* buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e5560ff7
AS
12012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2
3 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
5 * character.c (_fetch_multibyte_char_p): Remove.
6 * alloc.c: Include "character.h" before "buffer.h".
7 * bidi.c: Likewise.
8 * buffer.c: Likewise.
9 * bytecode.c: Likewise.
10 * callint.c: Likewise.
11 * callproc.c: Likewise.
12 * casefiddle.c: Likewise.
13 * casetab.c: Likewise.
14 * category.c: Likewise.
15 * cmds.c: Likewise.
16 * coding.c: Likewise.
17 * composite.c: Likewise.
18 * dired.c: Likewise.
19 * dispnew.c: Likewise.
20 * doc.c: Likewise.
21 * dosfns.c: Likewise.
22 * editfns.c: Likewise.
23 * emacs.c: Likewise.
24 * fileio.c: Likewise.
25 * filelock.c: Likewise.
26 * font.c: Likewise.
27 * fontset.c: Likewise.
28 * fringe.c: Likewise.
29 * indent.c: Likewise.
30 * insdel.c: Likewise.
31 * intervals.c: Likewise.
32 * keyboard.c: Likewise.
33 * keymap.c: Likewise.
34 * lread.c: Likewise.
35 * macros.c: Likewise.
36 * marker.c: Likewise.
37 * minibuf.c: Likewise.
38 * nsfns.m: Likewise.
39 * nsmenu.m: Likewise.
40 * print.c: Likewise.
41 * process.c: Likewise.
42 * regex.c: Likewise.
43 * region-cache.c: Likewise.
44 * search.c: Likewise.
45 * syntax.c: Likewise.
46 * term.c: Likewise.
47 * textprop.c: Likewise.
48 * undo.c: Likewise.
49 * unexsol.c: Likewise.
50 * w16select.c: Likewise.
51 * w32fns.c: Likewise.
52 * w32menu.c: Likewise.
53 * window.c: Likewise.
54 * xdisp.c: Likewise.
55 * xfns.c: Likewise.
56 * xmenu.c: Likewise.
57 * xml.c: Likewise.
58 * xselect.c: Likewise.
59
2f07e6af
EZ
602012-06-16 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
63 all the glyphs of the glyph row came from strings, and we have no
64 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
65 row.
66 (handle_face_prop): Use chunk-relative overlay string index when
67 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
68 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
69 the rightmost. (Bug#11720)
2f07e6af 70
29b83cec
AS
712012-06-16 Andreas Schwab <schwab@linux-m68k.org>
72
73 * category.h (CHAR_HAS_CATEGORY): Define as inline.
74 (CATEGORY_MEMBER): Enforce 1/0 value.
75 * category.c (_temp_category_set): Remove.
76
4c5501e9
EZ
772012-06-16 Eli Zaretskii <eliz@gnu.org>
78
79 * window.c (Fdelete_other_windows_internal)
80 (Fdelete_window_internal): Don't access frame's mouse highlight
81 info of the initial frame. (Bug#11677)
82
2b570124
PE
832012-06-14 Paul Eggert <eggert@cs.ucla.edu>
84
e93864f9
PE
85 * .gdbinit (xgetint): Fix recently-introduced paren typo.
86 Assume USE_2_TAGS_FOR_INTS.
87 (xreload): Adjust $tagmask width to match recent lisp.h change.
88
2b570124
PE
89 Simplify lisp.h in minor ways that should not affect code.
90 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
91 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
92 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
93 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
94 (INTTYPEBITS): New macro, for clarity.
95 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
96 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
97 now that USE_LSB_TAG is always defined.
98 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
99 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
100
81755f69
JB
1012012-06-13 Juanma Barranquero <lekktu@gmail.com>
102
103 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
104
16192a57
GM
1052012-06-13 Glenn Morris <rgm@gnu.org>
106
107 * s/bsd-common.h (BSD4_3):
108 * s/usg5-4-common.h (USG5_4): No longer define; unused.
109
646b5f55
AS
1102012-06-13 Andreas Schwab <schwab@linux-m68k.org>
111
112 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
113 instead of union.
114 (XLI, XIL): Define.
115 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
116 them.
117 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
118 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
119 * alloc.c (widen_to_Lisp_Object): Removed.
120 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
121 * frame.c (delete_frame): Remove outdated comment.
122 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
123 USE_LISP_UNION_TYPE.
124 (Fw32_unregister_hot_key): Likewise.
125 (Fw32_toggle_lock_key): Likewise.
126 * w32menu.c (add_menu_item): Likewise.
127 (w32_menu_display_help): Use XIL instead of checking
128 USE_LISP_UNION_TYPE.
129 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
130 (init_heap): Likewise.
131 * w32term.c (w32_read_socket): Update comment.
132
1d3823c9
GM
1332012-06-13 Glenn Morris <rgm@gnu.org>
134
c62ff706
GM
135 * s/usg5-4-common.h, src/s/unixware.h:
136 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
137
1d3823c9
GM
138 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
139
bfe3e0a2
PE
1402012-06-13 Paul Eggert <eggert@cs.ucla.edu>
141
142 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
143 * alloc.c (make_number) [!defined make_number]:
144 Remove, as lisp.h always defines this now.
145 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
146 (roundup_size): Verify that it is a power of 2.
147 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
148 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
149 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
150 -DUSE_LSB_TAG=0, to override the automatically-selected default.
151 USE_LSB_TAG now is always defined to be either 0 or 1.
152 All uses changed.
153 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
154 code works fine either way, and efficiency is not a concern here,
155 as the union type is for debugging, not for production.
156 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
157 Use an inline function on all platforms when using the union type,
158 since this is simpler and 'static inline' can be used portably
159 within Emacs now.
160 (LISP_INITIALLY_ZERO): New macro.
161 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
162 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
163
45fa9c0f
GM
1642012-06-12 Glenn Morris <rgm@gnu.org>
165
b4492cba
GM
166 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
167
168 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 169
45fa9c0f
GM
170 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
171 Move BROKEN_SIGIO to configure.
172
173 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
174 Move NO_TERMIO to configure.
175
0e25d334
CY
1762012-06-12 Chong Yidong <cyd@gnu.org>
177
178 * image.c (imagemagick_load_image): Use MagickFlattenImage if
179 MagickMergeImageLayers is undefined. Use pixel pusher loop if
180 MagickExportImagePixels is undefined.
181
43682bb6
PE
1822012-06-12 Paul Eggert <eggert@cs.ucla.edu>
183
184 * image.c (imagemagick_load_image): Remove unused label.
185
a9be7d2b
GM
1862012-06-11 Glenn Morris <rgm@gnu.org>
187
188 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
189 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
190 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
191 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
192
3017f87f
SM
1932012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
194
195 * alloc.c (make_byte_code): New function.
196 (Fmake_byte_code): Use it. Don't purify here.
197 * lread.c (read1): Use it as well to avoid extra allocation.
198
1b9b4cf4
CY
1992012-06-11 Chong Yidong <cyd@gnu.org>
200
201 * image.c (imagemagick_load_image): Implement transparency.
202
95988fcf
AS
2032012-06-10 Andreas Schwab <schwab@linux-m68k.org>
204
205 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
206 account for preceding backslashes. (Bug#11663)
207
cd4eb164
CY
2082012-06-09 Chong Yidong <cyd@gnu.org>
209
210 * term.c: Support italics in capable terminals (Bug#9652).
211 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
212 (turn_on_face): Output using TS_enter_italic_mode if available.
213 Don't handle unused blinking and alt-charset cases.
214 (turn_off_face): Handle italic case; discard unused tty_blinking_p
215 and tty_alt_charset_p cases.
216 (tty_capable_p, init_tty): Support italics.
217
218 * termchar.h (struct tty_display_info): Add field for italics.
219 Remove unused blink field.
220
221 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
222 Handle slant.
223
224 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
225 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
226 tty_alt_charset_p. Add tty_italic_p.
227
ff88beb8
MA
2282012-06-09 Michael Albinus <michael.albinus@gmx.de>
229
230 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
231 dbus_type_is_basic if available.
232 (xd_extract_signed, xd_extract_unsigned): Rename from
233 extract_signed and extract_unsigned, respectively. Adapt callers.
234
44286096
CY
2352012-06-09 Chong Yidong <cyd@gnu.org>
236
1682701f
CY
237 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
238
44286096
CY
239 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
240 case (Bug#9752).
241
d86feb17
PE
2422012-06-08 Paul Eggert <eggert@cs.ucla.edu>
243
244 * xdisp.c (vmessage): Treat frame message as multibyte.
245 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
246 would generate the diagnostic "Making \302\247 buffer-local while
247 let-bound!".
248
d5c20fe8
EZ
2492012-06-08 Eli Zaretskii <eliz@gnu.org>
250
251 * dispnew.c (showing_window_margins_p): Undo last change, which
252 was done due to an inadvertent commit.
253 (adjust_frame_glyphs_for_frame_redisplay): Do call
254 showing_window_margins_p.
255
513749ee
SM
2562012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * eval.c (Fmake_var_non_special): New primitive.
259 (syms_of_eval): Defsubr it.
260 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
261
d4a8f5c1
JB
2622012-06-08 Juanma Barranquero <lekktu@gmail.com>
263
264 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
265 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
266
8bbbc977
EZ
2672012-06-08 Eli Zaretskii <eliz@gnu.org>
268
269 * alloc.c (allocate_vectorlike): Fix last change.
270
f3372c87
DA
2712012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
272
273 Block-based vector allocation of small vectors.
274 * lisp.h (struct vectorlike_header): New field `nbytes',
275 adjust comment accordingly.
276 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
277 to denote vector blocks. Adjust users (live_vector_p,
278 mark_maybe_pointer, valid_lisp_object_p) accordingly.
279 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
280 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
281 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
282 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
283 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
284 (roundup_size): New constant.
285 (struct vector_block): New data type.
286 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 287 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
288 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
289 (sweep_vectors): New functions.
290 (allocate_vectorlike): Return `zero_vector' as the only vector of
291 0 items. Allocate new vector from block if vector size is less than
292 or equal to VBLOCK_BYTES_MAX.
293 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
294 (init_alloc_once): Add call to init_vectors.
295
4f18a4ed
SM
2962012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
297
298 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
299
86f158bc
PE
3002012-06-07 Paul Eggert <eggert@cs.ucla.edu>
301
302 * doprnt.c (doprnt): Truncate multibyte char correctly.
303 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
304 would mishandle a string argument "Xc" if X was a multibyte
305 character of length 2: it would truncate after X's first byte
306 rather than including all of X.
307
c5cfcbe0
CY
3082012-06-06 Chong Yidong <cyd@gnu.org>
309
310 * buffer.c (word_wrap): Doc fix.
311
c05cf390
PE
3122012-06-04 Paul Eggert <eggert@cs.ucla.edu>
313
314 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
315
0c3461de
GM
3162012-06-03 Glenn Morris <rgm@gnu.org>
317
318 * xdisp.c (tool-bar-style): Doc fix.
319
c71232db
UM
3202012-06-03 Ulrich Müller <ulm@gentoo.org>
321
322 * Makefile.in (PAXCTL): Define.
323 (temacs$(EXEEXT)): Disable memory randomization for the temacs
324 binary via PaX flags if the paxctl utility is available.
325 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
326 Restore PaX flags to their default. (Bug#11398)
327
383f7350
CY
3282012-06-03 Chong Yidong <cyd@gnu.org>
329
330 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
331 buffer (Bug#11226).
332
5f2c76c6
CY
3332012-06-03 Chong Yidong <cyd@gnu.org>
334
335 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
336 (note_mode_line_or_margin_highlight): If there is no help echo,
337 use mode-line-default-help-echo. Handle the case where the mouse
338 position is past the end of the mode line string.
339
340 * buffer.c (buffer_local_value_1): New function, split from
341 Fbuffer_local_value; can return Qunbound.
342 (Fbuffer_local_value): Use it.
343 (Vmode_line_format): Docstring tweaks.
344
773d47f6
PE
3452012-06-02 Paul Eggert <eggert@cs.ucla.edu>
346
347 * sysdep.c (system_process_attributes): Improve comment.
348
f2d6a3df
SM
3492012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
350
351 * keyboard.c: Export real-this-command to Elisp.
352 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
353 and DEFVAR it. Update all users.
354
63810350
PE
3552012-06-02 Paul Eggert <eggert@cs.ucla.edu>
356
7bd5c1f4
PE
357 * minibuf.c (Fassoc_string): Remove duplicate declaration.
358
63810350
PE
359 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
360 Convert pctcpu and pctmem to Lisp float properly.
361 Let the compiler fold better, as 100.0/0x8000 is exact.
362
a2821611
AS
3632012-06-02 Andreas Schwab <schwab@linux-m68k.org>
364
365 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
366 cons_block.
367
5fceba1d
PE
3682012-06-01 Paul Eggert <eggert@cs.ucla.edu>
369
370 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
371
c98ff5dd
DA
3722012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
373
374 For a 'struct window', replace some Lisp_Object fields to
375 bitfields where appropriate, remove unused fields.
376 * window.h (struct window): Remove unused 'last_mark_x' and
377 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
378 change it's type from Lisp_Object to bitfield.
379 Change type of 'force_start', 'optional_new_start',
380 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
381 fields from Lisp_Object to bitfield. Adjust users accordingly.
382
ca34e0be
PE
3832012-05-31 Paul Eggert <eggert@cs.ucla.edu>
384
385 Pacify gcc -Wdouble-precision when using Xaw.
386 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
387 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
388 Use 'float' consistently, rather than 'float' in most places
389 and 'double' in a couple of places.
390
efc00ab1 3912012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
392
393 * xdisp.c (handle_stop): Detect whether we have overlay strings
394 loaded by testing it->current.overlay_string_index to be
395 non-negative, instead of checking whether n_overlay_strings is
396 positive. (Bug#11587)
397
efc00ab1 3982012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
399
400 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
401
402 * doc.c (Fsubstitute_command_keys): Doc fix.
403
efc00ab1 4042012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
405
406 * search.c (search_buffer): Remove calls to
407 r_alloc_inhibit_buffer_relocation, as it is now called by
408 maybe_unify_char, which was the cause of relocation of buffer text
409 in bug#11519.
410
efc00ab1 4112012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
412
413 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
414 for the duration of call to load_charset, to avoid problems with
415 callers of maybe_unify_char that access buffer text through C
416 pointers.
417
418 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
419 decrement the inhibition flag, instead of just setting or
420 resetting it.
421
ba93a187
PE
4222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
423
424 Remove obsolete '#define static' cruft.
425 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
426 This #undef was "temporary" in 2000; it is no longer needed
427 now that '#define static' has gone away.
428 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
429 (gray_bitmap_bits): Remove; no longer needed.
430 All uses replaced with definiens.
431 * xterm.c: Include "bitmaps/gray.xbm".
432
9e4bf381
PE
4332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
434
435 Clean up __executable_start, monstartup when --enable-profiling.
436 The following changes affect the code only when profiling.
437 * dispnew.c (__executable_start): Rename from safe_bcopy.
438 Define only on platforms that need it.
439 * emacs.c: Include <sys/gmon.h> when profiling.
440 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
441 (__executable_start): Remove decl, since lisp.h does it now.
442 (safe_bcopy): Remove decl; no longer has that name.
443 (main): Coalesce #if into single bit of code, for simplicity.
444 Cast pointers to uintptr_t, since standard libraries want integers
445 and not pointers.
446 * lisp.h (__executable_start): New decl.
447
32d72c2f
GM
4482012-05-31 Glenn Morris <rgm@gnu.org>
449
450 * image.c (Fimagemagick_types): Doc fix.
451
baac5bc7
JM
4522012-05-30 Jim Meyering <meyering@redhat.com>
453
454 * callproc.c (Fcall_process_region): Include directory component
455 in mkstemp error message (Bug#11586).
456
72cb32cf
PE
4572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
458
459 * alloc.c, lisp.h (make_pure_vector): Now static.
460
61b108cc
SM
4612012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
462
463 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
464 Move to byte-run.el.
465 (Fautoload): Do the hash-doc more carefully.
466 * data.c (Fdefalias): Purify definition, except for keymaps.
467 (Qdefun): Move from eval.c.
468 * lisp.h (Qdefun): Remove.
469 * lread.c (read1): Tiny simplification.
470
471fe23d
TN
4712012-05-29 Troels Nielsen <bn.troels@gmail.com>
472
934f3f58 473 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
474 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
475 Bug#9642, but explicitly check that the buffer the overlay would
476 be moved to is live and rearrange lines to make sure that errors
477 will not put the overlay in an inconsistent state.
478 (Fdelete_overlay): Cosmetics.
479
85d0efd1
EZ
4802012-05-28 Eli Zaretskii <eliz@gnu.org>
481
482 * w32term.c (my_bring_window_to_top): New function.
483 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
484 could be different from the original one.
485 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
486 (Bug#11513)
487
488 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
489 by calling BringWindowToTop.
490
491 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
492 (WM_EMACS_END): Increase by one.
493
da92a98c
PE
4942012-05-28 Paul Eggert <eggert@cs.ucla.edu>
495
496 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
497 This avoids undefined behavior that might cause the eassert
498 to not catch an out-of-range value.
499
74d1f848
JB
5002012-05-28 Juanma Barranquero <lekktu@gmail.com>
501
502 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
503 Update dependencies.
504
9e1a06fc
EZ
5052012-05-27 Eli Zaretskii <eliz@gnu.org>
506
507 * bidi.c (bidi_mirror_char): Fix last change.
508
f3dd7312
AS
5092012-05-27 Andreas Schwab <schwab@linux-m68k.org>
510
511 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
512 when referring to sectname field in printf format.
513
81899c91
PE
5142012-05-27 Paul Eggert <eggert@cs.ucla.edu>
515
57b81a9f
PE
516 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
517 Only r_alloc_inhibit_buffer_relocation needed to be added;
518 the others were already declared.
519
81899c91
PE
520 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
521 before checking whether it's out of range. Put the check inside
522 eassert. See
523 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
524
33017faf 5252012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
526
527 * callproc.c (Fcall_process): Restore a line that was accidentally
528 commented out in the 2011-02-13 change (bug#11547).
529
33017faf 5302012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
531
532 * lisp.h [REL_ALLOC]: Add prototypes for external functions
533 defined on ralloc.c.
534
535 * buffer.c [REL_ALLOC]: Remove prototypes of
536 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
537 they are now on lisp.h.
538
539 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
540
541 * search.c (search_buffer): Use it to inhibit relocation of buffer
542 text while re_search_2 is doing its job, because re_search_2 is
543 passed C pointers to buffer text. (Bug#11519)
544
23415acf
EZ
545 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
546 Update value to 24.
547
44e27368
EZ
548 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
549 state after an additional call to move_it_in_display_line_to, keep
550 the values of it->max_ascent and it->max_descent found for the
551 entire line.
552 (pos_visible_p): Revert the comparison against bottom_y to what it
553 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
554 (Bug#11464)
555
c1892f11
PE
5562012-05-26 Paul Eggert <eggert@cs.ucla.edu>
557
558 Fix coding-related core dumps with gcc -ftrapv.
559 The code was computing A - B, where A and B are pointers, and B is
560 random garbage. This can lead to core dumps on platforms that
561 have special pointer registers, and it also leads to core dumps on
562 x86-64 when compiled with gcc -ftrapv. The fix is to compute
563 A - B only when B is initialized properly.
564 * coding.c (coding_set_source, coding_set_destination): Return void.
565 (coding_change_source, coding_change_destinations): New functions,
566 with the old behaviors of coding_set_source and coding_set_destination.
567 All callers that need an offset changed to use these new functions.
568
eb7afdad
GM
5692012-05-26 Glenn Morris <rgm@gnu.org>
570
571 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
572
f12fdf02
EZ
5732012-05-26 Eli Zaretskii <eliz@gnu.org>
574
53a63be6 575 Extend mouse support on W32 text-mode console.
61b108cc
SM
576 * xdisp.c (draw_row_with_mouse_face):
577 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 578
eb3f6f01 579 * w32console.c: Include window.h.
61b108cc
SM
580 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
581 New functions.
eb3f6f01
EZ
582 (initialize_w32_display): Initialize mouse-highlight data.
583
53a63be6
EZ
584 * w32inevt.c: Include termchar.h and window.h.
585 (do_mouse_event): Support mouse-autoselect-window. When the mouse
586 moves, call note_mouse_highlight. If help_echo changed, call
587 gen_help_event to produce help-echo message in the echo area.
588 Call clear_mouse_face if mouse_face_hidden is set in the mouse
589 highlight info.
590
4cfd81f6
PE
5912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
592
593 * lread.c (read1): Simplify slightly to avoid an overflow warning
594 with GCC 4.7.0 on x86-64.
595
4446092a
EZ
5962012-05-26 Eli Zaretskii <eliz@gnu.org>
597
598 * bidi.c (bidi_mirror_char): Revert last change: an int is
599 definitely wide enough here.
600
42b2a986 6012012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 602
42b2a986 603 Fix integer width and related bugs (Bug#9874).
eb106a49 604 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
605 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
606 (string_bytes, check_sblock, allocate_string_data):
607 (compact_small_strings, Fmake_bool_vector, make_string)
608 (make_unibyte_string, make_multibyte_string)
609 (make_string_from_bytes, make_specified_string)
610 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
611 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
612 (mark_vectorlike):
613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
614 (allocate_pseudovector):
615 Use int, not EMACS_INT, where int is wide enough.
616 (inhibit_garbage_collection, Fgarbage_collect):
617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
618 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
619 int might not be wide enough.
620 (bidi_cache_search, bidi_cache_find, bidi_init_it)
621 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
622 (bidi_at_paragraph_end, bidi_find_paragraph_start)
623 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
624 (bidi_level_of_next_char, bidi_move_to_visually_next):
625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
626 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
627 (Fkill_buffer, Fset_buffer_major_mode)
628 (advance_to_char_boundary, Fbuffer_swap_text)
629 (Fset_buffer_multibyte, overlays_at, overlays_in)
630 (overlay_touches_p, struct sortvec, record_overlay_string)
631 (overlay_strings, recenter_overlay_lists)
632 (adjust_overlays_for_insert, adjust_overlays_for_delete)
633 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
634 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
635 (Foverlay_recenter, last_overlay_modification_hooks_used)
636 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
638 (validate_region): Omit unnecessary test for b <= e,
639 since that's guaranteed by the previous test.
d311d28c
PE
640 (adjust_overlays_for_delete): Avoid pos + length overflow.
641 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
642 (report_overlay_modification):
643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
644 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
645 Omit pointer cast, which isn't needed anyway, and doesn't work
646 after the EMACS_INT -> ptrdiff_t change.
02481186 647 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
648 * buffer.h: Adjust decls to match defn changes elsewhere.
649 (struct buffer_text, struct buffer):
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
652 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
653 not int, to avoid needless 32-bit limit on 64-bit hosts.
654 (exec_byte_code): Use tighter memory-full test, one that checks
655 for alloca overflow. Don't compute the address of the object just
656 before an array, as that's not portable. Use EMACS_INT, not
657 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
658 * callint.c (Fcall_interactively):
659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
660 * callproc.c (call_process_kill, Fcall_process):
661 Don't assume pid_t fits into an Emacs fixnum.
662 (call_process_cleanup, Fcall_process, child_setup):
663 Don't assume pid_t fits into int.
664 (call_process_cleanup, Fcall_process, delete_temp_file)
665 (Fcall_process_region):
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
667 (Fcall_process): Simplify handling of volatile integers.
668 Use int, not EMACS_INT, where int will do.
669 * casefiddle.c (casify_object, casify_region, operate_on_word)
670 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
672 (casify_object): Avoid integer overflow when overallocating buffer.
673 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 674 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
675 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
676 * category.h (CATEGORYP): Don't assume arg is nonnegative.
677 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
678 integers are now checked earlier. All uses replaced with XINT.
679 (ccl_driver):
680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
681 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
682 (ccl_driver, Fregister_code_conversion_map):
683 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
684 (resolve_symbol_ccl_program): Check that vector header is in range.
685 Always copy the vector, so that we can check its contents reliably
686 now rather than having to recheck each instruction as it's being
687 executed. Check that vector words fit in 'int'.
688 (ccl_get_compiled_code, Fregister_ccl_program)
689 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
690 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
691 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
692 contents are in range.
693 (Fccl_execute_on_string): Check that status is in range.
694 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
695 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
696 Accept and return EMACS_INT, not int, because callers can pass values
697 out of 'int' range.
698 (c_string_width, strwidth, lisp_string_width, chars_in_text)
699 (multibyte_chars_in_text, parse_str_as_multibyte)
700 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
701 (str_as_unibyte, str_to_unibyte, string_count_byte8)
702 (string_escape_byte8, Fget_byte):
703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 704 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
705 avoid mishandling large integers.
706 * character.h: Adjust decls to match defn changes elsewhere.
707 * charset.c (load_charset_map_from_file, find_charsets_in_text)
708 (Ffind_charset_region):
709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
710 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
711 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 712 Don't assume fixnum fits in int.
d311d28c
PE
713 (load_charset_map_from_vector, Fmap_charset_chars):
714 Remove now-unnecessary CHECK_NATNUMs.
715 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
716 Don't rely on undefined behavior with signed left shift overflow.
717 Don't assume unsigned int fits into fixnum, or that fixnum fits
718 into unsigned int. Don't require max_code to be a valid fixnum;
719 that's not true for gb10830 4-byte on a 32-bit host. Allow
720 invalid_code to be a cons, for the same reason. Require code_offset
721 to be a character. Avoid int overflow if max_char is close
722 to INT_MAX.
723 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
724 this is intended anyway and avoids some undefined behavior.
725 (load_charset_map): Pass unsigned, not int, as 2nd arg of
726 INDEX_TO_CODE_POINT, as that's what it expects.
727 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
728 * charset.h (DECODE_CHAR): Return int, not unsigned;
729 this is what was intended anyway, and it avoids undefined behavior.
730 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
731 integer-overflow issues.
732 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
733 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
734 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
735 * chartab.c (Fmake_char_table, Fset_char_table_range)
736 (uniprop_get_decoder, uniprop_get_encoder):
737 Don't assume fixnum fits in int.
738 * cmds.c (move_point): New function, that does the gist of
739 Fforward_char and Fbackward_char, but does so while checking
740 for integer overflow more accurately.
c96e5d6a 741 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
742 (Fforward_line, Fend_of_line, internal_self_insert)
743 (internal_self_insert):
744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
745 Fix a FIXME, by checking for integer overflow when calculating
746 target_clm and actual_clm.
747 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 748 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
749 (ASSURE_DESTINATION, coding_alloc_by_realloc)
750 (coding_alloc_by_making_gap, alloc_destination)
751 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
752 (encode_coding_utf_16, detect_coding_emacs_mule)
753 (decode_coding_emacs_mule, encode_coding_emacs_mule)
754 (detect_coding_iso_2022, decode_coding_iso_2022)
755 (encode_invocation_designation, encode_designation_at_bol)
756 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
757 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
758 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
759 (encode_coding_ccl, encode_coding_raw_text)
760 (detect_coding_charset, decode_coding_charset)
761 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
762 (produce_composition, produce_charset, produce_annotation)
763 (decode_coding, handle_composition_annotation)
764 (handle_charset_annotation, consume_chars, decode_coding_gap)
765 (decode_coding_object, encode_coding_object, detect_coding_system)
766 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
767 (code_convert_region, code_convert_string)
8f50130c
PE
768 (Fdefine_coding_system_internal)
769 (coding_set_source, coding_set_destination):
d311d28c
PE
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
772 (Fdefine_coding_system_internal):
773 Don't assume fixnums fit in int.
774 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 775 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
776 (Funencodable_char_position, Fcheck_coding_systems_region)
777 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 779 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 780 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 781 Don't access memory outside of the args array.
d311d28c 782 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
783 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
784 result of ENCODE_CHAR.
d311d28c
PE
785 * coding.h: Adjust decls to match defn changes elsewhere.
786 (struct coding_system):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 * composite.c (get_composition_id, find_composition)
789 (run_composition_function, update_compositions)
790 (compose_text, composition_gstring_put_cache)
791 (composition_gstring_p, composition_gstring_width)
792 (fill_gstring_header, fill_gstring_body, autocmp_chars)
793 (composition_compute_stop_pos, composition_reseat_it)
794 (composition_update_it, struct position_record)
795 (find_automatic_composition, composition_adjust_point)
796 (Fcomposition_get_gstring, Ffind_composition_internal):
797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
798 (update_compositions):
799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
800 * composite.h: Adjust decls to match defn changes elsewhere.
801 (struct composition):
802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
803 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
804 Do not attempt to compute the address of the object just before a
805 buffer; this is not portable.
806 (Faref, Faset):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (Faset): Use int, not EMACS_INT, where int is wide enough.
809 (Fstring_to_number): Don't assume fixnums fit in int.
810 (Frem): Don't assume arg is nonnegative.
811 * dbusbind.c (xd_append_arg): Check for integers out of range.
812 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 813 (extract_signed, extract_unsigned): New functions.
243e0530
PE
814 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
815 (xd_get_connection_references): Return ptrdiff_t, not int.
816 All uses changed.
817 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
818 (xd_read_message_1):
819 Use int, not unsigned, where the dbus API uses int.
820 (Fdbus_message_internal): Don't overflow mtype.
821 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
822 * dired.c (directory_files_internal, file_name_completion, scmp)
823 (file_name_completion_stat):
824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
825 (file_name_completion): Don't overflow matchcount.
826 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
827 * dispextern.h: Adjust decls to match defn changes elsewhere.
828 (struct text_pos, struct glyph, struct bidi_saved_info)
829 (struct bidi_string_data, struct bidi_it, struct composition_it)
830 (struct it):
831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
832 (struct display_pos, struct composition_it, struct it):
833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
834 * dispnew.c (increment_matrix_positions)
835 (increment_row_positions, mode_line_string)
836 (marginal_area_string):
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 838 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
840 (duration_to_sec_usec): New function, to check for overflow better.
841 (Fsleep_for, sit_for): Use it.
842 * doc.c (get_doc_string, store_function_docstring):
843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
844 (get_doc_string, Fsnarf_documentation):
845 Use int, not EMACS_INT, where int is wide enough.
846 (get_doc_string):
847 Use SAFE_ALLOCA, not alloca.
848 Check for overflow when converting EMACS_INT to off_t.
849 * doprnt.c (doprnt):
850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
851 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
852 Don't assume uid_t fits into fixnum.
853 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
854 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
855 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
856 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
857 (general_insert_function)
858 (Finsert_char, make_buffer_string, make_buffer_string_both)
859 (update_buffer_properties, Fbuffer_substring)
860 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
861 (Fsubst_char_in_region, check_translation)
862 (Ftranslate_region_internal, save_restriction_restore, Fformat)
863 (transpose_markers, Ftranspose_regions):
864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 (clip_to_bounds): Move to lisp.h as an inline function).
866 (Fconstrain_to_field): Don't assume integers are nonnegative.
867 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
868 (Fsubst_char_in_region, Fsave_restriction):
869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
870 (Femacs_pid): Don't assume pid_t fits into fixnum.
871 (lo_time): Use int, not EMACS_INT, when int suffices.
872 (lisp_time_argument): Check for usec out of range.
873 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
874 (Fuser_login_name, Fuser_full_name): Signal an error
875 if a uid argument is out of range, rather than relying on
876 undefined behavior.
c8d5c857
PE
877 (Fformat_time_string): Remove now-unnecessary check.
878 lisp_time_argument checks for out-of-range usec now.
243e0530 879 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
880 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
881 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
882 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
883 (init_cmdargs, Fdump_emacs):
884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
885 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
886 the bottom (typically) 32 bits of the fixnum.
887 * eval.c (specpdl_size, call_debugger):
888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
889 (when_entered_debugger, Fbacktrace_debug):
890 Don't assume fixnum can fit in int.
891 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
892 the object just before a buffer; this is not portable.
893 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
894 (grow_specpdl, unbind_to):
895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
896 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
897 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 898 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
899 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
900 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
902 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
903 (a_write, e_write):
904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
905 (Fcopy_file, non_regular_nbytes, read_non_regular)
906 (Finsert_file_contents):
907 Use int, not EMACS_INT, where int is wide enough.
908 (READ_BUF_SIZE): Verify that it fits in int.
909 (Finsert_file_contents): Check that counts are in proper range,
910 rather than assuming fixnums fit into ptrdiff_t etc.
911 Don't assume fixnums fit into int.
125b3835 912 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
913 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
914 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
915 (string_char_to_byte, string_byte_to_char)
916 (string_make_multibyte, string_to_multibyte)
917 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
918 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
919 (substring_both, Fdelete, internal_equal, Ffillarray)
920 (Fclear_string, mapcar1)
921 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
922 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
923 (larger_vector, make_hash_table, maybe_resize_hash_table)
924 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
925 (Fmaphash, secure_hash):
926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
927 (concat): Check for string index and length overflow.
928 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
929 (Frequire):
930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
931 (larger_vector): New API (vec, incr_min, size_max) replaces old
932 one (vec, new_size, init). This catches size overflow.
933 INIT was removed because it was always Qnil.
934 All callers changed.
935 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
936 the upper bound on a hash table index size.
937 (make_hash_table, maybe_resize_hash_table): Use it.
938 (secure_hash): Computer start_byte and end_byte only after
939 they're known to be in ptrdiff_t range.
940 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
941 (Ffont_get_glyphs, Ffont_at):
942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
943 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
944 (Flist_fonts, Fopen_font):
945 Don't assume fixnum can fit in int.
946 (check_gstring): Don't assume index can fit in int.
947 (font_match_p): Check that fixnum is a character, not a nonnegative
948 fixnum, since the later code needs to stuff it into an int.
949 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
950 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
951 conversion overflow issues.
952 (Fopen_font): Check for integer out of range.
953 (Ffont_get_glyphs): Don't assume index can fit in int.
954 * font.h: Adjust decls to match defn changes elsewhere.
955 * fontset.c (reorder_font_vector): Redo score calculation to avoid
956 integer overflow.
957 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
958 printmax_t, where ptrdiff_t is wide enough.
959 (Finternal_char_font):
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
961 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
962 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
963 (Fset_frame_position, x_set_frame_parameters)
964 (x_set_line_spacing, x_set_border_width)
965 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
966 Check that fixnums are in proper range for system types.
967 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
969 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
970 Use SAFE_ALLOCA_LISP, not alloca.
971 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
972 intptr_t is wide enough.
973 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
974 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
975 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
976 Check for fixnum out of range.
977 * ftfont.c (ftfont_list): Don't assume index fits in int.
978 Check that fixnums are in proper range for system types.
979 (ftfont_shape_by_flt):
980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
981 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
983 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
984 Check that fixnums are in proper range for system types.
985 * gnutls.h: Adjust decls to match defn changes elsewhere.
986 * gtkutil.c (xg_dialog_run):
987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
988 (update_frame_tool_bar):
989 Check that fixnums are in proper range for system types.
990 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 991 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
992 * indent.c (last_known_column, last_known_column_point):
993 (current_column_bol_cache):
994 (skip_invisible, current_column, check_display_width):
995 (check_display_width, scan_for_column, current_column_1)
996 (Findent_to, Fcurrent_indentation, position_indentation)
997 (indented_beyond_p, Fmove_to_column, compute_motion):
998 (Fcompute_motion, Fvertical_motion):
999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1000 (last_known_column_modified): Use EMACS_INT, not int.
1001 (check_display_width):
1002 (Fcompute_motion):
1003 Check that fixnums and floats are in proper range for system types.
1004 (compute_motion): Don't assume index or fixnum fits in int.
1005 (compute_motion, Fcompute_motion):
1006 Use int, not EMACS_INT, when it is wide enough.
1007 (vmotion): Omit local var start_hpos that is always 0; that way
1008 we don't need to worry about overflow in expressions involving it.
1009 * indent.h: Adjust decls to match defn changes elsewhere.
1010 (struct position):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1012 Use int, not EMACS_INT, where int is wide enough.
1013 Remove unused members ovstring_chars_done and tab_offset;
1014 all uses removed.
1015 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1016 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1017 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1018 (make_gap, copy_text, insert, insert_and_inherit)
1019 (insert_before_markers, insert_before_markers_and_inherit)
1020 (insert_1, count_combining_before, count_combining_after)
1021 (insert_1_both, insert_from_string)
1022 (insert_from_string_before_markers, insert_from_string_1)
1023 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1024 (adjust_after_replace, adjust_after_insert, replace_range)
1025 (replace_range_2, del_range, del_range_1, del_range_byte)
1026 (del_range_both, del_range_2, modify_region)
1027 (prepare_to_modify_buffer, signal_before_change)
1028 (signal_after_change, Fcombine_after_change_execute):
1029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1030 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1031 (balance_an_interval, split_interval_right, split_interval_left)
1032 (find_interval, next_interval, update_interval)
1033 (adjust_intervals_for_insertion, delete_node, delete_interval)
1034 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1035 (static_offset_intervals, offset_intervals)
1036 (merge_interval_right, merge_interval_left, make_new_interval)
1037 (graft_intervals_into_buffer, temp_set_point_both)
1038 (temp_set_point, set_point, adjust_for_invis_intang)
1039 (set_point_both, move_if_not_intangible, get_property_and_range)
1040 (get_local_map, copy_intervals, copy_intervals_to_string)
1041 (compare_string_intervals, set_intervals_multibyte_1):
1042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1043 * intervals.h: Adjust decls to match defn changes elsewhere.
1044 (struct interval):
1045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1046 * keyboard.c (this_command_key_count, this_single_command_key_start)
1047 (before_command_key_count, before_command_echo_length, echo_now)
1048 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1049 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1050 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1051 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 (last_non_minibuf_size, last_point_position, echo_truncate)
1054 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1055 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1056 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1057 (stuff_buffered_input):
1058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1059 (last_auto_save, command_loop_1, read_char):
1060 Use EMACS_INT, not int, to avoid integer overflow.
1061 (record_char): Avoid overflow in total_keys computation.
1062 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1063 * keyboard.h: Adjust decls to match defn changes elsewhere.
1064 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1065 (Fkey_description, Fdescribe_vector, Flookup_key):
1066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1067 (click_position): New function, to check that positions are in range.
1068 (Fcurrent_active_maps):
1069 (describe_command):
1070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1071 (Faccessible_keymaps, Fkey_description):
1072 (preferred_sequence_p):
1073 Don't assume fixnum can fit into int.
1074 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1075 Check for integer overflow in size calculations.
1076 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1077 avoid mishandling large integers.
1078 * lisp.h: Adjust decls to match defn changes elsewhere.
1079 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1080 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1081 (struct Lisp_Marker):
1082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1083 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1084 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1085 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1086 All callers changed.
1087 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1088 Assume the arg has valid form, since it always does.
1089 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1090 unsigned integer system type.
1091 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1092 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1094 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1095 (duration_to_sec_usec): New decl.
1096 * lread.c (read_from_string_index, read_from_string_index_byte)
1097 (read_from_string_limit, readchar, unreadchar, openp)
1098 (read_internal_start, read1, oblookup):
1099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1100 (Fload, readevalloop, Feval_buffer, Feval_region):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (openp): Check for out-of-range argument to 'access'.
1103 (read1): Use int, not EMACS_INT, where int is wide enough.
1104 Don't assume fixnum fits into int.
6efdadfd 1105 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1106 (read_filtered_event): Use duration_to_sec_usec
1107 to do proper overflow checking on durations.
d311d28c
PE
1108 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1109 in size calculation.
1110 (Fexecute_kbd_macro):
1111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1112 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1113 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1114 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1115 (set_marker_both, set_marker_restricted_both, marker_position)
1116 (marker_byte_position, Fbuffer_has_markers_at):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1119 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1120 It now merely ensures that the menu is large enough, without
1121 necessarily growing it, as this avoids some integer overflow issues.
1122 All callers changed.
1123 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1125 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1126 Use SAFE_ALLOCA_LISP, not alloca.
1127 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1128 to EMACS_INT. Check that fixnums are in proper range for system types.
1129 * minibuf.c (minibuf_prompt_width, string_to_object)
1130 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1131 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1133 (get_minibuffer, read_minibuf_unwind):
1134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1135 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1136 this simplifies overflow checking. All callers changed.
1137 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1138 (Ftest_completion):
1139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1140 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1141 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1142 Check that fixnums are in proper range for system types.
1143 (Fx_create_frame, Fx_show_tip):
1144 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1145 * nsfont.m (ns_findfonts, nsfont_list_family):
1146 Don't assume fixnum fits in long.
1147 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1148 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1149 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1150 wide enough.
17fdb222 1151 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1153 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1154 (PRINTDECLARE, PRINTPREPARE):
1155 (strout, print_string):
1156 (print, print_preprocess, print_check_string_charset_prop)
1157 (print_object):
1158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1159 (PRINTDECLARE):
1160 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1163 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1164 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1165 (print_error_message): Use SAFE_ALLOCA, not alloca.
1166 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1167 (print_depth, new_backquote_output, print_number_index):
1168 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1169 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1170 (Fset_process_window_size, Fformat_network_address)
1171 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1172 (sigchld_handler):
d311d28c 1173 Check that fixnums are in proper range for system types.
d44287d4 1174 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1175 Check for process-ids out of pid_t range rather than relying on
1176 undefined behavior.
e4d81efc 1177 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1178 (Fformat_network_address, read_process_output, send_process)
1179 (Fprocess_send_region, status_notify):
1180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1181 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1182 (wait_reading_process_output, read_process_output, exec_sentinel):
1183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1184 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1185 (Faccept_process_output): Use duration_to_sec_usec to do proper
1186 overflow checking on durations.
dde14581
PE
1187 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1188 Don't assume pid_t fits in int.
02481186
PE
1189 * process.h (struct Lisp_Process): Members tick and update_tick
1190 are now of type EMACS_INT, not int.
b62b53e8
PE
1191 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1192 configured --with-wide-int.
d311d28c
PE
1193 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1194 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1195 * search.c (looking_at_1, string_match_1):
1196 (fast_string_match, fast_c_string_match_ignore_case)
1197 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1198 (scan_newline, find_before_next_newline, search_command)
1199 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1200 (set_search_regs, wordify):
1201 (Freplace_match):
1202 (Fmatch_data):
1203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1204 (string_match_1, search_buffer, set_search_regs):
1205 (Fmatch_data):
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 (wordify): Check for overflow in size calculation.
1208 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1209 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1210 Check that fixnums are in proper range for system types.
1211 * sound.c (struct sound_device)
1212 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1214 (Fplay_sound_internal):
1215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1216 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1217 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1218 (Fparse_partial_sexp):
1219 Don't assume fixnums can fit in int.
1220 (struct lisp_parse_state, find_start_pos, find_start_value)
1221 (find_start_value_byte, find_start_begv)
1222 (update_syntax_table, char_quoted, dec_bytepos)
1223 (find_defun_start, prev_char_comend_first, back_comment):
1224 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1225 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1227 (Finternal_describe_syntax_value): Check that match_lisp is a
1228 character, not an integer, since the code stuffs it into int.
1229 (scan_words, scan_sexps_forward):
1230 Check that fixnums are in proper range for system types.
1231 (Fforward_word):
1232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1233 (scan_sexps_forward):
1234 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1235 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1236 * syntax.h: Adjust decls to match defn changes elsewhere.
1237 (struct gl_state_s):
1238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1239 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1240 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1241 * sysdep.c (wait_for_termination_1, wait_for_termination)
1242 (interruptible_wait_for_termination, mkdir):
1243 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1244 (emacs_read, emacs_write):
1245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1246 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1247 and double all fit in int.
d311d28c
PE
1248 * term.c (set_tty_color_mode):
1249 Check that fixnums are in proper range for system types.
1250 * termhooks.h (struct input_event):
1251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1252 * textprop.c (validate_interval_range, interval_of)
1253 (Fadd_text_properties, set_text_properties_1)
1254 (Fremove_text_properties, Fremove_list_of_text_properties)
1255 (Ftext_property_any, Ftext_property_not_all)
1256 (copy_text_properties, text_property_list, extend_property_ranges)
1257 (verify_interval_modification):
1258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1259 (Fnext_single_char_property_change)
1260 (Fprevious_single_char_property_change):
1261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1262 (copy_text_properties):
1263 Check for integer overflow in index calculation.
d311d28c
PE
1264 * undo.c (last_boundary_position, record_point, record_insert)
1265 (record_delete, record_marker_adjustment, record_change)
1266 (record_property_change):
1267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1268 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1270 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1271 (Fx_hide_tip, Fx_file_dialog):
1272 * w32menu.c (set_frame_menubar):
1273 Use ptrdiff_t, not int, for consistency with rest of code.
1274 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1275 (select_window, Fdelete_other_windows_internal)
1276 (window_scroll_pixel_based, window_scroll_line_based)
1277 (Frecenter, Fset_window_configuration):
1278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1279 (Fset_window_hscroll, run_window_configuration_change_hook)
1280 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1281 (Fscroll_other_window, Frecenter):
d311d28c
PE
1282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1283 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1284 Don't assume fixnum fits in int.
1285 (Fset_window_scroll_bars):
1286 Check that fixnums are in proper range for system types.
1287 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1288 (string_pos, c_string_pos, number_of_chars, init_iterator)
1289 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1290 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1291 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1292 (face_before_or_after_it_pos, handle_invisible_prop)
1293 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1294 (display_prop_intangible_p, string_buffer_position_lim)
1295 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1296 (get_overlay_strings_1, get_overlay_strings)
1297 (iterate_out_of_display_property, forward_to_next_line_start)
1298 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1299 (get_next_display_element, set_iterator_to_next)
1300 (get_visually_first_element, compute_stop_pos_backwards)
1301 (handle_stop_backwards, next_element_from_buffer)
1302 (move_it_in_display_line_to, move_it_in_display_line)
1303 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1304 (add_to_log, message_dolog, message_log_check_duplicate)
1305 (message2, message2_nolog, message3, message3_nolog
1306 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1307 (current_message_1, truncate_echo_area, truncate_message_1)
1308 (set_message, set_message_1, store_mode_line_noprop)
1309 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1310 (text_outside_line_unchanged_p, check_point_in_composition)
1311 (reconsider_clip_changes)
1312 (redisplay_internal, set_cursor_from_row, try_scrolling)
1313 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1314 (redisplay_window, find_last_unchanged_at_beg_row)
1315 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1316 (trailing_whitespace_p, find_row_edges, display_line)
1317 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1318 (display_mode_element, store_mode_line_string)
1319 (pint2str, pint2hrstr, decode_mode_spec)
1320 (display_count_lines, display_string, draw_glyphs)
1321 (x_produce_glyphs, x_insert_glyphs)
1322 (rows_from_pos_range, mouse_face_from_buffer_pos)
1323 (fast_find_string_pos, mouse_face_from_string_pos)
1324 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1326 (safe_call, init_from_display_pos, handle_fontified_prop)
1327 (handle_single_display_spec, load_overlay_strings)
1328 (with_echo_area_buffer, setup_echo_area_for_printing)
1329 (display_echo_area, echo_area_display)
1330 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1331 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1332 (redisplay_window, dump_glyph_row, display_mode_line)
1333 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1334 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1336 (handle_single_display_spec, build_desired_tool_bar_string)
1337 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1338 (get_specified_cursor_type):
1339 Check that fixnums are in proper range for system types.
1340 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1341 (Flookup_image_map):
1342 Don't assume fixnums fit in int.
1343 (compare_overlay_entries):
1344 Avoid mishandling comparisons due to subtraction overflow.
1345 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1346 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1347 (handle_tool_bar_click):
1348 Use int, not unsigned, since we prefer signed and the signedness
1349 doesn't matter here.
1350 (get_next_display_element, next_element_from_display_vector):
1351 Use int, not EMACS_INT, when int is wide enough.
1352 (start_hourglass): Use duration_to_sec_usec to do proper
1353 overflow checking on durations.
1354 * xfaces.c (Fbitmap_spec_p):
1355 Check that fixnums are in proper range for system types.
1356 (compare_fonts_by_sort_order):
1357 Avoid mishandling comparisons due to subtraction overflow.
1358 (Fx_family_fonts, realize_basic_faces):
1359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1360 (Fx_family_fonts):
1361 Don't assume fixnum fits in int.
1362 Use SAFE_ALLOCA_LISP, not alloca.
1363 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1364 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1365 (face_at_buffer_position, face_for_overlay_string)
1366 (face_at_string_position):
1367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1368 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1369 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1370 (Fx_show_tip):
1371 Check that fixnums are in proper range for system types.
1372 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1373 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1375 (Fx_change_window_property): Don't assume fixnums fit in int.
1376 * xfont.c (xfont_chars_supported):
1377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1378 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1379 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1381 * xml.c (parse_region):
1382 * xrdb.c (magic_file_p):
1383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1384 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1385 (x_get_local_selection, x_reply_selection_request)
1386 (x_handle_selection_request, wait_for_property_change):
1387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1388 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1389 short is wide enough.
1390 (x_send_client_event): Don't assume fixnum fits in int.
1391 * xterm.c (x_x_to_emacs_modifiers):
1392 Don't assume EMACS_INT overflows nicely into int.
1393 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1394 may come from Lisp.
1395 (handle_one_xevent): NATNUMP can eval its arg twice.
1396 (x_connection_closed):
1397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1398 * xterm.h: Adjust decls to match defn changes elsewhere.
1399 (struct scroll_bar): Use struct vectorlike_header
1400 rather than rolling our own approximation.
1401 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1402
c6574eb5
GM
14032012-05-25 Glenn Morris <rgm@gnu.org>
1404
1405 * lisp.mk (lisp): Update for more files being compiled now.
1406
e8d32c7e
SM
14072012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1408
48def666
SM
1409 * lread.c: Remove `read_pure' which makes no difference.
1410 (read_pure): Remove var.
1411 (unreadpure): Remove function.
1412 (readevalloop): Don't call read_list with -1 flag.
1413 (read1, read_vector): Don't test read_pure any more.
1414 (read_list): Simplify.
1415
e8d32c7e
SM
1416 * fileio.c, character.h: Minor style tweaks.
1417
4b2addb7
DA
14182012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 * window.h (clip_changed): Remove useless declaration.
1421
584461b2
JB
14222012-05-22 Juanma Barranquero <lekktu@gmail.com>
1423
1424 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1425 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1426
34374650
PE
14272012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 Remove src/m/*.
1430 This directory predates autoconf and is no longer needed nowadays.
1431 Move its few remaining bits of functionality to where they're needed.
1432 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1433 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1434 * m/template.h: Remove.
1435 * Makefile.in (M_FILE): Remove. All uses removed.
1436 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1437 * lisp.h (USE_LSB_TAG):
1438 * mem-limits.h (EXCEEDS_LISP_PTR):
1439 Use VAL_MAX, not VALBITS, in #if.
1440 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1441 (EMACS_UINT): Define unconditionally now.
1442 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1443 (BITS_PER_EMACS_INT): New constants, replacing
1444 what used to be in config.h, but not useful in #if.
1445 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1446 define them any more.
1447 (VAL_MAX): New macro.
1448 (VALMASK): Use it.
1449 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1450 BITS_PER_EMACS_INT, in #if.
1451 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1452 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1453 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1454 * s/ms-w32.h (DATA_START):
1455 Move here from removed file m/intel386.h.
1456 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1457 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1458
261cb4bb
PE
14592012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1460
1461 Assume C89 or later.
1462 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1463 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1464 (xrealloc):
1465 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1466 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1467 * textprop.c, tparam.c (NULL): Remove.
1468 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1469 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1470 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1471 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1472 * xterm.c (input_signal_count): Assume volatile works.
1473
ff23cd9f
KB
14742012-05-21 Ken Brown <kbrown@cornell.edu>
1475
1476 * xgselect.c (xg_select): Fix first argument in call to 'select'
1477 (bug#11508).
1478
1b170bc6
KB
14792012-05-20 Ken Brown <kbrown@cornell.edu>
1480
1481 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1482 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1483
b2f4d39f
KB
14842012-05-19 Ken Brown <kbrown@cornell.edu>
1485
1486 * xfns.c (x_in_use): Remove `static' qualifier.
1487 * xterm.h (x_in_use): Declare.
1488 * xgselect.c: Include xterm.h.
1489 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1490 and `display_arg' (bug#9754).
1491
003fdae2
PE
14922012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1493
9232a6d9
PE
1494 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1495
003fdae2
PE
1496 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1497 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1498
784b56e2
EZ
14992012-05-18 Eli Zaretskii <eliz@gnu.org>
1500
1501 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1502
1503 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1504 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1505
1506 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1507 reference to image_cache->refcount.
1508 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1509
a0a79cde
JL
15102012-05-17 Juri Linkov <juri@jurta.org>
1511
1512 * search.c (Fword_search_regexp, Fword_search_backward)
1513 (Fword_search_forward, Fword_search_backward_lax)
1514 (Fword_search_forward_lax): Move functions to isearch.el
1515 (bug#10145, bug#11381).
1516
b0572523
PE
15172012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1520
9660f5fc
SM
15212012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * lread.c (init_obarray): Declare Qt and Qnil as special.
1524
4374de83
GM
15252012-05-14 Glenn Morris <rgm@gnu.org>
1526
1527 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1528 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1529
dc44c39a
PE
15302012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1531
078c97cb
PE
1532 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1533
dc44c39a
PE
1534 * unexaix.c: Port to more-recent AIX compilers.
1535 (report_error, report_error_1, make_hdr, copy_sym)
1536 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1537 Make arguments const char *, not char *, to avoid violations of C
1538 standard and to fix some AIX warnings reported by Gilles Pion.
1539
e18afed7 15402012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1541
1542 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1543 already have overlays loaded.
1544 (handle_single_display_spec): Before returning without displaying
1545 fringe bitmap, synchronize the bidi iterator with the main display
1546 iterator, by calling iterate_out_of_display_property.
1547 (iterate_out_of_display_property): Detect buffer iteration by
1548 testing that it->string is a Lisp string.
1549 (get_next_display_element): When the current object is exhausted,
1550 and there's something on it->stack, call set_iterator_to_next to
1551 proceed with what's on the stack, instead of returning zero.
1552 (set_iterator_to_next): If called at the end of a Lisp string,
1553 proceed to consider_string_end without incrementing string
1554 position. Don't increment display vector index past the end of
1555 the display vector. (Bug#11417)
c8fb9dc6
EZ
1556 (pos_visible_p): Don't report a position visible when move_it_to
1557 stopped at the last line of window, which happens to be scanned
1558 backwards by the bidi iteration. (Bug#11464)
ac268e67 1559
e18afed7 15602012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1561
1562 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1563 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1564 are on a TTY, and thus unable to display on the fringes.
1565 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1566 so we need to signal to the caller that this is a "replacing"
1567 display spec. This fixes display when the spec is invalid or we
1568 are on a TTY.
1569
e18afed7 15702012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1571
1572 * unexaix.c (make_hdr): Fix typo in prototype.
1573 This bug broke the build on AIX. Problem reported by Gilles Pion.
1574
9d0a235a
MA
15752012-05-14 Michael Albinus <michael.albinus@gmx.de>
1576
1577 * keyboard.c (kbd_buffer_get_event): Read special events also in
1578 batch mode. (Bug#11415)
1579
9e6b06ed
GM
15802012-05-12 Glenn Morris <rgm@gnu.org>
1581
1582 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1583
c1a1d7a3
EZ
15842012-05-12 Eli Zaretskii <eliz@gnu.org>
1585
1586 * lisp.mk (lisp): Add newcomment.elc.
1587
3fe7cdc8
GM
15882012-05-12 Glenn Morris <rgm@gnu.org>
1589
1590 * Makefile.in (MKDIR_P): New, set by configure.
1591 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1592
53f7d2c0
PE
15932012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1594
1595 Remove unused function hourglass_started.
1596 * dispextern.h (hourglass_started):
1597 * w32fns.c (hourglass_started):
1598 * xdisp.c (hourglass_started): Remove.
1599
75aafb17
JB
16002012-05-10 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1603 Update dependencies.
1604
12959e8e
PE
16052012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1606
97107e2e
PE
1607 * xgselect.c (xg_select): Put maxfds+1 into a var.
1608 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1609
12959e8e
PE
1610 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1611
836d29b3
DA
16122012-05-10 Dave Abrahams <dave@boostpro.com>
1613
1614 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1615 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1616
5cb67954
MA
16172012-05-09 Michael Albinus <michael.albinus@gmx.de>
1618
1619 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1620 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1621 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1622 Initialize xd_registered_buses.
1623
3478ec45
PE
16242012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1625
b263a6b0
PE
1626 Untag more efficiently if USE_LSB_TAG.
1627 This is based on a proposal by YAMAMOTO Mitsuharu in
1628 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1629 For an admittedly artificial (nth 8000 longlist) benchmark on
1630 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1631 Emacs's overall text size by 1%.
1632 * lisp.h (XUNTAG): New macro.
1633 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1634 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1635 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1636 * eval.c (Fautoload):
1637 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1638 * frame.h (XFRAME): Use XUNTAG.
1639
3478ec45
PE
1640 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1641 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1642 Remove unportable assumptions about print widths of types like
1643 dbus_uint32_t.
1644 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1645 intptr_t when converting between pointer and integer, to avoid GCC
1646 warnings about wrong width.
1647
666b903b 16482012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1649
1650 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1651 stack for each reader_thread, instead of defaulting to 8MB
1652 determined by the linker. This avoids failures in creating
1653 subprocesses on Windows 7, see the discussion in this thread:
1654 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1655
b120cc17
JC
16562012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1657
1658 Fix up display of the *Minibuf-0* buffer in the mini window.
1659 * keyboard.c (read_char): Don't clear the echo area if there's no
1660 message to clear.
1661 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1662 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1663
9a4b36f8
MA
16642012-05-07 Michael Albinus <michael.albinus@gmx.de>
1665
1666 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1667 batch mode.
1668
e5f9458f
CY
16692012-05-06 Chong Yidong <cyd@gnu.org>
1670
1671 * lisp.mk (lisp): Update.
1672
eceeb5fc 16732012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1674
1675 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1676
71873e2b
SM
16772012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1678
1679 * data.c (PUT_ERROR): New macro.
1680 (syms_of_data): Use it. Add new error type `user-error'.
1681 * undo.c (user_error): New function.
1682 (Fprimitive_undo): Use it.
1683 * print.c (print_error_message): Adjust print style for `user-error'.
1684 * keyboard.c (user_error): New function.
1685 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1686
ab0fa4e4
PE
16872012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 Do not limit current-time-string to years 1000..9999.
1690 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1691 (Fcurrent_time_string): Support any year that is supported by the
1692 underlying localtime representation. Don't use asctime, as it
1693 has undefined behavior for years outside the range -999..9999.
1694
7ed806a7
PE
16952012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 Fix race conditions involving setenv, gmtime, localtime, asctime.
1698 Without this fix, interrupts could mess up code that uses these
1699 nonreentrant functions, since setting TZ invalidates existing
1700 tm_zone or tzname values, and since most of these functions return
1701 pointers to static storage.
1702 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1703 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1704 Grow the critical sections to include not just invoking
1705 localtime/gmtime, but also accessing these functions' results
1706 including their tm_zone values if any, and any related TZ setting.
1707 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1708 so that the struct tm is saved in the critical section.
1709 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1710 motivated by the fact that memory allocation needs to be outside
1711 the critical section.
1712
0c16dfed
DA
17132012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1714
1715 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1716 with RESET_INTERVAL.
1717
1718 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1719 Remove duplicated buffer name initialization.
1720
3f83ace8
JM
17212012-05-02 Jim Meyering <jim@meyering.net>
1722
1723 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1724
c7b8541e
JM
1725 * xfns.c (x_window): Use xstrdup (Bug#11375).
1726
90207a15 17272012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1728
1729 * xdisp.c (pos_visible_p): If already at a newline from the
1730 display string before the 'while' loop, don't walk back the glyphs
1731 from it3.glyph_row. Solves assertion violation when the display
1732 string begins with a newline (egg.el). (Bug#11367)
1733
b593d6a9
AH
17342012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1735
1736 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1737 Move to simple.el.
1738
4737362e
GM
17392012-05-01 Glenn Morris <rgm@gnu.org>
1740
99cf43f9
GM
1741 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1742 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1743 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1744 All were removed before 23.1.
1745
9311dcff
GM
1746 * dispnew.c: Remove HAVE_LIBNCURSES test;
1747 it is always true on relevant platforms.
1748
4d5c6349
GM
1749 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1750 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1751
4737362e
GM
1752 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1753
74dd3a6b
AS
17542012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1755
1756 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1757 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1758 Remove.
1759
13c379ee
PE
17602012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 Do not avoid creating empty evaporating overlays (Bug#9642).
1763 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1764 That is, do not delete an evaporating overlay if it becomes
1765 empty after its bounds are adjusted to fit within its buffer.
1766 This fix caused other problems, and I'm reverting it until we get
1767 to the bottom of them.
1768
a8e7d6d7 17692012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1770
1771 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1772
a8e7d6d7 17732012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1774
1775 * xdisp.c (pos_visible_p): If the window start position is beyond
1776 ZV, start the display from buffer beginning. Prevents assertion
1777 violation in init_iterator when the minibuffer window is scrolled
1778 via the scroll bar.
1779
1780 * window.c (window_scroll_pixel_based): Likewise.
1781
a8e7d6d7 17822012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1783
1784 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1785
a8e7d6d7 17862012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1787
1788 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1789 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1790
a8e7d6d7 17912012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1792
b593d6a9
AH
1793 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1794 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1795
1c6900d9
EZ
17962012-04-26 Eli Zaretskii <eliz@gnu.org>
1797
4c3fa1d9
EZ
1798 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1799 display element, check also the underlying string or buffer
1800 character. (Bug#11341)
1801
1c6900d9
EZ
1802 * w32menu.c: Include w32heap.h.
1803 (add_menu_item): If the call to AppendMenuW (via
1804 unicode_append_menu) fails, disable Unicode menus only if we are
1805 running on Windows 9X/Me.
1806
42bf8205
AS
18072012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1808
1809 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1810 (xgetint): Add missing shift for LSB tags.
1811
b1bac16e
MR
18122012-04-24 Martin Rudalics <rudalics@gmx.at>
1813
1814 * keyboard.c (read_char): Don't wipe echo area for select window
1815 events: These might get delayed via `mouse-autoselect-window'
1816 (Bug#11304).
1817
d69621cc
JB
18182012-04-24 Juanma Barranquero <lekktu@gmail.com>
1819
1820 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1821 manipulation of :loaded-from data.
1822
02fd101b
JB
18232012-04-23 Juanma Barranquero <lekktu@gmail.com>
1824
1825 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1826 now a cons (bug#11311).
1827
888bec30
PE
18282012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1829
89a438bd
PE
1830 Do not create empty overlays with the evaporate property (Bug#9642).
1831 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1832 if it becomes empty after its bounds are adjusted to fit within
1833 its buffer. Without this fix, in a nonempty buffer (let ((o
1834 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1835 yields an empty overlay that has the evaporate property, which is
1836 not supposed to happen.
1837
1068fe4d
PE
1838 Fix minor GTK3 problems found by static checking.
1839 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1840 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1841 (struct _EmacsFixedClass, emacs_fixed_get_type):
1842 Move decls here from emacsgtkfixed.h, since they needn't be public.
1843 (emacs_fixed_get_type): Now static.
1844 (emacs_fixed_class_init): Omit unused local.
1845 (emacs_fixed_child_type): Remove; unused.
1846 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1847 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1848 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1849 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1850 (EMACS_FIXED_GET_CLASS): Remove; unused.
1851 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1852
888bec30
PE
1853 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1854 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1855
de85e130
PE
18562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1857
d0baac98 1858 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1859 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1860 (__malloc_size_t, __malloc_ptrdiff_t):
1861 Remove. All uses removed, replaced by the definiens if needed,
1862 since we can assume C89 or better now.
1863 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1864 (protect_malloc_state, align, get_contiguous_space)
1865 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1866 (malloc_atfork_handler_child, malloc_enable_thread)
1867 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1868 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1869 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1870 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1871 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1872 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1873 Define using prototypes, not old style.
1874 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1875 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1876 (align): Don't assume that signed integer overflow wraps around.
1877 Omit unused local var.
1878 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1879 (_free_internal_nolock, memalign, mallochook, reallochook):
1880 Omit no-longer-needed casts.
1881 (valloc): Use getpagesize, not __getpagesize.
1882 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1883 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1884
de85e130
PE
1885 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1886
dcbf5805
MA
18872012-04-22 Michael Albinus <michael.albinus@gmx.de>
1888
1889 Move functions from C to Lisp. Make non-blocking method calls
1890 the default. Implement further D-Bus standard interfaces.
1891
1892 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1893 (QCdbus_request_name_allow_replacement)
1894 (QCdbus_request_name_replace_existing)
1895 (QCdbus_request_name_do_not_queue)
1896 (QCdbus_request_name_reply_primary_owner)
1897 (QCdbus_request_name_reply_in_queue)
1898 (QCdbus_request_name_reply_exists)
1899 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1900 (QCdbus_registered_serial, QCdbus_registered_method)
1901 (QCdbus_registered_signal): New Lisp objects.
1902 (XD_DEBUG_MESSAGE): Use sizeof.
1903 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1904 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1905 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1906 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1907 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1908 (xd_signature, xd_append_arg): Allow float for integer types.
1909 (xd_get_connection_references): New function.
b593d6a9
AH
1910 (xd_get_connection_address): Rename from xd_initialize.
1911 Return cached address.
dcbf5805
MA
1912 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1913 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1914 level.
1915 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1916 Return number of refcounts.
dcbf5805
MA
1917 (Fdbus_get_unique_name): Make stronger parameter check.
1918 (Fdbus_message_internal): New defun.
1919 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1920 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1921 (Fdbus_send_signal, Fdbus_register_service)
1922 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1923 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1924 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1925 (Vdbus_compiled_version, Vdbus_runtime_version)
1926 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1927 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1928 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1929 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1930 Adapt docstring.
dcbf5805 1931
52828e02
PE
19322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1933
da05bc4c
PE
1934 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1935 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1936 Do not assume ptrdiff_t is the same width as 'int'.
1937
52828e02
PE
1938 * alloc.c: Handle unusual debugging option combinations.
1939 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1940 since the two debugging options are incompatible.
1941 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1942 is defined.
1943 (mem_init, mem_insert, mem_insert_fixup):
1944 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1945 (NEED_MEM_INSERT): Remove; no longer needed.
1946
f01769f9
LL
19472012-04-22 Leo Liu <sdl.web@gmail.com>
1948
1949 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1950
5790543d
PE
19512012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 * sysdep.c [__FreeBSD__]: Minor cleanups.
1954 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1955 Use Emacs indenting style more consistently. Avoid some casts.
1956 Use 'double' consistently rather than mixing 'float' and 'double'.
1957
b91b7e4d
EW
19582012-04-21 Eduard Wiebe <usenet@pusto.de>
1959
b593d6a9
AH
1960 * sysdep.c (list_system_processes, system_process_attributes):
1961 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1962
6114eb15
AS
19632012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1964
1965 * lisp.mk (lisp): Update.
1966
2f38dff7
PE
19672012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1970 It is never used otherwise.
1971
4ae29f89
SM
19722012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1973
1974 * print.c (print_preprocess): Only check print_depth if print-circle
1975 is nil.
1976 (print_object): Check for cycles even when print-circle is nil and
1977 print-gensym is t, but only check print_depth if print-circle is nil.
1978
f30d612a
CY
19792012-04-20 Chong Yidong <cyd@gnu.org>
1980
1981 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1982 set the status to "failed" and ensure that sentinel is run.
1983
c07a4c0b 19842012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1985
1986 * process.c (Fset_process_inherit_coding_system_flag)
1987 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1988 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1989
c07a4c0b 19902012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1991
1992 * xdisp.c (string_buffer_position_lim): Limit starting position to
1993 BEGV.
1994 (set_cursor_from_row): If called for a mode-line or header-line
1995 row, return zero immediately.
1996 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1997 farther than the first row after the header line, if any.
1998 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1999 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2000
c07a4c0b 20012012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2002
4ae29f89
SM
2003 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2004 (bug#11238).
ad3a2b41 2005
c07a4c0b 20062012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 20072012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2008
2009 configure: new option --enable-gcc-warnings (Bug#11207)
2010 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2011 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2012 (ALL_CFLAGS): Use new macros rather than old.
2013 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2014 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2015 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2016 -Wunused-result, -Wunused-variable. This should go away once
2017 the Emacs and Gnulib regex code is merged.
2018 (xmalloc, xrealloc): Now static.
2019
aba027e8
PE
20202012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 * dired.c (Fsystem_groups): Remove unused local.
2023
e5a36063
GM
20242012-04-17 Glenn Morris <rgm@gnu.org>
2025
2026 * dired.c (Fsystem_users): Doc fix.
2027
316411f0
DA
20282012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2029
2030 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2031 (syms_of_dired): Add them.
2032
9426aba4
PE
20332012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2034
b62a57be
PE
2035 Fix minor alloc.c problems found by static checking.
2036 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2037 New extern decls, to avoid calling undeclared functions.
2038 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2039 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2040 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2041 (NEED_MEM_INSERT): New macro.
2042 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2043 Remove one incorrect comment and fix another.
b62a57be 2044
3539f31f
PE
2045 Fix minor ralloc.c problems found by static checking.
2046 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2047 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2048 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2049 (r_alloc_sbrk): Now static.
2050
a041960a
PE
2051 Improve ralloc.c interface checking.
2052 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2053 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2054 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2055 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2056 [REL_ALLOC]: ... to here, to check interface.
2057 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2058 Remove decls. This fixes an "It stinks!".
2059
9426aba4
PE
2060 * alloc.c (which_symbols): Fix alignment issue / type clash.
2061
d55c12ed
AS
20622012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2063
2064 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2065 (struct Lisp_Misc_Any): Likewise.
2066 (struct Lisp_Free): Likewise.
2067 * alloc.c (union aligned_Lisp_Symbol): Define.
2068 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2069 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2070 (union aligned_Lisp_Misc): Define.
2071 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2072 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2073 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2074
b948ce8b
PE
20752012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2078 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2079 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2080 * s/netbsd.h, s/sol2-6.h:
2081 Remove definition of GC_MARK_STACK, since the default now works.
2082 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2083 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2084 no longer the default.
2085 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2086
35dc09a1 20872012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2088
35dc09a1
GM
2089 * lread.c (lisp_file_lexically_bound_p):
2090 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2091
35dc09a1
GM
20922012-04-14 Eli Zaretskii <eliz@gnu.org>
2093
2094 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2095 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2096
20972012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2098
2099 * nsterm.m (constrainFrameRect): Always constrain when there is only
2100 one screen (Bug#10962).
2101
bcd86815
KB
21022012-04-13 Ken Brown <kbrown@cornell.edu>
2103
2104 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2105
c25df26e
RT
21062012-04-13 Reuben Thomas <rrt@sc3d.org>
2107
2108 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2109
0fc59f1e
DC
21102012-04-11 Daniel Colascione <dancol@dancol.org>
2111
2112 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2113 against is gone. It's better to use vfork now so that when Cygwin
2114 gains a new, working vfork, we use it automatically (bug#10398).
2115
de8c03dc
SM
21162012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2117
2118 * window.c (save_window_save): Obey window-point-insertion-type.
2119
2f097256
GM
21202012-04-11 Glenn Morris <rgm@gnu.org>
2121
2122 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2123
453b951e
SM
21242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2125
2126 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2127
75f1671a 21282012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2129
2130 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2131 (force_quit_count): New var.
2132 (handle_interrupt): Use it.
2133
2a8ce227
JB
21342012-04-10 Juanma Barranquero <lekktu@gmail.com>
2135
2136 * w32.c (w32_delayed_load): Record the full path of the library
2137 being loaded (bug#10424).
2138
935396c0
GM
21392012-04-09 Glenn Morris <rgm@gnu.org>
2140
05920a43
GM
2141 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2142 not just in the obarray, before snarfing them. (Bug#11036)
2143
935396c0
GM
2144 * Makefile.in ($(leimdir)/leim-list.el):
2145 Pass EMACS rather than BUILT_EMACS.
2146
a18ecafa
TZ
21472012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2148
2149 * process.c (make_process):
2150 * process.h: Add integer `gnutls_handshakes_tried' member to
2151 process struct.
2152
6bbef4e5
JC
2153 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2154 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2155
2156 * gnutls.c (gnutls_log_function2i): Convenience log function.
2157 (emacs_gnutls_read): Use new log functions,
2158 `gnutls_handshakes_tried' process member, and
2159 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2160 attempts per process (connection).
2161
b4d3bc10
CY
21622012-04-09 Chong Yidong <cyd@gnu.org>
2163
2164 * eval.c (Fuser_variable_p, user_variable_p_eh)
2165 (lisp_indirect_variable): Functions deleted.
2166 (Fdefvar): Caller changed.
2167
2168 * callint.c (Finteractive, Fcall_interactively):
2169 * minibuf.c (Fread_variable): Callers changed.
2170
70f4d973
EZ
21712012-04-09 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (set_cursor_from_row): If the display string appears in
2174 the buffer at position that is closer to point than the position
2175 after the display string, display the cursor on the first glyph of
2176 the display string. Fixes cursor display when a 'display' text
2177 property immediately follows invisible text. (Bug#11094)
2178
cb3c2e3e
PE
21792012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 composite.c: use 'double' consistently
2182 * composite.c (get_composition_id): Use 'double' consistently
2183 instead of converting 'float' to 'double' and vice versa; this is
2184 easier to understand and avoids a GCC warning.
2185
fd06db5d
GM
21862012-04-09 Glenn Morris <rgm@gnu.org>
2187
50fe702a
GM
2188 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2189 preparation for dumping it with emacs. (Bug#4789)
2190 (leimdir): New variable.
2191 ($(leimdir)/leim-list.el): New rule.
2192 (emacs$(EXEEXT)): Depend on leim-list.el.
2193
fd06db5d
GM
2194 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2195 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2196 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2197
55c131ee
AS
21982012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2199
2200 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2201 proper alignment.
2202
9209588f
JB
22032012-04-07 Juanma Barranquero <lekktu@gmail.com>
2204
2205 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2206 Remove unused local variable.
2207
e3fb2efb
PE
22082012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2211 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2212 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2213 objects, as mark_maybe_pointer will catch them otherwise.
2214 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2215 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2216
b5385551
PE
22172012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 Fix typo that broke non-Windows builds.
2220 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2221
9078ead6
EZ
22222012-04-07 Eli Zaretskii <eliz@gnu.org>
2223
2224 Support building on MS-Windows with libxml2.
2225
2226 * makefile.w32-in (OBJ2): Add xml.$(O).
2227 (GLOBAL_SOURCES): Add xml.c.
2228 ($(BLD)/xml.$(O)): New dependency list.
2229
2230 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2231 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2232 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2233 [!WINDOWSNT]: New macros.
2234 (init_libxml2_functions, libxml2_loaded_p): New functions.
2235 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2236 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2237 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2238 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2239 linked in).
6bbef4e5
JC
2240 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2241 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2242 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2243
2244 * emacs.c: Don't include libxml/parser.h.
2245 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2246 xmlCleanupParser directly.
2247
2248 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2249
3811fdf3
EZ
22502012-04-07 Eli Zaretskii <eliz@gnu.org>
2251
2252 * indent.c (Fvertical_motion): If there is a display string at
2253 point, use it.vpos to compute how many lines to backtrack after
2254 move_it_to point. (Bug#11133)
2255
2f8e16b2
EZ
22562012-04-06 Eli Zaretskii <eliz@gnu.org>
2257
2258 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2259 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2260 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2261 macros related to unification of CJK characters. For the details,
2262 see the discussion following the message here:
2263 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2264
3d439cd1
CY
22652012-04-04 Chong Yidong <cyd@gnu.org>
2266
2267 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2268
8bc53d00
EZ
22692012-04-01 Eli Zaretskii <eliz@gnu.org>
2270
2271 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2272 instead of alloca. (Bug#11138)
2273
3b0512a3
AS
22742012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2275
2276 * w32menu.c (is_simple_dialog): Properly check lisp types.
2277 (Bug#11141)
2278
8427ddd2
EZ
22792012-03-31 Eli Zaretskii <eliz@gnu.org>
2280
979022ef
EZ
2281 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2282 position we get to after a call to move_it_to fails the
2283 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2284 only if we wind up in a string from display property. (Bug#11063)
2285
a6b1c7cc
EZ
2286 * window.c (Fdelete_other_windows_internal): Invalidate the row
2287 and column information about mouse highlight, so that redisplay
2288 restores it after reallocating the glyph matrices. (Bug#7464)
2289
8427ddd2
EZ
2290 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2291 string comes from a `display' text property, use the buffer
2292 position of that property as if we actually saw that position in
2293 the row's glyphs.
697ba24b
EZ
2294 (move_it_by_lines): Remove the assertion that
2295 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2296 violated when there's a before-string at the beginning of a line.
2297 (Bug#11063)
8427ddd2 2298
65a0a738
EZ
22992012-03-30 Eli Zaretskii <eliz@gnu.org>
2300
2301 * xdisp.c (append_space_for_newline): If the default face was
2302 remapped, use the remapped face for the appended newline.
2303 (extend_face_to_end_of_line): Use the remapped default face for
2304 extending the face to the end of the line.
2305 (display_line): Call extend_face_to_end_of_line when the default
2306 face was remapped. (Bug#11068)
2307
581355cc
EZ
23082012-03-29 Eli Zaretskii <eliz@gnu.org>
2309
2310 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2311
e8fc049f
SM
23122012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2313
2314 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2315
4fb9a543
GM
23162012-03-27 Glenn Morris <rgm@gnu.org>
2317
2318 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2319 Doc fixes.
2320
679910f1
KH
23212012-03-26 Kenichi Handa <handa@m17n.org>
2322
2323 * dispextern.h (struct glyph): Fix previous change. Change the
2324 bit length of glyphless.ch to 25 (Bug#11082).
2325
90d49b7f
CY
23262012-03-26 Chong Yidong <cyd@gnu.org>
2327
2328 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2329 (command_loop_1): Use it; inhibit selection update for
2330 handle-select-window too (Bug#8996).
2331
f514f6f0
FP
23322012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2333
e8fc049f 2334 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2335
bf43fa51
KH
23362012-03-25 Kenichi Handa <handa@m17n.org>
2337
2338 * dispextern.h (struct glyph): Change the bit length of
2339 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2340
8a0c01dd
EZ
23412012-03-24 Eli Zaretskii <eliz@gnu.org>
2342
2343 * s/ms-w32.h (tzname): Include time.h before redirecting to
2344 _tzname. Fixes the MSVC build. (Bug#9960)
2345
7d1c3a76
AS
23462012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2347
8ed79523
AS
2348 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2349 characters.
2350
7d1c3a76
AS
2351 * xterm.c (XTread_socket): Only modify handling_signal if
2352 !SYNC_INPUT. (Bug#11080)
2353
e99a9b8b
EZ
23542012-03-23 Eli Zaretskii <eliz@gnu.org>
2355
2356 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2357 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2358 when fetching a multibyte character consumes more bytes than
2359 CHAR_BYTES returns, due to unification of CJK characters in
2360 string_char. (Bug#11073)
2361
5063c0e1
TN
23622012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2363
2364 * process.c (wait_reading_process_output): Handle pty disconnect
2365 by refraining from sending oneself a SIGCHLD (bug#10933).
2366
9f851fbd
CY
23672012-03-22 Chong Yidong <cyd@gnu.org>
2368
2369 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2370
5063c0e1 2371 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2372 Mark string as coming from a prefix property.
2373 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2374 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2375
fb5b8aca
CY
23762012-03-21 Chong Yidong <cyd@gnu.org>
2377
2378 * xfaces.c (Vface_remapping_alist): Doc fix.
2379
62356a1b
EZ
23802012-03-20 Eli Zaretskii <eliz@gnu.org>
2381
2382 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2383 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2384 Doc fixes.
62356a1b 2385
025de85b
CY
23862012-03-20 Chong Yidong <cyd@gnu.org>
2387
2388 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2389 to reflect default non-nil value of redisplay-dont-pause.
2390
4827f94e
KH
23912012-03-19 Kenichi Handa <handa@m17n.org>
2392
2393 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2394 it fit in a valid range (Bug#11003).
2395
e50a24a2
EZ
23962012-03-18 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2399 that is not from display property, accept the row as a "cursor
2400 row" if one of the string's character has a non-nil `cursor'
2401 property. Fixes cursor positioning when there are newlines in
2402 overlay strings, e.g. in icomplete.el. (Bug#11035)
2403
9af5ed87
PE
24042012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2407
d1f55f16
CY
24082012-03-12 Chong Yidong <cyd@gnu.org>
2409
2410 * eval.c (inhibit_lisp_code): Rename from
2411 inhibit_window_configuration_change_hook; move from window.c.
2412
2413 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2414 * window.c (run_window_configuration_change_hook)
2415 (syms_of_window): Callers changed.
2416
66c5eebd
CY
24172012-03-11 Chong Yidong <cyd@gnu.org>
2418
413df973
CY
2419 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2420
66c5eebd
CY
2421 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2422
1de11f56
CY
24232012-03-10 Chong Yidong <cyd@gnu.org>
2424
2425 * frame.c (other_visible_frames): Don't assume the selected frame
2426 is visible (Bug#10955).
2427
cae07000
SM
24282012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2429
2430 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2431
89c94350
JD
24322012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2433
2434 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2435 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2436 zero (Bug#10954).
2437
999dd333
GM
24382012-03-03 Glenn Morris <rgm@gnu.org>
2439
01a6dcc8 2440 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2441
de0100f2
EZ
24422012-03-02 Eli Zaretskii <eliz@gnu.org>
2443
2444 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2445 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2446 (redisplay_window, next_element_from_string): Fix typos in
2447 comments.
3e441275
EZ
2448 (redisplay_window): Pass to move_it_vertically the margin in
2449 pixels, not in screen lines.
de0100f2 2450
96a72ee9
GM
24512012-03-02 Glenn Morris <rgm@gnu.org>
2452
2453 * buffer.c (buffer-list-update-hook): Doc fix.
2454
312508d7
EZ
24552012-02-29 Eli Zaretskii <eliz@gnu.org>
2456
2457 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2458 push_it before setting up the iterator for the first overlay
2459 string, even if we have an empty string loaded.
2460 (next_overlay_string): If there's an empty string on the iterator
2461 stack, pop the stack. (Bug#10903)
2462
27f3c637
PE
24632012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2466 Suggested by Stefan Monnier in
2467 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2468 * alloc.c (widen_to_Lisp_Object): New static function.
2469 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2470 and widening them to Lisp_Objects. This would work even if
2471 USE_LSB_TAG is defined and wide integers are used, which might
2472 happen in a future version of Emacs.
2473
3c9dfce6
CY
24742012-02-25 Chong Yidong <cyd@gnu.org>
2475
fa74b241
CY
2476 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2477 Doc fix.
2478
3c9dfce6
CY
2479 * xselect.c (Fx_selection_exists_p): Doc fix.
2480 (x_clipboard_manager_save_all): Print an informative message
2481 before saving to clipboard manager.
2482
9486df08
CY
24832012-02-24 Chong Yidong <cyd@gnu.org>
2484
2485 * keyboard.c (process_special_events): Handle all X selection
2486 requests in kbd_buffer, not just the next one (Bug#8869).
2487
f01d3321
CY
24882012-02-23 Chong Yidong <cyd@gnu.org>
2489
2490 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2491 call when setting menu-bar-lines and tool-bar-lines parameters.
2492 (unwind_create_frame_1): New helper function.
2493
2494 * window.c (inhibit_window_configuration_change_hook): New var.
2495 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2496 (syms_of_window): Initialize it.
f01d3321 2497
86b847b6
CY
24982012-02-22 Chong Yidong <cyd@gnu.org>
2499
2500 * xterm.c (x_draw_image_relief): Add missing type check for
2501 Vtool_bar_button_margin (Bug#10743).
2502
a59225b1
CY
25032012-02-21 Chong Yidong <cyd@gnu.org>
2504
2505 * fileio.c (Vfile_name_handler_alist): Doc fix.
2506
2507 * buffer.c (Fget_file_buffer): Protect against invalid file
2508 handler return value.
2509
310f5bd4
PE
25102012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2511
cb3a28cc
PE
2512 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2513 when computing $valmask.
2514
310f5bd4
PE
2515 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2516 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2517 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2518 It's useless in that case, and it can cause problems on hosts
2519 that allocate halves of EMACS_INT values separately.
2520 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2521 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2522 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2523 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2524 it avoids undefined behavior on hosts where shifting right by more
2525 than the word width has undefined behavior.
2526
2375c96a
CY
25272012-02-19 Chong Yidong <cyd@gnu.org>
2528
2529 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2530 (Funhandled_file_name_directory, Ffile_name_as_directory)
2531 (Fdirectory_file_name, Fexpand_file_name)
2532 (Fsubstitute_in_file_name): Protect against invalid file handler
2533 return values (Bug#10845).
2534
3eb49e71
EZ
25352012-02-18 Eli Zaretskii <eliz@gnu.org>
2536
2537 * .gdbinit (pitx): Fix incorrect references to fields of the
2538 iterator stack.
2539
7b926f3f
CY
25402012-02-17 Chong Yidong <cyd@gnu.org>
2541
2542 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2543
11273115
PE
25442012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2547 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2548
c3a70e2b
CY
25492012-02-15 Chong Yidong <cyd@gnu.org>
2550
2551 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2552 marked as special. Also, starting docstrings with * is obsolete.
2553
0ca43699
AS
25542012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2555
2556 * gnutls.c (emacs_gnutls_write): Fix last change.
2557
2e8f3c56
LI
25582012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2559
2560 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2561 send_process.
2562
af70074f
SM
25632012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2564
2565 * keymap.c (Fsingle_key_description): Handle char ranges.
2566
95986d52
CY
25672012-02-12 Chong Yidong <cyd@gnu.org>
2568
afd83bd1
CY
2569 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2570 as that creates a dangerous corner case.
2571
95986d52
CY
2572 * window.c (Fdelete_window_internal): Invalidate the mouse
2573 highlight (Bug#9904).
2574
bd7da63e
GM
25752012-02-12 Glenn Morris <rgm@gnu.org>
2576
2577 * xselect.c (Fx_own_selection_internal)
2578 (Fx_get_selection_internal, Fx_disown_selection_internal)
2579 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2580 * nsselect.m (Fx_own_selection_internal)
2581 (Fx_disown_selection_internal, Fx_selection_exists_p)
2582 (Fx_selection_owner_p, Fx_get_selection_internal):
2583 Sync docs and argument specs with the xselect.c versions.
2584
77abcbc2
LI
25852012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2586
2587 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2588
90b671e2
EZ
25892012-02-11 Eli Zaretskii <eliz@gnu.org>
2590
1c0ca0b7
EZ
2591 * w32select.c (Fx_selection_exists_p): Sync doc string and
2592 argument list with xselect.c. (Bug#10783)
2593
2594 * w16select.c (Fx_selection_exists_p): Sync doc string and
2595 argument list with xselect.c. (Bug#10783)
90b671e2 2596
49241268
GM
25972012-02-10 Glenn Morris <rgm@gnu.org>
2598
2599 * fns.c (Fsecure_hash): Doc fix.
2600
f998bbe7 26012012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2602
2603 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2604
0992bd9c
CY
26052012-02-07 Chong Yidong <cyd@gnu.org>
2606
2607 * buffer.c (Fbuffer_local_variables)
2608 (buffer_lisp_local_variables): Handle unbound vars correctly;
2609 don't let Qunbound leak into Lisp.
2610
af008560
GM
26112012-02-07 Glenn Morris <rgm@gnu.org>
2612
dd605cc4
GM
2613 * image.c (Fimagemagick_types): Doc fix.
2614
af008560
GM
2615 * image.c (imagemagick-render-type): Change it from a lisp object
2616 to an integer. Move the doc here from the lisp manual.
2617 Treat all values not equal to 0 the same.
2618
1449fa1d
CY
26192012-02-06 Chong Yidong <cyd@gnu.org>
2620
2621 * doc.c (store_function_docstring): Avoid applying docstring of
2622 alias to base function (Bug#2603).
2623
3723ec07
AS
26242012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2625
2626 * .gdbinit (pp1, pv1): Remove redundant defines.
2627 (pr): Use pp.
2628
79c1cc1e
CY
26292012-02-04 Chong Yidong <cyd@gnu.org>
2630
2631 * nsterm.m: Declare a global (Bug#10694).
2632
d7f29f8e
EZ
26332012-02-04 Eli Zaretskii <eliz@gnu.org>
2634
cae07000
SM
2635 * w32.c (get_emacs_configuration_options):
2636 Include --enable-checking, if specified, in the return value.
d7f29f8e 2637
3b95a6f9
MR
26382012-02-04 Martin Rudalics <rudalics@gmx.at>
2639
2640 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2641 after rounding frame sizes. (Bug#9723)
2642
d6fa96a6
EZ
26432012-02-04 Eli Zaretskii <eliz@gnu.org>
2644
2645 * keyboard.c (adjust_point_for_property): Don't position point
2646 before BEGV. (Bug#10696)
2647
df0b2940
PE
26482012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 Handle overflow when computing char display width (Bug#9496).
2651 * character.c (char_width): Return EMACS_INT, not int.
2652 (char_width, c_string_width): Check for overflow when
2653 computing the width; this is possible now that individual
2654 characters can have unbounded width. Problem introduced
2655 by merge from Emacs 23 on 2012-01-19.
2656
6bee44d6
MA
26572012-02-02 Michael Albinus <michael.albinus@gmx.de>
2658
2659 * dbusbind.c (Fdbus_register_method): Mention the return value
2660 :ignore in the docstring.
2661
44f92739
GM
26622012-02-02 Glenn Morris <rgm@gnu.org>
2663
1b9f60cc
GM
2664 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2665
44f92739
GM
2666 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2667 Unconditionally set to t. (Bug#10673)
2668 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2669 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2670 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2671
c5d3843c
KH
26722012-02-02 Kenichi Handa <handa@m17n.org>
2673
2674 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2675 0, do not call append_composite_glyph.
2676
159462d4 26772012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2678
2679 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2680 NULL (Bug#6988).
2681 (x_produce_glyphs): If the component of a composition is a null
2682 string, set it->pixel_width to 1 to avoid zero-width glyph.
2683
78cef877
EZ
26842012-02-01 Eli Zaretskii <eliz@gnu.org>
2685
2686 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2687 first 2 arguments are identical. This makes inserting large
2688 output from a subprocess an order of magnitude faster on
2689 MS-Windows, where all sbrk'ed memory is always contiguous.
2690
97897668
GM
26912012-01-31 Glenn Morris <rgm@gnu.org>
2692
2693 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2694 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2695 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2696
31fd3586
GM
26972012-01-29 Glenn Morris <rgm@gnu.org>
2698
2699 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2700
0e24a8b2
CY
27012012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2702
2703 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2704
cc0adcb0
CY
27052012-01-28 Chong Yidong <cyd@gnu.org>
2706
2707 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2708
acc28cb9
CY
27092012-01-26 Chong Yidong <cyd@gnu.org>
2710
9c69cfb7
CY
2711 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2712
acc28cb9
CY
2713 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2714 repeat counts (Bug#10507).
2715
48da7392
GM
27162012-01-26 Glenn Morris <rgm@gnu.org>
2717
2718 * lread.c (syms_of_lread): Doc fix.
2719
14af5f7f
CY
27202012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2721
2722 * coding.c (encode_designation_at_bol): Change return value to
2723 EMACS_INT.
2724
0b21c100
CY
27252012-01-25 Chong Yidong <cyd@gnu.org>
2726
2727 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2728
3c2907f7
CY
27292012-01-21 Chong Yidong <cyd@gnu.org>
2730
2731 * floatfns.c (Fcopysign): Make the second argument non-optional,
2732 since nil is not allowed anyway.
2733
959ad23f
AS
27342012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2735
2736 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2737 (send_process): Likewise.
2738
34a02f46
MR
27392012-01-19 Martin Rudalics <rudalics@gmx.at>
2740
2741 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2742 (Vwindow_persistent_parameters): Do not use Qstate.
2743 Rewrite doc-strings.
34a02f46 2744
1259009a 27452012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2746
2747 * character.c (char_width): New function.
70d4fdf6
GM
2748 (Fchar_width, c_string_width, lisp_string_width):
2749 Use char_width (Bug#9496).
25ed9e61 2750
6a6ee00d
MR
27512012-01-16 Martin Rudalics <rudalics@gmx.at>
2752
2753 * window.c (Vwindow_persistent_parameters): New variable.
2754 (Fset_window_configuration, save_window_save): Handle persistent
2755 window parameters.
2756
c85efaf7
EZ
27572012-01-14 Eli Zaretskii <eliz@gnu.org>
2758
2759 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2760 thrashing the stack of the thread. (Bug#9087)
2761
5944709e
PE
27622012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2765
e71f5d99
EZ
27662012-01-11 Eli Zaretskii <eliz@gnu.org>
2767
2768 * xdisp.c (rows_from_pos_range): Handle the case where the
2769 highlight ends on a newline. (Bug#10464)
2770 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2771 he end column for display of highlight that ends on a newline
2772 before a R2L line.
2773
ce316182
GM
27742012-01-11 Glenn Morris <rgm@gnu.org>
2775
2776 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2777 from load-path also when installation-directory is nil. (Bug#10208)
2778
5b43da69
GM
27792012-01-10 Glenn Morris <rgm@gnu.org>
2780
74cc8ff9
GM
2781 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2782
7d8d6e4e
GM
2783 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2784 Update template values to be closer to their typical values these days.
5b43da69 2785
a0db8d43
EZ
27862012-01-09 Eli Zaretskii <eliz@gnu.org>
2787
2788 * xdisp.c (rows_from_pos_range): Accept additional argument
2789 DISP_STRING, and accept any glyph in a row whose object is that
2790 string as eligible for mouse highlight. Fixes mouse highlight of
2791 display strings from overlays. (Bug#10464)
2792
9a0115ab 27932012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2794
b9110d6a 2795 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2796 * fileio.c (auto_saving_dir_umask): New static var.
2797 (Fmake_directory_internal): Use it.
2798 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2799 creating the directory. The old code temporarily assigns
2800 too-generous permissions to the directory.
2801 (do_auto_save_eh): Clear it.
b9110d6a 2802 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2803 that the var is always cleared.
2804
6c1bd3f3
EZ
28052012-01-07 Eli Zaretskii <eliz@gnu.org>
2806
2807 * search.c (scan_buffer): Pass character positions to
2808 know_region_cache, not byte positions. (Bug#6540)
2809
069d2b50
L
28102012-01-07 LynX <_LynX@bk.ru> (tiny change)
2811
2812 * w32.c (sys_rename): Report EXDEV when rename of a directory
2813 fails because the target is on another logical disk. (Bug#10284)
2814
75bf0d33
DB
28152012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2816
2817 * xterm.c (x_embed_request_focus): New function.
2818
2819 * xterm.h: Add prototype.
2820
2821 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2822
1c6e5a32
GM
28232012-01-05 Glenn Morris <rgm@gnu.org>
2824
2825 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2826
651e947e
EZ
28272012-01-01 Eli Zaretskii <eliz@gnu.org>
2828
2829 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2830 Load gnutls_transport_set_lowat only if GnuTLS version is below
2831 2.11.1.
2832 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2833 GnuTLS versions below 2.11.1.
2834
3778cdd8
AL
28352011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2836
2837 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2838 to the doc string advising against its use for altering the way
2839 windows are scrolled.
2840
0e5317f7
KH
28412011-12-28 Kenichi Handa <handa@m17n.org>
2842
2843 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2844 coding-system ASCII compatible only when it does not produce BOM
2845 on encoding (Bug#10383).
2846
93d5ca1f
JD
28472011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2848
2849 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2850 can scroll.
2851 (create_and_show_popup_menu): Always use menu_position_func for
2852 Gtk3 (Bug#10361).
2853
ca22b785
AS
28542011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2855
2856 * callint.c (Fcall_interactively): Don't truncate prompt string.
2857
d048e1e6
EZ
28582011-12-23 Eli Zaretskii <eliz@gnu.org>
2859
2860 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2861 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2862 resumed from there (after widening). (Bug#10360)
d048e1e6 2863
5ccaba1f
JD
28642011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2865
2866 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2867
204ee57f
JD
28682011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2869
b81d40f0
JB
2870 * nsterm.m (x_free_frame_resources):
2871 Release f->output_data.ns->miniimage.
204ee57f
JD
2872 (ns_index_color): Fix indentation. Do not retain
2873 color_table->colors[i].
2874
2875 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2876 before returning.
2877
2878 * nsfns.m (x_set_background_color): Assign return value from
2879 ns_index_color to face-background instead of NSColor*.
2880 (ns_implicitly_set_icon_type): Fix indentation.
2881 Change assignment in for loop to comparison.
2882
2883 * emacs.c (ns_pool): New variable.
2884 (main): Assign ns_pool.
2885 (Fkill_emacs): Call ns_release_autorelease_pool.
2886
2887 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2888 autorelease fdesc, release fdAttrs and tdict.
2889 (ns_get_covering_families): Release charset.
2890 (ns_findfonts): Release NSFontDescriptor created with new.
2891 (ns_uni_to_glyphs): Fix indentation.
2892 (setString): Release attrStr before assigning new value.
2893
c803b2b7
JD
28942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2895
678f4426
JD
2896 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2897 and NS_IMPL_COCOA.
2898 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2899 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2900
cd394be1 29012011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2902
5fecd5fc
JD
2903 * nsterm.m (ns_term_init): Subscribe for notifications
2904 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2905 to method trackingNotification in EmacsMenu.
2906
2907 * nsmenu.m (trackingMenu): New variable.
3771cb17 2908 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2909 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2910 from Aquamacs (Bug#7030).
678f4426
JD
2911
29122011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2913
c803b2b7
JD
2914 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2915 (symbol_to_nsstring): Fix indentation.
2916 (ns_symbol_to_pb): New function.
cae07000
SM
2917 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2918 (Fns_rotate_cut_buffers_internal): Remove.
2919 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2920 Fns_store_cut_buffer_internal.
2921 (ns_get_foreign_selection, Fx_own_selection_internal)
2922 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2923 (Fns_get_selection_internal, Fns_store_selection_internal):
2924 Use ns_symbol_to_pb and check if return value is nil.
2925 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2926 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2927 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2928 renamed to Sns_store_selection_internal.
2929 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2930 and remove this function.
2931 (ns_handle_selection_clear): Remove, never used.
2932 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2933 here.
2934
e1b01a3a
KB
29352011-12-17 Ken Brown <kbrown@cornell.edu>
2936
2937 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2938 GID is unknown (Bug#10257).
2939
2adb6e85
PE
29402011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2943 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2944 which caused a build failure on GNU/Linux IA-64. This problem was
2945 introduced by my 2011-10-07 patch.
2946
d1d7b339
JL
29472011-12-15 Juri Linkov <juri@jurta.org>
2948
2949 * image.c (imagemagick_error): New function. (Bug#10112)
2950 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2951 Use `imagemagick_error' where ImageMagick functions return
2952 `MagickFalse'.
2953 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2954 proper order.
2955
100d5755
KH
29562011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2957
2958 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2959 fill background (Bug#8992).
2960
454592a6
MR
29612011-12-13 Martin Rudalics <rudalics@gmx.at>
2962
2963 * window.c (Vwindow_combination_resize)
2964 (Vwindow_combination_limit): Use t instead of non-nil in
2965 doc-strings.
61d4b438
MR
2966 (Vrecenter_redisplay): Add first sentence of doc-string on
2967 separate line.
53524d93 2968 (Frecenter): Fix doc-string typo.
454592a6 2969
3633e3aa
KH
29702011-12-11 Kenichi Handa <handa@m17n.org>
2971
2972 * coding.c (Funencodable_char_position): Pay attention to the
2973 buffer text relocation (Bug#9389).
2974
7b9d523a 29752011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2976
7b9d523a
JD
2977 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2978 gtk_init (Bug#10100).
2979
b73189c6
EZ
29802011-12-10 Eli Zaretskii <eliz@gnu.org>
2981
2982 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2983 IT->string is nil. (Bug#10263)
2984
f7dfe5d6
JD
29852011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2986
83faebb4
JD
2987 * nsterm.h (x_free_frame_resources): Declare.
2988
f7dfe5d6
JD
2989 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2990 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2991
2992 * nsterm.h (ns_get_defaults_value): Declare.
2993
2994 * nsterm.m (ns_default): Call ns_get_defaults_value.
2995
7cd4e72c
EZ
29962011-12-09 Eli Zaretskii <eliz@gnu.org>
2997
2998 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2999 (Bug#10170)
3000
b34d7317
YM
30012011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3002
3003 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3004 that where the value of an _OBJC_* symbol points to is in the .bss
3005 section (Bug#10240).
3006
76470ad1
KH
30072011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3008
3009 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3010 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3011
745fff94
KH
30122011-12-08 Kenichi Handa <handa@m17n.org>
3013
3014 * ftfont.c (get_adstyle_property): Fix previous change
3015 (Bug#10233).
3016
6e44397c
JB
30172011-12-07 Juanma Barranquero <lekktu@gmail.com>
3018
3019 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3020 dirs from the default value of EMACSLOADPATH (bug#10208).
3021
7efa6272
GM
30222011-12-07 Glenn Morris <rgm@gnu.org>
3023
3024 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3025 installation and source directories as well. (Bug#10208)
3026
f6fc4d87
CY
30272011-12-06 Chong Yidong <cyd@gnu.org>
3028
3029 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3030
2bf26180
GM
30312011-12-06 Glenn Morris <rgm@gnu.org>
3032
3033 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3034 as an error, not just -1. (Bug#10217)
3035
3a6ad4f0
CY
30362011-12-05 Chong Yidong <cyd@gnu.org>
3037
3038 * keyboard.c (process_special_events): New function.
3039 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3040
75a3b399
PE
30412011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3042
3043 * coding.c (encode_designation_at_bol): Don't use uninitialized
3044 local variable (Bug#9318).
3045
c3c9e25e
KH
30462011-12-05 Kenichi Handa <handa@m17n.org>
3047
3048 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3049 return Qnil (Bug#8046, Bug#10193).
3050
5eb05ea3
KH
30512011-12-05 Kenichi Handa <handa@m17n.org>
3052
3053 * coding.c (encode_designation_at_bol): New args charbuf_end and
3054 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3055 (coding_set_source): Return how many bytes coding->source was
3056 relocated.
3057 (coding_set_destination): Return how many bytes
3058 coding->destination was relocated.
3059 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3060 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3061
30622011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3063
3064 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3065 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3066 macro (Bug#9318).
3067
30682011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3069
3070 The following changes are to fix Bug#9318.
3071
a79703f5 3072 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3073 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3074 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3075 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3076
7dbda6df
JB
30772011-12-05 Juanma Barranquero <lekktu@gmail.com>
3078
3079 * lisp.h (process_quit_flag): Fix external declaration.
3080
6d5eb5b0
SM
30812011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3082
3083 Don't macro-inline non-performance-critical code.
3084 * eval.c (process_quit_flag): New function.
3085 * lisp.h (QUIT): Use it.
3086
a0c3fad0
JD
30872011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3088
3089 * nsfns.m (get_geometry_from_preferences): New function.
3090 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3091
6c07aac2
AS
30922011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3093
3094 * emacs.c (Qkill_emacs): Define.
3095 (syms_of_emacs): Initialize it.
3096 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3097 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3098 (quit_throw_to_read_char): Add parameter `from_signal'.
3099 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3100 * lisp.h (QUIT): Call Fkill_emacs if requested.
3101
c052ead4
JD
31022011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3103
3104 * widget.c (update_wm_hints): Return if wmshell is null.
3105 (widget_update_wm_size_hints): New function.
3106
3107 * widget.h (widget_update_wm_size_hints): Declare.
3108
3109 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3110 widget_update_wm_size_hints (Bug#10104).
3111
9e49252b
EZ
31122011-12-03 Eli Zaretskii <eliz@gnu.org>
3113
3114 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3115 before a newline, prepare the bidi iterator for consuming the
3116 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3117 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3118
02b16839
JL
31192011-12-02 Juri Linkov <juri@jurta.org>
3120
3121 * search.c (Fword_search_regexp): New Lisp function created from
3122 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3123 (Fword_search_backward, Fword_search_forward)
3124 (Fword_search_backward_lax, Fword_search_forward_lax):
3125 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3126 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3127
0068070e
SM
31282011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3129
3130 * fileio.c (Finsert_file_contents): Move after-change-function call
3131 to before the "handled:" label, since all "goto handled" appear in
3132 cases where the *-change-functions have already been properly called
3133 (bug#10117).
3134
3360a3fc
AS
31352011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3136
3137 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3138 waiting for input. (Bug#10169)
3139
73d6c093
EZ
31402011-11-30 Eli Zaretskii <eliz@gnu.org>
3141
3142 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3143 verifies glyph row's hash code--we have just reallocated the
3144 glyphs, so their contents can be complete garbage. (Bug#10164)
3145
febe6bea
JB
31462011-11-30 Juanma Barranquero <lekktu@gmail.com>
3147
3148 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3149
801a4313
EZ
31502011-11-30 Eli Zaretskii <eliz@gnu.org>
3151
3152 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3153 attributes are tested _before_ calling verify_row_hash, to protect
3154 against GCC re-ordering of the tests. (Bug#10164)
3155
2b56b87e
JD
31562011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3157
3158 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3159
3160 * xterm.c (handle_one_xevent): Only set async_visible and friends
3161 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3162 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3163 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3164
dbf31225
PE
31652011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3168 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3169 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3170 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3171 All uses changed to use GCPRO1 etc.
3172 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3173 Revert to old implementation (i.e., before 2011-03-11).
3174
1305621b
YM
31752011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3176
3177 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3178 of scroll runs so as to avoid assigning disabled bogus rows and
3179 unnecessary graphics copy operations.
3180
8c9afb46
EZ
31812011-11-27 Eli Zaretskii <eliz@gnu.org>
3182
3183 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3184 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3185 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3186 (malloc, free, realloc, calloc): Redirect to e_* only when
3187 compiling Emacs.
3188
3189 * lisp.h (GCTYPEBITS): Move before first use.
3190 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3191 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3192 this macro definition.
3193
3194 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3195 _MSC_VER.
3196
54e9e3bf
JD
31972011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3198
6d5eb5b0
SM
3199 * gtkutil.c (xg_create_frame_widgets):
3200 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3201 present with Gtk+ 2.0.
3202
83aca1cb
PE
32032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 * fileio.c (Finsert_file_contents): Undo previous change; see
3206 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3207
5b76caa4
PE
32082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 Rename locals to avoid shadowing.
3211 * fileio.c (Finsert_file_contents):
3212 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3213 * process.c (wait_reading_process_output):
3214 Rename inner 'proc' to 'p' to avoid shadowing.
3215 Indent for consistency with usual Emacs style.
3216
8c535114
EZ
32172011-11-25 Eli Zaretskii <eliz@gnu.org>
3218
3219 * xdisp.c (redisplay_window): If cursor row is not fully visible
3220 after recentering, and scroll-conservatively is set to a large
3221 number, scroll window by a few more lines to make the cursor fully
3222 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3223 (start_display): Don't move to the next line if the display should
3224 start at a newline that is part of a display vector or an overlay
3225 string. (Bug#10119)
8c535114 3226
fa4fdb5c
JL
32272011-11-24 Juri Linkov <juri@jurta.org>
3228
3229 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3230 after the `MagickPingImage' call. (Bug#10112)
3231
90ec88df
CY
32322011-11-23 Chong Yidong <cyd@gnu.org>
3233
3234 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3235
56e2e794
MR
32362011-11-23 Martin Rudalics <rudalics@gmx.at>
3237
3238 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3239 making another buffer current. (Bug#10114)
3240
b6e64c41
GM
32412011-11-23 Glenn Morris <rgm@gnu.org>
3242
3243 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3244
6b21de18
CY
32452011-11-23 Chong Yidong <cyd@gnu.org>
3246
3247 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3248 using it (Bug#5984).
3249
b12cd789
EZ
32502011-11-22 Eli Zaretskii <eliz@gnu.org>
3251
3252 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3253 and header-lines, as they don't have one computed for them.
3254 (Bug#10098)
3255
3256 * .gdbinit (prow): Make displayed values more self-explaining.
3257 Add row's hash code.
3258
261b6fd4
LMI
32592011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260
3261 * process.c (wait_reading_process_output): Fix asynchrounous
3262 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3263 (wait_reading_process_output): Add comment and URL.
261b6fd4 3264
e7cfd277
JD
32652011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3266
3267 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3268
a9b9b7f5
CY
32692011-11-21 Chong Yidong <cyd@gnu.org>
3270
3271 * window.c (Fnext_window, Fprevious_window): Doc fix.
3272
b0d15b4f
SM
32732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3274
3275 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3276
fe7a3057
JB
32772011-11-20 Juanma Barranquero <lekktu@gmail.com>
3278
3279 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3280
d2999b1a
MR
32812011-11-20 Martin Rudalics <rudalics@gmx.at>
3282
3283 * window.c (Fset_window_combination_limit): Rename argument
3284 STATUS to LIMIT.
3285 (Vwindow_combination_limit): Remove "status" from doc-string.
3286
d5ff9cd0
AS
32872011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3288
3289 * m/ibms390.h: Remove.
3290 * m/ibms390x.h: Don't include "ibms390.h".
3291
a5bb9bd3
SM
32922011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3293
3294 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3295 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3296
cd1181db
JB
32972011-11-20 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * casetab.c (Fset_case_table):
3300 * charset.c (Fcharset_after): Fix typos.
3301
615a3b8d 33022011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3303
17e845af
PE
3304 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3305 Otherwise, valgrind does not work on some platforms.
3306 Problem reported by Andreas Schwab in
6a0bf43d
PE
3307 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3308 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3309 is set, removing the need for VIRT_ADDRESS_VARIES.
3310 (PURE_P): Use a more-efficient implementation that needs just one
3311 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3312 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3313 to 4 (xorl, subq, cmpq, setbe).
3314 * alloc.c (pure): Always extern now, since that's the
3315 VIRT_ADDR_VARIES behavior.
3316 (PURE_POINTER_P): Use a single comparison, not two, for
3317 consistency with the new puresize.h.
3318 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3319 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3320 Remove VIRT_ADDR_VARIES no longer needed.
3321
f8fe6f96
EZ
33222011-11-19 Eli Zaretskii <eliz@gnu.org>
3323
3324 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3325 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3326 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3327 behave as if the cursor position were at the window margin.
3328
3329 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3330 and the cursor position is out of bounds, behave as if the cursor
3331 position were at the window margin. (Bug#10075)
3332
df05a53c
CY
33332011-11-18 Chong Yidong <cyd@gnu.org>
3334
3335 * window.c (Fwindow_combination_limit): Make first argument
3336 non-optional, since it is meaningless for live windows like the
3337 selected window.
61ccba97 3338
2071918e
DA
33392011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3340
3341 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3342
b50a28de
SM
33432011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3344
3345 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3346 (graft_intervals_into_buffer): Simplify.
3347
015137db
EZ
33482011-11-18 Eli Zaretskii <eliz@gnu.org>
3349
3350 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3351 hash values of the two rows.
3352 (copy_row_except_pointers): Preserve the used[] arrays and the
3353 hash values of the two rows. (Bug#10035)
68c95424 3354 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3355
3356 * xdisp.c (row_hash): New function, body extracted from
3357 compute_line_metrics.
3358 (compute_line_metrics): Call row_hash, instead of computing the
3359 hash code inline.
3360
3361 * dispnew.c (verify_row_hash): Call row_hash for computing the
3362 hash code of a row, instead of duplicating code from xdisp.c.
3363
3364 * dispextern.h (row_hash): Add prototype.
3365
a2addb04
TH
33662011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3367
3368 * frame.c (delete_frame): Don't delete the terminal when the last
3369 X frame is closed if emacs is built with GTK toolkit.
3370
df85d315
JB
33712011-11-17 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3374
a0c2d0ae
MR
33752011-11-17 Martin Rudalics <rudalics@gmx.at>
3376
3377 * window.c (Vwindow_splits): Rename to
3378 Vwindow_combination_resize. Suggested by Juri Linkov.
3379 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3380 of Vwindow_splits.
3381
58179cce
JB
33822011-11-16 Juanma Barranquero <lekktu@gmail.com>
3383
7877f373
JB
3384 * nsfns.m (Fns_font_name):
3385 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3386
b6f67890
MR
33872011-11-16 Martin Rudalics <rudalics@gmx.at>
3388
3389 * window.h (window): Rename slot "nest" to "combination_limit".
3390 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3391 (Fset_window_nest): Rename to Fset_window_combination_limit.
3392 (Vwindow_nest): Rename to Vwindow_combination_limit.
3393 (recombine_windows, make_parent_window, make_window)
3394 (Fsplit_window_internal, saved_window)
3395 (Fset_window_configuration, save_window_save): Rename all
3396 occurrences of window_nest to window_combination_limit.
3397
c7015153
JB
33982011-11-15 Juanma Barranquero <lekktu@gmail.com>
3399
3400 * image.c (imagemagick_load_image): Fix typo.
3401
322ad6ec
EZ
34022011-11-14 Eli Zaretskii <eliz@gnu.org>
3403
3404 * xdisp.c (display_line): Move the call to
3405 highlight_trailing_whitespace before the call to
3406 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3407 faces of all the glyphs to compute ROW's hash value.
3408 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3409
f067b8ec
JB
34102011-11-14 Juanma Barranquero <lekktu@gmail.com>
3411
3412 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3413 just return (bug#10044).
3414
1e5b2111
EZ
34152011-11-12 Eli Zaretskii <eliz@gnu.org>
3416
7ef3cbd5
EZ
3417 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3418 with user-defined heap size. Bump the default size of the temacs
3419 heap to 27MB, to avoid memory warning when running temacs.
3420 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3421
1e5b2111
EZ
3422 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3423 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3424 (verify_row_hash) [XASSERTS]: New function.
3425 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3426 that the hash value of glyph rows is correct.
1e5b2111 3427
89d61221
MR
34282011-11-12 Martin Rudalics <rudalics@gmx.at>
3429
3430 * window.h (window): Remove splits slot.
3431 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3432 (Fdelete_other_windows_internal, make_parent_window)
3433 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3434 (Fset_window_configuration, save_window_save): Don't deal with
3435 split status of windows.
3436 (saved_window): Remove splits slot.
3437 (Vwindow_splits): Rewrite doc-string.
3438
97f18cc8
JD
34392011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3440
3441 * xfns.c (unwind_create_frame):
3442 * nsfns.m (unwind_create_frame):
3443 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3444 Vframe_list (Bug#9999).
3445
22a648b4
DA
34462011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3447
0b381c7e 3448 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3449
659afede
KH
34502011-11-11 Kenichi Handa <handa@m17n.org>
3451
3452 * callproc.c (Fcall_process): Set the member dst_multibyte of
3453 process_coding.
3454
9ac0394b
KH
34552011-11-11 Johan Bockgård <bojohan@gnu.org>
3456
3457 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3458 avoid a crash (bug#9496).
3459
2fbdc249
CY
34602011-11-09 Chong Yidong <cyd@gnu.org>
3461
3462 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3463 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3464
ac6b1f81
PE
34652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3466
3467 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3468
09db192c
PE
34692011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 Avoid some portability problems by eschewing 'extern inline' functions.
3472 The trivial performance wins aren't worth the portability hassles; see
3473 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3474 et seq.
3475 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3476 (window_box_width, window_box_left, window_box_left_offset)
3477 (window_box_right, window_box_right_offset): Undo previous change,
3478 by removing the "extern"s.
3479 * intervals.c (adjust_intervals_for_insertion)
3480 (adjust_intervals_for_deletion): Undo previous change,
3481 making these static again.
3482 (offset_intervals, temp_set_point_both, temp_set_point)
3483 (copy_intervals_to_string): No longer inline.
3484 * xdisp.c (window_text_bottom_y, window_box_width)
3485 (window_box_height, window_box_left_offset)
3486 (window_box_right_offset, window_box_left, window_box_right)
3487 (window_box): No longer inline.
3488
105216ed
CY
34892011-11-08 Chong Yidong <cyd@gnu.org>
3490
3491 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3492 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3493 Signal an error if not a live window.
105216ed
CY
3494 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3495 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3496
ae9e237f
JB
34972011-11-07 Juanma Barranquero <lekktu@gmail.com>
3498
3499 * lisp.h (syms_of_abbrev): Remove declaration.
3500 Reported by CHENG Gao <chenggao@royau.me>.
3501
c7aa8333
EZ
35022011-11-07 Eli Zaretskii <eliz@gnu.org>
3503
3504 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3505 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3506 of temacs in GUI mode.
3507
be7f5545
MR
35082011-11-07 Martin Rudalics <rudalics@gmx.at>
3509
3510 * window.h: Declare delete_all_child_windows instead of
3511 delete_all_subwindows.
3512 * window.c (Fwindow_nest, Fset_window_nest)
3513 (Fset_window_new_total, Fset_window_new_normal)
3514 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3515 (delete_all_subwindows): Rename to delete_all_child_windows.
3516 (Fdelete_other_windows_internal, Fset_window_configuration):
3517 Call delete_all_child_windows instead of delete_all_subwindows.
3518 * frame.c (delete_frame): Call delete_all_child_windows instead
3519 of delete_all_subwindows.
3520
ca78dc43
PE
35212011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3524 This is also needed for porting to any host where GC_MARK_STACK is
3525 not GC_MAKE_GCPROS_NOOPS.
3526 (which_symbols): Use it.
3527
a0241d01
KH
35282011-11-07 Kenichi Handa <handa@m17n.org>
3529
3530 * coding.c (coding_set_destination): Check coding->src_pos only
3531 when coding->src_object is a buffer (bug#9910).
3532
3533 * process.c (send_process): Set the member src_multibyte of coding
3534 to 0 (bug#9911) when sending a unibyte text.
3535
3536 * callproc.c (Fcall_process): Set the member src_multibyte of
3537 process_coding to 0 (bug#9912).
3538
a64bfdfa 35392011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3540
3541 * xmenu.c (cleanup_widget_value_tree): New function.
3542 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3543 calling free_menubar_widget_value_tree directly (Bug#9830).
3544
cb41b32a
PE
35452011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 Fix some portability problems with 'inline'.
3548 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3549 (window_box_width, window_box_left, window_box_left_offset)
3550 (window_box_right, window_box_right_offset): Declare extern.
3551 Otherwise, these inline functions do not conform to C99 and
3552 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3553 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3554 * intervals.c (adjust_intervals_for_insertion)
3555 (adjust_intervals_for_deletion): Now extern, because otherwise the
3556 extern inline functions 'offset_intervals' couldn't refer to it.
3557 (static_offset_intervals): Remove.
3558 (offset_intervals): Rewrite using the old contents of
3559 static_offset_intervals. The old version didn't conform to C99
3560 because an extern inline function contained a reference to an
3561 identifier with static linkage.
3562
b7041366
AS
35632011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3564
3565 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3566 GC.
3567
88a37c4d
EZ
35682011-11-06 Eli Zaretskii <eliz@gnu.org>
3569
3570 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3571 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3572 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3573 return Qleft_to_right.
3574
49745b39
CY
35752011-11-06 Chong Yidong <cyd@gnu.org>
3576
3577 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3578 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3579 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3580 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3581 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3582 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3583 (Fwindow_vscroll): Doc fix.
3584 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3585 argument, since it makes no sense to pass a live window and for
3586 consistency with window-child.
3587
1f05cd82
CS
35882011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3589
3590 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3591 support MSVC.
3592
22610910
JR
35932011-11-05 Jason Rumney <jasonr@gnu.org>
3594
3595 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3596 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3597 fonts (Bug#6029).
3598 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3599 bitwise arithmetic preventing use of unicode-sip and non-truetype
3600 opentype fonts.
3601
a06776b2
EZ
36022011-11-05 Eli Zaretskii <eliz@gnu.org>
3603
3ad924ba
EZ
3604 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3605 "emacs"-only part.
3606
a06776b2
EZ
3607 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3608 initialization code to keep similarity to xfns.c after changes
3609 from 2011-11-05.
3610
c9e7db78
JD
36112011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3612
a97f8f3f
JD
3613 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3614 (unwind_create_frame): New function (Bug#9943).
3615 (Fx_create_frame): Restructure code to be more similar to the one in
3616 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3617 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3618 Move terminal->reference_count++ just before making the frame official
3619 (Bug#9943).
3620
3621 * nsterm.m (x_free_frame_resources): New function.
3622 (x_destroy_window): Move code to x_free_frame_resources.
3623
c9e7db78 3624 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3625 (Fx_create_frame, x_create_tip_frame):
3626 Move terminal->reference_count++ just before making the frame
75f1671a 3627 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3628 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3629
a6fc3b5c
EZ
36302011-11-05 Eli Zaretskii <eliz@gnu.org>
3631
3632 Support MSVC build with newer versions of Visual Studio.
3633 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3634 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3635 nt/gmake.defs.
3636
3637 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3638 which are not supported by MSVC.
3639 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3640 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3641 bitfields.
3642 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3643 types in bitfields.
3644 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3645
3646 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3647
58179cce 36482011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3649
3650 Support MSVC build with newer versions of Visual Studio.
3651 * w32.c: Don't include w32api.h for MSVC.
3652 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3653
3654 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3655 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3656 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3657 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3658 e_* cousins.
3659 (alloca) [_MSC_VER]: Define to _alloca.
3660
3661 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3662
3663 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3664
a58c13ed
EZ
36652011-11-04 Eli Zaretskii <eliz@gnu.org>
3666
3667 * xdisp.c (note_mouse_highlight): If either of
3668 previous/next-single-property-change returns nil, treat that as
3669 the beginning or the end of the buffer. (Bug#9955)
3670
fe0b6370
JD
36712011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3672
a58c13ed 3673 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3674 label is not null (Bug#9951).
3675 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3676 may be NULL.
3677
89bd5ee1
EZ
36782011-11-04 Eli Zaretskii <eliz@gnu.org>
3679
3680 * window.c (Fwindow_body_size): Mention in the doc string that the
3681 return value is in frame's canonical units. (Bug#9949)
3682
84c3edb9
EZ
36832011-11-03 Eli Zaretskii <eliz@gnu.org>
3684
4e2fb5c7
EZ
3685 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3686
84c3edb9 3687 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3688 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3689 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3690
bc17a887
EZ
36912011-11-01 Eli Zaretskii <eliz@gnu.org>
3692
3693 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3694 Don't stop backward scan on the continuation glyph, even though
3695 its CHARPOS is positive.
6d5eb5b0
SM
3696 (mouse_face_from_buffer_pos, note_mouse_highlight):
3697 Rename cover_string to disp_string.
bc17a887 3698
4ee88440
MR
36992011-11-01 Martin Rudalics <rudalics@gmx.at>
3700
3701 * window.c (temp_output_buffer_show): Don't use
3702 Vtemp_buffer_show_specifiers.
3703 (Vtemp_buffer_show_specifiers): Remove unused variable.
3704
c2ff3c02
EZ
37052011-10-30 Eli Zaretskii <eliz@gnu.org>
3706
3707 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3708 past the beginning of the current glyph matrix.
3709
58179cce 37102011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3711
3712 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3713 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3714 HAVE_GTK3 (Bug#9869).
b77a6a7f 3715
3b574623
JD
3716 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3717 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3718
b77a6a7f
JD
3719 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3720
3721 * xterm.c: Declare x_handle_net_wm_state to return int.
3722 (handle_one_xevent): Check if we are iconified but don't have
3723 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3724 (get_current_wm_state): Return non-zero if not hidden,
3725 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3726 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3727 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3728 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3729
196e41e4
PE
37302011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3731
3732 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3733 so that this new function doesn't get optimized away by a
3734 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3735
021f2e1a
AS
37362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3737
3738 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3739
8b058d44
EZ
37402011-10-29 Eli Zaretskii <eliz@gnu.org>
3741
3742 Fix the `xbytecode' command.
3743 * .gdbinit (xprintbytestr): New command.
b50a28de 3744 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3745 (xbytecode): Print the byte-code string as well.
3746
4452fb80
EZ
37472011-10-29 Kim Storm <storm@cua.dk>
3748
8b058d44
EZ
3749 * alloc.c (which_symbols): New function.
3750
21b72067
AS
37512011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3752
3753 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3754 line. (Bug#9903)
3755
83ed7b5c
GM
37562011-10-29 Glenn Morris <rgm@gnu.org>
3757
3758 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3759 Not clear what it was for, and it causes various bugs. (Bug#9839)
3760
5a7a728b
EZ
37612011-10-28 Eli Zaretskii <eliz@gnu.org>
3762
3763 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3764 possible random value that matches one of those tested as
3765 condition to clear the mouse face.
3766
d3d0842f
CY
37672011-10-28 Chong Yidong <cyd@gnu.org>
3768
3769 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3770
31b39d13
DN
37712011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3772
3773 * window.c (make_window): Initialize phys_cursor_on_p.
3774
9aba6043
SM
37752011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3776
3777 * lisp.h (struct Lisp_Symbol): Update comments.
3778
c20992f4
JB
37792011-10-28 Juanma Barranquero <lekktu@gmail.com>
3780
3781 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3782
db4f02f2
EZ
37832011-10-28 Eli Zaretskii <eliz@gnu.org>
3784
3785 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3786 <oslsachem@gmail.com> for helping to debug this.
3787
3788 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3789 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3790 (g_b_init_get_glyph_outline_w): New static variables.
3791 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3792 (GetGlyphOutlineW_Proc): New typedefs.
3793 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3794 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3795 New functions.
3796 (w32font_open_internal, compute_metrics):
3797 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3798 instead of calling the "wide" APIs directly.
3799
3800 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3801
3802 * w32.h (syms_of_w32font): Add prototype.
3803
87e68db4
JB
38042011-10-27 Juanma Barranquero <lekktu@gmail.com>
3805
3806 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3807 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3808 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3809 (Fmove_to_window_line): Doc fix.
3810
435c1d67
CY
38112011-10-27 Chong Yidong <cyd@gnu.org>
3812
3813 * process.c (make_process): Set gnutls_state to NULL.
3814
3815 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3816 non-NULL, regardless of GNUTLS_INITSTAGE.
3817 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3818 an error. Set process slots as soon as we allocate them.
3819
3820 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3821
9c6c6f49
CY
38222011-10-27 Chong Yidong <cyd@gnu.org>
3823
9aba6043
SM
3824 * gnutls.c (emacs_gnutls_deinit): New function.
3825 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3826 (Fgnutls_deinit, Fgnutls_boot): Use it.
3827
3828 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3829 (deactivate_process): Call emacs_gnutls_deinit.
3830
657d08d3
JB
38312011-10-27 Juanma Barranquero <lekktu@gmail.com>
3832
3833 * image.c (x_create_x_image_and_pixmap):
3834 * w32.c (sys_rename, w32_delayed_load):
3835 * w32font.c (fill_in_logfont):
3836 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3837
5430d399
JB
38382011-10-26 Juanma Barranquero <lekktu@gmail.com>
3839
3840 * w32fns.c (w32_default_color_map): New function,
3841 extracted from Fw32_default_color_map.
a7ef684b 3842 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3843
fe0055fa
PE
38442011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3847
e6346438
SM
38482011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3849
3850 * keyboard.c (test_undefined): New function (bug#9751).
3851 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3852
e112cc37
ET
38532011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3854
3855 * sysdep.c (init_sys_modes): Fix the check for the controlling
3856 terminal (Bug#6649).
3857
7b5d6677
EZ
38582011-10-20 Eli Zaretskii <eliz@gnu.org>
3859
3860 * dispextern.h (struct bidi_it): New member next_en_type.
3861
3862 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3863 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3864 current character, check also for next_en_type being WEAK_EN.
3865 (bidi_resolve_weak): Don't enter the expensive loop if the current
3866 position is before next_en_pos. Record the bidi type of the first
3867 non-ET, non-BN character we find, in addition to its position.
3868 (bidi_level_of_next_char): Invalidate next_en_type when
3869 next_en_pos is over-stepped.
3870
7da0b018
PE
38712011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3874 * editfns.c: Rewrite current-time-zone so that it invokes
3875 the equivalent of (format-time-string "%Z") to get the time zone name.
3876 This fixes a bug when the time zone name contains characters that
3877 need converting from the system time locale to Emacs internal format.
3878 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3879 that patch fixed format-time-string to do the conversion, but
3880 I forgot to fix current-time-zone.
3881 (format_time_string): New function, containing most of
3882 what Fformat_time_string used to contain.
3883 (Fformat_time_string): Rewrite in terms of format_time_string.
3884 This doesn't change this function's behavior.
3885 (current-time-zone): Rewrite to use format_time_string.
3886 This fixes the bug reported by Michael Schierl in
3887 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3888 Jason Rumney's 2007-06-07 change worked around this bug, but
3889 didn't fix it.
3890 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3891
8547b010
EZ
38922011-10-19 Eli Zaretskii <eliz@gnu.org>
3893
3894 * xdisp.c (start_display): If the character at POS is displayed
3895 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3896 (try_window_reusing_current_matrix): If a line ends in a display
3897 vector or the next line starts in a display vector, continue
3898 redrawing the window even though the character position of
3899 start_row was reached.
8547b010
EZ
3900 (Bug#9771, part 2)
3901
4e948d15
CY
39022011-10-18 Chong Yidong <cyd@gnu.org>
3903
3904 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3905 with nobreak-char-display too.
3906
4787455f
EZ
39072011-10-18 Eli Zaretskii <eliz@gnu.org>
3908
3909 Fix part 3 of bug#9771.
3910 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3911 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3912 non-neutral characters if the current character is a paragraph
3913 separator (a.k.a. Newline). This avoids running the same
3914 expensive loop twice, once when we consume the preceding newline
3915 and the other time when the line actually needs to be displayed.
3916 Avoid the loop when we see neutrals on the base embedding level
3917 following a character whose directionality is the same as the
3918 paragraph's. This avoids running the expensive loop when a line
3919 ends in a long sequence of neutrals, like control characters.
3920 Add assertion against STRONG_AL type. Slightly rearrange code
3921 that determines the type of a neutral given the first non-neutral
3922 that follows it.
3923 (bidi_level_of_next_char): Set next_en_pos to zero when
3924 invalidating its info.
3925
2c91f553
EZ
39262011-10-17 Eli Zaretskii <eliz@gnu.org>
3927
3928 * xdisp.c (push_display_prop): Determine whether to record string
3929 or buffer position by IT->string, not by IT->method. Allow
3930 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3931 (move_it_vertically_backward): Don't look for character position
3932 immediately after the newline when in a continuation line.
3933 (Bug#9771, part 1)
2c91f553 3934
c7b08b0d
MR
39352011-10-15 Martin Rudalics <rudalics@gmx.at>
3936
3937 * window.c (coordinates_in_window): Rewrite and delabelize
3938 vertical border check. (Bug#5357) (Bug#9618)
3939
6b02f655
SM
39402011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3941
3942 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3943 errors in XSetWindowBorder (bug#9310).
3944
81d40c92
DA
39452011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3946
3947 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3948 avoid crash when xmalloc overrun checking is enabled.
3949
d4172c3b
EZ
39502011-10-13 Eli Zaretskii <eliz@gnu.org>
3951
3952 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3953 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3954 cursor motion with <left> and <right> arrow keys.
3955
3956 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3957 some callers set that themselves.
3958
b00eea75
EZ
39592011-10-12 Eli Zaretskii <eliz@gnu.org>
3960
3961 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3962 display string and the previous row comes from the same string and
3963 is empty. (Bug#9739) (Bug#9738)
3964
8fe012c4
SM
39652011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3966
3967 * doc.c (get_doc_string): Encode file name (bug#9735).
3968
0074aef2
EZ
39692011-10-12 Eli Zaretskii <eliz@gnu.org>
3970
79beb178
EZ
3971 * bidi.c (bidi_level_of_next_char):
3972 * xdisp.c (get_visually_first_element): Remove old incorrect
3973 comments regarding the Unicode Line Separator character.
3974
0074aef2
EZ
3975 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3976
6e4b3fbe
DA
39772011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3978
3979 * alloc.c (Fgc_status): Do not access beyond zombies array
3980 boundary if nzombies > MAX_ZOMBIES.
3981 * alloc.c (dump_zombies): Add missing format specifier.
3982
0324f3af
PE
39832011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3984
b5525cac
PE
3985 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3986 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3987
0324f3af
PE
3988 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3989 Some packages use them to denote characters with modifiers.
3990
e9b5f888
AS
39912011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3992
3993 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3994 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3995 matching a pp-number. Rename parameter var to var1.
3996
127827c0
SM
39972011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3998
3999 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4000
c8fd3bd0
GM
40012011-10-08 Glenn Morris <rgm@gnu.org>
4002
4003 * callint.c (Fcall_interactively): Give a more explicit error for the
4004 'c' case with a non-character input. (Bug#8479)
4005
352ec8ff
EZ
40062011-10-08 Eli Zaretskii <eliz@gnu.org>
4007
03669ccb
EZ
4008 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4009 lines.
7061c986
EZ
4010 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4011 lines that are hscrolled on the left.
03669ccb 4012
352ec8ff
EZ
4013 * dispnew.c (buffer_posn_from_coords): Account for a possible
4014 presence of header-line. (Bug#4426)
4015
a66cfb1c
SM
40162011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4017
6b02f655
SM
4018 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4019 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4020
7c5ee88e
PE
40212011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4022
4023 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4024 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4025 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4026 this makes Emacs dump core during garbage collection on rare
4027 occasions. sizeof is obviously inferior to offsetof here, so
4028 stick with offsetof.
4029 (GC_POINTER_ALIGNMENT): New macro.
4030 (mark_memory): Omit 3rd (offset) arg; caller changed.
4031 Don't assume EMACS_INT alignment is the same as pointer alignment.
4032
df1bbe5b
SM
40332011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4034
4035 * keyboard.c (read_key_sequence_remapped): New var.
4036 (read_key_sequence): Compute remapping in the right buffer.
4037 (command_loop_1): Use read_key_sequence's remapping directly.
4038
51553db6
SM
40392011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4040
32c1fffd
SM
4041 * dired.c (file_name_completion): Don't expand file name.
4042 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4043 before checking file name handler.
4044
51553db6
SM
4045 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4046 they've been requested explicitly (bug#9591).
4047
b6bd1599 40482011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4049
4050 * keymap.c (Fsingle_key_description): Use make_specified_string
4051 instead of build_string to build string from push_key_description.
4052 (Bug#5193)
4053
f701dc2a
PE
40542011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4055
4222c55d
PE
4056 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4057 This fixes a Y2038 bug on 64-bit hosts.
4058 * buffer.c (reset_buffer):
4059 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4060 (Fclear_buffer_auto_save_failure):
4061 Use 0, not -1, to represent an unset failure time, since time_t
4062 might not be signed.
4063
f701dc2a
PE
4064 Remove dependency on glibc malloc internals.
4065 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4066 Move back here from lisp.h, but with their new implementations.
4067 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4068 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4069 * charset.c (charset_table_init): New static var.
4070 (syms_of_charset): Use it instead of xmalloc. This removes a
4071 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4072 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4073 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4074 Move back to alloc.c.
4075 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4076 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4077
9ceebf39
JD
40782011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4079
4080 * nsterm.m (windowDidResize): Call x_set_window_size only when
4081 ns_in_resize is true. Otherwise set pixelwidth/height and
4082 call change_frame_size (Bug#9628).
4083
cb993c58
PE
40842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4085
3930c88b
PE
4086 Port --enable-checking=all to Fedora 14 x86-64.
4087 * charset.c (syms_of_charset): Also account for glibc malloc's
4088 internal overhead when calculating the initial malloc maximum.
4089
cb993c58
PE
4090 Port --enable-checking=all to Fedora 14 x86.
4091 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4092 Move to lisp.h.
4093 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4094 (overrun_check_realloc, overrun_check_free):
4095 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4096 That way, xmalloc returns a properly-aligned pointer even if
4097 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4098 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4099 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4100 into account when calculating the initial malloc maximum.
4101 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4102 Move here from alloc.c, so that charset.c can use it too.
4103 Properly align; the old code wasn't right for common 32-bit hosts
4104 when configured with --enable-checking=all.
4105 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4106 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4107
31bed486
EZ
41082011-09-29 Eli Zaretskii <eliz@gnu.org>
4109
04c70788 4110 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4111 use EDOM.
4112
fbcaa2f3
EZ
41132011-09-28 Eli Zaretskii <eliz@gnu.org>
4114
4115 * xdisp.c (compute_display_string_end): If there's no display
4116 string at CHARPOS, return -1.
4117
4118 * bidi.c (bidi_fetch_char): When compute_display_string_end
4119 returns a negative value, treat the character as a normal
4120 character not covered by a display string. (Bug#9624)
4121
a239d4e9
JB
41222011-09-28 Juanma Barranquero <lekktu@gmail.com>
4123
4124 * lread.c (Fread_from_string): Fix typo in docstring.
4125
88652fd5
EZ
41262011-09-27 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4129 newline, reseat the iterator instead of bidi-iterating there one
4130 character at a time. (Bug#9610)
32c1fffd
SM
4131 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4132 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4133
ed497dd4
AS
41342011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4135
4136 * lread.c (readevalloop): Use correct code for NBSP.
4137 (read1): Likewise. (Bug#9608)
4138
b2bf61aa
MA
41392011-09-25 Michael Albinus <michael.albinus@gmx.de>
4140
4141 * dbusbind.c (Fdbus_register_signal): When service is not
4142 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4143
32bbb17c
GM
41442011-09-25 Glenn Morris <rgm@gnu.org>
4145
4146 * buffer.c (truncate-lines): Doc fix.
4147
94e0933e
CY
41482011-09-24 Chong Yidong <cyd@stupidchicken.com>
4149
4150 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4151 (Fset_window_next_buffers): Doc fix.
4152
cddde921
GM
41532011-09-24 Glenn Morris <rgm@gnu.org>
4154
4155 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4156
1260aef1
PE
41572011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4158
25b4bfa0
PE
4159 Fix minor problems found by static checking.
4160 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4161 * indent.c (Fvertical_motion): Fix == vs = typo.
4162
e3cbd34b
EZ
41632011-09-24 Eli Zaretskii <eliz@gnu.org>
4164
a66cfb1c
SM
4165 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4166 Default value is now t. Doc fix.
6bf7006f 4167
e3cbd34b 4168 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4169 logic when moving up, not only when moving down. Fix the
e3cbd34b 4170 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4171 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4172
4173 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4174 CHARPOS is covered by a display string which includes newlines.
4175 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4176 is covered by a display string with embedded newlines.
4177
a3de0cbd
MA
41782011-09-24 Michael Albinus <michael.albinus@gmx.de>
4179
4180 * dbusbind.c (Fdbus_register_signal): Add match rule to
4181 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4182 (Fdbus_register_method, Vdbus_registered_objects_table):
4183 Fix docstring.
a3de0cbd 4184
b260039d
JM
41852011-09-24 Jim Meyering <meyering@redhat.com>
4186
32c1fffd 4187 do not ignore write error for any output size
b260039d
JM
4188 The previous change was incomplete.
4189 While it makes emacs --batch detect the vast majority of stdout
4190 write failures, errors were still ignored whenever the output size is
4191 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4192 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4193 && echo FAIL: ignored write error
4194 FAIL: ignored write error
4195 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4196 && echo FAIL: ignored write error
4197 FAIL: ignored write error
4198 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4199
8eca8a7c
AS
42002011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4201
4202 * emacs.c (Fkill_emacs): In noninteractive mode exit
4203 non-successfully if a write error occurred on stdout. (Bug#9574)
4204
3341db62
EZ
42052011-09-21 Eli Zaretskii <eliz@gnu.org>
4206
4207 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4208 the xassert test.
4209
4210 * dispextern.h (struct it): Update the comment documenting what
4211 can it->OBJECT be.
4212
8c203dbf
EZ
42132011-09-20 Eli Zaretskii <eliz@gnu.org>
4214
4215 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4216 a display string, extend search for cursor position to end of row.
4217 (find_row_edges): If the row ends in a newline from a display
4218 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4219 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4220 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4221 non-empty line. Fixes confusing cursor motion with arrow keys at
4222 the beginning of a line that starts with whitespace.
8c203dbf 4223
a4824228
LMI
42242011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4225
4226 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4227 (bug#9493).
4228
33ed493b
CY
42292011-09-18 Chong Yidong <cyd@stupidchicken.com>
4230
4231 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4232 boolean (Bug#9154).
4233
56cd55c8
EZ
42342011-09-18 Eli Zaretskii <eliz@gnu.org>
4235
4236 * xdisp.c (display_line): Record maximum and minimum buffer
4237 positions even if no glyphs were produced (e.g., by a zero-width
4238 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4239 buffer positions that will be removed from the glyph row because
4240 they don't fit.
c02dcedf
EZ
4241 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4242 column is beyond frame width: don't subtract 1 "pixel" when
4243 computing width of the stretch.
3e62b7e0
EZ
4244 (reseat_at_next_visible_line_start): Undo the change made on
4245 2011-09-17 that saved paragraph information and restored it after
4246 the call to `reseat'. (Bug#9545)
56cd55c8 4247
5ed99d36 42482011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4249
4250 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4251 and turn window cursor on if cleared (Bug#9415).
4252
5ed99d36 42532011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4254
4255 * search.c (boyer_moore): Take unibyte characters from pattern
4256 literally. (Bug#9458)
4257
9bade7b2
EZ
42582011-09-18 Eli Zaretskii <eliz@gnu.org>
4259
4260 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4261
e5e9d610
PE
42622011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4263
87e4427a
PE
4264 Fix minor problem found by static checking.
4265 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4266 initialized, to pacify gcc -Wuninitialized.
4267
e5e9d610
PE
4268 * fileio.c: Report proper errno when syscall falls.
4269 (Finsert_file_contents): Save and restore errno,
4270 so that report_file_error outputs the correct diagnostic.
4271 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4272
a1674f0b
EZ
42732011-09-18 Eli Zaretskii <eliz@gnu.org>
4274
4275 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4276
fbfb6dd4
EZ
42772011-09-17 Eli Zaretskii <eliz@gnu.org>
4278
4279 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4280 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4281
bb187662
EZ
42822011-09-17 Eli Zaretskii <eliz@gnu.org>
4283
1137e8b8 4284 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4285 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4286
4287 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4288 (bidi_find_paragraph_start): Search back for paragraph beginning
4289 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4290 (bidi_move_to_visually_next): Only trigger paragraph-related
4291 computations when the last character is a newline or at EOB, not
4292 just any NEUTRAL_B. (Bug#9470)
4293
bb187662
EZ
4294 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4295 truncated lines if point is covered by a display string. (Bug#9524)
4296
2e621251
PE
42972011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4298
4299 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4300 (cons_to_x_long): New function.
4301 (lisp_data_to_selection_data): Use it. Correct the test for
4302 short-versus-long data; it was negated. Break out of vector
4303 loop, for efficiency, when a long datum is discovered.
4304
91a15bc6
SM
43052011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4306
4307 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4308
b41c3a35
EZ
43092011-09-16 Eli Zaretskii <eliz@gnu.org>
4310
4311 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4312 GCC PR/17406) by declaring this function with external scope.
4313
7812ba2d
PE
43142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4315
4316 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4317 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4318
cf7edc2a
AS
43192011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4320
4321 * editfns.c (Fformat): Correctly handle text properties on "%%".
4322
bd01620e
EZ
43232011-09-15 Eli Zaretskii <eliz@gnu.org>
4324
4325 * xterm.c (x_draw_composite_glyph_string_foreground):
4326 * w32term.c (x_draw_composite_glyph_string_foreground):
4327 * term.c (encode_terminal_code):
4328 * composite.c (composition_update_it, get_composition_id):
4329 * xdisp.c (get_next_display_element)
4330 (fill_composite_glyph_string): Add comments about special meaning
4331 of TAB characters in a composition.
4332
a02719a3
PE
43332011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4336 This occurs when processing a multibyte format.
4337 Problem reported by Wolfgang Jenker.
a02719a3 4338
72589a3c
JB
43392011-09-15 Johan Bockgård <bojohan@gnu.org>
4340
4341 * xdisp.c (try_cursor_movement): Only check for exact match if
4342 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4343
1c14176c
PE
43442011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 Remove unused external symbols.
4347 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4348 * xdisp.c (calc_pixel_width_or_height): Now static.
4349 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4350 * indent.c (check_display_width):
4351 * w32term.c: Fix comment to match code.
4352 * xterm.c, xterm.h (x_catching_errors): Remove.
4353
d2eea5b5
PE
43542011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4355
4356 * xselect.c: Use signed conversions more consistently (Bug#9498).
4357 (selection_data_to_lisp_data): Assume incoming selection data are
4358 signed integers, not unsigned. This is to be consistent with
4359 outgoing selection data, which was modified to use signed integers
4360 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4361 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4362 expects long, not unsigned long.
4363
46888499
EZ
43642011-09-14 Eli Zaretskii <eliz@gnu.org>
4365
4366 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4367 computation of loop end. Reported by Johan Bockgård
4368 <bojohan@gnu.org>.
4369
ef8ef9fb
CY
43702011-09-13 Chong Yidong <cyd@stupidchicken.com>
4371
4372 * frame.c (Fother_visible_frames_p): Function deleted.
4373
fa819fed
EZ
43742011-09-12 Eli Zaretskii <eliz@gnu.org>
4375
4376 * indent.c (compute_motion): Process display vector front to back
4377 rather than the other way around. (Bug#2496)
4378
2ba8e008
SM
43792011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4380
4381 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4382
20f53c69
CY
43832011-09-11 Chong Yidong <cyd@stupidchicken.com>
4384
4385 * minibuf.c (Fread_from_minibuffer): Doc fix.
4386
d562d7a4
EZ
43872011-09-11 Eli Zaretskii <eliz@gnu.org>
4388
4389 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4390 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4391
1c4d7f3d
LMI
43922011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4393
4394 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4395 value for non-existent files.
4396
b885bf36
EZ
43972011-09-11 Eli Zaretskii <eliz@gnu.org>
4398
4399 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4400 set its "size" to -1. This will set the modtime_size field of
4401 the corresponding buffer to -1, which is what
4402 verify-visited-file-modtime expects for files that do not exist.
4403 (Bug#9139)
4404
6612f0bf
PE
44052011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4406
4407 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4408 here ...
4409 * lisp.h: ... from here. push_key_description is no longer
4410 defined in keyboard.c, so its declaration should not be in
4411 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4412 logically belongs with push_key_description.
4413
dfb3f755
PE
44142011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4415
4416 * buffer.h: Include <sys/types.h> instead of <time.h>.
4417 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4418 Problem reported by Herbert J. Skuhra.
4419
3134906c
LMI
44202011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4421
4422 * xml.c (parse_region): Make the parsing work for
4423 non-comment-starting XML files again (bug#9144).
4424
8d903f4e
AS
44252011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4426
4427 * image.c (gif_load): Fix calculation of bottom and right corner.
4428 (Bug#9468)
4429
80ad64f4
EZ
44302011-09-10 Eli Zaretskii <eliz@gnu.org>
4431
4432 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4433 redisplay in small windows.
4434
208a048d
EZ
44352011-09-09 Eli Zaretskii <eliz@gnu.org>
4436
4437 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4438
9b1c252e
MR
44392011-09-08 Martin Rudalics <rudalics@gmx.at>
4440
4441 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4442 Operate on live windows only.
4443
2949f33b
JB
44442011-09-08 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4447
e08dcafd
EZ
44482011-09-07 Eli Zaretskii <eliz@gnu.org>
4449
4450 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4451 only under bidi iteration.
4452
115b96bd
JD
44532011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4454
4455 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4456
c8199d0f
PE
44572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4458
4459 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4460 Without this fix, the command to link temacs failed due to an
4461 undefined symbol __builtin_isnan. This is because
4462 /usr/include/iso/math_c99.h #defines isnan(x) to
4463 __builtin_isnan(x), but the bundled gcc, which identifies itself
4464 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4465 a __builtin_isnan.
4466 * floatfns.c (isnan): #undef, and then #define to a clone of
4467 what's in data.c.
4468 (Fisnan): Always define, since it's always available now.
4469 (syms_of_floatfns): Always define isnan at the Lisp level.
4470
e39b275c 44712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4472
4473 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4474
b2db44d9 44752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4476
f4af5137 4477 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4478 The previous code assumed that file offsets (off_t values) fit in
4479 EMACS_INT variables, which is not true on typical 32-bit hosts.
4480 The code messed up by falsely reporting buffer overflow in cases
4481 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4482 when "big" contains more than 2**29 bytes, even though this
4483 inserts just one byte and does not overflow the buffer.
4484 (Finsert_file_contents): Store file offsets as off_t
4485 values, not as EMACS_INT values. Check for overflow when
4486 converting between EMACS_INT and off_t. When checking for
4487 buffer overflow or for overlap, take the offsets into account.
4488 Don't use EMACS_INT for small values where int suffices.
4489 When checking for overlap, fix a typo: ZV was used where
4490 ZV_BYTE was intended.
4491 (Fwrite_region): Don't assume off_t fits into 'long'.
4492 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4493
ecfc0a49
MA
44942011-09-05 Michael Albinus <michael.albinus@gmx.de>
4495
4496 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4497
6511acf2 44982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4499
0999621a 4500 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4501
4502 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4503 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4504 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4505 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4506 (modify_event_symbol): Do not assume that the length of
4507 name_alist_or_stem is safe to alloca and fits in int.
4508 (Fexecute_extended_command): Likewise for function name and binding.
4509 (Frecursion_depth): Wrap around reliably on integer overflow.
4510 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4511 since some callers pass EMACS_INT values.
4512 (Fsingle_key_description): Don't crash if symbol name contains more
4513 than MAX_ALLOCA bytes.
4514 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4515 (get_minibuffer): Arg is now EMACS_INT, not int.
4516 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4517 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4518 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4519
2be7d702
PE
4520 * dbusbind.c (signature_cat): New function.
4521 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4522 Do not overrun buffer; instead, report string overflow.
4523
9d1df220
PE
4524 * dispnew.c (add_window_display_history): Don't overrun buffer.
4525 Truncate instead; this is OK since it's just a log.
4526
33ef5c64
PE
4527 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4528 even if the time zone offset is outlandishly large.
4529 Don't mishandle offset == INT_MIN.
4530
66c6fdd5
PE
4531 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4532 when creating daemon; the previous buffer-overflow check was incorrect.
4533
d749b01b
PE
4534 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4535 which has the guts of the old verror function.
4536
b5cd1905
PE
4537 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4538 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4539
6e1a67fb
PE
4540 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4541 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4542 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4543 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4544 length of string rather than counting it via multiple sprintfs;
4545 that's simpler and more reliable.
c21721cc
PE
4546 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4547 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4548 sprintf, in case result does not fit in int.
4549
c57b67fc
PE
4550 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4551 (fontset_from_font): Print it.
4552
8a401434
PE
4553 * frame.c (tty_frame_count): Now printmax_t, not int.
4554 (make_terminal_frame, set_term_frame_name): Print it.
4555 (x_report_frame_params): In X, window IDs are unsigned long,
4556 not signed long, so print them as unsigned.
4557 (validate_x_resource_name): Check for implausibly long names,
4558 and don't assume name length fits in 'int'.
4559 (x_get_resource_string): Don't blindly alloca invocation name;
4560 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4561 not fit in int.
4562
6e1a67fb
PE
4563 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4564 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4565 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4566
0df02bf3
PE
4567 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4568 Use esprintf, not sprintf, in case result does not fit in int.
4569
48e30793
PE
4570 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4571 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4572 it as a large positive number.
4573 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4574 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4575
a66ff6d8
PE
4576 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4577 in case result does not fit in int.
4578
aca216ff
PE
4579 * print.c (float_to_string): Detect width overflow more reliably.
4580 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4581 buffer overrun. Don't assume list length fits in 'int'. Treat
4582 print length of 0 as 0, not as infinity; to be consistent with other
4583 uses of print length in this function. Don't overflow print length
4584 index. Don't assume hash table size fits in 'long', or that
4585 vectorlike size fits in 'unsigned long'.
4586
31c286f7
PE
4587 * process.c (make_process): Use printmax_t, not int, to format
4588 process-name gensyms.
4589
55e5faa1
PE
4590 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4591
80f2e268
PE
4592 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4593 to avoid potential buffer overrun.
4594
670741ab
PE
4595 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4596 if X resource line is longer than 512 bytes.
4597
b7163a50
PE
4598 * xfns.c (x_window): Make sprintf buffer a bit bigger
4599 to avoid potential buffer overrun.
4600
ae58ff1f
PE
4601 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4602
c43c8a6a
PE
4603 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4604
3f8236f4
PE
46052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4606
53e9fe90 4607 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4608 Without these, Emacs silently mishandles large integers sometimes.
4609 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4610 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4611
6511acf2
PE
4612 * xdisp.c (try_window_id): Check Emacs fixnum range before
4613 converting to 'int'.
806add1d 4614
6511acf2 4615 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4616 Check that an Emacs fixnum is in range before assigning it to 'int'.
4617 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4618 values converted from Emacs fixnums.
4619 (Frecenter): Don't wrap around a line count if it is out of 'int'
4620 range; instead, treat it as an extreme value.
4621 (Fset_window_configuration, compare_window_configurations):
4622 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4623
6511acf2
PE
4624 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4625 that can exceed INT_MAX. Check that EMACS_INT value is in range
4626 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4627 (match_limit): Don't assume that a fixnum can fit in 'int'.
4628
6511acf2 4629 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4630 exceed INT_MAX.
4631
6511acf2 4632 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4633 (Fvertical_motion): Don't wrap around LINES values that don't fit
4634 in 'int'. Instead, treat them as extreme values. This is good
4635 enough for windows, which can't have more than INT_MAX lines anyway.
4636
fcb901a7
LMI
46372011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4638
0f2f6b6d
LMI
4639 * Require libxml/parser.h to avoid compilation warning.
4640
fcb901a7
LMI
4641 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4642
4643 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4644 since this reportedly can destroy thread storage.
4645
6e20a0d4
CY
46462011-08-30 Chong Yidong <cyd@stupidchicken.com>
4647
4648 * syntax.c (find_defun_start): Update all cache variables if
4649 exiting early (Bug#9401).
4650
148ae00e
EZ
46512011-08-30 Eli Zaretskii <eliz@gnu.org>
4652
f6cfbd8f
EZ
4653 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4654
148ae00e
EZ
4655 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4656 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4657 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4658
4659 * term.c (tty_append_glyph): New function.
4660 (produce_stretch_glyph): Static function and its prototype deleted.
4661
a66cfb1c
SM
4662 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4663 Add prototypes.
148ae00e 4664
c4a07a4c
PE
46652011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4666
4667 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4668 when checking :margin (Bug#9390).
4669 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4670 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4671 so that the name doesn't mislead. All uses changed.
4672
6bc8cd65
JB
46732011-08-28 Johan Bockgård <bojohan@gnu.org>
4674
4675 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4676 set_tty_hooks.
4677
dca4927e
EZ
46782011-08-27 Eli Zaretskii <eliz@gnu.org>
4679
4680 * xdisp.c (move_it_to): Don't bail out early when reaching
4681 position beyond to_charpos, if we are scanning backwards.
4682 (move_it_vertically_backward): When DY == 0, make sure we get to
4683 the first character in the line after the newline.
4684
f2cad773
PE
46852011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4686
4687 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4688 (ccl_driver): Do not generate an out-of-range pointer.
4689 (Fccl_execute_on_string): Remove unnecessary check for
4690 integer overflow, noted by Stefan Monnier in
4691 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4692 Remove a FIXME that didn't need fixing.
4693 Simplify the newly-introduced buffer reallocation code.
4694
0cae2cdb
JB
46952011-08-27 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4698
5fc295a4 46992011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4700
70c60eb2 4701 Integer and memory overflow issues (Bug#9196).
726e0ab1 4702
d31850da
PE
4703 * doc.c (get_doc_string): Rework so that
4704 get_doc_string_buffer_size is the actual buffer size, rather than
4705 being 1 less than the actual buffer size; this makes xpalloc more
4706 convenient.
4707
a69fbedb
PE
4708 * image.c (x_allocate_bitmap_record, cache_image):
4709 * xselect.c (Fx_register_dnd_atom):
4710 Simplify previous changes by using xpalloc.
4711
fe5c5d37
PE
4712 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4713 since either will do and ptrdiff_t is convenient with xpalloc.
4714
0065d054
PE
4715 * charset.c (charset_table_size)
4716 (struct charset_sort_data.priority): Now ptrdiff_t.
4717 (charset_compare): Don't overflow if priorities differ greatly.
4718 (Fsort_charsets): Don't assume list length fits in int.
4719 Check for size-calculation overflow when allocating sort data.
4720 (syms_of_charset): Allocate an initial charset table that is
4721 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4722
4723 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4724
4725 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4726 The actual value is always <= INT_MAX, and leaving it unsigned made
4727 overflow checking harder.
4728
4729 * dispextern.h (struct glyph_matrix.rows_allocated)
4730 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4731 with xpalloc. The values are still always <= INT_MAX.
4732
4733 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4734
4735 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4736 (SAFE_NALLOCA): New macro.
4737
4738 * region-cache.c (struct boundary.pos, find_cache_boundary)
4739 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4740 (set_cache_region, invalidate_region_cache)
4741 (revalidate_region_cache, know_region_cache, region_cache_forward)
4742 (region_cache_backward, pp_cache):
4743 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4744 so that ptrdiff_t * can be passed to xpalloc.
4745 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4746 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4747 (pp_cache): Don't assume cache_len fits in int.
4748 * region-cache.h: Adjust extern decls to match.
4749
4750 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4751 EMACS_INT, since either will do, for xpalloc.
4752
4753 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4754 (xnmalloc, xnrealloc, xpalloc): New functions.
4755
726e0ab1
PE
4756 * bidi.c (bidi_shelve_header_size): New constant.
4757 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4758 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4759
51f30bc5 4760 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4761 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4762 (overlay_strings):
4763 Don't update size of array until after memory allocation succeeds,
4764 because xmalloc/xrealloc may not return.
0065d054
PE
4765 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4766 now that we have proper integer overflow checking.
4767 (record_overlay_string, overlay_strings): Catch overflows when
4768 calculating size of overlay_str_buf.
726e0ab1 4769
0065d054
PE
4770 * callproc.c (Fcall_process): Check for size overflow when
4771 calculating size of args2.
4772 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4773 Normally we prefer signed values, but sticking with ptrdiff_t would
4774 require adding more-complicated checks.
726e0ab1
PE
4775
4776 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4777 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4778 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4779 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4780
4781 * character.c (Fstring): Check for size-calculation overflow.
4782
4783 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4784 unnecessary integer overflow. Check for size overflow.
4785 (encode_coding_object): Don't update size until xmalloc succeeds.
4786
4787 * composite.c (get_composition_id): Check for overflow in glyph
4788 length calculations.
4789
4790 Integer and memory overflow fixes for display code.
4791 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4792 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4793 (scrolling_window): Check for overflow in size calculations.
4794 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4795 Don't assume glyph table len fits in int.
4796 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4797 (row_table_size): Now ptrdiff_t, not int.
4798 (scrolling_window): Avoid overflow in size calculations.
4799 Don't update size until allocation succeeds.
4800 * fns.c (concat): Check for overflow in size calculations.
4801 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4802 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4803 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4804
4805 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4806 (get_doc_string): Check for size calculation overflow.
4807 Don't update size until allocation succeeds.
4808 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4809 EMACS_INT, where ptrdiff_t will do.
4810 (Fsubstitute_command_keys): Check for string overflow.
4811
4812 * editfns.c (set_time_zone_rule): Don't assume environment length
4813 fits in int.
4814 (message_length): Now ptrdiff_t, not int.
4815 (Fmessage_box): Don't update size until allocation succeeds.
4816 Don't assume message length fits in int.
4817 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4818
0065d054
PE
4819 * emacs.c (main): Do not reallocate argv, since there is a null at
4820 the end that can be overwritten, and this way there's no need to
4821 worry about size-calculation overflow.
4822 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4823
4824 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4825 alloc succeeds.
4826 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4827
4828 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4829 (x_set_scroll_bar_width, x_figure_window_size):
4830 Check for integer overflow.
4831 (x_set_alpha): Do not assume XINT fits in int.
4832
4833 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4834 This is for the members text_lines, text_cols, total_lines, total_cols,
4835 where the system imposes an 'int' limit.
4836
4837 * fringe.c (Fdefine_fringe_bitmap):
4838 Don't update size until alloc works.
4839
4840 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4841 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4842
4843 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4844 Check for size-calculation overflow.
4845 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4846 do, as we prefer signed integers.
4847 (id_to_widget.max_size, id_to_widget.used)
4848 (xg_store_widget_in_map, xg_remove_widget_from_map)
4849 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4850 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4851 Use and return ptrdiff_t, not int.
4852 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4853 * gtkutil.h: Change prototypes to match the above.
4854
4855 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4856 are duplicate now that they've been promoted to lisp.h.
4857 (x_allocate_bitmap_record, x_alloc_image_color)
4858 (make_image_cache, cache_image, xpm_load):
4859 Don't update size until alloc is done.
4860 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4861 (x_detect_edges):
3256efce 4862 Check for size calculation overflow.
726e0ab1
PE
4863 (ct_colors_allocated_max): New constant.
4864 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4865 overflow.
3256efce 4866
726e0ab1
PE
4867 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4868 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4869 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4870 Use ptrdiff_t, not int, to count maps.
4871 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4872 calculations. Don't update size until allocation succeeds.
4873 Redo calculations to avoid overflow.
726e0ab1
PE
4874 * keyboard.h: Change prototypes to match the above.
4875
4876 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4877 to count maps.
4878 (current_minor_maps): Check for size calculation overflow.
4879 * keymap.h: Change prototypes to match the above.
4880
4881 * lread.c (read1, init_obarray): Don't update size until alloc done.
4882
4883 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4884 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4885
726e0ab1
PE
4886 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4887 Now ptrdiff_t, not int.
4888 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4889 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4890
4891 * process.c (Fnetwork_interface_list): Check for overflow
4892 in size calculation.
4893
4894 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4895
4896 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4897 overflow. Don't bother calling xmalloc when xrealloc will do.
4898
4899 * search.c (Freplace_match): Check for size calculation overflow.
4900 (Fset_match_data): Don't assume list lengths fit in 'int'.
4901
4902 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4903 for command line length. Do not attempt to address one before the
4904 beginning of an array, as that's not portable.
4905
4906 * term.c (max_frame_lines): Remove; unused.
4907 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4908 not int.
4909 (encode_terminal_code, calculate_costs): Check for size
4910 calculation overflow.
4911 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4912 table lengths and related sizes. Don't update size until alloc
4913 done. Redo calculations to avoid overflow.
4914 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4915
4916 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4917 subtracting pointers.
4918 (gobble_line): Check for overflow more carefully. Don't update size
4919 until alloc done.
4920
4921 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4922 Don't update size until alloc done.
4923 Redo size calculations to avoid overflow.
4924 Check for size calculation overflow.
0065d054 4925 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4926
4927 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4928 Use ptrdiff_t, not int, for sizes.
4929 (store_mode_line_noprop_char): Don't update size until alloc done.
4930
0065d054
PE
4931 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4932 Use ptrdiff_t, not int, for sizes.
4933 (Finternal_make_lisp_face, cache_face):
4934 Check for size calculation overflow.
4935 (cache_face): Treat size calculation overflows as if they were
4936 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4937
4938 * xfns.c (x_encode_text, x_set_name_internal)
4939 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4940 sizes, since they can exceed INT_MAX in size. Check for size
4941 calculation overflow.
4942
0065d054
PE
4943 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4944 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4945 Don't update size until alloc done.
4946
0065d054 4947 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4948 as sprintf is limited to int lengths.
1d526e2f 4949
252c5ee1
PE
4950 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4951 (X_LONG_MIN): New macros.
864d7ce7
PE
4952 Use them to make the following changes clearer.
4953 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4954 This change doesn't affect the value now, but it may help remind
4955 future maintainers not to raise the value too much later.
4956 (SELECTION_QUANTUM): Remove, replacing with ...
4957 (selection_quantum): ... new function, which avoids overflow.
4958 All uses changed.
4959 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4960 assumption that selection length fits in 'int'.
4961 (x_reply_selection_request, x_handle_selection_request)
4962 (x_get_window_property, receive_incremental_selection)
4963 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4964 (lisp_data_to_selection_data, clean_local_selection_data):
4965 Use ptrdiff_t, not int, to record length of selection.
4966 (x_reply_selection_request, x_get_window_property)
4967 (receive_incremental_selection, x_property_data_to_lisp):
4968 Redo calculations to avoid overflow.
4969 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4970 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4971 something.
4972 (x_get_window_property, receive_incremental_selection)
4973 (lisp_data_to_selection_data, x_property_data_to_lisp):
4974 Check for size-calculation overflow.
4975 (x_get_window_property, receive_incremental_selection)
4976 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4977 Don't store size until memory allocation succeeds.
4978 (x_get_window_property): Plug memory leak on memory exhaustion.
4979 Don't double-block input; malloc is safe here. Don't assume 2**34
4980 - 4 fits in unsigned long. Add an xassert to check
4981 XGetWindowProperty overflow. Be more careful about overflow
4982 calculations, and distinguish size from memory overflow better.
4983 (receive_incremental_selection): When tracing, don't assume
4984 unsigned int is less than INT_MAX.
4985 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4986 harmful) conversions of unsigned short to int.
4987 (lisp_data_to_selection_data): Don't assume that integers
4988 in the range -65535 through -1 fit in an X unsigned short.
4989 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4990 result parameters unless successful. Rely on cons_to_unsigned
4991 to report problems with elements; the old code wasn't right anyway.
4992 (x_check_property_data): Check for int overflow; we cannot use
4993 a wider type due to X limits.
4994 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4995
726e0ab1 4996 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4997
0065d054
PE
4998 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4999 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5000 (x_color_cells): Don't store size until memory allocation succeeds.
5001 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5002 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5003 (x_term_init): Don't assume length fits in int (sprintf is limited
5004 to int size).
bc18e09d 5005
ebfa62c0
PE
5006 Use ptrdiff_t for composition IDs.
5007 * character.c (lisp_string_width):
5008 * composite.c (composition_table_size, n_compositions)
5009 (get_composition_id, composition_gstring_from_id):
5010 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5011 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5012 * window.c (Frecenter):
5013 Use ptrdiff_t, not int, for composition IDs.
5014 * composite.c (get_composition_id): Check for integer overflow.
5015 * composite.h: Adjust prototypes to match the above changes.
5016
d3411f89
PE
5017 Use ptrdiff_t for hash table indexes.
5018 * category.c (hash_get_category_set):
5019 * ccl.c (ccl_driver):
5020 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5021 * coding.c (coding_system_charset_list, detect_coding_system):
5022 * coding.h (struct coding_system.id):
5023 * composite.c (get_composition_id, gstring_lookup_cache):
5024 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5025 * image.c (xpm_get_color_table_h):
5026 * lisp.h (hash_lookup, hash_put):
5027 * minibuf.c (Ftest_completion):
5028 Use ptrdiff_t for hash table indexes, not int (which is too
5029 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5030 32-bit --with-wide-int hosts).
5031
e097a6fa
PE
5032 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5033 Add a FIXME comment about memory leaks.
5034 (syms_of_charset): Don't assume xmalloc returns.
5035
5637687f
PE
5036 Don't assume that stated character widths fit in int.
5037 * character.c (Fchar_width, c_string_width, lisp_string_width):
5038 * character.h (CHAR_WIDTH):
5039 * indent.c (MULTIBYTE_BYTES_WIDTH):
5040 Use sanitize_char_width to avoid undefined and/or bad behavior
5041 with outlandish widths.
a66cfb1c 5042 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5043 now that we have two such functions. All uses changed.
5044 (sanitize_char_width): New inline function.
5045
a2271ba2
PE
5046 Don't assume that tab-width fits in int.
5047 * character.h (sanitize_width): New inline function.
5048 (SANE_TAB_WIDTH): New macro.
5049 (ASCII_CHAR_WIDTH): Use it.
5050 * indent.c (sane_tab_width): Remove. All uses replaced by
5051 SANE_TAB_WIDTH (current_buffer).
5052 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5053
18c52557
PE
5054 * fileio.c: Integer overflow issues with file modes.
5055 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5056
caeeedc1
PE
5057 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5058 Remove unreachable code.
5059 (read_hex, load_charset_map_from_file): Check for integer overflow.
5060
6df6ae42 5061 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5062 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5063 (x_send_scroll_bar_event): Likewise. Check that the size does not
5064 exceed limits imposed by XClientMessageEvent, as well as the usual
5065 ptrdiff_t and size_t limits.
5066
b13995db
PE
5067 * keyboard.c: Overflow, signedness and related fixes.
5068 (make_lispy_movement): Use same integer type in forward decl
5069 that is used in the definition.
5070 (read_key_sequence, keyremap_step):
5071 Change bufsize argument back to int, undoing my 2011-03-30 change.
5072 We prefer signed types, and int is wide enough here.
5073 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5074 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5075 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5076 length, not size_t. Use ptrdiff_t for index, not int.
5077 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5078 possibility of integer overflow.
5079
13464394
PE
5080 Overflow, signedness and related fixes for images.
5081
5082 * dispextern.h (struct it.stack[0].u.image.image_id)
5083 (struct_it.image_id, struct image.id, struct image_cache.size)
5084 (struct image_cache.used, struct image_cache.ref_count):
5085 * gtkutil.c (update_frame_tool_bar):
5086 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5087 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5088 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5089 * nsmenu.m (update_frame_tool_bar):
5090 * xdisp.c (calc_pixel_width_or_height):
5091 * xfns.c (image_cache_refcount):
5092 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5093 on typical 64-bit hosts.
5094
5095 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5096 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5097 Omit unnecessary casts to int.
5098 (parse_image_spec): Check that integers fall into 'int' range
5099 when the callers expect that.
5100 (image_ascent): Redo ascent calculation to avoid int overflow.
5101 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5102 (lookup_image): Remove unnecessary tests.
5103 (xbm_image_p): Locals are now of int, not EMACS_INT,
5104 since parse_image_check makes sure they fit into int.
5105 (png_load, gif_load, svg_load_image):
5106 Prefer int to unsigned where either will do.
5107 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5108 old tiff_error_handler and tiff_warning_handler.
5109 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5110 stack buffer overflows. It uses only the features of vsnprintf
5111 that are common to both POSIX and native Microsoft.
5112 (tiff_error_handler, tiff_warning_handler): Use it.
5113 (tiff_load, gif_load, imagemagick_load_image):
5114 Don't assume :index value fits in 'int'.
5115 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5116 (imagemagick_load_image): Check that crop parameters fit into
5117 the integer types that MagickCropImage accepts. Don't assume
5118 Vimagemagick_render_type has a nonnegative value. Don't assume
5119 size_t fits in 'long'.
5120 (gs_load): Use printmax_t to print the widest integers possible.
5121 Check for integer overflow when computing image height and width.
5122
c11821d4
EZ
51232011-08-26 Eli Zaretskii <eliz@gnu.org>
5124
5125 * xdisp.c (redisplay_window): Don't force window start if point
5126 will be invisible in the resulting window. (Bug#9324)
5127
0c95fcf7
EZ
51282011-08-25 Eli Zaretskii <eliz@gnu.org>
5129
5130 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5131 the display spec is of the form `(space ...)'.
5132 (handle_display_spec): Return the value returned by
5133 handle_single_display_spec, not just 1 or zero.
5134 (handle_single_display_spec): If the display spec is of the form
5135 `(space ...)', and specifies display in the text area, return 2
5136 rather than 1.
fee65a97 5137 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5138 accurately, and prefer exact match for point under bidi.
5139 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5140
5141 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5142 into disp_prop; all users changed.
5143
5144 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5145 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5146 for the text covered by the display property.
5147
e4ed06f1
CY
51482011-08-25 Chong Yidong <cyd@stupidchicken.com>
5149
5150 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5151 Change return value to nil.
5152 (Frecord_buffer): Delete unused function.
5153
f67cdd7f
EZ
51542011-08-24 Eli Zaretskii <eliz@gnu.org>
5155
5980d4c6
EZ
5156 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5157 buffers, return left-to-right.
8610fe8b
EZ
5158 (set_cursor_from_row): Consider candidate row a win if its glyph
5159 represents a newline and point is on that newline. Fixes cursor
5160 positioning on the newline at EOL of R2L text within L2R
5161 paragraph, and vice versa.
5162 (try_cursor_movement): Check continued rows, in addition to
5163 continuation rows. Fixes unwarranted scroll when point enters a
5164 continued line of R2L text within an L2R paragraph, or vice versa.
5165 (cursor_row_p): Consider the case of point being equal to
5166 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5167 from the end of a short line to the beginning of a continued line
5168 of R2L text within L2R paragraph.
5169 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5170 composed characters.
5980d4c6 5171
f67cdd7f
EZ
5172 * bidi.c (bidi_check_type): Use xassert.
5173 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5174 members.
5175
bca633fb
EZ
51762011-08-23 Eli Zaretskii <eliz@gnu.org>
5177
5178 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5179 a character.
5180
4a5885a7
CY
51812011-08-23 Chong Yidong <cyd@stupidchicken.com>
5182
5183 * nsfont.m (ns_otf_to_script): Fix typo.
5184
0902a04e
KH
51852011-08-22 Kenichi Handa <handa@m17n.org>
5186
5187 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5188 extra slot even if the purpose is char-code-property-table.
5189
1a2e6670
EZ
51902011-08-23 Eli Zaretskii <eliz@gnu.org>
5191
8ddde651
EZ
5192 * xdisp.c (redisplay_window): When computing centering_position,
5193 account for the height of the header line. (Bug#8874)
5194
425cc014
EZ
5195 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5196 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5197 candidate is selected by the mouse, and that candidate has a
5198 composed character under the mouse.
5199
1a2e6670
EZ
5200 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5201 coordinates reported by pos-visible-in-window-p for a composed
5202 character in column zero.
5203
8b76d6f8
SM
52042011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5205
5206 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5207
dac347dd
EZ
52082011-08-22 Eli Zaretskii <eliz@gnu.org>
5209
5210 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5211 consider it a hit if to_charpos is anywhere in the range of the
5212 composed buffer positions.
5213
e013fb34
CY
52142011-08-22 Chong Yidong <cyd@stupidchicken.com>
5215
5216 * image.c (gif_load): Don't assume that each subimage has the same
5217 dimensions as the base image. Handle disposal method that is
5218 "undefined" by the gif spec (Bug#9335).
5219
bd1ba3e8
CY
52202011-08-20 Chong Yidong <cyd@stupidchicken.com>
5221
5222 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5223 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5224
54a1215b
EZ
52252011-08-19 Eli Zaretskii <eliz@gnu.org>
5226
823564e5
EZ
5227 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5228 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5229 from an Org mode buffer to a Speedbar frame.
5230
54a1215b
EZ
5231 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5232 a composition, take its buffer position from IT->cmp_it.charpos.
5233 Fixes cursor positioning at the beginning of a line that begins
5234 with a composed character.
5235
9778ebcc
EZ
52362011-08-18 Eli Zaretskii <eliz@gnu.org>
5237
0be6ee06
EZ
5238 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5239 character bidirectional type, use STRONG_L instead. Fixes crashes
5240 in a buffer produced by `describe-categories'.
5241
9778ebcc
EZ
5242 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5243 members before the level stack, so they would be saved and
5244 restored when copying iterator state. Fixes incorrect reordering
5245 around TABs covered by display properties.
5246
156bffbe
AS
52472011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5248
6b02f655 5249 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5250
72ad093b
CY
52512011-08-17 Chong Yidong <cyd@stupidchicken.com>
5252
5253 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5254 (internal_condition_case_2, internal_condition_case_n):
5255 Remove unnecessary aborts (Bug#9081).
72ad093b 5256
35774242
EZ
52572011-08-17 Eli Zaretskii <eliz@gnu.org>
5258
5259 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5260 has no `load' handler, try opening the file locally. (Bug#9311)
5261
db76dd85
KB
52622011-08-16 Ken Brown <kbrown@cornell.edu>
5263
5264 * gmalloc.c: Expand comment.
5265
b215eee5
EZ
52662011-08-16 Eli Zaretskii <eliz@gnu.org>
5267
5268 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5269 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5270
a4579d33
KB
52712011-08-16 Ken Brown <kbrown@cornell.edu>
5272
5273 Fix memory allocation problems in Cygwin build (Bug#9273).
5274
5275 * unexcw.c ( __malloc_initialized): Declare external variable.
5276 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5277
8b76d6f8
SM
5278 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5279 New variables.
a4579d33
KB
5280 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5281 dumped emacs.
5282 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5283 in the static heap.
5284 [CYGWIN] (special_realloc): New function.
5285 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5286 requests to realloc storage in the static heap.
5287
3ebec551
PE
52882011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 * bidi.c (bidi_initialize): Remove unused local.
5291
9fd8be00
EZ
52922011-08-15 Eli Zaretskii <eliz@gnu.org>
5293
6b02f655
SM
5294 * bidimirror.h:
5295 * biditype.h: Remove file.
5296 * makefile.w32-in ($(BLD)/bidi.$(O)):
5297 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5298
5299 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5300
5301 * chartab.c: Improve commentary for the uniprop_table API.
5302
32413314
EZ
5303 * bidi.c (bidi_paragraph_init): Support zero value of
5304 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5305 (bidi_initialize): Use uniprop_table instead of including
5306 biditype.h and bidimirror.h.
32413314 5307
9fd8be00
EZ
5308 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5309 coordinates of the iterator when restoring from ppos_it.
5310 (Bug#9296)
5311
5cf2b69b
KH
53122011-08-14 Kenichi Handa <handa@m17n.org>
5313
5314 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5315 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5316
daf17d00
EZ
53172011-08-14 Eli Zaretskii <eliz@gnu.org>
5318
5319 * xdisp.c (move_it_in_display_line_to): Don't invoke
5320 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5321 ppos_it. Fixes vertical cursor motion when line beginning is
5322 covered by an image. (Bug#9296)
5323
08e3161a
JD
53242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5325
5326 * nsterm.h (ns_run_ascript): Declare.
5327 (NSAPP_DATA2_RUNASSCRIPT): Define.
5328
5329 * nsfns.m (as_script, as_result, as_status): New static variables.
5330 (ns_run_ascript): New function.
5e617bc2 5331 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5332 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5333 the event loop. Get status from as_status (Bug#7276).
5334
5335 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5336 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5337 the event loop (Bug#7276).
5338
a3720aa2
AS
53392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5340
5341 * gnutls.c (QCgnutls_bootprop_priority)
5342 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5343 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5344 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5345 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5346 (QCgnutls_bootprop_verify_hostname_error)
5347 (QCgnutls_bootprop_callbacks_verify): Rename from
5348 Qgnutls_bootprop_..., all uses changed.
5349
5350 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5351 uses changed.
5352
0a0d27fb
PE
53532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5354
19d5c50c
PE
5355 * xfaces.c (Qframe_set_background_mode): Now static.
5356 * dispextern.h (Qframe_set_background_mode): Remove decl.
5357
0a0d27fb
PE
5358 * process.c (Fnetwork_interface_info): Declare local only if needed.
5359
377538cb
JD
53602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5361
5362 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5363 (Fnetwork_interface_list): Allocate in increments of bytes instead
5364 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5365 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5366 sockaddr.
5367 (struct ifflag_def): notrailers is smart on OSX.
5368 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5369 Get hardware address with getifaddrs if available.
5370
08fff70c
EZ
53712011-08-12 Eli Zaretskii <eliz@gnu.org>
5372
5373 * xdisp.c (iterate_out_of_display_property): xassert that
5374 IT->position is set to within IT->object's boundaries. Break from
5375 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5376 when IT->position is set up wrongly due to some bug.
5377 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5378 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5379 entry. Force push_it to save on the stack the current
5380 buffer/string position, to be restored by pop_it. Fix flags in
5381 the iterator structure wrt the object coming from a display
5382 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5383 properties. (Bug#9284)
5384
7be1c708 53852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5386
7be1c708
CY
5387 * fontset.c (fontset_get_font_group): Add proper type checks.
5388 (Bug#9172)
aac0c6e3 5389
7be1c708 53902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5391
7be1c708
CY
5392 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5393 and LC_VERSION_MIN_MACOSX.
5394 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5395 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5396
97bb72a6
EZ
53972011-08-08 Eli Zaretskii <eliz@gnu.org>
5398
5399 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5400 no-display-properties-and-no-overlays under bidi display.
5401 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5402 properties and overlays.
97bb72a6 5403
d5617611
CY
54042011-08-08 Chong Yidong <cyd@stupidchicken.com>
5405
37e11a63
CY
5406 * editfns.c (Fset_time_zone_rule): Document relationship with the
5407 setenv function.
5408
d5617611
CY
5409 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5410 the font entity extracted from the cache (Bug#8109).
5411
58872834
CY
54122011-08-07 Chong Yidong <cyd@stupidchicken.com>
5413
5414 * composite.c (autocmp_chars): Don't reset point. That is done by
5415 restore_point_unwind (Bug#5984).
5416
75bfc667
JL
54172011-08-07 Juri Linkov <juri@jurta.org>
5418
5419 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5420 to show the arg `TIME' instead of `TIMEVAL'.
5421
d1410150
EZ
54222011-08-06 Eli Zaretskii <eliz@gnu.org>
5423
5424 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5425 display property strides EOL and includes a newline, as in
5426 longlines-mode. (Bug#9254)
75b771e4
EZ
5427 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5428 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5429
5430 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5431 is non-zero, even if the data buffer is NULL. Fixes a crash in
5432 vertical-motion with longlines-mode. (Bug#9254)
5433
35928349
EZ
54342011-08-05 Eli Zaretskii <eliz@gnu.org>
5435
ec7cc85b
EZ
5436 * bidi.c <bidi_cache_total_alloc>: Now static.
5437 (bidi_initialize): Initialize bidi_cache_total_alloc.
5438
8b76d6f8 5439 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5440 cache. (Bug#9221)
5441
5442 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5443 amount allocated this far in `bidi_cache_total_alloc'.
5444 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5445 non-zero, only free the data buffer without restoring the cache
5446 contents. All callers changed.
5447
5448 * dispextern.h (bidi_unshelve_cache): Update prototype.
5449
5450 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5451 (move_it_in_display_line, move_it_to)
5452 (move_it_vertically_backward, move_it_by_lines): Replace the call
5453 to xfree to an equivalent call to bidi_unshelve_cache.
5454 (move_it_in_display_line_to): Fix logic of returning
412b6358 5455 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5456
e2e2423b
EZ
54572011-08-05 Eli Zaretskii <eliz@gnu.org>
5458
5459 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5460 came from a string character with a `cursor' property. (Bug#9229)
5461
ae9e757a
JD
54622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5463
5464 * Makefile.in (LIB_PTHREAD): New variable.
5465 (LIBES): Add LIB_PTHREAD (Bug#9216).
5466
5467 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5468 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5469
213bd7f2
AS
54702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5471
6b02f655 5472 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5473
99aaf75f
JD
54742011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5475
5476 * xterm.c (x_find_topmost_parent): New function.
5477 (x_set_frame_alpha): Find topmost parent window with
5478 x_find_topmost_parent and set the property there also (bug#9181).
5479 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5480
c74e9d86
PE
54812011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5482
5483 * callproc.c (Fcall_process): Avoid vfork clobbering
5484 the local vars buffer, coding_systems, current_dir.
5485
640c8776
SM
54862011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5487
5488 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5489
f26d0e4c
PE
54902011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5491
8a10d76c
PE
5492 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5493 so that it is not optimized away.
5494
f26d0e4c
PE
5495 * xdisp.c (compute_display_string_pos): Remove unused local.
5496
55439c61
EZ
54972011-08-02 Eli Zaretskii <eliz@gnu.org>
5498
5499 Fix slow cursor motion and scrolling in large buffers with
5500 selective display, like Org Mode buffers. (Bug#9218)
5501
5502 * dispextern.h (struct bidi_it): New member disp_prop_p.
5503
5504 * xdisp.c: Remove one-slot cache of display string positions.
5505 (compute_display_string_pos): Accept an additional argument
5e617bc2 5506 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5507 for a display string or property. If found, set DISP_PROP_P
5508 non-zero.
5509
5510 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5511 DISP_PROP_P, and pass it to compute_display_string_pos.
5512 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5513 non-zero. All callers of bidi_fetch_char changed.
5514
fb33fa43
SM
55152011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5516
5517 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5518
b099e063
DM
55192010-12-03 Don March <don@ohspite.net>
5520
5521 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5522 last character M-[char] is translated to ESC [char] (bug#7541).
5523
5cc7f7af
KH
55242011-08-02 Kenichi Handa <handa@m17n.org>
5525
d0fffa3f 5526 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5527
5528 * chartab.c (uniprop_table): Make it non-static.
5529
525d5e6e
EZ
55302011-08-01 Eli Zaretskii <eliz@gnu.org>
5531
5532 * xdisp.c (forward_to_next_line_start): Accept additional argument
5533 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5534 on the newline.
5535 (reseat_at_next_visible_line_start): Use the bidi iterator state
5536 returned by forward_to_next_line_start to restore the state of
5537 it->bidi_it after backing up to previous newline. (Bug#9212)
5538
31011111
AS
55392011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5540
5541 * regex.c (re_comp): Protoize.
5542 (re_exec): Fix return type.
5543 (regexec): Fix type of `ret'. (Bug#9203)
5544
476371c4
PE
55452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5546
e5d76069
PE
5547 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5548 This is needed if max-image-size is a floating-point number.
5549
9a79b20c
AS
55502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5551
5552 * print.c (print_object): Print empty symbol as ##.
5553
5554 * lread.c (read1): Read ## as empty symbol.
5555
d8c2fa78
AA
55562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5557
5558 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5559 setting frame foreground color (Bug#9175).
5560 (x_set_background_color): Likewise.
5561
ffe57a7a
AA
5562 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5563 contents (Bug#9176).
5564 (EmacsTooltip -init): Remove bezels and add shadows to
5565 tooltip windows.
5566
bf3492a5
AA
5567 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5568 or scroll bar (Bug#8470).
5569
d55e9c53
AA
5570 * nsfont.m (nsfont_open): Remove assignment to voffset and
5571 unnecessary vars hshink, expand, hd, full_height, min_height.
5572 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5573
5574 * nsterm.h (nsfont_info): Remove voffset field.
5575
d8c2fa78 55762011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5577
5578 Implement strike-through and overline on NextStep (Bug#8863).
5579
5580 * nsfont.m (nsfont_open): Use underline position provided by font,
5581 instead of hard-coded value of 2.
5582 (nsfont_draw): Call ns_draw_text_decoration instead.
5583
5584 * nsterm.h: Add declaration for ns_draw_text_decoration.
5585
5586 * nsterm.m (ns_draw_text_decoration): New function for drawing
5587 underline, overline, and strike-through.
5588 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5589 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5590 accommodate underlining, etc.
4843aac3 5591
4cc60b9b
EZ
55922011-07-28 Eli Zaretskii <eliz@gnu.org>
5593
bc7ece87
EZ
5594 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5595 default.
4cc60b9b 5596
476371c4
PE
55972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5598
66606eea
PE
5599 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5600 Without this fix, if a signal arrives just after memory fills up,
5601 'malloc' might be invoked reentrantly.
5602
476371c4
PE
5603 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5604 In other words, assume that every image size is allowed, on non-X
5605 hosts. This assumption is probably wrong, but it lets Emacs compile.
5606
f3fcc40d
AS
56072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5608
5609 * regex.c (re_iswctype): Convert return values to boolean.
5610
350c992f
EZ
56112011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5612
5613 * xdisp.c (compute_display_string_pos): Don't use cached display
5614 string position if the buffer had its restriction changed.
5615 (Bug#9184)
5616
5266b4bb
PE
56172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5618
5619 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5620
2573a837 56212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5622
41f55ccd 5623 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5624
39e378da
PE
5625 * bidi.c: Integer size and overflow fixes.
5626 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5627 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5628 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5629 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5630 (bidi_find_other_level_edge):
5631 Use ptrdiff_t instead of EMACS_INT where either will do.
5632 This works better on 32-bit hosts configured --with-wide-int.
5633 (bidi_cache_ensure_space): Check for size-calculation overflow.
5634 Use % rather than repeated addition, for better worst-case speed.
5635 Don't set bidi_cache_size until after xrealloc returns, because it
5636 might not return.
5637 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5638 (bidi_cache_ensure_space): Also check that the bidi cache size
5639 does not exceed that of the largest Lisp string or buffer. See Eli
5640 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5641
5e927815
PE
5642 * alloc.c (__malloc_size_t): Remove.
5643 All uses replaced by size_t. See Andreas Schwab's note
5644 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5645
ca4aa935
PE
5646 * image.c: Improve checking for integer overflow.
5647 (check_image_size): Assume that f is nonnull, since
5648 it is always nonnull in practice. This is one less thing to
5649 worry about when checking for integer overflow later.
5650 (x_check_image_size): New function, which checks for integer
5651 overflow issues inside X.
5652 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5653 This removes the need for a memory_full check.
5654 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5655 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5656 (xbm_read_bitmap_data): Change locals back to 'int', since
5657 their values must fit in 'int'.
5658 (xpm_load_image, png_load, tiff_load):
5659 Invoke x_create_x_image_and_pixmap earlier,
5660 to avoid much needless work if the image is too large.
5661 (tiff_load): Treat overly large images as if
5662 x_create_x_image_and_pixmap failed, not as malloc failures.
5663 (gs_load): Use x_check_image_size.
5664
5f8f9cc2
PE
5665 * gtkutil.c: Omit integer casts.
5666 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5667 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5668
5adf60bc
PE
5669 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5670
c8907a93
PE
5671 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5672 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5673 would wrongly return t on a 64-bit host.
5674
e3c25c68
PE
5675 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5676 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5677 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5678 and therefore cause GCC to emit a bogus diagnostic in some cases.
5679
3f791afe
PE
5680 * image.c: Integer signedness and overflow and related fixes.
5681 This is not an exhaustive set of fixes, but it's time to
5682 record what I've got.
5683 (lookup_pixel_color, check_image_size): Remove redundant decls.
5684 (check_image_size): Don't assume that arbitrary EMACS_INT values
5685 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5686 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5687 (tiff_load, imagemagick_load_image):
5688 Check for overflow in size calculations.
5689 (x_create_x_image_and_pixmap): Remove unnecessary test for
5690 xmalloc returning NULL; that can't happen.
5691 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5692 (xpm_color_bucket): Use better integer hashing function.
5693 (xpm_cache_color): Don't possibly over-allocate memory.
5694 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5695 (gif_memory_source):
5696 Use ptrdiff_t, not int or size_t, to record sizes.
5697 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5698 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5699 either works, as we prefer signed integers.
5700 (tiff_read_from_memory, tiff_write_from_memory):
5701 Return tsize_t, not size_t, since that's what the TIFF API wants.
5702 (tiff_read_from_memory): Don't fail simply because the read would
5703 go past EOF; instead, return a short read.
5704 (tiff_load): Omit no-longer-needed casts.
5705 (Fimagemagick_types): Don't assume size fits into 'int'.
5706
3cc5a532
PE
5707 Improve hashing quality when configured --with-wide-int.
5708 * fns.c (hash_string): New function, taken from sxhash_string.
5709 Do not discard information about ASCII character case; this
5710 discarding is no longer needed.
5711 (sxhash-string): Use it. Change sig to match it. Caller changed.
5712 * lisp.h: Declare it.
5713 * lread.c (hash_string): Remove, since we now use fns.c's version.
5714 The fns.c version returns a wider integer if --with-wide-int is
5715 specified, so this should help the quality of the hashing a bit.
5716
b312a492
PE
5717 * emacs.c: Integer overflow minor fix.
5718 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5719 Define only if GNU_LINUX.
5720 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5721
dfd153ae
PE
5722 * dispnew.c: Integer signedness and overflow fixes.
5723 Remove unnecessary forward decls, that were a maintenance hassle.
5724 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5725 All uses changed.
5726 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5727 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5728 (prepare_desired_row, line_draw_cost):
5729 Use int, not unsigned, where either works.
5730 (save_current_matrix, restore_current_matrix):
5731 Use ptrdiff_t, not size_t, where either works.
5732 (init_display): Check for overflow more accurately, and without
5733 relying on undefined behavior.
5734
a81d11a3
PE
5735 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5736 Remove, replacing with the new symbols in lisp.h. All uses changed.
5737 * fileio.c (make_temp_name):
5738 * filelock.c (lock_file_1, lock_file):
5739 * xdisp.c (message_dolog):
5740 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5741 Use pMd etc. instead.
5742 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5743 replacing the pWIDE etc. symbols removed from editfns.c.
5744
3300e6fd
PE
5745 * keyboard.h (num_input_events): Now uintmax_t.
5746 This is (very slightly) less likely to mess up due to wraparound.
5747 All uses changed.
5748
fd05c7e9
PE
5749 * buffer.c: Integer signedness fixes.
5750 (alloc_buffer_text, enlarge_buffer_text):
5751 Use ptrdiff_t rather than size_t when either will do, as we prefer
5752 signed integers.
5753
903fe15d
PE
5754 * alloc.c: Integer signedness and overflow fixes.
5755 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5756 (__malloc_size_t): Default to size_t, not to int.
5757 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5758 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5759 Prefer ptrdiff_t to size_t when either would do, as we prefer
5760 signed integers.
5761 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5762 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5763 Now const. Initialize with values that are in range even if char
5764 is signed.
5765 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5766 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5767 These functions do the right thing with sizes > 2**32.
5768 (check_depth): Now ptrdiff_t, not int.
5769 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5770 Adjust to new way of storing sizes. Check for size overflow bugs
5771 in rest of code.
5772 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5773 slightly wrong anyway, as it missed one instance of
5774 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5775 (refill_memory_reserve): Omit needless cast to size_t.
5776 (mark_object_loop_halt): Mark as externally visible.
5777
ac82cc6a
PE
5778 * xselect.c: Integer signedness and overflow fixes.
5779 (Fx_register_dnd_atom, x_handle_dnd_message):
5780 Use ptrdiff_t, not size_t, since we prefer signed.
5781 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5782 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5783 x_dnd_atoms_size and x_dnd_atoms_length.
5784
c2d1e36d
PE
5785 * doprnt.c: Prefer signed to unsigned when either works.
5786 * eval.c (verror):
5787 * doprnt.c (doprnt):
5788 * lisp.h (doprnt):
5789 * xdisp.c (vmessage):
5790 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5791 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5792 prefer signed arithmetic to avoid comparison confusion.
5793 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5794 but is a bit tricky.
5795
0e926e56
PE
5796 Assume freestanding C89 headers, string.h, stdlib.h.
5797 * data.c, doprnt.c, floatfns.c, print.c:
5798 Include float.h unconditionally.
5799 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5800 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5801 * regex.c: Likewise for stddef.h, string.h.
5802 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5803 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5804 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5805 (STDC_HEADERS): Remove obsolete defines.
5806 * sysdep.c: Include limits.h unconditionally.
5807
9cfdb3ec
PE
5808 Assume support for memcmp, memcpy, memmove, memset.
5809 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5810 * regex.c (memcmp, memcpy):
5811 Remove; we assume C89 now.
5812
5813 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5814 (__malloc_safe_bcopy): Remove; no longer needed.
5815
cf950e6b 5816 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5817 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5818 well either way, and we prefer signed to unsigned.
5819
dbf38e02
LMI
58202011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5821
5822 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5823 closes the connection while we're reading (bug#9182).
5824
d6f0886c 58252011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5826
d6f0886c
JD
5827 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5828 are specified (Bug#9168).
24e0f6b1 5829
2eb1f9e6
PE
58302011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5831
5832 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5833 Found by GCC static checking and --with-wide-int on a 32-bit host.
5834
22381272 58352011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5836
5837 * xdisp.c (compute_display_string_pos): Fix logic of caching
5838 previous display string position. Initialize cached_prev_pos to
5839 -1. Fixes slow-down at the beginning of a buffer.
5840
f25e39b4
EZ
58412011-07-24 Eli Zaretskii <eliz@gnu.org>
5842
5843 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5844 for attrs[LFACE_FONTSET_INDEX].
5845
04c4b52e
PE
58462011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5847
5848 * xml.c (parse_region): Remove unused local
5849 that was recently introduced.
5850
c1734fbd
EZ
58512011-07-23 Eli Zaretskii <eliz@gnu.org>
5852
be18c5a5
EZ
5853 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5854 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5855
c1734fbd
EZ
5856 * xdisp.c (move_it_in_display_line_to): Record the best matching
5857 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5858 exit if none of the characters scanned was an exact match.
5859 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5860 when exact match is impossible due to invisible text, and the
5861 lines are truncated.
5862
a258d627
JD
58632011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5864
5865 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5866 for OSX >= 10.7.
5867
b6d5a689
EZ
58682011-07-22 Eli Zaretskii <eliz@gnu.org>
5869
0f74f785
EZ
5870 Fix a significant slow-down of cursor motion with C-n, C-p,
5871 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5872 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5873 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5874 (next_element_from_buffer): Call compute_stop_pos_backwards to
5875 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5876 base_level_stop.
5877 (reseat): Don't look for prev_stop, as that could mean a very long
5878 run.
5879 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5880 <cached_disp_overlay_modiff>: Cache for last found display string
5881 position.
551918c1 5882 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5883 about the same buffer in the same area of character positions, and
5884 the buffer wasn't changed since the time the display string
5885 position was cached.
551918c1 5886
b2d0c91a
EZ
58872011-07-22 Eli Zaretskii <eliz@gnu.org>
5888
5889 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5890 is an integer, which is important for empty lines. (Bug#9149)
5891
043604ee
CY
58922011-07-22 Chong Yidong <cyd@stupidchicken.com>
5893
5894 * frame.c (Fmodify_frame_parameters): In tty case, update the
5895 default face if necessary (Bug#4238).
5896
da4adb04
CY
58972011-07-21 Chong Yidong <cyd@stupidchicken.com>
5898
5899 * editfns.c (Fstring_to_char): No need to explain what a character
5900 is in the docstring (Bug#6576).
5901
9abd0532
LMI
59022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5903
5904 * xml.c (parse_region): Make sure we always return a tree.
5905
36881d16
HK
59062011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5907
5908 * xml.c (parse_region): If a document contains only comments,
5909 return that, too.
5910
1e98674d
LMI
59112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5912
5913 * xml.c (make_dom): Return comments, too.
5914
590bd467
PE
59152011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 Port to OpenBSD.
5918 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5919 and the surrounding thread.
5920 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5921 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5922 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5923 timer goes off.
5924 * s/openbsd.h (BROKEN_SIGIO): Define.
5925 * unexelf.c (unexec) [__OpenBSD__]:
5926 Don't update the .mdebug section of the Alpha COFF symbol table.
5927
f41628b2
LMI
59282011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5929
5930 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5931 (bug#8460).
5932
b59b67c5
PE
59332011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5934
15e3a074
PE
5935 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5936 This fixes some race conditions on the permissions of any newly
5937 created file.
5938
41bed37d
PE
5939 * alloc.c (valid_pointer_p): Use pipe, not open.
5940 This fixes some permissions issues when debugging.
5941
b59b67c5
PE
5942 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5943 If fchown fails to set both uid and gid, try to set just gid,
5944 as that is sometimes allowed. Adjust the file's mode to eliminate
5945 setuid or setgid bits that are inappropriate if fchown fails.
5946
925a6be7
SM
59472011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5948
5949 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5950 to compare Lisp_Objects.
5951 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5952 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5953 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5954
52968808
AS
59552011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5956
0a6a104b
AS
5957 * lread.c (read_integer): Unread even EOF character.
5958 (read1): Likewise. Properly record start position of symbol.
5959
52968808
AS
5960 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5961 symbol character follows.
5962
9e381cdd
PE
59632011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5964
5965 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5966 This works around a problem with the previous change to Fcopy_file.
5967 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5968 and without this change, GCC might complain about discarding
5969 fchown's return value.
5970
b5641435
JB
59712011-07-16 Juanma Barranquero <lekktu@gmail.com>
5972
5973 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5974
a8031457
PE
59752011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5978
dd889327
LMI
59792011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5980
750c33f7
LMI
5981 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5982 it's used from the C level.
5983
dd889327
LMI
5984 * process.c: Use the same condition for POLL_FOR_INPUT in both
5985 keyboard.c and process.c (bug#1858).
5986
87e86684
LM
59872011-07-09 Lawrence Mitchell <wence@gmx.li>
5988
5989 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5990 (Fgnutls_boot): Use it.
5991
64348f40
AS
59922011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5993
5994 * doc.c (Fsubstitute_command_keys): Revert last change.
5995
1d698799
LMI
59962011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5997
f863868c
LMI
5998 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5999 quotes the next character, and doesn't affect other longer
6000 sequences (bug#8935).
6001
1d698799
LMI
6002 * lread.c (syms_of_lread): Clarify that is isn't only
6003 `eval-buffer' and `eval-defun' that's affected by
6004 `lexical-binding' (bug#8460).
6005
aa4b6df6
EZ
60062011-07-15 Eli Zaretskii <eliz@gnu.org>
6007
6008 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6009 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6010
5d856da6
PE
60112011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6012
ad6042bb
PE
6013 Fix minor problems found by static checking.
6014 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6015 (elsz): Now a signed constant, not a size_t var. We prefer signed
6016 types to unsigned, to avoid integer comparison confusion. Without
6017 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6018 "cannot optimize loop, the loop counter may overflow", a symptom
6019 of the confusion.
f00bbb22 6020 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6021 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6022
6468f31c
LMI
60232011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6024
49080b10
LMI
6025 * search.c (Fre_search_backward): Mention `case-fold-search' in
6026 all the re_search_* functions (bug#8138).
6027
6468f31c
LMI
6028 * keyboard.c (Fopen_dribble_file): Document when the file is
6029 closed (bug#8056).
6030
c965adc5
EZ
60312011-07-14 Eli Zaretskii <eliz@gnu.org>
6032
df9733bf
EZ
6033 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6034 bidi_cache_idx.
6035
0bb23927
EZ
6036 Support bidi reordering of display and overlay strings.
6037 * xdisp.c (compute_display_string_pos)
6038 (compute_display_string_end): Accept additional argument STRING.
6039 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6040 (reseat_to_string): Initialize bidi_it->string.s and
6041 bidi_it->string.schars.
6042 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6043 NULL (avoids a crash in bidi_paragraph_init).
6044 Initialize itb.string.lstring.
0bb23927
EZ
6045 (init_iterator): Call bidi_init_it only of a valid
6046 buffer position was specified. Initialize paragraph_embedding to
6047 L2R.
6048 (reseat_to_string): Initialize the bidi iterator.
6049 (display_string): If we need to ignore text properties of
6050 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6051 original value of -1 will not work with bidi.)
6052 (compute_display_string_pos): First arg is now struct
6053 `text_pos *'; all callers changed. Support display properties on
6054 Lisp strings.
6055 (compute_display_string_end): Support display properties on Lisp
6056 strings.
6057 (init_iterator, reseat_1, reseat_to_string): Initialize the
6058 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6059 when iterating on a string not from display properties).
640c8776
SM
6060 (compute_display_string_pos, compute_display_string_end):
6061 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6062 arrow keys.
6063 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6064 base_level_stop; instead, set base_level_stop to BEGV.
6065 Fixes crashes in vertical-motion.
0bb23927
EZ
6066 (next_element_from_buffer): Improve commentary for when
6067 the iterator is before prev_stop.
6068 (init_iterator): Initialize bidi_p from the default value of
6069 bidi-display-reordering, not from buffer-local value. Use the
6070 buffer-local value only if initializing for buffer iteration.
6071 (handle_invisible_prop): Support invisible properties on strings
6072 that are being bidi-reordered.
6073 (set_iterator_to_next): Support bidi reordering of C strings and
6074 Lisp strings.
6075 (next_element_from_string): Support bidi reordering of Lisp
6076 strings.
6077 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6078 (display_string): Support display of R2L glyph rows.
6079 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6080 (init_iterator): Don't initialize it->bidi_p for strings
6081 here.
6082 (reseat_to_string): Initialize it->bidi_p for strings here.
6083 (next_element_from_string, next_element_from_c_string)
6084 (next_element_from_buffer): Add xassert's for correspondence
6085 between IT's object being iterated and it->bidi_it.string
6086 structure.
6087 (face_before_or_after_it_pos): Support bidi iteration.
6088 (next_element_from_c_string): Handle the case of the first string
6089 character that is not the first one in the visual order.
6090 (get_visually_first_element): New function, refactored from common
6091 parts of next_element_from_buffer, next_element_from_string, and
6092 next_element_from_c_string.
6093 (tool_bar_lines_needed, redisplay_tool_bar)
6094 (display_menu_bar): Force left-to-right direction. Add a FIXME
6095 comment for making that be controlled by a user option.
6096 (push_it, pop_it): Save and restore the state of the
6097 bidi iterator. Save and restore the bidi_p flag.
6098 (pop_it): Iterate out of display property for string iteration as
6099 well.
6100 (iterate_out_of_display_property): Support iteration over strings.
6101 (handle_single_display_spec): Set up it->bidi_it for iteration
6102 over a display string, and call bidi_init_it.
6103 (handle_single_display_spec, next_overlay_string)
6104 (get_overlay_strings_1, push_display_prop): Set up the bidi
6105 iterator for displaying display or overlay strings.
6106 (forward_to_next_line_start): Don't use the shortcut if
6107 bidi-iterating.
6108 (back_to_previous_visible_line_start): If handle_display_prop
6109 pushed the iterator stack, restore the internal state of the bidi
6110 iterator by calling bidi_pop_it same number of times.
6111 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6112 and we are bidi-iterating, don't decrement the iterator position;
6113 instead, set the first_elt flag in the bidi iterator, to produce
6114 the same effect.
6115 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6116 (push_display_prop): xassert that we are iterating a buffer.
6117 (push_it, pop_it): Save and restore paragraph_embedding member.
6118 (handle_single_display_spec, next_overlay_string)
6119 (get_overlay_strings_1, reseat_1, reseat_to_string)
6120 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6121 correctly. Don't assume unibyte strings are not bidi-reordered.
6122 (compute_display_string_pos)
6123 (compute_display_string_end): Fix handling the case of C string.
6124 (push_it, pop_it): Save and restore from_disp_prop_p.
6125 (handle_single_display_spec, push_display_prop): Set the
6126 from_disp_prop_p flag.
6127 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6128 (pop_it): Call iterate_out_of_display_property only if we are
6129 popping after iteration over a string that came from a display
6130 property. Fix a typo in popping stretch info. Add an assertion
6131 for verifying that the iterator position is in sync with the bidi
6132 iterator.
6133 (handle_single_display_spec, get_overlay_strings_1)
6134 (push_display_prop): Fix initialization of paragraph direction for
6135 string when that of the parent object is not yet determined.
6136 (reseat_1): Call bidi_init_it to resync the bidi
6137 iterator with IT's position. (Bug#7616)
6138 (find_row_edges): If ROW->start.pos gives position
6139 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6140 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6141 Reset the from_disp_prop_p flag.
6142 (SAVE_IT, RESTORE_IT): New macros.
6143 (pos_visible_p, face_before_or_after_it_pos)
6144 (back_to_previous_visible_line_start)
6145 (move_it_in_display_line_to, move_it_in_display_line)
6146 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6147 (try_scrolling, redisplay_window, display_line): Use them when
6148 saving a temporary copy of the iterator and restoring it back.
6149 (back_to_previous_visible_line_start, reseat_1)
6150 (init_iterator): Empty the bidi cache "stack".
6151 (move_it_in_display_line_to): If iterator ended up at
6152 EOL, but we never saw any buffer positions smaller than
6153 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6154 motion in bidi-reordered lines.
6155 (move_it_in_display_line_to): Record prev_method and prev_pos
6156 immediately before the call to set_iterator_to_next. Fixes cursor
6157 motion in bidi-reordered lines with stretch glyphs and strings
6158 displayed in margins. (Bug#8133) (Bug#8867)
6159 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6160 TO_CHARPOS.
640c8776
SM
6161 (pos_visible_p): Support positions in bidi-reordered lines.
6162 Save and restore bidi cache.
0bb23927
EZ
6163
6164 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6165 (bidi_paragraph_info): Delete unused struct.
6166 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6167 (bidi_cache_start): New variable.
6168 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6169 to zero.
6170 (bidi_cache_fetch_state, bidi_cache_search)
6171 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6172 (bidi_cache_find, bidi_peek_at_next_level)
6173 (bidi_level_of_next_char, bidi_find_other_level_edge)
6174 (bidi_move_to_visually_next): Compare cache index with
6175 bidi_cache_start rather than with zero.
6176 (bidi_fetch_char): Accept new argument STRING; all callers
6177 changed. Support iteration over a string. Support strings with
6178 display properties. Support unibyte strings. Fix the type of
6179 `len' according to what STRING_CHAR_AND_LENGTH expects.
6180 (bidi_paragraph_init, bidi_resolve_explicit_1)
6181 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6182 (bidi_level_of_next_char, bidi_move_to_visually_next):
6183 Support iteration over a string.
0bb23927
EZ
6184 (bidi_set_sor_type, bidi_resolve_explicit_1)
6185 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6186 can now be zero (for strings); special values 0 and -1 were
6187 changed to -1 and -2, respectively.
6188 (bidi_char_at_pos): New function.
6189 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6190 Call it instead of FETCH_MULTIBYTE_CHAR.
6191 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6192 initialized to valid values.
6193 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6194 values.
6195 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6196 the test for valid cached positions. Fix the logic for looking up
6197 the sentinel state in the cache. GCPRO the Lisp string we are
6198 iterating.
6199 (bidi_push_it, bidi_pop_it): New functions.
6200 (bidi_initialize): Initialize the bidi cache start stack pointer.
6201 (bidi_cache_ensure_space): New function, refactored from part of
6202 bidi_cache_iterator_state. Don't assume the required size is just
6203 one BIDI_CACHE_CHUNK away.
6204 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6205 (bidi_count_bytes, bidi_char_at_pos): New functions.
6206 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6207 always valid if bidi_cache_idx is valid.
6208 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6209 is valid if it's going to be used.
6210 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6211 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6212 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6213 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6214 (bidi_find_other_level_edge, bidi_cache_start_stack):
6215 All variables related to cache indices are now EMACS_INT.
c965adc5 6216
0bb23927
EZ
6217 * dispextern.h (struct bidi_string_data): New structure.
6218 (struct bidi_it): New member `string'. Make flag members be 1-bit
6219 fields, and put them last in the struct.
640c8776
SM
6220 (compute_display_string_pos, compute_display_string_end):
6221 Update prototypes.
0bb23927
EZ
6222 (bidi_push_it, bidi_pop_it): Add prototypes.
6223 (struct iterator_stack_entry): New members bidi_p,
6224 paragraph_embedding, and from_disp_prop_p.
6225 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6226 (bidi_shelve_cache, bidi_unshelve_cache):
6227 Declare prototypes.
0bb23927
EZ
6228
6229 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6230 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6231 and vector-like objects.
6232
6233 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6234 cache around display iteration.
6235
6236 * window.c (Fwindow_end, window_scroll_pixel_based)
6237 (displayed_window_lines, Frecenter): Save and restore the bidi
6238 cache around display iteration.
6239
3bbd2265
LMI
62402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6241
6242 * editfns.c (Fdelete_region): Clarify the use of the named
6243 parameters (bug#6788).
6244
adc47434
MR
62452011-07-14 Martin Rudalics <rudalics@gmx.at>
6246
6247 * indent.c (Fvertical_motion): Set and restore w->pointm when
6248 saving and restoring the window's buffer (Bug#9006).
6249
837c31f8
LMI
62502011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6251
6252 * editfns.c (Fstring_to_char): Clarify just what is returned
6253 (bug#6576). Text by Eli Zaretskii.
6254
ac389d0c
JB
62552011-07-13 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6258
0be0ce47
EZ
62592011-07-13 Eli Zaretskii <eliz@gnu.org>
6260
6261 * buffer.c (mmap_find): Fix a typo.
6262
cd18e7e3
JB
62632011-07-13 Johan Bockgård <bojohan@gnu.org>
6264
6265 Fix execution of x selection hooks.
6266 * xselect.c (Qx_lost_selection_functions)
6267 (Qx_sent_selection_functions): New vars.
6268 (syms_of_xselect): DEFSYM them.
6269 (x_handle_selection_request): Pass Qx_sent_selection_functions
6270 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6271 (x_handle_selection_clear,x_clear_frame_selections):
6272 Pass Qx_lost_selection_functions rather than
6273 Vx_lost_selection_functions to Frun_hook_with_args.
6274
47ea7f44
PE
62752011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6276
ac389d0c 6277 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6278 The old code sometimes used this field without initializing it.
6279
47ea7f44
PE
6280 * alloc.c (gc_sweep): Don't read past end of array.
6281 In theory, the old code could also have corrupted Emacs internals,
6282 though it'd be very unlikely.
6283
bc985c87
AS
62842011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6285
6286 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6287 argument. (Bug#4026)
bc985c87 6288
0cf34688
LMI
62892011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6290
b3dadd76
LMI
6291 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6292 key" (bug#4257).
6293
0cf34688
LMI
6294 * window.c (Fset_window_start): Doc fix (bug#4199).
6295 (Fset_window_hscroll): Ditto.
6296
270768cd
PE
62972011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6298
077e3dda 6299 Fix minor new problems caught by GCC 4.6.1.
270768cd 6300 * term.c (init_tty): Remove unused local.
490011a6 6301 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6302 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6303 not used otherwise.
270768cd 6304
b1f58454
CY
63052011-07-12 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6308
22b9578d
LMI
63092011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6310
6e70ab07
LMI
6311 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6312 are the mini-buffer and the echo area (bug#3320).
6313
22b9578d
LMI
6314 * term.c (init_tty): Remove support for supdup, c10 and perq
6315 terminals, which are no longer supported (bug#1482).
6316
8974cc9f
JB
63172011-07-10 Johan Bockgård <bojohan@gnu.org>
6318
6319 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6320
a560d974
JD
63212011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6322
6323 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6324 for non-popups (Bug#3642).
6325
1dae0f0a
AS
63262011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6327
268c2c36 6328 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6329 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6330 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6331 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6332 * data.c (fmod): Likewise.
6333 * dispnew.c (swap_glyphs_in_rows): Likewise.
6334 * emacs.c (memory_warning_signal): Likewise.
6335 * floatfns.c (float_error): Likewise.
6336 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6337 (otf_open, font_otf_capability, generate_otf_features)
6338 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6339 Likewise.
6340 * image.c (pbm_read_file): Likewise.
6341 * indent.c (string_display_width): Likewise.
6342 * intervals.c (check_for_interval, search_for_interval)
6343 (inc_interval_count, count_intervals, root_interval)
6344 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6345 * lread.c (defalias): Likewise.
268c2c36 6346 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6347 * regex.c (set_image_of_range_1, set_image_of_range)
6348 (regex_grow_registers): Likewise.
6349 * sysdep.c (strerror): Likewise.
6350 * termcap.c (valid_filename_p, tprint, main): Likewise.
6351 * tparam.c (main): Likewise.
6352 * unexhp9k800.c (run_time_remap, save_data_space)
6353 (update_file_ptrs, read_header, write_header, calculate_checksum)
6354 (copy_file, copy_rest, display_header): Likewise.
6355 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6356 Likewise.
6357 * xdisp.c (check_it): Likewise.
6358 * xfaces.c (register_color, unregister_color, unregister_colors):
6359 Likewise.
6360 * xfns.c (print_fontset_result): Likewise.
6361 * xrdb.c (member, fatal, main): Likewise.
6362
99033785
PE
63632011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 Fix minor problems found by static checking (Bug#9031).
6366 * chartab.c (char_table_set_range, map_sub_char_table):
6367 Remove unused locals.
6368 (uniprop_table): Now static.
6369 * composite.c (_work_char): Remove unused static var.
6370
9cb2ac56
JB
63712011-07-09 Juanma Barranquero <lekktu@gmail.com>
6372
6373 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6374
f25661f0
JD
63752011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6376
6377 * gtkutil.c (qttip_cb): Remove code without function.
6378
8278c4fe
EZ
63792011-07-09 Eli Zaretskii <eliz@gnu.org>
6380
6381 * w32.c (pthread_sigmask): New stub.
6382
1692ae2d 63832011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6384
8a6ebd58 6385 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6386 sigprocmask is portable only for single-threaded applications, and
6387 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6388 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6389 (LIBES): Use it.
6390 * callproc.c (Fcall_process):
6391 * process.c (create_process):
6392 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6393 Use pthread_sigmask, not sigprocmask.
123403e4 6394
1b854618
JD
63952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6396
6397 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6398 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6399 wrong (Bug#8591).
6400
3fe4b549
JD
64012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6402
0ce7e563
JD
6403 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6404 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6405 (xg_hide_tooltip): Fix comment.
6406
3fe4b549
JD
6407 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6408 in registerServicesMenuSendTypes.
6409 (validRequestorForSendType): Don't check ns_return_types.
6410
6411 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6412 ns_return_type.
6413
5df75e47
JR
64142011-07-08 Jason Rumney <jasonr@gnu.org>
6415
22610910
JR
6416 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6417 SH_SHOW for hidden windows (Bug#5482).
6418
5df75e47
JR
6419 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6420 frame struct members of non-existent frames (Bug#6284).
6421
699c10bd
JD
64222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6423
4393663b
JD
6424 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6425 variable firstTime not needed on OSX >= 10.6.
6426 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6427 >= 10.5. Use setKnobProportion, setDoubleValue.
6428
6429 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6430 (MAC_OS_X_VERSION_10_5): Define if not defined.
6431 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6432 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6433 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6434
6435 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6436 cString and lossyCString on OSX >= 10.4
6437
58179cce 6438 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6439 sizeToFit on OSX >= 10.2.
6440
6441 * nsimage.m (allocInitFromFile): Don't use deprecated method
6442 bestRepresentationForDevice on OSX >= 10.6.
6443
6444 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6445 to avoid warning.
6446
6447 * emacs.c: Declare unexec_init_emacs_zone.
6448
a63e0781
JD
6449 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6450
699c10bd
JD
6451 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6452
6453 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6454 on svcsMenu (Bug#8842).
6455
6456 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6457 ns_return_types.
6458 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6459
6460 * nsterm.m (QUTF8_STRING): Declare.
6461 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6462 (validRequestorForSendType): Return type is (id).
6463 Change indexOfObjectIdenticalTo to indexOfObject.
6464 Check if we have local selection before returning self (Bug#8842).
6465 (writeSelectionToPasteboard): Put local selection into paste board
6466 if we have a local selection (Bug#8842).
6467 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6468
6469 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6470 (ns_get_local_selection): Declare.
6471
54e10184
LMI
64722011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6473
9888ff71
LMI
6474 * keymap.c (describe_map_tree): Don't insert a double newline at
6475 the end of the buffer (bug#1169) and return whether we inserted
6476 something.
6477
54e10184
LMI
6478 * callint.c (Fcall_interactively): Change "reading args" to
6479 "providing args" to try to clarify what it does (bug#1010).
6480
15fa4783
KH
64812011-07-07 Kenichi Handa <handa@m17n.org>
6482
6483 * composite.c (composition_compute_stop_pos): Ignore a static
6484 composition starting before CHARPOS (Bug#8915).
6485
6486 * xdisp.c (handle_composition_prop): Likewise.
6487
a8815b00
EZ
64882011-07-07 Eli Zaretskii <eliz@gnu.org>
6489
6490 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6491 (Bug#9015)
6492
ef7b981d 64932011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6494
6495 * character.h (unicode_category_t): New enum type.
6496
6497 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6498 (Qchar_code_property_table): New variable.
6499 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6500 (UNIPROP_COMPRESSED_FORM_P): New macros.
6501 (char_table_ascii): Uncompress the compressed values.
6502 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6503 Uncompress the compressed values.
ac389d0c 6504 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6505 (char_table_ref_and_range): Uncompress the compressed values.
6506 (sub_char_table_set): New arg is_uniprop. Callers changed.
6507 Uncompress the compressed values.
6508 (sub_char_table_set_range): Args changed. Callers changed.
6509 (char_table_set_range): Adjuted for the above change.
6510 (map_sub_char_table): Delete args default_val and parent. Add arg
6511 top. Give decoded values to a Lisp function.
640c8776 6512 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6513 values to a Lisp function. Gcpro more variables.
6514 (uniprop_table_uncompress)
6515 (uniprop_decode_value_run_length): New functions.
6516 (uniprop_decoder, uniprop_decoder_count): New variables.
6517 (uniprop_get_decoder, uniprop_encode_value_character)
6518 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6519 New functions.
6520 (uniprop_encoder, uniprop_encoder_count): New variables.
6521 (uniprop_get_encoder, uniprop_table)
6522 (Funicode_property_table_internal, Fget_unicode_property_internal)
6523 (Fput_unicode_property_internal): New functions.
6524 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6525 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6526 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6527 char-code-property-alist.
6528
640c8776 6529 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6530 Vunicode_category_table.
6531
640c8776 6532 * font.c (font_range): Adjust for the change of
c805dec0
KH
6533 Vunicode_category_table.
6534
76b397fb
DN
65352011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6536
6537 * m/iris4d.h: Remove file, move contents ...
6538 * s/irix6-5.h: ... here.
6539
22b4128e
PE
65402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6541
6542 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6543 * alloc.c (mark_buffer):
6544 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6545 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6546 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6547 This isn't true in general, and it's particularly not true
6548 if Emacs is configured with --with-wide-int.
6549 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6550 New macros, used in the buffer.c change.
6551
869795d6
JD
65522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6553
6554 * xsettings.c: Use both GConf and GSettings if both are available.
6555 (store_config_changed_event): Add comment.
6556 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6557 (store_tool_bar_style_changed): New functions.
5e617bc2 6558 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6559 (struct xsettings): Move font inside HAVE_XFT.
6560 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6561 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6562 Move inside HAVE_XFT.
640c8776 6563 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6564 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6565 also.
6566 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6567 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6568 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6569 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6570 (parse_settings): Move check for font inside HAVE_XFT.
6571 (read_settings, apply_xft_settings): Add comment.
6572 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6573 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6574 call store_font_name_changed.
6575 (xft_settings_event): Add comment.
6576 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6577 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6578 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6579 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6580 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6581 (xsettings_get_system_font, xsettings_get_system_normal_font):
6582 Add comment.
869795d6 6583
d8ed26bd
PE
65842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6585
6586 Random fixes. E.g., (random) never returned negative values.
6587 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6588 subseconds part to the entropy, as that's a bit more random.
6589 Prefer signed to unsigned, since the signedness doesn't matter and
6590 in general we prefer signed. When given a limit, use a
6591 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6592 latter isn't right if USE_2_TAGS_FOR_INTS.
6593 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6594 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6595
cabf1cac
SM
65962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6597
6598 * textprop.c (text_property_stickiness):
6599 Obey Vtext_property_default_nonsticky.
6600 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6601 * w32fns.c (syms_of_w32fns):
6602 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6603
6e9b2be9
PE
66042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6605
6606 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6607 This is more efficient than Ffile_directory_p and avoids a minor race.
6608
90186c68
LMI
66092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6610
7c301272
LMI
6611 * buffer.c (Foverlay_put): Say what the return value is
6612 (bug#7835).
6613
c4f2d8d4
LMI
6614 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6615 is a directory before asking whether to use the file name
6616 (bug#7564).
ad637907
LMI
6617 (barf_or_query_if_file_exists): Make the "File is a directory"
6618 error be more correct.
c4f2d8d4 6619
90186c68
LMI
6620 * fns.c (Frequire): Remove the mention of the .gz files, since
6621 that's installation-specific, but keep the mention of
6622 `get-load-suffixes'.
6623
da64016e
PE
66242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6625
6626 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6627 Report string overflow if the output is too long.
6628
7d47b580
JB
66292011-07-04 Juanma Barranquero <lekktu@gmail.com>
6630
a555cb87
JB
6631 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6632 (syms_of_gnutls): Remove duplicate DEFSYM for
6633 Qgnutls_bootprop_verify_hostname_error, an error for
6634 Qgnutls_bootprop_verify_error (which is no longer used).
6635
7d47b580
JB
6636 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6637 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6638 Also (re)move comments that are misplaced or no longer relevant.
6639
1e49bfab
LMI
66402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6641
6642 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6643
1485f4c0
CY
66442011-07-03 Chong Yidong <cyd@stupidchicken.com>
6645
6646 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6647 and background color parameters if they have been changed.
6648
a9ab721e
LMI
66492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6650
6651 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6652
cf7cff57
PE
66532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6654
2e13213d
PE
6655 * xsettings.c (SYSTEM_FONT): Define only when used.
6656 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6657
cf7cff57
PE
6658 * keymap.c (access_keymap_1): Now static.
6659
7a8e04f7
CY
66602011-07-02 Chong Yidong <cyd@stupidchicken.com>
6661
6662 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6663 leave any prefix arg for the up event (Bug#1586).
6664
61352f62
LMI
66652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6666
69bb1ef7
LMI
6667 * lread.c (syms_of_lread): Mention single symbols defined by
6668 `defvar' or `defconst' (bug#7154).
6669
61352f62 6670 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6671 (Frequire): Mention get-load-suffixes.
61352f62 6672
28545e04
MR
66732011-07-02 Martin Rudalics <rudalics@gmx.at>
6674
6675 * window.h (window): Remove clone_number slot.
6676 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6677 Remove.
6678 (make_parent_window, make_window, saved_window)
6679 (Fset_window_configuration, save_window_save): Don't deal with
6680 clone numbers.
6681 * buffer.c (Qclone_number): Remove declaration.
6682 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6683
3349e122
SM
66842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6685
6686 Add multiple inheritance to keymaps.
6687 * keymap.c (Fmake_composed_keymap): New function.
6688 (Fset_keymap_parent): Simplify.
6689 (fix_submap_inheritance): Remove.
6690 (access_keymap_1): New function extracted from access_keymap to handle
6691 embedded parents and handle lists of maps.
6692 (access_keymap): Use it.
6693 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6694 (Fcopy_keymap): Handle embedded parents.
6695 (Fcommand_remapping, define_as_prefix): Simplify.
6696 (Fkey_binding): Simplify.
6697 (syms_of_keymap): Move minibuffer-local-completion-map,
6698 minibuffer-local-filename-completion-map,
6699 minibuffer-local-must-match-map, and
6700 minibuffer-local-filename-must-match-map to Elisp.
6701 (syms_of_keymap): Defsubr make-composed-keymap.
6702 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6703 (parse_menu_item): Trivial simplification.
6704
3279eb87
GM
67052011-07-01 Glenn Morris <rgm@gnu.org>
6706
6707 * Makefile.in (SETTINGS_LIBS): Fix typo.
6708
4550efdf
KI
67092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6710
6711 * coding.c (Fencode_coding_string): Record the last coding system
6712 used, as the function doc string says (bug#8738).
6713
0949d2b6
JD
67142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6715
6716 * xsettings.c (store_monospaced_changed): Take new font as arg and
6717 check for change against current_mono_font.
6718 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6719 (emacs_settings_constructor, emacs_settings_get_property)
6720 (emacs_settings_set_property, emacs_settings_class_init)
6721 (emacs_settings_init, gsettings_obj): Remove.
6722 (something_changedCB): New function for HAVE_GSETTINGS.
6723 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6724 with value as argument.
6725 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6726 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6727 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6728 "changed".
6729
6730 * xgselect.c: Add defined (HAVE_GSETTINGS).
6731 (xgselect_initialize): Ditto.
6732
6733 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6734 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6735 xg_select.
6736
bbc6b304
PE
67372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6738
6739 * eval.c (struct backtrace): Simplify and port the data structure.
6740 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6741 signed bit field, as this assumption is not portable and it makes
6742 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6743 "char debug_on_exit : 1" as this is not portable either; instead,
6744 use the portable "unsigned int debug_on_exit : 1". Remove unused
6745 member evalargs. Remove obsolete comments about cc bombing out.
6746
9851bfc5
JD
67472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6748
51bb811f 6749 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6750 Let HAVE_GSETTINGS override HAVE_GCONF.
6751 (store_monospaced_changed): New function.
6752 (EMACS_SETTINGS): A new type derived from GObject to handle
6753 GSettings notifications.
6754 (emacs_settings_constructor, emacs_settings_get_property)
6755 (emacs_settings_set_property, emacs_settings_class_init):
6756 New functions.
6757 (gsettings_client, gsettings_obj): New variables.
6758 (GSETTINGS_SCHEMA): New define.
6759 (something_changedCB): Call store_monospaced_changed.
6760 (init_gsettings): New function.
6761 (xsettings_initialize): Call init_gsettings.
6762 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6763 to NULL.
6764
640c8776 6765 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6766 GCONF_CFLAGS/LIBS.
6767
5386012d
MR
67682011-06-29 Martin Rudalics <rudalics@gmx.at>
6769
6770 * window.c (resize_root_window, grow_mini_window)
6771 (shrink_mini_window): Rename Qresize_root_window to
6772 Qwindow_resize_root_window and Qresize_root_window_vertically to
6773 Qwindow_resize_root_window_vertically.
6774
f13e0b08
PE
67752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6776
6777 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6778
94515237
JB
67792011-06-27 Juanma Barranquero <lekktu@gmail.com>
6780
6781 * makefile.w32-in: Redesign dependencies so they reflect more
6782 clearly which files are directly included by each source file,
6783 and not through other includes.
6784
e43b6e43
MR
67852011-06-27 Martin Rudalics <rudalics@gmx.at>
6786
6787 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6788 (sort_overlays, overlay_strings): When an overlay's clone number
6789 matches the window's clone number process the overlay even if
6790 the overlay's window property doesn't match the current window.
6791
d68443dc
MR
6792 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6793 (Fwindow_hchild): Rename to Fwindow_left_child.
6794 (Fwindow_next): Rename to Fwindow_next_sibling.
6795 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6796 (resize_window_check): Rename to window_resize_check.
6797 (resize_window_apply): Rename to window_resize_apply.
6798 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6799 (Fdelete_other_windows_internal, resize_frame_windows)
6800 (Fsplit_window_internal, Fdelete_window_internal)
6801 (grow_mini_window, shrink_mini_window)
6802 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6803
c7e73be5
JD
68042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6805
6806 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6807 (emacs_fixed_set_min_size): Remove.
6808 (emacs_fixed_new): Take frame as argument.
6809
6810 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6811 (_EmacsFixedPrivate): Remove minwidth/height.
6812 Add struct frame *f.
6813 (emacs_fixed_init): Initialize priv->f.
6814 (get_parent_class, emacs_fixed_set_min_size): Remove.
6815 (emacs_fixed_new): Set priv->f to argument.
6816 (emacs_fixed_get_preferred_width)
6817 (emacs_fixed_get_preferred_height): Use min_width/height from
6818 frames size_hint to set minimum and natural (Bug#8919).
6819 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6820 and use min_width/height from frames size_hint to set
6821 min_width/height (Bug#8919).
6822
6823 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6824 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6825 Fix indentation.
c7e73be5 6826
cf99dcf8
EZ
68272011-06-26 Eli Zaretskii <eliz@gnu.org>
6828
6829 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6830 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6831 called at ZV.
6832
029529ac
CY
68332011-06-26 Chong Yidong <cyd@stupidchicken.com>
6834
6835 * process.c (wait_reading_process_output): Bypass select if
6836 waiting for a cell while ignoring keyboard input, and input is
6837 pending. Suggested by Jan Djärv (Bug#8869).
6838
7a7ef429
PE
68392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6840
6841 Use gnulib's dup2 module instead of rolling our own.
6842 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6843
11fdef7d 68442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6845
6846 * dispnew.c (scrolling_window): Before scrolling, turn off a
6847 mouse-highlight in the window being scrolled.
6848
cd3520a4
JB
68492011-06-24 Juanma Barranquero <lekktu@gmail.com>
6850
6851 Move DEFSYM to lisp.h and use everywhere.
6852
6853 * character.h (DEFSYM): Move declaration...
6854 * lisp.h (DEFSYM): ...here.
6855
6856 * gnutls.c:
6857 * minibuf.c:
6858 * w32menu.c:
6859 * w32proc.c:
6860 * w32select.c: Don't include character.h.
6861
6862 * alloc.c (syms_of_alloc):
6863 * buffer.c (syms_of_buffer):
6864 * bytecode.c (syms_of_bytecode):
6865 * callint.c (syms_of_callint):
6866 * casefiddle.c (syms_of_casefiddle):
6867 * casetab.c (init_casetab_once):
6868 * category.c (init_category_once, syms_of_category):
6869 * ccl.c (syms_of_ccl):
6870 * cmds.c (syms_of_cmds):
6871 * composite.c (syms_of_composite):
6872 * dbusbind.c (syms_of_dbusbind):
6873 * dired.c (syms_of_dired):
6874 * dispnew.c (syms_of_display):
6875 * doc.c (syms_of_doc):
6876 * editfns.c (syms_of_editfns):
6877 * emacs.c (syms_of_emacs):
6878 * eval.c (syms_of_eval):
6879 * fileio.c (syms_of_fileio):
6880 * fns.c (syms_of_fns):
6881 * frame.c (syms_of_frame):
6882 * fringe.c (syms_of_fringe):
6883 * insdel.c (syms_of_insdel):
6884 * keymap.c (syms_of_keymap):
6885 * lread.c (init_obarray, syms_of_lread):
6886 * macros.c (syms_of_macros):
6887 * msdos.c (syms_of_msdos):
6888 * print.c (syms_of_print):
6889 * process.c (syms_of_process):
6890 * search.c (syms_of_search):
6891 * sound.c (syms_of_sound):
6892 * syntax.c (init_syntax_once, syms_of_syntax):
6893 * terminal.c (syms_of_terminal):
6894 * textprop.c (syms_of_textprop):
6895 * undo.c (syms_of_undo):
6896 * w32.c (globals_of_w32):
6897 * window.c (syms_of_window):
6898 * xdisp.c (syms_of_xdisp):
6899 * xfaces.c (syms_of_xfaces):
6900 * xfns.c (syms_of_xfns):
6901 * xmenu.c (syms_of_xmenu):
6902 * xsettings.c (syms_of_xsettings):
6903 * xterm.c (syms_of_xterm): Use DEFSYM.
6904
4228cf16
TZ
69052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6906
cd3520a4 6907 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6908
7fcccf1e
PE
69092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6910
7efb4e0e
PE
6911 Integer and buffer overflow fixes (Bug#8873).
6912
ff5844ad
PE
6913 * print.c (printchar, strout): Check for string overflow.
6914 (PRINTPREPARE, printchar, strout):
6915 Don't set size unless allocation succeeds.
6916
90532f02
PE
6917 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6918 for sizes. Check for string overflow more accurately.
6919 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6920
6d84508d
PE
6921 * macros.c: Integer and buffer overflow fixes.
6922 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6923 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6924 Use ptrdiff_t, not int, for sizes.
6925 Don't increment bufsize until after realloc succeeds.
6926 Check for size-calculation overflow.
6927 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6928
437b2cb4
PE
6929 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6930
8b9ac8b4
PE
6931 * lread.c: Integer overflow fixes.
6932 (read_integer): Radix is now EMACS_INT, not int,
6933 to improve quality of diagnostics for out-of-range radices.
6934 Calculate buffer size correctly for out-of-range radices.
6935 (read1): Check for integer overflow in radices, and in
6936 read-circle numbers.
82cb60d3
PE
6937 (read_escape): Avoid int overflow.
6938 (Fload, openp, read_buffer_size, read1)
6939 (substitute_object_recurse, read_vector, read_list, map_obarray):
6940 Use ptrdiff_t, not int, for sizes.
6941 (read1): Use EMACS_INT, not int, for sizes.
20270765 6942 Check for size overflow.
8b9ac8b4 6943
7fcccf1e
PE
6944 * image.c (cache_image): Check for size arithmetic overflow.
6945
bfbbd7e7
PE
6946 * lread.c: Integer overflow issues.
6947 (saved_doc_string_size, saved_doc_string_length)
6948 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6949 Now ptrdiff_t, not int.
6950 (read1): Don't assume doc string length fits in int. Check for
6951 out-of-range doc string lengths.
6952 (read_list): Don't assume file position fits in int.
39019e54 6953 (read_escape): Check for hex character overflow.
bfbbd7e7 6954
4e323265
LL
69552011-06-22 Leo Liu <sdl.web@gmail.com>
6956
6957 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6958 Move to minibuffer.el.
6959
85fece3e
PE
69602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6961
20b84ce9 6962 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6963 The following patches are for when GLYPH_DEBUG && !XASSERT.
6964 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6965 * dispnew.c (flush_stdout):
6966 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6967 Mark as externally visible.
6968 * dispnew.c (check_window_matrix_pointers): Now static.
6969 * dispnew.c (window_to_frame_vpos):
6970 * xfns.c (unwind_create_frame):
6971 * xterm.c (x_check_font): Remove unused local.
6972 * scroll.c (CHECK_BOUNDS):
6973 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6974 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6975 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6976 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6977 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6978 Now static.
6979 (debug_method_add): Use va_list and vsprintf rather than relying
6980 on undefined behavior with wrong number of arguments.
6981 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6982 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6983 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6984 since we're not interested in debugging glyphs with old libraries.
6985 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6986 GCC 4.6.0's static checking.
6987
0766b489
PE
69882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6989
31fd4b32
PE
6990 Integer overflow and signedness fixes (Bug#8873).
6991 A few related buffer overrun fixes, too.
6992
b79e8648
PE
6993 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6994
0766b489
PE
6995 * dispextern.h (struct face.stipple):
6996 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6997 (x_bitmap_mask, x_allocate_bitmap_record)
6998 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6999 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7000 (x_create_bitmap_from_xpm_data):
7001 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7002 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7003 (.bitmaps_last):
7004 * xfaces.c (load_pixmap):
7005 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7006 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7007 (.bitmaps_last, struct x_output.icon_bitmap):
7008 Use ptrdiff_t, not int, for bitmap indexes.
7009 (x_allocate_bitmap_record): Check for size overflow.
7010 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7011
b081724f
PE
7012 Use ptrdiff_t, not int, for overlay counts.
7013 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7014 * editfns.c (overlays_around, get_pos_property):
7015 * textprop.c (get_char_property_and_overlay):
7016 * xdisp.c (next_overlay_change, note_mouse_highlight):
7017 * xfaces.c (face_at_buffer_position):
21514da7
PE
7018 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7019 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7020 (Fnext_overlay_change, Fprevious_overlay_change)
7021 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7022 Use ptrdiff_t, not int, for sizes.
21514da7 7023 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7024
3de73e5e
PE
7025 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7026
2606c57b
PE
7027 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7028 (x_session_initialize): Do not assume string length fits in int.
7029
aaafe47a
PE
7030 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7031 This is unlikely, but can occur if DPI is outlandish.
7032
2674ddc8 7033 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7034 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7035
28154962
PE
7036 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7037 * xrdb.c (magic_file_p, search_magic_path):
7038 Omit last arg SUFFIX; it was always 0. All callers changed.
7039 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7040
7de51af5
PE
7041 * xfont.c (xfont_match): Avoid need for strlen.
7042
25ed6cc3
PE
7043 * xfns.c: Don't assume strlen fits in int.
7044 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7045
4eab31dd
PE
7046 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7047 not unsigned long, as we prefer signed integers. All callers changed.
7048 Detect integer overflow in repeat count.
7049 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7050 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7051
171e2a58
PE
7052 * termcap.c: Don't assume sizes fit in int and never overflow.
7053 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7054 (gobble_line): Check for size-calculation overflow.
7055
ad39faca 7056 * minibuf.c (Fread_buffer):
6e5bb2dc 7057 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7058 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7059 Don't assume string length fits in int.
7060
52c61c22 7061 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7062 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7063
b5b8c9e5
PE
7064 * font.c: Don't assume string length fits in int.
7065 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7066 Use ptrdiff_t, not int.
ccd6111c
PE
7067 (font_intern_prop): Don't assume string length fits in int.
7068 Don't assume integer property fits in fixnum.
7069 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7070
882f0d81 7071 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7072 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7073 Reformulate so as not to need the command string.
7074 Invoke gzip -cd rather than gunzip, as it's more portable.
7075 (lock_info_type, lock_file_1, lock_file):
7076 Don't assume pid_t and time_t fit in unsigned long.
7077 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7078 (current_lock_owner): Prefer signed type for sizes.
7079 Use memcpy, not strncpy, where memcpy is what is really wanted.
7080 Don't assume (via atoi) that time_t and pid_t fit in int.
7081 Check for time_t and/or pid_t out of range, e.g., via a network share.
7082 Don't alloca where an auto var works fine.
7083
93f4cf88
PE
7084 * fileio.c: Fix some integer overflow issues.
7085 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7086 Don't assume string length fits in int.
7087 (directory_file_name): Don't assume string length fits in long.
7088 (make_temp_name): Don't assume pid fits in int, or that its print
7089 length is less than 20.
7090
f3e92b69
PE
7091 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7092
1bfdaf10
PE
7093 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7094
35016e9a
PE
7095 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7096
3d1e65a1
PE
7097 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7098 We prefer signed integers, even for size calculations.
7099
0b963a93
PE
7100 * emacs.c: Don't assume string length fits in 'int'.
7101 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7102 (main): Don't invoke strlen when not needed.
7103
573f4b54
PE
7104 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7105 (XD_DEBUG_MESSAGE): Don't waste a byte.
7106
989f33ba
PE
7107 * callproc.c (getenv_internal_1, getenv_internal)
7108 (Fgetenv_internal):
965d34eb
PE
7109 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7110
e4d29b33
PE
7111 * lread.c (invalid_syntax): Omit length argument.
7112 All uses changed. This doesn't fix a bug, but it simplifies the
7113 code away from its former Hollerith-constant appearance, and it's
7114 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7115 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7116
eb49b136
PE
7117 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7118 This didn't break anything, but it didn't help either.
7119 It's confusing to put a bogus integer in a place where the actual
7120 value does not matter.
9f62aeb1 7121 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7122 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7123
15375a22
PE
7124 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7125 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7126 implementation.
b61cc01c
PE
7127 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7128 We prefer signed types, and the value cannot exceed the EMACS_INT
7129 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7130 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7131 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7132 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7133
53b2623d
PE
7134 * indent.c (sane_tab_width): New function.
7135 (current_column, scan_for_column, Findent_to, position_indentation)
7136 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7137 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7138
51cab52b 7139 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7140
f2ed8a70
PE
7141 * lisp.h (lint_assume): New macro.
7142 * composite.c (composition_gstring_put_cache):
7143 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7144
abe80cc6
PE
7145 * editfns.c, insdel.c:
7146 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7147
b02c740e
PE
7148 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7149
ebc96716
PE
7150 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7151
b4e50fa0 7152 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7153 Use much-faster test for byte-length change.
311d5d7c 7154 Don't assume string byte-length fits in 'int'.
a4cf38e4 7155 Check that character arg fits in 'int'.
85461888 7156 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7157
c0c1ee9f
PE
7158 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7159
a498d7f4
PE
7160 * fns.c (concat): Catch string overflow earlier.
7161 Do not rely on integer wraparound.
7162
51cab52b
PE
7163 * dispextern.h (struct it.overlay_strings_charpos)
7164 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7165 * xdisp.c (forward_to_next_line_start)
7166 (back_to_previous_visible_line_start)
7167 (reseat_at_next_visible_line_start, next_element_from_buffer):
7168 Don't arbitrarily truncate the value of 'selective' to int.
7169
76031fad
PE
7170 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7171
5eb55db9
PE
7172 * composite.c: Don't truncate sizes to 'int'.
7173 (composition_gstring_p, composition_reseat_it)
7174 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7175 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7176 not EMACS_UINT, for indexes.
5eb55db9 7177
0703a717
PE
7178 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7179
d6202519
PE
7180 * buffer.c: Include <verify.h>.
7181 (struct sortvec.priority, struct sortstr.priority):
8961a454 7182 Now EMACS_INT, not int.
c20998a7 7183 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7184 (struct sortstr.size, record_overlay_string)
7185 (struct sortstrlist.size, struct sortlist.used):
7186 Don't truncate size to int.
7187 (record_overlay_string): Check for size-calculation overflow.
d6202519 7188 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7189
d5a19415
JM
71902011-06-22 Jim Meyering <meyering@redhat.com>
7191
029529ac 7192 Don't leak an XBM-image-sized buffer
d5a19415
JM
7193 * image.c (xbm_load): Free the image buffer after using it.
7194
a9041e6c
PE
71952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7196
7197 Port to Sun C.
7198 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7199 that Sun C diagnosed.
7200 * fns.c (secure_hash): Fix pointer signedness issue.
7201 * intervals.c (static_offset_intervals): New function.
7202 (offset_intervals): Use it.
7203
7f3f739f
LL
72042011-06-21 Leo Liu <sdl.web@gmail.com>
7205
7206 * deps.mk (fns.o):
7207 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7208 sha512.h.
7209
7210 * fns.c (secure_hash): Rename from crypto_hash_function and change
7211 the first arg to accept symbols.
5b66d427 7212 (Fsecure_hash): New primitive.
7f3f739f
LL
7213 (syms_of_fns): New symbols.
7214
76147d94
DD
72152011-06-20 Deniz Dogan <deniz@dogan.se>
7216
7217 * process.c (Fset_process_buffer): Clarify return value in
7218 docstring.
7219
7d7d0045
CY
72202011-06-18 Chong Yidong <cyd@stupidchicken.com>
7221
7222 * dispnew.c (add_window_display_history): Use BVAR.
7223
7224 * xdisp.c (debug_method_add): Use BVAR.
7225 (check_window_end, dump_glyph_matrix, dump_glyph)
7226 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7227
7228 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7229 Likewise.
7230
7231 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7232 check till after the cache is created in init_frame_faces.
7233
ff2bc410
SM
72342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7235
7236 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7237
28177add
PE
72382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7239
dd3482fe
PE
7240 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7241 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7242 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7243
393d71f3 7244 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7245 * fileio.c (Finsert_file_contents):
7246 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7247 Remove the old (too-loose) buffer overflow checks.
7248 They weren't needed, since make_gap checks for buffer overflow.
7249 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7250 The old code merely checked for Emacs fixnum overflow, and relied
7251 on undefined (wraparound) behavior. The new code avoids undefined
7252 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7253
2e6813b0 7254 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7255 Tune. Don't use wider integers than needed. Don't use alloca.
7256 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7257
599a9e4f
PE
7258 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7259
99561444
PE
7260 * insdel.c, lisp.h (buffer_overflow): New function.
7261 (insert_from_buffer_1, replace_range, replace_range_2):
7262 * insdel.c (make_gap_larger):
7263 * editfns.c (Finsert_char):
7264 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7265
28177add
PE
7266 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7267
e69dafad
PE
72682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7269
4baa020d 7270 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7271
b1c46f02
PE
7272 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7273 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7274
e69dafad
PE
7275 * fileio.c: Don't assume EMACS_INT fits in off_t.
7276 (emacs_lseek): New static function.
7277 (Finsert_file_contents, Fwrite_region): Use it.
7278 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7279
566684ea
PE
7280 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7281
e6966cd6
PE
7282 * fns.c: Don't overflow int when computing a list length.
7283 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7284 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7285 truncation on 64-bit hosts. Check for QUIT every
7286 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7287 faster and is responsive enough.
7288 (Flength): Report an error instead of overflowing an integer.
7289 (Fsafe_length): Return a float if the value is not representable
7290 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7291 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7292 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7293
dd0b0efb
PE
7294 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7295 (header_size, word_size): New constants.
7296 (allocate_vectorlike): Don't check size overflow here.
7297 (allocate_vector): Check it here instead, since this is the only
7298 caller of allocate_vectorlike that could cause overflow.
7299 Check that the new vector's length is representable as a fixnum.
7300
86fe5cfe
PE
7301 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7302 The previous code was bogus. For example, next_almost_prime (32)
7303 returned 39, which is undesirable as it is a multiple of 3; and
7304 next_almost_prime (24) returned 25, which is a multiple of 5 so
7305 why was the code bothering to check for multiples of 7?
7306
80e88859
PE
7307 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7308
4a2f0ad6
PE
7309 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7310
f66c7cf8
PE
7311 Variadic C functions now count arguments with ptrdiff_t.
7312 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7313 Back then I didn't know that the Emacs coding style prefers signed int.
7314 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7315 were being counted with int, which may truncate counts on 64-bit
7316 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7317 * lisp.h (struct Lisp_Subr.function.aMANY)
7318 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7319 Arg counts are now ptrdiff_t, not size_t.
7320 All variadic functions and their callers changed accordingly.
7321 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7322 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7323 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7324 * callint.c (Fcall_interactively): Check arg count for overflow,
7325 to avoid potential buffer overrun. Use signed char, not 'int',
7326 for 'varies' array, so that we needn't bother to check its size
7327 calculation for overflow.
7328 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7329 * eval.c (apply_lambda):
7330 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7331 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7332 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7333
a1759b76
PE
7334 * callint.c (Fcall_interactively): Don't use index var as event count.
7335
d96be9fc
PE
7336 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7337 * mem-limits.h (SIZE): Remove; no longer used.
7338
a690a978 7339 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7340
578c21e6
PE
7341 Remove unnecessary casts.
7342 * xterm.c (x_term_init):
7343 * xfns.c (x_set_border_pixel):
7344 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7345 These aren't needed now that we assume ANSI C.
7346
96f53c6c
PE
7347 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7348 It's more likely to cause problems (due to unsigned overflow)
7349 than to cure them.
7350
83c77d31
PE
7351 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7352
ee2079f1
PE
7353 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7354
6da65536
PE
7355 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7356
7147c4a4
PE
7357 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7358
193e32d9
PE
7359 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7360
e5533da6
PE
7361 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7362
9910e595
PE
7363 GLYPH_CODE_FACE returns EMACS_INT, not int.
7364 * dispextern.h (merge_faces):
7365 * xfaces.c (merge_faces):
01103c44
PE
7366 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7367 Don't assume EMACS_INT fits in int.
9910e595 7368
2638320e
PE
7369 * character.h (CHAR_VALID_P): Remove unused parameter.
7370 * fontset.c, lisp.h, xdisp.c: All uses changed.
7371
045eb8d9
PE
7372 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7373
c1f134b5
PE
7374 * fns.c (concat): Minor tuning based on overflow analysis.
7375 This doesn't fix any bugs. Use int to hold character, instead
7376 of constantly refetching from Emacs object. Use XFASTINT, not
7377 XINT, for value known to be a character. Don't bother comparing
7378 a single byte to 0400, as it's always less.
7379
395fcb93 7380 * floatfns.c (Fexpt):
327eeec8
PE
7381 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7382
abbd3d23
PE
7383 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7384 for characters.
7385
684a03ef
PE
7386 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7387
0fed43f3
PE
7388 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7389 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7390 incorrectly succeed when S was a string, because 4294967386 was
7391 truncated before it was used.
7392
8fd02eb7
PE
7393 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7394 Otherwise, an out-of-range integer could cause undefined behavior
7395 on a 64-bit host.
7396
f8c86b69
PE
7397 * composite.c: Use int, not EMACS_INT, for characters.
7398 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7399 EMACS_INT, for values that are known to be in character range.
7400 This doesn't fix any bugs but is the usual style inside Emacs and
7401 may generate better code on 32-bit machines.
7402
34206dd2
PE
7403 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7404 This is for reasons similar to the recent CHAR_STRING fix.
7405 * charset.c (Fencode_char): Check that character arg is actually
7406 a character. Pass an int to ENCODE_CHAR.
7407 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7408 wider than 'int', as a compile-time check to prevent future regressions
7409 in this area.
7410
c5958d4c 7411 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7412
7413 Make sure a 64-bit char is never passed to CHAR_STRING.
7414 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7415 by silently ignoring the top 32 bits, allowing some values
7416 that were far too large to be valid characters.
7417 * character.h: Include <verify.h>.
7418 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7419 arguments are no wider than unsigned, as a compile-time check
7420 to prevent future regressions in this area.
7421 * data.c (Faset):
01103c44 7422 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7423 (Fsubst_char_in_region):
7424 * fns.c (concat):
7425 * xdisp.c (decode_mode_spec_coding):
7426 Adjust to CHAR_STRING's new requirement.
7427 * editfns.c (Finsert_char, Fsubst_char_in_region):
7428 * fns.c (concat): Check that character args are actually
7429 characters. Without this test, these functions did the wrong
7430 thing with wildly out-of-range values on 64-bit hosts.
7431
d37ca623
PE
7432 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7433 These casts should not be needed on 32-bit hosts, either.
7434 * keyboard.c (read_char):
7435 * lread.c (Fload): Remove casts to unsigned.
7436
ea204efb
PE
7437 * lisp.h (UNSIGNED_CMP): New macro.
7438 This fixes comparison bugs on 64-bit hosts.
7439 (ASCII_CHAR_P): Use it.
7440 * casefiddle.c (casify_object):
01103c44 7441 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7442 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7443 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7444 * dispextern.h (FACE_FROM_ID):
7445 * keyboard.c (read_char): Use UNSIGNED_CMP.
7446
41cb286c
PE
7447 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7448 not to EMACS_INT, to avoid GCC warning.
7449
4a1b9832
PE
7450 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7451
55daad71
PE
7452 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7453 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7454 isn't needed on 32-bit machines.
8f95c75c 7455
01103c44
PE
7456 * buffer.c (Fgenerate_new_buffer_name):
7457 Use EMACS_INT for count, not int.
0ceccced 7458 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7459
7460 * data.c (Qcompiled_function): Now static.
7461
c6f072e7
PE
7462 * window.c (window_body_lines): Now static.
7463
20ce5912
PE
7464 * image.c (gif_load): Rename local to avoid shadowing.
7465
9c4c5f81
PE
7466 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7467 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7468 * alloc.c (make_save_value): Integer argument is now of type
7469 ptrdiff_t, not int.
7470 (mark_object): Use ptrdiff_t, not int.
7471 * lisp.h (pD): New macro.
7472 * print.c (print_object): Use it.
7473
c0c5c8ae
PE
7474 * alloc.c: Use EMACS_INT, not int, to count objects.
7475 (total_conses, total_markers, total_symbols, total_vector_size)
7476 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7477 (total_free_floats, total_floats, total_free_intervals)
7478 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7479 Now EMACS_INT, not int. All uses changed.
7480 (Fgarbage_collect): Compute overall total using a double, so that
7481 integer overflow is less likely to be a problem. Check for overflow
7482 when converting back to an integer.
5a25e253
PE
7483 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7484 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7485 These were 'int' variables that could overflow on 64-bit hosts;
7486 they were never used, so remove them instead of repairing them.
211a0b2a 7487 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7488 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7489 Previously, this ceilinged at INT_MAX, but that doesn't work on
7490 64-bit machines.
e46bb31a 7491 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7492
c78baabf 7493 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7494 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7495 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7496 when a (possibly-narrower) signed value would do just as well.
7497 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7498
c9d624c6
PE
7499 * alloc.c: Catch some string size overflows that we were missing.
7500 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7501 for convenience in STRING_BYTES_MAX.
7502 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7503 The definition here is exact; the one in lisp.h was approximate.
7504 (allocate_string_data): Check for string overflow. This catches
7505 some instances we weren't catching before. Also, it catches
7506 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7507 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7508 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7509
c9d624c6
PE
7510 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7511 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7512 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7513
353032ce
PE
7514 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7515
2bccce07
PE
7516 * alloc.c (Fmake_string): Check for out-of-range init.
7517
0ac30604
SM
75182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7519
7520 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7521
c195f2de
JD
75222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7523
7524 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7525 xg_get_default_scrollbar_width.
7526
7527 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7528 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7529 (style_changed_cb): Call update_theme_scrollbar_width and call
7530 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7531 all frames (Bug#8505).
7532 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7533 Call gtk_window_set_resizable if HAVE_GTK3.
7534 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7535 and height if HAVE_GTK3 (Bug#8505).
7536 (scroll_bar_width_for_theme): New variable.
7537 (update_theme_scrollbar_width): New function.
7538 (xg_get_default_scrollbar_width): Move code to
7539 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7540 (xg_initialize): Call update_theme_scrollbar_width.
7541
7542 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7543
7544 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7545
e10ac9f1
MR
75462011-06-12 Martin Rudalics <rudalics@gmx.at>
7547
7548 * frame.c (make_frame): Call other_buffer_safely instead of
7549 other_buffer.
7550
7551 * window.c (temp_output_buffer_show): Call display_buffer with
7552 second argument Vtemp_buffer_show_specifiers and reset latter
7553 immediately after the call.
7554 (Vtemp_buffer_show_specifiers): New variable.
7555 (auto_window_vscroll_p, next_screen_context_lines)
7556 (Vscroll_preserve_screen_position): Remove leading asterisks from
7557 doc-strings.
7558
2d3c217e 75592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7560
7b7f97e8 7561 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7562 * buffer.c (Qclone_number): Remove for now, as it's unused.
7563 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7564 (record_buffer): Remove unused local.
7565 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7566 (set_frame_buffer_list): Remove; unused.
7567 * frame.h (other_visible_frames): Remove decl.
7568 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7569 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7570 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7571 if HAVE_GPM.
7572 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7573 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7574 Define only if HAVE_GPM.
7575 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7576 (update_hints_inhibit): Remove; never set. All uses removed.
7577 * widgetprv.h (emacsFrameClassRec): Remove decl.
7578 * window.c (delete_deletable_window): Now returns void, since it
7579 wasn't returning anything.
7580 (compare_window_configurations): Remove unused locals.
7581 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7582 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7583 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7584 the same widths as pointers. This follows up on the 2011-05-06 patch.
7585 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7586 * xterm.h: Likewise.
7587 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7588
1384b89e
JB
75892011-06-12 Juanma Barranquero <lekktu@gmail.com>
7590
7591 * makefile.w32-in: Update dependencies.
7592 (LISP_H): Add lib/intprops.h.
7593
1100a63c
CY
75942011-06-11 Chong Yidong <cyd@stupidchicken.com>
7595
7596 * image.c (gif_load): Add animation frame delay to the metadata.
7597 (syms_of_image): Use DEFSYM. New symbol `delay'.
7598
6198ccd0
MR
75992011-06-11 Martin Rudalics <rudalics@gmx.at>
7600
7601 * window.c (delete_deletable_window): Re-add.
7602 (Fset_window_configuration): Rewrite to handle dead buffers and
7603 consequently deletable windows.
7604 (window_tree, Fwindow_tree): Remove. Supply functionality in
7605 window.el.
7606 (compare_window_configurations): Simplify code.
7607
b6e3633c
AS
76082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7609
1ab0dee5
AS
7610 * image.c (imagemagick_load_image): Fix type mismatch.
7611 (Fimagemagick_types): Likewise.
7612
b6e3633c
AS
7613 * window.h (replace_buffer_in_windows): Declare.
7614
9397e56f
MR
76152011-06-11 Martin Rudalics <rudalics@gmx.at>
7616
7617 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7618 Qclone_number. Remove external declaration of Qdelete_window.
7619 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7620 code.
640c8776
SM
7621 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7622 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7623 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7624 buffer list implementation.
7625 (other_buffer_safely): New function.
7626 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7627 calls to replace_buffer_in_windows and
7628 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7629 if allowed.
7630 (record_buffer): Inhibit quitting and rewrite using quittable
7631 functions. Run Qbuffer_list_update_hook if allowed.
7632 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7633 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7634 Move switch-to-buffer to window.el.
9397e56f
MR
7635 (bury-buffer): Move to window.el.
7636 (Vbuffer_list_update_hook): New variable.
7637
7638 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7639 section.
7640
7641 * window.h (resize_frame_windows): Move up in code.
7642 (Fwindow_frame): Remove EXFUN.
7643 (replace_buffer_in_all_windows): Remove prototype.
7644 (replace_buffer_in_windows_safely): Add prototype.
7645
7646 * window.c: Declare Qdelete_window static again. Move down
7647 declaration of select_count.
7648 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7649 (Fother_window): Move to window.el.
7650 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7651 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7652 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7653 window.el.
7654 (replace_buffer_in_windows): Implement by calling
7655 Qreplace_buffer_in_windows.
7656 (replace_buffer_in_all_windows): Remove with some functionality
7657 moved into replace_buffer_in_windows_safely.
7658 (replace_buffer_in_windows_safely): New function.
7659 (select_window_norecord, select_frame_norecord): Move in front
7660 of run_window_configuration_change_hook. Remove now obsolete
7661 declarations.
640c8776
SM
7662 (Fset_window_buffer): Rewrite doc-string.
7663 Call Qrecord_window_buffer.
9397e56f
MR
7664 (keys_of_window): Move binding for other-window to window.el.
7665
b50691aa
CY
76662011-06-11 Chong Yidong <cyd@stupidchicken.com>
7667
7668 * dispextern.h (struct image): Replace data member, whose int_val
7669 and ptr_val fields were not used by anything, with a single
7670 lisp_val object.
7671
7672 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7673 (gif_clear_image, gif_load, imagemagick_load_image)
7674 (gs_clear_image, gs_load): Callers changed.
7675
3f754b86
PE
76762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7677
cca69397
PE
7678 * buffer.h: Include <time.h>, for time_t.
7679 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7680
109e28d0
PE
7681 Fix minor problems found by static checking.
7682
60737f02
PE
7683 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7684
4b66faf3
PE
7685 Make identifiers static if they are not used in other modules.
7686 * data.c (Qcompiled_function, Qframe, Qvector):
7687 * image.c (QimageMagick, Qsvg):
7688 * minibuf.c (Qmetadata):
7689 * window.c (resize_window_check, resize_root_window): Now static.
7690 * window.h (resize_window_check, resize_root_window): Remove decls.
7691
109e28d0
PE
7692 * window.c (window_deletion_count, delete_deletable_window):
7693 Remove; unused.
46a4ce9e
PE
7694 (window_body_lines): Now static.
7695 (Fdelete_other_windows_internal): Mark vars as initialized.
7696 Make sure 'resize_failed' is initialized.
7697 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7698 (resize_window_apply): Remove unused local.
7699 * window.h (delete_deletable_window): Remove decl.
7700
109e28d0 7701 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7702 (imagemagick_load_image): Fix pointer signedness problem by changing
7703 last arg from unsigned char * to char *. All uses changed.
7704 Also, fix a local for similar reasons.
7705 Remove unused locals. Remove locals to avoid shadowing.
7706 (fn_rsvg_handle_free): Remove; unused.
7707 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7708 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7709
3f754b86
PE
7710 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7711
2547adb1
CY
77122011-06-10 Chong Yidong <cyd@stupidchicken.com>
7713
7714 * image.c (gif_load): Fix omitted cast error introduced by
7715 2011-06-06 change.
7716
2c8e37d4
MR
77172011-06-10 Martin Rudalics <rudalics@gmx.at>
7718
7719 * window.h (resize_proportionally, orig_total_lines)
7720 (orig_top_line): Remove from window structure.
7721 (set_window_height, set_window_width, change_window_heights)
7722 (Fdelete_window): Remove prototypes.
7723 (resize_frame_windows): Remove duplicate declaration.
7724
440a42e3
EZ
77252011-06-10 Eli Zaretskii <eliz@gnu.org>
7726
7727 * window.h (resize_frame_windows, resize_window_check)
7728 (delete_deletable_window, resize_root_window)
7729 (resize_frame_windows): Declare prototypes.
7730
7731 * window.c (resize_window_apply): Make definition be "static" to
7732 match the prototype.
7733
562dd5e9
MR
77342011-06-10 Martin Rudalics <rudalics@gmx.at>
7735
7736 * window.c: Remove declarations of Qwindow_size_fixed,
7737 window_min_size_1, window_min_size_2, window_min_size,
7738 size_window, window_fixed_size_p, enlarge_window, delete_window.
7739 Remove static from declaration of Qdelete_window, it's
7740 temporarily needed by Fbury_buffer.
7741 (replace_window): Don't assign orig_top_line and
7742 orig_total_lines.
7743 (Fdelete_window, delete_window): Remove. Window deletion is
7744 handled by window.el.
640c8776
SM
7745 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7746 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7747 (Fdelete_other_windows): Remove. Deleting other windows is
7748 handled by window.el.
7749 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7750 handled in window.el.
7751 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7752 Window minimum sizes are handled in window.el.
7753 (shrink_windows, size_window, set_window_height)
7754 (set_window_width, change_window_heights, window_height)
7755 (window_width, CURBEG, CURSIZE, enlarge_window)
7756 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7757 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7758 handled in window.el.
7759 (make_dummy_parent): Rename to make_parent_window and give it a
7760 second argument horflag.
7761 (make_window): Don't set resize_proportionally any more.
7762 (Fsplit_window): Remove. Windows are split in window.el.
7763 (save_restore_action, save_restore_orig_size)
7764 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7765 Resize mini windows in window.el.
7766 (grow_mini_window, shrink_mini_window): Implement by calling
7767 Qresize_root_window_vertically, resize_window_check and
7768 resize_window_apply.
640c8776
SM
7769 (saved_window, Fset_window_configuration, save_window_save):
7770 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7771 resize_proportionally.
7772 (window_min_height, window_min_width): Move to window.el.
7773 (keys_of_window): Move bindings for delete-other-windows,
7774 split-window, delete-window and enlarge-window to window.el.
7775
7776 * buffer.c: Temporarily extern Qdelete_window.
7777 (Fbury_buffer): Temporarily call Qdelete_window instead of
7778 Fdelete_window (Fbury_buffer will move to window.el soon).
7779
7780 * frame.c (set_menu_bar_lines_1): Remove code handling
7781 orig_top_line and orig_total_lines.
7782
7783 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7784 set_window_height but set heights directly.
7785 (change_frame_size_1): Use resize_frame_windows.
7786
7787 * xdisp.c (init_xdisp): Don't use set_window_height but set
7788 heights directly.
7789
640c8776
SM
7790 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7791 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7792 run_window_configuration_change_hook.
7793
7794 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7795 instead of change_window_heights and run
7796 run_window_configuration_change_hook.
7797
1a13852e
MR
77982011-06-09 Martin Rudalics <rudalics@gmx.at>
7799
7800 * window.c (replace_window): Rename second argument REPLACEMENT to
7801 NEW. New third argument SETFLAG. Rewrite.
7802 (delete_window, make_dummy_parent): Call replace_window with
7803 third argument 1.
7804 (window_list_1): Move down in code.
7805 (run_window_configuration_change_hook): Move set_buffer part
7806 before select_frame_norecord part in order to unwind correctly.
7807 Rename count1 to count.
7808 (recombine_windows, delete_deletable_window, resize_root_window)
7809 (Fdelete_other_windows_internal)
7810 (Frun_window_configuration_change_hook, make_parent_window)
7811 (resize_window_check, resize_window_apply, Fresize_window_apply)
7812 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7813 (Fdelete_window_internal, Fresize_mini_window_internal):
7814 New functions.
1a13852e
MR
7815 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7816
f3d1777e
MR
78172011-06-08 Martin Rudalics <rudalics@gmx.at>
7818
496e208e
MR
7819 * window.h (window): Add some new members to window structure -
7820 normal_lines, normal_cols, new_total, new_normal, clone_number,
7821 splits, nest, prev_buffers, next_buffers.
7822 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7823 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7824
f3d1777e
MR
7825 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7826 Remove.
496e208e
MR
7827 (make_dummy_parent): Set new members of windows structure.
7828 (make_window): Move down in code. Handle new members of window
7829 structure.
7830 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7831 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7832 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7833 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7834 (Fset_window_next_buffers, Fset_window_clone_number):
7835 New functions.
496e208e
MR
7836 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7837 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7838 Doc-string fixes.
7839 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7840 Argument WINDOW can be now internal window too.
7841 (Fwindow_use_time): Move up in code.
7842 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7843 Rewrite doc-string.
7844 (Fset_window_configuration, saved_window)
7845 (Fcurrent_window_configuration, save_window_save): Handle new
7846 members of window structure.
b9e809c2
MR
7847 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7848 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7849 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7850 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7851 Qget_mru_window, Qresize_root_window,
7852 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7853 Qauto_buffer_name; staticpro them.
f3d1777e 7854
abde8f8c
MR
78552011-06-07 Martin Rudalics <rudalics@gmx.at>
7856
7857 * window.c (Fwindow_total_size, Fwindow_left_column)
7858 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7859 (Fwindow_list_1): New functions.
7860 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7861 (Fwindow_width, Fscroll_left, Fscroll_right):
7862 Use window_body_cols instead of window_box_text_cols.
7863 (delete_window, Fset_window_configuration):
7864 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7865 (delete_all_subwindows): Take a window as argument and not a
7866 structure. Rewrite.
190b47e6
MR
7867 (window_loop): Remove handling of GET_LRU_WINDOW and
7868 GET_LARGEST_WINDOW.
7869 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7870
7871 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7872 window_box_text_cols. delete_all_subwindows now takes a
7873 Lisp_Object as argument.
abde8f8c 7874
640c8776
SM
7875 * indent.c (compute_motion, Fcompute_motion):
7876 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7877
fa8a67e6
MR
7878 * frame.c (delete_frame): Call delete_all_subwindows with root
7879 window as argument.
7880
a54e3482
DC
78812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7882
7883 * fns.c (Fputhash): Document return value.
7884
60002bf5
CY
78852011-06-06 Chong Yidong <cyd@stupidchicken.com>
7886
7887 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7888
0c671da6 78892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7890
b862a52a 7891 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7892
be44ca6c
PE
7893 Check for overflow when converting integer to cons and back.
7894 * charset.c (Fdefine_charset_internal, Fdecode_char):
7895 Use cons_to_unsigned to catch overflow.
7896 (Fencode_char): Use INTEGER_TO_CONS.
7897 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7898 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7899 * data.c (long_to_cons, cons_to_long): Remove.
7900 (cons_to_unsigned, cons_to_signed): New functions.
7901 These signal an error for invalid or out-of-range values.
7902 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7903 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7904 * font.c (Ffont_variation_glyphs):
7905 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7906 * lisp.h: Include <intprops.h>.
7907 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7908 (cons_to_signed, cons_to_unsigned): New decls.
7909 (long_to_cons, cons_to_long): Remove decls.
7910 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7911 (Fprimitive_undo): Use CONS_TO_INTEGER.
7912 * xfns.c (Fx_window_property): Likewise.
7913 * xselect.c: Include <limits.h>.
7914 (x_own_selection, selection_data_to_lisp_data):
7915 Use INTEGER_TO_CONS.
7916 (x_handle_selection_request, x_handle_selection_clear)
7917 (x_get_foreign_selection, Fx_disown_selection_internal)
7918 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7919 (lisp_data_to_selection_data): Use cons_to_unsigned.
7920 (x_fill_property_data): Use cons_to_signed.
7921 Report values out of range.
7922
d1f3d2af
PE
7923 Check for buffer and string overflow more precisely.
7924 * buffer.h (BUF_BYTES_MAX): New macro.
7925 * lisp.h (STRING_BYTES_MAX): New macro.
7926 * alloc.c (Fmake_string):
7927 * character.c (string_escape_byte8):
7928 * coding.c (coding_alloc_by_realloc):
7929 * doprnt.c (doprnt):
7930 * editfns.c (Fformat):
7931 * eval.c (verror):
7932 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7933 since they may not be the same number.
7934 * editfns.c (Finsert_char):
7935 * fileio.c (Finsert_file_contents):
7936 Likewise for BUF_BYTES_MAX.
7937
dd52fcea
PE
7938 * image.c: Use ptrdiff_t, not int, for sizes.
7939 (slurp_file): Switch from int to ptrdiff_t.
7940 All uses changed.
7941 (slurp_file): Check that file size fits in both size_t (for
7942 malloc) and ptrdiff_t (for sanity and safety).
7943
7f9bbdbb
PE
7944 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7945 if b->modtime has its maximal value.
7946
dfe18f82
PE
7947 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7948
84acfcf0
PE
7949 Don't assume time_t can fit into int.
7950 * buffer.h (struct buffer.modtime): Now time_t, not int.
7951 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7952 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7953
ccd9a01a
PE
7954 Minor fixes for signed vs unsigned integers.
7955 * character.h (MAYBE_UNIFY_CHAR):
7956 * charset.c (maybe_unify_char):
7957 * keyboard.c (read_char, reorder_modifiers):
7958 XINT -> XFASTINT, since the integer must be nonnegative.
7959 * ftfont.c (ftfont_spec_pattern):
7960 * keymap.c (access_keymap, silly_event_symbol_error):
7961 XUINT -> XFASTINT, since the integer must be nonnegative.
7962 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7963 since it makes no difference and we prefer signed.
7964 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7965 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7966 nonnegative.
7967
d6d100dd
SM
79682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7969
7970 * window.h (Fwindow_frame): Declare.
7971
2b6148e4
PE
79722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7973
7974 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7975 (SPARE_MEMORY): Always define.
7976 (LARGE_REQUEST): Remove.
7977 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7978
f230ecc9
MR
79792011-06-06 Martin Rudalics <rudalics@gmx.at>
7980
727e958e
MR
7981 * lisp.h: Move EXFUNS for Fframe_root_window,
7982 Fframe_first_window and Fset_frame_selected_window to window.h.
7983
7984 * window.h: Move EXFUNS for Fframe_root_window,
7985 Fframe_first_window and Fset_frame_selected_window here from
7986 lisp.h.
7987
7988 * frame.c (Fwindow_frame, Fframe_first_window)
7989 (Fframe_root_window, Fframe_selected_window)
7990 (Fset_frame_selected_window): Move to window.c.
7991 (Factive_minibuffer_window): Move to minibuf.c.
7992 (Fother_visible_frames_p): New function.
7993
7994 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7995
f230ecc9
MR
7996 * window.c (decode_window, decode_any_window): Move up in code.
7997 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7998 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7999 (Fwindow_buffer): Move up and rewrite doc-string.
8000 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8001 (Fwindow_prev): New functions.
727e958e
MR
8002 (Fwindow_frame): Move here from frame.c. Accept any window as
8003 argument.
8004 (Fframe_root_window, Fframe_first_window)
8005 (Fframe_selected_window): Move here from frame.c. Accept frame
8006 or arbitrary window as argument. Update doc-strings.
8007 (Fminibuffer_window): Move up in code.
8008 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8009 (Fset_frame_selected_window): Move here from frame.c.
8010 Marginal rewrite.
727e958e
MR
8011 (Fselected_window, select_window, Fselect_window): Move up in
8012 code. Minor doc-string fixes.
f230ecc9 8013
4d09bcf6
PE
80142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8015
8016 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8017 Do not assume that spare memory exists; that assumption is valid
8018 only if SYSTEM_MALLOC.
8019 (LARGE_REQUEST): New macro, so that the issue of large requests
8020 is separated from the issue of spare memory.
8021
810928a2
AS
80222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8023
172418ad
AS
8024 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8025 format. (Bug#8806)
8026
43f862f7
AS
8027 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8028
810928a2
AS
8029 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8030 before statements.
8031
a059fe24
JD
80322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8033
8034 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8035
8036 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8037
8038 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8039 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8040
989bf368
JB
80412011-06-05 Juanma Barranquero <lekktu@gmail.com>
8042
8043 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8044
4b80f674
CY
80452011-06-04 Chong Yidong <cyd@stupidchicken.com>
8046
8047 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8048 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8049 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8050 New error handlers.
4b80f674
CY
8051 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8052 Obey Vx_select_enable_clipboard_manager. Catch errors in
8053 x_clipboard_manager_save (Bug#8779).
8054 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8055 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8056
99a33b77 80572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8058
8059 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8060
99a33b77 80612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8062
8063 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8064 in the current matrix if keep_current_p is non-zero.
8065
8264569d
EZ
80662011-06-04 Eli Zaretskii <eliz@gnu.org>
8067
8068 * bidi.c (bidi_level_of_next_char): Fix last change.
8069
57f97249
EZ
80702011-06-03 Eli Zaretskii <eliz@gnu.org>
8071
fec2107c 8072 Support bidi reordering of text covered by display properties.
57f97249 8073
fec2107c
EZ
8074 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8075 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8076 (bidi_cache_search, bidi_cache_iterator_state)
8077 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8078 (bidi_level_of_next_char, bidi_move_to_visually_next):
8079 Support character positions inside a run of characters covered by a
fec2107c
EZ
8080 display string.
8081 (bidi_paragraph_init, bidi_resolve_explicit_1)
8082 (bidi_level_of_next_char): Call bidi_fetch_char and
8083 bidi_fetch_char_advance instead of FETCH_CHAR and
8084 FETCH_CHAR_ADVANCE.
8085 (bidi_init_it): Initialize new members.
8086 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8087 definitions.
8088 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8089 instead of using explicit *_CHAR codes.
d6d100dd
SM
8090 (bidi_resolve_explicit, bidi_resolve_weak):
8091 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8092 bidirectional text is supported only in multibyte buffers.
8093 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8094 it to initialize the frame_window_p member of struct bidi_it.
8095 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8096 (bidi_resolve_explicit, bidi_resolve_weak)
8097 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8098 bidi_it->nchars is non-positive.
8099 (bidi_level_of_next_char): Don't try to lookup the cache for the
8100 next/previous character if nothing is cached there yet, or if we
8101 were just reseat()'ed to a new position.
c40e2fb2 8102
0e14fe90
EZ
8103 * xdisp.c (set_cursor_from_row): Set start and stop points
8104 according to the row's direction when priming the loop that looks
8105 for the glyph on which to display cursor.
8106 (single_display_spec_intangible_p): Function deleted.
8107 (display_prop_intangible_p): Reimplement to call
8108 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8109 Accept 3 additional arguments needed by handle_display_spec.
8110 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8111 values: lists, `(when COND...)' forms, etc.
8112 (single_display_spec_string_p): Support property values that are
8113 lists with the argument STRING its top-level element.
8114 (display_prop_string_p): Fix the condition for processing a
8115 property that is a list to be consistent with handle_display_spec.
fec2107c 8116 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8117 last portion of handle_display_prop.
8118 (compute_display_string_pos): Accept additional argument
8119 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8120 value of a `display' property is a "replacing spec".
8121 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8122 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8123 the display property, but just return a value indicating whether
8124 the display property will replace the characters it covers.
8125 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8126 frame_window_p members of struct bidi_it.
d6d100dd
SM
8127 (compute_display_string_pos, compute_display_string_end):
8128 New functions.
fec2107c
EZ
8129 (push_it): Accept second argument POSITION, where pop_it should
8130 jump to continue iteration.
8131 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8132
fec2107c
EZ
8133 * keyboard.c (adjust_point_for_property): Adjust the call to
8134 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8135
8136 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8137 (bidi_init_it): Update prototypes.
8138 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8139 (compute_display_string_pos, compute_display_string_end):
8140 Declare prototypes.
fec2107c
EZ
8141 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8142 EMACS_INT.
fc6f18ce 8143
40087514 81442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8145
57f53182
PE
8146 Malloc failure behavior now depends on size of allocation.
8147 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8148 * lisp.h: Change signatures accordingly.
8149 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8150 All callers changed. (Bug#8762)
8151
8152 * gnutls.c: Use Emacs's memory allocators.
8153 Without this change, the gnutls library would invoke malloc etc.
8154 directly, which causes problems on non-SYNC_INPUT hosts, and which
8155 runs afoul of improving memory_full behavior. (Bug#8761)
8156 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8157 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8158 xfree instead of the default malloc, realloc, free.
8159 (Fgnutls_boot): No need to check for memory allocation failure,
8160 since xmalloc does that for us.
8161
ac32cd99 8162 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8163 * category.c (hash_get_category_set):
8164 * ccl.c (ccl_driver):
8165 * charset.c (Fdefine_charset_internal):
8166 * charset.h (struct charset.hash_index):
8167 * composite.c (get_composition_id, gstring_lookup_cache)
8168 (composition_gstring_put_cache):
8169 * composite.h (struct composition.hash_index):
8170 * dispextern.h (struct image.hash):
8171 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8172 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8173 (hashfn_equal, hashfn_user_defined, make_hash_table)
8174 (maybe_resize_hash_table, hash_lookup, hash_put)
8175 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8176 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8177 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8178 * image.c (make_image, search_image_cache, lookup_image)
8179 (xpm_put_color_table_h):
8180 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8181 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8182 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8183 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8184 * alloc.c (allocate_vectorlike):
8185 Check for overflow in vector size calculations.
8186 * ccl.c (ccl_driver):
8187 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8188 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8189 need to be updated by these changes.
40087514
PE
8190 * fns.c (make_hash_table, maybe_resize_hash_table):
8191 Check for integer overflow with large hash tables.
0de4bb68
PE
8192 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8193 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8194 (SXHASH_REDUCE): New macro.
8195 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8196 Use it instead of discarding useful hash info with large hash values.
8197 (sxhash_float): New function.
8198 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8199 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8200 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8201 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8202 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8203 Adjust signatures to match updated version of code.
8204 (consing_since_gc): Now EMACS_INT, since a single hash table can
8205 use more than INT_MAX bytes.
8206
698d32e2
DN
82072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8208
8209 Make it possible to build with GCC-4.6+ -O2 -flto.
8210
8211 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8212
fd6fa53f
SM
82132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8214
8215 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8216 Call minibuffer-inactive-mode.
8217
864db017
JB
82182011-05-31 Juanma Barranquero <lekktu@gmail.com>
8219
8220 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8221 Update dependencies.
8222
2ad0baf4
DN
82232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8224
8225 * data.c (init_data): Remove code for UTS, this system is not
8226 supported anymore.
8227
4fcc2638
DN
82282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8229
8230 Don't force ./temacs to start in terminal mode.
8231
8232 * frame.c (make_initial_frame): Initialize faces in all cases, not
8233 only when CANNOT_DUMP is defined.
8234 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8235
c56e0fd5
DN
82362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8237
8238 * dispnew.c (add_window_display_history): Use const for the string
8239 pointer. Remove declaration, not needed.
8240
333d54da 82412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8242
55d4c1b2 8243 Use 'inline', not 'INLINE'.
333d54da 8244 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8245 * alloc.c, fontset.c (INLINE): Remove.
8246 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8247 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8248 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8249 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8250 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8251
738db178
DN
82522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8253
8254 Make it possible to run ./temacs.
8255
8256 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8257 syms_of_callproc does the same thing. Remove test for
8258 "initialized", do it in the caller.
8259 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8260
620c53a6
SM
82612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8262
8263 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8264 (read_minibuf): Use get_minibuffer.
8265 (syms_of_minibuf): Use DEFSYM.
8266 (Qmetadata): New var.
8267 * data.c (Qbuffer): Don't make it static.
8268 (syms_of_data): Use DEFSYM.
8269
e003a292
PE
82702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8271
8272 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8273 (CCL_CODE_MIN): New macro.
8274
ed008a6d
PE
82752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8276
3687c2ef
PE
8277 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8278
ed008a6d
PE
8279 * eval.c (Qdebug): Now static.
8280 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8281 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8282 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8283
d66c4c7c
CY
82842011-05-29 Chong Yidong <cyd@stupidchicken.com>
8285
8286 * image.c: Various fixes to ImageMagick code comments.
8287 (Fimagemagick_types): Doc fix.
8288
5fbc2025
PE
82892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8290
0196f88a
PE
8291 Minor fixes prompted by GCC 4.6.0 warnings.
8292
8293 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8294
5fbc2025
PE
8295 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8296 (x_clipboard_manager_save_all): Move extern decl to ...
8297 * xterm.h: ... here, so that it can be checked for consistency.
8298
1dd3c2d9
CY
82992011-05-29 Chong Yidong <cyd@stupidchicken.com>
8300
8301 * xselect.c (x_clipboard_manager_save_frame)
8302 (x_clipboard_manager_save_all): New functions.
8303 (Fx_clipboard_manager_save): Lisp function deleted.
8304
8305 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8306 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8307
8308 * xterm.h: Update prototype.
8309
5ba6571d
WX
83102011-05-28 William Xu <william.xwl@gmail.com>
8311
8312 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8313 exiting (Bug#8239).
8314
3eaff834
JM
83152011-05-28 Jim Meyering <meyering@redhat.com>
8316
e1900994 8317 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8318 * fns.c (to_uchar): Define.
8319 (crypto_hash_function): Use it to convert some newly-signed
8320 variables to unsigned, to avoid sign-extension bugs. For example,
8321 without this change, (md5 "truc") would evaluate to
8322 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8323 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8324 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8325
0f6990a7
PE
83262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8327
8328 Integer overflow fixes.
c8a9ca5a 8329
08686060
PE
8330 * dbusbind.c: Serial number integer overflow fixes.
8331 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8332 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8333 to hold a serial number that is too large for a fixnum.
8334 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8335 Check for serial numbers out of range. Decode any serial number
59568bf0 8336 that was so large that it became a float. (Bug#8722)
08686060 8337
2d1fc3c7
PE
8338 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8339 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8340 Use XFASTINT rather than XUINT when numbers are nonnegative.
8341 (xd_append_arg, Fdbus_method_return_internal):
8342 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8343 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8344 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8345 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8346 (Bug#8722)
2d1fc3c7 8347
c8a9ca5a
PE
8348 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8349
519e1d69
PE
8350 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8351
6df6ae42 8352 ccl: Add integer overflow checks.
30569699
PE
8353 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8354 (IN_INT_RANGE): New macros.
8355 (ccl_driver): Use them to check for integer overflow when
8356 decoding a CCL program. Many of the new checks are whether XINT (x)
8357 fits in int; it doesn't always, on 64-bit hosts. The new version
8358 doesn't catch all possible integer overflows, but it's an
847044ea 8359 improvement. (Bug#8719)
30569699 8360
c11285dc
PE
8361 * alloc.c (make_event_array): Use XINT, not XUINT.
8362 There's no need for unsigned here.
8363
fdccd48e
PE
8364 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8365 This follows up to the 2011-05-06 change that substituted uintptr_t
8366 for EMACS_INT. This case wasn't caught back then.
8367
37910ab2
PE
8368 Rework Fformat to avoid integer overflow issues.
8369 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8370 now (part of C89). Include <verify.h>.
8371 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8372 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8373 (Fformat): Avoid the prepass trying to compute sizes; it was only
8374 approximate and thus did not catch overflow reliably. Instead, walk
8375 through the format just once, formatting and computing sizes as we go,
8376 checking for integer overflow at every step, and allocating a larger
8377 buffer as needed. Keep track separately whether the format is
8378 multibyte. Keep only the most-recently calculated precision, rather
8379 than them all. Record whether each argument has been converted to
8380 string. Use EMACS_INT, not int, for byte and char and arg counts.
8381 Support field widths and precisions larger than INT_MAX. Avoid
8382 sprintf's undefined behavior with conversion specifications such as %#d
8383 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8384 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8385 formatting out-of-range floating point numbers with int
9173deec 8386 formats. (Bug#8668)
37910ab2 8387
2e6578fb
PE
8388 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8389
0ae6bdee
PE
8390 * data.c: Avoid integer truncation in expressions involving floats.
8391 * data.c: Include <intprops.h>.
8392 (arith_driver): When there's an integer overflow in an expression
8393 involving floating point, convert the integers to floating point
8394 so that the resulting value does not suffer from catastrophic
8395 integer truncation. For example, on a 64-bit host (* 4
8396 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8397 Do not rely on undefined behavior after integer overflow.
8398
de883a70
PE
8399 merge count_size_as_multibyte, parse_str_to_multibyte
8400 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8401 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8402 Check for integer overflow.
8403 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8404 since it's now a duplicate of the other. This is more of
8405 a character than a buffer op, so better that it's in character.c.
8406 * fns.c, print.c: Adjust to above changes.
8407
2ff916cb
PE
84082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8409
8410 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8411
f1b54466
PE
84122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8413
fb1ac845
PE
8414 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8415 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8416 (x_clipboard_manager_save): Now static.
8417 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8418
f1b54466
PE
8419 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8420 (crypto_hash_function): Now static.
8421 Fix pointer signedness problems. Avoid unnecessary initializations.
8422
a9f737ee
CY
84232011-05-27 Chong Yidong <cyd@stupidchicken.com>
8424
8425 * termhooks.h (Vselection_alist): Make it terminal-local.
8426
8427 * terminal.c (create_terminal): Initialize it.
8428
8429 * xselect.c: Support for clipboard managers.
8430 (Vselection_alist): Move to termhooks.h as terminal-local var.
8431 (LOCAL_SELECTION): New macro.
8432 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8433 (symbol_to_x_atom): Remove gratuitous arg.
8434 (x_handle_selection_request, lisp_data_to_selection_data)
8435 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8436 (x_own_selection, x_get_local_selection, x_convert_selection):
8437 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8438 (some_frame_on_display): Delete unused function.
8439 (Fx_own_selection_internal, Fx_get_selection_internal)
8440 (Fx_disown_selection_internal, Fx_selection_owner_p)
8441 (Fx_selection_exists_p): New optional frame arg.
8442 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8443 (x_handle_selection_clear): Don't treat other terminals with the
8444 same keyboard specially. Use the terminal-local Vselection_alist.
8445 (x_clear_frame_selections): Use Frun_hook_with_args.
8446
8447 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8448
8449 * xterm.h: Add support for those atoms.
8450
e067f0c1
CY
84512011-05-26 Chong Yidong <cyd@stupidchicken.com>
8452
8453 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8454 (converted_selections, conversion_fail_tag): New global variables.
8455 (x_selection_request_lisp_error): Free the above.
8456 (x_get_local_selection): Remove unnecessary code.
8457 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8458 of converted selections stored in converted_selections.
8459 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8460 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8461 (x_convert_selection): New function.
8462 (x_handle_selection_event): Simplify.
8463 (x_get_foreign_selection): Don't ignore incoming requests while
8464 waiting for an answer; this will fail when we implement
8465 SAVE_TARGETS, and seems unnecessary anyway.
8466 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8467 (Vx_sent_selection_functions): Doc fix.
8468
0f4aebc0
LL
84692011-05-26 Leo Liu <sdl.web@gmail.com>
8470
8471 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8472
e61124cd
YM
84732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8474
8475 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8476
8477 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8478 for fringe update if it has periodic bitmap.
ac389d0c 8479 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8480 and fringe_bitmap_periodic_p.
8481
8482 * fringe.c (get_fringe_bitmap_data): New function.
8483 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8484 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8485 row. Mark glyph row for fringe update if periodicity changed.
8486
8487 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8488 for fringe update unless it has periodic bitmap.
8489
f16d9837
KH
84902011-05-25 Kenichi Handa <handa@m17n.org>
8491
8492 * xdisp.c (get_next_display_element): Set correct it->face_id for
8493 a static composition.
8494
e1b90ef6
LL
84952011-05-24 Leo Liu <sdl.web@gmail.com>
8496
8497 * deps.mk (fns.o):
8498 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8499
8500 * fns.c (crypto_hash_function, Fsha1): New function.
8501 (Fmd5): Use crypto_hash_function.
8502 (syms_of_fns): Add Ssha1.
8503
7400048f
PE
85042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8505
8506 * gnutls.c: Remove unused macros.
8507 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8508 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8509 Remove macros that are defined and never used.
8510 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8511
abb71cf4
CY
85122011-05-22 Chong Yidong <cyd@stupidchicken.com>
8513
8514 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8515 (Fx_get_selection_internal): Minor cleanup.
8516 (Fx_own_selection_internal): Rename arguments for consistency with
8517 select.el.
8518
6307db39
PE
85192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8520
8521 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8522
f3d4e0a4
CY
85232011-05-22 Chong Yidong <cyd@stupidchicken.com>
8524
8525 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8526
4d8ade89
YM
85272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8528
8529 * dispnew.c (scrolling_window): Don't exclude the case that the
8530 last enabled row in the desired matrix touches the bottom boundary.
8531
32078c8d
GM
85322011-05-21 Glenn Morris <rgm@gnu.org>
8533
8534 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8535 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8536 and add some more files.
32078c8d 8537
7285dc67
EZ
85382011-05-20 Eli Zaretskii <eliz@gnu.org>
8539
8540 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8541 report_file_error introduced by the change from 2011-05-07.
8542
89d1bd22
PE
85432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8544
8545 * systime.h (Time): Define only if emacs is defined.
8546 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8547 where the include path doesn't have X11/X.h by default. See
8548 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8549
cd394be1 85502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8551
8552 * composite.c (find_automatic_composition): Fix previous change.
8553
b9704ad9
GM
85542011-05-20 Glenn Morris <rgm@gnu.org>
8555
8556 * lisp.mk: New file, split from Makefile.in.
8557 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8558 (shortlisp): Remove.
8559 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8560
4a720484
GM
85612011-05-19 Glenn Morris <rgm@gnu.org>
8562
8563 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8564 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8565 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8566 (lisp): Set the order to that of loadup.el.
8567 (shortlisp): Make it a copy of $lisp.
8568 (SOME_MACHINE_LISP): Remove.
8569 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8570 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8571
a28d4396
KH
85722011-05-18 Kenichi Handa <handa@m17n.org>
8573
8574 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8575 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8576 (find_automatic_composition): Mostly rewrite for efficiency.
8577
a2b1fa8e
JB
85782011-05-18 Juanma Barranquero <lekktu@gmail.com>
8579
8580 * makefile.w32-in: Update dependencies.
8581
8e1f5610
CS
85822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8583
8584 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8585 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8586
7025ee00 85872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8588
cdfa6eab
PE
8589 Fix some integer overflow issues, such as string length overflow.
8590
06d6db33
PE
8591 * insdel.c (count_size_as_multibyte): Check for string overflow.
8592
2b4560a8
PE
8593 * character.c (lisp_string_width): Check for string overflow.
8594 Use EMACS_INT, not int, for string indexes and lengths; in
8595 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8596 the resulting string length overflows an EMACS_INT; instead,
8597 report a string overflow if no precision given. When checking for
8598 precision exhaustion, use a check that cannot possibly have
8599 integer overflow. (Bug#8675)
8600 * character.h (lisp_string_width): Adjust to new signature.
8601
cb93f9be
PE
8602 * alloc.c (string_overflow): New function.
8603 (Fmake_string): Use it. This doesn't change behavior, but saves
8604 a few bytes and will simplify future changes.
8605 * character.c (string_escape_byte8): Likewise.
8606 * lisp.h (string_overflow): New decl.
8607
1a1f3366
PE
8608 Fixups, following up to the user-interface timestamp change.
8609 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8610 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8611 * msdos.c (mouse_get_pos): Likewise.
8612 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8613 * w32gui.h (Time): Define by including "systime.h" rather than by
8614 declaring it ourselves. (Bug#8664)
8615
d4e3e4d3
PE
8616 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8617 * image.c (clear_image_cache): Likewise.
8618
f6a24d19
PE
8619 * term.c (term_mouse_position): Don't assume time_t wraparound.
8620
08dc5ae6
PE
8621 Be more systematic about user-interface timestamps.
8622 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8623 and sometimes 'EMACS_UINT', to represent these timestamps.
8624 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8625 This makes the code easier to follow, and makes it easier to catch
8626 integer overflow bugs such as Bug#8664.
8627 * frame.c (Fmouse_position, Fmouse_pixel_position):
8628 Use Time, not unsigned long, for user-interface timestamps.
8629 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8630 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8631 * keyboard.h (last_event_timestamp): Likewise.
8632 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8633 * menu.h (xmenu_show): Likewise.
8634 * term.c (term_mouse_position): Likewise.
8635 * termhooks.h (struct input_event.timestamp): Likewise.
8636 (struct terminal.mouse_position_hook): Likewise.
8637 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8638 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8639 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8640 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8641 what it was before.
8642 * menu.h, termhooks.h: Include "systime.h", for Time.
8643
8e55734a
PE
8644 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8645 Don't assume that the difference between two unsigned long values
8646 can fit into an integer. At this point, we know button_down_time
8647 <= event->timestamp, so the difference must be nonnegative, so
8648 there's no need to cast the result if double-click-time is
8649 nonnegative, as it should be; check that it's nonnegative, just in
8650 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8651 apart (about 25 days). (Bug#8664)
8e55734a 8652
841f1b75 8653 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8654 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8655
3e26f69c
PE
8656 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8657 that always fit in int. Use a sentinel instead of a counter, to
8658 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8659 * frame.h (struct frame): Use int for menu_bar_items_used
8660 instead of EMACS_INT, since it always fits in int.
3e26f69c 8661
5cc152c0
PE
8662 * menu.c (grow_menu_items): Check for int overflow.
8663
d89eb65e
PE
8664 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8665
5235bd3e
PE
8666 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8667 Before, the code was not consistent. These values cannot exceed
8668 2**31 - 1 so there's no need to make them unsigned.
8669 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8670 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8671 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8672 as modifiers.
8673 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8674
bc827e23
PE
8675 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8676 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8677 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8678 presumably because the widths might not match.
8679
78eb494e
PE
8680 * window.c (size_window): Avoid needless test at loop start.
8681
04f2d78b
CB
86822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8683
8684 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8685
d2fc7e3d 86862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8687
8688 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8689
d2fc7e3d 86902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8691
8692 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8693 `width' to `bar_area_x' and `bar_area_width', respectively.
8694 (x_scroll_run): Take account of fringe background extension.
8695
04f2d78b
CB
8696 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8697 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8698 `bar_area_width', respectively.
8699 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8700 background extension.
8701
79b70037
GM
87022011-05-10 Jim Meyering <meyering@redhat.com>
8703
8704 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8705
2f142cc5
JB
87062011-05-10 Juanma Barranquero <lekktu@gmail.com>
8707
8708 * image.c (Finit_image_library): Return t for built-in image types,
8709 like pbm and xbm. (Bug#8640)
8710
57679c86
AS
87112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8712
8713 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8714
888c9e86
EZ
87152011-05-07 Eli Zaretskii <eliz@gnu.org>
8716
b0512a1d
EZ
8717 * w32console.c (Fset_screen_color): Doc fix.
8718 (Fget_screen_color): New function.
8719 (syms_of_ntterm): Defsubr it.
8720
7285dc67
EZ
8721 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8722 unlink the temporary file if Fcall_process didn't create it in the
8723 first place.
8724 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8725 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8726 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8727 cue to call_process_cleanup not to close that handle.
8728
4d3fcc8e
BK
87292011-05-07 Ben Key <bkey76@gmail.com>
8730
8731 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8732 one of two shell specific rules, either bootstrap-temacs-CMD or
8733 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8734 to the previous implementation of the bootstrap-temacs rule.
8735 The bootstrap-temacs-CMD rule is similar to the previous
8736 implementation of the bootstrap-temacs rule except that it
8737 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8738 variable.
8739
8740 These changes, along with some changes to nt/configure.bat,
8741 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8742 earlier fix to add support for --cflags and --ldflags options
8743 that include quotes so that it works whether make uses cmd or
8744 sh as the shell.
8745
b4289b64
MA
87462011-05-06 Michael Albinus <michael.albinus@gmx.de>
8747
8748 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8749 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8750 is a constant.
8751 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8752 a string. Handle both cases.
8753 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8754 (Fdbus_register_method): Use Qinvalid_function.
8755
af4c0e28
JB
87562011-05-06 Juanma Barranquero <lekktu@gmail.com>
8757
8758 * makefile.w32-in: Update dependencies.
8759 (LISP_H): Add inttypes.h and stdin.h.
8760 (PROCESS_H): Add unistd.h.
8761
c51453d9
EZ
87622011-05-06 Eli Zaretskii <eliz@gnu.org>
8763
8764 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8765 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8766
8ff0ac3c 87672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8768
4c4b566b
PE
8769 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8770
aab2b9b5
PE
8771 * term.c (vfatal): Remove stray call to va_end.
8772 It's not needed and the C Standard doesn't allow it here anyway.
8773
c378da0b
PE
8774 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8775 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8776
288b08c7
PE
8777 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8778 bytes.
8779
e3601888
PE
8780 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8781
db6c0e74
PE
8782 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8783
dd5963ea
PE
8784 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8785
88c9450f
PE
8786 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8787
2f9442b8
PE
8788 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8789
c032b5f8
PE
8790 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8791 * charset.c (Fdefine_charset_internal): Don't initialize
8792 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8793 32-bit int (Bug#8600).
a108c10b
PE
8794
8795 * lread.c (read_integer): Be more consistent with string-to-number.
8796 Use string_to_number to do the actual conversion; this avoids
8797 rounding errors and fixes some other screwups. Without this fix,
8798 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8799 (digit_to_number): Move earlier, for benefit of read_integer.
8800 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8801 not a digit in any supported base. (Bug#8602)
a108c10b 8802
ad5f9eea
PE
8803 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8804
aec1708a
PE
8805 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8806 to match comment at start of function. This also removes a
8807 GCC warning about overflow in a 32+64-bit port.
8808
47be4ab5
PE
8809 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8810
371cac43
PE
8811 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8812 Reported by Stefan Monnier in
8813 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8814 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8815 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8816
d01a7826
PE
8817 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8818 (EMACS_UINTPTR): Likewise, with uintptr_t.
8819
7fd47d5c
PE
8820 * lisp.h: Prefer 64-bit EMACS_INT if available.
8821 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8822 on 32-bit hosts that have 64-bit int, so that they can access
8823 large files.
122b0c86
PE
8824 However, temporarily disable this change unless the temporary
8825 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8826
8727937b
PE
8827 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8828
8ac068ac
PE
8829 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8830 This removes an assumption that EMACS_INT and long are the same
8831 width as pointers. The assumption is true for Emacs porting targets
8832 now, but we want to make other targets possible.
8833 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8834 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8835 In the rest of the code, change types of integers that hold casted
8836 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8837 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8838 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8839 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8840 No need to cast type when ORing.
8841 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8842 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8843 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8844 assume EMACS_INT is the same width as char *.
8845 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8846 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8847 Remove no-longer-needed casts.
8848 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8849 (xg_tool_bar_help_callback, xg_make_tool_item):
8850 Use EMACS_INTPTR to hold an integer
8851 that will be cast to void *; this can avoid a GCC warning
8852 if EMACS_INT is not the same width as void *.
8853 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8854 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8855 (current_message_1, set_message_1):
8856 Use a local to convert to proper width without a cast.
8857 * xmenu.c (dialog_selection_callback): Likewise.
8858
ede49d71
PE
8859 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8860 Also, don't assume VALBITS / RAND_BITS is less than 5,
8861 and don't rely on undefined behavior when shifting a 1 left into
8862 the sign bit.
8863 * lisp.h (get_random): Change signature to match.
8864
2f30ecd0
PE
8865 * lread.c (hash_string): Use size_t, not int, for hash computation.
8866 Normally we prefer signed values; but hashing is special, because
8867 it's better to use unsigned division on hash table sizes so that
8868 the remainder is nonnegative. Also, size_t is the natural width
8869 for hashing into memory. The previous code used 'int', which doesn't
8870 retain enough info to hash well into very large tables.
8871 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8872
2a866e7b
PE
8873 * dbusbind.c: Don't possibly lose pointer info when converting.
8874 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8875 Use XPNTR rather than XHASH, so that the high-order bits of
8876 the pointer aren't lost when converting through void *.
8877
51639eac
PE
8878 * eval.c (Fautoload): Don't double-shift a pointer.
8879
92394119
PE
8880 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8881
dbdb9a7c
JB
88822011-05-06 Juanma Barranquero <lekktu@gmail.com>
8883
8884 * gnutls.c (DEF_GNUTLS_FN):
8885 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8886
db7a0b4f
AS
88872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8888
8889 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8890 marker. (Bug#8610)
8891
cd394be1 88922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8893
8894 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8895 New version that can reserve upto 2GB of heap space.
8896
f7ff1b0f 88972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8898
8899 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8900
639c109b
TZ
89012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8902
8903 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8904 `gnutls_certificate_set_x509_key_file'.
8905
d2127135
JB
89062011-05-05 Juanma Barranquero <lekktu@gmail.com>
8907
8908 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8909 Update dependencies.
8910
e968f4f3
JB
89112011-05-04 Juanma Barranquero <lekktu@gmail.com>
8912
8913 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8914 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8915 Remove unused parameter `fildes'.
8916 * process.c (read_process_output, send_process): Don't pass it.
8917
84d358f0
JB
89182011-05-04 Juanma Barranquero <lekktu@gmail.com>
8919
8920 Fix previous change: the library cache is defined in w32.c.
8921 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8922 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8923
0898ca10
JB
89242011-05-04 Juanma Barranquero <lekktu@gmail.com>
8925
8926 Implement dynamic loading of GnuTLS on Windows.
8927
8928 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8929 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8930 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8931 Declare.
8932
8933 * gnutls.c (Qgnutls_dll): Define.
8934 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8935 (gnutls_*): Declare function pointers.
8936 (init_gnutls_functions): New function to initialize function pointers.
8937 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8938 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8939 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8940 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8941 (emacs_gnutls_write, emacs_gnutls_read)
8942 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8943 (Fgnutls_available_p): New function.
8944 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8945 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8946 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8947
8948 * image.c: Include w32.h.
8949 (Vimage_type_cache): Delete.
8950 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8951 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8952 (w32_delayed_load): Move to w32.c.
8953
8954 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8955
8956 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8957 (w32_delayed_load): Move from image.c. When loading a library, record
8958 its filename in the :loaded-from property of the library id.
8959 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8960 Initialize and staticpro them.
8961 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8962
8963 * process.c: Include lisp.h before w32.h, not after.
8964 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8965 instead of gnutls_record_check_pending.
8966
8967 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8968
ff4de4aa
TZ
89692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8970
8971 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8972 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8973 as passed in.
8974
abe95abb
JD
89752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8976
8977 * xterm.c (x_set_frame_alpha): Do not set property on anything
8978 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8979
e16e55d4
JB
89802011-05-02 Juanma Barranquero <lekktu@gmail.com>
8981
8982 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8983
bafcf6a5
JB
89842011-05-02 Juanma Barranquero <lekktu@gmail.com>
8985
8986 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8987 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8988 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8989 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8990 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8991 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8992 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8993 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8994 (Qgnutls_bootprop_callbacks_verify): Make static.
8995
e7a6747f
AS
89962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8997
19ed11ba
AS
8998 * callproc.c: Indentation fixup.
8999
e7a6747f 9000 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9001 (wait_for_termination, interruptible_wait_for_termination):
9002 Move after wait_for_termination_1.
e7a6747f 9003
1ef14cb4
LMI
90042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9005
9006 * sysdep.c (interruptible_wait_for_termination): New function
9007 which is like wait_for_termination, but allows keyboard
9008 interruptions.
9009
9010 * callproc.c (Fcall_process): Add (:file "file") as an option for
9011 the STDOUT buffer.
9012 (Fcall_process_region): Ditto.
9013
330d880c
EZ
90142011-04-30 Eli Zaretskii <eliz@gnu.org>
9015
8db90b73
EZ
9016 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9017 rather than `XVECTOR (FOO)->size'.
9018
330d880c
EZ
9019 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9020 inttypes.h, as a gnulib replacement is used if it not available in
9021 system headers.
9022
15cbd324
EZ
90232011-04-21 Eli Zaretskii <eliz@gnu.org>
9024
9025 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9026 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9027 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9028
9029 * coding.c (coding_alloc_by_realloc): Error out if destination
9030 will grow beyond MOST_POSITIVE_FIXNUM.
9031 (decode_coding_emacs_mule): Abort if there isn't enough place in
9032 charbuf for the composition carryover bytes. Reserve an extra
9033 space for up to 2 characters produced in a loop.
9034 (decode_coding_iso_2022): Abort if there isn't enough place in
9035 charbuf for the composition carryover bytes.
9036
90372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9038
ae940cca
EZ
9039 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9040 aborting when %lld or %lll format is passed.
9041 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9042 %llo or %llx format is passed. (Bug#8545)
9043
03ab8921
EZ
9044 * window.c (window_scroll_line_based): Use a marker instead of
9045 simple variables to record original value of point. (Bug#7952)
9046
afda1437
EZ
9047 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9048 produced by %s or %c overflows available buffer space. (Bug#8545)
9049
f76dee0c
PE
90502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9051
9052 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9053 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9054
fdc5744d
JB
90552011-04-28 Juanma Barranquero <lekktu@gmail.com>
9056
9057 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9058
638f053a
JB
90592011-04-28 Juanma Barranquero <lekktu@gmail.com>
9060
9061 * keyboard.c (Qdelayed_warnings_hook): Define.
9062 (command_loop_1): Run `delayed-warnings-hook'
9063 if Vdelayed_warnings_list is non-nil.
9064 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9065 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9066
d178f871
EZ
90672011-04-28 Eli Zaretskii <eliz@gnu.org>
9068
9069 * doprnt.c (doprnt): Don't return value smaller than the buffer
9070 size if the message was truncated. (Bug#8545).
9071
b124fd93
JB
90722011-04-28 Juanma Barranquero <lekktu@gmail.com>
9073
9074 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9075 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9076
e810457d
PE
90772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9078
9079 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9080
ea51cceb
JB
90812011-04-27 Juanma Barranquero <lekktu@gmail.com>
9082
9083 * makefile.w32-in: Update dependencies.
9084
94dcfacf
EZ
90852011-04-27 Eli Zaretskii <eliz@gnu.org>
9086
9087 Improve `doprnt' and its usage. (Bug#8545)
9088 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9089 `format_end'. Remove support for %l as a conversion specifier.
9090 Don't use xrealloc. Improve diagnostics when the %l size modifier
9091 is used. Update the commentary.
9092
9093 * eval.c (verror): Simplify calculation of size_t.
9094
9095 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9096 messages.
9097
f61f41d7
PE
90982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9099
9100 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9101 change.
9102
96fb4434
PE
91032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9104
9105 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9106 This makes this file independent of the recent pseudovector change.
9107
671875da 91082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9109
69e9b5a3
PE
9110 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9111
b5f869a7 9112 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9113 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9114 Remove unused local.
c8926152 9115 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9116
841a1577 9117 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9118 GCC 4.6.0 optimizes based on type-based alias analysis.
9119 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9120 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9121 != &v->size, and therefore "v->size = 1; b->size = 2; return
9122 v->size;" must therefore return 1. This assumption is incorrect
9123 for Emacs, since it type-puns struct Lisp_Vector * with many other
9124 types. To fix this problem, this patch adds a new type struct
f904488f 9125 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9126 and pseudovectors, and helps optimizing compilers not get fooled
9127 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9128 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9129 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9130 the size member.
eab3844f
PE
9131 (XSETPVECTYPE): Rewrite in terms of new macro.
9132 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9133 This is a bit clearer, and further avoids the possibility of
9134 undesirable aliasing.
9135 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9136 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9137 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9138 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9139 (ASIZE): Now uses header.size rather than size.
9140 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9141 to avoid the hassle of writing XVECTOR (foo)->header.size.
9142 (struct vectorlike_header): New type.
eab3844f
PE
9143 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9144 object, to help avoid aliasing.
9145 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9146 (SUBRP): Likewise, since Lisp_Subr is a special case.
9147 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9148 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9149 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9150 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9151 changed to be "header.size" and "header.next".
9152 * buffer.h (struct buffer): Likewise.
9153 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9154 * frame.h (struct frame): Likewise.
9155 * process.h (struct Lisp_Process): Likewise.
9156 * termhooks.h (struct terminal): Likewise.
9157 * window.c (struct save_window_data, struct saved_window): Likewise.
9158 * window.h (struct window): Likewise.
9159 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9160 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9161 * buffer.c (init_buffer_once): Likewise.
9162 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9163 special case.
9164 * process.c (Fformat_network_address): Use local var for size,
9165 for brevity.
9166
0df1eac5
PE
9167 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9168
847ab9d1 9169 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9170 * data.c (atof): Remove decl; no longer used or needed.
9171 (digit_to_number): Move to lread.c.
9172 (Fstring_to_number): Use new string_to_number function, to be
9173 consistent with how the Lisp reader treats infinities and NaNs.
9174 Do not assume that floating-point numbers represent EMACS_INT
9175 without losing information; this is not true on most 64-bit hosts.
9176 Avoid double-rounding errors, by insisting on integers when
9177 parsing non-base-10 numbers, as the documentation specifies.
9178 * lisp.h (string_to_number): New decl, replacing ...
9179 (isfloat_string): Remove.
bc0a5c13 9180 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9181 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9182 appears to have been a coding error. Similarly, do not accept
9183 strings like +-1e0 as floating point numbers. Do not report
9184 overflow for integer overflows unless the base is not 10 which
9185 means we have no simple and reliable way to continue.
9186 Break out the floating-point parsing into a new
9187 function string_to_number, so that Fstring_to_number parses
9188 floating point numbers consistently with the Lisp reader.
04f2d78b 9189 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9190 (E_CHAR, EXP_INT): Remove, replacing with ...
9191 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9192 (string_to_number): New function, replacing isfloat_string.
9193 This function checks for valid syntax and produces the resulting
9194 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9195 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9196 so that overflow for non-base-10 numbers is reported only when
9197 there's no portable and simple way to convert to floating point.
452f4150 9198
67769ffc
PE
9199 * textprop.c (set_text_properties_1): Rewrite for clarity,
9200 and to avoid GCC warning about integer overflow.
9201
c20db43f
PE
9202 * intervals.h (struct interval): Use EMACS_INT for members
9203 where EMACS_UINT might cause problems. See
9204 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9205 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9206 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9207 All uses changed.
37aa2f85
PE
9208 (offset_intervals): Tell GCC not to worry about length overflow
9209 when negating a negative length.
c20db43f 9210
2538aa2f
PE
9211 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9212 (overrun_check_free): Likewise.
9213
f2d3008d
PE
9214 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9215 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9216 word size.
9217
ec8df744
PE
9218 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9219 (gnutls_make_error): Rename local to avoid shadowing.
9220 (gnutls_emacs_global_deinit): ifdef out; not used.
9221 (Fgnutls_boot): Use const for pointer to readonly storage.
9222 Comment out unused local. Fix pointer signedness problems.
9223
640ee02d
PE
9224 * lread.c (openp): Don't stuff size_t into an 'int'.
9225 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9226 about possible signed overflow.
9227
6048fb2a
PE
9228 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9229 (GDK_KEY_g): Don't define if already defined.
9230 (xg_prepare_tooltip): Avoid pointer signedness problem.
9231 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9232
fa3c87e1
PE
9233 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9234 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9235
2172544b
PE
9236 * xfns.c (Fx_window_property): Simplify a bit,
9237 to make a bit faster and to avoid GCC 4.6.0 warning.
9238 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9239
9b821a21
PE
9240 * fns.c (internal_equal): Don't assume size_t fits in int.
9241
3c616cfa
PE
9242 * alloc.c (compact_small_strings): Tighten assertion a little.
9243
c2982e87
PE
9244 Replace pEd with more-general pI, and fix some printf arg casts.
9245 * lisp.h (pI): New macro, generalizing old pEd macro to other
9246 conversion specifiers. For example, use "...%"pI"d..." rather
9247 than "...%"pEd"...".
9248 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9249 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9250 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9251 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9252 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9253 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9254 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9255 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9256 64-bit hosts.
9257 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9258 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9259 * print.c (safe_debug_print, print_object): Likewise.
9260 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9261 to int.
6f04d126
PE
9262 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9263 avoiding the 0 flag, which is not portable.
c2982e87
PE
9264 * process.c (Fmake_network_process): Use pI to avoid cast.
9265 * region-cache.c (pp_cache): Likewise.
9266 * xdisp.c (decode_mode_spec): Likewise.
9267 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9268 behavior on 64-bit hosts with printf arg.
6f04d126 9269 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9270 (x_stop_queuing_selection_requests): Likewise.
9271 (x_get_window_property): Don't truncate byte count to an 'int'
9272 when tracing.
0b432f21 9273
5e073ec7
PE
9274 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9275 here, since it parses constructs like leading '-' and spaces,
9276 which are not wanted; and it overflows with large numbers.
9277 Instead, simply match F[0-9]+, which is what is wanted anyway.
9278
36372bf9
PE
9279 * alloc.c: Remove unportable assumptions about struct layout.
9280 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9281 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9282 (allocate_vectorlike, make_pure_vector): Use the new macros,
9283 plus offsetof, to remove unportable assumptions about struct layout.
9284 These assumptions hold on all porting targets that I know of, but
9285 they are not guaranteed, they're easy to remove, and removing them
9286 makes further changes easier.
9287
0b432f21
PE
9288 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9289 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9290 (string_overrun_cookie): Now const. Use initializers that
9291 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9292 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9293 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9294 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9295 multiple of sizeof (EMACS_INT); it need not be, if
9296 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9297 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9298
895009e1
JB
92992011-04-26 Juanma Barranquero <lekktu@gmail.com>
9300
9301 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9302
6a7a1b0b
TZ
93032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9304
9305 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9306 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9307 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9308
841a1577 93092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9310
9311 * lisp.h (Qdebug): List symbol.
895009e1 9312 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9313 * keyboard.c (debug-on-event): New variable.
9314 (handle_user_signal): Break into debugger when debug-on-event
9315 matches the current signal symbol.
9316
f2d3ba6f
DN
93172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9318
9319 * alloc.c (check_sblock, check_string_bytes)
9320 (check_string_free_list): Convert to standard C.
9321
42ce4c63
TZ
93222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9323
9324 * w32.c (emacs_gnutls_push): Fix typo.
9325
825cd63c
EZ
93262011-04-25 Eli Zaretskii <eliz@gnu.org>
9327
fb11d64d
EZ
9328 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9329 "cast to pointer from integer of different size".
9330
825cd63c
EZ
9331 Improve doprnt and its use in verror. (Bug#8545)
9332 * doprnt.c (doprnt): Document the set of format control sequences
9333 supported by the function. Use SAFE_ALLOCA instead of always
9334 using `alloca'.
9335
9336 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9337 is one byte too soon. Don't use xrealloc; instead xfree and
9338 xmalloc anew.
9339
e061a11b
TZ
93402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9341
9342 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9343 callbacks stage.
9344
9345 * gnutls.c: Renamed global_initialized to
9346 gnutls_global_initialized. Added internals for the
9347 :verify-hostname-error, :verify-error, and :verify-flags
9348 parameters of `gnutls-boot' and documented those parameters in the
9349 docstring. Start callback support.
9173deec
JB
9350 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9351 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9352 on error. Return error code.
e061a11b
TZ
9353 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9354 (emacs_gnutls_read): Likewise.
9355 (Fgnutls_boot): Return handshake error code.
9356 (emacs_gnutls_handle_error): New function.
9357 (wsaerror_to_errno): Likewise.
9358
9359 * w32.h (emacs_gnutls_pull): Add prototype.
9360 (emacs_gnutls_push): Likewise.
9361
9362 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9363 (emacs_gnutls_push): Likewise.
9364
93652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9366
9367 * process.c (wait_reading_process_output): Check if GnuTLS
9368 buffered some data internally if no FDs are set for TLS
9369 connections.
9370
9371 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9372 (LIBS): Link to USER_LIBS.
9373 ($(BLD)/gnutls.$(0)): New target.
9374
fa6996bc
EZ
93752011-04-24 Eli Zaretskii <eliz@gnu.org>
9376
eb35682e
EZ
9377 * xdisp.c (handle_single_display_spec): Rename the
9378 display_replaced_before_p argument into display_replaced_p, to
9379 make it consistent with the commentary. Fix typos in the
9380 commentary.
9381
e2ad650c
EZ
9382 * textprop.c (syms_of_textprop): Remove dead code.
9383 (copy_text_properties): Delete obsolete commentary about an
9384 interface that was deleted long ago. Fix typos in the description
9385 of arguments.
9386
1b2de274
EZ
9387 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9388 to changes in oldXMenu/XMenu.h from 2011-04-16.
9389 <menu_help_message, prev_menu_help_message>: Constify.
9390 (IT_menu_make_room): menu->help_text is now `const char **';
9391 adjust.
9392
9393 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9394 to changes in oldXMenu/XMenu.h from 2011-04-16.
9395 (struct XMenu): Declare `help_text' `const char **'.
9396
9397 * xfaces.c <Qunspecified>: Make extern again.
9398
9399 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9400 required by POSIX.
1b2de274 9401
762b15be
EZ
9402 * doc.c (get_doc_string): Improve the format passed to `error'.
9403
9404 * doprnt.c (doprnt): Improve commentary.
9405
9406 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9407
9408 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9409 them with etags.
9410
f1052e5d
EZ
9411 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9412 changes in globals.h immediately force recompilation.
762b15be
EZ
9413 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9414 $(CURDIR)/s/ms-w32.h.
9415 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9416
fa6996bc
EZ
9417 * character.c (Fchar_direction): Function deleted.
9418 (syms_of_character): Don't defsubr it.
9419 <char-direction-table>: Deleted.
9420
e6c3da20
EZ
94212011-04-23 Eli Zaretskii <eliz@gnu.org>
9422
9423 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9424 * doprnt.c: Include limits.h.
9425 (SIZE_MAX): New macro.
04f2d78b
CB
9426 (doprnt): Return a size_t value. 2nd arg is now size_t.
9427 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9428 Improve overflow protection. Support `l' modifier for integer
9429 conversions. Support %l conversion. Don't assume an EMACS_INT
9430 argument for integer conversions and for %c.
9431
9432 * lisp.h (doprnt): Restore prototype.
9433
9434 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9435 $(SRC)/character.h.
9436
9437 * Makefile.in (base_obj): Add back doprnt.o.
9438
9439 * deps.mk (doprnt.o): Add back prerequisites.
9440 (callint.o): Depend on character.h.
9441
9442 * eval.c (internal_lisp_condition_case): Include the handler
9443 representation in the error message.
9444 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9445 when breaking from the loop.
9446
9447 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9448
9449 * callint.c (Fcall_interactively): When displaying error message
9450 about invalid control letter, pass the character's codepoint, not
9451 a pointer to its multibyte form. Improve display of the character
9452 in octal and display also its hex code.
9453
9454 * character.c (char_string): Use %x to display the (unsigned)
9455 codepoint of an invalid character, to avoid displaying a bogus
9456 negative value.
9457
9458 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9459 `error', not SYMBOL_NAME itself.
9460
9461 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9462 character arguments to `error'.
9463
9464 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9465 to `error' in error message about FINAL_CHAR argument. Make sure
9466 FINAL_CHAR is a character, and use %c when it is passed as
9467 argument to `error'.
9468
4ffd0d6b 94692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9470
9471 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9472
9473 * w32.c: Include <time.h>.
9474 (sys_localtime): New function.
9475
4ffd0d6b 94762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9477
9478 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9479
4ffd0d6b 9480 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9481
4ffd0d6b 94822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9483
4ffd0d6b
GM
9484 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9485 zombies (Bug#8467).
aac0c6e3 9486
04c56954
EZ
94872011-04-19 Eli Zaretskii <eliz@gnu.org>
9488
9489 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9490 gl_state.e_property when gl_state.object is Qt.
9491
9492 * insdel.c (make_gap_larger): Remove limitation of buffer size
9493 to <= INT_MAX.
9494
16a43933
CY
94952011-04-18 Chong Yidong <cyd@stupidchicken.com>
9496
9497 * xdisp.c (lookup_glyphless_char_display)
9498 (produce_glyphless_glyph): Handle cons cell entry in
9499 glyphless-char-display.
9500 (Vglyphless_char_display): Document it.
9501
9502 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9503 glyphless-char-display.
9504
4581706e
CY
95052011-04-17 Chong Yidong <cyd@stupidchicken.com>
9506
9507 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9508
9509 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9510
9511 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9512 definition for no-X builds.
9513
4887c6e2 95142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9515
fd35b6f9
PE
9516 Static checks with GCC 4.6.0 and non-default toolkits.
9517
5c1ccb01
PE
9518 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9519
006c5daa
PE
9520 * process.c (keyboard_bit_set): Define only if SIGIO.
9521 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9522 (send_process): Repair possible setjmp clobbering.
9523
efc736d3
PE
9524 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9525
4e2fe2e6
PE
9526 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9527
f97334a2
PE
9528 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9529
4e75f29d
PE
9530 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9531 Define only if needed.
9532
90efadd1
PE
9533 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9534 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9535 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9536
3c647824
PE
9537 * dispextern.h (struct redisplay_interface): Rename param
9538 to avoid shadowing.
e264f262 9539 * termhooks.h (struct terminal): Likewise.
761383f4 9540 * xterm.c (xembed_send_message): Likewise.
3c647824 9541
b58c5c4a
PE
9542 * insdel.c (make_gap_smaller): Define only if
9543 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9544
cad59032
PE
9545 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9546 it.
9547
c339dc2e
PE
9548 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9549 so that we aren't warned about unused symbols.
9550
91a3e27b
PE
9551 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9552
399c71d3 9553 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9554
8ffc96f5
PE
9555 * xfns.c (x_real_positions): Mark locals as initialized.
9556
eef9bc79
PE
9557 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9558
098db9dd
PE
9559 * xterm.c: Fix problems found by static analysis with other toolkits.
9560 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9561 (x_dispatch_event): Declare static if USE_GTK, and
9562 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9563 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9564 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9565 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9566 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9567
eb18f6cc
PE
9568 * xmenu.c (menu_help_callback): Pointer type fixes.
9569 Use const pointers when pointing at readonly data. Avoid pointer
9570 signedness clashes.
9571 (FALSE): Remove unused macro.
9572 (update_frame_menubar): Remove unused decl.
9573
1fe72bf8
PE
9574 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9575
60d9e1db
PE
9576 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9577 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9578 (single_menu_item): Rename local to avoid shadowing.
9579
39261c26
PE
9580 * keyboard.c (make_lispy_event): Remove unused local var.
9581
018c5e19
PE
9582 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9583 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9584
63d2b86e
PE
9585 * bitmaps: Change bitmaps from unsigned char back to the X11
9586 compatible char. Avoid the old compiler warnings about
9587 out-of-range initializers by using, for example, '\xab' rather
9588 than 0xab.
9589
aefd87e1
PE
9590 * xgselect.c (xgselect_initialize): Check vs interface
9591 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9592
bf501fb9
PE
9593 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9594
e9829fdf
PE
9595 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9596 to read-only memory.
9597
1086c095
PE
9598 * fns.c (vector): Remove; this old hack is no longer needed.
9599
2baccd04 9600 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9601 Remove unused var.
dde42981 9602 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9603
72391843 9604 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9605
436c16df 9606 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9607 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9608 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9609
92bb796d 9610 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9611 (x_term_init): Remove local to avoid shadowing.
92bb796d 9612
764430a3 9613 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9614
9615 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9616 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9617
d1dfb56c
EZ
96182011-04-16 Eli Zaretskii <eliz@gnu.org>
9619
c4354cb4
EZ
9620 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9621
d1dfb56c
EZ
9622 Fix regex.c, syntax.c and friends for buffers > 2GB.
9623 * syntax.h (struct gl_state_s): Declare character position members
9624 EMACS_INT.
9625
9626 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9627
04f2d78b
CB
9628 * textprop.c (verify_interval_modification, interval_of):
9629 Declare arguments EMACS_INT.
d1dfb56c
EZ
9630
9631 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9632 EMACS_INT.
9633
9634 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9635
9636 * indent.c (Fvertical_motion): Local variable it_start is now
9637 EMACS_INT.
9638
9639 * regex.c (re_match, re_match_2, re_match_2_internal)
9640 (bcmp_translate, regcomp, regexec, print_double_string)
9641 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9642 (re_compile_pattern, re_exec): Declare arguments and local
9643 variables `size_t' and `ssize_t' and return values `regoff_t', as
9644 appropriate.
9645 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9646 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9647 <compile_stack_type>: `size' and `avail' are now `size_t'.
9648
9649 * regex.h <regoff_t>: Use ssize_t, not int.
9650 (re_search, re_search_2, re_match, re_match_2): Arguments that
9651 specify buffer/string position and length are now ssize_t and
9652 size_t. Return type is regoff_t.
9653
613052cd
BK
96542011-04-16 Ben Key <bkey76@gmail.com>
9655
9656 * nsfont.m: Fixed bugs in ns_get_family and
9657 ns_descriptor_to_entity that were caused by using free to
9658 deallocate memory blocks that were allocated by xmalloc (via
9659 xstrdup). This caused Emacs to crash when compiled with
9660 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9661 --enable-checking=xmallocoverrun). xfree is now used to
9662 deallocate these memory blocks.
9663
4170f62f 96642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9665
71b41406
PE
9666 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9667
9587a89d
PE
9668 emacs_write: Accept and return EMACS_INT for sizes.
9669 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9670 et seq.
9671 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9672 Accept and return EMACS_INT.
9673 (emacs_gnutls_write): Return the number of bytes written on
9674 partial writes.
9675 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9676 (emacs_read, emacs_write): Remove check for negative size, as the
9677 Emacs source code has been audited now.
9587a89d
PE
9678 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9679 (emacs_read, emacs_write): Use it.
273a5f82
PE
9680 * process.c (send_process): Adjust to the new signatures of
9681 emacs_write and emacs_gnutls_write. Do not attempt to store
9682 a byte offset into an 'int'; it might overflow.
9587a89d 9683 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9684
3e047f51
PE
9685 * sound.c: Don't assume sizes fit in 'int'.
9686 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9687 Return EMACS_INT, not int.
3e047f51 9688 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9689 Accept EMACS_INT, not int.
9690 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9691 record read return values.
9692
cc39a9db
BK
96932011-04-15 Ben Key <bkey76@gmail.com>
9694
c9d0ec6d
JB
9695 * keyboard.c (Qundefined): Don't declare static since it is used
9696 in nsfns.m.
9697 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9698 static since they are used in nsfont.m.
cc39a9db 9699
6c60eb9f
SM
97002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9701
9702 * process.c (Qprocessp): Don't declare static.
9703 * lisp.h (Qprocessp): Declare again.
9704
7990b61a
JB
97052011-04-15 Juanma Barranquero <lekktu@gmail.com>
9706
9707 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9708
5d4cb038
PE
97092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9710
8bd7b830 9711 Improve C-level modularity by making more things 'static'.
cd64ea1d 9712
e3b27b31
PE
9713 Don't publish debugger-only interfaces to other modules.
9714 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9715 (verify_bytepos, count_markers): Move decls to the only modules
9716 that need them.
9717 * region-cache.h (pp_cache): Likewise.
9718 * window.h (check_all_windows): Likewise.
9719 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9720
5d4cb038
PE
9721 * sysdep.c (croak): Now static, if
9722 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9723 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9724
9725 * alloc.c (refill_memory_reserve): Now static if
9726 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9727 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9728
e87b6180
PE
9729 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9730 Define only if USE_LUCID.
9731
ac64929e
PE
9732 * xrdb.c (x_customization_string, x_rm_string): Now static.
9733
6f37259d
PE
9734 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9735 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9736
1683e3ab
PE
9737 * xdisp.c (draw_row_with_mouse_face): Now static.
9738 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9739
de9c2632
PE
9740 * window.h (check_all_windows): Mark externally visible.
9741
2b96acb7
PE
9742 * window.c (window_deletion_count): Now static.
9743
9744 * undo.c: Make symbols static if they're not exported.
9745 (last_undo_buffer, last_boundary_position, pending_boundary):
9746 Now static.
9747
50436f33
PE
9748 * textprop.c (interval_insert_behind_hooks): Now static.
9749 (interval_insert_in_front_hooks): Likewise.
9750
64520e5c
PE
9751 * term.c: Make symbols static if they're not exported.
9752 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9753 (max_frame_lines, tty_set_terminal_modes):
9754 (tty_reset_terminal_modes, tty_turn_off_highlight):
9755 (get_tty_terminal): Now static.
9756 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9757 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9758 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9759 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9760 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9761
1fa53021
PE
9762 * sysdep.c: Make symbols static if they're not exported.
9763 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9764 Now static.
9765 (sigprocmask_set, full_mask): Remove; unused.
9766 (wait_debugging): Mark as visible.
9767 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9768 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9769
d4b43b22
PE
9770 * syntax.c (syntax_temp): Define only if !__GNUC__.
9771
b7c513d0
PE
9772 * sound.c (current_sound_device, current_sound): Now static.
9773
989b29ad
PE
9774 * search.c (searchbufs, searchbuf_head): Now static.
9775
13a55a78
PE
9776 * scroll.c (scroll_cost): Remove; unused.
9777 * dispextern.h (scroll_cost): Remove decl.
9778
de68a1fc
PE
9779 * region-cache.h (pp_cache): Mark as externally visible.
9780
40ccffa6
PE
9781 * process.c: Make symbols static if they're not exported.
9782 (process_tick, update_tick, create_process, chan_process):
9783 (Vprocess_alist, proc_buffered_char, datagram_access):
9784 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9785 (deactivate_process): Mark defn as static, as well as decl.
9786 * lisp.h (create_process): Remove decl.
9787 * process.h (chan_process, Vprocess_alist): Remove decls.
9788
ad64fc97
PE
9789 * print.c: Make symbols static if they're not exported.
9790 (print_depth, new_backquote_output, being_printed, print_buffer):
9791 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9792 (print_interval, print_number_index, initial_stderr_stream):
9793 Now static.
9794 * lisp.h (Fprinc): Remove decl.
9795 (debug_output_compilation_hack): Mark as externally visible.
9796
adddb265
PE
9797 * sysdep.c (croak): Move decl from here to syssignal.h.
9798 * syssignal.h (croak): Put it here, so the API can be checked when
9799 'croak' is called from dissociate_if_controlling_tty.
9800
1717ede2
PE
9801 * minibuf.c: Make symbols static if they're not exported.
9802 (minibuf_save_list, choose_minibuf_frame): Now static.
9803 * lisp.h (choose_minibuf_frame): Remove decl.
9804
fa5fb2bc
PE
9805 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9806
1e3890d1
PE
9807 * lread.c: Make symbols static if they're not exported.
9808 (read_objects, initial_obarray, oblookup_last_bucket_number):
9809 Now static.
9810 (make_symbol): Remove; unused.
9811 * lisp.h (initial_obarray, make_symbol): Remove decls.
9812
8a1414fa
PE
9813 * keyboard.c: Make symbols static if they're not exported.
9814 (single_kboard, recent_keys_index, total_keys, recent_keys):
9815 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9816 (this_single_command_key_start, echoing, last_auto_save):
9817 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9818 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9819 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9820 (Vlispy_mouse_stem, double_click_count):
9821 Now static.
9822 (force_auto_save_soon): Define only if SIGDANGER.
9823 (ignore_mouse_drag_p): Now static if
9824 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9825 (print_help): Remove; unused.
9826 (stop_character, last_timer_event): Mark as externally visible.
9827 * keyboard.h (ignore_mouse_drag_p): Declare only if
9828 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9829 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9830 * lisp.h (echoing): Remove decl.
9831 (force_auto_save_soon): Declare only if SIGDANGER.
9832 * xdisp.c (redisplay_window): Simplify code, to make it more
9833 obvious that ignore_mouse_drag_p is not accessed if !defined
9834 USE_GTK && !defined HAVE_NS.
9835
93ea6e8f
PE
9836 * intervals.c: Make symbols static if they're not exported.
9837 (merge_properties_sticky, merge_interval_right, delete_interval):
9838 Now static.
9839 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9840
77382fcc
PE
9841 * insdel.c: Make symbols static if they're not exported.
9842 However, leave prepare_to_modify_buffer alone. It's never
9843 called from outside this function, but that appears to be a bug.
9844 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9845 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9846 (adjust_after_replace_noundo): Remove; unused.
9847 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9848 (signal_before_change): Remove decls.
77382fcc 9849
9306c32e
PE
9850 * indent.c (val_compute_motion, val_vmotion): Now static.
9851
cd44d2eb
PE
9852 * image.c: Make symbols static if they're not exported.
9853 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9854 if USE_GTK.
9855 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9856 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9857
ad9a7a06
PE
9858 * fringe.c (standard_bitmaps): Now static.
9859 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9860
81626931
PE
9861 * frame.c: Make symbols static if they're not exported.
9862 (x_report_frame_params, make_terminal_frame): Now static.
9863 (get_frame_param): Now static, unless HAVE_NS.
9864 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9865 (x_get_resource_string): Remove; not used.
9866 * frame.h (make_terminal_frame, x_report_frame_params):
9867 (x_get_resource_string); Remove decls.
9868 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9869 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9870
239f9db9
PE
9871 * font.c, fontset.c: Make symbols static if they're not exported.
9872 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9873 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9874 * font.c (font_close_object): Now static.
9875 * font.h (font_close_object): Remove.
9876 * fontset.c (FONTSET_OBJLIST): Remove.
9877 (free_realized_fontset) #if-0 the body, which does nothing.
9878 (face_suitable_for_char_p): #if-0, as it's never called.
9879 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9880 * xfaces.c (face_at_string_position):
9881 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9882 since 0 is always ASCII.
9883
dfcf3579
PE
9884 * fns.c (weak_hash_tables): Now static.
9885
5045092b
PE
9886 * fileio.c: Make symbols static if they're not exported.
9887 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9888 (Vwrite_region_annotation_buffers): Now static.
9889
57a96f5c
PE
9890 * eval.c: Make symbols static if they're not exported.
9891 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9892 * lisp.h (backtrace_list): Remove decl.
9893
35f08c38
PE
9894 * emacs.c: Make symbols static if they're not exported.
9895 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9896 (fatal_error_code, fatal_error_signal_hook, standard_args):
9897 Now static.
9898 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9899 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9900 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9901 * lisp.h (fatal_error_signal_hook): Remove decl.
9902 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9903
f44bd759
PE
9904 * editfns.c: Move a (normally-unused) function to its only use.
9905 * editfns.c, lisp.h (get_operating_system_release): Remove.
9906 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9907 worth the hassle of breaking this out.
9908
b532497d
PE
9909 * xterm.c: Make symbols static if they're not exported.
9910 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9911 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9912 (x_destroy_window, x_delete_display):
9913 Now static.
9914 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9915 (x_mouse_leave): Remove; unused.
9916 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9917 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9918 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9919 Remove decls.
9920 (x_mouse_leave): Declare only if WINDOWSNT.
9921 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9922 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9923 USE_X_TOOLKIT.
9924
1675728f
PE
9925 * ftxfont.c: Make symbols static if they're not exported.
9926 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9927 HAVE_FREETYPE.
9928 * font.h (ftxfont_driver): Likewise.
9929
e4cebfca
PE
9930 * xfns.c: Make symbols static if they're not exported.
9931 (x_last_font_name, x_display_info_for_name):
9932 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9933 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9934 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9935 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9936 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9937 (last_show_tip_args): Now static.
9938 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9939 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9940 (x_screen_planes): Remove; unused.
9941 * dispextern.h (x_screen_planes): Remove decl.
9942
5bf46f05
PE
9943 * dispnew.c: Make symbols static if they're not exported.
9944 * dispextern.h (redraw_garbaged_frames, scrolling):
9945 (increment_row_positions): Remove.
9946 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9947 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9948 Now static.
9949 (redraw_garbaged_frames): Remove; unused.
9950
435f4c28
PE
9951 * xfaces.c: Make symbols static if they're not exported.
9952 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9953 Remove decls.
9954 * xterm.h (defined_color): Remove decls.
9955 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9956 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9957 (menu_face_changed_default, defined_color, free_realized_face):
9958 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9959 (ascii_face_of_lisp_face): Remove; unused.
9960
8524aef3
PE
9961 * xdisp.c: Make symbols static if they're not exported.
9962 * dispextern.h (scratch_glyph_row, window_box_edges):
9963 (glyph_to_pixel_coords, set_cursor_from_row):
9964 (get_next_display_element, set_iterator_to_next):
9965 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9966 (show_mouse_face): Remove decls
9967 * frame.h (message_buf_print): Likewise.
9968 * lisp.h (pop_message, set_message, check_point_in_composition):
9969 Likewise.
9970 * xterm.h (set_vertical_scroll_bar): Likewise.
9971 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9972 (message_buf_print, scratch_glyph_row, displayed_buffer):
9973 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9974 (get_next_display_element, show_mouse_face, window_box_edges):
9975 (frame_to_window_pixel_xy, check_point_in_composition):
9976 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9977 (glyph_to_pixel_coords): Remove; unused.
9978
16390cd2
PE
9979 * dired.c (file_name_completion): Now static.
9980
9981 * dbusbind.c (xd_in_read_queued_messages): Now static.
9982
a25f4dfa
PE
9983 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9984 * data.c (circular_list_error): Remove.
9985
14a9c8df
PE
9986 * commands.h (last_point_position, last_point_position_buffer):
9987 (last_point_position_window): Remove decls.
9988 * keyboard.c: Make these variables static.
9989
04f2d78b
CB
9990 * coding.h (coding, code_convert_region, encode_coding_gap):
9991 Remove decls.
74ab6df5
PE
9992 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9993 (iso_code_class, detect_coding, code_convert_region): Now static.
9994 (encode_coding_gap): Remove; unused.
9995
38dfbee1
PE
9996 * chartab.c (chartab_chars, chartab_bits): Now static.
9997
a2cb4e63
PE
9998 * charset.h (charset_iso_8859_1): Remove decl.
9999 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10000 Now static.
10001
127198fd
PE
10002 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10003 * ccl.c (Vccl_program_table): Now static.
10004 (check_ccl_update): Remove; unused.
10005
d85b608f
PE
10006 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10007 * category.h: ... from here.
10008 * category.c (check_category_table, set_category_set): Now static.
10009
31cd66f3
PE
10010 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10011 * lisp.h: Remove these decls.
10012
c358e587
PE
10013 * buffer.c (buffer_count): Remove unused var.
10014
e78aecca
PE
10015 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10016 so that it's not optimized away.
10017 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10018 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10019 exported only to the debugger.
10020
e192d7d3 10021 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10022 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10023
92470028
PE
10024 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10025 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10026 was inaccessible from Lisp.
10027 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10028 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10029
244ed907
PE
10030 alloc.c: Import and export fewer symbols, and remove unused items.
10031 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10032 is defined.
10033 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10034 it's not optimized away by whole-program optimization.
10035 (message_enable_multibyte, free_misc): Remove.
10036 (catchlist, handlerlist, mark_backtrace):
10037 Declare only if BYTE_MARK_STACK.
10038 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10039 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10040 (message_enable_multibyte): Remove decl.
10041 (free_misc, interval_free_list, float_block, float_block_index):
10042 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10043 (cons_free_list, last_marked_index):
10044 Now static.
10045 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10046 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10047 (mark_backtrace): Define only if BYTE_MARK_STACK.
10048 * xdisp.c (message_enable_multibyte): Now static.
10049
61c2b50e 10050 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10051 This makes it easier for human readers (and static analyzers)
10052 to see whether these variables are used from other modules.
10053 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10054 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10055 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10056 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10057 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10058 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10059 * xmenu.c, xselect.c:
10060 Declare Q* vars static if they are not used in other modules.
10061 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10062 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10063 Remove decls of unexported vars.
10064 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10065
95c82688
PE
10066 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10067
16a97296
PE
10068 Make Emacs functions such as Fatom 'static' by default.
10069 This makes it easier for human readers (and static analyzers)
10070 to see whether these functions can be called from other modules.
10071 DEFUN now defines a static function. To make the function external
10072 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10073 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10074 (Finit_image_library):
16a97296
PE
10075 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10076 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10077 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10078 Remove decls, since these functions are now static.
10079 (Funintern, Fget_internal_run_time): New decls, since these functions
10080 were already external.
95c82688 10081
16a97296
PE
10082 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10083 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10084 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10085 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10086 * keyboard.c, keymap.c, lread.c:
10087 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10088 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10089 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10090 Mark functions with DEFUE instead of DEFUN,
10091 if they are used in other modules.
10092 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10093 decls for now-static functions.
10094 * buffer.h (Fdelete_overlay): Remove decl.
10095 * callproc.c (Fgetenv_internal): Mark as internal.
10096 * composite.c (Fremove_list_of_text_properties): Remove decl.
10097 (Fcomposition_get_gstring): New forward static decl.
10098 * composite.h (Fcomposite_get_gstring): Remove decl.
10099 * dired.c (Ffile_attributes): New forward static decl.
10100 * doc.c (Fdocumntation_property): New forward static decl.
10101 * eval.c (Ffetch_bytecode): New forward static decl.
10102 (Funintern): Remove extern decl; now in .h file where it belongs.
10103 * fileio.c (Fmake_symbolic_link): New forward static decl.
10104 * image.c (Finit_image_library): New forward static decl.
10105 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10106 * intervals.h (Fprevious_property_change):
10107 (Fremove_list_of_text_properties): Remove decls.
10108 * keyboard.c (Fthis_command_keys): Remove decl.
10109 (Fcommand_execute): New forward static decl.
10110 * keymap.c (Flookup_key): New forward static decl.
10111 (Fcopy_keymap): Now static.
10112 * keymap.h (Flookup_key): Remove decl.
10113 * process.c (Fget_process): New forward static decl.
10114 (Fprocess_datagram_address): Mark as internal.
10115 * syntax.c (Fsyntax_table_p): New forward static decl.
10116 (skip_chars): Remove duplicate decl.
10117 * textprop.c (Fprevious_property_change): New forward static decl.
10118 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10119 Now internal.
10120 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10121 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10122
785bbd42
PE
10123 * editfns.c (Fformat): Remove unreachable code.
10124
8b913b57
AS
101252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10126
10127 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10128 change. (Bug#8496)
10129
a6744a35
EZ
101302011-04-13 Eli Zaretskii <eliz@gnu.org>
10131
10132 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10133 when at ZV. (Bug#8487)
10134
e7974947
AS
101352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10136
baad03f0
AS
10137 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10138 (Bug#8437)
10139 * keyboard.c (parse_tool_bar_item): Likewise.
10140 * sound.c (sound_cleanup, alsa_close): Likewise.
10141 * termcap.c (tgetent): Likewise.
10142 * xfns.c (x_default_font_parameter): Likewise.
10143 * xsettings.c (read_and_apply_settings): Likewise.
10144
e7974947
AS
10145 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10146 (overrun_check_free): Protoize.
10147
28272684
PE
101482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10149
10150 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10151 since callers should never pass a negative size.
10152 Change the signature to match that of plain 'read' and 'write'; see
10153 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10154 * lisp.h: Update prototypes of emacs_write and emacs_read.
10155
11997c76
EZ
101562011-04-11 Eli Zaretskii <eliz@gnu.org>
10157
10158 * xdisp.c (redisplay_window): Don't try to determine the character
10159 position of the scroll margin if the window start point w->startp
e896f03c 10160 is outside the buffer's accessible region. (Bug#8468)
11997c76 10161
8a2cbd72
EZ
101622011-04-10 Eli Zaretskii <eliz@gnu.org>
10163
10164 Fix write-region and its subroutines for buffers > 2GB.
10165 * fileio.c (a_write, e_write): Modify declaration of arguments and
10166 local variables to support buffers larger than 2GB.
10167 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10168
10169 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10170 argument, local variables, and return value.
10171
10172 * lisp.h: Update prototypes of emacs_write and emacs_read.
10173
10174 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10175
4073e537 101762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10177
1ebfdcb6
PE
10178 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10179
b2ded58d
PE
10180 Fix more problems found by GCC 4.6.0's static checks.
10181
7d66342c
PE
10182 * xdisp.c (vmessage): Use a better test for character truncation.
10183
bbf47d44
PE
10184 * charset.c (load_charset_map): <, not <=, for optimization,
10185 and to avoid potential problems with integer overflow.
9248994d 10186 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10187 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10188 * editfns.c (Fformat): Likewise.
1e69125e 10189 * syntax.c (skip_chars): Likewise.
3befa583 10190
e3019616
PE
10191 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10192 This also lets GCC 4.6.0 generate slightly better loop code.
10193
becfa255
PE
10194 * callint.c (Fcall_interactively): <, not <=, for optimization.
10195 (Fcall_interactively): Count the number of arguments produced,
10196 not the number of arguments given. This is simpler and lets GCC
10197 4.6.0 generate slightly better code.
10198
dae0cd48
PE
10199 * ftfont.c: Distingish more carefully between FcChar8 and char.
10200 The previous code passed unsigned char * to a functions like
10201 strlen and xstrcasecmp that expect char *, which does not
10202 conform to the C standard.
10203 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10204 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10205 char * when the C standard requires it.
10206
76032d70
PE
10207 * keyboard.c (read_char): Remove unused var.
10208
eb3f1cc8
PE
10209 * eval.c: Port to Windows vsnprintf (Bug#8435).
10210 Include <limits.h>.
10211 (SIZE_MAX): Define if the headers do not.
10212 (verror): Do not give up if vsnprintf returns a negative count.
10213 Instead, grow the buffer. This ports to Windows vsnprintf, which
10214 does not conform to C99. Problem reported by Eli Zaretskii.
10215 Also, simplify the allocation scheme, by avoiding the need for
10216 calling realloc, and removing the ALLOCATED variable.
10217
70476b54
PE
10218 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10219
12020a9e
PE
10220 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10221 But keep the doprint source code for now, as we might revamp it
10222 and use it again (Bug#8435).
ea6c7ae6
PE
10223 * lisp.h (doprnt): Remove.
10224 * Makefile.in (base_obj): Remove doprnt.o.
10225 * deps.mk (doprnt.o): Remove.
10226
5fdb398c
PE
10227 error: Print 32- and 64-bit integers portably (Bug#8435).
10228 Without this change, on typical 64-bit hosts error ("...%d...", N)
10229 was used to print both 32- and 64-bit integers N, which relied on
10230 undefined behavior.
61bdb816 10231 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10232 * lisp.h (error, verror): Mark as printf-like functions.
10233 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10234 Report overflow in size calculations when allocating printf buffer.
10235 Do not truncate output string at its first null byte.
10236 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10237 Truncate the output at a character boundary, since vsnprintf does not
10238 do that.
10239 * charset.c (check_iso_charset_parameter): Convert internal
10240 character to string before calling 'error', since %c now has the
10241 printf meaning.
10242 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10243 overflow when computing char to be passed to 'error'. Do not
10244 pass Lisp_Object to 'error'; pass the integer instead.
10245 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10246 formatted with plain %d.
10247
b189fa66
PE
10248 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10249
bff87ef0
PE
10250 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10251
7e2cac20
PE
10252 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10253
ce4d90b5
PE
10254 * xterm.c (x_catch_errors): Remove duplicate declaration.
10255
266c9547
PE
10256 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10257
79c49ad2
PE
10258 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10259
368f4090
JM
102602011-04-10 Jim Meyering <meyering@redhat.com>
10261
10262 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10263 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10264 return ssize_t not "int", and use size_t as the buffer length.
10265 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10266 * gnutls.h: Update declarations.
10267 * process.c (read_process_output): Use ssize_t, to match.
10268 (send_process): Likewise.
10269
a32d4040
CY
102702011-04-09 Chong Yidong <cyd@stupidchicken.com>
10271
10272 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10273
8546720e 102742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10275
04f2d78b
CB
10276 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10277 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10278
8546720e
GM
10279 * xterm.c (handle_one_xevent):
10280 * xmenu.c (create_and_show_popup_menu):
10281 * xselect.c (x_decline_selection_request)
10282 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10283
0a2f5c1a 102842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10285
10286 Fix some uses of `int' instead of EMACS_INT.
10287 * search.c (string_match_1, fast_string_match)
10288 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10289 (scan_buffer, find_next_newline_no_quit)
10290 (find_before_next_newline, search_command, Freplace_match)
10291 (Fmatch_data): Make some `int' variables be EMACS_INT.
10292
10293 * xdisp.c (display_count_lines): 3rd argument and return value now
10294 EMACS_INT. All callers changed.
10295 (pint2hrstr): Last argument is now EMACS_INT.
10296
10297 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10298 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10299 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10300 (decode_coding_utf_16, decode_coding_emacs_mule)
10301 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10302 (decode_coding_ccl, decode_coding_charset)
10303 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10304 (decode_coding_iso_2022, decode_coding_emacs_mule)
10305 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10306 <char_offset, last_offset>: Declare EMACS_INT.
10307 (encode_coding_utf_8, encode_coding_utf_16)
10308 (encode_coding_emacs_mule, encode_invocation_designation)
10309 (encode_designation_at_bol, encode_coding_iso_2022)
10310 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10311 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10312 Declare EMACS_INT.
10313 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10314 (encode_invocation_designation): Last argument P_NCHARS is now
10315 EMACS_INT.
10316 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10317 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10318
10319 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10320 All users changed.
10321
10322 * ccl.c (Fccl_execute_on_string): Declare some variables
10323 EMACS_INT.
10324
8546720e 103252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10326
10327 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10328
4e19a977
CS
103292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10330
10331 * process.c (Fformat_network_address): Doc fix.
10332
87302331
R
103332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10334
ee7683eb 10335 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10336
cbb59342
CY
103372011-04-08 Chong Yidong <cyd@stupidchicken.com>
10338
10339 * keyboard.c (read_char): Call Lisp function help-form-show,
10340 instead of using internal_with_output_to_temp_buffer.
10341 (Qhelp_form_show): New var.
e0d38eeb 10342 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10343
10344 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10345
10346 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10347
e67a13ab
CY
103482011-04-06 Chong Yidong <cyd@stupidchicken.com>
10349
04f2d78b
CB
10350 * process.c (Flist_processes): Remove to Lisp.
10351 (list_processes_1): Delete.
e67a13ab 10352
973f782d
EZ
103532011-04-06 Eli Zaretskii <eliz@gnu.org>
10354
7c106b1e
EZ
10355 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10356
973f782d
EZ
10357 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10358
41cf7d1a 103592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10360
ca23cc88
PE
10361 Fix more problems found by GCC 4.6.0's static checks.
10362
f390e2d5
PE
10363 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10364
42eea0d0
PE
10365 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10366
b69769da 10367 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10368
f9541e84
PE
10369 * xdisp.c (vmessage): Mark as a printf-like function.
10370
13841b55
PE
10371 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10372
c136c10f
PE
10373 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10374
5e2d4a30
PE
10375 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10376 printf-like functions.
10377 (tiff_load): Add casts to remove these marks before passing them
10378 to system-supplied API.
10379
583f48b9
PE
10380 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10381
b25d760e
PE
10382 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10383 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10384 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10385 directly, rather than having caller test rule sign. This avoids
10386 some unnecessary tests.
10387 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10388 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10389 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10390
bc7b6697 10391 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10392 (xfont_open): Avoid unnecessary tests.
bc7b6697 10393
27ccc379
PE
10394 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10395
dcd5c89a
PE
10396 * composite.h, composite.c (composition_gstring_put_cache):
10397 Use EMACS_INT, not int, for length.
10398
b13a45c6
PE
10399 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10400 breaking out part of COMPOSITION_DECODE_RULE.
10401 (COMPOSITION_DECODE_RULE): Use it.
10402 * composite.c (get_composition_id): Remove unused local vars,
10403 by using the new macro.
10404
1e792e4d
PE
10405 * textprop.c (set_text_properties_1): Change while to do-while,
10406 since the condition is always true at first.
10407
dc6c6455 10408 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10409 (interval_deletion_adjustment): Return unsigned value.
10410 All uses changed.
dc6c6455 10411
aba7731a
PE
10412 * process.c (list_processes_1, create_pty, read_process_output):
10413 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10414 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10415 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10416 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10417 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10418
fdfc4bf3
PE
10419 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10420
fca8fe46 10421 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10422 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10423
06a0259a 10424 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10425 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10426 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10427
e7b9e80f
PE
10428 * print.c (print_error_message): Avoid int overflow.
10429
56201685
PE
10430 * font.c (font_list_entities): Redo for clarity,
10431 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10432
78834453 10433 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10434 (font_score): Avoid potential overflow in diff calculation.
78834453 10435
0bc0b309 10436 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10437 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10438
e610eaca
PE
10439 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10440
b895abce
PE
10441 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10442 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10443 can always succeed if overflow has undefined behavior.
10444
1f1d9321 10445 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10446 (wordify): Omit three unnecessary tests.
1f1d9321 10447
c59478bc
PE
10448 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10449 All callers changed. This avoids the need for an unused var.
10450
79b73827
PE
10451 * casefiddle.c (casify_region): Remove var that is set but not used.
10452
a4db5dfe
PE
10453 * dired.c (file_name_completion): Remove var that is set but not used.
10454
43aae36e
PE
10455 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10456
2a47c44d 10457 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10458 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10459
a37c69bf
PE
10460 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10461 Check for integer overflow on size calculations.
10462
328ab8e7
PE
10463 * buffer.c (Fprevious_overlay_change): Remove var that is set
10464 but not used.
10465
e5a2a5cb
PE
10466 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10467 Remove vars that are set but not used.
8d84a6eb 10468 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10469 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10470
a60e5f68
PE
10471 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10472
f661cb61 10473 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10474 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10475
f0397f5a
PE
10476 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10477 that are set but not used.
10478
8664db06 10479 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10480 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10481
6abdaa4a
PE
10482 * xselect.c (x_get_local_selection, x_handle_property_notify):
10483 Remove vars that are set but not used.
10484
0ce7538d 10485 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10486 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10487
9ae848fc
PE
10488 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10489 Remove var that is set but not used.
0b918413
PE
10490 (scroll_bar_windows_size): Now size_t, not int.
10491 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10492 Check for overflow.
9ae848fc 10493
a5a62657
PE
10494 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10495 (map_tty_color) [!defined MSDOS]: Likewise.
10496
5c5cdd39
PE
10497 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10498
66ebf983
PE
10499 * coding.c: Remove vars that are set but not used.
10500 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10501 All callers changed.
10502 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10503 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10504 (decode_coding_charset): Remove vars that are set but not used.
10505
1be4d761
PE
10506 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10507 that is set but not used.
10508
47553fa8
PE
10509 * print.c (print_object): Remove var that is set but not used.
10510
1f7196bf 10511 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10512 The gnulib version avoids calling malloc in the usual case,
10513 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10514 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10515 * filelock.c (current_lock_owner): Likewise.
10516 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10517 * sysdep.c: Include allocator.h, careadlinkat.h.
10518 (emacs_no_realloc_allocator): New static constant.
10519 (emacs_readlink): New function.
fdb61804
PE
10520 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10521 ../lib/careadlinkat.h.
d1fdcab7 10522
f84c17c7
SM
105232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10524
10525 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10526 first non-nil return value).
10527
ef3862ad
JD
105282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10529
10530 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10531 if not defined (Bug#8403).
10532
376a7006
JB
105332011-04-02 Juanma Barranquero <lekktu@gmail.com>
10534
10535 * xdisp.c (display_count_lines): Remove parameter `start',
10536 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10537 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10538 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10539 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10540 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10541 and thereabouts. All callers changed.
10542 (get_per_char_metric): Remove parameter `f', unused since
10543 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10544
6ca3801d
JM
105452011-04-02 Jim Meyering <meyering@redhat.com>
10546
10547 do not dereference NULL upon failed strdup
10548 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10549 (ns_get_family): Likewise.
10550
d8e2b5ba
JB
105512011-04-02 Juanma Barranquero <lekktu@gmail.com>
10552
10553 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10554
8c74fcbd
JD
105552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10556
10557 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10558 later (Bug#8403).
10559
7200d79c
SM
105602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10561
03408648 10562 Add lexical binding.
7200d79c 10563
03408648
SM
10564 * window.c (Ftemp_output_buffer_show): New fun.
10565 (Fsave_window_excursion):
10566 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10567
10568 * lread.c (lisp_file_lexically_bound_p): New function.
10569 (Fload): Bind Qlexical_binding.
10570 (readevalloop): Remove `evalfun' arg.
10571 Bind Qinternal_interpreter_environment.
10572 (Feval_buffer): Bind Qlexical_binding.
10573 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10574 Mark as dynamic.
10575 (syms_of_lread): Declare `lexical-binding'.
10576
10577 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10578
10579 * keyboard.c (eval_dyn): New fun.
10580 (menu_item_eval_property): Use it.
ca105506
SM
10581
10582 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10583
03408648
SM
10584 * fns.c (concat, mapcar1): Accept byte-code-functions.
10585
10586 * eval.c (Fsetq): Handle lexical vars.
10587 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10588 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10589 (FletX, Flet): Obey lexical binding.
10590 (Fcommandp): Handle closures.
10591 (Feval): New `lexical' arg.
10592 (eval_sub): New function extracted from Feval. Use it almost
10593 everywhere where Feval was used. Look up vars in lexical env.
10594 Handle closures.
10595 (Ffunctionp): Move from subr.el.
10596 (Ffuncall): Handle closures.
10597 (apply_lambda): Remove `eval_flags'.
10598 (funcall_lambda): Handle closures and new byte-code-functions.
10599 (Fspecial_variable_p): New function.
10600 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10601 but without exporting it to Lisp.
23aba0ea 10602
23aba0ea 10603 * doc.c (Fdocumentation, store_function_docstring):
03408648 10604 * data.c (Finteractive_form): Handle closures.
23aba0ea 10605
03408648
SM
10606 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10607 interactive spec.
ba83908c 10608
04f2d78b
CB
10609 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10610 New byte-codes.
03408648
SM
10611 (exec_byte_code): New function extracted from Fbyte_code to handle new
10612 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10613
03408648 10614 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10615
03408648 10616 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10617
e2abce01
JB
106182011-03-31 Juanma Barranquero <lekktu@gmail.com>
10619
10620 * xdisp.c (redisplay_internal): Fix prototype.
10621
63696a73 106222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10623
63696a73 10624 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10625 (try_scrolling): Use it when setting scroll_limit.
10626 Limit scrolling to 100 screen lines.
63696a73
EZ
10627 (redisplay_window): Even when falling back on "recentering",
10628 position point in the window according to scroll-conservatively,
10629 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10630
10631 (try_scrolling): When point is above the window, allow searching
10632 as far as scroll_max, or one screenful, to compute vertical
10633 distance from PT to the scroll margin position. This prevents
10634 try_scrolling from unnecessarily failing when
10635 scroll-conservatively is set to a value slightly larger than the
10636 window height. Clean up the case of PT below the margin at bottom
10637 of window: scroll_max can no longer be INT_MAX. When aggressive
10638 scrolling is in use, don't let point enter the opposite scroll
10639 margin as result of the scroll.
10640 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10641 threshold of 100 lines for never-recentering scrolling.
10642
e4cc2dfc
JB
106432011-03-31 Juanma Barranquero <lekktu@gmail.com>
10644
10645 * dispextern.h (move_it_by_lines):
10646 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10647 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10648 (message_log_check_duplicate): Remove parameters `prev_bol' and
10649 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10650 (redisplay_internal): Remove parameter `preserve_echo_area',
10651 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10652
10653 * indent.c (Fvertical_motion):
10654 * window.c (window_scroll_pixel_based, Frecenter):
10655 Don't pass `need_y_p' to `move_it_by_lines'.
10656
1c470562
SM
106572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10658
44f230aa
SM
10659 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10660 steal a few bits to be more compact.
10661 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10662 Remove unneeded casts.
10663
1c470562
SM
10664 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10665
888adce9
ZK
106662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10667
10668 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10669 binding" message (bug#7967).
10670
f838ed7b
PE
106712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10672
77861b95
PE
10673 Fix more problems found by GCC 4.6.0's static checks.
10674
de6dbc14
PE
10675 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10676 Remove unused local var.
10677
f838ed7b
PE
10678 * editfns.c (Fmessage_box): Remove unused local var.
10679
792c7b2b
PE
10680 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10681 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10682 Omit unused local vars.
c499e557 10683 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10684 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10685 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10686 Omit unused local var.
10687
ba0165e1
PE
10688 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10689 Don't assume string length fits in int.
32ad8845 10690 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10691 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10692
3c59b4c9
PE
10693 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10694 instead of alloca (Bug#8344).
10695
a3eed478 10696 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10697 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10698
eb4d412d
PE
10699 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10700
1658b401
PE
10701 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10702 concerns.
10703
10704 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10705
10706 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10707
9a2c6e05
PE
10708 * keyboard.c (syms_of_keyboard): Use the same style as later
10709 in this function when indexing through an array. This also
10710 works around GCC bug 48267.
10711
03d0a109
PE
10712 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10713
44f730c8
PE
10714 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10715
fe75f926
PE
10716 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10717 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10718
ffa8c828
PE
10719 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10720 This avoids undefined behavior on integer overflow, and is a bit
10721 more convenient anyway since it is compared to a size_t variable.
10722
c5101a77
PE
10723 Variadic C functions now count arguments with size_t, not int.
10724 This avoids an unnecessary limitation on 64-bit machines, which
10725 caused (substring ...) to crash on large vectors (Bug#8344).
10726 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10727 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10728 All variadic functions and their callers changed accordingly.
c5101a77
PE
10729 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10730 * data.c (arith_driver, float_arith_driver): Likewise.
10731 * editfns.c (general_insert_function): Likewise.
10732 * eval.c (struct backtrace.nargs, interactive_p)
10733 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10734 (funcall_lambda, mark_backtrace): Likewise.
10735 * fns.c (concat): Likewise.
10736 * frame.c (x_set_frame_parameters): Likewise.
10737 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10738 0 if not found, not -1. All callers changed.
10739
dd3f25f7
PE
10740 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10741 (stack_copy_size): Now size_t, not int.
10742 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10743
461c2ab9
JB
107442011-03-28 Juanma Barranquero <lekktu@gmail.com>
10745
10746 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10747 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10748 All callers changed.
10749
10750 * lisp.h (multibyte_char_to_unibyte):
10751 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10752 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10753 * character.h (CHAR_TO_BYTE8):
10754 * cmds.c (internal_self_insert):
10755 * editfns.c (general_insert_function):
10756 * keymap.c (push_key_description):
10757 * search.c (Freplace_match):
10758 * xdisp.c (message_dolog, set_message_1): All callers changed.
10759
f6d62986
SM
107602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10761
10762 * keyboard.c (safe_run_hook_funcall): New function.
10763 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10764 don't set the hook to nil, but remove the offending function instead.
10765 (Qcommand_hook_internal): Remove, unused.
10766 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10767 Vcommand_hook_internal.
10768
10769 * eval.c (enum run_hooks_condition): Remove.
10770 (funcall_nil, funcall_not): New functions.
10771 (run_hook_with_args): Call each function through a `funcall' argument.
10772 Remove `cond' argument, now redundant.
10773 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10774 (Frun_hook_with_args_until_failure): Adjust accordingly.
10775 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10776
1db5b1ad
JB
107772011-03-28 Juanma Barranquero <lekktu@gmail.com>
10778
10779 * dispextern.h (string_buffer_position): Remove declaration.
10780
10781 * print.c (strout): Remove parameter `multibyte', unused since
10782 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10783
10784 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10785 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10786 All callers changed.
10787
10788 * w32.c (_wsa_errlist): Use braces for struct initializers.
10789
10790 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10791 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10792 All callers changed.
10793 (string_buffer_position): Likewise. Also, make static (it's never
10794 used outside xdisp.c).
10795 (cursor_row_p): Remove parameter `w', unused since
10796 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10797 (decode_mode_spec): Remove parameter `precision', introduced during
10798 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10799 All callers changed.
10800
5ffb62aa
JD
108012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10802
10803 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10804
461c2ab9 108052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10806
10807 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10808 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10809 (ns_update_auto_hide_menu_bar): New functions.
10810 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10811 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10812 ns_constrain_all_frames.
10813 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10814 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10815
5c380ffb
JD
108162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10817
10818 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10819
9af30bdf
GM
108202011-03-27 Glenn Morris <rgm@gnu.org>
10821
10822 * syssignal.h: Replace RETSIGTYPE with void.
10823 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10824 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10825 Replace SIGTYPE with void everywhere.
10826 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10827 * s/template.h (SIGTYPE): Remove commented out definition.
10828
e2abce01
JB
108292011-03-26 Eli Zaretskii <eliz@gnu.org>
10830
10831 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10832 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10833
f868cd8a
JB
108342011-03-26 Juanma Barranquero <lekktu@gmail.com>
10835
59eb0929
JB
10836 * w32.c (read_unc_volume): Use parameter `henum', instead of
10837 global variable `wget_enum_handle'.
10838
10839 * keymap.c (describe_vector): Remove parameters `indices' and
10840 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10841 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10842
f868cd8a
JB
10843 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10844
10845 * keyboard.c (timer_check): Remove parameter `do_it_now',
10846 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10847 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10848 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10849
10850 * keyboard.c (read_char):
10851 * w32menu.c (w32_menu_display_help):
10852 * xmenu.c (show_help_event, menu_help_callback):
10853 Adjust calls to `show_help_echo'.
10854
10855 * gtkutil.c (xg_maybe_add_timer):
10856 * keyboard.c (readable_events):
10857 * process.c (wait_reading_process_output):
10858 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10859
10860 * insdel.c (adjust_markers_gap_motion):
10861 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10862 (gap_left, gap_right): Don't call it.
10863
2ecf6fdb
CY
108642011-03-25 Chong Yidong <cyd@stupidchicken.com>
10865
10866 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10867 incurred during fontification.
10868
6b1f9ba4
JB
108692011-03-25 Juanma Barranquero <lekktu@gmail.com>
10870
10871 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10872 (DEFVAR_PER_BUFFER): Don't pass it.
10873
10874 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10875 (scrolling_window): Don't pass it.
10876
0f4a96b5
JB
108772011-03-25 Juanma Barranquero <lekktu@gmail.com>
10878
10879 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10880
10881 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10882 and `suffix'.
10883 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10884 of variables specific to SELinux and computation of `encoded_absname'.
10885
10886 * image.c (XPutPixel): Remove unused variable `height'.
10887
10888 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10889
10890 * unexw32.c (get_section_info): Remove unused variable `section'.
10891
10892 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10893 (system_process_attributes): Remove unused variable `sess'.
10894 (sys_read): Remove unused variable `err'.
10895
10896 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10897 (w32_wnd_proc): Remove unused variable `isdead'.
10898 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10899 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10900 (x_create_tip_frame): Remove unused variable `tem'.
10901
10902 * w32inevt.c (w32_console_read_socket):
10903 Remove unused variable `no_events'.
10904
10905 * w32term.c (x_draw_composite_glyph_string_foreground):
10906 Remove unused variable `width'.
10907
1149507c
JB
109082011-03-24 Juanma Barranquero <lekktu@gmail.com>
10909
10910 * w32term.c (x_set_glyph_string_clipping):
10911 Don't pass uninitialized region to CombineRgn.
10912
9c88f339
JB
109132011-03-23 Juanma Barranquero <lekktu@gmail.com>
10914
10915 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10916 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10917 (Fx_close_connection): Remove unused variable `i'.
10918
10919 * w32font.c (w32font_draw): Return number of glyphs.
10920 (w32font_open_internal): Remove unused variable `i'.
10921 (w32font_driver): Add missing initializer.
10922
10923 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10924 (fill_in_menu): Remove unused variable `items_added'.
10925
10926 * w32term.c (last_mouse_press_frame): Remove static global variable.
10927 (w32_clip_to_row): Remove unused variable `f'.
10928 (x_delete_terminal): Remove unused variable `i'.
10929
10930 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10931 (NOTHING): Remove unused static global variable.
10932 (uniscribe_check_otf): Remove unused variable `table'.
10933 (uniscribe_font_driver): Add missing initializers.
10934
dee091a3
JD
109352011-03-23 Julien Danjou <julien@danjou.info>
10936
10937 * term.c (Fsuspend_tty, Fresume_tty):
10938 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10939 * window.c (temp_output_buffer_show):
10940 * insdel.c (signal_before_change):
10941 * frame.c (Fhandle_switch_frame):
10942 * fileio.c (Fdo_auto_save):
10943 * emacs.c (Fkill_emacs):
10944 * editfns.c (save_excursion_restore):
10945 * cmds.c (internal_self_insert):
10946 * callint.c (Fcall_interactively):
10947 * buffer.c (Fkill_all_local_variables):
10948 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10949 Use Frun_hooks.
0f4a96b5 10950 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10951 unconditionally since it does the check itself.
dee091a3 10952
2c520ab5 109532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10954
c9c49752
PE
10955 Fix more problems found by GCC 4.5.2's static checks.
10956
8abc3f12
PE
10957 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10958 the first time through the loop, since we know p0 < p1 then.
10959 This also avoids a gcc -Wstrict-overflow warning.
10960
a2d26660
PE
10961 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10962 leading to a memory leak, possible in functions like
10963 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10964 of objects (Bug#8318).
a2d26660 10965
916c72e9
PE
10966 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10967 that could (at least in theory) be that large.
10968
19ab8a18
PE
10969 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10970 This is less likely to overflow, and avoids undefined behavior if
10971 overflow does occur. All callers changed. Use strtoul to scan
10972 for the unsigned long integer.
b7cbbd6f
PE
10973 (pint2hrstr): Simplify and tune code slightly.
10974 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10975
f0641eff
PE
10976 * scroll.c (do_scrolling): Work around GCC bug 48228.
10977 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10978
7f650bb9
PE
10979 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10980 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10981 (validate_x_resource_name): Simplify count usage.
10982 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10983
37dd57d1
PE
10984 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10985 fail (Bug#8306).
81e56e61 10986
699979fc 10987 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10988
401bf9b4
PE
10989 * process.c (Fmake_network_process): Use socklen_t, not int,
10990 where POSIX says socklen_t is required in portable programs.
10991 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10992 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10993 (Fmake_network_process, server_accept_connection):
10994 (wait_reading_process_output, read_process_output):
10995 Likewise.
10996
b93aacde
PE
10997 * process.c: Rename or move locals to avoid shadowing.
10998 (list_processes_1, Fmake_network_process):
10999 (read_process_output_error_handler, exec_sentinel_error_handler):
11000 Rename or move locals.
4dc343ee 11001 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11002 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11003 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11004 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11005 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11006
af8a867c 11007 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11008 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11009 Include tparam.h instead, since it declares them.
af8a867c
PE
11010 * cm.h (PC): Remove extern decl; tparam.h now does this.
11011 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11012 * terminfo.c: Include tparam.h, to check interfaces.
11013 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11014 (tparam): Adjust signature to match interface in tparam.h;
11015 this removes some undefined behavior. Check that outstring and len
11016 are zero, which they always are with Emacs.
11017 * tparam.h (PC, BC, UP): New extern decls.
11018
0248044d 11019 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11020 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11021
8ff096c1 11022 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11023 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11024 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11025 (ftfont_list): Remove unused local.
49eaafba
PE
11026 (get_adstyle_property, ftfont_pattern_entity):
11027 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11028 Rename locals to avoid shadowing.
8ff096c1 11029
e2be39f6
PE
11030 * xfont.c (xfont_list_family): Mark var as initialized.
11031
c9735e30
PE
11032 * xml.c (make_dom): Now static.
11033
8f5201ae
PE
11034 * composite.c (composition_compute_stop_pos): Rename local to
11035 avoid shadowing.
b246f932
PE
11036 (composition_reseat_it): Remove unused locals.
11037 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11038 (composition_update_it): Mark var as initialized.
11b61122
PE
11039 (find_automatic_composition): Mark vars as initialized,
11040 with a FIXME (Bug#8290).
8f5201ae 11041
760fbc2c
PE
11042 character.h: Rename locals to avoid shadowing.
11043 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11044 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11045 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11046 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11047 to avoid shadowing.
11048
ff08eb85
PE
11049 * textprop.c (property_change_between_p): Remove; unused.
11050
fc7bf025
PE
11051 * intervals.c (interval_start_pos): Now static.
11052
235d7abc
PE
11053 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11054
44f230aa
SM
11055 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11056 Rename locals to avoid shadowing.
3e7d6594 11057
50060332
PE
11058 * sound.c (wav_play, au_play, Fplay_sound_internal):
11059 Fix pointer signedness.
d01f234b 11060 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11061 (wav_play): Initialize a variable to 0, to prevent undefined
11062 behavior (Bug#8278).
50060332 11063
c4fc4e30
PE
11064 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11065
918436ed
PE
11066 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11067
c939f91b
PE
11068 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11069 clobbering (Bug#8298).
b9c7f648
PE
11070 * sysdep.c (sys_subshell): Likewise.
11071 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11072
6bd8c144
PE
11073 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11074 This should get cleaned up, so that child_setup has the
11075 same signature on all platforms.
11076
7710357c 11077 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11078 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11079
c59da222
CY
110802011-03-22 Chong Yidong <cyd@stupidchicken.com>
11081
11082 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11083 not to be necessary, and produces flickering.
11084
66b87493
GM
110852011-03-20 Glenn Morris <rgm@gnu.org>
11086
11087 * config.in: Remove file.
11088
45b6f6d5
JB
110892011-03-20 Juanma Barranquero <lekktu@gmail.com>
11090
11091 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11092 are now in src/globals.h.
11093 (syms_of_minibuf): Remove spurious & from previous change.
11094
cd394be1 110952011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11096
11097 * minibuf.c (completing-read-function): New variable.
11098 (completing-read-default): Rename from completing-read.
11099 (completing-read): Call completing-read-function.
11100
b14e3e21
CY
111012011-03-19 Juanma Barranquero <lekktu@gmail.com>
11102
11103 * xfaces.c (Fx_load_color_file):
11104 Read color file from absolute filename (bug#8250).
11105
f2b726e6
JB
111062011-03-19 Juanma Barranquero <lekktu@gmail.com>
11107
11108 * makefile.w32-in: Update dependencies.
11109
09f6ff02
EZ
111102011-03-17 Eli Zaretskii <eliz@gnu.org>
11111
11112 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11113
29a6015a
PE
111142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11115
a3a6c54e
PE
11116 Fix more problems found by GCC 4.5.2's static checks.
11117
b766f867
PE
11118 * process.c (make_serial_process_unwind, send_process_trap):
11119 (sigchld_handler): Now static.
11120
be02381c
PE
11121 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11122 That way, the code declares only the vars that it needs.
11123 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11124 * s/cygwin.h (PTY_ITERATION): Likewise.
11125 * s/darwin.h (PTY_ITERATION): Likewise.
11126 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11127
57048744
PE
11128 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11129 * process.c (allocate_pty): Don't declare stb unless it's needed.
11130
7914961c 11131 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11132 (CONSTANTLIM): Remove; unused.
11133 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11134 Define only if needed.
7914961c 11135
b3967b18
PE
11136 * unexelf.c (unexec): Name an expression,
11137 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11138 Use a different way to cause a compilation error if anyone uses
11139 n rather than nn, a way that does not involve shadowing.
73366a00 11140 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11141
29a6015a
PE
11142 * deps.mk (unexalpha.o): Remove; unused.
11143
43cfc33e 11144 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11145 * unexec.h: New file.
ce701a33
PE
11146 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11147 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11148 Depend on unexec.h.
11149 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11150 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11151 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11152 Change as necessary to match prototype in unexec.h.
ce701a33 11153
01f44d5a
PE
11154 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11155 shadowing.
4f63c6bb 11156 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11157
a6670b0b
PE
11158 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11159 Rename locals to avoid shadowing.
11160
cef2010d 11161 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11162 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11163
d4d7173a
PE
11164 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11165
f08b802a
PE
11166 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11167 warning when compiling print.c.
11168
3ddb0639
PE
11169 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11170 instead of using an uninitialized var.
5ad03b97 11171 (font_sort_entities): Mark var as initialized.
3ddb0639 11172
170a2692
PE
11173 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11174
e663c700
PE
11175 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11176 pointers to constants.
89bc529a 11177 (font_parse_fcname): Remove unused vars.
7b81e2d0 11178 (font_delete_unmatched): Now static.
ea838e10 11179 (font_get_spec): Remove; unused.
13a547c6
PE
11180 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11181 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11182 Rename or move locals to avoid shadowing.
e663c700 11183
2a80c887 11184 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11185 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11186
1384fa33 11187 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11188 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11189
8b2c52e9
PE
11190 * alloc.c (mark_backtrace): Move decl from here ...
11191 * lisp.h: ... to here, so that it can be checked.
11192
475545b5 11193 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11194 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11195 (lisp_indirect_variable): Name an expression,
11196 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11197 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11198
b1349114 11199 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11200 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11201 Use const pointer when appropriate.
b1349114 11202
a2928364
PE
11203 * lisp.h (get_system_name, get_operating_system_release):
11204 Move decls here, to check interfaces.
11205 * process.c (get_operating_system_release): Move decl to lisp.h.
11206 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11207 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11208 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11209 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11210 (Fformat_time_string, Fencode_time, Finsert_char):
11211 (Ftranslate_region_internal, Fformat):
11212 Rename or remove local vars to avoid shadowing.
9710023e 11213 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11214
a415e694
PE
11215 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11216 avoid shadowing.
11217
8ef4622d
PE
11218 * lisp.h (eassert): Check that the argument compiles, even if
11219 ENABLE_CHECKING is not defined.
11220
946f9a5b
PE
11221 * data.c (Findirect_variable): Name an expression, to avoid
11222 gcc -Wbad-function-cast warning.
112396d6 11223 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11224 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11225 (Fmake_variable_buffer_local, Fmake_local_variable):
11226 Mark variables as initialized.
52746918 11227 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11228
e5aab7e7 11229 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11230 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11231 Rename locals to avoid shadowing.
dff45157
PE
11232 (mark_stack): Move local variables into the #ifdef region where
11233 they're used.
7bc26fdb
PE
11234 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11235 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11236 needed otherwise.
11237 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11238 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11239 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11240
e5aab7e7
PE
11241 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11242 avoids undefined behavior in theory.
11243
4da60324
PE
11244 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11245
88043301
PE
11246 Use functions, not macros, for up- and down-casing (Bug#8254).
11247 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11248 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11249 to use the following functions instead of these macros.
11250 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11251 EMACS_INT, since callers assume the returned value fits in int.
11252 (upcase1): Likewise, for UPCASE_TABLE.
11253 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11254 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11255 the race-condition problem in the old DOWNCASE.
88043301 11256
19ed5445
PE
11257 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11258 Rename locals to avoid shadowing.
11259 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11260 (regex_compile, re_search_2, re_match_2_internal):
11261 Remove unused local vars.
952db0d7
PE
11262 (FREE_VAR): Rewrite so as not to use empty "else",
11263 which gcc can warn about.
da053e48 11264 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11265 (RETALLOC_IF): Define only if needed.
11266 (WORDCHAR_P): Likewise. This one is never needed, but is used
11267 only in a comment talking about a compiler bug, so put inside
11268 the #if 0 of that comment.
11269 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11270 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11271 Remove; unused.
19ed5445 11272
1f3561e4 11273 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11274 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11275 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11276
ded6f8f7
PE
11277 * search.c (simple_search): Remove unused var.
11278
dbd37a95
PE
11279 * dired.c (compile_pattern): Move decl from here ...
11280 * lisp.h: ... to here, so that it can be checked.
11281 (struct re_registers): New forward decl.
11282
7e47afad
PE
11283 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11284
85f24f61
PE
11285 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11286 All uses changed.
11287 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11288 Rename locals to avoid shadowing.
5671df8f 11289 (Fvertical_motion): Mark locals as initialized.
85f24f61 11290
181aa2be 11291 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11292 (casify_region): Mark local as initialized.
181aa2be 11293
930d429c
PE
11294 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11295
7082eac6
PE
11296 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11297 New macros, so that the caller can use some names other than
11298 gcpro1, gcpro2, etc.
11299 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11300 of the new macros.
11301 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11302 argument, for consistency with GCPRO2_VAR, etc: it is now the
11303 prefix of the variable, not the variable itself. All uses
11304 changed.
38b2c076
PE
11305 * dired.c (directory_files_internal, file_name_completion):
11306 Rename locals to avoid shadowing.
11307
15206ed9
PE
11308 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11309 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11310 dired.c's scmp function, had undefined behavior.
11311 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11312 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11313 * buffer.h: ... to here, because these macros use current_buffer,
11314 and the new implementation with inline functions needs to have
11315 current_buffer in scope now, rather than later when the macros
11316 are used.
11317 (downcase, upcase1): New static inline functions.
11318 (DOWNCASE, UPCASE1): Reimplement using these functions.
11319 This avoids undefined behavior in expressions like
11320 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11321 from race conditions in accessing the global variables
11322 case_temp1 and case_temp2.
11323 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11324 * lisp.h (case_temp1, case_temp2): Remove their decls.
11325 * character.h (ASCII_CHAR_P): Move from here ...
11326 * lisp.h: ... to here, so that the inline functions mentioned
11327 above can use them.
11328
4a6bea26
PE
11329 * dired.c (directory_files_internal_unwind): Now static.
11330
f14b7e14
PE
11331 * fileio.c (file_name_as_directory, directory_file_name):
11332 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11333 Now static.
2893f146
PE
11334 (file_name_as_directory): Use const pointers when appropriate.
11335 (Fexpand_file_name): Likewise. In particular, newdir might
11336 point at constant storage, so make it a const pointer.
fd4ead52 11337 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11338 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11339 signedness issues.
f839df0c
PE
11340 (Fset_file_times, Finsert_file_contents, auto_save_error):
11341 Rename locals to avoid shadowing.
f14b7e14 11342
5716756e 11343 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11344 (Ftry_completion, Fall_completions): Rename or remove locals
11345 to avoid shadowing.
5716756e 11346
b4c3046a
PE
11347 * marker.c (bytepos_to_charpos): Remove; unused.
11348
b45db522
PE
11349 * lisp.h (verify_bytepos, count_markers): New decls,
11350 so that gcc does not warn that these functions aren't declared.
11351
85876d07
PE
11352 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11353 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11354 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11355 (copy_text): Remove unused local var.
85876d07 11356
03d78a21 11357 * filelock.c (within_one_second): Now static.
b3dd38ab 11358 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11359
5df8f01b
PE
11360 * buffer.c (fix_overlays_before): Mark locals as initialized.
11361 (fix_start_end_in_overlays): Likewise. This function should be
11362 simplified by using pointers-to-pointers, but that's a different
11363 matter.
b1d876f1 11364 (switch_to_buffer_1): Now static.
8f54f30a
PE
11365 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11366 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11367
a70072c9 11368 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11369 Fix pointer signedness issue.
edced198
PE
11370 (sys_subshell): Mark local as volatile if checking for lint,
11371 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11372 (MAXPATHLEN): Define only if needed.
a70072c9 11373
a0977c44
PE
11374 * process.c (serial_open, serial_configure): Move decls from here ...
11375 * systty.h: ... to here, so that they can be checked.
11376
a884fdcc
PE
11377 * fns.c (get_random, seed_random): Move extern decls from here ...
11378 * lisp.h: ... to here, so that they can be checked.
11379
604efe86 11380 * sysdep.c (reset_io): Now static.
b8950c94 11381 (wait_for_termination_signal): Remove; unused.
604efe86 11382
38fc62d9
PE
11383 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11384 (copy_keymap_item, append_key, push_text_char_description):
11385 Now static.
1004a21a 11386 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11387 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11388 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11389 (describe_map_tree):
11390 Rename locals to avoid shadowing.
38fc62d9 11391
2f2650da
PE
11392 * keyboard.c: Declare functions static if they are not used elsewhere.
11393 (echo_char, echo_dash, cmd_error, top_level_2):
11394 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11395 (read_char, kbd_buffer_get_event, make_lispy_position):
11396 (make_lispy_event, make_lispy_movement, apply_modifiers):
11397 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11398 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11399 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11400 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11401 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11402
a053e86c 11403 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11404 (mark_kboards): Move decl here ...
11405 * alloc.c (mark_kboards): ... from here.
a053e86c 11406
4752793e
PE
11407 * lisp.h (force_auto_save_soon): New decl.
11408
74f10ca7 11409 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11410 (DEFINE_DUMMY_FUNCTION): New macro.
11411 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11412 Use it.
c03cd23f
PE
11413 (main): Add casts to avoid warnings
11414 if GCC considers string literals to be constants.
74f10ca7 11415
022e70d4
PE
11416 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11417
59d6fe83
PE
11418 * dbusbind.c: Pointer signedness fixes.
11419 (xd_signature, xd_append_arg, xd_initialize):
11420 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11421 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11422 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11423 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11424
78320123
PE
11425 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11426 if GCC considers string literals to be constants.
49cebcca 11427 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11428
35ac2a97
SM
114292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11430
fb103ca9
SM
11431 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11432 (print_preprocess, print_object): New macro to fix last change.
11433
35ac2a97
SM
11434 * print.c (print_preprocess): Don't forget font objects.
11435
62973b41
JB
114362011-03-16 Juanma Barranquero <lekktu@gmail.com>
11437
11438 * emacs.c (USAGE3): Doc fixes.
11439
0e48bb22
AS
114402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11441
11442 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11443 structure.
11444
7684e57b
JB
114452011-03-14 Juanma Barranquero <lekktu@gmail.com>
11446
11447 * lisp.h (VWindow_system, Qfile_name_history):
11448 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11449 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11450 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11451
11452 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11453 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11454
11455 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11456 * w32console.c (detect_input_pending, read_input_pending)
11457 (encode_terminal_code):
11458 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11459 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11460 (w32_system_caret_y, Qfile_name_history):
11461 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11462 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11463 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11464 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11465 * w32proc.c (Qlocal, report_file_error):
11466 * w32term.c (Vwindow_system, updating_frame):
11467 * w32uniscribe.c (initialized, uniscribe_font_driver):
11468 Remove unneeded extern declarations.
11469
2aa46d6c
CY
114702011-03-14 Chong Yidong <cyd@stupidchicken.com>
11471
c96bbc66 11472 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11473
cffc6f3b
CY
114742011-03-13 Chong Yidong <cyd@stupidchicken.com>
11475
11476 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11477 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11478 These macros can no longer be used for assignment.
11479
44f230aa
SM
11480 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11481 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11482 (record_buffer_markers, fetch_buffer_markers): New functions for
11483 recording and fetching special buffer markers.
11484 (set_buffer_internal_1, set_buffer_temp): Use them.
11485
11486 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11487
11488 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11489
11490 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11491 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11492
11493 * xdisp.c (hscroll_window_tree):
11494 (reconsider_clip_changes): Use PT instead of BUF_PT.
11495
d251f04b
EZ
114962011-03-13 Eli Zaretskii <eliz@gnu.org>
11497
11498 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11499 $(EMACS_ROOT)/lib/intprops.h.
11500
f0c77cd1
PE
115012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11502
3eca4629
PE
11503 Fix more problems found by GCC 4.5.2's static checks.
11504
7c86ee98
PE
11505 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11506 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11507 (xg_free_frame_widgets): Make it clear that a local variable is
11508 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11509 (gdk_window_get_screen): Make it clear that this macro is needed
11510 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11511 (int_gtk_range_get_value): New function, which avoids a diagnostic
11512 from gcc -Wbad-function-cast.
11513 (xg_set_toolkit_scroll_bar_thumb): Use it.
11514 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11515 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11516 (get_utf8_string, xg_get_file_with_chooser):
11517 Rename locals to avoid shadowing.
11518 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11519
41729b81
PE
11520 * xgselect.c (xg_select): Remove unused var.
11521
f0c77cd1
PE
11522 * image.c (four_corners_best): Mark locals as initialized.
11523 (gif_load): Initialize transparent_p to zero (Bug#8238).
11524 Mark another local as initialized.
ec6cf4c6 11525 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11526
ce0ad53d 11527 * image.c (clear_image_cache): Now static.
d5d5a617 11528 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11529 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11530 (x_edge_detection): Remove unnecessary cast that
11531 gcc -Wbad-function-cast diagnoses.
2037898d 11532 (gif_load): Fix pointer signedness.
6ae141d6
PE
11533 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11534 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11535
33383987 115362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11537
d32df629
PE
11538 Improve quality of tests for time stamp overflow.
11539 For example, without this patch (encode-time 0 0 0 1 1
11540 1152921504606846976) returns the obviously-bogus value (-948597
11541 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11542 reports time overflow. See
11543 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11544 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11545 * editfns.c: Include limits.h and intprops.h.
11546 (TIME_T_MIN, TIME_T_MAX): New macros.
11547 (time_overflow): Move earlier, to before first use.
11548 (hi_time, lo_time): New functions, for an accurate test for
11549 out-of-range times.
11550 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11551 (Fget_internal_run_time): Don't assume time_t fits in int.
11552 (make_time): Use list2 instead of Fcons twice.
11553 (Fdecode_time): More accurate test for out-of-range times.
11554 (check_tm_member): New function.
11555 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11556 (lisp_time_argument): Don't rely on undefined left-shift and
11557 right-shift behavior when checking for time stamp overflow.
8be6f318 11558
fe31d94c
PE
11559 * editfns.c (time_overflow): New function, refactoring common code.
11560 (Fformat_time_string, Fdecode_time, Fencode_time):
11561 (Fcurrent_time_string): Use it.
11562
8be6f318
PE
11563 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11564 * dired.c (make_time): Move to ...
11565 * editfns.c (make_time): ... here.
11566 * systime.h: Note the move.
11567
09d9db2c 115682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11569
126bc0dc
YM
11570 * fringe.c (update_window_fringes): Remove unused variables.
11571
c47cbdfd
YM
11572 * unexmacosx.c (copy_data_segment): Also copy __got section.
11573 (Bug#8223)
11574
7ac80be9
EZ
115752011-03-12 Eli Zaretskii <eliz@gnu.org>
11576
c96bbc66 11577 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11578 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11579 Constify `char *' arguments and their references according to
11580 prototypes in tparam.h.
11581
ecb0f94d 11582 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11583
7ac80be9
EZ
11584 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11585 Adapt all references accordingly.
11586
11587 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11588
ef1fd07e
TT
115892011-03-11 Tom Tromey <tromey@redhat.com>
11590
11591 * buffer.c (syms_of_buffer): Remove obsolete comment.
11592
7ef4b50c
EZ
115932011-03-11 Eli Zaretskii <eliz@gnu.org>
11594
11595 * termhooks.h (encode_terminal_code): Declare prototype.
11596
11597 * msdos.c (encode_terminal_code): Don't declare prototype.
11598
11599 * term.c (encode_terminal_code): Now external again, used by
11600 w32console.c and msdos.c.
11601
44f230aa
SM
11602 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11603 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11604
4b1ec863 116052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11606
1714f52b 11607 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11608
4b1ec863
PE
11609 * fringe.c (update_window_fringes): Mark locals as initialized
11610 (Bug#8227).
11611 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11612
524c7aa6
PE
11613 * alloc.c (mark_fringe_data): Move decl from here ...
11614 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11615 to check its interface.
11616 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11617
a5c0af81 11618 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11619 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11620 (fontset_font): Mark local as initialized.
a9a06e0b 11621 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11622
b4716021
PE
11623 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11624
811e9bac 11625 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11626 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11627 (x_own_selection, Fx_disown_selection_internal): Rename locals
11628 to avoid shadowing.
11629 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11630
7e3ab302
PE
11631 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11632 so that the caller can use some name other than gcpro1.
11633 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11634 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11635 (Fx_backspace_delete_keys_p):
11636 Use them to avoid shadowing, and rename vars to avoid shadowing.
11637 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11638 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11639 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11640 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11641 Remove unused locals.
7e3ab302
PE
11642 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11643 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11644 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11645 macros.
f78faa98 11646
e2b13473
PE
11647 * xterm.h (x_mouse_leave): New decl.
11648
77f23912
PE
11649 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11650 Remove unused functions.
cdf4ba58
PE
11651 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11652 (x_calc_absolute_position): Now static.
7411c686 11653 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11654 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11655 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11656 unless they are used.
38d0b34a
PE
11657 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11658 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11659 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11660 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11661 (x_error_catcher, x_connection_closed, x_error_handler):
11662 (x_error_quitter, xembed_send_message, x_iconify_frame):
11663 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11664 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11665 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11666
44f230aa
SM
11667 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11668 Rename or move locals to avoid shadowing.
6b463e58 11669 (tty_defined_color, merge_face_heights): Now static.
5967d051 11670 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11671 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11672 does not deduce is never used uninitialized.
73719eba
PE
11673 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11674 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11675
426994c3 11676 * terminal.c (store_terminal_param): Now static.
5489860b 11677
032f1620 11678 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11679 (set_frame_menubar): Remove unused local.
d4323972 11680 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11681 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11682 since they might point to immutable storage.
281585b0
PE
11683 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11684 since it's unused otherwise.
032f1620 11685
367c19e5 11686 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11687 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11688 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11689 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11690 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11691 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11692 does not deduce are never used uninitialized.
70739cbe 11693
07b48fa9
PE
11694 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11695
8868a238 11696 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11697 * window.c (window_loop, size_window):
11698 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11699
7e5cf297 11700 * window.c (display_buffer): Now static.
d6550a9f
PE
11701 (size_window): Mark variables that gcc -Wuninitialized
11702 does not deduce are never used uninitialized.
a586633d
PE
11703 * window.h (check_all_windows): New decl, to forestall
11704 gcc -Wmissing-prototypes diagnostic.
5b555da1 11705 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11706
f6095868
PE
11707 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11708 shadowing.
11709 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11710 Include <limits.h>.
11711 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11712 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11713 (load_charset_map): Mark variables that gcc -Wuninitialized
11714 does not deduce are never used uninitialized.
53df7c11 11715 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11716
f38b440c
PE
11717 * coding.c (coding_set_source, coding_set_destination):
11718 Use "else { /* comment */ }" rather than "else /* comment */;"
11719 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11720 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11721 a block, when the outer 'i' will do.
11722 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11723 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11724 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11725 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11726 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11727 Rename locals to avoid shadowing.
11728 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11729 * coding.c (emacs_mule_char, encode_invocation_designation):
11730 Now static, since they're not used elsewhere.
413bb2db 11731 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11732 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11733 (decode_coding_emacs_mule): Mark variables that gcc
11734 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11735 (detect_coding_iso_2022): Initialize a local variable that might
11736 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11737 this initialization is needed. (Bug#8211)
5f58e762
PE
11738 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11739 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11740 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11741 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11742 Remove unused macros.
f38b440c 11743
232b38b9 11744 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11745 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11746 * character.c (string_count_byte8): Likewise.
232b38b9 11747
fb90da1b
PE
11748 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11749 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11750
fb93dbc2
PE
11751 * chartab.c (copy_sub_char_table): Now static, since it's not used
11752 elsewhere.
5c156ace
PE
11753 (sub_char_table_ref_and_range, char_table_ref_and_range):
11754 Rename locals to avoid shadowing.
bbcd0949 11755 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11756
7d3b3862 11757 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11758 (BIDI_BOB): Remove unused macro.
7d3b3862 11759
6be7d3da
PE
11760 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11761 deduce are never used uninitialized.
c2ed9c8b 11762 * term.c (encode_terminal_code): Likewise.
6be7d3da 11763
75f8807f 11764 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11765
50938595
PE
11766 * tparam.h: New file.
11767 * term.c, tparam.h: Include it.
11768 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11769 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11770 Move these decls to tparam.h, and make them agree with what
11771 is actually in tparam.c. The previous trick of using incompatible
11772 decls in different modules does not conform to the C standard.
11773 All callers of tparam changed to use tparam's actual API.
11774 * tparam.c (tparam1, tparam, tgoto):
11775 Use const pointers where appropriate.
11776
fbceeba2
PE
11777 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11778 * cm.h (struct cm): Likewise.
11779 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11780 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11781 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11782 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11783 (turn_on_face, init_tty): Likewise.
11784 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11785
7f3f1250
PE
11786 * term.c (term_mouse_position): Rename local to avoid shadowing.
11787
e6ca6543
PE
11788 * alloc.c (mark_ttys): Move decl from here ...
11789 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11790
c40f8d15
AS
117912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11792
11793 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11794
cfe0661d
JB
117952011-03-09 Juanma Barranquero <lekktu@gmail.com>
11796
11797 * search.c (compile_pattern_1): Remove argument regp, unused since
11798 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11799 (compile_pattern): Don't pass it.
11800
0afb4571
J
118012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11802
11803 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11804 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11805 for ! HAVE_GTK3.
11806 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11807
11808 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11809
11810 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11811 gdk_window_get_screen, gdk_window_get_geometry,
11812 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11813 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11814 (xg_get_pixbuf_from_pixmap): New function.
11815 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11816 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11817 Call xg_get_pixbuf_from_pixmap instead of
11818 gdk_pixbuf_get_from_drawable.
11819 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11820 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11821 (xg_check_special_colors): Use GtkStyleContext and its functions
11822 for HAVE_GTK3.
11823 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11824 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11825 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11826 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11827 Call gtk_widget_get_preferred_size.
0afb4571
J
11828 (xg_frame_resized): gdk_window_get_geometry only takes 5
11829 parameters.
44f230aa
SM
11830 (xg_win_to_widget, xg_event_is_for_menubar):
11831 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11832 (xg_set_widget_bg): New function.
11833 (delete_cb): New function.
895009e1 11834 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11835 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11836 (xg_set_background_color): Call xg_set_widget_bg.
11837 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11838 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11839 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11840 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11841 if ! HAVE_GTK3.
11842 (update_frame_tool_bar): Call gtk_widget_hide.
11843 (xg_initialize): Use GDK_KEY_g.
11844
11845 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11846 if ! HAVE_GTK3
11847 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11848
11849 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11850 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11851 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11852
1c2cc4ef
JB
118532011-03-08 Juanma Barranquero <lekktu@gmail.com>
11854
11855 * w32xfns.c (select_palette): Check success of RealizePalette against
11856 GDI_ERROR, not zero.
11857
33383987 11858See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11859
11860;; Local Variables:
11861;; coding: utf-8
aac0c6e3
MR
11862;; End:
11863
2f097256 11864 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11865
11866 This file is part of GNU Emacs.
11867
11868 GNU Emacs is free software: you can redistribute it and/or modify
11869 it under the terms of the GNU General Public License as published by
11870 the Free Software Foundation, either version 3 of the License, or
11871 (at your option) any later version.
11872
11873 GNU Emacs is distributed in the hope that it will be useful,
11874 but WITHOUT ANY WARRANTY; without even the implied warranty of
11875 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11876 GNU General Public License for more details.
11877
11878 You should have received a copy of the GNU General Public License
11879 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.