1 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3 * bidi.c (bidi_mirror_char): Revert last change: an int is
4 definitely wide enough here.
6 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
8 Fix integer width and related bugs (Bug#9874).
9 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
10 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
11 (string_bytes, check_sblock, allocate_string_data):
12 (compact_small_strings, Fmake_bool_vector, make_string)
13 (make_unibyte_string, make_multibyte_string)
14 (make_string_from_bytes, make_specified_string)
15 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
16 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
18 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
19 (allocate_pseudovector):
20 Use int, not EMACS_INT, where int is wide enough.
21 (inhibit_garbage_collection, Fgarbage_collect):
22 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
23 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
24 int might not be wide enough.
25 (bidi_cache_search, bidi_cache_find, bidi_init_it)
26 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
27 (bidi_at_paragraph_end, bidi_find_paragraph_start)
28 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
29 (bidi_level_of_next_char, bidi_move_to_visually_next):
30 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
31 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
32 (Fkill_buffer, Fset_buffer_major_mode)
33 (advance_to_char_boundary, Fbuffer_swap_text)
34 (Fset_buffer_multibyte, overlays_at, overlays_in)
35 (overlay_touches_p, struct sortvec, record_overlay_string)
36 (overlay_strings, recenter_overlay_lists)
37 (adjust_overlays_for_insert, adjust_overlays_for_delete)
38 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
39 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
40 (Foverlay_recenter, last_overlay_modification_hooks_used)
41 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
42 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
43 (validate_region): Omit unnecessary test for b <= e,
44 since that's guaranteed by the previous test.
45 (adjust_overlays_for_delete): Avoid pos + length overflow.
46 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
47 (report_overlay_modification):
48 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
49 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
50 Omit pointer cast, which isn't needed anyway, and doesn't work
51 after the EMACS_INT -> ptrdiff_t change.
52 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
154 (ASSURE_DESTINATION, coding_alloc_by_realloc)
155 (coding_alloc_by_making_gap, alloc_destination)
156 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
157 (encode_coding_utf_16, detect_coding_emacs_mule)
158 (decode_coding_emacs_mule, encode_coding_emacs_mule)
159 (detect_coding_iso_2022, decode_coding_iso_2022)
160 (encode_invocation_designation, encode_designation_at_bol)
161 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
162 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
163 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
164 (encode_coding_ccl, encode_coding_raw_text)
165 (detect_coding_charset, decode_coding_charset)
166 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
167 (produce_composition, produce_charset, produce_annotation)
168 (decode_coding, handle_composition_annotation)
169 (handle_charset_annotation, consume_chars, decode_coding_gap)
170 (decode_coding_object, encode_coding_object, detect_coding_system)
171 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
172 (code_convert_region, code_convert_string)
173 (Fdefine_coding_system_internal)
174 (coding_set_source, coding_set_destination):
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
177 (Fdefine_coding_system_internal):
178 Don't assume fixnums fit in int.
179 (decode_coding_gap, decode_coding_object, encode_coding_object)
180 (Fread_coding_system, Fdetect_coding_region)
181 (Funencodable_char_position, Fcheck_coding_systems_region)
182 (get_translation, handle_composition_annotation, consume_chars):
183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
184 (consume_chars): Rewrite to not calculate an address outside buffer.
185 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
186 Don't access memory outside of the args array.
187 (Fdefine_coding_system_internal): Check for charset-id overflow.
188 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
189 result of ENCODE_CHAR.
190 * coding.h: Adjust decls to match defn changes elsewhere.
191 (struct coding_system):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 * composite.c (get_composition_id, find_composition)
194 (run_composition_function, update_compositions)
195 (compose_text, composition_gstring_put_cache)
196 (composition_gstring_p, composition_gstring_width)
197 (fill_gstring_header, fill_gstring_body, autocmp_chars)
198 (composition_compute_stop_pos, composition_reseat_it)
199 (composition_update_it, struct position_record)
200 (find_automatic_composition, composition_adjust_point)
201 (Fcomposition_get_gstring, Ffind_composition_internal):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (update_compositions):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 * composite.h: Adjust decls to match defn changes elsewhere.
206 (struct composition):
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
209 Do not attempt to compute the address of the object just before a
210 buffer; this is not portable.
212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
213 (Faset): Use int, not EMACS_INT, where int is wide enough.
214 (Fstring_to_number): Don't assume fixnums fit in int.
215 (Frem): Don't assume arg is nonnegative.
216 * dbusbind.c (xd_append_arg): Check for integers out of range.
217 (Fdbus_call_method): Don't overflow the timeout int.
218 (extract_signed, extract_unsigned): New functions.
219 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
220 (xd_get_connection_references): Return ptrdiff_t, not int.
222 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
224 Use int, not unsigned, where the dbus API uses int.
225 (Fdbus_message_internal): Don't overflow mtype.
226 (syms_of_dbusbind): Allocate right-sized buffer for integers.
227 * dired.c (directory_files_internal, file_name_completion, scmp)
228 (file_name_completion_stat):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 (file_name_completion): Don't overflow matchcount.
231 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
232 * dispextern.h: Adjust decls to match defn changes elsewhere.
233 (struct text_pos, struct glyph, struct bidi_saved_info)
234 (struct bidi_string_data, struct bidi_it, struct composition_it)
236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
237 (struct display_pos, struct composition_it, struct it):
238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
239 * dispnew.c (increment_matrix_positions)
240 (increment_row_positions, mode_line_string)
241 (marginal_area_string):
242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
243 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
245 (duration_to_sec_usec): New function, to check for overflow better.
246 (Fsleep_for, sit_for): Use it.
247 * doc.c (get_doc_string, store_function_docstring):
248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
249 (get_doc_string, Fsnarf_documentation):
250 Use int, not EMACS_INT, where int is wide enough.
252 Use SAFE_ALLOCA, not alloca.
253 Check for overflow when converting EMACS_INT to off_t.
255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
256 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
257 Don't assume uid_t fits into fixnum.
258 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
259 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
260 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
261 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
262 (general_insert_function)
263 (Finsert_char, make_buffer_string, make_buffer_string_both)
264 (update_buffer_properties, Fbuffer_substring)
265 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
266 (Fsubst_char_in_region, check_translation)
267 (Ftranslate_region_internal, save_restriction_restore, Fformat)
268 (transpose_markers, Ftranspose_regions):
269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
270 (clip_to_bounds): Move to lisp.h as an inline function).
271 (Fconstrain_to_field): Don't assume integers are nonnegative.
272 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
273 (Fsubst_char_in_region, Fsave_restriction):
274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
275 (Femacs_pid): Don't assume pid_t fits into fixnum.
276 (lo_time): Use int, not EMACS_INT, when int suffices.
277 (lisp_time_argument): Check for usec out of range.
278 (Fencode_time): Don't assume fixnum fits in int.
279 (Fuser_login_name, Fuser_full_name): Signal an error
280 if a uid argument is out of range, rather than relying on
282 (Fformat_time_string): Remove now-unnecessary check.
283 lisp_time_argument checks for out-of-range usec now.
284 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
285 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
286 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
287 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
288 (init_cmdargs, Fdump_emacs):
289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
290 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
291 the bottom (typically) 32 bits of the fixnum.
292 * eval.c (specpdl_size, call_debugger):
293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
294 (when_entered_debugger, Fbacktrace_debug):
295 Don't assume fixnum can fit in int.
296 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
297 the object just before a buffer; this is not portable.
298 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
299 (grow_specpdl, unbind_to):
300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
301 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
302 (grow_specpdl): Simplify allocation by using xpalloc.
303 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
304 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
305 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
307 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
310 (Fcopy_file, non_regular_nbytes, read_non_regular)
311 (Finsert_file_contents):
312 Use int, not EMACS_INT, where int is wide enough.
313 (READ_BUF_SIZE): Verify that it fits in int.
314 (Finsert_file_contents): Check that counts are in proper range,
315 rather than assuming fixnums fit into ptrdiff_t etc.
316 Don't assume fixnums fit into int.
317 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
318 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
319 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
320 (string_char_to_byte, string_byte_to_char)
321 (string_make_multibyte, string_to_multibyte)
322 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
323 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
324 (substring_both, Fdelete, internal_equal, Ffillarray)
325 (Fclear_string, mapcar1)
326 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
327 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
328 (larger_vector, make_hash_table, maybe_resize_hash_table)
329 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
330 (Fmaphash, secure_hash):
331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
332 (concat): Check for string index and length overflow.
333 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
336 (larger_vector): New API (vec, incr_min, size_max) replaces old
337 one (vec, new_size, init). This catches size overflow.
338 INIT was removed because it was always Qnil.
340 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
341 the upper bound on a hash table index size.
342 (make_hash_table, maybe_resize_hash_table): Use it.
343 (secure_hash): Computer start_byte and end_byte only after
344 they're known to be in ptrdiff_t range.
345 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
346 (Ffont_get_glyphs, Ffont_at):
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
349 (Flist_fonts, Fopen_font):
350 Don't assume fixnum can fit in int.
351 (check_gstring): Don't assume index can fit in int.
352 (font_match_p): Check that fixnum is a character, not a nonnegative
353 fixnum, since the later code needs to stuff it into an int.
354 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
355 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
356 conversion overflow issues.
357 (Fopen_font): Check for integer out of range.
358 (Ffont_get_glyphs): Don't assume index can fit in int.
359 * font.h: Adjust decls to match defn changes elsewhere.
360 * fontset.c (reorder_font_vector): Redo score calculation to avoid
362 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
363 printmax_t, where ptrdiff_t is wide enough.
364 (Finternal_char_font):
365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
366 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
367 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
368 (Fset_frame_position, x_set_frame_parameters)
369 (x_set_line_spacing, x_set_border_width)
370 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
371 Check that fixnums are in proper range for system types.
372 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
375 Use SAFE_ALLOCA_LISP, not alloca.
376 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
377 intptr_t is wide enough.
378 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
379 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
380 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
381 Check for fixnum out of range.
382 * ftfont.c (ftfont_list): Don't assume index fits in int.
383 Check that fixnums are in proper range for system types.
384 (ftfont_shape_by_flt):
385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
386 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
389 Check that fixnums are in proper range for system types.
390 * gnutls.h: Adjust decls to match defn changes elsewhere.
391 * gtkutil.c (xg_dialog_run):
392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
393 (update_frame_tool_bar):
394 Check that fixnums are in proper range for system types.
395 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
396 (lookup_image): Check that fixnums are in range for system types.
397 * indent.c (last_known_column, last_known_column_point):
398 (current_column_bol_cache):
399 (skip_invisible, current_column, check_display_width):
400 (check_display_width, scan_for_column, current_column_1)
401 (Findent_to, Fcurrent_indentation, position_indentation)
402 (indented_beyond_p, Fmove_to_column, compute_motion):
403 (Fcompute_motion, Fvertical_motion):
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 (last_known_column_modified): Use EMACS_INT, not int.
406 (check_display_width):
408 Check that fixnums and floats are in proper range for system types.
409 (compute_motion): Don't assume index or fixnum fits in int.
410 (compute_motion, Fcompute_motion):
411 Use int, not EMACS_INT, when it is wide enough.
412 (vmotion): Omit local var start_hpos that is always 0; that way
413 we don't need to worry about overflow in expressions involving it.
414 * indent.h: Adjust decls to match defn changes elsewhere.
416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
417 Use int, not EMACS_INT, where int is wide enough.
418 Remove unused members ovstring_chars_done and tab_offset;
420 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
421 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
422 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
423 (make_gap, copy_text, insert, insert_and_inherit)
424 (insert_before_markers, insert_before_markers_and_inherit)
425 (insert_1, count_combining_before, count_combining_after)
426 (insert_1_both, insert_from_string)
427 (insert_from_string_before_markers, insert_from_string_1)
428 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
429 (adjust_after_replace, adjust_after_insert, replace_range)
430 (replace_range_2, del_range, del_range_1, del_range_byte)
431 (del_range_both, del_range_2, modify_region)
432 (prepare_to_modify_buffer, signal_before_change)
433 (signal_after_change, Fcombine_after_change_execute):
434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
435 * intervals.c (traverse_intervals, rotate_right, rotate_left)
436 (balance_an_interval, split_interval_right, split_interval_left)
437 (find_interval, next_interval, update_interval)
438 (adjust_intervals_for_insertion, delete_node, delete_interval)
439 (interval_deletion_adjustment, adjust_intervals_for_deletion)
440 (static_offset_intervals, offset_intervals)
441 (merge_interval_right, merge_interval_left, make_new_interval)
442 (graft_intervals_into_buffer, temp_set_point_both)
443 (temp_set_point, set_point, adjust_for_invis_intang)
444 (set_point_both, move_if_not_intangible, get_property_and_range)
445 (get_local_map, copy_intervals, copy_intervals_to_string)
446 (compare_string_intervals, set_intervals_multibyte_1):
447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
448 * intervals.h: Adjust decls to match defn changes elsewhere.
450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
451 * keyboard.c (this_command_key_count, this_single_command_key_start)
452 (before_command_key_count, before_command_echo_length, echo_now)
453 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
454 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
455 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
456 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
458 (last_non_minibuf_size, last_point_position, echo_truncate)
459 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
460 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
461 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
462 (stuff_buffered_input):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (last_auto_save, command_loop_1, read_char):
465 Use EMACS_INT, not int, to avoid integer overflow.
466 (record_char): Avoid overflow in total_keys computation.
467 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
468 * keyboard.h: Adjust decls to match defn changes elsewhere.
469 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
470 (Fkey_description, Fdescribe_vector, Flookup_key):
471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
472 (click_position): New function, to check that positions are in range.
473 (Fcurrent_active_maps):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (Faccessible_keymaps, Fkey_description):
477 (preferred_sequence_p):
478 Don't assume fixnum can fit into int.
479 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
480 Check for integer overflow in size calculations.
481 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
482 avoid mishandling large integers.
483 * lisp.h: Adjust decls to match defn changes elsewhere.
484 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
485 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
486 (struct Lisp_Marker):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (clip_to_bounds): Now an inline function, moved here from editfns.c.
489 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
490 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
492 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
493 Assume the arg has valid form, since it always does.
494 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
495 unsigned integer system type.
496 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
497 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
500 (duration_to_sec_usec): New decl.
501 * lread.c (read_from_string_index, read_from_string_index_byte)
502 (read_from_string_limit, readchar, unreadchar, openp)
503 (read_internal_start, read1, oblookup):
504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
505 (Fload, readevalloop, Feval_buffer, Feval_region):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 (openp): Check for out-of-range argument to 'access'.
508 (read1): Use int, not EMACS_INT, where int is wide enough.
509 Don't assume fixnum fits into int.
510 Fix off-by-one error that can read outside a buffer.
511 (read_filtered_event): Use duration_to_sec_usec
512 to do proper overflow checking on durations.
513 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
515 (Fexecute_kbd_macro):
516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
517 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
518 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
519 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
520 (set_marker_both, set_marker_restricted_both, marker_position)
521 (marker_byte_position, Fbuffer_has_markers_at):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
524 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
525 It now merely ensures that the menu is large enough, without
526 necessarily growing it, as this avoids some integer overflow issues.
528 (keymap_panes, parse_single_submenu, Fx_popup_menu):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
531 Use SAFE_ALLOCA_LISP, not alloca.
532 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
533 to EMACS_INT. Check that fixnums are in proper range for system types.
534 * minibuf.c (minibuf_prompt_width, string_to_object)
535 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
536 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
538 (get_minibuffer, read_minibuf_unwind):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
541 this simplifies overflow checking. All callers changed.
542 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
545 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
546 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
547 Check that fixnums are in proper range for system types.
548 (Fx_create_frame, Fx_show_tip):
549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
550 * nsfont.m (ns_findfonts, nsfont_list_family):
551 Don't assume fixnum fits in long.
552 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
556 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
559 (PRINTDECLARE, PRINTPREPARE):
560 (strout, print_string):
561 (print, print_preprocess, print_check_string_charset_prop)
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
565 (temp_output_buffer_setup, Fprin1_to_string, print_object):
566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
567 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
568 (printchar, strout): Use xpalloc to catch size calculation overflow.
569 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
570 (print_error_message): Use SAFE_ALLOCA, not alloca.
571 (print_object): Use int, not EMACS_INT, where int is wide enough.
572 (print_depth, new_backquote_output, print_number_index):
573 Use ptrdiff_t, not int, where int might not be wide enough.
574 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
575 (Fset_process_window_size, Fformat_network_address)
576 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
578 Check that fixnums are in proper range for system types.
579 (Fsignal_process): Simplify by avoiding a goto.
580 Check for process-ids out of pid_t range rather than relying on
582 (process_tick, update_tick): Use EMACS_INT, not int.
583 (Fformat_network_address, read_process_output, send_process)
584 (Fprocess_send_region, status_notify):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
587 (wait_reading_process_output, read_process_output, exec_sentinel):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
590 (Faccept_process_output): Use duration_to_sec_usec to do proper
591 overflow checking on durations.
592 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
593 Don't assume pid_t fits in int.
594 * process.h (struct Lisp_Process): Members tick and update_tick
595 are now of type EMACS_INT, not int.
596 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
597 configured --with-wide-int.
598 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
599 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
600 * search.c (looking_at_1, string_match_1):
601 (fast_string_match, fast_c_string_match_ignore_case)
602 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
603 (scan_newline, find_before_next_newline, search_command)
604 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
605 (set_search_regs, wordify):
608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
609 (string_match_1, search_buffer, set_search_regs):
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (wordify): Check for overflow in size calculation.
613 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
614 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
615 Check that fixnums are in proper range for system types.
616 * sound.c (struct sound_device)
617 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
619 (Fplay_sound_internal):
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 * syntax.c (struct lisp_parse_state, find_start_modiff)
622 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
623 (Fparse_partial_sexp):
624 Don't assume fixnums can fit in int.
625 (struct lisp_parse_state, find_start_pos, find_start_value)
626 (find_start_value_byte, find_start_begv)
627 (update_syntax_table, char_quoted, dec_bytepos)
628 (find_defun_start, prev_char_comend_first, back_comment):
629 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
630 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (Finternal_describe_syntax_value): Check that match_lisp is a
633 character, not an integer, since the code stuffs it into int.
634 (scan_words, scan_sexps_forward):
635 Check that fixnums are in proper range for system types.
637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
638 (scan_sexps_forward):
639 Use CHARACTERP, not INTEGERP, since the value must fit into int.
640 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
641 * syntax.h: Adjust decls to match defn changes elsewhere.
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
645 MOST_POSITIVE_FIXNUM.
646 * sysdep.c (wait_for_termination_1, wait_for_termination)
647 (interruptible_wait_for_termination, mkdir):
648 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
649 (emacs_read, emacs_write):
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
652 and double all fit in int.
653 * term.c (set_tty_color_mode):
654 Check that fixnums are in proper range for system types.
655 * termhooks.h (struct input_event):
656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
657 * textprop.c (validate_interval_range, interval_of)
658 (Fadd_text_properties, set_text_properties_1)
659 (Fremove_text_properties, Fremove_list_of_text_properties)
660 (Ftext_property_any, Ftext_property_not_all)
661 (copy_text_properties, text_property_list, extend_property_ranges)
662 (verify_interval_modification):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (Fnext_single_char_property_change)
665 (Fprevious_single_char_property_change):
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
667 (copy_text_properties):
668 Check for integer overflow in index calculation.
669 * undo.c (last_boundary_position, record_point, record_insert)
670 (record_delete, record_marker_adjustment, record_change)
671 (record_property_change):
672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
673 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
675 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
676 (Fx_hide_tip, Fx_file_dialog):
677 * w32menu.c (set_frame_menubar):
678 Use ptrdiff_t, not int, for consistency with rest of code.
679 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
680 (select_window, Fdelete_other_windows_internal)
681 (window_scroll_pixel_based, window_scroll_line_based)
682 (Frecenter, Fset_window_configuration):
683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
684 (Fset_window_hscroll, run_window_configuration_change_hook)
685 (set_window_buffer, temp_output_buffer_show, scroll_command)
686 (Fscroll_other_window, Frecenter):
687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
688 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
689 Don't assume fixnum fits in int.
690 (Fset_window_scroll_bars):
691 Check that fixnums are in proper range for system types.
692 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
693 (string_pos, c_string_pos, number_of_chars, init_iterator)
694 (in_ellipses_for_invisible_text_p, init_from_display_pos)
695 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
696 (compute_display_string_end, handle_face_prop)
697 (face_before_or_after_it_pos, handle_invisible_prop)
698 (handle_display_prop, handle_display_spec, handle_single_display_spec)
699 (display_prop_intangible_p, string_buffer_position_lim)
700 (string_buffer_position, handle_composition_prop, load_overlay_strings)
701 (get_overlay_strings_1, get_overlay_strings)
702 (iterate_out_of_display_property, forward_to_next_line_start)
703 (back_to_previous_visible_line_start, reseat, reseat_to_string)
704 (get_next_display_element, set_iterator_to_next)
705 (get_visually_first_element, compute_stop_pos_backwards)
706 (handle_stop_backwards, next_element_from_buffer)
707 (move_it_in_display_line_to, move_it_in_display_line)
708 (move_it_to, move_it_vertically_backward, move_it_by_lines)
709 (add_to_log, message_dolog, message_log_check_duplicate)
710 (message2, message2_nolog, message3, message3_nolog
711 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
712 (current_message_1, truncate_echo_area, truncate_message_1)
713 (set_message, set_message_1, store_mode_line_noprop)
714 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
715 (text_outside_line_unchanged_p, check_point_in_composition)
716 (reconsider_clip_changes)
717 (redisplay_internal, set_cursor_from_row, try_scrolling)
718 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
719 (redisplay_window, find_last_unchanged_at_beg_row)
720 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
721 (trailing_whitespace_p, find_row_edges, display_line)
722 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
723 (display_mode_element, store_mode_line_string)
724 (pint2str, pint2hrstr, decode_mode_spec)
725 (display_count_lines, display_string, draw_glyphs)
726 (x_produce_glyphs, x_insert_glyphs)
727 (rows_from_pos_range, mouse_face_from_buffer_pos)
728 (fast_find_string_pos, mouse_face_from_string_pos)
729 (note_mode_line_or_margin_highlight, note_mouse_highlight):
730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
731 (safe_call, init_from_display_pos, handle_fontified_prop)
732 (handle_single_display_spec, load_overlay_strings)
733 (with_echo_area_buffer, setup_echo_area_for_printing)
734 (display_echo_area, echo_area_display)
735 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
736 (update_tool_bar, hscroll_window_tree, redisplay_internal)
737 (redisplay_window, dump_glyph_row, display_mode_line)
738 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
739 (handle_display_spec, display_prop_string_p):
740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
741 (handle_single_display_spec, build_desired_tool_bar_string)
742 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
743 (get_specified_cursor_type):
744 Check that fixnums are in proper range for system types.
745 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
747 Don't assume fixnums fit in int.
748 (compare_overlay_entries):
749 Avoid mishandling comparisons due to subtraction overflow.
750 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
751 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
752 (handle_tool_bar_click):
753 Use int, not unsigned, since we prefer signed and the signedness
755 (get_next_display_element, next_element_from_display_vector):
756 Use int, not EMACS_INT, when int is wide enough.
757 (start_hourglass): Use duration_to_sec_usec to do proper
758 overflow checking on durations.
759 * xfaces.c (Fbitmap_spec_p):
760 Check that fixnums are in proper range for system types.
761 (compare_fonts_by_sort_order):
762 Avoid mishandling comparisons due to subtraction overflow.
763 (Fx_family_fonts, realize_basic_faces):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 Don't assume fixnum fits in int.
767 Use SAFE_ALLOCA_LISP, not alloca.
768 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
769 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
770 (face_at_buffer_position, face_for_overlay_string)
771 (face_at_string_position):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
774 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
776 Check that fixnums are in proper range for system types.
777 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
778 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
780 (Fx_change_window_property): Don't assume fixnums fit in int.
781 * xfont.c (xfont_chars_supported):
782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
783 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
784 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * xml.c (parse_region):
787 * xrdb.c (magic_file_p):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
790 (x_get_local_selection, x_reply_selection_request)
791 (x_handle_selection_request, wait_for_property_change):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
794 short is wide enough.
795 (x_send_client_event): Don't assume fixnum fits in int.
796 * xterm.c (x_x_to_emacs_modifiers):
797 Don't assume EMACS_INT overflows nicely into int.
798 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
800 (handle_one_xevent): NATNUMP can eval its arg twice.
801 (x_connection_closed):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 * xterm.h: Adjust decls to match defn changes elsewhere.
804 (struct scroll_bar): Use struct vectorlike_header
805 rather than rolling our own approximation.
806 (SCROLL_BAR_VEC_SIZE): Remove; not used.
808 2012-05-25 Glenn Morris <rgm@gnu.org>
810 * lisp.mk (lisp): Update for more files being compiled now.
812 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
814 * lread.c: Remove `read_pure' which makes no difference.
815 (read_pure): Remove var.
816 (unreadpure): Remove function.
817 (readevalloop): Don't call read_list with -1 flag.
818 (read1, read_vector): Don't test read_pure any more.
819 (read_list): Simplify.
821 * fileio.c, character.h: Minor style tweaks.
823 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
825 * window.h (clip_changed): Remove useless declaration.
827 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
829 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
830 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
832 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
835 This directory predates autoconf and is no longer needed nowadays.
836 Move its few remaining bits of functionality to where they're needed.
837 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
838 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
839 * m/template.h: Remove.
840 * Makefile.in (M_FILE): Remove. All uses removed.
841 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
842 * lisp.h (USE_LSB_TAG):
843 * mem-limits.h (EXCEEDS_LISP_PTR):
844 Use VAL_MAX, not VALBITS, in #if.
845 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
846 (EMACS_UINT): Define unconditionally now.
847 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
848 (BITS_PER_EMACS_INT): New constants, replacing
849 what used to be in config.h, but not useful in #if.
850 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
851 define them any more.
852 (VAL_MAX): New macro.
854 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
855 BITS_PER_EMACS_INT, in #if.
856 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
857 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
858 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
859 * s/ms-w32.h (DATA_START):
860 Move here from removed file m/intel386.h.
861 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
862 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
864 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
867 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
868 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
870 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
871 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
872 * textprop.c, tparam.c (NULL): Remove.
873 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
874 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
875 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
876 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
877 * xterm.c (input_signal_count): Assume volatile works.
879 2012-05-21 Ken Brown <kbrown@cornell.edu>
881 * xgselect.c (xg_select): Fix first argument in call to 'select'
884 2012-05-20 Ken Brown <kbrown@cornell.edu>
886 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
887 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
889 2012-05-19 Ken Brown <kbrown@cornell.edu>
891 * xfns.c (x_in_use): Remove `static' qualifier.
892 * xterm.h (x_in_use): Declare.
893 * xgselect.c: Include xterm.h.
894 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
895 and `display_arg' (bug#9754).
897 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
899 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
901 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
902 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
904 2012-05-18 Eli Zaretskii <eliz@gnu.org>
906 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
908 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
909 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
911 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
912 reference to image_cache->refcount.
913 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
915 2012-05-17 Juri Linkov <juri@jurta.org>
917 * search.c (Fword_search_regexp, Fword_search_backward)
918 (Fword_search_forward, Fword_search_backward_lax)
919 (Fword_search_forward_lax): Move functions to isearch.el
920 (bug#10145, bug#11381).
922 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
924 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
926 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
928 * lread.c (init_obarray): Declare Qt and Qnil as special.
930 2012-05-14 Glenn Morris <rgm@gnu.org>
932 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
933 Put "libexec" before "bin", for the sake of init_callproc_1.
935 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
937 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
939 * unexaix.c: Port to more-recent AIX compilers.
940 (report_error, report_error_1, make_hdr, copy_sym)
941 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
942 Make arguments const char *, not char *, to avoid violations of C
943 standard and to fix some AIX warnings reported by Gilles Pion.
945 2012-05-14 Eli Zaretskii <eliz@gnu.org>
947 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
948 already have overlays loaded.
949 (handle_single_display_spec): Before returning without displaying
950 fringe bitmap, synchronize the bidi iterator with the main display
951 iterator, by calling iterate_out_of_display_property.
952 (iterate_out_of_display_property): Detect buffer iteration by
953 testing that it->string is a Lisp string.
954 (get_next_display_element): When the current object is exhausted,
955 and there's something on it->stack, call set_iterator_to_next to
956 proceed with what's on the stack, instead of returning zero.
957 (set_iterator_to_next): If called at the end of a Lisp string,
958 proceed to consider_string_end without incrementing string
959 position. Don't increment display vector index past the end of
960 the display vector. (Bug#11417)
961 (pos_visible_p): Don't report a position visible when move_it_to
962 stopped at the last line of window, which happens to be scanned
963 backwards by the bidi iteration. (Bug#11464)
965 2012-05-14 Eli Zaretskii <eliz@gnu.org>
967 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
968 and right-margin display specs even if the spec is invalid or we
969 are on a TTY, and thus unable to display on the fringes. That's
970 because the text with the property will not be displayed anyway,
971 so we need to signal to the caller that this is a "replacing"
972 display spec. This fixes display when the spec is invalid or we
975 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
977 * unexaix.c (make_hdr): Fix typo in prototype.
978 This bug broke the build on AIX. Problem reported by Gilles Pion.
980 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
982 * keyboard.c (kbd_buffer_get_event): Read special events also in
983 batch mode. (Bug#11415)
985 2012-05-12 Glenn Morris <rgm@gnu.org>
987 * ns.mk: Update for ns_appbindir no longer having trailing "/".
989 2012-05-12 Eli Zaretskii <eliz@gnu.org>
991 * lisp.mk (lisp): Add newcomment.elc.
993 2012-05-12 Glenn Morris <rgm@gnu.org>
995 * Makefile.in (MKDIR_P): New, set by configure.
996 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
998 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1000 Remove unused function hourglass_started.
1001 * dispextern.h (hourglass_started):
1002 * w32fns.c (hourglass_started):
1003 * xdisp.c (hourglass_started): Remove.
1005 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1007 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1008 Update dependencies.
1010 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1012 * xgselect.c (xg_select): Put maxfds+1 into a var.
1013 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1015 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1017 2012-05-10 Dave Abrahams <dave@boostpro.com>
1019 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1020 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1022 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1024 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1025 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1026 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1027 Initialize xd_registered_buses.
1029 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1031 Untag more efficiently if USE_LSB_TAG.
1032 This is based on a proposal by YAMAMOTO Mitsuharu in
1033 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1034 For an admittedly artificial (nth 8000 longlist) benchmark on
1035 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1036 Emacs's overall text size by 1%.
1037 * lisp.h (XUNTAG): New macro.
1038 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1039 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1040 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1041 * eval.c (Fautoload):
1042 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1043 * frame.h (XFRAME): Use XUNTAG.
1045 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1046 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1047 Remove unportable assumptions about print widths of types like
1049 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1050 intptr_t when converting between pointer and integer, to avoid GCC
1051 warnings about wrong width.
1053 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1055 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1056 stack for each reader_thread, instead of defaulting to 8MB
1057 determined by the linker. This avoids failures in creating
1058 subprocesses on Windows 7, see the discussion in this thread:
1059 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1061 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1063 Fix up display of the *Minibuf-0* buffer in the mini window.
1064 * keyboard.c (read_char): Don't clear the echo area if there's no
1066 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1067 contents of *Minibuf-0*) if there's no message displayed in its stead.
1069 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1071 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1074 2012-05-06 Chong Yidong <cyd@gnu.org>
1076 * lisp.mk (lisp): Update.
1078 2012-05-05 Jim Meyering <meyering@redhat.com>
1080 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1082 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1084 * data.c (PUT_ERROR): New macro.
1085 (syms_of_data): Use it. Add new error type `user-error'.
1086 * undo.c (user_error): New function.
1087 (Fprimitive_undo): Use it.
1088 * print.c (print_error_message): Adjust print style for `user-error'.
1089 * keyboard.c (user_error): New function.
1090 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1092 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1094 Do not limit current-time-string to years 1000..9999.
1095 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1096 (Fcurrent_time_string): Support any year that is supported by the
1097 underlying localtime representation. Don't use asctime, as it
1098 has undefined behavior for years outside the range -999..9999.
1100 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1102 Fix race conditions involving setenv, gmtime, localtime, asctime.
1103 Without this fix, interrupts could mess up code that uses these
1104 nonreentrant functions, since setting TZ invalidates existing
1105 tm_zone or tzname values, and since most of these functions return
1106 pointers to static storage.
1107 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1108 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1109 Grow the critical sections to include not just invoking
1110 localtime/gmtime, but also accessing these functions' results
1111 including their tm_zone values if any, and any related TZ setting.
1112 (format_time_string): Last arg is now struct tm *, not struct tm **,
1113 so that the struct tm is saved in the critical section.
1114 All callers changed. Simplify allocation of initial buffer, partly
1115 motivated by the fact that memory allocation needs to be outside
1116 the critical section.
1118 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1120 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1121 with RESET_INTERVAL.
1123 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1124 Remove duplicated buffer name initialization.
1126 2012-05-02 Jim Meyering <jim@meyering.net>
1128 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1130 * xfns.c (x_window): Use xstrdup (Bug#11375).
1132 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1134 * xdisp.c (pos_visible_p): If already at a newline from the
1135 display string before the 'while' loop, don't walk back the glyphs
1136 from it3.glyph_row. Solves assertion violation when the display
1137 string begins with a newline (egg.el). (Bug#11367)
1139 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1141 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1144 2012-05-01 Glenn Morris <rgm@gnu.org>
1146 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1147 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1148 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1149 All were removed before 23.1.
1151 * dispnew.c: Remove HAVE_LIBNCURSES test;
1152 it is always true on relevant platforms.
1154 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1155 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1157 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1159 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1161 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1162 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1165 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1167 Do not avoid creating empty evaporating overlays (Bug#9642).
1168 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1169 That is, do not delete an evaporating overlay if it becomes
1170 empty after its bounds are adjusted to fit within its buffer.
1171 This fix caused other problems, and I'm reverting it until we get
1172 to the bottom of them.
1174 2012-04-27 Chong Yidong <cyd@gnu.org>
1176 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1178 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1180 * xdisp.c (pos_visible_p): If the window start position is beyond
1181 ZV, start the display from buffer beginning. Prevents assertion
1182 violation in init_iterator when the minibuffer window is scrolled
1185 * window.c (window_scroll_pixel_based): Likewise.
1187 2012-04-27 Chong Yidong <cyd@gnu.org>
1189 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1191 2012-04-27 Glenn Morris <rgm@gnu.org>
1193 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1194 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1196 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1198 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1199 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1201 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1203 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1204 display element, check also the underlying string or buffer
1205 character. (Bug#11341)
1207 * w32menu.c: Include w32heap.h.
1208 (add_menu_item): If the call to AppendMenuW (via
1209 unicode_append_menu) fails, disable Unicode menus only if we are
1210 running on Windows 9X/Me.
1212 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1214 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1215 (xgetint): Add missing shift for LSB tags.
1217 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1219 * keyboard.c (read_char): Don't wipe echo area for select window
1220 events: These might get delayed via `mouse-autoselect-window'
1223 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1225 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1226 manipulation of :loaded-from data.
1228 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1230 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1231 now a cons (bug#11311).
1233 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1235 Do not create empty overlays with the evaporate property (Bug#9642).
1236 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1237 if it becomes empty after its bounds are adjusted to fit within
1238 its buffer. Without this fix, in a nonempty buffer (let ((o
1239 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1240 yields an empty overlay that has the evaporate property, which is
1241 not supposed to happen.
1243 Fix minor GTK3 problems found by static checking.
1244 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1245 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1246 (struct _EmacsFixedClass, emacs_fixed_get_type):
1247 Move decls here from emacsgtkfixed.h, since they needn't be public.
1248 (emacs_fixed_get_type): Now static.
1249 (emacs_fixed_class_init): Omit unused local.
1250 (emacs_fixed_child_type): Remove; unused.
1251 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1252 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1253 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1254 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1255 (EMACS_FIXED_GET_CLASS): Remove; unused.
1256 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1258 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1259 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1261 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1263 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1264 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1265 (__malloc_size_t, __malloc_ptrdiff_t):
1266 Remove. All uses removed, replaced by the definiens if needed,
1267 since we can assume C89 or better now.
1268 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1269 (protect_malloc_state, align, get_contiguous_space)
1270 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1271 (malloc_atfork_handler_child, malloc_enable_thread)
1272 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1273 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1274 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1275 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1276 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1277 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1278 Define using prototypes, not old style.
1279 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1280 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1281 (align): Don't assume that signed integer overflow wraps around.
1282 Omit unused local var.
1283 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1284 (_free_internal_nolock, memalign, mallochook, reallochook):
1285 Omit no-longer-needed casts.
1286 (valloc): Use getpagesize, not __getpagesize.
1287 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1288 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1290 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1292 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1294 Move functions from C to Lisp. Make non-blocking method calls
1295 the default. Implement further D-Bus standard interfaces.
1297 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1298 (QCdbus_request_name_allow_replacement)
1299 (QCdbus_request_name_replace_existing)
1300 (QCdbus_request_name_do_not_queue)
1301 (QCdbus_request_name_reply_primary_owner)
1302 (QCdbus_request_name_reply_in_queue)
1303 (QCdbus_request_name_reply_exists)
1304 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1305 (QCdbus_registered_serial, QCdbus_registered_method)
1306 (QCdbus_registered_signal): New Lisp objects.
1307 (XD_DEBUG_MESSAGE): Use sizeof.
1308 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1309 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1310 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1311 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1312 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1313 (xd_signature, xd_append_arg): Allow float for integer types.
1314 (xd_get_connection_references): New function.
1315 (xd_get_connection_address): Rename from xd_initialize.
1316 Return cached address.
1317 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1318 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1320 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1321 Return number of refcounts.
1322 (Fdbus_get_unique_name): Make stronger parameter check.
1323 (Fdbus_message_internal): New defun.
1324 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1325 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1326 (Fdbus_send_signal, Fdbus_register_service)
1327 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1328 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1329 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1330 (Vdbus_compiled_version, Vdbus_runtime_version)
1331 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1332 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1333 (Vdbus_message_type_signal): New defvars.
1334 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1337 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1339 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1340 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1341 Do not assume ptrdiff_t is the same width as 'int'.
1343 * alloc.c: Handle unusual debugging option combinations.
1344 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1345 since the two debugging options are incompatible.
1346 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1348 (mem_init, mem_insert, mem_insert_fixup):
1349 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1350 (NEED_MEM_INSERT): Remove; no longer needed.
1352 2012-04-22 Leo Liu <sdl.web@gmail.com>
1354 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1356 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1358 * sysdep.c [__FreeBSD__]: Minor cleanups.
1359 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1360 Use Emacs indenting style more consistently. Avoid some casts.
1361 Use 'double' consistently rather than mixing 'float' and 'double'.
1363 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1365 * sysdep.c (list_system_processes, system_process_attributes):
1366 Add implementation for FreeBSD (Bug#5243).
1368 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1370 * lisp.mk (lisp): Update.
1372 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1374 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1375 It is never used otherwise.
1377 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1379 * print.c (print_preprocess): Only check print_depth if print-circle
1381 (print_object): Check for cycles even when print-circle is nil and
1382 print-gensym is t, but only check print_depth if print-circle is nil.
1384 2012-04-20 Chong Yidong <cyd@gnu.org>
1386 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1387 set the status to "failed" and ensure that sentinel is run.
1389 2012-04-20 Glenn Morris <rgm@gnu.org>
1391 * process.c (Fset_process_inherit_coding_system_flag)
1392 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1393 (Fmake_network_process, Fmake_serial_process): Doc fix.
1395 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1397 * xdisp.c (string_buffer_position_lim): Limit starting position to
1399 (set_cursor_from_row): If called for a mode-line or header-line
1400 row, return zero immediately.
1401 (try_cursor_movement): If inside continuation line, don't back up
1402 farther than the first row after the header line, if any.
1403 Don't consider the header-line row as "partially visible", even if
1404 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1406 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1408 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1411 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1412 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1414 configure: new option --enable-gcc-warnings (Bug#11207)
1415 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1416 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1417 (ALL_CFLAGS): Use new macros rather than old.
1418 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1419 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1420 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1421 -Wunused-result, -Wunused-variable. This should go away once
1422 the Emacs and Gnulib regex code is merged.
1423 (xmalloc, xrealloc): Now static.
1425 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1427 * dired.c (Fsystem_groups): Remove unused local.
1429 2012-04-17 Glenn Morris <rgm@gnu.org>
1431 * dired.c (Fsystem_users): Doc fix.
1433 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1435 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1436 (syms_of_dired): Add them.
1438 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1440 Fix minor alloc.c problems found by static checking.
1441 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1442 New extern decls, to avoid calling undeclared functions.
1443 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1444 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1445 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1446 (NEED_MEM_INSERT): New macro.
1447 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1448 Remove one incorrect comment and fix another.
1450 Fix minor ralloc.c problems found by static checking.
1451 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1452 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1453 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1454 (r_alloc_sbrk): Now static.
1456 Improve ralloc.c interface checking.
1457 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1458 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1459 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1460 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1461 [REL_ALLOC]: ... to here, to check interface.
1462 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1463 Remove decls. This fixes an "It stinks!".
1465 * alloc.c (which_symbols): Fix alignment issue / type clash.
1467 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1469 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1470 (struct Lisp_Misc_Any): Likewise.
1471 (struct Lisp_Free): Likewise.
1472 * alloc.c (union aligned_Lisp_Symbol): Define.
1473 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1474 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1475 (union aligned_Lisp_Misc): Define.
1476 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1477 aligned_Lisp_Misc instead of union Lisp_Misc.
1478 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1480 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1482 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1483 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1484 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1485 * s/netbsd.h, s/sol2-6.h:
1486 Remove definition of GC_MARK_STACK, since the default now works.
1487 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1488 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1489 no longer the default.
1490 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1492 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1494 * lread.c (lisp_file_lexically_bound_p):
1495 Fix hang at ";-*-\n" (bug#11238).
1497 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1499 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1500 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1502 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1504 * nsterm.m (constrainFrameRect): Always constrain when there is only
1505 one screen (Bug#10962).
1507 2012-04-13 Ken Brown <kbrown@cornell.edu>
1509 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1511 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1513 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1515 2012-04-11 Daniel Colascione <dancol@dancol.org>
1517 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1518 against is gone. It's better to use vfork now so that when Cygwin
1519 gains a new, working vfork, we use it automatically (bug#10398).
1521 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1523 * window.c (save_window_save): Obey window-point-insertion-type.
1525 2012-04-11 Glenn Morris <rgm@gnu.org>
1527 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1529 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1531 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1533 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1535 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1536 (force_quit_count): New var.
1537 (handle_interrupt): Use it.
1539 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1541 * w32.c (w32_delayed_load): Record the full path of the library
1542 being loaded (bug#10424).
1544 2012-04-09 Glenn Morris <rgm@gnu.org>
1546 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1547 not just in the obarray, before snarfing them. (Bug#11036)
1549 * Makefile.in ($(leimdir)/leim-list.el):
1550 Pass EMACS rather than BUILT_EMACS.
1552 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1554 * process.c (make_process):
1555 * process.h: Add integer `gnutls_handshakes_tried' member to
1558 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1559 Add convenience `GNUTLS_LOG2i' macro.
1561 * gnutls.c (gnutls_log_function2i): Convenience log function.
1562 (emacs_gnutls_read): Use new log functions,
1563 `gnutls_handshakes_tried' process member, and
1564 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1565 attempts per process (connection).
1567 2012-04-09 Chong Yidong <cyd@gnu.org>
1569 * eval.c (Fuser_variable_p, user_variable_p_eh)
1570 (lisp_indirect_variable): Functions deleted.
1571 (Fdefvar): Caller changed.
1573 * callint.c (Finteractive, Fcall_interactively):
1574 * minibuf.c (Fread_variable): Callers changed.
1576 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1578 * xdisp.c (set_cursor_from_row): If the display string appears in
1579 the buffer at position that is closer to point than the position
1580 after the display string, display the cursor on the first glyph of
1581 the display string. Fixes cursor display when a 'display' text
1582 property immediately follows invisible text. (Bug#11094)
1584 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1586 composite.c: use 'double' consistently
1587 * composite.c (get_composition_id): Use 'double' consistently
1588 instead of converting 'float' to 'double' and vice versa; this is
1589 easier to understand and avoids a GCC warning.
1591 2012-04-09 Glenn Morris <rgm@gnu.org>
1593 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1594 preparation for dumping it with emacs. (Bug#4789)
1595 (leimdir): New variable.
1596 ($(leimdir)/leim-list.el): New rule.
1597 (emacs$(EXEEXT)): Depend on leim-list.el.
1599 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1600 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1601 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1603 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1605 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1608 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1610 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1611 Remove unused local variable.
1613 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1615 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1616 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1617 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1618 objects, as mark_maybe_pointer will catch them otherwise.
1619 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1620 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1622 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1624 Fix typo that broke non-Windows builds.
1625 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1627 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1629 Support building on MS-Windows with libxml2.
1631 * makefile.w32-in (OBJ2): Add xml.$(O).
1632 (GLOBAL_SOURCES): Add xml.c.
1633 ($(BLD)/xml.$(O)): New dependency list.
1635 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1636 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1637 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1638 [!WINDOWSNT]: New macros.
1639 (init_libxml2_functions, libxml2_loaded_p): New functions.
1640 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1641 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1642 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1643 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1645 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1646 Call init_libxml2_functions before calling libxml2 functions.
1647 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1649 * emacs.c: Don't include libxml/parser.h.
1650 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1651 xmlCleanupParser directly.
1653 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1655 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1657 * indent.c (Fvertical_motion): If there is a display string at
1658 point, use it.vpos to compute how many lines to backtrack after
1659 move_it_to point. (Bug#11133)
1661 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1663 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1664 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1665 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1666 macros related to unification of CJK characters. For the details,
1667 see the discussion following the message here:
1668 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1670 2012-04-04 Chong Yidong <cyd@gnu.org>
1672 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1674 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1676 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1677 instead of alloca. (Bug#11138)
1679 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1681 * w32menu.c (is_simple_dialog): Properly check lisp types.
1684 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1686 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1687 position we get to after a call to move_it_to fails the
1688 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1689 only if we wind up in a string from display property. (Bug#11063)
1691 * window.c (Fdelete_other_windows_internal): Invalidate the row
1692 and column information about mouse highlight, so that redisplay
1693 restores it after reallocating the glyph matrices. (Bug#7464)
1695 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1696 string comes from a `display' text property, use the buffer
1697 position of that property as if we actually saw that position in
1699 (move_it_by_lines): Remove the assertion that
1700 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1701 violated when there's a before-string at the beginning of a line.
1704 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1706 * xdisp.c (append_space_for_newline): If the default face was
1707 remapped, use the remapped face for the appended newline.
1708 (extend_face_to_end_of_line): Use the remapped default face for
1709 extending the face to the end of the line.
1710 (display_line): Call extend_face_to_end_of_line when the default
1711 face was remapped. (Bug#11068)
1713 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1715 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1717 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1719 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1721 2012-03-27 Glenn Morris <rgm@gnu.org>
1723 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1726 2012-03-26 Kenichi Handa <handa@m17n.org>
1728 * dispextern.h (struct glyph): Fix previous change. Change the
1729 bit length of glyphless.ch to 25 (Bug#11082).
1731 2012-03-26 Chong Yidong <cyd@gnu.org>
1733 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1734 (command_loop_1): Use it; inhibit selection update for
1735 handle-select-window too (Bug#8996).
1737 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1739 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1741 2012-03-25 Kenichi Handa <handa@m17n.org>
1743 * dispextern.h (struct glyph): Change the bit length of
1744 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1746 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1748 * s/ms-w32.h (tzname): Include time.h before redirecting to
1749 _tzname. Fixes the MSVC build. (Bug#9960)
1751 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1753 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1756 * xterm.c (XTread_socket): Only modify handling_signal if
1757 !SYNC_INPUT. (Bug#11080)
1759 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1761 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1762 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1763 when fetching a multibyte character consumes more bytes than
1764 CHAR_BYTES returns, due to unification of CJK characters in
1765 string_char. (Bug#11073)
1767 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1769 * process.c (wait_reading_process_output): Handle pty disconnect
1770 by refraining from sending oneself a SIGCHLD (bug#10933).
1772 2012-03-22 Chong Yidong <cyd@gnu.org>
1774 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1776 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1777 Mark string as coming from a prefix property.
1778 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1779 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1781 2012-03-21 Chong Yidong <cyd@gnu.org>
1783 * xfaces.c (Vface_remapping_alist): Doc fix.
1785 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1787 * w32proc.c (Fw32_set_console_codepage)
1788 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1791 2012-03-20 Chong Yidong <cyd@gnu.org>
1793 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1794 to reflect default non-nil value of redisplay-dont-pause.
1796 2012-03-19 Kenichi Handa <handa@m17n.org>
1798 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1799 it fit in a valid range (Bug#11003).
1801 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1803 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1804 that is not from display property, accept the row as a "cursor
1805 row" if one of the string's character has a non-nil `cursor'
1806 property. Fixes cursor positioning when there are newlines in
1807 overlay strings, e.g. in icomplete.el. (Bug#11035)
1809 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1811 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1813 2012-03-12 Chong Yidong <cyd@gnu.org>
1815 * eval.c (inhibit_lisp_code): Rename from
1816 inhibit_window_configuration_change_hook; move from window.c.
1818 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1819 * window.c (run_window_configuration_change_hook)
1820 (syms_of_window): Callers changed.
1822 2012-03-11 Chong Yidong <cyd@gnu.org>
1824 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1826 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1828 2012-03-10 Chong Yidong <cyd@gnu.org>
1830 * frame.c (other_visible_frames): Don't assume the selected frame
1831 is visible (Bug#10955).
1833 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1835 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1837 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1839 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1840 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1843 2012-03-03 Glenn Morris <rgm@gnu.org>
1845 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1847 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1849 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1850 position past the first glyph_row that ends at ZV. (Bug#10902)
1851 (redisplay_window, next_element_from_string): Fix typos in
1853 (redisplay_window): Pass to move_it_vertically the margin in
1854 pixels, not in screen lines.
1856 2012-03-02 Glenn Morris <rgm@gnu.org>
1858 * buffer.c (buffer-list-update-hook): Doc fix.
1860 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1862 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1863 push_it before setting up the iterator for the first overlay
1864 string, even if we have an empty string loaded.
1865 (next_overlay_string): If there's an empty string on the iterator
1866 stack, pop the stack. (Bug#10903)
1868 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1870 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1871 Suggested by Stefan Monnier in
1872 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1873 * alloc.c (widen_to_Lisp_Object): New static function.
1874 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1875 and widening them to Lisp_Objects. This would work even if
1876 USE_LSB_TAG is defined and wide integers are used, which might
1877 happen in a future version of Emacs.
1879 2012-02-25 Chong Yidong <cyd@gnu.org>
1881 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1884 * xselect.c (Fx_selection_exists_p): Doc fix.
1885 (x_clipboard_manager_save_all): Print an informative message
1886 before saving to clipboard manager.
1888 2012-02-24 Chong Yidong <cyd@gnu.org>
1890 * keyboard.c (process_special_events): Handle all X selection
1891 requests in kbd_buffer, not just the next one (Bug#8869).
1893 2012-02-23 Chong Yidong <cyd@gnu.org>
1895 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1896 call when setting menu-bar-lines and tool-bar-lines parameters.
1897 (unwind_create_frame_1): New helper function.
1899 * window.c (inhibit_window_configuration_change_hook): New var.
1900 (run_window_configuration_change_hook): Obey it.
1901 (syms_of_window): Initialize it.
1903 2012-02-22 Chong Yidong <cyd@gnu.org>
1905 * xterm.c (x_draw_image_relief): Add missing type check for
1906 Vtool_bar_button_margin (Bug#10743).
1908 2012-02-21 Chong Yidong <cyd@gnu.org>
1910 * fileio.c (Vfile_name_handler_alist): Doc fix.
1912 * buffer.c (Fget_file_buffer): Protect against invalid file
1913 handler return value.
1915 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1917 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1918 when computing $valmask.
1920 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1921 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1922 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1923 It's useless in that case, and it can cause problems on hosts
1924 that allocate halves of EMACS_INT values separately.
1925 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1926 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1927 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1928 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1929 it avoids undefined behavior on hosts where shifting right by more
1930 than the word width has undefined behavior.
1932 2012-02-19 Chong Yidong <cyd@gnu.org>
1934 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1935 (Funhandled_file_name_directory, Ffile_name_as_directory)
1936 (Fdirectory_file_name, Fexpand_file_name)
1937 (Fsubstitute_in_file_name): Protect against invalid file handler
1938 return values (Bug#10845).
1940 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1942 * .gdbinit (pitx): Fix incorrect references to fields of the
1945 2012-02-17 Chong Yidong <cyd@gnu.org>
1947 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1949 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1951 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1952 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1954 2012-02-15 Chong Yidong <cyd@gnu.org>
1956 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1957 marked as special. Also, starting docstrings with * is obsolete.
1959 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1961 * gnutls.c (emacs_gnutls_write): Fix last change.
1963 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1965 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1968 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1970 * keymap.c (Fsingle_key_description): Handle char ranges.
1972 2012-02-12 Chong Yidong <cyd@gnu.org>
1974 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1975 as that creates a dangerous corner case.
1977 * window.c (Fdelete_window_internal): Invalidate the mouse
1978 highlight (Bug#9904).
1980 2012-02-12 Glenn Morris <rgm@gnu.org>
1982 * xselect.c (Fx_own_selection_internal)
1983 (Fx_get_selection_internal, Fx_disown_selection_internal)
1984 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1985 * nsselect.m (Fx_own_selection_internal)
1986 (Fx_disown_selection_internal, Fx_selection_exists_p)
1987 (Fx_selection_owner_p, Fx_get_selection_internal):
1988 Sync docs and argument specs with the xselect.c versions.
1990 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1992 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1994 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1996 * w32select.c (Fx_selection_exists_p): Sync doc string and
1997 argument list with xselect.c. (Bug#10783)
1999 * w16select.c (Fx_selection_exists_p): Sync doc string and
2000 argument list with xselect.c. (Bug#10783)
2002 2012-02-10 Glenn Morris <rgm@gnu.org>
2004 * fns.c (Fsecure_hash): Doc fix.
2006 2012-02-09 Kenichi Handa <handa@m17n.org>
2008 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2010 2012-02-07 Chong Yidong <cyd@gnu.org>
2012 * buffer.c (Fbuffer_local_variables)
2013 (buffer_lisp_local_variables): Handle unbound vars correctly;
2014 don't let Qunbound leak into Lisp.
2016 2012-02-07 Glenn Morris <rgm@gnu.org>
2018 * image.c (Fimagemagick_types): Doc fix.
2020 * image.c (imagemagick-render-type): Change it from a lisp object
2021 to an integer. Move the doc here from the lisp manual.
2022 Treat all values not equal to 0 the same.
2024 2012-02-06 Chong Yidong <cyd@gnu.org>
2026 * doc.c (store_function_docstring): Avoid applying docstring of
2027 alias to base function (Bug#2603).
2029 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2031 * .gdbinit (pp1, pv1): Remove redundant defines.
2034 2012-02-04 Chong Yidong <cyd@gnu.org>
2036 * nsterm.m: Declare a global (Bug#10694).
2038 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2040 * w32.c (get_emacs_configuration_options):
2041 Include --enable-checking, if specified, in the return value.
2043 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2045 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2046 after rounding frame sizes. (Bug#9723)
2048 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2050 * keyboard.c (adjust_point_for_property): Don't position point
2051 before BEGV. (Bug#10696)
2053 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2055 Handle overflow when computing char display width (Bug#9496).
2056 * character.c (char_width): Return EMACS_INT, not int.
2057 (char_width, c_string_width): Check for overflow when
2058 computing the width; this is possible now that individual
2059 characters can have unbounded width. Problem introduced
2060 by merge from Emacs 23 on 2012-01-19.
2062 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2064 * dbusbind.c (Fdbus_register_method): Mention the return value
2065 :ignore in the docstring.
2067 2012-02-02 Glenn Morris <rgm@gnu.org>
2069 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2071 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2072 Unconditionally set to t. (Bug#10673)
2073 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2074 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2075 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2077 2012-02-02 Kenichi Handa <handa@m17n.org>
2079 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2080 0, do not call append_composite_glyph.
2082 2012-02-02 Kenichi Handa <handa@m17n.org>
2084 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2086 (x_produce_glyphs): If the component of a composition is a null
2087 string, set it->pixel_width to 1 to avoid zero-width glyph.
2089 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2091 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2092 first 2 arguments are identical. This makes inserting large
2093 output from a subprocess an order of magnitude faster on
2094 MS-Windows, where all sbrk'ed memory is always contiguous.
2096 2012-01-31 Glenn Morris <rgm@gnu.org>
2098 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2099 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2100 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2102 2012-01-29 Glenn Morris <rgm@gnu.org>
2104 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2106 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2108 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2110 2012-01-28 Chong Yidong <cyd@gnu.org>
2112 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2114 2012-01-26 Chong Yidong <cyd@gnu.org>
2116 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2118 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2119 repeat counts (Bug#10507).
2121 2012-01-26 Glenn Morris <rgm@gnu.org>
2123 * lread.c (syms_of_lread): Doc fix.
2125 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2127 * coding.c (encode_designation_at_bol): Change return value to
2130 2012-01-25 Chong Yidong <cyd@gnu.org>
2132 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2134 2012-01-21 Chong Yidong <cyd@gnu.org>
2136 * floatfns.c (Fcopysign): Make the second argument non-optional,
2137 since nil is not allowed anyway.
2139 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2141 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2142 (send_process): Likewise.
2144 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2146 * window.c (save_window_save, Fcurrent_window_configuration)
2147 (Vwindow_persistent_parameters): Do not use Qstate.
2148 Rewrite doc-strings.
2150 2012-01-19 Kenichi Handa <handa@m17n.org>
2152 * character.c (char_width): New function.
2153 (Fchar_width, c_string_width, lisp_string_width):
2154 Use char_width (Bug#9496).
2156 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2158 * window.c (Vwindow_persistent_parameters): New variable.
2159 (Fset_window_configuration, save_window_save): Handle persistent
2162 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2164 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2165 thrashing the stack of the thread. (Bug#9087)
2167 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2169 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2171 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2173 * xdisp.c (rows_from_pos_range): Handle the case where the
2174 highlight ends on a newline. (Bug#10464)
2175 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2176 he end column for display of highlight that ends on a newline
2179 2012-01-11 Glenn Morris <rgm@gnu.org>
2181 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2182 from load-path also when installation-directory is nil. (Bug#10208)
2184 2012-01-10 Glenn Morris <rgm@gnu.org>
2186 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2188 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2189 Update template values to be closer to their typical values these days.
2191 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2193 * xdisp.c (rows_from_pos_range): Accept additional argument
2194 DISP_STRING, and accept any glyph in a row whose object is that
2195 string as eligible for mouse highlight. Fixes mouse highlight of
2196 display strings from overlays. (Bug#10464)
2198 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2200 emacs: fix an auto-save permissions race condition (Bug#10400)
2201 * fileio.c (auto_saving_dir_umask): New static var.
2202 (Fmake_directory_internal): Use it.
2203 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2204 creating the directory. The old code temporarily assigns
2205 too-generous permissions to the directory.
2206 (do_auto_save_eh): Clear it.
2207 (Fdo_auto_save): Catch all errors, not just file errors, so
2208 that the var is always cleared.
2210 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2212 * search.c (scan_buffer): Pass character positions to
2213 know_region_cache, not byte positions. (Bug#6540)
2215 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2217 * w32.c (sys_rename): Report EXDEV when rename of a directory
2218 fails because the target is on another logical disk. (Bug#10284)
2220 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2222 * xterm.c (x_embed_request_focus): New function.
2224 * xterm.h: Add prototype.
2226 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2228 2012-01-05 Glenn Morris <rgm@gnu.org>
2230 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2232 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2234 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2235 Load gnutls_transport_set_lowat only if GnuTLS version is below
2237 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2238 GnuTLS versions below 2.11.1.
2240 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2242 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2243 to the doc string advising against its use for altering the way
2244 windows are scrolled.
2246 2011-12-28 Kenichi Handa <handa@m17n.org>
2248 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2249 coding-system ASCII compatible only when it does not produce BOM
2250 on encoding (Bug#10383).
2252 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2254 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2256 (create_and_show_popup_menu): Always use menu_position_func for
2259 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2261 * callint.c (Fcall_interactively): Don't truncate prompt string.
2263 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2266 property that ends at ZV, so that the bidi iteration could be
2267 resumed from there (after widening). (Bug#10360)
2269 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2271 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2273 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2275 * nsterm.m (x_free_frame_resources):
2276 Release f->output_data.ns->miniimage.
2277 (ns_index_color): Fix indentation. Do not retain
2278 color_table->colors[i].
2280 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2283 * nsfns.m (x_set_background_color): Assign return value from
2284 ns_index_color to face-background instead of NSColor*.
2285 (ns_implicitly_set_icon_type): Fix indentation.
2286 Change assignment in for loop to comparison.
2288 * emacs.c (ns_pool): New variable.
2289 (main): Assign ns_pool.
2290 (Fkill_emacs): Call ns_release_autorelease_pool.
2292 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2293 autorelease fdesc, release fdAttrs and tdict.
2294 (ns_get_covering_families): Release charset.
2295 (ns_findfonts): Release NSFontDescriptor created with new.
2296 (ns_uni_to_glyphs): Fix indentation.
2297 (setString): Release attrStr before assigning new value.
2299 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2301 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2303 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2304 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2306 2011-12-18 David Reitter <reitter@cmu.edu>
2308 * nsterm.m (ns_term_init): Subscribe for notifications
2309 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2310 to method trackingNotification in EmacsMenu.
2312 * nsmenu.m (trackingMenu): New variable.
2313 (trackingNotification): New method (from Aquamacs).
2314 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2315 from Aquamacs (Bug#7030).
2317 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2319 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2320 (symbol_to_nsstring): Fix indentation.
2321 (ns_symbol_to_pb): New function.
2322 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2323 (Fns_rotate_cut_buffers_internal): Remove.
2324 (Fns_store_selection_internal): Rename from
2325 Fns_store_cut_buffer_internal.
2326 (ns_get_foreign_selection, Fx_own_selection_internal)
2327 (Fx_disown_selection_internal, Fx_selection_exists_p)
2328 (Fns_get_selection_internal, Fns_store_selection_internal):
2329 Use ns_symbol_to_pb and check if return value is nil.
2330 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2331 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2332 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2333 renamed to Sns_store_selection_internal.
2334 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2335 and remove this function.
2336 (ns_handle_selection_clear): Remove, never used.
2337 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2340 2011-12-17 Ken Brown <kbrown@cornell.edu>
2342 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2343 GID is unknown (Bug#10257).
2345 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2347 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2348 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2349 which caused a build failure on GNU/Linux IA-64. This problem was
2350 introduced by my 2011-10-07 patch.
2352 2011-12-15 Juri Linkov <juri@jurta.org>
2354 * image.c (imagemagick_error): New function. (Bug#10112)
2355 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2356 Use `imagemagick_error' where ImageMagick functions return
2358 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2361 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2363 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2364 fill background (Bug#8992).
2366 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2368 * window.c (Vwindow_combination_resize)
2369 (Vwindow_combination_limit): Use t instead of non-nil in
2371 (Vrecenter_redisplay): Add first sentence of doc-string on
2373 (Frecenter): Fix doc-string typo.
2375 2011-12-11 Kenichi Handa <handa@m17n.org>
2377 * coding.c (Funencodable_char_position): Pay attention to the
2378 buffer text relocation (Bug#9389).
2380 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2382 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2383 gtk_init (Bug#10100).
2385 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2388 IT->string is nil. (Bug#10263)
2390 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2392 * nsterm.h (x_free_frame_resources): Declare.
2394 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2395 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2397 * nsterm.h (ns_get_defaults_value): Declare.
2399 * nsterm.m (ns_default): Call ns_get_defaults_value.
2401 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2403 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2406 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2408 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2409 that where the value of an _OBJC_* symbol points to is in the .bss
2410 section (Bug#10240).
2412 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2414 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2415 after the loop to call ccl_driver at least once (Bug#8619).
2417 2011-12-08 Kenichi Handa <handa@m17n.org>
2419 * ftfont.c (get_adstyle_property): Fix previous change
2422 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2424 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2425 dirs from the default value of EMACSLOADPATH (bug#10208).
2427 2011-12-07 Glenn Morris <rgm@gnu.org>
2429 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2430 installation and source directories as well. (Bug#10208)
2432 2011-12-06 Chong Yidong <cyd@gnu.org>
2434 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2436 2011-12-06 Glenn Morris <rgm@gnu.org>
2438 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2439 as an error, not just -1. (Bug#10217)
2441 2011-12-05 Chong Yidong <cyd@gnu.org>
2443 * keyboard.c (process_special_events): New function.
2444 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2446 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2448 * coding.c (encode_designation_at_bol): Don't use uninitialized
2449 local variable (Bug#9318).
2451 2011-12-05 Kenichi Handa <handa@m17n.org>
2453 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2454 return Qnil (Bug#8046, Bug#10193).
2456 2011-12-05 Kenichi Handa <handa@m17n.org>
2458 * coding.c (encode_designation_at_bol): New args charbuf_end and
2459 dst. Return the number of produced bytes. Callers changed.
2460 (coding_set_source): Return how many bytes coding->source was
2462 (coding_set_destination): Return how many bytes
2463 coding->destination was relocated.
2464 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2465 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2467 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2469 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2470 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2473 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2475 The following changes are to fix Bug#9318.
2477 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2478 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2479 (encode_coding_iso_2022, encode_coding_sjis)
2480 (encode_coding_big5, encode_coding_charset): Use the above macros.
2482 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2484 * lisp.h (process_quit_flag): Fix external declaration.
2486 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2488 Don't macro-inline non-performance-critical code.
2489 * eval.c (process_quit_flag): New function.
2490 * lisp.h (QUIT): Use it.
2492 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2494 * nsfns.m (get_geometry_from_preferences): New function.
2495 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2497 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2499 * emacs.c (Qkill_emacs): Define.
2500 (syms_of_emacs): Initialize it.
2501 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2502 Qquit_flag to `kill-emacs' instead.
2503 (quit_throw_to_read_char): Add parameter `from_signal'.
2504 All callers changed. Call Fkill_emacs if requested and safe.
2505 * lisp.h (QUIT): Call Fkill_emacs if requested.
2507 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2509 * widget.c (update_wm_hints): Return if wmshell is null.
2510 (widget_update_wm_size_hints): New function.
2512 * widget.h (widget_update_wm_size_hints): Declare.
2514 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2515 widget_update_wm_size_hints (Bug#10104).
2517 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2519 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2520 before a newline, prepare the bidi iterator for consuming the
2521 newline, and keep the current paragraph direction. (Bug#10183)
2522 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2524 2011-12-02 Juri Linkov <juri@jurta.org>
2526 * search.c (Fword_search_regexp): New Lisp function created from
2527 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2528 (Fword_search_backward, Fword_search_forward)
2529 (Fword_search_backward_lax, Fword_search_forward_lax):
2530 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2531 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2533 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2535 * fileio.c (Finsert_file_contents): Move after-change-function call
2536 to before the "handled:" label, since all "goto handled" appear in
2537 cases where the *-change-functions have already been properly called
2540 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2542 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2543 waiting for input. (Bug#10169)
2545 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2547 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2548 verifies glyph row's hash code--we have just reallocated the
2549 glyphs, so their contents can be complete garbage. (Bug#10164)
2551 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2553 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2555 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2557 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2558 attributes are tested _before_ calling verify_row_hash, to protect
2559 against GCC re-ordering of the tests. (Bug#10164)
2561 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2563 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2565 * xterm.c (handle_one_xevent): Only set async_visible and friends
2566 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2567 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2568 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2570 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2572 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2573 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2574 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2575 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2576 All uses changed to use GCPRO1 etc.
2577 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2578 Revert to old implementation (i.e., before 2011-03-11).
2580 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2582 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2583 of scroll runs so as to avoid assigning disabled bogus rows and
2584 unnecessary graphics copy operations.
2586 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2588 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2589 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2590 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2591 (malloc, free, realloc, calloc): Redirect to e_* only when
2594 * lisp.h (GCTYPEBITS): Move before first use.
2595 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2596 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2597 this macro definition.
2599 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2602 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2604 * gtkutil.c (xg_create_frame_widgets):
2605 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2606 present with Gtk+ 2.0.
2608 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2610 * fileio.c (Finsert_file_contents): Undo previous change; see
2611 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2613 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2615 Rename locals to avoid shadowing.
2616 * fileio.c (Finsert_file_contents):
2617 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2618 * process.c (wait_reading_process_output):
2619 Rename inner 'proc' to 'p' to avoid shadowing.
2620 Indent for consistency with usual Emacs style.
2622 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2624 * xdisp.c (redisplay_window): If cursor row is not fully visible
2625 after recentering, and scroll-conservatively is set to a large
2626 number, scroll window by a few more lines to make the cursor fully
2627 visible and out of scroll-margin. (Bug#10105)
2628 (start_display): Don't move to the next line if the display should
2629 start at a newline that is part of a display vector or an overlay
2632 2011-11-24 Juri Linkov <juri@jurta.org>
2634 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2635 after the `MagickPingImage' call. (Bug#10112)
2637 2011-11-23 Chong Yidong <cyd@gnu.org>
2639 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2641 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2643 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2644 making another buffer current. (Bug#10114)
2646 2011-11-23 Glenn Morris <rgm@gnu.org>
2648 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2650 2011-11-23 Chong Yidong <cyd@gnu.org>
2652 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2653 using it (Bug#5984).
2655 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2657 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2658 and header-lines, as they don't have one computed for them.
2661 * .gdbinit (prow): Make displayed values more self-explaining.
2662 Add row's hash code.
2664 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2666 * process.c (wait_reading_process_output): Fix asynchrounous
2667 GnuTLS socket handling on some versions of the GnuTLS library.
2668 (wait_reading_process_output): Add comment and URL.
2670 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2672 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2674 2011-11-21 Chong Yidong <cyd@gnu.org>
2676 * window.c (Fnext_window, Fprevious_window): Doc fix.
2678 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2680 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2682 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2684 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2686 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2688 * window.c (Fset_window_combination_limit): Rename argument
2690 (Vwindow_combination_limit): Remove "status" from doc-string.
2692 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2694 * m/ibms390.h: Remove.
2695 * m/ibms390x.h: Don't include "ibms390.h".
2697 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2699 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2700 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2702 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2704 * casetab.c (Fset_case_table):
2705 * charset.c (Fcharset_after): Fix typos.
2707 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2709 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2710 Otherwise, valgrind does not work on some platforms.
2711 Problem reported by Andreas Schwab in
2712 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2713 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2714 is set, removing the need for VIRT_ADDRESS_VARIES.
2715 (PURE_P): Use a more-efficient implementation that needs just one
2716 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2717 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2718 to 4 (xorl, subq, cmpq, setbe).
2719 * alloc.c (pure): Always extern now, since that's the
2720 VIRT_ADDR_VARIES behavior.
2721 (PURE_POINTER_P): Use a single comparison, not two, for
2722 consistency with the new puresize.h.
2723 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2724 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2725 Remove VIRT_ADDR_VARIES no longer needed.
2727 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2729 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2730 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2731 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2732 behave as if the cursor position were at the window margin.
2734 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2735 and the cursor position is out of bounds, behave as if the cursor
2736 position were at the window margin. (Bug#10075)
2738 2011-11-18 Chong Yidong <cyd@gnu.org>
2740 * window.c (Fwindow_combination_limit): Make first argument
2741 non-optional, since it is meaningless for live windows like the
2744 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2746 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2748 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2750 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2751 (graft_intervals_into_buffer): Simplify.
2753 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2755 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2756 hash values of the two rows.
2757 (copy_row_except_pointers): Preserve the used[] arrays and the
2758 hash values of the two rows. (Bug#10035)
2759 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2761 * xdisp.c (row_hash): New function, body extracted from
2762 compute_line_metrics.
2763 (compute_line_metrics): Call row_hash, instead of computing the
2766 * dispnew.c (verify_row_hash): Call row_hash for computing the
2767 hash code of a row, instead of duplicating code from xdisp.c.
2769 * dispextern.h (row_hash): Add prototype.
2771 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2773 * frame.c (delete_frame): Don't delete the terminal when the last
2774 X frame is closed if emacs is built with GTK toolkit.
2776 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2778 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2780 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2782 * window.c (Vwindow_splits): Rename to
2783 Vwindow_combination_resize. Suggested by Juri Linkov.
2784 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2787 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2789 * nsfns.m (Fns_font_name):
2790 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2792 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2794 * window.h (window): Rename slot "nest" to "combination_limit".
2795 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2796 (Fset_window_nest): Rename to Fset_window_combination_limit.
2797 (Vwindow_nest): Rename to Vwindow_combination_limit.
2798 (recombine_windows, make_parent_window, make_window)
2799 (Fsplit_window_internal, saved_window)
2800 (Fset_window_configuration, save_window_save): Rename all
2801 occurrences of window_nest to window_combination_limit.
2803 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2805 * image.c (imagemagick_load_image): Fix typo.
2807 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2809 * xdisp.c (display_line): Move the call to
2810 highlight_trailing_whitespace before the call to
2811 compute_line_metrics, since the latter needs to see the final
2812 faces of all the glyphs to compute ROW's hash value.
2813 Fixes assertion violations in row_equal_p. (Bug#10035)
2815 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2817 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2818 just return (bug#10044).
2820 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2822 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2823 with user-defined heap size. Bump the default size of the temacs
2824 heap to 27MB, to avoid memory warning when running temacs.
2825 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2827 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2828 current_matrix and desired_matrix. (Bug#9990)
2829 (verify_row_hash) [XASSERTS]: New function.
2830 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2831 that the hash value of glyph rows is correct.
2833 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2835 * window.h (window): Remove splits slot.
2836 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2837 (Fdelete_other_windows_internal, make_parent_window)
2838 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2839 (Fset_window_configuration, save_window_save): Don't deal with
2840 split status of windows.
2841 (saved_window): Remove splits slot.
2842 (Vwindow_splits): Rewrite doc-string.
2844 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2846 * xfns.c (unwind_create_frame):
2847 * nsfns.m (unwind_create_frame):
2848 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2849 Vframe_list (Bug#9999).
2851 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2853 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2855 2011-11-11 Kenichi Handa <handa@m17n.org>
2857 * callproc.c (Fcall_process): Set the member dst_multibyte of
2860 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2862 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2863 avoid a crash (bug#9496).
2865 2011-11-09 Chong Yidong <cyd@gnu.org>
2867 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2868 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2870 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2872 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2874 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2876 Avoid some portability problems by eschewing 'extern inline' functions.
2877 The trivial performance wins aren't worth the portability hassles; see
2878 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2880 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2881 (window_box_width, window_box_left, window_box_left_offset)
2882 (window_box_right, window_box_right_offset): Undo previous change,
2883 by removing the "extern"s.
2884 * intervals.c (adjust_intervals_for_insertion)
2885 (adjust_intervals_for_deletion): Undo previous change,
2886 making these static again.
2887 (offset_intervals, temp_set_point_both, temp_set_point)
2888 (copy_intervals_to_string): No longer inline.
2889 * xdisp.c (window_text_bottom_y, window_box_width)
2890 (window_box_height, window_box_left_offset)
2891 (window_box_right_offset, window_box_left, window_box_right)
2892 (window_box): No longer inline.
2894 2011-11-08 Chong Yidong <cyd@gnu.org>
2896 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2897 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2898 Signal an error if not a live window.
2899 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2900 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2902 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2904 * lisp.h (syms_of_abbrev): Remove declaration.
2905 Reported by CHENG Gao <chenggao@royau.me>.
2907 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2909 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2910 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2911 of temacs in GUI mode.
2913 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2915 * window.h: Declare delete_all_child_windows instead of
2916 delete_all_subwindows.
2917 * window.c (Fwindow_nest, Fset_window_nest)
2918 (Fset_window_new_total, Fset_window_new_normal)
2919 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2920 (delete_all_subwindows): Rename to delete_all_child_windows.
2921 (Fdelete_other_windows_internal, Fset_window_configuration):
2922 Call delete_all_child_windows instead of delete_all_subwindows.
2923 * frame.c (delete_frame): Call delete_all_child_windows instead
2924 of delete_all_subwindows.
2926 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2928 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2929 This is also needed for porting to any host where GC_MARK_STACK is
2930 not GC_MAKE_GCPROS_NOOPS.
2931 (which_symbols): Use it.
2933 2011-11-07 Kenichi Handa <handa@m17n.org>
2935 * coding.c (coding_set_destination): Check coding->src_pos only
2936 when coding->src_object is a buffer (bug#9910).
2938 * process.c (send_process): Set the member src_multibyte of coding
2939 to 0 (bug#9911) when sending a unibyte text.
2941 * callproc.c (Fcall_process): Set the member src_multibyte of
2942 process_coding to 0 (bug#9912).
2944 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2946 * xmenu.c (cleanup_widget_value_tree): New function.
2947 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2948 calling free_menubar_widget_value_tree directly (Bug#9830).
2950 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2952 Fix some portability problems with 'inline'.
2953 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2954 (window_box_width, window_box_left, window_box_left_offset)
2955 (window_box_right, window_box_right_offset): Declare extern.
2956 Otherwise, these inline functions do not conform to C99 and
2957 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2958 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2959 * intervals.c (adjust_intervals_for_insertion)
2960 (adjust_intervals_for_deletion): Now extern, because otherwise the
2961 extern inline functions 'offset_intervals' couldn't refer to it.
2962 (static_offset_intervals): Remove.
2963 (offset_intervals): Rewrite using the old contents of
2964 static_offset_intervals. The old version didn't conform to C99
2965 because an extern inline function contained a reference to an
2966 identifier with static linkage.
2968 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2970 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2973 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2975 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2976 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2977 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2978 return Qleft_to_right.
2980 2011-11-06 Chong Yidong <cyd@gnu.org>
2982 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2983 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2984 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2985 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2986 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2987 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2988 (Fwindow_vscroll): Doc fix.
2989 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2990 argument, since it makes no sense to pass a live window and for
2991 consistency with window-child.
2993 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2995 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2998 2011-11-05 Jason Rumney <jasonr@gnu.org>
3000 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3001 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3003 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3004 bitwise arithmetic preventing use of unicode-sip and non-truetype
3007 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3009 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3012 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3013 initialization code to keep similarity to xfns.c after changes
3016 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3018 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3019 (unwind_create_frame): New function (Bug#9943).
3020 (Fx_create_frame): Restructure code to be more similar to the one in
3021 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3022 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3023 Move terminal->reference_count++ just before making the frame official
3026 * nsterm.m (x_free_frame_resources): New function.
3027 (x_destroy_window): Move code to x_free_frame_resources.
3029 * xfns.c (unwind_create_frame): Fix comment.
3030 (Fx_create_frame, x_create_tip_frame):
3031 Move terminal->reference_count++ just before making the frame
3032 official. Move initialization of image_cache_refcount and
3033 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3035 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3037 Support MSVC build with newer versions of Visual Studio.
3038 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3039 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3042 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3043 which are not supported by MSVC.
3044 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3045 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3047 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3049 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3051 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3053 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3055 Support MSVC build with newer versions of Visual Studio.
3056 * w32.c: Don't include w32api.h for MSVC.
3057 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3059 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3060 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3061 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3062 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3064 (alloca) [_MSC_VER]: Define to _alloca.
3066 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3068 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3070 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3072 * xdisp.c (note_mouse_highlight): If either of
3073 previous/next-single-property-change returns nil, treat that as
3074 the beginning or the end of the buffer. (Bug#9955)
3076 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3078 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3079 label is not null (Bug#9951).
3080 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3083 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3085 * window.c (Fwindow_body_size): Mention in the doc string that the
3086 return value is in frame's canonical units. (Bug#9949)
3088 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3090 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3092 * w32fns.c (unwind_create_frame): If needed, free the glyph
3093 matrices of the partially constructed frame. (Bug#9943)
3094 * xfns.c (unwind_create_frame): Likewise.
3096 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3098 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3099 Don't stop backward scan on the continuation glyph, even though
3100 its CHARPOS is positive.
3101 (mouse_face_from_buffer_pos, note_mouse_highlight):
3102 Rename cover_string to disp_string.
3104 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3106 * window.c (temp_output_buffer_show): Don't use
3107 Vtemp_buffer_show_specifiers.
3108 (Vtemp_buffer_show_specifiers): Remove unused variable.
3110 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3112 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3113 past the beginning of the current glyph matrix.
3115 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3117 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3118 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3119 HAVE_GTK3 (Bug#9869).
3121 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3122 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3124 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3126 * xterm.c: Declare x_handle_net_wm_state to return int.
3127 (handle_one_xevent): Check if we are iconified but don't have
3128 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3129 (get_current_wm_state): Return non-zero if not hidden,
3130 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3131 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3132 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3133 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3135 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3137 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3138 so that this new function doesn't get optimized away by a
3139 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3141 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3143 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3145 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3147 Fix the `xbytecode' command.
3148 * .gdbinit (xprintbytestr): New command.
3149 (xwhichsymbols): Rename from `which'; all callers changed.
3150 (xbytecode): Print the byte-code string as well.
3152 2011-10-29 Kim Storm <storm@cua.dk>
3154 * alloc.c (which_symbols): New function.
3156 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3158 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3161 2011-10-29 Glenn Morris <rgm@gnu.org>
3163 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3164 Not clear what it was for, and it causes various bugs. (Bug#9839)
3166 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3168 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3169 possible random value that matches one of those tested as
3170 condition to clear the mouse face.
3172 2011-10-28 Chong Yidong <cyd@gnu.org>
3174 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3176 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3178 * window.c (make_window): Initialize phys_cursor_on_p.
3180 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3182 * lisp.h (struct Lisp_Symbol): Update comments.
3184 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3186 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3188 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3190 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3191 <oslsachem@gmail.com> for helping to debug this.
3193 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3194 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3195 (g_b_init_get_glyph_outline_w): New static variables.
3196 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3197 (GetGlyphOutlineW_Proc): New typedefs.
3198 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3199 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3201 (w32font_open_internal, compute_metrics):
3202 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3203 instead of calling the "wide" APIs directly.
3205 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3207 * w32.h (syms_of_w32font): Add prototype.
3209 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3211 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3212 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3213 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3214 (Fmove_to_window_line): Doc fix.
3216 2011-10-27 Chong Yidong <cyd@gnu.org>
3218 * process.c (make_process): Set gnutls_state to NULL.
3220 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3221 non-NULL, regardless of GNUTLS_INITSTAGE.
3222 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3223 an error. Set process slots as soon as we allocate them.
3225 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3227 2011-10-27 Chong Yidong <cyd@gnu.org>
3229 * gnutls.c (emacs_gnutls_deinit): New function.
3230 Deallocate credentials structures as well as calling gnutls_deinit.
3231 (Fgnutls_deinit, Fgnutls_boot): Use it.
3233 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3234 (deactivate_process): Call emacs_gnutls_deinit.
3236 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3238 * image.c (x_create_x_image_and_pixmap):
3239 * w32.c (sys_rename, w32_delayed_load):
3240 * w32font.c (fill_in_logfont):
3241 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3243 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3245 * w32fns.c (w32_default_color_map): New function,
3246 extracted from Fw32_default_color_map.
3247 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3249 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3251 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3253 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3255 * keyboard.c (test_undefined): New function (bug#9751).
3256 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3258 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3260 * sysdep.c (init_sys_modes): Fix the check for the controlling
3261 terminal (Bug#6649).
3263 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3265 * dispextern.h (struct bidi_it): New member next_en_type.
3267 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3268 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3269 current character, check also for next_en_type being WEAK_EN.
3270 (bidi_resolve_weak): Don't enter the expensive loop if the current
3271 position is before next_en_pos. Record the bidi type of the first
3272 non-ET, non-BN character we find, in addition to its position.
3273 (bidi_level_of_next_char): Invalidate next_en_type when
3274 next_en_pos is over-stepped.
3276 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3278 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3279 * editfns.c: Rewrite current-time-zone so that it invokes
3280 the equivalent of (format-time-string "%Z") to get the time zone name.
3281 This fixes a bug when the time zone name contains characters that
3282 need converting from the system time locale to Emacs internal format.
3283 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3284 that patch fixed format-time-string to do the conversion, but
3285 I forgot to fix current-time-zone.
3286 (format_time_string): New function, containing most of
3287 what Fformat_time_string used to contain.
3288 (Fformat_time_string): Rewrite in terms of format_time_string.
3289 This doesn't change this function's behavior.
3290 (current-time-zone): Rewrite to use format_time_string.
3291 This fixes the bug reported by Michael Schierl in
3292 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3293 Jason Rumney's 2007-06-07 change worked around this bug, but
3295 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3297 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3299 * xdisp.c (start_display): If the character at POS is displayed
3300 via a display vector, reset IT->current.dpvec_index to zero.
3301 (try_window_reusing_current_matrix): If a line ends in a display
3302 vector or the next line starts in a display vector, continue
3303 redrawing the window even though the character position of
3304 start_row was reached.
3307 2011-10-18 Chong Yidong <cyd@gnu.org>
3309 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3310 with nobreak-char-display too.
3312 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3314 Fix part 3 of bug#9771.
3315 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3316 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3317 non-neutral characters if the current character is a paragraph
3318 separator (a.k.a. Newline). This avoids running the same
3319 expensive loop twice, once when we consume the preceding newline
3320 and the other time when the line actually needs to be displayed.
3321 Avoid the loop when we see neutrals on the base embedding level
3322 following a character whose directionality is the same as the
3323 paragraph's. This avoids running the expensive loop when a line
3324 ends in a long sequence of neutrals, like control characters.
3325 Add assertion against STRONG_AL type. Slightly rearrange code
3326 that determines the type of a neutral given the first non-neutral
3328 (bidi_level_of_next_char): Set next_en_pos to zero when
3329 invalidating its info.
3331 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3333 * xdisp.c (push_display_prop): Determine whether to record string
3334 or buffer position by IT->string, not by IT->method. Allow
3335 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3336 (move_it_vertically_backward): Don't look for character position
3337 immediately after the newline when in a continuation line.
3340 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3342 * window.c (coordinates_in_window): Rewrite and delabelize
3343 vertical border check. (Bug#5357) (Bug#9618)
3345 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3347 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3348 errors in XSetWindowBorder (bug#9310).
3350 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3352 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3353 avoid crash when xmalloc overrun checking is enabled.
3355 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3357 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3358 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3359 cursor motion with <left> and <right> arrow keys.
3361 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3362 some callers set that themselves.
3364 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3366 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3367 display string and the previous row comes from the same string and
3368 is empty. (Bug#9739) (Bug#9738)
3370 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3372 * doc.c (get_doc_string): Encode file name (bug#9735).
3374 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3376 * bidi.c (bidi_level_of_next_char):
3377 * xdisp.c (get_visually_first_element): Remove old incorrect
3378 comments regarding the Unicode Line Separator character.
3380 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3382 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3384 * alloc.c (Fgc_status): Do not access beyond zombies array
3385 boundary if nzombies > MAX_ZOMBIES.
3386 * alloc.c (dump_zombies): Add missing format specifier.
3388 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3390 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3391 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3393 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3394 Some packages use them to denote characters with modifiers.
3396 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3398 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3399 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3400 matching a pp-number. Rename parameter var to var1.
3402 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3404 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3406 2011-10-08 Glenn Morris <rgm@gnu.org>
3408 * callint.c (Fcall_interactively): Give a more explicit error for the
3409 'c' case with a non-character input. (Bug#8479)
3411 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3413 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3415 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3416 lines that are hscrolled on the left.
3418 * dispnew.c (buffer_posn_from_coords): Account for a possible
3419 presence of header-line. (Bug#4426)
3421 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3423 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3424 Don't advertise functionality which we discourage or doesn't work.
3426 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3428 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3429 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3430 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3431 this makes Emacs dump core during garbage collection on rare
3432 occasions. sizeof is obviously inferior to offsetof here, so
3433 stick with offsetof.
3434 (GC_POINTER_ALIGNMENT): New macro.
3435 (mark_memory): Omit 3rd (offset) arg; caller changed.
3436 Don't assume EMACS_INT alignment is the same as pointer alignment.
3438 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3440 * keyboard.c (read_key_sequence_remapped): New var.
3441 (read_key_sequence): Compute remapping in the right buffer.
3442 (command_loop_1): Use read_key_sequence's remapping directly.
3444 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3446 * dired.c (file_name_completion): Don't expand file name.
3447 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3448 before checking file name handler.
3450 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3451 they've been requested explicitly (bug#9591).
3453 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3455 * keymap.c (Fsingle_key_description): Use make_specified_string
3456 instead of build_string to build string from push_key_description.
3459 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3461 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3462 This fixes a Y2038 bug on 64-bit hosts.
3463 * buffer.c (reset_buffer):
3464 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3465 (Fclear_buffer_auto_save_failure):
3466 Use 0, not -1, to represent an unset failure time, since time_t
3467 might not be signed.
3469 Remove dependency on glibc malloc internals.
3470 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3471 Move back here from lisp.h, but with their new implementations.
3472 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3473 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3474 * charset.c (charset_table_init): New static var.
3475 (syms_of_charset): Use it instead of xmalloc. This removes a
3476 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3477 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3478 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3479 Move back to alloc.c.
3480 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3481 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3483 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3485 * nsterm.m (windowDidResize): Call x_set_window_size only when
3486 ns_in_resize is true. Otherwise set pixelwidth/height and
3487 call change_frame_size (Bug#9628).
3489 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3491 Port --enable-checking=all to Fedora 14 x86-64.
3492 * charset.c (syms_of_charset): Also account for glibc malloc's
3493 internal overhead when calculating the initial malloc maximum.
3495 Port --enable-checking=all to Fedora 14 x86.
3496 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3498 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3499 (overrun_check_realloc, overrun_check_free):
3500 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3501 That way, xmalloc returns a properly-aligned pointer even if
3502 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3503 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3504 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3505 into account when calculating the initial malloc maximum.
3506 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3507 Move here from alloc.c, so that charset.c can use it too.
3508 Properly align; the old code wasn't right for common 32-bit hosts
3509 when configured with --enable-checking=all.
3510 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3511 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3513 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3515 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3518 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3520 * xdisp.c (compute_display_string_end): If there's no display
3521 string at CHARPOS, return -1.
3523 * bidi.c (bidi_fetch_char): When compute_display_string_end
3524 returns a negative value, treat the character as a normal
3525 character not covered by a display string. (Bug#9624)
3527 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3529 * lread.c (Fread_from_string): Fix typo in docstring.
3531 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3533 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3534 newline, reseat the iterator instead of bidi-iterating there one
3535 character at a time. (Bug#9610)
3536 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3537 TO_CHARPOS if the bidi iterator is at base embedding level.
3539 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3541 * lread.c (readevalloop): Use correct code for NBSP.
3542 (read1): Likewise. (Bug#9608)
3544 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3546 * dbusbind.c (Fdbus_register_signal): When service is not
3547 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3549 2011-09-25 Glenn Morris <rgm@gnu.org>
3551 * buffer.c (truncate-lines): Doc fix.
3553 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3555 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3556 (Fset_window_next_buffers): Doc fix.
3558 2011-09-24 Glenn Morris <rgm@gnu.org>
3560 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3562 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3564 Fix minor problems found by static checking.
3565 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3566 * indent.c (Fvertical_motion): Fix == vs = typo.
3568 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3570 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3571 Default value is now t. Doc fix.
3573 * indent.c (Fvertical_motion): Compute and apply the overshoot
3574 logic when moving up, not only when moving down. Fix the
3575 confusing name and values of the it_overshoot_expected variable;
3576 logic changes accordingly. (Bug#9254) (Bug#9549)
3578 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3579 CHARPOS is covered by a display string which includes newlines.
3580 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3581 is covered by a display string with embedded newlines.
3583 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3585 * dbusbind.c (Fdbus_register_signal): Add match rule to
3586 Vdbus_registered_objects_table. (Bug#9581)
3587 (Fdbus_register_method, Vdbus_registered_objects_table):
3590 2011-09-24 Jim Meyering <meyering@redhat.com>
3592 do not ignore write error for any output size
3593 The previous change was incomplete.
3594 While it makes emacs --batch detect the vast majority of stdout
3595 write failures, errors were still ignored whenever the output size is
3596 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3597 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3598 && echo FAIL: ignored write error
3599 FAIL: ignored write error
3600 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3601 && echo FAIL: ignored write error
3602 FAIL: ignored write error
3603 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3605 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3607 * emacs.c (Fkill_emacs): In noninteractive mode exit
3608 non-successfully if a write error occurred on stdout. (Bug#9574)
3610 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3612 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3615 * dispextern.h (struct it): Update the comment documenting what
3618 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3620 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3621 a display string, extend search for cursor position to end of row.
3622 (find_row_edges): If the row ends in a newline from a display
3623 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3624 Handle the case of a display string with multiple newlines.
3625 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3626 non-empty line. Fixes confusing cursor motion with arrow keys at
3627 the beginning of a line that starts with whitespace.
3629 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3631 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3634 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3636 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3639 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3641 * xdisp.c (display_line): Record maximum and minimum buffer
3642 positions even if no glyphs were produced (e.g., by a zero-width
3643 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3644 buffer positions that will be removed from the glyph row because
3646 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3647 column is beyond frame width: don't subtract 1 "pixel" when
3648 computing width of the stretch.
3649 (reseat_at_next_visible_line_start): Undo the change made on
3650 2011-09-17 that saved paragraph information and restored it after
3651 the call to `reseat'. (Bug#9545)
3653 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3655 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3656 and turn window cursor on if cleared (Bug#9415).
3658 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3660 * search.c (boyer_moore): Take unibyte characters from pattern
3661 literally. (Bug#9458)
3663 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3665 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3667 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3669 Fix minor problem found by static checking.
3670 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3671 initialized, to pacify gcc -Wuninitialized.
3673 * fileio.c: Report proper errno when syscall falls.
3674 (Finsert_file_contents): Save and restore errno,
3675 so that report_file_error outputs the correct diagnostic.
3676 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3678 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3680 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3682 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3684 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3685 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3687 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3689 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3690 about the current paragraph and restore it after the call to reseat.
3692 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3693 (bidi_find_paragraph_start): Search back for paragraph beginning
3694 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3695 (bidi_move_to_visually_next): Only trigger paragraph-related
3696 computations when the last character is a newline or at EOB, not
3697 just any NEUTRAL_B. (Bug#9470)
3699 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3700 truncated lines if point is covered by a display string. (Bug#9524)
3702 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3704 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3705 (cons_to_x_long): New function.
3706 (lisp_data_to_selection_data): Use it. Correct the test for
3707 short-versus-long data; it was negated. Break out of vector
3708 loop, for efficiency, when a long datum is discovered.
3710 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3712 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3714 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3716 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3717 GCC PR/17406) by declaring this function with external scope.
3719 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3721 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3722 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3724 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3726 * editfns.c (Fformat): Correctly handle text properties on "%%".
3728 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3730 * xterm.c (x_draw_composite_glyph_string_foreground):
3731 * w32term.c (x_draw_composite_glyph_string_foreground):
3732 * term.c (encode_terminal_code):
3733 * composite.c (composition_update_it, get_composition_id):
3734 * xdisp.c (get_next_display_element)
3735 (fill_composite_glyph_string): Add comments about special meaning
3736 of TAB characters in a composition.
3738 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3740 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3741 This occurs when processing a multibyte format.
3742 Problem reported by Wolfgang Jenker.
3744 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3746 * xdisp.c (try_cursor_movement): Only check for exact match if
3747 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3749 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3751 Remove unused external symbols.
3752 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3753 * xdisp.c (calc_pixel_width_or_height): Now static.
3754 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3755 * indent.c (check_display_width):
3756 * w32term.c: Fix comment to match code.
3757 * xterm.c, xterm.h (x_catching_errors): Remove.
3759 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3761 * xselect.c: Use signed conversions more consistently (Bug#9498).
3762 (selection_data_to_lisp_data): Assume incoming selection data are
3763 signed integers, not unsigned. This is to be consistent with
3764 outgoing selection data, which was modified to use signed integers
3765 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3766 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3767 expects long, not unsigned long.
3769 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3771 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3772 computation of loop end. Reported by Johan Bockgård
3775 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3777 * frame.c (Fother_visible_frames_p): Function deleted.
3779 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3781 * indent.c (compute_motion): Process display vector front to back
3782 rather than the other way around. (Bug#2496)
3784 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3786 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3788 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3790 * minibuf.c (Fread_from_minibuffer): Doc fix.
3792 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3794 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3795 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3797 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3799 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3800 value for non-existent files.
3802 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3804 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3805 set its "size" to -1. This will set the modtime_size field of
3806 the corresponding buffer to -1, which is what
3807 verify-visited-file-modtime expects for files that do not exist.
3810 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3812 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3814 * lisp.h: ... from here. push_key_description is no longer
3815 defined in keyboard.c, so its declaration should not be in
3816 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3817 logically belongs with push_key_description.
3819 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3821 * buffer.h: Include <sys/types.h> instead of <time.h>.
3822 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3823 Problem reported by Herbert J. Skuhra.
3825 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3827 * xml.c (parse_region): Make the parsing work for
3828 non-comment-starting XML files again (bug#9144).
3830 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3832 * image.c (gif_load): Fix calculation of bottom and right corner.
3835 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3837 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3838 redisplay in small windows.
3840 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3842 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3844 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3846 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3847 Operate on live windows only.
3849 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3851 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3853 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3855 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3856 only under bidi iteration.
3858 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3860 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3862 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3864 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3865 Without this fix, the command to link temacs failed due to an
3866 undefined symbol __builtin_isnan. This is because
3867 /usr/include/iso/math_c99.h #defines isnan(x) to
3868 __builtin_isnan(x), but the bundled gcc, which identifies itself
3869 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3871 * floatfns.c (isnan): #undef, and then #define to a clone of
3873 (Fisnan): Always define, since it's always available now.
3874 (syms_of_floatfns): Always define isnan at the Lisp level.
3876 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3878 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3880 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3882 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3883 The previous code assumed that file offsets (off_t values) fit in
3884 EMACS_INT variables, which is not true on typical 32-bit hosts.
3885 The code messed up by falsely reporting buffer overflow in cases
3886 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3887 when "big" contains more than 2**29 bytes, even though this
3888 inserts just one byte and does not overflow the buffer.
3889 (Finsert_file_contents): Store file offsets as off_t
3890 values, not as EMACS_INT values. Check for overflow when
3891 converting between EMACS_INT and off_t. When checking for
3892 buffer overflow or for overlap, take the offsets into account.
3893 Don't use EMACS_INT for small values where int suffices.
3894 When checking for overlap, fix a typo: ZV was used where
3895 ZV_BYTE was intended.
3896 (Fwrite_region): Don't assume off_t fits into 'long'.
3897 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3899 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3901 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3903 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3905 sprintf-related integer and memory overflow issues (Bug#9412).
3907 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3908 (esprintf, exprintf, evxprintf): New functions.
3909 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3910 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3911 (modify_event_symbol): Do not assume that the length of
3912 name_alist_or_stem is safe to alloca and fits in int.
3913 (Fexecute_extended_command): Likewise for function name and binding.
3914 (Frecursion_depth): Wrap around reliably on integer overflow.
3915 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3916 since some callers pass EMACS_INT values.
3917 (Fsingle_key_description): Don't crash if symbol name contains more
3918 than MAX_ALLOCA bytes.
3919 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3920 (get_minibuffer): Arg is now EMACS_INT, not int.
3921 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3922 (esprintf, exprintf, evxprintf): New decls.
3923 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3925 * dbusbind.c (signature_cat): New function.
3926 (xd_signature, Fdbus_register_signal):
3927 Do not overrun buffer; instead, report string overflow.
3929 * dispnew.c (add_window_display_history): Don't overrun buffer.
3930 Truncate instead; this is OK since it's just a log.
3932 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3933 even if the time zone offset is outlandishly large.
3934 Don't mishandle offset == INT_MIN.
3936 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3937 when creating daemon; the previous buffer-overflow check was incorrect.
3939 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3940 which has the guts of the old verror function.
3942 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3943 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3945 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3946 (font_unparse_xlfd): Don't blindly alloca long strings.
3947 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3948 fits in int, when using sprintf. Use single snprintf to count
3949 length of string rather than counting it via multiple sprintfs;
3950 that's simpler and more reliable.
3951 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3952 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3953 sprintf, in case result does not fit in int.
3955 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3956 (fontset_from_font): Print it.
3958 * frame.c (tty_frame_count): Now printmax_t, not int.
3959 (make_terminal_frame, set_term_frame_name): Print it.
3960 (x_report_frame_params): In X, window IDs are unsigned long,
3961 not signed long, so print them as unsigned.
3962 (validate_x_resource_name): Check for implausibly long names,
3963 and don't assume name length fits in 'int'.
3964 (x_get_resource_string): Don't blindly alloca invocation name;
3965 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3968 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3969 (xg_check_special_colors, xg_set_geometry):
3970 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3972 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3973 Use esprintf, not sprintf, in case result does not fit in int.
3975 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3976 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3977 it as a large positive number.
3978 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3979 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3981 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3982 in case result does not fit in int.
3984 * print.c (float_to_string): Detect width overflow more reliably.
3985 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3986 buffer overrun. Don't assume list length fits in 'int'. Treat
3987 print length of 0 as 0, not as infinity; to be consistent with other
3988 uses of print length in this function. Don't overflow print length
3989 index. Don't assume hash table size fits in 'long', or that
3990 vectorlike size fits in 'unsigned long'.
3992 * process.c (make_process): Use printmax_t, not int, to format
3993 process-name gensyms.
3995 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3997 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3998 to avoid potential buffer overrun.
4000 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4001 if X resource line is longer than 512 bytes.
4003 * xfns.c (x_window): Make sprintf buffer a bit bigger
4004 to avoid potential buffer overrun.
4006 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4008 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4010 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4012 Integer overflow fixes for scrolling, etc.
4013 Without these, Emacs silently mishandles large integers sometimes.
4014 For example, "C-u 4294967297 M-x recenter" was treated as if
4015 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4017 * xdisp.c (try_window_id): Check Emacs fixnum range before
4018 converting to 'int'.
4020 * window.c (window_scroll_line_based, Frecenter):
4021 Check that an Emacs fixnum is in range before assigning it to 'int'.
4022 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4023 values converted from Emacs fixnums.
4024 (Frecenter): Don't wrap around a line count if it is out of 'int'
4025 range; instead, treat it as an extreme value.
4026 (Fset_window_configuration, compare_window_configurations):
4027 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4029 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4030 that can exceed INT_MAX. Check that EMACS_INT value is in range
4031 before assigning it to the (possibly-narrower) index.
4032 (match_limit): Don't assume that a fixnum can fit in 'int'.
4034 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4037 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4038 (Fvertical_motion): Don't wrap around LINES values that don't fit
4039 in 'int'. Instead, treat them as extreme values. This is good
4040 enough for windows, which can't have more than INT_MAX lines anyway.
4042 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4044 * Require libxml/parser.h to avoid compilation warning.
4046 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4048 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4049 since this reportedly can destroy thread storage.
4051 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4053 * syntax.c (find_defun_start): Update all cache variables if
4054 exiting early (Bug#9401).
4056 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4058 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4060 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4061 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4062 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4064 * term.c (tty_append_glyph): New function.
4065 (produce_stretch_glyph): Static function and its prototype deleted.
4067 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4070 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4072 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4073 when checking :margin (Bug#9390).
4074 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4075 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4076 so that the name doesn't mislead. All uses changed.
4078 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4080 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4083 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4085 * xdisp.c (move_it_to): Don't bail out early when reaching
4086 position beyond to_charpos, if we are scanning backwards.
4087 (move_it_vertically_backward): When DY == 0, make sure we get to
4088 the first character in the line after the newline.
4090 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4092 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4093 (ccl_driver): Do not generate an out-of-range pointer.
4094 (Fccl_execute_on_string): Remove unnecessary check for
4095 integer overflow, noted by Stefan Monnier in
4096 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4097 Remove a FIXME that didn't need fixing.
4098 Simplify the newly-introduced buffer reallocation code.
4100 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4102 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4104 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4106 Integer and memory overflow issues (Bug#9196).
4108 * doc.c (get_doc_string): Rework so that
4109 get_doc_string_buffer_size is the actual buffer size, rather than
4110 being 1 less than the actual buffer size; this makes xpalloc more
4113 * image.c (x_allocate_bitmap_record, cache_image):
4114 * xselect.c (Fx_register_dnd_atom):
4115 Simplify previous changes by using xpalloc.
4117 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4118 since either will do and ptrdiff_t is convenient with xpalloc.
4120 * charset.c (charset_table_size)
4121 (struct charset_sort_data.priority): Now ptrdiff_t.
4122 (charset_compare): Don't overflow if priorities differ greatly.
4123 (Fsort_charsets): Don't assume list length fits in int.
4124 Check for size-calculation overflow when allocating sort data.
4125 (syms_of_charset): Allocate an initial charset table that is
4126 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4128 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4130 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4131 The actual value is always <= INT_MAX, and leaving it unsigned made
4132 overflow checking harder.
4134 * dispextern.h (struct glyph_matrix.rows_allocated)
4135 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4136 with xpalloc. The values are still always <= INT_MAX.
4138 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4140 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4141 (SAFE_NALLOCA): New macro.
4143 * region-cache.c (struct boundary.pos, find_cache_boundary)
4144 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4145 (set_cache_region, invalidate_region_cache)
4146 (revalidate_region_cache, know_region_cache, region_cache_forward)
4147 (region_cache_backward, pp_cache):
4148 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4149 so that ptrdiff_t * can be passed to xpalloc.
4150 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4151 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4152 (pp_cache): Don't assume cache_len fits in int.
4153 * region-cache.h: Adjust extern decls to match.
4155 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4156 EMACS_INT, since either will do, for xpalloc.
4158 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4159 (xnmalloc, xnrealloc, xpalloc): New functions.
4161 * bidi.c (bidi_shelve_header_size): New constant.
4162 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4163 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4165 * bidi.c (bidi_cache_shrink):
4166 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4168 Don't update size of array until after memory allocation succeeds,
4169 because xmalloc/xrealloc may not return.
4170 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4171 now that we have proper integer overflow checking.
4172 (record_overlay_string, overlay_strings): Catch overflows when
4173 calculating size of overlay_str_buf.
4175 * callproc.c (Fcall_process): Check for size overflow when
4176 calculating size of args2.
4177 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4178 Normally we prefer signed values, but sticking with ptrdiff_t would
4179 require adding more-complicated checks.
4181 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4182 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4183 Redo buffer-overflow calculations to avoid integer overflow.
4184 Add a FIXME comment where memory seems to be over-allocated.
4186 * character.c (Fstring): Check for size-calculation overflow.
4188 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4189 unnecessary integer overflow. Check for size overflow.
4190 (encode_coding_object): Don't update size until xmalloc succeeds.
4192 * composite.c (get_composition_id): Check for overflow in glyph
4193 length calculations.
4195 Integer and memory overflow fixes for display code.
4196 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4197 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4198 (scrolling_window): Check for overflow in size calculations.
4199 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4200 Don't assume glyph table len fits in int.
4201 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4202 (row_table_size): Now ptrdiff_t, not int.
4203 (scrolling_window): Avoid overflow in size calculations.
4204 Don't update size until allocation succeeds.
4205 * fns.c (concat): Check for overflow in size calculations.
4206 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4207 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4208 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4210 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4211 (get_doc_string): Check for size calculation overflow.
4212 Don't update size until allocation succeeds.
4213 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4214 EMACS_INT, where ptrdiff_t will do.
4215 (Fsubstitute_command_keys): Check for string overflow.
4217 * editfns.c (set_time_zone_rule): Don't assume environment length
4219 (message_length): Now ptrdiff_t, not int.
4220 (Fmessage_box): Don't update size until allocation succeeds.
4221 Don't assume message length fits in int.
4222 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4224 * emacs.c (main): Do not reallocate argv, since there is a null at
4225 the end that can be overwritten, and this way there's no need to
4226 worry about size-calculation overflow.
4227 (sort_args): Check for size-calculation overflow.
4229 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4231 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4233 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4234 (x_set_scroll_bar_width, x_figure_window_size):
4235 Check for integer overflow.
4236 (x_set_alpha): Do not assume XINT fits in int.
4238 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4239 This is for the members text_lines, text_cols, total_lines, total_cols,
4240 where the system imposes an 'int' limit.
4242 * fringe.c (Fdefine_fringe_bitmap):
4243 Don't update size until alloc works.
4245 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4246 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4248 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4249 Check for size-calculation overflow.
4250 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4251 do, as we prefer signed integers.
4252 (id_to_widget.max_size, id_to_widget.used)
4253 (xg_store_widget_in_map, xg_remove_widget_from_map)
4254 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4255 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4256 Use and return ptrdiff_t, not int.
4257 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4258 * gtkutil.h: Change prototypes to match the above.
4260 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4261 are duplicate now that they've been promoted to lisp.h.
4262 (x_allocate_bitmap_record, x_alloc_image_color)
4263 (make_image_cache, cache_image, xpm_load):
4264 Don't update size until alloc is done.
4265 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4267 Check for size calculation overflow.
4268 (ct_colors_allocated_max): New constant.
4269 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4272 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4273 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4274 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4275 Use ptrdiff_t, not int, to count maps.
4276 (read_char_minibuf_menu_prompt): Check for overflow in size
4277 calculations. Don't update size until allocation succeeds.
4278 Redo calculations to avoid overflow.
4279 * keyboard.h: Change prototypes to match the above.
4281 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4283 (current_minor_maps): Check for size calculation overflow.
4284 * keymap.h: Change prototypes to match the above.
4286 * lread.c (read1, init_obarray): Don't update size until alloc done.
4288 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4289 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4291 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4292 Now ptrdiff_t, not int.
4293 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4294 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4296 * process.c (Fnetwork_interface_list): Check for overflow
4297 in size calculation.
4299 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4301 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4302 overflow. Don't bother calling xmalloc when xrealloc will do.
4304 * search.c (Freplace_match): Check for size calculation overflow.
4305 (Fset_match_data): Don't assume list lengths fit in 'int'.
4307 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4308 for command line length. Do not attempt to address one before the
4309 beginning of an array, as that's not portable.
4311 * term.c (max_frame_lines): Remove; unused.
4312 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4314 (encode_terminal_code, calculate_costs): Check for size
4315 calculation overflow.
4316 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4317 table lengths and related sizes. Don't update size until alloc
4318 done. Redo calculations to avoid overflow.
4319 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4321 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4322 subtracting pointers.
4323 (gobble_line): Check for overflow more carefully. Don't update size
4326 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4327 Don't update size until alloc done.
4328 Redo size calculations to avoid overflow.
4329 Check for size calculation overflow.
4330 (main) [DEBUG]: Fix typo in invoking tparam1.
4332 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4333 Use ptrdiff_t, not int, for sizes.
4334 (store_mode_line_noprop_char): Don't update size until alloc done.
4336 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4337 Use ptrdiff_t, not int, for sizes.
4338 (Finternal_make_lisp_face, cache_face):
4339 Check for size calculation overflow.
4340 (cache_face): Treat size calculation overflows as if they were
4341 memory exhaustion (the usual treatment), rather than aborting.
4343 * xfns.c (x_encode_text, x_set_name_internal)
4344 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4345 sizes, since they can exceed INT_MAX in size. Check for size
4346 calculation overflow.
4348 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4349 (xg_select): Check for size calculation overflow.
4350 Don't update size until alloc done.
4352 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4353 as sprintf is limited to int lengths.
4355 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4356 (X_LONG_MIN): New macros.
4357 Use them to make the following changes clearer.
4358 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4359 This change doesn't affect the value now, but it may help remind
4360 future maintainers not to raise the value too much later.
4361 (SELECTION_QUANTUM): Remove, replacing with ...
4362 (selection_quantum): ... new function, which avoids overflow.
4364 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4365 assumption that selection length fits in 'int'.
4366 (x_reply_selection_request, x_handle_selection_request)
4367 (x_get_window_property, receive_incremental_selection)
4368 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4369 (lisp_data_to_selection_data, clean_local_selection_data):
4370 Use ptrdiff_t, not int, to record length of selection.
4371 (x_reply_selection_request, x_get_window_property)
4372 (receive_incremental_selection, x_property_data_to_lisp):
4373 Redo calculations to avoid overflow.
4374 (x_reply_selection_request): When sending hint, ceiling it at
4375 X_LONG_MAX rather than relying on wraparound overflow to send
4377 (x_get_window_property, receive_incremental_selection)
4378 (lisp_data_to_selection_data, x_property_data_to_lisp):
4379 Check for size-calculation overflow.
4380 (x_get_window_property, receive_incremental_selection)
4381 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4382 Don't store size until memory allocation succeeds.
4383 (x_get_window_property): Plug memory leak on memory exhaustion.
4384 Don't double-block input; malloc is safe here. Don't assume 2**34
4385 - 4 fits in unsigned long. Add an xassert to check
4386 XGetWindowProperty overflow. Be more careful about overflow
4387 calculations, and distinguish size from memory overflow better.
4388 (receive_incremental_selection): When tracing, don't assume
4389 unsigned int is less than INT_MAX.
4390 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4391 harmful) conversions of unsigned short to int.
4392 (lisp_data_to_selection_data): Don't assume that integers
4393 in the range -65535 through -1 fit in an X unsigned short.
4394 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4395 result parameters unless successful. Rely on cons_to_unsigned
4396 to report problems with elements; the old code wasn't right anyway.
4397 (x_check_property_data): Check for int overflow; we cannot use
4398 a wider type due to X limits.
4399 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4401 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4403 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4404 (x_term_init): Check for size calculation overflow.
4405 (x_color_cells): Don't store size until memory allocation succeeds.
4406 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4407 Don't assume alloca size is less than MAX_ALLOCA.
4408 (x_term_init): Don't assume length fits in int (sprintf is limited
4411 Use ptrdiff_t for composition IDs.
4412 * character.c (lisp_string_width):
4413 * composite.c (composition_table_size, n_compositions)
4414 (get_composition_id, composition_gstring_from_id):
4415 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4416 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4417 * window.c (Frecenter):
4418 Use ptrdiff_t, not int, for composition IDs.
4419 * composite.c (get_composition_id): Check for integer overflow.
4420 * composite.h: Adjust prototypes to match the above changes.
4422 Use ptrdiff_t for hash table indexes.
4423 * category.c (hash_get_category_set):
4424 * ccl.c (ccl_driver):
4425 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4426 * coding.c (coding_system_charset_list, detect_coding_system):
4427 * coding.h (struct coding_system.id):
4428 * composite.c (get_composition_id, gstring_lookup_cache):
4429 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4430 * image.c (xpm_get_color_table_h):
4431 * lisp.h (hash_lookup, hash_put):
4432 * minibuf.c (Ftest_completion):
4433 Use ptrdiff_t for hash table indexes, not int (which is too
4434 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4435 32-bit --with-wide-int hosts).
4437 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4438 Add a FIXME comment about memory leaks.
4439 (syms_of_charset): Don't assume xmalloc returns.
4441 Don't assume that stated character widths fit in int.
4442 * character.c (Fchar_width, c_string_width, lisp_string_width):
4443 * character.h (CHAR_WIDTH):
4444 * indent.c (MULTIBYTE_BYTES_WIDTH):
4445 Use sanitize_char_width to avoid undefined and/or bad behavior
4446 with outlandish widths.
4447 * character.h (sanitize_tab_width): Rename from sanitize_width,
4448 now that we have two such functions. All uses changed.
4449 (sanitize_char_width): New inline function.
4451 Don't assume that tab-width fits in int.
4452 * character.h (sanitize_width): New inline function.
4453 (SANE_TAB_WIDTH): New macro.
4454 (ASCII_CHAR_WIDTH): Use it.
4455 * indent.c (sane_tab_width): Remove. All uses replaced by
4456 SANE_TAB_WIDTH (current_buffer).
4457 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4459 * fileio.c: Integer overflow issues with file modes.
4460 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4462 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4463 Remove unreachable code.
4464 (read_hex, load_charset_map_from_file): Check for integer overflow.
4466 * xterm.c: Don't go over XClientMessageEvent limit.
4467 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4468 (x_send_scroll_bar_event): Likewise. Check that the size does not
4469 exceed limits imposed by XClientMessageEvent, as well as the usual
4470 ptrdiff_t and size_t limits.
4472 * keyboard.c: Overflow, signedness and related fixes.
4473 (make_lispy_movement): Use same integer type in forward decl
4474 that is used in the definition.
4475 (read_key_sequence, keyremap_step):
4476 Change bufsize argument back to int, undoing my 2011-03-30 change.
4477 We prefer signed types, and int is wide enough here.
4478 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4479 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4480 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4481 length, not size_t. Use ptrdiff_t for index, not int.
4482 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4483 possibility of integer overflow.
4485 Overflow, signedness and related fixes for images.
4487 * dispextern.h (struct it.stack[0].u.image.image_id)
4488 (struct_it.image_id, struct image.id, struct image_cache.size)
4489 (struct image_cache.used, struct image_cache.ref_count):
4490 * gtkutil.c (update_frame_tool_bar):
4491 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4492 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4493 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4494 * nsmenu.m (update_frame_tool_bar):
4495 * xdisp.c (calc_pixel_width_or_height):
4496 * xfns.c (image_cache_refcount):
4497 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4498 on typical 64-bit hosts.
4500 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4501 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4502 Omit unnecessary casts to int.
4503 (parse_image_spec): Check that integers fall into 'int' range
4504 when the callers expect that.
4505 (image_ascent): Redo ascent calculation to avoid int overflow.
4506 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4507 (lookup_image): Remove unnecessary tests.
4508 (xbm_image_p): Locals are now of int, not EMACS_INT,
4509 since parse_image_check makes sure they fit into int.
4510 (png_load, gif_load, svg_load_image):
4511 Prefer int to unsigned where either will do.
4512 (tiff_handler): New function, combining the cores of the
4513 old tiff_error_handler and tiff_warning_handler.
4514 This function is rewritten to use vsnprintf and thereby avoid
4515 stack buffer overflows. It uses only the features of vsnprintf
4516 that are common to both POSIX and native Microsoft.
4517 (tiff_error_handler, tiff_warning_handler): Use it.
4518 (tiff_load, gif_load, imagemagick_load_image):
4519 Don't assume :index value fits in 'int'.
4520 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4521 (imagemagick_load_image): Check that crop parameters fit into
4522 the integer types that MagickCropImage accepts. Don't assume
4523 Vimagemagick_render_type has a nonnegative value. Don't assume
4524 size_t fits in 'long'.
4525 (gs_load): Use printmax_t to print the widest integers possible.
4526 Check for integer overflow when computing image height and width.
4528 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4530 * xdisp.c (redisplay_window): Don't force window start if point
4531 will be invisible in the resulting window. (Bug#9324)
4533 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4535 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4536 the display spec is of the form `(space ...)'.
4537 (handle_display_spec): Return the value returned by
4538 handle_single_display_spec, not just 1 or zero.
4539 (handle_single_display_spec): If the display spec is of the form
4540 `(space ...)', and specifies display in the text area, return 2
4542 (try_cursor_movement): Check for the need to scroll more
4543 accurately, and prefer exact match for point under bidi.
4544 Don't advance `row' beyond the last row of the window.
4546 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4547 into disp_prop; all users changed.
4549 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4550 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4551 for the text covered by the display property.
4553 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4555 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4556 Change return value to nil.
4557 (Frecord_buffer): Delete unused function.
4559 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4561 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4562 buffers, return left-to-right.
4563 (set_cursor_from_row): Consider candidate row a win if its glyph
4564 represents a newline and point is on that newline. Fixes cursor
4565 positioning on the newline at EOL of R2L text within L2R
4566 paragraph, and vice versa.
4567 (try_cursor_movement): Check continued rows, in addition to
4568 continuation rows. Fixes unwarranted scroll when point enters a
4569 continued line of R2L text within an L2R paragraph, or vice versa.
4570 (cursor_row_p): Consider the case of point being equal to
4571 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4572 from the end of a short line to the beginning of a continued line
4573 of R2L text within L2R paragraph.
4574 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4575 composed characters.
4577 * bidi.c (bidi_check_type): Use xassert.
4578 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4581 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4583 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4586 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4588 * nsfont.m (ns_otf_to_script): Fix typo.
4590 2011-08-22 Kenichi Handa <handa@m17n.org>
4592 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4593 extra slot even if the purpose is char-code-property-table.
4595 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4597 * xdisp.c (redisplay_window): When computing centering_position,
4598 account for the height of the header line. (Bug#8874)
4600 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4601 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4602 candidate is selected by the mouse, and that candidate has a
4603 composed character under the mouse.
4605 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4606 coordinates reported by pos-visible-in-window-p for a composed
4607 character in column zero.
4609 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4611 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4613 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4615 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4616 consider it a hit if to_charpos is anywhere in the range of the
4617 composed buffer positions.
4619 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4621 * image.c (gif_load): Don't assume that each subimage has the same
4622 dimensions as the base image. Handle disposal method that is
4623 "undefined" by the gif spec (Bug#9335).
4625 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4627 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4628 (Fcondition_case): Document `debug' symbol in error handler.
4630 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4632 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4633 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4634 from an Org mode buffer to a Speedbar frame.
4636 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4637 a composition, take its buffer position from IT->cmp_it.charpos.
4638 Fixes cursor positioning at the beginning of a line that begins
4639 with a composed character.
4641 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4643 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4644 character bidirectional type, use STRONG_L instead. Fixes crashes
4645 in a buffer produced by `describe-categories'.
4647 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4648 members before the level stack, so they would be saved and
4649 restored when copying iterator state. Fixes incorrect reordering
4650 around TABs covered by display properties.
4652 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4654 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4656 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4658 * eval.c (internal_condition_case, internal_condition_case_1)
4659 (internal_condition_case_2, internal_condition_case_n):
4660 Remove unnecessary aborts (Bug#9081).
4662 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4664 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4665 has no `load' handler, try opening the file locally. (Bug#9311)
4667 2011-08-16 Ken Brown <kbrown@cornell.edu>
4669 * gmalloc.c: Expand comment.
4671 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4673 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4674 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4676 2011-08-16 Ken Brown <kbrown@cornell.edu>
4678 Fix memory allocation problems in Cygwin build (Bug#9273).
4680 * unexcw.c ( __malloc_initialized): Declare external variable.
4681 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4683 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4685 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4687 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4689 [CYGWIN] (special_realloc): New function.
4690 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4691 requests to realloc storage in the static heap.
4693 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4695 * bidi.c (bidi_initialize): Remove unused local.
4697 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4700 * biditype.h: Remove file.
4701 * makefile.w32-in ($(BLD)/bidi.$(O)):
4702 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4704 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4706 * chartab.c: Improve commentary for the uniprop_table API.
4708 * bidi.c (bidi_paragraph_init): Support zero value of
4709 bidi_ignore_explicit_marks_for_paragraph_level.
4710 (bidi_initialize): Use uniprop_table instead of including
4711 biditype.h and bidimirror.h.
4713 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4714 coordinates of the iterator when restoring from ppos_it.
4717 2011-08-14 Kenichi Handa <handa@m17n.org>
4719 * process.c (create_process): Call setup_process_coding_systems
4720 after the pid of the process is set to -1 (Bug#8162).
4722 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4724 * xdisp.c (move_it_in_display_line_to): Don't invoke
4725 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4726 ppos_it. Fixes vertical cursor motion when line beginning is
4727 covered by an image. (Bug#9296)
4729 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4731 * nsterm.h (ns_run_ascript): Declare.
4732 (NSAPP_DATA2_RUNASSCRIPT): Define.
4734 * nsfns.m (as_script, as_result, as_status): New static variables.
4735 (ns_run_ascript): New function.
4736 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4737 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4738 the event loop. Get status from as_status (Bug#7276).
4740 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4741 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4742 the event loop (Bug#7276).
4744 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4746 * gnutls.c (QCgnutls_bootprop_priority)
4747 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4748 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4749 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4750 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4751 (QCgnutls_bootprop_verify_hostname_error)
4752 (QCgnutls_bootprop_callbacks_verify): Rename from
4753 Qgnutls_bootprop_..., all uses changed.
4755 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4758 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4760 * xfaces.c (Qframe_set_background_mode): Now static.
4761 * dispextern.h (Qframe_set_background_mode): Remove decl.
4763 * process.c (Fnetwork_interface_info): Declare local only if needed.
4765 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4767 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4768 (Fnetwork_interface_list): Allocate in increments of bytes instead
4769 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4770 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4772 (struct ifflag_def): notrailers is smart on OSX.
4773 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4774 Get hardware address with getifaddrs if available.
4776 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4778 * xdisp.c (iterate_out_of_display_property): xassert that
4779 IT->position is set to within IT->object's boundaries. Break from
4780 the loop as soon as EOB is reached; avoids infloops in redisplay
4781 when IT->position is set up wrongly due to some bug.
4782 Set IT->current to match the bidi iterator unconditionally.
4783 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4784 entry. Force push_it to save on the stack the current
4785 buffer/string position, to be restored by pop_it. Fix flags in
4786 the iterator structure wrt the object coming from a display
4787 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4788 properties. (Bug#9284)
4790 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4792 * fontset.c (fontset_get_font_group): Add proper type checks.
4795 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4797 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4798 and LC_VERSION_MIN_MACOSX.
4799 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4800 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4802 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4804 * xdisp.c (forward_to_next_line_start): Allow to use the
4805 no-display-properties-and-no-overlays under bidi display.
4806 Set disp_pos in the bidi iterator to avoid searches for display
4807 properties and overlays.
4809 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4811 * editfns.c (Fset_time_zone_rule): Document relationship with the
4814 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4815 the font entity extracted from the cache (Bug#8109).
4817 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4819 * composite.c (autocmp_chars): Don't reset point. That is done by
4820 restore_point_unwind (Bug#5984).
4822 2011-08-07 Juri Linkov <juri@jurta.org>
4824 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4825 to show the arg `TIME' instead of `TIMEVAL'.
4827 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4829 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4830 display property strides EOL and includes a newline, as in
4831 longlines-mode. (Bug#9254)
4832 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4833 word-wrap under bidirectional display. (Bug#9224)
4835 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4836 is non-zero, even if the data buffer is NULL. Fixes a crash in
4837 vertical-motion with longlines-mode. (Bug#9254)
4839 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4841 * bidi.c <bidi_cache_total_alloc>: Now static.
4842 (bidi_initialize): Initialize bidi_cache_total_alloc.
4844 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4847 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4848 amount allocated this far in `bidi_cache_total_alloc'.
4849 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4850 non-zero, only free the data buffer without restoring the cache
4851 contents. All callers changed.
4853 * dispextern.h (bidi_unshelve_cache): Update prototype.
4855 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4856 (move_it_in_display_line, move_it_to)
4857 (move_it_vertically_backward, move_it_by_lines): Replace the call
4858 to xfree to an equivalent call to bidi_unshelve_cache.
4859 (move_it_in_display_line_to): Fix logic of returning
4860 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4862 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4864 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4865 came from a string character with a `cursor' property. (Bug#9229)
4867 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4869 * Makefile.in (LIB_PTHREAD): New variable.
4870 (LIBES): Add LIB_PTHREAD (Bug#9216).
4872 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4873 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4875 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4877 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4879 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4881 * xterm.c (x_find_topmost_parent): New function.
4882 (x_set_frame_alpha): Find topmost parent window with
4883 x_find_topmost_parent and set the property there also (bug#9181).
4884 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4886 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4888 * callproc.c (Fcall_process): Avoid vfork clobbering
4889 the local vars buffer, coding_systems, current_dir.
4891 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4893 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4895 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4897 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4898 so that it is not optimized away.
4900 * xdisp.c (compute_display_string_pos): Remove unused local.
4902 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4904 Fix slow cursor motion and scrolling in large buffers with
4905 selective display, like Org Mode buffers. (Bug#9218)
4907 * dispextern.h (struct bidi_it): New member disp_prop_p.
4909 * xdisp.c: Remove one-slot cache of display string positions.
4910 (compute_display_string_pos): Accept an additional argument
4911 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4912 for a display string or property. If found, set DISP_PROP_P
4915 * bidi.c (bidi_fetch_char): Accept an additional argument
4916 DISP_PROP_P, and pass it to compute_display_string_pos.
4917 Only handle text covered by a display string if DISP_PROP_P is returned
4918 non-zero. All callers of bidi_fetch_char changed.
4920 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4922 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4924 2010-12-03 Don March <don@ohspite.net>
4926 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4927 last character M-[char] is translated to ESC [char] (bug#7541).
4929 2011-08-02 Kenichi Handa <handa@m17n.org>
4931 * lisp.h (uniprop_table): Extern it.
4933 * chartab.c (uniprop_table): Make it non-static.
4935 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4937 * xdisp.c (forward_to_next_line_start): Accept additional argument
4938 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4940 (reseat_at_next_visible_line_start): Use the bidi iterator state
4941 returned by forward_to_next_line_start to restore the state of
4942 it->bidi_it after backing up to previous newline. (Bug#9212)
4944 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4946 * regex.c (re_comp): Protoize.
4947 (re_exec): Fix return type.
4948 (regexec): Fix type of `ret'. (Bug#9203)
4950 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4952 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4953 This is needed if max-image-size is a floating-point number.
4955 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4957 * print.c (print_object): Print empty symbol as ##.
4959 * lread.c (read1): Read ## as empty symbol.
4961 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4963 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4964 setting frame foreground color (Bug#9175).
4965 (x_set_background_color): Likewise.
4967 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4968 contents (Bug#9176).
4969 (EmacsTooltip -init): Remove bezels and add shadows to
4972 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4973 or scroll bar (Bug#8470).
4975 * nsfont.m (nsfont_open): Remove assignment to voffset and
4976 unnecessary vars hshink, expand, hd, full_height, min_height.
4977 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4979 * nsterm.h (nsfont_info): Remove voffset field.
4981 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4983 Implement strike-through and overline on NextStep (Bug#8863).
4985 * nsfont.m (nsfont_open): Use underline position provided by font,
4986 instead of hard-coded value of 2.
4987 (nsfont_draw): Call ns_draw_text_decoration instead.
4989 * nsterm.h: Add declaration for ns_draw_text_decoration.
4991 * nsterm.m (ns_draw_text_decoration): New function for drawing
4992 underline, overline, and strike-through.
4993 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4994 ns_draw_text_decoration. Change treatment of cursor drawing to
4995 accommodate underlining, etc.
4997 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4999 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5002 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5004 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5005 Without this fix, if a signal arrives just after memory fills up,
5006 'malloc' might be invoked reentrantly.
5008 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5009 In other words, assume that every image size is allowed, on non-X
5010 hosts. This assumption is probably wrong, but it lets Emacs compile.
5012 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5014 * regex.c (re_iswctype): Convert return values to boolean.
5016 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5018 * xdisp.c (compute_display_string_pos): Don't use cached display
5019 string position if the buffer had its restriction changed.
5022 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5024 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5026 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5028 Integer signedness and overflow and related fixes. (Bug#9079)
5030 * bidi.c: Integer size and overflow fixes.
5031 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5032 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5033 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5034 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5035 (bidi_find_other_level_edge):
5036 Use ptrdiff_t instead of EMACS_INT where either will do.
5037 This works better on 32-bit hosts configured --with-wide-int.
5038 (bidi_cache_ensure_space): Check for size-calculation overflow.
5039 Use % rather than repeated addition, for better worst-case speed.
5040 Don't set bidi_cache_size until after xrealloc returns, because it
5042 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5043 (bidi_cache_ensure_space): Also check that the bidi cache size
5044 does not exceed that of the largest Lisp string or buffer. See Eli
5045 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5047 * alloc.c (__malloc_size_t): Remove.
5048 All uses replaced by size_t. See Andreas Schwab's note
5049 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5051 * image.c: Improve checking for integer overflow.
5052 (check_image_size): Assume that f is nonnull, since
5053 it is always nonnull in practice. This is one less thing to
5054 worry about when checking for integer overflow later.
5055 (x_check_image_size): New function, which checks for integer
5056 overflow issues inside X.
5057 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5058 This removes the need for a memory_full check.
5059 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5060 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5061 (xbm_read_bitmap_data): Change locals back to 'int', since
5062 their values must fit in 'int'.
5063 (xpm_load_image, png_load, tiff_load):
5064 Invoke x_create_x_image_and_pixmap earlier,
5065 to avoid much needless work if the image is too large.
5066 (tiff_load): Treat overly large images as if
5067 x_create_x_image_and_pixmap failed, not as malloc failures.
5068 (gs_load): Use x_check_image_size.
5070 * gtkutil.c: Omit integer casts.
5071 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5072 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5074 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5076 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5077 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5078 would wrongly return t on a 64-bit host.
5080 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5081 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5082 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5083 and therefore cause GCC to emit a bogus diagnostic in some cases.
5085 * image.c: Integer signedness and overflow and related fixes.
5086 This is not an exhaustive set of fixes, but it's time to
5087 record what I've got.
5088 (lookup_pixel_color, check_image_size): Remove redundant decls.
5089 (check_image_size): Don't assume that arbitrary EMACS_INT values
5090 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5091 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5092 (tiff_load, imagemagick_load_image):
5093 Check for overflow in size calculations.
5094 (x_create_x_image_and_pixmap): Remove unnecessary test for
5095 xmalloc returning NULL; that can't happen.
5096 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5097 (xpm_color_bucket): Use better integer hashing function.
5098 (xpm_cache_color): Don't possibly over-allocate memory.
5099 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5100 (gif_memory_source):
5101 Use ptrdiff_t, not int or size_t, to record sizes.
5102 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5103 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5104 either works, as we prefer signed integers.
5105 (tiff_read_from_memory, tiff_write_from_memory):
5106 Return tsize_t, not size_t, since that's what the TIFF API wants.
5107 (tiff_read_from_memory): Don't fail simply because the read would
5108 go past EOF; instead, return a short read.
5109 (tiff_load): Omit no-longer-needed casts.
5110 (Fimagemagick_types): Don't assume size fits into 'int'.
5112 Improve hashing quality when configured --with-wide-int.
5113 * fns.c (hash_string): New function, taken from sxhash_string.
5114 Do not discard information about ASCII character case; this
5115 discarding is no longer needed.
5116 (sxhash-string): Use it. Change sig to match it. Caller changed.
5117 * lisp.h: Declare it.
5118 * lread.c (hash_string): Remove, since we now use fns.c's version.
5119 The fns.c version returns a wider integer if --with-wide-int is
5120 specified, so this should help the quality of the hashing a bit.
5122 * emacs.c: Integer overflow minor fix.
5123 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5124 Define only if GNU_LINUX.
5125 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5127 * dispnew.c: Integer signedness and overflow fixes.
5128 Remove unnecessary forward decls, that were a maintenance hassle.
5129 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5131 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5132 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5133 (prepare_desired_row, line_draw_cost):
5134 Use int, not unsigned, where either works.
5135 (save_current_matrix, restore_current_matrix):
5136 Use ptrdiff_t, not size_t, where either works.
5137 (init_display): Check for overflow more accurately, and without
5138 relying on undefined behavior.
5140 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5141 Remove, replacing with the new symbols in lisp.h. All uses changed.
5142 * fileio.c (make_temp_name):
5143 * filelock.c (lock_file_1, lock_file):
5144 * xdisp.c (message_dolog):
5145 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5146 Use pMd etc. instead.
5147 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5148 replacing the pWIDE etc. symbols removed from editfns.c.
5150 * keyboard.h (num_input_events): Now uintmax_t.
5151 This is (very slightly) less likely to mess up due to wraparound.
5154 * buffer.c: Integer signedness fixes.
5155 (alloc_buffer_text, enlarge_buffer_text):
5156 Use ptrdiff_t rather than size_t when either will do, as we prefer
5159 * alloc.c: Integer signedness and overflow fixes.
5160 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5161 (__malloc_size_t): Default to size_t, not to int.
5162 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5163 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5164 Prefer ptrdiff_t to size_t when either would do, as we prefer
5166 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5167 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5168 Now const. Initialize with values that are in range even if char
5170 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5171 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5172 These functions do the right thing with sizes > 2**32.
5173 (check_depth): Now ptrdiff_t, not int.
5174 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5175 Adjust to new way of storing sizes. Check for size overflow bugs
5177 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5178 slightly wrong anyway, as it missed one instance of
5179 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5180 (refill_memory_reserve): Omit needless cast to size_t.
5181 (mark_object_loop_halt): Mark as externally visible.
5183 * xselect.c: Integer signedness and overflow fixes.
5184 (Fx_register_dnd_atom, x_handle_dnd_message):
5185 Use ptrdiff_t, not size_t, since we prefer signed.
5186 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5187 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5188 x_dnd_atoms_size and x_dnd_atoms_length.
5190 * doprnt.c: Prefer signed to unsigned when either works.
5192 * doprnt.c (doprnt):
5194 * xdisp.c (vmessage):
5195 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5196 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5197 prefer signed arithmetic to avoid comparison confusion.
5198 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5199 but is a bit tricky.
5201 Assume freestanding C89 headers, string.h, stdlib.h.
5202 * data.c, doprnt.c, floatfns.c, print.c:
5203 Include float.h unconditionally.
5204 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5205 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5206 * regex.c: Likewise for stddef.h, string.h.
5207 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5208 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5209 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5210 (STDC_HEADERS): Remove obsolete defines.
5211 * sysdep.c: Include limits.h unconditionally.
5213 Assume support for memcmp, memcpy, memmove, memset.
5214 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5215 * regex.c (memcmp, memcpy):
5216 Remove; we assume C89 now.
5218 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5219 (__malloc_safe_bcopy): Remove; no longer needed.
5221 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5222 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5223 well either way, and we prefer signed to unsigned.
5225 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5227 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5228 closes the connection while we're reading (bug#9182).
5230 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5232 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5233 are specified (Bug#9168).
5235 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5237 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5238 Found by GCC static checking and --with-wide-int on a 32-bit host.
5240 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5242 * xdisp.c (compute_display_string_pos): Fix logic of caching
5243 previous display string position. Initialize cached_prev_pos to
5244 -1. Fixes slow-down at the beginning of a buffer.
5246 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5248 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5249 for attrs[LFACE_FONTSET_INDEX].
5251 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5253 * xml.c (parse_region): Remove unused local
5254 that was recently introduced.
5256 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5258 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5259 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5261 * xdisp.c (move_it_in_display_line_to): Record the best matching
5262 position for TO_CHARPOS while scanning the line, and restore it on
5263 exit if none of the characters scanned was an exact match.
5264 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5265 when exact match is impossible due to invisible text, and the
5266 lines are truncated.
5268 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5270 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5273 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5275 Fix a significant slow-down of cursor motion with C-n, C-p,
5276 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5277 auto-repeat under bidi redisplay in fontified buffers.
5278 * xdisp.c (compute_stop_pos_backwards): New function.
5279 (next_element_from_buffer): Call compute_stop_pos_backwards to
5280 find a suitable prev_stop when we find ourselves before
5282 (reseat): Don't look for prev_stop, as that could mean a very long
5284 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5285 <cached_disp_overlay_modiff>: Cache for last found display string
5287 (compute_display_string_pos): Return the cached position if asked
5288 about the same buffer in the same area of character positions, and
5289 the buffer wasn't changed since the time the display string
5290 position was cached.
5292 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5294 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5295 is an integer, which is important for empty lines. (Bug#9149)
5297 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5299 * frame.c (Fmodify_frame_parameters): In tty case, update the
5300 default face if necessary (Bug#4238).
5302 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5304 * editfns.c (Fstring_to_char): No need to explain what a character
5305 is in the docstring (Bug#6576).
5307 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5309 * xml.c (parse_region): Make sure we always return a tree.
5311 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5313 * xml.c (parse_region): If a document contains only comments,
5316 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5318 * xml.c (make_dom): Return comments, too.
5320 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5323 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5324 and the surrounding thread.
5325 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5326 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5327 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5329 * s/openbsd.h (BROKEN_SIGIO): Define.
5330 * unexelf.c (unexec) [__OpenBSD__]:
5331 Don't update the .mdebug section of the Alpha COFF symbol table.
5333 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5335 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5338 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5340 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5341 This fixes some race conditions on the permissions of any newly
5344 * alloc.c (valid_pointer_p): Use pipe, not open.
5345 This fixes some permissions issues when debugging.
5347 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5348 If fchown fails to set both uid and gid, try to set just gid,
5349 as that is sometimes allowed. Adjust the file's mode to eliminate
5350 setuid or setgid bits that are inappropriate if fchown fails.
5352 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5354 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5355 to compare Lisp_Objects.
5356 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5357 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5358 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5360 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5362 * lread.c (read_integer): Unread even EOF character.
5363 (read1): Likewise. Properly record start position of symbol.
5365 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5366 symbol character follows.
5368 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5370 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5371 This works around a problem with the previous change to Fcopy_file.
5372 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5373 and without this change, GCC might complain about discarding
5374 fchown's return value.
5376 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5378 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5380 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5382 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5384 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5386 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5387 it's used from the C level.
5389 * process.c: Use the same condition for POLL_FOR_INPUT in both
5390 keyboard.c and process.c (bug#1858).
5392 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5394 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5395 (Fgnutls_boot): Use it.
5397 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5399 * doc.c (Fsubstitute_command_keys): Revert last change.
5401 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5403 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5404 quotes the next character, and doesn't affect other longer
5405 sequences (bug#8935).
5407 * lread.c (syms_of_lread): Clarify that is isn't only
5408 `eval-buffer' and `eval-defun' that's affected by
5409 `lexical-binding' (bug#8460).
5411 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5413 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5414 bidi redisplay when a line includes both an image and is truncated.
5416 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5418 Fix minor problems found by static checking.
5419 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5420 (elsz): Now a signed constant, not a size_t var. We prefer signed
5421 types to unsigned, to avoid integer comparison confusion. Without
5422 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5423 "cannot optimize loop, the loop counter may overflow", a symptom
5425 * indent.c (Fvertical_motion): Mark locals as initialized.
5426 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5428 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5430 * search.c (Fre_search_backward): Mention `case-fold-search' in
5431 all the re_search_* functions (bug#8138).
5433 * keyboard.c (Fopen_dribble_file): Document when the file is
5436 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5438 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5441 Support bidi reordering of display and overlay strings.
5442 * xdisp.c (compute_display_string_pos)
5443 (compute_display_string_end): Accept additional argument STRING.
5444 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5445 (reseat_to_string): Initialize bidi_it->string.s and
5446 bidi_it->string.schars.
5447 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5448 NULL (avoids a crash in bidi_paragraph_init).
5449 Initialize itb.string.lstring.
5450 (init_iterator): Call bidi_init_it only of a valid
5451 buffer position was specified. Initialize paragraph_embedding to
5453 (reseat_to_string): Initialize the bidi iterator.
5454 (display_string): If we need to ignore text properties of
5455 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5456 original value of -1 will not work with bidi.)
5457 (compute_display_string_pos): First arg is now struct
5458 `text_pos *'; all callers changed. Support display properties on
5460 (compute_display_string_end): Support display properties on Lisp
5462 (init_iterator, reseat_1, reseat_to_string): Initialize the
5463 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5464 when iterating on a string not from display properties).
5465 (compute_display_string_pos, compute_display_string_end):
5466 Fix calculation of the object to scan. Fixes an error when using
5468 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5469 base_level_stop; instead, set base_level_stop to BEGV.
5470 Fixes crashes in vertical-motion.
5471 (next_element_from_buffer): Improve commentary for when
5472 the iterator is before prev_stop.
5473 (init_iterator): Initialize bidi_p from the default value of
5474 bidi-display-reordering, not from buffer-local value. Use the
5475 buffer-local value only if initializing for buffer iteration.
5476 (handle_invisible_prop): Support invisible properties on strings
5477 that are being bidi-reordered.
5478 (set_iterator_to_next): Support bidi reordering of C strings and
5480 (next_element_from_string): Support bidi reordering of Lisp
5482 (handle_stop_backwards): Support Lisp strings as well.
5483 (display_string): Support display of R2L glyph rows.
5484 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5485 (init_iterator): Don't initialize it->bidi_p for strings
5487 (reseat_to_string): Initialize it->bidi_p for strings here.
5488 (next_element_from_string, next_element_from_c_string)
5489 (next_element_from_buffer): Add xassert's for correspondence
5490 between IT's object being iterated and it->bidi_it.string
5492 (face_before_or_after_it_pos): Support bidi iteration.
5493 (next_element_from_c_string): Handle the case of the first string
5494 character that is not the first one in the visual order.
5495 (get_visually_first_element): New function, refactored from common
5496 parts of next_element_from_buffer, next_element_from_string, and
5497 next_element_from_c_string.
5498 (tool_bar_lines_needed, redisplay_tool_bar)
5499 (display_menu_bar): Force left-to-right direction. Add a FIXME
5500 comment for making that be controlled by a user option.
5501 (push_it, pop_it): Save and restore the state of the
5502 bidi iterator. Save and restore the bidi_p flag.
5503 (pop_it): Iterate out of display property for string iteration as
5505 (iterate_out_of_display_property): Support iteration over strings.
5506 (handle_single_display_spec): Set up it->bidi_it for iteration
5507 over a display string, and call bidi_init_it.
5508 (handle_single_display_spec, next_overlay_string)
5509 (get_overlay_strings_1, push_display_prop): Set up the bidi
5510 iterator for displaying display or overlay strings.
5511 (forward_to_next_line_start): Don't use the shortcut if
5513 (back_to_previous_visible_line_start): If handle_display_prop
5514 pushed the iterator stack, restore the internal state of the bidi
5515 iterator by calling bidi_pop_it same number of times.
5516 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5517 and we are bidi-iterating, don't decrement the iterator position;
5518 instead, set the first_elt flag in the bidi iterator, to produce
5520 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5521 (push_display_prop): xassert that we are iterating a buffer.
5522 (push_it, pop_it): Save and restore paragraph_embedding member.
5523 (handle_single_display_spec, next_overlay_string)
5524 (get_overlay_strings_1, reseat_1, reseat_to_string)
5525 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5526 correctly. Don't assume unibyte strings are not bidi-reordered.
5527 (compute_display_string_pos)
5528 (compute_display_string_end): Fix handling the case of C string.
5529 (push_it, pop_it): Save and restore from_disp_prop_p.
5530 (handle_single_display_spec, push_display_prop): Set the
5531 from_disp_prop_p flag.
5532 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5533 (pop_it): Call iterate_out_of_display_property only if we are
5534 popping after iteration over a string that came from a display
5535 property. Fix a typo in popping stretch info. Add an assertion
5536 for verifying that the iterator position is in sync with the bidi
5538 (handle_single_display_spec, get_overlay_strings_1)
5539 (push_display_prop): Fix initialization of paragraph direction for
5540 string when that of the parent object is not yet determined.
5541 (reseat_1): Call bidi_init_it to resync the bidi
5542 iterator with IT's position. (Bug#7616)
5543 (find_row_edges): If ROW->start.pos gives position
5544 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5545 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5546 Reset the from_disp_prop_p flag.
5547 (SAVE_IT, RESTORE_IT): New macros.
5548 (pos_visible_p, face_before_or_after_it_pos)
5549 (back_to_previous_visible_line_start)
5550 (move_it_in_display_line_to, move_it_in_display_line)
5551 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5552 (try_scrolling, redisplay_window, display_line): Use them when
5553 saving a temporary copy of the iterator and restoring it back.
5554 (back_to_previous_visible_line_start, reseat_1)
5555 (init_iterator): Empty the bidi cache "stack".
5556 (move_it_in_display_line_to): If iterator ended up at
5557 EOL, but we never saw any buffer positions smaller than
5558 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5559 motion in bidi-reordered lines.
5560 (move_it_in_display_line_to): Record prev_method and prev_pos
5561 immediately before the call to set_iterator_to_next. Fixes cursor
5562 motion in bidi-reordered lines with stretch glyphs and strings
5563 displayed in margins. (Bug#8133) (Bug#8867)
5564 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5566 (pos_visible_p): Support positions in bidi-reordered lines.
5567 Save and restore bidi cache.
5569 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5570 (bidi_paragraph_info): Delete unused struct.
5571 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5572 (bidi_cache_start): New variable.
5573 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5575 (bidi_cache_fetch_state, bidi_cache_search)
5576 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5577 (bidi_cache_find, bidi_peek_at_next_level)
5578 (bidi_level_of_next_char, bidi_find_other_level_edge)
5579 (bidi_move_to_visually_next): Compare cache index with
5580 bidi_cache_start rather than with zero.
5581 (bidi_fetch_char): Accept new argument STRING; all callers
5582 changed. Support iteration over a string. Support strings with
5583 display properties. Support unibyte strings. Fix the type of
5584 `len' according to what STRING_CHAR_AND_LENGTH expects.
5585 (bidi_paragraph_init, bidi_resolve_explicit_1)
5586 (bidi_resolve_explicit, bidi_resolve_weak)
5587 (bidi_level_of_next_char, bidi_move_to_visually_next):
5588 Support iteration over a string.
5589 (bidi_set_sor_type, bidi_resolve_explicit_1)
5590 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5591 can now be zero (for strings); special values 0 and -1 were
5592 changed to -1 and -2, respectively.
5593 (bidi_char_at_pos): New function.
5594 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5595 Call it instead of FETCH_MULTIBYTE_CHAR.
5596 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5597 initialized to valid values.
5598 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5600 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5601 the test for valid cached positions. Fix the logic for looking up
5602 the sentinel state in the cache. GCPRO the Lisp string we are
5604 (bidi_push_it, bidi_pop_it): New functions.
5605 (bidi_initialize): Initialize the bidi cache start stack pointer.
5606 (bidi_cache_ensure_space): New function, refactored from part of
5607 bidi_cache_iterator_state. Don't assume the required size is just
5608 one BIDI_CACHE_CHUNK away.
5609 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5610 (bidi_count_bytes, bidi_char_at_pos): New functions.
5611 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5612 always valid if bidi_cache_idx is valid.
5613 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5614 is valid if it's going to be used.
5615 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5616 (bidi_cache_fetch_state, bidi_cache_search)
5617 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5618 (bidi_cache_iterator_state, bidi_cache_find)
5619 (bidi_find_other_level_edge, bidi_cache_start_stack):
5620 All variables related to cache indices are now EMACS_INT.
5622 * dispextern.h (struct bidi_string_data): New structure.
5623 (struct bidi_it): New member `string'. Make flag members be 1-bit
5624 fields, and put them last in the struct.
5625 (compute_display_string_pos, compute_display_string_end):
5627 (bidi_push_it, bidi_pop_it): Add prototypes.
5628 (struct iterator_stack_entry): New members bidi_p,
5629 paragraph_embedding, and from_disp_prop_p.
5630 (struct it): Member bidi_p is now a bit field 1 bit wide.
5631 (bidi_shelve_cache, bidi_unshelve_cache):
5634 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5635 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5636 and vector-like objects.
5638 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5639 cache around display iteration.
5641 * window.c (Fwindow_end, window_scroll_pixel_based)
5642 (displayed_window_lines, Frecenter): Save and restore the bidi
5643 cache around display iteration.
5645 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5647 * editfns.c (Fdelete_region): Clarify the use of the named
5648 parameters (bug#6788).
5650 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5652 * indent.c (Fvertical_motion): Set and restore w->pointm when
5653 saving and restoring the window's buffer (Bug#9006).
5655 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5657 * editfns.c (Fstring_to_char): Clarify just what is returned
5658 (bug#6576). Text by Eli Zaretskii.
5660 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5662 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5664 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5666 * buffer.c (mmap_find): Fix a typo.
5668 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5670 Fix execution of x selection hooks.
5671 * xselect.c (Qx_lost_selection_functions)
5672 (Qx_sent_selection_functions): New vars.
5673 (syms_of_xselect): DEFSYM them.
5674 (x_handle_selection_request): Pass Qx_sent_selection_functions
5675 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5676 (x_handle_selection_clear,x_clear_frame_selections):
5677 Pass Qx_lost_selection_functions rather than
5678 Vx_lost_selection_functions to Frun_hook_with_args.
5680 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5682 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5683 The old code sometimes used this field without initializing it.
5685 * alloc.c (gc_sweep): Don't read past end of array.
5686 In theory, the old code could also have corrupted Emacs internals,
5687 though it'd be very unlikely.
5689 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5691 * character.c (Fcharacterp): Don't advertise optional ignored
5692 argument. (Bug#4026)
5694 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5696 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5699 * window.c (Fset_window_start): Doc fix (bug#4199).
5700 (Fset_window_hscroll): Ditto.
5702 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5704 Fix minor new problems caught by GCC 4.6.1.
5705 * term.c (init_tty): Remove unused local.
5706 * xsettings.c (store_monospaced_changed): Define this function only
5707 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5710 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5712 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5714 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5716 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5717 are the mini-buffer and the echo area (bug#3320).
5719 * term.c (init_tty): Remove support for supdup, c10 and perq
5720 terminals, which are no longer supported (bug#1482).
5722 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5724 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5726 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5728 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5729 for non-popups (Bug#3642).
5731 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5733 * alloc.c (reset_malloc_hooks): Protoize.
5734 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5735 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5736 * cm.c (losecursor): Likewise.
5737 * data.c (fmod): Likewise.
5738 * dispnew.c (swap_glyphs_in_rows): Likewise.
5739 * emacs.c (memory_warning_signal): Likewise.
5740 * floatfns.c (float_error): Likewise.
5741 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5742 (otf_open, font_otf_capability, generate_otf_features)
5743 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5745 * image.c (pbm_read_file): Likewise.
5746 * indent.c (string_display_width): Likewise.
5747 * intervals.c (check_for_interval, search_for_interval)
5748 (inc_interval_count, count_intervals, root_interval)
5749 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5750 * lread.c (defalias): Likewise.
5751 * ralloc.c (r_alloc_check): Likewise.
5752 * regex.c (set_image_of_range_1, set_image_of_range)
5753 (regex_grow_registers): Likewise.
5754 * sysdep.c (strerror): Likewise.
5755 * termcap.c (valid_filename_p, tprint, main): Likewise.
5756 * tparam.c (main): Likewise.
5757 * unexhp9k800.c (run_time_remap, save_data_space)
5758 (update_file_ptrs, read_header, write_header, calculate_checksum)
5759 (copy_file, copy_rest, display_header): Likewise.
5760 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5762 * xdisp.c (check_it): Likewise.
5763 * xfaces.c (register_color, unregister_color, unregister_colors):
5765 * xfns.c (print_fontset_result): Likewise.
5766 * xrdb.c (member, fatal, main): Likewise.
5768 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5770 Fix minor problems found by static checking (Bug#9031).
5771 * chartab.c (char_table_set_range, map_sub_char_table):
5772 Remove unused locals.
5773 (uniprop_table): Now static.
5774 * composite.c (_work_char): Remove unused static var.
5776 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5778 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5780 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5782 * gtkutil.c (qttip_cb): Remove code without function.
5784 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5786 * w32.c (pthread_sigmask): New stub.
5788 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5790 Use pthread_sigmask, not sigprocmask (Bug#9010).
5791 sigprocmask is portable only for single-threaded applications, and
5792 Emacs can be multi-threaded when it uses GTK.
5793 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5795 * callproc.c (Fcall_process):
5796 * process.c (create_process):
5797 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5798 Use pthread_sigmask, not sigprocmask.
5800 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5802 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5803 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5806 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5808 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5809 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5810 (xg_hide_tooltip): Fix comment.
5812 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5813 in registerServicesMenuSendTypes.
5814 (validRequestorForSendType): Don't check ns_return_types.
5816 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5819 2011-07-08 Jason Rumney <jasonr@gnu.org>
5821 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5822 SH_SHOW for hidden windows (Bug#5482).
5824 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5825 frame struct members of non-existent frames (Bug#6284).
5827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5829 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5830 variable firstTime not needed on OSX >= 10.6.
5831 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5832 >= 10.5. Use setKnobProportion, setDoubleValue.
5834 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5835 (MAC_OS_X_VERSION_10_5): Define if not defined.
5836 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5837 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5838 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5840 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5841 cString and lossyCString on OSX >= 10.4
5843 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5844 sizeToFit on OSX >= 10.2.
5846 * nsimage.m (allocInitFromFile): Don't use deprecated method
5847 bestRepresentationForDevice on OSX >= 10.6.
5849 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5852 * emacs.c: Declare unexec_init_emacs_zone.
5854 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5856 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5858 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5859 on svcsMenu (Bug#8842).
5861 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5863 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5865 * nsterm.m (QUTF8_STRING): Declare.
5866 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5867 (validRequestorForSendType): Return type is (id).
5868 Change indexOfObjectIdenticalTo to indexOfObject.
5869 Check if we have local selection before returning self (Bug#8842).
5870 (writeSelectionToPasteboard): Put local selection into paste board
5871 if we have a local selection (Bug#8842).
5872 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5874 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5875 (ns_get_local_selection): Declare.
5877 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5879 * keymap.c (describe_map_tree): Don't insert a double newline at
5880 the end of the buffer (bug#1169) and return whether we inserted
5883 * callint.c (Fcall_interactively): Change "reading args" to
5884 "providing args" to try to clarify what it does (bug#1010).
5886 2011-07-07 Kenichi Handa <handa@m17n.org>
5888 * composite.c (composition_compute_stop_pos): Ignore a static
5889 composition starting before CHARPOS (Bug#8915).
5891 * xdisp.c (handle_composition_prop): Likewise.
5893 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5895 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5898 2011-07-07 Kenichi Handa <handa@m17n.org>
5900 * character.h (unicode_category_t): New enum type.
5902 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5903 (Qchar_code_property_table): New variable.
5904 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5905 (UNIPROP_COMPRESSED_FORM_P): New macros.
5906 (char_table_ascii): Uncompress the compressed values.
5907 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5908 Uncompress the compressed values.
5909 (sub_char_table_ref_and_range): Likewise.
5910 (char_table_ref_and_range): Uncompress the compressed values.
5911 (sub_char_table_set): New arg is_uniprop. Callers changed.
5912 Uncompress the compressed values.
5913 (sub_char_table_set_range): Args changed. Callers changed.
5914 (char_table_set_range): Adjuted for the above change.
5915 (map_sub_char_table): Delete args default_val and parent. Add arg
5916 top. Give decoded values to a Lisp function.
5917 (map_char_table): Adjust for the above change. Give decoded
5918 values to a Lisp function. Gcpro more variables.
5919 (uniprop_table_uncompress)
5920 (uniprop_decode_value_run_length): New functions.
5921 (uniprop_decoder, uniprop_decoder_count): New variables.
5922 (uniprop_get_decoder, uniprop_encode_value_character)
5923 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5925 (uniprop_encoder, uniprop_encoder_count): New variables.
5926 (uniprop_get_encoder, uniprop_table)
5927 (Funicode_property_table_internal, Fget_unicode_property_internal)
5928 (Fput_unicode_property_internal): New functions.
5929 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5930 Sunicode_property_table_internal, Sget_unicode_property_internal,
5931 and Sput_unicode_property_internal. Defvar_lisp
5932 char-code-property-alist.
5934 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5935 Vunicode_category_table.
5937 * font.c (font_range): Adjust for the change of
5938 Vunicode_category_table.
5940 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5942 * m/iris4d.h: Remove file, move contents ...
5943 * s/irix6-5.h: ... here.
5945 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5947 Remove unportable assumption about struct layout (Bug#8884).
5948 * alloc.c (mark_buffer):
5949 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5950 (clone_per_buffer_values): Don't assume that
5951 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5952 This isn't true in general, and it's particularly not true
5953 if Emacs is configured with --with-wide-int.
5954 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5955 New macros, used in the buffer.c change.
5957 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5959 * xsettings.c: Use both GConf and GSettings if both are available.
5960 (store_config_changed_event): Add comment.
5961 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5962 (store_tool_bar_style_changed): New functions.
5963 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5964 (struct xsettings): Move font inside HAVE_XFT.
5965 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5966 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5967 Move inside HAVE_XFT.
5968 (something_changed_gsettingsCB): Rename from something_changedCB.
5969 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5971 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5972 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5973 (something_changed_gconfCB): Rename from something_changedCB.
5974 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5975 (parse_settings): Move check for font inside HAVE_XFT.
5976 (read_settings, apply_xft_settings): Add comment.
5977 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5978 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5979 call store_font_name_changed.
5980 (xft_settings_event): Add comment.
5981 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5982 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5983 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5984 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5985 (xsettings_initialize): Call init_gsettings last.
5986 (xsettings_get_system_font, xsettings_get_system_normal_font):
5989 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5991 Random fixes. E.g., (random) never returned negative values.
5992 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5993 subseconds part to the entropy, as that's a bit more random.
5994 Prefer signed to unsigned, since the signedness doesn't matter and
5995 in general we prefer signed. When given a limit, use a
5996 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5997 latter isn't right if USE_2_TAGS_FOR_INTS.
5998 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5999 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6001 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6003 * textprop.c (text_property_stickiness):
6004 Obey Vtext_property_default_nonsticky.
6005 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6006 * w32fns.c (syms_of_w32fns):
6007 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6009 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6011 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6012 This is more efficient than Ffile_directory_p and avoids a minor race.
6014 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6016 * buffer.c (Foverlay_put): Say what the return value is
6019 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6020 is a directory before asking whether to use the file name
6022 (barf_or_query_if_file_exists): Make the "File is a directory"
6023 error be more correct.
6025 * fns.c (Frequire): Remove the mention of the .gz files, since
6026 that's installation-specific, but keep the mention of
6027 `get-load-suffixes'.
6029 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6031 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6032 Report string overflow if the output is too long.
6034 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6036 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6037 (syms_of_gnutls): Remove duplicate DEFSYM for
6038 Qgnutls_bootprop_verify_hostname_error, an error for
6039 Qgnutls_bootprop_verify_error (which is no longer used).
6041 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6042 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6043 Also (re)move comments that are misplaced or no longer relevant.
6045 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6047 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6049 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6051 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6052 and background color parameters if they have been changed.
6054 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6056 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6058 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6060 * xsettings.c (SYSTEM_FONT): Define only when used.
6061 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6063 * keymap.c (access_keymap_1): Now static.
6065 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6067 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6068 leave any prefix arg for the up event (Bug#1586).
6070 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6072 * lread.c (syms_of_lread): Mention single symbols defined by
6073 `defvar' or `defconst' (bug#7154).
6075 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6076 (Frequire): Mention get-load-suffixes.
6078 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6080 * window.h (window): Remove clone_number slot.
6081 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6083 (make_parent_window, make_window, saved_window)
6084 (Fset_window_configuration, save_window_save): Don't deal with
6086 * buffer.c (Qclone_number): Remove declaration.
6087 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6089 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6091 Add multiple inheritance to keymaps.
6092 * keymap.c (Fmake_composed_keymap): New function.
6093 (Fset_keymap_parent): Simplify.
6094 (fix_submap_inheritance): Remove.
6095 (access_keymap_1): New function extracted from access_keymap to handle
6096 embedded parents and handle lists of maps.
6097 (access_keymap): Use it.
6098 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6099 (Fcopy_keymap): Handle embedded parents.
6100 (Fcommand_remapping, define_as_prefix): Simplify.
6101 (Fkey_binding): Simplify.
6102 (syms_of_keymap): Move minibuffer-local-completion-map,
6103 minibuffer-local-filename-completion-map,
6104 minibuffer-local-must-match-map, and
6105 minibuffer-local-filename-must-match-map to Elisp.
6106 (syms_of_keymap): Defsubr make-composed-keymap.
6107 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6108 (parse_menu_item): Trivial simplification.
6110 2011-07-01 Glenn Morris <rgm@gnu.org>
6112 * Makefile.in (SETTINGS_LIBS): Fix typo.
6114 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6116 * coding.c (Fencode_coding_string): Record the last coding system
6117 used, as the function doc string says (bug#8738).
6119 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6121 * xsettings.c (store_monospaced_changed): Take new font as arg and
6122 check for change against current_mono_font.
6123 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6124 (emacs_settings_constructor, emacs_settings_get_property)
6125 (emacs_settings_set_property, emacs_settings_class_init)
6126 (emacs_settings_init, gsettings_obj): Remove.
6127 (something_changedCB): New function for HAVE_GSETTINGS.
6128 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6129 with value as argument.
6130 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6131 g_settings_new (Bug#8967). Do not create gsettings_obj.
6132 Remove calls to g_settings_bind. Connect something_changedCB to
6135 * xgselect.c: Add defined (HAVE_GSETTINGS).
6136 (xgselect_initialize): Ditto.
6138 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6139 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6142 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6144 * eval.c (struct backtrace): Simplify and port the data structure.
6145 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6146 signed bit field, as this assumption is not portable and it makes
6147 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6148 "char debug_on_exit : 1" as this is not portable either; instead,
6149 use the portable "unsigned int debug_on_exit : 1". Remove unused
6150 member evalargs. Remove obsolete comments about cc bombing out.
6152 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6154 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6155 Let HAVE_GSETTINGS override HAVE_GCONF.
6156 (store_monospaced_changed): New function.
6157 (EMACS_SETTINGS): A new type derived from GObject to handle
6158 GSettings notifications.
6159 (emacs_settings_constructor, emacs_settings_get_property)
6160 (emacs_settings_set_property, emacs_settings_class_init):
6162 (gsettings_client, gsettings_obj): New variables.
6163 (GSETTINGS_SCHEMA): New define.
6164 (something_changedCB): Call store_monospaced_changed.
6165 (init_gsettings): New function.
6166 (xsettings_initialize): Call init_gsettings.
6167 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6170 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6173 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6175 * window.c (resize_root_window, grow_mini_window)
6176 (shrink_mini_window): Rename Qresize_root_window to
6177 Qwindow_resize_root_window and Qresize_root_window_vertically to
6178 Qwindow_resize_root_window_vertically.
6180 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6182 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6184 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6186 * makefile.w32-in: Redesign dependencies so they reflect more
6187 clearly which files are directly included by each source file,
6188 and not through other includes.
6190 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6192 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6193 (sort_overlays, overlay_strings): When an overlay's clone number
6194 matches the window's clone number process the overlay even if
6195 the overlay's window property doesn't match the current window.
6197 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6198 (Fwindow_hchild): Rename to Fwindow_left_child.
6199 (Fwindow_next): Rename to Fwindow_next_sibling.
6200 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6201 (resize_window_check): Rename to window_resize_check.
6202 (resize_window_apply): Rename to window_resize_apply.
6203 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6204 (Fdelete_other_windows_internal, resize_frame_windows)
6205 (Fsplit_window_internal, Fdelete_window_internal)
6206 (grow_mini_window, shrink_mini_window)
6207 (Fresize_mini_window_internal): Fix callers accordingly.
6209 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6211 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6212 (emacs_fixed_set_min_size): Remove.
6213 (emacs_fixed_new): Take frame as argument.
6215 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6216 (_EmacsFixedPrivate): Remove minwidth/height.
6217 Add struct frame *f.
6218 (emacs_fixed_init): Initialize priv->f.
6219 (get_parent_class, emacs_fixed_set_min_size): Remove.
6220 (emacs_fixed_new): Set priv->f to argument.
6221 (emacs_fixed_get_preferred_width)
6222 (emacs_fixed_get_preferred_height): Use min_width/height from
6223 frames size_hint to set minimum and natural (Bug#8919).
6224 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6225 and use min_width/height from frames size_hint to set
6226 min_width/height (Bug#8919).
6228 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6229 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6232 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6234 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6235 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6238 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6240 * process.c (wait_reading_process_output): Bypass select if
6241 waiting for a cell while ignoring keyboard input, and input is
6242 pending. Suggested by Jan Djärv (Bug#8869).
6244 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6246 Use gnulib's dup2 module instead of rolling our own.
6247 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6249 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6251 * dispnew.c (scrolling_window): Before scrolling, turn off a
6252 mouse-highlight in the window being scrolled.
6254 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6256 Move DEFSYM to lisp.h and use everywhere.
6258 * character.h (DEFSYM): Move declaration...
6259 * lisp.h (DEFSYM): ...here.
6265 * w32select.c: Don't include character.h.
6267 * alloc.c (syms_of_alloc):
6268 * buffer.c (syms_of_buffer):
6269 * bytecode.c (syms_of_bytecode):
6270 * callint.c (syms_of_callint):
6271 * casefiddle.c (syms_of_casefiddle):
6272 * casetab.c (init_casetab_once):
6273 * category.c (init_category_once, syms_of_category):
6274 * ccl.c (syms_of_ccl):
6275 * cmds.c (syms_of_cmds):
6276 * composite.c (syms_of_composite):
6277 * dbusbind.c (syms_of_dbusbind):
6278 * dired.c (syms_of_dired):
6279 * dispnew.c (syms_of_display):
6280 * doc.c (syms_of_doc):
6281 * editfns.c (syms_of_editfns):
6282 * emacs.c (syms_of_emacs):
6283 * eval.c (syms_of_eval):
6284 * fileio.c (syms_of_fileio):
6285 * fns.c (syms_of_fns):
6286 * frame.c (syms_of_frame):
6287 * fringe.c (syms_of_fringe):
6288 * insdel.c (syms_of_insdel):
6289 * keymap.c (syms_of_keymap):
6290 * lread.c (init_obarray, syms_of_lread):
6291 * macros.c (syms_of_macros):
6292 * msdos.c (syms_of_msdos):
6293 * print.c (syms_of_print):
6294 * process.c (syms_of_process):
6295 * search.c (syms_of_search):
6296 * sound.c (syms_of_sound):
6297 * syntax.c (init_syntax_once, syms_of_syntax):
6298 * terminal.c (syms_of_terminal):
6299 * textprop.c (syms_of_textprop):
6300 * undo.c (syms_of_undo):
6301 * w32.c (globals_of_w32):
6302 * window.c (syms_of_window):
6303 * xdisp.c (syms_of_xdisp):
6304 * xfaces.c (syms_of_xfaces):
6305 * xfns.c (syms_of_xfns):
6306 * xmenu.c (syms_of_xmenu):
6307 * xsettings.c (syms_of_xsettings):
6308 * xterm.c (syms_of_xterm): Use DEFSYM.
6310 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6312 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6314 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6316 Integer and buffer overflow fixes (Bug#8873).
6318 * print.c (printchar, strout): Check for string overflow.
6319 (PRINTPREPARE, printchar, strout):
6320 Don't set size unless allocation succeeds.
6322 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6323 for sizes. Check for string overflow more accurately.
6324 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6326 * macros.c: Integer and buffer overflow fixes.
6327 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6328 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6329 Use ptrdiff_t, not int, for sizes.
6330 Don't increment bufsize until after realloc succeeds.
6331 Check for size-calculation overflow.
6332 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6334 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6336 * lread.c: Integer overflow fixes.
6337 (read_integer): Radix is now EMACS_INT, not int,
6338 to improve quality of diagnostics for out-of-range radices.
6339 Calculate buffer size correctly for out-of-range radices.
6340 (read1): Check for integer overflow in radices, and in
6341 read-circle numbers.
6342 (read_escape): Avoid int overflow.
6343 (Fload, openp, read_buffer_size, read1)
6344 (substitute_object_recurse, read_vector, read_list, map_obarray):
6345 Use ptrdiff_t, not int, for sizes.
6346 (read1): Use EMACS_INT, not int, for sizes.
6347 Check for size overflow.
6349 * image.c (cache_image): Check for size arithmetic overflow.
6351 * lread.c: Integer overflow issues.
6352 (saved_doc_string_size, saved_doc_string_length)
6353 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6354 Now ptrdiff_t, not int.
6355 (read1): Don't assume doc string length fits in int. Check for
6356 out-of-range doc string lengths.
6357 (read_list): Don't assume file position fits in int.
6358 (read_escape): Check for hex character overflow.
6360 2011-06-22 Leo Liu <sdl.web@gmail.com>
6362 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6363 Move to minibuffer.el.
6365 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6367 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6368 The following patches are for when GLYPH_DEBUG && !XASSERT.
6369 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6370 * dispnew.c (flush_stdout):
6371 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6372 Mark as externally visible.
6373 * dispnew.c (check_window_matrix_pointers): Now static.
6374 * dispnew.c (window_to_frame_vpos):
6375 * xfns.c (unwind_create_frame):
6376 * xterm.c (x_check_font): Remove unused local.
6377 * scroll.c (CHECK_BOUNDS):
6378 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6379 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6380 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6381 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6382 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6384 (debug_method_add): Use va_list and vsprintf rather than relying
6385 on undefined behavior with wrong number of arguments.
6386 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6387 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6388 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6389 since we're not interested in debugging glyphs with old libraries.
6390 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6391 GCC 4.6.0's static checking.
6393 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6395 Integer overflow and signedness fixes (Bug#8873).
6396 A few related buffer overrun fixes, too.
6398 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6400 * dispextern.h (struct face.stipple):
6401 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6402 (x_bitmap_mask, x_allocate_bitmap_record)
6403 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6404 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6405 (x_create_bitmap_from_xpm_data):
6406 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6407 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6409 * xfaces.c (load_pixmap):
6410 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6411 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6412 (.bitmaps_last, struct x_output.icon_bitmap):
6413 Use ptrdiff_t, not int, for bitmap indexes.
6414 (x_allocate_bitmap_record): Check for size overflow.
6415 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6417 Use ptrdiff_t, not int, for overlay counts.
6418 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6419 * editfns.c (overlays_around, get_pos_property):
6420 * textprop.c (get_char_property_and_overlay):
6421 * xdisp.c (next_overlay_change, note_mouse_highlight):
6422 * xfaces.c (face_at_buffer_position):
6423 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6424 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6425 (Fnext_overlay_change, Fprevious_overlay_change)
6426 (mouse_face_overlay_overlaps, Foverlays_in):
6427 Use ptrdiff_t, not int, for sizes.
6428 (overlays_at, overlays_in): Check for size-calculation overflow.
6430 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6432 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6433 (x_session_initialize): Do not assume string length fits in int.
6435 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6436 This is unlikely, but can occur if DPI is outlandish.
6438 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6439 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6441 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6442 * xrdb.c (magic_file_p, search_magic_path):
6443 Omit last arg SUFFIX; it was always 0. All callers changed.
6444 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6446 * xfont.c (xfont_match): Avoid need for strlen.
6448 * xfns.c: Don't assume strlen fits in int.
6449 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6451 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6452 not unsigned long, as we prefer signed integers. All callers changed.
6453 Detect integer overflow in repeat count.
6454 (message_dolog): Don't assume print length fits in 39 bytes.
6455 (display_mode_element): Don't assume strlen fits in int.
6457 * termcap.c: Don't assume sizes fit in int and never overflow.
6458 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6459 (gobble_line): Check for size-calculation overflow.
6461 * minibuf.c (Fread_buffer):
6462 * lread.c (intern, intern_c_string):
6463 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6464 Don't assume string length fits in int.
6466 * keyboard.c (parse_tool_bar_item):
6467 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6469 * font.c: Don't assume string length fits in int.
6470 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6471 Use ptrdiff_t, not int.
6472 (font_intern_prop): Don't assume string length fits in int.
6473 Don't assume integer property fits in fixnum.
6474 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6476 * filelock.c: Fix some buffer overrun and integer overflow issues.
6477 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6478 Reformulate so as not to need the command string.
6479 Invoke gzip -cd rather than gunzip, as it's more portable.
6480 (lock_info_type, lock_file_1, lock_file):
6481 Don't assume pid_t and time_t fit in unsigned long.
6482 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6483 (current_lock_owner): Prefer signed type for sizes.
6484 Use memcpy, not strncpy, where memcpy is what is really wanted.
6485 Don't assume (via atoi) that time_t and pid_t fit in int.
6486 Check for time_t and/or pid_t out of range, e.g., via a network share.
6487 Don't alloca where an auto var works fine.
6489 * fileio.c: Fix some integer overflow issues.
6490 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6491 Don't assume string length fits in int.
6492 (directory_file_name): Don't assume string length fits in long.
6493 (make_temp_name): Don't assume pid fits in int, or that its print
6494 length is less than 20.
6496 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6498 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6500 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6502 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6503 We prefer signed integers, even for size calculations.
6505 * emacs.c: Don't assume string length fits in 'int'.
6506 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6507 (main): Don't invoke strlen when not needed.
6509 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6510 (XD_DEBUG_MESSAGE): Don't waste a byte.
6512 * callproc.c (getenv_internal_1, getenv_internal)
6514 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6516 * lread.c (invalid_syntax): Omit length argument.
6517 All uses changed. This doesn't fix a bug, but it simplifies the
6518 code away from its former Hollerith-constant appearance, and it's
6519 one less 'int' to worry about when looking at integer-overflow issues.
6520 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6522 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6523 This didn't break anything, but it didn't help either.
6524 It's confusing to put a bogus integer in a place where the actual
6525 value does not matter.
6526 (LIST_END_P): Remove unused macro and its bogus comment.
6527 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6529 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6530 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6532 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6533 We prefer signed types, and the value cannot exceed the EMACS_INT
6534 range anyway (because otherwise the length would not be representable).
6535 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6536 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6537 This avoids a GCC warning when WIDE_EMACS_INT.
6539 * indent.c (sane_tab_width): New function.
6540 (current_column, scan_for_column, Findent_to, position_indentation)
6541 (compute_motion): Use it. This is just for clarity.
6542 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6544 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6546 * lisp.h (lint_assume): New macro.
6547 * composite.c (composition_gstring_put_cache):
6548 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6550 * editfns.c, insdel.c:
6551 Omit unnecessary forward decls, to simplify future changes.
6553 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6555 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6557 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6558 Use much-faster test for byte-length change.
6559 Don't assume string byte-length fits in 'int'.
6560 Check that character arg fits in 'int'.
6561 (mapcar1): Declare byte as byte, for clarity.
6563 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6565 * fns.c (concat): Catch string overflow earlier.
6566 Do not rely on integer wraparound.
6568 * dispextern.h (struct it.overlay_strings_charpos)
6569 (struct it.selective): Now EMACS_INT, not int.
6570 * xdisp.c (forward_to_next_line_start)
6571 (back_to_previous_visible_line_start)
6572 (reseat_at_next_visible_line_start, next_element_from_buffer):
6573 Don't arbitrarily truncate the value of 'selective' to int.
6575 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6577 * composite.c: Don't truncate sizes to 'int'.
6578 (composition_gstring_p, composition_reseat_it)
6579 (composition_adjust_point): Use EMACS_INT, not int.
6580 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6581 not EMACS_UINT, for indexes.
6583 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6585 * buffer.c: Include <verify.h>.
6586 (struct sortvec.priority, struct sortstr.priority):
6587 Now EMACS_INT, not int.
6588 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6589 (struct sortstr.size, record_overlay_string)
6590 (struct sortstrlist.size, struct sortlist.used):
6591 Don't truncate size to int.
6592 (record_overlay_string): Check for size-calculation overflow.
6593 (init_buffer_once): Check at compile-time, not run-time.
6595 2011-06-22 Jim Meyering <meyering@redhat.com>
6597 Don't leak an XBM-image-sized buffer
6598 * image.c (xbm_load): Free the image buffer after using it.
6600 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6603 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6604 that Sun C diagnosed.
6605 * fns.c (secure_hash): Fix pointer signedness issue.
6606 * intervals.c (static_offset_intervals): New function.
6607 (offset_intervals): Use it.
6609 2011-06-21 Leo Liu <sdl.web@gmail.com>
6612 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6615 * fns.c (secure_hash): Rename from crypto_hash_function and change
6616 the first arg to accept symbols.
6617 (Fsecure_hash): New primitive.
6618 (syms_of_fns): New symbols.
6620 2011-06-20 Deniz Dogan <deniz@dogan.se>
6622 * process.c (Fset_process_buffer): Clarify return value in
6625 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6627 * dispnew.c (add_window_display_history): Use BVAR.
6629 * xdisp.c (debug_method_add): Use BVAR.
6630 (check_window_end, dump_glyph_matrix, dump_glyph)
6631 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6633 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6636 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6637 check till after the cache is created in init_frame_faces.
6639 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6641 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6643 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6645 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6646 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6647 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6649 Improve buffer-overflow checking (Bug#8873).
6650 * fileio.c (Finsert_file_contents):
6651 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6652 Remove the old (too-loose) buffer overflow checks.
6653 They weren't needed, since make_gap checks for buffer overflow.
6654 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6655 The old code merely checked for Emacs fixnum overflow, and relied
6656 on undefined (wraparound) behavior. The new code avoids undefined
6657 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6659 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6660 Tune. Don't use wider integers than needed. Don't use alloca.
6661 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6663 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6665 * insdel.c, lisp.h (buffer_overflow): New function.
6666 (insert_from_buffer_1, replace_range, replace_range_2):
6667 * insdel.c (make_gap_larger):
6668 * editfns.c (Finsert_char):
6669 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6671 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6673 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6675 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6677 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6678 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6680 * fileio.c: Don't assume EMACS_INT fits in off_t.
6681 (emacs_lseek): New static function.
6682 (Finsert_file_contents, Fwrite_region): Use it.
6683 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6685 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6687 * fns.c: Don't overflow int when computing a list length.
6688 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6689 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6690 truncation on 64-bit hosts. Check for QUIT every
6691 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6692 faster and is responsive enough.
6693 (Flength): Report an error instead of overflowing an integer.
6694 (Fsafe_length): Return a float if the value is not representable
6695 as a fixnum. This shouldn't happen except in contrived situations.
6696 (Fnthcdr, Fsort): Don't assume list length fits in int.
6697 (Fcopy_sequence): Don't assume vector length fits in int.
6699 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6700 (header_size, word_size): New constants.
6701 (allocate_vectorlike): Don't check size overflow here.
6702 (allocate_vector): Check it here instead, since this is the only
6703 caller of allocate_vectorlike that could cause overflow.
6704 Check that the new vector's length is representable as a fixnum.
6706 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6707 The previous code was bogus. For example, next_almost_prime (32)
6708 returned 39, which is undesirable as it is a multiple of 3; and
6709 next_almost_prime (24) returned 25, which is a multiple of 5 so
6710 why was the code bothering to check for multiples of 7?
6712 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6714 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6716 Variadic C functions now count arguments with ptrdiff_t.
6717 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6718 Back then I didn't know that the Emacs coding style prefers signed int.
6719 Also, in the meantime I found a few more instances where arguments
6720 were being counted with int, which may truncate counts on 64-bit
6721 machines, or EMACS_INT, which may be unnecessarily wide.
6722 * lisp.h (struct Lisp_Subr.function.aMANY)
6723 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6724 Arg counts are now ptrdiff_t, not size_t.
6725 All variadic functions and their callers changed accordingly.
6726 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6727 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6728 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6729 * callint.c (Fcall_interactively): Check arg count for overflow,
6730 to avoid potential buffer overrun. Use signed char, not 'int',
6731 for 'varies' array, so that we needn't bother to check its size
6732 calculation for overflow.
6733 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6734 * eval.c (apply_lambda):
6735 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6736 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6737 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6739 * callint.c (Fcall_interactively): Don't use index var as event count.
6741 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6742 * mem-limits.h (SIZE): Remove; no longer used.
6744 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6746 Remove unnecessary casts.
6747 * xterm.c (x_term_init):
6748 * xfns.c (x_set_border_pixel):
6749 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6750 These aren't needed now that we assume ANSI C.
6752 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6753 It's more likely to cause problems (due to unsigned overflow)
6756 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6758 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6760 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6762 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6764 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6766 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6768 GLYPH_CODE_FACE returns EMACS_INT, not int.
6769 * dispextern.h (merge_faces):
6770 * xfaces.c (merge_faces):
6771 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6772 Don't assume EMACS_INT fits in int.
6774 * character.h (CHAR_VALID_P): Remove unused parameter.
6775 * fontset.c, lisp.h, xdisp.c: All uses changed.
6777 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6779 * fns.c (concat): Minor tuning based on overflow analysis.
6780 This doesn't fix any bugs. Use int to hold character, instead
6781 of constantly refetching from Emacs object. Use XFASTINT, not
6782 XINT, for value known to be a character. Don't bother comparing
6783 a single byte to 0400, as it's always less.
6785 * floatfns.c (Fexpt):
6786 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6788 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6791 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6793 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6794 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6795 incorrectly succeed when S was a string, because 4294967386 was
6796 truncated before it was used.
6798 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6799 Otherwise, an out-of-range integer could cause undefined behavior
6802 * composite.c: Use int, not EMACS_INT, for characters.
6803 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6804 EMACS_INT, for values that are known to be in character range.
6805 This doesn't fix any bugs but is the usual style inside Emacs and
6806 may generate better code on 32-bit machines.
6808 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6809 This is for reasons similar to the recent CHAR_STRING fix.
6810 * charset.c (Fencode_char): Check that character arg is actually
6811 a character. Pass an int to ENCODE_CHAR.
6812 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6813 wider than 'int', as a compile-time check to prevent future regressions
6816 * character.c (char_string): Remove unnecessary casts.
6818 Make sure a 64-bit char is never passed to CHAR_STRING.
6819 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6820 by silently ignoring the top 32 bits, allowing some values
6821 that were far too large to be valid characters.
6822 * character.h: Include <verify.h>.
6823 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6824 arguments are no wider than unsigned, as a compile-time check
6825 to prevent future regressions in this area.
6827 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6828 (Fsubst_char_in_region):
6830 * xdisp.c (decode_mode_spec_coding):
6831 Adjust to CHAR_STRING's new requirement.
6832 * editfns.c (Finsert_char, Fsubst_char_in_region):
6833 * fns.c (concat): Check that character args are actually
6834 characters. Without this test, these functions did the wrong
6835 thing with wildly out-of-range values on 64-bit hosts.
6837 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6838 These casts should not be needed on 32-bit hosts, either.
6839 * keyboard.c (read_char):
6840 * lread.c (Fload): Remove casts to unsigned.
6842 * lisp.h (UNSIGNED_CMP): New macro.
6843 This fixes comparison bugs on 64-bit hosts.
6844 (ASCII_CHAR_P): Use it.
6845 * casefiddle.c (casify_object):
6846 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6847 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6848 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6849 * dispextern.h (FACE_FROM_ID):
6850 * keyboard.c (read_char): Use UNSIGNED_CMP.
6852 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6853 not to EMACS_INT, to avoid GCC warning.
6855 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6857 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6858 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6859 isn't needed on 32-bit machines.
6861 * buffer.c (Fgenerate_new_buffer_name):
6862 Use EMACS_INT for count, not int.
6863 (advance_to_char_boundary): Return EMACS_INT, not int.
6865 * data.c (Qcompiled_function): Now static.
6867 * window.c (window_body_lines): Now static.
6869 * image.c (gif_load): Rename local to avoid shadowing.
6871 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6872 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6873 * alloc.c (make_save_value): Integer argument is now of type
6875 (mark_object): Use ptrdiff_t, not int.
6876 * lisp.h (pD): New macro.
6877 * print.c (print_object): Use it.
6879 * alloc.c: Use EMACS_INT, not int, to count objects.
6880 (total_conses, total_markers, total_symbols, total_vector_size)
6881 (total_free_conses, total_free_markers, total_free_symbols)
6882 (total_free_floats, total_floats, total_free_intervals)
6883 (total_intervals, total_strings, total_free_strings):
6884 Now EMACS_INT, not int. All uses changed.
6885 (Fgarbage_collect): Compute overall total using a double, so that
6886 integer overflow is less likely to be a problem. Check for overflow
6887 when converting back to an integer.
6888 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6889 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6890 These were 'int' variables that could overflow on 64-bit hosts;
6891 they were never used, so remove them instead of repairing them.
6892 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6893 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6894 Previously, this ceilinged at INT_MAX, but that doesn't work on
6896 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6898 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6899 (allocate_vectorlike): Check for ptrdiff_t overflow.
6900 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6901 when a (possibly-narrower) signed value would do just as well.
6902 We prefer using signed arithmetic, to avoid comparison confusion.
6904 * alloc.c: Catch some string size overflows that we were missing.
6905 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6906 for convenience in STRING_BYTES_MAX.
6907 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6908 The definition here is exact; the one in lisp.h was approximate.
6909 (allocate_string_data): Check for string overflow. This catches
6910 some instances we weren't catching before. Also, it catches
6911 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6912 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6913 and ptrdiff_t and EMACS_INT are both 64 bits.
6915 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6916 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6917 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6919 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6921 * alloc.c (Fmake_string): Check for out-of-range init.
6923 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6925 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6927 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6929 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6930 xg_get_default_scrollbar_width.
6932 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6933 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6934 (style_changed_cb): Call update_theme_scrollbar_width and call
6935 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6936 all frames (Bug#8505).
6937 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6938 Call gtk_window_set_resizable if HAVE_GTK3.
6939 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6940 and height if HAVE_GTK3 (Bug#8505).
6941 (scroll_bar_width_for_theme): New variable.
6942 (update_theme_scrollbar_width): New function.
6943 (xg_get_default_scrollbar_width): Move code to
6944 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6945 (xg_initialize): Call update_theme_scrollbar_width.
6947 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6949 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6951 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6953 * frame.c (make_frame): Call other_buffer_safely instead of
6956 * window.c (temp_output_buffer_show): Call display_buffer with
6957 second argument Vtemp_buffer_show_specifiers and reset latter
6958 immediately after the call.
6959 (Vtemp_buffer_show_specifiers): New variable.
6960 (auto_window_vscroll_p, next_screen_context_lines)
6961 (Vscroll_preserve_screen_position): Remove leading asterisks from
6964 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6966 Fix minor problems found by GCC 4.6.0 static checking.
6967 * buffer.c (Qclone_number): Remove for now, as it's unused.
6968 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6969 (record_buffer): Remove unused local.
6970 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6971 (set_frame_buffer_list): Remove; unused.
6972 * frame.h (other_visible_frames): Remove decl.
6973 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6974 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6975 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6977 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6978 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6979 Define only if HAVE_GPM.
6980 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6981 (update_hints_inhibit): Remove; never set. All uses removed.
6982 * widgetprv.h (emacsFrameClassRec): Remove decl.
6983 * window.c (delete_deletable_window): Now returns void, since it
6984 wasn't returning anything.
6985 (compare_window_configurations): Remove unused locals.
6986 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6987 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6988 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6989 the same widths as pointers. This follows up on the 2011-05-06 patch.
6990 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6991 * xterm.h: Likewise.
6992 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6994 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6996 * makefile.w32-in: Update dependencies.
6997 (LISP_H): Add lib/intprops.h.
6999 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7001 * image.c (gif_load): Add animation frame delay to the metadata.
7002 (syms_of_image): Use DEFSYM. New symbol `delay'.
7004 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7006 * window.c (delete_deletable_window): Re-add.
7007 (Fset_window_configuration): Rewrite to handle dead buffers and
7008 consequently deletable windows.
7009 (window_tree, Fwindow_tree): Remove. Supply functionality in
7011 (compare_window_configurations): Simplify code.
7013 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7015 * image.c (imagemagick_load_image): Fix type mismatch.
7016 (Fimagemagick_types): Likewise.
7018 * window.h (replace_buffer_in_windows): Declare.
7020 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7022 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7023 Qclone_number. Remove external declaration of Qdelete_window.
7024 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7026 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7027 Run Qbuffer_list_update_hook if allowed.
7028 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7029 buffer list implementation.
7030 (other_buffer_safely): New function.
7031 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7032 calls to replace_buffer_in_windows and
7033 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7035 (record_buffer): Inhibit quitting and rewrite using quittable
7036 functions. Run Qbuffer_list_update_hook if allowed.
7037 (Frecord_buffer, Funrecord_buffer): New functions.
7038 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7039 Move switch-to-buffer to window.el.
7040 (bury-buffer): Move to window.el.
7041 (Vbuffer_list_update_hook): New variable.
7043 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7046 * window.h (resize_frame_windows): Move up in code.
7047 (Fwindow_frame): Remove EXFUN.
7048 (replace_buffer_in_all_windows): Remove prototype.
7049 (replace_buffer_in_windows_safely): Add prototype.
7051 * window.c: Declare Qdelete_window static again. Move down
7052 declaration of select_count.
7053 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7054 (Fother_window): Move to window.el.
7055 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7056 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7057 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7059 (replace_buffer_in_windows): Implement by calling
7060 Qreplace_buffer_in_windows.
7061 (replace_buffer_in_all_windows): Remove with some functionality
7062 moved into replace_buffer_in_windows_safely.
7063 (replace_buffer_in_windows_safely): New function.
7064 (select_window_norecord, select_frame_norecord): Move in front
7065 of run_window_configuration_change_hook. Remove now obsolete
7067 (Fset_window_buffer): Rewrite doc-string.
7068 Call Qrecord_window_buffer.
7069 (keys_of_window): Move binding for other-window to window.el.
7071 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7073 * dispextern.h (struct image): Replace data member, whose int_val
7074 and ptr_val fields were not used by anything, with a single
7077 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7078 (gif_clear_image, gif_load, imagemagick_load_image)
7079 (gs_clear_image, gs_load): Callers changed.
7081 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7083 * buffer.h: Include <time.h>, for time_t.
7084 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7086 Fix minor problems found by static checking.
7088 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7090 Make identifiers static if they are not used in other modules.
7091 * data.c (Qcompiled_function, Qframe, Qvector):
7092 * image.c (QimageMagick, Qsvg):
7093 * minibuf.c (Qmetadata):
7094 * window.c (resize_window_check, resize_root_window): Now static.
7095 * window.h (resize_window_check, resize_root_window): Remove decls.
7097 * window.c (window_deletion_count, delete_deletable_window):
7099 (window_body_lines): Now static.
7100 (Fdelete_other_windows_internal): Mark vars as initialized.
7101 Make sure 'resize_failed' is initialized.
7102 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7103 (resize_window_apply): Remove unused local.
7104 * window.h (delete_deletable_window): Remove decl.
7106 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7107 (imagemagick_load_image): Fix pointer signedness problem by changing
7108 last arg from unsigned char * to char *. All uses changed.
7109 Also, fix a local for similar reasons.
7110 Remove unused locals. Remove locals to avoid shadowing.
7111 (fn_rsvg_handle_free): Remove; unused.
7112 (svg_load, svg_load_image): Fix pointer signedness problem.
7113 (imagemagick_load_image): Don't use garbage pointer image_wand.
7115 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7117 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7119 * image.c (gif_load): Fix omitted cast error introduced by
7122 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7124 * window.h (resize_proportionally, orig_total_lines)
7125 (orig_top_line): Remove from window structure.
7126 (set_window_height, set_window_width, change_window_heights)
7127 (Fdelete_window): Remove prototypes.
7128 (resize_frame_windows): Remove duplicate declaration.
7130 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7132 * window.h (resize_frame_windows, resize_window_check)
7133 (delete_deletable_window, resize_root_window)
7134 (resize_frame_windows): Declare prototypes.
7136 * window.c (resize_window_apply): Make definition be "static" to
7137 match the prototype.
7139 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7141 * window.c: Remove declarations of Qwindow_size_fixed,
7142 window_min_size_1, window_min_size_2, window_min_size,
7143 size_window, window_fixed_size_p, enlarge_window, delete_window.
7144 Remove static from declaration of Qdelete_window, it's
7145 temporarily needed by Fbury_buffer.
7146 (replace_window): Don't assign orig_top_line and
7148 (Fdelete_window, delete_window): Remove. Window deletion is
7149 handled by window.el.
7150 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7151 Replace Fdelete_window calls with calls to Qdelete_window.
7152 (Fdelete_other_windows): Remove. Deleting other windows is
7153 handled by window.el.
7154 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7155 handled in window.el.
7156 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7157 Window minimum sizes are handled in window.el.
7158 (shrink_windows, size_window, set_window_height)
7159 (set_window_width, change_window_heights, window_height)
7160 (window_width, CURBEG, CURSIZE, enlarge_window)
7161 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7162 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7163 handled in window.el.
7164 (make_dummy_parent): Rename to make_parent_window and give it a
7165 second argument horflag.
7166 (make_window): Don't set resize_proportionally any more.
7167 (Fsplit_window): Remove. Windows are split in window.el.
7168 (save_restore_action, save_restore_orig_size)
7169 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7170 Resize mini windows in window.el.
7171 (grow_mini_window, shrink_mini_window): Implement by calling
7172 Qresize_root_window_vertically, resize_window_check and
7173 resize_window_apply.
7174 (saved_window, Fset_window_configuration, save_window_save):
7175 Do not handle orig_top_line, orig_total_lines, and
7176 resize_proportionally.
7177 (window_min_height, window_min_width): Move to window.el.
7178 (keys_of_window): Move bindings for delete-other-windows,
7179 split-window, delete-window and enlarge-window to window.el.
7181 * buffer.c: Temporarily extern Qdelete_window.
7182 (Fbury_buffer): Temporarily call Qdelete_window instead of
7183 Fdelete_window (Fbury_buffer will move to window.el soon).
7185 * frame.c (set_menu_bar_lines_1): Remove code handling
7186 orig_top_line and orig_total_lines.
7188 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7189 set_window_height but set heights directly.
7190 (change_frame_size_1): Use resize_frame_windows.
7192 * xdisp.c (init_xdisp): Don't use set_window_height but set
7195 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7196 Use resize_frame_windows instead of change_window_heights and run
7197 run_window_configuration_change_hook.
7199 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7200 instead of change_window_heights and run
7201 run_window_configuration_change_hook.
7203 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7205 * window.c (replace_window): Rename second argument REPLACEMENT to
7206 NEW. New third argument SETFLAG. Rewrite.
7207 (delete_window, make_dummy_parent): Call replace_window with
7209 (window_list_1): Move down in code.
7210 (run_window_configuration_change_hook): Move set_buffer part
7211 before select_frame_norecord part in order to unwind correctly.
7212 Rename count1 to count.
7213 (recombine_windows, delete_deletable_window, resize_root_window)
7214 (Fdelete_other_windows_internal)
7215 (Frun_window_configuration_change_hook, make_parent_window)
7216 (resize_window_check, resize_window_apply, Fresize_window_apply)
7217 (resize_frame_windows, Fsplit_window_internal)
7218 (Fdelete_window_internal, Fresize_mini_window_internal):
7220 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7222 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7224 * window.h (window): Add some new members to window structure -
7225 normal_lines, normal_cols, new_total, new_normal, clone_number,
7226 splits, nest, prev_buffers, next_buffers.
7227 (WINDOW_TOTAL_SIZE): Move here from window.c.
7228 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7230 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7232 (make_dummy_parent): Set new members of windows structure.
7233 (make_window): Move down in code. Handle new members of window
7235 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7236 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7237 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7238 (Fset_window_prev_buffers, Fwindow_next_buffers)
7239 (Fset_window_next_buffers, Fset_window_clone_number):
7241 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7242 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7244 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7245 Argument WINDOW can be now internal window too.
7246 (Fwindow_use_time): Move up in code.
7247 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7249 (Fset_window_configuration, saved_window)
7250 (Fcurrent_window_configuration, save_window_save): Handle new
7251 members of window structure.
7252 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7253 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7254 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7255 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7256 Qget_mru_window, Qresize_root_window,
7257 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7258 Qauto_buffer_name; staticpro them.
7260 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7262 * window.c (Fwindow_total_size, Fwindow_left_column)
7263 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7264 (Fwindow_list_1): New functions.
7265 (window_box_text_cols): Replace with window_body_cols.
7266 (Fwindow_width, Fscroll_left, Fscroll_right):
7267 Use window_body_cols instead of window_box_text_cols.
7268 (delete_window, Fset_window_configuration):
7269 Call delete_all_subwindows with window as argument.
7270 (delete_all_subwindows): Take a window as argument and not a
7272 (window_loop): Remove handling of GET_LRU_WINDOW and
7274 (Fget_lru_window, Fget_largest_window): Move to window.el.
7276 * window.h: Extern window_body_cols instead of
7277 window_box_text_cols. delete_all_subwindows now takes a
7278 Lisp_Object as argument.
7280 * indent.c (compute_motion, Fcompute_motion):
7281 Use window_body_cols instead of window_box_text_cols.
7283 * frame.c (delete_frame): Call delete_all_subwindows with root
7286 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7288 * fns.c (Fputhash): Document return value.
7290 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7292 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7294 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7296 Cons<->int and similar integer overflow fixes (Bug#8794).
7298 Check for overflow when converting integer to cons and back.
7299 * charset.c (Fdefine_charset_internal, Fdecode_char):
7300 Use cons_to_unsigned to catch overflow.
7301 (Fencode_char): Use INTEGER_TO_CONS.
7302 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7303 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7304 * data.c (long_to_cons, cons_to_long): Remove.
7305 (cons_to_unsigned, cons_to_signed): New functions.
7306 These signal an error for invalid or out-of-range values.
7307 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7308 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7309 * font.c (Ffont_variation_glyphs):
7310 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7311 * lisp.h: Include <intprops.h>.
7312 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7313 (cons_to_signed, cons_to_unsigned): New decls.
7314 (long_to_cons, cons_to_long): Remove decls.
7315 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7316 (Fprimitive_undo): Use CONS_TO_INTEGER.
7317 * xfns.c (Fx_window_property): Likewise.
7318 * xselect.c: Include <limits.h>.
7319 (x_own_selection, selection_data_to_lisp_data):
7320 Use INTEGER_TO_CONS.
7321 (x_handle_selection_request, x_handle_selection_clear)
7322 (x_get_foreign_selection, Fx_disown_selection_internal)
7323 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7324 (lisp_data_to_selection_data): Use cons_to_unsigned.
7325 (x_fill_property_data): Use cons_to_signed.
7326 Report values out of range.
7328 Check for buffer and string overflow more precisely.
7329 * buffer.h (BUF_BYTES_MAX): New macro.
7330 * lisp.h (STRING_BYTES_MAX): New macro.
7331 * alloc.c (Fmake_string):
7332 * character.c (string_escape_byte8):
7333 * coding.c (coding_alloc_by_realloc):
7334 * doprnt.c (doprnt):
7335 * editfns.c (Fformat):
7337 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7338 since they may not be the same number.
7339 * editfns.c (Finsert_char):
7340 * fileio.c (Finsert_file_contents):
7341 Likewise for BUF_BYTES_MAX.
7343 * image.c: Use ptrdiff_t, not int, for sizes.
7344 (slurp_file): Switch from int to ptrdiff_t.
7346 (slurp_file): Check that file size fits in both size_t (for
7347 malloc) and ptrdiff_t (for sanity and safety).
7349 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7350 if b->modtime has its maximal value.
7352 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7354 Don't assume time_t can fit into int.
7355 * buffer.h (struct buffer.modtime): Now time_t, not int.
7356 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7357 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7359 Minor fixes for signed vs unsigned integers.
7360 * character.h (MAYBE_UNIFY_CHAR):
7361 * charset.c (maybe_unify_char):
7362 * keyboard.c (read_char, reorder_modifiers):
7363 XINT -> XFASTINT, since the integer must be nonnegative.
7364 * ftfont.c (ftfont_spec_pattern):
7365 * keymap.c (access_keymap, silly_event_symbol_error):
7366 XUINT -> XFASTINT, since the integer must be nonnegative.
7367 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7368 since it makes no difference and we prefer signed.
7369 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7370 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7373 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7375 * window.h (Fwindow_frame): Declare.
7377 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7379 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7380 (SPARE_MEMORY): Always define.
7381 (LARGE_REQUEST): Remove.
7382 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7384 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7386 * lisp.h: Move EXFUNS for Fframe_root_window,
7387 Fframe_first_window and Fset_frame_selected_window to window.h.
7389 * window.h: Move EXFUNS for Fframe_root_window,
7390 Fframe_first_window and Fset_frame_selected_window here from
7393 * frame.c (Fwindow_frame, Fframe_first_window)
7394 (Fframe_root_window, Fframe_selected_window)
7395 (Fset_frame_selected_window): Move to window.c.
7396 (Factive_minibuffer_window): Move to minibuf.c.
7397 (Fother_visible_frames_p): New function.
7399 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7401 * window.c (decode_window, decode_any_window): Move up in code.
7402 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7403 (inhibit_frame_unsplittable): Remove unused variable.
7404 (Fwindow_buffer): Move up and rewrite doc-string.
7405 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7406 (Fwindow_prev): New functions.
7407 (Fwindow_frame): Move here from frame.c. Accept any window as
7409 (Fframe_root_window, Fframe_first_window)
7410 (Fframe_selected_window): Move here from frame.c. Accept frame
7411 or arbitrary window as argument. Update doc-strings.
7412 (Fminibuffer_window): Move up in code.
7413 (Fwindow_minibuffer_p): Move up in code and simplify.
7414 (Fset_frame_selected_window): Move here from frame.c.
7416 (Fselected_window, select_window, Fselect_window): Move up in
7417 code. Minor doc-string fixes.
7419 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7421 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7422 Do not assume that spare memory exists; that assumption is valid
7423 only if SYSTEM_MALLOC.
7424 (LARGE_REQUEST): New macro, so that the issue of large requests
7425 is separated from the issue of spare memory.
7427 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7429 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7432 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7434 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7437 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7439 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7441 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7443 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7444 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7446 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7448 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7450 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7452 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7453 (x_clipboard_manager_save): Add return value.
7454 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7456 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7457 Obey Vx_select_enable_clipboard_manager. Catch errors in
7458 x_clipboard_manager_save (Bug#8779).
7459 (Vx_select_enable_clipboard_manager): New variable.
7460 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7462 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7464 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7466 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7468 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7469 in the current matrix if keep_current_p is non-zero.
7471 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7473 * bidi.c (bidi_level_of_next_char): Fix last change.
7475 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7477 Support bidi reordering of text covered by display properties.
7479 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7480 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7481 (bidi_cache_search, bidi_cache_iterator_state)
7482 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7483 (bidi_level_of_next_char, bidi_move_to_visually_next):
7484 Support character positions inside a run of characters covered by a
7486 (bidi_paragraph_init, bidi_resolve_explicit_1)
7487 (bidi_level_of_next_char): Call bidi_fetch_char and
7488 bidi_fetch_char_advance instead of FETCH_CHAR and
7490 (bidi_init_it): Initialize new members.
7491 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7493 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7494 instead of using explicit *_CHAR codes.
7495 (bidi_resolve_explicit, bidi_resolve_weak):
7496 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7497 bidirectional text is supported only in multibyte buffers.
7498 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7499 it to initialize the frame_window_p member of struct bidi_it.
7500 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7501 (bidi_resolve_explicit, bidi_resolve_weak)
7502 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7503 bidi_it->nchars is non-positive.
7504 (bidi_level_of_next_char): Don't try to lookup the cache for the
7505 next/previous character if nothing is cached there yet, or if we
7506 were just reseat()'ed to a new position.
7508 * xdisp.c (set_cursor_from_row): Set start and stop points
7509 according to the row's direction when priming the loop that looks
7510 for the glyph on which to display cursor.
7511 (single_display_spec_intangible_p): Function deleted.
7512 (display_prop_intangible_p): Reimplement to call
7513 handle_display_spec instead of single_display_spec_intangible_p.
7514 Accept 3 additional arguments needed by handle_display_spec.
7515 This fixes incorrect cursor motion across display property with complex
7516 values: lists, `(when COND...)' forms, etc.
7517 (single_display_spec_string_p): Support property values that are
7518 lists with the argument STRING its top-level element.
7519 (display_prop_string_p): Fix the condition for processing a
7520 property that is a list to be consistent with handle_display_spec.
7521 (handle_display_spec): New function, refactored from the
7522 last portion of handle_display_prop.
7523 (compute_display_string_pos): Accept additional argument
7524 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7525 value of a `display' property is a "replacing spec".
7526 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7527 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7528 the display property, but just return a value indicating whether
7529 the display property will replace the characters it covers.
7530 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7531 frame_window_p members of struct bidi_it.
7532 (compute_display_string_pos, compute_display_string_end):
7534 (push_it): Accept second argument POSITION, where pop_it should
7535 jump to continue iteration.
7536 (reseat_1): Initialize bidi_it.disp_pos.
7538 * keyboard.c (adjust_point_for_property): Adjust the call to
7539 display_prop_intangible_p to its new signature.
7541 * dispextern.h (struct bidi_it): New member frame_window_p.
7542 (bidi_init_it): Update prototypes.
7543 (display_prop_intangible_p): Update prototype.
7544 (compute_display_string_pos, compute_display_string_end):
7546 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7549 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7551 Malloc failure behavior now depends on size of allocation.
7552 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7553 * lisp.h: Change signatures accordingly.
7554 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7555 All callers changed. (Bug#8762)
7557 * gnutls.c: Use Emacs's memory allocators.
7558 Without this change, the gnutls library would invoke malloc etc.
7559 directly, which causes problems on non-SYNC_INPUT hosts, and which
7560 runs afoul of improving memory_full behavior. (Bug#8761)
7561 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7562 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7563 xfree instead of the default malloc, realloc, free.
7564 (Fgnutls_boot): No need to check for memory allocation failure,
7565 since xmalloc does that for us.
7567 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7568 * category.c (hash_get_category_set):
7569 * ccl.c (ccl_driver):
7570 * charset.c (Fdefine_charset_internal):
7571 * charset.h (struct charset.hash_index):
7572 * composite.c (get_composition_id, gstring_lookup_cache)
7573 (composition_gstring_put_cache):
7574 * composite.h (struct composition.hash_index):
7575 * dispextern.h (struct image.hash):
7576 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7577 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7578 (hashfn_equal, hashfn_user_defined, make_hash_table)
7579 (maybe_resize_hash_table, hash_lookup, hash_put)
7580 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7581 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7582 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7583 * image.c (make_image, search_image_cache, lookup_image)
7584 (xpm_put_color_table_h):
7585 * lisp.h (struct Lisp_Hash_Table):
7586 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7587 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7588 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7589 * alloc.c (allocate_vectorlike):
7590 Check for overflow in vector size calculations.
7591 * ccl.c (ccl_driver):
7592 Check for overflow when converting EMACS_INT to int.
7593 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7594 need to be updated by these changes.
7595 * fns.c (make_hash_table, maybe_resize_hash_table):
7596 Check for integer overflow with large hash tables.
7597 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7598 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7599 (SXHASH_REDUCE): New macro.
7600 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7601 Use it instead of discarding useful hash info with large hash values.
7602 (sxhash_float): New function.
7603 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7604 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7605 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7606 Rewrite to use FIXNUM_BITS, as this simplifies things.
7607 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7608 Adjust signatures to match updated version of code.
7609 (consing_since_gc): Now EMACS_INT, since a single hash table can
7610 use more than INT_MAX bytes.
7612 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7614 Make it possible to build with GCC-4.6+ -O2 -flto.
7616 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7618 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7620 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7621 Call minibuffer-inactive-mode.
7623 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7625 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7626 Update dependencies.
7628 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7630 * data.c (init_data): Remove code for UTS, this system is not
7633 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7635 Don't force ./temacs to start in terminal mode.
7637 * frame.c (make_initial_frame): Initialize faces in all cases, not
7638 only when CANNOT_DUMP is defined.
7639 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7641 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7643 * dispnew.c (add_window_display_history): Use const for the string
7644 pointer. Remove declaration, not needed.
7646 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7648 Use 'inline', not 'INLINE'.
7649 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7650 * alloc.c, fontset.c (INLINE): Remove.
7651 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7652 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7653 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7654 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7655 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7657 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7659 Make it possible to run ./temacs.
7661 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7662 syms_of_callproc does the same thing. Remove test for
7663 "initialized", do it in the caller.
7664 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7666 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7668 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7669 (read_minibuf): Use get_minibuffer.
7670 (syms_of_minibuf): Use DEFSYM.
7671 (Qmetadata): New var.
7672 * data.c (Qbuffer): Don't make it static.
7673 (syms_of_data): Use DEFSYM.
7675 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7677 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7678 (CCL_CODE_MIN): New macro.
7680 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7682 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7684 * eval.c (Qdebug): Now static.
7685 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7686 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7687 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7689 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7691 * image.c: Various fixes to ImageMagick code comments.
7692 (Fimagemagick_types): Doc fix.
7694 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7696 Minor fixes prompted by GCC 4.6.0 warnings.
7698 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7700 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7701 (x_clipboard_manager_save_all): Move extern decl to ...
7702 * xterm.h: ... here, so that it can be checked for consistency.
7704 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7706 * xselect.c (x_clipboard_manager_save_frame)
7707 (x_clipboard_manager_save_all): New functions.
7708 (Fx_clipboard_manager_save): Lisp function deleted.
7710 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7711 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7713 * xterm.h: Update prototype.
7715 2011-05-28 William Xu <william.xwl@gmail.com>
7717 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7720 2011-05-28 Jim Meyering <meyering@redhat.com>
7722 Avoid a sign-extension bug in crypto_hash_function.
7723 * fns.c (to_uchar): Define.
7724 (crypto_hash_function): Use it to convert some newly-signed
7725 variables to unsigned, to avoid sign-extension bugs. For example,
7726 without this change, (md5 "truc") would evaluate to
7727 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7728 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7729 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7731 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7733 Integer overflow fixes.
7735 * dbusbind.c: Serial number integer overflow fixes.
7736 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7737 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7738 to hold a serial number that is too large for a fixnum.
7739 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7740 Check for serial numbers out of range. Decode any serial number
7741 that was so large that it became a float. (Bug#8722)
7743 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7744 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7745 Use XFASTINT rather than XUINT when numbers are nonnegative.
7746 (xd_append_arg, Fdbus_method_return_internal):
7747 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7748 arguments, check that Lisp number is nonnegative, rather than
7749 silently wrapping negative numbers around. (Bug#8722)
7750 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7753 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7755 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7757 ccl: Add integer overflow checks.
7758 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7759 (IN_INT_RANGE): New macros.
7760 (ccl_driver): Use them to check for integer overflow when
7761 decoding a CCL program. Many of the new checks are whether XINT (x)
7762 fits in int; it doesn't always, on 64-bit hosts. The new version
7763 doesn't catch all possible integer overflows, but it's an
7764 improvement. (Bug#8719)
7766 * alloc.c (make_event_array): Use XINT, not XUINT.
7767 There's no need for unsigned here.
7769 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7770 This follows up to the 2011-05-06 change that substituted uintptr_t
7771 for EMACS_INT. This case wasn't caught back then.
7773 Rework Fformat to avoid integer overflow issues.
7774 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7775 now (part of C89). Include <verify.h>.
7776 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7777 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7778 (Fformat): Avoid the prepass trying to compute sizes; it was only
7779 approximate and thus did not catch overflow reliably. Instead, walk
7780 through the format just once, formatting and computing sizes as we go,
7781 checking for integer overflow at every step, and allocating a larger
7782 buffer as needed. Keep track separately whether the format is
7783 multibyte. Keep only the most-recently calculated precision, rather
7784 than them all. Record whether each argument has been converted to
7785 string. Use EMACS_INT, not int, for byte and char and arg counts.
7786 Support field widths and precisions larger than INT_MAX. Avoid
7787 sprintf's undefined behavior with conversion specifications such as %#d
7788 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7789 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7790 formatting out-of-range floating point numbers with int
7793 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7795 * data.c: Avoid integer truncation in expressions involving floats.
7796 * data.c: Include <intprops.h>.
7797 (arith_driver): When there's an integer overflow in an expression
7798 involving floating point, convert the integers to floating point
7799 so that the resulting value does not suffer from catastrophic
7800 integer truncation. For example, on a 64-bit host (* 4
7801 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7802 Do not rely on undefined behavior after integer overflow.
7804 merge count_size_as_multibyte, parse_str_to_multibyte
7805 * character.c, character.h (count_size_as_multibyte):
7806 Rename from parse_str_to_multibyte; all uses changed.
7807 Check for integer overflow.
7808 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7809 since it's now a duplicate of the other. This is more of
7810 a character than a buffer op, so better that it's in character.c.
7811 * fns.c, print.c: Adjust to above changes.
7813 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7815 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7817 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7819 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7820 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7821 (x_clipboard_manager_save): Now static.
7822 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7824 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7825 (crypto_hash_function): Now static.
7826 Fix pointer signedness problems. Avoid unnecessary initializations.
7828 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7830 * termhooks.h (Vselection_alist): Make it terminal-local.
7832 * terminal.c (create_terminal): Initialize it.
7834 * xselect.c: Support for clipboard managers.
7835 (Vselection_alist): Move to termhooks.h as terminal-local var.
7836 (LOCAL_SELECTION): New macro.
7837 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7838 (symbol_to_x_atom): Remove gratuitous arg.
7839 (x_handle_selection_request, lisp_data_to_selection_data)
7840 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7841 (x_own_selection, x_get_local_selection, x_convert_selection):
7842 New arg, specifying work frame. Use terminal-local Vselection_alist.
7843 (some_frame_on_display): Delete unused function.
7844 (Fx_own_selection_internal, Fx_get_selection_internal)
7845 (Fx_disown_selection_internal, Fx_selection_owner_p)
7846 (Fx_selection_exists_p): New optional frame arg.
7847 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7848 (x_handle_selection_clear): Don't treat other terminals with the
7849 same keyboard specially. Use the terminal-local Vselection_alist.
7850 (x_clear_frame_selections): Use Frun_hook_with_args.
7852 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7854 * xterm.h: Add support for those atoms.
7856 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7858 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7859 (converted_selections, conversion_fail_tag): New global variables.
7860 (x_selection_request_lisp_error): Free the above.
7861 (x_get_local_selection): Remove unnecessary code.
7862 (x_reply_selection_request): Args changed; handle arbitrary array
7863 of converted selections stored in converted_selections.
7864 Separate the XChangeProperty and SelectionNotify steps.
7865 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7866 (x_convert_selection): New function.
7867 (x_handle_selection_event): Simplify.
7868 (x_get_foreign_selection): Don't ignore incoming requests while
7869 waiting for an answer; this will fail when we implement
7870 SAVE_TARGETS, and seems unnecessary anyway.
7871 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7872 (Vx_sent_selection_functions): Doc fix.
7874 2011-05-26 Leo Liu <sdl.web@gmail.com>
7876 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7878 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7880 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7882 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7883 for fringe update if it has periodic bitmap.
7884 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7885 and fringe_bitmap_periodic_p.
7887 * fringe.c (get_fringe_bitmap_data): New function.
7888 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7889 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7890 row. Mark glyph row for fringe update if periodicity changed.
7892 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7893 for fringe update unless it has periodic bitmap.
7895 2011-05-25 Kenichi Handa <handa@m17n.org>
7897 * xdisp.c (get_next_display_element): Set correct it->face_id for
7898 a static composition.
7900 2011-05-24 Leo Liu <sdl.web@gmail.com>
7903 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7905 * fns.c (crypto_hash_function, Fsha1): New function.
7906 (Fmd5): Use crypto_hash_function.
7907 (syms_of_fns): Add Ssha1.
7909 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7911 * gnutls.c: Remove unused macros.
7912 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7913 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7914 Remove macros that are defined and never used.
7915 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7917 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7919 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7920 (Fx_get_selection_internal): Minor cleanup.
7921 (Fx_own_selection_internal): Rename arguments for consistency with
7924 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7926 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7928 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7930 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7932 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7934 * dispnew.c (scrolling_window): Don't exclude the case that the
7935 last enabled row in the desired matrix touches the bottom boundary.
7937 2011-05-21 Glenn Morris <rgm@gnu.org>
7939 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7940 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7941 and add some more files.
7943 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7945 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7946 report_file_error introduced by the change from 2011-05-07.
7948 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7950 * systime.h (Time): Define only if emacs is defined.
7951 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7952 where the include path doesn't have X11/X.h by default. See
7953 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7955 2011-05-20 Kenichi Handa <handa@m17n.org>
7957 * composite.c (find_automatic_composition): Fix previous change.
7959 2011-05-20 Glenn Morris <rgm@gnu.org>
7961 * lisp.mk: New file, split from Makefile.in.
7962 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7963 (shortlisp): Remove.
7964 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7966 2011-05-19 Glenn Morris <rgm@gnu.org>
7968 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7969 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7970 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7971 (lisp): Set the order to that of loadup.el.
7972 (shortlisp): Make it a copy of $lisp.
7973 (SOME_MACHINE_LISP): Remove.
7974 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7975 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7977 2011-05-18 Kenichi Handa <handa@m17n.org>
7979 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7980 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7981 (find_automatic_composition): Mostly rewrite for efficiency.
7983 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7985 * makefile.w32-in: Update dependencies.
7987 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7989 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7990 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7992 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7994 Fix some integer overflow issues, such as string length overflow.
7996 * insdel.c (count_size_as_multibyte): Check for string overflow.
7998 * character.c (lisp_string_width): Check for string overflow.
7999 Use EMACS_INT, not int, for string indexes and lengths; in
8000 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8001 the resulting string length overflows an EMACS_INT; instead,
8002 report a string overflow if no precision given. When checking for
8003 precision exhaustion, use a check that cannot possibly have
8004 integer overflow. (Bug#8675)
8005 * character.h (lisp_string_width): Adjust to new signature.
8007 * alloc.c (string_overflow): New function.
8008 (Fmake_string): Use it. This doesn't change behavior, but saves
8009 a few bytes and will simplify future changes.
8010 * character.c (string_escape_byte8): Likewise.
8011 * lisp.h (string_overflow): New decl.
8013 Fixups, following up to the user-interface timestamp change.
8014 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8015 for UI timestamps, instead of unsigned long.
8016 * msdos.c (mouse_get_pos): Likewise.
8017 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8018 * w32gui.h (Time): Define by including "systime.h" rather than by
8019 declaring it ourselves. (Bug#8664)
8021 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8022 * image.c (clear_image_cache): Likewise.
8024 * term.c (term_mouse_position): Don't assume time_t wraparound.
8026 Be more systematic about user-interface timestamps.
8027 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8028 and sometimes 'EMACS_UINT', to represent these timestamps.
8029 This change causes it to use 'Time' uniformly, as that's what X uses.
8030 This makes the code easier to follow, and makes it easier to catch
8031 integer overflow bugs such as Bug#8664.
8032 * frame.c (Fmouse_position, Fmouse_pixel_position):
8033 Use Time, not unsigned long, for user-interface timestamps.
8034 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8035 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8036 * keyboard.h (last_event_timestamp): Likewise.
8037 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8038 * menu.h (xmenu_show): Likewise.
8039 * term.c (term_mouse_position): Likewise.
8040 * termhooks.h (struct input_event.timestamp): Likewise.
8041 (struct terminal.mouse_position_hook): Likewise.
8042 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8043 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8044 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8045 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8047 * menu.h, termhooks.h: Include "systime.h", for Time.
8049 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8050 Don't assume that the difference between two unsigned long values
8051 can fit into an integer. At this point, we know button_down_time
8052 <= event->timestamp, so the difference must be nonnegative, so
8053 there's no need to cast the result if double-click-time is
8054 nonnegative, as it should be; check that it's nonnegative, just in
8055 case. This bug is triggered when events are more than 2**31 ms
8056 apart (about 25 days). (Bug#8664)
8058 * xselect.c (last_event_timestamp): Remove duplicate decl.
8059 (x_own_selection): Remove needless cast to unsigned long.
8061 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8062 that always fit in int. Use a sentinel instead of a counter, to
8063 avoid a temp and to allay GCC's concerns about possible int overflow.
8064 * frame.h (struct frame): Use int for menu_bar_items_used
8065 instead of EMACS_INT, since it always fits in int.
8067 * menu.c (grow_menu_items): Check for int overflow.
8069 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8071 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8072 Before, the code was not consistent. These values cannot exceed
8073 2**31 - 1 so there's no need to make them unsigned.
8074 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8075 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8076 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8078 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8080 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8081 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8082 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8083 presumably because the widths might not match.
8085 * window.c (size_window): Avoid needless test at loop start.
8087 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8089 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8091 2011-05-12 Drew Adams <drew.adams@oracle.com>
8093 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8095 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8097 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8098 `width' to `bar_area_x' and `bar_area_width', respectively.
8099 (x_scroll_run): Take account of fringe background extension.
8101 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8102 Rename local vars `left' and `width' to `bar_area_x' and
8103 `bar_area_width', respectively.
8104 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8105 background extension.
8107 2011-05-10 Jim Meyering <meyering@redhat.com>
8109 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8111 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8113 * image.c (Finit_image_library): Return t for built-in image types,
8114 like pbm and xbm. (Bug#8640)
8116 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8118 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8120 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8122 * w32console.c (Fset_screen_color): Doc fix.
8123 (Fget_screen_color): New function.
8124 (syms_of_ntterm): Defsubr it.
8126 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8127 unlink the temporary file if Fcall_process didn't create it in the
8129 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8130 child process will be redirected to a file specified with `:file'.
8131 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8132 cue to call_process_cleanup not to close that handle.
8134 2011-05-07 Ben Key <bkey76@gmail.com>
8136 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8137 one of two shell specific rules, either bootstrap-temacs-CMD or
8138 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8139 to the previous implementation of the bootstrap-temacs rule.
8140 The bootstrap-temacs-CMD rule is similar to the previous
8141 implementation of the bootstrap-temacs rule except that it
8142 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8145 These changes, along with some changes to nt/configure.bat,
8146 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8147 earlier fix to add support for --cflags and --ldflags options
8148 that include quotes so that it works whether make uses cmd or
8151 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8153 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8154 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8156 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8157 a string. Handle both cases.
8158 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8159 (Fdbus_register_method): Use Qinvalid_function.
8161 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8163 * makefile.w32-in: Update dependencies.
8164 (LISP_H): Add inttypes.h and stdin.h.
8165 (PROCESS_H): Add unistd.h.
8167 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8169 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8170 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8172 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8174 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8176 * term.c (vfatal): Remove stray call to va_end.
8177 It's not needed and the C Standard doesn't allow it here anyway.
8179 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8180 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8182 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8185 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8187 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8189 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8191 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8193 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8195 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8196 * charset.c (Fdefine_charset_internal): Don't initialize
8197 charset.code_space[15]. The value was garbage, on hosts with
8198 32-bit int (Bug#8600).
8200 * lread.c (read_integer): Be more consistent with string-to-number.
8201 Use string_to_number to do the actual conversion; this avoids
8202 rounding errors and fixes some other screwups. Without this fix,
8203 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8204 (digit_to_number): Move earlier, for benefit of read_integer.
8205 Return -1 if the digit is out of range for the base, -2 if it is
8206 not a digit in any supported base. (Bug#8602)
8208 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8210 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8211 to match comment at start of function. This also removes a
8212 GCC warning about overflow in a 32+64-bit port.
8214 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8216 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8217 Reported by Stefan Monnier in
8218 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8220 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8222 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8223 (EMACS_UINTPTR): Likewise, with uintptr_t.
8225 * lisp.h: Prefer 64-bit EMACS_INT if available.
8226 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8227 on 32-bit hosts that have 64-bit int, so that they can access
8229 However, temporarily disable this change unless the temporary
8230 symbol WIDE_EMACS_INT is defined.
8232 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8234 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8235 This removes an assumption that EMACS_INT and long are the same
8236 width as pointers. The assumption is true for Emacs porting targets
8237 now, but we want to make other targets possible.
8238 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8239 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8240 In the rest of the code, change types of integers that hold casted
8241 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8242 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8243 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8244 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8245 No need to cast type when ORing.
8246 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8247 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8248 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8249 assume EMACS_INT is the same width as char *.
8250 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8251 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8252 Remove no-longer-needed casts.
8253 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8254 (xg_tool_bar_help_callback, xg_make_tool_item):
8255 Use EMACS_INTPTR to hold an integer
8256 that will be cast to void *; this can avoid a GCC warning
8257 if EMACS_INT is not the same width as void *.
8258 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8259 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8260 (current_message_1, set_message_1):
8261 Use a local to convert to proper width without a cast.
8262 * xmenu.c (dialog_selection_callback): Likewise.
8264 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8265 Also, don't assume VALBITS / RAND_BITS is less than 5,
8266 and don't rely on undefined behavior when shifting a 1 left into
8268 * lisp.h (get_random): Change signature to match.
8270 * lread.c (hash_string): Use size_t, not int, for hash computation.
8271 Normally we prefer signed values; but hashing is special, because
8272 it's better to use unsigned division on hash table sizes so that
8273 the remainder is nonnegative. Also, size_t is the natural width
8274 for hashing into memory. The previous code used 'int', which doesn't
8275 retain enough info to hash well into very large tables.
8276 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8278 * dbusbind.c: Don't possibly lose pointer info when converting.
8279 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8280 Use XPNTR rather than XHASH, so that the high-order bits of
8281 the pointer aren't lost when converting through void *.
8283 * eval.c (Fautoload): Don't double-shift a pointer.
8285 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8287 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8289 * gnutls.c (DEF_GNUTLS_FN):
8290 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8292 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8294 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8297 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8299 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8300 New version that can reserve upto 2GB of heap space.
8302 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8304 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8306 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8308 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8309 `gnutls_certificate_set_x509_key_file'.
8311 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8313 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8314 Update dependencies.
8316 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8318 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8319 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8320 Remove unused parameter `fildes'.
8321 * process.c (read_process_output, send_process): Don't pass it.
8323 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8325 Fix previous change: the library cache is defined in w32.c.
8326 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8327 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8329 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8331 Implement dynamic loading of GnuTLS on Windows.
8333 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8334 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8335 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8338 * gnutls.c (Qgnutls_dll): Define.
8339 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8340 (gnutls_*): Declare function pointers.
8341 (init_gnutls_functions): New function to initialize function pointers.
8342 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8343 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8344 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8345 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8346 (emacs_gnutls_write, emacs_gnutls_read)
8347 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8348 (Fgnutls_available_p): New function.
8349 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8350 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8351 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8353 * image.c: Include w32.h.
8354 (Vimage_type_cache): Delete.
8355 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8356 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8357 (w32_delayed_load): Move to w32.c.
8359 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8361 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8362 (w32_delayed_load): Move from image.c. When loading a library, record
8363 its filename in the :loaded-from property of the library id.
8364 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8365 Initialize and staticpro them.
8366 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8368 * process.c: Include lisp.h before w32.h, not after.
8369 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8370 instead of gnutls_record_check_pending.
8372 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8374 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8376 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8377 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8380 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8382 * xterm.c (x_set_frame_alpha): Do not set property on anything
8383 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8385 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8387 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8389 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8391 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8392 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8393 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8394 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8395 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8396 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8397 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8398 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8399 (Qgnutls_bootprop_callbacks_verify): Make static.
8401 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8403 * callproc.c: Indentation fixup.
8405 * sysdep.c (wait_for_termination_1): Make static.
8406 (wait_for_termination, interruptible_wait_for_termination):
8407 Move after wait_for_termination_1.
8409 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8411 * sysdep.c (interruptible_wait_for_termination): New function
8412 which is like wait_for_termination, but allows keyboard
8415 * callproc.c (Fcall_process): Add (:file "file") as an option for
8417 (Fcall_process_region): Ditto.
8419 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8421 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8422 rather than `XVECTOR (FOO)->size'.
8424 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8425 inttypes.h, as a gnulib replacement is used if it not available in
8428 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8430 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8431 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8432 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8434 * coding.c (coding_alloc_by_realloc): Error out if destination
8435 will grow beyond MOST_POSITIVE_FIXNUM.
8436 (decode_coding_emacs_mule): Abort if there isn't enough place in
8437 charbuf for the composition carryover bytes. Reserve an extra
8438 space for up to 2 characters produced in a loop.
8439 (decode_coding_iso_2022): Abort if there isn't enough place in
8440 charbuf for the composition carryover bytes.
8442 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8444 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8445 aborting when %lld or %lll format is passed.
8446 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8447 %llo or %llx format is passed. (Bug#8545)
8449 * window.c (window_scroll_line_based): Use a marker instead of
8450 simple variables to record original value of point. (Bug#7952)
8452 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8453 produced by %s or %c overflows available buffer space. (Bug#8545)
8455 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8457 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8458 (SIZE_MAX): Move defn after all includes, as they might #define it.
8460 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8462 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8464 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8466 * keyboard.c (Qdelayed_warnings_hook): Define.
8467 (command_loop_1): Run `delayed-warnings-hook'
8468 if Vdelayed_warnings_list is non-nil.
8469 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8470 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8472 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8474 * doprnt.c (doprnt): Don't return value smaller than the buffer
8475 size if the message was truncated. (Bug#8545).
8477 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8479 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8480 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8482 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8484 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8486 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8488 * makefile.w32-in: Update dependencies.
8490 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8492 Improve `doprnt' and its usage. (Bug#8545)
8493 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8494 `format_end'. Remove support for %l as a conversion specifier.
8495 Don't use xrealloc. Improve diagnostics when the %l size modifier
8496 is used. Update the commentary.
8498 * eval.c (verror): Simplify calculation of size_t.
8500 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8503 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8505 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8508 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8510 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8511 This makes this file independent of the recent pseudovector change.
8513 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8515 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8517 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8518 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8519 Remove unused local.
8520 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8522 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8523 GCC 4.6.0 optimizes based on type-based alias analysis.
8524 For example, if b is of type struct buffer * and v of type struct
8525 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8526 != &v->size, and therefore "v->size = 1; b->size = 2; return
8527 v->size;" must therefore return 1. This assumption is incorrect
8528 for Emacs, since it type-puns struct Lisp_Vector * with many other
8529 types. To fix this problem, this patch adds a new type struct
8530 vectorlike_header that documents the constraints on layout of vectors
8531 and pseudovectors, and helps optimizing compilers not get fooled
8532 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8533 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8534 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8536 (XSETPVECTYPE): Rewrite in terms of new macro.
8537 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8538 This is a bit clearer, and further avoids the possibility of
8539 undesirable aliasing.
8540 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8541 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8542 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8543 since Lisp_Subr is a special case (no "next" field).
8544 (ASIZE): Now uses header.size rather than size.
8545 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8546 to avoid the hassle of writing XVECTOR (foo)->header.size.
8547 (struct vectorlike_header): New type.
8548 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8549 object, to help avoid aliasing.
8550 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8551 (SUBRP): Likewise, since Lisp_Subr is a special case.
8552 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8553 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8554 (struct Lisp_Hash_Table): Combine first two members into a single
8555 struct vectorlike_header member. All uses of "size" and "next" members
8556 changed to be "header.size" and "header.next".
8557 * buffer.h (struct buffer): Likewise.
8558 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8559 * frame.h (struct frame): Likewise.
8560 * process.h (struct Lisp_Process): Likewise.
8561 * termhooks.h (struct terminal): Likewise.
8562 * window.c (struct save_window_data, struct saved_window): Likewise.
8563 * window.h (struct window): Likewise.
8564 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8565 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8566 * buffer.c (init_buffer_once): Likewise.
8567 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8569 * process.c (Fformat_network_address): Use local var for size,
8572 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8574 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8575 * data.c (atof): Remove decl; no longer used or needed.
8576 (digit_to_number): Move to lread.c.
8577 (Fstring_to_number): Use new string_to_number function, to be
8578 consistent with how the Lisp reader treats infinities and NaNs.
8579 Do not assume that floating-point numbers represent EMACS_INT
8580 without losing information; this is not true on most 64-bit hosts.
8581 Avoid double-rounding errors, by insisting on integers when
8582 parsing non-base-10 numbers, as the documentation specifies.
8583 * lisp.h (string_to_number): New decl, replacing ...
8584 (isfloat_string): Remove.
8585 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8586 (read1): Do not accept +. and -. as integers; this
8587 appears to have been a coding error. Similarly, do not accept
8588 strings like +-1e0 as floating point numbers. Do not report
8589 overflow for integer overflows unless the base is not 10 which
8590 means we have no simple and reliable way to continue.
8591 Break out the floating-point parsing into a new
8592 function string_to_number, so that Fstring_to_number parses
8593 floating point numbers consistently with the Lisp reader.
8594 (digit_to_number): Move here from data.c. Make it static inline.
8595 (E_CHAR, EXP_INT): Remove, replacing with ...
8596 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8597 (string_to_number): New function, replacing isfloat_string.
8598 This function checks for valid syntax and produces the resulting
8599 Lisp float number too. Rework it so that string-to-number
8600 no longer mishandles examples like "1.0e+". Use strtoumax,
8601 so that overflow for non-base-10 numbers is reported only when
8602 there's no portable and simple way to convert to floating point.
8604 * textprop.c (set_text_properties_1): Rewrite for clarity,
8605 and to avoid GCC warning about integer overflow.
8607 * intervals.h (struct interval): Use EMACS_INT for members
8608 where EMACS_UINT might cause problems. See
8609 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8610 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8611 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8613 (offset_intervals): Tell GCC not to worry about length overflow
8614 when negating a negative length.
8616 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8617 (overrun_check_free): Likewise.
8619 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8620 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8623 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8624 (gnutls_make_error): Rename local to avoid shadowing.
8625 (gnutls_emacs_global_deinit): ifdef out; not used.
8626 (Fgnutls_boot): Use const for pointer to readonly storage.
8627 Comment out unused local. Fix pointer signedness problems.
8629 * lread.c (openp): Don't stuff size_t into an 'int'.
8630 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8631 about possible signed overflow.
8633 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8634 (GDK_KEY_g): Don't define if already defined.
8635 (xg_prepare_tooltip): Avoid pointer signedness problem.
8636 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8638 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8639 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8641 * xfns.c (Fx_window_property): Simplify a bit,
8642 to make a bit faster and to avoid GCC 4.6.0 warning.
8643 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8645 * fns.c (internal_equal): Don't assume size_t fits in int.
8647 * alloc.c (compact_small_strings): Tighten assertion a little.
8649 Replace pEd with more-general pI, and fix some printf arg casts.
8650 * lisp.h (pI): New macro, generalizing old pEd macro to other
8651 conversion specifiers. For example, use "...%"pI"d..." rather
8652 than "...%"pEd"...".
8653 (pEd): Remove. All uses replaced with similar uses of pI.
8654 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8655 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8656 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8657 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8658 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8659 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8660 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8662 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8663 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8664 * print.c (safe_debug_print, print_object): Likewise.
8665 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8667 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8668 avoiding the 0 flag, which is not portable.
8669 * process.c (Fmake_network_process): Use pI to avoid cast.
8670 * region-cache.c (pp_cache): Likewise.
8671 * xdisp.c (decode_mode_spec): Likewise.
8672 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8673 behavior on 64-bit hosts with printf arg.
8674 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8675 (x_stop_queuing_selection_requests): Likewise.
8676 (x_get_window_property): Don't truncate byte count to an 'int'
8679 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8680 here, since it parses constructs like leading '-' and spaces,
8681 which are not wanted; and it overflows with large numbers.
8682 Instead, simply match F[0-9]+, which is what is wanted anyway.
8684 * alloc.c: Remove unportable assumptions about struct layout.
8685 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8686 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8687 (allocate_vectorlike, make_pure_vector): Use the new macros,
8688 plus offsetof, to remove unportable assumptions about struct layout.
8689 These assumptions hold on all porting targets that I know of, but
8690 they are not guaranteed, they're easy to remove, and removing them
8691 makes further changes easier.
8693 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8694 This doesn't fix a bug but makes the code clearer.
8695 (string_overrun_cookie): Now const. Use initializers that
8696 don't formally overflow signed char, to avoid warnings.
8697 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8698 can cause Emacs to crash when string overrun checking is enabled.
8699 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8700 multiple of sizeof (EMACS_INT); it need not be, if
8701 alignof(EMACS_INT) < sizeof (EMACS_INT).
8702 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8704 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8706 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8708 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8710 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8711 supposed to be handshaking. (Bug#8556)
8712 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8714 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8716 * lisp.h (Qdebug): List symbol.
8717 * eval.c (Qdebug): Restore global linkage.
8718 * keyboard.c (debug-on-event): New variable.
8719 (handle_user_signal): Break into debugger when debug-on-event
8720 matches the current signal symbol.
8722 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8724 * alloc.c (check_sblock, check_string_bytes)
8725 (check_string_free_list): Convert to standard C.
8727 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8729 * w32.c (emacs_gnutls_push): Fix typo.
8731 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8733 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8734 "cast to pointer from integer of different size".
8736 Improve doprnt and its use in verror. (Bug#8545)
8737 * doprnt.c (doprnt): Document the set of format control sequences
8738 supported by the function. Use SAFE_ALLOCA instead of always
8741 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8742 is one byte too soon. Don't use xrealloc; instead xfree and
8745 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8747 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8750 * gnutls.c: Renamed global_initialized to
8751 gnutls_global_initialized. Added internals for the
8752 :verify-hostname-error, :verify-error, and :verify-flags
8753 parameters of `gnutls-boot' and documented those parameters in the
8754 docstring. Start callback support.
8755 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8756 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8757 on error. Return error code.
8758 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8759 (emacs_gnutls_read): Likewise.
8760 (Fgnutls_boot): Return handshake error code.
8761 (emacs_gnutls_handle_error): New function.
8762 (wsaerror_to_errno): Likewise.
8764 * w32.h (emacs_gnutls_pull): Add prototype.
8765 (emacs_gnutls_push): Likewise.
8767 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8768 (emacs_gnutls_push): Likewise.
8770 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8772 * process.c (wait_reading_process_output): Check if GnuTLS
8773 buffered some data internally if no FDs are set for TLS
8776 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8777 (LIBS): Link to USER_LIBS.
8778 ($(BLD)/gnutls.$(0)): New target.
8780 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8782 * xdisp.c (handle_single_display_spec): Rename the
8783 display_replaced_before_p argument into display_replaced_p, to
8784 make it consistent with the commentary. Fix typos in the
8787 * textprop.c (syms_of_textprop): Remove dead code.
8788 (copy_text_properties): Delete obsolete commentary about an
8789 interface that was deleted long ago. Fix typos in the description
8792 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8793 to changes in oldXMenu/XMenu.h from 2011-04-16.
8794 <menu_help_message, prev_menu_help_message>: Constify.
8795 (IT_menu_make_room): menu->help_text is now `const char **';
8798 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8799 to changes in oldXMenu/XMenu.h from 2011-04-16.
8800 (struct XMenu): Declare `help_text' `const char **'.
8802 * xfaces.c <Qunspecified>: Make extern again.
8804 * syntax.c: Include sys/types.h before including regex.h, as
8807 * doc.c (get_doc_string): Improve the format passed to `error'.
8809 * doprnt.c (doprnt): Improve commentary.
8811 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8813 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8816 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8817 changes in globals.h immediately force recompilation.
8818 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8819 $(CURDIR)/s/ms-w32.h.
8820 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8822 * character.c (Fchar_direction): Function deleted.
8823 (syms_of_character): Don't defsubr it.
8824 <char-direction-table>: Deleted.
8826 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8828 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8829 * doprnt.c: Include limits.h.
8830 (SIZE_MAX): New macro.
8831 (doprnt): Return a size_t value. 2nd arg is now size_t.
8832 Many local variables are now size_t instead of int or unsigned.
8833 Improve overflow protection. Support `l' modifier for integer
8834 conversions. Support %l conversion. Don't assume an EMACS_INT
8835 argument for integer conversions and for %c.
8837 * lisp.h (doprnt): Restore prototype.
8839 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8842 * Makefile.in (base_obj): Add back doprnt.o.
8844 * deps.mk (doprnt.o): Add back prerequisites.
8845 (callint.o): Depend on character.h.
8847 * eval.c (internal_lisp_condition_case): Include the handler
8848 representation in the error message.
8849 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8850 when breaking from the loop.
8852 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8854 * callint.c (Fcall_interactively): When displaying error message
8855 about invalid control letter, pass the character's codepoint, not
8856 a pointer to its multibyte form. Improve display of the character
8857 in octal and display also its hex code.
8859 * character.c (char_string): Use %x to display the (unsigned)
8860 codepoint of an invalid character, to avoid displaying a bogus
8863 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8864 `error', not SYMBOL_NAME itself.
8866 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8867 character arguments to `error'.
8869 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8870 to `error' in error message about FINAL_CHAR argument. Make sure
8871 FINAL_CHAR is a character, and use %c when it is passed as
8872 argument to `error'.
8874 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8876 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8878 * w32.c: Include <time.h>.
8879 (sys_localtime): New function.
8881 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8883 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8885 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8887 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8889 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8892 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8894 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8895 gl_state.e_property when gl_state.object is Qt.
8897 * insdel.c (make_gap_larger): Remove limitation of buffer size
8900 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8902 * xdisp.c (lookup_glyphless_char_display)
8903 (produce_glyphless_glyph): Handle cons cell entry in
8904 glyphless-char-display.
8905 (Vglyphless_char_display): Document it.
8907 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8908 glyphless-char-display.
8910 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8912 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8914 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8916 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8917 definition for no-X builds.
8919 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8921 Static checks with GCC 4.6.0 and non-default toolkits.
8923 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8925 * process.c (keyboard_bit_set): Define only if SIGIO.
8926 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8927 (send_process): Repair possible setjmp clobbering.
8929 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8931 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8933 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8935 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8936 Define only if needed.
8938 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8939 by pacifying GCC about it. Maybe it's time to retire it?
8940 * xfaces.c (USG, __TIMEVAL__): Likewise.
8942 * dispextern.h (struct redisplay_interface): Rename param
8944 * termhooks.h (struct terminal): Likewise.
8945 * xterm.c (xembed_send_message): Likewise.
8947 * insdel.c (make_gap_smaller): Define only if
8948 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8950 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8953 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8954 so that we aren't warned about unused symbols.
8956 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8958 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8960 * xfns.c (x_real_positions): Mark locals as initialized.
8962 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8964 * xterm.c: Fix problems found by static analysis with other toolkits.
8965 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8966 (x_dispatch_event): Declare static if USE_GTK, and
8967 define if USE_GTK || USE_X_TOOLKIT.
8968 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8969 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8970 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8971 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8973 * xmenu.c (menu_help_callback): Pointer type fixes.
8974 Use const pointers when pointing at readonly data. Avoid pointer
8976 (FALSE): Remove unused macro.
8977 (update_frame_menubar): Remove unused decl.
8979 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8981 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8982 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8983 (single_menu_item): Rename local to avoid shadowing.
8985 * keyboard.c (make_lispy_event): Remove unused local var.
8987 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8988 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8990 * bitmaps: Change bitmaps from unsigned char back to the X11
8991 compatible char. Avoid the old compiler warnings about
8992 out-of-range initializers by using, for example, '\xab' rather
8995 * xgselect.c (xgselect_initialize): Check vs interface
8996 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8998 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9000 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9001 to read-only memory.
9003 * fns.c (vector): Remove; this old hack is no longer needed.
9005 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9007 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9009 * xrdb.c (x_load_resources): Omit unused local.
9011 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9012 (x_window): Rename locals to avoid shadowing.
9013 (USG): Use the kludged USG macro, to pacify gcc.
9015 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9016 (x_term_init): Remove local to avoid shadowing.
9018 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9020 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9021 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9023 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9025 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9027 Fix regex.c, syntax.c and friends for buffers > 2GB.
9028 * syntax.h (struct gl_state_s): Declare character position members
9031 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9033 * textprop.c (verify_interval_modification, interval_of):
9034 Declare arguments EMACS_INT.
9036 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9039 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9041 * indent.c (Fvertical_motion): Local variable it_start is now
9044 * regex.c (re_match, re_match_2, re_match_2_internal)
9045 (bcmp_translate, regcomp, regexec, print_double_string)
9046 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9047 (re_compile_pattern, re_exec): Declare arguments and local
9048 variables `size_t' and `ssize_t' and return values `regoff_t', as
9050 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9051 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9052 <compile_stack_type>: `size' and `avail' are now `size_t'.
9054 * regex.h <regoff_t>: Use ssize_t, not int.
9055 (re_search, re_search_2, re_match, re_match_2): Arguments that
9056 specify buffer/string position and length are now ssize_t and
9057 size_t. Return type is regoff_t.
9059 2011-04-16 Ben Key <bkey76@gmail.com>
9061 * nsfont.m: Fixed bugs in ns_get_family and
9062 ns_descriptor_to_entity that were caused by using free to
9063 deallocate memory blocks that were allocated by xmalloc (via
9064 xstrdup). This caused Emacs to crash when compiled with
9065 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9066 --enable-checking=xmallocoverrun). xfree is now used to
9067 deallocate these memory blocks.
9069 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9071 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9073 emacs_write: Accept and return EMACS_INT for sizes.
9074 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9076 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9077 Accept and return EMACS_INT.
9078 (emacs_gnutls_write): Return the number of bytes written on
9080 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9081 (emacs_read, emacs_write): Remove check for negative size, as the
9082 Emacs source code has been audited now.
9083 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9084 (emacs_read, emacs_write): Use it.
9085 * process.c (send_process): Adjust to the new signatures of
9086 emacs_write and emacs_gnutls_write. Do not attempt to store
9087 a byte offset into an 'int'; it might overflow.
9088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9090 * sound.c: Don't assume sizes fit in 'int'.
9091 (struct sound_device.period_size, alsa_period_size):
9092 Return EMACS_INT, not int.
9093 (struct sound_device.write, vox_write, alsa_write):
9094 Accept EMACS_INT, not int.
9095 (wav_play, au_play): Use EMACS_INT to store sizes and to
9096 record read return values.
9098 2011-04-15 Ben Key <bkey76@gmail.com>
9100 * keyboard.c (Qundefined): Don't declare static since it is used
9102 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9103 static since they are used in nsfont.m.
9105 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9107 * process.c (Qprocessp): Don't declare static.
9108 * lisp.h (Qprocessp): Declare again.
9110 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9112 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9114 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9116 Improve C-level modularity by making more things 'static'.
9118 Don't publish debugger-only interfaces to other modules.
9119 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9120 (verify_bytepos, count_markers): Move decls to the only modules
9122 * region-cache.h (pp_cache): Likewise.
9123 * window.h (check_all_windows): Likewise.
9124 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9126 * sysdep.c (croak): Now static, if
9127 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9128 * syssignal.h (croak): Declare only if not static.
9130 * alloc.c (refill_memory_reserve): Now static if
9131 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9132 * lisp.h (refill_memory_reserve): Declare only if not static.
9134 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9135 Define only if USE_LUCID.
9137 * xrdb.c (x_customization_string, x_rm_string): Now static.
9139 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9140 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9142 * xdisp.c (draw_row_with_mouse_face): Now static.
9143 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9145 * window.h (check_all_windows): Mark externally visible.
9147 * window.c (window_deletion_count): Now static.
9149 * undo.c: Make symbols static if they're not exported.
9150 (last_undo_buffer, last_boundary_position, pending_boundary):
9153 * textprop.c (interval_insert_behind_hooks): Now static.
9154 (interval_insert_in_front_hooks): Likewise.
9156 * term.c: Make symbols static if they're not exported.
9157 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9158 (max_frame_lines, tty_set_terminal_modes):
9159 (tty_reset_terminal_modes, tty_turn_off_highlight):
9160 (get_tty_terminal): Now static.
9161 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9162 * termhooks.h (term_mouse_moveto): Do not declare if
9164 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9165 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9167 * sysdep.c: Make symbols static if they're not exported.
9168 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9170 (sigprocmask_set, full_mask): Remove; unused.
9171 (wait_debugging): Mark as visible.
9172 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9173 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9175 * syntax.c (syntax_temp): Define only if !__GNUC__.
9177 * sound.c (current_sound_device, current_sound): Now static.
9179 * search.c (searchbufs, searchbuf_head): Now static.
9181 * scroll.c (scroll_cost): Remove; unused.
9182 * dispextern.h (scroll_cost): Remove decl.
9184 * region-cache.h (pp_cache): Mark as externally visible.
9186 * process.c: Make symbols static if they're not exported.
9187 (process_tick, update_tick, create_process, chan_process):
9188 (Vprocess_alist, proc_buffered_char, datagram_access):
9189 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9190 (deactivate_process): Mark defn as static, as well as decl.
9191 * lisp.h (create_process): Remove decl.
9192 * process.h (chan_process, Vprocess_alist): Remove decls.
9194 * print.c: Make symbols static if they're not exported.
9195 (print_depth, new_backquote_output, being_printed, print_buffer):
9196 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9197 (print_interval, print_number_index, initial_stderr_stream):
9199 * lisp.h (Fprinc): Remove decl.
9200 (debug_output_compilation_hack): Mark as externally visible.
9202 * sysdep.c (croak): Move decl from here to syssignal.h.
9203 * syssignal.h (croak): Put it here, so the API can be checked when
9204 'croak' is called from dissociate_if_controlling_tty.
9206 * minibuf.c: Make symbols static if they're not exported.
9207 (minibuf_save_list, choose_minibuf_frame): Now static.
9208 * lisp.h (choose_minibuf_frame): Remove decl.
9210 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9212 * lread.c: Make symbols static if they're not exported.
9213 (read_objects, initial_obarray, oblookup_last_bucket_number):
9215 (make_symbol): Remove; unused.
9216 * lisp.h (initial_obarray, make_symbol): Remove decls.
9218 * keyboard.c: Make symbols static if they're not exported.
9219 (single_kboard, recent_keys_index, total_keys, recent_keys):
9220 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9221 (this_single_command_key_start, echoing, last_auto_save):
9222 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9223 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9224 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9225 (Vlispy_mouse_stem, double_click_count):
9227 (force_auto_save_soon): Define only if SIGDANGER.
9228 (ignore_mouse_drag_p): Now static if
9229 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9230 (print_help): Remove; unused.
9231 (stop_character, last_timer_event): Mark as externally visible.
9232 * keyboard.h (ignore_mouse_drag_p): Declare only if
9233 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9234 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9235 * lisp.h (echoing): Remove decl.
9236 (force_auto_save_soon): Declare only if SIGDANGER.
9237 * xdisp.c (redisplay_window): Simplify code, to make it more
9238 obvious that ignore_mouse_drag_p is not accessed if !defined
9239 USE_GTK && !defined HAVE_NS.
9241 * intervals.c: Make symbols static if they're not exported.
9242 (merge_properties_sticky, merge_interval_right, delete_interval):
9244 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9246 * insdel.c: Make symbols static if they're not exported.
9247 However, leave prepare_to_modify_buffer alone. It's never
9248 called from outside this function, but that appears to be a bug.
9249 (combine_after_change_list, combine_after_change_buffer):
9250 (adjust_after_replace, signal_before_change): Now static.
9251 (adjust_after_replace_noundo): Remove; unused.
9252 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9253 (signal_before_change): Remove decls.
9255 * indent.c (val_compute_motion, val_vmotion): Now static.
9257 * image.c: Make symbols static if they're not exported.
9258 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9260 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9261 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9263 * fringe.c (standard_bitmaps): Now static.
9264 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9266 * frame.c: Make symbols static if they're not exported.
9267 (x_report_frame_params, make_terminal_frame): Now static.
9268 (get_frame_param): Now static, unless HAVE_NS.
9269 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9270 (x_get_resource_string): Remove; not used.
9271 * frame.h (make_terminal_frame, x_report_frame_params):
9272 (x_get_resource_string); Remove decls.
9273 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9274 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9276 * font.c, fontset.c: Make symbols static if they're not exported.
9277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9278 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9279 * font.c (font_close_object): Now static.
9280 * font.h (font_close_object): Remove.
9281 * fontset.c (FONTSET_OBJLIST): Remove.
9282 (free_realized_fontset) #if-0 the body, which does nothing.
9283 (face_suitable_for_char_p): #if-0, as it's never called.
9284 * fontset.h (face_suitable_for_char_p): Remove decl.
9285 * xfaces.c (face_at_string_position):
9286 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9287 since 0 is always ASCII.
9289 * fns.c (weak_hash_tables): Now static.
9291 * fileio.c: Make symbols static if they're not exported.
9292 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9293 (Vwrite_region_annotation_buffers): Now static.
9295 * eval.c: Make symbols static if they're not exported.
9296 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9297 * lisp.h (backtrace_list): Remove decl.
9299 * emacs.c: Make symbols static if they're not exported.
9300 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9301 (fatal_error_code, fatal_error_signal_hook, standard_args):
9303 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9304 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9305 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9306 * lisp.h (fatal_error_signal_hook): Remove decl.
9307 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9309 * editfns.c: Move a (normally-unused) function to its only use.
9310 * editfns.c, lisp.h (get_operating_system_release): Remove.
9311 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9312 worth the hassle of breaking this out.
9314 * xterm.c: Make symbols static if they're not exported.
9315 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9316 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9317 (x_destroy_window, x_delete_display):
9319 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9320 (x_mouse_leave): Remove; unused.
9321 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9322 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9323 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9325 (x_mouse_leave): Declare only if WINDOWSNT.
9326 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9327 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9330 * ftxfont.c: Make symbols static if they're not exported.
9331 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9333 * font.h (ftxfont_driver): Likewise.
9335 * xfns.c: Make symbols static if they're not exported.
9336 (x_last_font_name, x_display_info_for_name):
9337 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9338 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9339 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9340 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9341 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9342 (last_show_tip_args): Now static.
9343 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9344 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9345 (x_screen_planes): Remove; unused.
9346 * dispextern.h (x_screen_planes): Remove decl.
9348 * dispnew.c: Make symbols static if they're not exported.
9349 * dispextern.h (redraw_garbaged_frames, scrolling):
9350 (increment_row_positions): Remove.
9351 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9352 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9354 (redraw_garbaged_frames): Remove; unused.
9356 * xfaces.c: Make symbols static if they're not exported.
9357 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9359 * xterm.h (defined_color): Remove decls.
9360 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9361 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9362 (menu_face_changed_default, defined_color, free_realized_face):
9363 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9364 (ascii_face_of_lisp_face): Remove; unused.
9366 * xdisp.c: Make symbols static if they're not exported.
9367 * dispextern.h (scratch_glyph_row, window_box_edges):
9368 (glyph_to_pixel_coords, set_cursor_from_row):
9369 (get_next_display_element, set_iterator_to_next):
9370 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9371 (show_mouse_face): Remove decls
9372 * frame.h (message_buf_print): Likewise.
9373 * lisp.h (pop_message, set_message, check_point_in_composition):
9375 * xterm.h (set_vertical_scroll_bar): Likewise.
9376 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9377 (message_buf_print, scratch_glyph_row, displayed_buffer):
9378 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9379 (get_next_display_element, show_mouse_face, window_box_edges):
9380 (frame_to_window_pixel_xy, check_point_in_composition):
9381 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9382 (glyph_to_pixel_coords): Remove; unused.
9384 * dired.c (file_name_completion): Now static.
9386 * dbusbind.c (xd_in_read_queued_messages): Now static.
9388 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9389 * data.c (circular_list_error): Remove.
9391 * commands.h (last_point_position, last_point_position_buffer):
9392 (last_point_position_window): Remove decls.
9393 * keyboard.c: Make these variables static.
9395 * coding.h (coding, code_convert_region, encode_coding_gap):
9397 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9398 (iso_code_class, detect_coding, code_convert_region): Now static.
9399 (encode_coding_gap): Remove; unused.
9401 * chartab.c (chartab_chars, chartab_bits): Now static.
9403 * charset.h (charset_iso_8859_1): Remove decl.
9404 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9407 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9408 * ccl.c (Vccl_program_table): Now static.
9409 (check_ccl_update): Remove; unused.
9411 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9412 * category.h: ... from here.
9413 * category.c (check_category_table, set_category_set): Now static.
9415 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9416 * lisp.h: Remove these decls.
9418 * buffer.c (buffer_count): Remove unused var.
9420 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9421 so that it's not optimized away.
9422 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9423 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9424 exported only to the debugger.
9426 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9427 * atimer.h (run_all_atimers): Remove; not exported.
9429 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9430 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9431 was inaccessible from Lisp.
9432 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9433 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9435 alloc.c: Import and export fewer symbols, and remove unused items.
9436 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9438 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9439 it's not optimized away by whole-program optimization.
9440 (message_enable_multibyte, free_misc): Remove.
9441 (catchlist, handlerlist, mark_backtrace):
9442 Declare only if BYTE_MARK_STACK.
9443 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9444 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9445 (message_enable_multibyte): Remove decl.
9446 (free_misc, interval_free_list, float_block, float_block_index):
9447 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9448 (cons_free_list, last_marked_index):
9450 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9451 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9452 (mark_backtrace): Define only if BYTE_MARK_STACK.
9453 * xdisp.c (message_enable_multibyte): Now static.
9455 Declare Lisp_Object Q* variables to be 'static' if not exported.
9456 This makes it easier for human readers (and static analyzers)
9457 to see whether these variables are used from other modules.
9458 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9459 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9460 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9461 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9462 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9463 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9464 * xmenu.c, xselect.c:
9465 Declare Q* vars static if they are not used in other modules.
9466 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9467 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9468 Remove decls of unexported vars.
9469 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9471 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9473 Make Emacs functions such as Fatom 'static' by default.
9474 This makes it easier for human readers (and static analyzers)
9475 to see whether these functions can be called from other modules.
9476 DEFUN now defines a static function. To make the function external
9477 so that it can be used in other C modules, use the new macro DEFUE.
9478 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9479 (Finit_image_library):
9480 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9481 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9482 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9483 Remove decls, since these functions are now static.
9484 (Funintern, Fget_internal_run_time): New decls, since these functions
9485 were already external.
9487 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9488 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9489 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9490 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9491 * keyboard.c, keymap.c, lread.c:
9492 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9493 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9494 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9495 Mark functions with DEFUE instead of DEFUN,
9496 if they are used in other modules.
9497 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9498 decls for now-static functions.
9499 * buffer.h (Fdelete_overlay): Remove decl.
9500 * callproc.c (Fgetenv_internal): Mark as internal.
9501 * composite.c (Fremove_list_of_text_properties): Remove decl.
9502 (Fcomposition_get_gstring): New forward static decl.
9503 * composite.h (Fcomposite_get_gstring): Remove decl.
9504 * dired.c (Ffile_attributes): New forward static decl.
9505 * doc.c (Fdocumntation_property): New forward static decl.
9506 * eval.c (Ffetch_bytecode): New forward static decl.
9507 (Funintern): Remove extern decl; now in .h file where it belongs.
9508 * fileio.c (Fmake_symbolic_link): New forward static decl.
9509 * image.c (Finit_image_library): New forward static decl.
9510 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9511 * intervals.h (Fprevious_property_change):
9512 (Fremove_list_of_text_properties): Remove decls.
9513 * keyboard.c (Fthis_command_keys): Remove decl.
9514 (Fcommand_execute): New forward static decl.
9515 * keymap.c (Flookup_key): New forward static decl.
9516 (Fcopy_keymap): Now static.
9517 * keymap.h (Flookup_key): Remove decl.
9518 * process.c (Fget_process): New forward static decl.
9519 (Fprocess_datagram_address): Mark as internal.
9520 * syntax.c (Fsyntax_table_p): New forward static decl.
9521 (skip_chars): Remove duplicate decl.
9522 * textprop.c (Fprevious_property_change): New forward static decl.
9523 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9525 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9526 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9528 * editfns.c (Fformat): Remove unreachable code.
9530 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9532 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9535 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9537 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9538 when at ZV. (Bug#8487)
9540 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9542 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9544 * keyboard.c (parse_tool_bar_item): Likewise.
9545 * sound.c (sound_cleanup, alsa_close): Likewise.
9546 * termcap.c (tgetent): Likewise.
9547 * xfns.c (x_default_font_parameter): Likewise.
9548 * xsettings.c (read_and_apply_settings): Likewise.
9550 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9551 (overrun_check_free): Protoize.
9553 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9555 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9556 since callers should never pass a negative size.
9557 Change the signature to match that of plain 'read' and 'write'; see
9558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9559 * lisp.h: Update prototypes of emacs_write and emacs_read.
9561 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9563 * xdisp.c (redisplay_window): Don't try to determine the character
9564 position of the scroll margin if the window start point w->startp
9565 is outside the buffer's accessible region. (Bug#8468)
9567 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9569 Fix write-region and its subroutines for buffers > 2GB.
9570 * fileio.c (a_write, e_write): Modify declaration of arguments and
9571 local variables to support buffers larger than 2GB.
9572 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9574 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9575 argument, local variables, and return value.
9577 * lisp.h: Update prototypes of emacs_write and emacs_read.
9579 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9581 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9583 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9585 Fix more problems found by GCC 4.6.0's static checks.
9587 * xdisp.c (vmessage): Use a better test for character truncation.
9589 * charset.c (load_charset_map): <, not <=, for optimization,
9590 and to avoid potential problems with integer overflow.
9591 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9592 * casetab.c (set_identity, shuffle): Likewise.
9593 * editfns.c (Fformat): Likewise.
9594 * syntax.c (skip_chars): Likewise.
9596 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9597 This also lets GCC 4.6.0 generate slightly better loop code.
9599 * callint.c (Fcall_interactively): <, not <=, for optimization.
9600 (Fcall_interactively): Count the number of arguments produced,
9601 not the number of arguments given. This is simpler and lets GCC
9602 4.6.0 generate slightly better code.
9604 * ftfont.c: Distingish more carefully between FcChar8 and char.
9605 The previous code passed unsigned char * to a functions like
9606 strlen and xstrcasecmp that expect char *, which does not
9607 conform to the C standard.
9608 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9609 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9610 char * when the C standard requires it.
9612 * keyboard.c (read_char): Remove unused var.
9614 * eval.c: Port to Windows vsnprintf (Bug#8435).
9616 (SIZE_MAX): Define if the headers do not.
9617 (verror): Do not give up if vsnprintf returns a negative count.
9618 Instead, grow the buffer. This ports to Windows vsnprintf, which
9619 does not conform to C99. Problem reported by Eli Zaretskii.
9620 Also, simplify the allocation scheme, by avoiding the need for
9621 calling realloc, and removing the ALLOCATED variable.
9623 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9625 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9626 But keep the doprint source code for now, as we might revamp it
9627 and use it again (Bug#8435).
9628 * lisp.h (doprnt): Remove.
9629 * Makefile.in (base_obj): Remove doprnt.o.
9630 * deps.mk (doprnt.o): Remove.
9632 error: Print 32- and 64-bit integers portably (Bug#8435).
9633 Without this change, on typical 64-bit hosts error ("...%d...", N)
9634 was used to print both 32- and 64-bit integers N, which relied on
9636 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9637 * lisp.h (error, verror): Mark as printf-like functions.
9638 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9639 Report overflow in size calculations when allocating printf buffer.
9640 Do not truncate output string at its first null byte.
9641 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9642 Truncate the output at a character boundary, since vsnprintf does not
9644 * charset.c (check_iso_charset_parameter): Convert internal
9645 character to string before calling 'error', since %c now has the
9647 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9648 overflow when computing char to be passed to 'error'. Do not
9649 pass Lisp_Object to 'error'; pass the integer instead.
9650 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9651 formatted with plain %d.
9653 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9655 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9657 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9659 * xterm.c (x_catch_errors): Remove duplicate declaration.
9661 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9663 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9665 2011-04-10 Jim Meyering <meyering@redhat.com>
9667 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9668 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9669 return ssize_t not "int", and use size_t as the buffer length.
9670 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9671 * gnutls.h: Update declarations.
9672 * process.c (read_process_output): Use ssize_t, to match.
9673 (send_process): Likewise.
9675 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9677 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9679 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9681 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9682 Use unsigned char, to match FcChar8 type definition.
9684 * xterm.c (handle_one_xevent):
9685 * xmenu.c (create_and_show_popup_menu):
9686 * xselect.c (x_decline_selection_request)
9687 (x_reply_selection_request): Avoid type-punned deref of X events.
9689 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9691 Fix some uses of `int' instead of EMACS_INT.
9692 * search.c (string_match_1, fast_string_match)
9693 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9694 (scan_buffer, find_next_newline_no_quit)
9695 (find_before_next_newline, search_command, Freplace_match)
9696 (Fmatch_data): Make some `int' variables be EMACS_INT.
9698 * xdisp.c (display_count_lines): 3rd argument and return value now
9699 EMACS_INT. All callers changed.
9700 (pint2hrstr): Last argument is now EMACS_INT.
9702 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9703 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9704 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9705 (decode_coding_utf_16, decode_coding_emacs_mule)
9706 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9707 (decode_coding_ccl, decode_coding_charset)
9708 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9709 (decode_coding_iso_2022, decode_coding_emacs_mule)
9710 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9711 <char_offset, last_offset>: Declare EMACS_INT.
9712 (encode_coding_utf_8, encode_coding_utf_16)
9713 (encode_coding_emacs_mule, encode_invocation_designation)
9714 (encode_designation_at_bol, encode_coding_iso_2022)
9715 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9716 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9718 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9719 (encode_invocation_designation): Last argument P_NCHARS is now
9721 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9722 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9724 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9727 * ccl.c (Fccl_execute_on_string): Declare some variables
9730 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9732 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9734 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9736 * process.c (Fformat_network_address): Doc fix.
9738 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9740 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9742 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9744 * keyboard.c (read_char): Call Lisp function help-form-show,
9745 instead of using internal_with_output_to_temp_buffer.
9746 (Qhelp_form_show): New var.
9747 (syms_of_keyboard): Use DEFSYM macro.
9749 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9751 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9753 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9755 * process.c (Flist_processes): Remove to Lisp.
9756 (list_processes_1): Delete.
9758 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9760 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9762 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9764 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9766 Fix more problems found by GCC 4.6.0's static checks.
9768 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9770 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9772 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9774 * xdisp.c (vmessage): Mark as a printf-like function.
9776 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9778 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9780 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9781 printf-like functions.
9782 (tiff_load): Add casts to remove these marks before passing them
9783 to system-supplied API.
9785 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9787 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9788 This avoids several warnings with gcc -Wstrict-overflow.
9789 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9790 directly, rather than having caller test rule sign. This avoids
9791 some unnecessary tests.
9792 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9793 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9794 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9796 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9797 (xfont_open): Avoid unnecessary tests.
9799 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9801 * composite.h, composite.c (composition_gstring_put_cache):
9802 Use EMACS_INT, not int, for length.
9804 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9805 breaking out part of COMPOSITION_DECODE_RULE.
9806 (COMPOSITION_DECODE_RULE): Use it.
9807 * composite.c (get_composition_id): Remove unused local vars,
9808 by using the new macro.
9810 * textprop.c (set_text_properties_1): Change while to do-while,
9811 since the condition is always true at first.
9813 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9814 (interval_deletion_adjustment): Return unsigned value.
9817 * process.c (list_processes_1, create_pty, read_process_output):
9818 (exec_sentinel): Remove vars that were set but not used.
9819 (create_pty): Remove unnecessary "volatile"s.
9820 (Fnetwork_interface_info): Avoid possibility of int overflow.
9821 (read_process_output): Do adaptive read buffering even if carryover.
9822 (read_process_output): Simplify nbytes computation if buffered.
9824 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9826 * syntax.c (scan_words): Remove var that was set but not used.
9827 (update_syntax_table): Use unsigned instead of int.
9829 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9830 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9831 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9833 * print.c (print_error_message): Avoid int overflow.
9835 * font.c (font_list_entities): Redo for clarity,
9836 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9838 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9839 (font_score): Avoid potential overflow in diff calculation.
9841 * fns.c (substring_both): Remove var that is set but not used.
9842 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9844 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9846 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9847 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9848 can always succeed if overflow has undefined behavior.
9850 * search.c (boyer_moore, wordify): Remove vars set but not used.
9851 (wordify): Omit three unnecessary tests.
9853 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9854 All callers changed. This avoids the need for an unused var.
9856 * casefiddle.c (casify_region): Remove var that is set but not used.
9858 * dired.c (file_name_completion): Remove var that is set but not used.
9860 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9862 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9863 (Finsert_file_contents): Remove unnecessary code checking fd.
9865 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9866 Check for integer overflow on size calculations.
9868 * buffer.c (Fprevious_overlay_change): Remove var that is set
9871 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9872 Remove vars that are set but not used.
9873 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9874 (timer_check_2): Mark vars as initialized.
9876 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9878 * image.c (lookup_image): Remove var that is set but not used.
9879 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9881 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9882 that are set but not used.
9884 * xfns.c (make_invisible_cursor): Don't return garbage
9885 if XCreateBitmapFromData fails (Bug#8410).
9887 * xselect.c (x_get_local_selection, x_handle_property_notify):
9888 Remove vars that are set but not used.
9890 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9891 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9893 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9894 Remove var that is set but not used.
9895 (scroll_bar_windows_size): Now size_t, not int.
9896 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9899 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9900 (map_tty_color) [!defined MSDOS]: Likewise.
9902 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9904 * coding.c: Remove vars that are set but not used.
9905 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9906 All callers changed.
9907 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9908 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9909 (decode_coding_charset): Remove vars that are set but not used.
9911 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9912 that is set but not used.
9914 * print.c (print_object): Remove var that is set but not used.
9916 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9917 The gnulib version avoids calling malloc in the usual case,
9918 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9919 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9920 * filelock.c (current_lock_owner): Likewise.
9921 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9922 * sysdep.c: Include allocator.h, careadlinkat.h.
9923 (emacs_no_realloc_allocator): New static constant.
9924 (emacs_readlink): New function.
9925 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9926 ../lib/careadlinkat.h.
9928 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9930 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9931 first non-nil return value).
9933 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9935 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9936 if not defined (Bug#8403).
9938 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9940 * xdisp.c (display_count_lines): Remove parameter `start',
9941 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9942 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9943 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9944 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9945 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9946 and thereabouts. All callers changed.
9947 (get_per_char_metric): Remove parameter `f', unused since
9948 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9950 2011-04-02 Jim Meyering <meyering@redhat.com>
9952 do not dereference NULL upon failed strdup
9953 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9954 (ns_get_family): Likewise.
9956 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9958 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9960 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9962 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9965 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9967 Add lexical binding.
9969 * window.c (Ftemp_output_buffer_show): New fun.
9970 (Fsave_window_excursion):
9971 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9973 * lread.c (lisp_file_lexically_bound_p): New function.
9974 (Fload): Bind Qlexical_binding.
9975 (readevalloop): Remove `evalfun' arg.
9976 Bind Qinternal_interpreter_environment.
9977 (Feval_buffer): Bind Qlexical_binding.
9978 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9980 (syms_of_lread): Declare `lexical-binding'.
9982 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9984 * keyboard.c (eval_dyn): New fun.
9985 (menu_item_eval_property): Use it.
9987 * image.c (parse_image_spec): Use Ffunctionp.
9989 * fns.c (concat, mapcar1): Accept byte-code-functions.
9991 * eval.c (Fsetq): Handle lexical vars.
9992 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9993 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9994 (FletX, Flet): Obey lexical binding.
9995 (Fcommandp): Handle closures.
9996 (Feval): New `lexical' arg.
9997 (eval_sub): New function extracted from Feval. Use it almost
9998 everywhere where Feval was used. Look up vars in lexical env.
10000 (Ffunctionp): Move from subr.el.
10001 (Ffuncall): Handle closures.
10002 (apply_lambda): Remove `eval_flags'.
10003 (funcall_lambda): Handle closures and new byte-code-functions.
10004 (Fspecial_variable_p): New function.
10005 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10006 but without exporting it to Lisp.
10008 * doc.c (Fdocumentation, store_function_docstring):
10009 * data.c (Finteractive_form): Handle closures.
10011 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10014 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10016 (exec_byte_code): New function extracted from Fbyte_code to handle new
10017 calling convention for byte-code-functions. Add new byte-codes.
10019 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10021 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10023 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10025 * xdisp.c (redisplay_internal): Fix prototype.
10027 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10029 * xdisp.c (SCROLL_LIMIT): New macro.
10030 (try_scrolling): Use it when setting scroll_limit.
10031 Limit scrolling to 100 screen lines.
10032 (redisplay_window): Even when falling back on "recentering",
10033 position point in the window according to scroll-conservatively,
10034 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10036 (try_scrolling): When point is above the window, allow searching
10037 as far as scroll_max, or one screenful, to compute vertical
10038 distance from PT to the scroll margin position. This prevents
10039 try_scrolling from unnecessarily failing when
10040 scroll-conservatively is set to a value slightly larger than the
10041 window height. Clean up the case of PT below the margin at bottom
10042 of window: scroll_max can no longer be INT_MAX. When aggressive
10043 scrolling is in use, don't let point enter the opposite scroll
10044 margin as result of the scroll.
10045 (syms_of_xdisp) <scroll-conservatively>: Document the
10046 threshold of 100 lines for never-recentering scrolling.
10048 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10050 * dispextern.h (move_it_by_lines):
10051 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10052 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10053 (message_log_check_duplicate): Remove parameters `prev_bol' and
10054 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10055 (redisplay_internal): Remove parameter `preserve_echo_area',
10056 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10058 * indent.c (Fvertical_motion):
10059 * window.c (window_scroll_pixel_based, Frecenter):
10060 Don't pass `need_y_p' to `move_it_by_lines'.
10062 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10064 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10065 steal a few bits to be more compact.
10066 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10067 Remove unneeded casts.
10069 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10071 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10073 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10074 binding" message (bug#7967).
10076 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10078 Fix more problems found by GCC 4.6.0's static checks.
10080 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10081 Remove unused local var.
10083 * editfns.c (Fmessage_box): Remove unused local var.
10085 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10086 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10087 Omit unused local vars.
10088 * window.c (shrink_windows): Omit unused local var.
10089 * menu.c (digest_single_submenu): Omit unused local var.
10090 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10091 Omit unused local var.
10093 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10094 Don't assume string length fits in int.
10095 (keyremap_step, read_key_sequence): Use size_t for sizes.
10096 (read_key_sequence): Don't check last_real_key_start redundantly.
10098 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10099 instead of alloca (Bug#8344).
10101 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10102 (Fbacktrace_frame): Don't assume nframes fits in int.
10104 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10106 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10109 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10111 * cm.c (calccost): Turn while-do into do-while, for clarity.
10113 * keyboard.c (syms_of_keyboard): Use the same style as later
10114 in this function when indexing through an array. This also
10115 works around GCC bug 48267.
10117 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10119 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10121 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10122 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10124 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10125 This avoids undefined behavior on integer overflow, and is a bit
10126 more convenient anyway since it is compared to a size_t variable.
10128 Variadic C functions now count arguments with size_t, not int.
10129 This avoids an unnecessary limitation on 64-bit machines, which
10130 caused (substring ...) to crash on large vectors (Bug#8344).
10131 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10132 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10133 All variadic functions and their callers changed accordingly.
10134 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10135 * data.c (arith_driver, float_arith_driver): Likewise.
10136 * editfns.c (general_insert_function): Likewise.
10137 * eval.c (struct backtrace.nargs, interactive_p)
10138 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10139 (funcall_lambda, mark_backtrace): Likewise.
10140 * fns.c (concat): Likewise.
10141 * frame.c (x_set_frame_parameters): Likewise.
10142 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10143 0 if not found, not -1. All callers changed.
10145 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10146 (stack_copy_size): Now size_t, not int.
10147 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10149 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10151 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10152 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10153 All callers changed.
10155 * lisp.h (multibyte_char_to_unibyte):
10156 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10157 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10158 * character.h (CHAR_TO_BYTE8):
10159 * cmds.c (internal_self_insert):
10160 * editfns.c (general_insert_function):
10161 * keymap.c (push_key_description):
10162 * search.c (Freplace_match):
10163 * xdisp.c (message_dolog, set_message_1): All callers changed.
10165 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10167 * keyboard.c (safe_run_hook_funcall): New function.
10168 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10169 don't set the hook to nil, but remove the offending function instead.
10170 (Qcommand_hook_internal): Remove, unused.
10171 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10172 Vcommand_hook_internal.
10174 * eval.c (enum run_hooks_condition): Remove.
10175 (funcall_nil, funcall_not): New functions.
10176 (run_hook_with_args): Call each function through a `funcall' argument.
10177 Remove `cond' argument, now redundant.
10178 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10179 (Frun_hook_with_args_until_failure): Adjust accordingly.
10180 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10182 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10184 * dispextern.h (string_buffer_position): Remove declaration.
10186 * print.c (strout): Remove parameter `multibyte', unused since
10187 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10189 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10190 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10191 All callers changed.
10193 * w32.c (_wsa_errlist): Use braces for struct initializers.
10195 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10196 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10197 All callers changed.
10198 (string_buffer_position): Likewise. Also, make static (it's never
10199 used outside xdisp.c).
10200 (cursor_row_p): Remove parameter `w', unused since
10201 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10202 (decode_mode_spec): Remove parameter `precision', introduced during
10203 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10204 All callers changed.
10206 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10208 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10210 2011-03-27 Anders Lindgren <andlind@gmail.com>
10212 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10213 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10214 (ns_update_auto_hide_menu_bar): New functions.
10215 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10216 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10217 ns_constrain_all_frames.
10218 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10219 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10221 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10223 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10225 2011-03-27 Glenn Morris <rgm@gnu.org>
10227 * syssignal.h: Replace RETSIGTYPE with void.
10228 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10229 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10230 Replace SIGTYPE with void everywhere.
10231 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10232 * s/template.h (SIGTYPE): Remove commented out definition.
10234 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10236 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10237 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10239 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10241 * w32.c (read_unc_volume): Use parameter `henum', instead of
10242 global variable `wget_enum_handle'.
10244 * keymap.c (describe_vector): Remove parameters `indices' and
10245 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10246 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10248 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10250 * keyboard.c (timer_check): Remove parameter `do_it_now',
10251 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10252 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10253 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10255 * keyboard.c (read_char):
10256 * w32menu.c (w32_menu_display_help):
10257 * xmenu.c (show_help_event, menu_help_callback):
10258 Adjust calls to `show_help_echo'.
10260 * gtkutil.c (xg_maybe_add_timer):
10261 * keyboard.c (readable_events):
10262 * process.c (wait_reading_process_output):
10263 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10265 * insdel.c (adjust_markers_gap_motion):
10266 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10267 (gap_left, gap_right): Don't call it.
10269 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10271 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10272 incurred during fontification.
10274 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10276 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10277 (DEFVAR_PER_BUFFER): Don't pass it.
10279 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10280 (scrolling_window): Don't pass it.
10282 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10284 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10286 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10288 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10289 of variables specific to SELinux and computation of `encoded_absname'.
10291 * image.c (XPutPixel): Remove unused variable `height'.
10293 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10295 * unexw32.c (get_section_info): Remove unused variable `section'.
10297 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10298 (system_process_attributes): Remove unused variable `sess'.
10299 (sys_read): Remove unused variable `err'.
10301 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10302 (w32_wnd_proc): Remove unused variable `isdead'.
10303 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10304 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10305 (x_create_tip_frame): Remove unused variable `tem'.
10307 * w32inevt.c (w32_console_read_socket):
10308 Remove unused variable `no_events'.
10310 * w32term.c (x_draw_composite_glyph_string_foreground):
10311 Remove unused variable `width'.
10313 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10315 * w32term.c (x_set_glyph_string_clipping):
10316 Don't pass uninitialized region to CombineRgn.
10318 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10320 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10321 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10322 (Fx_close_connection): Remove unused variable `i'.
10324 * w32font.c (w32font_draw): Return number of glyphs.
10325 (w32font_open_internal): Remove unused variable `i'.
10326 (w32font_driver): Add missing initializer.
10328 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10329 (fill_in_menu): Remove unused variable `items_added'.
10331 * w32term.c (last_mouse_press_frame): Remove static global variable.
10332 (w32_clip_to_row): Remove unused variable `f'.
10333 (x_delete_terminal): Remove unused variable `i'.
10335 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10336 (NOTHING): Remove unused static global variable.
10337 (uniscribe_check_otf): Remove unused variable `table'.
10338 (uniscribe_font_driver): Add missing initializers.
10340 2011-03-23 Julien Danjou <julien@danjou.info>
10342 * term.c (Fsuspend_tty, Fresume_tty):
10343 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10344 * window.c (temp_output_buffer_show):
10345 * insdel.c (signal_before_change):
10346 * frame.c (Fhandle_switch_frame):
10347 * fileio.c (Fdo_auto_save):
10348 * emacs.c (Fkill_emacs):
10349 * editfns.c (save_excursion_restore):
10350 * cmds.c (internal_self_insert):
10351 * callint.c (Fcall_interactively):
10352 * buffer.c (Fkill_all_local_variables):
10353 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10355 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10356 unconditionally since it does the check itself.
10358 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10360 Fix more problems found by GCC 4.5.2's static checks.
10362 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10363 the first time through the loop, since we know p0 < p1 then.
10364 This also avoids a gcc -Wstrict-overflow warning.
10366 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10367 leading to a memory leak, possible in functions like
10368 load_charset_map_from_file that can allocate an unbounded number
10369 of objects (Bug#8318).
10371 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10372 that could (at least in theory) be that large.
10374 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10375 This is less likely to overflow, and avoids undefined behavior if
10376 overflow does occur. All callers changed. Use strtoul to scan
10377 for the unsigned long integer.
10378 (pint2hrstr): Simplify and tune code slightly.
10379 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10381 * scroll.c (do_scrolling): Work around GCC bug 48228.
10382 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10384 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10385 This also avoids a warning with gcc -Wstrict-overflow.
10386 (validate_x_resource_name): Simplify count usage.
10387 This also avoids a warning with gcc -Wstrict-overflow.
10389 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10392 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10394 * process.c (Fmake_network_process): Use socklen_t, not int,
10395 where POSIX says socklen_t is required in portable programs.
10396 This fixes a porting bug on hosts like 64-bit HP-UX, where
10397 socklen_t is wider than int (Bug#8277).
10398 (Fmake_network_process, server_accept_connection):
10399 (wait_reading_process_output, read_process_output):
10402 * process.c: Rename or move locals to avoid shadowing.
10403 (list_processes_1, Fmake_network_process):
10404 (read_process_output_error_handler, exec_sentinel_error_handler):
10405 Rename or move locals.
10406 (Fmake_network_process): Define label "retry_connect" only if needed.
10407 (Fnetwork_interface_info): Fix pointer signedness.
10408 (process_send_signal): Add cast to avoid pointer signedness problem.
10409 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10410 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10412 Make tparam.h and terminfo.c consistent.
10413 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10414 Include tparam.h instead, since it declares them.
10415 * cm.h (PC): Remove extern decl; tparam.h now does this.
10416 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10417 * terminfo.c: Include tparam.h, to check interfaces.
10418 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10419 (tparam): Adjust signature to match interface in tparam.h;
10420 this removes some undefined behavior. Check that outstring and len
10421 are zero, which they always are with Emacs.
10422 * tparam.h (PC, BC, UP): New extern decls.
10424 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10425 (xftfont_open): Rename locals to avoid shadowing.
10427 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10428 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10429 (OTF_TAG_SYM): Omit macro if not needed.
10430 (ftfont_list): Remove unused local.
10431 (get_adstyle_property, ftfont_pattern_entity):
10432 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10433 Rename locals to avoid shadowing.
10435 * xfont.c (xfont_list_family): Mark var as initialized.
10437 * xml.c (make_dom): Now static.
10439 * composite.c (composition_compute_stop_pos): Rename local to
10441 (composition_reseat_it): Remove unused locals.
10442 (find_automatic_composition, composition_adjust_point): Likewise.
10443 (composition_update_it): Mark var as initialized.
10444 (find_automatic_composition): Mark vars as initialized,
10445 with a FIXME (Bug#8290).
10447 character.h: Rename locals to avoid shadowing.
10448 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10449 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10450 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10451 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10452 to avoid shadowing.
10454 * textprop.c (property_change_between_p): Remove; unused.
10456 * intervals.c (interval_start_pos): Now static.
10458 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10460 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10461 Rename locals to avoid shadowing.
10463 * sound.c (wav_play, au_play, Fplay_sound_internal):
10464 Fix pointer signedness.
10465 (alsa_choose_format): Remove unused local var.
10466 (wav_play): Initialize a variable to 0, to prevent undefined
10467 behavior (Bug#8278).
10469 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10471 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10473 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10474 clobbering (Bug#8298).
10475 * sysdep.c (sys_subshell): Likewise.
10476 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10478 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10479 This should get cleaned up, so that child_setup has the
10480 same signature on all platforms.
10482 * callproc.c (call_process_cleanup): Now static.
10483 (relocate_fd): Rename locals to avoid shadowing.
10485 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10487 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10488 not to be necessary, and produces flickering.
10490 2011-03-20 Glenn Morris <rgm@gnu.org>
10492 * config.in: Remove file.
10494 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10496 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10497 are now in src/globals.h.
10498 (syms_of_minibuf): Remove spurious & from previous change.
10500 2011-03-20 Leo Liu <sdl.web@gmail.com>
10502 * minibuf.c (completing-read-function): New variable.
10503 (completing-read-default): Rename from completing-read.
10504 (completing-read): Call completing-read-function.
10506 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10508 * xfaces.c (Fx_load_color_file):
10509 Read color file from absolute filename (bug#8250).
10511 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10513 * makefile.w32-in: Update dependencies.
10515 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10517 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10519 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10521 Fix more problems found by GCC 4.5.2's static checks.
10523 * process.c (make_serial_process_unwind, send_process_trap):
10524 (sigchld_handler): Now static.
10526 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10527 That way, the code declares only the vars that it needs.
10528 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10529 * s/cygwin.h (PTY_ITERATION): Likewise.
10530 * s/darwin.h (PTY_ITERATION): Likewise.
10531 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10533 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10534 * process.c (allocate_pty): Don't declare stb unless it's needed.
10536 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10537 (CONSTANTLIM): Remove; unused.
10538 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10539 Define only if needed.
10541 * unexelf.c (unexec): Name an expression,
10542 to avoid gcc -Wbad-function-cast warning.
10543 Use a different way to cause a compilation error if anyone uses
10544 n rather than nn, a way that does not involve shadowing.
10545 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10547 * deps.mk (unexalpha.o): Remove; unused.
10549 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10550 * unexec.h: New file.
10551 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10552 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10553 Depend on unexec.h.
10554 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10555 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10556 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10557 Change as necessary to match prototype in unexec.h.
10559 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10561 (back_comment, skip_chars): Mark vars as initialized.
10563 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10564 Rename locals to avoid shadowing.
10566 * lread.c (read1): Rewrite so as not to use empty "else".
10567 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10569 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10571 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10572 warning when compiling print.c.
10574 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10575 instead of using an uninitialized var.
10576 (font_sort_entities): Mark var as initialized.
10578 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10580 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10581 pointers to constants.
10582 (font_parse_fcname): Remove unused vars.
10583 (font_delete_unmatched): Now static.
10584 (font_get_spec): Remove; unused.
10585 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10586 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10587 Rename or move locals to avoid shadowing.
10589 * fns.c (require_nesting_list, require_unwind): Now static.
10590 (Ffillarray): Rename locals to avoid shadowing.
10592 * floatfns.c (domain_error2): Define only if needed.
10593 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10595 * alloc.c (mark_backtrace): Move decl from here ...
10596 * lisp.h: ... to here, so that it can be checked.
10598 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10599 (Fdefvar): Rewrite so as not to use empty "else".
10600 (lisp_indirect_variable): Name an expression,
10601 to avoid gcc -Wbad-function-cast warning.
10602 (Fdefvar): Rename locals to avoid shadowing.
10604 * callint.c (quotify_arg, quotify_args): Now static.
10605 (Fcall_interactively): Rename locals to avoid shadowing.
10606 Use const pointer when appropriate.
10608 * lisp.h (get_system_name, get_operating_system_release):
10609 Move decls here, to check interfaces.
10610 * process.c (get_operating_system_release): Move decl to lisp.h.
10611 * xrdb.c (get_system_name): Likewise.
10612 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10613 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10614 some of which prompt warnings from gcc -Wbad-function-cast.
10615 (Fformat_time_string, Fencode_time, Finsert_char):
10616 (Ftranslate_region_internal, Fformat):
10617 Rename or remove local vars to avoid shadowing.
10618 (Ftranslate_region_internal): Mark var as initialized.
10620 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10623 * lisp.h (eassert): Check that the argument compiles, even if
10624 ENABLE_CHECKING is not defined.
10626 * data.c (Findirect_variable): Name an expression, to avoid
10627 gcc -Wbad-function-cast warning.
10628 (default_value, arithcompare, arith_driver, arith_error): Now static.
10629 (store_symval_forwarding): Rename local to avoid shadowing.
10630 (Fmake_variable_buffer_local, Fmake_local_variable):
10631 Mark variables as initialized.
10632 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10634 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10635 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10636 Rename locals to avoid shadowing.
10637 (mark_stack): Move local variables into the #ifdef region where
10639 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10640 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10642 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10643 (GC_STRING_CHARS): Remove; not used.
10644 (Fmemory_limit): Cast sbrk's returned value to char *.
10646 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10647 avoids undefined behavior in theory.
10649 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10651 Use functions, not macros, for up- and down-casing (Bug#8254).
10652 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10653 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10654 to use the following functions instead of these macros.
10655 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10656 EMACS_INT, since callers assume the returned value fits in int.
10657 (upcase1): Likewise, for UPCASE_TABLE.
10658 (uppercasep, lowercasep, upcase): New static inline functions.
10659 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10660 the race-condition problem in the old DOWNCASE.
10662 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10663 Rename locals to avoid shadowing.
10664 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10665 (regex_compile, re_search_2, re_match_2_internal):
10666 Remove unused local vars.
10667 (FREE_VAR): Rewrite so as not to use empty "else",
10668 which gcc can warn about.
10669 (regex_compile, re_match_2_internal): Mark locals as initialized.
10670 (RETALLOC_IF): Define only if needed.
10671 (WORDCHAR_P): Likewise. This one is never needed, but is used
10672 only in a comment talking about a compiler bug, so put inside
10673 the #if 0 of that comment.
10674 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10675 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10678 * search.c (boyer_moore): Rename locals to avoid shadowing.
10679 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10680 (PREV_CHAR_BOUNDARY): Likewise.
10682 * search.c (simple_search): Remove unused var.
10684 * dired.c (compile_pattern): Move decl from here ...
10685 * lisp.h: ... to here, so that it can be checked.
10686 (struct re_registers): New forward decl.
10688 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10690 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10692 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10693 Rename locals to avoid shadowing.
10694 (Fvertical_motion): Mark locals as initialized.
10696 * casefiddle.c (casify_object, casify_region): Now static.
10697 (casify_region): Mark local as initialized.
10699 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10701 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10702 New macros, so that the caller can use some names other than
10703 gcpro1, gcpro2, etc.
10704 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10706 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10707 argument, for consistency with GCPRO2_VAR, etc: it is now the
10708 prefix of the variable, not the variable itself. All uses
10710 * dired.c (directory_files_internal, file_name_completion):
10711 Rename locals to avoid shadowing.
10713 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10714 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10715 dired.c's scmp function, had undefined behavior.
10716 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10717 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10718 * buffer.h: ... to here, because these macros use current_buffer,
10719 and the new implementation with inline functions needs to have
10720 current_buffer in scope now, rather than later when the macros
10722 (downcase, upcase1): New static inline functions.
10723 (DOWNCASE, UPCASE1): Reimplement using these functions.
10724 This avoids undefined behavior in expressions like
10725 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10726 from race conditions in accessing the global variables
10727 case_temp1 and case_temp2.
10728 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10729 * lisp.h (case_temp1, case_temp2): Remove their decls.
10730 * character.h (ASCII_CHAR_P): Move from here ...
10731 * lisp.h: ... to here, so that the inline functions mentioned
10732 above can use them.
10734 * dired.c (directory_files_internal_unwind): Now static.
10736 * fileio.c (file_name_as_directory, directory_file_name):
10737 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10739 (file_name_as_directory): Use const pointers when appropriate.
10740 (Fexpand_file_name): Likewise. In particular, newdir might
10741 point at constant storage, so make it a const pointer.
10742 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10743 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10745 (Fset_file_times, Finsert_file_contents, auto_save_error):
10746 Rename locals to avoid shadowing.
10748 * minibuf.c (choose_minibuf_frame_1): Now static.
10749 (Ftry_completion, Fall_completions): Rename or remove locals
10750 to avoid shadowing.
10752 * marker.c (bytepos_to_charpos): Remove; unused.
10754 * lisp.h (verify_bytepos, count_markers): New decls,
10755 so that gcc does not warn that these functions aren't declared.
10757 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10758 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10759 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10760 (copy_text): Remove unused local var.
10762 * filelock.c (within_one_second): Now static.
10763 (lock_file_1): Rename local to avoid shadowing.
10765 * buffer.c (fix_overlays_before): Mark locals as initialized.
10766 (fix_start_end_in_overlays): Likewise. This function should be
10767 simplified by using pointers-to-pointers, but that's a different
10769 (switch_to_buffer_1): Now static.
10770 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10771 (report_overlay_modification): Rename locals to avoid shadowing.
10773 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10774 Fix pointer signedness issue.
10775 (sys_subshell): Mark local as volatile if checking for lint,
10776 to suppress a gcc -Wclobbered warning that does not seem to be right.
10777 (MAXPATHLEN): Define only if needed.
10779 * process.c (serial_open, serial_configure): Move decls from here ...
10780 * systty.h: ... to here, so that they can be checked.
10782 * fns.c (get_random, seed_random): Move extern decls from here ...
10783 * lisp.h: ... to here, so that they can be checked.
10785 * sysdep.c (reset_io): Now static.
10786 (wait_for_termination_signal): Remove; unused.
10788 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10789 (copy_keymap_item, append_key, push_text_char_description):
10791 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10792 (DENSE_TABLE_SIZE): Remove; unused.
10793 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10794 (describe_map_tree):
10795 Rename locals to avoid shadowing.
10797 * keyboard.c: Declare functions static if they are not used elsewhere.
10798 (echo_char, echo_dash, cmd_error, top_level_2):
10799 (poll_for_input, handle_async_input): Now static.
10800 (read_char, kbd_buffer_get_event, make_lispy_position):
10801 (make_lispy_event, make_lispy_movement, apply_modifiers):
10802 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10803 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10804 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10805 (read_key_sequence, read_char): Mark locals as initialized.
10806 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10808 * keyboard.h (make_ctrl_char): New decl.
10809 (mark_kboards): Move decl here ...
10810 * alloc.c (mark_kboards): ... from here.
10812 * lisp.h (force_auto_save_soon): New decl.
10814 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10815 (DEFINE_DUMMY_FUNCTION): New macro.
10816 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10818 (main): Add casts to avoid warnings
10819 if GCC considers string literals to be constants.
10821 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10823 * dbusbind.c: Pointer signedness fixes.
10824 (xd_signature, xd_append_arg, xd_initialize):
10825 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10826 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10827 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10828 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10830 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10831 if GCC considers string literals to be constants.
10832 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10834 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10836 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10837 (print_preprocess, print_object): New macro to fix last change.
10839 * print.c (print_preprocess): Don't forget font objects.
10841 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10843 * emacs.c (USAGE3): Doc fixes.
10845 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10847 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10850 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10852 * lisp.h (VWindow_system, Qfile_name_history):
10853 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10854 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10855 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10857 * w32select.c: Don't #include "keyboard.h".
10858 (run_protected): Add extern declaration for waiting_for_input.
10860 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10861 * w32console.c (detect_input_pending, read_input_pending)
10862 (encode_terminal_code):
10863 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10864 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10865 (w32_system_caret_y, Qfile_name_history):
10866 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10867 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10868 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10869 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10870 * w32proc.c (Qlocal, report_file_error):
10871 * w32term.c (Vwindow_system, updating_frame):
10872 * w32uniscribe.c (initialized, uniscribe_font_driver):
10873 Remove unneeded extern declarations.
10875 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10877 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10879 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10881 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10882 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10883 These macros can no longer be used for assignment.
10885 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10886 Assign struct members directly, instead of using BUF_BEGV etc.
10887 (record_buffer_markers, fetch_buffer_markers): New functions for
10888 recording and fetching special buffer markers.
10889 (set_buffer_internal_1, set_buffer_temp): Use them.
10891 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10893 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10895 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10896 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10898 * xdisp.c (hscroll_window_tree):
10899 (reconsider_clip_changes): Use PT instead of BUF_PT.
10901 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10903 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10904 $(EMACS_ROOT)/lib/intprops.h.
10906 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10908 Fix more problems found by GCC 4.5.2's static checks.
10910 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10911 to unsigned char * to avoid compiler diagnostic.
10912 (xg_free_frame_widgets): Make it clear that a local variable is
10913 needed only if USE_GTK_TOOLTIP.
10914 (gdk_window_get_screen): Make it clear that this macro is needed
10915 only if USE_GTK_TOOLTIP.
10916 (int_gtk_range_get_value): New function, which avoids a diagnostic
10917 from gcc -Wbad-function-cast.
10918 (xg_set_toolkit_scroll_bar_thumb): Use it.
10919 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10920 diagnostic from gcc -Wbad-function-cast.
10921 (get_utf8_string, xg_get_file_with_chooser):
10922 Rename locals to avoid shadowing.
10923 (create_dialog): Move locals to avoid shadowing.
10925 * xgselect.c (xg_select): Remove unused var.
10927 * image.c (four_corners_best): Mark locals as initialized.
10928 (gif_load): Initialize transparent_p to zero (Bug#8238).
10929 Mark another local as initialized.
10930 (my_png_error, my_error_exit): Mark with NO_RETURN.
10932 * image.c (clear_image_cache): Now static.
10933 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10934 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10935 (x_edge_detection): Remove unnecessary cast that
10936 gcc -Wbad-function-cast diagnoses.
10937 (gif_load): Fix pointer signedness.
10938 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10939 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10941 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10943 Improve quality of tests for time stamp overflow.
10944 For example, without this patch (encode-time 0 0 0 1 1
10945 1152921504606846976) returns the obviously-bogus value (-948597
10946 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10947 reports time overflow. See
10948 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10949 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10950 * editfns.c: Include limits.h and intprops.h.
10951 (TIME_T_MIN, TIME_T_MAX): New macros.
10952 (time_overflow): Move earlier, to before first use.
10953 (hi_time, lo_time): New functions, for an accurate test for
10954 out-of-range times.
10955 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10956 (Fget_internal_run_time): Don't assume time_t fits in int.
10957 (make_time): Use list2 instead of Fcons twice.
10958 (Fdecode_time): More accurate test for out-of-range times.
10959 (check_tm_member): New function.
10960 (Fencode_time): Use it, to test for out-of-range times.
10961 (lisp_time_argument): Don't rely on undefined left-shift and
10962 right-shift behavior when checking for time stamp overflow.
10964 * editfns.c (time_overflow): New function, refactoring common code.
10965 (Fformat_time_string, Fdecode_time, Fencode_time):
10966 (Fcurrent_time_string): Use it.
10968 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10969 * dired.c (make_time): Move to ...
10970 * editfns.c (make_time): ... here.
10971 * systime.h: Note the move.
10973 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10975 * fringe.c (update_window_fringes): Remove unused variables.
10977 * unexmacosx.c (copy_data_segment): Also copy __got section.
10980 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10982 * termcap.c [MSDOS]: Include "msdos.h".
10983 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10984 Constify `char *' arguments and their references according to
10985 prototypes in tparam.h.
10987 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10989 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10990 Adapt all references accordingly.
10992 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10994 2011-03-11 Tom Tromey <tromey@redhat.com>
10996 * buffer.c (syms_of_buffer): Remove obsolete comment.
10998 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11000 * termhooks.h (encode_terminal_code): Declare prototype.
11002 * msdos.c (encode_terminal_code): Don't declare prototype.
11004 * term.c (encode_terminal_code): Now external again, used by
11005 w32console.c and msdos.c.
11007 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11008 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11010 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11012 Fix some minor problems found by GCC 4.5.2's static checks.
11014 * fringe.c (update_window_fringes): Mark locals as initialized
11016 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11018 * alloc.c (mark_fringe_data): Move decl from here ...
11019 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11020 to check its interface.
11021 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11023 * fontset.c (free_realized_fontset): Now static.
11024 (Fset_fontset_font): Rename local to avoid shadowing.
11025 (fontset_font): Mark local as initialized.
11026 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11028 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11030 * xselect.c (x_disown_buffer_selections): Remove; not used.
11031 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11032 (x_own_selection, Fx_disown_selection_internal): Rename locals
11033 to avoid shadowing.
11034 (x_handle_dnd_message): Remove local to avoid shadowing.
11036 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11037 so that the caller can use some name other than gcpro1.
11038 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11039 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11040 (Fx_backspace_delete_keys_p):
11041 Use them to avoid shadowing, and rename vars to avoid shadowing.
11042 (x_decode_color, x_set_name, x_window): Now static.
11043 (Fx_create_frame): Add braces to silence GCC warning.
11044 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11045 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11046 Remove unused locals.
11047 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11048 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11049 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11052 * xterm.h (x_mouse_leave): New decl.
11054 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11055 Remove unused functions.
11056 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11057 (x_calc_absolute_position): Now static.
11058 (XTread_socket): Don't define label "out" unless it's used.
11059 Don't declare local "event" unless it's used.
11060 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11061 unless they are used.
11062 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11063 (x_fatal_error_signal): Remove; not used.
11064 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11065 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11066 (x_error_catcher, x_connection_closed, x_error_handler):
11067 (x_error_quitter, xembed_send_message, x_iconify_frame):
11068 (my_log_handler): Rename locals to avoid shadowing.
11069 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11070 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11072 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11073 Rename or move locals to avoid shadowing.
11074 (tty_defined_color, merge_face_heights): Now static.
11075 (free_realized_faces_for_fontset): Remove; not used.
11076 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11077 does not deduce is never used uninitialized.
11078 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11079 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11081 * terminal.c (store_terminal_param): Now static.
11083 * xmenu.c (menu_highlight_callback): Now static.
11084 (set_frame_menubar): Remove unused local.
11085 (xmenu_show): Rename parameter to avoid shadowing.
11086 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11087 since they might point to immutable storage.
11088 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11089 since it's unused otherwise.
11091 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11092 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11093 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11094 avoids a gcc -Wuninitialized diagnostic.
11095 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11096 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11097 does not deduce are never used uninitialized.
11099 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11101 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11102 * window.c (window_loop, size_window):
11103 (run_window_configuration_change_hook, enlarge_window): Likewise.
11105 * window.c (display_buffer): Now static.
11106 (size_window): Mark variables that gcc -Wuninitialized
11107 does not deduce are never used uninitialized.
11108 * window.h (check_all_windows): New decl, to forestall
11109 gcc -Wmissing-prototypes diagnostic.
11110 * dispextern.h (bidi_dump_cached_states): Likewise.
11112 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11114 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11115 Include <limits.h>.
11116 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11117 and to avoid gcc -Wuninitialized warning.
11118 (load_charset_map): Mark variables that gcc -Wuninitialized
11119 does not deduce are never used uninitialized.
11120 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11122 * coding.c (coding_set_source, coding_set_destination):
11123 Use "else { /* comment */ }" rather than "else /* comment */;"
11124 for clarity, and to avoid gcc -Wempty-body warning.
11125 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11126 a block, when the outer 'i' will do.
11127 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11128 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11129 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11130 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11131 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11132 Rename locals to avoid shadowing.
11133 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11134 * coding.c (emacs_mule_char, encode_invocation_designation):
11135 Now static, since they're not used elsewhere.
11136 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11137 (decode_coding_object, encode_coding_object, detect_coding_system):
11138 (decode_coding_emacs_mule): Mark variables that gcc
11139 -Wuninitialized does not deduce are never used uninitialized.
11140 (detect_coding_iso_2022): Initialize a local variable that might
11141 be used uninitialized. Leave a FIXME because it's not clear that
11142 this initialization is needed. (Bug#8211)
11143 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11144 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11145 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11146 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11147 Remove unused macros.
11149 * category.c (hash_get_category_set): Remove unused local var.
11150 (copy_category_table): Now static, since it's not used elsewhere.
11151 * character.c (string_count_byte8): Likewise.
11153 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11154 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11156 * chartab.c (copy_sub_char_table): Now static, since it's not used
11158 (sub_char_table_ref_and_range, char_table_ref_and_range):
11159 Rename locals to avoid shadowing.
11160 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11162 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11163 (BIDI_BOB): Remove unused macro.
11165 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11166 deduce are never used uninitialized.
11167 * term.c (encode_terminal_code): Likewise.
11169 * term.c (encode_terminal_code): Now static. Remove unused local.
11171 * tparam.h: New file.
11172 * term.c, tparam.h: Include it.
11173 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11174 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11175 Move these decls to tparam.h, and make them agree with what
11176 is actually in tparam.c. The previous trick of using incompatible
11177 decls in different modules does not conform to the C standard.
11178 All callers of tparam changed to use tparam's actual API.
11179 * tparam.c (tparam1, tparam, tgoto):
11180 Use const pointers where appropriate.
11182 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11183 * cm.h (struct cm): Likewise.
11184 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11185 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11186 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11187 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11188 (turn_on_face, init_tty): Likewise.
11189 * termchar.h (struct tty_display_info): Likewise.
11191 * term.c (term_mouse_position): Rename local to avoid shadowing.
11193 * alloc.c (mark_ttys): Move decl from here ...
11194 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11196 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11198 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11200 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11202 * search.c (compile_pattern_1): Remove argument regp, unused since
11203 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11204 (compile_pattern): Don't pass it.
11206 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11208 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11209 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11211 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11213 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11215 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11216 gdk_window_get_screen, gdk_window_get_geometry,
11217 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11218 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11219 (xg_get_pixbuf_from_pixmap): New function.
11220 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11221 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11222 Call xg_get_pixbuf_from_pixmap instead of
11223 gdk_pixbuf_get_from_drawable.
11224 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11225 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11226 (xg_check_special_colors): Use GtkStyleContext and its functions
11228 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11229 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11230 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11231 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11232 Call gtk_widget_get_preferred_size.
11233 (xg_frame_resized): gdk_window_get_geometry only takes 5
11235 (xg_win_to_widget, xg_event_is_for_menubar):
11236 Call gdk_x11_window_lookup_for_display.
11237 (xg_set_widget_bg): New function.
11238 (delete_cb): New function.
11239 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11240 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11241 (xg_set_background_color): Call xg_set_widget_bg.
11242 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11243 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11244 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11245 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11247 (update_frame_tool_bar): Call gtk_widget_hide.
11248 (xg_initialize): Use GDK_KEY_g.
11250 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11252 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11254 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11255 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11256 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11258 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11260 * w32xfns.c (select_palette): Check success of RealizePalette against
11261 GDI_ERROR, not zero.
11263 See ChangeLog.11 for earlier changes.
11265 ;; Local Variables:
11269 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11271 This file is part of GNU Emacs.
11273 GNU Emacs is free software: you can redistribute it and/or modify
11274 it under the terms of the GNU General Public License as published by
11275 the Free Software Foundation, either version 3 of the License, or
11276 (at your option) any later version.
11278 GNU Emacs is distributed in the hope that it will be useful,
11279 but WITHOUT ANY WARRANTY; without even the implied warranty of
11280 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11281 GNU General Public License for more details.
11283 You should have received a copy of the GNU General Public License
11284 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.