Remove no-longer-used macro HAVE_FTIME.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
003fdae2
PE
12012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5
784b56e2
EZ
62012-05-18 Eli Zaretskii <eliz@gnu.org>
7
8 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
9
10 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
11 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
12
13 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
14 reference to image_cache->refcount.
15 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
16
a0a79cde
JL
172012-05-17 Juri Linkov <juri@jurta.org>
18
19 * search.c (Fword_search_regexp, Fword_search_backward)
20 (Fword_search_forward, Fword_search_backward_lax)
21 (Fword_search_forward_lax): Move functions to isearch.el
22 (bug#10145, bug#11381).
23
b0572523
PE
242012-05-16 Paul Eggert <eggert@cs.ucla.edu>
25
26 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
27
9660f5fc
SM
282012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
29
30 * lread.c (init_obarray): Declare Qt and Qnil as special.
31
4374de83
GM
322012-05-14 Glenn Morris <rgm@gnu.org>
33
34 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 35 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 36
dc44c39a
PE
372012-05-14 Paul Eggert <eggert@cs.ucla.edu>
38
078c97cb
PE
39 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
40
dc44c39a
PE
41 * unexaix.c: Port to more-recent AIX compilers.
42 (report_error, report_error_1, make_hdr, copy_sym)
43 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
44 Make arguments const char *, not char *, to avoid violations of C
45 standard and to fix some AIX warnings reported by Gilles Pion.
46
e18afed7 472012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
48
49 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
50 already have overlays loaded.
51 (handle_single_display_spec): Before returning without displaying
52 fringe bitmap, synchronize the bidi iterator with the main display
53 iterator, by calling iterate_out_of_display_property.
54 (iterate_out_of_display_property): Detect buffer iteration by
55 testing that it->string is a Lisp string.
56 (get_next_display_element): When the current object is exhausted,
57 and there's something on it->stack, call set_iterator_to_next to
58 proceed with what's on the stack, instead of returning zero.
59 (set_iterator_to_next): If called at the end of a Lisp string,
60 proceed to consider_string_end without incrementing string
61 position. Don't increment display vector index past the end of
62 the display vector. (Bug#11417)
c8fb9dc6
EZ
63 (pos_visible_p): Don't report a position visible when move_it_to
64 stopped at the last line of window, which happens to be scanned
65 backwards by the bidi iteration. (Bug#11464)
ac268e67 66
e18afed7 672012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
68
69 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
70 and right-margin display specs even if the spec is invalid or we
71 are on a TTY, and thus unable to display on the fringes. That's
72 because the text with the property will not be displayed anyway,
73 so we need to signal to the caller that this is a "replacing"
74 display spec. This fixes display when the spec is invalid or we
75 are on a TTY.
76
e18afed7 772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
78
79 * unexaix.c (make_hdr): Fix typo in prototype.
80 This bug broke the build on AIX. Problem reported by Gilles Pion.
81
9d0a235a
MA
822012-05-14 Michael Albinus <michael.albinus@gmx.de>
83
84 * keyboard.c (kbd_buffer_get_event): Read special events also in
85 batch mode. (Bug#11415)
86
9e6b06ed
GM
872012-05-12 Glenn Morris <rgm@gnu.org>
88
89 * ns.mk: Update for ns_appbindir no longer having trailing "/".
90
c1a1d7a3
EZ
912012-05-12 Eli Zaretskii <eliz@gnu.org>
92
93 * lisp.mk (lisp): Add newcomment.elc.
94
3fe7cdc8
GM
952012-05-12 Glenn Morris <rgm@gnu.org>
96
97 * Makefile.in (MKDIR_P): New, set by configure.
98 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
99
53f7d2c0
PE
1002012-05-11 Paul Eggert <eggert@cs.ucla.edu>
101
102 Remove unused function hourglass_started.
103 * dispextern.h (hourglass_started):
104 * w32fns.c (hourglass_started):
105 * xdisp.c (hourglass_started): Remove.
106
75aafb17
JB
1072012-05-10 Juanma Barranquero <lekktu@gmail.com>
108
109 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
110 Update dependencies.
111
12959e8e
PE
1122012-05-10 Paul Eggert <eggert@cs.ucla.edu>
113
97107e2e
PE
114 * xgselect.c (xg_select): Put maxfds+1 into a var.
115 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
116
12959e8e
PE
117 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
118
836d29b3
DA
1192012-05-10 Dave Abrahams <dave@boostpro.com>
120
121 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
122 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
123
5cb67954
MA
1242012-05-09 Michael Albinus <michael.albinus@gmx.de>
125
126 * dbusbind.c (xd_registered_buses): New internal Lisp object.
127 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
128 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
129 Initialize xd_registered_buses.
130
3478ec45
PE
1312012-05-09 Paul Eggert <eggert@cs.ucla.edu>
132
b263a6b0
PE
133 Untag more efficiently if USE_LSB_TAG.
134 This is based on a proposal by YAMAMOTO Mitsuharu in
135 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
136 For an admittedly artificial (nth 8000 longlist) benchmark on
137 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
138 Emacs's overall text size by 1%.
139 * lisp.h (XUNTAG): New macro.
140 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
141 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
142 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
143 * eval.c (Fautoload):
144 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
145 * frame.h (XFRAME): Use XUNTAG.
146
3478ec45
PE
147 Port recent dbusbind.c changes to 32-bit --with-wide-int.
148 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
149 Remove unportable assumptions about print widths of types like
150 dbus_uint32_t.
151 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
152 intptr_t when converting between pointer and integer, to avoid GCC
153 warnings about wrong width.
154
666b903b 1552012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
156
157 * w32proc.c (new_child): Force Windows to reserve only 64KB of
158 stack for each reader_thread, instead of defaulting to 8MB
159 determined by the linker. This avoids failures in creating
160 subprocesses on Windows 7, see the discussion in this thread:
161 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
162
b120cc17
JC
1632012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
164
165 Fix up display of the *Minibuf-0* buffer in the mini window.
166 * keyboard.c (read_char): Don't clear the echo area if there's no
167 message to clear.
168 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 169 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 170
9a4b36f8
MA
1712012-05-07 Michael Albinus <michael.albinus@gmx.de>
172
173 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
174 batch mode.
175
e5f9458f
CY
1762012-05-06 Chong Yidong <cyd@gnu.org>
177
178 * lisp.mk (lisp): Update.
179
eceeb5fc 1802012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
181
182 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
183
71873e2b
SM
1842012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
185
186 * data.c (PUT_ERROR): New macro.
187 (syms_of_data): Use it. Add new error type `user-error'.
188 * undo.c (user_error): New function.
189 (Fprimitive_undo): Use it.
190 * print.c (print_error_message): Adjust print style for `user-error'.
191 * keyboard.c (user_error): New function.
192 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
193
ab0fa4e4
PE
1942012-05-03 Paul Eggert <eggert@cs.ucla.edu>
195
196 Do not limit current-time-string to years 1000..9999.
197 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
198 (Fcurrent_time_string): Support any year that is supported by the
199 underlying localtime representation. Don't use asctime, as it
200 has undefined behavior for years outside the range -999..9999.
201
7ed806a7
PE
2022012-05-02 Paul Eggert <eggert@cs.ucla.edu>
203
204 Fix race conditions involving setenv, gmtime, localtime, asctime.
205 Without this fix, interrupts could mess up code that uses these
206 nonreentrant functions, since setting TZ invalidates existing
207 tm_zone or tzname values, and since most of these functions return
208 pointers to static storage.
209 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
210 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
211 Grow the critical sections to include not just invoking
212 localtime/gmtime, but also accessing these functions' results
213 including their tm_zone values if any, and any related TZ setting.
214 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
215 so that the struct tm is saved in the critical section.
216 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
217 motivated by the fact that memory allocation needs to be outside
218 the critical section.
219
0c16dfed
DA
2202012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
223 with RESET_INTERVAL.
224
225 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
226 Remove duplicated buffer name initialization.
227
3f83ace8
JM
2282012-05-02 Jim Meyering <jim@meyering.net>
229
230 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
231
c7b8541e
JM
232 * xfns.c (x_window): Use xstrdup (Bug#11375).
233
90207a15 2342012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
235
236 * xdisp.c (pos_visible_p): If already at a newline from the
237 display string before the 'while' loop, don't walk back the glyphs
238 from it3.glyph_row. Solves assertion violation when the display
239 string begins with a newline (egg.el). (Bug#11367)
240
b593d6a9
AH
2412012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
242
243 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
244 Move to simple.el.
245
4737362e
GM
2462012-05-01 Glenn Morris <rgm@gnu.org>
247
99cf43f9
GM
248 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
249 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
250 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
251 All were removed before 23.1.
252
9311dcff
GM
253 * dispnew.c: Remove HAVE_LIBNCURSES test;
254 it is always true on relevant platforms.
255
4d5c6349
GM
256 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
257 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
258
4737362e
GM
259 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
260
74dd3a6b
AS
2612012-04-30 Andreas Schwab <schwab@linux-m68k.org>
262
263 * .gdbinit (xpr): Remove checks for no longer existing misc types.
264 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
265 Remove.
266
13c379ee
PE
2672012-04-28 Paul Eggert <eggert@cs.ucla.edu>
268
269 Do not avoid creating empty evaporating overlays (Bug#9642).
270 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
271 That is, do not delete an evaporating overlay if it becomes
272 empty after its bounds are adjusted to fit within its buffer.
273 This fix caused other problems, and I'm reverting it until we get
274 to the bottom of them.
275
a8e7d6d7 2762012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
277
278 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
279
a8e7d6d7 2802012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
281
282 * xdisp.c (pos_visible_p): If the window start position is beyond
283 ZV, start the display from buffer beginning. Prevents assertion
284 violation in init_iterator when the minibuffer window is scrolled
285 via the scroll bar.
286
287 * window.c (window_scroll_pixel_based): Likewise.
288
a8e7d6d7 2892012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
290
291 * keymap.c (where_is_internal): Doc fix (Bug#10872).
292
a8e7d6d7 2932012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
294
295 * fileio.c (Fcopy_file, Fset_file_selinux_context):
296 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
297
a8e7d6d7 2982012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 299
b593d6a9
AH
300 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
301 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 302
1c6900d9
EZ
3032012-04-26 Eli Zaretskii <eliz@gnu.org>
304
4c3fa1d9
EZ
305 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
306 display element, check also the underlying string or buffer
307 character. (Bug#11341)
308
1c6900d9
EZ
309 * w32menu.c: Include w32heap.h.
310 (add_menu_item): If the call to AppendMenuW (via
311 unicode_append_menu) fails, disable Unicode menus only if we are
312 running on Windows 9X/Me.
313
42bf8205
AS
3142012-04-24 Andreas Schwab <schwab@linux-m68k.org>
315
316 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
317 (xgetint): Add missing shift for LSB tags.
318
b1bac16e
MR
3192012-04-24 Martin Rudalics <rudalics@gmx.at>
320
321 * keyboard.c (read_char): Don't wipe echo area for select window
322 events: These might get delayed via `mouse-autoselect-window'
323 (Bug#11304).
324
d69621cc
JB
3252012-04-24 Juanma Barranquero <lekktu@gmail.com>
326
327 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
328 manipulation of :loaded-from data.
329
02fd101b
JB
3302012-04-23 Juanma Barranquero <lekktu@gmail.com>
331
332 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
333 now a cons (bug#11311).
334
888bec30
PE
3352012-04-23 Paul Eggert <eggert@cs.ucla.edu>
336
89a438bd
PE
337 Do not create empty overlays with the evaporate property (Bug#9642).
338 * buffer.c (Fmove_overlay): Delete an evaporating overlay
339 if it becomes empty after its bounds are adjusted to fit within
340 its buffer. Without this fix, in a nonempty buffer (let ((o
341 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
342 yields an empty overlay that has the evaporate property, which is
343 not supposed to happen.
344
1068fe4d
PE
345 Fix minor GTK3 problems found by static checking.
346 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
347 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
348 (struct _EmacsFixedClass, emacs_fixed_get_type):
349 Move decls here from emacsgtkfixed.h, since they needn't be public.
350 (emacs_fixed_get_type): Now static.
351 (emacs_fixed_class_init): Omit unused local.
352 (emacs_fixed_child_type): Remove; unused.
353 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
354 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
355 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
356 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
357 (EMACS_FIXED_GET_CLASS): Remove; unused.
358 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
359
888bec30
PE
360 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
361 Problem reported by Juanma Barranquero for Windows -Wunused-function.
362
de85e130
PE
3632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
364
d0baac98
PE
365 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
366 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
367 (__malloc_size_t, __malloc_ptrdiff_t):
368 Remove. All uses removed, replaced by the definiens if needed,
369 since we can assume C89 or better now.
370 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
371 (protect_malloc_state, align, get_contiguous_space)
372 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
373 (malloc_atfork_handler_child, malloc_enable_thread)
374 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
375 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
376 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
377 (special_realloc, _realloc_internal_nolock, _realloc_internal)
378 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
379 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
380 Define using prototypes, not old style.
381 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
382 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
383 (align): Don't assume that signed integer overflow wraps around.
384 Omit unused local var.
385 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
386 (_free_internal_nolock, memalign, mallochook, reallochook):
387 Omit no-longer-needed casts.
388 (valloc): Use getpagesize, not __getpagesize.
389 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
390 (struct hdr): The 'magic' member is now size_t, not unsigned long.
391
de85e130
PE
392 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
393
dcbf5805
MA
3942012-04-22 Michael Albinus <michael.albinus@gmx.de>
395
396 Move functions from C to Lisp. Make non-blocking method calls
397 the default. Implement further D-Bus standard interfaces.
398
399 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
400 (QCdbus_request_name_allow_replacement)
401 (QCdbus_request_name_replace_existing)
402 (QCdbus_request_name_do_not_queue)
403 (QCdbus_request_name_reply_primary_owner)
404 (QCdbus_request_name_reply_in_queue)
405 (QCdbus_request_name_reply_exists)
406 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
407 (QCdbus_registered_serial, QCdbus_registered_method)
408 (QCdbus_registered_signal): New Lisp objects.
409 (XD_DEBUG_MESSAGE): Use sizeof.
410 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
411 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
412 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
413 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
414 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
415 (xd_signature, xd_append_arg): Allow float for integer types.
416 (xd_get_connection_references): New function.
b593d6a9
AH
417 (xd_get_connection_address): Rename from xd_initialize.
418 Return cached address.
dcbf5805
MA
419 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
420 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
421 level.
422 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 423 Return number of refcounts.
dcbf5805
MA
424 (Fdbus_get_unique_name): Make stronger parameter check.
425 (Fdbus_message_internal): New defun.
426 (Fdbus_call_method, Fdbus_call_method_asynchronously)
427 (Fdbus_method_return_internal, Fdbus_method_error_internal)
428 (Fdbus_send_signal, Fdbus_register_service)
429 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
430 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
431 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
432 (Vdbus_compiled_version, Vdbus_runtime_version)
433 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
434 (Vdbus_message_type_method_return, Vdbus_message_type_error)
435 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
436 (Vdbus_registered_buses, Vdbus_registered_objects_table):
437 Adapt docstring.
dcbf5805 438
52828e02
PE
4392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
440
da05bc4c
PE
441 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
442 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
443 Do not assume ptrdiff_t is the same width as 'int'.
444
52828e02
PE
445 * alloc.c: Handle unusual debugging option combinations.
446 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
447 since the two debugging options are incompatible.
448 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
449 is defined.
450 (mem_init, mem_insert, mem_insert_fixup):
451 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
452 (NEED_MEM_INSERT): Remove; no longer needed.
453
f01769f9
LL
4542012-04-22 Leo Liu <sdl.web@gmail.com>
455
456 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
457
5790543d
PE
4582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
459
460 * sysdep.c [__FreeBSD__]: Minor cleanups.
461 (list_system_processes, system_process_attributes) [__FreeBSD__]:
462 Use Emacs indenting style more consistently. Avoid some casts.
463 Use 'double' consistently rather than mixing 'float' and 'double'.
464
b91b7e4d
EW
4652012-04-21 Eduard Wiebe <usenet@pusto.de>
466
b593d6a9
AH
467 * sysdep.c (list_system_processes, system_process_attributes):
468 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 469
6114eb15
AS
4702012-04-21 Andreas Schwab <schwab@linux-m68k.org>
471
472 * lisp.mk (lisp): Update.
473
2f38dff7
PE
4742012-04-20 Paul Eggert <eggert@cs.ucla.edu>
475
476 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
477 It is never used otherwise.
478
4ae29f89
SM
4792012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
480
481 * print.c (print_preprocess): Only check print_depth if print-circle
482 is nil.
483 (print_object): Check for cycles even when print-circle is nil and
484 print-gensym is t, but only check print_depth if print-circle is nil.
485
f30d612a
CY
4862012-04-20 Chong Yidong <cyd@gnu.org>
487
488 * process.c (wait_reading_process_output): If EIO occurs on a pty,
489 set the status to "failed" and ensure that sentinel is run.
490
c07a4c0b 4912012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
492
493 * process.c (Fset_process_inherit_coding_system_flag)
494 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 495 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 496
c07a4c0b 4972012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
498
499 * xdisp.c (string_buffer_position_lim): Limit starting position to
500 BEGV.
501 (set_cursor_from_row): If called for a mode-line or header-line
502 row, return zero immediately.
503 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
504 farther than the first row after the header line, if any.
505 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
506 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
507
c07a4c0b 5082012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 509
4ae29f89
SM
510 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
511 (bug#11238).
ad3a2b41 512
c07a4c0b 5132012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 5142012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
515
516 configure: new option --enable-gcc-warnings (Bug#11207)
517 * Makefile.in (C_WARNINGS_SWITCH): Remove.
518 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
519 (ALL_CFLAGS): Use new macros rather than old.
520 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
521 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
522 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
523 -Wunused-result, -Wunused-variable. This should go away once
524 the Emacs and Gnulib regex code is merged.
525 (xmalloc, xrealloc): Now static.
526
aba027e8
PE
5272012-04-17 Paul Eggert <eggert@cs.ucla.edu>
528
529 * dired.c (Fsystem_groups): Remove unused local.
530
e5a36063
GM
5312012-04-17 Glenn Morris <rgm@gnu.org>
532
533 * dired.c (Fsystem_users): Doc fix.
534
316411f0
DA
5352012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
536
537 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
538 (syms_of_dired): Add them.
539
9426aba4
PE
5402012-04-16 Paul Eggert <eggert@cs.ucla.edu>
541
b62a57be
PE
542 Fix minor alloc.c problems found by static checking.
543 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
544 New extern decls, to avoid calling undeclared functions.
545 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
546 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
547 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
548 (NEED_MEM_INSERT): New macro.
549 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 550 Remove one incorrect comment and fix another.
b62a57be 551
3539f31f
PE
552 Fix minor ralloc.c problems found by static checking.
553 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
554 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
555 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
556 (r_alloc_sbrk): Now static.
557
a041960a
PE
558 Improve ralloc.c interface checking.
559 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
560 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
561 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
562 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
563 [REL_ALLOC]: ... to here, to check interface.
564 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
565 Remove decls. This fixes an "It stinks!".
566
9426aba4
PE
567 * alloc.c (which_symbols): Fix alignment issue / type clash.
568
d55c12ed
AS
5692012-04-15 Andreas Schwab <schwab@linux-m68k.org>
570
571 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
572 (struct Lisp_Misc_Any): Likewise.
573 (struct Lisp_Free): Likewise.
574 * alloc.c (union aligned_Lisp_Symbol): Define.
575 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
576 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
577 (union aligned_Lisp_Misc): Define.
578 (MARKER_BLOCK_SIZE, struct marker_block): Use union
579 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 580 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 581
b948ce8b
PE
5822012-04-14 Paul Eggert <eggert@cs.ucla.edu>
583
584 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
585 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
586 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
587 * s/netbsd.h, s/sol2-6.h:
588 Remove definition of GC_MARK_STACK, since the default now works.
589 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
590 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
591 no longer the default.
592 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
593
35dc09a1 5942012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 595
35dc09a1
GM
596 * lread.c (lisp_file_lexically_bound_p):
597 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 598
35dc09a1
GM
5992012-04-14 Eli Zaretskii <eliz@gnu.org>
600
601 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
602 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
603
6042012-04-14 Jan Djärv <jan.h.d@swipnet.se>
605
606 * nsterm.m (constrainFrameRect): Always constrain when there is only
607 one screen (Bug#10962).
608
bcd86815
KB
6092012-04-13 Ken Brown <kbrown@cornell.edu>
610
611 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
612
c25df26e
RT
6132012-04-13 Reuben Thomas <rrt@sc3d.org>
614
615 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
616
0fc59f1e
DC
6172012-04-11 Daniel Colascione <dancol@dancol.org>
618
619 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
620 against is gone. It's better to use vfork now so that when Cygwin
621 gains a new, working vfork, we use it automatically (bug#10398).
622
de8c03dc
SM
6232012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * window.c (save_window_save): Obey window-point-insertion-type.
626
2f097256
GM
6272012-04-11 Glenn Morris <rgm@gnu.org>
628
629 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
630
453b951e
SM
6312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
634
75f1671a 6352012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
636
637 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
638 (force_quit_count): New var.
639 (handle_interrupt): Use it.
640
2a8ce227
JB
6412012-04-10 Juanma Barranquero <lekktu@gmail.com>
642
643 * w32.c (w32_delayed_load): Record the full path of the library
644 being loaded (bug#10424).
645
935396c0
GM
6462012-04-09 Glenn Morris <rgm@gnu.org>
647
05920a43
GM
648 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
649 not just in the obarray, before snarfing them. (Bug#11036)
650
935396c0
GM
651 * Makefile.in ($(leimdir)/leim-list.el):
652 Pass EMACS rather than BUILT_EMACS.
653
a18ecafa
TZ
6542012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
655
656 * process.c (make_process):
657 * process.h: Add integer `gnutls_handshakes_tried' member to
658 process struct.
659
6bbef4e5
JC
660 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
661 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
662
663 * gnutls.c (gnutls_log_function2i): Convenience log function.
664 (emacs_gnutls_read): Use new log functions,
665 `gnutls_handshakes_tried' process member, and
666 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
667 attempts per process (connection).
668
b4d3bc10
CY
6692012-04-09 Chong Yidong <cyd@gnu.org>
670
671 * eval.c (Fuser_variable_p, user_variable_p_eh)
672 (lisp_indirect_variable): Functions deleted.
673 (Fdefvar): Caller changed.
674
675 * callint.c (Finteractive, Fcall_interactively):
676 * minibuf.c (Fread_variable): Callers changed.
677
70f4d973
EZ
6782012-04-09 Eli Zaretskii <eliz@gnu.org>
679
680 * xdisp.c (set_cursor_from_row): If the display string appears in
681 the buffer at position that is closer to point than the position
682 after the display string, display the cursor on the first glyph of
683 the display string. Fixes cursor display when a 'display' text
684 property immediately follows invisible text. (Bug#11094)
685
cb3c2e3e
PE
6862012-04-09 Paul Eggert <eggert@cs.ucla.edu>
687
688 composite.c: use 'double' consistently
689 * composite.c (get_composition_id): Use 'double' consistently
690 instead of converting 'float' to 'double' and vice versa; this is
691 easier to understand and avoids a GCC warning.
692
fd06db5d
GM
6932012-04-09 Glenn Morris <rgm@gnu.org>
694
50fe702a
GM
695 * Makefile.in: Generate leim-list with bootstrap-emacs, in
696 preparation for dumping it with emacs. (Bug#4789)
697 (leimdir): New variable.
698 ($(leimdir)/leim-list.el): New rule.
699 (emacs$(EXEEXT)): Depend on leim-list.el.
700
fd06db5d
GM
701 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
702 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
703 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
704
55c131ee
AS
7052012-04-08 Andreas Schwab <schwab@linux-m68k.org>
706
707 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
708 proper alignment.
709
9209588f
JB
7102012-04-07 Juanma Barranquero <lekktu@gmail.com>
711
712 * xml.c (init_libxml2_functions) [WINDOWSNT]:
713 Remove unused local variable.
714
e3fb2efb
PE
7152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
716
717 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
718 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
719 (mark_memory): Mark Lisp_Objects only if pointers might hide in
720 objects, as mark_maybe_pointer will catch them otherwise.
721 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
722 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
723
b5385551
PE
7242012-04-07 Paul Eggert <eggert@cs.ucla.edu>
725
726 Fix typo that broke non-Windows builds.
727 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
728
9078ead6
EZ
7292012-04-07 Eli Zaretskii <eliz@gnu.org>
730
731 Support building on MS-Windows with libxml2.
732
733 * makefile.w32-in (OBJ2): Add xml.$(O).
734 (GLOBAL_SOURCES): Add xml.c.
735 ($(BLD)/xml.$(O)): New dependency list.
736
737 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
738 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
739 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
740 [!WINDOWSNT]: New macros.
741 (init_libxml2_functions, libxml2_loaded_p): New functions.
742 (parse_region): Call fn_xmlCheckVersion instead of using the macro
743 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
744 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
745 Calls xmlCleanupParser only if libxml2 was loaded (or statically
746 linked in).
6bbef4e5
JC
747 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
748 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
749 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
750
751 * emacs.c: Don't include libxml/parser.h.
752 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
753 xmlCleanupParser directly.
754
755 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
756
3811fdf3
EZ
7572012-04-07 Eli Zaretskii <eliz@gnu.org>
758
759 * indent.c (Fvertical_motion): If there is a display string at
760 point, use it.vpos to compute how many lines to backtrack after
761 move_it_to point. (Bug#11133)
762
2f8e16b2
EZ
7632012-04-06 Eli Zaretskii <eliz@gnu.org>
764
765 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
766 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
767 about subtle differences between FETCH_CHAR* and STRING_CHAR*
768 macros related to unification of CJK characters. For the details,
769 see the discussion following the message here:
770 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
771
3d439cd1
CY
7722012-04-04 Chong Yidong <cyd@gnu.org>
773
774 * keyboard.c (Vdelayed_warnings_list): Doc fix.
775
8bc53d00
EZ
7762012-04-01 Eli Zaretskii <eliz@gnu.org>
777
778 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
779 instead of alloca. (Bug#11138)
780
3b0512a3
AS
7812012-04-01 Andreas Schwab <schwab@linux-m68k.org>
782
783 * w32menu.c (is_simple_dialog): Properly check lisp types.
784 (Bug#11141)
785
8427ddd2
EZ
7862012-03-31 Eli Zaretskii <eliz@gnu.org>
787
979022ef
EZ
788 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
789 position we get to after a call to move_it_to fails the
790 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
791 only if we wind up in a string from display property. (Bug#11063)
792
a6b1c7cc
EZ
793 * window.c (Fdelete_other_windows_internal): Invalidate the row
794 and column information about mouse highlight, so that redisplay
795 restores it after reallocating the glyph matrices. (Bug#7464)
796
8427ddd2
EZ
797 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
798 string comes from a `display' text property, use the buffer
799 position of that property as if we actually saw that position in
800 the row's glyphs.
697ba24b
EZ
801 (move_it_by_lines): Remove the assertion that
802 "it->current_x == 0 && it->hpos == 0" which can be legitimately
803 violated when there's a before-string at the beginning of a line.
804 (Bug#11063)
8427ddd2 805
65a0a738
EZ
8062012-03-30 Eli Zaretskii <eliz@gnu.org>
807
808 * xdisp.c (append_space_for_newline): If the default face was
809 remapped, use the remapped face for the appended newline.
810 (extend_face_to_end_of_line): Use the remapped default face for
811 extending the face to the end of the line.
812 (display_line): Call extend_face_to_end_of_line when the default
813 face was remapped. (Bug#11068)
814
581355cc
EZ
8152012-03-29 Eli Zaretskii <eliz@gnu.org>
816
817 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
818
e8fc049f
SM
8192012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
820
821 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
822
4fb9a543
GM
8232012-03-27 Glenn Morris <rgm@gnu.org>
824
825 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
826 Doc fixes.
827
679910f1
KH
8282012-03-26 Kenichi Handa <handa@m17n.org>
829
830 * dispextern.h (struct glyph): Fix previous change. Change the
831 bit length of glyphless.ch to 25 (Bug#11082).
832
90d49b7f
CY
8332012-03-26 Chong Yidong <cyd@gnu.org>
834
835 * keyboard.c (Vselection_inhibit_update_commands): New variable.
836 (command_loop_1): Use it; inhibit selection update for
837 handle-select-window too (Bug#8996).
838
f514f6f0
FP
8392012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
840
e8fc049f 841 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 842
bf43fa51
KH
8432012-03-25 Kenichi Handa <handa@m17n.org>
844
845 * dispextern.h (struct glyph): Change the bit length of
846 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
847
8a0c01dd
EZ
8482012-03-24 Eli Zaretskii <eliz@gnu.org>
849
850 * s/ms-w32.h (tzname): Include time.h before redirecting to
851 _tzname. Fixes the MSVC build. (Bug#9960)
852
7d1c3a76
AS
8532012-03-24 Andreas Schwab <schwab@linux-m68k.org>
854
8ed79523
AS
855 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
856 characters.
857
7d1c3a76
AS
858 * xterm.c (XTread_socket): Only modify handling_signal if
859 !SYNC_INPUT. (Bug#11080)
860
e99a9b8b
EZ
8612012-03-23 Eli Zaretskii <eliz@gnu.org>
862
863 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
864 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
865 when fetching a multibyte character consumes more bytes than
866 CHAR_BYTES returns, due to unification of CJK characters in
867 string_char. (Bug#11073)
868
5063c0e1
TN
8692012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
870
871 * process.c (wait_reading_process_output): Handle pty disconnect
872 by refraining from sending oneself a SIGCHLD (bug#10933).
873
9f851fbd
CY
8742012-03-22 Chong Yidong <cyd@gnu.org>
875
876 * dispextern.h (struct it): New member string_from_prefix_prop_p.
877
5063c0e1 878 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
879 Mark string as coming from a prefix property.
880 (handle_face_prop): Use default face for prefix strings (Bug#4281).
881 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
882
fb5b8aca
CY
8832012-03-21 Chong Yidong <cyd@gnu.org>
884
885 * xfaces.c (Vface_remapping_alist): Doc fix.
886
62356a1b
EZ
8872012-03-20 Eli Zaretskii <eliz@gnu.org>
888
889 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
890 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
891 Doc fixes.
62356a1b 892
025de85b
CY
8932012-03-20 Chong Yidong <cyd@gnu.org>
894
895 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
896 to reflect default non-nil value of redisplay-dont-pause.
897
4827f94e
KH
8982012-03-19 Kenichi Handa <handa@m17n.org>
899
900 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
901 it fit in a valid range (Bug#11003).
902
e50a24a2
EZ
9032012-03-18 Eli Zaretskii <eliz@gnu.org>
904
905 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
906 that is not from display property, accept the row as a "cursor
907 row" if one of the string's character has a non-nil `cursor'
908 property. Fixes cursor positioning when there are newlines in
909 overlay strings, e.g. in icomplete.el. (Bug#11035)
910
9af5ed87
PE
9112012-03-12 Paul Eggert <eggert@cs.ucla.edu>
912
913 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
914
d1f55f16
CY
9152012-03-12 Chong Yidong <cyd@gnu.org>
916
917 * eval.c (inhibit_lisp_code): Rename from
918 inhibit_window_configuration_change_hook; move from window.c.
919
920 * xfns.c (unwind_create_frame_1, Fx_create_frame):
921 * window.c (run_window_configuration_change_hook)
922 (syms_of_window): Callers changed.
923
66c5eebd
CY
9242012-03-11 Chong Yidong <cyd@gnu.org>
925
413df973
CY
926 * keymap.c (Fkey_description): Doc fix (Bug#9700).
927
66c5eebd
CY
928 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
929
1de11f56
CY
9302012-03-10 Chong Yidong <cyd@gnu.org>
931
932 * frame.c (other_visible_frames): Don't assume the selected frame
933 is visible (Bug#10955).
934
cae07000
SM
9352012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
938
89c94350
JD
9392012-03-08 Jan Djärv <jan.h.d@swipnet.se>
940
941 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
942 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
943 zero (Bug#10954).
944
999dd333
GM
9452012-03-03 Glenn Morris <rgm@gnu.org>
946
01a6dcc8 947 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 948
de0100f2
EZ
9492012-03-02 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
952 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
953 (redisplay_window, next_element_from_string): Fix typos in
954 comments.
3e441275
EZ
955 (redisplay_window): Pass to move_it_vertically the margin in
956 pixels, not in screen lines.
de0100f2 957
96a72ee9
GM
9582012-03-02 Glenn Morris <rgm@gnu.org>
959
960 * buffer.c (buffer-list-update-hook): Doc fix.
961
312508d7
EZ
9622012-02-29 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
965 push_it before setting up the iterator for the first overlay
966 string, even if we have an empty string loaded.
967 (next_overlay_string): If there's an empty string on the iterator
968 stack, pop the stack. (Bug#10903)
969
27f3c637
PE
9702012-02-25 Paul Eggert <eggert@cs.ucla.edu>
971
972 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
973 Suggested by Stefan Monnier in
974 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
975 * alloc.c (widen_to_Lisp_Object): New static function.
976 (mark_memory): Also mark Lisp_Objects by fetching pointer words
977 and widening them to Lisp_Objects. This would work even if
978 USE_LSB_TAG is defined and wide integers are used, which might
979 happen in a future version of Emacs.
980
3c9dfce6
CY
9812012-02-25 Chong Yidong <cyd@gnu.org>
982
fa74b241
CY
983 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
984 Doc fix.
985
3c9dfce6
CY
986 * xselect.c (Fx_selection_exists_p): Doc fix.
987 (x_clipboard_manager_save_all): Print an informative message
988 before saving to clipboard manager.
989
9486df08
CY
9902012-02-24 Chong Yidong <cyd@gnu.org>
991
992 * keyboard.c (process_special_events): Handle all X selection
993 requests in kbd_buffer, not just the next one (Bug#8869).
994
f01d3321
CY
9952012-02-23 Chong Yidong <cyd@gnu.org>
996
997 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
998 call when setting menu-bar-lines and tool-bar-lines parameters.
999 (unwind_create_frame_1): New helper function.
1000
1001 * window.c (inhibit_window_configuration_change_hook): New var.
1002 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1003 (syms_of_window): Initialize it.
f01d3321 1004
86b847b6
CY
10052012-02-22 Chong Yidong <cyd@gnu.org>
1006
1007 * xterm.c (x_draw_image_relief): Add missing type check for
1008 Vtool_bar_button_margin (Bug#10743).
1009
a59225b1
CY
10102012-02-21 Chong Yidong <cyd@gnu.org>
1011
1012 * fileio.c (Vfile_name_handler_alist): Doc fix.
1013
1014 * buffer.c (Fget_file_buffer): Protect against invalid file
1015 handler return value.
1016
310f5bd4
PE
10172012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1018
cb3a28cc
PE
1019 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1020 when computing $valmask.
1021
310f5bd4
PE
1022 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1023 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1024 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1025 It's useless in that case, and it can cause problems on hosts
1026 that allocate halves of EMACS_INT values separately.
1027 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1028 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1029 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1030 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1031 it avoids undefined behavior on hosts where shifting right by more
1032 than the word width has undefined behavior.
1033
2375c96a
CY
10342012-02-19 Chong Yidong <cyd@gnu.org>
1035
1036 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1037 (Funhandled_file_name_directory, Ffile_name_as_directory)
1038 (Fdirectory_file_name, Fexpand_file_name)
1039 (Fsubstitute_in_file_name): Protect against invalid file handler
1040 return values (Bug#10845).
1041
3eb49e71
EZ
10422012-02-18 Eli Zaretskii <eliz@gnu.org>
1043
1044 * .gdbinit (pitx): Fix incorrect references to fields of the
1045 iterator stack.
1046
7b926f3f
CY
10472012-02-17 Chong Yidong <cyd@gnu.org>
1048
1049 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1050
11273115
PE
10512012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1054 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1055
c3a70e2b
CY
10562012-02-15 Chong Yidong <cyd@gnu.org>
1057
1058 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1059 marked as special. Also, starting docstrings with * is obsolete.
1060
0ca43699
AS
10612012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1062
1063 * gnutls.c (emacs_gnutls_write): Fix last change.
1064
2e8f3c56
LI
10652012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1066
1067 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1068 send_process.
1069
af70074f
SM
10702012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1071
1072 * keymap.c (Fsingle_key_description): Handle char ranges.
1073
95986d52
CY
10742012-02-12 Chong Yidong <cyd@gnu.org>
1075
afd83bd1
CY
1076 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1077 as that creates a dangerous corner case.
1078
95986d52
CY
1079 * window.c (Fdelete_window_internal): Invalidate the mouse
1080 highlight (Bug#9904).
1081
bd7da63e
GM
10822012-02-12 Glenn Morris <rgm@gnu.org>
1083
1084 * xselect.c (Fx_own_selection_internal)
1085 (Fx_get_selection_internal, Fx_disown_selection_internal)
1086 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1087 * nsselect.m (Fx_own_selection_internal)
1088 (Fx_disown_selection_internal, Fx_selection_exists_p)
1089 (Fx_selection_owner_p, Fx_get_selection_internal):
1090 Sync docs and argument specs with the xselect.c versions.
1091
77abcbc2
LI
10922012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1093
1094 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1095
90b671e2
EZ
10962012-02-11 Eli Zaretskii <eliz@gnu.org>
1097
1c0ca0b7
EZ
1098 * w32select.c (Fx_selection_exists_p): Sync doc string and
1099 argument list with xselect.c. (Bug#10783)
1100
1101 * w16select.c (Fx_selection_exists_p): Sync doc string and
1102 argument list with xselect.c. (Bug#10783)
90b671e2 1103
49241268
GM
11042012-02-10 Glenn Morris <rgm@gnu.org>
1105
1106 * fns.c (Fsecure_hash): Doc fix.
1107
f998bbe7 11082012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1109
1110 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1111
0992bd9c
CY
11122012-02-07 Chong Yidong <cyd@gnu.org>
1113
1114 * buffer.c (Fbuffer_local_variables)
1115 (buffer_lisp_local_variables): Handle unbound vars correctly;
1116 don't let Qunbound leak into Lisp.
1117
af008560
GM
11182012-02-07 Glenn Morris <rgm@gnu.org>
1119
dd605cc4
GM
1120 * image.c (Fimagemagick_types): Doc fix.
1121
af008560
GM
1122 * image.c (imagemagick-render-type): Change it from a lisp object
1123 to an integer. Move the doc here from the lisp manual.
1124 Treat all values not equal to 0 the same.
1125
1449fa1d
CY
11262012-02-06 Chong Yidong <cyd@gnu.org>
1127
1128 * doc.c (store_function_docstring): Avoid applying docstring of
1129 alias to base function (Bug#2603).
1130
3723ec07
AS
11312012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1132
1133 * .gdbinit (pp1, pv1): Remove redundant defines.
1134 (pr): Use pp.
1135
79c1cc1e
CY
11362012-02-04 Chong Yidong <cyd@gnu.org>
1137
1138 * nsterm.m: Declare a global (Bug#10694).
1139
d7f29f8e
EZ
11402012-02-04 Eli Zaretskii <eliz@gnu.org>
1141
cae07000
SM
1142 * w32.c (get_emacs_configuration_options):
1143 Include --enable-checking, if specified, in the return value.
d7f29f8e 1144
3b95a6f9
MR
11452012-02-04 Martin Rudalics <rudalics@gmx.at>
1146
1147 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1148 after rounding frame sizes. (Bug#9723)
1149
d6fa96a6
EZ
11502012-02-04 Eli Zaretskii <eliz@gnu.org>
1151
1152 * keyboard.c (adjust_point_for_property): Don't position point
1153 before BEGV. (Bug#10696)
1154
df0b2940
PE
11552012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 Handle overflow when computing char display width (Bug#9496).
1158 * character.c (char_width): Return EMACS_INT, not int.
1159 (char_width, c_string_width): Check for overflow when
1160 computing the width; this is possible now that individual
1161 characters can have unbounded width. Problem introduced
1162 by merge from Emacs 23 on 2012-01-19.
1163
6bee44d6
MA
11642012-02-02 Michael Albinus <michael.albinus@gmx.de>
1165
1166 * dbusbind.c (Fdbus_register_method): Mention the return value
1167 :ignore in the docstring.
1168
44f92739
GM
11692012-02-02 Glenn Morris <rgm@gnu.org>
1170
1b9f60cc
GM
1171 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1172
44f92739
GM
1173 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1174 Unconditionally set to t. (Bug#10673)
1175 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1176 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1177 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1178
c5d3843c
KH
11792012-02-02 Kenichi Handa <handa@m17n.org>
1180
1181 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1182 0, do not call append_composite_glyph.
1183
159462d4 11842012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1185
1186 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1187 NULL (Bug#6988).
1188 (x_produce_glyphs): If the component of a composition is a null
1189 string, set it->pixel_width to 1 to avoid zero-width glyph.
1190
78cef877
EZ
11912012-02-01 Eli Zaretskii <eliz@gnu.org>
1192
1193 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1194 first 2 arguments are identical. This makes inserting large
1195 output from a subprocess an order of magnitude faster on
1196 MS-Windows, where all sbrk'ed memory is always contiguous.
1197
97897668
GM
11982012-01-31 Glenn Morris <rgm@gnu.org>
1199
1200 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1201 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1202 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1203
31fd3586
GM
12042012-01-29 Glenn Morris <rgm@gnu.org>
1205
1206 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1207
0e24a8b2
CY
12082012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1209
1210 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1211
cc0adcb0
CY
12122012-01-28 Chong Yidong <cyd@gnu.org>
1213
1214 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1215
acc28cb9
CY
12162012-01-26 Chong Yidong <cyd@gnu.org>
1217
9c69cfb7
CY
1218 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1219
acc28cb9
CY
1220 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1221 repeat counts (Bug#10507).
1222
48da7392
GM
12232012-01-26 Glenn Morris <rgm@gnu.org>
1224
1225 * lread.c (syms_of_lread): Doc fix.
1226
14af5f7f
CY
12272012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1228
1229 * coding.c (encode_designation_at_bol): Change return value to
1230 EMACS_INT.
1231
0b21c100
CY
12322012-01-25 Chong Yidong <cyd@gnu.org>
1233
1234 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1235
3c2907f7
CY
12362012-01-21 Chong Yidong <cyd@gnu.org>
1237
1238 * floatfns.c (Fcopysign): Make the second argument non-optional,
1239 since nil is not allowed anyway.
1240
959ad23f
AS
12412012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1242
1243 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1244 (send_process): Likewise.
1245
34a02f46
MR
12462012-01-19 Martin Rudalics <rudalics@gmx.at>
1247
1248 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1249 (Vwindow_persistent_parameters): Do not use Qstate.
1250 Rewrite doc-strings.
34a02f46 1251
1259009a 12522012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1253
1254 * character.c (char_width): New function.
70d4fdf6
GM
1255 (Fchar_width, c_string_width, lisp_string_width):
1256 Use char_width (Bug#9496).
25ed9e61 1257
6a6ee00d
MR
12582012-01-16 Martin Rudalics <rudalics@gmx.at>
1259
1260 * window.c (Vwindow_persistent_parameters): New variable.
1261 (Fset_window_configuration, save_window_save): Handle persistent
1262 window parameters.
1263
c85efaf7
EZ
12642012-01-14 Eli Zaretskii <eliz@gnu.org>
1265
1266 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1267 thrashing the stack of the thread. (Bug#9087)
1268
5944709e
PE
12692012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1270
1271 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1272
e71f5d99
EZ
12732012-01-11 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xdisp.c (rows_from_pos_range): Handle the case where the
1276 highlight ends on a newline. (Bug#10464)
1277 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1278 he end column for display of highlight that ends on a newline
1279 before a R2L line.
1280
ce316182
GM
12812012-01-11 Glenn Morris <rgm@gnu.org>
1282
1283 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1284 from load-path also when installation-directory is nil. (Bug#10208)
1285
5b43da69
GM
12862012-01-10 Glenn Morris <rgm@gnu.org>
1287
74cc8ff9
GM
1288 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1289
7d8d6e4e
GM
1290 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1291 Update template values to be closer to their typical values these days.
5b43da69 1292
a0db8d43
EZ
12932012-01-09 Eli Zaretskii <eliz@gnu.org>
1294
1295 * xdisp.c (rows_from_pos_range): Accept additional argument
1296 DISP_STRING, and accept any glyph in a row whose object is that
1297 string as eligible for mouse highlight. Fixes mouse highlight of
1298 display strings from overlays. (Bug#10464)
1299
9a0115ab 13002012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1301
b9110d6a 1302 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1303 * fileio.c (auto_saving_dir_umask): New static var.
1304 (Fmake_directory_internal): Use it.
1305 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1306 creating the directory. The old code temporarily assigns
1307 too-generous permissions to the directory.
1308 (do_auto_save_eh): Clear it.
b9110d6a 1309 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1310 that the var is always cleared.
1311
6c1bd3f3
EZ
13122012-01-07 Eli Zaretskii <eliz@gnu.org>
1313
1314 * search.c (scan_buffer): Pass character positions to
1315 know_region_cache, not byte positions. (Bug#6540)
1316
069d2b50
L
13172012-01-07 LynX <_LynX@bk.ru> (tiny change)
1318
1319 * w32.c (sys_rename): Report EXDEV when rename of a directory
1320 fails because the target is on another logical disk. (Bug#10284)
1321
75bf0d33
DB
13222012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1323
1324 * xterm.c (x_embed_request_focus): New function.
1325
1326 * xterm.h: Add prototype.
1327
1328 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1329
1c6e5a32
GM
13302012-01-05 Glenn Morris <rgm@gnu.org>
1331
1332 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1333
651e947e
EZ
13342012-01-01 Eli Zaretskii <eliz@gnu.org>
1335
1336 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1337 Load gnutls_transport_set_lowat only if GnuTLS version is below
1338 2.11.1.
1339 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1340 GnuTLS versions below 2.11.1.
1341
3778cdd8
AL
13422011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1343
1344 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1345 to the doc string advising against its use for altering the way
1346 windows are scrolled.
1347
0e5317f7
KH
13482011-12-28 Kenichi Handa <handa@m17n.org>
1349
1350 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1351 coding-system ASCII compatible only when it does not produce BOM
1352 on encoding (Bug#10383).
1353
93d5ca1f
JD
13542011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1355
1356 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1357 can scroll.
1358 (create_and_show_popup_menu): Always use menu_position_func for
1359 Gtk3 (Bug#10361).
1360
ca22b785
AS
13612011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1362
1363 * callint.c (Fcall_interactively): Don't truncate prompt string.
1364
d048e1e6
EZ
13652011-12-23 Eli Zaretskii <eliz@gnu.org>
1366
1367 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1368 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1369 resumed from there (after widening). (Bug#10360)
d048e1e6 1370
5ccaba1f
JD
13712011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1372
1373 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1374
204ee57f
JD
13752011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1376
b81d40f0
JB
1377 * nsterm.m (x_free_frame_resources):
1378 Release f->output_data.ns->miniimage.
204ee57f
JD
1379 (ns_index_color): Fix indentation. Do not retain
1380 color_table->colors[i].
1381
1382 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1383 before returning.
1384
1385 * nsfns.m (x_set_background_color): Assign return value from
1386 ns_index_color to face-background instead of NSColor*.
1387 (ns_implicitly_set_icon_type): Fix indentation.
1388 Change assignment in for loop to comparison.
1389
1390 * emacs.c (ns_pool): New variable.
1391 (main): Assign ns_pool.
1392 (Fkill_emacs): Call ns_release_autorelease_pool.
1393
1394 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1395 autorelease fdesc, release fdAttrs and tdict.
1396 (ns_get_covering_families): Release charset.
1397 (ns_findfonts): Release NSFontDescriptor created with new.
1398 (ns_uni_to_glyphs): Fix indentation.
1399 (setString): Release attrStr before assigning new value.
1400
c803b2b7
JD
14012011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1402
678f4426
JD
1403 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1404 and NS_IMPL_COCOA.
1405 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1406 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1407
cd394be1 14082011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1409
5fecd5fc
JD
1410 * nsterm.m (ns_term_init): Subscribe for notifications
1411 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1412 to method trackingNotification in EmacsMenu.
1413
1414 * nsmenu.m (trackingMenu): New variable.
3771cb17 1415 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1416 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1417 from Aquamacs (Bug#7030).
678f4426
JD
1418
14192011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1420
c803b2b7
JD
1421 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1422 (symbol_to_nsstring): Fix indentation.
1423 (ns_symbol_to_pb): New function.
cae07000
SM
1424 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1425 (Fns_rotate_cut_buffers_internal): Remove.
1426 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1427 Fns_store_cut_buffer_internal.
1428 (ns_get_foreign_selection, Fx_own_selection_internal)
1429 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1430 (Fns_get_selection_internal, Fns_store_selection_internal):
1431 Use ns_symbol_to_pb and check if return value is nil.
1432 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1433 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1434 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1435 renamed to Sns_store_selection_internal.
1436 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1437 and remove this function.
1438 (ns_handle_selection_clear): Remove, never used.
1439 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1440 here.
1441
e1b01a3a
KB
14422011-12-17 Ken Brown <kbrown@cornell.edu>
1443
1444 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1445 GID is unknown (Bug#10257).
1446
2adb6e85
PE
14472011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1450 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1451 which caused a build failure on GNU/Linux IA-64. This problem was
1452 introduced by my 2011-10-07 patch.
1453
d1d7b339
JL
14542011-12-15 Juri Linkov <juri@jurta.org>
1455
1456 * image.c (imagemagick_error): New function. (Bug#10112)
1457 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1458 Use `imagemagick_error' where ImageMagick functions return
1459 `MagickFalse'.
1460 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1461 proper order.
1462
100d5755
KH
14632011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1464
1465 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1466 fill background (Bug#8992).
1467
454592a6
MR
14682011-12-13 Martin Rudalics <rudalics@gmx.at>
1469
1470 * window.c (Vwindow_combination_resize)
1471 (Vwindow_combination_limit): Use t instead of non-nil in
1472 doc-strings.
61d4b438
MR
1473 (Vrecenter_redisplay): Add first sentence of doc-string on
1474 separate line.
53524d93 1475 (Frecenter): Fix doc-string typo.
454592a6 1476
3633e3aa
KH
14772011-12-11 Kenichi Handa <handa@m17n.org>
1478
1479 * coding.c (Funencodable_char_position): Pay attention to the
1480 buffer text relocation (Bug#9389).
1481
7b9d523a
JD
14822011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1483
1484 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1485 gtk_init (Bug#10100).
1486
b73189c6
EZ
14872011-12-10 Eli Zaretskii <eliz@gnu.org>
1488
1489 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1490 IT->string is nil. (Bug#10263)
1491
f7dfe5d6
JD
14922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1493
83faebb4
JD
1494 * nsterm.h (x_free_frame_resources): Declare.
1495
f7dfe5d6
JD
1496 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1497 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1498
1499 * nsterm.h (ns_get_defaults_value): Declare.
1500
1501 * nsterm.m (ns_default): Call ns_get_defaults_value.
1502
7cd4e72c
EZ
15032011-12-09 Eli Zaretskii <eliz@gnu.org>
1504
1505 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1506 (Bug#10170)
1507
b34d7317
YM
15082011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1509
1510 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1511 that where the value of an _OBJC_* symbol points to is in the .bss
1512 section (Bug#10240).
1513
76470ad1
KH
15142011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1515
1516 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1517 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1518
745fff94
KH
15192011-12-08 Kenichi Handa <handa@m17n.org>
1520
1521 * ftfont.c (get_adstyle_property): Fix previous change
1522 (Bug#10233).
1523
6e44397c
JB
15242011-12-07 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1527 dirs from the default value of EMACSLOADPATH (bug#10208).
1528
7efa6272
GM
15292011-12-07 Glenn Morris <rgm@gnu.org>
1530
1531 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1532 installation and source directories as well. (Bug#10208)
1533
f6fc4d87
CY
15342011-12-06 Chong Yidong <cyd@gnu.org>
1535
1536 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1537
2bf26180
GM
15382011-12-06 Glenn Morris <rgm@gnu.org>
1539
1540 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1541 as an error, not just -1. (Bug#10217)
1542
3a6ad4f0
CY
15432011-12-05 Chong Yidong <cyd@gnu.org>
1544
1545 * keyboard.c (process_special_events): New function.
1546 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1547
75a3b399
PE
15482011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1549
1550 * coding.c (encode_designation_at_bol): Don't use uninitialized
1551 local variable (Bug#9318).
1552
c3c9e25e
KH
15532011-12-05 Kenichi Handa <handa@m17n.org>
1554
1555 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1556 return Qnil (Bug#8046, Bug#10193).
1557
5eb05ea3
KH
15582011-12-05 Kenichi Handa <handa@m17n.org>
1559
1560 * coding.c (encode_designation_at_bol): New args charbuf_end and
1561 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1562 (coding_set_source): Return how many bytes coding->source was
1563 relocated.
1564 (coding_set_destination): Return how many bytes
1565 coding->destination was relocated.
1566 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1567 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1568
15692011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1570
1571 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1572 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1573 macro (Bug#9318).
1574
15752011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1576
1577 The following changes are to fix Bug#9318.
1578
a79703f5 1579 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1580 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1581 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1582 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1583
7dbda6df
JB
15842011-12-05 Juanma Barranquero <lekktu@gmail.com>
1585
1586 * lisp.h (process_quit_flag): Fix external declaration.
1587
6d5eb5b0
SM
15882011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1589
1590 Don't macro-inline non-performance-critical code.
1591 * eval.c (process_quit_flag): New function.
1592 * lisp.h (QUIT): Use it.
1593
a0c3fad0
JD
15942011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1595
1596 * nsfns.m (get_geometry_from_preferences): New function.
1597 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1598
6c07aac2
AS
15992011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1600
1601 * emacs.c (Qkill_emacs): Define.
1602 (syms_of_emacs): Initialize it.
1603 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1604 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1605 (quit_throw_to_read_char): Add parameter `from_signal'.
1606 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1607 * lisp.h (QUIT): Call Fkill_emacs if requested.
1608
c052ead4
JD
16092011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1610
1611 * widget.c (update_wm_hints): Return if wmshell is null.
1612 (widget_update_wm_size_hints): New function.
1613
1614 * widget.h (widget_update_wm_size_hints): Declare.
1615
1616 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1617 widget_update_wm_size_hints (Bug#10104).
1618
9e49252b
EZ
16192011-12-03 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1622 before a newline, prepare the bidi iterator for consuming the
1623 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1624 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1625
02b16839
JL
16262011-12-02 Juri Linkov <juri@jurta.org>
1627
1628 * search.c (Fword_search_regexp): New Lisp function created from
1629 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1630 (Fword_search_backward, Fword_search_forward)
1631 (Fword_search_backward_lax, Fword_search_forward_lax):
1632 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1633 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1634
0068070e
SM
16352011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1636
1637 * fileio.c (Finsert_file_contents): Move after-change-function call
1638 to before the "handled:" label, since all "goto handled" appear in
1639 cases where the *-change-functions have already been properly called
1640 (bug#10117).
1641
3360a3fc
AS
16422011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1643
1644 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1645 waiting for input. (Bug#10169)
1646
73d6c093
EZ
16472011-11-30 Eli Zaretskii <eliz@gnu.org>
1648
1649 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1650 verifies glyph row's hash code--we have just reallocated the
1651 glyphs, so their contents can be complete garbage. (Bug#10164)
1652
febe6bea
JB
16532011-11-30 Juanma Barranquero <lekktu@gmail.com>
1654
1655 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1656
801a4313
EZ
16572011-11-30 Eli Zaretskii <eliz@gnu.org>
1658
1659 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1660 attributes are tested _before_ calling verify_row_hash, to protect
1661 against GCC re-ordering of the tests. (Bug#10164)
1662
2b56b87e
JD
16632011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1664
1665 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1666
1667 * xterm.c (handle_one_xevent): Only set async_visible and friends
1668 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1669 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1670 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1671
dbf31225
PE
16722011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1675 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1676 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1677 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1678 All uses changed to use GCPRO1 etc.
1679 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1680 Revert to old implementation (i.e., before 2011-03-11).
1681
1305621b
YM
16822011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1683
1684 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1685 of scroll runs so as to avoid assigning disabled bogus rows and
1686 unnecessary graphics copy operations.
1687
8c9afb46
EZ
16882011-11-27 Eli Zaretskii <eliz@gnu.org>
1689
1690 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1691 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1692 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1693 (malloc, free, realloc, calloc): Redirect to e_* only when
1694 compiling Emacs.
1695
1696 * lisp.h (GCTYPEBITS): Move before first use.
1697 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1698 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1699 this macro definition.
1700
1701 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1702 _MSC_VER.
1703
54e9e3bf
JD
17042011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1705
6d5eb5b0
SM
1706 * gtkutil.c (xg_create_frame_widgets):
1707 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1708 present with Gtk+ 2.0.
1709
83aca1cb
PE
17102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * fileio.c (Finsert_file_contents): Undo previous change; see
1713 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1714
5b76caa4
PE
17152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 Rename locals to avoid shadowing.
1718 * fileio.c (Finsert_file_contents):
1719 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1720 * process.c (wait_reading_process_output):
1721 Rename inner 'proc' to 'p' to avoid shadowing.
1722 Indent for consistency with usual Emacs style.
1723
8c535114
EZ
17242011-11-25 Eli Zaretskii <eliz@gnu.org>
1725
1726 * xdisp.c (redisplay_window): If cursor row is not fully visible
1727 after recentering, and scroll-conservatively is set to a large
1728 number, scroll window by a few more lines to make the cursor fully
1729 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1730 (start_display): Don't move to the next line if the display should
1731 start at a newline that is part of a display vector or an overlay
1732 string. (Bug#10119)
8c535114 1733
fa4fdb5c
JL
17342011-11-24 Juri Linkov <juri@jurta.org>
1735
1736 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1737 after the `MagickPingImage' call. (Bug#10112)
1738
90ec88df
CY
17392011-11-23 Chong Yidong <cyd@gnu.org>
1740
1741 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1742
56e2e794
MR
17432011-11-23 Martin Rudalics <rudalics@gmx.at>
1744
1745 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1746 making another buffer current. (Bug#10114)
1747
b6e64c41
GM
17482011-11-23 Glenn Morris <rgm@gnu.org>
1749
1750 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1751
6b21de18
CY
17522011-11-23 Chong Yidong <cyd@gnu.org>
1753
1754 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1755 using it (Bug#5984).
1756
b12cd789
EZ
17572011-11-22 Eli Zaretskii <eliz@gnu.org>
1758
1759 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1760 and header-lines, as they don't have one computed for them.
1761 (Bug#10098)
1762
1763 * .gdbinit (prow): Make displayed values more self-explaining.
1764 Add row's hash code.
1765
261b6fd4
LMI
17662011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1767
1768 * process.c (wait_reading_process_output): Fix asynchrounous
1769 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1770 (wait_reading_process_output): Add comment and URL.
261b6fd4 1771
e7cfd277
JD
17722011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1773
1774 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1775
a9b9b7f5
CY
17762011-11-21 Chong Yidong <cyd@gnu.org>
1777
1778 * window.c (Fnext_window, Fprevious_window): Doc fix.
1779
b0d15b4f
SM
17802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1781
1782 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1783
fe7a3057
JB
17842011-11-20 Juanma Barranquero <lekktu@gmail.com>
1785
1786 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1787
d2999b1a
MR
17882011-11-20 Martin Rudalics <rudalics@gmx.at>
1789
1790 * window.c (Fset_window_combination_limit): Rename argument
1791 STATUS to LIMIT.
1792 (Vwindow_combination_limit): Remove "status" from doc-string.
1793
d5ff9cd0
AS
17942011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1795
1796 * m/ibms390.h: Remove.
1797 * m/ibms390x.h: Don't include "ibms390.h".
1798
a5bb9bd3
SM
17992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1800
1801 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1802 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1803
cd1181db
JB
18042011-11-20 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * casetab.c (Fset_case_table):
1807 * charset.c (Fcharset_after): Fix typos.
1808
615a3b8d 18092011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1810
17e845af
PE
1811 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1812 Otherwise, valgrind does not work on some platforms.
1813 Problem reported by Andreas Schwab in
6a0bf43d
PE
1814 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1815 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1816 is set, removing the need for VIRT_ADDRESS_VARIES.
1817 (PURE_P): Use a more-efficient implementation that needs just one
1818 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1819 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1820 to 4 (xorl, subq, cmpq, setbe).
1821 * alloc.c (pure): Always extern now, since that's the
1822 VIRT_ADDR_VARIES behavior.
1823 (PURE_POINTER_P): Use a single comparison, not two, for
1824 consistency with the new puresize.h.
1825 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1826 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1827 Remove VIRT_ADDR_VARIES no longer needed.
1828
f8fe6f96
EZ
18292011-11-19 Eli Zaretskii <eliz@gnu.org>
1830
1831 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1832 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1833 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1834 behave as if the cursor position were at the window margin.
1835
1836 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1837 and the cursor position is out of bounds, behave as if the cursor
1838 position were at the window margin. (Bug#10075)
1839
df05a53c
CY
18402011-11-18 Chong Yidong <cyd@gnu.org>
1841
1842 * window.c (Fwindow_combination_limit): Make first argument
1843 non-optional, since it is meaningless for live windows like the
1844 selected window.
1845
2071918e
DA
18462011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1847
1848 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1849
b50a28de
SM
18502011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1851
1852 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1853 (graft_intervals_into_buffer): Simplify.
1854
015137db
EZ
18552011-11-18 Eli Zaretskii <eliz@gnu.org>
1856
1857 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1858 hash values of the two rows.
1859 (copy_row_except_pointers): Preserve the used[] arrays and the
1860 hash values of the two rows. (Bug#10035)
68c95424 1861 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1862
1863 * xdisp.c (row_hash): New function, body extracted from
1864 compute_line_metrics.
1865 (compute_line_metrics): Call row_hash, instead of computing the
1866 hash code inline.
1867
1868 * dispnew.c (verify_row_hash): Call row_hash for computing the
1869 hash code of a row, instead of duplicating code from xdisp.c.
1870
1871 * dispextern.h (row_hash): Add prototype.
1872
a2addb04
TH
18732011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1874
1875 * frame.c (delete_frame): Don't delete the terminal when the last
1876 X frame is closed if emacs is built with GTK toolkit.
1877
df85d315
JB
18782011-11-17 Juanma Barranquero <lekktu@gmail.com>
1879
1880 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1881
a0c2d0ae
MR
18822011-11-17 Martin Rudalics <rudalics@gmx.at>
1883
1884 * window.c (Vwindow_splits): Rename to
1885 Vwindow_combination_resize. Suggested by Juri Linkov.
1886 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1887 of Vwindow_splits.
1888
58179cce
JB
18892011-11-16 Juanma Barranquero <lekktu@gmail.com>
1890
7877f373
JB
1891 * nsfns.m (Fns_font_name):
1892 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1893
b6f67890
MR
18942011-11-16 Martin Rudalics <rudalics@gmx.at>
1895
1896 * window.h (window): Rename slot "nest" to "combination_limit".
1897 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1898 (Fset_window_nest): Rename to Fset_window_combination_limit.
1899 (Vwindow_nest): Rename to Vwindow_combination_limit.
1900 (recombine_windows, make_parent_window, make_window)
1901 (Fsplit_window_internal, saved_window)
1902 (Fset_window_configuration, save_window_save): Rename all
1903 occurrences of window_nest to window_combination_limit.
1904
c7015153
JB
19052011-11-15 Juanma Barranquero <lekktu@gmail.com>
1906
1907 * image.c (imagemagick_load_image): Fix typo.
1908
322ad6ec
EZ
19092011-11-14 Eli Zaretskii <eliz@gnu.org>
1910
1911 * xdisp.c (display_line): Move the call to
1912 highlight_trailing_whitespace before the call to
1913 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1914 faces of all the glyphs to compute ROW's hash value.
1915 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1916
f067b8ec
JB
19172011-11-14 Juanma Barranquero <lekktu@gmail.com>
1918
1919 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1920 just return (bug#10044).
1921
1e5b2111
EZ
19222011-11-12 Eli Zaretskii <eliz@gnu.org>
1923
7ef3cbd5
EZ
1924 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1925 with user-defined heap size. Bump the default size of the temacs
1926 heap to 27MB, to avoid memory warning when running temacs.
1927 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1928
1e5b2111
EZ
1929 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1930 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1931 (verify_row_hash) [XASSERTS]: New function.
1932 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1933 that the hash value of glyph rows is correct.
1e5b2111 1934
89d61221
MR
19352011-11-12 Martin Rudalics <rudalics@gmx.at>
1936
1937 * window.h (window): Remove splits slot.
1938 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1939 (Fdelete_other_windows_internal, make_parent_window)
1940 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1941 (Fset_window_configuration, save_window_save): Don't deal with
1942 split status of windows.
1943 (saved_window): Remove splits slot.
1944 (Vwindow_splits): Rewrite doc-string.
1945
97f18cc8
JD
19462011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1947
1948 * xfns.c (unwind_create_frame):
1949 * nsfns.m (unwind_create_frame):
1950 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1951 Vframe_list (Bug#9999).
1952
22a648b4
DA
19532011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1954
0b381c7e 1955 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1956
659afede
KH
19572011-11-11 Kenichi Handa <handa@m17n.org>
1958
1959 * callproc.c (Fcall_process): Set the member dst_multibyte of
1960 process_coding.
1961
9ac0394b
KH
19622011-11-11 Johan Bockgård <bojohan@gnu.org>
1963
1964 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1965 avoid a crash (bug#9496).
1966
2fbdc249
CY
19672011-11-09 Chong Yidong <cyd@gnu.org>
1968
1969 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1970 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1971
ac6b1f81
PE
19722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1975
09db192c
PE
19762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 Avoid some portability problems by eschewing 'extern inline' functions.
1979 The trivial performance wins aren't worth the portability hassles; see
1980 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1981 et seq.
1982 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1983 (window_box_width, window_box_left, window_box_left_offset)
1984 (window_box_right, window_box_right_offset): Undo previous change,
1985 by removing the "extern"s.
1986 * intervals.c (adjust_intervals_for_insertion)
1987 (adjust_intervals_for_deletion): Undo previous change,
1988 making these static again.
1989 (offset_intervals, temp_set_point_both, temp_set_point)
1990 (copy_intervals_to_string): No longer inline.
1991 * xdisp.c (window_text_bottom_y, window_box_width)
1992 (window_box_height, window_box_left_offset)
1993 (window_box_right_offset, window_box_left, window_box_right)
1994 (window_box): No longer inline.
1995
105216ed
CY
19962011-11-08 Chong Yidong <cyd@gnu.org>
1997
1998 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1999 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2000 Signal an error if not a live window.
105216ed
CY
2001 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2002 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2003
ae9e237f
JB
20042011-11-07 Juanma Barranquero <lekktu@gmail.com>
2005
2006 * lisp.h (syms_of_abbrev): Remove declaration.
2007 Reported by CHENG Gao <chenggao@royau.me>.
2008
c7aa8333
EZ
20092011-11-07 Eli Zaretskii <eliz@gnu.org>
2010
2011 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2012 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2013 of temacs in GUI mode.
2014
be7f5545
MR
20152011-11-07 Martin Rudalics <rudalics@gmx.at>
2016
2017 * window.h: Declare delete_all_child_windows instead of
2018 delete_all_subwindows.
2019 * window.c (Fwindow_nest, Fset_window_nest)
2020 (Fset_window_new_total, Fset_window_new_normal)
2021 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2022 (delete_all_subwindows): Rename to delete_all_child_windows.
2023 (Fdelete_other_windows_internal, Fset_window_configuration):
2024 Call delete_all_child_windows instead of delete_all_subwindows.
2025 * frame.c (delete_frame): Call delete_all_child_windows instead
2026 of delete_all_subwindows.
2027
ca78dc43
PE
20282011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2031 This is also needed for porting to any host where GC_MARK_STACK is
2032 not GC_MAKE_GCPROS_NOOPS.
2033 (which_symbols): Use it.
2034
a0241d01
KH
20352011-11-07 Kenichi Handa <handa@m17n.org>
2036
2037 * coding.c (coding_set_destination): Check coding->src_pos only
2038 when coding->src_object is a buffer (bug#9910).
2039
2040 * process.c (send_process): Set the member src_multibyte of coding
2041 to 0 (bug#9911) when sending a unibyte text.
2042
2043 * callproc.c (Fcall_process): Set the member src_multibyte of
2044 process_coding to 0 (bug#9912).
2045
a64bfdfa 20462011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2047
2048 * xmenu.c (cleanup_widget_value_tree): New function.
2049 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2050 calling free_menubar_widget_value_tree directly (Bug#9830).
2051
cb41b32a
PE
20522011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Fix some portability problems with 'inline'.
2055 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2056 (window_box_width, window_box_left, window_box_left_offset)
2057 (window_box_right, window_box_right_offset): Declare extern.
2058 Otherwise, these inline functions do not conform to C99 and
2059 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2060 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2061 * intervals.c (adjust_intervals_for_insertion)
2062 (adjust_intervals_for_deletion): Now extern, because otherwise the
2063 extern inline functions 'offset_intervals' couldn't refer to it.
2064 (static_offset_intervals): Remove.
2065 (offset_intervals): Rewrite using the old contents of
2066 static_offset_intervals. The old version didn't conform to C99
2067 because an extern inline function contained a reference to an
2068 identifier with static linkage.
2069
b7041366
AS
20702011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2071
2072 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2073 GC.
2074
88a37c4d
EZ
20752011-11-06 Eli Zaretskii <eliz@gnu.org>
2076
2077 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2078 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2079 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2080 return Qleft_to_right.
2081
49745b39
CY
20822011-11-06 Chong Yidong <cyd@gnu.org>
2083
2084 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2085 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2086 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2087 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2088 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2089 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2090 (Fwindow_vscroll): Doc fix.
2091 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2092 argument, since it makes no sense to pass a live window and for
2093 consistency with window-child.
2094
1f05cd82
CS
20952011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2096
2097 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2098 support MSVC.
2099
22610910
JR
21002011-11-05 Jason Rumney <jasonr@gnu.org>
2101
2102 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2103 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2104 fonts (Bug#6029).
2105 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2106 bitwise arithmetic preventing use of unicode-sip and non-truetype
2107 opentype fonts.
2108
a06776b2
EZ
21092011-11-05 Eli Zaretskii <eliz@gnu.org>
2110
3ad924ba
EZ
2111 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2112 "emacs"-only part.
2113
a06776b2
EZ
2114 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2115 initialization code to keep similarity to xfns.c after changes
2116 from 2011-11-05.
2117
c9e7db78
JD
21182011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2119
a97f8f3f
JD
2120 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2121 (unwind_create_frame): New function (Bug#9943).
2122 (Fx_create_frame): Restructure code to be more similar to the one in
2123 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2124 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2125 Move terminal->reference_count++ just before making the frame official
2126 (Bug#9943).
2127
2128 * nsterm.m (x_free_frame_resources): New function.
2129 (x_destroy_window): Move code to x_free_frame_resources.
2130
c9e7db78 2131 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2132 (Fx_create_frame, x_create_tip_frame):
2133 Move terminal->reference_count++ just before making the frame
75f1671a 2134 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2135 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2136
a6fc3b5c
EZ
21372011-11-05 Eli Zaretskii <eliz@gnu.org>
2138
2139 Support MSVC build with newer versions of Visual Studio.
2140 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2141 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2142 nt/gmake.defs.
2143
2144 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2145 which are not supported by MSVC.
2146 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2147 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2148 bitfields.
2149 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2150 types in bitfields.
2151 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2152
2153 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2154
58179cce 21552011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2156
2157 Support MSVC build with newer versions of Visual Studio.
2158 * w32.c: Don't include w32api.h for MSVC.
2159 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2160
2161 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2162 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2163 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2164 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2165 e_* cousins.
2166 (alloca) [_MSC_VER]: Define to _alloca.
2167
2168 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2169
2170 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2171
a58c13ed
EZ
21722011-11-04 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (note_mouse_highlight): If either of
2175 previous/next-single-property-change returns nil, treat that as
2176 the beginning or the end of the buffer. (Bug#9955)
2177
fe0b6370
JD
21782011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2179
a58c13ed 2180 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2181 label is not null (Bug#9951).
2182 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2183 may be NULL.
2184
89bd5ee1
EZ
21852011-11-04 Eli Zaretskii <eliz@gnu.org>
2186
2187 * window.c (Fwindow_body_size): Mention in the doc string that the
2188 return value is in frame's canonical units. (Bug#9949)
2189
84c3edb9
EZ
21902011-11-03 Eli Zaretskii <eliz@gnu.org>
2191
4e2fb5c7
EZ
2192 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2193
84c3edb9 2194 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2195 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2196 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2197
bc17a887
EZ
21982011-11-01 Eli Zaretskii <eliz@gnu.org>
2199
2200 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2201 Don't stop backward scan on the continuation glyph, even though
2202 its CHARPOS is positive.
6d5eb5b0
SM
2203 (mouse_face_from_buffer_pos, note_mouse_highlight):
2204 Rename cover_string to disp_string.
bc17a887 2205
4ee88440
MR
22062011-11-01 Martin Rudalics <rudalics@gmx.at>
2207
2208 * window.c (temp_output_buffer_show): Don't use
2209 Vtemp_buffer_show_specifiers.
2210 (Vtemp_buffer_show_specifiers): Remove unused variable.
2211
c2ff3c02
EZ
22122011-10-30 Eli Zaretskii <eliz@gnu.org>
2213
2214 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2215 past the beginning of the current glyph matrix.
2216
58179cce 22172011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2218
2219 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2220 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2221 HAVE_GTK3 (Bug#9869).
b77a6a7f 2222
3b574623
JD
2223 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2224 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2225
b77a6a7f
JD
2226 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2227
2228 * xterm.c: Declare x_handle_net_wm_state to return int.
2229 (handle_one_xevent): Check if we are iconified but don't have
2230 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2231 (get_current_wm_state): Return non-zero if not hidden,
2232 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2233 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2234 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2235 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2236
196e41e4
PE
22372011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2238
2239 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2240 so that this new function doesn't get optimized away by a
2241 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2242
021f2e1a
AS
22432011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2244
2245 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2246
8b058d44
EZ
22472011-10-29 Eli Zaretskii <eliz@gnu.org>
2248
2249 Fix the `xbytecode' command.
2250 * .gdbinit (xprintbytestr): New command.
b50a28de 2251 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2252 (xbytecode): Print the byte-code string as well.
2253
4452fb80
EZ
22542011-10-29 Kim Storm <storm@cua.dk>
2255
8b058d44
EZ
2256 * alloc.c (which_symbols): New function.
2257
21b72067
AS
22582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2259
2260 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2261 line. (Bug#9903)
2262
83ed7b5c
GM
22632011-10-29 Glenn Morris <rgm@gnu.org>
2264
2265 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2266 Not clear what it was for, and it causes various bugs. (Bug#9839)
2267
5a7a728b
EZ
22682011-10-28 Eli Zaretskii <eliz@gnu.org>
2269
2270 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2271 possible random value that matches one of those tested as
2272 condition to clear the mouse face.
2273
d3d0842f
CY
22742011-10-28 Chong Yidong <cyd@gnu.org>
2275
2276 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2277
31b39d13
DN
22782011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2279
2280 * window.c (make_window): Initialize phys_cursor_on_p.
2281
9aba6043
SM
22822011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2283
2284 * lisp.h (struct Lisp_Symbol): Update comments.
2285
c20992f4
JB
22862011-10-28 Juanma Barranquero <lekktu@gmail.com>
2287
2288 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2289
db4f02f2
EZ
22902011-10-28 Eli Zaretskii <eliz@gnu.org>
2291
2292 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2293 <oslsachem@gmail.com> for helping to debug this.
2294
2295 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2296 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2297 (g_b_init_get_glyph_outline_w): New static variables.
2298 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2299 (GetGlyphOutlineW_Proc): New typedefs.
2300 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2301 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2302 New functions.
2303 (w32font_open_internal, compute_metrics):
2304 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2305 instead of calling the "wide" APIs directly.
2306
2307 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2308
2309 * w32.h (syms_of_w32font): Add prototype.
2310
87e68db4
JB
23112011-10-27 Juanma Barranquero <lekktu@gmail.com>
2312
2313 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2314 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2315 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2316 (Fmove_to_window_line): Doc fix.
2317
435c1d67
CY
23182011-10-27 Chong Yidong <cyd@gnu.org>
2319
2320 * process.c (make_process): Set gnutls_state to NULL.
2321
2322 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2323 non-NULL, regardless of GNUTLS_INITSTAGE.
2324 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2325 an error. Set process slots as soon as we allocate them.
2326
2327 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2328
9c6c6f49
CY
23292011-10-27 Chong Yidong <cyd@gnu.org>
2330
9aba6043
SM
2331 * gnutls.c (emacs_gnutls_deinit): New function.
2332 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2333 (Fgnutls_deinit, Fgnutls_boot): Use it.
2334
2335 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2336 (deactivate_process): Call emacs_gnutls_deinit.
2337
657d08d3
JB
23382011-10-27 Juanma Barranquero <lekktu@gmail.com>
2339
2340 * image.c (x_create_x_image_and_pixmap):
2341 * w32.c (sys_rename, w32_delayed_load):
2342 * w32font.c (fill_in_logfont):
2343 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2344
5430d399
JB
23452011-10-26 Juanma Barranquero <lekktu@gmail.com>
2346
2347 * w32fns.c (w32_default_color_map): New function,
2348 extracted from Fw32_default_color_map.
a7ef684b 2349 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2350
fe0055fa
PE
23512011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2354
e6346438
SM
23552011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2356
2357 * keyboard.c (test_undefined): New function (bug#9751).
2358 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2359
e112cc37
ET
23602011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2361
2362 * sysdep.c (init_sys_modes): Fix the check for the controlling
2363 terminal (Bug#6649).
2364
7b5d6677
EZ
23652011-10-20 Eli Zaretskii <eliz@gnu.org>
2366
2367 * dispextern.h (struct bidi_it): New member next_en_type.
2368
2369 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2370 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2371 current character, check also for next_en_type being WEAK_EN.
2372 (bidi_resolve_weak): Don't enter the expensive loop if the current
2373 position is before next_en_pos. Record the bidi type of the first
2374 non-ET, non-BN character we find, in addition to its position.
2375 (bidi_level_of_next_char): Invalidate next_en_type when
2376 next_en_pos is over-stepped.
2377
7da0b018
PE
23782011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2381 * editfns.c: Rewrite current-time-zone so that it invokes
2382 the equivalent of (format-time-string "%Z") to get the time zone name.
2383 This fixes a bug when the time zone name contains characters that
2384 need converting from the system time locale to Emacs internal format.
2385 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2386 that patch fixed format-time-string to do the conversion, but
2387 I forgot to fix current-time-zone.
2388 (format_time_string): New function, containing most of
2389 what Fformat_time_string used to contain.
2390 (Fformat_time_string): Rewrite in terms of format_time_string.
2391 This doesn't change this function's behavior.
2392 (current-time-zone): Rewrite to use format_time_string.
2393 This fixes the bug reported by Michael Schierl in
2394 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2395 Jason Rumney's 2007-06-07 change worked around this bug, but
2396 didn't fix it.
2397 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2398
8547b010
EZ
23992011-10-19 Eli Zaretskii <eliz@gnu.org>
2400
2401 * xdisp.c (start_display): If the character at POS is displayed
2402 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2403 (try_window_reusing_current_matrix): If a line ends in a display
2404 vector or the next line starts in a display vector, continue
2405 redrawing the window even though the character position of
2406 start_row was reached.
8547b010
EZ
2407 (Bug#9771, part 2)
2408
4e948d15
CY
24092011-10-18 Chong Yidong <cyd@gnu.org>
2410
2411 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2412 with nobreak-char-display too.
2413
4787455f
EZ
24142011-10-18 Eli Zaretskii <eliz@gnu.org>
2415
2416 Fix part 3 of bug#9771.
2417 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2418 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2419 non-neutral characters if the current character is a paragraph
2420 separator (a.k.a. Newline). This avoids running the same
2421 expensive loop twice, once when we consume the preceding newline
2422 and the other time when the line actually needs to be displayed.
2423 Avoid the loop when we see neutrals on the base embedding level
2424 following a character whose directionality is the same as the
2425 paragraph's. This avoids running the expensive loop when a line
2426 ends in a long sequence of neutrals, like control characters.
2427 Add assertion against STRONG_AL type. Slightly rearrange code
2428 that determines the type of a neutral given the first non-neutral
2429 that follows it.
2430 (bidi_level_of_next_char): Set next_en_pos to zero when
2431 invalidating its info.
2432
2c91f553
EZ
24332011-10-17 Eli Zaretskii <eliz@gnu.org>
2434
2435 * xdisp.c (push_display_prop): Determine whether to record string
2436 or buffer position by IT->string, not by IT->method. Allow
2437 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2438 (move_it_vertically_backward): Don't look for character position
2439 immediately after the newline when in a continuation line.
2440 (Bug#9771, part 1)
2c91f553 2441
c7b08b0d
MR
24422011-10-15 Martin Rudalics <rudalics@gmx.at>
2443
2444 * window.c (coordinates_in_window): Rewrite and delabelize
2445 vertical border check. (Bug#5357) (Bug#9618)
2446
6b02f655
SM
24472011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2448
2449 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2450 errors in XSetWindowBorder (bug#9310).
2451
81d40c92
DA
24522011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2453
2454 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2455 avoid crash when xmalloc overrun checking is enabled.
2456
d4172c3b
EZ
24572011-10-13 Eli Zaretskii <eliz@gnu.org>
2458
2459 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2460 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2461 cursor motion with <left> and <right> arrow keys.
2462
2463 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2464 some callers set that themselves.
2465
b00eea75
EZ
24662011-10-12 Eli Zaretskii <eliz@gnu.org>
2467
2468 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2469 display string and the previous row comes from the same string and
2470 is empty. (Bug#9739) (Bug#9738)
2471
8fe012c4
SM
24722011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2473
2474 * doc.c (get_doc_string): Encode file name (bug#9735).
2475
0074aef2
EZ
24762011-10-12 Eli Zaretskii <eliz@gnu.org>
2477
79beb178
EZ
2478 * bidi.c (bidi_level_of_next_char):
2479 * xdisp.c (get_visually_first_element): Remove old incorrect
2480 comments regarding the Unicode Line Separator character.
2481
0074aef2
EZ
2482 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2483
6e4b3fbe
DA
24842011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2485
2486 * alloc.c (Fgc_status): Do not access beyond zombies array
2487 boundary if nzombies > MAX_ZOMBIES.
2488 * alloc.c (dump_zombies): Add missing format specifier.
2489
0324f3af
PE
24902011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2491
b5525cac
PE
2492 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2493 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2494
0324f3af
PE
2495 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2496 Some packages use them to denote characters with modifiers.
2497
e9b5f888
AS
24982011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2499
2500 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2501 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2502 matching a pp-number. Rename parameter var to var1.
2503
127827c0
SM
25042011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2505
2506 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2507
c8fd3bd0
GM
25082011-10-08 Glenn Morris <rgm@gnu.org>
2509
2510 * callint.c (Fcall_interactively): Give a more explicit error for the
2511 'c' case with a non-character input. (Bug#8479)
2512
352ec8ff
EZ
25132011-10-08 Eli Zaretskii <eliz@gnu.org>
2514
03669ccb
EZ
2515 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2516 lines.
7061c986
EZ
2517 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2518 lines that are hscrolled on the left.
03669ccb 2519
352ec8ff
EZ
2520 * dispnew.c (buffer_posn_from_coords): Account for a possible
2521 presence of header-line. (Bug#4426)
2522
a66cfb1c
SM
25232011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2524
6b02f655
SM
2525 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2526 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2527
7c5ee88e
PE
25282011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2531 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2532 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2533 this makes Emacs dump core during garbage collection on rare
2534 occasions. sizeof is obviously inferior to offsetof here, so
2535 stick with offsetof.
2536 (GC_POINTER_ALIGNMENT): New macro.
2537 (mark_memory): Omit 3rd (offset) arg; caller changed.
2538 Don't assume EMACS_INT alignment is the same as pointer alignment.
2539
df1bbe5b
SM
25402011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2541
2542 * keyboard.c (read_key_sequence_remapped): New var.
2543 (read_key_sequence): Compute remapping in the right buffer.
2544 (command_loop_1): Use read_key_sequence's remapping directly.
2545
51553db6
SM
25462011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2547
32c1fffd
SM
2548 * dired.c (file_name_completion): Don't expand file name.
2549 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2550 before checking file name handler.
2551
51553db6
SM
2552 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2553 they've been requested explicitly (bug#9591).
2554
b6bd1599 25552011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2556
2557 * keymap.c (Fsingle_key_description): Use make_specified_string
2558 instead of build_string to build string from push_key_description.
2559 (Bug#5193)
2560
f701dc2a
PE
25612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2562
4222c55d
PE
2563 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2564 This fixes a Y2038 bug on 64-bit hosts.
2565 * buffer.c (reset_buffer):
2566 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2567 (Fclear_buffer_auto_save_failure):
2568 Use 0, not -1, to represent an unset failure time, since time_t
2569 might not be signed.
2570
f701dc2a
PE
2571 Remove dependency on glibc malloc internals.
2572 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2573 Move back here from lisp.h, but with their new implementations.
2574 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2575 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2576 * charset.c (charset_table_init): New static var.
2577 (syms_of_charset): Use it instead of xmalloc. This removes a
2578 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2579 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2580 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2581 Move back to alloc.c.
2582 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2583 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2584
9ceebf39
JD
25852011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2586
2587 * nsterm.m (windowDidResize): Call x_set_window_size only when
2588 ns_in_resize is true. Otherwise set pixelwidth/height and
2589 call change_frame_size (Bug#9628).
2590
cb993c58
PE
25912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2592
3930c88b
PE
2593 Port --enable-checking=all to Fedora 14 x86-64.
2594 * charset.c (syms_of_charset): Also account for glibc malloc's
2595 internal overhead when calculating the initial malloc maximum.
2596
cb993c58
PE
2597 Port --enable-checking=all to Fedora 14 x86.
2598 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2599 Move to lisp.h.
2600 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2601 (overrun_check_realloc, overrun_check_free):
2602 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2603 That way, xmalloc returns a properly-aligned pointer even if
2604 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2605 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2606 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2607 into account when calculating the initial malloc maximum.
2608 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2609 Move here from alloc.c, so that charset.c can use it too.
2610 Properly align; the old code wasn't right for common 32-bit hosts
2611 when configured with --enable-checking=all.
2612 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2613 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2614
31bed486
EZ
26152011-09-29 Eli Zaretskii <eliz@gnu.org>
2616
04c70788 2617 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2618 use EDOM.
2619
fbcaa2f3
EZ
26202011-09-28 Eli Zaretskii <eliz@gnu.org>
2621
2622 * xdisp.c (compute_display_string_end): If there's no display
2623 string at CHARPOS, return -1.
2624
2625 * bidi.c (bidi_fetch_char): When compute_display_string_end
2626 returns a negative value, treat the character as a normal
2627 character not covered by a display string. (Bug#9624)
2628
a239d4e9
JB
26292011-09-28 Juanma Barranquero <lekktu@gmail.com>
2630
2631 * lread.c (Fread_from_string): Fix typo in docstring.
2632
88652fd5
EZ
26332011-09-27 Eli Zaretskii <eliz@gnu.org>
2634
2635 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2636 newline, reseat the iterator instead of bidi-iterating there one
2637 character at a time. (Bug#9610)
32c1fffd
SM
2638 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2639 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2640
ed497dd4
AS
26412011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2642
2643 * lread.c (readevalloop): Use correct code for NBSP.
2644 (read1): Likewise. (Bug#9608)
2645
b2bf61aa
MA
26462011-09-25 Michael Albinus <michael.albinus@gmx.de>
2647
2648 * dbusbind.c (Fdbus_register_signal): When service is not
2649 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2650
32bbb17c
GM
26512011-09-25 Glenn Morris <rgm@gnu.org>
2652
2653 * buffer.c (truncate-lines): Doc fix.
2654
94e0933e
CY
26552011-09-24 Chong Yidong <cyd@stupidchicken.com>
2656
2657 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2658 (Fset_window_next_buffers): Doc fix.
2659
cddde921
GM
26602011-09-24 Glenn Morris <rgm@gnu.org>
2661
2662 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2663
1260aef1
PE
26642011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2665
25b4bfa0
PE
2666 Fix minor problems found by static checking.
2667 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2668 * indent.c (Fvertical_motion): Fix == vs = typo.
2669
e3cbd34b
EZ
26702011-09-24 Eli Zaretskii <eliz@gnu.org>
2671
a66cfb1c
SM
2672 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2673 Default value is now t. Doc fix.
6bf7006f 2674
e3cbd34b 2675 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2676 logic when moving up, not only when moving down. Fix the
e3cbd34b 2677 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2678 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2679
2680 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2681 CHARPOS is covered by a display string which includes newlines.
2682 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2683 is covered by a display string with embedded newlines.
2684
a3de0cbd
MA
26852011-09-24 Michael Albinus <michael.albinus@gmx.de>
2686
2687 * dbusbind.c (Fdbus_register_signal): Add match rule to
2688 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2689 (Fdbus_register_method, Vdbus_registered_objects_table):
2690 Fix docstring.
a3de0cbd 2691
b260039d
JM
26922011-09-24 Jim Meyering <meyering@redhat.com>
2693
32c1fffd 2694 do not ignore write error for any output size
b260039d
JM
2695 The previous change was incomplete.
2696 While it makes emacs --batch detect the vast majority of stdout
2697 write failures, errors were still ignored whenever the output size is
2698 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2699 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2700 && echo FAIL: ignored write error
2701 FAIL: ignored write error
2702 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2703 && echo FAIL: ignored write error
2704 FAIL: ignored write error
2705 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2706
8eca8a7c
AS
27072011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2708
2709 * emacs.c (Fkill_emacs): In noninteractive mode exit
2710 non-successfully if a write error occurred on stdout. (Bug#9574)
2711
3341db62
EZ
27122011-09-21 Eli Zaretskii <eliz@gnu.org>
2713
2714 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2715 the xassert test.
2716
2717 * dispextern.h (struct it): Update the comment documenting what
2718 can it->OBJECT be.
2719
8c203dbf
EZ
27202011-09-20 Eli Zaretskii <eliz@gnu.org>
2721
2722 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2723 a display string, extend search for cursor position to end of row.
2724 (find_row_edges): If the row ends in a newline from a display
2725 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2726 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2727 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2728 non-empty line. Fixes confusing cursor motion with arrow keys at
2729 the beginning of a line that starts with whitespace.
8c203dbf 2730
a4824228
LMI
27312011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2732
2733 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2734 (bug#9493).
2735
33ed493b
CY
27362011-09-18 Chong Yidong <cyd@stupidchicken.com>
2737
2738 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2739 boolean (Bug#9154).
2740
56cd55c8
EZ
27412011-09-18 Eli Zaretskii <eliz@gnu.org>
2742
2743 * xdisp.c (display_line): Record maximum and minimum buffer
2744 positions even if no glyphs were produced (e.g., by a zero-width
2745 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2746 buffer positions that will be removed from the glyph row because
2747 they don't fit.
c02dcedf
EZ
2748 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2749 column is beyond frame width: don't subtract 1 "pixel" when
2750 computing width of the stretch.
3e62b7e0
EZ
2751 (reseat_at_next_visible_line_start): Undo the change made on
2752 2011-09-17 that saved paragraph information and restored it after
2753 the call to `reseat'. (Bug#9545)
56cd55c8 2754
5ed99d36 27552011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2756
2757 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2758 and turn window cursor on if cleared (Bug#9415).
2759
5ed99d36 27602011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2761
2762 * search.c (boyer_moore): Take unibyte characters from pattern
2763 literally. (Bug#9458)
2764
9bade7b2
EZ
27652011-09-18 Eli Zaretskii <eliz@gnu.org>
2766
2767 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2768
e5e9d610
PE
27692011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2770
87e4427a
PE
2771 Fix minor problem found by static checking.
2772 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2773 initialized, to pacify gcc -Wuninitialized.
2774
e5e9d610
PE
2775 * fileio.c: Report proper errno when syscall falls.
2776 (Finsert_file_contents): Save and restore errno,
2777 so that report_file_error outputs the correct diagnostic.
2778 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2779
a1674f0b
EZ
27802011-09-18 Eli Zaretskii <eliz@gnu.org>
2781
2782 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2783
fbfb6dd4
EZ
27842011-09-17 Eli Zaretskii <eliz@gnu.org>
2785
2786 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2787 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2788
bb187662
EZ
27892011-09-17 Eli Zaretskii <eliz@gnu.org>
2790
1137e8b8 2791 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2792 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2793
2794 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2795 (bidi_find_paragraph_start): Search back for paragraph beginning
2796 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2797 (bidi_move_to_visually_next): Only trigger paragraph-related
2798 computations when the last character is a newline or at EOB, not
2799 just any NEUTRAL_B. (Bug#9470)
2800
bb187662
EZ
2801 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2802 truncated lines if point is covered by a display string. (Bug#9524)
2803
2e621251
PE
28042011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2807 (cons_to_x_long): New function.
2808 (lisp_data_to_selection_data): Use it. Correct the test for
2809 short-versus-long data; it was negated. Break out of vector
2810 loop, for efficiency, when a long datum is discovered.
2811
91a15bc6
SM
28122011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2813
2814 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2815
b41c3a35
EZ
28162011-09-16 Eli Zaretskii <eliz@gnu.org>
2817
2818 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2819 GCC PR/17406) by declaring this function with external scope.
2820
7812ba2d
PE
28212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2824 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2825
cf7edc2a
AS
28262011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2827
2828 * editfns.c (Fformat): Correctly handle text properties on "%%".
2829
bd01620e
EZ
28302011-09-15 Eli Zaretskii <eliz@gnu.org>
2831
2832 * xterm.c (x_draw_composite_glyph_string_foreground):
2833 * w32term.c (x_draw_composite_glyph_string_foreground):
2834 * term.c (encode_terminal_code):
2835 * composite.c (composition_update_it, get_composition_id):
2836 * xdisp.c (get_next_display_element)
2837 (fill_composite_glyph_string): Add comments about special meaning
2838 of TAB characters in a composition.
2839
a02719a3
PE
28402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2843 This occurs when processing a multibyte format.
2844 Problem reported by Wolfgang Jenker.
a02719a3 2845
72589a3c
JB
28462011-09-15 Johan Bockgård <bojohan@gnu.org>
2847
2848 * xdisp.c (try_cursor_movement): Only check for exact match if
2849 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2850
1c14176c
PE
28512011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 Remove unused external symbols.
2854 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2855 * xdisp.c (calc_pixel_width_or_height): Now static.
2856 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2857 * indent.c (check_display_width):
2858 * w32term.c: Fix comment to match code.
2859 * xterm.c, xterm.h (x_catching_errors): Remove.
2860
d2eea5b5
PE
28612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2862
2863 * xselect.c: Use signed conversions more consistently (Bug#9498).
2864 (selection_data_to_lisp_data): Assume incoming selection data are
2865 signed integers, not unsigned. This is to be consistent with
2866 outgoing selection data, which was modified to use signed integers
2867 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2868 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2869 expects long, not unsigned long.
2870
46888499
EZ
28712011-09-14 Eli Zaretskii <eliz@gnu.org>
2872
2873 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2874 computation of loop end. Reported by Johan Bockgård
2875 <bojohan@gnu.org>.
2876
ef8ef9fb
CY
28772011-09-13 Chong Yidong <cyd@stupidchicken.com>
2878
2879 * frame.c (Fother_visible_frames_p): Function deleted.
2880
fa819fed
EZ
28812011-09-12 Eli Zaretskii <eliz@gnu.org>
2882
2883 * indent.c (compute_motion): Process display vector front to back
2884 rather than the other way around. (Bug#2496)
2885
2ba8e008
SM
28862011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2887
2888 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2889
20f53c69
CY
28902011-09-11 Chong Yidong <cyd@stupidchicken.com>
2891
2892 * minibuf.c (Fread_from_minibuffer): Doc fix.
2893
d562d7a4
EZ
28942011-09-11 Eli Zaretskii <eliz@gnu.org>
2895
2896 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2897 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2898
1c4d7f3d
LMI
28992011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2900
2901 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2902 value for non-existent files.
2903
b885bf36
EZ
29042011-09-11 Eli Zaretskii <eliz@gnu.org>
2905
2906 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2907 set its "size" to -1. This will set the modtime_size field of
2908 the corresponding buffer to -1, which is what
2909 verify-visited-file-modtime expects for files that do not exist.
2910 (Bug#9139)
2911
6612f0bf
PE
29122011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2915 here ...
2916 * lisp.h: ... from here. push_key_description is no longer
2917 defined in keyboard.c, so its declaration should not be in
2918 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2919 logically belongs with push_key_description.
2920
dfb3f755
PE
29212011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 * buffer.h: Include <sys/types.h> instead of <time.h>.
2924 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2925 Problem reported by Herbert J. Skuhra.
2926
3134906c
LMI
29272011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2928
2929 * xml.c (parse_region): Make the parsing work for
2930 non-comment-starting XML files again (bug#9144).
2931
8d903f4e
AS
29322011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2933
2934 * image.c (gif_load): Fix calculation of bottom and right corner.
2935 (Bug#9468)
2936
80ad64f4
EZ
29372011-09-10 Eli Zaretskii <eliz@gnu.org>
2938
2939 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2940 redisplay in small windows.
2941
208a048d
EZ
29422011-09-09 Eli Zaretskii <eliz@gnu.org>
2943
2944 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2945
9b1c252e
MR
29462011-09-08 Martin Rudalics <rudalics@gmx.at>
2947
2948 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2949 Operate on live windows only.
2950
2949f33b
JB
29512011-09-08 Juanma Barranquero <lekktu@gmail.com>
2952
2953 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2954
e08dcafd
EZ
29552011-09-07 Eli Zaretskii <eliz@gnu.org>
2956
2957 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2958 only under bidi iteration.
2959
115b96bd
JD
29602011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2961
2962 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2963
c8199d0f
PE
29642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2965
2966 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2967 Without this fix, the command to link temacs failed due to an
2968 undefined symbol __builtin_isnan. This is because
2969 /usr/include/iso/math_c99.h #defines isnan(x) to
2970 __builtin_isnan(x), but the bundled gcc, which identifies itself
2971 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2972 a __builtin_isnan.
2973 * floatfns.c (isnan): #undef, and then #define to a clone of
2974 what's in data.c.
2975 (Fisnan): Always define, since it's always available now.
2976 (syms_of_floatfns): Always define isnan at the Lisp level.
2977
e39b275c 29782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2979
2980 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2981
b2db44d9 29822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2983
f4af5137 2984 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2985 The previous code assumed that file offsets (off_t values) fit in
2986 EMACS_INT variables, which is not true on typical 32-bit hosts.
2987 The code messed up by falsely reporting buffer overflow in cases
2988 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2989 when "big" contains more than 2**29 bytes, even though this
2990 inserts just one byte and does not overflow the buffer.
2991 (Finsert_file_contents): Store file offsets as off_t
2992 values, not as EMACS_INT values. Check for overflow when
2993 converting between EMACS_INT and off_t. When checking for
2994 buffer overflow or for overlap, take the offsets into account.
2995 Don't use EMACS_INT for small values where int suffices.
2996 When checking for overlap, fix a typo: ZV was used where
2997 ZV_BYTE was intended.
2998 (Fwrite_region): Don't assume off_t fits into 'long'.
2999 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3000
ecfc0a49
MA
30012011-09-05 Michael Albinus <michael.albinus@gmx.de>
3002
3003 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3004
6511acf2 30052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3006
0999621a 3007 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3008
3009 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3010 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3011 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3012 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3013 (modify_event_symbol): Do not assume that the length of
3014 name_alist_or_stem is safe to alloca and fits in int.
3015 (Fexecute_extended_command): Likewise for function name and binding.
3016 (Frecursion_depth): Wrap around reliably on integer overflow.
3017 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3018 since some callers pass EMACS_INT values.
3019 (Fsingle_key_description): Don't crash if symbol name contains more
3020 than MAX_ALLOCA bytes.
3021 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3022 (get_minibuffer): Arg is now EMACS_INT, not int.
3023 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3024 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3025 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3026
2be7d702
PE
3027 * dbusbind.c (signature_cat): New function.
3028 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3029 Do not overrun buffer; instead, report string overflow.
3030
9d1df220
PE
3031 * dispnew.c (add_window_display_history): Don't overrun buffer.
3032 Truncate instead; this is OK since it's just a log.
3033
33ef5c64
PE
3034 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3035 even if the time zone offset is outlandishly large.
3036 Don't mishandle offset == INT_MIN.
3037
66c6fdd5
PE
3038 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3039 when creating daemon; the previous buffer-overflow check was incorrect.
3040
d749b01b
PE
3041 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3042 which has the guts of the old verror function.
3043
b5cd1905
PE
3044 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3045 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3046
6e1a67fb
PE
3047 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3048 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3049 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3050 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3051 length of string rather than counting it via multiple sprintfs;
3052 that's simpler and more reliable.
c21721cc
PE
3053 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3054 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3055 sprintf, in case result does not fit in int.
3056
c57b67fc
PE
3057 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3058 (fontset_from_font): Print it.
3059
8a401434
PE
3060 * frame.c (tty_frame_count): Now printmax_t, not int.
3061 (make_terminal_frame, set_term_frame_name): Print it.
3062 (x_report_frame_params): In X, window IDs are unsigned long,
3063 not signed long, so print them as unsigned.
3064 (validate_x_resource_name): Check for implausibly long names,
3065 and don't assume name length fits in 'int'.
3066 (x_get_resource_string): Don't blindly alloca invocation name;
3067 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3068 not fit in int.
3069
6e1a67fb
PE
3070 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3071 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3072 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3073
0df02bf3
PE
3074 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3075 Use esprintf, not sprintf, in case result does not fit in int.
3076
48e30793
PE
3077 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3078 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3079 it as a large positive number.
3080 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3081 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3082
a66ff6d8
PE
3083 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3084 in case result does not fit in int.
3085
aca216ff
PE
3086 * print.c (float_to_string): Detect width overflow more reliably.
3087 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3088 buffer overrun. Don't assume list length fits in 'int'. Treat
3089 print length of 0 as 0, not as infinity; to be consistent with other
3090 uses of print length in this function. Don't overflow print length
3091 index. Don't assume hash table size fits in 'long', or that
3092 vectorlike size fits in 'unsigned long'.
3093
31c286f7
PE
3094 * process.c (make_process): Use printmax_t, not int, to format
3095 process-name gensyms.
3096
55e5faa1
PE
3097 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3098
80f2e268
PE
3099 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3100 to avoid potential buffer overrun.
3101
670741ab
PE
3102 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3103 if X resource line is longer than 512 bytes.
3104
b7163a50
PE
3105 * xfns.c (x_window): Make sprintf buffer a bit bigger
3106 to avoid potential buffer overrun.
3107
ae58ff1f
PE
3108 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3109
c43c8a6a
PE
3110 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3111
3f8236f4
PE
31122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3113
53e9fe90 3114 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3115 Without these, Emacs silently mishandles large integers sometimes.
3116 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3117 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3118
6511acf2
PE
3119 * xdisp.c (try_window_id): Check Emacs fixnum range before
3120 converting to 'int'.
806add1d 3121
6511acf2 3122 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3123 Check that an Emacs fixnum is in range before assigning it to 'int'.
3124 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3125 values converted from Emacs fixnums.
3126 (Frecenter): Don't wrap around a line count if it is out of 'int'
3127 range; instead, treat it as an extreme value.
3128 (Fset_window_configuration, compare_window_configurations):
3129 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3130
6511acf2
PE
3131 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3132 that can exceed INT_MAX. Check that EMACS_INT value is in range
3133 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3134 (match_limit): Don't assume that a fixnum can fit in 'int'.
3135
6511acf2 3136 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3137 exceed INT_MAX.
3138
6511acf2 3139 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3140 (Fvertical_motion): Don't wrap around LINES values that don't fit
3141 in 'int'. Instead, treat them as extreme values. This is good
3142 enough for windows, which can't have more than INT_MAX lines anyway.
3143
fcb901a7
LMI
31442011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3145
0f2f6b6d
LMI
3146 * Require libxml/parser.h to avoid compilation warning.
3147
fcb901a7
LMI
3148 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3149
3150 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3151 since this reportedly can destroy thread storage.
3152
6e20a0d4
CY
31532011-08-30 Chong Yidong <cyd@stupidchicken.com>
3154
3155 * syntax.c (find_defun_start): Update all cache variables if
3156 exiting early (Bug#9401).
3157
148ae00e
EZ
31582011-08-30 Eli Zaretskii <eliz@gnu.org>
3159
f6cfbd8f
EZ
3160 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3161
148ae00e
EZ
3162 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3163 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3164 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3165
3166 * term.c (tty_append_glyph): New function.
3167 (produce_stretch_glyph): Static function and its prototype deleted.
3168
a66cfb1c
SM
3169 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3170 Add prototypes.
148ae00e 3171
c4a07a4c
PE
31722011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3173
3174 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3175 when checking :margin (Bug#9390).
3176 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3177 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3178 so that the name doesn't mislead. All uses changed.
3179
6bc8cd65
JB
31802011-08-28 Johan Bockgård <bojohan@gnu.org>
3181
3182 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3183 set_tty_hooks.
3184
dca4927e
EZ
31852011-08-27 Eli Zaretskii <eliz@gnu.org>
3186
3187 * xdisp.c (move_it_to): Don't bail out early when reaching
3188 position beyond to_charpos, if we are scanning backwards.
3189 (move_it_vertically_backward): When DY == 0, make sure we get to
3190 the first character in the line after the newline.
3191
f2cad773
PE
31922011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3195 (ccl_driver): Do not generate an out-of-range pointer.
3196 (Fccl_execute_on_string): Remove unnecessary check for
3197 integer overflow, noted by Stefan Monnier in
3198 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3199 Remove a FIXME that didn't need fixing.
3200 Simplify the newly-introduced buffer reallocation code.
3201
0cae2cdb
JB
32022011-08-27 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3205
5fc295a4 32062011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3207
70c60eb2 3208 Integer and memory overflow issues (Bug#9196).
726e0ab1 3209
d31850da
PE
3210 * doc.c (get_doc_string): Rework so that
3211 get_doc_string_buffer_size is the actual buffer size, rather than
3212 being 1 less than the actual buffer size; this makes xpalloc more
3213 convenient.
3214
a69fbedb
PE
3215 * image.c (x_allocate_bitmap_record, cache_image):
3216 * xselect.c (Fx_register_dnd_atom):
3217 Simplify previous changes by using xpalloc.
3218
fe5c5d37
PE
3219 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3220 since either will do and ptrdiff_t is convenient with xpalloc.
3221
0065d054
PE
3222 * charset.c (charset_table_size)
3223 (struct charset_sort_data.priority): Now ptrdiff_t.
3224 (charset_compare): Don't overflow if priorities differ greatly.
3225 (Fsort_charsets): Don't assume list length fits in int.
3226 Check for size-calculation overflow when allocating sort data.
3227 (syms_of_charset): Allocate an initial charset table that is
3228 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3229
3230 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3231
3232 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3233 The actual value is always <= INT_MAX, and leaving it unsigned made
3234 overflow checking harder.
3235
3236 * dispextern.h (struct glyph_matrix.rows_allocated)
3237 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3238 with xpalloc. The values are still always <= INT_MAX.
3239
3240 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3241
3242 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3243 (SAFE_NALLOCA): New macro.
3244
3245 * region-cache.c (struct boundary.pos, find_cache_boundary)
3246 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3247 (set_cache_region, invalidate_region_cache)
3248 (revalidate_region_cache, know_region_cache, region_cache_forward)
3249 (region_cache_backward, pp_cache):
3250 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3251 so that ptrdiff_t * can be passed to xpalloc.
3252 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3253 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3254 (pp_cache): Don't assume cache_len fits in int.
3255 * region-cache.h: Adjust extern decls to match.
3256
3257 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3258 EMACS_INT, since either will do, for xpalloc.
3259
3260 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3261 (xnmalloc, xnrealloc, xpalloc): New functions.
3262
726e0ab1
PE
3263 * bidi.c (bidi_shelve_header_size): New constant.
3264 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3265 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3266
51f30bc5 3267 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3268 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3269 (overlay_strings):
3270 Don't update size of array until after memory allocation succeeds,
3271 because xmalloc/xrealloc may not return.
0065d054
PE
3272 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3273 now that we have proper integer overflow checking.
3274 (record_overlay_string, overlay_strings): Catch overflows when
3275 calculating size of overlay_str_buf.
726e0ab1 3276
0065d054
PE
3277 * callproc.c (Fcall_process): Check for size overflow when
3278 calculating size of args2.
3279 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3280 Normally we prefer signed values, but sticking with ptrdiff_t would
3281 require adding more-complicated checks.
726e0ab1
PE
3282
3283 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3284 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3285 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3286 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3287
3288 * character.c (Fstring): Check for size-calculation overflow.
3289
3290 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3291 unnecessary integer overflow. Check for size overflow.
3292 (encode_coding_object): Don't update size until xmalloc succeeds.
3293
3294 * composite.c (get_composition_id): Check for overflow in glyph
3295 length calculations.
3296
3297 Integer and memory overflow fixes for display code.
3298 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3299 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3300 (scrolling_window): Check for overflow in size calculations.
3301 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3302 Don't assume glyph table len fits in int.
3303 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3304 (row_table_size): Now ptrdiff_t, not int.
3305 (scrolling_window): Avoid overflow in size calculations.
3306 Don't update size until allocation succeeds.
3307 * fns.c (concat): Check for overflow in size calculations.
3308 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3309 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3310 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3311
3312 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3313 (get_doc_string): Check for size calculation overflow.
3314 Don't update size until allocation succeeds.
3315 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3316 EMACS_INT, where ptrdiff_t will do.
3317 (Fsubstitute_command_keys): Check for string overflow.
3318
3319 * editfns.c (set_time_zone_rule): Don't assume environment length
3320 fits in int.
3321 (message_length): Now ptrdiff_t, not int.
3322 (Fmessage_box): Don't update size until allocation succeeds.
3323 Don't assume message length fits in int.
3324 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3325
0065d054
PE
3326 * emacs.c (main): Do not reallocate argv, since there is a null at
3327 the end that can be overwritten, and this way there's no need to
3328 worry about size-calculation overflow.
3329 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3330
3331 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3332 alloc succeeds.
3333 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3334
3335 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3336 (x_set_scroll_bar_width, x_figure_window_size):
3337 Check for integer overflow.
3338 (x_set_alpha): Do not assume XINT fits in int.
3339
3340 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3341 This is for the members text_lines, text_cols, total_lines, total_cols,
3342 where the system imposes an 'int' limit.
3343
3344 * fringe.c (Fdefine_fringe_bitmap):
3345 Don't update size until alloc works.
3346
3347 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3348 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3349
3350 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3351 Check for size-calculation overflow.
3352 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3353 do, as we prefer signed integers.
3354 (id_to_widget.max_size, id_to_widget.used)
3355 (xg_store_widget_in_map, xg_remove_widget_from_map)
3356 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3357 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3358 Use and return ptrdiff_t, not int.
3359 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3360 * gtkutil.h: Change prototypes to match the above.
3361
3362 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3363 are duplicate now that they've been promoted to lisp.h.
3364 (x_allocate_bitmap_record, x_alloc_image_color)
3365 (make_image_cache, cache_image, xpm_load):
3366 Don't update size until alloc is done.
3367 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3368 (x_detect_edges):
3256efce 3369 Check for size calculation overflow.
726e0ab1
PE
3370 (ct_colors_allocated_max): New constant.
3371 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3372 overflow.
3256efce 3373
726e0ab1
PE
3374 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3375 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3376 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3377 Use ptrdiff_t, not int, to count maps.
3378 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3379 calculations. Don't update size until allocation succeeds.
3380 Redo calculations to avoid overflow.
726e0ab1
PE
3381 * keyboard.h: Change prototypes to match the above.
3382
3383 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3384 to count maps.
3385 (current_minor_maps): Check for size calculation overflow.
3386 * keymap.h: Change prototypes to match the above.
3387
3388 * lread.c (read1, init_obarray): Don't update size until alloc done.
3389
3390 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3391 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3392
726e0ab1
PE
3393 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3394 Now ptrdiff_t, not int.
3395 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3396 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3397
3398 * process.c (Fnetwork_interface_list): Check for overflow
3399 in size calculation.
3400
3401 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3402
3403 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3404 overflow. Don't bother calling xmalloc when xrealloc will do.
3405
3406 * search.c (Freplace_match): Check for size calculation overflow.
3407 (Fset_match_data): Don't assume list lengths fit in 'int'.
3408
3409 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3410 for command line length. Do not attempt to address one before the
3411 beginning of an array, as that's not portable.
3412
3413 * term.c (max_frame_lines): Remove; unused.
3414 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3415 not int.
3416 (encode_terminal_code, calculate_costs): Check for size
3417 calculation overflow.
3418 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3419 table lengths and related sizes. Don't update size until alloc
3420 done. Redo calculations to avoid overflow.
3421 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3422
3423 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3424 subtracting pointers.
3425 (gobble_line): Check for overflow more carefully. Don't update size
3426 until alloc done.
3427
3428 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3429 Don't update size until alloc done.
3430 Redo size calculations to avoid overflow.
3431 Check for size calculation overflow.
0065d054 3432 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3433
3434 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3435 Use ptrdiff_t, not int, for sizes.
3436 (store_mode_line_noprop_char): Don't update size until alloc done.
3437
0065d054
PE
3438 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3439 Use ptrdiff_t, not int, for sizes.
3440 (Finternal_make_lisp_face, cache_face):
3441 Check for size calculation overflow.
3442 (cache_face): Treat size calculation overflows as if they were
3443 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3444
3445 * xfns.c (x_encode_text, x_set_name_internal)
3446 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3447 sizes, since they can exceed INT_MAX in size. Check for size
3448 calculation overflow.
3449
0065d054
PE
3450 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3451 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3452 Don't update size until alloc done.
3453
0065d054 3454 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3455 as sprintf is limited to int lengths.
1d526e2f 3456
252c5ee1
PE
3457 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3458 (X_LONG_MIN): New macros.
864d7ce7
PE
3459 Use them to make the following changes clearer.
3460 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3461 This change doesn't affect the value now, but it may help remind
3462 future maintainers not to raise the value too much later.
3463 (SELECTION_QUANTUM): Remove, replacing with ...
3464 (selection_quantum): ... new function, which avoids overflow.
3465 All uses changed.
3466 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3467 assumption that selection length fits in 'int'.
3468 (x_reply_selection_request, x_handle_selection_request)
3469 (x_get_window_property, receive_incremental_selection)
3470 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3471 (lisp_data_to_selection_data, clean_local_selection_data):
3472 Use ptrdiff_t, not int, to record length of selection.
3473 (x_reply_selection_request, x_get_window_property)
3474 (receive_incremental_selection, x_property_data_to_lisp):
3475 Redo calculations to avoid overflow.
3476 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3477 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3478 something.
3479 (x_get_window_property, receive_incremental_selection)
3480 (lisp_data_to_selection_data, x_property_data_to_lisp):
3481 Check for size-calculation overflow.
3482 (x_get_window_property, receive_incremental_selection)
3483 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3484 Don't store size until memory allocation succeeds.
3485 (x_get_window_property): Plug memory leak on memory exhaustion.
3486 Don't double-block input; malloc is safe here. Don't assume 2**34
3487 - 4 fits in unsigned long. Add an xassert to check
3488 XGetWindowProperty overflow. Be more careful about overflow
3489 calculations, and distinguish size from memory overflow better.
3490 (receive_incremental_selection): When tracing, don't assume
3491 unsigned int is less than INT_MAX.
3492 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3493 harmful) conversions of unsigned short to int.
3494 (lisp_data_to_selection_data): Don't assume that integers
3495 in the range -65535 through -1 fit in an X unsigned short.
3496 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3497 result parameters unless successful. Rely on cons_to_unsigned
3498 to report problems with elements; the old code wasn't right anyway.
3499 (x_check_property_data): Check for int overflow; we cannot use
3500 a wider type due to X limits.
3501 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3502
726e0ab1 3503 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3504
0065d054
PE
3505 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3506 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3507 (x_color_cells): Don't store size until memory allocation succeeds.
3508 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3509 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3510 (x_term_init): Don't assume length fits in int (sprintf is limited
3511 to int size).
bc18e09d 3512
ebfa62c0
PE
3513 Use ptrdiff_t for composition IDs.
3514 * character.c (lisp_string_width):
3515 * composite.c (composition_table_size, n_compositions)
3516 (get_composition_id, composition_gstring_from_id):
3517 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3518 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3519 * window.c (Frecenter):
3520 Use ptrdiff_t, not int, for composition IDs.
3521 * composite.c (get_composition_id): Check for integer overflow.
3522 * composite.h: Adjust prototypes to match the above changes.
3523
d3411f89
PE
3524 Use ptrdiff_t for hash table indexes.
3525 * category.c (hash_get_category_set):
3526 * ccl.c (ccl_driver):
3527 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3528 * coding.c (coding_system_charset_list, detect_coding_system):
3529 * coding.h (struct coding_system.id):
3530 * composite.c (get_composition_id, gstring_lookup_cache):
3531 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3532 * image.c (xpm_get_color_table_h):
3533 * lisp.h (hash_lookup, hash_put):
3534 * minibuf.c (Ftest_completion):
3535 Use ptrdiff_t for hash table indexes, not int (which is too
3536 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3537 32-bit --with-wide-int hosts).
3538
e097a6fa
PE
3539 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3540 Add a FIXME comment about memory leaks.
3541 (syms_of_charset): Don't assume xmalloc returns.
3542
5637687f
PE
3543 Don't assume that stated character widths fit in int.
3544 * character.c (Fchar_width, c_string_width, lisp_string_width):
3545 * character.h (CHAR_WIDTH):
3546 * indent.c (MULTIBYTE_BYTES_WIDTH):
3547 Use sanitize_char_width to avoid undefined and/or bad behavior
3548 with outlandish widths.
a66cfb1c 3549 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3550 now that we have two such functions. All uses changed.
3551 (sanitize_char_width): New inline function.
3552
a2271ba2
PE
3553 Don't assume that tab-width fits in int.
3554 * character.h (sanitize_width): New inline function.
3555 (SANE_TAB_WIDTH): New macro.
3556 (ASCII_CHAR_WIDTH): Use it.
3557 * indent.c (sane_tab_width): Remove. All uses replaced by
3558 SANE_TAB_WIDTH (current_buffer).
3559 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3560
18c52557
PE
3561 * fileio.c: Integer overflow issues with file modes.
3562 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3563
caeeedc1
PE
3564 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3565 Remove unreachable code.
3566 (read_hex, load_charset_map_from_file): Check for integer overflow.
3567
6df6ae42 3568 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3569 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3570 (x_send_scroll_bar_event): Likewise. Check that the size does not
3571 exceed limits imposed by XClientMessageEvent, as well as the usual
3572 ptrdiff_t and size_t limits.
3573
b13995db
PE
3574 * keyboard.c: Overflow, signedness and related fixes.
3575 (make_lispy_movement): Use same integer type in forward decl
3576 that is used in the definition.
3577 (read_key_sequence, keyremap_step):
3578 Change bufsize argument back to int, undoing my 2011-03-30 change.
3579 We prefer signed types, and int is wide enough here.
3580 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3581 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3582 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3583 length, not size_t. Use ptrdiff_t for index, not int.
3584 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3585 possibility of integer overflow.
3586
13464394
PE
3587 Overflow, signedness and related fixes for images.
3588
3589 * dispextern.h (struct it.stack[0].u.image.image_id)
3590 (struct_it.image_id, struct image.id, struct image_cache.size)
3591 (struct image_cache.used, struct image_cache.ref_count):
3592 * gtkutil.c (update_frame_tool_bar):
3593 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3594 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3595 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3596 * nsmenu.m (update_frame_tool_bar):
3597 * xdisp.c (calc_pixel_width_or_height):
3598 * xfns.c (image_cache_refcount):
3599 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3600 on typical 64-bit hosts.
3601
3602 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3603 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3604 Omit unnecessary casts to int.
3605 (parse_image_spec): Check that integers fall into 'int' range
3606 when the callers expect that.
3607 (image_ascent): Redo ascent calculation to avoid int overflow.
3608 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3609 (lookup_image): Remove unnecessary tests.
3610 (xbm_image_p): Locals are now of int, not EMACS_INT,
3611 since parse_image_check makes sure they fit into int.
3612 (png_load, gif_load, svg_load_image):
3613 Prefer int to unsigned where either will do.
3614 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3615 old tiff_error_handler and tiff_warning_handler.
3616 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3617 stack buffer overflows. It uses only the features of vsnprintf
3618 that are common to both POSIX and native Microsoft.
3619 (tiff_error_handler, tiff_warning_handler): Use it.
3620 (tiff_load, gif_load, imagemagick_load_image):
3621 Don't assume :index value fits in 'int'.
3622 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3623 (imagemagick_load_image): Check that crop parameters fit into
3624 the integer types that MagickCropImage accepts. Don't assume
3625 Vimagemagick_render_type has a nonnegative value. Don't assume
3626 size_t fits in 'long'.
3627 (gs_load): Use printmax_t to print the widest integers possible.
3628 Check for integer overflow when computing image height and width.
3629
c11821d4
EZ
36302011-08-26 Eli Zaretskii <eliz@gnu.org>
3631
3632 * xdisp.c (redisplay_window): Don't force window start if point
3633 will be invisible in the resulting window. (Bug#9324)
3634
0c95fcf7
EZ
36352011-08-25 Eli Zaretskii <eliz@gnu.org>
3636
3637 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3638 the display spec is of the form `(space ...)'.
3639 (handle_display_spec): Return the value returned by
3640 handle_single_display_spec, not just 1 or zero.
3641 (handle_single_display_spec): If the display spec is of the form
3642 `(space ...)', and specifies display in the text area, return 2
3643 rather than 1.
fee65a97 3644 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3645 accurately, and prefer exact match for point under bidi.
3646 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3647
3648 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3649 into disp_prop; all users changed.
3650
3651 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3652 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3653 for the text covered by the display property.
3654
e4ed06f1
CY
36552011-08-25 Chong Yidong <cyd@stupidchicken.com>
3656
3657 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3658 Change return value to nil.
3659 (Frecord_buffer): Delete unused function.
3660
f67cdd7f
EZ
36612011-08-24 Eli Zaretskii <eliz@gnu.org>
3662
5980d4c6
EZ
3663 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3664 buffers, return left-to-right.
8610fe8b
EZ
3665 (set_cursor_from_row): Consider candidate row a win if its glyph
3666 represents a newline and point is on that newline. Fixes cursor
3667 positioning on the newline at EOL of R2L text within L2R
3668 paragraph, and vice versa.
3669 (try_cursor_movement): Check continued rows, in addition to
3670 continuation rows. Fixes unwarranted scroll when point enters a
3671 continued line of R2L text within an L2R paragraph, or vice versa.
3672 (cursor_row_p): Consider the case of point being equal to
3673 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3674 from the end of a short line to the beginning of a continued line
3675 of R2L text within L2R paragraph.
3676 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3677 composed characters.
5980d4c6 3678
f67cdd7f
EZ
3679 * bidi.c (bidi_check_type): Use xassert.
3680 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3681 members.
3682
bca633fb
EZ
36832011-08-23 Eli Zaretskii <eliz@gnu.org>
3684
3685 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3686 a character.
3687
4a5885a7
CY
36882011-08-23 Chong Yidong <cyd@stupidchicken.com>
3689
3690 * nsfont.m (ns_otf_to_script): Fix typo.
3691
0902a04e
KH
36922011-08-22 Kenichi Handa <handa@m17n.org>
3693
3694 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3695 extra slot even if the purpose is char-code-property-table.
3696
1a2e6670
EZ
36972011-08-23 Eli Zaretskii <eliz@gnu.org>
3698
8ddde651
EZ
3699 * xdisp.c (redisplay_window): When computing centering_position,
3700 account for the height of the header line. (Bug#8874)
3701
425cc014
EZ
3702 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3703 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3704 candidate is selected by the mouse, and that candidate has a
3705 composed character under the mouse.
3706
1a2e6670
EZ
3707 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3708 coordinates reported by pos-visible-in-window-p for a composed
3709 character in column zero.
3710
8b76d6f8
SM
37112011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3712
3713 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3714
dac347dd
EZ
37152011-08-22 Eli Zaretskii <eliz@gnu.org>
3716
3717 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3718 consider it a hit if to_charpos is anywhere in the range of the
3719 composed buffer positions.
3720
e013fb34
CY
37212011-08-22 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * image.c (gif_load): Don't assume that each subimage has the same
3724 dimensions as the base image. Handle disposal method that is
3725 "undefined" by the gif spec (Bug#9335).
3726
bd1ba3e8
CY
37272011-08-20 Chong Yidong <cyd@stupidchicken.com>
3728
3729 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3730 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3731
54a1215b
EZ
37322011-08-19 Eli Zaretskii <eliz@gnu.org>
3733
823564e5
EZ
3734 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3735 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3736 from an Org mode buffer to a Speedbar frame.
3737
54a1215b
EZ
3738 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3739 a composition, take its buffer position from IT->cmp_it.charpos.
3740 Fixes cursor positioning at the beginning of a line that begins
3741 with a composed character.
3742
9778ebcc
EZ
37432011-08-18 Eli Zaretskii <eliz@gnu.org>
3744
0be6ee06
EZ
3745 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3746 character bidirectional type, use STRONG_L instead. Fixes crashes
3747 in a buffer produced by `describe-categories'.
3748
9778ebcc
EZ
3749 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3750 members before the level stack, so they would be saved and
3751 restored when copying iterator state. Fixes incorrect reordering
3752 around TABs covered by display properties.
3753
156bffbe
AS
37542011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3755
6b02f655 3756 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3757
72ad093b
CY
37582011-08-17 Chong Yidong <cyd@stupidchicken.com>
3759
3760 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3761 (internal_condition_case_2, internal_condition_case_n):
3762 Remove unnecessary aborts (Bug#9081).
72ad093b 3763
35774242
EZ
37642011-08-17 Eli Zaretskii <eliz@gnu.org>
3765
3766 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3767 has no `load' handler, try opening the file locally. (Bug#9311)
3768
db76dd85
KB
37692011-08-16 Ken Brown <kbrown@cornell.edu>
3770
3771 * gmalloc.c: Expand comment.
3772
b215eee5
EZ
37732011-08-16 Eli Zaretskii <eliz@gnu.org>
3774
3775 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3776 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3777
a4579d33
KB
37782011-08-16 Ken Brown <kbrown@cornell.edu>
3779
3780 Fix memory allocation problems in Cygwin build (Bug#9273).
3781
3782 * unexcw.c ( __malloc_initialized): Declare external variable.
3783 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3784
8b76d6f8
SM
3785 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3786 New variables.
a4579d33
KB
3787 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3788 dumped emacs.
3789 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3790 in the static heap.
3791 [CYGWIN] (special_realloc): New function.
3792 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3793 requests to realloc storage in the static heap.
3794
3ebec551
PE
37952011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3796
3797 * bidi.c (bidi_initialize): Remove unused local.
3798
9fd8be00
EZ
37992011-08-15 Eli Zaretskii <eliz@gnu.org>
3800
6b02f655
SM
3801 * bidimirror.h:
3802 * biditype.h: Remove file.
3803 * makefile.w32-in ($(BLD)/bidi.$(O)):
3804 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3805
3806 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3807
3808 * chartab.c: Improve commentary for the uniprop_table API.
3809
32413314
EZ
3810 * bidi.c (bidi_paragraph_init): Support zero value of
3811 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3812 (bidi_initialize): Use uniprop_table instead of including
3813 biditype.h and bidimirror.h.
32413314 3814
9fd8be00
EZ
3815 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3816 coordinates of the iterator when restoring from ppos_it.
3817 (Bug#9296)
3818
5cf2b69b
KH
38192011-08-14 Kenichi Handa <handa@m17n.org>
3820
3821 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3822 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3823
daf17d00
EZ
38242011-08-14 Eli Zaretskii <eliz@gnu.org>
3825
3826 * xdisp.c (move_it_in_display_line_to): Don't invoke
3827 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3828 ppos_it. Fixes vertical cursor motion when line beginning is
3829 covered by an image. (Bug#9296)
3830
08e3161a
JD
38312011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3832
3833 * nsterm.h (ns_run_ascript): Declare.
3834 (NSAPP_DATA2_RUNASSCRIPT): Define.
3835
3836 * nsfns.m (as_script, as_result, as_status): New static variables.
3837 (ns_run_ascript): New function.
5e617bc2 3838 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3839 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3840 the event loop. Get status from as_status (Bug#7276).
3841
3842 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3843 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3844 the event loop (Bug#7276).
3845
a3720aa2
AS
38462011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3847
3848 * gnutls.c (QCgnutls_bootprop_priority)
3849 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3850 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3851 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3852 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3853 (QCgnutls_bootprop_verify_hostname_error)
3854 (QCgnutls_bootprop_callbacks_verify): Rename from
3855 Qgnutls_bootprop_..., all uses changed.
3856
3857 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3858 uses changed.
3859
0a0d27fb
PE
38602011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3861
19d5c50c
PE
3862 * xfaces.c (Qframe_set_background_mode): Now static.
3863 * dispextern.h (Qframe_set_background_mode): Remove decl.
3864
0a0d27fb
PE
3865 * process.c (Fnetwork_interface_info): Declare local only if needed.
3866
377538cb
JD
38672011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3868
3869 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3870 (Fnetwork_interface_list): Allocate in increments of bytes instead
3871 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3872 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3873 sockaddr.
3874 (struct ifflag_def): notrailers is smart on OSX.
3875 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3876 Get hardware address with getifaddrs if available.
3877
08fff70c
EZ
38782011-08-12 Eli Zaretskii <eliz@gnu.org>
3879
3880 * xdisp.c (iterate_out_of_display_property): xassert that
3881 IT->position is set to within IT->object's boundaries. Break from
3882 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3883 when IT->position is set up wrongly due to some bug.
3884 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3885 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3886 entry. Force push_it to save on the stack the current
3887 buffer/string position, to be restored by pop_it. Fix flags in
3888 the iterator structure wrt the object coming from a display
3889 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3890 properties. (Bug#9284)
3891
7be1c708 38922011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3893
7be1c708
CY
3894 * fontset.c (fontset_get_font_group): Add proper type checks.
3895 (Bug#9172)
aac0c6e3 3896
7be1c708 38972011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3898
7be1c708
CY
3899 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3900 and LC_VERSION_MIN_MACOSX.
3901 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3902 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3903
97bb72a6
EZ
39042011-08-08 Eli Zaretskii <eliz@gnu.org>
3905
3906 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3907 no-display-properties-and-no-overlays under bidi display.
3908 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3909 properties and overlays.
97bb72a6 3910
d5617611
CY
39112011-08-08 Chong Yidong <cyd@stupidchicken.com>
3912
37e11a63
CY
3913 * editfns.c (Fset_time_zone_rule): Document relationship with the
3914 setenv function.
3915
d5617611
CY
3916 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3917 the font entity extracted from the cache (Bug#8109).
3918
58872834
CY
39192011-08-07 Chong Yidong <cyd@stupidchicken.com>
3920
3921 * composite.c (autocmp_chars): Don't reset point. That is done by
3922 restore_point_unwind (Bug#5984).
3923
75bfc667
JL
39242011-08-07 Juri Linkov <juri@jurta.org>
3925
3926 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3927 to show the arg `TIME' instead of `TIMEVAL'.
3928
d1410150
EZ
39292011-08-06 Eli Zaretskii <eliz@gnu.org>
3930
3931 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3932 display property strides EOL and includes a newline, as in
3933 longlines-mode. (Bug#9254)
75b771e4
EZ
3934 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3935 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3936
3937 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3938 is non-zero, even if the data buffer is NULL. Fixes a crash in
3939 vertical-motion with longlines-mode. (Bug#9254)
3940
35928349
EZ
39412011-08-05 Eli Zaretskii <eliz@gnu.org>
3942
ec7cc85b
EZ
3943 * bidi.c <bidi_cache_total_alloc>: Now static.
3944 (bidi_initialize): Initialize bidi_cache_total_alloc.
3945
8b76d6f8 3946 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3947 cache. (Bug#9221)
3948
3949 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3950 amount allocated this far in `bidi_cache_total_alloc'.
3951 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3952 non-zero, only free the data buffer without restoring the cache
3953 contents. All callers changed.
3954
3955 * dispextern.h (bidi_unshelve_cache): Update prototype.
3956
3957 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3958 (move_it_in_display_line, move_it_to)
3959 (move_it_vertically_backward, move_it_by_lines): Replace the call
3960 to xfree to an equivalent call to bidi_unshelve_cache.
3961 (move_it_in_display_line_to): Fix logic of returning
412b6358 3962 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3963
e2e2423b
EZ
39642011-08-05 Eli Zaretskii <eliz@gnu.org>
3965
3966 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3967 came from a string character with a `cursor' property. (Bug#9229)
3968
ae9e757a
JD
39692011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3970
3971 * Makefile.in (LIB_PTHREAD): New variable.
3972 (LIBES): Add LIB_PTHREAD (Bug#9216).
3973
3974 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3975 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3976
213bd7f2
AS
39772011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3978
6b02f655 3979 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3980
99aaf75f
JD
39812011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3982
3983 * xterm.c (x_find_topmost_parent): New function.
3984 (x_set_frame_alpha): Find topmost parent window with
3985 x_find_topmost_parent and set the property there also (bug#9181).
3986 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3987
c74e9d86
PE
39882011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 * callproc.c (Fcall_process): Avoid vfork clobbering
3991 the local vars buffer, coding_systems, current_dir.
3992
640c8776
SM
39932011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3994
3995 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3996
f26d0e4c
PE
39972011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3998
8a10d76c
PE
3999 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4000 so that it is not optimized away.
4001
f26d0e4c
PE
4002 * xdisp.c (compute_display_string_pos): Remove unused local.
4003
55439c61
EZ
40042011-08-02 Eli Zaretskii <eliz@gnu.org>
4005
4006 Fix slow cursor motion and scrolling in large buffers with
4007 selective display, like Org Mode buffers. (Bug#9218)
4008
4009 * dispextern.h (struct bidi_it): New member disp_prop_p.
4010
4011 * xdisp.c: Remove one-slot cache of display string positions.
4012 (compute_display_string_pos): Accept an additional argument
5e617bc2 4013 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4014 for a display string or property. If found, set DISP_PROP_P
4015 non-zero.
4016
4017 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4018 DISP_PROP_P, and pass it to compute_display_string_pos.
4019 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4020 non-zero. All callers of bidi_fetch_char changed.
4021
fb33fa43
SM
40222011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4025
b099e063
DM
40262010-12-03 Don March <don@ohspite.net>
4027
4028 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4029 last character M-[char] is translated to ESC [char] (bug#7541).
4030
5cc7f7af
KH
40312011-08-02 Kenichi Handa <handa@m17n.org>
4032
d0fffa3f 4033 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4034
4035 * chartab.c (uniprop_table): Make it non-static.
4036
525d5e6e
EZ
40372011-08-01 Eli Zaretskii <eliz@gnu.org>
4038
4039 * xdisp.c (forward_to_next_line_start): Accept additional argument
4040 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4041 on the newline.
4042 (reseat_at_next_visible_line_start): Use the bidi iterator state
4043 returned by forward_to_next_line_start to restore the state of
4044 it->bidi_it after backing up to previous newline. (Bug#9212)
4045
31011111
AS
40462011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4047
4048 * regex.c (re_comp): Protoize.
4049 (re_exec): Fix return type.
4050 (regexec): Fix type of `ret'. (Bug#9203)
4051
476371c4
PE
40522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4053
e5d76069
PE
4054 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4055 This is needed if max-image-size is a floating-point number.
4056
9a79b20c
AS
40572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4058
4059 * print.c (print_object): Print empty symbol as ##.
4060
4061 * lread.c (read1): Read ## as empty symbol.
4062
d8c2fa78
AA
40632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4064
4065 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4066 setting frame foreground color (Bug#9175).
4067 (x_set_background_color): Likewise.
4068
ffe57a7a
AA
4069 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4070 contents (Bug#9176).
4071 (EmacsTooltip -init): Remove bezels and add shadows to
4072 tooltip windows.
4073
bf3492a5
AA
4074 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4075 or scroll bar (Bug#8470).
4076
d55e9c53
AA
4077 * nsfont.m (nsfont_open): Remove assignment to voffset and
4078 unnecessary vars hshink, expand, hd, full_height, min_height.
4079 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4080
4081 * nsterm.h (nsfont_info): Remove voffset field.
4082
d8c2fa78 40832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4084
4085 Implement strike-through and overline on NextStep (Bug#8863).
4086
4087 * nsfont.m (nsfont_open): Use underline position provided by font,
4088 instead of hard-coded value of 2.
4089 (nsfont_draw): Call ns_draw_text_decoration instead.
4090
4091 * nsterm.h: Add declaration for ns_draw_text_decoration.
4092
4093 * nsterm.m (ns_draw_text_decoration): New function for drawing
4094 underline, overline, and strike-through.
4095 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4096 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4097 accommodate underlining, etc.
4843aac3 4098
4cc60b9b
EZ
40992011-07-28 Eli Zaretskii <eliz@gnu.org>
4100
bc7ece87
EZ
4101 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4102 default.
4cc60b9b 4103
476371c4
PE
41042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4105
66606eea
PE
4106 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4107 Without this fix, if a signal arrives just after memory fills up,
4108 'malloc' might be invoked reentrantly.
4109
476371c4
PE
4110 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4111 In other words, assume that every image size is allowed, on non-X
4112 hosts. This assumption is probably wrong, but it lets Emacs compile.
4113
f3fcc40d
AS
41142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * regex.c (re_iswctype): Convert return values to boolean.
4117
350c992f
EZ
41182011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4119
4120 * xdisp.c (compute_display_string_pos): Don't use cached display
4121 string position if the buffer had its restriction changed.
4122 (Bug#9184)
4123
5266b4bb
PE
41242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4127
2573a837 41282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4129
41f55ccd 4130 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4131
39e378da
PE
4132 * bidi.c: Integer size and overflow fixes.
4133 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4134 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4135 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4136 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4137 (bidi_find_other_level_edge):
4138 Use ptrdiff_t instead of EMACS_INT where either will do.
4139 This works better on 32-bit hosts configured --with-wide-int.
4140 (bidi_cache_ensure_space): Check for size-calculation overflow.
4141 Use % rather than repeated addition, for better worst-case speed.
4142 Don't set bidi_cache_size until after xrealloc returns, because it
4143 might not return.
4144 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4145 (bidi_cache_ensure_space): Also check that the bidi cache size
4146 does not exceed that of the largest Lisp string or buffer. See Eli
4147 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4148
5e927815
PE
4149 * alloc.c (__malloc_size_t): Remove.
4150 All uses replaced by size_t. See Andreas Schwab's note
4151 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4152
ca4aa935
PE
4153 * image.c: Improve checking for integer overflow.
4154 (check_image_size): Assume that f is nonnull, since
4155 it is always nonnull in practice. This is one less thing to
4156 worry about when checking for integer overflow later.
4157 (x_check_image_size): New function, which checks for integer
4158 overflow issues inside X.
4159 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4160 This removes the need for a memory_full check.
4161 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4162 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4163 (xbm_read_bitmap_data): Change locals back to 'int', since
4164 their values must fit in 'int'.
4165 (xpm_load_image, png_load, tiff_load):
4166 Invoke x_create_x_image_and_pixmap earlier,
4167 to avoid much needless work if the image is too large.
4168 (tiff_load): Treat overly large images as if
4169 x_create_x_image_and_pixmap failed, not as malloc failures.
4170 (gs_load): Use x_check_image_size.
4171
5f8f9cc2
PE
4172 * gtkutil.c: Omit integer casts.
4173 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4174 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4175
5adf60bc
PE
4176 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4177
c8907a93
PE
4178 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4179 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4180 would wrongly return t on a 64-bit host.
4181
e3c25c68
PE
4182 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4183 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4184 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4185 and therefore cause GCC to emit a bogus diagnostic in some cases.
4186
3f791afe
PE
4187 * image.c: Integer signedness and overflow and related fixes.
4188 This is not an exhaustive set of fixes, but it's time to
4189 record what I've got.
4190 (lookup_pixel_color, check_image_size): Remove redundant decls.
4191 (check_image_size): Don't assume that arbitrary EMACS_INT values
4192 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4193 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4194 (tiff_load, imagemagick_load_image):
4195 Check for overflow in size calculations.
4196 (x_create_x_image_and_pixmap): Remove unnecessary test for
4197 xmalloc returning NULL; that can't happen.
4198 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4199 (xpm_color_bucket): Use better integer hashing function.
4200 (xpm_cache_color): Don't possibly over-allocate memory.
4201 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4202 (gif_memory_source):
4203 Use ptrdiff_t, not int or size_t, to record sizes.
4204 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4205 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4206 either works, as we prefer signed integers.
4207 (tiff_read_from_memory, tiff_write_from_memory):
4208 Return tsize_t, not size_t, since that's what the TIFF API wants.
4209 (tiff_read_from_memory): Don't fail simply because the read would
4210 go past EOF; instead, return a short read.
4211 (tiff_load): Omit no-longer-needed casts.
4212 (Fimagemagick_types): Don't assume size fits into 'int'.
4213
3cc5a532
PE
4214 Improve hashing quality when configured --with-wide-int.
4215 * fns.c (hash_string): New function, taken from sxhash_string.
4216 Do not discard information about ASCII character case; this
4217 discarding is no longer needed.
4218 (sxhash-string): Use it. Change sig to match it. Caller changed.
4219 * lisp.h: Declare it.
4220 * lread.c (hash_string): Remove, since we now use fns.c's version.
4221 The fns.c version returns a wider integer if --with-wide-int is
4222 specified, so this should help the quality of the hashing a bit.
4223
b312a492
PE
4224 * emacs.c: Integer overflow minor fix.
4225 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4226 Define only if GNU_LINUX.
4227 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4228
dfd153ae
PE
4229 * dispnew.c: Integer signedness and overflow fixes.
4230 Remove unnecessary forward decls, that were a maintenance hassle.
4231 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4232 All uses changed.
4233 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4234 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4235 (prepare_desired_row, line_draw_cost):
4236 Use int, not unsigned, where either works.
4237 (save_current_matrix, restore_current_matrix):
4238 Use ptrdiff_t, not size_t, where either works.
4239 (init_display): Check for overflow more accurately, and without
4240 relying on undefined behavior.
4241
a81d11a3
PE
4242 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4243 Remove, replacing with the new symbols in lisp.h. All uses changed.
4244 * fileio.c (make_temp_name):
4245 * filelock.c (lock_file_1, lock_file):
4246 * xdisp.c (message_dolog):
4247 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4248 Use pMd etc. instead.
4249 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4250 replacing the pWIDE etc. symbols removed from editfns.c.
4251
3300e6fd
PE
4252 * keyboard.h (num_input_events): Now uintmax_t.
4253 This is (very slightly) less likely to mess up due to wraparound.
4254 All uses changed.
4255
fd05c7e9
PE
4256 * buffer.c: Integer signedness fixes.
4257 (alloc_buffer_text, enlarge_buffer_text):
4258 Use ptrdiff_t rather than size_t when either will do, as we prefer
4259 signed integers.
4260
903fe15d
PE
4261 * alloc.c: Integer signedness and overflow fixes.
4262 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4263 (__malloc_size_t): Default to size_t, not to int.
4264 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4265 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4266 Prefer ptrdiff_t to size_t when either would do, as we prefer
4267 signed integers.
4268 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4269 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4270 Now const. Initialize with values that are in range even if char
4271 is signed.
4272 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4273 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4274 These functions do the right thing with sizes > 2**32.
4275 (check_depth): Now ptrdiff_t, not int.
4276 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4277 Adjust to new way of storing sizes. Check for size overflow bugs
4278 in rest of code.
4279 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4280 slightly wrong anyway, as it missed one instance of
4281 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4282 (refill_memory_reserve): Omit needless cast to size_t.
4283 (mark_object_loop_halt): Mark as externally visible.
4284
ac82cc6a
PE
4285 * xselect.c: Integer signedness and overflow fixes.
4286 (Fx_register_dnd_atom, x_handle_dnd_message):
4287 Use ptrdiff_t, not size_t, since we prefer signed.
4288 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4289 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4290 x_dnd_atoms_size and x_dnd_atoms_length.
4291
c2d1e36d
PE
4292 * doprnt.c: Prefer signed to unsigned when either works.
4293 * eval.c (verror):
4294 * doprnt.c (doprnt):
4295 * lisp.h (doprnt):
4296 * xdisp.c (vmessage):
4297 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4298 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4299 prefer signed arithmetic to avoid comparison confusion.
4300 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4301 but is a bit tricky.
4302
0e926e56
PE
4303 Assume freestanding C89 headers, string.h, stdlib.h.
4304 * data.c, doprnt.c, floatfns.c, print.c:
4305 Include float.h unconditionally.
4306 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4307 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4308 * regex.c: Likewise for stddef.h, string.h.
4309 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4310 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4311 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4312 (STDC_HEADERS): Remove obsolete defines.
4313 * sysdep.c: Include limits.h unconditionally.
4314
9cfdb3ec
PE
4315 Assume support for memcmp, memcpy, memmove, memset.
4316 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4317 * regex.c (memcmp, memcpy):
4318 Remove; we assume C89 now.
4319
4320 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4321 (__malloc_safe_bcopy): Remove; no longer needed.
4322
cf950e6b 4323 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4324 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4325 well either way, and we prefer signed to unsigned.
4326
dbf38e02
LMI
43272011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4328
4329 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4330 closes the connection while we're reading (bug#9182).
4331
d6f0886c 43322011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4333
d6f0886c
JD
4334 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4335 are specified (Bug#9168).
24e0f6b1 4336
2eb1f9e6
PE
43372011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4338
4339 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4340 Found by GCC static checking and --with-wide-int on a 32-bit host.
4341
22381272 43422011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4343
4344 * xdisp.c (compute_display_string_pos): Fix logic of caching
4345 previous display string position. Initialize cached_prev_pos to
4346 -1. Fixes slow-down at the beginning of a buffer.
4347
f25e39b4
EZ
43482011-07-24 Eli Zaretskii <eliz@gnu.org>
4349
4350 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4351 for attrs[LFACE_FONTSET_INDEX].
4352
04c4b52e
PE
43532011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 * xml.c (parse_region): Remove unused local
4356 that was recently introduced.
4357
c1734fbd
EZ
43582011-07-23 Eli Zaretskii <eliz@gnu.org>
4359
be18c5a5
EZ
4360 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4361 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4362
c1734fbd
EZ
4363 * xdisp.c (move_it_in_display_line_to): Record the best matching
4364 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4365 exit if none of the characters scanned was an exact match.
4366 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4367 when exact match is impossible due to invisible text, and the
4368 lines are truncated.
4369
a258d627
JD
43702011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4371
4372 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4373 for OSX >= 10.7.
4374
b6d5a689
EZ
43752011-07-22 Eli Zaretskii <eliz@gnu.org>
4376
0f74f785
EZ
4377 Fix a significant slow-down of cursor motion with C-n, C-p,
4378 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4379 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4380 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4381 (next_element_from_buffer): Call compute_stop_pos_backwards to
4382 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4383 base_level_stop.
4384 (reseat): Don't look for prev_stop, as that could mean a very long
4385 run.
4386 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4387 <cached_disp_overlay_modiff>: Cache for last found display string
4388 position.
551918c1 4389 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4390 about the same buffer in the same area of character positions, and
4391 the buffer wasn't changed since the time the display string
4392 position was cached.
551918c1 4393
b2d0c91a
EZ
43942011-07-22 Eli Zaretskii <eliz@gnu.org>
4395
4396 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4397 is an integer, which is important for empty lines. (Bug#9149)
4398
043604ee
CY
43992011-07-22 Chong Yidong <cyd@stupidchicken.com>
4400
4401 * frame.c (Fmodify_frame_parameters): In tty case, update the
4402 default face if necessary (Bug#4238).
4403
da4adb04
CY
44042011-07-21 Chong Yidong <cyd@stupidchicken.com>
4405
4406 * editfns.c (Fstring_to_char): No need to explain what a character
4407 is in the docstring (Bug#6576).
4408
9abd0532
LMI
44092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4410
4411 * xml.c (parse_region): Make sure we always return a tree.
4412
36881d16
HK
44132011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4414
4415 * xml.c (parse_region): If a document contains only comments,
4416 return that, too.
4417
1e98674d
LMI
44182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4419
4420 * xml.c (make_dom): Return comments, too.
4421
590bd467
PE
44222011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 Port to OpenBSD.
4425 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4426 and the surrounding thread.
4427 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4428 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4429 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4430 timer goes off.
4431 * s/openbsd.h (BROKEN_SIGIO): Define.
4432 * unexelf.c (unexec) [__OpenBSD__]:
4433 Don't update the .mdebug section of the Alpha COFF symbol table.
4434
f41628b2
LMI
44352011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4436
4437 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4438 (bug#8460).
4439
b59b67c5
PE
44402011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4441
15e3a074
PE
4442 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4443 This fixes some race conditions on the permissions of any newly
4444 created file.
4445
41bed37d
PE
4446 * alloc.c (valid_pointer_p): Use pipe, not open.
4447 This fixes some permissions issues when debugging.
4448
b59b67c5
PE
4449 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4450 If fchown fails to set both uid and gid, try to set just gid,
4451 as that is sometimes allowed. Adjust the file's mode to eliminate
4452 setuid or setgid bits that are inappropriate if fchown fails.
4453
925a6be7
SM
44542011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4455
4456 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4457 to compare Lisp_Objects.
4458 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4459 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4460 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4461
52968808
AS
44622011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4463
0a6a104b
AS
4464 * lread.c (read_integer): Unread even EOF character.
4465 (read1): Likewise. Properly record start position of symbol.
4466
52968808
AS
4467 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4468 symbol character follows.
4469
9e381cdd
PE
44702011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4471
4472 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4473 This works around a problem with the previous change to Fcopy_file.
4474 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4475 and without this change, GCC might complain about discarding
4476 fchown's return value.
4477
b5641435
JB
44782011-07-16 Juanma Barranquero <lekktu@gmail.com>
4479
4480 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4481
a8031457
PE
44822011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4485
dd889327
LMI
44862011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4487
750c33f7
LMI
4488 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4489 it's used from the C level.
4490
dd889327
LMI
4491 * process.c: Use the same condition for POLL_FOR_INPUT in both
4492 keyboard.c and process.c (bug#1858).
4493
87e86684
LM
44942011-07-09 Lawrence Mitchell <wence@gmx.li>
4495
4496 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4497 (Fgnutls_boot): Use it.
4498
64348f40
AS
44992011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4500
4501 * doc.c (Fsubstitute_command_keys): Revert last change.
4502
1d698799
LMI
45032011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4504
f863868c
LMI
4505 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4506 quotes the next character, and doesn't affect other longer
4507 sequences (bug#8935).
4508
1d698799
LMI
4509 * lread.c (syms_of_lread): Clarify that is isn't only
4510 `eval-buffer' and `eval-defun' that's affected by
4511 `lexical-binding' (bug#8460).
4512
aa4b6df6
EZ
45132011-07-15 Eli Zaretskii <eliz@gnu.org>
4514
4515 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4516 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4517
5d856da6
PE
45182011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4519
ad6042bb
PE
4520 Fix minor problems found by static checking.
4521 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4522 (elsz): Now a signed constant, not a size_t var. We prefer signed
4523 types to unsigned, to avoid integer comparison confusion. Without
4524 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4525 "cannot optimize loop, the loop counter may overflow", a symptom
4526 of the confusion.
f00bbb22 4527 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4528 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4529
6468f31c
LMI
45302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4531
49080b10
LMI
4532 * search.c (Fre_search_backward): Mention `case-fold-search' in
4533 all the re_search_* functions (bug#8138).
4534
6468f31c
LMI
4535 * keyboard.c (Fopen_dribble_file): Document when the file is
4536 closed (bug#8056).
4537
c965adc5
EZ
45382011-07-14 Eli Zaretskii <eliz@gnu.org>
4539
df9733bf
EZ
4540 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4541 bidi_cache_idx.
4542
0bb23927
EZ
4543 Support bidi reordering of display and overlay strings.
4544 * xdisp.c (compute_display_string_pos)
4545 (compute_display_string_end): Accept additional argument STRING.
4546 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4547 (reseat_to_string): Initialize bidi_it->string.s and
4548 bidi_it->string.schars.
4549 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4550 NULL (avoids a crash in bidi_paragraph_init).
4551 Initialize itb.string.lstring.
0bb23927
EZ
4552 (init_iterator): Call bidi_init_it only of a valid
4553 buffer position was specified. Initialize paragraph_embedding to
4554 L2R.
4555 (reseat_to_string): Initialize the bidi iterator.
4556 (display_string): If we need to ignore text properties of
4557 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4558 original value of -1 will not work with bidi.)
4559 (compute_display_string_pos): First arg is now struct
4560 `text_pos *'; all callers changed. Support display properties on
4561 Lisp strings.
4562 (compute_display_string_end): Support display properties on Lisp
4563 strings.
4564 (init_iterator, reseat_1, reseat_to_string): Initialize the
4565 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4566 when iterating on a string not from display properties).
640c8776
SM
4567 (compute_display_string_pos, compute_display_string_end):
4568 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4569 arrow keys.
4570 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4571 base_level_stop; instead, set base_level_stop to BEGV.
4572 Fixes crashes in vertical-motion.
0bb23927
EZ
4573 (next_element_from_buffer): Improve commentary for when
4574 the iterator is before prev_stop.
4575 (init_iterator): Initialize bidi_p from the default value of
4576 bidi-display-reordering, not from buffer-local value. Use the
4577 buffer-local value only if initializing for buffer iteration.
4578 (handle_invisible_prop): Support invisible properties on strings
4579 that are being bidi-reordered.
4580 (set_iterator_to_next): Support bidi reordering of C strings and
4581 Lisp strings.
4582 (next_element_from_string): Support bidi reordering of Lisp
4583 strings.
4584 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4585 (display_string): Support display of R2L glyph rows.
4586 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4587 (init_iterator): Don't initialize it->bidi_p for strings
4588 here.
4589 (reseat_to_string): Initialize it->bidi_p for strings here.
4590 (next_element_from_string, next_element_from_c_string)
4591 (next_element_from_buffer): Add xassert's for correspondence
4592 between IT's object being iterated and it->bidi_it.string
4593 structure.
4594 (face_before_or_after_it_pos): Support bidi iteration.
4595 (next_element_from_c_string): Handle the case of the first string
4596 character that is not the first one in the visual order.
4597 (get_visually_first_element): New function, refactored from common
4598 parts of next_element_from_buffer, next_element_from_string, and
4599 next_element_from_c_string.
4600 (tool_bar_lines_needed, redisplay_tool_bar)
4601 (display_menu_bar): Force left-to-right direction. Add a FIXME
4602 comment for making that be controlled by a user option.
4603 (push_it, pop_it): Save and restore the state of the
4604 bidi iterator. Save and restore the bidi_p flag.
4605 (pop_it): Iterate out of display property for string iteration as
4606 well.
4607 (iterate_out_of_display_property): Support iteration over strings.
4608 (handle_single_display_spec): Set up it->bidi_it for iteration
4609 over a display string, and call bidi_init_it.
4610 (handle_single_display_spec, next_overlay_string)
4611 (get_overlay_strings_1, push_display_prop): Set up the bidi
4612 iterator for displaying display or overlay strings.
4613 (forward_to_next_line_start): Don't use the shortcut if
4614 bidi-iterating.
4615 (back_to_previous_visible_line_start): If handle_display_prop
4616 pushed the iterator stack, restore the internal state of the bidi
4617 iterator by calling bidi_pop_it same number of times.
4618 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4619 and we are bidi-iterating, don't decrement the iterator position;
4620 instead, set the first_elt flag in the bidi iterator, to produce
4621 the same effect.
4622 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4623 (push_display_prop): xassert that we are iterating a buffer.
4624 (push_it, pop_it): Save and restore paragraph_embedding member.
4625 (handle_single_display_spec, next_overlay_string)
4626 (get_overlay_strings_1, reseat_1, reseat_to_string)
4627 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4628 correctly. Don't assume unibyte strings are not bidi-reordered.
4629 (compute_display_string_pos)
4630 (compute_display_string_end): Fix handling the case of C string.
4631 (push_it, pop_it): Save and restore from_disp_prop_p.
4632 (handle_single_display_spec, push_display_prop): Set the
4633 from_disp_prop_p flag.
4634 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4635 (pop_it): Call iterate_out_of_display_property only if we are
4636 popping after iteration over a string that came from a display
4637 property. Fix a typo in popping stretch info. Add an assertion
4638 for verifying that the iterator position is in sync with the bidi
4639 iterator.
4640 (handle_single_display_spec, get_overlay_strings_1)
4641 (push_display_prop): Fix initialization of paragraph direction for
4642 string when that of the parent object is not yet determined.
4643 (reseat_1): Call bidi_init_it to resync the bidi
4644 iterator with IT's position. (Bug#7616)
4645 (find_row_edges): If ROW->start.pos gives position
4646 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4647 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4648 Reset the from_disp_prop_p flag.
4649 (SAVE_IT, RESTORE_IT): New macros.
4650 (pos_visible_p, face_before_or_after_it_pos)
4651 (back_to_previous_visible_line_start)
4652 (move_it_in_display_line_to, move_it_in_display_line)
4653 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4654 (try_scrolling, redisplay_window, display_line): Use them when
4655 saving a temporary copy of the iterator and restoring it back.
4656 (back_to_previous_visible_line_start, reseat_1)
4657 (init_iterator): Empty the bidi cache "stack".
4658 (move_it_in_display_line_to): If iterator ended up at
4659 EOL, but we never saw any buffer positions smaller than
4660 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4661 motion in bidi-reordered lines.
4662 (move_it_in_display_line_to): Record prev_method and prev_pos
4663 immediately before the call to set_iterator_to_next. Fixes cursor
4664 motion in bidi-reordered lines with stretch glyphs and strings
4665 displayed in margins. (Bug#8133) (Bug#8867)
4666 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4667 TO_CHARPOS.
640c8776
SM
4668 (pos_visible_p): Support positions in bidi-reordered lines.
4669 Save and restore bidi cache.
0bb23927
EZ
4670
4671 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4672 (bidi_paragraph_info): Delete unused struct.
4673 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4674 (bidi_cache_start): New variable.
4675 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4676 to zero.
4677 (bidi_cache_fetch_state, bidi_cache_search)
4678 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4679 (bidi_cache_find, bidi_peek_at_next_level)
4680 (bidi_level_of_next_char, bidi_find_other_level_edge)
4681 (bidi_move_to_visually_next): Compare cache index with
4682 bidi_cache_start rather than with zero.
4683 (bidi_fetch_char): Accept new argument STRING; all callers
4684 changed. Support iteration over a string. Support strings with
4685 display properties. Support unibyte strings. Fix the type of
4686 `len' according to what STRING_CHAR_AND_LENGTH expects.
4687 (bidi_paragraph_init, bidi_resolve_explicit_1)
4688 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4689 (bidi_level_of_next_char, bidi_move_to_visually_next):
4690 Support iteration over a string.
0bb23927
EZ
4691 (bidi_set_sor_type, bidi_resolve_explicit_1)
4692 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4693 can now be zero (for strings); special values 0 and -1 were
4694 changed to -1 and -2, respectively.
4695 (bidi_char_at_pos): New function.
4696 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4697 Call it instead of FETCH_MULTIBYTE_CHAR.
4698 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4699 initialized to valid values.
4700 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4701 values.
4702 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4703 the test for valid cached positions. Fix the logic for looking up
4704 the sentinel state in the cache. GCPRO the Lisp string we are
4705 iterating.
4706 (bidi_push_it, bidi_pop_it): New functions.
4707 (bidi_initialize): Initialize the bidi cache start stack pointer.
4708 (bidi_cache_ensure_space): New function, refactored from part of
4709 bidi_cache_iterator_state. Don't assume the required size is just
4710 one BIDI_CACHE_CHUNK away.
4711 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4712 (bidi_count_bytes, bidi_char_at_pos): New functions.
4713 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4714 always valid if bidi_cache_idx is valid.
4715 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4716 is valid if it's going to be used.
4717 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4718 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4719 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4720 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4721 (bidi_find_other_level_edge, bidi_cache_start_stack):
4722 All variables related to cache indices are now EMACS_INT.
c965adc5 4723
0bb23927
EZ
4724 * dispextern.h (struct bidi_string_data): New structure.
4725 (struct bidi_it): New member `string'. Make flag members be 1-bit
4726 fields, and put them last in the struct.
640c8776
SM
4727 (compute_display_string_pos, compute_display_string_end):
4728 Update prototypes.
0bb23927
EZ
4729 (bidi_push_it, bidi_pop_it): Add prototypes.
4730 (struct iterator_stack_entry): New members bidi_p,
4731 paragraph_embedding, and from_disp_prop_p.
4732 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4733 (bidi_shelve_cache, bidi_unshelve_cache):
4734 Declare prototypes.
0bb23927
EZ
4735
4736 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4737 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4738 and vector-like objects.
4739
4740 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4741 cache around display iteration.
4742
4743 * window.c (Fwindow_end, window_scroll_pixel_based)
4744 (displayed_window_lines, Frecenter): Save and restore the bidi
4745 cache around display iteration.
4746
3bbd2265
LMI
47472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4748
4749 * editfns.c (Fdelete_region): Clarify the use of the named
4750 parameters (bug#6788).
4751
adc47434
MR
47522011-07-14 Martin Rudalics <rudalics@gmx.at>
4753
4754 * indent.c (Fvertical_motion): Set and restore w->pointm when
4755 saving and restoring the window's buffer (Bug#9006).
4756
837c31f8
LMI
47572011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4758
4759 * editfns.c (Fstring_to_char): Clarify just what is returned
4760 (bug#6576). Text by Eli Zaretskii.
4761
ac389d0c
JB
47622011-07-13 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4765
0be0ce47
EZ
47662011-07-13 Eli Zaretskii <eliz@gnu.org>
4767
4768 * buffer.c (mmap_find): Fix a typo.
4769
cd18e7e3
JB
47702011-07-13 Johan Bockgård <bojohan@gnu.org>
4771
4772 Fix execution of x selection hooks.
4773 * xselect.c (Qx_lost_selection_functions)
4774 (Qx_sent_selection_functions): New vars.
4775 (syms_of_xselect): DEFSYM them.
4776 (x_handle_selection_request): Pass Qx_sent_selection_functions
4777 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4778 (x_handle_selection_clear,x_clear_frame_selections):
4779 Pass Qx_lost_selection_functions rather than
4780 Vx_lost_selection_functions to Frun_hook_with_args.
4781
47ea7f44
PE
47822011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4783
ac389d0c 4784 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4785 The old code sometimes used this field without initializing it.
4786
47ea7f44
PE
4787 * alloc.c (gc_sweep): Don't read past end of array.
4788 In theory, the old code could also have corrupted Emacs internals,
4789 though it'd be very unlikely.
4790
bc985c87
AS
47912011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4792
4793 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4794 argument. (Bug#4026)
bc985c87 4795
0cf34688
LMI
47962011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4797
b3dadd76
LMI
4798 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4799 key" (bug#4257).
4800
0cf34688
LMI
4801 * window.c (Fset_window_start): Doc fix (bug#4199).
4802 (Fset_window_hscroll): Ditto.
4803
270768cd
PE
48042011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4805
077e3dda 4806 Fix minor new problems caught by GCC 4.6.1.
270768cd 4807 * term.c (init_tty): Remove unused local.
490011a6 4808 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4809 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4810 not used otherwise.
270768cd 4811
b1f58454
CY
48122011-07-12 Chong Yidong <cyd@stupidchicken.com>
4813
4814 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4815
22b9578d
LMI
48162011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4817
6e70ab07
LMI
4818 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4819 are the mini-buffer and the echo area (bug#3320).
4820
22b9578d
LMI
4821 * term.c (init_tty): Remove support for supdup, c10 and perq
4822 terminals, which are no longer supported (bug#1482).
4823
8974cc9f
JB
48242011-07-10 Johan Bockgård <bojohan@gnu.org>
4825
4826 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4827
a560d974
JD
48282011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4829
4830 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4831 for non-popups (Bug#3642).
4832
1dae0f0a
AS
48332011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4834
268c2c36 4835 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4836 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4837 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4838 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4839 * data.c (fmod): Likewise.
4840 * dispnew.c (swap_glyphs_in_rows): Likewise.
4841 * emacs.c (memory_warning_signal): Likewise.
4842 * floatfns.c (float_error): Likewise.
4843 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4844 (otf_open, font_otf_capability, generate_otf_features)
4845 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4846 Likewise.
4847 * image.c (pbm_read_file): Likewise.
4848 * indent.c (string_display_width): Likewise.
4849 * intervals.c (check_for_interval, search_for_interval)
4850 (inc_interval_count, count_intervals, root_interval)
4851 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4852 * lread.c (defalias): Likewise.
268c2c36 4853 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4854 * regex.c (set_image_of_range_1, set_image_of_range)
4855 (regex_grow_registers): Likewise.
4856 * sysdep.c (strerror): Likewise.
4857 * termcap.c (valid_filename_p, tprint, main): Likewise.
4858 * tparam.c (main): Likewise.
4859 * unexhp9k800.c (run_time_remap, save_data_space)
4860 (update_file_ptrs, read_header, write_header, calculate_checksum)
4861 (copy_file, copy_rest, display_header): Likewise.
4862 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4863 Likewise.
4864 * xdisp.c (check_it): Likewise.
4865 * xfaces.c (register_color, unregister_color, unregister_colors):
4866 Likewise.
4867 * xfns.c (print_fontset_result): Likewise.
4868 * xrdb.c (member, fatal, main): Likewise.
4869
99033785
PE
48702011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 Fix minor problems found by static checking (Bug#9031).
4873 * chartab.c (char_table_set_range, map_sub_char_table):
4874 Remove unused locals.
4875 (uniprop_table): Now static.
4876 * composite.c (_work_char): Remove unused static var.
4877
9cb2ac56
JB
48782011-07-09 Juanma Barranquero <lekktu@gmail.com>
4879
4880 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4881
f25661f0
JD
48822011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4883
4884 * gtkutil.c (qttip_cb): Remove code without function.
4885
8278c4fe
EZ
48862011-07-09 Eli Zaretskii <eliz@gnu.org>
4887
4888 * w32.c (pthread_sigmask): New stub.
4889
1692ae2d 48902011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4891
8a6ebd58 4892 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4893 sigprocmask is portable only for single-threaded applications, and
4894 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4895 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4896 (LIBES): Use it.
4897 * callproc.c (Fcall_process):
4898 * process.c (create_process):
4899 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4900 Use pthread_sigmask, not sigprocmask.
123403e4 4901
1b854618
JD
49022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4903
4904 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4905 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4906 wrong (Bug#8591).
4907
3fe4b549
JD
49082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4909
0ce7e563
JD
4910 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4911 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4912 (xg_hide_tooltip): Fix comment.
4913
3fe4b549
JD
4914 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4915 in registerServicesMenuSendTypes.
4916 (validRequestorForSendType): Don't check ns_return_types.
4917
4918 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4919 ns_return_type.
4920
5df75e47
JR
49212011-07-08 Jason Rumney <jasonr@gnu.org>
4922
22610910
JR
4923 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4924 SH_SHOW for hidden windows (Bug#5482).
4925
5df75e47
JR
4926 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4927 frame struct members of non-existent frames (Bug#6284).
4928
699c10bd
JD
49292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4930
4393663b
JD
4931 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4932 variable firstTime not needed on OSX >= 10.6.
4933 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4934 >= 10.5. Use setKnobProportion, setDoubleValue.
4935
4936 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4937 (MAC_OS_X_VERSION_10_5): Define if not defined.
4938 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4939 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4940 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4941
4942 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4943 cString and lossyCString on OSX >= 10.4
4944
58179cce 4945 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4946 sizeToFit on OSX >= 10.2.
4947
4948 * nsimage.m (allocInitFromFile): Don't use deprecated method
4949 bestRepresentationForDevice on OSX >= 10.6.
4950
4951 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4952 to avoid warning.
4953
4954 * emacs.c: Declare unexec_init_emacs_zone.
4955
a63e0781
JD
4956 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4957
699c10bd
JD
4958 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4959
4960 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4961 on svcsMenu (Bug#8842).
4962
4963 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4964 ns_return_types.
4965 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4966
4967 * nsterm.m (QUTF8_STRING): Declare.
4968 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4969 (validRequestorForSendType): Return type is (id).
4970 Change indexOfObjectIdenticalTo to indexOfObject.
4971 Check if we have local selection before returning self (Bug#8842).
4972 (writeSelectionToPasteboard): Put local selection into paste board
4973 if we have a local selection (Bug#8842).
4974 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4975
4976 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4977 (ns_get_local_selection): Declare.
4978
54e10184
LMI
49792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4980
9888ff71
LMI
4981 * keymap.c (describe_map_tree): Don't insert a double newline at
4982 the end of the buffer (bug#1169) and return whether we inserted
4983 something.
4984
54e10184
LMI
4985 * callint.c (Fcall_interactively): Change "reading args" to
4986 "providing args" to try to clarify what it does (bug#1010).
4987
15fa4783
KH
49882011-07-07 Kenichi Handa <handa@m17n.org>
4989
4990 * composite.c (composition_compute_stop_pos): Ignore a static
4991 composition starting before CHARPOS (Bug#8915).
4992
4993 * xdisp.c (handle_composition_prop): Likewise.
4994
a8815b00
EZ
49952011-07-07 Eli Zaretskii <eliz@gnu.org>
4996
4997 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4998 (Bug#9015)
4999
ef7b981d 50002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5001
5002 * character.h (unicode_category_t): New enum type.
5003
5004 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5005 (Qchar_code_property_table): New variable.
5006 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5007 (UNIPROP_COMPRESSED_FORM_P): New macros.
5008 (char_table_ascii): Uncompress the compressed values.
5009 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5010 Uncompress the compressed values.
ac389d0c 5011 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5012 (char_table_ref_and_range): Uncompress the compressed values.
5013 (sub_char_table_set): New arg is_uniprop. Callers changed.
5014 Uncompress the compressed values.
5015 (sub_char_table_set_range): Args changed. Callers changed.
5016 (char_table_set_range): Adjuted for the above change.
5017 (map_sub_char_table): Delete args default_val and parent. Add arg
5018 top. Give decoded values to a Lisp function.
640c8776 5019 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5020 values to a Lisp function. Gcpro more variables.
5021 (uniprop_table_uncompress)
5022 (uniprop_decode_value_run_length): New functions.
5023 (uniprop_decoder, uniprop_decoder_count): New variables.
5024 (uniprop_get_decoder, uniprop_encode_value_character)
5025 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5026 New functions.
5027 (uniprop_encoder, uniprop_encoder_count): New variables.
5028 (uniprop_get_encoder, uniprop_table)
5029 (Funicode_property_table_internal, Fget_unicode_property_internal)
5030 (Fput_unicode_property_internal): New functions.
5031 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5032 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5033 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5034 char-code-property-alist.
5035
640c8776 5036 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5037 Vunicode_category_table.
5038
640c8776 5039 * font.c (font_range): Adjust for the change of
c805dec0
KH
5040 Vunicode_category_table.
5041
76b397fb
DN
50422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5043
5044 * m/iris4d.h: Remove file, move contents ...
5045 * s/irix6-5.h: ... here.
5046
22b4128e
PE
50472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5048
5049 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5050 * alloc.c (mark_buffer):
5051 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5052 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5053 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5054 This isn't true in general, and it's particularly not true
5055 if Emacs is configured with --with-wide-int.
5056 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5057 New macros, used in the buffer.c change.
5058
869795d6
JD
50592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5060
5061 * xsettings.c: Use both GConf and GSettings if both are available.
5062 (store_config_changed_event): Add comment.
5063 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5064 (store_tool_bar_style_changed): New functions.
5e617bc2 5065 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5066 (struct xsettings): Move font inside HAVE_XFT.
5067 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5068 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5069 Move inside HAVE_XFT.
640c8776 5070 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5071 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5072 also.
5073 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5074 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5075 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5076 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5077 (parse_settings): Move check for font inside HAVE_XFT.
5078 (read_settings, apply_xft_settings): Add comment.
5079 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5080 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5081 call store_font_name_changed.
5082 (xft_settings_event): Add comment.
5083 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5084 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5085 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5086 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5087 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5088 (xsettings_get_system_font, xsettings_get_system_normal_font):
5089 Add comment.
869795d6 5090
d8ed26bd
PE
50912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5092
5093 Random fixes. E.g., (random) never returned negative values.
5094 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5095 subseconds part to the entropy, as that's a bit more random.
5096 Prefer signed to unsigned, since the signedness doesn't matter and
5097 in general we prefer signed. When given a limit, use a
5098 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5099 latter isn't right if USE_2_TAGS_FOR_INTS.
5100 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5101 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5102
cabf1cac
SM
51032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5104
5105 * textprop.c (text_property_stickiness):
5106 Obey Vtext_property_default_nonsticky.
5107 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5108 * w32fns.c (syms_of_w32fns):
5109 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5110
6e9b2be9
PE
51112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5114 This is more efficient than Ffile_directory_p and avoids a minor race.
5115
90186c68
LMI
51162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5117
7c301272
LMI
5118 * buffer.c (Foverlay_put): Say what the return value is
5119 (bug#7835).
5120
c4f2d8d4
LMI
5121 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5122 is a directory before asking whether to use the file name
5123 (bug#7564).
ad637907
LMI
5124 (barf_or_query_if_file_exists): Make the "File is a directory"
5125 error be more correct.
c4f2d8d4 5126
90186c68
LMI
5127 * fns.c (Frequire): Remove the mention of the .gz files, since
5128 that's installation-specific, but keep the mention of
5129 `get-load-suffixes'.
5130
da64016e
PE
51312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5132
5133 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5134 Report string overflow if the output is too long.
5135
7d47b580
JB
51362011-07-04 Juanma Barranquero <lekktu@gmail.com>
5137
a555cb87
JB
5138 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5139 (syms_of_gnutls): Remove duplicate DEFSYM for
5140 Qgnutls_bootprop_verify_hostname_error, an error for
5141 Qgnutls_bootprop_verify_error (which is no longer used).
5142
7d47b580
JB
5143 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5144 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5145 Also (re)move comments that are misplaced or no longer relevant.
5146
1e49bfab
LMI
51472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5148
5149 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5150
1485f4c0
CY
51512011-07-03 Chong Yidong <cyd@stupidchicken.com>
5152
5153 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5154 and background color parameters if they have been changed.
5155
a9ab721e
LMI
51562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5157
5158 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5159
cf7cff57
PE
51602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5161
2e13213d
PE
5162 * xsettings.c (SYSTEM_FONT): Define only when used.
5163 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5164
cf7cff57
PE
5165 * keymap.c (access_keymap_1): Now static.
5166
7a8e04f7
CY
51672011-07-02 Chong Yidong <cyd@stupidchicken.com>
5168
5169 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5170 leave any prefix arg for the up event (Bug#1586).
5171
61352f62
LMI
51722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5173
69bb1ef7
LMI
5174 * lread.c (syms_of_lread): Mention single symbols defined by
5175 `defvar' or `defconst' (bug#7154).
5176
61352f62 5177 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5178 (Frequire): Mention get-load-suffixes.
61352f62 5179
28545e04
MR
51802011-07-02 Martin Rudalics <rudalics@gmx.at>
5181
5182 * window.h (window): Remove clone_number slot.
5183 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5184 Remove.
5185 (make_parent_window, make_window, saved_window)
5186 (Fset_window_configuration, save_window_save): Don't deal with
5187 clone numbers.
5188 * buffer.c (Qclone_number): Remove declaration.
5189 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5190
3349e122
SM
51912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5192
5193 Add multiple inheritance to keymaps.
5194 * keymap.c (Fmake_composed_keymap): New function.
5195 (Fset_keymap_parent): Simplify.
5196 (fix_submap_inheritance): Remove.
5197 (access_keymap_1): New function extracted from access_keymap to handle
5198 embedded parents and handle lists of maps.
5199 (access_keymap): Use it.
5200 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5201 (Fcopy_keymap): Handle embedded parents.
5202 (Fcommand_remapping, define_as_prefix): Simplify.
5203 (Fkey_binding): Simplify.
5204 (syms_of_keymap): Move minibuffer-local-completion-map,
5205 minibuffer-local-filename-completion-map,
5206 minibuffer-local-must-match-map, and
5207 minibuffer-local-filename-must-match-map to Elisp.
5208 (syms_of_keymap): Defsubr make-composed-keymap.
5209 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5210 (parse_menu_item): Trivial simplification.
5211
3279eb87
GM
52122011-07-01 Glenn Morris <rgm@gnu.org>
5213
5214 * Makefile.in (SETTINGS_LIBS): Fix typo.
5215
4550efdf
KI
52162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5217
5218 * coding.c (Fencode_coding_string): Record the last coding system
5219 used, as the function doc string says (bug#8738).
5220
0949d2b6
JD
52212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5222
5223 * xsettings.c (store_monospaced_changed): Take new font as arg and
5224 check for change against current_mono_font.
5225 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5226 (emacs_settings_constructor, emacs_settings_get_property)
5227 (emacs_settings_set_property, emacs_settings_class_init)
5228 (emacs_settings_init, gsettings_obj): Remove.
5229 (something_changedCB): New function for HAVE_GSETTINGS.
5230 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5231 with value as argument.
5232 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5233 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5234 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5235 "changed".
5236
5237 * xgselect.c: Add defined (HAVE_GSETTINGS).
5238 (xgselect_initialize): Ditto.
5239
5240 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5241 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5242 xg_select.
5243
bbc6b304
PE
52442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 * eval.c (struct backtrace): Simplify and port the data structure.
5247 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5248 signed bit field, as this assumption is not portable and it makes
5249 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5250 "char debug_on_exit : 1" as this is not portable either; instead,
5251 use the portable "unsigned int debug_on_exit : 1". Remove unused
5252 member evalargs. Remove obsolete comments about cc bombing out.
5253
9851bfc5
JD
52542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5255
51bb811f 5256 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5257 Let HAVE_GSETTINGS override HAVE_GCONF.
5258 (store_monospaced_changed): New function.
5259 (EMACS_SETTINGS): A new type derived from GObject to handle
5260 GSettings notifications.
5261 (emacs_settings_constructor, emacs_settings_get_property)
5262 (emacs_settings_set_property, emacs_settings_class_init):
5263 New functions.
5264 (gsettings_client, gsettings_obj): New variables.
5265 (GSETTINGS_SCHEMA): New define.
5266 (something_changedCB): Call store_monospaced_changed.
5267 (init_gsettings): New function.
5268 (xsettings_initialize): Call init_gsettings.
5269 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5270 to NULL.
5271
640c8776 5272 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5273 GCONF_CFLAGS/LIBS.
5274
5386012d
MR
52752011-06-29 Martin Rudalics <rudalics@gmx.at>
5276
5277 * window.c (resize_root_window, grow_mini_window)
5278 (shrink_mini_window): Rename Qresize_root_window to
5279 Qwindow_resize_root_window and Qresize_root_window_vertically to
5280 Qwindow_resize_root_window_vertically.
5281
f13e0b08
PE
52822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5283
5284 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5285
94515237
JB
52862011-06-27 Juanma Barranquero <lekktu@gmail.com>
5287
5288 * makefile.w32-in: Redesign dependencies so they reflect more
5289 clearly which files are directly included by each source file,
5290 and not through other includes.
5291
e43b6e43
MR
52922011-06-27 Martin Rudalics <rudalics@gmx.at>
5293
5294 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5295 (sort_overlays, overlay_strings): When an overlay's clone number
5296 matches the window's clone number process the overlay even if
5297 the overlay's window property doesn't match the current window.
5298
d68443dc
MR
5299 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5300 (Fwindow_hchild): Rename to Fwindow_left_child.
5301 (Fwindow_next): Rename to Fwindow_next_sibling.
5302 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5303 (resize_window_check): Rename to window_resize_check.
5304 (resize_window_apply): Rename to window_resize_apply.
5305 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5306 (Fdelete_other_windows_internal, resize_frame_windows)
5307 (Fsplit_window_internal, Fdelete_window_internal)
5308 (grow_mini_window, shrink_mini_window)
5309 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5310
c7e73be5
JD
53112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5312
5313 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5314 (emacs_fixed_set_min_size): Remove.
5315 (emacs_fixed_new): Take frame as argument.
5316
5317 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5318 (_EmacsFixedPrivate): Remove minwidth/height.
5319 Add struct frame *f.
5320 (emacs_fixed_init): Initialize priv->f.
5321 (get_parent_class, emacs_fixed_set_min_size): Remove.
5322 (emacs_fixed_new): Set priv->f to argument.
5323 (emacs_fixed_get_preferred_width)
5324 (emacs_fixed_get_preferred_height): Use min_width/height from
5325 frames size_hint to set minimum and natural (Bug#8919).
5326 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5327 and use min_width/height from frames size_hint to set
5328 min_width/height (Bug#8919).
5329
5330 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5331 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5332 Fix indentation.
c7e73be5 5333
cf99dcf8
EZ
53342011-06-26 Eli Zaretskii <eliz@gnu.org>
5335
5336 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5337 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5338 called at ZV.
5339
029529ac
CY
53402011-06-26 Chong Yidong <cyd@stupidchicken.com>
5341
5342 * process.c (wait_reading_process_output): Bypass select if
5343 waiting for a cell while ignoring keyboard input, and input is
5344 pending. Suggested by Jan Djärv (Bug#8869).
5345
7a7ef429
PE
53462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 Use gnulib's dup2 module instead of rolling our own.
5349 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5350
11fdef7d 53512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5352
5353 * dispnew.c (scrolling_window): Before scrolling, turn off a
5354 mouse-highlight in the window being scrolled.
5355
cd3520a4
JB
53562011-06-24 Juanma Barranquero <lekktu@gmail.com>
5357
5358 Move DEFSYM to lisp.h and use everywhere.
5359
5360 * character.h (DEFSYM): Move declaration...
5361 * lisp.h (DEFSYM): ...here.
5362
5363 * gnutls.c:
5364 * minibuf.c:
5365 * w32menu.c:
5366 * w32proc.c:
5367 * w32select.c: Don't include character.h.
5368
5369 * alloc.c (syms_of_alloc):
5370 * buffer.c (syms_of_buffer):
5371 * bytecode.c (syms_of_bytecode):
5372 * callint.c (syms_of_callint):
5373 * casefiddle.c (syms_of_casefiddle):
5374 * casetab.c (init_casetab_once):
5375 * category.c (init_category_once, syms_of_category):
5376 * ccl.c (syms_of_ccl):
5377 * cmds.c (syms_of_cmds):
5378 * composite.c (syms_of_composite):
5379 * dbusbind.c (syms_of_dbusbind):
5380 * dired.c (syms_of_dired):
5381 * dispnew.c (syms_of_display):
5382 * doc.c (syms_of_doc):
5383 * editfns.c (syms_of_editfns):
5384 * emacs.c (syms_of_emacs):
5385 * eval.c (syms_of_eval):
5386 * fileio.c (syms_of_fileio):
5387 * fns.c (syms_of_fns):
5388 * frame.c (syms_of_frame):
5389 * fringe.c (syms_of_fringe):
5390 * insdel.c (syms_of_insdel):
5391 * keymap.c (syms_of_keymap):
5392 * lread.c (init_obarray, syms_of_lread):
5393 * macros.c (syms_of_macros):
5394 * msdos.c (syms_of_msdos):
5395 * print.c (syms_of_print):
5396 * process.c (syms_of_process):
5397 * search.c (syms_of_search):
5398 * sound.c (syms_of_sound):
5399 * syntax.c (init_syntax_once, syms_of_syntax):
5400 * terminal.c (syms_of_terminal):
5401 * textprop.c (syms_of_textprop):
5402 * undo.c (syms_of_undo):
5403 * w32.c (globals_of_w32):
5404 * window.c (syms_of_window):
5405 * xdisp.c (syms_of_xdisp):
5406 * xfaces.c (syms_of_xfaces):
5407 * xfns.c (syms_of_xfns):
5408 * xmenu.c (syms_of_xmenu):
5409 * xsettings.c (syms_of_xsettings):
5410 * xterm.c (syms_of_xterm): Use DEFSYM.
5411
4228cf16
TZ
54122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5413
cd3520a4 5414 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5415
7fcccf1e
PE
54162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5417
7efb4e0e
PE
5418 Integer and buffer overflow fixes (Bug#8873).
5419
ff5844ad
PE
5420 * print.c (printchar, strout): Check for string overflow.
5421 (PRINTPREPARE, printchar, strout):
5422 Don't set size unless allocation succeeds.
5423
90532f02
PE
5424 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5425 for sizes. Check for string overflow more accurately.
5426 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5427
6d84508d
PE
5428 * macros.c: Integer and buffer overflow fixes.
5429 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5430 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5431 Use ptrdiff_t, not int, for sizes.
5432 Don't increment bufsize until after realloc succeeds.
5433 Check for size-calculation overflow.
5434 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5435
437b2cb4
PE
5436 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5437
8b9ac8b4
PE
5438 * lread.c: Integer overflow fixes.
5439 (read_integer): Radix is now EMACS_INT, not int,
5440 to improve quality of diagnostics for out-of-range radices.
5441 Calculate buffer size correctly for out-of-range radices.
5442 (read1): Check for integer overflow in radices, and in
5443 read-circle numbers.
82cb60d3
PE
5444 (read_escape): Avoid int overflow.
5445 (Fload, openp, read_buffer_size, read1)
5446 (substitute_object_recurse, read_vector, read_list, map_obarray):
5447 Use ptrdiff_t, not int, for sizes.
5448 (read1): Use EMACS_INT, not int, for sizes.
20270765 5449 Check for size overflow.
8b9ac8b4 5450
7fcccf1e
PE
5451 * image.c (cache_image): Check for size arithmetic overflow.
5452
bfbbd7e7
PE
5453 * lread.c: Integer overflow issues.
5454 (saved_doc_string_size, saved_doc_string_length)
5455 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5456 Now ptrdiff_t, not int.
5457 (read1): Don't assume doc string length fits in int. Check for
5458 out-of-range doc string lengths.
5459 (read_list): Don't assume file position fits in int.
39019e54 5460 (read_escape): Check for hex character overflow.
bfbbd7e7 5461
4e323265
LL
54622011-06-22 Leo Liu <sdl.web@gmail.com>
5463
5464 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5465 Move to minibuffer.el.
5466
85fece3e
PE
54672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5468
20b84ce9 5469 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5470 The following patches are for when GLYPH_DEBUG && !XASSERT.
5471 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5472 * dispnew.c (flush_stdout):
5473 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5474 Mark as externally visible.
5475 * dispnew.c (check_window_matrix_pointers): Now static.
5476 * dispnew.c (window_to_frame_vpos):
5477 * xfns.c (unwind_create_frame):
5478 * xterm.c (x_check_font): Remove unused local.
5479 * scroll.c (CHECK_BOUNDS):
5480 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5481 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5482 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5483 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5484 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5485 Now static.
5486 (debug_method_add): Use va_list and vsprintf rather than relying
5487 on undefined behavior with wrong number of arguments.
5488 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5489 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5490 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5491 since we're not interested in debugging glyphs with old libraries.
5492 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5493 GCC 4.6.0's static checking.
5494
0766b489
PE
54952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5496
31fd4b32
PE
5497 Integer overflow and signedness fixes (Bug#8873).
5498 A few related buffer overrun fixes, too.
5499
b79e8648
PE
5500 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5501
0766b489
PE
5502 * dispextern.h (struct face.stipple):
5503 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5504 (x_bitmap_mask, x_allocate_bitmap_record)
5505 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5506 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5507 (x_create_bitmap_from_xpm_data):
5508 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5509 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5510 (.bitmaps_last):
5511 * xfaces.c (load_pixmap):
5512 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5513 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5514 (.bitmaps_last, struct x_output.icon_bitmap):
5515 Use ptrdiff_t, not int, for bitmap indexes.
5516 (x_allocate_bitmap_record): Check for size overflow.
5517 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5518
b081724f
PE
5519 Use ptrdiff_t, not int, for overlay counts.
5520 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5521 * editfns.c (overlays_around, get_pos_property):
5522 * textprop.c (get_char_property_and_overlay):
5523 * xdisp.c (next_overlay_change, note_mouse_highlight):
5524 * xfaces.c (face_at_buffer_position):
21514da7
PE
5525 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5526 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5527 (Fnext_overlay_change, Fprevious_overlay_change)
5528 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5529 Use ptrdiff_t, not int, for sizes.
21514da7 5530 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5531
3de73e5e
PE
5532 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5533
2606c57b
PE
5534 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5535 (x_session_initialize): Do not assume string length fits in int.
5536
aaafe47a
PE
5537 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5538 This is unlikely, but can occur if DPI is outlandish.
5539
2674ddc8 5540 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5541 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5542
28154962
PE
5543 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5544 * xrdb.c (magic_file_p, search_magic_path):
5545 Omit last arg SUFFIX; it was always 0. All callers changed.
5546 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5547
7de51af5
PE
5548 * xfont.c (xfont_match): Avoid need for strlen.
5549
25ed6cc3
PE
5550 * xfns.c: Don't assume strlen fits in int.
5551 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5552
4eab31dd
PE
5553 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5554 not unsigned long, as we prefer signed integers. All callers changed.
5555 Detect integer overflow in repeat count.
5556 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5557 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5558
171e2a58
PE
5559 * termcap.c: Don't assume sizes fit in int and never overflow.
5560 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5561 (gobble_line): Check for size-calculation overflow.
5562
ad39faca 5563 * minibuf.c (Fread_buffer):
6e5bb2dc 5564 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5565 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5566 Don't assume string length fits in int.
5567
52c61c22 5568 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5569 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5570
b5b8c9e5
PE
5571 * font.c: Don't assume string length fits in int.
5572 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5573 Use ptrdiff_t, not int.
ccd6111c
PE
5574 (font_intern_prop): Don't assume string length fits in int.
5575 Don't assume integer property fits in fixnum.
5576 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5577
882f0d81 5578 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5579 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5580 Reformulate so as not to need the command string.
5581 Invoke gzip -cd rather than gunzip, as it's more portable.
5582 (lock_info_type, lock_file_1, lock_file):
5583 Don't assume pid_t and time_t fit in unsigned long.
5584 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5585 (current_lock_owner): Prefer signed type for sizes.
5586 Use memcpy, not strncpy, where memcpy is what is really wanted.
5587 Don't assume (via atoi) that time_t and pid_t fit in int.
5588 Check for time_t and/or pid_t out of range, e.g., via a network share.
5589 Don't alloca where an auto var works fine.
5590
93f4cf88
PE
5591 * fileio.c: Fix some integer overflow issues.
5592 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5593 Don't assume string length fits in int.
5594 (directory_file_name): Don't assume string length fits in long.
5595 (make_temp_name): Don't assume pid fits in int, or that its print
5596 length is less than 20.
5597
f3e92b69
PE
5598 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5599
1bfdaf10
PE
5600 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5601
35016e9a
PE
5602 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5603
3d1e65a1
PE
5604 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5605 We prefer signed integers, even for size calculations.
5606
0b963a93
PE
5607 * emacs.c: Don't assume string length fits in 'int'.
5608 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5609 (main): Don't invoke strlen when not needed.
5610
573f4b54
PE
5611 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5612 (XD_DEBUG_MESSAGE): Don't waste a byte.
5613
989f33ba
PE
5614 * callproc.c (getenv_internal_1, getenv_internal)
5615 (Fgetenv_internal):
965d34eb
PE
5616 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5617
e4d29b33
PE
5618 * lread.c (invalid_syntax): Omit length argument.
5619 All uses changed. This doesn't fix a bug, but it simplifies the
5620 code away from its former Hollerith-constant appearance, and it's
5621 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5622 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5623
eb49b136
PE
5624 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5625 This didn't break anything, but it didn't help either.
5626 It's confusing to put a bogus integer in a place where the actual
5627 value does not matter.
9f62aeb1 5628 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5629 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5630
15375a22
PE
5631 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5632 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5633 implementation.
b61cc01c
PE
5634 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5635 We prefer signed types, and the value cannot exceed the EMACS_INT
5636 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5637 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5638 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5639 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5640
53b2623d
PE
5641 * indent.c (sane_tab_width): New function.
5642 (current_column, scan_for_column, Findent_to, position_indentation)
5643 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5644 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5645
51cab52b 5646 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5647
f2ed8a70
PE
5648 * lisp.h (lint_assume): New macro.
5649 * composite.c (composition_gstring_put_cache):
5650 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5651
abe80cc6
PE
5652 * editfns.c, insdel.c:
5653 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5654
b02c740e
PE
5655 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5656
ebc96716
PE
5657 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5658
b4e50fa0 5659 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5660 Use much-faster test for byte-length change.
311d5d7c 5661 Don't assume string byte-length fits in 'int'.
a4cf38e4 5662 Check that character arg fits in 'int'.
85461888 5663 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5664
c0c1ee9f
PE
5665 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5666
a498d7f4
PE
5667 * fns.c (concat): Catch string overflow earlier.
5668 Do not rely on integer wraparound.
5669
51cab52b
PE
5670 * dispextern.h (struct it.overlay_strings_charpos)
5671 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5672 * xdisp.c (forward_to_next_line_start)
5673 (back_to_previous_visible_line_start)
5674 (reseat_at_next_visible_line_start, next_element_from_buffer):
5675 Don't arbitrarily truncate the value of 'selective' to int.
5676
76031fad
PE
5677 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5678
5eb55db9
PE
5679 * composite.c: Don't truncate sizes to 'int'.
5680 (composition_gstring_p, composition_reseat_it)
5681 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5682 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5683 not EMACS_UINT, for indexes.
5eb55db9 5684
0703a717
PE
5685 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5686
d6202519
PE
5687 * buffer.c: Include <verify.h>.
5688 (struct sortvec.priority, struct sortstr.priority):
8961a454 5689 Now EMACS_INT, not int.
c20998a7 5690 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5691 (struct sortstr.size, record_overlay_string)
5692 (struct sortstrlist.size, struct sortlist.used):
5693 Don't truncate size to int.
5694 (record_overlay_string): Check for size-calculation overflow.
d6202519 5695 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5696
d5a19415
JM
56972011-06-22 Jim Meyering <meyering@redhat.com>
5698
029529ac 5699 Don't leak an XBM-image-sized buffer
d5a19415
JM
5700 * image.c (xbm_load): Free the image buffer after using it.
5701
a9041e6c
PE
57022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 Port to Sun C.
5705 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5706 that Sun C diagnosed.
5707 * fns.c (secure_hash): Fix pointer signedness issue.
5708 * intervals.c (static_offset_intervals): New function.
5709 (offset_intervals): Use it.
5710
7f3f739f
LL
57112011-06-21 Leo Liu <sdl.web@gmail.com>
5712
5713 * deps.mk (fns.o):
5714 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5715 sha512.h.
5716
5717 * fns.c (secure_hash): Rename from crypto_hash_function and change
5718 the first arg to accept symbols.
5b66d427 5719 (Fsecure_hash): New primitive.
7f3f739f
LL
5720 (syms_of_fns): New symbols.
5721
76147d94
DD
57222011-06-20 Deniz Dogan <deniz@dogan.se>
5723
5724 * process.c (Fset_process_buffer): Clarify return value in
5725 docstring.
5726
7d7d0045
CY
57272011-06-18 Chong Yidong <cyd@stupidchicken.com>
5728
5729 * dispnew.c (add_window_display_history): Use BVAR.
5730
5731 * xdisp.c (debug_method_add): Use BVAR.
5732 (check_window_end, dump_glyph_matrix, dump_glyph)
5733 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5734
5735 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5736 Likewise.
5737
5738 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5739 check till after the cache is created in init_frame_faces.
5740
ff2bc410
SM
57412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5742
5743 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5744
28177add
PE
57452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5746
dd3482fe
PE
5747 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5748 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5749 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5750
393d71f3 5751 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5752 * fileio.c (Finsert_file_contents):
5753 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5754 Remove the old (too-loose) buffer overflow checks.
5755 They weren't needed, since make_gap checks for buffer overflow.
5756 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5757 The old code merely checked for Emacs fixnum overflow, and relied
5758 on undefined (wraparound) behavior. The new code avoids undefined
5759 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5760
2e6813b0 5761 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5762 Tune. Don't use wider integers than needed. Don't use alloca.
5763 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5764
599a9e4f
PE
5765 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5766
99561444
PE
5767 * insdel.c, lisp.h (buffer_overflow): New function.
5768 (insert_from_buffer_1, replace_range, replace_range_2):
5769 * insdel.c (make_gap_larger):
5770 * editfns.c (Finsert_char):
5771 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5772
28177add
PE
5773 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5774
e69dafad
PE
57752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5776
4baa020d 5777 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5778
b1c46f02
PE
5779 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5780 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5781
e69dafad
PE
5782 * fileio.c: Don't assume EMACS_INT fits in off_t.
5783 (emacs_lseek): New static function.
5784 (Finsert_file_contents, Fwrite_region): Use it.
5785 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5786
566684ea
PE
5787 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5788
e6966cd6
PE
5789 * fns.c: Don't overflow int when computing a list length.
5790 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5791 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5792 truncation on 64-bit hosts. Check for QUIT every
5793 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5794 faster and is responsive enough.
5795 (Flength): Report an error instead of overflowing an integer.
5796 (Fsafe_length): Return a float if the value is not representable
5797 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5798 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5799 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5800
dd0b0efb
PE
5801 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5802 (header_size, word_size): New constants.
5803 (allocate_vectorlike): Don't check size overflow here.
5804 (allocate_vector): Check it here instead, since this is the only
5805 caller of allocate_vectorlike that could cause overflow.
5806 Check that the new vector's length is representable as a fixnum.
5807
86fe5cfe
PE
5808 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5809 The previous code was bogus. For example, next_almost_prime (32)
5810 returned 39, which is undesirable as it is a multiple of 3; and
5811 next_almost_prime (24) returned 25, which is a multiple of 5 so
5812 why was the code bothering to check for multiples of 7?
5813
80e88859
PE
5814 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5815
4a2f0ad6
PE
5816 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5817
f66c7cf8
PE
5818 Variadic C functions now count arguments with ptrdiff_t.
5819 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5820 Back then I didn't know that the Emacs coding style prefers signed int.
5821 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5822 were being counted with int, which may truncate counts on 64-bit
5823 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5824 * lisp.h (struct Lisp_Subr.function.aMANY)
5825 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5826 Arg counts are now ptrdiff_t, not size_t.
5827 All variadic functions and their callers changed accordingly.
5828 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5829 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5830 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5831 * callint.c (Fcall_interactively): Check arg count for overflow,
5832 to avoid potential buffer overrun. Use signed char, not 'int',
5833 for 'varies' array, so that we needn't bother to check its size
5834 calculation for overflow.
5835 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5836 * eval.c (apply_lambda):
5837 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5838 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5839 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5840
a1759b76
PE
5841 * callint.c (Fcall_interactively): Don't use index var as event count.
5842
d96be9fc
PE
5843 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5844 * mem-limits.h (SIZE): Remove; no longer used.
5845
a690a978 5846 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5847
578c21e6
PE
5848 Remove unnecessary casts.
5849 * xterm.c (x_term_init):
5850 * xfns.c (x_set_border_pixel):
5851 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5852 These aren't needed now that we assume ANSI C.
5853
96f53c6c
PE
5854 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5855 It's more likely to cause problems (due to unsigned overflow)
5856 than to cure them.
5857
83c77d31
PE
5858 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5859
ee2079f1
PE
5860 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5861
6da65536
PE
5862 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5863
7147c4a4
PE
5864 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5865
193e32d9
PE
5866 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5867
e5533da6
PE
5868 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5869
9910e595
PE
5870 GLYPH_CODE_FACE returns EMACS_INT, not int.
5871 * dispextern.h (merge_faces):
5872 * xfaces.c (merge_faces):
01103c44
PE
5873 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5874 Don't assume EMACS_INT fits in int.
9910e595 5875
2638320e
PE
5876 * character.h (CHAR_VALID_P): Remove unused parameter.
5877 * fontset.c, lisp.h, xdisp.c: All uses changed.
5878
045eb8d9
PE
5879 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5880
c1f134b5
PE
5881 * fns.c (concat): Minor tuning based on overflow analysis.
5882 This doesn't fix any bugs. Use int to hold character, instead
5883 of constantly refetching from Emacs object. Use XFASTINT, not
5884 XINT, for value known to be a character. Don't bother comparing
5885 a single byte to 0400, as it's always less.
5886
395fcb93 5887 * floatfns.c (Fexpt):
327eeec8
PE
5888 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5889
abbd3d23
PE
5890 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5891 for characters.
5892
684a03ef
PE
5893 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5894
0fed43f3
PE
5895 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5896 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5897 incorrectly succeed when S was a string, because 4294967386 was
5898 truncated before it was used.
5899
8fd02eb7
PE
5900 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5901 Otherwise, an out-of-range integer could cause undefined behavior
5902 on a 64-bit host.
5903
f8c86b69
PE
5904 * composite.c: Use int, not EMACS_INT, for characters.
5905 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5906 EMACS_INT, for values that are known to be in character range.
5907 This doesn't fix any bugs but is the usual style inside Emacs and
5908 may generate better code on 32-bit machines.
5909
34206dd2
PE
5910 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5911 This is for reasons similar to the recent CHAR_STRING fix.
5912 * charset.c (Fencode_char): Check that character arg is actually
5913 a character. Pass an int to ENCODE_CHAR.
5914 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5915 wider than 'int', as a compile-time check to prevent future regressions
5916 in this area.
5917
c5958d4c 5918 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5919
5920 Make sure a 64-bit char is never passed to CHAR_STRING.
5921 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5922 by silently ignoring the top 32 bits, allowing some values
5923 that were far too large to be valid characters.
5924 * character.h: Include <verify.h>.
5925 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5926 arguments are no wider than unsigned, as a compile-time check
5927 to prevent future regressions in this area.
5928 * data.c (Faset):
01103c44 5929 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5930 (Fsubst_char_in_region):
5931 * fns.c (concat):
5932 * xdisp.c (decode_mode_spec_coding):
5933 Adjust to CHAR_STRING's new requirement.
5934 * editfns.c (Finsert_char, Fsubst_char_in_region):
5935 * fns.c (concat): Check that character args are actually
5936 characters. Without this test, these functions did the wrong
5937 thing with wildly out-of-range values on 64-bit hosts.
5938
d37ca623
PE
5939 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5940 These casts should not be needed on 32-bit hosts, either.
5941 * keyboard.c (read_char):
5942 * lread.c (Fload): Remove casts to unsigned.
5943
ea204efb
PE
5944 * lisp.h (UNSIGNED_CMP): New macro.
5945 This fixes comparison bugs on 64-bit hosts.
5946 (ASCII_CHAR_P): Use it.
5947 * casefiddle.c (casify_object):
01103c44 5948 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5949 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5950 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5951 * dispextern.h (FACE_FROM_ID):
5952 * keyboard.c (read_char): Use UNSIGNED_CMP.
5953
41cb286c
PE
5954 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5955 not to EMACS_INT, to avoid GCC warning.
5956
4a1b9832
PE
5957 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5958
55daad71
PE
5959 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5960 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5961 isn't needed on 32-bit machines.
8f95c75c 5962
01103c44
PE
5963 * buffer.c (Fgenerate_new_buffer_name):
5964 Use EMACS_INT for count, not int.
0ceccced 5965 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5966
5967 * data.c (Qcompiled_function): Now static.
5968
c6f072e7
PE
5969 * window.c (window_body_lines): Now static.
5970
20ce5912
PE
5971 * image.c (gif_load): Rename local to avoid shadowing.
5972
9c4c5f81
PE
5973 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5974 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5975 * alloc.c (make_save_value): Integer argument is now of type
5976 ptrdiff_t, not int.
5977 (mark_object): Use ptrdiff_t, not int.
5978 * lisp.h (pD): New macro.
5979 * print.c (print_object): Use it.
5980
c0c5c8ae
PE
5981 * alloc.c: Use EMACS_INT, not int, to count objects.
5982 (total_conses, total_markers, total_symbols, total_vector_size)
5983 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5984 (total_free_floats, total_floats, total_free_intervals)
5985 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5986 Now EMACS_INT, not int. All uses changed.
5987 (Fgarbage_collect): Compute overall total using a double, so that
5988 integer overflow is less likely to be a problem. Check for overflow
5989 when converting back to an integer.
5a25e253
PE
5990 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5991 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5992 These were 'int' variables that could overflow on 64-bit hosts;
5993 they were never used, so remove them instead of repairing them.
211a0b2a 5994 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5995 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5996 Previously, this ceilinged at INT_MAX, but that doesn't work on
5997 64-bit machines.
e46bb31a 5998 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5999
c78baabf 6000 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6001 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6002 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6003 when a (possibly-narrower) signed value would do just as well.
6004 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6005
c9d624c6
PE
6006 * alloc.c: Catch some string size overflows that we were missing.
6007 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6008 for convenience in STRING_BYTES_MAX.
6009 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6010 The definition here is exact; the one in lisp.h was approximate.
6011 (allocate_string_data): Check for string overflow. This catches
6012 some instances we weren't catching before. Also, it catches
6013 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6014 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6015 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6016
c9d624c6
PE
6017 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6018 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6019 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6020
353032ce
PE
6021 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6022
2bccce07
PE
6023 * alloc.c (Fmake_string): Check for out-of-range init.
6024
0ac30604
SM
60252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6026
6027 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6028
c195f2de
JD
60292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6030
6031 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6032 xg_get_default_scrollbar_width.
6033
6034 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6035 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6036 (style_changed_cb): Call update_theme_scrollbar_width and call
6037 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6038 all frames (Bug#8505).
6039 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6040 Call gtk_window_set_resizable if HAVE_GTK3.
6041 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6042 and height if HAVE_GTK3 (Bug#8505).
6043 (scroll_bar_width_for_theme): New variable.
6044 (update_theme_scrollbar_width): New function.
6045 (xg_get_default_scrollbar_width): Move code to
6046 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6047 (xg_initialize): Call update_theme_scrollbar_width.
6048
6049 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6050
6051 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6052
e10ac9f1
MR
60532011-06-12 Martin Rudalics <rudalics@gmx.at>
6054
6055 * frame.c (make_frame): Call other_buffer_safely instead of
6056 other_buffer.
6057
6058 * window.c (temp_output_buffer_show): Call display_buffer with
6059 second argument Vtemp_buffer_show_specifiers and reset latter
6060 immediately after the call.
6061 (Vtemp_buffer_show_specifiers): New variable.
6062 (auto_window_vscroll_p, next_screen_context_lines)
6063 (Vscroll_preserve_screen_position): Remove leading asterisks from
6064 doc-strings.
6065
2d3c217e 60662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6067
7b7f97e8 6068 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6069 * buffer.c (Qclone_number): Remove for now, as it's unused.
6070 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6071 (record_buffer): Remove unused local.
6072 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6073 (set_frame_buffer_list): Remove; unused.
6074 * frame.h (other_visible_frames): Remove decl.
6075 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6076 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6077 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6078 if HAVE_GPM.
6079 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6080 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6081 Define only if HAVE_GPM.
6082 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6083 (update_hints_inhibit): Remove; never set. All uses removed.
6084 * widgetprv.h (emacsFrameClassRec): Remove decl.
6085 * window.c (delete_deletable_window): Now returns void, since it
6086 wasn't returning anything.
6087 (compare_window_configurations): Remove unused locals.
6088 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6089 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6090 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6091 the same widths as pointers. This follows up on the 2011-05-06 patch.
6092 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6093 * xterm.h: Likewise.
6094 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6095
1384b89e
JB
60962011-06-12 Juanma Barranquero <lekktu@gmail.com>
6097
6098 * makefile.w32-in: Update dependencies.
6099 (LISP_H): Add lib/intprops.h.
6100
1100a63c
CY
61012011-06-11 Chong Yidong <cyd@stupidchicken.com>
6102
6103 * image.c (gif_load): Add animation frame delay to the metadata.
6104 (syms_of_image): Use DEFSYM. New symbol `delay'.
6105
6198ccd0
MR
61062011-06-11 Martin Rudalics <rudalics@gmx.at>
6107
6108 * window.c (delete_deletable_window): Re-add.
6109 (Fset_window_configuration): Rewrite to handle dead buffers and
6110 consequently deletable windows.
6111 (window_tree, Fwindow_tree): Remove. Supply functionality in
6112 window.el.
6113 (compare_window_configurations): Simplify code.
6114
b6e3633c
AS
61152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6116
1ab0dee5
AS
6117 * image.c (imagemagick_load_image): Fix type mismatch.
6118 (Fimagemagick_types): Likewise.
6119
b6e3633c
AS
6120 * window.h (replace_buffer_in_windows): Declare.
6121
9397e56f
MR
61222011-06-11 Martin Rudalics <rudalics@gmx.at>
6123
6124 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6125 Qclone_number. Remove external declaration of Qdelete_window.
6126 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6127 code.
640c8776
SM
6128 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6129 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6130 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6131 buffer list implementation.
6132 (other_buffer_safely): New function.
6133 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6134 calls to replace_buffer_in_windows and
6135 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6136 if allowed.
6137 (record_buffer): Inhibit quitting and rewrite using quittable
6138 functions. Run Qbuffer_list_update_hook if allowed.
6139 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6140 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6141 Move switch-to-buffer to window.el.
9397e56f
MR
6142 (bury-buffer): Move to window.el.
6143 (Vbuffer_list_update_hook): New variable.
6144
6145 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6146 section.
6147
6148 * window.h (resize_frame_windows): Move up in code.
6149 (Fwindow_frame): Remove EXFUN.
6150 (replace_buffer_in_all_windows): Remove prototype.
6151 (replace_buffer_in_windows_safely): Add prototype.
6152
6153 * window.c: Declare Qdelete_window static again. Move down
6154 declaration of select_count.
6155 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6156 (Fother_window): Move to window.el.
6157 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6158 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6159 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6160 window.el.
6161 (replace_buffer_in_windows): Implement by calling
6162 Qreplace_buffer_in_windows.
6163 (replace_buffer_in_all_windows): Remove with some functionality
6164 moved into replace_buffer_in_windows_safely.
6165 (replace_buffer_in_windows_safely): New function.
6166 (select_window_norecord, select_frame_norecord): Move in front
6167 of run_window_configuration_change_hook. Remove now obsolete
6168 declarations.
640c8776
SM
6169 (Fset_window_buffer): Rewrite doc-string.
6170 Call Qrecord_window_buffer.
9397e56f
MR
6171 (keys_of_window): Move binding for other-window to window.el.
6172
b50691aa
CY
61732011-06-11 Chong Yidong <cyd@stupidchicken.com>
6174
6175 * dispextern.h (struct image): Replace data member, whose int_val
6176 and ptr_val fields were not used by anything, with a single
6177 lisp_val object.
6178
6179 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6180 (gif_clear_image, gif_load, imagemagick_load_image)
6181 (gs_clear_image, gs_load): Callers changed.
6182
3f754b86
PE
61832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6184
cca69397
PE
6185 * buffer.h: Include <time.h>, for time_t.
6186 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6187
109e28d0
PE
6188 Fix minor problems found by static checking.
6189
60737f02
PE
6190 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6191
4b66faf3
PE
6192 Make identifiers static if they are not used in other modules.
6193 * data.c (Qcompiled_function, Qframe, Qvector):
6194 * image.c (QimageMagick, Qsvg):
6195 * minibuf.c (Qmetadata):
6196 * window.c (resize_window_check, resize_root_window): Now static.
6197 * window.h (resize_window_check, resize_root_window): Remove decls.
6198
109e28d0
PE
6199 * window.c (window_deletion_count, delete_deletable_window):
6200 Remove; unused.
46a4ce9e
PE
6201 (window_body_lines): Now static.
6202 (Fdelete_other_windows_internal): Mark vars as initialized.
6203 Make sure 'resize_failed' is initialized.
6204 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6205 (resize_window_apply): Remove unused local.
6206 * window.h (delete_deletable_window): Remove decl.
6207
109e28d0 6208 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6209 (imagemagick_load_image): Fix pointer signedness problem by changing
6210 last arg from unsigned char * to char *. All uses changed.
6211 Also, fix a local for similar reasons.
6212 Remove unused locals. Remove locals to avoid shadowing.
6213 (fn_rsvg_handle_free): Remove; unused.
6214 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6215 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6216
3f754b86
PE
6217 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6218
2547adb1
CY
62192011-06-10 Chong Yidong <cyd@stupidchicken.com>
6220
6221 * image.c (gif_load): Fix omitted cast error introduced by
6222 2011-06-06 change.
6223
2c8e37d4
MR
62242011-06-10 Martin Rudalics <rudalics@gmx.at>
6225
6226 * window.h (resize_proportionally, orig_total_lines)
6227 (orig_top_line): Remove from window structure.
6228 (set_window_height, set_window_width, change_window_heights)
6229 (Fdelete_window): Remove prototypes.
6230 (resize_frame_windows): Remove duplicate declaration.
6231
440a42e3
EZ
62322011-06-10 Eli Zaretskii <eliz@gnu.org>
6233
6234 * window.h (resize_frame_windows, resize_window_check)
6235 (delete_deletable_window, resize_root_window)
6236 (resize_frame_windows): Declare prototypes.
6237
6238 * window.c (resize_window_apply): Make definition be "static" to
6239 match the prototype.
6240
562dd5e9
MR
62412011-06-10 Martin Rudalics <rudalics@gmx.at>
6242
6243 * window.c: Remove declarations of Qwindow_size_fixed,
6244 window_min_size_1, window_min_size_2, window_min_size,
6245 size_window, window_fixed_size_p, enlarge_window, delete_window.
6246 Remove static from declaration of Qdelete_window, it's
6247 temporarily needed by Fbury_buffer.
6248 (replace_window): Don't assign orig_top_line and
6249 orig_total_lines.
6250 (Fdelete_window, delete_window): Remove. Window deletion is
6251 handled by window.el.
640c8776
SM
6252 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6253 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6254 (Fdelete_other_windows): Remove. Deleting other windows is
6255 handled by window.el.
6256 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6257 handled in window.el.
6258 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6259 Window minimum sizes are handled in window.el.
6260 (shrink_windows, size_window, set_window_height)
6261 (set_window_width, change_window_heights, window_height)
6262 (window_width, CURBEG, CURSIZE, enlarge_window)
6263 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6264 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6265 handled in window.el.
6266 (make_dummy_parent): Rename to make_parent_window and give it a
6267 second argument horflag.
6268 (make_window): Don't set resize_proportionally any more.
6269 (Fsplit_window): Remove. Windows are split in window.el.
6270 (save_restore_action, save_restore_orig_size)
6271 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6272 Resize mini windows in window.el.
6273 (grow_mini_window, shrink_mini_window): Implement by calling
6274 Qresize_root_window_vertically, resize_window_check and
6275 resize_window_apply.
640c8776
SM
6276 (saved_window, Fset_window_configuration, save_window_save):
6277 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6278 resize_proportionally.
6279 (window_min_height, window_min_width): Move to window.el.
6280 (keys_of_window): Move bindings for delete-other-windows,
6281 split-window, delete-window and enlarge-window to window.el.
6282
6283 * buffer.c: Temporarily extern Qdelete_window.
6284 (Fbury_buffer): Temporarily call Qdelete_window instead of
6285 Fdelete_window (Fbury_buffer will move to window.el soon).
6286
6287 * frame.c (set_menu_bar_lines_1): Remove code handling
6288 orig_top_line and orig_total_lines.
6289
6290 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6291 set_window_height but set heights directly.
6292 (change_frame_size_1): Use resize_frame_windows.
6293
6294 * xdisp.c (init_xdisp): Don't use set_window_height but set
6295 heights directly.
6296
640c8776
SM
6297 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6298 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6299 run_window_configuration_change_hook.
6300
6301 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6302 instead of change_window_heights and run
6303 run_window_configuration_change_hook.
6304
1a13852e
MR
63052011-06-09 Martin Rudalics <rudalics@gmx.at>
6306
6307 * window.c (replace_window): Rename second argument REPLACEMENT to
6308 NEW. New third argument SETFLAG. Rewrite.
6309 (delete_window, make_dummy_parent): Call replace_window with
6310 third argument 1.
6311 (window_list_1): Move down in code.
6312 (run_window_configuration_change_hook): Move set_buffer part
6313 before select_frame_norecord part in order to unwind correctly.
6314 Rename count1 to count.
6315 (recombine_windows, delete_deletable_window, resize_root_window)
6316 (Fdelete_other_windows_internal)
6317 (Frun_window_configuration_change_hook, make_parent_window)
6318 (resize_window_check, resize_window_apply, Fresize_window_apply)
6319 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6320 (Fdelete_window_internal, Fresize_mini_window_internal):
6321 New functions.
1a13852e
MR
6322 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6323
f3d1777e
MR
63242011-06-08 Martin Rudalics <rudalics@gmx.at>
6325
496e208e
MR
6326 * window.h (window): Add some new members to window structure -
6327 normal_lines, normal_cols, new_total, new_normal, clone_number,
6328 splits, nest, prev_buffers, next_buffers.
6329 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6330 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6331
f3d1777e
MR
6332 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6333 Remove.
496e208e
MR
6334 (make_dummy_parent): Set new members of windows structure.
6335 (make_window): Move down in code. Handle new members of window
6336 structure.
6337 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6338 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6339 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6340 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6341 (Fset_window_next_buffers, Fset_window_clone_number):
6342 New functions.
496e208e
MR
6343 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6344 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6345 Doc-string fixes.
6346 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6347 Argument WINDOW can be now internal window too.
6348 (Fwindow_use_time): Move up in code.
6349 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6350 Rewrite doc-string.
6351 (Fset_window_configuration, saved_window)
6352 (Fcurrent_window_configuration, save_window_save): Handle new
6353 members of window structure.
b9e809c2
MR
6354 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6355 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6356 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6357 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6358 Qget_mru_window, Qresize_root_window,
6359 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6360 Qauto_buffer_name; staticpro them.
f3d1777e 6361
abde8f8c
MR
63622011-06-07 Martin Rudalics <rudalics@gmx.at>
6363
6364 * window.c (Fwindow_total_size, Fwindow_left_column)
6365 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6366 (Fwindow_list_1): New functions.
6367 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6368 (Fwindow_width, Fscroll_left, Fscroll_right):
6369 Use window_body_cols instead of window_box_text_cols.
6370 (delete_window, Fset_window_configuration):
6371 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6372 (delete_all_subwindows): Take a window as argument and not a
6373 structure. Rewrite.
190b47e6
MR
6374 (window_loop): Remove handling of GET_LRU_WINDOW and
6375 GET_LARGEST_WINDOW.
6376 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6377
6378 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6379 window_box_text_cols. delete_all_subwindows now takes a
6380 Lisp_Object as argument.
abde8f8c 6381
640c8776
SM
6382 * indent.c (compute_motion, Fcompute_motion):
6383 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6384
fa8a67e6
MR
6385 * frame.c (delete_frame): Call delete_all_subwindows with root
6386 window as argument.
6387
a54e3482
DC
63882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6389
6390 * fns.c (Fputhash): Document return value.
6391
60002bf5
CY
63922011-06-06 Chong Yidong <cyd@stupidchicken.com>
6393
6394 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6395
0c671da6 63962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6397
b862a52a 6398 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6399
be44ca6c
PE
6400 Check for overflow when converting integer to cons and back.
6401 * charset.c (Fdefine_charset_internal, Fdecode_char):
6402 Use cons_to_unsigned to catch overflow.
6403 (Fencode_char): Use INTEGER_TO_CONS.
6404 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6405 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6406 * data.c (long_to_cons, cons_to_long): Remove.
6407 (cons_to_unsigned, cons_to_signed): New functions.
6408 These signal an error for invalid or out-of-range values.
6409 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6410 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6411 * font.c (Ffont_variation_glyphs):
6412 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6413 * lisp.h: Include <intprops.h>.
6414 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6415 (cons_to_signed, cons_to_unsigned): New decls.
6416 (long_to_cons, cons_to_long): Remove decls.
6417 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6418 (Fprimitive_undo): Use CONS_TO_INTEGER.
6419 * xfns.c (Fx_window_property): Likewise.
6420 * xselect.c: Include <limits.h>.
6421 (x_own_selection, selection_data_to_lisp_data):
6422 Use INTEGER_TO_CONS.
6423 (x_handle_selection_request, x_handle_selection_clear)
6424 (x_get_foreign_selection, Fx_disown_selection_internal)
6425 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6426 (lisp_data_to_selection_data): Use cons_to_unsigned.
6427 (x_fill_property_data): Use cons_to_signed.
6428 Report values out of range.
6429
d1f3d2af
PE
6430 Check for buffer and string overflow more precisely.
6431 * buffer.h (BUF_BYTES_MAX): New macro.
6432 * lisp.h (STRING_BYTES_MAX): New macro.
6433 * alloc.c (Fmake_string):
6434 * character.c (string_escape_byte8):
6435 * coding.c (coding_alloc_by_realloc):
6436 * doprnt.c (doprnt):
6437 * editfns.c (Fformat):
6438 * eval.c (verror):
6439 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6440 since they may not be the same number.
6441 * editfns.c (Finsert_char):
6442 * fileio.c (Finsert_file_contents):
6443 Likewise for BUF_BYTES_MAX.
6444
dd52fcea
PE
6445 * image.c: Use ptrdiff_t, not int, for sizes.
6446 (slurp_file): Switch from int to ptrdiff_t.
6447 All uses changed.
6448 (slurp_file): Check that file size fits in both size_t (for
6449 malloc) and ptrdiff_t (for sanity and safety).
6450
7f9bbdbb
PE
6451 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6452 if b->modtime has its maximal value.
6453
dfe18f82
PE
6454 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6455
84acfcf0
PE
6456 Don't assume time_t can fit into int.
6457 * buffer.h (struct buffer.modtime): Now time_t, not int.
6458 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6459 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6460
ccd9a01a
PE
6461 Minor fixes for signed vs unsigned integers.
6462 * character.h (MAYBE_UNIFY_CHAR):
6463 * charset.c (maybe_unify_char):
6464 * keyboard.c (read_char, reorder_modifiers):
6465 XINT -> XFASTINT, since the integer must be nonnegative.
6466 * ftfont.c (ftfont_spec_pattern):
6467 * keymap.c (access_keymap, silly_event_symbol_error):
6468 XUINT -> XFASTINT, since the integer must be nonnegative.
6469 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6470 since it makes no difference and we prefer signed.
6471 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6472 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6473 nonnegative.
6474
d6d100dd
SM
64752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6476
6477 * window.h (Fwindow_frame): Declare.
6478
2b6148e4
PE
64792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6480
6481 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6482 (SPARE_MEMORY): Always define.
6483 (LARGE_REQUEST): Remove.
6484 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6485
f230ecc9
MR
64862011-06-06 Martin Rudalics <rudalics@gmx.at>
6487
727e958e
MR
6488 * lisp.h: Move EXFUNS for Fframe_root_window,
6489 Fframe_first_window and Fset_frame_selected_window to window.h.
6490
6491 * window.h: Move EXFUNS for Fframe_root_window,
6492 Fframe_first_window and Fset_frame_selected_window here from
6493 lisp.h.
6494
6495 * frame.c (Fwindow_frame, Fframe_first_window)
6496 (Fframe_root_window, Fframe_selected_window)
6497 (Fset_frame_selected_window): Move to window.c.
6498 (Factive_minibuffer_window): Move to minibuf.c.
6499 (Fother_visible_frames_p): New function.
6500
6501 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6502
f230ecc9
MR
6503 * window.c (decode_window, decode_any_window): Move up in code.
6504 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6505 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6506 (Fwindow_buffer): Move up and rewrite doc-string.
6507 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6508 (Fwindow_prev): New functions.
727e958e
MR
6509 (Fwindow_frame): Move here from frame.c. Accept any window as
6510 argument.
6511 (Fframe_root_window, Fframe_first_window)
6512 (Fframe_selected_window): Move here from frame.c. Accept frame
6513 or arbitrary window as argument. Update doc-strings.
6514 (Fminibuffer_window): Move up in code.
6515 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6516 (Fset_frame_selected_window): Move here from frame.c.
6517 Marginal rewrite.
727e958e
MR
6518 (Fselected_window, select_window, Fselect_window): Move up in
6519 code. Minor doc-string fixes.
f230ecc9 6520
4d09bcf6
PE
65212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6522
6523 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6524 Do not assume that spare memory exists; that assumption is valid
6525 only if SYSTEM_MALLOC.
6526 (LARGE_REQUEST): New macro, so that the issue of large requests
6527 is separated from the issue of spare memory.
6528
810928a2
AS
65292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6530
172418ad
AS
6531 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6532 format. (Bug#8806)
6533
43f862f7
AS
6534 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6535
810928a2
AS
6536 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6537 before statements.
6538
a059fe24
JD
65392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6540
6541 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6542
6543 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6544
6545 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6546 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6547
989bf368
JB
65482011-06-05 Juanma Barranquero <lekktu@gmail.com>
6549
6550 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6551
4b80f674
CY
65522011-06-04 Chong Yidong <cyd@stupidchicken.com>
6553
6554 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6555 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6556 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6557 New error handlers.
4b80f674
CY
6558 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6559 Obey Vx_select_enable_clipboard_manager. Catch errors in
6560 x_clipboard_manager_save (Bug#8779).
6561 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6562 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6563
99a33b77 65642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6565
6566 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6567
99a33b77 65682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6569
6570 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6571 in the current matrix if keep_current_p is non-zero.
6572
8264569d
EZ
65732011-06-04 Eli Zaretskii <eliz@gnu.org>
6574
6575 * bidi.c (bidi_level_of_next_char): Fix last change.
6576
57f97249
EZ
65772011-06-03 Eli Zaretskii <eliz@gnu.org>
6578
fec2107c 6579 Support bidi reordering of text covered by display properties.
57f97249 6580
fec2107c
EZ
6581 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6582 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6583 (bidi_cache_search, bidi_cache_iterator_state)
6584 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6585 (bidi_level_of_next_char, bidi_move_to_visually_next):
6586 Support character positions inside a run of characters covered by a
fec2107c
EZ
6587 display string.
6588 (bidi_paragraph_init, bidi_resolve_explicit_1)
6589 (bidi_level_of_next_char): Call bidi_fetch_char and
6590 bidi_fetch_char_advance instead of FETCH_CHAR and
6591 FETCH_CHAR_ADVANCE.
6592 (bidi_init_it): Initialize new members.
6593 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6594 definitions.
6595 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6596 instead of using explicit *_CHAR codes.
d6d100dd
SM
6597 (bidi_resolve_explicit, bidi_resolve_weak):
6598 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6599 bidirectional text is supported only in multibyte buffers.
6600 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6601 it to initialize the frame_window_p member of struct bidi_it.
6602 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6603 (bidi_resolve_explicit, bidi_resolve_weak)
6604 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6605 bidi_it->nchars is non-positive.
6606 (bidi_level_of_next_char): Don't try to lookup the cache for the
6607 next/previous character if nothing is cached there yet, or if we
6608 were just reseat()'ed to a new position.
c40e2fb2 6609
0e14fe90
EZ
6610 * xdisp.c (set_cursor_from_row): Set start and stop points
6611 according to the row's direction when priming the loop that looks
6612 for the glyph on which to display cursor.
6613 (single_display_spec_intangible_p): Function deleted.
6614 (display_prop_intangible_p): Reimplement to call
6615 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6616 Accept 3 additional arguments needed by handle_display_spec.
6617 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6618 values: lists, `(when COND...)' forms, etc.
6619 (single_display_spec_string_p): Support property values that are
6620 lists with the argument STRING its top-level element.
6621 (display_prop_string_p): Fix the condition for processing a
6622 property that is a list to be consistent with handle_display_spec.
fec2107c 6623 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6624 last portion of handle_display_prop.
6625 (compute_display_string_pos): Accept additional argument
6626 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6627 value of a `display' property is a "replacing spec".
6628 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6629 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6630 the display property, but just return a value indicating whether
6631 the display property will replace the characters it covers.
6632 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6633 frame_window_p members of struct bidi_it.
d6d100dd
SM
6634 (compute_display_string_pos, compute_display_string_end):
6635 New functions.
fec2107c
EZ
6636 (push_it): Accept second argument POSITION, where pop_it should
6637 jump to continue iteration.
6638 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6639
fec2107c
EZ
6640 * keyboard.c (adjust_point_for_property): Adjust the call to
6641 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6642
6643 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6644 (bidi_init_it): Update prototypes.
6645 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6646 (compute_display_string_pos, compute_display_string_end):
6647 Declare prototypes.
fec2107c
EZ
6648 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6649 EMACS_INT.
fc6f18ce 6650
40087514 66512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6652
57f53182
PE
6653 Malloc failure behavior now depends on size of allocation.
6654 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6655 * lisp.h: Change signatures accordingly.
6656 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6657 All callers changed. (Bug#8762)
6658
6659 * gnutls.c: Use Emacs's memory allocators.
6660 Without this change, the gnutls library would invoke malloc etc.
6661 directly, which causes problems on non-SYNC_INPUT hosts, and which
6662 runs afoul of improving memory_full behavior. (Bug#8761)
6663 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6664 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6665 xfree instead of the default malloc, realloc, free.
6666 (Fgnutls_boot): No need to check for memory allocation failure,
6667 since xmalloc does that for us.
6668
ac32cd99 6669 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6670 * category.c (hash_get_category_set):
6671 * ccl.c (ccl_driver):
6672 * charset.c (Fdefine_charset_internal):
6673 * charset.h (struct charset.hash_index):
6674 * composite.c (get_composition_id, gstring_lookup_cache)
6675 (composition_gstring_put_cache):
6676 * composite.h (struct composition.hash_index):
6677 * dispextern.h (struct image.hash):
6678 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6679 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6680 (hashfn_equal, hashfn_user_defined, make_hash_table)
6681 (maybe_resize_hash_table, hash_lookup, hash_put)
6682 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6683 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6684 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6685 * image.c (make_image, search_image_cache, lookup_image)
6686 (xpm_put_color_table_h):
6687 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6688 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6689 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6690 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6691 * alloc.c (allocate_vectorlike):
6692 Check for overflow in vector size calculations.
6693 * ccl.c (ccl_driver):
6694 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6695 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6696 need to be updated by these changes.
40087514
PE
6697 * fns.c (make_hash_table, maybe_resize_hash_table):
6698 Check for integer overflow with large hash tables.
0de4bb68
PE
6699 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6700 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6701 (SXHASH_REDUCE): New macro.
6702 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6703 Use it instead of discarding useful hash info with large hash values.
6704 (sxhash_float): New function.
6705 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6706 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6707 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6708 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6709 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6710 Adjust signatures to match updated version of code.
6711 (consing_since_gc): Now EMACS_INT, since a single hash table can
6712 use more than INT_MAX bytes.
6713
698d32e2
DN
67142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6715
6716 Make it possible to build with GCC-4.6+ -O2 -flto.
6717
6718 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6719
fd6fa53f
SM
67202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6721
6722 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6723 Call minibuffer-inactive-mode.
6724
864db017
JB
67252011-05-31 Juanma Barranquero <lekktu@gmail.com>
6726
6727 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6728 Update dependencies.
6729
2ad0baf4
DN
67302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6731
6732 * data.c (init_data): Remove code for UTS, this system is not
6733 supported anymore.
6734
4fcc2638
DN
67352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6736
6737 Don't force ./temacs to start in terminal mode.
6738
6739 * frame.c (make_initial_frame): Initialize faces in all cases, not
6740 only when CANNOT_DUMP is defined.
6741 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6742
c56e0fd5
DN
67432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6744
6745 * dispnew.c (add_window_display_history): Use const for the string
6746 pointer. Remove declaration, not needed.
6747
333d54da 67482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6749
55d4c1b2 6750 Use 'inline', not 'INLINE'.
333d54da 6751 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6752 * alloc.c, fontset.c (INLINE): Remove.
6753 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6754 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6755 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6756 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6757 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6758
738db178
DN
67592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6760
6761 Make it possible to run ./temacs.
6762
6763 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6764 syms_of_callproc does the same thing. Remove test for
6765 "initialized", do it in the caller.
6766 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6767
620c53a6
SM
67682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6769
6770 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6771 (read_minibuf): Use get_minibuffer.
6772 (syms_of_minibuf): Use DEFSYM.
6773 (Qmetadata): New var.
6774 * data.c (Qbuffer): Don't make it static.
6775 (syms_of_data): Use DEFSYM.
6776
e003a292
PE
67772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6780 (CCL_CODE_MIN): New macro.
6781
ed008a6d
PE
67822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6783
3687c2ef
PE
6784 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6785
ed008a6d
PE
6786 * eval.c (Qdebug): Now static.
6787 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6788 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6789 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6790
d66c4c7c
CY
67912011-05-29 Chong Yidong <cyd@stupidchicken.com>
6792
6793 * image.c: Various fixes to ImageMagick code comments.
6794 (Fimagemagick_types): Doc fix.
6795
5fbc2025
PE
67962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6797
0196f88a
PE
6798 Minor fixes prompted by GCC 4.6.0 warnings.
6799
6800 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6801
5fbc2025
PE
6802 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6803 (x_clipboard_manager_save_all): Move extern decl to ...
6804 * xterm.h: ... here, so that it can be checked for consistency.
6805
1dd3c2d9
CY
68062011-05-29 Chong Yidong <cyd@stupidchicken.com>
6807
6808 * xselect.c (x_clipboard_manager_save_frame)
6809 (x_clipboard_manager_save_all): New functions.
6810 (Fx_clipboard_manager_save): Lisp function deleted.
6811
6812 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6813 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6814
6815 * xterm.h: Update prototype.
6816
5ba6571d
WX
68172011-05-28 William Xu <william.xwl@gmail.com>
6818
6819 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6820 exiting (Bug#8239).
6821
3eaff834
JM
68222011-05-28 Jim Meyering <meyering@redhat.com>
6823
e1900994 6824 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6825 * fns.c (to_uchar): Define.
6826 (crypto_hash_function): Use it to convert some newly-signed
6827 variables to unsigned, to avoid sign-extension bugs. For example,
6828 without this change, (md5 "truc") would evaluate to
6829 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6830 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6831 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6832
0f6990a7
PE
68332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6834
6835 Integer overflow fixes.
c8a9ca5a 6836
08686060
PE
6837 * dbusbind.c: Serial number integer overflow fixes.
6838 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6839 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6840 to hold a serial number that is too large for a fixnum.
6841 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6842 Check for serial numbers out of range. Decode any serial number
59568bf0 6843 that was so large that it became a float. (Bug#8722)
08686060 6844
2d1fc3c7
PE
6845 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6846 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6847 Use XFASTINT rather than XUINT when numbers are nonnegative.
6848 (xd_append_arg, Fdbus_method_return_internal):
6849 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6850 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6851 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6852 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6853 (Bug#8722)
2d1fc3c7 6854
c8a9ca5a
PE
6855 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6856
519e1d69
PE
6857 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6858
6df6ae42 6859 ccl: Add integer overflow checks.
30569699
PE
6860 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6861 (IN_INT_RANGE): New macros.
6862 (ccl_driver): Use them to check for integer overflow when
6863 decoding a CCL program. Many of the new checks are whether XINT (x)
6864 fits in int; it doesn't always, on 64-bit hosts. The new version
6865 doesn't catch all possible integer overflows, but it's an
847044ea 6866 improvement. (Bug#8719)
30569699 6867
c11285dc
PE
6868 * alloc.c (make_event_array): Use XINT, not XUINT.
6869 There's no need for unsigned here.
6870
fdccd48e
PE
6871 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6872 This follows up to the 2011-05-06 change that substituted uintptr_t
6873 for EMACS_INT. This case wasn't caught back then.
6874
37910ab2
PE
6875 Rework Fformat to avoid integer overflow issues.
6876 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6877 now (part of C89). Include <verify.h>.
6878 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6879 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6880 (Fformat): Avoid the prepass trying to compute sizes; it was only
6881 approximate and thus did not catch overflow reliably. Instead, walk
6882 through the format just once, formatting and computing sizes as we go,
6883 checking for integer overflow at every step, and allocating a larger
6884 buffer as needed. Keep track separately whether the format is
6885 multibyte. Keep only the most-recently calculated precision, rather
6886 than them all. Record whether each argument has been converted to
6887 string. Use EMACS_INT, not int, for byte and char and arg counts.
6888 Support field widths and precisions larger than INT_MAX. Avoid
6889 sprintf's undefined behavior with conversion specifications such as %#d
6890 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6891 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6892 formatting out-of-range floating point numbers with int
9173deec 6893 formats. (Bug#8668)
37910ab2 6894
2e6578fb
PE
6895 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6896
0ae6bdee
PE
6897 * data.c: Avoid integer truncation in expressions involving floats.
6898 * data.c: Include <intprops.h>.
6899 (arith_driver): When there's an integer overflow in an expression
6900 involving floating point, convert the integers to floating point
6901 so that the resulting value does not suffer from catastrophic
6902 integer truncation. For example, on a 64-bit host (* 4
6903 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6904 Do not rely on undefined behavior after integer overflow.
6905
de883a70
PE
6906 merge count_size_as_multibyte, parse_str_to_multibyte
6907 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6908 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6909 Check for integer overflow.
6910 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6911 since it's now a duplicate of the other. This is more of
6912 a character than a buffer op, so better that it's in character.c.
6913 * fns.c, print.c: Adjust to above changes.
6914
2ff916cb
PE
69152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6916
6917 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6918
f1b54466
PE
69192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6920
fb1ac845
PE
6921 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6922 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6923 (x_clipboard_manager_save): Now static.
6924 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6925
f1b54466
PE
6926 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6927 (crypto_hash_function): Now static.
6928 Fix pointer signedness problems. Avoid unnecessary initializations.
6929
a9f737ee
CY
69302011-05-27 Chong Yidong <cyd@stupidchicken.com>
6931
6932 * termhooks.h (Vselection_alist): Make it terminal-local.
6933
6934 * terminal.c (create_terminal): Initialize it.
6935
6936 * xselect.c: Support for clipboard managers.
6937 (Vselection_alist): Move to termhooks.h as terminal-local var.
6938 (LOCAL_SELECTION): New macro.
6939 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6940 (symbol_to_x_atom): Remove gratuitous arg.
6941 (x_handle_selection_request, lisp_data_to_selection_data)
6942 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6943 (x_own_selection, x_get_local_selection, x_convert_selection):
6944 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6945 (some_frame_on_display): Delete unused function.
6946 (Fx_own_selection_internal, Fx_get_selection_internal)
6947 (Fx_disown_selection_internal, Fx_selection_owner_p)
6948 (Fx_selection_exists_p): New optional frame arg.
6949 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6950 (x_handle_selection_clear): Don't treat other terminals with the
6951 same keyboard specially. Use the terminal-local Vselection_alist.
6952 (x_clear_frame_selections): Use Frun_hook_with_args.
6953
6954 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6955
6956 * xterm.h: Add support for those atoms.
6957
e067f0c1
CY
69582011-05-26 Chong Yidong <cyd@stupidchicken.com>
6959
6960 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6961 (converted_selections, conversion_fail_tag): New global variables.
6962 (x_selection_request_lisp_error): Free the above.
6963 (x_get_local_selection): Remove unnecessary code.
6964 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6965 of converted selections stored in converted_selections.
6966 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6967 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6968 (x_convert_selection): New function.
6969 (x_handle_selection_event): Simplify.
6970 (x_get_foreign_selection): Don't ignore incoming requests while
6971 waiting for an answer; this will fail when we implement
6972 SAVE_TARGETS, and seems unnecessary anyway.
6973 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6974 (Vx_sent_selection_functions): Doc fix.
6975
0f4aebc0
LL
69762011-05-26 Leo Liu <sdl.web@gmail.com>
6977
6978 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6979
e61124cd
YM
69802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6981
6982 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6983
6984 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6985 for fringe update if it has periodic bitmap.
ac389d0c 6986 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6987 and fringe_bitmap_periodic_p.
6988
6989 * fringe.c (get_fringe_bitmap_data): New function.
6990 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6991 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6992 row. Mark glyph row for fringe update if periodicity changed.
6993
6994 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6995 for fringe update unless it has periodic bitmap.
6996
f16d9837
KH
69972011-05-25 Kenichi Handa <handa@m17n.org>
6998
6999 * xdisp.c (get_next_display_element): Set correct it->face_id for
7000 a static composition.
7001
e1b90ef6
LL
70022011-05-24 Leo Liu <sdl.web@gmail.com>
7003
7004 * deps.mk (fns.o):
7005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7006
7007 * fns.c (crypto_hash_function, Fsha1): New function.
7008 (Fmd5): Use crypto_hash_function.
7009 (syms_of_fns): Add Ssha1.
7010
7400048f
PE
70112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7012
7013 * gnutls.c: Remove unused macros.
7014 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7015 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7016 Remove macros that are defined and never used.
7017 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7018
abb71cf4
CY
70192011-05-22 Chong Yidong <cyd@stupidchicken.com>
7020
7021 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7022 (Fx_get_selection_internal): Minor cleanup.
7023 (Fx_own_selection_internal): Rename arguments for consistency with
7024 select.el.
7025
6307db39
PE
70262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7029
f3d4e0a4
CY
70302011-05-22 Chong Yidong <cyd@stupidchicken.com>
7031
7032 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7033
4d8ade89
YM
70342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7035
7036 * dispnew.c (scrolling_window): Don't exclude the case that the
7037 last enabled row in the desired matrix touches the bottom boundary.
7038
32078c8d
GM
70392011-05-21 Glenn Morris <rgm@gnu.org>
7040
7041 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7042 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7043 and add some more files.
32078c8d 7044
7285dc67
EZ
70452011-05-20 Eli Zaretskii <eliz@gnu.org>
7046
7047 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7048 report_file_error introduced by the change from 2011-05-07.
7049
89d1bd22
PE
70502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7051
7052 * systime.h (Time): Define only if emacs is defined.
7053 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7054 where the include path doesn't have X11/X.h by default. See
7055 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7056
cd394be1 70572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7058
7059 * composite.c (find_automatic_composition): Fix previous change.
7060
b9704ad9
GM
70612011-05-20 Glenn Morris <rgm@gnu.org>
7062
7063 * lisp.mk: New file, split from Makefile.in.
7064 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7065 (shortlisp): Remove.
7066 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7067
4a720484
GM
70682011-05-19 Glenn Morris <rgm@gnu.org>
7069
7070 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7071 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7072 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7073 (lisp): Set the order to that of loadup.el.
7074 (shortlisp): Make it a copy of $lisp.
7075 (SOME_MACHINE_LISP): Remove.
7076 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7077 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7078
a28d4396
KH
70792011-05-18 Kenichi Handa <handa@m17n.org>
7080
7081 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7082 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7083 (find_automatic_composition): Mostly rewrite for efficiency.
7084
a2b1fa8e
JB
70852011-05-18 Juanma Barranquero <lekktu@gmail.com>
7086
7087 * makefile.w32-in: Update dependencies.
7088
8e1f5610
CS
70892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7090
7091 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7092 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7093
7025ee00 70942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7095
cdfa6eab
PE
7096 Fix some integer overflow issues, such as string length overflow.
7097
06d6db33
PE
7098 * insdel.c (count_size_as_multibyte): Check for string overflow.
7099
2b4560a8
PE
7100 * character.c (lisp_string_width): Check for string overflow.
7101 Use EMACS_INT, not int, for string indexes and lengths; in
7102 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7103 the resulting string length overflows an EMACS_INT; instead,
7104 report a string overflow if no precision given. When checking for
7105 precision exhaustion, use a check that cannot possibly have
7106 integer overflow. (Bug#8675)
7107 * character.h (lisp_string_width): Adjust to new signature.
7108
cb93f9be
PE
7109 * alloc.c (string_overflow): New function.
7110 (Fmake_string): Use it. This doesn't change behavior, but saves
7111 a few bytes and will simplify future changes.
7112 * character.c (string_escape_byte8): Likewise.
7113 * lisp.h (string_overflow): New decl.
7114
1a1f3366
PE
7115 Fixups, following up to the user-interface timestamp change.
7116 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7117 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7118 * msdos.c (mouse_get_pos): Likewise.
7119 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7120 * w32gui.h (Time): Define by including "systime.h" rather than by
7121 declaring it ourselves. (Bug#8664)
7122
d4e3e4d3
PE
7123 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7124 * image.c (clear_image_cache): Likewise.
7125
f6a24d19
PE
7126 * term.c (term_mouse_position): Don't assume time_t wraparound.
7127
08dc5ae6
PE
7128 Be more systematic about user-interface timestamps.
7129 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7130 and sometimes 'EMACS_UINT', to represent these timestamps.
7131 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7132 This makes the code easier to follow, and makes it easier to catch
7133 integer overflow bugs such as Bug#8664.
7134 * frame.c (Fmouse_position, Fmouse_pixel_position):
7135 Use Time, not unsigned long, for user-interface timestamps.
7136 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7137 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7138 * keyboard.h (last_event_timestamp): Likewise.
7139 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7140 * menu.h (xmenu_show): Likewise.
7141 * term.c (term_mouse_position): Likewise.
7142 * termhooks.h (struct input_event.timestamp): Likewise.
7143 (struct terminal.mouse_position_hook): Likewise.
7144 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7145 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7146 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7147 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7148 what it was before.
7149 * menu.h, termhooks.h: Include "systime.h", for Time.
7150
8e55734a
PE
7151 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7152 Don't assume that the difference between two unsigned long values
7153 can fit into an integer. At this point, we know button_down_time
7154 <= event->timestamp, so the difference must be nonnegative, so
7155 there's no need to cast the result if double-click-time is
7156 nonnegative, as it should be; check that it's nonnegative, just in
7157 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7158 apart (about 25 days). (Bug#8664)
8e55734a 7159
841f1b75 7160 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7161 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7162
3e26f69c
PE
7163 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7164 that always fit in int. Use a sentinel instead of a counter, to
7165 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7166 * frame.h (struct frame): Use int for menu_bar_items_used
7167 instead of EMACS_INT, since it always fits in int.
3e26f69c 7168
5cc152c0
PE
7169 * menu.c (grow_menu_items): Check for int overflow.
7170
d89eb65e
PE
7171 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7172
5235bd3e
PE
7173 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7174 Before, the code was not consistent. These values cannot exceed
7175 2**31 - 1 so there's no need to make them unsigned.
7176 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7177 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7178 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7179 as modifiers.
7180 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7181
bc827e23
PE
7182 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7183 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7184 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7185 presumably because the widths might not match.
7186
78eb494e
PE
7187 * window.c (size_window): Avoid needless test at loop start.
7188
04f2d78b
CB
71892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7190
7191 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7192
d2fc7e3d 71932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7194
7195 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7196
d2fc7e3d 71972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7198
7199 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7200 `width' to `bar_area_x' and `bar_area_width', respectively.
7201 (x_scroll_run): Take account of fringe background extension.
7202
04f2d78b
CB
7203 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7204 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7205 `bar_area_width', respectively.
7206 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7207 background extension.
7208
79b70037
GM
72092011-05-10 Jim Meyering <meyering@redhat.com>
7210
7211 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7212
2f142cc5
JB
72132011-05-10 Juanma Barranquero <lekktu@gmail.com>
7214
7215 * image.c (Finit_image_library): Return t for built-in image types,
7216 like pbm and xbm. (Bug#8640)
7217
57679c86
AS
72182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7219
7220 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7221
888c9e86
EZ
72222011-05-07 Eli Zaretskii <eliz@gnu.org>
7223
b0512a1d
EZ
7224 * w32console.c (Fset_screen_color): Doc fix.
7225 (Fget_screen_color): New function.
7226 (syms_of_ntterm): Defsubr it.
7227
7285dc67
EZ
7228 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7229 unlink the temporary file if Fcall_process didn't create it in the
7230 first place.
7231 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7232 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7233 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7234 cue to call_process_cleanup not to close that handle.
7235
4d3fcc8e
BK
72362011-05-07 Ben Key <bkey76@gmail.com>
7237
7238 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7239 one of two shell specific rules, either bootstrap-temacs-CMD or
7240 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7241 to the previous implementation of the bootstrap-temacs rule.
7242 The bootstrap-temacs-CMD rule is similar to the previous
7243 implementation of the bootstrap-temacs rule except that it
7244 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7245 variable.
7246
7247 These changes, along with some changes to nt/configure.bat,
7248 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7249 earlier fix to add support for --cflags and --ldflags options
7250 that include quotes so that it works whether make uses cmd or
7251 sh as the shell.
7252
b4289b64
MA
72532011-05-06 Michael Albinus <michael.albinus@gmx.de>
7254
7255 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7256 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7257 is a constant.
7258 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7259 a string. Handle both cases.
7260 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7261 (Fdbus_register_method): Use Qinvalid_function.
7262
af4c0e28
JB
72632011-05-06 Juanma Barranquero <lekktu@gmail.com>
7264
7265 * makefile.w32-in: Update dependencies.
7266 (LISP_H): Add inttypes.h and stdin.h.
7267 (PROCESS_H): Add unistd.h.
7268
c51453d9
EZ
72692011-05-06 Eli Zaretskii <eliz@gnu.org>
7270
7271 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7272 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7273
8ff0ac3c 72742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7275
4c4b566b
PE
7276 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7277
aab2b9b5
PE
7278 * term.c (vfatal): Remove stray call to va_end.
7279 It's not needed and the C Standard doesn't allow it here anyway.
7280
c378da0b
PE
7281 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7282 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7283
288b08c7
PE
7284 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7285 bytes.
7286
e3601888
PE
7287 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7288
db6c0e74
PE
7289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7290
dd5963ea
PE
7291 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7292
88c9450f
PE
7293 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7294
2f9442b8
PE
7295 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7296
c032b5f8
PE
7297 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7298 * charset.c (Fdefine_charset_internal): Don't initialize
7299 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7300 32-bit int (Bug#8600).
a108c10b
PE
7301
7302 * lread.c (read_integer): Be more consistent with string-to-number.
7303 Use string_to_number to do the actual conversion; this avoids
7304 rounding errors and fixes some other screwups. Without this fix,
7305 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7306 (digit_to_number): Move earlier, for benefit of read_integer.
7307 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7308 not a digit in any supported base. (Bug#8602)
a108c10b 7309
ad5f9eea
PE
7310 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7311
aec1708a
PE
7312 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7313 to match comment at start of function. This also removes a
7314 GCC warning about overflow in a 32+64-bit port.
7315
47be4ab5
PE
7316 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7317
371cac43
PE
7318 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7319 Reported by Stefan Monnier in
7320 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7322 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7323
d01a7826
PE
7324 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7325 (EMACS_UINTPTR): Likewise, with uintptr_t.
7326
7fd47d5c
PE
7327 * lisp.h: Prefer 64-bit EMACS_INT if available.
7328 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7329 on 32-bit hosts that have 64-bit int, so that they can access
7330 large files.
122b0c86
PE
7331 However, temporarily disable this change unless the temporary
7332 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7333
8727937b
PE
7334 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7335
8ac068ac
PE
7336 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7337 This removes an assumption that EMACS_INT and long are the same
7338 width as pointers. The assumption is true for Emacs porting targets
7339 now, but we want to make other targets possible.
7340 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7341 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7342 In the rest of the code, change types of integers that hold casted
7343 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7344 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7345 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7346 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7347 No need to cast type when ORing.
7348 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7349 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7350 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7351 assume EMACS_INT is the same width as char *.
7352 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7353 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7354 Remove no-longer-needed casts.
7355 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7356 (xg_tool_bar_help_callback, xg_make_tool_item):
7357 Use EMACS_INTPTR to hold an integer
7358 that will be cast to void *; this can avoid a GCC warning
7359 if EMACS_INT is not the same width as void *.
7360 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7361 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7362 (current_message_1, set_message_1):
7363 Use a local to convert to proper width without a cast.
7364 * xmenu.c (dialog_selection_callback): Likewise.
7365
ede49d71
PE
7366 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7367 Also, don't assume VALBITS / RAND_BITS is less than 5,
7368 and don't rely on undefined behavior when shifting a 1 left into
7369 the sign bit.
7370 * lisp.h (get_random): Change signature to match.
7371
2f30ecd0
PE
7372 * lread.c (hash_string): Use size_t, not int, for hash computation.
7373 Normally we prefer signed values; but hashing is special, because
7374 it's better to use unsigned division on hash table sizes so that
7375 the remainder is nonnegative. Also, size_t is the natural width
7376 for hashing into memory. The previous code used 'int', which doesn't
7377 retain enough info to hash well into very large tables.
7378 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7379
2a866e7b
PE
7380 * dbusbind.c: Don't possibly lose pointer info when converting.
7381 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7382 Use XPNTR rather than XHASH, so that the high-order bits of
7383 the pointer aren't lost when converting through void *.
7384
51639eac
PE
7385 * eval.c (Fautoload): Don't double-shift a pointer.
7386
92394119
PE
7387 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7388
dbdb9a7c
JB
73892011-05-06 Juanma Barranquero <lekktu@gmail.com>
7390
7391 * gnutls.c (DEF_GNUTLS_FN):
7392 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7393
db7a0b4f
AS
73942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7395
7396 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7397 marker. (Bug#8610)
7398
cd394be1 73992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7400
7401 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7402 New version that can reserve upto 2GB of heap space.
7403
f7ff1b0f 74042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7405
7406 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7407
639c109b
TZ
74082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7409
7410 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7411 `gnutls_certificate_set_x509_key_file'.
7412
d2127135
JB
74132011-05-05 Juanma Barranquero <lekktu@gmail.com>
7414
7415 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7416 Update dependencies.
7417
e968f4f3
JB
74182011-05-04 Juanma Barranquero <lekktu@gmail.com>
7419
7420 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7421 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7422 Remove unused parameter `fildes'.
7423 * process.c (read_process_output, send_process): Don't pass it.
7424
84d358f0
JB
74252011-05-04 Juanma Barranquero <lekktu@gmail.com>
7426
7427 Fix previous change: the library cache is defined in w32.c.
7428 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7429 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7430
0898ca10
JB
74312011-05-04 Juanma Barranquero <lekktu@gmail.com>
7432
7433 Implement dynamic loading of GnuTLS on Windows.
7434
7435 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7436 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7437 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7438 Declare.
7439
7440 * gnutls.c (Qgnutls_dll): Define.
7441 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7442 (gnutls_*): Declare function pointers.
7443 (init_gnutls_functions): New function to initialize function pointers.
7444 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7445 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7446 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7447 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7448 (emacs_gnutls_write, emacs_gnutls_read)
7449 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7450 (Fgnutls_available_p): New function.
7451 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7452 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7453 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7454
7455 * image.c: Include w32.h.
7456 (Vimage_type_cache): Delete.
7457 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7458 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7459 (w32_delayed_load): Move to w32.c.
7460
7461 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7462
7463 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7464 (w32_delayed_load): Move from image.c. When loading a library, record
7465 its filename in the :loaded-from property of the library id.
7466 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7467 Initialize and staticpro them.
7468 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7469
7470 * process.c: Include lisp.h before w32.h, not after.
7471 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7472 instead of gnutls_record_check_pending.
7473
7474 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7475
ff4de4aa
TZ
74762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7477
7478 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7479 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7480 as passed in.
7481
abe95abb
JD
74822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7483
7484 * xterm.c (x_set_frame_alpha): Do not set property on anything
7485 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7486
e16e55d4
JB
74872011-05-02 Juanma Barranquero <lekktu@gmail.com>
7488
7489 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7490
bafcf6a5
JB
74912011-05-02 Juanma Barranquero <lekktu@gmail.com>
7492
7493 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7494 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7495 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7496 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7497 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7498 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7499 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7500 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7501 (Qgnutls_bootprop_callbacks_verify): Make static.
7502
e7a6747f
AS
75032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7504
19ed11ba
AS
7505 * callproc.c: Indentation fixup.
7506
e7a6747f 7507 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7508 (wait_for_termination, interruptible_wait_for_termination):
7509 Move after wait_for_termination_1.
e7a6747f 7510
1ef14cb4
LMI
75112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7512
7513 * sysdep.c (interruptible_wait_for_termination): New function
7514 which is like wait_for_termination, but allows keyboard
7515 interruptions.
7516
7517 * callproc.c (Fcall_process): Add (:file "file") as an option for
7518 the STDOUT buffer.
7519 (Fcall_process_region): Ditto.
7520
330d880c
EZ
75212011-04-30 Eli Zaretskii <eliz@gnu.org>
7522
8db90b73
EZ
7523 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7524 rather than `XVECTOR (FOO)->size'.
7525
330d880c
EZ
7526 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7527 inttypes.h, as a gnulib replacement is used if it not available in
7528 system headers.
7529
15cbd324
EZ
75302011-04-21 Eli Zaretskii <eliz@gnu.org>
7531
7532 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7533 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7534 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7535
7536 * coding.c (coding_alloc_by_realloc): Error out if destination
7537 will grow beyond MOST_POSITIVE_FIXNUM.
7538 (decode_coding_emacs_mule): Abort if there isn't enough place in
7539 charbuf for the composition carryover bytes. Reserve an extra
7540 space for up to 2 characters produced in a loop.
7541 (decode_coding_iso_2022): Abort if there isn't enough place in
7542 charbuf for the composition carryover bytes.
7543
75442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7545
ae940cca
EZ
7546 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7547 aborting when %lld or %lll format is passed.
7548 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7549 %llo or %llx format is passed. (Bug#8545)
7550
03ab8921
EZ
7551 * window.c (window_scroll_line_based): Use a marker instead of
7552 simple variables to record original value of point. (Bug#7952)
7553
afda1437
EZ
7554 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7555 produced by %s or %c overflows available buffer space. (Bug#8545)
7556
f76dee0c
PE
75572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7560 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7561
fdc5744d
JB
75622011-04-28 Juanma Barranquero <lekktu@gmail.com>
7563
7564 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7565
638f053a
JB
75662011-04-28 Juanma Barranquero <lekktu@gmail.com>
7567
7568 * keyboard.c (Qdelayed_warnings_hook): Define.
7569 (command_loop_1): Run `delayed-warnings-hook'
7570 if Vdelayed_warnings_list is non-nil.
7571 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7572 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7573
d178f871
EZ
75742011-04-28 Eli Zaretskii <eliz@gnu.org>
7575
7576 * doprnt.c (doprnt): Don't return value smaller than the buffer
7577 size if the message was truncated. (Bug#8545).
7578
b124fd93
JB
75792011-04-28 Juanma Barranquero <lekktu@gmail.com>
7580
7581 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7582 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7583
e810457d
PE
75842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7585
7586 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7587
ea51cceb
JB
75882011-04-27 Juanma Barranquero <lekktu@gmail.com>
7589
7590 * makefile.w32-in: Update dependencies.
7591
94dcfacf
EZ
75922011-04-27 Eli Zaretskii <eliz@gnu.org>
7593
7594 Improve `doprnt' and its usage. (Bug#8545)
7595 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7596 `format_end'. Remove support for %l as a conversion specifier.
7597 Don't use xrealloc. Improve diagnostics when the %l size modifier
7598 is used. Update the commentary.
7599
7600 * eval.c (verror): Simplify calculation of size_t.
7601
7602 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7603 messages.
7604
f61f41d7
PE
76052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7606
7607 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7608 change.
7609
96fb4434
PE
76102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7611
7612 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7613 This makes this file independent of the recent pseudovector change.
7614
671875da 76152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7616
69e9b5a3
PE
7617 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7618
b5f869a7 7619 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7620 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7621 Remove unused local.
c8926152 7622 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7623
841a1577 7624 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7625 GCC 4.6.0 optimizes based on type-based alias analysis.
7626 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7627 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7628 != &v->size, and therefore "v->size = 1; b->size = 2; return
7629 v->size;" must therefore return 1. This assumption is incorrect
7630 for Emacs, since it type-puns struct Lisp_Vector * with many other
7631 types. To fix this problem, this patch adds a new type struct
f904488f 7632 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7633 and pseudovectors, and helps optimizing compilers not get fooled
7634 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7635 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7636 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7637 the size member.
eab3844f
PE
7638 (XSETPVECTYPE): Rewrite in terms of new macro.
7639 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7640 This is a bit clearer, and further avoids the possibility of
7641 undesirable aliasing.
7642 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7643 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7644 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7645 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7646 (ASIZE): Now uses header.size rather than size.
7647 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7648 to avoid the hassle of writing XVECTOR (foo)->header.size.
7649 (struct vectorlike_header): New type.
eab3844f
PE
7650 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7651 object, to help avoid aliasing.
7652 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7653 (SUBRP): Likewise, since Lisp_Subr is a special case.
7654 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7655 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7656 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7657 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7658 changed to be "header.size" and "header.next".
7659 * buffer.h (struct buffer): Likewise.
7660 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7661 * frame.h (struct frame): Likewise.
7662 * process.h (struct Lisp_Process): Likewise.
7663 * termhooks.h (struct terminal): Likewise.
7664 * window.c (struct save_window_data, struct saved_window): Likewise.
7665 * window.h (struct window): Likewise.
7666 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7667 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7668 * buffer.c (init_buffer_once): Likewise.
7669 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7670 special case.
7671 * process.c (Fformat_network_address): Use local var for size,
7672 for brevity.
7673
0df1eac5
PE
7674 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7675
847ab9d1 7676 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7677 * data.c (atof): Remove decl; no longer used or needed.
7678 (digit_to_number): Move to lread.c.
7679 (Fstring_to_number): Use new string_to_number function, to be
7680 consistent with how the Lisp reader treats infinities and NaNs.
7681 Do not assume that floating-point numbers represent EMACS_INT
7682 without losing information; this is not true on most 64-bit hosts.
7683 Avoid double-rounding errors, by insisting on integers when
7684 parsing non-base-10 numbers, as the documentation specifies.
7685 * lisp.h (string_to_number): New decl, replacing ...
7686 (isfloat_string): Remove.
bc0a5c13 7687 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7688 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7689 appears to have been a coding error. Similarly, do not accept
7690 strings like +-1e0 as floating point numbers. Do not report
7691 overflow for integer overflows unless the base is not 10 which
7692 means we have no simple and reliable way to continue.
7693 Break out the floating-point parsing into a new
7694 function string_to_number, so that Fstring_to_number parses
7695 floating point numbers consistently with the Lisp reader.
04f2d78b 7696 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7697 (E_CHAR, EXP_INT): Remove, replacing with ...
7698 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7699 (string_to_number): New function, replacing isfloat_string.
7700 This function checks for valid syntax and produces the resulting
7701 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7702 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7703 so that overflow for non-base-10 numbers is reported only when
7704 there's no portable and simple way to convert to floating point.
452f4150 7705
67769ffc
PE
7706 * textprop.c (set_text_properties_1): Rewrite for clarity,
7707 and to avoid GCC warning about integer overflow.
7708
c20db43f
PE
7709 * intervals.h (struct interval): Use EMACS_INT for members
7710 where EMACS_UINT might cause problems. See
7711 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7712 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7713 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7714 All uses changed.
37aa2f85
PE
7715 (offset_intervals): Tell GCC not to worry about length overflow
7716 when negating a negative length.
c20db43f 7717
2538aa2f
PE
7718 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7719 (overrun_check_free): Likewise.
7720
f2d3008d
PE
7721 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7722 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7723 word size.
7724
ec8df744
PE
7725 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7726 (gnutls_make_error): Rename local to avoid shadowing.
7727 (gnutls_emacs_global_deinit): ifdef out; not used.
7728 (Fgnutls_boot): Use const for pointer to readonly storage.
7729 Comment out unused local. Fix pointer signedness problems.
7730
640ee02d
PE
7731 * lread.c (openp): Don't stuff size_t into an 'int'.
7732 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7733 about possible signed overflow.
7734
6048fb2a
PE
7735 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7736 (GDK_KEY_g): Don't define if already defined.
7737 (xg_prepare_tooltip): Avoid pointer signedness problem.
7738 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7739
fa3c87e1
PE
7740 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7741 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7742
2172544b
PE
7743 * xfns.c (Fx_window_property): Simplify a bit,
7744 to make a bit faster and to avoid GCC 4.6.0 warning.
7745 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7746
9b821a21
PE
7747 * fns.c (internal_equal): Don't assume size_t fits in int.
7748
3c616cfa
PE
7749 * alloc.c (compact_small_strings): Tighten assertion a little.
7750
c2982e87
PE
7751 Replace pEd with more-general pI, and fix some printf arg casts.
7752 * lisp.h (pI): New macro, generalizing old pEd macro to other
7753 conversion specifiers. For example, use "...%"pI"d..." rather
7754 than "...%"pEd"...".
7755 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7756 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7757 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7758 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7759 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7760 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7761 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7762 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7763 64-bit hosts.
7764 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7765 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7766 * print.c (safe_debug_print, print_object): Likewise.
7767 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7768 to int.
6f04d126
PE
7769 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7770 avoiding the 0 flag, which is not portable.
c2982e87
PE
7771 * process.c (Fmake_network_process): Use pI to avoid cast.
7772 * region-cache.c (pp_cache): Likewise.
7773 * xdisp.c (decode_mode_spec): Likewise.
7774 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7775 behavior on 64-bit hosts with printf arg.
6f04d126 7776 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7777 (x_stop_queuing_selection_requests): Likewise.
7778 (x_get_window_property): Don't truncate byte count to an 'int'
7779 when tracing.
0b432f21 7780
5e073ec7
PE
7781 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7782 here, since it parses constructs like leading '-' and spaces,
7783 which are not wanted; and it overflows with large numbers.
7784 Instead, simply match F[0-9]+, which is what is wanted anyway.
7785
36372bf9
PE
7786 * alloc.c: Remove unportable assumptions about struct layout.
7787 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7788 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7789 (allocate_vectorlike, make_pure_vector): Use the new macros,
7790 plus offsetof, to remove unportable assumptions about struct layout.
7791 These assumptions hold on all porting targets that I know of, but
7792 they are not guaranteed, they're easy to remove, and removing them
7793 makes further changes easier.
7794
0b432f21
PE
7795 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7796 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7797 (string_overrun_cookie): Now const. Use initializers that
7798 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7799 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7800 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7801 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7802 multiple of sizeof (EMACS_INT); it need not be, if
7803 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7804 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7805
895009e1
JB
78062011-04-26 Juanma Barranquero <lekktu@gmail.com>
7807
7808 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7809
6a7a1b0b
TZ
78102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7811
7812 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7813 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7814 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7815
841a1577 78162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7817
7818 * lisp.h (Qdebug): List symbol.
895009e1 7819 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7820 * keyboard.c (debug-on-event): New variable.
7821 (handle_user_signal): Break into debugger when debug-on-event
7822 matches the current signal symbol.
7823
f2d3ba6f
DN
78242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7825
7826 * alloc.c (check_sblock, check_string_bytes)
7827 (check_string_free_list): Convert to standard C.
7828
42ce4c63
TZ
78292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7830
7831 * w32.c (emacs_gnutls_push): Fix typo.
7832
825cd63c
EZ
78332011-04-25 Eli Zaretskii <eliz@gnu.org>
7834
fb11d64d
EZ
7835 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7836 "cast to pointer from integer of different size".
7837
825cd63c
EZ
7838 Improve doprnt and its use in verror. (Bug#8545)
7839 * doprnt.c (doprnt): Document the set of format control sequences
7840 supported by the function. Use SAFE_ALLOCA instead of always
7841 using `alloca'.
7842
7843 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7844 is one byte too soon. Don't use xrealloc; instead xfree and
7845 xmalloc anew.
7846
e061a11b
TZ
78472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7848
7849 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7850 callbacks stage.
7851
7852 * gnutls.c: Renamed global_initialized to
7853 gnutls_global_initialized. Added internals for the
7854 :verify-hostname-error, :verify-error, and :verify-flags
7855 parameters of `gnutls-boot' and documented those parameters in the
7856 docstring. Start callback support.
9173deec
JB
7857 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7858 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7859 on error. Return error code.
e061a11b
TZ
7860 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7861 (emacs_gnutls_read): Likewise.
7862 (Fgnutls_boot): Return handshake error code.
7863 (emacs_gnutls_handle_error): New function.
7864 (wsaerror_to_errno): Likewise.
7865
7866 * w32.h (emacs_gnutls_pull): Add prototype.
7867 (emacs_gnutls_push): Likewise.
7868
7869 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7870 (emacs_gnutls_push): Likewise.
7871
78722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7873
7874 * process.c (wait_reading_process_output): Check if GnuTLS
7875 buffered some data internally if no FDs are set for TLS
7876 connections.
7877
7878 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7879 (LIBS): Link to USER_LIBS.
7880 ($(BLD)/gnutls.$(0)): New target.
7881
fa6996bc
EZ
78822011-04-24 Eli Zaretskii <eliz@gnu.org>
7883
eb35682e
EZ
7884 * xdisp.c (handle_single_display_spec): Rename the
7885 display_replaced_before_p argument into display_replaced_p, to
7886 make it consistent with the commentary. Fix typos in the
7887 commentary.
7888
e2ad650c
EZ
7889 * textprop.c (syms_of_textprop): Remove dead code.
7890 (copy_text_properties): Delete obsolete commentary about an
7891 interface that was deleted long ago. Fix typos in the description
7892 of arguments.
7893
1b2de274
EZ
7894 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7895 to changes in oldXMenu/XMenu.h from 2011-04-16.
7896 <menu_help_message, prev_menu_help_message>: Constify.
7897 (IT_menu_make_room): menu->help_text is now `const char **';
7898 adjust.
7899
7900 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7901 to changes in oldXMenu/XMenu.h from 2011-04-16.
7902 (struct XMenu): Declare `help_text' `const char **'.
7903
7904 * xfaces.c <Qunspecified>: Make extern again.
7905
7906 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7907 required by POSIX.
1b2de274 7908
762b15be
EZ
7909 * doc.c (get_doc_string): Improve the format passed to `error'.
7910
7911 * doprnt.c (doprnt): Improve commentary.
7912
7913 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7914
7915 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7916 them with etags.
7917
f1052e5d
EZ
7918 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7919 changes in globals.h immediately force recompilation.
762b15be
EZ
7920 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7921 $(CURDIR)/s/ms-w32.h.
7922 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7923
fa6996bc
EZ
7924 * character.c (Fchar_direction): Function deleted.
7925 (syms_of_character): Don't defsubr it.
7926 <char-direction-table>: Deleted.
7927
e6c3da20
EZ
79282011-04-23 Eli Zaretskii <eliz@gnu.org>
7929
7930 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7931 * doprnt.c: Include limits.h.
7932 (SIZE_MAX): New macro.
04f2d78b
CB
7933 (doprnt): Return a size_t value. 2nd arg is now size_t.
7934 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7935 Improve overflow protection. Support `l' modifier for integer
7936 conversions. Support %l conversion. Don't assume an EMACS_INT
7937 argument for integer conversions and for %c.
7938
7939 * lisp.h (doprnt): Restore prototype.
7940
7941 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7942 $(SRC)/character.h.
7943
7944 * Makefile.in (base_obj): Add back doprnt.o.
7945
7946 * deps.mk (doprnt.o): Add back prerequisites.
7947 (callint.o): Depend on character.h.
7948
7949 * eval.c (internal_lisp_condition_case): Include the handler
7950 representation in the error message.
7951 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7952 when breaking from the loop.
7953
7954 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7955
7956 * callint.c (Fcall_interactively): When displaying error message
7957 about invalid control letter, pass the character's codepoint, not
7958 a pointer to its multibyte form. Improve display of the character
7959 in octal and display also its hex code.
7960
7961 * character.c (char_string): Use %x to display the (unsigned)
7962 codepoint of an invalid character, to avoid displaying a bogus
7963 negative value.
7964
7965 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7966 `error', not SYMBOL_NAME itself.
7967
7968 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7969 character arguments to `error'.
7970
7971 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7972 to `error' in error message about FINAL_CHAR argument. Make sure
7973 FINAL_CHAR is a character, and use %c when it is passed as
7974 argument to `error'.
7975
4ffd0d6b 79762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7977
7978 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7979
7980 * w32.c: Include <time.h>.
7981 (sys_localtime): New function.
7982
4ffd0d6b 79832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7984
7985 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7986
4ffd0d6b 7987 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7988
4ffd0d6b 79892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7990
4ffd0d6b
GM
7991 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7992 zombies (Bug#8467).
aac0c6e3 7993
04c56954
EZ
79942011-04-19 Eli Zaretskii <eliz@gnu.org>
7995
7996 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7997 gl_state.e_property when gl_state.object is Qt.
7998
7999 * insdel.c (make_gap_larger): Remove limitation of buffer size
8000 to <= INT_MAX.
8001
16a43933
CY
80022011-04-18 Chong Yidong <cyd@stupidchicken.com>
8003
8004 * xdisp.c (lookup_glyphless_char_display)
8005 (produce_glyphless_glyph): Handle cons cell entry in
8006 glyphless-char-display.
8007 (Vglyphless_char_display): Document it.
8008
8009 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8010 glyphless-char-display.
8011
4581706e
CY
80122011-04-17 Chong Yidong <cyd@stupidchicken.com>
8013
8014 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8015
8016 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8017
8018 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8019 definition for no-X builds.
8020
4887c6e2 80212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8022
fd35b6f9
PE
8023 Static checks with GCC 4.6.0 and non-default toolkits.
8024
5c1ccb01
PE
8025 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8026
006c5daa
PE
8027 * process.c (keyboard_bit_set): Define only if SIGIO.
8028 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8029 (send_process): Repair possible setjmp clobbering.
8030
efc736d3
PE
8031 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8032
4e2fe2e6
PE
8033 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8034
f97334a2
PE
8035 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8036
4e75f29d
PE
8037 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8038 Define only if needed.
8039
90efadd1
PE
8040 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8041 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8042 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8043
3c647824
PE
8044 * dispextern.h (struct redisplay_interface): Rename param
8045 to avoid shadowing.
e264f262 8046 * termhooks.h (struct terminal): Likewise.
761383f4 8047 * xterm.c (xembed_send_message): Likewise.
3c647824 8048
b58c5c4a
PE
8049 * insdel.c (make_gap_smaller): Define only if
8050 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8051
cad59032
PE
8052 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8053 it.
8054
c339dc2e
PE
8055 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8056 so that we aren't warned about unused symbols.
8057
91a3e27b
PE
8058 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8059
399c71d3 8060 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8061
8ffc96f5
PE
8062 * xfns.c (x_real_positions): Mark locals as initialized.
8063
eef9bc79
PE
8064 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8065
098db9dd
PE
8066 * xterm.c: Fix problems found by static analysis with other toolkits.
8067 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8068 (x_dispatch_event): Declare static if USE_GTK, and
8069 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8070 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8071 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8072 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8073 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8074
eb18f6cc
PE
8075 * xmenu.c (menu_help_callback): Pointer type fixes.
8076 Use const pointers when pointing at readonly data. Avoid pointer
8077 signedness clashes.
8078 (FALSE): Remove unused macro.
8079 (update_frame_menubar): Remove unused decl.
8080
1fe72bf8
PE
8081 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8082
60d9e1db
PE
8083 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8084 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8085 (single_menu_item): Rename local to avoid shadowing.
8086
39261c26
PE
8087 * keyboard.c (make_lispy_event): Remove unused local var.
8088
018c5e19
PE
8089 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8090 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8091
63d2b86e
PE
8092 * bitmaps: Change bitmaps from unsigned char back to the X11
8093 compatible char. Avoid the old compiler warnings about
8094 out-of-range initializers by using, for example, '\xab' rather
8095 than 0xab.
8096
aefd87e1
PE
8097 * xgselect.c (xgselect_initialize): Check vs interface
8098 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8099
bf501fb9
PE
8100 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8101
e9829fdf
PE
8102 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8103 to read-only memory.
8104
1086c095
PE
8105 * fns.c (vector): Remove; this old hack is no longer needed.
8106
2baccd04 8107 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8108 Remove unused var.
dde42981 8109 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8110
72391843 8111 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8112
436c16df 8113 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8114 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8115 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8116
92bb796d 8117 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8118 (x_term_init): Remove local to avoid shadowing.
92bb796d 8119
764430a3 8120 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8121
8122 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8123 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8124
d1dfb56c
EZ
81252011-04-16 Eli Zaretskii <eliz@gnu.org>
8126
c4354cb4
EZ
8127 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8128
d1dfb56c
EZ
8129 Fix regex.c, syntax.c and friends for buffers > 2GB.
8130 * syntax.h (struct gl_state_s): Declare character position members
8131 EMACS_INT.
8132
8133 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8134
04f2d78b
CB
8135 * textprop.c (verify_interval_modification, interval_of):
8136 Declare arguments EMACS_INT.
d1dfb56c
EZ
8137
8138 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8139 EMACS_INT.
8140
8141 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8142
8143 * indent.c (Fvertical_motion): Local variable it_start is now
8144 EMACS_INT.
8145
8146 * regex.c (re_match, re_match_2, re_match_2_internal)
8147 (bcmp_translate, regcomp, regexec, print_double_string)
8148 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8149 (re_compile_pattern, re_exec): Declare arguments and local
8150 variables `size_t' and `ssize_t' and return values `regoff_t', as
8151 appropriate.
8152 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8153 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8154 <compile_stack_type>: `size' and `avail' are now `size_t'.
8155
8156 * regex.h <regoff_t>: Use ssize_t, not int.
8157 (re_search, re_search_2, re_match, re_match_2): Arguments that
8158 specify buffer/string position and length are now ssize_t and
8159 size_t. Return type is regoff_t.
8160
613052cd
BK
81612011-04-16 Ben Key <bkey76@gmail.com>
8162
8163 * nsfont.m: Fixed bugs in ns_get_family and
8164 ns_descriptor_to_entity that were caused by using free to
8165 deallocate memory blocks that were allocated by xmalloc (via
8166 xstrdup). This caused Emacs to crash when compiled with
8167 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8168 --enable-checking=xmallocoverrun). xfree is now used to
8169 deallocate these memory blocks.
8170
4170f62f 81712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8172
71b41406
PE
8173 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8174
9587a89d
PE
8175 emacs_write: Accept and return EMACS_INT for sizes.
8176 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8177 et seq.
8178 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8179 Accept and return EMACS_INT.
8180 (emacs_gnutls_write): Return the number of bytes written on
8181 partial writes.
8182 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8183 (emacs_read, emacs_write): Remove check for negative size, as the
8184 Emacs source code has been audited now.
9587a89d
PE
8185 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8186 (emacs_read, emacs_write): Use it.
273a5f82
PE
8187 * process.c (send_process): Adjust to the new signatures of
8188 emacs_write and emacs_gnutls_write. Do not attempt to store
8189 a byte offset into an 'int'; it might overflow.
9587a89d 8190 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8191
3e047f51
PE
8192 * sound.c: Don't assume sizes fit in 'int'.
8193 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8194 Return EMACS_INT, not int.
3e047f51 8195 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8196 Accept EMACS_INT, not int.
8197 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8198 record read return values.
8199
cc39a9db
BK
82002011-04-15 Ben Key <bkey76@gmail.com>
8201
c9d0ec6d
JB
8202 * keyboard.c (Qundefined): Don't declare static since it is used
8203 in nsfns.m.
8204 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8205 static since they are used in nsfont.m.
cc39a9db 8206
6c60eb9f
SM
82072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8208
8209 * process.c (Qprocessp): Don't declare static.
8210 * lisp.h (Qprocessp): Declare again.
8211
7990b61a
JB
82122011-04-15 Juanma Barranquero <lekktu@gmail.com>
8213
8214 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8215
5d4cb038
PE
82162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8217
8bd7b830 8218 Improve C-level modularity by making more things 'static'.
cd64ea1d 8219
e3b27b31
PE
8220 Don't publish debugger-only interfaces to other modules.
8221 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8222 (verify_bytepos, count_markers): Move decls to the only modules
8223 that need them.
8224 * region-cache.h (pp_cache): Likewise.
8225 * window.h (check_all_windows): Likewise.
8226 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8227
5d4cb038
PE
8228 * sysdep.c (croak): Now static, if
8229 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8230 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8231
8232 * alloc.c (refill_memory_reserve): Now static if
8233 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8234 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8235
e87b6180
PE
8236 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8237 Define only if USE_LUCID.
8238
ac64929e
PE
8239 * xrdb.c (x_customization_string, x_rm_string): Now static.
8240
6f37259d
PE
8241 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8242 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8243
1683e3ab
PE
8244 * xdisp.c (draw_row_with_mouse_face): Now static.
8245 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8246
de9c2632
PE
8247 * window.h (check_all_windows): Mark externally visible.
8248
2b96acb7
PE
8249 * window.c (window_deletion_count): Now static.
8250
8251 * undo.c: Make symbols static if they're not exported.
8252 (last_undo_buffer, last_boundary_position, pending_boundary):
8253 Now static.
8254
50436f33
PE
8255 * textprop.c (interval_insert_behind_hooks): Now static.
8256 (interval_insert_in_front_hooks): Likewise.
8257
64520e5c
PE
8258 * term.c: Make symbols static if they're not exported.
8259 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8260 (max_frame_lines, tty_set_terminal_modes):
8261 (tty_reset_terminal_modes, tty_turn_off_highlight):
8262 (get_tty_terminal): Now static.
8263 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8264 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8265 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8266 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8267 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8268
1fa53021
PE
8269 * sysdep.c: Make symbols static if they're not exported.
8270 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8271 Now static.
8272 (sigprocmask_set, full_mask): Remove; unused.
8273 (wait_debugging): Mark as visible.
8274 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8275 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8276
d4b43b22
PE
8277 * syntax.c (syntax_temp): Define only if !__GNUC__.
8278
b7c513d0
PE
8279 * sound.c (current_sound_device, current_sound): Now static.
8280
989b29ad
PE
8281 * search.c (searchbufs, searchbuf_head): Now static.
8282
13a55a78
PE
8283 * scroll.c (scroll_cost): Remove; unused.
8284 * dispextern.h (scroll_cost): Remove decl.
8285
de68a1fc
PE
8286 * region-cache.h (pp_cache): Mark as externally visible.
8287
40ccffa6
PE
8288 * process.c: Make symbols static if they're not exported.
8289 (process_tick, update_tick, create_process, chan_process):
8290 (Vprocess_alist, proc_buffered_char, datagram_access):
8291 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8292 (deactivate_process): Mark defn as static, as well as decl.
8293 * lisp.h (create_process): Remove decl.
8294 * process.h (chan_process, Vprocess_alist): Remove decls.
8295
ad64fc97
PE
8296 * print.c: Make symbols static if they're not exported.
8297 (print_depth, new_backquote_output, being_printed, print_buffer):
8298 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8299 (print_interval, print_number_index, initial_stderr_stream):
8300 Now static.
8301 * lisp.h (Fprinc): Remove decl.
8302 (debug_output_compilation_hack): Mark as externally visible.
8303
adddb265
PE
8304 * sysdep.c (croak): Move decl from here to syssignal.h.
8305 * syssignal.h (croak): Put it here, so the API can be checked when
8306 'croak' is called from dissociate_if_controlling_tty.
8307
1717ede2
PE
8308 * minibuf.c: Make symbols static if they're not exported.
8309 (minibuf_save_list, choose_minibuf_frame): Now static.
8310 * lisp.h (choose_minibuf_frame): Remove decl.
8311
fa5fb2bc
PE
8312 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8313
1e3890d1
PE
8314 * lread.c: Make symbols static if they're not exported.
8315 (read_objects, initial_obarray, oblookup_last_bucket_number):
8316 Now static.
8317 (make_symbol): Remove; unused.
8318 * lisp.h (initial_obarray, make_symbol): Remove decls.
8319
8a1414fa
PE
8320 * keyboard.c: Make symbols static if they're not exported.
8321 (single_kboard, recent_keys_index, total_keys, recent_keys):
8322 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8323 (this_single_command_key_start, echoing, last_auto_save):
8324 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8325 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8326 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8327 (Vlispy_mouse_stem, double_click_count):
8328 Now static.
8329 (force_auto_save_soon): Define only if SIGDANGER.
8330 (ignore_mouse_drag_p): Now static if
8331 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8332 (print_help): Remove; unused.
8333 (stop_character, last_timer_event): Mark as externally visible.
8334 * keyboard.h (ignore_mouse_drag_p): Declare only if
8335 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8336 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8337 * lisp.h (echoing): Remove decl.
8338 (force_auto_save_soon): Declare only if SIGDANGER.
8339 * xdisp.c (redisplay_window): Simplify code, to make it more
8340 obvious that ignore_mouse_drag_p is not accessed if !defined
8341 USE_GTK && !defined HAVE_NS.
8342
93ea6e8f
PE
8343 * intervals.c: Make symbols static if they're not exported.
8344 (merge_properties_sticky, merge_interval_right, delete_interval):
8345 Now static.
8346 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8347
77382fcc
PE
8348 * insdel.c: Make symbols static if they're not exported.
8349 However, leave prepare_to_modify_buffer alone. It's never
8350 called from outside this function, but that appears to be a bug.
8351 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8352 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8353 (adjust_after_replace_noundo): Remove; unused.
8354 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8355 (signal_before_change): Remove decls.
77382fcc 8356
9306c32e
PE
8357 * indent.c (val_compute_motion, val_vmotion): Now static.
8358
cd44d2eb
PE
8359 * image.c: Make symbols static if they're not exported.
8360 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8361 if USE_GTK.
8362 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8363 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8364
ad9a7a06
PE
8365 * fringe.c (standard_bitmaps): Now static.
8366 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8367
81626931
PE
8368 * frame.c: Make symbols static if they're not exported.
8369 (x_report_frame_params, make_terminal_frame): Now static.
8370 (get_frame_param): Now static, unless HAVE_NS.
8371 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8372 (x_get_resource_string): Remove; not used.
8373 * frame.h (make_terminal_frame, x_report_frame_params):
8374 (x_get_resource_string); Remove decls.
8375 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8376 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8377
239f9db9
PE
8378 * font.c, fontset.c: Make symbols static if they're not exported.
8379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8380 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8381 * font.c (font_close_object): Now static.
8382 * font.h (font_close_object): Remove.
8383 * fontset.c (FONTSET_OBJLIST): Remove.
8384 (free_realized_fontset) #if-0 the body, which does nothing.
8385 (face_suitable_for_char_p): #if-0, as it's never called.
8386 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8387 * xfaces.c (face_at_string_position):
8388 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8389 since 0 is always ASCII.
8390
dfcf3579
PE
8391 * fns.c (weak_hash_tables): Now static.
8392
5045092b
PE
8393 * fileio.c: Make symbols static if they're not exported.
8394 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8395 (Vwrite_region_annotation_buffers): Now static.
8396
57a96f5c
PE
8397 * eval.c: Make symbols static if they're not exported.
8398 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8399 * lisp.h (backtrace_list): Remove decl.
8400
35f08c38
PE
8401 * emacs.c: Make symbols static if they're not exported.
8402 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8403 (fatal_error_code, fatal_error_signal_hook, standard_args):
8404 Now static.
8405 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8406 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8407 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8408 * lisp.h (fatal_error_signal_hook): Remove decl.
8409 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8410
f44bd759
PE
8411 * editfns.c: Move a (normally-unused) function to its only use.
8412 * editfns.c, lisp.h (get_operating_system_release): Remove.
8413 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8414 worth the hassle of breaking this out.
8415
b532497d
PE
8416 * xterm.c: Make symbols static if they're not exported.
8417 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8418 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8419 (x_destroy_window, x_delete_display):
8420 Now static.
8421 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8422 (x_mouse_leave): Remove; unused.
8423 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8424 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8425 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8426 Remove decls.
8427 (x_mouse_leave): Declare only if WINDOWSNT.
8428 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8429 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8430 USE_X_TOOLKIT.
8431
1675728f
PE
8432 * ftxfont.c: Make symbols static if they're not exported.
8433 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8434 HAVE_FREETYPE.
8435 * font.h (ftxfont_driver): Likewise.
8436
e4cebfca
PE
8437 * xfns.c: Make symbols static if they're not exported.
8438 (x_last_font_name, x_display_info_for_name):
8439 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8440 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8441 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8442 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8443 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8444 (last_show_tip_args): Now static.
8445 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8446 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8447 (x_screen_planes): Remove; unused.
8448 * dispextern.h (x_screen_planes): Remove decl.
8449
5bf46f05
PE
8450 * dispnew.c: Make symbols static if they're not exported.
8451 * dispextern.h (redraw_garbaged_frames, scrolling):
8452 (increment_row_positions): Remove.
8453 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8454 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8455 Now static.
8456 (redraw_garbaged_frames): Remove; unused.
8457
435f4c28
PE
8458 * xfaces.c: Make symbols static if they're not exported.
8459 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8460 Remove decls.
8461 * xterm.h (defined_color): Remove decls.
8462 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8463 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8464 (menu_face_changed_default, defined_color, free_realized_face):
8465 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8466 (ascii_face_of_lisp_face): Remove; unused.
8467
8524aef3
PE
8468 * xdisp.c: Make symbols static if they're not exported.
8469 * dispextern.h (scratch_glyph_row, window_box_edges):
8470 (glyph_to_pixel_coords, set_cursor_from_row):
8471 (get_next_display_element, set_iterator_to_next):
8472 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8473 (show_mouse_face): Remove decls
8474 * frame.h (message_buf_print): Likewise.
8475 * lisp.h (pop_message, set_message, check_point_in_composition):
8476 Likewise.
8477 * xterm.h (set_vertical_scroll_bar): Likewise.
8478 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8479 (message_buf_print, scratch_glyph_row, displayed_buffer):
8480 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8481 (get_next_display_element, show_mouse_face, window_box_edges):
8482 (frame_to_window_pixel_xy, check_point_in_composition):
8483 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8484 (glyph_to_pixel_coords): Remove; unused.
8485
16390cd2
PE
8486 * dired.c (file_name_completion): Now static.
8487
8488 * dbusbind.c (xd_in_read_queued_messages): Now static.
8489
a25f4dfa
PE
8490 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8491 * data.c (circular_list_error): Remove.
8492
14a9c8df
PE
8493 * commands.h (last_point_position, last_point_position_buffer):
8494 (last_point_position_window): Remove decls.
8495 * keyboard.c: Make these variables static.
8496
04f2d78b
CB
8497 * coding.h (coding, code_convert_region, encode_coding_gap):
8498 Remove decls.
74ab6df5
PE
8499 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8500 (iso_code_class, detect_coding, code_convert_region): Now static.
8501 (encode_coding_gap): Remove; unused.
8502
38dfbee1
PE
8503 * chartab.c (chartab_chars, chartab_bits): Now static.
8504
a2cb4e63
PE
8505 * charset.h (charset_iso_8859_1): Remove decl.
8506 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8507 Now static.
8508
127198fd
PE
8509 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8510 * ccl.c (Vccl_program_table): Now static.
8511 (check_ccl_update): Remove; unused.
8512
d85b608f
PE
8513 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8514 * category.h: ... from here.
8515 * category.c (check_category_table, set_category_set): Now static.
8516
31cd66f3
PE
8517 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8518 * lisp.h: Remove these decls.
8519
c358e587
PE
8520 * buffer.c (buffer_count): Remove unused var.
8521
e78aecca
PE
8522 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8523 so that it's not optimized away.
8524 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8525 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8526 exported only to the debugger.
8527
e192d7d3 8528 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8529 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8530
92470028
PE
8531 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8532 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8533 was inaccessible from Lisp.
8534 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8535 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8536
244ed907
PE
8537 alloc.c: Import and export fewer symbols, and remove unused items.
8538 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8539 is defined.
8540 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8541 it's not optimized away by whole-program optimization.
8542 (message_enable_multibyte, free_misc): Remove.
8543 (catchlist, handlerlist, mark_backtrace):
8544 Declare only if BYTE_MARK_STACK.
8545 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8546 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8547 (message_enable_multibyte): Remove decl.
8548 (free_misc, interval_free_list, float_block, float_block_index):
8549 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8550 (cons_free_list, last_marked_index):
8551 Now static.
8552 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8553 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8554 (mark_backtrace): Define only if BYTE_MARK_STACK.
8555 * xdisp.c (message_enable_multibyte): Now static.
8556
61c2b50e 8557 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8558 This makes it easier for human readers (and static analyzers)
8559 to see whether these variables are used from other modules.
8560 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8561 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8562 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8563 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8564 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8565 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8566 * xmenu.c, xselect.c:
8567 Declare Q* vars static if they are not used in other modules.
8568 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8569 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8570 Remove decls of unexported vars.
8571 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8572
95c82688
PE
8573 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8574
16a97296
PE
8575 Make Emacs functions such as Fatom 'static' by default.
8576 This makes it easier for human readers (and static analyzers)
8577 to see whether these functions can be called from other modules.
8578 DEFUN now defines a static function. To make the function external
8579 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8580 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8581 (Finit_image_library):
16a97296
PE
8582 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8583 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8584 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8585 Remove decls, since these functions are now static.
8586 (Funintern, Fget_internal_run_time): New decls, since these functions
8587 were already external.
95c82688 8588
16a97296
PE
8589 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8590 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8591 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8592 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8593 * keyboard.c, keymap.c, lread.c:
8594 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8595 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8596 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8597 Mark functions with DEFUE instead of DEFUN,
8598 if they are used in other modules.
8599 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8600 decls for now-static functions.
8601 * buffer.h (Fdelete_overlay): Remove decl.
8602 * callproc.c (Fgetenv_internal): Mark as internal.
8603 * composite.c (Fremove_list_of_text_properties): Remove decl.
8604 (Fcomposition_get_gstring): New forward static decl.
8605 * composite.h (Fcomposite_get_gstring): Remove decl.
8606 * dired.c (Ffile_attributes): New forward static decl.
8607 * doc.c (Fdocumntation_property): New forward static decl.
8608 * eval.c (Ffetch_bytecode): New forward static decl.
8609 (Funintern): Remove extern decl; now in .h file where it belongs.
8610 * fileio.c (Fmake_symbolic_link): New forward static decl.
8611 * image.c (Finit_image_library): New forward static decl.
8612 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8613 * intervals.h (Fprevious_property_change):
8614 (Fremove_list_of_text_properties): Remove decls.
8615 * keyboard.c (Fthis_command_keys): Remove decl.
8616 (Fcommand_execute): New forward static decl.
8617 * keymap.c (Flookup_key): New forward static decl.
8618 (Fcopy_keymap): Now static.
8619 * keymap.h (Flookup_key): Remove decl.
8620 * process.c (Fget_process): New forward static decl.
8621 (Fprocess_datagram_address): Mark as internal.
8622 * syntax.c (Fsyntax_table_p): New forward static decl.
8623 (skip_chars): Remove duplicate decl.
8624 * textprop.c (Fprevious_property_change): New forward static decl.
8625 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8626 Now internal.
8627 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8628 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8629
785bbd42
PE
8630 * editfns.c (Fformat): Remove unreachable code.
8631
8b913b57
AS
86322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8633
8634 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8635 change. (Bug#8496)
8636
a6744a35
EZ
86372011-04-13 Eli Zaretskii <eliz@gnu.org>
8638
8639 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8640 when at ZV. (Bug#8487)
8641
e7974947
AS
86422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8643
baad03f0
AS
8644 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8645 (Bug#8437)
8646 * keyboard.c (parse_tool_bar_item): Likewise.
8647 * sound.c (sound_cleanup, alsa_close): Likewise.
8648 * termcap.c (tgetent): Likewise.
8649 * xfns.c (x_default_font_parameter): Likewise.
8650 * xsettings.c (read_and_apply_settings): Likewise.
8651
e7974947
AS
8652 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8653 (overrun_check_free): Protoize.
8654
28272684
PE
86552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8656
8657 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8658 since callers should never pass a negative size.
8659 Change the signature to match that of plain 'read' and 'write'; see
8660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8661 * lisp.h: Update prototypes of emacs_write and emacs_read.
8662
11997c76
EZ
86632011-04-11 Eli Zaretskii <eliz@gnu.org>
8664
8665 * xdisp.c (redisplay_window): Don't try to determine the character
8666 position of the scroll margin if the window start point w->startp
e896f03c 8667 is outside the buffer's accessible region. (Bug#8468)
11997c76 8668
8a2cbd72
EZ
86692011-04-10 Eli Zaretskii <eliz@gnu.org>
8670
8671 Fix write-region and its subroutines for buffers > 2GB.
8672 * fileio.c (a_write, e_write): Modify declaration of arguments and
8673 local variables to support buffers larger than 2GB.
8674 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8675
8676 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8677 argument, local variables, and return value.
8678
8679 * lisp.h: Update prototypes of emacs_write and emacs_read.
8680
8681 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8682
4073e537 86832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8684
1ebfdcb6
PE
8685 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8686
b2ded58d
PE
8687 Fix more problems found by GCC 4.6.0's static checks.
8688
7d66342c
PE
8689 * xdisp.c (vmessage): Use a better test for character truncation.
8690
bbf47d44
PE
8691 * charset.c (load_charset_map): <, not <=, for optimization,
8692 and to avoid potential problems with integer overflow.
9248994d 8693 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8694 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8695 * editfns.c (Fformat): Likewise.
1e69125e 8696 * syntax.c (skip_chars): Likewise.
3befa583 8697
e3019616
PE
8698 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8699 This also lets GCC 4.6.0 generate slightly better loop code.
8700
becfa255
PE
8701 * callint.c (Fcall_interactively): <, not <=, for optimization.
8702 (Fcall_interactively): Count the number of arguments produced,
8703 not the number of arguments given. This is simpler and lets GCC
8704 4.6.0 generate slightly better code.
8705
dae0cd48
PE
8706 * ftfont.c: Distingish more carefully between FcChar8 and char.
8707 The previous code passed unsigned char * to a functions like
8708 strlen and xstrcasecmp that expect char *, which does not
8709 conform to the C standard.
8710 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8711 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8712 char * when the C standard requires it.
8713
76032d70
PE
8714 * keyboard.c (read_char): Remove unused var.
8715
eb3f1cc8
PE
8716 * eval.c: Port to Windows vsnprintf (Bug#8435).
8717 Include <limits.h>.
8718 (SIZE_MAX): Define if the headers do not.
8719 (verror): Do not give up if vsnprintf returns a negative count.
8720 Instead, grow the buffer. This ports to Windows vsnprintf, which
8721 does not conform to C99. Problem reported by Eli Zaretskii.
8722 Also, simplify the allocation scheme, by avoiding the need for
8723 calling realloc, and removing the ALLOCATED variable.
8724
70476b54
PE
8725 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8726
12020a9e
PE
8727 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8728 But keep the doprint source code for now, as we might revamp it
8729 and use it again (Bug#8435).
ea6c7ae6
PE
8730 * lisp.h (doprnt): Remove.
8731 * Makefile.in (base_obj): Remove doprnt.o.
8732 * deps.mk (doprnt.o): Remove.
8733
5fdb398c
PE
8734 error: Print 32- and 64-bit integers portably (Bug#8435).
8735 Without this change, on typical 64-bit hosts error ("...%d...", N)
8736 was used to print both 32- and 64-bit integers N, which relied on
8737 undefined behavior.
61bdb816 8738 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8739 * lisp.h (error, verror): Mark as printf-like functions.
8740 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8741 Report overflow in size calculations when allocating printf buffer.
8742 Do not truncate output string at its first null byte.
8743 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8744 Truncate the output at a character boundary, since vsnprintf does not
8745 do that.
8746 * charset.c (check_iso_charset_parameter): Convert internal
8747 character to string before calling 'error', since %c now has the
8748 printf meaning.
8749 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8750 overflow when computing char to be passed to 'error'. Do not
8751 pass Lisp_Object to 'error'; pass the integer instead.
8752 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8753 formatted with plain %d.
8754
b189fa66
PE
8755 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8756
bff87ef0
PE
8757 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8758
7e2cac20
PE
8759 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8760
ce4d90b5
PE
8761 * xterm.c (x_catch_errors): Remove duplicate declaration.
8762
266c9547
PE
8763 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8764
79c49ad2
PE
8765 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8766
368f4090
JM
87672011-04-10 Jim Meyering <meyering@redhat.com>
8768
8769 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8770 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8771 return ssize_t not "int", and use size_t as the buffer length.
8772 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8773 * gnutls.h: Update declarations.
8774 * process.c (read_process_output): Use ssize_t, to match.
8775 (send_process): Likewise.
8776
a32d4040
CY
87772011-04-09 Chong Yidong <cyd@stupidchicken.com>
8778
8779 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8780
8546720e 87812011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8782
04f2d78b
CB
8783 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8784 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8785
8546720e
GM
8786 * xterm.c (handle_one_xevent):
8787 * xmenu.c (create_and_show_popup_menu):
8788 * xselect.c (x_decline_selection_request)
8789 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8790
0a2f5c1a 87912011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8792
8793 Fix some uses of `int' instead of EMACS_INT.
8794 * search.c (string_match_1, fast_string_match)
8795 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8796 (scan_buffer, find_next_newline_no_quit)
8797 (find_before_next_newline, search_command, Freplace_match)
8798 (Fmatch_data): Make some `int' variables be EMACS_INT.
8799
8800 * xdisp.c (display_count_lines): 3rd argument and return value now
8801 EMACS_INT. All callers changed.
8802 (pint2hrstr): Last argument is now EMACS_INT.
8803
8804 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8805 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8806 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8807 (decode_coding_utf_16, decode_coding_emacs_mule)
8808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8809 (decode_coding_ccl, decode_coding_charset)
8810 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8811 (decode_coding_iso_2022, decode_coding_emacs_mule)
8812 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8813 <char_offset, last_offset>: Declare EMACS_INT.
8814 (encode_coding_utf_8, encode_coding_utf_16)
8815 (encode_coding_emacs_mule, encode_invocation_designation)
8816 (encode_designation_at_bol, encode_coding_iso_2022)
8817 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8818 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8819 Declare EMACS_INT.
8820 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8821 (encode_invocation_designation): Last argument P_NCHARS is now
8822 EMACS_INT.
8823 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8824 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8825
8826 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8827 All users changed.
8828
8829 * ccl.c (Fccl_execute_on_string): Declare some variables
8830 EMACS_INT.
8831
8546720e 88322011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8833
8834 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8835
4e19a977
CS
88362011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8837
8838 * process.c (Fformat_network_address): Doc fix.
8839
87302331
R
88402011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8841
ee7683eb 8842 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8843
cbb59342
CY
88442011-04-08 Chong Yidong <cyd@stupidchicken.com>
8845
8846 * keyboard.c (read_char): Call Lisp function help-form-show,
8847 instead of using internal_with_output_to_temp_buffer.
8848 (Qhelp_form_show): New var.
e0d38eeb 8849 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8850
8851 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8852
8853 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8854
e67a13ab
CY
88552011-04-06 Chong Yidong <cyd@stupidchicken.com>
8856
04f2d78b
CB
8857 * process.c (Flist_processes): Remove to Lisp.
8858 (list_processes_1): Delete.
e67a13ab 8859
973f782d
EZ
88602011-04-06 Eli Zaretskii <eliz@gnu.org>
8861
7c106b1e
EZ
8862 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8863
973f782d
EZ
8864 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8865
41cf7d1a 88662011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8867
ca23cc88
PE
8868 Fix more problems found by GCC 4.6.0's static checks.
8869
f390e2d5
PE
8870 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8871
42eea0d0
PE
8872 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8873
b69769da 8874 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8875
f9541e84
PE
8876 * xdisp.c (vmessage): Mark as a printf-like function.
8877
13841b55
PE
8878 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8879
c136c10f
PE
8880 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8881
5e2d4a30
PE
8882 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8883 printf-like functions.
8884 (tiff_load): Add casts to remove these marks before passing them
8885 to system-supplied API.
8886
583f48b9
PE
8887 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8888
b25d760e
PE
8889 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8890 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8891 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8892 directly, rather than having caller test rule sign. This avoids
8893 some unnecessary tests.
8894 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8895 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8896 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8897
bc7b6697 8898 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8899 (xfont_open): Avoid unnecessary tests.
bc7b6697 8900
27ccc379
PE
8901 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8902
dcd5c89a
PE
8903 * composite.h, composite.c (composition_gstring_put_cache):
8904 Use EMACS_INT, not int, for length.
8905
b13a45c6
PE
8906 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8907 breaking out part of COMPOSITION_DECODE_RULE.
8908 (COMPOSITION_DECODE_RULE): Use it.
8909 * composite.c (get_composition_id): Remove unused local vars,
8910 by using the new macro.
8911
1e792e4d
PE
8912 * textprop.c (set_text_properties_1): Change while to do-while,
8913 since the condition is always true at first.
8914
dc6c6455 8915 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8916 (interval_deletion_adjustment): Return unsigned value.
8917 All uses changed.
dc6c6455 8918
aba7731a
PE
8919 * process.c (list_processes_1, create_pty, read_process_output):
8920 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8921 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8922 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8923 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8924 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8925
fdfc4bf3
PE
8926 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8927
fca8fe46 8928 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8929 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8930
06a0259a 8931 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8932 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8933 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8934
e7b9e80f
PE
8935 * print.c (print_error_message): Avoid int overflow.
8936
56201685
PE
8937 * font.c (font_list_entities): Redo for clarity,
8938 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8939
78834453 8940 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8941 (font_score): Avoid potential overflow in diff calculation.
78834453 8942
0bc0b309 8943 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8944 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8945
e610eaca
PE
8946 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8947
b895abce
PE
8948 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8949 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8950 can always succeed if overflow has undefined behavior.
8951
1f1d9321 8952 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8953 (wordify): Omit three unnecessary tests.
1f1d9321 8954
c59478bc
PE
8955 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8956 All callers changed. This avoids the need for an unused var.
8957
79b73827
PE
8958 * casefiddle.c (casify_region): Remove var that is set but not used.
8959
a4db5dfe
PE
8960 * dired.c (file_name_completion): Remove var that is set but not used.
8961
43aae36e
PE
8962 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8963
2a47c44d 8964 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8965 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8966
a37c69bf
PE
8967 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8968 Check for integer overflow on size calculations.
8969
328ab8e7
PE
8970 * buffer.c (Fprevious_overlay_change): Remove var that is set
8971 but not used.
8972
e5a2a5cb
PE
8973 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8974 Remove vars that are set but not used.
8d84a6eb 8975 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8976 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8977
a60e5f68
PE
8978 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8979
f661cb61 8980 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8981 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8982
f0397f5a
PE
8983 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8984 that are set but not used.
8985
8664db06 8986 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8987 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8988
6abdaa4a
PE
8989 * xselect.c (x_get_local_selection, x_handle_property_notify):
8990 Remove vars that are set but not used.
8991
0ce7538d 8992 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8993 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8994
9ae848fc
PE
8995 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8996 Remove var that is set but not used.
0b918413
PE
8997 (scroll_bar_windows_size): Now size_t, not int.
8998 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8999 Check for overflow.
9ae848fc 9000
a5a62657
PE
9001 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9002 (map_tty_color) [!defined MSDOS]: Likewise.
9003
5c5cdd39
PE
9004 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9005
66ebf983
PE
9006 * coding.c: Remove vars that are set but not used.
9007 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9008 All callers changed.
9009 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9010 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9011 (decode_coding_charset): Remove vars that are set but not used.
9012
1be4d761
PE
9013 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9014 that is set but not used.
9015
47553fa8
PE
9016 * print.c (print_object): Remove var that is set but not used.
9017
1f7196bf 9018 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9019 The gnulib version avoids calling malloc in the usual case,
9020 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9021 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9022 * filelock.c (current_lock_owner): Likewise.
9023 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9024 * sysdep.c: Include allocator.h, careadlinkat.h.
9025 (emacs_no_realloc_allocator): New static constant.
9026 (emacs_readlink): New function.
fdb61804
PE
9027 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9028 ../lib/careadlinkat.h.
d1fdcab7 9029
f84c17c7
SM
90302011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9031
9032 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9033 first non-nil return value).
9034
ef3862ad
JD
90352011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9036
9037 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9038 if not defined (Bug#8403).
9039
376a7006
JB
90402011-04-02 Juanma Barranquero <lekktu@gmail.com>
9041
9042 * xdisp.c (display_count_lines): Remove parameter `start',
9043 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9044 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9045 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9046 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9047 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9048 and thereabouts. All callers changed.
9049 (get_per_char_metric): Remove parameter `f', unused since
9050 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9051
6ca3801d
JM
90522011-04-02 Jim Meyering <meyering@redhat.com>
9053
9054 do not dereference NULL upon failed strdup
9055 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9056 (ns_get_family): Likewise.
9057
d8e2b5ba
JB
90582011-04-02 Juanma Barranquero <lekktu@gmail.com>
9059
9060 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9061
8c74fcbd
JD
90622011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9063
9064 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9065 later (Bug#8403).
9066
7200d79c
SM
90672011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9068
03408648 9069 Add lexical binding.
7200d79c 9070
03408648
SM
9071 * window.c (Ftemp_output_buffer_show): New fun.
9072 (Fsave_window_excursion):
9073 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9074
9075 * lread.c (lisp_file_lexically_bound_p): New function.
9076 (Fload): Bind Qlexical_binding.
9077 (readevalloop): Remove `evalfun' arg.
9078 Bind Qinternal_interpreter_environment.
9079 (Feval_buffer): Bind Qlexical_binding.
9080 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9081 Mark as dynamic.
9082 (syms_of_lread): Declare `lexical-binding'.
9083
9084 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9085
9086 * keyboard.c (eval_dyn): New fun.
9087 (menu_item_eval_property): Use it.
ca105506
SM
9088
9089 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9090
03408648
SM
9091 * fns.c (concat, mapcar1): Accept byte-code-functions.
9092
9093 * eval.c (Fsetq): Handle lexical vars.
9094 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9095 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9096 (FletX, Flet): Obey lexical binding.
9097 (Fcommandp): Handle closures.
9098 (Feval): New `lexical' arg.
9099 (eval_sub): New function extracted from Feval. Use it almost
9100 everywhere where Feval was used. Look up vars in lexical env.
9101 Handle closures.
9102 (Ffunctionp): Move from subr.el.
9103 (Ffuncall): Handle closures.
9104 (apply_lambda): Remove `eval_flags'.
9105 (funcall_lambda): Handle closures and new byte-code-functions.
9106 (Fspecial_variable_p): New function.
9107 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9108 but without exporting it to Lisp.
23aba0ea 9109
23aba0ea 9110 * doc.c (Fdocumentation, store_function_docstring):
03408648 9111 * data.c (Finteractive_form): Handle closures.
23aba0ea 9112
03408648
SM
9113 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9114 interactive spec.
ba83908c 9115
04f2d78b
CB
9116 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9117 New byte-codes.
03408648
SM
9118 (exec_byte_code): New function extracted from Fbyte_code to handle new
9119 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9120
03408648 9121 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9122
03408648 9123 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9124
e2abce01
JB
91252011-03-31 Juanma Barranquero <lekktu@gmail.com>
9126
9127 * xdisp.c (redisplay_internal): Fix prototype.
9128
63696a73 91292011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9130
63696a73 9131 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9132 (try_scrolling): Use it when setting scroll_limit.
9133 Limit scrolling to 100 screen lines.
63696a73
EZ
9134 (redisplay_window): Even when falling back on "recentering",
9135 position point in the window according to scroll-conservatively,
9136 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9137
9138 (try_scrolling): When point is above the window, allow searching
9139 as far as scroll_max, or one screenful, to compute vertical
9140 distance from PT to the scroll margin position. This prevents
9141 try_scrolling from unnecessarily failing when
9142 scroll-conservatively is set to a value slightly larger than the
9143 window height. Clean up the case of PT below the margin at bottom
9144 of window: scroll_max can no longer be INT_MAX. When aggressive
9145 scrolling is in use, don't let point enter the opposite scroll
9146 margin as result of the scroll.
9147 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9148 threshold of 100 lines for never-recentering scrolling.
9149
e4cc2dfc
JB
91502011-03-31 Juanma Barranquero <lekktu@gmail.com>
9151
9152 * dispextern.h (move_it_by_lines):
9153 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9154 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9155 (message_log_check_duplicate): Remove parameters `prev_bol' and
9156 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9157 (redisplay_internal): Remove parameter `preserve_echo_area',
9158 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9159
9160 * indent.c (Fvertical_motion):
9161 * window.c (window_scroll_pixel_based, Frecenter):
9162 Don't pass `need_y_p' to `move_it_by_lines'.
9163
1c470562
SM
91642011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9165
44f230aa
SM
9166 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9167 steal a few bits to be more compact.
9168 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9169 Remove unneeded casts.
9170
1c470562
SM
9171 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9172
888adce9
ZK
91732011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9174
9175 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9176 binding" message (bug#7967).
9177
f838ed7b
PE
91782011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9179
77861b95
PE
9180 Fix more problems found by GCC 4.6.0's static checks.
9181
de6dbc14
PE
9182 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9183 Remove unused local var.
9184
f838ed7b
PE
9185 * editfns.c (Fmessage_box): Remove unused local var.
9186
792c7b2b
PE
9187 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9188 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9189 Omit unused local vars.
c499e557 9190 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9191 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9192 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9193 Omit unused local var.
9194
ba0165e1
PE
9195 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9196 Don't assume string length fits in int.
32ad8845 9197 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9198 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9199
3c59b4c9
PE
9200 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9201 instead of alloca (Bug#8344).
9202
a3eed478 9203 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9204 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9205
eb4d412d
PE
9206 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9207
1658b401
PE
9208 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9209 concerns.
9210
9211 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9212
9213 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9214
9a2c6e05
PE
9215 * keyboard.c (syms_of_keyboard): Use the same style as later
9216 in this function when indexing through an array. This also
9217 works around GCC bug 48267.
9218
03d0a109
PE
9219 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9220
44f730c8
PE
9221 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9222
fe75f926
PE
9223 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9224 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9225
ffa8c828
PE
9226 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9227 This avoids undefined behavior on integer overflow, and is a bit
9228 more convenient anyway since it is compared to a size_t variable.
9229
c5101a77
PE
9230 Variadic C functions now count arguments with size_t, not int.
9231 This avoids an unnecessary limitation on 64-bit machines, which
9232 caused (substring ...) to crash on large vectors (Bug#8344).
9233 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9234 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9235 All variadic functions and their callers changed accordingly.
c5101a77
PE
9236 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9237 * data.c (arith_driver, float_arith_driver): Likewise.
9238 * editfns.c (general_insert_function): Likewise.
9239 * eval.c (struct backtrace.nargs, interactive_p)
9240 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9241 (funcall_lambda, mark_backtrace): Likewise.
9242 * fns.c (concat): Likewise.
9243 * frame.c (x_set_frame_parameters): Likewise.
9244 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9245 0 if not found, not -1. All callers changed.
9246
dd3f25f7
PE
9247 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9248 (stack_copy_size): Now size_t, not int.
9249 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9250
461c2ab9
JB
92512011-03-28 Juanma Barranquero <lekktu@gmail.com>
9252
9253 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9254 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9255 All callers changed.
9256
9257 * lisp.h (multibyte_char_to_unibyte):
9258 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9259 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9260 * character.h (CHAR_TO_BYTE8):
9261 * cmds.c (internal_self_insert):
9262 * editfns.c (general_insert_function):
9263 * keymap.c (push_key_description):
9264 * search.c (Freplace_match):
9265 * xdisp.c (message_dolog, set_message_1): All callers changed.
9266
f6d62986
SM
92672011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9268
9269 * keyboard.c (safe_run_hook_funcall): New function.
9270 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9271 don't set the hook to nil, but remove the offending function instead.
9272 (Qcommand_hook_internal): Remove, unused.
9273 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9274 Vcommand_hook_internal.
9275
9276 * eval.c (enum run_hooks_condition): Remove.
9277 (funcall_nil, funcall_not): New functions.
9278 (run_hook_with_args): Call each function through a `funcall' argument.
9279 Remove `cond' argument, now redundant.
9280 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9281 (Frun_hook_with_args_until_failure): Adjust accordingly.
9282 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9283
1db5b1ad
JB
92842011-03-28 Juanma Barranquero <lekktu@gmail.com>
9285
9286 * dispextern.h (string_buffer_position): Remove declaration.
9287
9288 * print.c (strout): Remove parameter `multibyte', unused since
9289 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9290
9291 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9292 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9293 All callers changed.
9294
9295 * w32.c (_wsa_errlist): Use braces for struct initializers.
9296
9297 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9298 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9299 All callers changed.
9300 (string_buffer_position): Likewise. Also, make static (it's never
9301 used outside xdisp.c).
9302 (cursor_row_p): Remove parameter `w', unused since
9303 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9304 (decode_mode_spec): Remove parameter `precision', introduced during
9305 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9306 All callers changed.
9307
5ffb62aa
JD
93082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9309
9310 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9311
461c2ab9 93122011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9313
9314 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9315 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9316 (ns_update_auto_hide_menu_bar): New functions.
9317 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9318 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9319 ns_constrain_all_frames.
9320 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9321 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9322
5c380ffb
JD
93232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9324
9325 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9326
9af30bdf
GM
93272011-03-27 Glenn Morris <rgm@gnu.org>
9328
9329 * syssignal.h: Replace RETSIGTYPE with void.
9330 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9331 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9332 Replace SIGTYPE with void everywhere.
9333 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9334 * s/template.h (SIGTYPE): Remove commented out definition.
9335
e2abce01
JB
93362011-03-26 Eli Zaretskii <eliz@gnu.org>
9337
9338 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9339 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9340
f868cd8a
JB
93412011-03-26 Juanma Barranquero <lekktu@gmail.com>
9342
59eb0929
JB
9343 * w32.c (read_unc_volume): Use parameter `henum', instead of
9344 global variable `wget_enum_handle'.
9345
9346 * keymap.c (describe_vector): Remove parameters `indices' and
9347 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9348 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9349
f868cd8a
JB
9350 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9351
9352 * keyboard.c (timer_check): Remove parameter `do_it_now',
9353 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9354 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9355 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9356
9357 * keyboard.c (read_char):
9358 * w32menu.c (w32_menu_display_help):
9359 * xmenu.c (show_help_event, menu_help_callback):
9360 Adjust calls to `show_help_echo'.
9361
9362 * gtkutil.c (xg_maybe_add_timer):
9363 * keyboard.c (readable_events):
9364 * process.c (wait_reading_process_output):
9365 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9366
9367 * insdel.c (adjust_markers_gap_motion):
9368 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9369 (gap_left, gap_right): Don't call it.
9370
2ecf6fdb
CY
93712011-03-25 Chong Yidong <cyd@stupidchicken.com>
9372
9373 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9374 incurred during fontification.
9375
6b1f9ba4
JB
93762011-03-25 Juanma Barranquero <lekktu@gmail.com>
9377
9378 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9379 (DEFVAR_PER_BUFFER): Don't pass it.
9380
9381 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9382 (scrolling_window): Don't pass it.
9383
0f4a96b5
JB
93842011-03-25 Juanma Barranquero <lekktu@gmail.com>
9385
9386 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9387
9388 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9389 and `suffix'.
9390 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9391 of variables specific to SELinux and computation of `encoded_absname'.
9392
9393 * image.c (XPutPixel): Remove unused variable `height'.
9394
9395 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9396
9397 * unexw32.c (get_section_info): Remove unused variable `section'.
9398
9399 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9400 (system_process_attributes): Remove unused variable `sess'.
9401 (sys_read): Remove unused variable `err'.
9402
9403 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9404 (w32_wnd_proc): Remove unused variable `isdead'.
9405 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9406 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9407 (x_create_tip_frame): Remove unused variable `tem'.
9408
9409 * w32inevt.c (w32_console_read_socket):
9410 Remove unused variable `no_events'.
9411
9412 * w32term.c (x_draw_composite_glyph_string_foreground):
9413 Remove unused variable `width'.
9414
1149507c
JB
94152011-03-24 Juanma Barranquero <lekktu@gmail.com>
9416
9417 * w32term.c (x_set_glyph_string_clipping):
9418 Don't pass uninitialized region to CombineRgn.
9419
9c88f339
JB
94202011-03-23 Juanma Barranquero <lekktu@gmail.com>
9421
9422 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9423 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9424 (Fx_close_connection): Remove unused variable `i'.
9425
9426 * w32font.c (w32font_draw): Return number of glyphs.
9427 (w32font_open_internal): Remove unused variable `i'.
9428 (w32font_driver): Add missing initializer.
9429
9430 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9431 (fill_in_menu): Remove unused variable `items_added'.
9432
9433 * w32term.c (last_mouse_press_frame): Remove static global variable.
9434 (w32_clip_to_row): Remove unused variable `f'.
9435 (x_delete_terminal): Remove unused variable `i'.
9436
9437 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9438 (NOTHING): Remove unused static global variable.
9439 (uniscribe_check_otf): Remove unused variable `table'.
9440 (uniscribe_font_driver): Add missing initializers.
9441
dee091a3
JD
94422011-03-23 Julien Danjou <julien@danjou.info>
9443
9444 * term.c (Fsuspend_tty, Fresume_tty):
9445 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9446 * window.c (temp_output_buffer_show):
9447 * insdel.c (signal_before_change):
9448 * frame.c (Fhandle_switch_frame):
9449 * fileio.c (Fdo_auto_save):
9450 * emacs.c (Fkill_emacs):
9451 * editfns.c (save_excursion_restore):
9452 * cmds.c (internal_self_insert):
9453 * callint.c (Fcall_interactively):
9454 * buffer.c (Fkill_all_local_variables):
9455 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9456 Use Frun_hooks.
0f4a96b5 9457 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9458 unconditionally since it does the check itself.
dee091a3 9459
2c520ab5 94602011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9461
c9c49752
PE
9462 Fix more problems found by GCC 4.5.2's static checks.
9463
8abc3f12
PE
9464 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9465 the first time through the loop, since we know p0 < p1 then.
9466 This also avoids a gcc -Wstrict-overflow warning.
9467
a2d26660
PE
9468 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9469 leading to a memory leak, possible in functions like
9470 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9471 of objects (Bug#8318).
a2d26660 9472
916c72e9
PE
9473 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9474 that could (at least in theory) be that large.
9475
19ab8a18
PE
9476 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9477 This is less likely to overflow, and avoids undefined behavior if
9478 overflow does occur. All callers changed. Use strtoul to scan
9479 for the unsigned long integer.
b7cbbd6f
PE
9480 (pint2hrstr): Simplify and tune code slightly.
9481 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9482
f0641eff
PE
9483 * scroll.c (do_scrolling): Work around GCC bug 48228.
9484 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9485
7f650bb9
PE
9486 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9487 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9488 (validate_x_resource_name): Simplify count usage.
9489 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9490
37dd57d1
PE
9491 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9492 fail (Bug#8306).
81e56e61 9493
699979fc 9494 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9495
401bf9b4
PE
9496 * process.c (Fmake_network_process): Use socklen_t, not int,
9497 where POSIX says socklen_t is required in portable programs.
9498 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9499 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9500 (Fmake_network_process, server_accept_connection):
9501 (wait_reading_process_output, read_process_output):
9502 Likewise.
9503
b93aacde
PE
9504 * process.c: Rename or move locals to avoid shadowing.
9505 (list_processes_1, Fmake_network_process):
9506 (read_process_output_error_handler, exec_sentinel_error_handler):
9507 Rename or move locals.
4dc343ee 9508 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9509 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9510 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9511 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9512 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9513
af8a867c 9514 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9515 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9516 Include tparam.h instead, since it declares them.
af8a867c
PE
9517 * cm.h (PC): Remove extern decl; tparam.h now does this.
9518 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9519 * terminfo.c: Include tparam.h, to check interfaces.
9520 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9521 (tparam): Adjust signature to match interface in tparam.h;
9522 this removes some undefined behavior. Check that outstring and len
9523 are zero, which they always are with Emacs.
9524 * tparam.h (PC, BC, UP): New extern decls.
9525
0248044d 9526 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9527 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9528
8ff096c1 9529 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9530 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9531 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9532 (ftfont_list): Remove unused local.
49eaafba
PE
9533 (get_adstyle_property, ftfont_pattern_entity):
9534 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9535 Rename locals to avoid shadowing.
8ff096c1 9536
e2be39f6
PE
9537 * xfont.c (xfont_list_family): Mark var as initialized.
9538
c9735e30
PE
9539 * xml.c (make_dom): Now static.
9540
8f5201ae
PE
9541 * composite.c (composition_compute_stop_pos): Rename local to
9542 avoid shadowing.
b246f932
PE
9543 (composition_reseat_it): Remove unused locals.
9544 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9545 (composition_update_it): Mark var as initialized.
11b61122
PE
9546 (find_automatic_composition): Mark vars as initialized,
9547 with a FIXME (Bug#8290).
8f5201ae 9548
760fbc2c
PE
9549 character.h: Rename locals to avoid shadowing.
9550 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9551 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9552 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9553 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9554 to avoid shadowing.
9555
ff08eb85
PE
9556 * textprop.c (property_change_between_p): Remove; unused.
9557
fc7bf025
PE
9558 * intervals.c (interval_start_pos): Now static.
9559
235d7abc
PE
9560 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9561
44f230aa
SM
9562 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9563 Rename locals to avoid shadowing.
3e7d6594 9564
50060332
PE
9565 * sound.c (wav_play, au_play, Fplay_sound_internal):
9566 Fix pointer signedness.
d01f234b 9567 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9568 (wav_play): Initialize a variable to 0, to prevent undefined
9569 behavior (Bug#8278).
50060332 9570
c4fc4e30
PE
9571 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9572
918436ed
PE
9573 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9574
c939f91b
PE
9575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9576 clobbering (Bug#8298).
b9c7f648
PE
9577 * sysdep.c (sys_subshell): Likewise.
9578 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9579
6bd8c144
PE
9580 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9581 This should get cleaned up, so that child_setup has the
9582 same signature on all platforms.
9583
7710357c 9584 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9585 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9586
c59da222
CY
95872011-03-22 Chong Yidong <cyd@stupidchicken.com>
9588
9589 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9590 not to be necessary, and produces flickering.
9591
66b87493
GM
95922011-03-20 Glenn Morris <rgm@gnu.org>
9593
9594 * config.in: Remove file.
9595
45b6f6d5
JB
95962011-03-20 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9599 are now in src/globals.h.
9600 (syms_of_minibuf): Remove spurious & from previous change.
9601
cd394be1 96022011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9603
9604 * minibuf.c (completing-read-function): New variable.
9605 (completing-read-default): Rename from completing-read.
9606 (completing-read): Call completing-read-function.
9607
b14e3e21
CY
96082011-03-19 Juanma Barranquero <lekktu@gmail.com>
9609
9610 * xfaces.c (Fx_load_color_file):
9611 Read color file from absolute filename (bug#8250).
9612
f2b726e6
JB
96132011-03-19 Juanma Barranquero <lekktu@gmail.com>
9614
9615 * makefile.w32-in: Update dependencies.
9616
09f6ff02
EZ
96172011-03-17 Eli Zaretskii <eliz@gnu.org>
9618
9619 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9620
29a6015a
PE
96212011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9622
a3a6c54e
PE
9623 Fix more problems found by GCC 4.5.2's static checks.
9624
b766f867
PE
9625 * process.c (make_serial_process_unwind, send_process_trap):
9626 (sigchld_handler): Now static.
9627
be02381c
PE
9628 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9629 That way, the code declares only the vars that it needs.
9630 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9631 * s/cygwin.h (PTY_ITERATION): Likewise.
9632 * s/darwin.h (PTY_ITERATION): Likewise.
9633 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9634
57048744
PE
9635 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9636 * process.c (allocate_pty): Don't declare stb unless it's needed.
9637
7914961c 9638 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9639 (CONSTANTLIM): Remove; unused.
9640 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9641 Define only if needed.
7914961c 9642
b3967b18
PE
9643 * unexelf.c (unexec): Name an expression,
9644 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9645 Use a different way to cause a compilation error if anyone uses
9646 n rather than nn, a way that does not involve shadowing.
73366a00 9647 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9648
29a6015a
PE
9649 * deps.mk (unexalpha.o): Remove; unused.
9650
43cfc33e 9651 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9652 * unexec.h: New file.
ce701a33
PE
9653 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9654 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9655 Depend on unexec.h.
9656 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9657 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9658 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9659 Change as necessary to match prototype in unexec.h.
ce701a33 9660
01f44d5a
PE
9661 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9662 shadowing.
4f63c6bb 9663 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9664
a6670b0b
PE
9665 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9666 Rename locals to avoid shadowing.
9667
cef2010d 9668 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9669 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9670
d4d7173a
PE
9671 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9672
f08b802a
PE
9673 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9674 warning when compiling print.c.
9675
3ddb0639
PE
9676 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9677 instead of using an uninitialized var.
5ad03b97 9678 (font_sort_entities): Mark var as initialized.
3ddb0639 9679
170a2692
PE
9680 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9681
e663c700
PE
9682 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9683 pointers to constants.
89bc529a 9684 (font_parse_fcname): Remove unused vars.
7b81e2d0 9685 (font_delete_unmatched): Now static.
ea838e10 9686 (font_get_spec): Remove; unused.
13a547c6
PE
9687 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9688 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9689 Rename or move locals to avoid shadowing.
e663c700 9690
2a80c887 9691 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9692 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9693
1384fa33 9694 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9695 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9696
8b2c52e9
PE
9697 * alloc.c (mark_backtrace): Move decl from here ...
9698 * lisp.h: ... to here, so that it can be checked.
9699
475545b5 9700 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9701 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9702 (lisp_indirect_variable): Name an expression,
9703 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9704 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9705
b1349114 9706 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9707 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9708 Use const pointer when appropriate.
b1349114 9709
a2928364
PE
9710 * lisp.h (get_system_name, get_operating_system_release):
9711 Move decls here, to check interfaces.
9712 * process.c (get_operating_system_release): Move decl to lisp.h.
9713 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9714 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9715 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9716 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9717 (Fformat_time_string, Fencode_time, Finsert_char):
9718 (Ftranslate_region_internal, Fformat):
9719 Rename or remove local vars to avoid shadowing.
9710023e 9720 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9721
a415e694
PE
9722 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9723 avoid shadowing.
9724
8ef4622d
PE
9725 * lisp.h (eassert): Check that the argument compiles, even if
9726 ENABLE_CHECKING is not defined.
9727
946f9a5b
PE
9728 * data.c (Findirect_variable): Name an expression, to avoid
9729 gcc -Wbad-function-cast warning.
112396d6 9730 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9731 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9732 (Fmake_variable_buffer_local, Fmake_local_variable):
9733 Mark variables as initialized.
52746918 9734 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9735
e5aab7e7 9736 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9737 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9738 Rename locals to avoid shadowing.
dff45157
PE
9739 (mark_stack): Move local variables into the #ifdef region where
9740 they're used.
7bc26fdb
PE
9741 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9742 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9743 needed otherwise.
9744 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9745 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9746 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9747
e5aab7e7
PE
9748 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9749 avoids undefined behavior in theory.
9750
4da60324
PE
9751 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9752
88043301
PE
9753 Use functions, not macros, for up- and down-casing (Bug#8254).
9754 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9755 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9756 to use the following functions instead of these macros.
9757 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9758 EMACS_INT, since callers assume the returned value fits in int.
9759 (upcase1): Likewise, for UPCASE_TABLE.
9760 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9761 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9762 the race-condition problem in the old DOWNCASE.
88043301 9763
19ed5445
PE
9764 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9765 Rename locals to avoid shadowing.
9766 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9767 (regex_compile, re_search_2, re_match_2_internal):
9768 Remove unused local vars.
952db0d7
PE
9769 (FREE_VAR): Rewrite so as not to use empty "else",
9770 which gcc can warn about.
da053e48 9771 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9772 (RETALLOC_IF): Define only if needed.
9773 (WORDCHAR_P): Likewise. This one is never needed, but is used
9774 only in a comment talking about a compiler bug, so put inside
9775 the #if 0 of that comment.
9776 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9777 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9778 Remove; unused.
19ed5445 9779
1f3561e4 9780 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9781 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9782 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9783
ded6f8f7
PE
9784 * search.c (simple_search): Remove unused var.
9785
dbd37a95
PE
9786 * dired.c (compile_pattern): Move decl from here ...
9787 * lisp.h: ... to here, so that it can be checked.
9788 (struct re_registers): New forward decl.
9789
7e47afad
PE
9790 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9791
85f24f61
PE
9792 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9793 All uses changed.
9794 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9795 Rename locals to avoid shadowing.
5671df8f 9796 (Fvertical_motion): Mark locals as initialized.
85f24f61 9797
181aa2be 9798 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9799 (casify_region): Mark local as initialized.
181aa2be 9800
930d429c
PE
9801 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9802
7082eac6
PE
9803 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9804 New macros, so that the caller can use some names other than
9805 gcpro1, gcpro2, etc.
9806 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9807 of the new macros.
9808 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9809 argument, for consistency with GCPRO2_VAR, etc: it is now the
9810 prefix of the variable, not the variable itself. All uses
9811 changed.
38b2c076
PE
9812 * dired.c (directory_files_internal, file_name_completion):
9813 Rename locals to avoid shadowing.
9814
15206ed9
PE
9815 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9816 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9817 dired.c's scmp function, had undefined behavior.
9818 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9819 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9820 * buffer.h: ... to here, because these macros use current_buffer,
9821 and the new implementation with inline functions needs to have
9822 current_buffer in scope now, rather than later when the macros
9823 are used.
9824 (downcase, upcase1): New static inline functions.
9825 (DOWNCASE, UPCASE1): Reimplement using these functions.
9826 This avoids undefined behavior in expressions like
9827 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9828 from race conditions in accessing the global variables
9829 case_temp1 and case_temp2.
9830 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9831 * lisp.h (case_temp1, case_temp2): Remove their decls.
9832 * character.h (ASCII_CHAR_P): Move from here ...
9833 * lisp.h: ... to here, so that the inline functions mentioned
9834 above can use them.
9835
4a6bea26
PE
9836 * dired.c (directory_files_internal_unwind): Now static.
9837
f14b7e14
PE
9838 * fileio.c (file_name_as_directory, directory_file_name):
9839 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9840 Now static.
2893f146
PE
9841 (file_name_as_directory): Use const pointers when appropriate.
9842 (Fexpand_file_name): Likewise. In particular, newdir might
9843 point at constant storage, so make it a const pointer.
fd4ead52 9844 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9845 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9846 signedness issues.
f839df0c
PE
9847 (Fset_file_times, Finsert_file_contents, auto_save_error):
9848 Rename locals to avoid shadowing.
f14b7e14 9849
5716756e 9850 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9851 (Ftry_completion, Fall_completions): Rename or remove locals
9852 to avoid shadowing.
5716756e 9853
b4c3046a
PE
9854 * marker.c (bytepos_to_charpos): Remove; unused.
9855
b45db522
PE
9856 * lisp.h (verify_bytepos, count_markers): New decls,
9857 so that gcc does not warn that these functions aren't declared.
9858
85876d07
PE
9859 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9860 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9861 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9862 (copy_text): Remove unused local var.
85876d07 9863
03d78a21 9864 * filelock.c (within_one_second): Now static.
b3dd38ab 9865 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9866
5df8f01b
PE
9867 * buffer.c (fix_overlays_before): Mark locals as initialized.
9868 (fix_start_end_in_overlays): Likewise. This function should be
9869 simplified by using pointers-to-pointers, but that's a different
9870 matter.
b1d876f1 9871 (switch_to_buffer_1): Now static.
8f54f30a
PE
9872 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9873 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9874
a70072c9 9875 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9876 Fix pointer signedness issue.
edced198
PE
9877 (sys_subshell): Mark local as volatile if checking for lint,
9878 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9879 (MAXPATHLEN): Define only if needed.
a70072c9 9880
a0977c44
PE
9881 * process.c (serial_open, serial_configure): Move decls from here ...
9882 * systty.h: ... to here, so that they can be checked.
9883
a884fdcc
PE
9884 * fns.c (get_random, seed_random): Move extern decls from here ...
9885 * lisp.h: ... to here, so that they can be checked.
9886
604efe86 9887 * sysdep.c (reset_io): Now static.
b8950c94 9888 (wait_for_termination_signal): Remove; unused.
604efe86 9889
38fc62d9
PE
9890 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9891 (copy_keymap_item, append_key, push_text_char_description):
9892 Now static.
1004a21a 9893 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9894 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9895 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9896 (describe_map_tree):
9897 Rename locals to avoid shadowing.
38fc62d9 9898
2f2650da
PE
9899 * keyboard.c: Declare functions static if they are not used elsewhere.
9900 (echo_char, echo_dash, cmd_error, top_level_2):
9901 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9902 (read_char, kbd_buffer_get_event, make_lispy_position):
9903 (make_lispy_event, make_lispy_movement, apply_modifiers):
9904 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9905 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9906 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9907 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9908 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9909
a053e86c 9910 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9911 (mark_kboards): Move decl here ...
9912 * alloc.c (mark_kboards): ... from here.
a053e86c 9913
4752793e
PE
9914 * lisp.h (force_auto_save_soon): New decl.
9915
74f10ca7 9916 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9917 (DEFINE_DUMMY_FUNCTION): New macro.
9918 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9919 Use it.
c03cd23f
PE
9920 (main): Add casts to avoid warnings
9921 if GCC considers string literals to be constants.
74f10ca7 9922
022e70d4
PE
9923 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9924
59d6fe83
PE
9925 * dbusbind.c: Pointer signedness fixes.
9926 (xd_signature, xd_append_arg, xd_initialize):
9927 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9928 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9929 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9930 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9931
78320123
PE
9932 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9933 if GCC considers string literals to be constants.
49cebcca 9934 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9935
35ac2a97
SM
99362011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9937
fb103ca9
SM
9938 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9939 (print_preprocess, print_object): New macro to fix last change.
9940
35ac2a97
SM
9941 * print.c (print_preprocess): Don't forget font objects.
9942
62973b41
JB
99432011-03-16 Juanma Barranquero <lekktu@gmail.com>
9944
9945 * emacs.c (USAGE3): Doc fixes.
9946
0e48bb22
AS
99472011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9948
9949 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9950 structure.
9951
7684e57b
JB
99522011-03-14 Juanma Barranquero <lekktu@gmail.com>
9953
9954 * lisp.h (VWindow_system, Qfile_name_history):
9955 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9956 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9957 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9958
9959 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9960 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9961
9962 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9963 * w32console.c (detect_input_pending, read_input_pending)
9964 (encode_terminal_code):
9965 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9966 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9967 (w32_system_caret_y, Qfile_name_history):
9968 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9969 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9970 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9971 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9972 * w32proc.c (Qlocal, report_file_error):
9973 * w32term.c (Vwindow_system, updating_frame):
9974 * w32uniscribe.c (initialized, uniscribe_font_driver):
9975 Remove unneeded extern declarations.
9976
2aa46d6c
CY
99772011-03-14 Chong Yidong <cyd@stupidchicken.com>
9978
c96bbc66 9979 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9980
cffc6f3b
CY
99812011-03-13 Chong Yidong <cyd@stupidchicken.com>
9982
9983 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9984 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9985 These macros can no longer be used for assignment.
9986
44f230aa
SM
9987 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9988 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9989 (record_buffer_markers, fetch_buffer_markers): New functions for
9990 recording and fetching special buffer markers.
9991 (set_buffer_internal_1, set_buffer_temp): Use them.
9992
9993 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9994
9995 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9996
9997 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9998 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9999
10000 * xdisp.c (hscroll_window_tree):
10001 (reconsider_clip_changes): Use PT instead of BUF_PT.
10002
d251f04b
EZ
100032011-03-13 Eli Zaretskii <eliz@gnu.org>
10004
10005 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10006 $(EMACS_ROOT)/lib/intprops.h.
10007
f0c77cd1
PE
100082011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10009
3eca4629
PE
10010 Fix more problems found by GCC 4.5.2's static checks.
10011
7c86ee98
PE
10012 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10013 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10014 (xg_free_frame_widgets): Make it clear that a local variable is
10015 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10016 (gdk_window_get_screen): Make it clear that this macro is needed
10017 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10018 (int_gtk_range_get_value): New function, which avoids a diagnostic
10019 from gcc -Wbad-function-cast.
10020 (xg_set_toolkit_scroll_bar_thumb): Use it.
10021 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10022 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10023 (get_utf8_string, xg_get_file_with_chooser):
10024 Rename locals to avoid shadowing.
10025 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10026
41729b81
PE
10027 * xgselect.c (xg_select): Remove unused var.
10028
f0c77cd1
PE
10029 * image.c (four_corners_best): Mark locals as initialized.
10030 (gif_load): Initialize transparent_p to zero (Bug#8238).
10031 Mark another local as initialized.
ec6cf4c6 10032 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10033
ce0ad53d 10034 * image.c (clear_image_cache): Now static.
d5d5a617 10035 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10036 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10037 (x_edge_detection): Remove unnecessary cast that
10038 gcc -Wbad-function-cast diagnoses.
2037898d 10039 (gif_load): Fix pointer signedness.
6ae141d6
PE
10040 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10041 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10042
33383987 100432011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10044
d32df629
PE
10045 Improve quality of tests for time stamp overflow.
10046 For example, without this patch (encode-time 0 0 0 1 1
10047 1152921504606846976) returns the obviously-bogus value (-948597
10048 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10049 reports time overflow. See
10050 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10051 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10052 * editfns.c: Include limits.h and intprops.h.
10053 (TIME_T_MIN, TIME_T_MAX): New macros.
10054 (time_overflow): Move earlier, to before first use.
10055 (hi_time, lo_time): New functions, for an accurate test for
10056 out-of-range times.
10057 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10058 (Fget_internal_run_time): Don't assume time_t fits in int.
10059 (make_time): Use list2 instead of Fcons twice.
10060 (Fdecode_time): More accurate test for out-of-range times.
10061 (check_tm_member): New function.
10062 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10063 (lisp_time_argument): Don't rely on undefined left-shift and
10064 right-shift behavior when checking for time stamp overflow.
8be6f318 10065
fe31d94c
PE
10066 * editfns.c (time_overflow): New function, refactoring common code.
10067 (Fformat_time_string, Fdecode_time, Fencode_time):
10068 (Fcurrent_time_string): Use it.
10069
8be6f318
PE
10070 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10071 * dired.c (make_time): Move to ...
10072 * editfns.c (make_time): ... here.
10073 * systime.h: Note the move.
10074
09d9db2c 100752011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10076
126bc0dc
YM
10077 * fringe.c (update_window_fringes): Remove unused variables.
10078
c47cbdfd
YM
10079 * unexmacosx.c (copy_data_segment): Also copy __got section.
10080 (Bug#8223)
10081
7ac80be9
EZ
100822011-03-12 Eli Zaretskii <eliz@gnu.org>
10083
c96bbc66 10084 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10085 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10086 Constify `char *' arguments and their references according to
10087 prototypes in tparam.h.
10088
ecb0f94d 10089 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10090
7ac80be9
EZ
10091 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10092 Adapt all references accordingly.
10093
10094 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10095
ef1fd07e
TT
100962011-03-11 Tom Tromey <tromey@redhat.com>
10097
10098 * buffer.c (syms_of_buffer): Remove obsolete comment.
10099
7ef4b50c
EZ
101002011-03-11 Eli Zaretskii <eliz@gnu.org>
10101
10102 * termhooks.h (encode_terminal_code): Declare prototype.
10103
10104 * msdos.c (encode_terminal_code): Don't declare prototype.
10105
10106 * term.c (encode_terminal_code): Now external again, used by
10107 w32console.c and msdos.c.
10108
44f230aa
SM
10109 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10110 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10111
4b1ec863 101122011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10113
1714f52b 10114 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10115
4b1ec863
PE
10116 * fringe.c (update_window_fringes): Mark locals as initialized
10117 (Bug#8227).
10118 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10119
524c7aa6
PE
10120 * alloc.c (mark_fringe_data): Move decl from here ...
10121 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10122 to check its interface.
10123 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10124
a5c0af81 10125 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10126 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10127 (fontset_font): Mark local as initialized.
a9a06e0b 10128 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10129
b4716021
PE
10130 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10131
811e9bac 10132 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10133 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10134 (x_own_selection, Fx_disown_selection_internal): Rename locals
10135 to avoid shadowing.
10136 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10137
7e3ab302
PE
10138 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10139 so that the caller can use some name other than gcpro1.
10140 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10141 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10142 (Fx_backspace_delete_keys_p):
10143 Use them to avoid shadowing, and rename vars to avoid shadowing.
10144 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10145 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10146 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10147 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10148 Remove unused locals.
7e3ab302
PE
10149 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10150 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10151 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10152 macros.
f78faa98 10153
e2b13473
PE
10154 * xterm.h (x_mouse_leave): New decl.
10155
77f23912
PE
10156 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10157 Remove unused functions.
cdf4ba58
PE
10158 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10159 (x_calc_absolute_position): Now static.
7411c686 10160 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10161 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10162 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10163 unless they are used.
38d0b34a
PE
10164 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10165 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10166 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10167 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10168 (x_error_catcher, x_connection_closed, x_error_handler):
10169 (x_error_quitter, xembed_send_message, x_iconify_frame):
10170 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10171 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10172 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10173
44f230aa
SM
10174 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10175 Rename or move locals to avoid shadowing.
6b463e58 10176 (tty_defined_color, merge_face_heights): Now static.
5967d051 10177 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10178 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10179 does not deduce is never used uninitialized.
73719eba
PE
10180 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10181 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10182
426994c3 10183 * terminal.c (store_terminal_param): Now static.
5489860b 10184
032f1620 10185 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10186 (set_frame_menubar): Remove unused local.
d4323972 10187 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10188 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10189 since they might point to immutable storage.
281585b0
PE
10190 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10191 since it's unused otherwise.
032f1620 10192
367c19e5 10193 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10194 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10195 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10196 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10197 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10198 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10199 does not deduce are never used uninitialized.
70739cbe 10200
07b48fa9
PE
10201 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10202
8868a238 10203 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10204 * window.c (window_loop, size_window):
10205 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10206
7e5cf297 10207 * window.c (display_buffer): Now static.
d6550a9f
PE
10208 (size_window): Mark variables that gcc -Wuninitialized
10209 does not deduce are never used uninitialized.
a586633d
PE
10210 * window.h (check_all_windows): New decl, to forestall
10211 gcc -Wmissing-prototypes diagnostic.
5b555da1 10212 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10213
f6095868
PE
10214 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10215 shadowing.
10216 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10217 Include <limits.h>.
10218 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10219 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10220 (load_charset_map): Mark variables that gcc -Wuninitialized
10221 does not deduce are never used uninitialized.
53df7c11 10222 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10223
f38b440c
PE
10224 * coding.c (coding_set_source, coding_set_destination):
10225 Use "else { /* comment */ }" rather than "else /* comment */;"
10226 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10227 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10228 a block, when the outer 'i' will do.
10229 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10230 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10231 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10232 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10233 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10234 Rename locals to avoid shadowing.
10235 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10236 * coding.c (emacs_mule_char, encode_invocation_designation):
10237 Now static, since they're not used elsewhere.
413bb2db 10238 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10239 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10240 (decode_coding_emacs_mule): Mark variables that gcc
10241 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10242 (detect_coding_iso_2022): Initialize a local variable that might
10243 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10244 this initialization is needed. (Bug#8211)
5f58e762
PE
10245 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10246 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10247 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10248 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10249 Remove unused macros.
f38b440c 10250
232b38b9 10251 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10252 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10253 * character.c (string_count_byte8): Likewise.
232b38b9 10254
fb90da1b
PE
10255 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10256 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10257
fb93dbc2
PE
10258 * chartab.c (copy_sub_char_table): Now static, since it's not used
10259 elsewhere.
5c156ace
PE
10260 (sub_char_table_ref_and_range, char_table_ref_and_range):
10261 Rename locals to avoid shadowing.
bbcd0949 10262 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10263
7d3b3862 10264 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10265 (BIDI_BOB): Remove unused macro.
7d3b3862 10266
6be7d3da
PE
10267 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10268 deduce are never used uninitialized.
c2ed9c8b 10269 * term.c (encode_terminal_code): Likewise.
6be7d3da 10270
75f8807f 10271 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10272
50938595
PE
10273 * tparam.h: New file.
10274 * term.c, tparam.h: Include it.
10275 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10276 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10277 Move these decls to tparam.h, and make them agree with what
10278 is actually in tparam.c. The previous trick of using incompatible
10279 decls in different modules does not conform to the C standard.
10280 All callers of tparam changed to use tparam's actual API.
10281 * tparam.c (tparam1, tparam, tgoto):
10282 Use const pointers where appropriate.
10283
fbceeba2
PE
10284 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10285 * cm.h (struct cm): Likewise.
10286 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10287 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10288 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10289 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10290 (turn_on_face, init_tty): Likewise.
10291 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10292
7f3f1250
PE
10293 * term.c (term_mouse_position): Rename local to avoid shadowing.
10294
e6ca6543
PE
10295 * alloc.c (mark_ttys): Move decl from here ...
10296 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10297
c40f8d15
AS
102982011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10299
10300 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10301
cfe0661d
JB
103022011-03-09 Juanma Barranquero <lekktu@gmail.com>
10303
10304 * search.c (compile_pattern_1): Remove argument regp, unused since
10305 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10306 (compile_pattern): Don't pass it.
10307
0afb4571
J
103082011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10309
10310 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10311 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10312 for ! HAVE_GTK3.
10313 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10314
10315 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10316
10317 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10318 gdk_window_get_screen, gdk_window_get_geometry,
10319 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10320 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10321 (xg_get_pixbuf_from_pixmap): New function.
10322 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10323 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10324 Call xg_get_pixbuf_from_pixmap instead of
10325 gdk_pixbuf_get_from_drawable.
10326 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10327 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10328 (xg_check_special_colors): Use GtkStyleContext and its functions
10329 for HAVE_GTK3.
10330 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10331 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10332 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10333 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10334 Call gtk_widget_get_preferred_size.
0afb4571
J
10335 (xg_frame_resized): gdk_window_get_geometry only takes 5
10336 parameters.
44f230aa
SM
10337 (xg_win_to_widget, xg_event_is_for_menubar):
10338 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10339 (xg_set_widget_bg): New function.
10340 (delete_cb): New function.
895009e1 10341 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10342 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10343 (xg_set_background_color): Call xg_set_widget_bg.
10344 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10345 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10346 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10347 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10348 if ! HAVE_GTK3.
10349 (update_frame_tool_bar): Call gtk_widget_hide.
10350 (xg_initialize): Use GDK_KEY_g.
10351
10352 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10353 if ! HAVE_GTK3
10354 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10355
10356 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10357 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10358 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10359
1c2cc4ef
JB
103602011-03-08 Juanma Barranquero <lekktu@gmail.com>
10361
10362 * w32xfns.c (select_palette): Check success of RealizePalette against
10363 GDI_ERROR, not zero.
10364
33383987 10365See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10366
10367;; Local Variables:
10368;; coding: utf-8
aac0c6e3
MR
10369;; End:
10370
2f097256 10371 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10372
10373 This file is part of GNU Emacs.
10374
10375 GNU Emacs is free software: you can redistribute it and/or modify
10376 it under the terms of the GNU General Public License as published by
10377 the Free Software Foundation, either version 3 of the License, or
10378 (at your option) any later version.
10379
10380 GNU Emacs is distributed in the hope that it will be useful,
10381 but WITHOUT ANY WARRANTY; without even the implied warranty of
10382 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10383 GNU General Public License for more details.
10384
10385 You should have received a copy of the GNU General Public License
10386 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.