* lisp/net/rcirc.el (rcirc-split-message): New function.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
170aedb9
CY
12012-08-13 Eli Zaretskii <eliz@gnu.org>
2
3 * window.c (Fdelete_other_windows_internal)
4 (Fdelete_window_internal): Don't access frame's mouse highlight
5 info of the initial frame. (Bug#11677)
6
c17d5a38
JD
72012-08-12 Jan Djärv <jan.h.d@swipnet.se>
8
9 * nsterm.m (ns_read_socket): Return early if there is a modal
10 window (Bug#12043).
11
12 * nsmenu.m (Popdown_data): New struct.
13 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
14 free Popdown_data.
15 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
16 (initWithContentRect): Make imgView and contentView non-static
17 and autorelease them. Also autorelease img and matrix (Bug#12005).
18 (dealloc): Remove (Bug#12005).
19
20 * nsterm.m (keyDown:): Interpret flags without left/right bits
21 as the left key (Bug#11670).
22
23 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
24
8ccd072a
YM
252012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
26
27 * unexmacosx.c (copy_data_segment): Copy initialized data in
28 statically linked libraries from input file rather than memory.
29
db74a5fc
YM
302012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
31
32 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
33 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
34 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
35
23dc7744
CY
362012-07-19 Chong Yidong <cyd@gnu.org>
37
38 * window.c (Fwindow_absolute_pixel_edges)
39 (Fdelete_other_windows_internal): Signal an error if the window is
40 on a dead frame (Bug#11984).
41
fbf31a9c
EZ
422012-07-14 Eli Zaretskii <eliz@gnu.org>
43
44 Remove FILE_SYSTEM_CASE.
45 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
46
47 * fileio.c (FILE_SYSTEM_CASE): Don't define.
48 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
49 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
50 call-process-region passes it through expand-file-name.
51
52 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
53
8a05d57a
AS
542012-07-12 Andreas Schwab <schwab@linux-m68k.org>
55
56 Fix crash when creating indirect buffer (Bug#11917)
57 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
58 Don't handle unbound variables specially if non-zero.
59 (Fbuffer_local_variables): Pass zero.
60 (clone_per_buffer_values): Pass non-zero.
61
57570cd3
AS
622012-06-28 Andreas Schwab <schwab@linux-m68k.org>
63
64 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
65 to make the loop interruptible.
66
d01fd55f
AS
672012-06-26 Andreas Schwab <schwab@linux-m68k.org>
68
69 * gnutls.c (emacs_gnutls_handshake): Only retry if
70 GNUTLS_E_INTERRUPTED.
71
c81b46f6
EZ
722012-06-23 Eli Zaretskii <eliz@gnu.org>
73
74 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
75 in the logic of incrementing and decrementing the value of
76 use_relocatable_buffers.
77
63541ed8
GM
782012-06-21 Glenn Morris <rgm@gnu.org>
79
80 * charset.c (init_charset): Make lack of etc/charsets fatal.
81
50a93863
JD
822012-06-11 Jan Djärv <jan.h.d@swipnet.se>
83
84 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
85 referenced (Bug#11583).
86
94f0aa34
CY
872012-06-01 Chong Yidong <cyd@gnu.org>
88
89 * Version 24.1 released.
90
d5fd2c54
EZ
912012-05-30 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (handle_stop): Detect whether we have overlay strings
94 loaded by testing it->current.overlay_string_index to be
95 non-negative, instead of checking whether n_overlay_strings is
96 positive. (Bug#11587)
97
353c87f6
CY
982012-05-30 Chong Yidong <cyd@gnu.org>
99
100 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
101
102 * doc.c (Fsubstitute_command_keys): Doc fix.
103
a02ae4e5
EZ
1042012-05-29 Eli Zaretskii <eliz@gnu.org>
105
106 * search.c (search_buffer): Remove calls to
107 r_alloc_inhibit_buffer_relocation, as it is now called by
108 maybe_unify_char, which was the cause of relocation of buffer text
109 in bug#11519.
110
291d430f
EZ
1112012-05-23 Eli Zaretskii <eliz@gnu.org>
112
113 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
114 for the duration of call to load_charset, to avoid problems with
115 callers of maybe_unify_char that access buffer text through C
116 pointers.
117
118 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
119 decrement the inhibition flag, instead of just setting or
120 resetting it.
121
2f9b9adb
KB
1222012-05-24 Ken Brown <kbrown@cornell.edu>
123
124 * callproc.c (Fcall_process): Restore a line that was accidentally
125 commented out in the 2011-02-13 change (bug#11547).
126
52c55cc7
EZ
1272012-05-23 Eli Zaretskii <eliz@gnu.org>
128
129 * lisp.h [REL_ALLOC]: Add prototypes for external functions
130 defined on ralloc.c.
131
132 * buffer.c [REL_ALLOC]: Remove prototypes of
133 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
134 they are now on lisp.h.
135
136 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
137
138 * search.c (search_buffer): Use it to inhibit relocation of buffer
139 text while re_search_2 is doing its job, because re_search_2 is
140 passed C pointers to buffer text. (Bug#11519)
141
23415acf
EZ
1422012-05-21 Eli Zaretskii <eliz@gnu.org>
143
144 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
145 Update value to 24.
146
44e27368
EZ
1472012-05-19 Eli Zaretskii <eliz@gnu.org>
148
149 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
150 state after an additional call to move_it_in_display_line_to, keep
151 the values of it->max_ascent and it->max_descent found for the
152 entire line.
153 (pos_visible_p): Revert the comparison against bottom_y to what it
154 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
155 (Bug#11464)
156
ccbf309c
EZ
1572012-05-15 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
160
ac268e67
EZ
1612012-05-13 Eli Zaretskii <eliz@gnu.org>
162
163 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
164 already have overlays loaded.
165 (handle_single_display_spec): Before returning without displaying
166 fringe bitmap, synchronize the bidi iterator with the main display
167 iterator, by calling iterate_out_of_display_property.
168 (iterate_out_of_display_property): Detect buffer iteration by
169 testing that it->string is a Lisp string.
170 (get_next_display_element): When the current object is exhausted,
171 and there's something on it->stack, call set_iterator_to_next to
172 proceed with what's on the stack, instead of returning zero.
173 (set_iterator_to_next): If called at the end of a Lisp string,
174 proceed to consider_string_end without incrementing string
175 position. Don't increment display vector index past the end of
176 the display vector. (Bug#11417)
c8fb9dc6
EZ
177 (pos_visible_p): Don't report a position visible when move_it_to
178 stopped at the last line of window, which happens to be scanned
179 backwards by the bidi iteration. (Bug#11464)
ac268e67 180
82f9b393
EZ
1812012-05-11 Eli Zaretskii <eliz@gnu.org>
182
183 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
184 and right-margin display specs even if the spec is invalid or we
185 are on a TTY, and thus unable to display on the fringes. That's
186 because the text with the property will not be displayed anyway,
187 so we need to signal to the caller that this is a "replacing"
188 display spec. This fixes display when the spec is invalid or we
189 are on a TTY.
190
297834cd
PE
1912012-05-09 Paul Eggert <eggert@cs.ucla.edu>
192
193 * unexaix.c (make_hdr): Fix typo in prototype.
194 This bug broke the build on AIX. Problem reported by Gilles Pion.
195
0d887c7d
EZ
1962012-05-05 Eli Zaretskii <eliz@gnu.org>
197
198 * w32proc.c (new_child): Force Windows to reserve only 64KB of
199 stack for each reader_thread, instead of defaulting to 8MB
200 determined by the linker. This avoids failures in creating
201 subprocesses on Windows 7, see the discussion in this thread:
202 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
203
bf98199c
JM
2042012-05-02 Jim Meyering <meyering@redhat.com>
205
206 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
207
2fa85638
EZ
2082012-04-29 Eli Zaretskii <eliz@gnu.org>
209
210 * xdisp.c (pos_visible_p): If already at a newline from the
211 display string before the 'while' loop, don't walk back the glyphs
212 from it3.glyph_row. Solves assertion violation when the display
213 string begins with a newline (egg.el). (Bug#11367)
214
9be2fd9b
CY
2152012-04-24 Chong Yidong <cyd@gnu.org>
216
217 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
218
f0ee99a0
EZ
2192012-04-23 Eli Zaretskii <eliz@gnu.org>
220
221 * xdisp.c (pos_visible_p): If the window start position is beyond
222 ZV, start the display from buffer beginning. Prevents assertion
223 violation in init_iterator when the minibuffer window is scrolled
224 via the scroll bar.
225
226 * window.c (window_scroll_pixel_based): Likewise.
227
9ec7751f
CY
2282012-04-23 Chong Yidong <cyd@gnu.org>
229
230 * keymap.c (where_is_internal): Doc fix (Bug#10872).
231
24c51a09
GM
2322012-04-20 Glenn Morris <rgm@gnu.org>
233
234 * fileio.c (Fcopy_file, Fset_file_selinux_context):
235 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
236
73055685
EZ
2372012-04-20 Eli Zaretskii <eliz@gnu.org>
238
239 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
240 overrun array limits of glyph row's used[] array. (Bug#11288)
241
f30d612a
CY
2422012-04-20 Chong Yidong <cyd@gnu.org>
243
244 * process.c (wait_reading_process_output): If EIO occurs on a pty,
245 set the status to "failed" and ensure that sentinel is run.
246
016a35df
GM
2472012-04-18 Glenn Morris <rgm@gnu.org>
248
249 * process.c (Fset_process_inherit_coding_system_flag)
250 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 251 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 252
20a68157
EZ
2532012-04-17 Eli Zaretskii <eliz@gnu.org>
254
255 * xdisp.c (string_buffer_position_lim): Limit starting position to
256 BEGV.
257 (set_cursor_from_row): If called for a mode-line or header-line
258 row, return zero immediately.
259 (try_cursor_movement): If inside continuation line, don't back up
260 farther than the first row after the header line, if any. Don't
261 consider the header-line row as "partially visible", even if
262 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
263
ad3a2b41
AO
2642012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
265
266 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
267
e63c261b
CY
2682012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
269
270 * process.c (make_process):
271 * process.h: Add integer `gnutls_handshakes_tried' member to
272 process struct.
273
ad3a2b41
AO
274 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
275 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
276
277 * gnutls.c (gnutls_log_function2i): Convenience log function.
278 (emacs_gnutls_read): Use new log functions,
279 `gnutls_handshakes_tried' process member, and
280 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
281 attempts per process (connection).
282
e53357c4
EZ
2832012-04-09 Eli Zaretskii <eliz@gnu.org>
284
285 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
286 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
287
aff67c82
JD
2882012-04-09 Jan Djärv <jan.h.d@swipnet.se>
289
290 * nsterm.m (constrainFrameRect): Always constrain when there is only
291 one screen (Bug#10962).
292
2f8e16b2
EZ
2932012-04-06 Eli Zaretskii <eliz@gnu.org>
294
295 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
296 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
297 about subtle differences between FETCH_CHAR* and STRING_CHAR*
298 macros related to unification of CJK characters. For the details,
299 see the discussion following the message here:
300 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
301
3d439cd1
CY
3022012-04-04 Chong Yidong <cyd@gnu.org>
303
304 * keyboard.c (Vdelayed_warnings_list): Doc fix.
305
8bc53d00
EZ
3062012-04-01 Eli Zaretskii <eliz@gnu.org>
307
308 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
309 instead of alloca. (Bug#11138)
310
3b0512a3
AS
3112012-04-01 Andreas Schwab <schwab@linux-m68k.org>
312
313 * w32menu.c (is_simple_dialog): Properly check lisp types.
314 (Bug#11141)
315
8427ddd2
EZ
3162012-03-31 Eli Zaretskii <eliz@gnu.org>
317
979022ef
EZ
318 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
319 position we get to after a call to move_it_to fails the
320 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
321 only if we wind up in a string from display property. (Bug#11063)
322
a6b1c7cc
EZ
323 * window.c (Fdelete_other_windows_internal): Invalidate the row
324 and column information about mouse highlight, so that redisplay
325 restores it after reallocating the glyph matrices. (Bug#7464)
326
8427ddd2
EZ
327 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
328 string comes from a `display' text property, use the buffer
329 position of that property as if we actually saw that position in
330 the row's glyphs.
697ba24b
EZ
331 (move_it_by_lines): Remove the assertion that
332 "it->current_x == 0 && it->hpos == 0" which can be legitimately
333 violated when there's a before-string at the beginning of a line.
334 (Bug#11063)
8427ddd2 335
65a0a738
EZ
3362012-03-30 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (append_space_for_newline): If the default face was
339 remapped, use the remapped face for the appended newline.
340 (extend_face_to_end_of_line): Use the remapped default face for
341 extending the face to the end of the line.
342 (display_line): Call extend_face_to_end_of_line when the default
343 face was remapped. (Bug#11068)
344
581355cc
EZ
3452012-03-29 Eli Zaretskii <eliz@gnu.org>
346
347 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
348
e8fc049f
SM
3492012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
350
351 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
352
4fb9a543
GM
3532012-03-27 Glenn Morris <rgm@gnu.org>
354
355 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
356 Doc fixes.
357
679910f1
KH
3582012-03-26 Kenichi Handa <handa@m17n.org>
359
360 * dispextern.h (struct glyph): Fix previous change. Change the
361 bit length of glyphless.ch to 25 (Bug#11082).
362
90d49b7f
CY
3632012-03-26 Chong Yidong <cyd@gnu.org>
364
365 * keyboard.c (Vselection_inhibit_update_commands): New variable.
366 (command_loop_1): Use it; inhibit selection update for
367 handle-select-window too (Bug#8996).
368
f514f6f0
FP
3692012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
370
e8fc049f 371 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 372
bf43fa51
KH
3732012-03-25 Kenichi Handa <handa@m17n.org>
374
375 * dispextern.h (struct glyph): Change the bit length of
376 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
377
8a0c01dd
EZ
3782012-03-24 Eli Zaretskii <eliz@gnu.org>
379
380 * s/ms-w32.h (tzname): Include time.h before redirecting to
381 _tzname. Fixes the MSVC build. (Bug#9960)
382
7d1c3a76
AS
3832012-03-24 Andreas Schwab <schwab@linux-m68k.org>
384
8ed79523
AS
385 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
386 characters.
387
7d1c3a76
AS
388 * xterm.c (XTread_socket): Only modify handling_signal if
389 !SYNC_INPUT. (Bug#11080)
390
e99a9b8b
EZ
3912012-03-23 Eli Zaretskii <eliz@gnu.org>
392
393 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
394 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
395 when fetching a multibyte character consumes more bytes than
396 CHAR_BYTES returns, due to unification of CJK characters in
397 string_char. (Bug#11073)
398
5063c0e1
TN
3992012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
400
401 * process.c (wait_reading_process_output): Handle pty disconnect
402 by refraining from sending oneself a SIGCHLD (bug#10933).
403
9f851fbd
CY
4042012-03-22 Chong Yidong <cyd@gnu.org>
405
406 * dispextern.h (struct it): New member string_from_prefix_prop_p.
407
5063c0e1 408 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
409 Mark string as coming from a prefix property.
410 (handle_face_prop): Use default face for prefix strings (Bug#4281).
411 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
412
fb5b8aca
CY
4132012-03-21 Chong Yidong <cyd@gnu.org>
414
415 * xfaces.c (Vface_remapping_alist): Doc fix.
416
62356a1b
EZ
4172012-03-20 Eli Zaretskii <eliz@gnu.org>
418
419 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
420 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
421 Doc fixes.
62356a1b 422
025de85b
CY
4232012-03-20 Chong Yidong <cyd@gnu.org>
424
425 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
426 to reflect default non-nil value of redisplay-dont-pause.
427
4827f94e
KH
4282012-03-19 Kenichi Handa <handa@m17n.org>
429
430 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
431 it fit in a valid range (Bug#11003).
432
e50a24a2
EZ
4332012-03-18 Eli Zaretskii <eliz@gnu.org>
434
435 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
436 that is not from display property, accept the row as a "cursor
437 row" if one of the string's character has a non-nil `cursor'
438 property. Fixes cursor positioning when there are newlines in
439 overlay strings, e.g. in icomplete.el. (Bug#11035)
440
9af5ed87
PE
4412012-03-12 Paul Eggert <eggert@cs.ucla.edu>
442
443 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
444
d1f55f16
CY
4452012-03-12 Chong Yidong <cyd@gnu.org>
446
447 * eval.c (inhibit_lisp_code): Rename from
448 inhibit_window_configuration_change_hook; move from window.c.
449
450 * xfns.c (unwind_create_frame_1, Fx_create_frame):
451 * window.c (run_window_configuration_change_hook)
452 (syms_of_window): Callers changed.
453
66c5eebd
CY
4542012-03-11 Chong Yidong <cyd@gnu.org>
455
413df973
CY
456 * keymap.c (Fkey_description): Doc fix (Bug#9700).
457
66c5eebd
CY
458 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
459
1de11f56
CY
4602012-03-10 Chong Yidong <cyd@gnu.org>
461
462 * frame.c (other_visible_frames): Don't assume the selected frame
463 is visible (Bug#10955).
464
cae07000
SM
4652012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
466
467 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
468
89c94350
JD
4692012-03-08 Jan Djärv <jan.h.d@swipnet.se>
470
471 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
472 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
473 zero (Bug#10954).
474
999dd333
GM
4752012-03-03 Glenn Morris <rgm@gnu.org>
476
01a6dcc8 477 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 478
de0100f2
EZ
4792012-03-02 Eli Zaretskii <eliz@gnu.org>
480
481 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
482 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
483 (redisplay_window, next_element_from_string): Fix typos in
484 comments.
3e441275
EZ
485 (redisplay_window): Pass to move_it_vertically the margin in
486 pixels, not in screen lines.
de0100f2 487
96a72ee9
GM
4882012-03-02 Glenn Morris <rgm@gnu.org>
489
490 * buffer.c (buffer-list-update-hook): Doc fix.
491
312508d7
EZ
4922012-02-29 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
495 push_it before setting up the iterator for the first overlay
496 string, even if we have an empty string loaded.
497 (next_overlay_string): If there's an empty string on the iterator
498 stack, pop the stack. (Bug#10903)
499
27f3c637
PE
5002012-02-25 Paul Eggert <eggert@cs.ucla.edu>
501
502 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
503 Suggested by Stefan Monnier in
504 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
505 * alloc.c (widen_to_Lisp_Object): New static function.
506 (mark_memory): Also mark Lisp_Objects by fetching pointer words
507 and widening them to Lisp_Objects. This would work even if
508 USE_LSB_TAG is defined and wide integers are used, which might
509 happen in a future version of Emacs.
510
3c9dfce6
CY
5112012-02-25 Chong Yidong <cyd@gnu.org>
512
fa74b241
CY
513 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
514 Doc fix.
515
3c9dfce6
CY
516 * xselect.c (Fx_selection_exists_p): Doc fix.
517 (x_clipboard_manager_save_all): Print an informative message
518 before saving to clipboard manager.
519
9486df08
CY
5202012-02-24 Chong Yidong <cyd@gnu.org>
521
522 * keyboard.c (process_special_events): Handle all X selection
523 requests in kbd_buffer, not just the next one (Bug#8869).
524
f01d3321
CY
5252012-02-23 Chong Yidong <cyd@gnu.org>
526
527 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
528 call when setting menu-bar-lines and tool-bar-lines parameters.
529 (unwind_create_frame_1): New helper function.
530
531 * window.c (inhibit_window_configuration_change_hook): New var.
532 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 533 (syms_of_window): Initialize it.
f01d3321 534
86b847b6
CY
5352012-02-22 Chong Yidong <cyd@gnu.org>
536
537 * xterm.c (x_draw_image_relief): Add missing type check for
538 Vtool_bar_button_margin (Bug#10743).
539
a59225b1
CY
5402012-02-21 Chong Yidong <cyd@gnu.org>
541
542 * fileio.c (Vfile_name_handler_alist): Doc fix.
543
544 * buffer.c (Fget_file_buffer): Protect against invalid file
545 handler return value.
546
310f5bd4
PE
5472012-02-20 Paul Eggert <eggert@cs.ucla.edu>
548
cb3a28cc
PE
549 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
550 when computing $valmask.
551
310f5bd4
PE
552 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
553 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
554 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
555 It's useless in that case, and it can cause problems on hosts
556 that allocate halves of EMACS_INT values separately.
557 Reported by Dan Horák. Diagnosed by Andreas Schwab in
558 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
559 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
560 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
561 it avoids undefined behavior on hosts where shifting right by more
562 than the word width has undefined behavior.
563
2375c96a
CY
5642012-02-19 Chong Yidong <cyd@gnu.org>
565
566 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
567 (Funhandled_file_name_directory, Ffile_name_as_directory)
568 (Fdirectory_file_name, Fexpand_file_name)
569 (Fsubstitute_in_file_name): Protect against invalid file handler
570 return values (Bug#10845).
571
3eb49e71
EZ
5722012-02-18 Eli Zaretskii <eliz@gnu.org>
573
574 * .gdbinit (pitx): Fix incorrect references to fields of the
575 iterator stack.
576
7b926f3f
CY
5772012-02-17 Chong Yidong <cyd@gnu.org>
578
579 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
580
11273115
PE
5812012-02-15 Paul Eggert <eggert@cs.ucla.edu>
582
583 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
584 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
585
c3a70e2b
CY
5862012-02-15 Chong Yidong <cyd@gnu.org>
587
588 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
589 marked as special. Also, starting docstrings with * is obsolete.
590
0ca43699
AS
5912012-02-13 Andreas Schwab <schwab@linux-m68k.org>
592
593 * gnutls.c (emacs_gnutls_write): Fix last change.
594
2e8f3c56
LI
5952012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
596
597 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
598 send_process.
599
af70074f
SM
6002012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
601
602 * keymap.c (Fsingle_key_description): Handle char ranges.
603
95986d52
CY
6042012-02-12 Chong Yidong <cyd@gnu.org>
605
afd83bd1
CY
606 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
607 as that creates a dangerous corner case.
608
95986d52
CY
609 * window.c (Fdelete_window_internal): Invalidate the mouse
610 highlight (Bug#9904).
611
bd7da63e
GM
6122012-02-12 Glenn Morris <rgm@gnu.org>
613
614 * xselect.c (Fx_own_selection_internal)
615 (Fx_get_selection_internal, Fx_disown_selection_internal)
616 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
617 * nsselect.m (Fx_own_selection_internal)
618 (Fx_disown_selection_internal, Fx_selection_exists_p)
619 (Fx_selection_owner_p, Fx_get_selection_internal):
620 Sync docs and argument specs with the xselect.c versions.
621
77abcbc2
LI
6222012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
623
624 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
625
90b671e2
EZ
6262012-02-11 Eli Zaretskii <eliz@gnu.org>
627
1c0ca0b7
EZ
628 * w32select.c (Fx_selection_exists_p): Sync doc string and
629 argument list with xselect.c. (Bug#10783)
630
631 * w16select.c (Fx_selection_exists_p): Sync doc string and
632 argument list with xselect.c. (Bug#10783)
90b671e2 633
49241268
GM
6342012-02-10 Glenn Morris <rgm@gnu.org>
635
636 * fns.c (Fsecure_hash): Doc fix.
637
f998bbe7 6382012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
639
640 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
641
0992bd9c
CY
6422012-02-07 Chong Yidong <cyd@gnu.org>
643
644 * buffer.c (Fbuffer_local_variables)
645 (buffer_lisp_local_variables): Handle unbound vars correctly;
646 don't let Qunbound leak into Lisp.
647
af008560
GM
6482012-02-07 Glenn Morris <rgm@gnu.org>
649
dd605cc4
GM
650 * image.c (Fimagemagick_types): Doc fix.
651
af008560
GM
652 * image.c (imagemagick-render-type): Change it from a lisp object
653 to an integer. Move the doc here from the lisp manual.
654 Treat all values not equal to 0 the same.
655
1449fa1d
CY
6562012-02-06 Chong Yidong <cyd@gnu.org>
657
658 * doc.c (store_function_docstring): Avoid applying docstring of
659 alias to base function (Bug#2603).
660
3723ec07
AS
6612012-02-04 Andreas Schwab <schwab@linux-m68k.org>
662
663 * .gdbinit (pp1, pv1): Remove redundant defines.
664 (pr): Use pp.
665
79c1cc1e
CY
6662012-02-04 Chong Yidong <cyd@gnu.org>
667
668 * nsterm.m: Declare a global (Bug#10694).
669
d7f29f8e
EZ
6702012-02-04 Eli Zaretskii <eliz@gnu.org>
671
cae07000
SM
672 * w32.c (get_emacs_configuration_options):
673 Include --enable-checking, if specified, in the return value.
d7f29f8e 674
3b95a6f9
MR
6752012-02-04 Martin Rudalics <rudalics@gmx.at>
676
677 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
678 after rounding frame sizes. (Bug#9723)
679
d6fa96a6
EZ
6802012-02-04 Eli Zaretskii <eliz@gnu.org>
681
682 * keyboard.c (adjust_point_for_property): Don't position point
683 before BEGV. (Bug#10696)
684
df0b2940
PE
6852012-02-03 Paul Eggert <eggert@cs.ucla.edu>
686
687 Handle overflow when computing char display width (Bug#9496).
688 * character.c (char_width): Return EMACS_INT, not int.
689 (char_width, c_string_width): Check for overflow when
690 computing the width; this is possible now that individual
691 characters can have unbounded width. Problem introduced
692 by merge from Emacs 23 on 2012-01-19.
693
6bee44d6
MA
6942012-02-02 Michael Albinus <michael.albinus@gmx.de>
695
696 * dbusbind.c (Fdbus_register_method): Mention the return value
697 :ignore in the docstring.
698
44f92739
GM
6992012-02-02 Glenn Morris <rgm@gnu.org>
700
1b9f60cc
GM
701 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
702
44f92739
GM
703 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
704 Unconditionally set to t. (Bug#10673)
705 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
706 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
707 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
708
c5d3843c
KH
7092012-02-02 Kenichi Handa <handa@m17n.org>
710
711 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
712 0, do not call append_composite_glyph.
713
159462d4 7142012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
715
716 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
717 NULL (Bug#6988).
718 (x_produce_glyphs): If the component of a composition is a null
719 string, set it->pixel_width to 1 to avoid zero-width glyph.
720
78cef877
EZ
7212012-02-01 Eli Zaretskii <eliz@gnu.org>
722
723 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
724 first 2 arguments are identical. This makes inserting large
725 output from a subprocess an order of magnitude faster on
726 MS-Windows, where all sbrk'ed memory is always contiguous.
727
97897668
GM
7282012-01-31 Glenn Morris <rgm@gnu.org>
729
730 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 731 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
732 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
733
31fd3586
GM
7342012-01-29 Glenn Morris <rgm@gnu.org>
735
736 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
737
0e24a8b2
CY
7382012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
739
740 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
741
cc0adcb0
CY
7422012-01-28 Chong Yidong <cyd@gnu.org>
743
744 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
745
acc28cb9
CY
7462012-01-26 Chong Yidong <cyd@gnu.org>
747
9c69cfb7
CY
748 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
749
acc28cb9
CY
750 * search.c (Fsearch_forward, Fsearch_backward): Document negative
751 repeat counts (Bug#10507).
752
48da7392
GM
7532012-01-26 Glenn Morris <rgm@gnu.org>
754
755 * lread.c (syms_of_lread): Doc fix.
756
14af5f7f
CY
7572012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
758
759 * coding.c (encode_designation_at_bol): Change return value to
760 EMACS_INT.
761
0b21c100
CY
7622012-01-25 Chong Yidong <cyd@gnu.org>
763
764 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
765
3c2907f7
CY
7662012-01-21 Chong Yidong <cyd@gnu.org>
767
768 * floatfns.c (Fcopysign): Make the second argument non-optional,
769 since nil is not allowed anyway.
770
959ad23f
AS
7712012-01-21 Andreas Schwab <schwab@linux-m68k.org>
772
773 * process.c (read_process_output): Use p instead of XPROCESS (proc).
774 (send_process): Likewise.
775
34a02f46
MR
7762012-01-19 Martin Rudalics <rudalics@gmx.at>
777
778 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
779 (Vwindow_persistent_parameters): Do not use Qstate.
780 Rewrite doc-strings.
34a02f46 781
1259009a 7822012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
783
784 * character.c (char_width): New function.
70d4fdf6
GM
785 (Fchar_width, c_string_width, lisp_string_width):
786 Use char_width (Bug#9496).
25ed9e61 787
6a6ee00d
MR
7882012-01-16 Martin Rudalics <rudalics@gmx.at>
789
790 * window.c (Vwindow_persistent_parameters): New variable.
791 (Fset_window_configuration, save_window_save): Handle persistent
792 window parameters.
793
c85efaf7
EZ
7942012-01-14 Eli Zaretskii <eliz@gnu.org>
795
796 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
797 thrashing the stack of the thread. (Bug#9087)
798
5944709e
PE
7992012-01-12 Paul Eggert <eggert@cs.ucla.edu>
800
801 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
802
e71f5d99
EZ
8032012-01-11 Eli Zaretskii <eliz@gnu.org>
804
805 * xdisp.c (rows_from_pos_range): Handle the case where the
806 highlight ends on a newline. (Bug#10464)
807 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
808 he end column for display of highlight that ends on a newline
809 before a R2L line.
810
ce316182
GM
8112012-01-11 Glenn Morris <rgm@gnu.org>
812
813 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
814 from load-path also when installation-directory is nil. (Bug#10208)
815
5b43da69
GM
8162012-01-10 Glenn Morris <rgm@gnu.org>
817
74cc8ff9
GM
818 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
819
7d8d6e4e
GM
820 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
821 Update template values to be closer to their typical values these days.
5b43da69 822
a0db8d43
EZ
8232012-01-09 Eli Zaretskii <eliz@gnu.org>
824
825 * xdisp.c (rows_from_pos_range): Accept additional argument
826 DISP_STRING, and accept any glyph in a row whose object is that
827 string as eligible for mouse highlight. Fixes mouse highlight of
828 display strings from overlays. (Bug#10464)
829
9a0115ab 8302012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 831
b9110d6a 832 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
833 * fileio.c (auto_saving_dir_umask): New static var.
834 (Fmake_directory_internal): Use it.
835 (do_auto_save_make_dir): Set it, instead of invoking chmod after
836 creating the directory. The old code temporarily assigns
837 too-generous permissions to the directory.
838 (do_auto_save_eh): Clear it.
b9110d6a 839 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
840 that the var is always cleared.
841
6c1bd3f3
EZ
8422012-01-07 Eli Zaretskii <eliz@gnu.org>
843
844 * search.c (scan_buffer): Pass character positions to
845 know_region_cache, not byte positions. (Bug#6540)
846
069d2b50
L
8472012-01-07 LynX <_LynX@bk.ru> (tiny change)
848
849 * w32.c (sys_rename): Report EXDEV when rename of a directory
850 fails because the target is on another logical disk. (Bug#10284)
851
75bf0d33
DB
8522012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
853
854 * xterm.c (x_embed_request_focus): New function.
855
856 * xterm.h: Add prototype.
857
858 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
859
1c6e5a32
GM
8602012-01-05 Glenn Morris <rgm@gnu.org>
861
862 * emacs.c (emacs_copyright): Update short copyright year to 2012.
863
651e947e
EZ
8642012-01-01 Eli Zaretskii <eliz@gnu.org>
865
866 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
867 Load gnutls_transport_set_lowat only if GnuTLS version is below
868 2.11.1.
869 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
870 GnuTLS versions below 2.11.1.
871
3778cdd8
AL
8722011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
873
874 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
875 to the doc string advising against its use for altering the way
876 windows are scrolled.
877
0e5317f7
KH
8782011-12-28 Kenichi Handa <handa@m17n.org>
879
880 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
881 coding-system ASCII compatible only when it does not produce BOM
882 on encoding (Bug#10383).
883
93d5ca1f
JD
8842011-12-26 Jan Djärv <jan.h.d@swipnet.se>
885
886 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
887 can scroll.
888 (create_and_show_popup_menu): Always use menu_position_func for
889 Gtk3 (Bug#10361).
890
ca22b785
AS
8912011-12-24 Andreas Schwab <schwab@linux-m68k.org>
892
893 * callint.c (Fcall_interactively): Don't truncate prompt string.
894
d048e1e6
EZ
8952011-12-23 Eli Zaretskii <eliz@gnu.org>
896
897 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
898 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 899 resumed from there (after widening). (Bug#10360)
d048e1e6 900
5ccaba1f
JD
9012011-12-22 Jan Djärv <jan.h.d@swipnet.se>
902
903 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
904
204ee57f
JD
9052011-12-21 Jan Djärv <jan.h.d@swipnet.se>
906
b81d40f0
JB
907 * nsterm.m (x_free_frame_resources):
908 Release f->output_data.ns->miniimage.
204ee57f
JD
909 (ns_index_color): Fix indentation. Do not retain
910 color_table->colors[i].
911
912 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
913 before returning.
914
915 * nsfns.m (x_set_background_color): Assign return value from
916 ns_index_color to face-background instead of NSColor*.
917 (ns_implicitly_set_icon_type): Fix indentation.
918 Change assignment in for loop to comparison.
919
920 * emacs.c (ns_pool): New variable.
921 (main): Assign ns_pool.
922 (Fkill_emacs): Call ns_release_autorelease_pool.
923
924 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
925 autorelease fdesc, release fdAttrs and tdict.
926 (ns_get_covering_families): Release charset.
927 (ns_findfonts): Release NSFontDescriptor created with new.
928 (ns_uni_to_glyphs): Fix indentation.
929 (setString): Release attrStr before assigning new value.
930
c803b2b7
JD
9312011-12-18 Jan Djärv <jan.h.d@swipnet.se>
932
678f4426
JD
933 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
934 and NS_IMPL_COCOA.
935 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
936 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
937
cd394be1 9382011-12-18 David Reitter <reitter@cmu.edu>
678f4426 939
5fecd5fc
JD
940 * nsterm.m (ns_term_init): Subscribe for notifications
941 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
942 to method trackingNotification in EmacsMenu.
943
944 * nsmenu.m (trackingMenu): New variable.
3771cb17 945 (trackingNotification): New method (from Aquamacs).
5fecd5fc 946 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 947 from Aquamacs (Bug#7030).
678f4426
JD
948
9492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 950
c803b2b7
JD
951 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
952 (symbol_to_nsstring): Fix indentation.
953 (ns_symbol_to_pb): New function.
cae07000
SM
954 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
955 (Fns_rotate_cut_buffers_internal): Remove.
956 (Fns_store_selection_internal): Rename from
c803b2b7
JD
957 Fns_store_cut_buffer_internal.
958 (ns_get_foreign_selection, Fx_own_selection_internal)
959 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
960 (Fns_get_selection_internal, Fns_store_selection_internal):
961 Use ns_symbol_to_pb and check if return value is nil.
962 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
963 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
964 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
965 renamed to Sns_store_selection_internal.
966 (ns_handle_selection_request): Move code to Fx_own_selection_internal
967 and remove this function.
968 (ns_handle_selection_clear): Remove, never used.
969 (Fx_own_selection_internal): Move code from ns_handle_selection_request
970 here.
971
e1b01a3a
KB
9722011-12-17 Ken Brown <kbrown@cornell.edu>
973
974 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
975 GID is unknown (Bug#10257).
976
2adb6e85
PE
9772011-12-17 Paul Eggert <eggert@cs.ucla.edu>
978
979 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
980 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
981 which caused a build failure on GNU/Linux IA-64. This problem was
982 introduced by my 2011-10-07 patch.
983
d1d7b339
JL
9842011-12-15 Juri Linkov <juri@jurta.org>
985
986 * image.c (imagemagick_error): New function. (Bug#10112)
987 (imagemagick_load_image): Comment out `MagickSetResolution' call.
988 Use `imagemagick_error' where ImageMagick functions return
989 `MagickFalse'.
990 (Fimagemagick_types): Add `Fnreverse' to return the list in the
991 proper order.
992
100d5755
KH
9932011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
994
995 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
996 fill background (Bug#8992).
997
454592a6
MR
9982011-12-13 Martin Rudalics <rudalics@gmx.at>
999
1000 * window.c (Vwindow_combination_resize)
1001 (Vwindow_combination_limit): Use t instead of non-nil in
1002 doc-strings.
61d4b438
MR
1003 (Vrecenter_redisplay): Add first sentence of doc-string on
1004 separate line.
53524d93 1005 (Frecenter): Fix doc-string typo.
454592a6 1006
3633e3aa
KH
10072011-12-11 Kenichi Handa <handa@m17n.org>
1008
1009 * coding.c (Funencodable_char_position): Pay attention to the
1010 buffer text relocation (Bug#9389).
1011
7b9d523a
JD
10122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1013
1014 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1015 gtk_init (Bug#10100).
1016
b73189c6
EZ
10172011-12-10 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1020 IT->string is nil. (Bug#10263)
1021
f7dfe5d6
JD
10222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1023
83faebb4
JD
1024 * nsterm.h (x_free_frame_resources): Declare.
1025
f7dfe5d6
JD
1026 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1027 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1028
1029 * nsterm.h (ns_get_defaults_value): Declare.
1030
1031 * nsterm.m (ns_default): Call ns_get_defaults_value.
1032
7cd4e72c
EZ
10332011-12-09 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1036 (Bug#10170)
1037
b34d7317
YM
10382011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1039
1040 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1041 that where the value of an _OBJC_* symbol points to is in the .bss
1042 section (Bug#10240).
1043
76470ad1
KH
10442011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1045
1046 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1047 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1048
745fff94
KH
10492011-12-08 Kenichi Handa <handa@m17n.org>
1050
1051 * ftfont.c (get_adstyle_property): Fix previous change
1052 (Bug#10233).
1053
6e44397c
JB
10542011-12-07 Juanma Barranquero <lekktu@gmail.com>
1055
1056 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1057 dirs from the default value of EMACSLOADPATH (bug#10208).
1058
7efa6272
GM
10592011-12-07 Glenn Morris <rgm@gnu.org>
1060
1061 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1062 installation and source directories as well. (Bug#10208)
1063
f6fc4d87
CY
10642011-12-06 Chong Yidong <cyd@gnu.org>
1065
1066 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1067
2bf26180
GM
10682011-12-06 Glenn Morris <rgm@gnu.org>
1069
1070 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1071 as an error, not just -1. (Bug#10217)
1072
3a6ad4f0
CY
10732011-12-05 Chong Yidong <cyd@gnu.org>
1074
1075 * keyboard.c (process_special_events): New function.
1076 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1077
75a3b399
PE
10782011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * coding.c (encode_designation_at_bol): Don't use uninitialized
1081 local variable (Bug#9318).
1082
c3c9e25e
KH
10832011-12-05 Kenichi Handa <handa@m17n.org>
1084
1085 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1086 return Qnil (Bug#8046, Bug#10193).
1087
5eb05ea3
KH
10882011-12-05 Kenichi Handa <handa@m17n.org>
1089
1090 * coding.c (encode_designation_at_bol): New args charbuf_end and
1091 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1092 (coding_set_source): Return how many bytes coding->source was
1093 relocated.
1094 (coding_set_destination): Return how many bytes
1095 coding->destination was relocated.
1096 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1097 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1098
10992011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1100
1101 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1102 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1103 macro (Bug#9318).
1104
11052011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1106
1107 The following changes are to fix Bug#9318.
1108
a79703f5 1109 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1110 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1111 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1112 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1113
7dbda6df
JB
11142011-12-05 Juanma Barranquero <lekktu@gmail.com>
1115
1116 * lisp.h (process_quit_flag): Fix external declaration.
1117
6d5eb5b0
SM
11182011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1119
1120 Don't macro-inline non-performance-critical code.
1121 * eval.c (process_quit_flag): New function.
1122 * lisp.h (QUIT): Use it.
1123
a0c3fad0
JD
11242011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1125
1126 * nsfns.m (get_geometry_from_preferences): New function.
1127 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1128
6c07aac2
AS
11292011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1130
1131 * emacs.c (Qkill_emacs): Define.
1132 (syms_of_emacs): Initialize it.
1133 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1134 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1135 (quit_throw_to_read_char): Add parameter `from_signal'.
1136 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1137 * lisp.h (QUIT): Call Fkill_emacs if requested.
1138
c052ead4
JD
11392011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1140
1141 * widget.c (update_wm_hints): Return if wmshell is null.
1142 (widget_update_wm_size_hints): New function.
1143
1144 * widget.h (widget_update_wm_size_hints): Declare.
1145
1146 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1147 widget_update_wm_size_hints (Bug#10104).
1148
9e49252b
EZ
11492011-12-03 Eli Zaretskii <eliz@gnu.org>
1150
1151 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1152 before a newline, prepare the bidi iterator for consuming the
1153 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1154 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1155
02b16839
JL
11562011-12-02 Juri Linkov <juri@jurta.org>
1157
1158 * search.c (Fword_search_regexp): New Lisp function created from
1159 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1160 (Fword_search_backward, Fword_search_forward)
1161 (Fword_search_backward_lax, Fword_search_forward_lax):
1162 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1163 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1164
0068070e
SM
11652011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * fileio.c (Finsert_file_contents): Move after-change-function call
1168 to before the "handled:" label, since all "goto handled" appear in
1169 cases where the *-change-functions have already been properly called
1170 (bug#10117).
1171
3360a3fc
AS
11722011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1175 waiting for input. (Bug#10169)
1176
73d6c093
EZ
11772011-11-30 Eli Zaretskii <eliz@gnu.org>
1178
1179 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1180 verifies glyph row's hash code--we have just reallocated the
1181 glyphs, so their contents can be complete garbage. (Bug#10164)
1182
febe6bea
JB
11832011-11-30 Juanma Barranquero <lekktu@gmail.com>
1184
1185 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1186
801a4313
EZ
11872011-11-30 Eli Zaretskii <eliz@gnu.org>
1188
1189 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1190 attributes are tested _before_ calling verify_row_hash, to protect
1191 against GCC re-ordering of the tests. (Bug#10164)
1192
2b56b87e
JD
11932011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1194
1195 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1196
1197 * xterm.c (handle_one_xevent): Only set async_visible and friends
1198 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1199 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1200 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1201
dbf31225
PE
12022011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1205 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1206 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1207 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1208 All uses changed to use GCPRO1 etc.
1209 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1210 Revert to old implementation (i.e., before 2011-03-11).
1211
1305621b
YM
12122011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1213
1214 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1215 of scroll runs so as to avoid assigning disabled bogus rows and
1216 unnecessary graphics copy operations.
1217
8c9afb46
EZ
12182011-11-27 Eli Zaretskii <eliz@gnu.org>
1219
1220 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1221 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1222 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1223 (malloc, free, realloc, calloc): Redirect to e_* only when
1224 compiling Emacs.
1225
1226 * lisp.h (GCTYPEBITS): Move before first use.
1227 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1228 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1229 this macro definition.
1230
1231 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1232 _MSC_VER.
1233
54e9e3bf
JD
12342011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1235
6d5eb5b0
SM
1236 * gtkutil.c (xg_create_frame_widgets):
1237 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1238 present with Gtk+ 2.0.
1239
83aca1cb
PE
12402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 * fileio.c (Finsert_file_contents): Undo previous change; see
1243 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1244
5b76caa4
PE
12452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 Rename locals to avoid shadowing.
1248 * fileio.c (Finsert_file_contents):
1249 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1250 * process.c (wait_reading_process_output):
1251 Rename inner 'proc' to 'p' to avoid shadowing.
1252 Indent for consistency with usual Emacs style.
1253
8c535114
EZ
12542011-11-25 Eli Zaretskii <eliz@gnu.org>
1255
1256 * xdisp.c (redisplay_window): If cursor row is not fully visible
1257 after recentering, and scroll-conservatively is set to a large
1258 number, scroll window by a few more lines to make the cursor fully
1259 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1260 (start_display): Don't move to the next line if the display should
1261 start at a newline that is part of a display vector or an overlay
1262 string. (Bug#10119)
8c535114 1263
fa4fdb5c
JL
12642011-11-24 Juri Linkov <juri@jurta.org>
1265
1266 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1267 after the `MagickPingImage' call. (Bug#10112)
1268
90ec88df
CY
12692011-11-23 Chong Yidong <cyd@gnu.org>
1270
1271 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1272
56e2e794
MR
12732011-11-23 Martin Rudalics <rudalics@gmx.at>
1274
1275 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1276 making another buffer current. (Bug#10114)
1277
b6e64c41
GM
12782011-11-23 Glenn Morris <rgm@gnu.org>
1279
1280 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1281
6b21de18
CY
12822011-11-23 Chong Yidong <cyd@gnu.org>
1283
1284 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1285 using it (Bug#5984).
1286
b12cd789
EZ
12872011-11-22 Eli Zaretskii <eliz@gnu.org>
1288
1289 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1290 and header-lines, as they don't have one computed for them.
1291 (Bug#10098)
1292
1293 * .gdbinit (prow): Make displayed values more self-explaining.
1294 Add row's hash code.
1295
261b6fd4
LMI
12962011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1297
1298 * process.c (wait_reading_process_output): Fix asynchrounous
1299 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1300 (wait_reading_process_output): Add comment and URL.
261b6fd4 1301
e7cfd277
JD
13022011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1303
1304 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1305
a9b9b7f5
CY
13062011-11-21 Chong Yidong <cyd@gnu.org>
1307
1308 * window.c (Fnext_window, Fprevious_window): Doc fix.
1309
b0d15b4f
SM
13102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1311
1312 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1313
fe7a3057
JB
13142011-11-20 Juanma Barranquero <lekktu@gmail.com>
1315
1316 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1317
d2999b1a
MR
13182011-11-20 Martin Rudalics <rudalics@gmx.at>
1319
1320 * window.c (Fset_window_combination_limit): Rename argument
1321 STATUS to LIMIT.
1322 (Vwindow_combination_limit): Remove "status" from doc-string.
1323
d5ff9cd0
AS
13242011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1325
1326 * m/ibms390.h: Remove.
1327 * m/ibms390x.h: Don't include "ibms390.h".
1328
a5bb9bd3
SM
13292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1332 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1333
cd1181db
JB
13342011-11-20 Juanma Barranquero <lekktu@gmail.com>
1335
1336 * casetab.c (Fset_case_table):
1337 * charset.c (Fcharset_after): Fix typos.
1338
615a3b8d 13392011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1340
17e845af
PE
1341 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1342 Otherwise, valgrind does not work on some platforms.
1343 Problem reported by Andreas Schwab in
6a0bf43d
PE
1344 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1345 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1346 is set, removing the need for VIRT_ADDRESS_VARIES.
1347 (PURE_P): Use a more-efficient implementation that needs just one
1348 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1349 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1350 to 4 (xorl, subq, cmpq, setbe).
1351 * alloc.c (pure): Always extern now, since that's the
1352 VIRT_ADDR_VARIES behavior.
1353 (PURE_POINTER_P): Use a single comparison, not two, for
1354 consistency with the new puresize.h.
1355 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1356 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1357 Remove VIRT_ADDR_VARIES no longer needed.
1358
f8fe6f96
EZ
13592011-11-19 Eli Zaretskii <eliz@gnu.org>
1360
1361 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1362 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1363 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1364 behave as if the cursor position were at the window margin.
1365
1366 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1367 and the cursor position is out of bounds, behave as if the cursor
1368 position were at the window margin. (Bug#10075)
1369
df05a53c
CY
13702011-11-18 Chong Yidong <cyd@gnu.org>
1371
1372 * window.c (Fwindow_combination_limit): Make first argument
1373 non-optional, since it is meaningless for live windows like the
1374 selected window.
1375
2071918e
DA
13762011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1377
1378 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1379
b50a28de
SM
13802011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1381
1382 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1383 (graft_intervals_into_buffer): Simplify.
1384
015137db
EZ
13852011-11-18 Eli Zaretskii <eliz@gnu.org>
1386
1387 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1388 hash values of the two rows.
1389 (copy_row_except_pointers): Preserve the used[] arrays and the
1390 hash values of the two rows. (Bug#10035)
68c95424 1391 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1392
1393 * xdisp.c (row_hash): New function, body extracted from
1394 compute_line_metrics.
1395 (compute_line_metrics): Call row_hash, instead of computing the
1396 hash code inline.
1397
1398 * dispnew.c (verify_row_hash): Call row_hash for computing the
1399 hash code of a row, instead of duplicating code from xdisp.c.
1400
1401 * dispextern.h (row_hash): Add prototype.
1402
a2addb04
TH
14032011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1404
1405 * frame.c (delete_frame): Don't delete the terminal when the last
1406 X frame is closed if emacs is built with GTK toolkit.
1407
df85d315
JB
14082011-11-17 Juanma Barranquero <lekktu@gmail.com>
1409
1410 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1411
a0c2d0ae
MR
14122011-11-17 Martin Rudalics <rudalics@gmx.at>
1413
1414 * window.c (Vwindow_splits): Rename to
1415 Vwindow_combination_resize. Suggested by Juri Linkov.
1416 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1417 of Vwindow_splits.
1418
58179cce
JB
14192011-11-16 Juanma Barranquero <lekktu@gmail.com>
1420
7877f373
JB
1421 * nsfns.m (Fns_font_name):
1422 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1423
b6f67890
MR
14242011-11-16 Martin Rudalics <rudalics@gmx.at>
1425
1426 * window.h (window): Rename slot "nest" to "combination_limit".
1427 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1428 (Fset_window_nest): Rename to Fset_window_combination_limit.
1429 (Vwindow_nest): Rename to Vwindow_combination_limit.
1430 (recombine_windows, make_parent_window, make_window)
1431 (Fsplit_window_internal, saved_window)
1432 (Fset_window_configuration, save_window_save): Rename all
1433 occurrences of window_nest to window_combination_limit.
1434
c7015153
JB
14352011-11-15 Juanma Barranquero <lekktu@gmail.com>
1436
1437 * image.c (imagemagick_load_image): Fix typo.
1438
322ad6ec
EZ
14392011-11-14 Eli Zaretskii <eliz@gnu.org>
1440
1441 * xdisp.c (display_line): Move the call to
1442 highlight_trailing_whitespace before the call to
1443 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1444 faces of all the glyphs to compute ROW's hash value.
1445 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1446
f067b8ec
JB
14472011-11-14 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1450 just return (bug#10044).
1451
1e5b2111
EZ
14522011-11-12 Eli Zaretskii <eliz@gnu.org>
1453
7ef3cbd5
EZ
1454 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1455 with user-defined heap size. Bump the default size of the temacs
1456 heap to 27MB, to avoid memory warning when running temacs.
1457 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1458
1e5b2111
EZ
1459 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1460 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1461 (verify_row_hash) [XASSERTS]: New function.
1462 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1463 that the hash value of glyph rows is correct.
1e5b2111 1464
89d61221
MR
14652011-11-12 Martin Rudalics <rudalics@gmx.at>
1466
1467 * window.h (window): Remove splits slot.
1468 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1469 (Fdelete_other_windows_internal, make_parent_window)
1470 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1471 (Fset_window_configuration, save_window_save): Don't deal with
1472 split status of windows.
1473 (saved_window): Remove splits slot.
1474 (Vwindow_splits): Rewrite doc-string.
1475
97f18cc8
JD
14762011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1477
1478 * xfns.c (unwind_create_frame):
1479 * nsfns.m (unwind_create_frame):
1480 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1481 Vframe_list (Bug#9999).
1482
22a648b4
DA
14832011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1484
0b381c7e 1485 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1486
659afede
KH
14872011-11-11 Kenichi Handa <handa@m17n.org>
1488
1489 * callproc.c (Fcall_process): Set the member dst_multibyte of
1490 process_coding.
1491
9ac0394b
KH
14922011-11-11 Johan Bockgård <bojohan@gnu.org>
1493
1494 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1495 avoid a crash (bug#9496).
1496
2fbdc249
CY
14972011-11-09 Chong Yidong <cyd@gnu.org>
1498
1499 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1500 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1501
ac6b1f81
PE
15022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1505
09db192c
PE
15062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1507
1508 Avoid some portability problems by eschewing 'extern inline' functions.
1509 The trivial performance wins aren't worth the portability hassles; see
1510 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1511 et seq.
1512 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1513 (window_box_width, window_box_left, window_box_left_offset)
1514 (window_box_right, window_box_right_offset): Undo previous change,
1515 by removing the "extern"s.
1516 * intervals.c (adjust_intervals_for_insertion)
1517 (adjust_intervals_for_deletion): Undo previous change,
1518 making these static again.
1519 (offset_intervals, temp_set_point_both, temp_set_point)
1520 (copy_intervals_to_string): No longer inline.
1521 * xdisp.c (window_text_bottom_y, window_box_width)
1522 (window_box_height, window_box_left_offset)
1523 (window_box_right_offset, window_box_left, window_box_right)
1524 (window_box): No longer inline.
1525
105216ed
CY
15262011-11-08 Chong Yidong <cyd@gnu.org>
1527
1528 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1529 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1530 Signal an error if not a live window.
105216ed
CY
1531 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1532 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1533
ae9e237f
JB
15342011-11-07 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * lisp.h (syms_of_abbrev): Remove declaration.
1537 Reported by CHENG Gao <chenggao@royau.me>.
1538
c7aa8333
EZ
15392011-11-07 Eli Zaretskii <eliz@gnu.org>
1540
1541 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1542 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1543 of temacs in GUI mode.
1544
be7f5545
MR
15452011-11-07 Martin Rudalics <rudalics@gmx.at>
1546
1547 * window.h: Declare delete_all_child_windows instead of
1548 delete_all_subwindows.
1549 * window.c (Fwindow_nest, Fset_window_nest)
1550 (Fset_window_new_total, Fset_window_new_normal)
1551 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1552 (delete_all_subwindows): Rename to delete_all_child_windows.
1553 (Fdelete_other_windows_internal, Fset_window_configuration):
1554 Call delete_all_child_windows instead of delete_all_subwindows.
1555 * frame.c (delete_frame): Call delete_all_child_windows instead
1556 of delete_all_subwindows.
1557
ca78dc43
PE
15582011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1561 This is also needed for porting to any host where GC_MARK_STACK is
1562 not GC_MAKE_GCPROS_NOOPS.
1563 (which_symbols): Use it.
1564
a0241d01
KH
15652011-11-07 Kenichi Handa <handa@m17n.org>
1566
1567 * coding.c (coding_set_destination): Check coding->src_pos only
1568 when coding->src_object is a buffer (bug#9910).
1569
1570 * process.c (send_process): Set the member src_multibyte of coding
1571 to 0 (bug#9911) when sending a unibyte text.
1572
1573 * callproc.c (Fcall_process): Set the member src_multibyte of
1574 process_coding to 0 (bug#9912).
1575
a64bfdfa 15762011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1577
1578 * xmenu.c (cleanup_widget_value_tree): New function.
1579 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1580 calling free_menubar_widget_value_tree directly (Bug#9830).
1581
cb41b32a
PE
15822011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 Fix some portability problems with 'inline'.
1585 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1586 (window_box_width, window_box_left, window_box_left_offset)
1587 (window_box_right, window_box_right_offset): Declare extern.
1588 Otherwise, these inline functions do not conform to C99 and
1589 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1590 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1591 * intervals.c (adjust_intervals_for_insertion)
1592 (adjust_intervals_for_deletion): Now extern, because otherwise the
1593 extern inline functions 'offset_intervals' couldn't refer to it.
1594 (static_offset_intervals): Remove.
1595 (offset_intervals): Rewrite using the old contents of
1596 static_offset_intervals. The old version didn't conform to C99
1597 because an extern inline function contained a reference to an
1598 identifier with static linkage.
1599
b7041366
AS
16002011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1603 GC.
1604
88a37c4d
EZ
16052011-11-06 Eli Zaretskii <eliz@gnu.org>
1606
1607 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1608 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1609 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1610 return Qleft_to_right.
1611
49745b39
CY
16122011-11-06 Chong Yidong <cyd@gnu.org>
1613
1614 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1615 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1616 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1617 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1618 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1619 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1620 (Fwindow_vscroll): Doc fix.
1621 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1622 argument, since it makes no sense to pass a live window and for
1623 consistency with window-child.
1624
1f05cd82
CS
16252011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1626
1627 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1628 support MSVC.
1629
22610910
JR
16302011-11-05 Jason Rumney <jasonr@gnu.org>
1631
1632 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1633 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1634 fonts (Bug#6029).
1635 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1636 bitwise arithmetic preventing use of unicode-sip and non-truetype
1637 opentype fonts.
1638
a06776b2
EZ
16392011-11-05 Eli Zaretskii <eliz@gnu.org>
1640
3ad924ba
EZ
1641 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1642 "emacs"-only part.
1643
a06776b2
EZ
1644 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1645 initialization code to keep similarity to xfns.c after changes
1646 from 2011-11-05.
1647
c9e7db78
JD
16482011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1649
a97f8f3f
JD
1650 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1651 (unwind_create_frame): New function (Bug#9943).
1652 (Fx_create_frame): Restructure code to be more similar to the one in
1653 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1654 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1655 Move terminal->reference_count++ just before making the frame official
1656 (Bug#9943).
1657
1658 * nsterm.m (x_free_frame_resources): New function.
1659 (x_destroy_window): Move code to x_free_frame_resources.
1660
c9e7db78 1661 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1662 (Fx_create_frame, x_create_tip_frame):
1663 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1664 official. Move initialization of image_cache_refcount and
1665 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1666
a6fc3b5c
EZ
16672011-11-05 Eli Zaretskii <eliz@gnu.org>
1668
1669 Support MSVC build with newer versions of Visual Studio.
1670 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1671 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1672 nt/gmake.defs.
1673
1674 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1675 which are not supported by MSVC.
1676 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1677 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1678 bitfields.
1679 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1680 types in bitfields.
1681 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1682
1683 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1684
58179cce 16852011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1686
1687 Support MSVC build with newer versions of Visual Studio.
1688 * w32.c: Don't include w32api.h for MSVC.
1689 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1690
1691 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1692 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1693 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1694 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1695 e_* cousins.
1696 (alloca) [_MSC_VER]: Define to _alloca.
1697
1698 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1699
1700 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1701
a58c13ed
EZ
17022011-11-04 Eli Zaretskii <eliz@gnu.org>
1703
1704 * xdisp.c (note_mouse_highlight): If either of
1705 previous/next-single-property-change returns nil, treat that as
1706 the beginning or the end of the buffer. (Bug#9955)
1707
fe0b6370
JD
17082011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1709
a58c13ed 1710 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1711 label is not null (Bug#9951).
1712 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1713 may be NULL.
1714
89bd5ee1
EZ
17152011-11-04 Eli Zaretskii <eliz@gnu.org>
1716
1717 * window.c (Fwindow_body_size): Mention in the doc string that the
1718 return value is in frame's canonical units. (Bug#9949)
1719
84c3edb9
EZ
17202011-11-03 Eli Zaretskii <eliz@gnu.org>
1721
4e2fb5c7
EZ
1722 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1723
84c3edb9 1724 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1725 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1726 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1727
bc17a887
EZ
17282011-11-01 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1731 Don't stop backward scan on the continuation glyph, even though
1732 its CHARPOS is positive.
6d5eb5b0
SM
1733 (mouse_face_from_buffer_pos, note_mouse_highlight):
1734 Rename cover_string to disp_string.
bc17a887 1735
4ee88440
MR
17362011-11-01 Martin Rudalics <rudalics@gmx.at>
1737
1738 * window.c (temp_output_buffer_show): Don't use
1739 Vtemp_buffer_show_specifiers.
1740 (Vtemp_buffer_show_specifiers): Remove unused variable.
1741
c2ff3c02
EZ
17422011-10-30 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1745 past the beginning of the current glyph matrix.
1746
58179cce 17472011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1748
1749 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1750 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1751 HAVE_GTK3 (Bug#9869).
b77a6a7f 1752
3b574623
JD
1753 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1754 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1755
b77a6a7f
JD
1756 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1757
1758 * xterm.c: Declare x_handle_net_wm_state to return int.
1759 (handle_one_xevent): Check if we are iconified but don't have
1760 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1761 (get_current_wm_state): Return non-zero if not hidden,
1762 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1763 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1764 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1765 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1766
196e41e4
PE
17672011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1770 so that this new function doesn't get optimized away by a
1771 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1772
021f2e1a
AS
17732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1774
1775 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1776
8b058d44
EZ
17772011-10-29 Eli Zaretskii <eliz@gnu.org>
1778
1779 Fix the `xbytecode' command.
1780 * .gdbinit (xprintbytestr): New command.
b50a28de 1781 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1782 (xbytecode): Print the byte-code string as well.
1783
4452fb80
EZ
17842011-10-29 Kim Storm <storm@cua.dk>
1785
8b058d44
EZ
1786 * alloc.c (which_symbols): New function.
1787
21b72067
AS
17882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1789
1790 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1791 line. (Bug#9903)
1792
83ed7b5c
GM
17932011-10-29 Glenn Morris <rgm@gnu.org>
1794
1795 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1796 Not clear what it was for, and it causes various bugs. (Bug#9839)
1797
5a7a728b
EZ
17982011-10-28 Eli Zaretskii <eliz@gnu.org>
1799
1800 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1801 possible random value that matches one of those tested as
1802 condition to clear the mouse face.
1803
d3d0842f
CY
18042011-10-28 Chong Yidong <cyd@gnu.org>
1805
1806 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1807
31b39d13
DN
18082011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1809
1810 * window.c (make_window): Initialize phys_cursor_on_p.
1811
9aba6043
SM
18122011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * lisp.h (struct Lisp_Symbol): Update comments.
1815
c20992f4
JB
18162011-10-28 Juanma Barranquero <lekktu@gmail.com>
1817
1818 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1819
db4f02f2
EZ
18202011-10-28 Eli Zaretskii <eliz@gnu.org>
1821
1822 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1823 <oslsachem@gmail.com> for helping to debug this.
1824
1825 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1826 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1827 (g_b_init_get_glyph_outline_w): New static variables.
1828 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1829 (GetGlyphOutlineW_Proc): New typedefs.
1830 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1831 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1832 New functions.
1833 (w32font_open_internal, compute_metrics):
1834 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1835 instead of calling the "wide" APIs directly.
1836
1837 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1838
1839 * w32.h (syms_of_w32font): Add prototype.
1840
87e68db4
JB
18412011-10-27 Juanma Barranquero <lekktu@gmail.com>
1842
1843 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1844 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1845 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1846 (Fmove_to_window_line): Doc fix.
1847
435c1d67
CY
18482011-10-27 Chong Yidong <cyd@gnu.org>
1849
1850 * process.c (make_process): Set gnutls_state to NULL.
1851
1852 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1853 non-NULL, regardless of GNUTLS_INITSTAGE.
1854 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1855 an error. Set process slots as soon as we allocate them.
1856
1857 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1858
9c6c6f49
CY
18592011-10-27 Chong Yidong <cyd@gnu.org>
1860
9aba6043
SM
1861 * gnutls.c (emacs_gnutls_deinit): New function.
1862 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1863 (Fgnutls_deinit, Fgnutls_boot): Use it.
1864
1865 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1866 (deactivate_process): Call emacs_gnutls_deinit.
1867
657d08d3
JB
18682011-10-27 Juanma Barranquero <lekktu@gmail.com>
1869
1870 * image.c (x_create_x_image_and_pixmap):
1871 * w32.c (sys_rename, w32_delayed_load):
1872 * w32font.c (fill_in_logfont):
1873 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1874
5430d399
JB
18752011-10-26 Juanma Barranquero <lekktu@gmail.com>
1876
1877 * w32fns.c (w32_default_color_map): New function,
1878 extracted from Fw32_default_color_map.
a7ef684b 1879 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1880
fe0055fa
PE
18812011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1884
e6346438
SM
18852011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1886
1887 * keyboard.c (test_undefined): New function (bug#9751).
1888 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1889
e112cc37
ET
18902011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1891
1892 * sysdep.c (init_sys_modes): Fix the check for the controlling
1893 terminal (Bug#6649).
1894
7b5d6677
EZ
18952011-10-20 Eli Zaretskii <eliz@gnu.org>
1896
1897 * dispextern.h (struct bidi_it): New member next_en_type.
1898
1899 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1900 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1901 current character, check also for next_en_type being WEAK_EN.
1902 (bidi_resolve_weak): Don't enter the expensive loop if the current
1903 position is before next_en_pos. Record the bidi type of the first
1904 non-ET, non-BN character we find, in addition to its position.
1905 (bidi_level_of_next_char): Invalidate next_en_type when
1906 next_en_pos is over-stepped.
1907
7da0b018
PE
19082011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1911 * editfns.c: Rewrite current-time-zone so that it invokes
1912 the equivalent of (format-time-string "%Z") to get the time zone name.
1913 This fixes a bug when the time zone name contains characters that
1914 need converting from the system time locale to Emacs internal format.
1915 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1916 that patch fixed format-time-string to do the conversion, but
1917 I forgot to fix current-time-zone.
1918 (format_time_string): New function, containing most of
1919 what Fformat_time_string used to contain.
1920 (Fformat_time_string): Rewrite in terms of format_time_string.
1921 This doesn't change this function's behavior.
1922 (current-time-zone): Rewrite to use format_time_string.
1923 This fixes the bug reported by Michael Schierl in
1924 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1925 Jason Rumney's 2007-06-07 change worked around this bug, but
1926 didn't fix it.
1927 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1928
8547b010
EZ
19292011-10-19 Eli Zaretskii <eliz@gnu.org>
1930
1931 * xdisp.c (start_display): If the character at POS is displayed
1932 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1933 (try_window_reusing_current_matrix): If a line ends in a display
1934 vector or the next line starts in a display vector, continue
1935 redrawing the window even though the character position of
1936 start_row was reached.
8547b010
EZ
1937 (Bug#9771, part 2)
1938
4e948d15
CY
19392011-10-18 Chong Yidong <cyd@gnu.org>
1940
1941 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1942 with nobreak-char-display too.
1943
4787455f
EZ
19442011-10-18 Eli Zaretskii <eliz@gnu.org>
1945
1946 Fix part 3 of bug#9771.
1947 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1948 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1949 non-neutral characters if the current character is a paragraph
1950 separator (a.k.a. Newline). This avoids running the same
1951 expensive loop twice, once when we consume the preceding newline
1952 and the other time when the line actually needs to be displayed.
1953 Avoid the loop when we see neutrals on the base embedding level
1954 following a character whose directionality is the same as the
1955 paragraph's. This avoids running the expensive loop when a line
1956 ends in a long sequence of neutrals, like control characters.
1957 Add assertion against STRONG_AL type. Slightly rearrange code
1958 that determines the type of a neutral given the first non-neutral
1959 that follows it.
1960 (bidi_level_of_next_char): Set next_en_pos to zero when
1961 invalidating its info.
1962
2c91f553
EZ
19632011-10-17 Eli Zaretskii <eliz@gnu.org>
1964
1965 * xdisp.c (push_display_prop): Determine whether to record string
1966 or buffer position by IT->string, not by IT->method. Allow
1967 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1968 (move_it_vertically_backward): Don't look for character position
1969 immediately after the newline when in a continuation line.
1970 (Bug#9771, part 1)
2c91f553 1971
c7b08b0d
MR
19722011-10-15 Martin Rudalics <rudalics@gmx.at>
1973
1974 * window.c (coordinates_in_window): Rewrite and delabelize
1975 vertical border check. (Bug#5357) (Bug#9618)
1976
6b02f655
SM
19772011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1978
1979 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1980 errors in XSetWindowBorder (bug#9310).
1981
81d40c92
DA
19822011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1983
1984 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1985 avoid crash when xmalloc overrun checking is enabled.
1986
d4172c3b
EZ
19872011-10-13 Eli Zaretskii <eliz@gnu.org>
1988
1989 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1990 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1991 cursor motion with <left> and <right> arrow keys.
1992
1993 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1994 some callers set that themselves.
1995
b00eea75
EZ
19962011-10-12 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1999 display string and the previous row comes from the same string and
2000 is empty. (Bug#9739) (Bug#9738)
2001
8fe012c4
SM
20022011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * doc.c (get_doc_string): Encode file name (bug#9735).
2005
0074aef2
EZ
20062011-10-12 Eli Zaretskii <eliz@gnu.org>
2007
79beb178
EZ
2008 * bidi.c (bidi_level_of_next_char):
2009 * xdisp.c (get_visually_first_element): Remove old incorrect
2010 comments regarding the Unicode Line Separator character.
2011
0074aef2
EZ
2012 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2013
6e4b3fbe
DA
20142011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2015
2016 * alloc.c (Fgc_status): Do not access beyond zombies array
2017 boundary if nzombies > MAX_ZOMBIES.
2018 * alloc.c (dump_zombies): Add missing format specifier.
2019
0324f3af
PE
20202011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2021
b5525cac
PE
2022 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2023 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2024
0324f3af
PE
2025 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2026 Some packages use them to denote characters with modifiers.
2027
e9b5f888
AS
20282011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2029
2030 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2031 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2032 matching a pp-number. Rename parameter var to var1.
2033
127827c0
SM
20342011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2035
2036 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2037
c8fd3bd0
GM
20382011-10-08 Glenn Morris <rgm@gnu.org>
2039
2040 * callint.c (Fcall_interactively): Give a more explicit error for the
2041 'c' case with a non-character input. (Bug#8479)
2042
352ec8ff
EZ
20432011-10-08 Eli Zaretskii <eliz@gnu.org>
2044
03669ccb
EZ
2045 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2046 lines.
7061c986
EZ
2047 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2048 lines that are hscrolled on the left.
03669ccb 2049
352ec8ff
EZ
2050 * dispnew.c (buffer_posn_from_coords): Account for a possible
2051 presence of header-line. (Bug#4426)
2052
a66cfb1c
SM
20532011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2054
6b02f655
SM
2055 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2056 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2057
7c5ee88e
PE
20582011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2061 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2062 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2063 this makes Emacs dump core during garbage collection on rare
2064 occasions. sizeof is obviously inferior to offsetof here, so
2065 stick with offsetof.
2066 (GC_POINTER_ALIGNMENT): New macro.
2067 (mark_memory): Omit 3rd (offset) arg; caller changed.
2068 Don't assume EMACS_INT alignment is the same as pointer alignment.
2069
df1bbe5b
SM
20702011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2071
2072 * keyboard.c (read_key_sequence_remapped): New var.
2073 (read_key_sequence): Compute remapping in the right buffer.
2074 (command_loop_1): Use read_key_sequence's remapping directly.
2075
51553db6
SM
20762011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2077
32c1fffd
SM
2078 * dired.c (file_name_completion): Don't expand file name.
2079 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2080 before checking file name handler.
2081
51553db6
SM
2082 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2083 they've been requested explicitly (bug#9591).
2084
b6bd1599 20852011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2086
2087 * keymap.c (Fsingle_key_description): Use make_specified_string
2088 instead of build_string to build string from push_key_description.
2089 (Bug#5193)
2090
f701dc2a
PE
20912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2092
4222c55d
PE
2093 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2094 This fixes a Y2038 bug on 64-bit hosts.
2095 * buffer.c (reset_buffer):
2096 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2097 (Fclear_buffer_auto_save_failure):
2098 Use 0, not -1, to represent an unset failure time, since time_t
2099 might not be signed.
2100
f701dc2a
PE
2101 Remove dependency on glibc malloc internals.
2102 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2103 Move back here from lisp.h, but with their new implementations.
2104 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2105 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2106 * charset.c (charset_table_init): New static var.
2107 (syms_of_charset): Use it instead of xmalloc. This removes a
2108 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2109 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2110 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2111 Move back to alloc.c.
2112 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2113 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2114
9ceebf39
JD
21152011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2116
2117 * nsterm.m (windowDidResize): Call x_set_window_size only when
2118 ns_in_resize is true. Otherwise set pixelwidth/height and
2119 call change_frame_size (Bug#9628).
2120
cb993c58
PE
21212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2122
3930c88b
PE
2123 Port --enable-checking=all to Fedora 14 x86-64.
2124 * charset.c (syms_of_charset): Also account for glibc malloc's
2125 internal overhead when calculating the initial malloc maximum.
2126
cb993c58
PE
2127 Port --enable-checking=all to Fedora 14 x86.
2128 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2129 Move to lisp.h.
2130 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2131 (overrun_check_realloc, overrun_check_free):
2132 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2133 That way, xmalloc returns a properly-aligned pointer even if
2134 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2135 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2136 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2137 into account when calculating the initial malloc maximum.
2138 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2139 Move here from alloc.c, so that charset.c can use it too.
2140 Properly align; the old code wasn't right for common 32-bit hosts
2141 when configured with --enable-checking=all.
2142 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2143 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2144
31bed486
EZ
21452011-09-29 Eli Zaretskii <eliz@gnu.org>
2146
04c70788 2147 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2148 use EDOM.
2149
fbcaa2f3
EZ
21502011-09-28 Eli Zaretskii <eliz@gnu.org>
2151
2152 * xdisp.c (compute_display_string_end): If there's no display
2153 string at CHARPOS, return -1.
2154
2155 * bidi.c (bidi_fetch_char): When compute_display_string_end
2156 returns a negative value, treat the character as a normal
2157 character not covered by a display string. (Bug#9624)
2158
a239d4e9
JB
21592011-09-28 Juanma Barranquero <lekktu@gmail.com>
2160
2161 * lread.c (Fread_from_string): Fix typo in docstring.
2162
88652fd5
EZ
21632011-09-27 Eli Zaretskii <eliz@gnu.org>
2164
2165 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2166 newline, reseat the iterator instead of bidi-iterating there one
2167 character at a time. (Bug#9610)
32c1fffd
SM
2168 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2169 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2170
ed497dd4
AS
21712011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2172
2173 * lread.c (readevalloop): Use correct code for NBSP.
2174 (read1): Likewise. (Bug#9608)
2175
b2bf61aa
MA
21762011-09-25 Michael Albinus <michael.albinus@gmx.de>
2177
2178 * dbusbind.c (Fdbus_register_signal): When service is not
2179 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2180
32bbb17c
GM
21812011-09-25 Glenn Morris <rgm@gnu.org>
2182
2183 * buffer.c (truncate-lines): Doc fix.
2184
94e0933e
CY
21852011-09-24 Chong Yidong <cyd@stupidchicken.com>
2186
2187 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2188 (Fset_window_next_buffers): Doc fix.
2189
cddde921
GM
21902011-09-24 Glenn Morris <rgm@gnu.org>
2191
2192 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2193
1260aef1
PE
21942011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2195
25b4bfa0
PE
2196 Fix minor problems found by static checking.
2197 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2198 * indent.c (Fvertical_motion): Fix == vs = typo.
2199
e3cbd34b
EZ
22002011-09-24 Eli Zaretskii <eliz@gnu.org>
2201
a66cfb1c
SM
2202 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2203 Default value is now t. Doc fix.
6bf7006f 2204
e3cbd34b 2205 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2206 logic when moving up, not only when moving down. Fix the
e3cbd34b 2207 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2208 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2209
2210 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2211 CHARPOS is covered by a display string which includes newlines.
2212 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2213 is covered by a display string with embedded newlines.
2214
a3de0cbd
MA
22152011-09-24 Michael Albinus <michael.albinus@gmx.de>
2216
2217 * dbusbind.c (Fdbus_register_signal): Add match rule to
2218 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2219 (Fdbus_register_method, Vdbus_registered_objects_table):
2220 Fix docstring.
a3de0cbd 2221
b260039d
JM
22222011-09-24 Jim Meyering <meyering@redhat.com>
2223
32c1fffd 2224 do not ignore write error for any output size
b260039d
JM
2225 The previous change was incomplete.
2226 While it makes emacs --batch detect the vast majority of stdout
2227 write failures, errors were still ignored whenever the output size is
2228 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2229 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2230 && echo FAIL: ignored write error
2231 FAIL: ignored write error
2232 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2233 && echo FAIL: ignored write error
2234 FAIL: ignored write error
2235 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2236
8eca8a7c
AS
22372011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2238
2239 * emacs.c (Fkill_emacs): In noninteractive mode exit
2240 non-successfully if a write error occurred on stdout. (Bug#9574)
2241
3341db62
EZ
22422011-09-21 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2245 the xassert test.
2246
2247 * dispextern.h (struct it): Update the comment documenting what
2248 can it->OBJECT be.
2249
8c203dbf
EZ
22502011-09-20 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2253 a display string, extend search for cursor position to end of row.
2254 (find_row_edges): If the row ends in a newline from a display
2255 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2256 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2257 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2258 non-empty line. Fixes confusing cursor motion with arrow keys at
2259 the beginning of a line that starts with whitespace.
8c203dbf 2260
a4824228
LMI
22612011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2262
2263 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2264 (bug#9493).
2265
33ed493b
CY
22662011-09-18 Chong Yidong <cyd@stupidchicken.com>
2267
2268 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2269 boolean (Bug#9154).
2270
56cd55c8
EZ
22712011-09-18 Eli Zaretskii <eliz@gnu.org>
2272
2273 * xdisp.c (display_line): Record maximum and minimum buffer
2274 positions even if no glyphs were produced (e.g., by a zero-width
2275 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2276 buffer positions that will be removed from the glyph row because
2277 they don't fit.
c02dcedf
EZ
2278 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2279 column is beyond frame width: don't subtract 1 "pixel" when
2280 computing width of the stretch.
3e62b7e0
EZ
2281 (reseat_at_next_visible_line_start): Undo the change made on
2282 2011-09-17 that saved paragraph information and restored it after
2283 the call to `reseat'. (Bug#9545)
56cd55c8 2284
5ed99d36 22852011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2286
2287 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2288 and turn window cursor on if cleared (Bug#9415).
2289
5ed99d36 22902011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2291
2292 * search.c (boyer_moore): Take unibyte characters from pattern
2293 literally. (Bug#9458)
2294
9bade7b2
EZ
22952011-09-18 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2298
e5e9d610
PE
22992011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2300
87e4427a
PE
2301 Fix minor problem found by static checking.
2302 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2303 initialized, to pacify gcc -Wuninitialized.
2304
e5e9d610
PE
2305 * fileio.c: Report proper errno when syscall falls.
2306 (Finsert_file_contents): Save and restore errno,
2307 so that report_file_error outputs the correct diagnostic.
2308 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2309
a1674f0b
EZ
23102011-09-18 Eli Zaretskii <eliz@gnu.org>
2311
2312 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2313
fbfb6dd4
EZ
23142011-09-17 Eli Zaretskii <eliz@gnu.org>
2315
2316 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2317 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2318
bb187662
EZ
23192011-09-17 Eli Zaretskii <eliz@gnu.org>
2320
1137e8b8 2321 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2322 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2323
2324 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2325 (bidi_find_paragraph_start): Search back for paragraph beginning
2326 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2327 (bidi_move_to_visually_next): Only trigger paragraph-related
2328 computations when the last character is a newline or at EOB, not
2329 just any NEUTRAL_B. (Bug#9470)
2330
bb187662
EZ
2331 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2332 truncated lines if point is covered by a display string. (Bug#9524)
2333
2e621251
PE
23342011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2337 (cons_to_x_long): New function.
2338 (lisp_data_to_selection_data): Use it. Correct the test for
2339 short-versus-long data; it was negated. Break out of vector
2340 loop, for efficiency, when a long datum is discovered.
2341
91a15bc6
SM
23422011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2343
2344 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2345
b41c3a35
EZ
23462011-09-16 Eli Zaretskii <eliz@gnu.org>
2347
2348 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2349 GCC PR/17406) by declaring this function with external scope.
2350
7812ba2d
PE
23512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2352
2353 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2354 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2355
cf7edc2a
AS
23562011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2357
2358 * editfns.c (Fformat): Correctly handle text properties on "%%".
2359
bd01620e
EZ
23602011-09-15 Eli Zaretskii <eliz@gnu.org>
2361
2362 * xterm.c (x_draw_composite_glyph_string_foreground):
2363 * w32term.c (x_draw_composite_glyph_string_foreground):
2364 * term.c (encode_terminal_code):
2365 * composite.c (composition_update_it, get_composition_id):
2366 * xdisp.c (get_next_display_element)
2367 (fill_composite_glyph_string): Add comments about special meaning
2368 of TAB characters in a composition.
2369
a02719a3
PE
23702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2373 This occurs when processing a multibyte format.
2374 Problem reported by Wolfgang Jenker.
a02719a3 2375
72589a3c
JB
23762011-09-15 Johan Bockgård <bojohan@gnu.org>
2377
2378 * xdisp.c (try_cursor_movement): Only check for exact match if
2379 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2380
1c14176c
PE
23812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 Remove unused external symbols.
2384 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2385 * xdisp.c (calc_pixel_width_or_height): Now static.
2386 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2387 * indent.c (check_display_width):
2388 * w32term.c: Fix comment to match code.
2389 * xterm.c, xterm.h (x_catching_errors): Remove.
2390
d2eea5b5
PE
23912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * xselect.c: Use signed conversions more consistently (Bug#9498).
2394 (selection_data_to_lisp_data): Assume incoming selection data are
2395 signed integers, not unsigned. This is to be consistent with
2396 outgoing selection data, which was modified to use signed integers
2397 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2398 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2399 expects long, not unsigned long.
2400
46888499
EZ
24012011-09-14 Eli Zaretskii <eliz@gnu.org>
2402
2403 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2404 computation of loop end. Reported by Johan Bockgård
2405 <bojohan@gnu.org>.
2406
ef8ef9fb
CY
24072011-09-13 Chong Yidong <cyd@stupidchicken.com>
2408
2409 * frame.c (Fother_visible_frames_p): Function deleted.
2410
fa819fed
EZ
24112011-09-12 Eli Zaretskii <eliz@gnu.org>
2412
2413 * indent.c (compute_motion): Process display vector front to back
2414 rather than the other way around. (Bug#2496)
2415
2ba8e008
SM
24162011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2417
2418 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2419
20f53c69
CY
24202011-09-11 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * minibuf.c (Fread_from_minibuffer): Doc fix.
2423
d562d7a4
EZ
24242011-09-11 Eli Zaretskii <eliz@gnu.org>
2425
2426 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2427 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2428
1c4d7f3d
LMI
24292011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2430
2431 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2432 value for non-existent files.
2433
b885bf36
EZ
24342011-09-11 Eli Zaretskii <eliz@gnu.org>
2435
2436 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2437 set its "size" to -1. This will set the modtime_size field of
2438 the corresponding buffer to -1, which is what
2439 verify-visited-file-modtime expects for files that do not exist.
2440 (Bug#9139)
2441
6612f0bf
PE
24422011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2445 here ...
2446 * lisp.h: ... from here. push_key_description is no longer
2447 defined in keyboard.c, so its declaration should not be in
2448 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2449 logically belongs with push_key_description.
2450
dfb3f755
PE
24512011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * buffer.h: Include <sys/types.h> instead of <time.h>.
2454 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2455 Problem reported by Herbert J. Skuhra.
2456
3134906c
LMI
24572011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2458
2459 * xml.c (parse_region): Make the parsing work for
2460 non-comment-starting XML files again (bug#9144).
2461
8d903f4e
AS
24622011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * image.c (gif_load): Fix calculation of bottom and right corner.
2465 (Bug#9468)
2466
80ad64f4
EZ
24672011-09-10 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2470 redisplay in small windows.
2471
208a048d
EZ
24722011-09-09 Eli Zaretskii <eliz@gnu.org>
2473
2474 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2475
9b1c252e
MR
24762011-09-08 Martin Rudalics <rudalics@gmx.at>
2477
2478 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2479 Operate on live windows only.
2480
2949f33b
JB
24812011-09-08 Juanma Barranquero <lekktu@gmail.com>
2482
2483 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2484
e08dcafd
EZ
24852011-09-07 Eli Zaretskii <eliz@gnu.org>
2486
2487 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2488 only under bidi iteration.
2489
115b96bd
JD
24902011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2491
2492 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2493
c8199d0f
PE
24942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2495
2496 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2497 Without this fix, the command to link temacs failed due to an
2498 undefined symbol __builtin_isnan. This is because
2499 /usr/include/iso/math_c99.h #defines isnan(x) to
2500 __builtin_isnan(x), but the bundled gcc, which identifies itself
2501 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2502 a __builtin_isnan.
2503 * floatfns.c (isnan): #undef, and then #define to a clone of
2504 what's in data.c.
2505 (Fisnan): Always define, since it's always available now.
2506 (syms_of_floatfns): Always define isnan at the Lisp level.
2507
e39b275c 25082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2509
2510 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2511
b2db44d9 25122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2513
f4af5137 2514 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2515 The previous code assumed that file offsets (off_t values) fit in
2516 EMACS_INT variables, which is not true on typical 32-bit hosts.
2517 The code messed up by falsely reporting buffer overflow in cases
2518 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2519 when "big" contains more than 2**29 bytes, even though this
2520 inserts just one byte and does not overflow the buffer.
2521 (Finsert_file_contents): Store file offsets as off_t
2522 values, not as EMACS_INT values. Check for overflow when
2523 converting between EMACS_INT and off_t. When checking for
2524 buffer overflow or for overlap, take the offsets into account.
2525 Don't use EMACS_INT for small values where int suffices.
2526 When checking for overlap, fix a typo: ZV was used where
2527 ZV_BYTE was intended.
2528 (Fwrite_region): Don't assume off_t fits into 'long'.
2529 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2530
ecfc0a49
MA
25312011-09-05 Michael Albinus <michael.albinus@gmx.de>
2532
2533 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2534
6511acf2 25352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2536
0999621a 2537 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2538
2539 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2540 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2541 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2542 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2543 (modify_event_symbol): Do not assume that the length of
2544 name_alist_or_stem is safe to alloca and fits in int.
2545 (Fexecute_extended_command): Likewise for function name and binding.
2546 (Frecursion_depth): Wrap around reliably on integer overflow.
2547 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2548 since some callers pass EMACS_INT values.
2549 (Fsingle_key_description): Don't crash if symbol name contains more
2550 than MAX_ALLOCA bytes.
2551 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2552 (get_minibuffer): Arg is now EMACS_INT, not int.
2553 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2554 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2555 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2556
2be7d702
PE
2557 * dbusbind.c (signature_cat): New function.
2558 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2559 Do not overrun buffer; instead, report string overflow.
2560
9d1df220
PE
2561 * dispnew.c (add_window_display_history): Don't overrun buffer.
2562 Truncate instead; this is OK since it's just a log.
2563
33ef5c64
PE
2564 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2565 even if the time zone offset is outlandishly large.
2566 Don't mishandle offset == INT_MIN.
2567
66c6fdd5
PE
2568 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2569 when creating daemon; the previous buffer-overflow check was incorrect.
2570
d749b01b
PE
2571 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2572 which has the guts of the old verror function.
2573
b5cd1905
PE
2574 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2575 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2576
6e1a67fb
PE
2577 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2578 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2579 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2580 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2581 length of string rather than counting it via multiple sprintfs;
2582 that's simpler and more reliable.
c21721cc
PE
2583 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2584 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2585 sprintf, in case result does not fit in int.
2586
c57b67fc
PE
2587 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2588 (fontset_from_font): Print it.
2589
8a401434
PE
2590 * frame.c (tty_frame_count): Now printmax_t, not int.
2591 (make_terminal_frame, set_term_frame_name): Print it.
2592 (x_report_frame_params): In X, window IDs are unsigned long,
2593 not signed long, so print them as unsigned.
2594 (validate_x_resource_name): Check for implausibly long names,
2595 and don't assume name length fits in 'int'.
2596 (x_get_resource_string): Don't blindly alloca invocation name;
2597 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2598 not fit in int.
2599
6e1a67fb
PE
2600 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2601 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2602 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2603
0df02bf3
PE
2604 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2605 Use esprintf, not sprintf, in case result does not fit in int.
2606
48e30793
PE
2607 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2608 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2609 it as a large positive number.
2610 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2611 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2612
a66ff6d8
PE
2613 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2614 in case result does not fit in int.
2615
aca216ff
PE
2616 * print.c (float_to_string): Detect width overflow more reliably.
2617 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2618 buffer overrun. Don't assume list length fits in 'int'. Treat
2619 print length of 0 as 0, not as infinity; to be consistent with other
2620 uses of print length in this function. Don't overflow print length
2621 index. Don't assume hash table size fits in 'long', or that
2622 vectorlike size fits in 'unsigned long'.
2623
31c286f7
PE
2624 * process.c (make_process): Use printmax_t, not int, to format
2625 process-name gensyms.
2626
55e5faa1
PE
2627 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2628
80f2e268
PE
2629 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2630 to avoid potential buffer overrun.
2631
670741ab
PE
2632 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2633 if X resource line is longer than 512 bytes.
2634
b7163a50
PE
2635 * xfns.c (x_window): Make sprintf buffer a bit bigger
2636 to avoid potential buffer overrun.
2637
ae58ff1f
PE
2638 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2639
c43c8a6a
PE
2640 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2641
3f8236f4
PE
26422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2643
53e9fe90 2644 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2645 Without these, Emacs silently mishandles large integers sometimes.
2646 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2647 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2648
6511acf2
PE
2649 * xdisp.c (try_window_id): Check Emacs fixnum range before
2650 converting to 'int'.
806add1d 2651
6511acf2 2652 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2653 Check that an Emacs fixnum is in range before assigning it to 'int'.
2654 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2655 values converted from Emacs fixnums.
2656 (Frecenter): Don't wrap around a line count if it is out of 'int'
2657 range; instead, treat it as an extreme value.
2658 (Fset_window_configuration, compare_window_configurations):
2659 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2660
6511acf2
PE
2661 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2662 that can exceed INT_MAX. Check that EMACS_INT value is in range
2663 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2664 (match_limit): Don't assume that a fixnum can fit in 'int'.
2665
6511acf2 2666 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2667 exceed INT_MAX.
2668
6511acf2 2669 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2670 (Fvertical_motion): Don't wrap around LINES values that don't fit
2671 in 'int'. Instead, treat them as extreme values. This is good
2672 enough for windows, which can't have more than INT_MAX lines anyway.
2673
fcb901a7
LMI
26742011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2675
0f2f6b6d
LMI
2676 * Require libxml/parser.h to avoid compilation warning.
2677
fcb901a7
LMI
2678 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2679
2680 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2681 since this reportedly can destroy thread storage.
2682
6e20a0d4
CY
26832011-08-30 Chong Yidong <cyd@stupidchicken.com>
2684
2685 * syntax.c (find_defun_start): Update all cache variables if
2686 exiting early (Bug#9401).
2687
148ae00e
EZ
26882011-08-30 Eli Zaretskii <eliz@gnu.org>
2689
f6cfbd8f
EZ
2690 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2691
148ae00e
EZ
2692 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2693 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2694 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2695
2696 * term.c (tty_append_glyph): New function.
2697 (produce_stretch_glyph): Static function and its prototype deleted.
2698
a66cfb1c
SM
2699 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2700 Add prototypes.
148ae00e 2701
c4a07a4c
PE
27022011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2705 when checking :margin (Bug#9390).
2706 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2707 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2708 so that the name doesn't mislead. All uses changed.
2709
6bc8cd65
JB
27102011-08-28 Johan Bockgård <bojohan@gnu.org>
2711
2712 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2713 set_tty_hooks.
2714
dca4927e
EZ
27152011-08-27 Eli Zaretskii <eliz@gnu.org>
2716
2717 * xdisp.c (move_it_to): Don't bail out early when reaching
2718 position beyond to_charpos, if we are scanning backwards.
2719 (move_it_vertically_backward): When DY == 0, make sure we get to
2720 the first character in the line after the newline.
2721
f2cad773
PE
27222011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2725 (ccl_driver): Do not generate an out-of-range pointer.
2726 (Fccl_execute_on_string): Remove unnecessary check for
2727 integer overflow, noted by Stefan Monnier in
2728 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2729 Remove a FIXME that didn't need fixing.
2730 Simplify the newly-introduced buffer reallocation code.
2731
0cae2cdb
JB
27322011-08-27 Juanma Barranquero <lekktu@gmail.com>
2733
2734 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2735
5fc295a4 27362011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2737
70c60eb2 2738 Integer and memory overflow issues (Bug#9196).
726e0ab1 2739
d31850da
PE
2740 * doc.c (get_doc_string): Rework so that
2741 get_doc_string_buffer_size is the actual buffer size, rather than
2742 being 1 less than the actual buffer size; this makes xpalloc more
2743 convenient.
2744
a69fbedb
PE
2745 * image.c (x_allocate_bitmap_record, cache_image):
2746 * xselect.c (Fx_register_dnd_atom):
2747 Simplify previous changes by using xpalloc.
2748
fe5c5d37
PE
2749 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2750 since either will do and ptrdiff_t is convenient with xpalloc.
2751
0065d054
PE
2752 * charset.c (charset_table_size)
2753 (struct charset_sort_data.priority): Now ptrdiff_t.
2754 (charset_compare): Don't overflow if priorities differ greatly.
2755 (Fsort_charsets): Don't assume list length fits in int.
2756 Check for size-calculation overflow when allocating sort data.
2757 (syms_of_charset): Allocate an initial charset table that is
2758 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2759
2760 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2761
2762 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2763 The actual value is always <= INT_MAX, and leaving it unsigned made
2764 overflow checking harder.
2765
2766 * dispextern.h (struct glyph_matrix.rows_allocated)
2767 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2768 with xpalloc. The values are still always <= INT_MAX.
2769
2770 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2771
2772 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2773 (SAFE_NALLOCA): New macro.
2774
2775 * region-cache.c (struct boundary.pos, find_cache_boundary)
2776 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2777 (set_cache_region, invalidate_region_cache)
2778 (revalidate_region_cache, know_region_cache, region_cache_forward)
2779 (region_cache_backward, pp_cache):
2780 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2781 so that ptrdiff_t * can be passed to xpalloc.
2782 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2783 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2784 (pp_cache): Don't assume cache_len fits in int.
2785 * region-cache.h: Adjust extern decls to match.
2786
2787 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2788 EMACS_INT, since either will do, for xpalloc.
2789
2790 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2791 (xnmalloc, xnrealloc, xpalloc): New functions.
2792
726e0ab1
PE
2793 * bidi.c (bidi_shelve_header_size): New constant.
2794 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2795 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2796
51f30bc5 2797 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2798 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2799 (overlay_strings):
2800 Don't update size of array until after memory allocation succeeds,
2801 because xmalloc/xrealloc may not return.
0065d054
PE
2802 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2803 now that we have proper integer overflow checking.
2804 (record_overlay_string, overlay_strings): Catch overflows when
2805 calculating size of overlay_str_buf.
726e0ab1 2806
0065d054
PE
2807 * callproc.c (Fcall_process): Check for size overflow when
2808 calculating size of args2.
2809 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2810 Normally we prefer signed values, but sticking with ptrdiff_t would
2811 require adding more-complicated checks.
726e0ab1
PE
2812
2813 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2814 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2815 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2816 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2817
2818 * character.c (Fstring): Check for size-calculation overflow.
2819
2820 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2821 unnecessary integer overflow. Check for size overflow.
2822 (encode_coding_object): Don't update size until xmalloc succeeds.
2823
2824 * composite.c (get_composition_id): Check for overflow in glyph
2825 length calculations.
2826
2827 Integer and memory overflow fixes for display code.
2828 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2829 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2830 (scrolling_window): Check for overflow in size calculations.
2831 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2832 Don't assume glyph table len fits in int.
2833 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2834 (row_table_size): Now ptrdiff_t, not int.
2835 (scrolling_window): Avoid overflow in size calculations.
2836 Don't update size until allocation succeeds.
2837 * fns.c (concat): Check for overflow in size calculations.
2838 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2839 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2840 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2841
2842 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2843 (get_doc_string): Check for size calculation overflow.
2844 Don't update size until allocation succeeds.
2845 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2846 EMACS_INT, where ptrdiff_t will do.
2847 (Fsubstitute_command_keys): Check for string overflow.
2848
2849 * editfns.c (set_time_zone_rule): Don't assume environment length
2850 fits in int.
2851 (message_length): Now ptrdiff_t, not int.
2852 (Fmessage_box): Don't update size until allocation succeeds.
2853 Don't assume message length fits in int.
2854 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2855
0065d054
PE
2856 * emacs.c (main): Do not reallocate argv, since there is a null at
2857 the end that can be overwritten, and this way there's no need to
2858 worry about size-calculation overflow.
2859 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2860
2861 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2862 alloc succeeds.
2863 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2864
2865 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2866 (x_set_scroll_bar_width, x_figure_window_size):
2867 Check for integer overflow.
2868 (x_set_alpha): Do not assume XINT fits in int.
2869
2870 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2871 This is for the members text_lines, text_cols, total_lines, total_cols,
2872 where the system imposes an 'int' limit.
2873
2874 * fringe.c (Fdefine_fringe_bitmap):
2875 Don't update size until alloc works.
2876
2877 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2878 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2879
2880 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2881 Check for size-calculation overflow.
2882 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2883 do, as we prefer signed integers.
2884 (id_to_widget.max_size, id_to_widget.used)
2885 (xg_store_widget_in_map, xg_remove_widget_from_map)
2886 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2887 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2888 Use and return ptrdiff_t, not int.
2889 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2890 * gtkutil.h: Change prototypes to match the above.
2891
2892 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2893 are duplicate now that they've been promoted to lisp.h.
2894 (x_allocate_bitmap_record, x_alloc_image_color)
2895 (make_image_cache, cache_image, xpm_load):
2896 Don't update size until alloc is done.
2897 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2898 (x_detect_edges):
3256efce 2899 Check for size calculation overflow.
726e0ab1
PE
2900 (ct_colors_allocated_max): New constant.
2901 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2902 overflow.
3256efce 2903
726e0ab1
PE
2904 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2905 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2906 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2907 Use ptrdiff_t, not int, to count maps.
2908 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2909 calculations. Don't update size until allocation succeeds.
2910 Redo calculations to avoid overflow.
726e0ab1
PE
2911 * keyboard.h: Change prototypes to match the above.
2912
2913 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2914 to count maps.
2915 (current_minor_maps): Check for size calculation overflow.
2916 * keymap.h: Change prototypes to match the above.
2917
2918 * lread.c (read1, init_obarray): Don't update size until alloc done.
2919
2920 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2921 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2922
726e0ab1
PE
2923 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2924 Now ptrdiff_t, not int.
2925 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2926 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2927
2928 * process.c (Fnetwork_interface_list): Check for overflow
2929 in size calculation.
2930
2931 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2932
2933 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2934 overflow. Don't bother calling xmalloc when xrealloc will do.
2935
2936 * search.c (Freplace_match): Check for size calculation overflow.
2937 (Fset_match_data): Don't assume list lengths fit in 'int'.
2938
2939 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2940 for command line length. Do not attempt to address one before the
2941 beginning of an array, as that's not portable.
2942
2943 * term.c (max_frame_lines): Remove; unused.
2944 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2945 not int.
2946 (encode_terminal_code, calculate_costs): Check for size
2947 calculation overflow.
2948 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2949 table lengths and related sizes. Don't update size until alloc
2950 done. Redo calculations to avoid overflow.
2951 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2952
2953 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2954 subtracting pointers.
2955 (gobble_line): Check for overflow more carefully. Don't update size
2956 until alloc done.
2957
2958 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2959 Don't update size until alloc done.
2960 Redo size calculations to avoid overflow.
2961 Check for size calculation overflow.
0065d054 2962 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2963
2964 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2965 Use ptrdiff_t, not int, for sizes.
2966 (store_mode_line_noprop_char): Don't update size until alloc done.
2967
0065d054
PE
2968 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2969 Use ptrdiff_t, not int, for sizes.
2970 (Finternal_make_lisp_face, cache_face):
2971 Check for size calculation overflow.
2972 (cache_face): Treat size calculation overflows as if they were
2973 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2974
2975 * xfns.c (x_encode_text, x_set_name_internal)
2976 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2977 sizes, since they can exceed INT_MAX in size. Check for size
2978 calculation overflow.
2979
0065d054
PE
2980 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2981 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2982 Don't update size until alloc done.
2983
0065d054 2984 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2985 as sprintf is limited to int lengths.
1d526e2f 2986
252c5ee1
PE
2987 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2988 (X_LONG_MIN): New macros.
864d7ce7
PE
2989 Use them to make the following changes clearer.
2990 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2991 This change doesn't affect the value now, but it may help remind
2992 future maintainers not to raise the value too much later.
2993 (SELECTION_QUANTUM): Remove, replacing with ...
2994 (selection_quantum): ... new function, which avoids overflow.
2995 All uses changed.
2996 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2997 assumption that selection length fits in 'int'.
2998 (x_reply_selection_request, x_handle_selection_request)
2999 (x_get_window_property, receive_incremental_selection)
3000 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3001 (lisp_data_to_selection_data, clean_local_selection_data):
3002 Use ptrdiff_t, not int, to record length of selection.
3003 (x_reply_selection_request, x_get_window_property)
3004 (receive_incremental_selection, x_property_data_to_lisp):
3005 Redo calculations to avoid overflow.
3006 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3007 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3008 something.
3009 (x_get_window_property, receive_incremental_selection)
3010 (lisp_data_to_selection_data, x_property_data_to_lisp):
3011 Check for size-calculation overflow.
3012 (x_get_window_property, receive_incremental_selection)
3013 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3014 Don't store size until memory allocation succeeds.
3015 (x_get_window_property): Plug memory leak on memory exhaustion.
3016 Don't double-block input; malloc is safe here. Don't assume 2**34
3017 - 4 fits in unsigned long. Add an xassert to check
3018 XGetWindowProperty overflow. Be more careful about overflow
3019 calculations, and distinguish size from memory overflow better.
3020 (receive_incremental_selection): When tracing, don't assume
3021 unsigned int is less than INT_MAX.
3022 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3023 harmful) conversions of unsigned short to int.
3024 (lisp_data_to_selection_data): Don't assume that integers
3025 in the range -65535 through -1 fit in an X unsigned short.
3026 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3027 result parameters unless successful. Rely on cons_to_unsigned
3028 to report problems with elements; the old code wasn't right anyway.
3029 (x_check_property_data): Check for int overflow; we cannot use
3030 a wider type due to X limits.
3031 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3032
726e0ab1 3033 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3034
0065d054
PE
3035 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3036 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3037 (x_color_cells): Don't store size until memory allocation succeeds.
3038 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3039 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3040 (x_term_init): Don't assume length fits in int (sprintf is limited
3041 to int size).
bc18e09d 3042
ebfa62c0
PE
3043 Use ptrdiff_t for composition IDs.
3044 * character.c (lisp_string_width):
3045 * composite.c (composition_table_size, n_compositions)
3046 (get_composition_id, composition_gstring_from_id):
3047 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3048 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3049 * window.c (Frecenter):
3050 Use ptrdiff_t, not int, for composition IDs.
3051 * composite.c (get_composition_id): Check for integer overflow.
3052 * composite.h: Adjust prototypes to match the above changes.
3053
d3411f89
PE
3054 Use ptrdiff_t for hash table indexes.
3055 * category.c (hash_get_category_set):
3056 * ccl.c (ccl_driver):
3057 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3058 * coding.c (coding_system_charset_list, detect_coding_system):
3059 * coding.h (struct coding_system.id):
3060 * composite.c (get_composition_id, gstring_lookup_cache):
3061 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3062 * image.c (xpm_get_color_table_h):
3063 * lisp.h (hash_lookup, hash_put):
3064 * minibuf.c (Ftest_completion):
3065 Use ptrdiff_t for hash table indexes, not int (which is too
3066 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3067 32-bit --with-wide-int hosts).
3068
e097a6fa
PE
3069 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3070 Add a FIXME comment about memory leaks.
3071 (syms_of_charset): Don't assume xmalloc returns.
3072
5637687f
PE
3073 Don't assume that stated character widths fit in int.
3074 * character.c (Fchar_width, c_string_width, lisp_string_width):
3075 * character.h (CHAR_WIDTH):
3076 * indent.c (MULTIBYTE_BYTES_WIDTH):
3077 Use sanitize_char_width to avoid undefined and/or bad behavior
3078 with outlandish widths.
a66cfb1c 3079 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3080 now that we have two such functions. All uses changed.
3081 (sanitize_char_width): New inline function.
3082
a2271ba2
PE
3083 Don't assume that tab-width fits in int.
3084 * character.h (sanitize_width): New inline function.
3085 (SANE_TAB_WIDTH): New macro.
3086 (ASCII_CHAR_WIDTH): Use it.
3087 * indent.c (sane_tab_width): Remove. All uses replaced by
3088 SANE_TAB_WIDTH (current_buffer).
3089 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3090
18c52557
PE
3091 * fileio.c: Integer overflow issues with file modes.
3092 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3093
caeeedc1
PE
3094 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3095 Remove unreachable code.
3096 (read_hex, load_charset_map_from_file): Check for integer overflow.
3097
6df6ae42 3098 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3099 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3100 (x_send_scroll_bar_event): Likewise. Check that the size does not
3101 exceed limits imposed by XClientMessageEvent, as well as the usual
3102 ptrdiff_t and size_t limits.
3103
b13995db
PE
3104 * keyboard.c: Overflow, signedness and related fixes.
3105 (make_lispy_movement): Use same integer type in forward decl
3106 that is used in the definition.
3107 (read_key_sequence, keyremap_step):
3108 Change bufsize argument back to int, undoing my 2011-03-30 change.
3109 We prefer signed types, and int is wide enough here.
3110 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3111 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3112 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3113 length, not size_t. Use ptrdiff_t for index, not int.
3114 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3115 possibility of integer overflow.
3116
13464394
PE
3117 Overflow, signedness and related fixes for images.
3118
3119 * dispextern.h (struct it.stack[0].u.image.image_id)
3120 (struct_it.image_id, struct image.id, struct image_cache.size)
3121 (struct image_cache.used, struct image_cache.ref_count):
3122 * gtkutil.c (update_frame_tool_bar):
3123 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3124 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3125 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3126 * nsmenu.m (update_frame_tool_bar):
3127 * xdisp.c (calc_pixel_width_or_height):
3128 * xfns.c (image_cache_refcount):
3129 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3130 on typical 64-bit hosts.
3131
3132 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3133 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3134 Omit unnecessary casts to int.
3135 (parse_image_spec): Check that integers fall into 'int' range
3136 when the callers expect that.
3137 (image_ascent): Redo ascent calculation to avoid int overflow.
3138 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3139 (lookup_image): Remove unnecessary tests.
3140 (xbm_image_p): Locals are now of int, not EMACS_INT,
3141 since parse_image_check makes sure they fit into int.
3142 (png_load, gif_load, svg_load_image):
3143 Prefer int to unsigned where either will do.
3144 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3145 old tiff_error_handler and tiff_warning_handler.
3146 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3147 stack buffer overflows. It uses only the features of vsnprintf
3148 that are common to both POSIX and native Microsoft.
3149 (tiff_error_handler, tiff_warning_handler): Use it.
3150 (tiff_load, gif_load, imagemagick_load_image):
3151 Don't assume :index value fits in 'int'.
3152 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3153 (imagemagick_load_image): Check that crop parameters fit into
3154 the integer types that MagickCropImage accepts. Don't assume
3155 Vimagemagick_render_type has a nonnegative value. Don't assume
3156 size_t fits in 'long'.
3157 (gs_load): Use printmax_t to print the widest integers possible.
3158 Check for integer overflow when computing image height and width.
3159
c11821d4
EZ
31602011-08-26 Eli Zaretskii <eliz@gnu.org>
3161
3162 * xdisp.c (redisplay_window): Don't force window start if point
3163 will be invisible in the resulting window. (Bug#9324)
3164
0c95fcf7
EZ
31652011-08-25 Eli Zaretskii <eliz@gnu.org>
3166
3167 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3168 the display spec is of the form `(space ...)'.
3169 (handle_display_spec): Return the value returned by
3170 handle_single_display_spec, not just 1 or zero.
3171 (handle_single_display_spec): If the display spec is of the form
3172 `(space ...)', and specifies display in the text area, return 2
3173 rather than 1.
fee65a97 3174 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3175 accurately, and prefer exact match for point under bidi.
3176 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3177
3178 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3179 into disp_prop; all users changed.
3180
3181 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3182 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3183 for the text covered by the display property.
3184
e4ed06f1
CY
31852011-08-25 Chong Yidong <cyd@stupidchicken.com>
3186
3187 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3188 Change return value to nil.
3189 (Frecord_buffer): Delete unused function.
3190
f67cdd7f
EZ
31912011-08-24 Eli Zaretskii <eliz@gnu.org>
3192
5980d4c6
EZ
3193 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3194 buffers, return left-to-right.
8610fe8b
EZ
3195 (set_cursor_from_row): Consider candidate row a win if its glyph
3196 represents a newline and point is on that newline. Fixes cursor
3197 positioning on the newline at EOL of R2L text within L2R
3198 paragraph, and vice versa.
3199 (try_cursor_movement): Check continued rows, in addition to
3200 continuation rows. Fixes unwarranted scroll when point enters a
3201 continued line of R2L text within an L2R paragraph, or vice versa.
3202 (cursor_row_p): Consider the case of point being equal to
3203 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3204 from the end of a short line to the beginning of a continued line
3205 of R2L text within L2R paragraph.
3206 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3207 composed characters.
5980d4c6 3208
f67cdd7f
EZ
3209 * bidi.c (bidi_check_type): Use xassert.
3210 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3211 members.
3212
bca633fb
EZ
32132011-08-23 Eli Zaretskii <eliz@gnu.org>
3214
3215 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3216 a character.
3217
4a5885a7
CY
32182011-08-23 Chong Yidong <cyd@stupidchicken.com>
3219
3220 * nsfont.m (ns_otf_to_script): Fix typo.
3221
0902a04e
KH
32222011-08-22 Kenichi Handa <handa@m17n.org>
3223
3224 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3225 extra slot even if the purpose is char-code-property-table.
3226
1a2e6670
EZ
32272011-08-23 Eli Zaretskii <eliz@gnu.org>
3228
8ddde651
EZ
3229 * xdisp.c (redisplay_window): When computing centering_position,
3230 account for the height of the header line. (Bug#8874)
3231
425cc014
EZ
3232 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3233 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3234 candidate is selected by the mouse, and that candidate has a
3235 composed character under the mouse.
3236
1a2e6670
EZ
3237 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3238 coordinates reported by pos-visible-in-window-p for a composed
3239 character in column zero.
3240
8b76d6f8
SM
32412011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3242
3243 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3244
dac347dd
EZ
32452011-08-22 Eli Zaretskii <eliz@gnu.org>
3246
3247 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3248 consider it a hit if to_charpos is anywhere in the range of the
3249 composed buffer positions.
3250
e013fb34
CY
32512011-08-22 Chong Yidong <cyd@stupidchicken.com>
3252
3253 * image.c (gif_load): Don't assume that each subimage has the same
3254 dimensions as the base image. Handle disposal method that is
3255 "undefined" by the gif spec (Bug#9335).
3256
bd1ba3e8
CY
32572011-08-20 Chong Yidong <cyd@stupidchicken.com>
3258
3259 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3260 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3261
54a1215b
EZ
32622011-08-19 Eli Zaretskii <eliz@gnu.org>
3263
823564e5
EZ
3264 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3265 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3266 from an Org mode buffer to a Speedbar frame.
3267
54a1215b
EZ
3268 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3269 a composition, take its buffer position from IT->cmp_it.charpos.
3270 Fixes cursor positioning at the beginning of a line that begins
3271 with a composed character.
3272
9778ebcc
EZ
32732011-08-18 Eli Zaretskii <eliz@gnu.org>
3274
0be6ee06
EZ
3275 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3276 character bidirectional type, use STRONG_L instead. Fixes crashes
3277 in a buffer produced by `describe-categories'.
3278
9778ebcc
EZ
3279 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3280 members before the level stack, so they would be saved and
3281 restored when copying iterator state. Fixes incorrect reordering
3282 around TABs covered by display properties.
3283
156bffbe
AS
32842011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3285
6b02f655 3286 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3287
72ad093b
CY
32882011-08-17 Chong Yidong <cyd@stupidchicken.com>
3289
3290 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3291 (internal_condition_case_2, internal_condition_case_n):
3292 Remove unnecessary aborts (Bug#9081).
72ad093b 3293
35774242
EZ
32942011-08-17 Eli Zaretskii <eliz@gnu.org>
3295
3296 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3297 has no `load' handler, try opening the file locally. (Bug#9311)
3298
db76dd85
KB
32992011-08-16 Ken Brown <kbrown@cornell.edu>
3300
3301 * gmalloc.c: Expand comment.
3302
b215eee5
EZ
33032011-08-16 Eli Zaretskii <eliz@gnu.org>
3304
3305 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3306 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3307
a4579d33
KB
33082011-08-16 Ken Brown <kbrown@cornell.edu>
3309
3310 Fix memory allocation problems in Cygwin build (Bug#9273).
3311
3312 * unexcw.c ( __malloc_initialized): Declare external variable.
3313 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3314
8b76d6f8
SM
3315 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3316 New variables.
a4579d33
KB
3317 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3318 dumped emacs.
3319 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3320 in the static heap.
3321 [CYGWIN] (special_realloc): New function.
3322 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3323 requests to realloc storage in the static heap.
3324
3ebec551
PE
33252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3326
3327 * bidi.c (bidi_initialize): Remove unused local.
3328
9fd8be00
EZ
33292011-08-15 Eli Zaretskii <eliz@gnu.org>
3330
6b02f655
SM
3331 * bidimirror.h:
3332 * biditype.h: Remove file.
3333 * makefile.w32-in ($(BLD)/bidi.$(O)):
3334 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3335
3336 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3337
3338 * chartab.c: Improve commentary for the uniprop_table API.
3339
32413314
EZ
3340 * bidi.c (bidi_paragraph_init): Support zero value of
3341 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3342 (bidi_initialize): Use uniprop_table instead of including
3343 biditype.h and bidimirror.h.
32413314 3344
9fd8be00
EZ
3345 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3346 coordinates of the iterator when restoring from ppos_it.
3347 (Bug#9296)
3348
5cf2b69b
KH
33492011-08-14 Kenichi Handa <handa@m17n.org>
3350
3351 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3352 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3353
daf17d00
EZ
33542011-08-14 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xdisp.c (move_it_in_display_line_to): Don't invoke
3357 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3358 ppos_it. Fixes vertical cursor motion when line beginning is
3359 covered by an image. (Bug#9296)
3360
08e3161a
JD
33612011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3362
3363 * nsterm.h (ns_run_ascript): Declare.
3364 (NSAPP_DATA2_RUNASSCRIPT): Define.
3365
3366 * nsfns.m (as_script, as_result, as_status): New static variables.
3367 (ns_run_ascript): New function.
5e617bc2 3368 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3369 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3370 the event loop. Get status from as_status (Bug#7276).
3371
3372 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3373 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3374 the event loop (Bug#7276).
3375
a3720aa2
AS
33762011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3377
3378 * gnutls.c (QCgnutls_bootprop_priority)
3379 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3380 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3381 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3382 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3383 (QCgnutls_bootprop_verify_hostname_error)
3384 (QCgnutls_bootprop_callbacks_verify): Rename from
3385 Qgnutls_bootprop_..., all uses changed.
3386
3387 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3388 uses changed.
3389
0a0d27fb
PE
33902011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3391
19d5c50c
PE
3392 * xfaces.c (Qframe_set_background_mode): Now static.
3393 * dispextern.h (Qframe_set_background_mode): Remove decl.
3394
0a0d27fb
PE
3395 * process.c (Fnetwork_interface_info): Declare local only if needed.
3396
377538cb
JD
33972011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3398
3399 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3400 (Fnetwork_interface_list): Allocate in increments of bytes instead
3401 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3402 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3403 sockaddr.
3404 (struct ifflag_def): notrailers is smart on OSX.
3405 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3406 Get hardware address with getifaddrs if available.
3407
08fff70c
EZ
34082011-08-12 Eli Zaretskii <eliz@gnu.org>
3409
3410 * xdisp.c (iterate_out_of_display_property): xassert that
3411 IT->position is set to within IT->object's boundaries. Break from
3412 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3413 when IT->position is set up wrongly due to some bug.
3414 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3415 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3416 entry. Force push_it to save on the stack the current
3417 buffer/string position, to be restored by pop_it. Fix flags in
3418 the iterator structure wrt the object coming from a display
3419 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3420 properties. (Bug#9284)
3421
7be1c708 34222011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3423
7be1c708
CY
3424 * fontset.c (fontset_get_font_group): Add proper type checks.
3425 (Bug#9172)
aac0c6e3 3426
7be1c708 34272011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3428
7be1c708
CY
3429 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3430 and LC_VERSION_MIN_MACOSX.
3431 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3432 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3433
97bb72a6
EZ
34342011-08-08 Eli Zaretskii <eliz@gnu.org>
3435
3436 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3437 no-display-properties-and-no-overlays under bidi display.
3438 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3439 properties and overlays.
97bb72a6 3440
d5617611
CY
34412011-08-08 Chong Yidong <cyd@stupidchicken.com>
3442
37e11a63
CY
3443 * editfns.c (Fset_time_zone_rule): Document relationship with the
3444 setenv function.
3445
d5617611
CY
3446 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3447 the font entity extracted from the cache (Bug#8109).
3448
58872834
CY
34492011-08-07 Chong Yidong <cyd@stupidchicken.com>
3450
3451 * composite.c (autocmp_chars): Don't reset point. That is done by
3452 restore_point_unwind (Bug#5984).
3453
75bfc667
JL
34542011-08-07 Juri Linkov <juri@jurta.org>
3455
3456 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3457 to show the arg `TIME' instead of `TIMEVAL'.
3458
d1410150
EZ
34592011-08-06 Eli Zaretskii <eliz@gnu.org>
3460
3461 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3462 display property strides EOL and includes a newline, as in
3463 longlines-mode. (Bug#9254)
75b771e4
EZ
3464 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3465 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3466
3467 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3468 is non-zero, even if the data buffer is NULL. Fixes a crash in
3469 vertical-motion with longlines-mode. (Bug#9254)
3470
35928349
EZ
34712011-08-05 Eli Zaretskii <eliz@gnu.org>
3472
ec7cc85b
EZ
3473 * bidi.c <bidi_cache_total_alloc>: Now static.
3474 (bidi_initialize): Initialize bidi_cache_total_alloc.
3475
8b76d6f8 3476 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3477 cache. (Bug#9221)
3478
3479 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3480 amount allocated this far in `bidi_cache_total_alloc'.
3481 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3482 non-zero, only free the data buffer without restoring the cache
3483 contents. All callers changed.
3484
3485 * dispextern.h (bidi_unshelve_cache): Update prototype.
3486
3487 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3488 (move_it_in_display_line, move_it_to)
3489 (move_it_vertically_backward, move_it_by_lines): Replace the call
3490 to xfree to an equivalent call to bidi_unshelve_cache.
3491 (move_it_in_display_line_to): Fix logic of returning
412b6358 3492 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3493
e2e2423b
EZ
34942011-08-05 Eli Zaretskii <eliz@gnu.org>
3495
3496 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3497 came from a string character with a `cursor' property. (Bug#9229)
3498
ae9e757a
JD
34992011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3500
3501 * Makefile.in (LIB_PTHREAD): New variable.
3502 (LIBES): Add LIB_PTHREAD (Bug#9216).
3503
3504 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3505 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3506
213bd7f2
AS
35072011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3508
6b02f655 3509 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3510
99aaf75f
JD
35112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3512
3513 * xterm.c (x_find_topmost_parent): New function.
3514 (x_set_frame_alpha): Find topmost parent window with
3515 x_find_topmost_parent and set the property there also (bug#9181).
3516 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3517
c74e9d86
PE
35182011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 * callproc.c (Fcall_process): Avoid vfork clobbering
3521 the local vars buffer, coding_systems, current_dir.
3522
640c8776
SM
35232011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3524
3525 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3526
f26d0e4c
PE
35272011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3528
8a10d76c
PE
3529 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3530 so that it is not optimized away.
3531
f26d0e4c
PE
3532 * xdisp.c (compute_display_string_pos): Remove unused local.
3533
55439c61
EZ
35342011-08-02 Eli Zaretskii <eliz@gnu.org>
3535
3536 Fix slow cursor motion and scrolling in large buffers with
3537 selective display, like Org Mode buffers. (Bug#9218)
3538
3539 * dispextern.h (struct bidi_it): New member disp_prop_p.
3540
3541 * xdisp.c: Remove one-slot cache of display string positions.
3542 (compute_display_string_pos): Accept an additional argument
5e617bc2 3543 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3544 for a display string or property. If found, set DISP_PROP_P
3545 non-zero.
3546
3547 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3548 DISP_PROP_P, and pass it to compute_display_string_pos.
3549 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3550 non-zero. All callers of bidi_fetch_char changed.
3551
fb33fa43
SM
35522011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3553
3554 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3555
b099e063
DM
35562010-12-03 Don March <don@ohspite.net>
3557
3558 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3559 last character M-[char] is translated to ESC [char] (bug#7541).
3560
5cc7f7af
KH
35612011-08-02 Kenichi Handa <handa@m17n.org>
3562
d0fffa3f 3563 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3564
3565 * chartab.c (uniprop_table): Make it non-static.
3566
525d5e6e
EZ
35672011-08-01 Eli Zaretskii <eliz@gnu.org>
3568
3569 * xdisp.c (forward_to_next_line_start): Accept additional argument
3570 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3571 on the newline.
3572 (reseat_at_next_visible_line_start): Use the bidi iterator state
3573 returned by forward_to_next_line_start to restore the state of
3574 it->bidi_it after backing up to previous newline. (Bug#9212)
3575
31011111
AS
35762011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3577
3578 * regex.c (re_comp): Protoize.
3579 (re_exec): Fix return type.
3580 (regexec): Fix type of `ret'. (Bug#9203)
3581
476371c4
PE
35822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3583
e5d76069
PE
3584 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3585 This is needed if max-image-size is a floating-point number.
3586
9a79b20c
AS
35872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3588
3589 * print.c (print_object): Print empty symbol as ##.
3590
3591 * lread.c (read1): Read ## as empty symbol.
3592
d8c2fa78
AA
35932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3594
3595 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3596 setting frame foreground color (Bug#9175).
3597 (x_set_background_color): Likewise.
3598
ffe57a7a
AA
3599 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3600 contents (Bug#9176).
3601 (EmacsTooltip -init): Remove bezels and add shadows to
3602 tooltip windows.
3603
bf3492a5
AA
3604 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3605 or scroll bar (Bug#8470).
3606
d55e9c53
AA
3607 * nsfont.m (nsfont_open): Remove assignment to voffset and
3608 unnecessary vars hshink, expand, hd, full_height, min_height.
3609 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3610
3611 * nsterm.h (nsfont_info): Remove voffset field.
3612
d8c2fa78 36132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3614
3615 Implement strike-through and overline on NextStep (Bug#8863).
3616
3617 * nsfont.m (nsfont_open): Use underline position provided by font,
3618 instead of hard-coded value of 2.
3619 (nsfont_draw): Call ns_draw_text_decoration instead.
3620
3621 * nsterm.h: Add declaration for ns_draw_text_decoration.
3622
3623 * nsterm.m (ns_draw_text_decoration): New function for drawing
3624 underline, overline, and strike-through.
3625 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3626 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3627 accommodate underlining, etc.
4843aac3 3628
4cc60b9b
EZ
36292011-07-28 Eli Zaretskii <eliz@gnu.org>
3630
bc7ece87
EZ
3631 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3632 default.
4cc60b9b 3633
476371c4
PE
36342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3635
66606eea
PE
3636 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3637 Without this fix, if a signal arrives just after memory fills up,
3638 'malloc' might be invoked reentrantly.
3639
476371c4
PE
3640 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3641 In other words, assume that every image size is allowed, on non-X
3642 hosts. This assumption is probably wrong, but it lets Emacs compile.
3643
f3fcc40d
AS
36442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3645
3646 * regex.c (re_iswctype): Convert return values to boolean.
3647
350c992f
EZ
36482011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3649
3650 * xdisp.c (compute_display_string_pos): Don't use cached display
3651 string position if the buffer had its restriction changed.
3652 (Bug#9184)
3653
5266b4bb
PE
36542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3657
2573a837 36582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3659
41f55ccd 3660 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3661
39e378da
PE
3662 * bidi.c: Integer size and overflow fixes.
3663 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3664 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3665 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3666 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3667 (bidi_find_other_level_edge):
3668 Use ptrdiff_t instead of EMACS_INT where either will do.
3669 This works better on 32-bit hosts configured --with-wide-int.
3670 (bidi_cache_ensure_space): Check for size-calculation overflow.
3671 Use % rather than repeated addition, for better worst-case speed.
3672 Don't set bidi_cache_size until after xrealloc returns, because it
3673 might not return.
3674 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3675 (bidi_cache_ensure_space): Also check that the bidi cache size
3676 does not exceed that of the largest Lisp string or buffer. See Eli
3677 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3678
5e927815
PE
3679 * alloc.c (__malloc_size_t): Remove.
3680 All uses replaced by size_t. See Andreas Schwab's note
3681 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3682
ca4aa935
PE
3683 * image.c: Improve checking for integer overflow.
3684 (check_image_size): Assume that f is nonnull, since
3685 it is always nonnull in practice. This is one less thing to
3686 worry about when checking for integer overflow later.
3687 (x_check_image_size): New function, which checks for integer
3688 overflow issues inside X.
3689 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3690 This removes the need for a memory_full check.
3691 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3692 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3693 (xbm_read_bitmap_data): Change locals back to 'int', since
3694 their values must fit in 'int'.
3695 (xpm_load_image, png_load, tiff_load):
3696 Invoke x_create_x_image_and_pixmap earlier,
3697 to avoid much needless work if the image is too large.
3698 (tiff_load): Treat overly large images as if
3699 x_create_x_image_and_pixmap failed, not as malloc failures.
3700 (gs_load): Use x_check_image_size.
3701
5f8f9cc2
PE
3702 * gtkutil.c: Omit integer casts.
3703 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3704 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3705
5adf60bc
PE
3706 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3707
c8907a93
PE
3708 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3709 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3710 would wrongly return t on a 64-bit host.
3711
e3c25c68
PE
3712 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3713 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3714 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3715 and therefore cause GCC to emit a bogus diagnostic in some cases.
3716
3f791afe
PE
3717 * image.c: Integer signedness and overflow and related fixes.
3718 This is not an exhaustive set of fixes, but it's time to
3719 record what I've got.
3720 (lookup_pixel_color, check_image_size): Remove redundant decls.
3721 (check_image_size): Don't assume that arbitrary EMACS_INT values
3722 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3723 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3724 (tiff_load, imagemagick_load_image):
3725 Check for overflow in size calculations.
3726 (x_create_x_image_and_pixmap): Remove unnecessary test for
3727 xmalloc returning NULL; that can't happen.
3728 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3729 (xpm_color_bucket): Use better integer hashing function.
3730 (xpm_cache_color): Don't possibly over-allocate memory.
3731 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3732 (gif_memory_source):
3733 Use ptrdiff_t, not int or size_t, to record sizes.
3734 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3735 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3736 either works, as we prefer signed integers.
3737 (tiff_read_from_memory, tiff_write_from_memory):
3738 Return tsize_t, not size_t, since that's what the TIFF API wants.
3739 (tiff_read_from_memory): Don't fail simply because the read would
3740 go past EOF; instead, return a short read.
3741 (tiff_load): Omit no-longer-needed casts.
3742 (Fimagemagick_types): Don't assume size fits into 'int'.
3743
3cc5a532
PE
3744 Improve hashing quality when configured --with-wide-int.
3745 * fns.c (hash_string): New function, taken from sxhash_string.
3746 Do not discard information about ASCII character case; this
3747 discarding is no longer needed.
3748 (sxhash-string): Use it. Change sig to match it. Caller changed.
3749 * lisp.h: Declare it.
3750 * lread.c (hash_string): Remove, since we now use fns.c's version.
3751 The fns.c version returns a wider integer if --with-wide-int is
3752 specified, so this should help the quality of the hashing a bit.
3753
b312a492
PE
3754 * emacs.c: Integer overflow minor fix.
3755 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3756 Define only if GNU_LINUX.
3757 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3758
dfd153ae
PE
3759 * dispnew.c: Integer signedness and overflow fixes.
3760 Remove unnecessary forward decls, that were a maintenance hassle.
3761 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3762 All uses changed.
3763 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3764 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3765 (prepare_desired_row, line_draw_cost):
3766 Use int, not unsigned, where either works.
3767 (save_current_matrix, restore_current_matrix):
3768 Use ptrdiff_t, not size_t, where either works.
3769 (init_display): Check for overflow more accurately, and without
3770 relying on undefined behavior.
3771
a81d11a3
PE
3772 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3773 Remove, replacing with the new symbols in lisp.h. All uses changed.
3774 * fileio.c (make_temp_name):
3775 * filelock.c (lock_file_1, lock_file):
3776 * xdisp.c (message_dolog):
3777 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3778 Use pMd etc. instead.
3779 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3780 replacing the pWIDE etc. symbols removed from editfns.c.
3781
3300e6fd
PE
3782 * keyboard.h (num_input_events): Now uintmax_t.
3783 This is (very slightly) less likely to mess up due to wraparound.
3784 All uses changed.
3785
fd05c7e9
PE
3786 * buffer.c: Integer signedness fixes.
3787 (alloc_buffer_text, enlarge_buffer_text):
3788 Use ptrdiff_t rather than size_t when either will do, as we prefer
3789 signed integers.
3790
903fe15d
PE
3791 * alloc.c: Integer signedness and overflow fixes.
3792 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3793 (__malloc_size_t): Default to size_t, not to int.
3794 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3795 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3796 Prefer ptrdiff_t to size_t when either would do, as we prefer
3797 signed integers.
3798 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3799 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3800 Now const. Initialize with values that are in range even if char
3801 is signed.
3802 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3803 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3804 These functions do the right thing with sizes > 2**32.
3805 (check_depth): Now ptrdiff_t, not int.
3806 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3807 Adjust to new way of storing sizes. Check for size overflow bugs
3808 in rest of code.
3809 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3810 slightly wrong anyway, as it missed one instance of
3811 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3812 (refill_memory_reserve): Omit needless cast to size_t.
3813 (mark_object_loop_halt): Mark as externally visible.
3814
ac82cc6a
PE
3815 * xselect.c: Integer signedness and overflow fixes.
3816 (Fx_register_dnd_atom, x_handle_dnd_message):
3817 Use ptrdiff_t, not size_t, since we prefer signed.
3818 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3819 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3820 x_dnd_atoms_size and x_dnd_atoms_length.
3821
c2d1e36d
PE
3822 * doprnt.c: Prefer signed to unsigned when either works.
3823 * eval.c (verror):
3824 * doprnt.c (doprnt):
3825 * lisp.h (doprnt):
3826 * xdisp.c (vmessage):
3827 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3828 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3829 prefer signed arithmetic to avoid comparison confusion.
3830 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3831 but is a bit tricky.
3832
0e926e56
PE
3833 Assume freestanding C89 headers, string.h, stdlib.h.
3834 * data.c, doprnt.c, floatfns.c, print.c:
3835 Include float.h unconditionally.
3836 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3837 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3838 * regex.c: Likewise for stddef.h, string.h.
3839 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3840 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3841 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3842 (STDC_HEADERS): Remove obsolete defines.
3843 * sysdep.c: Include limits.h unconditionally.
3844
9cfdb3ec
PE
3845 Assume support for memcmp, memcpy, memmove, memset.
3846 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3847 * regex.c (memcmp, memcpy):
3848 Remove; we assume C89 now.
3849
3850 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3851 (__malloc_safe_bcopy): Remove; no longer needed.
3852
cf950e6b 3853 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3854 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3855 well either way, and we prefer signed to unsigned.
3856
dbf38e02
LMI
38572011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3858
3859 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3860 closes the connection while we're reading (bug#9182).
3861
d6f0886c 38622011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3863
d6f0886c
JD
3864 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3865 are specified (Bug#9168).
24e0f6b1 3866
2eb1f9e6
PE
38672011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3870 Found by GCC static checking and --with-wide-int on a 32-bit host.
3871
22381272 38722011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3873
3874 * xdisp.c (compute_display_string_pos): Fix logic of caching
3875 previous display string position. Initialize cached_prev_pos to
3876 -1. Fixes slow-down at the beginning of a buffer.
3877
f25e39b4
EZ
38782011-07-24 Eli Zaretskii <eliz@gnu.org>
3879
3880 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3881 for attrs[LFACE_FONTSET_INDEX].
3882
04c4b52e
PE
38832011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 * xml.c (parse_region): Remove unused local
3886 that was recently introduced.
3887
c1734fbd
EZ
38882011-07-23 Eli Zaretskii <eliz@gnu.org>
3889
be18c5a5
EZ
3890 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3891 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3892
c1734fbd
EZ
3893 * xdisp.c (move_it_in_display_line_to): Record the best matching
3894 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3895 exit if none of the characters scanned was an exact match.
3896 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3897 when exact match is impossible due to invisible text, and the
3898 lines are truncated.
3899
a258d627
JD
39002011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3901
3902 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3903 for OSX >= 10.7.
3904
b6d5a689
EZ
39052011-07-22 Eli Zaretskii <eliz@gnu.org>
3906
0f74f785
EZ
3907 Fix a significant slow-down of cursor motion with C-n, C-p,
3908 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3909 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3910 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3911 (next_element_from_buffer): Call compute_stop_pos_backwards to
3912 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3913 base_level_stop.
3914 (reseat): Don't look for prev_stop, as that could mean a very long
3915 run.
3916 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3917 <cached_disp_overlay_modiff>: Cache for last found display string
3918 position.
551918c1 3919 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3920 about the same buffer in the same area of character positions, and
3921 the buffer wasn't changed since the time the display string
3922 position was cached.
551918c1 3923
b2d0c91a
EZ
39242011-07-22 Eli Zaretskii <eliz@gnu.org>
3925
3926 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3927 is an integer, which is important for empty lines. (Bug#9149)
3928
043604ee
CY
39292011-07-22 Chong Yidong <cyd@stupidchicken.com>
3930
3931 * frame.c (Fmodify_frame_parameters): In tty case, update the
3932 default face if necessary (Bug#4238).
3933
da4adb04
CY
39342011-07-21 Chong Yidong <cyd@stupidchicken.com>
3935
3936 * editfns.c (Fstring_to_char): No need to explain what a character
3937 is in the docstring (Bug#6576).
3938
9abd0532
LMI
39392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3940
3941 * xml.c (parse_region): Make sure we always return a tree.
3942
36881d16
HK
39432011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3944
3945 * xml.c (parse_region): If a document contains only comments,
3946 return that, too.
3947
1e98674d
LMI
39482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3949
3950 * xml.c (make_dom): Return comments, too.
3951
590bd467
PE
39522011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3953
3954 Port to OpenBSD.
3955 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3956 and the surrounding thread.
3957 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3958 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3959 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3960 timer goes off.
3961 * s/openbsd.h (BROKEN_SIGIO): Define.
3962 * unexelf.c (unexec) [__OpenBSD__]:
3963 Don't update the .mdebug section of the Alpha COFF symbol table.
3964
f41628b2
LMI
39652011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3966
3967 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3968 (bug#8460).
3969
b59b67c5
PE
39702011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3971
15e3a074
PE
3972 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3973 This fixes some race conditions on the permissions of any newly
3974 created file.
3975
41bed37d
PE
3976 * alloc.c (valid_pointer_p): Use pipe, not open.
3977 This fixes some permissions issues when debugging.
3978
b59b67c5
PE
3979 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3980 If fchown fails to set both uid and gid, try to set just gid,
3981 as that is sometimes allowed. Adjust the file's mode to eliminate
3982 setuid or setgid bits that are inappropriate if fchown fails.
3983
925a6be7
SM
39842011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3985
3986 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3987 to compare Lisp_Objects.
3988 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3989 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3990 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3991
52968808
AS
39922011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3993
0a6a104b
AS
3994 * lread.c (read_integer): Unread even EOF character.
3995 (read1): Likewise. Properly record start position of symbol.
3996
52968808
AS
3997 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3998 symbol character follows.
3999
9e381cdd
PE
40002011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4003 This works around a problem with the previous change to Fcopy_file.
4004 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4005 and without this change, GCC might complain about discarding
4006 fchown's return value.
4007
b5641435
JB
40082011-07-16 Juanma Barranquero <lekktu@gmail.com>
4009
4010 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4011
a8031457
PE
40122011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4015
dd889327
LMI
40162011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4017
750c33f7
LMI
4018 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4019 it's used from the C level.
4020
dd889327
LMI
4021 * process.c: Use the same condition for POLL_FOR_INPUT in both
4022 keyboard.c and process.c (bug#1858).
4023
87e86684
LM
40242011-07-09 Lawrence Mitchell <wence@gmx.li>
4025
4026 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4027 (Fgnutls_boot): Use it.
4028
64348f40
AS
40292011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4030
4031 * doc.c (Fsubstitute_command_keys): Revert last change.
4032
1d698799
LMI
40332011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4034
f863868c
LMI
4035 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4036 quotes the next character, and doesn't affect other longer
4037 sequences (bug#8935).
4038
1d698799
LMI
4039 * lread.c (syms_of_lread): Clarify that is isn't only
4040 `eval-buffer' and `eval-defun' that's affected by
4041 `lexical-binding' (bug#8460).
4042
aa4b6df6
EZ
40432011-07-15 Eli Zaretskii <eliz@gnu.org>
4044
4045 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4046 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4047
5d856da6
PE
40482011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4049
ad6042bb
PE
4050 Fix minor problems found by static checking.
4051 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4052 (elsz): Now a signed constant, not a size_t var. We prefer signed
4053 types to unsigned, to avoid integer comparison confusion. Without
4054 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4055 "cannot optimize loop, the loop counter may overflow", a symptom
4056 of the confusion.
f00bbb22 4057 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4058 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4059
6468f31c
LMI
40602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4061
49080b10
LMI
4062 * search.c (Fre_search_backward): Mention `case-fold-search' in
4063 all the re_search_* functions (bug#8138).
4064
6468f31c
LMI
4065 * keyboard.c (Fopen_dribble_file): Document when the file is
4066 closed (bug#8056).
4067
c965adc5
EZ
40682011-07-14 Eli Zaretskii <eliz@gnu.org>
4069
df9733bf
EZ
4070 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4071 bidi_cache_idx.
4072
0bb23927
EZ
4073 Support bidi reordering of display and overlay strings.
4074 * xdisp.c (compute_display_string_pos)
4075 (compute_display_string_end): Accept additional argument STRING.
4076 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4077 (reseat_to_string): Initialize bidi_it->string.s and
4078 bidi_it->string.schars.
4079 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4080 NULL (avoids a crash in bidi_paragraph_init).
4081 Initialize itb.string.lstring.
0bb23927
EZ
4082 (init_iterator): Call bidi_init_it only of a valid
4083 buffer position was specified. Initialize paragraph_embedding to
4084 L2R.
4085 (reseat_to_string): Initialize the bidi iterator.
4086 (display_string): If we need to ignore text properties of
4087 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4088 original value of -1 will not work with bidi.)
4089 (compute_display_string_pos): First arg is now struct
4090 `text_pos *'; all callers changed. Support display properties on
4091 Lisp strings.
4092 (compute_display_string_end): Support display properties on Lisp
4093 strings.
4094 (init_iterator, reseat_1, reseat_to_string): Initialize the
4095 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4096 when iterating on a string not from display properties).
640c8776
SM
4097 (compute_display_string_pos, compute_display_string_end):
4098 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4099 arrow keys.
4100 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4101 base_level_stop; instead, set base_level_stop to BEGV.
4102 Fixes crashes in vertical-motion.
0bb23927
EZ
4103 (next_element_from_buffer): Improve commentary for when
4104 the iterator is before prev_stop.
4105 (init_iterator): Initialize bidi_p from the default value of
4106 bidi-display-reordering, not from buffer-local value. Use the
4107 buffer-local value only if initializing for buffer iteration.
4108 (handle_invisible_prop): Support invisible properties on strings
4109 that are being bidi-reordered.
4110 (set_iterator_to_next): Support bidi reordering of C strings and
4111 Lisp strings.
4112 (next_element_from_string): Support bidi reordering of Lisp
4113 strings.
4114 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4115 (display_string): Support display of R2L glyph rows.
4116 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4117 (init_iterator): Don't initialize it->bidi_p for strings
4118 here.
4119 (reseat_to_string): Initialize it->bidi_p for strings here.
4120 (next_element_from_string, next_element_from_c_string)
4121 (next_element_from_buffer): Add xassert's for correspondence
4122 between IT's object being iterated and it->bidi_it.string
4123 structure.
4124 (face_before_or_after_it_pos): Support bidi iteration.
4125 (next_element_from_c_string): Handle the case of the first string
4126 character that is not the first one in the visual order.
4127 (get_visually_first_element): New function, refactored from common
4128 parts of next_element_from_buffer, next_element_from_string, and
4129 next_element_from_c_string.
4130 (tool_bar_lines_needed, redisplay_tool_bar)
4131 (display_menu_bar): Force left-to-right direction. Add a FIXME
4132 comment for making that be controlled by a user option.
4133 (push_it, pop_it): Save and restore the state of the
4134 bidi iterator. Save and restore the bidi_p flag.
4135 (pop_it): Iterate out of display property for string iteration as
4136 well.
4137 (iterate_out_of_display_property): Support iteration over strings.
4138 (handle_single_display_spec): Set up it->bidi_it for iteration
4139 over a display string, and call bidi_init_it.
4140 (handle_single_display_spec, next_overlay_string)
4141 (get_overlay_strings_1, push_display_prop): Set up the bidi
4142 iterator for displaying display or overlay strings.
4143 (forward_to_next_line_start): Don't use the shortcut if
4144 bidi-iterating.
4145 (back_to_previous_visible_line_start): If handle_display_prop
4146 pushed the iterator stack, restore the internal state of the bidi
4147 iterator by calling bidi_pop_it same number of times.
4148 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4149 and we are bidi-iterating, don't decrement the iterator position;
4150 instead, set the first_elt flag in the bidi iterator, to produce
4151 the same effect.
4152 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4153 (push_display_prop): xassert that we are iterating a buffer.
4154 (push_it, pop_it): Save and restore paragraph_embedding member.
4155 (handle_single_display_spec, next_overlay_string)
4156 (get_overlay_strings_1, reseat_1, reseat_to_string)
4157 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4158 correctly. Don't assume unibyte strings are not bidi-reordered.
4159 (compute_display_string_pos)
4160 (compute_display_string_end): Fix handling the case of C string.
4161 (push_it, pop_it): Save and restore from_disp_prop_p.
4162 (handle_single_display_spec, push_display_prop): Set the
4163 from_disp_prop_p flag.
4164 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4165 (pop_it): Call iterate_out_of_display_property only if we are
4166 popping after iteration over a string that came from a display
4167 property. Fix a typo in popping stretch info. Add an assertion
4168 for verifying that the iterator position is in sync with the bidi
4169 iterator.
4170 (handle_single_display_spec, get_overlay_strings_1)
4171 (push_display_prop): Fix initialization of paragraph direction for
4172 string when that of the parent object is not yet determined.
4173 (reseat_1): Call bidi_init_it to resync the bidi
4174 iterator with IT's position. (Bug#7616)
4175 (find_row_edges): If ROW->start.pos gives position
4176 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4177 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4178 Reset the from_disp_prop_p flag.
4179 (SAVE_IT, RESTORE_IT): New macros.
4180 (pos_visible_p, face_before_or_after_it_pos)
4181 (back_to_previous_visible_line_start)
4182 (move_it_in_display_line_to, move_it_in_display_line)
4183 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4184 (try_scrolling, redisplay_window, display_line): Use them when
4185 saving a temporary copy of the iterator and restoring it back.
4186 (back_to_previous_visible_line_start, reseat_1)
4187 (init_iterator): Empty the bidi cache "stack".
4188 (move_it_in_display_line_to): If iterator ended up at
4189 EOL, but we never saw any buffer positions smaller than
4190 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4191 motion in bidi-reordered lines.
4192 (move_it_in_display_line_to): Record prev_method and prev_pos
4193 immediately before the call to set_iterator_to_next. Fixes cursor
4194 motion in bidi-reordered lines with stretch glyphs and strings
4195 displayed in margins. (Bug#8133) (Bug#8867)
4196 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4197 TO_CHARPOS.
640c8776
SM
4198 (pos_visible_p): Support positions in bidi-reordered lines.
4199 Save and restore bidi cache.
0bb23927
EZ
4200
4201 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4202 (bidi_paragraph_info): Delete unused struct.
4203 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4204 (bidi_cache_start): New variable.
4205 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4206 to zero.
4207 (bidi_cache_fetch_state, bidi_cache_search)
4208 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4209 (bidi_cache_find, bidi_peek_at_next_level)
4210 (bidi_level_of_next_char, bidi_find_other_level_edge)
4211 (bidi_move_to_visually_next): Compare cache index with
4212 bidi_cache_start rather than with zero.
4213 (bidi_fetch_char): Accept new argument STRING; all callers
4214 changed. Support iteration over a string. Support strings with
4215 display properties. Support unibyte strings. Fix the type of
4216 `len' according to what STRING_CHAR_AND_LENGTH expects.
4217 (bidi_paragraph_init, bidi_resolve_explicit_1)
4218 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4219 (bidi_level_of_next_char, bidi_move_to_visually_next):
4220 Support iteration over a string.
0bb23927
EZ
4221 (bidi_set_sor_type, bidi_resolve_explicit_1)
4222 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4223 can now be zero (for strings); special values 0 and -1 were
4224 changed to -1 and -2, respectively.
4225 (bidi_char_at_pos): New function.
4226 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4227 Call it instead of FETCH_MULTIBYTE_CHAR.
4228 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4229 initialized to valid values.
4230 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4231 values.
4232 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4233 the test for valid cached positions. Fix the logic for looking up
4234 the sentinel state in the cache. GCPRO the Lisp string we are
4235 iterating.
4236 (bidi_push_it, bidi_pop_it): New functions.
4237 (bidi_initialize): Initialize the bidi cache start stack pointer.
4238 (bidi_cache_ensure_space): New function, refactored from part of
4239 bidi_cache_iterator_state. Don't assume the required size is just
4240 one BIDI_CACHE_CHUNK away.
4241 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4242 (bidi_count_bytes, bidi_char_at_pos): New functions.
4243 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4244 always valid if bidi_cache_idx is valid.
4245 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4246 is valid if it's going to be used.
4247 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4248 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4249 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4250 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4251 (bidi_find_other_level_edge, bidi_cache_start_stack):
4252 All variables related to cache indices are now EMACS_INT.
c965adc5 4253
0bb23927
EZ
4254 * dispextern.h (struct bidi_string_data): New structure.
4255 (struct bidi_it): New member `string'. Make flag members be 1-bit
4256 fields, and put them last in the struct.
640c8776
SM
4257 (compute_display_string_pos, compute_display_string_end):
4258 Update prototypes.
0bb23927
EZ
4259 (bidi_push_it, bidi_pop_it): Add prototypes.
4260 (struct iterator_stack_entry): New members bidi_p,
4261 paragraph_embedding, and from_disp_prop_p.
4262 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4263 (bidi_shelve_cache, bidi_unshelve_cache):
4264 Declare prototypes.
0bb23927
EZ
4265
4266 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4267 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4268 and vector-like objects.
4269
4270 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4271 cache around display iteration.
4272
4273 * window.c (Fwindow_end, window_scroll_pixel_based)
4274 (displayed_window_lines, Frecenter): Save and restore the bidi
4275 cache around display iteration.
4276
3bbd2265
LMI
42772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4278
4279 * editfns.c (Fdelete_region): Clarify the use of the named
4280 parameters (bug#6788).
4281
adc47434
MR
42822011-07-14 Martin Rudalics <rudalics@gmx.at>
4283
4284 * indent.c (Fvertical_motion): Set and restore w->pointm when
4285 saving and restoring the window's buffer (Bug#9006).
4286
837c31f8
LMI
42872011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4288
4289 * editfns.c (Fstring_to_char): Clarify just what is returned
4290 (bug#6576). Text by Eli Zaretskii.
4291
ac389d0c
JB
42922011-07-13 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4295
0be0ce47
EZ
42962011-07-13 Eli Zaretskii <eliz@gnu.org>
4297
4298 * buffer.c (mmap_find): Fix a typo.
4299
cd18e7e3
JB
43002011-07-13 Johan Bockgård <bojohan@gnu.org>
4301
4302 Fix execution of x selection hooks.
4303 * xselect.c (Qx_lost_selection_functions)
4304 (Qx_sent_selection_functions): New vars.
4305 (syms_of_xselect): DEFSYM them.
4306 (x_handle_selection_request): Pass Qx_sent_selection_functions
4307 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4308 (x_handle_selection_clear,x_clear_frame_selections):
4309 Pass Qx_lost_selection_functions rather than
4310 Vx_lost_selection_functions to Frun_hook_with_args.
4311
47ea7f44
PE
43122011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4313
ac389d0c 4314 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4315 The old code sometimes used this field without initializing it.
4316
47ea7f44
PE
4317 * alloc.c (gc_sweep): Don't read past end of array.
4318 In theory, the old code could also have corrupted Emacs internals,
4319 though it'd be very unlikely.
4320
bc985c87
AS
43212011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4322
4323 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4324 argument. (Bug#4026)
bc985c87 4325
0cf34688
LMI
43262011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4327
b3dadd76
LMI
4328 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4329 key" (bug#4257).
4330
0cf34688
LMI
4331 * window.c (Fset_window_start): Doc fix (bug#4199).
4332 (Fset_window_hscroll): Ditto.
4333
270768cd
PE
43342011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4335
077e3dda 4336 Fix minor new problems caught by GCC 4.6.1.
270768cd 4337 * term.c (init_tty): Remove unused local.
490011a6 4338 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4339 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4340 not used otherwise.
270768cd 4341
b1f58454
CY
43422011-07-12 Chong Yidong <cyd@stupidchicken.com>
4343
4344 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4345
22b9578d
LMI
43462011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4347
6e70ab07
LMI
4348 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4349 are the mini-buffer and the echo area (bug#3320).
4350
22b9578d
LMI
4351 * term.c (init_tty): Remove support for supdup, c10 and perq
4352 terminals, which are no longer supported (bug#1482).
4353
8974cc9f
JB
43542011-07-10 Johan Bockgård <bojohan@gnu.org>
4355
4356 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4357
a560d974
JD
43582011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4359
4360 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4361 for non-popups (Bug#3642).
4362
1dae0f0a
AS
43632011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4364
268c2c36 4365 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4366 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4367 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4368 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4369 * data.c (fmod): Likewise.
4370 * dispnew.c (swap_glyphs_in_rows): Likewise.
4371 * emacs.c (memory_warning_signal): Likewise.
4372 * floatfns.c (float_error): Likewise.
4373 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4374 (otf_open, font_otf_capability, generate_otf_features)
4375 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4376 Likewise.
4377 * image.c (pbm_read_file): Likewise.
4378 * indent.c (string_display_width): Likewise.
4379 * intervals.c (check_for_interval, search_for_interval)
4380 (inc_interval_count, count_intervals, root_interval)
4381 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4382 * lread.c (defalias): Likewise.
268c2c36 4383 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4384 * regex.c (set_image_of_range_1, set_image_of_range)
4385 (regex_grow_registers): Likewise.
4386 * sysdep.c (strerror): Likewise.
4387 * termcap.c (valid_filename_p, tprint, main): Likewise.
4388 * tparam.c (main): Likewise.
4389 * unexhp9k800.c (run_time_remap, save_data_space)
4390 (update_file_ptrs, read_header, write_header, calculate_checksum)
4391 (copy_file, copy_rest, display_header): Likewise.
4392 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4393 Likewise.
4394 * xdisp.c (check_it): Likewise.
4395 * xfaces.c (register_color, unregister_color, unregister_colors):
4396 Likewise.
4397 * xfns.c (print_fontset_result): Likewise.
4398 * xrdb.c (member, fatal, main): Likewise.
4399
99033785
PE
44002011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 Fix minor problems found by static checking (Bug#9031).
4403 * chartab.c (char_table_set_range, map_sub_char_table):
4404 Remove unused locals.
4405 (uniprop_table): Now static.
4406 * composite.c (_work_char): Remove unused static var.
4407
9cb2ac56
JB
44082011-07-09 Juanma Barranquero <lekktu@gmail.com>
4409
4410 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4411
f25661f0
JD
44122011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4413
4414 * gtkutil.c (qttip_cb): Remove code without function.
4415
8278c4fe
EZ
44162011-07-09 Eli Zaretskii <eliz@gnu.org>
4417
4418 * w32.c (pthread_sigmask): New stub.
4419
1692ae2d 44202011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4421
8a6ebd58 4422 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4423 sigprocmask is portable only for single-threaded applications, and
4424 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4425 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4426 (LIBES): Use it.
4427 * callproc.c (Fcall_process):
4428 * process.c (create_process):
4429 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4430 Use pthread_sigmask, not sigprocmask.
123403e4 4431
1b854618
JD
44322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4433
4434 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4435 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4436 wrong (Bug#8591).
4437
3fe4b549
JD
44382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4439
0ce7e563
JD
4440 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4441 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4442 (xg_hide_tooltip): Fix comment.
4443
3fe4b549
JD
4444 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4445 in registerServicesMenuSendTypes.
4446 (validRequestorForSendType): Don't check ns_return_types.
4447
4448 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4449 ns_return_type.
4450
5df75e47
JR
44512011-07-08 Jason Rumney <jasonr@gnu.org>
4452
22610910
JR
4453 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4454 SH_SHOW for hidden windows (Bug#5482).
4455
5df75e47
JR
4456 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4457 frame struct members of non-existent frames (Bug#6284).
4458
699c10bd
JD
44592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4460
4393663b
JD
4461 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4462 variable firstTime not needed on OSX >= 10.6.
4463 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4464 >= 10.5. Use setKnobProportion, setDoubleValue.
4465
4466 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4467 (MAC_OS_X_VERSION_10_5): Define if not defined.
4468 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4469 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4470 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4471
4472 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4473 cString and lossyCString on OSX >= 10.4
4474
58179cce 4475 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4476 sizeToFit on OSX >= 10.2.
4477
4478 * nsimage.m (allocInitFromFile): Don't use deprecated method
4479 bestRepresentationForDevice on OSX >= 10.6.
4480
4481 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4482 to avoid warning.
4483
4484 * emacs.c: Declare unexec_init_emacs_zone.
4485
a63e0781
JD
4486 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4487
699c10bd
JD
4488 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4489
4490 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4491 on svcsMenu (Bug#8842).
4492
4493 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4494 ns_return_types.
4495 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4496
4497 * nsterm.m (QUTF8_STRING): Declare.
4498 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4499 (validRequestorForSendType): Return type is (id).
4500 Change indexOfObjectIdenticalTo to indexOfObject.
4501 Check if we have local selection before returning self (Bug#8842).
4502 (writeSelectionToPasteboard): Put local selection into paste board
4503 if we have a local selection (Bug#8842).
4504 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4505
4506 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4507 (ns_get_local_selection): Declare.
4508
54e10184
LMI
45092011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4510
9888ff71
LMI
4511 * keymap.c (describe_map_tree): Don't insert a double newline at
4512 the end of the buffer (bug#1169) and return whether we inserted
4513 something.
4514
54e10184
LMI
4515 * callint.c (Fcall_interactively): Change "reading args" to
4516 "providing args" to try to clarify what it does (bug#1010).
4517
15fa4783
KH
45182011-07-07 Kenichi Handa <handa@m17n.org>
4519
4520 * composite.c (composition_compute_stop_pos): Ignore a static
4521 composition starting before CHARPOS (Bug#8915).
4522
4523 * xdisp.c (handle_composition_prop): Likewise.
4524
a8815b00
EZ
45252011-07-07 Eli Zaretskii <eliz@gnu.org>
4526
4527 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4528 (Bug#9015)
4529
ef7b981d 45302011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4531
4532 * character.h (unicode_category_t): New enum type.
4533
4534 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4535 (Qchar_code_property_table): New variable.
4536 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4537 (UNIPROP_COMPRESSED_FORM_P): New macros.
4538 (char_table_ascii): Uncompress the compressed values.
4539 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4540 Uncompress the compressed values.
ac389d0c 4541 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4542 (char_table_ref_and_range): Uncompress the compressed values.
4543 (sub_char_table_set): New arg is_uniprop. Callers changed.
4544 Uncompress the compressed values.
4545 (sub_char_table_set_range): Args changed. Callers changed.
4546 (char_table_set_range): Adjuted for the above change.
4547 (map_sub_char_table): Delete args default_val and parent. Add arg
4548 top. Give decoded values to a Lisp function.
640c8776 4549 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4550 values to a Lisp function. Gcpro more variables.
4551 (uniprop_table_uncompress)
4552 (uniprop_decode_value_run_length): New functions.
4553 (uniprop_decoder, uniprop_decoder_count): New variables.
4554 (uniprop_get_decoder, uniprop_encode_value_character)
4555 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4556 New functions.
4557 (uniprop_encoder, uniprop_encoder_count): New variables.
4558 (uniprop_get_encoder, uniprop_table)
4559 (Funicode_property_table_internal, Fget_unicode_property_internal)
4560 (Fput_unicode_property_internal): New functions.
4561 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4562 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4563 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4564 char-code-property-alist.
4565
640c8776 4566 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4567 Vunicode_category_table.
4568
640c8776 4569 * font.c (font_range): Adjust for the change of
c805dec0
KH
4570 Vunicode_category_table.
4571
76b397fb
DN
45722011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4573
4574 * m/iris4d.h: Remove file, move contents ...
4575 * s/irix6-5.h: ... here.
4576
22b4128e
PE
45772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4578
4579 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4580 * alloc.c (mark_buffer):
4581 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4582 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4583 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4584 This isn't true in general, and it's particularly not true
4585 if Emacs is configured with --with-wide-int.
4586 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4587 New macros, used in the buffer.c change.
4588
869795d6
JD
45892011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4590
4591 * xsettings.c: Use both GConf and GSettings if both are available.
4592 (store_config_changed_event): Add comment.
4593 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4594 (store_tool_bar_style_changed): New functions.
5e617bc2 4595 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4596 (struct xsettings): Move font inside HAVE_XFT.
4597 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4598 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4599 Move inside HAVE_XFT.
640c8776 4600 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4601 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4602 also.
4603 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4604 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4605 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4606 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4607 (parse_settings): Move check for font inside HAVE_XFT.
4608 (read_settings, apply_xft_settings): Add comment.
4609 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4610 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4611 call store_font_name_changed.
4612 (xft_settings_event): Add comment.
4613 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4614 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4615 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4616 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4617 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4618 (xsettings_get_system_font, xsettings_get_system_normal_font):
4619 Add comment.
869795d6 4620
d8ed26bd
PE
46212011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4622
4623 Random fixes. E.g., (random) never returned negative values.
4624 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4625 subseconds part to the entropy, as that's a bit more random.
4626 Prefer signed to unsigned, since the signedness doesn't matter and
4627 in general we prefer signed. When given a limit, use a
4628 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4629 latter isn't right if USE_2_TAGS_FOR_INTS.
4630 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4631 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4632
cabf1cac
SM
46332011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4634
4635 * textprop.c (text_property_stickiness):
4636 Obey Vtext_property_default_nonsticky.
4637 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4638 * w32fns.c (syms_of_w32fns):
4639 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4640
6e9b2be9
PE
46412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4644 This is more efficient than Ffile_directory_p and avoids a minor race.
4645
90186c68
LMI
46462011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4647
7c301272
LMI
4648 * buffer.c (Foverlay_put): Say what the return value is
4649 (bug#7835).
4650
c4f2d8d4
LMI
4651 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4652 is a directory before asking whether to use the file name
4653 (bug#7564).
ad637907
LMI
4654 (barf_or_query_if_file_exists): Make the "File is a directory"
4655 error be more correct.
c4f2d8d4 4656
90186c68
LMI
4657 * fns.c (Frequire): Remove the mention of the .gz files, since
4658 that's installation-specific, but keep the mention of
4659 `get-load-suffixes'.
4660
da64016e
PE
46612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4662
4663 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4664 Report string overflow if the output is too long.
4665
7d47b580
JB
46662011-07-04 Juanma Barranquero <lekktu@gmail.com>
4667
a555cb87
JB
4668 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4669 (syms_of_gnutls): Remove duplicate DEFSYM for
4670 Qgnutls_bootprop_verify_hostname_error, an error for
4671 Qgnutls_bootprop_verify_error (which is no longer used).
4672
7d47b580
JB
4673 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4674 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4675 Also (re)move comments that are misplaced or no longer relevant.
4676
1e49bfab
LMI
46772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4678
4679 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4680
1485f4c0
CY
46812011-07-03 Chong Yidong <cyd@stupidchicken.com>
4682
4683 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4684 and background color parameters if they have been changed.
4685
a9ab721e
LMI
46862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4687
4688 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4689
cf7cff57
PE
46902011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4691
2e13213d
PE
4692 * xsettings.c (SYSTEM_FONT): Define only when used.
4693 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4694
cf7cff57
PE
4695 * keymap.c (access_keymap_1): Now static.
4696
7a8e04f7
CY
46972011-07-02 Chong Yidong <cyd@stupidchicken.com>
4698
4699 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4700 leave any prefix arg for the up event (Bug#1586).
4701
61352f62
LMI
47022011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4703
69bb1ef7
LMI
4704 * lread.c (syms_of_lread): Mention single symbols defined by
4705 `defvar' or `defconst' (bug#7154).
4706
61352f62 4707 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4708 (Frequire): Mention get-load-suffixes.
61352f62 4709
28545e04
MR
47102011-07-02 Martin Rudalics <rudalics@gmx.at>
4711
4712 * window.h (window): Remove clone_number slot.
4713 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4714 Remove.
4715 (make_parent_window, make_window, saved_window)
4716 (Fset_window_configuration, save_window_save): Don't deal with
4717 clone numbers.
4718 * buffer.c (Qclone_number): Remove declaration.
4719 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4720
3349e122
SM
47212011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4722
4723 Add multiple inheritance to keymaps.
4724 * keymap.c (Fmake_composed_keymap): New function.
4725 (Fset_keymap_parent): Simplify.
4726 (fix_submap_inheritance): Remove.
4727 (access_keymap_1): New function extracted from access_keymap to handle
4728 embedded parents and handle lists of maps.
4729 (access_keymap): Use it.
4730 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4731 (Fcopy_keymap): Handle embedded parents.
4732 (Fcommand_remapping, define_as_prefix): Simplify.
4733 (Fkey_binding): Simplify.
4734 (syms_of_keymap): Move minibuffer-local-completion-map,
4735 minibuffer-local-filename-completion-map,
4736 minibuffer-local-must-match-map, and
4737 minibuffer-local-filename-must-match-map to Elisp.
4738 (syms_of_keymap): Defsubr make-composed-keymap.
4739 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4740 (parse_menu_item): Trivial simplification.
4741
3279eb87
GM
47422011-07-01 Glenn Morris <rgm@gnu.org>
4743
4744 * Makefile.in (SETTINGS_LIBS): Fix typo.
4745
4550efdf
KI
47462011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4747
4748 * coding.c (Fencode_coding_string): Record the last coding system
4749 used, as the function doc string says (bug#8738).
4750
0949d2b6
JD
47512011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4752
4753 * xsettings.c (store_monospaced_changed): Take new font as arg and
4754 check for change against current_mono_font.
4755 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4756 (emacs_settings_constructor, emacs_settings_get_property)
4757 (emacs_settings_set_property, emacs_settings_class_init)
4758 (emacs_settings_init, gsettings_obj): Remove.
4759 (something_changedCB): New function for HAVE_GSETTINGS.
4760 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4761 with value as argument.
4762 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4763 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4764 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4765 "changed".
4766
4767 * xgselect.c: Add defined (HAVE_GSETTINGS).
4768 (xgselect_initialize): Ditto.
4769
4770 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4771 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4772 xg_select.
4773
bbc6b304
PE
47742011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 * eval.c (struct backtrace): Simplify and port the data structure.
4777 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4778 signed bit field, as this assumption is not portable and it makes
4779 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4780 "char debug_on_exit : 1" as this is not portable either; instead,
4781 use the portable "unsigned int debug_on_exit : 1". Remove unused
4782 member evalargs. Remove obsolete comments about cc bombing out.
4783
9851bfc5
JD
47842011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4785
51bb811f 4786 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4787 Let HAVE_GSETTINGS override HAVE_GCONF.
4788 (store_monospaced_changed): New function.
4789 (EMACS_SETTINGS): A new type derived from GObject to handle
4790 GSettings notifications.
4791 (emacs_settings_constructor, emacs_settings_get_property)
4792 (emacs_settings_set_property, emacs_settings_class_init):
4793 New functions.
4794 (gsettings_client, gsettings_obj): New variables.
4795 (GSETTINGS_SCHEMA): New define.
4796 (something_changedCB): Call store_monospaced_changed.
4797 (init_gsettings): New function.
4798 (xsettings_initialize): Call init_gsettings.
4799 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4800 to NULL.
4801
640c8776 4802 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4803 GCONF_CFLAGS/LIBS.
4804
5386012d
MR
48052011-06-29 Martin Rudalics <rudalics@gmx.at>
4806
4807 * window.c (resize_root_window, grow_mini_window)
4808 (shrink_mini_window): Rename Qresize_root_window to
4809 Qwindow_resize_root_window and Qresize_root_window_vertically to
4810 Qwindow_resize_root_window_vertically.
4811
f13e0b08
PE
48122011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4815
94515237
JB
48162011-06-27 Juanma Barranquero <lekktu@gmail.com>
4817
4818 * makefile.w32-in: Redesign dependencies so they reflect more
4819 clearly which files are directly included by each source file,
4820 and not through other includes.
4821
e43b6e43
MR
48222011-06-27 Martin Rudalics <rudalics@gmx.at>
4823
4824 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4825 (sort_overlays, overlay_strings): When an overlay's clone number
4826 matches the window's clone number process the overlay even if
4827 the overlay's window property doesn't match the current window.
4828
d68443dc
MR
4829 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4830 (Fwindow_hchild): Rename to Fwindow_left_child.
4831 (Fwindow_next): Rename to Fwindow_next_sibling.
4832 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4833 (resize_window_check): Rename to window_resize_check.
4834 (resize_window_apply): Rename to window_resize_apply.
4835 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4836 (Fdelete_other_windows_internal, resize_frame_windows)
4837 (Fsplit_window_internal, Fdelete_window_internal)
4838 (grow_mini_window, shrink_mini_window)
4839 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4840
c7e73be5
JD
48412011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4842
4843 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4844 (emacs_fixed_set_min_size): Remove.
4845 (emacs_fixed_new): Take frame as argument.
4846
4847 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4848 (_EmacsFixedPrivate): Remove minwidth/height.
4849 Add struct frame *f.
4850 (emacs_fixed_init): Initialize priv->f.
4851 (get_parent_class, emacs_fixed_set_min_size): Remove.
4852 (emacs_fixed_new): Set priv->f to argument.
4853 (emacs_fixed_get_preferred_width)
4854 (emacs_fixed_get_preferred_height): Use min_width/height from
4855 frames size_hint to set minimum and natural (Bug#8919).
4856 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4857 and use min_width/height from frames size_hint to set
4858 min_width/height (Bug#8919).
4859
4860 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4861 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4862 Fix indentation.
c7e73be5 4863
cf99dcf8
EZ
48642011-06-26 Eli Zaretskii <eliz@gnu.org>
4865
4866 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4867 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4868 called at ZV.
4869
029529ac
CY
48702011-06-26 Chong Yidong <cyd@stupidchicken.com>
4871
4872 * process.c (wait_reading_process_output): Bypass select if
4873 waiting for a cell while ignoring keyboard input, and input is
4874 pending. Suggested by Jan Djärv (Bug#8869).
4875
7a7ef429
PE
48762011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4877
4878 Use gnulib's dup2 module instead of rolling our own.
4879 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4880
11fdef7d 48812011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4882
4883 * dispnew.c (scrolling_window): Before scrolling, turn off a
4884 mouse-highlight in the window being scrolled.
4885
cd3520a4
JB
48862011-06-24 Juanma Barranquero <lekktu@gmail.com>
4887
4888 Move DEFSYM to lisp.h and use everywhere.
4889
4890 * character.h (DEFSYM): Move declaration...
4891 * lisp.h (DEFSYM): ...here.
4892
4893 * gnutls.c:
4894 * minibuf.c:
4895 * w32menu.c:
4896 * w32proc.c:
4897 * w32select.c: Don't include character.h.
4898
4899 * alloc.c (syms_of_alloc):
4900 * buffer.c (syms_of_buffer):
4901 * bytecode.c (syms_of_bytecode):
4902 * callint.c (syms_of_callint):
4903 * casefiddle.c (syms_of_casefiddle):
4904 * casetab.c (init_casetab_once):
4905 * category.c (init_category_once, syms_of_category):
4906 * ccl.c (syms_of_ccl):
4907 * cmds.c (syms_of_cmds):
4908 * composite.c (syms_of_composite):
4909 * dbusbind.c (syms_of_dbusbind):
4910 * dired.c (syms_of_dired):
4911 * dispnew.c (syms_of_display):
4912 * doc.c (syms_of_doc):
4913 * editfns.c (syms_of_editfns):
4914 * emacs.c (syms_of_emacs):
4915 * eval.c (syms_of_eval):
4916 * fileio.c (syms_of_fileio):
4917 * fns.c (syms_of_fns):
4918 * frame.c (syms_of_frame):
4919 * fringe.c (syms_of_fringe):
4920 * insdel.c (syms_of_insdel):
4921 * keymap.c (syms_of_keymap):
4922 * lread.c (init_obarray, syms_of_lread):
4923 * macros.c (syms_of_macros):
4924 * msdos.c (syms_of_msdos):
4925 * print.c (syms_of_print):
4926 * process.c (syms_of_process):
4927 * search.c (syms_of_search):
4928 * sound.c (syms_of_sound):
4929 * syntax.c (init_syntax_once, syms_of_syntax):
4930 * terminal.c (syms_of_terminal):
4931 * textprop.c (syms_of_textprop):
4932 * undo.c (syms_of_undo):
4933 * w32.c (globals_of_w32):
4934 * window.c (syms_of_window):
4935 * xdisp.c (syms_of_xdisp):
4936 * xfaces.c (syms_of_xfaces):
4937 * xfns.c (syms_of_xfns):
4938 * xmenu.c (syms_of_xmenu):
4939 * xsettings.c (syms_of_xsettings):
4940 * xterm.c (syms_of_xterm): Use DEFSYM.
4941
4228cf16
TZ
49422011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4943
cd3520a4 4944 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4945
7fcccf1e
PE
49462011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4947
7efb4e0e
PE
4948 Integer and buffer overflow fixes (Bug#8873).
4949
ff5844ad
PE
4950 * print.c (printchar, strout): Check for string overflow.
4951 (PRINTPREPARE, printchar, strout):
4952 Don't set size unless allocation succeeds.
4953
90532f02
PE
4954 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4955 for sizes. Check for string overflow more accurately.
4956 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4957
6d84508d
PE
4958 * macros.c: Integer and buffer overflow fixes.
4959 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4960 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4961 Use ptrdiff_t, not int, for sizes.
4962 Don't increment bufsize until after realloc succeeds.
4963 Check for size-calculation overflow.
4964 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4965
437b2cb4
PE
4966 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4967
8b9ac8b4
PE
4968 * lread.c: Integer overflow fixes.
4969 (read_integer): Radix is now EMACS_INT, not int,
4970 to improve quality of diagnostics for out-of-range radices.
4971 Calculate buffer size correctly for out-of-range radices.
4972 (read1): Check for integer overflow in radices, and in
4973 read-circle numbers.
82cb60d3
PE
4974 (read_escape): Avoid int overflow.
4975 (Fload, openp, read_buffer_size, read1)
4976 (substitute_object_recurse, read_vector, read_list, map_obarray):
4977 Use ptrdiff_t, not int, for sizes.
4978 (read1): Use EMACS_INT, not int, for sizes.
20270765 4979 Check for size overflow.
8b9ac8b4 4980
7fcccf1e
PE
4981 * image.c (cache_image): Check for size arithmetic overflow.
4982
bfbbd7e7
PE
4983 * lread.c: Integer overflow issues.
4984 (saved_doc_string_size, saved_doc_string_length)
4985 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4986 Now ptrdiff_t, not int.
4987 (read1): Don't assume doc string length fits in int. Check for
4988 out-of-range doc string lengths.
4989 (read_list): Don't assume file position fits in int.
39019e54 4990 (read_escape): Check for hex character overflow.
bfbbd7e7 4991
4e323265
LL
49922011-06-22 Leo Liu <sdl.web@gmail.com>
4993
4994 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4995 Move to minibuffer.el.
4996
85fece3e
PE
49972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4998
20b84ce9 4999 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5000 The following patches are for when GLYPH_DEBUG && !XASSERT.
5001 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5002 * dispnew.c (flush_stdout):
5003 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5004 Mark as externally visible.
5005 * dispnew.c (check_window_matrix_pointers): Now static.
5006 * dispnew.c (window_to_frame_vpos):
5007 * xfns.c (unwind_create_frame):
5008 * xterm.c (x_check_font): Remove unused local.
5009 * scroll.c (CHECK_BOUNDS):
5010 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5011 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5012 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5013 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5014 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5015 Now static.
5016 (debug_method_add): Use va_list and vsprintf rather than relying
5017 on undefined behavior with wrong number of arguments.
5018 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5019 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5020 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5021 since we're not interested in debugging glyphs with old libraries.
5022 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5023 GCC 4.6.0's static checking.
5024
0766b489
PE
50252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5026
31fd4b32
PE
5027 Integer overflow and signedness fixes (Bug#8873).
5028 A few related buffer overrun fixes, too.
5029
b79e8648
PE
5030 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5031
0766b489
PE
5032 * dispextern.h (struct face.stipple):
5033 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5034 (x_bitmap_mask, x_allocate_bitmap_record)
5035 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5036 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5037 (x_create_bitmap_from_xpm_data):
5038 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5039 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5040 (.bitmaps_last):
5041 * xfaces.c (load_pixmap):
5042 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5043 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5044 (.bitmaps_last, struct x_output.icon_bitmap):
5045 Use ptrdiff_t, not int, for bitmap indexes.
5046 (x_allocate_bitmap_record): Check for size overflow.
5047 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5048
b081724f
PE
5049 Use ptrdiff_t, not int, for overlay counts.
5050 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5051 * editfns.c (overlays_around, get_pos_property):
5052 * textprop.c (get_char_property_and_overlay):
5053 * xdisp.c (next_overlay_change, note_mouse_highlight):
5054 * xfaces.c (face_at_buffer_position):
21514da7
PE
5055 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5056 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5057 (Fnext_overlay_change, Fprevious_overlay_change)
5058 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5059 Use ptrdiff_t, not int, for sizes.
21514da7 5060 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5061
3de73e5e
PE
5062 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5063
2606c57b
PE
5064 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5065 (x_session_initialize): Do not assume string length fits in int.
5066
aaafe47a
PE
5067 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5068 This is unlikely, but can occur if DPI is outlandish.
5069
2674ddc8 5070 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5071 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5072
28154962
PE
5073 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5074 * xrdb.c (magic_file_p, search_magic_path):
5075 Omit last arg SUFFIX; it was always 0. All callers changed.
5076 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5077
7de51af5
PE
5078 * xfont.c (xfont_match): Avoid need for strlen.
5079
25ed6cc3
PE
5080 * xfns.c: Don't assume strlen fits in int.
5081 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5082
4eab31dd
PE
5083 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5084 not unsigned long, as we prefer signed integers. All callers changed.
5085 Detect integer overflow in repeat count.
5086 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5087 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5088
171e2a58
PE
5089 * termcap.c: Don't assume sizes fit in int and never overflow.
5090 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5091 (gobble_line): Check for size-calculation overflow.
5092
ad39faca 5093 * minibuf.c (Fread_buffer):
6e5bb2dc 5094 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5095 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5096 Don't assume string length fits in int.
5097
52c61c22 5098 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5099 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5100
b5b8c9e5
PE
5101 * font.c: Don't assume string length fits in int.
5102 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5103 Use ptrdiff_t, not int.
ccd6111c
PE
5104 (font_intern_prop): Don't assume string length fits in int.
5105 Don't assume integer property fits in fixnum.
5106 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5107
882f0d81 5108 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5109 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5110 Reformulate so as not to need the command string.
5111 Invoke gzip -cd rather than gunzip, as it's more portable.
5112 (lock_info_type, lock_file_1, lock_file):
5113 Don't assume pid_t and time_t fit in unsigned long.
5114 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5115 (current_lock_owner): Prefer signed type for sizes.
5116 Use memcpy, not strncpy, where memcpy is what is really wanted.
5117 Don't assume (via atoi) that time_t and pid_t fit in int.
5118 Check for time_t and/or pid_t out of range, e.g., via a network share.
5119 Don't alloca where an auto var works fine.
5120
93f4cf88
PE
5121 * fileio.c: Fix some integer overflow issues.
5122 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5123 Don't assume string length fits in int.
5124 (directory_file_name): Don't assume string length fits in long.
5125 (make_temp_name): Don't assume pid fits in int, or that its print
5126 length is less than 20.
5127
f3e92b69
PE
5128 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5129
1bfdaf10
PE
5130 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5131
35016e9a
PE
5132 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5133
3d1e65a1
PE
5134 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5135 We prefer signed integers, even for size calculations.
5136
0b963a93
PE
5137 * emacs.c: Don't assume string length fits in 'int'.
5138 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5139 (main): Don't invoke strlen when not needed.
5140
573f4b54
PE
5141 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5142 (XD_DEBUG_MESSAGE): Don't waste a byte.
5143
989f33ba
PE
5144 * callproc.c (getenv_internal_1, getenv_internal)
5145 (Fgetenv_internal):
965d34eb
PE
5146 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5147
e4d29b33
PE
5148 * lread.c (invalid_syntax): Omit length argument.
5149 All uses changed. This doesn't fix a bug, but it simplifies the
5150 code away from its former Hollerith-constant appearance, and it's
5151 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5152 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5153
eb49b136
PE
5154 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5155 This didn't break anything, but it didn't help either.
5156 It's confusing to put a bogus integer in a place where the actual
5157 value does not matter.
9f62aeb1 5158 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5159 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5160
15375a22
PE
5161 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5162 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5163 implementation.
b61cc01c
PE
5164 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5165 We prefer signed types, and the value cannot exceed the EMACS_INT
5166 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5167 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5168 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5169 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5170
53b2623d
PE
5171 * indent.c (sane_tab_width): New function.
5172 (current_column, scan_for_column, Findent_to, position_indentation)
5173 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5174 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5175
51cab52b 5176 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5177
f2ed8a70
PE
5178 * lisp.h (lint_assume): New macro.
5179 * composite.c (composition_gstring_put_cache):
5180 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5181
abe80cc6
PE
5182 * editfns.c, insdel.c:
5183 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5184
b02c740e
PE
5185 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5186
ebc96716
PE
5187 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5188
b4e50fa0 5189 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5190 Use much-faster test for byte-length change.
311d5d7c 5191 Don't assume string byte-length fits in 'int'.
a4cf38e4 5192 Check that character arg fits in 'int'.
85461888 5193 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5194
c0c1ee9f
PE
5195 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5196
a498d7f4
PE
5197 * fns.c (concat): Catch string overflow earlier.
5198 Do not rely on integer wraparound.
5199
51cab52b
PE
5200 * dispextern.h (struct it.overlay_strings_charpos)
5201 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5202 * xdisp.c (forward_to_next_line_start)
5203 (back_to_previous_visible_line_start)
5204 (reseat_at_next_visible_line_start, next_element_from_buffer):
5205 Don't arbitrarily truncate the value of 'selective' to int.
5206
76031fad
PE
5207 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5208
5eb55db9
PE
5209 * composite.c: Don't truncate sizes to 'int'.
5210 (composition_gstring_p, composition_reseat_it)
5211 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5212 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5213 not EMACS_UINT, for indexes.
5eb55db9 5214
0703a717
PE
5215 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5216
d6202519
PE
5217 * buffer.c: Include <verify.h>.
5218 (struct sortvec.priority, struct sortstr.priority):
8961a454 5219 Now EMACS_INT, not int.
c20998a7 5220 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5221 (struct sortstr.size, record_overlay_string)
5222 (struct sortstrlist.size, struct sortlist.used):
5223 Don't truncate size to int.
5224 (record_overlay_string): Check for size-calculation overflow.
d6202519 5225 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5226
d5a19415
JM
52272011-06-22 Jim Meyering <meyering@redhat.com>
5228
029529ac 5229 Don't leak an XBM-image-sized buffer
d5a19415
JM
5230 * image.c (xbm_load): Free the image buffer after using it.
5231
a9041e6c
PE
52322011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5233
5234 Port to Sun C.
5235 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5236 that Sun C diagnosed.
5237 * fns.c (secure_hash): Fix pointer signedness issue.
5238 * intervals.c (static_offset_intervals): New function.
5239 (offset_intervals): Use it.
5240
7f3f739f
LL
52412011-06-21 Leo Liu <sdl.web@gmail.com>
5242
5243 * deps.mk (fns.o):
5244 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5245 sha512.h.
5246
5247 * fns.c (secure_hash): Rename from crypto_hash_function and change
5248 the first arg to accept symbols.
5b66d427 5249 (Fsecure_hash): New primitive.
7f3f739f
LL
5250 (syms_of_fns): New symbols.
5251
76147d94
DD
52522011-06-20 Deniz Dogan <deniz@dogan.se>
5253
5254 * process.c (Fset_process_buffer): Clarify return value in
5255 docstring.
5256
7d7d0045
CY
52572011-06-18 Chong Yidong <cyd@stupidchicken.com>
5258
5259 * dispnew.c (add_window_display_history): Use BVAR.
5260
5261 * xdisp.c (debug_method_add): Use BVAR.
5262 (check_window_end, dump_glyph_matrix, dump_glyph)
5263 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5264
5265 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5266 Likewise.
5267
5268 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5269 check till after the cache is created in init_frame_faces.
5270
ff2bc410
SM
52712011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5272
5273 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5274
28177add
PE
52752011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5276
dd3482fe
PE
5277 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5278 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5279 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5280
393d71f3 5281 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5282 * fileio.c (Finsert_file_contents):
5283 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5284 Remove the old (too-loose) buffer overflow checks.
5285 They weren't needed, since make_gap checks for buffer overflow.
5286 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5287 The old code merely checked for Emacs fixnum overflow, and relied
5288 on undefined (wraparound) behavior. The new code avoids undefined
5289 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5290
2e6813b0 5291 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5292 Tune. Don't use wider integers than needed. Don't use alloca.
5293 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5294
599a9e4f
PE
5295 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5296
99561444
PE
5297 * insdel.c, lisp.h (buffer_overflow): New function.
5298 (insert_from_buffer_1, replace_range, replace_range_2):
5299 * insdel.c (make_gap_larger):
5300 * editfns.c (Finsert_char):
5301 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5302
28177add
PE
5303 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5304
e69dafad
PE
53052011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5306
4baa020d 5307 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5308
b1c46f02
PE
5309 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5310 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5311
e69dafad
PE
5312 * fileio.c: Don't assume EMACS_INT fits in off_t.
5313 (emacs_lseek): New static function.
5314 (Finsert_file_contents, Fwrite_region): Use it.
5315 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5316
566684ea
PE
5317 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5318
e6966cd6
PE
5319 * fns.c: Don't overflow int when computing a list length.
5320 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5321 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5322 truncation on 64-bit hosts. Check for QUIT every
5323 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5324 faster and is responsive enough.
5325 (Flength): Report an error instead of overflowing an integer.
5326 (Fsafe_length): Return a float if the value is not representable
5327 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5328 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5329 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5330
dd0b0efb
PE
5331 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5332 (header_size, word_size): New constants.
5333 (allocate_vectorlike): Don't check size overflow here.
5334 (allocate_vector): Check it here instead, since this is the only
5335 caller of allocate_vectorlike that could cause overflow.
5336 Check that the new vector's length is representable as a fixnum.
5337
86fe5cfe
PE
5338 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5339 The previous code was bogus. For example, next_almost_prime (32)
5340 returned 39, which is undesirable as it is a multiple of 3; and
5341 next_almost_prime (24) returned 25, which is a multiple of 5 so
5342 why was the code bothering to check for multiples of 7?
5343
80e88859
PE
5344 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5345
4a2f0ad6
PE
5346 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5347
f66c7cf8
PE
5348 Variadic C functions now count arguments with ptrdiff_t.
5349 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5350 Back then I didn't know that the Emacs coding style prefers signed int.
5351 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5352 were being counted with int, which may truncate counts on 64-bit
5353 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5354 * lisp.h (struct Lisp_Subr.function.aMANY)
5355 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5356 Arg counts are now ptrdiff_t, not size_t.
5357 All variadic functions and their callers changed accordingly.
5358 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5359 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5360 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5361 * callint.c (Fcall_interactively): Check arg count for overflow,
5362 to avoid potential buffer overrun. Use signed char, not 'int',
5363 for 'varies' array, so that we needn't bother to check its size
5364 calculation for overflow.
5365 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5366 * eval.c (apply_lambda):
5367 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5368 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5369 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5370
a1759b76
PE
5371 * callint.c (Fcall_interactively): Don't use index var as event count.
5372
d96be9fc
PE
5373 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5374 * mem-limits.h (SIZE): Remove; no longer used.
5375
a690a978 5376 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5377
578c21e6
PE
5378 Remove unnecessary casts.
5379 * xterm.c (x_term_init):
5380 * xfns.c (x_set_border_pixel):
5381 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5382 These aren't needed now that we assume ANSI C.
5383
96f53c6c
PE
5384 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5385 It's more likely to cause problems (due to unsigned overflow)
5386 than to cure them.
5387
83c77d31
PE
5388 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5389
ee2079f1
PE
5390 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5391
6da65536
PE
5392 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5393
7147c4a4
PE
5394 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5395
193e32d9
PE
5396 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5397
e5533da6
PE
5398 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5399
9910e595
PE
5400 GLYPH_CODE_FACE returns EMACS_INT, not int.
5401 * dispextern.h (merge_faces):
5402 * xfaces.c (merge_faces):
01103c44
PE
5403 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5404 Don't assume EMACS_INT fits in int.
9910e595 5405
2638320e
PE
5406 * character.h (CHAR_VALID_P): Remove unused parameter.
5407 * fontset.c, lisp.h, xdisp.c: All uses changed.
5408
045eb8d9
PE
5409 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5410
c1f134b5
PE
5411 * fns.c (concat): Minor tuning based on overflow analysis.
5412 This doesn't fix any bugs. Use int to hold character, instead
5413 of constantly refetching from Emacs object. Use XFASTINT, not
5414 XINT, for value known to be a character. Don't bother comparing
5415 a single byte to 0400, as it's always less.
5416
395fcb93 5417 * floatfns.c (Fexpt):
327eeec8
PE
5418 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5419
abbd3d23
PE
5420 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5421 for characters.
5422
684a03ef
PE
5423 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5424
0fed43f3
PE
5425 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5426 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5427 incorrectly succeed when S was a string, because 4294967386 was
5428 truncated before it was used.
5429
8fd02eb7
PE
5430 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5431 Otherwise, an out-of-range integer could cause undefined behavior
5432 on a 64-bit host.
5433
f8c86b69
PE
5434 * composite.c: Use int, not EMACS_INT, for characters.
5435 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5436 EMACS_INT, for values that are known to be in character range.
5437 This doesn't fix any bugs but is the usual style inside Emacs and
5438 may generate better code on 32-bit machines.
5439
34206dd2
PE
5440 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5441 This is for reasons similar to the recent CHAR_STRING fix.
5442 * charset.c (Fencode_char): Check that character arg is actually
5443 a character. Pass an int to ENCODE_CHAR.
5444 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5445 wider than 'int', as a compile-time check to prevent future regressions
5446 in this area.
5447
c5958d4c 5448 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5449
5450 Make sure a 64-bit char is never passed to CHAR_STRING.
5451 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5452 by silently ignoring the top 32 bits, allowing some values
5453 that were far too large to be valid characters.
5454 * character.h: Include <verify.h>.
5455 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5456 arguments are no wider than unsigned, as a compile-time check
5457 to prevent future regressions in this area.
5458 * data.c (Faset):
01103c44 5459 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5460 (Fsubst_char_in_region):
5461 * fns.c (concat):
5462 * xdisp.c (decode_mode_spec_coding):
5463 Adjust to CHAR_STRING's new requirement.
5464 * editfns.c (Finsert_char, Fsubst_char_in_region):
5465 * fns.c (concat): Check that character args are actually
5466 characters. Without this test, these functions did the wrong
5467 thing with wildly out-of-range values on 64-bit hosts.
5468
d37ca623
PE
5469 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5470 These casts should not be needed on 32-bit hosts, either.
5471 * keyboard.c (read_char):
5472 * lread.c (Fload): Remove casts to unsigned.
5473
ea204efb
PE
5474 * lisp.h (UNSIGNED_CMP): New macro.
5475 This fixes comparison bugs on 64-bit hosts.
5476 (ASCII_CHAR_P): Use it.
5477 * casefiddle.c (casify_object):
01103c44 5478 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5479 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5480 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5481 * dispextern.h (FACE_FROM_ID):
5482 * keyboard.c (read_char): Use UNSIGNED_CMP.
5483
41cb286c
PE
5484 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5485 not to EMACS_INT, to avoid GCC warning.
5486
4a1b9832
PE
5487 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5488
55daad71
PE
5489 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5490 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5491 isn't needed on 32-bit machines.
8f95c75c 5492
01103c44
PE
5493 * buffer.c (Fgenerate_new_buffer_name):
5494 Use EMACS_INT for count, not int.
0ceccced 5495 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5496
5497 * data.c (Qcompiled_function): Now static.
5498
c6f072e7
PE
5499 * window.c (window_body_lines): Now static.
5500
20ce5912
PE
5501 * image.c (gif_load): Rename local to avoid shadowing.
5502
9c4c5f81
PE
5503 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5504 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5505 * alloc.c (make_save_value): Integer argument is now of type
5506 ptrdiff_t, not int.
5507 (mark_object): Use ptrdiff_t, not int.
5508 * lisp.h (pD): New macro.
5509 * print.c (print_object): Use it.
5510
c0c5c8ae
PE
5511 * alloc.c: Use EMACS_INT, not int, to count objects.
5512 (total_conses, total_markers, total_symbols, total_vector_size)
5513 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5514 (total_free_floats, total_floats, total_free_intervals)
5515 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5516 Now EMACS_INT, not int. All uses changed.
5517 (Fgarbage_collect): Compute overall total using a double, so that
5518 integer overflow is less likely to be a problem. Check for overflow
5519 when converting back to an integer.
5a25e253
PE
5520 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5521 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5522 These were 'int' variables that could overflow on 64-bit hosts;
5523 they were never used, so remove them instead of repairing them.
211a0b2a 5524 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5525 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5526 Previously, this ceilinged at INT_MAX, but that doesn't work on
5527 64-bit machines.
e46bb31a 5528 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5529
c78baabf 5530 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5531 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5532 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5533 when a (possibly-narrower) signed value would do just as well.
5534 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5535
c9d624c6
PE
5536 * alloc.c: Catch some string size overflows that we were missing.
5537 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5538 for convenience in STRING_BYTES_MAX.
5539 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5540 The definition here is exact; the one in lisp.h was approximate.
5541 (allocate_string_data): Check for string overflow. This catches
5542 some instances we weren't catching before. Also, it catches
5543 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5544 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5545 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5546
c9d624c6
PE
5547 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5548 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5549 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5550
353032ce
PE
5551 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5552
2bccce07
PE
5553 * alloc.c (Fmake_string): Check for out-of-range init.
5554
0ac30604
SM
55552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5556
5557 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5558
c195f2de
JD
55592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5560
5561 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5562 xg_get_default_scrollbar_width.
5563
5564 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5565 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5566 (style_changed_cb): Call update_theme_scrollbar_width and call
5567 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5568 all frames (Bug#8505).
5569 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5570 Call gtk_window_set_resizable if HAVE_GTK3.
5571 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5572 and height if HAVE_GTK3 (Bug#8505).
5573 (scroll_bar_width_for_theme): New variable.
5574 (update_theme_scrollbar_width): New function.
5575 (xg_get_default_scrollbar_width): Move code to
5576 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5577 (xg_initialize): Call update_theme_scrollbar_width.
5578
5579 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5580
5581 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5582
e10ac9f1
MR
55832011-06-12 Martin Rudalics <rudalics@gmx.at>
5584
5585 * frame.c (make_frame): Call other_buffer_safely instead of
5586 other_buffer.
5587
5588 * window.c (temp_output_buffer_show): Call display_buffer with
5589 second argument Vtemp_buffer_show_specifiers and reset latter
5590 immediately after the call.
5591 (Vtemp_buffer_show_specifiers): New variable.
5592 (auto_window_vscroll_p, next_screen_context_lines)
5593 (Vscroll_preserve_screen_position): Remove leading asterisks from
5594 doc-strings.
5595
2d3c217e 55962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5597
7b7f97e8 5598 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5599 * buffer.c (Qclone_number): Remove for now, as it's unused.
5600 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5601 (record_buffer): Remove unused local.
5602 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5603 (set_frame_buffer_list): Remove; unused.
5604 * frame.h (other_visible_frames): Remove decl.
5605 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5606 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5607 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5608 if HAVE_GPM.
5609 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5610 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5611 Define only if HAVE_GPM.
5612 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5613 (update_hints_inhibit): Remove; never set. All uses removed.
5614 * widgetprv.h (emacsFrameClassRec): Remove decl.
5615 * window.c (delete_deletable_window): Now returns void, since it
5616 wasn't returning anything.
5617 (compare_window_configurations): Remove unused locals.
5618 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5619 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5620 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5621 the same widths as pointers. This follows up on the 2011-05-06 patch.
5622 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5623 * xterm.h: Likewise.
5624 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5625
1384b89e
JB
56262011-06-12 Juanma Barranquero <lekktu@gmail.com>
5627
5628 * makefile.w32-in: Update dependencies.
5629 (LISP_H): Add lib/intprops.h.
5630
1100a63c
CY
56312011-06-11 Chong Yidong <cyd@stupidchicken.com>
5632
5633 * image.c (gif_load): Add animation frame delay to the metadata.
5634 (syms_of_image): Use DEFSYM. New symbol `delay'.
5635
6198ccd0
MR
56362011-06-11 Martin Rudalics <rudalics@gmx.at>
5637
5638 * window.c (delete_deletable_window): Re-add.
5639 (Fset_window_configuration): Rewrite to handle dead buffers and
5640 consequently deletable windows.
5641 (window_tree, Fwindow_tree): Remove. Supply functionality in
5642 window.el.
5643 (compare_window_configurations): Simplify code.
5644
b6e3633c
AS
56452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5646
1ab0dee5
AS
5647 * image.c (imagemagick_load_image): Fix type mismatch.
5648 (Fimagemagick_types): Likewise.
5649
b6e3633c
AS
5650 * window.h (replace_buffer_in_windows): Declare.
5651
9397e56f
MR
56522011-06-11 Martin Rudalics <rudalics@gmx.at>
5653
5654 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5655 Qclone_number. Remove external declaration of Qdelete_window.
5656 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5657 code.
640c8776
SM
5658 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5659 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5660 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5661 buffer list implementation.
5662 (other_buffer_safely): New function.
5663 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5664 calls to replace_buffer_in_windows and
5665 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5666 if allowed.
5667 (record_buffer): Inhibit quitting and rewrite using quittable
5668 functions. Run Qbuffer_list_update_hook if allowed.
5669 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5670 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5671 Move switch-to-buffer to window.el.
9397e56f
MR
5672 (bury-buffer): Move to window.el.
5673 (Vbuffer_list_update_hook): New variable.
5674
5675 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5676 section.
5677
5678 * window.h (resize_frame_windows): Move up in code.
5679 (Fwindow_frame): Remove EXFUN.
5680 (replace_buffer_in_all_windows): Remove prototype.
5681 (replace_buffer_in_windows_safely): Add prototype.
5682
5683 * window.c: Declare Qdelete_window static again. Move down
5684 declaration of select_count.
5685 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5686 (Fother_window): Move to window.el.
5687 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5688 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5689 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5690 window.el.
5691 (replace_buffer_in_windows): Implement by calling
5692 Qreplace_buffer_in_windows.
5693 (replace_buffer_in_all_windows): Remove with some functionality
5694 moved into replace_buffer_in_windows_safely.
5695 (replace_buffer_in_windows_safely): New function.
5696 (select_window_norecord, select_frame_norecord): Move in front
5697 of run_window_configuration_change_hook. Remove now obsolete
5698 declarations.
640c8776
SM
5699 (Fset_window_buffer): Rewrite doc-string.
5700 Call Qrecord_window_buffer.
9397e56f
MR
5701 (keys_of_window): Move binding for other-window to window.el.
5702
b50691aa
CY
57032011-06-11 Chong Yidong <cyd@stupidchicken.com>
5704
5705 * dispextern.h (struct image): Replace data member, whose int_val
5706 and ptr_val fields were not used by anything, with a single
5707 lisp_val object.
5708
5709 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5710 (gif_clear_image, gif_load, imagemagick_load_image)
5711 (gs_clear_image, gs_load): Callers changed.
5712
3f754b86
PE
57132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5714
cca69397
PE
5715 * buffer.h: Include <time.h>, for time_t.
5716 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5717
109e28d0
PE
5718 Fix minor problems found by static checking.
5719
60737f02
PE
5720 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5721
4b66faf3
PE
5722 Make identifiers static if they are not used in other modules.
5723 * data.c (Qcompiled_function, Qframe, Qvector):
5724 * image.c (QimageMagick, Qsvg):
5725 * minibuf.c (Qmetadata):
5726 * window.c (resize_window_check, resize_root_window): Now static.
5727 * window.h (resize_window_check, resize_root_window): Remove decls.
5728
109e28d0
PE
5729 * window.c (window_deletion_count, delete_deletable_window):
5730 Remove; unused.
46a4ce9e
PE
5731 (window_body_lines): Now static.
5732 (Fdelete_other_windows_internal): Mark vars as initialized.
5733 Make sure 'resize_failed' is initialized.
5734 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5735 (resize_window_apply): Remove unused local.
5736 * window.h (delete_deletable_window): Remove decl.
5737
109e28d0 5738 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5739 (imagemagick_load_image): Fix pointer signedness problem by changing
5740 last arg from unsigned char * to char *. All uses changed.
5741 Also, fix a local for similar reasons.
5742 Remove unused locals. Remove locals to avoid shadowing.
5743 (fn_rsvg_handle_free): Remove; unused.
5744 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5745 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5746
3f754b86
PE
5747 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5748
2547adb1
CY
57492011-06-10 Chong Yidong <cyd@stupidchicken.com>
5750
5751 * image.c (gif_load): Fix omitted cast error introduced by
5752 2011-06-06 change.
5753
2c8e37d4
MR
57542011-06-10 Martin Rudalics <rudalics@gmx.at>
5755
5756 * window.h (resize_proportionally, orig_total_lines)
5757 (orig_top_line): Remove from window structure.
5758 (set_window_height, set_window_width, change_window_heights)
5759 (Fdelete_window): Remove prototypes.
5760 (resize_frame_windows): Remove duplicate declaration.
5761
440a42e3
EZ
57622011-06-10 Eli Zaretskii <eliz@gnu.org>
5763
5764 * window.h (resize_frame_windows, resize_window_check)
5765 (delete_deletable_window, resize_root_window)
5766 (resize_frame_windows): Declare prototypes.
5767
5768 * window.c (resize_window_apply): Make definition be "static" to
5769 match the prototype.
5770
562dd5e9
MR
57712011-06-10 Martin Rudalics <rudalics@gmx.at>
5772
5773 * window.c: Remove declarations of Qwindow_size_fixed,
5774 window_min_size_1, window_min_size_2, window_min_size,
5775 size_window, window_fixed_size_p, enlarge_window, delete_window.
5776 Remove static from declaration of Qdelete_window, it's
5777 temporarily needed by Fbury_buffer.
5778 (replace_window): Don't assign orig_top_line and
5779 orig_total_lines.
5780 (Fdelete_window, delete_window): Remove. Window deletion is
5781 handled by window.el.
640c8776
SM
5782 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5783 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5784 (Fdelete_other_windows): Remove. Deleting other windows is
5785 handled by window.el.
5786 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5787 handled in window.el.
5788 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5789 Window minimum sizes are handled in window.el.
5790 (shrink_windows, size_window, set_window_height)
5791 (set_window_width, change_window_heights, window_height)
5792 (window_width, CURBEG, CURSIZE, enlarge_window)
5793 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5794 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5795 handled in window.el.
5796 (make_dummy_parent): Rename to make_parent_window and give it a
5797 second argument horflag.
5798 (make_window): Don't set resize_proportionally any more.
5799 (Fsplit_window): Remove. Windows are split in window.el.
5800 (save_restore_action, save_restore_orig_size)
5801 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5802 Resize mini windows in window.el.
5803 (grow_mini_window, shrink_mini_window): Implement by calling
5804 Qresize_root_window_vertically, resize_window_check and
5805 resize_window_apply.
640c8776
SM
5806 (saved_window, Fset_window_configuration, save_window_save):
5807 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5808 resize_proportionally.
5809 (window_min_height, window_min_width): Move to window.el.
5810 (keys_of_window): Move bindings for delete-other-windows,
5811 split-window, delete-window and enlarge-window to window.el.
5812
5813 * buffer.c: Temporarily extern Qdelete_window.
5814 (Fbury_buffer): Temporarily call Qdelete_window instead of
5815 Fdelete_window (Fbury_buffer will move to window.el soon).
5816
5817 * frame.c (set_menu_bar_lines_1): Remove code handling
5818 orig_top_line and orig_total_lines.
5819
5820 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5821 set_window_height but set heights directly.
5822 (change_frame_size_1): Use resize_frame_windows.
5823
5824 * xdisp.c (init_xdisp): Don't use set_window_height but set
5825 heights directly.
5826
640c8776
SM
5827 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5828 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5829 run_window_configuration_change_hook.
5830
5831 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5832 instead of change_window_heights and run
5833 run_window_configuration_change_hook.
5834
1a13852e
MR
58352011-06-09 Martin Rudalics <rudalics@gmx.at>
5836
5837 * window.c (replace_window): Rename second argument REPLACEMENT to
5838 NEW. New third argument SETFLAG. Rewrite.
5839 (delete_window, make_dummy_parent): Call replace_window with
5840 third argument 1.
5841 (window_list_1): Move down in code.
5842 (run_window_configuration_change_hook): Move set_buffer part
5843 before select_frame_norecord part in order to unwind correctly.
5844 Rename count1 to count.
5845 (recombine_windows, delete_deletable_window, resize_root_window)
5846 (Fdelete_other_windows_internal)
5847 (Frun_window_configuration_change_hook, make_parent_window)
5848 (resize_window_check, resize_window_apply, Fresize_window_apply)
5849 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5850 (Fdelete_window_internal, Fresize_mini_window_internal):
5851 New functions.
1a13852e
MR
5852 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5853
f3d1777e
MR
58542011-06-08 Martin Rudalics <rudalics@gmx.at>
5855
496e208e
MR
5856 * window.h (window): Add some new members to window structure -
5857 normal_lines, normal_cols, new_total, new_normal, clone_number,
5858 splits, nest, prev_buffers, next_buffers.
5859 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5860 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5861
f3d1777e
MR
5862 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5863 Remove.
496e208e
MR
5864 (make_dummy_parent): Set new members of windows structure.
5865 (make_window): Move down in code. Handle new members of window
5866 structure.
5867 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5868 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5869 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5870 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5871 (Fset_window_next_buffers, Fset_window_clone_number):
5872 New functions.
496e208e
MR
5873 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5874 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5875 Doc-string fixes.
5876 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5877 Argument WINDOW can be now internal window too.
5878 (Fwindow_use_time): Move up in code.
5879 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5880 Rewrite doc-string.
5881 (Fset_window_configuration, saved_window)
5882 (Fcurrent_window_configuration, save_window_save): Handle new
5883 members of window structure.
b9e809c2
MR
5884 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5885 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5886 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5887 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5888 Qget_mru_window, Qresize_root_window,
5889 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5890 Qauto_buffer_name; staticpro them.
f3d1777e 5891
abde8f8c
MR
58922011-06-07 Martin Rudalics <rudalics@gmx.at>
5893
5894 * window.c (Fwindow_total_size, Fwindow_left_column)
5895 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5896 (Fwindow_list_1): New functions.
5897 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5898 (Fwindow_width, Fscroll_left, Fscroll_right):
5899 Use window_body_cols instead of window_box_text_cols.
5900 (delete_window, Fset_window_configuration):
5901 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5902 (delete_all_subwindows): Take a window as argument and not a
5903 structure. Rewrite.
190b47e6
MR
5904 (window_loop): Remove handling of GET_LRU_WINDOW and
5905 GET_LARGEST_WINDOW.
5906 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5907
5908 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5909 window_box_text_cols. delete_all_subwindows now takes a
5910 Lisp_Object as argument.
abde8f8c 5911
640c8776
SM
5912 * indent.c (compute_motion, Fcompute_motion):
5913 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5914
fa8a67e6
MR
5915 * frame.c (delete_frame): Call delete_all_subwindows with root
5916 window as argument.
5917
a54e3482
DC
59182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5919
5920 * fns.c (Fputhash): Document return value.
5921
60002bf5
CY
59222011-06-06 Chong Yidong <cyd@stupidchicken.com>
5923
5924 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5925
0c671da6 59262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5927
b862a52a 5928 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5929
be44ca6c
PE
5930 Check for overflow when converting integer to cons and back.
5931 * charset.c (Fdefine_charset_internal, Fdecode_char):
5932 Use cons_to_unsigned to catch overflow.
5933 (Fencode_char): Use INTEGER_TO_CONS.
5934 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5935 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5936 * data.c (long_to_cons, cons_to_long): Remove.
5937 (cons_to_unsigned, cons_to_signed): New functions.
5938 These signal an error for invalid or out-of-range values.
5939 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5940 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5941 * font.c (Ffont_variation_glyphs):
5942 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5943 * lisp.h: Include <intprops.h>.
5944 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5945 (cons_to_signed, cons_to_unsigned): New decls.
5946 (long_to_cons, cons_to_long): Remove decls.
5947 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5948 (Fprimitive_undo): Use CONS_TO_INTEGER.
5949 * xfns.c (Fx_window_property): Likewise.
5950 * xselect.c: Include <limits.h>.
5951 (x_own_selection, selection_data_to_lisp_data):
5952 Use INTEGER_TO_CONS.
5953 (x_handle_selection_request, x_handle_selection_clear)
5954 (x_get_foreign_selection, Fx_disown_selection_internal)
5955 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5956 (lisp_data_to_selection_data): Use cons_to_unsigned.
5957 (x_fill_property_data): Use cons_to_signed.
5958 Report values out of range.
5959
d1f3d2af
PE
5960 Check for buffer and string overflow more precisely.
5961 * buffer.h (BUF_BYTES_MAX): New macro.
5962 * lisp.h (STRING_BYTES_MAX): New macro.
5963 * alloc.c (Fmake_string):
5964 * character.c (string_escape_byte8):
5965 * coding.c (coding_alloc_by_realloc):
5966 * doprnt.c (doprnt):
5967 * editfns.c (Fformat):
5968 * eval.c (verror):
5969 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5970 since they may not be the same number.
5971 * editfns.c (Finsert_char):
5972 * fileio.c (Finsert_file_contents):
5973 Likewise for BUF_BYTES_MAX.
5974
dd52fcea
PE
5975 * image.c: Use ptrdiff_t, not int, for sizes.
5976 (slurp_file): Switch from int to ptrdiff_t.
5977 All uses changed.
5978 (slurp_file): Check that file size fits in both size_t (for
5979 malloc) and ptrdiff_t (for sanity and safety).
5980
7f9bbdbb
PE
5981 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5982 if b->modtime has its maximal value.
5983
dfe18f82
PE
5984 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5985
84acfcf0
PE
5986 Don't assume time_t can fit into int.
5987 * buffer.h (struct buffer.modtime): Now time_t, not int.
5988 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5989 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5990
ccd9a01a
PE
5991 Minor fixes for signed vs unsigned integers.
5992 * character.h (MAYBE_UNIFY_CHAR):
5993 * charset.c (maybe_unify_char):
5994 * keyboard.c (read_char, reorder_modifiers):
5995 XINT -> XFASTINT, since the integer must be nonnegative.
5996 * ftfont.c (ftfont_spec_pattern):
5997 * keymap.c (access_keymap, silly_event_symbol_error):
5998 XUINT -> XFASTINT, since the integer must be nonnegative.
5999 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6000 since it makes no difference and we prefer signed.
6001 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6002 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6003 nonnegative.
6004
d6d100dd
SM
60052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6006
6007 * window.h (Fwindow_frame): Declare.
6008
2b6148e4
PE
60092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6010
6011 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6012 (SPARE_MEMORY): Always define.
6013 (LARGE_REQUEST): Remove.
6014 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6015
f230ecc9
MR
60162011-06-06 Martin Rudalics <rudalics@gmx.at>
6017
727e958e
MR
6018 * lisp.h: Move EXFUNS for Fframe_root_window,
6019 Fframe_first_window and Fset_frame_selected_window to window.h.
6020
6021 * window.h: Move EXFUNS for Fframe_root_window,
6022 Fframe_first_window and Fset_frame_selected_window here from
6023 lisp.h.
6024
6025 * frame.c (Fwindow_frame, Fframe_first_window)
6026 (Fframe_root_window, Fframe_selected_window)
6027 (Fset_frame_selected_window): Move to window.c.
6028 (Factive_minibuffer_window): Move to minibuf.c.
6029 (Fother_visible_frames_p): New function.
6030
6031 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6032
f230ecc9
MR
6033 * window.c (decode_window, decode_any_window): Move up in code.
6034 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6035 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6036 (Fwindow_buffer): Move up and rewrite doc-string.
6037 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6038 (Fwindow_prev): New functions.
727e958e
MR
6039 (Fwindow_frame): Move here from frame.c. Accept any window as
6040 argument.
6041 (Fframe_root_window, Fframe_first_window)
6042 (Fframe_selected_window): Move here from frame.c. Accept frame
6043 or arbitrary window as argument. Update doc-strings.
6044 (Fminibuffer_window): Move up in code.
6045 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6046 (Fset_frame_selected_window): Move here from frame.c.
6047 Marginal rewrite.
727e958e
MR
6048 (Fselected_window, select_window, Fselect_window): Move up in
6049 code. Minor doc-string fixes.
f230ecc9 6050
4d09bcf6
PE
60512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6052
6053 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6054 Do not assume that spare memory exists; that assumption is valid
6055 only if SYSTEM_MALLOC.
6056 (LARGE_REQUEST): New macro, so that the issue of large requests
6057 is separated from the issue of spare memory.
6058
810928a2
AS
60592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6060
172418ad
AS
6061 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6062 format. (Bug#8806)
6063
43f862f7
AS
6064 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6065
810928a2
AS
6066 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6067 before statements.
6068
a059fe24
JD
60692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6070
6071 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6072
6073 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6074
6075 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6076 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6077
989bf368
JB
60782011-06-05 Juanma Barranquero <lekktu@gmail.com>
6079
6080 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6081
4b80f674
CY
60822011-06-04 Chong Yidong <cyd@stupidchicken.com>
6083
6084 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6085 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6086 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6087 New error handlers.
4b80f674
CY
6088 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6089 Obey Vx_select_enable_clipboard_manager. Catch errors in
6090 x_clipboard_manager_save (Bug#8779).
6091 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6092 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6093
99a33b77 60942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6095
6096 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6097
99a33b77 60982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6099
6100 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6101 in the current matrix if keep_current_p is non-zero.
6102
8264569d
EZ
61032011-06-04 Eli Zaretskii <eliz@gnu.org>
6104
6105 * bidi.c (bidi_level_of_next_char): Fix last change.
6106
57f97249
EZ
61072011-06-03 Eli Zaretskii <eliz@gnu.org>
6108
fec2107c 6109 Support bidi reordering of text covered by display properties.
57f97249 6110
fec2107c
EZ
6111 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6112 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6113 (bidi_cache_search, bidi_cache_iterator_state)
6114 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6115 (bidi_level_of_next_char, bidi_move_to_visually_next):
6116 Support character positions inside a run of characters covered by a
fec2107c
EZ
6117 display string.
6118 (bidi_paragraph_init, bidi_resolve_explicit_1)
6119 (bidi_level_of_next_char): Call bidi_fetch_char and
6120 bidi_fetch_char_advance instead of FETCH_CHAR and
6121 FETCH_CHAR_ADVANCE.
6122 (bidi_init_it): Initialize new members.
6123 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6124 definitions.
6125 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6126 instead of using explicit *_CHAR codes.
d6d100dd
SM
6127 (bidi_resolve_explicit, bidi_resolve_weak):
6128 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6129 bidirectional text is supported only in multibyte buffers.
6130 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6131 it to initialize the frame_window_p member of struct bidi_it.
6132 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6133 (bidi_resolve_explicit, bidi_resolve_weak)
6134 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6135 bidi_it->nchars is non-positive.
6136 (bidi_level_of_next_char): Don't try to lookup the cache for the
6137 next/previous character if nothing is cached there yet, or if we
6138 were just reseat()'ed to a new position.
c40e2fb2 6139
0e14fe90
EZ
6140 * xdisp.c (set_cursor_from_row): Set start and stop points
6141 according to the row's direction when priming the loop that looks
6142 for the glyph on which to display cursor.
6143 (single_display_spec_intangible_p): Function deleted.
6144 (display_prop_intangible_p): Reimplement to call
6145 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6146 Accept 3 additional arguments needed by handle_display_spec.
6147 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6148 values: lists, `(when COND...)' forms, etc.
6149 (single_display_spec_string_p): Support property values that are
6150 lists with the argument STRING its top-level element.
6151 (display_prop_string_p): Fix the condition for processing a
6152 property that is a list to be consistent with handle_display_spec.
fec2107c 6153 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6154 last portion of handle_display_prop.
6155 (compute_display_string_pos): Accept additional argument
6156 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6157 value of a `display' property is a "replacing spec".
6158 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6159 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6160 the display property, but just return a value indicating whether
6161 the display property will replace the characters it covers.
6162 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6163 frame_window_p members of struct bidi_it.
d6d100dd
SM
6164 (compute_display_string_pos, compute_display_string_end):
6165 New functions.
fec2107c
EZ
6166 (push_it): Accept second argument POSITION, where pop_it should
6167 jump to continue iteration.
6168 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6169
fec2107c
EZ
6170 * keyboard.c (adjust_point_for_property): Adjust the call to
6171 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6172
6173 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6174 (bidi_init_it): Update prototypes.
6175 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6176 (compute_display_string_pos, compute_display_string_end):
6177 Declare prototypes.
fec2107c
EZ
6178 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6179 EMACS_INT.
fc6f18ce 6180
40087514 61812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6182
57f53182
PE
6183 Malloc failure behavior now depends on size of allocation.
6184 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6185 * lisp.h: Change signatures accordingly.
6186 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6187 All callers changed. (Bug#8762)
6188
6189 * gnutls.c: Use Emacs's memory allocators.
6190 Without this change, the gnutls library would invoke malloc etc.
6191 directly, which causes problems on non-SYNC_INPUT hosts, and which
6192 runs afoul of improving memory_full behavior. (Bug#8761)
6193 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6194 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6195 xfree instead of the default malloc, realloc, free.
6196 (Fgnutls_boot): No need to check for memory allocation failure,
6197 since xmalloc does that for us.
6198
ac32cd99 6199 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6200 * category.c (hash_get_category_set):
6201 * ccl.c (ccl_driver):
6202 * charset.c (Fdefine_charset_internal):
6203 * charset.h (struct charset.hash_index):
6204 * composite.c (get_composition_id, gstring_lookup_cache)
6205 (composition_gstring_put_cache):
6206 * composite.h (struct composition.hash_index):
6207 * dispextern.h (struct image.hash):
6208 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6209 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6210 (hashfn_equal, hashfn_user_defined, make_hash_table)
6211 (maybe_resize_hash_table, hash_lookup, hash_put)
6212 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6213 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6214 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6215 * image.c (make_image, search_image_cache, lookup_image)
6216 (xpm_put_color_table_h):
6217 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6218 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6219 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6220 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6221 * alloc.c (allocate_vectorlike):
6222 Check for overflow in vector size calculations.
6223 * ccl.c (ccl_driver):
6224 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6225 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6226 need to be updated by these changes.
40087514
PE
6227 * fns.c (make_hash_table, maybe_resize_hash_table):
6228 Check for integer overflow with large hash tables.
0de4bb68
PE
6229 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6230 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6231 (SXHASH_REDUCE): New macro.
6232 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6233 Use it instead of discarding useful hash info with large hash values.
6234 (sxhash_float): New function.
6235 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6236 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6237 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6238 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6239 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6240 Adjust signatures to match updated version of code.
6241 (consing_since_gc): Now EMACS_INT, since a single hash table can
6242 use more than INT_MAX bytes.
6243
698d32e2
DN
62442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6245
6246 Make it possible to build with GCC-4.6+ -O2 -flto.
6247
6248 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6249
fd6fa53f
SM
62502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6251
6252 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6253 Call minibuffer-inactive-mode.
6254
864db017
JB
62552011-05-31 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6258 Update dependencies.
6259
2ad0baf4
DN
62602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6261
6262 * data.c (init_data): Remove code for UTS, this system is not
6263 supported anymore.
6264
4fcc2638
DN
62652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6266
6267 Don't force ./temacs to start in terminal mode.
6268
6269 * frame.c (make_initial_frame): Initialize faces in all cases, not
6270 only when CANNOT_DUMP is defined.
6271 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6272
c56e0fd5
DN
62732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6274
6275 * dispnew.c (add_window_display_history): Use const for the string
6276 pointer. Remove declaration, not needed.
6277
333d54da 62782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6279
55d4c1b2 6280 Use 'inline', not 'INLINE'.
333d54da 6281 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6282 * alloc.c, fontset.c (INLINE): Remove.
6283 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6284 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6285 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6286 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6287 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6288
738db178
DN
62892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6290
6291 Make it possible to run ./temacs.
6292
6293 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6294 syms_of_callproc does the same thing. Remove test for
6295 "initialized", do it in the caller.
6296 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6297
620c53a6
SM
62982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6299
6300 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6301 (read_minibuf): Use get_minibuffer.
6302 (syms_of_minibuf): Use DEFSYM.
6303 (Qmetadata): New var.
6304 * data.c (Qbuffer): Don't make it static.
6305 (syms_of_data): Use DEFSYM.
6306
e003a292
PE
63072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6308
6309 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6310 (CCL_CODE_MIN): New macro.
6311
ed008a6d
PE
63122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6313
3687c2ef
PE
6314 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6315
ed008a6d
PE
6316 * eval.c (Qdebug): Now static.
6317 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6318 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6319 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6320
d66c4c7c
CY
63212011-05-29 Chong Yidong <cyd@stupidchicken.com>
6322
6323 * image.c: Various fixes to ImageMagick code comments.
6324 (Fimagemagick_types): Doc fix.
6325
5fbc2025
PE
63262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6327
0196f88a
PE
6328 Minor fixes prompted by GCC 4.6.0 warnings.
6329
6330 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6331
5fbc2025
PE
6332 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6333 (x_clipboard_manager_save_all): Move extern decl to ...
6334 * xterm.h: ... here, so that it can be checked for consistency.
6335
1dd3c2d9
CY
63362011-05-29 Chong Yidong <cyd@stupidchicken.com>
6337
6338 * xselect.c (x_clipboard_manager_save_frame)
6339 (x_clipboard_manager_save_all): New functions.
6340 (Fx_clipboard_manager_save): Lisp function deleted.
6341
6342 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6343 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6344
6345 * xterm.h: Update prototype.
6346
5ba6571d
WX
63472011-05-28 William Xu <william.xwl@gmail.com>
6348
6349 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6350 exiting (Bug#8239).
6351
3eaff834
JM
63522011-05-28 Jim Meyering <meyering@redhat.com>
6353
e1900994 6354 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6355 * fns.c (to_uchar): Define.
6356 (crypto_hash_function): Use it to convert some newly-signed
6357 variables to unsigned, to avoid sign-extension bugs. For example,
6358 without this change, (md5 "truc") would evaluate to
6359 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6360 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6361 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6362
0f6990a7
PE
63632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 Integer overflow fixes.
c8a9ca5a 6366
08686060
PE
6367 * dbusbind.c: Serial number integer overflow fixes.
6368 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6369 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6370 to hold a serial number that is too large for a fixnum.
6371 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6372 Check for serial numbers out of range. Decode any serial number
59568bf0 6373 that was so large that it became a float. (Bug#8722)
08686060 6374
2d1fc3c7
PE
6375 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6376 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6377 Use XFASTINT rather than XUINT when numbers are nonnegative.
6378 (xd_append_arg, Fdbus_method_return_internal):
6379 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6380 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6381 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6382 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6383 (Bug#8722)
2d1fc3c7 6384
c8a9ca5a
PE
6385 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6386
519e1d69
PE
6387 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6388
6df6ae42 6389 ccl: Add integer overflow checks.
30569699
PE
6390 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6391 (IN_INT_RANGE): New macros.
6392 (ccl_driver): Use them to check for integer overflow when
6393 decoding a CCL program. Many of the new checks are whether XINT (x)
6394 fits in int; it doesn't always, on 64-bit hosts. The new version
6395 doesn't catch all possible integer overflows, but it's an
847044ea 6396 improvement. (Bug#8719)
30569699 6397
c11285dc
PE
6398 * alloc.c (make_event_array): Use XINT, not XUINT.
6399 There's no need for unsigned here.
6400
fdccd48e
PE
6401 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6402 This follows up to the 2011-05-06 change that substituted uintptr_t
6403 for EMACS_INT. This case wasn't caught back then.
6404
37910ab2
PE
6405 Rework Fformat to avoid integer overflow issues.
6406 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6407 now (part of C89). Include <verify.h>.
6408 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6409 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6410 (Fformat): Avoid the prepass trying to compute sizes; it was only
6411 approximate and thus did not catch overflow reliably. Instead, walk
6412 through the format just once, formatting and computing sizes as we go,
6413 checking for integer overflow at every step, and allocating a larger
6414 buffer as needed. Keep track separately whether the format is
6415 multibyte. Keep only the most-recently calculated precision, rather
6416 than them all. Record whether each argument has been converted to
6417 string. Use EMACS_INT, not int, for byte and char and arg counts.
6418 Support field widths and precisions larger than INT_MAX. Avoid
6419 sprintf's undefined behavior with conversion specifications such as %#d
6420 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6421 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6422 formatting out-of-range floating point numbers with int
9173deec 6423 formats. (Bug#8668)
37910ab2 6424
2e6578fb
PE
6425 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6426
0ae6bdee
PE
6427 * data.c: Avoid integer truncation in expressions involving floats.
6428 * data.c: Include <intprops.h>.
6429 (arith_driver): When there's an integer overflow in an expression
6430 involving floating point, convert the integers to floating point
6431 so that the resulting value does not suffer from catastrophic
6432 integer truncation. For example, on a 64-bit host (* 4
6433 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6434 Do not rely on undefined behavior after integer overflow.
6435
de883a70
PE
6436 merge count_size_as_multibyte, parse_str_to_multibyte
6437 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6438 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6439 Check for integer overflow.
6440 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6441 since it's now a duplicate of the other. This is more of
6442 a character than a buffer op, so better that it's in character.c.
6443 * fns.c, print.c: Adjust to above changes.
6444
2ff916cb
PE
64452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6446
6447 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6448
f1b54466
PE
64492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6450
fb1ac845
PE
6451 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6452 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6453 (x_clipboard_manager_save): Now static.
6454 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6455
f1b54466
PE
6456 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6457 (crypto_hash_function): Now static.
6458 Fix pointer signedness problems. Avoid unnecessary initializations.
6459
a9f737ee
CY
64602011-05-27 Chong Yidong <cyd@stupidchicken.com>
6461
6462 * termhooks.h (Vselection_alist): Make it terminal-local.
6463
6464 * terminal.c (create_terminal): Initialize it.
6465
6466 * xselect.c: Support for clipboard managers.
6467 (Vselection_alist): Move to termhooks.h as terminal-local var.
6468 (LOCAL_SELECTION): New macro.
6469 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6470 (symbol_to_x_atom): Remove gratuitous arg.
6471 (x_handle_selection_request, lisp_data_to_selection_data)
6472 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6473 (x_own_selection, x_get_local_selection, x_convert_selection):
6474 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6475 (some_frame_on_display): Delete unused function.
6476 (Fx_own_selection_internal, Fx_get_selection_internal)
6477 (Fx_disown_selection_internal, Fx_selection_owner_p)
6478 (Fx_selection_exists_p): New optional frame arg.
6479 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6480 (x_handle_selection_clear): Don't treat other terminals with the
6481 same keyboard specially. Use the terminal-local Vselection_alist.
6482 (x_clear_frame_selections): Use Frun_hook_with_args.
6483
6484 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6485
6486 * xterm.h: Add support for those atoms.
6487
e067f0c1
CY
64882011-05-26 Chong Yidong <cyd@stupidchicken.com>
6489
6490 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6491 (converted_selections, conversion_fail_tag): New global variables.
6492 (x_selection_request_lisp_error): Free the above.
6493 (x_get_local_selection): Remove unnecessary code.
6494 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6495 of converted selections stored in converted_selections.
6496 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6497 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6498 (x_convert_selection): New function.
6499 (x_handle_selection_event): Simplify.
6500 (x_get_foreign_selection): Don't ignore incoming requests while
6501 waiting for an answer; this will fail when we implement
6502 SAVE_TARGETS, and seems unnecessary anyway.
6503 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6504 (Vx_sent_selection_functions): Doc fix.
6505
0f4aebc0
LL
65062011-05-26 Leo Liu <sdl.web@gmail.com>
6507
6508 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6509
e61124cd
YM
65102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6511
6512 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6513
6514 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6515 for fringe update if it has periodic bitmap.
ac389d0c 6516 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6517 and fringe_bitmap_periodic_p.
6518
6519 * fringe.c (get_fringe_bitmap_data): New function.
6520 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6521 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6522 row. Mark glyph row for fringe update if periodicity changed.
6523
6524 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6525 for fringe update unless it has periodic bitmap.
6526
f16d9837
KH
65272011-05-25 Kenichi Handa <handa@m17n.org>
6528
6529 * xdisp.c (get_next_display_element): Set correct it->face_id for
6530 a static composition.
6531
e1b90ef6
LL
65322011-05-24 Leo Liu <sdl.web@gmail.com>
6533
6534 * deps.mk (fns.o):
6535 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6536
6537 * fns.c (crypto_hash_function, Fsha1): New function.
6538 (Fmd5): Use crypto_hash_function.
6539 (syms_of_fns): Add Ssha1.
6540
7400048f
PE
65412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * gnutls.c: Remove unused macros.
6544 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6545 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6546 Remove macros that are defined and never used.
6547 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6548
abb71cf4
CY
65492011-05-22 Chong Yidong <cyd@stupidchicken.com>
6550
6551 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6552 (Fx_get_selection_internal): Minor cleanup.
6553 (Fx_own_selection_internal): Rename arguments for consistency with
6554 select.el.
6555
6307db39
PE
65562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6557
6558 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6559
f3d4e0a4
CY
65602011-05-22 Chong Yidong <cyd@stupidchicken.com>
6561
6562 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6563
4d8ade89
YM
65642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6565
6566 * dispnew.c (scrolling_window): Don't exclude the case that the
6567 last enabled row in the desired matrix touches the bottom boundary.
6568
32078c8d
GM
65692011-05-21 Glenn Morris <rgm@gnu.org>
6570
6571 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6572 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6573 and add some more files.
32078c8d 6574
7285dc67
EZ
65752011-05-20 Eli Zaretskii <eliz@gnu.org>
6576
6577 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6578 report_file_error introduced by the change from 2011-05-07.
6579
89d1bd22
PE
65802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 * systime.h (Time): Define only if emacs is defined.
6583 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6584 where the include path doesn't have X11/X.h by default. See
6585 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6586
cd394be1 65872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6588
6589 * composite.c (find_automatic_composition): Fix previous change.
6590
b9704ad9
GM
65912011-05-20 Glenn Morris <rgm@gnu.org>
6592
6593 * lisp.mk: New file, split from Makefile.in.
6594 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6595 (shortlisp): Remove.
6596 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6597
4a720484
GM
65982011-05-19 Glenn Morris <rgm@gnu.org>
6599
6600 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6601 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6602 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6603 (lisp): Set the order to that of loadup.el.
6604 (shortlisp): Make it a copy of $lisp.
6605 (SOME_MACHINE_LISP): Remove.
6606 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6607 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6608
a28d4396
KH
66092011-05-18 Kenichi Handa <handa@m17n.org>
6610
6611 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6612 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6613 (find_automatic_composition): Mostly rewrite for efficiency.
6614
a2b1fa8e
JB
66152011-05-18 Juanma Barranquero <lekktu@gmail.com>
6616
6617 * makefile.w32-in: Update dependencies.
6618
8e1f5610
CS
66192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6620
6621 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6622 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6623
7025ee00 66242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6625
cdfa6eab
PE
6626 Fix some integer overflow issues, such as string length overflow.
6627
06d6db33
PE
6628 * insdel.c (count_size_as_multibyte): Check for string overflow.
6629
2b4560a8
PE
6630 * character.c (lisp_string_width): Check for string overflow.
6631 Use EMACS_INT, not int, for string indexes and lengths; in
6632 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6633 the resulting string length overflows an EMACS_INT; instead,
6634 report a string overflow if no precision given. When checking for
6635 precision exhaustion, use a check that cannot possibly have
6636 integer overflow. (Bug#8675)
6637 * character.h (lisp_string_width): Adjust to new signature.
6638
cb93f9be
PE
6639 * alloc.c (string_overflow): New function.
6640 (Fmake_string): Use it. This doesn't change behavior, but saves
6641 a few bytes and will simplify future changes.
6642 * character.c (string_escape_byte8): Likewise.
6643 * lisp.h (string_overflow): New decl.
6644
1a1f3366
PE
6645 Fixups, following up to the user-interface timestamp change.
6646 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6647 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6648 * msdos.c (mouse_get_pos): Likewise.
6649 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6650 * w32gui.h (Time): Define by including "systime.h" rather than by
6651 declaring it ourselves. (Bug#8664)
6652
d4e3e4d3
PE
6653 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6654 * image.c (clear_image_cache): Likewise.
6655
f6a24d19
PE
6656 * term.c (term_mouse_position): Don't assume time_t wraparound.
6657
08dc5ae6
PE
6658 Be more systematic about user-interface timestamps.
6659 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6660 and sometimes 'EMACS_UINT', to represent these timestamps.
6661 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6662 This makes the code easier to follow, and makes it easier to catch
6663 integer overflow bugs such as Bug#8664.
6664 * frame.c (Fmouse_position, Fmouse_pixel_position):
6665 Use Time, not unsigned long, for user-interface timestamps.
6666 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6667 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6668 * keyboard.h (last_event_timestamp): Likewise.
6669 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6670 * menu.h (xmenu_show): Likewise.
6671 * term.c (term_mouse_position): Likewise.
6672 * termhooks.h (struct input_event.timestamp): Likewise.
6673 (struct terminal.mouse_position_hook): Likewise.
6674 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6675 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6676 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6677 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6678 what it was before.
6679 * menu.h, termhooks.h: Include "systime.h", for Time.
6680
8e55734a
PE
6681 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6682 Don't assume that the difference between two unsigned long values
6683 can fit into an integer. At this point, we know button_down_time
6684 <= event->timestamp, so the difference must be nonnegative, so
6685 there's no need to cast the result if double-click-time is
6686 nonnegative, as it should be; check that it's nonnegative, just in
6687 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6688 apart (about 25 days). (Bug#8664)
8e55734a 6689
841f1b75 6690 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6691 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6692
3e26f69c
PE
6693 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6694 that always fit in int. Use a sentinel instead of a counter, to
6695 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6696 * frame.h (struct frame): Use int for menu_bar_items_used
6697 instead of EMACS_INT, since it always fits in int.
3e26f69c 6698
5cc152c0
PE
6699 * menu.c (grow_menu_items): Check for int overflow.
6700
d89eb65e
PE
6701 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6702
5235bd3e
PE
6703 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6704 Before, the code was not consistent. These values cannot exceed
6705 2**31 - 1 so there's no need to make them unsigned.
6706 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6707 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6708 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6709 as modifiers.
6710 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6711
bc827e23
PE
6712 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6713 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6714 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6715 presumably because the widths might not match.
6716
78eb494e
PE
6717 * window.c (size_window): Avoid needless test at loop start.
6718
04f2d78b
CB
67192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6720
6721 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6722
d2fc7e3d 67232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6724
6725 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6726
d2fc7e3d 67272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6728
6729 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6730 `width' to `bar_area_x' and `bar_area_width', respectively.
6731 (x_scroll_run): Take account of fringe background extension.
6732
04f2d78b
CB
6733 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6734 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6735 `bar_area_width', respectively.
6736 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6737 background extension.
6738
79b70037
GM
67392011-05-10 Jim Meyering <meyering@redhat.com>
6740
6741 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6742
2f142cc5
JB
67432011-05-10 Juanma Barranquero <lekktu@gmail.com>
6744
6745 * image.c (Finit_image_library): Return t for built-in image types,
6746 like pbm and xbm. (Bug#8640)
6747
57679c86
AS
67482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6749
6750 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6751
888c9e86
EZ
67522011-05-07 Eli Zaretskii <eliz@gnu.org>
6753
b0512a1d
EZ
6754 * w32console.c (Fset_screen_color): Doc fix.
6755 (Fget_screen_color): New function.
6756 (syms_of_ntterm): Defsubr it.
6757
7285dc67
EZ
6758 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6759 unlink the temporary file if Fcall_process didn't create it in the
6760 first place.
6761 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6762 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6763 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6764 cue to call_process_cleanup not to close that handle.
6765
4d3fcc8e
BK
67662011-05-07 Ben Key <bkey76@gmail.com>
6767
6768 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6769 one of two shell specific rules, either bootstrap-temacs-CMD or
6770 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6771 to the previous implementation of the bootstrap-temacs rule.
6772 The bootstrap-temacs-CMD rule is similar to the previous
6773 implementation of the bootstrap-temacs rule except that it
6774 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6775 variable.
6776
6777 These changes, along with some changes to nt/configure.bat,
6778 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6779 earlier fix to add support for --cflags and --ldflags options
6780 that include quotes so that it works whether make uses cmd or
6781 sh as the shell.
6782
b4289b64
MA
67832011-05-06 Michael Albinus <michael.albinus@gmx.de>
6784
6785 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6786 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6787 is a constant.
6788 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6789 a string. Handle both cases.
6790 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6791 (Fdbus_register_method): Use Qinvalid_function.
6792
af4c0e28
JB
67932011-05-06 Juanma Barranquero <lekktu@gmail.com>
6794
6795 * makefile.w32-in: Update dependencies.
6796 (LISP_H): Add inttypes.h and stdin.h.
6797 (PROCESS_H): Add unistd.h.
6798
c51453d9
EZ
67992011-05-06 Eli Zaretskii <eliz@gnu.org>
6800
6801 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6802 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6803
8ff0ac3c 68042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6805
4c4b566b
PE
6806 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6807
aab2b9b5
PE
6808 * term.c (vfatal): Remove stray call to va_end.
6809 It's not needed and the C Standard doesn't allow it here anyway.
6810
c378da0b
PE
6811 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6812 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6813
288b08c7
PE
6814 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6815 bytes.
6816
e3601888
PE
6817 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6818
db6c0e74
PE
6819 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6820
dd5963ea
PE
6821 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6822
88c9450f
PE
6823 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6824
2f9442b8
PE
6825 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6826
c032b5f8
PE
6827 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6828 * charset.c (Fdefine_charset_internal): Don't initialize
6829 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6830 32-bit int (Bug#8600).
a108c10b
PE
6831
6832 * lread.c (read_integer): Be more consistent with string-to-number.
6833 Use string_to_number to do the actual conversion; this avoids
6834 rounding errors and fixes some other screwups. Without this fix,
6835 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6836 (digit_to_number): Move earlier, for benefit of read_integer.
6837 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6838 not a digit in any supported base. (Bug#8602)
a108c10b 6839
ad5f9eea
PE
6840 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6841
aec1708a
PE
6842 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6843 to match comment at start of function. This also removes a
6844 GCC warning about overflow in a 32+64-bit port.
6845
47be4ab5
PE
6846 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6847
371cac43
PE
6848 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6849 Reported by Stefan Monnier in
6850 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6851 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6852 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6853
d01a7826
PE
6854 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6855 (EMACS_UINTPTR): Likewise, with uintptr_t.
6856
7fd47d5c
PE
6857 * lisp.h: Prefer 64-bit EMACS_INT if available.
6858 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6859 on 32-bit hosts that have 64-bit int, so that they can access
6860 large files.
122b0c86
PE
6861 However, temporarily disable this change unless the temporary
6862 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6863
8727937b
PE
6864 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6865
8ac068ac
PE
6866 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6867 This removes an assumption that EMACS_INT and long are the same
6868 width as pointers. The assumption is true for Emacs porting targets
6869 now, but we want to make other targets possible.
6870 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6871 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6872 In the rest of the code, change types of integers that hold casted
6873 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6874 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6875 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6876 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6877 No need to cast type when ORing.
6878 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6879 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6880 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6881 assume EMACS_INT is the same width as char *.
6882 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6883 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6884 Remove no-longer-needed casts.
6885 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6886 (xg_tool_bar_help_callback, xg_make_tool_item):
6887 Use EMACS_INTPTR to hold an integer
6888 that will be cast to void *; this can avoid a GCC warning
6889 if EMACS_INT is not the same width as void *.
6890 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6891 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6892 (current_message_1, set_message_1):
6893 Use a local to convert to proper width without a cast.
6894 * xmenu.c (dialog_selection_callback): Likewise.
6895
ede49d71
PE
6896 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6897 Also, don't assume VALBITS / RAND_BITS is less than 5,
6898 and don't rely on undefined behavior when shifting a 1 left into
6899 the sign bit.
6900 * lisp.h (get_random): Change signature to match.
6901
2f30ecd0
PE
6902 * lread.c (hash_string): Use size_t, not int, for hash computation.
6903 Normally we prefer signed values; but hashing is special, because
6904 it's better to use unsigned division on hash table sizes so that
6905 the remainder is nonnegative. Also, size_t is the natural width
6906 for hashing into memory. The previous code used 'int', which doesn't
6907 retain enough info to hash well into very large tables.
6908 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6909
2a866e7b
PE
6910 * dbusbind.c: Don't possibly lose pointer info when converting.
6911 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6912 Use XPNTR rather than XHASH, so that the high-order bits of
6913 the pointer aren't lost when converting through void *.
6914
51639eac
PE
6915 * eval.c (Fautoload): Don't double-shift a pointer.
6916
92394119
PE
6917 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6918
dbdb9a7c
JB
69192011-05-06 Juanma Barranquero <lekktu@gmail.com>
6920
6921 * gnutls.c (DEF_GNUTLS_FN):
6922 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6923
db7a0b4f
AS
69242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6925
6926 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6927 marker. (Bug#8610)
6928
cd394be1 69292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6930
6931 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6932 New version that can reserve upto 2GB of heap space.
6933
f7ff1b0f 69342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6935
6936 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6937
639c109b
TZ
69382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6939
6940 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6941 `gnutls_certificate_set_x509_key_file'.
6942
d2127135
JB
69432011-05-05 Juanma Barranquero <lekktu@gmail.com>
6944
6945 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6946 Update dependencies.
6947
e968f4f3
JB
69482011-05-04 Juanma Barranquero <lekktu@gmail.com>
6949
6950 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6951 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6952 Remove unused parameter `fildes'.
6953 * process.c (read_process_output, send_process): Don't pass it.
6954
84d358f0
JB
69552011-05-04 Juanma Barranquero <lekktu@gmail.com>
6956
6957 Fix previous change: the library cache is defined in w32.c.
6958 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6959 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6960
0898ca10
JB
69612011-05-04 Juanma Barranquero <lekktu@gmail.com>
6962
6963 Implement dynamic loading of GnuTLS on Windows.
6964
6965 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6966 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6967 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6968 Declare.
6969
6970 * gnutls.c (Qgnutls_dll): Define.
6971 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6972 (gnutls_*): Declare function pointers.
6973 (init_gnutls_functions): New function to initialize function pointers.
6974 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6975 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6976 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6977 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6978 (emacs_gnutls_write, emacs_gnutls_read)
6979 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6980 (Fgnutls_available_p): New function.
6981 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6982 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6983 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6984
6985 * image.c: Include w32.h.
6986 (Vimage_type_cache): Delete.
6987 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6988 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6989 (w32_delayed_load): Move to w32.c.
6990
6991 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6992
6993 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6994 (w32_delayed_load): Move from image.c. When loading a library, record
6995 its filename in the :loaded-from property of the library id.
6996 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6997 Initialize and staticpro them.
6998 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6999
7000 * process.c: Include lisp.h before w32.h, not after.
7001 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7002 instead of gnutls_record_check_pending.
7003
7004 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7005
ff4de4aa
TZ
70062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7007
7008 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7009 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7010 as passed in.
7011
abe95abb
JD
70122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7013
7014 * xterm.c (x_set_frame_alpha): Do not set property on anything
7015 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7016
e16e55d4
JB
70172011-05-02 Juanma Barranquero <lekktu@gmail.com>
7018
7019 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7020
bafcf6a5
JB
70212011-05-02 Juanma Barranquero <lekktu@gmail.com>
7022
7023 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7024 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7025 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7026 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7027 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7028 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7029 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7030 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7031 (Qgnutls_bootprop_callbacks_verify): Make static.
7032
e7a6747f
AS
70332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7034
19ed11ba
AS
7035 * callproc.c: Indentation fixup.
7036
e7a6747f 7037 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7038 (wait_for_termination, interruptible_wait_for_termination):
7039 Move after wait_for_termination_1.
e7a6747f 7040
1ef14cb4
LMI
70412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7042
7043 * sysdep.c (interruptible_wait_for_termination): New function
7044 which is like wait_for_termination, but allows keyboard
7045 interruptions.
7046
7047 * callproc.c (Fcall_process): Add (:file "file") as an option for
7048 the STDOUT buffer.
7049 (Fcall_process_region): Ditto.
7050
330d880c
EZ
70512011-04-30 Eli Zaretskii <eliz@gnu.org>
7052
8db90b73
EZ
7053 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7054 rather than `XVECTOR (FOO)->size'.
7055
330d880c
EZ
7056 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7057 inttypes.h, as a gnulib replacement is used if it not available in
7058 system headers.
7059
15cbd324
EZ
70602011-04-21 Eli Zaretskii <eliz@gnu.org>
7061
7062 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7063 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7064 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7065
7066 * coding.c (coding_alloc_by_realloc): Error out if destination
7067 will grow beyond MOST_POSITIVE_FIXNUM.
7068 (decode_coding_emacs_mule): Abort if there isn't enough place in
7069 charbuf for the composition carryover bytes. Reserve an extra
7070 space for up to 2 characters produced in a loop.
7071 (decode_coding_iso_2022): Abort if there isn't enough place in
7072 charbuf for the composition carryover bytes.
7073
70742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7075
ae940cca
EZ
7076 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7077 aborting when %lld or %lll format is passed.
7078 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7079 %llo or %llx format is passed. (Bug#8545)
7080
03ab8921
EZ
7081 * window.c (window_scroll_line_based): Use a marker instead of
7082 simple variables to record original value of point. (Bug#7952)
7083
afda1437
EZ
7084 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7085 produced by %s or %c overflows available buffer space. (Bug#8545)
7086
f76dee0c
PE
70872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7088
7089 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7090 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7091
fdc5744d
JB
70922011-04-28 Juanma Barranquero <lekktu@gmail.com>
7093
7094 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7095
638f053a
JB
70962011-04-28 Juanma Barranquero <lekktu@gmail.com>
7097
7098 * keyboard.c (Qdelayed_warnings_hook): Define.
7099 (command_loop_1): Run `delayed-warnings-hook'
7100 if Vdelayed_warnings_list is non-nil.
7101 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7102 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7103
d178f871
EZ
71042011-04-28 Eli Zaretskii <eliz@gnu.org>
7105
7106 * doprnt.c (doprnt): Don't return value smaller than the buffer
7107 size if the message was truncated. (Bug#8545).
7108
b124fd93
JB
71092011-04-28 Juanma Barranquero <lekktu@gmail.com>
7110
7111 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7112 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7113
e810457d
PE
71142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7115
7116 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7117
ea51cceb
JB
71182011-04-27 Juanma Barranquero <lekktu@gmail.com>
7119
7120 * makefile.w32-in: Update dependencies.
7121
94dcfacf
EZ
71222011-04-27 Eli Zaretskii <eliz@gnu.org>
7123
7124 Improve `doprnt' and its usage. (Bug#8545)
7125 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7126 `format_end'. Remove support for %l as a conversion specifier.
7127 Don't use xrealloc. Improve diagnostics when the %l size modifier
7128 is used. Update the commentary.
7129
7130 * eval.c (verror): Simplify calculation of size_t.
7131
7132 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7133 messages.
7134
f61f41d7
PE
71352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7136
7137 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7138 change.
7139
96fb4434
PE
71402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7141
7142 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7143 This makes this file independent of the recent pseudovector change.
7144
671875da 71452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7146
69e9b5a3
PE
7147 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7148
b5f869a7 7149 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7150 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7151 Remove unused local.
c8926152 7152 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7153
841a1577 7154 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7155 GCC 4.6.0 optimizes based on type-based alias analysis.
7156 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7157 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7158 != &v->size, and therefore "v->size = 1; b->size = 2; return
7159 v->size;" must therefore return 1. This assumption is incorrect
7160 for Emacs, since it type-puns struct Lisp_Vector * with many other
7161 types. To fix this problem, this patch adds a new type struct
f904488f 7162 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7163 and pseudovectors, and helps optimizing compilers not get fooled
7164 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7165 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7166 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7167 the size member.
eab3844f
PE
7168 (XSETPVECTYPE): Rewrite in terms of new macro.
7169 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7170 This is a bit clearer, and further avoids the possibility of
7171 undesirable aliasing.
7172 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7173 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7174 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7175 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7176 (ASIZE): Now uses header.size rather than size.
7177 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7178 to avoid the hassle of writing XVECTOR (foo)->header.size.
7179 (struct vectorlike_header): New type.
eab3844f
PE
7180 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7181 object, to help avoid aliasing.
7182 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7183 (SUBRP): Likewise, since Lisp_Subr is a special case.
7184 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7185 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7186 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7187 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7188 changed to be "header.size" and "header.next".
7189 * buffer.h (struct buffer): Likewise.
7190 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7191 * frame.h (struct frame): Likewise.
7192 * process.h (struct Lisp_Process): Likewise.
7193 * termhooks.h (struct terminal): Likewise.
7194 * window.c (struct save_window_data, struct saved_window): Likewise.
7195 * window.h (struct window): Likewise.
7196 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7197 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7198 * buffer.c (init_buffer_once): Likewise.
7199 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7200 special case.
7201 * process.c (Fformat_network_address): Use local var for size,
7202 for brevity.
7203
0df1eac5
PE
7204 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7205
847ab9d1 7206 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7207 * data.c (atof): Remove decl; no longer used or needed.
7208 (digit_to_number): Move to lread.c.
7209 (Fstring_to_number): Use new string_to_number function, to be
7210 consistent with how the Lisp reader treats infinities and NaNs.
7211 Do not assume that floating-point numbers represent EMACS_INT
7212 without losing information; this is not true on most 64-bit hosts.
7213 Avoid double-rounding errors, by insisting on integers when
7214 parsing non-base-10 numbers, as the documentation specifies.
7215 * lisp.h (string_to_number): New decl, replacing ...
7216 (isfloat_string): Remove.
bc0a5c13 7217 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7218 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7219 appears to have been a coding error. Similarly, do not accept
7220 strings like +-1e0 as floating point numbers. Do not report
7221 overflow for integer overflows unless the base is not 10 which
7222 means we have no simple and reliable way to continue.
7223 Break out the floating-point parsing into a new
7224 function string_to_number, so that Fstring_to_number parses
7225 floating point numbers consistently with the Lisp reader.
04f2d78b 7226 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7227 (E_CHAR, EXP_INT): Remove, replacing with ...
7228 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7229 (string_to_number): New function, replacing isfloat_string.
7230 This function checks for valid syntax and produces the resulting
7231 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7232 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7233 so that overflow for non-base-10 numbers is reported only when
7234 there's no portable and simple way to convert to floating point.
452f4150 7235
67769ffc
PE
7236 * textprop.c (set_text_properties_1): Rewrite for clarity,
7237 and to avoid GCC warning about integer overflow.
7238
c20db43f
PE
7239 * intervals.h (struct interval): Use EMACS_INT for members
7240 where EMACS_UINT might cause problems. See
7241 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7242 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7243 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7244 All uses changed.
37aa2f85
PE
7245 (offset_intervals): Tell GCC not to worry about length overflow
7246 when negating a negative length.
c20db43f 7247
2538aa2f
PE
7248 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7249 (overrun_check_free): Likewise.
7250
f2d3008d
PE
7251 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7252 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7253 word size.
7254
ec8df744
PE
7255 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7256 (gnutls_make_error): Rename local to avoid shadowing.
7257 (gnutls_emacs_global_deinit): ifdef out; not used.
7258 (Fgnutls_boot): Use const for pointer to readonly storage.
7259 Comment out unused local. Fix pointer signedness problems.
7260
640ee02d
PE
7261 * lread.c (openp): Don't stuff size_t into an 'int'.
7262 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7263 about possible signed overflow.
7264
6048fb2a
PE
7265 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7266 (GDK_KEY_g): Don't define if already defined.
7267 (xg_prepare_tooltip): Avoid pointer signedness problem.
7268 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7269
fa3c87e1
PE
7270 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7271 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7272
2172544b
PE
7273 * xfns.c (Fx_window_property): Simplify a bit,
7274 to make a bit faster and to avoid GCC 4.6.0 warning.
7275 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7276
9b821a21
PE
7277 * fns.c (internal_equal): Don't assume size_t fits in int.
7278
3c616cfa
PE
7279 * alloc.c (compact_small_strings): Tighten assertion a little.
7280
c2982e87
PE
7281 Replace pEd with more-general pI, and fix some printf arg casts.
7282 * lisp.h (pI): New macro, generalizing old pEd macro to other
7283 conversion specifiers. For example, use "...%"pI"d..." rather
7284 than "...%"pEd"...".
7285 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7286 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7287 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7288 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7289 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7290 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7291 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7292 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7293 64-bit hosts.
7294 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7295 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7296 * print.c (safe_debug_print, print_object): Likewise.
7297 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7298 to int.
6f04d126
PE
7299 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7300 avoiding the 0 flag, which is not portable.
c2982e87
PE
7301 * process.c (Fmake_network_process): Use pI to avoid cast.
7302 * region-cache.c (pp_cache): Likewise.
7303 * xdisp.c (decode_mode_spec): Likewise.
7304 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7305 behavior on 64-bit hosts with printf arg.
6f04d126 7306 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7307 (x_stop_queuing_selection_requests): Likewise.
7308 (x_get_window_property): Don't truncate byte count to an 'int'
7309 when tracing.
0b432f21 7310
5e073ec7
PE
7311 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7312 here, since it parses constructs like leading '-' and spaces,
7313 which are not wanted; and it overflows with large numbers.
7314 Instead, simply match F[0-9]+, which is what is wanted anyway.
7315
36372bf9
PE
7316 * alloc.c: Remove unportable assumptions about struct layout.
7317 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7318 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7319 (allocate_vectorlike, make_pure_vector): Use the new macros,
7320 plus offsetof, to remove unportable assumptions about struct layout.
7321 These assumptions hold on all porting targets that I know of, but
7322 they are not guaranteed, they're easy to remove, and removing them
7323 makes further changes easier.
7324
0b432f21
PE
7325 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7326 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7327 (string_overrun_cookie): Now const. Use initializers that
7328 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7329 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7330 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7331 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7332 multiple of sizeof (EMACS_INT); it need not be, if
7333 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7334 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7335
895009e1
JB
73362011-04-26 Juanma Barranquero <lekktu@gmail.com>
7337
7338 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7339
6a7a1b0b
TZ
73402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7341
7342 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7343 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7344 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7345
841a1577 73462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7347
7348 * lisp.h (Qdebug): List symbol.
895009e1 7349 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7350 * keyboard.c (debug-on-event): New variable.
7351 (handle_user_signal): Break into debugger when debug-on-event
7352 matches the current signal symbol.
7353
f2d3ba6f
DN
73542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7355
7356 * alloc.c (check_sblock, check_string_bytes)
7357 (check_string_free_list): Convert to standard C.
7358
42ce4c63
TZ
73592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7360
7361 * w32.c (emacs_gnutls_push): Fix typo.
7362
825cd63c
EZ
73632011-04-25 Eli Zaretskii <eliz@gnu.org>
7364
fb11d64d
EZ
7365 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7366 "cast to pointer from integer of different size".
7367
825cd63c
EZ
7368 Improve doprnt and its use in verror. (Bug#8545)
7369 * doprnt.c (doprnt): Document the set of format control sequences
7370 supported by the function. Use SAFE_ALLOCA instead of always
7371 using `alloca'.
7372
7373 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7374 is one byte too soon. Don't use xrealloc; instead xfree and
7375 xmalloc anew.
7376
e061a11b
TZ
73772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7378
7379 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7380 callbacks stage.
7381
7382 * gnutls.c: Renamed global_initialized to
7383 gnutls_global_initialized. Added internals for the
7384 :verify-hostname-error, :verify-error, and :verify-flags
7385 parameters of `gnutls-boot' and documented those parameters in the
7386 docstring. Start callback support.
9173deec
JB
7387 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7388 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7389 on error. Return error code.
e061a11b
TZ
7390 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7391 (emacs_gnutls_read): Likewise.
7392 (Fgnutls_boot): Return handshake error code.
7393 (emacs_gnutls_handle_error): New function.
7394 (wsaerror_to_errno): Likewise.
7395
7396 * w32.h (emacs_gnutls_pull): Add prototype.
7397 (emacs_gnutls_push): Likewise.
7398
7399 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7400 (emacs_gnutls_push): Likewise.
7401
74022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7403
7404 * process.c (wait_reading_process_output): Check if GnuTLS
7405 buffered some data internally if no FDs are set for TLS
7406 connections.
7407
7408 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7409 (LIBS): Link to USER_LIBS.
7410 ($(BLD)/gnutls.$(0)): New target.
7411
fa6996bc
EZ
74122011-04-24 Eli Zaretskii <eliz@gnu.org>
7413
eb35682e
EZ
7414 * xdisp.c (handle_single_display_spec): Rename the
7415 display_replaced_before_p argument into display_replaced_p, to
7416 make it consistent with the commentary. Fix typos in the
7417 commentary.
7418
e2ad650c
EZ
7419 * textprop.c (syms_of_textprop): Remove dead code.
7420 (copy_text_properties): Delete obsolete commentary about an
7421 interface that was deleted long ago. Fix typos in the description
7422 of arguments.
7423
1b2de274
EZ
7424 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7425 to changes in oldXMenu/XMenu.h from 2011-04-16.
7426 <menu_help_message, prev_menu_help_message>: Constify.
7427 (IT_menu_make_room): menu->help_text is now `const char **';
7428 adjust.
7429
7430 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7431 to changes in oldXMenu/XMenu.h from 2011-04-16.
7432 (struct XMenu): Declare `help_text' `const char **'.
7433
7434 * xfaces.c <Qunspecified>: Make extern again.
7435
7436 * syntax.c: Include sys/types.h before including regex.h, as
7437 required by Posix.
7438
762b15be
EZ
7439 * doc.c (get_doc_string): Improve the format passed to `error'.
7440
7441 * doprnt.c (doprnt): Improve commentary.
7442
7443 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7444
7445 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7446 them with etags.
7447
f1052e5d
EZ
7448 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7449 changes in globals.h immediately force recompilation.
762b15be
EZ
7450 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7451 $(CURDIR)/s/ms-w32.h.
7452 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7453
fa6996bc
EZ
7454 * character.c (Fchar_direction): Function deleted.
7455 (syms_of_character): Don't defsubr it.
7456 <char-direction-table>: Deleted.
7457
e6c3da20
EZ
74582011-04-23 Eli Zaretskii <eliz@gnu.org>
7459
7460 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7461 * doprnt.c: Include limits.h.
7462 (SIZE_MAX): New macro.
04f2d78b
CB
7463 (doprnt): Return a size_t value. 2nd arg is now size_t.
7464 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7465 Improve overflow protection. Support `l' modifier for integer
7466 conversions. Support %l conversion. Don't assume an EMACS_INT
7467 argument for integer conversions and for %c.
7468
7469 * lisp.h (doprnt): Restore prototype.
7470
7471 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7472 $(SRC)/character.h.
7473
7474 * Makefile.in (base_obj): Add back doprnt.o.
7475
7476 * deps.mk (doprnt.o): Add back prerequisites.
7477 (callint.o): Depend on character.h.
7478
7479 * eval.c (internal_lisp_condition_case): Include the handler
7480 representation in the error message.
7481 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7482 when breaking from the loop.
7483
7484 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7485
7486 * callint.c (Fcall_interactively): When displaying error message
7487 about invalid control letter, pass the character's codepoint, not
7488 a pointer to its multibyte form. Improve display of the character
7489 in octal and display also its hex code.
7490
7491 * character.c (char_string): Use %x to display the (unsigned)
7492 codepoint of an invalid character, to avoid displaying a bogus
7493 negative value.
7494
7495 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7496 `error', not SYMBOL_NAME itself.
7497
7498 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7499 character arguments to `error'.
7500
7501 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7502 to `error' in error message about FINAL_CHAR argument. Make sure
7503 FINAL_CHAR is a character, and use %c when it is passed as
7504 argument to `error'.
7505
4ffd0d6b 75062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7507
7508 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7509
7510 * w32.c: Include <time.h>.
7511 (sys_localtime): New function.
7512
4ffd0d6b 75132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7514
7515 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7516
4ffd0d6b 7517 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7518
4ffd0d6b 75192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7520
4ffd0d6b
GM
7521 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7522 zombies (Bug#8467).
aac0c6e3 7523
04c56954
EZ
75242011-04-19 Eli Zaretskii <eliz@gnu.org>
7525
7526 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7527 gl_state.e_property when gl_state.object is Qt.
7528
7529 * insdel.c (make_gap_larger): Remove limitation of buffer size
7530 to <= INT_MAX.
7531
16a43933
CY
75322011-04-18 Chong Yidong <cyd@stupidchicken.com>
7533
7534 * xdisp.c (lookup_glyphless_char_display)
7535 (produce_glyphless_glyph): Handle cons cell entry in
7536 glyphless-char-display.
7537 (Vglyphless_char_display): Document it.
7538
7539 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7540 glyphless-char-display.
7541
4581706e
CY
75422011-04-17 Chong Yidong <cyd@stupidchicken.com>
7543
7544 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7545
7546 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7547
7548 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7549 definition for no-X builds.
7550
4887c6e2 75512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7552
fd35b6f9
PE
7553 Static checks with GCC 4.6.0 and non-default toolkits.
7554
5c1ccb01
PE
7555 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7556
006c5daa
PE
7557 * process.c (keyboard_bit_set): Define only if SIGIO.
7558 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7559 (send_process): Repair possible setjmp clobbering.
7560
efc736d3
PE
7561 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7562
4e2fe2e6
PE
7563 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7564
f97334a2
PE
7565 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7566
4e75f29d
PE
7567 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7568 Define only if needed.
7569
90efadd1
PE
7570 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7571 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7572 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7573
3c647824
PE
7574 * dispextern.h (struct redisplay_interface): Rename param
7575 to avoid shadowing.
e264f262 7576 * termhooks.h (struct terminal): Likewise.
761383f4 7577 * xterm.c (xembed_send_message): Likewise.
3c647824 7578
b58c5c4a
PE
7579 * insdel.c (make_gap_smaller): Define only if
7580 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7581
cad59032
PE
7582 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7583 it.
7584
c339dc2e
PE
7585 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7586 so that we aren't warned about unused symbols.
7587
91a3e27b
PE
7588 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7589
399c71d3 7590 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7591
8ffc96f5
PE
7592 * xfns.c (x_real_positions): Mark locals as initialized.
7593
eef9bc79
PE
7594 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7595
098db9dd
PE
7596 * xterm.c: Fix problems found by static analysis with other toolkits.
7597 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7598 (x_dispatch_event): Declare static if USE_GTK, and
7599 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7600 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7601 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7602 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7603 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7604
eb18f6cc
PE
7605 * xmenu.c (menu_help_callback): Pointer type fixes.
7606 Use const pointers when pointing at readonly data. Avoid pointer
7607 signedness clashes.
7608 (FALSE): Remove unused macro.
7609 (update_frame_menubar): Remove unused decl.
7610
1fe72bf8
PE
7611 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7612
60d9e1db
PE
7613 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7614 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7615 (single_menu_item): Rename local to avoid shadowing.
7616
39261c26
PE
7617 * keyboard.c (make_lispy_event): Remove unused local var.
7618
018c5e19
PE
7619 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7620 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7621
63d2b86e
PE
7622 * bitmaps: Change bitmaps from unsigned char back to the X11
7623 compatible char. Avoid the old compiler warnings about
7624 out-of-range initializers by using, for example, '\xab' rather
7625 than 0xab.
7626
aefd87e1
PE
7627 * xgselect.c (xgselect_initialize): Check vs interface
7628 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7629
bf501fb9
PE
7630 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7631
e9829fdf
PE
7632 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7633 to read-only memory.
7634
1086c095
PE
7635 * fns.c (vector): Remove; this old hack is no longer needed.
7636
2baccd04 7637 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7638 Remove unused var.
dde42981 7639 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7640
72391843 7641 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7642
436c16df 7643 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7644 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7645 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7646
92bb796d 7647 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7648 (x_term_init): Remove local to avoid shadowing.
92bb796d 7649
764430a3 7650 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7651
7652 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7653 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7654
d1dfb56c
EZ
76552011-04-16 Eli Zaretskii <eliz@gnu.org>
7656
c4354cb4
EZ
7657 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7658
d1dfb56c
EZ
7659 Fix regex.c, syntax.c and friends for buffers > 2GB.
7660 * syntax.h (struct gl_state_s): Declare character position members
7661 EMACS_INT.
7662
7663 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7664
04f2d78b
CB
7665 * textprop.c (verify_interval_modification, interval_of):
7666 Declare arguments EMACS_INT.
d1dfb56c
EZ
7667
7668 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7669 EMACS_INT.
7670
7671 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7672
7673 * indent.c (Fvertical_motion): Local variable it_start is now
7674 EMACS_INT.
7675
7676 * regex.c (re_match, re_match_2, re_match_2_internal)
7677 (bcmp_translate, regcomp, regexec, print_double_string)
7678 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7679 (re_compile_pattern, re_exec): Declare arguments and local
7680 variables `size_t' and `ssize_t' and return values `regoff_t', as
7681 appropriate.
7682 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7683 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7684 <compile_stack_type>: `size' and `avail' are now `size_t'.
7685
7686 * regex.h <regoff_t>: Use ssize_t, not int.
7687 (re_search, re_search_2, re_match, re_match_2): Arguments that
7688 specify buffer/string position and length are now ssize_t and
7689 size_t. Return type is regoff_t.
7690
613052cd
BK
76912011-04-16 Ben Key <bkey76@gmail.com>
7692
7693 * nsfont.m: Fixed bugs in ns_get_family and
7694 ns_descriptor_to_entity that were caused by using free to
7695 deallocate memory blocks that were allocated by xmalloc (via
7696 xstrdup). This caused Emacs to crash when compiled with
7697 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7698 --enable-checking=xmallocoverrun). xfree is now used to
7699 deallocate these memory blocks.
7700
4170f62f 77012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7702
71b41406
PE
7703 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7704
9587a89d
PE
7705 emacs_write: Accept and return EMACS_INT for sizes.
7706 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7707 et seq.
7708 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7709 Accept and return EMACS_INT.
7710 (emacs_gnutls_write): Return the number of bytes written on
7711 partial writes.
7712 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7713 (emacs_read, emacs_write): Remove check for negative size, as the
7714 Emacs source code has been audited now.
9587a89d
PE
7715 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7716 (emacs_read, emacs_write): Use it.
273a5f82
PE
7717 * process.c (send_process): Adjust to the new signatures of
7718 emacs_write and emacs_gnutls_write. Do not attempt to store
7719 a byte offset into an 'int'; it might overflow.
9587a89d 7720 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7721
3e047f51
PE
7722 * sound.c: Don't assume sizes fit in 'int'.
7723 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7724 Return EMACS_INT, not int.
3e047f51 7725 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7726 Accept EMACS_INT, not int.
7727 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7728 record read return values.
7729
cc39a9db
BK
77302011-04-15 Ben Key <bkey76@gmail.com>
7731
c9d0ec6d
JB
7732 * keyboard.c (Qundefined): Don't declare static since it is used
7733 in nsfns.m.
7734 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7735 static since they are used in nsfont.m.
cc39a9db 7736
6c60eb9f
SM
77372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7738
7739 * process.c (Qprocessp): Don't declare static.
7740 * lisp.h (Qprocessp): Declare again.
7741
7990b61a
JB
77422011-04-15 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7745
5d4cb038
PE
77462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7747
8bd7b830 7748 Improve C-level modularity by making more things 'static'.
cd64ea1d 7749
e3b27b31
PE
7750 Don't publish debugger-only interfaces to other modules.
7751 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7752 (verify_bytepos, count_markers): Move decls to the only modules
7753 that need them.
7754 * region-cache.h (pp_cache): Likewise.
7755 * window.h (check_all_windows): Likewise.
7756 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7757
5d4cb038
PE
7758 * sysdep.c (croak): Now static, if
7759 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7760 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7761
7762 * alloc.c (refill_memory_reserve): Now static if
7763 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7764 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7765
e87b6180
PE
7766 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7767 Define only if USE_LUCID.
7768
ac64929e
PE
7769 * xrdb.c (x_customization_string, x_rm_string): Now static.
7770
6f37259d
PE
7771 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7772 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7773
1683e3ab
PE
7774 * xdisp.c (draw_row_with_mouse_face): Now static.
7775 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7776
de9c2632
PE
7777 * window.h (check_all_windows): Mark externally visible.
7778
2b96acb7
PE
7779 * window.c (window_deletion_count): Now static.
7780
7781 * undo.c: Make symbols static if they're not exported.
7782 (last_undo_buffer, last_boundary_position, pending_boundary):
7783 Now static.
7784
50436f33
PE
7785 * textprop.c (interval_insert_behind_hooks): Now static.
7786 (interval_insert_in_front_hooks): Likewise.
7787
64520e5c
PE
7788 * term.c: Make symbols static if they're not exported.
7789 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7790 (max_frame_lines, tty_set_terminal_modes):
7791 (tty_reset_terminal_modes, tty_turn_off_highlight):
7792 (get_tty_terminal): Now static.
7793 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7794 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7795 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7796 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7797 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7798
1fa53021
PE
7799 * sysdep.c: Make symbols static if they're not exported.
7800 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7801 Now static.
7802 (sigprocmask_set, full_mask): Remove; unused.
7803 (wait_debugging): Mark as visible.
7804 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7805 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7806
d4b43b22
PE
7807 * syntax.c (syntax_temp): Define only if !__GNUC__.
7808
b7c513d0
PE
7809 * sound.c (current_sound_device, current_sound): Now static.
7810
989b29ad
PE
7811 * search.c (searchbufs, searchbuf_head): Now static.
7812
13a55a78
PE
7813 * scroll.c (scroll_cost): Remove; unused.
7814 * dispextern.h (scroll_cost): Remove decl.
7815
de68a1fc
PE
7816 * region-cache.h (pp_cache): Mark as externally visible.
7817
40ccffa6
PE
7818 * process.c: Make symbols static if they're not exported.
7819 (process_tick, update_tick, create_process, chan_process):
7820 (Vprocess_alist, proc_buffered_char, datagram_access):
7821 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7822 (deactivate_process): Mark defn as static, as well as decl.
7823 * lisp.h (create_process): Remove decl.
7824 * process.h (chan_process, Vprocess_alist): Remove decls.
7825
ad64fc97
PE
7826 * print.c: Make symbols static if they're not exported.
7827 (print_depth, new_backquote_output, being_printed, print_buffer):
7828 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7829 (print_interval, print_number_index, initial_stderr_stream):
7830 Now static.
7831 * lisp.h (Fprinc): Remove decl.
7832 (debug_output_compilation_hack): Mark as externally visible.
7833
adddb265
PE
7834 * sysdep.c (croak): Move decl from here to syssignal.h.
7835 * syssignal.h (croak): Put it here, so the API can be checked when
7836 'croak' is called from dissociate_if_controlling_tty.
7837
1717ede2
PE
7838 * minibuf.c: Make symbols static if they're not exported.
7839 (minibuf_save_list, choose_minibuf_frame): Now static.
7840 * lisp.h (choose_minibuf_frame): Remove decl.
7841
fa5fb2bc
PE
7842 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7843
1e3890d1
PE
7844 * lread.c: Make symbols static if they're not exported.
7845 (read_objects, initial_obarray, oblookup_last_bucket_number):
7846 Now static.
7847 (make_symbol): Remove; unused.
7848 * lisp.h (initial_obarray, make_symbol): Remove decls.
7849
8a1414fa
PE
7850 * keyboard.c: Make symbols static if they're not exported.
7851 (single_kboard, recent_keys_index, total_keys, recent_keys):
7852 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7853 (this_single_command_key_start, echoing, last_auto_save):
7854 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7855 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7856 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7857 (Vlispy_mouse_stem, double_click_count):
7858 Now static.
7859 (force_auto_save_soon): Define only if SIGDANGER.
7860 (ignore_mouse_drag_p): Now static if
7861 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7862 (print_help): Remove; unused.
7863 (stop_character, last_timer_event): Mark as externally visible.
7864 * keyboard.h (ignore_mouse_drag_p): Declare only if
7865 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7866 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7867 * lisp.h (echoing): Remove decl.
7868 (force_auto_save_soon): Declare only if SIGDANGER.
7869 * xdisp.c (redisplay_window): Simplify code, to make it more
7870 obvious that ignore_mouse_drag_p is not accessed if !defined
7871 USE_GTK && !defined HAVE_NS.
7872
93ea6e8f
PE
7873 * intervals.c: Make symbols static if they're not exported.
7874 (merge_properties_sticky, merge_interval_right, delete_interval):
7875 Now static.
7876 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7877
77382fcc
PE
7878 * insdel.c: Make symbols static if they're not exported.
7879 However, leave prepare_to_modify_buffer alone. It's never
7880 called from outside this function, but that appears to be a bug.
7881 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7882 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7883 (adjust_after_replace_noundo): Remove; unused.
7884 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7885 (signal_before_change): Remove decls.
77382fcc 7886
9306c32e
PE
7887 * indent.c (val_compute_motion, val_vmotion): Now static.
7888
cd44d2eb
PE
7889 * image.c: Make symbols static if they're not exported.
7890 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7891 if USE_GTK.
7892 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7893 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7894
ad9a7a06
PE
7895 * fringe.c (standard_bitmaps): Now static.
7896 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7897
81626931
PE
7898 * frame.c: Make symbols static if they're not exported.
7899 (x_report_frame_params, make_terminal_frame): Now static.
7900 (get_frame_param): Now static, unless HAVE_NS.
7901 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7902 (x_get_resource_string): Remove; not used.
7903 * frame.h (make_terminal_frame, x_report_frame_params):
7904 (x_get_resource_string); Remove decls.
7905 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7906 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7907
239f9db9
PE
7908 * font.c, fontset.c: Make symbols static if they're not exported.
7909 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7910 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7911 * font.c (font_close_object): Now static.
7912 * font.h (font_close_object): Remove.
7913 * fontset.c (FONTSET_OBJLIST): Remove.
7914 (free_realized_fontset) #if-0 the body, which does nothing.
7915 (face_suitable_for_char_p): #if-0, as it's never called.
7916 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7917 * xfaces.c (face_at_string_position):
7918 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7919 since 0 is always ASCII.
7920
dfcf3579
PE
7921 * fns.c (weak_hash_tables): Now static.
7922
5045092b
PE
7923 * fileio.c: Make symbols static if they're not exported.
7924 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7925 (Vwrite_region_annotation_buffers): Now static.
7926
57a96f5c
PE
7927 * eval.c: Make symbols static if they're not exported.
7928 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7929 * lisp.h (backtrace_list): Remove decl.
7930
35f08c38
PE
7931 * emacs.c: Make symbols static if they're not exported.
7932 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7933 (fatal_error_code, fatal_error_signal_hook, standard_args):
7934 Now static.
7935 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7936 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7937 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7938 * lisp.h (fatal_error_signal_hook): Remove decl.
7939 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7940
f44bd759
PE
7941 * editfns.c: Move a (normally-unused) function to its only use.
7942 * editfns.c, lisp.h (get_operating_system_release): Remove.
7943 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7944 worth the hassle of breaking this out.
7945
b532497d
PE
7946 * xterm.c: Make symbols static if they're not exported.
7947 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7948 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7949 (x_destroy_window, x_delete_display):
7950 Now static.
7951 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7952 (x_mouse_leave): Remove; unused.
7953 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7954 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7955 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7956 Remove decls.
7957 (x_mouse_leave): Declare only if WINDOWSNT.
7958 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7959 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7960 USE_X_TOOLKIT.
7961
1675728f
PE
7962 * ftxfont.c: Make symbols static if they're not exported.
7963 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7964 HAVE_FREETYPE.
7965 * font.h (ftxfont_driver): Likewise.
7966
e4cebfca
PE
7967 * xfns.c: Make symbols static if they're not exported.
7968 (x_last_font_name, x_display_info_for_name):
7969 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7970 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7971 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7972 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7973 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7974 (last_show_tip_args): Now static.
7975 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7976 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7977 (x_screen_planes): Remove; unused.
7978 * dispextern.h (x_screen_planes): Remove decl.
7979
5bf46f05
PE
7980 * dispnew.c: Make symbols static if they're not exported.
7981 * dispextern.h (redraw_garbaged_frames, scrolling):
7982 (increment_row_positions): Remove.
7983 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7984 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7985 Now static.
7986 (redraw_garbaged_frames): Remove; unused.
7987
435f4c28
PE
7988 * xfaces.c: Make symbols static if they're not exported.
7989 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7990 Remove decls.
7991 * xterm.h (defined_color): Remove decls.
7992 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7993 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7994 (menu_face_changed_default, defined_color, free_realized_face):
7995 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7996 (ascii_face_of_lisp_face): Remove; unused.
7997
8524aef3
PE
7998 * xdisp.c: Make symbols static if they're not exported.
7999 * dispextern.h (scratch_glyph_row, window_box_edges):
8000 (glyph_to_pixel_coords, set_cursor_from_row):
8001 (get_next_display_element, set_iterator_to_next):
8002 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8003 (show_mouse_face): Remove decls
8004 * frame.h (message_buf_print): Likewise.
8005 * lisp.h (pop_message, set_message, check_point_in_composition):
8006 Likewise.
8007 * xterm.h (set_vertical_scroll_bar): Likewise.
8008 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8009 (message_buf_print, scratch_glyph_row, displayed_buffer):
8010 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8011 (get_next_display_element, show_mouse_face, window_box_edges):
8012 (frame_to_window_pixel_xy, check_point_in_composition):
8013 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8014 (glyph_to_pixel_coords): Remove; unused.
8015
16390cd2
PE
8016 * dired.c (file_name_completion): Now static.
8017
8018 * dbusbind.c (xd_in_read_queued_messages): Now static.
8019
a25f4dfa
PE
8020 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8021 * data.c (circular_list_error): Remove.
8022
14a9c8df
PE
8023 * commands.h (last_point_position, last_point_position_buffer):
8024 (last_point_position_window): Remove decls.
8025 * keyboard.c: Make these variables static.
8026
04f2d78b
CB
8027 * coding.h (coding, code_convert_region, encode_coding_gap):
8028 Remove decls.
74ab6df5
PE
8029 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8030 (iso_code_class, detect_coding, code_convert_region): Now static.
8031 (encode_coding_gap): Remove; unused.
8032
38dfbee1
PE
8033 * chartab.c (chartab_chars, chartab_bits): Now static.
8034
a2cb4e63
PE
8035 * charset.h (charset_iso_8859_1): Remove decl.
8036 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8037 Now static.
8038
127198fd
PE
8039 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8040 * ccl.c (Vccl_program_table): Now static.
8041 (check_ccl_update): Remove; unused.
8042
d85b608f
PE
8043 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8044 * category.h: ... from here.
8045 * category.c (check_category_table, set_category_set): Now static.
8046
31cd66f3
PE
8047 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8048 * lisp.h: Remove these decls.
8049
c358e587
PE
8050 * buffer.c (buffer_count): Remove unused var.
8051
e78aecca
PE
8052 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8053 so that it's not optimized away.
8054 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8055 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8056 exported only to the debugger.
8057
e192d7d3 8058 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8059 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8060
92470028
PE
8061 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8062 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8063 was inaccessible from Lisp.
8064 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8065 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8066
244ed907
PE
8067 alloc.c: Import and export fewer symbols, and remove unused items.
8068 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8069 is defined.
8070 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8071 it's not optimized away by whole-program optimization.
8072 (message_enable_multibyte, free_misc): Remove.
8073 (catchlist, handlerlist, mark_backtrace):
8074 Declare only if BYTE_MARK_STACK.
8075 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8076 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8077 (message_enable_multibyte): Remove decl.
8078 (free_misc, interval_free_list, float_block, float_block_index):
8079 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8080 (cons_free_list, last_marked_index):
8081 Now static.
8082 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8083 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8084 (mark_backtrace): Define only if BYTE_MARK_STACK.
8085 * xdisp.c (message_enable_multibyte): Now static.
8086
61c2b50e 8087 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8088 This makes it easier for human readers (and static analyzers)
8089 to see whether these variables are used from other modules.
8090 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8091 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8092 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8093 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8094 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8095 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8096 * xmenu.c, xselect.c:
8097 Declare Q* vars static if they are not used in other modules.
8098 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8099 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8100 Remove decls of unexported vars.
8101 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8102
95c82688
PE
8103 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8104
16a97296
PE
8105 Make Emacs functions such as Fatom 'static' by default.
8106 This makes it easier for human readers (and static analyzers)
8107 to see whether these functions can be called from other modules.
8108 DEFUN now defines a static function. To make the function external
8109 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8110 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8111 (Finit_image_library):
16a97296
PE
8112 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8113 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8114 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8115 Remove decls, since these functions are now static.
8116 (Funintern, Fget_internal_run_time): New decls, since these functions
8117 were already external.
95c82688 8118
16a97296
PE
8119 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8120 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8121 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8122 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8123 * keyboard.c, keymap.c, lread.c:
8124 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8125 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8126 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8127 Mark functions with DEFUE instead of DEFUN,
8128 if they are used in other modules.
8129 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8130 decls for now-static functions.
8131 * buffer.h (Fdelete_overlay): Remove decl.
8132 * callproc.c (Fgetenv_internal): Mark as internal.
8133 * composite.c (Fremove_list_of_text_properties): Remove decl.
8134 (Fcomposition_get_gstring): New forward static decl.
8135 * composite.h (Fcomposite_get_gstring): Remove decl.
8136 * dired.c (Ffile_attributes): New forward static decl.
8137 * doc.c (Fdocumntation_property): New forward static decl.
8138 * eval.c (Ffetch_bytecode): New forward static decl.
8139 (Funintern): Remove extern decl; now in .h file where it belongs.
8140 * fileio.c (Fmake_symbolic_link): New forward static decl.
8141 * image.c (Finit_image_library): New forward static decl.
8142 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8143 * intervals.h (Fprevious_property_change):
8144 (Fremove_list_of_text_properties): Remove decls.
8145 * keyboard.c (Fthis_command_keys): Remove decl.
8146 (Fcommand_execute): New forward static decl.
8147 * keymap.c (Flookup_key): New forward static decl.
8148 (Fcopy_keymap): Now static.
8149 * keymap.h (Flookup_key): Remove decl.
8150 * process.c (Fget_process): New forward static decl.
8151 (Fprocess_datagram_address): Mark as internal.
8152 * syntax.c (Fsyntax_table_p): New forward static decl.
8153 (skip_chars): Remove duplicate decl.
8154 * textprop.c (Fprevious_property_change): New forward static decl.
8155 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8156 Now internal.
8157 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8158 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8159
785bbd42
PE
8160 * editfns.c (Fformat): Remove unreachable code.
8161
8b913b57
AS
81622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8163
8164 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8165 change. (Bug#8496)
8166
a6744a35
EZ
81672011-04-13 Eli Zaretskii <eliz@gnu.org>
8168
8169 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8170 when at ZV. (Bug#8487)
8171
e7974947
AS
81722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8173
baad03f0
AS
8174 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8175 (Bug#8437)
8176 * keyboard.c (parse_tool_bar_item): Likewise.
8177 * sound.c (sound_cleanup, alsa_close): Likewise.
8178 * termcap.c (tgetent): Likewise.
8179 * xfns.c (x_default_font_parameter): Likewise.
8180 * xsettings.c (read_and_apply_settings): Likewise.
8181
e7974947
AS
8182 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8183 (overrun_check_free): Protoize.
8184
28272684
PE
81852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8186
8187 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8188 since callers should never pass a negative size.
8189 Change the signature to match that of plain 'read' and 'write'; see
8190 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8191 * lisp.h: Update prototypes of emacs_write and emacs_read.
8192
11997c76
EZ
81932011-04-11 Eli Zaretskii <eliz@gnu.org>
8194
8195 * xdisp.c (redisplay_window): Don't try to determine the character
8196 position of the scroll margin if the window start point w->startp
e896f03c 8197 is outside the buffer's accessible region. (Bug#8468)
11997c76 8198
8a2cbd72
EZ
81992011-04-10 Eli Zaretskii <eliz@gnu.org>
8200
8201 Fix write-region and its subroutines for buffers > 2GB.
8202 * fileio.c (a_write, e_write): Modify declaration of arguments and
8203 local variables to support buffers larger than 2GB.
8204 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8205
8206 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8207 argument, local variables, and return value.
8208
8209 * lisp.h: Update prototypes of emacs_write and emacs_read.
8210
8211 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8212
4073e537 82132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8214
1ebfdcb6
PE
8215 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8216
b2ded58d
PE
8217 Fix more problems found by GCC 4.6.0's static checks.
8218
7d66342c
PE
8219 * xdisp.c (vmessage): Use a better test for character truncation.
8220
bbf47d44
PE
8221 * charset.c (load_charset_map): <, not <=, for optimization,
8222 and to avoid potential problems with integer overflow.
9248994d 8223 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8224 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8225 * editfns.c (Fformat): Likewise.
1e69125e 8226 * syntax.c (skip_chars): Likewise.
3befa583 8227
e3019616
PE
8228 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8229 This also lets GCC 4.6.0 generate slightly better loop code.
8230
becfa255
PE
8231 * callint.c (Fcall_interactively): <, not <=, for optimization.
8232 (Fcall_interactively): Count the number of arguments produced,
8233 not the number of arguments given. This is simpler and lets GCC
8234 4.6.0 generate slightly better code.
8235
dae0cd48
PE
8236 * ftfont.c: Distingish more carefully between FcChar8 and char.
8237 The previous code passed unsigned char * to a functions like
8238 strlen and xstrcasecmp that expect char *, which does not
8239 conform to the C standard.
8240 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8241 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8242 char * when the C standard requires it.
8243
76032d70
PE
8244 * keyboard.c (read_char): Remove unused var.
8245
eb3f1cc8
PE
8246 * eval.c: Port to Windows vsnprintf (Bug#8435).
8247 Include <limits.h>.
8248 (SIZE_MAX): Define if the headers do not.
8249 (verror): Do not give up if vsnprintf returns a negative count.
8250 Instead, grow the buffer. This ports to Windows vsnprintf, which
8251 does not conform to C99. Problem reported by Eli Zaretskii.
8252 Also, simplify the allocation scheme, by avoiding the need for
8253 calling realloc, and removing the ALLOCATED variable.
8254
70476b54
PE
8255 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8256
12020a9e
PE
8257 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8258 But keep the doprint source code for now, as we might revamp it
8259 and use it again (Bug#8435).
ea6c7ae6
PE
8260 * lisp.h (doprnt): Remove.
8261 * Makefile.in (base_obj): Remove doprnt.o.
8262 * deps.mk (doprnt.o): Remove.
8263
5fdb398c
PE
8264 error: Print 32- and 64-bit integers portably (Bug#8435).
8265 Without this change, on typical 64-bit hosts error ("...%d...", N)
8266 was used to print both 32- and 64-bit integers N, which relied on
8267 undefined behavior.
61bdb816 8268 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8269 * lisp.h (error, verror): Mark as printf-like functions.
8270 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8271 Report overflow in size calculations when allocating printf buffer.
8272 Do not truncate output string at its first null byte.
8273 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8274 Truncate the output at a character boundary, since vsnprintf does not
8275 do that.
8276 * charset.c (check_iso_charset_parameter): Convert internal
8277 character to string before calling 'error', since %c now has the
8278 printf meaning.
8279 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8280 overflow when computing char to be passed to 'error'. Do not
8281 pass Lisp_Object to 'error'; pass the integer instead.
8282 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8283 formatted with plain %d.
8284
b189fa66
PE
8285 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8286
bff87ef0
PE
8287 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8288
7e2cac20
PE
8289 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8290
ce4d90b5
PE
8291 * xterm.c (x_catch_errors): Remove duplicate declaration.
8292
266c9547
PE
8293 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8294
79c49ad2
PE
8295 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8296
368f4090
JM
82972011-04-10 Jim Meyering <meyering@redhat.com>
8298
8299 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8300 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8301 return ssize_t not "int", and use size_t as the buffer length.
8302 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8303 * gnutls.h: Update declarations.
8304 * process.c (read_process_output): Use ssize_t, to match.
8305 (send_process): Likewise.
8306
a32d4040
CY
83072011-04-09 Chong Yidong <cyd@stupidchicken.com>
8308
8309 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8310
8546720e 83112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8312
04f2d78b
CB
8313 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8314 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8315
8546720e
GM
8316 * xterm.c (handle_one_xevent):
8317 * xmenu.c (create_and_show_popup_menu):
8318 * xselect.c (x_decline_selection_request)
8319 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8320
0a2f5c1a 83212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8322
8323 Fix some uses of `int' instead of EMACS_INT.
8324 * search.c (string_match_1, fast_string_match)
8325 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8326 (scan_buffer, find_next_newline_no_quit)
8327 (find_before_next_newline, search_command, Freplace_match)
8328 (Fmatch_data): Make some `int' variables be EMACS_INT.
8329
8330 * xdisp.c (display_count_lines): 3rd argument and return value now
8331 EMACS_INT. All callers changed.
8332 (pint2hrstr): Last argument is now EMACS_INT.
8333
8334 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8335 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8336 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8337 (decode_coding_utf_16, decode_coding_emacs_mule)
8338 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8339 (decode_coding_ccl, decode_coding_charset)
8340 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8341 (decode_coding_iso_2022, decode_coding_emacs_mule)
8342 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8343 <char_offset, last_offset>: Declare EMACS_INT.
8344 (encode_coding_utf_8, encode_coding_utf_16)
8345 (encode_coding_emacs_mule, encode_invocation_designation)
8346 (encode_designation_at_bol, encode_coding_iso_2022)
8347 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8348 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8349 Declare EMACS_INT.
8350 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8351 (encode_invocation_designation): Last argument P_NCHARS is now
8352 EMACS_INT.
8353 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8354 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8355
8356 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8357 All users changed.
8358
8359 * ccl.c (Fccl_execute_on_string): Declare some variables
8360 EMACS_INT.
8361
8546720e 83622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8363
8364 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8365
4e19a977
CS
83662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8367
8368 * process.c (Fformat_network_address): Doc fix.
8369
87302331
R
83702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8371
ee7683eb 8372 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8373
cbb59342
CY
83742011-04-08 Chong Yidong <cyd@stupidchicken.com>
8375
8376 * keyboard.c (read_char): Call Lisp function help-form-show,
8377 instead of using internal_with_output_to_temp_buffer.
8378 (Qhelp_form_show): New var.
e0d38eeb 8379 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8380
8381 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8382
8383 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8384
e67a13ab
CY
83852011-04-06 Chong Yidong <cyd@stupidchicken.com>
8386
04f2d78b
CB
8387 * process.c (Flist_processes): Remove to Lisp.
8388 (list_processes_1): Delete.
e67a13ab 8389
973f782d
EZ
83902011-04-06 Eli Zaretskii <eliz@gnu.org>
8391
7c106b1e
EZ
8392 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8393
973f782d
EZ
8394 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8395
41cf7d1a 83962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8397
ca23cc88
PE
8398 Fix more problems found by GCC 4.6.0's static checks.
8399
f390e2d5
PE
8400 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8401
42eea0d0
PE
8402 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8403
b69769da 8404 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8405
f9541e84
PE
8406 * xdisp.c (vmessage): Mark as a printf-like function.
8407
13841b55
PE
8408 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8409
c136c10f
PE
8410 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8411
5e2d4a30
PE
8412 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8413 printf-like functions.
8414 (tiff_load): Add casts to remove these marks before passing them
8415 to system-supplied API.
8416
583f48b9
PE
8417 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8418
b25d760e
PE
8419 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8420 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8421 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8422 directly, rather than having caller test rule sign. This avoids
8423 some unnecessary tests.
8424 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8425 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8426 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8427
bc7b6697 8428 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8429 (xfont_open): Avoid unnecessary tests.
bc7b6697 8430
27ccc379
PE
8431 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8432
dcd5c89a
PE
8433 * composite.h, composite.c (composition_gstring_put_cache):
8434 Use EMACS_INT, not int, for length.
8435
b13a45c6
PE
8436 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8437 breaking out part of COMPOSITION_DECODE_RULE.
8438 (COMPOSITION_DECODE_RULE): Use it.
8439 * composite.c (get_composition_id): Remove unused local vars,
8440 by using the new macro.
8441
1e792e4d
PE
8442 * textprop.c (set_text_properties_1): Change while to do-while,
8443 since the condition is always true at first.
8444
dc6c6455 8445 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8446 (interval_deletion_adjustment): Return unsigned value.
8447 All uses changed.
dc6c6455 8448
aba7731a
PE
8449 * process.c (list_processes_1, create_pty, read_process_output):
8450 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8451 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8452 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8453 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8454 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8455
fdfc4bf3
PE
8456 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8457
fca8fe46 8458 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8459 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8460
06a0259a 8461 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8462 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8463 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8464
e7b9e80f
PE
8465 * print.c (print_error_message): Avoid int overflow.
8466
56201685
PE
8467 * font.c (font_list_entities): Redo for clarity,
8468 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8469
78834453 8470 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8471 (font_score): Avoid potential overflow in diff calculation.
78834453 8472
0bc0b309 8473 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8474 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8475
e610eaca
PE
8476 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8477
b895abce
PE
8478 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8479 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8480 can always succeed if overflow has undefined behavior.
8481
1f1d9321 8482 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8483 (wordify): Omit three unnecessary tests.
1f1d9321 8484
c59478bc
PE
8485 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8486 All callers changed. This avoids the need for an unused var.
8487
79b73827
PE
8488 * casefiddle.c (casify_region): Remove var that is set but not used.
8489
a4db5dfe
PE
8490 * dired.c (file_name_completion): Remove var that is set but not used.
8491
43aae36e
PE
8492 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8493
2a47c44d 8494 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8495 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8496
a37c69bf
PE
8497 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8498 Check for integer overflow on size calculations.
8499
328ab8e7
PE
8500 * buffer.c (Fprevious_overlay_change): Remove var that is set
8501 but not used.
8502
e5a2a5cb
PE
8503 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8504 Remove vars that are set but not used.
8d84a6eb 8505 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8506 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8507
a60e5f68
PE
8508 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8509
f661cb61 8510 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8511 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8512
f0397f5a
PE
8513 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8514 that are set but not used.
8515
8664db06 8516 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8517 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8518
6abdaa4a
PE
8519 * xselect.c (x_get_local_selection, x_handle_property_notify):
8520 Remove vars that are set but not used.
8521
0ce7538d 8522 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8523 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8524
9ae848fc
PE
8525 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8526 Remove var that is set but not used.
0b918413
PE
8527 (scroll_bar_windows_size): Now size_t, not int.
8528 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8529 Check for overflow.
9ae848fc 8530
a5a62657
PE
8531 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8532 (map_tty_color) [!defined MSDOS]: Likewise.
8533
5c5cdd39
PE
8534 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8535
66ebf983
PE
8536 * coding.c: Remove vars that are set but not used.
8537 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8538 All callers changed.
8539 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8540 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8541 (decode_coding_charset): Remove vars that are set but not used.
8542
1be4d761
PE
8543 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8544 that is set but not used.
8545
47553fa8
PE
8546 * print.c (print_object): Remove var that is set but not used.
8547
1f7196bf 8548 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8549 The gnulib version avoids calling malloc in the usual case,
8550 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8551 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8552 * filelock.c (current_lock_owner): Likewise.
8553 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8554 * sysdep.c: Include allocator.h, careadlinkat.h.
8555 (emacs_no_realloc_allocator): New static constant.
8556 (emacs_readlink): New function.
fdb61804
PE
8557 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8558 ../lib/careadlinkat.h.
d1fdcab7 8559
f84c17c7
SM
85602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8561
8562 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8563 first non-nil return value).
8564
ef3862ad
JD
85652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8566
8567 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8568 if not defined (Bug#8403).
8569
376a7006
JB
85702011-04-02 Juanma Barranquero <lekktu@gmail.com>
8571
8572 * xdisp.c (display_count_lines): Remove parameter `start',
8573 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8574 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8575 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8576 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8577 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8578 and thereabouts. All callers changed.
8579 (get_per_char_metric): Remove parameter `f', unused since
8580 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8581
6ca3801d
JM
85822011-04-02 Jim Meyering <meyering@redhat.com>
8583
8584 do not dereference NULL upon failed strdup
8585 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8586 (ns_get_family): Likewise.
8587
d8e2b5ba
JB
85882011-04-02 Juanma Barranquero <lekktu@gmail.com>
8589
8590 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8591
8c74fcbd
JD
85922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8593
8594 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8595 later (Bug#8403).
8596
7200d79c
SM
85972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8598
03408648 8599 Add lexical binding.
7200d79c 8600
03408648
SM
8601 * window.c (Ftemp_output_buffer_show): New fun.
8602 (Fsave_window_excursion):
8603 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8604
8605 * lread.c (lisp_file_lexically_bound_p): New function.
8606 (Fload): Bind Qlexical_binding.
8607 (readevalloop): Remove `evalfun' arg.
8608 Bind Qinternal_interpreter_environment.
8609 (Feval_buffer): Bind Qlexical_binding.
8610 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8611 Mark as dynamic.
8612 (syms_of_lread): Declare `lexical-binding'.
8613
8614 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8615
8616 * keyboard.c (eval_dyn): New fun.
8617 (menu_item_eval_property): Use it.
ca105506
SM
8618
8619 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8620
03408648
SM
8621 * fns.c (concat, mapcar1): Accept byte-code-functions.
8622
8623 * eval.c (Fsetq): Handle lexical vars.
8624 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8625 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8626 (FletX, Flet): Obey lexical binding.
8627 (Fcommandp): Handle closures.
8628 (Feval): New `lexical' arg.
8629 (eval_sub): New function extracted from Feval. Use it almost
8630 everywhere where Feval was used. Look up vars in lexical env.
8631 Handle closures.
8632 (Ffunctionp): Move from subr.el.
8633 (Ffuncall): Handle closures.
8634 (apply_lambda): Remove `eval_flags'.
8635 (funcall_lambda): Handle closures and new byte-code-functions.
8636 (Fspecial_variable_p): New function.
8637 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8638 but without exporting it to Lisp.
23aba0ea 8639
23aba0ea 8640 * doc.c (Fdocumentation, store_function_docstring):
03408648 8641 * data.c (Finteractive_form): Handle closures.
23aba0ea 8642
03408648
SM
8643 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8644 interactive spec.
ba83908c 8645
04f2d78b
CB
8646 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8647 New byte-codes.
03408648
SM
8648 (exec_byte_code): New function extracted from Fbyte_code to handle new
8649 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8650
03408648 8651 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8652
03408648 8653 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8654
e2abce01
JB
86552011-03-31 Juanma Barranquero <lekktu@gmail.com>
8656
8657 * xdisp.c (redisplay_internal): Fix prototype.
8658
63696a73 86592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8660
63696a73 8661 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8662 (try_scrolling): Use it when setting scroll_limit.
8663 Limit scrolling to 100 screen lines.
63696a73
EZ
8664 (redisplay_window): Even when falling back on "recentering",
8665 position point in the window according to scroll-conservatively,
8666 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8667
8668 (try_scrolling): When point is above the window, allow searching
8669 as far as scroll_max, or one screenful, to compute vertical
8670 distance from PT to the scroll margin position. This prevents
8671 try_scrolling from unnecessarily failing when
8672 scroll-conservatively is set to a value slightly larger than the
8673 window height. Clean up the case of PT below the margin at bottom
8674 of window: scroll_max can no longer be INT_MAX. When aggressive
8675 scrolling is in use, don't let point enter the opposite scroll
8676 margin as result of the scroll.
8677 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8678 threshold of 100 lines for never-recentering scrolling.
8679
e4cc2dfc
JB
86802011-03-31 Juanma Barranquero <lekktu@gmail.com>
8681
8682 * dispextern.h (move_it_by_lines):
8683 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8684 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8685 (message_log_check_duplicate): Remove parameters `prev_bol' and
8686 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8687 (redisplay_internal): Remove parameter `preserve_echo_area',
8688 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8689
8690 * indent.c (Fvertical_motion):
8691 * window.c (window_scroll_pixel_based, Frecenter):
8692 Don't pass `need_y_p' to `move_it_by_lines'.
8693
1c470562
SM
86942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8695
44f230aa
SM
8696 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8697 steal a few bits to be more compact.
8698 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8699 Remove unneeded casts.
8700
1c470562
SM
8701 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8702
888adce9
ZK
87032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8704
8705 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8706 binding" message (bug#7967).
8707
f838ed7b
PE
87082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8709
77861b95
PE
8710 Fix more problems found by GCC 4.6.0's static checks.
8711
de6dbc14
PE
8712 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8713 Remove unused local var.
8714
f838ed7b
PE
8715 * editfns.c (Fmessage_box): Remove unused local var.
8716
792c7b2b
PE
8717 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8718 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8719 Omit unused local vars.
c499e557 8720 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8721 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8722 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8723 Omit unused local var.
8724
ba0165e1
PE
8725 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8726 Don't assume string length fits in int.
32ad8845 8727 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8728 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8729
3c59b4c9
PE
8730 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8731 instead of alloca (Bug#8344).
8732
a3eed478 8733 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8734 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8735
eb4d412d
PE
8736 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8737
1658b401
PE
8738 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8739 concerns.
8740
8741 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8742
8743 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8744
9a2c6e05
PE
8745 * keyboard.c (syms_of_keyboard): Use the same style as later
8746 in this function when indexing through an array. This also
8747 works around GCC bug 48267.
8748
03d0a109
PE
8749 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8750
44f730c8
PE
8751 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8752
fe75f926
PE
8753 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8754 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8755
ffa8c828
PE
8756 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8757 This avoids undefined behavior on integer overflow, and is a bit
8758 more convenient anyway since it is compared to a size_t variable.
8759
c5101a77
PE
8760 Variadic C functions now count arguments with size_t, not int.
8761 This avoids an unnecessary limitation on 64-bit machines, which
8762 caused (substring ...) to crash on large vectors (Bug#8344).
8763 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8764 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8765 All variadic functions and their callers changed accordingly.
c5101a77
PE
8766 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8767 * data.c (arith_driver, float_arith_driver): Likewise.
8768 * editfns.c (general_insert_function): Likewise.
8769 * eval.c (struct backtrace.nargs, interactive_p)
8770 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8771 (funcall_lambda, mark_backtrace): Likewise.
8772 * fns.c (concat): Likewise.
8773 * frame.c (x_set_frame_parameters): Likewise.
8774 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8775 0 if not found, not -1. All callers changed.
8776
dd3f25f7
PE
8777 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8778 (stack_copy_size): Now size_t, not int.
8779 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8780
461c2ab9
JB
87812011-03-28 Juanma Barranquero <lekktu@gmail.com>
8782
8783 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8784 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8785 All callers changed.
8786
8787 * lisp.h (multibyte_char_to_unibyte):
8788 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8789 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8790 * character.h (CHAR_TO_BYTE8):
8791 * cmds.c (internal_self_insert):
8792 * editfns.c (general_insert_function):
8793 * keymap.c (push_key_description):
8794 * search.c (Freplace_match):
8795 * xdisp.c (message_dolog, set_message_1): All callers changed.
8796
f6d62986
SM
87972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8798
8799 * keyboard.c (safe_run_hook_funcall): New function.
8800 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8801 don't set the hook to nil, but remove the offending function instead.
8802 (Qcommand_hook_internal): Remove, unused.
8803 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8804 Vcommand_hook_internal.
8805
8806 * eval.c (enum run_hooks_condition): Remove.
8807 (funcall_nil, funcall_not): New functions.
8808 (run_hook_with_args): Call each function through a `funcall' argument.
8809 Remove `cond' argument, now redundant.
8810 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8811 (Frun_hook_with_args_until_failure): Adjust accordingly.
8812 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8813
1db5b1ad
JB
88142011-03-28 Juanma Barranquero <lekktu@gmail.com>
8815
8816 * dispextern.h (string_buffer_position): Remove declaration.
8817
8818 * print.c (strout): Remove parameter `multibyte', unused since
8819 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8820
8821 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8822 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8823 All callers changed.
8824
8825 * w32.c (_wsa_errlist): Use braces for struct initializers.
8826
8827 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8828 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8829 All callers changed.
8830 (string_buffer_position): Likewise. Also, make static (it's never
8831 used outside xdisp.c).
8832 (cursor_row_p): Remove parameter `w', unused since
8833 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8834 (decode_mode_spec): Remove parameter `precision', introduced during
8835 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8836 All callers changed.
8837
5ffb62aa
JD
88382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8839
8840 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8841
461c2ab9 88422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8843
8844 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8845 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8846 (ns_update_auto_hide_menu_bar): New functions.
8847 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8848 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8849 ns_constrain_all_frames.
8850 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8851 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8852
5c380ffb
JD
88532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8854
8855 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8856
9af30bdf
GM
88572011-03-27 Glenn Morris <rgm@gnu.org>
8858
8859 * syssignal.h: Replace RETSIGTYPE with void.
8860 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8861 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8862 Replace SIGTYPE with void everywhere.
8863 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8864 * s/template.h (SIGTYPE): Remove commented out definition.
8865
e2abce01
JB
88662011-03-26 Eli Zaretskii <eliz@gnu.org>
8867
8868 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8869 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8870
f868cd8a
JB
88712011-03-26 Juanma Barranquero <lekktu@gmail.com>
8872
59eb0929
JB
8873 * w32.c (read_unc_volume): Use parameter `henum', instead of
8874 global variable `wget_enum_handle'.
8875
8876 * keymap.c (describe_vector): Remove parameters `indices' and
8877 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8878 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8879
f868cd8a
JB
8880 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8881
8882 * keyboard.c (timer_check): Remove parameter `do_it_now',
8883 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8884 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8885 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8886
8887 * keyboard.c (read_char):
8888 * w32menu.c (w32_menu_display_help):
8889 * xmenu.c (show_help_event, menu_help_callback):
8890 Adjust calls to `show_help_echo'.
8891
8892 * gtkutil.c (xg_maybe_add_timer):
8893 * keyboard.c (readable_events):
8894 * process.c (wait_reading_process_output):
8895 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8896
8897 * insdel.c (adjust_markers_gap_motion):
8898 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8899 (gap_left, gap_right): Don't call it.
8900
2ecf6fdb
CY
89012011-03-25 Chong Yidong <cyd@stupidchicken.com>
8902
8903 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8904 incurred during fontification.
8905
6b1f9ba4
JB
89062011-03-25 Juanma Barranquero <lekktu@gmail.com>
8907
8908 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8909 (DEFVAR_PER_BUFFER): Don't pass it.
8910
8911 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8912 (scrolling_window): Don't pass it.
8913
0f4a96b5
JB
89142011-03-25 Juanma Barranquero <lekktu@gmail.com>
8915
8916 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8917
8918 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8919 and `suffix'.
8920 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8921 of variables specific to SELinux and computation of `encoded_absname'.
8922
8923 * image.c (XPutPixel): Remove unused variable `height'.
8924
8925 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8926
8927 * unexw32.c (get_section_info): Remove unused variable `section'.
8928
8929 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8930 (system_process_attributes): Remove unused variable `sess'.
8931 (sys_read): Remove unused variable `err'.
8932
8933 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8934 (w32_wnd_proc): Remove unused variable `isdead'.
8935 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8936 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8937 (x_create_tip_frame): Remove unused variable `tem'.
8938
8939 * w32inevt.c (w32_console_read_socket):
8940 Remove unused variable `no_events'.
8941
8942 * w32term.c (x_draw_composite_glyph_string_foreground):
8943 Remove unused variable `width'.
8944
1149507c
JB
89452011-03-24 Juanma Barranquero <lekktu@gmail.com>
8946
8947 * w32term.c (x_set_glyph_string_clipping):
8948 Don't pass uninitialized region to CombineRgn.
8949
9c88f339
JB
89502011-03-23 Juanma Barranquero <lekktu@gmail.com>
8951
8952 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8953 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8954 (Fx_close_connection): Remove unused variable `i'.
8955
8956 * w32font.c (w32font_draw): Return number of glyphs.
8957 (w32font_open_internal): Remove unused variable `i'.
8958 (w32font_driver): Add missing initializer.
8959
8960 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8961 (fill_in_menu): Remove unused variable `items_added'.
8962
8963 * w32term.c (last_mouse_press_frame): Remove static global variable.
8964 (w32_clip_to_row): Remove unused variable `f'.
8965 (x_delete_terminal): Remove unused variable `i'.
8966
8967 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8968 (NOTHING): Remove unused static global variable.
8969 (uniscribe_check_otf): Remove unused variable `table'.
8970 (uniscribe_font_driver): Add missing initializers.
8971
dee091a3
JD
89722011-03-23 Julien Danjou <julien@danjou.info>
8973
8974 * term.c (Fsuspend_tty, Fresume_tty):
8975 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8976 * window.c (temp_output_buffer_show):
8977 * insdel.c (signal_before_change):
8978 * frame.c (Fhandle_switch_frame):
8979 * fileio.c (Fdo_auto_save):
8980 * emacs.c (Fkill_emacs):
8981 * editfns.c (save_excursion_restore):
8982 * cmds.c (internal_self_insert):
8983 * callint.c (Fcall_interactively):
8984 * buffer.c (Fkill_all_local_variables):
8985 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8986 Use Frun_hooks.
0f4a96b5 8987 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8988 unconditionally since it does the check itself.
dee091a3 8989
2c520ab5 89902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8991
c9c49752
PE
8992 Fix more problems found by GCC 4.5.2's static checks.
8993
8abc3f12
PE
8994 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8995 the first time through the loop, since we know p0 < p1 then.
8996 This also avoids a gcc -Wstrict-overflow warning.
8997
a2d26660
PE
8998 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8999 leading to a memory leak, possible in functions like
9000 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9001 of objects (Bug#8318).
a2d26660 9002
916c72e9
PE
9003 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9004 that could (at least in theory) be that large.
9005
19ab8a18
PE
9006 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9007 This is less likely to overflow, and avoids undefined behavior if
9008 overflow does occur. All callers changed. Use strtoul to scan
9009 for the unsigned long integer.
b7cbbd6f
PE
9010 (pint2hrstr): Simplify and tune code slightly.
9011 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9012
f0641eff
PE
9013 * scroll.c (do_scrolling): Work around GCC bug 48228.
9014 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9015
7f650bb9
PE
9016 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9017 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9018 (validate_x_resource_name): Simplify count usage.
9019 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9020
37dd57d1
PE
9021 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9022 fail (Bug#8306).
81e56e61 9023
699979fc 9024 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9025
401bf9b4
PE
9026 * process.c (Fmake_network_process): Use socklen_t, not int,
9027 where POSIX says socklen_t is required in portable programs.
9028 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9029 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9030 (Fmake_network_process, server_accept_connection):
9031 (wait_reading_process_output, read_process_output):
9032 Likewise.
9033
b93aacde
PE
9034 * process.c: Rename or move locals to avoid shadowing.
9035 (list_processes_1, Fmake_network_process):
9036 (read_process_output_error_handler, exec_sentinel_error_handler):
9037 Rename or move locals.
4dc343ee 9038 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9039 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9040 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9041 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9042 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9043
af8a867c 9044 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9045 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9046 Include tparam.h instead, since it declares them.
af8a867c
PE
9047 * cm.h (PC): Remove extern decl; tparam.h now does this.
9048 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9049 * terminfo.c: Include tparam.h, to check interfaces.
9050 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9051 (tparam): Adjust signature to match interface in tparam.h;
9052 this removes some undefined behavior. Check that outstring and len
9053 are zero, which they always are with Emacs.
9054 * tparam.h (PC, BC, UP): New extern decls.
9055
0248044d 9056 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9057 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9058
8ff096c1 9059 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9060 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9061 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9062 (ftfont_list): Remove unused local.
49eaafba
PE
9063 (get_adstyle_property, ftfont_pattern_entity):
9064 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9065 Rename locals to avoid shadowing.
8ff096c1 9066
e2be39f6
PE
9067 * xfont.c (xfont_list_family): Mark var as initialized.
9068
c9735e30
PE
9069 * xml.c (make_dom): Now static.
9070
8f5201ae
PE
9071 * composite.c (composition_compute_stop_pos): Rename local to
9072 avoid shadowing.
b246f932
PE
9073 (composition_reseat_it): Remove unused locals.
9074 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9075 (composition_update_it): Mark var as initialized.
11b61122
PE
9076 (find_automatic_composition): Mark vars as initialized,
9077 with a FIXME (Bug#8290).
8f5201ae 9078
760fbc2c
PE
9079 character.h: Rename locals to avoid shadowing.
9080 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9081 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9082 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9083 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9084 to avoid shadowing.
9085
ff08eb85
PE
9086 * textprop.c (property_change_between_p): Remove; unused.
9087
fc7bf025
PE
9088 * intervals.c (interval_start_pos): Now static.
9089
235d7abc
PE
9090 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9091
44f230aa
SM
9092 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9093 Rename locals to avoid shadowing.
3e7d6594 9094
50060332
PE
9095 * sound.c (wav_play, au_play, Fplay_sound_internal):
9096 Fix pointer signedness.
d01f234b 9097 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9098 (wav_play): Initialize a variable to 0, to prevent undefined
9099 behavior (Bug#8278).
50060332 9100
c4fc4e30
PE
9101 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9102
918436ed
PE
9103 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9104
c939f91b
PE
9105 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9106 clobbering (Bug#8298).
b9c7f648
PE
9107 * sysdep.c (sys_subshell): Likewise.
9108 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9109
6bd8c144
PE
9110 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9111 This should get cleaned up, so that child_setup has the
9112 same signature on all platforms.
9113
7710357c 9114 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9115 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9116
c59da222
CY
91172011-03-22 Chong Yidong <cyd@stupidchicken.com>
9118
9119 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9120 not to be necessary, and produces flickering.
9121
66b87493
GM
91222011-03-20 Glenn Morris <rgm@gnu.org>
9123
9124 * config.in: Remove file.
9125
45b6f6d5
JB
91262011-03-20 Juanma Barranquero <lekktu@gmail.com>
9127
9128 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9129 are now in src/globals.h.
9130 (syms_of_minibuf): Remove spurious & from previous change.
9131
cd394be1 91322011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9133
9134 * minibuf.c (completing-read-function): New variable.
9135 (completing-read-default): Rename from completing-read.
9136 (completing-read): Call completing-read-function.
9137
b14e3e21
CY
91382011-03-19 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * xfaces.c (Fx_load_color_file):
9141 Read color file from absolute filename (bug#8250).
9142
f2b726e6
JB
91432011-03-19 Juanma Barranquero <lekktu@gmail.com>
9144
9145 * makefile.w32-in: Update dependencies.
9146
09f6ff02
EZ
91472011-03-17 Eli Zaretskii <eliz@gnu.org>
9148
9149 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9150
29a6015a
PE
91512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9152
a3a6c54e
PE
9153 Fix more problems found by GCC 4.5.2's static checks.
9154
b766f867
PE
9155 * process.c (make_serial_process_unwind, send_process_trap):
9156 (sigchld_handler): Now static.
9157
be02381c
PE
9158 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9159 That way, the code declares only the vars that it needs.
9160 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9161 * s/cygwin.h (PTY_ITERATION): Likewise.
9162 * s/darwin.h (PTY_ITERATION): Likewise.
9163 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9164
57048744
PE
9165 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9166 * process.c (allocate_pty): Don't declare stb unless it's needed.
9167
7914961c 9168 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9169 (CONSTANTLIM): Remove; unused.
9170 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9171 Define only if needed.
7914961c 9172
b3967b18
PE
9173 * unexelf.c (unexec): Name an expression,
9174 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9175 Use a different way to cause a compilation error if anyone uses
9176 n rather than nn, a way that does not involve shadowing.
73366a00 9177 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9178
29a6015a
PE
9179 * deps.mk (unexalpha.o): Remove; unused.
9180
43cfc33e 9181 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9182 * unexec.h: New file.
ce701a33
PE
9183 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9184 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9185 Depend on unexec.h.
9186 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9187 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9188 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9189 Change as necessary to match prototype in unexec.h.
ce701a33 9190
01f44d5a
PE
9191 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9192 shadowing.
4f63c6bb 9193 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9194
a6670b0b
PE
9195 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9196 Rename locals to avoid shadowing.
9197
cef2010d 9198 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9199 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9200
d4d7173a
PE
9201 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9202
f08b802a
PE
9203 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9204 warning when compiling print.c.
9205
3ddb0639
PE
9206 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9207 instead of using an uninitialized var.
5ad03b97 9208 (font_sort_entities): Mark var as initialized.
3ddb0639 9209
170a2692
PE
9210 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9211
e663c700
PE
9212 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9213 pointers to constants.
89bc529a 9214 (font_parse_fcname): Remove unused vars.
7b81e2d0 9215 (font_delete_unmatched): Now static.
ea838e10 9216 (font_get_spec): Remove; unused.
13a547c6
PE
9217 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9218 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9219 Rename or move locals to avoid shadowing.
e663c700 9220
2a80c887 9221 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9222 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9223
1384fa33 9224 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9225 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9226
8b2c52e9
PE
9227 * alloc.c (mark_backtrace): Move decl from here ...
9228 * lisp.h: ... to here, so that it can be checked.
9229
475545b5 9230 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9231 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9232 (lisp_indirect_variable): Name an expression,
9233 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9234 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9235
b1349114 9236 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9237 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9238 Use const pointer when appropriate.
b1349114 9239
a2928364
PE
9240 * lisp.h (get_system_name, get_operating_system_release):
9241 Move decls here, to check interfaces.
9242 * process.c (get_operating_system_release): Move decl to lisp.h.
9243 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9244 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9245 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9246 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9247 (Fformat_time_string, Fencode_time, Finsert_char):
9248 (Ftranslate_region_internal, Fformat):
9249 Rename or remove local vars to avoid shadowing.
9710023e 9250 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9251
a415e694
PE
9252 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9253 avoid shadowing.
9254
8ef4622d
PE
9255 * lisp.h (eassert): Check that the argument compiles, even if
9256 ENABLE_CHECKING is not defined.
9257
946f9a5b
PE
9258 * data.c (Findirect_variable): Name an expression, to avoid
9259 gcc -Wbad-function-cast warning.
112396d6 9260 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9261 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9262 (Fmake_variable_buffer_local, Fmake_local_variable):
9263 Mark variables as initialized.
52746918 9264 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9265
e5aab7e7 9266 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9267 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9268 Rename locals to avoid shadowing.
dff45157
PE
9269 (mark_stack): Move local variables into the #ifdef region where
9270 they're used.
7bc26fdb
PE
9271 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9272 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9273 needed otherwise.
9274 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9275 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9276 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9277
e5aab7e7
PE
9278 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9279 avoids undefined behavior in theory.
9280
4da60324
PE
9281 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9282
88043301
PE
9283 Use functions, not macros, for up- and down-casing (Bug#8254).
9284 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9285 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9286 to use the following functions instead of these macros.
9287 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9288 EMACS_INT, since callers assume the returned value fits in int.
9289 (upcase1): Likewise, for UPCASE_TABLE.
9290 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9291 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9292 the race-condition problem in the old DOWNCASE.
88043301 9293
19ed5445
PE
9294 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9295 Rename locals to avoid shadowing.
9296 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9297 (regex_compile, re_search_2, re_match_2_internal):
9298 Remove unused local vars.
952db0d7
PE
9299 (FREE_VAR): Rewrite so as not to use empty "else",
9300 which gcc can warn about.
da053e48 9301 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9302 (RETALLOC_IF): Define only if needed.
9303 (WORDCHAR_P): Likewise. This one is never needed, but is used
9304 only in a comment talking about a compiler bug, so put inside
9305 the #if 0 of that comment.
9306 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9307 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9308 Remove; unused.
19ed5445 9309
1f3561e4 9310 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9311 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9312 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9313
ded6f8f7
PE
9314 * search.c (simple_search): Remove unused var.
9315
dbd37a95
PE
9316 * dired.c (compile_pattern): Move decl from here ...
9317 * lisp.h: ... to here, so that it can be checked.
9318 (struct re_registers): New forward decl.
9319
7e47afad
PE
9320 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9321
85f24f61
PE
9322 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9323 All uses changed.
9324 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9325 Rename locals to avoid shadowing.
5671df8f 9326 (Fvertical_motion): Mark locals as initialized.
85f24f61 9327
181aa2be 9328 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9329 (casify_region): Mark local as initialized.
181aa2be 9330
930d429c
PE
9331 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9332
7082eac6
PE
9333 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9334 New macros, so that the caller can use some names other than
9335 gcpro1, gcpro2, etc.
9336 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9337 of the new macros.
9338 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9339 argument, for consistency with GCPRO2_VAR, etc: it is now the
9340 prefix of the variable, not the variable itself. All uses
9341 changed.
38b2c076
PE
9342 * dired.c (directory_files_internal, file_name_completion):
9343 Rename locals to avoid shadowing.
9344
15206ed9
PE
9345 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9346 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9347 dired.c's scmp function, had undefined behavior.
9348 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9349 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9350 * buffer.h: ... to here, because these macros use current_buffer,
9351 and the new implementation with inline functions needs to have
9352 current_buffer in scope now, rather than later when the macros
9353 are used.
9354 (downcase, upcase1): New static inline functions.
9355 (DOWNCASE, UPCASE1): Reimplement using these functions.
9356 This avoids undefined behavior in expressions like
9357 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9358 from race conditions in accessing the global variables
9359 case_temp1 and case_temp2.
9360 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9361 * lisp.h (case_temp1, case_temp2): Remove their decls.
9362 * character.h (ASCII_CHAR_P): Move from here ...
9363 * lisp.h: ... to here, so that the inline functions mentioned
9364 above can use them.
9365
4a6bea26
PE
9366 * dired.c (directory_files_internal_unwind): Now static.
9367
f14b7e14
PE
9368 * fileio.c (file_name_as_directory, directory_file_name):
9369 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9370 Now static.
2893f146
PE
9371 (file_name_as_directory): Use const pointers when appropriate.
9372 (Fexpand_file_name): Likewise. In particular, newdir might
9373 point at constant storage, so make it a const pointer.
fd4ead52 9374 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9375 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9376 signedness issues.
f839df0c
PE
9377 (Fset_file_times, Finsert_file_contents, auto_save_error):
9378 Rename locals to avoid shadowing.
f14b7e14 9379
5716756e 9380 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9381 (Ftry_completion, Fall_completions): Rename or remove locals
9382 to avoid shadowing.
5716756e 9383
b4c3046a
PE
9384 * marker.c (bytepos_to_charpos): Remove; unused.
9385
b45db522
PE
9386 * lisp.h (verify_bytepos, count_markers): New decls,
9387 so that gcc does not warn that these functions aren't declared.
9388
85876d07
PE
9389 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9390 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9391 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9392 (copy_text): Remove unused local var.
85876d07 9393
03d78a21 9394 * filelock.c (within_one_second): Now static.
b3dd38ab 9395 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9396
5df8f01b
PE
9397 * buffer.c (fix_overlays_before): Mark locals as initialized.
9398 (fix_start_end_in_overlays): Likewise. This function should be
9399 simplified by using pointers-to-pointers, but that's a different
9400 matter.
b1d876f1 9401 (switch_to_buffer_1): Now static.
8f54f30a
PE
9402 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9403 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9404
a70072c9 9405 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9406 Fix pointer signedness issue.
edced198
PE
9407 (sys_subshell): Mark local as volatile if checking for lint,
9408 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9409 (MAXPATHLEN): Define only if needed.
a70072c9 9410
a0977c44
PE
9411 * process.c (serial_open, serial_configure): Move decls from here ...
9412 * systty.h: ... to here, so that they can be checked.
9413
a884fdcc
PE
9414 * fns.c (get_random, seed_random): Move extern decls from here ...
9415 * lisp.h: ... to here, so that they can be checked.
9416
604efe86 9417 * sysdep.c (reset_io): Now static.
b8950c94 9418 (wait_for_termination_signal): Remove; unused.
604efe86 9419
38fc62d9
PE
9420 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9421 (copy_keymap_item, append_key, push_text_char_description):
9422 Now static.
1004a21a 9423 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9424 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9425 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9426 (describe_map_tree):
9427 Rename locals to avoid shadowing.
38fc62d9 9428
2f2650da
PE
9429 * keyboard.c: Declare functions static if they are not used elsewhere.
9430 (echo_char, echo_dash, cmd_error, top_level_2):
9431 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9432 (read_char, kbd_buffer_get_event, make_lispy_position):
9433 (make_lispy_event, make_lispy_movement, apply_modifiers):
9434 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9435 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9436 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9437 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9438 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9439
a053e86c 9440 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9441 (mark_kboards): Move decl here ...
9442 * alloc.c (mark_kboards): ... from here.
a053e86c 9443
4752793e
PE
9444 * lisp.h (force_auto_save_soon): New decl.
9445
74f10ca7 9446 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9447 (DEFINE_DUMMY_FUNCTION): New macro.
9448 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9449 Use it.
c03cd23f
PE
9450 (main): Add casts to avoid warnings
9451 if GCC considers string literals to be constants.
74f10ca7 9452
022e70d4
PE
9453 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9454
59d6fe83
PE
9455 * dbusbind.c: Pointer signedness fixes.
9456 (xd_signature, xd_append_arg, xd_initialize):
9457 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9458 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9459 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9460 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9461
78320123
PE
9462 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9463 if GCC considers string literals to be constants.
49cebcca 9464 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9465
35ac2a97
SM
94662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9467
fb103ca9
SM
9468 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9469 (print_preprocess, print_object): New macro to fix last change.
9470
35ac2a97
SM
9471 * print.c (print_preprocess): Don't forget font objects.
9472
62973b41
JB
94732011-03-16 Juanma Barranquero <lekktu@gmail.com>
9474
9475 * emacs.c (USAGE3): Doc fixes.
9476
0e48bb22
AS
94772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9478
9479 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9480 structure.
9481
7684e57b
JB
94822011-03-14 Juanma Barranquero <lekktu@gmail.com>
9483
9484 * lisp.h (VWindow_system, Qfile_name_history):
9485 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9486 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9487 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9488
9489 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9490 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9491
9492 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9493 * w32console.c (detect_input_pending, read_input_pending)
9494 (encode_terminal_code):
9495 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9496 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9497 (w32_system_caret_y, Qfile_name_history):
9498 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9499 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9500 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9501 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9502 * w32proc.c (Qlocal, report_file_error):
9503 * w32term.c (Vwindow_system, updating_frame):
9504 * w32uniscribe.c (initialized, uniscribe_font_driver):
9505 Remove unneeded extern declarations.
9506
2aa46d6c
CY
95072011-03-14 Chong Yidong <cyd@stupidchicken.com>
9508
c96bbc66 9509 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9510
cffc6f3b
CY
95112011-03-13 Chong Yidong <cyd@stupidchicken.com>
9512
9513 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9514 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9515 These macros can no longer be used for assignment.
9516
44f230aa
SM
9517 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9518 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9519 (record_buffer_markers, fetch_buffer_markers): New functions for
9520 recording and fetching special buffer markers.
9521 (set_buffer_internal_1, set_buffer_temp): Use them.
9522
9523 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9524
9525 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9526
9527 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9528 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9529
9530 * xdisp.c (hscroll_window_tree):
9531 (reconsider_clip_changes): Use PT instead of BUF_PT.
9532
d251f04b
EZ
95332011-03-13 Eli Zaretskii <eliz@gnu.org>
9534
9535 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9536 $(EMACS_ROOT)/lib/intprops.h.
9537
f0c77cd1
PE
95382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9539
3eca4629
PE
9540 Fix more problems found by GCC 4.5.2's static checks.
9541
7c86ee98
PE
9542 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9543 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9544 (xg_free_frame_widgets): Make it clear that a local variable is
9545 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9546 (gdk_window_get_screen): Make it clear that this macro is needed
9547 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9548 (int_gtk_range_get_value): New function, which avoids a diagnostic
9549 from gcc -Wbad-function-cast.
9550 (xg_set_toolkit_scroll_bar_thumb): Use it.
9551 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9552 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9553 (get_utf8_string, xg_get_file_with_chooser):
9554 Rename locals to avoid shadowing.
9555 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9556
41729b81
PE
9557 * xgselect.c (xg_select): Remove unused var.
9558
f0c77cd1
PE
9559 * image.c (four_corners_best): Mark locals as initialized.
9560 (gif_load): Initialize transparent_p to zero (Bug#8238).
9561 Mark another local as initialized.
ec6cf4c6 9562 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9563
ce0ad53d 9564 * image.c (clear_image_cache): Now static.
d5d5a617 9565 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9566 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9567 (x_edge_detection): Remove unnecessary cast that
9568 gcc -Wbad-function-cast diagnoses.
2037898d 9569 (gif_load): Fix pointer signedness.
6ae141d6
PE
9570 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9571 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9572
33383987 95732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9574
d32df629
PE
9575 Improve quality of tests for time stamp overflow.
9576 For example, without this patch (encode-time 0 0 0 1 1
9577 1152921504606846976) returns the obviously-bogus value (-948597
9578 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9579 reports time overflow. See
9580 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9581 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9582 * editfns.c: Include limits.h and intprops.h.
9583 (TIME_T_MIN, TIME_T_MAX): New macros.
9584 (time_overflow): Move earlier, to before first use.
9585 (hi_time, lo_time): New functions, for an accurate test for
9586 out-of-range times.
9587 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9588 (Fget_internal_run_time): Don't assume time_t fits in int.
9589 (make_time): Use list2 instead of Fcons twice.
9590 (Fdecode_time): More accurate test for out-of-range times.
9591 (check_tm_member): New function.
9592 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9593 (lisp_time_argument): Don't rely on undefined left-shift and
9594 right-shift behavior when checking for time stamp overflow.
8be6f318 9595
fe31d94c
PE
9596 * editfns.c (time_overflow): New function, refactoring common code.
9597 (Fformat_time_string, Fdecode_time, Fencode_time):
9598 (Fcurrent_time_string): Use it.
9599
8be6f318
PE
9600 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9601 * dired.c (make_time): Move to ...
9602 * editfns.c (make_time): ... here.
9603 * systime.h: Note the move.
9604
09d9db2c 96052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9606
126bc0dc
YM
9607 * fringe.c (update_window_fringes): Remove unused variables.
9608
c47cbdfd
YM
9609 * unexmacosx.c (copy_data_segment): Also copy __got section.
9610 (Bug#8223)
9611
7ac80be9
EZ
96122011-03-12 Eli Zaretskii <eliz@gnu.org>
9613
c96bbc66 9614 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9615 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9616 Constify `char *' arguments and their references according to
9617 prototypes in tparam.h.
9618
ecb0f94d 9619 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9620
7ac80be9
EZ
9621 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9622 Adapt all references accordingly.
9623
9624 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9625
ef1fd07e
TT
96262011-03-11 Tom Tromey <tromey@redhat.com>
9627
9628 * buffer.c (syms_of_buffer): Remove obsolete comment.
9629
7ef4b50c
EZ
96302011-03-11 Eli Zaretskii <eliz@gnu.org>
9631
9632 * termhooks.h (encode_terminal_code): Declare prototype.
9633
9634 * msdos.c (encode_terminal_code): Don't declare prototype.
9635
9636 * term.c (encode_terminal_code): Now external again, used by
9637 w32console.c and msdos.c.
9638
44f230aa
SM
9639 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9640 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9641
4b1ec863 96422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9643
1714f52b 9644 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9645
4b1ec863
PE
9646 * fringe.c (update_window_fringes): Mark locals as initialized
9647 (Bug#8227).
9648 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9649
524c7aa6
PE
9650 * alloc.c (mark_fringe_data): Move decl from here ...
9651 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9652 to check its interface.
9653 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9654
a5c0af81 9655 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9656 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9657 (fontset_font): Mark local as initialized.
a9a06e0b 9658 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9659
b4716021
PE
9660 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9661
811e9bac 9662 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9663 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9664 (x_own_selection, Fx_disown_selection_internal): Rename locals
9665 to avoid shadowing.
9666 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9667
7e3ab302
PE
9668 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9669 so that the caller can use some name other than gcpro1.
9670 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9671 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9672 (Fx_backspace_delete_keys_p):
9673 Use them to avoid shadowing, and rename vars to avoid shadowing.
9674 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9675 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9676 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9677 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9678 Remove unused locals.
7e3ab302
PE
9679 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9680 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9681 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9682 macros.
f78faa98 9683
e2b13473
PE
9684 * xterm.h (x_mouse_leave): New decl.
9685
77f23912
PE
9686 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9687 Remove unused functions.
cdf4ba58
PE
9688 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9689 (x_calc_absolute_position): Now static.
7411c686 9690 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9691 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9692 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9693 unless they are used.
38d0b34a
PE
9694 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9695 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9696 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9697 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9698 (x_error_catcher, x_connection_closed, x_error_handler):
9699 (x_error_quitter, xembed_send_message, x_iconify_frame):
9700 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9701 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9702 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9703
44f230aa
SM
9704 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9705 Rename or move locals to avoid shadowing.
6b463e58 9706 (tty_defined_color, merge_face_heights): Now static.
5967d051 9707 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9708 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9709 does not deduce is never used uninitialized.
73719eba
PE
9710 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9711 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9712
426994c3 9713 * terminal.c (store_terminal_param): Now static.
5489860b 9714
032f1620 9715 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9716 (set_frame_menubar): Remove unused local.
d4323972 9717 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9718 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9719 since they might point to immutable storage.
281585b0
PE
9720 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9721 since it's unused otherwise.
032f1620 9722
367c19e5 9723 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9724 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9725 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9726 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9727 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9728 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9729 does not deduce are never used uninitialized.
70739cbe 9730
07b48fa9
PE
9731 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9732
8868a238 9733 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9734 * window.c (window_loop, size_window):
9735 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9736
7e5cf297 9737 * window.c (display_buffer): Now static.
d6550a9f
PE
9738 (size_window): Mark variables that gcc -Wuninitialized
9739 does not deduce are never used uninitialized.
a586633d
PE
9740 * window.h (check_all_windows): New decl, to forestall
9741 gcc -Wmissing-prototypes diagnostic.
5b555da1 9742 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9743
f6095868
PE
9744 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9745 shadowing.
9746 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9747 Include <limits.h>.
9748 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9749 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9750 (load_charset_map): Mark variables that gcc -Wuninitialized
9751 does not deduce are never used uninitialized.
53df7c11 9752 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9753
f38b440c
PE
9754 * coding.c (coding_set_source, coding_set_destination):
9755 Use "else { /* comment */ }" rather than "else /* comment */;"
9756 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9757 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9758 a block, when the outer 'i' will do.
9759 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9760 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9761 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9762 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9763 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9764 Rename locals to avoid shadowing.
9765 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9766 * coding.c (emacs_mule_char, encode_invocation_designation):
9767 Now static, since they're not used elsewhere.
413bb2db 9768 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9769 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9770 (decode_coding_emacs_mule): Mark variables that gcc
9771 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9772 (detect_coding_iso_2022): Initialize a local variable that might
9773 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9774 this initialization is needed. (Bug#8211)
5f58e762
PE
9775 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9776 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9777 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9778 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9779 Remove unused macros.
f38b440c 9780
232b38b9 9781 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9782 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9783 * character.c (string_count_byte8): Likewise.
232b38b9 9784
fb90da1b
PE
9785 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9786 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9787
fb93dbc2
PE
9788 * chartab.c (copy_sub_char_table): Now static, since it's not used
9789 elsewhere.
5c156ace
PE
9790 (sub_char_table_ref_and_range, char_table_ref_and_range):
9791 Rename locals to avoid shadowing.
bbcd0949 9792 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9793
7d3b3862 9794 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9795 (BIDI_BOB): Remove unused macro.
7d3b3862 9796
6be7d3da
PE
9797 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9798 deduce are never used uninitialized.
c2ed9c8b 9799 * term.c (encode_terminal_code): Likewise.
6be7d3da 9800
75f8807f 9801 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9802
50938595
PE
9803 * tparam.h: New file.
9804 * term.c, tparam.h: Include it.
9805 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9806 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9807 Move these decls to tparam.h, and make them agree with what
9808 is actually in tparam.c. The previous trick of using incompatible
9809 decls in different modules does not conform to the C standard.
9810 All callers of tparam changed to use tparam's actual API.
9811 * tparam.c (tparam1, tparam, tgoto):
9812 Use const pointers where appropriate.
9813
fbceeba2
PE
9814 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9815 * cm.h (struct cm): Likewise.
9816 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9817 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9818 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9819 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9820 (turn_on_face, init_tty): Likewise.
9821 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9822
7f3f1250
PE
9823 * term.c (term_mouse_position): Rename local to avoid shadowing.
9824
e6ca6543
PE
9825 * alloc.c (mark_ttys): Move decl from here ...
9826 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9827
c40f8d15
AS
98282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9829
9830 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9831
cfe0661d
JB
98322011-03-09 Juanma Barranquero <lekktu@gmail.com>
9833
9834 * search.c (compile_pattern_1): Remove argument regp, unused since
9835 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9836 (compile_pattern): Don't pass it.
9837
0afb4571
J
98382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9839
9840 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9841 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9842 for ! HAVE_GTK3.
9843 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9844
9845 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9846
9847 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9848 gdk_window_get_screen, gdk_window_get_geometry,
9849 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9850 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9851 (xg_get_pixbuf_from_pixmap): New function.
9852 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9853 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9854 Call xg_get_pixbuf_from_pixmap instead of
9855 gdk_pixbuf_get_from_drawable.
9856 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9857 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9858 (xg_check_special_colors): Use GtkStyleContext and its functions
9859 for HAVE_GTK3.
9860 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9861 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9862 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9863 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9864 Call gtk_widget_get_preferred_size.
0afb4571
J
9865 (xg_frame_resized): gdk_window_get_geometry only takes 5
9866 parameters.
44f230aa
SM
9867 (xg_win_to_widget, xg_event_is_for_menubar):
9868 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9869 (xg_set_widget_bg): New function.
9870 (delete_cb): New function.
895009e1 9871 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9872 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9873 (xg_set_background_color): Call xg_set_widget_bg.
9874 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9875 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9876 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9877 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9878 if ! HAVE_GTK3.
9879 (update_frame_tool_bar): Call gtk_widget_hide.
9880 (xg_initialize): Use GDK_KEY_g.
9881
9882 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9883 if ! HAVE_GTK3
9884 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9885
9886 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9887 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9888 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9889
1c2cc4ef
JB
98902011-03-08 Juanma Barranquero <lekktu@gmail.com>
9891
9892 * w32xfns.c (select_palette): Check success of RealizePalette against
9893 GDI_ERROR, not zero.
9894
33383987 9895See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9896
9897;; Local Variables:
9898;; coding: utf-8
aac0c6e3
MR
9899;; End:
9900
acaf905b 9901 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9902
9903 This file is part of GNU Emacs.
9904
9905 GNU Emacs is free software: you can redistribute it and/or modify
9906 it under the terms of the GNU General Public License as published by
9907 the Free Software Foundation, either version 3 of the License, or
9908 (at your option) any later version.
9909
9910 GNU Emacs is distributed in the hope that it will be useful,
9911 but WITHOUT ANY WARRANTY; without even the implied warranty of
9912 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9913 GNU General Public License for more details.
9914
9915 You should have received a copy of the GNU General Public License
9916 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.