* nsterm.m (constrainFrameRect): Always constrain when there is only
[bpt/emacs.git] / src / ChangeLog
CommitLineData
aff67c82
JD
12012-04-09 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (constrainFrameRect): Always constrain when there is only
4 one screen (Bug#10962).
5
2f8e16b2
EZ
62012-04-06 Eli Zaretskii <eliz@gnu.org>
7
8 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
9 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
10 about subtle differences between FETCH_CHAR* and STRING_CHAR*
11 macros related to unification of CJK characters. For the details,
12 see the discussion following the message here:
13 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
14
3d439cd1
CY
152012-04-04 Chong Yidong <cyd@gnu.org>
16
17 * keyboard.c (Vdelayed_warnings_list): Doc fix.
18
8bc53d00
EZ
192012-04-01 Eli Zaretskii <eliz@gnu.org>
20
21 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
22 instead of alloca. (Bug#11138)
23
3b0512a3
AS
242012-04-01 Andreas Schwab <schwab@linux-m68k.org>
25
26 * w32menu.c (is_simple_dialog): Properly check lisp types.
27 (Bug#11141)
28
8427ddd2
EZ
292012-03-31 Eli Zaretskii <eliz@gnu.org>
30
979022ef
EZ
31 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
32 position we get to after a call to move_it_to fails the
33 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
34 only if we wind up in a string from display property. (Bug#11063)
35
a6b1c7cc
EZ
36 * window.c (Fdelete_other_windows_internal): Invalidate the row
37 and column information about mouse highlight, so that redisplay
38 restores it after reallocating the glyph matrices. (Bug#7464)
39
8427ddd2
EZ
40 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
41 string comes from a `display' text property, use the buffer
42 position of that property as if we actually saw that position in
43 the row's glyphs.
697ba24b
EZ
44 (move_it_by_lines): Remove the assertion that
45 "it->current_x == 0 && it->hpos == 0" which can be legitimately
46 violated when there's a before-string at the beginning of a line.
47 (Bug#11063)
8427ddd2 48
65a0a738
EZ
492012-03-30 Eli Zaretskii <eliz@gnu.org>
50
51 * xdisp.c (append_space_for_newline): If the default face was
52 remapped, use the remapped face for the appended newline.
53 (extend_face_to_end_of_line): Use the remapped default face for
54 extending the face to the end of the line.
55 (display_line): Call extend_face_to_end_of_line when the default
56 face was remapped. (Bug#11068)
57
581355cc
EZ
582012-03-29 Eli Zaretskii <eliz@gnu.org>
59
60 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
61
e8fc049f
SM
622012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
63
64 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
65
4fb9a543
GM
662012-03-27 Glenn Morris <rgm@gnu.org>
67
68 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
69 Doc fixes.
70
679910f1
KH
712012-03-26 Kenichi Handa <handa@m17n.org>
72
73 * dispextern.h (struct glyph): Fix previous change. Change the
74 bit length of glyphless.ch to 25 (Bug#11082).
75
90d49b7f
CY
762012-03-26 Chong Yidong <cyd@gnu.org>
77
78 * keyboard.c (Vselection_inhibit_update_commands): New variable.
79 (command_loop_1): Use it; inhibit selection update for
80 handle-select-window too (Bug#8996).
81
f514f6f0
FP
822012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
83
e8fc049f 84 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 85
bf43fa51
KH
862012-03-25 Kenichi Handa <handa@m17n.org>
87
88 * dispextern.h (struct glyph): Change the bit length of
89 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
90
8a0c01dd
EZ
912012-03-24 Eli Zaretskii <eliz@gnu.org>
92
93 * s/ms-w32.h (tzname): Include time.h before redirecting to
94 _tzname. Fixes the MSVC build. (Bug#9960)
95
7d1c3a76
AS
962012-03-24 Andreas Schwab <schwab@linux-m68k.org>
97
8ed79523
AS
98 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
99 characters.
100
7d1c3a76
AS
101 * xterm.c (XTread_socket): Only modify handling_signal if
102 !SYNC_INPUT. (Bug#11080)
103
e99a9b8b
EZ
1042012-03-23 Eli Zaretskii <eliz@gnu.org>
105
106 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
107 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
108 when fetching a multibyte character consumes more bytes than
109 CHAR_BYTES returns, due to unification of CJK characters in
110 string_char. (Bug#11073)
111
5063c0e1
TN
1122012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
113
114 * process.c (wait_reading_process_output): Handle pty disconnect
115 by refraining from sending oneself a SIGCHLD (bug#10933).
116
9f851fbd
CY
1172012-03-22 Chong Yidong <cyd@gnu.org>
118
119 * dispextern.h (struct it): New member string_from_prefix_prop_p.
120
5063c0e1 121 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
122 Mark string as coming from a prefix property.
123 (handle_face_prop): Use default face for prefix strings (Bug#4281).
124 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
125
fb5b8aca
CY
1262012-03-21 Chong Yidong <cyd@gnu.org>
127
128 * xfaces.c (Vface_remapping_alist): Doc fix.
129
62356a1b
EZ
1302012-03-20 Eli Zaretskii <eliz@gnu.org>
131
132 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
133 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
134 Doc fixes.
62356a1b 135
025de85b
CY
1362012-03-20 Chong Yidong <cyd@gnu.org>
137
138 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
139 to reflect default non-nil value of redisplay-dont-pause.
140
4827f94e
KH
1412012-03-19 Kenichi Handa <handa@m17n.org>
142
143 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
144 it fit in a valid range (Bug#11003).
145
e50a24a2
EZ
1462012-03-18 Eli Zaretskii <eliz@gnu.org>
147
148 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
149 that is not from display property, accept the row as a "cursor
150 row" if one of the string's character has a non-nil `cursor'
151 property. Fixes cursor positioning when there are newlines in
152 overlay strings, e.g. in icomplete.el. (Bug#11035)
153
9af5ed87
PE
1542012-03-12 Paul Eggert <eggert@cs.ucla.edu>
155
156 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
157
d1f55f16
CY
1582012-03-12 Chong Yidong <cyd@gnu.org>
159
160 * eval.c (inhibit_lisp_code): Rename from
161 inhibit_window_configuration_change_hook; move from window.c.
162
163 * xfns.c (unwind_create_frame_1, Fx_create_frame):
164 * window.c (run_window_configuration_change_hook)
165 (syms_of_window): Callers changed.
166
66c5eebd
CY
1672012-03-11 Chong Yidong <cyd@gnu.org>
168
413df973
CY
169 * keymap.c (Fkey_description): Doc fix (Bug#9700).
170
66c5eebd
CY
171 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
172
1de11f56
CY
1732012-03-10 Chong Yidong <cyd@gnu.org>
174
175 * frame.c (other_visible_frames): Don't assume the selected frame
176 is visible (Bug#10955).
177
cae07000
SM
1782012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
179
180 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
181
89c94350
JD
1822012-03-08 Jan Djärv <jan.h.d@swipnet.se>
183
184 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
185 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
186 zero (Bug#10954).
187
999dd333
GM
1882012-03-03 Glenn Morris <rgm@gnu.org>
189
01a6dcc8 190 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 191
de0100f2
EZ
1922012-03-02 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
195 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
196 (redisplay_window, next_element_from_string): Fix typos in
197 comments.
3e441275
EZ
198 (redisplay_window): Pass to move_it_vertically the margin in
199 pixels, not in screen lines.
de0100f2 200
96a72ee9
GM
2012012-03-02 Glenn Morris <rgm@gnu.org>
202
203 * buffer.c (buffer-list-update-hook): Doc fix.
204
312508d7
EZ
2052012-02-29 Eli Zaretskii <eliz@gnu.org>
206
207 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
208 push_it before setting up the iterator for the first overlay
209 string, even if we have an empty string loaded.
210 (next_overlay_string): If there's an empty string on the iterator
211 stack, pop the stack. (Bug#10903)
212
27f3c637
PE
2132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
214
215 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
216 Suggested by Stefan Monnier in
217 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
218 * alloc.c (widen_to_Lisp_Object): New static function.
219 (mark_memory): Also mark Lisp_Objects by fetching pointer words
220 and widening them to Lisp_Objects. This would work even if
221 USE_LSB_TAG is defined and wide integers are used, which might
222 happen in a future version of Emacs.
223
3c9dfce6
CY
2242012-02-25 Chong Yidong <cyd@gnu.org>
225
fa74b241
CY
226 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
227 Doc fix.
228
3c9dfce6
CY
229 * xselect.c (Fx_selection_exists_p): Doc fix.
230 (x_clipboard_manager_save_all): Print an informative message
231 before saving to clipboard manager.
232
9486df08
CY
2332012-02-24 Chong Yidong <cyd@gnu.org>
234
235 * keyboard.c (process_special_events): Handle all X selection
236 requests in kbd_buffer, not just the next one (Bug#8869).
237
f01d3321
CY
2382012-02-23 Chong Yidong <cyd@gnu.org>
239
240 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
241 call when setting menu-bar-lines and tool-bar-lines parameters.
242 (unwind_create_frame_1): New helper function.
243
244 * window.c (inhibit_window_configuration_change_hook): New var.
245 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 246 (syms_of_window): Initialize it.
f01d3321 247
86b847b6
CY
2482012-02-22 Chong Yidong <cyd@gnu.org>
249
250 * xterm.c (x_draw_image_relief): Add missing type check for
251 Vtool_bar_button_margin (Bug#10743).
252
a59225b1
CY
2532012-02-21 Chong Yidong <cyd@gnu.org>
254
255 * fileio.c (Vfile_name_handler_alist): Doc fix.
256
257 * buffer.c (Fget_file_buffer): Protect against invalid file
258 handler return value.
259
310f5bd4
PE
2602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
261
cb3a28cc
PE
262 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
263 when computing $valmask.
264
310f5bd4
PE
265 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
266 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
267 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
268 It's useless in that case, and it can cause problems on hosts
269 that allocate halves of EMACS_INT values separately.
270 Reported by Dan Horák. Diagnosed by Andreas Schwab in
271 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
272 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
273 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
274 it avoids undefined behavior on hosts where shifting right by more
275 than the word width has undefined behavior.
276
2375c96a
CY
2772012-02-19 Chong Yidong <cyd@gnu.org>
278
279 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
280 (Funhandled_file_name_directory, Ffile_name_as_directory)
281 (Fdirectory_file_name, Fexpand_file_name)
282 (Fsubstitute_in_file_name): Protect against invalid file handler
283 return values (Bug#10845).
284
3eb49e71
EZ
2852012-02-18 Eli Zaretskii <eliz@gnu.org>
286
287 * .gdbinit (pitx): Fix incorrect references to fields of the
288 iterator stack.
289
7b926f3f
CY
2902012-02-17 Chong Yidong <cyd@gnu.org>
291
292 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
293
11273115
PE
2942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
295
296 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
297 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
298
c3a70e2b
CY
2992012-02-15 Chong Yidong <cyd@gnu.org>
300
301 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
302 marked as special. Also, starting docstrings with * is obsolete.
303
0ca43699
AS
3042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
305
306 * gnutls.c (emacs_gnutls_write): Fix last change.
307
2e8f3c56
LI
3082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
309
310 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
311 send_process.
312
af70074f
SM
3132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
314
315 * keymap.c (Fsingle_key_description): Handle char ranges.
316
95986d52
CY
3172012-02-12 Chong Yidong <cyd@gnu.org>
318
afd83bd1
CY
319 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
320 as that creates a dangerous corner case.
321
95986d52
CY
322 * window.c (Fdelete_window_internal): Invalidate the mouse
323 highlight (Bug#9904).
324
bd7da63e
GM
3252012-02-12 Glenn Morris <rgm@gnu.org>
326
327 * xselect.c (Fx_own_selection_internal)
328 (Fx_get_selection_internal, Fx_disown_selection_internal)
329 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
330 * nsselect.m (Fx_own_selection_internal)
331 (Fx_disown_selection_internal, Fx_selection_exists_p)
332 (Fx_selection_owner_p, Fx_get_selection_internal):
333 Sync docs and argument specs with the xselect.c versions.
334
77abcbc2
LI
3352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
336
337 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
338
90b671e2
EZ
3392012-02-11 Eli Zaretskii <eliz@gnu.org>
340
1c0ca0b7
EZ
341 * w32select.c (Fx_selection_exists_p): Sync doc string and
342 argument list with xselect.c. (Bug#10783)
343
344 * w16select.c (Fx_selection_exists_p): Sync doc string and
345 argument list with xselect.c. (Bug#10783)
90b671e2 346
49241268
GM
3472012-02-10 Glenn Morris <rgm@gnu.org>
348
349 * fns.c (Fsecure_hash): Doc fix.
350
f998bbe7 3512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
352
353 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
354
0992bd9c
CY
3552012-02-07 Chong Yidong <cyd@gnu.org>
356
357 * buffer.c (Fbuffer_local_variables)
358 (buffer_lisp_local_variables): Handle unbound vars correctly;
359 don't let Qunbound leak into Lisp.
360
af008560
GM
3612012-02-07 Glenn Morris <rgm@gnu.org>
362
dd605cc4
GM
363 * image.c (Fimagemagick_types): Doc fix.
364
af008560
GM
365 * image.c (imagemagick-render-type): Change it from a lisp object
366 to an integer. Move the doc here from the lisp manual.
367 Treat all values not equal to 0 the same.
368
1449fa1d
CY
3692012-02-06 Chong Yidong <cyd@gnu.org>
370
371 * doc.c (store_function_docstring): Avoid applying docstring of
372 alias to base function (Bug#2603).
373
3723ec07
AS
3742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
375
376 * .gdbinit (pp1, pv1): Remove redundant defines.
377 (pr): Use pp.
378
79c1cc1e
CY
3792012-02-04 Chong Yidong <cyd@gnu.org>
380
381 * nsterm.m: Declare a global (Bug#10694).
382
d7f29f8e
EZ
3832012-02-04 Eli Zaretskii <eliz@gnu.org>
384
cae07000
SM
385 * w32.c (get_emacs_configuration_options):
386 Include --enable-checking, if specified, in the return value.
d7f29f8e 387
3b95a6f9
MR
3882012-02-04 Martin Rudalics <rudalics@gmx.at>
389
390 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
391 after rounding frame sizes. (Bug#9723)
392
d6fa96a6
EZ
3932012-02-04 Eli Zaretskii <eliz@gnu.org>
394
395 * keyboard.c (adjust_point_for_property): Don't position point
396 before BEGV. (Bug#10696)
397
df0b2940
PE
3982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
399
400 Handle overflow when computing char display width (Bug#9496).
401 * character.c (char_width): Return EMACS_INT, not int.
402 (char_width, c_string_width): Check for overflow when
403 computing the width; this is possible now that individual
404 characters can have unbounded width. Problem introduced
405 by merge from Emacs 23 on 2012-01-19.
406
6bee44d6
MA
4072012-02-02 Michael Albinus <michael.albinus@gmx.de>
408
409 * dbusbind.c (Fdbus_register_method): Mention the return value
410 :ignore in the docstring.
411
44f92739
GM
4122012-02-02 Glenn Morris <rgm@gnu.org>
413
1b9f60cc
GM
414 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
415
44f92739
GM
416 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
417 Unconditionally set to t. (Bug#10673)
418 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
419 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
420 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
421
c5d3843c
KH
4222012-02-02 Kenichi Handa <handa@m17n.org>
423
424 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
425 0, do not call append_composite_glyph.
426
159462d4 4272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
428
429 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
430 NULL (Bug#6988).
431 (x_produce_glyphs): If the component of a composition is a null
432 string, set it->pixel_width to 1 to avoid zero-width glyph.
433
78cef877
EZ
4342012-02-01 Eli Zaretskii <eliz@gnu.org>
435
436 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
437 first 2 arguments are identical. This makes inserting large
438 output from a subprocess an order of magnitude faster on
439 MS-Windows, where all sbrk'ed memory is always contiguous.
440
97897668
GM
4412012-01-31 Glenn Morris <rgm@gnu.org>
442
443 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 444 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
445 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
446
31fd3586
GM
4472012-01-29 Glenn Morris <rgm@gnu.org>
448
449 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
450
0e24a8b2
CY
4512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
452
453 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
454
cc0adcb0
CY
4552012-01-28 Chong Yidong <cyd@gnu.org>
456
457 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
458
acc28cb9
CY
4592012-01-26 Chong Yidong <cyd@gnu.org>
460
9c69cfb7
CY
461 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
462
acc28cb9
CY
463 * search.c (Fsearch_forward, Fsearch_backward): Document negative
464 repeat counts (Bug#10507).
465
48da7392
GM
4662012-01-26 Glenn Morris <rgm@gnu.org>
467
468 * lread.c (syms_of_lread): Doc fix.
469
14af5f7f
CY
4702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
471
472 * coding.c (encode_designation_at_bol): Change return value to
473 EMACS_INT.
474
0b21c100
CY
4752012-01-25 Chong Yidong <cyd@gnu.org>
476
477 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
478
3c2907f7
CY
4792012-01-21 Chong Yidong <cyd@gnu.org>
480
481 * floatfns.c (Fcopysign): Make the second argument non-optional,
482 since nil is not allowed anyway.
483
959ad23f
AS
4842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
485
486 * process.c (read_process_output): Use p instead of XPROCESS (proc).
487 (send_process): Likewise.
488
34a02f46
MR
4892012-01-19 Martin Rudalics <rudalics@gmx.at>
490
491 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
492 (Vwindow_persistent_parameters): Do not use Qstate.
493 Rewrite doc-strings.
34a02f46 494
1259009a 4952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
496
497 * character.c (char_width): New function.
70d4fdf6
GM
498 (Fchar_width, c_string_width, lisp_string_width):
499 Use char_width (Bug#9496).
25ed9e61 500
6a6ee00d
MR
5012012-01-16 Martin Rudalics <rudalics@gmx.at>
502
503 * window.c (Vwindow_persistent_parameters): New variable.
504 (Fset_window_configuration, save_window_save): Handle persistent
505 window parameters.
506
c85efaf7
EZ
5072012-01-14 Eli Zaretskii <eliz@gnu.org>
508
509 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
510 thrashing the stack of the thread. (Bug#9087)
511
5944709e
PE
5122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
513
514 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
515
e71f5d99
EZ
5162012-01-11 Eli Zaretskii <eliz@gnu.org>
517
518 * xdisp.c (rows_from_pos_range): Handle the case where the
519 highlight ends on a newline. (Bug#10464)
520 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
521 he end column for display of highlight that ends on a newline
522 before a R2L line.
523
ce316182
GM
5242012-01-11 Glenn Morris <rgm@gnu.org>
525
526 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
527 from load-path also when installation-directory is nil. (Bug#10208)
528
5b43da69
GM
5292012-01-10 Glenn Morris <rgm@gnu.org>
530
74cc8ff9
GM
531 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
532
7d8d6e4e
GM
533 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
534 Update template values to be closer to their typical values these days.
5b43da69 535
a0db8d43
EZ
5362012-01-09 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (rows_from_pos_range): Accept additional argument
539 DISP_STRING, and accept any glyph in a row whose object is that
540 string as eligible for mouse highlight. Fixes mouse highlight of
541 display strings from overlays. (Bug#10464)
542
9a0115ab 5432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 544
b9110d6a 545 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
546 * fileio.c (auto_saving_dir_umask): New static var.
547 (Fmake_directory_internal): Use it.
548 (do_auto_save_make_dir): Set it, instead of invoking chmod after
549 creating the directory. The old code temporarily assigns
550 too-generous permissions to the directory.
551 (do_auto_save_eh): Clear it.
b9110d6a 552 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
553 that the var is always cleared.
554
6c1bd3f3
EZ
5552012-01-07 Eli Zaretskii <eliz@gnu.org>
556
557 * search.c (scan_buffer): Pass character positions to
558 know_region_cache, not byte positions. (Bug#6540)
559
069d2b50
L
5602012-01-07 LynX <_LynX@bk.ru> (tiny change)
561
562 * w32.c (sys_rename): Report EXDEV when rename of a directory
563 fails because the target is on another logical disk. (Bug#10284)
564
75bf0d33
DB
5652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
566
567 * xterm.c (x_embed_request_focus): New function.
568
569 * xterm.h: Add prototype.
570
571 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
572
1c6e5a32
GM
5732012-01-05 Glenn Morris <rgm@gnu.org>
574
575 * emacs.c (emacs_copyright): Update short copyright year to 2012.
576
651e947e
EZ
5772012-01-01 Eli Zaretskii <eliz@gnu.org>
578
579 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
580 Load gnutls_transport_set_lowat only if GnuTLS version is below
581 2.11.1.
582 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
583 GnuTLS versions below 2.11.1.
584
3778cdd8
AL
5852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
586
587 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
588 to the doc string advising against its use for altering the way
589 windows are scrolled.
590
0e5317f7
KH
5912011-12-28 Kenichi Handa <handa@m17n.org>
592
593 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
594 coding-system ASCII compatible only when it does not produce BOM
595 on encoding (Bug#10383).
596
93d5ca1f
JD
5972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
598
599 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
600 can scroll.
601 (create_and_show_popup_menu): Always use menu_position_func for
602 Gtk3 (Bug#10361).
603
ca22b785
AS
6042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
605
606 * callint.c (Fcall_interactively): Don't truncate prompt string.
607
d048e1e6
EZ
6082011-12-23 Eli Zaretskii <eliz@gnu.org>
609
610 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
611 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 612 resumed from there (after widening). (Bug#10360)
d048e1e6 613
5ccaba1f
JD
6142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
615
616 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
617
204ee57f
JD
6182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
619
b81d40f0
JB
620 * nsterm.m (x_free_frame_resources):
621 Release f->output_data.ns->miniimage.
204ee57f
JD
622 (ns_index_color): Fix indentation. Do not retain
623 color_table->colors[i].
624
625 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
626 before returning.
627
628 * nsfns.m (x_set_background_color): Assign return value from
629 ns_index_color to face-background instead of NSColor*.
630 (ns_implicitly_set_icon_type): Fix indentation.
631 Change assignment in for loop to comparison.
632
633 * emacs.c (ns_pool): New variable.
634 (main): Assign ns_pool.
635 (Fkill_emacs): Call ns_release_autorelease_pool.
636
637 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
638 autorelease fdesc, release fdAttrs and tdict.
639 (ns_get_covering_families): Release charset.
640 (ns_findfonts): Release NSFontDescriptor created with new.
641 (ns_uni_to_glyphs): Fix indentation.
642 (setString): Release attrStr before assigning new value.
643
c803b2b7
JD
6442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
645
678f4426
JD
646 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
647 and NS_IMPL_COCOA.
648 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
649 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
650
cd394be1 6512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 652
5fecd5fc
JD
653 * nsterm.m (ns_term_init): Subscribe for notifications
654 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
655 to method trackingNotification in EmacsMenu.
656
657 * nsmenu.m (trackingMenu): New variable.
3771cb17 658 (trackingNotification): New method (from Aquamacs).
5fecd5fc 659 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 660 from Aquamacs (Bug#7030).
678f4426
JD
661
6622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 663
c803b2b7
JD
664 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
665 (symbol_to_nsstring): Fix indentation.
666 (ns_symbol_to_pb): New function.
cae07000
SM
667 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
668 (Fns_rotate_cut_buffers_internal): Remove.
669 (Fns_store_selection_internal): Rename from
c803b2b7
JD
670 Fns_store_cut_buffer_internal.
671 (ns_get_foreign_selection, Fx_own_selection_internal)
672 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
673 (Fns_get_selection_internal, Fns_store_selection_internal):
674 Use ns_symbol_to_pb and check if return value is nil.
675 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
676 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
677 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
678 renamed to Sns_store_selection_internal.
679 (ns_handle_selection_request): Move code to Fx_own_selection_internal
680 and remove this function.
681 (ns_handle_selection_clear): Remove, never used.
682 (Fx_own_selection_internal): Move code from ns_handle_selection_request
683 here.
684
e1b01a3a
KB
6852011-12-17 Ken Brown <kbrown@cornell.edu>
686
687 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
688 GID is unknown (Bug#10257).
689
2adb6e85
PE
6902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
691
692 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
693 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
694 which caused a build failure on GNU/Linux IA-64. This problem was
695 introduced by my 2011-10-07 patch.
696
d1d7b339
JL
6972011-12-15 Juri Linkov <juri@jurta.org>
698
699 * image.c (imagemagick_error): New function. (Bug#10112)
700 (imagemagick_load_image): Comment out `MagickSetResolution' call.
701 Use `imagemagick_error' where ImageMagick functions return
702 `MagickFalse'.
703 (Fimagemagick_types): Add `Fnreverse' to return the list in the
704 proper order.
705
100d5755
KH
7062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
707
708 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
709 fill background (Bug#8992).
710
454592a6
MR
7112011-12-13 Martin Rudalics <rudalics@gmx.at>
712
713 * window.c (Vwindow_combination_resize)
714 (Vwindow_combination_limit): Use t instead of non-nil in
715 doc-strings.
61d4b438
MR
716 (Vrecenter_redisplay): Add first sentence of doc-string on
717 separate line.
53524d93 718 (Frecenter): Fix doc-string typo.
454592a6 719
3633e3aa
KH
7202011-12-11 Kenichi Handa <handa@m17n.org>
721
722 * coding.c (Funencodable_char_position): Pay attention to the
723 buffer text relocation (Bug#9389).
724
7b9d523a
JD
7252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
726
727 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
728 gtk_init (Bug#10100).
729
b73189c6
EZ
7302011-12-10 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
733 IT->string is nil. (Bug#10263)
734
f7dfe5d6
JD
7352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
736
83faebb4
JD
737 * nsterm.h (x_free_frame_resources): Declare.
738
f7dfe5d6
JD
739 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
740 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
741
742 * nsterm.h (ns_get_defaults_value): Declare.
743
744 * nsterm.m (ns_default): Call ns_get_defaults_value.
745
7cd4e72c
EZ
7462011-12-09 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
749 (Bug#10170)
750
b34d7317
YM
7512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
752
753 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
754 that where the value of an _OBJC_* symbol points to is in the .bss
755 section (Bug#10240).
756
76470ad1
KH
7572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
758
759 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 760 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 761
745fff94
KH
7622011-12-08 Kenichi Handa <handa@m17n.org>
763
764 * ftfont.c (get_adstyle_property): Fix previous change
765 (Bug#10233).
766
6e44397c
JB
7672011-12-07 Juanma Barranquero <lekktu@gmail.com>
768
769 * w32.c (init_environment): If no_site_lisp, remove site-lisp
770 dirs from the default value of EMACSLOADPATH (bug#10208).
771
7efa6272
GM
7722011-12-07 Glenn Morris <rgm@gnu.org>
773
774 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
775 installation and source directories as well. (Bug#10208)
776
f6fc4d87
CY
7772011-12-06 Chong Yidong <cyd@gnu.org>
778
779 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
780
2bf26180
GM
7812011-12-06 Glenn Morris <rgm@gnu.org>
782
783 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
784 as an error, not just -1. (Bug#10217)
785
3a6ad4f0
CY
7862011-12-05 Chong Yidong <cyd@gnu.org>
787
788 * keyboard.c (process_special_events): New function.
789 (swallow_events, Finput_pending_p): Use it (Bug#10195).
790
75a3b399
PE
7912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
792
793 * coding.c (encode_designation_at_bol): Don't use uninitialized
794 local variable (Bug#9318).
795
c3c9e25e
KH
7962011-12-05 Kenichi Handa <handa@m17n.org>
797
798 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
799 return Qnil (Bug#8046, Bug#10193).
800
5eb05ea3
KH
8012011-12-05 Kenichi Handa <handa@m17n.org>
802
803 * coding.c (encode_designation_at_bol): New args charbuf_end and
804 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
805 (coding_set_source): Return how many bytes coding->source was
806 relocated.
807 (coding_set_destination): Return how many bytes
808 coding->destination was relocated.
809 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 810 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
811
8122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
813
814 * coding.c (CODING_CHAR_CHARSET_P): New macro.
815 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
816 macro (Bug#9318).
817
8182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
819
820 The following changes are to fix Bug#9318.
821
a79703f5 822 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
823 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
824 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 825 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 826
7dbda6df
JB
8272011-12-05 Juanma Barranquero <lekktu@gmail.com>
828
829 * lisp.h (process_quit_flag): Fix external declaration.
830
6d5eb5b0
SM
8312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
832
833 Don't macro-inline non-performance-critical code.
834 * eval.c (process_quit_flag): New function.
835 * lisp.h (QUIT): Use it.
836
a0c3fad0
JD
8372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
838
839 * nsfns.m (get_geometry_from_preferences): New function.
840 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
841
6c07aac2
AS
8422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
843
844 * emacs.c (Qkill_emacs): Define.
845 (syms_of_emacs): Initialize it.
846 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
847 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
848 (quit_throw_to_read_char): Add parameter `from_signal'.
849 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
850 * lisp.h (QUIT): Call Fkill_emacs if requested.
851
c052ead4
JD
8522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
853
854 * widget.c (update_wm_hints): Return if wmshell is null.
855 (widget_update_wm_size_hints): New function.
856
857 * widget.h (widget_update_wm_size_hints): Declare.
858
859 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
860 widget_update_wm_size_hints (Bug#10104).
861
9e49252b
EZ
8622011-12-03 Eli Zaretskii <eliz@gnu.org>
863
864 * xdisp.c (handle_invisible_prop): If the invisible text ends just
865 before a newline, prepare the bidi iterator for consuming the
866 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 867 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 868
02b16839
JL
8692011-12-02 Juri Linkov <juri@jurta.org>
870
871 * search.c (Fword_search_regexp): New Lisp function created from
872 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
873 (Fword_search_backward, Fword_search_forward)
874 (Fword_search_backward_lax, Fword_search_forward_lax):
875 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
876 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
877
0068070e
SM
8782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
879
880 * fileio.c (Finsert_file_contents): Move after-change-function call
881 to before the "handled:" label, since all "goto handled" appear in
882 cases where the *-change-functions have already been properly called
883 (bug#10117).
884
3360a3fc
AS
8852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
886
887 * keyboard.c (interrupt_signal): Don't call kill-emacs when
888 waiting for input. (Bug#10169)
889
73d6c093
EZ
8902011-11-30 Eli Zaretskii <eliz@gnu.org>
891
892 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
893 verifies glyph row's hash code--we have just reallocated the
894 glyphs, so their contents can be complete garbage. (Bug#10164)
895
febe6bea
JB
8962011-11-30 Juanma Barranquero <lekktu@gmail.com>
897
898 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
899
801a4313
EZ
9002011-11-30 Eli Zaretskii <eliz@gnu.org>
901
902 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
903 attributes are tested _before_ calling verify_row_hash, to protect
904 against GCC re-ordering of the tests. (Bug#10164)
905
2b56b87e
JD
9062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
907
908 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
909
910 * xterm.c (handle_one_xevent): Only set async_visible and friends
911 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 912 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
913 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
914
dbf31225
PE
9152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
916
917 Remove GCPRO-related macros that exist only to avoid shadowing locals.
918 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
919 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
920 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
921 All uses changed to use GCPRO1 etc.
922 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
923 Revert to old implementation (i.e., before 2011-03-11).
924
1305621b
YM
9252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
926
927 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
928 of scroll runs so as to avoid assigning disabled bogus rows and
929 unnecessary graphics copy operations.
930
8c9afb46
EZ
9312011-11-27 Eli Zaretskii <eliz@gnu.org>
932
933 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
934 (snprintf) [_MSC_VER]: Redirect to _snprintf.
935 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
936 (malloc, free, realloc, calloc): Redirect to e_* only when
937 compiling Emacs.
938
939 * lisp.h (GCTYPEBITS): Move before first use.
940 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
941 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
942 this macro definition.
943
944 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
945 _MSC_VER.
946
54e9e3bf
JD
9472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
948
6d5eb5b0
SM
949 * gtkutil.c (xg_create_frame_widgets):
950 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
951 present with Gtk+ 2.0.
952
83aca1cb
PE
9532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
954
955 * fileio.c (Finsert_file_contents): Undo previous change; see
956 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
957
5b76caa4
PE
9582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
959
960 Rename locals to avoid shadowing.
961 * fileio.c (Finsert_file_contents):
962 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
963 * process.c (wait_reading_process_output):
964 Rename inner 'proc' to 'p' to avoid shadowing.
965 Indent for consistency with usual Emacs style.
966
8c535114
EZ
9672011-11-25 Eli Zaretskii <eliz@gnu.org>
968
969 * xdisp.c (redisplay_window): If cursor row is not fully visible
970 after recentering, and scroll-conservatively is set to a large
971 number, scroll window by a few more lines to make the cursor fully
972 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
973 (start_display): Don't move to the next line if the display should
974 start at a newline that is part of a display vector or an overlay
975 string. (Bug#10119)
8c535114 976
fa4fdb5c
JL
9772011-11-24 Juri Linkov <juri@jurta.org>
978
979 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
980 after the `MagickPingImage' call. (Bug#10112)
981
90ec88df
CY
9822011-11-23 Chong Yidong <cyd@gnu.org>
983
984 * window.c (Fcoordinates_in_window_p): Accept only live windows.
985
56e2e794
MR
9862011-11-23 Martin Rudalics <rudalics@gmx.at>
987
988 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
989 making another buffer current. (Bug#10114)
990
b6e64c41
GM
9912011-11-23 Glenn Morris <rgm@gnu.org>
992
993 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
994
6b21de18
CY
9952011-11-23 Chong Yidong <cyd@gnu.org>
996
997 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
998 using it (Bug#5984).
999
b12cd789
EZ
10002011-11-22 Eli Zaretskii <eliz@gnu.org>
1001
1002 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1003 and header-lines, as they don't have one computed for them.
1004 (Bug#10098)
1005
1006 * .gdbinit (prow): Make displayed values more self-explaining.
1007 Add row's hash code.
1008
261b6fd4
LMI
10092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1010
1011 * process.c (wait_reading_process_output): Fix asynchrounous
1012 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1013 (wait_reading_process_output): Add comment and URL.
261b6fd4 1014
e7cfd277
JD
10152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1016
1017 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1018
a9b9b7f5
CY
10192011-11-21 Chong Yidong <cyd@gnu.org>
1020
1021 * window.c (Fnext_window, Fprevious_window): Doc fix.
1022
b0d15b4f
SM
10232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1024
1025 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1026
fe7a3057
JB
10272011-11-20 Juanma Barranquero <lekktu@gmail.com>
1028
1029 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1030
d2999b1a
MR
10312011-11-20 Martin Rudalics <rudalics@gmx.at>
1032
1033 * window.c (Fset_window_combination_limit): Rename argument
1034 STATUS to LIMIT.
1035 (Vwindow_combination_limit): Remove "status" from doc-string.
1036
d5ff9cd0
AS
10372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1038
1039 * m/ibms390.h: Remove.
1040 * m/ibms390x.h: Don't include "ibms390.h".
1041
a5bb9bd3
SM
10422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1043
1044 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1045 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1046
cd1181db
JB
10472011-11-20 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * casetab.c (Fset_case_table):
1050 * charset.c (Fcharset_after): Fix typos.
1051
615a3b8d 10522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1053
17e845af
PE
1054 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1055 Otherwise, valgrind does not work on some platforms.
1056 Problem reported by Andreas Schwab in
6a0bf43d
PE
1057 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1058 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1059 is set, removing the need for VIRT_ADDRESS_VARIES.
1060 (PURE_P): Use a more-efficient implementation that needs just one
1061 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1062 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1063 to 4 (xorl, subq, cmpq, setbe).
1064 * alloc.c (pure): Always extern now, since that's the
1065 VIRT_ADDR_VARIES behavior.
1066 (PURE_POINTER_P): Use a single comparison, not two, for
1067 consistency with the new puresize.h.
1068 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1069 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1070 Remove VIRT_ADDR_VARIES no longer needed.
1071
f8fe6f96
EZ
10722011-11-19 Eli Zaretskii <eliz@gnu.org>
1073
1074 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1075 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1076 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1077 behave as if the cursor position were at the window margin.
1078
1079 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1080 and the cursor position is out of bounds, behave as if the cursor
1081 position were at the window margin. (Bug#10075)
1082
df05a53c
CY
10832011-11-18 Chong Yidong <cyd@gnu.org>
1084
1085 * window.c (Fwindow_combination_limit): Make first argument
1086 non-optional, since it is meaningless for live windows like the
1087 selected window.
1088
2071918e
DA
10892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1090
1091 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1092
b50a28de
SM
10932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1094
1095 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1096 (graft_intervals_into_buffer): Simplify.
1097
015137db
EZ
10982011-11-18 Eli Zaretskii <eliz@gnu.org>
1099
1100 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1101 hash values of the two rows.
1102 (copy_row_except_pointers): Preserve the used[] arrays and the
1103 hash values of the two rows. (Bug#10035)
68c95424 1104 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1105
1106 * xdisp.c (row_hash): New function, body extracted from
1107 compute_line_metrics.
1108 (compute_line_metrics): Call row_hash, instead of computing the
1109 hash code inline.
1110
1111 * dispnew.c (verify_row_hash): Call row_hash for computing the
1112 hash code of a row, instead of duplicating code from xdisp.c.
1113
1114 * dispextern.h (row_hash): Add prototype.
1115
a2addb04
TH
11162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1117
1118 * frame.c (delete_frame): Don't delete the terminal when the last
1119 X frame is closed if emacs is built with GTK toolkit.
1120
df85d315
JB
11212011-11-17 Juanma Barranquero <lekktu@gmail.com>
1122
1123 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1124
a0c2d0ae
MR
11252011-11-17 Martin Rudalics <rudalics@gmx.at>
1126
1127 * window.c (Vwindow_splits): Rename to
1128 Vwindow_combination_resize. Suggested by Juri Linkov.
1129 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1130 of Vwindow_splits.
1131
58179cce
JB
11322011-11-16 Juanma Barranquero <lekktu@gmail.com>
1133
7877f373
JB
1134 * nsfns.m (Fns_font_name):
1135 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1136
b6f67890
MR
11372011-11-16 Martin Rudalics <rudalics@gmx.at>
1138
1139 * window.h (window): Rename slot "nest" to "combination_limit".
1140 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1141 (Fset_window_nest): Rename to Fset_window_combination_limit.
1142 (Vwindow_nest): Rename to Vwindow_combination_limit.
1143 (recombine_windows, make_parent_window, make_window)
1144 (Fsplit_window_internal, saved_window)
1145 (Fset_window_configuration, save_window_save): Rename all
1146 occurrences of window_nest to window_combination_limit.
1147
c7015153
JB
11482011-11-15 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * image.c (imagemagick_load_image): Fix typo.
1151
322ad6ec
EZ
11522011-11-14 Eli Zaretskii <eliz@gnu.org>
1153
1154 * xdisp.c (display_line): Move the call to
1155 highlight_trailing_whitespace before the call to
1156 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1157 faces of all the glyphs to compute ROW's hash value.
1158 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1159
f067b8ec
JB
11602011-11-14 Juanma Barranquero <lekktu@gmail.com>
1161
1162 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1163 just return (bug#10044).
1164
1e5b2111
EZ
11652011-11-12 Eli Zaretskii <eliz@gnu.org>
1166
7ef3cbd5
EZ
1167 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1168 with user-defined heap size. Bump the default size of the temacs
1169 heap to 27MB, to avoid memory warning when running temacs.
1170 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1171
1e5b2111
EZ
1172 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1173 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1174 (verify_row_hash) [XASSERTS]: New function.
1175 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1176 that the hash value of glyph rows is correct.
1e5b2111 1177
89d61221
MR
11782011-11-12 Martin Rudalics <rudalics@gmx.at>
1179
1180 * window.h (window): Remove splits slot.
1181 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1182 (Fdelete_other_windows_internal, make_parent_window)
1183 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1184 (Fset_window_configuration, save_window_save): Don't deal with
1185 split status of windows.
1186 (saved_window): Remove splits slot.
1187 (Vwindow_splits): Rewrite doc-string.
1188
97f18cc8
JD
11892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1190
1191 * xfns.c (unwind_create_frame):
1192 * nsfns.m (unwind_create_frame):
1193 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1194 Vframe_list (Bug#9999).
1195
22a648b4
DA
11962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1197
0b381c7e 1198 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1199
659afede
KH
12002011-11-11 Kenichi Handa <handa@m17n.org>
1201
1202 * callproc.c (Fcall_process): Set the member dst_multibyte of
1203 process_coding.
1204
9ac0394b
KH
12052011-11-11 Johan Bockgård <bojohan@gnu.org>
1206
1207 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1208 avoid a crash (bug#9496).
1209
2fbdc249
CY
12102011-11-09 Chong Yidong <cyd@gnu.org>
1211
1212 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1213 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1214
ac6b1f81
PE
12152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1218
09db192c
PE
12192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 Avoid some portability problems by eschewing 'extern inline' functions.
1222 The trivial performance wins aren't worth the portability hassles; see
1223 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1224 et seq.
1225 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1226 (window_box_width, window_box_left, window_box_left_offset)
1227 (window_box_right, window_box_right_offset): Undo previous change,
1228 by removing the "extern"s.
1229 * intervals.c (adjust_intervals_for_insertion)
1230 (adjust_intervals_for_deletion): Undo previous change,
1231 making these static again.
1232 (offset_intervals, temp_set_point_both, temp_set_point)
1233 (copy_intervals_to_string): No longer inline.
1234 * xdisp.c (window_text_bottom_y, window_box_width)
1235 (window_box_height, window_box_left_offset)
1236 (window_box_right_offset, window_box_left, window_box_right)
1237 (window_box): No longer inline.
1238
105216ed
CY
12392011-11-08 Chong Yidong <cyd@gnu.org>
1240
1241 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1242 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1243 Signal an error if not a live window.
105216ed
CY
1244 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1245 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1246
ae9e237f
JB
12472011-11-07 Juanma Barranquero <lekktu@gmail.com>
1248
1249 * lisp.h (syms_of_abbrev): Remove declaration.
1250 Reported by CHENG Gao <chenggao@royau.me>.
1251
c7aa8333
EZ
12522011-11-07 Eli Zaretskii <eliz@gnu.org>
1253
1254 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1255 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1256 of temacs in GUI mode.
1257
be7f5545
MR
12582011-11-07 Martin Rudalics <rudalics@gmx.at>
1259
1260 * window.h: Declare delete_all_child_windows instead of
1261 delete_all_subwindows.
1262 * window.c (Fwindow_nest, Fset_window_nest)
1263 (Fset_window_new_total, Fset_window_new_normal)
1264 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1265 (delete_all_subwindows): Rename to delete_all_child_windows.
1266 (Fdelete_other_windows_internal, Fset_window_configuration):
1267 Call delete_all_child_windows instead of delete_all_subwindows.
1268 * frame.c (delete_frame): Call delete_all_child_windows instead
1269 of delete_all_subwindows.
1270
ca78dc43
PE
12712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1274 This is also needed for porting to any host where GC_MARK_STACK is
1275 not GC_MAKE_GCPROS_NOOPS.
1276 (which_symbols): Use it.
1277
a0241d01
KH
12782011-11-07 Kenichi Handa <handa@m17n.org>
1279
1280 * coding.c (coding_set_destination): Check coding->src_pos only
1281 when coding->src_object is a buffer (bug#9910).
1282
1283 * process.c (send_process): Set the member src_multibyte of coding
1284 to 0 (bug#9911) when sending a unibyte text.
1285
1286 * callproc.c (Fcall_process): Set the member src_multibyte of
1287 process_coding to 0 (bug#9912).
1288
a64bfdfa 12892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1290
1291 * xmenu.c (cleanup_widget_value_tree): New function.
1292 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1293 calling free_menubar_widget_value_tree directly (Bug#9830).
1294
cb41b32a
PE
12952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 Fix some portability problems with 'inline'.
1298 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1299 (window_box_width, window_box_left, window_box_left_offset)
1300 (window_box_right, window_box_right_offset): Declare extern.
1301 Otherwise, these inline functions do not conform to C99 and
1302 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1303 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1304 * intervals.c (adjust_intervals_for_insertion)
1305 (adjust_intervals_for_deletion): Now extern, because otherwise the
1306 extern inline functions 'offset_intervals' couldn't refer to it.
1307 (static_offset_intervals): Remove.
1308 (offset_intervals): Rewrite using the old contents of
1309 static_offset_intervals. The old version didn't conform to C99
1310 because an extern inline function contained a reference to an
1311 identifier with static linkage.
1312
b7041366
AS
13132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1314
1315 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1316 GC.
1317
88a37c4d
EZ
13182011-11-06 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1321 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1322 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1323 return Qleft_to_right.
1324
49745b39
CY
13252011-11-06 Chong Yidong <cyd@gnu.org>
1326
1327 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1328 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1329 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1330 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1331 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1332 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1333 (Fwindow_vscroll): Doc fix.
1334 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1335 argument, since it makes no sense to pass a live window and for
1336 consistency with window-child.
1337
1f05cd82
CS
13382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1339
1340 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1341 support MSVC.
1342
22610910
JR
13432011-11-05 Jason Rumney <jasonr@gnu.org>
1344
1345 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1346 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1347 fonts (Bug#6029).
1348 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1349 bitwise arithmetic preventing use of unicode-sip and non-truetype
1350 opentype fonts.
1351
a06776b2
EZ
13522011-11-05 Eli Zaretskii <eliz@gnu.org>
1353
3ad924ba
EZ
1354 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1355 "emacs"-only part.
1356
a06776b2
EZ
1357 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1358 initialization code to keep similarity to xfns.c after changes
1359 from 2011-11-05.
1360
c9e7db78
JD
13612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1362
a97f8f3f
JD
1363 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1364 (unwind_create_frame): New function (Bug#9943).
1365 (Fx_create_frame): Restructure code to be more similar to the one in
1366 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1367 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1368 Move terminal->reference_count++ just before making the frame official
1369 (Bug#9943).
1370
1371 * nsterm.m (x_free_frame_resources): New function.
1372 (x_destroy_window): Move code to x_free_frame_resources.
1373
c9e7db78 1374 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1375 (Fx_create_frame, x_create_tip_frame):
1376 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1377 official. Move initialization of image_cache_refcount and
1378 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1379
a6fc3b5c
EZ
13802011-11-05 Eli Zaretskii <eliz@gnu.org>
1381
1382 Support MSVC build with newer versions of Visual Studio.
1383 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1384 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1385 nt/gmake.defs.
1386
1387 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1388 which are not supported by MSVC.
1389 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1390 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1391 bitfields.
1392 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1393 types in bitfields.
1394 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1395
1396 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1397
58179cce 13982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1399
1400 Support MSVC build with newer versions of Visual Studio.
1401 * w32.c: Don't include w32api.h for MSVC.
1402 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1403
1404 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1405 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1406 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1407 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1408 e_* cousins.
1409 (alloca) [_MSC_VER]: Define to _alloca.
1410
1411 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1412
1413 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1414
a58c13ed
EZ
14152011-11-04 Eli Zaretskii <eliz@gnu.org>
1416
1417 * xdisp.c (note_mouse_highlight): If either of
1418 previous/next-single-property-change returns nil, treat that as
1419 the beginning or the end of the buffer. (Bug#9955)
1420
fe0b6370
JD
14212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1422
a58c13ed 1423 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1424 label is not null (Bug#9951).
1425 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1426 may be NULL.
1427
89bd5ee1
EZ
14282011-11-04 Eli Zaretskii <eliz@gnu.org>
1429
1430 * window.c (Fwindow_body_size): Mention in the doc string that the
1431 return value is in frame's canonical units. (Bug#9949)
1432
84c3edb9
EZ
14332011-11-03 Eli Zaretskii <eliz@gnu.org>
1434
4e2fb5c7
EZ
1435 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1436
84c3edb9 1437 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1438 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1439 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1440
bc17a887
EZ
14412011-11-01 Eli Zaretskii <eliz@gnu.org>
1442
1443 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1444 Don't stop backward scan on the continuation glyph, even though
1445 its CHARPOS is positive.
6d5eb5b0
SM
1446 (mouse_face_from_buffer_pos, note_mouse_highlight):
1447 Rename cover_string to disp_string.
bc17a887 1448
4ee88440
MR
14492011-11-01 Martin Rudalics <rudalics@gmx.at>
1450
1451 * window.c (temp_output_buffer_show): Don't use
1452 Vtemp_buffer_show_specifiers.
1453 (Vtemp_buffer_show_specifiers): Remove unused variable.
1454
c2ff3c02
EZ
14552011-10-30 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1458 past the beginning of the current glyph matrix.
1459
58179cce 14602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1461
1462 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1463 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1464 HAVE_GTK3 (Bug#9869).
b77a6a7f 1465
3b574623
JD
1466 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1467 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1468
b77a6a7f
JD
1469 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1470
1471 * xterm.c: Declare x_handle_net_wm_state to return int.
1472 (handle_one_xevent): Check if we are iconified but don't have
1473 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1474 (get_current_wm_state): Return non-zero if not hidden,
1475 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1476 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1477 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1478 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1479
196e41e4
PE
14802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1483 so that this new function doesn't get optimized away by a
1484 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1485
021f2e1a
AS
14862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1487
1488 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1489
8b058d44
EZ
14902011-10-29 Eli Zaretskii <eliz@gnu.org>
1491
1492 Fix the `xbytecode' command.
1493 * .gdbinit (xprintbytestr): New command.
b50a28de 1494 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1495 (xbytecode): Print the byte-code string as well.
1496
4452fb80
EZ
14972011-10-29 Kim Storm <storm@cua.dk>
1498
8b058d44
EZ
1499 * alloc.c (which_symbols): New function.
1500
21b72067
AS
15012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1502
1503 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1504 line. (Bug#9903)
1505
83ed7b5c
GM
15062011-10-29 Glenn Morris <rgm@gnu.org>
1507
1508 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1509 Not clear what it was for, and it causes various bugs. (Bug#9839)
1510
5a7a728b
EZ
15112011-10-28 Eli Zaretskii <eliz@gnu.org>
1512
1513 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1514 possible random value that matches one of those tested as
1515 condition to clear the mouse face.
1516
d3d0842f
CY
15172011-10-28 Chong Yidong <cyd@gnu.org>
1518
1519 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1520
31b39d13
DN
15212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1522
1523 * window.c (make_window): Initialize phys_cursor_on_p.
1524
9aba6043
SM
15252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1526
1527 * lisp.h (struct Lisp_Symbol): Update comments.
1528
c20992f4
JB
15292011-10-28 Juanma Barranquero <lekktu@gmail.com>
1530
1531 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1532
db4f02f2
EZ
15332011-10-28 Eli Zaretskii <eliz@gnu.org>
1534
1535 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1536 <oslsachem@gmail.com> for helping to debug this.
1537
1538 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1539 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1540 (g_b_init_get_glyph_outline_w): New static variables.
1541 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1542 (GetGlyphOutlineW_Proc): New typedefs.
1543 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1544 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1545 New functions.
1546 (w32font_open_internal, compute_metrics):
1547 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1548 instead of calling the "wide" APIs directly.
1549
1550 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1551
1552 * w32.h (syms_of_w32font): Add prototype.
1553
87e68db4
JB
15542011-10-27 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1557 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1558 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1559 (Fmove_to_window_line): Doc fix.
1560
435c1d67
CY
15612011-10-27 Chong Yidong <cyd@gnu.org>
1562
1563 * process.c (make_process): Set gnutls_state to NULL.
1564
1565 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1566 non-NULL, regardless of GNUTLS_INITSTAGE.
1567 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1568 an error. Set process slots as soon as we allocate them.
1569
1570 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1571
9c6c6f49
CY
15722011-10-27 Chong Yidong <cyd@gnu.org>
1573
9aba6043
SM
1574 * gnutls.c (emacs_gnutls_deinit): New function.
1575 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1576 (Fgnutls_deinit, Fgnutls_boot): Use it.
1577
1578 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1579 (deactivate_process): Call emacs_gnutls_deinit.
1580
657d08d3
JB
15812011-10-27 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * image.c (x_create_x_image_and_pixmap):
1584 * w32.c (sys_rename, w32_delayed_load):
1585 * w32font.c (fill_in_logfont):
1586 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1587
5430d399
JB
15882011-10-26 Juanma Barranquero <lekktu@gmail.com>
1589
1590 * w32fns.c (w32_default_color_map): New function,
1591 extracted from Fw32_default_color_map.
a7ef684b 1592 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1593
fe0055fa
PE
15942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1597
e6346438
SM
15982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1599
1600 * keyboard.c (test_undefined): New function (bug#9751).
1601 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1602
e112cc37
ET
16032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1604
1605 * sysdep.c (init_sys_modes): Fix the check for the controlling
1606 terminal (Bug#6649).
1607
7b5d6677
EZ
16082011-10-20 Eli Zaretskii <eliz@gnu.org>
1609
1610 * dispextern.h (struct bidi_it): New member next_en_type.
1611
1612 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1613 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1614 current character, check also for next_en_type being WEAK_EN.
1615 (bidi_resolve_weak): Don't enter the expensive loop if the current
1616 position is before next_en_pos. Record the bidi type of the first
1617 non-ET, non-BN character we find, in addition to its position.
1618 (bidi_level_of_next_char): Invalidate next_en_type when
1619 next_en_pos is over-stepped.
1620
7da0b018
PE
16212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1624 * editfns.c: Rewrite current-time-zone so that it invokes
1625 the equivalent of (format-time-string "%Z") to get the time zone name.
1626 This fixes a bug when the time zone name contains characters that
1627 need converting from the system time locale to Emacs internal format.
1628 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1629 that patch fixed format-time-string to do the conversion, but
1630 I forgot to fix current-time-zone.
1631 (format_time_string): New function, containing most of
1632 what Fformat_time_string used to contain.
1633 (Fformat_time_string): Rewrite in terms of format_time_string.
1634 This doesn't change this function's behavior.
1635 (current-time-zone): Rewrite to use format_time_string.
1636 This fixes the bug reported by Michael Schierl in
1637 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1638 Jason Rumney's 2007-06-07 change worked around this bug, but
1639 didn't fix it.
1640 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1641
8547b010
EZ
16422011-10-19 Eli Zaretskii <eliz@gnu.org>
1643
1644 * xdisp.c (start_display): If the character at POS is displayed
1645 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1646 (try_window_reusing_current_matrix): If a line ends in a display
1647 vector or the next line starts in a display vector, continue
1648 redrawing the window even though the character position of
1649 start_row was reached.
8547b010
EZ
1650 (Bug#9771, part 2)
1651
4e948d15
CY
16522011-10-18 Chong Yidong <cyd@gnu.org>
1653
1654 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1655 with nobreak-char-display too.
1656
4787455f
EZ
16572011-10-18 Eli Zaretskii <eliz@gnu.org>
1658
1659 Fix part 3 of bug#9771.
1660 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1661 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1662 non-neutral characters if the current character is a paragraph
1663 separator (a.k.a. Newline). This avoids running the same
1664 expensive loop twice, once when we consume the preceding newline
1665 and the other time when the line actually needs to be displayed.
1666 Avoid the loop when we see neutrals on the base embedding level
1667 following a character whose directionality is the same as the
1668 paragraph's. This avoids running the expensive loop when a line
1669 ends in a long sequence of neutrals, like control characters.
1670 Add assertion against STRONG_AL type. Slightly rearrange code
1671 that determines the type of a neutral given the first non-neutral
1672 that follows it.
1673 (bidi_level_of_next_char): Set next_en_pos to zero when
1674 invalidating its info.
1675
2c91f553
EZ
16762011-10-17 Eli Zaretskii <eliz@gnu.org>
1677
1678 * xdisp.c (push_display_prop): Determine whether to record string
1679 or buffer position by IT->string, not by IT->method. Allow
1680 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1681 (move_it_vertically_backward): Don't look for character position
1682 immediately after the newline when in a continuation line.
1683 (Bug#9771, part 1)
2c91f553 1684
c7b08b0d
MR
16852011-10-15 Martin Rudalics <rudalics@gmx.at>
1686
1687 * window.c (coordinates_in_window): Rewrite and delabelize
1688 vertical border check. (Bug#5357) (Bug#9618)
1689
6b02f655
SM
16902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1693 errors in XSetWindowBorder (bug#9310).
1694
81d40c92
DA
16952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1696
1697 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1698 avoid crash when xmalloc overrun checking is enabled.
1699
d4172c3b
EZ
17002011-10-13 Eli Zaretskii <eliz@gnu.org>
1701
1702 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1703 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1704 cursor motion with <left> and <right> arrow keys.
1705
1706 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1707 some callers set that themselves.
1708
b00eea75
EZ
17092011-10-12 Eli Zaretskii <eliz@gnu.org>
1710
1711 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1712 display string and the previous row comes from the same string and
1713 is empty. (Bug#9739) (Bug#9738)
1714
8fe012c4
SM
17152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1716
1717 * doc.c (get_doc_string): Encode file name (bug#9735).
1718
0074aef2
EZ
17192011-10-12 Eli Zaretskii <eliz@gnu.org>
1720
79beb178
EZ
1721 * bidi.c (bidi_level_of_next_char):
1722 * xdisp.c (get_visually_first_element): Remove old incorrect
1723 comments regarding the Unicode Line Separator character.
1724
0074aef2
EZ
1725 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1726
6e4b3fbe
DA
17272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 * alloc.c (Fgc_status): Do not access beyond zombies array
1730 boundary if nzombies > MAX_ZOMBIES.
1731 * alloc.c (dump_zombies): Add missing format specifier.
1732
0324f3af
PE
17332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1734
b5525cac
PE
1735 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1736 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1737
0324f3af
PE
1738 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1739 Some packages use them to denote characters with modifiers.
1740
e9b5f888
AS
17412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1742
1743 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1744 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1745 matching a pp-number. Rename parameter var to var1.
1746
127827c0
SM
17472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1748
1749 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1750
c8fd3bd0
GM
17512011-10-08 Glenn Morris <rgm@gnu.org>
1752
1753 * callint.c (Fcall_interactively): Give a more explicit error for the
1754 'c' case with a non-character input. (Bug#8479)
1755
352ec8ff
EZ
17562011-10-08 Eli Zaretskii <eliz@gnu.org>
1757
03669ccb
EZ
1758 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1759 lines.
7061c986
EZ
1760 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1761 lines that are hscrolled on the left.
03669ccb 1762
352ec8ff
EZ
1763 * dispnew.c (buffer_posn_from_coords): Account for a possible
1764 presence of header-line. (Bug#4426)
1765
a66cfb1c
SM
17662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1767
6b02f655
SM
1768 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1769 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1770
7c5ee88e
PE
17712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1774 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1775 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1776 this makes Emacs dump core during garbage collection on rare
1777 occasions. sizeof is obviously inferior to offsetof here, so
1778 stick with offsetof.
1779 (GC_POINTER_ALIGNMENT): New macro.
1780 (mark_memory): Omit 3rd (offset) arg; caller changed.
1781 Don't assume EMACS_INT alignment is the same as pointer alignment.
1782
df1bbe5b
SM
17832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1784
1785 * keyboard.c (read_key_sequence_remapped): New var.
1786 (read_key_sequence): Compute remapping in the right buffer.
1787 (command_loop_1): Use read_key_sequence's remapping directly.
1788
51553db6
SM
17892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1790
32c1fffd
SM
1791 * dired.c (file_name_completion): Don't expand file name.
1792 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1793 before checking file name handler.
1794
51553db6
SM
1795 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1796 they've been requested explicitly (bug#9591).
1797
b6bd1599 17982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1799
1800 * keymap.c (Fsingle_key_description): Use make_specified_string
1801 instead of build_string to build string from push_key_description.
1802 (Bug#5193)
1803
f701dc2a
PE
18042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1805
4222c55d
PE
1806 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1807 This fixes a Y2038 bug on 64-bit hosts.
1808 * buffer.c (reset_buffer):
1809 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1810 (Fclear_buffer_auto_save_failure):
1811 Use 0, not -1, to represent an unset failure time, since time_t
1812 might not be signed.
1813
f701dc2a
PE
1814 Remove dependency on glibc malloc internals.
1815 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1816 Move back here from lisp.h, but with their new implementations.
1817 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1818 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1819 * charset.c (charset_table_init): New static var.
1820 (syms_of_charset): Use it instead of xmalloc. This removes a
1821 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1822 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1823 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1824 Move back to alloc.c.
1825 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1826 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1827
9ceebf39
JD
18282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * nsterm.m (windowDidResize): Call x_set_window_size only when
1831 ns_in_resize is true. Otherwise set pixelwidth/height and
1832 call change_frame_size (Bug#9628).
1833
cb993c58
PE
18342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1835
3930c88b
PE
1836 Port --enable-checking=all to Fedora 14 x86-64.
1837 * charset.c (syms_of_charset): Also account for glibc malloc's
1838 internal overhead when calculating the initial malloc maximum.
1839
cb993c58
PE
1840 Port --enable-checking=all to Fedora 14 x86.
1841 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1842 Move to lisp.h.
1843 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1844 (overrun_check_realloc, overrun_check_free):
1845 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1846 That way, xmalloc returns a properly-aligned pointer even if
1847 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1848 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1849 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1850 into account when calculating the initial malloc maximum.
1851 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1852 Move here from alloc.c, so that charset.c can use it too.
1853 Properly align; the old code wasn't right for common 32-bit hosts
1854 when configured with --enable-checking=all.
1855 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1856 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1857
31bed486
EZ
18582011-09-29 Eli Zaretskii <eliz@gnu.org>
1859
04c70788 1860 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1861 use EDOM.
1862
fbcaa2f3
EZ
18632011-09-28 Eli Zaretskii <eliz@gnu.org>
1864
1865 * xdisp.c (compute_display_string_end): If there's no display
1866 string at CHARPOS, return -1.
1867
1868 * bidi.c (bidi_fetch_char): When compute_display_string_end
1869 returns a negative value, treat the character as a normal
1870 character not covered by a display string. (Bug#9624)
1871
a239d4e9
JB
18722011-09-28 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * lread.c (Fread_from_string): Fix typo in docstring.
1875
88652fd5
EZ
18762011-09-27 Eli Zaretskii <eliz@gnu.org>
1877
1878 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1879 newline, reseat the iterator instead of bidi-iterating there one
1880 character at a time. (Bug#9610)
32c1fffd
SM
1881 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1882 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1883
ed497dd4
AS
18842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1885
1886 * lread.c (readevalloop): Use correct code for NBSP.
1887 (read1): Likewise. (Bug#9608)
1888
b2bf61aa
MA
18892011-09-25 Michael Albinus <michael.albinus@gmx.de>
1890
1891 * dbusbind.c (Fdbus_register_signal): When service is not
1892 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1893
32bbb17c
GM
18942011-09-25 Glenn Morris <rgm@gnu.org>
1895
1896 * buffer.c (truncate-lines): Doc fix.
1897
94e0933e
CY
18982011-09-24 Chong Yidong <cyd@stupidchicken.com>
1899
1900 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1901 (Fset_window_next_buffers): Doc fix.
1902
cddde921
GM
19032011-09-24 Glenn Morris <rgm@gnu.org>
1904
1905 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1906
1260aef1
PE
19072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1908
25b4bfa0
PE
1909 Fix minor problems found by static checking.
1910 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1911 * indent.c (Fvertical_motion): Fix == vs = typo.
1912
e3cbd34b
EZ
19132011-09-24 Eli Zaretskii <eliz@gnu.org>
1914
a66cfb1c
SM
1915 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1916 Default value is now t. Doc fix.
6bf7006f 1917
e3cbd34b 1918 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1919 logic when moving up, not only when moving down. Fix the
e3cbd34b 1920 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1921 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1922
1923 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1924 CHARPOS is covered by a display string which includes newlines.
1925 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1926 is covered by a display string with embedded newlines.
1927
a3de0cbd
MA
19282011-09-24 Michael Albinus <michael.albinus@gmx.de>
1929
1930 * dbusbind.c (Fdbus_register_signal): Add match rule to
1931 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1932 (Fdbus_register_method, Vdbus_registered_objects_table):
1933 Fix docstring.
a3de0cbd 1934
b260039d
JM
19352011-09-24 Jim Meyering <meyering@redhat.com>
1936
32c1fffd 1937 do not ignore write error for any output size
b260039d
JM
1938 The previous change was incomplete.
1939 While it makes emacs --batch detect the vast majority of stdout
1940 write failures, errors were still ignored whenever the output size is
1941 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1942 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1943 && echo FAIL: ignored write error
1944 FAIL: ignored write error
1945 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1946 && echo FAIL: ignored write error
1947 FAIL: ignored write error
1948 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1949
8eca8a7c
AS
19502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1951
1952 * emacs.c (Fkill_emacs): In noninteractive mode exit
1953 non-successfully if a write error occurred on stdout. (Bug#9574)
1954
3341db62
EZ
19552011-09-21 Eli Zaretskii <eliz@gnu.org>
1956
1957 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1958 the xassert test.
1959
1960 * dispextern.h (struct it): Update the comment documenting what
1961 can it->OBJECT be.
1962
8c203dbf
EZ
19632011-09-20 Eli Zaretskii <eliz@gnu.org>
1964
1965 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1966 a display string, extend search for cursor position to end of row.
1967 (find_row_edges): If the row ends in a newline from a display
1968 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1969 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1970 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1971 non-empty line. Fixes confusing cursor motion with arrow keys at
1972 the beginning of a line that starts with whitespace.
8c203dbf 1973
a4824228
LMI
19742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1975
1976 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1977 (bug#9493).
1978
33ed493b
CY
19792011-09-18 Chong Yidong <cyd@stupidchicken.com>
1980
1981 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1982 boolean (Bug#9154).
1983
56cd55c8
EZ
19842011-09-18 Eli Zaretskii <eliz@gnu.org>
1985
1986 * xdisp.c (display_line): Record maximum and minimum buffer
1987 positions even if no glyphs were produced (e.g., by a zero-width
1988 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1989 buffer positions that will be removed from the glyph row because
1990 they don't fit.
c02dcedf
EZ
1991 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1992 column is beyond frame width: don't subtract 1 "pixel" when
1993 computing width of the stretch.
3e62b7e0
EZ
1994 (reseat_at_next_visible_line_start): Undo the change made on
1995 2011-09-17 that saved paragraph information and restored it after
1996 the call to `reseat'. (Bug#9545)
56cd55c8 1997
5ed99d36 19982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1999
2000 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2001 and turn window cursor on if cleared (Bug#9415).
2002
5ed99d36 20032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2004
2005 * search.c (boyer_moore): Take unibyte characters from pattern
2006 literally. (Bug#9458)
2007
9bade7b2
EZ
20082011-09-18 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2011
e5e9d610
PE
20122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2013
87e4427a
PE
2014 Fix minor problem found by static checking.
2015 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2016 initialized, to pacify gcc -Wuninitialized.
2017
e5e9d610
PE
2018 * fileio.c: Report proper errno when syscall falls.
2019 (Finsert_file_contents): Save and restore errno,
2020 so that report_file_error outputs the correct diagnostic.
2021 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2022
a1674f0b
EZ
20232011-09-18 Eli Zaretskii <eliz@gnu.org>
2024
2025 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2026
fbfb6dd4
EZ
20272011-09-17 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2030 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2031
bb187662
EZ
20322011-09-17 Eli Zaretskii <eliz@gnu.org>
2033
1137e8b8 2034 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2035 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2036
2037 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2038 (bidi_find_paragraph_start): Search back for paragraph beginning
2039 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2040 (bidi_move_to_visually_next): Only trigger paragraph-related
2041 computations when the last character is a newline or at EOB, not
2042 just any NEUTRAL_B. (Bug#9470)
2043
bb187662
EZ
2044 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2045 truncated lines if point is covered by a display string. (Bug#9524)
2046
2e621251
PE
20472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2050 (cons_to_x_long): New function.
2051 (lisp_data_to_selection_data): Use it. Correct the test for
2052 short-versus-long data; it was negated. Break out of vector
2053 loop, for efficiency, when a long datum is discovered.
2054
91a15bc6
SM
20552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2056
2057 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2058
b41c3a35
EZ
20592011-09-16 Eli Zaretskii <eliz@gnu.org>
2060
2061 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2062 GCC PR/17406) by declaring this function with external scope.
2063
7812ba2d
PE
20642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2065
2066 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2067 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2068
cf7edc2a
AS
20692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2070
2071 * editfns.c (Fformat): Correctly handle text properties on "%%".
2072
bd01620e
EZ
20732011-09-15 Eli Zaretskii <eliz@gnu.org>
2074
2075 * xterm.c (x_draw_composite_glyph_string_foreground):
2076 * w32term.c (x_draw_composite_glyph_string_foreground):
2077 * term.c (encode_terminal_code):
2078 * composite.c (composition_update_it, get_composition_id):
2079 * xdisp.c (get_next_display_element)
2080 (fill_composite_glyph_string): Add comments about special meaning
2081 of TAB characters in a composition.
2082
a02719a3
PE
20832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2086 This occurs when processing a multibyte format.
2087 Problem reported by Wolfgang Jenker.
a02719a3 2088
72589a3c
JB
20892011-09-15 Johan Bockgård <bojohan@gnu.org>
2090
2091 * xdisp.c (try_cursor_movement): Only check for exact match if
2092 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2093
1c14176c
PE
20942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 Remove unused external symbols.
2097 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2098 * xdisp.c (calc_pixel_width_or_height): Now static.
2099 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2100 * indent.c (check_display_width):
2101 * w32term.c: Fix comment to match code.
2102 * xterm.c, xterm.h (x_catching_errors): Remove.
2103
d2eea5b5
PE
21042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * xselect.c: Use signed conversions more consistently (Bug#9498).
2107 (selection_data_to_lisp_data): Assume incoming selection data are
2108 signed integers, not unsigned. This is to be consistent with
2109 outgoing selection data, which was modified to use signed integers
2110 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2111 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2112 expects long, not unsigned long.
2113
46888499
EZ
21142011-09-14 Eli Zaretskii <eliz@gnu.org>
2115
2116 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2117 computation of loop end. Reported by Johan Bockgård
2118 <bojohan@gnu.org>.
2119
ef8ef9fb
CY
21202011-09-13 Chong Yidong <cyd@stupidchicken.com>
2121
2122 * frame.c (Fother_visible_frames_p): Function deleted.
2123
fa819fed
EZ
21242011-09-12 Eli Zaretskii <eliz@gnu.org>
2125
2126 * indent.c (compute_motion): Process display vector front to back
2127 rather than the other way around. (Bug#2496)
2128
2ba8e008
SM
21292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2130
2131 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2132
20f53c69
CY
21332011-09-11 Chong Yidong <cyd@stupidchicken.com>
2134
2135 * minibuf.c (Fread_from_minibuffer): Doc fix.
2136
d562d7a4
EZ
21372011-09-11 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2140 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2141
1c4d7f3d
LMI
21422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2143
2144 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2145 value for non-existent files.
2146
b885bf36
EZ
21472011-09-11 Eli Zaretskii <eliz@gnu.org>
2148
2149 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2150 set its "size" to -1. This will set the modtime_size field of
2151 the corresponding buffer to -1, which is what
2152 verify-visited-file-modtime expects for files that do not exist.
2153 (Bug#9139)
2154
6612f0bf
PE
21552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2158 here ...
2159 * lisp.h: ... from here. push_key_description is no longer
2160 defined in keyboard.c, so its declaration should not be in
2161 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2162 logically belongs with push_key_description.
2163
dfb3f755
PE
21642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * buffer.h: Include <sys/types.h> instead of <time.h>.
2167 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2168 Problem reported by Herbert J. Skuhra.
2169
3134906c
LMI
21702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2171
2172 * xml.c (parse_region): Make the parsing work for
2173 non-comment-starting XML files again (bug#9144).
2174
8d903f4e
AS
21752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2176
2177 * image.c (gif_load): Fix calculation of bottom and right corner.
2178 (Bug#9468)
2179
80ad64f4
EZ
21802011-09-10 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2183 redisplay in small windows.
2184
208a048d
EZ
21852011-09-09 Eli Zaretskii <eliz@gnu.org>
2186
2187 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2188
9b1c252e
MR
21892011-09-08 Martin Rudalics <rudalics@gmx.at>
2190
2191 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2192 Operate on live windows only.
2193
2949f33b
JB
21942011-09-08 Juanma Barranquero <lekktu@gmail.com>
2195
2196 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2197
e08dcafd
EZ
21982011-09-07 Eli Zaretskii <eliz@gnu.org>
2199
2200 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2201 only under bidi iteration.
2202
115b96bd
JD
22032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2204
2205 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2206
c8199d0f
PE
22072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2210 Without this fix, the command to link temacs failed due to an
2211 undefined symbol __builtin_isnan. This is because
2212 /usr/include/iso/math_c99.h #defines isnan(x) to
2213 __builtin_isnan(x), but the bundled gcc, which identifies itself
2214 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2215 a __builtin_isnan.
2216 * floatfns.c (isnan): #undef, and then #define to a clone of
2217 what's in data.c.
2218 (Fisnan): Always define, since it's always available now.
2219 (syms_of_floatfns): Always define isnan at the Lisp level.
2220
e39b275c 22212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2222
2223 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2224
b2db44d9 22252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2226
f4af5137 2227 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2228 The previous code assumed that file offsets (off_t values) fit in
2229 EMACS_INT variables, which is not true on typical 32-bit hosts.
2230 The code messed up by falsely reporting buffer overflow in cases
2231 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2232 when "big" contains more than 2**29 bytes, even though this
2233 inserts just one byte and does not overflow the buffer.
2234 (Finsert_file_contents): Store file offsets as off_t
2235 values, not as EMACS_INT values. Check for overflow when
2236 converting between EMACS_INT and off_t. When checking for
2237 buffer overflow or for overlap, take the offsets into account.
2238 Don't use EMACS_INT for small values where int suffices.
2239 When checking for overlap, fix a typo: ZV was used where
2240 ZV_BYTE was intended.
2241 (Fwrite_region): Don't assume off_t fits into 'long'.
2242 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2243
ecfc0a49
MA
22442011-09-05 Michael Albinus <michael.albinus@gmx.de>
2245
2246 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2247
6511acf2 22482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2249
0999621a 2250 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2251
2252 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2253 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2254 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2255 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2256 (modify_event_symbol): Do not assume that the length of
2257 name_alist_or_stem is safe to alloca and fits in int.
2258 (Fexecute_extended_command): Likewise for function name and binding.
2259 (Frecursion_depth): Wrap around reliably on integer overflow.
2260 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2261 since some callers pass EMACS_INT values.
2262 (Fsingle_key_description): Don't crash if symbol name contains more
2263 than MAX_ALLOCA bytes.
2264 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2265 (get_minibuffer): Arg is now EMACS_INT, not int.
2266 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2267 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2268 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2269
2be7d702
PE
2270 * dbusbind.c (signature_cat): New function.
2271 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2272 Do not overrun buffer; instead, report string overflow.
2273
9d1df220
PE
2274 * dispnew.c (add_window_display_history): Don't overrun buffer.
2275 Truncate instead; this is OK since it's just a log.
2276
33ef5c64
PE
2277 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2278 even if the time zone offset is outlandishly large.
2279 Don't mishandle offset == INT_MIN.
2280
66c6fdd5
PE
2281 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2282 when creating daemon; the previous buffer-overflow check was incorrect.
2283
d749b01b
PE
2284 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2285 which has the guts of the old verror function.
2286
b5cd1905
PE
2287 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2288 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2289
6e1a67fb
PE
2290 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2291 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2292 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2293 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2294 length of string rather than counting it via multiple sprintfs;
2295 that's simpler and more reliable.
c21721cc
PE
2296 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2297 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2298 sprintf, in case result does not fit in int.
2299
c57b67fc
PE
2300 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2301 (fontset_from_font): Print it.
2302
8a401434
PE
2303 * frame.c (tty_frame_count): Now printmax_t, not int.
2304 (make_terminal_frame, set_term_frame_name): Print it.
2305 (x_report_frame_params): In X, window IDs are unsigned long,
2306 not signed long, so print them as unsigned.
2307 (validate_x_resource_name): Check for implausibly long names,
2308 and don't assume name length fits in 'int'.
2309 (x_get_resource_string): Don't blindly alloca invocation name;
2310 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2311 not fit in int.
2312
6e1a67fb
PE
2313 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2314 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2315 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2316
0df02bf3
PE
2317 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2318 Use esprintf, not sprintf, in case result does not fit in int.
2319
48e30793
PE
2320 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2321 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2322 it as a large positive number.
2323 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2324 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2325
a66ff6d8
PE
2326 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2327 in case result does not fit in int.
2328
aca216ff
PE
2329 * print.c (float_to_string): Detect width overflow more reliably.
2330 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2331 buffer overrun. Don't assume list length fits in 'int'. Treat
2332 print length of 0 as 0, not as infinity; to be consistent with other
2333 uses of print length in this function. Don't overflow print length
2334 index. Don't assume hash table size fits in 'long', or that
2335 vectorlike size fits in 'unsigned long'.
2336
31c286f7
PE
2337 * process.c (make_process): Use printmax_t, not int, to format
2338 process-name gensyms.
2339
55e5faa1
PE
2340 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2341
80f2e268
PE
2342 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2343 to avoid potential buffer overrun.
2344
670741ab
PE
2345 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2346 if X resource line is longer than 512 bytes.
2347
b7163a50
PE
2348 * xfns.c (x_window): Make sprintf buffer a bit bigger
2349 to avoid potential buffer overrun.
2350
ae58ff1f
PE
2351 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2352
c43c8a6a
PE
2353 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2354
3f8236f4
PE
23552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2356
53e9fe90 2357 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2358 Without these, Emacs silently mishandles large integers sometimes.
2359 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2360 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2361
6511acf2
PE
2362 * xdisp.c (try_window_id): Check Emacs fixnum range before
2363 converting to 'int'.
806add1d 2364
6511acf2 2365 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2366 Check that an Emacs fixnum is in range before assigning it to 'int'.
2367 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2368 values converted from Emacs fixnums.
2369 (Frecenter): Don't wrap around a line count if it is out of 'int'
2370 range; instead, treat it as an extreme value.
2371 (Fset_window_configuration, compare_window_configurations):
2372 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2373
6511acf2
PE
2374 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2375 that can exceed INT_MAX. Check that EMACS_INT value is in range
2376 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2377 (match_limit): Don't assume that a fixnum can fit in 'int'.
2378
6511acf2 2379 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2380 exceed INT_MAX.
2381
6511acf2 2382 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2383 (Fvertical_motion): Don't wrap around LINES values that don't fit
2384 in 'int'. Instead, treat them as extreme values. This is good
2385 enough for windows, which can't have more than INT_MAX lines anyway.
2386
fcb901a7
LMI
23872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2388
0f2f6b6d
LMI
2389 * Require libxml/parser.h to avoid compilation warning.
2390
fcb901a7
LMI
2391 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2392
2393 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2394 since this reportedly can destroy thread storage.
2395
6e20a0d4
CY
23962011-08-30 Chong Yidong <cyd@stupidchicken.com>
2397
2398 * syntax.c (find_defun_start): Update all cache variables if
2399 exiting early (Bug#9401).
2400
148ae00e
EZ
24012011-08-30 Eli Zaretskii <eliz@gnu.org>
2402
f6cfbd8f
EZ
2403 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2404
148ae00e
EZ
2405 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2406 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2407 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2408
2409 * term.c (tty_append_glyph): New function.
2410 (produce_stretch_glyph): Static function and its prototype deleted.
2411
a66cfb1c
SM
2412 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2413 Add prototypes.
148ae00e 2414
c4a07a4c
PE
24152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2418 when checking :margin (Bug#9390).
2419 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2420 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2421 so that the name doesn't mislead. All uses changed.
2422
6bc8cd65
JB
24232011-08-28 Johan Bockgård <bojohan@gnu.org>
2424
2425 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2426 set_tty_hooks.
2427
dca4927e
EZ
24282011-08-27 Eli Zaretskii <eliz@gnu.org>
2429
2430 * xdisp.c (move_it_to): Don't bail out early when reaching
2431 position beyond to_charpos, if we are scanning backwards.
2432 (move_it_vertically_backward): When DY == 0, make sure we get to
2433 the first character in the line after the newline.
2434
f2cad773
PE
24352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2436
2437 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2438 (ccl_driver): Do not generate an out-of-range pointer.
2439 (Fccl_execute_on_string): Remove unnecessary check for
2440 integer overflow, noted by Stefan Monnier in
2441 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2442 Remove a FIXME that didn't need fixing.
2443 Simplify the newly-introduced buffer reallocation code.
2444
0cae2cdb
JB
24452011-08-27 Juanma Barranquero <lekktu@gmail.com>
2446
2447 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2448
5fc295a4 24492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2450
70c60eb2 2451 Integer and memory overflow issues (Bug#9196).
726e0ab1 2452
d31850da
PE
2453 * doc.c (get_doc_string): Rework so that
2454 get_doc_string_buffer_size is the actual buffer size, rather than
2455 being 1 less than the actual buffer size; this makes xpalloc more
2456 convenient.
2457
a69fbedb
PE
2458 * image.c (x_allocate_bitmap_record, cache_image):
2459 * xselect.c (Fx_register_dnd_atom):
2460 Simplify previous changes by using xpalloc.
2461
fe5c5d37
PE
2462 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2463 since either will do and ptrdiff_t is convenient with xpalloc.
2464
0065d054
PE
2465 * charset.c (charset_table_size)
2466 (struct charset_sort_data.priority): Now ptrdiff_t.
2467 (charset_compare): Don't overflow if priorities differ greatly.
2468 (Fsort_charsets): Don't assume list length fits in int.
2469 Check for size-calculation overflow when allocating sort data.
2470 (syms_of_charset): Allocate an initial charset table that is
2471 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2472
2473 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2474
2475 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2476 The actual value is always <= INT_MAX, and leaving it unsigned made
2477 overflow checking harder.
2478
2479 * dispextern.h (struct glyph_matrix.rows_allocated)
2480 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2481 with xpalloc. The values are still always <= INT_MAX.
2482
2483 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2484
2485 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2486 (SAFE_NALLOCA): New macro.
2487
2488 * region-cache.c (struct boundary.pos, find_cache_boundary)
2489 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2490 (set_cache_region, invalidate_region_cache)
2491 (revalidate_region_cache, know_region_cache, region_cache_forward)
2492 (region_cache_backward, pp_cache):
2493 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2494 so that ptrdiff_t * can be passed to xpalloc.
2495 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2496 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2497 (pp_cache): Don't assume cache_len fits in int.
2498 * region-cache.h: Adjust extern decls to match.
2499
2500 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2501 EMACS_INT, since either will do, for xpalloc.
2502
2503 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2504 (xnmalloc, xnrealloc, xpalloc): New functions.
2505
726e0ab1
PE
2506 * bidi.c (bidi_shelve_header_size): New constant.
2507 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2508 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2509
51f30bc5 2510 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2511 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2512 (overlay_strings):
2513 Don't update size of array until after memory allocation succeeds,
2514 because xmalloc/xrealloc may not return.
0065d054
PE
2515 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2516 now that we have proper integer overflow checking.
2517 (record_overlay_string, overlay_strings): Catch overflows when
2518 calculating size of overlay_str_buf.
726e0ab1 2519
0065d054
PE
2520 * callproc.c (Fcall_process): Check for size overflow when
2521 calculating size of args2.
2522 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2523 Normally we prefer signed values, but sticking with ptrdiff_t would
2524 require adding more-complicated checks.
726e0ab1
PE
2525
2526 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2527 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2528 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2529 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2530
2531 * character.c (Fstring): Check for size-calculation overflow.
2532
2533 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2534 unnecessary integer overflow. Check for size overflow.
2535 (encode_coding_object): Don't update size until xmalloc succeeds.
2536
2537 * composite.c (get_composition_id): Check for overflow in glyph
2538 length calculations.
2539
2540 Integer and memory overflow fixes for display code.
2541 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2542 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2543 (scrolling_window): Check for overflow in size calculations.
2544 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2545 Don't assume glyph table len fits in int.
2546 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2547 (row_table_size): Now ptrdiff_t, not int.
2548 (scrolling_window): Avoid overflow in size calculations.
2549 Don't update size until allocation succeeds.
2550 * fns.c (concat): Check for overflow in size calculations.
2551 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2552 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2553 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2554
2555 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2556 (get_doc_string): Check for size calculation overflow.
2557 Don't update size until allocation succeeds.
2558 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2559 EMACS_INT, where ptrdiff_t will do.
2560 (Fsubstitute_command_keys): Check for string overflow.
2561
2562 * editfns.c (set_time_zone_rule): Don't assume environment length
2563 fits in int.
2564 (message_length): Now ptrdiff_t, not int.
2565 (Fmessage_box): Don't update size until allocation succeeds.
2566 Don't assume message length fits in int.
2567 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2568
0065d054
PE
2569 * emacs.c (main): Do not reallocate argv, since there is a null at
2570 the end that can be overwritten, and this way there's no need to
2571 worry about size-calculation overflow.
2572 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2573
2574 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2575 alloc succeeds.
2576 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2577
2578 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2579 (x_set_scroll_bar_width, x_figure_window_size):
2580 Check for integer overflow.
2581 (x_set_alpha): Do not assume XINT fits in int.
2582
2583 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2584 This is for the members text_lines, text_cols, total_lines, total_cols,
2585 where the system imposes an 'int' limit.
2586
2587 * fringe.c (Fdefine_fringe_bitmap):
2588 Don't update size until alloc works.
2589
2590 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2591 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2592
2593 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2594 Check for size-calculation overflow.
2595 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2596 do, as we prefer signed integers.
2597 (id_to_widget.max_size, id_to_widget.used)
2598 (xg_store_widget_in_map, xg_remove_widget_from_map)
2599 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2600 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2601 Use and return ptrdiff_t, not int.
2602 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2603 * gtkutil.h: Change prototypes to match the above.
2604
2605 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2606 are duplicate now that they've been promoted to lisp.h.
2607 (x_allocate_bitmap_record, x_alloc_image_color)
2608 (make_image_cache, cache_image, xpm_load):
2609 Don't update size until alloc is done.
2610 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2611 (x_detect_edges):
3256efce 2612 Check for size calculation overflow.
726e0ab1
PE
2613 (ct_colors_allocated_max): New constant.
2614 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2615 overflow.
3256efce 2616
726e0ab1
PE
2617 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2618 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2619 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2620 Use ptrdiff_t, not int, to count maps.
2621 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2622 calculations. Don't update size until allocation succeeds.
2623 Redo calculations to avoid overflow.
726e0ab1
PE
2624 * keyboard.h: Change prototypes to match the above.
2625
2626 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2627 to count maps.
2628 (current_minor_maps): Check for size calculation overflow.
2629 * keymap.h: Change prototypes to match the above.
2630
2631 * lread.c (read1, init_obarray): Don't update size until alloc done.
2632
2633 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2634 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2635
726e0ab1
PE
2636 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2637 Now ptrdiff_t, not int.
2638 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2639 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2640
2641 * process.c (Fnetwork_interface_list): Check for overflow
2642 in size calculation.
2643
2644 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2645
2646 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2647 overflow. Don't bother calling xmalloc when xrealloc will do.
2648
2649 * search.c (Freplace_match): Check for size calculation overflow.
2650 (Fset_match_data): Don't assume list lengths fit in 'int'.
2651
2652 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2653 for command line length. Do not attempt to address one before the
2654 beginning of an array, as that's not portable.
2655
2656 * term.c (max_frame_lines): Remove; unused.
2657 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2658 not int.
2659 (encode_terminal_code, calculate_costs): Check for size
2660 calculation overflow.
2661 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2662 table lengths and related sizes. Don't update size until alloc
2663 done. Redo calculations to avoid overflow.
2664 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2665
2666 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2667 subtracting pointers.
2668 (gobble_line): Check for overflow more carefully. Don't update size
2669 until alloc done.
2670
2671 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2672 Don't update size until alloc done.
2673 Redo size calculations to avoid overflow.
2674 Check for size calculation overflow.
0065d054 2675 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2676
2677 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2678 Use ptrdiff_t, not int, for sizes.
2679 (store_mode_line_noprop_char): Don't update size until alloc done.
2680
0065d054
PE
2681 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2682 Use ptrdiff_t, not int, for sizes.
2683 (Finternal_make_lisp_face, cache_face):
2684 Check for size calculation overflow.
2685 (cache_face): Treat size calculation overflows as if they were
2686 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2687
2688 * xfns.c (x_encode_text, x_set_name_internal)
2689 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2690 sizes, since they can exceed INT_MAX in size. Check for size
2691 calculation overflow.
2692
0065d054
PE
2693 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2694 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2695 Don't update size until alloc done.
2696
0065d054 2697 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2698 as sprintf is limited to int lengths.
1d526e2f 2699
252c5ee1
PE
2700 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2701 (X_LONG_MIN): New macros.
864d7ce7
PE
2702 Use them to make the following changes clearer.
2703 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2704 This change doesn't affect the value now, but it may help remind
2705 future maintainers not to raise the value too much later.
2706 (SELECTION_QUANTUM): Remove, replacing with ...
2707 (selection_quantum): ... new function, which avoids overflow.
2708 All uses changed.
2709 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2710 assumption that selection length fits in 'int'.
2711 (x_reply_selection_request, x_handle_selection_request)
2712 (x_get_window_property, receive_incremental_selection)
2713 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2714 (lisp_data_to_selection_data, clean_local_selection_data):
2715 Use ptrdiff_t, not int, to record length of selection.
2716 (x_reply_selection_request, x_get_window_property)
2717 (receive_incremental_selection, x_property_data_to_lisp):
2718 Redo calculations to avoid overflow.
2719 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2720 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2721 something.
2722 (x_get_window_property, receive_incremental_selection)
2723 (lisp_data_to_selection_data, x_property_data_to_lisp):
2724 Check for size-calculation overflow.
2725 (x_get_window_property, receive_incremental_selection)
2726 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2727 Don't store size until memory allocation succeeds.
2728 (x_get_window_property): Plug memory leak on memory exhaustion.
2729 Don't double-block input; malloc is safe here. Don't assume 2**34
2730 - 4 fits in unsigned long. Add an xassert to check
2731 XGetWindowProperty overflow. Be more careful about overflow
2732 calculations, and distinguish size from memory overflow better.
2733 (receive_incremental_selection): When tracing, don't assume
2734 unsigned int is less than INT_MAX.
2735 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2736 harmful) conversions of unsigned short to int.
2737 (lisp_data_to_selection_data): Don't assume that integers
2738 in the range -65535 through -1 fit in an X unsigned short.
2739 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2740 result parameters unless successful. Rely on cons_to_unsigned
2741 to report problems with elements; the old code wasn't right anyway.
2742 (x_check_property_data): Check for int overflow; we cannot use
2743 a wider type due to X limits.
2744 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2745
726e0ab1 2746 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2747
0065d054
PE
2748 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2749 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2750 (x_color_cells): Don't store size until memory allocation succeeds.
2751 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2752 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2753 (x_term_init): Don't assume length fits in int (sprintf is limited
2754 to int size).
bc18e09d 2755
ebfa62c0
PE
2756 Use ptrdiff_t for composition IDs.
2757 * character.c (lisp_string_width):
2758 * composite.c (composition_table_size, n_compositions)
2759 (get_composition_id, composition_gstring_from_id):
2760 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2761 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2762 * window.c (Frecenter):
2763 Use ptrdiff_t, not int, for composition IDs.
2764 * composite.c (get_composition_id): Check for integer overflow.
2765 * composite.h: Adjust prototypes to match the above changes.
2766
d3411f89
PE
2767 Use ptrdiff_t for hash table indexes.
2768 * category.c (hash_get_category_set):
2769 * ccl.c (ccl_driver):
2770 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2771 * coding.c (coding_system_charset_list, detect_coding_system):
2772 * coding.h (struct coding_system.id):
2773 * composite.c (get_composition_id, gstring_lookup_cache):
2774 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2775 * image.c (xpm_get_color_table_h):
2776 * lisp.h (hash_lookup, hash_put):
2777 * minibuf.c (Ftest_completion):
2778 Use ptrdiff_t for hash table indexes, not int (which is too
2779 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2780 32-bit --with-wide-int hosts).
2781
e097a6fa
PE
2782 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2783 Add a FIXME comment about memory leaks.
2784 (syms_of_charset): Don't assume xmalloc returns.
2785
5637687f
PE
2786 Don't assume that stated character widths fit in int.
2787 * character.c (Fchar_width, c_string_width, lisp_string_width):
2788 * character.h (CHAR_WIDTH):
2789 * indent.c (MULTIBYTE_BYTES_WIDTH):
2790 Use sanitize_char_width to avoid undefined and/or bad behavior
2791 with outlandish widths.
a66cfb1c 2792 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2793 now that we have two such functions. All uses changed.
2794 (sanitize_char_width): New inline function.
2795
a2271ba2
PE
2796 Don't assume that tab-width fits in int.
2797 * character.h (sanitize_width): New inline function.
2798 (SANE_TAB_WIDTH): New macro.
2799 (ASCII_CHAR_WIDTH): Use it.
2800 * indent.c (sane_tab_width): Remove. All uses replaced by
2801 SANE_TAB_WIDTH (current_buffer).
2802 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2803
18c52557
PE
2804 * fileio.c: Integer overflow issues with file modes.
2805 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2806
caeeedc1
PE
2807 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2808 Remove unreachable code.
2809 (read_hex, load_charset_map_from_file): Check for integer overflow.
2810
6df6ae42 2811 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2812 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2813 (x_send_scroll_bar_event): Likewise. Check that the size does not
2814 exceed limits imposed by XClientMessageEvent, as well as the usual
2815 ptrdiff_t and size_t limits.
2816
b13995db
PE
2817 * keyboard.c: Overflow, signedness and related fixes.
2818 (make_lispy_movement): Use same integer type in forward decl
2819 that is used in the definition.
2820 (read_key_sequence, keyremap_step):
2821 Change bufsize argument back to int, undoing my 2011-03-30 change.
2822 We prefer signed types, and int is wide enough here.
2823 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2824 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2825 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2826 length, not size_t. Use ptrdiff_t for index, not int.
2827 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2828 possibility of integer overflow.
2829
13464394
PE
2830 Overflow, signedness and related fixes for images.
2831
2832 * dispextern.h (struct it.stack[0].u.image.image_id)
2833 (struct_it.image_id, struct image.id, struct image_cache.size)
2834 (struct image_cache.used, struct image_cache.ref_count):
2835 * gtkutil.c (update_frame_tool_bar):
2836 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2837 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2838 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2839 * nsmenu.m (update_frame_tool_bar):
2840 * xdisp.c (calc_pixel_width_or_height):
2841 * xfns.c (image_cache_refcount):
2842 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2843 on typical 64-bit hosts.
2844
2845 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2846 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2847 Omit unnecessary casts to int.
2848 (parse_image_spec): Check that integers fall into 'int' range
2849 when the callers expect that.
2850 (image_ascent): Redo ascent calculation to avoid int overflow.
2851 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2852 (lookup_image): Remove unnecessary tests.
2853 (xbm_image_p): Locals are now of int, not EMACS_INT,
2854 since parse_image_check makes sure they fit into int.
2855 (png_load, gif_load, svg_load_image):
2856 Prefer int to unsigned where either will do.
2857 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2858 old tiff_error_handler and tiff_warning_handler.
2859 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2860 stack buffer overflows. It uses only the features of vsnprintf
2861 that are common to both POSIX and native Microsoft.
2862 (tiff_error_handler, tiff_warning_handler): Use it.
2863 (tiff_load, gif_load, imagemagick_load_image):
2864 Don't assume :index value fits in 'int'.
2865 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2866 (imagemagick_load_image): Check that crop parameters fit into
2867 the integer types that MagickCropImage accepts. Don't assume
2868 Vimagemagick_render_type has a nonnegative value. Don't assume
2869 size_t fits in 'long'.
2870 (gs_load): Use printmax_t to print the widest integers possible.
2871 Check for integer overflow when computing image height and width.
2872
c11821d4
EZ
28732011-08-26 Eli Zaretskii <eliz@gnu.org>
2874
2875 * xdisp.c (redisplay_window): Don't force window start if point
2876 will be invisible in the resulting window. (Bug#9324)
2877
0c95fcf7
EZ
28782011-08-25 Eli Zaretskii <eliz@gnu.org>
2879
2880 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2881 the display spec is of the form `(space ...)'.
2882 (handle_display_spec): Return the value returned by
2883 handle_single_display_spec, not just 1 or zero.
2884 (handle_single_display_spec): If the display spec is of the form
2885 `(space ...)', and specifies display in the text area, return 2
2886 rather than 1.
fee65a97 2887 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2888 accurately, and prefer exact match for point under bidi.
2889 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2890
2891 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2892 into disp_prop; all users changed.
2893
2894 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2895 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2896 for the text covered by the display property.
2897
e4ed06f1
CY
28982011-08-25 Chong Yidong <cyd@stupidchicken.com>
2899
2900 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2901 Change return value to nil.
2902 (Frecord_buffer): Delete unused function.
2903
f67cdd7f
EZ
29042011-08-24 Eli Zaretskii <eliz@gnu.org>
2905
5980d4c6
EZ
2906 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2907 buffers, return left-to-right.
8610fe8b
EZ
2908 (set_cursor_from_row): Consider candidate row a win if its glyph
2909 represents a newline and point is on that newline. Fixes cursor
2910 positioning on the newline at EOL of R2L text within L2R
2911 paragraph, and vice versa.
2912 (try_cursor_movement): Check continued rows, in addition to
2913 continuation rows. Fixes unwarranted scroll when point enters a
2914 continued line of R2L text within an L2R paragraph, or vice versa.
2915 (cursor_row_p): Consider the case of point being equal to
2916 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2917 from the end of a short line to the beginning of a continued line
2918 of R2L text within L2R paragraph.
2919 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2920 composed characters.
5980d4c6 2921
f67cdd7f
EZ
2922 * bidi.c (bidi_check_type): Use xassert.
2923 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2924 members.
2925
bca633fb
EZ
29262011-08-23 Eli Zaretskii <eliz@gnu.org>
2927
2928 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2929 a character.
2930
4a5885a7
CY
29312011-08-23 Chong Yidong <cyd@stupidchicken.com>
2932
2933 * nsfont.m (ns_otf_to_script): Fix typo.
2934
0902a04e
KH
29352011-08-22 Kenichi Handa <handa@m17n.org>
2936
2937 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2938 extra slot even if the purpose is char-code-property-table.
2939
1a2e6670
EZ
29402011-08-23 Eli Zaretskii <eliz@gnu.org>
2941
8ddde651
EZ
2942 * xdisp.c (redisplay_window): When computing centering_position,
2943 account for the height of the header line. (Bug#8874)
2944
425cc014
EZ
2945 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2946 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2947 candidate is selected by the mouse, and that candidate has a
2948 composed character under the mouse.
2949
1a2e6670
EZ
2950 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2951 coordinates reported by pos-visible-in-window-p for a composed
2952 character in column zero.
2953
8b76d6f8
SM
29542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2955
2956 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2957
dac347dd
EZ
29582011-08-22 Eli Zaretskii <eliz@gnu.org>
2959
2960 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2961 consider it a hit if to_charpos is anywhere in the range of the
2962 composed buffer positions.
2963
e013fb34
CY
29642011-08-22 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * image.c (gif_load): Don't assume that each subimage has the same
2967 dimensions as the base image. Handle disposal method that is
2968 "undefined" by the gif spec (Bug#9335).
2969
bd1ba3e8
CY
29702011-08-20 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2973 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2974
54a1215b
EZ
29752011-08-19 Eli Zaretskii <eliz@gnu.org>
2976
823564e5
EZ
2977 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2978 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2979 from an Org mode buffer to a Speedbar frame.
2980
54a1215b
EZ
2981 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2982 a composition, take its buffer position from IT->cmp_it.charpos.
2983 Fixes cursor positioning at the beginning of a line that begins
2984 with a composed character.
2985
9778ebcc
EZ
29862011-08-18 Eli Zaretskii <eliz@gnu.org>
2987
0be6ee06
EZ
2988 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2989 character bidirectional type, use STRONG_L instead. Fixes crashes
2990 in a buffer produced by `describe-categories'.
2991
9778ebcc
EZ
2992 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2993 members before the level stack, so they would be saved and
2994 restored when copying iterator state. Fixes incorrect reordering
2995 around TABs covered by display properties.
2996
156bffbe
AS
29972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2998
6b02f655 2999 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3000
72ad093b
CY
30012011-08-17 Chong Yidong <cyd@stupidchicken.com>
3002
3003 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3004 (internal_condition_case_2, internal_condition_case_n):
3005 Remove unnecessary aborts (Bug#9081).
72ad093b 3006
35774242
EZ
30072011-08-17 Eli Zaretskii <eliz@gnu.org>
3008
3009 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3010 has no `load' handler, try opening the file locally. (Bug#9311)
3011
db76dd85
KB
30122011-08-16 Ken Brown <kbrown@cornell.edu>
3013
3014 * gmalloc.c: Expand comment.
3015
b215eee5
EZ
30162011-08-16 Eli Zaretskii <eliz@gnu.org>
3017
3018 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3019 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3020
a4579d33
KB
30212011-08-16 Ken Brown <kbrown@cornell.edu>
3022
3023 Fix memory allocation problems in Cygwin build (Bug#9273).
3024
3025 * unexcw.c ( __malloc_initialized): Declare external variable.
3026 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3027
8b76d6f8
SM
3028 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3029 New variables.
a4579d33
KB
3030 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3031 dumped emacs.
3032 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3033 in the static heap.
3034 [CYGWIN] (special_realloc): New function.
3035 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3036 requests to realloc storage in the static heap.
3037
3ebec551
PE
30382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * bidi.c (bidi_initialize): Remove unused local.
3041
9fd8be00
EZ
30422011-08-15 Eli Zaretskii <eliz@gnu.org>
3043
6b02f655
SM
3044 * bidimirror.h:
3045 * biditype.h: Remove file.
3046 * makefile.w32-in ($(BLD)/bidi.$(O)):
3047 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3048
3049 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3050
3051 * chartab.c: Improve commentary for the uniprop_table API.
3052
32413314
EZ
3053 * bidi.c (bidi_paragraph_init): Support zero value of
3054 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3055 (bidi_initialize): Use uniprop_table instead of including
3056 biditype.h and bidimirror.h.
32413314 3057
9fd8be00
EZ
3058 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3059 coordinates of the iterator when restoring from ppos_it.
3060 (Bug#9296)
3061
5cf2b69b
KH
30622011-08-14 Kenichi Handa <handa@m17n.org>
3063
3064 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3065 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3066
daf17d00
EZ
30672011-08-14 Eli Zaretskii <eliz@gnu.org>
3068
3069 * xdisp.c (move_it_in_display_line_to): Don't invoke
3070 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3071 ppos_it. Fixes vertical cursor motion when line beginning is
3072 covered by an image. (Bug#9296)
3073
08e3161a
JD
30742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3075
3076 * nsterm.h (ns_run_ascript): Declare.
3077 (NSAPP_DATA2_RUNASSCRIPT): Define.
3078
3079 * nsfns.m (as_script, as_result, as_status): New static variables.
3080 (ns_run_ascript): New function.
5e617bc2 3081 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3082 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3083 the event loop. Get status from as_status (Bug#7276).
3084
3085 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3086 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3087 the event loop (Bug#7276).
3088
a3720aa2
AS
30892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3090
3091 * gnutls.c (QCgnutls_bootprop_priority)
3092 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3093 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3094 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3095 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3096 (QCgnutls_bootprop_verify_hostname_error)
3097 (QCgnutls_bootprop_callbacks_verify): Rename from
3098 Qgnutls_bootprop_..., all uses changed.
3099
3100 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3101 uses changed.
3102
0a0d27fb
PE
31032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3104
19d5c50c
PE
3105 * xfaces.c (Qframe_set_background_mode): Now static.
3106 * dispextern.h (Qframe_set_background_mode): Remove decl.
3107
0a0d27fb
PE
3108 * process.c (Fnetwork_interface_info): Declare local only if needed.
3109
377538cb
JD
31102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3111
3112 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3113 (Fnetwork_interface_list): Allocate in increments of bytes instead
3114 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3115 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3116 sockaddr.
3117 (struct ifflag_def): notrailers is smart on OSX.
3118 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3119 Get hardware address with getifaddrs if available.
3120
08fff70c
EZ
31212011-08-12 Eli Zaretskii <eliz@gnu.org>
3122
3123 * xdisp.c (iterate_out_of_display_property): xassert that
3124 IT->position is set to within IT->object's boundaries. Break from
3125 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3126 when IT->position is set up wrongly due to some bug.
3127 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3128 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3129 entry. Force push_it to save on the stack the current
3130 buffer/string position, to be restored by pop_it. Fix flags in
3131 the iterator structure wrt the object coming from a display
3132 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3133 properties. (Bug#9284)
3134
7be1c708 31352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3136
7be1c708
CY
3137 * fontset.c (fontset_get_font_group): Add proper type checks.
3138 (Bug#9172)
aac0c6e3 3139
7be1c708 31402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3141
7be1c708
CY
3142 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3143 and LC_VERSION_MIN_MACOSX.
3144 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3145 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3146
97bb72a6
EZ
31472011-08-08 Eli Zaretskii <eliz@gnu.org>
3148
3149 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3150 no-display-properties-and-no-overlays under bidi display.
3151 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3152 properties and overlays.
97bb72a6 3153
d5617611
CY
31542011-08-08 Chong Yidong <cyd@stupidchicken.com>
3155
37e11a63
CY
3156 * editfns.c (Fset_time_zone_rule): Document relationship with the
3157 setenv function.
3158
d5617611
CY
3159 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3160 the font entity extracted from the cache (Bug#8109).
3161
58872834
CY
31622011-08-07 Chong Yidong <cyd@stupidchicken.com>
3163
3164 * composite.c (autocmp_chars): Don't reset point. That is done by
3165 restore_point_unwind (Bug#5984).
3166
75bfc667
JL
31672011-08-07 Juri Linkov <juri@jurta.org>
3168
3169 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3170 to show the arg `TIME' instead of `TIMEVAL'.
3171
d1410150
EZ
31722011-08-06 Eli Zaretskii <eliz@gnu.org>
3173
3174 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3175 display property strides EOL and includes a newline, as in
3176 longlines-mode. (Bug#9254)
75b771e4
EZ
3177 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3178 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3179
3180 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3181 is non-zero, even if the data buffer is NULL. Fixes a crash in
3182 vertical-motion with longlines-mode. (Bug#9254)
3183
35928349
EZ
31842011-08-05 Eli Zaretskii <eliz@gnu.org>
3185
ec7cc85b
EZ
3186 * bidi.c <bidi_cache_total_alloc>: Now static.
3187 (bidi_initialize): Initialize bidi_cache_total_alloc.
3188
8b76d6f8 3189 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3190 cache. (Bug#9221)
3191
3192 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3193 amount allocated this far in `bidi_cache_total_alloc'.
3194 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3195 non-zero, only free the data buffer without restoring the cache
3196 contents. All callers changed.
3197
3198 * dispextern.h (bidi_unshelve_cache): Update prototype.
3199
3200 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3201 (move_it_in_display_line, move_it_to)
3202 (move_it_vertically_backward, move_it_by_lines): Replace the call
3203 to xfree to an equivalent call to bidi_unshelve_cache.
3204 (move_it_in_display_line_to): Fix logic of returning
412b6358 3205 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3206
e2e2423b
EZ
32072011-08-05 Eli Zaretskii <eliz@gnu.org>
3208
3209 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3210 came from a string character with a `cursor' property. (Bug#9229)
3211
ae9e757a
JD
32122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3213
3214 * Makefile.in (LIB_PTHREAD): New variable.
3215 (LIBES): Add LIB_PTHREAD (Bug#9216).
3216
3217 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3218 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3219
213bd7f2
AS
32202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3221
6b02f655 3222 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3223
99aaf75f
JD
32242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3225
3226 * xterm.c (x_find_topmost_parent): New function.
3227 (x_set_frame_alpha): Find topmost parent window with
3228 x_find_topmost_parent and set the property there also (bug#9181).
3229 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3230
c74e9d86
PE
32312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 * callproc.c (Fcall_process): Avoid vfork clobbering
3234 the local vars buffer, coding_systems, current_dir.
3235
640c8776
SM
32362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3237
3238 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3239
f26d0e4c
PE
32402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3241
8a10d76c
PE
3242 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3243 so that it is not optimized away.
3244
f26d0e4c
PE
3245 * xdisp.c (compute_display_string_pos): Remove unused local.
3246
55439c61
EZ
32472011-08-02 Eli Zaretskii <eliz@gnu.org>
3248
3249 Fix slow cursor motion and scrolling in large buffers with
3250 selective display, like Org Mode buffers. (Bug#9218)
3251
3252 * dispextern.h (struct bidi_it): New member disp_prop_p.
3253
3254 * xdisp.c: Remove one-slot cache of display string positions.
3255 (compute_display_string_pos): Accept an additional argument
5e617bc2 3256 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3257 for a display string or property. If found, set DISP_PROP_P
3258 non-zero.
3259
3260 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3261 DISP_PROP_P, and pass it to compute_display_string_pos.
3262 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3263 non-zero. All callers of bidi_fetch_char changed.
3264
fb33fa43
SM
32652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3266
3267 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3268
b099e063
DM
32692010-12-03 Don March <don@ohspite.net>
3270
3271 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3272 last character M-[char] is translated to ESC [char] (bug#7541).
3273
5cc7f7af
KH
32742011-08-02 Kenichi Handa <handa@m17n.org>
3275
d0fffa3f 3276 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3277
3278 * chartab.c (uniprop_table): Make it non-static.
3279
525d5e6e
EZ
32802011-08-01 Eli Zaretskii <eliz@gnu.org>
3281
3282 * xdisp.c (forward_to_next_line_start): Accept additional argument
3283 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3284 on the newline.
3285 (reseat_at_next_visible_line_start): Use the bidi iterator state
3286 returned by forward_to_next_line_start to restore the state of
3287 it->bidi_it after backing up to previous newline. (Bug#9212)
3288
31011111
AS
32892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3290
3291 * regex.c (re_comp): Protoize.
3292 (re_exec): Fix return type.
3293 (regexec): Fix type of `ret'. (Bug#9203)
3294
476371c4
PE
32952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3296
e5d76069
PE
3297 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3298 This is needed if max-image-size is a floating-point number.
3299
9a79b20c
AS
33002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3301
3302 * print.c (print_object): Print empty symbol as ##.
3303
3304 * lread.c (read1): Read ## as empty symbol.
3305
d8c2fa78
AA
33062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3307
3308 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3309 setting frame foreground color (Bug#9175).
3310 (x_set_background_color): Likewise.
3311
ffe57a7a
AA
3312 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3313 contents (Bug#9176).
3314 (EmacsTooltip -init): Remove bezels and add shadows to
3315 tooltip windows.
3316
bf3492a5
AA
3317 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3318 or scroll bar (Bug#8470).
3319
d55e9c53
AA
3320 * nsfont.m (nsfont_open): Remove assignment to voffset and
3321 unnecessary vars hshink, expand, hd, full_height, min_height.
3322 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3323
3324 * nsterm.h (nsfont_info): Remove voffset field.
3325
d8c2fa78 33262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3327
3328 Implement strike-through and overline on NextStep (Bug#8863).
3329
3330 * nsfont.m (nsfont_open): Use underline position provided by font,
3331 instead of hard-coded value of 2.
3332 (nsfont_draw): Call ns_draw_text_decoration instead.
3333
3334 * nsterm.h: Add declaration for ns_draw_text_decoration.
3335
3336 * nsterm.m (ns_draw_text_decoration): New function for drawing
3337 underline, overline, and strike-through.
3338 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3339 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3340 accommodate underlining, etc.
4843aac3 3341
4cc60b9b
EZ
33422011-07-28 Eli Zaretskii <eliz@gnu.org>
3343
bc7ece87
EZ
3344 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3345 default.
4cc60b9b 3346
476371c4
PE
33472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3348
66606eea
PE
3349 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3350 Without this fix, if a signal arrives just after memory fills up,
3351 'malloc' might be invoked reentrantly.
3352
476371c4
PE
3353 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3354 In other words, assume that every image size is allowed, on non-X
3355 hosts. This assumption is probably wrong, but it lets Emacs compile.
3356
f3fcc40d
AS
33572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3358
3359 * regex.c (re_iswctype): Convert return values to boolean.
3360
350c992f
EZ
33612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3362
3363 * xdisp.c (compute_display_string_pos): Don't use cached display
3364 string position if the buffer had its restriction changed.
3365 (Bug#9184)
3366
5266b4bb
PE
33672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3370
2573a837 33712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3372
41f55ccd 3373 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3374
39e378da
PE
3375 * bidi.c: Integer size and overflow fixes.
3376 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3377 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3378 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3379 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3380 (bidi_find_other_level_edge):
3381 Use ptrdiff_t instead of EMACS_INT where either will do.
3382 This works better on 32-bit hosts configured --with-wide-int.
3383 (bidi_cache_ensure_space): Check for size-calculation overflow.
3384 Use % rather than repeated addition, for better worst-case speed.
3385 Don't set bidi_cache_size until after xrealloc returns, because it
3386 might not return.
3387 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3388 (bidi_cache_ensure_space): Also check that the bidi cache size
3389 does not exceed that of the largest Lisp string or buffer. See Eli
3390 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3391
5e927815
PE
3392 * alloc.c (__malloc_size_t): Remove.
3393 All uses replaced by size_t. See Andreas Schwab's note
3394 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3395
ca4aa935
PE
3396 * image.c: Improve checking for integer overflow.
3397 (check_image_size): Assume that f is nonnull, since
3398 it is always nonnull in practice. This is one less thing to
3399 worry about when checking for integer overflow later.
3400 (x_check_image_size): New function, which checks for integer
3401 overflow issues inside X.
3402 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3403 This removes the need for a memory_full check.
3404 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3405 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3406 (xbm_read_bitmap_data): Change locals back to 'int', since
3407 their values must fit in 'int'.
3408 (xpm_load_image, png_load, tiff_load):
3409 Invoke x_create_x_image_and_pixmap earlier,
3410 to avoid much needless work if the image is too large.
3411 (tiff_load): Treat overly large images as if
3412 x_create_x_image_and_pixmap failed, not as malloc failures.
3413 (gs_load): Use x_check_image_size.
3414
5f8f9cc2
PE
3415 * gtkutil.c: Omit integer casts.
3416 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3417 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3418
5adf60bc
PE
3419 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3420
c8907a93
PE
3421 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3422 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3423 would wrongly return t on a 64-bit host.
3424
e3c25c68
PE
3425 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3426 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3427 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3428 and therefore cause GCC to emit a bogus diagnostic in some cases.
3429
3f791afe
PE
3430 * image.c: Integer signedness and overflow and related fixes.
3431 This is not an exhaustive set of fixes, but it's time to
3432 record what I've got.
3433 (lookup_pixel_color, check_image_size): Remove redundant decls.
3434 (check_image_size): Don't assume that arbitrary EMACS_INT values
3435 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3436 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3437 (tiff_load, imagemagick_load_image):
3438 Check for overflow in size calculations.
3439 (x_create_x_image_and_pixmap): Remove unnecessary test for
3440 xmalloc returning NULL; that can't happen.
3441 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3442 (xpm_color_bucket): Use better integer hashing function.
3443 (xpm_cache_color): Don't possibly over-allocate memory.
3444 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3445 (gif_memory_source):
3446 Use ptrdiff_t, not int or size_t, to record sizes.
3447 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3448 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3449 either works, as we prefer signed integers.
3450 (tiff_read_from_memory, tiff_write_from_memory):
3451 Return tsize_t, not size_t, since that's what the TIFF API wants.
3452 (tiff_read_from_memory): Don't fail simply because the read would
3453 go past EOF; instead, return a short read.
3454 (tiff_load): Omit no-longer-needed casts.
3455 (Fimagemagick_types): Don't assume size fits into 'int'.
3456
3cc5a532
PE
3457 Improve hashing quality when configured --with-wide-int.
3458 * fns.c (hash_string): New function, taken from sxhash_string.
3459 Do not discard information about ASCII character case; this
3460 discarding is no longer needed.
3461 (sxhash-string): Use it. Change sig to match it. Caller changed.
3462 * lisp.h: Declare it.
3463 * lread.c (hash_string): Remove, since we now use fns.c's version.
3464 The fns.c version returns a wider integer if --with-wide-int is
3465 specified, so this should help the quality of the hashing a bit.
3466
b312a492
PE
3467 * emacs.c: Integer overflow minor fix.
3468 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3469 Define only if GNU_LINUX.
3470 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3471
dfd153ae
PE
3472 * dispnew.c: Integer signedness and overflow fixes.
3473 Remove unnecessary forward decls, that were a maintenance hassle.
3474 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3475 All uses changed.
3476 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3477 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3478 (prepare_desired_row, line_draw_cost):
3479 Use int, not unsigned, where either works.
3480 (save_current_matrix, restore_current_matrix):
3481 Use ptrdiff_t, not size_t, where either works.
3482 (init_display): Check for overflow more accurately, and without
3483 relying on undefined behavior.
3484
a81d11a3
PE
3485 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3486 Remove, replacing with the new symbols in lisp.h. All uses changed.
3487 * fileio.c (make_temp_name):
3488 * filelock.c (lock_file_1, lock_file):
3489 * xdisp.c (message_dolog):
3490 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3491 Use pMd etc. instead.
3492 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3493 replacing the pWIDE etc. symbols removed from editfns.c.
3494
3300e6fd
PE
3495 * keyboard.h (num_input_events): Now uintmax_t.
3496 This is (very slightly) less likely to mess up due to wraparound.
3497 All uses changed.
3498
fd05c7e9
PE
3499 * buffer.c: Integer signedness fixes.
3500 (alloc_buffer_text, enlarge_buffer_text):
3501 Use ptrdiff_t rather than size_t when either will do, as we prefer
3502 signed integers.
3503
903fe15d
PE
3504 * alloc.c: Integer signedness and overflow fixes.
3505 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3506 (__malloc_size_t): Default to size_t, not to int.
3507 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3508 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3509 Prefer ptrdiff_t to size_t when either would do, as we prefer
3510 signed integers.
3511 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3512 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3513 Now const. Initialize with values that are in range even if char
3514 is signed.
3515 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3516 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3517 These functions do the right thing with sizes > 2**32.
3518 (check_depth): Now ptrdiff_t, not int.
3519 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3520 Adjust to new way of storing sizes. Check for size overflow bugs
3521 in rest of code.
3522 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3523 slightly wrong anyway, as it missed one instance of
3524 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3525 (refill_memory_reserve): Omit needless cast to size_t.
3526 (mark_object_loop_halt): Mark as externally visible.
3527
ac82cc6a
PE
3528 * xselect.c: Integer signedness and overflow fixes.
3529 (Fx_register_dnd_atom, x_handle_dnd_message):
3530 Use ptrdiff_t, not size_t, since we prefer signed.
3531 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3532 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3533 x_dnd_atoms_size and x_dnd_atoms_length.
3534
c2d1e36d
PE
3535 * doprnt.c: Prefer signed to unsigned when either works.
3536 * eval.c (verror):
3537 * doprnt.c (doprnt):
3538 * lisp.h (doprnt):
3539 * xdisp.c (vmessage):
3540 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3541 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3542 prefer signed arithmetic to avoid comparison confusion.
3543 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3544 but is a bit tricky.
3545
0e926e56
PE
3546 Assume freestanding C89 headers, string.h, stdlib.h.
3547 * data.c, doprnt.c, floatfns.c, print.c:
3548 Include float.h unconditionally.
3549 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3550 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3551 * regex.c: Likewise for stddef.h, string.h.
3552 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3553 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3554 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3555 (STDC_HEADERS): Remove obsolete defines.
3556 * sysdep.c: Include limits.h unconditionally.
3557
9cfdb3ec
PE
3558 Assume support for memcmp, memcpy, memmove, memset.
3559 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3560 * regex.c (memcmp, memcpy):
3561 Remove; we assume C89 now.
3562
3563 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3564 (__malloc_safe_bcopy): Remove; no longer needed.
3565
cf950e6b 3566 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3567 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3568 well either way, and we prefer signed to unsigned.
3569
dbf38e02
LMI
35702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3571
3572 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3573 closes the connection while we're reading (bug#9182).
3574
d6f0886c 35752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3576
d6f0886c
JD
3577 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3578 are specified (Bug#9168).
24e0f6b1 3579
2eb1f9e6
PE
35802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3583 Found by GCC static checking and --with-wide-int on a 32-bit host.
3584
22381272 35852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3586
3587 * xdisp.c (compute_display_string_pos): Fix logic of caching
3588 previous display string position. Initialize cached_prev_pos to
3589 -1. Fixes slow-down at the beginning of a buffer.
3590
f25e39b4
EZ
35912011-07-24 Eli Zaretskii <eliz@gnu.org>
3592
3593 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3594 for attrs[LFACE_FONTSET_INDEX].
3595
04c4b52e
PE
35962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 * xml.c (parse_region): Remove unused local
3599 that was recently introduced.
3600
c1734fbd
EZ
36012011-07-23 Eli Zaretskii <eliz@gnu.org>
3602
be18c5a5
EZ
3603 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3604 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3605
c1734fbd
EZ
3606 * xdisp.c (move_it_in_display_line_to): Record the best matching
3607 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3608 exit if none of the characters scanned was an exact match.
3609 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3610 when exact match is impossible due to invisible text, and the
3611 lines are truncated.
3612
a258d627
JD
36132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3616 for OSX >= 10.7.
3617
b6d5a689
EZ
36182011-07-22 Eli Zaretskii <eliz@gnu.org>
3619
0f74f785
EZ
3620 Fix a significant slow-down of cursor motion with C-n, C-p,
3621 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3622 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3623 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3624 (next_element_from_buffer): Call compute_stop_pos_backwards to
3625 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3626 base_level_stop.
3627 (reseat): Don't look for prev_stop, as that could mean a very long
3628 run.
3629 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3630 <cached_disp_overlay_modiff>: Cache for last found display string
3631 position.
551918c1 3632 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3633 about the same buffer in the same area of character positions, and
3634 the buffer wasn't changed since the time the display string
3635 position was cached.
551918c1 3636
b2d0c91a
EZ
36372011-07-22 Eli Zaretskii <eliz@gnu.org>
3638
3639 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3640 is an integer, which is important for empty lines. (Bug#9149)
3641
043604ee
CY
36422011-07-22 Chong Yidong <cyd@stupidchicken.com>
3643
3644 * frame.c (Fmodify_frame_parameters): In tty case, update the
3645 default face if necessary (Bug#4238).
3646
da4adb04
CY
36472011-07-21 Chong Yidong <cyd@stupidchicken.com>
3648
3649 * editfns.c (Fstring_to_char): No need to explain what a character
3650 is in the docstring (Bug#6576).
3651
9abd0532
LMI
36522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3653
3654 * xml.c (parse_region): Make sure we always return a tree.
3655
36881d16
HK
36562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3657
3658 * xml.c (parse_region): If a document contains only comments,
3659 return that, too.
3660
1e98674d
LMI
36612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3662
3663 * xml.c (make_dom): Return comments, too.
3664
590bd467
PE
36652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 Port to OpenBSD.
3668 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3669 and the surrounding thread.
3670 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3671 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3672 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3673 timer goes off.
3674 * s/openbsd.h (BROKEN_SIGIO): Define.
3675 * unexelf.c (unexec) [__OpenBSD__]:
3676 Don't update the .mdebug section of the Alpha COFF symbol table.
3677
f41628b2
LMI
36782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3679
3680 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3681 (bug#8460).
3682
b59b67c5
PE
36832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3684
15e3a074
PE
3685 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3686 This fixes some race conditions on the permissions of any newly
3687 created file.
3688
41bed37d
PE
3689 * alloc.c (valid_pointer_p): Use pipe, not open.
3690 This fixes some permissions issues when debugging.
3691
b59b67c5
PE
3692 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3693 If fchown fails to set both uid and gid, try to set just gid,
3694 as that is sometimes allowed. Adjust the file's mode to eliminate
3695 setuid or setgid bits that are inappropriate if fchown fails.
3696
925a6be7
SM
36972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3698
3699 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3700 to compare Lisp_Objects.
3701 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3702 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3703 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3704
52968808
AS
37052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3706
0a6a104b
AS
3707 * lread.c (read_integer): Unread even EOF character.
3708 (read1): Likewise. Properly record start position of symbol.
3709
52968808
AS
3710 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3711 symbol character follows.
3712
9e381cdd
PE
37132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3716 This works around a problem with the previous change to Fcopy_file.
3717 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3718 and without this change, GCC might complain about discarding
3719 fchown's return value.
3720
b5641435
JB
37212011-07-16 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3724
a8031457
PE
37252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3728
dd889327
LMI
37292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3730
750c33f7
LMI
3731 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3732 it's used from the C level.
3733
dd889327
LMI
3734 * process.c: Use the same condition for POLL_FOR_INPUT in both
3735 keyboard.c and process.c (bug#1858).
3736
87e86684
LM
37372011-07-09 Lawrence Mitchell <wence@gmx.li>
3738
3739 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3740 (Fgnutls_boot): Use it.
3741
64348f40
AS
37422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3743
3744 * doc.c (Fsubstitute_command_keys): Revert last change.
3745
1d698799
LMI
37462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3747
f863868c
LMI
3748 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3749 quotes the next character, and doesn't affect other longer
3750 sequences (bug#8935).
3751
1d698799
LMI
3752 * lread.c (syms_of_lread): Clarify that is isn't only
3753 `eval-buffer' and `eval-defun' that's affected by
3754 `lexical-binding' (bug#8460).
3755
aa4b6df6
EZ
37562011-07-15 Eli Zaretskii <eliz@gnu.org>
3757
3758 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3759 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3760
5d856da6
PE
37612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3762
ad6042bb
PE
3763 Fix minor problems found by static checking.
3764 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3765 (elsz): Now a signed constant, not a size_t var. We prefer signed
3766 types to unsigned, to avoid integer comparison confusion. Without
3767 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3768 "cannot optimize loop, the loop counter may overflow", a symptom
3769 of the confusion.
f00bbb22 3770 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3771 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3772
6468f31c
LMI
37732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3774
49080b10
LMI
3775 * search.c (Fre_search_backward): Mention `case-fold-search' in
3776 all the re_search_* functions (bug#8138).
3777
6468f31c
LMI
3778 * keyboard.c (Fopen_dribble_file): Document when the file is
3779 closed (bug#8056).
3780
c965adc5
EZ
37812011-07-14 Eli Zaretskii <eliz@gnu.org>
3782
df9733bf
EZ
3783 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3784 bidi_cache_idx.
3785
0bb23927
EZ
3786 Support bidi reordering of display and overlay strings.
3787 * xdisp.c (compute_display_string_pos)
3788 (compute_display_string_end): Accept additional argument STRING.
3789 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3790 (reseat_to_string): Initialize bidi_it->string.s and
3791 bidi_it->string.schars.
3792 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3793 NULL (avoids a crash in bidi_paragraph_init).
3794 Initialize itb.string.lstring.
0bb23927
EZ
3795 (init_iterator): Call bidi_init_it only of a valid
3796 buffer position was specified. Initialize paragraph_embedding to
3797 L2R.
3798 (reseat_to_string): Initialize the bidi iterator.
3799 (display_string): If we need to ignore text properties of
3800 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3801 original value of -1 will not work with bidi.)
3802 (compute_display_string_pos): First arg is now struct
3803 `text_pos *'; all callers changed. Support display properties on
3804 Lisp strings.
3805 (compute_display_string_end): Support display properties on Lisp
3806 strings.
3807 (init_iterator, reseat_1, reseat_to_string): Initialize the
3808 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3809 when iterating on a string not from display properties).
640c8776
SM
3810 (compute_display_string_pos, compute_display_string_end):
3811 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3812 arrow keys.
3813 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3814 base_level_stop; instead, set base_level_stop to BEGV.
3815 Fixes crashes in vertical-motion.
0bb23927
EZ
3816 (next_element_from_buffer): Improve commentary for when
3817 the iterator is before prev_stop.
3818 (init_iterator): Initialize bidi_p from the default value of
3819 bidi-display-reordering, not from buffer-local value. Use the
3820 buffer-local value only if initializing for buffer iteration.
3821 (handle_invisible_prop): Support invisible properties on strings
3822 that are being bidi-reordered.
3823 (set_iterator_to_next): Support bidi reordering of C strings and
3824 Lisp strings.
3825 (next_element_from_string): Support bidi reordering of Lisp
3826 strings.
3827 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3828 (display_string): Support display of R2L glyph rows.
3829 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3830 (init_iterator): Don't initialize it->bidi_p for strings
3831 here.
3832 (reseat_to_string): Initialize it->bidi_p for strings here.
3833 (next_element_from_string, next_element_from_c_string)
3834 (next_element_from_buffer): Add xassert's for correspondence
3835 between IT's object being iterated and it->bidi_it.string
3836 structure.
3837 (face_before_or_after_it_pos): Support bidi iteration.
3838 (next_element_from_c_string): Handle the case of the first string
3839 character that is not the first one in the visual order.
3840 (get_visually_first_element): New function, refactored from common
3841 parts of next_element_from_buffer, next_element_from_string, and
3842 next_element_from_c_string.
3843 (tool_bar_lines_needed, redisplay_tool_bar)
3844 (display_menu_bar): Force left-to-right direction. Add a FIXME
3845 comment for making that be controlled by a user option.
3846 (push_it, pop_it): Save and restore the state of the
3847 bidi iterator. Save and restore the bidi_p flag.
3848 (pop_it): Iterate out of display property for string iteration as
3849 well.
3850 (iterate_out_of_display_property): Support iteration over strings.
3851 (handle_single_display_spec): Set up it->bidi_it for iteration
3852 over a display string, and call bidi_init_it.
3853 (handle_single_display_spec, next_overlay_string)
3854 (get_overlay_strings_1, push_display_prop): Set up the bidi
3855 iterator for displaying display or overlay strings.
3856 (forward_to_next_line_start): Don't use the shortcut if
3857 bidi-iterating.
3858 (back_to_previous_visible_line_start): If handle_display_prop
3859 pushed the iterator stack, restore the internal state of the bidi
3860 iterator by calling bidi_pop_it same number of times.
3861 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3862 and we are bidi-iterating, don't decrement the iterator position;
3863 instead, set the first_elt flag in the bidi iterator, to produce
3864 the same effect.
3865 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3866 (push_display_prop): xassert that we are iterating a buffer.
3867 (push_it, pop_it): Save and restore paragraph_embedding member.
3868 (handle_single_display_spec, next_overlay_string)
3869 (get_overlay_strings_1, reseat_1, reseat_to_string)
3870 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3871 correctly. Don't assume unibyte strings are not bidi-reordered.
3872 (compute_display_string_pos)
3873 (compute_display_string_end): Fix handling the case of C string.
3874 (push_it, pop_it): Save and restore from_disp_prop_p.
3875 (handle_single_display_spec, push_display_prop): Set the
3876 from_disp_prop_p flag.
3877 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3878 (pop_it): Call iterate_out_of_display_property only if we are
3879 popping after iteration over a string that came from a display
3880 property. Fix a typo in popping stretch info. Add an assertion
3881 for verifying that the iterator position is in sync with the bidi
3882 iterator.
3883 (handle_single_display_spec, get_overlay_strings_1)
3884 (push_display_prop): Fix initialization of paragraph direction for
3885 string when that of the parent object is not yet determined.
3886 (reseat_1): Call bidi_init_it to resync the bidi
3887 iterator with IT's position. (Bug#7616)
3888 (find_row_edges): If ROW->start.pos gives position
3889 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3890 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3891 Reset the from_disp_prop_p flag.
3892 (SAVE_IT, RESTORE_IT): New macros.
3893 (pos_visible_p, face_before_or_after_it_pos)
3894 (back_to_previous_visible_line_start)
3895 (move_it_in_display_line_to, move_it_in_display_line)
3896 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3897 (try_scrolling, redisplay_window, display_line): Use them when
3898 saving a temporary copy of the iterator and restoring it back.
3899 (back_to_previous_visible_line_start, reseat_1)
3900 (init_iterator): Empty the bidi cache "stack".
3901 (move_it_in_display_line_to): If iterator ended up at
3902 EOL, but we never saw any buffer positions smaller than
3903 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3904 motion in bidi-reordered lines.
3905 (move_it_in_display_line_to): Record prev_method and prev_pos
3906 immediately before the call to set_iterator_to_next. Fixes cursor
3907 motion in bidi-reordered lines with stretch glyphs and strings
3908 displayed in margins. (Bug#8133) (Bug#8867)
3909 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3910 TO_CHARPOS.
640c8776
SM
3911 (pos_visible_p): Support positions in bidi-reordered lines.
3912 Save and restore bidi cache.
0bb23927
EZ
3913
3914 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3915 (bidi_paragraph_info): Delete unused struct.
3916 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3917 (bidi_cache_start): New variable.
3918 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3919 to zero.
3920 (bidi_cache_fetch_state, bidi_cache_search)
3921 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3922 (bidi_cache_find, bidi_peek_at_next_level)
3923 (bidi_level_of_next_char, bidi_find_other_level_edge)
3924 (bidi_move_to_visually_next): Compare cache index with
3925 bidi_cache_start rather than with zero.
3926 (bidi_fetch_char): Accept new argument STRING; all callers
3927 changed. Support iteration over a string. Support strings with
3928 display properties. Support unibyte strings. Fix the type of
3929 `len' according to what STRING_CHAR_AND_LENGTH expects.
3930 (bidi_paragraph_init, bidi_resolve_explicit_1)
3931 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3932 (bidi_level_of_next_char, bidi_move_to_visually_next):
3933 Support iteration over a string.
0bb23927
EZ
3934 (bidi_set_sor_type, bidi_resolve_explicit_1)
3935 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3936 can now be zero (for strings); special values 0 and -1 were
3937 changed to -1 and -2, respectively.
3938 (bidi_char_at_pos): New function.
3939 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3940 Call it instead of FETCH_MULTIBYTE_CHAR.
3941 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3942 initialized to valid values.
3943 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3944 values.
3945 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3946 the test for valid cached positions. Fix the logic for looking up
3947 the sentinel state in the cache. GCPRO the Lisp string we are
3948 iterating.
3949 (bidi_push_it, bidi_pop_it): New functions.
3950 (bidi_initialize): Initialize the bidi cache start stack pointer.
3951 (bidi_cache_ensure_space): New function, refactored from part of
3952 bidi_cache_iterator_state. Don't assume the required size is just
3953 one BIDI_CACHE_CHUNK away.
3954 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3955 (bidi_count_bytes, bidi_char_at_pos): New functions.
3956 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3957 always valid if bidi_cache_idx is valid.
3958 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3959 is valid if it's going to be used.
3960 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3961 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3962 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3963 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3964 (bidi_find_other_level_edge, bidi_cache_start_stack):
3965 All variables related to cache indices are now EMACS_INT.
c965adc5 3966
0bb23927
EZ
3967 * dispextern.h (struct bidi_string_data): New structure.
3968 (struct bidi_it): New member `string'. Make flag members be 1-bit
3969 fields, and put them last in the struct.
640c8776
SM
3970 (compute_display_string_pos, compute_display_string_end):
3971 Update prototypes.
0bb23927
EZ
3972 (bidi_push_it, bidi_pop_it): Add prototypes.
3973 (struct iterator_stack_entry): New members bidi_p,
3974 paragraph_embedding, and from_disp_prop_p.
3975 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3976 (bidi_shelve_cache, bidi_unshelve_cache):
3977 Declare prototypes.
0bb23927
EZ
3978
3979 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3980 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3981 and vector-like objects.
3982
3983 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3984 cache around display iteration.
3985
3986 * window.c (Fwindow_end, window_scroll_pixel_based)
3987 (displayed_window_lines, Frecenter): Save and restore the bidi
3988 cache around display iteration.
3989
3bbd2265
LMI
39902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3991
3992 * editfns.c (Fdelete_region): Clarify the use of the named
3993 parameters (bug#6788).
3994
adc47434
MR
39952011-07-14 Martin Rudalics <rudalics@gmx.at>
3996
3997 * indent.c (Fvertical_motion): Set and restore w->pointm when
3998 saving and restoring the window's buffer (Bug#9006).
3999
837c31f8
LMI
40002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4001
4002 * editfns.c (Fstring_to_char): Clarify just what is returned
4003 (bug#6576). Text by Eli Zaretskii.
4004
ac389d0c
JB
40052011-07-13 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4008
0be0ce47
EZ
40092011-07-13 Eli Zaretskii <eliz@gnu.org>
4010
4011 * buffer.c (mmap_find): Fix a typo.
4012
cd18e7e3
JB
40132011-07-13 Johan Bockgård <bojohan@gnu.org>
4014
4015 Fix execution of x selection hooks.
4016 * xselect.c (Qx_lost_selection_functions)
4017 (Qx_sent_selection_functions): New vars.
4018 (syms_of_xselect): DEFSYM them.
4019 (x_handle_selection_request): Pass Qx_sent_selection_functions
4020 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4021 (x_handle_selection_clear,x_clear_frame_selections):
4022 Pass Qx_lost_selection_functions rather than
4023 Vx_lost_selection_functions to Frun_hook_with_args.
4024
47ea7f44
PE
40252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4026
ac389d0c 4027 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4028 The old code sometimes used this field without initializing it.
4029
47ea7f44
PE
4030 * alloc.c (gc_sweep): Don't read past end of array.
4031 In theory, the old code could also have corrupted Emacs internals,
4032 though it'd be very unlikely.
4033
bc985c87
AS
40342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4035
4036 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4037 argument. (Bug#4026)
bc985c87 4038
0cf34688
LMI
40392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4040
b3dadd76
LMI
4041 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4042 key" (bug#4257).
4043
0cf34688
LMI
4044 * window.c (Fset_window_start): Doc fix (bug#4199).
4045 (Fset_window_hscroll): Ditto.
4046
270768cd
PE
40472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4048
077e3dda 4049 Fix minor new problems caught by GCC 4.6.1.
270768cd 4050 * term.c (init_tty): Remove unused local.
490011a6 4051 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4052 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4053 not used otherwise.
270768cd 4054
b1f58454
CY
40552011-07-12 Chong Yidong <cyd@stupidchicken.com>
4056
4057 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4058
22b9578d
LMI
40592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4060
6e70ab07
LMI
4061 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4062 are the mini-buffer and the echo area (bug#3320).
4063
22b9578d
LMI
4064 * term.c (init_tty): Remove support for supdup, c10 and perq
4065 terminals, which are no longer supported (bug#1482).
4066
8974cc9f
JB
40672011-07-10 Johan Bockgård <bojohan@gnu.org>
4068
4069 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4070
a560d974
JD
40712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4072
4073 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4074 for non-popups (Bug#3642).
4075
1dae0f0a
AS
40762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4077
268c2c36 4078 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4079 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4080 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4081 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4082 * data.c (fmod): Likewise.
4083 * dispnew.c (swap_glyphs_in_rows): Likewise.
4084 * emacs.c (memory_warning_signal): Likewise.
4085 * floatfns.c (float_error): Likewise.
4086 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4087 (otf_open, font_otf_capability, generate_otf_features)
4088 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4089 Likewise.
4090 * image.c (pbm_read_file): Likewise.
4091 * indent.c (string_display_width): Likewise.
4092 * intervals.c (check_for_interval, search_for_interval)
4093 (inc_interval_count, count_intervals, root_interval)
4094 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4095 * lread.c (defalias): Likewise.
268c2c36 4096 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4097 * regex.c (set_image_of_range_1, set_image_of_range)
4098 (regex_grow_registers): Likewise.
4099 * sysdep.c (strerror): Likewise.
4100 * termcap.c (valid_filename_p, tprint, main): Likewise.
4101 * tparam.c (main): Likewise.
4102 * unexhp9k800.c (run_time_remap, save_data_space)
4103 (update_file_ptrs, read_header, write_header, calculate_checksum)
4104 (copy_file, copy_rest, display_header): Likewise.
4105 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4106 Likewise.
4107 * xdisp.c (check_it): Likewise.
4108 * xfaces.c (register_color, unregister_color, unregister_colors):
4109 Likewise.
4110 * xfns.c (print_fontset_result): Likewise.
4111 * xrdb.c (member, fatal, main): Likewise.
4112
99033785
PE
41132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4114
4115 Fix minor problems found by static checking (Bug#9031).
4116 * chartab.c (char_table_set_range, map_sub_char_table):
4117 Remove unused locals.
4118 (uniprop_table): Now static.
4119 * composite.c (_work_char): Remove unused static var.
4120
9cb2ac56
JB
41212011-07-09 Juanma Barranquero <lekktu@gmail.com>
4122
4123 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4124
f25661f0
JD
41252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4126
4127 * gtkutil.c (qttip_cb): Remove code without function.
4128
8278c4fe
EZ
41292011-07-09 Eli Zaretskii <eliz@gnu.org>
4130
4131 * w32.c (pthread_sigmask): New stub.
4132
1692ae2d 41332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4134
8a6ebd58 4135 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4136 sigprocmask is portable only for single-threaded applications, and
4137 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4138 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4139 (LIBES): Use it.
4140 * callproc.c (Fcall_process):
4141 * process.c (create_process):
4142 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4143 Use pthread_sigmask, not sigprocmask.
123403e4 4144
1b854618
JD
41452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4146
4147 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4148 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4149 wrong (Bug#8591).
4150
3fe4b549
JD
41512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4152
0ce7e563
JD
4153 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4154 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4155 (xg_hide_tooltip): Fix comment.
4156
3fe4b549
JD
4157 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4158 in registerServicesMenuSendTypes.
4159 (validRequestorForSendType): Don't check ns_return_types.
4160
4161 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4162 ns_return_type.
4163
5df75e47
JR
41642011-07-08 Jason Rumney <jasonr@gnu.org>
4165
22610910
JR
4166 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4167 SH_SHOW for hidden windows (Bug#5482).
4168
5df75e47
JR
4169 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4170 frame struct members of non-existent frames (Bug#6284).
4171
699c10bd
JD
41722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4173
4393663b
JD
4174 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4175 variable firstTime not needed on OSX >= 10.6.
4176 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4177 >= 10.5. Use setKnobProportion, setDoubleValue.
4178
4179 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4180 (MAC_OS_X_VERSION_10_5): Define if not defined.
4181 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4182 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4183 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4184
4185 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4186 cString and lossyCString on OSX >= 10.4
4187
58179cce 4188 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4189 sizeToFit on OSX >= 10.2.
4190
4191 * nsimage.m (allocInitFromFile): Don't use deprecated method
4192 bestRepresentationForDevice on OSX >= 10.6.
4193
4194 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4195 to avoid warning.
4196
4197 * emacs.c: Declare unexec_init_emacs_zone.
4198
a63e0781
JD
4199 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4200
699c10bd
JD
4201 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4202
4203 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4204 on svcsMenu (Bug#8842).
4205
4206 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4207 ns_return_types.
4208 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4209
4210 * nsterm.m (QUTF8_STRING): Declare.
4211 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4212 (validRequestorForSendType): Return type is (id).
4213 Change indexOfObjectIdenticalTo to indexOfObject.
4214 Check if we have local selection before returning self (Bug#8842).
4215 (writeSelectionToPasteboard): Put local selection into paste board
4216 if we have a local selection (Bug#8842).
4217 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4218
4219 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4220 (ns_get_local_selection): Declare.
4221
54e10184
LMI
42222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4223
9888ff71
LMI
4224 * keymap.c (describe_map_tree): Don't insert a double newline at
4225 the end of the buffer (bug#1169) and return whether we inserted
4226 something.
4227
54e10184
LMI
4228 * callint.c (Fcall_interactively): Change "reading args" to
4229 "providing args" to try to clarify what it does (bug#1010).
4230
15fa4783
KH
42312011-07-07 Kenichi Handa <handa@m17n.org>
4232
4233 * composite.c (composition_compute_stop_pos): Ignore a static
4234 composition starting before CHARPOS (Bug#8915).
4235
4236 * xdisp.c (handle_composition_prop): Likewise.
4237
a8815b00
EZ
42382011-07-07 Eli Zaretskii <eliz@gnu.org>
4239
4240 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4241 (Bug#9015)
4242
ef7b981d 42432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4244
4245 * character.h (unicode_category_t): New enum type.
4246
4247 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4248 (Qchar_code_property_table): New variable.
4249 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4250 (UNIPROP_COMPRESSED_FORM_P): New macros.
4251 (char_table_ascii): Uncompress the compressed values.
4252 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4253 Uncompress the compressed values.
ac389d0c 4254 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4255 (char_table_ref_and_range): Uncompress the compressed values.
4256 (sub_char_table_set): New arg is_uniprop. Callers changed.
4257 Uncompress the compressed values.
4258 (sub_char_table_set_range): Args changed. Callers changed.
4259 (char_table_set_range): Adjuted for the above change.
4260 (map_sub_char_table): Delete args default_val and parent. Add arg
4261 top. Give decoded values to a Lisp function.
640c8776 4262 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4263 values to a Lisp function. Gcpro more variables.
4264 (uniprop_table_uncompress)
4265 (uniprop_decode_value_run_length): New functions.
4266 (uniprop_decoder, uniprop_decoder_count): New variables.
4267 (uniprop_get_decoder, uniprop_encode_value_character)
4268 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4269 New functions.
4270 (uniprop_encoder, uniprop_encoder_count): New variables.
4271 (uniprop_get_encoder, uniprop_table)
4272 (Funicode_property_table_internal, Fget_unicode_property_internal)
4273 (Fput_unicode_property_internal): New functions.
4274 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4275 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4276 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4277 char-code-property-alist.
4278
640c8776 4279 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4280 Vunicode_category_table.
4281
640c8776 4282 * font.c (font_range): Adjust for the change of
c805dec0
KH
4283 Vunicode_category_table.
4284
76b397fb
DN
42852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4286
4287 * m/iris4d.h: Remove file, move contents ...
4288 * s/irix6-5.h: ... here.
4289
22b4128e
PE
42902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4293 * alloc.c (mark_buffer):
4294 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4295 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4296 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4297 This isn't true in general, and it's particularly not true
4298 if Emacs is configured with --with-wide-int.
4299 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4300 New macros, used in the buffer.c change.
4301
869795d6
JD
43022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4303
4304 * xsettings.c: Use both GConf and GSettings if both are available.
4305 (store_config_changed_event): Add comment.
4306 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4307 (store_tool_bar_style_changed): New functions.
5e617bc2 4308 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4309 (struct xsettings): Move font inside HAVE_XFT.
4310 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4311 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4312 Move inside HAVE_XFT.
640c8776 4313 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4314 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4315 also.
4316 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4317 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4318 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4319 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4320 (parse_settings): Move check for font inside HAVE_XFT.
4321 (read_settings, apply_xft_settings): Add comment.
4322 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4323 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4324 call store_font_name_changed.
4325 (xft_settings_event): Add comment.
4326 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4327 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4328 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4329 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4330 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4331 (xsettings_get_system_font, xsettings_get_system_normal_font):
4332 Add comment.
869795d6 4333
d8ed26bd
PE
43342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4335
4336 Random fixes. E.g., (random) never returned negative values.
4337 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4338 subseconds part to the entropy, as that's a bit more random.
4339 Prefer signed to unsigned, since the signedness doesn't matter and
4340 in general we prefer signed. When given a limit, use a
4341 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4342 latter isn't right if USE_2_TAGS_FOR_INTS.
4343 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4344 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4345
cabf1cac
SM
43462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4347
4348 * textprop.c (text_property_stickiness):
4349 Obey Vtext_property_default_nonsticky.
4350 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4351 * w32fns.c (syms_of_w32fns):
4352 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4353
6e9b2be9
PE
43542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4355
4356 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4357 This is more efficient than Ffile_directory_p and avoids a minor race.
4358
90186c68
LMI
43592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4360
7c301272
LMI
4361 * buffer.c (Foverlay_put): Say what the return value is
4362 (bug#7835).
4363
c4f2d8d4
LMI
4364 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4365 is a directory before asking whether to use the file name
4366 (bug#7564).
ad637907
LMI
4367 (barf_or_query_if_file_exists): Make the "File is a directory"
4368 error be more correct.
c4f2d8d4 4369
90186c68
LMI
4370 * fns.c (Frequire): Remove the mention of the .gz files, since
4371 that's installation-specific, but keep the mention of
4372 `get-load-suffixes'.
4373
da64016e
PE
43742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4377 Report string overflow if the output is too long.
4378
7d47b580
JB
43792011-07-04 Juanma Barranquero <lekktu@gmail.com>
4380
a555cb87
JB
4381 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4382 (syms_of_gnutls): Remove duplicate DEFSYM for
4383 Qgnutls_bootprop_verify_hostname_error, an error for
4384 Qgnutls_bootprop_verify_error (which is no longer used).
4385
7d47b580
JB
4386 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4387 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4388 Also (re)move comments that are misplaced or no longer relevant.
4389
1e49bfab
LMI
43902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4391
4392 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4393
1485f4c0
CY
43942011-07-03 Chong Yidong <cyd@stupidchicken.com>
4395
4396 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4397 and background color parameters if they have been changed.
4398
a9ab721e
LMI
43992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4400
4401 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4402
cf7cff57
PE
44032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4404
2e13213d
PE
4405 * xsettings.c (SYSTEM_FONT): Define only when used.
4406 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4407
cf7cff57
PE
4408 * keymap.c (access_keymap_1): Now static.
4409
7a8e04f7
CY
44102011-07-02 Chong Yidong <cyd@stupidchicken.com>
4411
4412 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4413 leave any prefix arg for the up event (Bug#1586).
4414
61352f62
LMI
44152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4416
69bb1ef7
LMI
4417 * lread.c (syms_of_lread): Mention single symbols defined by
4418 `defvar' or `defconst' (bug#7154).
4419
61352f62 4420 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4421 (Frequire): Mention get-load-suffixes.
61352f62 4422
28545e04
MR
44232011-07-02 Martin Rudalics <rudalics@gmx.at>
4424
4425 * window.h (window): Remove clone_number slot.
4426 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4427 Remove.
4428 (make_parent_window, make_window, saved_window)
4429 (Fset_window_configuration, save_window_save): Don't deal with
4430 clone numbers.
4431 * buffer.c (Qclone_number): Remove declaration.
4432 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4433
3349e122
SM
44342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4435
4436 Add multiple inheritance to keymaps.
4437 * keymap.c (Fmake_composed_keymap): New function.
4438 (Fset_keymap_parent): Simplify.
4439 (fix_submap_inheritance): Remove.
4440 (access_keymap_1): New function extracted from access_keymap to handle
4441 embedded parents and handle lists of maps.
4442 (access_keymap): Use it.
4443 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4444 (Fcopy_keymap): Handle embedded parents.
4445 (Fcommand_remapping, define_as_prefix): Simplify.
4446 (Fkey_binding): Simplify.
4447 (syms_of_keymap): Move minibuffer-local-completion-map,
4448 minibuffer-local-filename-completion-map,
4449 minibuffer-local-must-match-map, and
4450 minibuffer-local-filename-must-match-map to Elisp.
4451 (syms_of_keymap): Defsubr make-composed-keymap.
4452 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4453 (parse_menu_item): Trivial simplification.
4454
3279eb87
GM
44552011-07-01 Glenn Morris <rgm@gnu.org>
4456
4457 * Makefile.in (SETTINGS_LIBS): Fix typo.
4458
4550efdf
KI
44592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4460
4461 * coding.c (Fencode_coding_string): Record the last coding system
4462 used, as the function doc string says (bug#8738).
4463
0949d2b6
JD
44642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4465
4466 * xsettings.c (store_monospaced_changed): Take new font as arg and
4467 check for change against current_mono_font.
4468 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4469 (emacs_settings_constructor, emacs_settings_get_property)
4470 (emacs_settings_set_property, emacs_settings_class_init)
4471 (emacs_settings_init, gsettings_obj): Remove.
4472 (something_changedCB): New function for HAVE_GSETTINGS.
4473 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4474 with value as argument.
4475 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4476 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4477 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4478 "changed".
4479
4480 * xgselect.c: Add defined (HAVE_GSETTINGS).
4481 (xgselect_initialize): Ditto.
4482
4483 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4484 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4485 xg_select.
4486
bbc6b304
PE
44872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4488
4489 * eval.c (struct backtrace): Simplify and port the data structure.
4490 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4491 signed bit field, as this assumption is not portable and it makes
4492 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4493 "char debug_on_exit : 1" as this is not portable either; instead,
4494 use the portable "unsigned int debug_on_exit : 1". Remove unused
4495 member evalargs. Remove obsolete comments about cc bombing out.
4496
9851bfc5
JD
44972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4498
51bb811f 4499 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4500 Let HAVE_GSETTINGS override HAVE_GCONF.
4501 (store_monospaced_changed): New function.
4502 (EMACS_SETTINGS): A new type derived from GObject to handle
4503 GSettings notifications.
4504 (emacs_settings_constructor, emacs_settings_get_property)
4505 (emacs_settings_set_property, emacs_settings_class_init):
4506 New functions.
4507 (gsettings_client, gsettings_obj): New variables.
4508 (GSETTINGS_SCHEMA): New define.
4509 (something_changedCB): Call store_monospaced_changed.
4510 (init_gsettings): New function.
4511 (xsettings_initialize): Call init_gsettings.
4512 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4513 to NULL.
4514
640c8776 4515 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4516 GCONF_CFLAGS/LIBS.
4517
5386012d
MR
45182011-06-29 Martin Rudalics <rudalics@gmx.at>
4519
4520 * window.c (resize_root_window, grow_mini_window)
4521 (shrink_mini_window): Rename Qresize_root_window to
4522 Qwindow_resize_root_window and Qresize_root_window_vertically to
4523 Qwindow_resize_root_window_vertically.
4524
f13e0b08
PE
45252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4526
4527 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4528
94515237
JB
45292011-06-27 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * makefile.w32-in: Redesign dependencies so they reflect more
4532 clearly which files are directly included by each source file,
4533 and not through other includes.
4534
e43b6e43
MR
45352011-06-27 Martin Rudalics <rudalics@gmx.at>
4536
4537 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4538 (sort_overlays, overlay_strings): When an overlay's clone number
4539 matches the window's clone number process the overlay even if
4540 the overlay's window property doesn't match the current window.
4541
d68443dc
MR
4542 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4543 (Fwindow_hchild): Rename to Fwindow_left_child.
4544 (Fwindow_next): Rename to Fwindow_next_sibling.
4545 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4546 (resize_window_check): Rename to window_resize_check.
4547 (resize_window_apply): Rename to window_resize_apply.
4548 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4549 (Fdelete_other_windows_internal, resize_frame_windows)
4550 (Fsplit_window_internal, Fdelete_window_internal)
4551 (grow_mini_window, shrink_mini_window)
4552 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4553
c7e73be5
JD
45542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4555
4556 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4557 (emacs_fixed_set_min_size): Remove.
4558 (emacs_fixed_new): Take frame as argument.
4559
4560 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4561 (_EmacsFixedPrivate): Remove minwidth/height.
4562 Add struct frame *f.
4563 (emacs_fixed_init): Initialize priv->f.
4564 (get_parent_class, emacs_fixed_set_min_size): Remove.
4565 (emacs_fixed_new): Set priv->f to argument.
4566 (emacs_fixed_get_preferred_width)
4567 (emacs_fixed_get_preferred_height): Use min_width/height from
4568 frames size_hint to set minimum and natural (Bug#8919).
4569 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4570 and use min_width/height from frames size_hint to set
4571 min_width/height (Bug#8919).
4572
4573 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4574 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4575 Fix indentation.
c7e73be5 4576
cf99dcf8
EZ
45772011-06-26 Eli Zaretskii <eliz@gnu.org>
4578
4579 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4580 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4581 called at ZV.
4582
029529ac
CY
45832011-06-26 Chong Yidong <cyd@stupidchicken.com>
4584
4585 * process.c (wait_reading_process_output): Bypass select if
4586 waiting for a cell while ignoring keyboard input, and input is
4587 pending. Suggested by Jan Djärv (Bug#8869).
4588
7a7ef429
PE
45892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4590
4591 Use gnulib's dup2 module instead of rolling our own.
4592 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4593
11fdef7d 45942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4595
4596 * dispnew.c (scrolling_window): Before scrolling, turn off a
4597 mouse-highlight in the window being scrolled.
4598
cd3520a4
JB
45992011-06-24 Juanma Barranquero <lekktu@gmail.com>
4600
4601 Move DEFSYM to lisp.h and use everywhere.
4602
4603 * character.h (DEFSYM): Move declaration...
4604 * lisp.h (DEFSYM): ...here.
4605
4606 * gnutls.c:
4607 * minibuf.c:
4608 * w32menu.c:
4609 * w32proc.c:
4610 * w32select.c: Don't include character.h.
4611
4612 * alloc.c (syms_of_alloc):
4613 * buffer.c (syms_of_buffer):
4614 * bytecode.c (syms_of_bytecode):
4615 * callint.c (syms_of_callint):
4616 * casefiddle.c (syms_of_casefiddle):
4617 * casetab.c (init_casetab_once):
4618 * category.c (init_category_once, syms_of_category):
4619 * ccl.c (syms_of_ccl):
4620 * cmds.c (syms_of_cmds):
4621 * composite.c (syms_of_composite):
4622 * dbusbind.c (syms_of_dbusbind):
4623 * dired.c (syms_of_dired):
4624 * dispnew.c (syms_of_display):
4625 * doc.c (syms_of_doc):
4626 * editfns.c (syms_of_editfns):
4627 * emacs.c (syms_of_emacs):
4628 * eval.c (syms_of_eval):
4629 * fileio.c (syms_of_fileio):
4630 * fns.c (syms_of_fns):
4631 * frame.c (syms_of_frame):
4632 * fringe.c (syms_of_fringe):
4633 * insdel.c (syms_of_insdel):
4634 * keymap.c (syms_of_keymap):
4635 * lread.c (init_obarray, syms_of_lread):
4636 * macros.c (syms_of_macros):
4637 * msdos.c (syms_of_msdos):
4638 * print.c (syms_of_print):
4639 * process.c (syms_of_process):
4640 * search.c (syms_of_search):
4641 * sound.c (syms_of_sound):
4642 * syntax.c (init_syntax_once, syms_of_syntax):
4643 * terminal.c (syms_of_terminal):
4644 * textprop.c (syms_of_textprop):
4645 * undo.c (syms_of_undo):
4646 * w32.c (globals_of_w32):
4647 * window.c (syms_of_window):
4648 * xdisp.c (syms_of_xdisp):
4649 * xfaces.c (syms_of_xfaces):
4650 * xfns.c (syms_of_xfns):
4651 * xmenu.c (syms_of_xmenu):
4652 * xsettings.c (syms_of_xsettings):
4653 * xterm.c (syms_of_xterm): Use DEFSYM.
4654
4228cf16
TZ
46552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4656
cd3520a4 4657 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4658
7fcccf1e
PE
46592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4660
7efb4e0e
PE
4661 Integer and buffer overflow fixes (Bug#8873).
4662
ff5844ad
PE
4663 * print.c (printchar, strout): Check for string overflow.
4664 (PRINTPREPARE, printchar, strout):
4665 Don't set size unless allocation succeeds.
4666
90532f02
PE
4667 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4668 for sizes. Check for string overflow more accurately.
4669 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4670
6d84508d
PE
4671 * macros.c: Integer and buffer overflow fixes.
4672 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4673 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4674 Use ptrdiff_t, not int, for sizes.
4675 Don't increment bufsize until after realloc succeeds.
4676 Check for size-calculation overflow.
4677 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4678
437b2cb4
PE
4679 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4680
8b9ac8b4
PE
4681 * lread.c: Integer overflow fixes.
4682 (read_integer): Radix is now EMACS_INT, not int,
4683 to improve quality of diagnostics for out-of-range radices.
4684 Calculate buffer size correctly for out-of-range radices.
4685 (read1): Check for integer overflow in radices, and in
4686 read-circle numbers.
82cb60d3
PE
4687 (read_escape): Avoid int overflow.
4688 (Fload, openp, read_buffer_size, read1)
4689 (substitute_object_recurse, read_vector, read_list, map_obarray):
4690 Use ptrdiff_t, not int, for sizes.
4691 (read1): Use EMACS_INT, not int, for sizes.
20270765 4692 Check for size overflow.
8b9ac8b4 4693
7fcccf1e
PE
4694 * image.c (cache_image): Check for size arithmetic overflow.
4695
bfbbd7e7
PE
4696 * lread.c: Integer overflow issues.
4697 (saved_doc_string_size, saved_doc_string_length)
4698 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4699 Now ptrdiff_t, not int.
4700 (read1): Don't assume doc string length fits in int. Check for
4701 out-of-range doc string lengths.
4702 (read_list): Don't assume file position fits in int.
39019e54 4703 (read_escape): Check for hex character overflow.
bfbbd7e7 4704
4e323265
LL
47052011-06-22 Leo Liu <sdl.web@gmail.com>
4706
4707 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4708 Move to minibuffer.el.
4709
85fece3e
PE
47102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4711
20b84ce9 4712 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4713 The following patches are for when GLYPH_DEBUG && !XASSERT.
4714 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4715 * dispnew.c (flush_stdout):
4716 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4717 Mark as externally visible.
4718 * dispnew.c (check_window_matrix_pointers): Now static.
4719 * dispnew.c (window_to_frame_vpos):
4720 * xfns.c (unwind_create_frame):
4721 * xterm.c (x_check_font): Remove unused local.
4722 * scroll.c (CHECK_BOUNDS):
4723 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4724 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4725 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4726 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4727 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4728 Now static.
4729 (debug_method_add): Use va_list and vsprintf rather than relying
4730 on undefined behavior with wrong number of arguments.
4731 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4732 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4733 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4734 since we're not interested in debugging glyphs with old libraries.
4735 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4736 GCC 4.6.0's static checking.
4737
0766b489
PE
47382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4739
31fd4b32
PE
4740 Integer overflow and signedness fixes (Bug#8873).
4741 A few related buffer overrun fixes, too.
4742
b79e8648
PE
4743 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4744
0766b489
PE
4745 * dispextern.h (struct face.stipple):
4746 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4747 (x_bitmap_mask, x_allocate_bitmap_record)
4748 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4749 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4750 (x_create_bitmap_from_xpm_data):
4751 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4752 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4753 (.bitmaps_last):
4754 * xfaces.c (load_pixmap):
4755 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4756 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4757 (.bitmaps_last, struct x_output.icon_bitmap):
4758 Use ptrdiff_t, not int, for bitmap indexes.
4759 (x_allocate_bitmap_record): Check for size overflow.
4760 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4761
b081724f
PE
4762 Use ptrdiff_t, not int, for overlay counts.
4763 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4764 * editfns.c (overlays_around, get_pos_property):
4765 * textprop.c (get_char_property_and_overlay):
4766 * xdisp.c (next_overlay_change, note_mouse_highlight):
4767 * xfaces.c (face_at_buffer_position):
21514da7
PE
4768 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4769 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4770 (Fnext_overlay_change, Fprevious_overlay_change)
4771 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4772 Use ptrdiff_t, not int, for sizes.
21514da7 4773 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4774
3de73e5e
PE
4775 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4776
2606c57b
PE
4777 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4778 (x_session_initialize): Do not assume string length fits in int.
4779
aaafe47a
PE
4780 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4781 This is unlikely, but can occur if DPI is outlandish.
4782
2674ddc8 4783 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4784 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4785
28154962
PE
4786 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4787 * xrdb.c (magic_file_p, search_magic_path):
4788 Omit last arg SUFFIX; it was always 0. All callers changed.
4789 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4790
7de51af5
PE
4791 * xfont.c (xfont_match): Avoid need for strlen.
4792
25ed6cc3
PE
4793 * xfns.c: Don't assume strlen fits in int.
4794 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4795
4eab31dd
PE
4796 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4797 not unsigned long, as we prefer signed integers. All callers changed.
4798 Detect integer overflow in repeat count.
4799 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4800 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4801
171e2a58
PE
4802 * termcap.c: Don't assume sizes fit in int and never overflow.
4803 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4804 (gobble_line): Check for size-calculation overflow.
4805
ad39faca 4806 * minibuf.c (Fread_buffer):
6e5bb2dc 4807 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4808 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4809 Don't assume string length fits in int.
4810
52c61c22 4811 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4812 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4813
b5b8c9e5
PE
4814 * font.c: Don't assume string length fits in int.
4815 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4816 Use ptrdiff_t, not int.
ccd6111c
PE
4817 (font_intern_prop): Don't assume string length fits in int.
4818 Don't assume integer property fits in fixnum.
4819 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4820
882f0d81 4821 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4822 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4823 Reformulate so as not to need the command string.
4824 Invoke gzip -cd rather than gunzip, as it's more portable.
4825 (lock_info_type, lock_file_1, lock_file):
4826 Don't assume pid_t and time_t fit in unsigned long.
4827 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4828 (current_lock_owner): Prefer signed type for sizes.
4829 Use memcpy, not strncpy, where memcpy is what is really wanted.
4830 Don't assume (via atoi) that time_t and pid_t fit in int.
4831 Check for time_t and/or pid_t out of range, e.g., via a network share.
4832 Don't alloca where an auto var works fine.
4833
93f4cf88
PE
4834 * fileio.c: Fix some integer overflow issues.
4835 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4836 Don't assume string length fits in int.
4837 (directory_file_name): Don't assume string length fits in long.
4838 (make_temp_name): Don't assume pid fits in int, or that its print
4839 length is less than 20.
4840
f3e92b69
PE
4841 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4842
1bfdaf10
PE
4843 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4844
35016e9a
PE
4845 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4846
3d1e65a1
PE
4847 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4848 We prefer signed integers, even for size calculations.
4849
0b963a93
PE
4850 * emacs.c: Don't assume string length fits in 'int'.
4851 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4852 (main): Don't invoke strlen when not needed.
4853
573f4b54
PE
4854 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4855 (XD_DEBUG_MESSAGE): Don't waste a byte.
4856
989f33ba
PE
4857 * callproc.c (getenv_internal_1, getenv_internal)
4858 (Fgetenv_internal):
965d34eb
PE
4859 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4860
e4d29b33
PE
4861 * lread.c (invalid_syntax): Omit length argument.
4862 All uses changed. This doesn't fix a bug, but it simplifies the
4863 code away from its former Hollerith-constant appearance, and it's
4864 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4865 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4866
eb49b136
PE
4867 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4868 This didn't break anything, but it didn't help either.
4869 It's confusing to put a bogus integer in a place where the actual
4870 value does not matter.
9f62aeb1 4871 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4872 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4873
15375a22
PE
4874 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4875 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4876 implementation.
b61cc01c
PE
4877 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4878 We prefer signed types, and the value cannot exceed the EMACS_INT
4879 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4880 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4881 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4882 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4883
53b2623d
PE
4884 * indent.c (sane_tab_width): New function.
4885 (current_column, scan_for_column, Findent_to, position_indentation)
4886 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4887 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4888
51cab52b 4889 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4890
f2ed8a70
PE
4891 * lisp.h (lint_assume): New macro.
4892 * composite.c (composition_gstring_put_cache):
4893 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4894
abe80cc6
PE
4895 * editfns.c, insdel.c:
4896 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4897
b02c740e
PE
4898 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4899
ebc96716
PE
4900 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4901
b4e50fa0 4902 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4903 Use much-faster test for byte-length change.
311d5d7c 4904 Don't assume string byte-length fits in 'int'.
a4cf38e4 4905 Check that character arg fits in 'int'.
85461888 4906 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4907
c0c1ee9f
PE
4908 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4909
a498d7f4
PE
4910 * fns.c (concat): Catch string overflow earlier.
4911 Do not rely on integer wraparound.
4912
51cab52b
PE
4913 * dispextern.h (struct it.overlay_strings_charpos)
4914 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4915 * xdisp.c (forward_to_next_line_start)
4916 (back_to_previous_visible_line_start)
4917 (reseat_at_next_visible_line_start, next_element_from_buffer):
4918 Don't arbitrarily truncate the value of 'selective' to int.
4919
76031fad
PE
4920 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4921
5eb55db9
PE
4922 * composite.c: Don't truncate sizes to 'int'.
4923 (composition_gstring_p, composition_reseat_it)
4924 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4925 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4926 not EMACS_UINT, for indexes.
5eb55db9 4927
0703a717
PE
4928 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4929
d6202519
PE
4930 * buffer.c: Include <verify.h>.
4931 (struct sortvec.priority, struct sortstr.priority):
8961a454 4932 Now EMACS_INT, not int.
c20998a7 4933 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4934 (struct sortstr.size, record_overlay_string)
4935 (struct sortstrlist.size, struct sortlist.used):
4936 Don't truncate size to int.
4937 (record_overlay_string): Check for size-calculation overflow.
d6202519 4938 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4939
d5a19415
JM
49402011-06-22 Jim Meyering <meyering@redhat.com>
4941
029529ac 4942 Don't leak an XBM-image-sized buffer
d5a19415
JM
4943 * image.c (xbm_load): Free the image buffer after using it.
4944
a9041e6c
PE
49452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4946
4947 Port to Sun C.
4948 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4949 that Sun C diagnosed.
4950 * fns.c (secure_hash): Fix pointer signedness issue.
4951 * intervals.c (static_offset_intervals): New function.
4952 (offset_intervals): Use it.
4953
7f3f739f
LL
49542011-06-21 Leo Liu <sdl.web@gmail.com>
4955
4956 * deps.mk (fns.o):
4957 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4958 sha512.h.
4959
4960 * fns.c (secure_hash): Rename from crypto_hash_function and change
4961 the first arg to accept symbols.
5b66d427 4962 (Fsecure_hash): New primitive.
7f3f739f
LL
4963 (syms_of_fns): New symbols.
4964
76147d94
DD
49652011-06-20 Deniz Dogan <deniz@dogan.se>
4966
4967 * process.c (Fset_process_buffer): Clarify return value in
4968 docstring.
4969
7d7d0045
CY
49702011-06-18 Chong Yidong <cyd@stupidchicken.com>
4971
4972 * dispnew.c (add_window_display_history): Use BVAR.
4973
4974 * xdisp.c (debug_method_add): Use BVAR.
4975 (check_window_end, dump_glyph_matrix, dump_glyph)
4976 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4977
4978 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4979 Likewise.
4980
4981 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4982 check till after the cache is created in init_frame_faces.
4983
ff2bc410
SM
49842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4985
4986 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4987
28177add
PE
49882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4989
dd3482fe
PE
4990 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4991 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4992 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4993
393d71f3 4994 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4995 * fileio.c (Finsert_file_contents):
4996 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4997 Remove the old (too-loose) buffer overflow checks.
4998 They weren't needed, since make_gap checks for buffer overflow.
4999 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5000 The old code merely checked for Emacs fixnum overflow, and relied
5001 on undefined (wraparound) behavior. The new code avoids undefined
5002 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5003
2e6813b0 5004 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5005 Tune. Don't use wider integers than needed. Don't use alloca.
5006 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5007
599a9e4f
PE
5008 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5009
99561444
PE
5010 * insdel.c, lisp.h (buffer_overflow): New function.
5011 (insert_from_buffer_1, replace_range, replace_range_2):
5012 * insdel.c (make_gap_larger):
5013 * editfns.c (Finsert_char):
5014 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5015
28177add
PE
5016 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5017
e69dafad
PE
50182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5019
4baa020d 5020 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5021
b1c46f02
PE
5022 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5023 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5024
e69dafad
PE
5025 * fileio.c: Don't assume EMACS_INT fits in off_t.
5026 (emacs_lseek): New static function.
5027 (Finsert_file_contents, Fwrite_region): Use it.
5028 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5029
566684ea
PE
5030 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5031
e6966cd6
PE
5032 * fns.c: Don't overflow int when computing a list length.
5033 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5034 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5035 truncation on 64-bit hosts. Check for QUIT every
5036 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5037 faster and is responsive enough.
5038 (Flength): Report an error instead of overflowing an integer.
5039 (Fsafe_length): Return a float if the value is not representable
5040 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5041 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5042 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5043
dd0b0efb
PE
5044 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5045 (header_size, word_size): New constants.
5046 (allocate_vectorlike): Don't check size overflow here.
5047 (allocate_vector): Check it here instead, since this is the only
5048 caller of allocate_vectorlike that could cause overflow.
5049 Check that the new vector's length is representable as a fixnum.
5050
86fe5cfe
PE
5051 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5052 The previous code was bogus. For example, next_almost_prime (32)
5053 returned 39, which is undesirable as it is a multiple of 3; and
5054 next_almost_prime (24) returned 25, which is a multiple of 5 so
5055 why was the code bothering to check for multiples of 7?
5056
80e88859
PE
5057 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5058
4a2f0ad6
PE
5059 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5060
f66c7cf8
PE
5061 Variadic C functions now count arguments with ptrdiff_t.
5062 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5063 Back then I didn't know that the Emacs coding style prefers signed int.
5064 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5065 were being counted with int, which may truncate counts on 64-bit
5066 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5067 * lisp.h (struct Lisp_Subr.function.aMANY)
5068 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5069 Arg counts are now ptrdiff_t, not size_t.
5070 All variadic functions and their callers changed accordingly.
5071 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5072 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5073 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5074 * callint.c (Fcall_interactively): Check arg count for overflow,
5075 to avoid potential buffer overrun. Use signed char, not 'int',
5076 for 'varies' array, so that we needn't bother to check its size
5077 calculation for overflow.
5078 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5079 * eval.c (apply_lambda):
5080 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5081 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5082 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5083
a1759b76
PE
5084 * callint.c (Fcall_interactively): Don't use index var as event count.
5085
d96be9fc
PE
5086 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5087 * mem-limits.h (SIZE): Remove; no longer used.
5088
a690a978 5089 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5090
578c21e6
PE
5091 Remove unnecessary casts.
5092 * xterm.c (x_term_init):
5093 * xfns.c (x_set_border_pixel):
5094 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5095 These aren't needed now that we assume ANSI C.
5096
96f53c6c
PE
5097 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5098 It's more likely to cause problems (due to unsigned overflow)
5099 than to cure them.
5100
83c77d31
PE
5101 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5102
ee2079f1
PE
5103 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5104
6da65536
PE
5105 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5106
7147c4a4
PE
5107 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5108
193e32d9
PE
5109 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5110
e5533da6
PE
5111 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5112
9910e595
PE
5113 GLYPH_CODE_FACE returns EMACS_INT, not int.
5114 * dispextern.h (merge_faces):
5115 * xfaces.c (merge_faces):
01103c44
PE
5116 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5117 Don't assume EMACS_INT fits in int.
9910e595 5118
2638320e
PE
5119 * character.h (CHAR_VALID_P): Remove unused parameter.
5120 * fontset.c, lisp.h, xdisp.c: All uses changed.
5121
045eb8d9
PE
5122 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5123
c1f134b5
PE
5124 * fns.c (concat): Minor tuning based on overflow analysis.
5125 This doesn't fix any bugs. Use int to hold character, instead
5126 of constantly refetching from Emacs object. Use XFASTINT, not
5127 XINT, for value known to be a character. Don't bother comparing
5128 a single byte to 0400, as it's always less.
5129
395fcb93 5130 * floatfns.c (Fexpt):
327eeec8
PE
5131 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5132
abbd3d23
PE
5133 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5134 for characters.
5135
684a03ef
PE
5136 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5137
0fed43f3
PE
5138 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5139 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5140 incorrectly succeed when S was a string, because 4294967386 was
5141 truncated before it was used.
5142
8fd02eb7
PE
5143 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5144 Otherwise, an out-of-range integer could cause undefined behavior
5145 on a 64-bit host.
5146
f8c86b69
PE
5147 * composite.c: Use int, not EMACS_INT, for characters.
5148 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5149 EMACS_INT, for values that are known to be in character range.
5150 This doesn't fix any bugs but is the usual style inside Emacs and
5151 may generate better code on 32-bit machines.
5152
34206dd2
PE
5153 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5154 This is for reasons similar to the recent CHAR_STRING fix.
5155 * charset.c (Fencode_char): Check that character arg is actually
5156 a character. Pass an int to ENCODE_CHAR.
5157 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5158 wider than 'int', as a compile-time check to prevent future regressions
5159 in this area.
5160
c5958d4c 5161 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5162
5163 Make sure a 64-bit char is never passed to CHAR_STRING.
5164 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5165 by silently ignoring the top 32 bits, allowing some values
5166 that were far too large to be valid characters.
5167 * character.h: Include <verify.h>.
5168 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5169 arguments are no wider than unsigned, as a compile-time check
5170 to prevent future regressions in this area.
5171 * data.c (Faset):
01103c44 5172 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5173 (Fsubst_char_in_region):
5174 * fns.c (concat):
5175 * xdisp.c (decode_mode_spec_coding):
5176 Adjust to CHAR_STRING's new requirement.
5177 * editfns.c (Finsert_char, Fsubst_char_in_region):
5178 * fns.c (concat): Check that character args are actually
5179 characters. Without this test, these functions did the wrong
5180 thing with wildly out-of-range values on 64-bit hosts.
5181
d37ca623
PE
5182 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5183 These casts should not be needed on 32-bit hosts, either.
5184 * keyboard.c (read_char):
5185 * lread.c (Fload): Remove casts to unsigned.
5186
ea204efb
PE
5187 * lisp.h (UNSIGNED_CMP): New macro.
5188 This fixes comparison bugs on 64-bit hosts.
5189 (ASCII_CHAR_P): Use it.
5190 * casefiddle.c (casify_object):
01103c44 5191 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5192 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5193 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5194 * dispextern.h (FACE_FROM_ID):
5195 * keyboard.c (read_char): Use UNSIGNED_CMP.
5196
41cb286c
PE
5197 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5198 not to EMACS_INT, to avoid GCC warning.
5199
4a1b9832
PE
5200 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5201
55daad71
PE
5202 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5203 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5204 isn't needed on 32-bit machines.
8f95c75c 5205
01103c44
PE
5206 * buffer.c (Fgenerate_new_buffer_name):
5207 Use EMACS_INT for count, not int.
0ceccced 5208 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5209
5210 * data.c (Qcompiled_function): Now static.
5211
c6f072e7
PE
5212 * window.c (window_body_lines): Now static.
5213
20ce5912
PE
5214 * image.c (gif_load): Rename local to avoid shadowing.
5215
9c4c5f81
PE
5216 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5217 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5218 * alloc.c (make_save_value): Integer argument is now of type
5219 ptrdiff_t, not int.
5220 (mark_object): Use ptrdiff_t, not int.
5221 * lisp.h (pD): New macro.
5222 * print.c (print_object): Use it.
5223
c0c5c8ae
PE
5224 * alloc.c: Use EMACS_INT, not int, to count objects.
5225 (total_conses, total_markers, total_symbols, total_vector_size)
5226 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5227 (total_free_floats, total_floats, total_free_intervals)
5228 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5229 Now EMACS_INT, not int. All uses changed.
5230 (Fgarbage_collect): Compute overall total using a double, so that
5231 integer overflow is less likely to be a problem. Check for overflow
5232 when converting back to an integer.
5a25e253
PE
5233 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5234 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5235 These were 'int' variables that could overflow on 64-bit hosts;
5236 they were never used, so remove them instead of repairing them.
211a0b2a 5237 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5238 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5239 Previously, this ceilinged at INT_MAX, but that doesn't work on
5240 64-bit machines.
e46bb31a 5241 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5242
c78baabf 5243 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5244 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5245 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5246 when a (possibly-narrower) signed value would do just as well.
5247 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5248
c9d624c6
PE
5249 * alloc.c: Catch some string size overflows that we were missing.
5250 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5251 for convenience in STRING_BYTES_MAX.
5252 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5253 The definition here is exact; the one in lisp.h was approximate.
5254 (allocate_string_data): Check for string overflow. This catches
5255 some instances we weren't catching before. Also, it catches
5256 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5257 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5258 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5259
c9d624c6
PE
5260 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5261 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5262 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5263
353032ce
PE
5264 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5265
2bccce07
PE
5266 * alloc.c (Fmake_string): Check for out-of-range init.
5267
0ac30604
SM
52682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5269
5270 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5271
c195f2de
JD
52722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5273
5274 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5275 xg_get_default_scrollbar_width.
5276
5277 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5278 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5279 (style_changed_cb): Call update_theme_scrollbar_width and call
5280 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5281 all frames (Bug#8505).
5282 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5283 Call gtk_window_set_resizable if HAVE_GTK3.
5284 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5285 and height if HAVE_GTK3 (Bug#8505).
5286 (scroll_bar_width_for_theme): New variable.
5287 (update_theme_scrollbar_width): New function.
5288 (xg_get_default_scrollbar_width): Move code to
5289 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5290 (xg_initialize): Call update_theme_scrollbar_width.
5291
5292 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5293
5294 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5295
e10ac9f1
MR
52962011-06-12 Martin Rudalics <rudalics@gmx.at>
5297
5298 * frame.c (make_frame): Call other_buffer_safely instead of
5299 other_buffer.
5300
5301 * window.c (temp_output_buffer_show): Call display_buffer with
5302 second argument Vtemp_buffer_show_specifiers and reset latter
5303 immediately after the call.
5304 (Vtemp_buffer_show_specifiers): New variable.
5305 (auto_window_vscroll_p, next_screen_context_lines)
5306 (Vscroll_preserve_screen_position): Remove leading asterisks from
5307 doc-strings.
5308
2d3c217e 53092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5310
7b7f97e8 5311 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5312 * buffer.c (Qclone_number): Remove for now, as it's unused.
5313 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5314 (record_buffer): Remove unused local.
5315 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5316 (set_frame_buffer_list): Remove; unused.
5317 * frame.h (other_visible_frames): Remove decl.
5318 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5319 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5320 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5321 if HAVE_GPM.
5322 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5323 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5324 Define only if HAVE_GPM.
5325 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5326 (update_hints_inhibit): Remove; never set. All uses removed.
5327 * widgetprv.h (emacsFrameClassRec): Remove decl.
5328 * window.c (delete_deletable_window): Now returns void, since it
5329 wasn't returning anything.
5330 (compare_window_configurations): Remove unused locals.
5331 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5332 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5333 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5334 the same widths as pointers. This follows up on the 2011-05-06 patch.
5335 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5336 * xterm.h: Likewise.
5337 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5338
1384b89e
JB
53392011-06-12 Juanma Barranquero <lekktu@gmail.com>
5340
5341 * makefile.w32-in: Update dependencies.
5342 (LISP_H): Add lib/intprops.h.
5343
1100a63c
CY
53442011-06-11 Chong Yidong <cyd@stupidchicken.com>
5345
5346 * image.c (gif_load): Add animation frame delay to the metadata.
5347 (syms_of_image): Use DEFSYM. New symbol `delay'.
5348
6198ccd0
MR
53492011-06-11 Martin Rudalics <rudalics@gmx.at>
5350
5351 * window.c (delete_deletable_window): Re-add.
5352 (Fset_window_configuration): Rewrite to handle dead buffers and
5353 consequently deletable windows.
5354 (window_tree, Fwindow_tree): Remove. Supply functionality in
5355 window.el.
5356 (compare_window_configurations): Simplify code.
5357
b6e3633c
AS
53582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5359
1ab0dee5
AS
5360 * image.c (imagemagick_load_image): Fix type mismatch.
5361 (Fimagemagick_types): Likewise.
5362
b6e3633c
AS
5363 * window.h (replace_buffer_in_windows): Declare.
5364
9397e56f
MR
53652011-06-11 Martin Rudalics <rudalics@gmx.at>
5366
5367 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5368 Qclone_number. Remove external declaration of Qdelete_window.
5369 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5370 code.
640c8776
SM
5371 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5372 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5373 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5374 buffer list implementation.
5375 (other_buffer_safely): New function.
5376 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5377 calls to replace_buffer_in_windows and
5378 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5379 if allowed.
5380 (record_buffer): Inhibit quitting and rewrite using quittable
5381 functions. Run Qbuffer_list_update_hook if allowed.
5382 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5383 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5384 Move switch-to-buffer to window.el.
9397e56f
MR
5385 (bury-buffer): Move to window.el.
5386 (Vbuffer_list_update_hook): New variable.
5387
5388 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5389 section.
5390
5391 * window.h (resize_frame_windows): Move up in code.
5392 (Fwindow_frame): Remove EXFUN.
5393 (replace_buffer_in_all_windows): Remove prototype.
5394 (replace_buffer_in_windows_safely): Add prototype.
5395
5396 * window.c: Declare Qdelete_window static again. Move down
5397 declaration of select_count.
5398 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5399 (Fother_window): Move to window.el.
5400 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5401 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5402 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5403 window.el.
5404 (replace_buffer_in_windows): Implement by calling
5405 Qreplace_buffer_in_windows.
5406 (replace_buffer_in_all_windows): Remove with some functionality
5407 moved into replace_buffer_in_windows_safely.
5408 (replace_buffer_in_windows_safely): New function.
5409 (select_window_norecord, select_frame_norecord): Move in front
5410 of run_window_configuration_change_hook. Remove now obsolete
5411 declarations.
640c8776
SM
5412 (Fset_window_buffer): Rewrite doc-string.
5413 Call Qrecord_window_buffer.
9397e56f
MR
5414 (keys_of_window): Move binding for other-window to window.el.
5415
b50691aa
CY
54162011-06-11 Chong Yidong <cyd@stupidchicken.com>
5417
5418 * dispextern.h (struct image): Replace data member, whose int_val
5419 and ptr_val fields were not used by anything, with a single
5420 lisp_val object.
5421
5422 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5423 (gif_clear_image, gif_load, imagemagick_load_image)
5424 (gs_clear_image, gs_load): Callers changed.
5425
3f754b86
PE
54262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5427
cca69397
PE
5428 * buffer.h: Include <time.h>, for time_t.
5429 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5430
109e28d0
PE
5431 Fix minor problems found by static checking.
5432
60737f02
PE
5433 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5434
4b66faf3
PE
5435 Make identifiers static if they are not used in other modules.
5436 * data.c (Qcompiled_function, Qframe, Qvector):
5437 * image.c (QimageMagick, Qsvg):
5438 * minibuf.c (Qmetadata):
5439 * window.c (resize_window_check, resize_root_window): Now static.
5440 * window.h (resize_window_check, resize_root_window): Remove decls.
5441
109e28d0
PE
5442 * window.c (window_deletion_count, delete_deletable_window):
5443 Remove; unused.
46a4ce9e
PE
5444 (window_body_lines): Now static.
5445 (Fdelete_other_windows_internal): Mark vars as initialized.
5446 Make sure 'resize_failed' is initialized.
5447 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5448 (resize_window_apply): Remove unused local.
5449 * window.h (delete_deletable_window): Remove decl.
5450
109e28d0 5451 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5452 (imagemagick_load_image): Fix pointer signedness problem by changing
5453 last arg from unsigned char * to char *. All uses changed.
5454 Also, fix a local for similar reasons.
5455 Remove unused locals. Remove locals to avoid shadowing.
5456 (fn_rsvg_handle_free): Remove; unused.
5457 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5458 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5459
3f754b86
PE
5460 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5461
2547adb1
CY
54622011-06-10 Chong Yidong <cyd@stupidchicken.com>
5463
5464 * image.c (gif_load): Fix omitted cast error introduced by
5465 2011-06-06 change.
5466
2c8e37d4
MR
54672011-06-10 Martin Rudalics <rudalics@gmx.at>
5468
5469 * window.h (resize_proportionally, orig_total_lines)
5470 (orig_top_line): Remove from window structure.
5471 (set_window_height, set_window_width, change_window_heights)
5472 (Fdelete_window): Remove prototypes.
5473 (resize_frame_windows): Remove duplicate declaration.
5474
440a42e3
EZ
54752011-06-10 Eli Zaretskii <eliz@gnu.org>
5476
5477 * window.h (resize_frame_windows, resize_window_check)
5478 (delete_deletable_window, resize_root_window)
5479 (resize_frame_windows): Declare prototypes.
5480
5481 * window.c (resize_window_apply): Make definition be "static" to
5482 match the prototype.
5483
562dd5e9
MR
54842011-06-10 Martin Rudalics <rudalics@gmx.at>
5485
5486 * window.c: Remove declarations of Qwindow_size_fixed,
5487 window_min_size_1, window_min_size_2, window_min_size,
5488 size_window, window_fixed_size_p, enlarge_window, delete_window.
5489 Remove static from declaration of Qdelete_window, it's
5490 temporarily needed by Fbury_buffer.
5491 (replace_window): Don't assign orig_top_line and
5492 orig_total_lines.
5493 (Fdelete_window, delete_window): Remove. Window deletion is
5494 handled by window.el.
640c8776
SM
5495 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5496 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5497 (Fdelete_other_windows): Remove. Deleting other windows is
5498 handled by window.el.
5499 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5500 handled in window.el.
5501 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5502 Window minimum sizes are handled in window.el.
5503 (shrink_windows, size_window, set_window_height)
5504 (set_window_width, change_window_heights, window_height)
5505 (window_width, CURBEG, CURSIZE, enlarge_window)
5506 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5507 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5508 handled in window.el.
5509 (make_dummy_parent): Rename to make_parent_window and give it a
5510 second argument horflag.
5511 (make_window): Don't set resize_proportionally any more.
5512 (Fsplit_window): Remove. Windows are split in window.el.
5513 (save_restore_action, save_restore_orig_size)
5514 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5515 Resize mini windows in window.el.
5516 (grow_mini_window, shrink_mini_window): Implement by calling
5517 Qresize_root_window_vertically, resize_window_check and
5518 resize_window_apply.
640c8776
SM
5519 (saved_window, Fset_window_configuration, save_window_save):
5520 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5521 resize_proportionally.
5522 (window_min_height, window_min_width): Move to window.el.
5523 (keys_of_window): Move bindings for delete-other-windows,
5524 split-window, delete-window and enlarge-window to window.el.
5525
5526 * buffer.c: Temporarily extern Qdelete_window.
5527 (Fbury_buffer): Temporarily call Qdelete_window instead of
5528 Fdelete_window (Fbury_buffer will move to window.el soon).
5529
5530 * frame.c (set_menu_bar_lines_1): Remove code handling
5531 orig_top_line and orig_total_lines.
5532
5533 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5534 set_window_height but set heights directly.
5535 (change_frame_size_1): Use resize_frame_windows.
5536
5537 * xdisp.c (init_xdisp): Don't use set_window_height but set
5538 heights directly.
5539
640c8776
SM
5540 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5541 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5542 run_window_configuration_change_hook.
5543
5544 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5545 instead of change_window_heights and run
5546 run_window_configuration_change_hook.
5547
1a13852e
MR
55482011-06-09 Martin Rudalics <rudalics@gmx.at>
5549
5550 * window.c (replace_window): Rename second argument REPLACEMENT to
5551 NEW. New third argument SETFLAG. Rewrite.
5552 (delete_window, make_dummy_parent): Call replace_window with
5553 third argument 1.
5554 (window_list_1): Move down in code.
5555 (run_window_configuration_change_hook): Move set_buffer part
5556 before select_frame_norecord part in order to unwind correctly.
5557 Rename count1 to count.
5558 (recombine_windows, delete_deletable_window, resize_root_window)
5559 (Fdelete_other_windows_internal)
5560 (Frun_window_configuration_change_hook, make_parent_window)
5561 (resize_window_check, resize_window_apply, Fresize_window_apply)
5562 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5563 (Fdelete_window_internal, Fresize_mini_window_internal):
5564 New functions.
1a13852e
MR
5565 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5566
f3d1777e
MR
55672011-06-08 Martin Rudalics <rudalics@gmx.at>
5568
496e208e
MR
5569 * window.h (window): Add some new members to window structure -
5570 normal_lines, normal_cols, new_total, new_normal, clone_number,
5571 splits, nest, prev_buffers, next_buffers.
5572 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5573 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5574
f3d1777e
MR
5575 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5576 Remove.
496e208e
MR
5577 (make_dummy_parent): Set new members of windows structure.
5578 (make_window): Move down in code. Handle new members of window
5579 structure.
5580 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5581 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5582 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5583 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5584 (Fset_window_next_buffers, Fset_window_clone_number):
5585 New functions.
496e208e
MR
5586 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5587 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5588 Doc-string fixes.
5589 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5590 Argument WINDOW can be now internal window too.
5591 (Fwindow_use_time): Move up in code.
5592 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5593 Rewrite doc-string.
5594 (Fset_window_configuration, saved_window)
5595 (Fcurrent_window_configuration, save_window_save): Handle new
5596 members of window structure.
b9e809c2
MR
5597 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5598 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5599 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5600 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5601 Qget_mru_window, Qresize_root_window,
5602 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5603 Qauto_buffer_name; staticpro them.
f3d1777e 5604
abde8f8c
MR
56052011-06-07 Martin Rudalics <rudalics@gmx.at>
5606
5607 * window.c (Fwindow_total_size, Fwindow_left_column)
5608 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5609 (Fwindow_list_1): New functions.
5610 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5611 (Fwindow_width, Fscroll_left, Fscroll_right):
5612 Use window_body_cols instead of window_box_text_cols.
5613 (delete_window, Fset_window_configuration):
5614 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5615 (delete_all_subwindows): Take a window as argument and not a
5616 structure. Rewrite.
190b47e6
MR
5617 (window_loop): Remove handling of GET_LRU_WINDOW and
5618 GET_LARGEST_WINDOW.
5619 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5620
5621 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5622 window_box_text_cols. delete_all_subwindows now takes a
5623 Lisp_Object as argument.
abde8f8c 5624
640c8776
SM
5625 * indent.c (compute_motion, Fcompute_motion):
5626 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5627
fa8a67e6
MR
5628 * frame.c (delete_frame): Call delete_all_subwindows with root
5629 window as argument.
5630
a54e3482
DC
56312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5632
5633 * fns.c (Fputhash): Document return value.
5634
60002bf5
CY
56352011-06-06 Chong Yidong <cyd@stupidchicken.com>
5636
5637 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5638
0c671da6 56392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5640
b862a52a 5641 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5642
be44ca6c
PE
5643 Check for overflow when converting integer to cons and back.
5644 * charset.c (Fdefine_charset_internal, Fdecode_char):
5645 Use cons_to_unsigned to catch overflow.
5646 (Fencode_char): Use INTEGER_TO_CONS.
5647 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5648 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5649 * data.c (long_to_cons, cons_to_long): Remove.
5650 (cons_to_unsigned, cons_to_signed): New functions.
5651 These signal an error for invalid or out-of-range values.
5652 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5653 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5654 * font.c (Ffont_variation_glyphs):
5655 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5656 * lisp.h: Include <intprops.h>.
5657 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5658 (cons_to_signed, cons_to_unsigned): New decls.
5659 (long_to_cons, cons_to_long): Remove decls.
5660 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5661 (Fprimitive_undo): Use CONS_TO_INTEGER.
5662 * xfns.c (Fx_window_property): Likewise.
5663 * xselect.c: Include <limits.h>.
5664 (x_own_selection, selection_data_to_lisp_data):
5665 Use INTEGER_TO_CONS.
5666 (x_handle_selection_request, x_handle_selection_clear)
5667 (x_get_foreign_selection, Fx_disown_selection_internal)
5668 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5669 (lisp_data_to_selection_data): Use cons_to_unsigned.
5670 (x_fill_property_data): Use cons_to_signed.
5671 Report values out of range.
5672
d1f3d2af
PE
5673 Check for buffer and string overflow more precisely.
5674 * buffer.h (BUF_BYTES_MAX): New macro.
5675 * lisp.h (STRING_BYTES_MAX): New macro.
5676 * alloc.c (Fmake_string):
5677 * character.c (string_escape_byte8):
5678 * coding.c (coding_alloc_by_realloc):
5679 * doprnt.c (doprnt):
5680 * editfns.c (Fformat):
5681 * eval.c (verror):
5682 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5683 since they may not be the same number.
5684 * editfns.c (Finsert_char):
5685 * fileio.c (Finsert_file_contents):
5686 Likewise for BUF_BYTES_MAX.
5687
dd52fcea
PE
5688 * image.c: Use ptrdiff_t, not int, for sizes.
5689 (slurp_file): Switch from int to ptrdiff_t.
5690 All uses changed.
5691 (slurp_file): Check that file size fits in both size_t (for
5692 malloc) and ptrdiff_t (for sanity and safety).
5693
7f9bbdbb
PE
5694 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5695 if b->modtime has its maximal value.
5696
dfe18f82
PE
5697 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5698
84acfcf0
PE
5699 Don't assume time_t can fit into int.
5700 * buffer.h (struct buffer.modtime): Now time_t, not int.
5701 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5702 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5703
ccd9a01a
PE
5704 Minor fixes for signed vs unsigned integers.
5705 * character.h (MAYBE_UNIFY_CHAR):
5706 * charset.c (maybe_unify_char):
5707 * keyboard.c (read_char, reorder_modifiers):
5708 XINT -> XFASTINT, since the integer must be nonnegative.
5709 * ftfont.c (ftfont_spec_pattern):
5710 * keymap.c (access_keymap, silly_event_symbol_error):
5711 XUINT -> XFASTINT, since the integer must be nonnegative.
5712 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5713 since it makes no difference and we prefer signed.
5714 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5715 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5716 nonnegative.
5717
d6d100dd
SM
57182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5719
5720 * window.h (Fwindow_frame): Declare.
5721
2b6148e4
PE
57222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5725 (SPARE_MEMORY): Always define.
5726 (LARGE_REQUEST): Remove.
5727 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5728
f230ecc9
MR
57292011-06-06 Martin Rudalics <rudalics@gmx.at>
5730
727e958e
MR
5731 * lisp.h: Move EXFUNS for Fframe_root_window,
5732 Fframe_first_window and Fset_frame_selected_window to window.h.
5733
5734 * window.h: Move EXFUNS for Fframe_root_window,
5735 Fframe_first_window and Fset_frame_selected_window here from
5736 lisp.h.
5737
5738 * frame.c (Fwindow_frame, Fframe_first_window)
5739 (Fframe_root_window, Fframe_selected_window)
5740 (Fset_frame_selected_window): Move to window.c.
5741 (Factive_minibuffer_window): Move to minibuf.c.
5742 (Fother_visible_frames_p): New function.
5743
5744 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5745
f230ecc9
MR
5746 * window.c (decode_window, decode_any_window): Move up in code.
5747 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5748 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5749 (Fwindow_buffer): Move up and rewrite doc-string.
5750 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5751 (Fwindow_prev): New functions.
727e958e
MR
5752 (Fwindow_frame): Move here from frame.c. Accept any window as
5753 argument.
5754 (Fframe_root_window, Fframe_first_window)
5755 (Fframe_selected_window): Move here from frame.c. Accept frame
5756 or arbitrary window as argument. Update doc-strings.
5757 (Fminibuffer_window): Move up in code.
5758 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5759 (Fset_frame_selected_window): Move here from frame.c.
5760 Marginal rewrite.
727e958e
MR
5761 (Fselected_window, select_window, Fselect_window): Move up in
5762 code. Minor doc-string fixes.
f230ecc9 5763
4d09bcf6
PE
57642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5767 Do not assume that spare memory exists; that assumption is valid
5768 only if SYSTEM_MALLOC.
5769 (LARGE_REQUEST): New macro, so that the issue of large requests
5770 is separated from the issue of spare memory.
5771
810928a2
AS
57722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5773
172418ad
AS
5774 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5775 format. (Bug#8806)
5776
43f862f7
AS
5777 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5778
810928a2
AS
5779 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5780 before statements.
5781
a059fe24
JD
57822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5783
5784 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5785
5786 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5787
5788 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5789 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5790
989bf368
JB
57912011-06-05 Juanma Barranquero <lekktu@gmail.com>
5792
5793 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5794
4b80f674
CY
57952011-06-04 Chong Yidong <cyd@stupidchicken.com>
5796
5797 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5798 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5799 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5800 New error handlers.
4b80f674
CY
5801 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5802 Obey Vx_select_enable_clipboard_manager. Catch errors in
5803 x_clipboard_manager_save (Bug#8779).
5804 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5805 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5806
99a33b77 58072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5808
5809 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5810
99a33b77 58112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5812
5813 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5814 in the current matrix if keep_current_p is non-zero.
5815
8264569d
EZ
58162011-06-04 Eli Zaretskii <eliz@gnu.org>
5817
5818 * bidi.c (bidi_level_of_next_char): Fix last change.
5819
57f97249
EZ
58202011-06-03 Eli Zaretskii <eliz@gnu.org>
5821
fec2107c 5822 Support bidi reordering of text covered by display properties.
57f97249 5823
fec2107c
EZ
5824 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5825 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5826 (bidi_cache_search, bidi_cache_iterator_state)
5827 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5828 (bidi_level_of_next_char, bidi_move_to_visually_next):
5829 Support character positions inside a run of characters covered by a
fec2107c
EZ
5830 display string.
5831 (bidi_paragraph_init, bidi_resolve_explicit_1)
5832 (bidi_level_of_next_char): Call bidi_fetch_char and
5833 bidi_fetch_char_advance instead of FETCH_CHAR and
5834 FETCH_CHAR_ADVANCE.
5835 (bidi_init_it): Initialize new members.
5836 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5837 definitions.
5838 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5839 instead of using explicit *_CHAR codes.
d6d100dd
SM
5840 (bidi_resolve_explicit, bidi_resolve_weak):
5841 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5842 bidirectional text is supported only in multibyte buffers.
5843 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5844 it to initialize the frame_window_p member of struct bidi_it.
5845 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5846 (bidi_resolve_explicit, bidi_resolve_weak)
5847 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5848 bidi_it->nchars is non-positive.
5849 (bidi_level_of_next_char): Don't try to lookup the cache for the
5850 next/previous character if nothing is cached there yet, or if we
5851 were just reseat()'ed to a new position.
c40e2fb2 5852
0e14fe90
EZ
5853 * xdisp.c (set_cursor_from_row): Set start and stop points
5854 according to the row's direction when priming the loop that looks
5855 for the glyph on which to display cursor.
5856 (single_display_spec_intangible_p): Function deleted.
5857 (display_prop_intangible_p): Reimplement to call
5858 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5859 Accept 3 additional arguments needed by handle_display_spec.
5860 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5861 values: lists, `(when COND...)' forms, etc.
5862 (single_display_spec_string_p): Support property values that are
5863 lists with the argument STRING its top-level element.
5864 (display_prop_string_p): Fix the condition for processing a
5865 property that is a list to be consistent with handle_display_spec.
fec2107c 5866 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5867 last portion of handle_display_prop.
5868 (compute_display_string_pos): Accept additional argument
5869 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5870 value of a `display' property is a "replacing spec".
5871 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5872 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5873 the display property, but just return a value indicating whether
5874 the display property will replace the characters it covers.
5875 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5876 frame_window_p members of struct bidi_it.
d6d100dd
SM
5877 (compute_display_string_pos, compute_display_string_end):
5878 New functions.
fec2107c
EZ
5879 (push_it): Accept second argument POSITION, where pop_it should
5880 jump to continue iteration.
5881 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5882
fec2107c
EZ
5883 * keyboard.c (adjust_point_for_property): Adjust the call to
5884 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5885
5886 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5887 (bidi_init_it): Update prototypes.
5888 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5889 (compute_display_string_pos, compute_display_string_end):
5890 Declare prototypes.
fec2107c
EZ
5891 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5892 EMACS_INT.
fc6f18ce 5893
40087514 58942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5895
57f53182
PE
5896 Malloc failure behavior now depends on size of allocation.
5897 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5898 * lisp.h: Change signatures accordingly.
5899 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5900 All callers changed. (Bug#8762)
5901
5902 * gnutls.c: Use Emacs's memory allocators.
5903 Without this change, the gnutls library would invoke malloc etc.
5904 directly, which causes problems on non-SYNC_INPUT hosts, and which
5905 runs afoul of improving memory_full behavior. (Bug#8761)
5906 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5907 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5908 xfree instead of the default malloc, realloc, free.
5909 (Fgnutls_boot): No need to check for memory allocation failure,
5910 since xmalloc does that for us.
5911
ac32cd99 5912 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5913 * category.c (hash_get_category_set):
5914 * ccl.c (ccl_driver):
5915 * charset.c (Fdefine_charset_internal):
5916 * charset.h (struct charset.hash_index):
5917 * composite.c (get_composition_id, gstring_lookup_cache)
5918 (composition_gstring_put_cache):
5919 * composite.h (struct composition.hash_index):
5920 * dispextern.h (struct image.hash):
5921 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5922 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5923 (hashfn_equal, hashfn_user_defined, make_hash_table)
5924 (maybe_resize_hash_table, hash_lookup, hash_put)
5925 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5926 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5927 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5928 * image.c (make_image, search_image_cache, lookup_image)
5929 (xpm_put_color_table_h):
5930 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5931 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5932 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5933 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5934 * alloc.c (allocate_vectorlike):
5935 Check for overflow in vector size calculations.
5936 * ccl.c (ccl_driver):
5937 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5938 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5939 need to be updated by these changes.
40087514
PE
5940 * fns.c (make_hash_table, maybe_resize_hash_table):
5941 Check for integer overflow with large hash tables.
0de4bb68
PE
5942 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5943 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5944 (SXHASH_REDUCE): New macro.
5945 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5946 Use it instead of discarding useful hash info with large hash values.
5947 (sxhash_float): New function.
5948 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5949 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5950 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5951 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5952 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5953 Adjust signatures to match updated version of code.
5954 (consing_since_gc): Now EMACS_INT, since a single hash table can
5955 use more than INT_MAX bytes.
5956
698d32e2
DN
59572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5958
5959 Make it possible to build with GCC-4.6+ -O2 -flto.
5960
5961 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5962
fd6fa53f
SM
59632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5964
5965 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5966 Call minibuffer-inactive-mode.
5967
864db017
JB
59682011-05-31 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5971 Update dependencies.
5972
2ad0baf4
DN
59732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5974
5975 * data.c (init_data): Remove code for UTS, this system is not
5976 supported anymore.
5977
4fcc2638
DN
59782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5979
5980 Don't force ./temacs to start in terminal mode.
5981
5982 * frame.c (make_initial_frame): Initialize faces in all cases, not
5983 only when CANNOT_DUMP is defined.
5984 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5985
c56e0fd5
DN
59862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5987
5988 * dispnew.c (add_window_display_history): Use const for the string
5989 pointer. Remove declaration, not needed.
5990
333d54da 59912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5992
55d4c1b2 5993 Use 'inline', not 'INLINE'.
333d54da 5994 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5995 * alloc.c, fontset.c (INLINE): Remove.
5996 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5997 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5998 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5999 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6000 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6001
738db178
DN
60022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6003
6004 Make it possible to run ./temacs.
6005
6006 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6007 syms_of_callproc does the same thing. Remove test for
6008 "initialized", do it in the caller.
6009 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6010
620c53a6
SM
60112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6012
6013 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6014 (read_minibuf): Use get_minibuffer.
6015 (syms_of_minibuf): Use DEFSYM.
6016 (Qmetadata): New var.
6017 * data.c (Qbuffer): Don't make it static.
6018 (syms_of_data): Use DEFSYM.
6019
e003a292
PE
60202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6021
6022 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6023 (CCL_CODE_MIN): New macro.
6024
ed008a6d
PE
60252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6026
3687c2ef
PE
6027 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6028
ed008a6d
PE
6029 * eval.c (Qdebug): Now static.
6030 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6031 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6032 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6033
d66c4c7c
CY
60342011-05-29 Chong Yidong <cyd@stupidchicken.com>
6035
6036 * image.c: Various fixes to ImageMagick code comments.
6037 (Fimagemagick_types): Doc fix.
6038
5fbc2025
PE
60392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6040
0196f88a
PE
6041 Minor fixes prompted by GCC 4.6.0 warnings.
6042
6043 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6044
5fbc2025
PE
6045 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6046 (x_clipboard_manager_save_all): Move extern decl to ...
6047 * xterm.h: ... here, so that it can be checked for consistency.
6048
1dd3c2d9
CY
60492011-05-29 Chong Yidong <cyd@stupidchicken.com>
6050
6051 * xselect.c (x_clipboard_manager_save_frame)
6052 (x_clipboard_manager_save_all): New functions.
6053 (Fx_clipboard_manager_save): Lisp function deleted.
6054
6055 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6056 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6057
6058 * xterm.h: Update prototype.
6059
5ba6571d
WX
60602011-05-28 William Xu <william.xwl@gmail.com>
6061
6062 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6063 exiting (Bug#8239).
6064
3eaff834
JM
60652011-05-28 Jim Meyering <meyering@redhat.com>
6066
e1900994 6067 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6068 * fns.c (to_uchar): Define.
6069 (crypto_hash_function): Use it to convert some newly-signed
6070 variables to unsigned, to avoid sign-extension bugs. For example,
6071 without this change, (md5 "truc") would evaluate to
6072 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6073 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6074 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6075
0f6990a7
PE
60762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 Integer overflow fixes.
c8a9ca5a 6079
08686060
PE
6080 * dbusbind.c: Serial number integer overflow fixes.
6081 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6082 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6083 to hold a serial number that is too large for a fixnum.
6084 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6085 Check for serial numbers out of range. Decode any serial number
59568bf0 6086 that was so large that it became a float. (Bug#8722)
08686060 6087
2d1fc3c7
PE
6088 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6089 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6090 Use XFASTINT rather than XUINT when numbers are nonnegative.
6091 (xd_append_arg, Fdbus_method_return_internal):
6092 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6093 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6094 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6095 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6096 (Bug#8722)
2d1fc3c7 6097
c8a9ca5a
PE
6098 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6099
519e1d69
PE
6100 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6101
6df6ae42 6102 ccl: Add integer overflow checks.
30569699
PE
6103 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6104 (IN_INT_RANGE): New macros.
6105 (ccl_driver): Use them to check for integer overflow when
6106 decoding a CCL program. Many of the new checks are whether XINT (x)
6107 fits in int; it doesn't always, on 64-bit hosts. The new version
6108 doesn't catch all possible integer overflows, but it's an
847044ea 6109 improvement. (Bug#8719)
30569699 6110
c11285dc
PE
6111 * alloc.c (make_event_array): Use XINT, not XUINT.
6112 There's no need for unsigned here.
6113
fdccd48e
PE
6114 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6115 This follows up to the 2011-05-06 change that substituted uintptr_t
6116 for EMACS_INT. This case wasn't caught back then.
6117
37910ab2
PE
6118 Rework Fformat to avoid integer overflow issues.
6119 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6120 now (part of C89). Include <verify.h>.
6121 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6122 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6123 (Fformat): Avoid the prepass trying to compute sizes; it was only
6124 approximate and thus did not catch overflow reliably. Instead, walk
6125 through the format just once, formatting and computing sizes as we go,
6126 checking for integer overflow at every step, and allocating a larger
6127 buffer as needed. Keep track separately whether the format is
6128 multibyte. Keep only the most-recently calculated precision, rather
6129 than them all. Record whether each argument has been converted to
6130 string. Use EMACS_INT, not int, for byte and char and arg counts.
6131 Support field widths and precisions larger than INT_MAX. Avoid
6132 sprintf's undefined behavior with conversion specifications such as %#d
6133 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6134 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6135 formatting out-of-range floating point numbers with int
9173deec 6136 formats. (Bug#8668)
37910ab2 6137
2e6578fb
PE
6138 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6139
0ae6bdee
PE
6140 * data.c: Avoid integer truncation in expressions involving floats.
6141 * data.c: Include <intprops.h>.
6142 (arith_driver): When there's an integer overflow in an expression
6143 involving floating point, convert the integers to floating point
6144 so that the resulting value does not suffer from catastrophic
6145 integer truncation. For example, on a 64-bit host (* 4
6146 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6147 Do not rely on undefined behavior after integer overflow.
6148
de883a70
PE
6149 merge count_size_as_multibyte, parse_str_to_multibyte
6150 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6151 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6152 Check for integer overflow.
6153 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6154 since it's now a duplicate of the other. This is more of
6155 a character than a buffer op, so better that it's in character.c.
6156 * fns.c, print.c: Adjust to above changes.
6157
2ff916cb
PE
61582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6159
6160 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6161
f1b54466
PE
61622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6163
fb1ac845
PE
6164 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6165 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6166 (x_clipboard_manager_save): Now static.
6167 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6168
f1b54466
PE
6169 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6170 (crypto_hash_function): Now static.
6171 Fix pointer signedness problems. Avoid unnecessary initializations.
6172
a9f737ee
CY
61732011-05-27 Chong Yidong <cyd@stupidchicken.com>
6174
6175 * termhooks.h (Vselection_alist): Make it terminal-local.
6176
6177 * terminal.c (create_terminal): Initialize it.
6178
6179 * xselect.c: Support for clipboard managers.
6180 (Vselection_alist): Move to termhooks.h as terminal-local var.
6181 (LOCAL_SELECTION): New macro.
6182 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6183 (symbol_to_x_atom): Remove gratuitous arg.
6184 (x_handle_selection_request, lisp_data_to_selection_data)
6185 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6186 (x_own_selection, x_get_local_selection, x_convert_selection):
6187 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6188 (some_frame_on_display): Delete unused function.
6189 (Fx_own_selection_internal, Fx_get_selection_internal)
6190 (Fx_disown_selection_internal, Fx_selection_owner_p)
6191 (Fx_selection_exists_p): New optional frame arg.
6192 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6193 (x_handle_selection_clear): Don't treat other terminals with the
6194 same keyboard specially. Use the terminal-local Vselection_alist.
6195 (x_clear_frame_selections): Use Frun_hook_with_args.
6196
6197 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6198
6199 * xterm.h: Add support for those atoms.
6200
e067f0c1
CY
62012011-05-26 Chong Yidong <cyd@stupidchicken.com>
6202
6203 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6204 (converted_selections, conversion_fail_tag): New global variables.
6205 (x_selection_request_lisp_error): Free the above.
6206 (x_get_local_selection): Remove unnecessary code.
6207 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6208 of converted selections stored in converted_selections.
6209 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6210 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6211 (x_convert_selection): New function.
6212 (x_handle_selection_event): Simplify.
6213 (x_get_foreign_selection): Don't ignore incoming requests while
6214 waiting for an answer; this will fail when we implement
6215 SAVE_TARGETS, and seems unnecessary anyway.
6216 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6217 (Vx_sent_selection_functions): Doc fix.
6218
0f4aebc0
LL
62192011-05-26 Leo Liu <sdl.web@gmail.com>
6220
6221 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6222
e61124cd
YM
62232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6224
6225 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6226
6227 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6228 for fringe update if it has periodic bitmap.
ac389d0c 6229 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6230 and fringe_bitmap_periodic_p.
6231
6232 * fringe.c (get_fringe_bitmap_data): New function.
6233 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6234 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6235 row. Mark glyph row for fringe update if periodicity changed.
6236
6237 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6238 for fringe update unless it has periodic bitmap.
6239
f16d9837
KH
62402011-05-25 Kenichi Handa <handa@m17n.org>
6241
6242 * xdisp.c (get_next_display_element): Set correct it->face_id for
6243 a static composition.
6244
e1b90ef6
LL
62452011-05-24 Leo Liu <sdl.web@gmail.com>
6246
6247 * deps.mk (fns.o):
6248 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6249
6250 * fns.c (crypto_hash_function, Fsha1): New function.
6251 (Fmd5): Use crypto_hash_function.
6252 (syms_of_fns): Add Ssha1.
6253
7400048f
PE
62542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6255
6256 * gnutls.c: Remove unused macros.
6257 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6258 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6259 Remove macros that are defined and never used.
6260 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6261
abb71cf4
CY
62622011-05-22 Chong Yidong <cyd@stupidchicken.com>
6263
6264 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6265 (Fx_get_selection_internal): Minor cleanup.
6266 (Fx_own_selection_internal): Rename arguments for consistency with
6267 select.el.
6268
6307db39
PE
62692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6270
6271 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6272
f3d4e0a4
CY
62732011-05-22 Chong Yidong <cyd@stupidchicken.com>
6274
6275 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6276
4d8ade89
YM
62772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6278
6279 * dispnew.c (scrolling_window): Don't exclude the case that the
6280 last enabled row in the desired matrix touches the bottom boundary.
6281
32078c8d
GM
62822011-05-21 Glenn Morris <rgm@gnu.org>
6283
6284 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6285 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6286 and add some more files.
32078c8d 6287
7285dc67
EZ
62882011-05-20 Eli Zaretskii <eliz@gnu.org>
6289
6290 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6291 report_file_error introduced by the change from 2011-05-07.
6292
89d1bd22
PE
62932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 * systime.h (Time): Define only if emacs is defined.
6296 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6297 where the include path doesn't have X11/X.h by default. See
6298 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6299
cd394be1 63002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6301
6302 * composite.c (find_automatic_composition): Fix previous change.
6303
b9704ad9
GM
63042011-05-20 Glenn Morris <rgm@gnu.org>
6305
6306 * lisp.mk: New file, split from Makefile.in.
6307 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6308 (shortlisp): Remove.
6309 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6310
4a720484
GM
63112011-05-19 Glenn Morris <rgm@gnu.org>
6312
6313 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6314 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6315 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6316 (lisp): Set the order to that of loadup.el.
6317 (shortlisp): Make it a copy of $lisp.
6318 (SOME_MACHINE_LISP): Remove.
6319 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6320 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6321
a28d4396
KH
63222011-05-18 Kenichi Handa <handa@m17n.org>
6323
6324 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6325 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6326 (find_automatic_composition): Mostly rewrite for efficiency.
6327
a2b1fa8e
JB
63282011-05-18 Juanma Barranquero <lekktu@gmail.com>
6329
6330 * makefile.w32-in: Update dependencies.
6331
8e1f5610
CS
63322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6333
6334 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6335 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6336
7025ee00 63372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6338
cdfa6eab
PE
6339 Fix some integer overflow issues, such as string length overflow.
6340
06d6db33
PE
6341 * insdel.c (count_size_as_multibyte): Check for string overflow.
6342
2b4560a8
PE
6343 * character.c (lisp_string_width): Check for string overflow.
6344 Use EMACS_INT, not int, for string indexes and lengths; in
6345 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6346 the resulting string length overflows an EMACS_INT; instead,
6347 report a string overflow if no precision given. When checking for
6348 precision exhaustion, use a check that cannot possibly have
6349 integer overflow. (Bug#8675)
6350 * character.h (lisp_string_width): Adjust to new signature.
6351
cb93f9be
PE
6352 * alloc.c (string_overflow): New function.
6353 (Fmake_string): Use it. This doesn't change behavior, but saves
6354 a few bytes and will simplify future changes.
6355 * character.c (string_escape_byte8): Likewise.
6356 * lisp.h (string_overflow): New decl.
6357
1a1f3366
PE
6358 Fixups, following up to the user-interface timestamp change.
6359 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6360 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6361 * msdos.c (mouse_get_pos): Likewise.
6362 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6363 * w32gui.h (Time): Define by including "systime.h" rather than by
6364 declaring it ourselves. (Bug#8664)
6365
d4e3e4d3
PE
6366 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6367 * image.c (clear_image_cache): Likewise.
6368
f6a24d19
PE
6369 * term.c (term_mouse_position): Don't assume time_t wraparound.
6370
08dc5ae6
PE
6371 Be more systematic about user-interface timestamps.
6372 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6373 and sometimes 'EMACS_UINT', to represent these timestamps.
6374 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6375 This makes the code easier to follow, and makes it easier to catch
6376 integer overflow bugs such as Bug#8664.
6377 * frame.c (Fmouse_position, Fmouse_pixel_position):
6378 Use Time, not unsigned long, for user-interface timestamps.
6379 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6380 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6381 * keyboard.h (last_event_timestamp): Likewise.
6382 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6383 * menu.h (xmenu_show): Likewise.
6384 * term.c (term_mouse_position): Likewise.
6385 * termhooks.h (struct input_event.timestamp): Likewise.
6386 (struct terminal.mouse_position_hook): Likewise.
6387 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6388 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6389 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6390 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6391 what it was before.
6392 * menu.h, termhooks.h: Include "systime.h", for Time.
6393
8e55734a
PE
6394 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6395 Don't assume that the difference between two unsigned long values
6396 can fit into an integer. At this point, we know button_down_time
6397 <= event->timestamp, so the difference must be nonnegative, so
6398 there's no need to cast the result if double-click-time is
6399 nonnegative, as it should be; check that it's nonnegative, just in
6400 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6401 apart (about 25 days). (Bug#8664)
8e55734a 6402
841f1b75 6403 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6404 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6405
3e26f69c
PE
6406 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6407 that always fit in int. Use a sentinel instead of a counter, to
6408 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6409 * frame.h (struct frame): Use int for menu_bar_items_used
6410 instead of EMACS_INT, since it always fits in int.
3e26f69c 6411
5cc152c0
PE
6412 * menu.c (grow_menu_items): Check for int overflow.
6413
d89eb65e
PE
6414 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6415
5235bd3e
PE
6416 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6417 Before, the code was not consistent. These values cannot exceed
6418 2**31 - 1 so there's no need to make them unsigned.
6419 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6420 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6421 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6422 as modifiers.
6423 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6424
bc827e23
PE
6425 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6426 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6427 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6428 presumably because the widths might not match.
6429
78eb494e
PE
6430 * window.c (size_window): Avoid needless test at loop start.
6431
04f2d78b
CB
64322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6433
6434 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6435
d2fc7e3d 64362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6437
6438 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6439
d2fc7e3d 64402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6441
6442 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6443 `width' to `bar_area_x' and `bar_area_width', respectively.
6444 (x_scroll_run): Take account of fringe background extension.
6445
04f2d78b
CB
6446 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6447 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6448 `bar_area_width', respectively.
6449 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6450 background extension.
6451
79b70037
GM
64522011-05-10 Jim Meyering <meyering@redhat.com>
6453
6454 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6455
2f142cc5
JB
64562011-05-10 Juanma Barranquero <lekktu@gmail.com>
6457
6458 * image.c (Finit_image_library): Return t for built-in image types,
6459 like pbm and xbm. (Bug#8640)
6460
57679c86
AS
64612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6462
6463 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6464
888c9e86
EZ
64652011-05-07 Eli Zaretskii <eliz@gnu.org>
6466
b0512a1d
EZ
6467 * w32console.c (Fset_screen_color): Doc fix.
6468 (Fget_screen_color): New function.
6469 (syms_of_ntterm): Defsubr it.
6470
7285dc67
EZ
6471 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6472 unlink the temporary file if Fcall_process didn't create it in the
6473 first place.
6474 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6475 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6476 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6477 cue to call_process_cleanup not to close that handle.
6478
4d3fcc8e
BK
64792011-05-07 Ben Key <bkey76@gmail.com>
6480
6481 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6482 one of two shell specific rules, either bootstrap-temacs-CMD or
6483 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6484 to the previous implementation of the bootstrap-temacs rule.
6485 The bootstrap-temacs-CMD rule is similar to the previous
6486 implementation of the bootstrap-temacs rule except that it
6487 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6488 variable.
6489
6490 These changes, along with some changes to nt/configure.bat,
6491 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6492 earlier fix to add support for --cflags and --ldflags options
6493 that include quotes so that it works whether make uses cmd or
6494 sh as the shell.
6495
b4289b64
MA
64962011-05-06 Michael Albinus <michael.albinus@gmx.de>
6497
6498 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6499 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6500 is a constant.
6501 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6502 a string. Handle both cases.
6503 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6504 (Fdbus_register_method): Use Qinvalid_function.
6505
af4c0e28
JB
65062011-05-06 Juanma Barranquero <lekktu@gmail.com>
6507
6508 * makefile.w32-in: Update dependencies.
6509 (LISP_H): Add inttypes.h and stdin.h.
6510 (PROCESS_H): Add unistd.h.
6511
c51453d9
EZ
65122011-05-06 Eli Zaretskii <eliz@gnu.org>
6513
6514 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6515 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6516
8ff0ac3c 65172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6518
4c4b566b
PE
6519 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6520
aab2b9b5
PE
6521 * term.c (vfatal): Remove stray call to va_end.
6522 It's not needed and the C Standard doesn't allow it here anyway.
6523
c378da0b
PE
6524 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6525 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6526
288b08c7
PE
6527 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6528 bytes.
6529
e3601888
PE
6530 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6531
db6c0e74
PE
6532 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6533
dd5963ea
PE
6534 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6535
88c9450f
PE
6536 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6537
2f9442b8
PE
6538 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6539
c032b5f8
PE
6540 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6541 * charset.c (Fdefine_charset_internal): Don't initialize
6542 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6543 32-bit int (Bug#8600).
a108c10b
PE
6544
6545 * lread.c (read_integer): Be more consistent with string-to-number.
6546 Use string_to_number to do the actual conversion; this avoids
6547 rounding errors and fixes some other screwups. Without this fix,
6548 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6549 (digit_to_number): Move earlier, for benefit of read_integer.
6550 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6551 not a digit in any supported base. (Bug#8602)
a108c10b 6552
ad5f9eea
PE
6553 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6554
aec1708a
PE
6555 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6556 to match comment at start of function. This also removes a
6557 GCC warning about overflow in a 32+64-bit port.
6558
47be4ab5
PE
6559 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6560
371cac43
PE
6561 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6562 Reported by Stefan Monnier in
6563 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6564 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6565 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6566
d01a7826
PE
6567 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6568 (EMACS_UINTPTR): Likewise, with uintptr_t.
6569
7fd47d5c
PE
6570 * lisp.h: Prefer 64-bit EMACS_INT if available.
6571 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6572 on 32-bit hosts that have 64-bit int, so that they can access
6573 large files.
122b0c86
PE
6574 However, temporarily disable this change unless the temporary
6575 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6576
8727937b
PE
6577 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6578
8ac068ac
PE
6579 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6580 This removes an assumption that EMACS_INT and long are the same
6581 width as pointers. The assumption is true for Emacs porting targets
6582 now, but we want to make other targets possible.
6583 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6584 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6585 In the rest of the code, change types of integers that hold casted
6586 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6587 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6588 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6589 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6590 No need to cast type when ORing.
6591 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6592 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6593 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6594 assume EMACS_INT is the same width as char *.
6595 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6596 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6597 Remove no-longer-needed casts.
6598 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6599 (xg_tool_bar_help_callback, xg_make_tool_item):
6600 Use EMACS_INTPTR to hold an integer
6601 that will be cast to void *; this can avoid a GCC warning
6602 if EMACS_INT is not the same width as void *.
6603 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6604 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6605 (current_message_1, set_message_1):
6606 Use a local to convert to proper width without a cast.
6607 * xmenu.c (dialog_selection_callback): Likewise.
6608
ede49d71
PE
6609 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6610 Also, don't assume VALBITS / RAND_BITS is less than 5,
6611 and don't rely on undefined behavior when shifting a 1 left into
6612 the sign bit.
6613 * lisp.h (get_random): Change signature to match.
6614
2f30ecd0
PE
6615 * lread.c (hash_string): Use size_t, not int, for hash computation.
6616 Normally we prefer signed values; but hashing is special, because
6617 it's better to use unsigned division on hash table sizes so that
6618 the remainder is nonnegative. Also, size_t is the natural width
6619 for hashing into memory. The previous code used 'int', which doesn't
6620 retain enough info to hash well into very large tables.
6621 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6622
2a866e7b
PE
6623 * dbusbind.c: Don't possibly lose pointer info when converting.
6624 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6625 Use XPNTR rather than XHASH, so that the high-order bits of
6626 the pointer aren't lost when converting through void *.
6627
51639eac
PE
6628 * eval.c (Fautoload): Don't double-shift a pointer.
6629
92394119
PE
6630 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6631
dbdb9a7c
JB
66322011-05-06 Juanma Barranquero <lekktu@gmail.com>
6633
6634 * gnutls.c (DEF_GNUTLS_FN):
6635 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6636
db7a0b4f
AS
66372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6638
6639 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6640 marker. (Bug#8610)
6641
cd394be1 66422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6643
6644 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6645 New version that can reserve upto 2GB of heap space.
6646
f7ff1b0f 66472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6648
6649 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6650
639c109b
TZ
66512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6652
6653 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6654 `gnutls_certificate_set_x509_key_file'.
6655
d2127135
JB
66562011-05-05 Juanma Barranquero <lekktu@gmail.com>
6657
6658 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6659 Update dependencies.
6660
e968f4f3
JB
66612011-05-04 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6664 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6665 Remove unused parameter `fildes'.
6666 * process.c (read_process_output, send_process): Don't pass it.
6667
84d358f0
JB
66682011-05-04 Juanma Barranquero <lekktu@gmail.com>
6669
6670 Fix previous change: the library cache is defined in w32.c.
6671 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6672 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6673
0898ca10
JB
66742011-05-04 Juanma Barranquero <lekktu@gmail.com>
6675
6676 Implement dynamic loading of GnuTLS on Windows.
6677
6678 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6679 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6680 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6681 Declare.
6682
6683 * gnutls.c (Qgnutls_dll): Define.
6684 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6685 (gnutls_*): Declare function pointers.
6686 (init_gnutls_functions): New function to initialize function pointers.
6687 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6688 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6689 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6690 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6691 (emacs_gnutls_write, emacs_gnutls_read)
6692 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6693 (Fgnutls_available_p): New function.
6694 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6695 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6696 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6697
6698 * image.c: Include w32.h.
6699 (Vimage_type_cache): Delete.
6700 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6701 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6702 (w32_delayed_load): Move to w32.c.
6703
6704 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6705
6706 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6707 (w32_delayed_load): Move from image.c. When loading a library, record
6708 its filename in the :loaded-from property of the library id.
6709 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6710 Initialize and staticpro them.
6711 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6712
6713 * process.c: Include lisp.h before w32.h, not after.
6714 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6715 instead of gnutls_record_check_pending.
6716
6717 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6718
ff4de4aa
TZ
67192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6720
6721 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6722 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6723 as passed in.
6724
abe95abb
JD
67252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6726
6727 * xterm.c (x_set_frame_alpha): Do not set property on anything
6728 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6729
e16e55d4
JB
67302011-05-02 Juanma Barranquero <lekktu@gmail.com>
6731
6732 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6733
bafcf6a5
JB
67342011-05-02 Juanma Barranquero <lekktu@gmail.com>
6735
6736 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6737 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6738 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6739 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6740 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6741 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6742 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6743 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6744 (Qgnutls_bootprop_callbacks_verify): Make static.
6745
e7a6747f
AS
67462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6747
19ed11ba
AS
6748 * callproc.c: Indentation fixup.
6749
e7a6747f 6750 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6751 (wait_for_termination, interruptible_wait_for_termination):
6752 Move after wait_for_termination_1.
e7a6747f 6753
1ef14cb4
LMI
67542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6755
6756 * sysdep.c (interruptible_wait_for_termination): New function
6757 which is like wait_for_termination, but allows keyboard
6758 interruptions.
6759
6760 * callproc.c (Fcall_process): Add (:file "file") as an option for
6761 the STDOUT buffer.
6762 (Fcall_process_region): Ditto.
6763
330d880c
EZ
67642011-04-30 Eli Zaretskii <eliz@gnu.org>
6765
8db90b73
EZ
6766 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6767 rather than `XVECTOR (FOO)->size'.
6768
330d880c
EZ
6769 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6770 inttypes.h, as a gnulib replacement is used if it not available in
6771 system headers.
6772
15cbd324
EZ
67732011-04-21 Eli Zaretskii <eliz@gnu.org>
6774
6775 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6776 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6777 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6778
6779 * coding.c (coding_alloc_by_realloc): Error out if destination
6780 will grow beyond MOST_POSITIVE_FIXNUM.
6781 (decode_coding_emacs_mule): Abort if there isn't enough place in
6782 charbuf for the composition carryover bytes. Reserve an extra
6783 space for up to 2 characters produced in a loop.
6784 (decode_coding_iso_2022): Abort if there isn't enough place in
6785 charbuf for the composition carryover bytes.
6786
67872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6788
ae940cca
EZ
6789 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6790 aborting when %lld or %lll format is passed.
6791 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6792 %llo or %llx format is passed. (Bug#8545)
6793
03ab8921
EZ
6794 * window.c (window_scroll_line_based): Use a marker instead of
6795 simple variables to record original value of point. (Bug#7952)
6796
afda1437
EZ
6797 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6798 produced by %s or %c overflows available buffer space. (Bug#8545)
6799
f76dee0c
PE
68002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6801
6802 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6803 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6804
fdc5744d
JB
68052011-04-28 Juanma Barranquero <lekktu@gmail.com>
6806
6807 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6808
638f053a
JB
68092011-04-28 Juanma Barranquero <lekktu@gmail.com>
6810
6811 * keyboard.c (Qdelayed_warnings_hook): Define.
6812 (command_loop_1): Run `delayed-warnings-hook'
6813 if Vdelayed_warnings_list is non-nil.
6814 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6815 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6816
d178f871
EZ
68172011-04-28 Eli Zaretskii <eliz@gnu.org>
6818
6819 * doprnt.c (doprnt): Don't return value smaller than the buffer
6820 size if the message was truncated. (Bug#8545).
6821
b124fd93
JB
68222011-04-28 Juanma Barranquero <lekktu@gmail.com>
6823
6824 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6825 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6826
e810457d
PE
68272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6828
6829 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6830
ea51cceb
JB
68312011-04-27 Juanma Barranquero <lekktu@gmail.com>
6832
6833 * makefile.w32-in: Update dependencies.
6834
94dcfacf
EZ
68352011-04-27 Eli Zaretskii <eliz@gnu.org>
6836
6837 Improve `doprnt' and its usage. (Bug#8545)
6838 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6839 `format_end'. Remove support for %l as a conversion specifier.
6840 Don't use xrealloc. Improve diagnostics when the %l size modifier
6841 is used. Update the commentary.
6842
6843 * eval.c (verror): Simplify calculation of size_t.
6844
6845 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6846 messages.
6847
f61f41d7
PE
68482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6849
6850 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6851 change.
6852
96fb4434
PE
68532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6856 This makes this file independent of the recent pseudovector change.
6857
671875da 68582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6859
69e9b5a3
PE
6860 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6861
b5f869a7 6862 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6863 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6864 Remove unused local.
c8926152 6865 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6866
841a1577 6867 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6868 GCC 4.6.0 optimizes based on type-based alias analysis.
6869 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6870 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6871 != &v->size, and therefore "v->size = 1; b->size = 2; return
6872 v->size;" must therefore return 1. This assumption is incorrect
6873 for Emacs, since it type-puns struct Lisp_Vector * with many other
6874 types. To fix this problem, this patch adds a new type struct
f904488f 6875 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6876 and pseudovectors, and helps optimizing compilers not get fooled
6877 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6878 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6879 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6880 the size member.
eab3844f
PE
6881 (XSETPVECTYPE): Rewrite in terms of new macro.
6882 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6883 This is a bit clearer, and further avoids the possibility of
6884 undesirable aliasing.
6885 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6886 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6887 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6888 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6889 (ASIZE): Now uses header.size rather than size.
6890 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6891 to avoid the hassle of writing XVECTOR (foo)->header.size.
6892 (struct vectorlike_header): New type.
eab3844f
PE
6893 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6894 object, to help avoid aliasing.
6895 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6896 (SUBRP): Likewise, since Lisp_Subr is a special case.
6897 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6898 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6899 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6900 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6901 changed to be "header.size" and "header.next".
6902 * buffer.h (struct buffer): Likewise.
6903 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6904 * frame.h (struct frame): Likewise.
6905 * process.h (struct Lisp_Process): Likewise.
6906 * termhooks.h (struct terminal): Likewise.
6907 * window.c (struct save_window_data, struct saved_window): Likewise.
6908 * window.h (struct window): Likewise.
6909 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6910 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6911 * buffer.c (init_buffer_once): Likewise.
6912 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6913 special case.
6914 * process.c (Fformat_network_address): Use local var for size,
6915 for brevity.
6916
0df1eac5
PE
6917 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6918
847ab9d1 6919 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6920 * data.c (atof): Remove decl; no longer used or needed.
6921 (digit_to_number): Move to lread.c.
6922 (Fstring_to_number): Use new string_to_number function, to be
6923 consistent with how the Lisp reader treats infinities and NaNs.
6924 Do not assume that floating-point numbers represent EMACS_INT
6925 without losing information; this is not true on most 64-bit hosts.
6926 Avoid double-rounding errors, by insisting on integers when
6927 parsing non-base-10 numbers, as the documentation specifies.
6928 * lisp.h (string_to_number): New decl, replacing ...
6929 (isfloat_string): Remove.
bc0a5c13 6930 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6931 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6932 appears to have been a coding error. Similarly, do not accept
6933 strings like +-1e0 as floating point numbers. Do not report
6934 overflow for integer overflows unless the base is not 10 which
6935 means we have no simple and reliable way to continue.
6936 Break out the floating-point parsing into a new
6937 function string_to_number, so that Fstring_to_number parses
6938 floating point numbers consistently with the Lisp reader.
04f2d78b 6939 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6940 (E_CHAR, EXP_INT): Remove, replacing with ...
6941 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6942 (string_to_number): New function, replacing isfloat_string.
6943 This function checks for valid syntax and produces the resulting
6944 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6945 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6946 so that overflow for non-base-10 numbers is reported only when
6947 there's no portable and simple way to convert to floating point.
452f4150 6948
67769ffc
PE
6949 * textprop.c (set_text_properties_1): Rewrite for clarity,
6950 and to avoid GCC warning about integer overflow.
6951
c20db43f
PE
6952 * intervals.h (struct interval): Use EMACS_INT for members
6953 where EMACS_UINT might cause problems. See
6954 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6955 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6956 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6957 All uses changed.
37aa2f85
PE
6958 (offset_intervals): Tell GCC not to worry about length overflow
6959 when negating a negative length.
c20db43f 6960
2538aa2f
PE
6961 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6962 (overrun_check_free): Likewise.
6963
f2d3008d
PE
6964 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6965 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6966 word size.
6967
ec8df744
PE
6968 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6969 (gnutls_make_error): Rename local to avoid shadowing.
6970 (gnutls_emacs_global_deinit): ifdef out; not used.
6971 (Fgnutls_boot): Use const for pointer to readonly storage.
6972 Comment out unused local. Fix pointer signedness problems.
6973
640ee02d
PE
6974 * lread.c (openp): Don't stuff size_t into an 'int'.
6975 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6976 about possible signed overflow.
6977
6048fb2a
PE
6978 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6979 (GDK_KEY_g): Don't define if already defined.
6980 (xg_prepare_tooltip): Avoid pointer signedness problem.
6981 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6982
fa3c87e1
PE
6983 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6984 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6985
2172544b
PE
6986 * xfns.c (Fx_window_property): Simplify a bit,
6987 to make a bit faster and to avoid GCC 4.6.0 warning.
6988 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6989
9b821a21
PE
6990 * fns.c (internal_equal): Don't assume size_t fits in int.
6991
3c616cfa
PE
6992 * alloc.c (compact_small_strings): Tighten assertion a little.
6993
c2982e87
PE
6994 Replace pEd with more-general pI, and fix some printf arg casts.
6995 * lisp.h (pI): New macro, generalizing old pEd macro to other
6996 conversion specifiers. For example, use "...%"pI"d..." rather
6997 than "...%"pEd"...".
6998 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6999 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7000 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7001 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7002 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7003 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7004 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7005 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7006 64-bit hosts.
7007 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7008 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7009 * print.c (safe_debug_print, print_object): Likewise.
7010 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7011 to int.
6f04d126
PE
7012 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7013 avoiding the 0 flag, which is not portable.
c2982e87
PE
7014 * process.c (Fmake_network_process): Use pI to avoid cast.
7015 * region-cache.c (pp_cache): Likewise.
7016 * xdisp.c (decode_mode_spec): Likewise.
7017 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7018 behavior on 64-bit hosts with printf arg.
6f04d126 7019 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7020 (x_stop_queuing_selection_requests): Likewise.
7021 (x_get_window_property): Don't truncate byte count to an 'int'
7022 when tracing.
0b432f21 7023
5e073ec7
PE
7024 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7025 here, since it parses constructs like leading '-' and spaces,
7026 which are not wanted; and it overflows with large numbers.
7027 Instead, simply match F[0-9]+, which is what is wanted anyway.
7028
36372bf9
PE
7029 * alloc.c: Remove unportable assumptions about struct layout.
7030 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7031 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7032 (allocate_vectorlike, make_pure_vector): Use the new macros,
7033 plus offsetof, to remove unportable assumptions about struct layout.
7034 These assumptions hold on all porting targets that I know of, but
7035 they are not guaranteed, they're easy to remove, and removing them
7036 makes further changes easier.
7037
0b432f21
PE
7038 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7039 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7040 (string_overrun_cookie): Now const. Use initializers that
7041 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7042 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7043 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7044 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7045 multiple of sizeof (EMACS_INT); it need not be, if
7046 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7047 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7048
895009e1
JB
70492011-04-26 Juanma Barranquero <lekktu@gmail.com>
7050
7051 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7052
6a7a1b0b
TZ
70532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7054
7055 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7056 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7057 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7058
841a1577 70592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7060
7061 * lisp.h (Qdebug): List symbol.
895009e1 7062 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7063 * keyboard.c (debug-on-event): New variable.
7064 (handle_user_signal): Break into debugger when debug-on-event
7065 matches the current signal symbol.
7066
f2d3ba6f
DN
70672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7068
7069 * alloc.c (check_sblock, check_string_bytes)
7070 (check_string_free_list): Convert to standard C.
7071
42ce4c63
TZ
70722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7073
7074 * w32.c (emacs_gnutls_push): Fix typo.
7075
825cd63c
EZ
70762011-04-25 Eli Zaretskii <eliz@gnu.org>
7077
fb11d64d
EZ
7078 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7079 "cast to pointer from integer of different size".
7080
825cd63c
EZ
7081 Improve doprnt and its use in verror. (Bug#8545)
7082 * doprnt.c (doprnt): Document the set of format control sequences
7083 supported by the function. Use SAFE_ALLOCA instead of always
7084 using `alloca'.
7085
7086 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7087 is one byte too soon. Don't use xrealloc; instead xfree and
7088 xmalloc anew.
7089
e061a11b
TZ
70902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7091
7092 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7093 callbacks stage.
7094
7095 * gnutls.c: Renamed global_initialized to
7096 gnutls_global_initialized. Added internals for the
7097 :verify-hostname-error, :verify-error, and :verify-flags
7098 parameters of `gnutls-boot' and documented those parameters in the
7099 docstring. Start callback support.
9173deec
JB
7100 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7101 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7102 on error. Return error code.
e061a11b
TZ
7103 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7104 (emacs_gnutls_read): Likewise.
7105 (Fgnutls_boot): Return handshake error code.
7106 (emacs_gnutls_handle_error): New function.
7107 (wsaerror_to_errno): Likewise.
7108
7109 * w32.h (emacs_gnutls_pull): Add prototype.
7110 (emacs_gnutls_push): Likewise.
7111
7112 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7113 (emacs_gnutls_push): Likewise.
7114
71152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7116
7117 * process.c (wait_reading_process_output): Check if GnuTLS
7118 buffered some data internally if no FDs are set for TLS
7119 connections.
7120
7121 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7122 (LIBS): Link to USER_LIBS.
7123 ($(BLD)/gnutls.$(0)): New target.
7124
fa6996bc
EZ
71252011-04-24 Eli Zaretskii <eliz@gnu.org>
7126
eb35682e
EZ
7127 * xdisp.c (handle_single_display_spec): Rename the
7128 display_replaced_before_p argument into display_replaced_p, to
7129 make it consistent with the commentary. Fix typos in the
7130 commentary.
7131
e2ad650c
EZ
7132 * textprop.c (syms_of_textprop): Remove dead code.
7133 (copy_text_properties): Delete obsolete commentary about an
7134 interface that was deleted long ago. Fix typos in the description
7135 of arguments.
7136
1b2de274
EZ
7137 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7138 to changes in oldXMenu/XMenu.h from 2011-04-16.
7139 <menu_help_message, prev_menu_help_message>: Constify.
7140 (IT_menu_make_room): menu->help_text is now `const char **';
7141 adjust.
7142
7143 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7144 to changes in oldXMenu/XMenu.h from 2011-04-16.
7145 (struct XMenu): Declare `help_text' `const char **'.
7146
7147 * xfaces.c <Qunspecified>: Make extern again.
7148
7149 * syntax.c: Include sys/types.h before including regex.h, as
7150 required by Posix.
7151
762b15be
EZ
7152 * doc.c (get_doc_string): Improve the format passed to `error'.
7153
7154 * doprnt.c (doprnt): Improve commentary.
7155
7156 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7157
7158 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7159 them with etags.
7160
f1052e5d
EZ
7161 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7162 changes in globals.h immediately force recompilation.
762b15be
EZ
7163 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7164 $(CURDIR)/s/ms-w32.h.
7165 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7166
fa6996bc
EZ
7167 * character.c (Fchar_direction): Function deleted.
7168 (syms_of_character): Don't defsubr it.
7169 <char-direction-table>: Deleted.
7170
e6c3da20
EZ
71712011-04-23 Eli Zaretskii <eliz@gnu.org>
7172
7173 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7174 * doprnt.c: Include limits.h.
7175 (SIZE_MAX): New macro.
04f2d78b
CB
7176 (doprnt): Return a size_t value. 2nd arg is now size_t.
7177 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7178 Improve overflow protection. Support `l' modifier for integer
7179 conversions. Support %l conversion. Don't assume an EMACS_INT
7180 argument for integer conversions and for %c.
7181
7182 * lisp.h (doprnt): Restore prototype.
7183
7184 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7185 $(SRC)/character.h.
7186
7187 * Makefile.in (base_obj): Add back doprnt.o.
7188
7189 * deps.mk (doprnt.o): Add back prerequisites.
7190 (callint.o): Depend on character.h.
7191
7192 * eval.c (internal_lisp_condition_case): Include the handler
7193 representation in the error message.
7194 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7195 when breaking from the loop.
7196
7197 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7198
7199 * callint.c (Fcall_interactively): When displaying error message
7200 about invalid control letter, pass the character's codepoint, not
7201 a pointer to its multibyte form. Improve display of the character
7202 in octal and display also its hex code.
7203
7204 * character.c (char_string): Use %x to display the (unsigned)
7205 codepoint of an invalid character, to avoid displaying a bogus
7206 negative value.
7207
7208 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7209 `error', not SYMBOL_NAME itself.
7210
7211 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7212 character arguments to `error'.
7213
7214 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7215 to `error' in error message about FINAL_CHAR argument. Make sure
7216 FINAL_CHAR is a character, and use %c when it is passed as
7217 argument to `error'.
7218
4ffd0d6b 72192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7220
7221 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7222
7223 * w32.c: Include <time.h>.
7224 (sys_localtime): New function.
7225
4ffd0d6b 72262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7227
7228 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7229
4ffd0d6b 7230 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7231
4ffd0d6b 72322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7233
4ffd0d6b
GM
7234 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7235 zombies (Bug#8467).
aac0c6e3 7236
04c56954
EZ
72372011-04-19 Eli Zaretskii <eliz@gnu.org>
7238
7239 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7240 gl_state.e_property when gl_state.object is Qt.
7241
7242 * insdel.c (make_gap_larger): Remove limitation of buffer size
7243 to <= INT_MAX.
7244
16a43933
CY
72452011-04-18 Chong Yidong <cyd@stupidchicken.com>
7246
7247 * xdisp.c (lookup_glyphless_char_display)
7248 (produce_glyphless_glyph): Handle cons cell entry in
7249 glyphless-char-display.
7250 (Vglyphless_char_display): Document it.
7251
7252 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7253 glyphless-char-display.
7254
4581706e
CY
72552011-04-17 Chong Yidong <cyd@stupidchicken.com>
7256
7257 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7258
7259 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7260
7261 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7262 definition for no-X builds.
7263
4887c6e2 72642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7265
fd35b6f9
PE
7266 Static checks with GCC 4.6.0 and non-default toolkits.
7267
5c1ccb01
PE
7268 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7269
006c5daa
PE
7270 * process.c (keyboard_bit_set): Define only if SIGIO.
7271 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7272 (send_process): Repair possible setjmp clobbering.
7273
efc736d3
PE
7274 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7275
4e2fe2e6
PE
7276 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7277
f97334a2
PE
7278 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7279
4e75f29d
PE
7280 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7281 Define only if needed.
7282
90efadd1
PE
7283 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7284 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7285 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7286
3c647824
PE
7287 * dispextern.h (struct redisplay_interface): Rename param
7288 to avoid shadowing.
e264f262 7289 * termhooks.h (struct terminal): Likewise.
761383f4 7290 * xterm.c (xembed_send_message): Likewise.
3c647824 7291
b58c5c4a
PE
7292 * insdel.c (make_gap_smaller): Define only if
7293 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7294
cad59032
PE
7295 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7296 it.
7297
c339dc2e
PE
7298 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7299 so that we aren't warned about unused symbols.
7300
91a3e27b
PE
7301 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7302
399c71d3 7303 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7304
8ffc96f5
PE
7305 * xfns.c (x_real_positions): Mark locals as initialized.
7306
eef9bc79
PE
7307 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7308
098db9dd
PE
7309 * xterm.c: Fix problems found by static analysis with other toolkits.
7310 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7311 (x_dispatch_event): Declare static if USE_GTK, and
7312 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7313 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7314 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7315 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7316 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7317
eb18f6cc
PE
7318 * xmenu.c (menu_help_callback): Pointer type fixes.
7319 Use const pointers when pointing at readonly data. Avoid pointer
7320 signedness clashes.
7321 (FALSE): Remove unused macro.
7322 (update_frame_menubar): Remove unused decl.
7323
1fe72bf8
PE
7324 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7325
60d9e1db
PE
7326 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7327 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7328 (single_menu_item): Rename local to avoid shadowing.
7329
39261c26
PE
7330 * keyboard.c (make_lispy_event): Remove unused local var.
7331
018c5e19
PE
7332 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7333 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7334
63d2b86e
PE
7335 * bitmaps: Change bitmaps from unsigned char back to the X11
7336 compatible char. Avoid the old compiler warnings about
7337 out-of-range initializers by using, for example, '\xab' rather
7338 than 0xab.
7339
aefd87e1
PE
7340 * xgselect.c (xgselect_initialize): Check vs interface
7341 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7342
bf501fb9
PE
7343 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7344
e9829fdf
PE
7345 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7346 to read-only memory.
7347
1086c095
PE
7348 * fns.c (vector): Remove; this old hack is no longer needed.
7349
2baccd04 7350 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7351 Remove unused var.
dde42981 7352 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7353
72391843 7354 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7355
436c16df 7356 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7357 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7358 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7359
92bb796d 7360 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7361 (x_term_init): Remove local to avoid shadowing.
92bb796d 7362
764430a3 7363 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7364
7365 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7366 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7367
d1dfb56c
EZ
73682011-04-16 Eli Zaretskii <eliz@gnu.org>
7369
c4354cb4
EZ
7370 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7371
d1dfb56c
EZ
7372 Fix regex.c, syntax.c and friends for buffers > 2GB.
7373 * syntax.h (struct gl_state_s): Declare character position members
7374 EMACS_INT.
7375
7376 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7377
04f2d78b
CB
7378 * textprop.c (verify_interval_modification, interval_of):
7379 Declare arguments EMACS_INT.
d1dfb56c
EZ
7380
7381 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7382 EMACS_INT.
7383
7384 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7385
7386 * indent.c (Fvertical_motion): Local variable it_start is now
7387 EMACS_INT.
7388
7389 * regex.c (re_match, re_match_2, re_match_2_internal)
7390 (bcmp_translate, regcomp, regexec, print_double_string)
7391 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7392 (re_compile_pattern, re_exec): Declare arguments and local
7393 variables `size_t' and `ssize_t' and return values `regoff_t', as
7394 appropriate.
7395 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7396 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7397 <compile_stack_type>: `size' and `avail' are now `size_t'.
7398
7399 * regex.h <regoff_t>: Use ssize_t, not int.
7400 (re_search, re_search_2, re_match, re_match_2): Arguments that
7401 specify buffer/string position and length are now ssize_t and
7402 size_t. Return type is regoff_t.
7403
613052cd
BK
74042011-04-16 Ben Key <bkey76@gmail.com>
7405
7406 * nsfont.m: Fixed bugs in ns_get_family and
7407 ns_descriptor_to_entity that were caused by using free to
7408 deallocate memory blocks that were allocated by xmalloc (via
7409 xstrdup). This caused Emacs to crash when compiled with
7410 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7411 --enable-checking=xmallocoverrun). xfree is now used to
7412 deallocate these memory blocks.
7413
4170f62f 74142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7415
71b41406
PE
7416 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7417
9587a89d
PE
7418 emacs_write: Accept and return EMACS_INT for sizes.
7419 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7420 et seq.
7421 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7422 Accept and return EMACS_INT.
7423 (emacs_gnutls_write): Return the number of bytes written on
7424 partial writes.
7425 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7426 (emacs_read, emacs_write): Remove check for negative size, as the
7427 Emacs source code has been audited now.
9587a89d
PE
7428 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7429 (emacs_read, emacs_write): Use it.
273a5f82
PE
7430 * process.c (send_process): Adjust to the new signatures of
7431 emacs_write and emacs_gnutls_write. Do not attempt to store
7432 a byte offset into an 'int'; it might overflow.
9587a89d 7433 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7434
3e047f51
PE
7435 * sound.c: Don't assume sizes fit in 'int'.
7436 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7437 Return EMACS_INT, not int.
3e047f51 7438 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7439 Accept EMACS_INT, not int.
7440 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7441 record read return values.
7442
cc39a9db
BK
74432011-04-15 Ben Key <bkey76@gmail.com>
7444
c9d0ec6d
JB
7445 * keyboard.c (Qundefined): Don't declare static since it is used
7446 in nsfns.m.
7447 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7448 static since they are used in nsfont.m.
cc39a9db 7449
6c60eb9f
SM
74502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7451
7452 * process.c (Qprocessp): Don't declare static.
7453 * lisp.h (Qprocessp): Declare again.
7454
7990b61a
JB
74552011-04-15 Juanma Barranquero <lekktu@gmail.com>
7456
7457 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7458
5d4cb038
PE
74592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7460
8bd7b830 7461 Improve C-level modularity by making more things 'static'.
cd64ea1d 7462
e3b27b31
PE
7463 Don't publish debugger-only interfaces to other modules.
7464 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7465 (verify_bytepos, count_markers): Move decls to the only modules
7466 that need them.
7467 * region-cache.h (pp_cache): Likewise.
7468 * window.h (check_all_windows): Likewise.
7469 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7470
5d4cb038
PE
7471 * sysdep.c (croak): Now static, if
7472 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7473 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7474
7475 * alloc.c (refill_memory_reserve): Now static if
7476 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7477 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7478
e87b6180
PE
7479 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7480 Define only if USE_LUCID.
7481
ac64929e
PE
7482 * xrdb.c (x_customization_string, x_rm_string): Now static.
7483
6f37259d
PE
7484 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7485 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7486
1683e3ab
PE
7487 * xdisp.c (draw_row_with_mouse_face): Now static.
7488 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7489
de9c2632
PE
7490 * window.h (check_all_windows): Mark externally visible.
7491
2b96acb7
PE
7492 * window.c (window_deletion_count): Now static.
7493
7494 * undo.c: Make symbols static if they're not exported.
7495 (last_undo_buffer, last_boundary_position, pending_boundary):
7496 Now static.
7497
50436f33
PE
7498 * textprop.c (interval_insert_behind_hooks): Now static.
7499 (interval_insert_in_front_hooks): Likewise.
7500
64520e5c
PE
7501 * term.c: Make symbols static if they're not exported.
7502 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7503 (max_frame_lines, tty_set_terminal_modes):
7504 (tty_reset_terminal_modes, tty_turn_off_highlight):
7505 (get_tty_terminal): Now static.
7506 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7507 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7508 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7509 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7510 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7511
1fa53021
PE
7512 * sysdep.c: Make symbols static if they're not exported.
7513 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7514 Now static.
7515 (sigprocmask_set, full_mask): Remove; unused.
7516 (wait_debugging): Mark as visible.
7517 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7518 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7519
d4b43b22
PE
7520 * syntax.c (syntax_temp): Define only if !__GNUC__.
7521
b7c513d0
PE
7522 * sound.c (current_sound_device, current_sound): Now static.
7523
989b29ad
PE
7524 * search.c (searchbufs, searchbuf_head): Now static.
7525
13a55a78
PE
7526 * scroll.c (scroll_cost): Remove; unused.
7527 * dispextern.h (scroll_cost): Remove decl.
7528
de68a1fc
PE
7529 * region-cache.h (pp_cache): Mark as externally visible.
7530
40ccffa6
PE
7531 * process.c: Make symbols static if they're not exported.
7532 (process_tick, update_tick, create_process, chan_process):
7533 (Vprocess_alist, proc_buffered_char, datagram_access):
7534 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7535 (deactivate_process): Mark defn as static, as well as decl.
7536 * lisp.h (create_process): Remove decl.
7537 * process.h (chan_process, Vprocess_alist): Remove decls.
7538
ad64fc97
PE
7539 * print.c: Make symbols static if they're not exported.
7540 (print_depth, new_backquote_output, being_printed, print_buffer):
7541 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7542 (print_interval, print_number_index, initial_stderr_stream):
7543 Now static.
7544 * lisp.h (Fprinc): Remove decl.
7545 (debug_output_compilation_hack): Mark as externally visible.
7546
adddb265
PE
7547 * sysdep.c (croak): Move decl from here to syssignal.h.
7548 * syssignal.h (croak): Put it here, so the API can be checked when
7549 'croak' is called from dissociate_if_controlling_tty.
7550
1717ede2
PE
7551 * minibuf.c: Make symbols static if they're not exported.
7552 (minibuf_save_list, choose_minibuf_frame): Now static.
7553 * lisp.h (choose_minibuf_frame): Remove decl.
7554
fa5fb2bc
PE
7555 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7556
1e3890d1
PE
7557 * lread.c: Make symbols static if they're not exported.
7558 (read_objects, initial_obarray, oblookup_last_bucket_number):
7559 Now static.
7560 (make_symbol): Remove; unused.
7561 * lisp.h (initial_obarray, make_symbol): Remove decls.
7562
8a1414fa
PE
7563 * keyboard.c: Make symbols static if they're not exported.
7564 (single_kboard, recent_keys_index, total_keys, recent_keys):
7565 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7566 (this_single_command_key_start, echoing, last_auto_save):
7567 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7568 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7569 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7570 (Vlispy_mouse_stem, double_click_count):
7571 Now static.
7572 (force_auto_save_soon): Define only if SIGDANGER.
7573 (ignore_mouse_drag_p): Now static if
7574 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7575 (print_help): Remove; unused.
7576 (stop_character, last_timer_event): Mark as externally visible.
7577 * keyboard.h (ignore_mouse_drag_p): Declare only if
7578 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7579 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7580 * lisp.h (echoing): Remove decl.
7581 (force_auto_save_soon): Declare only if SIGDANGER.
7582 * xdisp.c (redisplay_window): Simplify code, to make it more
7583 obvious that ignore_mouse_drag_p is not accessed if !defined
7584 USE_GTK && !defined HAVE_NS.
7585
93ea6e8f
PE
7586 * intervals.c: Make symbols static if they're not exported.
7587 (merge_properties_sticky, merge_interval_right, delete_interval):
7588 Now static.
7589 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7590
77382fcc
PE
7591 * insdel.c: Make symbols static if they're not exported.
7592 However, leave prepare_to_modify_buffer alone. It's never
7593 called from outside this function, but that appears to be a bug.
7594 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7595 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7596 (adjust_after_replace_noundo): Remove; unused.
7597 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7598 (signal_before_change): Remove decls.
77382fcc 7599
9306c32e
PE
7600 * indent.c (val_compute_motion, val_vmotion): Now static.
7601
cd44d2eb
PE
7602 * image.c: Make symbols static if they're not exported.
7603 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7604 if USE_GTK.
7605 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7606 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7607
ad9a7a06
PE
7608 * fringe.c (standard_bitmaps): Now static.
7609 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7610
81626931
PE
7611 * frame.c: Make symbols static if they're not exported.
7612 (x_report_frame_params, make_terminal_frame): Now static.
7613 (get_frame_param): Now static, unless HAVE_NS.
7614 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7615 (x_get_resource_string): Remove; not used.
7616 * frame.h (make_terminal_frame, x_report_frame_params):
7617 (x_get_resource_string); Remove decls.
7618 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7619 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7620
239f9db9
PE
7621 * font.c, fontset.c: Make symbols static if they're not exported.
7622 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7623 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7624 * font.c (font_close_object): Now static.
7625 * font.h (font_close_object): Remove.
7626 * fontset.c (FONTSET_OBJLIST): Remove.
7627 (free_realized_fontset) #if-0 the body, which does nothing.
7628 (face_suitable_for_char_p): #if-0, as it's never called.
7629 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7630 * xfaces.c (face_at_string_position):
7631 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7632 since 0 is always ASCII.
7633
dfcf3579
PE
7634 * fns.c (weak_hash_tables): Now static.
7635
5045092b
PE
7636 * fileio.c: Make symbols static if they're not exported.
7637 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7638 (Vwrite_region_annotation_buffers): Now static.
7639
57a96f5c
PE
7640 * eval.c: Make symbols static if they're not exported.
7641 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7642 * lisp.h (backtrace_list): Remove decl.
7643
35f08c38
PE
7644 * emacs.c: Make symbols static if they're not exported.
7645 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7646 (fatal_error_code, fatal_error_signal_hook, standard_args):
7647 Now static.
7648 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7649 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7650 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7651 * lisp.h (fatal_error_signal_hook): Remove decl.
7652 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7653
f44bd759
PE
7654 * editfns.c: Move a (normally-unused) function to its only use.
7655 * editfns.c, lisp.h (get_operating_system_release): Remove.
7656 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7657 worth the hassle of breaking this out.
7658
b532497d
PE
7659 * xterm.c: Make symbols static if they're not exported.
7660 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7661 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7662 (x_destroy_window, x_delete_display):
7663 Now static.
7664 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7665 (x_mouse_leave): Remove; unused.
7666 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7667 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7668 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7669 Remove decls.
7670 (x_mouse_leave): Declare only if WINDOWSNT.
7671 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7672 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7673 USE_X_TOOLKIT.
7674
1675728f
PE
7675 * ftxfont.c: Make symbols static if they're not exported.
7676 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7677 HAVE_FREETYPE.
7678 * font.h (ftxfont_driver): Likewise.
7679
e4cebfca
PE
7680 * xfns.c: Make symbols static if they're not exported.
7681 (x_last_font_name, x_display_info_for_name):
7682 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7683 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7684 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7685 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7686 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7687 (last_show_tip_args): Now static.
7688 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7689 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7690 (x_screen_planes): Remove; unused.
7691 * dispextern.h (x_screen_planes): Remove decl.
7692
5bf46f05
PE
7693 * dispnew.c: Make symbols static if they're not exported.
7694 * dispextern.h (redraw_garbaged_frames, scrolling):
7695 (increment_row_positions): Remove.
7696 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7697 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7698 Now static.
7699 (redraw_garbaged_frames): Remove; unused.
7700
435f4c28
PE
7701 * xfaces.c: Make symbols static if they're not exported.
7702 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7703 Remove decls.
7704 * xterm.h (defined_color): Remove decls.
7705 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7706 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7707 (menu_face_changed_default, defined_color, free_realized_face):
7708 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7709 (ascii_face_of_lisp_face): Remove; unused.
7710
8524aef3
PE
7711 * xdisp.c: Make symbols static if they're not exported.
7712 * dispextern.h (scratch_glyph_row, window_box_edges):
7713 (glyph_to_pixel_coords, set_cursor_from_row):
7714 (get_next_display_element, set_iterator_to_next):
7715 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7716 (show_mouse_face): Remove decls
7717 * frame.h (message_buf_print): Likewise.
7718 * lisp.h (pop_message, set_message, check_point_in_composition):
7719 Likewise.
7720 * xterm.h (set_vertical_scroll_bar): Likewise.
7721 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7722 (message_buf_print, scratch_glyph_row, displayed_buffer):
7723 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7724 (get_next_display_element, show_mouse_face, window_box_edges):
7725 (frame_to_window_pixel_xy, check_point_in_composition):
7726 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7727 (glyph_to_pixel_coords): Remove; unused.
7728
16390cd2
PE
7729 * dired.c (file_name_completion): Now static.
7730
7731 * dbusbind.c (xd_in_read_queued_messages): Now static.
7732
a25f4dfa
PE
7733 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7734 * data.c (circular_list_error): Remove.
7735
14a9c8df
PE
7736 * commands.h (last_point_position, last_point_position_buffer):
7737 (last_point_position_window): Remove decls.
7738 * keyboard.c: Make these variables static.
7739
04f2d78b
CB
7740 * coding.h (coding, code_convert_region, encode_coding_gap):
7741 Remove decls.
74ab6df5
PE
7742 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7743 (iso_code_class, detect_coding, code_convert_region): Now static.
7744 (encode_coding_gap): Remove; unused.
7745
38dfbee1
PE
7746 * chartab.c (chartab_chars, chartab_bits): Now static.
7747
a2cb4e63
PE
7748 * charset.h (charset_iso_8859_1): Remove decl.
7749 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7750 Now static.
7751
127198fd
PE
7752 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7753 * ccl.c (Vccl_program_table): Now static.
7754 (check_ccl_update): Remove; unused.
7755
d85b608f
PE
7756 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7757 * category.h: ... from here.
7758 * category.c (check_category_table, set_category_set): Now static.
7759
31cd66f3
PE
7760 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7761 * lisp.h: Remove these decls.
7762
c358e587
PE
7763 * buffer.c (buffer_count): Remove unused var.
7764
e78aecca
PE
7765 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7766 so that it's not optimized away.
7767 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7768 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7769 exported only to the debugger.
7770
e192d7d3 7771 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7772 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7773
92470028
PE
7774 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7775 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7776 was inaccessible from Lisp.
7777 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7778 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7779
244ed907
PE
7780 alloc.c: Import and export fewer symbols, and remove unused items.
7781 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7782 is defined.
7783 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7784 it's not optimized away by whole-program optimization.
7785 (message_enable_multibyte, free_misc): Remove.
7786 (catchlist, handlerlist, mark_backtrace):
7787 Declare only if BYTE_MARK_STACK.
7788 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7789 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7790 (message_enable_multibyte): Remove decl.
7791 (free_misc, interval_free_list, float_block, float_block_index):
7792 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7793 (cons_free_list, last_marked_index):
7794 Now static.
7795 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7796 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7797 (mark_backtrace): Define only if BYTE_MARK_STACK.
7798 * xdisp.c (message_enable_multibyte): Now static.
7799
61c2b50e 7800 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7801 This makes it easier for human readers (and static analyzers)
7802 to see whether these variables are used from other modules.
7803 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7804 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7805 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7806 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7807 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7808 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7809 * xmenu.c, xselect.c:
7810 Declare Q* vars static if they are not used in other modules.
7811 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7812 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7813 Remove decls of unexported vars.
7814 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7815
95c82688
PE
7816 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7817
16a97296
PE
7818 Make Emacs functions such as Fatom 'static' by default.
7819 This makes it easier for human readers (and static analyzers)
7820 to see whether these functions can be called from other modules.
7821 DEFUN now defines a static function. To make the function external
7822 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7823 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7824 (Finit_image_library):
16a97296
PE
7825 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7826 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7827 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7828 Remove decls, since these functions are now static.
7829 (Funintern, Fget_internal_run_time): New decls, since these functions
7830 were already external.
95c82688 7831
16a97296
PE
7832 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7833 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7834 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7835 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7836 * keyboard.c, keymap.c, lread.c:
7837 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7838 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7839 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7840 Mark functions with DEFUE instead of DEFUN,
7841 if they are used in other modules.
7842 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7843 decls for now-static functions.
7844 * buffer.h (Fdelete_overlay): Remove decl.
7845 * callproc.c (Fgetenv_internal): Mark as internal.
7846 * composite.c (Fremove_list_of_text_properties): Remove decl.
7847 (Fcomposition_get_gstring): New forward static decl.
7848 * composite.h (Fcomposite_get_gstring): Remove decl.
7849 * dired.c (Ffile_attributes): New forward static decl.
7850 * doc.c (Fdocumntation_property): New forward static decl.
7851 * eval.c (Ffetch_bytecode): New forward static decl.
7852 (Funintern): Remove extern decl; now in .h file where it belongs.
7853 * fileio.c (Fmake_symbolic_link): New forward static decl.
7854 * image.c (Finit_image_library): New forward static decl.
7855 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7856 * intervals.h (Fprevious_property_change):
7857 (Fremove_list_of_text_properties): Remove decls.
7858 * keyboard.c (Fthis_command_keys): Remove decl.
7859 (Fcommand_execute): New forward static decl.
7860 * keymap.c (Flookup_key): New forward static decl.
7861 (Fcopy_keymap): Now static.
7862 * keymap.h (Flookup_key): Remove decl.
7863 * process.c (Fget_process): New forward static decl.
7864 (Fprocess_datagram_address): Mark as internal.
7865 * syntax.c (Fsyntax_table_p): New forward static decl.
7866 (skip_chars): Remove duplicate decl.
7867 * textprop.c (Fprevious_property_change): New forward static decl.
7868 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7869 Now internal.
7870 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7871 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7872
785bbd42
PE
7873 * editfns.c (Fformat): Remove unreachable code.
7874
8b913b57
AS
78752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7876
7877 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7878 change. (Bug#8496)
7879
a6744a35
EZ
78802011-04-13 Eli Zaretskii <eliz@gnu.org>
7881
7882 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7883 when at ZV. (Bug#8487)
7884
e7974947
AS
78852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7886
baad03f0
AS
7887 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7888 (Bug#8437)
7889 * keyboard.c (parse_tool_bar_item): Likewise.
7890 * sound.c (sound_cleanup, alsa_close): Likewise.
7891 * termcap.c (tgetent): Likewise.
7892 * xfns.c (x_default_font_parameter): Likewise.
7893 * xsettings.c (read_and_apply_settings): Likewise.
7894
e7974947
AS
7895 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7896 (overrun_check_free): Protoize.
7897
28272684
PE
78982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7899
7900 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7901 since callers should never pass a negative size.
7902 Change the signature to match that of plain 'read' and 'write'; see
7903 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7904 * lisp.h: Update prototypes of emacs_write and emacs_read.
7905
11997c76
EZ
79062011-04-11 Eli Zaretskii <eliz@gnu.org>
7907
7908 * xdisp.c (redisplay_window): Don't try to determine the character
7909 position of the scroll margin if the window start point w->startp
e896f03c 7910 is outside the buffer's accessible region. (Bug#8468)
11997c76 7911
8a2cbd72
EZ
79122011-04-10 Eli Zaretskii <eliz@gnu.org>
7913
7914 Fix write-region and its subroutines for buffers > 2GB.
7915 * fileio.c (a_write, e_write): Modify declaration of arguments and
7916 local variables to support buffers larger than 2GB.
7917 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7918
7919 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7920 argument, local variables, and return value.
7921
7922 * lisp.h: Update prototypes of emacs_write and emacs_read.
7923
7924 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7925
4073e537 79262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7927
1ebfdcb6
PE
7928 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7929
b2ded58d
PE
7930 Fix more problems found by GCC 4.6.0's static checks.
7931
7d66342c
PE
7932 * xdisp.c (vmessage): Use a better test for character truncation.
7933
bbf47d44
PE
7934 * charset.c (load_charset_map): <, not <=, for optimization,
7935 and to avoid potential problems with integer overflow.
9248994d 7936 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7937 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7938 * editfns.c (Fformat): Likewise.
1e69125e 7939 * syntax.c (skip_chars): Likewise.
3befa583 7940
e3019616
PE
7941 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7942 This also lets GCC 4.6.0 generate slightly better loop code.
7943
becfa255
PE
7944 * callint.c (Fcall_interactively): <, not <=, for optimization.
7945 (Fcall_interactively): Count the number of arguments produced,
7946 not the number of arguments given. This is simpler and lets GCC
7947 4.6.0 generate slightly better code.
7948
dae0cd48
PE
7949 * ftfont.c: Distingish more carefully between FcChar8 and char.
7950 The previous code passed unsigned char * to a functions like
7951 strlen and xstrcasecmp that expect char *, which does not
7952 conform to the C standard.
7953 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7954 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7955 char * when the C standard requires it.
7956
76032d70
PE
7957 * keyboard.c (read_char): Remove unused var.
7958
eb3f1cc8
PE
7959 * eval.c: Port to Windows vsnprintf (Bug#8435).
7960 Include <limits.h>.
7961 (SIZE_MAX): Define if the headers do not.
7962 (verror): Do not give up if vsnprintf returns a negative count.
7963 Instead, grow the buffer. This ports to Windows vsnprintf, which
7964 does not conform to C99. Problem reported by Eli Zaretskii.
7965 Also, simplify the allocation scheme, by avoiding the need for
7966 calling realloc, and removing the ALLOCATED variable.
7967
70476b54
PE
7968 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7969
12020a9e
PE
7970 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7971 But keep the doprint source code for now, as we might revamp it
7972 and use it again (Bug#8435).
ea6c7ae6
PE
7973 * lisp.h (doprnt): Remove.
7974 * Makefile.in (base_obj): Remove doprnt.o.
7975 * deps.mk (doprnt.o): Remove.
7976
5fdb398c
PE
7977 error: Print 32- and 64-bit integers portably (Bug#8435).
7978 Without this change, on typical 64-bit hosts error ("...%d...", N)
7979 was used to print both 32- and 64-bit integers N, which relied on
7980 undefined behavior.
61bdb816 7981 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7982 * lisp.h (error, verror): Mark as printf-like functions.
7983 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7984 Report overflow in size calculations when allocating printf buffer.
7985 Do not truncate output string at its first null byte.
7986 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7987 Truncate the output at a character boundary, since vsnprintf does not
7988 do that.
7989 * charset.c (check_iso_charset_parameter): Convert internal
7990 character to string before calling 'error', since %c now has the
7991 printf meaning.
7992 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7993 overflow when computing char to be passed to 'error'. Do not
7994 pass Lisp_Object to 'error'; pass the integer instead.
7995 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7996 formatted with plain %d.
7997
b189fa66
PE
7998 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7999
bff87ef0
PE
8000 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8001
7e2cac20
PE
8002 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8003
ce4d90b5
PE
8004 * xterm.c (x_catch_errors): Remove duplicate declaration.
8005
266c9547
PE
8006 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8007
79c49ad2
PE
8008 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8009
368f4090
JM
80102011-04-10 Jim Meyering <meyering@redhat.com>
8011
8012 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8013 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8014 return ssize_t not "int", and use size_t as the buffer length.
8015 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8016 * gnutls.h: Update declarations.
8017 * process.c (read_process_output): Use ssize_t, to match.
8018 (send_process): Likewise.
8019
a32d4040
CY
80202011-04-09 Chong Yidong <cyd@stupidchicken.com>
8021
8022 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8023
8546720e 80242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8025
04f2d78b
CB
8026 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8027 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8028
8546720e
GM
8029 * xterm.c (handle_one_xevent):
8030 * xmenu.c (create_and_show_popup_menu):
8031 * xselect.c (x_decline_selection_request)
8032 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8033
0a2f5c1a 80342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8035
8036 Fix some uses of `int' instead of EMACS_INT.
8037 * search.c (string_match_1, fast_string_match)
8038 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8039 (scan_buffer, find_next_newline_no_quit)
8040 (find_before_next_newline, search_command, Freplace_match)
8041 (Fmatch_data): Make some `int' variables be EMACS_INT.
8042
8043 * xdisp.c (display_count_lines): 3rd argument and return value now
8044 EMACS_INT. All callers changed.
8045 (pint2hrstr): Last argument is now EMACS_INT.
8046
8047 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8048 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8049 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8050 (decode_coding_utf_16, decode_coding_emacs_mule)
8051 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8052 (decode_coding_ccl, decode_coding_charset)
8053 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8054 (decode_coding_iso_2022, decode_coding_emacs_mule)
8055 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8056 <char_offset, last_offset>: Declare EMACS_INT.
8057 (encode_coding_utf_8, encode_coding_utf_16)
8058 (encode_coding_emacs_mule, encode_invocation_designation)
8059 (encode_designation_at_bol, encode_coding_iso_2022)
8060 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8061 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8062 Declare EMACS_INT.
8063 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8064 (encode_invocation_designation): Last argument P_NCHARS is now
8065 EMACS_INT.
8066 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8067 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8068
8069 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8070 All users changed.
8071
8072 * ccl.c (Fccl_execute_on_string): Declare some variables
8073 EMACS_INT.
8074
8546720e 80752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8076
8077 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8078
4e19a977
CS
80792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8080
8081 * process.c (Fformat_network_address): Doc fix.
8082
87302331
R
80832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8084
ee7683eb 8085 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8086
cbb59342
CY
80872011-04-08 Chong Yidong <cyd@stupidchicken.com>
8088
8089 * keyboard.c (read_char): Call Lisp function help-form-show,
8090 instead of using internal_with_output_to_temp_buffer.
8091 (Qhelp_form_show): New var.
e0d38eeb 8092 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8093
8094 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8095
8096 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8097
e67a13ab
CY
80982011-04-06 Chong Yidong <cyd@stupidchicken.com>
8099
04f2d78b
CB
8100 * process.c (Flist_processes): Remove to Lisp.
8101 (list_processes_1): Delete.
e67a13ab 8102
973f782d
EZ
81032011-04-06 Eli Zaretskii <eliz@gnu.org>
8104
7c106b1e
EZ
8105 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8106
973f782d
EZ
8107 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8108
41cf7d1a 81092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8110
ca23cc88
PE
8111 Fix more problems found by GCC 4.6.0's static checks.
8112
f390e2d5
PE
8113 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8114
42eea0d0
PE
8115 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8116
b69769da 8117 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8118
f9541e84
PE
8119 * xdisp.c (vmessage): Mark as a printf-like function.
8120
13841b55
PE
8121 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8122
c136c10f
PE
8123 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8124
5e2d4a30
PE
8125 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8126 printf-like functions.
8127 (tiff_load): Add casts to remove these marks before passing them
8128 to system-supplied API.
8129
583f48b9
PE
8130 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8131
b25d760e
PE
8132 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8133 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8134 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8135 directly, rather than having caller test rule sign. This avoids
8136 some unnecessary tests.
8137 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8138 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8139 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8140
bc7b6697 8141 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8142 (xfont_open): Avoid unnecessary tests.
bc7b6697 8143
27ccc379
PE
8144 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8145
dcd5c89a
PE
8146 * composite.h, composite.c (composition_gstring_put_cache):
8147 Use EMACS_INT, not int, for length.
8148
b13a45c6
PE
8149 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8150 breaking out part of COMPOSITION_DECODE_RULE.
8151 (COMPOSITION_DECODE_RULE): Use it.
8152 * composite.c (get_composition_id): Remove unused local vars,
8153 by using the new macro.
8154
1e792e4d
PE
8155 * textprop.c (set_text_properties_1): Change while to do-while,
8156 since the condition is always true at first.
8157
dc6c6455 8158 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8159 (interval_deletion_adjustment): Return unsigned value.
8160 All uses changed.
dc6c6455 8161
aba7731a
PE
8162 * process.c (list_processes_1, create_pty, read_process_output):
8163 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8164 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8165 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8166 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8167 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8168
fdfc4bf3
PE
8169 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8170
fca8fe46 8171 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8172 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8173
06a0259a 8174 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8175 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8176 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8177
e7b9e80f
PE
8178 * print.c (print_error_message): Avoid int overflow.
8179
56201685
PE
8180 * font.c (font_list_entities): Redo for clarity,
8181 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8182
78834453 8183 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8184 (font_score): Avoid potential overflow in diff calculation.
78834453 8185
0bc0b309 8186 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8187 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8188
e610eaca
PE
8189 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8190
b895abce
PE
8191 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8192 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8193 can always succeed if overflow has undefined behavior.
8194
1f1d9321 8195 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8196 (wordify): Omit three unnecessary tests.
1f1d9321 8197
c59478bc
PE
8198 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8199 All callers changed. This avoids the need for an unused var.
8200
79b73827
PE
8201 * casefiddle.c (casify_region): Remove var that is set but not used.
8202
a4db5dfe
PE
8203 * dired.c (file_name_completion): Remove var that is set but not used.
8204
43aae36e
PE
8205 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8206
2a47c44d 8207 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8208 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8209
a37c69bf
PE
8210 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8211 Check for integer overflow on size calculations.
8212
328ab8e7
PE
8213 * buffer.c (Fprevious_overlay_change): Remove var that is set
8214 but not used.
8215
e5a2a5cb
PE
8216 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8217 Remove vars that are set but not used.
8d84a6eb 8218 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8219 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8220
a60e5f68
PE
8221 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8222
f661cb61 8223 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8224 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8225
f0397f5a
PE
8226 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8227 that are set but not used.
8228
8664db06 8229 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8230 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8231
6abdaa4a
PE
8232 * xselect.c (x_get_local_selection, x_handle_property_notify):
8233 Remove vars that are set but not used.
8234
0ce7538d 8235 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8236 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8237
9ae848fc
PE
8238 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8239 Remove var that is set but not used.
0b918413
PE
8240 (scroll_bar_windows_size): Now size_t, not int.
8241 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8242 Check for overflow.
9ae848fc 8243
a5a62657
PE
8244 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8245 (map_tty_color) [!defined MSDOS]: Likewise.
8246
5c5cdd39
PE
8247 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8248
66ebf983
PE
8249 * coding.c: Remove vars that are set but not used.
8250 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8251 All callers changed.
8252 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8253 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8254 (decode_coding_charset): Remove vars that are set but not used.
8255
1be4d761
PE
8256 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8257 that is set but not used.
8258
47553fa8
PE
8259 * print.c (print_object): Remove var that is set but not used.
8260
1f7196bf 8261 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8262 The gnulib version avoids calling malloc in the usual case,
8263 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8264 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8265 * filelock.c (current_lock_owner): Likewise.
8266 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8267 * sysdep.c: Include allocator.h, careadlinkat.h.
8268 (emacs_no_realloc_allocator): New static constant.
8269 (emacs_readlink): New function.
fdb61804
PE
8270 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8271 ../lib/careadlinkat.h.
d1fdcab7 8272
f84c17c7
SM
82732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8274
8275 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8276 first non-nil return value).
8277
ef3862ad
JD
82782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8279
8280 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8281 if not defined (Bug#8403).
8282
376a7006
JB
82832011-04-02 Juanma Barranquero <lekktu@gmail.com>
8284
8285 * xdisp.c (display_count_lines): Remove parameter `start',
8286 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8287 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8288 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8289 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8290 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8291 and thereabouts. All callers changed.
8292 (get_per_char_metric): Remove parameter `f', unused since
8293 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8294
6ca3801d
JM
82952011-04-02 Jim Meyering <meyering@redhat.com>
8296
8297 do not dereference NULL upon failed strdup
8298 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8299 (ns_get_family): Likewise.
8300
d8e2b5ba
JB
83012011-04-02 Juanma Barranquero <lekktu@gmail.com>
8302
8303 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8304
8c74fcbd
JD
83052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8306
8307 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8308 later (Bug#8403).
8309
7200d79c
SM
83102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8311
03408648 8312 Add lexical binding.
7200d79c 8313
03408648
SM
8314 * window.c (Ftemp_output_buffer_show): New fun.
8315 (Fsave_window_excursion):
8316 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8317
8318 * lread.c (lisp_file_lexically_bound_p): New function.
8319 (Fload): Bind Qlexical_binding.
8320 (readevalloop): Remove `evalfun' arg.
8321 Bind Qinternal_interpreter_environment.
8322 (Feval_buffer): Bind Qlexical_binding.
8323 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8324 Mark as dynamic.
8325 (syms_of_lread): Declare `lexical-binding'.
8326
8327 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8328
8329 * keyboard.c (eval_dyn): New fun.
8330 (menu_item_eval_property): Use it.
ca105506
SM
8331
8332 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8333
03408648
SM
8334 * fns.c (concat, mapcar1): Accept byte-code-functions.
8335
8336 * eval.c (Fsetq): Handle lexical vars.
8337 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8338 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8339 (FletX, Flet): Obey lexical binding.
8340 (Fcommandp): Handle closures.
8341 (Feval): New `lexical' arg.
8342 (eval_sub): New function extracted from Feval. Use it almost
8343 everywhere where Feval was used. Look up vars in lexical env.
8344 Handle closures.
8345 (Ffunctionp): Move from subr.el.
8346 (Ffuncall): Handle closures.
8347 (apply_lambda): Remove `eval_flags'.
8348 (funcall_lambda): Handle closures and new byte-code-functions.
8349 (Fspecial_variable_p): New function.
8350 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8351 but without exporting it to Lisp.
23aba0ea 8352
23aba0ea 8353 * doc.c (Fdocumentation, store_function_docstring):
03408648 8354 * data.c (Finteractive_form): Handle closures.
23aba0ea 8355
03408648
SM
8356 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8357 interactive spec.
ba83908c 8358
04f2d78b
CB
8359 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8360 New byte-codes.
03408648
SM
8361 (exec_byte_code): New function extracted from Fbyte_code to handle new
8362 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8363
03408648 8364 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8365
03408648 8366 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8367
e2abce01
JB
83682011-03-31 Juanma Barranquero <lekktu@gmail.com>
8369
8370 * xdisp.c (redisplay_internal): Fix prototype.
8371
63696a73 83722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8373
63696a73 8374 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8375 (try_scrolling): Use it when setting scroll_limit.
8376 Limit scrolling to 100 screen lines.
63696a73
EZ
8377 (redisplay_window): Even when falling back on "recentering",
8378 position point in the window according to scroll-conservatively,
8379 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8380
8381 (try_scrolling): When point is above the window, allow searching
8382 as far as scroll_max, or one screenful, to compute vertical
8383 distance from PT to the scroll margin position. This prevents
8384 try_scrolling from unnecessarily failing when
8385 scroll-conservatively is set to a value slightly larger than the
8386 window height. Clean up the case of PT below the margin at bottom
8387 of window: scroll_max can no longer be INT_MAX. When aggressive
8388 scrolling is in use, don't let point enter the opposite scroll
8389 margin as result of the scroll.
8390 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8391 threshold of 100 lines for never-recentering scrolling.
8392
e4cc2dfc
JB
83932011-03-31 Juanma Barranquero <lekktu@gmail.com>
8394
8395 * dispextern.h (move_it_by_lines):
8396 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8397 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8398 (message_log_check_duplicate): Remove parameters `prev_bol' and
8399 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8400 (redisplay_internal): Remove parameter `preserve_echo_area',
8401 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8402
8403 * indent.c (Fvertical_motion):
8404 * window.c (window_scroll_pixel_based, Frecenter):
8405 Don't pass `need_y_p' to `move_it_by_lines'.
8406
1c470562
SM
84072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8408
44f230aa
SM
8409 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8410 steal a few bits to be more compact.
8411 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8412 Remove unneeded casts.
8413
1c470562
SM
8414 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8415
888adce9
ZK
84162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8417
8418 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8419 binding" message (bug#7967).
8420
f838ed7b
PE
84212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8422
77861b95
PE
8423 Fix more problems found by GCC 4.6.0's static checks.
8424
de6dbc14
PE
8425 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8426 Remove unused local var.
8427
f838ed7b
PE
8428 * editfns.c (Fmessage_box): Remove unused local var.
8429
792c7b2b
PE
8430 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8431 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8432 Omit unused local vars.
c499e557 8433 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8434 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8435 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8436 Omit unused local var.
8437
ba0165e1
PE
8438 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8439 Don't assume string length fits in int.
32ad8845 8440 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8441 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8442
3c59b4c9
PE
8443 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8444 instead of alloca (Bug#8344).
8445
a3eed478 8446 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8447 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8448
eb4d412d
PE
8449 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8450
1658b401
PE
8451 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8452 concerns.
8453
8454 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8455
8456 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8457
9a2c6e05
PE
8458 * keyboard.c (syms_of_keyboard): Use the same style as later
8459 in this function when indexing through an array. This also
8460 works around GCC bug 48267.
8461
03d0a109
PE
8462 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8463
44f730c8
PE
8464 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8465
fe75f926
PE
8466 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8467 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8468
ffa8c828
PE
8469 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8470 This avoids undefined behavior on integer overflow, and is a bit
8471 more convenient anyway since it is compared to a size_t variable.
8472
c5101a77
PE
8473 Variadic C functions now count arguments with size_t, not int.
8474 This avoids an unnecessary limitation on 64-bit machines, which
8475 caused (substring ...) to crash on large vectors (Bug#8344).
8476 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8477 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8478 All variadic functions and their callers changed accordingly.
c5101a77
PE
8479 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8480 * data.c (arith_driver, float_arith_driver): Likewise.
8481 * editfns.c (general_insert_function): Likewise.
8482 * eval.c (struct backtrace.nargs, interactive_p)
8483 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8484 (funcall_lambda, mark_backtrace): Likewise.
8485 * fns.c (concat): Likewise.
8486 * frame.c (x_set_frame_parameters): Likewise.
8487 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8488 0 if not found, not -1. All callers changed.
8489
dd3f25f7
PE
8490 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8491 (stack_copy_size): Now size_t, not int.
8492 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8493
461c2ab9
JB
84942011-03-28 Juanma Barranquero <lekktu@gmail.com>
8495
8496 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8497 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8498 All callers changed.
8499
8500 * lisp.h (multibyte_char_to_unibyte):
8501 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8502 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8503 * character.h (CHAR_TO_BYTE8):
8504 * cmds.c (internal_self_insert):
8505 * editfns.c (general_insert_function):
8506 * keymap.c (push_key_description):
8507 * search.c (Freplace_match):
8508 * xdisp.c (message_dolog, set_message_1): All callers changed.
8509
f6d62986
SM
85102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8511
8512 * keyboard.c (safe_run_hook_funcall): New function.
8513 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8514 don't set the hook to nil, but remove the offending function instead.
8515 (Qcommand_hook_internal): Remove, unused.
8516 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8517 Vcommand_hook_internal.
8518
8519 * eval.c (enum run_hooks_condition): Remove.
8520 (funcall_nil, funcall_not): New functions.
8521 (run_hook_with_args): Call each function through a `funcall' argument.
8522 Remove `cond' argument, now redundant.
8523 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8524 (Frun_hook_with_args_until_failure): Adjust accordingly.
8525 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8526
1db5b1ad
JB
85272011-03-28 Juanma Barranquero <lekktu@gmail.com>
8528
8529 * dispextern.h (string_buffer_position): Remove declaration.
8530
8531 * print.c (strout): Remove parameter `multibyte', unused since
8532 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8533
8534 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8535 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8536 All callers changed.
8537
8538 * w32.c (_wsa_errlist): Use braces for struct initializers.
8539
8540 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8541 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8542 All callers changed.
8543 (string_buffer_position): Likewise. Also, make static (it's never
8544 used outside xdisp.c).
8545 (cursor_row_p): Remove parameter `w', unused since
8546 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8547 (decode_mode_spec): Remove parameter `precision', introduced during
8548 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8549 All callers changed.
8550
5ffb62aa
JD
85512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8552
8553 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8554
461c2ab9 85552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8556
8557 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8558 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8559 (ns_update_auto_hide_menu_bar): New functions.
8560 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8561 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8562 ns_constrain_all_frames.
8563 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8564 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8565
5c380ffb
JD
85662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8567
8568 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8569
9af30bdf
GM
85702011-03-27 Glenn Morris <rgm@gnu.org>
8571
8572 * syssignal.h: Replace RETSIGTYPE with void.
8573 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8574 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8575 Replace SIGTYPE with void everywhere.
8576 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8577 * s/template.h (SIGTYPE): Remove commented out definition.
8578
e2abce01
JB
85792011-03-26 Eli Zaretskii <eliz@gnu.org>
8580
8581 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8582 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8583
f868cd8a
JB
85842011-03-26 Juanma Barranquero <lekktu@gmail.com>
8585
59eb0929
JB
8586 * w32.c (read_unc_volume): Use parameter `henum', instead of
8587 global variable `wget_enum_handle'.
8588
8589 * keymap.c (describe_vector): Remove parameters `indices' and
8590 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8591 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8592
f868cd8a
JB
8593 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8594
8595 * keyboard.c (timer_check): Remove parameter `do_it_now',
8596 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8597 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8598 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8599
8600 * keyboard.c (read_char):
8601 * w32menu.c (w32_menu_display_help):
8602 * xmenu.c (show_help_event, menu_help_callback):
8603 Adjust calls to `show_help_echo'.
8604
8605 * gtkutil.c (xg_maybe_add_timer):
8606 * keyboard.c (readable_events):
8607 * process.c (wait_reading_process_output):
8608 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8609
8610 * insdel.c (adjust_markers_gap_motion):
8611 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8612 (gap_left, gap_right): Don't call it.
8613
2ecf6fdb
CY
86142011-03-25 Chong Yidong <cyd@stupidchicken.com>
8615
8616 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8617 incurred during fontification.
8618
6b1f9ba4
JB
86192011-03-25 Juanma Barranquero <lekktu@gmail.com>
8620
8621 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8622 (DEFVAR_PER_BUFFER): Don't pass it.
8623
8624 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8625 (scrolling_window): Don't pass it.
8626
0f4a96b5
JB
86272011-03-25 Juanma Barranquero <lekktu@gmail.com>
8628
8629 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8630
8631 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8632 and `suffix'.
8633 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8634 of variables specific to SELinux and computation of `encoded_absname'.
8635
8636 * image.c (XPutPixel): Remove unused variable `height'.
8637
8638 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8639
8640 * unexw32.c (get_section_info): Remove unused variable `section'.
8641
8642 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8643 (system_process_attributes): Remove unused variable `sess'.
8644 (sys_read): Remove unused variable `err'.
8645
8646 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8647 (w32_wnd_proc): Remove unused variable `isdead'.
8648 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8649 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8650 (x_create_tip_frame): Remove unused variable `tem'.
8651
8652 * w32inevt.c (w32_console_read_socket):
8653 Remove unused variable `no_events'.
8654
8655 * w32term.c (x_draw_composite_glyph_string_foreground):
8656 Remove unused variable `width'.
8657
1149507c
JB
86582011-03-24 Juanma Barranquero <lekktu@gmail.com>
8659
8660 * w32term.c (x_set_glyph_string_clipping):
8661 Don't pass uninitialized region to CombineRgn.
8662
9c88f339
JB
86632011-03-23 Juanma Barranquero <lekktu@gmail.com>
8664
8665 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8666 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8667 (Fx_close_connection): Remove unused variable `i'.
8668
8669 * w32font.c (w32font_draw): Return number of glyphs.
8670 (w32font_open_internal): Remove unused variable `i'.
8671 (w32font_driver): Add missing initializer.
8672
8673 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8674 (fill_in_menu): Remove unused variable `items_added'.
8675
8676 * w32term.c (last_mouse_press_frame): Remove static global variable.
8677 (w32_clip_to_row): Remove unused variable `f'.
8678 (x_delete_terminal): Remove unused variable `i'.
8679
8680 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8681 (NOTHING): Remove unused static global variable.
8682 (uniscribe_check_otf): Remove unused variable `table'.
8683 (uniscribe_font_driver): Add missing initializers.
8684
dee091a3
JD
86852011-03-23 Julien Danjou <julien@danjou.info>
8686
8687 * term.c (Fsuspend_tty, Fresume_tty):
8688 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8689 * window.c (temp_output_buffer_show):
8690 * insdel.c (signal_before_change):
8691 * frame.c (Fhandle_switch_frame):
8692 * fileio.c (Fdo_auto_save):
8693 * emacs.c (Fkill_emacs):
8694 * editfns.c (save_excursion_restore):
8695 * cmds.c (internal_self_insert):
8696 * callint.c (Fcall_interactively):
8697 * buffer.c (Fkill_all_local_variables):
8698 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8699 Use Frun_hooks.
0f4a96b5 8700 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8701 unconditionally since it does the check itself.
dee091a3 8702
2c520ab5 87032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8704
c9c49752
PE
8705 Fix more problems found by GCC 4.5.2's static checks.
8706
8abc3f12
PE
8707 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8708 the first time through the loop, since we know p0 < p1 then.
8709 This also avoids a gcc -Wstrict-overflow warning.
8710
a2d26660
PE
8711 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8712 leading to a memory leak, possible in functions like
8713 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8714 of objects (Bug#8318).
a2d26660 8715
916c72e9
PE
8716 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8717 that could (at least in theory) be that large.
8718
19ab8a18
PE
8719 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8720 This is less likely to overflow, and avoids undefined behavior if
8721 overflow does occur. All callers changed. Use strtoul to scan
8722 for the unsigned long integer.
b7cbbd6f
PE
8723 (pint2hrstr): Simplify and tune code slightly.
8724 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8725
f0641eff
PE
8726 * scroll.c (do_scrolling): Work around GCC bug 48228.
8727 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8728
7f650bb9
PE
8729 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8730 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8731 (validate_x_resource_name): Simplify count usage.
8732 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8733
37dd57d1
PE
8734 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8735 fail (Bug#8306).
81e56e61 8736
699979fc 8737 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8738
401bf9b4
PE
8739 * process.c (Fmake_network_process): Use socklen_t, not int,
8740 where POSIX says socklen_t is required in portable programs.
8741 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8742 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8743 (Fmake_network_process, server_accept_connection):
8744 (wait_reading_process_output, read_process_output):
8745 Likewise.
8746
b93aacde
PE
8747 * process.c: Rename or move locals to avoid shadowing.
8748 (list_processes_1, Fmake_network_process):
8749 (read_process_output_error_handler, exec_sentinel_error_handler):
8750 Rename or move locals.
4dc343ee 8751 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8752 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8753 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8754 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8755 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8756
af8a867c 8757 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8758 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8759 Include tparam.h instead, since it declares them.
af8a867c
PE
8760 * cm.h (PC): Remove extern decl; tparam.h now does this.
8761 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8762 * terminfo.c: Include tparam.h, to check interfaces.
8763 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8764 (tparam): Adjust signature to match interface in tparam.h;
8765 this removes some undefined behavior. Check that outstring and len
8766 are zero, which they always are with Emacs.
8767 * tparam.h (PC, BC, UP): New extern decls.
8768
0248044d 8769 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8770 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8771
8ff096c1 8772 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8773 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8774 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8775 (ftfont_list): Remove unused local.
49eaafba
PE
8776 (get_adstyle_property, ftfont_pattern_entity):
8777 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8778 Rename locals to avoid shadowing.
8ff096c1 8779
e2be39f6
PE
8780 * xfont.c (xfont_list_family): Mark var as initialized.
8781
c9735e30
PE
8782 * xml.c (make_dom): Now static.
8783
8f5201ae
PE
8784 * composite.c (composition_compute_stop_pos): Rename local to
8785 avoid shadowing.
b246f932
PE
8786 (composition_reseat_it): Remove unused locals.
8787 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8788 (composition_update_it): Mark var as initialized.
11b61122
PE
8789 (find_automatic_composition): Mark vars as initialized,
8790 with a FIXME (Bug#8290).
8f5201ae 8791
760fbc2c
PE
8792 character.h: Rename locals to avoid shadowing.
8793 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8794 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8795 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8796 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8797 to avoid shadowing.
8798
ff08eb85
PE
8799 * textprop.c (property_change_between_p): Remove; unused.
8800
fc7bf025
PE
8801 * intervals.c (interval_start_pos): Now static.
8802
235d7abc
PE
8803 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8804
44f230aa
SM
8805 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8806 Rename locals to avoid shadowing.
3e7d6594 8807
50060332
PE
8808 * sound.c (wav_play, au_play, Fplay_sound_internal):
8809 Fix pointer signedness.
d01f234b 8810 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8811 (wav_play): Initialize a variable to 0, to prevent undefined
8812 behavior (Bug#8278).
50060332 8813
c4fc4e30
PE
8814 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8815
918436ed
PE
8816 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8817
c939f91b
PE
8818 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8819 clobbering (Bug#8298).
b9c7f648
PE
8820 * sysdep.c (sys_subshell): Likewise.
8821 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8822
6bd8c144
PE
8823 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8824 This should get cleaned up, so that child_setup has the
8825 same signature on all platforms.
8826
7710357c 8827 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8828 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8829
c59da222
CY
88302011-03-22 Chong Yidong <cyd@stupidchicken.com>
8831
8832 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8833 not to be necessary, and produces flickering.
8834
66b87493
GM
88352011-03-20 Glenn Morris <rgm@gnu.org>
8836
8837 * config.in: Remove file.
8838
45b6f6d5
JB
88392011-03-20 Juanma Barranquero <lekktu@gmail.com>
8840
8841 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8842 are now in src/globals.h.
8843 (syms_of_minibuf): Remove spurious & from previous change.
8844
cd394be1 88452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8846
8847 * minibuf.c (completing-read-function): New variable.
8848 (completing-read-default): Rename from completing-read.
8849 (completing-read): Call completing-read-function.
8850
b14e3e21
CY
88512011-03-19 Juanma Barranquero <lekktu@gmail.com>
8852
8853 * xfaces.c (Fx_load_color_file):
8854 Read color file from absolute filename (bug#8250).
8855
f2b726e6
JB
88562011-03-19 Juanma Barranquero <lekktu@gmail.com>
8857
8858 * makefile.w32-in: Update dependencies.
8859
09f6ff02
EZ
88602011-03-17 Eli Zaretskii <eliz@gnu.org>
8861
8862 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8863
29a6015a
PE
88642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8865
a3a6c54e
PE
8866 Fix more problems found by GCC 4.5.2's static checks.
8867
b766f867
PE
8868 * process.c (make_serial_process_unwind, send_process_trap):
8869 (sigchld_handler): Now static.
8870
be02381c
PE
8871 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8872 That way, the code declares only the vars that it needs.
8873 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8874 * s/cygwin.h (PTY_ITERATION): Likewise.
8875 * s/darwin.h (PTY_ITERATION): Likewise.
8876 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8877
57048744
PE
8878 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8879 * process.c (allocate_pty): Don't declare stb unless it's needed.
8880
7914961c 8881 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8882 (CONSTANTLIM): Remove; unused.
8883 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8884 Define only if needed.
7914961c 8885
b3967b18
PE
8886 * unexelf.c (unexec): Name an expression,
8887 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8888 Use a different way to cause a compilation error if anyone uses
8889 n rather than nn, a way that does not involve shadowing.
73366a00 8890 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8891
29a6015a
PE
8892 * deps.mk (unexalpha.o): Remove; unused.
8893
43cfc33e 8894 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8895 * unexec.h: New file.
ce701a33
PE
8896 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8897 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8898 Depend on unexec.h.
8899 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8900 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8901 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8902 Change as necessary to match prototype in unexec.h.
ce701a33 8903
01f44d5a
PE
8904 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8905 shadowing.
4f63c6bb 8906 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8907
a6670b0b
PE
8908 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8909 Rename locals to avoid shadowing.
8910
cef2010d 8911 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8912 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8913
d4d7173a
PE
8914 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8915
f08b802a
PE
8916 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8917 warning when compiling print.c.
8918
3ddb0639
PE
8919 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8920 instead of using an uninitialized var.
5ad03b97 8921 (font_sort_entities): Mark var as initialized.
3ddb0639 8922
170a2692
PE
8923 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8924
e663c700
PE
8925 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8926 pointers to constants.
89bc529a 8927 (font_parse_fcname): Remove unused vars.
7b81e2d0 8928 (font_delete_unmatched): Now static.
ea838e10 8929 (font_get_spec): Remove; unused.
13a547c6
PE
8930 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8931 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8932 Rename or move locals to avoid shadowing.
e663c700 8933
2a80c887 8934 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8935 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8936
1384fa33 8937 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8938 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8939
8b2c52e9
PE
8940 * alloc.c (mark_backtrace): Move decl from here ...
8941 * lisp.h: ... to here, so that it can be checked.
8942
475545b5 8943 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8944 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8945 (lisp_indirect_variable): Name an expression,
8946 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8947 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8948
b1349114 8949 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8950 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8951 Use const pointer when appropriate.
b1349114 8952
a2928364
PE
8953 * lisp.h (get_system_name, get_operating_system_release):
8954 Move decls here, to check interfaces.
8955 * process.c (get_operating_system_release): Move decl to lisp.h.
8956 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8957 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8958 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8959 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8960 (Fformat_time_string, Fencode_time, Finsert_char):
8961 (Ftranslate_region_internal, Fformat):
8962 Rename or remove local vars to avoid shadowing.
9710023e 8963 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8964
a415e694
PE
8965 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8966 avoid shadowing.
8967
8ef4622d
PE
8968 * lisp.h (eassert): Check that the argument compiles, even if
8969 ENABLE_CHECKING is not defined.
8970
946f9a5b
PE
8971 * data.c (Findirect_variable): Name an expression, to avoid
8972 gcc -Wbad-function-cast warning.
112396d6 8973 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8974 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8975 (Fmake_variable_buffer_local, Fmake_local_variable):
8976 Mark variables as initialized.
52746918 8977 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8978
e5aab7e7 8979 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8980 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8981 Rename locals to avoid shadowing.
dff45157
PE
8982 (mark_stack): Move local variables into the #ifdef region where
8983 they're used.
7bc26fdb
PE
8984 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8985 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8986 needed otherwise.
8987 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8988 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8989 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8990
e5aab7e7
PE
8991 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8992 avoids undefined behavior in theory.
8993
4da60324
PE
8994 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8995
88043301
PE
8996 Use functions, not macros, for up- and down-casing (Bug#8254).
8997 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8998 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8999 to use the following functions instead of these macros.
9000 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9001 EMACS_INT, since callers assume the returned value fits in int.
9002 (upcase1): Likewise, for UPCASE_TABLE.
9003 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9004 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9005 the race-condition problem in the old DOWNCASE.
88043301 9006
19ed5445
PE
9007 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9008 Rename locals to avoid shadowing.
9009 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9010 (regex_compile, re_search_2, re_match_2_internal):
9011 Remove unused local vars.
952db0d7
PE
9012 (FREE_VAR): Rewrite so as not to use empty "else",
9013 which gcc can warn about.
da053e48 9014 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9015 (RETALLOC_IF): Define only if needed.
9016 (WORDCHAR_P): Likewise. This one is never needed, but is used
9017 only in a comment talking about a compiler bug, so put inside
9018 the #if 0 of that comment.
9019 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9020 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9021 Remove; unused.
19ed5445 9022
1f3561e4 9023 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9024 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9025 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9026
ded6f8f7
PE
9027 * search.c (simple_search): Remove unused var.
9028
dbd37a95
PE
9029 * dired.c (compile_pattern): Move decl from here ...
9030 * lisp.h: ... to here, so that it can be checked.
9031 (struct re_registers): New forward decl.
9032
7e47afad
PE
9033 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9034
85f24f61
PE
9035 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9036 All uses changed.
9037 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9038 Rename locals to avoid shadowing.
5671df8f 9039 (Fvertical_motion): Mark locals as initialized.
85f24f61 9040
181aa2be 9041 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9042 (casify_region): Mark local as initialized.
181aa2be 9043
930d429c
PE
9044 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9045
7082eac6
PE
9046 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9047 New macros, so that the caller can use some names other than
9048 gcpro1, gcpro2, etc.
9049 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9050 of the new macros.
9051 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9052 argument, for consistency with GCPRO2_VAR, etc: it is now the
9053 prefix of the variable, not the variable itself. All uses
9054 changed.
38b2c076
PE
9055 * dired.c (directory_files_internal, file_name_completion):
9056 Rename locals to avoid shadowing.
9057
15206ed9
PE
9058 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9059 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9060 dired.c's scmp function, had undefined behavior.
9061 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9062 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9063 * buffer.h: ... to here, because these macros use current_buffer,
9064 and the new implementation with inline functions needs to have
9065 current_buffer in scope now, rather than later when the macros
9066 are used.
9067 (downcase, upcase1): New static inline functions.
9068 (DOWNCASE, UPCASE1): Reimplement using these functions.
9069 This avoids undefined behavior in expressions like
9070 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9071 from race conditions in accessing the global variables
9072 case_temp1 and case_temp2.
9073 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9074 * lisp.h (case_temp1, case_temp2): Remove their decls.
9075 * character.h (ASCII_CHAR_P): Move from here ...
9076 * lisp.h: ... to here, so that the inline functions mentioned
9077 above can use them.
9078
4a6bea26
PE
9079 * dired.c (directory_files_internal_unwind): Now static.
9080
f14b7e14
PE
9081 * fileio.c (file_name_as_directory, directory_file_name):
9082 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9083 Now static.
2893f146
PE
9084 (file_name_as_directory): Use const pointers when appropriate.
9085 (Fexpand_file_name): Likewise. In particular, newdir might
9086 point at constant storage, so make it a const pointer.
fd4ead52 9087 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9088 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9089 signedness issues.
f839df0c
PE
9090 (Fset_file_times, Finsert_file_contents, auto_save_error):
9091 Rename locals to avoid shadowing.
f14b7e14 9092
5716756e 9093 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9094 (Ftry_completion, Fall_completions): Rename or remove locals
9095 to avoid shadowing.
5716756e 9096
b4c3046a
PE
9097 * marker.c (bytepos_to_charpos): Remove; unused.
9098
b45db522
PE
9099 * lisp.h (verify_bytepos, count_markers): New decls,
9100 so that gcc does not warn that these functions aren't declared.
9101
85876d07
PE
9102 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9103 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9104 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9105 (copy_text): Remove unused local var.
85876d07 9106
03d78a21 9107 * filelock.c (within_one_second): Now static.
b3dd38ab 9108 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9109
5df8f01b
PE
9110 * buffer.c (fix_overlays_before): Mark locals as initialized.
9111 (fix_start_end_in_overlays): Likewise. This function should be
9112 simplified by using pointers-to-pointers, but that's a different
9113 matter.
b1d876f1 9114 (switch_to_buffer_1): Now static.
8f54f30a
PE
9115 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9116 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9117
a70072c9 9118 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9119 Fix pointer signedness issue.
edced198
PE
9120 (sys_subshell): Mark local as volatile if checking for lint,
9121 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9122 (MAXPATHLEN): Define only if needed.
a70072c9 9123
a0977c44
PE
9124 * process.c (serial_open, serial_configure): Move decls from here ...
9125 * systty.h: ... to here, so that they can be checked.
9126
a884fdcc
PE
9127 * fns.c (get_random, seed_random): Move extern decls from here ...
9128 * lisp.h: ... to here, so that they can be checked.
9129
604efe86 9130 * sysdep.c (reset_io): Now static.
b8950c94 9131 (wait_for_termination_signal): Remove; unused.
604efe86 9132
38fc62d9
PE
9133 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9134 (copy_keymap_item, append_key, push_text_char_description):
9135 Now static.
1004a21a 9136 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9137 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9138 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9139 (describe_map_tree):
9140 Rename locals to avoid shadowing.
38fc62d9 9141
2f2650da
PE
9142 * keyboard.c: Declare functions static if they are not used elsewhere.
9143 (echo_char, echo_dash, cmd_error, top_level_2):
9144 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9145 (read_char, kbd_buffer_get_event, make_lispy_position):
9146 (make_lispy_event, make_lispy_movement, apply_modifiers):
9147 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9148 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9149 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9150 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9151 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9152
a053e86c 9153 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9154 (mark_kboards): Move decl here ...
9155 * alloc.c (mark_kboards): ... from here.
a053e86c 9156
4752793e
PE
9157 * lisp.h (force_auto_save_soon): New decl.
9158
74f10ca7 9159 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9160 (DEFINE_DUMMY_FUNCTION): New macro.
9161 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9162 Use it.
c03cd23f
PE
9163 (main): Add casts to avoid warnings
9164 if GCC considers string literals to be constants.
74f10ca7 9165
022e70d4
PE
9166 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9167
59d6fe83
PE
9168 * dbusbind.c: Pointer signedness fixes.
9169 (xd_signature, xd_append_arg, xd_initialize):
9170 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9171 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9172 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9173 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9174
78320123
PE
9175 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9176 if GCC considers string literals to be constants.
49cebcca 9177 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9178
35ac2a97
SM
91792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9180
fb103ca9
SM
9181 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9182 (print_preprocess, print_object): New macro to fix last change.
9183
35ac2a97
SM
9184 * print.c (print_preprocess): Don't forget font objects.
9185
62973b41
JB
91862011-03-16 Juanma Barranquero <lekktu@gmail.com>
9187
9188 * emacs.c (USAGE3): Doc fixes.
9189
0e48bb22
AS
91902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9191
9192 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9193 structure.
9194
7684e57b
JB
91952011-03-14 Juanma Barranquero <lekktu@gmail.com>
9196
9197 * lisp.h (VWindow_system, Qfile_name_history):
9198 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9199 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9200 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9201
9202 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9203 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9204
9205 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9206 * w32console.c (detect_input_pending, read_input_pending)
9207 (encode_terminal_code):
9208 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9209 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9210 (w32_system_caret_y, Qfile_name_history):
9211 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9212 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9213 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9214 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9215 * w32proc.c (Qlocal, report_file_error):
9216 * w32term.c (Vwindow_system, updating_frame):
9217 * w32uniscribe.c (initialized, uniscribe_font_driver):
9218 Remove unneeded extern declarations.
9219
2aa46d6c
CY
92202011-03-14 Chong Yidong <cyd@stupidchicken.com>
9221
c96bbc66 9222 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9223
cffc6f3b
CY
92242011-03-13 Chong Yidong <cyd@stupidchicken.com>
9225
9226 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9227 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9228 These macros can no longer be used for assignment.
9229
44f230aa
SM
9230 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9231 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9232 (record_buffer_markers, fetch_buffer_markers): New functions for
9233 recording and fetching special buffer markers.
9234 (set_buffer_internal_1, set_buffer_temp): Use them.
9235
9236 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9237
9238 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9239
9240 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9241 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9242
9243 * xdisp.c (hscroll_window_tree):
9244 (reconsider_clip_changes): Use PT instead of BUF_PT.
9245
d251f04b
EZ
92462011-03-13 Eli Zaretskii <eliz@gnu.org>
9247
9248 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9249 $(EMACS_ROOT)/lib/intprops.h.
9250
f0c77cd1
PE
92512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9252
3eca4629
PE
9253 Fix more problems found by GCC 4.5.2's static checks.
9254
7c86ee98
PE
9255 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9256 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9257 (xg_free_frame_widgets): Make it clear that a local variable is
9258 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9259 (gdk_window_get_screen): Make it clear that this macro is needed
9260 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9261 (int_gtk_range_get_value): New function, which avoids a diagnostic
9262 from gcc -Wbad-function-cast.
9263 (xg_set_toolkit_scroll_bar_thumb): Use it.
9264 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9265 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9266 (get_utf8_string, xg_get_file_with_chooser):
9267 Rename locals to avoid shadowing.
9268 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9269
41729b81
PE
9270 * xgselect.c (xg_select): Remove unused var.
9271
f0c77cd1
PE
9272 * image.c (four_corners_best): Mark locals as initialized.
9273 (gif_load): Initialize transparent_p to zero (Bug#8238).
9274 Mark another local as initialized.
ec6cf4c6 9275 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9276
ce0ad53d 9277 * image.c (clear_image_cache): Now static.
d5d5a617 9278 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9279 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9280 (x_edge_detection): Remove unnecessary cast that
9281 gcc -Wbad-function-cast diagnoses.
2037898d 9282 (gif_load): Fix pointer signedness.
6ae141d6
PE
9283 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9284 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9285
33383987 92862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9287
d32df629
PE
9288 Improve quality of tests for time stamp overflow.
9289 For example, without this patch (encode-time 0 0 0 1 1
9290 1152921504606846976) returns the obviously-bogus value (-948597
9291 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9292 reports time overflow. See
9293 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9294 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9295 * editfns.c: Include limits.h and intprops.h.
9296 (TIME_T_MIN, TIME_T_MAX): New macros.
9297 (time_overflow): Move earlier, to before first use.
9298 (hi_time, lo_time): New functions, for an accurate test for
9299 out-of-range times.
9300 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9301 (Fget_internal_run_time): Don't assume time_t fits in int.
9302 (make_time): Use list2 instead of Fcons twice.
9303 (Fdecode_time): More accurate test for out-of-range times.
9304 (check_tm_member): New function.
9305 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9306 (lisp_time_argument): Don't rely on undefined left-shift and
9307 right-shift behavior when checking for time stamp overflow.
8be6f318 9308
fe31d94c
PE
9309 * editfns.c (time_overflow): New function, refactoring common code.
9310 (Fformat_time_string, Fdecode_time, Fencode_time):
9311 (Fcurrent_time_string): Use it.
9312
8be6f318
PE
9313 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9314 * dired.c (make_time): Move to ...
9315 * editfns.c (make_time): ... here.
9316 * systime.h: Note the move.
9317
09d9db2c 93182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9319
126bc0dc
YM
9320 * fringe.c (update_window_fringes): Remove unused variables.
9321
c47cbdfd
YM
9322 * unexmacosx.c (copy_data_segment): Also copy __got section.
9323 (Bug#8223)
9324
7ac80be9
EZ
93252011-03-12 Eli Zaretskii <eliz@gnu.org>
9326
c96bbc66 9327 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9328 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9329 Constify `char *' arguments and their references according to
9330 prototypes in tparam.h.
9331
ecb0f94d 9332 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9333
7ac80be9
EZ
9334 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9335 Adapt all references accordingly.
9336
9337 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9338
ef1fd07e
TT
93392011-03-11 Tom Tromey <tromey@redhat.com>
9340
9341 * buffer.c (syms_of_buffer): Remove obsolete comment.
9342
7ef4b50c
EZ
93432011-03-11 Eli Zaretskii <eliz@gnu.org>
9344
9345 * termhooks.h (encode_terminal_code): Declare prototype.
9346
9347 * msdos.c (encode_terminal_code): Don't declare prototype.
9348
9349 * term.c (encode_terminal_code): Now external again, used by
9350 w32console.c and msdos.c.
9351
44f230aa
SM
9352 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9353 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9354
4b1ec863 93552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9356
1714f52b 9357 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9358
4b1ec863
PE
9359 * fringe.c (update_window_fringes): Mark locals as initialized
9360 (Bug#8227).
9361 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9362
524c7aa6
PE
9363 * alloc.c (mark_fringe_data): Move decl from here ...
9364 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9365 to check its interface.
9366 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9367
a5c0af81 9368 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9369 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9370 (fontset_font): Mark local as initialized.
a9a06e0b 9371 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9372
b4716021
PE
9373 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9374
811e9bac 9375 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9376 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9377 (x_own_selection, Fx_disown_selection_internal): Rename locals
9378 to avoid shadowing.
9379 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9380
7e3ab302
PE
9381 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9382 so that the caller can use some name other than gcpro1.
9383 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9384 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9385 (Fx_backspace_delete_keys_p):
9386 Use them to avoid shadowing, and rename vars to avoid shadowing.
9387 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9388 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9389 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9390 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9391 Remove unused locals.
7e3ab302
PE
9392 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9393 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9394 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9395 macros.
f78faa98 9396
e2b13473
PE
9397 * xterm.h (x_mouse_leave): New decl.
9398
77f23912
PE
9399 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9400 Remove unused functions.
cdf4ba58
PE
9401 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9402 (x_calc_absolute_position): Now static.
7411c686 9403 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9404 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9405 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9406 unless they are used.
38d0b34a
PE
9407 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9408 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9409 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9410 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9411 (x_error_catcher, x_connection_closed, x_error_handler):
9412 (x_error_quitter, xembed_send_message, x_iconify_frame):
9413 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9414 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9415 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9416
44f230aa
SM
9417 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9418 Rename or move locals to avoid shadowing.
6b463e58 9419 (tty_defined_color, merge_face_heights): Now static.
5967d051 9420 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9421 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9422 does not deduce is never used uninitialized.
73719eba
PE
9423 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9424 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9425
426994c3 9426 * terminal.c (store_terminal_param): Now static.
5489860b 9427
032f1620 9428 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9429 (set_frame_menubar): Remove unused local.
d4323972 9430 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9431 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9432 since they might point to immutable storage.
281585b0
PE
9433 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9434 since it's unused otherwise.
032f1620 9435
367c19e5 9436 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9437 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9438 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9439 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9440 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9441 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9442 does not deduce are never used uninitialized.
70739cbe 9443
07b48fa9
PE
9444 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9445
8868a238 9446 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9447 * window.c (window_loop, size_window):
9448 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9449
7e5cf297 9450 * window.c (display_buffer): Now static.
d6550a9f
PE
9451 (size_window): Mark variables that gcc -Wuninitialized
9452 does not deduce are never used uninitialized.
a586633d
PE
9453 * window.h (check_all_windows): New decl, to forestall
9454 gcc -Wmissing-prototypes diagnostic.
5b555da1 9455 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9456
f6095868
PE
9457 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9458 shadowing.
9459 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9460 Include <limits.h>.
9461 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9462 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9463 (load_charset_map): Mark variables that gcc -Wuninitialized
9464 does not deduce are never used uninitialized.
53df7c11 9465 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9466
f38b440c
PE
9467 * coding.c (coding_set_source, coding_set_destination):
9468 Use "else { /* comment */ }" rather than "else /* comment */;"
9469 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9470 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9471 a block, when the outer 'i' will do.
9472 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9473 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9475 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9476 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9477 Rename locals to avoid shadowing.
9478 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9479 * coding.c (emacs_mule_char, encode_invocation_designation):
9480 Now static, since they're not used elsewhere.
413bb2db 9481 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9482 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9483 (decode_coding_emacs_mule): Mark variables that gcc
9484 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9485 (detect_coding_iso_2022): Initialize a local variable that might
9486 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9487 this initialization is needed. (Bug#8211)
5f58e762
PE
9488 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9489 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9490 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9491 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9492 Remove unused macros.
f38b440c 9493
232b38b9 9494 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9495 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9496 * character.c (string_count_byte8): Likewise.
232b38b9 9497
fb90da1b
PE
9498 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9499 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9500
fb93dbc2
PE
9501 * chartab.c (copy_sub_char_table): Now static, since it's not used
9502 elsewhere.
5c156ace
PE
9503 (sub_char_table_ref_and_range, char_table_ref_and_range):
9504 Rename locals to avoid shadowing.
bbcd0949 9505 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9506
7d3b3862 9507 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9508 (BIDI_BOB): Remove unused macro.
7d3b3862 9509
6be7d3da
PE
9510 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9511 deduce are never used uninitialized.
c2ed9c8b 9512 * term.c (encode_terminal_code): Likewise.
6be7d3da 9513
75f8807f 9514 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9515
50938595
PE
9516 * tparam.h: New file.
9517 * term.c, tparam.h: Include it.
9518 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9519 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9520 Move these decls to tparam.h, and make them agree with what
9521 is actually in tparam.c. The previous trick of using incompatible
9522 decls in different modules does not conform to the C standard.
9523 All callers of tparam changed to use tparam's actual API.
9524 * tparam.c (tparam1, tparam, tgoto):
9525 Use const pointers where appropriate.
9526
fbceeba2
PE
9527 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9528 * cm.h (struct cm): Likewise.
9529 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9530 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9531 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9532 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9533 (turn_on_face, init_tty): Likewise.
9534 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9535
7f3f1250
PE
9536 * term.c (term_mouse_position): Rename local to avoid shadowing.
9537
e6ca6543
PE
9538 * alloc.c (mark_ttys): Move decl from here ...
9539 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9540
c40f8d15
AS
95412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9542
9543 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9544
cfe0661d
JB
95452011-03-09 Juanma Barranquero <lekktu@gmail.com>
9546
9547 * search.c (compile_pattern_1): Remove argument regp, unused since
9548 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9549 (compile_pattern): Don't pass it.
9550
0afb4571
J
95512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9552
9553 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9554 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9555 for ! HAVE_GTK3.
9556 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9557
9558 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9559
9560 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9561 gdk_window_get_screen, gdk_window_get_geometry,
9562 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9563 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9564 (xg_get_pixbuf_from_pixmap): New function.
9565 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9566 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9567 Call xg_get_pixbuf_from_pixmap instead of
9568 gdk_pixbuf_get_from_drawable.
9569 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9570 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9571 (xg_check_special_colors): Use GtkStyleContext and its functions
9572 for HAVE_GTK3.
9573 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9574 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9575 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9576 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9577 Call gtk_widget_get_preferred_size.
0afb4571
J
9578 (xg_frame_resized): gdk_window_get_geometry only takes 5
9579 parameters.
44f230aa
SM
9580 (xg_win_to_widget, xg_event_is_for_menubar):
9581 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9582 (xg_set_widget_bg): New function.
9583 (delete_cb): New function.
895009e1 9584 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9585 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9586 (xg_set_background_color): Call xg_set_widget_bg.
9587 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9588 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9589 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9590 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9591 if ! HAVE_GTK3.
9592 (update_frame_tool_bar): Call gtk_widget_hide.
9593 (xg_initialize): Use GDK_KEY_g.
9594
9595 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9596 if ! HAVE_GTK3
9597 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9598
9599 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9600 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9601 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9602
1c2cc4ef
JB
96032011-03-08 Juanma Barranquero <lekktu@gmail.com>
9604
9605 * w32xfns.c (select_palette): Check success of RealizePalette against
9606 GDI_ERROR, not zero.
9607
33383987 9608See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9609
9610;; Local Variables:
9611;; coding: utf-8
aac0c6e3
MR
9612;; End:
9613
acaf905b 9614 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9615
9616 This file is part of GNU Emacs.
9617
9618 GNU Emacs is free software: you can redistribute it and/or modify
9619 it under the terms of the GNU General Public License as published by
9620 the Free Software Foundation, either version 3 of the License, or
9621 (at your option) any later version.
9622
9623 GNU Emacs is distributed in the hope that it will be useful,
9624 but WITHOUT ANY WARRANTY; without even the implied warranty of
9625 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9626 GNU General Public License for more details.
9627
9628 You should have received a copy of the GNU General Public License
9629 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.