Backports for 1995-05-29T20:16:10Z!kwzh@gnu.org, 1995-05-03T21:38:13Z!rms@gnu.org...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c17d5a38
JD
12012-08-12 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (ns_read_socket): Return early if there is a modal
4 window (Bug#12043).
5
6 * nsmenu.m (Popdown_data): New struct.
7 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
8 free Popdown_data.
9 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
10 (initWithContentRect): Make imgView and contentView non-static
11 and autorelease them. Also autorelease img and matrix (Bug#12005).
12 (dealloc): Remove (Bug#12005).
13
14 * nsterm.m (keyDown:): Interpret flags without left/right bits
15 as the left key (Bug#11670).
16
17 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
18
8ccd072a
YM
192012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
20
21 * unexmacosx.c (copy_data_segment): Copy initialized data in
22 statically linked libraries from input file rather than memory.
23
db74a5fc
YM
242012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
25
26 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
27 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
28 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
29
23dc7744
CY
302012-07-19 Chong Yidong <cyd@gnu.org>
31
32 * window.c (Fwindow_absolute_pixel_edges)
33 (Fdelete_other_windows_internal): Signal an error if the window is
34 on a dead frame (Bug#11984).
35
fbf31a9c
EZ
362012-07-14 Eli Zaretskii <eliz@gnu.org>
37
38 Remove FILE_SYSTEM_CASE.
39 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
40
41 * fileio.c (FILE_SYSTEM_CASE): Don't define.
42 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
43 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
44 call-process-region passes it through expand-file-name.
45
46 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
47
8a05d57a
AS
482012-07-12 Andreas Schwab <schwab@linux-m68k.org>
49
50 Fix crash when creating indirect buffer (Bug#11917)
51 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
52 Don't handle unbound variables specially if non-zero.
53 (Fbuffer_local_variables): Pass zero.
54 (clone_per_buffer_values): Pass non-zero.
55
57570cd3
AS
562012-06-28 Andreas Schwab <schwab@linux-m68k.org>
57
58 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
59 to make the loop interruptible.
60
d01fd55f
AS
612012-06-26 Andreas Schwab <schwab@linux-m68k.org>
62
63 * gnutls.c (emacs_gnutls_handshake): Only retry if
64 GNUTLS_E_INTERRUPTED.
65
c81b46f6
EZ
662012-06-23 Eli Zaretskii <eliz@gnu.org>
67
68 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
69 in the logic of incrementing and decrementing the value of
70 use_relocatable_buffers.
71
63541ed8
GM
722012-06-21 Glenn Morris <rgm@gnu.org>
73
74 * charset.c (init_charset): Make lack of etc/charsets fatal.
75
50a93863
JD
762012-06-11 Jan Djärv <jan.h.d@swipnet.se>
77
78 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
79 referenced (Bug#11583).
80
94f0aa34
CY
812012-06-01 Chong Yidong <cyd@gnu.org>
82
83 * Version 24.1 released.
84
d5fd2c54
EZ
852012-05-30 Eli Zaretskii <eliz@gnu.org>
86
87 * xdisp.c (handle_stop): Detect whether we have overlay strings
88 loaded by testing it->current.overlay_string_index to be
89 non-negative, instead of checking whether n_overlay_strings is
90 positive. (Bug#11587)
91
353c87f6
CY
922012-05-30 Chong Yidong <cyd@gnu.org>
93
94 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
95
96 * doc.c (Fsubstitute_command_keys): Doc fix.
97
a02ae4e5
EZ
982012-05-29 Eli Zaretskii <eliz@gnu.org>
99
100 * search.c (search_buffer): Remove calls to
101 r_alloc_inhibit_buffer_relocation, as it is now called by
102 maybe_unify_char, which was the cause of relocation of buffer text
103 in bug#11519.
104
291d430f
EZ
1052012-05-23 Eli Zaretskii <eliz@gnu.org>
106
107 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
108 for the duration of call to load_charset, to avoid problems with
109 callers of maybe_unify_char that access buffer text through C
110 pointers.
111
112 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
113 decrement the inhibition flag, instead of just setting or
114 resetting it.
115
2f9b9adb
KB
1162012-05-24 Ken Brown <kbrown@cornell.edu>
117
118 * callproc.c (Fcall_process): Restore a line that was accidentally
119 commented out in the 2011-02-13 change (bug#11547).
120
52c55cc7
EZ
1212012-05-23 Eli Zaretskii <eliz@gnu.org>
122
123 * lisp.h [REL_ALLOC]: Add prototypes for external functions
124 defined on ralloc.c.
125
126 * buffer.c [REL_ALLOC]: Remove prototypes of
127 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
128 they are now on lisp.h.
129
130 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
131
132 * search.c (search_buffer): Use it to inhibit relocation of buffer
133 text while re_search_2 is doing its job, because re_search_2 is
134 passed C pointers to buffer text. (Bug#11519)
135
23415acf
EZ
1362012-05-21 Eli Zaretskii <eliz@gnu.org>
137
138 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
139 Update value to 24.
140
44e27368
EZ
1412012-05-19 Eli Zaretskii <eliz@gnu.org>
142
143 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
144 state after an additional call to move_it_in_display_line_to, keep
145 the values of it->max_ascent and it->max_descent found for the
146 entire line.
147 (pos_visible_p): Revert the comparison against bottom_y to what it
148 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
149 (Bug#11464)
150
ccbf309c
EZ
1512012-05-15 Eli Zaretskii <eliz@gnu.org>
152
153 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
154
ac268e67
EZ
1552012-05-13 Eli Zaretskii <eliz@gnu.org>
156
157 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
158 already have overlays loaded.
159 (handle_single_display_spec): Before returning without displaying
160 fringe bitmap, synchronize the bidi iterator with the main display
161 iterator, by calling iterate_out_of_display_property.
162 (iterate_out_of_display_property): Detect buffer iteration by
163 testing that it->string is a Lisp string.
164 (get_next_display_element): When the current object is exhausted,
165 and there's something on it->stack, call set_iterator_to_next to
166 proceed with what's on the stack, instead of returning zero.
167 (set_iterator_to_next): If called at the end of a Lisp string,
168 proceed to consider_string_end without incrementing string
169 position. Don't increment display vector index past the end of
170 the display vector. (Bug#11417)
c8fb9dc6
EZ
171 (pos_visible_p): Don't report a position visible when move_it_to
172 stopped at the last line of window, which happens to be scanned
173 backwards by the bidi iteration. (Bug#11464)
ac268e67 174
82f9b393
EZ
1752012-05-11 Eli Zaretskii <eliz@gnu.org>
176
177 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
178 and right-margin display specs even if the spec is invalid or we
179 are on a TTY, and thus unable to display on the fringes. That's
180 because the text with the property will not be displayed anyway,
181 so we need to signal to the caller that this is a "replacing"
182 display spec. This fixes display when the spec is invalid or we
183 are on a TTY.
184
297834cd
PE
1852012-05-09 Paul Eggert <eggert@cs.ucla.edu>
186
187 * unexaix.c (make_hdr): Fix typo in prototype.
188 This bug broke the build on AIX. Problem reported by Gilles Pion.
189
0d887c7d
EZ
1902012-05-05 Eli Zaretskii <eliz@gnu.org>
191
192 * w32proc.c (new_child): Force Windows to reserve only 64KB of
193 stack for each reader_thread, instead of defaulting to 8MB
194 determined by the linker. This avoids failures in creating
195 subprocesses on Windows 7, see the discussion in this thread:
196 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
197
bf98199c
JM
1982012-05-02 Jim Meyering <meyering@redhat.com>
199
200 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
201
2fa85638
EZ
2022012-04-29 Eli Zaretskii <eliz@gnu.org>
203
204 * xdisp.c (pos_visible_p): If already at a newline from the
205 display string before the 'while' loop, don't walk back the glyphs
206 from it3.glyph_row. Solves assertion violation when the display
207 string begins with a newline (egg.el). (Bug#11367)
208
9be2fd9b
CY
2092012-04-24 Chong Yidong <cyd@gnu.org>
210
211 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
212
f0ee99a0
EZ
2132012-04-23 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (pos_visible_p): If the window start position is beyond
216 ZV, start the display from buffer beginning. Prevents assertion
217 violation in init_iterator when the minibuffer window is scrolled
218 via the scroll bar.
219
220 * window.c (window_scroll_pixel_based): Likewise.
221
9ec7751f
CY
2222012-04-23 Chong Yidong <cyd@gnu.org>
223
224 * keymap.c (where_is_internal): Doc fix (Bug#10872).
225
24c51a09
GM
2262012-04-20 Glenn Morris <rgm@gnu.org>
227
228 * fileio.c (Fcopy_file, Fset_file_selinux_context):
229 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
230
73055685
EZ
2312012-04-20 Eli Zaretskii <eliz@gnu.org>
232
233 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
234 overrun array limits of glyph row's used[] array. (Bug#11288)
235
f30d612a
CY
2362012-04-20 Chong Yidong <cyd@gnu.org>
237
238 * process.c (wait_reading_process_output): If EIO occurs on a pty,
239 set the status to "failed" and ensure that sentinel is run.
240
016a35df
GM
2412012-04-18 Glenn Morris <rgm@gnu.org>
242
243 * process.c (Fset_process_inherit_coding_system_flag)
244 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 245 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 246
20a68157
EZ
2472012-04-17 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (string_buffer_position_lim): Limit starting position to
250 BEGV.
251 (set_cursor_from_row): If called for a mode-line or header-line
252 row, return zero immediately.
253 (try_cursor_movement): If inside continuation line, don't back up
254 farther than the first row after the header line, if any. Don't
255 consider the header-line row as "partially visible", even if
256 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
257
ad3a2b41
AO
2582012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
259
260 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
261
e63c261b
CY
2622012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
263
264 * process.c (make_process):
265 * process.h: Add integer `gnutls_handshakes_tried' member to
266 process struct.
267
ad3a2b41
AO
268 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
269 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
270
271 * gnutls.c (gnutls_log_function2i): Convenience log function.
272 (emacs_gnutls_read): Use new log functions,
273 `gnutls_handshakes_tried' process member, and
274 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
275 attempts per process (connection).
276
e53357c4
EZ
2772012-04-09 Eli Zaretskii <eliz@gnu.org>
278
279 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
280 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
281
aff67c82
JD
2822012-04-09 Jan Djärv <jan.h.d@swipnet.se>
283
284 * nsterm.m (constrainFrameRect): Always constrain when there is only
285 one screen (Bug#10962).
286
2f8e16b2
EZ
2872012-04-06 Eli Zaretskii <eliz@gnu.org>
288
289 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
290 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
291 about subtle differences between FETCH_CHAR* and STRING_CHAR*
292 macros related to unification of CJK characters. For the details,
293 see the discussion following the message here:
294 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
295
3d439cd1
CY
2962012-04-04 Chong Yidong <cyd@gnu.org>
297
298 * keyboard.c (Vdelayed_warnings_list): Doc fix.
299
8bc53d00
EZ
3002012-04-01 Eli Zaretskii <eliz@gnu.org>
301
302 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
303 instead of alloca. (Bug#11138)
304
3b0512a3
AS
3052012-04-01 Andreas Schwab <schwab@linux-m68k.org>
306
307 * w32menu.c (is_simple_dialog): Properly check lisp types.
308 (Bug#11141)
309
8427ddd2
EZ
3102012-03-31 Eli Zaretskii <eliz@gnu.org>
311
979022ef
EZ
312 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
313 position we get to after a call to move_it_to fails the
314 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
315 only if we wind up in a string from display property. (Bug#11063)
316
a6b1c7cc
EZ
317 * window.c (Fdelete_other_windows_internal): Invalidate the row
318 and column information about mouse highlight, so that redisplay
319 restores it after reallocating the glyph matrices. (Bug#7464)
320
8427ddd2
EZ
321 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
322 string comes from a `display' text property, use the buffer
323 position of that property as if we actually saw that position in
324 the row's glyphs.
697ba24b
EZ
325 (move_it_by_lines): Remove the assertion that
326 "it->current_x == 0 && it->hpos == 0" which can be legitimately
327 violated when there's a before-string at the beginning of a line.
328 (Bug#11063)
8427ddd2 329
65a0a738
EZ
3302012-03-30 Eli Zaretskii <eliz@gnu.org>
331
332 * xdisp.c (append_space_for_newline): If the default face was
333 remapped, use the remapped face for the appended newline.
334 (extend_face_to_end_of_line): Use the remapped default face for
335 extending the face to the end of the line.
336 (display_line): Call extend_face_to_end_of_line when the default
337 face was remapped. (Bug#11068)
338
581355cc
EZ
3392012-03-29 Eli Zaretskii <eliz@gnu.org>
340
341 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
342
e8fc049f
SM
3432012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
344
345 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
346
4fb9a543
GM
3472012-03-27 Glenn Morris <rgm@gnu.org>
348
349 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
350 Doc fixes.
351
679910f1
KH
3522012-03-26 Kenichi Handa <handa@m17n.org>
353
354 * dispextern.h (struct glyph): Fix previous change. Change the
355 bit length of glyphless.ch to 25 (Bug#11082).
356
90d49b7f
CY
3572012-03-26 Chong Yidong <cyd@gnu.org>
358
359 * keyboard.c (Vselection_inhibit_update_commands): New variable.
360 (command_loop_1): Use it; inhibit selection update for
361 handle-select-window too (Bug#8996).
362
f514f6f0
FP
3632012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
364
e8fc049f 365 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 366
bf43fa51
KH
3672012-03-25 Kenichi Handa <handa@m17n.org>
368
369 * dispextern.h (struct glyph): Change the bit length of
370 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
371
8a0c01dd
EZ
3722012-03-24 Eli Zaretskii <eliz@gnu.org>
373
374 * s/ms-w32.h (tzname): Include time.h before redirecting to
375 _tzname. Fixes the MSVC build. (Bug#9960)
376
7d1c3a76
AS
3772012-03-24 Andreas Schwab <schwab@linux-m68k.org>
378
8ed79523
AS
379 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
380 characters.
381
7d1c3a76
AS
382 * xterm.c (XTread_socket): Only modify handling_signal if
383 !SYNC_INPUT. (Bug#11080)
384
e99a9b8b
EZ
3852012-03-23 Eli Zaretskii <eliz@gnu.org>
386
387 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
388 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
389 when fetching a multibyte character consumes more bytes than
390 CHAR_BYTES returns, due to unification of CJK characters in
391 string_char. (Bug#11073)
392
5063c0e1
TN
3932012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
394
395 * process.c (wait_reading_process_output): Handle pty disconnect
396 by refraining from sending oneself a SIGCHLD (bug#10933).
397
9f851fbd
CY
3982012-03-22 Chong Yidong <cyd@gnu.org>
399
400 * dispextern.h (struct it): New member string_from_prefix_prop_p.
401
5063c0e1 402 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
403 Mark string as coming from a prefix property.
404 (handle_face_prop): Use default face for prefix strings (Bug#4281).
405 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
406
fb5b8aca
CY
4072012-03-21 Chong Yidong <cyd@gnu.org>
408
409 * xfaces.c (Vface_remapping_alist): Doc fix.
410
62356a1b
EZ
4112012-03-20 Eli Zaretskii <eliz@gnu.org>
412
413 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
414 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
415 Doc fixes.
62356a1b 416
025de85b
CY
4172012-03-20 Chong Yidong <cyd@gnu.org>
418
419 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
420 to reflect default non-nil value of redisplay-dont-pause.
421
4827f94e
KH
4222012-03-19 Kenichi Handa <handa@m17n.org>
423
424 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
425 it fit in a valid range (Bug#11003).
426
e50a24a2
EZ
4272012-03-18 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
430 that is not from display property, accept the row as a "cursor
431 row" if one of the string's character has a non-nil `cursor'
432 property. Fixes cursor positioning when there are newlines in
433 overlay strings, e.g. in icomplete.el. (Bug#11035)
434
9af5ed87
PE
4352012-03-12 Paul Eggert <eggert@cs.ucla.edu>
436
437 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
438
d1f55f16
CY
4392012-03-12 Chong Yidong <cyd@gnu.org>
440
441 * eval.c (inhibit_lisp_code): Rename from
442 inhibit_window_configuration_change_hook; move from window.c.
443
444 * xfns.c (unwind_create_frame_1, Fx_create_frame):
445 * window.c (run_window_configuration_change_hook)
446 (syms_of_window): Callers changed.
447
66c5eebd
CY
4482012-03-11 Chong Yidong <cyd@gnu.org>
449
413df973
CY
450 * keymap.c (Fkey_description): Doc fix (Bug#9700).
451
66c5eebd
CY
452 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
453
1de11f56
CY
4542012-03-10 Chong Yidong <cyd@gnu.org>
455
456 * frame.c (other_visible_frames): Don't assume the selected frame
457 is visible (Bug#10955).
458
cae07000
SM
4592012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
460
461 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
462
89c94350
JD
4632012-03-08 Jan Djärv <jan.h.d@swipnet.se>
464
465 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
466 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
467 zero (Bug#10954).
468
999dd333
GM
4692012-03-03 Glenn Morris <rgm@gnu.org>
470
01a6dcc8 471 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 472
de0100f2
EZ
4732012-03-02 Eli Zaretskii <eliz@gnu.org>
474
475 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
476 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
477 (redisplay_window, next_element_from_string): Fix typos in
478 comments.
3e441275
EZ
479 (redisplay_window): Pass to move_it_vertically the margin in
480 pixels, not in screen lines.
de0100f2 481
96a72ee9
GM
4822012-03-02 Glenn Morris <rgm@gnu.org>
483
484 * buffer.c (buffer-list-update-hook): Doc fix.
485
312508d7
EZ
4862012-02-29 Eli Zaretskii <eliz@gnu.org>
487
488 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
489 push_it before setting up the iterator for the first overlay
490 string, even if we have an empty string loaded.
491 (next_overlay_string): If there's an empty string on the iterator
492 stack, pop the stack. (Bug#10903)
493
27f3c637
PE
4942012-02-25 Paul Eggert <eggert@cs.ucla.edu>
495
496 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
497 Suggested by Stefan Monnier in
498 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
499 * alloc.c (widen_to_Lisp_Object): New static function.
500 (mark_memory): Also mark Lisp_Objects by fetching pointer words
501 and widening them to Lisp_Objects. This would work even if
502 USE_LSB_TAG is defined and wide integers are used, which might
503 happen in a future version of Emacs.
504
3c9dfce6
CY
5052012-02-25 Chong Yidong <cyd@gnu.org>
506
fa74b241
CY
507 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
508 Doc fix.
509
3c9dfce6
CY
510 * xselect.c (Fx_selection_exists_p): Doc fix.
511 (x_clipboard_manager_save_all): Print an informative message
512 before saving to clipboard manager.
513
9486df08
CY
5142012-02-24 Chong Yidong <cyd@gnu.org>
515
516 * keyboard.c (process_special_events): Handle all X selection
517 requests in kbd_buffer, not just the next one (Bug#8869).
518
f01d3321
CY
5192012-02-23 Chong Yidong <cyd@gnu.org>
520
521 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
522 call when setting menu-bar-lines and tool-bar-lines parameters.
523 (unwind_create_frame_1): New helper function.
524
525 * window.c (inhibit_window_configuration_change_hook): New var.
526 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 527 (syms_of_window): Initialize it.
f01d3321 528
86b847b6
CY
5292012-02-22 Chong Yidong <cyd@gnu.org>
530
531 * xterm.c (x_draw_image_relief): Add missing type check for
532 Vtool_bar_button_margin (Bug#10743).
533
a59225b1
CY
5342012-02-21 Chong Yidong <cyd@gnu.org>
535
536 * fileio.c (Vfile_name_handler_alist): Doc fix.
537
538 * buffer.c (Fget_file_buffer): Protect against invalid file
539 handler return value.
540
310f5bd4
PE
5412012-02-20 Paul Eggert <eggert@cs.ucla.edu>
542
cb3a28cc
PE
543 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
544 when computing $valmask.
545
310f5bd4
PE
546 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
547 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
548 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
549 It's useless in that case, and it can cause problems on hosts
550 that allocate halves of EMACS_INT values separately.
551 Reported by Dan Horák. Diagnosed by Andreas Schwab in
552 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
553 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
554 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
555 it avoids undefined behavior on hosts where shifting right by more
556 than the word width has undefined behavior.
557
2375c96a
CY
5582012-02-19 Chong Yidong <cyd@gnu.org>
559
560 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
561 (Funhandled_file_name_directory, Ffile_name_as_directory)
562 (Fdirectory_file_name, Fexpand_file_name)
563 (Fsubstitute_in_file_name): Protect against invalid file handler
564 return values (Bug#10845).
565
3eb49e71
EZ
5662012-02-18 Eli Zaretskii <eliz@gnu.org>
567
568 * .gdbinit (pitx): Fix incorrect references to fields of the
569 iterator stack.
570
7b926f3f
CY
5712012-02-17 Chong Yidong <cyd@gnu.org>
572
573 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
574
11273115
PE
5752012-02-15 Paul Eggert <eggert@cs.ucla.edu>
576
577 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
578 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
579
c3a70e2b
CY
5802012-02-15 Chong Yidong <cyd@gnu.org>
581
582 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
583 marked as special. Also, starting docstrings with * is obsolete.
584
0ca43699
AS
5852012-02-13 Andreas Schwab <schwab@linux-m68k.org>
586
587 * gnutls.c (emacs_gnutls_write): Fix last change.
588
2e8f3c56
LI
5892012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
590
591 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
592 send_process.
593
af70074f
SM
5942012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
595
596 * keymap.c (Fsingle_key_description): Handle char ranges.
597
95986d52
CY
5982012-02-12 Chong Yidong <cyd@gnu.org>
599
afd83bd1
CY
600 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
601 as that creates a dangerous corner case.
602
95986d52
CY
603 * window.c (Fdelete_window_internal): Invalidate the mouse
604 highlight (Bug#9904).
605
bd7da63e
GM
6062012-02-12 Glenn Morris <rgm@gnu.org>
607
608 * xselect.c (Fx_own_selection_internal)
609 (Fx_get_selection_internal, Fx_disown_selection_internal)
610 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
611 * nsselect.m (Fx_own_selection_internal)
612 (Fx_disown_selection_internal, Fx_selection_exists_p)
613 (Fx_selection_owner_p, Fx_get_selection_internal):
614 Sync docs and argument specs with the xselect.c versions.
615
77abcbc2
LI
6162012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
617
618 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
619
90b671e2
EZ
6202012-02-11 Eli Zaretskii <eliz@gnu.org>
621
1c0ca0b7
EZ
622 * w32select.c (Fx_selection_exists_p): Sync doc string and
623 argument list with xselect.c. (Bug#10783)
624
625 * w16select.c (Fx_selection_exists_p): Sync doc string and
626 argument list with xselect.c. (Bug#10783)
90b671e2 627
49241268
GM
6282012-02-10 Glenn Morris <rgm@gnu.org>
629
630 * fns.c (Fsecure_hash): Doc fix.
631
f998bbe7 6322012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
633
634 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
635
0992bd9c
CY
6362012-02-07 Chong Yidong <cyd@gnu.org>
637
638 * buffer.c (Fbuffer_local_variables)
639 (buffer_lisp_local_variables): Handle unbound vars correctly;
640 don't let Qunbound leak into Lisp.
641
af008560
GM
6422012-02-07 Glenn Morris <rgm@gnu.org>
643
dd605cc4
GM
644 * image.c (Fimagemagick_types): Doc fix.
645
af008560
GM
646 * image.c (imagemagick-render-type): Change it from a lisp object
647 to an integer. Move the doc here from the lisp manual.
648 Treat all values not equal to 0 the same.
649
1449fa1d
CY
6502012-02-06 Chong Yidong <cyd@gnu.org>
651
652 * doc.c (store_function_docstring): Avoid applying docstring of
653 alias to base function (Bug#2603).
654
3723ec07
AS
6552012-02-04 Andreas Schwab <schwab@linux-m68k.org>
656
657 * .gdbinit (pp1, pv1): Remove redundant defines.
658 (pr): Use pp.
659
79c1cc1e
CY
6602012-02-04 Chong Yidong <cyd@gnu.org>
661
662 * nsterm.m: Declare a global (Bug#10694).
663
d7f29f8e
EZ
6642012-02-04 Eli Zaretskii <eliz@gnu.org>
665
cae07000
SM
666 * w32.c (get_emacs_configuration_options):
667 Include --enable-checking, if specified, in the return value.
d7f29f8e 668
3b95a6f9
MR
6692012-02-04 Martin Rudalics <rudalics@gmx.at>
670
671 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
672 after rounding frame sizes. (Bug#9723)
673
d6fa96a6
EZ
6742012-02-04 Eli Zaretskii <eliz@gnu.org>
675
676 * keyboard.c (adjust_point_for_property): Don't position point
677 before BEGV. (Bug#10696)
678
df0b2940
PE
6792012-02-03 Paul Eggert <eggert@cs.ucla.edu>
680
681 Handle overflow when computing char display width (Bug#9496).
682 * character.c (char_width): Return EMACS_INT, not int.
683 (char_width, c_string_width): Check for overflow when
684 computing the width; this is possible now that individual
685 characters can have unbounded width. Problem introduced
686 by merge from Emacs 23 on 2012-01-19.
687
6bee44d6
MA
6882012-02-02 Michael Albinus <michael.albinus@gmx.de>
689
690 * dbusbind.c (Fdbus_register_method): Mention the return value
691 :ignore in the docstring.
692
44f92739
GM
6932012-02-02 Glenn Morris <rgm@gnu.org>
694
1b9f60cc
GM
695 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
696
44f92739
GM
697 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
698 Unconditionally set to t. (Bug#10673)
699 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
700 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
701 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
702
c5d3843c
KH
7032012-02-02 Kenichi Handa <handa@m17n.org>
704
705 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
706 0, do not call append_composite_glyph.
707
159462d4 7082012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
709
710 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
711 NULL (Bug#6988).
712 (x_produce_glyphs): If the component of a composition is a null
713 string, set it->pixel_width to 1 to avoid zero-width glyph.
714
78cef877
EZ
7152012-02-01 Eli Zaretskii <eliz@gnu.org>
716
717 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
718 first 2 arguments are identical. This makes inserting large
719 output from a subprocess an order of magnitude faster on
720 MS-Windows, where all sbrk'ed memory is always contiguous.
721
97897668
GM
7222012-01-31 Glenn Morris <rgm@gnu.org>
723
724 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 725 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
726 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
727
31fd3586
GM
7282012-01-29 Glenn Morris <rgm@gnu.org>
729
730 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
731
0e24a8b2
CY
7322012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
733
734 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
735
cc0adcb0
CY
7362012-01-28 Chong Yidong <cyd@gnu.org>
737
738 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
739
acc28cb9
CY
7402012-01-26 Chong Yidong <cyd@gnu.org>
741
9c69cfb7
CY
742 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
743
acc28cb9
CY
744 * search.c (Fsearch_forward, Fsearch_backward): Document negative
745 repeat counts (Bug#10507).
746
48da7392
GM
7472012-01-26 Glenn Morris <rgm@gnu.org>
748
749 * lread.c (syms_of_lread): Doc fix.
750
14af5f7f
CY
7512012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
752
753 * coding.c (encode_designation_at_bol): Change return value to
754 EMACS_INT.
755
0b21c100
CY
7562012-01-25 Chong Yidong <cyd@gnu.org>
757
758 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
759
3c2907f7
CY
7602012-01-21 Chong Yidong <cyd@gnu.org>
761
762 * floatfns.c (Fcopysign): Make the second argument non-optional,
763 since nil is not allowed anyway.
764
959ad23f
AS
7652012-01-21 Andreas Schwab <schwab@linux-m68k.org>
766
767 * process.c (read_process_output): Use p instead of XPROCESS (proc).
768 (send_process): Likewise.
769
34a02f46
MR
7702012-01-19 Martin Rudalics <rudalics@gmx.at>
771
772 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
773 (Vwindow_persistent_parameters): Do not use Qstate.
774 Rewrite doc-strings.
34a02f46 775
1259009a 7762012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
777
778 * character.c (char_width): New function.
70d4fdf6
GM
779 (Fchar_width, c_string_width, lisp_string_width):
780 Use char_width (Bug#9496).
25ed9e61 781
6a6ee00d
MR
7822012-01-16 Martin Rudalics <rudalics@gmx.at>
783
784 * window.c (Vwindow_persistent_parameters): New variable.
785 (Fset_window_configuration, save_window_save): Handle persistent
786 window parameters.
787
c85efaf7
EZ
7882012-01-14 Eli Zaretskii <eliz@gnu.org>
789
790 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
791 thrashing the stack of the thread. (Bug#9087)
792
5944709e
PE
7932012-01-12 Paul Eggert <eggert@cs.ucla.edu>
794
795 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
796
e71f5d99
EZ
7972012-01-11 Eli Zaretskii <eliz@gnu.org>
798
799 * xdisp.c (rows_from_pos_range): Handle the case where the
800 highlight ends on a newline. (Bug#10464)
801 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
802 he end column for display of highlight that ends on a newline
803 before a R2L line.
804
ce316182
GM
8052012-01-11 Glenn Morris <rgm@gnu.org>
806
807 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
808 from load-path also when installation-directory is nil. (Bug#10208)
809
5b43da69
GM
8102012-01-10 Glenn Morris <rgm@gnu.org>
811
74cc8ff9
GM
812 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
813
7d8d6e4e
GM
814 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
815 Update template values to be closer to their typical values these days.
5b43da69 816
a0db8d43
EZ
8172012-01-09 Eli Zaretskii <eliz@gnu.org>
818
819 * xdisp.c (rows_from_pos_range): Accept additional argument
820 DISP_STRING, and accept any glyph in a row whose object is that
821 string as eligible for mouse highlight. Fixes mouse highlight of
822 display strings from overlays. (Bug#10464)
823
9a0115ab 8242012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 825
b9110d6a 826 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
827 * fileio.c (auto_saving_dir_umask): New static var.
828 (Fmake_directory_internal): Use it.
829 (do_auto_save_make_dir): Set it, instead of invoking chmod after
830 creating the directory. The old code temporarily assigns
831 too-generous permissions to the directory.
832 (do_auto_save_eh): Clear it.
b9110d6a 833 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
834 that the var is always cleared.
835
6c1bd3f3
EZ
8362012-01-07 Eli Zaretskii <eliz@gnu.org>
837
838 * search.c (scan_buffer): Pass character positions to
839 know_region_cache, not byte positions. (Bug#6540)
840
069d2b50
L
8412012-01-07 LynX <_LynX@bk.ru> (tiny change)
842
843 * w32.c (sys_rename): Report EXDEV when rename of a directory
844 fails because the target is on another logical disk. (Bug#10284)
845
75bf0d33
DB
8462012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
847
848 * xterm.c (x_embed_request_focus): New function.
849
850 * xterm.h: Add prototype.
851
852 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
853
1c6e5a32
GM
8542012-01-05 Glenn Morris <rgm@gnu.org>
855
856 * emacs.c (emacs_copyright): Update short copyright year to 2012.
857
651e947e
EZ
8582012-01-01 Eli Zaretskii <eliz@gnu.org>
859
860 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
861 Load gnutls_transport_set_lowat only if GnuTLS version is below
862 2.11.1.
863 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
864 GnuTLS versions below 2.11.1.
865
3778cdd8
AL
8662011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
867
868 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
869 to the doc string advising against its use for altering the way
870 windows are scrolled.
871
0e5317f7
KH
8722011-12-28 Kenichi Handa <handa@m17n.org>
873
874 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
875 coding-system ASCII compatible only when it does not produce BOM
876 on encoding (Bug#10383).
877
93d5ca1f
JD
8782011-12-26 Jan Djärv <jan.h.d@swipnet.se>
879
880 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
881 can scroll.
882 (create_and_show_popup_menu): Always use menu_position_func for
883 Gtk3 (Bug#10361).
884
ca22b785
AS
8852011-12-24 Andreas Schwab <schwab@linux-m68k.org>
886
887 * callint.c (Fcall_interactively): Don't truncate prompt string.
888
d048e1e6
EZ
8892011-12-23 Eli Zaretskii <eliz@gnu.org>
890
891 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
892 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 893 resumed from there (after widening). (Bug#10360)
d048e1e6 894
5ccaba1f
JD
8952011-12-22 Jan Djärv <jan.h.d@swipnet.se>
896
897 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
898
204ee57f
JD
8992011-12-21 Jan Djärv <jan.h.d@swipnet.se>
900
b81d40f0
JB
901 * nsterm.m (x_free_frame_resources):
902 Release f->output_data.ns->miniimage.
204ee57f
JD
903 (ns_index_color): Fix indentation. Do not retain
904 color_table->colors[i].
905
906 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
907 before returning.
908
909 * nsfns.m (x_set_background_color): Assign return value from
910 ns_index_color to face-background instead of NSColor*.
911 (ns_implicitly_set_icon_type): Fix indentation.
912 Change assignment in for loop to comparison.
913
914 * emacs.c (ns_pool): New variable.
915 (main): Assign ns_pool.
916 (Fkill_emacs): Call ns_release_autorelease_pool.
917
918 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
919 autorelease fdesc, release fdAttrs and tdict.
920 (ns_get_covering_families): Release charset.
921 (ns_findfonts): Release NSFontDescriptor created with new.
922 (ns_uni_to_glyphs): Fix indentation.
923 (setString): Release attrStr before assigning new value.
924
c803b2b7
JD
9252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
926
678f4426
JD
927 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
928 and NS_IMPL_COCOA.
929 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
930 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
931
cd394be1 9322011-12-18 David Reitter <reitter@cmu.edu>
678f4426 933
5fecd5fc
JD
934 * nsterm.m (ns_term_init): Subscribe for notifications
935 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
936 to method trackingNotification in EmacsMenu.
937
938 * nsmenu.m (trackingMenu): New variable.
3771cb17 939 (trackingNotification): New method (from Aquamacs).
5fecd5fc 940 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 941 from Aquamacs (Bug#7030).
678f4426
JD
942
9432011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 944
c803b2b7
JD
945 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
946 (symbol_to_nsstring): Fix indentation.
947 (ns_symbol_to_pb): New function.
cae07000
SM
948 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
949 (Fns_rotate_cut_buffers_internal): Remove.
950 (Fns_store_selection_internal): Rename from
c803b2b7
JD
951 Fns_store_cut_buffer_internal.
952 (ns_get_foreign_selection, Fx_own_selection_internal)
953 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
954 (Fns_get_selection_internal, Fns_store_selection_internal):
955 Use ns_symbol_to_pb and check if return value is nil.
956 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
957 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
958 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
959 renamed to Sns_store_selection_internal.
960 (ns_handle_selection_request): Move code to Fx_own_selection_internal
961 and remove this function.
962 (ns_handle_selection_clear): Remove, never used.
963 (Fx_own_selection_internal): Move code from ns_handle_selection_request
964 here.
965
e1b01a3a
KB
9662011-12-17 Ken Brown <kbrown@cornell.edu>
967
968 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
969 GID is unknown (Bug#10257).
970
2adb6e85
PE
9712011-12-17 Paul Eggert <eggert@cs.ucla.edu>
972
973 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
974 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
975 which caused a build failure on GNU/Linux IA-64. This problem was
976 introduced by my 2011-10-07 patch.
977
d1d7b339
JL
9782011-12-15 Juri Linkov <juri@jurta.org>
979
980 * image.c (imagemagick_error): New function. (Bug#10112)
981 (imagemagick_load_image): Comment out `MagickSetResolution' call.
982 Use `imagemagick_error' where ImageMagick functions return
983 `MagickFalse'.
984 (Fimagemagick_types): Add `Fnreverse' to return the list in the
985 proper order.
986
100d5755
KH
9872011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
988
989 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
990 fill background (Bug#8992).
991
454592a6
MR
9922011-12-13 Martin Rudalics <rudalics@gmx.at>
993
994 * window.c (Vwindow_combination_resize)
995 (Vwindow_combination_limit): Use t instead of non-nil in
996 doc-strings.
61d4b438
MR
997 (Vrecenter_redisplay): Add first sentence of doc-string on
998 separate line.
53524d93 999 (Frecenter): Fix doc-string typo.
454592a6 1000
3633e3aa
KH
10012011-12-11 Kenichi Handa <handa@m17n.org>
1002
1003 * coding.c (Funencodable_char_position): Pay attention to the
1004 buffer text relocation (Bug#9389).
1005
7b9d523a
JD
10062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1007
1008 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1009 gtk_init (Bug#10100).
1010
b73189c6
EZ
10112011-12-10 Eli Zaretskii <eliz@gnu.org>
1012
1013 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1014 IT->string is nil. (Bug#10263)
1015
f7dfe5d6
JD
10162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1017
83faebb4
JD
1018 * nsterm.h (x_free_frame_resources): Declare.
1019
f7dfe5d6
JD
1020 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1021 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1022
1023 * nsterm.h (ns_get_defaults_value): Declare.
1024
1025 * nsterm.m (ns_default): Call ns_get_defaults_value.
1026
7cd4e72c
EZ
10272011-12-09 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1030 (Bug#10170)
1031
b34d7317
YM
10322011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1033
1034 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1035 that where the value of an _OBJC_* symbol points to is in the .bss
1036 section (Bug#10240).
1037
76470ad1
KH
10382011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1039
1040 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1041 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1042
745fff94
KH
10432011-12-08 Kenichi Handa <handa@m17n.org>
1044
1045 * ftfont.c (get_adstyle_property): Fix previous change
1046 (Bug#10233).
1047
6e44397c
JB
10482011-12-07 Juanma Barranquero <lekktu@gmail.com>
1049
1050 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1051 dirs from the default value of EMACSLOADPATH (bug#10208).
1052
7efa6272
GM
10532011-12-07 Glenn Morris <rgm@gnu.org>
1054
1055 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1056 installation and source directories as well. (Bug#10208)
1057
f6fc4d87
CY
10582011-12-06 Chong Yidong <cyd@gnu.org>
1059
1060 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1061
2bf26180
GM
10622011-12-06 Glenn Morris <rgm@gnu.org>
1063
1064 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1065 as an error, not just -1. (Bug#10217)
1066
3a6ad4f0
CY
10672011-12-05 Chong Yidong <cyd@gnu.org>
1068
1069 * keyboard.c (process_special_events): New function.
1070 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1071
75a3b399
PE
10722011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1073
1074 * coding.c (encode_designation_at_bol): Don't use uninitialized
1075 local variable (Bug#9318).
1076
c3c9e25e
KH
10772011-12-05 Kenichi Handa <handa@m17n.org>
1078
1079 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1080 return Qnil (Bug#8046, Bug#10193).
1081
5eb05ea3
KH
10822011-12-05 Kenichi Handa <handa@m17n.org>
1083
1084 * coding.c (encode_designation_at_bol): New args charbuf_end and
1085 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1086 (coding_set_source): Return how many bytes coding->source was
1087 relocated.
1088 (coding_set_destination): Return how many bytes
1089 coding->destination was relocated.
1090 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1091 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1092
10932011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1094
1095 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1096 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1097 macro (Bug#9318).
1098
10992011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1100
1101 The following changes are to fix Bug#9318.
1102
a79703f5 1103 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1104 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1105 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1106 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1107
7dbda6df
JB
11082011-12-05 Juanma Barranquero <lekktu@gmail.com>
1109
1110 * lisp.h (process_quit_flag): Fix external declaration.
1111
6d5eb5b0
SM
11122011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1113
1114 Don't macro-inline non-performance-critical code.
1115 * eval.c (process_quit_flag): New function.
1116 * lisp.h (QUIT): Use it.
1117
a0c3fad0
JD
11182011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1119
1120 * nsfns.m (get_geometry_from_preferences): New function.
1121 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1122
6c07aac2
AS
11232011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1124
1125 * emacs.c (Qkill_emacs): Define.
1126 (syms_of_emacs): Initialize it.
1127 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1128 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1129 (quit_throw_to_read_char): Add parameter `from_signal'.
1130 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1131 * lisp.h (QUIT): Call Fkill_emacs if requested.
1132
c052ead4
JD
11332011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1134
1135 * widget.c (update_wm_hints): Return if wmshell is null.
1136 (widget_update_wm_size_hints): New function.
1137
1138 * widget.h (widget_update_wm_size_hints): Declare.
1139
1140 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1141 widget_update_wm_size_hints (Bug#10104).
1142
9e49252b
EZ
11432011-12-03 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1146 before a newline, prepare the bidi iterator for consuming the
1147 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1148 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1149
02b16839
JL
11502011-12-02 Juri Linkov <juri@jurta.org>
1151
1152 * search.c (Fword_search_regexp): New Lisp function created from
1153 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1154 (Fword_search_backward, Fword_search_forward)
1155 (Fword_search_backward_lax, Fword_search_forward_lax):
1156 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1157 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1158
0068070e
SM
11592011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 * fileio.c (Finsert_file_contents): Move after-change-function call
1162 to before the "handled:" label, since all "goto handled" appear in
1163 cases where the *-change-functions have already been properly called
1164 (bug#10117).
1165
3360a3fc
AS
11662011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1167
1168 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1169 waiting for input. (Bug#10169)
1170
73d6c093
EZ
11712011-11-30 Eli Zaretskii <eliz@gnu.org>
1172
1173 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1174 verifies glyph row's hash code--we have just reallocated the
1175 glyphs, so their contents can be complete garbage. (Bug#10164)
1176
febe6bea
JB
11772011-11-30 Juanma Barranquero <lekktu@gmail.com>
1178
1179 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1180
801a4313
EZ
11812011-11-30 Eli Zaretskii <eliz@gnu.org>
1182
1183 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1184 attributes are tested _before_ calling verify_row_hash, to protect
1185 against GCC re-ordering of the tests. (Bug#10164)
1186
2b56b87e
JD
11872011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1188
1189 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1190
1191 * xterm.c (handle_one_xevent): Only set async_visible and friends
1192 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1193 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1194 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1195
dbf31225
PE
11962011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1199 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1200 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1201 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1202 All uses changed to use GCPRO1 etc.
1203 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1204 Revert to old implementation (i.e., before 2011-03-11).
1205
1305621b
YM
12062011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1207
1208 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1209 of scroll runs so as to avoid assigning disabled bogus rows and
1210 unnecessary graphics copy operations.
1211
8c9afb46
EZ
12122011-11-27 Eli Zaretskii <eliz@gnu.org>
1213
1214 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1215 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1216 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1217 (malloc, free, realloc, calloc): Redirect to e_* only when
1218 compiling Emacs.
1219
1220 * lisp.h (GCTYPEBITS): Move before first use.
1221 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1222 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1223 this macro definition.
1224
1225 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1226 _MSC_VER.
1227
54e9e3bf
JD
12282011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1229
6d5eb5b0
SM
1230 * gtkutil.c (xg_create_frame_widgets):
1231 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1232 present with Gtk+ 2.0.
1233
83aca1cb
PE
12342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * fileio.c (Finsert_file_contents): Undo previous change; see
1237 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1238
5b76caa4
PE
12392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 Rename locals to avoid shadowing.
1242 * fileio.c (Finsert_file_contents):
1243 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1244 * process.c (wait_reading_process_output):
1245 Rename inner 'proc' to 'p' to avoid shadowing.
1246 Indent for consistency with usual Emacs style.
1247
8c535114
EZ
12482011-11-25 Eli Zaretskii <eliz@gnu.org>
1249
1250 * xdisp.c (redisplay_window): If cursor row is not fully visible
1251 after recentering, and scroll-conservatively is set to a large
1252 number, scroll window by a few more lines to make the cursor fully
1253 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1254 (start_display): Don't move to the next line if the display should
1255 start at a newline that is part of a display vector or an overlay
1256 string. (Bug#10119)
8c535114 1257
fa4fdb5c
JL
12582011-11-24 Juri Linkov <juri@jurta.org>
1259
1260 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1261 after the `MagickPingImage' call. (Bug#10112)
1262
90ec88df
CY
12632011-11-23 Chong Yidong <cyd@gnu.org>
1264
1265 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1266
56e2e794
MR
12672011-11-23 Martin Rudalics <rudalics@gmx.at>
1268
1269 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1270 making another buffer current. (Bug#10114)
1271
b6e64c41
GM
12722011-11-23 Glenn Morris <rgm@gnu.org>
1273
1274 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1275
6b21de18
CY
12762011-11-23 Chong Yidong <cyd@gnu.org>
1277
1278 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1279 using it (Bug#5984).
1280
b12cd789
EZ
12812011-11-22 Eli Zaretskii <eliz@gnu.org>
1282
1283 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1284 and header-lines, as they don't have one computed for them.
1285 (Bug#10098)
1286
1287 * .gdbinit (prow): Make displayed values more self-explaining.
1288 Add row's hash code.
1289
261b6fd4
LMI
12902011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1291
1292 * process.c (wait_reading_process_output): Fix asynchrounous
1293 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1294 (wait_reading_process_output): Add comment and URL.
261b6fd4 1295
e7cfd277
JD
12962011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1297
1298 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1299
a9b9b7f5
CY
13002011-11-21 Chong Yidong <cyd@gnu.org>
1301
1302 * window.c (Fnext_window, Fprevious_window): Doc fix.
1303
b0d15b4f
SM
13042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1305
1306 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1307
fe7a3057
JB
13082011-11-20 Juanma Barranquero <lekktu@gmail.com>
1309
1310 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1311
d2999b1a
MR
13122011-11-20 Martin Rudalics <rudalics@gmx.at>
1313
1314 * window.c (Fset_window_combination_limit): Rename argument
1315 STATUS to LIMIT.
1316 (Vwindow_combination_limit): Remove "status" from doc-string.
1317
d5ff9cd0
AS
13182011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * m/ibms390.h: Remove.
1321 * m/ibms390x.h: Don't include "ibms390.h".
1322
a5bb9bd3
SM
13232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1324
1325 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1326 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1327
cd1181db
JB
13282011-11-20 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * casetab.c (Fset_case_table):
1331 * charset.c (Fcharset_after): Fix typos.
1332
615a3b8d 13332011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1334
17e845af
PE
1335 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1336 Otherwise, valgrind does not work on some platforms.
1337 Problem reported by Andreas Schwab in
6a0bf43d
PE
1338 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1339 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1340 is set, removing the need for VIRT_ADDRESS_VARIES.
1341 (PURE_P): Use a more-efficient implementation that needs just one
1342 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1343 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1344 to 4 (xorl, subq, cmpq, setbe).
1345 * alloc.c (pure): Always extern now, since that's the
1346 VIRT_ADDR_VARIES behavior.
1347 (PURE_POINTER_P): Use a single comparison, not two, for
1348 consistency with the new puresize.h.
1349 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1350 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1351 Remove VIRT_ADDR_VARIES no longer needed.
1352
f8fe6f96
EZ
13532011-11-19 Eli Zaretskii <eliz@gnu.org>
1354
1355 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1356 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1357 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1358 behave as if the cursor position were at the window margin.
1359
1360 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1361 and the cursor position is out of bounds, behave as if the cursor
1362 position were at the window margin. (Bug#10075)
1363
df05a53c
CY
13642011-11-18 Chong Yidong <cyd@gnu.org>
1365
1366 * window.c (Fwindow_combination_limit): Make first argument
1367 non-optional, since it is meaningless for live windows like the
1368 selected window.
1369
2071918e
DA
13702011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1371
1372 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1373
b50a28de
SM
13742011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1375
1376 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1377 (graft_intervals_into_buffer): Simplify.
1378
015137db
EZ
13792011-11-18 Eli Zaretskii <eliz@gnu.org>
1380
1381 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1382 hash values of the two rows.
1383 (copy_row_except_pointers): Preserve the used[] arrays and the
1384 hash values of the two rows. (Bug#10035)
68c95424 1385 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1386
1387 * xdisp.c (row_hash): New function, body extracted from
1388 compute_line_metrics.
1389 (compute_line_metrics): Call row_hash, instead of computing the
1390 hash code inline.
1391
1392 * dispnew.c (verify_row_hash): Call row_hash for computing the
1393 hash code of a row, instead of duplicating code from xdisp.c.
1394
1395 * dispextern.h (row_hash): Add prototype.
1396
a2addb04
TH
13972011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1398
1399 * frame.c (delete_frame): Don't delete the terminal when the last
1400 X frame is closed if emacs is built with GTK toolkit.
1401
df85d315
JB
14022011-11-17 Juanma Barranquero <lekktu@gmail.com>
1403
1404 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1405
a0c2d0ae
MR
14062011-11-17 Martin Rudalics <rudalics@gmx.at>
1407
1408 * window.c (Vwindow_splits): Rename to
1409 Vwindow_combination_resize. Suggested by Juri Linkov.
1410 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1411 of Vwindow_splits.
1412
58179cce
JB
14132011-11-16 Juanma Barranquero <lekktu@gmail.com>
1414
7877f373
JB
1415 * nsfns.m (Fns_font_name):
1416 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1417
b6f67890
MR
14182011-11-16 Martin Rudalics <rudalics@gmx.at>
1419
1420 * window.h (window): Rename slot "nest" to "combination_limit".
1421 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1422 (Fset_window_nest): Rename to Fset_window_combination_limit.
1423 (Vwindow_nest): Rename to Vwindow_combination_limit.
1424 (recombine_windows, make_parent_window, make_window)
1425 (Fsplit_window_internal, saved_window)
1426 (Fset_window_configuration, save_window_save): Rename all
1427 occurrences of window_nest to window_combination_limit.
1428
c7015153
JB
14292011-11-15 Juanma Barranquero <lekktu@gmail.com>
1430
1431 * image.c (imagemagick_load_image): Fix typo.
1432
322ad6ec
EZ
14332011-11-14 Eli Zaretskii <eliz@gnu.org>
1434
1435 * xdisp.c (display_line): Move the call to
1436 highlight_trailing_whitespace before the call to
1437 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1438 faces of all the glyphs to compute ROW's hash value.
1439 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1440
f067b8ec
JB
14412011-11-14 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1444 just return (bug#10044).
1445
1e5b2111
EZ
14462011-11-12 Eli Zaretskii <eliz@gnu.org>
1447
7ef3cbd5
EZ
1448 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1449 with user-defined heap size. Bump the default size of the temacs
1450 heap to 27MB, to avoid memory warning when running temacs.
1451 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1452
1e5b2111
EZ
1453 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1454 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1455 (verify_row_hash) [XASSERTS]: New function.
1456 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1457 that the hash value of glyph rows is correct.
1e5b2111 1458
89d61221
MR
14592011-11-12 Martin Rudalics <rudalics@gmx.at>
1460
1461 * window.h (window): Remove splits slot.
1462 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1463 (Fdelete_other_windows_internal, make_parent_window)
1464 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1465 (Fset_window_configuration, save_window_save): Don't deal with
1466 split status of windows.
1467 (saved_window): Remove splits slot.
1468 (Vwindow_splits): Rewrite doc-string.
1469
97f18cc8
JD
14702011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1471
1472 * xfns.c (unwind_create_frame):
1473 * nsfns.m (unwind_create_frame):
1474 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1475 Vframe_list (Bug#9999).
1476
22a648b4
DA
14772011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1478
0b381c7e 1479 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1480
659afede
KH
14812011-11-11 Kenichi Handa <handa@m17n.org>
1482
1483 * callproc.c (Fcall_process): Set the member dst_multibyte of
1484 process_coding.
1485
9ac0394b
KH
14862011-11-11 Johan Bockgård <bojohan@gnu.org>
1487
1488 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1489 avoid a crash (bug#9496).
1490
2fbdc249
CY
14912011-11-09 Chong Yidong <cyd@gnu.org>
1492
1493 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1494 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1495
ac6b1f81
PE
14962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1499
09db192c
PE
15002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 Avoid some portability problems by eschewing 'extern inline' functions.
1503 The trivial performance wins aren't worth the portability hassles; see
1504 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1505 et seq.
1506 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1507 (window_box_width, window_box_left, window_box_left_offset)
1508 (window_box_right, window_box_right_offset): Undo previous change,
1509 by removing the "extern"s.
1510 * intervals.c (adjust_intervals_for_insertion)
1511 (adjust_intervals_for_deletion): Undo previous change,
1512 making these static again.
1513 (offset_intervals, temp_set_point_both, temp_set_point)
1514 (copy_intervals_to_string): No longer inline.
1515 * xdisp.c (window_text_bottom_y, window_box_width)
1516 (window_box_height, window_box_left_offset)
1517 (window_box_right_offset, window_box_left, window_box_right)
1518 (window_box): No longer inline.
1519
105216ed
CY
15202011-11-08 Chong Yidong <cyd@gnu.org>
1521
1522 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1523 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1524 Signal an error if not a live window.
105216ed
CY
1525 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1526 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1527
ae9e237f
JB
15282011-11-07 Juanma Barranquero <lekktu@gmail.com>
1529
1530 * lisp.h (syms_of_abbrev): Remove declaration.
1531 Reported by CHENG Gao <chenggao@royau.me>.
1532
c7aa8333
EZ
15332011-11-07 Eli Zaretskii <eliz@gnu.org>
1534
1535 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1536 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1537 of temacs in GUI mode.
1538
be7f5545
MR
15392011-11-07 Martin Rudalics <rudalics@gmx.at>
1540
1541 * window.h: Declare delete_all_child_windows instead of
1542 delete_all_subwindows.
1543 * window.c (Fwindow_nest, Fset_window_nest)
1544 (Fset_window_new_total, Fset_window_new_normal)
1545 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1546 (delete_all_subwindows): Rename to delete_all_child_windows.
1547 (Fdelete_other_windows_internal, Fset_window_configuration):
1548 Call delete_all_child_windows instead of delete_all_subwindows.
1549 * frame.c (delete_frame): Call delete_all_child_windows instead
1550 of delete_all_subwindows.
1551
ca78dc43
PE
15522011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1555 This is also needed for porting to any host where GC_MARK_STACK is
1556 not GC_MAKE_GCPROS_NOOPS.
1557 (which_symbols): Use it.
1558
a0241d01
KH
15592011-11-07 Kenichi Handa <handa@m17n.org>
1560
1561 * coding.c (coding_set_destination): Check coding->src_pos only
1562 when coding->src_object is a buffer (bug#9910).
1563
1564 * process.c (send_process): Set the member src_multibyte of coding
1565 to 0 (bug#9911) when sending a unibyte text.
1566
1567 * callproc.c (Fcall_process): Set the member src_multibyte of
1568 process_coding to 0 (bug#9912).
1569
a64bfdfa 15702011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1571
1572 * xmenu.c (cleanup_widget_value_tree): New function.
1573 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1574 calling free_menubar_widget_value_tree directly (Bug#9830).
1575
cb41b32a
PE
15762011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 Fix some portability problems with 'inline'.
1579 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1580 (window_box_width, window_box_left, window_box_left_offset)
1581 (window_box_right, window_box_right_offset): Declare extern.
1582 Otherwise, these inline functions do not conform to C99 and
1583 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1584 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1585 * intervals.c (adjust_intervals_for_insertion)
1586 (adjust_intervals_for_deletion): Now extern, because otherwise the
1587 extern inline functions 'offset_intervals' couldn't refer to it.
1588 (static_offset_intervals): Remove.
1589 (offset_intervals): Rewrite using the old contents of
1590 static_offset_intervals. The old version didn't conform to C99
1591 because an extern inline function contained a reference to an
1592 identifier with static linkage.
1593
b7041366
AS
15942011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1595
1596 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1597 GC.
1598
88a37c4d
EZ
15992011-11-06 Eli Zaretskii <eliz@gnu.org>
1600
1601 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1602 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1603 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1604 return Qleft_to_right.
1605
49745b39
CY
16062011-11-06 Chong Yidong <cyd@gnu.org>
1607
1608 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1609 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1610 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1611 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1612 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1613 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1614 (Fwindow_vscroll): Doc fix.
1615 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1616 argument, since it makes no sense to pass a live window and for
1617 consistency with window-child.
1618
1f05cd82
CS
16192011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1620
1621 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1622 support MSVC.
1623
22610910
JR
16242011-11-05 Jason Rumney <jasonr@gnu.org>
1625
1626 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1627 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1628 fonts (Bug#6029).
1629 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1630 bitwise arithmetic preventing use of unicode-sip and non-truetype
1631 opentype fonts.
1632
a06776b2
EZ
16332011-11-05 Eli Zaretskii <eliz@gnu.org>
1634
3ad924ba
EZ
1635 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1636 "emacs"-only part.
1637
a06776b2
EZ
1638 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1639 initialization code to keep similarity to xfns.c after changes
1640 from 2011-11-05.
1641
c9e7db78
JD
16422011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1643
a97f8f3f
JD
1644 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1645 (unwind_create_frame): New function (Bug#9943).
1646 (Fx_create_frame): Restructure code to be more similar to the one in
1647 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1648 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1649 Move terminal->reference_count++ just before making the frame official
1650 (Bug#9943).
1651
1652 * nsterm.m (x_free_frame_resources): New function.
1653 (x_destroy_window): Move code to x_free_frame_resources.
1654
c9e7db78 1655 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1656 (Fx_create_frame, x_create_tip_frame):
1657 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1658 official. Move initialization of image_cache_refcount and
1659 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1660
a6fc3b5c
EZ
16612011-11-05 Eli Zaretskii <eliz@gnu.org>
1662
1663 Support MSVC build with newer versions of Visual Studio.
1664 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1665 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1666 nt/gmake.defs.
1667
1668 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1669 which are not supported by MSVC.
1670 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1671 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1672 bitfields.
1673 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1674 types in bitfields.
1675 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1676
1677 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1678
58179cce 16792011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1680
1681 Support MSVC build with newer versions of Visual Studio.
1682 * w32.c: Don't include w32api.h for MSVC.
1683 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1684
1685 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1686 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1687 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1688 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1689 e_* cousins.
1690 (alloca) [_MSC_VER]: Define to _alloca.
1691
1692 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1693
1694 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1695
a58c13ed
EZ
16962011-11-04 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (note_mouse_highlight): If either of
1699 previous/next-single-property-change returns nil, treat that as
1700 the beginning or the end of the buffer. (Bug#9955)
1701
fe0b6370
JD
17022011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1703
a58c13ed 1704 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1705 label is not null (Bug#9951).
1706 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1707 may be NULL.
1708
89bd5ee1
EZ
17092011-11-04 Eli Zaretskii <eliz@gnu.org>
1710
1711 * window.c (Fwindow_body_size): Mention in the doc string that the
1712 return value is in frame's canonical units. (Bug#9949)
1713
84c3edb9
EZ
17142011-11-03 Eli Zaretskii <eliz@gnu.org>
1715
4e2fb5c7
EZ
1716 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1717
84c3edb9 1718 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1719 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1720 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1721
bc17a887
EZ
17222011-11-01 Eli Zaretskii <eliz@gnu.org>
1723
1724 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1725 Don't stop backward scan on the continuation glyph, even though
1726 its CHARPOS is positive.
6d5eb5b0
SM
1727 (mouse_face_from_buffer_pos, note_mouse_highlight):
1728 Rename cover_string to disp_string.
bc17a887 1729
4ee88440
MR
17302011-11-01 Martin Rudalics <rudalics@gmx.at>
1731
1732 * window.c (temp_output_buffer_show): Don't use
1733 Vtemp_buffer_show_specifiers.
1734 (Vtemp_buffer_show_specifiers): Remove unused variable.
1735
c2ff3c02
EZ
17362011-10-30 Eli Zaretskii <eliz@gnu.org>
1737
1738 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1739 past the beginning of the current glyph matrix.
1740
58179cce 17412011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1742
1743 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1744 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1745 HAVE_GTK3 (Bug#9869).
b77a6a7f 1746
3b574623
JD
1747 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1748 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1749
b77a6a7f
JD
1750 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1751
1752 * xterm.c: Declare x_handle_net_wm_state to return int.
1753 (handle_one_xevent): Check if we are iconified but don't have
1754 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1755 (get_current_wm_state): Return non-zero if not hidden,
1756 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1757 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1758 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1759 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1760
196e41e4
PE
17612011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1764 so that this new function doesn't get optimized away by a
1765 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1766
021f2e1a
AS
17672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1768
1769 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1770
8b058d44
EZ
17712011-10-29 Eli Zaretskii <eliz@gnu.org>
1772
1773 Fix the `xbytecode' command.
1774 * .gdbinit (xprintbytestr): New command.
b50a28de 1775 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1776 (xbytecode): Print the byte-code string as well.
1777
4452fb80
EZ
17782011-10-29 Kim Storm <storm@cua.dk>
1779
8b058d44
EZ
1780 * alloc.c (which_symbols): New function.
1781
21b72067
AS
17822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1783
1784 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1785 line. (Bug#9903)
1786
83ed7b5c
GM
17872011-10-29 Glenn Morris <rgm@gnu.org>
1788
1789 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1790 Not clear what it was for, and it causes various bugs. (Bug#9839)
1791
5a7a728b
EZ
17922011-10-28 Eli Zaretskii <eliz@gnu.org>
1793
1794 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1795 possible random value that matches one of those tested as
1796 condition to clear the mouse face.
1797
d3d0842f
CY
17982011-10-28 Chong Yidong <cyd@gnu.org>
1799
1800 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1801
31b39d13
DN
18022011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1803
1804 * window.c (make_window): Initialize phys_cursor_on_p.
1805
9aba6043
SM
18062011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1807
1808 * lisp.h (struct Lisp_Symbol): Update comments.
1809
c20992f4
JB
18102011-10-28 Juanma Barranquero <lekktu@gmail.com>
1811
1812 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1813
db4f02f2
EZ
18142011-10-28 Eli Zaretskii <eliz@gnu.org>
1815
1816 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1817 <oslsachem@gmail.com> for helping to debug this.
1818
1819 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1820 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1821 (g_b_init_get_glyph_outline_w): New static variables.
1822 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1823 (GetGlyphOutlineW_Proc): New typedefs.
1824 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1825 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1826 New functions.
1827 (w32font_open_internal, compute_metrics):
1828 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1829 instead of calling the "wide" APIs directly.
1830
1831 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1832
1833 * w32.h (syms_of_w32font): Add prototype.
1834
87e68db4
JB
18352011-10-27 Juanma Barranquero <lekktu@gmail.com>
1836
1837 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1838 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1839 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1840 (Fmove_to_window_line): Doc fix.
1841
435c1d67
CY
18422011-10-27 Chong Yidong <cyd@gnu.org>
1843
1844 * process.c (make_process): Set gnutls_state to NULL.
1845
1846 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1847 non-NULL, regardless of GNUTLS_INITSTAGE.
1848 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1849 an error. Set process slots as soon as we allocate them.
1850
1851 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1852
9c6c6f49
CY
18532011-10-27 Chong Yidong <cyd@gnu.org>
1854
9aba6043
SM
1855 * gnutls.c (emacs_gnutls_deinit): New function.
1856 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1857 (Fgnutls_deinit, Fgnutls_boot): Use it.
1858
1859 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1860 (deactivate_process): Call emacs_gnutls_deinit.
1861
657d08d3
JB
18622011-10-27 Juanma Barranquero <lekktu@gmail.com>
1863
1864 * image.c (x_create_x_image_and_pixmap):
1865 * w32.c (sys_rename, w32_delayed_load):
1866 * w32font.c (fill_in_logfont):
1867 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1868
5430d399
JB
18692011-10-26 Juanma Barranquero <lekktu@gmail.com>
1870
1871 * w32fns.c (w32_default_color_map): New function,
1872 extracted from Fw32_default_color_map.
a7ef684b 1873 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1874
fe0055fa
PE
18752011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1878
e6346438
SM
18792011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1880
1881 * keyboard.c (test_undefined): New function (bug#9751).
1882 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1883
e112cc37
ET
18842011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1885
1886 * sysdep.c (init_sys_modes): Fix the check for the controlling
1887 terminal (Bug#6649).
1888
7b5d6677
EZ
18892011-10-20 Eli Zaretskii <eliz@gnu.org>
1890
1891 * dispextern.h (struct bidi_it): New member next_en_type.
1892
1893 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1894 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1895 current character, check also for next_en_type being WEAK_EN.
1896 (bidi_resolve_weak): Don't enter the expensive loop if the current
1897 position is before next_en_pos. Record the bidi type of the first
1898 non-ET, non-BN character we find, in addition to its position.
1899 (bidi_level_of_next_char): Invalidate next_en_type when
1900 next_en_pos is over-stepped.
1901
7da0b018
PE
19022011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1905 * editfns.c: Rewrite current-time-zone so that it invokes
1906 the equivalent of (format-time-string "%Z") to get the time zone name.
1907 This fixes a bug when the time zone name contains characters that
1908 need converting from the system time locale to Emacs internal format.
1909 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1910 that patch fixed format-time-string to do the conversion, but
1911 I forgot to fix current-time-zone.
1912 (format_time_string): New function, containing most of
1913 what Fformat_time_string used to contain.
1914 (Fformat_time_string): Rewrite in terms of format_time_string.
1915 This doesn't change this function's behavior.
1916 (current-time-zone): Rewrite to use format_time_string.
1917 This fixes the bug reported by Michael Schierl in
1918 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1919 Jason Rumney's 2007-06-07 change worked around this bug, but
1920 didn't fix it.
1921 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1922
8547b010
EZ
19232011-10-19 Eli Zaretskii <eliz@gnu.org>
1924
1925 * xdisp.c (start_display): If the character at POS is displayed
1926 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1927 (try_window_reusing_current_matrix): If a line ends in a display
1928 vector or the next line starts in a display vector, continue
1929 redrawing the window even though the character position of
1930 start_row was reached.
8547b010
EZ
1931 (Bug#9771, part 2)
1932
4e948d15
CY
19332011-10-18 Chong Yidong <cyd@gnu.org>
1934
1935 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1936 with nobreak-char-display too.
1937
4787455f
EZ
19382011-10-18 Eli Zaretskii <eliz@gnu.org>
1939
1940 Fix part 3 of bug#9771.
1941 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1942 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1943 non-neutral characters if the current character is a paragraph
1944 separator (a.k.a. Newline). This avoids running the same
1945 expensive loop twice, once when we consume the preceding newline
1946 and the other time when the line actually needs to be displayed.
1947 Avoid the loop when we see neutrals on the base embedding level
1948 following a character whose directionality is the same as the
1949 paragraph's. This avoids running the expensive loop when a line
1950 ends in a long sequence of neutrals, like control characters.
1951 Add assertion against STRONG_AL type. Slightly rearrange code
1952 that determines the type of a neutral given the first non-neutral
1953 that follows it.
1954 (bidi_level_of_next_char): Set next_en_pos to zero when
1955 invalidating its info.
1956
2c91f553
EZ
19572011-10-17 Eli Zaretskii <eliz@gnu.org>
1958
1959 * xdisp.c (push_display_prop): Determine whether to record string
1960 or buffer position by IT->string, not by IT->method. Allow
1961 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1962 (move_it_vertically_backward): Don't look for character position
1963 immediately after the newline when in a continuation line.
1964 (Bug#9771, part 1)
2c91f553 1965
c7b08b0d
MR
19662011-10-15 Martin Rudalics <rudalics@gmx.at>
1967
1968 * window.c (coordinates_in_window): Rewrite and delabelize
1969 vertical border check. (Bug#5357) (Bug#9618)
1970
6b02f655
SM
19712011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1972
1973 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1974 errors in XSetWindowBorder (bug#9310).
1975
81d40c92
DA
19762011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1977
1978 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1979 avoid crash when xmalloc overrun checking is enabled.
1980
d4172c3b
EZ
19812011-10-13 Eli Zaretskii <eliz@gnu.org>
1982
1983 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1984 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1985 cursor motion with <left> and <right> arrow keys.
1986
1987 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1988 some callers set that themselves.
1989
b00eea75
EZ
19902011-10-12 Eli Zaretskii <eliz@gnu.org>
1991
1992 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1993 display string and the previous row comes from the same string and
1994 is empty. (Bug#9739) (Bug#9738)
1995
8fe012c4
SM
19962011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1997
1998 * doc.c (get_doc_string): Encode file name (bug#9735).
1999
0074aef2
EZ
20002011-10-12 Eli Zaretskii <eliz@gnu.org>
2001
79beb178
EZ
2002 * bidi.c (bidi_level_of_next_char):
2003 * xdisp.c (get_visually_first_element): Remove old incorrect
2004 comments regarding the Unicode Line Separator character.
2005
0074aef2
EZ
2006 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2007
6e4b3fbe
DA
20082011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 * alloc.c (Fgc_status): Do not access beyond zombies array
2011 boundary if nzombies > MAX_ZOMBIES.
2012 * alloc.c (dump_zombies): Add missing format specifier.
2013
0324f3af
PE
20142011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2015
b5525cac
PE
2016 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2017 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2018
0324f3af
PE
2019 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2020 Some packages use them to denote characters with modifiers.
2021
e9b5f888
AS
20222011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2023
2024 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2025 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2026 matching a pp-number. Rename parameter var to var1.
2027
127827c0
SM
20282011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2029
2030 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2031
c8fd3bd0
GM
20322011-10-08 Glenn Morris <rgm@gnu.org>
2033
2034 * callint.c (Fcall_interactively): Give a more explicit error for the
2035 'c' case with a non-character input. (Bug#8479)
2036
352ec8ff
EZ
20372011-10-08 Eli Zaretskii <eliz@gnu.org>
2038
03669ccb
EZ
2039 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2040 lines.
7061c986
EZ
2041 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2042 lines that are hscrolled on the left.
03669ccb 2043
352ec8ff
EZ
2044 * dispnew.c (buffer_posn_from_coords): Account for a possible
2045 presence of header-line. (Bug#4426)
2046
a66cfb1c
SM
20472011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2048
6b02f655
SM
2049 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2050 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2051
7c5ee88e
PE
20522011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2055 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2056 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2057 this makes Emacs dump core during garbage collection on rare
2058 occasions. sizeof is obviously inferior to offsetof here, so
2059 stick with offsetof.
2060 (GC_POINTER_ALIGNMENT): New macro.
2061 (mark_memory): Omit 3rd (offset) arg; caller changed.
2062 Don't assume EMACS_INT alignment is the same as pointer alignment.
2063
df1bbe5b
SM
20642011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2065
2066 * keyboard.c (read_key_sequence_remapped): New var.
2067 (read_key_sequence): Compute remapping in the right buffer.
2068 (command_loop_1): Use read_key_sequence's remapping directly.
2069
51553db6
SM
20702011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2071
32c1fffd
SM
2072 * dired.c (file_name_completion): Don't expand file name.
2073 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2074 before checking file name handler.
2075
51553db6
SM
2076 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2077 they've been requested explicitly (bug#9591).
2078
b6bd1599 20792011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2080
2081 * keymap.c (Fsingle_key_description): Use make_specified_string
2082 instead of build_string to build string from push_key_description.
2083 (Bug#5193)
2084
f701dc2a
PE
20852011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2086
4222c55d
PE
2087 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2088 This fixes a Y2038 bug on 64-bit hosts.
2089 * buffer.c (reset_buffer):
2090 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2091 (Fclear_buffer_auto_save_failure):
2092 Use 0, not -1, to represent an unset failure time, since time_t
2093 might not be signed.
2094
f701dc2a
PE
2095 Remove dependency on glibc malloc internals.
2096 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2097 Move back here from lisp.h, but with their new implementations.
2098 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2099 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2100 * charset.c (charset_table_init): New static var.
2101 (syms_of_charset): Use it instead of xmalloc. This removes a
2102 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2103 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2104 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2105 Move back to alloc.c.
2106 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2107 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2108
9ceebf39
JD
21092011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2110
2111 * nsterm.m (windowDidResize): Call x_set_window_size only when
2112 ns_in_resize is true. Otherwise set pixelwidth/height and
2113 call change_frame_size (Bug#9628).
2114
cb993c58
PE
21152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2116
3930c88b
PE
2117 Port --enable-checking=all to Fedora 14 x86-64.
2118 * charset.c (syms_of_charset): Also account for glibc malloc's
2119 internal overhead when calculating the initial malloc maximum.
2120
cb993c58
PE
2121 Port --enable-checking=all to Fedora 14 x86.
2122 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2123 Move to lisp.h.
2124 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2125 (overrun_check_realloc, overrun_check_free):
2126 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2127 That way, xmalloc returns a properly-aligned pointer even if
2128 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2129 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2130 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2131 into account when calculating the initial malloc maximum.
2132 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2133 Move here from alloc.c, so that charset.c can use it too.
2134 Properly align; the old code wasn't right for common 32-bit hosts
2135 when configured with --enable-checking=all.
2136 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2137 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2138
31bed486
EZ
21392011-09-29 Eli Zaretskii <eliz@gnu.org>
2140
04c70788 2141 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2142 use EDOM.
2143
fbcaa2f3
EZ
21442011-09-28 Eli Zaretskii <eliz@gnu.org>
2145
2146 * xdisp.c (compute_display_string_end): If there's no display
2147 string at CHARPOS, return -1.
2148
2149 * bidi.c (bidi_fetch_char): When compute_display_string_end
2150 returns a negative value, treat the character as a normal
2151 character not covered by a display string. (Bug#9624)
2152
a239d4e9
JB
21532011-09-28 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * lread.c (Fread_from_string): Fix typo in docstring.
2156
88652fd5
EZ
21572011-09-27 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2160 newline, reseat the iterator instead of bidi-iterating there one
2161 character at a time. (Bug#9610)
32c1fffd
SM
2162 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2163 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2164
ed497dd4
AS
21652011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2166
2167 * lread.c (readevalloop): Use correct code for NBSP.
2168 (read1): Likewise. (Bug#9608)
2169
b2bf61aa
MA
21702011-09-25 Michael Albinus <michael.albinus@gmx.de>
2171
2172 * dbusbind.c (Fdbus_register_signal): When service is not
2173 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2174
32bbb17c
GM
21752011-09-25 Glenn Morris <rgm@gnu.org>
2176
2177 * buffer.c (truncate-lines): Doc fix.
2178
94e0933e
CY
21792011-09-24 Chong Yidong <cyd@stupidchicken.com>
2180
2181 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2182 (Fset_window_next_buffers): Doc fix.
2183
cddde921
GM
21842011-09-24 Glenn Morris <rgm@gnu.org>
2185
2186 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2187
1260aef1
PE
21882011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2189
25b4bfa0
PE
2190 Fix minor problems found by static checking.
2191 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2192 * indent.c (Fvertical_motion): Fix == vs = typo.
2193
e3cbd34b
EZ
21942011-09-24 Eli Zaretskii <eliz@gnu.org>
2195
a66cfb1c
SM
2196 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2197 Default value is now t. Doc fix.
6bf7006f 2198
e3cbd34b 2199 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2200 logic when moving up, not only when moving down. Fix the
e3cbd34b 2201 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2202 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2203
2204 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2205 CHARPOS is covered by a display string which includes newlines.
2206 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2207 is covered by a display string with embedded newlines.
2208
a3de0cbd
MA
22092011-09-24 Michael Albinus <michael.albinus@gmx.de>
2210
2211 * dbusbind.c (Fdbus_register_signal): Add match rule to
2212 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2213 (Fdbus_register_method, Vdbus_registered_objects_table):
2214 Fix docstring.
a3de0cbd 2215
b260039d
JM
22162011-09-24 Jim Meyering <meyering@redhat.com>
2217
32c1fffd 2218 do not ignore write error for any output size
b260039d
JM
2219 The previous change was incomplete.
2220 While it makes emacs --batch detect the vast majority of stdout
2221 write failures, errors were still ignored whenever the output size is
2222 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2223 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2224 && echo FAIL: ignored write error
2225 FAIL: ignored write error
2226 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2227 && echo FAIL: ignored write error
2228 FAIL: ignored write error
2229 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2230
8eca8a7c
AS
22312011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2232
2233 * emacs.c (Fkill_emacs): In noninteractive mode exit
2234 non-successfully if a write error occurred on stdout. (Bug#9574)
2235
3341db62
EZ
22362011-09-21 Eli Zaretskii <eliz@gnu.org>
2237
2238 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2239 the xassert test.
2240
2241 * dispextern.h (struct it): Update the comment documenting what
2242 can it->OBJECT be.
2243
8c203dbf
EZ
22442011-09-20 Eli Zaretskii <eliz@gnu.org>
2245
2246 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2247 a display string, extend search for cursor position to end of row.
2248 (find_row_edges): If the row ends in a newline from a display
2249 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2250 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2251 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2252 non-empty line. Fixes confusing cursor motion with arrow keys at
2253 the beginning of a line that starts with whitespace.
8c203dbf 2254
a4824228
LMI
22552011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2256
2257 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2258 (bug#9493).
2259
33ed493b
CY
22602011-09-18 Chong Yidong <cyd@stupidchicken.com>
2261
2262 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2263 boolean (Bug#9154).
2264
56cd55c8
EZ
22652011-09-18 Eli Zaretskii <eliz@gnu.org>
2266
2267 * xdisp.c (display_line): Record maximum and minimum buffer
2268 positions even if no glyphs were produced (e.g., by a zero-width
2269 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2270 buffer positions that will be removed from the glyph row because
2271 they don't fit.
c02dcedf
EZ
2272 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2273 column is beyond frame width: don't subtract 1 "pixel" when
2274 computing width of the stretch.
3e62b7e0
EZ
2275 (reseat_at_next_visible_line_start): Undo the change made on
2276 2011-09-17 that saved paragraph information and restored it after
2277 the call to `reseat'. (Bug#9545)
56cd55c8 2278
5ed99d36 22792011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2280
2281 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2282 and turn window cursor on if cleared (Bug#9415).
2283
5ed99d36 22842011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2285
2286 * search.c (boyer_moore): Take unibyte characters from pattern
2287 literally. (Bug#9458)
2288
9bade7b2
EZ
22892011-09-18 Eli Zaretskii <eliz@gnu.org>
2290
2291 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2292
e5e9d610
PE
22932011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2294
87e4427a
PE
2295 Fix minor problem found by static checking.
2296 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2297 initialized, to pacify gcc -Wuninitialized.
2298
e5e9d610
PE
2299 * fileio.c: Report proper errno when syscall falls.
2300 (Finsert_file_contents): Save and restore errno,
2301 so that report_file_error outputs the correct diagnostic.
2302 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2303
a1674f0b
EZ
23042011-09-18 Eli Zaretskii <eliz@gnu.org>
2305
2306 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2307
fbfb6dd4
EZ
23082011-09-17 Eli Zaretskii <eliz@gnu.org>
2309
2310 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2311 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2312
bb187662
EZ
23132011-09-17 Eli Zaretskii <eliz@gnu.org>
2314
1137e8b8 2315 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2316 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2317
2318 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2319 (bidi_find_paragraph_start): Search back for paragraph beginning
2320 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2321 (bidi_move_to_visually_next): Only trigger paragraph-related
2322 computations when the last character is a newline or at EOB, not
2323 just any NEUTRAL_B. (Bug#9470)
2324
bb187662
EZ
2325 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2326 truncated lines if point is covered by a display string. (Bug#9524)
2327
2e621251
PE
23282011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2329
2330 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2331 (cons_to_x_long): New function.
2332 (lisp_data_to_selection_data): Use it. Correct the test for
2333 short-versus-long data; it was negated. Break out of vector
2334 loop, for efficiency, when a long datum is discovered.
2335
91a15bc6
SM
23362011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2337
2338 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2339
b41c3a35
EZ
23402011-09-16 Eli Zaretskii <eliz@gnu.org>
2341
2342 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2343 GCC PR/17406) by declaring this function with external scope.
2344
7812ba2d
PE
23452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2346
2347 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2348 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2349
cf7edc2a
AS
23502011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2351
2352 * editfns.c (Fformat): Correctly handle text properties on "%%".
2353
bd01620e
EZ
23542011-09-15 Eli Zaretskii <eliz@gnu.org>
2355
2356 * xterm.c (x_draw_composite_glyph_string_foreground):
2357 * w32term.c (x_draw_composite_glyph_string_foreground):
2358 * term.c (encode_terminal_code):
2359 * composite.c (composition_update_it, get_composition_id):
2360 * xdisp.c (get_next_display_element)
2361 (fill_composite_glyph_string): Add comments about special meaning
2362 of TAB characters in a composition.
2363
a02719a3
PE
23642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2367 This occurs when processing a multibyte format.
2368 Problem reported by Wolfgang Jenker.
a02719a3 2369
72589a3c
JB
23702011-09-15 Johan Bockgård <bojohan@gnu.org>
2371
2372 * xdisp.c (try_cursor_movement): Only check for exact match if
2373 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2374
1c14176c
PE
23752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 Remove unused external symbols.
2378 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2379 * xdisp.c (calc_pixel_width_or_height): Now static.
2380 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2381 * indent.c (check_display_width):
2382 * w32term.c: Fix comment to match code.
2383 * xterm.c, xterm.h (x_catching_errors): Remove.
2384
d2eea5b5
PE
23852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2386
2387 * xselect.c: Use signed conversions more consistently (Bug#9498).
2388 (selection_data_to_lisp_data): Assume incoming selection data are
2389 signed integers, not unsigned. This is to be consistent with
2390 outgoing selection data, which was modified to use signed integers
2391 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2392 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2393 expects long, not unsigned long.
2394
46888499
EZ
23952011-09-14 Eli Zaretskii <eliz@gnu.org>
2396
2397 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2398 computation of loop end. Reported by Johan Bockgård
2399 <bojohan@gnu.org>.
2400
ef8ef9fb
CY
24012011-09-13 Chong Yidong <cyd@stupidchicken.com>
2402
2403 * frame.c (Fother_visible_frames_p): Function deleted.
2404
fa819fed
EZ
24052011-09-12 Eli Zaretskii <eliz@gnu.org>
2406
2407 * indent.c (compute_motion): Process display vector front to back
2408 rather than the other way around. (Bug#2496)
2409
2ba8e008
SM
24102011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2411
2412 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2413
20f53c69
CY
24142011-09-11 Chong Yidong <cyd@stupidchicken.com>
2415
2416 * minibuf.c (Fread_from_minibuffer): Doc fix.
2417
d562d7a4
EZ
24182011-09-11 Eli Zaretskii <eliz@gnu.org>
2419
2420 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2421 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2422
1c4d7f3d
LMI
24232011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2424
2425 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2426 value for non-existent files.
2427
b885bf36
EZ
24282011-09-11 Eli Zaretskii <eliz@gnu.org>
2429
2430 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2431 set its "size" to -1. This will set the modtime_size field of
2432 the corresponding buffer to -1, which is what
2433 verify-visited-file-modtime expects for files that do not exist.
2434 (Bug#9139)
2435
6612f0bf
PE
24362011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2439 here ...
2440 * lisp.h: ... from here. push_key_description is no longer
2441 defined in keyboard.c, so its declaration should not be in
2442 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2443 logically belongs with push_key_description.
2444
dfb3f755
PE
24452011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 * buffer.h: Include <sys/types.h> instead of <time.h>.
2448 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2449 Problem reported by Herbert J. Skuhra.
2450
3134906c
LMI
24512011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2452
2453 * xml.c (parse_region): Make the parsing work for
2454 non-comment-starting XML files again (bug#9144).
2455
8d903f4e
AS
24562011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2457
2458 * image.c (gif_load): Fix calculation of bottom and right corner.
2459 (Bug#9468)
2460
80ad64f4
EZ
24612011-09-10 Eli Zaretskii <eliz@gnu.org>
2462
2463 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2464 redisplay in small windows.
2465
208a048d
EZ
24662011-09-09 Eli Zaretskii <eliz@gnu.org>
2467
2468 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2469
9b1c252e
MR
24702011-09-08 Martin Rudalics <rudalics@gmx.at>
2471
2472 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2473 Operate on live windows only.
2474
2949f33b
JB
24752011-09-08 Juanma Barranquero <lekktu@gmail.com>
2476
2477 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2478
e08dcafd
EZ
24792011-09-07 Eli Zaretskii <eliz@gnu.org>
2480
2481 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2482 only under bidi iteration.
2483
115b96bd
JD
24842011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2485
2486 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2487
c8199d0f
PE
24882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2491 Without this fix, the command to link temacs failed due to an
2492 undefined symbol __builtin_isnan. This is because
2493 /usr/include/iso/math_c99.h #defines isnan(x) to
2494 __builtin_isnan(x), but the bundled gcc, which identifies itself
2495 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2496 a __builtin_isnan.
2497 * floatfns.c (isnan): #undef, and then #define to a clone of
2498 what's in data.c.
2499 (Fisnan): Always define, since it's always available now.
2500 (syms_of_floatfns): Always define isnan at the Lisp level.
2501
e39b275c 25022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2503
2504 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2505
b2db44d9 25062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2507
f4af5137 2508 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2509 The previous code assumed that file offsets (off_t values) fit in
2510 EMACS_INT variables, which is not true on typical 32-bit hosts.
2511 The code messed up by falsely reporting buffer overflow in cases
2512 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2513 when "big" contains more than 2**29 bytes, even though this
2514 inserts just one byte and does not overflow the buffer.
2515 (Finsert_file_contents): Store file offsets as off_t
2516 values, not as EMACS_INT values. Check for overflow when
2517 converting between EMACS_INT and off_t. When checking for
2518 buffer overflow or for overlap, take the offsets into account.
2519 Don't use EMACS_INT for small values where int suffices.
2520 When checking for overlap, fix a typo: ZV was used where
2521 ZV_BYTE was intended.
2522 (Fwrite_region): Don't assume off_t fits into 'long'.
2523 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2524
ecfc0a49
MA
25252011-09-05 Michael Albinus <michael.albinus@gmx.de>
2526
2527 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2528
6511acf2 25292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2530
0999621a 2531 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2532
2533 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2534 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2535 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2536 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2537 (modify_event_symbol): Do not assume that the length of
2538 name_alist_or_stem is safe to alloca and fits in int.
2539 (Fexecute_extended_command): Likewise for function name and binding.
2540 (Frecursion_depth): Wrap around reliably on integer overflow.
2541 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2542 since some callers pass EMACS_INT values.
2543 (Fsingle_key_description): Don't crash if symbol name contains more
2544 than MAX_ALLOCA bytes.
2545 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2546 (get_minibuffer): Arg is now EMACS_INT, not int.
2547 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2548 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2549 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2550
2be7d702
PE
2551 * dbusbind.c (signature_cat): New function.
2552 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2553 Do not overrun buffer; instead, report string overflow.
2554
9d1df220
PE
2555 * dispnew.c (add_window_display_history): Don't overrun buffer.
2556 Truncate instead; this is OK since it's just a log.
2557
33ef5c64
PE
2558 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2559 even if the time zone offset is outlandishly large.
2560 Don't mishandle offset == INT_MIN.
2561
66c6fdd5
PE
2562 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2563 when creating daemon; the previous buffer-overflow check was incorrect.
2564
d749b01b
PE
2565 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2566 which has the guts of the old verror function.
2567
b5cd1905
PE
2568 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2569 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2570
6e1a67fb
PE
2571 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2572 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2573 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2574 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2575 length of string rather than counting it via multiple sprintfs;
2576 that's simpler and more reliable.
c21721cc
PE
2577 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2578 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2579 sprintf, in case result does not fit in int.
2580
c57b67fc
PE
2581 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2582 (fontset_from_font): Print it.
2583
8a401434
PE
2584 * frame.c (tty_frame_count): Now printmax_t, not int.
2585 (make_terminal_frame, set_term_frame_name): Print it.
2586 (x_report_frame_params): In X, window IDs are unsigned long,
2587 not signed long, so print them as unsigned.
2588 (validate_x_resource_name): Check for implausibly long names,
2589 and don't assume name length fits in 'int'.
2590 (x_get_resource_string): Don't blindly alloca invocation name;
2591 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2592 not fit in int.
2593
6e1a67fb
PE
2594 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2595 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2596 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2597
0df02bf3
PE
2598 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2599 Use esprintf, not sprintf, in case result does not fit in int.
2600
48e30793
PE
2601 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2602 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2603 it as a large positive number.
2604 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2605 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2606
a66ff6d8
PE
2607 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2608 in case result does not fit in int.
2609
aca216ff
PE
2610 * print.c (float_to_string): Detect width overflow more reliably.
2611 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2612 buffer overrun. Don't assume list length fits in 'int'. Treat
2613 print length of 0 as 0, not as infinity; to be consistent with other
2614 uses of print length in this function. Don't overflow print length
2615 index. Don't assume hash table size fits in 'long', or that
2616 vectorlike size fits in 'unsigned long'.
2617
31c286f7
PE
2618 * process.c (make_process): Use printmax_t, not int, to format
2619 process-name gensyms.
2620
55e5faa1
PE
2621 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2622
80f2e268
PE
2623 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2624 to avoid potential buffer overrun.
2625
670741ab
PE
2626 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2627 if X resource line is longer than 512 bytes.
2628
b7163a50
PE
2629 * xfns.c (x_window): Make sprintf buffer a bit bigger
2630 to avoid potential buffer overrun.
2631
ae58ff1f
PE
2632 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2633
c43c8a6a
PE
2634 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2635
3f8236f4
PE
26362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2637
53e9fe90 2638 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2639 Without these, Emacs silently mishandles large integers sometimes.
2640 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2641 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2642
6511acf2
PE
2643 * xdisp.c (try_window_id): Check Emacs fixnum range before
2644 converting to 'int'.
806add1d 2645
6511acf2 2646 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2647 Check that an Emacs fixnum is in range before assigning it to 'int'.
2648 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2649 values converted from Emacs fixnums.
2650 (Frecenter): Don't wrap around a line count if it is out of 'int'
2651 range; instead, treat it as an extreme value.
2652 (Fset_window_configuration, compare_window_configurations):
2653 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2654
6511acf2
PE
2655 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2656 that can exceed INT_MAX. Check that EMACS_INT value is in range
2657 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2658 (match_limit): Don't assume that a fixnum can fit in 'int'.
2659
6511acf2 2660 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2661 exceed INT_MAX.
2662
6511acf2 2663 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2664 (Fvertical_motion): Don't wrap around LINES values that don't fit
2665 in 'int'. Instead, treat them as extreme values. This is good
2666 enough for windows, which can't have more than INT_MAX lines anyway.
2667
fcb901a7
LMI
26682011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2669
0f2f6b6d
LMI
2670 * Require libxml/parser.h to avoid compilation warning.
2671
fcb901a7
LMI
2672 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2673
2674 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2675 since this reportedly can destroy thread storage.
2676
6e20a0d4
CY
26772011-08-30 Chong Yidong <cyd@stupidchicken.com>
2678
2679 * syntax.c (find_defun_start): Update all cache variables if
2680 exiting early (Bug#9401).
2681
148ae00e
EZ
26822011-08-30 Eli Zaretskii <eliz@gnu.org>
2683
f6cfbd8f
EZ
2684 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2685
148ae00e
EZ
2686 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2687 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2688 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2689
2690 * term.c (tty_append_glyph): New function.
2691 (produce_stretch_glyph): Static function and its prototype deleted.
2692
a66cfb1c
SM
2693 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2694 Add prototypes.
148ae00e 2695
c4a07a4c
PE
26962011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2699 when checking :margin (Bug#9390).
2700 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2701 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2702 so that the name doesn't mislead. All uses changed.
2703
6bc8cd65
JB
27042011-08-28 Johan Bockgård <bojohan@gnu.org>
2705
2706 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2707 set_tty_hooks.
2708
dca4927e
EZ
27092011-08-27 Eli Zaretskii <eliz@gnu.org>
2710
2711 * xdisp.c (move_it_to): Don't bail out early when reaching
2712 position beyond to_charpos, if we are scanning backwards.
2713 (move_it_vertically_backward): When DY == 0, make sure we get to
2714 the first character in the line after the newline.
2715
f2cad773
PE
27162011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2719 (ccl_driver): Do not generate an out-of-range pointer.
2720 (Fccl_execute_on_string): Remove unnecessary check for
2721 integer overflow, noted by Stefan Monnier in
2722 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2723 Remove a FIXME that didn't need fixing.
2724 Simplify the newly-introduced buffer reallocation code.
2725
0cae2cdb
JB
27262011-08-27 Juanma Barranquero <lekktu@gmail.com>
2727
2728 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2729
5fc295a4 27302011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2731
70c60eb2 2732 Integer and memory overflow issues (Bug#9196).
726e0ab1 2733
d31850da
PE
2734 * doc.c (get_doc_string): Rework so that
2735 get_doc_string_buffer_size is the actual buffer size, rather than
2736 being 1 less than the actual buffer size; this makes xpalloc more
2737 convenient.
2738
a69fbedb
PE
2739 * image.c (x_allocate_bitmap_record, cache_image):
2740 * xselect.c (Fx_register_dnd_atom):
2741 Simplify previous changes by using xpalloc.
2742
fe5c5d37
PE
2743 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2744 since either will do and ptrdiff_t is convenient with xpalloc.
2745
0065d054
PE
2746 * charset.c (charset_table_size)
2747 (struct charset_sort_data.priority): Now ptrdiff_t.
2748 (charset_compare): Don't overflow if priorities differ greatly.
2749 (Fsort_charsets): Don't assume list length fits in int.
2750 Check for size-calculation overflow when allocating sort data.
2751 (syms_of_charset): Allocate an initial charset table that is
2752 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2753
2754 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2755
2756 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2757 The actual value is always <= INT_MAX, and leaving it unsigned made
2758 overflow checking harder.
2759
2760 * dispextern.h (struct glyph_matrix.rows_allocated)
2761 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2762 with xpalloc. The values are still always <= INT_MAX.
2763
2764 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2765
2766 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2767 (SAFE_NALLOCA): New macro.
2768
2769 * region-cache.c (struct boundary.pos, find_cache_boundary)
2770 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2771 (set_cache_region, invalidate_region_cache)
2772 (revalidate_region_cache, know_region_cache, region_cache_forward)
2773 (region_cache_backward, pp_cache):
2774 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2775 so that ptrdiff_t * can be passed to xpalloc.
2776 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2777 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2778 (pp_cache): Don't assume cache_len fits in int.
2779 * region-cache.h: Adjust extern decls to match.
2780
2781 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2782 EMACS_INT, since either will do, for xpalloc.
2783
2784 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2785 (xnmalloc, xnrealloc, xpalloc): New functions.
2786
726e0ab1
PE
2787 * bidi.c (bidi_shelve_header_size): New constant.
2788 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2789 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2790
51f30bc5 2791 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2792 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2793 (overlay_strings):
2794 Don't update size of array until after memory allocation succeeds,
2795 because xmalloc/xrealloc may not return.
0065d054
PE
2796 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2797 now that we have proper integer overflow checking.
2798 (record_overlay_string, overlay_strings): Catch overflows when
2799 calculating size of overlay_str_buf.
726e0ab1 2800
0065d054
PE
2801 * callproc.c (Fcall_process): Check for size overflow when
2802 calculating size of args2.
2803 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2804 Normally we prefer signed values, but sticking with ptrdiff_t would
2805 require adding more-complicated checks.
726e0ab1
PE
2806
2807 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2808 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2809 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2810 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2811
2812 * character.c (Fstring): Check for size-calculation overflow.
2813
2814 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2815 unnecessary integer overflow. Check for size overflow.
2816 (encode_coding_object): Don't update size until xmalloc succeeds.
2817
2818 * composite.c (get_composition_id): Check for overflow in glyph
2819 length calculations.
2820
2821 Integer and memory overflow fixes for display code.
2822 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2823 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2824 (scrolling_window): Check for overflow in size calculations.
2825 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2826 Don't assume glyph table len fits in int.
2827 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2828 (row_table_size): Now ptrdiff_t, not int.
2829 (scrolling_window): Avoid overflow in size calculations.
2830 Don't update size until allocation succeeds.
2831 * fns.c (concat): Check for overflow in size calculations.
2832 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2833 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2834 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2835
2836 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2837 (get_doc_string): Check for size calculation overflow.
2838 Don't update size until allocation succeeds.
2839 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2840 EMACS_INT, where ptrdiff_t will do.
2841 (Fsubstitute_command_keys): Check for string overflow.
2842
2843 * editfns.c (set_time_zone_rule): Don't assume environment length
2844 fits in int.
2845 (message_length): Now ptrdiff_t, not int.
2846 (Fmessage_box): Don't update size until allocation succeeds.
2847 Don't assume message length fits in int.
2848 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2849
0065d054
PE
2850 * emacs.c (main): Do not reallocate argv, since there is a null at
2851 the end that can be overwritten, and this way there's no need to
2852 worry about size-calculation overflow.
2853 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2854
2855 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2856 alloc succeeds.
2857 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2858
2859 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2860 (x_set_scroll_bar_width, x_figure_window_size):
2861 Check for integer overflow.
2862 (x_set_alpha): Do not assume XINT fits in int.
2863
2864 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2865 This is for the members text_lines, text_cols, total_lines, total_cols,
2866 where the system imposes an 'int' limit.
2867
2868 * fringe.c (Fdefine_fringe_bitmap):
2869 Don't update size until alloc works.
2870
2871 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2872 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2873
2874 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2875 Check for size-calculation overflow.
2876 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2877 do, as we prefer signed integers.
2878 (id_to_widget.max_size, id_to_widget.used)
2879 (xg_store_widget_in_map, xg_remove_widget_from_map)
2880 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2881 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2882 Use and return ptrdiff_t, not int.
2883 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2884 * gtkutil.h: Change prototypes to match the above.
2885
2886 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2887 are duplicate now that they've been promoted to lisp.h.
2888 (x_allocate_bitmap_record, x_alloc_image_color)
2889 (make_image_cache, cache_image, xpm_load):
2890 Don't update size until alloc is done.
2891 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2892 (x_detect_edges):
3256efce 2893 Check for size calculation overflow.
726e0ab1
PE
2894 (ct_colors_allocated_max): New constant.
2895 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2896 overflow.
3256efce 2897
726e0ab1
PE
2898 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2899 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2900 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2901 Use ptrdiff_t, not int, to count maps.
2902 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2903 calculations. Don't update size until allocation succeeds.
2904 Redo calculations to avoid overflow.
726e0ab1
PE
2905 * keyboard.h: Change prototypes to match the above.
2906
2907 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2908 to count maps.
2909 (current_minor_maps): Check for size calculation overflow.
2910 * keymap.h: Change prototypes to match the above.
2911
2912 * lread.c (read1, init_obarray): Don't update size until alloc done.
2913
2914 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2915 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2916
726e0ab1
PE
2917 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2918 Now ptrdiff_t, not int.
2919 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2920 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2921
2922 * process.c (Fnetwork_interface_list): Check for overflow
2923 in size calculation.
2924
2925 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2926
2927 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2928 overflow. Don't bother calling xmalloc when xrealloc will do.
2929
2930 * search.c (Freplace_match): Check for size calculation overflow.
2931 (Fset_match_data): Don't assume list lengths fit in 'int'.
2932
2933 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2934 for command line length. Do not attempt to address one before the
2935 beginning of an array, as that's not portable.
2936
2937 * term.c (max_frame_lines): Remove; unused.
2938 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2939 not int.
2940 (encode_terminal_code, calculate_costs): Check for size
2941 calculation overflow.
2942 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2943 table lengths and related sizes. Don't update size until alloc
2944 done. Redo calculations to avoid overflow.
2945 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2946
2947 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2948 subtracting pointers.
2949 (gobble_line): Check for overflow more carefully. Don't update size
2950 until alloc done.
2951
2952 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2953 Don't update size until alloc done.
2954 Redo size calculations to avoid overflow.
2955 Check for size calculation overflow.
0065d054 2956 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2957
2958 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2959 Use ptrdiff_t, not int, for sizes.
2960 (store_mode_line_noprop_char): Don't update size until alloc done.
2961
0065d054
PE
2962 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2963 Use ptrdiff_t, not int, for sizes.
2964 (Finternal_make_lisp_face, cache_face):
2965 Check for size calculation overflow.
2966 (cache_face): Treat size calculation overflows as if they were
2967 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2968
2969 * xfns.c (x_encode_text, x_set_name_internal)
2970 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2971 sizes, since they can exceed INT_MAX in size. Check for size
2972 calculation overflow.
2973
0065d054
PE
2974 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2975 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2976 Don't update size until alloc done.
2977
0065d054 2978 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2979 as sprintf is limited to int lengths.
1d526e2f 2980
252c5ee1
PE
2981 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2982 (X_LONG_MIN): New macros.
864d7ce7
PE
2983 Use them to make the following changes clearer.
2984 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2985 This change doesn't affect the value now, but it may help remind
2986 future maintainers not to raise the value too much later.
2987 (SELECTION_QUANTUM): Remove, replacing with ...
2988 (selection_quantum): ... new function, which avoids overflow.
2989 All uses changed.
2990 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2991 assumption that selection length fits in 'int'.
2992 (x_reply_selection_request, x_handle_selection_request)
2993 (x_get_window_property, receive_incremental_selection)
2994 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2995 (lisp_data_to_selection_data, clean_local_selection_data):
2996 Use ptrdiff_t, not int, to record length of selection.
2997 (x_reply_selection_request, x_get_window_property)
2998 (receive_incremental_selection, x_property_data_to_lisp):
2999 Redo calculations to avoid overflow.
3000 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3001 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3002 something.
3003 (x_get_window_property, receive_incremental_selection)
3004 (lisp_data_to_selection_data, x_property_data_to_lisp):
3005 Check for size-calculation overflow.
3006 (x_get_window_property, receive_incremental_selection)
3007 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3008 Don't store size until memory allocation succeeds.
3009 (x_get_window_property): Plug memory leak on memory exhaustion.
3010 Don't double-block input; malloc is safe here. Don't assume 2**34
3011 - 4 fits in unsigned long. Add an xassert to check
3012 XGetWindowProperty overflow. Be more careful about overflow
3013 calculations, and distinguish size from memory overflow better.
3014 (receive_incremental_selection): When tracing, don't assume
3015 unsigned int is less than INT_MAX.
3016 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3017 harmful) conversions of unsigned short to int.
3018 (lisp_data_to_selection_data): Don't assume that integers
3019 in the range -65535 through -1 fit in an X unsigned short.
3020 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3021 result parameters unless successful. Rely on cons_to_unsigned
3022 to report problems with elements; the old code wasn't right anyway.
3023 (x_check_property_data): Check for int overflow; we cannot use
3024 a wider type due to X limits.
3025 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3026
726e0ab1 3027 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3028
0065d054
PE
3029 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3030 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3031 (x_color_cells): Don't store size until memory allocation succeeds.
3032 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3033 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3034 (x_term_init): Don't assume length fits in int (sprintf is limited
3035 to int size).
bc18e09d 3036
ebfa62c0
PE
3037 Use ptrdiff_t for composition IDs.
3038 * character.c (lisp_string_width):
3039 * composite.c (composition_table_size, n_compositions)
3040 (get_composition_id, composition_gstring_from_id):
3041 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3042 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3043 * window.c (Frecenter):
3044 Use ptrdiff_t, not int, for composition IDs.
3045 * composite.c (get_composition_id): Check for integer overflow.
3046 * composite.h: Adjust prototypes to match the above changes.
3047
d3411f89
PE
3048 Use ptrdiff_t for hash table indexes.
3049 * category.c (hash_get_category_set):
3050 * ccl.c (ccl_driver):
3051 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3052 * coding.c (coding_system_charset_list, detect_coding_system):
3053 * coding.h (struct coding_system.id):
3054 * composite.c (get_composition_id, gstring_lookup_cache):
3055 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3056 * image.c (xpm_get_color_table_h):
3057 * lisp.h (hash_lookup, hash_put):
3058 * minibuf.c (Ftest_completion):
3059 Use ptrdiff_t for hash table indexes, not int (which is too
3060 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3061 32-bit --with-wide-int hosts).
3062
e097a6fa
PE
3063 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3064 Add a FIXME comment about memory leaks.
3065 (syms_of_charset): Don't assume xmalloc returns.
3066
5637687f
PE
3067 Don't assume that stated character widths fit in int.
3068 * character.c (Fchar_width, c_string_width, lisp_string_width):
3069 * character.h (CHAR_WIDTH):
3070 * indent.c (MULTIBYTE_BYTES_WIDTH):
3071 Use sanitize_char_width to avoid undefined and/or bad behavior
3072 with outlandish widths.
a66cfb1c 3073 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3074 now that we have two such functions. All uses changed.
3075 (sanitize_char_width): New inline function.
3076
a2271ba2
PE
3077 Don't assume that tab-width fits in int.
3078 * character.h (sanitize_width): New inline function.
3079 (SANE_TAB_WIDTH): New macro.
3080 (ASCII_CHAR_WIDTH): Use it.
3081 * indent.c (sane_tab_width): Remove. All uses replaced by
3082 SANE_TAB_WIDTH (current_buffer).
3083 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3084
18c52557
PE
3085 * fileio.c: Integer overflow issues with file modes.
3086 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3087
caeeedc1
PE
3088 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3089 Remove unreachable code.
3090 (read_hex, load_charset_map_from_file): Check for integer overflow.
3091
6df6ae42 3092 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3093 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3094 (x_send_scroll_bar_event): Likewise. Check that the size does not
3095 exceed limits imposed by XClientMessageEvent, as well as the usual
3096 ptrdiff_t and size_t limits.
3097
b13995db
PE
3098 * keyboard.c: Overflow, signedness and related fixes.
3099 (make_lispy_movement): Use same integer type in forward decl
3100 that is used in the definition.
3101 (read_key_sequence, keyremap_step):
3102 Change bufsize argument back to int, undoing my 2011-03-30 change.
3103 We prefer signed types, and int is wide enough here.
3104 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3105 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3106 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3107 length, not size_t. Use ptrdiff_t for index, not int.
3108 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3109 possibility of integer overflow.
3110
13464394
PE
3111 Overflow, signedness and related fixes for images.
3112
3113 * dispextern.h (struct it.stack[0].u.image.image_id)
3114 (struct_it.image_id, struct image.id, struct image_cache.size)
3115 (struct image_cache.used, struct image_cache.ref_count):
3116 * gtkutil.c (update_frame_tool_bar):
3117 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3118 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3119 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3120 * nsmenu.m (update_frame_tool_bar):
3121 * xdisp.c (calc_pixel_width_or_height):
3122 * xfns.c (image_cache_refcount):
3123 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3124 on typical 64-bit hosts.
3125
3126 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3127 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3128 Omit unnecessary casts to int.
3129 (parse_image_spec): Check that integers fall into 'int' range
3130 when the callers expect that.
3131 (image_ascent): Redo ascent calculation to avoid int overflow.
3132 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3133 (lookup_image): Remove unnecessary tests.
3134 (xbm_image_p): Locals are now of int, not EMACS_INT,
3135 since parse_image_check makes sure they fit into int.
3136 (png_load, gif_load, svg_load_image):
3137 Prefer int to unsigned where either will do.
3138 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3139 old tiff_error_handler and tiff_warning_handler.
3140 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3141 stack buffer overflows. It uses only the features of vsnprintf
3142 that are common to both POSIX and native Microsoft.
3143 (tiff_error_handler, tiff_warning_handler): Use it.
3144 (tiff_load, gif_load, imagemagick_load_image):
3145 Don't assume :index value fits in 'int'.
3146 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3147 (imagemagick_load_image): Check that crop parameters fit into
3148 the integer types that MagickCropImage accepts. Don't assume
3149 Vimagemagick_render_type has a nonnegative value. Don't assume
3150 size_t fits in 'long'.
3151 (gs_load): Use printmax_t to print the widest integers possible.
3152 Check for integer overflow when computing image height and width.
3153
c11821d4
EZ
31542011-08-26 Eli Zaretskii <eliz@gnu.org>
3155
3156 * xdisp.c (redisplay_window): Don't force window start if point
3157 will be invisible in the resulting window. (Bug#9324)
3158
0c95fcf7
EZ
31592011-08-25 Eli Zaretskii <eliz@gnu.org>
3160
3161 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3162 the display spec is of the form `(space ...)'.
3163 (handle_display_spec): Return the value returned by
3164 handle_single_display_spec, not just 1 or zero.
3165 (handle_single_display_spec): If the display spec is of the form
3166 `(space ...)', and specifies display in the text area, return 2
3167 rather than 1.
fee65a97 3168 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3169 accurately, and prefer exact match for point under bidi.
3170 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3171
3172 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3173 into disp_prop; all users changed.
3174
3175 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3176 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3177 for the text covered by the display property.
3178
e4ed06f1
CY
31792011-08-25 Chong Yidong <cyd@stupidchicken.com>
3180
3181 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3182 Change return value to nil.
3183 (Frecord_buffer): Delete unused function.
3184
f67cdd7f
EZ
31852011-08-24 Eli Zaretskii <eliz@gnu.org>
3186
5980d4c6
EZ
3187 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3188 buffers, return left-to-right.
8610fe8b
EZ
3189 (set_cursor_from_row): Consider candidate row a win if its glyph
3190 represents a newline and point is on that newline. Fixes cursor
3191 positioning on the newline at EOL of R2L text within L2R
3192 paragraph, and vice versa.
3193 (try_cursor_movement): Check continued rows, in addition to
3194 continuation rows. Fixes unwarranted scroll when point enters a
3195 continued line of R2L text within an L2R paragraph, or vice versa.
3196 (cursor_row_p): Consider the case of point being equal to
3197 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3198 from the end of a short line to the beginning of a continued line
3199 of R2L text within L2R paragraph.
3200 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3201 composed characters.
5980d4c6 3202
f67cdd7f
EZ
3203 * bidi.c (bidi_check_type): Use xassert.
3204 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3205 members.
3206
bca633fb
EZ
32072011-08-23 Eli Zaretskii <eliz@gnu.org>
3208
3209 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3210 a character.
3211
4a5885a7
CY
32122011-08-23 Chong Yidong <cyd@stupidchicken.com>
3213
3214 * nsfont.m (ns_otf_to_script): Fix typo.
3215
0902a04e
KH
32162011-08-22 Kenichi Handa <handa@m17n.org>
3217
3218 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3219 extra slot even if the purpose is char-code-property-table.
3220
1a2e6670
EZ
32212011-08-23 Eli Zaretskii <eliz@gnu.org>
3222
8ddde651
EZ
3223 * xdisp.c (redisplay_window): When computing centering_position,
3224 account for the height of the header line. (Bug#8874)
3225
425cc014
EZ
3226 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3227 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3228 candidate is selected by the mouse, and that candidate has a
3229 composed character under the mouse.
3230
1a2e6670
EZ
3231 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3232 coordinates reported by pos-visible-in-window-p for a composed
3233 character in column zero.
3234
8b76d6f8
SM
32352011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3236
3237 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3238
dac347dd
EZ
32392011-08-22 Eli Zaretskii <eliz@gnu.org>
3240
3241 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3242 consider it a hit if to_charpos is anywhere in the range of the
3243 composed buffer positions.
3244
e013fb34
CY
32452011-08-22 Chong Yidong <cyd@stupidchicken.com>
3246
3247 * image.c (gif_load): Don't assume that each subimage has the same
3248 dimensions as the base image. Handle disposal method that is
3249 "undefined" by the gif spec (Bug#9335).
3250
bd1ba3e8
CY
32512011-08-20 Chong Yidong <cyd@stupidchicken.com>
3252
3253 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3254 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3255
54a1215b
EZ
32562011-08-19 Eli Zaretskii <eliz@gnu.org>
3257
823564e5
EZ
3258 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3259 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3260 from an Org mode buffer to a Speedbar frame.
3261
54a1215b
EZ
3262 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3263 a composition, take its buffer position from IT->cmp_it.charpos.
3264 Fixes cursor positioning at the beginning of a line that begins
3265 with a composed character.
3266
9778ebcc
EZ
32672011-08-18 Eli Zaretskii <eliz@gnu.org>
3268
0be6ee06
EZ
3269 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3270 character bidirectional type, use STRONG_L instead. Fixes crashes
3271 in a buffer produced by `describe-categories'.
3272
9778ebcc
EZ
3273 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3274 members before the level stack, so they would be saved and
3275 restored when copying iterator state. Fixes incorrect reordering
3276 around TABs covered by display properties.
3277
156bffbe
AS
32782011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3279
6b02f655 3280 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3281
72ad093b
CY
32822011-08-17 Chong Yidong <cyd@stupidchicken.com>
3283
3284 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3285 (internal_condition_case_2, internal_condition_case_n):
3286 Remove unnecessary aborts (Bug#9081).
72ad093b 3287
35774242
EZ
32882011-08-17 Eli Zaretskii <eliz@gnu.org>
3289
3290 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3291 has no `load' handler, try opening the file locally. (Bug#9311)
3292
db76dd85
KB
32932011-08-16 Ken Brown <kbrown@cornell.edu>
3294
3295 * gmalloc.c: Expand comment.
3296
b215eee5
EZ
32972011-08-16 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3300 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3301
a4579d33
KB
33022011-08-16 Ken Brown <kbrown@cornell.edu>
3303
3304 Fix memory allocation problems in Cygwin build (Bug#9273).
3305
3306 * unexcw.c ( __malloc_initialized): Declare external variable.
3307 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3308
8b76d6f8
SM
3309 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3310 New variables.
a4579d33
KB
3311 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3312 dumped emacs.
3313 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3314 in the static heap.
3315 [CYGWIN] (special_realloc): New function.
3316 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3317 requests to realloc storage in the static heap.
3318
3ebec551
PE
33192011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * bidi.c (bidi_initialize): Remove unused local.
3322
9fd8be00
EZ
33232011-08-15 Eli Zaretskii <eliz@gnu.org>
3324
6b02f655
SM
3325 * bidimirror.h:
3326 * biditype.h: Remove file.
3327 * makefile.w32-in ($(BLD)/bidi.$(O)):
3328 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3329
3330 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3331
3332 * chartab.c: Improve commentary for the uniprop_table API.
3333
32413314
EZ
3334 * bidi.c (bidi_paragraph_init): Support zero value of
3335 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3336 (bidi_initialize): Use uniprop_table instead of including
3337 biditype.h and bidimirror.h.
32413314 3338
9fd8be00
EZ
3339 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3340 coordinates of the iterator when restoring from ppos_it.
3341 (Bug#9296)
3342
5cf2b69b
KH
33432011-08-14 Kenichi Handa <handa@m17n.org>
3344
3345 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3346 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3347
daf17d00
EZ
33482011-08-14 Eli Zaretskii <eliz@gnu.org>
3349
3350 * xdisp.c (move_it_in_display_line_to): Don't invoke
3351 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3352 ppos_it. Fixes vertical cursor motion when line beginning is
3353 covered by an image. (Bug#9296)
3354
08e3161a
JD
33552011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3356
3357 * nsterm.h (ns_run_ascript): Declare.
3358 (NSAPP_DATA2_RUNASSCRIPT): Define.
3359
3360 * nsfns.m (as_script, as_result, as_status): New static variables.
3361 (ns_run_ascript): New function.
5e617bc2 3362 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3363 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3364 the event loop. Get status from as_status (Bug#7276).
3365
3366 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3367 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3368 the event loop (Bug#7276).
3369
a3720aa2
AS
33702011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3371
3372 * gnutls.c (QCgnutls_bootprop_priority)
3373 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3374 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3375 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3376 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3377 (QCgnutls_bootprop_verify_hostname_error)
3378 (QCgnutls_bootprop_callbacks_verify): Rename from
3379 Qgnutls_bootprop_..., all uses changed.
3380
3381 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3382 uses changed.
3383
0a0d27fb
PE
33842011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3385
19d5c50c
PE
3386 * xfaces.c (Qframe_set_background_mode): Now static.
3387 * dispextern.h (Qframe_set_background_mode): Remove decl.
3388
0a0d27fb
PE
3389 * process.c (Fnetwork_interface_info): Declare local only if needed.
3390
377538cb
JD
33912011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3392
3393 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3394 (Fnetwork_interface_list): Allocate in increments of bytes instead
3395 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3396 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3397 sockaddr.
3398 (struct ifflag_def): notrailers is smart on OSX.
3399 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3400 Get hardware address with getifaddrs if available.
3401
08fff70c
EZ
34022011-08-12 Eli Zaretskii <eliz@gnu.org>
3403
3404 * xdisp.c (iterate_out_of_display_property): xassert that
3405 IT->position is set to within IT->object's boundaries. Break from
3406 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3407 when IT->position is set up wrongly due to some bug.
3408 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3409 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3410 entry. Force push_it to save on the stack the current
3411 buffer/string position, to be restored by pop_it. Fix flags in
3412 the iterator structure wrt the object coming from a display
3413 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3414 properties. (Bug#9284)
3415
7be1c708 34162011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3417
7be1c708
CY
3418 * fontset.c (fontset_get_font_group): Add proper type checks.
3419 (Bug#9172)
aac0c6e3 3420
7be1c708 34212011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3422
7be1c708
CY
3423 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3424 and LC_VERSION_MIN_MACOSX.
3425 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3426 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3427
97bb72a6
EZ
34282011-08-08 Eli Zaretskii <eliz@gnu.org>
3429
3430 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3431 no-display-properties-and-no-overlays under bidi display.
3432 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3433 properties and overlays.
97bb72a6 3434
d5617611
CY
34352011-08-08 Chong Yidong <cyd@stupidchicken.com>
3436
37e11a63
CY
3437 * editfns.c (Fset_time_zone_rule): Document relationship with the
3438 setenv function.
3439
d5617611
CY
3440 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3441 the font entity extracted from the cache (Bug#8109).
3442
58872834
CY
34432011-08-07 Chong Yidong <cyd@stupidchicken.com>
3444
3445 * composite.c (autocmp_chars): Don't reset point. That is done by
3446 restore_point_unwind (Bug#5984).
3447
75bfc667
JL
34482011-08-07 Juri Linkov <juri@jurta.org>
3449
3450 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3451 to show the arg `TIME' instead of `TIMEVAL'.
3452
d1410150
EZ
34532011-08-06 Eli Zaretskii <eliz@gnu.org>
3454
3455 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3456 display property strides EOL and includes a newline, as in
3457 longlines-mode. (Bug#9254)
75b771e4
EZ
3458 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3459 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3460
3461 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3462 is non-zero, even if the data buffer is NULL. Fixes a crash in
3463 vertical-motion with longlines-mode. (Bug#9254)
3464
35928349
EZ
34652011-08-05 Eli Zaretskii <eliz@gnu.org>
3466
ec7cc85b
EZ
3467 * bidi.c <bidi_cache_total_alloc>: Now static.
3468 (bidi_initialize): Initialize bidi_cache_total_alloc.
3469
8b76d6f8 3470 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3471 cache. (Bug#9221)
3472
3473 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3474 amount allocated this far in `bidi_cache_total_alloc'.
3475 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3476 non-zero, only free the data buffer without restoring the cache
3477 contents. All callers changed.
3478
3479 * dispextern.h (bidi_unshelve_cache): Update prototype.
3480
3481 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3482 (move_it_in_display_line, move_it_to)
3483 (move_it_vertically_backward, move_it_by_lines): Replace the call
3484 to xfree to an equivalent call to bidi_unshelve_cache.
3485 (move_it_in_display_line_to): Fix logic of returning
412b6358 3486 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3487
e2e2423b
EZ
34882011-08-05 Eli Zaretskii <eliz@gnu.org>
3489
3490 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3491 came from a string character with a `cursor' property. (Bug#9229)
3492
ae9e757a
JD
34932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3494
3495 * Makefile.in (LIB_PTHREAD): New variable.
3496 (LIBES): Add LIB_PTHREAD (Bug#9216).
3497
3498 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3499 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3500
213bd7f2
AS
35012011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3502
6b02f655 3503 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3504
99aaf75f
JD
35052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3506
3507 * xterm.c (x_find_topmost_parent): New function.
3508 (x_set_frame_alpha): Find topmost parent window with
3509 x_find_topmost_parent and set the property there also (bug#9181).
3510 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3511
c74e9d86
PE
35122011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * callproc.c (Fcall_process): Avoid vfork clobbering
3515 the local vars buffer, coding_systems, current_dir.
3516
640c8776
SM
35172011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3518
3519 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3520
f26d0e4c
PE
35212011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3522
8a10d76c
PE
3523 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3524 so that it is not optimized away.
3525
f26d0e4c
PE
3526 * xdisp.c (compute_display_string_pos): Remove unused local.
3527
55439c61
EZ
35282011-08-02 Eli Zaretskii <eliz@gnu.org>
3529
3530 Fix slow cursor motion and scrolling in large buffers with
3531 selective display, like Org Mode buffers. (Bug#9218)
3532
3533 * dispextern.h (struct bidi_it): New member disp_prop_p.
3534
3535 * xdisp.c: Remove one-slot cache of display string positions.
3536 (compute_display_string_pos): Accept an additional argument
5e617bc2 3537 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3538 for a display string or property. If found, set DISP_PROP_P
3539 non-zero.
3540
3541 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3542 DISP_PROP_P, and pass it to compute_display_string_pos.
3543 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3544 non-zero. All callers of bidi_fetch_char changed.
3545
fb33fa43
SM
35462011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3547
3548 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3549
b099e063
DM
35502010-12-03 Don March <don@ohspite.net>
3551
3552 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3553 last character M-[char] is translated to ESC [char] (bug#7541).
3554
5cc7f7af
KH
35552011-08-02 Kenichi Handa <handa@m17n.org>
3556
d0fffa3f 3557 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3558
3559 * chartab.c (uniprop_table): Make it non-static.
3560
525d5e6e
EZ
35612011-08-01 Eli Zaretskii <eliz@gnu.org>
3562
3563 * xdisp.c (forward_to_next_line_start): Accept additional argument
3564 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3565 on the newline.
3566 (reseat_at_next_visible_line_start): Use the bidi iterator state
3567 returned by forward_to_next_line_start to restore the state of
3568 it->bidi_it after backing up to previous newline. (Bug#9212)
3569
31011111
AS
35702011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3571
3572 * regex.c (re_comp): Protoize.
3573 (re_exec): Fix return type.
3574 (regexec): Fix type of `ret'. (Bug#9203)
3575
476371c4
PE
35762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3577
e5d76069
PE
3578 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3579 This is needed if max-image-size is a floating-point number.
3580
9a79b20c
AS
35812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3582
3583 * print.c (print_object): Print empty symbol as ##.
3584
3585 * lread.c (read1): Read ## as empty symbol.
3586
d8c2fa78
AA
35872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3588
3589 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3590 setting frame foreground color (Bug#9175).
3591 (x_set_background_color): Likewise.
3592
ffe57a7a
AA
3593 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3594 contents (Bug#9176).
3595 (EmacsTooltip -init): Remove bezels and add shadows to
3596 tooltip windows.
3597
bf3492a5
AA
3598 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3599 or scroll bar (Bug#8470).
3600
d55e9c53
AA
3601 * nsfont.m (nsfont_open): Remove assignment to voffset and
3602 unnecessary vars hshink, expand, hd, full_height, min_height.
3603 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3604
3605 * nsterm.h (nsfont_info): Remove voffset field.
3606
d8c2fa78 36072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3608
3609 Implement strike-through and overline on NextStep (Bug#8863).
3610
3611 * nsfont.m (nsfont_open): Use underline position provided by font,
3612 instead of hard-coded value of 2.
3613 (nsfont_draw): Call ns_draw_text_decoration instead.
3614
3615 * nsterm.h: Add declaration for ns_draw_text_decoration.
3616
3617 * nsterm.m (ns_draw_text_decoration): New function for drawing
3618 underline, overline, and strike-through.
3619 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3620 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3621 accommodate underlining, etc.
4843aac3 3622
4cc60b9b
EZ
36232011-07-28 Eli Zaretskii <eliz@gnu.org>
3624
bc7ece87
EZ
3625 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3626 default.
4cc60b9b 3627
476371c4
PE
36282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3629
66606eea
PE
3630 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3631 Without this fix, if a signal arrives just after memory fills up,
3632 'malloc' might be invoked reentrantly.
3633
476371c4
PE
3634 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3635 In other words, assume that every image size is allowed, on non-X
3636 hosts. This assumption is probably wrong, but it lets Emacs compile.
3637
f3fcc40d
AS
36382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3639
3640 * regex.c (re_iswctype): Convert return values to boolean.
3641
350c992f
EZ
36422011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3643
3644 * xdisp.c (compute_display_string_pos): Don't use cached display
3645 string position if the buffer had its restriction changed.
3646 (Bug#9184)
3647
5266b4bb
PE
36482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3649
3650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3651
2573a837 36522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3653
41f55ccd 3654 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3655
39e378da
PE
3656 * bidi.c: Integer size and overflow fixes.
3657 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3658 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3659 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3660 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3661 (bidi_find_other_level_edge):
3662 Use ptrdiff_t instead of EMACS_INT where either will do.
3663 This works better on 32-bit hosts configured --with-wide-int.
3664 (bidi_cache_ensure_space): Check for size-calculation overflow.
3665 Use % rather than repeated addition, for better worst-case speed.
3666 Don't set bidi_cache_size until after xrealloc returns, because it
3667 might not return.
3668 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3669 (bidi_cache_ensure_space): Also check that the bidi cache size
3670 does not exceed that of the largest Lisp string or buffer. See Eli
3671 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3672
5e927815
PE
3673 * alloc.c (__malloc_size_t): Remove.
3674 All uses replaced by size_t. See Andreas Schwab's note
3675 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3676
ca4aa935
PE
3677 * image.c: Improve checking for integer overflow.
3678 (check_image_size): Assume that f is nonnull, since
3679 it is always nonnull in practice. This is one less thing to
3680 worry about when checking for integer overflow later.
3681 (x_check_image_size): New function, which checks for integer
3682 overflow issues inside X.
3683 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3684 This removes the need for a memory_full check.
3685 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3686 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3687 (xbm_read_bitmap_data): Change locals back to 'int', since
3688 their values must fit in 'int'.
3689 (xpm_load_image, png_load, tiff_load):
3690 Invoke x_create_x_image_and_pixmap earlier,
3691 to avoid much needless work if the image is too large.
3692 (tiff_load): Treat overly large images as if
3693 x_create_x_image_and_pixmap failed, not as malloc failures.
3694 (gs_load): Use x_check_image_size.
3695
5f8f9cc2
PE
3696 * gtkutil.c: Omit integer casts.
3697 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3698 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3699
5adf60bc
PE
3700 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3701
c8907a93
PE
3702 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3703 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3704 would wrongly return t on a 64-bit host.
3705
e3c25c68
PE
3706 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3707 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3708 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3709 and therefore cause GCC to emit a bogus diagnostic in some cases.
3710
3f791afe
PE
3711 * image.c: Integer signedness and overflow and related fixes.
3712 This is not an exhaustive set of fixes, but it's time to
3713 record what I've got.
3714 (lookup_pixel_color, check_image_size): Remove redundant decls.
3715 (check_image_size): Don't assume that arbitrary EMACS_INT values
3716 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3717 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3718 (tiff_load, imagemagick_load_image):
3719 Check for overflow in size calculations.
3720 (x_create_x_image_and_pixmap): Remove unnecessary test for
3721 xmalloc returning NULL; that can't happen.
3722 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3723 (xpm_color_bucket): Use better integer hashing function.
3724 (xpm_cache_color): Don't possibly over-allocate memory.
3725 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3726 (gif_memory_source):
3727 Use ptrdiff_t, not int or size_t, to record sizes.
3728 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3729 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3730 either works, as we prefer signed integers.
3731 (tiff_read_from_memory, tiff_write_from_memory):
3732 Return tsize_t, not size_t, since that's what the TIFF API wants.
3733 (tiff_read_from_memory): Don't fail simply because the read would
3734 go past EOF; instead, return a short read.
3735 (tiff_load): Omit no-longer-needed casts.
3736 (Fimagemagick_types): Don't assume size fits into 'int'.
3737
3cc5a532
PE
3738 Improve hashing quality when configured --with-wide-int.
3739 * fns.c (hash_string): New function, taken from sxhash_string.
3740 Do not discard information about ASCII character case; this
3741 discarding is no longer needed.
3742 (sxhash-string): Use it. Change sig to match it. Caller changed.
3743 * lisp.h: Declare it.
3744 * lread.c (hash_string): Remove, since we now use fns.c's version.
3745 The fns.c version returns a wider integer if --with-wide-int is
3746 specified, so this should help the quality of the hashing a bit.
3747
b312a492
PE
3748 * emacs.c: Integer overflow minor fix.
3749 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3750 Define only if GNU_LINUX.
3751 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3752
dfd153ae
PE
3753 * dispnew.c: Integer signedness and overflow fixes.
3754 Remove unnecessary forward decls, that were a maintenance hassle.
3755 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3756 All uses changed.
3757 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3758 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3759 (prepare_desired_row, line_draw_cost):
3760 Use int, not unsigned, where either works.
3761 (save_current_matrix, restore_current_matrix):
3762 Use ptrdiff_t, not size_t, where either works.
3763 (init_display): Check for overflow more accurately, and without
3764 relying on undefined behavior.
3765
a81d11a3
PE
3766 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3767 Remove, replacing with the new symbols in lisp.h. All uses changed.
3768 * fileio.c (make_temp_name):
3769 * filelock.c (lock_file_1, lock_file):
3770 * xdisp.c (message_dolog):
3771 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3772 Use pMd etc. instead.
3773 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3774 replacing the pWIDE etc. symbols removed from editfns.c.
3775
3300e6fd
PE
3776 * keyboard.h (num_input_events): Now uintmax_t.
3777 This is (very slightly) less likely to mess up due to wraparound.
3778 All uses changed.
3779
fd05c7e9
PE
3780 * buffer.c: Integer signedness fixes.
3781 (alloc_buffer_text, enlarge_buffer_text):
3782 Use ptrdiff_t rather than size_t when either will do, as we prefer
3783 signed integers.
3784
903fe15d
PE
3785 * alloc.c: Integer signedness and overflow fixes.
3786 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3787 (__malloc_size_t): Default to size_t, not to int.
3788 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3789 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3790 Prefer ptrdiff_t to size_t when either would do, as we prefer
3791 signed integers.
3792 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3793 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3794 Now const. Initialize with values that are in range even if char
3795 is signed.
3796 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3797 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3798 These functions do the right thing with sizes > 2**32.
3799 (check_depth): Now ptrdiff_t, not int.
3800 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3801 Adjust to new way of storing sizes. Check for size overflow bugs
3802 in rest of code.
3803 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3804 slightly wrong anyway, as it missed one instance of
3805 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3806 (refill_memory_reserve): Omit needless cast to size_t.
3807 (mark_object_loop_halt): Mark as externally visible.
3808
ac82cc6a
PE
3809 * xselect.c: Integer signedness and overflow fixes.
3810 (Fx_register_dnd_atom, x_handle_dnd_message):
3811 Use ptrdiff_t, not size_t, since we prefer signed.
3812 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3813 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3814 x_dnd_atoms_size and x_dnd_atoms_length.
3815
c2d1e36d
PE
3816 * doprnt.c: Prefer signed to unsigned when either works.
3817 * eval.c (verror):
3818 * doprnt.c (doprnt):
3819 * lisp.h (doprnt):
3820 * xdisp.c (vmessage):
3821 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3822 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3823 prefer signed arithmetic to avoid comparison confusion.
3824 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3825 but is a bit tricky.
3826
0e926e56
PE
3827 Assume freestanding C89 headers, string.h, stdlib.h.
3828 * data.c, doprnt.c, floatfns.c, print.c:
3829 Include float.h unconditionally.
3830 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3831 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3832 * regex.c: Likewise for stddef.h, string.h.
3833 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3834 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3835 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3836 (STDC_HEADERS): Remove obsolete defines.
3837 * sysdep.c: Include limits.h unconditionally.
3838
9cfdb3ec
PE
3839 Assume support for memcmp, memcpy, memmove, memset.
3840 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3841 * regex.c (memcmp, memcpy):
3842 Remove; we assume C89 now.
3843
3844 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3845 (__malloc_safe_bcopy): Remove; no longer needed.
3846
cf950e6b 3847 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3848 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3849 well either way, and we prefer signed to unsigned.
3850
dbf38e02
LMI
38512011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3852
3853 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3854 closes the connection while we're reading (bug#9182).
3855
d6f0886c 38562011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3857
d6f0886c
JD
3858 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3859 are specified (Bug#9168).
24e0f6b1 3860
2eb1f9e6
PE
38612011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3864 Found by GCC static checking and --with-wide-int on a 32-bit host.
3865
22381272 38662011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3867
3868 * xdisp.c (compute_display_string_pos): Fix logic of caching
3869 previous display string position. Initialize cached_prev_pos to
3870 -1. Fixes slow-down at the beginning of a buffer.
3871
f25e39b4
EZ
38722011-07-24 Eli Zaretskii <eliz@gnu.org>
3873
3874 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3875 for attrs[LFACE_FONTSET_INDEX].
3876
04c4b52e
PE
38772011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * xml.c (parse_region): Remove unused local
3880 that was recently introduced.
3881
c1734fbd
EZ
38822011-07-23 Eli Zaretskii <eliz@gnu.org>
3883
be18c5a5
EZ
3884 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3885 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3886
c1734fbd
EZ
3887 * xdisp.c (move_it_in_display_line_to): Record the best matching
3888 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3889 exit if none of the characters scanned was an exact match.
3890 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3891 when exact match is impossible due to invisible text, and the
3892 lines are truncated.
3893
a258d627
JD
38942011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3895
3896 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3897 for OSX >= 10.7.
3898
b6d5a689
EZ
38992011-07-22 Eli Zaretskii <eliz@gnu.org>
3900
0f74f785
EZ
3901 Fix a significant slow-down of cursor motion with C-n, C-p,
3902 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3903 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3904 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3905 (next_element_from_buffer): Call compute_stop_pos_backwards to
3906 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3907 base_level_stop.
3908 (reseat): Don't look for prev_stop, as that could mean a very long
3909 run.
3910 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3911 <cached_disp_overlay_modiff>: Cache for last found display string
3912 position.
551918c1 3913 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3914 about the same buffer in the same area of character positions, and
3915 the buffer wasn't changed since the time the display string
3916 position was cached.
551918c1 3917
b2d0c91a
EZ
39182011-07-22 Eli Zaretskii <eliz@gnu.org>
3919
3920 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3921 is an integer, which is important for empty lines. (Bug#9149)
3922
043604ee
CY
39232011-07-22 Chong Yidong <cyd@stupidchicken.com>
3924
3925 * frame.c (Fmodify_frame_parameters): In tty case, update the
3926 default face if necessary (Bug#4238).
3927
da4adb04
CY
39282011-07-21 Chong Yidong <cyd@stupidchicken.com>
3929
3930 * editfns.c (Fstring_to_char): No need to explain what a character
3931 is in the docstring (Bug#6576).
3932
9abd0532
LMI
39332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3934
3935 * xml.c (parse_region): Make sure we always return a tree.
3936
36881d16
HK
39372011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3938
3939 * xml.c (parse_region): If a document contains only comments,
3940 return that, too.
3941
1e98674d
LMI
39422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3943
3944 * xml.c (make_dom): Return comments, too.
3945
590bd467
PE
39462011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Port to OpenBSD.
3949 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3950 and the surrounding thread.
3951 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3952 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3953 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3954 timer goes off.
3955 * s/openbsd.h (BROKEN_SIGIO): Define.
3956 * unexelf.c (unexec) [__OpenBSD__]:
3957 Don't update the .mdebug section of the Alpha COFF symbol table.
3958
f41628b2
LMI
39592011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3960
3961 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3962 (bug#8460).
3963
b59b67c5
PE
39642011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3965
15e3a074
PE
3966 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3967 This fixes some race conditions on the permissions of any newly
3968 created file.
3969
41bed37d
PE
3970 * alloc.c (valid_pointer_p): Use pipe, not open.
3971 This fixes some permissions issues when debugging.
3972
b59b67c5
PE
3973 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3974 If fchown fails to set both uid and gid, try to set just gid,
3975 as that is sometimes allowed. Adjust the file's mode to eliminate
3976 setuid or setgid bits that are inappropriate if fchown fails.
3977
925a6be7
SM
39782011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3979
3980 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3981 to compare Lisp_Objects.
3982 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3983 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3984 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3985
52968808
AS
39862011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3987
0a6a104b
AS
3988 * lread.c (read_integer): Unread even EOF character.
3989 (read1): Likewise. Properly record start position of symbol.
3990
52968808
AS
3991 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3992 symbol character follows.
3993
9e381cdd
PE
39942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3997 This works around a problem with the previous change to Fcopy_file.
3998 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3999 and without this change, GCC might complain about discarding
4000 fchown's return value.
4001
b5641435
JB
40022011-07-16 Juanma Barranquero <lekktu@gmail.com>
4003
4004 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4005
a8031457
PE
40062011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4009
dd889327
LMI
40102011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4011
750c33f7
LMI
4012 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4013 it's used from the C level.
4014
dd889327
LMI
4015 * process.c: Use the same condition for POLL_FOR_INPUT in both
4016 keyboard.c and process.c (bug#1858).
4017
87e86684
LM
40182011-07-09 Lawrence Mitchell <wence@gmx.li>
4019
4020 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4021 (Fgnutls_boot): Use it.
4022
64348f40
AS
40232011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4024
4025 * doc.c (Fsubstitute_command_keys): Revert last change.
4026
1d698799
LMI
40272011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4028
f863868c
LMI
4029 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4030 quotes the next character, and doesn't affect other longer
4031 sequences (bug#8935).
4032
1d698799
LMI
4033 * lread.c (syms_of_lread): Clarify that is isn't only
4034 `eval-buffer' and `eval-defun' that's affected by
4035 `lexical-binding' (bug#8460).
4036
aa4b6df6
EZ
40372011-07-15 Eli Zaretskii <eliz@gnu.org>
4038
4039 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4040 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4041
5d856da6
PE
40422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4043
ad6042bb
PE
4044 Fix minor problems found by static checking.
4045 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4046 (elsz): Now a signed constant, not a size_t var. We prefer signed
4047 types to unsigned, to avoid integer comparison confusion. Without
4048 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4049 "cannot optimize loop, the loop counter may overflow", a symptom
4050 of the confusion.
f00bbb22 4051 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4052 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4053
6468f31c
LMI
40542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4055
49080b10
LMI
4056 * search.c (Fre_search_backward): Mention `case-fold-search' in
4057 all the re_search_* functions (bug#8138).
4058
6468f31c
LMI
4059 * keyboard.c (Fopen_dribble_file): Document when the file is
4060 closed (bug#8056).
4061
c965adc5
EZ
40622011-07-14 Eli Zaretskii <eliz@gnu.org>
4063
df9733bf
EZ
4064 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4065 bidi_cache_idx.
4066
0bb23927
EZ
4067 Support bidi reordering of display and overlay strings.
4068 * xdisp.c (compute_display_string_pos)
4069 (compute_display_string_end): Accept additional argument STRING.
4070 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4071 (reseat_to_string): Initialize bidi_it->string.s and
4072 bidi_it->string.schars.
4073 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4074 NULL (avoids a crash in bidi_paragraph_init).
4075 Initialize itb.string.lstring.
0bb23927
EZ
4076 (init_iterator): Call bidi_init_it only of a valid
4077 buffer position was specified. Initialize paragraph_embedding to
4078 L2R.
4079 (reseat_to_string): Initialize the bidi iterator.
4080 (display_string): If we need to ignore text properties of
4081 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4082 original value of -1 will not work with bidi.)
4083 (compute_display_string_pos): First arg is now struct
4084 `text_pos *'; all callers changed. Support display properties on
4085 Lisp strings.
4086 (compute_display_string_end): Support display properties on Lisp
4087 strings.
4088 (init_iterator, reseat_1, reseat_to_string): Initialize the
4089 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4090 when iterating on a string not from display properties).
640c8776
SM
4091 (compute_display_string_pos, compute_display_string_end):
4092 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4093 arrow keys.
4094 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4095 base_level_stop; instead, set base_level_stop to BEGV.
4096 Fixes crashes in vertical-motion.
0bb23927
EZ
4097 (next_element_from_buffer): Improve commentary for when
4098 the iterator is before prev_stop.
4099 (init_iterator): Initialize bidi_p from the default value of
4100 bidi-display-reordering, not from buffer-local value. Use the
4101 buffer-local value only if initializing for buffer iteration.
4102 (handle_invisible_prop): Support invisible properties on strings
4103 that are being bidi-reordered.
4104 (set_iterator_to_next): Support bidi reordering of C strings and
4105 Lisp strings.
4106 (next_element_from_string): Support bidi reordering of Lisp
4107 strings.
4108 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4109 (display_string): Support display of R2L glyph rows.
4110 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4111 (init_iterator): Don't initialize it->bidi_p for strings
4112 here.
4113 (reseat_to_string): Initialize it->bidi_p for strings here.
4114 (next_element_from_string, next_element_from_c_string)
4115 (next_element_from_buffer): Add xassert's for correspondence
4116 between IT's object being iterated and it->bidi_it.string
4117 structure.
4118 (face_before_or_after_it_pos): Support bidi iteration.
4119 (next_element_from_c_string): Handle the case of the first string
4120 character that is not the first one in the visual order.
4121 (get_visually_first_element): New function, refactored from common
4122 parts of next_element_from_buffer, next_element_from_string, and
4123 next_element_from_c_string.
4124 (tool_bar_lines_needed, redisplay_tool_bar)
4125 (display_menu_bar): Force left-to-right direction. Add a FIXME
4126 comment for making that be controlled by a user option.
4127 (push_it, pop_it): Save and restore the state of the
4128 bidi iterator. Save and restore the bidi_p flag.
4129 (pop_it): Iterate out of display property for string iteration as
4130 well.
4131 (iterate_out_of_display_property): Support iteration over strings.
4132 (handle_single_display_spec): Set up it->bidi_it for iteration
4133 over a display string, and call bidi_init_it.
4134 (handle_single_display_spec, next_overlay_string)
4135 (get_overlay_strings_1, push_display_prop): Set up the bidi
4136 iterator for displaying display or overlay strings.
4137 (forward_to_next_line_start): Don't use the shortcut if
4138 bidi-iterating.
4139 (back_to_previous_visible_line_start): If handle_display_prop
4140 pushed the iterator stack, restore the internal state of the bidi
4141 iterator by calling bidi_pop_it same number of times.
4142 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4143 and we are bidi-iterating, don't decrement the iterator position;
4144 instead, set the first_elt flag in the bidi iterator, to produce
4145 the same effect.
4146 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4147 (push_display_prop): xassert that we are iterating a buffer.
4148 (push_it, pop_it): Save and restore paragraph_embedding member.
4149 (handle_single_display_spec, next_overlay_string)
4150 (get_overlay_strings_1, reseat_1, reseat_to_string)
4151 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4152 correctly. Don't assume unibyte strings are not bidi-reordered.
4153 (compute_display_string_pos)
4154 (compute_display_string_end): Fix handling the case of C string.
4155 (push_it, pop_it): Save and restore from_disp_prop_p.
4156 (handle_single_display_spec, push_display_prop): Set the
4157 from_disp_prop_p flag.
4158 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4159 (pop_it): Call iterate_out_of_display_property only if we are
4160 popping after iteration over a string that came from a display
4161 property. Fix a typo in popping stretch info. Add an assertion
4162 for verifying that the iterator position is in sync with the bidi
4163 iterator.
4164 (handle_single_display_spec, get_overlay_strings_1)
4165 (push_display_prop): Fix initialization of paragraph direction for
4166 string when that of the parent object is not yet determined.
4167 (reseat_1): Call bidi_init_it to resync the bidi
4168 iterator with IT's position. (Bug#7616)
4169 (find_row_edges): If ROW->start.pos gives position
4170 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4171 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4172 Reset the from_disp_prop_p flag.
4173 (SAVE_IT, RESTORE_IT): New macros.
4174 (pos_visible_p, face_before_or_after_it_pos)
4175 (back_to_previous_visible_line_start)
4176 (move_it_in_display_line_to, move_it_in_display_line)
4177 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4178 (try_scrolling, redisplay_window, display_line): Use them when
4179 saving a temporary copy of the iterator and restoring it back.
4180 (back_to_previous_visible_line_start, reseat_1)
4181 (init_iterator): Empty the bidi cache "stack".
4182 (move_it_in_display_line_to): If iterator ended up at
4183 EOL, but we never saw any buffer positions smaller than
4184 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4185 motion in bidi-reordered lines.
4186 (move_it_in_display_line_to): Record prev_method and prev_pos
4187 immediately before the call to set_iterator_to_next. Fixes cursor
4188 motion in bidi-reordered lines with stretch glyphs and strings
4189 displayed in margins. (Bug#8133) (Bug#8867)
4190 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4191 TO_CHARPOS.
640c8776
SM
4192 (pos_visible_p): Support positions in bidi-reordered lines.
4193 Save and restore bidi cache.
0bb23927
EZ
4194
4195 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4196 (bidi_paragraph_info): Delete unused struct.
4197 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4198 (bidi_cache_start): New variable.
4199 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4200 to zero.
4201 (bidi_cache_fetch_state, bidi_cache_search)
4202 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4203 (bidi_cache_find, bidi_peek_at_next_level)
4204 (bidi_level_of_next_char, bidi_find_other_level_edge)
4205 (bidi_move_to_visually_next): Compare cache index with
4206 bidi_cache_start rather than with zero.
4207 (bidi_fetch_char): Accept new argument STRING; all callers
4208 changed. Support iteration over a string. Support strings with
4209 display properties. Support unibyte strings. Fix the type of
4210 `len' according to what STRING_CHAR_AND_LENGTH expects.
4211 (bidi_paragraph_init, bidi_resolve_explicit_1)
4212 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4213 (bidi_level_of_next_char, bidi_move_to_visually_next):
4214 Support iteration over a string.
0bb23927
EZ
4215 (bidi_set_sor_type, bidi_resolve_explicit_1)
4216 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4217 can now be zero (for strings); special values 0 and -1 were
4218 changed to -1 and -2, respectively.
4219 (bidi_char_at_pos): New function.
4220 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4221 Call it instead of FETCH_MULTIBYTE_CHAR.
4222 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4223 initialized to valid values.
4224 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4225 values.
4226 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4227 the test for valid cached positions. Fix the logic for looking up
4228 the sentinel state in the cache. GCPRO the Lisp string we are
4229 iterating.
4230 (bidi_push_it, bidi_pop_it): New functions.
4231 (bidi_initialize): Initialize the bidi cache start stack pointer.
4232 (bidi_cache_ensure_space): New function, refactored from part of
4233 bidi_cache_iterator_state. Don't assume the required size is just
4234 one BIDI_CACHE_CHUNK away.
4235 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4236 (bidi_count_bytes, bidi_char_at_pos): New functions.
4237 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4238 always valid if bidi_cache_idx is valid.
4239 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4240 is valid if it's going to be used.
4241 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4242 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4243 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4244 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4245 (bidi_find_other_level_edge, bidi_cache_start_stack):
4246 All variables related to cache indices are now EMACS_INT.
c965adc5 4247
0bb23927
EZ
4248 * dispextern.h (struct bidi_string_data): New structure.
4249 (struct bidi_it): New member `string'. Make flag members be 1-bit
4250 fields, and put them last in the struct.
640c8776
SM
4251 (compute_display_string_pos, compute_display_string_end):
4252 Update prototypes.
0bb23927
EZ
4253 (bidi_push_it, bidi_pop_it): Add prototypes.
4254 (struct iterator_stack_entry): New members bidi_p,
4255 paragraph_embedding, and from_disp_prop_p.
4256 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4257 (bidi_shelve_cache, bidi_unshelve_cache):
4258 Declare prototypes.
0bb23927
EZ
4259
4260 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4261 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4262 and vector-like objects.
4263
4264 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4265 cache around display iteration.
4266
4267 * window.c (Fwindow_end, window_scroll_pixel_based)
4268 (displayed_window_lines, Frecenter): Save and restore the bidi
4269 cache around display iteration.
4270
3bbd2265
LMI
42712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4272
4273 * editfns.c (Fdelete_region): Clarify the use of the named
4274 parameters (bug#6788).
4275
adc47434
MR
42762011-07-14 Martin Rudalics <rudalics@gmx.at>
4277
4278 * indent.c (Fvertical_motion): Set and restore w->pointm when
4279 saving and restoring the window's buffer (Bug#9006).
4280
837c31f8
LMI
42812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4282
4283 * editfns.c (Fstring_to_char): Clarify just what is returned
4284 (bug#6576). Text by Eli Zaretskii.
4285
ac389d0c
JB
42862011-07-13 Juanma Barranquero <lekktu@gmail.com>
4287
4288 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4289
0be0ce47
EZ
42902011-07-13 Eli Zaretskii <eliz@gnu.org>
4291
4292 * buffer.c (mmap_find): Fix a typo.
4293
cd18e7e3
JB
42942011-07-13 Johan Bockgård <bojohan@gnu.org>
4295
4296 Fix execution of x selection hooks.
4297 * xselect.c (Qx_lost_selection_functions)
4298 (Qx_sent_selection_functions): New vars.
4299 (syms_of_xselect): DEFSYM them.
4300 (x_handle_selection_request): Pass Qx_sent_selection_functions
4301 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4302 (x_handle_selection_clear,x_clear_frame_selections):
4303 Pass Qx_lost_selection_functions rather than
4304 Vx_lost_selection_functions to Frun_hook_with_args.
4305
47ea7f44
PE
43062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4307
ac389d0c 4308 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4309 The old code sometimes used this field without initializing it.
4310
47ea7f44
PE
4311 * alloc.c (gc_sweep): Don't read past end of array.
4312 In theory, the old code could also have corrupted Emacs internals,
4313 though it'd be very unlikely.
4314
bc985c87
AS
43152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4316
4317 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4318 argument. (Bug#4026)
bc985c87 4319
0cf34688
LMI
43202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4321
b3dadd76
LMI
4322 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4323 key" (bug#4257).
4324
0cf34688
LMI
4325 * window.c (Fset_window_start): Doc fix (bug#4199).
4326 (Fset_window_hscroll): Ditto.
4327
270768cd
PE
43282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4329
077e3dda 4330 Fix minor new problems caught by GCC 4.6.1.
270768cd 4331 * term.c (init_tty): Remove unused local.
490011a6 4332 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4333 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4334 not used otherwise.
270768cd 4335
b1f58454
CY
43362011-07-12 Chong Yidong <cyd@stupidchicken.com>
4337
4338 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4339
22b9578d
LMI
43402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4341
6e70ab07
LMI
4342 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4343 are the mini-buffer and the echo area (bug#3320).
4344
22b9578d
LMI
4345 * term.c (init_tty): Remove support for supdup, c10 and perq
4346 terminals, which are no longer supported (bug#1482).
4347
8974cc9f
JB
43482011-07-10 Johan Bockgård <bojohan@gnu.org>
4349
4350 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4351
a560d974
JD
43522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4353
4354 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4355 for non-popups (Bug#3642).
4356
1dae0f0a
AS
43572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4358
268c2c36 4359 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4360 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4361 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4362 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4363 * data.c (fmod): Likewise.
4364 * dispnew.c (swap_glyphs_in_rows): Likewise.
4365 * emacs.c (memory_warning_signal): Likewise.
4366 * floatfns.c (float_error): Likewise.
4367 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4368 (otf_open, font_otf_capability, generate_otf_features)
4369 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4370 Likewise.
4371 * image.c (pbm_read_file): Likewise.
4372 * indent.c (string_display_width): Likewise.
4373 * intervals.c (check_for_interval, search_for_interval)
4374 (inc_interval_count, count_intervals, root_interval)
4375 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4376 * lread.c (defalias): Likewise.
268c2c36 4377 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4378 * regex.c (set_image_of_range_1, set_image_of_range)
4379 (regex_grow_registers): Likewise.
4380 * sysdep.c (strerror): Likewise.
4381 * termcap.c (valid_filename_p, tprint, main): Likewise.
4382 * tparam.c (main): Likewise.
4383 * unexhp9k800.c (run_time_remap, save_data_space)
4384 (update_file_ptrs, read_header, write_header, calculate_checksum)
4385 (copy_file, copy_rest, display_header): Likewise.
4386 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4387 Likewise.
4388 * xdisp.c (check_it): Likewise.
4389 * xfaces.c (register_color, unregister_color, unregister_colors):
4390 Likewise.
4391 * xfns.c (print_fontset_result): Likewise.
4392 * xrdb.c (member, fatal, main): Likewise.
4393
99033785
PE
43942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 Fix minor problems found by static checking (Bug#9031).
4397 * chartab.c (char_table_set_range, map_sub_char_table):
4398 Remove unused locals.
4399 (uniprop_table): Now static.
4400 * composite.c (_work_char): Remove unused static var.
4401
9cb2ac56
JB
44022011-07-09 Juanma Barranquero <lekktu@gmail.com>
4403
4404 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4405
f25661f0
JD
44062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4407
4408 * gtkutil.c (qttip_cb): Remove code without function.
4409
8278c4fe
EZ
44102011-07-09 Eli Zaretskii <eliz@gnu.org>
4411
4412 * w32.c (pthread_sigmask): New stub.
4413
1692ae2d 44142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4415
8a6ebd58 4416 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4417 sigprocmask is portable only for single-threaded applications, and
4418 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4419 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4420 (LIBES): Use it.
4421 * callproc.c (Fcall_process):
4422 * process.c (create_process):
4423 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4424 Use pthread_sigmask, not sigprocmask.
123403e4 4425
1b854618
JD
44262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4427
4428 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4429 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4430 wrong (Bug#8591).
4431
3fe4b549
JD
44322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4433
0ce7e563
JD
4434 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4435 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4436 (xg_hide_tooltip): Fix comment.
4437
3fe4b549
JD
4438 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4439 in registerServicesMenuSendTypes.
4440 (validRequestorForSendType): Don't check ns_return_types.
4441
4442 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4443 ns_return_type.
4444
5df75e47
JR
44452011-07-08 Jason Rumney <jasonr@gnu.org>
4446
22610910
JR
4447 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4448 SH_SHOW for hidden windows (Bug#5482).
4449
5df75e47
JR
4450 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4451 frame struct members of non-existent frames (Bug#6284).
4452
699c10bd
JD
44532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4454
4393663b
JD
4455 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4456 variable firstTime not needed on OSX >= 10.6.
4457 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4458 >= 10.5. Use setKnobProportion, setDoubleValue.
4459
4460 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4461 (MAC_OS_X_VERSION_10_5): Define if not defined.
4462 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4463 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4464 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4465
4466 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4467 cString and lossyCString on OSX >= 10.4
4468
58179cce 4469 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4470 sizeToFit on OSX >= 10.2.
4471
4472 * nsimage.m (allocInitFromFile): Don't use deprecated method
4473 bestRepresentationForDevice on OSX >= 10.6.
4474
4475 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4476 to avoid warning.
4477
4478 * emacs.c: Declare unexec_init_emacs_zone.
4479
a63e0781
JD
4480 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4481
699c10bd
JD
4482 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4483
4484 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4485 on svcsMenu (Bug#8842).
4486
4487 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4488 ns_return_types.
4489 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4490
4491 * nsterm.m (QUTF8_STRING): Declare.
4492 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4493 (validRequestorForSendType): Return type is (id).
4494 Change indexOfObjectIdenticalTo to indexOfObject.
4495 Check if we have local selection before returning self (Bug#8842).
4496 (writeSelectionToPasteboard): Put local selection into paste board
4497 if we have a local selection (Bug#8842).
4498 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4499
4500 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4501 (ns_get_local_selection): Declare.
4502
54e10184
LMI
45032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4504
9888ff71
LMI
4505 * keymap.c (describe_map_tree): Don't insert a double newline at
4506 the end of the buffer (bug#1169) and return whether we inserted
4507 something.
4508
54e10184
LMI
4509 * callint.c (Fcall_interactively): Change "reading args" to
4510 "providing args" to try to clarify what it does (bug#1010).
4511
15fa4783
KH
45122011-07-07 Kenichi Handa <handa@m17n.org>
4513
4514 * composite.c (composition_compute_stop_pos): Ignore a static
4515 composition starting before CHARPOS (Bug#8915).
4516
4517 * xdisp.c (handle_composition_prop): Likewise.
4518
a8815b00
EZ
45192011-07-07 Eli Zaretskii <eliz@gnu.org>
4520
4521 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4522 (Bug#9015)
4523
ef7b981d 45242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4525
4526 * character.h (unicode_category_t): New enum type.
4527
4528 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4529 (Qchar_code_property_table): New variable.
4530 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4531 (UNIPROP_COMPRESSED_FORM_P): New macros.
4532 (char_table_ascii): Uncompress the compressed values.
4533 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4534 Uncompress the compressed values.
ac389d0c 4535 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4536 (char_table_ref_and_range): Uncompress the compressed values.
4537 (sub_char_table_set): New arg is_uniprop. Callers changed.
4538 Uncompress the compressed values.
4539 (sub_char_table_set_range): Args changed. Callers changed.
4540 (char_table_set_range): Adjuted for the above change.
4541 (map_sub_char_table): Delete args default_val and parent. Add arg
4542 top. Give decoded values to a Lisp function.
640c8776 4543 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4544 values to a Lisp function. Gcpro more variables.
4545 (uniprop_table_uncompress)
4546 (uniprop_decode_value_run_length): New functions.
4547 (uniprop_decoder, uniprop_decoder_count): New variables.
4548 (uniprop_get_decoder, uniprop_encode_value_character)
4549 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4550 New functions.
4551 (uniprop_encoder, uniprop_encoder_count): New variables.
4552 (uniprop_get_encoder, uniprop_table)
4553 (Funicode_property_table_internal, Fget_unicode_property_internal)
4554 (Fput_unicode_property_internal): New functions.
4555 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4556 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4557 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4558 char-code-property-alist.
4559
640c8776 4560 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4561 Vunicode_category_table.
4562
640c8776 4563 * font.c (font_range): Adjust for the change of
c805dec0
KH
4564 Vunicode_category_table.
4565
76b397fb
DN
45662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4567
4568 * m/iris4d.h: Remove file, move contents ...
4569 * s/irix6-5.h: ... here.
4570
22b4128e
PE
45712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4574 * alloc.c (mark_buffer):
4575 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4576 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4577 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4578 This isn't true in general, and it's particularly not true
4579 if Emacs is configured with --with-wide-int.
4580 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4581 New macros, used in the buffer.c change.
4582
869795d6
JD
45832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4584
4585 * xsettings.c: Use both GConf and GSettings if both are available.
4586 (store_config_changed_event): Add comment.
4587 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4588 (store_tool_bar_style_changed): New functions.
5e617bc2 4589 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4590 (struct xsettings): Move font inside HAVE_XFT.
4591 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4592 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4593 Move inside HAVE_XFT.
640c8776 4594 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4595 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4596 also.
4597 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4598 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4599 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4600 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4601 (parse_settings): Move check for font inside HAVE_XFT.
4602 (read_settings, apply_xft_settings): Add comment.
4603 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4604 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4605 call store_font_name_changed.
4606 (xft_settings_event): Add comment.
4607 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4608 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4609 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4610 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4611 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4612 (xsettings_get_system_font, xsettings_get_system_normal_font):
4613 Add comment.
869795d6 4614
d8ed26bd
PE
46152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4616
4617 Random fixes. E.g., (random) never returned negative values.
4618 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4619 subseconds part to the entropy, as that's a bit more random.
4620 Prefer signed to unsigned, since the signedness doesn't matter and
4621 in general we prefer signed. When given a limit, use a
4622 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4623 latter isn't right if USE_2_TAGS_FOR_INTS.
4624 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4625 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4626
cabf1cac
SM
46272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4628
4629 * textprop.c (text_property_stickiness):
4630 Obey Vtext_property_default_nonsticky.
4631 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4632 * w32fns.c (syms_of_w32fns):
4633 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4634
6e9b2be9
PE
46352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4636
4637 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4638 This is more efficient than Ffile_directory_p and avoids a minor race.
4639
90186c68
LMI
46402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4641
7c301272
LMI
4642 * buffer.c (Foverlay_put): Say what the return value is
4643 (bug#7835).
4644
c4f2d8d4
LMI
4645 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4646 is a directory before asking whether to use the file name
4647 (bug#7564).
ad637907
LMI
4648 (barf_or_query_if_file_exists): Make the "File is a directory"
4649 error be more correct.
c4f2d8d4 4650
90186c68
LMI
4651 * fns.c (Frequire): Remove the mention of the .gz files, since
4652 that's installation-specific, but keep the mention of
4653 `get-load-suffixes'.
4654
da64016e
PE
46552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4656
4657 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4658 Report string overflow if the output is too long.
4659
7d47b580
JB
46602011-07-04 Juanma Barranquero <lekktu@gmail.com>
4661
a555cb87
JB
4662 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4663 (syms_of_gnutls): Remove duplicate DEFSYM for
4664 Qgnutls_bootprop_verify_hostname_error, an error for
4665 Qgnutls_bootprop_verify_error (which is no longer used).
4666
7d47b580
JB
4667 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4668 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4669 Also (re)move comments that are misplaced or no longer relevant.
4670
1e49bfab
LMI
46712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4672
4673 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4674
1485f4c0
CY
46752011-07-03 Chong Yidong <cyd@stupidchicken.com>
4676
4677 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4678 and background color parameters if they have been changed.
4679
a9ab721e
LMI
46802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4681
4682 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4683
cf7cff57
PE
46842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4685
2e13213d
PE
4686 * xsettings.c (SYSTEM_FONT): Define only when used.
4687 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4688
cf7cff57
PE
4689 * keymap.c (access_keymap_1): Now static.
4690
7a8e04f7
CY
46912011-07-02 Chong Yidong <cyd@stupidchicken.com>
4692
4693 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4694 leave any prefix arg for the up event (Bug#1586).
4695
61352f62
LMI
46962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4697
69bb1ef7
LMI
4698 * lread.c (syms_of_lread): Mention single symbols defined by
4699 `defvar' or `defconst' (bug#7154).
4700
61352f62 4701 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4702 (Frequire): Mention get-load-suffixes.
61352f62 4703
28545e04
MR
47042011-07-02 Martin Rudalics <rudalics@gmx.at>
4705
4706 * window.h (window): Remove clone_number slot.
4707 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4708 Remove.
4709 (make_parent_window, make_window, saved_window)
4710 (Fset_window_configuration, save_window_save): Don't deal with
4711 clone numbers.
4712 * buffer.c (Qclone_number): Remove declaration.
4713 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4714
3349e122
SM
47152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4716
4717 Add multiple inheritance to keymaps.
4718 * keymap.c (Fmake_composed_keymap): New function.
4719 (Fset_keymap_parent): Simplify.
4720 (fix_submap_inheritance): Remove.
4721 (access_keymap_1): New function extracted from access_keymap to handle
4722 embedded parents and handle lists of maps.
4723 (access_keymap): Use it.
4724 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4725 (Fcopy_keymap): Handle embedded parents.
4726 (Fcommand_remapping, define_as_prefix): Simplify.
4727 (Fkey_binding): Simplify.
4728 (syms_of_keymap): Move minibuffer-local-completion-map,
4729 minibuffer-local-filename-completion-map,
4730 minibuffer-local-must-match-map, and
4731 minibuffer-local-filename-must-match-map to Elisp.
4732 (syms_of_keymap): Defsubr make-composed-keymap.
4733 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4734 (parse_menu_item): Trivial simplification.
4735
3279eb87
GM
47362011-07-01 Glenn Morris <rgm@gnu.org>
4737
4738 * Makefile.in (SETTINGS_LIBS): Fix typo.
4739
4550efdf
KI
47402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4741
4742 * coding.c (Fencode_coding_string): Record the last coding system
4743 used, as the function doc string says (bug#8738).
4744
0949d2b6
JD
47452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4746
4747 * xsettings.c (store_monospaced_changed): Take new font as arg and
4748 check for change against current_mono_font.
4749 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4750 (emacs_settings_constructor, emacs_settings_get_property)
4751 (emacs_settings_set_property, emacs_settings_class_init)
4752 (emacs_settings_init, gsettings_obj): Remove.
4753 (something_changedCB): New function for HAVE_GSETTINGS.
4754 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4755 with value as argument.
4756 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4757 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4758 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4759 "changed".
4760
4761 * xgselect.c: Add defined (HAVE_GSETTINGS).
4762 (xgselect_initialize): Ditto.
4763
4764 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4765 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4766 xg_select.
4767
bbc6b304
PE
47682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4769
4770 * eval.c (struct backtrace): Simplify and port the data structure.
4771 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4772 signed bit field, as this assumption is not portable and it makes
4773 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4774 "char debug_on_exit : 1" as this is not portable either; instead,
4775 use the portable "unsigned int debug_on_exit : 1". Remove unused
4776 member evalargs. Remove obsolete comments about cc bombing out.
4777
9851bfc5
JD
47782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4779
51bb811f 4780 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4781 Let HAVE_GSETTINGS override HAVE_GCONF.
4782 (store_monospaced_changed): New function.
4783 (EMACS_SETTINGS): A new type derived from GObject to handle
4784 GSettings notifications.
4785 (emacs_settings_constructor, emacs_settings_get_property)
4786 (emacs_settings_set_property, emacs_settings_class_init):
4787 New functions.
4788 (gsettings_client, gsettings_obj): New variables.
4789 (GSETTINGS_SCHEMA): New define.
4790 (something_changedCB): Call store_monospaced_changed.
4791 (init_gsettings): New function.
4792 (xsettings_initialize): Call init_gsettings.
4793 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4794 to NULL.
4795
640c8776 4796 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4797 GCONF_CFLAGS/LIBS.
4798
5386012d
MR
47992011-06-29 Martin Rudalics <rudalics@gmx.at>
4800
4801 * window.c (resize_root_window, grow_mini_window)
4802 (shrink_mini_window): Rename Qresize_root_window to
4803 Qwindow_resize_root_window and Qresize_root_window_vertically to
4804 Qwindow_resize_root_window_vertically.
4805
f13e0b08
PE
48062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4807
4808 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4809
94515237
JB
48102011-06-27 Juanma Barranquero <lekktu@gmail.com>
4811
4812 * makefile.w32-in: Redesign dependencies so they reflect more
4813 clearly which files are directly included by each source file,
4814 and not through other includes.
4815
e43b6e43
MR
48162011-06-27 Martin Rudalics <rudalics@gmx.at>
4817
4818 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4819 (sort_overlays, overlay_strings): When an overlay's clone number
4820 matches the window's clone number process the overlay even if
4821 the overlay's window property doesn't match the current window.
4822
d68443dc
MR
4823 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4824 (Fwindow_hchild): Rename to Fwindow_left_child.
4825 (Fwindow_next): Rename to Fwindow_next_sibling.
4826 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4827 (resize_window_check): Rename to window_resize_check.
4828 (resize_window_apply): Rename to window_resize_apply.
4829 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4830 (Fdelete_other_windows_internal, resize_frame_windows)
4831 (Fsplit_window_internal, Fdelete_window_internal)
4832 (grow_mini_window, shrink_mini_window)
4833 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4834
c7e73be5
JD
48352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4836
4837 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4838 (emacs_fixed_set_min_size): Remove.
4839 (emacs_fixed_new): Take frame as argument.
4840
4841 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4842 (_EmacsFixedPrivate): Remove minwidth/height.
4843 Add struct frame *f.
4844 (emacs_fixed_init): Initialize priv->f.
4845 (get_parent_class, emacs_fixed_set_min_size): Remove.
4846 (emacs_fixed_new): Set priv->f to argument.
4847 (emacs_fixed_get_preferred_width)
4848 (emacs_fixed_get_preferred_height): Use min_width/height from
4849 frames size_hint to set minimum and natural (Bug#8919).
4850 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4851 and use min_width/height from frames size_hint to set
4852 min_width/height (Bug#8919).
4853
4854 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4855 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4856 Fix indentation.
c7e73be5 4857
cf99dcf8
EZ
48582011-06-26 Eli Zaretskii <eliz@gnu.org>
4859
4860 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4861 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4862 called at ZV.
4863
029529ac
CY
48642011-06-26 Chong Yidong <cyd@stupidchicken.com>
4865
4866 * process.c (wait_reading_process_output): Bypass select if
4867 waiting for a cell while ignoring keyboard input, and input is
4868 pending. Suggested by Jan Djärv (Bug#8869).
4869
7a7ef429
PE
48702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 Use gnulib's dup2 module instead of rolling our own.
4873 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4874
11fdef7d 48752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4876
4877 * dispnew.c (scrolling_window): Before scrolling, turn off a
4878 mouse-highlight in the window being scrolled.
4879
cd3520a4
JB
48802011-06-24 Juanma Barranquero <lekktu@gmail.com>
4881
4882 Move DEFSYM to lisp.h and use everywhere.
4883
4884 * character.h (DEFSYM): Move declaration...
4885 * lisp.h (DEFSYM): ...here.
4886
4887 * gnutls.c:
4888 * minibuf.c:
4889 * w32menu.c:
4890 * w32proc.c:
4891 * w32select.c: Don't include character.h.
4892
4893 * alloc.c (syms_of_alloc):
4894 * buffer.c (syms_of_buffer):
4895 * bytecode.c (syms_of_bytecode):
4896 * callint.c (syms_of_callint):
4897 * casefiddle.c (syms_of_casefiddle):
4898 * casetab.c (init_casetab_once):
4899 * category.c (init_category_once, syms_of_category):
4900 * ccl.c (syms_of_ccl):
4901 * cmds.c (syms_of_cmds):
4902 * composite.c (syms_of_composite):
4903 * dbusbind.c (syms_of_dbusbind):
4904 * dired.c (syms_of_dired):
4905 * dispnew.c (syms_of_display):
4906 * doc.c (syms_of_doc):
4907 * editfns.c (syms_of_editfns):
4908 * emacs.c (syms_of_emacs):
4909 * eval.c (syms_of_eval):
4910 * fileio.c (syms_of_fileio):
4911 * fns.c (syms_of_fns):
4912 * frame.c (syms_of_frame):
4913 * fringe.c (syms_of_fringe):
4914 * insdel.c (syms_of_insdel):
4915 * keymap.c (syms_of_keymap):
4916 * lread.c (init_obarray, syms_of_lread):
4917 * macros.c (syms_of_macros):
4918 * msdos.c (syms_of_msdos):
4919 * print.c (syms_of_print):
4920 * process.c (syms_of_process):
4921 * search.c (syms_of_search):
4922 * sound.c (syms_of_sound):
4923 * syntax.c (init_syntax_once, syms_of_syntax):
4924 * terminal.c (syms_of_terminal):
4925 * textprop.c (syms_of_textprop):
4926 * undo.c (syms_of_undo):
4927 * w32.c (globals_of_w32):
4928 * window.c (syms_of_window):
4929 * xdisp.c (syms_of_xdisp):
4930 * xfaces.c (syms_of_xfaces):
4931 * xfns.c (syms_of_xfns):
4932 * xmenu.c (syms_of_xmenu):
4933 * xsettings.c (syms_of_xsettings):
4934 * xterm.c (syms_of_xterm): Use DEFSYM.
4935
4228cf16
TZ
49362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4937
cd3520a4 4938 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4939
7fcccf1e
PE
49402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4941
7efb4e0e
PE
4942 Integer and buffer overflow fixes (Bug#8873).
4943
ff5844ad
PE
4944 * print.c (printchar, strout): Check for string overflow.
4945 (PRINTPREPARE, printchar, strout):
4946 Don't set size unless allocation succeeds.
4947
90532f02
PE
4948 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4949 for sizes. Check for string overflow more accurately.
4950 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4951
6d84508d
PE
4952 * macros.c: Integer and buffer overflow fixes.
4953 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4954 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4955 Use ptrdiff_t, not int, for sizes.
4956 Don't increment bufsize until after realloc succeeds.
4957 Check for size-calculation overflow.
4958 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4959
437b2cb4
PE
4960 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4961
8b9ac8b4
PE
4962 * lread.c: Integer overflow fixes.
4963 (read_integer): Radix is now EMACS_INT, not int,
4964 to improve quality of diagnostics for out-of-range radices.
4965 Calculate buffer size correctly for out-of-range radices.
4966 (read1): Check for integer overflow in radices, and in
4967 read-circle numbers.
82cb60d3
PE
4968 (read_escape): Avoid int overflow.
4969 (Fload, openp, read_buffer_size, read1)
4970 (substitute_object_recurse, read_vector, read_list, map_obarray):
4971 Use ptrdiff_t, not int, for sizes.
4972 (read1): Use EMACS_INT, not int, for sizes.
20270765 4973 Check for size overflow.
8b9ac8b4 4974
7fcccf1e
PE
4975 * image.c (cache_image): Check for size arithmetic overflow.
4976
bfbbd7e7
PE
4977 * lread.c: Integer overflow issues.
4978 (saved_doc_string_size, saved_doc_string_length)
4979 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4980 Now ptrdiff_t, not int.
4981 (read1): Don't assume doc string length fits in int. Check for
4982 out-of-range doc string lengths.
4983 (read_list): Don't assume file position fits in int.
39019e54 4984 (read_escape): Check for hex character overflow.
bfbbd7e7 4985
4e323265
LL
49862011-06-22 Leo Liu <sdl.web@gmail.com>
4987
4988 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4989 Move to minibuffer.el.
4990
85fece3e
PE
49912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4992
20b84ce9 4993 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4994 The following patches are for when GLYPH_DEBUG && !XASSERT.
4995 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4996 * dispnew.c (flush_stdout):
4997 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4998 Mark as externally visible.
4999 * dispnew.c (check_window_matrix_pointers): Now static.
5000 * dispnew.c (window_to_frame_vpos):
5001 * xfns.c (unwind_create_frame):
5002 * xterm.c (x_check_font): Remove unused local.
5003 * scroll.c (CHECK_BOUNDS):
5004 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5005 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5006 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5007 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5008 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5009 Now static.
5010 (debug_method_add): Use va_list and vsprintf rather than relying
5011 on undefined behavior with wrong number of arguments.
5012 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5013 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5014 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5015 since we're not interested in debugging glyphs with old libraries.
5016 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5017 GCC 4.6.0's static checking.
5018
0766b489
PE
50192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5020
31fd4b32
PE
5021 Integer overflow and signedness fixes (Bug#8873).
5022 A few related buffer overrun fixes, too.
5023
b79e8648
PE
5024 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5025
0766b489
PE
5026 * dispextern.h (struct face.stipple):
5027 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5028 (x_bitmap_mask, x_allocate_bitmap_record)
5029 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5030 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5031 (x_create_bitmap_from_xpm_data):
5032 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5033 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5034 (.bitmaps_last):
5035 * xfaces.c (load_pixmap):
5036 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5037 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5038 (.bitmaps_last, struct x_output.icon_bitmap):
5039 Use ptrdiff_t, not int, for bitmap indexes.
5040 (x_allocate_bitmap_record): Check for size overflow.
5041 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5042
b081724f
PE
5043 Use ptrdiff_t, not int, for overlay counts.
5044 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5045 * editfns.c (overlays_around, get_pos_property):
5046 * textprop.c (get_char_property_and_overlay):
5047 * xdisp.c (next_overlay_change, note_mouse_highlight):
5048 * xfaces.c (face_at_buffer_position):
21514da7
PE
5049 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5050 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5051 (Fnext_overlay_change, Fprevious_overlay_change)
5052 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5053 Use ptrdiff_t, not int, for sizes.
21514da7 5054 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5055
3de73e5e
PE
5056 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5057
2606c57b
PE
5058 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5059 (x_session_initialize): Do not assume string length fits in int.
5060
aaafe47a
PE
5061 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5062 This is unlikely, but can occur if DPI is outlandish.
5063
2674ddc8 5064 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5065 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5066
28154962
PE
5067 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5068 * xrdb.c (magic_file_p, search_magic_path):
5069 Omit last arg SUFFIX; it was always 0. All callers changed.
5070 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5071
7de51af5
PE
5072 * xfont.c (xfont_match): Avoid need for strlen.
5073
25ed6cc3
PE
5074 * xfns.c: Don't assume strlen fits in int.
5075 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5076
4eab31dd
PE
5077 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5078 not unsigned long, as we prefer signed integers. All callers changed.
5079 Detect integer overflow in repeat count.
5080 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5081 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5082
171e2a58
PE
5083 * termcap.c: Don't assume sizes fit in int and never overflow.
5084 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5085 (gobble_line): Check for size-calculation overflow.
5086
ad39faca 5087 * minibuf.c (Fread_buffer):
6e5bb2dc 5088 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5089 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5090 Don't assume string length fits in int.
5091
52c61c22 5092 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5093 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5094
b5b8c9e5
PE
5095 * font.c: Don't assume string length fits in int.
5096 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5097 Use ptrdiff_t, not int.
ccd6111c
PE
5098 (font_intern_prop): Don't assume string length fits in int.
5099 Don't assume integer property fits in fixnum.
5100 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5101
882f0d81 5102 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5103 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5104 Reformulate so as not to need the command string.
5105 Invoke gzip -cd rather than gunzip, as it's more portable.
5106 (lock_info_type, lock_file_1, lock_file):
5107 Don't assume pid_t and time_t fit in unsigned long.
5108 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5109 (current_lock_owner): Prefer signed type for sizes.
5110 Use memcpy, not strncpy, where memcpy is what is really wanted.
5111 Don't assume (via atoi) that time_t and pid_t fit in int.
5112 Check for time_t and/or pid_t out of range, e.g., via a network share.
5113 Don't alloca where an auto var works fine.
5114
93f4cf88
PE
5115 * fileio.c: Fix some integer overflow issues.
5116 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5117 Don't assume string length fits in int.
5118 (directory_file_name): Don't assume string length fits in long.
5119 (make_temp_name): Don't assume pid fits in int, or that its print
5120 length is less than 20.
5121
f3e92b69
PE
5122 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5123
1bfdaf10
PE
5124 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5125
35016e9a
PE
5126 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5127
3d1e65a1
PE
5128 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5129 We prefer signed integers, even for size calculations.
5130
0b963a93
PE
5131 * emacs.c: Don't assume string length fits in 'int'.
5132 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5133 (main): Don't invoke strlen when not needed.
5134
573f4b54
PE
5135 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5136 (XD_DEBUG_MESSAGE): Don't waste a byte.
5137
989f33ba
PE
5138 * callproc.c (getenv_internal_1, getenv_internal)
5139 (Fgetenv_internal):
965d34eb
PE
5140 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5141
e4d29b33
PE
5142 * lread.c (invalid_syntax): Omit length argument.
5143 All uses changed. This doesn't fix a bug, but it simplifies the
5144 code away from its former Hollerith-constant appearance, and it's
5145 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5146 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5147
eb49b136
PE
5148 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5149 This didn't break anything, but it didn't help either.
5150 It's confusing to put a bogus integer in a place where the actual
5151 value does not matter.
9f62aeb1 5152 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5153 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5154
15375a22
PE
5155 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5156 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5157 implementation.
b61cc01c
PE
5158 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5159 We prefer signed types, and the value cannot exceed the EMACS_INT
5160 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5161 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5162 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5163 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5164
53b2623d
PE
5165 * indent.c (sane_tab_width): New function.
5166 (current_column, scan_for_column, Findent_to, position_indentation)
5167 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5168 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5169
51cab52b 5170 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5171
f2ed8a70
PE
5172 * lisp.h (lint_assume): New macro.
5173 * composite.c (composition_gstring_put_cache):
5174 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5175
abe80cc6
PE
5176 * editfns.c, insdel.c:
5177 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5178
b02c740e
PE
5179 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5180
ebc96716
PE
5181 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5182
b4e50fa0 5183 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5184 Use much-faster test for byte-length change.
311d5d7c 5185 Don't assume string byte-length fits in 'int'.
a4cf38e4 5186 Check that character arg fits in 'int'.
85461888 5187 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5188
c0c1ee9f
PE
5189 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5190
a498d7f4
PE
5191 * fns.c (concat): Catch string overflow earlier.
5192 Do not rely on integer wraparound.
5193
51cab52b
PE
5194 * dispextern.h (struct it.overlay_strings_charpos)
5195 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5196 * xdisp.c (forward_to_next_line_start)
5197 (back_to_previous_visible_line_start)
5198 (reseat_at_next_visible_line_start, next_element_from_buffer):
5199 Don't arbitrarily truncate the value of 'selective' to int.
5200
76031fad
PE
5201 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5202
5eb55db9
PE
5203 * composite.c: Don't truncate sizes to 'int'.
5204 (composition_gstring_p, composition_reseat_it)
5205 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5206 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5207 not EMACS_UINT, for indexes.
5eb55db9 5208
0703a717
PE
5209 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5210
d6202519
PE
5211 * buffer.c: Include <verify.h>.
5212 (struct sortvec.priority, struct sortstr.priority):
8961a454 5213 Now EMACS_INT, not int.
c20998a7 5214 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5215 (struct sortstr.size, record_overlay_string)
5216 (struct sortstrlist.size, struct sortlist.used):
5217 Don't truncate size to int.
5218 (record_overlay_string): Check for size-calculation overflow.
d6202519 5219 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5220
d5a19415
JM
52212011-06-22 Jim Meyering <meyering@redhat.com>
5222
029529ac 5223 Don't leak an XBM-image-sized buffer
d5a19415
JM
5224 * image.c (xbm_load): Free the image buffer after using it.
5225
a9041e6c
PE
52262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5227
5228 Port to Sun C.
5229 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5230 that Sun C diagnosed.
5231 * fns.c (secure_hash): Fix pointer signedness issue.
5232 * intervals.c (static_offset_intervals): New function.
5233 (offset_intervals): Use it.
5234
7f3f739f
LL
52352011-06-21 Leo Liu <sdl.web@gmail.com>
5236
5237 * deps.mk (fns.o):
5238 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5239 sha512.h.
5240
5241 * fns.c (secure_hash): Rename from crypto_hash_function and change
5242 the first arg to accept symbols.
5b66d427 5243 (Fsecure_hash): New primitive.
7f3f739f
LL
5244 (syms_of_fns): New symbols.
5245
76147d94
DD
52462011-06-20 Deniz Dogan <deniz@dogan.se>
5247
5248 * process.c (Fset_process_buffer): Clarify return value in
5249 docstring.
5250
7d7d0045
CY
52512011-06-18 Chong Yidong <cyd@stupidchicken.com>
5252
5253 * dispnew.c (add_window_display_history): Use BVAR.
5254
5255 * xdisp.c (debug_method_add): Use BVAR.
5256 (check_window_end, dump_glyph_matrix, dump_glyph)
5257 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5258
5259 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5260 Likewise.
5261
5262 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5263 check till after the cache is created in init_frame_faces.
5264
ff2bc410
SM
52652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5266
5267 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5268
28177add
PE
52692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5270
dd3482fe
PE
5271 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5272 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5273 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5274
393d71f3 5275 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5276 * fileio.c (Finsert_file_contents):
5277 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5278 Remove the old (too-loose) buffer overflow checks.
5279 They weren't needed, since make_gap checks for buffer overflow.
5280 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5281 The old code merely checked for Emacs fixnum overflow, and relied
5282 on undefined (wraparound) behavior. The new code avoids undefined
5283 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5284
2e6813b0 5285 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5286 Tune. Don't use wider integers than needed. Don't use alloca.
5287 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5288
599a9e4f
PE
5289 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5290
99561444
PE
5291 * insdel.c, lisp.h (buffer_overflow): New function.
5292 (insert_from_buffer_1, replace_range, replace_range_2):
5293 * insdel.c (make_gap_larger):
5294 * editfns.c (Finsert_char):
5295 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5296
28177add
PE
5297 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5298
e69dafad
PE
52992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5300
4baa020d 5301 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5302
b1c46f02
PE
5303 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5304 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5305
e69dafad
PE
5306 * fileio.c: Don't assume EMACS_INT fits in off_t.
5307 (emacs_lseek): New static function.
5308 (Finsert_file_contents, Fwrite_region): Use it.
5309 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5310
566684ea
PE
5311 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5312
e6966cd6
PE
5313 * fns.c: Don't overflow int when computing a list length.
5314 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5315 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5316 truncation on 64-bit hosts. Check for QUIT every
5317 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5318 faster and is responsive enough.
5319 (Flength): Report an error instead of overflowing an integer.
5320 (Fsafe_length): Return a float if the value is not representable
5321 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5322 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5323 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5324
dd0b0efb
PE
5325 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5326 (header_size, word_size): New constants.
5327 (allocate_vectorlike): Don't check size overflow here.
5328 (allocate_vector): Check it here instead, since this is the only
5329 caller of allocate_vectorlike that could cause overflow.
5330 Check that the new vector's length is representable as a fixnum.
5331
86fe5cfe
PE
5332 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5333 The previous code was bogus. For example, next_almost_prime (32)
5334 returned 39, which is undesirable as it is a multiple of 3; and
5335 next_almost_prime (24) returned 25, which is a multiple of 5 so
5336 why was the code bothering to check for multiples of 7?
5337
80e88859
PE
5338 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5339
4a2f0ad6
PE
5340 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5341
f66c7cf8
PE
5342 Variadic C functions now count arguments with ptrdiff_t.
5343 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5344 Back then I didn't know that the Emacs coding style prefers signed int.
5345 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5346 were being counted with int, which may truncate counts on 64-bit
5347 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5348 * lisp.h (struct Lisp_Subr.function.aMANY)
5349 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5350 Arg counts are now ptrdiff_t, not size_t.
5351 All variadic functions and their callers changed accordingly.
5352 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5353 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5354 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5355 * callint.c (Fcall_interactively): Check arg count for overflow,
5356 to avoid potential buffer overrun. Use signed char, not 'int',
5357 for 'varies' array, so that we needn't bother to check its size
5358 calculation for overflow.
5359 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5360 * eval.c (apply_lambda):
5361 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5362 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5363 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5364
a1759b76
PE
5365 * callint.c (Fcall_interactively): Don't use index var as event count.
5366
d96be9fc
PE
5367 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5368 * mem-limits.h (SIZE): Remove; no longer used.
5369
a690a978 5370 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5371
578c21e6
PE
5372 Remove unnecessary casts.
5373 * xterm.c (x_term_init):
5374 * xfns.c (x_set_border_pixel):
5375 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5376 These aren't needed now that we assume ANSI C.
5377
96f53c6c
PE
5378 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5379 It's more likely to cause problems (due to unsigned overflow)
5380 than to cure them.
5381
83c77d31
PE
5382 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5383
ee2079f1
PE
5384 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5385
6da65536
PE
5386 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5387
7147c4a4
PE
5388 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5389
193e32d9
PE
5390 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5391
e5533da6
PE
5392 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5393
9910e595
PE
5394 GLYPH_CODE_FACE returns EMACS_INT, not int.
5395 * dispextern.h (merge_faces):
5396 * xfaces.c (merge_faces):
01103c44
PE
5397 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5398 Don't assume EMACS_INT fits in int.
9910e595 5399
2638320e
PE
5400 * character.h (CHAR_VALID_P): Remove unused parameter.
5401 * fontset.c, lisp.h, xdisp.c: All uses changed.
5402
045eb8d9
PE
5403 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5404
c1f134b5
PE
5405 * fns.c (concat): Minor tuning based on overflow analysis.
5406 This doesn't fix any bugs. Use int to hold character, instead
5407 of constantly refetching from Emacs object. Use XFASTINT, not
5408 XINT, for value known to be a character. Don't bother comparing
5409 a single byte to 0400, as it's always less.
5410
395fcb93 5411 * floatfns.c (Fexpt):
327eeec8
PE
5412 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5413
abbd3d23
PE
5414 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5415 for characters.
5416
684a03ef
PE
5417 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5418
0fed43f3
PE
5419 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5420 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5421 incorrectly succeed when S was a string, because 4294967386 was
5422 truncated before it was used.
5423
8fd02eb7
PE
5424 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5425 Otherwise, an out-of-range integer could cause undefined behavior
5426 on a 64-bit host.
5427
f8c86b69
PE
5428 * composite.c: Use int, not EMACS_INT, for characters.
5429 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5430 EMACS_INT, for values that are known to be in character range.
5431 This doesn't fix any bugs but is the usual style inside Emacs and
5432 may generate better code on 32-bit machines.
5433
34206dd2
PE
5434 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5435 This is for reasons similar to the recent CHAR_STRING fix.
5436 * charset.c (Fencode_char): Check that character arg is actually
5437 a character. Pass an int to ENCODE_CHAR.
5438 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5439 wider than 'int', as a compile-time check to prevent future regressions
5440 in this area.
5441
c5958d4c 5442 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5443
5444 Make sure a 64-bit char is never passed to CHAR_STRING.
5445 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5446 by silently ignoring the top 32 bits, allowing some values
5447 that were far too large to be valid characters.
5448 * character.h: Include <verify.h>.
5449 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5450 arguments are no wider than unsigned, as a compile-time check
5451 to prevent future regressions in this area.
5452 * data.c (Faset):
01103c44 5453 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5454 (Fsubst_char_in_region):
5455 * fns.c (concat):
5456 * xdisp.c (decode_mode_spec_coding):
5457 Adjust to CHAR_STRING's new requirement.
5458 * editfns.c (Finsert_char, Fsubst_char_in_region):
5459 * fns.c (concat): Check that character args are actually
5460 characters. Without this test, these functions did the wrong
5461 thing with wildly out-of-range values on 64-bit hosts.
5462
d37ca623
PE
5463 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5464 These casts should not be needed on 32-bit hosts, either.
5465 * keyboard.c (read_char):
5466 * lread.c (Fload): Remove casts to unsigned.
5467
ea204efb
PE
5468 * lisp.h (UNSIGNED_CMP): New macro.
5469 This fixes comparison bugs on 64-bit hosts.
5470 (ASCII_CHAR_P): Use it.
5471 * casefiddle.c (casify_object):
01103c44 5472 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5473 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5474 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5475 * dispextern.h (FACE_FROM_ID):
5476 * keyboard.c (read_char): Use UNSIGNED_CMP.
5477
41cb286c
PE
5478 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5479 not to EMACS_INT, to avoid GCC warning.
5480
4a1b9832
PE
5481 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5482
55daad71
PE
5483 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5484 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5485 isn't needed on 32-bit machines.
8f95c75c 5486
01103c44
PE
5487 * buffer.c (Fgenerate_new_buffer_name):
5488 Use EMACS_INT for count, not int.
0ceccced 5489 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5490
5491 * data.c (Qcompiled_function): Now static.
5492
c6f072e7
PE
5493 * window.c (window_body_lines): Now static.
5494
20ce5912
PE
5495 * image.c (gif_load): Rename local to avoid shadowing.
5496
9c4c5f81
PE
5497 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5498 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5499 * alloc.c (make_save_value): Integer argument is now of type
5500 ptrdiff_t, not int.
5501 (mark_object): Use ptrdiff_t, not int.
5502 * lisp.h (pD): New macro.
5503 * print.c (print_object): Use it.
5504
c0c5c8ae
PE
5505 * alloc.c: Use EMACS_INT, not int, to count objects.
5506 (total_conses, total_markers, total_symbols, total_vector_size)
5507 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5508 (total_free_floats, total_floats, total_free_intervals)
5509 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5510 Now EMACS_INT, not int. All uses changed.
5511 (Fgarbage_collect): Compute overall total using a double, so that
5512 integer overflow is less likely to be a problem. Check for overflow
5513 when converting back to an integer.
5a25e253
PE
5514 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5515 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5516 These were 'int' variables that could overflow on 64-bit hosts;
5517 they were never used, so remove them instead of repairing them.
211a0b2a 5518 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5519 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5520 Previously, this ceilinged at INT_MAX, but that doesn't work on
5521 64-bit machines.
e46bb31a 5522 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5523
c78baabf 5524 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5525 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5526 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5527 when a (possibly-narrower) signed value would do just as well.
5528 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5529
c9d624c6
PE
5530 * alloc.c: Catch some string size overflows that we were missing.
5531 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5532 for convenience in STRING_BYTES_MAX.
5533 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5534 The definition here is exact; the one in lisp.h was approximate.
5535 (allocate_string_data): Check for string overflow. This catches
5536 some instances we weren't catching before. Also, it catches
5537 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5538 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5539 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5540
c9d624c6
PE
5541 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5542 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5543 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5544
353032ce
PE
5545 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5546
2bccce07
PE
5547 * alloc.c (Fmake_string): Check for out-of-range init.
5548
0ac30604
SM
55492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5550
5551 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5552
c195f2de
JD
55532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5554
5555 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5556 xg_get_default_scrollbar_width.
5557
5558 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5559 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5560 (style_changed_cb): Call update_theme_scrollbar_width and call
5561 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5562 all frames (Bug#8505).
5563 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5564 Call gtk_window_set_resizable if HAVE_GTK3.
5565 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5566 and height if HAVE_GTK3 (Bug#8505).
5567 (scroll_bar_width_for_theme): New variable.
5568 (update_theme_scrollbar_width): New function.
5569 (xg_get_default_scrollbar_width): Move code to
5570 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5571 (xg_initialize): Call update_theme_scrollbar_width.
5572
5573 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5574
5575 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5576
e10ac9f1
MR
55772011-06-12 Martin Rudalics <rudalics@gmx.at>
5578
5579 * frame.c (make_frame): Call other_buffer_safely instead of
5580 other_buffer.
5581
5582 * window.c (temp_output_buffer_show): Call display_buffer with
5583 second argument Vtemp_buffer_show_specifiers and reset latter
5584 immediately after the call.
5585 (Vtemp_buffer_show_specifiers): New variable.
5586 (auto_window_vscroll_p, next_screen_context_lines)
5587 (Vscroll_preserve_screen_position): Remove leading asterisks from
5588 doc-strings.
5589
2d3c217e 55902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5591
7b7f97e8 5592 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5593 * buffer.c (Qclone_number): Remove for now, as it's unused.
5594 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5595 (record_buffer): Remove unused local.
5596 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5597 (set_frame_buffer_list): Remove; unused.
5598 * frame.h (other_visible_frames): Remove decl.
5599 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5600 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5601 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5602 if HAVE_GPM.
5603 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5604 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5605 Define only if HAVE_GPM.
5606 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5607 (update_hints_inhibit): Remove; never set. All uses removed.
5608 * widgetprv.h (emacsFrameClassRec): Remove decl.
5609 * window.c (delete_deletable_window): Now returns void, since it
5610 wasn't returning anything.
5611 (compare_window_configurations): Remove unused locals.
5612 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5613 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5614 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5615 the same widths as pointers. This follows up on the 2011-05-06 patch.
5616 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5617 * xterm.h: Likewise.
5618 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5619
1384b89e
JB
56202011-06-12 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * makefile.w32-in: Update dependencies.
5623 (LISP_H): Add lib/intprops.h.
5624
1100a63c
CY
56252011-06-11 Chong Yidong <cyd@stupidchicken.com>
5626
5627 * image.c (gif_load): Add animation frame delay to the metadata.
5628 (syms_of_image): Use DEFSYM. New symbol `delay'.
5629
6198ccd0
MR
56302011-06-11 Martin Rudalics <rudalics@gmx.at>
5631
5632 * window.c (delete_deletable_window): Re-add.
5633 (Fset_window_configuration): Rewrite to handle dead buffers and
5634 consequently deletable windows.
5635 (window_tree, Fwindow_tree): Remove. Supply functionality in
5636 window.el.
5637 (compare_window_configurations): Simplify code.
5638
b6e3633c
AS
56392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5640
1ab0dee5
AS
5641 * image.c (imagemagick_load_image): Fix type mismatch.
5642 (Fimagemagick_types): Likewise.
5643
b6e3633c
AS
5644 * window.h (replace_buffer_in_windows): Declare.
5645
9397e56f
MR
56462011-06-11 Martin Rudalics <rudalics@gmx.at>
5647
5648 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5649 Qclone_number. Remove external declaration of Qdelete_window.
5650 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5651 code.
640c8776
SM
5652 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5653 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5654 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5655 buffer list implementation.
5656 (other_buffer_safely): New function.
5657 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5658 calls to replace_buffer_in_windows and
5659 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5660 if allowed.
5661 (record_buffer): Inhibit quitting and rewrite using quittable
5662 functions. Run Qbuffer_list_update_hook if allowed.
5663 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5664 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5665 Move switch-to-buffer to window.el.
9397e56f
MR
5666 (bury-buffer): Move to window.el.
5667 (Vbuffer_list_update_hook): New variable.
5668
5669 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5670 section.
5671
5672 * window.h (resize_frame_windows): Move up in code.
5673 (Fwindow_frame): Remove EXFUN.
5674 (replace_buffer_in_all_windows): Remove prototype.
5675 (replace_buffer_in_windows_safely): Add prototype.
5676
5677 * window.c: Declare Qdelete_window static again. Move down
5678 declaration of select_count.
5679 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5680 (Fother_window): Move to window.el.
5681 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5682 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5683 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5684 window.el.
5685 (replace_buffer_in_windows): Implement by calling
5686 Qreplace_buffer_in_windows.
5687 (replace_buffer_in_all_windows): Remove with some functionality
5688 moved into replace_buffer_in_windows_safely.
5689 (replace_buffer_in_windows_safely): New function.
5690 (select_window_norecord, select_frame_norecord): Move in front
5691 of run_window_configuration_change_hook. Remove now obsolete
5692 declarations.
640c8776
SM
5693 (Fset_window_buffer): Rewrite doc-string.
5694 Call Qrecord_window_buffer.
9397e56f
MR
5695 (keys_of_window): Move binding for other-window to window.el.
5696
b50691aa
CY
56972011-06-11 Chong Yidong <cyd@stupidchicken.com>
5698
5699 * dispextern.h (struct image): Replace data member, whose int_val
5700 and ptr_val fields were not used by anything, with a single
5701 lisp_val object.
5702
5703 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5704 (gif_clear_image, gif_load, imagemagick_load_image)
5705 (gs_clear_image, gs_load): Callers changed.
5706
3f754b86
PE
57072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5708
cca69397
PE
5709 * buffer.h: Include <time.h>, for time_t.
5710 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5711
109e28d0
PE
5712 Fix minor problems found by static checking.
5713
60737f02
PE
5714 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5715
4b66faf3
PE
5716 Make identifiers static if they are not used in other modules.
5717 * data.c (Qcompiled_function, Qframe, Qvector):
5718 * image.c (QimageMagick, Qsvg):
5719 * minibuf.c (Qmetadata):
5720 * window.c (resize_window_check, resize_root_window): Now static.
5721 * window.h (resize_window_check, resize_root_window): Remove decls.
5722
109e28d0
PE
5723 * window.c (window_deletion_count, delete_deletable_window):
5724 Remove; unused.
46a4ce9e
PE
5725 (window_body_lines): Now static.
5726 (Fdelete_other_windows_internal): Mark vars as initialized.
5727 Make sure 'resize_failed' is initialized.
5728 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5729 (resize_window_apply): Remove unused local.
5730 * window.h (delete_deletable_window): Remove decl.
5731
109e28d0 5732 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5733 (imagemagick_load_image): Fix pointer signedness problem by changing
5734 last arg from unsigned char * to char *. All uses changed.
5735 Also, fix a local for similar reasons.
5736 Remove unused locals. Remove locals to avoid shadowing.
5737 (fn_rsvg_handle_free): Remove; unused.
5738 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5739 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5740
3f754b86
PE
5741 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5742
2547adb1
CY
57432011-06-10 Chong Yidong <cyd@stupidchicken.com>
5744
5745 * image.c (gif_load): Fix omitted cast error introduced by
5746 2011-06-06 change.
5747
2c8e37d4
MR
57482011-06-10 Martin Rudalics <rudalics@gmx.at>
5749
5750 * window.h (resize_proportionally, orig_total_lines)
5751 (orig_top_line): Remove from window structure.
5752 (set_window_height, set_window_width, change_window_heights)
5753 (Fdelete_window): Remove prototypes.
5754 (resize_frame_windows): Remove duplicate declaration.
5755
440a42e3
EZ
57562011-06-10 Eli Zaretskii <eliz@gnu.org>
5757
5758 * window.h (resize_frame_windows, resize_window_check)
5759 (delete_deletable_window, resize_root_window)
5760 (resize_frame_windows): Declare prototypes.
5761
5762 * window.c (resize_window_apply): Make definition be "static" to
5763 match the prototype.
5764
562dd5e9
MR
57652011-06-10 Martin Rudalics <rudalics@gmx.at>
5766
5767 * window.c: Remove declarations of Qwindow_size_fixed,
5768 window_min_size_1, window_min_size_2, window_min_size,
5769 size_window, window_fixed_size_p, enlarge_window, delete_window.
5770 Remove static from declaration of Qdelete_window, it's
5771 temporarily needed by Fbury_buffer.
5772 (replace_window): Don't assign orig_top_line and
5773 orig_total_lines.
5774 (Fdelete_window, delete_window): Remove. Window deletion is
5775 handled by window.el.
640c8776
SM
5776 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5777 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5778 (Fdelete_other_windows): Remove. Deleting other windows is
5779 handled by window.el.
5780 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5781 handled in window.el.
5782 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5783 Window minimum sizes are handled in window.el.
5784 (shrink_windows, size_window, set_window_height)
5785 (set_window_width, change_window_heights, window_height)
5786 (window_width, CURBEG, CURSIZE, enlarge_window)
5787 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5788 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5789 handled in window.el.
5790 (make_dummy_parent): Rename to make_parent_window and give it a
5791 second argument horflag.
5792 (make_window): Don't set resize_proportionally any more.
5793 (Fsplit_window): Remove. Windows are split in window.el.
5794 (save_restore_action, save_restore_orig_size)
5795 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5796 Resize mini windows in window.el.
5797 (grow_mini_window, shrink_mini_window): Implement by calling
5798 Qresize_root_window_vertically, resize_window_check and
5799 resize_window_apply.
640c8776
SM
5800 (saved_window, Fset_window_configuration, save_window_save):
5801 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5802 resize_proportionally.
5803 (window_min_height, window_min_width): Move to window.el.
5804 (keys_of_window): Move bindings for delete-other-windows,
5805 split-window, delete-window and enlarge-window to window.el.
5806
5807 * buffer.c: Temporarily extern Qdelete_window.
5808 (Fbury_buffer): Temporarily call Qdelete_window instead of
5809 Fdelete_window (Fbury_buffer will move to window.el soon).
5810
5811 * frame.c (set_menu_bar_lines_1): Remove code handling
5812 orig_top_line and orig_total_lines.
5813
5814 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5815 set_window_height but set heights directly.
5816 (change_frame_size_1): Use resize_frame_windows.
5817
5818 * xdisp.c (init_xdisp): Don't use set_window_height but set
5819 heights directly.
5820
640c8776
SM
5821 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5822 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5823 run_window_configuration_change_hook.
5824
5825 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5826 instead of change_window_heights and run
5827 run_window_configuration_change_hook.
5828
1a13852e
MR
58292011-06-09 Martin Rudalics <rudalics@gmx.at>
5830
5831 * window.c (replace_window): Rename second argument REPLACEMENT to
5832 NEW. New third argument SETFLAG. Rewrite.
5833 (delete_window, make_dummy_parent): Call replace_window with
5834 third argument 1.
5835 (window_list_1): Move down in code.
5836 (run_window_configuration_change_hook): Move set_buffer part
5837 before select_frame_norecord part in order to unwind correctly.
5838 Rename count1 to count.
5839 (recombine_windows, delete_deletable_window, resize_root_window)
5840 (Fdelete_other_windows_internal)
5841 (Frun_window_configuration_change_hook, make_parent_window)
5842 (resize_window_check, resize_window_apply, Fresize_window_apply)
5843 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5844 (Fdelete_window_internal, Fresize_mini_window_internal):
5845 New functions.
1a13852e
MR
5846 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5847
f3d1777e
MR
58482011-06-08 Martin Rudalics <rudalics@gmx.at>
5849
496e208e
MR
5850 * window.h (window): Add some new members to window structure -
5851 normal_lines, normal_cols, new_total, new_normal, clone_number,
5852 splits, nest, prev_buffers, next_buffers.
5853 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5854 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5855
f3d1777e
MR
5856 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5857 Remove.
496e208e
MR
5858 (make_dummy_parent): Set new members of windows structure.
5859 (make_window): Move down in code. Handle new members of window
5860 structure.
5861 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5862 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5863 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5864 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5865 (Fset_window_next_buffers, Fset_window_clone_number):
5866 New functions.
496e208e
MR
5867 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5868 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5869 Doc-string fixes.
5870 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5871 Argument WINDOW can be now internal window too.
5872 (Fwindow_use_time): Move up in code.
5873 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5874 Rewrite doc-string.
5875 (Fset_window_configuration, saved_window)
5876 (Fcurrent_window_configuration, save_window_save): Handle new
5877 members of window structure.
b9e809c2
MR
5878 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5879 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5880 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5881 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5882 Qget_mru_window, Qresize_root_window,
5883 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5884 Qauto_buffer_name; staticpro them.
f3d1777e 5885
abde8f8c
MR
58862011-06-07 Martin Rudalics <rudalics@gmx.at>
5887
5888 * window.c (Fwindow_total_size, Fwindow_left_column)
5889 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5890 (Fwindow_list_1): New functions.
5891 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5892 (Fwindow_width, Fscroll_left, Fscroll_right):
5893 Use window_body_cols instead of window_box_text_cols.
5894 (delete_window, Fset_window_configuration):
5895 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5896 (delete_all_subwindows): Take a window as argument and not a
5897 structure. Rewrite.
190b47e6
MR
5898 (window_loop): Remove handling of GET_LRU_WINDOW and
5899 GET_LARGEST_WINDOW.
5900 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5901
5902 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5903 window_box_text_cols. delete_all_subwindows now takes a
5904 Lisp_Object as argument.
abde8f8c 5905
640c8776
SM
5906 * indent.c (compute_motion, Fcompute_motion):
5907 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5908
fa8a67e6
MR
5909 * frame.c (delete_frame): Call delete_all_subwindows with root
5910 window as argument.
5911
a54e3482
DC
59122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5913
5914 * fns.c (Fputhash): Document return value.
5915
60002bf5
CY
59162011-06-06 Chong Yidong <cyd@stupidchicken.com>
5917
5918 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5919
0c671da6 59202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5921
b862a52a 5922 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5923
be44ca6c
PE
5924 Check for overflow when converting integer to cons and back.
5925 * charset.c (Fdefine_charset_internal, Fdecode_char):
5926 Use cons_to_unsigned to catch overflow.
5927 (Fencode_char): Use INTEGER_TO_CONS.
5928 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5929 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5930 * data.c (long_to_cons, cons_to_long): Remove.
5931 (cons_to_unsigned, cons_to_signed): New functions.
5932 These signal an error for invalid or out-of-range values.
5933 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5934 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5935 * font.c (Ffont_variation_glyphs):
5936 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5937 * lisp.h: Include <intprops.h>.
5938 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5939 (cons_to_signed, cons_to_unsigned): New decls.
5940 (long_to_cons, cons_to_long): Remove decls.
5941 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5942 (Fprimitive_undo): Use CONS_TO_INTEGER.
5943 * xfns.c (Fx_window_property): Likewise.
5944 * xselect.c: Include <limits.h>.
5945 (x_own_selection, selection_data_to_lisp_data):
5946 Use INTEGER_TO_CONS.
5947 (x_handle_selection_request, x_handle_selection_clear)
5948 (x_get_foreign_selection, Fx_disown_selection_internal)
5949 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5950 (lisp_data_to_selection_data): Use cons_to_unsigned.
5951 (x_fill_property_data): Use cons_to_signed.
5952 Report values out of range.
5953
d1f3d2af
PE
5954 Check for buffer and string overflow more precisely.
5955 * buffer.h (BUF_BYTES_MAX): New macro.
5956 * lisp.h (STRING_BYTES_MAX): New macro.
5957 * alloc.c (Fmake_string):
5958 * character.c (string_escape_byte8):
5959 * coding.c (coding_alloc_by_realloc):
5960 * doprnt.c (doprnt):
5961 * editfns.c (Fformat):
5962 * eval.c (verror):
5963 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5964 since they may not be the same number.
5965 * editfns.c (Finsert_char):
5966 * fileio.c (Finsert_file_contents):
5967 Likewise for BUF_BYTES_MAX.
5968
dd52fcea
PE
5969 * image.c: Use ptrdiff_t, not int, for sizes.
5970 (slurp_file): Switch from int to ptrdiff_t.
5971 All uses changed.
5972 (slurp_file): Check that file size fits in both size_t (for
5973 malloc) and ptrdiff_t (for sanity and safety).
5974
7f9bbdbb
PE
5975 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5976 if b->modtime has its maximal value.
5977
dfe18f82
PE
5978 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5979
84acfcf0
PE
5980 Don't assume time_t can fit into int.
5981 * buffer.h (struct buffer.modtime): Now time_t, not int.
5982 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5983 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5984
ccd9a01a
PE
5985 Minor fixes for signed vs unsigned integers.
5986 * character.h (MAYBE_UNIFY_CHAR):
5987 * charset.c (maybe_unify_char):
5988 * keyboard.c (read_char, reorder_modifiers):
5989 XINT -> XFASTINT, since the integer must be nonnegative.
5990 * ftfont.c (ftfont_spec_pattern):
5991 * keymap.c (access_keymap, silly_event_symbol_error):
5992 XUINT -> XFASTINT, since the integer must be nonnegative.
5993 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5994 since it makes no difference and we prefer signed.
5995 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5996 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5997 nonnegative.
5998
d6d100dd
SM
59992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6000
6001 * window.h (Fwindow_frame): Declare.
6002
2b6148e4
PE
60032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6004
6005 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6006 (SPARE_MEMORY): Always define.
6007 (LARGE_REQUEST): Remove.
6008 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6009
f230ecc9
MR
60102011-06-06 Martin Rudalics <rudalics@gmx.at>
6011
727e958e
MR
6012 * lisp.h: Move EXFUNS for Fframe_root_window,
6013 Fframe_first_window and Fset_frame_selected_window to window.h.
6014
6015 * window.h: Move EXFUNS for Fframe_root_window,
6016 Fframe_first_window and Fset_frame_selected_window here from
6017 lisp.h.
6018
6019 * frame.c (Fwindow_frame, Fframe_first_window)
6020 (Fframe_root_window, Fframe_selected_window)
6021 (Fset_frame_selected_window): Move to window.c.
6022 (Factive_minibuffer_window): Move to minibuf.c.
6023 (Fother_visible_frames_p): New function.
6024
6025 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6026
f230ecc9
MR
6027 * window.c (decode_window, decode_any_window): Move up in code.
6028 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6029 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6030 (Fwindow_buffer): Move up and rewrite doc-string.
6031 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6032 (Fwindow_prev): New functions.
727e958e
MR
6033 (Fwindow_frame): Move here from frame.c. Accept any window as
6034 argument.
6035 (Fframe_root_window, Fframe_first_window)
6036 (Fframe_selected_window): Move here from frame.c. Accept frame
6037 or arbitrary window as argument. Update doc-strings.
6038 (Fminibuffer_window): Move up in code.
6039 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6040 (Fset_frame_selected_window): Move here from frame.c.
6041 Marginal rewrite.
727e958e
MR
6042 (Fselected_window, select_window, Fselect_window): Move up in
6043 code. Minor doc-string fixes.
f230ecc9 6044
4d09bcf6
PE
60452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6046
6047 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6048 Do not assume that spare memory exists; that assumption is valid
6049 only if SYSTEM_MALLOC.
6050 (LARGE_REQUEST): New macro, so that the issue of large requests
6051 is separated from the issue of spare memory.
6052
810928a2
AS
60532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6054
172418ad
AS
6055 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6056 format. (Bug#8806)
6057
43f862f7
AS
6058 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6059
810928a2
AS
6060 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6061 before statements.
6062
a059fe24
JD
60632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6064
6065 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6066
6067 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6068
6069 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6070 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6071
989bf368
JB
60722011-06-05 Juanma Barranquero <lekktu@gmail.com>
6073
6074 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6075
4b80f674
CY
60762011-06-04 Chong Yidong <cyd@stupidchicken.com>
6077
6078 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6079 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6080 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6081 New error handlers.
4b80f674
CY
6082 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6083 Obey Vx_select_enable_clipboard_manager. Catch errors in
6084 x_clipboard_manager_save (Bug#8779).
6085 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6086 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6087
99a33b77 60882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6089
6090 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6091
99a33b77 60922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6093
6094 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6095 in the current matrix if keep_current_p is non-zero.
6096
8264569d
EZ
60972011-06-04 Eli Zaretskii <eliz@gnu.org>
6098
6099 * bidi.c (bidi_level_of_next_char): Fix last change.
6100
57f97249
EZ
61012011-06-03 Eli Zaretskii <eliz@gnu.org>
6102
fec2107c 6103 Support bidi reordering of text covered by display properties.
57f97249 6104
fec2107c
EZ
6105 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6106 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6107 (bidi_cache_search, bidi_cache_iterator_state)
6108 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6109 (bidi_level_of_next_char, bidi_move_to_visually_next):
6110 Support character positions inside a run of characters covered by a
fec2107c
EZ
6111 display string.
6112 (bidi_paragraph_init, bidi_resolve_explicit_1)
6113 (bidi_level_of_next_char): Call bidi_fetch_char and
6114 bidi_fetch_char_advance instead of FETCH_CHAR and
6115 FETCH_CHAR_ADVANCE.
6116 (bidi_init_it): Initialize new members.
6117 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6118 definitions.
6119 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6120 instead of using explicit *_CHAR codes.
d6d100dd
SM
6121 (bidi_resolve_explicit, bidi_resolve_weak):
6122 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6123 bidirectional text is supported only in multibyte buffers.
6124 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6125 it to initialize the frame_window_p member of struct bidi_it.
6126 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6127 (bidi_resolve_explicit, bidi_resolve_weak)
6128 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6129 bidi_it->nchars is non-positive.
6130 (bidi_level_of_next_char): Don't try to lookup the cache for the
6131 next/previous character if nothing is cached there yet, or if we
6132 were just reseat()'ed to a new position.
c40e2fb2 6133
0e14fe90
EZ
6134 * xdisp.c (set_cursor_from_row): Set start and stop points
6135 according to the row's direction when priming the loop that looks
6136 for the glyph on which to display cursor.
6137 (single_display_spec_intangible_p): Function deleted.
6138 (display_prop_intangible_p): Reimplement to call
6139 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6140 Accept 3 additional arguments needed by handle_display_spec.
6141 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6142 values: lists, `(when COND...)' forms, etc.
6143 (single_display_spec_string_p): Support property values that are
6144 lists with the argument STRING its top-level element.
6145 (display_prop_string_p): Fix the condition for processing a
6146 property that is a list to be consistent with handle_display_spec.
fec2107c 6147 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6148 last portion of handle_display_prop.
6149 (compute_display_string_pos): Accept additional argument
6150 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6151 value of a `display' property is a "replacing spec".
6152 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6153 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6154 the display property, but just return a value indicating whether
6155 the display property will replace the characters it covers.
6156 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6157 frame_window_p members of struct bidi_it.
d6d100dd
SM
6158 (compute_display_string_pos, compute_display_string_end):
6159 New functions.
fec2107c
EZ
6160 (push_it): Accept second argument POSITION, where pop_it should
6161 jump to continue iteration.
6162 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6163
fec2107c
EZ
6164 * keyboard.c (adjust_point_for_property): Adjust the call to
6165 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6166
6167 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6168 (bidi_init_it): Update prototypes.
6169 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6170 (compute_display_string_pos, compute_display_string_end):
6171 Declare prototypes.
fec2107c
EZ
6172 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6173 EMACS_INT.
fc6f18ce 6174
40087514 61752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6176
57f53182
PE
6177 Malloc failure behavior now depends on size of allocation.
6178 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6179 * lisp.h: Change signatures accordingly.
6180 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6181 All callers changed. (Bug#8762)
6182
6183 * gnutls.c: Use Emacs's memory allocators.
6184 Without this change, the gnutls library would invoke malloc etc.
6185 directly, which causes problems on non-SYNC_INPUT hosts, and which
6186 runs afoul of improving memory_full behavior. (Bug#8761)
6187 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6188 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6189 xfree instead of the default malloc, realloc, free.
6190 (Fgnutls_boot): No need to check for memory allocation failure,
6191 since xmalloc does that for us.
6192
ac32cd99 6193 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6194 * category.c (hash_get_category_set):
6195 * ccl.c (ccl_driver):
6196 * charset.c (Fdefine_charset_internal):
6197 * charset.h (struct charset.hash_index):
6198 * composite.c (get_composition_id, gstring_lookup_cache)
6199 (composition_gstring_put_cache):
6200 * composite.h (struct composition.hash_index):
6201 * dispextern.h (struct image.hash):
6202 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6203 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6204 (hashfn_equal, hashfn_user_defined, make_hash_table)
6205 (maybe_resize_hash_table, hash_lookup, hash_put)
6206 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6207 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6208 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6209 * image.c (make_image, search_image_cache, lookup_image)
6210 (xpm_put_color_table_h):
6211 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6212 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6213 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6214 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6215 * alloc.c (allocate_vectorlike):
6216 Check for overflow in vector size calculations.
6217 * ccl.c (ccl_driver):
6218 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6219 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6220 need to be updated by these changes.
40087514
PE
6221 * fns.c (make_hash_table, maybe_resize_hash_table):
6222 Check for integer overflow with large hash tables.
0de4bb68
PE
6223 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6224 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6225 (SXHASH_REDUCE): New macro.
6226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6227 Use it instead of discarding useful hash info with large hash values.
6228 (sxhash_float): New function.
6229 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6230 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6231 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6232 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6233 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6234 Adjust signatures to match updated version of code.
6235 (consing_since_gc): Now EMACS_INT, since a single hash table can
6236 use more than INT_MAX bytes.
6237
698d32e2
DN
62382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6239
6240 Make it possible to build with GCC-4.6+ -O2 -flto.
6241
6242 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6243
fd6fa53f
SM
62442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6245
6246 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6247 Call minibuffer-inactive-mode.
6248
864db017
JB
62492011-05-31 Juanma Barranquero <lekktu@gmail.com>
6250
6251 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6252 Update dependencies.
6253
2ad0baf4
DN
62542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6255
6256 * data.c (init_data): Remove code for UTS, this system is not
6257 supported anymore.
6258
4fcc2638
DN
62592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6260
6261 Don't force ./temacs to start in terminal mode.
6262
6263 * frame.c (make_initial_frame): Initialize faces in all cases, not
6264 only when CANNOT_DUMP is defined.
6265 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6266
c56e0fd5
DN
62672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6268
6269 * dispnew.c (add_window_display_history): Use const for the string
6270 pointer. Remove declaration, not needed.
6271
333d54da 62722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6273
55d4c1b2 6274 Use 'inline', not 'INLINE'.
333d54da 6275 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6276 * alloc.c, fontset.c (INLINE): Remove.
6277 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6278 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6279 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6280 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6281 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6282
738db178
DN
62832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6284
6285 Make it possible to run ./temacs.
6286
6287 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6288 syms_of_callproc does the same thing. Remove test for
6289 "initialized", do it in the caller.
6290 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6291
620c53a6
SM
62922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6293
6294 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6295 (read_minibuf): Use get_minibuffer.
6296 (syms_of_minibuf): Use DEFSYM.
6297 (Qmetadata): New var.
6298 * data.c (Qbuffer): Don't make it static.
6299 (syms_of_data): Use DEFSYM.
6300
e003a292
PE
63012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6302
6303 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6304 (CCL_CODE_MIN): New macro.
6305
ed008a6d
PE
63062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6307
3687c2ef
PE
6308 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6309
ed008a6d
PE
6310 * eval.c (Qdebug): Now static.
6311 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6312 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6313 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6314
d66c4c7c
CY
63152011-05-29 Chong Yidong <cyd@stupidchicken.com>
6316
6317 * image.c: Various fixes to ImageMagick code comments.
6318 (Fimagemagick_types): Doc fix.
6319
5fbc2025
PE
63202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6321
0196f88a
PE
6322 Minor fixes prompted by GCC 4.6.0 warnings.
6323
6324 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6325
5fbc2025
PE
6326 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6327 (x_clipboard_manager_save_all): Move extern decl to ...
6328 * xterm.h: ... here, so that it can be checked for consistency.
6329
1dd3c2d9
CY
63302011-05-29 Chong Yidong <cyd@stupidchicken.com>
6331
6332 * xselect.c (x_clipboard_manager_save_frame)
6333 (x_clipboard_manager_save_all): New functions.
6334 (Fx_clipboard_manager_save): Lisp function deleted.
6335
6336 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6337 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6338
6339 * xterm.h: Update prototype.
6340
5ba6571d
WX
63412011-05-28 William Xu <william.xwl@gmail.com>
6342
6343 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6344 exiting (Bug#8239).
6345
3eaff834
JM
63462011-05-28 Jim Meyering <meyering@redhat.com>
6347
e1900994 6348 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6349 * fns.c (to_uchar): Define.
6350 (crypto_hash_function): Use it to convert some newly-signed
6351 variables to unsigned, to avoid sign-extension bugs. For example,
6352 without this change, (md5 "truc") would evaluate to
6353 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6354 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6355 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6356
0f6990a7
PE
63572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6358
6359 Integer overflow fixes.
c8a9ca5a 6360
08686060
PE
6361 * dbusbind.c: Serial number integer overflow fixes.
6362 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6363 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6364 to hold a serial number that is too large for a fixnum.
6365 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6366 Check for serial numbers out of range. Decode any serial number
59568bf0 6367 that was so large that it became a float. (Bug#8722)
08686060 6368
2d1fc3c7
PE
6369 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6370 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6371 Use XFASTINT rather than XUINT when numbers are nonnegative.
6372 (xd_append_arg, Fdbus_method_return_internal):
6373 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6374 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6375 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6376 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6377 (Bug#8722)
2d1fc3c7 6378
c8a9ca5a
PE
6379 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6380
519e1d69
PE
6381 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6382
6df6ae42 6383 ccl: Add integer overflow checks.
30569699
PE
6384 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6385 (IN_INT_RANGE): New macros.
6386 (ccl_driver): Use them to check for integer overflow when
6387 decoding a CCL program. Many of the new checks are whether XINT (x)
6388 fits in int; it doesn't always, on 64-bit hosts. The new version
6389 doesn't catch all possible integer overflows, but it's an
847044ea 6390 improvement. (Bug#8719)
30569699 6391
c11285dc
PE
6392 * alloc.c (make_event_array): Use XINT, not XUINT.
6393 There's no need for unsigned here.
6394
fdccd48e
PE
6395 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6396 This follows up to the 2011-05-06 change that substituted uintptr_t
6397 for EMACS_INT. This case wasn't caught back then.
6398
37910ab2
PE
6399 Rework Fformat to avoid integer overflow issues.
6400 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6401 now (part of C89). Include <verify.h>.
6402 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6403 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6404 (Fformat): Avoid the prepass trying to compute sizes; it was only
6405 approximate and thus did not catch overflow reliably. Instead, walk
6406 through the format just once, formatting and computing sizes as we go,
6407 checking for integer overflow at every step, and allocating a larger
6408 buffer as needed. Keep track separately whether the format is
6409 multibyte. Keep only the most-recently calculated precision, rather
6410 than them all. Record whether each argument has been converted to
6411 string. Use EMACS_INT, not int, for byte and char and arg counts.
6412 Support field widths and precisions larger than INT_MAX. Avoid
6413 sprintf's undefined behavior with conversion specifications such as %#d
6414 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6415 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6416 formatting out-of-range floating point numbers with int
9173deec 6417 formats. (Bug#8668)
37910ab2 6418
2e6578fb
PE
6419 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6420
0ae6bdee
PE
6421 * data.c: Avoid integer truncation in expressions involving floats.
6422 * data.c: Include <intprops.h>.
6423 (arith_driver): When there's an integer overflow in an expression
6424 involving floating point, convert the integers to floating point
6425 so that the resulting value does not suffer from catastrophic
6426 integer truncation. For example, on a 64-bit host (* 4
6427 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6428 Do not rely on undefined behavior after integer overflow.
6429
de883a70
PE
6430 merge count_size_as_multibyte, parse_str_to_multibyte
6431 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6432 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6433 Check for integer overflow.
6434 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6435 since it's now a duplicate of the other. This is more of
6436 a character than a buffer op, so better that it's in character.c.
6437 * fns.c, print.c: Adjust to above changes.
6438
2ff916cb
PE
64392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6440
6441 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6442
f1b54466
PE
64432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6444
fb1ac845
PE
6445 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6446 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6447 (x_clipboard_manager_save): Now static.
6448 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6449
f1b54466
PE
6450 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6451 (crypto_hash_function): Now static.
6452 Fix pointer signedness problems. Avoid unnecessary initializations.
6453
a9f737ee
CY
64542011-05-27 Chong Yidong <cyd@stupidchicken.com>
6455
6456 * termhooks.h (Vselection_alist): Make it terminal-local.
6457
6458 * terminal.c (create_terminal): Initialize it.
6459
6460 * xselect.c: Support for clipboard managers.
6461 (Vselection_alist): Move to termhooks.h as terminal-local var.
6462 (LOCAL_SELECTION): New macro.
6463 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6464 (symbol_to_x_atom): Remove gratuitous arg.
6465 (x_handle_selection_request, lisp_data_to_selection_data)
6466 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6467 (x_own_selection, x_get_local_selection, x_convert_selection):
6468 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6469 (some_frame_on_display): Delete unused function.
6470 (Fx_own_selection_internal, Fx_get_selection_internal)
6471 (Fx_disown_selection_internal, Fx_selection_owner_p)
6472 (Fx_selection_exists_p): New optional frame arg.
6473 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6474 (x_handle_selection_clear): Don't treat other terminals with the
6475 same keyboard specially. Use the terminal-local Vselection_alist.
6476 (x_clear_frame_selections): Use Frun_hook_with_args.
6477
6478 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6479
6480 * xterm.h: Add support for those atoms.
6481
e067f0c1
CY
64822011-05-26 Chong Yidong <cyd@stupidchicken.com>
6483
6484 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6485 (converted_selections, conversion_fail_tag): New global variables.
6486 (x_selection_request_lisp_error): Free the above.
6487 (x_get_local_selection): Remove unnecessary code.
6488 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6489 of converted selections stored in converted_selections.
6490 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6491 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6492 (x_convert_selection): New function.
6493 (x_handle_selection_event): Simplify.
6494 (x_get_foreign_selection): Don't ignore incoming requests while
6495 waiting for an answer; this will fail when we implement
6496 SAVE_TARGETS, and seems unnecessary anyway.
6497 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6498 (Vx_sent_selection_functions): Doc fix.
6499
0f4aebc0
LL
65002011-05-26 Leo Liu <sdl.web@gmail.com>
6501
6502 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6503
e61124cd
YM
65042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6505
6506 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6507
6508 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6509 for fringe update if it has periodic bitmap.
ac389d0c 6510 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6511 and fringe_bitmap_periodic_p.
6512
6513 * fringe.c (get_fringe_bitmap_data): New function.
6514 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6515 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6516 row. Mark glyph row for fringe update if periodicity changed.
6517
6518 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6519 for fringe update unless it has periodic bitmap.
6520
f16d9837
KH
65212011-05-25 Kenichi Handa <handa@m17n.org>
6522
6523 * xdisp.c (get_next_display_element): Set correct it->face_id for
6524 a static composition.
6525
e1b90ef6
LL
65262011-05-24 Leo Liu <sdl.web@gmail.com>
6527
6528 * deps.mk (fns.o):
6529 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6530
6531 * fns.c (crypto_hash_function, Fsha1): New function.
6532 (Fmd5): Use crypto_hash_function.
6533 (syms_of_fns): Add Ssha1.
6534
7400048f
PE
65352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6536
6537 * gnutls.c: Remove unused macros.
6538 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6539 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6540 Remove macros that are defined and never used.
6541 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6542
abb71cf4
CY
65432011-05-22 Chong Yidong <cyd@stupidchicken.com>
6544
6545 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6546 (Fx_get_selection_internal): Minor cleanup.
6547 (Fx_own_selection_internal): Rename arguments for consistency with
6548 select.el.
6549
6307db39
PE
65502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6551
6552 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6553
f3d4e0a4
CY
65542011-05-22 Chong Yidong <cyd@stupidchicken.com>
6555
6556 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6557
4d8ade89
YM
65582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6559
6560 * dispnew.c (scrolling_window): Don't exclude the case that the
6561 last enabled row in the desired matrix touches the bottom boundary.
6562
32078c8d
GM
65632011-05-21 Glenn Morris <rgm@gnu.org>
6564
6565 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6566 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6567 and add some more files.
32078c8d 6568
7285dc67
EZ
65692011-05-20 Eli Zaretskii <eliz@gnu.org>
6570
6571 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6572 report_file_error introduced by the change from 2011-05-07.
6573
89d1bd22
PE
65742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6575
6576 * systime.h (Time): Define only if emacs is defined.
6577 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6578 where the include path doesn't have X11/X.h by default. See
6579 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6580
cd394be1 65812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6582
6583 * composite.c (find_automatic_composition): Fix previous change.
6584
b9704ad9
GM
65852011-05-20 Glenn Morris <rgm@gnu.org>
6586
6587 * lisp.mk: New file, split from Makefile.in.
6588 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6589 (shortlisp): Remove.
6590 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6591
4a720484
GM
65922011-05-19 Glenn Morris <rgm@gnu.org>
6593
6594 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6595 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6596 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6597 (lisp): Set the order to that of loadup.el.
6598 (shortlisp): Make it a copy of $lisp.
6599 (SOME_MACHINE_LISP): Remove.
6600 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6601 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6602
a28d4396
KH
66032011-05-18 Kenichi Handa <handa@m17n.org>
6604
6605 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6606 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6607 (find_automatic_composition): Mostly rewrite for efficiency.
6608
a2b1fa8e
JB
66092011-05-18 Juanma Barranquero <lekktu@gmail.com>
6610
6611 * makefile.w32-in: Update dependencies.
6612
8e1f5610
CS
66132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6614
6615 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6616 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6617
7025ee00 66182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6619
cdfa6eab
PE
6620 Fix some integer overflow issues, such as string length overflow.
6621
06d6db33
PE
6622 * insdel.c (count_size_as_multibyte): Check for string overflow.
6623
2b4560a8
PE
6624 * character.c (lisp_string_width): Check for string overflow.
6625 Use EMACS_INT, not int, for string indexes and lengths; in
6626 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6627 the resulting string length overflows an EMACS_INT; instead,
6628 report a string overflow if no precision given. When checking for
6629 precision exhaustion, use a check that cannot possibly have
6630 integer overflow. (Bug#8675)
6631 * character.h (lisp_string_width): Adjust to new signature.
6632
cb93f9be
PE
6633 * alloc.c (string_overflow): New function.
6634 (Fmake_string): Use it. This doesn't change behavior, but saves
6635 a few bytes and will simplify future changes.
6636 * character.c (string_escape_byte8): Likewise.
6637 * lisp.h (string_overflow): New decl.
6638
1a1f3366
PE
6639 Fixups, following up to the user-interface timestamp change.
6640 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6641 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6642 * msdos.c (mouse_get_pos): Likewise.
6643 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6644 * w32gui.h (Time): Define by including "systime.h" rather than by
6645 declaring it ourselves. (Bug#8664)
6646
d4e3e4d3
PE
6647 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6648 * image.c (clear_image_cache): Likewise.
6649
f6a24d19
PE
6650 * term.c (term_mouse_position): Don't assume time_t wraparound.
6651
08dc5ae6
PE
6652 Be more systematic about user-interface timestamps.
6653 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6654 and sometimes 'EMACS_UINT', to represent these timestamps.
6655 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6656 This makes the code easier to follow, and makes it easier to catch
6657 integer overflow bugs such as Bug#8664.
6658 * frame.c (Fmouse_position, Fmouse_pixel_position):
6659 Use Time, not unsigned long, for user-interface timestamps.
6660 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6661 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6662 * keyboard.h (last_event_timestamp): Likewise.
6663 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6664 * menu.h (xmenu_show): Likewise.
6665 * term.c (term_mouse_position): Likewise.
6666 * termhooks.h (struct input_event.timestamp): Likewise.
6667 (struct terminal.mouse_position_hook): Likewise.
6668 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6669 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6670 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6671 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6672 what it was before.
6673 * menu.h, termhooks.h: Include "systime.h", for Time.
6674
8e55734a
PE
6675 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6676 Don't assume that the difference between two unsigned long values
6677 can fit into an integer. At this point, we know button_down_time
6678 <= event->timestamp, so the difference must be nonnegative, so
6679 there's no need to cast the result if double-click-time is
6680 nonnegative, as it should be; check that it's nonnegative, just in
6681 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6682 apart (about 25 days). (Bug#8664)
8e55734a 6683
841f1b75 6684 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6685 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6686
3e26f69c
PE
6687 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6688 that always fit in int. Use a sentinel instead of a counter, to
6689 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6690 * frame.h (struct frame): Use int for menu_bar_items_used
6691 instead of EMACS_INT, since it always fits in int.
3e26f69c 6692
5cc152c0
PE
6693 * menu.c (grow_menu_items): Check for int overflow.
6694
d89eb65e
PE
6695 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6696
5235bd3e
PE
6697 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6698 Before, the code was not consistent. These values cannot exceed
6699 2**31 - 1 so there's no need to make them unsigned.
6700 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6701 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6702 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6703 as modifiers.
6704 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6705
bc827e23
PE
6706 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6707 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6708 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6709 presumably because the widths might not match.
6710
78eb494e
PE
6711 * window.c (size_window): Avoid needless test at loop start.
6712
04f2d78b
CB
67132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6714
6715 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6716
d2fc7e3d 67172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6718
6719 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6720
d2fc7e3d 67212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6722
6723 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6724 `width' to `bar_area_x' and `bar_area_width', respectively.
6725 (x_scroll_run): Take account of fringe background extension.
6726
04f2d78b
CB
6727 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6728 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6729 `bar_area_width', respectively.
6730 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6731 background extension.
6732
79b70037
GM
67332011-05-10 Jim Meyering <meyering@redhat.com>
6734
6735 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6736
2f142cc5
JB
67372011-05-10 Juanma Barranquero <lekktu@gmail.com>
6738
6739 * image.c (Finit_image_library): Return t for built-in image types,
6740 like pbm and xbm. (Bug#8640)
6741
57679c86
AS
67422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6743
6744 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6745
888c9e86
EZ
67462011-05-07 Eli Zaretskii <eliz@gnu.org>
6747
b0512a1d
EZ
6748 * w32console.c (Fset_screen_color): Doc fix.
6749 (Fget_screen_color): New function.
6750 (syms_of_ntterm): Defsubr it.
6751
7285dc67
EZ
6752 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6753 unlink the temporary file if Fcall_process didn't create it in the
6754 first place.
6755 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6756 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6757 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6758 cue to call_process_cleanup not to close that handle.
6759
4d3fcc8e
BK
67602011-05-07 Ben Key <bkey76@gmail.com>
6761
6762 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6763 one of two shell specific rules, either bootstrap-temacs-CMD or
6764 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6765 to the previous implementation of the bootstrap-temacs rule.
6766 The bootstrap-temacs-CMD rule is similar to the previous
6767 implementation of the bootstrap-temacs rule except that it
6768 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6769 variable.
6770
6771 These changes, along with some changes to nt/configure.bat,
6772 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6773 earlier fix to add support for --cflags and --ldflags options
6774 that include quotes so that it works whether make uses cmd or
6775 sh as the shell.
6776
b4289b64
MA
67772011-05-06 Michael Albinus <michael.albinus@gmx.de>
6778
6779 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6780 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6781 is a constant.
6782 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6783 a string. Handle both cases.
6784 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6785 (Fdbus_register_method): Use Qinvalid_function.
6786
af4c0e28
JB
67872011-05-06 Juanma Barranquero <lekktu@gmail.com>
6788
6789 * makefile.w32-in: Update dependencies.
6790 (LISP_H): Add inttypes.h and stdin.h.
6791 (PROCESS_H): Add unistd.h.
6792
c51453d9
EZ
67932011-05-06 Eli Zaretskii <eliz@gnu.org>
6794
6795 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6796 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6797
8ff0ac3c 67982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6799
4c4b566b
PE
6800 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6801
aab2b9b5
PE
6802 * term.c (vfatal): Remove stray call to va_end.
6803 It's not needed and the C Standard doesn't allow it here anyway.
6804
c378da0b
PE
6805 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6806 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6807
288b08c7
PE
6808 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6809 bytes.
6810
e3601888
PE
6811 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6812
db6c0e74
PE
6813 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6814
dd5963ea
PE
6815 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6816
88c9450f
PE
6817 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6818
2f9442b8
PE
6819 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6820
c032b5f8
PE
6821 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6822 * charset.c (Fdefine_charset_internal): Don't initialize
6823 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6824 32-bit int (Bug#8600).
a108c10b
PE
6825
6826 * lread.c (read_integer): Be more consistent with string-to-number.
6827 Use string_to_number to do the actual conversion; this avoids
6828 rounding errors and fixes some other screwups. Without this fix,
6829 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6830 (digit_to_number): Move earlier, for benefit of read_integer.
6831 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6832 not a digit in any supported base. (Bug#8602)
a108c10b 6833
ad5f9eea
PE
6834 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6835
aec1708a
PE
6836 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6837 to match comment at start of function. This also removes a
6838 GCC warning about overflow in a 32+64-bit port.
6839
47be4ab5
PE
6840 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6841
371cac43
PE
6842 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6843 Reported by Stefan Monnier in
6844 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6845 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6846 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6847
d01a7826
PE
6848 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6849 (EMACS_UINTPTR): Likewise, with uintptr_t.
6850
7fd47d5c
PE
6851 * lisp.h: Prefer 64-bit EMACS_INT if available.
6852 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6853 on 32-bit hosts that have 64-bit int, so that they can access
6854 large files.
122b0c86
PE
6855 However, temporarily disable this change unless the temporary
6856 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6857
8727937b
PE
6858 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6859
8ac068ac
PE
6860 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6861 This removes an assumption that EMACS_INT and long are the same
6862 width as pointers. The assumption is true for Emacs porting targets
6863 now, but we want to make other targets possible.
6864 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6865 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6866 In the rest of the code, change types of integers that hold casted
6867 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6868 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6869 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6870 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6871 No need to cast type when ORing.
6872 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6873 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6874 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6875 assume EMACS_INT is the same width as char *.
6876 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6877 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6878 Remove no-longer-needed casts.
6879 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6880 (xg_tool_bar_help_callback, xg_make_tool_item):
6881 Use EMACS_INTPTR to hold an integer
6882 that will be cast to void *; this can avoid a GCC warning
6883 if EMACS_INT is not the same width as void *.
6884 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6885 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6886 (current_message_1, set_message_1):
6887 Use a local to convert to proper width without a cast.
6888 * xmenu.c (dialog_selection_callback): Likewise.
6889
ede49d71
PE
6890 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6891 Also, don't assume VALBITS / RAND_BITS is less than 5,
6892 and don't rely on undefined behavior when shifting a 1 left into
6893 the sign bit.
6894 * lisp.h (get_random): Change signature to match.
6895
2f30ecd0
PE
6896 * lread.c (hash_string): Use size_t, not int, for hash computation.
6897 Normally we prefer signed values; but hashing is special, because
6898 it's better to use unsigned division on hash table sizes so that
6899 the remainder is nonnegative. Also, size_t is the natural width
6900 for hashing into memory. The previous code used 'int', which doesn't
6901 retain enough info to hash well into very large tables.
6902 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6903
2a866e7b
PE
6904 * dbusbind.c: Don't possibly lose pointer info when converting.
6905 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6906 Use XPNTR rather than XHASH, so that the high-order bits of
6907 the pointer aren't lost when converting through void *.
6908
51639eac
PE
6909 * eval.c (Fautoload): Don't double-shift a pointer.
6910
92394119
PE
6911 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6912
dbdb9a7c
JB
69132011-05-06 Juanma Barranquero <lekktu@gmail.com>
6914
6915 * gnutls.c (DEF_GNUTLS_FN):
6916 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6917
db7a0b4f
AS
69182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6919
6920 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6921 marker. (Bug#8610)
6922
cd394be1 69232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6924
6925 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6926 New version that can reserve upto 2GB of heap space.
6927
f7ff1b0f 69282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6929
6930 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6931
639c109b
TZ
69322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6933
6934 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6935 `gnutls_certificate_set_x509_key_file'.
6936
d2127135
JB
69372011-05-05 Juanma Barranquero <lekktu@gmail.com>
6938
6939 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6940 Update dependencies.
6941
e968f4f3
JB
69422011-05-04 Juanma Barranquero <lekktu@gmail.com>
6943
6944 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6945 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6946 Remove unused parameter `fildes'.
6947 * process.c (read_process_output, send_process): Don't pass it.
6948
84d358f0
JB
69492011-05-04 Juanma Barranquero <lekktu@gmail.com>
6950
6951 Fix previous change: the library cache is defined in w32.c.
6952 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6953 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6954
0898ca10
JB
69552011-05-04 Juanma Barranquero <lekktu@gmail.com>
6956
6957 Implement dynamic loading of GnuTLS on Windows.
6958
6959 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6960 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6961 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6962 Declare.
6963
6964 * gnutls.c (Qgnutls_dll): Define.
6965 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6966 (gnutls_*): Declare function pointers.
6967 (init_gnutls_functions): New function to initialize function pointers.
6968 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6969 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6970 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6971 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6972 (emacs_gnutls_write, emacs_gnutls_read)
6973 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6974 (Fgnutls_available_p): New function.
6975 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6976 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6977 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6978
6979 * image.c: Include w32.h.
6980 (Vimage_type_cache): Delete.
6981 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6982 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6983 (w32_delayed_load): Move to w32.c.
6984
6985 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6986
6987 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6988 (w32_delayed_load): Move from image.c. When loading a library, record
6989 its filename in the :loaded-from property of the library id.
6990 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6991 Initialize and staticpro them.
6992 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6993
6994 * process.c: Include lisp.h before w32.h, not after.
6995 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6996 instead of gnutls_record_check_pending.
6997
6998 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6999
ff4de4aa
TZ
70002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7001
7002 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7003 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7004 as passed in.
7005
abe95abb
JD
70062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7007
7008 * xterm.c (x_set_frame_alpha): Do not set property on anything
7009 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7010
e16e55d4
JB
70112011-05-02 Juanma Barranquero <lekktu@gmail.com>
7012
7013 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7014
bafcf6a5
JB
70152011-05-02 Juanma Barranquero <lekktu@gmail.com>
7016
7017 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7018 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7019 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7020 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7021 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7022 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7023 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7024 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7025 (Qgnutls_bootprop_callbacks_verify): Make static.
7026
e7a6747f
AS
70272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7028
19ed11ba
AS
7029 * callproc.c: Indentation fixup.
7030
e7a6747f 7031 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7032 (wait_for_termination, interruptible_wait_for_termination):
7033 Move after wait_for_termination_1.
e7a6747f 7034
1ef14cb4
LMI
70352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7036
7037 * sysdep.c (interruptible_wait_for_termination): New function
7038 which is like wait_for_termination, but allows keyboard
7039 interruptions.
7040
7041 * callproc.c (Fcall_process): Add (:file "file") as an option for
7042 the STDOUT buffer.
7043 (Fcall_process_region): Ditto.
7044
330d880c
EZ
70452011-04-30 Eli Zaretskii <eliz@gnu.org>
7046
8db90b73
EZ
7047 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7048 rather than `XVECTOR (FOO)->size'.
7049
330d880c
EZ
7050 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7051 inttypes.h, as a gnulib replacement is used if it not available in
7052 system headers.
7053
15cbd324
EZ
70542011-04-21 Eli Zaretskii <eliz@gnu.org>
7055
7056 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7057 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7058 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7059
7060 * coding.c (coding_alloc_by_realloc): Error out if destination
7061 will grow beyond MOST_POSITIVE_FIXNUM.
7062 (decode_coding_emacs_mule): Abort if there isn't enough place in
7063 charbuf for the composition carryover bytes. Reserve an extra
7064 space for up to 2 characters produced in a loop.
7065 (decode_coding_iso_2022): Abort if there isn't enough place in
7066 charbuf for the composition carryover bytes.
7067
70682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7069
ae940cca
EZ
7070 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7071 aborting when %lld or %lll format is passed.
7072 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7073 %llo or %llx format is passed. (Bug#8545)
7074
03ab8921
EZ
7075 * window.c (window_scroll_line_based): Use a marker instead of
7076 simple variables to record original value of point. (Bug#7952)
7077
afda1437
EZ
7078 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7079 produced by %s or %c overflows available buffer space. (Bug#8545)
7080
f76dee0c
PE
70812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7082
7083 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7084 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7085
fdc5744d
JB
70862011-04-28 Juanma Barranquero <lekktu@gmail.com>
7087
7088 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7089
638f053a
JB
70902011-04-28 Juanma Barranquero <lekktu@gmail.com>
7091
7092 * keyboard.c (Qdelayed_warnings_hook): Define.
7093 (command_loop_1): Run `delayed-warnings-hook'
7094 if Vdelayed_warnings_list is non-nil.
7095 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7096 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7097
d178f871
EZ
70982011-04-28 Eli Zaretskii <eliz@gnu.org>
7099
7100 * doprnt.c (doprnt): Don't return value smaller than the buffer
7101 size if the message was truncated. (Bug#8545).
7102
b124fd93
JB
71032011-04-28 Juanma Barranquero <lekktu@gmail.com>
7104
7105 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7106 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7107
e810457d
PE
71082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7109
7110 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7111
ea51cceb
JB
71122011-04-27 Juanma Barranquero <lekktu@gmail.com>
7113
7114 * makefile.w32-in: Update dependencies.
7115
94dcfacf
EZ
71162011-04-27 Eli Zaretskii <eliz@gnu.org>
7117
7118 Improve `doprnt' and its usage. (Bug#8545)
7119 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7120 `format_end'. Remove support for %l as a conversion specifier.
7121 Don't use xrealloc. Improve diagnostics when the %l size modifier
7122 is used. Update the commentary.
7123
7124 * eval.c (verror): Simplify calculation of size_t.
7125
7126 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7127 messages.
7128
f61f41d7
PE
71292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7130
7131 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7132 change.
7133
96fb4434
PE
71342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7135
7136 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7137 This makes this file independent of the recent pseudovector change.
7138
671875da 71392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7140
69e9b5a3
PE
7141 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7142
b5f869a7 7143 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7144 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7145 Remove unused local.
c8926152 7146 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7147
841a1577 7148 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7149 GCC 4.6.0 optimizes based on type-based alias analysis.
7150 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7151 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7152 != &v->size, and therefore "v->size = 1; b->size = 2; return
7153 v->size;" must therefore return 1. This assumption is incorrect
7154 for Emacs, since it type-puns struct Lisp_Vector * with many other
7155 types. To fix this problem, this patch adds a new type struct
f904488f 7156 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7157 and pseudovectors, and helps optimizing compilers not get fooled
7158 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7159 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7160 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7161 the size member.
eab3844f
PE
7162 (XSETPVECTYPE): Rewrite in terms of new macro.
7163 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7164 This is a bit clearer, and further avoids the possibility of
7165 undesirable aliasing.
7166 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7167 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7168 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7169 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7170 (ASIZE): Now uses header.size rather than size.
7171 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7172 to avoid the hassle of writing XVECTOR (foo)->header.size.
7173 (struct vectorlike_header): New type.
eab3844f
PE
7174 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7175 object, to help avoid aliasing.
7176 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7177 (SUBRP): Likewise, since Lisp_Subr is a special case.
7178 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7179 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7180 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7181 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7182 changed to be "header.size" and "header.next".
7183 * buffer.h (struct buffer): Likewise.
7184 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7185 * frame.h (struct frame): Likewise.
7186 * process.h (struct Lisp_Process): Likewise.
7187 * termhooks.h (struct terminal): Likewise.
7188 * window.c (struct save_window_data, struct saved_window): Likewise.
7189 * window.h (struct window): Likewise.
7190 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7191 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7192 * buffer.c (init_buffer_once): Likewise.
7193 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7194 special case.
7195 * process.c (Fformat_network_address): Use local var for size,
7196 for brevity.
7197
0df1eac5
PE
7198 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7199
847ab9d1 7200 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7201 * data.c (atof): Remove decl; no longer used or needed.
7202 (digit_to_number): Move to lread.c.
7203 (Fstring_to_number): Use new string_to_number function, to be
7204 consistent with how the Lisp reader treats infinities and NaNs.
7205 Do not assume that floating-point numbers represent EMACS_INT
7206 without losing information; this is not true on most 64-bit hosts.
7207 Avoid double-rounding errors, by insisting on integers when
7208 parsing non-base-10 numbers, as the documentation specifies.
7209 * lisp.h (string_to_number): New decl, replacing ...
7210 (isfloat_string): Remove.
bc0a5c13 7211 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7212 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7213 appears to have been a coding error. Similarly, do not accept
7214 strings like +-1e0 as floating point numbers. Do not report
7215 overflow for integer overflows unless the base is not 10 which
7216 means we have no simple and reliable way to continue.
7217 Break out the floating-point parsing into a new
7218 function string_to_number, so that Fstring_to_number parses
7219 floating point numbers consistently with the Lisp reader.
04f2d78b 7220 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7221 (E_CHAR, EXP_INT): Remove, replacing with ...
7222 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7223 (string_to_number): New function, replacing isfloat_string.
7224 This function checks for valid syntax and produces the resulting
7225 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7226 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7227 so that overflow for non-base-10 numbers is reported only when
7228 there's no portable and simple way to convert to floating point.
452f4150 7229
67769ffc
PE
7230 * textprop.c (set_text_properties_1): Rewrite for clarity,
7231 and to avoid GCC warning about integer overflow.
7232
c20db43f
PE
7233 * intervals.h (struct interval): Use EMACS_INT for members
7234 where EMACS_UINT might cause problems. See
7235 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7236 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7237 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7238 All uses changed.
37aa2f85
PE
7239 (offset_intervals): Tell GCC not to worry about length overflow
7240 when negating a negative length.
c20db43f 7241
2538aa2f
PE
7242 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7243 (overrun_check_free): Likewise.
7244
f2d3008d
PE
7245 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7246 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7247 word size.
7248
ec8df744
PE
7249 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7250 (gnutls_make_error): Rename local to avoid shadowing.
7251 (gnutls_emacs_global_deinit): ifdef out; not used.
7252 (Fgnutls_boot): Use const for pointer to readonly storage.
7253 Comment out unused local. Fix pointer signedness problems.
7254
640ee02d
PE
7255 * lread.c (openp): Don't stuff size_t into an 'int'.
7256 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7257 about possible signed overflow.
7258
6048fb2a
PE
7259 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7260 (GDK_KEY_g): Don't define if already defined.
7261 (xg_prepare_tooltip): Avoid pointer signedness problem.
7262 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7263
fa3c87e1
PE
7264 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7265 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7266
2172544b
PE
7267 * xfns.c (Fx_window_property): Simplify a bit,
7268 to make a bit faster and to avoid GCC 4.6.0 warning.
7269 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7270
9b821a21
PE
7271 * fns.c (internal_equal): Don't assume size_t fits in int.
7272
3c616cfa
PE
7273 * alloc.c (compact_small_strings): Tighten assertion a little.
7274
c2982e87
PE
7275 Replace pEd with more-general pI, and fix some printf arg casts.
7276 * lisp.h (pI): New macro, generalizing old pEd macro to other
7277 conversion specifiers. For example, use "...%"pI"d..." rather
7278 than "...%"pEd"...".
7279 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7280 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7281 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7282 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7283 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7284 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7285 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7286 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7287 64-bit hosts.
7288 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7289 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7290 * print.c (safe_debug_print, print_object): Likewise.
7291 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7292 to int.
6f04d126
PE
7293 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7294 avoiding the 0 flag, which is not portable.
c2982e87
PE
7295 * process.c (Fmake_network_process): Use pI to avoid cast.
7296 * region-cache.c (pp_cache): Likewise.
7297 * xdisp.c (decode_mode_spec): Likewise.
7298 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7299 behavior on 64-bit hosts with printf arg.
6f04d126 7300 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7301 (x_stop_queuing_selection_requests): Likewise.
7302 (x_get_window_property): Don't truncate byte count to an 'int'
7303 when tracing.
0b432f21 7304
5e073ec7
PE
7305 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7306 here, since it parses constructs like leading '-' and spaces,
7307 which are not wanted; and it overflows with large numbers.
7308 Instead, simply match F[0-9]+, which is what is wanted anyway.
7309
36372bf9
PE
7310 * alloc.c: Remove unportable assumptions about struct layout.
7311 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7312 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7313 (allocate_vectorlike, make_pure_vector): Use the new macros,
7314 plus offsetof, to remove unportable assumptions about struct layout.
7315 These assumptions hold on all porting targets that I know of, but
7316 they are not guaranteed, they're easy to remove, and removing them
7317 makes further changes easier.
7318
0b432f21
PE
7319 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7320 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7321 (string_overrun_cookie): Now const. Use initializers that
7322 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7323 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7324 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7325 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7326 multiple of sizeof (EMACS_INT); it need not be, if
7327 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7328 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7329
895009e1
JB
73302011-04-26 Juanma Barranquero <lekktu@gmail.com>
7331
7332 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7333
6a7a1b0b
TZ
73342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7335
7336 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7337 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7338 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7339
841a1577 73402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7341
7342 * lisp.h (Qdebug): List symbol.
895009e1 7343 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7344 * keyboard.c (debug-on-event): New variable.
7345 (handle_user_signal): Break into debugger when debug-on-event
7346 matches the current signal symbol.
7347
f2d3ba6f
DN
73482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7349
7350 * alloc.c (check_sblock, check_string_bytes)
7351 (check_string_free_list): Convert to standard C.
7352
42ce4c63
TZ
73532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7354
7355 * w32.c (emacs_gnutls_push): Fix typo.
7356
825cd63c
EZ
73572011-04-25 Eli Zaretskii <eliz@gnu.org>
7358
fb11d64d
EZ
7359 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7360 "cast to pointer from integer of different size".
7361
825cd63c
EZ
7362 Improve doprnt and its use in verror. (Bug#8545)
7363 * doprnt.c (doprnt): Document the set of format control sequences
7364 supported by the function. Use SAFE_ALLOCA instead of always
7365 using `alloca'.
7366
7367 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7368 is one byte too soon. Don't use xrealloc; instead xfree and
7369 xmalloc anew.
7370
e061a11b
TZ
73712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7372
7373 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7374 callbacks stage.
7375
7376 * gnutls.c: Renamed global_initialized to
7377 gnutls_global_initialized. Added internals for the
7378 :verify-hostname-error, :verify-error, and :verify-flags
7379 parameters of `gnutls-boot' and documented those parameters in the
7380 docstring. Start callback support.
9173deec
JB
7381 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7382 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7383 on error. Return error code.
e061a11b
TZ
7384 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7385 (emacs_gnutls_read): Likewise.
7386 (Fgnutls_boot): Return handshake error code.
7387 (emacs_gnutls_handle_error): New function.
7388 (wsaerror_to_errno): Likewise.
7389
7390 * w32.h (emacs_gnutls_pull): Add prototype.
7391 (emacs_gnutls_push): Likewise.
7392
7393 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7394 (emacs_gnutls_push): Likewise.
7395
73962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7397
7398 * process.c (wait_reading_process_output): Check if GnuTLS
7399 buffered some data internally if no FDs are set for TLS
7400 connections.
7401
7402 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7403 (LIBS): Link to USER_LIBS.
7404 ($(BLD)/gnutls.$(0)): New target.
7405
fa6996bc
EZ
74062011-04-24 Eli Zaretskii <eliz@gnu.org>
7407
eb35682e
EZ
7408 * xdisp.c (handle_single_display_spec): Rename the
7409 display_replaced_before_p argument into display_replaced_p, to
7410 make it consistent with the commentary. Fix typos in the
7411 commentary.
7412
e2ad650c
EZ
7413 * textprop.c (syms_of_textprop): Remove dead code.
7414 (copy_text_properties): Delete obsolete commentary about an
7415 interface that was deleted long ago. Fix typos in the description
7416 of arguments.
7417
1b2de274
EZ
7418 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7419 to changes in oldXMenu/XMenu.h from 2011-04-16.
7420 <menu_help_message, prev_menu_help_message>: Constify.
7421 (IT_menu_make_room): menu->help_text is now `const char **';
7422 adjust.
7423
7424 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7425 to changes in oldXMenu/XMenu.h from 2011-04-16.
7426 (struct XMenu): Declare `help_text' `const char **'.
7427
7428 * xfaces.c <Qunspecified>: Make extern again.
7429
7430 * syntax.c: Include sys/types.h before including regex.h, as
7431 required by Posix.
7432
762b15be
EZ
7433 * doc.c (get_doc_string): Improve the format passed to `error'.
7434
7435 * doprnt.c (doprnt): Improve commentary.
7436
7437 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7438
7439 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7440 them with etags.
7441
f1052e5d
EZ
7442 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7443 changes in globals.h immediately force recompilation.
762b15be
EZ
7444 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7445 $(CURDIR)/s/ms-w32.h.
7446 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7447
fa6996bc
EZ
7448 * character.c (Fchar_direction): Function deleted.
7449 (syms_of_character): Don't defsubr it.
7450 <char-direction-table>: Deleted.
7451
e6c3da20
EZ
74522011-04-23 Eli Zaretskii <eliz@gnu.org>
7453
7454 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7455 * doprnt.c: Include limits.h.
7456 (SIZE_MAX): New macro.
04f2d78b
CB
7457 (doprnt): Return a size_t value. 2nd arg is now size_t.
7458 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7459 Improve overflow protection. Support `l' modifier for integer
7460 conversions. Support %l conversion. Don't assume an EMACS_INT
7461 argument for integer conversions and for %c.
7462
7463 * lisp.h (doprnt): Restore prototype.
7464
7465 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7466 $(SRC)/character.h.
7467
7468 * Makefile.in (base_obj): Add back doprnt.o.
7469
7470 * deps.mk (doprnt.o): Add back prerequisites.
7471 (callint.o): Depend on character.h.
7472
7473 * eval.c (internal_lisp_condition_case): Include the handler
7474 representation in the error message.
7475 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7476 when breaking from the loop.
7477
7478 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7479
7480 * callint.c (Fcall_interactively): When displaying error message
7481 about invalid control letter, pass the character's codepoint, not
7482 a pointer to its multibyte form. Improve display of the character
7483 in octal and display also its hex code.
7484
7485 * character.c (char_string): Use %x to display the (unsigned)
7486 codepoint of an invalid character, to avoid displaying a bogus
7487 negative value.
7488
7489 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7490 `error', not SYMBOL_NAME itself.
7491
7492 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7493 character arguments to `error'.
7494
7495 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7496 to `error' in error message about FINAL_CHAR argument. Make sure
7497 FINAL_CHAR is a character, and use %c when it is passed as
7498 argument to `error'.
7499
4ffd0d6b 75002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7501
7502 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7503
7504 * w32.c: Include <time.h>.
7505 (sys_localtime): New function.
7506
4ffd0d6b 75072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7508
7509 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7510
4ffd0d6b 7511 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7512
4ffd0d6b 75132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7514
4ffd0d6b
GM
7515 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7516 zombies (Bug#8467).
aac0c6e3 7517
04c56954
EZ
75182011-04-19 Eli Zaretskii <eliz@gnu.org>
7519
7520 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7521 gl_state.e_property when gl_state.object is Qt.
7522
7523 * insdel.c (make_gap_larger): Remove limitation of buffer size
7524 to <= INT_MAX.
7525
16a43933
CY
75262011-04-18 Chong Yidong <cyd@stupidchicken.com>
7527
7528 * xdisp.c (lookup_glyphless_char_display)
7529 (produce_glyphless_glyph): Handle cons cell entry in
7530 glyphless-char-display.
7531 (Vglyphless_char_display): Document it.
7532
7533 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7534 glyphless-char-display.
7535
4581706e
CY
75362011-04-17 Chong Yidong <cyd@stupidchicken.com>
7537
7538 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7539
7540 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7541
7542 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7543 definition for no-X builds.
7544
4887c6e2 75452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7546
fd35b6f9
PE
7547 Static checks with GCC 4.6.0 and non-default toolkits.
7548
5c1ccb01
PE
7549 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7550
006c5daa
PE
7551 * process.c (keyboard_bit_set): Define only if SIGIO.
7552 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7553 (send_process): Repair possible setjmp clobbering.
7554
efc736d3
PE
7555 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7556
4e2fe2e6
PE
7557 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7558
f97334a2
PE
7559 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7560
4e75f29d
PE
7561 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7562 Define only if needed.
7563
90efadd1
PE
7564 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7565 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7566 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7567
3c647824
PE
7568 * dispextern.h (struct redisplay_interface): Rename param
7569 to avoid shadowing.
e264f262 7570 * termhooks.h (struct terminal): Likewise.
761383f4 7571 * xterm.c (xembed_send_message): Likewise.
3c647824 7572
b58c5c4a
PE
7573 * insdel.c (make_gap_smaller): Define only if
7574 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7575
cad59032
PE
7576 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7577 it.
7578
c339dc2e
PE
7579 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7580 so that we aren't warned about unused symbols.
7581
91a3e27b
PE
7582 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7583
399c71d3 7584 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7585
8ffc96f5
PE
7586 * xfns.c (x_real_positions): Mark locals as initialized.
7587
eef9bc79
PE
7588 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7589
098db9dd
PE
7590 * xterm.c: Fix problems found by static analysis with other toolkits.
7591 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7592 (x_dispatch_event): Declare static if USE_GTK, and
7593 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7594 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7595 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7596 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7597 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7598
eb18f6cc
PE
7599 * xmenu.c (menu_help_callback): Pointer type fixes.
7600 Use const pointers when pointing at readonly data. Avoid pointer
7601 signedness clashes.
7602 (FALSE): Remove unused macro.
7603 (update_frame_menubar): Remove unused decl.
7604
1fe72bf8
PE
7605 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7606
60d9e1db
PE
7607 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7608 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7609 (single_menu_item): Rename local to avoid shadowing.
7610
39261c26
PE
7611 * keyboard.c (make_lispy_event): Remove unused local var.
7612
018c5e19
PE
7613 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7614 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7615
63d2b86e
PE
7616 * bitmaps: Change bitmaps from unsigned char back to the X11
7617 compatible char. Avoid the old compiler warnings about
7618 out-of-range initializers by using, for example, '\xab' rather
7619 than 0xab.
7620
aefd87e1
PE
7621 * xgselect.c (xgselect_initialize): Check vs interface
7622 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7623
bf501fb9
PE
7624 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7625
e9829fdf
PE
7626 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7627 to read-only memory.
7628
1086c095
PE
7629 * fns.c (vector): Remove; this old hack is no longer needed.
7630
2baccd04 7631 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7632 Remove unused var.
dde42981 7633 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7634
72391843 7635 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7636
436c16df 7637 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7638 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7639 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7640
92bb796d 7641 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7642 (x_term_init): Remove local to avoid shadowing.
92bb796d 7643
764430a3 7644 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7645
7646 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7647 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7648
d1dfb56c
EZ
76492011-04-16 Eli Zaretskii <eliz@gnu.org>
7650
c4354cb4
EZ
7651 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7652
d1dfb56c
EZ
7653 Fix regex.c, syntax.c and friends for buffers > 2GB.
7654 * syntax.h (struct gl_state_s): Declare character position members
7655 EMACS_INT.
7656
7657 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7658
04f2d78b
CB
7659 * textprop.c (verify_interval_modification, interval_of):
7660 Declare arguments EMACS_INT.
d1dfb56c
EZ
7661
7662 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7663 EMACS_INT.
7664
7665 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7666
7667 * indent.c (Fvertical_motion): Local variable it_start is now
7668 EMACS_INT.
7669
7670 * regex.c (re_match, re_match_2, re_match_2_internal)
7671 (bcmp_translate, regcomp, regexec, print_double_string)
7672 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7673 (re_compile_pattern, re_exec): Declare arguments and local
7674 variables `size_t' and `ssize_t' and return values `regoff_t', as
7675 appropriate.
7676 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7677 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7678 <compile_stack_type>: `size' and `avail' are now `size_t'.
7679
7680 * regex.h <regoff_t>: Use ssize_t, not int.
7681 (re_search, re_search_2, re_match, re_match_2): Arguments that
7682 specify buffer/string position and length are now ssize_t and
7683 size_t. Return type is regoff_t.
7684
613052cd
BK
76852011-04-16 Ben Key <bkey76@gmail.com>
7686
7687 * nsfont.m: Fixed bugs in ns_get_family and
7688 ns_descriptor_to_entity that were caused by using free to
7689 deallocate memory blocks that were allocated by xmalloc (via
7690 xstrdup). This caused Emacs to crash when compiled with
7691 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7692 --enable-checking=xmallocoverrun). xfree is now used to
7693 deallocate these memory blocks.
7694
4170f62f 76952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7696
71b41406
PE
7697 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7698
9587a89d
PE
7699 emacs_write: Accept and return EMACS_INT for sizes.
7700 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7701 et seq.
7702 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7703 Accept and return EMACS_INT.
7704 (emacs_gnutls_write): Return the number of bytes written on
7705 partial writes.
7706 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7707 (emacs_read, emacs_write): Remove check for negative size, as the
7708 Emacs source code has been audited now.
9587a89d
PE
7709 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7710 (emacs_read, emacs_write): Use it.
273a5f82
PE
7711 * process.c (send_process): Adjust to the new signatures of
7712 emacs_write and emacs_gnutls_write. Do not attempt to store
7713 a byte offset into an 'int'; it might overflow.
9587a89d 7714 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7715
3e047f51
PE
7716 * sound.c: Don't assume sizes fit in 'int'.
7717 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7718 Return EMACS_INT, not int.
3e047f51 7719 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7720 Accept EMACS_INT, not int.
7721 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7722 record read return values.
7723
cc39a9db
BK
77242011-04-15 Ben Key <bkey76@gmail.com>
7725
c9d0ec6d
JB
7726 * keyboard.c (Qundefined): Don't declare static since it is used
7727 in nsfns.m.
7728 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7729 static since they are used in nsfont.m.
cc39a9db 7730
6c60eb9f
SM
77312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7732
7733 * process.c (Qprocessp): Don't declare static.
7734 * lisp.h (Qprocessp): Declare again.
7735
7990b61a
JB
77362011-04-15 Juanma Barranquero <lekktu@gmail.com>
7737
7738 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7739
5d4cb038
PE
77402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7741
8bd7b830 7742 Improve C-level modularity by making more things 'static'.
cd64ea1d 7743
e3b27b31
PE
7744 Don't publish debugger-only interfaces to other modules.
7745 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7746 (verify_bytepos, count_markers): Move decls to the only modules
7747 that need them.
7748 * region-cache.h (pp_cache): Likewise.
7749 * window.h (check_all_windows): Likewise.
7750 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7751
5d4cb038
PE
7752 * sysdep.c (croak): Now static, if
7753 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7754 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7755
7756 * alloc.c (refill_memory_reserve): Now static if
7757 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7758 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7759
e87b6180
PE
7760 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7761 Define only if USE_LUCID.
7762
ac64929e
PE
7763 * xrdb.c (x_customization_string, x_rm_string): Now static.
7764
6f37259d
PE
7765 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7766 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7767
1683e3ab
PE
7768 * xdisp.c (draw_row_with_mouse_face): Now static.
7769 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7770
de9c2632
PE
7771 * window.h (check_all_windows): Mark externally visible.
7772
2b96acb7
PE
7773 * window.c (window_deletion_count): Now static.
7774
7775 * undo.c: Make symbols static if they're not exported.
7776 (last_undo_buffer, last_boundary_position, pending_boundary):
7777 Now static.
7778
50436f33
PE
7779 * textprop.c (interval_insert_behind_hooks): Now static.
7780 (interval_insert_in_front_hooks): Likewise.
7781
64520e5c
PE
7782 * term.c: Make symbols static if they're not exported.
7783 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7784 (max_frame_lines, tty_set_terminal_modes):
7785 (tty_reset_terminal_modes, tty_turn_off_highlight):
7786 (get_tty_terminal): Now static.
7787 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7788 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7789 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7790 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7791 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7792
1fa53021
PE
7793 * sysdep.c: Make symbols static if they're not exported.
7794 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7795 Now static.
7796 (sigprocmask_set, full_mask): Remove; unused.
7797 (wait_debugging): Mark as visible.
7798 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7799 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7800
d4b43b22
PE
7801 * syntax.c (syntax_temp): Define only if !__GNUC__.
7802
b7c513d0
PE
7803 * sound.c (current_sound_device, current_sound): Now static.
7804
989b29ad
PE
7805 * search.c (searchbufs, searchbuf_head): Now static.
7806
13a55a78
PE
7807 * scroll.c (scroll_cost): Remove; unused.
7808 * dispextern.h (scroll_cost): Remove decl.
7809
de68a1fc
PE
7810 * region-cache.h (pp_cache): Mark as externally visible.
7811
40ccffa6
PE
7812 * process.c: Make symbols static if they're not exported.
7813 (process_tick, update_tick, create_process, chan_process):
7814 (Vprocess_alist, proc_buffered_char, datagram_access):
7815 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7816 (deactivate_process): Mark defn as static, as well as decl.
7817 * lisp.h (create_process): Remove decl.
7818 * process.h (chan_process, Vprocess_alist): Remove decls.
7819
ad64fc97
PE
7820 * print.c: Make symbols static if they're not exported.
7821 (print_depth, new_backquote_output, being_printed, print_buffer):
7822 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7823 (print_interval, print_number_index, initial_stderr_stream):
7824 Now static.
7825 * lisp.h (Fprinc): Remove decl.
7826 (debug_output_compilation_hack): Mark as externally visible.
7827
adddb265
PE
7828 * sysdep.c (croak): Move decl from here to syssignal.h.
7829 * syssignal.h (croak): Put it here, so the API can be checked when
7830 'croak' is called from dissociate_if_controlling_tty.
7831
1717ede2
PE
7832 * minibuf.c: Make symbols static if they're not exported.
7833 (minibuf_save_list, choose_minibuf_frame): Now static.
7834 * lisp.h (choose_minibuf_frame): Remove decl.
7835
fa5fb2bc
PE
7836 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7837
1e3890d1
PE
7838 * lread.c: Make symbols static if they're not exported.
7839 (read_objects, initial_obarray, oblookup_last_bucket_number):
7840 Now static.
7841 (make_symbol): Remove; unused.
7842 * lisp.h (initial_obarray, make_symbol): Remove decls.
7843
8a1414fa
PE
7844 * keyboard.c: Make symbols static if they're not exported.
7845 (single_kboard, recent_keys_index, total_keys, recent_keys):
7846 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7847 (this_single_command_key_start, echoing, last_auto_save):
7848 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7849 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7850 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7851 (Vlispy_mouse_stem, double_click_count):
7852 Now static.
7853 (force_auto_save_soon): Define only if SIGDANGER.
7854 (ignore_mouse_drag_p): Now static if
7855 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7856 (print_help): Remove; unused.
7857 (stop_character, last_timer_event): Mark as externally visible.
7858 * keyboard.h (ignore_mouse_drag_p): Declare only if
7859 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7860 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7861 * lisp.h (echoing): Remove decl.
7862 (force_auto_save_soon): Declare only if SIGDANGER.
7863 * xdisp.c (redisplay_window): Simplify code, to make it more
7864 obvious that ignore_mouse_drag_p is not accessed if !defined
7865 USE_GTK && !defined HAVE_NS.
7866
93ea6e8f
PE
7867 * intervals.c: Make symbols static if they're not exported.
7868 (merge_properties_sticky, merge_interval_right, delete_interval):
7869 Now static.
7870 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7871
77382fcc
PE
7872 * insdel.c: Make symbols static if they're not exported.
7873 However, leave prepare_to_modify_buffer alone. It's never
7874 called from outside this function, but that appears to be a bug.
7875 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7876 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7877 (adjust_after_replace_noundo): Remove; unused.
7878 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7879 (signal_before_change): Remove decls.
77382fcc 7880
9306c32e
PE
7881 * indent.c (val_compute_motion, val_vmotion): Now static.
7882
cd44d2eb
PE
7883 * image.c: Make symbols static if they're not exported.
7884 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7885 if USE_GTK.
7886 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7887 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7888
ad9a7a06
PE
7889 * fringe.c (standard_bitmaps): Now static.
7890 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7891
81626931
PE
7892 * frame.c: Make symbols static if they're not exported.
7893 (x_report_frame_params, make_terminal_frame): Now static.
7894 (get_frame_param): Now static, unless HAVE_NS.
7895 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7896 (x_get_resource_string): Remove; not used.
7897 * frame.h (make_terminal_frame, x_report_frame_params):
7898 (x_get_resource_string); Remove decls.
7899 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7900 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7901
239f9db9
PE
7902 * font.c, fontset.c: Make symbols static if they're not exported.
7903 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7904 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7905 * font.c (font_close_object): Now static.
7906 * font.h (font_close_object): Remove.
7907 * fontset.c (FONTSET_OBJLIST): Remove.
7908 (free_realized_fontset) #if-0 the body, which does nothing.
7909 (face_suitable_for_char_p): #if-0, as it's never called.
7910 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7911 * xfaces.c (face_at_string_position):
7912 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7913 since 0 is always ASCII.
7914
dfcf3579
PE
7915 * fns.c (weak_hash_tables): Now static.
7916
5045092b
PE
7917 * fileio.c: Make symbols static if they're not exported.
7918 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7919 (Vwrite_region_annotation_buffers): Now static.
7920
57a96f5c
PE
7921 * eval.c: Make symbols static if they're not exported.
7922 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7923 * lisp.h (backtrace_list): Remove decl.
7924
35f08c38
PE
7925 * emacs.c: Make symbols static if they're not exported.
7926 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7927 (fatal_error_code, fatal_error_signal_hook, standard_args):
7928 Now static.
7929 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7930 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7931 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7932 * lisp.h (fatal_error_signal_hook): Remove decl.
7933 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7934
f44bd759
PE
7935 * editfns.c: Move a (normally-unused) function to its only use.
7936 * editfns.c, lisp.h (get_operating_system_release): Remove.
7937 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7938 worth the hassle of breaking this out.
7939
b532497d
PE
7940 * xterm.c: Make symbols static if they're not exported.
7941 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7942 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7943 (x_destroy_window, x_delete_display):
7944 Now static.
7945 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7946 (x_mouse_leave): Remove; unused.
7947 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7948 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7949 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7950 Remove decls.
7951 (x_mouse_leave): Declare only if WINDOWSNT.
7952 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7953 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7954 USE_X_TOOLKIT.
7955
1675728f
PE
7956 * ftxfont.c: Make symbols static if they're not exported.
7957 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7958 HAVE_FREETYPE.
7959 * font.h (ftxfont_driver): Likewise.
7960
e4cebfca
PE
7961 * xfns.c: Make symbols static if they're not exported.
7962 (x_last_font_name, x_display_info_for_name):
7963 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7964 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7965 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7966 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7967 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7968 (last_show_tip_args): Now static.
7969 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7970 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7971 (x_screen_planes): Remove; unused.
7972 * dispextern.h (x_screen_planes): Remove decl.
7973
5bf46f05
PE
7974 * dispnew.c: Make symbols static if they're not exported.
7975 * dispextern.h (redraw_garbaged_frames, scrolling):
7976 (increment_row_positions): Remove.
7977 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7978 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7979 Now static.
7980 (redraw_garbaged_frames): Remove; unused.
7981
435f4c28
PE
7982 * xfaces.c: Make symbols static if they're not exported.
7983 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7984 Remove decls.
7985 * xterm.h (defined_color): Remove decls.
7986 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7987 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7988 (menu_face_changed_default, defined_color, free_realized_face):
7989 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7990 (ascii_face_of_lisp_face): Remove; unused.
7991
8524aef3
PE
7992 * xdisp.c: Make symbols static if they're not exported.
7993 * dispextern.h (scratch_glyph_row, window_box_edges):
7994 (glyph_to_pixel_coords, set_cursor_from_row):
7995 (get_next_display_element, set_iterator_to_next):
7996 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7997 (show_mouse_face): Remove decls
7998 * frame.h (message_buf_print): Likewise.
7999 * lisp.h (pop_message, set_message, check_point_in_composition):
8000 Likewise.
8001 * xterm.h (set_vertical_scroll_bar): Likewise.
8002 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8003 (message_buf_print, scratch_glyph_row, displayed_buffer):
8004 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8005 (get_next_display_element, show_mouse_face, window_box_edges):
8006 (frame_to_window_pixel_xy, check_point_in_composition):
8007 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8008 (glyph_to_pixel_coords): Remove; unused.
8009
16390cd2
PE
8010 * dired.c (file_name_completion): Now static.
8011
8012 * dbusbind.c (xd_in_read_queued_messages): Now static.
8013
a25f4dfa
PE
8014 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8015 * data.c (circular_list_error): Remove.
8016
14a9c8df
PE
8017 * commands.h (last_point_position, last_point_position_buffer):
8018 (last_point_position_window): Remove decls.
8019 * keyboard.c: Make these variables static.
8020
04f2d78b
CB
8021 * coding.h (coding, code_convert_region, encode_coding_gap):
8022 Remove decls.
74ab6df5
PE
8023 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8024 (iso_code_class, detect_coding, code_convert_region): Now static.
8025 (encode_coding_gap): Remove; unused.
8026
38dfbee1
PE
8027 * chartab.c (chartab_chars, chartab_bits): Now static.
8028
a2cb4e63
PE
8029 * charset.h (charset_iso_8859_1): Remove decl.
8030 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8031 Now static.
8032
127198fd
PE
8033 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8034 * ccl.c (Vccl_program_table): Now static.
8035 (check_ccl_update): Remove; unused.
8036
d85b608f
PE
8037 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8038 * category.h: ... from here.
8039 * category.c (check_category_table, set_category_set): Now static.
8040
31cd66f3
PE
8041 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8042 * lisp.h: Remove these decls.
8043
c358e587
PE
8044 * buffer.c (buffer_count): Remove unused var.
8045
e78aecca
PE
8046 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8047 so that it's not optimized away.
8048 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8049 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8050 exported only to the debugger.
8051
e192d7d3 8052 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8053 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8054
92470028
PE
8055 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8056 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8057 was inaccessible from Lisp.
8058 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8059 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8060
244ed907
PE
8061 alloc.c: Import and export fewer symbols, and remove unused items.
8062 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8063 is defined.
8064 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8065 it's not optimized away by whole-program optimization.
8066 (message_enable_multibyte, free_misc): Remove.
8067 (catchlist, handlerlist, mark_backtrace):
8068 Declare only if BYTE_MARK_STACK.
8069 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8070 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8071 (message_enable_multibyte): Remove decl.
8072 (free_misc, interval_free_list, float_block, float_block_index):
8073 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8074 (cons_free_list, last_marked_index):
8075 Now static.
8076 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8077 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8078 (mark_backtrace): Define only if BYTE_MARK_STACK.
8079 * xdisp.c (message_enable_multibyte): Now static.
8080
61c2b50e 8081 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8082 This makes it easier for human readers (and static analyzers)
8083 to see whether these variables are used from other modules.
8084 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8085 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8086 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8087 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8088 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8089 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8090 * xmenu.c, xselect.c:
8091 Declare Q* vars static if they are not used in other modules.
8092 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8093 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8094 Remove decls of unexported vars.
8095 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8096
95c82688
PE
8097 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8098
16a97296
PE
8099 Make Emacs functions such as Fatom 'static' by default.
8100 This makes it easier for human readers (and static analyzers)
8101 to see whether these functions can be called from other modules.
8102 DEFUN now defines a static function. To make the function external
8103 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8104 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8105 (Finit_image_library):
16a97296
PE
8106 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8107 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8108 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8109 Remove decls, since these functions are now static.
8110 (Funintern, Fget_internal_run_time): New decls, since these functions
8111 were already external.
95c82688 8112
16a97296
PE
8113 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8114 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8115 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8116 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8117 * keyboard.c, keymap.c, lread.c:
8118 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8119 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8120 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8121 Mark functions with DEFUE instead of DEFUN,
8122 if they are used in other modules.
8123 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8124 decls for now-static functions.
8125 * buffer.h (Fdelete_overlay): Remove decl.
8126 * callproc.c (Fgetenv_internal): Mark as internal.
8127 * composite.c (Fremove_list_of_text_properties): Remove decl.
8128 (Fcomposition_get_gstring): New forward static decl.
8129 * composite.h (Fcomposite_get_gstring): Remove decl.
8130 * dired.c (Ffile_attributes): New forward static decl.
8131 * doc.c (Fdocumntation_property): New forward static decl.
8132 * eval.c (Ffetch_bytecode): New forward static decl.
8133 (Funintern): Remove extern decl; now in .h file where it belongs.
8134 * fileio.c (Fmake_symbolic_link): New forward static decl.
8135 * image.c (Finit_image_library): New forward static decl.
8136 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8137 * intervals.h (Fprevious_property_change):
8138 (Fremove_list_of_text_properties): Remove decls.
8139 * keyboard.c (Fthis_command_keys): Remove decl.
8140 (Fcommand_execute): New forward static decl.
8141 * keymap.c (Flookup_key): New forward static decl.
8142 (Fcopy_keymap): Now static.
8143 * keymap.h (Flookup_key): Remove decl.
8144 * process.c (Fget_process): New forward static decl.
8145 (Fprocess_datagram_address): Mark as internal.
8146 * syntax.c (Fsyntax_table_p): New forward static decl.
8147 (skip_chars): Remove duplicate decl.
8148 * textprop.c (Fprevious_property_change): New forward static decl.
8149 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8150 Now internal.
8151 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8152 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8153
785bbd42
PE
8154 * editfns.c (Fformat): Remove unreachable code.
8155
8b913b57
AS
81562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8157
8158 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8159 change. (Bug#8496)
8160
a6744a35
EZ
81612011-04-13 Eli Zaretskii <eliz@gnu.org>
8162
8163 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8164 when at ZV. (Bug#8487)
8165
e7974947
AS
81662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8167
baad03f0
AS
8168 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8169 (Bug#8437)
8170 * keyboard.c (parse_tool_bar_item): Likewise.
8171 * sound.c (sound_cleanup, alsa_close): Likewise.
8172 * termcap.c (tgetent): Likewise.
8173 * xfns.c (x_default_font_parameter): Likewise.
8174 * xsettings.c (read_and_apply_settings): Likewise.
8175
e7974947
AS
8176 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8177 (overrun_check_free): Protoize.
8178
28272684
PE
81792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8180
8181 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8182 since callers should never pass a negative size.
8183 Change the signature to match that of plain 'read' and 'write'; see
8184 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8185 * lisp.h: Update prototypes of emacs_write and emacs_read.
8186
11997c76
EZ
81872011-04-11 Eli Zaretskii <eliz@gnu.org>
8188
8189 * xdisp.c (redisplay_window): Don't try to determine the character
8190 position of the scroll margin if the window start point w->startp
e896f03c 8191 is outside the buffer's accessible region. (Bug#8468)
11997c76 8192
8a2cbd72
EZ
81932011-04-10 Eli Zaretskii <eliz@gnu.org>
8194
8195 Fix write-region and its subroutines for buffers > 2GB.
8196 * fileio.c (a_write, e_write): Modify declaration of arguments and
8197 local variables to support buffers larger than 2GB.
8198 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8199
8200 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8201 argument, local variables, and return value.
8202
8203 * lisp.h: Update prototypes of emacs_write and emacs_read.
8204
8205 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8206
4073e537 82072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8208
1ebfdcb6
PE
8209 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8210
b2ded58d
PE
8211 Fix more problems found by GCC 4.6.0's static checks.
8212
7d66342c
PE
8213 * xdisp.c (vmessage): Use a better test for character truncation.
8214
bbf47d44
PE
8215 * charset.c (load_charset_map): <, not <=, for optimization,
8216 and to avoid potential problems with integer overflow.
9248994d 8217 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8218 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8219 * editfns.c (Fformat): Likewise.
1e69125e 8220 * syntax.c (skip_chars): Likewise.
3befa583 8221
e3019616
PE
8222 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8223 This also lets GCC 4.6.0 generate slightly better loop code.
8224
becfa255
PE
8225 * callint.c (Fcall_interactively): <, not <=, for optimization.
8226 (Fcall_interactively): Count the number of arguments produced,
8227 not the number of arguments given. This is simpler and lets GCC
8228 4.6.0 generate slightly better code.
8229
dae0cd48
PE
8230 * ftfont.c: Distingish more carefully between FcChar8 and char.
8231 The previous code passed unsigned char * to a functions like
8232 strlen and xstrcasecmp that expect char *, which does not
8233 conform to the C standard.
8234 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8235 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8236 char * when the C standard requires it.
8237
76032d70
PE
8238 * keyboard.c (read_char): Remove unused var.
8239
eb3f1cc8
PE
8240 * eval.c: Port to Windows vsnprintf (Bug#8435).
8241 Include <limits.h>.
8242 (SIZE_MAX): Define if the headers do not.
8243 (verror): Do not give up if vsnprintf returns a negative count.
8244 Instead, grow the buffer. This ports to Windows vsnprintf, which
8245 does not conform to C99. Problem reported by Eli Zaretskii.
8246 Also, simplify the allocation scheme, by avoiding the need for
8247 calling realloc, and removing the ALLOCATED variable.
8248
70476b54
PE
8249 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8250
12020a9e
PE
8251 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8252 But keep the doprint source code for now, as we might revamp it
8253 and use it again (Bug#8435).
ea6c7ae6
PE
8254 * lisp.h (doprnt): Remove.
8255 * Makefile.in (base_obj): Remove doprnt.o.
8256 * deps.mk (doprnt.o): Remove.
8257
5fdb398c
PE
8258 error: Print 32- and 64-bit integers portably (Bug#8435).
8259 Without this change, on typical 64-bit hosts error ("...%d...", N)
8260 was used to print both 32- and 64-bit integers N, which relied on
8261 undefined behavior.
61bdb816 8262 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8263 * lisp.h (error, verror): Mark as printf-like functions.
8264 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8265 Report overflow in size calculations when allocating printf buffer.
8266 Do not truncate output string at its first null byte.
8267 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8268 Truncate the output at a character boundary, since vsnprintf does not
8269 do that.
8270 * charset.c (check_iso_charset_parameter): Convert internal
8271 character to string before calling 'error', since %c now has the
8272 printf meaning.
8273 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8274 overflow when computing char to be passed to 'error'. Do not
8275 pass Lisp_Object to 'error'; pass the integer instead.
8276 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8277 formatted with plain %d.
8278
b189fa66
PE
8279 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8280
bff87ef0
PE
8281 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8282
7e2cac20
PE
8283 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8284
ce4d90b5
PE
8285 * xterm.c (x_catch_errors): Remove duplicate declaration.
8286
266c9547
PE
8287 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8288
79c49ad2
PE
8289 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8290
368f4090
JM
82912011-04-10 Jim Meyering <meyering@redhat.com>
8292
8293 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8294 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8295 return ssize_t not "int", and use size_t as the buffer length.
8296 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8297 * gnutls.h: Update declarations.
8298 * process.c (read_process_output): Use ssize_t, to match.
8299 (send_process): Likewise.
8300
a32d4040
CY
83012011-04-09 Chong Yidong <cyd@stupidchicken.com>
8302
8303 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8304
8546720e 83052011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8306
04f2d78b
CB
8307 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8308 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8309
8546720e
GM
8310 * xterm.c (handle_one_xevent):
8311 * xmenu.c (create_and_show_popup_menu):
8312 * xselect.c (x_decline_selection_request)
8313 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8314
0a2f5c1a 83152011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8316
8317 Fix some uses of `int' instead of EMACS_INT.
8318 * search.c (string_match_1, fast_string_match)
8319 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8320 (scan_buffer, find_next_newline_no_quit)
8321 (find_before_next_newline, search_command, Freplace_match)
8322 (Fmatch_data): Make some `int' variables be EMACS_INT.
8323
8324 * xdisp.c (display_count_lines): 3rd argument and return value now
8325 EMACS_INT. All callers changed.
8326 (pint2hrstr): Last argument is now EMACS_INT.
8327
8328 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8329 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8330 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8331 (decode_coding_utf_16, decode_coding_emacs_mule)
8332 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8333 (decode_coding_ccl, decode_coding_charset)
8334 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8335 (decode_coding_iso_2022, decode_coding_emacs_mule)
8336 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8337 <char_offset, last_offset>: Declare EMACS_INT.
8338 (encode_coding_utf_8, encode_coding_utf_16)
8339 (encode_coding_emacs_mule, encode_invocation_designation)
8340 (encode_designation_at_bol, encode_coding_iso_2022)
8341 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8342 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8343 Declare EMACS_INT.
8344 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8345 (encode_invocation_designation): Last argument P_NCHARS is now
8346 EMACS_INT.
8347 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8348 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8349
8350 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8351 All users changed.
8352
8353 * ccl.c (Fccl_execute_on_string): Declare some variables
8354 EMACS_INT.
8355
8546720e 83562011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8357
8358 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8359
4e19a977
CS
83602011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8361
8362 * process.c (Fformat_network_address): Doc fix.
8363
87302331
R
83642011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8365
ee7683eb 8366 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8367
cbb59342
CY
83682011-04-08 Chong Yidong <cyd@stupidchicken.com>
8369
8370 * keyboard.c (read_char): Call Lisp function help-form-show,
8371 instead of using internal_with_output_to_temp_buffer.
8372 (Qhelp_form_show): New var.
e0d38eeb 8373 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8374
8375 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8376
8377 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8378
e67a13ab
CY
83792011-04-06 Chong Yidong <cyd@stupidchicken.com>
8380
04f2d78b
CB
8381 * process.c (Flist_processes): Remove to Lisp.
8382 (list_processes_1): Delete.
e67a13ab 8383
973f782d
EZ
83842011-04-06 Eli Zaretskii <eliz@gnu.org>
8385
7c106b1e
EZ
8386 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8387
973f782d
EZ
8388 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8389
41cf7d1a 83902011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8391
ca23cc88
PE
8392 Fix more problems found by GCC 4.6.0's static checks.
8393
f390e2d5
PE
8394 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8395
42eea0d0
PE
8396 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8397
b69769da 8398 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8399
f9541e84
PE
8400 * xdisp.c (vmessage): Mark as a printf-like function.
8401
13841b55
PE
8402 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8403
c136c10f
PE
8404 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8405
5e2d4a30
PE
8406 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8407 printf-like functions.
8408 (tiff_load): Add casts to remove these marks before passing them
8409 to system-supplied API.
8410
583f48b9
PE
8411 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8412
b25d760e
PE
8413 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8414 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8415 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8416 directly, rather than having caller test rule sign. This avoids
8417 some unnecessary tests.
8418 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8419 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8420 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8421
bc7b6697 8422 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8423 (xfont_open): Avoid unnecessary tests.
bc7b6697 8424
27ccc379
PE
8425 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8426
dcd5c89a
PE
8427 * composite.h, composite.c (composition_gstring_put_cache):
8428 Use EMACS_INT, not int, for length.
8429
b13a45c6
PE
8430 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8431 breaking out part of COMPOSITION_DECODE_RULE.
8432 (COMPOSITION_DECODE_RULE): Use it.
8433 * composite.c (get_composition_id): Remove unused local vars,
8434 by using the new macro.
8435
1e792e4d
PE
8436 * textprop.c (set_text_properties_1): Change while to do-while,
8437 since the condition is always true at first.
8438
dc6c6455 8439 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8440 (interval_deletion_adjustment): Return unsigned value.
8441 All uses changed.
dc6c6455 8442
aba7731a
PE
8443 * process.c (list_processes_1, create_pty, read_process_output):
8444 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8445 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8446 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8447 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8448 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8449
fdfc4bf3
PE
8450 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8451
fca8fe46 8452 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8453 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8454
06a0259a 8455 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8456 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8457 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8458
e7b9e80f
PE
8459 * print.c (print_error_message): Avoid int overflow.
8460
56201685
PE
8461 * font.c (font_list_entities): Redo for clarity,
8462 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8463
78834453 8464 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8465 (font_score): Avoid potential overflow in diff calculation.
78834453 8466
0bc0b309 8467 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8468 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8469
e610eaca
PE
8470 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8471
b895abce
PE
8472 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8473 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8474 can always succeed if overflow has undefined behavior.
8475
1f1d9321 8476 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8477 (wordify): Omit three unnecessary tests.
1f1d9321 8478
c59478bc
PE
8479 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8480 All callers changed. This avoids the need for an unused var.
8481
79b73827
PE
8482 * casefiddle.c (casify_region): Remove var that is set but not used.
8483
a4db5dfe
PE
8484 * dired.c (file_name_completion): Remove var that is set but not used.
8485
43aae36e
PE
8486 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8487
2a47c44d 8488 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8489 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8490
a37c69bf
PE
8491 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8492 Check for integer overflow on size calculations.
8493
328ab8e7
PE
8494 * buffer.c (Fprevious_overlay_change): Remove var that is set
8495 but not used.
8496
e5a2a5cb
PE
8497 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8498 Remove vars that are set but not used.
8d84a6eb 8499 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8500 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8501
a60e5f68
PE
8502 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8503
f661cb61 8504 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8505 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8506
f0397f5a
PE
8507 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8508 that are set but not used.
8509
8664db06 8510 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8511 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8512
6abdaa4a
PE
8513 * xselect.c (x_get_local_selection, x_handle_property_notify):
8514 Remove vars that are set but not used.
8515
0ce7538d 8516 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8517 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8518
9ae848fc
PE
8519 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8520 Remove var that is set but not used.
0b918413
PE
8521 (scroll_bar_windows_size): Now size_t, not int.
8522 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8523 Check for overflow.
9ae848fc 8524
a5a62657
PE
8525 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8526 (map_tty_color) [!defined MSDOS]: Likewise.
8527
5c5cdd39
PE
8528 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8529
66ebf983
PE
8530 * coding.c: Remove vars that are set but not used.
8531 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8532 All callers changed.
8533 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8534 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8535 (decode_coding_charset): Remove vars that are set but not used.
8536
1be4d761
PE
8537 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8538 that is set but not used.
8539
47553fa8
PE
8540 * print.c (print_object): Remove var that is set but not used.
8541
1f7196bf 8542 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8543 The gnulib version avoids calling malloc in the usual case,
8544 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8545 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8546 * filelock.c (current_lock_owner): Likewise.
8547 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8548 * sysdep.c: Include allocator.h, careadlinkat.h.
8549 (emacs_no_realloc_allocator): New static constant.
8550 (emacs_readlink): New function.
fdb61804
PE
8551 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8552 ../lib/careadlinkat.h.
d1fdcab7 8553
f84c17c7
SM
85542011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8555
8556 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8557 first non-nil return value).
8558
ef3862ad
JD
85592011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8560
8561 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8562 if not defined (Bug#8403).
8563
376a7006
JB
85642011-04-02 Juanma Barranquero <lekktu@gmail.com>
8565
8566 * xdisp.c (display_count_lines): Remove parameter `start',
8567 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8568 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8569 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8570 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8571 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8572 and thereabouts. All callers changed.
8573 (get_per_char_metric): Remove parameter `f', unused since
8574 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8575
6ca3801d
JM
85762011-04-02 Jim Meyering <meyering@redhat.com>
8577
8578 do not dereference NULL upon failed strdup
8579 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8580 (ns_get_family): Likewise.
8581
d8e2b5ba
JB
85822011-04-02 Juanma Barranquero <lekktu@gmail.com>
8583
8584 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8585
8c74fcbd
JD
85862011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8587
8588 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8589 later (Bug#8403).
8590
7200d79c
SM
85912011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8592
03408648 8593 Add lexical binding.
7200d79c 8594
03408648
SM
8595 * window.c (Ftemp_output_buffer_show): New fun.
8596 (Fsave_window_excursion):
8597 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8598
8599 * lread.c (lisp_file_lexically_bound_p): New function.
8600 (Fload): Bind Qlexical_binding.
8601 (readevalloop): Remove `evalfun' arg.
8602 Bind Qinternal_interpreter_environment.
8603 (Feval_buffer): Bind Qlexical_binding.
8604 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8605 Mark as dynamic.
8606 (syms_of_lread): Declare `lexical-binding'.
8607
8608 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8609
8610 * keyboard.c (eval_dyn): New fun.
8611 (menu_item_eval_property): Use it.
ca105506
SM
8612
8613 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8614
03408648
SM
8615 * fns.c (concat, mapcar1): Accept byte-code-functions.
8616
8617 * eval.c (Fsetq): Handle lexical vars.
8618 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8619 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8620 (FletX, Flet): Obey lexical binding.
8621 (Fcommandp): Handle closures.
8622 (Feval): New `lexical' arg.
8623 (eval_sub): New function extracted from Feval. Use it almost
8624 everywhere where Feval was used. Look up vars in lexical env.
8625 Handle closures.
8626 (Ffunctionp): Move from subr.el.
8627 (Ffuncall): Handle closures.
8628 (apply_lambda): Remove `eval_flags'.
8629 (funcall_lambda): Handle closures and new byte-code-functions.
8630 (Fspecial_variable_p): New function.
8631 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8632 but without exporting it to Lisp.
23aba0ea 8633
23aba0ea 8634 * doc.c (Fdocumentation, store_function_docstring):
03408648 8635 * data.c (Finteractive_form): Handle closures.
23aba0ea 8636
03408648
SM
8637 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8638 interactive spec.
ba83908c 8639
04f2d78b
CB
8640 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8641 New byte-codes.
03408648
SM
8642 (exec_byte_code): New function extracted from Fbyte_code to handle new
8643 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8644
03408648 8645 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8646
03408648 8647 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8648
e2abce01
JB
86492011-03-31 Juanma Barranquero <lekktu@gmail.com>
8650
8651 * xdisp.c (redisplay_internal): Fix prototype.
8652
63696a73 86532011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8654
63696a73 8655 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8656 (try_scrolling): Use it when setting scroll_limit.
8657 Limit scrolling to 100 screen lines.
63696a73
EZ
8658 (redisplay_window): Even when falling back on "recentering",
8659 position point in the window according to scroll-conservatively,
8660 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8661
8662 (try_scrolling): When point is above the window, allow searching
8663 as far as scroll_max, or one screenful, to compute vertical
8664 distance from PT to the scroll margin position. This prevents
8665 try_scrolling from unnecessarily failing when
8666 scroll-conservatively is set to a value slightly larger than the
8667 window height. Clean up the case of PT below the margin at bottom
8668 of window: scroll_max can no longer be INT_MAX. When aggressive
8669 scrolling is in use, don't let point enter the opposite scroll
8670 margin as result of the scroll.
8671 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8672 threshold of 100 lines for never-recentering scrolling.
8673
e4cc2dfc
JB
86742011-03-31 Juanma Barranquero <lekktu@gmail.com>
8675
8676 * dispextern.h (move_it_by_lines):
8677 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8678 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8679 (message_log_check_duplicate): Remove parameters `prev_bol' and
8680 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8681 (redisplay_internal): Remove parameter `preserve_echo_area',
8682 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8683
8684 * indent.c (Fvertical_motion):
8685 * window.c (window_scroll_pixel_based, Frecenter):
8686 Don't pass `need_y_p' to `move_it_by_lines'.
8687
1c470562
SM
86882011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8689
44f230aa
SM
8690 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8691 steal a few bits to be more compact.
8692 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8693 Remove unneeded casts.
8694
1c470562
SM
8695 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8696
888adce9
ZK
86972011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8698
8699 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8700 binding" message (bug#7967).
8701
f838ed7b
PE
87022011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8703
77861b95
PE
8704 Fix more problems found by GCC 4.6.0's static checks.
8705
de6dbc14
PE
8706 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8707 Remove unused local var.
8708
f838ed7b
PE
8709 * editfns.c (Fmessage_box): Remove unused local var.
8710
792c7b2b
PE
8711 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8712 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8713 Omit unused local vars.
c499e557 8714 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8715 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8716 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8717 Omit unused local var.
8718
ba0165e1
PE
8719 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8720 Don't assume string length fits in int.
32ad8845 8721 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8722 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8723
3c59b4c9
PE
8724 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8725 instead of alloca (Bug#8344).
8726
a3eed478 8727 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8728 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8729
eb4d412d
PE
8730 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8731
1658b401
PE
8732 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8733 concerns.
8734
8735 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8736
8737 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8738
9a2c6e05
PE
8739 * keyboard.c (syms_of_keyboard): Use the same style as later
8740 in this function when indexing through an array. This also
8741 works around GCC bug 48267.
8742
03d0a109
PE
8743 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8744
44f730c8
PE
8745 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8746
fe75f926
PE
8747 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8748 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8749
ffa8c828
PE
8750 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8751 This avoids undefined behavior on integer overflow, and is a bit
8752 more convenient anyway since it is compared to a size_t variable.
8753
c5101a77
PE
8754 Variadic C functions now count arguments with size_t, not int.
8755 This avoids an unnecessary limitation on 64-bit machines, which
8756 caused (substring ...) to crash on large vectors (Bug#8344).
8757 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8758 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8759 All variadic functions and their callers changed accordingly.
c5101a77
PE
8760 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8761 * data.c (arith_driver, float_arith_driver): Likewise.
8762 * editfns.c (general_insert_function): Likewise.
8763 * eval.c (struct backtrace.nargs, interactive_p)
8764 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8765 (funcall_lambda, mark_backtrace): Likewise.
8766 * fns.c (concat): Likewise.
8767 * frame.c (x_set_frame_parameters): Likewise.
8768 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8769 0 if not found, not -1. All callers changed.
8770
dd3f25f7
PE
8771 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8772 (stack_copy_size): Now size_t, not int.
8773 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8774
461c2ab9
JB
87752011-03-28 Juanma Barranquero <lekktu@gmail.com>
8776
8777 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8778 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8779 All callers changed.
8780
8781 * lisp.h (multibyte_char_to_unibyte):
8782 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8783 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8784 * character.h (CHAR_TO_BYTE8):
8785 * cmds.c (internal_self_insert):
8786 * editfns.c (general_insert_function):
8787 * keymap.c (push_key_description):
8788 * search.c (Freplace_match):
8789 * xdisp.c (message_dolog, set_message_1): All callers changed.
8790
f6d62986
SM
87912011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8792
8793 * keyboard.c (safe_run_hook_funcall): New function.
8794 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8795 don't set the hook to nil, but remove the offending function instead.
8796 (Qcommand_hook_internal): Remove, unused.
8797 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8798 Vcommand_hook_internal.
8799
8800 * eval.c (enum run_hooks_condition): Remove.
8801 (funcall_nil, funcall_not): New functions.
8802 (run_hook_with_args): Call each function through a `funcall' argument.
8803 Remove `cond' argument, now redundant.
8804 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8805 (Frun_hook_with_args_until_failure): Adjust accordingly.
8806 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8807
1db5b1ad
JB
88082011-03-28 Juanma Barranquero <lekktu@gmail.com>
8809
8810 * dispextern.h (string_buffer_position): Remove declaration.
8811
8812 * print.c (strout): Remove parameter `multibyte', unused since
8813 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8814
8815 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8816 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8817 All callers changed.
8818
8819 * w32.c (_wsa_errlist): Use braces for struct initializers.
8820
8821 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8822 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8823 All callers changed.
8824 (string_buffer_position): Likewise. Also, make static (it's never
8825 used outside xdisp.c).
8826 (cursor_row_p): Remove parameter `w', unused since
8827 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8828 (decode_mode_spec): Remove parameter `precision', introduced during
8829 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8830 All callers changed.
8831
5ffb62aa
JD
88322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8833
8834 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8835
461c2ab9 88362011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8837
8838 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8839 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8840 (ns_update_auto_hide_menu_bar): New functions.
8841 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8842 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8843 ns_constrain_all_frames.
8844 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8845 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8846
5c380ffb
JD
88472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8848
8849 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8850
9af30bdf
GM
88512011-03-27 Glenn Morris <rgm@gnu.org>
8852
8853 * syssignal.h: Replace RETSIGTYPE with void.
8854 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8855 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8856 Replace SIGTYPE with void everywhere.
8857 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8858 * s/template.h (SIGTYPE): Remove commented out definition.
8859
e2abce01
JB
88602011-03-26 Eli Zaretskii <eliz@gnu.org>
8861
8862 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8863 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8864
f868cd8a
JB
88652011-03-26 Juanma Barranquero <lekktu@gmail.com>
8866
59eb0929
JB
8867 * w32.c (read_unc_volume): Use parameter `henum', instead of
8868 global variable `wget_enum_handle'.
8869
8870 * keymap.c (describe_vector): Remove parameters `indices' and
8871 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8872 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8873
f868cd8a
JB
8874 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8875
8876 * keyboard.c (timer_check): Remove parameter `do_it_now',
8877 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8878 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8879 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8880
8881 * keyboard.c (read_char):
8882 * w32menu.c (w32_menu_display_help):
8883 * xmenu.c (show_help_event, menu_help_callback):
8884 Adjust calls to `show_help_echo'.
8885
8886 * gtkutil.c (xg_maybe_add_timer):
8887 * keyboard.c (readable_events):
8888 * process.c (wait_reading_process_output):
8889 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8890
8891 * insdel.c (adjust_markers_gap_motion):
8892 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8893 (gap_left, gap_right): Don't call it.
8894
2ecf6fdb
CY
88952011-03-25 Chong Yidong <cyd@stupidchicken.com>
8896
8897 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8898 incurred during fontification.
8899
6b1f9ba4
JB
89002011-03-25 Juanma Barranquero <lekktu@gmail.com>
8901
8902 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8903 (DEFVAR_PER_BUFFER): Don't pass it.
8904
8905 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8906 (scrolling_window): Don't pass it.
8907
0f4a96b5
JB
89082011-03-25 Juanma Barranquero <lekktu@gmail.com>
8909
8910 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8911
8912 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8913 and `suffix'.
8914 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8915 of variables specific to SELinux and computation of `encoded_absname'.
8916
8917 * image.c (XPutPixel): Remove unused variable `height'.
8918
8919 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8920
8921 * unexw32.c (get_section_info): Remove unused variable `section'.
8922
8923 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8924 (system_process_attributes): Remove unused variable `sess'.
8925 (sys_read): Remove unused variable `err'.
8926
8927 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8928 (w32_wnd_proc): Remove unused variable `isdead'.
8929 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8930 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8931 (x_create_tip_frame): Remove unused variable `tem'.
8932
8933 * w32inevt.c (w32_console_read_socket):
8934 Remove unused variable `no_events'.
8935
8936 * w32term.c (x_draw_composite_glyph_string_foreground):
8937 Remove unused variable `width'.
8938
1149507c
JB
89392011-03-24 Juanma Barranquero <lekktu@gmail.com>
8940
8941 * w32term.c (x_set_glyph_string_clipping):
8942 Don't pass uninitialized region to CombineRgn.
8943
9c88f339
JB
89442011-03-23 Juanma Barranquero <lekktu@gmail.com>
8945
8946 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8947 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8948 (Fx_close_connection): Remove unused variable `i'.
8949
8950 * w32font.c (w32font_draw): Return number of glyphs.
8951 (w32font_open_internal): Remove unused variable `i'.
8952 (w32font_driver): Add missing initializer.
8953
8954 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8955 (fill_in_menu): Remove unused variable `items_added'.
8956
8957 * w32term.c (last_mouse_press_frame): Remove static global variable.
8958 (w32_clip_to_row): Remove unused variable `f'.
8959 (x_delete_terminal): Remove unused variable `i'.
8960
8961 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8962 (NOTHING): Remove unused static global variable.
8963 (uniscribe_check_otf): Remove unused variable `table'.
8964 (uniscribe_font_driver): Add missing initializers.
8965
dee091a3
JD
89662011-03-23 Julien Danjou <julien@danjou.info>
8967
8968 * term.c (Fsuspend_tty, Fresume_tty):
8969 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8970 * window.c (temp_output_buffer_show):
8971 * insdel.c (signal_before_change):
8972 * frame.c (Fhandle_switch_frame):
8973 * fileio.c (Fdo_auto_save):
8974 * emacs.c (Fkill_emacs):
8975 * editfns.c (save_excursion_restore):
8976 * cmds.c (internal_self_insert):
8977 * callint.c (Fcall_interactively):
8978 * buffer.c (Fkill_all_local_variables):
8979 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8980 Use Frun_hooks.
0f4a96b5 8981 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8982 unconditionally since it does the check itself.
dee091a3 8983
2c520ab5 89842011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8985
c9c49752
PE
8986 Fix more problems found by GCC 4.5.2's static checks.
8987
8abc3f12
PE
8988 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8989 the first time through the loop, since we know p0 < p1 then.
8990 This also avoids a gcc -Wstrict-overflow warning.
8991
a2d26660
PE
8992 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8993 leading to a memory leak, possible in functions like
8994 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8995 of objects (Bug#8318).
a2d26660 8996
916c72e9
PE
8997 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8998 that could (at least in theory) be that large.
8999
19ab8a18
PE
9000 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9001 This is less likely to overflow, and avoids undefined behavior if
9002 overflow does occur. All callers changed. Use strtoul to scan
9003 for the unsigned long integer.
b7cbbd6f
PE
9004 (pint2hrstr): Simplify and tune code slightly.
9005 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9006
f0641eff
PE
9007 * scroll.c (do_scrolling): Work around GCC bug 48228.
9008 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9009
7f650bb9
PE
9010 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9011 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9012 (validate_x_resource_name): Simplify count usage.
9013 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9014
37dd57d1
PE
9015 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9016 fail (Bug#8306).
81e56e61 9017
699979fc 9018 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9019
401bf9b4
PE
9020 * process.c (Fmake_network_process): Use socklen_t, not int,
9021 where POSIX says socklen_t is required in portable programs.
9022 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9023 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9024 (Fmake_network_process, server_accept_connection):
9025 (wait_reading_process_output, read_process_output):
9026 Likewise.
9027
b93aacde
PE
9028 * process.c: Rename or move locals to avoid shadowing.
9029 (list_processes_1, Fmake_network_process):
9030 (read_process_output_error_handler, exec_sentinel_error_handler):
9031 Rename or move locals.
4dc343ee 9032 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9033 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9034 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9035 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9036 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9037
af8a867c 9038 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9039 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9040 Include tparam.h instead, since it declares them.
af8a867c
PE
9041 * cm.h (PC): Remove extern decl; tparam.h now does this.
9042 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9043 * terminfo.c: Include tparam.h, to check interfaces.
9044 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9045 (tparam): Adjust signature to match interface in tparam.h;
9046 this removes some undefined behavior. Check that outstring and len
9047 are zero, which they always are with Emacs.
9048 * tparam.h (PC, BC, UP): New extern decls.
9049
0248044d 9050 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9051 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9052
8ff096c1 9053 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9054 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9055 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9056 (ftfont_list): Remove unused local.
49eaafba
PE
9057 (get_adstyle_property, ftfont_pattern_entity):
9058 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9059 Rename locals to avoid shadowing.
8ff096c1 9060
e2be39f6
PE
9061 * xfont.c (xfont_list_family): Mark var as initialized.
9062
c9735e30
PE
9063 * xml.c (make_dom): Now static.
9064
8f5201ae
PE
9065 * composite.c (composition_compute_stop_pos): Rename local to
9066 avoid shadowing.
b246f932
PE
9067 (composition_reseat_it): Remove unused locals.
9068 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9069 (composition_update_it): Mark var as initialized.
11b61122
PE
9070 (find_automatic_composition): Mark vars as initialized,
9071 with a FIXME (Bug#8290).
8f5201ae 9072
760fbc2c
PE
9073 character.h: Rename locals to avoid shadowing.
9074 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9075 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9076 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9077 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9078 to avoid shadowing.
9079
ff08eb85
PE
9080 * textprop.c (property_change_between_p): Remove; unused.
9081
fc7bf025
PE
9082 * intervals.c (interval_start_pos): Now static.
9083
235d7abc
PE
9084 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9085
44f230aa
SM
9086 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9087 Rename locals to avoid shadowing.
3e7d6594 9088
50060332
PE
9089 * sound.c (wav_play, au_play, Fplay_sound_internal):
9090 Fix pointer signedness.
d01f234b 9091 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9092 (wav_play): Initialize a variable to 0, to prevent undefined
9093 behavior (Bug#8278).
50060332 9094
c4fc4e30
PE
9095 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9096
918436ed
PE
9097 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9098
c939f91b
PE
9099 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9100 clobbering (Bug#8298).
b9c7f648
PE
9101 * sysdep.c (sys_subshell): Likewise.
9102 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9103
6bd8c144
PE
9104 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9105 This should get cleaned up, so that child_setup has the
9106 same signature on all platforms.
9107
7710357c 9108 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9109 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9110
c59da222
CY
91112011-03-22 Chong Yidong <cyd@stupidchicken.com>
9112
9113 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9114 not to be necessary, and produces flickering.
9115
66b87493
GM
91162011-03-20 Glenn Morris <rgm@gnu.org>
9117
9118 * config.in: Remove file.
9119
45b6f6d5
JB
91202011-03-20 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9123 are now in src/globals.h.
9124 (syms_of_minibuf): Remove spurious & from previous change.
9125
cd394be1 91262011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9127
9128 * minibuf.c (completing-read-function): New variable.
9129 (completing-read-default): Rename from completing-read.
9130 (completing-read): Call completing-read-function.
9131
b14e3e21
CY
91322011-03-19 Juanma Barranquero <lekktu@gmail.com>
9133
9134 * xfaces.c (Fx_load_color_file):
9135 Read color file from absolute filename (bug#8250).
9136
f2b726e6
JB
91372011-03-19 Juanma Barranquero <lekktu@gmail.com>
9138
9139 * makefile.w32-in: Update dependencies.
9140
09f6ff02
EZ
91412011-03-17 Eli Zaretskii <eliz@gnu.org>
9142
9143 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9144
29a6015a
PE
91452011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9146
a3a6c54e
PE
9147 Fix more problems found by GCC 4.5.2's static checks.
9148
b766f867
PE
9149 * process.c (make_serial_process_unwind, send_process_trap):
9150 (sigchld_handler): Now static.
9151
be02381c
PE
9152 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9153 That way, the code declares only the vars that it needs.
9154 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9155 * s/cygwin.h (PTY_ITERATION): Likewise.
9156 * s/darwin.h (PTY_ITERATION): Likewise.
9157 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9158
57048744
PE
9159 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9160 * process.c (allocate_pty): Don't declare stb unless it's needed.
9161
7914961c 9162 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9163 (CONSTANTLIM): Remove; unused.
9164 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9165 Define only if needed.
7914961c 9166
b3967b18
PE
9167 * unexelf.c (unexec): Name an expression,
9168 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9169 Use a different way to cause a compilation error if anyone uses
9170 n rather than nn, a way that does not involve shadowing.
73366a00 9171 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9172
29a6015a
PE
9173 * deps.mk (unexalpha.o): Remove; unused.
9174
43cfc33e 9175 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9176 * unexec.h: New file.
ce701a33
PE
9177 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9178 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9179 Depend on unexec.h.
9180 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9181 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9182 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9183 Change as necessary to match prototype in unexec.h.
ce701a33 9184
01f44d5a
PE
9185 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9186 shadowing.
4f63c6bb 9187 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9188
a6670b0b
PE
9189 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9190 Rename locals to avoid shadowing.
9191
cef2010d 9192 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9193 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9194
d4d7173a
PE
9195 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9196
f08b802a
PE
9197 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9198 warning when compiling print.c.
9199
3ddb0639
PE
9200 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9201 instead of using an uninitialized var.
5ad03b97 9202 (font_sort_entities): Mark var as initialized.
3ddb0639 9203
170a2692
PE
9204 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9205
e663c700
PE
9206 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9207 pointers to constants.
89bc529a 9208 (font_parse_fcname): Remove unused vars.
7b81e2d0 9209 (font_delete_unmatched): Now static.
ea838e10 9210 (font_get_spec): Remove; unused.
13a547c6
PE
9211 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9212 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9213 Rename or move locals to avoid shadowing.
e663c700 9214
2a80c887 9215 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9216 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9217
1384fa33 9218 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9219 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9220
8b2c52e9
PE
9221 * alloc.c (mark_backtrace): Move decl from here ...
9222 * lisp.h: ... to here, so that it can be checked.
9223
475545b5 9224 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9225 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9226 (lisp_indirect_variable): Name an expression,
9227 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9228 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9229
b1349114 9230 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9231 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9232 Use const pointer when appropriate.
b1349114 9233
a2928364
PE
9234 * lisp.h (get_system_name, get_operating_system_release):
9235 Move decls here, to check interfaces.
9236 * process.c (get_operating_system_release): Move decl to lisp.h.
9237 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9238 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9239 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9240 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9241 (Fformat_time_string, Fencode_time, Finsert_char):
9242 (Ftranslate_region_internal, Fformat):
9243 Rename or remove local vars to avoid shadowing.
9710023e 9244 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9245
a415e694
PE
9246 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9247 avoid shadowing.
9248
8ef4622d
PE
9249 * lisp.h (eassert): Check that the argument compiles, even if
9250 ENABLE_CHECKING is not defined.
9251
946f9a5b
PE
9252 * data.c (Findirect_variable): Name an expression, to avoid
9253 gcc -Wbad-function-cast warning.
112396d6 9254 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9255 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9256 (Fmake_variable_buffer_local, Fmake_local_variable):
9257 Mark variables as initialized.
52746918 9258 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9259
e5aab7e7 9260 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9261 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9262 Rename locals to avoid shadowing.
dff45157
PE
9263 (mark_stack): Move local variables into the #ifdef region where
9264 they're used.
7bc26fdb
PE
9265 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9266 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9267 needed otherwise.
9268 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9269 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9270 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9271
e5aab7e7
PE
9272 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9273 avoids undefined behavior in theory.
9274
4da60324
PE
9275 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9276
88043301
PE
9277 Use functions, not macros, for up- and down-casing (Bug#8254).
9278 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9279 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9280 to use the following functions instead of these macros.
9281 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9282 EMACS_INT, since callers assume the returned value fits in int.
9283 (upcase1): Likewise, for UPCASE_TABLE.
9284 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9285 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9286 the race-condition problem in the old DOWNCASE.
88043301 9287
19ed5445
PE
9288 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9289 Rename locals to avoid shadowing.
9290 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9291 (regex_compile, re_search_2, re_match_2_internal):
9292 Remove unused local vars.
952db0d7
PE
9293 (FREE_VAR): Rewrite so as not to use empty "else",
9294 which gcc can warn about.
da053e48 9295 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9296 (RETALLOC_IF): Define only if needed.
9297 (WORDCHAR_P): Likewise. This one is never needed, but is used
9298 only in a comment talking about a compiler bug, so put inside
9299 the #if 0 of that comment.
9300 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9301 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9302 Remove; unused.
19ed5445 9303
1f3561e4 9304 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9305 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9306 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9307
ded6f8f7
PE
9308 * search.c (simple_search): Remove unused var.
9309
dbd37a95
PE
9310 * dired.c (compile_pattern): Move decl from here ...
9311 * lisp.h: ... to here, so that it can be checked.
9312 (struct re_registers): New forward decl.
9313
7e47afad
PE
9314 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9315
85f24f61
PE
9316 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9317 All uses changed.
9318 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9319 Rename locals to avoid shadowing.
5671df8f 9320 (Fvertical_motion): Mark locals as initialized.
85f24f61 9321
181aa2be 9322 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9323 (casify_region): Mark local as initialized.
181aa2be 9324
930d429c
PE
9325 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9326
7082eac6
PE
9327 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9328 New macros, so that the caller can use some names other than
9329 gcpro1, gcpro2, etc.
9330 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9331 of the new macros.
9332 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9333 argument, for consistency with GCPRO2_VAR, etc: it is now the
9334 prefix of the variable, not the variable itself. All uses
9335 changed.
38b2c076
PE
9336 * dired.c (directory_files_internal, file_name_completion):
9337 Rename locals to avoid shadowing.
9338
15206ed9
PE
9339 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9340 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9341 dired.c's scmp function, had undefined behavior.
9342 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9343 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9344 * buffer.h: ... to here, because these macros use current_buffer,
9345 and the new implementation with inline functions needs to have
9346 current_buffer in scope now, rather than later when the macros
9347 are used.
9348 (downcase, upcase1): New static inline functions.
9349 (DOWNCASE, UPCASE1): Reimplement using these functions.
9350 This avoids undefined behavior in expressions like
9351 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9352 from race conditions in accessing the global variables
9353 case_temp1 and case_temp2.
9354 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9355 * lisp.h (case_temp1, case_temp2): Remove their decls.
9356 * character.h (ASCII_CHAR_P): Move from here ...
9357 * lisp.h: ... to here, so that the inline functions mentioned
9358 above can use them.
9359
4a6bea26
PE
9360 * dired.c (directory_files_internal_unwind): Now static.
9361
f14b7e14
PE
9362 * fileio.c (file_name_as_directory, directory_file_name):
9363 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9364 Now static.
2893f146
PE
9365 (file_name_as_directory): Use const pointers when appropriate.
9366 (Fexpand_file_name): Likewise. In particular, newdir might
9367 point at constant storage, so make it a const pointer.
fd4ead52 9368 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9369 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9370 signedness issues.
f839df0c
PE
9371 (Fset_file_times, Finsert_file_contents, auto_save_error):
9372 Rename locals to avoid shadowing.
f14b7e14 9373
5716756e 9374 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9375 (Ftry_completion, Fall_completions): Rename or remove locals
9376 to avoid shadowing.
5716756e 9377
b4c3046a
PE
9378 * marker.c (bytepos_to_charpos): Remove; unused.
9379
b45db522
PE
9380 * lisp.h (verify_bytepos, count_markers): New decls,
9381 so that gcc does not warn that these functions aren't declared.
9382
85876d07
PE
9383 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9384 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9385 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9386 (copy_text): Remove unused local var.
85876d07 9387
03d78a21 9388 * filelock.c (within_one_second): Now static.
b3dd38ab 9389 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9390
5df8f01b
PE
9391 * buffer.c (fix_overlays_before): Mark locals as initialized.
9392 (fix_start_end_in_overlays): Likewise. This function should be
9393 simplified by using pointers-to-pointers, but that's a different
9394 matter.
b1d876f1 9395 (switch_to_buffer_1): Now static.
8f54f30a
PE
9396 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9397 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9398
a70072c9 9399 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9400 Fix pointer signedness issue.
edced198
PE
9401 (sys_subshell): Mark local as volatile if checking for lint,
9402 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9403 (MAXPATHLEN): Define only if needed.
a70072c9 9404
a0977c44
PE
9405 * process.c (serial_open, serial_configure): Move decls from here ...
9406 * systty.h: ... to here, so that they can be checked.
9407
a884fdcc
PE
9408 * fns.c (get_random, seed_random): Move extern decls from here ...
9409 * lisp.h: ... to here, so that they can be checked.
9410
604efe86 9411 * sysdep.c (reset_io): Now static.
b8950c94 9412 (wait_for_termination_signal): Remove; unused.
604efe86 9413
38fc62d9
PE
9414 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9415 (copy_keymap_item, append_key, push_text_char_description):
9416 Now static.
1004a21a 9417 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9418 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9419 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9420 (describe_map_tree):
9421 Rename locals to avoid shadowing.
38fc62d9 9422
2f2650da
PE
9423 * keyboard.c: Declare functions static if they are not used elsewhere.
9424 (echo_char, echo_dash, cmd_error, top_level_2):
9425 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9426 (read_char, kbd_buffer_get_event, make_lispy_position):
9427 (make_lispy_event, make_lispy_movement, apply_modifiers):
9428 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9429 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9430 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9431 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9432 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9433
a053e86c 9434 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9435 (mark_kboards): Move decl here ...
9436 * alloc.c (mark_kboards): ... from here.
a053e86c 9437
4752793e
PE
9438 * lisp.h (force_auto_save_soon): New decl.
9439
74f10ca7 9440 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9441 (DEFINE_DUMMY_FUNCTION): New macro.
9442 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9443 Use it.
c03cd23f
PE
9444 (main): Add casts to avoid warnings
9445 if GCC considers string literals to be constants.
74f10ca7 9446
022e70d4
PE
9447 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9448
59d6fe83
PE
9449 * dbusbind.c: Pointer signedness fixes.
9450 (xd_signature, xd_append_arg, xd_initialize):
9451 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9452 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9453 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9454 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9455
78320123
PE
9456 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9457 if GCC considers string literals to be constants.
49cebcca 9458 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9459
35ac2a97
SM
94602011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9461
fb103ca9
SM
9462 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9463 (print_preprocess, print_object): New macro to fix last change.
9464
35ac2a97
SM
9465 * print.c (print_preprocess): Don't forget font objects.
9466
62973b41
JB
94672011-03-16 Juanma Barranquero <lekktu@gmail.com>
9468
9469 * emacs.c (USAGE3): Doc fixes.
9470
0e48bb22
AS
94712011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9472
9473 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9474 structure.
9475
7684e57b
JB
94762011-03-14 Juanma Barranquero <lekktu@gmail.com>
9477
9478 * lisp.h (VWindow_system, Qfile_name_history):
9479 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9480 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9481 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9482
9483 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9484 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9485
9486 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9487 * w32console.c (detect_input_pending, read_input_pending)
9488 (encode_terminal_code):
9489 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9490 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9491 (w32_system_caret_y, Qfile_name_history):
9492 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9493 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9494 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9495 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9496 * w32proc.c (Qlocal, report_file_error):
9497 * w32term.c (Vwindow_system, updating_frame):
9498 * w32uniscribe.c (initialized, uniscribe_font_driver):
9499 Remove unneeded extern declarations.
9500
2aa46d6c
CY
95012011-03-14 Chong Yidong <cyd@stupidchicken.com>
9502
c96bbc66 9503 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9504
cffc6f3b
CY
95052011-03-13 Chong Yidong <cyd@stupidchicken.com>
9506
9507 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9508 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9509 These macros can no longer be used for assignment.
9510
44f230aa
SM
9511 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9512 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9513 (record_buffer_markers, fetch_buffer_markers): New functions for
9514 recording and fetching special buffer markers.
9515 (set_buffer_internal_1, set_buffer_temp): Use them.
9516
9517 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9518
9519 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9520
9521 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9522 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9523
9524 * xdisp.c (hscroll_window_tree):
9525 (reconsider_clip_changes): Use PT instead of BUF_PT.
9526
d251f04b
EZ
95272011-03-13 Eli Zaretskii <eliz@gnu.org>
9528
9529 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9530 $(EMACS_ROOT)/lib/intprops.h.
9531
f0c77cd1
PE
95322011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9533
3eca4629
PE
9534 Fix more problems found by GCC 4.5.2's static checks.
9535
7c86ee98
PE
9536 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9537 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9538 (xg_free_frame_widgets): Make it clear that a local variable is
9539 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9540 (gdk_window_get_screen): Make it clear that this macro is needed
9541 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9542 (int_gtk_range_get_value): New function, which avoids a diagnostic
9543 from gcc -Wbad-function-cast.
9544 (xg_set_toolkit_scroll_bar_thumb): Use it.
9545 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9546 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9547 (get_utf8_string, xg_get_file_with_chooser):
9548 Rename locals to avoid shadowing.
9549 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9550
41729b81
PE
9551 * xgselect.c (xg_select): Remove unused var.
9552
f0c77cd1
PE
9553 * image.c (four_corners_best): Mark locals as initialized.
9554 (gif_load): Initialize transparent_p to zero (Bug#8238).
9555 Mark another local as initialized.
ec6cf4c6 9556 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9557
ce0ad53d 9558 * image.c (clear_image_cache): Now static.
d5d5a617 9559 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9560 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9561 (x_edge_detection): Remove unnecessary cast that
9562 gcc -Wbad-function-cast diagnoses.
2037898d 9563 (gif_load): Fix pointer signedness.
6ae141d6
PE
9564 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9565 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9566
33383987 95672011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9568
d32df629
PE
9569 Improve quality of tests for time stamp overflow.
9570 For example, without this patch (encode-time 0 0 0 1 1
9571 1152921504606846976) returns the obviously-bogus value (-948597
9572 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9573 reports time overflow. See
9574 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9575 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9576 * editfns.c: Include limits.h and intprops.h.
9577 (TIME_T_MIN, TIME_T_MAX): New macros.
9578 (time_overflow): Move earlier, to before first use.
9579 (hi_time, lo_time): New functions, for an accurate test for
9580 out-of-range times.
9581 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9582 (Fget_internal_run_time): Don't assume time_t fits in int.
9583 (make_time): Use list2 instead of Fcons twice.
9584 (Fdecode_time): More accurate test for out-of-range times.
9585 (check_tm_member): New function.
9586 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9587 (lisp_time_argument): Don't rely on undefined left-shift and
9588 right-shift behavior when checking for time stamp overflow.
8be6f318 9589
fe31d94c
PE
9590 * editfns.c (time_overflow): New function, refactoring common code.
9591 (Fformat_time_string, Fdecode_time, Fencode_time):
9592 (Fcurrent_time_string): Use it.
9593
8be6f318
PE
9594 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9595 * dired.c (make_time): Move to ...
9596 * editfns.c (make_time): ... here.
9597 * systime.h: Note the move.
9598
09d9db2c 95992011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9600
126bc0dc
YM
9601 * fringe.c (update_window_fringes): Remove unused variables.
9602
c47cbdfd
YM
9603 * unexmacosx.c (copy_data_segment): Also copy __got section.
9604 (Bug#8223)
9605
7ac80be9
EZ
96062011-03-12 Eli Zaretskii <eliz@gnu.org>
9607
c96bbc66 9608 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9609 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9610 Constify `char *' arguments and their references according to
9611 prototypes in tparam.h.
9612
ecb0f94d 9613 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9614
7ac80be9
EZ
9615 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9616 Adapt all references accordingly.
9617
9618 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9619
ef1fd07e
TT
96202011-03-11 Tom Tromey <tromey@redhat.com>
9621
9622 * buffer.c (syms_of_buffer): Remove obsolete comment.
9623
7ef4b50c
EZ
96242011-03-11 Eli Zaretskii <eliz@gnu.org>
9625
9626 * termhooks.h (encode_terminal_code): Declare prototype.
9627
9628 * msdos.c (encode_terminal_code): Don't declare prototype.
9629
9630 * term.c (encode_terminal_code): Now external again, used by
9631 w32console.c and msdos.c.
9632
44f230aa
SM
9633 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9634 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9635
4b1ec863 96362011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9637
1714f52b 9638 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9639
4b1ec863
PE
9640 * fringe.c (update_window_fringes): Mark locals as initialized
9641 (Bug#8227).
9642 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9643
524c7aa6
PE
9644 * alloc.c (mark_fringe_data): Move decl from here ...
9645 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9646 to check its interface.
9647 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9648
a5c0af81 9649 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9650 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9651 (fontset_font): Mark local as initialized.
a9a06e0b 9652 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9653
b4716021
PE
9654 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9655
811e9bac 9656 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9657 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9658 (x_own_selection, Fx_disown_selection_internal): Rename locals
9659 to avoid shadowing.
9660 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9661
7e3ab302
PE
9662 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9663 so that the caller can use some name other than gcpro1.
9664 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9665 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9666 (Fx_backspace_delete_keys_p):
9667 Use them to avoid shadowing, and rename vars to avoid shadowing.
9668 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9669 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9670 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9671 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9672 Remove unused locals.
7e3ab302
PE
9673 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9674 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9675 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9676 macros.
f78faa98 9677
e2b13473
PE
9678 * xterm.h (x_mouse_leave): New decl.
9679
77f23912
PE
9680 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9681 Remove unused functions.
cdf4ba58
PE
9682 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9683 (x_calc_absolute_position): Now static.
7411c686 9684 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9685 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9686 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9687 unless they are used.
38d0b34a
PE
9688 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9689 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9690 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9691 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9692 (x_error_catcher, x_connection_closed, x_error_handler):
9693 (x_error_quitter, xembed_send_message, x_iconify_frame):
9694 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9695 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9696 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9697
44f230aa
SM
9698 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9699 Rename or move locals to avoid shadowing.
6b463e58 9700 (tty_defined_color, merge_face_heights): Now static.
5967d051 9701 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9702 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9703 does not deduce is never used uninitialized.
73719eba
PE
9704 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9705 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9706
426994c3 9707 * terminal.c (store_terminal_param): Now static.
5489860b 9708
032f1620 9709 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9710 (set_frame_menubar): Remove unused local.
d4323972 9711 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9712 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9713 since they might point to immutable storage.
281585b0
PE
9714 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9715 since it's unused otherwise.
032f1620 9716
367c19e5 9717 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9718 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9719 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9720 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9721 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9722 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9723 does not deduce are never used uninitialized.
70739cbe 9724
07b48fa9
PE
9725 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9726
8868a238 9727 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9728 * window.c (window_loop, size_window):
9729 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9730
7e5cf297 9731 * window.c (display_buffer): Now static.
d6550a9f
PE
9732 (size_window): Mark variables that gcc -Wuninitialized
9733 does not deduce are never used uninitialized.
a586633d
PE
9734 * window.h (check_all_windows): New decl, to forestall
9735 gcc -Wmissing-prototypes diagnostic.
5b555da1 9736 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9737
f6095868
PE
9738 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9739 shadowing.
9740 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9741 Include <limits.h>.
9742 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9743 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9744 (load_charset_map): Mark variables that gcc -Wuninitialized
9745 does not deduce are never used uninitialized.
53df7c11 9746 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9747
f38b440c
PE
9748 * coding.c (coding_set_source, coding_set_destination):
9749 Use "else { /* comment */ }" rather than "else /* comment */;"
9750 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9751 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9752 a block, when the outer 'i' will do.
9753 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9754 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9755 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9756 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9757 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9758 Rename locals to avoid shadowing.
9759 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9760 * coding.c (emacs_mule_char, encode_invocation_designation):
9761 Now static, since they're not used elsewhere.
413bb2db 9762 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9763 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9764 (decode_coding_emacs_mule): Mark variables that gcc
9765 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9766 (detect_coding_iso_2022): Initialize a local variable that might
9767 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9768 this initialization is needed. (Bug#8211)
5f58e762
PE
9769 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9770 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9771 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9772 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9773 Remove unused macros.
f38b440c 9774
232b38b9 9775 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9776 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9777 * character.c (string_count_byte8): Likewise.
232b38b9 9778
fb90da1b
PE
9779 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9780 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9781
fb93dbc2
PE
9782 * chartab.c (copy_sub_char_table): Now static, since it's not used
9783 elsewhere.
5c156ace
PE
9784 (sub_char_table_ref_and_range, char_table_ref_and_range):
9785 Rename locals to avoid shadowing.
bbcd0949 9786 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9787
7d3b3862 9788 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9789 (BIDI_BOB): Remove unused macro.
7d3b3862 9790
6be7d3da
PE
9791 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9792 deduce are never used uninitialized.
c2ed9c8b 9793 * term.c (encode_terminal_code): Likewise.
6be7d3da 9794
75f8807f 9795 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9796
50938595
PE
9797 * tparam.h: New file.
9798 * term.c, tparam.h: Include it.
9799 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9800 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9801 Move these decls to tparam.h, and make them agree with what
9802 is actually in tparam.c. The previous trick of using incompatible
9803 decls in different modules does not conform to the C standard.
9804 All callers of tparam changed to use tparam's actual API.
9805 * tparam.c (tparam1, tparam, tgoto):
9806 Use const pointers where appropriate.
9807
fbceeba2
PE
9808 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9809 * cm.h (struct cm): Likewise.
9810 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9811 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9812 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9813 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9814 (turn_on_face, init_tty): Likewise.
9815 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9816
7f3f1250
PE
9817 * term.c (term_mouse_position): Rename local to avoid shadowing.
9818
e6ca6543
PE
9819 * alloc.c (mark_ttys): Move decl from here ...
9820 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9821
c40f8d15
AS
98222011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9823
9824 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9825
cfe0661d
JB
98262011-03-09 Juanma Barranquero <lekktu@gmail.com>
9827
9828 * search.c (compile_pattern_1): Remove argument regp, unused since
9829 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9830 (compile_pattern): Don't pass it.
9831
0afb4571
J
98322011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9833
9834 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9835 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9836 for ! HAVE_GTK3.
9837 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9838
9839 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9840
9841 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9842 gdk_window_get_screen, gdk_window_get_geometry,
9843 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9844 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9845 (xg_get_pixbuf_from_pixmap): New function.
9846 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9847 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9848 Call xg_get_pixbuf_from_pixmap instead of
9849 gdk_pixbuf_get_from_drawable.
9850 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9851 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9852 (xg_check_special_colors): Use GtkStyleContext and its functions
9853 for HAVE_GTK3.
9854 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9855 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9856 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9857 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9858 Call gtk_widget_get_preferred_size.
0afb4571
J
9859 (xg_frame_resized): gdk_window_get_geometry only takes 5
9860 parameters.
44f230aa
SM
9861 (xg_win_to_widget, xg_event_is_for_menubar):
9862 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9863 (xg_set_widget_bg): New function.
9864 (delete_cb): New function.
895009e1 9865 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9866 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9867 (xg_set_background_color): Call xg_set_widget_bg.
9868 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9869 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9870 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9871 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9872 if ! HAVE_GTK3.
9873 (update_frame_tool_bar): Call gtk_widget_hide.
9874 (xg_initialize): Use GDK_KEY_g.
9875
9876 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9877 if ! HAVE_GTK3
9878 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9879
9880 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9881 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9882 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9883
1c2cc4ef
JB
98842011-03-08 Juanma Barranquero <lekktu@gmail.com>
9885
9886 * w32xfns.c (select_palette): Check success of RealizePalette against
9887 GDI_ERROR, not zero.
9888
33383987 9889See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9890
9891;; Local Variables:
9892;; coding: utf-8
aac0c6e3
MR
9893;; End:
9894
acaf905b 9895 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9896
9897 This file is part of GNU Emacs.
9898
9899 GNU Emacs is free software: you can redistribute it and/or modify
9900 it under the terms of the GNU General Public License as published by
9901 the Free Software Foundation, either version 3 of the License, or
9902 (at your option) any later version.
9903
9904 GNU Emacs is distributed in the hope that it will be useful,
9905 but WITHOUT ANY WARRANTY; without even the implied warranty of
9906 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9907 GNU General Public License for more details.
9908
9909 You should have received a copy of the GNU General Public License
9910 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.