Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7f654971
UM
12012-08-14 Ulrich Mueller <ulm@gentoo.org>
2
3 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
4 (Bug#11712).
5
170aedb9
CY
62012-08-13 Eli Zaretskii <eliz@gnu.org>
7
b7f501c7
EZ
8 * w32menu.c: Include w32heap.h.
9 (add_menu_item): If the call to AppendMenuW (via
10 unicode_append_menu) fails, disable Unicode menus only if we are
11 running on Windows 9X/Me.
12
13 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
14
170aedb9
CY
15 * window.c (Fdelete_other_windows_internal)
16 (Fdelete_window_internal): Don't access frame's mouse highlight
17 info of the initial frame. (Bug#11677)
18
c17d5a38
JD
192012-08-12 Jan Djärv <jan.h.d@swipnet.se>
20
21 * nsterm.m (ns_read_socket): Return early if there is a modal
22 window (Bug#12043).
23
24 * nsmenu.m (Popdown_data): New struct.
25 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
26 free Popdown_data.
27 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
28 (initWithContentRect): Make imgView and contentView non-static
29 and autorelease them. Also autorelease img and matrix (Bug#12005).
30 (dealloc): Remove (Bug#12005).
31
32 * nsterm.m (keyDown:): Interpret flags without left/right bits
33 as the left key (Bug#11670).
34
35 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
36
8ccd072a
YM
372012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
38
39 * unexmacosx.c (copy_data_segment): Copy initialized data in
40 statically linked libraries from input file rather than memory.
41
db74a5fc
YM
422012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
43
44 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
45 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
46 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
47
23dc7744
CY
482012-07-19 Chong Yidong <cyd@gnu.org>
49
50 * window.c (Fwindow_absolute_pixel_edges)
51 (Fdelete_other_windows_internal): Signal an error if the window is
52 on a dead frame (Bug#11984).
53
fbf31a9c
EZ
542012-07-14 Eli Zaretskii <eliz@gnu.org>
55
56 Remove FILE_SYSTEM_CASE.
57 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
58
59 * fileio.c (FILE_SYSTEM_CASE): Don't define.
60 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
61 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
62 call-process-region passes it through expand-file-name.
63
64 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
65
8a05d57a
AS
662012-07-12 Andreas Schwab <schwab@linux-m68k.org>
67
68 Fix crash when creating indirect buffer (Bug#11917)
69 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
70 Don't handle unbound variables specially if non-zero.
71 (Fbuffer_local_variables): Pass zero.
72 (clone_per_buffer_values): Pass non-zero.
73
57570cd3
AS
742012-06-28 Andreas Schwab <schwab@linux-m68k.org>
75
76 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
77 to make the loop interruptible.
78
d01fd55f
AS
792012-06-26 Andreas Schwab <schwab@linux-m68k.org>
80
81 * gnutls.c (emacs_gnutls_handshake): Only retry if
82 GNUTLS_E_INTERRUPTED.
83
c81b46f6
EZ
842012-06-23 Eli Zaretskii <eliz@gnu.org>
85
86 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
87 in the logic of incrementing and decrementing the value of
88 use_relocatable_buffers.
89
63541ed8
GM
902012-06-21 Glenn Morris <rgm@gnu.org>
91
92 * charset.c (init_charset): Make lack of etc/charsets fatal.
93
50a93863
JD
942012-06-11 Jan Djärv <jan.h.d@swipnet.se>
95
96 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
97 referenced (Bug#11583).
98
94f0aa34
CY
992012-06-01 Chong Yidong <cyd@gnu.org>
100
101 * Version 24.1 released.
102
d5fd2c54
EZ
1032012-05-30 Eli Zaretskii <eliz@gnu.org>
104
105 * xdisp.c (handle_stop): Detect whether we have overlay strings
106 loaded by testing it->current.overlay_string_index to be
107 non-negative, instead of checking whether n_overlay_strings is
108 positive. (Bug#11587)
109
353c87f6
CY
1102012-05-30 Chong Yidong <cyd@gnu.org>
111
112 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
113
114 * doc.c (Fsubstitute_command_keys): Doc fix.
115
a02ae4e5
EZ
1162012-05-29 Eli Zaretskii <eliz@gnu.org>
117
118 * search.c (search_buffer): Remove calls to
119 r_alloc_inhibit_buffer_relocation, as it is now called by
120 maybe_unify_char, which was the cause of relocation of buffer text
121 in bug#11519.
122
291d430f
EZ
1232012-05-23 Eli Zaretskii <eliz@gnu.org>
124
125 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
126 for the duration of call to load_charset, to avoid problems with
127 callers of maybe_unify_char that access buffer text through C
128 pointers.
129
130 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
131 decrement the inhibition flag, instead of just setting or
132 resetting it.
133
2f9b9adb
KB
1342012-05-24 Ken Brown <kbrown@cornell.edu>
135
136 * callproc.c (Fcall_process): Restore a line that was accidentally
137 commented out in the 2011-02-13 change (bug#11547).
138
52c55cc7
EZ
1392012-05-23 Eli Zaretskii <eliz@gnu.org>
140
141 * lisp.h [REL_ALLOC]: Add prototypes for external functions
142 defined on ralloc.c.
143
144 * buffer.c [REL_ALLOC]: Remove prototypes of
145 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
146 they are now on lisp.h.
147
148 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
149
150 * search.c (search_buffer): Use it to inhibit relocation of buffer
151 text while re_search_2 is doing its job, because re_search_2 is
152 passed C pointers to buffer text. (Bug#11519)
153
23415acf
EZ
1542012-05-21 Eli Zaretskii <eliz@gnu.org>
155
156 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
157 Update value to 24.
158
44e27368
EZ
1592012-05-19 Eli Zaretskii <eliz@gnu.org>
160
161 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
162 state after an additional call to move_it_in_display_line_to, keep
163 the values of it->max_ascent and it->max_descent found for the
164 entire line.
165 (pos_visible_p): Revert the comparison against bottom_y to what it
166 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
167 (Bug#11464)
168
ccbf309c
EZ
1692012-05-15 Eli Zaretskii <eliz@gnu.org>
170
171 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
172
ac268e67
EZ
1732012-05-13 Eli Zaretskii <eliz@gnu.org>
174
175 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
176 already have overlays loaded.
177 (handle_single_display_spec): Before returning without displaying
178 fringe bitmap, synchronize the bidi iterator with the main display
179 iterator, by calling iterate_out_of_display_property.
180 (iterate_out_of_display_property): Detect buffer iteration by
181 testing that it->string is a Lisp string.
182 (get_next_display_element): When the current object is exhausted,
183 and there's something on it->stack, call set_iterator_to_next to
184 proceed with what's on the stack, instead of returning zero.
185 (set_iterator_to_next): If called at the end of a Lisp string,
186 proceed to consider_string_end without incrementing string
187 position. Don't increment display vector index past the end of
188 the display vector. (Bug#11417)
c8fb9dc6
EZ
189 (pos_visible_p): Don't report a position visible when move_it_to
190 stopped at the last line of window, which happens to be scanned
191 backwards by the bidi iteration. (Bug#11464)
ac268e67 192
82f9b393
EZ
1932012-05-11 Eli Zaretskii <eliz@gnu.org>
194
195 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
196 and right-margin display specs even if the spec is invalid or we
197 are on a TTY, and thus unable to display on the fringes. That's
198 because the text with the property will not be displayed anyway,
199 so we need to signal to the caller that this is a "replacing"
200 display spec. This fixes display when the spec is invalid or we
201 are on a TTY.
202
297834cd
PE
2032012-05-09 Paul Eggert <eggert@cs.ucla.edu>
204
205 * unexaix.c (make_hdr): Fix typo in prototype.
206 This bug broke the build on AIX. Problem reported by Gilles Pion.
207
0d887c7d
EZ
2082012-05-05 Eli Zaretskii <eliz@gnu.org>
209
210 * w32proc.c (new_child): Force Windows to reserve only 64KB of
211 stack for each reader_thread, instead of defaulting to 8MB
212 determined by the linker. This avoids failures in creating
213 subprocesses on Windows 7, see the discussion in this thread:
214 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
215
bf98199c
JM
2162012-05-02 Jim Meyering <meyering@redhat.com>
217
218 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
219
2fa85638
EZ
2202012-04-29 Eli Zaretskii <eliz@gnu.org>
221
222 * xdisp.c (pos_visible_p): If already at a newline from the
223 display string before the 'while' loop, don't walk back the glyphs
224 from it3.glyph_row. Solves assertion violation when the display
225 string begins with a newline (egg.el). (Bug#11367)
226
9be2fd9b
CY
2272012-04-24 Chong Yidong <cyd@gnu.org>
228
229 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
230
f0ee99a0
EZ
2312012-04-23 Eli Zaretskii <eliz@gnu.org>
232
233 * xdisp.c (pos_visible_p): If the window start position is beyond
234 ZV, start the display from buffer beginning. Prevents assertion
235 violation in init_iterator when the minibuffer window is scrolled
236 via the scroll bar.
237
238 * window.c (window_scroll_pixel_based): Likewise.
239
9ec7751f
CY
2402012-04-23 Chong Yidong <cyd@gnu.org>
241
242 * keymap.c (where_is_internal): Doc fix (Bug#10872).
243
24c51a09
GM
2442012-04-20 Glenn Morris <rgm@gnu.org>
245
246 * fileio.c (Fcopy_file, Fset_file_selinux_context):
247 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
248
73055685
EZ
2492012-04-20 Eli Zaretskii <eliz@gnu.org>
250
251 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
252 overrun array limits of glyph row's used[] array. (Bug#11288)
253
f30d612a
CY
2542012-04-20 Chong Yidong <cyd@gnu.org>
255
256 * process.c (wait_reading_process_output): If EIO occurs on a pty,
257 set the status to "failed" and ensure that sentinel is run.
258
016a35df
GM
2592012-04-18 Glenn Morris <rgm@gnu.org>
260
261 * process.c (Fset_process_inherit_coding_system_flag)
262 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 263 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 264
20a68157
EZ
2652012-04-17 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (string_buffer_position_lim): Limit starting position to
268 BEGV.
269 (set_cursor_from_row): If called for a mode-line or header-line
270 row, return zero immediately.
271 (try_cursor_movement): If inside continuation line, don't back up
272 farther than the first row after the header line, if any. Don't
273 consider the header-line row as "partially visible", even if
274 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
275
ad3a2b41
AO
2762012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
277
278 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
279
e63c261b
CY
2802012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
281
282 * process.c (make_process):
283 * process.h: Add integer `gnutls_handshakes_tried' member to
284 process struct.
285
ad3a2b41
AO
286 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
287 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
288
289 * gnutls.c (gnutls_log_function2i): Convenience log function.
290 (emacs_gnutls_read): Use new log functions,
291 `gnutls_handshakes_tried' process member, and
292 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
293 attempts per process (connection).
294
e53357c4
EZ
2952012-04-09 Eli Zaretskii <eliz@gnu.org>
296
297 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
298 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
299
aff67c82
JD
3002012-04-09 Jan Djärv <jan.h.d@swipnet.se>
301
302 * nsterm.m (constrainFrameRect): Always constrain when there is only
303 one screen (Bug#10962).
304
2f8e16b2
EZ
3052012-04-06 Eli Zaretskii <eliz@gnu.org>
306
307 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
308 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
309 about subtle differences between FETCH_CHAR* and STRING_CHAR*
310 macros related to unification of CJK characters. For the details,
311 see the discussion following the message here:
312 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
313
3d439cd1
CY
3142012-04-04 Chong Yidong <cyd@gnu.org>
315
316 * keyboard.c (Vdelayed_warnings_list): Doc fix.
317
8bc53d00
EZ
3182012-04-01 Eli Zaretskii <eliz@gnu.org>
319
320 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
321 instead of alloca. (Bug#11138)
322
3b0512a3
AS
3232012-04-01 Andreas Schwab <schwab@linux-m68k.org>
324
325 * w32menu.c (is_simple_dialog): Properly check lisp types.
326 (Bug#11141)
327
8427ddd2
EZ
3282012-03-31 Eli Zaretskii <eliz@gnu.org>
329
979022ef
EZ
330 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
331 position we get to after a call to move_it_to fails the
332 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
333 only if we wind up in a string from display property. (Bug#11063)
334
a6b1c7cc
EZ
335 * window.c (Fdelete_other_windows_internal): Invalidate the row
336 and column information about mouse highlight, so that redisplay
337 restores it after reallocating the glyph matrices. (Bug#7464)
338
8427ddd2
EZ
339 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
340 string comes from a `display' text property, use the buffer
341 position of that property as if we actually saw that position in
342 the row's glyphs.
697ba24b
EZ
343 (move_it_by_lines): Remove the assertion that
344 "it->current_x == 0 && it->hpos == 0" which can be legitimately
345 violated when there's a before-string at the beginning of a line.
346 (Bug#11063)
8427ddd2 347
65a0a738
EZ
3482012-03-30 Eli Zaretskii <eliz@gnu.org>
349
350 * xdisp.c (append_space_for_newline): If the default face was
351 remapped, use the remapped face for the appended newline.
352 (extend_face_to_end_of_line): Use the remapped default face for
353 extending the face to the end of the line.
354 (display_line): Call extend_face_to_end_of_line when the default
355 face was remapped. (Bug#11068)
356
581355cc
EZ
3572012-03-29 Eli Zaretskii <eliz@gnu.org>
358
359 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
360
e8fc049f
SM
3612012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
364
4fb9a543
GM
3652012-03-27 Glenn Morris <rgm@gnu.org>
366
367 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
368 Doc fixes.
369
679910f1
KH
3702012-03-26 Kenichi Handa <handa@m17n.org>
371
372 * dispextern.h (struct glyph): Fix previous change. Change the
373 bit length of glyphless.ch to 25 (Bug#11082).
374
90d49b7f
CY
3752012-03-26 Chong Yidong <cyd@gnu.org>
376
377 * keyboard.c (Vselection_inhibit_update_commands): New variable.
378 (command_loop_1): Use it; inhibit selection update for
379 handle-select-window too (Bug#8996).
380
f514f6f0
FP
3812012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
382
e8fc049f 383 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 384
bf43fa51
KH
3852012-03-25 Kenichi Handa <handa@m17n.org>
386
387 * dispextern.h (struct glyph): Change the bit length of
388 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
389
8a0c01dd
EZ
3902012-03-24 Eli Zaretskii <eliz@gnu.org>
391
392 * s/ms-w32.h (tzname): Include time.h before redirecting to
393 _tzname. Fixes the MSVC build. (Bug#9960)
394
7d1c3a76
AS
3952012-03-24 Andreas Schwab <schwab@linux-m68k.org>
396
8ed79523
AS
397 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
398 characters.
399
7d1c3a76
AS
400 * xterm.c (XTread_socket): Only modify handling_signal if
401 !SYNC_INPUT. (Bug#11080)
402
e99a9b8b
EZ
4032012-03-23 Eli Zaretskii <eliz@gnu.org>
404
405 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
406 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
407 when fetching a multibyte character consumes more bytes than
408 CHAR_BYTES returns, due to unification of CJK characters in
409 string_char. (Bug#11073)
410
5063c0e1
TN
4112012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
412
413 * process.c (wait_reading_process_output): Handle pty disconnect
414 by refraining from sending oneself a SIGCHLD (bug#10933).
415
9f851fbd
CY
4162012-03-22 Chong Yidong <cyd@gnu.org>
417
418 * dispextern.h (struct it): New member string_from_prefix_prop_p.
419
5063c0e1 420 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
421 Mark string as coming from a prefix property.
422 (handle_face_prop): Use default face for prefix strings (Bug#4281).
423 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
424
fb5b8aca
CY
4252012-03-21 Chong Yidong <cyd@gnu.org>
426
427 * xfaces.c (Vface_remapping_alist): Doc fix.
428
62356a1b
EZ
4292012-03-20 Eli Zaretskii <eliz@gnu.org>
430
431 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
432 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
433 Doc fixes.
62356a1b 434
025de85b
CY
4352012-03-20 Chong Yidong <cyd@gnu.org>
436
437 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
438 to reflect default non-nil value of redisplay-dont-pause.
439
4827f94e
KH
4402012-03-19 Kenichi Handa <handa@m17n.org>
441
442 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
443 it fit in a valid range (Bug#11003).
444
e50a24a2
EZ
4452012-03-18 Eli Zaretskii <eliz@gnu.org>
446
447 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
448 that is not from display property, accept the row as a "cursor
449 row" if one of the string's character has a non-nil `cursor'
450 property. Fixes cursor positioning when there are newlines in
451 overlay strings, e.g. in icomplete.el. (Bug#11035)
452
9af5ed87
PE
4532012-03-12 Paul Eggert <eggert@cs.ucla.edu>
454
455 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
456
d1f55f16
CY
4572012-03-12 Chong Yidong <cyd@gnu.org>
458
459 * eval.c (inhibit_lisp_code): Rename from
460 inhibit_window_configuration_change_hook; move from window.c.
461
462 * xfns.c (unwind_create_frame_1, Fx_create_frame):
463 * window.c (run_window_configuration_change_hook)
464 (syms_of_window): Callers changed.
465
66c5eebd
CY
4662012-03-11 Chong Yidong <cyd@gnu.org>
467
413df973
CY
468 * keymap.c (Fkey_description): Doc fix (Bug#9700).
469
66c5eebd
CY
470 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
471
1de11f56
CY
4722012-03-10 Chong Yidong <cyd@gnu.org>
473
474 * frame.c (other_visible_frames): Don't assume the selected frame
475 is visible (Bug#10955).
476
cae07000
SM
4772012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
478
479 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
480
89c94350
JD
4812012-03-08 Jan Djärv <jan.h.d@swipnet.se>
482
483 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
484 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
485 zero (Bug#10954).
486
999dd333
GM
4872012-03-03 Glenn Morris <rgm@gnu.org>
488
01a6dcc8 489 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 490
de0100f2
EZ
4912012-03-02 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
494 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
495 (redisplay_window, next_element_from_string): Fix typos in
496 comments.
3e441275
EZ
497 (redisplay_window): Pass to move_it_vertically the margin in
498 pixels, not in screen lines.
de0100f2 499
96a72ee9
GM
5002012-03-02 Glenn Morris <rgm@gnu.org>
501
502 * buffer.c (buffer-list-update-hook): Doc fix.
503
312508d7
EZ
5042012-02-29 Eli Zaretskii <eliz@gnu.org>
505
506 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
507 push_it before setting up the iterator for the first overlay
508 string, even if we have an empty string loaded.
509 (next_overlay_string): If there's an empty string on the iterator
510 stack, pop the stack. (Bug#10903)
511
27f3c637
PE
5122012-02-25 Paul Eggert <eggert@cs.ucla.edu>
513
514 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
515 Suggested by Stefan Monnier in
516 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
517 * alloc.c (widen_to_Lisp_Object): New static function.
518 (mark_memory): Also mark Lisp_Objects by fetching pointer words
519 and widening them to Lisp_Objects. This would work even if
520 USE_LSB_TAG is defined and wide integers are used, which might
521 happen in a future version of Emacs.
522
3c9dfce6
CY
5232012-02-25 Chong Yidong <cyd@gnu.org>
524
fa74b241
CY
525 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
526 Doc fix.
527
3c9dfce6
CY
528 * xselect.c (Fx_selection_exists_p): Doc fix.
529 (x_clipboard_manager_save_all): Print an informative message
530 before saving to clipboard manager.
531
9486df08
CY
5322012-02-24 Chong Yidong <cyd@gnu.org>
533
534 * keyboard.c (process_special_events): Handle all X selection
535 requests in kbd_buffer, not just the next one (Bug#8869).
536
f01d3321
CY
5372012-02-23 Chong Yidong <cyd@gnu.org>
538
539 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
540 call when setting menu-bar-lines and tool-bar-lines parameters.
541 (unwind_create_frame_1): New helper function.
542
543 * window.c (inhibit_window_configuration_change_hook): New var.
544 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 545 (syms_of_window): Initialize it.
f01d3321 546
86b847b6
CY
5472012-02-22 Chong Yidong <cyd@gnu.org>
548
549 * xterm.c (x_draw_image_relief): Add missing type check for
550 Vtool_bar_button_margin (Bug#10743).
551
a59225b1
CY
5522012-02-21 Chong Yidong <cyd@gnu.org>
553
554 * fileio.c (Vfile_name_handler_alist): Doc fix.
555
556 * buffer.c (Fget_file_buffer): Protect against invalid file
557 handler return value.
558
310f5bd4
PE
5592012-02-20 Paul Eggert <eggert@cs.ucla.edu>
560
cb3a28cc
PE
561 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
562 when computing $valmask.
563
310f5bd4
PE
564 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
565 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
566 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
567 It's useless in that case, and it can cause problems on hosts
568 that allocate halves of EMACS_INT values separately.
569 Reported by Dan Horák. Diagnosed by Andreas Schwab in
570 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
571 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
572 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
573 it avoids undefined behavior on hosts where shifting right by more
574 than the word width has undefined behavior.
575
2375c96a
CY
5762012-02-19 Chong Yidong <cyd@gnu.org>
577
578 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
579 (Funhandled_file_name_directory, Ffile_name_as_directory)
580 (Fdirectory_file_name, Fexpand_file_name)
581 (Fsubstitute_in_file_name): Protect against invalid file handler
582 return values (Bug#10845).
583
3eb49e71
EZ
5842012-02-18 Eli Zaretskii <eliz@gnu.org>
585
586 * .gdbinit (pitx): Fix incorrect references to fields of the
587 iterator stack.
588
7b926f3f
CY
5892012-02-17 Chong Yidong <cyd@gnu.org>
590
591 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
592
11273115
PE
5932012-02-15 Paul Eggert <eggert@cs.ucla.edu>
594
595 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
596 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
597
c3a70e2b
CY
5982012-02-15 Chong Yidong <cyd@gnu.org>
599
600 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
601 marked as special. Also, starting docstrings with * is obsolete.
602
0ca43699
AS
6032012-02-13 Andreas Schwab <schwab@linux-m68k.org>
604
605 * gnutls.c (emacs_gnutls_write): Fix last change.
606
2e8f3c56
LI
6072012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
608
609 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
610 send_process.
611
af70074f
SM
6122012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
613
614 * keymap.c (Fsingle_key_description): Handle char ranges.
615
95986d52
CY
6162012-02-12 Chong Yidong <cyd@gnu.org>
617
afd83bd1
CY
618 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
619 as that creates a dangerous corner case.
620
95986d52
CY
621 * window.c (Fdelete_window_internal): Invalidate the mouse
622 highlight (Bug#9904).
623
bd7da63e
GM
6242012-02-12 Glenn Morris <rgm@gnu.org>
625
626 * xselect.c (Fx_own_selection_internal)
627 (Fx_get_selection_internal, Fx_disown_selection_internal)
628 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
629 * nsselect.m (Fx_own_selection_internal)
630 (Fx_disown_selection_internal, Fx_selection_exists_p)
631 (Fx_selection_owner_p, Fx_get_selection_internal):
632 Sync docs and argument specs with the xselect.c versions.
633
77abcbc2
LI
6342012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
635
636 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
637
90b671e2
EZ
6382012-02-11 Eli Zaretskii <eliz@gnu.org>
639
1c0ca0b7
EZ
640 * w32select.c (Fx_selection_exists_p): Sync doc string and
641 argument list with xselect.c. (Bug#10783)
642
643 * w16select.c (Fx_selection_exists_p): Sync doc string and
644 argument list with xselect.c. (Bug#10783)
90b671e2 645
49241268
GM
6462012-02-10 Glenn Morris <rgm@gnu.org>
647
648 * fns.c (Fsecure_hash): Doc fix.
649
f998bbe7 6502012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
651
652 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
653
0992bd9c
CY
6542012-02-07 Chong Yidong <cyd@gnu.org>
655
656 * buffer.c (Fbuffer_local_variables)
657 (buffer_lisp_local_variables): Handle unbound vars correctly;
658 don't let Qunbound leak into Lisp.
659
af008560
GM
6602012-02-07 Glenn Morris <rgm@gnu.org>
661
dd605cc4
GM
662 * image.c (Fimagemagick_types): Doc fix.
663
af008560
GM
664 * image.c (imagemagick-render-type): Change it from a lisp object
665 to an integer. Move the doc here from the lisp manual.
666 Treat all values not equal to 0 the same.
667
1449fa1d
CY
6682012-02-06 Chong Yidong <cyd@gnu.org>
669
670 * doc.c (store_function_docstring): Avoid applying docstring of
671 alias to base function (Bug#2603).
672
3723ec07
AS
6732012-02-04 Andreas Schwab <schwab@linux-m68k.org>
674
675 * .gdbinit (pp1, pv1): Remove redundant defines.
676 (pr): Use pp.
677
79c1cc1e
CY
6782012-02-04 Chong Yidong <cyd@gnu.org>
679
680 * nsterm.m: Declare a global (Bug#10694).
681
d7f29f8e
EZ
6822012-02-04 Eli Zaretskii <eliz@gnu.org>
683
cae07000
SM
684 * w32.c (get_emacs_configuration_options):
685 Include --enable-checking, if specified, in the return value.
d7f29f8e 686
3b95a6f9
MR
6872012-02-04 Martin Rudalics <rudalics@gmx.at>
688
689 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
690 after rounding frame sizes. (Bug#9723)
691
d6fa96a6
EZ
6922012-02-04 Eli Zaretskii <eliz@gnu.org>
693
694 * keyboard.c (adjust_point_for_property): Don't position point
695 before BEGV. (Bug#10696)
696
df0b2940
PE
6972012-02-03 Paul Eggert <eggert@cs.ucla.edu>
698
699 Handle overflow when computing char display width (Bug#9496).
700 * character.c (char_width): Return EMACS_INT, not int.
701 (char_width, c_string_width): Check for overflow when
702 computing the width; this is possible now that individual
703 characters can have unbounded width. Problem introduced
704 by merge from Emacs 23 on 2012-01-19.
705
6bee44d6
MA
7062012-02-02 Michael Albinus <michael.albinus@gmx.de>
707
708 * dbusbind.c (Fdbus_register_method): Mention the return value
709 :ignore in the docstring.
710
44f92739
GM
7112012-02-02 Glenn Morris <rgm@gnu.org>
712
1b9f60cc
GM
713 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
714
44f92739
GM
715 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
716 Unconditionally set to t. (Bug#10673)
717 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
718 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
719 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
720
c5d3843c
KH
7212012-02-02 Kenichi Handa <handa@m17n.org>
722
723 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
724 0, do not call append_composite_glyph.
725
159462d4 7262012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
727
728 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
729 NULL (Bug#6988).
730 (x_produce_glyphs): If the component of a composition is a null
731 string, set it->pixel_width to 1 to avoid zero-width glyph.
732
78cef877
EZ
7332012-02-01 Eli Zaretskii <eliz@gnu.org>
734
735 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
736 first 2 arguments are identical. This makes inserting large
737 output from a subprocess an order of magnitude faster on
738 MS-Windows, where all sbrk'ed memory is always contiguous.
739
97897668
GM
7402012-01-31 Glenn Morris <rgm@gnu.org>
741
742 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 743 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
744 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
745
31fd3586
GM
7462012-01-29 Glenn Morris <rgm@gnu.org>
747
748 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
749
0e24a8b2
CY
7502012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
751
752 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
753
cc0adcb0
CY
7542012-01-28 Chong Yidong <cyd@gnu.org>
755
756 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
757
acc28cb9
CY
7582012-01-26 Chong Yidong <cyd@gnu.org>
759
9c69cfb7
CY
760 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
761
acc28cb9
CY
762 * search.c (Fsearch_forward, Fsearch_backward): Document negative
763 repeat counts (Bug#10507).
764
48da7392
GM
7652012-01-26 Glenn Morris <rgm@gnu.org>
766
767 * lread.c (syms_of_lread): Doc fix.
768
14af5f7f
CY
7692012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
770
771 * coding.c (encode_designation_at_bol): Change return value to
772 EMACS_INT.
773
0b21c100
CY
7742012-01-25 Chong Yidong <cyd@gnu.org>
775
776 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
777
3c2907f7
CY
7782012-01-21 Chong Yidong <cyd@gnu.org>
779
780 * floatfns.c (Fcopysign): Make the second argument non-optional,
781 since nil is not allowed anyway.
782
959ad23f
AS
7832012-01-21 Andreas Schwab <schwab@linux-m68k.org>
784
785 * process.c (read_process_output): Use p instead of XPROCESS (proc).
786 (send_process): Likewise.
787
34a02f46
MR
7882012-01-19 Martin Rudalics <rudalics@gmx.at>
789
790 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
791 (Vwindow_persistent_parameters): Do not use Qstate.
792 Rewrite doc-strings.
34a02f46 793
1259009a 7942012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
795
796 * character.c (char_width): New function.
70d4fdf6
GM
797 (Fchar_width, c_string_width, lisp_string_width):
798 Use char_width (Bug#9496).
25ed9e61 799
6a6ee00d
MR
8002012-01-16 Martin Rudalics <rudalics@gmx.at>
801
802 * window.c (Vwindow_persistent_parameters): New variable.
803 (Fset_window_configuration, save_window_save): Handle persistent
804 window parameters.
805
c85efaf7
EZ
8062012-01-14 Eli Zaretskii <eliz@gnu.org>
807
808 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
809 thrashing the stack of the thread. (Bug#9087)
810
5944709e
PE
8112012-01-12 Paul Eggert <eggert@cs.ucla.edu>
812
813 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
814
e71f5d99
EZ
8152012-01-11 Eli Zaretskii <eliz@gnu.org>
816
817 * xdisp.c (rows_from_pos_range): Handle the case where the
818 highlight ends on a newline. (Bug#10464)
819 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
820 he end column for display of highlight that ends on a newline
821 before a R2L line.
822
ce316182
GM
8232012-01-11 Glenn Morris <rgm@gnu.org>
824
825 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
826 from load-path also when installation-directory is nil. (Bug#10208)
827
5b43da69
GM
8282012-01-10 Glenn Morris <rgm@gnu.org>
829
74cc8ff9
GM
830 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
831
7d8d6e4e
GM
832 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
833 Update template values to be closer to their typical values these days.
5b43da69 834
a0db8d43
EZ
8352012-01-09 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (rows_from_pos_range): Accept additional argument
838 DISP_STRING, and accept any glyph in a row whose object is that
839 string as eligible for mouse highlight. Fixes mouse highlight of
840 display strings from overlays. (Bug#10464)
841
9a0115ab 8422012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 843
b9110d6a 844 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
845 * fileio.c (auto_saving_dir_umask): New static var.
846 (Fmake_directory_internal): Use it.
847 (do_auto_save_make_dir): Set it, instead of invoking chmod after
848 creating the directory. The old code temporarily assigns
849 too-generous permissions to the directory.
850 (do_auto_save_eh): Clear it.
b9110d6a 851 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
852 that the var is always cleared.
853
6c1bd3f3
EZ
8542012-01-07 Eli Zaretskii <eliz@gnu.org>
855
856 * search.c (scan_buffer): Pass character positions to
857 know_region_cache, not byte positions. (Bug#6540)
858
069d2b50
L
8592012-01-07 LynX <_LynX@bk.ru> (tiny change)
860
861 * w32.c (sys_rename): Report EXDEV when rename of a directory
862 fails because the target is on another logical disk. (Bug#10284)
863
75bf0d33
DB
8642012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
865
866 * xterm.c (x_embed_request_focus): New function.
867
868 * xterm.h: Add prototype.
869
870 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
871
1c6e5a32
GM
8722012-01-05 Glenn Morris <rgm@gnu.org>
873
874 * emacs.c (emacs_copyright): Update short copyright year to 2012.
875
651e947e
EZ
8762012-01-01 Eli Zaretskii <eliz@gnu.org>
877
878 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
879 Load gnutls_transport_set_lowat only if GnuTLS version is below
880 2.11.1.
881 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
882 GnuTLS versions below 2.11.1.
883
3778cdd8
AL
8842011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
885
886 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
887 to the doc string advising against its use for altering the way
888 windows are scrolled.
889
0e5317f7
KH
8902011-12-28 Kenichi Handa <handa@m17n.org>
891
892 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
893 coding-system ASCII compatible only when it does not produce BOM
894 on encoding (Bug#10383).
895
93d5ca1f
JD
8962011-12-26 Jan Djärv <jan.h.d@swipnet.se>
897
898 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
899 can scroll.
900 (create_and_show_popup_menu): Always use menu_position_func for
901 Gtk3 (Bug#10361).
902
ca22b785
AS
9032011-12-24 Andreas Schwab <schwab@linux-m68k.org>
904
905 * callint.c (Fcall_interactively): Don't truncate prompt string.
906
d048e1e6
EZ
9072011-12-23 Eli Zaretskii <eliz@gnu.org>
908
909 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
910 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 911 resumed from there (after widening). (Bug#10360)
d048e1e6 912
5ccaba1f
JD
9132011-12-22 Jan Djärv <jan.h.d@swipnet.se>
914
915 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
916
204ee57f
JD
9172011-12-21 Jan Djärv <jan.h.d@swipnet.se>
918
b81d40f0
JB
919 * nsterm.m (x_free_frame_resources):
920 Release f->output_data.ns->miniimage.
204ee57f
JD
921 (ns_index_color): Fix indentation. Do not retain
922 color_table->colors[i].
923
924 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
925 before returning.
926
927 * nsfns.m (x_set_background_color): Assign return value from
928 ns_index_color to face-background instead of NSColor*.
929 (ns_implicitly_set_icon_type): Fix indentation.
930 Change assignment in for loop to comparison.
931
932 * emacs.c (ns_pool): New variable.
933 (main): Assign ns_pool.
934 (Fkill_emacs): Call ns_release_autorelease_pool.
935
936 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
937 autorelease fdesc, release fdAttrs and tdict.
938 (ns_get_covering_families): Release charset.
939 (ns_findfonts): Release NSFontDescriptor created with new.
940 (ns_uni_to_glyphs): Fix indentation.
941 (setString): Release attrStr before assigning new value.
942
c803b2b7
JD
9432011-12-18 Jan Djärv <jan.h.d@swipnet.se>
944
678f4426
JD
945 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
946 and NS_IMPL_COCOA.
947 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
948 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
949
cd394be1 9502011-12-18 David Reitter <reitter@cmu.edu>
678f4426 951
5fecd5fc
JD
952 * nsterm.m (ns_term_init): Subscribe for notifications
953 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
954 to method trackingNotification in EmacsMenu.
955
956 * nsmenu.m (trackingMenu): New variable.
3771cb17 957 (trackingNotification): New method (from Aquamacs).
5fecd5fc 958 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 959 from Aquamacs (Bug#7030).
678f4426
JD
960
9612011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 962
c803b2b7
JD
963 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
964 (symbol_to_nsstring): Fix indentation.
965 (ns_symbol_to_pb): New function.
cae07000
SM
966 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
967 (Fns_rotate_cut_buffers_internal): Remove.
968 (Fns_store_selection_internal): Rename from
c803b2b7
JD
969 Fns_store_cut_buffer_internal.
970 (ns_get_foreign_selection, Fx_own_selection_internal)
971 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
972 (Fns_get_selection_internal, Fns_store_selection_internal):
973 Use ns_symbol_to_pb and check if return value is nil.
974 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
975 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
976 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
977 renamed to Sns_store_selection_internal.
978 (ns_handle_selection_request): Move code to Fx_own_selection_internal
979 and remove this function.
980 (ns_handle_selection_clear): Remove, never used.
981 (Fx_own_selection_internal): Move code from ns_handle_selection_request
982 here.
983
e1b01a3a
KB
9842011-12-17 Ken Brown <kbrown@cornell.edu>
985
986 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
987 GID is unknown (Bug#10257).
988
2adb6e85
PE
9892011-12-17 Paul Eggert <eggert@cs.ucla.edu>
990
991 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
992 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
993 which caused a build failure on GNU/Linux IA-64. This problem was
994 introduced by my 2011-10-07 patch.
995
d1d7b339
JL
9962011-12-15 Juri Linkov <juri@jurta.org>
997
998 * image.c (imagemagick_error): New function. (Bug#10112)
999 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1000 Use `imagemagick_error' where ImageMagick functions return
1001 `MagickFalse'.
1002 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1003 proper order.
1004
100d5755
KH
10052011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1006
1007 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1008 fill background (Bug#8992).
1009
454592a6
MR
10102011-12-13 Martin Rudalics <rudalics@gmx.at>
1011
1012 * window.c (Vwindow_combination_resize)
1013 (Vwindow_combination_limit): Use t instead of non-nil in
1014 doc-strings.
61d4b438
MR
1015 (Vrecenter_redisplay): Add first sentence of doc-string on
1016 separate line.
53524d93 1017 (Frecenter): Fix doc-string typo.
454592a6 1018
3633e3aa
KH
10192011-12-11 Kenichi Handa <handa@m17n.org>
1020
1021 * coding.c (Funencodable_char_position): Pay attention to the
1022 buffer text relocation (Bug#9389).
1023
7b9d523a
JD
10242011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1025
1026 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1027 gtk_init (Bug#10100).
1028
b73189c6
EZ
10292011-12-10 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1032 IT->string is nil. (Bug#10263)
1033
f7dfe5d6
JD
10342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1035
83faebb4
JD
1036 * nsterm.h (x_free_frame_resources): Declare.
1037
f7dfe5d6
JD
1038 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1039 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1040
1041 * nsterm.h (ns_get_defaults_value): Declare.
1042
1043 * nsterm.m (ns_default): Call ns_get_defaults_value.
1044
7cd4e72c
EZ
10452011-12-09 Eli Zaretskii <eliz@gnu.org>
1046
1047 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1048 (Bug#10170)
1049
b34d7317
YM
10502011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1051
1052 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1053 that where the value of an _OBJC_* symbol points to is in the .bss
1054 section (Bug#10240).
1055
76470ad1
KH
10562011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1057
1058 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1059 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1060
745fff94
KH
10612011-12-08 Kenichi Handa <handa@m17n.org>
1062
1063 * ftfont.c (get_adstyle_property): Fix previous change
1064 (Bug#10233).
1065
6e44397c
JB
10662011-12-07 Juanma Barranquero <lekktu@gmail.com>
1067
1068 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1069 dirs from the default value of EMACSLOADPATH (bug#10208).
1070
7efa6272
GM
10712011-12-07 Glenn Morris <rgm@gnu.org>
1072
1073 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1074 installation and source directories as well. (Bug#10208)
1075
f6fc4d87
CY
10762011-12-06 Chong Yidong <cyd@gnu.org>
1077
1078 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1079
2bf26180
GM
10802011-12-06 Glenn Morris <rgm@gnu.org>
1081
1082 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1083 as an error, not just -1. (Bug#10217)
1084
3a6ad4f0
CY
10852011-12-05 Chong Yidong <cyd@gnu.org>
1086
1087 * keyboard.c (process_special_events): New function.
1088 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1089
75a3b399
PE
10902011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * coding.c (encode_designation_at_bol): Don't use uninitialized
1093 local variable (Bug#9318).
1094
c3c9e25e
KH
10952011-12-05 Kenichi Handa <handa@m17n.org>
1096
1097 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1098 return Qnil (Bug#8046, Bug#10193).
1099
5eb05ea3
KH
11002011-12-05 Kenichi Handa <handa@m17n.org>
1101
1102 * coding.c (encode_designation_at_bol): New args charbuf_end and
1103 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1104 (coding_set_source): Return how many bytes coding->source was
1105 relocated.
1106 (coding_set_destination): Return how many bytes
1107 coding->destination was relocated.
1108 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1109 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1110
11112011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1112
1113 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1114 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1115 macro (Bug#9318).
1116
11172011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1118
1119 The following changes are to fix Bug#9318.
1120
a79703f5 1121 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1122 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1123 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1124 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1125
7dbda6df
JB
11262011-12-05 Juanma Barranquero <lekktu@gmail.com>
1127
1128 * lisp.h (process_quit_flag): Fix external declaration.
1129
6d5eb5b0
SM
11302011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 Don't macro-inline non-performance-critical code.
1133 * eval.c (process_quit_flag): New function.
1134 * lisp.h (QUIT): Use it.
1135
a0c3fad0
JD
11362011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1137
1138 * nsfns.m (get_geometry_from_preferences): New function.
1139 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1140
6c07aac2
AS
11412011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1142
1143 * emacs.c (Qkill_emacs): Define.
1144 (syms_of_emacs): Initialize it.
1145 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1146 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1147 (quit_throw_to_read_char): Add parameter `from_signal'.
1148 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1149 * lisp.h (QUIT): Call Fkill_emacs if requested.
1150
c052ead4
JD
11512011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1152
1153 * widget.c (update_wm_hints): Return if wmshell is null.
1154 (widget_update_wm_size_hints): New function.
1155
1156 * widget.h (widget_update_wm_size_hints): Declare.
1157
1158 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1159 widget_update_wm_size_hints (Bug#10104).
1160
9e49252b
EZ
11612011-12-03 Eli Zaretskii <eliz@gnu.org>
1162
1163 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1164 before a newline, prepare the bidi iterator for consuming the
1165 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1166 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1167
02b16839
JL
11682011-12-02 Juri Linkov <juri@jurta.org>
1169
1170 * search.c (Fword_search_regexp): New Lisp function created from
1171 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1172 (Fword_search_backward, Fword_search_forward)
1173 (Fword_search_backward_lax, Fword_search_forward_lax):
1174 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1175 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1176
0068070e
SM
11772011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * fileio.c (Finsert_file_contents): Move after-change-function call
1180 to before the "handled:" label, since all "goto handled" appear in
1181 cases where the *-change-functions have already been properly called
1182 (bug#10117).
1183
3360a3fc
AS
11842011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1185
1186 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1187 waiting for input. (Bug#10169)
1188
73d6c093
EZ
11892011-11-30 Eli Zaretskii <eliz@gnu.org>
1190
1191 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1192 verifies glyph row's hash code--we have just reallocated the
1193 glyphs, so their contents can be complete garbage. (Bug#10164)
1194
febe6bea
JB
11952011-11-30 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1198
801a4313
EZ
11992011-11-30 Eli Zaretskii <eliz@gnu.org>
1200
1201 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1202 attributes are tested _before_ calling verify_row_hash, to protect
1203 against GCC re-ordering of the tests. (Bug#10164)
1204
2b56b87e
JD
12052011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1206
1207 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1208
1209 * xterm.c (handle_one_xevent): Only set async_visible and friends
1210 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1211 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1212 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1213
dbf31225
PE
12142011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1217 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1218 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1219 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1220 All uses changed to use GCPRO1 etc.
1221 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1222 Revert to old implementation (i.e., before 2011-03-11).
1223
1305621b
YM
12242011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1225
1226 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1227 of scroll runs so as to avoid assigning disabled bogus rows and
1228 unnecessary graphics copy operations.
1229
8c9afb46
EZ
12302011-11-27 Eli Zaretskii <eliz@gnu.org>
1231
1232 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1233 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1234 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1235 (malloc, free, realloc, calloc): Redirect to e_* only when
1236 compiling Emacs.
1237
1238 * lisp.h (GCTYPEBITS): Move before first use.
1239 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1240 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1241 this macro definition.
1242
1243 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1244 _MSC_VER.
1245
54e9e3bf
JD
12462011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1247
6d5eb5b0
SM
1248 * gtkutil.c (xg_create_frame_widgets):
1249 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1250 present with Gtk+ 2.0.
1251
83aca1cb
PE
12522011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1253
1254 * fileio.c (Finsert_file_contents): Undo previous change; see
1255 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1256
5b76caa4
PE
12572011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 Rename locals to avoid shadowing.
1260 * fileio.c (Finsert_file_contents):
1261 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1262 * process.c (wait_reading_process_output):
1263 Rename inner 'proc' to 'p' to avoid shadowing.
1264 Indent for consistency with usual Emacs style.
1265
8c535114
EZ
12662011-11-25 Eli Zaretskii <eliz@gnu.org>
1267
1268 * xdisp.c (redisplay_window): If cursor row is not fully visible
1269 after recentering, and scroll-conservatively is set to a large
1270 number, scroll window by a few more lines to make the cursor fully
1271 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1272 (start_display): Don't move to the next line if the display should
1273 start at a newline that is part of a display vector or an overlay
1274 string. (Bug#10119)
8c535114 1275
fa4fdb5c
JL
12762011-11-24 Juri Linkov <juri@jurta.org>
1277
1278 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1279 after the `MagickPingImage' call. (Bug#10112)
1280
90ec88df
CY
12812011-11-23 Chong Yidong <cyd@gnu.org>
1282
1283 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1284
56e2e794
MR
12852011-11-23 Martin Rudalics <rudalics@gmx.at>
1286
1287 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1288 making another buffer current. (Bug#10114)
1289
b6e64c41
GM
12902011-11-23 Glenn Morris <rgm@gnu.org>
1291
1292 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1293
6b21de18
CY
12942011-11-23 Chong Yidong <cyd@gnu.org>
1295
1296 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1297 using it (Bug#5984).
1298
b12cd789
EZ
12992011-11-22 Eli Zaretskii <eliz@gnu.org>
1300
1301 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1302 and header-lines, as they don't have one computed for them.
1303 (Bug#10098)
1304
1305 * .gdbinit (prow): Make displayed values more self-explaining.
1306 Add row's hash code.
1307
261b6fd4
LMI
13082011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1309
1310 * process.c (wait_reading_process_output): Fix asynchrounous
1311 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1312 (wait_reading_process_output): Add comment and URL.
261b6fd4 1313
e7cfd277
JD
13142011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1315
1316 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1317
a9b9b7f5
CY
13182011-11-21 Chong Yidong <cyd@gnu.org>
1319
1320 * window.c (Fnext_window, Fprevious_window): Doc fix.
1321
b0d15b4f
SM
13222011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1323
1324 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1325
fe7a3057
JB
13262011-11-20 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1329
d2999b1a
MR
13302011-11-20 Martin Rudalics <rudalics@gmx.at>
1331
1332 * window.c (Fset_window_combination_limit): Rename argument
1333 STATUS to LIMIT.
1334 (Vwindow_combination_limit): Remove "status" from doc-string.
1335
d5ff9cd0
AS
13362011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1337
1338 * m/ibms390.h: Remove.
1339 * m/ibms390x.h: Don't include "ibms390.h".
1340
a5bb9bd3
SM
13412011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1342
1343 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1344 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1345
cd1181db
JB
13462011-11-20 Juanma Barranquero <lekktu@gmail.com>
1347
1348 * casetab.c (Fset_case_table):
1349 * charset.c (Fcharset_after): Fix typos.
1350
615a3b8d 13512011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1352
17e845af
PE
1353 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1354 Otherwise, valgrind does not work on some platforms.
1355 Problem reported by Andreas Schwab in
6a0bf43d
PE
1356 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1357 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1358 is set, removing the need for VIRT_ADDRESS_VARIES.
1359 (PURE_P): Use a more-efficient implementation that needs just one
1360 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1361 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1362 to 4 (xorl, subq, cmpq, setbe).
1363 * alloc.c (pure): Always extern now, since that's the
1364 VIRT_ADDR_VARIES behavior.
1365 (PURE_POINTER_P): Use a single comparison, not two, for
1366 consistency with the new puresize.h.
1367 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1368 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1369 Remove VIRT_ADDR_VARIES no longer needed.
1370
f8fe6f96
EZ
13712011-11-19 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1374 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1375 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1376 behave as if the cursor position were at the window margin.
1377
1378 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1379 and the cursor position is out of bounds, behave as if the cursor
1380 position were at the window margin. (Bug#10075)
1381
df05a53c
CY
13822011-11-18 Chong Yidong <cyd@gnu.org>
1383
1384 * window.c (Fwindow_combination_limit): Make first argument
1385 non-optional, since it is meaningless for live windows like the
1386 selected window.
1387
2071918e
DA
13882011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1389
1390 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1391
b50a28de
SM
13922011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1393
1394 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1395 (graft_intervals_into_buffer): Simplify.
1396
015137db
EZ
13972011-11-18 Eli Zaretskii <eliz@gnu.org>
1398
1399 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1400 hash values of the two rows.
1401 (copy_row_except_pointers): Preserve the used[] arrays and the
1402 hash values of the two rows. (Bug#10035)
68c95424 1403 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1404
1405 * xdisp.c (row_hash): New function, body extracted from
1406 compute_line_metrics.
1407 (compute_line_metrics): Call row_hash, instead of computing the
1408 hash code inline.
1409
1410 * dispnew.c (verify_row_hash): Call row_hash for computing the
1411 hash code of a row, instead of duplicating code from xdisp.c.
1412
1413 * dispextern.h (row_hash): Add prototype.
1414
a2addb04
TH
14152011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1416
1417 * frame.c (delete_frame): Don't delete the terminal when the last
1418 X frame is closed if emacs is built with GTK toolkit.
1419
df85d315
JB
14202011-11-17 Juanma Barranquero <lekktu@gmail.com>
1421
1422 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1423
a0c2d0ae
MR
14242011-11-17 Martin Rudalics <rudalics@gmx.at>
1425
1426 * window.c (Vwindow_splits): Rename to
1427 Vwindow_combination_resize. Suggested by Juri Linkov.
1428 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1429 of Vwindow_splits.
1430
58179cce
JB
14312011-11-16 Juanma Barranquero <lekktu@gmail.com>
1432
7877f373
JB
1433 * nsfns.m (Fns_font_name):
1434 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1435
b6f67890
MR
14362011-11-16 Martin Rudalics <rudalics@gmx.at>
1437
1438 * window.h (window): Rename slot "nest" to "combination_limit".
1439 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1440 (Fset_window_nest): Rename to Fset_window_combination_limit.
1441 (Vwindow_nest): Rename to Vwindow_combination_limit.
1442 (recombine_windows, make_parent_window, make_window)
1443 (Fsplit_window_internal, saved_window)
1444 (Fset_window_configuration, save_window_save): Rename all
1445 occurrences of window_nest to window_combination_limit.
1446
c7015153
JB
14472011-11-15 Juanma Barranquero <lekktu@gmail.com>
1448
1449 * image.c (imagemagick_load_image): Fix typo.
1450
322ad6ec
EZ
14512011-11-14 Eli Zaretskii <eliz@gnu.org>
1452
1453 * xdisp.c (display_line): Move the call to
1454 highlight_trailing_whitespace before the call to
1455 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1456 faces of all the glyphs to compute ROW's hash value.
1457 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1458
f067b8ec
JB
14592011-11-14 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1462 just return (bug#10044).
1463
1e5b2111
EZ
14642011-11-12 Eli Zaretskii <eliz@gnu.org>
1465
7ef3cbd5
EZ
1466 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1467 with user-defined heap size. Bump the default size of the temacs
1468 heap to 27MB, to avoid memory warning when running temacs.
1469 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1470
1e5b2111
EZ
1471 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1472 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1473 (verify_row_hash) [XASSERTS]: New function.
1474 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1475 that the hash value of glyph rows is correct.
1e5b2111 1476
89d61221
MR
14772011-11-12 Martin Rudalics <rudalics@gmx.at>
1478
1479 * window.h (window): Remove splits slot.
1480 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1481 (Fdelete_other_windows_internal, make_parent_window)
1482 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1483 (Fset_window_configuration, save_window_save): Don't deal with
1484 split status of windows.
1485 (saved_window): Remove splits slot.
1486 (Vwindow_splits): Rewrite doc-string.
1487
97f18cc8
JD
14882011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1489
1490 * xfns.c (unwind_create_frame):
1491 * nsfns.m (unwind_create_frame):
1492 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1493 Vframe_list (Bug#9999).
1494
22a648b4
DA
14952011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1496
0b381c7e 1497 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1498
659afede
KH
14992011-11-11 Kenichi Handa <handa@m17n.org>
1500
1501 * callproc.c (Fcall_process): Set the member dst_multibyte of
1502 process_coding.
1503
9ac0394b
KH
15042011-11-11 Johan Bockgård <bojohan@gnu.org>
1505
1506 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1507 avoid a crash (bug#9496).
1508
2fbdc249
CY
15092011-11-09 Chong Yidong <cyd@gnu.org>
1510
1511 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1512 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1513
ac6b1f81
PE
15142011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1517
09db192c
PE
15182011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Avoid some portability problems by eschewing 'extern inline' functions.
1521 The trivial performance wins aren't worth the portability hassles; see
1522 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1523 et seq.
1524 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1525 (window_box_width, window_box_left, window_box_left_offset)
1526 (window_box_right, window_box_right_offset): Undo previous change,
1527 by removing the "extern"s.
1528 * intervals.c (adjust_intervals_for_insertion)
1529 (adjust_intervals_for_deletion): Undo previous change,
1530 making these static again.
1531 (offset_intervals, temp_set_point_both, temp_set_point)
1532 (copy_intervals_to_string): No longer inline.
1533 * xdisp.c (window_text_bottom_y, window_box_width)
1534 (window_box_height, window_box_left_offset)
1535 (window_box_right_offset, window_box_left, window_box_right)
1536 (window_box): No longer inline.
1537
105216ed
CY
15382011-11-08 Chong Yidong <cyd@gnu.org>
1539
1540 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1541 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1542 Signal an error if not a live window.
105216ed
CY
1543 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1544 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1545
ae9e237f
JB
15462011-11-07 Juanma Barranquero <lekktu@gmail.com>
1547
1548 * lisp.h (syms_of_abbrev): Remove declaration.
1549 Reported by CHENG Gao <chenggao@royau.me>.
1550
c7aa8333
EZ
15512011-11-07 Eli Zaretskii <eliz@gnu.org>
1552
1553 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1554 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1555 of temacs in GUI mode.
1556
be7f5545
MR
15572011-11-07 Martin Rudalics <rudalics@gmx.at>
1558
1559 * window.h: Declare delete_all_child_windows instead of
1560 delete_all_subwindows.
1561 * window.c (Fwindow_nest, Fset_window_nest)
1562 (Fset_window_new_total, Fset_window_new_normal)
1563 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1564 (delete_all_subwindows): Rename to delete_all_child_windows.
1565 (Fdelete_other_windows_internal, Fset_window_configuration):
1566 Call delete_all_child_windows instead of delete_all_subwindows.
1567 * frame.c (delete_frame): Call delete_all_child_windows instead
1568 of delete_all_subwindows.
1569
ca78dc43
PE
15702011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1571
1572 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1573 This is also needed for porting to any host where GC_MARK_STACK is
1574 not GC_MAKE_GCPROS_NOOPS.
1575 (which_symbols): Use it.
1576
a0241d01
KH
15772011-11-07 Kenichi Handa <handa@m17n.org>
1578
1579 * coding.c (coding_set_destination): Check coding->src_pos only
1580 when coding->src_object is a buffer (bug#9910).
1581
1582 * process.c (send_process): Set the member src_multibyte of coding
1583 to 0 (bug#9911) when sending a unibyte text.
1584
1585 * callproc.c (Fcall_process): Set the member src_multibyte of
1586 process_coding to 0 (bug#9912).
1587
a64bfdfa 15882011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1589
1590 * xmenu.c (cleanup_widget_value_tree): New function.
1591 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1592 calling free_menubar_widget_value_tree directly (Bug#9830).
1593
cb41b32a
PE
15942011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1595
1596 Fix some portability problems with 'inline'.
1597 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1598 (window_box_width, window_box_left, window_box_left_offset)
1599 (window_box_right, window_box_right_offset): Declare extern.
1600 Otherwise, these inline functions do not conform to C99 and
1601 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1602 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1603 * intervals.c (adjust_intervals_for_insertion)
1604 (adjust_intervals_for_deletion): Now extern, because otherwise the
1605 extern inline functions 'offset_intervals' couldn't refer to it.
1606 (static_offset_intervals): Remove.
1607 (offset_intervals): Rewrite using the old contents of
1608 static_offset_intervals. The old version didn't conform to C99
1609 because an extern inline function contained a reference to an
1610 identifier with static linkage.
1611
b7041366
AS
16122011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1613
1614 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1615 GC.
1616
88a37c4d
EZ
16172011-11-06 Eli Zaretskii <eliz@gnu.org>
1618
1619 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1620 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1621 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1622 return Qleft_to_right.
1623
49745b39
CY
16242011-11-06 Chong Yidong <cyd@gnu.org>
1625
1626 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1627 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1628 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1629 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1630 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1631 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1632 (Fwindow_vscroll): Doc fix.
1633 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1634 argument, since it makes no sense to pass a live window and for
1635 consistency with window-child.
1636
1f05cd82
CS
16372011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1638
1639 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1640 support MSVC.
1641
22610910
JR
16422011-11-05 Jason Rumney <jasonr@gnu.org>
1643
1644 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1645 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1646 fonts (Bug#6029).
1647 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1648 bitwise arithmetic preventing use of unicode-sip and non-truetype
1649 opentype fonts.
1650
a06776b2
EZ
16512011-11-05 Eli Zaretskii <eliz@gnu.org>
1652
3ad924ba
EZ
1653 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1654 "emacs"-only part.
1655
a06776b2
EZ
1656 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1657 initialization code to keep similarity to xfns.c after changes
1658 from 2011-11-05.
1659
c9e7db78
JD
16602011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1661
a97f8f3f
JD
1662 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1663 (unwind_create_frame): New function (Bug#9943).
1664 (Fx_create_frame): Restructure code to be more similar to the one in
1665 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1666 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1667 Move terminal->reference_count++ just before making the frame official
1668 (Bug#9943).
1669
1670 * nsterm.m (x_free_frame_resources): New function.
1671 (x_destroy_window): Move code to x_free_frame_resources.
1672
c9e7db78 1673 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1674 (Fx_create_frame, x_create_tip_frame):
1675 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1676 official. Move initialization of image_cache_refcount and
1677 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1678
a6fc3b5c
EZ
16792011-11-05 Eli Zaretskii <eliz@gnu.org>
1680
1681 Support MSVC build with newer versions of Visual Studio.
1682 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1683 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1684 nt/gmake.defs.
1685
1686 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1687 which are not supported by MSVC.
1688 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1689 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1690 bitfields.
1691 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1692 types in bitfields.
1693 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1694
1695 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1696
58179cce 16972011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1698
1699 Support MSVC build with newer versions of Visual Studio.
1700 * w32.c: Don't include w32api.h for MSVC.
1701 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1702
1703 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1704 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1705 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1706 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1707 e_* cousins.
1708 (alloca) [_MSC_VER]: Define to _alloca.
1709
1710 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1711
1712 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1713
a58c13ed
EZ
17142011-11-04 Eli Zaretskii <eliz@gnu.org>
1715
1716 * xdisp.c (note_mouse_highlight): If either of
1717 previous/next-single-property-change returns nil, treat that as
1718 the beginning or the end of the buffer. (Bug#9955)
1719
fe0b6370
JD
17202011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1721
a58c13ed 1722 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1723 label is not null (Bug#9951).
1724 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1725 may be NULL.
1726
89bd5ee1
EZ
17272011-11-04 Eli Zaretskii <eliz@gnu.org>
1728
1729 * window.c (Fwindow_body_size): Mention in the doc string that the
1730 return value is in frame's canonical units. (Bug#9949)
1731
84c3edb9
EZ
17322011-11-03 Eli Zaretskii <eliz@gnu.org>
1733
4e2fb5c7
EZ
1734 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1735
84c3edb9 1736 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1737 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1738 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1739
bc17a887
EZ
17402011-11-01 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1743 Don't stop backward scan on the continuation glyph, even though
1744 its CHARPOS is positive.
6d5eb5b0
SM
1745 (mouse_face_from_buffer_pos, note_mouse_highlight):
1746 Rename cover_string to disp_string.
bc17a887 1747
4ee88440
MR
17482011-11-01 Martin Rudalics <rudalics@gmx.at>
1749
1750 * window.c (temp_output_buffer_show): Don't use
1751 Vtemp_buffer_show_specifiers.
1752 (Vtemp_buffer_show_specifiers): Remove unused variable.
1753
c2ff3c02
EZ
17542011-10-30 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1757 past the beginning of the current glyph matrix.
1758
58179cce 17592011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1760
1761 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1762 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1763 HAVE_GTK3 (Bug#9869).
b77a6a7f 1764
3b574623
JD
1765 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1766 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1767
b77a6a7f
JD
1768 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1769
1770 * xterm.c: Declare x_handle_net_wm_state to return int.
1771 (handle_one_xevent): Check if we are iconified but don't have
1772 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1773 (get_current_wm_state): Return non-zero if not hidden,
1774 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1775 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1776 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1777 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1778
196e41e4
PE
17792011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1782 so that this new function doesn't get optimized away by a
1783 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1784
021f2e1a
AS
17852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1786
1787 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1788
8b058d44
EZ
17892011-10-29 Eli Zaretskii <eliz@gnu.org>
1790
1791 Fix the `xbytecode' command.
1792 * .gdbinit (xprintbytestr): New command.
b50a28de 1793 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1794 (xbytecode): Print the byte-code string as well.
1795
4452fb80
EZ
17962011-10-29 Kim Storm <storm@cua.dk>
1797
8b058d44
EZ
1798 * alloc.c (which_symbols): New function.
1799
21b72067
AS
18002011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1801
1802 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1803 line. (Bug#9903)
1804
83ed7b5c
GM
18052011-10-29 Glenn Morris <rgm@gnu.org>
1806
1807 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1808 Not clear what it was for, and it causes various bugs. (Bug#9839)
1809
5a7a728b
EZ
18102011-10-28 Eli Zaretskii <eliz@gnu.org>
1811
1812 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1813 possible random value that matches one of those tested as
1814 condition to clear the mouse face.
1815
d3d0842f
CY
18162011-10-28 Chong Yidong <cyd@gnu.org>
1817
1818 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1819
31b39d13
DN
18202011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1821
1822 * window.c (make_window): Initialize phys_cursor_on_p.
1823
9aba6043
SM
18242011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1825
1826 * lisp.h (struct Lisp_Symbol): Update comments.
1827
c20992f4
JB
18282011-10-28 Juanma Barranquero <lekktu@gmail.com>
1829
1830 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1831
db4f02f2
EZ
18322011-10-28 Eli Zaretskii <eliz@gnu.org>
1833
1834 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1835 <oslsachem@gmail.com> for helping to debug this.
1836
1837 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1838 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1839 (g_b_init_get_glyph_outline_w): New static variables.
1840 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1841 (GetGlyphOutlineW_Proc): New typedefs.
1842 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1843 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1844 New functions.
1845 (w32font_open_internal, compute_metrics):
1846 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1847 instead of calling the "wide" APIs directly.
1848
1849 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1850
1851 * w32.h (syms_of_w32font): Add prototype.
1852
87e68db4
JB
18532011-10-27 Juanma Barranquero <lekktu@gmail.com>
1854
1855 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1856 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1857 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1858 (Fmove_to_window_line): Doc fix.
1859
435c1d67
CY
18602011-10-27 Chong Yidong <cyd@gnu.org>
1861
1862 * process.c (make_process): Set gnutls_state to NULL.
1863
1864 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1865 non-NULL, regardless of GNUTLS_INITSTAGE.
1866 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1867 an error. Set process slots as soon as we allocate them.
1868
1869 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1870
9c6c6f49
CY
18712011-10-27 Chong Yidong <cyd@gnu.org>
1872
9aba6043
SM
1873 * gnutls.c (emacs_gnutls_deinit): New function.
1874 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1875 (Fgnutls_deinit, Fgnutls_boot): Use it.
1876
1877 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1878 (deactivate_process): Call emacs_gnutls_deinit.
1879
657d08d3
JB
18802011-10-27 Juanma Barranquero <lekktu@gmail.com>
1881
1882 * image.c (x_create_x_image_and_pixmap):
1883 * w32.c (sys_rename, w32_delayed_load):
1884 * w32font.c (fill_in_logfont):
1885 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1886
5430d399
JB
18872011-10-26 Juanma Barranquero <lekktu@gmail.com>
1888
1889 * w32fns.c (w32_default_color_map): New function,
1890 extracted from Fw32_default_color_map.
a7ef684b 1891 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1892
fe0055fa
PE
18932011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1896
e6346438
SM
18972011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1898
1899 * keyboard.c (test_undefined): New function (bug#9751).
1900 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1901
e112cc37
ET
19022011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1903
1904 * sysdep.c (init_sys_modes): Fix the check for the controlling
1905 terminal (Bug#6649).
1906
7b5d6677
EZ
19072011-10-20 Eli Zaretskii <eliz@gnu.org>
1908
1909 * dispextern.h (struct bidi_it): New member next_en_type.
1910
1911 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1912 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1913 current character, check also for next_en_type being WEAK_EN.
1914 (bidi_resolve_weak): Don't enter the expensive loop if the current
1915 position is before next_en_pos. Record the bidi type of the first
1916 non-ET, non-BN character we find, in addition to its position.
1917 (bidi_level_of_next_char): Invalidate next_en_type when
1918 next_en_pos is over-stepped.
1919
7da0b018
PE
19202011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1923 * editfns.c: Rewrite current-time-zone so that it invokes
1924 the equivalent of (format-time-string "%Z") to get the time zone name.
1925 This fixes a bug when the time zone name contains characters that
1926 need converting from the system time locale to Emacs internal format.
1927 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1928 that patch fixed format-time-string to do the conversion, but
1929 I forgot to fix current-time-zone.
1930 (format_time_string): New function, containing most of
1931 what Fformat_time_string used to contain.
1932 (Fformat_time_string): Rewrite in terms of format_time_string.
1933 This doesn't change this function's behavior.
1934 (current-time-zone): Rewrite to use format_time_string.
1935 This fixes the bug reported by Michael Schierl in
1936 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1937 Jason Rumney's 2007-06-07 change worked around this bug, but
1938 didn't fix it.
1939 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1940
8547b010
EZ
19412011-10-19 Eli Zaretskii <eliz@gnu.org>
1942
1943 * xdisp.c (start_display): If the character at POS is displayed
1944 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1945 (try_window_reusing_current_matrix): If a line ends in a display
1946 vector or the next line starts in a display vector, continue
1947 redrawing the window even though the character position of
1948 start_row was reached.
8547b010
EZ
1949 (Bug#9771, part 2)
1950
4e948d15
CY
19512011-10-18 Chong Yidong <cyd@gnu.org>
1952
1953 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1954 with nobreak-char-display too.
1955
4787455f
EZ
19562011-10-18 Eli Zaretskii <eliz@gnu.org>
1957
1958 Fix part 3 of bug#9771.
1959 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1960 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1961 non-neutral characters if the current character is a paragraph
1962 separator (a.k.a. Newline). This avoids running the same
1963 expensive loop twice, once when we consume the preceding newline
1964 and the other time when the line actually needs to be displayed.
1965 Avoid the loop when we see neutrals on the base embedding level
1966 following a character whose directionality is the same as the
1967 paragraph's. This avoids running the expensive loop when a line
1968 ends in a long sequence of neutrals, like control characters.
1969 Add assertion against STRONG_AL type. Slightly rearrange code
1970 that determines the type of a neutral given the first non-neutral
1971 that follows it.
1972 (bidi_level_of_next_char): Set next_en_pos to zero when
1973 invalidating its info.
1974
2c91f553
EZ
19752011-10-17 Eli Zaretskii <eliz@gnu.org>
1976
1977 * xdisp.c (push_display_prop): Determine whether to record string
1978 or buffer position by IT->string, not by IT->method. Allow
1979 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1980 (move_it_vertically_backward): Don't look for character position
1981 immediately after the newline when in a continuation line.
1982 (Bug#9771, part 1)
2c91f553 1983
c7b08b0d
MR
19842011-10-15 Martin Rudalics <rudalics@gmx.at>
1985
1986 * window.c (coordinates_in_window): Rewrite and delabelize
1987 vertical border check. (Bug#5357) (Bug#9618)
1988
6b02f655
SM
19892011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1990
1991 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1992 errors in XSetWindowBorder (bug#9310).
1993
81d40c92
DA
19942011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1995
1996 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1997 avoid crash when xmalloc overrun checking is enabled.
1998
d4172c3b
EZ
19992011-10-13 Eli Zaretskii <eliz@gnu.org>
2000
2001 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2002 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2003 cursor motion with <left> and <right> arrow keys.
2004
2005 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2006 some callers set that themselves.
2007
b00eea75
EZ
20082011-10-12 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2011 display string and the previous row comes from the same string and
2012 is empty. (Bug#9739) (Bug#9738)
2013
8fe012c4
SM
20142011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2015
2016 * doc.c (get_doc_string): Encode file name (bug#9735).
2017
0074aef2
EZ
20182011-10-12 Eli Zaretskii <eliz@gnu.org>
2019
79beb178
EZ
2020 * bidi.c (bidi_level_of_next_char):
2021 * xdisp.c (get_visually_first_element): Remove old incorrect
2022 comments regarding the Unicode Line Separator character.
2023
0074aef2
EZ
2024 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2025
6e4b3fbe
DA
20262011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2027
2028 * alloc.c (Fgc_status): Do not access beyond zombies array
2029 boundary if nzombies > MAX_ZOMBIES.
2030 * alloc.c (dump_zombies): Add missing format specifier.
2031
0324f3af
PE
20322011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2033
b5525cac
PE
2034 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2035 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2036
0324f3af
PE
2037 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2038 Some packages use them to denote characters with modifiers.
2039
e9b5f888
AS
20402011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2041
2042 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2043 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2044 matching a pp-number. Rename parameter var to var1.
2045
127827c0
SM
20462011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2047
2048 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2049
c8fd3bd0
GM
20502011-10-08 Glenn Morris <rgm@gnu.org>
2051
2052 * callint.c (Fcall_interactively): Give a more explicit error for the
2053 'c' case with a non-character input. (Bug#8479)
2054
352ec8ff
EZ
20552011-10-08 Eli Zaretskii <eliz@gnu.org>
2056
03669ccb
EZ
2057 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2058 lines.
7061c986
EZ
2059 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2060 lines that are hscrolled on the left.
03669ccb 2061
352ec8ff
EZ
2062 * dispnew.c (buffer_posn_from_coords): Account for a possible
2063 presence of header-line. (Bug#4426)
2064
a66cfb1c
SM
20652011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2066
6b02f655
SM
2067 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2068 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2069
7c5ee88e
PE
20702011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2073 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2074 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2075 this makes Emacs dump core during garbage collection on rare
2076 occasions. sizeof is obviously inferior to offsetof here, so
2077 stick with offsetof.
2078 (GC_POINTER_ALIGNMENT): New macro.
2079 (mark_memory): Omit 3rd (offset) arg; caller changed.
2080 Don't assume EMACS_INT alignment is the same as pointer alignment.
2081
df1bbe5b
SM
20822011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2083
2084 * keyboard.c (read_key_sequence_remapped): New var.
2085 (read_key_sequence): Compute remapping in the right buffer.
2086 (command_loop_1): Use read_key_sequence's remapping directly.
2087
51553db6
SM
20882011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2089
32c1fffd
SM
2090 * dired.c (file_name_completion): Don't expand file name.
2091 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2092 before checking file name handler.
2093
51553db6
SM
2094 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2095 they've been requested explicitly (bug#9591).
2096
b6bd1599 20972011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2098
2099 * keymap.c (Fsingle_key_description): Use make_specified_string
2100 instead of build_string to build string from push_key_description.
2101 (Bug#5193)
2102
f701dc2a
PE
21032011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2104
4222c55d
PE
2105 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2106 This fixes a Y2038 bug on 64-bit hosts.
2107 * buffer.c (reset_buffer):
2108 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2109 (Fclear_buffer_auto_save_failure):
2110 Use 0, not -1, to represent an unset failure time, since time_t
2111 might not be signed.
2112
f701dc2a
PE
2113 Remove dependency on glibc malloc internals.
2114 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2115 Move back here from lisp.h, but with their new implementations.
2116 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2117 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2118 * charset.c (charset_table_init): New static var.
2119 (syms_of_charset): Use it instead of xmalloc. This removes a
2120 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2121 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2122 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2123 Move back to alloc.c.
2124 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2125 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2126
9ceebf39
JD
21272011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2128
2129 * nsterm.m (windowDidResize): Call x_set_window_size only when
2130 ns_in_resize is true. Otherwise set pixelwidth/height and
2131 call change_frame_size (Bug#9628).
2132
cb993c58
PE
21332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2134
3930c88b
PE
2135 Port --enable-checking=all to Fedora 14 x86-64.
2136 * charset.c (syms_of_charset): Also account for glibc malloc's
2137 internal overhead when calculating the initial malloc maximum.
2138
cb993c58
PE
2139 Port --enable-checking=all to Fedora 14 x86.
2140 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2141 Move to lisp.h.
2142 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2143 (overrun_check_realloc, overrun_check_free):
2144 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2145 That way, xmalloc returns a properly-aligned pointer even if
2146 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2147 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2148 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2149 into account when calculating the initial malloc maximum.
2150 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2151 Move here from alloc.c, so that charset.c can use it too.
2152 Properly align; the old code wasn't right for common 32-bit hosts
2153 when configured with --enable-checking=all.
2154 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2155 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2156
31bed486
EZ
21572011-09-29 Eli Zaretskii <eliz@gnu.org>
2158
04c70788 2159 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2160 use EDOM.
2161
fbcaa2f3
EZ
21622011-09-28 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (compute_display_string_end): If there's no display
2165 string at CHARPOS, return -1.
2166
2167 * bidi.c (bidi_fetch_char): When compute_display_string_end
2168 returns a negative value, treat the character as a normal
2169 character not covered by a display string. (Bug#9624)
2170
a239d4e9
JB
21712011-09-28 Juanma Barranquero <lekktu@gmail.com>
2172
2173 * lread.c (Fread_from_string): Fix typo in docstring.
2174
88652fd5
EZ
21752011-09-27 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2178 newline, reseat the iterator instead of bidi-iterating there one
2179 character at a time. (Bug#9610)
32c1fffd
SM
2180 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2181 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2182
ed497dd4
AS
21832011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2184
2185 * lread.c (readevalloop): Use correct code for NBSP.
2186 (read1): Likewise. (Bug#9608)
2187
b2bf61aa
MA
21882011-09-25 Michael Albinus <michael.albinus@gmx.de>
2189
2190 * dbusbind.c (Fdbus_register_signal): When service is not
2191 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2192
32bbb17c
GM
21932011-09-25 Glenn Morris <rgm@gnu.org>
2194
2195 * buffer.c (truncate-lines): Doc fix.
2196
94e0933e
CY
21972011-09-24 Chong Yidong <cyd@stupidchicken.com>
2198
2199 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2200 (Fset_window_next_buffers): Doc fix.
2201
cddde921
GM
22022011-09-24 Glenn Morris <rgm@gnu.org>
2203
2204 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2205
1260aef1
PE
22062011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2207
25b4bfa0
PE
2208 Fix minor problems found by static checking.
2209 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2210 * indent.c (Fvertical_motion): Fix == vs = typo.
2211
e3cbd34b
EZ
22122011-09-24 Eli Zaretskii <eliz@gnu.org>
2213
a66cfb1c
SM
2214 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2215 Default value is now t. Doc fix.
6bf7006f 2216
e3cbd34b 2217 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2218 logic when moving up, not only when moving down. Fix the
e3cbd34b 2219 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2220 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2221
2222 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2223 CHARPOS is covered by a display string which includes newlines.
2224 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2225 is covered by a display string with embedded newlines.
2226
a3de0cbd
MA
22272011-09-24 Michael Albinus <michael.albinus@gmx.de>
2228
2229 * dbusbind.c (Fdbus_register_signal): Add match rule to
2230 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2231 (Fdbus_register_method, Vdbus_registered_objects_table):
2232 Fix docstring.
a3de0cbd 2233
b260039d
JM
22342011-09-24 Jim Meyering <meyering@redhat.com>
2235
32c1fffd 2236 do not ignore write error for any output size
b260039d
JM
2237 The previous change was incomplete.
2238 While it makes emacs --batch detect the vast majority of stdout
2239 write failures, errors were still ignored whenever the output size is
2240 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2241 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2242 && echo FAIL: ignored write error
2243 FAIL: ignored write error
2244 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2245 && echo FAIL: ignored write error
2246 FAIL: ignored write error
2247 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2248
8eca8a7c
AS
22492011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2250
2251 * emacs.c (Fkill_emacs): In noninteractive mode exit
2252 non-successfully if a write error occurred on stdout. (Bug#9574)
2253
3341db62
EZ
22542011-09-21 Eli Zaretskii <eliz@gnu.org>
2255
2256 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2257 the xassert test.
2258
2259 * dispextern.h (struct it): Update the comment documenting what
2260 can it->OBJECT be.
2261
8c203dbf
EZ
22622011-09-20 Eli Zaretskii <eliz@gnu.org>
2263
2264 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2265 a display string, extend search for cursor position to end of row.
2266 (find_row_edges): If the row ends in a newline from a display
2267 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2268 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2269 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2270 non-empty line. Fixes confusing cursor motion with arrow keys at
2271 the beginning of a line that starts with whitespace.
8c203dbf 2272
a4824228
LMI
22732011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2274
2275 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2276 (bug#9493).
2277
33ed493b
CY
22782011-09-18 Chong Yidong <cyd@stupidchicken.com>
2279
2280 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2281 boolean (Bug#9154).
2282
56cd55c8
EZ
22832011-09-18 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (display_line): Record maximum and minimum buffer
2286 positions even if no glyphs were produced (e.g., by a zero-width
2287 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2288 buffer positions that will be removed from the glyph row because
2289 they don't fit.
c02dcedf
EZ
2290 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2291 column is beyond frame width: don't subtract 1 "pixel" when
2292 computing width of the stretch.
3e62b7e0
EZ
2293 (reseat_at_next_visible_line_start): Undo the change made on
2294 2011-09-17 that saved paragraph information and restored it after
2295 the call to `reseat'. (Bug#9545)
56cd55c8 2296
5ed99d36 22972011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2298
2299 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2300 and turn window cursor on if cleared (Bug#9415).
2301
5ed99d36 23022011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2303
2304 * search.c (boyer_moore): Take unibyte characters from pattern
2305 literally. (Bug#9458)
2306
9bade7b2
EZ
23072011-09-18 Eli Zaretskii <eliz@gnu.org>
2308
2309 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2310
e5e9d610
PE
23112011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2312
87e4427a
PE
2313 Fix minor problem found by static checking.
2314 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2315 initialized, to pacify gcc -Wuninitialized.
2316
e5e9d610
PE
2317 * fileio.c: Report proper errno when syscall falls.
2318 (Finsert_file_contents): Save and restore errno,
2319 so that report_file_error outputs the correct diagnostic.
2320 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2321
a1674f0b
EZ
23222011-09-18 Eli Zaretskii <eliz@gnu.org>
2323
2324 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2325
fbfb6dd4
EZ
23262011-09-17 Eli Zaretskii <eliz@gnu.org>
2327
2328 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2329 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2330
bb187662
EZ
23312011-09-17 Eli Zaretskii <eliz@gnu.org>
2332
1137e8b8 2333 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2334 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2335
2336 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2337 (bidi_find_paragraph_start): Search back for paragraph beginning
2338 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2339 (bidi_move_to_visually_next): Only trigger paragraph-related
2340 computations when the last character is a newline or at EOB, not
2341 just any NEUTRAL_B. (Bug#9470)
2342
bb187662
EZ
2343 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2344 truncated lines if point is covered by a display string. (Bug#9524)
2345
2e621251
PE
23462011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2347
2348 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2349 (cons_to_x_long): New function.
2350 (lisp_data_to_selection_data): Use it. Correct the test for
2351 short-versus-long data; it was negated. Break out of vector
2352 loop, for efficiency, when a long datum is discovered.
2353
91a15bc6
SM
23542011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2355
2356 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2357
b41c3a35
EZ
23582011-09-16 Eli Zaretskii <eliz@gnu.org>
2359
2360 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2361 GCC PR/17406) by declaring this function with external scope.
2362
7812ba2d
PE
23632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2366 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2367
cf7edc2a
AS
23682011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2369
2370 * editfns.c (Fformat): Correctly handle text properties on "%%".
2371
bd01620e
EZ
23722011-09-15 Eli Zaretskii <eliz@gnu.org>
2373
2374 * xterm.c (x_draw_composite_glyph_string_foreground):
2375 * w32term.c (x_draw_composite_glyph_string_foreground):
2376 * term.c (encode_terminal_code):
2377 * composite.c (composition_update_it, get_composition_id):
2378 * xdisp.c (get_next_display_element)
2379 (fill_composite_glyph_string): Add comments about special meaning
2380 of TAB characters in a composition.
2381
a02719a3
PE
23822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2385 This occurs when processing a multibyte format.
2386 Problem reported by Wolfgang Jenker.
a02719a3 2387
72589a3c
JB
23882011-09-15 Johan Bockgård <bojohan@gnu.org>
2389
2390 * xdisp.c (try_cursor_movement): Only check for exact match if
2391 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2392
1c14176c
PE
23932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2394
2395 Remove unused external symbols.
2396 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2397 * xdisp.c (calc_pixel_width_or_height): Now static.
2398 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2399 * indent.c (check_display_width):
2400 * w32term.c: Fix comment to match code.
2401 * xterm.c, xterm.h (x_catching_errors): Remove.
2402
d2eea5b5
PE
24032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 * xselect.c: Use signed conversions more consistently (Bug#9498).
2406 (selection_data_to_lisp_data): Assume incoming selection data are
2407 signed integers, not unsigned. This is to be consistent with
2408 outgoing selection data, which was modified to use signed integers
2409 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2410 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2411 expects long, not unsigned long.
2412
46888499
EZ
24132011-09-14 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2416 computation of loop end. Reported by Johan Bockgård
2417 <bojohan@gnu.org>.
2418
ef8ef9fb
CY
24192011-09-13 Chong Yidong <cyd@stupidchicken.com>
2420
2421 * frame.c (Fother_visible_frames_p): Function deleted.
2422
fa819fed
EZ
24232011-09-12 Eli Zaretskii <eliz@gnu.org>
2424
2425 * indent.c (compute_motion): Process display vector front to back
2426 rather than the other way around. (Bug#2496)
2427
2ba8e008
SM
24282011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2429
2430 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2431
20f53c69
CY
24322011-09-11 Chong Yidong <cyd@stupidchicken.com>
2433
2434 * minibuf.c (Fread_from_minibuffer): Doc fix.
2435
d562d7a4
EZ
24362011-09-11 Eli Zaretskii <eliz@gnu.org>
2437
2438 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2439 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2440
1c4d7f3d
LMI
24412011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2442
2443 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2444 value for non-existent files.
2445
b885bf36
EZ
24462011-09-11 Eli Zaretskii <eliz@gnu.org>
2447
2448 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2449 set its "size" to -1. This will set the modtime_size field of
2450 the corresponding buffer to -1, which is what
2451 verify-visited-file-modtime expects for files that do not exist.
2452 (Bug#9139)
2453
6612f0bf
PE
24542011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2457 here ...
2458 * lisp.h: ... from here. push_key_description is no longer
2459 defined in keyboard.c, so its declaration should not be in
2460 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2461 logically belongs with push_key_description.
2462
dfb3f755
PE
24632011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 * buffer.h: Include <sys/types.h> instead of <time.h>.
2466 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2467 Problem reported by Herbert J. Skuhra.
2468
3134906c
LMI
24692011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2470
2471 * xml.c (parse_region): Make the parsing work for
2472 non-comment-starting XML files again (bug#9144).
2473
8d903f4e
AS
24742011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2475
2476 * image.c (gif_load): Fix calculation of bottom and right corner.
2477 (Bug#9468)
2478
80ad64f4
EZ
24792011-09-10 Eli Zaretskii <eliz@gnu.org>
2480
2481 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2482 redisplay in small windows.
2483
208a048d
EZ
24842011-09-09 Eli Zaretskii <eliz@gnu.org>
2485
2486 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2487
9b1c252e
MR
24882011-09-08 Martin Rudalics <rudalics@gmx.at>
2489
2490 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2491 Operate on live windows only.
2492
2949f33b
JB
24932011-09-08 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2496
e08dcafd
EZ
24972011-09-07 Eli Zaretskii <eliz@gnu.org>
2498
2499 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2500 only under bidi iteration.
2501
115b96bd
JD
25022011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2503
2504 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2505
c8199d0f
PE
25062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2509 Without this fix, the command to link temacs failed due to an
2510 undefined symbol __builtin_isnan. This is because
2511 /usr/include/iso/math_c99.h #defines isnan(x) to
2512 __builtin_isnan(x), but the bundled gcc, which identifies itself
2513 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2514 a __builtin_isnan.
2515 * floatfns.c (isnan): #undef, and then #define to a clone of
2516 what's in data.c.
2517 (Fisnan): Always define, since it's always available now.
2518 (syms_of_floatfns): Always define isnan at the Lisp level.
2519
e39b275c 25202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2521
2522 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2523
b2db44d9 25242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2525
f4af5137 2526 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2527 The previous code assumed that file offsets (off_t values) fit in
2528 EMACS_INT variables, which is not true on typical 32-bit hosts.
2529 The code messed up by falsely reporting buffer overflow in cases
2530 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2531 when "big" contains more than 2**29 bytes, even though this
2532 inserts just one byte and does not overflow the buffer.
2533 (Finsert_file_contents): Store file offsets as off_t
2534 values, not as EMACS_INT values. Check for overflow when
2535 converting between EMACS_INT and off_t. When checking for
2536 buffer overflow or for overlap, take the offsets into account.
2537 Don't use EMACS_INT for small values where int suffices.
2538 When checking for overlap, fix a typo: ZV was used where
2539 ZV_BYTE was intended.
2540 (Fwrite_region): Don't assume off_t fits into 'long'.
2541 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2542
ecfc0a49
MA
25432011-09-05 Michael Albinus <michael.albinus@gmx.de>
2544
2545 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2546
6511acf2 25472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2548
0999621a 2549 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2550
2551 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2552 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2553 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2554 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2555 (modify_event_symbol): Do not assume that the length of
2556 name_alist_or_stem is safe to alloca and fits in int.
2557 (Fexecute_extended_command): Likewise for function name and binding.
2558 (Frecursion_depth): Wrap around reliably on integer overflow.
2559 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2560 since some callers pass EMACS_INT values.
2561 (Fsingle_key_description): Don't crash if symbol name contains more
2562 than MAX_ALLOCA bytes.
2563 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2564 (get_minibuffer): Arg is now EMACS_INT, not int.
2565 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2566 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2567 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2568
2be7d702
PE
2569 * dbusbind.c (signature_cat): New function.
2570 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2571 Do not overrun buffer; instead, report string overflow.
2572
9d1df220
PE
2573 * dispnew.c (add_window_display_history): Don't overrun buffer.
2574 Truncate instead; this is OK since it's just a log.
2575
33ef5c64
PE
2576 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2577 even if the time zone offset is outlandishly large.
2578 Don't mishandle offset == INT_MIN.
2579
66c6fdd5
PE
2580 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2581 when creating daemon; the previous buffer-overflow check was incorrect.
2582
d749b01b
PE
2583 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2584 which has the guts of the old verror function.
2585
b5cd1905
PE
2586 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2587 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2588
6e1a67fb
PE
2589 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2590 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2591 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2592 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2593 length of string rather than counting it via multiple sprintfs;
2594 that's simpler and more reliable.
c21721cc
PE
2595 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2596 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2597 sprintf, in case result does not fit in int.
2598
c57b67fc
PE
2599 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2600 (fontset_from_font): Print it.
2601
8a401434
PE
2602 * frame.c (tty_frame_count): Now printmax_t, not int.
2603 (make_terminal_frame, set_term_frame_name): Print it.
2604 (x_report_frame_params): In X, window IDs are unsigned long,
2605 not signed long, so print them as unsigned.
2606 (validate_x_resource_name): Check for implausibly long names,
2607 and don't assume name length fits in 'int'.
2608 (x_get_resource_string): Don't blindly alloca invocation name;
2609 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2610 not fit in int.
2611
6e1a67fb
PE
2612 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2613 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2614 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2615
0df02bf3
PE
2616 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2617 Use esprintf, not sprintf, in case result does not fit in int.
2618
48e30793
PE
2619 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2620 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2621 it as a large positive number.
2622 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2623 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2624
a66ff6d8
PE
2625 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2626 in case result does not fit in int.
2627
aca216ff
PE
2628 * print.c (float_to_string): Detect width overflow more reliably.
2629 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2630 buffer overrun. Don't assume list length fits in 'int'. Treat
2631 print length of 0 as 0, not as infinity; to be consistent with other
2632 uses of print length in this function. Don't overflow print length
2633 index. Don't assume hash table size fits in 'long', or that
2634 vectorlike size fits in 'unsigned long'.
2635
31c286f7
PE
2636 * process.c (make_process): Use printmax_t, not int, to format
2637 process-name gensyms.
2638
55e5faa1
PE
2639 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2640
80f2e268
PE
2641 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2642 to avoid potential buffer overrun.
2643
670741ab
PE
2644 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2645 if X resource line is longer than 512 bytes.
2646
b7163a50
PE
2647 * xfns.c (x_window): Make sprintf buffer a bit bigger
2648 to avoid potential buffer overrun.
2649
ae58ff1f
PE
2650 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2651
c43c8a6a
PE
2652 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2653
3f8236f4
PE
26542011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2655
53e9fe90 2656 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2657 Without these, Emacs silently mishandles large integers sometimes.
2658 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2659 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2660
6511acf2
PE
2661 * xdisp.c (try_window_id): Check Emacs fixnum range before
2662 converting to 'int'.
806add1d 2663
6511acf2 2664 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2665 Check that an Emacs fixnum is in range before assigning it to 'int'.
2666 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2667 values converted from Emacs fixnums.
2668 (Frecenter): Don't wrap around a line count if it is out of 'int'
2669 range; instead, treat it as an extreme value.
2670 (Fset_window_configuration, compare_window_configurations):
2671 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2672
6511acf2
PE
2673 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2674 that can exceed INT_MAX. Check that EMACS_INT value is in range
2675 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2676 (match_limit): Don't assume that a fixnum can fit in 'int'.
2677
6511acf2 2678 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2679 exceed INT_MAX.
2680
6511acf2 2681 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2682 (Fvertical_motion): Don't wrap around LINES values that don't fit
2683 in 'int'. Instead, treat them as extreme values. This is good
2684 enough for windows, which can't have more than INT_MAX lines anyway.
2685
fcb901a7
LMI
26862011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2687
0f2f6b6d
LMI
2688 * Require libxml/parser.h to avoid compilation warning.
2689
fcb901a7
LMI
2690 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2691
2692 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2693 since this reportedly can destroy thread storage.
2694
6e20a0d4
CY
26952011-08-30 Chong Yidong <cyd@stupidchicken.com>
2696
2697 * syntax.c (find_defun_start): Update all cache variables if
2698 exiting early (Bug#9401).
2699
148ae00e
EZ
27002011-08-30 Eli Zaretskii <eliz@gnu.org>
2701
f6cfbd8f
EZ
2702 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2703
148ae00e
EZ
2704 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2705 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2706 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2707
2708 * term.c (tty_append_glyph): New function.
2709 (produce_stretch_glyph): Static function and its prototype deleted.
2710
a66cfb1c
SM
2711 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2712 Add prototypes.
148ae00e 2713
c4a07a4c
PE
27142011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2717 when checking :margin (Bug#9390).
2718 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2719 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2720 so that the name doesn't mislead. All uses changed.
2721
6bc8cd65
JB
27222011-08-28 Johan Bockgård <bojohan@gnu.org>
2723
2724 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2725 set_tty_hooks.
2726
dca4927e
EZ
27272011-08-27 Eli Zaretskii <eliz@gnu.org>
2728
2729 * xdisp.c (move_it_to): Don't bail out early when reaching
2730 position beyond to_charpos, if we are scanning backwards.
2731 (move_it_vertically_backward): When DY == 0, make sure we get to
2732 the first character in the line after the newline.
2733
f2cad773
PE
27342011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2735
2736 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2737 (ccl_driver): Do not generate an out-of-range pointer.
2738 (Fccl_execute_on_string): Remove unnecessary check for
2739 integer overflow, noted by Stefan Monnier in
2740 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2741 Remove a FIXME that didn't need fixing.
2742 Simplify the newly-introduced buffer reallocation code.
2743
0cae2cdb
JB
27442011-08-27 Juanma Barranquero <lekktu@gmail.com>
2745
2746 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2747
5fc295a4 27482011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2749
70c60eb2 2750 Integer and memory overflow issues (Bug#9196).
726e0ab1 2751
d31850da
PE
2752 * doc.c (get_doc_string): Rework so that
2753 get_doc_string_buffer_size is the actual buffer size, rather than
2754 being 1 less than the actual buffer size; this makes xpalloc more
2755 convenient.
2756
a69fbedb
PE
2757 * image.c (x_allocate_bitmap_record, cache_image):
2758 * xselect.c (Fx_register_dnd_atom):
2759 Simplify previous changes by using xpalloc.
2760
fe5c5d37
PE
2761 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2762 since either will do and ptrdiff_t is convenient with xpalloc.
2763
0065d054
PE
2764 * charset.c (charset_table_size)
2765 (struct charset_sort_data.priority): Now ptrdiff_t.
2766 (charset_compare): Don't overflow if priorities differ greatly.
2767 (Fsort_charsets): Don't assume list length fits in int.
2768 Check for size-calculation overflow when allocating sort data.
2769 (syms_of_charset): Allocate an initial charset table that is
2770 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2771
2772 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2773
2774 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2775 The actual value is always <= INT_MAX, and leaving it unsigned made
2776 overflow checking harder.
2777
2778 * dispextern.h (struct glyph_matrix.rows_allocated)
2779 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2780 with xpalloc. The values are still always <= INT_MAX.
2781
2782 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2783
2784 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2785 (SAFE_NALLOCA): New macro.
2786
2787 * region-cache.c (struct boundary.pos, find_cache_boundary)
2788 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2789 (set_cache_region, invalidate_region_cache)
2790 (revalidate_region_cache, know_region_cache, region_cache_forward)
2791 (region_cache_backward, pp_cache):
2792 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2793 so that ptrdiff_t * can be passed to xpalloc.
2794 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2795 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2796 (pp_cache): Don't assume cache_len fits in int.
2797 * region-cache.h: Adjust extern decls to match.
2798
2799 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2800 EMACS_INT, since either will do, for xpalloc.
2801
2802 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2803 (xnmalloc, xnrealloc, xpalloc): New functions.
2804
726e0ab1
PE
2805 * bidi.c (bidi_shelve_header_size): New constant.
2806 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2807 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2808
51f30bc5 2809 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2810 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2811 (overlay_strings):
2812 Don't update size of array until after memory allocation succeeds,
2813 because xmalloc/xrealloc may not return.
0065d054
PE
2814 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2815 now that we have proper integer overflow checking.
2816 (record_overlay_string, overlay_strings): Catch overflows when
2817 calculating size of overlay_str_buf.
726e0ab1 2818
0065d054
PE
2819 * callproc.c (Fcall_process): Check for size overflow when
2820 calculating size of args2.
2821 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2822 Normally we prefer signed values, but sticking with ptrdiff_t would
2823 require adding more-complicated checks.
726e0ab1
PE
2824
2825 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2826 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2827 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2828 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2829
2830 * character.c (Fstring): Check for size-calculation overflow.
2831
2832 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2833 unnecessary integer overflow. Check for size overflow.
2834 (encode_coding_object): Don't update size until xmalloc succeeds.
2835
2836 * composite.c (get_composition_id): Check for overflow in glyph
2837 length calculations.
2838
2839 Integer and memory overflow fixes for display code.
2840 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2841 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2842 (scrolling_window): Check for overflow in size calculations.
2843 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2844 Don't assume glyph table len fits in int.
2845 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2846 (row_table_size): Now ptrdiff_t, not int.
2847 (scrolling_window): Avoid overflow in size calculations.
2848 Don't update size until allocation succeeds.
2849 * fns.c (concat): Check for overflow in size calculations.
2850 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2851 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2852 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2853
2854 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2855 (get_doc_string): Check for size calculation overflow.
2856 Don't update size until allocation succeeds.
2857 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2858 EMACS_INT, where ptrdiff_t will do.
2859 (Fsubstitute_command_keys): Check for string overflow.
2860
2861 * editfns.c (set_time_zone_rule): Don't assume environment length
2862 fits in int.
2863 (message_length): Now ptrdiff_t, not int.
2864 (Fmessage_box): Don't update size until allocation succeeds.
2865 Don't assume message length fits in int.
2866 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2867
0065d054
PE
2868 * emacs.c (main): Do not reallocate argv, since there is a null at
2869 the end that can be overwritten, and this way there's no need to
2870 worry about size-calculation overflow.
2871 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2872
2873 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2874 alloc succeeds.
2875 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2876
2877 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2878 (x_set_scroll_bar_width, x_figure_window_size):
2879 Check for integer overflow.
2880 (x_set_alpha): Do not assume XINT fits in int.
2881
2882 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2883 This is for the members text_lines, text_cols, total_lines, total_cols,
2884 where the system imposes an 'int' limit.
2885
2886 * fringe.c (Fdefine_fringe_bitmap):
2887 Don't update size until alloc works.
2888
2889 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2890 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2891
2892 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2893 Check for size-calculation overflow.
2894 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2895 do, as we prefer signed integers.
2896 (id_to_widget.max_size, id_to_widget.used)
2897 (xg_store_widget_in_map, xg_remove_widget_from_map)
2898 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2899 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2900 Use and return ptrdiff_t, not int.
2901 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2902 * gtkutil.h: Change prototypes to match the above.
2903
2904 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2905 are duplicate now that they've been promoted to lisp.h.
2906 (x_allocate_bitmap_record, x_alloc_image_color)
2907 (make_image_cache, cache_image, xpm_load):
2908 Don't update size until alloc is done.
2909 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2910 (x_detect_edges):
3256efce 2911 Check for size calculation overflow.
726e0ab1
PE
2912 (ct_colors_allocated_max): New constant.
2913 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2914 overflow.
3256efce 2915
726e0ab1
PE
2916 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2917 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2918 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2919 Use ptrdiff_t, not int, to count maps.
2920 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2921 calculations. Don't update size until allocation succeeds.
2922 Redo calculations to avoid overflow.
726e0ab1
PE
2923 * keyboard.h: Change prototypes to match the above.
2924
2925 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2926 to count maps.
2927 (current_minor_maps): Check for size calculation overflow.
2928 * keymap.h: Change prototypes to match the above.
2929
2930 * lread.c (read1, init_obarray): Don't update size until alloc done.
2931
2932 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2933 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2934
726e0ab1
PE
2935 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2936 Now ptrdiff_t, not int.
2937 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2938 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2939
2940 * process.c (Fnetwork_interface_list): Check for overflow
2941 in size calculation.
2942
2943 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2944
2945 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2946 overflow. Don't bother calling xmalloc when xrealloc will do.
2947
2948 * search.c (Freplace_match): Check for size calculation overflow.
2949 (Fset_match_data): Don't assume list lengths fit in 'int'.
2950
2951 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2952 for command line length. Do not attempt to address one before the
2953 beginning of an array, as that's not portable.
2954
2955 * term.c (max_frame_lines): Remove; unused.
2956 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2957 not int.
2958 (encode_terminal_code, calculate_costs): Check for size
2959 calculation overflow.
2960 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2961 table lengths and related sizes. Don't update size until alloc
2962 done. Redo calculations to avoid overflow.
2963 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2964
2965 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2966 subtracting pointers.
2967 (gobble_line): Check for overflow more carefully. Don't update size
2968 until alloc done.
2969
2970 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2971 Don't update size until alloc done.
2972 Redo size calculations to avoid overflow.
2973 Check for size calculation overflow.
0065d054 2974 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2975
2976 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2977 Use ptrdiff_t, not int, for sizes.
2978 (store_mode_line_noprop_char): Don't update size until alloc done.
2979
0065d054
PE
2980 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2981 Use ptrdiff_t, not int, for sizes.
2982 (Finternal_make_lisp_face, cache_face):
2983 Check for size calculation overflow.
2984 (cache_face): Treat size calculation overflows as if they were
2985 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2986
2987 * xfns.c (x_encode_text, x_set_name_internal)
2988 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2989 sizes, since they can exceed INT_MAX in size. Check for size
2990 calculation overflow.
2991
0065d054
PE
2992 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2993 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2994 Don't update size until alloc done.
2995
0065d054 2996 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2997 as sprintf is limited to int lengths.
1d526e2f 2998
252c5ee1
PE
2999 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3000 (X_LONG_MIN): New macros.
864d7ce7
PE
3001 Use them to make the following changes clearer.
3002 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3003 This change doesn't affect the value now, but it may help remind
3004 future maintainers not to raise the value too much later.
3005 (SELECTION_QUANTUM): Remove, replacing with ...
3006 (selection_quantum): ... new function, which avoids overflow.
3007 All uses changed.
3008 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3009 assumption that selection length fits in 'int'.
3010 (x_reply_selection_request, x_handle_selection_request)
3011 (x_get_window_property, receive_incremental_selection)
3012 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3013 (lisp_data_to_selection_data, clean_local_selection_data):
3014 Use ptrdiff_t, not int, to record length of selection.
3015 (x_reply_selection_request, x_get_window_property)
3016 (receive_incremental_selection, x_property_data_to_lisp):
3017 Redo calculations to avoid overflow.
3018 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3019 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3020 something.
3021 (x_get_window_property, receive_incremental_selection)
3022 (lisp_data_to_selection_data, x_property_data_to_lisp):
3023 Check for size-calculation overflow.
3024 (x_get_window_property, receive_incremental_selection)
3025 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3026 Don't store size until memory allocation succeeds.
3027 (x_get_window_property): Plug memory leak on memory exhaustion.
3028 Don't double-block input; malloc is safe here. Don't assume 2**34
3029 - 4 fits in unsigned long. Add an xassert to check
3030 XGetWindowProperty overflow. Be more careful about overflow
3031 calculations, and distinguish size from memory overflow better.
3032 (receive_incremental_selection): When tracing, don't assume
3033 unsigned int is less than INT_MAX.
3034 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3035 harmful) conversions of unsigned short to int.
3036 (lisp_data_to_selection_data): Don't assume that integers
3037 in the range -65535 through -1 fit in an X unsigned short.
3038 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3039 result parameters unless successful. Rely on cons_to_unsigned
3040 to report problems with elements; the old code wasn't right anyway.
3041 (x_check_property_data): Check for int overflow; we cannot use
3042 a wider type due to X limits.
3043 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3044
726e0ab1 3045 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3046
0065d054
PE
3047 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3048 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3049 (x_color_cells): Don't store size until memory allocation succeeds.
3050 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3051 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3052 (x_term_init): Don't assume length fits in int (sprintf is limited
3053 to int size).
bc18e09d 3054
ebfa62c0
PE
3055 Use ptrdiff_t for composition IDs.
3056 * character.c (lisp_string_width):
3057 * composite.c (composition_table_size, n_compositions)
3058 (get_composition_id, composition_gstring_from_id):
3059 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3060 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3061 * window.c (Frecenter):
3062 Use ptrdiff_t, not int, for composition IDs.
3063 * composite.c (get_composition_id): Check for integer overflow.
3064 * composite.h: Adjust prototypes to match the above changes.
3065
d3411f89
PE
3066 Use ptrdiff_t for hash table indexes.
3067 * category.c (hash_get_category_set):
3068 * ccl.c (ccl_driver):
3069 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3070 * coding.c (coding_system_charset_list, detect_coding_system):
3071 * coding.h (struct coding_system.id):
3072 * composite.c (get_composition_id, gstring_lookup_cache):
3073 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3074 * image.c (xpm_get_color_table_h):
3075 * lisp.h (hash_lookup, hash_put):
3076 * minibuf.c (Ftest_completion):
3077 Use ptrdiff_t for hash table indexes, not int (which is too
3078 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3079 32-bit --with-wide-int hosts).
3080
e097a6fa
PE
3081 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3082 Add a FIXME comment about memory leaks.
3083 (syms_of_charset): Don't assume xmalloc returns.
3084
5637687f
PE
3085 Don't assume that stated character widths fit in int.
3086 * character.c (Fchar_width, c_string_width, lisp_string_width):
3087 * character.h (CHAR_WIDTH):
3088 * indent.c (MULTIBYTE_BYTES_WIDTH):
3089 Use sanitize_char_width to avoid undefined and/or bad behavior
3090 with outlandish widths.
a66cfb1c 3091 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3092 now that we have two such functions. All uses changed.
3093 (sanitize_char_width): New inline function.
3094
a2271ba2
PE
3095 Don't assume that tab-width fits in int.
3096 * character.h (sanitize_width): New inline function.
3097 (SANE_TAB_WIDTH): New macro.
3098 (ASCII_CHAR_WIDTH): Use it.
3099 * indent.c (sane_tab_width): Remove. All uses replaced by
3100 SANE_TAB_WIDTH (current_buffer).
3101 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3102
18c52557
PE
3103 * fileio.c: Integer overflow issues with file modes.
3104 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3105
caeeedc1
PE
3106 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3107 Remove unreachable code.
3108 (read_hex, load_charset_map_from_file): Check for integer overflow.
3109
6df6ae42 3110 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3111 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3112 (x_send_scroll_bar_event): Likewise. Check that the size does not
3113 exceed limits imposed by XClientMessageEvent, as well as the usual
3114 ptrdiff_t and size_t limits.
3115
b13995db
PE
3116 * keyboard.c: Overflow, signedness and related fixes.
3117 (make_lispy_movement): Use same integer type in forward decl
3118 that is used in the definition.
3119 (read_key_sequence, keyremap_step):
3120 Change bufsize argument back to int, undoing my 2011-03-30 change.
3121 We prefer signed types, and int is wide enough here.
3122 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3123 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3124 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3125 length, not size_t. Use ptrdiff_t for index, not int.
3126 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3127 possibility of integer overflow.
3128
13464394
PE
3129 Overflow, signedness and related fixes for images.
3130
3131 * dispextern.h (struct it.stack[0].u.image.image_id)
3132 (struct_it.image_id, struct image.id, struct image_cache.size)
3133 (struct image_cache.used, struct image_cache.ref_count):
3134 * gtkutil.c (update_frame_tool_bar):
3135 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3136 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3137 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3138 * nsmenu.m (update_frame_tool_bar):
3139 * xdisp.c (calc_pixel_width_or_height):
3140 * xfns.c (image_cache_refcount):
3141 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3142 on typical 64-bit hosts.
3143
3144 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3145 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3146 Omit unnecessary casts to int.
3147 (parse_image_spec): Check that integers fall into 'int' range
3148 when the callers expect that.
3149 (image_ascent): Redo ascent calculation to avoid int overflow.
3150 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3151 (lookup_image): Remove unnecessary tests.
3152 (xbm_image_p): Locals are now of int, not EMACS_INT,
3153 since parse_image_check makes sure they fit into int.
3154 (png_load, gif_load, svg_load_image):
3155 Prefer int to unsigned where either will do.
3156 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3157 old tiff_error_handler and tiff_warning_handler.
3158 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3159 stack buffer overflows. It uses only the features of vsnprintf
3160 that are common to both POSIX and native Microsoft.
3161 (tiff_error_handler, tiff_warning_handler): Use it.
3162 (tiff_load, gif_load, imagemagick_load_image):
3163 Don't assume :index value fits in 'int'.
3164 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3165 (imagemagick_load_image): Check that crop parameters fit into
3166 the integer types that MagickCropImage accepts. Don't assume
3167 Vimagemagick_render_type has a nonnegative value. Don't assume
3168 size_t fits in 'long'.
3169 (gs_load): Use printmax_t to print the widest integers possible.
3170 Check for integer overflow when computing image height and width.
3171
c11821d4
EZ
31722011-08-26 Eli Zaretskii <eliz@gnu.org>
3173
3174 * xdisp.c (redisplay_window): Don't force window start if point
3175 will be invisible in the resulting window. (Bug#9324)
3176
0c95fcf7
EZ
31772011-08-25 Eli Zaretskii <eliz@gnu.org>
3178
3179 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3180 the display spec is of the form `(space ...)'.
3181 (handle_display_spec): Return the value returned by
3182 handle_single_display_spec, not just 1 or zero.
3183 (handle_single_display_spec): If the display spec is of the form
3184 `(space ...)', and specifies display in the text area, return 2
3185 rather than 1.
fee65a97 3186 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3187 accurately, and prefer exact match for point under bidi.
3188 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3189
3190 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3191 into disp_prop; all users changed.
3192
3193 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3194 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3195 for the text covered by the display property.
3196
e4ed06f1
CY
31972011-08-25 Chong Yidong <cyd@stupidchicken.com>
3198
3199 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3200 Change return value to nil.
3201 (Frecord_buffer): Delete unused function.
3202
f67cdd7f
EZ
32032011-08-24 Eli Zaretskii <eliz@gnu.org>
3204
5980d4c6
EZ
3205 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3206 buffers, return left-to-right.
8610fe8b
EZ
3207 (set_cursor_from_row): Consider candidate row a win if its glyph
3208 represents a newline and point is on that newline. Fixes cursor
3209 positioning on the newline at EOL of R2L text within L2R
3210 paragraph, and vice versa.
3211 (try_cursor_movement): Check continued rows, in addition to
3212 continuation rows. Fixes unwarranted scroll when point enters a
3213 continued line of R2L text within an L2R paragraph, or vice versa.
3214 (cursor_row_p): Consider the case of point being equal to
3215 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3216 from the end of a short line to the beginning of a continued line
3217 of R2L text within L2R paragraph.
3218 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3219 composed characters.
5980d4c6 3220
f67cdd7f
EZ
3221 * bidi.c (bidi_check_type): Use xassert.
3222 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3223 members.
3224
bca633fb
EZ
32252011-08-23 Eli Zaretskii <eliz@gnu.org>
3226
3227 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3228 a character.
3229
4a5885a7
CY
32302011-08-23 Chong Yidong <cyd@stupidchicken.com>
3231
3232 * nsfont.m (ns_otf_to_script): Fix typo.
3233
0902a04e
KH
32342011-08-22 Kenichi Handa <handa@m17n.org>
3235
3236 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3237 extra slot even if the purpose is char-code-property-table.
3238
1a2e6670
EZ
32392011-08-23 Eli Zaretskii <eliz@gnu.org>
3240
8ddde651
EZ
3241 * xdisp.c (redisplay_window): When computing centering_position,
3242 account for the height of the header line. (Bug#8874)
3243
425cc014
EZ
3244 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3245 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3246 candidate is selected by the mouse, and that candidate has a
3247 composed character under the mouse.
3248
1a2e6670
EZ
3249 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3250 coordinates reported by pos-visible-in-window-p for a composed
3251 character in column zero.
3252
8b76d6f8
SM
32532011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3254
3255 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3256
dac347dd
EZ
32572011-08-22 Eli Zaretskii <eliz@gnu.org>
3258
3259 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3260 consider it a hit if to_charpos is anywhere in the range of the
3261 composed buffer positions.
3262
e013fb34
CY
32632011-08-22 Chong Yidong <cyd@stupidchicken.com>
3264
3265 * image.c (gif_load): Don't assume that each subimage has the same
3266 dimensions as the base image. Handle disposal method that is
3267 "undefined" by the gif spec (Bug#9335).
3268
bd1ba3e8
CY
32692011-08-20 Chong Yidong <cyd@stupidchicken.com>
3270
3271 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3272 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3273
54a1215b
EZ
32742011-08-19 Eli Zaretskii <eliz@gnu.org>
3275
823564e5
EZ
3276 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3277 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3278 from an Org mode buffer to a Speedbar frame.
3279
54a1215b
EZ
3280 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3281 a composition, take its buffer position from IT->cmp_it.charpos.
3282 Fixes cursor positioning at the beginning of a line that begins
3283 with a composed character.
3284
9778ebcc
EZ
32852011-08-18 Eli Zaretskii <eliz@gnu.org>
3286
0be6ee06
EZ
3287 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3288 character bidirectional type, use STRONG_L instead. Fixes crashes
3289 in a buffer produced by `describe-categories'.
3290
9778ebcc
EZ
3291 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3292 members before the level stack, so they would be saved and
3293 restored when copying iterator state. Fixes incorrect reordering
3294 around TABs covered by display properties.
3295
156bffbe
AS
32962011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3297
6b02f655 3298 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3299
72ad093b
CY
33002011-08-17 Chong Yidong <cyd@stupidchicken.com>
3301
3302 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3303 (internal_condition_case_2, internal_condition_case_n):
3304 Remove unnecessary aborts (Bug#9081).
72ad093b 3305
35774242
EZ
33062011-08-17 Eli Zaretskii <eliz@gnu.org>
3307
3308 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3309 has no `load' handler, try opening the file locally. (Bug#9311)
3310
db76dd85
KB
33112011-08-16 Ken Brown <kbrown@cornell.edu>
3312
3313 * gmalloc.c: Expand comment.
3314
b215eee5
EZ
33152011-08-16 Eli Zaretskii <eliz@gnu.org>
3316
3317 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3318 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3319
a4579d33
KB
33202011-08-16 Ken Brown <kbrown@cornell.edu>
3321
3322 Fix memory allocation problems in Cygwin build (Bug#9273).
3323
3324 * unexcw.c ( __malloc_initialized): Declare external variable.
3325 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3326
8b76d6f8
SM
3327 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3328 New variables.
a4579d33
KB
3329 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3330 dumped emacs.
3331 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3332 in the static heap.
3333 [CYGWIN] (special_realloc): New function.
3334 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3335 requests to realloc storage in the static heap.
3336
3ebec551
PE
33372011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 * bidi.c (bidi_initialize): Remove unused local.
3340
9fd8be00
EZ
33412011-08-15 Eli Zaretskii <eliz@gnu.org>
3342
6b02f655
SM
3343 * bidimirror.h:
3344 * biditype.h: Remove file.
3345 * makefile.w32-in ($(BLD)/bidi.$(O)):
3346 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3347
3348 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3349
3350 * chartab.c: Improve commentary for the uniprop_table API.
3351
32413314
EZ
3352 * bidi.c (bidi_paragraph_init): Support zero value of
3353 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3354 (bidi_initialize): Use uniprop_table instead of including
3355 biditype.h and bidimirror.h.
32413314 3356
9fd8be00
EZ
3357 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3358 coordinates of the iterator when restoring from ppos_it.
3359 (Bug#9296)
3360
5cf2b69b
KH
33612011-08-14 Kenichi Handa <handa@m17n.org>
3362
3363 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3364 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3365
daf17d00
EZ
33662011-08-14 Eli Zaretskii <eliz@gnu.org>
3367
3368 * xdisp.c (move_it_in_display_line_to): Don't invoke
3369 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3370 ppos_it. Fixes vertical cursor motion when line beginning is
3371 covered by an image. (Bug#9296)
3372
08e3161a
JD
33732011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3374
3375 * nsterm.h (ns_run_ascript): Declare.
3376 (NSAPP_DATA2_RUNASSCRIPT): Define.
3377
3378 * nsfns.m (as_script, as_result, as_status): New static variables.
3379 (ns_run_ascript): New function.
5e617bc2 3380 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3381 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3382 the event loop. Get status from as_status (Bug#7276).
3383
3384 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3385 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3386 the event loop (Bug#7276).
3387
a3720aa2
AS
33882011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3389
3390 * gnutls.c (QCgnutls_bootprop_priority)
3391 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3392 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3393 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3394 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3395 (QCgnutls_bootprop_verify_hostname_error)
3396 (QCgnutls_bootprop_callbacks_verify): Rename from
3397 Qgnutls_bootprop_..., all uses changed.
3398
3399 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3400 uses changed.
3401
0a0d27fb
PE
34022011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3403
19d5c50c
PE
3404 * xfaces.c (Qframe_set_background_mode): Now static.
3405 * dispextern.h (Qframe_set_background_mode): Remove decl.
3406
0a0d27fb
PE
3407 * process.c (Fnetwork_interface_info): Declare local only if needed.
3408
377538cb
JD
34092011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3410
3411 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3412 (Fnetwork_interface_list): Allocate in increments of bytes instead
3413 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3414 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3415 sockaddr.
3416 (struct ifflag_def): notrailers is smart on OSX.
3417 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3418 Get hardware address with getifaddrs if available.
3419
08fff70c
EZ
34202011-08-12 Eli Zaretskii <eliz@gnu.org>
3421
3422 * xdisp.c (iterate_out_of_display_property): xassert that
3423 IT->position is set to within IT->object's boundaries. Break from
3424 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3425 when IT->position is set up wrongly due to some bug.
3426 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3427 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3428 entry. Force push_it to save on the stack the current
3429 buffer/string position, to be restored by pop_it. Fix flags in
3430 the iterator structure wrt the object coming from a display
3431 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3432 properties. (Bug#9284)
3433
7be1c708 34342011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3435
7be1c708
CY
3436 * fontset.c (fontset_get_font_group): Add proper type checks.
3437 (Bug#9172)
aac0c6e3 3438
7be1c708 34392011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3440
7be1c708
CY
3441 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3442 and LC_VERSION_MIN_MACOSX.
3443 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3444 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3445
97bb72a6
EZ
34462011-08-08 Eli Zaretskii <eliz@gnu.org>
3447
3448 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3449 no-display-properties-and-no-overlays under bidi display.
3450 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3451 properties and overlays.
97bb72a6 3452
d5617611
CY
34532011-08-08 Chong Yidong <cyd@stupidchicken.com>
3454
37e11a63
CY
3455 * editfns.c (Fset_time_zone_rule): Document relationship with the
3456 setenv function.
3457
d5617611
CY
3458 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3459 the font entity extracted from the cache (Bug#8109).
3460
58872834
CY
34612011-08-07 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * composite.c (autocmp_chars): Don't reset point. That is done by
3464 restore_point_unwind (Bug#5984).
3465
75bfc667
JL
34662011-08-07 Juri Linkov <juri@jurta.org>
3467
3468 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3469 to show the arg `TIME' instead of `TIMEVAL'.
3470
d1410150
EZ
34712011-08-06 Eli Zaretskii <eliz@gnu.org>
3472
3473 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3474 display property strides EOL and includes a newline, as in
3475 longlines-mode. (Bug#9254)
75b771e4
EZ
3476 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3477 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3478
3479 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3480 is non-zero, even if the data buffer is NULL. Fixes a crash in
3481 vertical-motion with longlines-mode. (Bug#9254)
3482
35928349
EZ
34832011-08-05 Eli Zaretskii <eliz@gnu.org>
3484
ec7cc85b
EZ
3485 * bidi.c <bidi_cache_total_alloc>: Now static.
3486 (bidi_initialize): Initialize bidi_cache_total_alloc.
3487
8b76d6f8 3488 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3489 cache. (Bug#9221)
3490
3491 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3492 amount allocated this far in `bidi_cache_total_alloc'.
3493 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3494 non-zero, only free the data buffer without restoring the cache
3495 contents. All callers changed.
3496
3497 * dispextern.h (bidi_unshelve_cache): Update prototype.
3498
3499 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3500 (move_it_in_display_line, move_it_to)
3501 (move_it_vertically_backward, move_it_by_lines): Replace the call
3502 to xfree to an equivalent call to bidi_unshelve_cache.
3503 (move_it_in_display_line_to): Fix logic of returning
412b6358 3504 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3505
e2e2423b
EZ
35062011-08-05 Eli Zaretskii <eliz@gnu.org>
3507
3508 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3509 came from a string character with a `cursor' property. (Bug#9229)
3510
ae9e757a
JD
35112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3512
3513 * Makefile.in (LIB_PTHREAD): New variable.
3514 (LIBES): Add LIB_PTHREAD (Bug#9216).
3515
3516 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3517 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3518
213bd7f2
AS
35192011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3520
6b02f655 3521 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3522
99aaf75f
JD
35232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3524
3525 * xterm.c (x_find_topmost_parent): New function.
3526 (x_set_frame_alpha): Find topmost parent window with
3527 x_find_topmost_parent and set the property there also (bug#9181).
3528 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3529
c74e9d86
PE
35302011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3531
3532 * callproc.c (Fcall_process): Avoid vfork clobbering
3533 the local vars buffer, coding_systems, current_dir.
3534
640c8776
SM
35352011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3536
3537 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3538
f26d0e4c
PE
35392011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3540
8a10d76c
PE
3541 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3542 so that it is not optimized away.
3543
f26d0e4c
PE
3544 * xdisp.c (compute_display_string_pos): Remove unused local.
3545
55439c61
EZ
35462011-08-02 Eli Zaretskii <eliz@gnu.org>
3547
3548 Fix slow cursor motion and scrolling in large buffers with
3549 selective display, like Org Mode buffers. (Bug#9218)
3550
3551 * dispextern.h (struct bidi_it): New member disp_prop_p.
3552
3553 * xdisp.c: Remove one-slot cache of display string positions.
3554 (compute_display_string_pos): Accept an additional argument
5e617bc2 3555 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3556 for a display string or property. If found, set DISP_PROP_P
3557 non-zero.
3558
3559 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3560 DISP_PROP_P, and pass it to compute_display_string_pos.
3561 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3562 non-zero. All callers of bidi_fetch_char changed.
3563
fb33fa43
SM
35642011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3565
3566 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3567
b099e063
DM
35682010-12-03 Don March <don@ohspite.net>
3569
3570 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3571 last character M-[char] is translated to ESC [char] (bug#7541).
3572
5cc7f7af
KH
35732011-08-02 Kenichi Handa <handa@m17n.org>
3574
d0fffa3f 3575 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3576
3577 * chartab.c (uniprop_table): Make it non-static.
3578
525d5e6e
EZ
35792011-08-01 Eli Zaretskii <eliz@gnu.org>
3580
3581 * xdisp.c (forward_to_next_line_start): Accept additional argument
3582 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3583 on the newline.
3584 (reseat_at_next_visible_line_start): Use the bidi iterator state
3585 returned by forward_to_next_line_start to restore the state of
3586 it->bidi_it after backing up to previous newline. (Bug#9212)
3587
31011111
AS
35882011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * regex.c (re_comp): Protoize.
3591 (re_exec): Fix return type.
3592 (regexec): Fix type of `ret'. (Bug#9203)
3593
476371c4
PE
35942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3595
e5d76069
PE
3596 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3597 This is needed if max-image-size is a floating-point number.
3598
9a79b20c
AS
35992011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3600
3601 * print.c (print_object): Print empty symbol as ##.
3602
3603 * lread.c (read1): Read ## as empty symbol.
3604
d8c2fa78
AA
36052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3606
3607 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3608 setting frame foreground color (Bug#9175).
3609 (x_set_background_color): Likewise.
3610
ffe57a7a
AA
3611 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3612 contents (Bug#9176).
3613 (EmacsTooltip -init): Remove bezels and add shadows to
3614 tooltip windows.
3615
bf3492a5
AA
3616 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3617 or scroll bar (Bug#8470).
3618
d55e9c53
AA
3619 * nsfont.m (nsfont_open): Remove assignment to voffset and
3620 unnecessary vars hshink, expand, hd, full_height, min_height.
3621 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3622
3623 * nsterm.h (nsfont_info): Remove voffset field.
3624
d8c2fa78 36252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3626
3627 Implement strike-through and overline on NextStep (Bug#8863).
3628
3629 * nsfont.m (nsfont_open): Use underline position provided by font,
3630 instead of hard-coded value of 2.
3631 (nsfont_draw): Call ns_draw_text_decoration instead.
3632
3633 * nsterm.h: Add declaration for ns_draw_text_decoration.
3634
3635 * nsterm.m (ns_draw_text_decoration): New function for drawing
3636 underline, overline, and strike-through.
3637 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3638 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3639 accommodate underlining, etc.
4843aac3 3640
4cc60b9b
EZ
36412011-07-28 Eli Zaretskii <eliz@gnu.org>
3642
bc7ece87
EZ
3643 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3644 default.
4cc60b9b 3645
476371c4
PE
36462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3647
66606eea
PE
3648 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3649 Without this fix, if a signal arrives just after memory fills up,
3650 'malloc' might be invoked reentrantly.
3651
476371c4
PE
3652 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3653 In other words, assume that every image size is allowed, on non-X
3654 hosts. This assumption is probably wrong, but it lets Emacs compile.
3655
f3fcc40d
AS
36562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3657
3658 * regex.c (re_iswctype): Convert return values to boolean.
3659
350c992f
EZ
36602011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3661
3662 * xdisp.c (compute_display_string_pos): Don't use cached display
3663 string position if the buffer had its restriction changed.
3664 (Bug#9184)
3665
5266b4bb
PE
36662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3669
2573a837 36702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3671
41f55ccd 3672 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3673
39e378da
PE
3674 * bidi.c: Integer size and overflow fixes.
3675 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3676 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3677 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3678 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3679 (bidi_find_other_level_edge):
3680 Use ptrdiff_t instead of EMACS_INT where either will do.
3681 This works better on 32-bit hosts configured --with-wide-int.
3682 (bidi_cache_ensure_space): Check for size-calculation overflow.
3683 Use % rather than repeated addition, for better worst-case speed.
3684 Don't set bidi_cache_size until after xrealloc returns, because it
3685 might not return.
3686 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3687 (bidi_cache_ensure_space): Also check that the bidi cache size
3688 does not exceed that of the largest Lisp string or buffer. See Eli
3689 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3690
5e927815
PE
3691 * alloc.c (__malloc_size_t): Remove.
3692 All uses replaced by size_t. See Andreas Schwab's note
3693 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3694
ca4aa935
PE
3695 * image.c: Improve checking for integer overflow.
3696 (check_image_size): Assume that f is nonnull, since
3697 it is always nonnull in practice. This is one less thing to
3698 worry about when checking for integer overflow later.
3699 (x_check_image_size): New function, which checks for integer
3700 overflow issues inside X.
3701 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3702 This removes the need for a memory_full check.
3703 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3704 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3705 (xbm_read_bitmap_data): Change locals back to 'int', since
3706 their values must fit in 'int'.
3707 (xpm_load_image, png_load, tiff_load):
3708 Invoke x_create_x_image_and_pixmap earlier,
3709 to avoid much needless work if the image is too large.
3710 (tiff_load): Treat overly large images as if
3711 x_create_x_image_and_pixmap failed, not as malloc failures.
3712 (gs_load): Use x_check_image_size.
3713
5f8f9cc2
PE
3714 * gtkutil.c: Omit integer casts.
3715 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3716 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3717
5adf60bc
PE
3718 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3719
c8907a93
PE
3720 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3721 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3722 would wrongly return t on a 64-bit host.
3723
e3c25c68
PE
3724 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3725 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3726 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3727 and therefore cause GCC to emit a bogus diagnostic in some cases.
3728
3f791afe
PE
3729 * image.c: Integer signedness and overflow and related fixes.
3730 This is not an exhaustive set of fixes, but it's time to
3731 record what I've got.
3732 (lookup_pixel_color, check_image_size): Remove redundant decls.
3733 (check_image_size): Don't assume that arbitrary EMACS_INT values
3734 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3735 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3736 (tiff_load, imagemagick_load_image):
3737 Check for overflow in size calculations.
3738 (x_create_x_image_and_pixmap): Remove unnecessary test for
3739 xmalloc returning NULL; that can't happen.
3740 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3741 (xpm_color_bucket): Use better integer hashing function.
3742 (xpm_cache_color): Don't possibly over-allocate memory.
3743 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3744 (gif_memory_source):
3745 Use ptrdiff_t, not int or size_t, to record sizes.
3746 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3747 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3748 either works, as we prefer signed integers.
3749 (tiff_read_from_memory, tiff_write_from_memory):
3750 Return tsize_t, not size_t, since that's what the TIFF API wants.
3751 (tiff_read_from_memory): Don't fail simply because the read would
3752 go past EOF; instead, return a short read.
3753 (tiff_load): Omit no-longer-needed casts.
3754 (Fimagemagick_types): Don't assume size fits into 'int'.
3755
3cc5a532
PE
3756 Improve hashing quality when configured --with-wide-int.
3757 * fns.c (hash_string): New function, taken from sxhash_string.
3758 Do not discard information about ASCII character case; this
3759 discarding is no longer needed.
3760 (sxhash-string): Use it. Change sig to match it. Caller changed.
3761 * lisp.h: Declare it.
3762 * lread.c (hash_string): Remove, since we now use fns.c's version.
3763 The fns.c version returns a wider integer if --with-wide-int is
3764 specified, so this should help the quality of the hashing a bit.
3765
b312a492
PE
3766 * emacs.c: Integer overflow minor fix.
3767 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3768 Define only if GNU_LINUX.
3769 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3770
dfd153ae
PE
3771 * dispnew.c: Integer signedness and overflow fixes.
3772 Remove unnecessary forward decls, that were a maintenance hassle.
3773 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3774 All uses changed.
3775 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3776 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3777 (prepare_desired_row, line_draw_cost):
3778 Use int, not unsigned, where either works.
3779 (save_current_matrix, restore_current_matrix):
3780 Use ptrdiff_t, not size_t, where either works.
3781 (init_display): Check for overflow more accurately, and without
3782 relying on undefined behavior.
3783
a81d11a3
PE
3784 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3785 Remove, replacing with the new symbols in lisp.h. All uses changed.
3786 * fileio.c (make_temp_name):
3787 * filelock.c (lock_file_1, lock_file):
3788 * xdisp.c (message_dolog):
3789 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3790 Use pMd etc. instead.
3791 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3792 replacing the pWIDE etc. symbols removed from editfns.c.
3793
3300e6fd
PE
3794 * keyboard.h (num_input_events): Now uintmax_t.
3795 This is (very slightly) less likely to mess up due to wraparound.
3796 All uses changed.
3797
fd05c7e9
PE
3798 * buffer.c: Integer signedness fixes.
3799 (alloc_buffer_text, enlarge_buffer_text):
3800 Use ptrdiff_t rather than size_t when either will do, as we prefer
3801 signed integers.
3802
903fe15d
PE
3803 * alloc.c: Integer signedness and overflow fixes.
3804 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3805 (__malloc_size_t): Default to size_t, not to int.
3806 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3807 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3808 Prefer ptrdiff_t to size_t when either would do, as we prefer
3809 signed integers.
3810 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3811 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3812 Now const. Initialize with values that are in range even if char
3813 is signed.
3814 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3815 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3816 These functions do the right thing with sizes > 2**32.
3817 (check_depth): Now ptrdiff_t, not int.
3818 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3819 Adjust to new way of storing sizes. Check for size overflow bugs
3820 in rest of code.
3821 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3822 slightly wrong anyway, as it missed one instance of
3823 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3824 (refill_memory_reserve): Omit needless cast to size_t.
3825 (mark_object_loop_halt): Mark as externally visible.
3826
ac82cc6a
PE
3827 * xselect.c: Integer signedness and overflow fixes.
3828 (Fx_register_dnd_atom, x_handle_dnd_message):
3829 Use ptrdiff_t, not size_t, since we prefer signed.
3830 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3831 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3832 x_dnd_atoms_size and x_dnd_atoms_length.
3833
c2d1e36d
PE
3834 * doprnt.c: Prefer signed to unsigned when either works.
3835 * eval.c (verror):
3836 * doprnt.c (doprnt):
3837 * lisp.h (doprnt):
3838 * xdisp.c (vmessage):
3839 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3840 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3841 prefer signed arithmetic to avoid comparison confusion.
3842 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3843 but is a bit tricky.
3844
0e926e56
PE
3845 Assume freestanding C89 headers, string.h, stdlib.h.
3846 * data.c, doprnt.c, floatfns.c, print.c:
3847 Include float.h unconditionally.
3848 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3849 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3850 * regex.c: Likewise for stddef.h, string.h.
3851 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3852 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3853 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3854 (STDC_HEADERS): Remove obsolete defines.
3855 * sysdep.c: Include limits.h unconditionally.
3856
9cfdb3ec
PE
3857 Assume support for memcmp, memcpy, memmove, memset.
3858 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3859 * regex.c (memcmp, memcpy):
3860 Remove; we assume C89 now.
3861
3862 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3863 (__malloc_safe_bcopy): Remove; no longer needed.
3864
cf950e6b 3865 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3866 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3867 well either way, and we prefer signed to unsigned.
3868
dbf38e02
LMI
38692011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870
3871 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3872 closes the connection while we're reading (bug#9182).
3873
d6f0886c 38742011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3875
d6f0886c
JD
3876 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3877 are specified (Bug#9168).
24e0f6b1 3878
2eb1f9e6
PE
38792011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3882 Found by GCC static checking and --with-wide-int on a 32-bit host.
3883
22381272 38842011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3885
3886 * xdisp.c (compute_display_string_pos): Fix logic of caching
3887 previous display string position. Initialize cached_prev_pos to
3888 -1. Fixes slow-down at the beginning of a buffer.
3889
f25e39b4
EZ
38902011-07-24 Eli Zaretskii <eliz@gnu.org>
3891
3892 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3893 for attrs[LFACE_FONTSET_INDEX].
3894
04c4b52e
PE
38952011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * xml.c (parse_region): Remove unused local
3898 that was recently introduced.
3899
c1734fbd
EZ
39002011-07-23 Eli Zaretskii <eliz@gnu.org>
3901
be18c5a5
EZ
3902 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3903 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3904
c1734fbd
EZ
3905 * xdisp.c (move_it_in_display_line_to): Record the best matching
3906 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3907 exit if none of the characters scanned was an exact match.
3908 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3909 when exact match is impossible due to invisible text, and the
3910 lines are truncated.
3911
a258d627
JD
39122011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3913
3914 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3915 for OSX >= 10.7.
3916
b6d5a689
EZ
39172011-07-22 Eli Zaretskii <eliz@gnu.org>
3918
0f74f785
EZ
3919 Fix a significant slow-down of cursor motion with C-n, C-p,
3920 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3921 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3922 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3923 (next_element_from_buffer): Call compute_stop_pos_backwards to
3924 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3925 base_level_stop.
3926 (reseat): Don't look for prev_stop, as that could mean a very long
3927 run.
3928 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3929 <cached_disp_overlay_modiff>: Cache for last found display string
3930 position.
551918c1 3931 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3932 about the same buffer in the same area of character positions, and
3933 the buffer wasn't changed since the time the display string
3934 position was cached.
551918c1 3935
b2d0c91a
EZ
39362011-07-22 Eli Zaretskii <eliz@gnu.org>
3937
3938 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3939 is an integer, which is important for empty lines. (Bug#9149)
3940
043604ee
CY
39412011-07-22 Chong Yidong <cyd@stupidchicken.com>
3942
3943 * frame.c (Fmodify_frame_parameters): In tty case, update the
3944 default face if necessary (Bug#4238).
3945
da4adb04
CY
39462011-07-21 Chong Yidong <cyd@stupidchicken.com>
3947
3948 * editfns.c (Fstring_to_char): No need to explain what a character
3949 is in the docstring (Bug#6576).
3950
9abd0532
LMI
39512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3952
3953 * xml.c (parse_region): Make sure we always return a tree.
3954
36881d16
HK
39552011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3956
3957 * xml.c (parse_region): If a document contains only comments,
3958 return that, too.
3959
1e98674d
LMI
39602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961
3962 * xml.c (make_dom): Return comments, too.
3963
590bd467
PE
39642011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3965
3966 Port to OpenBSD.
3967 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3968 and the surrounding thread.
3969 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3970 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3971 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3972 timer goes off.
3973 * s/openbsd.h (BROKEN_SIGIO): Define.
3974 * unexelf.c (unexec) [__OpenBSD__]:
3975 Don't update the .mdebug section of the Alpha COFF symbol table.
3976
f41628b2
LMI
39772011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3978
3979 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3980 (bug#8460).
3981
b59b67c5
PE
39822011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3983
15e3a074
PE
3984 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3985 This fixes some race conditions on the permissions of any newly
3986 created file.
3987
41bed37d
PE
3988 * alloc.c (valid_pointer_p): Use pipe, not open.
3989 This fixes some permissions issues when debugging.
3990
b59b67c5
PE
3991 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3992 If fchown fails to set both uid and gid, try to set just gid,
3993 as that is sometimes allowed. Adjust the file's mode to eliminate
3994 setuid or setgid bits that are inappropriate if fchown fails.
3995
925a6be7
SM
39962011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3997
3998 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3999 to compare Lisp_Objects.
4000 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4001 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4002 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4003
52968808
AS
40042011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4005
0a6a104b
AS
4006 * lread.c (read_integer): Unread even EOF character.
4007 (read1): Likewise. Properly record start position of symbol.
4008
52968808
AS
4009 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4010 symbol character follows.
4011
9e381cdd
PE
40122011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4013
4014 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4015 This works around a problem with the previous change to Fcopy_file.
4016 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4017 and without this change, GCC might complain about discarding
4018 fchown's return value.
4019
b5641435
JB
40202011-07-16 Juanma Barranquero <lekktu@gmail.com>
4021
4022 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4023
a8031457
PE
40242011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4025
4026 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4027
dd889327
LMI
40282011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4029
750c33f7
LMI
4030 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4031 it's used from the C level.
4032
dd889327
LMI
4033 * process.c: Use the same condition for POLL_FOR_INPUT in both
4034 keyboard.c and process.c (bug#1858).
4035
87e86684
LM
40362011-07-09 Lawrence Mitchell <wence@gmx.li>
4037
4038 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4039 (Fgnutls_boot): Use it.
4040
64348f40
AS
40412011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4042
4043 * doc.c (Fsubstitute_command_keys): Revert last change.
4044
1d698799
LMI
40452011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4046
f863868c
LMI
4047 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4048 quotes the next character, and doesn't affect other longer
4049 sequences (bug#8935).
4050
1d698799
LMI
4051 * lread.c (syms_of_lread): Clarify that is isn't only
4052 `eval-buffer' and `eval-defun' that's affected by
4053 `lexical-binding' (bug#8460).
4054
aa4b6df6
EZ
40552011-07-15 Eli Zaretskii <eliz@gnu.org>
4056
4057 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4058 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4059
5d856da6
PE
40602011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4061
ad6042bb
PE
4062 Fix minor problems found by static checking.
4063 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4064 (elsz): Now a signed constant, not a size_t var. We prefer signed
4065 types to unsigned, to avoid integer comparison confusion. Without
4066 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4067 "cannot optimize loop, the loop counter may overflow", a symptom
4068 of the confusion.
f00bbb22 4069 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4070 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4071
6468f31c
LMI
40722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4073
49080b10
LMI
4074 * search.c (Fre_search_backward): Mention `case-fold-search' in
4075 all the re_search_* functions (bug#8138).
4076
6468f31c
LMI
4077 * keyboard.c (Fopen_dribble_file): Document when the file is
4078 closed (bug#8056).
4079
c965adc5
EZ
40802011-07-14 Eli Zaretskii <eliz@gnu.org>
4081
df9733bf
EZ
4082 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4083 bidi_cache_idx.
4084
0bb23927
EZ
4085 Support bidi reordering of display and overlay strings.
4086 * xdisp.c (compute_display_string_pos)
4087 (compute_display_string_end): Accept additional argument STRING.
4088 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4089 (reseat_to_string): Initialize bidi_it->string.s and
4090 bidi_it->string.schars.
4091 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4092 NULL (avoids a crash in bidi_paragraph_init).
4093 Initialize itb.string.lstring.
0bb23927
EZ
4094 (init_iterator): Call bidi_init_it only of a valid
4095 buffer position was specified. Initialize paragraph_embedding to
4096 L2R.
4097 (reseat_to_string): Initialize the bidi iterator.
4098 (display_string): If we need to ignore text properties of
4099 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4100 original value of -1 will not work with bidi.)
4101 (compute_display_string_pos): First arg is now struct
4102 `text_pos *'; all callers changed. Support display properties on
4103 Lisp strings.
4104 (compute_display_string_end): Support display properties on Lisp
4105 strings.
4106 (init_iterator, reseat_1, reseat_to_string): Initialize the
4107 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4108 when iterating on a string not from display properties).
640c8776
SM
4109 (compute_display_string_pos, compute_display_string_end):
4110 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4111 arrow keys.
4112 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4113 base_level_stop; instead, set base_level_stop to BEGV.
4114 Fixes crashes in vertical-motion.
0bb23927
EZ
4115 (next_element_from_buffer): Improve commentary for when
4116 the iterator is before prev_stop.
4117 (init_iterator): Initialize bidi_p from the default value of
4118 bidi-display-reordering, not from buffer-local value. Use the
4119 buffer-local value only if initializing for buffer iteration.
4120 (handle_invisible_prop): Support invisible properties on strings
4121 that are being bidi-reordered.
4122 (set_iterator_to_next): Support bidi reordering of C strings and
4123 Lisp strings.
4124 (next_element_from_string): Support bidi reordering of Lisp
4125 strings.
4126 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4127 (display_string): Support display of R2L glyph rows.
4128 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4129 (init_iterator): Don't initialize it->bidi_p for strings
4130 here.
4131 (reseat_to_string): Initialize it->bidi_p for strings here.
4132 (next_element_from_string, next_element_from_c_string)
4133 (next_element_from_buffer): Add xassert's for correspondence
4134 between IT's object being iterated and it->bidi_it.string
4135 structure.
4136 (face_before_or_after_it_pos): Support bidi iteration.
4137 (next_element_from_c_string): Handle the case of the first string
4138 character that is not the first one in the visual order.
4139 (get_visually_first_element): New function, refactored from common
4140 parts of next_element_from_buffer, next_element_from_string, and
4141 next_element_from_c_string.
4142 (tool_bar_lines_needed, redisplay_tool_bar)
4143 (display_menu_bar): Force left-to-right direction. Add a FIXME
4144 comment for making that be controlled by a user option.
4145 (push_it, pop_it): Save and restore the state of the
4146 bidi iterator. Save and restore the bidi_p flag.
4147 (pop_it): Iterate out of display property for string iteration as
4148 well.
4149 (iterate_out_of_display_property): Support iteration over strings.
4150 (handle_single_display_spec): Set up it->bidi_it for iteration
4151 over a display string, and call bidi_init_it.
4152 (handle_single_display_spec, next_overlay_string)
4153 (get_overlay_strings_1, push_display_prop): Set up the bidi
4154 iterator for displaying display or overlay strings.
4155 (forward_to_next_line_start): Don't use the shortcut if
4156 bidi-iterating.
4157 (back_to_previous_visible_line_start): If handle_display_prop
4158 pushed the iterator stack, restore the internal state of the bidi
4159 iterator by calling bidi_pop_it same number of times.
4160 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4161 and we are bidi-iterating, don't decrement the iterator position;
4162 instead, set the first_elt flag in the bidi iterator, to produce
4163 the same effect.
4164 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4165 (push_display_prop): xassert that we are iterating a buffer.
4166 (push_it, pop_it): Save and restore paragraph_embedding member.
4167 (handle_single_display_spec, next_overlay_string)
4168 (get_overlay_strings_1, reseat_1, reseat_to_string)
4169 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4170 correctly. Don't assume unibyte strings are not bidi-reordered.
4171 (compute_display_string_pos)
4172 (compute_display_string_end): Fix handling the case of C string.
4173 (push_it, pop_it): Save and restore from_disp_prop_p.
4174 (handle_single_display_spec, push_display_prop): Set the
4175 from_disp_prop_p flag.
4176 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4177 (pop_it): Call iterate_out_of_display_property only if we are
4178 popping after iteration over a string that came from a display
4179 property. Fix a typo in popping stretch info. Add an assertion
4180 for verifying that the iterator position is in sync with the bidi
4181 iterator.
4182 (handle_single_display_spec, get_overlay_strings_1)
4183 (push_display_prop): Fix initialization of paragraph direction for
4184 string when that of the parent object is not yet determined.
4185 (reseat_1): Call bidi_init_it to resync the bidi
4186 iterator with IT's position. (Bug#7616)
4187 (find_row_edges): If ROW->start.pos gives position
4188 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4189 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4190 Reset the from_disp_prop_p flag.
4191 (SAVE_IT, RESTORE_IT): New macros.
4192 (pos_visible_p, face_before_or_after_it_pos)
4193 (back_to_previous_visible_line_start)
4194 (move_it_in_display_line_to, move_it_in_display_line)
4195 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4196 (try_scrolling, redisplay_window, display_line): Use them when
4197 saving a temporary copy of the iterator and restoring it back.
4198 (back_to_previous_visible_line_start, reseat_1)
4199 (init_iterator): Empty the bidi cache "stack".
4200 (move_it_in_display_line_to): If iterator ended up at
4201 EOL, but we never saw any buffer positions smaller than
4202 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4203 motion in bidi-reordered lines.
4204 (move_it_in_display_line_to): Record prev_method and prev_pos
4205 immediately before the call to set_iterator_to_next. Fixes cursor
4206 motion in bidi-reordered lines with stretch glyphs and strings
4207 displayed in margins. (Bug#8133) (Bug#8867)
4208 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4209 TO_CHARPOS.
640c8776
SM
4210 (pos_visible_p): Support positions in bidi-reordered lines.
4211 Save and restore bidi cache.
0bb23927
EZ
4212
4213 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4214 (bidi_paragraph_info): Delete unused struct.
4215 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4216 (bidi_cache_start): New variable.
4217 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4218 to zero.
4219 (bidi_cache_fetch_state, bidi_cache_search)
4220 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4221 (bidi_cache_find, bidi_peek_at_next_level)
4222 (bidi_level_of_next_char, bidi_find_other_level_edge)
4223 (bidi_move_to_visually_next): Compare cache index with
4224 bidi_cache_start rather than with zero.
4225 (bidi_fetch_char): Accept new argument STRING; all callers
4226 changed. Support iteration over a string. Support strings with
4227 display properties. Support unibyte strings. Fix the type of
4228 `len' according to what STRING_CHAR_AND_LENGTH expects.
4229 (bidi_paragraph_init, bidi_resolve_explicit_1)
4230 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4231 (bidi_level_of_next_char, bidi_move_to_visually_next):
4232 Support iteration over a string.
0bb23927
EZ
4233 (bidi_set_sor_type, bidi_resolve_explicit_1)
4234 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4235 can now be zero (for strings); special values 0 and -1 were
4236 changed to -1 and -2, respectively.
4237 (bidi_char_at_pos): New function.
4238 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4239 Call it instead of FETCH_MULTIBYTE_CHAR.
4240 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4241 initialized to valid values.
4242 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4243 values.
4244 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4245 the test for valid cached positions. Fix the logic for looking up
4246 the sentinel state in the cache. GCPRO the Lisp string we are
4247 iterating.
4248 (bidi_push_it, bidi_pop_it): New functions.
4249 (bidi_initialize): Initialize the bidi cache start stack pointer.
4250 (bidi_cache_ensure_space): New function, refactored from part of
4251 bidi_cache_iterator_state. Don't assume the required size is just
4252 one BIDI_CACHE_CHUNK away.
4253 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4254 (bidi_count_bytes, bidi_char_at_pos): New functions.
4255 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4256 always valid if bidi_cache_idx is valid.
4257 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4258 is valid if it's going to be used.
4259 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4260 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4261 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4262 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4263 (bidi_find_other_level_edge, bidi_cache_start_stack):
4264 All variables related to cache indices are now EMACS_INT.
c965adc5 4265
0bb23927
EZ
4266 * dispextern.h (struct bidi_string_data): New structure.
4267 (struct bidi_it): New member `string'. Make flag members be 1-bit
4268 fields, and put them last in the struct.
640c8776
SM
4269 (compute_display_string_pos, compute_display_string_end):
4270 Update prototypes.
0bb23927
EZ
4271 (bidi_push_it, bidi_pop_it): Add prototypes.
4272 (struct iterator_stack_entry): New members bidi_p,
4273 paragraph_embedding, and from_disp_prop_p.
4274 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4275 (bidi_shelve_cache, bidi_unshelve_cache):
4276 Declare prototypes.
0bb23927
EZ
4277
4278 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4279 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4280 and vector-like objects.
4281
4282 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4283 cache around display iteration.
4284
4285 * window.c (Fwindow_end, window_scroll_pixel_based)
4286 (displayed_window_lines, Frecenter): Save and restore the bidi
4287 cache around display iteration.
4288
3bbd2265
LMI
42892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4290
4291 * editfns.c (Fdelete_region): Clarify the use of the named
4292 parameters (bug#6788).
4293
adc47434
MR
42942011-07-14 Martin Rudalics <rudalics@gmx.at>
4295
4296 * indent.c (Fvertical_motion): Set and restore w->pointm when
4297 saving and restoring the window's buffer (Bug#9006).
4298
837c31f8
LMI
42992011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4300
4301 * editfns.c (Fstring_to_char): Clarify just what is returned
4302 (bug#6576). Text by Eli Zaretskii.
4303
ac389d0c
JB
43042011-07-13 Juanma Barranquero <lekktu@gmail.com>
4305
4306 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4307
0be0ce47
EZ
43082011-07-13 Eli Zaretskii <eliz@gnu.org>
4309
4310 * buffer.c (mmap_find): Fix a typo.
4311
cd18e7e3
JB
43122011-07-13 Johan Bockgård <bojohan@gnu.org>
4313
4314 Fix execution of x selection hooks.
4315 * xselect.c (Qx_lost_selection_functions)
4316 (Qx_sent_selection_functions): New vars.
4317 (syms_of_xselect): DEFSYM them.
4318 (x_handle_selection_request): Pass Qx_sent_selection_functions
4319 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4320 (x_handle_selection_clear,x_clear_frame_selections):
4321 Pass Qx_lost_selection_functions rather than
4322 Vx_lost_selection_functions to Frun_hook_with_args.
4323
47ea7f44
PE
43242011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4325
ac389d0c 4326 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4327 The old code sometimes used this field without initializing it.
4328
47ea7f44
PE
4329 * alloc.c (gc_sweep): Don't read past end of array.
4330 In theory, the old code could also have corrupted Emacs internals,
4331 though it'd be very unlikely.
4332
bc985c87
AS
43332011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4334
4335 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4336 argument. (Bug#4026)
bc985c87 4337
0cf34688
LMI
43382011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339
b3dadd76
LMI
4340 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4341 key" (bug#4257).
4342
0cf34688
LMI
4343 * window.c (Fset_window_start): Doc fix (bug#4199).
4344 (Fset_window_hscroll): Ditto.
4345
270768cd
PE
43462011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4347
077e3dda 4348 Fix minor new problems caught by GCC 4.6.1.
270768cd 4349 * term.c (init_tty): Remove unused local.
490011a6 4350 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4351 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4352 not used otherwise.
270768cd 4353
b1f58454
CY
43542011-07-12 Chong Yidong <cyd@stupidchicken.com>
4355
4356 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4357
22b9578d
LMI
43582011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4359
6e70ab07
LMI
4360 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4361 are the mini-buffer and the echo area (bug#3320).
4362
22b9578d
LMI
4363 * term.c (init_tty): Remove support for supdup, c10 and perq
4364 terminals, which are no longer supported (bug#1482).
4365
8974cc9f
JB
43662011-07-10 Johan Bockgård <bojohan@gnu.org>
4367
4368 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4369
a560d974
JD
43702011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4371
4372 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4373 for non-popups (Bug#3642).
4374
1dae0f0a
AS
43752011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4376
268c2c36 4377 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4378 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4379 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4380 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4381 * data.c (fmod): Likewise.
4382 * dispnew.c (swap_glyphs_in_rows): Likewise.
4383 * emacs.c (memory_warning_signal): Likewise.
4384 * floatfns.c (float_error): Likewise.
4385 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4386 (otf_open, font_otf_capability, generate_otf_features)
4387 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4388 Likewise.
4389 * image.c (pbm_read_file): Likewise.
4390 * indent.c (string_display_width): Likewise.
4391 * intervals.c (check_for_interval, search_for_interval)
4392 (inc_interval_count, count_intervals, root_interval)
4393 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4394 * lread.c (defalias): Likewise.
268c2c36 4395 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4396 * regex.c (set_image_of_range_1, set_image_of_range)
4397 (regex_grow_registers): Likewise.
4398 * sysdep.c (strerror): Likewise.
4399 * termcap.c (valid_filename_p, tprint, main): Likewise.
4400 * tparam.c (main): Likewise.
4401 * unexhp9k800.c (run_time_remap, save_data_space)
4402 (update_file_ptrs, read_header, write_header, calculate_checksum)
4403 (copy_file, copy_rest, display_header): Likewise.
4404 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4405 Likewise.
4406 * xdisp.c (check_it): Likewise.
4407 * xfaces.c (register_color, unregister_color, unregister_colors):
4408 Likewise.
4409 * xfns.c (print_fontset_result): Likewise.
4410 * xrdb.c (member, fatal, main): Likewise.
4411
99033785
PE
44122011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4413
4414 Fix minor problems found by static checking (Bug#9031).
4415 * chartab.c (char_table_set_range, map_sub_char_table):
4416 Remove unused locals.
4417 (uniprop_table): Now static.
4418 * composite.c (_work_char): Remove unused static var.
4419
9cb2ac56
JB
44202011-07-09 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4423
f25661f0
JD
44242011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4425
4426 * gtkutil.c (qttip_cb): Remove code without function.
4427
8278c4fe
EZ
44282011-07-09 Eli Zaretskii <eliz@gnu.org>
4429
4430 * w32.c (pthread_sigmask): New stub.
4431
1692ae2d 44322011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4433
8a6ebd58 4434 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4435 sigprocmask is portable only for single-threaded applications, and
4436 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4437 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4438 (LIBES): Use it.
4439 * callproc.c (Fcall_process):
4440 * process.c (create_process):
4441 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4442 Use pthread_sigmask, not sigprocmask.
123403e4 4443
1b854618
JD
44442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4445
4446 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4447 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4448 wrong (Bug#8591).
4449
3fe4b549
JD
44502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4451
0ce7e563
JD
4452 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4453 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4454 (xg_hide_tooltip): Fix comment.
4455
3fe4b549
JD
4456 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4457 in registerServicesMenuSendTypes.
4458 (validRequestorForSendType): Don't check ns_return_types.
4459
4460 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4461 ns_return_type.
4462
5df75e47
JR
44632011-07-08 Jason Rumney <jasonr@gnu.org>
4464
22610910
JR
4465 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4466 SH_SHOW for hidden windows (Bug#5482).
4467
5df75e47
JR
4468 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4469 frame struct members of non-existent frames (Bug#6284).
4470
699c10bd
JD
44712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4472
4393663b
JD
4473 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4474 variable firstTime not needed on OSX >= 10.6.
4475 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4476 >= 10.5. Use setKnobProportion, setDoubleValue.
4477
4478 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4479 (MAC_OS_X_VERSION_10_5): Define if not defined.
4480 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4481 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4482 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4483
4484 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4485 cString and lossyCString on OSX >= 10.4
4486
58179cce 4487 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4488 sizeToFit on OSX >= 10.2.
4489
4490 * nsimage.m (allocInitFromFile): Don't use deprecated method
4491 bestRepresentationForDevice on OSX >= 10.6.
4492
4493 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4494 to avoid warning.
4495
4496 * emacs.c: Declare unexec_init_emacs_zone.
4497
a63e0781
JD
4498 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4499
699c10bd
JD
4500 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4501
4502 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4503 on svcsMenu (Bug#8842).
4504
4505 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4506 ns_return_types.
4507 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4508
4509 * nsterm.m (QUTF8_STRING): Declare.
4510 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4511 (validRequestorForSendType): Return type is (id).
4512 Change indexOfObjectIdenticalTo to indexOfObject.
4513 Check if we have local selection before returning self (Bug#8842).
4514 (writeSelectionToPasteboard): Put local selection into paste board
4515 if we have a local selection (Bug#8842).
4516 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4517
4518 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4519 (ns_get_local_selection): Declare.
4520
54e10184
LMI
45212011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4522
9888ff71
LMI
4523 * keymap.c (describe_map_tree): Don't insert a double newline at
4524 the end of the buffer (bug#1169) and return whether we inserted
4525 something.
4526
54e10184
LMI
4527 * callint.c (Fcall_interactively): Change "reading args" to
4528 "providing args" to try to clarify what it does (bug#1010).
4529
15fa4783
KH
45302011-07-07 Kenichi Handa <handa@m17n.org>
4531
4532 * composite.c (composition_compute_stop_pos): Ignore a static
4533 composition starting before CHARPOS (Bug#8915).
4534
4535 * xdisp.c (handle_composition_prop): Likewise.
4536
a8815b00
EZ
45372011-07-07 Eli Zaretskii <eliz@gnu.org>
4538
4539 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4540 (Bug#9015)
4541
ef7b981d 45422011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4543
4544 * character.h (unicode_category_t): New enum type.
4545
4546 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4547 (Qchar_code_property_table): New variable.
4548 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4549 (UNIPROP_COMPRESSED_FORM_P): New macros.
4550 (char_table_ascii): Uncompress the compressed values.
4551 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4552 Uncompress the compressed values.
ac389d0c 4553 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4554 (char_table_ref_and_range): Uncompress the compressed values.
4555 (sub_char_table_set): New arg is_uniprop. Callers changed.
4556 Uncompress the compressed values.
4557 (sub_char_table_set_range): Args changed. Callers changed.
4558 (char_table_set_range): Adjuted for the above change.
4559 (map_sub_char_table): Delete args default_val and parent. Add arg
4560 top. Give decoded values to a Lisp function.
640c8776 4561 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4562 values to a Lisp function. Gcpro more variables.
4563 (uniprop_table_uncompress)
4564 (uniprop_decode_value_run_length): New functions.
4565 (uniprop_decoder, uniprop_decoder_count): New variables.
4566 (uniprop_get_decoder, uniprop_encode_value_character)
4567 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4568 New functions.
4569 (uniprop_encoder, uniprop_encoder_count): New variables.
4570 (uniprop_get_encoder, uniprop_table)
4571 (Funicode_property_table_internal, Fget_unicode_property_internal)
4572 (Fput_unicode_property_internal): New functions.
4573 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4574 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4575 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4576 char-code-property-alist.
4577
640c8776 4578 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4579 Vunicode_category_table.
4580
640c8776 4581 * font.c (font_range): Adjust for the change of
c805dec0
KH
4582 Vunicode_category_table.
4583
76b397fb
DN
45842011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4585
4586 * m/iris4d.h: Remove file, move contents ...
4587 * s/irix6-5.h: ... here.
4588
22b4128e
PE
45892011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4590
4591 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4592 * alloc.c (mark_buffer):
4593 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4594 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4595 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4596 This isn't true in general, and it's particularly not true
4597 if Emacs is configured with --with-wide-int.
4598 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4599 New macros, used in the buffer.c change.
4600
869795d6
JD
46012011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4602
4603 * xsettings.c: Use both GConf and GSettings if both are available.
4604 (store_config_changed_event): Add comment.
4605 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4606 (store_tool_bar_style_changed): New functions.
5e617bc2 4607 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4608 (struct xsettings): Move font inside HAVE_XFT.
4609 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4610 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4611 Move inside HAVE_XFT.
640c8776 4612 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4613 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4614 also.
4615 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4616 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4617 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4618 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4619 (parse_settings): Move check for font inside HAVE_XFT.
4620 (read_settings, apply_xft_settings): Add comment.
4621 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4622 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4623 call store_font_name_changed.
4624 (xft_settings_event): Add comment.
4625 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4626 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4627 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4628 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4629 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4630 (xsettings_get_system_font, xsettings_get_system_normal_font):
4631 Add comment.
869795d6 4632
d8ed26bd
PE
46332011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 Random fixes. E.g., (random) never returned negative values.
4636 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4637 subseconds part to the entropy, as that's a bit more random.
4638 Prefer signed to unsigned, since the signedness doesn't matter and
4639 in general we prefer signed. When given a limit, use a
4640 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4641 latter isn't right if USE_2_TAGS_FOR_INTS.
4642 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4643 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4644
cabf1cac
SM
46452011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4646
4647 * textprop.c (text_property_stickiness):
4648 Obey Vtext_property_default_nonsticky.
4649 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4650 * w32fns.c (syms_of_w32fns):
4651 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4652
6e9b2be9
PE
46532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4656 This is more efficient than Ffile_directory_p and avoids a minor race.
4657
90186c68
LMI
46582011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4659
7c301272
LMI
4660 * buffer.c (Foverlay_put): Say what the return value is
4661 (bug#7835).
4662
c4f2d8d4
LMI
4663 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4664 is a directory before asking whether to use the file name
4665 (bug#7564).
ad637907
LMI
4666 (barf_or_query_if_file_exists): Make the "File is a directory"
4667 error be more correct.
c4f2d8d4 4668
90186c68
LMI
4669 * fns.c (Frequire): Remove the mention of the .gz files, since
4670 that's installation-specific, but keep the mention of
4671 `get-load-suffixes'.
4672
da64016e
PE
46732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4674
4675 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4676 Report string overflow if the output is too long.
4677
7d47b580
JB
46782011-07-04 Juanma Barranquero <lekktu@gmail.com>
4679
a555cb87
JB
4680 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4681 (syms_of_gnutls): Remove duplicate DEFSYM for
4682 Qgnutls_bootprop_verify_hostname_error, an error for
4683 Qgnutls_bootprop_verify_error (which is no longer used).
4684
7d47b580
JB
4685 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4686 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4687 Also (re)move comments that are misplaced or no longer relevant.
4688
1e49bfab
LMI
46892011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4690
4691 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4692
1485f4c0
CY
46932011-07-03 Chong Yidong <cyd@stupidchicken.com>
4694
4695 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4696 and background color parameters if they have been changed.
4697
a9ab721e
LMI
46982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4699
4700 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4701
cf7cff57
PE
47022011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4703
2e13213d
PE
4704 * xsettings.c (SYSTEM_FONT): Define only when used.
4705 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4706
cf7cff57
PE
4707 * keymap.c (access_keymap_1): Now static.
4708
7a8e04f7
CY
47092011-07-02 Chong Yidong <cyd@stupidchicken.com>
4710
4711 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4712 leave any prefix arg for the up event (Bug#1586).
4713
61352f62
LMI
47142011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4715
69bb1ef7
LMI
4716 * lread.c (syms_of_lread): Mention single symbols defined by
4717 `defvar' or `defconst' (bug#7154).
4718
61352f62 4719 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4720 (Frequire): Mention get-load-suffixes.
61352f62 4721
28545e04
MR
47222011-07-02 Martin Rudalics <rudalics@gmx.at>
4723
4724 * window.h (window): Remove clone_number slot.
4725 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4726 Remove.
4727 (make_parent_window, make_window, saved_window)
4728 (Fset_window_configuration, save_window_save): Don't deal with
4729 clone numbers.
4730 * buffer.c (Qclone_number): Remove declaration.
4731 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4732
3349e122
SM
47332011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4734
4735 Add multiple inheritance to keymaps.
4736 * keymap.c (Fmake_composed_keymap): New function.
4737 (Fset_keymap_parent): Simplify.
4738 (fix_submap_inheritance): Remove.
4739 (access_keymap_1): New function extracted from access_keymap to handle
4740 embedded parents and handle lists of maps.
4741 (access_keymap): Use it.
4742 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4743 (Fcopy_keymap): Handle embedded parents.
4744 (Fcommand_remapping, define_as_prefix): Simplify.
4745 (Fkey_binding): Simplify.
4746 (syms_of_keymap): Move minibuffer-local-completion-map,
4747 minibuffer-local-filename-completion-map,
4748 minibuffer-local-must-match-map, and
4749 minibuffer-local-filename-must-match-map to Elisp.
4750 (syms_of_keymap): Defsubr make-composed-keymap.
4751 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4752 (parse_menu_item): Trivial simplification.
4753
3279eb87
GM
47542011-07-01 Glenn Morris <rgm@gnu.org>
4755
4756 * Makefile.in (SETTINGS_LIBS): Fix typo.
4757
4550efdf
KI
47582011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4759
4760 * coding.c (Fencode_coding_string): Record the last coding system
4761 used, as the function doc string says (bug#8738).
4762
0949d2b6
JD
47632011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4764
4765 * xsettings.c (store_monospaced_changed): Take new font as arg and
4766 check for change against current_mono_font.
4767 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4768 (emacs_settings_constructor, emacs_settings_get_property)
4769 (emacs_settings_set_property, emacs_settings_class_init)
4770 (emacs_settings_init, gsettings_obj): Remove.
4771 (something_changedCB): New function for HAVE_GSETTINGS.
4772 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4773 with value as argument.
4774 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4775 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4776 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4777 "changed".
4778
4779 * xgselect.c: Add defined (HAVE_GSETTINGS).
4780 (xgselect_initialize): Ditto.
4781
4782 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4783 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4784 xg_select.
4785
bbc6b304
PE
47862011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 * eval.c (struct backtrace): Simplify and port the data structure.
4789 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4790 signed bit field, as this assumption is not portable and it makes
4791 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4792 "char debug_on_exit : 1" as this is not portable either; instead,
4793 use the portable "unsigned int debug_on_exit : 1". Remove unused
4794 member evalargs. Remove obsolete comments about cc bombing out.
4795
9851bfc5
JD
47962011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4797
51bb811f 4798 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4799 Let HAVE_GSETTINGS override HAVE_GCONF.
4800 (store_monospaced_changed): New function.
4801 (EMACS_SETTINGS): A new type derived from GObject to handle
4802 GSettings notifications.
4803 (emacs_settings_constructor, emacs_settings_get_property)
4804 (emacs_settings_set_property, emacs_settings_class_init):
4805 New functions.
4806 (gsettings_client, gsettings_obj): New variables.
4807 (GSETTINGS_SCHEMA): New define.
4808 (something_changedCB): Call store_monospaced_changed.
4809 (init_gsettings): New function.
4810 (xsettings_initialize): Call init_gsettings.
4811 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4812 to NULL.
4813
640c8776 4814 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4815 GCONF_CFLAGS/LIBS.
4816
5386012d
MR
48172011-06-29 Martin Rudalics <rudalics@gmx.at>
4818
4819 * window.c (resize_root_window, grow_mini_window)
4820 (shrink_mini_window): Rename Qresize_root_window to
4821 Qwindow_resize_root_window and Qresize_root_window_vertically to
4822 Qwindow_resize_root_window_vertically.
4823
f13e0b08
PE
48242011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4827
94515237
JB
48282011-06-27 Juanma Barranquero <lekktu@gmail.com>
4829
4830 * makefile.w32-in: Redesign dependencies so they reflect more
4831 clearly which files are directly included by each source file,
4832 and not through other includes.
4833
e43b6e43
MR
48342011-06-27 Martin Rudalics <rudalics@gmx.at>
4835
4836 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4837 (sort_overlays, overlay_strings): When an overlay's clone number
4838 matches the window's clone number process the overlay even if
4839 the overlay's window property doesn't match the current window.
4840
d68443dc
MR
4841 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4842 (Fwindow_hchild): Rename to Fwindow_left_child.
4843 (Fwindow_next): Rename to Fwindow_next_sibling.
4844 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4845 (resize_window_check): Rename to window_resize_check.
4846 (resize_window_apply): Rename to window_resize_apply.
4847 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4848 (Fdelete_other_windows_internal, resize_frame_windows)
4849 (Fsplit_window_internal, Fdelete_window_internal)
4850 (grow_mini_window, shrink_mini_window)
4851 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4852
c7e73be5
JD
48532011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4854
4855 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4856 (emacs_fixed_set_min_size): Remove.
4857 (emacs_fixed_new): Take frame as argument.
4858
4859 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4860 (_EmacsFixedPrivate): Remove minwidth/height.
4861 Add struct frame *f.
4862 (emacs_fixed_init): Initialize priv->f.
4863 (get_parent_class, emacs_fixed_set_min_size): Remove.
4864 (emacs_fixed_new): Set priv->f to argument.
4865 (emacs_fixed_get_preferred_width)
4866 (emacs_fixed_get_preferred_height): Use min_width/height from
4867 frames size_hint to set minimum and natural (Bug#8919).
4868 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4869 and use min_width/height from frames size_hint to set
4870 min_width/height (Bug#8919).
4871
4872 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4873 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4874 Fix indentation.
c7e73be5 4875
cf99dcf8
EZ
48762011-06-26 Eli Zaretskii <eliz@gnu.org>
4877
4878 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4879 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4880 called at ZV.
4881
029529ac
CY
48822011-06-26 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * process.c (wait_reading_process_output): Bypass select if
4885 waiting for a cell while ignoring keyboard input, and input is
4886 pending. Suggested by Jan Djärv (Bug#8869).
4887
7a7ef429
PE
48882011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 Use gnulib's dup2 module instead of rolling our own.
4891 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4892
11fdef7d 48932011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4894
4895 * dispnew.c (scrolling_window): Before scrolling, turn off a
4896 mouse-highlight in the window being scrolled.
4897
cd3520a4
JB
48982011-06-24 Juanma Barranquero <lekktu@gmail.com>
4899
4900 Move DEFSYM to lisp.h and use everywhere.
4901
4902 * character.h (DEFSYM): Move declaration...
4903 * lisp.h (DEFSYM): ...here.
4904
4905 * gnutls.c:
4906 * minibuf.c:
4907 * w32menu.c:
4908 * w32proc.c:
4909 * w32select.c: Don't include character.h.
4910
4911 * alloc.c (syms_of_alloc):
4912 * buffer.c (syms_of_buffer):
4913 * bytecode.c (syms_of_bytecode):
4914 * callint.c (syms_of_callint):
4915 * casefiddle.c (syms_of_casefiddle):
4916 * casetab.c (init_casetab_once):
4917 * category.c (init_category_once, syms_of_category):
4918 * ccl.c (syms_of_ccl):
4919 * cmds.c (syms_of_cmds):
4920 * composite.c (syms_of_composite):
4921 * dbusbind.c (syms_of_dbusbind):
4922 * dired.c (syms_of_dired):
4923 * dispnew.c (syms_of_display):
4924 * doc.c (syms_of_doc):
4925 * editfns.c (syms_of_editfns):
4926 * emacs.c (syms_of_emacs):
4927 * eval.c (syms_of_eval):
4928 * fileio.c (syms_of_fileio):
4929 * fns.c (syms_of_fns):
4930 * frame.c (syms_of_frame):
4931 * fringe.c (syms_of_fringe):
4932 * insdel.c (syms_of_insdel):
4933 * keymap.c (syms_of_keymap):
4934 * lread.c (init_obarray, syms_of_lread):
4935 * macros.c (syms_of_macros):
4936 * msdos.c (syms_of_msdos):
4937 * print.c (syms_of_print):
4938 * process.c (syms_of_process):
4939 * search.c (syms_of_search):
4940 * sound.c (syms_of_sound):
4941 * syntax.c (init_syntax_once, syms_of_syntax):
4942 * terminal.c (syms_of_terminal):
4943 * textprop.c (syms_of_textprop):
4944 * undo.c (syms_of_undo):
4945 * w32.c (globals_of_w32):
4946 * window.c (syms_of_window):
4947 * xdisp.c (syms_of_xdisp):
4948 * xfaces.c (syms_of_xfaces):
4949 * xfns.c (syms_of_xfns):
4950 * xmenu.c (syms_of_xmenu):
4951 * xsettings.c (syms_of_xsettings):
4952 * xterm.c (syms_of_xterm): Use DEFSYM.
4953
4228cf16
TZ
49542011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4955
cd3520a4 4956 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4957
7fcccf1e
PE
49582011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4959
7efb4e0e
PE
4960 Integer and buffer overflow fixes (Bug#8873).
4961
ff5844ad
PE
4962 * print.c (printchar, strout): Check for string overflow.
4963 (PRINTPREPARE, printchar, strout):
4964 Don't set size unless allocation succeeds.
4965
90532f02
PE
4966 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4967 for sizes. Check for string overflow more accurately.
4968 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4969
6d84508d
PE
4970 * macros.c: Integer and buffer overflow fixes.
4971 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4972 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4973 Use ptrdiff_t, not int, for sizes.
4974 Don't increment bufsize until after realloc succeeds.
4975 Check for size-calculation overflow.
4976 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4977
437b2cb4
PE
4978 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4979
8b9ac8b4
PE
4980 * lread.c: Integer overflow fixes.
4981 (read_integer): Radix is now EMACS_INT, not int,
4982 to improve quality of diagnostics for out-of-range radices.
4983 Calculate buffer size correctly for out-of-range radices.
4984 (read1): Check for integer overflow in radices, and in
4985 read-circle numbers.
82cb60d3
PE
4986 (read_escape): Avoid int overflow.
4987 (Fload, openp, read_buffer_size, read1)
4988 (substitute_object_recurse, read_vector, read_list, map_obarray):
4989 Use ptrdiff_t, not int, for sizes.
4990 (read1): Use EMACS_INT, not int, for sizes.
20270765 4991 Check for size overflow.
8b9ac8b4 4992
7fcccf1e
PE
4993 * image.c (cache_image): Check for size arithmetic overflow.
4994
bfbbd7e7
PE
4995 * lread.c: Integer overflow issues.
4996 (saved_doc_string_size, saved_doc_string_length)
4997 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4998 Now ptrdiff_t, not int.
4999 (read1): Don't assume doc string length fits in int. Check for
5000 out-of-range doc string lengths.
5001 (read_list): Don't assume file position fits in int.
39019e54 5002 (read_escape): Check for hex character overflow.
bfbbd7e7 5003
4e323265
LL
50042011-06-22 Leo Liu <sdl.web@gmail.com>
5005
5006 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5007 Move to minibuffer.el.
5008
85fece3e
PE
50092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5010
20b84ce9 5011 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5012 The following patches are for when GLYPH_DEBUG && !XASSERT.
5013 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5014 * dispnew.c (flush_stdout):
5015 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5016 Mark as externally visible.
5017 * dispnew.c (check_window_matrix_pointers): Now static.
5018 * dispnew.c (window_to_frame_vpos):
5019 * xfns.c (unwind_create_frame):
5020 * xterm.c (x_check_font): Remove unused local.
5021 * scroll.c (CHECK_BOUNDS):
5022 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5023 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5024 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5025 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5026 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5027 Now static.
5028 (debug_method_add): Use va_list and vsprintf rather than relying
5029 on undefined behavior with wrong number of arguments.
5030 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5031 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5032 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5033 since we're not interested in debugging glyphs with old libraries.
5034 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5035 GCC 4.6.0's static checking.
5036
0766b489
PE
50372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5038
31fd4b32
PE
5039 Integer overflow and signedness fixes (Bug#8873).
5040 A few related buffer overrun fixes, too.
5041
b79e8648
PE
5042 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5043
0766b489
PE
5044 * dispextern.h (struct face.stipple):
5045 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5046 (x_bitmap_mask, x_allocate_bitmap_record)
5047 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5048 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5049 (x_create_bitmap_from_xpm_data):
5050 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5051 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5052 (.bitmaps_last):
5053 * xfaces.c (load_pixmap):
5054 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5055 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5056 (.bitmaps_last, struct x_output.icon_bitmap):
5057 Use ptrdiff_t, not int, for bitmap indexes.
5058 (x_allocate_bitmap_record): Check for size overflow.
5059 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5060
b081724f
PE
5061 Use ptrdiff_t, not int, for overlay counts.
5062 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5063 * editfns.c (overlays_around, get_pos_property):
5064 * textprop.c (get_char_property_and_overlay):
5065 * xdisp.c (next_overlay_change, note_mouse_highlight):
5066 * xfaces.c (face_at_buffer_position):
21514da7
PE
5067 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5068 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5069 (Fnext_overlay_change, Fprevious_overlay_change)
5070 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5071 Use ptrdiff_t, not int, for sizes.
21514da7 5072 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5073
3de73e5e
PE
5074 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5075
2606c57b
PE
5076 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5077 (x_session_initialize): Do not assume string length fits in int.
5078
aaafe47a
PE
5079 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5080 This is unlikely, but can occur if DPI is outlandish.
5081
2674ddc8 5082 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5083 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5084
28154962
PE
5085 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5086 * xrdb.c (magic_file_p, search_magic_path):
5087 Omit last arg SUFFIX; it was always 0. All callers changed.
5088 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5089
7de51af5
PE
5090 * xfont.c (xfont_match): Avoid need for strlen.
5091
25ed6cc3
PE
5092 * xfns.c: Don't assume strlen fits in int.
5093 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5094
4eab31dd
PE
5095 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5096 not unsigned long, as we prefer signed integers. All callers changed.
5097 Detect integer overflow in repeat count.
5098 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5099 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5100
171e2a58
PE
5101 * termcap.c: Don't assume sizes fit in int and never overflow.
5102 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5103 (gobble_line): Check for size-calculation overflow.
5104
ad39faca 5105 * minibuf.c (Fread_buffer):
6e5bb2dc 5106 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5107 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5108 Don't assume string length fits in int.
5109
52c61c22 5110 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5111 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5112
b5b8c9e5
PE
5113 * font.c: Don't assume string length fits in int.
5114 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5115 Use ptrdiff_t, not int.
ccd6111c
PE
5116 (font_intern_prop): Don't assume string length fits in int.
5117 Don't assume integer property fits in fixnum.
5118 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5119
882f0d81 5120 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5121 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5122 Reformulate so as not to need the command string.
5123 Invoke gzip -cd rather than gunzip, as it's more portable.
5124 (lock_info_type, lock_file_1, lock_file):
5125 Don't assume pid_t and time_t fit in unsigned long.
5126 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5127 (current_lock_owner): Prefer signed type for sizes.
5128 Use memcpy, not strncpy, where memcpy is what is really wanted.
5129 Don't assume (via atoi) that time_t and pid_t fit in int.
5130 Check for time_t and/or pid_t out of range, e.g., via a network share.
5131 Don't alloca where an auto var works fine.
5132
93f4cf88
PE
5133 * fileio.c: Fix some integer overflow issues.
5134 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5135 Don't assume string length fits in int.
5136 (directory_file_name): Don't assume string length fits in long.
5137 (make_temp_name): Don't assume pid fits in int, or that its print
5138 length is less than 20.
5139
f3e92b69
PE
5140 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5141
1bfdaf10
PE
5142 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5143
35016e9a
PE
5144 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5145
3d1e65a1
PE
5146 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5147 We prefer signed integers, even for size calculations.
5148
0b963a93
PE
5149 * emacs.c: Don't assume string length fits in 'int'.
5150 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5151 (main): Don't invoke strlen when not needed.
5152
573f4b54
PE
5153 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5154 (XD_DEBUG_MESSAGE): Don't waste a byte.
5155
989f33ba
PE
5156 * callproc.c (getenv_internal_1, getenv_internal)
5157 (Fgetenv_internal):
965d34eb
PE
5158 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5159
e4d29b33
PE
5160 * lread.c (invalid_syntax): Omit length argument.
5161 All uses changed. This doesn't fix a bug, but it simplifies the
5162 code away from its former Hollerith-constant appearance, and it's
5163 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5164 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5165
eb49b136
PE
5166 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5167 This didn't break anything, but it didn't help either.
5168 It's confusing to put a bogus integer in a place where the actual
5169 value does not matter.
9f62aeb1 5170 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5171 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5172
15375a22
PE
5173 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5174 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5175 implementation.
b61cc01c
PE
5176 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5177 We prefer signed types, and the value cannot exceed the EMACS_INT
5178 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5179 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5180 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5181 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5182
53b2623d
PE
5183 * indent.c (sane_tab_width): New function.
5184 (current_column, scan_for_column, Findent_to, position_indentation)
5185 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5186 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5187
51cab52b 5188 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5189
f2ed8a70
PE
5190 * lisp.h (lint_assume): New macro.
5191 * composite.c (composition_gstring_put_cache):
5192 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5193
abe80cc6
PE
5194 * editfns.c, insdel.c:
5195 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5196
b02c740e
PE
5197 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5198
ebc96716
PE
5199 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5200
b4e50fa0 5201 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5202 Use much-faster test for byte-length change.
311d5d7c 5203 Don't assume string byte-length fits in 'int'.
a4cf38e4 5204 Check that character arg fits in 'int'.
85461888 5205 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5206
c0c1ee9f
PE
5207 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5208
a498d7f4
PE
5209 * fns.c (concat): Catch string overflow earlier.
5210 Do not rely on integer wraparound.
5211
51cab52b
PE
5212 * dispextern.h (struct it.overlay_strings_charpos)
5213 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5214 * xdisp.c (forward_to_next_line_start)
5215 (back_to_previous_visible_line_start)
5216 (reseat_at_next_visible_line_start, next_element_from_buffer):
5217 Don't arbitrarily truncate the value of 'selective' to int.
5218
76031fad
PE
5219 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5220
5eb55db9
PE
5221 * composite.c: Don't truncate sizes to 'int'.
5222 (composition_gstring_p, composition_reseat_it)
5223 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5224 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5225 not EMACS_UINT, for indexes.
5eb55db9 5226
0703a717
PE
5227 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5228
d6202519
PE
5229 * buffer.c: Include <verify.h>.
5230 (struct sortvec.priority, struct sortstr.priority):
8961a454 5231 Now EMACS_INT, not int.
c20998a7 5232 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5233 (struct sortstr.size, record_overlay_string)
5234 (struct sortstrlist.size, struct sortlist.used):
5235 Don't truncate size to int.
5236 (record_overlay_string): Check for size-calculation overflow.
d6202519 5237 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5238
d5a19415
JM
52392011-06-22 Jim Meyering <meyering@redhat.com>
5240
029529ac 5241 Don't leak an XBM-image-sized buffer
d5a19415
JM
5242 * image.c (xbm_load): Free the image buffer after using it.
5243
a9041e6c
PE
52442011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 Port to Sun C.
5247 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5248 that Sun C diagnosed.
5249 * fns.c (secure_hash): Fix pointer signedness issue.
5250 * intervals.c (static_offset_intervals): New function.
5251 (offset_intervals): Use it.
5252
7f3f739f
LL
52532011-06-21 Leo Liu <sdl.web@gmail.com>
5254
5255 * deps.mk (fns.o):
5256 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5257 sha512.h.
5258
5259 * fns.c (secure_hash): Rename from crypto_hash_function and change
5260 the first arg to accept symbols.
5b66d427 5261 (Fsecure_hash): New primitive.
7f3f739f
LL
5262 (syms_of_fns): New symbols.
5263
76147d94
DD
52642011-06-20 Deniz Dogan <deniz@dogan.se>
5265
5266 * process.c (Fset_process_buffer): Clarify return value in
5267 docstring.
5268
7d7d0045
CY
52692011-06-18 Chong Yidong <cyd@stupidchicken.com>
5270
5271 * dispnew.c (add_window_display_history): Use BVAR.
5272
5273 * xdisp.c (debug_method_add): Use BVAR.
5274 (check_window_end, dump_glyph_matrix, dump_glyph)
5275 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5276
5277 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5278 Likewise.
5279
5280 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5281 check till after the cache is created in init_frame_faces.
5282
ff2bc410
SM
52832011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5284
5285 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5286
28177add
PE
52872011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5288
dd3482fe
PE
5289 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5290 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5291 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5292
393d71f3 5293 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5294 * fileio.c (Finsert_file_contents):
5295 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5296 Remove the old (too-loose) buffer overflow checks.
5297 They weren't needed, since make_gap checks for buffer overflow.
5298 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5299 The old code merely checked for Emacs fixnum overflow, and relied
5300 on undefined (wraparound) behavior. The new code avoids undefined
5301 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5302
2e6813b0 5303 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5304 Tune. Don't use wider integers than needed. Don't use alloca.
5305 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5306
599a9e4f
PE
5307 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5308
99561444
PE
5309 * insdel.c, lisp.h (buffer_overflow): New function.
5310 (insert_from_buffer_1, replace_range, replace_range_2):
5311 * insdel.c (make_gap_larger):
5312 * editfns.c (Finsert_char):
5313 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5314
28177add
PE
5315 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5316
e69dafad
PE
53172011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5318
4baa020d 5319 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5320
b1c46f02
PE
5321 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5322 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5323
e69dafad
PE
5324 * fileio.c: Don't assume EMACS_INT fits in off_t.
5325 (emacs_lseek): New static function.
5326 (Finsert_file_contents, Fwrite_region): Use it.
5327 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5328
566684ea
PE
5329 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5330
e6966cd6
PE
5331 * fns.c: Don't overflow int when computing a list length.
5332 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5333 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5334 truncation on 64-bit hosts. Check for QUIT every
5335 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5336 faster and is responsive enough.
5337 (Flength): Report an error instead of overflowing an integer.
5338 (Fsafe_length): Return a float if the value is not representable
5339 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5340 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5341 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5342
dd0b0efb
PE
5343 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5344 (header_size, word_size): New constants.
5345 (allocate_vectorlike): Don't check size overflow here.
5346 (allocate_vector): Check it here instead, since this is the only
5347 caller of allocate_vectorlike that could cause overflow.
5348 Check that the new vector's length is representable as a fixnum.
5349
86fe5cfe
PE
5350 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5351 The previous code was bogus. For example, next_almost_prime (32)
5352 returned 39, which is undesirable as it is a multiple of 3; and
5353 next_almost_prime (24) returned 25, which is a multiple of 5 so
5354 why was the code bothering to check for multiples of 7?
5355
80e88859
PE
5356 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5357
4a2f0ad6
PE
5358 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5359
f66c7cf8
PE
5360 Variadic C functions now count arguments with ptrdiff_t.
5361 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5362 Back then I didn't know that the Emacs coding style prefers signed int.
5363 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5364 were being counted with int, which may truncate counts on 64-bit
5365 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5366 * lisp.h (struct Lisp_Subr.function.aMANY)
5367 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5368 Arg counts are now ptrdiff_t, not size_t.
5369 All variadic functions and their callers changed accordingly.
5370 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5371 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5372 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5373 * callint.c (Fcall_interactively): Check arg count for overflow,
5374 to avoid potential buffer overrun. Use signed char, not 'int',
5375 for 'varies' array, so that we needn't bother to check its size
5376 calculation for overflow.
5377 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5378 * eval.c (apply_lambda):
5379 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5380 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5381 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5382
a1759b76
PE
5383 * callint.c (Fcall_interactively): Don't use index var as event count.
5384
d96be9fc
PE
5385 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5386 * mem-limits.h (SIZE): Remove; no longer used.
5387
a690a978 5388 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5389
578c21e6
PE
5390 Remove unnecessary casts.
5391 * xterm.c (x_term_init):
5392 * xfns.c (x_set_border_pixel):
5393 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5394 These aren't needed now that we assume ANSI C.
5395
96f53c6c
PE
5396 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5397 It's more likely to cause problems (due to unsigned overflow)
5398 than to cure them.
5399
83c77d31
PE
5400 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5401
ee2079f1
PE
5402 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5403
6da65536
PE
5404 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5405
7147c4a4
PE
5406 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5407
193e32d9
PE
5408 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5409
e5533da6
PE
5410 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5411
9910e595
PE
5412 GLYPH_CODE_FACE returns EMACS_INT, not int.
5413 * dispextern.h (merge_faces):
5414 * xfaces.c (merge_faces):
01103c44
PE
5415 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5416 Don't assume EMACS_INT fits in int.
9910e595 5417
2638320e
PE
5418 * character.h (CHAR_VALID_P): Remove unused parameter.
5419 * fontset.c, lisp.h, xdisp.c: All uses changed.
5420
045eb8d9
PE
5421 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5422
c1f134b5
PE
5423 * fns.c (concat): Minor tuning based on overflow analysis.
5424 This doesn't fix any bugs. Use int to hold character, instead
5425 of constantly refetching from Emacs object. Use XFASTINT, not
5426 XINT, for value known to be a character. Don't bother comparing
5427 a single byte to 0400, as it's always less.
5428
395fcb93 5429 * floatfns.c (Fexpt):
327eeec8
PE
5430 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5431
abbd3d23
PE
5432 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5433 for characters.
5434
684a03ef
PE
5435 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5436
0fed43f3
PE
5437 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5438 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5439 incorrectly succeed when S was a string, because 4294967386 was
5440 truncated before it was used.
5441
8fd02eb7
PE
5442 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5443 Otherwise, an out-of-range integer could cause undefined behavior
5444 on a 64-bit host.
5445
f8c86b69
PE
5446 * composite.c: Use int, not EMACS_INT, for characters.
5447 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5448 EMACS_INT, for values that are known to be in character range.
5449 This doesn't fix any bugs but is the usual style inside Emacs and
5450 may generate better code on 32-bit machines.
5451
34206dd2
PE
5452 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5453 This is for reasons similar to the recent CHAR_STRING fix.
5454 * charset.c (Fencode_char): Check that character arg is actually
5455 a character. Pass an int to ENCODE_CHAR.
5456 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5457 wider than 'int', as a compile-time check to prevent future regressions
5458 in this area.
5459
c5958d4c 5460 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5461
5462 Make sure a 64-bit char is never passed to CHAR_STRING.
5463 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5464 by silently ignoring the top 32 bits, allowing some values
5465 that were far too large to be valid characters.
5466 * character.h: Include <verify.h>.
5467 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5468 arguments are no wider than unsigned, as a compile-time check
5469 to prevent future regressions in this area.
5470 * data.c (Faset):
01103c44 5471 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5472 (Fsubst_char_in_region):
5473 * fns.c (concat):
5474 * xdisp.c (decode_mode_spec_coding):
5475 Adjust to CHAR_STRING's new requirement.
5476 * editfns.c (Finsert_char, Fsubst_char_in_region):
5477 * fns.c (concat): Check that character args are actually
5478 characters. Without this test, these functions did the wrong
5479 thing with wildly out-of-range values on 64-bit hosts.
5480
d37ca623
PE
5481 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5482 These casts should not be needed on 32-bit hosts, either.
5483 * keyboard.c (read_char):
5484 * lread.c (Fload): Remove casts to unsigned.
5485
ea204efb
PE
5486 * lisp.h (UNSIGNED_CMP): New macro.
5487 This fixes comparison bugs on 64-bit hosts.
5488 (ASCII_CHAR_P): Use it.
5489 * casefiddle.c (casify_object):
01103c44 5490 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5491 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5492 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5493 * dispextern.h (FACE_FROM_ID):
5494 * keyboard.c (read_char): Use UNSIGNED_CMP.
5495
41cb286c
PE
5496 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5497 not to EMACS_INT, to avoid GCC warning.
5498
4a1b9832
PE
5499 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5500
55daad71
PE
5501 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5502 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5503 isn't needed on 32-bit machines.
8f95c75c 5504
01103c44
PE
5505 * buffer.c (Fgenerate_new_buffer_name):
5506 Use EMACS_INT for count, not int.
0ceccced 5507 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5508
5509 * data.c (Qcompiled_function): Now static.
5510
c6f072e7
PE
5511 * window.c (window_body_lines): Now static.
5512
20ce5912
PE
5513 * image.c (gif_load): Rename local to avoid shadowing.
5514
9c4c5f81
PE
5515 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5516 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5517 * alloc.c (make_save_value): Integer argument is now of type
5518 ptrdiff_t, not int.
5519 (mark_object): Use ptrdiff_t, not int.
5520 * lisp.h (pD): New macro.
5521 * print.c (print_object): Use it.
5522
c0c5c8ae
PE
5523 * alloc.c: Use EMACS_INT, not int, to count objects.
5524 (total_conses, total_markers, total_symbols, total_vector_size)
5525 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5526 (total_free_floats, total_floats, total_free_intervals)
5527 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5528 Now EMACS_INT, not int. All uses changed.
5529 (Fgarbage_collect): Compute overall total using a double, so that
5530 integer overflow is less likely to be a problem. Check for overflow
5531 when converting back to an integer.
5a25e253
PE
5532 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5533 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5534 These were 'int' variables that could overflow on 64-bit hosts;
5535 they were never used, so remove them instead of repairing them.
211a0b2a 5536 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5537 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5538 Previously, this ceilinged at INT_MAX, but that doesn't work on
5539 64-bit machines.
e46bb31a 5540 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5541
c78baabf 5542 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5543 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5544 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5545 when a (possibly-narrower) signed value would do just as well.
5546 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5547
c9d624c6
PE
5548 * alloc.c: Catch some string size overflows that we were missing.
5549 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5550 for convenience in STRING_BYTES_MAX.
5551 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5552 The definition here is exact; the one in lisp.h was approximate.
5553 (allocate_string_data): Check for string overflow. This catches
5554 some instances we weren't catching before. Also, it catches
5555 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5556 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5557 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5558
c9d624c6
PE
5559 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5560 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5561 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5562
353032ce
PE
5563 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5564
2bccce07
PE
5565 * alloc.c (Fmake_string): Check for out-of-range init.
5566
0ac30604
SM
55672011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5568
5569 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5570
c195f2de
JD
55712011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5572
5573 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5574 xg_get_default_scrollbar_width.
5575
5576 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5577 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5578 (style_changed_cb): Call update_theme_scrollbar_width and call
5579 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5580 all frames (Bug#8505).
5581 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5582 Call gtk_window_set_resizable if HAVE_GTK3.
5583 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5584 and height if HAVE_GTK3 (Bug#8505).
5585 (scroll_bar_width_for_theme): New variable.
5586 (update_theme_scrollbar_width): New function.
5587 (xg_get_default_scrollbar_width): Move code to
5588 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5589 (xg_initialize): Call update_theme_scrollbar_width.
5590
5591 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5592
5593 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5594
e10ac9f1
MR
55952011-06-12 Martin Rudalics <rudalics@gmx.at>
5596
5597 * frame.c (make_frame): Call other_buffer_safely instead of
5598 other_buffer.
5599
5600 * window.c (temp_output_buffer_show): Call display_buffer with
5601 second argument Vtemp_buffer_show_specifiers and reset latter
5602 immediately after the call.
5603 (Vtemp_buffer_show_specifiers): New variable.
5604 (auto_window_vscroll_p, next_screen_context_lines)
5605 (Vscroll_preserve_screen_position): Remove leading asterisks from
5606 doc-strings.
5607
2d3c217e 56082011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5609
7b7f97e8 5610 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5611 * buffer.c (Qclone_number): Remove for now, as it's unused.
5612 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5613 (record_buffer): Remove unused local.
5614 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5615 (set_frame_buffer_list): Remove; unused.
5616 * frame.h (other_visible_frames): Remove decl.
5617 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5618 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5619 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5620 if HAVE_GPM.
5621 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5622 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5623 Define only if HAVE_GPM.
5624 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5625 (update_hints_inhibit): Remove; never set. All uses removed.
5626 * widgetprv.h (emacsFrameClassRec): Remove decl.
5627 * window.c (delete_deletable_window): Now returns void, since it
5628 wasn't returning anything.
5629 (compare_window_configurations): Remove unused locals.
5630 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5631 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5632 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5633 the same widths as pointers. This follows up on the 2011-05-06 patch.
5634 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5635 * xterm.h: Likewise.
5636 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5637
1384b89e
JB
56382011-06-12 Juanma Barranquero <lekktu@gmail.com>
5639
5640 * makefile.w32-in: Update dependencies.
5641 (LISP_H): Add lib/intprops.h.
5642
1100a63c
CY
56432011-06-11 Chong Yidong <cyd@stupidchicken.com>
5644
5645 * image.c (gif_load): Add animation frame delay to the metadata.
5646 (syms_of_image): Use DEFSYM. New symbol `delay'.
5647
6198ccd0
MR
56482011-06-11 Martin Rudalics <rudalics@gmx.at>
5649
5650 * window.c (delete_deletable_window): Re-add.
5651 (Fset_window_configuration): Rewrite to handle dead buffers and
5652 consequently deletable windows.
5653 (window_tree, Fwindow_tree): Remove. Supply functionality in
5654 window.el.
5655 (compare_window_configurations): Simplify code.
5656
b6e3633c
AS
56572011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5658
1ab0dee5
AS
5659 * image.c (imagemagick_load_image): Fix type mismatch.
5660 (Fimagemagick_types): Likewise.
5661
b6e3633c
AS
5662 * window.h (replace_buffer_in_windows): Declare.
5663
9397e56f
MR
56642011-06-11 Martin Rudalics <rudalics@gmx.at>
5665
5666 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5667 Qclone_number. Remove external declaration of Qdelete_window.
5668 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5669 code.
640c8776
SM
5670 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5671 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5672 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5673 buffer list implementation.
5674 (other_buffer_safely): New function.
5675 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5676 calls to replace_buffer_in_windows and
5677 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5678 if allowed.
5679 (record_buffer): Inhibit quitting and rewrite using quittable
5680 functions. Run Qbuffer_list_update_hook if allowed.
5681 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5682 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5683 Move switch-to-buffer to window.el.
9397e56f
MR
5684 (bury-buffer): Move to window.el.
5685 (Vbuffer_list_update_hook): New variable.
5686
5687 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5688 section.
5689
5690 * window.h (resize_frame_windows): Move up in code.
5691 (Fwindow_frame): Remove EXFUN.
5692 (replace_buffer_in_all_windows): Remove prototype.
5693 (replace_buffer_in_windows_safely): Add prototype.
5694
5695 * window.c: Declare Qdelete_window static again. Move down
5696 declaration of select_count.
5697 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5698 (Fother_window): Move to window.el.
5699 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5700 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5701 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5702 window.el.
5703 (replace_buffer_in_windows): Implement by calling
5704 Qreplace_buffer_in_windows.
5705 (replace_buffer_in_all_windows): Remove with some functionality
5706 moved into replace_buffer_in_windows_safely.
5707 (replace_buffer_in_windows_safely): New function.
5708 (select_window_norecord, select_frame_norecord): Move in front
5709 of run_window_configuration_change_hook. Remove now obsolete
5710 declarations.
640c8776
SM
5711 (Fset_window_buffer): Rewrite doc-string.
5712 Call Qrecord_window_buffer.
9397e56f
MR
5713 (keys_of_window): Move binding for other-window to window.el.
5714
b50691aa
CY
57152011-06-11 Chong Yidong <cyd@stupidchicken.com>
5716
5717 * dispextern.h (struct image): Replace data member, whose int_val
5718 and ptr_val fields were not used by anything, with a single
5719 lisp_val object.
5720
5721 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5722 (gif_clear_image, gif_load, imagemagick_load_image)
5723 (gs_clear_image, gs_load): Callers changed.
5724
3f754b86
PE
57252011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5726
cca69397
PE
5727 * buffer.h: Include <time.h>, for time_t.
5728 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5729
109e28d0
PE
5730 Fix minor problems found by static checking.
5731
60737f02
PE
5732 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5733
4b66faf3
PE
5734 Make identifiers static if they are not used in other modules.
5735 * data.c (Qcompiled_function, Qframe, Qvector):
5736 * image.c (QimageMagick, Qsvg):
5737 * minibuf.c (Qmetadata):
5738 * window.c (resize_window_check, resize_root_window): Now static.
5739 * window.h (resize_window_check, resize_root_window): Remove decls.
5740
109e28d0
PE
5741 * window.c (window_deletion_count, delete_deletable_window):
5742 Remove; unused.
46a4ce9e
PE
5743 (window_body_lines): Now static.
5744 (Fdelete_other_windows_internal): Mark vars as initialized.
5745 Make sure 'resize_failed' is initialized.
5746 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5747 (resize_window_apply): Remove unused local.
5748 * window.h (delete_deletable_window): Remove decl.
5749
109e28d0 5750 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5751 (imagemagick_load_image): Fix pointer signedness problem by changing
5752 last arg from unsigned char * to char *. All uses changed.
5753 Also, fix a local for similar reasons.
5754 Remove unused locals. Remove locals to avoid shadowing.
5755 (fn_rsvg_handle_free): Remove; unused.
5756 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5757 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5758
3f754b86
PE
5759 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5760
2547adb1
CY
57612011-06-10 Chong Yidong <cyd@stupidchicken.com>
5762
5763 * image.c (gif_load): Fix omitted cast error introduced by
5764 2011-06-06 change.
5765
2c8e37d4
MR
57662011-06-10 Martin Rudalics <rudalics@gmx.at>
5767
5768 * window.h (resize_proportionally, orig_total_lines)
5769 (orig_top_line): Remove from window structure.
5770 (set_window_height, set_window_width, change_window_heights)
5771 (Fdelete_window): Remove prototypes.
5772 (resize_frame_windows): Remove duplicate declaration.
5773
440a42e3
EZ
57742011-06-10 Eli Zaretskii <eliz@gnu.org>
5775
5776 * window.h (resize_frame_windows, resize_window_check)
5777 (delete_deletable_window, resize_root_window)
5778 (resize_frame_windows): Declare prototypes.
5779
5780 * window.c (resize_window_apply): Make definition be "static" to
5781 match the prototype.
5782
562dd5e9
MR
57832011-06-10 Martin Rudalics <rudalics@gmx.at>
5784
5785 * window.c: Remove declarations of Qwindow_size_fixed,
5786 window_min_size_1, window_min_size_2, window_min_size,
5787 size_window, window_fixed_size_p, enlarge_window, delete_window.
5788 Remove static from declaration of Qdelete_window, it's
5789 temporarily needed by Fbury_buffer.
5790 (replace_window): Don't assign orig_top_line and
5791 orig_total_lines.
5792 (Fdelete_window, delete_window): Remove. Window deletion is
5793 handled by window.el.
640c8776
SM
5794 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5795 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5796 (Fdelete_other_windows): Remove. Deleting other windows is
5797 handled by window.el.
5798 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5799 handled in window.el.
5800 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5801 Window minimum sizes are handled in window.el.
5802 (shrink_windows, size_window, set_window_height)
5803 (set_window_width, change_window_heights, window_height)
5804 (window_width, CURBEG, CURSIZE, enlarge_window)
5805 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5806 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5807 handled in window.el.
5808 (make_dummy_parent): Rename to make_parent_window and give it a
5809 second argument horflag.
5810 (make_window): Don't set resize_proportionally any more.
5811 (Fsplit_window): Remove. Windows are split in window.el.
5812 (save_restore_action, save_restore_orig_size)
5813 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5814 Resize mini windows in window.el.
5815 (grow_mini_window, shrink_mini_window): Implement by calling
5816 Qresize_root_window_vertically, resize_window_check and
5817 resize_window_apply.
640c8776
SM
5818 (saved_window, Fset_window_configuration, save_window_save):
5819 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5820 resize_proportionally.
5821 (window_min_height, window_min_width): Move to window.el.
5822 (keys_of_window): Move bindings for delete-other-windows,
5823 split-window, delete-window and enlarge-window to window.el.
5824
5825 * buffer.c: Temporarily extern Qdelete_window.
5826 (Fbury_buffer): Temporarily call Qdelete_window instead of
5827 Fdelete_window (Fbury_buffer will move to window.el soon).
5828
5829 * frame.c (set_menu_bar_lines_1): Remove code handling
5830 orig_top_line and orig_total_lines.
5831
5832 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5833 set_window_height but set heights directly.
5834 (change_frame_size_1): Use resize_frame_windows.
5835
5836 * xdisp.c (init_xdisp): Don't use set_window_height but set
5837 heights directly.
5838
640c8776
SM
5839 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5840 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5841 run_window_configuration_change_hook.
5842
5843 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5844 instead of change_window_heights and run
5845 run_window_configuration_change_hook.
5846
1a13852e
MR
58472011-06-09 Martin Rudalics <rudalics@gmx.at>
5848
5849 * window.c (replace_window): Rename second argument REPLACEMENT to
5850 NEW. New third argument SETFLAG. Rewrite.
5851 (delete_window, make_dummy_parent): Call replace_window with
5852 third argument 1.
5853 (window_list_1): Move down in code.
5854 (run_window_configuration_change_hook): Move set_buffer part
5855 before select_frame_norecord part in order to unwind correctly.
5856 Rename count1 to count.
5857 (recombine_windows, delete_deletable_window, resize_root_window)
5858 (Fdelete_other_windows_internal)
5859 (Frun_window_configuration_change_hook, make_parent_window)
5860 (resize_window_check, resize_window_apply, Fresize_window_apply)
5861 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5862 (Fdelete_window_internal, Fresize_mini_window_internal):
5863 New functions.
1a13852e
MR
5864 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5865
f3d1777e
MR
58662011-06-08 Martin Rudalics <rudalics@gmx.at>
5867
496e208e
MR
5868 * window.h (window): Add some new members to window structure -
5869 normal_lines, normal_cols, new_total, new_normal, clone_number,
5870 splits, nest, prev_buffers, next_buffers.
5871 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5872 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5873
f3d1777e
MR
5874 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5875 Remove.
496e208e
MR
5876 (make_dummy_parent): Set new members of windows structure.
5877 (make_window): Move down in code. Handle new members of window
5878 structure.
5879 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5880 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5881 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5882 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5883 (Fset_window_next_buffers, Fset_window_clone_number):
5884 New functions.
496e208e
MR
5885 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5886 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5887 Doc-string fixes.
5888 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5889 Argument WINDOW can be now internal window too.
5890 (Fwindow_use_time): Move up in code.
5891 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5892 Rewrite doc-string.
5893 (Fset_window_configuration, saved_window)
5894 (Fcurrent_window_configuration, save_window_save): Handle new
5895 members of window structure.
b9e809c2
MR
5896 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5897 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5898 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5899 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5900 Qget_mru_window, Qresize_root_window,
5901 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5902 Qauto_buffer_name; staticpro them.
f3d1777e 5903
abde8f8c
MR
59042011-06-07 Martin Rudalics <rudalics@gmx.at>
5905
5906 * window.c (Fwindow_total_size, Fwindow_left_column)
5907 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5908 (Fwindow_list_1): New functions.
5909 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5910 (Fwindow_width, Fscroll_left, Fscroll_right):
5911 Use window_body_cols instead of window_box_text_cols.
5912 (delete_window, Fset_window_configuration):
5913 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5914 (delete_all_subwindows): Take a window as argument and not a
5915 structure. Rewrite.
190b47e6
MR
5916 (window_loop): Remove handling of GET_LRU_WINDOW and
5917 GET_LARGEST_WINDOW.
5918 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5919
5920 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5921 window_box_text_cols. delete_all_subwindows now takes a
5922 Lisp_Object as argument.
abde8f8c 5923
640c8776
SM
5924 * indent.c (compute_motion, Fcompute_motion):
5925 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5926
fa8a67e6
MR
5927 * frame.c (delete_frame): Call delete_all_subwindows with root
5928 window as argument.
5929
a54e3482
DC
59302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5931
5932 * fns.c (Fputhash): Document return value.
5933
60002bf5
CY
59342011-06-06 Chong Yidong <cyd@stupidchicken.com>
5935
5936 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5937
0c671da6 59382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5939
b862a52a 5940 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5941
be44ca6c
PE
5942 Check for overflow when converting integer to cons and back.
5943 * charset.c (Fdefine_charset_internal, Fdecode_char):
5944 Use cons_to_unsigned to catch overflow.
5945 (Fencode_char): Use INTEGER_TO_CONS.
5946 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5947 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5948 * data.c (long_to_cons, cons_to_long): Remove.
5949 (cons_to_unsigned, cons_to_signed): New functions.
5950 These signal an error for invalid or out-of-range values.
5951 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5952 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5953 * font.c (Ffont_variation_glyphs):
5954 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5955 * lisp.h: Include <intprops.h>.
5956 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5957 (cons_to_signed, cons_to_unsigned): New decls.
5958 (long_to_cons, cons_to_long): Remove decls.
5959 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5960 (Fprimitive_undo): Use CONS_TO_INTEGER.
5961 * xfns.c (Fx_window_property): Likewise.
5962 * xselect.c: Include <limits.h>.
5963 (x_own_selection, selection_data_to_lisp_data):
5964 Use INTEGER_TO_CONS.
5965 (x_handle_selection_request, x_handle_selection_clear)
5966 (x_get_foreign_selection, Fx_disown_selection_internal)
5967 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5968 (lisp_data_to_selection_data): Use cons_to_unsigned.
5969 (x_fill_property_data): Use cons_to_signed.
5970 Report values out of range.
5971
d1f3d2af
PE
5972 Check for buffer and string overflow more precisely.
5973 * buffer.h (BUF_BYTES_MAX): New macro.
5974 * lisp.h (STRING_BYTES_MAX): New macro.
5975 * alloc.c (Fmake_string):
5976 * character.c (string_escape_byte8):
5977 * coding.c (coding_alloc_by_realloc):
5978 * doprnt.c (doprnt):
5979 * editfns.c (Fformat):
5980 * eval.c (verror):
5981 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5982 since they may not be the same number.
5983 * editfns.c (Finsert_char):
5984 * fileio.c (Finsert_file_contents):
5985 Likewise for BUF_BYTES_MAX.
5986
dd52fcea
PE
5987 * image.c: Use ptrdiff_t, not int, for sizes.
5988 (slurp_file): Switch from int to ptrdiff_t.
5989 All uses changed.
5990 (slurp_file): Check that file size fits in both size_t (for
5991 malloc) and ptrdiff_t (for sanity and safety).
5992
7f9bbdbb
PE
5993 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5994 if b->modtime has its maximal value.
5995
dfe18f82
PE
5996 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5997
84acfcf0
PE
5998 Don't assume time_t can fit into int.
5999 * buffer.h (struct buffer.modtime): Now time_t, not int.
6000 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6001 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6002
ccd9a01a
PE
6003 Minor fixes for signed vs unsigned integers.
6004 * character.h (MAYBE_UNIFY_CHAR):
6005 * charset.c (maybe_unify_char):
6006 * keyboard.c (read_char, reorder_modifiers):
6007 XINT -> XFASTINT, since the integer must be nonnegative.
6008 * ftfont.c (ftfont_spec_pattern):
6009 * keymap.c (access_keymap, silly_event_symbol_error):
6010 XUINT -> XFASTINT, since the integer must be nonnegative.
6011 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6012 since it makes no difference and we prefer signed.
6013 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6014 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6015 nonnegative.
6016
d6d100dd
SM
60172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6018
6019 * window.h (Fwindow_frame): Declare.
6020
2b6148e4
PE
60212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6024 (SPARE_MEMORY): Always define.
6025 (LARGE_REQUEST): Remove.
6026 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6027
f230ecc9
MR
60282011-06-06 Martin Rudalics <rudalics@gmx.at>
6029
727e958e
MR
6030 * lisp.h: Move EXFUNS for Fframe_root_window,
6031 Fframe_first_window and Fset_frame_selected_window to window.h.
6032
6033 * window.h: Move EXFUNS for Fframe_root_window,
6034 Fframe_first_window and Fset_frame_selected_window here from
6035 lisp.h.
6036
6037 * frame.c (Fwindow_frame, Fframe_first_window)
6038 (Fframe_root_window, Fframe_selected_window)
6039 (Fset_frame_selected_window): Move to window.c.
6040 (Factive_minibuffer_window): Move to minibuf.c.
6041 (Fother_visible_frames_p): New function.
6042
6043 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6044
f230ecc9
MR
6045 * window.c (decode_window, decode_any_window): Move up in code.
6046 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6047 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6048 (Fwindow_buffer): Move up and rewrite doc-string.
6049 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6050 (Fwindow_prev): New functions.
727e958e
MR
6051 (Fwindow_frame): Move here from frame.c. Accept any window as
6052 argument.
6053 (Fframe_root_window, Fframe_first_window)
6054 (Fframe_selected_window): Move here from frame.c. Accept frame
6055 or arbitrary window as argument. Update doc-strings.
6056 (Fminibuffer_window): Move up in code.
6057 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6058 (Fset_frame_selected_window): Move here from frame.c.
6059 Marginal rewrite.
727e958e
MR
6060 (Fselected_window, select_window, Fselect_window): Move up in
6061 code. Minor doc-string fixes.
f230ecc9 6062
4d09bcf6
PE
60632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6066 Do not assume that spare memory exists; that assumption is valid
6067 only if SYSTEM_MALLOC.
6068 (LARGE_REQUEST): New macro, so that the issue of large requests
6069 is separated from the issue of spare memory.
6070
810928a2
AS
60712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6072
172418ad
AS
6073 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6074 format. (Bug#8806)
6075
43f862f7
AS
6076 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6077
810928a2
AS
6078 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6079 before statements.
6080
a059fe24
JD
60812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6082
6083 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6084
6085 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6086
6087 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6088 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6089
989bf368
JB
60902011-06-05 Juanma Barranquero <lekktu@gmail.com>
6091
6092 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6093
4b80f674
CY
60942011-06-04 Chong Yidong <cyd@stupidchicken.com>
6095
6096 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6097 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6098 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6099 New error handlers.
4b80f674
CY
6100 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6101 Obey Vx_select_enable_clipboard_manager. Catch errors in
6102 x_clipboard_manager_save (Bug#8779).
6103 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6104 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6105
99a33b77 61062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6107
6108 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6109
99a33b77 61102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6111
6112 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6113 in the current matrix if keep_current_p is non-zero.
6114
8264569d
EZ
61152011-06-04 Eli Zaretskii <eliz@gnu.org>
6116
6117 * bidi.c (bidi_level_of_next_char): Fix last change.
6118
57f97249
EZ
61192011-06-03 Eli Zaretskii <eliz@gnu.org>
6120
fec2107c 6121 Support bidi reordering of text covered by display properties.
57f97249 6122
fec2107c
EZ
6123 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6124 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6125 (bidi_cache_search, bidi_cache_iterator_state)
6126 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6127 (bidi_level_of_next_char, bidi_move_to_visually_next):
6128 Support character positions inside a run of characters covered by a
fec2107c
EZ
6129 display string.
6130 (bidi_paragraph_init, bidi_resolve_explicit_1)
6131 (bidi_level_of_next_char): Call bidi_fetch_char and
6132 bidi_fetch_char_advance instead of FETCH_CHAR and
6133 FETCH_CHAR_ADVANCE.
6134 (bidi_init_it): Initialize new members.
6135 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6136 definitions.
6137 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6138 instead of using explicit *_CHAR codes.
d6d100dd
SM
6139 (bidi_resolve_explicit, bidi_resolve_weak):
6140 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6141 bidirectional text is supported only in multibyte buffers.
6142 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6143 it to initialize the frame_window_p member of struct bidi_it.
6144 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6145 (bidi_resolve_explicit, bidi_resolve_weak)
6146 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6147 bidi_it->nchars is non-positive.
6148 (bidi_level_of_next_char): Don't try to lookup the cache for the
6149 next/previous character if nothing is cached there yet, or if we
6150 were just reseat()'ed to a new position.
c40e2fb2 6151
0e14fe90
EZ
6152 * xdisp.c (set_cursor_from_row): Set start and stop points
6153 according to the row's direction when priming the loop that looks
6154 for the glyph on which to display cursor.
6155 (single_display_spec_intangible_p): Function deleted.
6156 (display_prop_intangible_p): Reimplement to call
6157 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6158 Accept 3 additional arguments needed by handle_display_spec.
6159 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6160 values: lists, `(when COND...)' forms, etc.
6161 (single_display_spec_string_p): Support property values that are
6162 lists with the argument STRING its top-level element.
6163 (display_prop_string_p): Fix the condition for processing a
6164 property that is a list to be consistent with handle_display_spec.
fec2107c 6165 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6166 last portion of handle_display_prop.
6167 (compute_display_string_pos): Accept additional argument
6168 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6169 value of a `display' property is a "replacing spec".
6170 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6171 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6172 the display property, but just return a value indicating whether
6173 the display property will replace the characters it covers.
6174 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6175 frame_window_p members of struct bidi_it.
d6d100dd
SM
6176 (compute_display_string_pos, compute_display_string_end):
6177 New functions.
fec2107c
EZ
6178 (push_it): Accept second argument POSITION, where pop_it should
6179 jump to continue iteration.
6180 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6181
fec2107c
EZ
6182 * keyboard.c (adjust_point_for_property): Adjust the call to
6183 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6184
6185 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6186 (bidi_init_it): Update prototypes.
6187 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6188 (compute_display_string_pos, compute_display_string_end):
6189 Declare prototypes.
fec2107c
EZ
6190 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6191 EMACS_INT.
fc6f18ce 6192
40087514 61932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6194
57f53182
PE
6195 Malloc failure behavior now depends on size of allocation.
6196 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6197 * lisp.h: Change signatures accordingly.
6198 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6199 All callers changed. (Bug#8762)
6200
6201 * gnutls.c: Use Emacs's memory allocators.
6202 Without this change, the gnutls library would invoke malloc etc.
6203 directly, which causes problems on non-SYNC_INPUT hosts, and which
6204 runs afoul of improving memory_full behavior. (Bug#8761)
6205 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6206 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6207 xfree instead of the default malloc, realloc, free.
6208 (Fgnutls_boot): No need to check for memory allocation failure,
6209 since xmalloc does that for us.
6210
ac32cd99 6211 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6212 * category.c (hash_get_category_set):
6213 * ccl.c (ccl_driver):
6214 * charset.c (Fdefine_charset_internal):
6215 * charset.h (struct charset.hash_index):
6216 * composite.c (get_composition_id, gstring_lookup_cache)
6217 (composition_gstring_put_cache):
6218 * composite.h (struct composition.hash_index):
6219 * dispextern.h (struct image.hash):
6220 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6221 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6222 (hashfn_equal, hashfn_user_defined, make_hash_table)
6223 (maybe_resize_hash_table, hash_lookup, hash_put)
6224 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6225 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6226 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6227 * image.c (make_image, search_image_cache, lookup_image)
6228 (xpm_put_color_table_h):
6229 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6230 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6231 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6232 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6233 * alloc.c (allocate_vectorlike):
6234 Check for overflow in vector size calculations.
6235 * ccl.c (ccl_driver):
6236 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6237 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6238 need to be updated by these changes.
40087514
PE
6239 * fns.c (make_hash_table, maybe_resize_hash_table):
6240 Check for integer overflow with large hash tables.
0de4bb68
PE
6241 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6242 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6243 (SXHASH_REDUCE): New macro.
6244 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6245 Use it instead of discarding useful hash info with large hash values.
6246 (sxhash_float): New function.
6247 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6248 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6249 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6250 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6251 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6252 Adjust signatures to match updated version of code.
6253 (consing_since_gc): Now EMACS_INT, since a single hash table can
6254 use more than INT_MAX bytes.
6255
698d32e2
DN
62562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6257
6258 Make it possible to build with GCC-4.6+ -O2 -flto.
6259
6260 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6261
fd6fa53f
SM
62622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6263
6264 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6265 Call minibuffer-inactive-mode.
6266
864db017
JB
62672011-05-31 Juanma Barranquero <lekktu@gmail.com>
6268
6269 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6270 Update dependencies.
6271
2ad0baf4
DN
62722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6273
6274 * data.c (init_data): Remove code for UTS, this system is not
6275 supported anymore.
6276
4fcc2638
DN
62772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6278
6279 Don't force ./temacs to start in terminal mode.
6280
6281 * frame.c (make_initial_frame): Initialize faces in all cases, not
6282 only when CANNOT_DUMP is defined.
6283 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6284
c56e0fd5
DN
62852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6286
6287 * dispnew.c (add_window_display_history): Use const for the string
6288 pointer. Remove declaration, not needed.
6289
333d54da 62902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6291
55d4c1b2 6292 Use 'inline', not 'INLINE'.
333d54da 6293 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6294 * alloc.c, fontset.c (INLINE): Remove.
6295 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6296 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6297 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6298 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6299 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6300
738db178
DN
63012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6302
6303 Make it possible to run ./temacs.
6304
6305 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6306 syms_of_callproc does the same thing. Remove test for
6307 "initialized", do it in the caller.
6308 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6309
620c53a6
SM
63102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6311
6312 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6313 (read_minibuf): Use get_minibuffer.
6314 (syms_of_minibuf): Use DEFSYM.
6315 (Qmetadata): New var.
6316 * data.c (Qbuffer): Don't make it static.
6317 (syms_of_data): Use DEFSYM.
6318
e003a292
PE
63192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6320
6321 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6322 (CCL_CODE_MIN): New macro.
6323
ed008a6d
PE
63242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6325
3687c2ef
PE
6326 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6327
ed008a6d
PE
6328 * eval.c (Qdebug): Now static.
6329 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6330 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6331 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6332
d66c4c7c
CY
63332011-05-29 Chong Yidong <cyd@stupidchicken.com>
6334
6335 * image.c: Various fixes to ImageMagick code comments.
6336 (Fimagemagick_types): Doc fix.
6337
5fbc2025
PE
63382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6339
0196f88a
PE
6340 Minor fixes prompted by GCC 4.6.0 warnings.
6341
6342 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6343
5fbc2025
PE
6344 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6345 (x_clipboard_manager_save_all): Move extern decl to ...
6346 * xterm.h: ... here, so that it can be checked for consistency.
6347
1dd3c2d9
CY
63482011-05-29 Chong Yidong <cyd@stupidchicken.com>
6349
6350 * xselect.c (x_clipboard_manager_save_frame)
6351 (x_clipboard_manager_save_all): New functions.
6352 (Fx_clipboard_manager_save): Lisp function deleted.
6353
6354 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6355 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6356
6357 * xterm.h: Update prototype.
6358
5ba6571d
WX
63592011-05-28 William Xu <william.xwl@gmail.com>
6360
6361 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6362 exiting (Bug#8239).
6363
3eaff834
JM
63642011-05-28 Jim Meyering <meyering@redhat.com>
6365
e1900994 6366 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6367 * fns.c (to_uchar): Define.
6368 (crypto_hash_function): Use it to convert some newly-signed
6369 variables to unsigned, to avoid sign-extension bugs. For example,
6370 without this change, (md5 "truc") would evaluate to
6371 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6372 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6373 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6374
0f6990a7
PE
63752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6376
6377 Integer overflow fixes.
c8a9ca5a 6378
08686060
PE
6379 * dbusbind.c: Serial number integer overflow fixes.
6380 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6381 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6382 to hold a serial number that is too large for a fixnum.
6383 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6384 Check for serial numbers out of range. Decode any serial number
59568bf0 6385 that was so large that it became a float. (Bug#8722)
08686060 6386
2d1fc3c7
PE
6387 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6388 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6389 Use XFASTINT rather than XUINT when numbers are nonnegative.
6390 (xd_append_arg, Fdbus_method_return_internal):
6391 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6392 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6393 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6394 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6395 (Bug#8722)
2d1fc3c7 6396
c8a9ca5a
PE
6397 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6398
519e1d69
PE
6399 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6400
6df6ae42 6401 ccl: Add integer overflow checks.
30569699
PE
6402 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6403 (IN_INT_RANGE): New macros.
6404 (ccl_driver): Use them to check for integer overflow when
6405 decoding a CCL program. Many of the new checks are whether XINT (x)
6406 fits in int; it doesn't always, on 64-bit hosts. The new version
6407 doesn't catch all possible integer overflows, but it's an
847044ea 6408 improvement. (Bug#8719)
30569699 6409
c11285dc
PE
6410 * alloc.c (make_event_array): Use XINT, not XUINT.
6411 There's no need for unsigned here.
6412
fdccd48e
PE
6413 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6414 This follows up to the 2011-05-06 change that substituted uintptr_t
6415 for EMACS_INT. This case wasn't caught back then.
6416
37910ab2
PE
6417 Rework Fformat to avoid integer overflow issues.
6418 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6419 now (part of C89). Include <verify.h>.
6420 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6421 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6422 (Fformat): Avoid the prepass trying to compute sizes; it was only
6423 approximate and thus did not catch overflow reliably. Instead, walk
6424 through the format just once, formatting and computing sizes as we go,
6425 checking for integer overflow at every step, and allocating a larger
6426 buffer as needed. Keep track separately whether the format is
6427 multibyte. Keep only the most-recently calculated precision, rather
6428 than them all. Record whether each argument has been converted to
6429 string. Use EMACS_INT, not int, for byte and char and arg counts.
6430 Support field widths and precisions larger than INT_MAX. Avoid
6431 sprintf's undefined behavior with conversion specifications such as %#d
6432 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6433 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6434 formatting out-of-range floating point numbers with int
9173deec 6435 formats. (Bug#8668)
37910ab2 6436
2e6578fb
PE
6437 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6438
0ae6bdee
PE
6439 * data.c: Avoid integer truncation in expressions involving floats.
6440 * data.c: Include <intprops.h>.
6441 (arith_driver): When there's an integer overflow in an expression
6442 involving floating point, convert the integers to floating point
6443 so that the resulting value does not suffer from catastrophic
6444 integer truncation. For example, on a 64-bit host (* 4
6445 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6446 Do not rely on undefined behavior after integer overflow.
6447
de883a70
PE
6448 merge count_size_as_multibyte, parse_str_to_multibyte
6449 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6450 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6451 Check for integer overflow.
6452 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6453 since it's now a duplicate of the other. This is more of
6454 a character than a buffer op, so better that it's in character.c.
6455 * fns.c, print.c: Adjust to above changes.
6456
2ff916cb
PE
64572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6458
6459 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6460
f1b54466
PE
64612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6462
fb1ac845
PE
6463 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6464 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6465 (x_clipboard_manager_save): Now static.
6466 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6467
f1b54466
PE
6468 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6469 (crypto_hash_function): Now static.
6470 Fix pointer signedness problems. Avoid unnecessary initializations.
6471
a9f737ee
CY
64722011-05-27 Chong Yidong <cyd@stupidchicken.com>
6473
6474 * termhooks.h (Vselection_alist): Make it terminal-local.
6475
6476 * terminal.c (create_terminal): Initialize it.
6477
6478 * xselect.c: Support for clipboard managers.
6479 (Vselection_alist): Move to termhooks.h as terminal-local var.
6480 (LOCAL_SELECTION): New macro.
6481 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6482 (symbol_to_x_atom): Remove gratuitous arg.
6483 (x_handle_selection_request, lisp_data_to_selection_data)
6484 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6485 (x_own_selection, x_get_local_selection, x_convert_selection):
6486 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6487 (some_frame_on_display): Delete unused function.
6488 (Fx_own_selection_internal, Fx_get_selection_internal)
6489 (Fx_disown_selection_internal, Fx_selection_owner_p)
6490 (Fx_selection_exists_p): New optional frame arg.
6491 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6492 (x_handle_selection_clear): Don't treat other terminals with the
6493 same keyboard specially. Use the terminal-local Vselection_alist.
6494 (x_clear_frame_selections): Use Frun_hook_with_args.
6495
6496 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6497
6498 * xterm.h: Add support for those atoms.
6499
e067f0c1
CY
65002011-05-26 Chong Yidong <cyd@stupidchicken.com>
6501
6502 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6503 (converted_selections, conversion_fail_tag): New global variables.
6504 (x_selection_request_lisp_error): Free the above.
6505 (x_get_local_selection): Remove unnecessary code.
6506 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6507 of converted selections stored in converted_selections.
6508 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6509 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6510 (x_convert_selection): New function.
6511 (x_handle_selection_event): Simplify.
6512 (x_get_foreign_selection): Don't ignore incoming requests while
6513 waiting for an answer; this will fail when we implement
6514 SAVE_TARGETS, and seems unnecessary anyway.
6515 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6516 (Vx_sent_selection_functions): Doc fix.
6517
0f4aebc0
LL
65182011-05-26 Leo Liu <sdl.web@gmail.com>
6519
6520 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6521
e61124cd
YM
65222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6523
6524 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6525
6526 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6527 for fringe update if it has periodic bitmap.
ac389d0c 6528 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6529 and fringe_bitmap_periodic_p.
6530
6531 * fringe.c (get_fringe_bitmap_data): New function.
6532 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6533 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6534 row. Mark glyph row for fringe update if periodicity changed.
6535
6536 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6537 for fringe update unless it has periodic bitmap.
6538
f16d9837
KH
65392011-05-25 Kenichi Handa <handa@m17n.org>
6540
6541 * xdisp.c (get_next_display_element): Set correct it->face_id for
6542 a static composition.
6543
e1b90ef6
LL
65442011-05-24 Leo Liu <sdl.web@gmail.com>
6545
6546 * deps.mk (fns.o):
6547 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6548
6549 * fns.c (crypto_hash_function, Fsha1): New function.
6550 (Fmd5): Use crypto_hash_function.
6551 (syms_of_fns): Add Ssha1.
6552
7400048f
PE
65532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6554
6555 * gnutls.c: Remove unused macros.
6556 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6557 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6558 Remove macros that are defined and never used.
6559 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6560
abb71cf4
CY
65612011-05-22 Chong Yidong <cyd@stupidchicken.com>
6562
6563 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6564 (Fx_get_selection_internal): Minor cleanup.
6565 (Fx_own_selection_internal): Rename arguments for consistency with
6566 select.el.
6567
6307db39
PE
65682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6571
f3d4e0a4
CY
65722011-05-22 Chong Yidong <cyd@stupidchicken.com>
6573
6574 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6575
4d8ade89
YM
65762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6577
6578 * dispnew.c (scrolling_window): Don't exclude the case that the
6579 last enabled row in the desired matrix touches the bottom boundary.
6580
32078c8d
GM
65812011-05-21 Glenn Morris <rgm@gnu.org>
6582
6583 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6584 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6585 and add some more files.
32078c8d 6586
7285dc67
EZ
65872011-05-20 Eli Zaretskii <eliz@gnu.org>
6588
6589 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6590 report_file_error introduced by the change from 2011-05-07.
6591
89d1bd22
PE
65922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6593
6594 * systime.h (Time): Define only if emacs is defined.
6595 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6596 where the include path doesn't have X11/X.h by default. See
6597 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6598
cd394be1 65992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6600
6601 * composite.c (find_automatic_composition): Fix previous change.
6602
b9704ad9
GM
66032011-05-20 Glenn Morris <rgm@gnu.org>
6604
6605 * lisp.mk: New file, split from Makefile.in.
6606 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6607 (shortlisp): Remove.
6608 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6609
4a720484
GM
66102011-05-19 Glenn Morris <rgm@gnu.org>
6611
6612 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6613 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6614 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6615 (lisp): Set the order to that of loadup.el.
6616 (shortlisp): Make it a copy of $lisp.
6617 (SOME_MACHINE_LISP): Remove.
6618 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6619 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6620
a28d4396
KH
66212011-05-18 Kenichi Handa <handa@m17n.org>
6622
6623 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6624 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6625 (find_automatic_composition): Mostly rewrite for efficiency.
6626
a2b1fa8e
JB
66272011-05-18 Juanma Barranquero <lekktu@gmail.com>
6628
6629 * makefile.w32-in: Update dependencies.
6630
8e1f5610
CS
66312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6632
6633 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6634 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6635
7025ee00 66362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6637
cdfa6eab
PE
6638 Fix some integer overflow issues, such as string length overflow.
6639
06d6db33
PE
6640 * insdel.c (count_size_as_multibyte): Check for string overflow.
6641
2b4560a8
PE
6642 * character.c (lisp_string_width): Check for string overflow.
6643 Use EMACS_INT, not int, for string indexes and lengths; in
6644 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6645 the resulting string length overflows an EMACS_INT; instead,
6646 report a string overflow if no precision given. When checking for
6647 precision exhaustion, use a check that cannot possibly have
6648 integer overflow. (Bug#8675)
6649 * character.h (lisp_string_width): Adjust to new signature.
6650
cb93f9be
PE
6651 * alloc.c (string_overflow): New function.
6652 (Fmake_string): Use it. This doesn't change behavior, but saves
6653 a few bytes and will simplify future changes.
6654 * character.c (string_escape_byte8): Likewise.
6655 * lisp.h (string_overflow): New decl.
6656
1a1f3366
PE
6657 Fixups, following up to the user-interface timestamp change.
6658 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6659 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6660 * msdos.c (mouse_get_pos): Likewise.
6661 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6662 * w32gui.h (Time): Define by including "systime.h" rather than by
6663 declaring it ourselves. (Bug#8664)
6664
d4e3e4d3
PE
6665 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6666 * image.c (clear_image_cache): Likewise.
6667
f6a24d19
PE
6668 * term.c (term_mouse_position): Don't assume time_t wraparound.
6669
08dc5ae6
PE
6670 Be more systematic about user-interface timestamps.
6671 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6672 and sometimes 'EMACS_UINT', to represent these timestamps.
6673 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6674 This makes the code easier to follow, and makes it easier to catch
6675 integer overflow bugs such as Bug#8664.
6676 * frame.c (Fmouse_position, Fmouse_pixel_position):
6677 Use Time, not unsigned long, for user-interface timestamps.
6678 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6679 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6680 * keyboard.h (last_event_timestamp): Likewise.
6681 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6682 * menu.h (xmenu_show): Likewise.
6683 * term.c (term_mouse_position): Likewise.
6684 * termhooks.h (struct input_event.timestamp): Likewise.
6685 (struct terminal.mouse_position_hook): Likewise.
6686 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6687 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6688 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6689 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6690 what it was before.
6691 * menu.h, termhooks.h: Include "systime.h", for Time.
6692
8e55734a
PE
6693 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6694 Don't assume that the difference between two unsigned long values
6695 can fit into an integer. At this point, we know button_down_time
6696 <= event->timestamp, so the difference must be nonnegative, so
6697 there's no need to cast the result if double-click-time is
6698 nonnegative, as it should be; check that it's nonnegative, just in
6699 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6700 apart (about 25 days). (Bug#8664)
8e55734a 6701
841f1b75 6702 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6703 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6704
3e26f69c
PE
6705 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6706 that always fit in int. Use a sentinel instead of a counter, to
6707 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6708 * frame.h (struct frame): Use int for menu_bar_items_used
6709 instead of EMACS_INT, since it always fits in int.
3e26f69c 6710
5cc152c0
PE
6711 * menu.c (grow_menu_items): Check for int overflow.
6712
d89eb65e
PE
6713 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6714
5235bd3e
PE
6715 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6716 Before, the code was not consistent. These values cannot exceed
6717 2**31 - 1 so there's no need to make them unsigned.
6718 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6719 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6720 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6721 as modifiers.
6722 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6723
bc827e23
PE
6724 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6725 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6726 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6727 presumably because the widths might not match.
6728
78eb494e
PE
6729 * window.c (size_window): Avoid needless test at loop start.
6730
04f2d78b
CB
67312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6732
6733 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6734
d2fc7e3d 67352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6736
6737 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6738
d2fc7e3d 67392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6740
6741 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6742 `width' to `bar_area_x' and `bar_area_width', respectively.
6743 (x_scroll_run): Take account of fringe background extension.
6744
04f2d78b
CB
6745 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6746 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6747 `bar_area_width', respectively.
6748 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6749 background extension.
6750
79b70037
GM
67512011-05-10 Jim Meyering <meyering@redhat.com>
6752
6753 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6754
2f142cc5
JB
67552011-05-10 Juanma Barranquero <lekktu@gmail.com>
6756
6757 * image.c (Finit_image_library): Return t for built-in image types,
6758 like pbm and xbm. (Bug#8640)
6759
57679c86
AS
67602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6761
6762 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6763
888c9e86
EZ
67642011-05-07 Eli Zaretskii <eliz@gnu.org>
6765
b0512a1d
EZ
6766 * w32console.c (Fset_screen_color): Doc fix.
6767 (Fget_screen_color): New function.
6768 (syms_of_ntterm): Defsubr it.
6769
7285dc67
EZ
6770 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6771 unlink the temporary file if Fcall_process didn't create it in the
6772 first place.
6773 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6774 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6775 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6776 cue to call_process_cleanup not to close that handle.
6777
4d3fcc8e
BK
67782011-05-07 Ben Key <bkey76@gmail.com>
6779
6780 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6781 one of two shell specific rules, either bootstrap-temacs-CMD or
6782 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6783 to the previous implementation of the bootstrap-temacs rule.
6784 The bootstrap-temacs-CMD rule is similar to the previous
6785 implementation of the bootstrap-temacs rule except that it
6786 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6787 variable.
6788
6789 These changes, along with some changes to nt/configure.bat,
6790 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6791 earlier fix to add support for --cflags and --ldflags options
6792 that include quotes so that it works whether make uses cmd or
6793 sh as the shell.
6794
b4289b64
MA
67952011-05-06 Michael Albinus <michael.albinus@gmx.de>
6796
6797 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6798 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6799 is a constant.
6800 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6801 a string. Handle both cases.
6802 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6803 (Fdbus_register_method): Use Qinvalid_function.
6804
af4c0e28
JB
68052011-05-06 Juanma Barranquero <lekktu@gmail.com>
6806
6807 * makefile.w32-in: Update dependencies.
6808 (LISP_H): Add inttypes.h and stdin.h.
6809 (PROCESS_H): Add unistd.h.
6810
c51453d9
EZ
68112011-05-06 Eli Zaretskii <eliz@gnu.org>
6812
6813 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6814 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6815
8ff0ac3c 68162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6817
4c4b566b
PE
6818 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6819
aab2b9b5
PE
6820 * term.c (vfatal): Remove stray call to va_end.
6821 It's not needed and the C Standard doesn't allow it here anyway.
6822
c378da0b
PE
6823 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6824 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6825
288b08c7
PE
6826 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6827 bytes.
6828
e3601888
PE
6829 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6830
db6c0e74
PE
6831 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6832
dd5963ea
PE
6833 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6834
88c9450f
PE
6835 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6836
2f9442b8
PE
6837 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6838
c032b5f8
PE
6839 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6840 * charset.c (Fdefine_charset_internal): Don't initialize
6841 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6842 32-bit int (Bug#8600).
a108c10b
PE
6843
6844 * lread.c (read_integer): Be more consistent with string-to-number.
6845 Use string_to_number to do the actual conversion; this avoids
6846 rounding errors and fixes some other screwups. Without this fix,
6847 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6848 (digit_to_number): Move earlier, for benefit of read_integer.
6849 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6850 not a digit in any supported base. (Bug#8602)
a108c10b 6851
ad5f9eea
PE
6852 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6853
aec1708a
PE
6854 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6855 to match comment at start of function. This also removes a
6856 GCC warning about overflow in a 32+64-bit port.
6857
47be4ab5
PE
6858 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6859
371cac43
PE
6860 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6861 Reported by Stefan Monnier in
6862 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6863 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6864 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6865
d01a7826
PE
6866 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6867 (EMACS_UINTPTR): Likewise, with uintptr_t.
6868
7fd47d5c
PE
6869 * lisp.h: Prefer 64-bit EMACS_INT if available.
6870 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6871 on 32-bit hosts that have 64-bit int, so that they can access
6872 large files.
122b0c86
PE
6873 However, temporarily disable this change unless the temporary
6874 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6875
8727937b
PE
6876 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6877
8ac068ac
PE
6878 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6879 This removes an assumption that EMACS_INT and long are the same
6880 width as pointers. The assumption is true for Emacs porting targets
6881 now, but we want to make other targets possible.
6882 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6883 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6884 In the rest of the code, change types of integers that hold casted
6885 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6886 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6887 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6888 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6889 No need to cast type when ORing.
6890 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6891 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6892 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6893 assume EMACS_INT is the same width as char *.
6894 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6895 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6896 Remove no-longer-needed casts.
6897 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6898 (xg_tool_bar_help_callback, xg_make_tool_item):
6899 Use EMACS_INTPTR to hold an integer
6900 that will be cast to void *; this can avoid a GCC warning
6901 if EMACS_INT is not the same width as void *.
6902 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6903 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6904 (current_message_1, set_message_1):
6905 Use a local to convert to proper width without a cast.
6906 * xmenu.c (dialog_selection_callback): Likewise.
6907
ede49d71
PE
6908 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6909 Also, don't assume VALBITS / RAND_BITS is less than 5,
6910 and don't rely on undefined behavior when shifting a 1 left into
6911 the sign bit.
6912 * lisp.h (get_random): Change signature to match.
6913
2f30ecd0
PE
6914 * lread.c (hash_string): Use size_t, not int, for hash computation.
6915 Normally we prefer signed values; but hashing is special, because
6916 it's better to use unsigned division on hash table sizes so that
6917 the remainder is nonnegative. Also, size_t is the natural width
6918 for hashing into memory. The previous code used 'int', which doesn't
6919 retain enough info to hash well into very large tables.
6920 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6921
2a866e7b
PE
6922 * dbusbind.c: Don't possibly lose pointer info when converting.
6923 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6924 Use XPNTR rather than XHASH, so that the high-order bits of
6925 the pointer aren't lost when converting through void *.
6926
51639eac
PE
6927 * eval.c (Fautoload): Don't double-shift a pointer.
6928
92394119
PE
6929 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6930
dbdb9a7c
JB
69312011-05-06 Juanma Barranquero <lekktu@gmail.com>
6932
6933 * gnutls.c (DEF_GNUTLS_FN):
6934 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6935
db7a0b4f
AS
69362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6937
6938 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6939 marker. (Bug#8610)
6940
cd394be1 69412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6942
6943 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6944 New version that can reserve upto 2GB of heap space.
6945
f7ff1b0f 69462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6947
6948 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6949
639c109b
TZ
69502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6951
6952 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6953 `gnutls_certificate_set_x509_key_file'.
6954
d2127135
JB
69552011-05-05 Juanma Barranquero <lekktu@gmail.com>
6956
6957 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6958 Update dependencies.
6959
e968f4f3
JB
69602011-05-04 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6963 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6964 Remove unused parameter `fildes'.
6965 * process.c (read_process_output, send_process): Don't pass it.
6966
84d358f0
JB
69672011-05-04 Juanma Barranquero <lekktu@gmail.com>
6968
6969 Fix previous change: the library cache is defined in w32.c.
6970 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6971 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6972
0898ca10
JB
69732011-05-04 Juanma Barranquero <lekktu@gmail.com>
6974
6975 Implement dynamic loading of GnuTLS on Windows.
6976
6977 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6978 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6979 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6980 Declare.
6981
6982 * gnutls.c (Qgnutls_dll): Define.
6983 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6984 (gnutls_*): Declare function pointers.
6985 (init_gnutls_functions): New function to initialize function pointers.
6986 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6987 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6988 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6989 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6990 (emacs_gnutls_write, emacs_gnutls_read)
6991 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6992 (Fgnutls_available_p): New function.
6993 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6994 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6995 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6996
6997 * image.c: Include w32.h.
6998 (Vimage_type_cache): Delete.
6999 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7000 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7001 (w32_delayed_load): Move to w32.c.
7002
7003 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7004
7005 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7006 (w32_delayed_load): Move from image.c. When loading a library, record
7007 its filename in the :loaded-from property of the library id.
7008 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7009 Initialize and staticpro them.
7010 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7011
7012 * process.c: Include lisp.h before w32.h, not after.
7013 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7014 instead of gnutls_record_check_pending.
7015
7016 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7017
ff4de4aa
TZ
70182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7019
7020 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7021 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7022 as passed in.
7023
abe95abb
JD
70242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7025
7026 * xterm.c (x_set_frame_alpha): Do not set property on anything
7027 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7028
e16e55d4
JB
70292011-05-02 Juanma Barranquero <lekktu@gmail.com>
7030
7031 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7032
bafcf6a5
JB
70332011-05-02 Juanma Barranquero <lekktu@gmail.com>
7034
7035 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7036 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7037 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7038 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7039 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7040 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7041 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7042 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7043 (Qgnutls_bootprop_callbacks_verify): Make static.
7044
e7a6747f
AS
70452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7046
19ed11ba
AS
7047 * callproc.c: Indentation fixup.
7048
e7a6747f 7049 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7050 (wait_for_termination, interruptible_wait_for_termination):
7051 Move after wait_for_termination_1.
e7a6747f 7052
1ef14cb4
LMI
70532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7054
7055 * sysdep.c (interruptible_wait_for_termination): New function
7056 which is like wait_for_termination, but allows keyboard
7057 interruptions.
7058
7059 * callproc.c (Fcall_process): Add (:file "file") as an option for
7060 the STDOUT buffer.
7061 (Fcall_process_region): Ditto.
7062
330d880c
EZ
70632011-04-30 Eli Zaretskii <eliz@gnu.org>
7064
8db90b73
EZ
7065 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7066 rather than `XVECTOR (FOO)->size'.
7067
330d880c
EZ
7068 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7069 inttypes.h, as a gnulib replacement is used if it not available in
7070 system headers.
7071
15cbd324
EZ
70722011-04-21 Eli Zaretskii <eliz@gnu.org>
7073
7074 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7075 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7076 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7077
7078 * coding.c (coding_alloc_by_realloc): Error out if destination
7079 will grow beyond MOST_POSITIVE_FIXNUM.
7080 (decode_coding_emacs_mule): Abort if there isn't enough place in
7081 charbuf for the composition carryover bytes. Reserve an extra
7082 space for up to 2 characters produced in a loop.
7083 (decode_coding_iso_2022): Abort if there isn't enough place in
7084 charbuf for the composition carryover bytes.
7085
70862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7087
ae940cca
EZ
7088 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7089 aborting when %lld or %lll format is passed.
7090 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7091 %llo or %llx format is passed. (Bug#8545)
7092
03ab8921
EZ
7093 * window.c (window_scroll_line_based): Use a marker instead of
7094 simple variables to record original value of point. (Bug#7952)
7095
afda1437
EZ
7096 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7097 produced by %s or %c overflows available buffer space. (Bug#8545)
7098
f76dee0c
PE
70992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7100
7101 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7102 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7103
fdc5744d
JB
71042011-04-28 Juanma Barranquero <lekktu@gmail.com>
7105
7106 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7107
638f053a
JB
71082011-04-28 Juanma Barranquero <lekktu@gmail.com>
7109
7110 * keyboard.c (Qdelayed_warnings_hook): Define.
7111 (command_loop_1): Run `delayed-warnings-hook'
7112 if Vdelayed_warnings_list is non-nil.
7113 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7114 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7115
d178f871
EZ
71162011-04-28 Eli Zaretskii <eliz@gnu.org>
7117
7118 * doprnt.c (doprnt): Don't return value smaller than the buffer
7119 size if the message was truncated. (Bug#8545).
7120
b124fd93
JB
71212011-04-28 Juanma Barranquero <lekktu@gmail.com>
7122
7123 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7124 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7125
e810457d
PE
71262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7127
7128 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7129
ea51cceb
JB
71302011-04-27 Juanma Barranquero <lekktu@gmail.com>
7131
7132 * makefile.w32-in: Update dependencies.
7133
94dcfacf
EZ
71342011-04-27 Eli Zaretskii <eliz@gnu.org>
7135
7136 Improve `doprnt' and its usage. (Bug#8545)
7137 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7138 `format_end'. Remove support for %l as a conversion specifier.
7139 Don't use xrealloc. Improve diagnostics when the %l size modifier
7140 is used. Update the commentary.
7141
7142 * eval.c (verror): Simplify calculation of size_t.
7143
7144 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7145 messages.
7146
f61f41d7
PE
71472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7148
7149 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7150 change.
7151
96fb4434
PE
71522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7153
7154 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7155 This makes this file independent of the recent pseudovector change.
7156
671875da 71572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7158
69e9b5a3
PE
7159 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7160
b5f869a7 7161 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7162 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7163 Remove unused local.
c8926152 7164 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7165
841a1577 7166 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7167 GCC 4.6.0 optimizes based on type-based alias analysis.
7168 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7169 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7170 != &v->size, and therefore "v->size = 1; b->size = 2; return
7171 v->size;" must therefore return 1. This assumption is incorrect
7172 for Emacs, since it type-puns struct Lisp_Vector * with many other
7173 types. To fix this problem, this patch adds a new type struct
f904488f 7174 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7175 and pseudovectors, and helps optimizing compilers not get fooled
7176 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7177 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7178 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7179 the size member.
eab3844f
PE
7180 (XSETPVECTYPE): Rewrite in terms of new macro.
7181 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7182 This is a bit clearer, and further avoids the possibility of
7183 undesirable aliasing.
7184 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7185 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7186 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7187 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7188 (ASIZE): Now uses header.size rather than size.
7189 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7190 to avoid the hassle of writing XVECTOR (foo)->header.size.
7191 (struct vectorlike_header): New type.
eab3844f
PE
7192 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7193 object, to help avoid aliasing.
7194 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7195 (SUBRP): Likewise, since Lisp_Subr is a special case.
7196 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7197 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7198 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7199 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7200 changed to be "header.size" and "header.next".
7201 * buffer.h (struct buffer): Likewise.
7202 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7203 * frame.h (struct frame): Likewise.
7204 * process.h (struct Lisp_Process): Likewise.
7205 * termhooks.h (struct terminal): Likewise.
7206 * window.c (struct save_window_data, struct saved_window): Likewise.
7207 * window.h (struct window): Likewise.
7208 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7209 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7210 * buffer.c (init_buffer_once): Likewise.
7211 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7212 special case.
7213 * process.c (Fformat_network_address): Use local var for size,
7214 for brevity.
7215
0df1eac5
PE
7216 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7217
847ab9d1 7218 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7219 * data.c (atof): Remove decl; no longer used or needed.
7220 (digit_to_number): Move to lread.c.
7221 (Fstring_to_number): Use new string_to_number function, to be
7222 consistent with how the Lisp reader treats infinities and NaNs.
7223 Do not assume that floating-point numbers represent EMACS_INT
7224 without losing information; this is not true on most 64-bit hosts.
7225 Avoid double-rounding errors, by insisting on integers when
7226 parsing non-base-10 numbers, as the documentation specifies.
7227 * lisp.h (string_to_number): New decl, replacing ...
7228 (isfloat_string): Remove.
bc0a5c13 7229 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7230 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7231 appears to have been a coding error. Similarly, do not accept
7232 strings like +-1e0 as floating point numbers. Do not report
7233 overflow for integer overflows unless the base is not 10 which
7234 means we have no simple and reliable way to continue.
7235 Break out the floating-point parsing into a new
7236 function string_to_number, so that Fstring_to_number parses
7237 floating point numbers consistently with the Lisp reader.
04f2d78b 7238 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7239 (E_CHAR, EXP_INT): Remove, replacing with ...
7240 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7241 (string_to_number): New function, replacing isfloat_string.
7242 This function checks for valid syntax and produces the resulting
7243 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7244 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7245 so that overflow for non-base-10 numbers is reported only when
7246 there's no portable and simple way to convert to floating point.
452f4150 7247
67769ffc
PE
7248 * textprop.c (set_text_properties_1): Rewrite for clarity,
7249 and to avoid GCC warning about integer overflow.
7250
c20db43f
PE
7251 * intervals.h (struct interval): Use EMACS_INT for members
7252 where EMACS_UINT might cause problems. See
7253 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7254 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7255 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7256 All uses changed.
37aa2f85
PE
7257 (offset_intervals): Tell GCC not to worry about length overflow
7258 when negating a negative length.
c20db43f 7259
2538aa2f
PE
7260 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7261 (overrun_check_free): Likewise.
7262
f2d3008d
PE
7263 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7264 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7265 word size.
7266
ec8df744
PE
7267 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7268 (gnutls_make_error): Rename local to avoid shadowing.
7269 (gnutls_emacs_global_deinit): ifdef out; not used.
7270 (Fgnutls_boot): Use const for pointer to readonly storage.
7271 Comment out unused local. Fix pointer signedness problems.
7272
640ee02d
PE
7273 * lread.c (openp): Don't stuff size_t into an 'int'.
7274 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7275 about possible signed overflow.
7276
6048fb2a
PE
7277 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7278 (GDK_KEY_g): Don't define if already defined.
7279 (xg_prepare_tooltip): Avoid pointer signedness problem.
7280 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7281
fa3c87e1
PE
7282 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7283 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7284
2172544b
PE
7285 * xfns.c (Fx_window_property): Simplify a bit,
7286 to make a bit faster and to avoid GCC 4.6.0 warning.
7287 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7288
9b821a21
PE
7289 * fns.c (internal_equal): Don't assume size_t fits in int.
7290
3c616cfa
PE
7291 * alloc.c (compact_small_strings): Tighten assertion a little.
7292
c2982e87
PE
7293 Replace pEd with more-general pI, and fix some printf arg casts.
7294 * lisp.h (pI): New macro, generalizing old pEd macro to other
7295 conversion specifiers. For example, use "...%"pI"d..." rather
7296 than "...%"pEd"...".
7297 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7298 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7299 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7300 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7301 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7302 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7303 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7304 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7305 64-bit hosts.
7306 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7307 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7308 * print.c (safe_debug_print, print_object): Likewise.
7309 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7310 to int.
6f04d126
PE
7311 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7312 avoiding the 0 flag, which is not portable.
c2982e87
PE
7313 * process.c (Fmake_network_process): Use pI to avoid cast.
7314 * region-cache.c (pp_cache): Likewise.
7315 * xdisp.c (decode_mode_spec): Likewise.
7316 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7317 behavior on 64-bit hosts with printf arg.
6f04d126 7318 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7319 (x_stop_queuing_selection_requests): Likewise.
7320 (x_get_window_property): Don't truncate byte count to an 'int'
7321 when tracing.
0b432f21 7322
5e073ec7
PE
7323 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7324 here, since it parses constructs like leading '-' and spaces,
7325 which are not wanted; and it overflows with large numbers.
7326 Instead, simply match F[0-9]+, which is what is wanted anyway.
7327
36372bf9
PE
7328 * alloc.c: Remove unportable assumptions about struct layout.
7329 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7330 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7331 (allocate_vectorlike, make_pure_vector): Use the new macros,
7332 plus offsetof, to remove unportable assumptions about struct layout.
7333 These assumptions hold on all porting targets that I know of, but
7334 they are not guaranteed, they're easy to remove, and removing them
7335 makes further changes easier.
7336
0b432f21
PE
7337 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7338 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7339 (string_overrun_cookie): Now const. Use initializers that
7340 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7341 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7342 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7343 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7344 multiple of sizeof (EMACS_INT); it need not be, if
7345 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7346 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7347
895009e1
JB
73482011-04-26 Juanma Barranquero <lekktu@gmail.com>
7349
7350 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7351
6a7a1b0b
TZ
73522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7353
7354 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7355 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7356 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7357
841a1577 73582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7359
7360 * lisp.h (Qdebug): List symbol.
895009e1 7361 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7362 * keyboard.c (debug-on-event): New variable.
7363 (handle_user_signal): Break into debugger when debug-on-event
7364 matches the current signal symbol.
7365
f2d3ba6f
DN
73662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7367
7368 * alloc.c (check_sblock, check_string_bytes)
7369 (check_string_free_list): Convert to standard C.
7370
42ce4c63
TZ
73712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7372
7373 * w32.c (emacs_gnutls_push): Fix typo.
7374
825cd63c
EZ
73752011-04-25 Eli Zaretskii <eliz@gnu.org>
7376
fb11d64d
EZ
7377 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7378 "cast to pointer from integer of different size".
7379
825cd63c
EZ
7380 Improve doprnt and its use in verror. (Bug#8545)
7381 * doprnt.c (doprnt): Document the set of format control sequences
7382 supported by the function. Use SAFE_ALLOCA instead of always
7383 using `alloca'.
7384
7385 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7386 is one byte too soon. Don't use xrealloc; instead xfree and
7387 xmalloc anew.
7388
e061a11b
TZ
73892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7390
7391 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7392 callbacks stage.
7393
7394 * gnutls.c: Renamed global_initialized to
7395 gnutls_global_initialized. Added internals for the
7396 :verify-hostname-error, :verify-error, and :verify-flags
7397 parameters of `gnutls-boot' and documented those parameters in the
7398 docstring. Start callback support.
9173deec
JB
7399 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7400 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7401 on error. Return error code.
e061a11b
TZ
7402 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7403 (emacs_gnutls_read): Likewise.
7404 (Fgnutls_boot): Return handshake error code.
7405 (emacs_gnutls_handle_error): New function.
7406 (wsaerror_to_errno): Likewise.
7407
7408 * w32.h (emacs_gnutls_pull): Add prototype.
7409 (emacs_gnutls_push): Likewise.
7410
7411 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7412 (emacs_gnutls_push): Likewise.
7413
74142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7415
7416 * process.c (wait_reading_process_output): Check if GnuTLS
7417 buffered some data internally if no FDs are set for TLS
7418 connections.
7419
7420 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7421 (LIBS): Link to USER_LIBS.
7422 ($(BLD)/gnutls.$(0)): New target.
7423
fa6996bc
EZ
74242011-04-24 Eli Zaretskii <eliz@gnu.org>
7425
eb35682e
EZ
7426 * xdisp.c (handle_single_display_spec): Rename the
7427 display_replaced_before_p argument into display_replaced_p, to
7428 make it consistent with the commentary. Fix typos in the
7429 commentary.
7430
e2ad650c
EZ
7431 * textprop.c (syms_of_textprop): Remove dead code.
7432 (copy_text_properties): Delete obsolete commentary about an
7433 interface that was deleted long ago. Fix typos in the description
7434 of arguments.
7435
1b2de274
EZ
7436 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7437 to changes in oldXMenu/XMenu.h from 2011-04-16.
7438 <menu_help_message, prev_menu_help_message>: Constify.
7439 (IT_menu_make_room): menu->help_text is now `const char **';
7440 adjust.
7441
7442 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7443 to changes in oldXMenu/XMenu.h from 2011-04-16.
7444 (struct XMenu): Declare `help_text' `const char **'.
7445
7446 * xfaces.c <Qunspecified>: Make extern again.
7447
7448 * syntax.c: Include sys/types.h before including regex.h, as
7449 required by Posix.
7450
762b15be
EZ
7451 * doc.c (get_doc_string): Improve the format passed to `error'.
7452
7453 * doprnt.c (doprnt): Improve commentary.
7454
7455 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7456
7457 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7458 them with etags.
7459
f1052e5d
EZ
7460 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7461 changes in globals.h immediately force recompilation.
762b15be
EZ
7462 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7463 $(CURDIR)/s/ms-w32.h.
7464 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7465
fa6996bc
EZ
7466 * character.c (Fchar_direction): Function deleted.
7467 (syms_of_character): Don't defsubr it.
7468 <char-direction-table>: Deleted.
7469
e6c3da20
EZ
74702011-04-23 Eli Zaretskii <eliz@gnu.org>
7471
7472 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7473 * doprnt.c: Include limits.h.
7474 (SIZE_MAX): New macro.
04f2d78b
CB
7475 (doprnt): Return a size_t value. 2nd arg is now size_t.
7476 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7477 Improve overflow protection. Support `l' modifier for integer
7478 conversions. Support %l conversion. Don't assume an EMACS_INT
7479 argument for integer conversions and for %c.
7480
7481 * lisp.h (doprnt): Restore prototype.
7482
7483 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7484 $(SRC)/character.h.
7485
7486 * Makefile.in (base_obj): Add back doprnt.o.
7487
7488 * deps.mk (doprnt.o): Add back prerequisites.
7489 (callint.o): Depend on character.h.
7490
7491 * eval.c (internal_lisp_condition_case): Include the handler
7492 representation in the error message.
7493 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7494 when breaking from the loop.
7495
7496 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7497
7498 * callint.c (Fcall_interactively): When displaying error message
7499 about invalid control letter, pass the character's codepoint, not
7500 a pointer to its multibyte form. Improve display of the character
7501 in octal and display also its hex code.
7502
7503 * character.c (char_string): Use %x to display the (unsigned)
7504 codepoint of an invalid character, to avoid displaying a bogus
7505 negative value.
7506
7507 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7508 `error', not SYMBOL_NAME itself.
7509
7510 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7511 character arguments to `error'.
7512
7513 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7514 to `error' in error message about FINAL_CHAR argument. Make sure
7515 FINAL_CHAR is a character, and use %c when it is passed as
7516 argument to `error'.
7517
4ffd0d6b 75182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7519
7520 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7521
7522 * w32.c: Include <time.h>.
7523 (sys_localtime): New function.
7524
4ffd0d6b 75252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7526
7527 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7528
4ffd0d6b 7529 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7530
4ffd0d6b 75312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7532
4ffd0d6b
GM
7533 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7534 zombies (Bug#8467).
aac0c6e3 7535
04c56954
EZ
75362011-04-19 Eli Zaretskii <eliz@gnu.org>
7537
7538 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7539 gl_state.e_property when gl_state.object is Qt.
7540
7541 * insdel.c (make_gap_larger): Remove limitation of buffer size
7542 to <= INT_MAX.
7543
16a43933
CY
75442011-04-18 Chong Yidong <cyd@stupidchicken.com>
7545
7546 * xdisp.c (lookup_glyphless_char_display)
7547 (produce_glyphless_glyph): Handle cons cell entry in
7548 glyphless-char-display.
7549 (Vglyphless_char_display): Document it.
7550
7551 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7552 glyphless-char-display.
7553
4581706e
CY
75542011-04-17 Chong Yidong <cyd@stupidchicken.com>
7555
7556 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7557
7558 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7559
7560 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7561 definition for no-X builds.
7562
4887c6e2 75632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7564
fd35b6f9
PE
7565 Static checks with GCC 4.6.0 and non-default toolkits.
7566
5c1ccb01
PE
7567 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7568
006c5daa
PE
7569 * process.c (keyboard_bit_set): Define only if SIGIO.
7570 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7571 (send_process): Repair possible setjmp clobbering.
7572
efc736d3
PE
7573 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7574
4e2fe2e6
PE
7575 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7576
f97334a2
PE
7577 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7578
4e75f29d
PE
7579 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7580 Define only if needed.
7581
90efadd1
PE
7582 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7583 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7584 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7585
3c647824
PE
7586 * dispextern.h (struct redisplay_interface): Rename param
7587 to avoid shadowing.
e264f262 7588 * termhooks.h (struct terminal): Likewise.
761383f4 7589 * xterm.c (xembed_send_message): Likewise.
3c647824 7590
b58c5c4a
PE
7591 * insdel.c (make_gap_smaller): Define only if
7592 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7593
cad59032
PE
7594 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7595 it.
7596
c339dc2e
PE
7597 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7598 so that we aren't warned about unused symbols.
7599
91a3e27b
PE
7600 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7601
399c71d3 7602 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7603
8ffc96f5
PE
7604 * xfns.c (x_real_positions): Mark locals as initialized.
7605
eef9bc79
PE
7606 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7607
098db9dd
PE
7608 * xterm.c: Fix problems found by static analysis with other toolkits.
7609 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7610 (x_dispatch_event): Declare static if USE_GTK, and
7611 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7612 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7613 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7614 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7615 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7616
eb18f6cc
PE
7617 * xmenu.c (menu_help_callback): Pointer type fixes.
7618 Use const pointers when pointing at readonly data. Avoid pointer
7619 signedness clashes.
7620 (FALSE): Remove unused macro.
7621 (update_frame_menubar): Remove unused decl.
7622
1fe72bf8
PE
7623 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7624
60d9e1db
PE
7625 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7626 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7627 (single_menu_item): Rename local to avoid shadowing.
7628
39261c26
PE
7629 * keyboard.c (make_lispy_event): Remove unused local var.
7630
018c5e19
PE
7631 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7632 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7633
63d2b86e
PE
7634 * bitmaps: Change bitmaps from unsigned char back to the X11
7635 compatible char. Avoid the old compiler warnings about
7636 out-of-range initializers by using, for example, '\xab' rather
7637 than 0xab.
7638
aefd87e1
PE
7639 * xgselect.c (xgselect_initialize): Check vs interface
7640 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7641
bf501fb9
PE
7642 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7643
e9829fdf
PE
7644 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7645 to read-only memory.
7646
1086c095
PE
7647 * fns.c (vector): Remove; this old hack is no longer needed.
7648
2baccd04 7649 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7650 Remove unused var.
dde42981 7651 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7652
72391843 7653 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7654
436c16df 7655 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7656 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7657 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7658
92bb796d 7659 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7660 (x_term_init): Remove local to avoid shadowing.
92bb796d 7661
764430a3 7662 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7663
7664 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7665 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7666
d1dfb56c
EZ
76672011-04-16 Eli Zaretskii <eliz@gnu.org>
7668
c4354cb4
EZ
7669 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7670
d1dfb56c
EZ
7671 Fix regex.c, syntax.c and friends for buffers > 2GB.
7672 * syntax.h (struct gl_state_s): Declare character position members
7673 EMACS_INT.
7674
7675 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7676
04f2d78b
CB
7677 * textprop.c (verify_interval_modification, interval_of):
7678 Declare arguments EMACS_INT.
d1dfb56c
EZ
7679
7680 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7681 EMACS_INT.
7682
7683 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7684
7685 * indent.c (Fvertical_motion): Local variable it_start is now
7686 EMACS_INT.
7687
7688 * regex.c (re_match, re_match_2, re_match_2_internal)
7689 (bcmp_translate, regcomp, regexec, print_double_string)
7690 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7691 (re_compile_pattern, re_exec): Declare arguments and local
7692 variables `size_t' and `ssize_t' and return values `regoff_t', as
7693 appropriate.
7694 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7695 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7696 <compile_stack_type>: `size' and `avail' are now `size_t'.
7697
7698 * regex.h <regoff_t>: Use ssize_t, not int.
7699 (re_search, re_search_2, re_match, re_match_2): Arguments that
7700 specify buffer/string position and length are now ssize_t and
7701 size_t. Return type is regoff_t.
7702
613052cd
BK
77032011-04-16 Ben Key <bkey76@gmail.com>
7704
7705 * nsfont.m: Fixed bugs in ns_get_family and
7706 ns_descriptor_to_entity that were caused by using free to
7707 deallocate memory blocks that were allocated by xmalloc (via
7708 xstrdup). This caused Emacs to crash when compiled with
7709 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7710 --enable-checking=xmallocoverrun). xfree is now used to
7711 deallocate these memory blocks.
7712
4170f62f 77132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7714
71b41406
PE
7715 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7716
9587a89d
PE
7717 emacs_write: Accept and return EMACS_INT for sizes.
7718 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7719 et seq.
7720 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7721 Accept and return EMACS_INT.
7722 (emacs_gnutls_write): Return the number of bytes written on
7723 partial writes.
7724 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7725 (emacs_read, emacs_write): Remove check for negative size, as the
7726 Emacs source code has been audited now.
9587a89d
PE
7727 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7728 (emacs_read, emacs_write): Use it.
273a5f82
PE
7729 * process.c (send_process): Adjust to the new signatures of
7730 emacs_write and emacs_gnutls_write. Do not attempt to store
7731 a byte offset into an 'int'; it might overflow.
9587a89d 7732 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7733
3e047f51
PE
7734 * sound.c: Don't assume sizes fit in 'int'.
7735 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7736 Return EMACS_INT, not int.
3e047f51 7737 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7738 Accept EMACS_INT, not int.
7739 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7740 record read return values.
7741
cc39a9db
BK
77422011-04-15 Ben Key <bkey76@gmail.com>
7743
c9d0ec6d
JB
7744 * keyboard.c (Qundefined): Don't declare static since it is used
7745 in nsfns.m.
7746 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7747 static since they are used in nsfont.m.
cc39a9db 7748
6c60eb9f
SM
77492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7750
7751 * process.c (Qprocessp): Don't declare static.
7752 * lisp.h (Qprocessp): Declare again.
7753
7990b61a
JB
77542011-04-15 Juanma Barranquero <lekktu@gmail.com>
7755
7756 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7757
5d4cb038
PE
77582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7759
8bd7b830 7760 Improve C-level modularity by making more things 'static'.
cd64ea1d 7761
e3b27b31
PE
7762 Don't publish debugger-only interfaces to other modules.
7763 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7764 (verify_bytepos, count_markers): Move decls to the only modules
7765 that need them.
7766 * region-cache.h (pp_cache): Likewise.
7767 * window.h (check_all_windows): Likewise.
7768 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7769
5d4cb038
PE
7770 * sysdep.c (croak): Now static, if
7771 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7772 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7773
7774 * alloc.c (refill_memory_reserve): Now static if
7775 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7776 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7777
e87b6180
PE
7778 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7779 Define only if USE_LUCID.
7780
ac64929e
PE
7781 * xrdb.c (x_customization_string, x_rm_string): Now static.
7782
6f37259d
PE
7783 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7784 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7785
1683e3ab
PE
7786 * xdisp.c (draw_row_with_mouse_face): Now static.
7787 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7788
de9c2632
PE
7789 * window.h (check_all_windows): Mark externally visible.
7790
2b96acb7
PE
7791 * window.c (window_deletion_count): Now static.
7792
7793 * undo.c: Make symbols static if they're not exported.
7794 (last_undo_buffer, last_boundary_position, pending_boundary):
7795 Now static.
7796
50436f33
PE
7797 * textprop.c (interval_insert_behind_hooks): Now static.
7798 (interval_insert_in_front_hooks): Likewise.
7799
64520e5c
PE
7800 * term.c: Make symbols static if they're not exported.
7801 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7802 (max_frame_lines, tty_set_terminal_modes):
7803 (tty_reset_terminal_modes, tty_turn_off_highlight):
7804 (get_tty_terminal): Now static.
7805 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7806 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7807 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7808 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7809 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7810
1fa53021
PE
7811 * sysdep.c: Make symbols static if they're not exported.
7812 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7813 Now static.
7814 (sigprocmask_set, full_mask): Remove; unused.
7815 (wait_debugging): Mark as visible.
7816 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7817 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7818
d4b43b22
PE
7819 * syntax.c (syntax_temp): Define only if !__GNUC__.
7820
b7c513d0
PE
7821 * sound.c (current_sound_device, current_sound): Now static.
7822
989b29ad
PE
7823 * search.c (searchbufs, searchbuf_head): Now static.
7824
13a55a78
PE
7825 * scroll.c (scroll_cost): Remove; unused.
7826 * dispextern.h (scroll_cost): Remove decl.
7827
de68a1fc
PE
7828 * region-cache.h (pp_cache): Mark as externally visible.
7829
40ccffa6
PE
7830 * process.c: Make symbols static if they're not exported.
7831 (process_tick, update_tick, create_process, chan_process):
7832 (Vprocess_alist, proc_buffered_char, datagram_access):
7833 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7834 (deactivate_process): Mark defn as static, as well as decl.
7835 * lisp.h (create_process): Remove decl.
7836 * process.h (chan_process, Vprocess_alist): Remove decls.
7837
ad64fc97
PE
7838 * print.c: Make symbols static if they're not exported.
7839 (print_depth, new_backquote_output, being_printed, print_buffer):
7840 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7841 (print_interval, print_number_index, initial_stderr_stream):
7842 Now static.
7843 * lisp.h (Fprinc): Remove decl.
7844 (debug_output_compilation_hack): Mark as externally visible.
7845
adddb265
PE
7846 * sysdep.c (croak): Move decl from here to syssignal.h.
7847 * syssignal.h (croak): Put it here, so the API can be checked when
7848 'croak' is called from dissociate_if_controlling_tty.
7849
1717ede2
PE
7850 * minibuf.c: Make symbols static if they're not exported.
7851 (minibuf_save_list, choose_minibuf_frame): Now static.
7852 * lisp.h (choose_minibuf_frame): Remove decl.
7853
fa5fb2bc
PE
7854 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7855
1e3890d1
PE
7856 * lread.c: Make symbols static if they're not exported.
7857 (read_objects, initial_obarray, oblookup_last_bucket_number):
7858 Now static.
7859 (make_symbol): Remove; unused.
7860 * lisp.h (initial_obarray, make_symbol): Remove decls.
7861
8a1414fa
PE
7862 * keyboard.c: Make symbols static if they're not exported.
7863 (single_kboard, recent_keys_index, total_keys, recent_keys):
7864 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7865 (this_single_command_key_start, echoing, last_auto_save):
7866 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7867 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7868 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7869 (Vlispy_mouse_stem, double_click_count):
7870 Now static.
7871 (force_auto_save_soon): Define only if SIGDANGER.
7872 (ignore_mouse_drag_p): Now static if
7873 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7874 (print_help): Remove; unused.
7875 (stop_character, last_timer_event): Mark as externally visible.
7876 * keyboard.h (ignore_mouse_drag_p): Declare only if
7877 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7878 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7879 * lisp.h (echoing): Remove decl.
7880 (force_auto_save_soon): Declare only if SIGDANGER.
7881 * xdisp.c (redisplay_window): Simplify code, to make it more
7882 obvious that ignore_mouse_drag_p is not accessed if !defined
7883 USE_GTK && !defined HAVE_NS.
7884
93ea6e8f
PE
7885 * intervals.c: Make symbols static if they're not exported.
7886 (merge_properties_sticky, merge_interval_right, delete_interval):
7887 Now static.
7888 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7889
77382fcc
PE
7890 * insdel.c: Make symbols static if they're not exported.
7891 However, leave prepare_to_modify_buffer alone. It's never
7892 called from outside this function, but that appears to be a bug.
7893 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7894 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7895 (adjust_after_replace_noundo): Remove; unused.
7896 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7897 (signal_before_change): Remove decls.
77382fcc 7898
9306c32e
PE
7899 * indent.c (val_compute_motion, val_vmotion): Now static.
7900
cd44d2eb
PE
7901 * image.c: Make symbols static if they're not exported.
7902 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7903 if USE_GTK.
7904 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7905 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7906
ad9a7a06
PE
7907 * fringe.c (standard_bitmaps): Now static.
7908 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7909
81626931
PE
7910 * frame.c: Make symbols static if they're not exported.
7911 (x_report_frame_params, make_terminal_frame): Now static.
7912 (get_frame_param): Now static, unless HAVE_NS.
7913 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7914 (x_get_resource_string): Remove; not used.
7915 * frame.h (make_terminal_frame, x_report_frame_params):
7916 (x_get_resource_string); Remove decls.
7917 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7918 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7919
239f9db9
PE
7920 * font.c, fontset.c: Make symbols static if they're not exported.
7921 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7922 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7923 * font.c (font_close_object): Now static.
7924 * font.h (font_close_object): Remove.
7925 * fontset.c (FONTSET_OBJLIST): Remove.
7926 (free_realized_fontset) #if-0 the body, which does nothing.
7927 (face_suitable_for_char_p): #if-0, as it's never called.
7928 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7929 * xfaces.c (face_at_string_position):
7930 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7931 since 0 is always ASCII.
7932
dfcf3579
PE
7933 * fns.c (weak_hash_tables): Now static.
7934
5045092b
PE
7935 * fileio.c: Make symbols static if they're not exported.
7936 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7937 (Vwrite_region_annotation_buffers): Now static.
7938
57a96f5c
PE
7939 * eval.c: Make symbols static if they're not exported.
7940 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7941 * lisp.h (backtrace_list): Remove decl.
7942
35f08c38
PE
7943 * emacs.c: Make symbols static if they're not exported.
7944 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7945 (fatal_error_code, fatal_error_signal_hook, standard_args):
7946 Now static.
7947 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7948 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7949 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7950 * lisp.h (fatal_error_signal_hook): Remove decl.
7951 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7952
f44bd759
PE
7953 * editfns.c: Move a (normally-unused) function to its only use.
7954 * editfns.c, lisp.h (get_operating_system_release): Remove.
7955 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7956 worth the hassle of breaking this out.
7957
b532497d
PE
7958 * xterm.c: Make symbols static if they're not exported.
7959 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7960 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7961 (x_destroy_window, x_delete_display):
7962 Now static.
7963 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7964 (x_mouse_leave): Remove; unused.
7965 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7966 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7967 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7968 Remove decls.
7969 (x_mouse_leave): Declare only if WINDOWSNT.
7970 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7971 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7972 USE_X_TOOLKIT.
7973
1675728f
PE
7974 * ftxfont.c: Make symbols static if they're not exported.
7975 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7976 HAVE_FREETYPE.
7977 * font.h (ftxfont_driver): Likewise.
7978
e4cebfca
PE
7979 * xfns.c: Make symbols static if they're not exported.
7980 (x_last_font_name, x_display_info_for_name):
7981 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7982 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7983 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7984 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7985 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7986 (last_show_tip_args): Now static.
7987 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7988 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7989 (x_screen_planes): Remove; unused.
7990 * dispextern.h (x_screen_planes): Remove decl.
7991
5bf46f05
PE
7992 * dispnew.c: Make symbols static if they're not exported.
7993 * dispextern.h (redraw_garbaged_frames, scrolling):
7994 (increment_row_positions): Remove.
7995 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7996 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7997 Now static.
7998 (redraw_garbaged_frames): Remove; unused.
7999
435f4c28
PE
8000 * xfaces.c: Make symbols static if they're not exported.
8001 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8002 Remove decls.
8003 * xterm.h (defined_color): Remove decls.
8004 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8005 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8006 (menu_face_changed_default, defined_color, free_realized_face):
8007 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8008 (ascii_face_of_lisp_face): Remove; unused.
8009
8524aef3
PE
8010 * xdisp.c: Make symbols static if they're not exported.
8011 * dispextern.h (scratch_glyph_row, window_box_edges):
8012 (glyph_to_pixel_coords, set_cursor_from_row):
8013 (get_next_display_element, set_iterator_to_next):
8014 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8015 (show_mouse_face): Remove decls
8016 * frame.h (message_buf_print): Likewise.
8017 * lisp.h (pop_message, set_message, check_point_in_composition):
8018 Likewise.
8019 * xterm.h (set_vertical_scroll_bar): Likewise.
8020 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8021 (message_buf_print, scratch_glyph_row, displayed_buffer):
8022 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8023 (get_next_display_element, show_mouse_face, window_box_edges):
8024 (frame_to_window_pixel_xy, check_point_in_composition):
8025 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8026 (glyph_to_pixel_coords): Remove; unused.
8027
16390cd2
PE
8028 * dired.c (file_name_completion): Now static.
8029
8030 * dbusbind.c (xd_in_read_queued_messages): Now static.
8031
a25f4dfa
PE
8032 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8033 * data.c (circular_list_error): Remove.
8034
14a9c8df
PE
8035 * commands.h (last_point_position, last_point_position_buffer):
8036 (last_point_position_window): Remove decls.
8037 * keyboard.c: Make these variables static.
8038
04f2d78b
CB
8039 * coding.h (coding, code_convert_region, encode_coding_gap):
8040 Remove decls.
74ab6df5
PE
8041 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8042 (iso_code_class, detect_coding, code_convert_region): Now static.
8043 (encode_coding_gap): Remove; unused.
8044
38dfbee1
PE
8045 * chartab.c (chartab_chars, chartab_bits): Now static.
8046
a2cb4e63
PE
8047 * charset.h (charset_iso_8859_1): Remove decl.
8048 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8049 Now static.
8050
127198fd
PE
8051 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8052 * ccl.c (Vccl_program_table): Now static.
8053 (check_ccl_update): Remove; unused.
8054
d85b608f
PE
8055 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8056 * category.h: ... from here.
8057 * category.c (check_category_table, set_category_set): Now static.
8058
31cd66f3
PE
8059 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8060 * lisp.h: Remove these decls.
8061
c358e587
PE
8062 * buffer.c (buffer_count): Remove unused var.
8063
e78aecca
PE
8064 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8065 so that it's not optimized away.
8066 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8067 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8068 exported only to the debugger.
8069
e192d7d3 8070 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8071 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8072
92470028
PE
8073 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8074 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8075 was inaccessible from Lisp.
8076 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8077 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8078
244ed907
PE
8079 alloc.c: Import and export fewer symbols, and remove unused items.
8080 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8081 is defined.
8082 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8083 it's not optimized away by whole-program optimization.
8084 (message_enable_multibyte, free_misc): Remove.
8085 (catchlist, handlerlist, mark_backtrace):
8086 Declare only if BYTE_MARK_STACK.
8087 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8088 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8089 (message_enable_multibyte): Remove decl.
8090 (free_misc, interval_free_list, float_block, float_block_index):
8091 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8092 (cons_free_list, last_marked_index):
8093 Now static.
8094 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8095 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8096 (mark_backtrace): Define only if BYTE_MARK_STACK.
8097 * xdisp.c (message_enable_multibyte): Now static.
8098
61c2b50e 8099 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8100 This makes it easier for human readers (and static analyzers)
8101 to see whether these variables are used from other modules.
8102 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8103 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8104 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8105 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8106 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8107 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8108 * xmenu.c, xselect.c:
8109 Declare Q* vars static if they are not used in other modules.
8110 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8111 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8112 Remove decls of unexported vars.
8113 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8114
95c82688
PE
8115 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8116
16a97296
PE
8117 Make Emacs functions such as Fatom 'static' by default.
8118 This makes it easier for human readers (and static analyzers)
8119 to see whether these functions can be called from other modules.
8120 DEFUN now defines a static function. To make the function external
8121 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8122 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8123 (Finit_image_library):
16a97296
PE
8124 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8125 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8126 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8127 Remove decls, since these functions are now static.
8128 (Funintern, Fget_internal_run_time): New decls, since these functions
8129 were already external.
95c82688 8130
16a97296
PE
8131 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8132 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8133 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8134 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8135 * keyboard.c, keymap.c, lread.c:
8136 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8137 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8138 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8139 Mark functions with DEFUE instead of DEFUN,
8140 if they are used in other modules.
8141 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8142 decls for now-static functions.
8143 * buffer.h (Fdelete_overlay): Remove decl.
8144 * callproc.c (Fgetenv_internal): Mark as internal.
8145 * composite.c (Fremove_list_of_text_properties): Remove decl.
8146 (Fcomposition_get_gstring): New forward static decl.
8147 * composite.h (Fcomposite_get_gstring): Remove decl.
8148 * dired.c (Ffile_attributes): New forward static decl.
8149 * doc.c (Fdocumntation_property): New forward static decl.
8150 * eval.c (Ffetch_bytecode): New forward static decl.
8151 (Funintern): Remove extern decl; now in .h file where it belongs.
8152 * fileio.c (Fmake_symbolic_link): New forward static decl.
8153 * image.c (Finit_image_library): New forward static decl.
8154 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8155 * intervals.h (Fprevious_property_change):
8156 (Fremove_list_of_text_properties): Remove decls.
8157 * keyboard.c (Fthis_command_keys): Remove decl.
8158 (Fcommand_execute): New forward static decl.
8159 * keymap.c (Flookup_key): New forward static decl.
8160 (Fcopy_keymap): Now static.
8161 * keymap.h (Flookup_key): Remove decl.
8162 * process.c (Fget_process): New forward static decl.
8163 (Fprocess_datagram_address): Mark as internal.
8164 * syntax.c (Fsyntax_table_p): New forward static decl.
8165 (skip_chars): Remove duplicate decl.
8166 * textprop.c (Fprevious_property_change): New forward static decl.
8167 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8168 Now internal.
8169 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8170 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8171
785bbd42
PE
8172 * editfns.c (Fformat): Remove unreachable code.
8173
8b913b57
AS
81742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8175
8176 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8177 change. (Bug#8496)
8178
a6744a35
EZ
81792011-04-13 Eli Zaretskii <eliz@gnu.org>
8180
8181 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8182 when at ZV. (Bug#8487)
8183
e7974947
AS
81842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8185
baad03f0
AS
8186 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8187 (Bug#8437)
8188 * keyboard.c (parse_tool_bar_item): Likewise.
8189 * sound.c (sound_cleanup, alsa_close): Likewise.
8190 * termcap.c (tgetent): Likewise.
8191 * xfns.c (x_default_font_parameter): Likewise.
8192 * xsettings.c (read_and_apply_settings): Likewise.
8193
e7974947
AS
8194 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8195 (overrun_check_free): Protoize.
8196
28272684
PE
81972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8198
8199 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8200 since callers should never pass a negative size.
8201 Change the signature to match that of plain 'read' and 'write'; see
8202 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8203 * lisp.h: Update prototypes of emacs_write and emacs_read.
8204
11997c76
EZ
82052011-04-11 Eli Zaretskii <eliz@gnu.org>
8206
8207 * xdisp.c (redisplay_window): Don't try to determine the character
8208 position of the scroll margin if the window start point w->startp
e896f03c 8209 is outside the buffer's accessible region. (Bug#8468)
11997c76 8210
8a2cbd72
EZ
82112011-04-10 Eli Zaretskii <eliz@gnu.org>
8212
8213 Fix write-region and its subroutines for buffers > 2GB.
8214 * fileio.c (a_write, e_write): Modify declaration of arguments and
8215 local variables to support buffers larger than 2GB.
8216 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8217
8218 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8219 argument, local variables, and return value.
8220
8221 * lisp.h: Update prototypes of emacs_write and emacs_read.
8222
8223 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8224
4073e537 82252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8226
1ebfdcb6
PE
8227 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8228
b2ded58d
PE
8229 Fix more problems found by GCC 4.6.0's static checks.
8230
7d66342c
PE
8231 * xdisp.c (vmessage): Use a better test for character truncation.
8232
bbf47d44
PE
8233 * charset.c (load_charset_map): <, not <=, for optimization,
8234 and to avoid potential problems with integer overflow.
9248994d 8235 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8236 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8237 * editfns.c (Fformat): Likewise.
1e69125e 8238 * syntax.c (skip_chars): Likewise.
3befa583 8239
e3019616
PE
8240 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8241 This also lets GCC 4.6.0 generate slightly better loop code.
8242
becfa255
PE
8243 * callint.c (Fcall_interactively): <, not <=, for optimization.
8244 (Fcall_interactively): Count the number of arguments produced,
8245 not the number of arguments given. This is simpler and lets GCC
8246 4.6.0 generate slightly better code.
8247
dae0cd48
PE
8248 * ftfont.c: Distingish more carefully between FcChar8 and char.
8249 The previous code passed unsigned char * to a functions like
8250 strlen and xstrcasecmp that expect char *, which does not
8251 conform to the C standard.
8252 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8253 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8254 char * when the C standard requires it.
8255
76032d70
PE
8256 * keyboard.c (read_char): Remove unused var.
8257
eb3f1cc8
PE
8258 * eval.c: Port to Windows vsnprintf (Bug#8435).
8259 Include <limits.h>.
8260 (SIZE_MAX): Define if the headers do not.
8261 (verror): Do not give up if vsnprintf returns a negative count.
8262 Instead, grow the buffer. This ports to Windows vsnprintf, which
8263 does not conform to C99. Problem reported by Eli Zaretskii.
8264 Also, simplify the allocation scheme, by avoiding the need for
8265 calling realloc, and removing the ALLOCATED variable.
8266
70476b54
PE
8267 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8268
12020a9e
PE
8269 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8270 But keep the doprint source code for now, as we might revamp it
8271 and use it again (Bug#8435).
ea6c7ae6
PE
8272 * lisp.h (doprnt): Remove.
8273 * Makefile.in (base_obj): Remove doprnt.o.
8274 * deps.mk (doprnt.o): Remove.
8275
5fdb398c
PE
8276 error: Print 32- and 64-bit integers portably (Bug#8435).
8277 Without this change, on typical 64-bit hosts error ("...%d...", N)
8278 was used to print both 32- and 64-bit integers N, which relied on
8279 undefined behavior.
61bdb816 8280 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8281 * lisp.h (error, verror): Mark as printf-like functions.
8282 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8283 Report overflow in size calculations when allocating printf buffer.
8284 Do not truncate output string at its first null byte.
8285 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8286 Truncate the output at a character boundary, since vsnprintf does not
8287 do that.
8288 * charset.c (check_iso_charset_parameter): Convert internal
8289 character to string before calling 'error', since %c now has the
8290 printf meaning.
8291 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8292 overflow when computing char to be passed to 'error'. Do not
8293 pass Lisp_Object to 'error'; pass the integer instead.
8294 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8295 formatted with plain %d.
8296
b189fa66
PE
8297 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8298
bff87ef0
PE
8299 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8300
7e2cac20
PE
8301 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8302
ce4d90b5
PE
8303 * xterm.c (x_catch_errors): Remove duplicate declaration.
8304
266c9547
PE
8305 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8306
79c49ad2
PE
8307 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8308
368f4090
JM
83092011-04-10 Jim Meyering <meyering@redhat.com>
8310
8311 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8312 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8313 return ssize_t not "int", and use size_t as the buffer length.
8314 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8315 * gnutls.h: Update declarations.
8316 * process.c (read_process_output): Use ssize_t, to match.
8317 (send_process): Likewise.
8318
a32d4040
CY
83192011-04-09 Chong Yidong <cyd@stupidchicken.com>
8320
8321 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8322
8546720e 83232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8324
04f2d78b
CB
8325 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8326 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8327
8546720e
GM
8328 * xterm.c (handle_one_xevent):
8329 * xmenu.c (create_and_show_popup_menu):
8330 * xselect.c (x_decline_selection_request)
8331 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8332
0a2f5c1a 83332011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8334
8335 Fix some uses of `int' instead of EMACS_INT.
8336 * search.c (string_match_1, fast_string_match)
8337 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8338 (scan_buffer, find_next_newline_no_quit)
8339 (find_before_next_newline, search_command, Freplace_match)
8340 (Fmatch_data): Make some `int' variables be EMACS_INT.
8341
8342 * xdisp.c (display_count_lines): 3rd argument and return value now
8343 EMACS_INT. All callers changed.
8344 (pint2hrstr): Last argument is now EMACS_INT.
8345
8346 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8347 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8348 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8349 (decode_coding_utf_16, decode_coding_emacs_mule)
8350 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8351 (decode_coding_ccl, decode_coding_charset)
8352 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8353 (decode_coding_iso_2022, decode_coding_emacs_mule)
8354 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8355 <char_offset, last_offset>: Declare EMACS_INT.
8356 (encode_coding_utf_8, encode_coding_utf_16)
8357 (encode_coding_emacs_mule, encode_invocation_designation)
8358 (encode_designation_at_bol, encode_coding_iso_2022)
8359 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8360 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8361 Declare EMACS_INT.
8362 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8363 (encode_invocation_designation): Last argument P_NCHARS is now
8364 EMACS_INT.
8365 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8366 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8367
8368 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8369 All users changed.
8370
8371 * ccl.c (Fccl_execute_on_string): Declare some variables
8372 EMACS_INT.
8373
8546720e 83742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8375
8376 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8377
4e19a977
CS
83782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8379
8380 * process.c (Fformat_network_address): Doc fix.
8381
87302331
R
83822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8383
ee7683eb 8384 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8385
cbb59342
CY
83862011-04-08 Chong Yidong <cyd@stupidchicken.com>
8387
8388 * keyboard.c (read_char): Call Lisp function help-form-show,
8389 instead of using internal_with_output_to_temp_buffer.
8390 (Qhelp_form_show): New var.
e0d38eeb 8391 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8392
8393 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8394
8395 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8396
e67a13ab
CY
83972011-04-06 Chong Yidong <cyd@stupidchicken.com>
8398
04f2d78b
CB
8399 * process.c (Flist_processes): Remove to Lisp.
8400 (list_processes_1): Delete.
e67a13ab 8401
973f782d
EZ
84022011-04-06 Eli Zaretskii <eliz@gnu.org>
8403
7c106b1e
EZ
8404 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8405
973f782d
EZ
8406 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8407
41cf7d1a 84082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8409
ca23cc88
PE
8410 Fix more problems found by GCC 4.6.0's static checks.
8411
f390e2d5
PE
8412 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8413
42eea0d0
PE
8414 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8415
b69769da 8416 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8417
f9541e84
PE
8418 * xdisp.c (vmessage): Mark as a printf-like function.
8419
13841b55
PE
8420 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8421
c136c10f
PE
8422 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8423
5e2d4a30
PE
8424 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8425 printf-like functions.
8426 (tiff_load): Add casts to remove these marks before passing them
8427 to system-supplied API.
8428
583f48b9
PE
8429 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8430
b25d760e
PE
8431 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8432 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8433 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8434 directly, rather than having caller test rule sign. This avoids
8435 some unnecessary tests.
8436 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8437 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8438 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8439
bc7b6697 8440 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8441 (xfont_open): Avoid unnecessary tests.
bc7b6697 8442
27ccc379
PE
8443 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8444
dcd5c89a
PE
8445 * composite.h, composite.c (composition_gstring_put_cache):
8446 Use EMACS_INT, not int, for length.
8447
b13a45c6
PE
8448 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8449 breaking out part of COMPOSITION_DECODE_RULE.
8450 (COMPOSITION_DECODE_RULE): Use it.
8451 * composite.c (get_composition_id): Remove unused local vars,
8452 by using the new macro.
8453
1e792e4d
PE
8454 * textprop.c (set_text_properties_1): Change while to do-while,
8455 since the condition is always true at first.
8456
dc6c6455 8457 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8458 (interval_deletion_adjustment): Return unsigned value.
8459 All uses changed.
dc6c6455 8460
aba7731a
PE
8461 * process.c (list_processes_1, create_pty, read_process_output):
8462 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8463 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8464 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8465 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8466 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8467
fdfc4bf3
PE
8468 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8469
fca8fe46 8470 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8471 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8472
06a0259a 8473 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8474 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8475 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8476
e7b9e80f
PE
8477 * print.c (print_error_message): Avoid int overflow.
8478
56201685
PE
8479 * font.c (font_list_entities): Redo for clarity,
8480 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8481
78834453 8482 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8483 (font_score): Avoid potential overflow in diff calculation.
78834453 8484
0bc0b309 8485 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8486 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8487
e610eaca
PE
8488 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8489
b895abce
PE
8490 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8491 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8492 can always succeed if overflow has undefined behavior.
8493
1f1d9321 8494 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8495 (wordify): Omit three unnecessary tests.
1f1d9321 8496
c59478bc
PE
8497 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8498 All callers changed. This avoids the need for an unused var.
8499
79b73827
PE
8500 * casefiddle.c (casify_region): Remove var that is set but not used.
8501
a4db5dfe
PE
8502 * dired.c (file_name_completion): Remove var that is set but not used.
8503
43aae36e
PE
8504 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8505
2a47c44d 8506 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8507 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8508
a37c69bf
PE
8509 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8510 Check for integer overflow on size calculations.
8511
328ab8e7
PE
8512 * buffer.c (Fprevious_overlay_change): Remove var that is set
8513 but not used.
8514
e5a2a5cb
PE
8515 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8516 Remove vars that are set but not used.
8d84a6eb 8517 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8518 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8519
a60e5f68
PE
8520 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8521
f661cb61 8522 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8523 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8524
f0397f5a
PE
8525 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8526 that are set but not used.
8527
8664db06 8528 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8529 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8530
6abdaa4a
PE
8531 * xselect.c (x_get_local_selection, x_handle_property_notify):
8532 Remove vars that are set but not used.
8533
0ce7538d 8534 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8535 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8536
9ae848fc
PE
8537 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8538 Remove var that is set but not used.
0b918413
PE
8539 (scroll_bar_windows_size): Now size_t, not int.
8540 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8541 Check for overflow.
9ae848fc 8542
a5a62657
PE
8543 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8544 (map_tty_color) [!defined MSDOS]: Likewise.
8545
5c5cdd39
PE
8546 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8547
66ebf983
PE
8548 * coding.c: Remove vars that are set but not used.
8549 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8550 All callers changed.
8551 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8552 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8553 (decode_coding_charset): Remove vars that are set but not used.
8554
1be4d761
PE
8555 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8556 that is set but not used.
8557
47553fa8
PE
8558 * print.c (print_object): Remove var that is set but not used.
8559
1f7196bf 8560 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8561 The gnulib version avoids calling malloc in the usual case,
8562 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8563 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8564 * filelock.c (current_lock_owner): Likewise.
8565 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8566 * sysdep.c: Include allocator.h, careadlinkat.h.
8567 (emacs_no_realloc_allocator): New static constant.
8568 (emacs_readlink): New function.
fdb61804
PE
8569 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8570 ../lib/careadlinkat.h.
d1fdcab7 8571
f84c17c7
SM
85722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8573
8574 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8575 first non-nil return value).
8576
ef3862ad
JD
85772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8578
8579 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8580 if not defined (Bug#8403).
8581
376a7006
JB
85822011-04-02 Juanma Barranquero <lekktu@gmail.com>
8583
8584 * xdisp.c (display_count_lines): Remove parameter `start',
8585 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8586 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8587 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8588 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8589 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8590 and thereabouts. All callers changed.
8591 (get_per_char_metric): Remove parameter `f', unused since
8592 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8593
6ca3801d
JM
85942011-04-02 Jim Meyering <meyering@redhat.com>
8595
8596 do not dereference NULL upon failed strdup
8597 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8598 (ns_get_family): Likewise.
8599
d8e2b5ba
JB
86002011-04-02 Juanma Barranquero <lekktu@gmail.com>
8601
8602 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8603
8c74fcbd
JD
86042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8605
8606 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8607 later (Bug#8403).
8608
7200d79c
SM
86092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8610
03408648 8611 Add lexical binding.
7200d79c 8612
03408648
SM
8613 * window.c (Ftemp_output_buffer_show): New fun.
8614 (Fsave_window_excursion):
8615 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8616
8617 * lread.c (lisp_file_lexically_bound_p): New function.
8618 (Fload): Bind Qlexical_binding.
8619 (readevalloop): Remove `evalfun' arg.
8620 Bind Qinternal_interpreter_environment.
8621 (Feval_buffer): Bind Qlexical_binding.
8622 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8623 Mark as dynamic.
8624 (syms_of_lread): Declare `lexical-binding'.
8625
8626 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8627
8628 * keyboard.c (eval_dyn): New fun.
8629 (menu_item_eval_property): Use it.
ca105506
SM
8630
8631 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8632
03408648
SM
8633 * fns.c (concat, mapcar1): Accept byte-code-functions.
8634
8635 * eval.c (Fsetq): Handle lexical vars.
8636 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8637 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8638 (FletX, Flet): Obey lexical binding.
8639 (Fcommandp): Handle closures.
8640 (Feval): New `lexical' arg.
8641 (eval_sub): New function extracted from Feval. Use it almost
8642 everywhere where Feval was used. Look up vars in lexical env.
8643 Handle closures.
8644 (Ffunctionp): Move from subr.el.
8645 (Ffuncall): Handle closures.
8646 (apply_lambda): Remove `eval_flags'.
8647 (funcall_lambda): Handle closures and new byte-code-functions.
8648 (Fspecial_variable_p): New function.
8649 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8650 but without exporting it to Lisp.
23aba0ea 8651
23aba0ea 8652 * doc.c (Fdocumentation, store_function_docstring):
03408648 8653 * data.c (Finteractive_form): Handle closures.
23aba0ea 8654
03408648
SM
8655 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8656 interactive spec.
ba83908c 8657
04f2d78b
CB
8658 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8659 New byte-codes.
03408648
SM
8660 (exec_byte_code): New function extracted from Fbyte_code to handle new
8661 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8662
03408648 8663 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8664
03408648 8665 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8666
e2abce01
JB
86672011-03-31 Juanma Barranquero <lekktu@gmail.com>
8668
8669 * xdisp.c (redisplay_internal): Fix prototype.
8670
63696a73 86712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8672
63696a73 8673 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8674 (try_scrolling): Use it when setting scroll_limit.
8675 Limit scrolling to 100 screen lines.
63696a73
EZ
8676 (redisplay_window): Even when falling back on "recentering",
8677 position point in the window according to scroll-conservatively,
8678 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8679
8680 (try_scrolling): When point is above the window, allow searching
8681 as far as scroll_max, or one screenful, to compute vertical
8682 distance from PT to the scroll margin position. This prevents
8683 try_scrolling from unnecessarily failing when
8684 scroll-conservatively is set to a value slightly larger than the
8685 window height. Clean up the case of PT below the margin at bottom
8686 of window: scroll_max can no longer be INT_MAX. When aggressive
8687 scrolling is in use, don't let point enter the opposite scroll
8688 margin as result of the scroll.
8689 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8690 threshold of 100 lines for never-recentering scrolling.
8691
e4cc2dfc
JB
86922011-03-31 Juanma Barranquero <lekktu@gmail.com>
8693
8694 * dispextern.h (move_it_by_lines):
8695 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8696 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8697 (message_log_check_duplicate): Remove parameters `prev_bol' and
8698 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8699 (redisplay_internal): Remove parameter `preserve_echo_area',
8700 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8701
8702 * indent.c (Fvertical_motion):
8703 * window.c (window_scroll_pixel_based, Frecenter):
8704 Don't pass `need_y_p' to `move_it_by_lines'.
8705
1c470562
SM
87062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8707
44f230aa
SM
8708 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8709 steal a few bits to be more compact.
8710 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8711 Remove unneeded casts.
8712
1c470562
SM
8713 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8714
888adce9
ZK
87152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8716
8717 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8718 binding" message (bug#7967).
8719
f838ed7b
PE
87202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8721
77861b95
PE
8722 Fix more problems found by GCC 4.6.0's static checks.
8723
de6dbc14
PE
8724 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8725 Remove unused local var.
8726
f838ed7b
PE
8727 * editfns.c (Fmessage_box): Remove unused local var.
8728
792c7b2b
PE
8729 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8730 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8731 Omit unused local vars.
c499e557 8732 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8733 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8734 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8735 Omit unused local var.
8736
ba0165e1
PE
8737 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8738 Don't assume string length fits in int.
32ad8845 8739 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8740 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8741
3c59b4c9
PE
8742 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8743 instead of alloca (Bug#8344).
8744
a3eed478 8745 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8746 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8747
eb4d412d
PE
8748 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8749
1658b401
PE
8750 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8751 concerns.
8752
8753 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8754
8755 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8756
9a2c6e05
PE
8757 * keyboard.c (syms_of_keyboard): Use the same style as later
8758 in this function when indexing through an array. This also
8759 works around GCC bug 48267.
8760
03d0a109
PE
8761 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8762
44f730c8
PE
8763 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8764
fe75f926
PE
8765 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8766 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8767
ffa8c828
PE
8768 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8769 This avoids undefined behavior on integer overflow, and is a bit
8770 more convenient anyway since it is compared to a size_t variable.
8771
c5101a77
PE
8772 Variadic C functions now count arguments with size_t, not int.
8773 This avoids an unnecessary limitation on 64-bit machines, which
8774 caused (substring ...) to crash on large vectors (Bug#8344).
8775 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8776 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8777 All variadic functions and their callers changed accordingly.
c5101a77
PE
8778 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8779 * data.c (arith_driver, float_arith_driver): Likewise.
8780 * editfns.c (general_insert_function): Likewise.
8781 * eval.c (struct backtrace.nargs, interactive_p)
8782 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8783 (funcall_lambda, mark_backtrace): Likewise.
8784 * fns.c (concat): Likewise.
8785 * frame.c (x_set_frame_parameters): Likewise.
8786 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8787 0 if not found, not -1. All callers changed.
8788
dd3f25f7
PE
8789 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8790 (stack_copy_size): Now size_t, not int.
8791 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8792
461c2ab9
JB
87932011-03-28 Juanma Barranquero <lekktu@gmail.com>
8794
8795 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8796 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8797 All callers changed.
8798
8799 * lisp.h (multibyte_char_to_unibyte):
8800 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8801 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8802 * character.h (CHAR_TO_BYTE8):
8803 * cmds.c (internal_self_insert):
8804 * editfns.c (general_insert_function):
8805 * keymap.c (push_key_description):
8806 * search.c (Freplace_match):
8807 * xdisp.c (message_dolog, set_message_1): All callers changed.
8808
f6d62986
SM
88092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8810
8811 * keyboard.c (safe_run_hook_funcall): New function.
8812 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8813 don't set the hook to nil, but remove the offending function instead.
8814 (Qcommand_hook_internal): Remove, unused.
8815 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8816 Vcommand_hook_internal.
8817
8818 * eval.c (enum run_hooks_condition): Remove.
8819 (funcall_nil, funcall_not): New functions.
8820 (run_hook_with_args): Call each function through a `funcall' argument.
8821 Remove `cond' argument, now redundant.
8822 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8823 (Frun_hook_with_args_until_failure): Adjust accordingly.
8824 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8825
1db5b1ad
JB
88262011-03-28 Juanma Barranquero <lekktu@gmail.com>
8827
8828 * dispextern.h (string_buffer_position): Remove declaration.
8829
8830 * print.c (strout): Remove parameter `multibyte', unused since
8831 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8832
8833 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8834 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8835 All callers changed.
8836
8837 * w32.c (_wsa_errlist): Use braces for struct initializers.
8838
8839 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8840 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8841 All callers changed.
8842 (string_buffer_position): Likewise. Also, make static (it's never
8843 used outside xdisp.c).
8844 (cursor_row_p): Remove parameter `w', unused since
8845 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8846 (decode_mode_spec): Remove parameter `precision', introduced during
8847 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8848 All callers changed.
8849
5ffb62aa
JD
88502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8851
8852 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8853
461c2ab9 88542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8855
8856 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8857 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8858 (ns_update_auto_hide_menu_bar): New functions.
8859 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8860 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8861 ns_constrain_all_frames.
8862 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8863 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8864
5c380ffb
JD
88652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8866
8867 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8868
9af30bdf
GM
88692011-03-27 Glenn Morris <rgm@gnu.org>
8870
8871 * syssignal.h: Replace RETSIGTYPE with void.
8872 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8873 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8874 Replace SIGTYPE with void everywhere.
8875 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8876 * s/template.h (SIGTYPE): Remove commented out definition.
8877
e2abce01
JB
88782011-03-26 Eli Zaretskii <eliz@gnu.org>
8879
8880 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8881 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8882
f868cd8a
JB
88832011-03-26 Juanma Barranquero <lekktu@gmail.com>
8884
59eb0929
JB
8885 * w32.c (read_unc_volume): Use parameter `henum', instead of
8886 global variable `wget_enum_handle'.
8887
8888 * keymap.c (describe_vector): Remove parameters `indices' and
8889 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8890 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8891
f868cd8a
JB
8892 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8893
8894 * keyboard.c (timer_check): Remove parameter `do_it_now',
8895 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8896 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8897 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8898
8899 * keyboard.c (read_char):
8900 * w32menu.c (w32_menu_display_help):
8901 * xmenu.c (show_help_event, menu_help_callback):
8902 Adjust calls to `show_help_echo'.
8903
8904 * gtkutil.c (xg_maybe_add_timer):
8905 * keyboard.c (readable_events):
8906 * process.c (wait_reading_process_output):
8907 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8908
8909 * insdel.c (adjust_markers_gap_motion):
8910 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8911 (gap_left, gap_right): Don't call it.
8912
2ecf6fdb
CY
89132011-03-25 Chong Yidong <cyd@stupidchicken.com>
8914
8915 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8916 incurred during fontification.
8917
6b1f9ba4
JB
89182011-03-25 Juanma Barranquero <lekktu@gmail.com>
8919
8920 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8921 (DEFVAR_PER_BUFFER): Don't pass it.
8922
8923 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8924 (scrolling_window): Don't pass it.
8925
0f4a96b5
JB
89262011-03-25 Juanma Barranquero <lekktu@gmail.com>
8927
8928 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8929
8930 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8931 and `suffix'.
8932 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8933 of variables specific to SELinux and computation of `encoded_absname'.
8934
8935 * image.c (XPutPixel): Remove unused variable `height'.
8936
8937 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8938
8939 * unexw32.c (get_section_info): Remove unused variable `section'.
8940
8941 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8942 (system_process_attributes): Remove unused variable `sess'.
8943 (sys_read): Remove unused variable `err'.
8944
8945 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8946 (w32_wnd_proc): Remove unused variable `isdead'.
8947 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8948 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8949 (x_create_tip_frame): Remove unused variable `tem'.
8950
8951 * w32inevt.c (w32_console_read_socket):
8952 Remove unused variable `no_events'.
8953
8954 * w32term.c (x_draw_composite_glyph_string_foreground):
8955 Remove unused variable `width'.
8956
1149507c
JB
89572011-03-24 Juanma Barranquero <lekktu@gmail.com>
8958
8959 * w32term.c (x_set_glyph_string_clipping):
8960 Don't pass uninitialized region to CombineRgn.
8961
9c88f339
JB
89622011-03-23 Juanma Barranquero <lekktu@gmail.com>
8963
8964 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8965 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8966 (Fx_close_connection): Remove unused variable `i'.
8967
8968 * w32font.c (w32font_draw): Return number of glyphs.
8969 (w32font_open_internal): Remove unused variable `i'.
8970 (w32font_driver): Add missing initializer.
8971
8972 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8973 (fill_in_menu): Remove unused variable `items_added'.
8974
8975 * w32term.c (last_mouse_press_frame): Remove static global variable.
8976 (w32_clip_to_row): Remove unused variable `f'.
8977 (x_delete_terminal): Remove unused variable `i'.
8978
8979 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8980 (NOTHING): Remove unused static global variable.
8981 (uniscribe_check_otf): Remove unused variable `table'.
8982 (uniscribe_font_driver): Add missing initializers.
8983
dee091a3
JD
89842011-03-23 Julien Danjou <julien@danjou.info>
8985
8986 * term.c (Fsuspend_tty, Fresume_tty):
8987 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8988 * window.c (temp_output_buffer_show):
8989 * insdel.c (signal_before_change):
8990 * frame.c (Fhandle_switch_frame):
8991 * fileio.c (Fdo_auto_save):
8992 * emacs.c (Fkill_emacs):
8993 * editfns.c (save_excursion_restore):
8994 * cmds.c (internal_self_insert):
8995 * callint.c (Fcall_interactively):
8996 * buffer.c (Fkill_all_local_variables):
8997 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8998 Use Frun_hooks.
0f4a96b5 8999 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9000 unconditionally since it does the check itself.
dee091a3 9001
2c520ab5 90022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9003
c9c49752
PE
9004 Fix more problems found by GCC 4.5.2's static checks.
9005
8abc3f12
PE
9006 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9007 the first time through the loop, since we know p0 < p1 then.
9008 This also avoids a gcc -Wstrict-overflow warning.
9009
a2d26660
PE
9010 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9011 leading to a memory leak, possible in functions like
9012 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9013 of objects (Bug#8318).
a2d26660 9014
916c72e9
PE
9015 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9016 that could (at least in theory) be that large.
9017
19ab8a18
PE
9018 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9019 This is less likely to overflow, and avoids undefined behavior if
9020 overflow does occur. All callers changed. Use strtoul to scan
9021 for the unsigned long integer.
b7cbbd6f
PE
9022 (pint2hrstr): Simplify and tune code slightly.
9023 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9024
f0641eff
PE
9025 * scroll.c (do_scrolling): Work around GCC bug 48228.
9026 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9027
7f650bb9
PE
9028 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9029 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9030 (validate_x_resource_name): Simplify count usage.
9031 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9032
37dd57d1
PE
9033 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9034 fail (Bug#8306).
81e56e61 9035
699979fc 9036 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9037
401bf9b4
PE
9038 * process.c (Fmake_network_process): Use socklen_t, not int,
9039 where POSIX says socklen_t is required in portable programs.
9040 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9041 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9042 (Fmake_network_process, server_accept_connection):
9043 (wait_reading_process_output, read_process_output):
9044 Likewise.
9045
b93aacde
PE
9046 * process.c: Rename or move locals to avoid shadowing.
9047 (list_processes_1, Fmake_network_process):
9048 (read_process_output_error_handler, exec_sentinel_error_handler):
9049 Rename or move locals.
4dc343ee 9050 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9051 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9052 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9053 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9054 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9055
af8a867c 9056 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9057 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9058 Include tparam.h instead, since it declares them.
af8a867c
PE
9059 * cm.h (PC): Remove extern decl; tparam.h now does this.
9060 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9061 * terminfo.c: Include tparam.h, to check interfaces.
9062 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9063 (tparam): Adjust signature to match interface in tparam.h;
9064 this removes some undefined behavior. Check that outstring and len
9065 are zero, which they always are with Emacs.
9066 * tparam.h (PC, BC, UP): New extern decls.
9067
0248044d 9068 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9069 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9070
8ff096c1 9071 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9072 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9073 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9074 (ftfont_list): Remove unused local.
49eaafba
PE
9075 (get_adstyle_property, ftfont_pattern_entity):
9076 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9077 Rename locals to avoid shadowing.
8ff096c1 9078
e2be39f6
PE
9079 * xfont.c (xfont_list_family): Mark var as initialized.
9080
c9735e30
PE
9081 * xml.c (make_dom): Now static.
9082
8f5201ae
PE
9083 * composite.c (composition_compute_stop_pos): Rename local to
9084 avoid shadowing.
b246f932
PE
9085 (composition_reseat_it): Remove unused locals.
9086 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9087 (composition_update_it): Mark var as initialized.
11b61122
PE
9088 (find_automatic_composition): Mark vars as initialized,
9089 with a FIXME (Bug#8290).
8f5201ae 9090
760fbc2c
PE
9091 character.h: Rename locals to avoid shadowing.
9092 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9093 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9094 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9095 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9096 to avoid shadowing.
9097
ff08eb85
PE
9098 * textprop.c (property_change_between_p): Remove; unused.
9099
fc7bf025
PE
9100 * intervals.c (interval_start_pos): Now static.
9101
235d7abc
PE
9102 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9103
44f230aa
SM
9104 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9105 Rename locals to avoid shadowing.
3e7d6594 9106
50060332
PE
9107 * sound.c (wav_play, au_play, Fplay_sound_internal):
9108 Fix pointer signedness.
d01f234b 9109 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9110 (wav_play): Initialize a variable to 0, to prevent undefined
9111 behavior (Bug#8278).
50060332 9112
c4fc4e30
PE
9113 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9114
918436ed
PE
9115 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9116
c939f91b
PE
9117 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9118 clobbering (Bug#8298).
b9c7f648
PE
9119 * sysdep.c (sys_subshell): Likewise.
9120 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9121
6bd8c144
PE
9122 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9123 This should get cleaned up, so that child_setup has the
9124 same signature on all platforms.
9125
7710357c 9126 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9127 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9128
c59da222
CY
91292011-03-22 Chong Yidong <cyd@stupidchicken.com>
9130
9131 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9132 not to be necessary, and produces flickering.
9133
66b87493
GM
91342011-03-20 Glenn Morris <rgm@gnu.org>
9135
9136 * config.in: Remove file.
9137
45b6f6d5
JB
91382011-03-20 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9141 are now in src/globals.h.
9142 (syms_of_minibuf): Remove spurious & from previous change.
9143
cd394be1 91442011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9145
9146 * minibuf.c (completing-read-function): New variable.
9147 (completing-read-default): Rename from completing-read.
9148 (completing-read): Call completing-read-function.
9149
b14e3e21
CY
91502011-03-19 Juanma Barranquero <lekktu@gmail.com>
9151
9152 * xfaces.c (Fx_load_color_file):
9153 Read color file from absolute filename (bug#8250).
9154
f2b726e6
JB
91552011-03-19 Juanma Barranquero <lekktu@gmail.com>
9156
9157 * makefile.w32-in: Update dependencies.
9158
09f6ff02
EZ
91592011-03-17 Eli Zaretskii <eliz@gnu.org>
9160
9161 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9162
29a6015a
PE
91632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9164
a3a6c54e
PE
9165 Fix more problems found by GCC 4.5.2's static checks.
9166
b766f867
PE
9167 * process.c (make_serial_process_unwind, send_process_trap):
9168 (sigchld_handler): Now static.
9169
be02381c
PE
9170 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9171 That way, the code declares only the vars that it needs.
9172 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9173 * s/cygwin.h (PTY_ITERATION): Likewise.
9174 * s/darwin.h (PTY_ITERATION): Likewise.
9175 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9176
57048744
PE
9177 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9178 * process.c (allocate_pty): Don't declare stb unless it's needed.
9179
7914961c 9180 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9181 (CONSTANTLIM): Remove; unused.
9182 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9183 Define only if needed.
7914961c 9184
b3967b18
PE
9185 * unexelf.c (unexec): Name an expression,
9186 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9187 Use a different way to cause a compilation error if anyone uses
9188 n rather than nn, a way that does not involve shadowing.
73366a00 9189 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9190
29a6015a
PE
9191 * deps.mk (unexalpha.o): Remove; unused.
9192
43cfc33e 9193 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9194 * unexec.h: New file.
ce701a33
PE
9195 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9196 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9197 Depend on unexec.h.
9198 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9199 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9200 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9201 Change as necessary to match prototype in unexec.h.
ce701a33 9202
01f44d5a
PE
9203 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9204 shadowing.
4f63c6bb 9205 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9206
a6670b0b
PE
9207 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9208 Rename locals to avoid shadowing.
9209
cef2010d 9210 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9211 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9212
d4d7173a
PE
9213 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9214
f08b802a
PE
9215 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9216 warning when compiling print.c.
9217
3ddb0639
PE
9218 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9219 instead of using an uninitialized var.
5ad03b97 9220 (font_sort_entities): Mark var as initialized.
3ddb0639 9221
170a2692
PE
9222 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9223
e663c700
PE
9224 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9225 pointers to constants.
89bc529a 9226 (font_parse_fcname): Remove unused vars.
7b81e2d0 9227 (font_delete_unmatched): Now static.
ea838e10 9228 (font_get_spec): Remove; unused.
13a547c6
PE
9229 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9230 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9231 Rename or move locals to avoid shadowing.
e663c700 9232
2a80c887 9233 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9234 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9235
1384fa33 9236 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9237 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9238
8b2c52e9
PE
9239 * alloc.c (mark_backtrace): Move decl from here ...
9240 * lisp.h: ... to here, so that it can be checked.
9241
475545b5 9242 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9243 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9244 (lisp_indirect_variable): Name an expression,
9245 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9246 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9247
b1349114 9248 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9249 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9250 Use const pointer when appropriate.
b1349114 9251
a2928364
PE
9252 * lisp.h (get_system_name, get_operating_system_release):
9253 Move decls here, to check interfaces.
9254 * process.c (get_operating_system_release): Move decl to lisp.h.
9255 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9256 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9257 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9258 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9259 (Fformat_time_string, Fencode_time, Finsert_char):
9260 (Ftranslate_region_internal, Fformat):
9261 Rename or remove local vars to avoid shadowing.
9710023e 9262 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9263
a415e694
PE
9264 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9265 avoid shadowing.
9266
8ef4622d
PE
9267 * lisp.h (eassert): Check that the argument compiles, even if
9268 ENABLE_CHECKING is not defined.
9269
946f9a5b
PE
9270 * data.c (Findirect_variable): Name an expression, to avoid
9271 gcc -Wbad-function-cast warning.
112396d6 9272 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9273 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9274 (Fmake_variable_buffer_local, Fmake_local_variable):
9275 Mark variables as initialized.
52746918 9276 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9277
e5aab7e7 9278 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9279 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9280 Rename locals to avoid shadowing.
dff45157
PE
9281 (mark_stack): Move local variables into the #ifdef region where
9282 they're used.
7bc26fdb
PE
9283 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9284 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9285 needed otherwise.
9286 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9287 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9288 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9289
e5aab7e7
PE
9290 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9291 avoids undefined behavior in theory.
9292
4da60324
PE
9293 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9294
88043301
PE
9295 Use functions, not macros, for up- and down-casing (Bug#8254).
9296 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9297 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9298 to use the following functions instead of these macros.
9299 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9300 EMACS_INT, since callers assume the returned value fits in int.
9301 (upcase1): Likewise, for UPCASE_TABLE.
9302 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9303 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9304 the race-condition problem in the old DOWNCASE.
88043301 9305
19ed5445
PE
9306 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9307 Rename locals to avoid shadowing.
9308 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9309 (regex_compile, re_search_2, re_match_2_internal):
9310 Remove unused local vars.
952db0d7
PE
9311 (FREE_VAR): Rewrite so as not to use empty "else",
9312 which gcc can warn about.
da053e48 9313 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9314 (RETALLOC_IF): Define only if needed.
9315 (WORDCHAR_P): Likewise. This one is never needed, but is used
9316 only in a comment talking about a compiler bug, so put inside
9317 the #if 0 of that comment.
9318 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9319 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9320 Remove; unused.
19ed5445 9321
1f3561e4 9322 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9323 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9324 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9325
ded6f8f7
PE
9326 * search.c (simple_search): Remove unused var.
9327
dbd37a95
PE
9328 * dired.c (compile_pattern): Move decl from here ...
9329 * lisp.h: ... to here, so that it can be checked.
9330 (struct re_registers): New forward decl.
9331
7e47afad
PE
9332 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9333
85f24f61
PE
9334 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9335 All uses changed.
9336 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9337 Rename locals to avoid shadowing.
5671df8f 9338 (Fvertical_motion): Mark locals as initialized.
85f24f61 9339
181aa2be 9340 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9341 (casify_region): Mark local as initialized.
181aa2be 9342
930d429c
PE
9343 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9344
7082eac6
PE
9345 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9346 New macros, so that the caller can use some names other than
9347 gcpro1, gcpro2, etc.
9348 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9349 of the new macros.
9350 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9351 argument, for consistency with GCPRO2_VAR, etc: it is now the
9352 prefix of the variable, not the variable itself. All uses
9353 changed.
38b2c076
PE
9354 * dired.c (directory_files_internal, file_name_completion):
9355 Rename locals to avoid shadowing.
9356
15206ed9
PE
9357 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9358 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9359 dired.c's scmp function, had undefined behavior.
9360 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9361 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9362 * buffer.h: ... to here, because these macros use current_buffer,
9363 and the new implementation with inline functions needs to have
9364 current_buffer in scope now, rather than later when the macros
9365 are used.
9366 (downcase, upcase1): New static inline functions.
9367 (DOWNCASE, UPCASE1): Reimplement using these functions.
9368 This avoids undefined behavior in expressions like
9369 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9370 from race conditions in accessing the global variables
9371 case_temp1 and case_temp2.
9372 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9373 * lisp.h (case_temp1, case_temp2): Remove their decls.
9374 * character.h (ASCII_CHAR_P): Move from here ...
9375 * lisp.h: ... to here, so that the inline functions mentioned
9376 above can use them.
9377
4a6bea26
PE
9378 * dired.c (directory_files_internal_unwind): Now static.
9379
f14b7e14
PE
9380 * fileio.c (file_name_as_directory, directory_file_name):
9381 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9382 Now static.
2893f146
PE
9383 (file_name_as_directory): Use const pointers when appropriate.
9384 (Fexpand_file_name): Likewise. In particular, newdir might
9385 point at constant storage, so make it a const pointer.
fd4ead52 9386 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9387 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9388 signedness issues.
f839df0c
PE
9389 (Fset_file_times, Finsert_file_contents, auto_save_error):
9390 Rename locals to avoid shadowing.
f14b7e14 9391
5716756e 9392 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9393 (Ftry_completion, Fall_completions): Rename or remove locals
9394 to avoid shadowing.
5716756e 9395
b4c3046a
PE
9396 * marker.c (bytepos_to_charpos): Remove; unused.
9397
b45db522
PE
9398 * lisp.h (verify_bytepos, count_markers): New decls,
9399 so that gcc does not warn that these functions aren't declared.
9400
85876d07
PE
9401 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9402 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9403 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9404 (copy_text): Remove unused local var.
85876d07 9405
03d78a21 9406 * filelock.c (within_one_second): Now static.
b3dd38ab 9407 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9408
5df8f01b
PE
9409 * buffer.c (fix_overlays_before): Mark locals as initialized.
9410 (fix_start_end_in_overlays): Likewise. This function should be
9411 simplified by using pointers-to-pointers, but that's a different
9412 matter.
b1d876f1 9413 (switch_to_buffer_1): Now static.
8f54f30a
PE
9414 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9415 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9416
a70072c9 9417 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9418 Fix pointer signedness issue.
edced198
PE
9419 (sys_subshell): Mark local as volatile if checking for lint,
9420 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9421 (MAXPATHLEN): Define only if needed.
a70072c9 9422
a0977c44
PE
9423 * process.c (serial_open, serial_configure): Move decls from here ...
9424 * systty.h: ... to here, so that they can be checked.
9425
a884fdcc
PE
9426 * fns.c (get_random, seed_random): Move extern decls from here ...
9427 * lisp.h: ... to here, so that they can be checked.
9428
604efe86 9429 * sysdep.c (reset_io): Now static.
b8950c94 9430 (wait_for_termination_signal): Remove; unused.
604efe86 9431
38fc62d9
PE
9432 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9433 (copy_keymap_item, append_key, push_text_char_description):
9434 Now static.
1004a21a 9435 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9436 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9437 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9438 (describe_map_tree):
9439 Rename locals to avoid shadowing.
38fc62d9 9440
2f2650da
PE
9441 * keyboard.c: Declare functions static if they are not used elsewhere.
9442 (echo_char, echo_dash, cmd_error, top_level_2):
9443 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9444 (read_char, kbd_buffer_get_event, make_lispy_position):
9445 (make_lispy_event, make_lispy_movement, apply_modifiers):
9446 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9447 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9448 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9449 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9450 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9451
a053e86c 9452 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9453 (mark_kboards): Move decl here ...
9454 * alloc.c (mark_kboards): ... from here.
a053e86c 9455
4752793e
PE
9456 * lisp.h (force_auto_save_soon): New decl.
9457
74f10ca7 9458 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9459 (DEFINE_DUMMY_FUNCTION): New macro.
9460 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9461 Use it.
c03cd23f
PE
9462 (main): Add casts to avoid warnings
9463 if GCC considers string literals to be constants.
74f10ca7 9464
022e70d4
PE
9465 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9466
59d6fe83
PE
9467 * dbusbind.c: Pointer signedness fixes.
9468 (xd_signature, xd_append_arg, xd_initialize):
9469 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9470 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9471 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9472 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9473
78320123
PE
9474 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9475 if GCC considers string literals to be constants.
49cebcca 9476 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9477
35ac2a97
SM
94782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9479
fb103ca9
SM
9480 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9481 (print_preprocess, print_object): New macro to fix last change.
9482
35ac2a97
SM
9483 * print.c (print_preprocess): Don't forget font objects.
9484
62973b41
JB
94852011-03-16 Juanma Barranquero <lekktu@gmail.com>
9486
9487 * emacs.c (USAGE3): Doc fixes.
9488
0e48bb22
AS
94892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9490
9491 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9492 structure.
9493
7684e57b
JB
94942011-03-14 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * lisp.h (VWindow_system, Qfile_name_history):
9497 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9498 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9499 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9500
9501 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9502 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9503
9504 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9505 * w32console.c (detect_input_pending, read_input_pending)
9506 (encode_terminal_code):
9507 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9508 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9509 (w32_system_caret_y, Qfile_name_history):
9510 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9511 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9512 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9513 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9514 * w32proc.c (Qlocal, report_file_error):
9515 * w32term.c (Vwindow_system, updating_frame):
9516 * w32uniscribe.c (initialized, uniscribe_font_driver):
9517 Remove unneeded extern declarations.
9518
2aa46d6c
CY
95192011-03-14 Chong Yidong <cyd@stupidchicken.com>
9520
c96bbc66 9521 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9522
cffc6f3b
CY
95232011-03-13 Chong Yidong <cyd@stupidchicken.com>
9524
9525 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9526 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9527 These macros can no longer be used for assignment.
9528
44f230aa
SM
9529 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9530 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9531 (record_buffer_markers, fetch_buffer_markers): New functions for
9532 recording and fetching special buffer markers.
9533 (set_buffer_internal_1, set_buffer_temp): Use them.
9534
9535 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9536
9537 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9538
9539 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9540 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9541
9542 * xdisp.c (hscroll_window_tree):
9543 (reconsider_clip_changes): Use PT instead of BUF_PT.
9544
d251f04b
EZ
95452011-03-13 Eli Zaretskii <eliz@gnu.org>
9546
9547 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9548 $(EMACS_ROOT)/lib/intprops.h.
9549
f0c77cd1
PE
95502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9551
3eca4629
PE
9552 Fix more problems found by GCC 4.5.2's static checks.
9553
7c86ee98
PE
9554 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9555 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9556 (xg_free_frame_widgets): Make it clear that a local variable is
9557 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9558 (gdk_window_get_screen): Make it clear that this macro is needed
9559 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9560 (int_gtk_range_get_value): New function, which avoids a diagnostic
9561 from gcc -Wbad-function-cast.
9562 (xg_set_toolkit_scroll_bar_thumb): Use it.
9563 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9564 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9565 (get_utf8_string, xg_get_file_with_chooser):
9566 Rename locals to avoid shadowing.
9567 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9568
41729b81
PE
9569 * xgselect.c (xg_select): Remove unused var.
9570
f0c77cd1
PE
9571 * image.c (four_corners_best): Mark locals as initialized.
9572 (gif_load): Initialize transparent_p to zero (Bug#8238).
9573 Mark another local as initialized.
ec6cf4c6 9574 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9575
ce0ad53d 9576 * image.c (clear_image_cache): Now static.
d5d5a617 9577 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9578 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9579 (x_edge_detection): Remove unnecessary cast that
9580 gcc -Wbad-function-cast diagnoses.
2037898d 9581 (gif_load): Fix pointer signedness.
6ae141d6
PE
9582 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9583 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9584
33383987 95852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9586
d32df629
PE
9587 Improve quality of tests for time stamp overflow.
9588 For example, without this patch (encode-time 0 0 0 1 1
9589 1152921504606846976) returns the obviously-bogus value (-948597
9590 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9591 reports time overflow. See
9592 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9593 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9594 * editfns.c: Include limits.h and intprops.h.
9595 (TIME_T_MIN, TIME_T_MAX): New macros.
9596 (time_overflow): Move earlier, to before first use.
9597 (hi_time, lo_time): New functions, for an accurate test for
9598 out-of-range times.
9599 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9600 (Fget_internal_run_time): Don't assume time_t fits in int.
9601 (make_time): Use list2 instead of Fcons twice.
9602 (Fdecode_time): More accurate test for out-of-range times.
9603 (check_tm_member): New function.
9604 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9605 (lisp_time_argument): Don't rely on undefined left-shift and
9606 right-shift behavior when checking for time stamp overflow.
8be6f318 9607
fe31d94c
PE
9608 * editfns.c (time_overflow): New function, refactoring common code.
9609 (Fformat_time_string, Fdecode_time, Fencode_time):
9610 (Fcurrent_time_string): Use it.
9611
8be6f318
PE
9612 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9613 * dired.c (make_time): Move to ...
9614 * editfns.c (make_time): ... here.
9615 * systime.h: Note the move.
9616
09d9db2c 96172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9618
126bc0dc
YM
9619 * fringe.c (update_window_fringes): Remove unused variables.
9620
c47cbdfd
YM
9621 * unexmacosx.c (copy_data_segment): Also copy __got section.
9622 (Bug#8223)
9623
7ac80be9
EZ
96242011-03-12 Eli Zaretskii <eliz@gnu.org>
9625
c96bbc66 9626 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9627 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9628 Constify `char *' arguments and their references according to
9629 prototypes in tparam.h.
9630
ecb0f94d 9631 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9632
7ac80be9
EZ
9633 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9634 Adapt all references accordingly.
9635
9636 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9637
ef1fd07e
TT
96382011-03-11 Tom Tromey <tromey@redhat.com>
9639
9640 * buffer.c (syms_of_buffer): Remove obsolete comment.
9641
7ef4b50c
EZ
96422011-03-11 Eli Zaretskii <eliz@gnu.org>
9643
9644 * termhooks.h (encode_terminal_code): Declare prototype.
9645
9646 * msdos.c (encode_terminal_code): Don't declare prototype.
9647
9648 * term.c (encode_terminal_code): Now external again, used by
9649 w32console.c and msdos.c.
9650
44f230aa
SM
9651 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9652 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9653
4b1ec863 96542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9655
1714f52b 9656 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9657
4b1ec863
PE
9658 * fringe.c (update_window_fringes): Mark locals as initialized
9659 (Bug#8227).
9660 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9661
524c7aa6
PE
9662 * alloc.c (mark_fringe_data): Move decl from here ...
9663 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9664 to check its interface.
9665 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9666
a5c0af81 9667 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9668 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9669 (fontset_font): Mark local as initialized.
a9a06e0b 9670 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9671
b4716021
PE
9672 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9673
811e9bac 9674 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9675 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9676 (x_own_selection, Fx_disown_selection_internal): Rename locals
9677 to avoid shadowing.
9678 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9679
7e3ab302
PE
9680 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9681 so that the caller can use some name other than gcpro1.
9682 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9683 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9684 (Fx_backspace_delete_keys_p):
9685 Use them to avoid shadowing, and rename vars to avoid shadowing.
9686 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9687 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9688 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9689 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9690 Remove unused locals.
7e3ab302
PE
9691 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9692 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9693 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9694 macros.
f78faa98 9695
e2b13473
PE
9696 * xterm.h (x_mouse_leave): New decl.
9697
77f23912
PE
9698 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9699 Remove unused functions.
cdf4ba58
PE
9700 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9701 (x_calc_absolute_position): Now static.
7411c686 9702 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9703 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9704 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9705 unless they are used.
38d0b34a
PE
9706 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9707 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9708 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9709 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9710 (x_error_catcher, x_connection_closed, x_error_handler):
9711 (x_error_quitter, xembed_send_message, x_iconify_frame):
9712 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9713 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9714 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9715
44f230aa
SM
9716 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9717 Rename or move locals to avoid shadowing.
6b463e58 9718 (tty_defined_color, merge_face_heights): Now static.
5967d051 9719 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9720 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9721 does not deduce is never used uninitialized.
73719eba
PE
9722 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9723 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9724
426994c3 9725 * terminal.c (store_terminal_param): Now static.
5489860b 9726
032f1620 9727 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9728 (set_frame_menubar): Remove unused local.
d4323972 9729 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9730 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9731 since they might point to immutable storage.
281585b0
PE
9732 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9733 since it's unused otherwise.
032f1620 9734
367c19e5 9735 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9736 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9737 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9738 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9739 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9740 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9741 does not deduce are never used uninitialized.
70739cbe 9742
07b48fa9
PE
9743 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9744
8868a238 9745 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9746 * window.c (window_loop, size_window):
9747 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9748
7e5cf297 9749 * window.c (display_buffer): Now static.
d6550a9f
PE
9750 (size_window): Mark variables that gcc -Wuninitialized
9751 does not deduce are never used uninitialized.
a586633d
PE
9752 * window.h (check_all_windows): New decl, to forestall
9753 gcc -Wmissing-prototypes diagnostic.
5b555da1 9754 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9755
f6095868
PE
9756 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9757 shadowing.
9758 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9759 Include <limits.h>.
9760 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9761 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9762 (load_charset_map): Mark variables that gcc -Wuninitialized
9763 does not deduce are never used uninitialized.
53df7c11 9764 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9765
f38b440c
PE
9766 * coding.c (coding_set_source, coding_set_destination):
9767 Use "else { /* comment */ }" rather than "else /* comment */;"
9768 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9769 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9770 a block, when the outer 'i' will do.
9771 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9772 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9773 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9774 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9775 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9776 Rename locals to avoid shadowing.
9777 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9778 * coding.c (emacs_mule_char, encode_invocation_designation):
9779 Now static, since they're not used elsewhere.
413bb2db 9780 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9781 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9782 (decode_coding_emacs_mule): Mark variables that gcc
9783 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9784 (detect_coding_iso_2022): Initialize a local variable that might
9785 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9786 this initialization is needed. (Bug#8211)
5f58e762
PE
9787 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9788 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9789 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9790 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9791 Remove unused macros.
f38b440c 9792
232b38b9 9793 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9794 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9795 * character.c (string_count_byte8): Likewise.
232b38b9 9796
fb90da1b
PE
9797 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9798 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9799
fb93dbc2
PE
9800 * chartab.c (copy_sub_char_table): Now static, since it's not used
9801 elsewhere.
5c156ace
PE
9802 (sub_char_table_ref_and_range, char_table_ref_and_range):
9803 Rename locals to avoid shadowing.
bbcd0949 9804 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9805
7d3b3862 9806 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9807 (BIDI_BOB): Remove unused macro.
7d3b3862 9808
6be7d3da
PE
9809 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9810 deduce are never used uninitialized.
c2ed9c8b 9811 * term.c (encode_terminal_code): Likewise.
6be7d3da 9812
75f8807f 9813 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9814
50938595
PE
9815 * tparam.h: New file.
9816 * term.c, tparam.h: Include it.
9817 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9818 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9819 Move these decls to tparam.h, and make them agree with what
9820 is actually in tparam.c. The previous trick of using incompatible
9821 decls in different modules does not conform to the C standard.
9822 All callers of tparam changed to use tparam's actual API.
9823 * tparam.c (tparam1, tparam, tgoto):
9824 Use const pointers where appropriate.
9825
fbceeba2
PE
9826 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9827 * cm.h (struct cm): Likewise.
9828 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9829 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9830 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9831 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9832 (turn_on_face, init_tty): Likewise.
9833 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9834
7f3f1250
PE
9835 * term.c (term_mouse_position): Rename local to avoid shadowing.
9836
e6ca6543
PE
9837 * alloc.c (mark_ttys): Move decl from here ...
9838 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9839
c40f8d15
AS
98402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9841
9842 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9843
cfe0661d
JB
98442011-03-09 Juanma Barranquero <lekktu@gmail.com>
9845
9846 * search.c (compile_pattern_1): Remove argument regp, unused since
9847 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9848 (compile_pattern): Don't pass it.
9849
0afb4571
J
98502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9851
9852 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9853 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9854 for ! HAVE_GTK3.
9855 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9856
9857 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9858
9859 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9860 gdk_window_get_screen, gdk_window_get_geometry,
9861 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9862 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9863 (xg_get_pixbuf_from_pixmap): New function.
9864 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9865 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9866 Call xg_get_pixbuf_from_pixmap instead of
9867 gdk_pixbuf_get_from_drawable.
9868 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9869 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9870 (xg_check_special_colors): Use GtkStyleContext and its functions
9871 for HAVE_GTK3.
9872 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9873 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9874 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9875 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9876 Call gtk_widget_get_preferred_size.
0afb4571
J
9877 (xg_frame_resized): gdk_window_get_geometry only takes 5
9878 parameters.
44f230aa
SM
9879 (xg_win_to_widget, xg_event_is_for_menubar):
9880 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9881 (xg_set_widget_bg): New function.
9882 (delete_cb): New function.
895009e1 9883 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9884 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9885 (xg_set_background_color): Call xg_set_widget_bg.
9886 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9887 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9888 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9889 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9890 if ! HAVE_GTK3.
9891 (update_frame_tool_bar): Call gtk_widget_hide.
9892 (xg_initialize): Use GDK_KEY_g.
9893
9894 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9895 if ! HAVE_GTK3
9896 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9897
9898 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9899 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9900 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9901
1c2cc4ef
JB
99022011-03-08 Juanma Barranquero <lekktu@gmail.com>
9903
9904 * w32xfns.c (select_palette): Check success of RealizePalette against
9905 GDI_ERROR, not zero.
9906
33383987 9907See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9908
9909;; Local Variables:
9910;; coding: utf-8
aac0c6e3
MR
9911;; End:
9912
acaf905b 9913 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9914
9915 This file is part of GNU Emacs.
9916
9917 GNU Emacs is free software: you can redistribute it and/or modify
9918 it under the terms of the GNU General Public License as published by
9919 the Free Software Foundation, either version 3 of the License, or
9920 (at your option) any later version.
9921
9922 GNU Emacs is distributed in the hope that it will be useful,
9923 but WITHOUT ANY WARRANTY; without even the implied warranty of
9924 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9925 GNU General Public License for more details.
9926
9927 You should have received a copy of the GNU General Public License
9928 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.