Backport: Really fix bug #11519, by fixing the last change in ralloc.c.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c81b46f6
EZ
12012-06-23 Eli Zaretskii <eliz@gnu.org>
2
3 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4 in the logic of incrementing and decrementing the value of
5 use_relocatable_buffers.
6
63541ed8
GM
72012-06-21 Glenn Morris <rgm@gnu.org>
8
9 * charset.c (init_charset): Make lack of etc/charsets fatal.
10
50a93863
JD
112012-06-11 Jan Djärv <jan.h.d@swipnet.se>
12
13 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
14 referenced (Bug#11583).
15
94f0aa34
CY
162012-06-01 Chong Yidong <cyd@gnu.org>
17
18 * Version 24.1 released.
19
d5fd2c54
EZ
202012-05-30 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (handle_stop): Detect whether we have overlay strings
23 loaded by testing it->current.overlay_string_index to be
24 non-negative, instead of checking whether n_overlay_strings is
25 positive. (Bug#11587)
26
353c87f6
CY
272012-05-30 Chong Yidong <cyd@gnu.org>
28
29 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
30
31 * doc.c (Fsubstitute_command_keys): Doc fix.
32
a02ae4e5
EZ
332012-05-29 Eli Zaretskii <eliz@gnu.org>
34
35 * search.c (search_buffer): Remove calls to
36 r_alloc_inhibit_buffer_relocation, as it is now called by
37 maybe_unify_char, which was the cause of relocation of buffer text
38 in bug#11519.
39
291d430f
EZ
402012-05-23 Eli Zaretskii <eliz@gnu.org>
41
42 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
43 for the duration of call to load_charset, to avoid problems with
44 callers of maybe_unify_char that access buffer text through C
45 pointers.
46
47 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
48 decrement the inhibition flag, instead of just setting or
49 resetting it.
50
2f9b9adb
KB
512012-05-24 Ken Brown <kbrown@cornell.edu>
52
53 * callproc.c (Fcall_process): Restore a line that was accidentally
54 commented out in the 2011-02-13 change (bug#11547).
55
52c55cc7
EZ
562012-05-23 Eli Zaretskii <eliz@gnu.org>
57
58 * lisp.h [REL_ALLOC]: Add prototypes for external functions
59 defined on ralloc.c.
60
61 * buffer.c [REL_ALLOC]: Remove prototypes of
62 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
63 they are now on lisp.h.
64
65 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
66
67 * search.c (search_buffer): Use it to inhibit relocation of buffer
68 text while re_search_2 is doing its job, because re_search_2 is
69 passed C pointers to buffer text. (Bug#11519)
70
23415acf
EZ
712012-05-21 Eli Zaretskii <eliz@gnu.org>
72
73 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
74 Update value to 24.
75
44e27368
EZ
762012-05-19 Eli Zaretskii <eliz@gnu.org>
77
78 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
79 state after an additional call to move_it_in_display_line_to, keep
80 the values of it->max_ascent and it->max_descent found for the
81 entire line.
82 (pos_visible_p): Revert the comparison against bottom_y to what it
83 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
84 (Bug#11464)
85
ccbf309c
EZ
862012-05-15 Eli Zaretskii <eliz@gnu.org>
87
88 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
89
ac268e67
EZ
902012-05-13 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
93 already have overlays loaded.
94 (handle_single_display_spec): Before returning without displaying
95 fringe bitmap, synchronize the bidi iterator with the main display
96 iterator, by calling iterate_out_of_display_property.
97 (iterate_out_of_display_property): Detect buffer iteration by
98 testing that it->string is a Lisp string.
99 (get_next_display_element): When the current object is exhausted,
100 and there's something on it->stack, call set_iterator_to_next to
101 proceed with what's on the stack, instead of returning zero.
102 (set_iterator_to_next): If called at the end of a Lisp string,
103 proceed to consider_string_end without incrementing string
104 position. Don't increment display vector index past the end of
105 the display vector. (Bug#11417)
c8fb9dc6
EZ
106 (pos_visible_p): Don't report a position visible when move_it_to
107 stopped at the last line of window, which happens to be scanned
108 backwards by the bidi iteration. (Bug#11464)
ac268e67 109
82f9b393
EZ
1102012-05-11 Eli Zaretskii <eliz@gnu.org>
111
112 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
113 and right-margin display specs even if the spec is invalid or we
114 are on a TTY, and thus unable to display on the fringes. That's
115 because the text with the property will not be displayed anyway,
116 so we need to signal to the caller that this is a "replacing"
117 display spec. This fixes display when the spec is invalid or we
118 are on a TTY.
119
297834cd
PE
1202012-05-09 Paul Eggert <eggert@cs.ucla.edu>
121
122 * unexaix.c (make_hdr): Fix typo in prototype.
123 This bug broke the build on AIX. Problem reported by Gilles Pion.
124
0d887c7d
EZ
1252012-05-05 Eli Zaretskii <eliz@gnu.org>
126
127 * w32proc.c (new_child): Force Windows to reserve only 64KB of
128 stack for each reader_thread, instead of defaulting to 8MB
129 determined by the linker. This avoids failures in creating
130 subprocesses on Windows 7, see the discussion in this thread:
131 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
132
bf98199c
JM
1332012-05-02 Jim Meyering <meyering@redhat.com>
134
135 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
136
2fa85638
EZ
1372012-04-29 Eli Zaretskii <eliz@gnu.org>
138
139 * xdisp.c (pos_visible_p): If already at a newline from the
140 display string before the 'while' loop, don't walk back the glyphs
141 from it3.glyph_row. Solves assertion violation when the display
142 string begins with a newline (egg.el). (Bug#11367)
143
9be2fd9b
CY
1442012-04-24 Chong Yidong <cyd@gnu.org>
145
146 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
147
f0ee99a0
EZ
1482012-04-23 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (pos_visible_p): If the window start position is beyond
151 ZV, start the display from buffer beginning. Prevents assertion
152 violation in init_iterator when the minibuffer window is scrolled
153 via the scroll bar.
154
155 * window.c (window_scroll_pixel_based): Likewise.
156
9ec7751f
CY
1572012-04-23 Chong Yidong <cyd@gnu.org>
158
159 * keymap.c (where_is_internal): Doc fix (Bug#10872).
160
24c51a09
GM
1612012-04-20 Glenn Morris <rgm@gnu.org>
162
163 * fileio.c (Fcopy_file, Fset_file_selinux_context):
164 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
165
73055685
EZ
1662012-04-20 Eli Zaretskii <eliz@gnu.org>
167
168 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
169 overrun array limits of glyph row's used[] array. (Bug#11288)
170
f30d612a
CY
1712012-04-20 Chong Yidong <cyd@gnu.org>
172
173 * process.c (wait_reading_process_output): If EIO occurs on a pty,
174 set the status to "failed" and ensure that sentinel is run.
175
016a35df
GM
1762012-04-18 Glenn Morris <rgm@gnu.org>
177
178 * process.c (Fset_process_inherit_coding_system_flag)
179 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 180 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 181
20a68157
EZ
1822012-04-17 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (string_buffer_position_lim): Limit starting position to
185 BEGV.
186 (set_cursor_from_row): If called for a mode-line or header-line
187 row, return zero immediately.
188 (try_cursor_movement): If inside continuation line, don't back up
189 farther than the first row after the header line, if any. Don't
190 consider the header-line row as "partially visible", even if
191 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
192
ad3a2b41
AO
1932012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
194
195 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
196
e63c261b
CY
1972012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
198
199 * process.c (make_process):
200 * process.h: Add integer `gnutls_handshakes_tried' member to
201 process struct.
202
ad3a2b41
AO
203 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
204 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
205
206 * gnutls.c (gnutls_log_function2i): Convenience log function.
207 (emacs_gnutls_read): Use new log functions,
208 `gnutls_handshakes_tried' process member, and
209 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
210 attempts per process (connection).
211
e53357c4
EZ
2122012-04-09 Eli Zaretskii <eliz@gnu.org>
213
214 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
215 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
216
aff67c82
JD
2172012-04-09 Jan Djärv <jan.h.d@swipnet.se>
218
219 * nsterm.m (constrainFrameRect): Always constrain when there is only
220 one screen (Bug#10962).
221
2f8e16b2
EZ
2222012-04-06 Eli Zaretskii <eliz@gnu.org>
223
224 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
225 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
226 about subtle differences between FETCH_CHAR* and STRING_CHAR*
227 macros related to unification of CJK characters. For the details,
228 see the discussion following the message here:
229 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
230
3d439cd1
CY
2312012-04-04 Chong Yidong <cyd@gnu.org>
232
233 * keyboard.c (Vdelayed_warnings_list): Doc fix.
234
8bc53d00
EZ
2352012-04-01 Eli Zaretskii <eliz@gnu.org>
236
237 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
238 instead of alloca. (Bug#11138)
239
3b0512a3
AS
2402012-04-01 Andreas Schwab <schwab@linux-m68k.org>
241
242 * w32menu.c (is_simple_dialog): Properly check lisp types.
243 (Bug#11141)
244
8427ddd2
EZ
2452012-03-31 Eli Zaretskii <eliz@gnu.org>
246
979022ef
EZ
247 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
248 position we get to after a call to move_it_to fails the
249 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
250 only if we wind up in a string from display property. (Bug#11063)
251
a6b1c7cc
EZ
252 * window.c (Fdelete_other_windows_internal): Invalidate the row
253 and column information about mouse highlight, so that redisplay
254 restores it after reallocating the glyph matrices. (Bug#7464)
255
8427ddd2
EZ
256 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
257 string comes from a `display' text property, use the buffer
258 position of that property as if we actually saw that position in
259 the row's glyphs.
697ba24b
EZ
260 (move_it_by_lines): Remove the assertion that
261 "it->current_x == 0 && it->hpos == 0" which can be legitimately
262 violated when there's a before-string at the beginning of a line.
263 (Bug#11063)
8427ddd2 264
65a0a738
EZ
2652012-03-30 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (append_space_for_newline): If the default face was
268 remapped, use the remapped face for the appended newline.
269 (extend_face_to_end_of_line): Use the remapped default face for
270 extending the face to the end of the line.
271 (display_line): Call extend_face_to_end_of_line when the default
272 face was remapped. (Bug#11068)
273
581355cc
EZ
2742012-03-29 Eli Zaretskii <eliz@gnu.org>
275
276 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
277
e8fc049f
SM
2782012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
279
280 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
281
4fb9a543
GM
2822012-03-27 Glenn Morris <rgm@gnu.org>
283
284 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
285 Doc fixes.
286
679910f1
KH
2872012-03-26 Kenichi Handa <handa@m17n.org>
288
289 * dispextern.h (struct glyph): Fix previous change. Change the
290 bit length of glyphless.ch to 25 (Bug#11082).
291
90d49b7f
CY
2922012-03-26 Chong Yidong <cyd@gnu.org>
293
294 * keyboard.c (Vselection_inhibit_update_commands): New variable.
295 (command_loop_1): Use it; inhibit selection update for
296 handle-select-window too (Bug#8996).
297
f514f6f0
FP
2982012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
299
e8fc049f 300 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 301
bf43fa51
KH
3022012-03-25 Kenichi Handa <handa@m17n.org>
303
304 * dispextern.h (struct glyph): Change the bit length of
305 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
306
8a0c01dd
EZ
3072012-03-24 Eli Zaretskii <eliz@gnu.org>
308
309 * s/ms-w32.h (tzname): Include time.h before redirecting to
310 _tzname. Fixes the MSVC build. (Bug#9960)
311
7d1c3a76
AS
3122012-03-24 Andreas Schwab <schwab@linux-m68k.org>
313
8ed79523
AS
314 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
315 characters.
316
7d1c3a76
AS
317 * xterm.c (XTread_socket): Only modify handling_signal if
318 !SYNC_INPUT. (Bug#11080)
319
e99a9b8b
EZ
3202012-03-23 Eli Zaretskii <eliz@gnu.org>
321
322 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
323 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
324 when fetching a multibyte character consumes more bytes than
325 CHAR_BYTES returns, due to unification of CJK characters in
326 string_char. (Bug#11073)
327
5063c0e1
TN
3282012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
329
330 * process.c (wait_reading_process_output): Handle pty disconnect
331 by refraining from sending oneself a SIGCHLD (bug#10933).
332
9f851fbd
CY
3332012-03-22 Chong Yidong <cyd@gnu.org>
334
335 * dispextern.h (struct it): New member string_from_prefix_prop_p.
336
5063c0e1 337 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
338 Mark string as coming from a prefix property.
339 (handle_face_prop): Use default face for prefix strings (Bug#4281).
340 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
341
fb5b8aca
CY
3422012-03-21 Chong Yidong <cyd@gnu.org>
343
344 * xfaces.c (Vface_remapping_alist): Doc fix.
345
62356a1b
EZ
3462012-03-20 Eli Zaretskii <eliz@gnu.org>
347
348 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
349 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
350 Doc fixes.
62356a1b 351
025de85b
CY
3522012-03-20 Chong Yidong <cyd@gnu.org>
353
354 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
355 to reflect default non-nil value of redisplay-dont-pause.
356
4827f94e
KH
3572012-03-19 Kenichi Handa <handa@m17n.org>
358
359 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
360 it fit in a valid range (Bug#11003).
361
e50a24a2
EZ
3622012-03-18 Eli Zaretskii <eliz@gnu.org>
363
364 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
365 that is not from display property, accept the row as a "cursor
366 row" if one of the string's character has a non-nil `cursor'
367 property. Fixes cursor positioning when there are newlines in
368 overlay strings, e.g. in icomplete.el. (Bug#11035)
369
9af5ed87
PE
3702012-03-12 Paul Eggert <eggert@cs.ucla.edu>
371
372 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
373
d1f55f16
CY
3742012-03-12 Chong Yidong <cyd@gnu.org>
375
376 * eval.c (inhibit_lisp_code): Rename from
377 inhibit_window_configuration_change_hook; move from window.c.
378
379 * xfns.c (unwind_create_frame_1, Fx_create_frame):
380 * window.c (run_window_configuration_change_hook)
381 (syms_of_window): Callers changed.
382
66c5eebd
CY
3832012-03-11 Chong Yidong <cyd@gnu.org>
384
413df973
CY
385 * keymap.c (Fkey_description): Doc fix (Bug#9700).
386
66c5eebd
CY
387 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
388
1de11f56
CY
3892012-03-10 Chong Yidong <cyd@gnu.org>
390
391 * frame.c (other_visible_frames): Don't assume the selected frame
392 is visible (Bug#10955).
393
cae07000
SM
3942012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
395
396 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
397
89c94350
JD
3982012-03-08 Jan Djärv <jan.h.d@swipnet.se>
399
400 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
401 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
402 zero (Bug#10954).
403
999dd333
GM
4042012-03-03 Glenn Morris <rgm@gnu.org>
405
01a6dcc8 406 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 407
de0100f2
EZ
4082012-03-02 Eli Zaretskii <eliz@gnu.org>
409
410 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
411 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
412 (redisplay_window, next_element_from_string): Fix typos in
413 comments.
3e441275
EZ
414 (redisplay_window): Pass to move_it_vertically the margin in
415 pixels, not in screen lines.
de0100f2 416
96a72ee9
GM
4172012-03-02 Glenn Morris <rgm@gnu.org>
418
419 * buffer.c (buffer-list-update-hook): Doc fix.
420
312508d7
EZ
4212012-02-29 Eli Zaretskii <eliz@gnu.org>
422
423 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
424 push_it before setting up the iterator for the first overlay
425 string, even if we have an empty string loaded.
426 (next_overlay_string): If there's an empty string on the iterator
427 stack, pop the stack. (Bug#10903)
428
27f3c637
PE
4292012-02-25 Paul Eggert <eggert@cs.ucla.edu>
430
431 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
432 Suggested by Stefan Monnier in
433 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
434 * alloc.c (widen_to_Lisp_Object): New static function.
435 (mark_memory): Also mark Lisp_Objects by fetching pointer words
436 and widening them to Lisp_Objects. This would work even if
437 USE_LSB_TAG is defined and wide integers are used, which might
438 happen in a future version of Emacs.
439
3c9dfce6
CY
4402012-02-25 Chong Yidong <cyd@gnu.org>
441
fa74b241
CY
442 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
443 Doc fix.
444
3c9dfce6
CY
445 * xselect.c (Fx_selection_exists_p): Doc fix.
446 (x_clipboard_manager_save_all): Print an informative message
447 before saving to clipboard manager.
448
9486df08
CY
4492012-02-24 Chong Yidong <cyd@gnu.org>
450
451 * keyboard.c (process_special_events): Handle all X selection
452 requests in kbd_buffer, not just the next one (Bug#8869).
453
f01d3321
CY
4542012-02-23 Chong Yidong <cyd@gnu.org>
455
456 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
457 call when setting menu-bar-lines and tool-bar-lines parameters.
458 (unwind_create_frame_1): New helper function.
459
460 * window.c (inhibit_window_configuration_change_hook): New var.
461 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 462 (syms_of_window): Initialize it.
f01d3321 463
86b847b6
CY
4642012-02-22 Chong Yidong <cyd@gnu.org>
465
466 * xterm.c (x_draw_image_relief): Add missing type check for
467 Vtool_bar_button_margin (Bug#10743).
468
a59225b1
CY
4692012-02-21 Chong Yidong <cyd@gnu.org>
470
471 * fileio.c (Vfile_name_handler_alist): Doc fix.
472
473 * buffer.c (Fget_file_buffer): Protect against invalid file
474 handler return value.
475
310f5bd4
PE
4762012-02-20 Paul Eggert <eggert@cs.ucla.edu>
477
cb3a28cc
PE
478 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
479 when computing $valmask.
480
310f5bd4
PE
481 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
482 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
483 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
484 It's useless in that case, and it can cause problems on hosts
485 that allocate halves of EMACS_INT values separately.
486 Reported by Dan Horák. Diagnosed by Andreas Schwab in
487 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
488 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
489 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
490 it avoids undefined behavior on hosts where shifting right by more
491 than the word width has undefined behavior.
492
2375c96a
CY
4932012-02-19 Chong Yidong <cyd@gnu.org>
494
495 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
496 (Funhandled_file_name_directory, Ffile_name_as_directory)
497 (Fdirectory_file_name, Fexpand_file_name)
498 (Fsubstitute_in_file_name): Protect against invalid file handler
499 return values (Bug#10845).
500
3eb49e71
EZ
5012012-02-18 Eli Zaretskii <eliz@gnu.org>
502
503 * .gdbinit (pitx): Fix incorrect references to fields of the
504 iterator stack.
505
7b926f3f
CY
5062012-02-17 Chong Yidong <cyd@gnu.org>
507
508 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
509
11273115
PE
5102012-02-15 Paul Eggert <eggert@cs.ucla.edu>
511
512 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
513 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
514
c3a70e2b
CY
5152012-02-15 Chong Yidong <cyd@gnu.org>
516
517 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
518 marked as special. Also, starting docstrings with * is obsolete.
519
0ca43699
AS
5202012-02-13 Andreas Schwab <schwab@linux-m68k.org>
521
522 * gnutls.c (emacs_gnutls_write): Fix last change.
523
2e8f3c56
LI
5242012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
525
526 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
527 send_process.
528
af70074f
SM
5292012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
530
531 * keymap.c (Fsingle_key_description): Handle char ranges.
532
95986d52
CY
5332012-02-12 Chong Yidong <cyd@gnu.org>
534
afd83bd1
CY
535 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
536 as that creates a dangerous corner case.
537
95986d52
CY
538 * window.c (Fdelete_window_internal): Invalidate the mouse
539 highlight (Bug#9904).
540
bd7da63e
GM
5412012-02-12 Glenn Morris <rgm@gnu.org>
542
543 * xselect.c (Fx_own_selection_internal)
544 (Fx_get_selection_internal, Fx_disown_selection_internal)
545 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
546 * nsselect.m (Fx_own_selection_internal)
547 (Fx_disown_selection_internal, Fx_selection_exists_p)
548 (Fx_selection_owner_p, Fx_get_selection_internal):
549 Sync docs and argument specs with the xselect.c versions.
550
77abcbc2
LI
5512012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
552
553 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
554
90b671e2
EZ
5552012-02-11 Eli Zaretskii <eliz@gnu.org>
556
1c0ca0b7
EZ
557 * w32select.c (Fx_selection_exists_p): Sync doc string and
558 argument list with xselect.c. (Bug#10783)
559
560 * w16select.c (Fx_selection_exists_p): Sync doc string and
561 argument list with xselect.c. (Bug#10783)
90b671e2 562
49241268
GM
5632012-02-10 Glenn Morris <rgm@gnu.org>
564
565 * fns.c (Fsecure_hash): Doc fix.
566
f998bbe7 5672012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
568
569 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
570
0992bd9c
CY
5712012-02-07 Chong Yidong <cyd@gnu.org>
572
573 * buffer.c (Fbuffer_local_variables)
574 (buffer_lisp_local_variables): Handle unbound vars correctly;
575 don't let Qunbound leak into Lisp.
576
af008560
GM
5772012-02-07 Glenn Morris <rgm@gnu.org>
578
dd605cc4
GM
579 * image.c (Fimagemagick_types): Doc fix.
580
af008560
GM
581 * image.c (imagemagick-render-type): Change it from a lisp object
582 to an integer. Move the doc here from the lisp manual.
583 Treat all values not equal to 0 the same.
584
1449fa1d
CY
5852012-02-06 Chong Yidong <cyd@gnu.org>
586
587 * doc.c (store_function_docstring): Avoid applying docstring of
588 alias to base function (Bug#2603).
589
3723ec07
AS
5902012-02-04 Andreas Schwab <schwab@linux-m68k.org>
591
592 * .gdbinit (pp1, pv1): Remove redundant defines.
593 (pr): Use pp.
594
79c1cc1e
CY
5952012-02-04 Chong Yidong <cyd@gnu.org>
596
597 * nsterm.m: Declare a global (Bug#10694).
598
d7f29f8e
EZ
5992012-02-04 Eli Zaretskii <eliz@gnu.org>
600
cae07000
SM
601 * w32.c (get_emacs_configuration_options):
602 Include --enable-checking, if specified, in the return value.
d7f29f8e 603
3b95a6f9
MR
6042012-02-04 Martin Rudalics <rudalics@gmx.at>
605
606 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
607 after rounding frame sizes. (Bug#9723)
608
d6fa96a6
EZ
6092012-02-04 Eli Zaretskii <eliz@gnu.org>
610
611 * keyboard.c (adjust_point_for_property): Don't position point
612 before BEGV. (Bug#10696)
613
df0b2940
PE
6142012-02-03 Paul Eggert <eggert@cs.ucla.edu>
615
616 Handle overflow when computing char display width (Bug#9496).
617 * character.c (char_width): Return EMACS_INT, not int.
618 (char_width, c_string_width): Check for overflow when
619 computing the width; this is possible now that individual
620 characters can have unbounded width. Problem introduced
621 by merge from Emacs 23 on 2012-01-19.
622
6bee44d6
MA
6232012-02-02 Michael Albinus <michael.albinus@gmx.de>
624
625 * dbusbind.c (Fdbus_register_method): Mention the return value
626 :ignore in the docstring.
627
44f92739
GM
6282012-02-02 Glenn Morris <rgm@gnu.org>
629
1b9f60cc
GM
630 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
631
44f92739
GM
632 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
633 Unconditionally set to t. (Bug#10673)
634 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
635 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
636 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
637
c5d3843c
KH
6382012-02-02 Kenichi Handa <handa@m17n.org>
639
640 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
641 0, do not call append_composite_glyph.
642
159462d4 6432012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
644
645 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
646 NULL (Bug#6988).
647 (x_produce_glyphs): If the component of a composition is a null
648 string, set it->pixel_width to 1 to avoid zero-width glyph.
649
78cef877
EZ
6502012-02-01 Eli Zaretskii <eliz@gnu.org>
651
652 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
653 first 2 arguments are identical. This makes inserting large
654 output from a subprocess an order of magnitude faster on
655 MS-Windows, where all sbrk'ed memory is always contiguous.
656
97897668
GM
6572012-01-31 Glenn Morris <rgm@gnu.org>
658
659 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 660 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
661 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
662
31fd3586
GM
6632012-01-29 Glenn Morris <rgm@gnu.org>
664
665 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
666
0e24a8b2
CY
6672012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
668
669 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
670
cc0adcb0
CY
6712012-01-28 Chong Yidong <cyd@gnu.org>
672
673 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
674
acc28cb9
CY
6752012-01-26 Chong Yidong <cyd@gnu.org>
676
9c69cfb7
CY
677 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
678
acc28cb9
CY
679 * search.c (Fsearch_forward, Fsearch_backward): Document negative
680 repeat counts (Bug#10507).
681
48da7392
GM
6822012-01-26 Glenn Morris <rgm@gnu.org>
683
684 * lread.c (syms_of_lread): Doc fix.
685
14af5f7f
CY
6862012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
687
688 * coding.c (encode_designation_at_bol): Change return value to
689 EMACS_INT.
690
0b21c100
CY
6912012-01-25 Chong Yidong <cyd@gnu.org>
692
693 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
694
3c2907f7
CY
6952012-01-21 Chong Yidong <cyd@gnu.org>
696
697 * floatfns.c (Fcopysign): Make the second argument non-optional,
698 since nil is not allowed anyway.
699
959ad23f
AS
7002012-01-21 Andreas Schwab <schwab@linux-m68k.org>
701
702 * process.c (read_process_output): Use p instead of XPROCESS (proc).
703 (send_process): Likewise.
704
34a02f46
MR
7052012-01-19 Martin Rudalics <rudalics@gmx.at>
706
707 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
708 (Vwindow_persistent_parameters): Do not use Qstate.
709 Rewrite doc-strings.
34a02f46 710
1259009a 7112012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
712
713 * character.c (char_width): New function.
70d4fdf6
GM
714 (Fchar_width, c_string_width, lisp_string_width):
715 Use char_width (Bug#9496).
25ed9e61 716
6a6ee00d
MR
7172012-01-16 Martin Rudalics <rudalics@gmx.at>
718
719 * window.c (Vwindow_persistent_parameters): New variable.
720 (Fset_window_configuration, save_window_save): Handle persistent
721 window parameters.
722
c85efaf7
EZ
7232012-01-14 Eli Zaretskii <eliz@gnu.org>
724
725 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
726 thrashing the stack of the thread. (Bug#9087)
727
5944709e
PE
7282012-01-12 Paul Eggert <eggert@cs.ucla.edu>
729
730 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
731
e71f5d99
EZ
7322012-01-11 Eli Zaretskii <eliz@gnu.org>
733
734 * xdisp.c (rows_from_pos_range): Handle the case where the
735 highlight ends on a newline. (Bug#10464)
736 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
737 he end column for display of highlight that ends on a newline
738 before a R2L line.
739
ce316182
GM
7402012-01-11 Glenn Morris <rgm@gnu.org>
741
742 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
743 from load-path also when installation-directory is nil. (Bug#10208)
744
5b43da69
GM
7452012-01-10 Glenn Morris <rgm@gnu.org>
746
74cc8ff9
GM
747 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
748
7d8d6e4e
GM
749 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
750 Update template values to be closer to their typical values these days.
5b43da69 751
a0db8d43
EZ
7522012-01-09 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (rows_from_pos_range): Accept additional argument
755 DISP_STRING, and accept any glyph in a row whose object is that
756 string as eligible for mouse highlight. Fixes mouse highlight of
757 display strings from overlays. (Bug#10464)
758
9a0115ab 7592012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 760
b9110d6a 761 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
762 * fileio.c (auto_saving_dir_umask): New static var.
763 (Fmake_directory_internal): Use it.
764 (do_auto_save_make_dir): Set it, instead of invoking chmod after
765 creating the directory. The old code temporarily assigns
766 too-generous permissions to the directory.
767 (do_auto_save_eh): Clear it.
b9110d6a 768 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
769 that the var is always cleared.
770
6c1bd3f3
EZ
7712012-01-07 Eli Zaretskii <eliz@gnu.org>
772
773 * search.c (scan_buffer): Pass character positions to
774 know_region_cache, not byte positions. (Bug#6540)
775
069d2b50
L
7762012-01-07 LynX <_LynX@bk.ru> (tiny change)
777
778 * w32.c (sys_rename): Report EXDEV when rename of a directory
779 fails because the target is on another logical disk. (Bug#10284)
780
75bf0d33
DB
7812012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
782
783 * xterm.c (x_embed_request_focus): New function.
784
785 * xterm.h: Add prototype.
786
787 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
788
1c6e5a32
GM
7892012-01-05 Glenn Morris <rgm@gnu.org>
790
791 * emacs.c (emacs_copyright): Update short copyright year to 2012.
792
651e947e
EZ
7932012-01-01 Eli Zaretskii <eliz@gnu.org>
794
795 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
796 Load gnutls_transport_set_lowat only if GnuTLS version is below
797 2.11.1.
798 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
799 GnuTLS versions below 2.11.1.
800
3778cdd8
AL
8012011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
802
803 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
804 to the doc string advising against its use for altering the way
805 windows are scrolled.
806
0e5317f7
KH
8072011-12-28 Kenichi Handa <handa@m17n.org>
808
809 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
810 coding-system ASCII compatible only when it does not produce BOM
811 on encoding (Bug#10383).
812
93d5ca1f
JD
8132011-12-26 Jan Djärv <jan.h.d@swipnet.se>
814
815 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
816 can scroll.
817 (create_and_show_popup_menu): Always use menu_position_func for
818 Gtk3 (Bug#10361).
819
ca22b785
AS
8202011-12-24 Andreas Schwab <schwab@linux-m68k.org>
821
822 * callint.c (Fcall_interactively): Don't truncate prompt string.
823
d048e1e6
EZ
8242011-12-23 Eli Zaretskii <eliz@gnu.org>
825
826 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
827 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 828 resumed from there (after widening). (Bug#10360)
d048e1e6 829
5ccaba1f
JD
8302011-12-22 Jan Djärv <jan.h.d@swipnet.se>
831
832 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
833
204ee57f
JD
8342011-12-21 Jan Djärv <jan.h.d@swipnet.se>
835
b81d40f0
JB
836 * nsterm.m (x_free_frame_resources):
837 Release f->output_data.ns->miniimage.
204ee57f
JD
838 (ns_index_color): Fix indentation. Do not retain
839 color_table->colors[i].
840
841 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
842 before returning.
843
844 * nsfns.m (x_set_background_color): Assign return value from
845 ns_index_color to face-background instead of NSColor*.
846 (ns_implicitly_set_icon_type): Fix indentation.
847 Change assignment in for loop to comparison.
848
849 * emacs.c (ns_pool): New variable.
850 (main): Assign ns_pool.
851 (Fkill_emacs): Call ns_release_autorelease_pool.
852
853 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
854 autorelease fdesc, release fdAttrs and tdict.
855 (ns_get_covering_families): Release charset.
856 (ns_findfonts): Release NSFontDescriptor created with new.
857 (ns_uni_to_glyphs): Fix indentation.
858 (setString): Release attrStr before assigning new value.
859
c803b2b7
JD
8602011-12-18 Jan Djärv <jan.h.d@swipnet.se>
861
678f4426
JD
862 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
863 and NS_IMPL_COCOA.
864 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
865 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
866
cd394be1 8672011-12-18 David Reitter <reitter@cmu.edu>
678f4426 868
5fecd5fc
JD
869 * nsterm.m (ns_term_init): Subscribe for notifications
870 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
871 to method trackingNotification in EmacsMenu.
872
873 * nsmenu.m (trackingMenu): New variable.
3771cb17 874 (trackingNotification): New method (from Aquamacs).
5fecd5fc 875 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 876 from Aquamacs (Bug#7030).
678f4426
JD
877
8782011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 879
c803b2b7
JD
880 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
881 (symbol_to_nsstring): Fix indentation.
882 (ns_symbol_to_pb): New function.
cae07000
SM
883 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
884 (Fns_rotate_cut_buffers_internal): Remove.
885 (Fns_store_selection_internal): Rename from
c803b2b7
JD
886 Fns_store_cut_buffer_internal.
887 (ns_get_foreign_selection, Fx_own_selection_internal)
888 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
889 (Fns_get_selection_internal, Fns_store_selection_internal):
890 Use ns_symbol_to_pb and check if return value is nil.
891 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
892 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
893 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
894 renamed to Sns_store_selection_internal.
895 (ns_handle_selection_request): Move code to Fx_own_selection_internal
896 and remove this function.
897 (ns_handle_selection_clear): Remove, never used.
898 (Fx_own_selection_internal): Move code from ns_handle_selection_request
899 here.
900
e1b01a3a
KB
9012011-12-17 Ken Brown <kbrown@cornell.edu>
902
903 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
904 GID is unknown (Bug#10257).
905
2adb6e85
PE
9062011-12-17 Paul Eggert <eggert@cs.ucla.edu>
907
908 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
909 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
910 which caused a build failure on GNU/Linux IA-64. This problem was
911 introduced by my 2011-10-07 patch.
912
d1d7b339
JL
9132011-12-15 Juri Linkov <juri@jurta.org>
914
915 * image.c (imagemagick_error): New function. (Bug#10112)
916 (imagemagick_load_image): Comment out `MagickSetResolution' call.
917 Use `imagemagick_error' where ImageMagick functions return
918 `MagickFalse'.
919 (Fimagemagick_types): Add `Fnreverse' to return the list in the
920 proper order.
921
100d5755
KH
9222011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
923
924 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
925 fill background (Bug#8992).
926
454592a6
MR
9272011-12-13 Martin Rudalics <rudalics@gmx.at>
928
929 * window.c (Vwindow_combination_resize)
930 (Vwindow_combination_limit): Use t instead of non-nil in
931 doc-strings.
61d4b438
MR
932 (Vrecenter_redisplay): Add first sentence of doc-string on
933 separate line.
53524d93 934 (Frecenter): Fix doc-string typo.
454592a6 935
3633e3aa
KH
9362011-12-11 Kenichi Handa <handa@m17n.org>
937
938 * coding.c (Funencodable_char_position): Pay attention to the
939 buffer text relocation (Bug#9389).
940
7b9d523a
JD
9412011-12-10 Jan Djärv <jan.h.d@swipnet.se>
942
943 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
944 gtk_init (Bug#10100).
945
b73189c6
EZ
9462011-12-10 Eli Zaretskii <eliz@gnu.org>
947
948 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
949 IT->string is nil. (Bug#10263)
950
f7dfe5d6
JD
9512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
952
83faebb4
JD
953 * nsterm.h (x_free_frame_resources): Declare.
954
f7dfe5d6
JD
955 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
956 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
957
958 * nsterm.h (ns_get_defaults_value): Declare.
959
960 * nsterm.m (ns_default): Call ns_get_defaults_value.
961
7cd4e72c
EZ
9622011-12-09 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
965 (Bug#10170)
966
b34d7317
YM
9672011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
968
969 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
970 that where the value of an _OBJC_* symbol points to is in the .bss
971 section (Bug#10240).
972
76470ad1
KH
9732011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
974
975 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 976 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 977
745fff94
KH
9782011-12-08 Kenichi Handa <handa@m17n.org>
979
980 * ftfont.c (get_adstyle_property): Fix previous change
981 (Bug#10233).
982
6e44397c
JB
9832011-12-07 Juanma Barranquero <lekktu@gmail.com>
984
985 * w32.c (init_environment): If no_site_lisp, remove site-lisp
986 dirs from the default value of EMACSLOADPATH (bug#10208).
987
7efa6272
GM
9882011-12-07 Glenn Morris <rgm@gnu.org>
989
990 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
991 installation and source directories as well. (Bug#10208)
992
f6fc4d87
CY
9932011-12-06 Chong Yidong <cyd@gnu.org>
994
995 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
996
2bf26180
GM
9972011-12-06 Glenn Morris <rgm@gnu.org>
998
999 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1000 as an error, not just -1. (Bug#10217)
1001
3a6ad4f0
CY
10022011-12-05 Chong Yidong <cyd@gnu.org>
1003
1004 * keyboard.c (process_special_events): New function.
1005 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1006
75a3b399
PE
10072011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 * coding.c (encode_designation_at_bol): Don't use uninitialized
1010 local variable (Bug#9318).
1011
c3c9e25e
KH
10122011-12-05 Kenichi Handa <handa@m17n.org>
1013
1014 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1015 return Qnil (Bug#8046, Bug#10193).
1016
5eb05ea3
KH
10172011-12-05 Kenichi Handa <handa@m17n.org>
1018
1019 * coding.c (encode_designation_at_bol): New args charbuf_end and
1020 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1021 (coding_set_source): Return how many bytes coding->source was
1022 relocated.
1023 (coding_set_destination): Return how many bytes
1024 coding->destination was relocated.
1025 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1026 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1027
10282011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1029
1030 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1031 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1032 macro (Bug#9318).
1033
10342011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1035
1036 The following changes are to fix Bug#9318.
1037
a79703f5 1038 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1039 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1040 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1041 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1042
7dbda6df
JB
10432011-12-05 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * lisp.h (process_quit_flag): Fix external declaration.
1046
6d5eb5b0
SM
10472011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 Don't macro-inline non-performance-critical code.
1050 * eval.c (process_quit_flag): New function.
1051 * lisp.h (QUIT): Use it.
1052
a0c3fad0
JD
10532011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1054
1055 * nsfns.m (get_geometry_from_preferences): New function.
1056 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1057
6c07aac2
AS
10582011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1059
1060 * emacs.c (Qkill_emacs): Define.
1061 (syms_of_emacs): Initialize it.
1062 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1063 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1064 (quit_throw_to_read_char): Add parameter `from_signal'.
1065 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1066 * lisp.h (QUIT): Call Fkill_emacs if requested.
1067
c052ead4
JD
10682011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1069
1070 * widget.c (update_wm_hints): Return if wmshell is null.
1071 (widget_update_wm_size_hints): New function.
1072
1073 * widget.h (widget_update_wm_size_hints): Declare.
1074
1075 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1076 widget_update_wm_size_hints (Bug#10104).
1077
9e49252b
EZ
10782011-12-03 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1081 before a newline, prepare the bidi iterator for consuming the
1082 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1083 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1084
02b16839
JL
10852011-12-02 Juri Linkov <juri@jurta.org>
1086
1087 * search.c (Fword_search_regexp): New Lisp function created from
1088 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1089 (Fword_search_backward, Fword_search_forward)
1090 (Fword_search_backward_lax, Fword_search_forward_lax):
1091 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1092 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1093
0068070e
SM
10942011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1095
1096 * fileio.c (Finsert_file_contents): Move after-change-function call
1097 to before the "handled:" label, since all "goto handled" appear in
1098 cases where the *-change-functions have already been properly called
1099 (bug#10117).
1100
3360a3fc
AS
11012011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1102
1103 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1104 waiting for input. (Bug#10169)
1105
73d6c093
EZ
11062011-11-30 Eli Zaretskii <eliz@gnu.org>
1107
1108 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1109 verifies glyph row's hash code--we have just reallocated the
1110 glyphs, so their contents can be complete garbage. (Bug#10164)
1111
febe6bea
JB
11122011-11-30 Juanma Barranquero <lekktu@gmail.com>
1113
1114 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1115
801a4313
EZ
11162011-11-30 Eli Zaretskii <eliz@gnu.org>
1117
1118 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1119 attributes are tested _before_ calling verify_row_hash, to protect
1120 against GCC re-ordering of the tests. (Bug#10164)
1121
2b56b87e
JD
11222011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1123
1124 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1125
1126 * xterm.c (handle_one_xevent): Only set async_visible and friends
1127 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1128 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1129 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1130
dbf31225
PE
11312011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1134 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1135 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1136 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1137 All uses changed to use GCPRO1 etc.
1138 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1139 Revert to old implementation (i.e., before 2011-03-11).
1140
1305621b
YM
11412011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1142
1143 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1144 of scroll runs so as to avoid assigning disabled bogus rows and
1145 unnecessary graphics copy operations.
1146
8c9afb46
EZ
11472011-11-27 Eli Zaretskii <eliz@gnu.org>
1148
1149 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1150 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1151 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1152 (malloc, free, realloc, calloc): Redirect to e_* only when
1153 compiling Emacs.
1154
1155 * lisp.h (GCTYPEBITS): Move before first use.
1156 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1157 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1158 this macro definition.
1159
1160 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1161 _MSC_VER.
1162
54e9e3bf
JD
11632011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1164
6d5eb5b0
SM
1165 * gtkutil.c (xg_create_frame_widgets):
1166 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1167 present with Gtk+ 2.0.
1168
83aca1cb
PE
11692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * fileio.c (Finsert_file_contents): Undo previous change; see
1172 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1173
5b76caa4
PE
11742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 Rename locals to avoid shadowing.
1177 * fileio.c (Finsert_file_contents):
1178 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1179 * process.c (wait_reading_process_output):
1180 Rename inner 'proc' to 'p' to avoid shadowing.
1181 Indent for consistency with usual Emacs style.
1182
8c535114
EZ
11832011-11-25 Eli Zaretskii <eliz@gnu.org>
1184
1185 * xdisp.c (redisplay_window): If cursor row is not fully visible
1186 after recentering, and scroll-conservatively is set to a large
1187 number, scroll window by a few more lines to make the cursor fully
1188 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1189 (start_display): Don't move to the next line if the display should
1190 start at a newline that is part of a display vector or an overlay
1191 string. (Bug#10119)
8c535114 1192
fa4fdb5c
JL
11932011-11-24 Juri Linkov <juri@jurta.org>
1194
1195 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1196 after the `MagickPingImage' call. (Bug#10112)
1197
90ec88df
CY
11982011-11-23 Chong Yidong <cyd@gnu.org>
1199
1200 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1201
56e2e794
MR
12022011-11-23 Martin Rudalics <rudalics@gmx.at>
1203
1204 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1205 making another buffer current. (Bug#10114)
1206
b6e64c41
GM
12072011-11-23 Glenn Morris <rgm@gnu.org>
1208
1209 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1210
6b21de18
CY
12112011-11-23 Chong Yidong <cyd@gnu.org>
1212
1213 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1214 using it (Bug#5984).
1215
b12cd789
EZ
12162011-11-22 Eli Zaretskii <eliz@gnu.org>
1217
1218 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1219 and header-lines, as they don't have one computed for them.
1220 (Bug#10098)
1221
1222 * .gdbinit (prow): Make displayed values more self-explaining.
1223 Add row's hash code.
1224
261b6fd4
LMI
12252011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1226
1227 * process.c (wait_reading_process_output): Fix asynchrounous
1228 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1229 (wait_reading_process_output): Add comment and URL.
261b6fd4 1230
e7cfd277
JD
12312011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1232
1233 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1234
a9b9b7f5
CY
12352011-11-21 Chong Yidong <cyd@gnu.org>
1236
1237 * window.c (Fnext_window, Fprevious_window): Doc fix.
1238
b0d15b4f
SM
12392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1242
fe7a3057
JB
12432011-11-20 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1246
d2999b1a
MR
12472011-11-20 Martin Rudalics <rudalics@gmx.at>
1248
1249 * window.c (Fset_window_combination_limit): Rename argument
1250 STATUS to LIMIT.
1251 (Vwindow_combination_limit): Remove "status" from doc-string.
1252
d5ff9cd0
AS
12532011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1254
1255 * m/ibms390.h: Remove.
1256 * m/ibms390x.h: Don't include "ibms390.h".
1257
a5bb9bd3
SM
12582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1259
1260 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1261 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1262
cd1181db
JB
12632011-11-20 Juanma Barranquero <lekktu@gmail.com>
1264
1265 * casetab.c (Fset_case_table):
1266 * charset.c (Fcharset_after): Fix typos.
1267
615a3b8d 12682011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1269
17e845af
PE
1270 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1271 Otherwise, valgrind does not work on some platforms.
1272 Problem reported by Andreas Schwab in
6a0bf43d
PE
1273 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1274 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1275 is set, removing the need for VIRT_ADDRESS_VARIES.
1276 (PURE_P): Use a more-efficient implementation that needs just one
1277 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1278 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1279 to 4 (xorl, subq, cmpq, setbe).
1280 * alloc.c (pure): Always extern now, since that's the
1281 VIRT_ADDR_VARIES behavior.
1282 (PURE_POINTER_P): Use a single comparison, not two, for
1283 consistency with the new puresize.h.
1284 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1285 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1286 Remove VIRT_ADDR_VARIES no longer needed.
1287
f8fe6f96
EZ
12882011-11-19 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1291 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1292 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1293 behave as if the cursor position were at the window margin.
1294
1295 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1296 and the cursor position is out of bounds, behave as if the cursor
1297 position were at the window margin. (Bug#10075)
1298
df05a53c
CY
12992011-11-18 Chong Yidong <cyd@gnu.org>
1300
1301 * window.c (Fwindow_combination_limit): Make first argument
1302 non-optional, since it is meaningless for live windows like the
1303 selected window.
1304
2071918e
DA
13052011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1308
b50a28de
SM
13092011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1310
1311 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1312 (graft_intervals_into_buffer): Simplify.
1313
015137db
EZ
13142011-11-18 Eli Zaretskii <eliz@gnu.org>
1315
1316 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1317 hash values of the two rows.
1318 (copy_row_except_pointers): Preserve the used[] arrays and the
1319 hash values of the two rows. (Bug#10035)
68c95424 1320 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1321
1322 * xdisp.c (row_hash): New function, body extracted from
1323 compute_line_metrics.
1324 (compute_line_metrics): Call row_hash, instead of computing the
1325 hash code inline.
1326
1327 * dispnew.c (verify_row_hash): Call row_hash for computing the
1328 hash code of a row, instead of duplicating code from xdisp.c.
1329
1330 * dispextern.h (row_hash): Add prototype.
1331
a2addb04
TH
13322011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1333
1334 * frame.c (delete_frame): Don't delete the terminal when the last
1335 X frame is closed if emacs is built with GTK toolkit.
1336
df85d315
JB
13372011-11-17 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1340
a0c2d0ae
MR
13412011-11-17 Martin Rudalics <rudalics@gmx.at>
1342
1343 * window.c (Vwindow_splits): Rename to
1344 Vwindow_combination_resize. Suggested by Juri Linkov.
1345 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1346 of Vwindow_splits.
1347
58179cce
JB
13482011-11-16 Juanma Barranquero <lekktu@gmail.com>
1349
7877f373
JB
1350 * nsfns.m (Fns_font_name):
1351 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1352
b6f67890
MR
13532011-11-16 Martin Rudalics <rudalics@gmx.at>
1354
1355 * window.h (window): Rename slot "nest" to "combination_limit".
1356 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1357 (Fset_window_nest): Rename to Fset_window_combination_limit.
1358 (Vwindow_nest): Rename to Vwindow_combination_limit.
1359 (recombine_windows, make_parent_window, make_window)
1360 (Fsplit_window_internal, saved_window)
1361 (Fset_window_configuration, save_window_save): Rename all
1362 occurrences of window_nest to window_combination_limit.
1363
c7015153
JB
13642011-11-15 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * image.c (imagemagick_load_image): Fix typo.
1367
322ad6ec
EZ
13682011-11-14 Eli Zaretskii <eliz@gnu.org>
1369
1370 * xdisp.c (display_line): Move the call to
1371 highlight_trailing_whitespace before the call to
1372 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1373 faces of all the glyphs to compute ROW's hash value.
1374 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1375
f067b8ec
JB
13762011-11-14 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1379 just return (bug#10044).
1380
1e5b2111
EZ
13812011-11-12 Eli Zaretskii <eliz@gnu.org>
1382
7ef3cbd5
EZ
1383 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1384 with user-defined heap size. Bump the default size of the temacs
1385 heap to 27MB, to avoid memory warning when running temacs.
1386 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1387
1e5b2111
EZ
1388 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1389 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1390 (verify_row_hash) [XASSERTS]: New function.
1391 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1392 that the hash value of glyph rows is correct.
1e5b2111 1393
89d61221
MR
13942011-11-12 Martin Rudalics <rudalics@gmx.at>
1395
1396 * window.h (window): Remove splits slot.
1397 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1398 (Fdelete_other_windows_internal, make_parent_window)
1399 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1400 (Fset_window_configuration, save_window_save): Don't deal with
1401 split status of windows.
1402 (saved_window): Remove splits slot.
1403 (Vwindow_splits): Rewrite doc-string.
1404
97f18cc8
JD
14052011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1406
1407 * xfns.c (unwind_create_frame):
1408 * nsfns.m (unwind_create_frame):
1409 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1410 Vframe_list (Bug#9999).
1411
22a648b4
DA
14122011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1413
0b381c7e 1414 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1415
659afede
KH
14162011-11-11 Kenichi Handa <handa@m17n.org>
1417
1418 * callproc.c (Fcall_process): Set the member dst_multibyte of
1419 process_coding.
1420
9ac0394b
KH
14212011-11-11 Johan Bockgård <bojohan@gnu.org>
1422
1423 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1424 avoid a crash (bug#9496).
1425
2fbdc249
CY
14262011-11-09 Chong Yidong <cyd@gnu.org>
1427
1428 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1429 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1430
ac6b1f81
PE
14312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1434
09db192c
PE
14352011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Avoid some portability problems by eschewing 'extern inline' functions.
1438 The trivial performance wins aren't worth the portability hassles; see
1439 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1440 et seq.
1441 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1442 (window_box_width, window_box_left, window_box_left_offset)
1443 (window_box_right, window_box_right_offset): Undo previous change,
1444 by removing the "extern"s.
1445 * intervals.c (adjust_intervals_for_insertion)
1446 (adjust_intervals_for_deletion): Undo previous change,
1447 making these static again.
1448 (offset_intervals, temp_set_point_both, temp_set_point)
1449 (copy_intervals_to_string): No longer inline.
1450 * xdisp.c (window_text_bottom_y, window_box_width)
1451 (window_box_height, window_box_left_offset)
1452 (window_box_right_offset, window_box_left, window_box_right)
1453 (window_box): No longer inline.
1454
105216ed
CY
14552011-11-08 Chong Yidong <cyd@gnu.org>
1456
1457 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1458 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1459 Signal an error if not a live window.
105216ed
CY
1460 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1461 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1462
ae9e237f
JB
14632011-11-07 Juanma Barranquero <lekktu@gmail.com>
1464
1465 * lisp.h (syms_of_abbrev): Remove declaration.
1466 Reported by CHENG Gao <chenggao@royau.me>.
1467
c7aa8333
EZ
14682011-11-07 Eli Zaretskii <eliz@gnu.org>
1469
1470 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1471 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1472 of temacs in GUI mode.
1473
be7f5545
MR
14742011-11-07 Martin Rudalics <rudalics@gmx.at>
1475
1476 * window.h: Declare delete_all_child_windows instead of
1477 delete_all_subwindows.
1478 * window.c (Fwindow_nest, Fset_window_nest)
1479 (Fset_window_new_total, Fset_window_new_normal)
1480 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1481 (delete_all_subwindows): Rename to delete_all_child_windows.
1482 (Fdelete_other_windows_internal, Fset_window_configuration):
1483 Call delete_all_child_windows instead of delete_all_subwindows.
1484 * frame.c (delete_frame): Call delete_all_child_windows instead
1485 of delete_all_subwindows.
1486
ca78dc43
PE
14872011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1488
1489 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1490 This is also needed for porting to any host where GC_MARK_STACK is
1491 not GC_MAKE_GCPROS_NOOPS.
1492 (which_symbols): Use it.
1493
a0241d01
KH
14942011-11-07 Kenichi Handa <handa@m17n.org>
1495
1496 * coding.c (coding_set_destination): Check coding->src_pos only
1497 when coding->src_object is a buffer (bug#9910).
1498
1499 * process.c (send_process): Set the member src_multibyte of coding
1500 to 0 (bug#9911) when sending a unibyte text.
1501
1502 * callproc.c (Fcall_process): Set the member src_multibyte of
1503 process_coding to 0 (bug#9912).
1504
a64bfdfa 15052011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1506
1507 * xmenu.c (cleanup_widget_value_tree): New function.
1508 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1509 calling free_menubar_widget_value_tree directly (Bug#9830).
1510
cb41b32a
PE
15112011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 Fix some portability problems with 'inline'.
1514 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1515 (window_box_width, window_box_left, window_box_left_offset)
1516 (window_box_right, window_box_right_offset): Declare extern.
1517 Otherwise, these inline functions do not conform to C99 and
1518 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1519 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1520 * intervals.c (adjust_intervals_for_insertion)
1521 (adjust_intervals_for_deletion): Now extern, because otherwise the
1522 extern inline functions 'offset_intervals' couldn't refer to it.
1523 (static_offset_intervals): Remove.
1524 (offset_intervals): Rewrite using the old contents of
1525 static_offset_intervals. The old version didn't conform to C99
1526 because an extern inline function contained a reference to an
1527 identifier with static linkage.
1528
b7041366
AS
15292011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1532 GC.
1533
88a37c4d
EZ
15342011-11-06 Eli Zaretskii <eliz@gnu.org>
1535
1536 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1537 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1538 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1539 return Qleft_to_right.
1540
49745b39
CY
15412011-11-06 Chong Yidong <cyd@gnu.org>
1542
1543 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1544 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1545 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1546 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1547 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1548 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1549 (Fwindow_vscroll): Doc fix.
1550 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1551 argument, since it makes no sense to pass a live window and for
1552 consistency with window-child.
1553
1f05cd82
CS
15542011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1555
1556 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1557 support MSVC.
1558
22610910
JR
15592011-11-05 Jason Rumney <jasonr@gnu.org>
1560
1561 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1562 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1563 fonts (Bug#6029).
1564 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1565 bitwise arithmetic preventing use of unicode-sip and non-truetype
1566 opentype fonts.
1567
a06776b2
EZ
15682011-11-05 Eli Zaretskii <eliz@gnu.org>
1569
3ad924ba
EZ
1570 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1571 "emacs"-only part.
1572
a06776b2
EZ
1573 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1574 initialization code to keep similarity to xfns.c after changes
1575 from 2011-11-05.
1576
c9e7db78
JD
15772011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1578
a97f8f3f
JD
1579 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1580 (unwind_create_frame): New function (Bug#9943).
1581 (Fx_create_frame): Restructure code to be more similar to the one in
1582 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1583 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1584 Move terminal->reference_count++ just before making the frame official
1585 (Bug#9943).
1586
1587 * nsterm.m (x_free_frame_resources): New function.
1588 (x_destroy_window): Move code to x_free_frame_resources.
1589
c9e7db78 1590 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1591 (Fx_create_frame, x_create_tip_frame):
1592 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1593 official. Move initialization of image_cache_refcount and
1594 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1595
a6fc3b5c
EZ
15962011-11-05 Eli Zaretskii <eliz@gnu.org>
1597
1598 Support MSVC build with newer versions of Visual Studio.
1599 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1600 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1601 nt/gmake.defs.
1602
1603 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1604 which are not supported by MSVC.
1605 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1606 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1607 bitfields.
1608 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1609 types in bitfields.
1610 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1611
1612 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1613
58179cce 16142011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1615
1616 Support MSVC build with newer versions of Visual Studio.
1617 * w32.c: Don't include w32api.h for MSVC.
1618 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1619
1620 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1621 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1622 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1623 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1624 e_* cousins.
1625 (alloca) [_MSC_VER]: Define to _alloca.
1626
1627 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1628
1629 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1630
a58c13ed
EZ
16312011-11-04 Eli Zaretskii <eliz@gnu.org>
1632
1633 * xdisp.c (note_mouse_highlight): If either of
1634 previous/next-single-property-change returns nil, treat that as
1635 the beginning or the end of the buffer. (Bug#9955)
1636
fe0b6370
JD
16372011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1638
a58c13ed 1639 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1640 label is not null (Bug#9951).
1641 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1642 may be NULL.
1643
89bd5ee1
EZ
16442011-11-04 Eli Zaretskii <eliz@gnu.org>
1645
1646 * window.c (Fwindow_body_size): Mention in the doc string that the
1647 return value is in frame's canonical units. (Bug#9949)
1648
84c3edb9
EZ
16492011-11-03 Eli Zaretskii <eliz@gnu.org>
1650
4e2fb5c7
EZ
1651 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1652
84c3edb9 1653 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1654 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1655 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1656
bc17a887
EZ
16572011-11-01 Eli Zaretskii <eliz@gnu.org>
1658
1659 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1660 Don't stop backward scan on the continuation glyph, even though
1661 its CHARPOS is positive.
6d5eb5b0
SM
1662 (mouse_face_from_buffer_pos, note_mouse_highlight):
1663 Rename cover_string to disp_string.
bc17a887 1664
4ee88440
MR
16652011-11-01 Martin Rudalics <rudalics@gmx.at>
1666
1667 * window.c (temp_output_buffer_show): Don't use
1668 Vtemp_buffer_show_specifiers.
1669 (Vtemp_buffer_show_specifiers): Remove unused variable.
1670
c2ff3c02
EZ
16712011-10-30 Eli Zaretskii <eliz@gnu.org>
1672
1673 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1674 past the beginning of the current glyph matrix.
1675
58179cce 16762011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1677
1678 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1679 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1680 HAVE_GTK3 (Bug#9869).
b77a6a7f 1681
3b574623
JD
1682 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1683 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1684
b77a6a7f
JD
1685 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1686
1687 * xterm.c: Declare x_handle_net_wm_state to return int.
1688 (handle_one_xevent): Check if we are iconified but don't have
1689 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1690 (get_current_wm_state): Return non-zero if not hidden,
1691 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1692 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1693 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1694 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1695
196e41e4
PE
16962011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1699 so that this new function doesn't get optimized away by a
1700 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1701
021f2e1a
AS
17022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1703
1704 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1705
8b058d44
EZ
17062011-10-29 Eli Zaretskii <eliz@gnu.org>
1707
1708 Fix the `xbytecode' command.
1709 * .gdbinit (xprintbytestr): New command.
b50a28de 1710 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1711 (xbytecode): Print the byte-code string as well.
1712
4452fb80
EZ
17132011-10-29 Kim Storm <storm@cua.dk>
1714
8b058d44
EZ
1715 * alloc.c (which_symbols): New function.
1716
21b72067
AS
17172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1718
1719 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1720 line. (Bug#9903)
1721
83ed7b5c
GM
17222011-10-29 Glenn Morris <rgm@gnu.org>
1723
1724 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1725 Not clear what it was for, and it causes various bugs. (Bug#9839)
1726
5a7a728b
EZ
17272011-10-28 Eli Zaretskii <eliz@gnu.org>
1728
1729 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1730 possible random value that matches one of those tested as
1731 condition to clear the mouse face.
1732
d3d0842f
CY
17332011-10-28 Chong Yidong <cyd@gnu.org>
1734
1735 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1736
31b39d13
DN
17372011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1738
1739 * window.c (make_window): Initialize phys_cursor_on_p.
1740
9aba6043
SM
17412011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1742
1743 * lisp.h (struct Lisp_Symbol): Update comments.
1744
c20992f4
JB
17452011-10-28 Juanma Barranquero <lekktu@gmail.com>
1746
1747 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1748
db4f02f2
EZ
17492011-10-28 Eli Zaretskii <eliz@gnu.org>
1750
1751 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1752 <oslsachem@gmail.com> for helping to debug this.
1753
1754 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1755 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1756 (g_b_init_get_glyph_outline_w): New static variables.
1757 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1758 (GetGlyphOutlineW_Proc): New typedefs.
1759 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1760 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1761 New functions.
1762 (w32font_open_internal, compute_metrics):
1763 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1764 instead of calling the "wide" APIs directly.
1765
1766 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1767
1768 * w32.h (syms_of_w32font): Add prototype.
1769
87e68db4
JB
17702011-10-27 Juanma Barranquero <lekktu@gmail.com>
1771
1772 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1773 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1774 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1775 (Fmove_to_window_line): Doc fix.
1776
435c1d67
CY
17772011-10-27 Chong Yidong <cyd@gnu.org>
1778
1779 * process.c (make_process): Set gnutls_state to NULL.
1780
1781 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1782 non-NULL, regardless of GNUTLS_INITSTAGE.
1783 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1784 an error. Set process slots as soon as we allocate them.
1785
1786 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1787
9c6c6f49
CY
17882011-10-27 Chong Yidong <cyd@gnu.org>
1789
9aba6043
SM
1790 * gnutls.c (emacs_gnutls_deinit): New function.
1791 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1792 (Fgnutls_deinit, Fgnutls_boot): Use it.
1793
1794 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1795 (deactivate_process): Call emacs_gnutls_deinit.
1796
657d08d3
JB
17972011-10-27 Juanma Barranquero <lekktu@gmail.com>
1798
1799 * image.c (x_create_x_image_and_pixmap):
1800 * w32.c (sys_rename, w32_delayed_load):
1801 * w32font.c (fill_in_logfont):
1802 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1803
5430d399
JB
18042011-10-26 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * w32fns.c (w32_default_color_map): New function,
1807 extracted from Fw32_default_color_map.
a7ef684b 1808 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1809
fe0055fa
PE
18102011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1813
e6346438
SM
18142011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1815
1816 * keyboard.c (test_undefined): New function (bug#9751).
1817 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1818
e112cc37
ET
18192011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1820
1821 * sysdep.c (init_sys_modes): Fix the check for the controlling
1822 terminal (Bug#6649).
1823
7b5d6677
EZ
18242011-10-20 Eli Zaretskii <eliz@gnu.org>
1825
1826 * dispextern.h (struct bidi_it): New member next_en_type.
1827
1828 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1829 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1830 current character, check also for next_en_type being WEAK_EN.
1831 (bidi_resolve_weak): Don't enter the expensive loop if the current
1832 position is before next_en_pos. Record the bidi type of the first
1833 non-ET, non-BN character we find, in addition to its position.
1834 (bidi_level_of_next_char): Invalidate next_en_type when
1835 next_en_pos is over-stepped.
1836
7da0b018
PE
18372011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1840 * editfns.c: Rewrite current-time-zone so that it invokes
1841 the equivalent of (format-time-string "%Z") to get the time zone name.
1842 This fixes a bug when the time zone name contains characters that
1843 need converting from the system time locale to Emacs internal format.
1844 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1845 that patch fixed format-time-string to do the conversion, but
1846 I forgot to fix current-time-zone.
1847 (format_time_string): New function, containing most of
1848 what Fformat_time_string used to contain.
1849 (Fformat_time_string): Rewrite in terms of format_time_string.
1850 This doesn't change this function's behavior.
1851 (current-time-zone): Rewrite to use format_time_string.
1852 This fixes the bug reported by Michael Schierl in
1853 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1854 Jason Rumney's 2007-06-07 change worked around this bug, but
1855 didn't fix it.
1856 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1857
8547b010
EZ
18582011-10-19 Eli Zaretskii <eliz@gnu.org>
1859
1860 * xdisp.c (start_display): If the character at POS is displayed
1861 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1862 (try_window_reusing_current_matrix): If a line ends in a display
1863 vector or the next line starts in a display vector, continue
1864 redrawing the window even though the character position of
1865 start_row was reached.
8547b010
EZ
1866 (Bug#9771, part 2)
1867
4e948d15
CY
18682011-10-18 Chong Yidong <cyd@gnu.org>
1869
1870 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1871 with nobreak-char-display too.
1872
4787455f
EZ
18732011-10-18 Eli Zaretskii <eliz@gnu.org>
1874
1875 Fix part 3 of bug#9771.
1876 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1877 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1878 non-neutral characters if the current character is a paragraph
1879 separator (a.k.a. Newline). This avoids running the same
1880 expensive loop twice, once when we consume the preceding newline
1881 and the other time when the line actually needs to be displayed.
1882 Avoid the loop when we see neutrals on the base embedding level
1883 following a character whose directionality is the same as the
1884 paragraph's. This avoids running the expensive loop when a line
1885 ends in a long sequence of neutrals, like control characters.
1886 Add assertion against STRONG_AL type. Slightly rearrange code
1887 that determines the type of a neutral given the first non-neutral
1888 that follows it.
1889 (bidi_level_of_next_char): Set next_en_pos to zero when
1890 invalidating its info.
1891
2c91f553
EZ
18922011-10-17 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (push_display_prop): Determine whether to record string
1895 or buffer position by IT->string, not by IT->method. Allow
1896 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1897 (move_it_vertically_backward): Don't look for character position
1898 immediately after the newline when in a continuation line.
1899 (Bug#9771, part 1)
2c91f553 1900
c7b08b0d
MR
19012011-10-15 Martin Rudalics <rudalics@gmx.at>
1902
1903 * window.c (coordinates_in_window): Rewrite and delabelize
1904 vertical border check. (Bug#5357) (Bug#9618)
1905
6b02f655
SM
19062011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1907
1908 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1909 errors in XSetWindowBorder (bug#9310).
1910
81d40c92
DA
19112011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1912
1913 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1914 avoid crash when xmalloc overrun checking is enabled.
1915
d4172c3b
EZ
19162011-10-13 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1919 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1920 cursor motion with <left> and <right> arrow keys.
1921
1922 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1923 some callers set that themselves.
1924
b00eea75
EZ
19252011-10-12 Eli Zaretskii <eliz@gnu.org>
1926
1927 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1928 display string and the previous row comes from the same string and
1929 is empty. (Bug#9739) (Bug#9738)
1930
8fe012c4
SM
19312011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1932
1933 * doc.c (get_doc_string): Encode file name (bug#9735).
1934
0074aef2
EZ
19352011-10-12 Eli Zaretskii <eliz@gnu.org>
1936
79beb178
EZ
1937 * bidi.c (bidi_level_of_next_char):
1938 * xdisp.c (get_visually_first_element): Remove old incorrect
1939 comments regarding the Unicode Line Separator character.
1940
0074aef2
EZ
1941 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1942
6e4b3fbe
DA
19432011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 * alloc.c (Fgc_status): Do not access beyond zombies array
1946 boundary if nzombies > MAX_ZOMBIES.
1947 * alloc.c (dump_zombies): Add missing format specifier.
1948
0324f3af
PE
19492011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1950
b5525cac
PE
1951 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1952 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1953
0324f3af
PE
1954 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1955 Some packages use them to denote characters with modifiers.
1956
e9b5f888
AS
19572011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1958
1959 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1960 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1961 matching a pp-number. Rename parameter var to var1.
1962
127827c0
SM
19632011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1964
1965 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1966
c8fd3bd0
GM
19672011-10-08 Glenn Morris <rgm@gnu.org>
1968
1969 * callint.c (Fcall_interactively): Give a more explicit error for the
1970 'c' case with a non-character input. (Bug#8479)
1971
352ec8ff
EZ
19722011-10-08 Eli Zaretskii <eliz@gnu.org>
1973
03669ccb
EZ
1974 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1975 lines.
7061c986
EZ
1976 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1977 lines that are hscrolled on the left.
03669ccb 1978
352ec8ff
EZ
1979 * dispnew.c (buffer_posn_from_coords): Account for a possible
1980 presence of header-line. (Bug#4426)
1981
a66cfb1c
SM
19822011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1983
6b02f655
SM
1984 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1985 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1986
7c5ee88e
PE
19872011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1988
1989 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1990 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1991 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1992 this makes Emacs dump core during garbage collection on rare
1993 occasions. sizeof is obviously inferior to offsetof here, so
1994 stick with offsetof.
1995 (GC_POINTER_ALIGNMENT): New macro.
1996 (mark_memory): Omit 3rd (offset) arg; caller changed.
1997 Don't assume EMACS_INT alignment is the same as pointer alignment.
1998
df1bbe5b
SM
19992011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2000
2001 * keyboard.c (read_key_sequence_remapped): New var.
2002 (read_key_sequence): Compute remapping in the right buffer.
2003 (command_loop_1): Use read_key_sequence's remapping directly.
2004
51553db6
SM
20052011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2006
32c1fffd
SM
2007 * dired.c (file_name_completion): Don't expand file name.
2008 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2009 before checking file name handler.
2010
51553db6
SM
2011 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2012 they've been requested explicitly (bug#9591).
2013
b6bd1599 20142011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2015
2016 * keymap.c (Fsingle_key_description): Use make_specified_string
2017 instead of build_string to build string from push_key_description.
2018 (Bug#5193)
2019
f701dc2a
PE
20202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2021
4222c55d
PE
2022 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2023 This fixes a Y2038 bug on 64-bit hosts.
2024 * buffer.c (reset_buffer):
2025 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2026 (Fclear_buffer_auto_save_failure):
2027 Use 0, not -1, to represent an unset failure time, since time_t
2028 might not be signed.
2029
f701dc2a
PE
2030 Remove dependency on glibc malloc internals.
2031 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2032 Move back here from lisp.h, but with their new implementations.
2033 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2034 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2035 * charset.c (charset_table_init): New static var.
2036 (syms_of_charset): Use it instead of xmalloc. This removes a
2037 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2038 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2039 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2040 Move back to alloc.c.
2041 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2042 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2043
9ceebf39
JD
20442011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2045
2046 * nsterm.m (windowDidResize): Call x_set_window_size only when
2047 ns_in_resize is true. Otherwise set pixelwidth/height and
2048 call change_frame_size (Bug#9628).
2049
cb993c58
PE
20502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2051
3930c88b
PE
2052 Port --enable-checking=all to Fedora 14 x86-64.
2053 * charset.c (syms_of_charset): Also account for glibc malloc's
2054 internal overhead when calculating the initial malloc maximum.
2055
cb993c58
PE
2056 Port --enable-checking=all to Fedora 14 x86.
2057 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2058 Move to lisp.h.
2059 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2060 (overrun_check_realloc, overrun_check_free):
2061 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2062 That way, xmalloc returns a properly-aligned pointer even if
2063 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2064 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2065 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2066 into account when calculating the initial malloc maximum.
2067 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2068 Move here from alloc.c, so that charset.c can use it too.
2069 Properly align; the old code wasn't right for common 32-bit hosts
2070 when configured with --enable-checking=all.
2071 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2072 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2073
31bed486
EZ
20742011-09-29 Eli Zaretskii <eliz@gnu.org>
2075
04c70788 2076 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2077 use EDOM.
2078
fbcaa2f3
EZ
20792011-09-28 Eli Zaretskii <eliz@gnu.org>
2080
2081 * xdisp.c (compute_display_string_end): If there's no display
2082 string at CHARPOS, return -1.
2083
2084 * bidi.c (bidi_fetch_char): When compute_display_string_end
2085 returns a negative value, treat the character as a normal
2086 character not covered by a display string. (Bug#9624)
2087
a239d4e9
JB
20882011-09-28 Juanma Barranquero <lekktu@gmail.com>
2089
2090 * lread.c (Fread_from_string): Fix typo in docstring.
2091
88652fd5
EZ
20922011-09-27 Eli Zaretskii <eliz@gnu.org>
2093
2094 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2095 newline, reseat the iterator instead of bidi-iterating there one
2096 character at a time. (Bug#9610)
32c1fffd
SM
2097 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2098 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2099
ed497dd4
AS
21002011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2101
2102 * lread.c (readevalloop): Use correct code for NBSP.
2103 (read1): Likewise. (Bug#9608)
2104
b2bf61aa
MA
21052011-09-25 Michael Albinus <michael.albinus@gmx.de>
2106
2107 * dbusbind.c (Fdbus_register_signal): When service is not
2108 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2109
32bbb17c
GM
21102011-09-25 Glenn Morris <rgm@gnu.org>
2111
2112 * buffer.c (truncate-lines): Doc fix.
2113
94e0933e
CY
21142011-09-24 Chong Yidong <cyd@stupidchicken.com>
2115
2116 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2117 (Fset_window_next_buffers): Doc fix.
2118
cddde921
GM
21192011-09-24 Glenn Morris <rgm@gnu.org>
2120
2121 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2122
1260aef1
PE
21232011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2124
25b4bfa0
PE
2125 Fix minor problems found by static checking.
2126 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2127 * indent.c (Fvertical_motion): Fix == vs = typo.
2128
e3cbd34b
EZ
21292011-09-24 Eli Zaretskii <eliz@gnu.org>
2130
a66cfb1c
SM
2131 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2132 Default value is now t. Doc fix.
6bf7006f 2133
e3cbd34b 2134 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2135 logic when moving up, not only when moving down. Fix the
e3cbd34b 2136 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2137 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2138
2139 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2140 CHARPOS is covered by a display string which includes newlines.
2141 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2142 is covered by a display string with embedded newlines.
2143
a3de0cbd
MA
21442011-09-24 Michael Albinus <michael.albinus@gmx.de>
2145
2146 * dbusbind.c (Fdbus_register_signal): Add match rule to
2147 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2148 (Fdbus_register_method, Vdbus_registered_objects_table):
2149 Fix docstring.
a3de0cbd 2150
b260039d
JM
21512011-09-24 Jim Meyering <meyering@redhat.com>
2152
32c1fffd 2153 do not ignore write error for any output size
b260039d
JM
2154 The previous change was incomplete.
2155 While it makes emacs --batch detect the vast majority of stdout
2156 write failures, errors were still ignored whenever the output size is
2157 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2158 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2159 && echo FAIL: ignored write error
2160 FAIL: ignored write error
2161 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2162 && echo FAIL: ignored write error
2163 FAIL: ignored write error
2164 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2165
8eca8a7c
AS
21662011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2167
2168 * emacs.c (Fkill_emacs): In noninteractive mode exit
2169 non-successfully if a write error occurred on stdout. (Bug#9574)
2170
3341db62
EZ
21712011-09-21 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2174 the xassert test.
2175
2176 * dispextern.h (struct it): Update the comment documenting what
2177 can it->OBJECT be.
2178
8c203dbf
EZ
21792011-09-20 Eli Zaretskii <eliz@gnu.org>
2180
2181 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2182 a display string, extend search for cursor position to end of row.
2183 (find_row_edges): If the row ends in a newline from a display
2184 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2185 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2186 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2187 non-empty line. Fixes confusing cursor motion with arrow keys at
2188 the beginning of a line that starts with whitespace.
8c203dbf 2189
a4824228
LMI
21902011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2191
2192 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2193 (bug#9493).
2194
33ed493b
CY
21952011-09-18 Chong Yidong <cyd@stupidchicken.com>
2196
2197 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2198 boolean (Bug#9154).
2199
56cd55c8
EZ
22002011-09-18 Eli Zaretskii <eliz@gnu.org>
2201
2202 * xdisp.c (display_line): Record maximum and minimum buffer
2203 positions even if no glyphs were produced (e.g., by a zero-width
2204 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2205 buffer positions that will be removed from the glyph row because
2206 they don't fit.
c02dcedf
EZ
2207 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2208 column is beyond frame width: don't subtract 1 "pixel" when
2209 computing width of the stretch.
3e62b7e0
EZ
2210 (reseat_at_next_visible_line_start): Undo the change made on
2211 2011-09-17 that saved paragraph information and restored it after
2212 the call to `reseat'. (Bug#9545)
56cd55c8 2213
5ed99d36 22142011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2215
2216 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2217 and turn window cursor on if cleared (Bug#9415).
2218
5ed99d36 22192011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2220
2221 * search.c (boyer_moore): Take unibyte characters from pattern
2222 literally. (Bug#9458)
2223
9bade7b2
EZ
22242011-09-18 Eli Zaretskii <eliz@gnu.org>
2225
2226 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2227
e5e9d610
PE
22282011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2229
87e4427a
PE
2230 Fix minor problem found by static checking.
2231 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2232 initialized, to pacify gcc -Wuninitialized.
2233
e5e9d610
PE
2234 * fileio.c: Report proper errno when syscall falls.
2235 (Finsert_file_contents): Save and restore errno,
2236 so that report_file_error outputs the correct diagnostic.
2237 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2238
a1674f0b
EZ
22392011-09-18 Eli Zaretskii <eliz@gnu.org>
2240
2241 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2242
fbfb6dd4
EZ
22432011-09-17 Eli Zaretskii <eliz@gnu.org>
2244
2245 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2246 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2247
bb187662
EZ
22482011-09-17 Eli Zaretskii <eliz@gnu.org>
2249
1137e8b8 2250 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2251 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2252
2253 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2254 (bidi_find_paragraph_start): Search back for paragraph beginning
2255 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2256 (bidi_move_to_visually_next): Only trigger paragraph-related
2257 computations when the last character is a newline or at EOB, not
2258 just any NEUTRAL_B. (Bug#9470)
2259
bb187662
EZ
2260 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2261 truncated lines if point is covered by a display string. (Bug#9524)
2262
2e621251
PE
22632011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2266 (cons_to_x_long): New function.
2267 (lisp_data_to_selection_data): Use it. Correct the test for
2268 short-versus-long data; it was negated. Break out of vector
2269 loop, for efficiency, when a long datum is discovered.
2270
91a15bc6
SM
22712011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2272
2273 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2274
b41c3a35
EZ
22752011-09-16 Eli Zaretskii <eliz@gnu.org>
2276
2277 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2278 GCC PR/17406) by declaring this function with external scope.
2279
7812ba2d
PE
22802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2283 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2284
cf7edc2a
AS
22852011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2286
2287 * editfns.c (Fformat): Correctly handle text properties on "%%".
2288
bd01620e
EZ
22892011-09-15 Eli Zaretskii <eliz@gnu.org>
2290
2291 * xterm.c (x_draw_composite_glyph_string_foreground):
2292 * w32term.c (x_draw_composite_glyph_string_foreground):
2293 * term.c (encode_terminal_code):
2294 * composite.c (composition_update_it, get_composition_id):
2295 * xdisp.c (get_next_display_element)
2296 (fill_composite_glyph_string): Add comments about special meaning
2297 of TAB characters in a composition.
2298
a02719a3
PE
22992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2302 This occurs when processing a multibyte format.
2303 Problem reported by Wolfgang Jenker.
a02719a3 2304
72589a3c
JB
23052011-09-15 Johan Bockgård <bojohan@gnu.org>
2306
2307 * xdisp.c (try_cursor_movement): Only check for exact match if
2308 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2309
1c14176c
PE
23102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 Remove unused external symbols.
2313 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2314 * xdisp.c (calc_pixel_width_or_height): Now static.
2315 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2316 * indent.c (check_display_width):
2317 * w32term.c: Fix comment to match code.
2318 * xterm.c, xterm.h (x_catching_errors): Remove.
2319
d2eea5b5
PE
23202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2321
2322 * xselect.c: Use signed conversions more consistently (Bug#9498).
2323 (selection_data_to_lisp_data): Assume incoming selection data are
2324 signed integers, not unsigned. This is to be consistent with
2325 outgoing selection data, which was modified to use signed integers
2326 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2327 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2328 expects long, not unsigned long.
2329
46888499
EZ
23302011-09-14 Eli Zaretskii <eliz@gnu.org>
2331
2332 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2333 computation of loop end. Reported by Johan Bockgård
2334 <bojohan@gnu.org>.
2335
ef8ef9fb
CY
23362011-09-13 Chong Yidong <cyd@stupidchicken.com>
2337
2338 * frame.c (Fother_visible_frames_p): Function deleted.
2339
fa819fed
EZ
23402011-09-12 Eli Zaretskii <eliz@gnu.org>
2341
2342 * indent.c (compute_motion): Process display vector front to back
2343 rather than the other way around. (Bug#2496)
2344
2ba8e008
SM
23452011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2346
2347 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2348
20f53c69
CY
23492011-09-11 Chong Yidong <cyd@stupidchicken.com>
2350
2351 * minibuf.c (Fread_from_minibuffer): Doc fix.
2352
d562d7a4
EZ
23532011-09-11 Eli Zaretskii <eliz@gnu.org>
2354
2355 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2356 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2357
1c4d7f3d
LMI
23582011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2359
2360 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2361 value for non-existent files.
2362
b885bf36
EZ
23632011-09-11 Eli Zaretskii <eliz@gnu.org>
2364
2365 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2366 set its "size" to -1. This will set the modtime_size field of
2367 the corresponding buffer to -1, which is what
2368 verify-visited-file-modtime expects for files that do not exist.
2369 (Bug#9139)
2370
6612f0bf
PE
23712011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2374 here ...
2375 * lisp.h: ... from here. push_key_description is no longer
2376 defined in keyboard.c, so its declaration should not be in
2377 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2378 logically belongs with push_key_description.
2379
dfb3f755
PE
23802011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 * buffer.h: Include <sys/types.h> instead of <time.h>.
2383 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2384 Problem reported by Herbert J. Skuhra.
2385
3134906c
LMI
23862011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2387
2388 * xml.c (parse_region): Make the parsing work for
2389 non-comment-starting XML files again (bug#9144).
2390
8d903f4e
AS
23912011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2392
2393 * image.c (gif_load): Fix calculation of bottom and right corner.
2394 (Bug#9468)
2395
80ad64f4
EZ
23962011-09-10 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2399 redisplay in small windows.
2400
208a048d
EZ
24012011-09-09 Eli Zaretskii <eliz@gnu.org>
2402
2403 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2404
9b1c252e
MR
24052011-09-08 Martin Rudalics <rudalics@gmx.at>
2406
2407 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2408 Operate on live windows only.
2409
2949f33b
JB
24102011-09-08 Juanma Barranquero <lekktu@gmail.com>
2411
2412 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2413
e08dcafd
EZ
24142011-09-07 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2417 only under bidi iteration.
2418
115b96bd
JD
24192011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2420
2421 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2422
c8199d0f
PE
24232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2426 Without this fix, the command to link temacs failed due to an
2427 undefined symbol __builtin_isnan. This is because
2428 /usr/include/iso/math_c99.h #defines isnan(x) to
2429 __builtin_isnan(x), but the bundled gcc, which identifies itself
2430 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2431 a __builtin_isnan.
2432 * floatfns.c (isnan): #undef, and then #define to a clone of
2433 what's in data.c.
2434 (Fisnan): Always define, since it's always available now.
2435 (syms_of_floatfns): Always define isnan at the Lisp level.
2436
e39b275c 24372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2438
2439 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2440
b2db44d9 24412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2442
f4af5137 2443 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2444 The previous code assumed that file offsets (off_t values) fit in
2445 EMACS_INT variables, which is not true on typical 32-bit hosts.
2446 The code messed up by falsely reporting buffer overflow in cases
2447 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2448 when "big" contains more than 2**29 bytes, even though this
2449 inserts just one byte and does not overflow the buffer.
2450 (Finsert_file_contents): Store file offsets as off_t
2451 values, not as EMACS_INT values. Check for overflow when
2452 converting between EMACS_INT and off_t. When checking for
2453 buffer overflow or for overlap, take the offsets into account.
2454 Don't use EMACS_INT for small values where int suffices.
2455 When checking for overlap, fix a typo: ZV was used where
2456 ZV_BYTE was intended.
2457 (Fwrite_region): Don't assume off_t fits into 'long'.
2458 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2459
ecfc0a49
MA
24602011-09-05 Michael Albinus <michael.albinus@gmx.de>
2461
2462 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2463
6511acf2 24642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2465
0999621a 2466 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2467
2468 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2469 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2470 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2471 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2472 (modify_event_symbol): Do not assume that the length of
2473 name_alist_or_stem is safe to alloca and fits in int.
2474 (Fexecute_extended_command): Likewise for function name and binding.
2475 (Frecursion_depth): Wrap around reliably on integer overflow.
2476 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2477 since some callers pass EMACS_INT values.
2478 (Fsingle_key_description): Don't crash if symbol name contains more
2479 than MAX_ALLOCA bytes.
2480 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2481 (get_minibuffer): Arg is now EMACS_INT, not int.
2482 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2483 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2484 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2485
2be7d702
PE
2486 * dbusbind.c (signature_cat): New function.
2487 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2488 Do not overrun buffer; instead, report string overflow.
2489
9d1df220
PE
2490 * dispnew.c (add_window_display_history): Don't overrun buffer.
2491 Truncate instead; this is OK since it's just a log.
2492
33ef5c64
PE
2493 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2494 even if the time zone offset is outlandishly large.
2495 Don't mishandle offset == INT_MIN.
2496
66c6fdd5
PE
2497 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2498 when creating daemon; the previous buffer-overflow check was incorrect.
2499
d749b01b
PE
2500 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2501 which has the guts of the old verror function.
2502
b5cd1905
PE
2503 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2504 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2505
6e1a67fb
PE
2506 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2507 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2508 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2509 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2510 length of string rather than counting it via multiple sprintfs;
2511 that's simpler and more reliable.
c21721cc
PE
2512 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2513 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2514 sprintf, in case result does not fit in int.
2515
c57b67fc
PE
2516 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2517 (fontset_from_font): Print it.
2518
8a401434
PE
2519 * frame.c (tty_frame_count): Now printmax_t, not int.
2520 (make_terminal_frame, set_term_frame_name): Print it.
2521 (x_report_frame_params): In X, window IDs are unsigned long,
2522 not signed long, so print them as unsigned.
2523 (validate_x_resource_name): Check for implausibly long names,
2524 and don't assume name length fits in 'int'.
2525 (x_get_resource_string): Don't blindly alloca invocation name;
2526 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2527 not fit in int.
2528
6e1a67fb
PE
2529 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2530 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2531 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2532
0df02bf3
PE
2533 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2534 Use esprintf, not sprintf, in case result does not fit in int.
2535
48e30793
PE
2536 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2537 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2538 it as a large positive number.
2539 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2540 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2541
a66ff6d8
PE
2542 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2543 in case result does not fit in int.
2544
aca216ff
PE
2545 * print.c (float_to_string): Detect width overflow more reliably.
2546 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2547 buffer overrun. Don't assume list length fits in 'int'. Treat
2548 print length of 0 as 0, not as infinity; to be consistent with other
2549 uses of print length in this function. Don't overflow print length
2550 index. Don't assume hash table size fits in 'long', or that
2551 vectorlike size fits in 'unsigned long'.
2552
31c286f7
PE
2553 * process.c (make_process): Use printmax_t, not int, to format
2554 process-name gensyms.
2555
55e5faa1
PE
2556 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2557
80f2e268
PE
2558 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2559 to avoid potential buffer overrun.
2560
670741ab
PE
2561 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2562 if X resource line is longer than 512 bytes.
2563
b7163a50
PE
2564 * xfns.c (x_window): Make sprintf buffer a bit bigger
2565 to avoid potential buffer overrun.
2566
ae58ff1f
PE
2567 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2568
c43c8a6a
PE
2569 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2570
3f8236f4
PE
25712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2572
53e9fe90 2573 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2574 Without these, Emacs silently mishandles large integers sometimes.
2575 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2576 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2577
6511acf2
PE
2578 * xdisp.c (try_window_id): Check Emacs fixnum range before
2579 converting to 'int'.
806add1d 2580
6511acf2 2581 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2582 Check that an Emacs fixnum is in range before assigning it to 'int'.
2583 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2584 values converted from Emacs fixnums.
2585 (Frecenter): Don't wrap around a line count if it is out of 'int'
2586 range; instead, treat it as an extreme value.
2587 (Fset_window_configuration, compare_window_configurations):
2588 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2589
6511acf2
PE
2590 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2591 that can exceed INT_MAX. Check that EMACS_INT value is in range
2592 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2593 (match_limit): Don't assume that a fixnum can fit in 'int'.
2594
6511acf2 2595 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2596 exceed INT_MAX.
2597
6511acf2 2598 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2599 (Fvertical_motion): Don't wrap around LINES values that don't fit
2600 in 'int'. Instead, treat them as extreme values. This is good
2601 enough for windows, which can't have more than INT_MAX lines anyway.
2602
fcb901a7
LMI
26032011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2604
0f2f6b6d
LMI
2605 * Require libxml/parser.h to avoid compilation warning.
2606
fcb901a7
LMI
2607 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2608
2609 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2610 since this reportedly can destroy thread storage.
2611
6e20a0d4
CY
26122011-08-30 Chong Yidong <cyd@stupidchicken.com>
2613
2614 * syntax.c (find_defun_start): Update all cache variables if
2615 exiting early (Bug#9401).
2616
148ae00e
EZ
26172011-08-30 Eli Zaretskii <eliz@gnu.org>
2618
f6cfbd8f
EZ
2619 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2620
148ae00e
EZ
2621 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2622 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2623 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2624
2625 * term.c (tty_append_glyph): New function.
2626 (produce_stretch_glyph): Static function and its prototype deleted.
2627
a66cfb1c
SM
2628 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2629 Add prototypes.
148ae00e 2630
c4a07a4c
PE
26312011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2632
2633 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2634 when checking :margin (Bug#9390).
2635 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2636 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2637 so that the name doesn't mislead. All uses changed.
2638
6bc8cd65
JB
26392011-08-28 Johan Bockgård <bojohan@gnu.org>
2640
2641 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2642 set_tty_hooks.
2643
dca4927e
EZ
26442011-08-27 Eli Zaretskii <eliz@gnu.org>
2645
2646 * xdisp.c (move_it_to): Don't bail out early when reaching
2647 position beyond to_charpos, if we are scanning backwards.
2648 (move_it_vertically_backward): When DY == 0, make sure we get to
2649 the first character in the line after the newline.
2650
f2cad773
PE
26512011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2652
2653 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2654 (ccl_driver): Do not generate an out-of-range pointer.
2655 (Fccl_execute_on_string): Remove unnecessary check for
2656 integer overflow, noted by Stefan Monnier in
2657 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2658 Remove a FIXME that didn't need fixing.
2659 Simplify the newly-introduced buffer reallocation code.
2660
0cae2cdb
JB
26612011-08-27 Juanma Barranquero <lekktu@gmail.com>
2662
2663 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2664
5fc295a4 26652011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2666
70c60eb2 2667 Integer and memory overflow issues (Bug#9196).
726e0ab1 2668
d31850da
PE
2669 * doc.c (get_doc_string): Rework so that
2670 get_doc_string_buffer_size is the actual buffer size, rather than
2671 being 1 less than the actual buffer size; this makes xpalloc more
2672 convenient.
2673
a69fbedb
PE
2674 * image.c (x_allocate_bitmap_record, cache_image):
2675 * xselect.c (Fx_register_dnd_atom):
2676 Simplify previous changes by using xpalloc.
2677
fe5c5d37
PE
2678 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2679 since either will do and ptrdiff_t is convenient with xpalloc.
2680
0065d054
PE
2681 * charset.c (charset_table_size)
2682 (struct charset_sort_data.priority): Now ptrdiff_t.
2683 (charset_compare): Don't overflow if priorities differ greatly.
2684 (Fsort_charsets): Don't assume list length fits in int.
2685 Check for size-calculation overflow when allocating sort data.
2686 (syms_of_charset): Allocate an initial charset table that is
2687 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2688
2689 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2690
2691 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2692 The actual value is always <= INT_MAX, and leaving it unsigned made
2693 overflow checking harder.
2694
2695 * dispextern.h (struct glyph_matrix.rows_allocated)
2696 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2697 with xpalloc. The values are still always <= INT_MAX.
2698
2699 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2700
2701 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2702 (SAFE_NALLOCA): New macro.
2703
2704 * region-cache.c (struct boundary.pos, find_cache_boundary)
2705 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2706 (set_cache_region, invalidate_region_cache)
2707 (revalidate_region_cache, know_region_cache, region_cache_forward)
2708 (region_cache_backward, pp_cache):
2709 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2710 so that ptrdiff_t * can be passed to xpalloc.
2711 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2712 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2713 (pp_cache): Don't assume cache_len fits in int.
2714 * region-cache.h: Adjust extern decls to match.
2715
2716 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2717 EMACS_INT, since either will do, for xpalloc.
2718
2719 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2720 (xnmalloc, xnrealloc, xpalloc): New functions.
2721
726e0ab1
PE
2722 * bidi.c (bidi_shelve_header_size): New constant.
2723 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2724 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2725
51f30bc5 2726 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2727 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2728 (overlay_strings):
2729 Don't update size of array until after memory allocation succeeds,
2730 because xmalloc/xrealloc may not return.
0065d054
PE
2731 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2732 now that we have proper integer overflow checking.
2733 (record_overlay_string, overlay_strings): Catch overflows when
2734 calculating size of overlay_str_buf.
726e0ab1 2735
0065d054
PE
2736 * callproc.c (Fcall_process): Check for size overflow when
2737 calculating size of args2.
2738 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2739 Normally we prefer signed values, but sticking with ptrdiff_t would
2740 require adding more-complicated checks.
726e0ab1
PE
2741
2742 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2743 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2744 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2745 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2746
2747 * character.c (Fstring): Check for size-calculation overflow.
2748
2749 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2750 unnecessary integer overflow. Check for size overflow.
2751 (encode_coding_object): Don't update size until xmalloc succeeds.
2752
2753 * composite.c (get_composition_id): Check for overflow in glyph
2754 length calculations.
2755
2756 Integer and memory overflow fixes for display code.
2757 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2758 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2759 (scrolling_window): Check for overflow in size calculations.
2760 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2761 Don't assume glyph table len fits in int.
2762 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2763 (row_table_size): Now ptrdiff_t, not int.
2764 (scrolling_window): Avoid overflow in size calculations.
2765 Don't update size until allocation succeeds.
2766 * fns.c (concat): Check for overflow in size calculations.
2767 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2768 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2769 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2770
2771 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2772 (get_doc_string): Check for size calculation overflow.
2773 Don't update size until allocation succeeds.
2774 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2775 EMACS_INT, where ptrdiff_t will do.
2776 (Fsubstitute_command_keys): Check for string overflow.
2777
2778 * editfns.c (set_time_zone_rule): Don't assume environment length
2779 fits in int.
2780 (message_length): Now ptrdiff_t, not int.
2781 (Fmessage_box): Don't update size until allocation succeeds.
2782 Don't assume message length fits in int.
2783 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2784
0065d054
PE
2785 * emacs.c (main): Do not reallocate argv, since there is a null at
2786 the end that can be overwritten, and this way there's no need to
2787 worry about size-calculation overflow.
2788 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2789
2790 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2791 alloc succeeds.
2792 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2793
2794 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2795 (x_set_scroll_bar_width, x_figure_window_size):
2796 Check for integer overflow.
2797 (x_set_alpha): Do not assume XINT fits in int.
2798
2799 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2800 This is for the members text_lines, text_cols, total_lines, total_cols,
2801 where the system imposes an 'int' limit.
2802
2803 * fringe.c (Fdefine_fringe_bitmap):
2804 Don't update size until alloc works.
2805
2806 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2807 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2808
2809 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2810 Check for size-calculation overflow.
2811 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2812 do, as we prefer signed integers.
2813 (id_to_widget.max_size, id_to_widget.used)
2814 (xg_store_widget_in_map, xg_remove_widget_from_map)
2815 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2816 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2817 Use and return ptrdiff_t, not int.
2818 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2819 * gtkutil.h: Change prototypes to match the above.
2820
2821 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2822 are duplicate now that they've been promoted to lisp.h.
2823 (x_allocate_bitmap_record, x_alloc_image_color)
2824 (make_image_cache, cache_image, xpm_load):
2825 Don't update size until alloc is done.
2826 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2827 (x_detect_edges):
3256efce 2828 Check for size calculation overflow.
726e0ab1
PE
2829 (ct_colors_allocated_max): New constant.
2830 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2831 overflow.
3256efce 2832
726e0ab1
PE
2833 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2834 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2835 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2836 Use ptrdiff_t, not int, to count maps.
2837 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2838 calculations. Don't update size until allocation succeeds.
2839 Redo calculations to avoid overflow.
726e0ab1
PE
2840 * keyboard.h: Change prototypes to match the above.
2841
2842 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2843 to count maps.
2844 (current_minor_maps): Check for size calculation overflow.
2845 * keymap.h: Change prototypes to match the above.
2846
2847 * lread.c (read1, init_obarray): Don't update size until alloc done.
2848
2849 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2850 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2851
726e0ab1
PE
2852 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2853 Now ptrdiff_t, not int.
2854 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2855 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2856
2857 * process.c (Fnetwork_interface_list): Check for overflow
2858 in size calculation.
2859
2860 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2861
2862 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2863 overflow. Don't bother calling xmalloc when xrealloc will do.
2864
2865 * search.c (Freplace_match): Check for size calculation overflow.
2866 (Fset_match_data): Don't assume list lengths fit in 'int'.
2867
2868 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2869 for command line length. Do not attempt to address one before the
2870 beginning of an array, as that's not portable.
2871
2872 * term.c (max_frame_lines): Remove; unused.
2873 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2874 not int.
2875 (encode_terminal_code, calculate_costs): Check for size
2876 calculation overflow.
2877 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2878 table lengths and related sizes. Don't update size until alloc
2879 done. Redo calculations to avoid overflow.
2880 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2881
2882 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2883 subtracting pointers.
2884 (gobble_line): Check for overflow more carefully. Don't update size
2885 until alloc done.
2886
2887 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2888 Don't update size until alloc done.
2889 Redo size calculations to avoid overflow.
2890 Check for size calculation overflow.
0065d054 2891 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2892
2893 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2894 Use ptrdiff_t, not int, for sizes.
2895 (store_mode_line_noprop_char): Don't update size until alloc done.
2896
0065d054
PE
2897 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2898 Use ptrdiff_t, not int, for sizes.
2899 (Finternal_make_lisp_face, cache_face):
2900 Check for size calculation overflow.
2901 (cache_face): Treat size calculation overflows as if they were
2902 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2903
2904 * xfns.c (x_encode_text, x_set_name_internal)
2905 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2906 sizes, since they can exceed INT_MAX in size. Check for size
2907 calculation overflow.
2908
0065d054
PE
2909 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2910 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2911 Don't update size until alloc done.
2912
0065d054 2913 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2914 as sprintf is limited to int lengths.
1d526e2f 2915
252c5ee1
PE
2916 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2917 (X_LONG_MIN): New macros.
864d7ce7
PE
2918 Use them to make the following changes clearer.
2919 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2920 This change doesn't affect the value now, but it may help remind
2921 future maintainers not to raise the value too much later.
2922 (SELECTION_QUANTUM): Remove, replacing with ...
2923 (selection_quantum): ... new function, which avoids overflow.
2924 All uses changed.
2925 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2926 assumption that selection length fits in 'int'.
2927 (x_reply_selection_request, x_handle_selection_request)
2928 (x_get_window_property, receive_incremental_selection)
2929 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2930 (lisp_data_to_selection_data, clean_local_selection_data):
2931 Use ptrdiff_t, not int, to record length of selection.
2932 (x_reply_selection_request, x_get_window_property)
2933 (receive_incremental_selection, x_property_data_to_lisp):
2934 Redo calculations to avoid overflow.
2935 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2936 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2937 something.
2938 (x_get_window_property, receive_incremental_selection)
2939 (lisp_data_to_selection_data, x_property_data_to_lisp):
2940 Check for size-calculation overflow.
2941 (x_get_window_property, receive_incremental_selection)
2942 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2943 Don't store size until memory allocation succeeds.
2944 (x_get_window_property): Plug memory leak on memory exhaustion.
2945 Don't double-block input; malloc is safe here. Don't assume 2**34
2946 - 4 fits in unsigned long. Add an xassert to check
2947 XGetWindowProperty overflow. Be more careful about overflow
2948 calculations, and distinguish size from memory overflow better.
2949 (receive_incremental_selection): When tracing, don't assume
2950 unsigned int is less than INT_MAX.
2951 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2952 harmful) conversions of unsigned short to int.
2953 (lisp_data_to_selection_data): Don't assume that integers
2954 in the range -65535 through -1 fit in an X unsigned short.
2955 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2956 result parameters unless successful. Rely on cons_to_unsigned
2957 to report problems with elements; the old code wasn't right anyway.
2958 (x_check_property_data): Check for int overflow; we cannot use
2959 a wider type due to X limits.
2960 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2961
726e0ab1 2962 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2963
0065d054
PE
2964 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2965 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2966 (x_color_cells): Don't store size until memory allocation succeeds.
2967 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2968 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2969 (x_term_init): Don't assume length fits in int (sprintf is limited
2970 to int size).
bc18e09d 2971
ebfa62c0
PE
2972 Use ptrdiff_t for composition IDs.
2973 * character.c (lisp_string_width):
2974 * composite.c (composition_table_size, n_compositions)
2975 (get_composition_id, composition_gstring_from_id):
2976 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2977 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2978 * window.c (Frecenter):
2979 Use ptrdiff_t, not int, for composition IDs.
2980 * composite.c (get_composition_id): Check for integer overflow.
2981 * composite.h: Adjust prototypes to match the above changes.
2982
d3411f89
PE
2983 Use ptrdiff_t for hash table indexes.
2984 * category.c (hash_get_category_set):
2985 * ccl.c (ccl_driver):
2986 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2987 * coding.c (coding_system_charset_list, detect_coding_system):
2988 * coding.h (struct coding_system.id):
2989 * composite.c (get_composition_id, gstring_lookup_cache):
2990 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2991 * image.c (xpm_get_color_table_h):
2992 * lisp.h (hash_lookup, hash_put):
2993 * minibuf.c (Ftest_completion):
2994 Use ptrdiff_t for hash table indexes, not int (which is too
2995 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2996 32-bit --with-wide-int hosts).
2997
e097a6fa
PE
2998 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2999 Add a FIXME comment about memory leaks.
3000 (syms_of_charset): Don't assume xmalloc returns.
3001
5637687f
PE
3002 Don't assume that stated character widths fit in int.
3003 * character.c (Fchar_width, c_string_width, lisp_string_width):
3004 * character.h (CHAR_WIDTH):
3005 * indent.c (MULTIBYTE_BYTES_WIDTH):
3006 Use sanitize_char_width to avoid undefined and/or bad behavior
3007 with outlandish widths.
a66cfb1c 3008 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3009 now that we have two such functions. All uses changed.
3010 (sanitize_char_width): New inline function.
3011
a2271ba2
PE
3012 Don't assume that tab-width fits in int.
3013 * character.h (sanitize_width): New inline function.
3014 (SANE_TAB_WIDTH): New macro.
3015 (ASCII_CHAR_WIDTH): Use it.
3016 * indent.c (sane_tab_width): Remove. All uses replaced by
3017 SANE_TAB_WIDTH (current_buffer).
3018 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3019
18c52557
PE
3020 * fileio.c: Integer overflow issues with file modes.
3021 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3022
caeeedc1
PE
3023 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3024 Remove unreachable code.
3025 (read_hex, load_charset_map_from_file): Check for integer overflow.
3026
6df6ae42 3027 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3028 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3029 (x_send_scroll_bar_event): Likewise. Check that the size does not
3030 exceed limits imposed by XClientMessageEvent, as well as the usual
3031 ptrdiff_t and size_t limits.
3032
b13995db
PE
3033 * keyboard.c: Overflow, signedness and related fixes.
3034 (make_lispy_movement): Use same integer type in forward decl
3035 that is used in the definition.
3036 (read_key_sequence, keyremap_step):
3037 Change bufsize argument back to int, undoing my 2011-03-30 change.
3038 We prefer signed types, and int is wide enough here.
3039 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3040 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3041 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3042 length, not size_t. Use ptrdiff_t for index, not int.
3043 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3044 possibility of integer overflow.
3045
13464394
PE
3046 Overflow, signedness and related fixes for images.
3047
3048 * dispextern.h (struct it.stack[0].u.image.image_id)
3049 (struct_it.image_id, struct image.id, struct image_cache.size)
3050 (struct image_cache.used, struct image_cache.ref_count):
3051 * gtkutil.c (update_frame_tool_bar):
3052 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3053 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3054 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3055 * nsmenu.m (update_frame_tool_bar):
3056 * xdisp.c (calc_pixel_width_or_height):
3057 * xfns.c (image_cache_refcount):
3058 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3059 on typical 64-bit hosts.
3060
3061 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3062 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3063 Omit unnecessary casts to int.
3064 (parse_image_spec): Check that integers fall into 'int' range
3065 when the callers expect that.
3066 (image_ascent): Redo ascent calculation to avoid int overflow.
3067 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3068 (lookup_image): Remove unnecessary tests.
3069 (xbm_image_p): Locals are now of int, not EMACS_INT,
3070 since parse_image_check makes sure they fit into int.
3071 (png_load, gif_load, svg_load_image):
3072 Prefer int to unsigned where either will do.
3073 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3074 old tiff_error_handler and tiff_warning_handler.
3075 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3076 stack buffer overflows. It uses only the features of vsnprintf
3077 that are common to both POSIX and native Microsoft.
3078 (tiff_error_handler, tiff_warning_handler): Use it.
3079 (tiff_load, gif_load, imagemagick_load_image):
3080 Don't assume :index value fits in 'int'.
3081 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3082 (imagemagick_load_image): Check that crop parameters fit into
3083 the integer types that MagickCropImage accepts. Don't assume
3084 Vimagemagick_render_type has a nonnegative value. Don't assume
3085 size_t fits in 'long'.
3086 (gs_load): Use printmax_t to print the widest integers possible.
3087 Check for integer overflow when computing image height and width.
3088
c11821d4
EZ
30892011-08-26 Eli Zaretskii <eliz@gnu.org>
3090
3091 * xdisp.c (redisplay_window): Don't force window start if point
3092 will be invisible in the resulting window. (Bug#9324)
3093
0c95fcf7
EZ
30942011-08-25 Eli Zaretskii <eliz@gnu.org>
3095
3096 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3097 the display spec is of the form `(space ...)'.
3098 (handle_display_spec): Return the value returned by
3099 handle_single_display_spec, not just 1 or zero.
3100 (handle_single_display_spec): If the display spec is of the form
3101 `(space ...)', and specifies display in the text area, return 2
3102 rather than 1.
fee65a97 3103 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3104 accurately, and prefer exact match for point under bidi.
3105 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3106
3107 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3108 into disp_prop; all users changed.
3109
3110 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3111 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3112 for the text covered by the display property.
3113
e4ed06f1
CY
31142011-08-25 Chong Yidong <cyd@stupidchicken.com>
3115
3116 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3117 Change return value to nil.
3118 (Frecord_buffer): Delete unused function.
3119
f67cdd7f
EZ
31202011-08-24 Eli Zaretskii <eliz@gnu.org>
3121
5980d4c6
EZ
3122 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3123 buffers, return left-to-right.
8610fe8b
EZ
3124 (set_cursor_from_row): Consider candidate row a win if its glyph
3125 represents a newline and point is on that newline. Fixes cursor
3126 positioning on the newline at EOL of R2L text within L2R
3127 paragraph, and vice versa.
3128 (try_cursor_movement): Check continued rows, in addition to
3129 continuation rows. Fixes unwarranted scroll when point enters a
3130 continued line of R2L text within an L2R paragraph, or vice versa.
3131 (cursor_row_p): Consider the case of point being equal to
3132 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3133 from the end of a short line to the beginning of a continued line
3134 of R2L text within L2R paragraph.
3135 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3136 composed characters.
5980d4c6 3137
f67cdd7f
EZ
3138 * bidi.c (bidi_check_type): Use xassert.
3139 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3140 members.
3141
bca633fb
EZ
31422011-08-23 Eli Zaretskii <eliz@gnu.org>
3143
3144 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3145 a character.
3146
4a5885a7
CY
31472011-08-23 Chong Yidong <cyd@stupidchicken.com>
3148
3149 * nsfont.m (ns_otf_to_script): Fix typo.
3150
0902a04e
KH
31512011-08-22 Kenichi Handa <handa@m17n.org>
3152
3153 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3154 extra slot even if the purpose is char-code-property-table.
3155
1a2e6670
EZ
31562011-08-23 Eli Zaretskii <eliz@gnu.org>
3157
8ddde651
EZ
3158 * xdisp.c (redisplay_window): When computing centering_position,
3159 account for the height of the header line. (Bug#8874)
3160
425cc014
EZ
3161 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3162 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3163 candidate is selected by the mouse, and that candidate has a
3164 composed character under the mouse.
3165
1a2e6670
EZ
3166 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3167 coordinates reported by pos-visible-in-window-p for a composed
3168 character in column zero.
3169
8b76d6f8
SM
31702011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3171
3172 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3173
dac347dd
EZ
31742011-08-22 Eli Zaretskii <eliz@gnu.org>
3175
3176 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3177 consider it a hit if to_charpos is anywhere in the range of the
3178 composed buffer positions.
3179
e013fb34
CY
31802011-08-22 Chong Yidong <cyd@stupidchicken.com>
3181
3182 * image.c (gif_load): Don't assume that each subimage has the same
3183 dimensions as the base image. Handle disposal method that is
3184 "undefined" by the gif spec (Bug#9335).
3185
bd1ba3e8
CY
31862011-08-20 Chong Yidong <cyd@stupidchicken.com>
3187
3188 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3189 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3190
54a1215b
EZ
31912011-08-19 Eli Zaretskii <eliz@gnu.org>
3192
823564e5
EZ
3193 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3194 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3195 from an Org mode buffer to a Speedbar frame.
3196
54a1215b
EZ
3197 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3198 a composition, take its buffer position from IT->cmp_it.charpos.
3199 Fixes cursor positioning at the beginning of a line that begins
3200 with a composed character.
3201
9778ebcc
EZ
32022011-08-18 Eli Zaretskii <eliz@gnu.org>
3203
0be6ee06
EZ
3204 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3205 character bidirectional type, use STRONG_L instead. Fixes crashes
3206 in a buffer produced by `describe-categories'.
3207
9778ebcc
EZ
3208 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3209 members before the level stack, so they would be saved and
3210 restored when copying iterator state. Fixes incorrect reordering
3211 around TABs covered by display properties.
3212
156bffbe
AS
32132011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3214
6b02f655 3215 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3216
72ad093b
CY
32172011-08-17 Chong Yidong <cyd@stupidchicken.com>
3218
3219 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3220 (internal_condition_case_2, internal_condition_case_n):
3221 Remove unnecessary aborts (Bug#9081).
72ad093b 3222
35774242
EZ
32232011-08-17 Eli Zaretskii <eliz@gnu.org>
3224
3225 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3226 has no `load' handler, try opening the file locally. (Bug#9311)
3227
db76dd85
KB
32282011-08-16 Ken Brown <kbrown@cornell.edu>
3229
3230 * gmalloc.c: Expand comment.
3231
b215eee5
EZ
32322011-08-16 Eli Zaretskii <eliz@gnu.org>
3233
3234 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3235 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3236
a4579d33
KB
32372011-08-16 Ken Brown <kbrown@cornell.edu>
3238
3239 Fix memory allocation problems in Cygwin build (Bug#9273).
3240
3241 * unexcw.c ( __malloc_initialized): Declare external variable.
3242 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3243
8b76d6f8
SM
3244 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3245 New variables.
a4579d33
KB
3246 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3247 dumped emacs.
3248 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3249 in the static heap.
3250 [CYGWIN] (special_realloc): New function.
3251 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3252 requests to realloc storage in the static heap.
3253
3ebec551
PE
32542011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 * bidi.c (bidi_initialize): Remove unused local.
3257
9fd8be00
EZ
32582011-08-15 Eli Zaretskii <eliz@gnu.org>
3259
6b02f655
SM
3260 * bidimirror.h:
3261 * biditype.h: Remove file.
3262 * makefile.w32-in ($(BLD)/bidi.$(O)):
3263 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3264
3265 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3266
3267 * chartab.c: Improve commentary for the uniprop_table API.
3268
32413314
EZ
3269 * bidi.c (bidi_paragraph_init): Support zero value of
3270 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3271 (bidi_initialize): Use uniprop_table instead of including
3272 biditype.h and bidimirror.h.
32413314 3273
9fd8be00
EZ
3274 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3275 coordinates of the iterator when restoring from ppos_it.
3276 (Bug#9296)
3277
5cf2b69b
KH
32782011-08-14 Kenichi Handa <handa@m17n.org>
3279
3280 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3281 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3282
daf17d00
EZ
32832011-08-14 Eli Zaretskii <eliz@gnu.org>
3284
3285 * xdisp.c (move_it_in_display_line_to): Don't invoke
3286 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3287 ppos_it. Fixes vertical cursor motion when line beginning is
3288 covered by an image. (Bug#9296)
3289
08e3161a
JD
32902011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3291
3292 * nsterm.h (ns_run_ascript): Declare.
3293 (NSAPP_DATA2_RUNASSCRIPT): Define.
3294
3295 * nsfns.m (as_script, as_result, as_status): New static variables.
3296 (ns_run_ascript): New function.
5e617bc2 3297 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3298 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3299 the event loop. Get status from as_status (Bug#7276).
3300
3301 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3302 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3303 the event loop (Bug#7276).
3304
a3720aa2
AS
33052011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3306
3307 * gnutls.c (QCgnutls_bootprop_priority)
3308 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3309 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3310 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3311 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3312 (QCgnutls_bootprop_verify_hostname_error)
3313 (QCgnutls_bootprop_callbacks_verify): Rename from
3314 Qgnutls_bootprop_..., all uses changed.
3315
3316 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3317 uses changed.
3318
0a0d27fb
PE
33192011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3320
19d5c50c
PE
3321 * xfaces.c (Qframe_set_background_mode): Now static.
3322 * dispextern.h (Qframe_set_background_mode): Remove decl.
3323
0a0d27fb
PE
3324 * process.c (Fnetwork_interface_info): Declare local only if needed.
3325
377538cb
JD
33262011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3327
3328 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3329 (Fnetwork_interface_list): Allocate in increments of bytes instead
3330 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3331 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3332 sockaddr.
3333 (struct ifflag_def): notrailers is smart on OSX.
3334 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3335 Get hardware address with getifaddrs if available.
3336
08fff70c
EZ
33372011-08-12 Eli Zaretskii <eliz@gnu.org>
3338
3339 * xdisp.c (iterate_out_of_display_property): xassert that
3340 IT->position is set to within IT->object's boundaries. Break from
3341 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3342 when IT->position is set up wrongly due to some bug.
3343 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3344 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3345 entry. Force push_it to save on the stack the current
3346 buffer/string position, to be restored by pop_it. Fix flags in
3347 the iterator structure wrt the object coming from a display
3348 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3349 properties. (Bug#9284)
3350
7be1c708 33512011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3352
7be1c708
CY
3353 * fontset.c (fontset_get_font_group): Add proper type checks.
3354 (Bug#9172)
aac0c6e3 3355
7be1c708 33562011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3357
7be1c708
CY
3358 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3359 and LC_VERSION_MIN_MACOSX.
3360 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3361 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3362
97bb72a6
EZ
33632011-08-08 Eli Zaretskii <eliz@gnu.org>
3364
3365 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3366 no-display-properties-and-no-overlays under bidi display.
3367 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3368 properties and overlays.
97bb72a6 3369
d5617611
CY
33702011-08-08 Chong Yidong <cyd@stupidchicken.com>
3371
37e11a63
CY
3372 * editfns.c (Fset_time_zone_rule): Document relationship with the
3373 setenv function.
3374
d5617611
CY
3375 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3376 the font entity extracted from the cache (Bug#8109).
3377
58872834
CY
33782011-08-07 Chong Yidong <cyd@stupidchicken.com>
3379
3380 * composite.c (autocmp_chars): Don't reset point. That is done by
3381 restore_point_unwind (Bug#5984).
3382
75bfc667
JL
33832011-08-07 Juri Linkov <juri@jurta.org>
3384
3385 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3386 to show the arg `TIME' instead of `TIMEVAL'.
3387
d1410150
EZ
33882011-08-06 Eli Zaretskii <eliz@gnu.org>
3389
3390 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3391 display property strides EOL and includes a newline, as in
3392 longlines-mode. (Bug#9254)
75b771e4
EZ
3393 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3394 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3395
3396 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3397 is non-zero, even if the data buffer is NULL. Fixes a crash in
3398 vertical-motion with longlines-mode. (Bug#9254)
3399
35928349
EZ
34002011-08-05 Eli Zaretskii <eliz@gnu.org>
3401
ec7cc85b
EZ
3402 * bidi.c <bidi_cache_total_alloc>: Now static.
3403 (bidi_initialize): Initialize bidi_cache_total_alloc.
3404
8b76d6f8 3405 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3406 cache. (Bug#9221)
3407
3408 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3409 amount allocated this far in `bidi_cache_total_alloc'.
3410 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3411 non-zero, only free the data buffer without restoring the cache
3412 contents. All callers changed.
3413
3414 * dispextern.h (bidi_unshelve_cache): Update prototype.
3415
3416 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3417 (move_it_in_display_line, move_it_to)
3418 (move_it_vertically_backward, move_it_by_lines): Replace the call
3419 to xfree to an equivalent call to bidi_unshelve_cache.
3420 (move_it_in_display_line_to): Fix logic of returning
412b6358 3421 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3422
e2e2423b
EZ
34232011-08-05 Eli Zaretskii <eliz@gnu.org>
3424
3425 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3426 came from a string character with a `cursor' property. (Bug#9229)
3427
ae9e757a
JD
34282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3429
3430 * Makefile.in (LIB_PTHREAD): New variable.
3431 (LIBES): Add LIB_PTHREAD (Bug#9216).
3432
3433 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3434 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3435
213bd7f2
AS
34362011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3437
6b02f655 3438 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3439
99aaf75f
JD
34402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3441
3442 * xterm.c (x_find_topmost_parent): New function.
3443 (x_set_frame_alpha): Find topmost parent window with
3444 x_find_topmost_parent and set the property there also (bug#9181).
3445 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3446
c74e9d86
PE
34472011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3448
3449 * callproc.c (Fcall_process): Avoid vfork clobbering
3450 the local vars buffer, coding_systems, current_dir.
3451
640c8776
SM
34522011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3453
3454 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3455
f26d0e4c
PE
34562011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3457
8a10d76c
PE
3458 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3459 so that it is not optimized away.
3460
f26d0e4c
PE
3461 * xdisp.c (compute_display_string_pos): Remove unused local.
3462
55439c61
EZ
34632011-08-02 Eli Zaretskii <eliz@gnu.org>
3464
3465 Fix slow cursor motion and scrolling in large buffers with
3466 selective display, like Org Mode buffers. (Bug#9218)
3467
3468 * dispextern.h (struct bidi_it): New member disp_prop_p.
3469
3470 * xdisp.c: Remove one-slot cache of display string positions.
3471 (compute_display_string_pos): Accept an additional argument
5e617bc2 3472 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3473 for a display string or property. If found, set DISP_PROP_P
3474 non-zero.
3475
3476 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3477 DISP_PROP_P, and pass it to compute_display_string_pos.
3478 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3479 non-zero. All callers of bidi_fetch_char changed.
3480
fb33fa43
SM
34812011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3482
3483 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3484
b099e063
DM
34852010-12-03 Don March <don@ohspite.net>
3486
3487 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3488 last character M-[char] is translated to ESC [char] (bug#7541).
3489
5cc7f7af
KH
34902011-08-02 Kenichi Handa <handa@m17n.org>
3491
d0fffa3f 3492 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3493
3494 * chartab.c (uniprop_table): Make it non-static.
3495
525d5e6e
EZ
34962011-08-01 Eli Zaretskii <eliz@gnu.org>
3497
3498 * xdisp.c (forward_to_next_line_start): Accept additional argument
3499 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3500 on the newline.
3501 (reseat_at_next_visible_line_start): Use the bidi iterator state
3502 returned by forward_to_next_line_start to restore the state of
3503 it->bidi_it after backing up to previous newline. (Bug#9212)
3504
31011111
AS
35052011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3506
3507 * regex.c (re_comp): Protoize.
3508 (re_exec): Fix return type.
3509 (regexec): Fix type of `ret'. (Bug#9203)
3510
476371c4
PE
35112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3512
e5d76069
PE
3513 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3514 This is needed if max-image-size is a floating-point number.
3515
9a79b20c
AS
35162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3517
3518 * print.c (print_object): Print empty symbol as ##.
3519
3520 * lread.c (read1): Read ## as empty symbol.
3521
d8c2fa78
AA
35222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3523
3524 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3525 setting frame foreground color (Bug#9175).
3526 (x_set_background_color): Likewise.
3527
ffe57a7a
AA
3528 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3529 contents (Bug#9176).
3530 (EmacsTooltip -init): Remove bezels and add shadows to
3531 tooltip windows.
3532
bf3492a5
AA
3533 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3534 or scroll bar (Bug#8470).
3535
d55e9c53
AA
3536 * nsfont.m (nsfont_open): Remove assignment to voffset and
3537 unnecessary vars hshink, expand, hd, full_height, min_height.
3538 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3539
3540 * nsterm.h (nsfont_info): Remove voffset field.
3541
d8c2fa78 35422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3543
3544 Implement strike-through and overline on NextStep (Bug#8863).
3545
3546 * nsfont.m (nsfont_open): Use underline position provided by font,
3547 instead of hard-coded value of 2.
3548 (nsfont_draw): Call ns_draw_text_decoration instead.
3549
3550 * nsterm.h: Add declaration for ns_draw_text_decoration.
3551
3552 * nsterm.m (ns_draw_text_decoration): New function for drawing
3553 underline, overline, and strike-through.
3554 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3555 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3556 accommodate underlining, etc.
4843aac3 3557
4cc60b9b
EZ
35582011-07-28 Eli Zaretskii <eliz@gnu.org>
3559
bc7ece87
EZ
3560 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3561 default.
4cc60b9b 3562
476371c4
PE
35632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3564
66606eea
PE
3565 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3566 Without this fix, if a signal arrives just after memory fills up,
3567 'malloc' might be invoked reentrantly.
3568
476371c4
PE
3569 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3570 In other words, assume that every image size is allowed, on non-X
3571 hosts. This assumption is probably wrong, but it lets Emacs compile.
3572
f3fcc40d
AS
35732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3574
3575 * regex.c (re_iswctype): Convert return values to boolean.
3576
350c992f
EZ
35772011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3578
3579 * xdisp.c (compute_display_string_pos): Don't use cached display
3580 string position if the buffer had its restriction changed.
3581 (Bug#9184)
3582
5266b4bb
PE
35832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3584
3585 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3586
2573a837 35872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3588
41f55ccd 3589 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3590
39e378da
PE
3591 * bidi.c: Integer size and overflow fixes.
3592 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3593 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3594 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3595 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3596 (bidi_find_other_level_edge):
3597 Use ptrdiff_t instead of EMACS_INT where either will do.
3598 This works better on 32-bit hosts configured --with-wide-int.
3599 (bidi_cache_ensure_space): Check for size-calculation overflow.
3600 Use % rather than repeated addition, for better worst-case speed.
3601 Don't set bidi_cache_size until after xrealloc returns, because it
3602 might not return.
3603 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3604 (bidi_cache_ensure_space): Also check that the bidi cache size
3605 does not exceed that of the largest Lisp string or buffer. See Eli
3606 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3607
5e927815
PE
3608 * alloc.c (__malloc_size_t): Remove.
3609 All uses replaced by size_t. See Andreas Schwab's note
3610 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3611
ca4aa935
PE
3612 * image.c: Improve checking for integer overflow.
3613 (check_image_size): Assume that f is nonnull, since
3614 it is always nonnull in practice. This is one less thing to
3615 worry about when checking for integer overflow later.
3616 (x_check_image_size): New function, which checks for integer
3617 overflow issues inside X.
3618 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3619 This removes the need for a memory_full check.
3620 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3621 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3622 (xbm_read_bitmap_data): Change locals back to 'int', since
3623 their values must fit in 'int'.
3624 (xpm_load_image, png_load, tiff_load):
3625 Invoke x_create_x_image_and_pixmap earlier,
3626 to avoid much needless work if the image is too large.
3627 (tiff_load): Treat overly large images as if
3628 x_create_x_image_and_pixmap failed, not as malloc failures.
3629 (gs_load): Use x_check_image_size.
3630
5f8f9cc2
PE
3631 * gtkutil.c: Omit integer casts.
3632 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3633 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3634
5adf60bc
PE
3635 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3636
c8907a93
PE
3637 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3638 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3639 would wrongly return t on a 64-bit host.
3640
e3c25c68
PE
3641 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3642 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3643 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3644 and therefore cause GCC to emit a bogus diagnostic in some cases.
3645
3f791afe
PE
3646 * image.c: Integer signedness and overflow and related fixes.
3647 This is not an exhaustive set of fixes, but it's time to
3648 record what I've got.
3649 (lookup_pixel_color, check_image_size): Remove redundant decls.
3650 (check_image_size): Don't assume that arbitrary EMACS_INT values
3651 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3652 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3653 (tiff_load, imagemagick_load_image):
3654 Check for overflow in size calculations.
3655 (x_create_x_image_and_pixmap): Remove unnecessary test for
3656 xmalloc returning NULL; that can't happen.
3657 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3658 (xpm_color_bucket): Use better integer hashing function.
3659 (xpm_cache_color): Don't possibly over-allocate memory.
3660 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3661 (gif_memory_source):
3662 Use ptrdiff_t, not int or size_t, to record sizes.
3663 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3664 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3665 either works, as we prefer signed integers.
3666 (tiff_read_from_memory, tiff_write_from_memory):
3667 Return tsize_t, not size_t, since that's what the TIFF API wants.
3668 (tiff_read_from_memory): Don't fail simply because the read would
3669 go past EOF; instead, return a short read.
3670 (tiff_load): Omit no-longer-needed casts.
3671 (Fimagemagick_types): Don't assume size fits into 'int'.
3672
3cc5a532
PE
3673 Improve hashing quality when configured --with-wide-int.
3674 * fns.c (hash_string): New function, taken from sxhash_string.
3675 Do not discard information about ASCII character case; this
3676 discarding is no longer needed.
3677 (sxhash-string): Use it. Change sig to match it. Caller changed.
3678 * lisp.h: Declare it.
3679 * lread.c (hash_string): Remove, since we now use fns.c's version.
3680 The fns.c version returns a wider integer if --with-wide-int is
3681 specified, so this should help the quality of the hashing a bit.
3682
b312a492
PE
3683 * emacs.c: Integer overflow minor fix.
3684 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3685 Define only if GNU_LINUX.
3686 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3687
dfd153ae
PE
3688 * dispnew.c: Integer signedness and overflow fixes.
3689 Remove unnecessary forward decls, that were a maintenance hassle.
3690 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3691 All uses changed.
3692 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3693 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3694 (prepare_desired_row, line_draw_cost):
3695 Use int, not unsigned, where either works.
3696 (save_current_matrix, restore_current_matrix):
3697 Use ptrdiff_t, not size_t, where either works.
3698 (init_display): Check for overflow more accurately, and without
3699 relying on undefined behavior.
3700
a81d11a3
PE
3701 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3702 Remove, replacing with the new symbols in lisp.h. All uses changed.
3703 * fileio.c (make_temp_name):
3704 * filelock.c (lock_file_1, lock_file):
3705 * xdisp.c (message_dolog):
3706 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3707 Use pMd etc. instead.
3708 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3709 replacing the pWIDE etc. symbols removed from editfns.c.
3710
3300e6fd
PE
3711 * keyboard.h (num_input_events): Now uintmax_t.
3712 This is (very slightly) less likely to mess up due to wraparound.
3713 All uses changed.
3714
fd05c7e9
PE
3715 * buffer.c: Integer signedness fixes.
3716 (alloc_buffer_text, enlarge_buffer_text):
3717 Use ptrdiff_t rather than size_t when either will do, as we prefer
3718 signed integers.
3719
903fe15d
PE
3720 * alloc.c: Integer signedness and overflow fixes.
3721 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3722 (__malloc_size_t): Default to size_t, not to int.
3723 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3724 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3725 Prefer ptrdiff_t to size_t when either would do, as we prefer
3726 signed integers.
3727 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3728 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3729 Now const. Initialize with values that are in range even if char
3730 is signed.
3731 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3732 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3733 These functions do the right thing with sizes > 2**32.
3734 (check_depth): Now ptrdiff_t, not int.
3735 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3736 Adjust to new way of storing sizes. Check for size overflow bugs
3737 in rest of code.
3738 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3739 slightly wrong anyway, as it missed one instance of
3740 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3741 (refill_memory_reserve): Omit needless cast to size_t.
3742 (mark_object_loop_halt): Mark as externally visible.
3743
ac82cc6a
PE
3744 * xselect.c: Integer signedness and overflow fixes.
3745 (Fx_register_dnd_atom, x_handle_dnd_message):
3746 Use ptrdiff_t, not size_t, since we prefer signed.
3747 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3748 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3749 x_dnd_atoms_size and x_dnd_atoms_length.
3750
c2d1e36d
PE
3751 * doprnt.c: Prefer signed to unsigned when either works.
3752 * eval.c (verror):
3753 * doprnt.c (doprnt):
3754 * lisp.h (doprnt):
3755 * xdisp.c (vmessage):
3756 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3757 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3758 prefer signed arithmetic to avoid comparison confusion.
3759 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3760 but is a bit tricky.
3761
0e926e56
PE
3762 Assume freestanding C89 headers, string.h, stdlib.h.
3763 * data.c, doprnt.c, floatfns.c, print.c:
3764 Include float.h unconditionally.
3765 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3766 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3767 * regex.c: Likewise for stddef.h, string.h.
3768 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3769 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3770 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3771 (STDC_HEADERS): Remove obsolete defines.
3772 * sysdep.c: Include limits.h unconditionally.
3773
9cfdb3ec
PE
3774 Assume support for memcmp, memcpy, memmove, memset.
3775 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3776 * regex.c (memcmp, memcpy):
3777 Remove; we assume C89 now.
3778
3779 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3780 (__malloc_safe_bcopy): Remove; no longer needed.
3781
cf950e6b 3782 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3783 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3784 well either way, and we prefer signed to unsigned.
3785
dbf38e02
LMI
37862011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3787
3788 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3789 closes the connection while we're reading (bug#9182).
3790
d6f0886c 37912011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3792
d6f0886c
JD
3793 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3794 are specified (Bug#9168).
24e0f6b1 3795
2eb1f9e6
PE
37962011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3797
3798 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3799 Found by GCC static checking and --with-wide-int on a 32-bit host.
3800
22381272 38012011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3802
3803 * xdisp.c (compute_display_string_pos): Fix logic of caching
3804 previous display string position. Initialize cached_prev_pos to
3805 -1. Fixes slow-down at the beginning of a buffer.
3806
f25e39b4
EZ
38072011-07-24 Eli Zaretskii <eliz@gnu.org>
3808
3809 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3810 for attrs[LFACE_FONTSET_INDEX].
3811
04c4b52e
PE
38122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * xml.c (parse_region): Remove unused local
3815 that was recently introduced.
3816
c1734fbd
EZ
38172011-07-23 Eli Zaretskii <eliz@gnu.org>
3818
be18c5a5
EZ
3819 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3820 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3821
c1734fbd
EZ
3822 * xdisp.c (move_it_in_display_line_to): Record the best matching
3823 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3824 exit if none of the characters scanned was an exact match.
3825 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3826 when exact match is impossible due to invisible text, and the
3827 lines are truncated.
3828
a258d627
JD
38292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3830
3831 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3832 for OSX >= 10.7.
3833
b6d5a689
EZ
38342011-07-22 Eli Zaretskii <eliz@gnu.org>
3835
0f74f785
EZ
3836 Fix a significant slow-down of cursor motion with C-n, C-p,
3837 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3838 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3839 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3840 (next_element_from_buffer): Call compute_stop_pos_backwards to
3841 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3842 base_level_stop.
3843 (reseat): Don't look for prev_stop, as that could mean a very long
3844 run.
3845 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3846 <cached_disp_overlay_modiff>: Cache for last found display string
3847 position.
551918c1 3848 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3849 about the same buffer in the same area of character positions, and
3850 the buffer wasn't changed since the time the display string
3851 position was cached.
551918c1 3852
b2d0c91a
EZ
38532011-07-22 Eli Zaretskii <eliz@gnu.org>
3854
3855 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3856 is an integer, which is important for empty lines. (Bug#9149)
3857
043604ee
CY
38582011-07-22 Chong Yidong <cyd@stupidchicken.com>
3859
3860 * frame.c (Fmodify_frame_parameters): In tty case, update the
3861 default face if necessary (Bug#4238).
3862
da4adb04
CY
38632011-07-21 Chong Yidong <cyd@stupidchicken.com>
3864
3865 * editfns.c (Fstring_to_char): No need to explain what a character
3866 is in the docstring (Bug#6576).
3867
9abd0532
LMI
38682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869
3870 * xml.c (parse_region): Make sure we always return a tree.
3871
36881d16
HK
38722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3873
3874 * xml.c (parse_region): If a document contains only comments,
3875 return that, too.
3876
1e98674d
LMI
38772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3878
3879 * xml.c (make_dom): Return comments, too.
3880
590bd467
PE
38812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 Port to OpenBSD.
3884 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3885 and the surrounding thread.
3886 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3887 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3888 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3889 timer goes off.
3890 * s/openbsd.h (BROKEN_SIGIO): Define.
3891 * unexelf.c (unexec) [__OpenBSD__]:
3892 Don't update the .mdebug section of the Alpha COFF symbol table.
3893
f41628b2
LMI
38942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3895
3896 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3897 (bug#8460).
3898
b59b67c5
PE
38992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3900
15e3a074
PE
3901 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3902 This fixes some race conditions on the permissions of any newly
3903 created file.
3904
41bed37d
PE
3905 * alloc.c (valid_pointer_p): Use pipe, not open.
3906 This fixes some permissions issues when debugging.
3907
b59b67c5
PE
3908 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3909 If fchown fails to set both uid and gid, try to set just gid,
3910 as that is sometimes allowed. Adjust the file's mode to eliminate
3911 setuid or setgid bits that are inappropriate if fchown fails.
3912
925a6be7
SM
39132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3914
3915 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3916 to compare Lisp_Objects.
3917 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3918 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3919 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3920
52968808
AS
39212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3922
0a6a104b
AS
3923 * lread.c (read_integer): Unread even EOF character.
3924 (read1): Likewise. Properly record start position of symbol.
3925
52968808
AS
3926 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3927 symbol character follows.
3928
9e381cdd
PE
39292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3932 This works around a problem with the previous change to Fcopy_file.
3933 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3934 and without this change, GCC might complain about discarding
3935 fchown's return value.
3936
b5641435
JB
39372011-07-16 Juanma Barranquero <lekktu@gmail.com>
3938
3939 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3940
a8031457
PE
39412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3944
dd889327
LMI
39452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3946
750c33f7
LMI
3947 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3948 it's used from the C level.
3949
dd889327
LMI
3950 * process.c: Use the same condition for POLL_FOR_INPUT in both
3951 keyboard.c and process.c (bug#1858).
3952
87e86684
LM
39532011-07-09 Lawrence Mitchell <wence@gmx.li>
3954
3955 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3956 (Fgnutls_boot): Use it.
3957
64348f40
AS
39582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3959
3960 * doc.c (Fsubstitute_command_keys): Revert last change.
3961
1d698799
LMI
39622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3963
f863868c
LMI
3964 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3965 quotes the next character, and doesn't affect other longer
3966 sequences (bug#8935).
3967
1d698799
LMI
3968 * lread.c (syms_of_lread): Clarify that is isn't only
3969 `eval-buffer' and `eval-defun' that's affected by
3970 `lexical-binding' (bug#8460).
3971
aa4b6df6
EZ
39722011-07-15 Eli Zaretskii <eliz@gnu.org>
3973
3974 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3975 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3976
5d856da6
PE
39772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3978
ad6042bb
PE
3979 Fix minor problems found by static checking.
3980 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3981 (elsz): Now a signed constant, not a size_t var. We prefer signed
3982 types to unsigned, to avoid integer comparison confusion. Without
3983 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3984 "cannot optimize loop, the loop counter may overflow", a symptom
3985 of the confusion.
f00bbb22 3986 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3987 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3988
6468f31c
LMI
39892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3990
49080b10
LMI
3991 * search.c (Fre_search_backward): Mention `case-fold-search' in
3992 all the re_search_* functions (bug#8138).
3993
6468f31c
LMI
3994 * keyboard.c (Fopen_dribble_file): Document when the file is
3995 closed (bug#8056).
3996
c965adc5
EZ
39972011-07-14 Eli Zaretskii <eliz@gnu.org>
3998
df9733bf
EZ
3999 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4000 bidi_cache_idx.
4001
0bb23927
EZ
4002 Support bidi reordering of display and overlay strings.
4003 * xdisp.c (compute_display_string_pos)
4004 (compute_display_string_end): Accept additional argument STRING.
4005 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4006 (reseat_to_string): Initialize bidi_it->string.s and
4007 bidi_it->string.schars.
4008 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4009 NULL (avoids a crash in bidi_paragraph_init).
4010 Initialize itb.string.lstring.
0bb23927
EZ
4011 (init_iterator): Call bidi_init_it only of a valid
4012 buffer position was specified. Initialize paragraph_embedding to
4013 L2R.
4014 (reseat_to_string): Initialize the bidi iterator.
4015 (display_string): If we need to ignore text properties of
4016 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4017 original value of -1 will not work with bidi.)
4018 (compute_display_string_pos): First arg is now struct
4019 `text_pos *'; all callers changed. Support display properties on
4020 Lisp strings.
4021 (compute_display_string_end): Support display properties on Lisp
4022 strings.
4023 (init_iterator, reseat_1, reseat_to_string): Initialize the
4024 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4025 when iterating on a string not from display properties).
640c8776
SM
4026 (compute_display_string_pos, compute_display_string_end):
4027 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4028 arrow keys.
4029 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4030 base_level_stop; instead, set base_level_stop to BEGV.
4031 Fixes crashes in vertical-motion.
0bb23927
EZ
4032 (next_element_from_buffer): Improve commentary for when
4033 the iterator is before prev_stop.
4034 (init_iterator): Initialize bidi_p from the default value of
4035 bidi-display-reordering, not from buffer-local value. Use the
4036 buffer-local value only if initializing for buffer iteration.
4037 (handle_invisible_prop): Support invisible properties on strings
4038 that are being bidi-reordered.
4039 (set_iterator_to_next): Support bidi reordering of C strings and
4040 Lisp strings.
4041 (next_element_from_string): Support bidi reordering of Lisp
4042 strings.
4043 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4044 (display_string): Support display of R2L glyph rows.
4045 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4046 (init_iterator): Don't initialize it->bidi_p for strings
4047 here.
4048 (reseat_to_string): Initialize it->bidi_p for strings here.
4049 (next_element_from_string, next_element_from_c_string)
4050 (next_element_from_buffer): Add xassert's for correspondence
4051 between IT's object being iterated and it->bidi_it.string
4052 structure.
4053 (face_before_or_after_it_pos): Support bidi iteration.
4054 (next_element_from_c_string): Handle the case of the first string
4055 character that is not the first one in the visual order.
4056 (get_visually_first_element): New function, refactored from common
4057 parts of next_element_from_buffer, next_element_from_string, and
4058 next_element_from_c_string.
4059 (tool_bar_lines_needed, redisplay_tool_bar)
4060 (display_menu_bar): Force left-to-right direction. Add a FIXME
4061 comment for making that be controlled by a user option.
4062 (push_it, pop_it): Save and restore the state of the
4063 bidi iterator. Save and restore the bidi_p flag.
4064 (pop_it): Iterate out of display property for string iteration as
4065 well.
4066 (iterate_out_of_display_property): Support iteration over strings.
4067 (handle_single_display_spec): Set up it->bidi_it for iteration
4068 over a display string, and call bidi_init_it.
4069 (handle_single_display_spec, next_overlay_string)
4070 (get_overlay_strings_1, push_display_prop): Set up the bidi
4071 iterator for displaying display or overlay strings.
4072 (forward_to_next_line_start): Don't use the shortcut if
4073 bidi-iterating.
4074 (back_to_previous_visible_line_start): If handle_display_prop
4075 pushed the iterator stack, restore the internal state of the bidi
4076 iterator by calling bidi_pop_it same number of times.
4077 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4078 and we are bidi-iterating, don't decrement the iterator position;
4079 instead, set the first_elt flag in the bidi iterator, to produce
4080 the same effect.
4081 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4082 (push_display_prop): xassert that we are iterating a buffer.
4083 (push_it, pop_it): Save and restore paragraph_embedding member.
4084 (handle_single_display_spec, next_overlay_string)
4085 (get_overlay_strings_1, reseat_1, reseat_to_string)
4086 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4087 correctly. Don't assume unibyte strings are not bidi-reordered.
4088 (compute_display_string_pos)
4089 (compute_display_string_end): Fix handling the case of C string.
4090 (push_it, pop_it): Save and restore from_disp_prop_p.
4091 (handle_single_display_spec, push_display_prop): Set the
4092 from_disp_prop_p flag.
4093 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4094 (pop_it): Call iterate_out_of_display_property only if we are
4095 popping after iteration over a string that came from a display
4096 property. Fix a typo in popping stretch info. Add an assertion
4097 for verifying that the iterator position is in sync with the bidi
4098 iterator.
4099 (handle_single_display_spec, get_overlay_strings_1)
4100 (push_display_prop): Fix initialization of paragraph direction for
4101 string when that of the parent object is not yet determined.
4102 (reseat_1): Call bidi_init_it to resync the bidi
4103 iterator with IT's position. (Bug#7616)
4104 (find_row_edges): If ROW->start.pos gives position
4105 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4106 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4107 Reset the from_disp_prop_p flag.
4108 (SAVE_IT, RESTORE_IT): New macros.
4109 (pos_visible_p, face_before_or_after_it_pos)
4110 (back_to_previous_visible_line_start)
4111 (move_it_in_display_line_to, move_it_in_display_line)
4112 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4113 (try_scrolling, redisplay_window, display_line): Use them when
4114 saving a temporary copy of the iterator and restoring it back.
4115 (back_to_previous_visible_line_start, reseat_1)
4116 (init_iterator): Empty the bidi cache "stack".
4117 (move_it_in_display_line_to): If iterator ended up at
4118 EOL, but we never saw any buffer positions smaller than
4119 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4120 motion in bidi-reordered lines.
4121 (move_it_in_display_line_to): Record prev_method and prev_pos
4122 immediately before the call to set_iterator_to_next. Fixes cursor
4123 motion in bidi-reordered lines with stretch glyphs and strings
4124 displayed in margins. (Bug#8133) (Bug#8867)
4125 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4126 TO_CHARPOS.
640c8776
SM
4127 (pos_visible_p): Support positions in bidi-reordered lines.
4128 Save and restore bidi cache.
0bb23927
EZ
4129
4130 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4131 (bidi_paragraph_info): Delete unused struct.
4132 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4133 (bidi_cache_start): New variable.
4134 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4135 to zero.
4136 (bidi_cache_fetch_state, bidi_cache_search)
4137 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4138 (bidi_cache_find, bidi_peek_at_next_level)
4139 (bidi_level_of_next_char, bidi_find_other_level_edge)
4140 (bidi_move_to_visually_next): Compare cache index with
4141 bidi_cache_start rather than with zero.
4142 (bidi_fetch_char): Accept new argument STRING; all callers
4143 changed. Support iteration over a string. Support strings with
4144 display properties. Support unibyte strings. Fix the type of
4145 `len' according to what STRING_CHAR_AND_LENGTH expects.
4146 (bidi_paragraph_init, bidi_resolve_explicit_1)
4147 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4148 (bidi_level_of_next_char, bidi_move_to_visually_next):
4149 Support iteration over a string.
0bb23927
EZ
4150 (bidi_set_sor_type, bidi_resolve_explicit_1)
4151 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4152 can now be zero (for strings); special values 0 and -1 were
4153 changed to -1 and -2, respectively.
4154 (bidi_char_at_pos): New function.
4155 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4156 Call it instead of FETCH_MULTIBYTE_CHAR.
4157 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4158 initialized to valid values.
4159 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4160 values.
4161 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4162 the test for valid cached positions. Fix the logic for looking up
4163 the sentinel state in the cache. GCPRO the Lisp string we are
4164 iterating.
4165 (bidi_push_it, bidi_pop_it): New functions.
4166 (bidi_initialize): Initialize the bidi cache start stack pointer.
4167 (bidi_cache_ensure_space): New function, refactored from part of
4168 bidi_cache_iterator_state. Don't assume the required size is just
4169 one BIDI_CACHE_CHUNK away.
4170 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4171 (bidi_count_bytes, bidi_char_at_pos): New functions.
4172 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4173 always valid if bidi_cache_idx is valid.
4174 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4175 is valid if it's going to be used.
4176 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4177 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4178 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4179 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4180 (bidi_find_other_level_edge, bidi_cache_start_stack):
4181 All variables related to cache indices are now EMACS_INT.
c965adc5 4182
0bb23927
EZ
4183 * dispextern.h (struct bidi_string_data): New structure.
4184 (struct bidi_it): New member `string'. Make flag members be 1-bit
4185 fields, and put them last in the struct.
640c8776
SM
4186 (compute_display_string_pos, compute_display_string_end):
4187 Update prototypes.
0bb23927
EZ
4188 (bidi_push_it, bidi_pop_it): Add prototypes.
4189 (struct iterator_stack_entry): New members bidi_p,
4190 paragraph_embedding, and from_disp_prop_p.
4191 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4192 (bidi_shelve_cache, bidi_unshelve_cache):
4193 Declare prototypes.
0bb23927
EZ
4194
4195 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4196 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4197 and vector-like objects.
4198
4199 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4200 cache around display iteration.
4201
4202 * window.c (Fwindow_end, window_scroll_pixel_based)
4203 (displayed_window_lines, Frecenter): Save and restore the bidi
4204 cache around display iteration.
4205
3bbd2265
LMI
42062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4207
4208 * editfns.c (Fdelete_region): Clarify the use of the named
4209 parameters (bug#6788).
4210
adc47434
MR
42112011-07-14 Martin Rudalics <rudalics@gmx.at>
4212
4213 * indent.c (Fvertical_motion): Set and restore w->pointm when
4214 saving and restoring the window's buffer (Bug#9006).
4215
837c31f8
LMI
42162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4217
4218 * editfns.c (Fstring_to_char): Clarify just what is returned
4219 (bug#6576). Text by Eli Zaretskii.
4220
ac389d0c
JB
42212011-07-13 Juanma Barranquero <lekktu@gmail.com>
4222
4223 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4224
0be0ce47
EZ
42252011-07-13 Eli Zaretskii <eliz@gnu.org>
4226
4227 * buffer.c (mmap_find): Fix a typo.
4228
cd18e7e3
JB
42292011-07-13 Johan Bockgård <bojohan@gnu.org>
4230
4231 Fix execution of x selection hooks.
4232 * xselect.c (Qx_lost_selection_functions)
4233 (Qx_sent_selection_functions): New vars.
4234 (syms_of_xselect): DEFSYM them.
4235 (x_handle_selection_request): Pass Qx_sent_selection_functions
4236 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4237 (x_handle_selection_clear,x_clear_frame_selections):
4238 Pass Qx_lost_selection_functions rather than
4239 Vx_lost_selection_functions to Frun_hook_with_args.
4240
47ea7f44
PE
42412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4242
ac389d0c 4243 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4244 The old code sometimes used this field without initializing it.
4245
47ea7f44
PE
4246 * alloc.c (gc_sweep): Don't read past end of array.
4247 In theory, the old code could also have corrupted Emacs internals,
4248 though it'd be very unlikely.
4249
bc985c87
AS
42502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4251
4252 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4253 argument. (Bug#4026)
bc985c87 4254
0cf34688
LMI
42552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4256
b3dadd76
LMI
4257 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4258 key" (bug#4257).
4259
0cf34688
LMI
4260 * window.c (Fset_window_start): Doc fix (bug#4199).
4261 (Fset_window_hscroll): Ditto.
4262
270768cd
PE
42632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4264
077e3dda 4265 Fix minor new problems caught by GCC 4.6.1.
270768cd 4266 * term.c (init_tty): Remove unused local.
490011a6 4267 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4268 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4269 not used otherwise.
270768cd 4270
b1f58454
CY
42712011-07-12 Chong Yidong <cyd@stupidchicken.com>
4272
4273 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4274
22b9578d
LMI
42752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4276
6e70ab07
LMI
4277 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4278 are the mini-buffer and the echo area (bug#3320).
4279
22b9578d
LMI
4280 * term.c (init_tty): Remove support for supdup, c10 and perq
4281 terminals, which are no longer supported (bug#1482).
4282
8974cc9f
JB
42832011-07-10 Johan Bockgård <bojohan@gnu.org>
4284
4285 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4286
a560d974
JD
42872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4288
4289 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4290 for non-popups (Bug#3642).
4291
1dae0f0a
AS
42922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4293
268c2c36 4294 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4295 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4296 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4297 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4298 * data.c (fmod): Likewise.
4299 * dispnew.c (swap_glyphs_in_rows): Likewise.
4300 * emacs.c (memory_warning_signal): Likewise.
4301 * floatfns.c (float_error): Likewise.
4302 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4303 (otf_open, font_otf_capability, generate_otf_features)
4304 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4305 Likewise.
4306 * image.c (pbm_read_file): Likewise.
4307 * indent.c (string_display_width): Likewise.
4308 * intervals.c (check_for_interval, search_for_interval)
4309 (inc_interval_count, count_intervals, root_interval)
4310 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4311 * lread.c (defalias): Likewise.
268c2c36 4312 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4313 * regex.c (set_image_of_range_1, set_image_of_range)
4314 (regex_grow_registers): Likewise.
4315 * sysdep.c (strerror): Likewise.
4316 * termcap.c (valid_filename_p, tprint, main): Likewise.
4317 * tparam.c (main): Likewise.
4318 * unexhp9k800.c (run_time_remap, save_data_space)
4319 (update_file_ptrs, read_header, write_header, calculate_checksum)
4320 (copy_file, copy_rest, display_header): Likewise.
4321 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4322 Likewise.
4323 * xdisp.c (check_it): Likewise.
4324 * xfaces.c (register_color, unregister_color, unregister_colors):
4325 Likewise.
4326 * xfns.c (print_fontset_result): Likewise.
4327 * xrdb.c (member, fatal, main): Likewise.
4328
99033785
PE
43292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4330
4331 Fix minor problems found by static checking (Bug#9031).
4332 * chartab.c (char_table_set_range, map_sub_char_table):
4333 Remove unused locals.
4334 (uniprop_table): Now static.
4335 * composite.c (_work_char): Remove unused static var.
4336
9cb2ac56
JB
43372011-07-09 Juanma Barranquero <lekktu@gmail.com>
4338
4339 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4340
f25661f0
JD
43412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4342
4343 * gtkutil.c (qttip_cb): Remove code without function.
4344
8278c4fe
EZ
43452011-07-09 Eli Zaretskii <eliz@gnu.org>
4346
4347 * w32.c (pthread_sigmask): New stub.
4348
1692ae2d 43492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4350
8a6ebd58 4351 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4352 sigprocmask is portable only for single-threaded applications, and
4353 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4354 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4355 (LIBES): Use it.
4356 * callproc.c (Fcall_process):
4357 * process.c (create_process):
4358 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4359 Use pthread_sigmask, not sigprocmask.
123403e4 4360
1b854618
JD
43612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4362
4363 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4364 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4365 wrong (Bug#8591).
4366
3fe4b549
JD
43672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4368
0ce7e563
JD
4369 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4370 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4371 (xg_hide_tooltip): Fix comment.
4372
3fe4b549
JD
4373 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4374 in registerServicesMenuSendTypes.
4375 (validRequestorForSendType): Don't check ns_return_types.
4376
4377 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4378 ns_return_type.
4379
5df75e47
JR
43802011-07-08 Jason Rumney <jasonr@gnu.org>
4381
22610910
JR
4382 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4383 SH_SHOW for hidden windows (Bug#5482).
4384
5df75e47
JR
4385 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4386 frame struct members of non-existent frames (Bug#6284).
4387
699c10bd
JD
43882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4389
4393663b
JD
4390 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4391 variable firstTime not needed on OSX >= 10.6.
4392 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4393 >= 10.5. Use setKnobProportion, setDoubleValue.
4394
4395 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4396 (MAC_OS_X_VERSION_10_5): Define if not defined.
4397 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4398 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4399 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4400
4401 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4402 cString and lossyCString on OSX >= 10.4
4403
58179cce 4404 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4405 sizeToFit on OSX >= 10.2.
4406
4407 * nsimage.m (allocInitFromFile): Don't use deprecated method
4408 bestRepresentationForDevice on OSX >= 10.6.
4409
4410 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4411 to avoid warning.
4412
4413 * emacs.c: Declare unexec_init_emacs_zone.
4414
a63e0781
JD
4415 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4416
699c10bd
JD
4417 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4418
4419 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4420 on svcsMenu (Bug#8842).
4421
4422 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4423 ns_return_types.
4424 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4425
4426 * nsterm.m (QUTF8_STRING): Declare.
4427 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4428 (validRequestorForSendType): Return type is (id).
4429 Change indexOfObjectIdenticalTo to indexOfObject.
4430 Check if we have local selection before returning self (Bug#8842).
4431 (writeSelectionToPasteboard): Put local selection into paste board
4432 if we have a local selection (Bug#8842).
4433 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4434
4435 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4436 (ns_get_local_selection): Declare.
4437
54e10184
LMI
44382011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4439
9888ff71
LMI
4440 * keymap.c (describe_map_tree): Don't insert a double newline at
4441 the end of the buffer (bug#1169) and return whether we inserted
4442 something.
4443
54e10184
LMI
4444 * callint.c (Fcall_interactively): Change "reading args" to
4445 "providing args" to try to clarify what it does (bug#1010).
4446
15fa4783
KH
44472011-07-07 Kenichi Handa <handa@m17n.org>
4448
4449 * composite.c (composition_compute_stop_pos): Ignore a static
4450 composition starting before CHARPOS (Bug#8915).
4451
4452 * xdisp.c (handle_composition_prop): Likewise.
4453
a8815b00
EZ
44542011-07-07 Eli Zaretskii <eliz@gnu.org>
4455
4456 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4457 (Bug#9015)
4458
ef7b981d 44592011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4460
4461 * character.h (unicode_category_t): New enum type.
4462
4463 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4464 (Qchar_code_property_table): New variable.
4465 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4466 (UNIPROP_COMPRESSED_FORM_P): New macros.
4467 (char_table_ascii): Uncompress the compressed values.
4468 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4469 Uncompress the compressed values.
ac389d0c 4470 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4471 (char_table_ref_and_range): Uncompress the compressed values.
4472 (sub_char_table_set): New arg is_uniprop. Callers changed.
4473 Uncompress the compressed values.
4474 (sub_char_table_set_range): Args changed. Callers changed.
4475 (char_table_set_range): Adjuted for the above change.
4476 (map_sub_char_table): Delete args default_val and parent. Add arg
4477 top. Give decoded values to a Lisp function.
640c8776 4478 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4479 values to a Lisp function. Gcpro more variables.
4480 (uniprop_table_uncompress)
4481 (uniprop_decode_value_run_length): New functions.
4482 (uniprop_decoder, uniprop_decoder_count): New variables.
4483 (uniprop_get_decoder, uniprop_encode_value_character)
4484 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4485 New functions.
4486 (uniprop_encoder, uniprop_encoder_count): New variables.
4487 (uniprop_get_encoder, uniprop_table)
4488 (Funicode_property_table_internal, Fget_unicode_property_internal)
4489 (Fput_unicode_property_internal): New functions.
4490 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4491 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4492 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4493 char-code-property-alist.
4494
640c8776 4495 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4496 Vunicode_category_table.
4497
640c8776 4498 * font.c (font_range): Adjust for the change of
c805dec0
KH
4499 Vunicode_category_table.
4500
76b397fb
DN
45012011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4502
4503 * m/iris4d.h: Remove file, move contents ...
4504 * s/irix6-5.h: ... here.
4505
22b4128e
PE
45062011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4507
4508 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4509 * alloc.c (mark_buffer):
4510 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4511 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4512 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4513 This isn't true in general, and it's particularly not true
4514 if Emacs is configured with --with-wide-int.
4515 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4516 New macros, used in the buffer.c change.
4517
869795d6
JD
45182011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4519
4520 * xsettings.c: Use both GConf and GSettings if both are available.
4521 (store_config_changed_event): Add comment.
4522 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4523 (store_tool_bar_style_changed): New functions.
5e617bc2 4524 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4525 (struct xsettings): Move font inside HAVE_XFT.
4526 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4527 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4528 Move inside HAVE_XFT.
640c8776 4529 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4530 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4531 also.
4532 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4533 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4534 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4535 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4536 (parse_settings): Move check for font inside HAVE_XFT.
4537 (read_settings, apply_xft_settings): Add comment.
4538 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4539 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4540 call store_font_name_changed.
4541 (xft_settings_event): Add comment.
4542 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4543 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4544 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4545 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4546 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4547 (xsettings_get_system_font, xsettings_get_system_normal_font):
4548 Add comment.
869795d6 4549
d8ed26bd
PE
45502011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 Random fixes. E.g., (random) never returned negative values.
4553 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4554 subseconds part to the entropy, as that's a bit more random.
4555 Prefer signed to unsigned, since the signedness doesn't matter and
4556 in general we prefer signed. When given a limit, use a
4557 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4558 latter isn't right if USE_2_TAGS_FOR_INTS.
4559 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4560 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4561
cabf1cac
SM
45622011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4563
4564 * textprop.c (text_property_stickiness):
4565 Obey Vtext_property_default_nonsticky.
4566 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4567 * w32fns.c (syms_of_w32fns):
4568 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4569
6e9b2be9
PE
45702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4573 This is more efficient than Ffile_directory_p and avoids a minor race.
4574
90186c68
LMI
45752011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4576
7c301272
LMI
4577 * buffer.c (Foverlay_put): Say what the return value is
4578 (bug#7835).
4579
c4f2d8d4
LMI
4580 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4581 is a directory before asking whether to use the file name
4582 (bug#7564).
ad637907
LMI
4583 (barf_or_query_if_file_exists): Make the "File is a directory"
4584 error be more correct.
c4f2d8d4 4585
90186c68
LMI
4586 * fns.c (Frequire): Remove the mention of the .gz files, since
4587 that's installation-specific, but keep the mention of
4588 `get-load-suffixes'.
4589
da64016e
PE
45902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4591
4592 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4593 Report string overflow if the output is too long.
4594
7d47b580
JB
45952011-07-04 Juanma Barranquero <lekktu@gmail.com>
4596
a555cb87
JB
4597 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4598 (syms_of_gnutls): Remove duplicate DEFSYM for
4599 Qgnutls_bootprop_verify_hostname_error, an error for
4600 Qgnutls_bootprop_verify_error (which is no longer used).
4601
7d47b580
JB
4602 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4603 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4604 Also (re)move comments that are misplaced or no longer relevant.
4605
1e49bfab
LMI
46062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4607
4608 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4609
1485f4c0
CY
46102011-07-03 Chong Yidong <cyd@stupidchicken.com>
4611
4612 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4613 and background color parameters if they have been changed.
4614
a9ab721e
LMI
46152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4616
4617 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4618
cf7cff57
PE
46192011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4620
2e13213d
PE
4621 * xsettings.c (SYSTEM_FONT): Define only when used.
4622 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4623
cf7cff57
PE
4624 * keymap.c (access_keymap_1): Now static.
4625
7a8e04f7
CY
46262011-07-02 Chong Yidong <cyd@stupidchicken.com>
4627
4628 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4629 leave any prefix arg for the up event (Bug#1586).
4630
61352f62
LMI
46312011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4632
69bb1ef7
LMI
4633 * lread.c (syms_of_lread): Mention single symbols defined by
4634 `defvar' or `defconst' (bug#7154).
4635
61352f62 4636 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4637 (Frequire): Mention get-load-suffixes.
61352f62 4638
28545e04
MR
46392011-07-02 Martin Rudalics <rudalics@gmx.at>
4640
4641 * window.h (window): Remove clone_number slot.
4642 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4643 Remove.
4644 (make_parent_window, make_window, saved_window)
4645 (Fset_window_configuration, save_window_save): Don't deal with
4646 clone numbers.
4647 * buffer.c (Qclone_number): Remove declaration.
4648 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4649
3349e122
SM
46502011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4651
4652 Add multiple inheritance to keymaps.
4653 * keymap.c (Fmake_composed_keymap): New function.
4654 (Fset_keymap_parent): Simplify.
4655 (fix_submap_inheritance): Remove.
4656 (access_keymap_1): New function extracted from access_keymap to handle
4657 embedded parents and handle lists of maps.
4658 (access_keymap): Use it.
4659 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4660 (Fcopy_keymap): Handle embedded parents.
4661 (Fcommand_remapping, define_as_prefix): Simplify.
4662 (Fkey_binding): Simplify.
4663 (syms_of_keymap): Move minibuffer-local-completion-map,
4664 minibuffer-local-filename-completion-map,
4665 minibuffer-local-must-match-map, and
4666 minibuffer-local-filename-must-match-map to Elisp.
4667 (syms_of_keymap): Defsubr make-composed-keymap.
4668 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4669 (parse_menu_item): Trivial simplification.
4670
3279eb87
GM
46712011-07-01 Glenn Morris <rgm@gnu.org>
4672
4673 * Makefile.in (SETTINGS_LIBS): Fix typo.
4674
4550efdf
KI
46752011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4676
4677 * coding.c (Fencode_coding_string): Record the last coding system
4678 used, as the function doc string says (bug#8738).
4679
0949d2b6
JD
46802011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4681
4682 * xsettings.c (store_monospaced_changed): Take new font as arg and
4683 check for change against current_mono_font.
4684 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4685 (emacs_settings_constructor, emacs_settings_get_property)
4686 (emacs_settings_set_property, emacs_settings_class_init)
4687 (emacs_settings_init, gsettings_obj): Remove.
4688 (something_changedCB): New function for HAVE_GSETTINGS.
4689 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4690 with value as argument.
4691 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4692 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4693 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4694 "changed".
4695
4696 * xgselect.c: Add defined (HAVE_GSETTINGS).
4697 (xgselect_initialize): Ditto.
4698
4699 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4700 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4701 xg_select.
4702
bbc6b304
PE
47032011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4704
4705 * eval.c (struct backtrace): Simplify and port the data structure.
4706 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4707 signed bit field, as this assumption is not portable and it makes
4708 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4709 "char debug_on_exit : 1" as this is not portable either; instead,
4710 use the portable "unsigned int debug_on_exit : 1". Remove unused
4711 member evalargs. Remove obsolete comments about cc bombing out.
4712
9851bfc5
JD
47132011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4714
51bb811f 4715 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4716 Let HAVE_GSETTINGS override HAVE_GCONF.
4717 (store_monospaced_changed): New function.
4718 (EMACS_SETTINGS): A new type derived from GObject to handle
4719 GSettings notifications.
4720 (emacs_settings_constructor, emacs_settings_get_property)
4721 (emacs_settings_set_property, emacs_settings_class_init):
4722 New functions.
4723 (gsettings_client, gsettings_obj): New variables.
4724 (GSETTINGS_SCHEMA): New define.
4725 (something_changedCB): Call store_monospaced_changed.
4726 (init_gsettings): New function.
4727 (xsettings_initialize): Call init_gsettings.
4728 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4729 to NULL.
4730
640c8776 4731 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4732 GCONF_CFLAGS/LIBS.
4733
5386012d
MR
47342011-06-29 Martin Rudalics <rudalics@gmx.at>
4735
4736 * window.c (resize_root_window, grow_mini_window)
4737 (shrink_mini_window): Rename Qresize_root_window to
4738 Qwindow_resize_root_window and Qresize_root_window_vertically to
4739 Qwindow_resize_root_window_vertically.
4740
f13e0b08
PE
47412011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4742
4743 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4744
94515237
JB
47452011-06-27 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * makefile.w32-in: Redesign dependencies so they reflect more
4748 clearly which files are directly included by each source file,
4749 and not through other includes.
4750
e43b6e43
MR
47512011-06-27 Martin Rudalics <rudalics@gmx.at>
4752
4753 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4754 (sort_overlays, overlay_strings): When an overlay's clone number
4755 matches the window's clone number process the overlay even if
4756 the overlay's window property doesn't match the current window.
4757
d68443dc
MR
4758 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4759 (Fwindow_hchild): Rename to Fwindow_left_child.
4760 (Fwindow_next): Rename to Fwindow_next_sibling.
4761 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4762 (resize_window_check): Rename to window_resize_check.
4763 (resize_window_apply): Rename to window_resize_apply.
4764 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4765 (Fdelete_other_windows_internal, resize_frame_windows)
4766 (Fsplit_window_internal, Fdelete_window_internal)
4767 (grow_mini_window, shrink_mini_window)
4768 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4769
c7e73be5
JD
47702011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4771
4772 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4773 (emacs_fixed_set_min_size): Remove.
4774 (emacs_fixed_new): Take frame as argument.
4775
4776 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4777 (_EmacsFixedPrivate): Remove minwidth/height.
4778 Add struct frame *f.
4779 (emacs_fixed_init): Initialize priv->f.
4780 (get_parent_class, emacs_fixed_set_min_size): Remove.
4781 (emacs_fixed_new): Set priv->f to argument.
4782 (emacs_fixed_get_preferred_width)
4783 (emacs_fixed_get_preferred_height): Use min_width/height from
4784 frames size_hint to set minimum and natural (Bug#8919).
4785 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4786 and use min_width/height from frames size_hint to set
4787 min_width/height (Bug#8919).
4788
4789 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4790 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4791 Fix indentation.
c7e73be5 4792
cf99dcf8
EZ
47932011-06-26 Eli Zaretskii <eliz@gnu.org>
4794
4795 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4796 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4797 called at ZV.
4798
029529ac
CY
47992011-06-26 Chong Yidong <cyd@stupidchicken.com>
4800
4801 * process.c (wait_reading_process_output): Bypass select if
4802 waiting for a cell while ignoring keyboard input, and input is
4803 pending. Suggested by Jan Djärv (Bug#8869).
4804
7a7ef429
PE
48052011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4806
4807 Use gnulib's dup2 module instead of rolling our own.
4808 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4809
11fdef7d 48102011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4811
4812 * dispnew.c (scrolling_window): Before scrolling, turn off a
4813 mouse-highlight in the window being scrolled.
4814
cd3520a4
JB
48152011-06-24 Juanma Barranquero <lekktu@gmail.com>
4816
4817 Move DEFSYM to lisp.h and use everywhere.
4818
4819 * character.h (DEFSYM): Move declaration...
4820 * lisp.h (DEFSYM): ...here.
4821
4822 * gnutls.c:
4823 * minibuf.c:
4824 * w32menu.c:
4825 * w32proc.c:
4826 * w32select.c: Don't include character.h.
4827
4828 * alloc.c (syms_of_alloc):
4829 * buffer.c (syms_of_buffer):
4830 * bytecode.c (syms_of_bytecode):
4831 * callint.c (syms_of_callint):
4832 * casefiddle.c (syms_of_casefiddle):
4833 * casetab.c (init_casetab_once):
4834 * category.c (init_category_once, syms_of_category):
4835 * ccl.c (syms_of_ccl):
4836 * cmds.c (syms_of_cmds):
4837 * composite.c (syms_of_composite):
4838 * dbusbind.c (syms_of_dbusbind):
4839 * dired.c (syms_of_dired):
4840 * dispnew.c (syms_of_display):
4841 * doc.c (syms_of_doc):
4842 * editfns.c (syms_of_editfns):
4843 * emacs.c (syms_of_emacs):
4844 * eval.c (syms_of_eval):
4845 * fileio.c (syms_of_fileio):
4846 * fns.c (syms_of_fns):
4847 * frame.c (syms_of_frame):
4848 * fringe.c (syms_of_fringe):
4849 * insdel.c (syms_of_insdel):
4850 * keymap.c (syms_of_keymap):
4851 * lread.c (init_obarray, syms_of_lread):
4852 * macros.c (syms_of_macros):
4853 * msdos.c (syms_of_msdos):
4854 * print.c (syms_of_print):
4855 * process.c (syms_of_process):
4856 * search.c (syms_of_search):
4857 * sound.c (syms_of_sound):
4858 * syntax.c (init_syntax_once, syms_of_syntax):
4859 * terminal.c (syms_of_terminal):
4860 * textprop.c (syms_of_textprop):
4861 * undo.c (syms_of_undo):
4862 * w32.c (globals_of_w32):
4863 * window.c (syms_of_window):
4864 * xdisp.c (syms_of_xdisp):
4865 * xfaces.c (syms_of_xfaces):
4866 * xfns.c (syms_of_xfns):
4867 * xmenu.c (syms_of_xmenu):
4868 * xsettings.c (syms_of_xsettings):
4869 * xterm.c (syms_of_xterm): Use DEFSYM.
4870
4228cf16
TZ
48712011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4872
cd3520a4 4873 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4874
7fcccf1e
PE
48752011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4876
7efb4e0e
PE
4877 Integer and buffer overflow fixes (Bug#8873).
4878
ff5844ad
PE
4879 * print.c (printchar, strout): Check for string overflow.
4880 (PRINTPREPARE, printchar, strout):
4881 Don't set size unless allocation succeeds.
4882
90532f02
PE
4883 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4884 for sizes. Check for string overflow more accurately.
4885 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4886
6d84508d
PE
4887 * macros.c: Integer and buffer overflow fixes.
4888 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4889 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4890 Use ptrdiff_t, not int, for sizes.
4891 Don't increment bufsize until after realloc succeeds.
4892 Check for size-calculation overflow.
4893 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4894
437b2cb4
PE
4895 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4896
8b9ac8b4
PE
4897 * lread.c: Integer overflow fixes.
4898 (read_integer): Radix is now EMACS_INT, not int,
4899 to improve quality of diagnostics for out-of-range radices.
4900 Calculate buffer size correctly for out-of-range radices.
4901 (read1): Check for integer overflow in radices, and in
4902 read-circle numbers.
82cb60d3
PE
4903 (read_escape): Avoid int overflow.
4904 (Fload, openp, read_buffer_size, read1)
4905 (substitute_object_recurse, read_vector, read_list, map_obarray):
4906 Use ptrdiff_t, not int, for sizes.
4907 (read1): Use EMACS_INT, not int, for sizes.
20270765 4908 Check for size overflow.
8b9ac8b4 4909
7fcccf1e
PE
4910 * image.c (cache_image): Check for size arithmetic overflow.
4911
bfbbd7e7
PE
4912 * lread.c: Integer overflow issues.
4913 (saved_doc_string_size, saved_doc_string_length)
4914 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4915 Now ptrdiff_t, not int.
4916 (read1): Don't assume doc string length fits in int. Check for
4917 out-of-range doc string lengths.
4918 (read_list): Don't assume file position fits in int.
39019e54 4919 (read_escape): Check for hex character overflow.
bfbbd7e7 4920
4e323265
LL
49212011-06-22 Leo Liu <sdl.web@gmail.com>
4922
4923 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4924 Move to minibuffer.el.
4925
85fece3e
PE
49262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4927
20b84ce9 4928 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4929 The following patches are for when GLYPH_DEBUG && !XASSERT.
4930 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4931 * dispnew.c (flush_stdout):
4932 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4933 Mark as externally visible.
4934 * dispnew.c (check_window_matrix_pointers): Now static.
4935 * dispnew.c (window_to_frame_vpos):
4936 * xfns.c (unwind_create_frame):
4937 * xterm.c (x_check_font): Remove unused local.
4938 * scroll.c (CHECK_BOUNDS):
4939 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4940 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4941 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4942 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4943 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4944 Now static.
4945 (debug_method_add): Use va_list and vsprintf rather than relying
4946 on undefined behavior with wrong number of arguments.
4947 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4948 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4949 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4950 since we're not interested in debugging glyphs with old libraries.
4951 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4952 GCC 4.6.0's static checking.
4953
0766b489
PE
49542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4955
31fd4b32
PE
4956 Integer overflow and signedness fixes (Bug#8873).
4957 A few related buffer overrun fixes, too.
4958
b79e8648
PE
4959 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4960
0766b489
PE
4961 * dispextern.h (struct face.stipple):
4962 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4963 (x_bitmap_mask, x_allocate_bitmap_record)
4964 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4965 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4966 (x_create_bitmap_from_xpm_data):
4967 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4968 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4969 (.bitmaps_last):
4970 * xfaces.c (load_pixmap):
4971 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4972 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4973 (.bitmaps_last, struct x_output.icon_bitmap):
4974 Use ptrdiff_t, not int, for bitmap indexes.
4975 (x_allocate_bitmap_record): Check for size overflow.
4976 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4977
b081724f
PE
4978 Use ptrdiff_t, not int, for overlay counts.
4979 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4980 * editfns.c (overlays_around, get_pos_property):
4981 * textprop.c (get_char_property_and_overlay):
4982 * xdisp.c (next_overlay_change, note_mouse_highlight):
4983 * xfaces.c (face_at_buffer_position):
21514da7
PE
4984 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4985 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4986 (Fnext_overlay_change, Fprevious_overlay_change)
4987 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4988 Use ptrdiff_t, not int, for sizes.
21514da7 4989 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4990
3de73e5e
PE
4991 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4992
2606c57b
PE
4993 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4994 (x_session_initialize): Do not assume string length fits in int.
4995
aaafe47a
PE
4996 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4997 This is unlikely, but can occur if DPI is outlandish.
4998
2674ddc8 4999 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5000 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5001
28154962
PE
5002 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5003 * xrdb.c (magic_file_p, search_magic_path):
5004 Omit last arg SUFFIX; it was always 0. All callers changed.
5005 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5006
7de51af5
PE
5007 * xfont.c (xfont_match): Avoid need for strlen.
5008
25ed6cc3
PE
5009 * xfns.c: Don't assume strlen fits in int.
5010 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5011
4eab31dd
PE
5012 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5013 not unsigned long, as we prefer signed integers. All callers changed.
5014 Detect integer overflow in repeat count.
5015 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5016 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5017
171e2a58
PE
5018 * termcap.c: Don't assume sizes fit in int and never overflow.
5019 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5020 (gobble_line): Check for size-calculation overflow.
5021
ad39faca 5022 * minibuf.c (Fread_buffer):
6e5bb2dc 5023 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5024 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5025 Don't assume string length fits in int.
5026
52c61c22 5027 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5028 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5029
b5b8c9e5
PE
5030 * font.c: Don't assume string length fits in int.
5031 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5032 Use ptrdiff_t, not int.
ccd6111c
PE
5033 (font_intern_prop): Don't assume string length fits in int.
5034 Don't assume integer property fits in fixnum.
5035 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5036
882f0d81 5037 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5038 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5039 Reformulate so as not to need the command string.
5040 Invoke gzip -cd rather than gunzip, as it's more portable.
5041 (lock_info_type, lock_file_1, lock_file):
5042 Don't assume pid_t and time_t fit in unsigned long.
5043 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5044 (current_lock_owner): Prefer signed type for sizes.
5045 Use memcpy, not strncpy, where memcpy is what is really wanted.
5046 Don't assume (via atoi) that time_t and pid_t fit in int.
5047 Check for time_t and/or pid_t out of range, e.g., via a network share.
5048 Don't alloca where an auto var works fine.
5049
93f4cf88
PE
5050 * fileio.c: Fix some integer overflow issues.
5051 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5052 Don't assume string length fits in int.
5053 (directory_file_name): Don't assume string length fits in long.
5054 (make_temp_name): Don't assume pid fits in int, or that its print
5055 length is less than 20.
5056
f3e92b69
PE
5057 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5058
1bfdaf10
PE
5059 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5060
35016e9a
PE
5061 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5062
3d1e65a1
PE
5063 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5064 We prefer signed integers, even for size calculations.
5065
0b963a93
PE
5066 * emacs.c: Don't assume string length fits in 'int'.
5067 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5068 (main): Don't invoke strlen when not needed.
5069
573f4b54
PE
5070 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5071 (XD_DEBUG_MESSAGE): Don't waste a byte.
5072
989f33ba
PE
5073 * callproc.c (getenv_internal_1, getenv_internal)
5074 (Fgetenv_internal):
965d34eb
PE
5075 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5076
e4d29b33
PE
5077 * lread.c (invalid_syntax): Omit length argument.
5078 All uses changed. This doesn't fix a bug, but it simplifies the
5079 code away from its former Hollerith-constant appearance, and it's
5080 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5081 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5082
eb49b136
PE
5083 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5084 This didn't break anything, but it didn't help either.
5085 It's confusing to put a bogus integer in a place where the actual
5086 value does not matter.
9f62aeb1 5087 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5088 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5089
15375a22
PE
5090 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5091 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5092 implementation.
b61cc01c
PE
5093 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5094 We prefer signed types, and the value cannot exceed the EMACS_INT
5095 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5096 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5097 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5098 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5099
53b2623d
PE
5100 * indent.c (sane_tab_width): New function.
5101 (current_column, scan_for_column, Findent_to, position_indentation)
5102 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5103 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5104
51cab52b 5105 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5106
f2ed8a70
PE
5107 * lisp.h (lint_assume): New macro.
5108 * composite.c (composition_gstring_put_cache):
5109 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5110
abe80cc6
PE
5111 * editfns.c, insdel.c:
5112 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5113
b02c740e
PE
5114 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5115
ebc96716
PE
5116 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5117
b4e50fa0 5118 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5119 Use much-faster test for byte-length change.
311d5d7c 5120 Don't assume string byte-length fits in 'int'.
a4cf38e4 5121 Check that character arg fits in 'int'.
85461888 5122 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5123
c0c1ee9f
PE
5124 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5125
a498d7f4
PE
5126 * fns.c (concat): Catch string overflow earlier.
5127 Do not rely on integer wraparound.
5128
51cab52b
PE
5129 * dispextern.h (struct it.overlay_strings_charpos)
5130 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5131 * xdisp.c (forward_to_next_line_start)
5132 (back_to_previous_visible_line_start)
5133 (reseat_at_next_visible_line_start, next_element_from_buffer):
5134 Don't arbitrarily truncate the value of 'selective' to int.
5135
76031fad
PE
5136 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5137
5eb55db9
PE
5138 * composite.c: Don't truncate sizes to 'int'.
5139 (composition_gstring_p, composition_reseat_it)
5140 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5141 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5142 not EMACS_UINT, for indexes.
5eb55db9 5143
0703a717
PE
5144 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5145
d6202519
PE
5146 * buffer.c: Include <verify.h>.
5147 (struct sortvec.priority, struct sortstr.priority):
8961a454 5148 Now EMACS_INT, not int.
c20998a7 5149 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5150 (struct sortstr.size, record_overlay_string)
5151 (struct sortstrlist.size, struct sortlist.used):
5152 Don't truncate size to int.
5153 (record_overlay_string): Check for size-calculation overflow.
d6202519 5154 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5155
d5a19415
JM
51562011-06-22 Jim Meyering <meyering@redhat.com>
5157
029529ac 5158 Don't leak an XBM-image-sized buffer
d5a19415
JM
5159 * image.c (xbm_load): Free the image buffer after using it.
5160
a9041e6c
PE
51612011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5162
5163 Port to Sun C.
5164 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5165 that Sun C diagnosed.
5166 * fns.c (secure_hash): Fix pointer signedness issue.
5167 * intervals.c (static_offset_intervals): New function.
5168 (offset_intervals): Use it.
5169
7f3f739f
LL
51702011-06-21 Leo Liu <sdl.web@gmail.com>
5171
5172 * deps.mk (fns.o):
5173 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5174 sha512.h.
5175
5176 * fns.c (secure_hash): Rename from crypto_hash_function and change
5177 the first arg to accept symbols.
5b66d427 5178 (Fsecure_hash): New primitive.
7f3f739f
LL
5179 (syms_of_fns): New symbols.
5180
76147d94
DD
51812011-06-20 Deniz Dogan <deniz@dogan.se>
5182
5183 * process.c (Fset_process_buffer): Clarify return value in
5184 docstring.
5185
7d7d0045
CY
51862011-06-18 Chong Yidong <cyd@stupidchicken.com>
5187
5188 * dispnew.c (add_window_display_history): Use BVAR.
5189
5190 * xdisp.c (debug_method_add): Use BVAR.
5191 (check_window_end, dump_glyph_matrix, dump_glyph)
5192 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5193
5194 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5195 Likewise.
5196
5197 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5198 check till after the cache is created in init_frame_faces.
5199
ff2bc410
SM
52002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5201
5202 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5203
28177add
PE
52042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5205
dd3482fe
PE
5206 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5207 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5208 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5209
393d71f3 5210 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5211 * fileio.c (Finsert_file_contents):
5212 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5213 Remove the old (too-loose) buffer overflow checks.
5214 They weren't needed, since make_gap checks for buffer overflow.
5215 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5216 The old code merely checked for Emacs fixnum overflow, and relied
5217 on undefined (wraparound) behavior. The new code avoids undefined
5218 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5219
2e6813b0 5220 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5221 Tune. Don't use wider integers than needed. Don't use alloca.
5222 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5223
599a9e4f
PE
5224 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5225
99561444
PE
5226 * insdel.c, lisp.h (buffer_overflow): New function.
5227 (insert_from_buffer_1, replace_range, replace_range_2):
5228 * insdel.c (make_gap_larger):
5229 * editfns.c (Finsert_char):
5230 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5231
28177add
PE
5232 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5233
e69dafad
PE
52342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5235
4baa020d 5236 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5237
b1c46f02
PE
5238 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5239 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5240
e69dafad
PE
5241 * fileio.c: Don't assume EMACS_INT fits in off_t.
5242 (emacs_lseek): New static function.
5243 (Finsert_file_contents, Fwrite_region): Use it.
5244 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5245
566684ea
PE
5246 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5247
e6966cd6
PE
5248 * fns.c: Don't overflow int when computing a list length.
5249 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5250 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5251 truncation on 64-bit hosts. Check for QUIT every
5252 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5253 faster and is responsive enough.
5254 (Flength): Report an error instead of overflowing an integer.
5255 (Fsafe_length): Return a float if the value is not representable
5256 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5257 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5258 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5259
dd0b0efb
PE
5260 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5261 (header_size, word_size): New constants.
5262 (allocate_vectorlike): Don't check size overflow here.
5263 (allocate_vector): Check it here instead, since this is the only
5264 caller of allocate_vectorlike that could cause overflow.
5265 Check that the new vector's length is representable as a fixnum.
5266
86fe5cfe
PE
5267 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5268 The previous code was bogus. For example, next_almost_prime (32)
5269 returned 39, which is undesirable as it is a multiple of 3; and
5270 next_almost_prime (24) returned 25, which is a multiple of 5 so
5271 why was the code bothering to check for multiples of 7?
5272
80e88859
PE
5273 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5274
4a2f0ad6
PE
5275 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5276
f66c7cf8
PE
5277 Variadic C functions now count arguments with ptrdiff_t.
5278 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5279 Back then I didn't know that the Emacs coding style prefers signed int.
5280 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5281 were being counted with int, which may truncate counts on 64-bit
5282 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5283 * lisp.h (struct Lisp_Subr.function.aMANY)
5284 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5285 Arg counts are now ptrdiff_t, not size_t.
5286 All variadic functions and their callers changed accordingly.
5287 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5288 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5289 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5290 * callint.c (Fcall_interactively): Check arg count for overflow,
5291 to avoid potential buffer overrun. Use signed char, not 'int',
5292 for 'varies' array, so that we needn't bother to check its size
5293 calculation for overflow.
5294 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5295 * eval.c (apply_lambda):
5296 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5297 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5298 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5299
a1759b76
PE
5300 * callint.c (Fcall_interactively): Don't use index var as event count.
5301
d96be9fc
PE
5302 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5303 * mem-limits.h (SIZE): Remove; no longer used.
5304
a690a978 5305 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5306
578c21e6
PE
5307 Remove unnecessary casts.
5308 * xterm.c (x_term_init):
5309 * xfns.c (x_set_border_pixel):
5310 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5311 These aren't needed now that we assume ANSI C.
5312
96f53c6c
PE
5313 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5314 It's more likely to cause problems (due to unsigned overflow)
5315 than to cure them.
5316
83c77d31
PE
5317 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5318
ee2079f1
PE
5319 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5320
6da65536
PE
5321 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5322
7147c4a4
PE
5323 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5324
193e32d9
PE
5325 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5326
e5533da6
PE
5327 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5328
9910e595
PE
5329 GLYPH_CODE_FACE returns EMACS_INT, not int.
5330 * dispextern.h (merge_faces):
5331 * xfaces.c (merge_faces):
01103c44
PE
5332 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5333 Don't assume EMACS_INT fits in int.
9910e595 5334
2638320e
PE
5335 * character.h (CHAR_VALID_P): Remove unused parameter.
5336 * fontset.c, lisp.h, xdisp.c: All uses changed.
5337
045eb8d9
PE
5338 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5339
c1f134b5
PE
5340 * fns.c (concat): Minor tuning based on overflow analysis.
5341 This doesn't fix any bugs. Use int to hold character, instead
5342 of constantly refetching from Emacs object. Use XFASTINT, not
5343 XINT, for value known to be a character. Don't bother comparing
5344 a single byte to 0400, as it's always less.
5345
395fcb93 5346 * floatfns.c (Fexpt):
327eeec8
PE
5347 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5348
abbd3d23
PE
5349 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5350 for characters.
5351
684a03ef
PE
5352 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5353
0fed43f3
PE
5354 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5355 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5356 incorrectly succeed when S was a string, because 4294967386 was
5357 truncated before it was used.
5358
8fd02eb7
PE
5359 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5360 Otherwise, an out-of-range integer could cause undefined behavior
5361 on a 64-bit host.
5362
f8c86b69
PE
5363 * composite.c: Use int, not EMACS_INT, for characters.
5364 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5365 EMACS_INT, for values that are known to be in character range.
5366 This doesn't fix any bugs but is the usual style inside Emacs and
5367 may generate better code on 32-bit machines.
5368
34206dd2
PE
5369 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5370 This is for reasons similar to the recent CHAR_STRING fix.
5371 * charset.c (Fencode_char): Check that character arg is actually
5372 a character. Pass an int to ENCODE_CHAR.
5373 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5374 wider than 'int', as a compile-time check to prevent future regressions
5375 in this area.
5376
c5958d4c 5377 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5378
5379 Make sure a 64-bit char is never passed to CHAR_STRING.
5380 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5381 by silently ignoring the top 32 bits, allowing some values
5382 that were far too large to be valid characters.
5383 * character.h: Include <verify.h>.
5384 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5385 arguments are no wider than unsigned, as a compile-time check
5386 to prevent future regressions in this area.
5387 * data.c (Faset):
01103c44 5388 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5389 (Fsubst_char_in_region):
5390 * fns.c (concat):
5391 * xdisp.c (decode_mode_spec_coding):
5392 Adjust to CHAR_STRING's new requirement.
5393 * editfns.c (Finsert_char, Fsubst_char_in_region):
5394 * fns.c (concat): Check that character args are actually
5395 characters. Without this test, these functions did the wrong
5396 thing with wildly out-of-range values on 64-bit hosts.
5397
d37ca623
PE
5398 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5399 These casts should not be needed on 32-bit hosts, either.
5400 * keyboard.c (read_char):
5401 * lread.c (Fload): Remove casts to unsigned.
5402
ea204efb
PE
5403 * lisp.h (UNSIGNED_CMP): New macro.
5404 This fixes comparison bugs on 64-bit hosts.
5405 (ASCII_CHAR_P): Use it.
5406 * casefiddle.c (casify_object):
01103c44 5407 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5408 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5409 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5410 * dispextern.h (FACE_FROM_ID):
5411 * keyboard.c (read_char): Use UNSIGNED_CMP.
5412
41cb286c
PE
5413 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5414 not to EMACS_INT, to avoid GCC warning.
5415
4a1b9832
PE
5416 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5417
55daad71
PE
5418 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5419 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5420 isn't needed on 32-bit machines.
8f95c75c 5421
01103c44
PE
5422 * buffer.c (Fgenerate_new_buffer_name):
5423 Use EMACS_INT for count, not int.
0ceccced 5424 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5425
5426 * data.c (Qcompiled_function): Now static.
5427
c6f072e7
PE
5428 * window.c (window_body_lines): Now static.
5429
20ce5912
PE
5430 * image.c (gif_load): Rename local to avoid shadowing.
5431
9c4c5f81
PE
5432 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5433 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5434 * alloc.c (make_save_value): Integer argument is now of type
5435 ptrdiff_t, not int.
5436 (mark_object): Use ptrdiff_t, not int.
5437 * lisp.h (pD): New macro.
5438 * print.c (print_object): Use it.
5439
c0c5c8ae
PE
5440 * alloc.c: Use EMACS_INT, not int, to count objects.
5441 (total_conses, total_markers, total_symbols, total_vector_size)
5442 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5443 (total_free_floats, total_floats, total_free_intervals)
5444 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5445 Now EMACS_INT, not int. All uses changed.
5446 (Fgarbage_collect): Compute overall total using a double, so that
5447 integer overflow is less likely to be a problem. Check for overflow
5448 when converting back to an integer.
5a25e253
PE
5449 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5450 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5451 These were 'int' variables that could overflow on 64-bit hosts;
5452 they were never used, so remove them instead of repairing them.
211a0b2a 5453 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5454 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5455 Previously, this ceilinged at INT_MAX, but that doesn't work on
5456 64-bit machines.
e46bb31a 5457 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5458
c78baabf 5459 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5460 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5461 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5462 when a (possibly-narrower) signed value would do just as well.
5463 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5464
c9d624c6
PE
5465 * alloc.c: Catch some string size overflows that we were missing.
5466 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5467 for convenience in STRING_BYTES_MAX.
5468 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5469 The definition here is exact; the one in lisp.h was approximate.
5470 (allocate_string_data): Check for string overflow. This catches
5471 some instances we weren't catching before. Also, it catches
5472 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5473 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5474 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5475
c9d624c6
PE
5476 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5477 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5478 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5479
353032ce
PE
5480 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5481
2bccce07
PE
5482 * alloc.c (Fmake_string): Check for out-of-range init.
5483
0ac30604
SM
54842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5485
5486 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5487
c195f2de
JD
54882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5489
5490 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5491 xg_get_default_scrollbar_width.
5492
5493 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5494 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5495 (style_changed_cb): Call update_theme_scrollbar_width and call
5496 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5497 all frames (Bug#8505).
5498 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5499 Call gtk_window_set_resizable if HAVE_GTK3.
5500 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5501 and height if HAVE_GTK3 (Bug#8505).
5502 (scroll_bar_width_for_theme): New variable.
5503 (update_theme_scrollbar_width): New function.
5504 (xg_get_default_scrollbar_width): Move code to
5505 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5506 (xg_initialize): Call update_theme_scrollbar_width.
5507
5508 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5509
5510 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5511
e10ac9f1
MR
55122011-06-12 Martin Rudalics <rudalics@gmx.at>
5513
5514 * frame.c (make_frame): Call other_buffer_safely instead of
5515 other_buffer.
5516
5517 * window.c (temp_output_buffer_show): Call display_buffer with
5518 second argument Vtemp_buffer_show_specifiers and reset latter
5519 immediately after the call.
5520 (Vtemp_buffer_show_specifiers): New variable.
5521 (auto_window_vscroll_p, next_screen_context_lines)
5522 (Vscroll_preserve_screen_position): Remove leading asterisks from
5523 doc-strings.
5524
2d3c217e 55252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5526
7b7f97e8 5527 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5528 * buffer.c (Qclone_number): Remove for now, as it's unused.
5529 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5530 (record_buffer): Remove unused local.
5531 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5532 (set_frame_buffer_list): Remove; unused.
5533 * frame.h (other_visible_frames): Remove decl.
5534 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5535 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5536 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5537 if HAVE_GPM.
5538 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5539 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5540 Define only if HAVE_GPM.
5541 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5542 (update_hints_inhibit): Remove; never set. All uses removed.
5543 * widgetprv.h (emacsFrameClassRec): Remove decl.
5544 * window.c (delete_deletable_window): Now returns void, since it
5545 wasn't returning anything.
5546 (compare_window_configurations): Remove unused locals.
5547 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5548 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5549 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5550 the same widths as pointers. This follows up on the 2011-05-06 patch.
5551 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5552 * xterm.h: Likewise.
5553 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5554
1384b89e
JB
55552011-06-12 Juanma Barranquero <lekktu@gmail.com>
5556
5557 * makefile.w32-in: Update dependencies.
5558 (LISP_H): Add lib/intprops.h.
5559
1100a63c
CY
55602011-06-11 Chong Yidong <cyd@stupidchicken.com>
5561
5562 * image.c (gif_load): Add animation frame delay to the metadata.
5563 (syms_of_image): Use DEFSYM. New symbol `delay'.
5564
6198ccd0
MR
55652011-06-11 Martin Rudalics <rudalics@gmx.at>
5566
5567 * window.c (delete_deletable_window): Re-add.
5568 (Fset_window_configuration): Rewrite to handle dead buffers and
5569 consequently deletable windows.
5570 (window_tree, Fwindow_tree): Remove. Supply functionality in
5571 window.el.
5572 (compare_window_configurations): Simplify code.
5573
b6e3633c
AS
55742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5575
1ab0dee5
AS
5576 * image.c (imagemagick_load_image): Fix type mismatch.
5577 (Fimagemagick_types): Likewise.
5578
b6e3633c
AS
5579 * window.h (replace_buffer_in_windows): Declare.
5580
9397e56f
MR
55812011-06-11 Martin Rudalics <rudalics@gmx.at>
5582
5583 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5584 Qclone_number. Remove external declaration of Qdelete_window.
5585 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5586 code.
640c8776
SM
5587 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5588 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5589 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5590 buffer list implementation.
5591 (other_buffer_safely): New function.
5592 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5593 calls to replace_buffer_in_windows and
5594 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5595 if allowed.
5596 (record_buffer): Inhibit quitting and rewrite using quittable
5597 functions. Run Qbuffer_list_update_hook if allowed.
5598 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5599 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5600 Move switch-to-buffer to window.el.
9397e56f
MR
5601 (bury-buffer): Move to window.el.
5602 (Vbuffer_list_update_hook): New variable.
5603
5604 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5605 section.
5606
5607 * window.h (resize_frame_windows): Move up in code.
5608 (Fwindow_frame): Remove EXFUN.
5609 (replace_buffer_in_all_windows): Remove prototype.
5610 (replace_buffer_in_windows_safely): Add prototype.
5611
5612 * window.c: Declare Qdelete_window static again. Move down
5613 declaration of select_count.
5614 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5615 (Fother_window): Move to window.el.
5616 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5617 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5618 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5619 window.el.
5620 (replace_buffer_in_windows): Implement by calling
5621 Qreplace_buffer_in_windows.
5622 (replace_buffer_in_all_windows): Remove with some functionality
5623 moved into replace_buffer_in_windows_safely.
5624 (replace_buffer_in_windows_safely): New function.
5625 (select_window_norecord, select_frame_norecord): Move in front
5626 of run_window_configuration_change_hook. Remove now obsolete
5627 declarations.
640c8776
SM
5628 (Fset_window_buffer): Rewrite doc-string.
5629 Call Qrecord_window_buffer.
9397e56f
MR
5630 (keys_of_window): Move binding for other-window to window.el.
5631
b50691aa
CY
56322011-06-11 Chong Yidong <cyd@stupidchicken.com>
5633
5634 * dispextern.h (struct image): Replace data member, whose int_val
5635 and ptr_val fields were not used by anything, with a single
5636 lisp_val object.
5637
5638 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5639 (gif_clear_image, gif_load, imagemagick_load_image)
5640 (gs_clear_image, gs_load): Callers changed.
5641
3f754b86
PE
56422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5643
cca69397
PE
5644 * buffer.h: Include <time.h>, for time_t.
5645 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5646
109e28d0
PE
5647 Fix minor problems found by static checking.
5648
60737f02
PE
5649 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5650
4b66faf3
PE
5651 Make identifiers static if they are not used in other modules.
5652 * data.c (Qcompiled_function, Qframe, Qvector):
5653 * image.c (QimageMagick, Qsvg):
5654 * minibuf.c (Qmetadata):
5655 * window.c (resize_window_check, resize_root_window): Now static.
5656 * window.h (resize_window_check, resize_root_window): Remove decls.
5657
109e28d0
PE
5658 * window.c (window_deletion_count, delete_deletable_window):
5659 Remove; unused.
46a4ce9e
PE
5660 (window_body_lines): Now static.
5661 (Fdelete_other_windows_internal): Mark vars as initialized.
5662 Make sure 'resize_failed' is initialized.
5663 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5664 (resize_window_apply): Remove unused local.
5665 * window.h (delete_deletable_window): Remove decl.
5666
109e28d0 5667 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5668 (imagemagick_load_image): Fix pointer signedness problem by changing
5669 last arg from unsigned char * to char *. All uses changed.
5670 Also, fix a local for similar reasons.
5671 Remove unused locals. Remove locals to avoid shadowing.
5672 (fn_rsvg_handle_free): Remove; unused.
5673 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5674 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5675
3f754b86
PE
5676 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5677
2547adb1
CY
56782011-06-10 Chong Yidong <cyd@stupidchicken.com>
5679
5680 * image.c (gif_load): Fix omitted cast error introduced by
5681 2011-06-06 change.
5682
2c8e37d4
MR
56832011-06-10 Martin Rudalics <rudalics@gmx.at>
5684
5685 * window.h (resize_proportionally, orig_total_lines)
5686 (orig_top_line): Remove from window structure.
5687 (set_window_height, set_window_width, change_window_heights)
5688 (Fdelete_window): Remove prototypes.
5689 (resize_frame_windows): Remove duplicate declaration.
5690
440a42e3
EZ
56912011-06-10 Eli Zaretskii <eliz@gnu.org>
5692
5693 * window.h (resize_frame_windows, resize_window_check)
5694 (delete_deletable_window, resize_root_window)
5695 (resize_frame_windows): Declare prototypes.
5696
5697 * window.c (resize_window_apply): Make definition be "static" to
5698 match the prototype.
5699
562dd5e9
MR
57002011-06-10 Martin Rudalics <rudalics@gmx.at>
5701
5702 * window.c: Remove declarations of Qwindow_size_fixed,
5703 window_min_size_1, window_min_size_2, window_min_size,
5704 size_window, window_fixed_size_p, enlarge_window, delete_window.
5705 Remove static from declaration of Qdelete_window, it's
5706 temporarily needed by Fbury_buffer.
5707 (replace_window): Don't assign orig_top_line and
5708 orig_total_lines.
5709 (Fdelete_window, delete_window): Remove. Window deletion is
5710 handled by window.el.
640c8776
SM
5711 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5712 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5713 (Fdelete_other_windows): Remove. Deleting other windows is
5714 handled by window.el.
5715 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5716 handled in window.el.
5717 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5718 Window minimum sizes are handled in window.el.
5719 (shrink_windows, size_window, set_window_height)
5720 (set_window_width, change_window_heights, window_height)
5721 (window_width, CURBEG, CURSIZE, enlarge_window)
5722 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5723 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5724 handled in window.el.
5725 (make_dummy_parent): Rename to make_parent_window and give it a
5726 second argument horflag.
5727 (make_window): Don't set resize_proportionally any more.
5728 (Fsplit_window): Remove. Windows are split in window.el.
5729 (save_restore_action, save_restore_orig_size)
5730 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5731 Resize mini windows in window.el.
5732 (grow_mini_window, shrink_mini_window): Implement by calling
5733 Qresize_root_window_vertically, resize_window_check and
5734 resize_window_apply.
640c8776
SM
5735 (saved_window, Fset_window_configuration, save_window_save):
5736 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5737 resize_proportionally.
5738 (window_min_height, window_min_width): Move to window.el.
5739 (keys_of_window): Move bindings for delete-other-windows,
5740 split-window, delete-window and enlarge-window to window.el.
5741
5742 * buffer.c: Temporarily extern Qdelete_window.
5743 (Fbury_buffer): Temporarily call Qdelete_window instead of
5744 Fdelete_window (Fbury_buffer will move to window.el soon).
5745
5746 * frame.c (set_menu_bar_lines_1): Remove code handling
5747 orig_top_line and orig_total_lines.
5748
5749 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5750 set_window_height but set heights directly.
5751 (change_frame_size_1): Use resize_frame_windows.
5752
5753 * xdisp.c (init_xdisp): Don't use set_window_height but set
5754 heights directly.
5755
640c8776
SM
5756 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5757 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5758 run_window_configuration_change_hook.
5759
5760 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5761 instead of change_window_heights and run
5762 run_window_configuration_change_hook.
5763
1a13852e
MR
57642011-06-09 Martin Rudalics <rudalics@gmx.at>
5765
5766 * window.c (replace_window): Rename second argument REPLACEMENT to
5767 NEW. New third argument SETFLAG. Rewrite.
5768 (delete_window, make_dummy_parent): Call replace_window with
5769 third argument 1.
5770 (window_list_1): Move down in code.
5771 (run_window_configuration_change_hook): Move set_buffer part
5772 before select_frame_norecord part in order to unwind correctly.
5773 Rename count1 to count.
5774 (recombine_windows, delete_deletable_window, resize_root_window)
5775 (Fdelete_other_windows_internal)
5776 (Frun_window_configuration_change_hook, make_parent_window)
5777 (resize_window_check, resize_window_apply, Fresize_window_apply)
5778 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5779 (Fdelete_window_internal, Fresize_mini_window_internal):
5780 New functions.
1a13852e
MR
5781 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5782
f3d1777e
MR
57832011-06-08 Martin Rudalics <rudalics@gmx.at>
5784
496e208e
MR
5785 * window.h (window): Add some new members to window structure -
5786 normal_lines, normal_cols, new_total, new_normal, clone_number,
5787 splits, nest, prev_buffers, next_buffers.
5788 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5789 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5790
f3d1777e
MR
5791 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5792 Remove.
496e208e
MR
5793 (make_dummy_parent): Set new members of windows structure.
5794 (make_window): Move down in code. Handle new members of window
5795 structure.
5796 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5797 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5798 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5799 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5800 (Fset_window_next_buffers, Fset_window_clone_number):
5801 New functions.
496e208e
MR
5802 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5803 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5804 Doc-string fixes.
5805 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5806 Argument WINDOW can be now internal window too.
5807 (Fwindow_use_time): Move up in code.
5808 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5809 Rewrite doc-string.
5810 (Fset_window_configuration, saved_window)
5811 (Fcurrent_window_configuration, save_window_save): Handle new
5812 members of window structure.
b9e809c2
MR
5813 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5814 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5815 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5816 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5817 Qget_mru_window, Qresize_root_window,
5818 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5819 Qauto_buffer_name; staticpro them.
f3d1777e 5820
abde8f8c
MR
58212011-06-07 Martin Rudalics <rudalics@gmx.at>
5822
5823 * window.c (Fwindow_total_size, Fwindow_left_column)
5824 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5825 (Fwindow_list_1): New functions.
5826 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5827 (Fwindow_width, Fscroll_left, Fscroll_right):
5828 Use window_body_cols instead of window_box_text_cols.
5829 (delete_window, Fset_window_configuration):
5830 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5831 (delete_all_subwindows): Take a window as argument and not a
5832 structure. Rewrite.
190b47e6
MR
5833 (window_loop): Remove handling of GET_LRU_WINDOW and
5834 GET_LARGEST_WINDOW.
5835 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5836
5837 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5838 window_box_text_cols. delete_all_subwindows now takes a
5839 Lisp_Object as argument.
abde8f8c 5840
640c8776
SM
5841 * indent.c (compute_motion, Fcompute_motion):
5842 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5843
fa8a67e6
MR
5844 * frame.c (delete_frame): Call delete_all_subwindows with root
5845 window as argument.
5846
a54e3482
DC
58472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5848
5849 * fns.c (Fputhash): Document return value.
5850
60002bf5
CY
58512011-06-06 Chong Yidong <cyd@stupidchicken.com>
5852
5853 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5854
0c671da6 58552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5856
b862a52a 5857 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5858
be44ca6c
PE
5859 Check for overflow when converting integer to cons and back.
5860 * charset.c (Fdefine_charset_internal, Fdecode_char):
5861 Use cons_to_unsigned to catch overflow.
5862 (Fencode_char): Use INTEGER_TO_CONS.
5863 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5864 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5865 * data.c (long_to_cons, cons_to_long): Remove.
5866 (cons_to_unsigned, cons_to_signed): New functions.
5867 These signal an error for invalid or out-of-range values.
5868 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5869 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5870 * font.c (Ffont_variation_glyphs):
5871 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5872 * lisp.h: Include <intprops.h>.
5873 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5874 (cons_to_signed, cons_to_unsigned): New decls.
5875 (long_to_cons, cons_to_long): Remove decls.
5876 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5877 (Fprimitive_undo): Use CONS_TO_INTEGER.
5878 * xfns.c (Fx_window_property): Likewise.
5879 * xselect.c: Include <limits.h>.
5880 (x_own_selection, selection_data_to_lisp_data):
5881 Use INTEGER_TO_CONS.
5882 (x_handle_selection_request, x_handle_selection_clear)
5883 (x_get_foreign_selection, Fx_disown_selection_internal)
5884 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5885 (lisp_data_to_selection_data): Use cons_to_unsigned.
5886 (x_fill_property_data): Use cons_to_signed.
5887 Report values out of range.
5888
d1f3d2af
PE
5889 Check for buffer and string overflow more precisely.
5890 * buffer.h (BUF_BYTES_MAX): New macro.
5891 * lisp.h (STRING_BYTES_MAX): New macro.
5892 * alloc.c (Fmake_string):
5893 * character.c (string_escape_byte8):
5894 * coding.c (coding_alloc_by_realloc):
5895 * doprnt.c (doprnt):
5896 * editfns.c (Fformat):
5897 * eval.c (verror):
5898 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5899 since they may not be the same number.
5900 * editfns.c (Finsert_char):
5901 * fileio.c (Finsert_file_contents):
5902 Likewise for BUF_BYTES_MAX.
5903
dd52fcea
PE
5904 * image.c: Use ptrdiff_t, not int, for sizes.
5905 (slurp_file): Switch from int to ptrdiff_t.
5906 All uses changed.
5907 (slurp_file): Check that file size fits in both size_t (for
5908 malloc) and ptrdiff_t (for sanity and safety).
5909
7f9bbdbb
PE
5910 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5911 if b->modtime has its maximal value.
5912
dfe18f82
PE
5913 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5914
84acfcf0
PE
5915 Don't assume time_t can fit into int.
5916 * buffer.h (struct buffer.modtime): Now time_t, not int.
5917 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5918 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5919
ccd9a01a
PE
5920 Minor fixes for signed vs unsigned integers.
5921 * character.h (MAYBE_UNIFY_CHAR):
5922 * charset.c (maybe_unify_char):
5923 * keyboard.c (read_char, reorder_modifiers):
5924 XINT -> XFASTINT, since the integer must be nonnegative.
5925 * ftfont.c (ftfont_spec_pattern):
5926 * keymap.c (access_keymap, silly_event_symbol_error):
5927 XUINT -> XFASTINT, since the integer must be nonnegative.
5928 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5929 since it makes no difference and we prefer signed.
5930 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5931 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5932 nonnegative.
5933
d6d100dd
SM
59342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5935
5936 * window.h (Fwindow_frame): Declare.
5937
2b6148e4
PE
59382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5939
5940 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5941 (SPARE_MEMORY): Always define.
5942 (LARGE_REQUEST): Remove.
5943 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5944
f230ecc9
MR
59452011-06-06 Martin Rudalics <rudalics@gmx.at>
5946
727e958e
MR
5947 * lisp.h: Move EXFUNS for Fframe_root_window,
5948 Fframe_first_window and Fset_frame_selected_window to window.h.
5949
5950 * window.h: Move EXFUNS for Fframe_root_window,
5951 Fframe_first_window and Fset_frame_selected_window here from
5952 lisp.h.
5953
5954 * frame.c (Fwindow_frame, Fframe_first_window)
5955 (Fframe_root_window, Fframe_selected_window)
5956 (Fset_frame_selected_window): Move to window.c.
5957 (Factive_minibuffer_window): Move to minibuf.c.
5958 (Fother_visible_frames_p): New function.
5959
5960 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5961
f230ecc9
MR
5962 * window.c (decode_window, decode_any_window): Move up in code.
5963 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5964 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5965 (Fwindow_buffer): Move up and rewrite doc-string.
5966 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5967 (Fwindow_prev): New functions.
727e958e
MR
5968 (Fwindow_frame): Move here from frame.c. Accept any window as
5969 argument.
5970 (Fframe_root_window, Fframe_first_window)
5971 (Fframe_selected_window): Move here from frame.c. Accept frame
5972 or arbitrary window as argument. Update doc-strings.
5973 (Fminibuffer_window): Move up in code.
5974 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5975 (Fset_frame_selected_window): Move here from frame.c.
5976 Marginal rewrite.
727e958e
MR
5977 (Fselected_window, select_window, Fselect_window): Move up in
5978 code. Minor doc-string fixes.
f230ecc9 5979
4d09bcf6
PE
59802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5983 Do not assume that spare memory exists; that assumption is valid
5984 only if SYSTEM_MALLOC.
5985 (LARGE_REQUEST): New macro, so that the issue of large requests
5986 is separated from the issue of spare memory.
5987
810928a2
AS
59882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5989
172418ad
AS
5990 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5991 format. (Bug#8806)
5992
43f862f7
AS
5993 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5994
810928a2
AS
5995 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5996 before statements.
5997
a059fe24
JD
59982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5999
6000 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6001
6002 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6003
6004 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6005 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6006
989bf368
JB
60072011-06-05 Juanma Barranquero <lekktu@gmail.com>
6008
6009 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6010
4b80f674
CY
60112011-06-04 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6014 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6015 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6016 New error handlers.
4b80f674
CY
6017 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6018 Obey Vx_select_enable_clipboard_manager. Catch errors in
6019 x_clipboard_manager_save (Bug#8779).
6020 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6021 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6022
99a33b77 60232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6024
6025 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6026
99a33b77 60272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6028
6029 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6030 in the current matrix if keep_current_p is non-zero.
6031
8264569d
EZ
60322011-06-04 Eli Zaretskii <eliz@gnu.org>
6033
6034 * bidi.c (bidi_level_of_next_char): Fix last change.
6035
57f97249
EZ
60362011-06-03 Eli Zaretskii <eliz@gnu.org>
6037
fec2107c 6038 Support bidi reordering of text covered by display properties.
57f97249 6039
fec2107c
EZ
6040 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6041 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6042 (bidi_cache_search, bidi_cache_iterator_state)
6043 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6044 (bidi_level_of_next_char, bidi_move_to_visually_next):
6045 Support character positions inside a run of characters covered by a
fec2107c
EZ
6046 display string.
6047 (bidi_paragraph_init, bidi_resolve_explicit_1)
6048 (bidi_level_of_next_char): Call bidi_fetch_char and
6049 bidi_fetch_char_advance instead of FETCH_CHAR and
6050 FETCH_CHAR_ADVANCE.
6051 (bidi_init_it): Initialize new members.
6052 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6053 definitions.
6054 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6055 instead of using explicit *_CHAR codes.
d6d100dd
SM
6056 (bidi_resolve_explicit, bidi_resolve_weak):
6057 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6058 bidirectional text is supported only in multibyte buffers.
6059 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6060 it to initialize the frame_window_p member of struct bidi_it.
6061 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6062 (bidi_resolve_explicit, bidi_resolve_weak)
6063 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6064 bidi_it->nchars is non-positive.
6065 (bidi_level_of_next_char): Don't try to lookup the cache for the
6066 next/previous character if nothing is cached there yet, or if we
6067 were just reseat()'ed to a new position.
c40e2fb2 6068
0e14fe90
EZ
6069 * xdisp.c (set_cursor_from_row): Set start and stop points
6070 according to the row's direction when priming the loop that looks
6071 for the glyph on which to display cursor.
6072 (single_display_spec_intangible_p): Function deleted.
6073 (display_prop_intangible_p): Reimplement to call
6074 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6075 Accept 3 additional arguments needed by handle_display_spec.
6076 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6077 values: lists, `(when COND...)' forms, etc.
6078 (single_display_spec_string_p): Support property values that are
6079 lists with the argument STRING its top-level element.
6080 (display_prop_string_p): Fix the condition for processing a
6081 property that is a list to be consistent with handle_display_spec.
fec2107c 6082 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6083 last portion of handle_display_prop.
6084 (compute_display_string_pos): Accept additional argument
6085 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6086 value of a `display' property is a "replacing spec".
6087 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6088 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6089 the display property, but just return a value indicating whether
6090 the display property will replace the characters it covers.
6091 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6092 frame_window_p members of struct bidi_it.
d6d100dd
SM
6093 (compute_display_string_pos, compute_display_string_end):
6094 New functions.
fec2107c
EZ
6095 (push_it): Accept second argument POSITION, where pop_it should
6096 jump to continue iteration.
6097 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6098
fec2107c
EZ
6099 * keyboard.c (adjust_point_for_property): Adjust the call to
6100 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6101
6102 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6103 (bidi_init_it): Update prototypes.
6104 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6105 (compute_display_string_pos, compute_display_string_end):
6106 Declare prototypes.
fec2107c
EZ
6107 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6108 EMACS_INT.
fc6f18ce 6109
40087514 61102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6111
57f53182
PE
6112 Malloc failure behavior now depends on size of allocation.
6113 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6114 * lisp.h: Change signatures accordingly.
6115 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6116 All callers changed. (Bug#8762)
6117
6118 * gnutls.c: Use Emacs's memory allocators.
6119 Without this change, the gnutls library would invoke malloc etc.
6120 directly, which causes problems on non-SYNC_INPUT hosts, and which
6121 runs afoul of improving memory_full behavior. (Bug#8761)
6122 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6123 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6124 xfree instead of the default malloc, realloc, free.
6125 (Fgnutls_boot): No need to check for memory allocation failure,
6126 since xmalloc does that for us.
6127
ac32cd99 6128 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6129 * category.c (hash_get_category_set):
6130 * ccl.c (ccl_driver):
6131 * charset.c (Fdefine_charset_internal):
6132 * charset.h (struct charset.hash_index):
6133 * composite.c (get_composition_id, gstring_lookup_cache)
6134 (composition_gstring_put_cache):
6135 * composite.h (struct composition.hash_index):
6136 * dispextern.h (struct image.hash):
6137 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6138 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6139 (hashfn_equal, hashfn_user_defined, make_hash_table)
6140 (maybe_resize_hash_table, hash_lookup, hash_put)
6141 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6142 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6143 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6144 * image.c (make_image, search_image_cache, lookup_image)
6145 (xpm_put_color_table_h):
6146 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6147 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6148 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6149 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6150 * alloc.c (allocate_vectorlike):
6151 Check for overflow in vector size calculations.
6152 * ccl.c (ccl_driver):
6153 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6154 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6155 need to be updated by these changes.
40087514
PE
6156 * fns.c (make_hash_table, maybe_resize_hash_table):
6157 Check for integer overflow with large hash tables.
0de4bb68
PE
6158 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6159 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6160 (SXHASH_REDUCE): New macro.
6161 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6162 Use it instead of discarding useful hash info with large hash values.
6163 (sxhash_float): New function.
6164 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6165 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6166 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6167 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6168 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6169 Adjust signatures to match updated version of code.
6170 (consing_since_gc): Now EMACS_INT, since a single hash table can
6171 use more than INT_MAX bytes.
6172
698d32e2
DN
61732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6174
6175 Make it possible to build with GCC-4.6+ -O2 -flto.
6176
6177 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6178
fd6fa53f
SM
61792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6180
6181 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6182 Call minibuffer-inactive-mode.
6183
864db017
JB
61842011-05-31 Juanma Barranquero <lekktu@gmail.com>
6185
6186 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6187 Update dependencies.
6188
2ad0baf4
DN
61892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6190
6191 * data.c (init_data): Remove code for UTS, this system is not
6192 supported anymore.
6193
4fcc2638
DN
61942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6195
6196 Don't force ./temacs to start in terminal mode.
6197
6198 * frame.c (make_initial_frame): Initialize faces in all cases, not
6199 only when CANNOT_DUMP is defined.
6200 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6201
c56e0fd5
DN
62022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6203
6204 * dispnew.c (add_window_display_history): Use const for the string
6205 pointer. Remove declaration, not needed.
6206
333d54da 62072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6208
55d4c1b2 6209 Use 'inline', not 'INLINE'.
333d54da 6210 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6211 * alloc.c, fontset.c (INLINE): Remove.
6212 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6213 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6214 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6215 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6216 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6217
738db178
DN
62182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6219
6220 Make it possible to run ./temacs.
6221
6222 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6223 syms_of_callproc does the same thing. Remove test for
6224 "initialized", do it in the caller.
6225 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6226
620c53a6
SM
62272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6228
6229 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6230 (read_minibuf): Use get_minibuffer.
6231 (syms_of_minibuf): Use DEFSYM.
6232 (Qmetadata): New var.
6233 * data.c (Qbuffer): Don't make it static.
6234 (syms_of_data): Use DEFSYM.
6235
e003a292
PE
62362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6237
6238 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6239 (CCL_CODE_MIN): New macro.
6240
ed008a6d
PE
62412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6242
3687c2ef
PE
6243 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6244
ed008a6d
PE
6245 * eval.c (Qdebug): Now static.
6246 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6247 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6248 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6249
d66c4c7c
CY
62502011-05-29 Chong Yidong <cyd@stupidchicken.com>
6251
6252 * image.c: Various fixes to ImageMagick code comments.
6253 (Fimagemagick_types): Doc fix.
6254
5fbc2025
PE
62552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6256
0196f88a
PE
6257 Minor fixes prompted by GCC 4.6.0 warnings.
6258
6259 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6260
5fbc2025
PE
6261 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6262 (x_clipboard_manager_save_all): Move extern decl to ...
6263 * xterm.h: ... here, so that it can be checked for consistency.
6264
1dd3c2d9
CY
62652011-05-29 Chong Yidong <cyd@stupidchicken.com>
6266
6267 * xselect.c (x_clipboard_manager_save_frame)
6268 (x_clipboard_manager_save_all): New functions.
6269 (Fx_clipboard_manager_save): Lisp function deleted.
6270
6271 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6272 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6273
6274 * xterm.h: Update prototype.
6275
5ba6571d
WX
62762011-05-28 William Xu <william.xwl@gmail.com>
6277
6278 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6279 exiting (Bug#8239).
6280
3eaff834
JM
62812011-05-28 Jim Meyering <meyering@redhat.com>
6282
e1900994 6283 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6284 * fns.c (to_uchar): Define.
6285 (crypto_hash_function): Use it to convert some newly-signed
6286 variables to unsigned, to avoid sign-extension bugs. For example,
6287 without this change, (md5 "truc") would evaluate to
6288 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6289 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6290 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6291
0f6990a7
PE
62922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6293
6294 Integer overflow fixes.
c8a9ca5a 6295
08686060
PE
6296 * dbusbind.c: Serial number integer overflow fixes.
6297 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6298 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6299 to hold a serial number that is too large for a fixnum.
6300 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6301 Check for serial numbers out of range. Decode any serial number
59568bf0 6302 that was so large that it became a float. (Bug#8722)
08686060 6303
2d1fc3c7
PE
6304 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6305 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6306 Use XFASTINT rather than XUINT when numbers are nonnegative.
6307 (xd_append_arg, Fdbus_method_return_internal):
6308 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6309 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6310 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6311 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6312 (Bug#8722)
2d1fc3c7 6313
c8a9ca5a
PE
6314 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6315
519e1d69
PE
6316 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6317
6df6ae42 6318 ccl: Add integer overflow checks.
30569699
PE
6319 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6320 (IN_INT_RANGE): New macros.
6321 (ccl_driver): Use them to check for integer overflow when
6322 decoding a CCL program. Many of the new checks are whether XINT (x)
6323 fits in int; it doesn't always, on 64-bit hosts. The new version
6324 doesn't catch all possible integer overflows, but it's an
847044ea 6325 improvement. (Bug#8719)
30569699 6326
c11285dc
PE
6327 * alloc.c (make_event_array): Use XINT, not XUINT.
6328 There's no need for unsigned here.
6329
fdccd48e
PE
6330 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6331 This follows up to the 2011-05-06 change that substituted uintptr_t
6332 for EMACS_INT. This case wasn't caught back then.
6333
37910ab2
PE
6334 Rework Fformat to avoid integer overflow issues.
6335 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6336 now (part of C89). Include <verify.h>.
6337 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6338 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6339 (Fformat): Avoid the prepass trying to compute sizes; it was only
6340 approximate and thus did not catch overflow reliably. Instead, walk
6341 through the format just once, formatting and computing sizes as we go,
6342 checking for integer overflow at every step, and allocating a larger
6343 buffer as needed. Keep track separately whether the format is
6344 multibyte. Keep only the most-recently calculated precision, rather
6345 than them all. Record whether each argument has been converted to
6346 string. Use EMACS_INT, not int, for byte and char and arg counts.
6347 Support field widths and precisions larger than INT_MAX. Avoid
6348 sprintf's undefined behavior with conversion specifications such as %#d
6349 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6350 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6351 formatting out-of-range floating point numbers with int
9173deec 6352 formats. (Bug#8668)
37910ab2 6353
2e6578fb
PE
6354 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6355
0ae6bdee
PE
6356 * data.c: Avoid integer truncation in expressions involving floats.
6357 * data.c: Include <intprops.h>.
6358 (arith_driver): When there's an integer overflow in an expression
6359 involving floating point, convert the integers to floating point
6360 so that the resulting value does not suffer from catastrophic
6361 integer truncation. For example, on a 64-bit host (* 4
6362 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6363 Do not rely on undefined behavior after integer overflow.
6364
de883a70
PE
6365 merge count_size_as_multibyte, parse_str_to_multibyte
6366 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6367 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6368 Check for integer overflow.
6369 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6370 since it's now a duplicate of the other. This is more of
6371 a character than a buffer op, so better that it's in character.c.
6372 * fns.c, print.c: Adjust to above changes.
6373
2ff916cb
PE
63742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6375
6376 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6377
f1b54466
PE
63782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6379
fb1ac845
PE
6380 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6381 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6382 (x_clipboard_manager_save): Now static.
6383 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6384
f1b54466
PE
6385 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6386 (crypto_hash_function): Now static.
6387 Fix pointer signedness problems. Avoid unnecessary initializations.
6388
a9f737ee
CY
63892011-05-27 Chong Yidong <cyd@stupidchicken.com>
6390
6391 * termhooks.h (Vselection_alist): Make it terminal-local.
6392
6393 * terminal.c (create_terminal): Initialize it.
6394
6395 * xselect.c: Support for clipboard managers.
6396 (Vselection_alist): Move to termhooks.h as terminal-local var.
6397 (LOCAL_SELECTION): New macro.
6398 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6399 (symbol_to_x_atom): Remove gratuitous arg.
6400 (x_handle_selection_request, lisp_data_to_selection_data)
6401 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6402 (x_own_selection, x_get_local_selection, x_convert_selection):
6403 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6404 (some_frame_on_display): Delete unused function.
6405 (Fx_own_selection_internal, Fx_get_selection_internal)
6406 (Fx_disown_selection_internal, Fx_selection_owner_p)
6407 (Fx_selection_exists_p): New optional frame arg.
6408 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6409 (x_handle_selection_clear): Don't treat other terminals with the
6410 same keyboard specially. Use the terminal-local Vselection_alist.
6411 (x_clear_frame_selections): Use Frun_hook_with_args.
6412
6413 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6414
6415 * xterm.h: Add support for those atoms.
6416
e067f0c1
CY
64172011-05-26 Chong Yidong <cyd@stupidchicken.com>
6418
6419 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6420 (converted_selections, conversion_fail_tag): New global variables.
6421 (x_selection_request_lisp_error): Free the above.
6422 (x_get_local_selection): Remove unnecessary code.
6423 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6424 of converted selections stored in converted_selections.
6425 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6426 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6427 (x_convert_selection): New function.
6428 (x_handle_selection_event): Simplify.
6429 (x_get_foreign_selection): Don't ignore incoming requests while
6430 waiting for an answer; this will fail when we implement
6431 SAVE_TARGETS, and seems unnecessary anyway.
6432 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6433 (Vx_sent_selection_functions): Doc fix.
6434
0f4aebc0
LL
64352011-05-26 Leo Liu <sdl.web@gmail.com>
6436
6437 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6438
e61124cd
YM
64392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6440
6441 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6442
6443 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6444 for fringe update if it has periodic bitmap.
ac389d0c 6445 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6446 and fringe_bitmap_periodic_p.
6447
6448 * fringe.c (get_fringe_bitmap_data): New function.
6449 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6450 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6451 row. Mark glyph row for fringe update if periodicity changed.
6452
6453 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6454 for fringe update unless it has periodic bitmap.
6455
f16d9837
KH
64562011-05-25 Kenichi Handa <handa@m17n.org>
6457
6458 * xdisp.c (get_next_display_element): Set correct it->face_id for
6459 a static composition.
6460
e1b90ef6
LL
64612011-05-24 Leo Liu <sdl.web@gmail.com>
6462
6463 * deps.mk (fns.o):
6464 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6465
6466 * fns.c (crypto_hash_function, Fsha1): New function.
6467 (Fmd5): Use crypto_hash_function.
6468 (syms_of_fns): Add Ssha1.
6469
7400048f
PE
64702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6471
6472 * gnutls.c: Remove unused macros.
6473 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6474 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6475 Remove macros that are defined and never used.
6476 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6477
abb71cf4
CY
64782011-05-22 Chong Yidong <cyd@stupidchicken.com>
6479
6480 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6481 (Fx_get_selection_internal): Minor cleanup.
6482 (Fx_own_selection_internal): Rename arguments for consistency with
6483 select.el.
6484
6307db39
PE
64852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6486
6487 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6488
f3d4e0a4
CY
64892011-05-22 Chong Yidong <cyd@stupidchicken.com>
6490
6491 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6492
4d8ade89
YM
64932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6494
6495 * dispnew.c (scrolling_window): Don't exclude the case that the
6496 last enabled row in the desired matrix touches the bottom boundary.
6497
32078c8d
GM
64982011-05-21 Glenn Morris <rgm@gnu.org>
6499
6500 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6501 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6502 and add some more files.
32078c8d 6503
7285dc67
EZ
65042011-05-20 Eli Zaretskii <eliz@gnu.org>
6505
6506 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6507 report_file_error introduced by the change from 2011-05-07.
6508
89d1bd22
PE
65092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6510
6511 * systime.h (Time): Define only if emacs is defined.
6512 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6513 where the include path doesn't have X11/X.h by default. See
6514 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6515
cd394be1 65162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6517
6518 * composite.c (find_automatic_composition): Fix previous change.
6519
b9704ad9
GM
65202011-05-20 Glenn Morris <rgm@gnu.org>
6521
6522 * lisp.mk: New file, split from Makefile.in.
6523 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6524 (shortlisp): Remove.
6525 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6526
4a720484
GM
65272011-05-19 Glenn Morris <rgm@gnu.org>
6528
6529 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6530 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6531 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6532 (lisp): Set the order to that of loadup.el.
6533 (shortlisp): Make it a copy of $lisp.
6534 (SOME_MACHINE_LISP): Remove.
6535 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6536 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6537
a28d4396
KH
65382011-05-18 Kenichi Handa <handa@m17n.org>
6539
6540 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6541 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6542 (find_automatic_composition): Mostly rewrite for efficiency.
6543
a2b1fa8e
JB
65442011-05-18 Juanma Barranquero <lekktu@gmail.com>
6545
6546 * makefile.w32-in: Update dependencies.
6547
8e1f5610
CS
65482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6549
6550 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6551 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6552
7025ee00 65532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6554
cdfa6eab
PE
6555 Fix some integer overflow issues, such as string length overflow.
6556
06d6db33
PE
6557 * insdel.c (count_size_as_multibyte): Check for string overflow.
6558
2b4560a8
PE
6559 * character.c (lisp_string_width): Check for string overflow.
6560 Use EMACS_INT, not int, for string indexes and lengths; in
6561 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6562 the resulting string length overflows an EMACS_INT; instead,
6563 report a string overflow if no precision given. When checking for
6564 precision exhaustion, use a check that cannot possibly have
6565 integer overflow. (Bug#8675)
6566 * character.h (lisp_string_width): Adjust to new signature.
6567
cb93f9be
PE
6568 * alloc.c (string_overflow): New function.
6569 (Fmake_string): Use it. This doesn't change behavior, but saves
6570 a few bytes and will simplify future changes.
6571 * character.c (string_escape_byte8): Likewise.
6572 * lisp.h (string_overflow): New decl.
6573
1a1f3366
PE
6574 Fixups, following up to the user-interface timestamp change.
6575 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6576 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6577 * msdos.c (mouse_get_pos): Likewise.
6578 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6579 * w32gui.h (Time): Define by including "systime.h" rather than by
6580 declaring it ourselves. (Bug#8664)
6581
d4e3e4d3
PE
6582 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6583 * image.c (clear_image_cache): Likewise.
6584
f6a24d19
PE
6585 * term.c (term_mouse_position): Don't assume time_t wraparound.
6586
08dc5ae6
PE
6587 Be more systematic about user-interface timestamps.
6588 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6589 and sometimes 'EMACS_UINT', to represent these timestamps.
6590 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6591 This makes the code easier to follow, and makes it easier to catch
6592 integer overflow bugs such as Bug#8664.
6593 * frame.c (Fmouse_position, Fmouse_pixel_position):
6594 Use Time, not unsigned long, for user-interface timestamps.
6595 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6596 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6597 * keyboard.h (last_event_timestamp): Likewise.
6598 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6599 * menu.h (xmenu_show): Likewise.
6600 * term.c (term_mouse_position): Likewise.
6601 * termhooks.h (struct input_event.timestamp): Likewise.
6602 (struct terminal.mouse_position_hook): Likewise.
6603 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6604 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6605 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6606 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6607 what it was before.
6608 * menu.h, termhooks.h: Include "systime.h", for Time.
6609
8e55734a
PE
6610 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6611 Don't assume that the difference between two unsigned long values
6612 can fit into an integer. At this point, we know button_down_time
6613 <= event->timestamp, so the difference must be nonnegative, so
6614 there's no need to cast the result if double-click-time is
6615 nonnegative, as it should be; check that it's nonnegative, just in
6616 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6617 apart (about 25 days). (Bug#8664)
8e55734a 6618
841f1b75 6619 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6620 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6621
3e26f69c
PE
6622 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6623 that always fit in int. Use a sentinel instead of a counter, to
6624 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6625 * frame.h (struct frame): Use int for menu_bar_items_used
6626 instead of EMACS_INT, since it always fits in int.
3e26f69c 6627
5cc152c0
PE
6628 * menu.c (grow_menu_items): Check for int overflow.
6629
d89eb65e
PE
6630 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6631
5235bd3e
PE
6632 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6633 Before, the code was not consistent. These values cannot exceed
6634 2**31 - 1 so there's no need to make them unsigned.
6635 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6636 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6637 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6638 as modifiers.
6639 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6640
bc827e23
PE
6641 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6642 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6643 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6644 presumably because the widths might not match.
6645
78eb494e
PE
6646 * window.c (size_window): Avoid needless test at loop start.
6647
04f2d78b
CB
66482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6649
6650 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6651
d2fc7e3d 66522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6653
6654 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6655
d2fc7e3d 66562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6657
6658 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6659 `width' to `bar_area_x' and `bar_area_width', respectively.
6660 (x_scroll_run): Take account of fringe background extension.
6661
04f2d78b
CB
6662 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6663 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6664 `bar_area_width', respectively.
6665 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6666 background extension.
6667
79b70037
GM
66682011-05-10 Jim Meyering <meyering@redhat.com>
6669
6670 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6671
2f142cc5
JB
66722011-05-10 Juanma Barranquero <lekktu@gmail.com>
6673
6674 * image.c (Finit_image_library): Return t for built-in image types,
6675 like pbm and xbm. (Bug#8640)
6676
57679c86
AS
66772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6678
6679 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6680
888c9e86
EZ
66812011-05-07 Eli Zaretskii <eliz@gnu.org>
6682
b0512a1d
EZ
6683 * w32console.c (Fset_screen_color): Doc fix.
6684 (Fget_screen_color): New function.
6685 (syms_of_ntterm): Defsubr it.
6686
7285dc67
EZ
6687 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6688 unlink the temporary file if Fcall_process didn't create it in the
6689 first place.
6690 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6691 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6692 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6693 cue to call_process_cleanup not to close that handle.
6694
4d3fcc8e
BK
66952011-05-07 Ben Key <bkey76@gmail.com>
6696
6697 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6698 one of two shell specific rules, either bootstrap-temacs-CMD or
6699 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6700 to the previous implementation of the bootstrap-temacs rule.
6701 The bootstrap-temacs-CMD rule is similar to the previous
6702 implementation of the bootstrap-temacs rule except that it
6703 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6704 variable.
6705
6706 These changes, along with some changes to nt/configure.bat,
6707 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6708 earlier fix to add support for --cflags and --ldflags options
6709 that include quotes so that it works whether make uses cmd or
6710 sh as the shell.
6711
b4289b64
MA
67122011-05-06 Michael Albinus <michael.albinus@gmx.de>
6713
6714 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6715 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6716 is a constant.
6717 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6718 a string. Handle both cases.
6719 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6720 (Fdbus_register_method): Use Qinvalid_function.
6721
af4c0e28
JB
67222011-05-06 Juanma Barranquero <lekktu@gmail.com>
6723
6724 * makefile.w32-in: Update dependencies.
6725 (LISP_H): Add inttypes.h and stdin.h.
6726 (PROCESS_H): Add unistd.h.
6727
c51453d9
EZ
67282011-05-06 Eli Zaretskii <eliz@gnu.org>
6729
6730 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6731 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6732
8ff0ac3c 67332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6734
4c4b566b
PE
6735 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6736
aab2b9b5
PE
6737 * term.c (vfatal): Remove stray call to va_end.
6738 It's not needed and the C Standard doesn't allow it here anyway.
6739
c378da0b
PE
6740 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6741 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6742
288b08c7
PE
6743 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6744 bytes.
6745
e3601888
PE
6746 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6747
db6c0e74
PE
6748 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6749
dd5963ea
PE
6750 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6751
88c9450f
PE
6752 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6753
2f9442b8
PE
6754 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6755
c032b5f8
PE
6756 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6757 * charset.c (Fdefine_charset_internal): Don't initialize
6758 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6759 32-bit int (Bug#8600).
a108c10b
PE
6760
6761 * lread.c (read_integer): Be more consistent with string-to-number.
6762 Use string_to_number to do the actual conversion; this avoids
6763 rounding errors and fixes some other screwups. Without this fix,
6764 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6765 (digit_to_number): Move earlier, for benefit of read_integer.
6766 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6767 not a digit in any supported base. (Bug#8602)
a108c10b 6768
ad5f9eea
PE
6769 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6770
aec1708a
PE
6771 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6772 to match comment at start of function. This also removes a
6773 GCC warning about overflow in a 32+64-bit port.
6774
47be4ab5
PE
6775 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6776
371cac43
PE
6777 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6778 Reported by Stefan Monnier in
6779 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6780 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6781 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6782
d01a7826
PE
6783 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6784 (EMACS_UINTPTR): Likewise, with uintptr_t.
6785
7fd47d5c
PE
6786 * lisp.h: Prefer 64-bit EMACS_INT if available.
6787 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6788 on 32-bit hosts that have 64-bit int, so that they can access
6789 large files.
122b0c86
PE
6790 However, temporarily disable this change unless the temporary
6791 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6792
8727937b
PE
6793 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6794
8ac068ac
PE
6795 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6796 This removes an assumption that EMACS_INT and long are the same
6797 width as pointers. The assumption is true for Emacs porting targets
6798 now, but we want to make other targets possible.
6799 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6800 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6801 In the rest of the code, change types of integers that hold casted
6802 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6803 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6804 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6805 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6806 No need to cast type when ORing.
6807 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6808 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6809 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6810 assume EMACS_INT is the same width as char *.
6811 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6812 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6813 Remove no-longer-needed casts.
6814 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6815 (xg_tool_bar_help_callback, xg_make_tool_item):
6816 Use EMACS_INTPTR to hold an integer
6817 that will be cast to void *; this can avoid a GCC warning
6818 if EMACS_INT is not the same width as void *.
6819 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6820 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6821 (current_message_1, set_message_1):
6822 Use a local to convert to proper width without a cast.
6823 * xmenu.c (dialog_selection_callback): Likewise.
6824
ede49d71
PE
6825 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6826 Also, don't assume VALBITS / RAND_BITS is less than 5,
6827 and don't rely on undefined behavior when shifting a 1 left into
6828 the sign bit.
6829 * lisp.h (get_random): Change signature to match.
6830
2f30ecd0
PE
6831 * lread.c (hash_string): Use size_t, not int, for hash computation.
6832 Normally we prefer signed values; but hashing is special, because
6833 it's better to use unsigned division on hash table sizes so that
6834 the remainder is nonnegative. Also, size_t is the natural width
6835 for hashing into memory. The previous code used 'int', which doesn't
6836 retain enough info to hash well into very large tables.
6837 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6838
2a866e7b
PE
6839 * dbusbind.c: Don't possibly lose pointer info when converting.
6840 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6841 Use XPNTR rather than XHASH, so that the high-order bits of
6842 the pointer aren't lost when converting through void *.
6843
51639eac
PE
6844 * eval.c (Fautoload): Don't double-shift a pointer.
6845
92394119
PE
6846 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6847
dbdb9a7c
JB
68482011-05-06 Juanma Barranquero <lekktu@gmail.com>
6849
6850 * gnutls.c (DEF_GNUTLS_FN):
6851 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6852
db7a0b4f
AS
68532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6854
6855 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6856 marker. (Bug#8610)
6857
cd394be1 68582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6859
6860 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6861 New version that can reserve upto 2GB of heap space.
6862
f7ff1b0f 68632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6864
6865 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6866
639c109b
TZ
68672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6868
6869 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6870 `gnutls_certificate_set_x509_key_file'.
6871
d2127135
JB
68722011-05-05 Juanma Barranquero <lekktu@gmail.com>
6873
6874 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6875 Update dependencies.
6876
e968f4f3
JB
68772011-05-04 Juanma Barranquero <lekktu@gmail.com>
6878
6879 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6880 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6881 Remove unused parameter `fildes'.
6882 * process.c (read_process_output, send_process): Don't pass it.
6883
84d358f0
JB
68842011-05-04 Juanma Barranquero <lekktu@gmail.com>
6885
6886 Fix previous change: the library cache is defined in w32.c.
6887 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6888 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6889
0898ca10
JB
68902011-05-04 Juanma Barranquero <lekktu@gmail.com>
6891
6892 Implement dynamic loading of GnuTLS on Windows.
6893
6894 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6895 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6896 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6897 Declare.
6898
6899 * gnutls.c (Qgnutls_dll): Define.
6900 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6901 (gnutls_*): Declare function pointers.
6902 (init_gnutls_functions): New function to initialize function pointers.
6903 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6904 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6905 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6906 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6907 (emacs_gnutls_write, emacs_gnutls_read)
6908 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6909 (Fgnutls_available_p): New function.
6910 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6911 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6912 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6913
6914 * image.c: Include w32.h.
6915 (Vimage_type_cache): Delete.
6916 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6917 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6918 (w32_delayed_load): Move to w32.c.
6919
6920 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6921
6922 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6923 (w32_delayed_load): Move from image.c. When loading a library, record
6924 its filename in the :loaded-from property of the library id.
6925 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6926 Initialize and staticpro them.
6927 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6928
6929 * process.c: Include lisp.h before w32.h, not after.
6930 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6931 instead of gnutls_record_check_pending.
6932
6933 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6934
ff4de4aa
TZ
69352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6936
6937 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6938 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6939 as passed in.
6940
abe95abb
JD
69412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6942
6943 * xterm.c (x_set_frame_alpha): Do not set property on anything
6944 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6945
e16e55d4
JB
69462011-05-02 Juanma Barranquero <lekktu@gmail.com>
6947
6948 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6949
bafcf6a5
JB
69502011-05-02 Juanma Barranquero <lekktu@gmail.com>
6951
6952 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6953 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6954 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6955 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6956 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6957 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6958 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6959 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6960 (Qgnutls_bootprop_callbacks_verify): Make static.
6961
e7a6747f
AS
69622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6963
19ed11ba
AS
6964 * callproc.c: Indentation fixup.
6965
e7a6747f 6966 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6967 (wait_for_termination, interruptible_wait_for_termination):
6968 Move after wait_for_termination_1.
e7a6747f 6969
1ef14cb4
LMI
69702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6971
6972 * sysdep.c (interruptible_wait_for_termination): New function
6973 which is like wait_for_termination, but allows keyboard
6974 interruptions.
6975
6976 * callproc.c (Fcall_process): Add (:file "file") as an option for
6977 the STDOUT buffer.
6978 (Fcall_process_region): Ditto.
6979
330d880c
EZ
69802011-04-30 Eli Zaretskii <eliz@gnu.org>
6981
8db90b73
EZ
6982 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6983 rather than `XVECTOR (FOO)->size'.
6984
330d880c
EZ
6985 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6986 inttypes.h, as a gnulib replacement is used if it not available in
6987 system headers.
6988
15cbd324
EZ
69892011-04-21 Eli Zaretskii <eliz@gnu.org>
6990
6991 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6992 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6993 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6994
6995 * coding.c (coding_alloc_by_realloc): Error out if destination
6996 will grow beyond MOST_POSITIVE_FIXNUM.
6997 (decode_coding_emacs_mule): Abort if there isn't enough place in
6998 charbuf for the composition carryover bytes. Reserve an extra
6999 space for up to 2 characters produced in a loop.
7000 (decode_coding_iso_2022): Abort if there isn't enough place in
7001 charbuf for the composition carryover bytes.
7002
70032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7004
ae940cca
EZ
7005 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7006 aborting when %lld or %lll format is passed.
7007 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7008 %llo or %llx format is passed. (Bug#8545)
7009
03ab8921
EZ
7010 * window.c (window_scroll_line_based): Use a marker instead of
7011 simple variables to record original value of point. (Bug#7952)
7012
afda1437
EZ
7013 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7014 produced by %s or %c overflows available buffer space. (Bug#8545)
7015
f76dee0c
PE
70162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7017
7018 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7019 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7020
fdc5744d
JB
70212011-04-28 Juanma Barranquero <lekktu@gmail.com>
7022
7023 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7024
638f053a
JB
70252011-04-28 Juanma Barranquero <lekktu@gmail.com>
7026
7027 * keyboard.c (Qdelayed_warnings_hook): Define.
7028 (command_loop_1): Run `delayed-warnings-hook'
7029 if Vdelayed_warnings_list is non-nil.
7030 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7031 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7032
d178f871
EZ
70332011-04-28 Eli Zaretskii <eliz@gnu.org>
7034
7035 * doprnt.c (doprnt): Don't return value smaller than the buffer
7036 size if the message was truncated. (Bug#8545).
7037
b124fd93
JB
70382011-04-28 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7041 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7042
e810457d
PE
70432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7044
7045 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7046
ea51cceb
JB
70472011-04-27 Juanma Barranquero <lekktu@gmail.com>
7048
7049 * makefile.w32-in: Update dependencies.
7050
94dcfacf
EZ
70512011-04-27 Eli Zaretskii <eliz@gnu.org>
7052
7053 Improve `doprnt' and its usage. (Bug#8545)
7054 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7055 `format_end'. Remove support for %l as a conversion specifier.
7056 Don't use xrealloc. Improve diagnostics when the %l size modifier
7057 is used. Update the commentary.
7058
7059 * eval.c (verror): Simplify calculation of size_t.
7060
7061 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7062 messages.
7063
f61f41d7
PE
70642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7065
7066 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7067 change.
7068
96fb4434
PE
70692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7070
7071 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7072 This makes this file independent of the recent pseudovector change.
7073
671875da 70742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7075
69e9b5a3
PE
7076 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7077
b5f869a7 7078 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7079 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7080 Remove unused local.
c8926152 7081 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7082
841a1577 7083 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7084 GCC 4.6.0 optimizes based on type-based alias analysis.
7085 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7086 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7087 != &v->size, and therefore "v->size = 1; b->size = 2; return
7088 v->size;" must therefore return 1. This assumption is incorrect
7089 for Emacs, since it type-puns struct Lisp_Vector * with many other
7090 types. To fix this problem, this patch adds a new type struct
f904488f 7091 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7092 and pseudovectors, and helps optimizing compilers not get fooled
7093 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7094 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7095 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7096 the size member.
eab3844f
PE
7097 (XSETPVECTYPE): Rewrite in terms of new macro.
7098 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7099 This is a bit clearer, and further avoids the possibility of
7100 undesirable aliasing.
7101 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7102 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7103 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7104 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7105 (ASIZE): Now uses header.size rather than size.
7106 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7107 to avoid the hassle of writing XVECTOR (foo)->header.size.
7108 (struct vectorlike_header): New type.
eab3844f
PE
7109 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7110 object, to help avoid aliasing.
7111 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7112 (SUBRP): Likewise, since Lisp_Subr is a special case.
7113 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7114 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7115 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7116 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7117 changed to be "header.size" and "header.next".
7118 * buffer.h (struct buffer): Likewise.
7119 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7120 * frame.h (struct frame): Likewise.
7121 * process.h (struct Lisp_Process): Likewise.
7122 * termhooks.h (struct terminal): Likewise.
7123 * window.c (struct save_window_data, struct saved_window): Likewise.
7124 * window.h (struct window): Likewise.
7125 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7126 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7127 * buffer.c (init_buffer_once): Likewise.
7128 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7129 special case.
7130 * process.c (Fformat_network_address): Use local var for size,
7131 for brevity.
7132
0df1eac5
PE
7133 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7134
847ab9d1 7135 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7136 * data.c (atof): Remove decl; no longer used or needed.
7137 (digit_to_number): Move to lread.c.
7138 (Fstring_to_number): Use new string_to_number function, to be
7139 consistent with how the Lisp reader treats infinities and NaNs.
7140 Do not assume that floating-point numbers represent EMACS_INT
7141 without losing information; this is not true on most 64-bit hosts.
7142 Avoid double-rounding errors, by insisting on integers when
7143 parsing non-base-10 numbers, as the documentation specifies.
7144 * lisp.h (string_to_number): New decl, replacing ...
7145 (isfloat_string): Remove.
bc0a5c13 7146 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7147 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7148 appears to have been a coding error. Similarly, do not accept
7149 strings like +-1e0 as floating point numbers. Do not report
7150 overflow for integer overflows unless the base is not 10 which
7151 means we have no simple and reliable way to continue.
7152 Break out the floating-point parsing into a new
7153 function string_to_number, so that Fstring_to_number parses
7154 floating point numbers consistently with the Lisp reader.
04f2d78b 7155 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7156 (E_CHAR, EXP_INT): Remove, replacing with ...
7157 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7158 (string_to_number): New function, replacing isfloat_string.
7159 This function checks for valid syntax and produces the resulting
7160 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7161 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7162 so that overflow for non-base-10 numbers is reported only when
7163 there's no portable and simple way to convert to floating point.
452f4150 7164
67769ffc
PE
7165 * textprop.c (set_text_properties_1): Rewrite for clarity,
7166 and to avoid GCC warning about integer overflow.
7167
c20db43f
PE
7168 * intervals.h (struct interval): Use EMACS_INT for members
7169 where EMACS_UINT might cause problems. See
7170 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7171 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7172 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7173 All uses changed.
37aa2f85
PE
7174 (offset_intervals): Tell GCC not to worry about length overflow
7175 when negating a negative length.
c20db43f 7176
2538aa2f
PE
7177 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7178 (overrun_check_free): Likewise.
7179
f2d3008d
PE
7180 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7181 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7182 word size.
7183
ec8df744
PE
7184 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7185 (gnutls_make_error): Rename local to avoid shadowing.
7186 (gnutls_emacs_global_deinit): ifdef out; not used.
7187 (Fgnutls_boot): Use const for pointer to readonly storage.
7188 Comment out unused local. Fix pointer signedness problems.
7189
640ee02d
PE
7190 * lread.c (openp): Don't stuff size_t into an 'int'.
7191 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7192 about possible signed overflow.
7193
6048fb2a
PE
7194 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7195 (GDK_KEY_g): Don't define if already defined.
7196 (xg_prepare_tooltip): Avoid pointer signedness problem.
7197 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7198
fa3c87e1
PE
7199 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7200 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7201
2172544b
PE
7202 * xfns.c (Fx_window_property): Simplify a bit,
7203 to make a bit faster and to avoid GCC 4.6.0 warning.
7204 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7205
9b821a21
PE
7206 * fns.c (internal_equal): Don't assume size_t fits in int.
7207
3c616cfa
PE
7208 * alloc.c (compact_small_strings): Tighten assertion a little.
7209
c2982e87
PE
7210 Replace pEd with more-general pI, and fix some printf arg casts.
7211 * lisp.h (pI): New macro, generalizing old pEd macro to other
7212 conversion specifiers. For example, use "...%"pI"d..." rather
7213 than "...%"pEd"...".
7214 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7215 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7216 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7217 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7218 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7219 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7220 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7221 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7222 64-bit hosts.
7223 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7224 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7225 * print.c (safe_debug_print, print_object): Likewise.
7226 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7227 to int.
6f04d126
PE
7228 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7229 avoiding the 0 flag, which is not portable.
c2982e87
PE
7230 * process.c (Fmake_network_process): Use pI to avoid cast.
7231 * region-cache.c (pp_cache): Likewise.
7232 * xdisp.c (decode_mode_spec): Likewise.
7233 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7234 behavior on 64-bit hosts with printf arg.
6f04d126 7235 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7236 (x_stop_queuing_selection_requests): Likewise.
7237 (x_get_window_property): Don't truncate byte count to an 'int'
7238 when tracing.
0b432f21 7239
5e073ec7
PE
7240 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7241 here, since it parses constructs like leading '-' and spaces,
7242 which are not wanted; and it overflows with large numbers.
7243 Instead, simply match F[0-9]+, which is what is wanted anyway.
7244
36372bf9
PE
7245 * alloc.c: Remove unportable assumptions about struct layout.
7246 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7247 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7248 (allocate_vectorlike, make_pure_vector): Use the new macros,
7249 plus offsetof, to remove unportable assumptions about struct layout.
7250 These assumptions hold on all porting targets that I know of, but
7251 they are not guaranteed, they're easy to remove, and removing them
7252 makes further changes easier.
7253
0b432f21
PE
7254 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7255 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7256 (string_overrun_cookie): Now const. Use initializers that
7257 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7258 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7259 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7260 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7261 multiple of sizeof (EMACS_INT); it need not be, if
7262 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7263 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7264
895009e1
JB
72652011-04-26 Juanma Barranquero <lekktu@gmail.com>
7266
7267 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7268
6a7a1b0b
TZ
72692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7270
7271 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7272 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7273 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7274
841a1577 72752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7276
7277 * lisp.h (Qdebug): List symbol.
895009e1 7278 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7279 * keyboard.c (debug-on-event): New variable.
7280 (handle_user_signal): Break into debugger when debug-on-event
7281 matches the current signal symbol.
7282
f2d3ba6f
DN
72832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7284
7285 * alloc.c (check_sblock, check_string_bytes)
7286 (check_string_free_list): Convert to standard C.
7287
42ce4c63
TZ
72882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7289
7290 * w32.c (emacs_gnutls_push): Fix typo.
7291
825cd63c
EZ
72922011-04-25 Eli Zaretskii <eliz@gnu.org>
7293
fb11d64d
EZ
7294 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7295 "cast to pointer from integer of different size".
7296
825cd63c
EZ
7297 Improve doprnt and its use in verror. (Bug#8545)
7298 * doprnt.c (doprnt): Document the set of format control sequences
7299 supported by the function. Use SAFE_ALLOCA instead of always
7300 using `alloca'.
7301
7302 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7303 is one byte too soon. Don't use xrealloc; instead xfree and
7304 xmalloc anew.
7305
e061a11b
TZ
73062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7307
7308 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7309 callbacks stage.
7310
7311 * gnutls.c: Renamed global_initialized to
7312 gnutls_global_initialized. Added internals for the
7313 :verify-hostname-error, :verify-error, and :verify-flags
7314 parameters of `gnutls-boot' and documented those parameters in the
7315 docstring. Start callback support.
9173deec
JB
7316 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7317 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7318 on error. Return error code.
e061a11b
TZ
7319 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7320 (emacs_gnutls_read): Likewise.
7321 (Fgnutls_boot): Return handshake error code.
7322 (emacs_gnutls_handle_error): New function.
7323 (wsaerror_to_errno): Likewise.
7324
7325 * w32.h (emacs_gnutls_pull): Add prototype.
7326 (emacs_gnutls_push): Likewise.
7327
7328 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7329 (emacs_gnutls_push): Likewise.
7330
73312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7332
7333 * process.c (wait_reading_process_output): Check if GnuTLS
7334 buffered some data internally if no FDs are set for TLS
7335 connections.
7336
7337 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7338 (LIBS): Link to USER_LIBS.
7339 ($(BLD)/gnutls.$(0)): New target.
7340
fa6996bc
EZ
73412011-04-24 Eli Zaretskii <eliz@gnu.org>
7342
eb35682e
EZ
7343 * xdisp.c (handle_single_display_spec): Rename the
7344 display_replaced_before_p argument into display_replaced_p, to
7345 make it consistent with the commentary. Fix typos in the
7346 commentary.
7347
e2ad650c
EZ
7348 * textprop.c (syms_of_textprop): Remove dead code.
7349 (copy_text_properties): Delete obsolete commentary about an
7350 interface that was deleted long ago. Fix typos in the description
7351 of arguments.
7352
1b2de274
EZ
7353 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7354 to changes in oldXMenu/XMenu.h from 2011-04-16.
7355 <menu_help_message, prev_menu_help_message>: Constify.
7356 (IT_menu_make_room): menu->help_text is now `const char **';
7357 adjust.
7358
7359 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7360 to changes in oldXMenu/XMenu.h from 2011-04-16.
7361 (struct XMenu): Declare `help_text' `const char **'.
7362
7363 * xfaces.c <Qunspecified>: Make extern again.
7364
7365 * syntax.c: Include sys/types.h before including regex.h, as
7366 required by Posix.
7367
762b15be
EZ
7368 * doc.c (get_doc_string): Improve the format passed to `error'.
7369
7370 * doprnt.c (doprnt): Improve commentary.
7371
7372 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7373
7374 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7375 them with etags.
7376
f1052e5d
EZ
7377 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7378 changes in globals.h immediately force recompilation.
762b15be
EZ
7379 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7380 $(CURDIR)/s/ms-w32.h.
7381 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7382
fa6996bc
EZ
7383 * character.c (Fchar_direction): Function deleted.
7384 (syms_of_character): Don't defsubr it.
7385 <char-direction-table>: Deleted.
7386
e6c3da20
EZ
73872011-04-23 Eli Zaretskii <eliz@gnu.org>
7388
7389 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7390 * doprnt.c: Include limits.h.
7391 (SIZE_MAX): New macro.
04f2d78b
CB
7392 (doprnt): Return a size_t value. 2nd arg is now size_t.
7393 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7394 Improve overflow protection. Support `l' modifier for integer
7395 conversions. Support %l conversion. Don't assume an EMACS_INT
7396 argument for integer conversions and for %c.
7397
7398 * lisp.h (doprnt): Restore prototype.
7399
7400 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7401 $(SRC)/character.h.
7402
7403 * Makefile.in (base_obj): Add back doprnt.o.
7404
7405 * deps.mk (doprnt.o): Add back prerequisites.
7406 (callint.o): Depend on character.h.
7407
7408 * eval.c (internal_lisp_condition_case): Include the handler
7409 representation in the error message.
7410 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7411 when breaking from the loop.
7412
7413 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7414
7415 * callint.c (Fcall_interactively): When displaying error message
7416 about invalid control letter, pass the character's codepoint, not
7417 a pointer to its multibyte form. Improve display of the character
7418 in octal and display also its hex code.
7419
7420 * character.c (char_string): Use %x to display the (unsigned)
7421 codepoint of an invalid character, to avoid displaying a bogus
7422 negative value.
7423
7424 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7425 `error', not SYMBOL_NAME itself.
7426
7427 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7428 character arguments to `error'.
7429
7430 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7431 to `error' in error message about FINAL_CHAR argument. Make sure
7432 FINAL_CHAR is a character, and use %c when it is passed as
7433 argument to `error'.
7434
4ffd0d6b 74352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7436
7437 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7438
7439 * w32.c: Include <time.h>.
7440 (sys_localtime): New function.
7441
4ffd0d6b 74422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7443
7444 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7445
4ffd0d6b 7446 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7447
4ffd0d6b 74482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7449
4ffd0d6b
GM
7450 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7451 zombies (Bug#8467).
aac0c6e3 7452
04c56954
EZ
74532011-04-19 Eli Zaretskii <eliz@gnu.org>
7454
7455 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7456 gl_state.e_property when gl_state.object is Qt.
7457
7458 * insdel.c (make_gap_larger): Remove limitation of buffer size
7459 to <= INT_MAX.
7460
16a43933
CY
74612011-04-18 Chong Yidong <cyd@stupidchicken.com>
7462
7463 * xdisp.c (lookup_glyphless_char_display)
7464 (produce_glyphless_glyph): Handle cons cell entry in
7465 glyphless-char-display.
7466 (Vglyphless_char_display): Document it.
7467
7468 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7469 glyphless-char-display.
7470
4581706e
CY
74712011-04-17 Chong Yidong <cyd@stupidchicken.com>
7472
7473 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7474
7475 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7476
7477 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7478 definition for no-X builds.
7479
4887c6e2 74802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7481
fd35b6f9
PE
7482 Static checks with GCC 4.6.0 and non-default toolkits.
7483
5c1ccb01
PE
7484 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7485
006c5daa
PE
7486 * process.c (keyboard_bit_set): Define only if SIGIO.
7487 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7488 (send_process): Repair possible setjmp clobbering.
7489
efc736d3
PE
7490 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7491
4e2fe2e6
PE
7492 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7493
f97334a2
PE
7494 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7495
4e75f29d
PE
7496 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7497 Define only if needed.
7498
90efadd1
PE
7499 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7500 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7501 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7502
3c647824
PE
7503 * dispextern.h (struct redisplay_interface): Rename param
7504 to avoid shadowing.
e264f262 7505 * termhooks.h (struct terminal): Likewise.
761383f4 7506 * xterm.c (xembed_send_message): Likewise.
3c647824 7507
b58c5c4a
PE
7508 * insdel.c (make_gap_smaller): Define only if
7509 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7510
cad59032
PE
7511 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7512 it.
7513
c339dc2e
PE
7514 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7515 so that we aren't warned about unused symbols.
7516
91a3e27b
PE
7517 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7518
399c71d3 7519 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7520
8ffc96f5
PE
7521 * xfns.c (x_real_positions): Mark locals as initialized.
7522
eef9bc79
PE
7523 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7524
098db9dd
PE
7525 * xterm.c: Fix problems found by static analysis with other toolkits.
7526 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7527 (x_dispatch_event): Declare static if USE_GTK, and
7528 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7529 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7530 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7531 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7532 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7533
eb18f6cc
PE
7534 * xmenu.c (menu_help_callback): Pointer type fixes.
7535 Use const pointers when pointing at readonly data. Avoid pointer
7536 signedness clashes.
7537 (FALSE): Remove unused macro.
7538 (update_frame_menubar): Remove unused decl.
7539
1fe72bf8
PE
7540 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7541
60d9e1db
PE
7542 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7543 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7544 (single_menu_item): Rename local to avoid shadowing.
7545
39261c26
PE
7546 * keyboard.c (make_lispy_event): Remove unused local var.
7547
018c5e19
PE
7548 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7549 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7550
63d2b86e
PE
7551 * bitmaps: Change bitmaps from unsigned char back to the X11
7552 compatible char. Avoid the old compiler warnings about
7553 out-of-range initializers by using, for example, '\xab' rather
7554 than 0xab.
7555
aefd87e1
PE
7556 * xgselect.c (xgselect_initialize): Check vs interface
7557 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7558
bf501fb9
PE
7559 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7560
e9829fdf
PE
7561 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7562 to read-only memory.
7563
1086c095
PE
7564 * fns.c (vector): Remove; this old hack is no longer needed.
7565
2baccd04 7566 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7567 Remove unused var.
dde42981 7568 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7569
72391843 7570 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7571
436c16df 7572 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7573 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7574 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7575
92bb796d 7576 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7577 (x_term_init): Remove local to avoid shadowing.
92bb796d 7578
764430a3 7579 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7580
7581 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7582 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7583
d1dfb56c
EZ
75842011-04-16 Eli Zaretskii <eliz@gnu.org>
7585
c4354cb4
EZ
7586 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7587
d1dfb56c
EZ
7588 Fix regex.c, syntax.c and friends for buffers > 2GB.
7589 * syntax.h (struct gl_state_s): Declare character position members
7590 EMACS_INT.
7591
7592 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7593
04f2d78b
CB
7594 * textprop.c (verify_interval_modification, interval_of):
7595 Declare arguments EMACS_INT.
d1dfb56c
EZ
7596
7597 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7598 EMACS_INT.
7599
7600 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7601
7602 * indent.c (Fvertical_motion): Local variable it_start is now
7603 EMACS_INT.
7604
7605 * regex.c (re_match, re_match_2, re_match_2_internal)
7606 (bcmp_translate, regcomp, regexec, print_double_string)
7607 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7608 (re_compile_pattern, re_exec): Declare arguments and local
7609 variables `size_t' and `ssize_t' and return values `regoff_t', as
7610 appropriate.
7611 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7612 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7613 <compile_stack_type>: `size' and `avail' are now `size_t'.
7614
7615 * regex.h <regoff_t>: Use ssize_t, not int.
7616 (re_search, re_search_2, re_match, re_match_2): Arguments that
7617 specify buffer/string position and length are now ssize_t and
7618 size_t. Return type is regoff_t.
7619
613052cd
BK
76202011-04-16 Ben Key <bkey76@gmail.com>
7621
7622 * nsfont.m: Fixed bugs in ns_get_family and
7623 ns_descriptor_to_entity that were caused by using free to
7624 deallocate memory blocks that were allocated by xmalloc (via
7625 xstrdup). This caused Emacs to crash when compiled with
7626 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7627 --enable-checking=xmallocoverrun). xfree is now used to
7628 deallocate these memory blocks.
7629
4170f62f 76302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7631
71b41406
PE
7632 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7633
9587a89d
PE
7634 emacs_write: Accept and return EMACS_INT for sizes.
7635 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7636 et seq.
7637 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7638 Accept and return EMACS_INT.
7639 (emacs_gnutls_write): Return the number of bytes written on
7640 partial writes.
7641 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7642 (emacs_read, emacs_write): Remove check for negative size, as the
7643 Emacs source code has been audited now.
9587a89d
PE
7644 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7645 (emacs_read, emacs_write): Use it.
273a5f82
PE
7646 * process.c (send_process): Adjust to the new signatures of
7647 emacs_write and emacs_gnutls_write. Do not attempt to store
7648 a byte offset into an 'int'; it might overflow.
9587a89d 7649 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7650
3e047f51
PE
7651 * sound.c: Don't assume sizes fit in 'int'.
7652 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7653 Return EMACS_INT, not int.
3e047f51 7654 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7655 Accept EMACS_INT, not int.
7656 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7657 record read return values.
7658
cc39a9db
BK
76592011-04-15 Ben Key <bkey76@gmail.com>
7660
c9d0ec6d
JB
7661 * keyboard.c (Qundefined): Don't declare static since it is used
7662 in nsfns.m.
7663 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7664 static since they are used in nsfont.m.
cc39a9db 7665
6c60eb9f
SM
76662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7667
7668 * process.c (Qprocessp): Don't declare static.
7669 * lisp.h (Qprocessp): Declare again.
7670
7990b61a
JB
76712011-04-15 Juanma Barranquero <lekktu@gmail.com>
7672
7673 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7674
5d4cb038
PE
76752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7676
8bd7b830 7677 Improve C-level modularity by making more things 'static'.
cd64ea1d 7678
e3b27b31
PE
7679 Don't publish debugger-only interfaces to other modules.
7680 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7681 (verify_bytepos, count_markers): Move decls to the only modules
7682 that need them.
7683 * region-cache.h (pp_cache): Likewise.
7684 * window.h (check_all_windows): Likewise.
7685 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7686
5d4cb038
PE
7687 * sysdep.c (croak): Now static, if
7688 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7689 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7690
7691 * alloc.c (refill_memory_reserve): Now static if
7692 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7693 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7694
e87b6180
PE
7695 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7696 Define only if USE_LUCID.
7697
ac64929e
PE
7698 * xrdb.c (x_customization_string, x_rm_string): Now static.
7699
6f37259d
PE
7700 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7701 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7702
1683e3ab
PE
7703 * xdisp.c (draw_row_with_mouse_face): Now static.
7704 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7705
de9c2632
PE
7706 * window.h (check_all_windows): Mark externally visible.
7707
2b96acb7
PE
7708 * window.c (window_deletion_count): Now static.
7709
7710 * undo.c: Make symbols static if they're not exported.
7711 (last_undo_buffer, last_boundary_position, pending_boundary):
7712 Now static.
7713
50436f33
PE
7714 * textprop.c (interval_insert_behind_hooks): Now static.
7715 (interval_insert_in_front_hooks): Likewise.
7716
64520e5c
PE
7717 * term.c: Make symbols static if they're not exported.
7718 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7719 (max_frame_lines, tty_set_terminal_modes):
7720 (tty_reset_terminal_modes, tty_turn_off_highlight):
7721 (get_tty_terminal): Now static.
7722 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7723 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7724 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7725 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7726 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7727
1fa53021
PE
7728 * sysdep.c: Make symbols static if they're not exported.
7729 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7730 Now static.
7731 (sigprocmask_set, full_mask): Remove; unused.
7732 (wait_debugging): Mark as visible.
7733 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7734 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7735
d4b43b22
PE
7736 * syntax.c (syntax_temp): Define only if !__GNUC__.
7737
b7c513d0
PE
7738 * sound.c (current_sound_device, current_sound): Now static.
7739
989b29ad
PE
7740 * search.c (searchbufs, searchbuf_head): Now static.
7741
13a55a78
PE
7742 * scroll.c (scroll_cost): Remove; unused.
7743 * dispextern.h (scroll_cost): Remove decl.
7744
de68a1fc
PE
7745 * region-cache.h (pp_cache): Mark as externally visible.
7746
40ccffa6
PE
7747 * process.c: Make symbols static if they're not exported.
7748 (process_tick, update_tick, create_process, chan_process):
7749 (Vprocess_alist, proc_buffered_char, datagram_access):
7750 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7751 (deactivate_process): Mark defn as static, as well as decl.
7752 * lisp.h (create_process): Remove decl.
7753 * process.h (chan_process, Vprocess_alist): Remove decls.
7754
ad64fc97
PE
7755 * print.c: Make symbols static if they're not exported.
7756 (print_depth, new_backquote_output, being_printed, print_buffer):
7757 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7758 (print_interval, print_number_index, initial_stderr_stream):
7759 Now static.
7760 * lisp.h (Fprinc): Remove decl.
7761 (debug_output_compilation_hack): Mark as externally visible.
7762
adddb265
PE
7763 * sysdep.c (croak): Move decl from here to syssignal.h.
7764 * syssignal.h (croak): Put it here, so the API can be checked when
7765 'croak' is called from dissociate_if_controlling_tty.
7766
1717ede2
PE
7767 * minibuf.c: Make symbols static if they're not exported.
7768 (minibuf_save_list, choose_minibuf_frame): Now static.
7769 * lisp.h (choose_minibuf_frame): Remove decl.
7770
fa5fb2bc
PE
7771 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7772
1e3890d1
PE
7773 * lread.c: Make symbols static if they're not exported.
7774 (read_objects, initial_obarray, oblookup_last_bucket_number):
7775 Now static.
7776 (make_symbol): Remove; unused.
7777 * lisp.h (initial_obarray, make_symbol): Remove decls.
7778
8a1414fa
PE
7779 * keyboard.c: Make symbols static if they're not exported.
7780 (single_kboard, recent_keys_index, total_keys, recent_keys):
7781 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7782 (this_single_command_key_start, echoing, last_auto_save):
7783 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7784 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7785 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7786 (Vlispy_mouse_stem, double_click_count):
7787 Now static.
7788 (force_auto_save_soon): Define only if SIGDANGER.
7789 (ignore_mouse_drag_p): Now static if
7790 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7791 (print_help): Remove; unused.
7792 (stop_character, last_timer_event): Mark as externally visible.
7793 * keyboard.h (ignore_mouse_drag_p): Declare only if
7794 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7795 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7796 * lisp.h (echoing): Remove decl.
7797 (force_auto_save_soon): Declare only if SIGDANGER.
7798 * xdisp.c (redisplay_window): Simplify code, to make it more
7799 obvious that ignore_mouse_drag_p is not accessed if !defined
7800 USE_GTK && !defined HAVE_NS.
7801
93ea6e8f
PE
7802 * intervals.c: Make symbols static if they're not exported.
7803 (merge_properties_sticky, merge_interval_right, delete_interval):
7804 Now static.
7805 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7806
77382fcc
PE
7807 * insdel.c: Make symbols static if they're not exported.
7808 However, leave prepare_to_modify_buffer alone. It's never
7809 called from outside this function, but that appears to be a bug.
7810 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7811 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7812 (adjust_after_replace_noundo): Remove; unused.
7813 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7814 (signal_before_change): Remove decls.
77382fcc 7815
9306c32e
PE
7816 * indent.c (val_compute_motion, val_vmotion): Now static.
7817
cd44d2eb
PE
7818 * image.c: Make symbols static if they're not exported.
7819 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7820 if USE_GTK.
7821 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7822 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7823
ad9a7a06
PE
7824 * fringe.c (standard_bitmaps): Now static.
7825 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7826
81626931
PE
7827 * frame.c: Make symbols static if they're not exported.
7828 (x_report_frame_params, make_terminal_frame): Now static.
7829 (get_frame_param): Now static, unless HAVE_NS.
7830 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7831 (x_get_resource_string): Remove; not used.
7832 * frame.h (make_terminal_frame, x_report_frame_params):
7833 (x_get_resource_string); Remove decls.
7834 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7835 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7836
239f9db9
PE
7837 * font.c, fontset.c: Make symbols static if they're not exported.
7838 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7839 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7840 * font.c (font_close_object): Now static.
7841 * font.h (font_close_object): Remove.
7842 * fontset.c (FONTSET_OBJLIST): Remove.
7843 (free_realized_fontset) #if-0 the body, which does nothing.
7844 (face_suitable_for_char_p): #if-0, as it's never called.
7845 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7846 * xfaces.c (face_at_string_position):
7847 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7848 since 0 is always ASCII.
7849
dfcf3579
PE
7850 * fns.c (weak_hash_tables): Now static.
7851
5045092b
PE
7852 * fileio.c: Make symbols static if they're not exported.
7853 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7854 (Vwrite_region_annotation_buffers): Now static.
7855
57a96f5c
PE
7856 * eval.c: Make symbols static if they're not exported.
7857 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7858 * lisp.h (backtrace_list): Remove decl.
7859
35f08c38
PE
7860 * emacs.c: Make symbols static if they're not exported.
7861 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7862 (fatal_error_code, fatal_error_signal_hook, standard_args):
7863 Now static.
7864 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7865 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7866 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7867 * lisp.h (fatal_error_signal_hook): Remove decl.
7868 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7869
f44bd759
PE
7870 * editfns.c: Move a (normally-unused) function to its only use.
7871 * editfns.c, lisp.h (get_operating_system_release): Remove.
7872 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7873 worth the hassle of breaking this out.
7874
b532497d
PE
7875 * xterm.c: Make symbols static if they're not exported.
7876 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7877 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7878 (x_destroy_window, x_delete_display):
7879 Now static.
7880 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7881 (x_mouse_leave): Remove; unused.
7882 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7883 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7884 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7885 Remove decls.
7886 (x_mouse_leave): Declare only if WINDOWSNT.
7887 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7888 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7889 USE_X_TOOLKIT.
7890
1675728f
PE
7891 * ftxfont.c: Make symbols static if they're not exported.
7892 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7893 HAVE_FREETYPE.
7894 * font.h (ftxfont_driver): Likewise.
7895
e4cebfca
PE
7896 * xfns.c: Make symbols static if they're not exported.
7897 (x_last_font_name, x_display_info_for_name):
7898 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7899 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7900 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7901 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7902 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7903 (last_show_tip_args): Now static.
7904 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7905 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7906 (x_screen_planes): Remove; unused.
7907 * dispextern.h (x_screen_planes): Remove decl.
7908
5bf46f05
PE
7909 * dispnew.c: Make symbols static if they're not exported.
7910 * dispextern.h (redraw_garbaged_frames, scrolling):
7911 (increment_row_positions): Remove.
7912 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7913 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7914 Now static.
7915 (redraw_garbaged_frames): Remove; unused.
7916
435f4c28
PE
7917 * xfaces.c: Make symbols static if they're not exported.
7918 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7919 Remove decls.
7920 * xterm.h (defined_color): Remove decls.
7921 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7922 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7923 (menu_face_changed_default, defined_color, free_realized_face):
7924 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7925 (ascii_face_of_lisp_face): Remove; unused.
7926
8524aef3
PE
7927 * xdisp.c: Make symbols static if they're not exported.
7928 * dispextern.h (scratch_glyph_row, window_box_edges):
7929 (glyph_to_pixel_coords, set_cursor_from_row):
7930 (get_next_display_element, set_iterator_to_next):
7931 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7932 (show_mouse_face): Remove decls
7933 * frame.h (message_buf_print): Likewise.
7934 * lisp.h (pop_message, set_message, check_point_in_composition):
7935 Likewise.
7936 * xterm.h (set_vertical_scroll_bar): Likewise.
7937 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7938 (message_buf_print, scratch_glyph_row, displayed_buffer):
7939 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7940 (get_next_display_element, show_mouse_face, window_box_edges):
7941 (frame_to_window_pixel_xy, check_point_in_composition):
7942 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7943 (glyph_to_pixel_coords): Remove; unused.
7944
16390cd2
PE
7945 * dired.c (file_name_completion): Now static.
7946
7947 * dbusbind.c (xd_in_read_queued_messages): Now static.
7948
a25f4dfa
PE
7949 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7950 * data.c (circular_list_error): Remove.
7951
14a9c8df
PE
7952 * commands.h (last_point_position, last_point_position_buffer):
7953 (last_point_position_window): Remove decls.
7954 * keyboard.c: Make these variables static.
7955
04f2d78b
CB
7956 * coding.h (coding, code_convert_region, encode_coding_gap):
7957 Remove decls.
74ab6df5
PE
7958 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7959 (iso_code_class, detect_coding, code_convert_region): Now static.
7960 (encode_coding_gap): Remove; unused.
7961
38dfbee1
PE
7962 * chartab.c (chartab_chars, chartab_bits): Now static.
7963
a2cb4e63
PE
7964 * charset.h (charset_iso_8859_1): Remove decl.
7965 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7966 Now static.
7967
127198fd
PE
7968 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7969 * ccl.c (Vccl_program_table): Now static.
7970 (check_ccl_update): Remove; unused.
7971
d85b608f
PE
7972 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7973 * category.h: ... from here.
7974 * category.c (check_category_table, set_category_set): Now static.
7975
31cd66f3
PE
7976 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7977 * lisp.h: Remove these decls.
7978
c358e587
PE
7979 * buffer.c (buffer_count): Remove unused var.
7980
e78aecca
PE
7981 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7982 so that it's not optimized away.
7983 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7984 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7985 exported only to the debugger.
7986
e192d7d3 7987 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7988 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7989
92470028
PE
7990 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7991 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7992 was inaccessible from Lisp.
7993 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7994 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7995
244ed907
PE
7996 alloc.c: Import and export fewer symbols, and remove unused items.
7997 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7998 is defined.
7999 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8000 it's not optimized away by whole-program optimization.
8001 (message_enable_multibyte, free_misc): Remove.
8002 (catchlist, handlerlist, mark_backtrace):
8003 Declare only if BYTE_MARK_STACK.
8004 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8005 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8006 (message_enable_multibyte): Remove decl.
8007 (free_misc, interval_free_list, float_block, float_block_index):
8008 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8009 (cons_free_list, last_marked_index):
8010 Now static.
8011 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8012 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8013 (mark_backtrace): Define only if BYTE_MARK_STACK.
8014 * xdisp.c (message_enable_multibyte): Now static.
8015
61c2b50e 8016 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8017 This makes it easier for human readers (and static analyzers)
8018 to see whether these variables are used from other modules.
8019 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8020 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8021 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8022 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8023 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8024 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8025 * xmenu.c, xselect.c:
8026 Declare Q* vars static if they are not used in other modules.
8027 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8028 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8029 Remove decls of unexported vars.
8030 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8031
95c82688
PE
8032 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8033
16a97296
PE
8034 Make Emacs functions such as Fatom 'static' by default.
8035 This makes it easier for human readers (and static analyzers)
8036 to see whether these functions can be called from other modules.
8037 DEFUN now defines a static function. To make the function external
8038 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8039 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8040 (Finit_image_library):
16a97296
PE
8041 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8042 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8043 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8044 Remove decls, since these functions are now static.
8045 (Funintern, Fget_internal_run_time): New decls, since these functions
8046 were already external.
95c82688 8047
16a97296
PE
8048 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8049 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8050 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8051 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8052 * keyboard.c, keymap.c, lread.c:
8053 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8054 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8055 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8056 Mark functions with DEFUE instead of DEFUN,
8057 if they are used in other modules.
8058 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8059 decls for now-static functions.
8060 * buffer.h (Fdelete_overlay): Remove decl.
8061 * callproc.c (Fgetenv_internal): Mark as internal.
8062 * composite.c (Fremove_list_of_text_properties): Remove decl.
8063 (Fcomposition_get_gstring): New forward static decl.
8064 * composite.h (Fcomposite_get_gstring): Remove decl.
8065 * dired.c (Ffile_attributes): New forward static decl.
8066 * doc.c (Fdocumntation_property): New forward static decl.
8067 * eval.c (Ffetch_bytecode): New forward static decl.
8068 (Funintern): Remove extern decl; now in .h file where it belongs.
8069 * fileio.c (Fmake_symbolic_link): New forward static decl.
8070 * image.c (Finit_image_library): New forward static decl.
8071 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8072 * intervals.h (Fprevious_property_change):
8073 (Fremove_list_of_text_properties): Remove decls.
8074 * keyboard.c (Fthis_command_keys): Remove decl.
8075 (Fcommand_execute): New forward static decl.
8076 * keymap.c (Flookup_key): New forward static decl.
8077 (Fcopy_keymap): Now static.
8078 * keymap.h (Flookup_key): Remove decl.
8079 * process.c (Fget_process): New forward static decl.
8080 (Fprocess_datagram_address): Mark as internal.
8081 * syntax.c (Fsyntax_table_p): New forward static decl.
8082 (skip_chars): Remove duplicate decl.
8083 * textprop.c (Fprevious_property_change): New forward static decl.
8084 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8085 Now internal.
8086 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8087 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8088
785bbd42
PE
8089 * editfns.c (Fformat): Remove unreachable code.
8090
8b913b57
AS
80912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8092
8093 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8094 change. (Bug#8496)
8095
a6744a35
EZ
80962011-04-13 Eli Zaretskii <eliz@gnu.org>
8097
8098 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8099 when at ZV. (Bug#8487)
8100
e7974947
AS
81012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8102
baad03f0
AS
8103 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8104 (Bug#8437)
8105 * keyboard.c (parse_tool_bar_item): Likewise.
8106 * sound.c (sound_cleanup, alsa_close): Likewise.
8107 * termcap.c (tgetent): Likewise.
8108 * xfns.c (x_default_font_parameter): Likewise.
8109 * xsettings.c (read_and_apply_settings): Likewise.
8110
e7974947
AS
8111 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8112 (overrun_check_free): Protoize.
8113
28272684
PE
81142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8115
8116 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8117 since callers should never pass a negative size.
8118 Change the signature to match that of plain 'read' and 'write'; see
8119 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8120 * lisp.h: Update prototypes of emacs_write and emacs_read.
8121
11997c76
EZ
81222011-04-11 Eli Zaretskii <eliz@gnu.org>
8123
8124 * xdisp.c (redisplay_window): Don't try to determine the character
8125 position of the scroll margin if the window start point w->startp
e896f03c 8126 is outside the buffer's accessible region. (Bug#8468)
11997c76 8127
8a2cbd72
EZ
81282011-04-10 Eli Zaretskii <eliz@gnu.org>
8129
8130 Fix write-region and its subroutines for buffers > 2GB.
8131 * fileio.c (a_write, e_write): Modify declaration of arguments and
8132 local variables to support buffers larger than 2GB.
8133 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8134
8135 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8136 argument, local variables, and return value.
8137
8138 * lisp.h: Update prototypes of emacs_write and emacs_read.
8139
8140 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8141
4073e537 81422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8143
1ebfdcb6
PE
8144 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8145
b2ded58d
PE
8146 Fix more problems found by GCC 4.6.0's static checks.
8147
7d66342c
PE
8148 * xdisp.c (vmessage): Use a better test for character truncation.
8149
bbf47d44
PE
8150 * charset.c (load_charset_map): <, not <=, for optimization,
8151 and to avoid potential problems with integer overflow.
9248994d 8152 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8153 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8154 * editfns.c (Fformat): Likewise.
1e69125e 8155 * syntax.c (skip_chars): Likewise.
3befa583 8156
e3019616
PE
8157 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8158 This also lets GCC 4.6.0 generate slightly better loop code.
8159
becfa255
PE
8160 * callint.c (Fcall_interactively): <, not <=, for optimization.
8161 (Fcall_interactively): Count the number of arguments produced,
8162 not the number of arguments given. This is simpler and lets GCC
8163 4.6.0 generate slightly better code.
8164
dae0cd48
PE
8165 * ftfont.c: Distingish more carefully between FcChar8 and char.
8166 The previous code passed unsigned char * to a functions like
8167 strlen and xstrcasecmp that expect char *, which does not
8168 conform to the C standard.
8169 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8170 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8171 char * when the C standard requires it.
8172
76032d70
PE
8173 * keyboard.c (read_char): Remove unused var.
8174
eb3f1cc8
PE
8175 * eval.c: Port to Windows vsnprintf (Bug#8435).
8176 Include <limits.h>.
8177 (SIZE_MAX): Define if the headers do not.
8178 (verror): Do not give up if vsnprintf returns a negative count.
8179 Instead, grow the buffer. This ports to Windows vsnprintf, which
8180 does not conform to C99. Problem reported by Eli Zaretskii.
8181 Also, simplify the allocation scheme, by avoiding the need for
8182 calling realloc, and removing the ALLOCATED variable.
8183
70476b54
PE
8184 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8185
12020a9e
PE
8186 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8187 But keep the doprint source code for now, as we might revamp it
8188 and use it again (Bug#8435).
ea6c7ae6
PE
8189 * lisp.h (doprnt): Remove.
8190 * Makefile.in (base_obj): Remove doprnt.o.
8191 * deps.mk (doprnt.o): Remove.
8192
5fdb398c
PE
8193 error: Print 32- and 64-bit integers portably (Bug#8435).
8194 Without this change, on typical 64-bit hosts error ("...%d...", N)
8195 was used to print both 32- and 64-bit integers N, which relied on
8196 undefined behavior.
61bdb816 8197 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8198 * lisp.h (error, verror): Mark as printf-like functions.
8199 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8200 Report overflow in size calculations when allocating printf buffer.
8201 Do not truncate output string at its first null byte.
8202 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8203 Truncate the output at a character boundary, since vsnprintf does not
8204 do that.
8205 * charset.c (check_iso_charset_parameter): Convert internal
8206 character to string before calling 'error', since %c now has the
8207 printf meaning.
8208 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8209 overflow when computing char to be passed to 'error'. Do not
8210 pass Lisp_Object to 'error'; pass the integer instead.
8211 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8212 formatted with plain %d.
8213
b189fa66
PE
8214 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8215
bff87ef0
PE
8216 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8217
7e2cac20
PE
8218 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8219
ce4d90b5
PE
8220 * xterm.c (x_catch_errors): Remove duplicate declaration.
8221
266c9547
PE
8222 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8223
79c49ad2
PE
8224 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8225
368f4090
JM
82262011-04-10 Jim Meyering <meyering@redhat.com>
8227
8228 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8229 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8230 return ssize_t not "int", and use size_t as the buffer length.
8231 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8232 * gnutls.h: Update declarations.
8233 * process.c (read_process_output): Use ssize_t, to match.
8234 (send_process): Likewise.
8235
a32d4040
CY
82362011-04-09 Chong Yidong <cyd@stupidchicken.com>
8237
8238 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8239
8546720e 82402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8241
04f2d78b
CB
8242 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8243 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8244
8546720e
GM
8245 * xterm.c (handle_one_xevent):
8246 * xmenu.c (create_and_show_popup_menu):
8247 * xselect.c (x_decline_selection_request)
8248 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8249
0a2f5c1a 82502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8251
8252 Fix some uses of `int' instead of EMACS_INT.
8253 * search.c (string_match_1, fast_string_match)
8254 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8255 (scan_buffer, find_next_newline_no_quit)
8256 (find_before_next_newline, search_command, Freplace_match)
8257 (Fmatch_data): Make some `int' variables be EMACS_INT.
8258
8259 * xdisp.c (display_count_lines): 3rd argument and return value now
8260 EMACS_INT. All callers changed.
8261 (pint2hrstr): Last argument is now EMACS_INT.
8262
8263 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8264 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8265 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8266 (decode_coding_utf_16, decode_coding_emacs_mule)
8267 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8268 (decode_coding_ccl, decode_coding_charset)
8269 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8270 (decode_coding_iso_2022, decode_coding_emacs_mule)
8271 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8272 <char_offset, last_offset>: Declare EMACS_INT.
8273 (encode_coding_utf_8, encode_coding_utf_16)
8274 (encode_coding_emacs_mule, encode_invocation_designation)
8275 (encode_designation_at_bol, encode_coding_iso_2022)
8276 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8277 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8278 Declare EMACS_INT.
8279 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8280 (encode_invocation_designation): Last argument P_NCHARS is now
8281 EMACS_INT.
8282 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8283 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8284
8285 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8286 All users changed.
8287
8288 * ccl.c (Fccl_execute_on_string): Declare some variables
8289 EMACS_INT.
8290
8546720e 82912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8292
8293 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8294
4e19a977
CS
82952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8296
8297 * process.c (Fformat_network_address): Doc fix.
8298
87302331
R
82992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8300
ee7683eb 8301 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8302
cbb59342
CY
83032011-04-08 Chong Yidong <cyd@stupidchicken.com>
8304
8305 * keyboard.c (read_char): Call Lisp function help-form-show,
8306 instead of using internal_with_output_to_temp_buffer.
8307 (Qhelp_form_show): New var.
e0d38eeb 8308 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8309
8310 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8311
8312 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8313
e67a13ab
CY
83142011-04-06 Chong Yidong <cyd@stupidchicken.com>
8315
04f2d78b
CB
8316 * process.c (Flist_processes): Remove to Lisp.
8317 (list_processes_1): Delete.
e67a13ab 8318
973f782d
EZ
83192011-04-06 Eli Zaretskii <eliz@gnu.org>
8320
7c106b1e
EZ
8321 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8322
973f782d
EZ
8323 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8324
41cf7d1a 83252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8326
ca23cc88
PE
8327 Fix more problems found by GCC 4.6.0's static checks.
8328
f390e2d5
PE
8329 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8330
42eea0d0
PE
8331 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8332
b69769da 8333 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8334
f9541e84
PE
8335 * xdisp.c (vmessage): Mark as a printf-like function.
8336
13841b55
PE
8337 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8338
c136c10f
PE
8339 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8340
5e2d4a30
PE
8341 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8342 printf-like functions.
8343 (tiff_load): Add casts to remove these marks before passing them
8344 to system-supplied API.
8345
583f48b9
PE
8346 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8347
b25d760e
PE
8348 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8349 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8350 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8351 directly, rather than having caller test rule sign. This avoids
8352 some unnecessary tests.
8353 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8354 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8355 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8356
bc7b6697 8357 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8358 (xfont_open): Avoid unnecessary tests.
bc7b6697 8359
27ccc379
PE
8360 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8361
dcd5c89a
PE
8362 * composite.h, composite.c (composition_gstring_put_cache):
8363 Use EMACS_INT, not int, for length.
8364
b13a45c6
PE
8365 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8366 breaking out part of COMPOSITION_DECODE_RULE.
8367 (COMPOSITION_DECODE_RULE): Use it.
8368 * composite.c (get_composition_id): Remove unused local vars,
8369 by using the new macro.
8370
1e792e4d
PE
8371 * textprop.c (set_text_properties_1): Change while to do-while,
8372 since the condition is always true at first.
8373
dc6c6455 8374 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8375 (interval_deletion_adjustment): Return unsigned value.
8376 All uses changed.
dc6c6455 8377
aba7731a
PE
8378 * process.c (list_processes_1, create_pty, read_process_output):
8379 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8380 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8381 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8382 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8383 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8384
fdfc4bf3
PE
8385 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8386
fca8fe46 8387 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8388 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8389
06a0259a 8390 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8391 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8392 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8393
e7b9e80f
PE
8394 * print.c (print_error_message): Avoid int overflow.
8395
56201685
PE
8396 * font.c (font_list_entities): Redo for clarity,
8397 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8398
78834453 8399 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8400 (font_score): Avoid potential overflow in diff calculation.
78834453 8401
0bc0b309 8402 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8403 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8404
e610eaca
PE
8405 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8406
b895abce
PE
8407 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8408 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8409 can always succeed if overflow has undefined behavior.
8410
1f1d9321 8411 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8412 (wordify): Omit three unnecessary tests.
1f1d9321 8413
c59478bc
PE
8414 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8415 All callers changed. This avoids the need for an unused var.
8416
79b73827
PE
8417 * casefiddle.c (casify_region): Remove var that is set but not used.
8418
a4db5dfe
PE
8419 * dired.c (file_name_completion): Remove var that is set but not used.
8420
43aae36e
PE
8421 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8422
2a47c44d 8423 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8424 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8425
a37c69bf
PE
8426 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8427 Check for integer overflow on size calculations.
8428
328ab8e7
PE
8429 * buffer.c (Fprevious_overlay_change): Remove var that is set
8430 but not used.
8431
e5a2a5cb
PE
8432 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8433 Remove vars that are set but not used.
8d84a6eb 8434 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8435 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8436
a60e5f68
PE
8437 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8438
f661cb61 8439 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8440 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8441
f0397f5a
PE
8442 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8443 that are set but not used.
8444
8664db06 8445 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8446 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8447
6abdaa4a
PE
8448 * xselect.c (x_get_local_selection, x_handle_property_notify):
8449 Remove vars that are set but not used.
8450
0ce7538d 8451 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8452 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8453
9ae848fc
PE
8454 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8455 Remove var that is set but not used.
0b918413
PE
8456 (scroll_bar_windows_size): Now size_t, not int.
8457 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8458 Check for overflow.
9ae848fc 8459
a5a62657
PE
8460 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8461 (map_tty_color) [!defined MSDOS]: Likewise.
8462
5c5cdd39
PE
8463 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8464
66ebf983
PE
8465 * coding.c: Remove vars that are set but not used.
8466 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8467 All callers changed.
8468 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8469 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8470 (decode_coding_charset): Remove vars that are set but not used.
8471
1be4d761
PE
8472 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8473 that is set but not used.
8474
47553fa8
PE
8475 * print.c (print_object): Remove var that is set but not used.
8476
1f7196bf 8477 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8478 The gnulib version avoids calling malloc in the usual case,
8479 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8480 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8481 * filelock.c (current_lock_owner): Likewise.
8482 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8483 * sysdep.c: Include allocator.h, careadlinkat.h.
8484 (emacs_no_realloc_allocator): New static constant.
8485 (emacs_readlink): New function.
fdb61804
PE
8486 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8487 ../lib/careadlinkat.h.
d1fdcab7 8488
f84c17c7
SM
84892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8490
8491 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8492 first non-nil return value).
8493
ef3862ad
JD
84942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8495
8496 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8497 if not defined (Bug#8403).
8498
376a7006
JB
84992011-04-02 Juanma Barranquero <lekktu@gmail.com>
8500
8501 * xdisp.c (display_count_lines): Remove parameter `start',
8502 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8503 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8504 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8505 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8506 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8507 and thereabouts. All callers changed.
8508 (get_per_char_metric): Remove parameter `f', unused since
8509 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8510
6ca3801d
JM
85112011-04-02 Jim Meyering <meyering@redhat.com>
8512
8513 do not dereference NULL upon failed strdup
8514 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8515 (ns_get_family): Likewise.
8516
d8e2b5ba
JB
85172011-04-02 Juanma Barranquero <lekktu@gmail.com>
8518
8519 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8520
8c74fcbd
JD
85212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8522
8523 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8524 later (Bug#8403).
8525
7200d79c
SM
85262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8527
03408648 8528 Add lexical binding.
7200d79c 8529
03408648
SM
8530 * window.c (Ftemp_output_buffer_show): New fun.
8531 (Fsave_window_excursion):
8532 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8533
8534 * lread.c (lisp_file_lexically_bound_p): New function.
8535 (Fload): Bind Qlexical_binding.
8536 (readevalloop): Remove `evalfun' arg.
8537 Bind Qinternal_interpreter_environment.
8538 (Feval_buffer): Bind Qlexical_binding.
8539 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8540 Mark as dynamic.
8541 (syms_of_lread): Declare `lexical-binding'.
8542
8543 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8544
8545 * keyboard.c (eval_dyn): New fun.
8546 (menu_item_eval_property): Use it.
ca105506
SM
8547
8548 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8549
03408648
SM
8550 * fns.c (concat, mapcar1): Accept byte-code-functions.
8551
8552 * eval.c (Fsetq): Handle lexical vars.
8553 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8554 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8555 (FletX, Flet): Obey lexical binding.
8556 (Fcommandp): Handle closures.
8557 (Feval): New `lexical' arg.
8558 (eval_sub): New function extracted from Feval. Use it almost
8559 everywhere where Feval was used. Look up vars in lexical env.
8560 Handle closures.
8561 (Ffunctionp): Move from subr.el.
8562 (Ffuncall): Handle closures.
8563 (apply_lambda): Remove `eval_flags'.
8564 (funcall_lambda): Handle closures and new byte-code-functions.
8565 (Fspecial_variable_p): New function.
8566 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8567 but without exporting it to Lisp.
23aba0ea 8568
23aba0ea 8569 * doc.c (Fdocumentation, store_function_docstring):
03408648 8570 * data.c (Finteractive_form): Handle closures.
23aba0ea 8571
03408648
SM
8572 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8573 interactive spec.
ba83908c 8574
04f2d78b
CB
8575 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8576 New byte-codes.
03408648
SM
8577 (exec_byte_code): New function extracted from Fbyte_code to handle new
8578 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8579
03408648 8580 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8581
03408648 8582 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8583
e2abce01
JB
85842011-03-31 Juanma Barranquero <lekktu@gmail.com>
8585
8586 * xdisp.c (redisplay_internal): Fix prototype.
8587
63696a73 85882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8589
63696a73 8590 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8591 (try_scrolling): Use it when setting scroll_limit.
8592 Limit scrolling to 100 screen lines.
63696a73
EZ
8593 (redisplay_window): Even when falling back on "recentering",
8594 position point in the window according to scroll-conservatively,
8595 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8596
8597 (try_scrolling): When point is above the window, allow searching
8598 as far as scroll_max, or one screenful, to compute vertical
8599 distance from PT to the scroll margin position. This prevents
8600 try_scrolling from unnecessarily failing when
8601 scroll-conservatively is set to a value slightly larger than the
8602 window height. Clean up the case of PT below the margin at bottom
8603 of window: scroll_max can no longer be INT_MAX. When aggressive
8604 scrolling is in use, don't let point enter the opposite scroll
8605 margin as result of the scroll.
8606 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8607 threshold of 100 lines for never-recentering scrolling.
8608
e4cc2dfc
JB
86092011-03-31 Juanma Barranquero <lekktu@gmail.com>
8610
8611 * dispextern.h (move_it_by_lines):
8612 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8613 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8614 (message_log_check_duplicate): Remove parameters `prev_bol' and
8615 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8616 (redisplay_internal): Remove parameter `preserve_echo_area',
8617 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8618
8619 * indent.c (Fvertical_motion):
8620 * window.c (window_scroll_pixel_based, Frecenter):
8621 Don't pass `need_y_p' to `move_it_by_lines'.
8622
1c470562
SM
86232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8624
44f230aa
SM
8625 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8626 steal a few bits to be more compact.
8627 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8628 Remove unneeded casts.
8629
1c470562
SM
8630 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8631
888adce9
ZK
86322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8633
8634 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8635 binding" message (bug#7967).
8636
f838ed7b
PE
86372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8638
77861b95
PE
8639 Fix more problems found by GCC 4.6.0's static checks.
8640
de6dbc14
PE
8641 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8642 Remove unused local var.
8643
f838ed7b
PE
8644 * editfns.c (Fmessage_box): Remove unused local var.
8645
792c7b2b
PE
8646 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8647 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8648 Omit unused local vars.
c499e557 8649 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8650 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8651 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8652 Omit unused local var.
8653
ba0165e1
PE
8654 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8655 Don't assume string length fits in int.
32ad8845 8656 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8657 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8658
3c59b4c9
PE
8659 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8660 instead of alloca (Bug#8344).
8661
a3eed478 8662 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8663 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8664
eb4d412d
PE
8665 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8666
1658b401
PE
8667 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8668 concerns.
8669
8670 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8671
8672 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8673
9a2c6e05
PE
8674 * keyboard.c (syms_of_keyboard): Use the same style as later
8675 in this function when indexing through an array. This also
8676 works around GCC bug 48267.
8677
03d0a109
PE
8678 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8679
44f730c8
PE
8680 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8681
fe75f926
PE
8682 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8683 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8684
ffa8c828
PE
8685 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8686 This avoids undefined behavior on integer overflow, and is a bit
8687 more convenient anyway since it is compared to a size_t variable.
8688
c5101a77
PE
8689 Variadic C functions now count arguments with size_t, not int.
8690 This avoids an unnecessary limitation on 64-bit machines, which
8691 caused (substring ...) to crash on large vectors (Bug#8344).
8692 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8693 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8694 All variadic functions and their callers changed accordingly.
c5101a77
PE
8695 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8696 * data.c (arith_driver, float_arith_driver): Likewise.
8697 * editfns.c (general_insert_function): Likewise.
8698 * eval.c (struct backtrace.nargs, interactive_p)
8699 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8700 (funcall_lambda, mark_backtrace): Likewise.
8701 * fns.c (concat): Likewise.
8702 * frame.c (x_set_frame_parameters): Likewise.
8703 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8704 0 if not found, not -1. All callers changed.
8705
dd3f25f7
PE
8706 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8707 (stack_copy_size): Now size_t, not int.
8708 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8709
461c2ab9
JB
87102011-03-28 Juanma Barranquero <lekktu@gmail.com>
8711
8712 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8713 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8714 All callers changed.
8715
8716 * lisp.h (multibyte_char_to_unibyte):
8717 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8718 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8719 * character.h (CHAR_TO_BYTE8):
8720 * cmds.c (internal_self_insert):
8721 * editfns.c (general_insert_function):
8722 * keymap.c (push_key_description):
8723 * search.c (Freplace_match):
8724 * xdisp.c (message_dolog, set_message_1): All callers changed.
8725
f6d62986
SM
87262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8727
8728 * keyboard.c (safe_run_hook_funcall): New function.
8729 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8730 don't set the hook to nil, but remove the offending function instead.
8731 (Qcommand_hook_internal): Remove, unused.
8732 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8733 Vcommand_hook_internal.
8734
8735 * eval.c (enum run_hooks_condition): Remove.
8736 (funcall_nil, funcall_not): New functions.
8737 (run_hook_with_args): Call each function through a `funcall' argument.
8738 Remove `cond' argument, now redundant.
8739 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8740 (Frun_hook_with_args_until_failure): Adjust accordingly.
8741 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8742
1db5b1ad
JB
87432011-03-28 Juanma Barranquero <lekktu@gmail.com>
8744
8745 * dispextern.h (string_buffer_position): Remove declaration.
8746
8747 * print.c (strout): Remove parameter `multibyte', unused since
8748 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8749
8750 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8751 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8752 All callers changed.
8753
8754 * w32.c (_wsa_errlist): Use braces for struct initializers.
8755
8756 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8757 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8758 All callers changed.
8759 (string_buffer_position): Likewise. Also, make static (it's never
8760 used outside xdisp.c).
8761 (cursor_row_p): Remove parameter `w', unused since
8762 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8763 (decode_mode_spec): Remove parameter `precision', introduced during
8764 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8765 All callers changed.
8766
5ffb62aa
JD
87672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8768
8769 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8770
461c2ab9 87712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8772
8773 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8774 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8775 (ns_update_auto_hide_menu_bar): New functions.
8776 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8777 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8778 ns_constrain_all_frames.
8779 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8780 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8781
5c380ffb
JD
87822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8783
8784 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8785
9af30bdf
GM
87862011-03-27 Glenn Morris <rgm@gnu.org>
8787
8788 * syssignal.h: Replace RETSIGTYPE with void.
8789 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8790 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8791 Replace SIGTYPE with void everywhere.
8792 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8793 * s/template.h (SIGTYPE): Remove commented out definition.
8794
e2abce01
JB
87952011-03-26 Eli Zaretskii <eliz@gnu.org>
8796
8797 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8798 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8799
f868cd8a
JB
88002011-03-26 Juanma Barranquero <lekktu@gmail.com>
8801
59eb0929
JB
8802 * w32.c (read_unc_volume): Use parameter `henum', instead of
8803 global variable `wget_enum_handle'.
8804
8805 * keymap.c (describe_vector): Remove parameters `indices' and
8806 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8807 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8808
f868cd8a
JB
8809 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8810
8811 * keyboard.c (timer_check): Remove parameter `do_it_now',
8812 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8813 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8814 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8815
8816 * keyboard.c (read_char):
8817 * w32menu.c (w32_menu_display_help):
8818 * xmenu.c (show_help_event, menu_help_callback):
8819 Adjust calls to `show_help_echo'.
8820
8821 * gtkutil.c (xg_maybe_add_timer):
8822 * keyboard.c (readable_events):
8823 * process.c (wait_reading_process_output):
8824 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8825
8826 * insdel.c (adjust_markers_gap_motion):
8827 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8828 (gap_left, gap_right): Don't call it.
8829
2ecf6fdb
CY
88302011-03-25 Chong Yidong <cyd@stupidchicken.com>
8831
8832 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8833 incurred during fontification.
8834
6b1f9ba4
JB
88352011-03-25 Juanma Barranquero <lekktu@gmail.com>
8836
8837 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8838 (DEFVAR_PER_BUFFER): Don't pass it.
8839
8840 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8841 (scrolling_window): Don't pass it.
8842
0f4a96b5
JB
88432011-03-25 Juanma Barranquero <lekktu@gmail.com>
8844
8845 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8846
8847 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8848 and `suffix'.
8849 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8850 of variables specific to SELinux and computation of `encoded_absname'.
8851
8852 * image.c (XPutPixel): Remove unused variable `height'.
8853
8854 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8855
8856 * unexw32.c (get_section_info): Remove unused variable `section'.
8857
8858 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8859 (system_process_attributes): Remove unused variable `sess'.
8860 (sys_read): Remove unused variable `err'.
8861
8862 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8863 (w32_wnd_proc): Remove unused variable `isdead'.
8864 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8865 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8866 (x_create_tip_frame): Remove unused variable `tem'.
8867
8868 * w32inevt.c (w32_console_read_socket):
8869 Remove unused variable `no_events'.
8870
8871 * w32term.c (x_draw_composite_glyph_string_foreground):
8872 Remove unused variable `width'.
8873
1149507c
JB
88742011-03-24 Juanma Barranquero <lekktu@gmail.com>
8875
8876 * w32term.c (x_set_glyph_string_clipping):
8877 Don't pass uninitialized region to CombineRgn.
8878
9c88f339
JB
88792011-03-23 Juanma Barranquero <lekktu@gmail.com>
8880
8881 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8882 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8883 (Fx_close_connection): Remove unused variable `i'.
8884
8885 * w32font.c (w32font_draw): Return number of glyphs.
8886 (w32font_open_internal): Remove unused variable `i'.
8887 (w32font_driver): Add missing initializer.
8888
8889 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8890 (fill_in_menu): Remove unused variable `items_added'.
8891
8892 * w32term.c (last_mouse_press_frame): Remove static global variable.
8893 (w32_clip_to_row): Remove unused variable `f'.
8894 (x_delete_terminal): Remove unused variable `i'.
8895
8896 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8897 (NOTHING): Remove unused static global variable.
8898 (uniscribe_check_otf): Remove unused variable `table'.
8899 (uniscribe_font_driver): Add missing initializers.
8900
dee091a3
JD
89012011-03-23 Julien Danjou <julien@danjou.info>
8902
8903 * term.c (Fsuspend_tty, Fresume_tty):
8904 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8905 * window.c (temp_output_buffer_show):
8906 * insdel.c (signal_before_change):
8907 * frame.c (Fhandle_switch_frame):
8908 * fileio.c (Fdo_auto_save):
8909 * emacs.c (Fkill_emacs):
8910 * editfns.c (save_excursion_restore):
8911 * cmds.c (internal_self_insert):
8912 * callint.c (Fcall_interactively):
8913 * buffer.c (Fkill_all_local_variables):
8914 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8915 Use Frun_hooks.
0f4a96b5 8916 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8917 unconditionally since it does the check itself.
dee091a3 8918
2c520ab5 89192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8920
c9c49752
PE
8921 Fix more problems found by GCC 4.5.2's static checks.
8922
8abc3f12
PE
8923 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8924 the first time through the loop, since we know p0 < p1 then.
8925 This also avoids a gcc -Wstrict-overflow warning.
8926
a2d26660
PE
8927 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8928 leading to a memory leak, possible in functions like
8929 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8930 of objects (Bug#8318).
a2d26660 8931
916c72e9
PE
8932 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8933 that could (at least in theory) be that large.
8934
19ab8a18
PE
8935 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8936 This is less likely to overflow, and avoids undefined behavior if
8937 overflow does occur. All callers changed. Use strtoul to scan
8938 for the unsigned long integer.
b7cbbd6f
PE
8939 (pint2hrstr): Simplify and tune code slightly.
8940 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8941
f0641eff
PE
8942 * scroll.c (do_scrolling): Work around GCC bug 48228.
8943 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8944
7f650bb9
PE
8945 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8946 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8947 (validate_x_resource_name): Simplify count usage.
8948 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8949
37dd57d1
PE
8950 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8951 fail (Bug#8306).
81e56e61 8952
699979fc 8953 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8954
401bf9b4
PE
8955 * process.c (Fmake_network_process): Use socklen_t, not int,
8956 where POSIX says socklen_t is required in portable programs.
8957 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8958 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8959 (Fmake_network_process, server_accept_connection):
8960 (wait_reading_process_output, read_process_output):
8961 Likewise.
8962
b93aacde
PE
8963 * process.c: Rename or move locals to avoid shadowing.
8964 (list_processes_1, Fmake_network_process):
8965 (read_process_output_error_handler, exec_sentinel_error_handler):
8966 Rename or move locals.
4dc343ee 8967 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8968 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8969 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8970 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8971 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8972
af8a867c 8973 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8974 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8975 Include tparam.h instead, since it declares them.
af8a867c
PE
8976 * cm.h (PC): Remove extern decl; tparam.h now does this.
8977 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8978 * terminfo.c: Include tparam.h, to check interfaces.
8979 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8980 (tparam): Adjust signature to match interface in tparam.h;
8981 this removes some undefined behavior. Check that outstring and len
8982 are zero, which they always are with Emacs.
8983 * tparam.h (PC, BC, UP): New extern decls.
8984
0248044d 8985 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8986 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8987
8ff096c1 8988 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8989 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8990 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8991 (ftfont_list): Remove unused local.
49eaafba
PE
8992 (get_adstyle_property, ftfont_pattern_entity):
8993 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8994 Rename locals to avoid shadowing.
8ff096c1 8995
e2be39f6
PE
8996 * xfont.c (xfont_list_family): Mark var as initialized.
8997
c9735e30
PE
8998 * xml.c (make_dom): Now static.
8999
8f5201ae
PE
9000 * composite.c (composition_compute_stop_pos): Rename local to
9001 avoid shadowing.
b246f932
PE
9002 (composition_reseat_it): Remove unused locals.
9003 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9004 (composition_update_it): Mark var as initialized.
11b61122
PE
9005 (find_automatic_composition): Mark vars as initialized,
9006 with a FIXME (Bug#8290).
8f5201ae 9007
760fbc2c
PE
9008 character.h: Rename locals to avoid shadowing.
9009 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9010 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9011 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9012 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9013 to avoid shadowing.
9014
ff08eb85
PE
9015 * textprop.c (property_change_between_p): Remove; unused.
9016
fc7bf025
PE
9017 * intervals.c (interval_start_pos): Now static.
9018
235d7abc
PE
9019 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9020
44f230aa
SM
9021 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9022 Rename locals to avoid shadowing.
3e7d6594 9023
50060332
PE
9024 * sound.c (wav_play, au_play, Fplay_sound_internal):
9025 Fix pointer signedness.
d01f234b 9026 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9027 (wav_play): Initialize a variable to 0, to prevent undefined
9028 behavior (Bug#8278).
50060332 9029
c4fc4e30
PE
9030 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9031
918436ed
PE
9032 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9033
c939f91b
PE
9034 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9035 clobbering (Bug#8298).
b9c7f648
PE
9036 * sysdep.c (sys_subshell): Likewise.
9037 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9038
6bd8c144
PE
9039 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9040 This should get cleaned up, so that child_setup has the
9041 same signature on all platforms.
9042
7710357c 9043 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9044 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9045
c59da222
CY
90462011-03-22 Chong Yidong <cyd@stupidchicken.com>
9047
9048 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9049 not to be necessary, and produces flickering.
9050
66b87493
GM
90512011-03-20 Glenn Morris <rgm@gnu.org>
9052
9053 * config.in: Remove file.
9054
45b6f6d5
JB
90552011-03-20 Juanma Barranquero <lekktu@gmail.com>
9056
9057 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9058 are now in src/globals.h.
9059 (syms_of_minibuf): Remove spurious & from previous change.
9060
cd394be1 90612011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9062
9063 * minibuf.c (completing-read-function): New variable.
9064 (completing-read-default): Rename from completing-read.
9065 (completing-read): Call completing-read-function.
9066
b14e3e21
CY
90672011-03-19 Juanma Barranquero <lekktu@gmail.com>
9068
9069 * xfaces.c (Fx_load_color_file):
9070 Read color file from absolute filename (bug#8250).
9071
f2b726e6
JB
90722011-03-19 Juanma Barranquero <lekktu@gmail.com>
9073
9074 * makefile.w32-in: Update dependencies.
9075
09f6ff02
EZ
90762011-03-17 Eli Zaretskii <eliz@gnu.org>
9077
9078 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9079
29a6015a
PE
90802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9081
a3a6c54e
PE
9082 Fix more problems found by GCC 4.5.2's static checks.
9083
b766f867
PE
9084 * process.c (make_serial_process_unwind, send_process_trap):
9085 (sigchld_handler): Now static.
9086
be02381c
PE
9087 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9088 That way, the code declares only the vars that it needs.
9089 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9090 * s/cygwin.h (PTY_ITERATION): Likewise.
9091 * s/darwin.h (PTY_ITERATION): Likewise.
9092 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9093
57048744
PE
9094 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9095 * process.c (allocate_pty): Don't declare stb unless it's needed.
9096
7914961c 9097 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9098 (CONSTANTLIM): Remove; unused.
9099 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9100 Define only if needed.
7914961c 9101
b3967b18
PE
9102 * unexelf.c (unexec): Name an expression,
9103 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9104 Use a different way to cause a compilation error if anyone uses
9105 n rather than nn, a way that does not involve shadowing.
73366a00 9106 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9107
29a6015a
PE
9108 * deps.mk (unexalpha.o): Remove; unused.
9109
43cfc33e 9110 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9111 * unexec.h: New file.
ce701a33
PE
9112 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9113 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9114 Depend on unexec.h.
9115 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9116 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9117 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9118 Change as necessary to match prototype in unexec.h.
ce701a33 9119
01f44d5a
PE
9120 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9121 shadowing.
4f63c6bb 9122 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9123
a6670b0b
PE
9124 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9125 Rename locals to avoid shadowing.
9126
cef2010d 9127 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9128 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9129
d4d7173a
PE
9130 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9131
f08b802a
PE
9132 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9133 warning when compiling print.c.
9134
3ddb0639
PE
9135 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9136 instead of using an uninitialized var.
5ad03b97 9137 (font_sort_entities): Mark var as initialized.
3ddb0639 9138
170a2692
PE
9139 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9140
e663c700
PE
9141 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9142 pointers to constants.
89bc529a 9143 (font_parse_fcname): Remove unused vars.
7b81e2d0 9144 (font_delete_unmatched): Now static.
ea838e10 9145 (font_get_spec): Remove; unused.
13a547c6
PE
9146 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9147 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9148 Rename or move locals to avoid shadowing.
e663c700 9149
2a80c887 9150 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9151 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9152
1384fa33 9153 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9154 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9155
8b2c52e9
PE
9156 * alloc.c (mark_backtrace): Move decl from here ...
9157 * lisp.h: ... to here, so that it can be checked.
9158
475545b5 9159 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9160 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9161 (lisp_indirect_variable): Name an expression,
9162 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9163 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9164
b1349114 9165 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9166 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9167 Use const pointer when appropriate.
b1349114 9168
a2928364
PE
9169 * lisp.h (get_system_name, get_operating_system_release):
9170 Move decls here, to check interfaces.
9171 * process.c (get_operating_system_release): Move decl to lisp.h.
9172 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9173 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9174 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9175 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9176 (Fformat_time_string, Fencode_time, Finsert_char):
9177 (Ftranslate_region_internal, Fformat):
9178 Rename or remove local vars to avoid shadowing.
9710023e 9179 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9180
a415e694
PE
9181 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9182 avoid shadowing.
9183
8ef4622d
PE
9184 * lisp.h (eassert): Check that the argument compiles, even if
9185 ENABLE_CHECKING is not defined.
9186
946f9a5b
PE
9187 * data.c (Findirect_variable): Name an expression, to avoid
9188 gcc -Wbad-function-cast warning.
112396d6 9189 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9190 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9191 (Fmake_variable_buffer_local, Fmake_local_variable):
9192 Mark variables as initialized.
52746918 9193 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9194
e5aab7e7 9195 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9196 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9197 Rename locals to avoid shadowing.
dff45157
PE
9198 (mark_stack): Move local variables into the #ifdef region where
9199 they're used.
7bc26fdb
PE
9200 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9201 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9202 needed otherwise.
9203 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9204 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9205 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9206
e5aab7e7
PE
9207 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9208 avoids undefined behavior in theory.
9209
4da60324
PE
9210 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9211
88043301
PE
9212 Use functions, not macros, for up- and down-casing (Bug#8254).
9213 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9214 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9215 to use the following functions instead of these macros.
9216 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9217 EMACS_INT, since callers assume the returned value fits in int.
9218 (upcase1): Likewise, for UPCASE_TABLE.
9219 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9220 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9221 the race-condition problem in the old DOWNCASE.
88043301 9222
19ed5445
PE
9223 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9224 Rename locals to avoid shadowing.
9225 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9226 (regex_compile, re_search_2, re_match_2_internal):
9227 Remove unused local vars.
952db0d7
PE
9228 (FREE_VAR): Rewrite so as not to use empty "else",
9229 which gcc can warn about.
da053e48 9230 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9231 (RETALLOC_IF): Define only if needed.
9232 (WORDCHAR_P): Likewise. This one is never needed, but is used
9233 only in a comment talking about a compiler bug, so put inside
9234 the #if 0 of that comment.
9235 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9236 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9237 Remove; unused.
19ed5445 9238
1f3561e4 9239 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9240 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9241 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9242
ded6f8f7
PE
9243 * search.c (simple_search): Remove unused var.
9244
dbd37a95
PE
9245 * dired.c (compile_pattern): Move decl from here ...
9246 * lisp.h: ... to here, so that it can be checked.
9247 (struct re_registers): New forward decl.
9248
7e47afad
PE
9249 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9250
85f24f61
PE
9251 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9252 All uses changed.
9253 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9254 Rename locals to avoid shadowing.
5671df8f 9255 (Fvertical_motion): Mark locals as initialized.
85f24f61 9256
181aa2be 9257 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9258 (casify_region): Mark local as initialized.
181aa2be 9259
930d429c
PE
9260 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9261
7082eac6
PE
9262 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9263 New macros, so that the caller can use some names other than
9264 gcpro1, gcpro2, etc.
9265 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9266 of the new macros.
9267 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9268 argument, for consistency with GCPRO2_VAR, etc: it is now the
9269 prefix of the variable, not the variable itself. All uses
9270 changed.
38b2c076
PE
9271 * dired.c (directory_files_internal, file_name_completion):
9272 Rename locals to avoid shadowing.
9273
15206ed9
PE
9274 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9275 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9276 dired.c's scmp function, had undefined behavior.
9277 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9278 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9279 * buffer.h: ... to here, because these macros use current_buffer,
9280 and the new implementation with inline functions needs to have
9281 current_buffer in scope now, rather than later when the macros
9282 are used.
9283 (downcase, upcase1): New static inline functions.
9284 (DOWNCASE, UPCASE1): Reimplement using these functions.
9285 This avoids undefined behavior in expressions like
9286 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9287 from race conditions in accessing the global variables
9288 case_temp1 and case_temp2.
9289 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9290 * lisp.h (case_temp1, case_temp2): Remove their decls.
9291 * character.h (ASCII_CHAR_P): Move from here ...
9292 * lisp.h: ... to here, so that the inline functions mentioned
9293 above can use them.
9294
4a6bea26
PE
9295 * dired.c (directory_files_internal_unwind): Now static.
9296
f14b7e14
PE
9297 * fileio.c (file_name_as_directory, directory_file_name):
9298 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9299 Now static.
2893f146
PE
9300 (file_name_as_directory): Use const pointers when appropriate.
9301 (Fexpand_file_name): Likewise. In particular, newdir might
9302 point at constant storage, so make it a const pointer.
fd4ead52 9303 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9304 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9305 signedness issues.
f839df0c
PE
9306 (Fset_file_times, Finsert_file_contents, auto_save_error):
9307 Rename locals to avoid shadowing.
f14b7e14 9308
5716756e 9309 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9310 (Ftry_completion, Fall_completions): Rename or remove locals
9311 to avoid shadowing.
5716756e 9312
b4c3046a
PE
9313 * marker.c (bytepos_to_charpos): Remove; unused.
9314
b45db522
PE
9315 * lisp.h (verify_bytepos, count_markers): New decls,
9316 so that gcc does not warn that these functions aren't declared.
9317
85876d07
PE
9318 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9319 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9320 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9321 (copy_text): Remove unused local var.
85876d07 9322
03d78a21 9323 * filelock.c (within_one_second): Now static.
b3dd38ab 9324 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9325
5df8f01b
PE
9326 * buffer.c (fix_overlays_before): Mark locals as initialized.
9327 (fix_start_end_in_overlays): Likewise. This function should be
9328 simplified by using pointers-to-pointers, but that's a different
9329 matter.
b1d876f1 9330 (switch_to_buffer_1): Now static.
8f54f30a
PE
9331 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9332 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9333
a70072c9 9334 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9335 Fix pointer signedness issue.
edced198
PE
9336 (sys_subshell): Mark local as volatile if checking for lint,
9337 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9338 (MAXPATHLEN): Define only if needed.
a70072c9 9339
a0977c44
PE
9340 * process.c (serial_open, serial_configure): Move decls from here ...
9341 * systty.h: ... to here, so that they can be checked.
9342
a884fdcc
PE
9343 * fns.c (get_random, seed_random): Move extern decls from here ...
9344 * lisp.h: ... to here, so that they can be checked.
9345
604efe86 9346 * sysdep.c (reset_io): Now static.
b8950c94 9347 (wait_for_termination_signal): Remove; unused.
604efe86 9348
38fc62d9
PE
9349 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9350 (copy_keymap_item, append_key, push_text_char_description):
9351 Now static.
1004a21a 9352 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9353 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9354 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9355 (describe_map_tree):
9356 Rename locals to avoid shadowing.
38fc62d9 9357
2f2650da
PE
9358 * keyboard.c: Declare functions static if they are not used elsewhere.
9359 (echo_char, echo_dash, cmd_error, top_level_2):
9360 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9361 (read_char, kbd_buffer_get_event, make_lispy_position):
9362 (make_lispy_event, make_lispy_movement, apply_modifiers):
9363 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9364 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9365 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9366 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9367 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9368
a053e86c 9369 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9370 (mark_kboards): Move decl here ...
9371 * alloc.c (mark_kboards): ... from here.
a053e86c 9372
4752793e
PE
9373 * lisp.h (force_auto_save_soon): New decl.
9374
74f10ca7 9375 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9376 (DEFINE_DUMMY_FUNCTION): New macro.
9377 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9378 Use it.
c03cd23f
PE
9379 (main): Add casts to avoid warnings
9380 if GCC considers string literals to be constants.
74f10ca7 9381
022e70d4
PE
9382 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9383
59d6fe83
PE
9384 * dbusbind.c: Pointer signedness fixes.
9385 (xd_signature, xd_append_arg, xd_initialize):
9386 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9387 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9388 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9389 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9390
78320123
PE
9391 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9392 if GCC considers string literals to be constants.
49cebcca 9393 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9394
35ac2a97
SM
93952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9396
fb103ca9
SM
9397 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9398 (print_preprocess, print_object): New macro to fix last change.
9399
35ac2a97
SM
9400 * print.c (print_preprocess): Don't forget font objects.
9401
62973b41
JB
94022011-03-16 Juanma Barranquero <lekktu@gmail.com>
9403
9404 * emacs.c (USAGE3): Doc fixes.
9405
0e48bb22
AS
94062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9407
9408 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9409 structure.
9410
7684e57b
JB
94112011-03-14 Juanma Barranquero <lekktu@gmail.com>
9412
9413 * lisp.h (VWindow_system, Qfile_name_history):
9414 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9415 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9416 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9417
9418 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9419 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9420
9421 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9422 * w32console.c (detect_input_pending, read_input_pending)
9423 (encode_terminal_code):
9424 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9425 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9426 (w32_system_caret_y, Qfile_name_history):
9427 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9428 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9429 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9430 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9431 * w32proc.c (Qlocal, report_file_error):
9432 * w32term.c (Vwindow_system, updating_frame):
9433 * w32uniscribe.c (initialized, uniscribe_font_driver):
9434 Remove unneeded extern declarations.
9435
2aa46d6c
CY
94362011-03-14 Chong Yidong <cyd@stupidchicken.com>
9437
c96bbc66 9438 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9439
cffc6f3b
CY
94402011-03-13 Chong Yidong <cyd@stupidchicken.com>
9441
9442 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9443 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9444 These macros can no longer be used for assignment.
9445
44f230aa
SM
9446 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9447 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9448 (record_buffer_markers, fetch_buffer_markers): New functions for
9449 recording and fetching special buffer markers.
9450 (set_buffer_internal_1, set_buffer_temp): Use them.
9451
9452 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9453
9454 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9455
9456 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9457 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9458
9459 * xdisp.c (hscroll_window_tree):
9460 (reconsider_clip_changes): Use PT instead of BUF_PT.
9461
d251f04b
EZ
94622011-03-13 Eli Zaretskii <eliz@gnu.org>
9463
9464 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9465 $(EMACS_ROOT)/lib/intprops.h.
9466
f0c77cd1
PE
94672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9468
3eca4629
PE
9469 Fix more problems found by GCC 4.5.2's static checks.
9470
7c86ee98
PE
9471 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9472 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9473 (xg_free_frame_widgets): Make it clear that a local variable is
9474 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9475 (gdk_window_get_screen): Make it clear that this macro is needed
9476 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9477 (int_gtk_range_get_value): New function, which avoids a diagnostic
9478 from gcc -Wbad-function-cast.
9479 (xg_set_toolkit_scroll_bar_thumb): Use it.
9480 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9481 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9482 (get_utf8_string, xg_get_file_with_chooser):
9483 Rename locals to avoid shadowing.
9484 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9485
41729b81
PE
9486 * xgselect.c (xg_select): Remove unused var.
9487
f0c77cd1
PE
9488 * image.c (four_corners_best): Mark locals as initialized.
9489 (gif_load): Initialize transparent_p to zero (Bug#8238).
9490 Mark another local as initialized.
ec6cf4c6 9491 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9492
ce0ad53d 9493 * image.c (clear_image_cache): Now static.
d5d5a617 9494 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9495 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9496 (x_edge_detection): Remove unnecessary cast that
9497 gcc -Wbad-function-cast diagnoses.
2037898d 9498 (gif_load): Fix pointer signedness.
6ae141d6
PE
9499 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9500 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9501
33383987 95022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9503
d32df629
PE
9504 Improve quality of tests for time stamp overflow.
9505 For example, without this patch (encode-time 0 0 0 1 1
9506 1152921504606846976) returns the obviously-bogus value (-948597
9507 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9508 reports time overflow. See
9509 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9510 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9511 * editfns.c: Include limits.h and intprops.h.
9512 (TIME_T_MIN, TIME_T_MAX): New macros.
9513 (time_overflow): Move earlier, to before first use.
9514 (hi_time, lo_time): New functions, for an accurate test for
9515 out-of-range times.
9516 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9517 (Fget_internal_run_time): Don't assume time_t fits in int.
9518 (make_time): Use list2 instead of Fcons twice.
9519 (Fdecode_time): More accurate test for out-of-range times.
9520 (check_tm_member): New function.
9521 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9522 (lisp_time_argument): Don't rely on undefined left-shift and
9523 right-shift behavior when checking for time stamp overflow.
8be6f318 9524
fe31d94c
PE
9525 * editfns.c (time_overflow): New function, refactoring common code.
9526 (Fformat_time_string, Fdecode_time, Fencode_time):
9527 (Fcurrent_time_string): Use it.
9528
8be6f318
PE
9529 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9530 * dired.c (make_time): Move to ...
9531 * editfns.c (make_time): ... here.
9532 * systime.h: Note the move.
9533
09d9db2c 95342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9535
126bc0dc
YM
9536 * fringe.c (update_window_fringes): Remove unused variables.
9537
c47cbdfd
YM
9538 * unexmacosx.c (copy_data_segment): Also copy __got section.
9539 (Bug#8223)
9540
7ac80be9
EZ
95412011-03-12 Eli Zaretskii <eliz@gnu.org>
9542
c96bbc66 9543 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9544 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9545 Constify `char *' arguments and their references according to
9546 prototypes in tparam.h.
9547
ecb0f94d 9548 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9549
7ac80be9
EZ
9550 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9551 Adapt all references accordingly.
9552
9553 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9554
ef1fd07e
TT
95552011-03-11 Tom Tromey <tromey@redhat.com>
9556
9557 * buffer.c (syms_of_buffer): Remove obsolete comment.
9558
7ef4b50c
EZ
95592011-03-11 Eli Zaretskii <eliz@gnu.org>
9560
9561 * termhooks.h (encode_terminal_code): Declare prototype.
9562
9563 * msdos.c (encode_terminal_code): Don't declare prototype.
9564
9565 * term.c (encode_terminal_code): Now external again, used by
9566 w32console.c and msdos.c.
9567
44f230aa
SM
9568 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9569 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9570
4b1ec863 95712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9572
1714f52b 9573 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9574
4b1ec863
PE
9575 * fringe.c (update_window_fringes): Mark locals as initialized
9576 (Bug#8227).
9577 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9578
524c7aa6
PE
9579 * alloc.c (mark_fringe_data): Move decl from here ...
9580 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9581 to check its interface.
9582 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9583
a5c0af81 9584 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9585 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9586 (fontset_font): Mark local as initialized.
a9a06e0b 9587 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9588
b4716021
PE
9589 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9590
811e9bac 9591 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9592 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9593 (x_own_selection, Fx_disown_selection_internal): Rename locals
9594 to avoid shadowing.
9595 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9596
7e3ab302
PE
9597 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9598 so that the caller can use some name other than gcpro1.
9599 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9600 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9601 (Fx_backspace_delete_keys_p):
9602 Use them to avoid shadowing, and rename vars to avoid shadowing.
9603 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9604 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9605 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9606 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9607 Remove unused locals.
7e3ab302
PE
9608 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9609 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9610 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9611 macros.
f78faa98 9612
e2b13473
PE
9613 * xterm.h (x_mouse_leave): New decl.
9614
77f23912
PE
9615 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9616 Remove unused functions.
cdf4ba58
PE
9617 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9618 (x_calc_absolute_position): Now static.
7411c686 9619 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9620 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9621 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9622 unless they are used.
38d0b34a
PE
9623 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9624 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9625 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9626 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9627 (x_error_catcher, x_connection_closed, x_error_handler):
9628 (x_error_quitter, xembed_send_message, x_iconify_frame):
9629 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9630 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9631 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9632
44f230aa
SM
9633 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9634 Rename or move locals to avoid shadowing.
6b463e58 9635 (tty_defined_color, merge_face_heights): Now static.
5967d051 9636 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9637 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9638 does not deduce is never used uninitialized.
73719eba
PE
9639 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9640 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9641
426994c3 9642 * terminal.c (store_terminal_param): Now static.
5489860b 9643
032f1620 9644 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9645 (set_frame_menubar): Remove unused local.
d4323972 9646 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9647 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9648 since they might point to immutable storage.
281585b0
PE
9649 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9650 since it's unused otherwise.
032f1620 9651
367c19e5 9652 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9653 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9654 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9655 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9656 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9657 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9658 does not deduce are never used uninitialized.
70739cbe 9659
07b48fa9
PE
9660 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9661
8868a238 9662 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9663 * window.c (window_loop, size_window):
9664 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9665
7e5cf297 9666 * window.c (display_buffer): Now static.
d6550a9f
PE
9667 (size_window): Mark variables that gcc -Wuninitialized
9668 does not deduce are never used uninitialized.
a586633d
PE
9669 * window.h (check_all_windows): New decl, to forestall
9670 gcc -Wmissing-prototypes diagnostic.
5b555da1 9671 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9672
f6095868
PE
9673 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9674 shadowing.
9675 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9676 Include <limits.h>.
9677 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9678 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9679 (load_charset_map): Mark variables that gcc -Wuninitialized
9680 does not deduce are never used uninitialized.
53df7c11 9681 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9682
f38b440c
PE
9683 * coding.c (coding_set_source, coding_set_destination):
9684 Use "else { /* comment */ }" rather than "else /* comment */;"
9685 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9686 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9687 a block, when the outer 'i' will do.
9688 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9689 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9690 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9691 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9692 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9693 Rename locals to avoid shadowing.
9694 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9695 * coding.c (emacs_mule_char, encode_invocation_designation):
9696 Now static, since they're not used elsewhere.
413bb2db 9697 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9698 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9699 (decode_coding_emacs_mule): Mark variables that gcc
9700 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9701 (detect_coding_iso_2022): Initialize a local variable that might
9702 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9703 this initialization is needed. (Bug#8211)
5f58e762
PE
9704 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9705 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9706 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9707 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9708 Remove unused macros.
f38b440c 9709
232b38b9 9710 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9711 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9712 * character.c (string_count_byte8): Likewise.
232b38b9 9713
fb90da1b
PE
9714 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9715 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9716
fb93dbc2
PE
9717 * chartab.c (copy_sub_char_table): Now static, since it's not used
9718 elsewhere.
5c156ace
PE
9719 (sub_char_table_ref_and_range, char_table_ref_and_range):
9720 Rename locals to avoid shadowing.
bbcd0949 9721 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9722
7d3b3862 9723 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9724 (BIDI_BOB): Remove unused macro.
7d3b3862 9725
6be7d3da
PE
9726 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9727 deduce are never used uninitialized.
c2ed9c8b 9728 * term.c (encode_terminal_code): Likewise.
6be7d3da 9729
75f8807f 9730 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9731
50938595
PE
9732 * tparam.h: New file.
9733 * term.c, tparam.h: Include it.
9734 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9735 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9736 Move these decls to tparam.h, and make them agree with what
9737 is actually in tparam.c. The previous trick of using incompatible
9738 decls in different modules does not conform to the C standard.
9739 All callers of tparam changed to use tparam's actual API.
9740 * tparam.c (tparam1, tparam, tgoto):
9741 Use const pointers where appropriate.
9742
fbceeba2
PE
9743 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9744 * cm.h (struct cm): Likewise.
9745 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9746 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9747 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9748 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9749 (turn_on_face, init_tty): Likewise.
9750 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9751
7f3f1250
PE
9752 * term.c (term_mouse_position): Rename local to avoid shadowing.
9753
e6ca6543
PE
9754 * alloc.c (mark_ttys): Move decl from here ...
9755 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9756
c40f8d15
AS
97572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9758
9759 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9760
cfe0661d
JB
97612011-03-09 Juanma Barranquero <lekktu@gmail.com>
9762
9763 * search.c (compile_pattern_1): Remove argument regp, unused since
9764 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9765 (compile_pattern): Don't pass it.
9766
0afb4571
J
97672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9768
9769 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9770 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9771 for ! HAVE_GTK3.
9772 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9773
9774 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9775
9776 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9777 gdk_window_get_screen, gdk_window_get_geometry,
9778 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9779 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9780 (xg_get_pixbuf_from_pixmap): New function.
9781 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9782 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9783 Call xg_get_pixbuf_from_pixmap instead of
9784 gdk_pixbuf_get_from_drawable.
9785 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9786 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9787 (xg_check_special_colors): Use GtkStyleContext and its functions
9788 for HAVE_GTK3.
9789 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9790 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9791 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9792 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9793 Call gtk_widget_get_preferred_size.
0afb4571
J
9794 (xg_frame_resized): gdk_window_get_geometry only takes 5
9795 parameters.
44f230aa
SM
9796 (xg_win_to_widget, xg_event_is_for_menubar):
9797 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9798 (xg_set_widget_bg): New function.
9799 (delete_cb): New function.
895009e1 9800 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9801 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9802 (xg_set_background_color): Call xg_set_widget_bg.
9803 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9804 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9805 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9806 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9807 if ! HAVE_GTK3.
9808 (update_frame_tool_bar): Call gtk_widget_hide.
9809 (xg_initialize): Use GDK_KEY_g.
9810
9811 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9812 if ! HAVE_GTK3
9813 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9814
9815 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9816 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9817 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9818
1c2cc4ef
JB
98192011-03-08 Juanma Barranquero <lekktu@gmail.com>
9820
9821 * w32xfns.c (select_palette): Check success of RealizePalette against
9822 GDI_ERROR, not zero.
9823
33383987 9824See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9825
9826;; Local Variables:
9827;; coding: utf-8
aac0c6e3
MR
9828;; End:
9829
acaf905b 9830 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9831
9832 This file is part of GNU Emacs.
9833
9834 GNU Emacs is free software: you can redistribute it and/or modify
9835 it under the terms of the GNU General Public License as published by
9836 the Free Software Foundation, either version 3 of the License, or
9837 (at your option) any later version.
9838
9839 GNU Emacs is distributed in the hope that it will be useful,
9840 but WITHOUT ANY WARRANTY; without even the implied warranty of
9841 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9842 GNU General Public License for more details.
9843
9844 You should have received a copy of the GNU General Public License
9845 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.