Support building on MS-Windows with libxml2.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9078ead6
EZ
12012-04-07 Eli Zaretskii <eliz@gnu.org>
2
3 Support building on MS-Windows with libxml2.
4
5 * makefile.w32-in (OBJ2): Add xml.$(O).
6 (GLOBAL_SOURCES): Add xml.c.
7 ($(BLD)/xml.$(O)): New dependency list.
8
9 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
10 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
11 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
12 [!WINDOWSNT]: New macros.
13 (init_libxml2_functions, libxml2_loaded_p): New functions.
14 (parse_region): Call fn_xmlCheckVersion instead of using the macro
15 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
16 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
17 Calls xmlCleanupParser only if libxml2 was loaded (or statically
18 linked in).
19 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
20 init_libxml2_functions before calling libxml2 functions.
21 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
22
23 * emacs.c: Don't include libxml/parser.h.
24 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
25 xmlCleanupParser directly.
26
27 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
28
3811fdf3
EZ
292012-04-07 Eli Zaretskii <eliz@gnu.org>
30
31 * indent.c (Fvertical_motion): If there is a display string at
32 point, use it.vpos to compute how many lines to backtrack after
33 move_it_to point. (Bug#11133)
34
2f8e16b2
EZ
352012-04-06 Eli Zaretskii <eliz@gnu.org>
36
37 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
38 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
39 about subtle differences between FETCH_CHAR* and STRING_CHAR*
40 macros related to unification of CJK characters. For the details,
41 see the discussion following the message here:
42 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
43
3d439cd1
CY
442012-04-04 Chong Yidong <cyd@gnu.org>
45
46 * keyboard.c (Vdelayed_warnings_list): Doc fix.
47
8bc53d00
EZ
482012-04-01 Eli Zaretskii <eliz@gnu.org>
49
50 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
51 instead of alloca. (Bug#11138)
52
3b0512a3
AS
532012-04-01 Andreas Schwab <schwab@linux-m68k.org>
54
55 * w32menu.c (is_simple_dialog): Properly check lisp types.
56 (Bug#11141)
57
8427ddd2
EZ
582012-03-31 Eli Zaretskii <eliz@gnu.org>
59
979022ef
EZ
60 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
61 position we get to after a call to move_it_to fails the
62 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
63 only if we wind up in a string from display property. (Bug#11063)
64
a6b1c7cc
EZ
65 * window.c (Fdelete_other_windows_internal): Invalidate the row
66 and column information about mouse highlight, so that redisplay
67 restores it after reallocating the glyph matrices. (Bug#7464)
68
8427ddd2
EZ
69 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
70 string comes from a `display' text property, use the buffer
71 position of that property as if we actually saw that position in
72 the row's glyphs.
697ba24b
EZ
73 (move_it_by_lines): Remove the assertion that
74 "it->current_x == 0 && it->hpos == 0" which can be legitimately
75 violated when there's a before-string at the beginning of a line.
76 (Bug#11063)
8427ddd2 77
65a0a738
EZ
782012-03-30 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (append_space_for_newline): If the default face was
81 remapped, use the remapped face for the appended newline.
82 (extend_face_to_end_of_line): Use the remapped default face for
83 extending the face to the end of the line.
84 (display_line): Call extend_face_to_end_of_line when the default
85 face was remapped. (Bug#11068)
86
581355cc
EZ
872012-03-29 Eli Zaretskii <eliz@gnu.org>
88
89 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
90
e8fc049f
SM
912012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
92
93 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
94
4fb9a543
GM
952012-03-27 Glenn Morris <rgm@gnu.org>
96
97 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
98 Doc fixes.
99
679910f1
KH
1002012-03-26 Kenichi Handa <handa@m17n.org>
101
102 * dispextern.h (struct glyph): Fix previous change. Change the
103 bit length of glyphless.ch to 25 (Bug#11082).
104
90d49b7f
CY
1052012-03-26 Chong Yidong <cyd@gnu.org>
106
107 * keyboard.c (Vselection_inhibit_update_commands): New variable.
108 (command_loop_1): Use it; inhibit selection update for
109 handle-select-window too (Bug#8996).
110
f514f6f0
FP
1112012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
112
e8fc049f 113 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 114
bf43fa51
KH
1152012-03-25 Kenichi Handa <handa@m17n.org>
116
117 * dispextern.h (struct glyph): Change the bit length of
118 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
119
8a0c01dd
EZ
1202012-03-24 Eli Zaretskii <eliz@gnu.org>
121
122 * s/ms-w32.h (tzname): Include time.h before redirecting to
123 _tzname. Fixes the MSVC build. (Bug#9960)
124
7d1c3a76
AS
1252012-03-24 Andreas Schwab <schwab@linux-m68k.org>
126
8ed79523
AS
127 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
128 characters.
129
7d1c3a76
AS
130 * xterm.c (XTread_socket): Only modify handling_signal if
131 !SYNC_INPUT. (Bug#11080)
132
e99a9b8b
EZ
1332012-03-23 Eli Zaretskii <eliz@gnu.org>
134
135 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
136 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
137 when fetching a multibyte character consumes more bytes than
138 CHAR_BYTES returns, due to unification of CJK characters in
139 string_char. (Bug#11073)
140
5063c0e1
TN
1412012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
142
143 * process.c (wait_reading_process_output): Handle pty disconnect
144 by refraining from sending oneself a SIGCHLD (bug#10933).
145
9f851fbd
CY
1462012-03-22 Chong Yidong <cyd@gnu.org>
147
148 * dispextern.h (struct it): New member string_from_prefix_prop_p.
149
5063c0e1 150 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
151 Mark string as coming from a prefix property.
152 (handle_face_prop): Use default face for prefix strings (Bug#4281).
153 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
154
fb5b8aca
CY
1552012-03-21 Chong Yidong <cyd@gnu.org>
156
157 * xfaces.c (Vface_remapping_alist): Doc fix.
158
62356a1b
EZ
1592012-03-20 Eli Zaretskii <eliz@gnu.org>
160
161 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
162 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
163 Doc fixes.
62356a1b 164
025de85b
CY
1652012-03-20 Chong Yidong <cyd@gnu.org>
166
167 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
168 to reflect default non-nil value of redisplay-dont-pause.
169
4827f94e
KH
1702012-03-19 Kenichi Handa <handa@m17n.org>
171
172 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
173 it fit in a valid range (Bug#11003).
174
e50a24a2
EZ
1752012-03-18 Eli Zaretskii <eliz@gnu.org>
176
177 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
178 that is not from display property, accept the row as a "cursor
179 row" if one of the string's character has a non-nil `cursor'
180 property. Fixes cursor positioning when there are newlines in
181 overlay strings, e.g. in icomplete.el. (Bug#11035)
182
9af5ed87
PE
1832012-03-12 Paul Eggert <eggert@cs.ucla.edu>
184
185 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
186
d1f55f16
CY
1872012-03-12 Chong Yidong <cyd@gnu.org>
188
189 * eval.c (inhibit_lisp_code): Rename from
190 inhibit_window_configuration_change_hook; move from window.c.
191
192 * xfns.c (unwind_create_frame_1, Fx_create_frame):
193 * window.c (run_window_configuration_change_hook)
194 (syms_of_window): Callers changed.
195
66c5eebd
CY
1962012-03-11 Chong Yidong <cyd@gnu.org>
197
413df973
CY
198 * keymap.c (Fkey_description): Doc fix (Bug#9700).
199
66c5eebd
CY
200 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
201
1de11f56
CY
2022012-03-10 Chong Yidong <cyd@gnu.org>
203
204 * frame.c (other_visible_frames): Don't assume the selected frame
205 is visible (Bug#10955).
206
cae07000
SM
2072012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
208
209 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
210
89c94350
JD
2112012-03-08 Jan Djärv <jan.h.d@swipnet.se>
212
213 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
214 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
215 zero (Bug#10954).
216
999dd333
GM
2172012-03-03 Glenn Morris <rgm@gnu.org>
218
01a6dcc8 219 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 220
de0100f2
EZ
2212012-03-02 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
224 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
225 (redisplay_window, next_element_from_string): Fix typos in
226 comments.
3e441275
EZ
227 (redisplay_window): Pass to move_it_vertically the margin in
228 pixels, not in screen lines.
de0100f2 229
96a72ee9
GM
2302012-03-02 Glenn Morris <rgm@gnu.org>
231
232 * buffer.c (buffer-list-update-hook): Doc fix.
233
312508d7
EZ
2342012-02-29 Eli Zaretskii <eliz@gnu.org>
235
236 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
237 push_it before setting up the iterator for the first overlay
238 string, even if we have an empty string loaded.
239 (next_overlay_string): If there's an empty string on the iterator
240 stack, pop the stack. (Bug#10903)
241
27f3c637
PE
2422012-02-25 Paul Eggert <eggert@cs.ucla.edu>
243
244 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
245 Suggested by Stefan Monnier in
246 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
247 * alloc.c (widen_to_Lisp_Object): New static function.
248 (mark_memory): Also mark Lisp_Objects by fetching pointer words
249 and widening them to Lisp_Objects. This would work even if
250 USE_LSB_TAG is defined and wide integers are used, which might
251 happen in a future version of Emacs.
252
3c9dfce6
CY
2532012-02-25 Chong Yidong <cyd@gnu.org>
254
fa74b241
CY
255 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
256 Doc fix.
257
3c9dfce6
CY
258 * xselect.c (Fx_selection_exists_p): Doc fix.
259 (x_clipboard_manager_save_all): Print an informative message
260 before saving to clipboard manager.
261
9486df08
CY
2622012-02-24 Chong Yidong <cyd@gnu.org>
263
264 * keyboard.c (process_special_events): Handle all X selection
265 requests in kbd_buffer, not just the next one (Bug#8869).
266
f01d3321
CY
2672012-02-23 Chong Yidong <cyd@gnu.org>
268
269 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
270 call when setting menu-bar-lines and tool-bar-lines parameters.
271 (unwind_create_frame_1): New helper function.
272
273 * window.c (inhibit_window_configuration_change_hook): New var.
274 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 275 (syms_of_window): Initialize it.
f01d3321 276
86b847b6
CY
2772012-02-22 Chong Yidong <cyd@gnu.org>
278
279 * xterm.c (x_draw_image_relief): Add missing type check for
280 Vtool_bar_button_margin (Bug#10743).
281
a59225b1
CY
2822012-02-21 Chong Yidong <cyd@gnu.org>
283
284 * fileio.c (Vfile_name_handler_alist): Doc fix.
285
286 * buffer.c (Fget_file_buffer): Protect against invalid file
287 handler return value.
288
310f5bd4
PE
2892012-02-20 Paul Eggert <eggert@cs.ucla.edu>
290
cb3a28cc
PE
291 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
292 when computing $valmask.
293
310f5bd4
PE
294 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
295 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
296 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
297 It's useless in that case, and it can cause problems on hosts
298 that allocate halves of EMACS_INT values separately.
299 Reported by Dan Horák. Diagnosed by Andreas Schwab in
300 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
301 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
302 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
303 it avoids undefined behavior on hosts where shifting right by more
304 than the word width has undefined behavior.
305
2375c96a
CY
3062012-02-19 Chong Yidong <cyd@gnu.org>
307
308 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
309 (Funhandled_file_name_directory, Ffile_name_as_directory)
310 (Fdirectory_file_name, Fexpand_file_name)
311 (Fsubstitute_in_file_name): Protect against invalid file handler
312 return values (Bug#10845).
313
3eb49e71
EZ
3142012-02-18 Eli Zaretskii <eliz@gnu.org>
315
316 * .gdbinit (pitx): Fix incorrect references to fields of the
317 iterator stack.
318
7b926f3f
CY
3192012-02-17 Chong Yidong <cyd@gnu.org>
320
321 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
322
11273115
PE
3232012-02-15 Paul Eggert <eggert@cs.ucla.edu>
324
325 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
326 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
327
c3a70e2b
CY
3282012-02-15 Chong Yidong <cyd@gnu.org>
329
330 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
331 marked as special. Also, starting docstrings with * is obsolete.
332
0ca43699
AS
3332012-02-13 Andreas Schwab <schwab@linux-m68k.org>
334
335 * gnutls.c (emacs_gnutls_write): Fix last change.
336
2e8f3c56
LI
3372012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
338
339 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
340 send_process.
341
af70074f
SM
3422012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
343
344 * keymap.c (Fsingle_key_description): Handle char ranges.
345
95986d52
CY
3462012-02-12 Chong Yidong <cyd@gnu.org>
347
afd83bd1
CY
348 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
349 as that creates a dangerous corner case.
350
95986d52
CY
351 * window.c (Fdelete_window_internal): Invalidate the mouse
352 highlight (Bug#9904).
353
bd7da63e
GM
3542012-02-12 Glenn Morris <rgm@gnu.org>
355
356 * xselect.c (Fx_own_selection_internal)
357 (Fx_get_selection_internal, Fx_disown_selection_internal)
358 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
359 * nsselect.m (Fx_own_selection_internal)
360 (Fx_disown_selection_internal, Fx_selection_exists_p)
361 (Fx_selection_owner_p, Fx_get_selection_internal):
362 Sync docs and argument specs with the xselect.c versions.
363
77abcbc2
LI
3642012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
365
366 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
367
90b671e2
EZ
3682012-02-11 Eli Zaretskii <eliz@gnu.org>
369
1c0ca0b7
EZ
370 * w32select.c (Fx_selection_exists_p): Sync doc string and
371 argument list with xselect.c. (Bug#10783)
372
373 * w16select.c (Fx_selection_exists_p): Sync doc string and
374 argument list with xselect.c. (Bug#10783)
90b671e2 375
49241268
GM
3762012-02-10 Glenn Morris <rgm@gnu.org>
377
378 * fns.c (Fsecure_hash): Doc fix.
379
f998bbe7 3802012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
381
382 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
383
0992bd9c
CY
3842012-02-07 Chong Yidong <cyd@gnu.org>
385
386 * buffer.c (Fbuffer_local_variables)
387 (buffer_lisp_local_variables): Handle unbound vars correctly;
388 don't let Qunbound leak into Lisp.
389
af008560
GM
3902012-02-07 Glenn Morris <rgm@gnu.org>
391
dd605cc4
GM
392 * image.c (Fimagemagick_types): Doc fix.
393
af008560
GM
394 * image.c (imagemagick-render-type): Change it from a lisp object
395 to an integer. Move the doc here from the lisp manual.
396 Treat all values not equal to 0 the same.
397
1449fa1d
CY
3982012-02-06 Chong Yidong <cyd@gnu.org>
399
400 * doc.c (store_function_docstring): Avoid applying docstring of
401 alias to base function (Bug#2603).
402
3723ec07
AS
4032012-02-04 Andreas Schwab <schwab@linux-m68k.org>
404
405 * .gdbinit (pp1, pv1): Remove redundant defines.
406 (pr): Use pp.
407
79c1cc1e
CY
4082012-02-04 Chong Yidong <cyd@gnu.org>
409
410 * nsterm.m: Declare a global (Bug#10694).
411
d7f29f8e
EZ
4122012-02-04 Eli Zaretskii <eliz@gnu.org>
413
cae07000
SM
414 * w32.c (get_emacs_configuration_options):
415 Include --enable-checking, if specified, in the return value.
d7f29f8e 416
3b95a6f9
MR
4172012-02-04 Martin Rudalics <rudalics@gmx.at>
418
419 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
420 after rounding frame sizes. (Bug#9723)
421
d6fa96a6
EZ
4222012-02-04 Eli Zaretskii <eliz@gnu.org>
423
424 * keyboard.c (adjust_point_for_property): Don't position point
425 before BEGV. (Bug#10696)
426
df0b2940
PE
4272012-02-03 Paul Eggert <eggert@cs.ucla.edu>
428
429 Handle overflow when computing char display width (Bug#9496).
430 * character.c (char_width): Return EMACS_INT, not int.
431 (char_width, c_string_width): Check for overflow when
432 computing the width; this is possible now that individual
433 characters can have unbounded width. Problem introduced
434 by merge from Emacs 23 on 2012-01-19.
435
6bee44d6
MA
4362012-02-02 Michael Albinus <michael.albinus@gmx.de>
437
438 * dbusbind.c (Fdbus_register_method): Mention the return value
439 :ignore in the docstring.
440
44f92739
GM
4412012-02-02 Glenn Morris <rgm@gnu.org>
442
1b9f60cc
GM
443 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
444
44f92739
GM
445 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
446 Unconditionally set to t. (Bug#10673)
447 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
448 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
449 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
450
c5d3843c
KH
4512012-02-02 Kenichi Handa <handa@m17n.org>
452
453 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
454 0, do not call append_composite_glyph.
455
159462d4 4562012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
457
458 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
459 NULL (Bug#6988).
460 (x_produce_glyphs): If the component of a composition is a null
461 string, set it->pixel_width to 1 to avoid zero-width glyph.
462
78cef877
EZ
4632012-02-01 Eli Zaretskii <eliz@gnu.org>
464
465 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
466 first 2 arguments are identical. This makes inserting large
467 output from a subprocess an order of magnitude faster on
468 MS-Windows, where all sbrk'ed memory is always contiguous.
469
97897668
GM
4702012-01-31 Glenn Morris <rgm@gnu.org>
471
472 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 473 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
474 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
475
31fd3586
GM
4762012-01-29 Glenn Morris <rgm@gnu.org>
477
478 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
479
0e24a8b2
CY
4802012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
481
482 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
483
cc0adcb0
CY
4842012-01-28 Chong Yidong <cyd@gnu.org>
485
486 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
487
acc28cb9
CY
4882012-01-26 Chong Yidong <cyd@gnu.org>
489
9c69cfb7
CY
490 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
491
acc28cb9
CY
492 * search.c (Fsearch_forward, Fsearch_backward): Document negative
493 repeat counts (Bug#10507).
494
48da7392
GM
4952012-01-26 Glenn Morris <rgm@gnu.org>
496
497 * lread.c (syms_of_lread): Doc fix.
498
14af5f7f
CY
4992012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
500
501 * coding.c (encode_designation_at_bol): Change return value to
502 EMACS_INT.
503
0b21c100
CY
5042012-01-25 Chong Yidong <cyd@gnu.org>
505
506 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
507
3c2907f7
CY
5082012-01-21 Chong Yidong <cyd@gnu.org>
509
510 * floatfns.c (Fcopysign): Make the second argument non-optional,
511 since nil is not allowed anyway.
512
959ad23f
AS
5132012-01-21 Andreas Schwab <schwab@linux-m68k.org>
514
515 * process.c (read_process_output): Use p instead of XPROCESS (proc).
516 (send_process): Likewise.
517
34a02f46
MR
5182012-01-19 Martin Rudalics <rudalics@gmx.at>
519
520 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
521 (Vwindow_persistent_parameters): Do not use Qstate.
522 Rewrite doc-strings.
34a02f46 523
1259009a 5242012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
525
526 * character.c (char_width): New function.
70d4fdf6
GM
527 (Fchar_width, c_string_width, lisp_string_width):
528 Use char_width (Bug#9496).
25ed9e61 529
6a6ee00d
MR
5302012-01-16 Martin Rudalics <rudalics@gmx.at>
531
532 * window.c (Vwindow_persistent_parameters): New variable.
533 (Fset_window_configuration, save_window_save): Handle persistent
534 window parameters.
535
c85efaf7
EZ
5362012-01-14 Eli Zaretskii <eliz@gnu.org>
537
538 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
539 thrashing the stack of the thread. (Bug#9087)
540
5944709e
PE
5412012-01-12 Paul Eggert <eggert@cs.ucla.edu>
542
543 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
544
e71f5d99
EZ
5452012-01-11 Eli Zaretskii <eliz@gnu.org>
546
547 * xdisp.c (rows_from_pos_range): Handle the case where the
548 highlight ends on a newline. (Bug#10464)
549 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
550 he end column for display of highlight that ends on a newline
551 before a R2L line.
552
ce316182
GM
5532012-01-11 Glenn Morris <rgm@gnu.org>
554
555 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
556 from load-path also when installation-directory is nil. (Bug#10208)
557
5b43da69
GM
5582012-01-10 Glenn Morris <rgm@gnu.org>
559
74cc8ff9
GM
560 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
561
7d8d6e4e
GM
562 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
563 Update template values to be closer to their typical values these days.
5b43da69 564
a0db8d43
EZ
5652012-01-09 Eli Zaretskii <eliz@gnu.org>
566
567 * xdisp.c (rows_from_pos_range): Accept additional argument
568 DISP_STRING, and accept any glyph in a row whose object is that
569 string as eligible for mouse highlight. Fixes mouse highlight of
570 display strings from overlays. (Bug#10464)
571
9a0115ab 5722012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 573
b9110d6a 574 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
575 * fileio.c (auto_saving_dir_umask): New static var.
576 (Fmake_directory_internal): Use it.
577 (do_auto_save_make_dir): Set it, instead of invoking chmod after
578 creating the directory. The old code temporarily assigns
579 too-generous permissions to the directory.
580 (do_auto_save_eh): Clear it.
b9110d6a 581 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
582 that the var is always cleared.
583
6c1bd3f3
EZ
5842012-01-07 Eli Zaretskii <eliz@gnu.org>
585
586 * search.c (scan_buffer): Pass character positions to
587 know_region_cache, not byte positions. (Bug#6540)
588
069d2b50
L
5892012-01-07 LynX <_LynX@bk.ru> (tiny change)
590
591 * w32.c (sys_rename): Report EXDEV when rename of a directory
592 fails because the target is on another logical disk. (Bug#10284)
593
75bf0d33
DB
5942012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
595
596 * xterm.c (x_embed_request_focus): New function.
597
598 * xterm.h: Add prototype.
599
600 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
601
1c6e5a32
GM
6022012-01-05 Glenn Morris <rgm@gnu.org>
603
604 * emacs.c (emacs_copyright): Update short copyright year to 2012.
605
651e947e
EZ
6062012-01-01 Eli Zaretskii <eliz@gnu.org>
607
608 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
609 Load gnutls_transport_set_lowat only if GnuTLS version is below
610 2.11.1.
611 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
612 GnuTLS versions below 2.11.1.
613
3778cdd8
AL
6142011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
615
616 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
617 to the doc string advising against its use for altering the way
618 windows are scrolled.
619
0e5317f7
KH
6202011-12-28 Kenichi Handa <handa@m17n.org>
621
622 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
623 coding-system ASCII compatible only when it does not produce BOM
624 on encoding (Bug#10383).
625
93d5ca1f
JD
6262011-12-26 Jan Djärv <jan.h.d@swipnet.se>
627
628 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
629 can scroll.
630 (create_and_show_popup_menu): Always use menu_position_func for
631 Gtk3 (Bug#10361).
632
ca22b785
AS
6332011-12-24 Andreas Schwab <schwab@linux-m68k.org>
634
635 * callint.c (Fcall_interactively): Don't truncate prompt string.
636
d048e1e6
EZ
6372011-12-23 Eli Zaretskii <eliz@gnu.org>
638
639 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
640 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 641 resumed from there (after widening). (Bug#10360)
d048e1e6 642
5ccaba1f
JD
6432011-12-22 Jan Djärv <jan.h.d@swipnet.se>
644
645 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
646
204ee57f
JD
6472011-12-21 Jan Djärv <jan.h.d@swipnet.se>
648
b81d40f0
JB
649 * nsterm.m (x_free_frame_resources):
650 Release f->output_data.ns->miniimage.
204ee57f
JD
651 (ns_index_color): Fix indentation. Do not retain
652 color_table->colors[i].
653
654 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
655 before returning.
656
657 * nsfns.m (x_set_background_color): Assign return value from
658 ns_index_color to face-background instead of NSColor*.
659 (ns_implicitly_set_icon_type): Fix indentation.
660 Change assignment in for loop to comparison.
661
662 * emacs.c (ns_pool): New variable.
663 (main): Assign ns_pool.
664 (Fkill_emacs): Call ns_release_autorelease_pool.
665
666 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
667 autorelease fdesc, release fdAttrs and tdict.
668 (ns_get_covering_families): Release charset.
669 (ns_findfonts): Release NSFontDescriptor created with new.
670 (ns_uni_to_glyphs): Fix indentation.
671 (setString): Release attrStr before assigning new value.
672
c803b2b7
JD
6732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
674
678f4426
JD
675 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
676 and NS_IMPL_COCOA.
677 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
678 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
679
cd394be1 6802011-12-18 David Reitter <reitter@cmu.edu>
678f4426 681
5fecd5fc
JD
682 * nsterm.m (ns_term_init): Subscribe for notifications
683 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
684 to method trackingNotification in EmacsMenu.
685
686 * nsmenu.m (trackingMenu): New variable.
3771cb17 687 (trackingNotification): New method (from Aquamacs).
5fecd5fc 688 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 689 from Aquamacs (Bug#7030).
678f4426
JD
690
6912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 692
c803b2b7
JD
693 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
694 (symbol_to_nsstring): Fix indentation.
695 (ns_symbol_to_pb): New function.
cae07000
SM
696 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
697 (Fns_rotate_cut_buffers_internal): Remove.
698 (Fns_store_selection_internal): Rename from
c803b2b7
JD
699 Fns_store_cut_buffer_internal.
700 (ns_get_foreign_selection, Fx_own_selection_internal)
701 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
702 (Fns_get_selection_internal, Fns_store_selection_internal):
703 Use ns_symbol_to_pb and check if return value is nil.
704 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
705 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
706 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
707 renamed to Sns_store_selection_internal.
708 (ns_handle_selection_request): Move code to Fx_own_selection_internal
709 and remove this function.
710 (ns_handle_selection_clear): Remove, never used.
711 (Fx_own_selection_internal): Move code from ns_handle_selection_request
712 here.
713
e1b01a3a
KB
7142011-12-17 Ken Brown <kbrown@cornell.edu>
715
716 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
717 GID is unknown (Bug#10257).
718
2adb6e85
PE
7192011-12-17 Paul Eggert <eggert@cs.ucla.edu>
720
721 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
722 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
723 which caused a build failure on GNU/Linux IA-64. This problem was
724 introduced by my 2011-10-07 patch.
725
d1d7b339
JL
7262011-12-15 Juri Linkov <juri@jurta.org>
727
728 * image.c (imagemagick_error): New function. (Bug#10112)
729 (imagemagick_load_image): Comment out `MagickSetResolution' call.
730 Use `imagemagick_error' where ImageMagick functions return
731 `MagickFalse'.
732 (Fimagemagick_types): Add `Fnreverse' to return the list in the
733 proper order.
734
100d5755
KH
7352011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
736
737 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
738 fill background (Bug#8992).
739
454592a6
MR
7402011-12-13 Martin Rudalics <rudalics@gmx.at>
741
742 * window.c (Vwindow_combination_resize)
743 (Vwindow_combination_limit): Use t instead of non-nil in
744 doc-strings.
61d4b438
MR
745 (Vrecenter_redisplay): Add first sentence of doc-string on
746 separate line.
53524d93 747 (Frecenter): Fix doc-string typo.
454592a6 748
3633e3aa
KH
7492011-12-11 Kenichi Handa <handa@m17n.org>
750
751 * coding.c (Funencodable_char_position): Pay attention to the
752 buffer text relocation (Bug#9389).
753
7b9d523a
JD
7542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
755
756 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
757 gtk_init (Bug#10100).
758
b73189c6
EZ
7592011-12-10 Eli Zaretskii <eliz@gnu.org>
760
761 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
762 IT->string is nil. (Bug#10263)
763
f7dfe5d6
JD
7642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
765
83faebb4
JD
766 * nsterm.h (x_free_frame_resources): Declare.
767
f7dfe5d6
JD
768 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
769 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
770
771 * nsterm.h (ns_get_defaults_value): Declare.
772
773 * nsterm.m (ns_default): Call ns_get_defaults_value.
774
7cd4e72c
EZ
7752011-12-09 Eli Zaretskii <eliz@gnu.org>
776
777 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
778 (Bug#10170)
779
b34d7317
YM
7802011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
781
782 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
783 that where the value of an _OBJC_* symbol points to is in the .bss
784 section (Bug#10240).
785
76470ad1
KH
7862011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
787
788 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 789 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 790
745fff94
KH
7912011-12-08 Kenichi Handa <handa@m17n.org>
792
793 * ftfont.c (get_adstyle_property): Fix previous change
794 (Bug#10233).
795
6e44397c
JB
7962011-12-07 Juanma Barranquero <lekktu@gmail.com>
797
798 * w32.c (init_environment): If no_site_lisp, remove site-lisp
799 dirs from the default value of EMACSLOADPATH (bug#10208).
800
7efa6272
GM
8012011-12-07 Glenn Morris <rgm@gnu.org>
802
803 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
804 installation and source directories as well. (Bug#10208)
805
f6fc4d87
CY
8062011-12-06 Chong Yidong <cyd@gnu.org>
807
808 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
809
2bf26180
GM
8102011-12-06 Glenn Morris <rgm@gnu.org>
811
812 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
813 as an error, not just -1. (Bug#10217)
814
3a6ad4f0
CY
8152011-12-05 Chong Yidong <cyd@gnu.org>
816
817 * keyboard.c (process_special_events): New function.
818 (swallow_events, Finput_pending_p): Use it (Bug#10195).
819
75a3b399
PE
8202011-12-05 Paul Eggert <eggert@cs.ucla.edu>
821
822 * coding.c (encode_designation_at_bol): Don't use uninitialized
823 local variable (Bug#9318).
824
c3c9e25e
KH
8252011-12-05 Kenichi Handa <handa@m17n.org>
826
827 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
828 return Qnil (Bug#8046, Bug#10193).
829
5eb05ea3
KH
8302011-12-05 Kenichi Handa <handa@m17n.org>
831
832 * coding.c (encode_designation_at_bol): New args charbuf_end and
833 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
834 (coding_set_source): Return how many bytes coding->source was
835 relocated.
836 (coding_set_destination): Return how many bytes
837 coding->destination was relocated.
838 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 839 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
840
8412011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
842
843 * coding.c (CODING_CHAR_CHARSET_P): New macro.
844 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
845 macro (Bug#9318).
846
8472011-12-05 Andreas Schwab <schwab@linux-m68k.org>
848
849 The following changes are to fix Bug#9318.
850
a79703f5 851 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
852 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
853 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 854 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 855
7dbda6df
JB
8562011-12-05 Juanma Barranquero <lekktu@gmail.com>
857
858 * lisp.h (process_quit_flag): Fix external declaration.
859
6d5eb5b0
SM
8602011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
861
862 Don't macro-inline non-performance-critical code.
863 * eval.c (process_quit_flag): New function.
864 * lisp.h (QUIT): Use it.
865
a0c3fad0
JD
8662011-12-04 Jan Djärv <jan.h.d@swipnet.se>
867
868 * nsfns.m (get_geometry_from_preferences): New function.
869 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
870
6c07aac2
AS
8712011-12-04 Andreas Schwab <schwab@linux-m68k.org>
872
873 * emacs.c (Qkill_emacs): Define.
874 (syms_of_emacs): Initialize it.
875 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
876 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
877 (quit_throw_to_read_char): Add parameter `from_signal'.
878 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
879 * lisp.h (QUIT): Call Fkill_emacs if requested.
880
c052ead4
JD
8812011-12-03 Jan Djärv <jan.h.d@swipnet.se>
882
883 * widget.c (update_wm_hints): Return if wmshell is null.
884 (widget_update_wm_size_hints): New function.
885
886 * widget.h (widget_update_wm_size_hints): Declare.
887
888 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
889 widget_update_wm_size_hints (Bug#10104).
890
9e49252b
EZ
8912011-12-03 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (handle_invisible_prop): If the invisible text ends just
894 before a newline, prepare the bidi iterator for consuming the
895 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 896 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 897
02b16839
JL
8982011-12-02 Juri Linkov <juri@jurta.org>
899
900 * search.c (Fword_search_regexp): New Lisp function created from
901 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
902 (Fword_search_backward, Fword_search_forward)
903 (Fword_search_backward_lax, Fword_search_forward_lax):
904 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
905 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
906
0068070e
SM
9072011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
908
909 * fileio.c (Finsert_file_contents): Move after-change-function call
910 to before the "handled:" label, since all "goto handled" appear in
911 cases where the *-change-functions have already been properly called
912 (bug#10117).
913
3360a3fc
AS
9142011-12-01 Andreas Schwab <schwab@linux-m68k.org>
915
916 * keyboard.c (interrupt_signal): Don't call kill-emacs when
917 waiting for input. (Bug#10169)
918
73d6c093
EZ
9192011-11-30 Eli Zaretskii <eliz@gnu.org>
920
921 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
922 verifies glyph row's hash code--we have just reallocated the
923 glyphs, so their contents can be complete garbage. (Bug#10164)
924
febe6bea
JB
9252011-11-30 Juanma Barranquero <lekktu@gmail.com>
926
927 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
928
801a4313
EZ
9292011-11-30 Eli Zaretskii <eliz@gnu.org>
930
931 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
932 attributes are tested _before_ calling verify_row_hash, to protect
933 against GCC re-ordering of the tests. (Bug#10164)
934
2b56b87e
JD
9352011-11-29 Jan Djärv <jan.h.d@swipnet.se>
936
937 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
938
939 * xterm.c (handle_one_xevent): Only set async_visible and friends
940 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 941 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
942 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
943
dbf31225
PE
9442011-11-28 Paul Eggert <eggert@cs.ucla.edu>
945
946 Remove GCPRO-related macros that exist only to avoid shadowing locals.
947 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
948 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
949 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
950 All uses changed to use GCPRO1 etc.
951 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
952 Revert to old implementation (i.e., before 2011-03-11).
953
1305621b
YM
9542011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
955
956 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
957 of scroll runs so as to avoid assigning disabled bogus rows and
958 unnecessary graphics copy operations.
959
8c9afb46
EZ
9602011-11-27 Eli Zaretskii <eliz@gnu.org>
961
962 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
963 (snprintf) [_MSC_VER]: Redirect to _snprintf.
964 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
965 (malloc, free, realloc, calloc): Redirect to e_* only when
966 compiling Emacs.
967
968 * lisp.h (GCTYPEBITS): Move before first use.
969 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
970 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
971 this macro definition.
972
973 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
974 _MSC_VER.
975
54e9e3bf
JD
9762011-11-27 Jan Djärv <jan.h.d@swipnet.se>
977
6d5eb5b0
SM
978 * gtkutil.c (xg_create_frame_widgets):
979 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
980 present with Gtk+ 2.0.
981
83aca1cb
PE
9822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
983
984 * fileio.c (Finsert_file_contents): Undo previous change; see
985 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
986
5b76caa4
PE
9872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
988
989 Rename locals to avoid shadowing.
990 * fileio.c (Finsert_file_contents):
991 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
992 * process.c (wait_reading_process_output):
993 Rename inner 'proc' to 'p' to avoid shadowing.
994 Indent for consistency with usual Emacs style.
995
8c535114
EZ
9962011-11-25 Eli Zaretskii <eliz@gnu.org>
997
998 * xdisp.c (redisplay_window): If cursor row is not fully visible
999 after recentering, and scroll-conservatively is set to a large
1000 number, scroll window by a few more lines to make the cursor fully
1001 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1002 (start_display): Don't move to the next line if the display should
1003 start at a newline that is part of a display vector or an overlay
1004 string. (Bug#10119)
8c535114 1005
fa4fdb5c
JL
10062011-11-24 Juri Linkov <juri@jurta.org>
1007
1008 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1009 after the `MagickPingImage' call. (Bug#10112)
1010
90ec88df
CY
10112011-11-23 Chong Yidong <cyd@gnu.org>
1012
1013 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1014
56e2e794
MR
10152011-11-23 Martin Rudalics <rudalics@gmx.at>
1016
1017 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1018 making another buffer current. (Bug#10114)
1019
b6e64c41
GM
10202011-11-23 Glenn Morris <rgm@gnu.org>
1021
1022 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1023
6b21de18
CY
10242011-11-23 Chong Yidong <cyd@gnu.org>
1025
1026 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1027 using it (Bug#5984).
1028
b12cd789
EZ
10292011-11-22 Eli Zaretskii <eliz@gnu.org>
1030
1031 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1032 and header-lines, as they don't have one computed for them.
1033 (Bug#10098)
1034
1035 * .gdbinit (prow): Make displayed values more self-explaining.
1036 Add row's hash code.
1037
261b6fd4
LMI
10382011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1039
1040 * process.c (wait_reading_process_output): Fix asynchrounous
1041 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1042 (wait_reading_process_output): Add comment and URL.
261b6fd4 1043
e7cfd277
JD
10442011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1047
a9b9b7f5
CY
10482011-11-21 Chong Yidong <cyd@gnu.org>
1049
1050 * window.c (Fnext_window, Fprevious_window): Doc fix.
1051
b0d15b4f
SM
10522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1053
1054 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1055
fe7a3057
JB
10562011-11-20 Juanma Barranquero <lekktu@gmail.com>
1057
1058 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1059
d2999b1a
MR
10602011-11-20 Martin Rudalics <rudalics@gmx.at>
1061
1062 * window.c (Fset_window_combination_limit): Rename argument
1063 STATUS to LIMIT.
1064 (Vwindow_combination_limit): Remove "status" from doc-string.
1065
d5ff9cd0
AS
10662011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1067
1068 * m/ibms390.h: Remove.
1069 * m/ibms390x.h: Don't include "ibms390.h".
1070
a5bb9bd3
SM
10712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1072
1073 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1074 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1075
cd1181db
JB
10762011-11-20 Juanma Barranquero <lekktu@gmail.com>
1077
1078 * casetab.c (Fset_case_table):
1079 * charset.c (Fcharset_after): Fix typos.
1080
615a3b8d 10812011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1082
17e845af
PE
1083 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1084 Otherwise, valgrind does not work on some platforms.
1085 Problem reported by Andreas Schwab in
6a0bf43d
PE
1086 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1087 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1088 is set, removing the need for VIRT_ADDRESS_VARIES.
1089 (PURE_P): Use a more-efficient implementation that needs just one
1090 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1091 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1092 to 4 (xorl, subq, cmpq, setbe).
1093 * alloc.c (pure): Always extern now, since that's the
1094 VIRT_ADDR_VARIES behavior.
1095 (PURE_POINTER_P): Use a single comparison, not two, for
1096 consistency with the new puresize.h.
1097 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1098 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1099 Remove VIRT_ADDR_VARIES no longer needed.
1100
f8fe6f96
EZ
11012011-11-19 Eli Zaretskii <eliz@gnu.org>
1102
1103 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1104 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1105 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1106 behave as if the cursor position were at the window margin.
1107
1108 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1109 and the cursor position is out of bounds, behave as if the cursor
1110 position were at the window margin. (Bug#10075)
1111
df05a53c
CY
11122011-11-18 Chong Yidong <cyd@gnu.org>
1113
1114 * window.c (Fwindow_combination_limit): Make first argument
1115 non-optional, since it is meaningless for live windows like the
1116 selected window.
1117
2071918e
DA
11182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1121
b50a28de
SM
11222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1123
1124 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1125 (graft_intervals_into_buffer): Simplify.
1126
015137db
EZ
11272011-11-18 Eli Zaretskii <eliz@gnu.org>
1128
1129 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1130 hash values of the two rows.
1131 (copy_row_except_pointers): Preserve the used[] arrays and the
1132 hash values of the two rows. (Bug#10035)
68c95424 1133 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1134
1135 * xdisp.c (row_hash): New function, body extracted from
1136 compute_line_metrics.
1137 (compute_line_metrics): Call row_hash, instead of computing the
1138 hash code inline.
1139
1140 * dispnew.c (verify_row_hash): Call row_hash for computing the
1141 hash code of a row, instead of duplicating code from xdisp.c.
1142
1143 * dispextern.h (row_hash): Add prototype.
1144
a2addb04
TH
11452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1146
1147 * frame.c (delete_frame): Don't delete the terminal when the last
1148 X frame is closed if emacs is built with GTK toolkit.
1149
df85d315
JB
11502011-11-17 Juanma Barranquero <lekktu@gmail.com>
1151
1152 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1153
a0c2d0ae
MR
11542011-11-17 Martin Rudalics <rudalics@gmx.at>
1155
1156 * window.c (Vwindow_splits): Rename to
1157 Vwindow_combination_resize. Suggested by Juri Linkov.
1158 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1159 of Vwindow_splits.
1160
58179cce
JB
11612011-11-16 Juanma Barranquero <lekktu@gmail.com>
1162
7877f373
JB
1163 * nsfns.m (Fns_font_name):
1164 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1165
b6f67890
MR
11662011-11-16 Martin Rudalics <rudalics@gmx.at>
1167
1168 * window.h (window): Rename slot "nest" to "combination_limit".
1169 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1170 (Fset_window_nest): Rename to Fset_window_combination_limit.
1171 (Vwindow_nest): Rename to Vwindow_combination_limit.
1172 (recombine_windows, make_parent_window, make_window)
1173 (Fsplit_window_internal, saved_window)
1174 (Fset_window_configuration, save_window_save): Rename all
1175 occurrences of window_nest to window_combination_limit.
1176
c7015153
JB
11772011-11-15 Juanma Barranquero <lekktu@gmail.com>
1178
1179 * image.c (imagemagick_load_image): Fix typo.
1180
322ad6ec
EZ
11812011-11-14 Eli Zaretskii <eliz@gnu.org>
1182
1183 * xdisp.c (display_line): Move the call to
1184 highlight_trailing_whitespace before the call to
1185 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1186 faces of all the glyphs to compute ROW's hash value.
1187 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1188
f067b8ec
JB
11892011-11-14 Juanma Barranquero <lekktu@gmail.com>
1190
1191 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1192 just return (bug#10044).
1193
1e5b2111
EZ
11942011-11-12 Eli Zaretskii <eliz@gnu.org>
1195
7ef3cbd5
EZ
1196 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1197 with user-defined heap size. Bump the default size of the temacs
1198 heap to 27MB, to avoid memory warning when running temacs.
1199 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1200
1e5b2111
EZ
1201 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1202 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1203 (verify_row_hash) [XASSERTS]: New function.
1204 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1205 that the hash value of glyph rows is correct.
1e5b2111 1206
89d61221
MR
12072011-11-12 Martin Rudalics <rudalics@gmx.at>
1208
1209 * window.h (window): Remove splits slot.
1210 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1211 (Fdelete_other_windows_internal, make_parent_window)
1212 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1213 (Fset_window_configuration, save_window_save): Don't deal with
1214 split status of windows.
1215 (saved_window): Remove splits slot.
1216 (Vwindow_splits): Rewrite doc-string.
1217
97f18cc8
JD
12182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1219
1220 * xfns.c (unwind_create_frame):
1221 * nsfns.m (unwind_create_frame):
1222 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1223 Vframe_list (Bug#9999).
1224
22a648b4
DA
12252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1226
0b381c7e 1227 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1228
659afede
KH
12292011-11-11 Kenichi Handa <handa@m17n.org>
1230
1231 * callproc.c (Fcall_process): Set the member dst_multibyte of
1232 process_coding.
1233
9ac0394b
KH
12342011-11-11 Johan Bockgård <bojohan@gnu.org>
1235
1236 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1237 avoid a crash (bug#9496).
1238
2fbdc249
CY
12392011-11-09 Chong Yidong <cyd@gnu.org>
1240
1241 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1242 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1243
ac6b1f81
PE
12442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1247
09db192c
PE
12482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 Avoid some portability problems by eschewing 'extern inline' functions.
1251 The trivial performance wins aren't worth the portability hassles; see
1252 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1253 et seq.
1254 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1255 (window_box_width, window_box_left, window_box_left_offset)
1256 (window_box_right, window_box_right_offset): Undo previous change,
1257 by removing the "extern"s.
1258 * intervals.c (adjust_intervals_for_insertion)
1259 (adjust_intervals_for_deletion): Undo previous change,
1260 making these static again.
1261 (offset_intervals, temp_set_point_both, temp_set_point)
1262 (copy_intervals_to_string): No longer inline.
1263 * xdisp.c (window_text_bottom_y, window_box_width)
1264 (window_box_height, window_box_left_offset)
1265 (window_box_right_offset, window_box_left, window_box_right)
1266 (window_box): No longer inline.
1267
105216ed
CY
12682011-11-08 Chong Yidong <cyd@gnu.org>
1269
1270 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1271 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1272 Signal an error if not a live window.
105216ed
CY
1273 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1274 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1275
ae9e237f
JB
12762011-11-07 Juanma Barranquero <lekktu@gmail.com>
1277
1278 * lisp.h (syms_of_abbrev): Remove declaration.
1279 Reported by CHENG Gao <chenggao@royau.me>.
1280
c7aa8333
EZ
12812011-11-07 Eli Zaretskii <eliz@gnu.org>
1282
1283 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1284 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1285 of temacs in GUI mode.
1286
be7f5545
MR
12872011-11-07 Martin Rudalics <rudalics@gmx.at>
1288
1289 * window.h: Declare delete_all_child_windows instead of
1290 delete_all_subwindows.
1291 * window.c (Fwindow_nest, Fset_window_nest)
1292 (Fset_window_new_total, Fset_window_new_normal)
1293 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1294 (delete_all_subwindows): Rename to delete_all_child_windows.
1295 (Fdelete_other_windows_internal, Fset_window_configuration):
1296 Call delete_all_child_windows instead of delete_all_subwindows.
1297 * frame.c (delete_frame): Call delete_all_child_windows instead
1298 of delete_all_subwindows.
1299
ca78dc43
PE
13002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1303 This is also needed for porting to any host where GC_MARK_STACK is
1304 not GC_MAKE_GCPROS_NOOPS.
1305 (which_symbols): Use it.
1306
a0241d01
KH
13072011-11-07 Kenichi Handa <handa@m17n.org>
1308
1309 * coding.c (coding_set_destination): Check coding->src_pos only
1310 when coding->src_object is a buffer (bug#9910).
1311
1312 * process.c (send_process): Set the member src_multibyte of coding
1313 to 0 (bug#9911) when sending a unibyte text.
1314
1315 * callproc.c (Fcall_process): Set the member src_multibyte of
1316 process_coding to 0 (bug#9912).
1317
a64bfdfa 13182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1319
1320 * xmenu.c (cleanup_widget_value_tree): New function.
1321 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1322 calling free_menubar_widget_value_tree directly (Bug#9830).
1323
cb41b32a
PE
13242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 Fix some portability problems with 'inline'.
1327 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1328 (window_box_width, window_box_left, window_box_left_offset)
1329 (window_box_right, window_box_right_offset): Declare extern.
1330 Otherwise, these inline functions do not conform to C99 and
1331 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1332 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1333 * intervals.c (adjust_intervals_for_insertion)
1334 (adjust_intervals_for_deletion): Now extern, because otherwise the
1335 extern inline functions 'offset_intervals' couldn't refer to it.
1336 (static_offset_intervals): Remove.
1337 (offset_intervals): Rewrite using the old contents of
1338 static_offset_intervals. The old version didn't conform to C99
1339 because an extern inline function contained a reference to an
1340 identifier with static linkage.
1341
b7041366
AS
13422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1343
1344 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1345 GC.
1346
88a37c4d
EZ
13472011-11-06 Eli Zaretskii <eliz@gnu.org>
1348
1349 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1350 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1351 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1352 return Qleft_to_right.
1353
49745b39
CY
13542011-11-06 Chong Yidong <cyd@gnu.org>
1355
1356 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1357 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1358 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1359 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1360 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1361 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1362 (Fwindow_vscroll): Doc fix.
1363 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1364 argument, since it makes no sense to pass a live window and for
1365 consistency with window-child.
1366
1f05cd82
CS
13672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1368
1369 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1370 support MSVC.
1371
22610910
JR
13722011-11-05 Jason Rumney <jasonr@gnu.org>
1373
1374 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1375 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1376 fonts (Bug#6029).
1377 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1378 bitwise arithmetic preventing use of unicode-sip and non-truetype
1379 opentype fonts.
1380
a06776b2
EZ
13812011-11-05 Eli Zaretskii <eliz@gnu.org>
1382
3ad924ba
EZ
1383 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1384 "emacs"-only part.
1385
a06776b2
EZ
1386 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1387 initialization code to keep similarity to xfns.c after changes
1388 from 2011-11-05.
1389
c9e7db78
JD
13902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1391
a97f8f3f
JD
1392 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1393 (unwind_create_frame): New function (Bug#9943).
1394 (Fx_create_frame): Restructure code to be more similar to the one in
1395 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1396 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1397 Move terminal->reference_count++ just before making the frame official
1398 (Bug#9943).
1399
1400 * nsterm.m (x_free_frame_resources): New function.
1401 (x_destroy_window): Move code to x_free_frame_resources.
1402
c9e7db78 1403 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1404 (Fx_create_frame, x_create_tip_frame):
1405 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1406 official. Move initialization of image_cache_refcount and
1407 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1408
a6fc3b5c
EZ
14092011-11-05 Eli Zaretskii <eliz@gnu.org>
1410
1411 Support MSVC build with newer versions of Visual Studio.
1412 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1413 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1414 nt/gmake.defs.
1415
1416 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1417 which are not supported by MSVC.
1418 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1419 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1420 bitfields.
1421 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1422 types in bitfields.
1423 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1424
1425 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1426
58179cce 14272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1428
1429 Support MSVC build with newer versions of Visual Studio.
1430 * w32.c: Don't include w32api.h for MSVC.
1431 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1432
1433 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1434 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1435 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1436 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1437 e_* cousins.
1438 (alloca) [_MSC_VER]: Define to _alloca.
1439
1440 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1441
1442 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1443
a58c13ed
EZ
14442011-11-04 Eli Zaretskii <eliz@gnu.org>
1445
1446 * xdisp.c (note_mouse_highlight): If either of
1447 previous/next-single-property-change returns nil, treat that as
1448 the beginning or the end of the buffer. (Bug#9955)
1449
fe0b6370
JD
14502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1451
a58c13ed 1452 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1453 label is not null (Bug#9951).
1454 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1455 may be NULL.
1456
89bd5ee1
EZ
14572011-11-04 Eli Zaretskii <eliz@gnu.org>
1458
1459 * window.c (Fwindow_body_size): Mention in the doc string that the
1460 return value is in frame's canonical units. (Bug#9949)
1461
84c3edb9
EZ
14622011-11-03 Eli Zaretskii <eliz@gnu.org>
1463
4e2fb5c7
EZ
1464 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1465
84c3edb9 1466 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1467 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1468 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1469
bc17a887
EZ
14702011-11-01 Eli Zaretskii <eliz@gnu.org>
1471
1472 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1473 Don't stop backward scan on the continuation glyph, even though
1474 its CHARPOS is positive.
6d5eb5b0
SM
1475 (mouse_face_from_buffer_pos, note_mouse_highlight):
1476 Rename cover_string to disp_string.
bc17a887 1477
4ee88440
MR
14782011-11-01 Martin Rudalics <rudalics@gmx.at>
1479
1480 * window.c (temp_output_buffer_show): Don't use
1481 Vtemp_buffer_show_specifiers.
1482 (Vtemp_buffer_show_specifiers): Remove unused variable.
1483
c2ff3c02
EZ
14842011-10-30 Eli Zaretskii <eliz@gnu.org>
1485
1486 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1487 past the beginning of the current glyph matrix.
1488
58179cce 14892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1490
1491 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1492 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1493 HAVE_GTK3 (Bug#9869).
b77a6a7f 1494
3b574623
JD
1495 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1496 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1497
b77a6a7f
JD
1498 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1499
1500 * xterm.c: Declare x_handle_net_wm_state to return int.
1501 (handle_one_xevent): Check if we are iconified but don't have
1502 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1503 (get_current_wm_state): Return non-zero if not hidden,
1504 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1505 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1506 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1507 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1508
196e41e4
PE
15092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1510
1511 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1512 so that this new function doesn't get optimized away by a
1513 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1514
021f2e1a
AS
15152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1516
1517 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1518
8b058d44
EZ
15192011-10-29 Eli Zaretskii <eliz@gnu.org>
1520
1521 Fix the `xbytecode' command.
1522 * .gdbinit (xprintbytestr): New command.
b50a28de 1523 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1524 (xbytecode): Print the byte-code string as well.
1525
4452fb80
EZ
15262011-10-29 Kim Storm <storm@cua.dk>
1527
8b058d44
EZ
1528 * alloc.c (which_symbols): New function.
1529
21b72067
AS
15302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1531
1532 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1533 line. (Bug#9903)
1534
83ed7b5c
GM
15352011-10-29 Glenn Morris <rgm@gnu.org>
1536
1537 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1538 Not clear what it was for, and it causes various bugs. (Bug#9839)
1539
5a7a728b
EZ
15402011-10-28 Eli Zaretskii <eliz@gnu.org>
1541
1542 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1543 possible random value that matches one of those tested as
1544 condition to clear the mouse face.
1545
d3d0842f
CY
15462011-10-28 Chong Yidong <cyd@gnu.org>
1547
1548 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1549
31b39d13
DN
15502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1551
1552 * window.c (make_window): Initialize phys_cursor_on_p.
1553
9aba6043
SM
15542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1555
1556 * lisp.h (struct Lisp_Symbol): Update comments.
1557
c20992f4
JB
15582011-10-28 Juanma Barranquero <lekktu@gmail.com>
1559
1560 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1561
db4f02f2
EZ
15622011-10-28 Eli Zaretskii <eliz@gnu.org>
1563
1564 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1565 <oslsachem@gmail.com> for helping to debug this.
1566
1567 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1568 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1569 (g_b_init_get_glyph_outline_w): New static variables.
1570 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1571 (GetGlyphOutlineW_Proc): New typedefs.
1572 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1573 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1574 New functions.
1575 (w32font_open_internal, compute_metrics):
1576 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1577 instead of calling the "wide" APIs directly.
1578
1579 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1580
1581 * w32.h (syms_of_w32font): Add prototype.
1582
87e68db4
JB
15832011-10-27 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1586 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1587 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1588 (Fmove_to_window_line): Doc fix.
1589
435c1d67
CY
15902011-10-27 Chong Yidong <cyd@gnu.org>
1591
1592 * process.c (make_process): Set gnutls_state to NULL.
1593
1594 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1595 non-NULL, regardless of GNUTLS_INITSTAGE.
1596 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1597 an error. Set process slots as soon as we allocate them.
1598
1599 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1600
9c6c6f49
CY
16012011-10-27 Chong Yidong <cyd@gnu.org>
1602
9aba6043
SM
1603 * gnutls.c (emacs_gnutls_deinit): New function.
1604 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1605 (Fgnutls_deinit, Fgnutls_boot): Use it.
1606
1607 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1608 (deactivate_process): Call emacs_gnutls_deinit.
1609
657d08d3
JB
16102011-10-27 Juanma Barranquero <lekktu@gmail.com>
1611
1612 * image.c (x_create_x_image_and_pixmap):
1613 * w32.c (sys_rename, w32_delayed_load):
1614 * w32font.c (fill_in_logfont):
1615 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1616
5430d399
JB
16172011-10-26 Juanma Barranquero <lekktu@gmail.com>
1618
1619 * w32fns.c (w32_default_color_map): New function,
1620 extracted from Fw32_default_color_map.
a7ef684b 1621 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1622
fe0055fa
PE
16232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1626
e6346438
SM
16272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1628
1629 * keyboard.c (test_undefined): New function (bug#9751).
1630 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1631
e112cc37
ET
16322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1633
1634 * sysdep.c (init_sys_modes): Fix the check for the controlling
1635 terminal (Bug#6649).
1636
7b5d6677
EZ
16372011-10-20 Eli Zaretskii <eliz@gnu.org>
1638
1639 * dispextern.h (struct bidi_it): New member next_en_type.
1640
1641 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1642 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1643 current character, check also for next_en_type being WEAK_EN.
1644 (bidi_resolve_weak): Don't enter the expensive loop if the current
1645 position is before next_en_pos. Record the bidi type of the first
1646 non-ET, non-BN character we find, in addition to its position.
1647 (bidi_level_of_next_char): Invalidate next_en_type when
1648 next_en_pos is over-stepped.
1649
7da0b018
PE
16502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1653 * editfns.c: Rewrite current-time-zone so that it invokes
1654 the equivalent of (format-time-string "%Z") to get the time zone name.
1655 This fixes a bug when the time zone name contains characters that
1656 need converting from the system time locale to Emacs internal format.
1657 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1658 that patch fixed format-time-string to do the conversion, but
1659 I forgot to fix current-time-zone.
1660 (format_time_string): New function, containing most of
1661 what Fformat_time_string used to contain.
1662 (Fformat_time_string): Rewrite in terms of format_time_string.
1663 This doesn't change this function's behavior.
1664 (current-time-zone): Rewrite to use format_time_string.
1665 This fixes the bug reported by Michael Schierl in
1666 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1667 Jason Rumney's 2007-06-07 change worked around this bug, but
1668 didn't fix it.
1669 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1670
8547b010
EZ
16712011-10-19 Eli Zaretskii <eliz@gnu.org>
1672
1673 * xdisp.c (start_display): If the character at POS is displayed
1674 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1675 (try_window_reusing_current_matrix): If a line ends in a display
1676 vector or the next line starts in a display vector, continue
1677 redrawing the window even though the character position of
1678 start_row was reached.
8547b010
EZ
1679 (Bug#9771, part 2)
1680
4e948d15
CY
16812011-10-18 Chong Yidong <cyd@gnu.org>
1682
1683 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1684 with nobreak-char-display too.
1685
4787455f
EZ
16862011-10-18 Eli Zaretskii <eliz@gnu.org>
1687
1688 Fix part 3 of bug#9771.
1689 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1690 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1691 non-neutral characters if the current character is a paragraph
1692 separator (a.k.a. Newline). This avoids running the same
1693 expensive loop twice, once when we consume the preceding newline
1694 and the other time when the line actually needs to be displayed.
1695 Avoid the loop when we see neutrals on the base embedding level
1696 following a character whose directionality is the same as the
1697 paragraph's. This avoids running the expensive loop when a line
1698 ends in a long sequence of neutrals, like control characters.
1699 Add assertion against STRONG_AL type. Slightly rearrange code
1700 that determines the type of a neutral given the first non-neutral
1701 that follows it.
1702 (bidi_level_of_next_char): Set next_en_pos to zero when
1703 invalidating its info.
1704
2c91f553
EZ
17052011-10-17 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (push_display_prop): Determine whether to record string
1708 or buffer position by IT->string, not by IT->method. Allow
1709 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1710 (move_it_vertically_backward): Don't look for character position
1711 immediately after the newline when in a continuation line.
1712 (Bug#9771, part 1)
2c91f553 1713
c7b08b0d
MR
17142011-10-15 Martin Rudalics <rudalics@gmx.at>
1715
1716 * window.c (coordinates_in_window): Rewrite and delabelize
1717 vertical border check. (Bug#5357) (Bug#9618)
1718
6b02f655
SM
17192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1720
1721 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1722 errors in XSetWindowBorder (bug#9310).
1723
81d40c92
DA
17242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1725
1726 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1727 avoid crash when xmalloc overrun checking is enabled.
1728
d4172c3b
EZ
17292011-10-13 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1732 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1733 cursor motion with <left> and <right> arrow keys.
1734
1735 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1736 some callers set that themselves.
1737
b00eea75
EZ
17382011-10-12 Eli Zaretskii <eliz@gnu.org>
1739
1740 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1741 display string and the previous row comes from the same string and
1742 is empty. (Bug#9739) (Bug#9738)
1743
8fe012c4
SM
17442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1745
1746 * doc.c (get_doc_string): Encode file name (bug#9735).
1747
0074aef2
EZ
17482011-10-12 Eli Zaretskii <eliz@gnu.org>
1749
79beb178
EZ
1750 * bidi.c (bidi_level_of_next_char):
1751 * xdisp.c (get_visually_first_element): Remove old incorrect
1752 comments regarding the Unicode Line Separator character.
1753
0074aef2
EZ
1754 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1755
6e4b3fbe
DA
17562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1757
1758 * alloc.c (Fgc_status): Do not access beyond zombies array
1759 boundary if nzombies > MAX_ZOMBIES.
1760 * alloc.c (dump_zombies): Add missing format specifier.
1761
0324f3af
PE
17622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1763
b5525cac
PE
1764 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1765 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1766
0324f3af
PE
1767 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1768 Some packages use them to denote characters with modifiers.
1769
e9b5f888
AS
17702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1771
1772 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1773 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1774 matching a pp-number. Rename parameter var to var1.
1775
127827c0
SM
17762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1777
1778 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1779
c8fd3bd0
GM
17802011-10-08 Glenn Morris <rgm@gnu.org>
1781
1782 * callint.c (Fcall_interactively): Give a more explicit error for the
1783 'c' case with a non-character input. (Bug#8479)
1784
352ec8ff
EZ
17852011-10-08 Eli Zaretskii <eliz@gnu.org>
1786
03669ccb
EZ
1787 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1788 lines.
7061c986
EZ
1789 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1790 lines that are hscrolled on the left.
03669ccb 1791
352ec8ff
EZ
1792 * dispnew.c (buffer_posn_from_coords): Account for a possible
1793 presence of header-line. (Bug#4426)
1794
a66cfb1c
SM
17952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1796
6b02f655
SM
1797 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1798 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1799
7c5ee88e
PE
18002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1803 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1804 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1805 this makes Emacs dump core during garbage collection on rare
1806 occasions. sizeof is obviously inferior to offsetof here, so
1807 stick with offsetof.
1808 (GC_POINTER_ALIGNMENT): New macro.
1809 (mark_memory): Omit 3rd (offset) arg; caller changed.
1810 Don't assume EMACS_INT alignment is the same as pointer alignment.
1811
df1bbe5b
SM
18122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1813
1814 * keyboard.c (read_key_sequence_remapped): New var.
1815 (read_key_sequence): Compute remapping in the right buffer.
1816 (command_loop_1): Use read_key_sequence's remapping directly.
1817
51553db6
SM
18182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1819
32c1fffd
SM
1820 * dired.c (file_name_completion): Don't expand file name.
1821 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1822 before checking file name handler.
1823
51553db6
SM
1824 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1825 they've been requested explicitly (bug#9591).
1826
b6bd1599 18272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1828
1829 * keymap.c (Fsingle_key_description): Use make_specified_string
1830 instead of build_string to build string from push_key_description.
1831 (Bug#5193)
1832
f701dc2a
PE
18332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1834
4222c55d
PE
1835 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1836 This fixes a Y2038 bug on 64-bit hosts.
1837 * buffer.c (reset_buffer):
1838 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1839 (Fclear_buffer_auto_save_failure):
1840 Use 0, not -1, to represent an unset failure time, since time_t
1841 might not be signed.
1842
f701dc2a
PE
1843 Remove dependency on glibc malloc internals.
1844 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1845 Move back here from lisp.h, but with their new implementations.
1846 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1847 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1848 * charset.c (charset_table_init): New static var.
1849 (syms_of_charset): Use it instead of xmalloc. This removes a
1850 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1851 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1852 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1853 Move back to alloc.c.
1854 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1855 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1856
9ceebf39
JD
18572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1858
1859 * nsterm.m (windowDidResize): Call x_set_window_size only when
1860 ns_in_resize is true. Otherwise set pixelwidth/height and
1861 call change_frame_size (Bug#9628).
1862
cb993c58
PE
18632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1864
3930c88b
PE
1865 Port --enable-checking=all to Fedora 14 x86-64.
1866 * charset.c (syms_of_charset): Also account for glibc malloc's
1867 internal overhead when calculating the initial malloc maximum.
1868
cb993c58
PE
1869 Port --enable-checking=all to Fedora 14 x86.
1870 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1871 Move to lisp.h.
1872 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1873 (overrun_check_realloc, overrun_check_free):
1874 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1875 That way, xmalloc returns a properly-aligned pointer even if
1876 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1877 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1878 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1879 into account when calculating the initial malloc maximum.
1880 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1881 Move here from alloc.c, so that charset.c can use it too.
1882 Properly align; the old code wasn't right for common 32-bit hosts
1883 when configured with --enable-checking=all.
1884 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1885 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1886
31bed486
EZ
18872011-09-29 Eli Zaretskii <eliz@gnu.org>
1888
04c70788 1889 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1890 use EDOM.
1891
fbcaa2f3
EZ
18922011-09-28 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (compute_display_string_end): If there's no display
1895 string at CHARPOS, return -1.
1896
1897 * bidi.c (bidi_fetch_char): When compute_display_string_end
1898 returns a negative value, treat the character as a normal
1899 character not covered by a display string. (Bug#9624)
1900
a239d4e9
JB
19012011-09-28 Juanma Barranquero <lekktu@gmail.com>
1902
1903 * lread.c (Fread_from_string): Fix typo in docstring.
1904
88652fd5
EZ
19052011-09-27 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1908 newline, reseat the iterator instead of bidi-iterating there one
1909 character at a time. (Bug#9610)
32c1fffd
SM
1910 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1911 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1912
ed497dd4
AS
19132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1914
1915 * lread.c (readevalloop): Use correct code for NBSP.
1916 (read1): Likewise. (Bug#9608)
1917
b2bf61aa
MA
19182011-09-25 Michael Albinus <michael.albinus@gmx.de>
1919
1920 * dbusbind.c (Fdbus_register_signal): When service is not
1921 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1922
32bbb17c
GM
19232011-09-25 Glenn Morris <rgm@gnu.org>
1924
1925 * buffer.c (truncate-lines): Doc fix.
1926
94e0933e
CY
19272011-09-24 Chong Yidong <cyd@stupidchicken.com>
1928
1929 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1930 (Fset_window_next_buffers): Doc fix.
1931
cddde921
GM
19322011-09-24 Glenn Morris <rgm@gnu.org>
1933
1934 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1935
1260aef1
PE
19362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1937
25b4bfa0
PE
1938 Fix minor problems found by static checking.
1939 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1940 * indent.c (Fvertical_motion): Fix == vs = typo.
1941
e3cbd34b
EZ
19422011-09-24 Eli Zaretskii <eliz@gnu.org>
1943
a66cfb1c
SM
1944 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1945 Default value is now t. Doc fix.
6bf7006f 1946
e3cbd34b 1947 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1948 logic when moving up, not only when moving down. Fix the
e3cbd34b 1949 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1950 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1951
1952 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1953 CHARPOS is covered by a display string which includes newlines.
1954 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1955 is covered by a display string with embedded newlines.
1956
a3de0cbd
MA
19572011-09-24 Michael Albinus <michael.albinus@gmx.de>
1958
1959 * dbusbind.c (Fdbus_register_signal): Add match rule to
1960 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1961 (Fdbus_register_method, Vdbus_registered_objects_table):
1962 Fix docstring.
a3de0cbd 1963
b260039d
JM
19642011-09-24 Jim Meyering <meyering@redhat.com>
1965
32c1fffd 1966 do not ignore write error for any output size
b260039d
JM
1967 The previous change was incomplete.
1968 While it makes emacs --batch detect the vast majority of stdout
1969 write failures, errors were still ignored whenever the output size is
1970 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1971 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1972 && echo FAIL: ignored write error
1973 FAIL: ignored write error
1974 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1975 && echo FAIL: ignored write error
1976 FAIL: ignored write error
1977 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1978
8eca8a7c
AS
19792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1980
1981 * emacs.c (Fkill_emacs): In noninteractive mode exit
1982 non-successfully if a write error occurred on stdout. (Bug#9574)
1983
3341db62
EZ
19842011-09-21 Eli Zaretskii <eliz@gnu.org>
1985
1986 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1987 the xassert test.
1988
1989 * dispextern.h (struct it): Update the comment documenting what
1990 can it->OBJECT be.
1991
8c203dbf
EZ
19922011-09-20 Eli Zaretskii <eliz@gnu.org>
1993
1994 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1995 a display string, extend search for cursor position to end of row.
1996 (find_row_edges): If the row ends in a newline from a display
1997 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1998 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1999 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2000 non-empty line. Fixes confusing cursor motion with arrow keys at
2001 the beginning of a line that starts with whitespace.
8c203dbf 2002
a4824228
LMI
20032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2004
2005 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2006 (bug#9493).
2007
33ed493b
CY
20082011-09-18 Chong Yidong <cyd@stupidchicken.com>
2009
2010 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2011 boolean (Bug#9154).
2012
56cd55c8
EZ
20132011-09-18 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (display_line): Record maximum and minimum buffer
2016 positions even if no glyphs were produced (e.g., by a zero-width
2017 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2018 buffer positions that will be removed from the glyph row because
2019 they don't fit.
c02dcedf
EZ
2020 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2021 column is beyond frame width: don't subtract 1 "pixel" when
2022 computing width of the stretch.
3e62b7e0
EZ
2023 (reseat_at_next_visible_line_start): Undo the change made on
2024 2011-09-17 that saved paragraph information and restored it after
2025 the call to `reseat'. (Bug#9545)
56cd55c8 2026
5ed99d36 20272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2028
2029 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2030 and turn window cursor on if cleared (Bug#9415).
2031
5ed99d36 20322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2033
2034 * search.c (boyer_moore): Take unibyte characters from pattern
2035 literally. (Bug#9458)
2036
9bade7b2
EZ
20372011-09-18 Eli Zaretskii <eliz@gnu.org>
2038
2039 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2040
e5e9d610
PE
20412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2042
87e4427a
PE
2043 Fix minor problem found by static checking.
2044 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2045 initialized, to pacify gcc -Wuninitialized.
2046
e5e9d610
PE
2047 * fileio.c: Report proper errno when syscall falls.
2048 (Finsert_file_contents): Save and restore errno,
2049 so that report_file_error outputs the correct diagnostic.
2050 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2051
a1674f0b
EZ
20522011-09-18 Eli Zaretskii <eliz@gnu.org>
2053
2054 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2055
fbfb6dd4
EZ
20562011-09-17 Eli Zaretskii <eliz@gnu.org>
2057
2058 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2059 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2060
bb187662
EZ
20612011-09-17 Eli Zaretskii <eliz@gnu.org>
2062
1137e8b8 2063 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2064 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2065
2066 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2067 (bidi_find_paragraph_start): Search back for paragraph beginning
2068 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2069 (bidi_move_to_visually_next): Only trigger paragraph-related
2070 computations when the last character is a newline or at EOB, not
2071 just any NEUTRAL_B. (Bug#9470)
2072
bb187662
EZ
2073 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2074 truncated lines if point is covered by a display string. (Bug#9524)
2075
2e621251
PE
20762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2079 (cons_to_x_long): New function.
2080 (lisp_data_to_selection_data): Use it. Correct the test for
2081 short-versus-long data; it was negated. Break out of vector
2082 loop, for efficiency, when a long datum is discovered.
2083
91a15bc6
SM
20842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2087
b41c3a35
EZ
20882011-09-16 Eli Zaretskii <eliz@gnu.org>
2089
2090 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2091 GCC PR/17406) by declaring this function with external scope.
2092
7812ba2d
PE
20932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2096 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2097
cf7edc2a
AS
20982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2099
2100 * editfns.c (Fformat): Correctly handle text properties on "%%".
2101
bd01620e
EZ
21022011-09-15 Eli Zaretskii <eliz@gnu.org>
2103
2104 * xterm.c (x_draw_composite_glyph_string_foreground):
2105 * w32term.c (x_draw_composite_glyph_string_foreground):
2106 * term.c (encode_terminal_code):
2107 * composite.c (composition_update_it, get_composition_id):
2108 * xdisp.c (get_next_display_element)
2109 (fill_composite_glyph_string): Add comments about special meaning
2110 of TAB characters in a composition.
2111
a02719a3
PE
21122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2115 This occurs when processing a multibyte format.
2116 Problem reported by Wolfgang Jenker.
a02719a3 2117
72589a3c
JB
21182011-09-15 Johan Bockgård <bojohan@gnu.org>
2119
2120 * xdisp.c (try_cursor_movement): Only check for exact match if
2121 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2122
1c14176c
PE
21232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 Remove unused external symbols.
2126 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2127 * xdisp.c (calc_pixel_width_or_height): Now static.
2128 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2129 * indent.c (check_display_width):
2130 * w32term.c: Fix comment to match code.
2131 * xterm.c, xterm.h (x_catching_errors): Remove.
2132
d2eea5b5
PE
21332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2134
2135 * xselect.c: Use signed conversions more consistently (Bug#9498).
2136 (selection_data_to_lisp_data): Assume incoming selection data are
2137 signed integers, not unsigned. This is to be consistent with
2138 outgoing selection data, which was modified to use signed integers
2139 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2140 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2141 expects long, not unsigned long.
2142
46888499
EZ
21432011-09-14 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2146 computation of loop end. Reported by Johan Bockgård
2147 <bojohan@gnu.org>.
2148
ef8ef9fb
CY
21492011-09-13 Chong Yidong <cyd@stupidchicken.com>
2150
2151 * frame.c (Fother_visible_frames_p): Function deleted.
2152
fa819fed
EZ
21532011-09-12 Eli Zaretskii <eliz@gnu.org>
2154
2155 * indent.c (compute_motion): Process display vector front to back
2156 rather than the other way around. (Bug#2496)
2157
2ba8e008
SM
21582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2159
2160 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2161
20f53c69
CY
21622011-09-11 Chong Yidong <cyd@stupidchicken.com>
2163
2164 * minibuf.c (Fread_from_minibuffer): Doc fix.
2165
d562d7a4
EZ
21662011-09-11 Eli Zaretskii <eliz@gnu.org>
2167
2168 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2169 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2170
1c4d7f3d
LMI
21712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2172
2173 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2174 value for non-existent files.
2175
b885bf36
EZ
21762011-09-11 Eli Zaretskii <eliz@gnu.org>
2177
2178 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2179 set its "size" to -1. This will set the modtime_size field of
2180 the corresponding buffer to -1, which is what
2181 verify-visited-file-modtime expects for files that do not exist.
2182 (Bug#9139)
2183
6612f0bf
PE
21842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2185
2186 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2187 here ...
2188 * lisp.h: ... from here. push_key_description is no longer
2189 defined in keyboard.c, so its declaration should not be in
2190 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2191 logically belongs with push_key_description.
2192
dfb3f755
PE
21932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * buffer.h: Include <sys/types.h> instead of <time.h>.
2196 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2197 Problem reported by Herbert J. Skuhra.
2198
3134906c
LMI
21992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2200
2201 * xml.c (parse_region): Make the parsing work for
2202 non-comment-starting XML files again (bug#9144).
2203
8d903f4e
AS
22042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2205
2206 * image.c (gif_load): Fix calculation of bottom and right corner.
2207 (Bug#9468)
2208
80ad64f4
EZ
22092011-09-10 Eli Zaretskii <eliz@gnu.org>
2210
2211 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2212 redisplay in small windows.
2213
208a048d
EZ
22142011-09-09 Eli Zaretskii <eliz@gnu.org>
2215
2216 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2217
9b1c252e
MR
22182011-09-08 Martin Rudalics <rudalics@gmx.at>
2219
2220 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2221 Operate on live windows only.
2222
2949f33b
JB
22232011-09-08 Juanma Barranquero <lekktu@gmail.com>
2224
2225 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2226
e08dcafd
EZ
22272011-09-07 Eli Zaretskii <eliz@gnu.org>
2228
2229 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2230 only under bidi iteration.
2231
115b96bd
JD
22322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2233
2234 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2235
c8199d0f
PE
22362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2239 Without this fix, the command to link temacs failed due to an
2240 undefined symbol __builtin_isnan. This is because
2241 /usr/include/iso/math_c99.h #defines isnan(x) to
2242 __builtin_isnan(x), but the bundled gcc, which identifies itself
2243 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2244 a __builtin_isnan.
2245 * floatfns.c (isnan): #undef, and then #define to a clone of
2246 what's in data.c.
2247 (Fisnan): Always define, since it's always available now.
2248 (syms_of_floatfns): Always define isnan at the Lisp level.
2249
e39b275c 22502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2251
2252 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2253
b2db44d9 22542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2255
f4af5137 2256 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2257 The previous code assumed that file offsets (off_t values) fit in
2258 EMACS_INT variables, which is not true on typical 32-bit hosts.
2259 The code messed up by falsely reporting buffer overflow in cases
2260 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2261 when "big" contains more than 2**29 bytes, even though this
2262 inserts just one byte and does not overflow the buffer.
2263 (Finsert_file_contents): Store file offsets as off_t
2264 values, not as EMACS_INT values. Check for overflow when
2265 converting between EMACS_INT and off_t. When checking for
2266 buffer overflow or for overlap, take the offsets into account.
2267 Don't use EMACS_INT for small values where int suffices.
2268 When checking for overlap, fix a typo: ZV was used where
2269 ZV_BYTE was intended.
2270 (Fwrite_region): Don't assume off_t fits into 'long'.
2271 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2272
ecfc0a49
MA
22732011-09-05 Michael Albinus <michael.albinus@gmx.de>
2274
2275 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2276
6511acf2 22772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2278
0999621a 2279 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2280
2281 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2282 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2283 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2284 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2285 (modify_event_symbol): Do not assume that the length of
2286 name_alist_or_stem is safe to alloca and fits in int.
2287 (Fexecute_extended_command): Likewise for function name and binding.
2288 (Frecursion_depth): Wrap around reliably on integer overflow.
2289 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2290 since some callers pass EMACS_INT values.
2291 (Fsingle_key_description): Don't crash if symbol name contains more
2292 than MAX_ALLOCA bytes.
2293 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2294 (get_minibuffer): Arg is now EMACS_INT, not int.
2295 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2296 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2297 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2298
2be7d702
PE
2299 * dbusbind.c (signature_cat): New function.
2300 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2301 Do not overrun buffer; instead, report string overflow.
2302
9d1df220
PE
2303 * dispnew.c (add_window_display_history): Don't overrun buffer.
2304 Truncate instead; this is OK since it's just a log.
2305
33ef5c64
PE
2306 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2307 even if the time zone offset is outlandishly large.
2308 Don't mishandle offset == INT_MIN.
2309
66c6fdd5
PE
2310 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2311 when creating daemon; the previous buffer-overflow check was incorrect.
2312
d749b01b
PE
2313 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2314 which has the guts of the old verror function.
2315
b5cd1905
PE
2316 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2317 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2318
6e1a67fb
PE
2319 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2320 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2321 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2322 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2323 length of string rather than counting it via multiple sprintfs;
2324 that's simpler and more reliable.
c21721cc
PE
2325 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2326 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2327 sprintf, in case result does not fit in int.
2328
c57b67fc
PE
2329 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2330 (fontset_from_font): Print it.
2331
8a401434
PE
2332 * frame.c (tty_frame_count): Now printmax_t, not int.
2333 (make_terminal_frame, set_term_frame_name): Print it.
2334 (x_report_frame_params): In X, window IDs are unsigned long,
2335 not signed long, so print them as unsigned.
2336 (validate_x_resource_name): Check for implausibly long names,
2337 and don't assume name length fits in 'int'.
2338 (x_get_resource_string): Don't blindly alloca invocation name;
2339 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2340 not fit in int.
2341
6e1a67fb
PE
2342 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2343 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2344 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2345
0df02bf3
PE
2346 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2347 Use esprintf, not sprintf, in case result does not fit in int.
2348
48e30793
PE
2349 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2350 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2351 it as a large positive number.
2352 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2353 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2354
a66ff6d8
PE
2355 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2356 in case result does not fit in int.
2357
aca216ff
PE
2358 * print.c (float_to_string): Detect width overflow more reliably.
2359 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2360 buffer overrun. Don't assume list length fits in 'int'. Treat
2361 print length of 0 as 0, not as infinity; to be consistent with other
2362 uses of print length in this function. Don't overflow print length
2363 index. Don't assume hash table size fits in 'long', or that
2364 vectorlike size fits in 'unsigned long'.
2365
31c286f7
PE
2366 * process.c (make_process): Use printmax_t, not int, to format
2367 process-name gensyms.
2368
55e5faa1
PE
2369 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2370
80f2e268
PE
2371 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2372 to avoid potential buffer overrun.
2373
670741ab
PE
2374 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2375 if X resource line is longer than 512 bytes.
2376
b7163a50
PE
2377 * xfns.c (x_window): Make sprintf buffer a bit bigger
2378 to avoid potential buffer overrun.
2379
ae58ff1f
PE
2380 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2381
c43c8a6a
PE
2382 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2383
3f8236f4
PE
23842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2385
53e9fe90 2386 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2387 Without these, Emacs silently mishandles large integers sometimes.
2388 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2389 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2390
6511acf2
PE
2391 * xdisp.c (try_window_id): Check Emacs fixnum range before
2392 converting to 'int'.
806add1d 2393
6511acf2 2394 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2395 Check that an Emacs fixnum is in range before assigning it to 'int'.
2396 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2397 values converted from Emacs fixnums.
2398 (Frecenter): Don't wrap around a line count if it is out of 'int'
2399 range; instead, treat it as an extreme value.
2400 (Fset_window_configuration, compare_window_configurations):
2401 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2402
6511acf2
PE
2403 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2404 that can exceed INT_MAX. Check that EMACS_INT value is in range
2405 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2406 (match_limit): Don't assume that a fixnum can fit in 'int'.
2407
6511acf2 2408 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2409 exceed INT_MAX.
2410
6511acf2 2411 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2412 (Fvertical_motion): Don't wrap around LINES values that don't fit
2413 in 'int'. Instead, treat them as extreme values. This is good
2414 enough for windows, which can't have more than INT_MAX lines anyway.
2415
fcb901a7
LMI
24162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2417
0f2f6b6d
LMI
2418 * Require libxml/parser.h to avoid compilation warning.
2419
fcb901a7
LMI
2420 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2421
2422 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2423 since this reportedly can destroy thread storage.
2424
6e20a0d4
CY
24252011-08-30 Chong Yidong <cyd@stupidchicken.com>
2426
2427 * syntax.c (find_defun_start): Update all cache variables if
2428 exiting early (Bug#9401).
2429
148ae00e
EZ
24302011-08-30 Eli Zaretskii <eliz@gnu.org>
2431
f6cfbd8f
EZ
2432 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2433
148ae00e
EZ
2434 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2435 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2436 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2437
2438 * term.c (tty_append_glyph): New function.
2439 (produce_stretch_glyph): Static function and its prototype deleted.
2440
a66cfb1c
SM
2441 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2442 Add prototypes.
148ae00e 2443
c4a07a4c
PE
24442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2447 when checking :margin (Bug#9390).
2448 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2449 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2450 so that the name doesn't mislead. All uses changed.
2451
6bc8cd65
JB
24522011-08-28 Johan Bockgård <bojohan@gnu.org>
2453
2454 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2455 set_tty_hooks.
2456
dca4927e
EZ
24572011-08-27 Eli Zaretskii <eliz@gnu.org>
2458
2459 * xdisp.c (move_it_to): Don't bail out early when reaching
2460 position beyond to_charpos, if we are scanning backwards.
2461 (move_it_vertically_backward): When DY == 0, make sure we get to
2462 the first character in the line after the newline.
2463
f2cad773
PE
24642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2467 (ccl_driver): Do not generate an out-of-range pointer.
2468 (Fccl_execute_on_string): Remove unnecessary check for
2469 integer overflow, noted by Stefan Monnier in
2470 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2471 Remove a FIXME that didn't need fixing.
2472 Simplify the newly-introduced buffer reallocation code.
2473
0cae2cdb
JB
24742011-08-27 Juanma Barranquero <lekktu@gmail.com>
2475
2476 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2477
5fc295a4 24782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2479
70c60eb2 2480 Integer and memory overflow issues (Bug#9196).
726e0ab1 2481
d31850da
PE
2482 * doc.c (get_doc_string): Rework so that
2483 get_doc_string_buffer_size is the actual buffer size, rather than
2484 being 1 less than the actual buffer size; this makes xpalloc more
2485 convenient.
2486
a69fbedb
PE
2487 * image.c (x_allocate_bitmap_record, cache_image):
2488 * xselect.c (Fx_register_dnd_atom):
2489 Simplify previous changes by using xpalloc.
2490
fe5c5d37
PE
2491 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2492 since either will do and ptrdiff_t is convenient with xpalloc.
2493
0065d054
PE
2494 * charset.c (charset_table_size)
2495 (struct charset_sort_data.priority): Now ptrdiff_t.
2496 (charset_compare): Don't overflow if priorities differ greatly.
2497 (Fsort_charsets): Don't assume list length fits in int.
2498 Check for size-calculation overflow when allocating sort data.
2499 (syms_of_charset): Allocate an initial charset table that is
2500 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2501
2502 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2503
2504 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2505 The actual value is always <= INT_MAX, and leaving it unsigned made
2506 overflow checking harder.
2507
2508 * dispextern.h (struct glyph_matrix.rows_allocated)
2509 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2510 with xpalloc. The values are still always <= INT_MAX.
2511
2512 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2513
2514 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2515 (SAFE_NALLOCA): New macro.
2516
2517 * region-cache.c (struct boundary.pos, find_cache_boundary)
2518 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2519 (set_cache_region, invalidate_region_cache)
2520 (revalidate_region_cache, know_region_cache, region_cache_forward)
2521 (region_cache_backward, pp_cache):
2522 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2523 so that ptrdiff_t * can be passed to xpalloc.
2524 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2525 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2526 (pp_cache): Don't assume cache_len fits in int.
2527 * region-cache.h: Adjust extern decls to match.
2528
2529 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2530 EMACS_INT, since either will do, for xpalloc.
2531
2532 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2533 (xnmalloc, xnrealloc, xpalloc): New functions.
2534
726e0ab1
PE
2535 * bidi.c (bidi_shelve_header_size): New constant.
2536 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2537 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2538
51f30bc5 2539 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2540 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2541 (overlay_strings):
2542 Don't update size of array until after memory allocation succeeds,
2543 because xmalloc/xrealloc may not return.
0065d054
PE
2544 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2545 now that we have proper integer overflow checking.
2546 (record_overlay_string, overlay_strings): Catch overflows when
2547 calculating size of overlay_str_buf.
726e0ab1 2548
0065d054
PE
2549 * callproc.c (Fcall_process): Check for size overflow when
2550 calculating size of args2.
2551 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2552 Normally we prefer signed values, but sticking with ptrdiff_t would
2553 require adding more-complicated checks.
726e0ab1
PE
2554
2555 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2556 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2557 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2558 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2559
2560 * character.c (Fstring): Check for size-calculation overflow.
2561
2562 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2563 unnecessary integer overflow. Check for size overflow.
2564 (encode_coding_object): Don't update size until xmalloc succeeds.
2565
2566 * composite.c (get_composition_id): Check for overflow in glyph
2567 length calculations.
2568
2569 Integer and memory overflow fixes for display code.
2570 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2571 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2572 (scrolling_window): Check for overflow in size calculations.
2573 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2574 Don't assume glyph table len fits in int.
2575 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2576 (row_table_size): Now ptrdiff_t, not int.
2577 (scrolling_window): Avoid overflow in size calculations.
2578 Don't update size until allocation succeeds.
2579 * fns.c (concat): Check for overflow in size calculations.
2580 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2581 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2582 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2583
2584 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2585 (get_doc_string): Check for size calculation overflow.
2586 Don't update size until allocation succeeds.
2587 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2588 EMACS_INT, where ptrdiff_t will do.
2589 (Fsubstitute_command_keys): Check for string overflow.
2590
2591 * editfns.c (set_time_zone_rule): Don't assume environment length
2592 fits in int.
2593 (message_length): Now ptrdiff_t, not int.
2594 (Fmessage_box): Don't update size until allocation succeeds.
2595 Don't assume message length fits in int.
2596 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2597
0065d054
PE
2598 * emacs.c (main): Do not reallocate argv, since there is a null at
2599 the end that can be overwritten, and this way there's no need to
2600 worry about size-calculation overflow.
2601 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2602
2603 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2604 alloc succeeds.
2605 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2606
2607 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2608 (x_set_scroll_bar_width, x_figure_window_size):
2609 Check for integer overflow.
2610 (x_set_alpha): Do not assume XINT fits in int.
2611
2612 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2613 This is for the members text_lines, text_cols, total_lines, total_cols,
2614 where the system imposes an 'int' limit.
2615
2616 * fringe.c (Fdefine_fringe_bitmap):
2617 Don't update size until alloc works.
2618
2619 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2620 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2621
2622 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2623 Check for size-calculation overflow.
2624 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2625 do, as we prefer signed integers.
2626 (id_to_widget.max_size, id_to_widget.used)
2627 (xg_store_widget_in_map, xg_remove_widget_from_map)
2628 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2629 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2630 Use and return ptrdiff_t, not int.
2631 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2632 * gtkutil.h: Change prototypes to match the above.
2633
2634 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2635 are duplicate now that they've been promoted to lisp.h.
2636 (x_allocate_bitmap_record, x_alloc_image_color)
2637 (make_image_cache, cache_image, xpm_load):
2638 Don't update size until alloc is done.
2639 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2640 (x_detect_edges):
3256efce 2641 Check for size calculation overflow.
726e0ab1
PE
2642 (ct_colors_allocated_max): New constant.
2643 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2644 overflow.
3256efce 2645
726e0ab1
PE
2646 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2647 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2648 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2649 Use ptrdiff_t, not int, to count maps.
2650 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2651 calculations. Don't update size until allocation succeeds.
2652 Redo calculations to avoid overflow.
726e0ab1
PE
2653 * keyboard.h: Change prototypes to match the above.
2654
2655 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2656 to count maps.
2657 (current_minor_maps): Check for size calculation overflow.
2658 * keymap.h: Change prototypes to match the above.
2659
2660 * lread.c (read1, init_obarray): Don't update size until alloc done.
2661
2662 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2663 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2664
726e0ab1
PE
2665 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2666 Now ptrdiff_t, not int.
2667 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2668 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2669
2670 * process.c (Fnetwork_interface_list): Check for overflow
2671 in size calculation.
2672
2673 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2674
2675 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2676 overflow. Don't bother calling xmalloc when xrealloc will do.
2677
2678 * search.c (Freplace_match): Check for size calculation overflow.
2679 (Fset_match_data): Don't assume list lengths fit in 'int'.
2680
2681 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2682 for command line length. Do not attempt to address one before the
2683 beginning of an array, as that's not portable.
2684
2685 * term.c (max_frame_lines): Remove; unused.
2686 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2687 not int.
2688 (encode_terminal_code, calculate_costs): Check for size
2689 calculation overflow.
2690 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2691 table lengths and related sizes. Don't update size until alloc
2692 done. Redo calculations to avoid overflow.
2693 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2694
2695 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2696 subtracting pointers.
2697 (gobble_line): Check for overflow more carefully. Don't update size
2698 until alloc done.
2699
2700 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2701 Don't update size until alloc done.
2702 Redo size calculations to avoid overflow.
2703 Check for size calculation overflow.
0065d054 2704 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2705
2706 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2707 Use ptrdiff_t, not int, for sizes.
2708 (store_mode_line_noprop_char): Don't update size until alloc done.
2709
0065d054
PE
2710 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2711 Use ptrdiff_t, not int, for sizes.
2712 (Finternal_make_lisp_face, cache_face):
2713 Check for size calculation overflow.
2714 (cache_face): Treat size calculation overflows as if they were
2715 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2716
2717 * xfns.c (x_encode_text, x_set_name_internal)
2718 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2719 sizes, since they can exceed INT_MAX in size. Check for size
2720 calculation overflow.
2721
0065d054
PE
2722 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2723 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2724 Don't update size until alloc done.
2725
0065d054 2726 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2727 as sprintf is limited to int lengths.
1d526e2f 2728
252c5ee1
PE
2729 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2730 (X_LONG_MIN): New macros.
864d7ce7
PE
2731 Use them to make the following changes clearer.
2732 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2733 This change doesn't affect the value now, but it may help remind
2734 future maintainers not to raise the value too much later.
2735 (SELECTION_QUANTUM): Remove, replacing with ...
2736 (selection_quantum): ... new function, which avoids overflow.
2737 All uses changed.
2738 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2739 assumption that selection length fits in 'int'.
2740 (x_reply_selection_request, x_handle_selection_request)
2741 (x_get_window_property, receive_incremental_selection)
2742 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2743 (lisp_data_to_selection_data, clean_local_selection_data):
2744 Use ptrdiff_t, not int, to record length of selection.
2745 (x_reply_selection_request, x_get_window_property)
2746 (receive_incremental_selection, x_property_data_to_lisp):
2747 Redo calculations to avoid overflow.
2748 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2749 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2750 something.
2751 (x_get_window_property, receive_incremental_selection)
2752 (lisp_data_to_selection_data, x_property_data_to_lisp):
2753 Check for size-calculation overflow.
2754 (x_get_window_property, receive_incremental_selection)
2755 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2756 Don't store size until memory allocation succeeds.
2757 (x_get_window_property): Plug memory leak on memory exhaustion.
2758 Don't double-block input; malloc is safe here. Don't assume 2**34
2759 - 4 fits in unsigned long. Add an xassert to check
2760 XGetWindowProperty overflow. Be more careful about overflow
2761 calculations, and distinguish size from memory overflow better.
2762 (receive_incremental_selection): When tracing, don't assume
2763 unsigned int is less than INT_MAX.
2764 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2765 harmful) conversions of unsigned short to int.
2766 (lisp_data_to_selection_data): Don't assume that integers
2767 in the range -65535 through -1 fit in an X unsigned short.
2768 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2769 result parameters unless successful. Rely on cons_to_unsigned
2770 to report problems with elements; the old code wasn't right anyway.
2771 (x_check_property_data): Check for int overflow; we cannot use
2772 a wider type due to X limits.
2773 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2774
726e0ab1 2775 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2776
0065d054
PE
2777 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2778 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2779 (x_color_cells): Don't store size until memory allocation succeeds.
2780 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2781 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2782 (x_term_init): Don't assume length fits in int (sprintf is limited
2783 to int size).
bc18e09d 2784
ebfa62c0
PE
2785 Use ptrdiff_t for composition IDs.
2786 * character.c (lisp_string_width):
2787 * composite.c (composition_table_size, n_compositions)
2788 (get_composition_id, composition_gstring_from_id):
2789 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2790 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2791 * window.c (Frecenter):
2792 Use ptrdiff_t, not int, for composition IDs.
2793 * composite.c (get_composition_id): Check for integer overflow.
2794 * composite.h: Adjust prototypes to match the above changes.
2795
d3411f89
PE
2796 Use ptrdiff_t for hash table indexes.
2797 * category.c (hash_get_category_set):
2798 * ccl.c (ccl_driver):
2799 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2800 * coding.c (coding_system_charset_list, detect_coding_system):
2801 * coding.h (struct coding_system.id):
2802 * composite.c (get_composition_id, gstring_lookup_cache):
2803 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2804 * image.c (xpm_get_color_table_h):
2805 * lisp.h (hash_lookup, hash_put):
2806 * minibuf.c (Ftest_completion):
2807 Use ptrdiff_t for hash table indexes, not int (which is too
2808 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2809 32-bit --with-wide-int hosts).
2810
e097a6fa
PE
2811 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2812 Add a FIXME comment about memory leaks.
2813 (syms_of_charset): Don't assume xmalloc returns.
2814
5637687f
PE
2815 Don't assume that stated character widths fit in int.
2816 * character.c (Fchar_width, c_string_width, lisp_string_width):
2817 * character.h (CHAR_WIDTH):
2818 * indent.c (MULTIBYTE_BYTES_WIDTH):
2819 Use sanitize_char_width to avoid undefined and/or bad behavior
2820 with outlandish widths.
a66cfb1c 2821 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2822 now that we have two such functions. All uses changed.
2823 (sanitize_char_width): New inline function.
2824
a2271ba2
PE
2825 Don't assume that tab-width fits in int.
2826 * character.h (sanitize_width): New inline function.
2827 (SANE_TAB_WIDTH): New macro.
2828 (ASCII_CHAR_WIDTH): Use it.
2829 * indent.c (sane_tab_width): Remove. All uses replaced by
2830 SANE_TAB_WIDTH (current_buffer).
2831 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2832
18c52557
PE
2833 * fileio.c: Integer overflow issues with file modes.
2834 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2835
caeeedc1
PE
2836 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2837 Remove unreachable code.
2838 (read_hex, load_charset_map_from_file): Check for integer overflow.
2839
6df6ae42 2840 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2841 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2842 (x_send_scroll_bar_event): Likewise. Check that the size does not
2843 exceed limits imposed by XClientMessageEvent, as well as the usual
2844 ptrdiff_t and size_t limits.
2845
b13995db
PE
2846 * keyboard.c: Overflow, signedness and related fixes.
2847 (make_lispy_movement): Use same integer type in forward decl
2848 that is used in the definition.
2849 (read_key_sequence, keyremap_step):
2850 Change bufsize argument back to int, undoing my 2011-03-30 change.
2851 We prefer signed types, and int is wide enough here.
2852 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2853 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2854 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2855 length, not size_t. Use ptrdiff_t for index, not int.
2856 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2857 possibility of integer overflow.
2858
13464394
PE
2859 Overflow, signedness and related fixes for images.
2860
2861 * dispextern.h (struct it.stack[0].u.image.image_id)
2862 (struct_it.image_id, struct image.id, struct image_cache.size)
2863 (struct image_cache.used, struct image_cache.ref_count):
2864 * gtkutil.c (update_frame_tool_bar):
2865 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2866 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2867 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2868 * nsmenu.m (update_frame_tool_bar):
2869 * xdisp.c (calc_pixel_width_or_height):
2870 * xfns.c (image_cache_refcount):
2871 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2872 on typical 64-bit hosts.
2873
2874 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2875 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2876 Omit unnecessary casts to int.
2877 (parse_image_spec): Check that integers fall into 'int' range
2878 when the callers expect that.
2879 (image_ascent): Redo ascent calculation to avoid int overflow.
2880 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2881 (lookup_image): Remove unnecessary tests.
2882 (xbm_image_p): Locals are now of int, not EMACS_INT,
2883 since parse_image_check makes sure they fit into int.
2884 (png_load, gif_load, svg_load_image):
2885 Prefer int to unsigned where either will do.
2886 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2887 old tiff_error_handler and tiff_warning_handler.
2888 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2889 stack buffer overflows. It uses only the features of vsnprintf
2890 that are common to both POSIX and native Microsoft.
2891 (tiff_error_handler, tiff_warning_handler): Use it.
2892 (tiff_load, gif_load, imagemagick_load_image):
2893 Don't assume :index value fits in 'int'.
2894 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2895 (imagemagick_load_image): Check that crop parameters fit into
2896 the integer types that MagickCropImage accepts. Don't assume
2897 Vimagemagick_render_type has a nonnegative value. Don't assume
2898 size_t fits in 'long'.
2899 (gs_load): Use printmax_t to print the widest integers possible.
2900 Check for integer overflow when computing image height and width.
2901
c11821d4
EZ
29022011-08-26 Eli Zaretskii <eliz@gnu.org>
2903
2904 * xdisp.c (redisplay_window): Don't force window start if point
2905 will be invisible in the resulting window. (Bug#9324)
2906
0c95fcf7
EZ
29072011-08-25 Eli Zaretskii <eliz@gnu.org>
2908
2909 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2910 the display spec is of the form `(space ...)'.
2911 (handle_display_spec): Return the value returned by
2912 handle_single_display_spec, not just 1 or zero.
2913 (handle_single_display_spec): If the display spec is of the form
2914 `(space ...)', and specifies display in the text area, return 2
2915 rather than 1.
fee65a97 2916 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2917 accurately, and prefer exact match for point under bidi.
2918 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2919
2920 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2921 into disp_prop; all users changed.
2922
2923 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2924 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2925 for the text covered by the display property.
2926
e4ed06f1
CY
29272011-08-25 Chong Yidong <cyd@stupidchicken.com>
2928
2929 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2930 Change return value to nil.
2931 (Frecord_buffer): Delete unused function.
2932
f67cdd7f
EZ
29332011-08-24 Eli Zaretskii <eliz@gnu.org>
2934
5980d4c6
EZ
2935 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2936 buffers, return left-to-right.
8610fe8b
EZ
2937 (set_cursor_from_row): Consider candidate row a win if its glyph
2938 represents a newline and point is on that newline. Fixes cursor
2939 positioning on the newline at EOL of R2L text within L2R
2940 paragraph, and vice versa.
2941 (try_cursor_movement): Check continued rows, in addition to
2942 continuation rows. Fixes unwarranted scroll when point enters a
2943 continued line of R2L text within an L2R paragraph, or vice versa.
2944 (cursor_row_p): Consider the case of point being equal to
2945 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2946 from the end of a short line to the beginning of a continued line
2947 of R2L text within L2R paragraph.
2948 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2949 composed characters.
5980d4c6 2950
f67cdd7f
EZ
2951 * bidi.c (bidi_check_type): Use xassert.
2952 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2953 members.
2954
bca633fb
EZ
29552011-08-23 Eli Zaretskii <eliz@gnu.org>
2956
2957 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2958 a character.
2959
4a5885a7
CY
29602011-08-23 Chong Yidong <cyd@stupidchicken.com>
2961
2962 * nsfont.m (ns_otf_to_script): Fix typo.
2963
0902a04e
KH
29642011-08-22 Kenichi Handa <handa@m17n.org>
2965
2966 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2967 extra slot even if the purpose is char-code-property-table.
2968
1a2e6670
EZ
29692011-08-23 Eli Zaretskii <eliz@gnu.org>
2970
8ddde651
EZ
2971 * xdisp.c (redisplay_window): When computing centering_position,
2972 account for the height of the header line. (Bug#8874)
2973
425cc014
EZ
2974 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2975 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2976 candidate is selected by the mouse, and that candidate has a
2977 composed character under the mouse.
2978
1a2e6670
EZ
2979 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2980 coordinates reported by pos-visible-in-window-p for a composed
2981 character in column zero.
2982
8b76d6f8
SM
29832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2984
2985 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2986
dac347dd
EZ
29872011-08-22 Eli Zaretskii <eliz@gnu.org>
2988
2989 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2990 consider it a hit if to_charpos is anywhere in the range of the
2991 composed buffer positions.
2992
e013fb34
CY
29932011-08-22 Chong Yidong <cyd@stupidchicken.com>
2994
2995 * image.c (gif_load): Don't assume that each subimage has the same
2996 dimensions as the base image. Handle disposal method that is
2997 "undefined" by the gif spec (Bug#9335).
2998
bd1ba3e8
CY
29992011-08-20 Chong Yidong <cyd@stupidchicken.com>
3000
3001 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3002 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3003
54a1215b
EZ
30042011-08-19 Eli Zaretskii <eliz@gnu.org>
3005
823564e5
EZ
3006 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3007 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3008 from an Org mode buffer to a Speedbar frame.
3009
54a1215b
EZ
3010 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3011 a composition, take its buffer position from IT->cmp_it.charpos.
3012 Fixes cursor positioning at the beginning of a line that begins
3013 with a composed character.
3014
9778ebcc
EZ
30152011-08-18 Eli Zaretskii <eliz@gnu.org>
3016
0be6ee06
EZ
3017 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3018 character bidirectional type, use STRONG_L instead. Fixes crashes
3019 in a buffer produced by `describe-categories'.
3020
9778ebcc
EZ
3021 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3022 members before the level stack, so they would be saved and
3023 restored when copying iterator state. Fixes incorrect reordering
3024 around TABs covered by display properties.
3025
156bffbe
AS
30262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3027
6b02f655 3028 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3029
72ad093b
CY
30302011-08-17 Chong Yidong <cyd@stupidchicken.com>
3031
3032 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3033 (internal_condition_case_2, internal_condition_case_n):
3034 Remove unnecessary aborts (Bug#9081).
72ad093b 3035
35774242
EZ
30362011-08-17 Eli Zaretskii <eliz@gnu.org>
3037
3038 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3039 has no `load' handler, try opening the file locally. (Bug#9311)
3040
db76dd85
KB
30412011-08-16 Ken Brown <kbrown@cornell.edu>
3042
3043 * gmalloc.c: Expand comment.
3044
b215eee5
EZ
30452011-08-16 Eli Zaretskii <eliz@gnu.org>
3046
3047 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3048 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3049
a4579d33
KB
30502011-08-16 Ken Brown <kbrown@cornell.edu>
3051
3052 Fix memory allocation problems in Cygwin build (Bug#9273).
3053
3054 * unexcw.c ( __malloc_initialized): Declare external variable.
3055 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3056
8b76d6f8
SM
3057 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3058 New variables.
a4579d33
KB
3059 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3060 dumped emacs.
3061 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3062 in the static heap.
3063 [CYGWIN] (special_realloc): New function.
3064 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3065 requests to realloc storage in the static heap.
3066
3ebec551
PE
30672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3068
3069 * bidi.c (bidi_initialize): Remove unused local.
3070
9fd8be00
EZ
30712011-08-15 Eli Zaretskii <eliz@gnu.org>
3072
6b02f655
SM
3073 * bidimirror.h:
3074 * biditype.h: Remove file.
3075 * makefile.w32-in ($(BLD)/bidi.$(O)):
3076 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3077
3078 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3079
3080 * chartab.c: Improve commentary for the uniprop_table API.
3081
32413314
EZ
3082 * bidi.c (bidi_paragraph_init): Support zero value of
3083 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3084 (bidi_initialize): Use uniprop_table instead of including
3085 biditype.h and bidimirror.h.
32413314 3086
9fd8be00
EZ
3087 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3088 coordinates of the iterator when restoring from ppos_it.
3089 (Bug#9296)
3090
5cf2b69b
KH
30912011-08-14 Kenichi Handa <handa@m17n.org>
3092
3093 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3094 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3095
daf17d00
EZ
30962011-08-14 Eli Zaretskii <eliz@gnu.org>
3097
3098 * xdisp.c (move_it_in_display_line_to): Don't invoke
3099 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3100 ppos_it. Fixes vertical cursor motion when line beginning is
3101 covered by an image. (Bug#9296)
3102
08e3161a
JD
31032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3104
3105 * nsterm.h (ns_run_ascript): Declare.
3106 (NSAPP_DATA2_RUNASSCRIPT): Define.
3107
3108 * nsfns.m (as_script, as_result, as_status): New static variables.
3109 (ns_run_ascript): New function.
5e617bc2 3110 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3111 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3112 the event loop. Get status from as_status (Bug#7276).
3113
3114 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3115 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3116 the event loop (Bug#7276).
3117
a3720aa2
AS
31182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3119
3120 * gnutls.c (QCgnutls_bootprop_priority)
3121 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3122 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3123 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3124 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3125 (QCgnutls_bootprop_verify_hostname_error)
3126 (QCgnutls_bootprop_callbacks_verify): Rename from
3127 Qgnutls_bootprop_..., all uses changed.
3128
3129 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3130 uses changed.
3131
0a0d27fb
PE
31322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3133
19d5c50c
PE
3134 * xfaces.c (Qframe_set_background_mode): Now static.
3135 * dispextern.h (Qframe_set_background_mode): Remove decl.
3136
0a0d27fb
PE
3137 * process.c (Fnetwork_interface_info): Declare local only if needed.
3138
377538cb
JD
31392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3140
3141 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3142 (Fnetwork_interface_list): Allocate in increments of bytes instead
3143 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3144 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3145 sockaddr.
3146 (struct ifflag_def): notrailers is smart on OSX.
3147 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3148 Get hardware address with getifaddrs if available.
3149
08fff70c
EZ
31502011-08-12 Eli Zaretskii <eliz@gnu.org>
3151
3152 * xdisp.c (iterate_out_of_display_property): xassert that
3153 IT->position is set to within IT->object's boundaries. Break from
3154 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3155 when IT->position is set up wrongly due to some bug.
3156 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3157 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3158 entry. Force push_it to save on the stack the current
3159 buffer/string position, to be restored by pop_it. Fix flags in
3160 the iterator structure wrt the object coming from a display
3161 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3162 properties. (Bug#9284)
3163
7be1c708 31642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3165
7be1c708
CY
3166 * fontset.c (fontset_get_font_group): Add proper type checks.
3167 (Bug#9172)
aac0c6e3 3168
7be1c708 31692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3170
7be1c708
CY
3171 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3172 and LC_VERSION_MIN_MACOSX.
3173 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3174 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3175
97bb72a6
EZ
31762011-08-08 Eli Zaretskii <eliz@gnu.org>
3177
3178 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3179 no-display-properties-and-no-overlays under bidi display.
3180 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3181 properties and overlays.
97bb72a6 3182
d5617611
CY
31832011-08-08 Chong Yidong <cyd@stupidchicken.com>
3184
37e11a63
CY
3185 * editfns.c (Fset_time_zone_rule): Document relationship with the
3186 setenv function.
3187
d5617611
CY
3188 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3189 the font entity extracted from the cache (Bug#8109).
3190
58872834
CY
31912011-08-07 Chong Yidong <cyd@stupidchicken.com>
3192
3193 * composite.c (autocmp_chars): Don't reset point. That is done by
3194 restore_point_unwind (Bug#5984).
3195
75bfc667
JL
31962011-08-07 Juri Linkov <juri@jurta.org>
3197
3198 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3199 to show the arg `TIME' instead of `TIMEVAL'.
3200
d1410150
EZ
32012011-08-06 Eli Zaretskii <eliz@gnu.org>
3202
3203 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3204 display property strides EOL and includes a newline, as in
3205 longlines-mode. (Bug#9254)
75b771e4
EZ
3206 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3207 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3208
3209 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3210 is non-zero, even if the data buffer is NULL. Fixes a crash in
3211 vertical-motion with longlines-mode. (Bug#9254)
3212
35928349
EZ
32132011-08-05 Eli Zaretskii <eliz@gnu.org>
3214
ec7cc85b
EZ
3215 * bidi.c <bidi_cache_total_alloc>: Now static.
3216 (bidi_initialize): Initialize bidi_cache_total_alloc.
3217
8b76d6f8 3218 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3219 cache. (Bug#9221)
3220
3221 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3222 amount allocated this far in `bidi_cache_total_alloc'.
3223 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3224 non-zero, only free the data buffer without restoring the cache
3225 contents. All callers changed.
3226
3227 * dispextern.h (bidi_unshelve_cache): Update prototype.
3228
3229 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3230 (move_it_in_display_line, move_it_to)
3231 (move_it_vertically_backward, move_it_by_lines): Replace the call
3232 to xfree to an equivalent call to bidi_unshelve_cache.
3233 (move_it_in_display_line_to): Fix logic of returning
412b6358 3234 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3235
e2e2423b
EZ
32362011-08-05 Eli Zaretskii <eliz@gnu.org>
3237
3238 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3239 came from a string character with a `cursor' property. (Bug#9229)
3240
ae9e757a
JD
32412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3242
3243 * Makefile.in (LIB_PTHREAD): New variable.
3244 (LIBES): Add LIB_PTHREAD (Bug#9216).
3245
3246 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3247 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3248
213bd7f2
AS
32492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3250
6b02f655 3251 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3252
99aaf75f
JD
32532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3254
3255 * xterm.c (x_find_topmost_parent): New function.
3256 (x_set_frame_alpha): Find topmost parent window with
3257 x_find_topmost_parent and set the property there also (bug#9181).
3258 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3259
c74e9d86
PE
32602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * callproc.c (Fcall_process): Avoid vfork clobbering
3263 the local vars buffer, coding_systems, current_dir.
3264
640c8776
SM
32652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3266
3267 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3268
f26d0e4c
PE
32692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3270
8a10d76c
PE
3271 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3272 so that it is not optimized away.
3273
f26d0e4c
PE
3274 * xdisp.c (compute_display_string_pos): Remove unused local.
3275
55439c61
EZ
32762011-08-02 Eli Zaretskii <eliz@gnu.org>
3277
3278 Fix slow cursor motion and scrolling in large buffers with
3279 selective display, like Org Mode buffers. (Bug#9218)
3280
3281 * dispextern.h (struct bidi_it): New member disp_prop_p.
3282
3283 * xdisp.c: Remove one-slot cache of display string positions.
3284 (compute_display_string_pos): Accept an additional argument
5e617bc2 3285 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3286 for a display string or property. If found, set DISP_PROP_P
3287 non-zero.
3288
3289 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3290 DISP_PROP_P, and pass it to compute_display_string_pos.
3291 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3292 non-zero. All callers of bidi_fetch_char changed.
3293
fb33fa43
SM
32942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3295
3296 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3297
b099e063
DM
32982010-12-03 Don March <don@ohspite.net>
3299
3300 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3301 last character M-[char] is translated to ESC [char] (bug#7541).
3302
5cc7f7af
KH
33032011-08-02 Kenichi Handa <handa@m17n.org>
3304
d0fffa3f 3305 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3306
3307 * chartab.c (uniprop_table): Make it non-static.
3308
525d5e6e
EZ
33092011-08-01 Eli Zaretskii <eliz@gnu.org>
3310
3311 * xdisp.c (forward_to_next_line_start): Accept additional argument
3312 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3313 on the newline.
3314 (reseat_at_next_visible_line_start): Use the bidi iterator state
3315 returned by forward_to_next_line_start to restore the state of
3316 it->bidi_it after backing up to previous newline. (Bug#9212)
3317
31011111
AS
33182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3319
3320 * regex.c (re_comp): Protoize.
3321 (re_exec): Fix return type.
3322 (regexec): Fix type of `ret'. (Bug#9203)
3323
476371c4
PE
33242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3325
e5d76069
PE
3326 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3327 This is needed if max-image-size is a floating-point number.
3328
9a79b20c
AS
33292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3330
3331 * print.c (print_object): Print empty symbol as ##.
3332
3333 * lread.c (read1): Read ## as empty symbol.
3334
d8c2fa78
AA
33352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3336
3337 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3338 setting frame foreground color (Bug#9175).
3339 (x_set_background_color): Likewise.
3340
ffe57a7a
AA
3341 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3342 contents (Bug#9176).
3343 (EmacsTooltip -init): Remove bezels and add shadows to
3344 tooltip windows.
3345
bf3492a5
AA
3346 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3347 or scroll bar (Bug#8470).
3348
d55e9c53
AA
3349 * nsfont.m (nsfont_open): Remove assignment to voffset and
3350 unnecessary vars hshink, expand, hd, full_height, min_height.
3351 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3352
3353 * nsterm.h (nsfont_info): Remove voffset field.
3354
d8c2fa78 33552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3356
3357 Implement strike-through and overline on NextStep (Bug#8863).
3358
3359 * nsfont.m (nsfont_open): Use underline position provided by font,
3360 instead of hard-coded value of 2.
3361 (nsfont_draw): Call ns_draw_text_decoration instead.
3362
3363 * nsterm.h: Add declaration for ns_draw_text_decoration.
3364
3365 * nsterm.m (ns_draw_text_decoration): New function for drawing
3366 underline, overline, and strike-through.
3367 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3368 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3369 accommodate underlining, etc.
4843aac3 3370
4cc60b9b
EZ
33712011-07-28 Eli Zaretskii <eliz@gnu.org>
3372
bc7ece87
EZ
3373 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3374 default.
4cc60b9b 3375
476371c4
PE
33762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3377
66606eea
PE
3378 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3379 Without this fix, if a signal arrives just after memory fills up,
3380 'malloc' might be invoked reentrantly.
3381
476371c4
PE
3382 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3383 In other words, assume that every image size is allowed, on non-X
3384 hosts. This assumption is probably wrong, but it lets Emacs compile.
3385
f3fcc40d
AS
33862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3387
3388 * regex.c (re_iswctype): Convert return values to boolean.
3389
350c992f
EZ
33902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3391
3392 * xdisp.c (compute_display_string_pos): Don't use cached display
3393 string position if the buffer had its restriction changed.
3394 (Bug#9184)
3395
5266b4bb
PE
33962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3397
3398 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3399
2573a837 34002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3401
41f55ccd 3402 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3403
39e378da
PE
3404 * bidi.c: Integer size and overflow fixes.
3405 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3406 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3407 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3408 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3409 (bidi_find_other_level_edge):
3410 Use ptrdiff_t instead of EMACS_INT where either will do.
3411 This works better on 32-bit hosts configured --with-wide-int.
3412 (bidi_cache_ensure_space): Check for size-calculation overflow.
3413 Use % rather than repeated addition, for better worst-case speed.
3414 Don't set bidi_cache_size until after xrealloc returns, because it
3415 might not return.
3416 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3417 (bidi_cache_ensure_space): Also check that the bidi cache size
3418 does not exceed that of the largest Lisp string or buffer. See Eli
3419 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3420
5e927815
PE
3421 * alloc.c (__malloc_size_t): Remove.
3422 All uses replaced by size_t. See Andreas Schwab's note
3423 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3424
ca4aa935
PE
3425 * image.c: Improve checking for integer overflow.
3426 (check_image_size): Assume that f is nonnull, since
3427 it is always nonnull in practice. This is one less thing to
3428 worry about when checking for integer overflow later.
3429 (x_check_image_size): New function, which checks for integer
3430 overflow issues inside X.
3431 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3432 This removes the need for a memory_full check.
3433 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3434 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3435 (xbm_read_bitmap_data): Change locals back to 'int', since
3436 their values must fit in 'int'.
3437 (xpm_load_image, png_load, tiff_load):
3438 Invoke x_create_x_image_and_pixmap earlier,
3439 to avoid much needless work if the image is too large.
3440 (tiff_load): Treat overly large images as if
3441 x_create_x_image_and_pixmap failed, not as malloc failures.
3442 (gs_load): Use x_check_image_size.
3443
5f8f9cc2
PE
3444 * gtkutil.c: Omit integer casts.
3445 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3446 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3447
5adf60bc
PE
3448 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3449
c8907a93
PE
3450 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3451 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3452 would wrongly return t on a 64-bit host.
3453
e3c25c68
PE
3454 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3455 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3456 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3457 and therefore cause GCC to emit a bogus diagnostic in some cases.
3458
3f791afe
PE
3459 * image.c: Integer signedness and overflow and related fixes.
3460 This is not an exhaustive set of fixes, but it's time to
3461 record what I've got.
3462 (lookup_pixel_color, check_image_size): Remove redundant decls.
3463 (check_image_size): Don't assume that arbitrary EMACS_INT values
3464 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3465 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3466 (tiff_load, imagemagick_load_image):
3467 Check for overflow in size calculations.
3468 (x_create_x_image_and_pixmap): Remove unnecessary test for
3469 xmalloc returning NULL; that can't happen.
3470 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3471 (xpm_color_bucket): Use better integer hashing function.
3472 (xpm_cache_color): Don't possibly over-allocate memory.
3473 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3474 (gif_memory_source):
3475 Use ptrdiff_t, not int or size_t, to record sizes.
3476 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3477 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3478 either works, as we prefer signed integers.
3479 (tiff_read_from_memory, tiff_write_from_memory):
3480 Return tsize_t, not size_t, since that's what the TIFF API wants.
3481 (tiff_read_from_memory): Don't fail simply because the read would
3482 go past EOF; instead, return a short read.
3483 (tiff_load): Omit no-longer-needed casts.
3484 (Fimagemagick_types): Don't assume size fits into 'int'.
3485
3cc5a532
PE
3486 Improve hashing quality when configured --with-wide-int.
3487 * fns.c (hash_string): New function, taken from sxhash_string.
3488 Do not discard information about ASCII character case; this
3489 discarding is no longer needed.
3490 (sxhash-string): Use it. Change sig to match it. Caller changed.
3491 * lisp.h: Declare it.
3492 * lread.c (hash_string): Remove, since we now use fns.c's version.
3493 The fns.c version returns a wider integer if --with-wide-int is
3494 specified, so this should help the quality of the hashing a bit.
3495
b312a492
PE
3496 * emacs.c: Integer overflow minor fix.
3497 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3498 Define only if GNU_LINUX.
3499 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3500
dfd153ae
PE
3501 * dispnew.c: Integer signedness and overflow fixes.
3502 Remove unnecessary forward decls, that were a maintenance hassle.
3503 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3504 All uses changed.
3505 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3506 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3507 (prepare_desired_row, line_draw_cost):
3508 Use int, not unsigned, where either works.
3509 (save_current_matrix, restore_current_matrix):
3510 Use ptrdiff_t, not size_t, where either works.
3511 (init_display): Check for overflow more accurately, and without
3512 relying on undefined behavior.
3513
a81d11a3
PE
3514 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3515 Remove, replacing with the new symbols in lisp.h. All uses changed.
3516 * fileio.c (make_temp_name):
3517 * filelock.c (lock_file_1, lock_file):
3518 * xdisp.c (message_dolog):
3519 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3520 Use pMd etc. instead.
3521 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3522 replacing the pWIDE etc. symbols removed from editfns.c.
3523
3300e6fd
PE
3524 * keyboard.h (num_input_events): Now uintmax_t.
3525 This is (very slightly) less likely to mess up due to wraparound.
3526 All uses changed.
3527
fd05c7e9
PE
3528 * buffer.c: Integer signedness fixes.
3529 (alloc_buffer_text, enlarge_buffer_text):
3530 Use ptrdiff_t rather than size_t when either will do, as we prefer
3531 signed integers.
3532
903fe15d
PE
3533 * alloc.c: Integer signedness and overflow fixes.
3534 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3535 (__malloc_size_t): Default to size_t, not to int.
3536 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3537 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3538 Prefer ptrdiff_t to size_t when either would do, as we prefer
3539 signed integers.
3540 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3541 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3542 Now const. Initialize with values that are in range even if char
3543 is signed.
3544 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3545 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3546 These functions do the right thing with sizes > 2**32.
3547 (check_depth): Now ptrdiff_t, not int.
3548 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3549 Adjust to new way of storing sizes. Check for size overflow bugs
3550 in rest of code.
3551 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3552 slightly wrong anyway, as it missed one instance of
3553 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3554 (refill_memory_reserve): Omit needless cast to size_t.
3555 (mark_object_loop_halt): Mark as externally visible.
3556
ac82cc6a
PE
3557 * xselect.c: Integer signedness and overflow fixes.
3558 (Fx_register_dnd_atom, x_handle_dnd_message):
3559 Use ptrdiff_t, not size_t, since we prefer signed.
3560 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3561 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3562 x_dnd_atoms_size and x_dnd_atoms_length.
3563
c2d1e36d
PE
3564 * doprnt.c: Prefer signed to unsigned when either works.
3565 * eval.c (verror):
3566 * doprnt.c (doprnt):
3567 * lisp.h (doprnt):
3568 * xdisp.c (vmessage):
3569 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3570 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3571 prefer signed arithmetic to avoid comparison confusion.
3572 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3573 but is a bit tricky.
3574
0e926e56
PE
3575 Assume freestanding C89 headers, string.h, stdlib.h.
3576 * data.c, doprnt.c, floatfns.c, print.c:
3577 Include float.h unconditionally.
3578 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3579 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3580 * regex.c: Likewise for stddef.h, string.h.
3581 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3582 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3583 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3584 (STDC_HEADERS): Remove obsolete defines.
3585 * sysdep.c: Include limits.h unconditionally.
3586
9cfdb3ec
PE
3587 Assume support for memcmp, memcpy, memmove, memset.
3588 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3589 * regex.c (memcmp, memcpy):
3590 Remove; we assume C89 now.
3591
3592 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3593 (__malloc_safe_bcopy): Remove; no longer needed.
3594
cf950e6b 3595 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3596 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3597 well either way, and we prefer signed to unsigned.
3598
dbf38e02
LMI
35992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3600
3601 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3602 closes the connection while we're reading (bug#9182).
3603
d6f0886c 36042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3605
d6f0886c
JD
3606 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3607 are specified (Bug#9168).
24e0f6b1 3608
2eb1f9e6
PE
36092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3612 Found by GCC static checking and --with-wide-int on a 32-bit host.
3613
22381272 36142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3615
3616 * xdisp.c (compute_display_string_pos): Fix logic of caching
3617 previous display string position. Initialize cached_prev_pos to
3618 -1. Fixes slow-down at the beginning of a buffer.
3619
f25e39b4
EZ
36202011-07-24 Eli Zaretskii <eliz@gnu.org>
3621
3622 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3623 for attrs[LFACE_FONTSET_INDEX].
3624
04c4b52e
PE
36252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3626
3627 * xml.c (parse_region): Remove unused local
3628 that was recently introduced.
3629
c1734fbd
EZ
36302011-07-23 Eli Zaretskii <eliz@gnu.org>
3631
be18c5a5
EZ
3632 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3633 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3634
c1734fbd
EZ
3635 * xdisp.c (move_it_in_display_line_to): Record the best matching
3636 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3637 exit if none of the characters scanned was an exact match.
3638 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3639 when exact match is impossible due to invisible text, and the
3640 lines are truncated.
3641
a258d627
JD
36422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3643
3644 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3645 for OSX >= 10.7.
3646
b6d5a689
EZ
36472011-07-22 Eli Zaretskii <eliz@gnu.org>
3648
0f74f785
EZ
3649 Fix a significant slow-down of cursor motion with C-n, C-p,
3650 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3651 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3652 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3653 (next_element_from_buffer): Call compute_stop_pos_backwards to
3654 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3655 base_level_stop.
3656 (reseat): Don't look for prev_stop, as that could mean a very long
3657 run.
3658 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3659 <cached_disp_overlay_modiff>: Cache for last found display string
3660 position.
551918c1 3661 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3662 about the same buffer in the same area of character positions, and
3663 the buffer wasn't changed since the time the display string
3664 position was cached.
551918c1 3665
b2d0c91a
EZ
36662011-07-22 Eli Zaretskii <eliz@gnu.org>
3667
3668 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3669 is an integer, which is important for empty lines. (Bug#9149)
3670
043604ee
CY
36712011-07-22 Chong Yidong <cyd@stupidchicken.com>
3672
3673 * frame.c (Fmodify_frame_parameters): In tty case, update the
3674 default face if necessary (Bug#4238).
3675
da4adb04
CY
36762011-07-21 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * editfns.c (Fstring_to_char): No need to explain what a character
3679 is in the docstring (Bug#6576).
3680
9abd0532
LMI
36812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3682
3683 * xml.c (parse_region): Make sure we always return a tree.
3684
36881d16
HK
36852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3686
3687 * xml.c (parse_region): If a document contains only comments,
3688 return that, too.
3689
1e98674d
LMI
36902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3691
3692 * xml.c (make_dom): Return comments, too.
3693
590bd467
PE
36942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 Port to OpenBSD.
3697 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3698 and the surrounding thread.
3699 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3700 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3701 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3702 timer goes off.
3703 * s/openbsd.h (BROKEN_SIGIO): Define.
3704 * unexelf.c (unexec) [__OpenBSD__]:
3705 Don't update the .mdebug section of the Alpha COFF symbol table.
3706
f41628b2
LMI
37072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3708
3709 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3710 (bug#8460).
3711
b59b67c5
PE
37122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3713
15e3a074
PE
3714 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3715 This fixes some race conditions on the permissions of any newly
3716 created file.
3717
41bed37d
PE
3718 * alloc.c (valid_pointer_p): Use pipe, not open.
3719 This fixes some permissions issues when debugging.
3720
b59b67c5
PE
3721 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3722 If fchown fails to set both uid and gid, try to set just gid,
3723 as that is sometimes allowed. Adjust the file's mode to eliminate
3724 setuid or setgid bits that are inappropriate if fchown fails.
3725
925a6be7
SM
37262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3727
3728 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3729 to compare Lisp_Objects.
3730 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3731 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3732 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3733
52968808
AS
37342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3735
0a6a104b
AS
3736 * lread.c (read_integer): Unread even EOF character.
3737 (read1): Likewise. Properly record start position of symbol.
3738
52968808
AS
3739 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3740 symbol character follows.
3741
9e381cdd
PE
37422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3743
3744 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3745 This works around a problem with the previous change to Fcopy_file.
3746 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3747 and without this change, GCC might complain about discarding
3748 fchown's return value.
3749
b5641435
JB
37502011-07-16 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3753
a8031457
PE
37542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3755
3756 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3757
dd889327
LMI
37582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3759
750c33f7
LMI
3760 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3761 it's used from the C level.
3762
dd889327
LMI
3763 * process.c: Use the same condition for POLL_FOR_INPUT in both
3764 keyboard.c and process.c (bug#1858).
3765
87e86684
LM
37662011-07-09 Lawrence Mitchell <wence@gmx.li>
3767
3768 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3769 (Fgnutls_boot): Use it.
3770
64348f40
AS
37712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3772
3773 * doc.c (Fsubstitute_command_keys): Revert last change.
3774
1d698799
LMI
37752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3776
f863868c
LMI
3777 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3778 quotes the next character, and doesn't affect other longer
3779 sequences (bug#8935).
3780
1d698799
LMI
3781 * lread.c (syms_of_lread): Clarify that is isn't only
3782 `eval-buffer' and `eval-defun' that's affected by
3783 `lexical-binding' (bug#8460).
3784
aa4b6df6
EZ
37852011-07-15 Eli Zaretskii <eliz@gnu.org>
3786
3787 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3788 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3789
5d856da6
PE
37902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3791
ad6042bb
PE
3792 Fix minor problems found by static checking.
3793 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3794 (elsz): Now a signed constant, not a size_t var. We prefer signed
3795 types to unsigned, to avoid integer comparison confusion. Without
3796 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3797 "cannot optimize loop, the loop counter may overflow", a symptom
3798 of the confusion.
f00bbb22 3799 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3800 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3801
6468f31c
LMI
38022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803
49080b10
LMI
3804 * search.c (Fre_search_backward): Mention `case-fold-search' in
3805 all the re_search_* functions (bug#8138).
3806
6468f31c
LMI
3807 * keyboard.c (Fopen_dribble_file): Document when the file is
3808 closed (bug#8056).
3809
c965adc5
EZ
38102011-07-14 Eli Zaretskii <eliz@gnu.org>
3811
df9733bf
EZ
3812 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3813 bidi_cache_idx.
3814
0bb23927
EZ
3815 Support bidi reordering of display and overlay strings.
3816 * xdisp.c (compute_display_string_pos)
3817 (compute_display_string_end): Accept additional argument STRING.
3818 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3819 (reseat_to_string): Initialize bidi_it->string.s and
3820 bidi_it->string.schars.
3821 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3822 NULL (avoids a crash in bidi_paragraph_init).
3823 Initialize itb.string.lstring.
0bb23927
EZ
3824 (init_iterator): Call bidi_init_it only of a valid
3825 buffer position was specified. Initialize paragraph_embedding to
3826 L2R.
3827 (reseat_to_string): Initialize the bidi iterator.
3828 (display_string): If we need to ignore text properties of
3829 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3830 original value of -1 will not work with bidi.)
3831 (compute_display_string_pos): First arg is now struct
3832 `text_pos *'; all callers changed. Support display properties on
3833 Lisp strings.
3834 (compute_display_string_end): Support display properties on Lisp
3835 strings.
3836 (init_iterator, reseat_1, reseat_to_string): Initialize the
3837 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3838 when iterating on a string not from display properties).
640c8776
SM
3839 (compute_display_string_pos, compute_display_string_end):
3840 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3841 arrow keys.
3842 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3843 base_level_stop; instead, set base_level_stop to BEGV.
3844 Fixes crashes in vertical-motion.
0bb23927
EZ
3845 (next_element_from_buffer): Improve commentary for when
3846 the iterator is before prev_stop.
3847 (init_iterator): Initialize bidi_p from the default value of
3848 bidi-display-reordering, not from buffer-local value. Use the
3849 buffer-local value only if initializing for buffer iteration.
3850 (handle_invisible_prop): Support invisible properties on strings
3851 that are being bidi-reordered.
3852 (set_iterator_to_next): Support bidi reordering of C strings and
3853 Lisp strings.
3854 (next_element_from_string): Support bidi reordering of Lisp
3855 strings.
3856 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3857 (display_string): Support display of R2L glyph rows.
3858 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3859 (init_iterator): Don't initialize it->bidi_p for strings
3860 here.
3861 (reseat_to_string): Initialize it->bidi_p for strings here.
3862 (next_element_from_string, next_element_from_c_string)
3863 (next_element_from_buffer): Add xassert's for correspondence
3864 between IT's object being iterated and it->bidi_it.string
3865 structure.
3866 (face_before_or_after_it_pos): Support bidi iteration.
3867 (next_element_from_c_string): Handle the case of the first string
3868 character that is not the first one in the visual order.
3869 (get_visually_first_element): New function, refactored from common
3870 parts of next_element_from_buffer, next_element_from_string, and
3871 next_element_from_c_string.
3872 (tool_bar_lines_needed, redisplay_tool_bar)
3873 (display_menu_bar): Force left-to-right direction. Add a FIXME
3874 comment for making that be controlled by a user option.
3875 (push_it, pop_it): Save and restore the state of the
3876 bidi iterator. Save and restore the bidi_p flag.
3877 (pop_it): Iterate out of display property for string iteration as
3878 well.
3879 (iterate_out_of_display_property): Support iteration over strings.
3880 (handle_single_display_spec): Set up it->bidi_it for iteration
3881 over a display string, and call bidi_init_it.
3882 (handle_single_display_spec, next_overlay_string)
3883 (get_overlay_strings_1, push_display_prop): Set up the bidi
3884 iterator for displaying display or overlay strings.
3885 (forward_to_next_line_start): Don't use the shortcut if
3886 bidi-iterating.
3887 (back_to_previous_visible_line_start): If handle_display_prop
3888 pushed the iterator stack, restore the internal state of the bidi
3889 iterator by calling bidi_pop_it same number of times.
3890 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3891 and we are bidi-iterating, don't decrement the iterator position;
3892 instead, set the first_elt flag in the bidi iterator, to produce
3893 the same effect.
3894 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3895 (push_display_prop): xassert that we are iterating a buffer.
3896 (push_it, pop_it): Save and restore paragraph_embedding member.
3897 (handle_single_display_spec, next_overlay_string)
3898 (get_overlay_strings_1, reseat_1, reseat_to_string)
3899 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3900 correctly. Don't assume unibyte strings are not bidi-reordered.
3901 (compute_display_string_pos)
3902 (compute_display_string_end): Fix handling the case of C string.
3903 (push_it, pop_it): Save and restore from_disp_prop_p.
3904 (handle_single_display_spec, push_display_prop): Set the
3905 from_disp_prop_p flag.
3906 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3907 (pop_it): Call iterate_out_of_display_property only if we are
3908 popping after iteration over a string that came from a display
3909 property. Fix a typo in popping stretch info. Add an assertion
3910 for verifying that the iterator position is in sync with the bidi
3911 iterator.
3912 (handle_single_display_spec, get_overlay_strings_1)
3913 (push_display_prop): Fix initialization of paragraph direction for
3914 string when that of the parent object is not yet determined.
3915 (reseat_1): Call bidi_init_it to resync the bidi
3916 iterator with IT's position. (Bug#7616)
3917 (find_row_edges): If ROW->start.pos gives position
3918 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3919 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3920 Reset the from_disp_prop_p flag.
3921 (SAVE_IT, RESTORE_IT): New macros.
3922 (pos_visible_p, face_before_or_after_it_pos)
3923 (back_to_previous_visible_line_start)
3924 (move_it_in_display_line_to, move_it_in_display_line)
3925 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3926 (try_scrolling, redisplay_window, display_line): Use them when
3927 saving a temporary copy of the iterator and restoring it back.
3928 (back_to_previous_visible_line_start, reseat_1)
3929 (init_iterator): Empty the bidi cache "stack".
3930 (move_it_in_display_line_to): If iterator ended up at
3931 EOL, but we never saw any buffer positions smaller than
3932 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3933 motion in bidi-reordered lines.
3934 (move_it_in_display_line_to): Record prev_method and prev_pos
3935 immediately before the call to set_iterator_to_next. Fixes cursor
3936 motion in bidi-reordered lines with stretch glyphs and strings
3937 displayed in margins. (Bug#8133) (Bug#8867)
3938 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3939 TO_CHARPOS.
640c8776
SM
3940 (pos_visible_p): Support positions in bidi-reordered lines.
3941 Save and restore bidi cache.
0bb23927
EZ
3942
3943 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3944 (bidi_paragraph_info): Delete unused struct.
3945 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3946 (bidi_cache_start): New variable.
3947 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3948 to zero.
3949 (bidi_cache_fetch_state, bidi_cache_search)
3950 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3951 (bidi_cache_find, bidi_peek_at_next_level)
3952 (bidi_level_of_next_char, bidi_find_other_level_edge)
3953 (bidi_move_to_visually_next): Compare cache index with
3954 bidi_cache_start rather than with zero.
3955 (bidi_fetch_char): Accept new argument STRING; all callers
3956 changed. Support iteration over a string. Support strings with
3957 display properties. Support unibyte strings. Fix the type of
3958 `len' according to what STRING_CHAR_AND_LENGTH expects.
3959 (bidi_paragraph_init, bidi_resolve_explicit_1)
3960 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3961 (bidi_level_of_next_char, bidi_move_to_visually_next):
3962 Support iteration over a string.
0bb23927
EZ
3963 (bidi_set_sor_type, bidi_resolve_explicit_1)
3964 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3965 can now be zero (for strings); special values 0 and -1 were
3966 changed to -1 and -2, respectively.
3967 (bidi_char_at_pos): New function.
3968 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3969 Call it instead of FETCH_MULTIBYTE_CHAR.
3970 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3971 initialized to valid values.
3972 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3973 values.
3974 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3975 the test for valid cached positions. Fix the logic for looking up
3976 the sentinel state in the cache. GCPRO the Lisp string we are
3977 iterating.
3978 (bidi_push_it, bidi_pop_it): New functions.
3979 (bidi_initialize): Initialize the bidi cache start stack pointer.
3980 (bidi_cache_ensure_space): New function, refactored from part of
3981 bidi_cache_iterator_state. Don't assume the required size is just
3982 one BIDI_CACHE_CHUNK away.
3983 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3984 (bidi_count_bytes, bidi_char_at_pos): New functions.
3985 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3986 always valid if bidi_cache_idx is valid.
3987 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3988 is valid if it's going to be used.
3989 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3990 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3991 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3992 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3993 (bidi_find_other_level_edge, bidi_cache_start_stack):
3994 All variables related to cache indices are now EMACS_INT.
c965adc5 3995
0bb23927
EZ
3996 * dispextern.h (struct bidi_string_data): New structure.
3997 (struct bidi_it): New member `string'. Make flag members be 1-bit
3998 fields, and put them last in the struct.
640c8776
SM
3999 (compute_display_string_pos, compute_display_string_end):
4000 Update prototypes.
0bb23927
EZ
4001 (bidi_push_it, bidi_pop_it): Add prototypes.
4002 (struct iterator_stack_entry): New members bidi_p,
4003 paragraph_embedding, and from_disp_prop_p.
4004 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4005 (bidi_shelve_cache, bidi_unshelve_cache):
4006 Declare prototypes.
0bb23927
EZ
4007
4008 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4009 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4010 and vector-like objects.
4011
4012 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4013 cache around display iteration.
4014
4015 * window.c (Fwindow_end, window_scroll_pixel_based)
4016 (displayed_window_lines, Frecenter): Save and restore the bidi
4017 cache around display iteration.
4018
3bbd2265
LMI
40192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4020
4021 * editfns.c (Fdelete_region): Clarify the use of the named
4022 parameters (bug#6788).
4023
adc47434
MR
40242011-07-14 Martin Rudalics <rudalics@gmx.at>
4025
4026 * indent.c (Fvertical_motion): Set and restore w->pointm when
4027 saving and restoring the window's buffer (Bug#9006).
4028
837c31f8
LMI
40292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4030
4031 * editfns.c (Fstring_to_char): Clarify just what is returned
4032 (bug#6576). Text by Eli Zaretskii.
4033
ac389d0c
JB
40342011-07-13 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4037
0be0ce47
EZ
40382011-07-13 Eli Zaretskii <eliz@gnu.org>
4039
4040 * buffer.c (mmap_find): Fix a typo.
4041
cd18e7e3
JB
40422011-07-13 Johan Bockgård <bojohan@gnu.org>
4043
4044 Fix execution of x selection hooks.
4045 * xselect.c (Qx_lost_selection_functions)
4046 (Qx_sent_selection_functions): New vars.
4047 (syms_of_xselect): DEFSYM them.
4048 (x_handle_selection_request): Pass Qx_sent_selection_functions
4049 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4050 (x_handle_selection_clear,x_clear_frame_selections):
4051 Pass Qx_lost_selection_functions rather than
4052 Vx_lost_selection_functions to Frun_hook_with_args.
4053
47ea7f44
PE
40542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4055
ac389d0c 4056 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4057 The old code sometimes used this field without initializing it.
4058
47ea7f44
PE
4059 * alloc.c (gc_sweep): Don't read past end of array.
4060 In theory, the old code could also have corrupted Emacs internals,
4061 though it'd be very unlikely.
4062
bc985c87
AS
40632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4064
4065 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4066 argument. (Bug#4026)
bc985c87 4067
0cf34688
LMI
40682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4069
b3dadd76
LMI
4070 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4071 key" (bug#4257).
4072
0cf34688
LMI
4073 * window.c (Fset_window_start): Doc fix (bug#4199).
4074 (Fset_window_hscroll): Ditto.
4075
270768cd
PE
40762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4077
077e3dda 4078 Fix minor new problems caught by GCC 4.6.1.
270768cd 4079 * term.c (init_tty): Remove unused local.
490011a6 4080 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4081 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4082 not used otherwise.
270768cd 4083
b1f58454
CY
40842011-07-12 Chong Yidong <cyd@stupidchicken.com>
4085
4086 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4087
22b9578d
LMI
40882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4089
6e70ab07
LMI
4090 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4091 are the mini-buffer and the echo area (bug#3320).
4092
22b9578d
LMI
4093 * term.c (init_tty): Remove support for supdup, c10 and perq
4094 terminals, which are no longer supported (bug#1482).
4095
8974cc9f
JB
40962011-07-10 Johan Bockgård <bojohan@gnu.org>
4097
4098 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4099
a560d974
JD
41002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4101
4102 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4103 for non-popups (Bug#3642).
4104
1dae0f0a
AS
41052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4106
268c2c36 4107 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4108 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4109 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4110 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4111 * data.c (fmod): Likewise.
4112 * dispnew.c (swap_glyphs_in_rows): Likewise.
4113 * emacs.c (memory_warning_signal): Likewise.
4114 * floatfns.c (float_error): Likewise.
4115 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4116 (otf_open, font_otf_capability, generate_otf_features)
4117 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4118 Likewise.
4119 * image.c (pbm_read_file): Likewise.
4120 * indent.c (string_display_width): Likewise.
4121 * intervals.c (check_for_interval, search_for_interval)
4122 (inc_interval_count, count_intervals, root_interval)
4123 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4124 * lread.c (defalias): Likewise.
268c2c36 4125 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4126 * regex.c (set_image_of_range_1, set_image_of_range)
4127 (regex_grow_registers): Likewise.
4128 * sysdep.c (strerror): Likewise.
4129 * termcap.c (valid_filename_p, tprint, main): Likewise.
4130 * tparam.c (main): Likewise.
4131 * unexhp9k800.c (run_time_remap, save_data_space)
4132 (update_file_ptrs, read_header, write_header, calculate_checksum)
4133 (copy_file, copy_rest, display_header): Likewise.
4134 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4135 Likewise.
4136 * xdisp.c (check_it): Likewise.
4137 * xfaces.c (register_color, unregister_color, unregister_colors):
4138 Likewise.
4139 * xfns.c (print_fontset_result): Likewise.
4140 * xrdb.c (member, fatal, main): Likewise.
4141
99033785
PE
41422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4143
4144 Fix minor problems found by static checking (Bug#9031).
4145 * chartab.c (char_table_set_range, map_sub_char_table):
4146 Remove unused locals.
4147 (uniprop_table): Now static.
4148 * composite.c (_work_char): Remove unused static var.
4149
9cb2ac56
JB
41502011-07-09 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4153
f25661f0
JD
41542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4155
4156 * gtkutil.c (qttip_cb): Remove code without function.
4157
8278c4fe
EZ
41582011-07-09 Eli Zaretskii <eliz@gnu.org>
4159
4160 * w32.c (pthread_sigmask): New stub.
4161
1692ae2d 41622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4163
8a6ebd58 4164 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4165 sigprocmask is portable only for single-threaded applications, and
4166 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4167 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4168 (LIBES): Use it.
4169 * callproc.c (Fcall_process):
4170 * process.c (create_process):
4171 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4172 Use pthread_sigmask, not sigprocmask.
123403e4 4173
1b854618
JD
41742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4175
4176 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4177 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4178 wrong (Bug#8591).
4179
3fe4b549
JD
41802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4181
0ce7e563
JD
4182 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4183 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4184 (xg_hide_tooltip): Fix comment.
4185
3fe4b549
JD
4186 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4187 in registerServicesMenuSendTypes.
4188 (validRequestorForSendType): Don't check ns_return_types.
4189
4190 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4191 ns_return_type.
4192
5df75e47
JR
41932011-07-08 Jason Rumney <jasonr@gnu.org>
4194
22610910
JR
4195 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4196 SH_SHOW for hidden windows (Bug#5482).
4197
5df75e47
JR
4198 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4199 frame struct members of non-existent frames (Bug#6284).
4200
699c10bd
JD
42012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4202
4393663b
JD
4203 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4204 variable firstTime not needed on OSX >= 10.6.
4205 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4206 >= 10.5. Use setKnobProportion, setDoubleValue.
4207
4208 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4209 (MAC_OS_X_VERSION_10_5): Define if not defined.
4210 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4211 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4212 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4213
4214 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4215 cString and lossyCString on OSX >= 10.4
4216
58179cce 4217 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4218 sizeToFit on OSX >= 10.2.
4219
4220 * nsimage.m (allocInitFromFile): Don't use deprecated method
4221 bestRepresentationForDevice on OSX >= 10.6.
4222
4223 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4224 to avoid warning.
4225
4226 * emacs.c: Declare unexec_init_emacs_zone.
4227
a63e0781
JD
4228 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4229
699c10bd
JD
4230 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4231
4232 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4233 on svcsMenu (Bug#8842).
4234
4235 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4236 ns_return_types.
4237 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4238
4239 * nsterm.m (QUTF8_STRING): Declare.
4240 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4241 (validRequestorForSendType): Return type is (id).
4242 Change indexOfObjectIdenticalTo to indexOfObject.
4243 Check if we have local selection before returning self (Bug#8842).
4244 (writeSelectionToPasteboard): Put local selection into paste board
4245 if we have a local selection (Bug#8842).
4246 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4247
4248 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4249 (ns_get_local_selection): Declare.
4250
54e10184
LMI
42512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4252
9888ff71
LMI
4253 * keymap.c (describe_map_tree): Don't insert a double newline at
4254 the end of the buffer (bug#1169) and return whether we inserted
4255 something.
4256
54e10184
LMI
4257 * callint.c (Fcall_interactively): Change "reading args" to
4258 "providing args" to try to clarify what it does (bug#1010).
4259
15fa4783
KH
42602011-07-07 Kenichi Handa <handa@m17n.org>
4261
4262 * composite.c (composition_compute_stop_pos): Ignore a static
4263 composition starting before CHARPOS (Bug#8915).
4264
4265 * xdisp.c (handle_composition_prop): Likewise.
4266
a8815b00
EZ
42672011-07-07 Eli Zaretskii <eliz@gnu.org>
4268
4269 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4270 (Bug#9015)
4271
ef7b981d 42722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4273
4274 * character.h (unicode_category_t): New enum type.
4275
4276 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4277 (Qchar_code_property_table): New variable.
4278 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4279 (UNIPROP_COMPRESSED_FORM_P): New macros.
4280 (char_table_ascii): Uncompress the compressed values.
4281 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4282 Uncompress the compressed values.
ac389d0c 4283 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4284 (char_table_ref_and_range): Uncompress the compressed values.
4285 (sub_char_table_set): New arg is_uniprop. Callers changed.
4286 Uncompress the compressed values.
4287 (sub_char_table_set_range): Args changed. Callers changed.
4288 (char_table_set_range): Adjuted for the above change.
4289 (map_sub_char_table): Delete args default_val and parent. Add arg
4290 top. Give decoded values to a Lisp function.
640c8776 4291 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4292 values to a Lisp function. Gcpro more variables.
4293 (uniprop_table_uncompress)
4294 (uniprop_decode_value_run_length): New functions.
4295 (uniprop_decoder, uniprop_decoder_count): New variables.
4296 (uniprop_get_decoder, uniprop_encode_value_character)
4297 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4298 New functions.
4299 (uniprop_encoder, uniprop_encoder_count): New variables.
4300 (uniprop_get_encoder, uniprop_table)
4301 (Funicode_property_table_internal, Fget_unicode_property_internal)
4302 (Fput_unicode_property_internal): New functions.
4303 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4304 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4305 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4306 char-code-property-alist.
4307
640c8776 4308 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4309 Vunicode_category_table.
4310
640c8776 4311 * font.c (font_range): Adjust for the change of
c805dec0
KH
4312 Vunicode_category_table.
4313
76b397fb
DN
43142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4315
4316 * m/iris4d.h: Remove file, move contents ...
4317 * s/irix6-5.h: ... here.
4318
22b4128e
PE
43192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4320
4321 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4322 * alloc.c (mark_buffer):
4323 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4324 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4325 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4326 This isn't true in general, and it's particularly not true
4327 if Emacs is configured with --with-wide-int.
4328 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4329 New macros, used in the buffer.c change.
4330
869795d6
JD
43312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4332
4333 * xsettings.c: Use both GConf and GSettings if both are available.
4334 (store_config_changed_event): Add comment.
4335 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4336 (store_tool_bar_style_changed): New functions.
5e617bc2 4337 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4338 (struct xsettings): Move font inside HAVE_XFT.
4339 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4340 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4341 Move inside HAVE_XFT.
640c8776 4342 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4343 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4344 also.
4345 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4346 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4347 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4348 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4349 (parse_settings): Move check for font inside HAVE_XFT.
4350 (read_settings, apply_xft_settings): Add comment.
4351 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4352 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4353 call store_font_name_changed.
4354 (xft_settings_event): Add comment.
4355 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4356 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4357 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4358 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4359 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4360 (xsettings_get_system_font, xsettings_get_system_normal_font):
4361 Add comment.
869795d6 4362
d8ed26bd
PE
43632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 Random fixes. E.g., (random) never returned negative values.
4366 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4367 subseconds part to the entropy, as that's a bit more random.
4368 Prefer signed to unsigned, since the signedness doesn't matter and
4369 in general we prefer signed. When given a limit, use a
4370 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4371 latter isn't right if USE_2_TAGS_FOR_INTS.
4372 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4373 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4374
cabf1cac
SM
43752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4376
4377 * textprop.c (text_property_stickiness):
4378 Obey Vtext_property_default_nonsticky.
4379 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4380 * w32fns.c (syms_of_w32fns):
4381 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4382
6e9b2be9
PE
43832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4384
4385 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4386 This is more efficient than Ffile_directory_p and avoids a minor race.
4387
90186c68
LMI
43882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4389
7c301272
LMI
4390 * buffer.c (Foverlay_put): Say what the return value is
4391 (bug#7835).
4392
c4f2d8d4
LMI
4393 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4394 is a directory before asking whether to use the file name
4395 (bug#7564).
ad637907
LMI
4396 (barf_or_query_if_file_exists): Make the "File is a directory"
4397 error be more correct.
c4f2d8d4 4398
90186c68
LMI
4399 * fns.c (Frequire): Remove the mention of the .gz files, since
4400 that's installation-specific, but keep the mention of
4401 `get-load-suffixes'.
4402
da64016e
PE
44032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4406 Report string overflow if the output is too long.
4407
7d47b580
JB
44082011-07-04 Juanma Barranquero <lekktu@gmail.com>
4409
a555cb87
JB
4410 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4411 (syms_of_gnutls): Remove duplicate DEFSYM for
4412 Qgnutls_bootprop_verify_hostname_error, an error for
4413 Qgnutls_bootprop_verify_error (which is no longer used).
4414
7d47b580
JB
4415 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4416 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4417 Also (re)move comments that are misplaced or no longer relevant.
4418
1e49bfab
LMI
44192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4420
4421 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4422
1485f4c0
CY
44232011-07-03 Chong Yidong <cyd@stupidchicken.com>
4424
4425 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4426 and background color parameters if they have been changed.
4427
a9ab721e
LMI
44282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4429
4430 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4431
cf7cff57
PE
44322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4433
2e13213d
PE
4434 * xsettings.c (SYSTEM_FONT): Define only when used.
4435 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4436
cf7cff57
PE
4437 * keymap.c (access_keymap_1): Now static.
4438
7a8e04f7
CY
44392011-07-02 Chong Yidong <cyd@stupidchicken.com>
4440
4441 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4442 leave any prefix arg for the up event (Bug#1586).
4443
61352f62
LMI
44442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4445
69bb1ef7
LMI
4446 * lread.c (syms_of_lread): Mention single symbols defined by
4447 `defvar' or `defconst' (bug#7154).
4448
61352f62 4449 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4450 (Frequire): Mention get-load-suffixes.
61352f62 4451
28545e04
MR
44522011-07-02 Martin Rudalics <rudalics@gmx.at>
4453
4454 * window.h (window): Remove clone_number slot.
4455 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4456 Remove.
4457 (make_parent_window, make_window, saved_window)
4458 (Fset_window_configuration, save_window_save): Don't deal with
4459 clone numbers.
4460 * buffer.c (Qclone_number): Remove declaration.
4461 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4462
3349e122
SM
44632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4464
4465 Add multiple inheritance to keymaps.
4466 * keymap.c (Fmake_composed_keymap): New function.
4467 (Fset_keymap_parent): Simplify.
4468 (fix_submap_inheritance): Remove.
4469 (access_keymap_1): New function extracted from access_keymap to handle
4470 embedded parents and handle lists of maps.
4471 (access_keymap): Use it.
4472 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4473 (Fcopy_keymap): Handle embedded parents.
4474 (Fcommand_remapping, define_as_prefix): Simplify.
4475 (Fkey_binding): Simplify.
4476 (syms_of_keymap): Move minibuffer-local-completion-map,
4477 minibuffer-local-filename-completion-map,
4478 minibuffer-local-must-match-map, and
4479 minibuffer-local-filename-must-match-map to Elisp.
4480 (syms_of_keymap): Defsubr make-composed-keymap.
4481 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4482 (parse_menu_item): Trivial simplification.
4483
3279eb87
GM
44842011-07-01 Glenn Morris <rgm@gnu.org>
4485
4486 * Makefile.in (SETTINGS_LIBS): Fix typo.
4487
4550efdf
KI
44882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4489
4490 * coding.c (Fencode_coding_string): Record the last coding system
4491 used, as the function doc string says (bug#8738).
4492
0949d2b6
JD
44932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4494
4495 * xsettings.c (store_monospaced_changed): Take new font as arg and
4496 check for change against current_mono_font.
4497 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4498 (emacs_settings_constructor, emacs_settings_get_property)
4499 (emacs_settings_set_property, emacs_settings_class_init)
4500 (emacs_settings_init, gsettings_obj): Remove.
4501 (something_changedCB): New function for HAVE_GSETTINGS.
4502 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4503 with value as argument.
4504 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4505 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4506 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4507 "changed".
4508
4509 * xgselect.c: Add defined (HAVE_GSETTINGS).
4510 (xgselect_initialize): Ditto.
4511
4512 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4513 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4514 xg_select.
4515
bbc6b304
PE
45162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4517
4518 * eval.c (struct backtrace): Simplify and port the data structure.
4519 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4520 signed bit field, as this assumption is not portable and it makes
4521 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4522 "char debug_on_exit : 1" as this is not portable either; instead,
4523 use the portable "unsigned int debug_on_exit : 1". Remove unused
4524 member evalargs. Remove obsolete comments about cc bombing out.
4525
9851bfc5
JD
45262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4527
51bb811f 4528 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4529 Let HAVE_GSETTINGS override HAVE_GCONF.
4530 (store_monospaced_changed): New function.
4531 (EMACS_SETTINGS): A new type derived from GObject to handle
4532 GSettings notifications.
4533 (emacs_settings_constructor, emacs_settings_get_property)
4534 (emacs_settings_set_property, emacs_settings_class_init):
4535 New functions.
4536 (gsettings_client, gsettings_obj): New variables.
4537 (GSETTINGS_SCHEMA): New define.
4538 (something_changedCB): Call store_monospaced_changed.
4539 (init_gsettings): New function.
4540 (xsettings_initialize): Call init_gsettings.
4541 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4542 to NULL.
4543
640c8776 4544 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4545 GCONF_CFLAGS/LIBS.
4546
5386012d
MR
45472011-06-29 Martin Rudalics <rudalics@gmx.at>
4548
4549 * window.c (resize_root_window, grow_mini_window)
4550 (shrink_mini_window): Rename Qresize_root_window to
4551 Qwindow_resize_root_window and Qresize_root_window_vertically to
4552 Qwindow_resize_root_window_vertically.
4553
f13e0b08
PE
45542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4555
4556 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4557
94515237
JB
45582011-06-27 Juanma Barranquero <lekktu@gmail.com>
4559
4560 * makefile.w32-in: Redesign dependencies so they reflect more
4561 clearly which files are directly included by each source file,
4562 and not through other includes.
4563
e43b6e43
MR
45642011-06-27 Martin Rudalics <rudalics@gmx.at>
4565
4566 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4567 (sort_overlays, overlay_strings): When an overlay's clone number
4568 matches the window's clone number process the overlay even if
4569 the overlay's window property doesn't match the current window.
4570
d68443dc
MR
4571 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4572 (Fwindow_hchild): Rename to Fwindow_left_child.
4573 (Fwindow_next): Rename to Fwindow_next_sibling.
4574 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4575 (resize_window_check): Rename to window_resize_check.
4576 (resize_window_apply): Rename to window_resize_apply.
4577 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4578 (Fdelete_other_windows_internal, resize_frame_windows)
4579 (Fsplit_window_internal, Fdelete_window_internal)
4580 (grow_mini_window, shrink_mini_window)
4581 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4582
c7e73be5
JD
45832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4584
4585 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4586 (emacs_fixed_set_min_size): Remove.
4587 (emacs_fixed_new): Take frame as argument.
4588
4589 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4590 (_EmacsFixedPrivate): Remove minwidth/height.
4591 Add struct frame *f.
4592 (emacs_fixed_init): Initialize priv->f.
4593 (get_parent_class, emacs_fixed_set_min_size): Remove.
4594 (emacs_fixed_new): Set priv->f to argument.
4595 (emacs_fixed_get_preferred_width)
4596 (emacs_fixed_get_preferred_height): Use min_width/height from
4597 frames size_hint to set minimum and natural (Bug#8919).
4598 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4599 and use min_width/height from frames size_hint to set
4600 min_width/height (Bug#8919).
4601
4602 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4603 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4604 Fix indentation.
c7e73be5 4605
cf99dcf8
EZ
46062011-06-26 Eli Zaretskii <eliz@gnu.org>
4607
4608 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4609 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4610 called at ZV.
4611
029529ac
CY
46122011-06-26 Chong Yidong <cyd@stupidchicken.com>
4613
4614 * process.c (wait_reading_process_output): Bypass select if
4615 waiting for a cell while ignoring keyboard input, and input is
4616 pending. Suggested by Jan Djärv (Bug#8869).
4617
7a7ef429
PE
46182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4619
4620 Use gnulib's dup2 module instead of rolling our own.
4621 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4622
11fdef7d 46232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4624
4625 * dispnew.c (scrolling_window): Before scrolling, turn off a
4626 mouse-highlight in the window being scrolled.
4627
cd3520a4
JB
46282011-06-24 Juanma Barranquero <lekktu@gmail.com>
4629
4630 Move DEFSYM to lisp.h and use everywhere.
4631
4632 * character.h (DEFSYM): Move declaration...
4633 * lisp.h (DEFSYM): ...here.
4634
4635 * gnutls.c:
4636 * minibuf.c:
4637 * w32menu.c:
4638 * w32proc.c:
4639 * w32select.c: Don't include character.h.
4640
4641 * alloc.c (syms_of_alloc):
4642 * buffer.c (syms_of_buffer):
4643 * bytecode.c (syms_of_bytecode):
4644 * callint.c (syms_of_callint):
4645 * casefiddle.c (syms_of_casefiddle):
4646 * casetab.c (init_casetab_once):
4647 * category.c (init_category_once, syms_of_category):
4648 * ccl.c (syms_of_ccl):
4649 * cmds.c (syms_of_cmds):
4650 * composite.c (syms_of_composite):
4651 * dbusbind.c (syms_of_dbusbind):
4652 * dired.c (syms_of_dired):
4653 * dispnew.c (syms_of_display):
4654 * doc.c (syms_of_doc):
4655 * editfns.c (syms_of_editfns):
4656 * emacs.c (syms_of_emacs):
4657 * eval.c (syms_of_eval):
4658 * fileio.c (syms_of_fileio):
4659 * fns.c (syms_of_fns):
4660 * frame.c (syms_of_frame):
4661 * fringe.c (syms_of_fringe):
4662 * insdel.c (syms_of_insdel):
4663 * keymap.c (syms_of_keymap):
4664 * lread.c (init_obarray, syms_of_lread):
4665 * macros.c (syms_of_macros):
4666 * msdos.c (syms_of_msdos):
4667 * print.c (syms_of_print):
4668 * process.c (syms_of_process):
4669 * search.c (syms_of_search):
4670 * sound.c (syms_of_sound):
4671 * syntax.c (init_syntax_once, syms_of_syntax):
4672 * terminal.c (syms_of_terminal):
4673 * textprop.c (syms_of_textprop):
4674 * undo.c (syms_of_undo):
4675 * w32.c (globals_of_w32):
4676 * window.c (syms_of_window):
4677 * xdisp.c (syms_of_xdisp):
4678 * xfaces.c (syms_of_xfaces):
4679 * xfns.c (syms_of_xfns):
4680 * xmenu.c (syms_of_xmenu):
4681 * xsettings.c (syms_of_xsettings):
4682 * xterm.c (syms_of_xterm): Use DEFSYM.
4683
4228cf16
TZ
46842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4685
cd3520a4 4686 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4687
7fcccf1e
PE
46882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4689
7efb4e0e
PE
4690 Integer and buffer overflow fixes (Bug#8873).
4691
ff5844ad
PE
4692 * print.c (printchar, strout): Check for string overflow.
4693 (PRINTPREPARE, printchar, strout):
4694 Don't set size unless allocation succeeds.
4695
90532f02
PE
4696 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4697 for sizes. Check for string overflow more accurately.
4698 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4699
6d84508d
PE
4700 * macros.c: Integer and buffer overflow fixes.
4701 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4702 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4703 Use ptrdiff_t, not int, for sizes.
4704 Don't increment bufsize until after realloc succeeds.
4705 Check for size-calculation overflow.
4706 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4707
437b2cb4
PE
4708 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4709
8b9ac8b4
PE
4710 * lread.c: Integer overflow fixes.
4711 (read_integer): Radix is now EMACS_INT, not int,
4712 to improve quality of diagnostics for out-of-range radices.
4713 Calculate buffer size correctly for out-of-range radices.
4714 (read1): Check for integer overflow in radices, and in
4715 read-circle numbers.
82cb60d3
PE
4716 (read_escape): Avoid int overflow.
4717 (Fload, openp, read_buffer_size, read1)
4718 (substitute_object_recurse, read_vector, read_list, map_obarray):
4719 Use ptrdiff_t, not int, for sizes.
4720 (read1): Use EMACS_INT, not int, for sizes.
20270765 4721 Check for size overflow.
8b9ac8b4 4722
7fcccf1e
PE
4723 * image.c (cache_image): Check for size arithmetic overflow.
4724
bfbbd7e7
PE
4725 * lread.c: Integer overflow issues.
4726 (saved_doc_string_size, saved_doc_string_length)
4727 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4728 Now ptrdiff_t, not int.
4729 (read1): Don't assume doc string length fits in int. Check for
4730 out-of-range doc string lengths.
4731 (read_list): Don't assume file position fits in int.
39019e54 4732 (read_escape): Check for hex character overflow.
bfbbd7e7 4733
4e323265
LL
47342011-06-22 Leo Liu <sdl.web@gmail.com>
4735
4736 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4737 Move to minibuffer.el.
4738
85fece3e
PE
47392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4740
20b84ce9 4741 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4742 The following patches are for when GLYPH_DEBUG && !XASSERT.
4743 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4744 * dispnew.c (flush_stdout):
4745 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4746 Mark as externally visible.
4747 * dispnew.c (check_window_matrix_pointers): Now static.
4748 * dispnew.c (window_to_frame_vpos):
4749 * xfns.c (unwind_create_frame):
4750 * xterm.c (x_check_font): Remove unused local.
4751 * scroll.c (CHECK_BOUNDS):
4752 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4753 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4754 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4755 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4756 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4757 Now static.
4758 (debug_method_add): Use va_list and vsprintf rather than relying
4759 on undefined behavior with wrong number of arguments.
4760 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4761 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4762 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4763 since we're not interested in debugging glyphs with old libraries.
4764 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4765 GCC 4.6.0's static checking.
4766
0766b489
PE
47672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4768
31fd4b32
PE
4769 Integer overflow and signedness fixes (Bug#8873).
4770 A few related buffer overrun fixes, too.
4771
b79e8648
PE
4772 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4773
0766b489
PE
4774 * dispextern.h (struct face.stipple):
4775 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4776 (x_bitmap_mask, x_allocate_bitmap_record)
4777 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4778 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4779 (x_create_bitmap_from_xpm_data):
4780 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4781 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4782 (.bitmaps_last):
4783 * xfaces.c (load_pixmap):
4784 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4785 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4786 (.bitmaps_last, struct x_output.icon_bitmap):
4787 Use ptrdiff_t, not int, for bitmap indexes.
4788 (x_allocate_bitmap_record): Check for size overflow.
4789 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4790
b081724f
PE
4791 Use ptrdiff_t, not int, for overlay counts.
4792 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4793 * editfns.c (overlays_around, get_pos_property):
4794 * textprop.c (get_char_property_and_overlay):
4795 * xdisp.c (next_overlay_change, note_mouse_highlight):
4796 * xfaces.c (face_at_buffer_position):
21514da7
PE
4797 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4798 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4799 (Fnext_overlay_change, Fprevious_overlay_change)
4800 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4801 Use ptrdiff_t, not int, for sizes.
21514da7 4802 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4803
3de73e5e
PE
4804 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4805
2606c57b
PE
4806 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4807 (x_session_initialize): Do not assume string length fits in int.
4808
aaafe47a
PE
4809 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4810 This is unlikely, but can occur if DPI is outlandish.
4811
2674ddc8 4812 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4813 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4814
28154962
PE
4815 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4816 * xrdb.c (magic_file_p, search_magic_path):
4817 Omit last arg SUFFIX; it was always 0. All callers changed.
4818 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4819
7de51af5
PE
4820 * xfont.c (xfont_match): Avoid need for strlen.
4821
25ed6cc3
PE
4822 * xfns.c: Don't assume strlen fits in int.
4823 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4824
4eab31dd
PE
4825 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4826 not unsigned long, as we prefer signed integers. All callers changed.
4827 Detect integer overflow in repeat count.
4828 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4829 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4830
171e2a58
PE
4831 * termcap.c: Don't assume sizes fit in int and never overflow.
4832 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4833 (gobble_line): Check for size-calculation overflow.
4834
ad39faca 4835 * minibuf.c (Fread_buffer):
6e5bb2dc 4836 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4837 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4838 Don't assume string length fits in int.
4839
52c61c22 4840 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4841 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4842
b5b8c9e5
PE
4843 * font.c: Don't assume string length fits in int.
4844 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4845 Use ptrdiff_t, not int.
ccd6111c
PE
4846 (font_intern_prop): Don't assume string length fits in int.
4847 Don't assume integer property fits in fixnum.
4848 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4849
882f0d81 4850 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4851 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4852 Reformulate so as not to need the command string.
4853 Invoke gzip -cd rather than gunzip, as it's more portable.
4854 (lock_info_type, lock_file_1, lock_file):
4855 Don't assume pid_t and time_t fit in unsigned long.
4856 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4857 (current_lock_owner): Prefer signed type for sizes.
4858 Use memcpy, not strncpy, where memcpy is what is really wanted.
4859 Don't assume (via atoi) that time_t and pid_t fit in int.
4860 Check for time_t and/or pid_t out of range, e.g., via a network share.
4861 Don't alloca where an auto var works fine.
4862
93f4cf88
PE
4863 * fileio.c: Fix some integer overflow issues.
4864 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4865 Don't assume string length fits in int.
4866 (directory_file_name): Don't assume string length fits in long.
4867 (make_temp_name): Don't assume pid fits in int, or that its print
4868 length is less than 20.
4869
f3e92b69
PE
4870 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4871
1bfdaf10
PE
4872 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4873
35016e9a
PE
4874 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4875
3d1e65a1
PE
4876 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4877 We prefer signed integers, even for size calculations.
4878
0b963a93
PE
4879 * emacs.c: Don't assume string length fits in 'int'.
4880 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4881 (main): Don't invoke strlen when not needed.
4882
573f4b54
PE
4883 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4884 (XD_DEBUG_MESSAGE): Don't waste a byte.
4885
989f33ba
PE
4886 * callproc.c (getenv_internal_1, getenv_internal)
4887 (Fgetenv_internal):
965d34eb
PE
4888 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4889
e4d29b33
PE
4890 * lread.c (invalid_syntax): Omit length argument.
4891 All uses changed. This doesn't fix a bug, but it simplifies the
4892 code away from its former Hollerith-constant appearance, and it's
4893 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4894 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4895
eb49b136
PE
4896 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4897 This didn't break anything, but it didn't help either.
4898 It's confusing to put a bogus integer in a place where the actual
4899 value does not matter.
9f62aeb1 4900 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4901 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4902
15375a22
PE
4903 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4904 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4905 implementation.
b61cc01c
PE
4906 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4907 We prefer signed types, and the value cannot exceed the EMACS_INT
4908 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4909 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4910 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4911 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4912
53b2623d
PE
4913 * indent.c (sane_tab_width): New function.
4914 (current_column, scan_for_column, Findent_to, position_indentation)
4915 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4916 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4917
51cab52b 4918 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4919
f2ed8a70
PE
4920 * lisp.h (lint_assume): New macro.
4921 * composite.c (composition_gstring_put_cache):
4922 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4923
abe80cc6
PE
4924 * editfns.c, insdel.c:
4925 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4926
b02c740e
PE
4927 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4928
ebc96716
PE
4929 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4930
b4e50fa0 4931 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4932 Use much-faster test for byte-length change.
311d5d7c 4933 Don't assume string byte-length fits in 'int'.
a4cf38e4 4934 Check that character arg fits in 'int'.
85461888 4935 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4936
c0c1ee9f
PE
4937 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4938
a498d7f4
PE
4939 * fns.c (concat): Catch string overflow earlier.
4940 Do not rely on integer wraparound.
4941
51cab52b
PE
4942 * dispextern.h (struct it.overlay_strings_charpos)
4943 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4944 * xdisp.c (forward_to_next_line_start)
4945 (back_to_previous_visible_line_start)
4946 (reseat_at_next_visible_line_start, next_element_from_buffer):
4947 Don't arbitrarily truncate the value of 'selective' to int.
4948
76031fad
PE
4949 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4950
5eb55db9
PE
4951 * composite.c: Don't truncate sizes to 'int'.
4952 (composition_gstring_p, composition_reseat_it)
4953 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4954 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4955 not EMACS_UINT, for indexes.
5eb55db9 4956
0703a717
PE
4957 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4958
d6202519
PE
4959 * buffer.c: Include <verify.h>.
4960 (struct sortvec.priority, struct sortstr.priority):
8961a454 4961 Now EMACS_INT, not int.
c20998a7 4962 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4963 (struct sortstr.size, record_overlay_string)
4964 (struct sortstrlist.size, struct sortlist.used):
4965 Don't truncate size to int.
4966 (record_overlay_string): Check for size-calculation overflow.
d6202519 4967 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4968
d5a19415
JM
49692011-06-22 Jim Meyering <meyering@redhat.com>
4970
029529ac 4971 Don't leak an XBM-image-sized buffer
d5a19415
JM
4972 * image.c (xbm_load): Free the image buffer after using it.
4973
a9041e6c
PE
49742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4975
4976 Port to Sun C.
4977 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4978 that Sun C diagnosed.
4979 * fns.c (secure_hash): Fix pointer signedness issue.
4980 * intervals.c (static_offset_intervals): New function.
4981 (offset_intervals): Use it.
4982
7f3f739f
LL
49832011-06-21 Leo Liu <sdl.web@gmail.com>
4984
4985 * deps.mk (fns.o):
4986 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4987 sha512.h.
4988
4989 * fns.c (secure_hash): Rename from crypto_hash_function and change
4990 the first arg to accept symbols.
5b66d427 4991 (Fsecure_hash): New primitive.
7f3f739f
LL
4992 (syms_of_fns): New symbols.
4993
76147d94
DD
49942011-06-20 Deniz Dogan <deniz@dogan.se>
4995
4996 * process.c (Fset_process_buffer): Clarify return value in
4997 docstring.
4998
7d7d0045
CY
49992011-06-18 Chong Yidong <cyd@stupidchicken.com>
5000
5001 * dispnew.c (add_window_display_history): Use BVAR.
5002
5003 * xdisp.c (debug_method_add): Use BVAR.
5004 (check_window_end, dump_glyph_matrix, dump_glyph)
5005 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5006
5007 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5008 Likewise.
5009
5010 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5011 check till after the cache is created in init_frame_faces.
5012
ff2bc410
SM
50132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5014
5015 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5016
28177add
PE
50172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5018
dd3482fe
PE
5019 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5020 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5021 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5022
393d71f3 5023 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5024 * fileio.c (Finsert_file_contents):
5025 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5026 Remove the old (too-loose) buffer overflow checks.
5027 They weren't needed, since make_gap checks for buffer overflow.
5028 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5029 The old code merely checked for Emacs fixnum overflow, and relied
5030 on undefined (wraparound) behavior. The new code avoids undefined
5031 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5032
2e6813b0 5033 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5034 Tune. Don't use wider integers than needed. Don't use alloca.
5035 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5036
599a9e4f
PE
5037 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5038
99561444
PE
5039 * insdel.c, lisp.h (buffer_overflow): New function.
5040 (insert_from_buffer_1, replace_range, replace_range_2):
5041 * insdel.c (make_gap_larger):
5042 * editfns.c (Finsert_char):
5043 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5044
28177add
PE
5045 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5046
e69dafad
PE
50472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5048
4baa020d 5049 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5050
b1c46f02
PE
5051 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5052 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5053
e69dafad
PE
5054 * fileio.c: Don't assume EMACS_INT fits in off_t.
5055 (emacs_lseek): New static function.
5056 (Finsert_file_contents, Fwrite_region): Use it.
5057 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5058
566684ea
PE
5059 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5060
e6966cd6
PE
5061 * fns.c: Don't overflow int when computing a list length.
5062 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5063 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5064 truncation on 64-bit hosts. Check for QUIT every
5065 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5066 faster and is responsive enough.
5067 (Flength): Report an error instead of overflowing an integer.
5068 (Fsafe_length): Return a float if the value is not representable
5069 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5070 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5071 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5072
dd0b0efb
PE
5073 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5074 (header_size, word_size): New constants.
5075 (allocate_vectorlike): Don't check size overflow here.
5076 (allocate_vector): Check it here instead, since this is the only
5077 caller of allocate_vectorlike that could cause overflow.
5078 Check that the new vector's length is representable as a fixnum.
5079
86fe5cfe
PE
5080 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5081 The previous code was bogus. For example, next_almost_prime (32)
5082 returned 39, which is undesirable as it is a multiple of 3; and
5083 next_almost_prime (24) returned 25, which is a multiple of 5 so
5084 why was the code bothering to check for multiples of 7?
5085
80e88859
PE
5086 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5087
4a2f0ad6
PE
5088 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5089
f66c7cf8
PE
5090 Variadic C functions now count arguments with ptrdiff_t.
5091 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5092 Back then I didn't know that the Emacs coding style prefers signed int.
5093 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5094 were being counted with int, which may truncate counts on 64-bit
5095 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5096 * lisp.h (struct Lisp_Subr.function.aMANY)
5097 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5098 Arg counts are now ptrdiff_t, not size_t.
5099 All variadic functions and their callers changed accordingly.
5100 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5101 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5102 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5103 * callint.c (Fcall_interactively): Check arg count for overflow,
5104 to avoid potential buffer overrun. Use signed char, not 'int',
5105 for 'varies' array, so that we needn't bother to check its size
5106 calculation for overflow.
5107 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5108 * eval.c (apply_lambda):
5109 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5110 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5111 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5112
a1759b76
PE
5113 * callint.c (Fcall_interactively): Don't use index var as event count.
5114
d96be9fc
PE
5115 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5116 * mem-limits.h (SIZE): Remove; no longer used.
5117
a690a978 5118 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5119
578c21e6
PE
5120 Remove unnecessary casts.
5121 * xterm.c (x_term_init):
5122 * xfns.c (x_set_border_pixel):
5123 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5124 These aren't needed now that we assume ANSI C.
5125
96f53c6c
PE
5126 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5127 It's more likely to cause problems (due to unsigned overflow)
5128 than to cure them.
5129
83c77d31
PE
5130 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5131
ee2079f1
PE
5132 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5133
6da65536
PE
5134 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5135
7147c4a4
PE
5136 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5137
193e32d9
PE
5138 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5139
e5533da6
PE
5140 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5141
9910e595
PE
5142 GLYPH_CODE_FACE returns EMACS_INT, not int.
5143 * dispextern.h (merge_faces):
5144 * xfaces.c (merge_faces):
01103c44
PE
5145 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5146 Don't assume EMACS_INT fits in int.
9910e595 5147
2638320e
PE
5148 * character.h (CHAR_VALID_P): Remove unused parameter.
5149 * fontset.c, lisp.h, xdisp.c: All uses changed.
5150
045eb8d9
PE
5151 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5152
c1f134b5
PE
5153 * fns.c (concat): Minor tuning based on overflow analysis.
5154 This doesn't fix any bugs. Use int to hold character, instead
5155 of constantly refetching from Emacs object. Use XFASTINT, not
5156 XINT, for value known to be a character. Don't bother comparing
5157 a single byte to 0400, as it's always less.
5158
395fcb93 5159 * floatfns.c (Fexpt):
327eeec8
PE
5160 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5161
abbd3d23
PE
5162 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5163 for characters.
5164
684a03ef
PE
5165 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5166
0fed43f3
PE
5167 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5168 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5169 incorrectly succeed when S was a string, because 4294967386 was
5170 truncated before it was used.
5171
8fd02eb7
PE
5172 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5173 Otherwise, an out-of-range integer could cause undefined behavior
5174 on a 64-bit host.
5175
f8c86b69
PE
5176 * composite.c: Use int, not EMACS_INT, for characters.
5177 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5178 EMACS_INT, for values that are known to be in character range.
5179 This doesn't fix any bugs but is the usual style inside Emacs and
5180 may generate better code on 32-bit machines.
5181
34206dd2
PE
5182 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5183 This is for reasons similar to the recent CHAR_STRING fix.
5184 * charset.c (Fencode_char): Check that character arg is actually
5185 a character. Pass an int to ENCODE_CHAR.
5186 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5187 wider than 'int', as a compile-time check to prevent future regressions
5188 in this area.
5189
c5958d4c 5190 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5191
5192 Make sure a 64-bit char is never passed to CHAR_STRING.
5193 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5194 by silently ignoring the top 32 bits, allowing some values
5195 that were far too large to be valid characters.
5196 * character.h: Include <verify.h>.
5197 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5198 arguments are no wider than unsigned, as a compile-time check
5199 to prevent future regressions in this area.
5200 * data.c (Faset):
01103c44 5201 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5202 (Fsubst_char_in_region):
5203 * fns.c (concat):
5204 * xdisp.c (decode_mode_spec_coding):
5205 Adjust to CHAR_STRING's new requirement.
5206 * editfns.c (Finsert_char, Fsubst_char_in_region):
5207 * fns.c (concat): Check that character args are actually
5208 characters. Without this test, these functions did the wrong
5209 thing with wildly out-of-range values on 64-bit hosts.
5210
d37ca623
PE
5211 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5212 These casts should not be needed on 32-bit hosts, either.
5213 * keyboard.c (read_char):
5214 * lread.c (Fload): Remove casts to unsigned.
5215
ea204efb
PE
5216 * lisp.h (UNSIGNED_CMP): New macro.
5217 This fixes comparison bugs on 64-bit hosts.
5218 (ASCII_CHAR_P): Use it.
5219 * casefiddle.c (casify_object):
01103c44 5220 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5221 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5222 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5223 * dispextern.h (FACE_FROM_ID):
5224 * keyboard.c (read_char): Use UNSIGNED_CMP.
5225
41cb286c
PE
5226 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5227 not to EMACS_INT, to avoid GCC warning.
5228
4a1b9832
PE
5229 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5230
55daad71
PE
5231 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5232 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5233 isn't needed on 32-bit machines.
8f95c75c 5234
01103c44
PE
5235 * buffer.c (Fgenerate_new_buffer_name):
5236 Use EMACS_INT for count, not int.
0ceccced 5237 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5238
5239 * data.c (Qcompiled_function): Now static.
5240
c6f072e7
PE
5241 * window.c (window_body_lines): Now static.
5242
20ce5912
PE
5243 * image.c (gif_load): Rename local to avoid shadowing.
5244
9c4c5f81
PE
5245 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5246 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5247 * alloc.c (make_save_value): Integer argument is now of type
5248 ptrdiff_t, not int.
5249 (mark_object): Use ptrdiff_t, not int.
5250 * lisp.h (pD): New macro.
5251 * print.c (print_object): Use it.
5252
c0c5c8ae
PE
5253 * alloc.c: Use EMACS_INT, not int, to count objects.
5254 (total_conses, total_markers, total_symbols, total_vector_size)
5255 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5256 (total_free_floats, total_floats, total_free_intervals)
5257 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5258 Now EMACS_INT, not int. All uses changed.
5259 (Fgarbage_collect): Compute overall total using a double, so that
5260 integer overflow is less likely to be a problem. Check for overflow
5261 when converting back to an integer.
5a25e253
PE
5262 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5263 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5264 These were 'int' variables that could overflow on 64-bit hosts;
5265 they were never used, so remove them instead of repairing them.
211a0b2a 5266 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5267 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5268 Previously, this ceilinged at INT_MAX, but that doesn't work on
5269 64-bit machines.
e46bb31a 5270 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5271
c78baabf 5272 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5273 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5274 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5275 when a (possibly-narrower) signed value would do just as well.
5276 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5277
c9d624c6
PE
5278 * alloc.c: Catch some string size overflows that we were missing.
5279 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5280 for convenience in STRING_BYTES_MAX.
5281 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5282 The definition here is exact; the one in lisp.h was approximate.
5283 (allocate_string_data): Check for string overflow. This catches
5284 some instances we weren't catching before. Also, it catches
5285 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5286 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5287 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5288
c9d624c6
PE
5289 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5290 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5291 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5292
353032ce
PE
5293 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5294
2bccce07
PE
5295 * alloc.c (Fmake_string): Check for out-of-range init.
5296
0ac30604
SM
52972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5298
5299 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5300
c195f2de
JD
53012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5302
5303 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5304 xg_get_default_scrollbar_width.
5305
5306 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5307 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5308 (style_changed_cb): Call update_theme_scrollbar_width and call
5309 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5310 all frames (Bug#8505).
5311 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5312 Call gtk_window_set_resizable if HAVE_GTK3.
5313 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5314 and height if HAVE_GTK3 (Bug#8505).
5315 (scroll_bar_width_for_theme): New variable.
5316 (update_theme_scrollbar_width): New function.
5317 (xg_get_default_scrollbar_width): Move code to
5318 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5319 (xg_initialize): Call update_theme_scrollbar_width.
5320
5321 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5322
5323 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5324
e10ac9f1
MR
53252011-06-12 Martin Rudalics <rudalics@gmx.at>
5326
5327 * frame.c (make_frame): Call other_buffer_safely instead of
5328 other_buffer.
5329
5330 * window.c (temp_output_buffer_show): Call display_buffer with
5331 second argument Vtemp_buffer_show_specifiers and reset latter
5332 immediately after the call.
5333 (Vtemp_buffer_show_specifiers): New variable.
5334 (auto_window_vscroll_p, next_screen_context_lines)
5335 (Vscroll_preserve_screen_position): Remove leading asterisks from
5336 doc-strings.
5337
2d3c217e 53382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5339
7b7f97e8 5340 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5341 * buffer.c (Qclone_number): Remove for now, as it's unused.
5342 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5343 (record_buffer): Remove unused local.
5344 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5345 (set_frame_buffer_list): Remove; unused.
5346 * frame.h (other_visible_frames): Remove decl.
5347 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5348 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5349 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5350 if HAVE_GPM.
5351 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5352 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5353 Define only if HAVE_GPM.
5354 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5355 (update_hints_inhibit): Remove; never set. All uses removed.
5356 * widgetprv.h (emacsFrameClassRec): Remove decl.
5357 * window.c (delete_deletable_window): Now returns void, since it
5358 wasn't returning anything.
5359 (compare_window_configurations): Remove unused locals.
5360 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5361 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5362 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5363 the same widths as pointers. This follows up on the 2011-05-06 patch.
5364 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5365 * xterm.h: Likewise.
5366 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5367
1384b89e
JB
53682011-06-12 Juanma Barranquero <lekktu@gmail.com>
5369
5370 * makefile.w32-in: Update dependencies.
5371 (LISP_H): Add lib/intprops.h.
5372
1100a63c
CY
53732011-06-11 Chong Yidong <cyd@stupidchicken.com>
5374
5375 * image.c (gif_load): Add animation frame delay to the metadata.
5376 (syms_of_image): Use DEFSYM. New symbol `delay'.
5377
6198ccd0
MR
53782011-06-11 Martin Rudalics <rudalics@gmx.at>
5379
5380 * window.c (delete_deletable_window): Re-add.
5381 (Fset_window_configuration): Rewrite to handle dead buffers and
5382 consequently deletable windows.
5383 (window_tree, Fwindow_tree): Remove. Supply functionality in
5384 window.el.
5385 (compare_window_configurations): Simplify code.
5386
b6e3633c
AS
53872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5388
1ab0dee5
AS
5389 * image.c (imagemagick_load_image): Fix type mismatch.
5390 (Fimagemagick_types): Likewise.
5391
b6e3633c
AS
5392 * window.h (replace_buffer_in_windows): Declare.
5393
9397e56f
MR
53942011-06-11 Martin Rudalics <rudalics@gmx.at>
5395
5396 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5397 Qclone_number. Remove external declaration of Qdelete_window.
5398 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5399 code.
640c8776
SM
5400 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5401 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5402 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5403 buffer list implementation.
5404 (other_buffer_safely): New function.
5405 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5406 calls to replace_buffer_in_windows and
5407 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5408 if allowed.
5409 (record_buffer): Inhibit quitting and rewrite using quittable
5410 functions. Run Qbuffer_list_update_hook if allowed.
5411 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5412 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5413 Move switch-to-buffer to window.el.
9397e56f
MR
5414 (bury-buffer): Move to window.el.
5415 (Vbuffer_list_update_hook): New variable.
5416
5417 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5418 section.
5419
5420 * window.h (resize_frame_windows): Move up in code.
5421 (Fwindow_frame): Remove EXFUN.
5422 (replace_buffer_in_all_windows): Remove prototype.
5423 (replace_buffer_in_windows_safely): Add prototype.
5424
5425 * window.c: Declare Qdelete_window static again. Move down
5426 declaration of select_count.
5427 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5428 (Fother_window): Move to window.el.
5429 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5430 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5431 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5432 window.el.
5433 (replace_buffer_in_windows): Implement by calling
5434 Qreplace_buffer_in_windows.
5435 (replace_buffer_in_all_windows): Remove with some functionality
5436 moved into replace_buffer_in_windows_safely.
5437 (replace_buffer_in_windows_safely): New function.
5438 (select_window_norecord, select_frame_norecord): Move in front
5439 of run_window_configuration_change_hook. Remove now obsolete
5440 declarations.
640c8776
SM
5441 (Fset_window_buffer): Rewrite doc-string.
5442 Call Qrecord_window_buffer.
9397e56f
MR
5443 (keys_of_window): Move binding for other-window to window.el.
5444
b50691aa
CY
54452011-06-11 Chong Yidong <cyd@stupidchicken.com>
5446
5447 * dispextern.h (struct image): Replace data member, whose int_val
5448 and ptr_val fields were not used by anything, with a single
5449 lisp_val object.
5450
5451 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5452 (gif_clear_image, gif_load, imagemagick_load_image)
5453 (gs_clear_image, gs_load): Callers changed.
5454
3f754b86
PE
54552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5456
cca69397
PE
5457 * buffer.h: Include <time.h>, for time_t.
5458 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5459
109e28d0
PE
5460 Fix minor problems found by static checking.
5461
60737f02
PE
5462 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5463
4b66faf3
PE
5464 Make identifiers static if they are not used in other modules.
5465 * data.c (Qcompiled_function, Qframe, Qvector):
5466 * image.c (QimageMagick, Qsvg):
5467 * minibuf.c (Qmetadata):
5468 * window.c (resize_window_check, resize_root_window): Now static.
5469 * window.h (resize_window_check, resize_root_window): Remove decls.
5470
109e28d0
PE
5471 * window.c (window_deletion_count, delete_deletable_window):
5472 Remove; unused.
46a4ce9e
PE
5473 (window_body_lines): Now static.
5474 (Fdelete_other_windows_internal): Mark vars as initialized.
5475 Make sure 'resize_failed' is initialized.
5476 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5477 (resize_window_apply): Remove unused local.
5478 * window.h (delete_deletable_window): Remove decl.
5479
109e28d0 5480 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5481 (imagemagick_load_image): Fix pointer signedness problem by changing
5482 last arg from unsigned char * to char *. All uses changed.
5483 Also, fix a local for similar reasons.
5484 Remove unused locals. Remove locals to avoid shadowing.
5485 (fn_rsvg_handle_free): Remove; unused.
5486 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5487 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5488
3f754b86
PE
5489 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5490
2547adb1
CY
54912011-06-10 Chong Yidong <cyd@stupidchicken.com>
5492
5493 * image.c (gif_load): Fix omitted cast error introduced by
5494 2011-06-06 change.
5495
2c8e37d4
MR
54962011-06-10 Martin Rudalics <rudalics@gmx.at>
5497
5498 * window.h (resize_proportionally, orig_total_lines)
5499 (orig_top_line): Remove from window structure.
5500 (set_window_height, set_window_width, change_window_heights)
5501 (Fdelete_window): Remove prototypes.
5502 (resize_frame_windows): Remove duplicate declaration.
5503
440a42e3
EZ
55042011-06-10 Eli Zaretskii <eliz@gnu.org>
5505
5506 * window.h (resize_frame_windows, resize_window_check)
5507 (delete_deletable_window, resize_root_window)
5508 (resize_frame_windows): Declare prototypes.
5509
5510 * window.c (resize_window_apply): Make definition be "static" to
5511 match the prototype.
5512
562dd5e9
MR
55132011-06-10 Martin Rudalics <rudalics@gmx.at>
5514
5515 * window.c: Remove declarations of Qwindow_size_fixed,
5516 window_min_size_1, window_min_size_2, window_min_size,
5517 size_window, window_fixed_size_p, enlarge_window, delete_window.
5518 Remove static from declaration of Qdelete_window, it's
5519 temporarily needed by Fbury_buffer.
5520 (replace_window): Don't assign orig_top_line and
5521 orig_total_lines.
5522 (Fdelete_window, delete_window): Remove. Window deletion is
5523 handled by window.el.
640c8776
SM
5524 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5525 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5526 (Fdelete_other_windows): Remove. Deleting other windows is
5527 handled by window.el.
5528 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5529 handled in window.el.
5530 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5531 Window minimum sizes are handled in window.el.
5532 (shrink_windows, size_window, set_window_height)
5533 (set_window_width, change_window_heights, window_height)
5534 (window_width, CURBEG, CURSIZE, enlarge_window)
5535 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5536 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5537 handled in window.el.
5538 (make_dummy_parent): Rename to make_parent_window and give it a
5539 second argument horflag.
5540 (make_window): Don't set resize_proportionally any more.
5541 (Fsplit_window): Remove. Windows are split in window.el.
5542 (save_restore_action, save_restore_orig_size)
5543 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5544 Resize mini windows in window.el.
5545 (grow_mini_window, shrink_mini_window): Implement by calling
5546 Qresize_root_window_vertically, resize_window_check and
5547 resize_window_apply.
640c8776
SM
5548 (saved_window, Fset_window_configuration, save_window_save):
5549 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5550 resize_proportionally.
5551 (window_min_height, window_min_width): Move to window.el.
5552 (keys_of_window): Move bindings for delete-other-windows,
5553 split-window, delete-window and enlarge-window to window.el.
5554
5555 * buffer.c: Temporarily extern Qdelete_window.
5556 (Fbury_buffer): Temporarily call Qdelete_window instead of
5557 Fdelete_window (Fbury_buffer will move to window.el soon).
5558
5559 * frame.c (set_menu_bar_lines_1): Remove code handling
5560 orig_top_line and orig_total_lines.
5561
5562 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5563 set_window_height but set heights directly.
5564 (change_frame_size_1): Use resize_frame_windows.
5565
5566 * xdisp.c (init_xdisp): Don't use set_window_height but set
5567 heights directly.
5568
640c8776
SM
5569 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5570 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5571 run_window_configuration_change_hook.
5572
5573 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5574 instead of change_window_heights and run
5575 run_window_configuration_change_hook.
5576
1a13852e
MR
55772011-06-09 Martin Rudalics <rudalics@gmx.at>
5578
5579 * window.c (replace_window): Rename second argument REPLACEMENT to
5580 NEW. New third argument SETFLAG. Rewrite.
5581 (delete_window, make_dummy_parent): Call replace_window with
5582 third argument 1.
5583 (window_list_1): Move down in code.
5584 (run_window_configuration_change_hook): Move set_buffer part
5585 before select_frame_norecord part in order to unwind correctly.
5586 Rename count1 to count.
5587 (recombine_windows, delete_deletable_window, resize_root_window)
5588 (Fdelete_other_windows_internal)
5589 (Frun_window_configuration_change_hook, make_parent_window)
5590 (resize_window_check, resize_window_apply, Fresize_window_apply)
5591 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5592 (Fdelete_window_internal, Fresize_mini_window_internal):
5593 New functions.
1a13852e
MR
5594 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5595
f3d1777e
MR
55962011-06-08 Martin Rudalics <rudalics@gmx.at>
5597
496e208e
MR
5598 * window.h (window): Add some new members to window structure -
5599 normal_lines, normal_cols, new_total, new_normal, clone_number,
5600 splits, nest, prev_buffers, next_buffers.
5601 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5602 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5603
f3d1777e
MR
5604 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5605 Remove.
496e208e
MR
5606 (make_dummy_parent): Set new members of windows structure.
5607 (make_window): Move down in code. Handle new members of window
5608 structure.
5609 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5610 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5611 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5612 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5613 (Fset_window_next_buffers, Fset_window_clone_number):
5614 New functions.
496e208e
MR
5615 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5616 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5617 Doc-string fixes.
5618 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5619 Argument WINDOW can be now internal window too.
5620 (Fwindow_use_time): Move up in code.
5621 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5622 Rewrite doc-string.
5623 (Fset_window_configuration, saved_window)
5624 (Fcurrent_window_configuration, save_window_save): Handle new
5625 members of window structure.
b9e809c2
MR
5626 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5627 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5628 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5629 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5630 Qget_mru_window, Qresize_root_window,
5631 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5632 Qauto_buffer_name; staticpro them.
f3d1777e 5633
abde8f8c
MR
56342011-06-07 Martin Rudalics <rudalics@gmx.at>
5635
5636 * window.c (Fwindow_total_size, Fwindow_left_column)
5637 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5638 (Fwindow_list_1): New functions.
5639 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5640 (Fwindow_width, Fscroll_left, Fscroll_right):
5641 Use window_body_cols instead of window_box_text_cols.
5642 (delete_window, Fset_window_configuration):
5643 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5644 (delete_all_subwindows): Take a window as argument and not a
5645 structure. Rewrite.
190b47e6
MR
5646 (window_loop): Remove handling of GET_LRU_WINDOW and
5647 GET_LARGEST_WINDOW.
5648 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5649
5650 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5651 window_box_text_cols. delete_all_subwindows now takes a
5652 Lisp_Object as argument.
abde8f8c 5653
640c8776
SM
5654 * indent.c (compute_motion, Fcompute_motion):
5655 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5656
fa8a67e6
MR
5657 * frame.c (delete_frame): Call delete_all_subwindows with root
5658 window as argument.
5659
a54e3482
DC
56602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5661
5662 * fns.c (Fputhash): Document return value.
5663
60002bf5
CY
56642011-06-06 Chong Yidong <cyd@stupidchicken.com>
5665
5666 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5667
0c671da6 56682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5669
b862a52a 5670 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5671
be44ca6c
PE
5672 Check for overflow when converting integer to cons and back.
5673 * charset.c (Fdefine_charset_internal, Fdecode_char):
5674 Use cons_to_unsigned to catch overflow.
5675 (Fencode_char): Use INTEGER_TO_CONS.
5676 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5677 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5678 * data.c (long_to_cons, cons_to_long): Remove.
5679 (cons_to_unsigned, cons_to_signed): New functions.
5680 These signal an error for invalid or out-of-range values.
5681 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5682 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5683 * font.c (Ffont_variation_glyphs):
5684 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5685 * lisp.h: Include <intprops.h>.
5686 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5687 (cons_to_signed, cons_to_unsigned): New decls.
5688 (long_to_cons, cons_to_long): Remove decls.
5689 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5690 (Fprimitive_undo): Use CONS_TO_INTEGER.
5691 * xfns.c (Fx_window_property): Likewise.
5692 * xselect.c: Include <limits.h>.
5693 (x_own_selection, selection_data_to_lisp_data):
5694 Use INTEGER_TO_CONS.
5695 (x_handle_selection_request, x_handle_selection_clear)
5696 (x_get_foreign_selection, Fx_disown_selection_internal)
5697 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5698 (lisp_data_to_selection_data): Use cons_to_unsigned.
5699 (x_fill_property_data): Use cons_to_signed.
5700 Report values out of range.
5701
d1f3d2af
PE
5702 Check for buffer and string overflow more precisely.
5703 * buffer.h (BUF_BYTES_MAX): New macro.
5704 * lisp.h (STRING_BYTES_MAX): New macro.
5705 * alloc.c (Fmake_string):
5706 * character.c (string_escape_byte8):
5707 * coding.c (coding_alloc_by_realloc):
5708 * doprnt.c (doprnt):
5709 * editfns.c (Fformat):
5710 * eval.c (verror):
5711 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5712 since they may not be the same number.
5713 * editfns.c (Finsert_char):
5714 * fileio.c (Finsert_file_contents):
5715 Likewise for BUF_BYTES_MAX.
5716
dd52fcea
PE
5717 * image.c: Use ptrdiff_t, not int, for sizes.
5718 (slurp_file): Switch from int to ptrdiff_t.
5719 All uses changed.
5720 (slurp_file): Check that file size fits in both size_t (for
5721 malloc) and ptrdiff_t (for sanity and safety).
5722
7f9bbdbb
PE
5723 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5724 if b->modtime has its maximal value.
5725
dfe18f82
PE
5726 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5727
84acfcf0
PE
5728 Don't assume time_t can fit into int.
5729 * buffer.h (struct buffer.modtime): Now time_t, not int.
5730 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5731 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5732
ccd9a01a
PE
5733 Minor fixes for signed vs unsigned integers.
5734 * character.h (MAYBE_UNIFY_CHAR):
5735 * charset.c (maybe_unify_char):
5736 * keyboard.c (read_char, reorder_modifiers):
5737 XINT -> XFASTINT, since the integer must be nonnegative.
5738 * ftfont.c (ftfont_spec_pattern):
5739 * keymap.c (access_keymap, silly_event_symbol_error):
5740 XUINT -> XFASTINT, since the integer must be nonnegative.
5741 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5742 since it makes no difference and we prefer signed.
5743 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5744 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5745 nonnegative.
5746
d6d100dd
SM
57472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5748
5749 * window.h (Fwindow_frame): Declare.
5750
2b6148e4
PE
57512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5754 (SPARE_MEMORY): Always define.
5755 (LARGE_REQUEST): Remove.
5756 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5757
f230ecc9
MR
57582011-06-06 Martin Rudalics <rudalics@gmx.at>
5759
727e958e
MR
5760 * lisp.h: Move EXFUNS for Fframe_root_window,
5761 Fframe_first_window and Fset_frame_selected_window to window.h.
5762
5763 * window.h: Move EXFUNS for Fframe_root_window,
5764 Fframe_first_window and Fset_frame_selected_window here from
5765 lisp.h.
5766
5767 * frame.c (Fwindow_frame, Fframe_first_window)
5768 (Fframe_root_window, Fframe_selected_window)
5769 (Fset_frame_selected_window): Move to window.c.
5770 (Factive_minibuffer_window): Move to minibuf.c.
5771 (Fother_visible_frames_p): New function.
5772
5773 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5774
f230ecc9
MR
5775 * window.c (decode_window, decode_any_window): Move up in code.
5776 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5777 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5778 (Fwindow_buffer): Move up and rewrite doc-string.
5779 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5780 (Fwindow_prev): New functions.
727e958e
MR
5781 (Fwindow_frame): Move here from frame.c. Accept any window as
5782 argument.
5783 (Fframe_root_window, Fframe_first_window)
5784 (Fframe_selected_window): Move here from frame.c. Accept frame
5785 or arbitrary window as argument. Update doc-strings.
5786 (Fminibuffer_window): Move up in code.
5787 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5788 (Fset_frame_selected_window): Move here from frame.c.
5789 Marginal rewrite.
727e958e
MR
5790 (Fselected_window, select_window, Fselect_window): Move up in
5791 code. Minor doc-string fixes.
f230ecc9 5792
4d09bcf6
PE
57932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5794
5795 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5796 Do not assume that spare memory exists; that assumption is valid
5797 only if SYSTEM_MALLOC.
5798 (LARGE_REQUEST): New macro, so that the issue of large requests
5799 is separated from the issue of spare memory.
5800
810928a2
AS
58012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5802
172418ad
AS
5803 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5804 format. (Bug#8806)
5805
43f862f7
AS
5806 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5807
810928a2
AS
5808 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5809 before statements.
5810
a059fe24
JD
58112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5812
5813 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5814
5815 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5816
5817 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5818 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5819
989bf368
JB
58202011-06-05 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5823
4b80f674
CY
58242011-06-04 Chong Yidong <cyd@stupidchicken.com>
5825
5826 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5827 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5828 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5829 New error handlers.
4b80f674
CY
5830 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5831 Obey Vx_select_enable_clipboard_manager. Catch errors in
5832 x_clipboard_manager_save (Bug#8779).
5833 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5834 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5835
99a33b77 58362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5837
5838 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5839
99a33b77 58402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5841
5842 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5843 in the current matrix if keep_current_p is non-zero.
5844
8264569d
EZ
58452011-06-04 Eli Zaretskii <eliz@gnu.org>
5846
5847 * bidi.c (bidi_level_of_next_char): Fix last change.
5848
57f97249
EZ
58492011-06-03 Eli Zaretskii <eliz@gnu.org>
5850
fec2107c 5851 Support bidi reordering of text covered by display properties.
57f97249 5852
fec2107c
EZ
5853 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5854 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5855 (bidi_cache_search, bidi_cache_iterator_state)
5856 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5857 (bidi_level_of_next_char, bidi_move_to_visually_next):
5858 Support character positions inside a run of characters covered by a
fec2107c
EZ
5859 display string.
5860 (bidi_paragraph_init, bidi_resolve_explicit_1)
5861 (bidi_level_of_next_char): Call bidi_fetch_char and
5862 bidi_fetch_char_advance instead of FETCH_CHAR and
5863 FETCH_CHAR_ADVANCE.
5864 (bidi_init_it): Initialize new members.
5865 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5866 definitions.
5867 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5868 instead of using explicit *_CHAR codes.
d6d100dd
SM
5869 (bidi_resolve_explicit, bidi_resolve_weak):
5870 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5871 bidirectional text is supported only in multibyte buffers.
5872 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5873 it to initialize the frame_window_p member of struct bidi_it.
5874 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5875 (bidi_resolve_explicit, bidi_resolve_weak)
5876 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5877 bidi_it->nchars is non-positive.
5878 (bidi_level_of_next_char): Don't try to lookup the cache for the
5879 next/previous character if nothing is cached there yet, or if we
5880 were just reseat()'ed to a new position.
c40e2fb2 5881
0e14fe90
EZ
5882 * xdisp.c (set_cursor_from_row): Set start and stop points
5883 according to the row's direction when priming the loop that looks
5884 for the glyph on which to display cursor.
5885 (single_display_spec_intangible_p): Function deleted.
5886 (display_prop_intangible_p): Reimplement to call
5887 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5888 Accept 3 additional arguments needed by handle_display_spec.
5889 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5890 values: lists, `(when COND...)' forms, etc.
5891 (single_display_spec_string_p): Support property values that are
5892 lists with the argument STRING its top-level element.
5893 (display_prop_string_p): Fix the condition for processing a
5894 property that is a list to be consistent with handle_display_spec.
fec2107c 5895 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5896 last portion of handle_display_prop.
5897 (compute_display_string_pos): Accept additional argument
5898 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5899 value of a `display' property is a "replacing spec".
5900 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5901 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5902 the display property, but just return a value indicating whether
5903 the display property will replace the characters it covers.
5904 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5905 frame_window_p members of struct bidi_it.
d6d100dd
SM
5906 (compute_display_string_pos, compute_display_string_end):
5907 New functions.
fec2107c
EZ
5908 (push_it): Accept second argument POSITION, where pop_it should
5909 jump to continue iteration.
5910 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5911
fec2107c
EZ
5912 * keyboard.c (adjust_point_for_property): Adjust the call to
5913 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5914
5915 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5916 (bidi_init_it): Update prototypes.
5917 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5918 (compute_display_string_pos, compute_display_string_end):
5919 Declare prototypes.
fec2107c
EZ
5920 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5921 EMACS_INT.
fc6f18ce 5922
40087514 59232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5924
57f53182
PE
5925 Malloc failure behavior now depends on size of allocation.
5926 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5927 * lisp.h: Change signatures accordingly.
5928 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5929 All callers changed. (Bug#8762)
5930
5931 * gnutls.c: Use Emacs's memory allocators.
5932 Without this change, the gnutls library would invoke malloc etc.
5933 directly, which causes problems on non-SYNC_INPUT hosts, and which
5934 runs afoul of improving memory_full behavior. (Bug#8761)
5935 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5936 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5937 xfree instead of the default malloc, realloc, free.
5938 (Fgnutls_boot): No need to check for memory allocation failure,
5939 since xmalloc does that for us.
5940
ac32cd99 5941 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5942 * category.c (hash_get_category_set):
5943 * ccl.c (ccl_driver):
5944 * charset.c (Fdefine_charset_internal):
5945 * charset.h (struct charset.hash_index):
5946 * composite.c (get_composition_id, gstring_lookup_cache)
5947 (composition_gstring_put_cache):
5948 * composite.h (struct composition.hash_index):
5949 * dispextern.h (struct image.hash):
5950 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5951 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5952 (hashfn_equal, hashfn_user_defined, make_hash_table)
5953 (maybe_resize_hash_table, hash_lookup, hash_put)
5954 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5955 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5956 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5957 * image.c (make_image, search_image_cache, lookup_image)
5958 (xpm_put_color_table_h):
5959 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5960 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5961 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5962 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5963 * alloc.c (allocate_vectorlike):
5964 Check for overflow in vector size calculations.
5965 * ccl.c (ccl_driver):
5966 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5967 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5968 need to be updated by these changes.
40087514
PE
5969 * fns.c (make_hash_table, maybe_resize_hash_table):
5970 Check for integer overflow with large hash tables.
0de4bb68
PE
5971 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5972 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5973 (SXHASH_REDUCE): New macro.
5974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5975 Use it instead of discarding useful hash info with large hash values.
5976 (sxhash_float): New function.
5977 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5978 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5979 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5980 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5981 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5982 Adjust signatures to match updated version of code.
5983 (consing_since_gc): Now EMACS_INT, since a single hash table can
5984 use more than INT_MAX bytes.
5985
698d32e2
DN
59862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5987
5988 Make it possible to build with GCC-4.6+ -O2 -flto.
5989
5990 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5991
fd6fa53f
SM
59922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5993
5994 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5995 Call minibuffer-inactive-mode.
5996
864db017
JB
59972011-05-31 Juanma Barranquero <lekktu@gmail.com>
5998
5999 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6000 Update dependencies.
6001
2ad0baf4
DN
60022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6003
6004 * data.c (init_data): Remove code for UTS, this system is not
6005 supported anymore.
6006
4fcc2638
DN
60072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6008
6009 Don't force ./temacs to start in terminal mode.
6010
6011 * frame.c (make_initial_frame): Initialize faces in all cases, not
6012 only when CANNOT_DUMP is defined.
6013 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6014
c56e0fd5
DN
60152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6016
6017 * dispnew.c (add_window_display_history): Use const for the string
6018 pointer. Remove declaration, not needed.
6019
333d54da 60202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6021
55d4c1b2 6022 Use 'inline', not 'INLINE'.
333d54da 6023 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6024 * alloc.c, fontset.c (INLINE): Remove.
6025 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6026 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6027 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6028 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6029 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6030
738db178
DN
60312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6032
6033 Make it possible to run ./temacs.
6034
6035 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6036 syms_of_callproc does the same thing. Remove test for
6037 "initialized", do it in the caller.
6038 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6039
620c53a6
SM
60402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6041
6042 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6043 (read_minibuf): Use get_minibuffer.
6044 (syms_of_minibuf): Use DEFSYM.
6045 (Qmetadata): New var.
6046 * data.c (Qbuffer): Don't make it static.
6047 (syms_of_data): Use DEFSYM.
6048
e003a292
PE
60492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6052 (CCL_CODE_MIN): New macro.
6053
ed008a6d
PE
60542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6055
3687c2ef
PE
6056 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6057
ed008a6d
PE
6058 * eval.c (Qdebug): Now static.
6059 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6060 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6061 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6062
d66c4c7c
CY
60632011-05-29 Chong Yidong <cyd@stupidchicken.com>
6064
6065 * image.c: Various fixes to ImageMagick code comments.
6066 (Fimagemagick_types): Doc fix.
6067
5fbc2025
PE
60682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6069
0196f88a
PE
6070 Minor fixes prompted by GCC 4.6.0 warnings.
6071
6072 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6073
5fbc2025
PE
6074 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6075 (x_clipboard_manager_save_all): Move extern decl to ...
6076 * xterm.h: ... here, so that it can be checked for consistency.
6077
1dd3c2d9
CY
60782011-05-29 Chong Yidong <cyd@stupidchicken.com>
6079
6080 * xselect.c (x_clipboard_manager_save_frame)
6081 (x_clipboard_manager_save_all): New functions.
6082 (Fx_clipboard_manager_save): Lisp function deleted.
6083
6084 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6085 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6086
6087 * xterm.h: Update prototype.
6088
5ba6571d
WX
60892011-05-28 William Xu <william.xwl@gmail.com>
6090
6091 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6092 exiting (Bug#8239).
6093
3eaff834
JM
60942011-05-28 Jim Meyering <meyering@redhat.com>
6095
e1900994 6096 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6097 * fns.c (to_uchar): Define.
6098 (crypto_hash_function): Use it to convert some newly-signed
6099 variables to unsigned, to avoid sign-extension bugs. For example,
6100 without this change, (md5 "truc") would evaluate to
6101 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6102 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6103 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6104
0f6990a7
PE
61052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6106
6107 Integer overflow fixes.
c8a9ca5a 6108
08686060
PE
6109 * dbusbind.c: Serial number integer overflow fixes.
6110 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6111 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6112 to hold a serial number that is too large for a fixnum.
6113 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6114 Check for serial numbers out of range. Decode any serial number
59568bf0 6115 that was so large that it became a float. (Bug#8722)
08686060 6116
2d1fc3c7
PE
6117 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6118 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6119 Use XFASTINT rather than XUINT when numbers are nonnegative.
6120 (xd_append_arg, Fdbus_method_return_internal):
6121 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6122 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6123 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6124 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6125 (Bug#8722)
2d1fc3c7 6126
c8a9ca5a
PE
6127 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6128
519e1d69
PE
6129 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6130
6df6ae42 6131 ccl: Add integer overflow checks.
30569699
PE
6132 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6133 (IN_INT_RANGE): New macros.
6134 (ccl_driver): Use them to check for integer overflow when
6135 decoding a CCL program. Many of the new checks are whether XINT (x)
6136 fits in int; it doesn't always, on 64-bit hosts. The new version
6137 doesn't catch all possible integer overflows, but it's an
847044ea 6138 improvement. (Bug#8719)
30569699 6139
c11285dc
PE
6140 * alloc.c (make_event_array): Use XINT, not XUINT.
6141 There's no need for unsigned here.
6142
fdccd48e
PE
6143 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6144 This follows up to the 2011-05-06 change that substituted uintptr_t
6145 for EMACS_INT. This case wasn't caught back then.
6146
37910ab2
PE
6147 Rework Fformat to avoid integer overflow issues.
6148 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6149 now (part of C89). Include <verify.h>.
6150 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6151 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6152 (Fformat): Avoid the prepass trying to compute sizes; it was only
6153 approximate and thus did not catch overflow reliably. Instead, walk
6154 through the format just once, formatting and computing sizes as we go,
6155 checking for integer overflow at every step, and allocating a larger
6156 buffer as needed. Keep track separately whether the format is
6157 multibyte. Keep only the most-recently calculated precision, rather
6158 than them all. Record whether each argument has been converted to
6159 string. Use EMACS_INT, not int, for byte and char and arg counts.
6160 Support field widths and precisions larger than INT_MAX. Avoid
6161 sprintf's undefined behavior with conversion specifications such as %#d
6162 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6163 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6164 formatting out-of-range floating point numbers with int
9173deec 6165 formats. (Bug#8668)
37910ab2 6166
2e6578fb
PE
6167 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6168
0ae6bdee
PE
6169 * data.c: Avoid integer truncation in expressions involving floats.
6170 * data.c: Include <intprops.h>.
6171 (arith_driver): When there's an integer overflow in an expression
6172 involving floating point, convert the integers to floating point
6173 so that the resulting value does not suffer from catastrophic
6174 integer truncation. For example, on a 64-bit host (* 4
6175 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6176 Do not rely on undefined behavior after integer overflow.
6177
de883a70
PE
6178 merge count_size_as_multibyte, parse_str_to_multibyte
6179 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6180 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6181 Check for integer overflow.
6182 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6183 since it's now a duplicate of the other. This is more of
6184 a character than a buffer op, so better that it's in character.c.
6185 * fns.c, print.c: Adjust to above changes.
6186
2ff916cb
PE
61872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6188
6189 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6190
f1b54466
PE
61912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6192
fb1ac845
PE
6193 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6194 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6195 (x_clipboard_manager_save): Now static.
6196 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6197
f1b54466
PE
6198 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6199 (crypto_hash_function): Now static.
6200 Fix pointer signedness problems. Avoid unnecessary initializations.
6201
a9f737ee
CY
62022011-05-27 Chong Yidong <cyd@stupidchicken.com>
6203
6204 * termhooks.h (Vselection_alist): Make it terminal-local.
6205
6206 * terminal.c (create_terminal): Initialize it.
6207
6208 * xselect.c: Support for clipboard managers.
6209 (Vselection_alist): Move to termhooks.h as terminal-local var.
6210 (LOCAL_SELECTION): New macro.
6211 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6212 (symbol_to_x_atom): Remove gratuitous arg.
6213 (x_handle_selection_request, lisp_data_to_selection_data)
6214 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6215 (x_own_selection, x_get_local_selection, x_convert_selection):
6216 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6217 (some_frame_on_display): Delete unused function.
6218 (Fx_own_selection_internal, Fx_get_selection_internal)
6219 (Fx_disown_selection_internal, Fx_selection_owner_p)
6220 (Fx_selection_exists_p): New optional frame arg.
6221 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6222 (x_handle_selection_clear): Don't treat other terminals with the
6223 same keyboard specially. Use the terminal-local Vselection_alist.
6224 (x_clear_frame_selections): Use Frun_hook_with_args.
6225
6226 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6227
6228 * xterm.h: Add support for those atoms.
6229
e067f0c1
CY
62302011-05-26 Chong Yidong <cyd@stupidchicken.com>
6231
6232 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6233 (converted_selections, conversion_fail_tag): New global variables.
6234 (x_selection_request_lisp_error): Free the above.
6235 (x_get_local_selection): Remove unnecessary code.
6236 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6237 of converted selections stored in converted_selections.
6238 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6239 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6240 (x_convert_selection): New function.
6241 (x_handle_selection_event): Simplify.
6242 (x_get_foreign_selection): Don't ignore incoming requests while
6243 waiting for an answer; this will fail when we implement
6244 SAVE_TARGETS, and seems unnecessary anyway.
6245 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6246 (Vx_sent_selection_functions): Doc fix.
6247
0f4aebc0
LL
62482011-05-26 Leo Liu <sdl.web@gmail.com>
6249
6250 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6251
e61124cd
YM
62522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6253
6254 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6255
6256 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6257 for fringe update if it has periodic bitmap.
ac389d0c 6258 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6259 and fringe_bitmap_periodic_p.
6260
6261 * fringe.c (get_fringe_bitmap_data): New function.
6262 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6263 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6264 row. Mark glyph row for fringe update if periodicity changed.
6265
6266 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6267 for fringe update unless it has periodic bitmap.
6268
f16d9837
KH
62692011-05-25 Kenichi Handa <handa@m17n.org>
6270
6271 * xdisp.c (get_next_display_element): Set correct it->face_id for
6272 a static composition.
6273
e1b90ef6
LL
62742011-05-24 Leo Liu <sdl.web@gmail.com>
6275
6276 * deps.mk (fns.o):
6277 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6278
6279 * fns.c (crypto_hash_function, Fsha1): New function.
6280 (Fmd5): Use crypto_hash_function.
6281 (syms_of_fns): Add Ssha1.
6282
7400048f
PE
62832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6284
6285 * gnutls.c: Remove unused macros.
6286 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6287 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6288 Remove macros that are defined and never used.
6289 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6290
abb71cf4
CY
62912011-05-22 Chong Yidong <cyd@stupidchicken.com>
6292
6293 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6294 (Fx_get_selection_internal): Minor cleanup.
6295 (Fx_own_selection_internal): Rename arguments for consistency with
6296 select.el.
6297
6307db39
PE
62982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6299
6300 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6301
f3d4e0a4
CY
63022011-05-22 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6305
4d8ade89
YM
63062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6307
6308 * dispnew.c (scrolling_window): Don't exclude the case that the
6309 last enabled row in the desired matrix touches the bottom boundary.
6310
32078c8d
GM
63112011-05-21 Glenn Morris <rgm@gnu.org>
6312
6313 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6314 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6315 and add some more files.
32078c8d 6316
7285dc67
EZ
63172011-05-20 Eli Zaretskii <eliz@gnu.org>
6318
6319 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6320 report_file_error introduced by the change from 2011-05-07.
6321
89d1bd22
PE
63222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6323
6324 * systime.h (Time): Define only if emacs is defined.
6325 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6326 where the include path doesn't have X11/X.h by default. See
6327 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6328
cd394be1 63292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6330
6331 * composite.c (find_automatic_composition): Fix previous change.
6332
b9704ad9
GM
63332011-05-20 Glenn Morris <rgm@gnu.org>
6334
6335 * lisp.mk: New file, split from Makefile.in.
6336 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6337 (shortlisp): Remove.
6338 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6339
4a720484
GM
63402011-05-19 Glenn Morris <rgm@gnu.org>
6341
6342 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6343 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6344 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6345 (lisp): Set the order to that of loadup.el.
6346 (shortlisp): Make it a copy of $lisp.
6347 (SOME_MACHINE_LISP): Remove.
6348 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6349 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6350
a28d4396
KH
63512011-05-18 Kenichi Handa <handa@m17n.org>
6352
6353 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6354 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6355 (find_automatic_composition): Mostly rewrite for efficiency.
6356
a2b1fa8e
JB
63572011-05-18 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * makefile.w32-in: Update dependencies.
6360
8e1f5610
CS
63612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6362
6363 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6364 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6365
7025ee00 63662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6367
cdfa6eab
PE
6368 Fix some integer overflow issues, such as string length overflow.
6369
06d6db33
PE
6370 * insdel.c (count_size_as_multibyte): Check for string overflow.
6371
2b4560a8
PE
6372 * character.c (lisp_string_width): Check for string overflow.
6373 Use EMACS_INT, not int, for string indexes and lengths; in
6374 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6375 the resulting string length overflows an EMACS_INT; instead,
6376 report a string overflow if no precision given. When checking for
6377 precision exhaustion, use a check that cannot possibly have
6378 integer overflow. (Bug#8675)
6379 * character.h (lisp_string_width): Adjust to new signature.
6380
cb93f9be
PE
6381 * alloc.c (string_overflow): New function.
6382 (Fmake_string): Use it. This doesn't change behavior, but saves
6383 a few bytes and will simplify future changes.
6384 * character.c (string_escape_byte8): Likewise.
6385 * lisp.h (string_overflow): New decl.
6386
1a1f3366
PE
6387 Fixups, following up to the user-interface timestamp change.
6388 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6389 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6390 * msdos.c (mouse_get_pos): Likewise.
6391 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6392 * w32gui.h (Time): Define by including "systime.h" rather than by
6393 declaring it ourselves. (Bug#8664)
6394
d4e3e4d3
PE
6395 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6396 * image.c (clear_image_cache): Likewise.
6397
f6a24d19
PE
6398 * term.c (term_mouse_position): Don't assume time_t wraparound.
6399
08dc5ae6
PE
6400 Be more systematic about user-interface timestamps.
6401 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6402 and sometimes 'EMACS_UINT', to represent these timestamps.
6403 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6404 This makes the code easier to follow, and makes it easier to catch
6405 integer overflow bugs such as Bug#8664.
6406 * frame.c (Fmouse_position, Fmouse_pixel_position):
6407 Use Time, not unsigned long, for user-interface timestamps.
6408 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6409 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6410 * keyboard.h (last_event_timestamp): Likewise.
6411 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6412 * menu.h (xmenu_show): Likewise.
6413 * term.c (term_mouse_position): Likewise.
6414 * termhooks.h (struct input_event.timestamp): Likewise.
6415 (struct terminal.mouse_position_hook): Likewise.
6416 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6417 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6418 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6419 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6420 what it was before.
6421 * menu.h, termhooks.h: Include "systime.h", for Time.
6422
8e55734a
PE
6423 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6424 Don't assume that the difference between two unsigned long values
6425 can fit into an integer. At this point, we know button_down_time
6426 <= event->timestamp, so the difference must be nonnegative, so
6427 there's no need to cast the result if double-click-time is
6428 nonnegative, as it should be; check that it's nonnegative, just in
6429 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6430 apart (about 25 days). (Bug#8664)
8e55734a 6431
841f1b75 6432 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6433 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6434
3e26f69c
PE
6435 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6436 that always fit in int. Use a sentinel instead of a counter, to
6437 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6438 * frame.h (struct frame): Use int for menu_bar_items_used
6439 instead of EMACS_INT, since it always fits in int.
3e26f69c 6440
5cc152c0
PE
6441 * menu.c (grow_menu_items): Check for int overflow.
6442
d89eb65e
PE
6443 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6444
5235bd3e
PE
6445 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6446 Before, the code was not consistent. These values cannot exceed
6447 2**31 - 1 so there's no need to make them unsigned.
6448 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6449 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6450 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6451 as modifiers.
6452 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6453
bc827e23
PE
6454 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6455 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6456 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6457 presumably because the widths might not match.
6458
78eb494e
PE
6459 * window.c (size_window): Avoid needless test at loop start.
6460
04f2d78b
CB
64612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6462
6463 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6464
d2fc7e3d 64652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6466
6467 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6468
d2fc7e3d 64692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6470
6471 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6472 `width' to `bar_area_x' and `bar_area_width', respectively.
6473 (x_scroll_run): Take account of fringe background extension.
6474
04f2d78b
CB
6475 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6476 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6477 `bar_area_width', respectively.
6478 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6479 background extension.
6480
79b70037
GM
64812011-05-10 Jim Meyering <meyering@redhat.com>
6482
6483 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6484
2f142cc5
JB
64852011-05-10 Juanma Barranquero <lekktu@gmail.com>
6486
6487 * image.c (Finit_image_library): Return t for built-in image types,
6488 like pbm and xbm. (Bug#8640)
6489
57679c86
AS
64902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6491
6492 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6493
888c9e86
EZ
64942011-05-07 Eli Zaretskii <eliz@gnu.org>
6495
b0512a1d
EZ
6496 * w32console.c (Fset_screen_color): Doc fix.
6497 (Fget_screen_color): New function.
6498 (syms_of_ntterm): Defsubr it.
6499
7285dc67
EZ
6500 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6501 unlink the temporary file if Fcall_process didn't create it in the
6502 first place.
6503 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6504 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6505 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6506 cue to call_process_cleanup not to close that handle.
6507
4d3fcc8e
BK
65082011-05-07 Ben Key <bkey76@gmail.com>
6509
6510 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6511 one of two shell specific rules, either bootstrap-temacs-CMD or
6512 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6513 to the previous implementation of the bootstrap-temacs rule.
6514 The bootstrap-temacs-CMD rule is similar to the previous
6515 implementation of the bootstrap-temacs rule except that it
6516 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6517 variable.
6518
6519 These changes, along with some changes to nt/configure.bat,
6520 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6521 earlier fix to add support for --cflags and --ldflags options
6522 that include quotes so that it works whether make uses cmd or
6523 sh as the shell.
6524
b4289b64
MA
65252011-05-06 Michael Albinus <michael.albinus@gmx.de>
6526
6527 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6528 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6529 is a constant.
6530 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6531 a string. Handle both cases.
6532 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6533 (Fdbus_register_method): Use Qinvalid_function.
6534
af4c0e28
JB
65352011-05-06 Juanma Barranquero <lekktu@gmail.com>
6536
6537 * makefile.w32-in: Update dependencies.
6538 (LISP_H): Add inttypes.h and stdin.h.
6539 (PROCESS_H): Add unistd.h.
6540
c51453d9
EZ
65412011-05-06 Eli Zaretskii <eliz@gnu.org>
6542
6543 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6544 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6545
8ff0ac3c 65462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6547
4c4b566b
PE
6548 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6549
aab2b9b5
PE
6550 * term.c (vfatal): Remove stray call to va_end.
6551 It's not needed and the C Standard doesn't allow it here anyway.
6552
c378da0b
PE
6553 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6554 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6555
288b08c7
PE
6556 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6557 bytes.
6558
e3601888
PE
6559 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6560
db6c0e74
PE
6561 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6562
dd5963ea
PE
6563 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6564
88c9450f
PE
6565 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6566
2f9442b8
PE
6567 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6568
c032b5f8
PE
6569 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6570 * charset.c (Fdefine_charset_internal): Don't initialize
6571 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6572 32-bit int (Bug#8600).
a108c10b
PE
6573
6574 * lread.c (read_integer): Be more consistent with string-to-number.
6575 Use string_to_number to do the actual conversion; this avoids
6576 rounding errors and fixes some other screwups. Without this fix,
6577 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6578 (digit_to_number): Move earlier, for benefit of read_integer.
6579 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6580 not a digit in any supported base. (Bug#8602)
a108c10b 6581
ad5f9eea
PE
6582 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6583
aec1708a
PE
6584 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6585 to match comment at start of function. This also removes a
6586 GCC warning about overflow in a 32+64-bit port.
6587
47be4ab5
PE
6588 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6589
371cac43
PE
6590 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6591 Reported by Stefan Monnier in
6592 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6593 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6594 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6595
d01a7826
PE
6596 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6597 (EMACS_UINTPTR): Likewise, with uintptr_t.
6598
7fd47d5c
PE
6599 * lisp.h: Prefer 64-bit EMACS_INT if available.
6600 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6601 on 32-bit hosts that have 64-bit int, so that they can access
6602 large files.
122b0c86
PE
6603 However, temporarily disable this change unless the temporary
6604 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6605
8727937b
PE
6606 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6607
8ac068ac
PE
6608 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6609 This removes an assumption that EMACS_INT and long are the same
6610 width as pointers. The assumption is true for Emacs porting targets
6611 now, but we want to make other targets possible.
6612 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6613 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6614 In the rest of the code, change types of integers that hold casted
6615 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6616 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6617 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6618 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6619 No need to cast type when ORing.
6620 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6621 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6622 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6623 assume EMACS_INT is the same width as char *.
6624 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6625 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6626 Remove no-longer-needed casts.
6627 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6628 (xg_tool_bar_help_callback, xg_make_tool_item):
6629 Use EMACS_INTPTR to hold an integer
6630 that will be cast to void *; this can avoid a GCC warning
6631 if EMACS_INT is not the same width as void *.
6632 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6633 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6634 (current_message_1, set_message_1):
6635 Use a local to convert to proper width without a cast.
6636 * xmenu.c (dialog_selection_callback): Likewise.
6637
ede49d71
PE
6638 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6639 Also, don't assume VALBITS / RAND_BITS is less than 5,
6640 and don't rely on undefined behavior when shifting a 1 left into
6641 the sign bit.
6642 * lisp.h (get_random): Change signature to match.
6643
2f30ecd0
PE
6644 * lread.c (hash_string): Use size_t, not int, for hash computation.
6645 Normally we prefer signed values; but hashing is special, because
6646 it's better to use unsigned division on hash table sizes so that
6647 the remainder is nonnegative. Also, size_t is the natural width
6648 for hashing into memory. The previous code used 'int', which doesn't
6649 retain enough info to hash well into very large tables.
6650 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6651
2a866e7b
PE
6652 * dbusbind.c: Don't possibly lose pointer info when converting.
6653 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6654 Use XPNTR rather than XHASH, so that the high-order bits of
6655 the pointer aren't lost when converting through void *.
6656
51639eac
PE
6657 * eval.c (Fautoload): Don't double-shift a pointer.
6658
92394119
PE
6659 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6660
dbdb9a7c
JB
66612011-05-06 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * gnutls.c (DEF_GNUTLS_FN):
6664 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6665
db7a0b4f
AS
66662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6667
6668 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6669 marker. (Bug#8610)
6670
cd394be1 66712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6672
6673 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6674 New version that can reserve upto 2GB of heap space.
6675
f7ff1b0f 66762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6677
6678 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6679
639c109b
TZ
66802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6681
6682 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6683 `gnutls_certificate_set_x509_key_file'.
6684
d2127135
JB
66852011-05-05 Juanma Barranquero <lekktu@gmail.com>
6686
6687 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6688 Update dependencies.
6689
e968f4f3
JB
66902011-05-04 Juanma Barranquero <lekktu@gmail.com>
6691
6692 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6693 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6694 Remove unused parameter `fildes'.
6695 * process.c (read_process_output, send_process): Don't pass it.
6696
84d358f0
JB
66972011-05-04 Juanma Barranquero <lekktu@gmail.com>
6698
6699 Fix previous change: the library cache is defined in w32.c.
6700 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6701 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6702
0898ca10
JB
67032011-05-04 Juanma Barranquero <lekktu@gmail.com>
6704
6705 Implement dynamic loading of GnuTLS on Windows.
6706
6707 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6708 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6709 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6710 Declare.
6711
6712 * gnutls.c (Qgnutls_dll): Define.
6713 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6714 (gnutls_*): Declare function pointers.
6715 (init_gnutls_functions): New function to initialize function pointers.
6716 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6717 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6718 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6719 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6720 (emacs_gnutls_write, emacs_gnutls_read)
6721 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6722 (Fgnutls_available_p): New function.
6723 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6724 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6725 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6726
6727 * image.c: Include w32.h.
6728 (Vimage_type_cache): Delete.
6729 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6730 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6731 (w32_delayed_load): Move to w32.c.
6732
6733 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6734
6735 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6736 (w32_delayed_load): Move from image.c. When loading a library, record
6737 its filename in the :loaded-from property of the library id.
6738 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6739 Initialize and staticpro them.
6740 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6741
6742 * process.c: Include lisp.h before w32.h, not after.
6743 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6744 instead of gnutls_record_check_pending.
6745
6746 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6747
ff4de4aa
TZ
67482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6749
6750 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6751 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6752 as passed in.
6753
abe95abb
JD
67542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6755
6756 * xterm.c (x_set_frame_alpha): Do not set property on anything
6757 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6758
e16e55d4
JB
67592011-05-02 Juanma Barranquero <lekktu@gmail.com>
6760
6761 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6762
bafcf6a5
JB
67632011-05-02 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6766 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6767 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6768 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6769 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6770 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6771 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6772 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6773 (Qgnutls_bootprop_callbacks_verify): Make static.
6774
e7a6747f
AS
67752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6776
19ed11ba
AS
6777 * callproc.c: Indentation fixup.
6778
e7a6747f 6779 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6780 (wait_for_termination, interruptible_wait_for_termination):
6781 Move after wait_for_termination_1.
e7a6747f 6782
1ef14cb4
LMI
67832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6784
6785 * sysdep.c (interruptible_wait_for_termination): New function
6786 which is like wait_for_termination, but allows keyboard
6787 interruptions.
6788
6789 * callproc.c (Fcall_process): Add (:file "file") as an option for
6790 the STDOUT buffer.
6791 (Fcall_process_region): Ditto.
6792
330d880c
EZ
67932011-04-30 Eli Zaretskii <eliz@gnu.org>
6794
8db90b73
EZ
6795 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6796 rather than `XVECTOR (FOO)->size'.
6797
330d880c
EZ
6798 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6799 inttypes.h, as a gnulib replacement is used if it not available in
6800 system headers.
6801
15cbd324
EZ
68022011-04-21 Eli Zaretskii <eliz@gnu.org>
6803
6804 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6805 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6806 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6807
6808 * coding.c (coding_alloc_by_realloc): Error out if destination
6809 will grow beyond MOST_POSITIVE_FIXNUM.
6810 (decode_coding_emacs_mule): Abort if there isn't enough place in
6811 charbuf for the composition carryover bytes. Reserve an extra
6812 space for up to 2 characters produced in a loop.
6813 (decode_coding_iso_2022): Abort if there isn't enough place in
6814 charbuf for the composition carryover bytes.
6815
68162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6817
ae940cca
EZ
6818 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6819 aborting when %lld or %lll format is passed.
6820 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6821 %llo or %llx format is passed. (Bug#8545)
6822
03ab8921
EZ
6823 * window.c (window_scroll_line_based): Use a marker instead of
6824 simple variables to record original value of point. (Bug#7952)
6825
afda1437
EZ
6826 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6827 produced by %s or %c overflows available buffer space. (Bug#8545)
6828
f76dee0c
PE
68292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6830
6831 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6832 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6833
fdc5744d
JB
68342011-04-28 Juanma Barranquero <lekktu@gmail.com>
6835
6836 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6837
638f053a
JB
68382011-04-28 Juanma Barranquero <lekktu@gmail.com>
6839
6840 * keyboard.c (Qdelayed_warnings_hook): Define.
6841 (command_loop_1): Run `delayed-warnings-hook'
6842 if Vdelayed_warnings_list is non-nil.
6843 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6844 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6845
d178f871
EZ
68462011-04-28 Eli Zaretskii <eliz@gnu.org>
6847
6848 * doprnt.c (doprnt): Don't return value smaller than the buffer
6849 size if the message was truncated. (Bug#8545).
6850
b124fd93
JB
68512011-04-28 Juanma Barranquero <lekktu@gmail.com>
6852
6853 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6854 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6855
e810457d
PE
68562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6857
6858 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6859
ea51cceb
JB
68602011-04-27 Juanma Barranquero <lekktu@gmail.com>
6861
6862 * makefile.w32-in: Update dependencies.
6863
94dcfacf
EZ
68642011-04-27 Eli Zaretskii <eliz@gnu.org>
6865
6866 Improve `doprnt' and its usage. (Bug#8545)
6867 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6868 `format_end'. Remove support for %l as a conversion specifier.
6869 Don't use xrealloc. Improve diagnostics when the %l size modifier
6870 is used. Update the commentary.
6871
6872 * eval.c (verror): Simplify calculation of size_t.
6873
6874 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6875 messages.
6876
f61f41d7
PE
68772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6878
6879 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6880 change.
6881
96fb4434
PE
68822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6883
6884 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6885 This makes this file independent of the recent pseudovector change.
6886
671875da 68872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6888
69e9b5a3
PE
6889 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6890
b5f869a7 6891 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6892 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6893 Remove unused local.
c8926152 6894 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6895
841a1577 6896 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6897 GCC 4.6.0 optimizes based on type-based alias analysis.
6898 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6899 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6900 != &v->size, and therefore "v->size = 1; b->size = 2; return
6901 v->size;" must therefore return 1. This assumption is incorrect
6902 for Emacs, since it type-puns struct Lisp_Vector * with many other
6903 types. To fix this problem, this patch adds a new type struct
f904488f 6904 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6905 and pseudovectors, and helps optimizing compilers not get fooled
6906 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6907 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6908 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6909 the size member.
eab3844f
PE
6910 (XSETPVECTYPE): Rewrite in terms of new macro.
6911 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6912 This is a bit clearer, and further avoids the possibility of
6913 undesirable aliasing.
6914 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6915 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6916 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6917 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6918 (ASIZE): Now uses header.size rather than size.
6919 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6920 to avoid the hassle of writing XVECTOR (foo)->header.size.
6921 (struct vectorlike_header): New type.
eab3844f
PE
6922 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6923 object, to help avoid aliasing.
6924 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6925 (SUBRP): Likewise, since Lisp_Subr is a special case.
6926 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6927 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6928 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6929 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6930 changed to be "header.size" and "header.next".
6931 * buffer.h (struct buffer): Likewise.
6932 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6933 * frame.h (struct frame): Likewise.
6934 * process.h (struct Lisp_Process): Likewise.
6935 * termhooks.h (struct terminal): Likewise.
6936 * window.c (struct save_window_data, struct saved_window): Likewise.
6937 * window.h (struct window): Likewise.
6938 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6939 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6940 * buffer.c (init_buffer_once): Likewise.
6941 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6942 special case.
6943 * process.c (Fformat_network_address): Use local var for size,
6944 for brevity.
6945
0df1eac5
PE
6946 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6947
847ab9d1 6948 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6949 * data.c (atof): Remove decl; no longer used or needed.
6950 (digit_to_number): Move to lread.c.
6951 (Fstring_to_number): Use new string_to_number function, to be
6952 consistent with how the Lisp reader treats infinities and NaNs.
6953 Do not assume that floating-point numbers represent EMACS_INT
6954 without losing information; this is not true on most 64-bit hosts.
6955 Avoid double-rounding errors, by insisting on integers when
6956 parsing non-base-10 numbers, as the documentation specifies.
6957 * lisp.h (string_to_number): New decl, replacing ...
6958 (isfloat_string): Remove.
bc0a5c13 6959 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6960 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6961 appears to have been a coding error. Similarly, do not accept
6962 strings like +-1e0 as floating point numbers. Do not report
6963 overflow for integer overflows unless the base is not 10 which
6964 means we have no simple and reliable way to continue.
6965 Break out the floating-point parsing into a new
6966 function string_to_number, so that Fstring_to_number parses
6967 floating point numbers consistently with the Lisp reader.
04f2d78b 6968 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6969 (E_CHAR, EXP_INT): Remove, replacing with ...
6970 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6971 (string_to_number): New function, replacing isfloat_string.
6972 This function checks for valid syntax and produces the resulting
6973 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6974 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6975 so that overflow for non-base-10 numbers is reported only when
6976 there's no portable and simple way to convert to floating point.
452f4150 6977
67769ffc
PE
6978 * textprop.c (set_text_properties_1): Rewrite for clarity,
6979 and to avoid GCC warning about integer overflow.
6980
c20db43f
PE
6981 * intervals.h (struct interval): Use EMACS_INT for members
6982 where EMACS_UINT might cause problems. See
6983 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6984 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6985 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6986 All uses changed.
37aa2f85
PE
6987 (offset_intervals): Tell GCC not to worry about length overflow
6988 when negating a negative length.
c20db43f 6989
2538aa2f
PE
6990 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6991 (overrun_check_free): Likewise.
6992
f2d3008d
PE
6993 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6994 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6995 word size.
6996
ec8df744
PE
6997 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6998 (gnutls_make_error): Rename local to avoid shadowing.
6999 (gnutls_emacs_global_deinit): ifdef out; not used.
7000 (Fgnutls_boot): Use const for pointer to readonly storage.
7001 Comment out unused local. Fix pointer signedness problems.
7002
640ee02d
PE
7003 * lread.c (openp): Don't stuff size_t into an 'int'.
7004 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7005 about possible signed overflow.
7006
6048fb2a
PE
7007 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7008 (GDK_KEY_g): Don't define if already defined.
7009 (xg_prepare_tooltip): Avoid pointer signedness problem.
7010 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7011
fa3c87e1
PE
7012 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7013 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7014
2172544b
PE
7015 * xfns.c (Fx_window_property): Simplify a bit,
7016 to make a bit faster and to avoid GCC 4.6.0 warning.
7017 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7018
9b821a21
PE
7019 * fns.c (internal_equal): Don't assume size_t fits in int.
7020
3c616cfa
PE
7021 * alloc.c (compact_small_strings): Tighten assertion a little.
7022
c2982e87
PE
7023 Replace pEd with more-general pI, and fix some printf arg casts.
7024 * lisp.h (pI): New macro, generalizing old pEd macro to other
7025 conversion specifiers. For example, use "...%"pI"d..." rather
7026 than "...%"pEd"...".
7027 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7028 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7029 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7030 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7031 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7032 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7033 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7034 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7035 64-bit hosts.
7036 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7037 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7038 * print.c (safe_debug_print, print_object): Likewise.
7039 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7040 to int.
6f04d126
PE
7041 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7042 avoiding the 0 flag, which is not portable.
c2982e87
PE
7043 * process.c (Fmake_network_process): Use pI to avoid cast.
7044 * region-cache.c (pp_cache): Likewise.
7045 * xdisp.c (decode_mode_spec): Likewise.
7046 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7047 behavior on 64-bit hosts with printf arg.
6f04d126 7048 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7049 (x_stop_queuing_selection_requests): Likewise.
7050 (x_get_window_property): Don't truncate byte count to an 'int'
7051 when tracing.
0b432f21 7052
5e073ec7
PE
7053 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7054 here, since it parses constructs like leading '-' and spaces,
7055 which are not wanted; and it overflows with large numbers.
7056 Instead, simply match F[0-9]+, which is what is wanted anyway.
7057
36372bf9
PE
7058 * alloc.c: Remove unportable assumptions about struct layout.
7059 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7060 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7061 (allocate_vectorlike, make_pure_vector): Use the new macros,
7062 plus offsetof, to remove unportable assumptions about struct layout.
7063 These assumptions hold on all porting targets that I know of, but
7064 they are not guaranteed, they're easy to remove, and removing them
7065 makes further changes easier.
7066
0b432f21
PE
7067 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7068 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7069 (string_overrun_cookie): Now const. Use initializers that
7070 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7071 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7072 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7073 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7074 multiple of sizeof (EMACS_INT); it need not be, if
7075 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7076 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7077
895009e1
JB
70782011-04-26 Juanma Barranquero <lekktu@gmail.com>
7079
7080 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7081
6a7a1b0b
TZ
70822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7083
7084 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7085 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7086 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7087
841a1577 70882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7089
7090 * lisp.h (Qdebug): List symbol.
895009e1 7091 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7092 * keyboard.c (debug-on-event): New variable.
7093 (handle_user_signal): Break into debugger when debug-on-event
7094 matches the current signal symbol.
7095
f2d3ba6f
DN
70962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7097
7098 * alloc.c (check_sblock, check_string_bytes)
7099 (check_string_free_list): Convert to standard C.
7100
42ce4c63
TZ
71012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7102
7103 * w32.c (emacs_gnutls_push): Fix typo.
7104
825cd63c
EZ
71052011-04-25 Eli Zaretskii <eliz@gnu.org>
7106
fb11d64d
EZ
7107 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7108 "cast to pointer from integer of different size".
7109
825cd63c
EZ
7110 Improve doprnt and its use in verror. (Bug#8545)
7111 * doprnt.c (doprnt): Document the set of format control sequences
7112 supported by the function. Use SAFE_ALLOCA instead of always
7113 using `alloca'.
7114
7115 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7116 is one byte too soon. Don't use xrealloc; instead xfree and
7117 xmalloc anew.
7118
e061a11b
TZ
71192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7120
7121 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7122 callbacks stage.
7123
7124 * gnutls.c: Renamed global_initialized to
7125 gnutls_global_initialized. Added internals for the
7126 :verify-hostname-error, :verify-error, and :verify-flags
7127 parameters of `gnutls-boot' and documented those parameters in the
7128 docstring. Start callback support.
9173deec
JB
7129 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7130 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7131 on error. Return error code.
e061a11b
TZ
7132 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7133 (emacs_gnutls_read): Likewise.
7134 (Fgnutls_boot): Return handshake error code.
7135 (emacs_gnutls_handle_error): New function.
7136 (wsaerror_to_errno): Likewise.
7137
7138 * w32.h (emacs_gnutls_pull): Add prototype.
7139 (emacs_gnutls_push): Likewise.
7140
7141 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7142 (emacs_gnutls_push): Likewise.
7143
71442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7145
7146 * process.c (wait_reading_process_output): Check if GnuTLS
7147 buffered some data internally if no FDs are set for TLS
7148 connections.
7149
7150 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7151 (LIBS): Link to USER_LIBS.
7152 ($(BLD)/gnutls.$(0)): New target.
7153
fa6996bc
EZ
71542011-04-24 Eli Zaretskii <eliz@gnu.org>
7155
eb35682e
EZ
7156 * xdisp.c (handle_single_display_spec): Rename the
7157 display_replaced_before_p argument into display_replaced_p, to
7158 make it consistent with the commentary. Fix typos in the
7159 commentary.
7160
e2ad650c
EZ
7161 * textprop.c (syms_of_textprop): Remove dead code.
7162 (copy_text_properties): Delete obsolete commentary about an
7163 interface that was deleted long ago. Fix typos in the description
7164 of arguments.
7165
1b2de274
EZ
7166 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7167 to changes in oldXMenu/XMenu.h from 2011-04-16.
7168 <menu_help_message, prev_menu_help_message>: Constify.
7169 (IT_menu_make_room): menu->help_text is now `const char **';
7170 adjust.
7171
7172 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7173 to changes in oldXMenu/XMenu.h from 2011-04-16.
7174 (struct XMenu): Declare `help_text' `const char **'.
7175
7176 * xfaces.c <Qunspecified>: Make extern again.
7177
7178 * syntax.c: Include sys/types.h before including regex.h, as
7179 required by Posix.
7180
762b15be
EZ
7181 * doc.c (get_doc_string): Improve the format passed to `error'.
7182
7183 * doprnt.c (doprnt): Improve commentary.
7184
7185 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7186
7187 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7188 them with etags.
7189
f1052e5d
EZ
7190 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7191 changes in globals.h immediately force recompilation.
762b15be
EZ
7192 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7193 $(CURDIR)/s/ms-w32.h.
7194 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7195
fa6996bc
EZ
7196 * character.c (Fchar_direction): Function deleted.
7197 (syms_of_character): Don't defsubr it.
7198 <char-direction-table>: Deleted.
7199
e6c3da20
EZ
72002011-04-23 Eli Zaretskii <eliz@gnu.org>
7201
7202 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7203 * doprnt.c: Include limits.h.
7204 (SIZE_MAX): New macro.
04f2d78b
CB
7205 (doprnt): Return a size_t value. 2nd arg is now size_t.
7206 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7207 Improve overflow protection. Support `l' modifier for integer
7208 conversions. Support %l conversion. Don't assume an EMACS_INT
7209 argument for integer conversions and for %c.
7210
7211 * lisp.h (doprnt): Restore prototype.
7212
7213 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7214 $(SRC)/character.h.
7215
7216 * Makefile.in (base_obj): Add back doprnt.o.
7217
7218 * deps.mk (doprnt.o): Add back prerequisites.
7219 (callint.o): Depend on character.h.
7220
7221 * eval.c (internal_lisp_condition_case): Include the handler
7222 representation in the error message.
7223 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7224 when breaking from the loop.
7225
7226 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7227
7228 * callint.c (Fcall_interactively): When displaying error message
7229 about invalid control letter, pass the character's codepoint, not
7230 a pointer to its multibyte form. Improve display of the character
7231 in octal and display also its hex code.
7232
7233 * character.c (char_string): Use %x to display the (unsigned)
7234 codepoint of an invalid character, to avoid displaying a bogus
7235 negative value.
7236
7237 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7238 `error', not SYMBOL_NAME itself.
7239
7240 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7241 character arguments to `error'.
7242
7243 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7244 to `error' in error message about FINAL_CHAR argument. Make sure
7245 FINAL_CHAR is a character, and use %c when it is passed as
7246 argument to `error'.
7247
4ffd0d6b 72482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7249
7250 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7251
7252 * w32.c: Include <time.h>.
7253 (sys_localtime): New function.
7254
4ffd0d6b 72552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7256
7257 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7258
4ffd0d6b 7259 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7260
4ffd0d6b 72612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7262
4ffd0d6b
GM
7263 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7264 zombies (Bug#8467).
aac0c6e3 7265
04c56954
EZ
72662011-04-19 Eli Zaretskii <eliz@gnu.org>
7267
7268 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7269 gl_state.e_property when gl_state.object is Qt.
7270
7271 * insdel.c (make_gap_larger): Remove limitation of buffer size
7272 to <= INT_MAX.
7273
16a43933
CY
72742011-04-18 Chong Yidong <cyd@stupidchicken.com>
7275
7276 * xdisp.c (lookup_glyphless_char_display)
7277 (produce_glyphless_glyph): Handle cons cell entry in
7278 glyphless-char-display.
7279 (Vglyphless_char_display): Document it.
7280
7281 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7282 glyphless-char-display.
7283
4581706e
CY
72842011-04-17 Chong Yidong <cyd@stupidchicken.com>
7285
7286 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7287
7288 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7289
7290 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7291 definition for no-X builds.
7292
4887c6e2 72932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7294
fd35b6f9
PE
7295 Static checks with GCC 4.6.0 and non-default toolkits.
7296
5c1ccb01
PE
7297 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7298
006c5daa
PE
7299 * process.c (keyboard_bit_set): Define only if SIGIO.
7300 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7301 (send_process): Repair possible setjmp clobbering.
7302
efc736d3
PE
7303 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7304
4e2fe2e6
PE
7305 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7306
f97334a2
PE
7307 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7308
4e75f29d
PE
7309 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7310 Define only if needed.
7311
90efadd1
PE
7312 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7313 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7314 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7315
3c647824
PE
7316 * dispextern.h (struct redisplay_interface): Rename param
7317 to avoid shadowing.
e264f262 7318 * termhooks.h (struct terminal): Likewise.
761383f4 7319 * xterm.c (xembed_send_message): Likewise.
3c647824 7320
b58c5c4a
PE
7321 * insdel.c (make_gap_smaller): Define only if
7322 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7323
cad59032
PE
7324 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7325 it.
7326
c339dc2e
PE
7327 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7328 so that we aren't warned about unused symbols.
7329
91a3e27b
PE
7330 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7331
399c71d3 7332 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7333
8ffc96f5
PE
7334 * xfns.c (x_real_positions): Mark locals as initialized.
7335
eef9bc79
PE
7336 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7337
098db9dd
PE
7338 * xterm.c: Fix problems found by static analysis with other toolkits.
7339 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7340 (x_dispatch_event): Declare static if USE_GTK, and
7341 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7342 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7343 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7344 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7345 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7346
eb18f6cc
PE
7347 * xmenu.c (menu_help_callback): Pointer type fixes.
7348 Use const pointers when pointing at readonly data. Avoid pointer
7349 signedness clashes.
7350 (FALSE): Remove unused macro.
7351 (update_frame_menubar): Remove unused decl.
7352
1fe72bf8
PE
7353 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7354
60d9e1db
PE
7355 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7356 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7357 (single_menu_item): Rename local to avoid shadowing.
7358
39261c26
PE
7359 * keyboard.c (make_lispy_event): Remove unused local var.
7360
018c5e19
PE
7361 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7362 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7363
63d2b86e
PE
7364 * bitmaps: Change bitmaps from unsigned char back to the X11
7365 compatible char. Avoid the old compiler warnings about
7366 out-of-range initializers by using, for example, '\xab' rather
7367 than 0xab.
7368
aefd87e1
PE
7369 * xgselect.c (xgselect_initialize): Check vs interface
7370 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7371
bf501fb9
PE
7372 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7373
e9829fdf
PE
7374 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7375 to read-only memory.
7376
1086c095
PE
7377 * fns.c (vector): Remove; this old hack is no longer needed.
7378
2baccd04 7379 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7380 Remove unused var.
dde42981 7381 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7382
72391843 7383 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7384
436c16df 7385 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7386 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7387 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7388
92bb796d 7389 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7390 (x_term_init): Remove local to avoid shadowing.
92bb796d 7391
764430a3 7392 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7393
7394 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7395 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7396
d1dfb56c
EZ
73972011-04-16 Eli Zaretskii <eliz@gnu.org>
7398
c4354cb4
EZ
7399 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7400
d1dfb56c
EZ
7401 Fix regex.c, syntax.c and friends for buffers > 2GB.
7402 * syntax.h (struct gl_state_s): Declare character position members
7403 EMACS_INT.
7404
7405 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7406
04f2d78b
CB
7407 * textprop.c (verify_interval_modification, interval_of):
7408 Declare arguments EMACS_INT.
d1dfb56c
EZ
7409
7410 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7411 EMACS_INT.
7412
7413 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7414
7415 * indent.c (Fvertical_motion): Local variable it_start is now
7416 EMACS_INT.
7417
7418 * regex.c (re_match, re_match_2, re_match_2_internal)
7419 (bcmp_translate, regcomp, regexec, print_double_string)
7420 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7421 (re_compile_pattern, re_exec): Declare arguments and local
7422 variables `size_t' and `ssize_t' and return values `regoff_t', as
7423 appropriate.
7424 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7425 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7426 <compile_stack_type>: `size' and `avail' are now `size_t'.
7427
7428 * regex.h <regoff_t>: Use ssize_t, not int.
7429 (re_search, re_search_2, re_match, re_match_2): Arguments that
7430 specify buffer/string position and length are now ssize_t and
7431 size_t. Return type is regoff_t.
7432
613052cd
BK
74332011-04-16 Ben Key <bkey76@gmail.com>
7434
7435 * nsfont.m: Fixed bugs in ns_get_family and
7436 ns_descriptor_to_entity that were caused by using free to
7437 deallocate memory blocks that were allocated by xmalloc (via
7438 xstrdup). This caused Emacs to crash when compiled with
7439 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7440 --enable-checking=xmallocoverrun). xfree is now used to
7441 deallocate these memory blocks.
7442
4170f62f 74432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7444
71b41406
PE
7445 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7446
9587a89d
PE
7447 emacs_write: Accept and return EMACS_INT for sizes.
7448 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7449 et seq.
7450 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7451 Accept and return EMACS_INT.
7452 (emacs_gnutls_write): Return the number of bytes written on
7453 partial writes.
7454 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7455 (emacs_read, emacs_write): Remove check for negative size, as the
7456 Emacs source code has been audited now.
9587a89d
PE
7457 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7458 (emacs_read, emacs_write): Use it.
273a5f82
PE
7459 * process.c (send_process): Adjust to the new signatures of
7460 emacs_write and emacs_gnutls_write. Do not attempt to store
7461 a byte offset into an 'int'; it might overflow.
9587a89d 7462 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7463
3e047f51
PE
7464 * sound.c: Don't assume sizes fit in 'int'.
7465 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7466 Return EMACS_INT, not int.
3e047f51 7467 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7468 Accept EMACS_INT, not int.
7469 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7470 record read return values.
7471
cc39a9db
BK
74722011-04-15 Ben Key <bkey76@gmail.com>
7473
c9d0ec6d
JB
7474 * keyboard.c (Qundefined): Don't declare static since it is used
7475 in nsfns.m.
7476 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7477 static since they are used in nsfont.m.
cc39a9db 7478
6c60eb9f
SM
74792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7480
7481 * process.c (Qprocessp): Don't declare static.
7482 * lisp.h (Qprocessp): Declare again.
7483
7990b61a
JB
74842011-04-15 Juanma Barranquero <lekktu@gmail.com>
7485
7486 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7487
5d4cb038
PE
74882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7489
8bd7b830 7490 Improve C-level modularity by making more things 'static'.
cd64ea1d 7491
e3b27b31
PE
7492 Don't publish debugger-only interfaces to other modules.
7493 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7494 (verify_bytepos, count_markers): Move decls to the only modules
7495 that need them.
7496 * region-cache.h (pp_cache): Likewise.
7497 * window.h (check_all_windows): Likewise.
7498 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7499
5d4cb038
PE
7500 * sysdep.c (croak): Now static, if
7501 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7502 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7503
7504 * alloc.c (refill_memory_reserve): Now static if
7505 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7506 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7507
e87b6180
PE
7508 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7509 Define only if USE_LUCID.
7510
ac64929e
PE
7511 * xrdb.c (x_customization_string, x_rm_string): Now static.
7512
6f37259d
PE
7513 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7514 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7515
1683e3ab
PE
7516 * xdisp.c (draw_row_with_mouse_face): Now static.
7517 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7518
de9c2632
PE
7519 * window.h (check_all_windows): Mark externally visible.
7520
2b96acb7
PE
7521 * window.c (window_deletion_count): Now static.
7522
7523 * undo.c: Make symbols static if they're not exported.
7524 (last_undo_buffer, last_boundary_position, pending_boundary):
7525 Now static.
7526
50436f33
PE
7527 * textprop.c (interval_insert_behind_hooks): Now static.
7528 (interval_insert_in_front_hooks): Likewise.
7529
64520e5c
PE
7530 * term.c: Make symbols static if they're not exported.
7531 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7532 (max_frame_lines, tty_set_terminal_modes):
7533 (tty_reset_terminal_modes, tty_turn_off_highlight):
7534 (get_tty_terminal): Now static.
7535 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7536 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7537 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7538 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7539 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7540
1fa53021
PE
7541 * sysdep.c: Make symbols static if they're not exported.
7542 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7543 Now static.
7544 (sigprocmask_set, full_mask): Remove; unused.
7545 (wait_debugging): Mark as visible.
7546 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7547 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7548
d4b43b22
PE
7549 * syntax.c (syntax_temp): Define only if !__GNUC__.
7550
b7c513d0
PE
7551 * sound.c (current_sound_device, current_sound): Now static.
7552
989b29ad
PE
7553 * search.c (searchbufs, searchbuf_head): Now static.
7554
13a55a78
PE
7555 * scroll.c (scroll_cost): Remove; unused.
7556 * dispextern.h (scroll_cost): Remove decl.
7557
de68a1fc
PE
7558 * region-cache.h (pp_cache): Mark as externally visible.
7559
40ccffa6
PE
7560 * process.c: Make symbols static if they're not exported.
7561 (process_tick, update_tick, create_process, chan_process):
7562 (Vprocess_alist, proc_buffered_char, datagram_access):
7563 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7564 (deactivate_process): Mark defn as static, as well as decl.
7565 * lisp.h (create_process): Remove decl.
7566 * process.h (chan_process, Vprocess_alist): Remove decls.
7567
ad64fc97
PE
7568 * print.c: Make symbols static if they're not exported.
7569 (print_depth, new_backquote_output, being_printed, print_buffer):
7570 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7571 (print_interval, print_number_index, initial_stderr_stream):
7572 Now static.
7573 * lisp.h (Fprinc): Remove decl.
7574 (debug_output_compilation_hack): Mark as externally visible.
7575
adddb265
PE
7576 * sysdep.c (croak): Move decl from here to syssignal.h.
7577 * syssignal.h (croak): Put it here, so the API can be checked when
7578 'croak' is called from dissociate_if_controlling_tty.
7579
1717ede2
PE
7580 * minibuf.c: Make symbols static if they're not exported.
7581 (minibuf_save_list, choose_minibuf_frame): Now static.
7582 * lisp.h (choose_minibuf_frame): Remove decl.
7583
fa5fb2bc
PE
7584 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7585
1e3890d1
PE
7586 * lread.c: Make symbols static if they're not exported.
7587 (read_objects, initial_obarray, oblookup_last_bucket_number):
7588 Now static.
7589 (make_symbol): Remove; unused.
7590 * lisp.h (initial_obarray, make_symbol): Remove decls.
7591
8a1414fa
PE
7592 * keyboard.c: Make symbols static if they're not exported.
7593 (single_kboard, recent_keys_index, total_keys, recent_keys):
7594 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7595 (this_single_command_key_start, echoing, last_auto_save):
7596 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7597 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7598 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7599 (Vlispy_mouse_stem, double_click_count):
7600 Now static.
7601 (force_auto_save_soon): Define only if SIGDANGER.
7602 (ignore_mouse_drag_p): Now static if
7603 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7604 (print_help): Remove; unused.
7605 (stop_character, last_timer_event): Mark as externally visible.
7606 * keyboard.h (ignore_mouse_drag_p): Declare only if
7607 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7608 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7609 * lisp.h (echoing): Remove decl.
7610 (force_auto_save_soon): Declare only if SIGDANGER.
7611 * xdisp.c (redisplay_window): Simplify code, to make it more
7612 obvious that ignore_mouse_drag_p is not accessed if !defined
7613 USE_GTK && !defined HAVE_NS.
7614
93ea6e8f
PE
7615 * intervals.c: Make symbols static if they're not exported.
7616 (merge_properties_sticky, merge_interval_right, delete_interval):
7617 Now static.
7618 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7619
77382fcc
PE
7620 * insdel.c: Make symbols static if they're not exported.
7621 However, leave prepare_to_modify_buffer alone. It's never
7622 called from outside this function, but that appears to be a bug.
7623 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7624 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7625 (adjust_after_replace_noundo): Remove; unused.
7626 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7627 (signal_before_change): Remove decls.
77382fcc 7628
9306c32e
PE
7629 * indent.c (val_compute_motion, val_vmotion): Now static.
7630
cd44d2eb
PE
7631 * image.c: Make symbols static if they're not exported.
7632 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7633 if USE_GTK.
7634 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7635 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7636
ad9a7a06
PE
7637 * fringe.c (standard_bitmaps): Now static.
7638 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7639
81626931
PE
7640 * frame.c: Make symbols static if they're not exported.
7641 (x_report_frame_params, make_terminal_frame): Now static.
7642 (get_frame_param): Now static, unless HAVE_NS.
7643 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7644 (x_get_resource_string): Remove; not used.
7645 * frame.h (make_terminal_frame, x_report_frame_params):
7646 (x_get_resource_string); Remove decls.
7647 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7648 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7649
239f9db9
PE
7650 * font.c, fontset.c: Make symbols static if they're not exported.
7651 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7652 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7653 * font.c (font_close_object): Now static.
7654 * font.h (font_close_object): Remove.
7655 * fontset.c (FONTSET_OBJLIST): Remove.
7656 (free_realized_fontset) #if-0 the body, which does nothing.
7657 (face_suitable_for_char_p): #if-0, as it's never called.
7658 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7659 * xfaces.c (face_at_string_position):
7660 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7661 since 0 is always ASCII.
7662
dfcf3579
PE
7663 * fns.c (weak_hash_tables): Now static.
7664
5045092b
PE
7665 * fileio.c: Make symbols static if they're not exported.
7666 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7667 (Vwrite_region_annotation_buffers): Now static.
7668
57a96f5c
PE
7669 * eval.c: Make symbols static if they're not exported.
7670 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7671 * lisp.h (backtrace_list): Remove decl.
7672
35f08c38
PE
7673 * emacs.c: Make symbols static if they're not exported.
7674 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7675 (fatal_error_code, fatal_error_signal_hook, standard_args):
7676 Now static.
7677 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7678 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7679 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7680 * lisp.h (fatal_error_signal_hook): Remove decl.
7681 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7682
f44bd759
PE
7683 * editfns.c: Move a (normally-unused) function to its only use.
7684 * editfns.c, lisp.h (get_operating_system_release): Remove.
7685 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7686 worth the hassle of breaking this out.
7687
b532497d
PE
7688 * xterm.c: Make symbols static if they're not exported.
7689 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7690 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7691 (x_destroy_window, x_delete_display):
7692 Now static.
7693 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7694 (x_mouse_leave): Remove; unused.
7695 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7696 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7697 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7698 Remove decls.
7699 (x_mouse_leave): Declare only if WINDOWSNT.
7700 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7701 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7702 USE_X_TOOLKIT.
7703
1675728f
PE
7704 * ftxfont.c: Make symbols static if they're not exported.
7705 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7706 HAVE_FREETYPE.
7707 * font.h (ftxfont_driver): Likewise.
7708
e4cebfca
PE
7709 * xfns.c: Make symbols static if they're not exported.
7710 (x_last_font_name, x_display_info_for_name):
7711 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7712 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7713 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7714 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7715 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7716 (last_show_tip_args): Now static.
7717 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7718 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7719 (x_screen_planes): Remove; unused.
7720 * dispextern.h (x_screen_planes): Remove decl.
7721
5bf46f05
PE
7722 * dispnew.c: Make symbols static if they're not exported.
7723 * dispextern.h (redraw_garbaged_frames, scrolling):
7724 (increment_row_positions): Remove.
7725 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7726 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7727 Now static.
7728 (redraw_garbaged_frames): Remove; unused.
7729
435f4c28
PE
7730 * xfaces.c: Make symbols static if they're not exported.
7731 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7732 Remove decls.
7733 * xterm.h (defined_color): Remove decls.
7734 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7735 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7736 (menu_face_changed_default, defined_color, free_realized_face):
7737 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7738 (ascii_face_of_lisp_face): Remove; unused.
7739
8524aef3
PE
7740 * xdisp.c: Make symbols static if they're not exported.
7741 * dispextern.h (scratch_glyph_row, window_box_edges):
7742 (glyph_to_pixel_coords, set_cursor_from_row):
7743 (get_next_display_element, set_iterator_to_next):
7744 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7745 (show_mouse_face): Remove decls
7746 * frame.h (message_buf_print): Likewise.
7747 * lisp.h (pop_message, set_message, check_point_in_composition):
7748 Likewise.
7749 * xterm.h (set_vertical_scroll_bar): Likewise.
7750 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7751 (message_buf_print, scratch_glyph_row, displayed_buffer):
7752 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7753 (get_next_display_element, show_mouse_face, window_box_edges):
7754 (frame_to_window_pixel_xy, check_point_in_composition):
7755 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7756 (glyph_to_pixel_coords): Remove; unused.
7757
16390cd2
PE
7758 * dired.c (file_name_completion): Now static.
7759
7760 * dbusbind.c (xd_in_read_queued_messages): Now static.
7761
a25f4dfa
PE
7762 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7763 * data.c (circular_list_error): Remove.
7764
14a9c8df
PE
7765 * commands.h (last_point_position, last_point_position_buffer):
7766 (last_point_position_window): Remove decls.
7767 * keyboard.c: Make these variables static.
7768
04f2d78b
CB
7769 * coding.h (coding, code_convert_region, encode_coding_gap):
7770 Remove decls.
74ab6df5
PE
7771 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7772 (iso_code_class, detect_coding, code_convert_region): Now static.
7773 (encode_coding_gap): Remove; unused.
7774
38dfbee1
PE
7775 * chartab.c (chartab_chars, chartab_bits): Now static.
7776
a2cb4e63
PE
7777 * charset.h (charset_iso_8859_1): Remove decl.
7778 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7779 Now static.
7780
127198fd
PE
7781 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7782 * ccl.c (Vccl_program_table): Now static.
7783 (check_ccl_update): Remove; unused.
7784
d85b608f
PE
7785 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7786 * category.h: ... from here.
7787 * category.c (check_category_table, set_category_set): Now static.
7788
31cd66f3
PE
7789 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7790 * lisp.h: Remove these decls.
7791
c358e587
PE
7792 * buffer.c (buffer_count): Remove unused var.
7793
e78aecca
PE
7794 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7795 so that it's not optimized away.
7796 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7797 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7798 exported only to the debugger.
7799
e192d7d3 7800 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7801 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7802
92470028
PE
7803 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7804 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7805 was inaccessible from Lisp.
7806 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7807 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7808
244ed907
PE
7809 alloc.c: Import and export fewer symbols, and remove unused items.
7810 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7811 is defined.
7812 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7813 it's not optimized away by whole-program optimization.
7814 (message_enable_multibyte, free_misc): Remove.
7815 (catchlist, handlerlist, mark_backtrace):
7816 Declare only if BYTE_MARK_STACK.
7817 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7818 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7819 (message_enable_multibyte): Remove decl.
7820 (free_misc, interval_free_list, float_block, float_block_index):
7821 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7822 (cons_free_list, last_marked_index):
7823 Now static.
7824 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7825 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7826 (mark_backtrace): Define only if BYTE_MARK_STACK.
7827 * xdisp.c (message_enable_multibyte): Now static.
7828
61c2b50e 7829 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7830 This makes it easier for human readers (and static analyzers)
7831 to see whether these variables are used from other modules.
7832 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7833 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7834 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7835 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7836 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7837 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7838 * xmenu.c, xselect.c:
7839 Declare Q* vars static if they are not used in other modules.
7840 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7841 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7842 Remove decls of unexported vars.
7843 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7844
95c82688
PE
7845 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7846
16a97296
PE
7847 Make Emacs functions such as Fatom 'static' by default.
7848 This makes it easier for human readers (and static analyzers)
7849 to see whether these functions can be called from other modules.
7850 DEFUN now defines a static function. To make the function external
7851 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7852 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7853 (Finit_image_library):
16a97296
PE
7854 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7855 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7856 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7857 Remove decls, since these functions are now static.
7858 (Funintern, Fget_internal_run_time): New decls, since these functions
7859 were already external.
95c82688 7860
16a97296
PE
7861 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7862 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7863 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7864 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7865 * keyboard.c, keymap.c, lread.c:
7866 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7867 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7868 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7869 Mark functions with DEFUE instead of DEFUN,
7870 if they are used in other modules.
7871 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7872 decls for now-static functions.
7873 * buffer.h (Fdelete_overlay): Remove decl.
7874 * callproc.c (Fgetenv_internal): Mark as internal.
7875 * composite.c (Fremove_list_of_text_properties): Remove decl.
7876 (Fcomposition_get_gstring): New forward static decl.
7877 * composite.h (Fcomposite_get_gstring): Remove decl.
7878 * dired.c (Ffile_attributes): New forward static decl.
7879 * doc.c (Fdocumntation_property): New forward static decl.
7880 * eval.c (Ffetch_bytecode): New forward static decl.
7881 (Funintern): Remove extern decl; now in .h file where it belongs.
7882 * fileio.c (Fmake_symbolic_link): New forward static decl.
7883 * image.c (Finit_image_library): New forward static decl.
7884 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7885 * intervals.h (Fprevious_property_change):
7886 (Fremove_list_of_text_properties): Remove decls.
7887 * keyboard.c (Fthis_command_keys): Remove decl.
7888 (Fcommand_execute): New forward static decl.
7889 * keymap.c (Flookup_key): New forward static decl.
7890 (Fcopy_keymap): Now static.
7891 * keymap.h (Flookup_key): Remove decl.
7892 * process.c (Fget_process): New forward static decl.
7893 (Fprocess_datagram_address): Mark as internal.
7894 * syntax.c (Fsyntax_table_p): New forward static decl.
7895 (skip_chars): Remove duplicate decl.
7896 * textprop.c (Fprevious_property_change): New forward static decl.
7897 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7898 Now internal.
7899 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7900 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7901
785bbd42
PE
7902 * editfns.c (Fformat): Remove unreachable code.
7903
8b913b57
AS
79042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7905
7906 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7907 change. (Bug#8496)
7908
a6744a35
EZ
79092011-04-13 Eli Zaretskii <eliz@gnu.org>
7910
7911 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7912 when at ZV. (Bug#8487)
7913
e7974947
AS
79142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7915
baad03f0
AS
7916 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7917 (Bug#8437)
7918 * keyboard.c (parse_tool_bar_item): Likewise.
7919 * sound.c (sound_cleanup, alsa_close): Likewise.
7920 * termcap.c (tgetent): Likewise.
7921 * xfns.c (x_default_font_parameter): Likewise.
7922 * xsettings.c (read_and_apply_settings): Likewise.
7923
e7974947
AS
7924 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7925 (overrun_check_free): Protoize.
7926
28272684
PE
79272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7928
7929 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7930 since callers should never pass a negative size.
7931 Change the signature to match that of plain 'read' and 'write'; see
7932 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7933 * lisp.h: Update prototypes of emacs_write and emacs_read.
7934
11997c76
EZ
79352011-04-11 Eli Zaretskii <eliz@gnu.org>
7936
7937 * xdisp.c (redisplay_window): Don't try to determine the character
7938 position of the scroll margin if the window start point w->startp
e896f03c 7939 is outside the buffer's accessible region. (Bug#8468)
11997c76 7940
8a2cbd72
EZ
79412011-04-10 Eli Zaretskii <eliz@gnu.org>
7942
7943 Fix write-region and its subroutines for buffers > 2GB.
7944 * fileio.c (a_write, e_write): Modify declaration of arguments and
7945 local variables to support buffers larger than 2GB.
7946 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7947
7948 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7949 argument, local variables, and return value.
7950
7951 * lisp.h: Update prototypes of emacs_write and emacs_read.
7952
7953 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7954
4073e537 79552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7956
1ebfdcb6
PE
7957 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7958
b2ded58d
PE
7959 Fix more problems found by GCC 4.6.0's static checks.
7960
7d66342c
PE
7961 * xdisp.c (vmessage): Use a better test for character truncation.
7962
bbf47d44
PE
7963 * charset.c (load_charset_map): <, not <=, for optimization,
7964 and to avoid potential problems with integer overflow.
9248994d 7965 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7966 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7967 * editfns.c (Fformat): Likewise.
1e69125e 7968 * syntax.c (skip_chars): Likewise.
3befa583 7969
e3019616
PE
7970 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7971 This also lets GCC 4.6.0 generate slightly better loop code.
7972
becfa255
PE
7973 * callint.c (Fcall_interactively): <, not <=, for optimization.
7974 (Fcall_interactively): Count the number of arguments produced,
7975 not the number of arguments given. This is simpler and lets GCC
7976 4.6.0 generate slightly better code.
7977
dae0cd48
PE
7978 * ftfont.c: Distingish more carefully between FcChar8 and char.
7979 The previous code passed unsigned char * to a functions like
7980 strlen and xstrcasecmp that expect char *, which does not
7981 conform to the C standard.
7982 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7983 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7984 char * when the C standard requires it.
7985
76032d70
PE
7986 * keyboard.c (read_char): Remove unused var.
7987
eb3f1cc8
PE
7988 * eval.c: Port to Windows vsnprintf (Bug#8435).
7989 Include <limits.h>.
7990 (SIZE_MAX): Define if the headers do not.
7991 (verror): Do not give up if vsnprintf returns a negative count.
7992 Instead, grow the buffer. This ports to Windows vsnprintf, which
7993 does not conform to C99. Problem reported by Eli Zaretskii.
7994 Also, simplify the allocation scheme, by avoiding the need for
7995 calling realloc, and removing the ALLOCATED variable.
7996
70476b54
PE
7997 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7998
12020a9e
PE
7999 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8000 But keep the doprint source code for now, as we might revamp it
8001 and use it again (Bug#8435).
ea6c7ae6
PE
8002 * lisp.h (doprnt): Remove.
8003 * Makefile.in (base_obj): Remove doprnt.o.
8004 * deps.mk (doprnt.o): Remove.
8005
5fdb398c
PE
8006 error: Print 32- and 64-bit integers portably (Bug#8435).
8007 Without this change, on typical 64-bit hosts error ("...%d...", N)
8008 was used to print both 32- and 64-bit integers N, which relied on
8009 undefined behavior.
61bdb816 8010 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8011 * lisp.h (error, verror): Mark as printf-like functions.
8012 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8013 Report overflow in size calculations when allocating printf buffer.
8014 Do not truncate output string at its first null byte.
8015 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8016 Truncate the output at a character boundary, since vsnprintf does not
8017 do that.
8018 * charset.c (check_iso_charset_parameter): Convert internal
8019 character to string before calling 'error', since %c now has the
8020 printf meaning.
8021 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8022 overflow when computing char to be passed to 'error'. Do not
8023 pass Lisp_Object to 'error'; pass the integer instead.
8024 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8025 formatted with plain %d.
8026
b189fa66
PE
8027 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8028
bff87ef0
PE
8029 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8030
7e2cac20
PE
8031 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8032
ce4d90b5
PE
8033 * xterm.c (x_catch_errors): Remove duplicate declaration.
8034
266c9547
PE
8035 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8036
79c49ad2
PE
8037 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8038
368f4090
JM
80392011-04-10 Jim Meyering <meyering@redhat.com>
8040
8041 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8042 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8043 return ssize_t not "int", and use size_t as the buffer length.
8044 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8045 * gnutls.h: Update declarations.
8046 * process.c (read_process_output): Use ssize_t, to match.
8047 (send_process): Likewise.
8048
a32d4040
CY
80492011-04-09 Chong Yidong <cyd@stupidchicken.com>
8050
8051 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8052
8546720e 80532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8054
04f2d78b
CB
8055 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8056 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8057
8546720e
GM
8058 * xterm.c (handle_one_xevent):
8059 * xmenu.c (create_and_show_popup_menu):
8060 * xselect.c (x_decline_selection_request)
8061 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8062
0a2f5c1a 80632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8064
8065 Fix some uses of `int' instead of EMACS_INT.
8066 * search.c (string_match_1, fast_string_match)
8067 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8068 (scan_buffer, find_next_newline_no_quit)
8069 (find_before_next_newline, search_command, Freplace_match)
8070 (Fmatch_data): Make some `int' variables be EMACS_INT.
8071
8072 * xdisp.c (display_count_lines): 3rd argument and return value now
8073 EMACS_INT. All callers changed.
8074 (pint2hrstr): Last argument is now EMACS_INT.
8075
8076 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8077 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8078 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8079 (decode_coding_utf_16, decode_coding_emacs_mule)
8080 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8081 (decode_coding_ccl, decode_coding_charset)
8082 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8083 (decode_coding_iso_2022, decode_coding_emacs_mule)
8084 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8085 <char_offset, last_offset>: Declare EMACS_INT.
8086 (encode_coding_utf_8, encode_coding_utf_16)
8087 (encode_coding_emacs_mule, encode_invocation_designation)
8088 (encode_designation_at_bol, encode_coding_iso_2022)
8089 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8090 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8091 Declare EMACS_INT.
8092 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8093 (encode_invocation_designation): Last argument P_NCHARS is now
8094 EMACS_INT.
8095 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8096 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8097
8098 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8099 All users changed.
8100
8101 * ccl.c (Fccl_execute_on_string): Declare some variables
8102 EMACS_INT.
8103
8546720e 81042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8105
8106 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8107
4e19a977
CS
81082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8109
8110 * process.c (Fformat_network_address): Doc fix.
8111
87302331
R
81122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8113
ee7683eb 8114 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8115
cbb59342
CY
81162011-04-08 Chong Yidong <cyd@stupidchicken.com>
8117
8118 * keyboard.c (read_char): Call Lisp function help-form-show,
8119 instead of using internal_with_output_to_temp_buffer.
8120 (Qhelp_form_show): New var.
e0d38eeb 8121 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8122
8123 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8124
8125 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8126
e67a13ab
CY
81272011-04-06 Chong Yidong <cyd@stupidchicken.com>
8128
04f2d78b
CB
8129 * process.c (Flist_processes): Remove to Lisp.
8130 (list_processes_1): Delete.
e67a13ab 8131
973f782d
EZ
81322011-04-06 Eli Zaretskii <eliz@gnu.org>
8133
7c106b1e
EZ
8134 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8135
973f782d
EZ
8136 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8137
41cf7d1a 81382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8139
ca23cc88
PE
8140 Fix more problems found by GCC 4.6.0's static checks.
8141
f390e2d5
PE
8142 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8143
42eea0d0
PE
8144 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8145
b69769da 8146 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8147
f9541e84
PE
8148 * xdisp.c (vmessage): Mark as a printf-like function.
8149
13841b55
PE
8150 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8151
c136c10f
PE
8152 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8153
5e2d4a30
PE
8154 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8155 printf-like functions.
8156 (tiff_load): Add casts to remove these marks before passing them
8157 to system-supplied API.
8158
583f48b9
PE
8159 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8160
b25d760e
PE
8161 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8162 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8163 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8164 directly, rather than having caller test rule sign. This avoids
8165 some unnecessary tests.
8166 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8167 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8168 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8169
bc7b6697 8170 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8171 (xfont_open): Avoid unnecessary tests.
bc7b6697 8172
27ccc379
PE
8173 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8174
dcd5c89a
PE
8175 * composite.h, composite.c (composition_gstring_put_cache):
8176 Use EMACS_INT, not int, for length.
8177
b13a45c6
PE
8178 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8179 breaking out part of COMPOSITION_DECODE_RULE.
8180 (COMPOSITION_DECODE_RULE): Use it.
8181 * composite.c (get_composition_id): Remove unused local vars,
8182 by using the new macro.
8183
1e792e4d
PE
8184 * textprop.c (set_text_properties_1): Change while to do-while,
8185 since the condition is always true at first.
8186
dc6c6455 8187 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8188 (interval_deletion_adjustment): Return unsigned value.
8189 All uses changed.
dc6c6455 8190
aba7731a
PE
8191 * process.c (list_processes_1, create_pty, read_process_output):
8192 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8193 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8194 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8195 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8196 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8197
fdfc4bf3
PE
8198 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8199
fca8fe46 8200 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8201 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8202
06a0259a 8203 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8204 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8205 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8206
e7b9e80f
PE
8207 * print.c (print_error_message): Avoid int overflow.
8208
56201685
PE
8209 * font.c (font_list_entities): Redo for clarity,
8210 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8211
78834453 8212 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8213 (font_score): Avoid potential overflow in diff calculation.
78834453 8214
0bc0b309 8215 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8216 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8217
e610eaca
PE
8218 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8219
b895abce
PE
8220 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8221 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8222 can always succeed if overflow has undefined behavior.
8223
1f1d9321 8224 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8225 (wordify): Omit three unnecessary tests.
1f1d9321 8226
c59478bc
PE
8227 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8228 All callers changed. This avoids the need for an unused var.
8229
79b73827
PE
8230 * casefiddle.c (casify_region): Remove var that is set but not used.
8231
a4db5dfe
PE
8232 * dired.c (file_name_completion): Remove var that is set but not used.
8233
43aae36e
PE
8234 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8235
2a47c44d 8236 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8237 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8238
a37c69bf
PE
8239 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8240 Check for integer overflow on size calculations.
8241
328ab8e7
PE
8242 * buffer.c (Fprevious_overlay_change): Remove var that is set
8243 but not used.
8244
e5a2a5cb
PE
8245 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8246 Remove vars that are set but not used.
8d84a6eb 8247 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8248 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8249
a60e5f68
PE
8250 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8251
f661cb61 8252 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8253 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8254
f0397f5a
PE
8255 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8256 that are set but not used.
8257
8664db06 8258 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8259 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8260
6abdaa4a
PE
8261 * xselect.c (x_get_local_selection, x_handle_property_notify):
8262 Remove vars that are set but not used.
8263
0ce7538d 8264 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8265 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8266
9ae848fc
PE
8267 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8268 Remove var that is set but not used.
0b918413
PE
8269 (scroll_bar_windows_size): Now size_t, not int.
8270 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8271 Check for overflow.
9ae848fc 8272
a5a62657
PE
8273 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8274 (map_tty_color) [!defined MSDOS]: Likewise.
8275
5c5cdd39
PE
8276 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8277
66ebf983
PE
8278 * coding.c: Remove vars that are set but not used.
8279 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8280 All callers changed.
8281 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8282 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8283 (decode_coding_charset): Remove vars that are set but not used.
8284
1be4d761
PE
8285 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8286 that is set but not used.
8287
47553fa8
PE
8288 * print.c (print_object): Remove var that is set but not used.
8289
1f7196bf 8290 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8291 The gnulib version avoids calling malloc in the usual case,
8292 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8293 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8294 * filelock.c (current_lock_owner): Likewise.
8295 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8296 * sysdep.c: Include allocator.h, careadlinkat.h.
8297 (emacs_no_realloc_allocator): New static constant.
8298 (emacs_readlink): New function.
fdb61804
PE
8299 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8300 ../lib/careadlinkat.h.
d1fdcab7 8301
f84c17c7
SM
83022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8303
8304 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8305 first non-nil return value).
8306
ef3862ad
JD
83072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8308
8309 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8310 if not defined (Bug#8403).
8311
376a7006
JB
83122011-04-02 Juanma Barranquero <lekktu@gmail.com>
8313
8314 * xdisp.c (display_count_lines): Remove parameter `start',
8315 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8316 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8317 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8318 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8319 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8320 and thereabouts. All callers changed.
8321 (get_per_char_metric): Remove parameter `f', unused since
8322 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8323
6ca3801d
JM
83242011-04-02 Jim Meyering <meyering@redhat.com>
8325
8326 do not dereference NULL upon failed strdup
8327 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8328 (ns_get_family): Likewise.
8329
d8e2b5ba
JB
83302011-04-02 Juanma Barranquero <lekktu@gmail.com>
8331
8332 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8333
8c74fcbd
JD
83342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8335
8336 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8337 later (Bug#8403).
8338
7200d79c
SM
83392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8340
03408648 8341 Add lexical binding.
7200d79c 8342
03408648
SM
8343 * window.c (Ftemp_output_buffer_show): New fun.
8344 (Fsave_window_excursion):
8345 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8346
8347 * lread.c (lisp_file_lexically_bound_p): New function.
8348 (Fload): Bind Qlexical_binding.
8349 (readevalloop): Remove `evalfun' arg.
8350 Bind Qinternal_interpreter_environment.
8351 (Feval_buffer): Bind Qlexical_binding.
8352 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8353 Mark as dynamic.
8354 (syms_of_lread): Declare `lexical-binding'.
8355
8356 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8357
8358 * keyboard.c (eval_dyn): New fun.
8359 (menu_item_eval_property): Use it.
ca105506
SM
8360
8361 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8362
03408648
SM
8363 * fns.c (concat, mapcar1): Accept byte-code-functions.
8364
8365 * eval.c (Fsetq): Handle lexical vars.
8366 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8367 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8368 (FletX, Flet): Obey lexical binding.
8369 (Fcommandp): Handle closures.
8370 (Feval): New `lexical' arg.
8371 (eval_sub): New function extracted from Feval. Use it almost
8372 everywhere where Feval was used. Look up vars in lexical env.
8373 Handle closures.
8374 (Ffunctionp): Move from subr.el.
8375 (Ffuncall): Handle closures.
8376 (apply_lambda): Remove `eval_flags'.
8377 (funcall_lambda): Handle closures and new byte-code-functions.
8378 (Fspecial_variable_p): New function.
8379 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8380 but without exporting it to Lisp.
23aba0ea 8381
23aba0ea 8382 * doc.c (Fdocumentation, store_function_docstring):
03408648 8383 * data.c (Finteractive_form): Handle closures.
23aba0ea 8384
03408648
SM
8385 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8386 interactive spec.
ba83908c 8387
04f2d78b
CB
8388 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8389 New byte-codes.
03408648
SM
8390 (exec_byte_code): New function extracted from Fbyte_code to handle new
8391 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8392
03408648 8393 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8394
03408648 8395 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8396
e2abce01
JB
83972011-03-31 Juanma Barranquero <lekktu@gmail.com>
8398
8399 * xdisp.c (redisplay_internal): Fix prototype.
8400
63696a73 84012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8402
63696a73 8403 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8404 (try_scrolling): Use it when setting scroll_limit.
8405 Limit scrolling to 100 screen lines.
63696a73
EZ
8406 (redisplay_window): Even when falling back on "recentering",
8407 position point in the window according to scroll-conservatively,
8408 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8409
8410 (try_scrolling): When point is above the window, allow searching
8411 as far as scroll_max, or one screenful, to compute vertical
8412 distance from PT to the scroll margin position. This prevents
8413 try_scrolling from unnecessarily failing when
8414 scroll-conservatively is set to a value slightly larger than the
8415 window height. Clean up the case of PT below the margin at bottom
8416 of window: scroll_max can no longer be INT_MAX. When aggressive
8417 scrolling is in use, don't let point enter the opposite scroll
8418 margin as result of the scroll.
8419 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8420 threshold of 100 lines for never-recentering scrolling.
8421
e4cc2dfc
JB
84222011-03-31 Juanma Barranquero <lekktu@gmail.com>
8423
8424 * dispextern.h (move_it_by_lines):
8425 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8426 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8427 (message_log_check_duplicate): Remove parameters `prev_bol' and
8428 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8429 (redisplay_internal): Remove parameter `preserve_echo_area',
8430 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8431
8432 * indent.c (Fvertical_motion):
8433 * window.c (window_scroll_pixel_based, Frecenter):
8434 Don't pass `need_y_p' to `move_it_by_lines'.
8435
1c470562
SM
84362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8437
44f230aa
SM
8438 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8439 steal a few bits to be more compact.
8440 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8441 Remove unneeded casts.
8442
1c470562
SM
8443 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8444
888adce9
ZK
84452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8446
8447 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8448 binding" message (bug#7967).
8449
f838ed7b
PE
84502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8451
77861b95
PE
8452 Fix more problems found by GCC 4.6.0's static checks.
8453
de6dbc14
PE
8454 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8455 Remove unused local var.
8456
f838ed7b
PE
8457 * editfns.c (Fmessage_box): Remove unused local var.
8458
792c7b2b
PE
8459 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8460 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8461 Omit unused local vars.
c499e557 8462 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8463 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8464 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8465 Omit unused local var.
8466
ba0165e1
PE
8467 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8468 Don't assume string length fits in int.
32ad8845 8469 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8470 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8471
3c59b4c9
PE
8472 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8473 instead of alloca (Bug#8344).
8474
a3eed478 8475 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8476 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8477
eb4d412d
PE
8478 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8479
1658b401
PE
8480 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8481 concerns.
8482
8483 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8484
8485 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8486
9a2c6e05
PE
8487 * keyboard.c (syms_of_keyboard): Use the same style as later
8488 in this function when indexing through an array. This also
8489 works around GCC bug 48267.
8490
03d0a109
PE
8491 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8492
44f730c8
PE
8493 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8494
fe75f926
PE
8495 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8496 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8497
ffa8c828
PE
8498 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8499 This avoids undefined behavior on integer overflow, and is a bit
8500 more convenient anyway since it is compared to a size_t variable.
8501
c5101a77
PE
8502 Variadic C functions now count arguments with size_t, not int.
8503 This avoids an unnecessary limitation on 64-bit machines, which
8504 caused (substring ...) to crash on large vectors (Bug#8344).
8505 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8506 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8507 All variadic functions and their callers changed accordingly.
c5101a77
PE
8508 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8509 * data.c (arith_driver, float_arith_driver): Likewise.
8510 * editfns.c (general_insert_function): Likewise.
8511 * eval.c (struct backtrace.nargs, interactive_p)
8512 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8513 (funcall_lambda, mark_backtrace): Likewise.
8514 * fns.c (concat): Likewise.
8515 * frame.c (x_set_frame_parameters): Likewise.
8516 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8517 0 if not found, not -1. All callers changed.
8518
dd3f25f7
PE
8519 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8520 (stack_copy_size): Now size_t, not int.
8521 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8522
461c2ab9
JB
85232011-03-28 Juanma Barranquero <lekktu@gmail.com>
8524
8525 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8526 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8527 All callers changed.
8528
8529 * lisp.h (multibyte_char_to_unibyte):
8530 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8531 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8532 * character.h (CHAR_TO_BYTE8):
8533 * cmds.c (internal_self_insert):
8534 * editfns.c (general_insert_function):
8535 * keymap.c (push_key_description):
8536 * search.c (Freplace_match):
8537 * xdisp.c (message_dolog, set_message_1): All callers changed.
8538
f6d62986
SM
85392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8540
8541 * keyboard.c (safe_run_hook_funcall): New function.
8542 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8543 don't set the hook to nil, but remove the offending function instead.
8544 (Qcommand_hook_internal): Remove, unused.
8545 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8546 Vcommand_hook_internal.
8547
8548 * eval.c (enum run_hooks_condition): Remove.
8549 (funcall_nil, funcall_not): New functions.
8550 (run_hook_with_args): Call each function through a `funcall' argument.
8551 Remove `cond' argument, now redundant.
8552 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8553 (Frun_hook_with_args_until_failure): Adjust accordingly.
8554 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8555
1db5b1ad
JB
85562011-03-28 Juanma Barranquero <lekktu@gmail.com>
8557
8558 * dispextern.h (string_buffer_position): Remove declaration.
8559
8560 * print.c (strout): Remove parameter `multibyte', unused since
8561 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8562
8563 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8564 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8565 All callers changed.
8566
8567 * w32.c (_wsa_errlist): Use braces for struct initializers.
8568
8569 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8570 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8571 All callers changed.
8572 (string_buffer_position): Likewise. Also, make static (it's never
8573 used outside xdisp.c).
8574 (cursor_row_p): Remove parameter `w', unused since
8575 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8576 (decode_mode_spec): Remove parameter `precision', introduced during
8577 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8578 All callers changed.
8579
5ffb62aa
JD
85802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8581
8582 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8583
461c2ab9 85842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8585
8586 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8587 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8588 (ns_update_auto_hide_menu_bar): New functions.
8589 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8590 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8591 ns_constrain_all_frames.
8592 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8593 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8594
5c380ffb
JD
85952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8598
9af30bdf
GM
85992011-03-27 Glenn Morris <rgm@gnu.org>
8600
8601 * syssignal.h: Replace RETSIGTYPE with void.
8602 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8603 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8604 Replace SIGTYPE with void everywhere.
8605 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8606 * s/template.h (SIGTYPE): Remove commented out definition.
8607
e2abce01
JB
86082011-03-26 Eli Zaretskii <eliz@gnu.org>
8609
8610 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8611 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8612
f868cd8a
JB
86132011-03-26 Juanma Barranquero <lekktu@gmail.com>
8614
59eb0929
JB
8615 * w32.c (read_unc_volume): Use parameter `henum', instead of
8616 global variable `wget_enum_handle'.
8617
8618 * keymap.c (describe_vector): Remove parameters `indices' and
8619 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8620 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8621
f868cd8a
JB
8622 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8623
8624 * keyboard.c (timer_check): Remove parameter `do_it_now',
8625 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8626 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8627 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8628
8629 * keyboard.c (read_char):
8630 * w32menu.c (w32_menu_display_help):
8631 * xmenu.c (show_help_event, menu_help_callback):
8632 Adjust calls to `show_help_echo'.
8633
8634 * gtkutil.c (xg_maybe_add_timer):
8635 * keyboard.c (readable_events):
8636 * process.c (wait_reading_process_output):
8637 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8638
8639 * insdel.c (adjust_markers_gap_motion):
8640 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8641 (gap_left, gap_right): Don't call it.
8642
2ecf6fdb
CY
86432011-03-25 Chong Yidong <cyd@stupidchicken.com>
8644
8645 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8646 incurred during fontification.
8647
6b1f9ba4
JB
86482011-03-25 Juanma Barranquero <lekktu@gmail.com>
8649
8650 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8651 (DEFVAR_PER_BUFFER): Don't pass it.
8652
8653 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8654 (scrolling_window): Don't pass it.
8655
0f4a96b5
JB
86562011-03-25 Juanma Barranquero <lekktu@gmail.com>
8657
8658 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8659
8660 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8661 and `suffix'.
8662 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8663 of variables specific to SELinux and computation of `encoded_absname'.
8664
8665 * image.c (XPutPixel): Remove unused variable `height'.
8666
8667 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8668
8669 * unexw32.c (get_section_info): Remove unused variable `section'.
8670
8671 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8672 (system_process_attributes): Remove unused variable `sess'.
8673 (sys_read): Remove unused variable `err'.
8674
8675 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8676 (w32_wnd_proc): Remove unused variable `isdead'.
8677 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8678 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8679 (x_create_tip_frame): Remove unused variable `tem'.
8680
8681 * w32inevt.c (w32_console_read_socket):
8682 Remove unused variable `no_events'.
8683
8684 * w32term.c (x_draw_composite_glyph_string_foreground):
8685 Remove unused variable `width'.
8686
1149507c
JB
86872011-03-24 Juanma Barranquero <lekktu@gmail.com>
8688
8689 * w32term.c (x_set_glyph_string_clipping):
8690 Don't pass uninitialized region to CombineRgn.
8691
9c88f339
JB
86922011-03-23 Juanma Barranquero <lekktu@gmail.com>
8693
8694 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8695 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8696 (Fx_close_connection): Remove unused variable `i'.
8697
8698 * w32font.c (w32font_draw): Return number of glyphs.
8699 (w32font_open_internal): Remove unused variable `i'.
8700 (w32font_driver): Add missing initializer.
8701
8702 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8703 (fill_in_menu): Remove unused variable `items_added'.
8704
8705 * w32term.c (last_mouse_press_frame): Remove static global variable.
8706 (w32_clip_to_row): Remove unused variable `f'.
8707 (x_delete_terminal): Remove unused variable `i'.
8708
8709 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8710 (NOTHING): Remove unused static global variable.
8711 (uniscribe_check_otf): Remove unused variable `table'.
8712 (uniscribe_font_driver): Add missing initializers.
8713
dee091a3
JD
87142011-03-23 Julien Danjou <julien@danjou.info>
8715
8716 * term.c (Fsuspend_tty, Fresume_tty):
8717 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8718 * window.c (temp_output_buffer_show):
8719 * insdel.c (signal_before_change):
8720 * frame.c (Fhandle_switch_frame):
8721 * fileio.c (Fdo_auto_save):
8722 * emacs.c (Fkill_emacs):
8723 * editfns.c (save_excursion_restore):
8724 * cmds.c (internal_self_insert):
8725 * callint.c (Fcall_interactively):
8726 * buffer.c (Fkill_all_local_variables):
8727 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8728 Use Frun_hooks.
0f4a96b5 8729 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8730 unconditionally since it does the check itself.
dee091a3 8731
2c520ab5 87322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8733
c9c49752
PE
8734 Fix more problems found by GCC 4.5.2's static checks.
8735
8abc3f12
PE
8736 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8737 the first time through the loop, since we know p0 < p1 then.
8738 This also avoids a gcc -Wstrict-overflow warning.
8739
a2d26660
PE
8740 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8741 leading to a memory leak, possible in functions like
8742 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8743 of objects (Bug#8318).
a2d26660 8744
916c72e9
PE
8745 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8746 that could (at least in theory) be that large.
8747
19ab8a18
PE
8748 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8749 This is less likely to overflow, and avoids undefined behavior if
8750 overflow does occur. All callers changed. Use strtoul to scan
8751 for the unsigned long integer.
b7cbbd6f
PE
8752 (pint2hrstr): Simplify and tune code slightly.
8753 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8754
f0641eff
PE
8755 * scroll.c (do_scrolling): Work around GCC bug 48228.
8756 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8757
7f650bb9
PE
8758 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8759 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8760 (validate_x_resource_name): Simplify count usage.
8761 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8762
37dd57d1
PE
8763 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8764 fail (Bug#8306).
81e56e61 8765
699979fc 8766 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8767
401bf9b4
PE
8768 * process.c (Fmake_network_process): Use socklen_t, not int,
8769 where POSIX says socklen_t is required in portable programs.
8770 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8771 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8772 (Fmake_network_process, server_accept_connection):
8773 (wait_reading_process_output, read_process_output):
8774 Likewise.
8775
b93aacde
PE
8776 * process.c: Rename or move locals to avoid shadowing.
8777 (list_processes_1, Fmake_network_process):
8778 (read_process_output_error_handler, exec_sentinel_error_handler):
8779 Rename or move locals.
4dc343ee 8780 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8781 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8782 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8783 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8784 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8785
af8a867c 8786 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8787 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8788 Include tparam.h instead, since it declares them.
af8a867c
PE
8789 * cm.h (PC): Remove extern decl; tparam.h now does this.
8790 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8791 * terminfo.c: Include tparam.h, to check interfaces.
8792 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8793 (tparam): Adjust signature to match interface in tparam.h;
8794 this removes some undefined behavior. Check that outstring and len
8795 are zero, which they always are with Emacs.
8796 * tparam.h (PC, BC, UP): New extern decls.
8797
0248044d 8798 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8799 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8800
8ff096c1 8801 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8802 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8803 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8804 (ftfont_list): Remove unused local.
49eaafba
PE
8805 (get_adstyle_property, ftfont_pattern_entity):
8806 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8807 Rename locals to avoid shadowing.
8ff096c1 8808
e2be39f6
PE
8809 * xfont.c (xfont_list_family): Mark var as initialized.
8810
c9735e30
PE
8811 * xml.c (make_dom): Now static.
8812
8f5201ae
PE
8813 * composite.c (composition_compute_stop_pos): Rename local to
8814 avoid shadowing.
b246f932
PE
8815 (composition_reseat_it): Remove unused locals.
8816 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8817 (composition_update_it): Mark var as initialized.
11b61122
PE
8818 (find_automatic_composition): Mark vars as initialized,
8819 with a FIXME (Bug#8290).
8f5201ae 8820
760fbc2c
PE
8821 character.h: Rename locals to avoid shadowing.
8822 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8823 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8824 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8825 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8826 to avoid shadowing.
8827
ff08eb85
PE
8828 * textprop.c (property_change_between_p): Remove; unused.
8829
fc7bf025
PE
8830 * intervals.c (interval_start_pos): Now static.
8831
235d7abc
PE
8832 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8833
44f230aa
SM
8834 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8835 Rename locals to avoid shadowing.
3e7d6594 8836
50060332
PE
8837 * sound.c (wav_play, au_play, Fplay_sound_internal):
8838 Fix pointer signedness.
d01f234b 8839 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8840 (wav_play): Initialize a variable to 0, to prevent undefined
8841 behavior (Bug#8278).
50060332 8842
c4fc4e30
PE
8843 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8844
918436ed
PE
8845 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8846
c939f91b
PE
8847 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8848 clobbering (Bug#8298).
b9c7f648
PE
8849 * sysdep.c (sys_subshell): Likewise.
8850 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8851
6bd8c144
PE
8852 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8853 This should get cleaned up, so that child_setup has the
8854 same signature on all platforms.
8855
7710357c 8856 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8857 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8858
c59da222
CY
88592011-03-22 Chong Yidong <cyd@stupidchicken.com>
8860
8861 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8862 not to be necessary, and produces flickering.
8863
66b87493
GM
88642011-03-20 Glenn Morris <rgm@gnu.org>
8865
8866 * config.in: Remove file.
8867
45b6f6d5
JB
88682011-03-20 Juanma Barranquero <lekktu@gmail.com>
8869
8870 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8871 are now in src/globals.h.
8872 (syms_of_minibuf): Remove spurious & from previous change.
8873
cd394be1 88742011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8875
8876 * minibuf.c (completing-read-function): New variable.
8877 (completing-read-default): Rename from completing-read.
8878 (completing-read): Call completing-read-function.
8879
b14e3e21
CY
88802011-03-19 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * xfaces.c (Fx_load_color_file):
8883 Read color file from absolute filename (bug#8250).
8884
f2b726e6
JB
88852011-03-19 Juanma Barranquero <lekktu@gmail.com>
8886
8887 * makefile.w32-in: Update dependencies.
8888
09f6ff02
EZ
88892011-03-17 Eli Zaretskii <eliz@gnu.org>
8890
8891 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8892
29a6015a
PE
88932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8894
a3a6c54e
PE
8895 Fix more problems found by GCC 4.5.2's static checks.
8896
b766f867
PE
8897 * process.c (make_serial_process_unwind, send_process_trap):
8898 (sigchld_handler): Now static.
8899
be02381c
PE
8900 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8901 That way, the code declares only the vars that it needs.
8902 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8903 * s/cygwin.h (PTY_ITERATION): Likewise.
8904 * s/darwin.h (PTY_ITERATION): Likewise.
8905 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8906
57048744
PE
8907 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8908 * process.c (allocate_pty): Don't declare stb unless it's needed.
8909
7914961c 8910 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8911 (CONSTANTLIM): Remove; unused.
8912 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8913 Define only if needed.
7914961c 8914
b3967b18
PE
8915 * unexelf.c (unexec): Name an expression,
8916 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8917 Use a different way to cause a compilation error if anyone uses
8918 n rather than nn, a way that does not involve shadowing.
73366a00 8919 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8920
29a6015a
PE
8921 * deps.mk (unexalpha.o): Remove; unused.
8922
43cfc33e 8923 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8924 * unexec.h: New file.
ce701a33
PE
8925 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8926 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8927 Depend on unexec.h.
8928 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8929 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8930 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8931 Change as necessary to match prototype in unexec.h.
ce701a33 8932
01f44d5a
PE
8933 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8934 shadowing.
4f63c6bb 8935 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8936
a6670b0b
PE
8937 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8938 Rename locals to avoid shadowing.
8939
cef2010d 8940 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8941 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8942
d4d7173a
PE
8943 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8944
f08b802a
PE
8945 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8946 warning when compiling print.c.
8947
3ddb0639
PE
8948 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8949 instead of using an uninitialized var.
5ad03b97 8950 (font_sort_entities): Mark var as initialized.
3ddb0639 8951
170a2692
PE
8952 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8953
e663c700
PE
8954 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8955 pointers to constants.
89bc529a 8956 (font_parse_fcname): Remove unused vars.
7b81e2d0 8957 (font_delete_unmatched): Now static.
ea838e10 8958 (font_get_spec): Remove; unused.
13a547c6
PE
8959 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8960 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8961 Rename or move locals to avoid shadowing.
e663c700 8962
2a80c887 8963 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8964 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8965
1384fa33 8966 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8967 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8968
8b2c52e9
PE
8969 * alloc.c (mark_backtrace): Move decl from here ...
8970 * lisp.h: ... to here, so that it can be checked.
8971
475545b5 8972 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8973 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8974 (lisp_indirect_variable): Name an expression,
8975 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8976 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8977
b1349114 8978 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8979 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8980 Use const pointer when appropriate.
b1349114 8981
a2928364
PE
8982 * lisp.h (get_system_name, get_operating_system_release):
8983 Move decls here, to check interfaces.
8984 * process.c (get_operating_system_release): Move decl to lisp.h.
8985 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8986 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8987 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8988 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8989 (Fformat_time_string, Fencode_time, Finsert_char):
8990 (Ftranslate_region_internal, Fformat):
8991 Rename or remove local vars to avoid shadowing.
9710023e 8992 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8993
a415e694
PE
8994 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8995 avoid shadowing.
8996
8ef4622d
PE
8997 * lisp.h (eassert): Check that the argument compiles, even if
8998 ENABLE_CHECKING is not defined.
8999
946f9a5b
PE
9000 * data.c (Findirect_variable): Name an expression, to avoid
9001 gcc -Wbad-function-cast warning.
112396d6 9002 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9003 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9004 (Fmake_variable_buffer_local, Fmake_local_variable):
9005 Mark variables as initialized.
52746918 9006 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9007
e5aab7e7 9008 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9009 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9010 Rename locals to avoid shadowing.
dff45157
PE
9011 (mark_stack): Move local variables into the #ifdef region where
9012 they're used.
7bc26fdb
PE
9013 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9014 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9015 needed otherwise.
9016 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9017 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9018 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9019
e5aab7e7
PE
9020 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9021 avoids undefined behavior in theory.
9022
4da60324
PE
9023 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9024
88043301
PE
9025 Use functions, not macros, for up- and down-casing (Bug#8254).
9026 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9027 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9028 to use the following functions instead of these macros.
9029 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9030 EMACS_INT, since callers assume the returned value fits in int.
9031 (upcase1): Likewise, for UPCASE_TABLE.
9032 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9033 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9034 the race-condition problem in the old DOWNCASE.
88043301 9035
19ed5445
PE
9036 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9037 Rename locals to avoid shadowing.
9038 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9039 (regex_compile, re_search_2, re_match_2_internal):
9040 Remove unused local vars.
952db0d7
PE
9041 (FREE_VAR): Rewrite so as not to use empty "else",
9042 which gcc can warn about.
da053e48 9043 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9044 (RETALLOC_IF): Define only if needed.
9045 (WORDCHAR_P): Likewise. This one is never needed, but is used
9046 only in a comment talking about a compiler bug, so put inside
9047 the #if 0 of that comment.
9048 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9049 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9050 Remove; unused.
19ed5445 9051
1f3561e4 9052 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9053 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9054 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9055
ded6f8f7
PE
9056 * search.c (simple_search): Remove unused var.
9057
dbd37a95
PE
9058 * dired.c (compile_pattern): Move decl from here ...
9059 * lisp.h: ... to here, so that it can be checked.
9060 (struct re_registers): New forward decl.
9061
7e47afad
PE
9062 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9063
85f24f61
PE
9064 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9065 All uses changed.
9066 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9067 Rename locals to avoid shadowing.
5671df8f 9068 (Fvertical_motion): Mark locals as initialized.
85f24f61 9069
181aa2be 9070 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9071 (casify_region): Mark local as initialized.
181aa2be 9072
930d429c
PE
9073 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9074
7082eac6
PE
9075 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9076 New macros, so that the caller can use some names other than
9077 gcpro1, gcpro2, etc.
9078 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9079 of the new macros.
9080 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9081 argument, for consistency with GCPRO2_VAR, etc: it is now the
9082 prefix of the variable, not the variable itself. All uses
9083 changed.
38b2c076
PE
9084 * dired.c (directory_files_internal, file_name_completion):
9085 Rename locals to avoid shadowing.
9086
15206ed9
PE
9087 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9088 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9089 dired.c's scmp function, had undefined behavior.
9090 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9091 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9092 * buffer.h: ... to here, because these macros use current_buffer,
9093 and the new implementation with inline functions needs to have
9094 current_buffer in scope now, rather than later when the macros
9095 are used.
9096 (downcase, upcase1): New static inline functions.
9097 (DOWNCASE, UPCASE1): Reimplement using these functions.
9098 This avoids undefined behavior in expressions like
9099 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9100 from race conditions in accessing the global variables
9101 case_temp1 and case_temp2.
9102 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9103 * lisp.h (case_temp1, case_temp2): Remove their decls.
9104 * character.h (ASCII_CHAR_P): Move from here ...
9105 * lisp.h: ... to here, so that the inline functions mentioned
9106 above can use them.
9107
4a6bea26
PE
9108 * dired.c (directory_files_internal_unwind): Now static.
9109
f14b7e14
PE
9110 * fileio.c (file_name_as_directory, directory_file_name):
9111 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9112 Now static.
2893f146
PE
9113 (file_name_as_directory): Use const pointers when appropriate.
9114 (Fexpand_file_name): Likewise. In particular, newdir might
9115 point at constant storage, so make it a const pointer.
fd4ead52 9116 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9117 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9118 signedness issues.
f839df0c
PE
9119 (Fset_file_times, Finsert_file_contents, auto_save_error):
9120 Rename locals to avoid shadowing.
f14b7e14 9121
5716756e 9122 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9123 (Ftry_completion, Fall_completions): Rename or remove locals
9124 to avoid shadowing.
5716756e 9125
b4c3046a
PE
9126 * marker.c (bytepos_to_charpos): Remove; unused.
9127
b45db522
PE
9128 * lisp.h (verify_bytepos, count_markers): New decls,
9129 so that gcc does not warn that these functions aren't declared.
9130
85876d07
PE
9131 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9132 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9133 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9134 (copy_text): Remove unused local var.
85876d07 9135
03d78a21 9136 * filelock.c (within_one_second): Now static.
b3dd38ab 9137 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9138
5df8f01b
PE
9139 * buffer.c (fix_overlays_before): Mark locals as initialized.
9140 (fix_start_end_in_overlays): Likewise. This function should be
9141 simplified by using pointers-to-pointers, but that's a different
9142 matter.
b1d876f1 9143 (switch_to_buffer_1): Now static.
8f54f30a
PE
9144 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9145 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9146
a70072c9 9147 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9148 Fix pointer signedness issue.
edced198
PE
9149 (sys_subshell): Mark local as volatile if checking for lint,
9150 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9151 (MAXPATHLEN): Define only if needed.
a70072c9 9152
a0977c44
PE
9153 * process.c (serial_open, serial_configure): Move decls from here ...
9154 * systty.h: ... to here, so that they can be checked.
9155
a884fdcc
PE
9156 * fns.c (get_random, seed_random): Move extern decls from here ...
9157 * lisp.h: ... to here, so that they can be checked.
9158
604efe86 9159 * sysdep.c (reset_io): Now static.
b8950c94 9160 (wait_for_termination_signal): Remove; unused.
604efe86 9161
38fc62d9
PE
9162 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9163 (copy_keymap_item, append_key, push_text_char_description):
9164 Now static.
1004a21a 9165 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9166 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9167 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9168 (describe_map_tree):
9169 Rename locals to avoid shadowing.
38fc62d9 9170
2f2650da
PE
9171 * keyboard.c: Declare functions static if they are not used elsewhere.
9172 (echo_char, echo_dash, cmd_error, top_level_2):
9173 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9174 (read_char, kbd_buffer_get_event, make_lispy_position):
9175 (make_lispy_event, make_lispy_movement, apply_modifiers):
9176 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9177 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9178 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9179 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9180 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9181
a053e86c 9182 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9183 (mark_kboards): Move decl here ...
9184 * alloc.c (mark_kboards): ... from here.
a053e86c 9185
4752793e
PE
9186 * lisp.h (force_auto_save_soon): New decl.
9187
74f10ca7 9188 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9189 (DEFINE_DUMMY_FUNCTION): New macro.
9190 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9191 Use it.
c03cd23f
PE
9192 (main): Add casts to avoid warnings
9193 if GCC considers string literals to be constants.
74f10ca7 9194
022e70d4
PE
9195 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9196
59d6fe83
PE
9197 * dbusbind.c: Pointer signedness fixes.
9198 (xd_signature, xd_append_arg, xd_initialize):
9199 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9200 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9201 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9202 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9203
78320123
PE
9204 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9205 if GCC considers string literals to be constants.
49cebcca 9206 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9207
35ac2a97
SM
92082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9209
fb103ca9
SM
9210 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9211 (print_preprocess, print_object): New macro to fix last change.
9212
35ac2a97
SM
9213 * print.c (print_preprocess): Don't forget font objects.
9214
62973b41
JB
92152011-03-16 Juanma Barranquero <lekktu@gmail.com>
9216
9217 * emacs.c (USAGE3): Doc fixes.
9218
0e48bb22
AS
92192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9220
9221 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9222 structure.
9223
7684e57b
JB
92242011-03-14 Juanma Barranquero <lekktu@gmail.com>
9225
9226 * lisp.h (VWindow_system, Qfile_name_history):
9227 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9228 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9229 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9230
9231 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9232 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9233
9234 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9235 * w32console.c (detect_input_pending, read_input_pending)
9236 (encode_terminal_code):
9237 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9238 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9239 (w32_system_caret_y, Qfile_name_history):
9240 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9241 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9242 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9243 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9244 * w32proc.c (Qlocal, report_file_error):
9245 * w32term.c (Vwindow_system, updating_frame):
9246 * w32uniscribe.c (initialized, uniscribe_font_driver):
9247 Remove unneeded extern declarations.
9248
2aa46d6c
CY
92492011-03-14 Chong Yidong <cyd@stupidchicken.com>
9250
c96bbc66 9251 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9252
cffc6f3b
CY
92532011-03-13 Chong Yidong <cyd@stupidchicken.com>
9254
9255 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9256 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9257 These macros can no longer be used for assignment.
9258
44f230aa
SM
9259 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9260 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9261 (record_buffer_markers, fetch_buffer_markers): New functions for
9262 recording and fetching special buffer markers.
9263 (set_buffer_internal_1, set_buffer_temp): Use them.
9264
9265 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9266
9267 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9268
9269 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9270 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9271
9272 * xdisp.c (hscroll_window_tree):
9273 (reconsider_clip_changes): Use PT instead of BUF_PT.
9274
d251f04b
EZ
92752011-03-13 Eli Zaretskii <eliz@gnu.org>
9276
9277 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9278 $(EMACS_ROOT)/lib/intprops.h.
9279
f0c77cd1
PE
92802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9281
3eca4629
PE
9282 Fix more problems found by GCC 4.5.2's static checks.
9283
7c86ee98
PE
9284 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9285 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9286 (xg_free_frame_widgets): Make it clear that a local variable is
9287 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9288 (gdk_window_get_screen): Make it clear that this macro is needed
9289 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9290 (int_gtk_range_get_value): New function, which avoids a diagnostic
9291 from gcc -Wbad-function-cast.
9292 (xg_set_toolkit_scroll_bar_thumb): Use it.
9293 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9294 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9295 (get_utf8_string, xg_get_file_with_chooser):
9296 Rename locals to avoid shadowing.
9297 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9298
41729b81
PE
9299 * xgselect.c (xg_select): Remove unused var.
9300
f0c77cd1
PE
9301 * image.c (four_corners_best): Mark locals as initialized.
9302 (gif_load): Initialize transparent_p to zero (Bug#8238).
9303 Mark another local as initialized.
ec6cf4c6 9304 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9305
ce0ad53d 9306 * image.c (clear_image_cache): Now static.
d5d5a617 9307 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9308 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9309 (x_edge_detection): Remove unnecessary cast that
9310 gcc -Wbad-function-cast diagnoses.
2037898d 9311 (gif_load): Fix pointer signedness.
6ae141d6
PE
9312 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9313 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9314
33383987 93152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9316
d32df629
PE
9317 Improve quality of tests for time stamp overflow.
9318 For example, without this patch (encode-time 0 0 0 1 1
9319 1152921504606846976) returns the obviously-bogus value (-948597
9320 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9321 reports time overflow. See
9322 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9323 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9324 * editfns.c: Include limits.h and intprops.h.
9325 (TIME_T_MIN, TIME_T_MAX): New macros.
9326 (time_overflow): Move earlier, to before first use.
9327 (hi_time, lo_time): New functions, for an accurate test for
9328 out-of-range times.
9329 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9330 (Fget_internal_run_time): Don't assume time_t fits in int.
9331 (make_time): Use list2 instead of Fcons twice.
9332 (Fdecode_time): More accurate test for out-of-range times.
9333 (check_tm_member): New function.
9334 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9335 (lisp_time_argument): Don't rely on undefined left-shift and
9336 right-shift behavior when checking for time stamp overflow.
8be6f318 9337
fe31d94c
PE
9338 * editfns.c (time_overflow): New function, refactoring common code.
9339 (Fformat_time_string, Fdecode_time, Fencode_time):
9340 (Fcurrent_time_string): Use it.
9341
8be6f318
PE
9342 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9343 * dired.c (make_time): Move to ...
9344 * editfns.c (make_time): ... here.
9345 * systime.h: Note the move.
9346
09d9db2c 93472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9348
126bc0dc
YM
9349 * fringe.c (update_window_fringes): Remove unused variables.
9350
c47cbdfd
YM
9351 * unexmacosx.c (copy_data_segment): Also copy __got section.
9352 (Bug#8223)
9353
7ac80be9
EZ
93542011-03-12 Eli Zaretskii <eliz@gnu.org>
9355
c96bbc66 9356 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9357 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9358 Constify `char *' arguments and their references according to
9359 prototypes in tparam.h.
9360
ecb0f94d 9361 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9362
7ac80be9
EZ
9363 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9364 Adapt all references accordingly.
9365
9366 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9367
ef1fd07e
TT
93682011-03-11 Tom Tromey <tromey@redhat.com>
9369
9370 * buffer.c (syms_of_buffer): Remove obsolete comment.
9371
7ef4b50c
EZ
93722011-03-11 Eli Zaretskii <eliz@gnu.org>
9373
9374 * termhooks.h (encode_terminal_code): Declare prototype.
9375
9376 * msdos.c (encode_terminal_code): Don't declare prototype.
9377
9378 * term.c (encode_terminal_code): Now external again, used by
9379 w32console.c and msdos.c.
9380
44f230aa
SM
9381 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9382 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9383
4b1ec863 93842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9385
1714f52b 9386 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9387
4b1ec863
PE
9388 * fringe.c (update_window_fringes): Mark locals as initialized
9389 (Bug#8227).
9390 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9391
524c7aa6
PE
9392 * alloc.c (mark_fringe_data): Move decl from here ...
9393 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9394 to check its interface.
9395 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9396
a5c0af81 9397 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9398 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9399 (fontset_font): Mark local as initialized.
a9a06e0b 9400 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9401
b4716021
PE
9402 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9403
811e9bac 9404 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9405 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9406 (x_own_selection, Fx_disown_selection_internal): Rename locals
9407 to avoid shadowing.
9408 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9409
7e3ab302
PE
9410 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9411 so that the caller can use some name other than gcpro1.
9412 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9413 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9414 (Fx_backspace_delete_keys_p):
9415 Use them to avoid shadowing, and rename vars to avoid shadowing.
9416 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9417 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9418 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9419 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9420 Remove unused locals.
7e3ab302
PE
9421 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9422 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9423 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9424 macros.
f78faa98 9425
e2b13473
PE
9426 * xterm.h (x_mouse_leave): New decl.
9427
77f23912
PE
9428 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9429 Remove unused functions.
cdf4ba58
PE
9430 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9431 (x_calc_absolute_position): Now static.
7411c686 9432 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9433 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9434 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9435 unless they are used.
38d0b34a
PE
9436 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9437 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9438 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9439 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9440 (x_error_catcher, x_connection_closed, x_error_handler):
9441 (x_error_quitter, xembed_send_message, x_iconify_frame):
9442 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9443 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9444 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9445
44f230aa
SM
9446 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9447 Rename or move locals to avoid shadowing.
6b463e58 9448 (tty_defined_color, merge_face_heights): Now static.
5967d051 9449 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9450 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9451 does not deduce is never used uninitialized.
73719eba
PE
9452 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9453 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9454
426994c3 9455 * terminal.c (store_terminal_param): Now static.
5489860b 9456
032f1620 9457 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9458 (set_frame_menubar): Remove unused local.
d4323972 9459 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9460 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9461 since they might point to immutable storage.
281585b0
PE
9462 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9463 since it's unused otherwise.
032f1620 9464
367c19e5 9465 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9466 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9467 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9468 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9469 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9470 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9471 does not deduce are never used uninitialized.
70739cbe 9472
07b48fa9
PE
9473 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9474
8868a238 9475 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9476 * window.c (window_loop, size_window):
9477 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9478
7e5cf297 9479 * window.c (display_buffer): Now static.
d6550a9f
PE
9480 (size_window): Mark variables that gcc -Wuninitialized
9481 does not deduce are never used uninitialized.
a586633d
PE
9482 * window.h (check_all_windows): New decl, to forestall
9483 gcc -Wmissing-prototypes diagnostic.
5b555da1 9484 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9485
f6095868
PE
9486 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9487 shadowing.
9488 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9489 Include <limits.h>.
9490 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9491 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9492 (load_charset_map): Mark variables that gcc -Wuninitialized
9493 does not deduce are never used uninitialized.
53df7c11 9494 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9495
f38b440c
PE
9496 * coding.c (coding_set_source, coding_set_destination):
9497 Use "else { /* comment */ }" rather than "else /* comment */;"
9498 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9499 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9500 a block, when the outer 'i' will do.
9501 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9502 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9503 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9504 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9505 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9506 Rename locals to avoid shadowing.
9507 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9508 * coding.c (emacs_mule_char, encode_invocation_designation):
9509 Now static, since they're not used elsewhere.
413bb2db 9510 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9511 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9512 (decode_coding_emacs_mule): Mark variables that gcc
9513 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9514 (detect_coding_iso_2022): Initialize a local variable that might
9515 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9516 this initialization is needed. (Bug#8211)
5f58e762
PE
9517 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9518 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9519 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9520 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9521 Remove unused macros.
f38b440c 9522
232b38b9 9523 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9524 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9525 * character.c (string_count_byte8): Likewise.
232b38b9 9526
fb90da1b
PE
9527 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9528 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9529
fb93dbc2
PE
9530 * chartab.c (copy_sub_char_table): Now static, since it's not used
9531 elsewhere.
5c156ace
PE
9532 (sub_char_table_ref_and_range, char_table_ref_and_range):
9533 Rename locals to avoid shadowing.
bbcd0949 9534 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9535
7d3b3862 9536 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9537 (BIDI_BOB): Remove unused macro.
7d3b3862 9538
6be7d3da
PE
9539 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9540 deduce are never used uninitialized.
c2ed9c8b 9541 * term.c (encode_terminal_code): Likewise.
6be7d3da 9542
75f8807f 9543 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9544
50938595
PE
9545 * tparam.h: New file.
9546 * term.c, tparam.h: Include it.
9547 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9548 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9549 Move these decls to tparam.h, and make them agree with what
9550 is actually in tparam.c. The previous trick of using incompatible
9551 decls in different modules does not conform to the C standard.
9552 All callers of tparam changed to use tparam's actual API.
9553 * tparam.c (tparam1, tparam, tgoto):
9554 Use const pointers where appropriate.
9555
fbceeba2
PE
9556 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9557 * cm.h (struct cm): Likewise.
9558 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9559 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9560 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9561 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9562 (turn_on_face, init_tty): Likewise.
9563 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9564
7f3f1250
PE
9565 * term.c (term_mouse_position): Rename local to avoid shadowing.
9566
e6ca6543
PE
9567 * alloc.c (mark_ttys): Move decl from here ...
9568 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9569
c40f8d15
AS
95702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9571
9572 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9573
cfe0661d
JB
95742011-03-09 Juanma Barranquero <lekktu@gmail.com>
9575
9576 * search.c (compile_pattern_1): Remove argument regp, unused since
9577 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9578 (compile_pattern): Don't pass it.
9579
0afb4571
J
95802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9581
9582 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9583 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9584 for ! HAVE_GTK3.
9585 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9586
9587 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9588
9589 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9590 gdk_window_get_screen, gdk_window_get_geometry,
9591 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9592 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9593 (xg_get_pixbuf_from_pixmap): New function.
9594 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9595 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9596 Call xg_get_pixbuf_from_pixmap instead of
9597 gdk_pixbuf_get_from_drawable.
9598 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9599 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9600 (xg_check_special_colors): Use GtkStyleContext and its functions
9601 for HAVE_GTK3.
9602 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9603 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9604 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9605 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9606 Call gtk_widget_get_preferred_size.
0afb4571
J
9607 (xg_frame_resized): gdk_window_get_geometry only takes 5
9608 parameters.
44f230aa
SM
9609 (xg_win_to_widget, xg_event_is_for_menubar):
9610 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9611 (xg_set_widget_bg): New function.
9612 (delete_cb): New function.
895009e1 9613 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9614 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9615 (xg_set_background_color): Call xg_set_widget_bg.
9616 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9617 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9618 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9619 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9620 if ! HAVE_GTK3.
9621 (update_frame_tool_bar): Call gtk_widget_hide.
9622 (xg_initialize): Use GDK_KEY_g.
9623
9624 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9625 if ! HAVE_GTK3
9626 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9627
9628 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9629 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9630 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9631
1c2cc4ef
JB
96322011-03-08 Juanma Barranquero <lekktu@gmail.com>
9633
9634 * w32xfns.c (select_palette): Check success of RealizePalette against
9635 GDI_ERROR, not zero.
9636
33383987 9637See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9638
9639;; Local Variables:
9640;; coding: utf-8
aac0c6e3
MR
9641;; End:
9642
acaf905b 9643 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9644
9645 This file is part of GNU Emacs.
9646
9647 GNU Emacs is free software: you can redistribute it and/or modify
9648 it under the terms of the GNU General Public License as published by
9649 the Free Software Foundation, either version 3 of the License, or
9650 (at your option) any later version.
9651
9652 GNU Emacs is distributed in the hope that it will be useful,
9653 but WITHOUT ANY WARRANTY; without even the implied warranty of
9654 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9655 GNU General Public License for more details.
9656
9657 You should have received a copy of the GNU General Public License
9658 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.