Fix bug #11035 with cursor positioning on overlay strings with newlines.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e50a24a2
EZ
12012-03-18 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4 that is not from display property, accept the row as a "cursor
5 row" if one of the string's character has a non-nil `cursor'
6 property. Fixes cursor positioning when there are newlines in
7 overlay strings, e.g. in icomplete.el. (Bug#11035)
8
9af5ed87
PE
92012-03-12 Paul Eggert <eggert@cs.ucla.edu>
10
11 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
12
d1f55f16
CY
132012-03-12 Chong Yidong <cyd@gnu.org>
14
15 * eval.c (inhibit_lisp_code): Rename from
16 inhibit_window_configuration_change_hook; move from window.c.
17
18 * xfns.c (unwind_create_frame_1, Fx_create_frame):
19 * window.c (run_window_configuration_change_hook)
20 (syms_of_window): Callers changed.
21
66c5eebd
CY
222012-03-11 Chong Yidong <cyd@gnu.org>
23
413df973
CY
24 * keymap.c (Fkey_description): Doc fix (Bug#9700).
25
66c5eebd
CY
26 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
27
1de11f56
CY
282012-03-10 Chong Yidong <cyd@gnu.org>
29
30 * frame.c (other_visible_frames): Don't assume the selected frame
31 is visible (Bug#10955).
32
cae07000
SM
332012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
34
35 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
36
89c94350
JD
372012-03-08 Jan Djärv <jan.h.d@swipnet.se>
38
39 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
40 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
41 zero (Bug#10954).
42
999dd333
GM
432012-03-03 Glenn Morris <rgm@gnu.org>
44
01a6dcc8 45 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 46
de0100f2
EZ
472012-03-02 Eli Zaretskii <eliz@gnu.org>
48
49 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
50 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
51 (redisplay_window, next_element_from_string): Fix typos in
52 comments.
3e441275
EZ
53 (redisplay_window): Pass to move_it_vertically the margin in
54 pixels, not in screen lines.
de0100f2 55
96a72ee9
GM
562012-03-02 Glenn Morris <rgm@gnu.org>
57
58 * buffer.c (buffer-list-update-hook): Doc fix.
59
312508d7
EZ
602012-02-29 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
63 push_it before setting up the iterator for the first overlay
64 string, even if we have an empty string loaded.
65 (next_overlay_string): If there's an empty string on the iterator
66 stack, pop the stack. (Bug#10903)
67
27f3c637
PE
682012-02-25 Paul Eggert <eggert@cs.ucla.edu>
69
70 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
71 Suggested by Stefan Monnier in
72 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
73 * alloc.c (widen_to_Lisp_Object): New static function.
74 (mark_memory): Also mark Lisp_Objects by fetching pointer words
75 and widening them to Lisp_Objects. This would work even if
76 USE_LSB_TAG is defined and wide integers are used, which might
77 happen in a future version of Emacs.
78
3c9dfce6
CY
792012-02-25 Chong Yidong <cyd@gnu.org>
80
fa74b241
CY
81 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
82 Doc fix.
83
3c9dfce6
CY
84 * xselect.c (Fx_selection_exists_p): Doc fix.
85 (x_clipboard_manager_save_all): Print an informative message
86 before saving to clipboard manager.
87
9486df08
CY
882012-02-24 Chong Yidong <cyd@gnu.org>
89
90 * keyboard.c (process_special_events): Handle all X selection
91 requests in kbd_buffer, not just the next one (Bug#8869).
92
f01d3321
CY
932012-02-23 Chong Yidong <cyd@gnu.org>
94
95 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
96 call when setting menu-bar-lines and tool-bar-lines parameters.
97 (unwind_create_frame_1): New helper function.
98
99 * window.c (inhibit_window_configuration_change_hook): New var.
100 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 101 (syms_of_window): Initialize it.
f01d3321 102
86b847b6
CY
1032012-02-22 Chong Yidong <cyd@gnu.org>
104
105 * xterm.c (x_draw_image_relief): Add missing type check for
106 Vtool_bar_button_margin (Bug#10743).
107
a59225b1
CY
1082012-02-21 Chong Yidong <cyd@gnu.org>
109
110 * fileio.c (Vfile_name_handler_alist): Doc fix.
111
112 * buffer.c (Fget_file_buffer): Protect against invalid file
113 handler return value.
114
310f5bd4
PE
1152012-02-20 Paul Eggert <eggert@cs.ucla.edu>
116
cb3a28cc
PE
117 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
118 when computing $valmask.
119
310f5bd4
PE
120 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
121 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
122 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
123 It's useless in that case, and it can cause problems on hosts
124 that allocate halves of EMACS_INT values separately.
125 Reported by Dan Horák. Diagnosed by Andreas Schwab in
126 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
127 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
128 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
129 it avoids undefined behavior on hosts where shifting right by more
130 than the word width has undefined behavior.
131
2375c96a
CY
1322012-02-19 Chong Yidong <cyd@gnu.org>
133
134 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
135 (Funhandled_file_name_directory, Ffile_name_as_directory)
136 (Fdirectory_file_name, Fexpand_file_name)
137 (Fsubstitute_in_file_name): Protect against invalid file handler
138 return values (Bug#10845).
139
3eb49e71
EZ
1402012-02-18 Eli Zaretskii <eliz@gnu.org>
141
142 * .gdbinit (pitx): Fix incorrect references to fields of the
143 iterator stack.
144
7b926f3f
CY
1452012-02-17 Chong Yidong <cyd@gnu.org>
146
147 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
148
11273115
PE
1492012-02-15 Paul Eggert <eggert@cs.ucla.edu>
150
151 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
152 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
153
c3a70e2b
CY
1542012-02-15 Chong Yidong <cyd@gnu.org>
155
156 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
157 marked as special. Also, starting docstrings with * is obsolete.
158
0ca43699
AS
1592012-02-13 Andreas Schwab <schwab@linux-m68k.org>
160
161 * gnutls.c (emacs_gnutls_write): Fix last change.
162
2e8f3c56
LI
1632012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
164
165 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
166 send_process.
167
af70074f
SM
1682012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
169
170 * keymap.c (Fsingle_key_description): Handle char ranges.
171
95986d52
CY
1722012-02-12 Chong Yidong <cyd@gnu.org>
173
afd83bd1
CY
174 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
175 as that creates a dangerous corner case.
176
95986d52
CY
177 * window.c (Fdelete_window_internal): Invalidate the mouse
178 highlight (Bug#9904).
179
bd7da63e
GM
1802012-02-12 Glenn Morris <rgm@gnu.org>
181
182 * xselect.c (Fx_own_selection_internal)
183 (Fx_get_selection_internal, Fx_disown_selection_internal)
184 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
185 * nsselect.m (Fx_own_selection_internal)
186 (Fx_disown_selection_internal, Fx_selection_exists_p)
187 (Fx_selection_owner_p, Fx_get_selection_internal):
188 Sync docs and argument specs with the xselect.c versions.
189
77abcbc2
LI
1902012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
191
192 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
193
90b671e2
EZ
1942012-02-11 Eli Zaretskii <eliz@gnu.org>
195
1c0ca0b7
EZ
196 * w32select.c (Fx_selection_exists_p): Sync doc string and
197 argument list with xselect.c. (Bug#10783)
198
199 * w16select.c (Fx_selection_exists_p): Sync doc string and
200 argument list with xselect.c. (Bug#10783)
90b671e2 201
49241268
GM
2022012-02-10 Glenn Morris <rgm@gnu.org>
203
204 * fns.c (Fsecure_hash): Doc fix.
205
f998bbe7 2062012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
207
208 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
209
0992bd9c
CY
2102012-02-07 Chong Yidong <cyd@gnu.org>
211
212 * buffer.c (Fbuffer_local_variables)
213 (buffer_lisp_local_variables): Handle unbound vars correctly;
214 don't let Qunbound leak into Lisp.
215
af008560
GM
2162012-02-07 Glenn Morris <rgm@gnu.org>
217
dd605cc4
GM
218 * image.c (Fimagemagick_types): Doc fix.
219
af008560
GM
220 * image.c (imagemagick-render-type): Change it from a lisp object
221 to an integer. Move the doc here from the lisp manual.
222 Treat all values not equal to 0 the same.
223
1449fa1d
CY
2242012-02-06 Chong Yidong <cyd@gnu.org>
225
226 * doc.c (store_function_docstring): Avoid applying docstring of
227 alias to base function (Bug#2603).
228
3723ec07
AS
2292012-02-04 Andreas Schwab <schwab@linux-m68k.org>
230
231 * .gdbinit (pp1, pv1): Remove redundant defines.
232 (pr): Use pp.
233
79c1cc1e
CY
2342012-02-04 Chong Yidong <cyd@gnu.org>
235
236 * nsterm.m: Declare a global (Bug#10694).
237
d7f29f8e
EZ
2382012-02-04 Eli Zaretskii <eliz@gnu.org>
239
cae07000
SM
240 * w32.c (get_emacs_configuration_options):
241 Include --enable-checking, if specified, in the return value.
d7f29f8e 242
3b95a6f9
MR
2432012-02-04 Martin Rudalics <rudalics@gmx.at>
244
245 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
246 after rounding frame sizes. (Bug#9723)
247
d6fa96a6
EZ
2482012-02-04 Eli Zaretskii <eliz@gnu.org>
249
250 * keyboard.c (adjust_point_for_property): Don't position point
251 before BEGV. (Bug#10696)
252
df0b2940
PE
2532012-02-03 Paul Eggert <eggert@cs.ucla.edu>
254
255 Handle overflow when computing char display width (Bug#9496).
256 * character.c (char_width): Return EMACS_INT, not int.
257 (char_width, c_string_width): Check for overflow when
258 computing the width; this is possible now that individual
259 characters can have unbounded width. Problem introduced
260 by merge from Emacs 23 on 2012-01-19.
261
6bee44d6
MA
2622012-02-02 Michael Albinus <michael.albinus@gmx.de>
263
264 * dbusbind.c (Fdbus_register_method): Mention the return value
265 :ignore in the docstring.
266
44f92739
GM
2672012-02-02 Glenn Morris <rgm@gnu.org>
268
1b9f60cc
GM
269 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
270
44f92739
GM
271 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
272 Unconditionally set to t. (Bug#10673)
273 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
274 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
275 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
276
c5d3843c
KH
2772012-02-02 Kenichi Handa <handa@m17n.org>
278
279 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
280 0, do not call append_composite_glyph.
281
159462d4 2822012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
283
284 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
285 NULL (Bug#6988).
286 (x_produce_glyphs): If the component of a composition is a null
287 string, set it->pixel_width to 1 to avoid zero-width glyph.
288
78cef877
EZ
2892012-02-01 Eli Zaretskii <eliz@gnu.org>
290
291 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
292 first 2 arguments are identical. This makes inserting large
293 output from a subprocess an order of magnitude faster on
294 MS-Windows, where all sbrk'ed memory is always contiguous.
295
97897668
GM
2962012-01-31 Glenn Morris <rgm@gnu.org>
297
298 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 299 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
300 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
301
31fd3586
GM
3022012-01-29 Glenn Morris <rgm@gnu.org>
303
304 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
305
0e24a8b2
CY
3062012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
307
308 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
309
cc0adcb0
CY
3102012-01-28 Chong Yidong <cyd@gnu.org>
311
312 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
313
acc28cb9
CY
3142012-01-26 Chong Yidong <cyd@gnu.org>
315
9c69cfb7
CY
316 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
317
acc28cb9
CY
318 * search.c (Fsearch_forward, Fsearch_backward): Document negative
319 repeat counts (Bug#10507).
320
48da7392
GM
3212012-01-26 Glenn Morris <rgm@gnu.org>
322
323 * lread.c (syms_of_lread): Doc fix.
324
14af5f7f
CY
3252012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
326
327 * coding.c (encode_designation_at_bol): Change return value to
328 EMACS_INT.
329
0b21c100
CY
3302012-01-25 Chong Yidong <cyd@gnu.org>
331
332 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
333
3c2907f7
CY
3342012-01-21 Chong Yidong <cyd@gnu.org>
335
336 * floatfns.c (Fcopysign): Make the second argument non-optional,
337 since nil is not allowed anyway.
338
959ad23f
AS
3392012-01-21 Andreas Schwab <schwab@linux-m68k.org>
340
341 * process.c (read_process_output): Use p instead of XPROCESS (proc).
342 (send_process): Likewise.
343
34a02f46
MR
3442012-01-19 Martin Rudalics <rudalics@gmx.at>
345
346 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
347 (Vwindow_persistent_parameters): Do not use Qstate.
348 Rewrite doc-strings.
34a02f46 349
1259009a 3502012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
351
352 * character.c (char_width): New function.
70d4fdf6
GM
353 (Fchar_width, c_string_width, lisp_string_width):
354 Use char_width (Bug#9496).
25ed9e61 355
6a6ee00d
MR
3562012-01-16 Martin Rudalics <rudalics@gmx.at>
357
358 * window.c (Vwindow_persistent_parameters): New variable.
359 (Fset_window_configuration, save_window_save): Handle persistent
360 window parameters.
361
c85efaf7
EZ
3622012-01-14 Eli Zaretskii <eliz@gnu.org>
363
364 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
365 thrashing the stack of the thread. (Bug#9087)
366
5944709e
PE
3672012-01-12 Paul Eggert <eggert@cs.ucla.edu>
368
369 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
370
e71f5d99
EZ
3712012-01-11 Eli Zaretskii <eliz@gnu.org>
372
373 * xdisp.c (rows_from_pos_range): Handle the case where the
374 highlight ends on a newline. (Bug#10464)
375 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
376 he end column for display of highlight that ends on a newline
377 before a R2L line.
378
ce316182
GM
3792012-01-11 Glenn Morris <rgm@gnu.org>
380
381 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
382 from load-path also when installation-directory is nil. (Bug#10208)
383
5b43da69
GM
3842012-01-10 Glenn Morris <rgm@gnu.org>
385
74cc8ff9
GM
386 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
387
7d8d6e4e
GM
388 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
389 Update template values to be closer to their typical values these days.
5b43da69 390
a0db8d43
EZ
3912012-01-09 Eli Zaretskii <eliz@gnu.org>
392
393 * xdisp.c (rows_from_pos_range): Accept additional argument
394 DISP_STRING, and accept any glyph in a row whose object is that
395 string as eligible for mouse highlight. Fixes mouse highlight of
396 display strings from overlays. (Bug#10464)
397
9a0115ab 3982012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 399
b9110d6a 400 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
401 * fileio.c (auto_saving_dir_umask): New static var.
402 (Fmake_directory_internal): Use it.
403 (do_auto_save_make_dir): Set it, instead of invoking chmod after
404 creating the directory. The old code temporarily assigns
405 too-generous permissions to the directory.
406 (do_auto_save_eh): Clear it.
b9110d6a 407 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
408 that the var is always cleared.
409
6c1bd3f3
EZ
4102012-01-07 Eli Zaretskii <eliz@gnu.org>
411
412 * search.c (scan_buffer): Pass character positions to
413 know_region_cache, not byte positions. (Bug#6540)
414
069d2b50
L
4152012-01-07 LynX <_LynX@bk.ru> (tiny change)
416
417 * w32.c (sys_rename): Report EXDEV when rename of a directory
418 fails because the target is on another logical disk. (Bug#10284)
419
75bf0d33
DB
4202012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
421
422 * xterm.c (x_embed_request_focus): New function.
423
424 * xterm.h: Add prototype.
425
426 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
427
1c6e5a32
GM
4282012-01-05 Glenn Morris <rgm@gnu.org>
429
430 * emacs.c (emacs_copyright): Update short copyright year to 2012.
431
651e947e
EZ
4322012-01-01 Eli Zaretskii <eliz@gnu.org>
433
434 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
435 Load gnutls_transport_set_lowat only if GnuTLS version is below
436 2.11.1.
437 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
438 GnuTLS versions below 2.11.1.
439
3778cdd8
AL
4402011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
441
442 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
443 to the doc string advising against its use for altering the way
444 windows are scrolled.
445
0e5317f7
KH
4462011-12-28 Kenichi Handa <handa@m17n.org>
447
448 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
449 coding-system ASCII compatible only when it does not produce BOM
450 on encoding (Bug#10383).
451
93d5ca1f
JD
4522011-12-26 Jan Djärv <jan.h.d@swipnet.se>
453
454 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
455 can scroll.
456 (create_and_show_popup_menu): Always use menu_position_func for
457 Gtk3 (Bug#10361).
458
ca22b785
AS
4592011-12-24 Andreas Schwab <schwab@linux-m68k.org>
460
461 * callint.c (Fcall_interactively): Don't truncate prompt string.
462
d048e1e6
EZ
4632011-12-23 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
466 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 467 resumed from there (after widening). (Bug#10360)
d048e1e6 468
5ccaba1f
JD
4692011-12-22 Jan Djärv <jan.h.d@swipnet.se>
470
471 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
472
204ee57f
JD
4732011-12-21 Jan Djärv <jan.h.d@swipnet.se>
474
b81d40f0
JB
475 * nsterm.m (x_free_frame_resources):
476 Release f->output_data.ns->miniimage.
204ee57f
JD
477 (ns_index_color): Fix indentation. Do not retain
478 color_table->colors[i].
479
480 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
481 before returning.
482
483 * nsfns.m (x_set_background_color): Assign return value from
484 ns_index_color to face-background instead of NSColor*.
485 (ns_implicitly_set_icon_type): Fix indentation.
486 Change assignment in for loop to comparison.
487
488 * emacs.c (ns_pool): New variable.
489 (main): Assign ns_pool.
490 (Fkill_emacs): Call ns_release_autorelease_pool.
491
492 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
493 autorelease fdesc, release fdAttrs and tdict.
494 (ns_get_covering_families): Release charset.
495 (ns_findfonts): Release NSFontDescriptor created with new.
496 (ns_uni_to_glyphs): Fix indentation.
497 (setString): Release attrStr before assigning new value.
498
c803b2b7
JD
4992011-12-18 Jan Djärv <jan.h.d@swipnet.se>
500
678f4426
JD
501 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
502 and NS_IMPL_COCOA.
503 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
504 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
505
cd394be1 5062011-12-18 David Reitter <reitter@cmu.edu>
678f4426 507
5fecd5fc
JD
508 * nsterm.m (ns_term_init): Subscribe for notifications
509 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
510 to method trackingNotification in EmacsMenu.
511
512 * nsmenu.m (trackingMenu): New variable.
3771cb17 513 (trackingNotification): New method (from Aquamacs).
5fecd5fc 514 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 515 from Aquamacs (Bug#7030).
678f4426
JD
516
5172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 518
c803b2b7
JD
519 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
520 (symbol_to_nsstring): Fix indentation.
521 (ns_symbol_to_pb): New function.
cae07000
SM
522 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
523 (Fns_rotate_cut_buffers_internal): Remove.
524 (Fns_store_selection_internal): Rename from
c803b2b7
JD
525 Fns_store_cut_buffer_internal.
526 (ns_get_foreign_selection, Fx_own_selection_internal)
527 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
528 (Fns_get_selection_internal, Fns_store_selection_internal):
529 Use ns_symbol_to_pb and check if return value is nil.
530 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
531 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
532 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
533 renamed to Sns_store_selection_internal.
534 (ns_handle_selection_request): Move code to Fx_own_selection_internal
535 and remove this function.
536 (ns_handle_selection_clear): Remove, never used.
537 (Fx_own_selection_internal): Move code from ns_handle_selection_request
538 here.
539
e1b01a3a
KB
5402011-12-17 Ken Brown <kbrown@cornell.edu>
541
542 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
543 GID is unknown (Bug#10257).
544
2adb6e85
PE
5452011-12-17 Paul Eggert <eggert@cs.ucla.edu>
546
547 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
548 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
549 which caused a build failure on GNU/Linux IA-64. This problem was
550 introduced by my 2011-10-07 patch.
551
d1d7b339
JL
5522011-12-15 Juri Linkov <juri@jurta.org>
553
554 * image.c (imagemagick_error): New function. (Bug#10112)
555 (imagemagick_load_image): Comment out `MagickSetResolution' call.
556 Use `imagemagick_error' where ImageMagick functions return
557 `MagickFalse'.
558 (Fimagemagick_types): Add `Fnreverse' to return the list in the
559 proper order.
560
100d5755
KH
5612011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
562
563 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
564 fill background (Bug#8992).
565
454592a6
MR
5662011-12-13 Martin Rudalics <rudalics@gmx.at>
567
568 * window.c (Vwindow_combination_resize)
569 (Vwindow_combination_limit): Use t instead of non-nil in
570 doc-strings.
61d4b438
MR
571 (Vrecenter_redisplay): Add first sentence of doc-string on
572 separate line.
53524d93 573 (Frecenter): Fix doc-string typo.
454592a6 574
3633e3aa
KH
5752011-12-11 Kenichi Handa <handa@m17n.org>
576
577 * coding.c (Funencodable_char_position): Pay attention to the
578 buffer text relocation (Bug#9389).
579
7b9d523a
JD
5802011-12-10 Jan Djärv <jan.h.d@swipnet.se>
581
582 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
583 gtk_init (Bug#10100).
584
b73189c6
EZ
5852011-12-10 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
588 IT->string is nil. (Bug#10263)
589
f7dfe5d6
JD
5902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
591
83faebb4
JD
592 * nsterm.h (x_free_frame_resources): Declare.
593
f7dfe5d6
JD
594 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
595 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
596
597 * nsterm.h (ns_get_defaults_value): Declare.
598
599 * nsterm.m (ns_default): Call ns_get_defaults_value.
600
7cd4e72c
EZ
6012011-12-09 Eli Zaretskii <eliz@gnu.org>
602
603 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
604 (Bug#10170)
605
b34d7317
YM
6062011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
607
608 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
609 that where the value of an _OBJC_* symbol points to is in the .bss
610 section (Bug#10240).
611
76470ad1
KH
6122011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
613
614 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 615 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 616
745fff94
KH
6172011-12-08 Kenichi Handa <handa@m17n.org>
618
619 * ftfont.c (get_adstyle_property): Fix previous change
620 (Bug#10233).
621
6e44397c
JB
6222011-12-07 Juanma Barranquero <lekktu@gmail.com>
623
624 * w32.c (init_environment): If no_site_lisp, remove site-lisp
625 dirs from the default value of EMACSLOADPATH (bug#10208).
626
7efa6272
GM
6272011-12-07 Glenn Morris <rgm@gnu.org>
628
629 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
630 installation and source directories as well. (Bug#10208)
631
f6fc4d87
CY
6322011-12-06 Chong Yidong <cyd@gnu.org>
633
634 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
635
2bf26180
GM
6362011-12-06 Glenn Morris <rgm@gnu.org>
637
638 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
639 as an error, not just -1. (Bug#10217)
640
3a6ad4f0
CY
6412011-12-05 Chong Yidong <cyd@gnu.org>
642
643 * keyboard.c (process_special_events): New function.
644 (swallow_events, Finput_pending_p): Use it (Bug#10195).
645
75a3b399
PE
6462011-12-05 Paul Eggert <eggert@cs.ucla.edu>
647
648 * coding.c (encode_designation_at_bol): Don't use uninitialized
649 local variable (Bug#9318).
650
c3c9e25e
KH
6512011-12-05 Kenichi Handa <handa@m17n.org>
652
653 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
654 return Qnil (Bug#8046, Bug#10193).
655
5eb05ea3
KH
6562011-12-05 Kenichi Handa <handa@m17n.org>
657
658 * coding.c (encode_designation_at_bol): New args charbuf_end and
659 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
660 (coding_set_source): Return how many bytes coding->source was
661 relocated.
662 (coding_set_destination): Return how many bytes
663 coding->destination was relocated.
664 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 665 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
666
6672011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
668
669 * coding.c (CODING_CHAR_CHARSET_P): New macro.
670 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
671 macro (Bug#9318).
672
6732011-12-05 Andreas Schwab <schwab@linux-m68k.org>
674
675 The following changes are to fix Bug#9318.
676
a79703f5 677 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
678 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
679 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 680 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 681
7dbda6df
JB
6822011-12-05 Juanma Barranquero <lekktu@gmail.com>
683
684 * lisp.h (process_quit_flag): Fix external declaration.
685
6d5eb5b0
SM
6862011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
687
688 Don't macro-inline non-performance-critical code.
689 * eval.c (process_quit_flag): New function.
690 * lisp.h (QUIT): Use it.
691
a0c3fad0
JD
6922011-12-04 Jan Djärv <jan.h.d@swipnet.se>
693
694 * nsfns.m (get_geometry_from_preferences): New function.
695 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
696
6c07aac2
AS
6972011-12-04 Andreas Schwab <schwab@linux-m68k.org>
698
699 * emacs.c (Qkill_emacs): Define.
700 (syms_of_emacs): Initialize it.
701 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
702 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
703 (quit_throw_to_read_char): Add parameter `from_signal'.
704 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
705 * lisp.h (QUIT): Call Fkill_emacs if requested.
706
c052ead4
JD
7072011-12-03 Jan Djärv <jan.h.d@swipnet.se>
708
709 * widget.c (update_wm_hints): Return if wmshell is null.
710 (widget_update_wm_size_hints): New function.
711
712 * widget.h (widget_update_wm_size_hints): Declare.
713
714 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
715 widget_update_wm_size_hints (Bug#10104).
716
9e49252b
EZ
7172011-12-03 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (handle_invisible_prop): If the invisible text ends just
720 before a newline, prepare the bidi iterator for consuming the
721 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 722 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 723
02b16839
JL
7242011-12-02 Juri Linkov <juri@jurta.org>
725
726 * search.c (Fword_search_regexp): New Lisp function created from
727 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
728 (Fword_search_backward, Fword_search_forward)
729 (Fword_search_backward_lax, Fword_search_forward_lax):
730 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
731 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
732
0068070e
SM
7332011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
734
735 * fileio.c (Finsert_file_contents): Move after-change-function call
736 to before the "handled:" label, since all "goto handled" appear in
737 cases where the *-change-functions have already been properly called
738 (bug#10117).
739
3360a3fc
AS
7402011-12-01 Andreas Schwab <schwab@linux-m68k.org>
741
742 * keyboard.c (interrupt_signal): Don't call kill-emacs when
743 waiting for input. (Bug#10169)
744
73d6c093
EZ
7452011-11-30 Eli Zaretskii <eliz@gnu.org>
746
747 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
748 verifies glyph row's hash code--we have just reallocated the
749 glyphs, so their contents can be complete garbage. (Bug#10164)
750
febe6bea
JB
7512011-11-30 Juanma Barranquero <lekktu@gmail.com>
752
753 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
754
801a4313
EZ
7552011-11-30 Eli Zaretskii <eliz@gnu.org>
756
757 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
758 attributes are tested _before_ calling verify_row_hash, to protect
759 against GCC re-ordering of the tests. (Bug#10164)
760
2b56b87e
JD
7612011-11-29 Jan Djärv <jan.h.d@swipnet.se>
762
763 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
764
765 * xterm.c (handle_one_xevent): Only set async_visible and friends
766 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 767 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
768 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
769
dbf31225
PE
7702011-11-28 Paul Eggert <eggert@cs.ucla.edu>
771
772 Remove GCPRO-related macros that exist only to avoid shadowing locals.
773 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
774 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
775 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
776 All uses changed to use GCPRO1 etc.
777 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
778 Revert to old implementation (i.e., before 2011-03-11).
779
1305621b
YM
7802011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
781
782 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
783 of scroll runs so as to avoid assigning disabled bogus rows and
784 unnecessary graphics copy operations.
785
8c9afb46
EZ
7862011-11-27 Eli Zaretskii <eliz@gnu.org>
787
788 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
789 (snprintf) [_MSC_VER]: Redirect to _snprintf.
790 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
791 (malloc, free, realloc, calloc): Redirect to e_* only when
792 compiling Emacs.
793
794 * lisp.h (GCTYPEBITS): Move before first use.
795 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
796 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
797 this macro definition.
798
799 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
800 _MSC_VER.
801
54e9e3bf
JD
8022011-11-27 Jan Djärv <jan.h.d@swipnet.se>
803
6d5eb5b0
SM
804 * gtkutil.c (xg_create_frame_widgets):
805 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
806 present with Gtk+ 2.0.
807
83aca1cb
PE
8082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
809
810 * fileio.c (Finsert_file_contents): Undo previous change; see
811 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
812
5b76caa4
PE
8132011-11-26 Paul Eggert <eggert@cs.ucla.edu>
814
815 Rename locals to avoid shadowing.
816 * fileio.c (Finsert_file_contents):
817 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
818 * process.c (wait_reading_process_output):
819 Rename inner 'proc' to 'p' to avoid shadowing.
820 Indent for consistency with usual Emacs style.
821
8c535114
EZ
8222011-11-25 Eli Zaretskii <eliz@gnu.org>
823
824 * xdisp.c (redisplay_window): If cursor row is not fully visible
825 after recentering, and scroll-conservatively is set to a large
826 number, scroll window by a few more lines to make the cursor fully
827 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
828 (start_display): Don't move to the next line if the display should
829 start at a newline that is part of a display vector or an overlay
830 string. (Bug#10119)
8c535114 831
fa4fdb5c
JL
8322011-11-24 Juri Linkov <juri@jurta.org>
833
834 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
835 after the `MagickPingImage' call. (Bug#10112)
836
90ec88df
CY
8372011-11-23 Chong Yidong <cyd@gnu.org>
838
839 * window.c (Fcoordinates_in_window_p): Accept only live windows.
840
56e2e794
MR
8412011-11-23 Martin Rudalics <rudalics@gmx.at>
842
843 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
844 making another buffer current. (Bug#10114)
845
b6e64c41
GM
8462011-11-23 Glenn Morris <rgm@gnu.org>
847
848 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
849
6b21de18
CY
8502011-11-23 Chong Yidong <cyd@gnu.org>
851
852 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
853 using it (Bug#5984).
854
b12cd789
EZ
8552011-11-22 Eli Zaretskii <eliz@gnu.org>
856
857 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
858 and header-lines, as they don't have one computed for them.
859 (Bug#10098)
860
861 * .gdbinit (prow): Make displayed values more self-explaining.
862 Add row's hash code.
863
261b6fd4
LMI
8642011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
865
866 * process.c (wait_reading_process_output): Fix asynchrounous
867 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 868 (wait_reading_process_output): Add comment and URL.
261b6fd4 869
e7cfd277
JD
8702011-11-21 Jan Djärv <jan.h.d@swipnet.se>
871
872 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
873
a9b9b7f5
CY
8742011-11-21 Chong Yidong <cyd@gnu.org>
875
876 * window.c (Fnext_window, Fprevious_window): Doc fix.
877
b0d15b4f
SM
8782011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
879
880 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
881
fe7a3057
JB
8822011-11-20 Juanma Barranquero <lekktu@gmail.com>
883
884 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
885
d2999b1a
MR
8862011-11-20 Martin Rudalics <rudalics@gmx.at>
887
888 * window.c (Fset_window_combination_limit): Rename argument
889 STATUS to LIMIT.
890 (Vwindow_combination_limit): Remove "status" from doc-string.
891
d5ff9cd0
AS
8922011-11-20 Andreas Schwab <schwab@linux-m68k.org>
893
894 * m/ibms390.h: Remove.
895 * m/ibms390x.h: Don't include "ibms390.h".
896
a5bb9bd3
SM
8972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
898
899 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
900 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
901
cd1181db
JB
9022011-11-20 Juanma Barranquero <lekktu@gmail.com>
903
904 * casetab.c (Fset_case_table):
905 * charset.c (Fcharset_after): Fix typos.
906
615a3b8d 9072011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 908
17e845af
PE
909 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
910 Otherwise, valgrind does not work on some platforms.
911 Problem reported by Andreas Schwab in
6a0bf43d
PE
912 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
913 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
914 is set, removing the need for VIRT_ADDRESS_VARIES.
915 (PURE_P): Use a more-efficient implementation that needs just one
916 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
917 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
918 to 4 (xorl, subq, cmpq, setbe).
919 * alloc.c (pure): Always extern now, since that's the
920 VIRT_ADDR_VARIES behavior.
921 (PURE_POINTER_P): Use a single comparison, not two, for
922 consistency with the new puresize.h.
923 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
924 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
925 Remove VIRT_ADDR_VARIES no longer needed.
926
f8fe6f96
EZ
9272011-11-19 Eli Zaretskii <eliz@gnu.org>
928
929 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
930 (erase_phys_cursor, update_window_cursor, show_mouse_face)
931 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
932 behave as if the cursor position were at the window margin.
933
934 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
935 and the cursor position is out of bounds, behave as if the cursor
936 position were at the window margin. (Bug#10075)
937
df05a53c
CY
9382011-11-18 Chong Yidong <cyd@gnu.org>
939
940 * window.c (Fwindow_combination_limit): Make first argument
941 non-optional, since it is meaningless for live windows like the
942 selected window.
943
2071918e
DA
9442011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
945
946 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
947
b50a28de
SM
9482011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
949
950 * intervals.c: Fix grafting over the whole buffer (bug#10071).
951 (graft_intervals_into_buffer): Simplify.
952
015137db
EZ
9532011-11-18 Eli Zaretskii <eliz@gnu.org>
954
955 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
956 hash values of the two rows.
957 (copy_row_except_pointers): Preserve the used[] arrays and the
958 hash values of the two rows. (Bug#10035)
68c95424 959 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
960
961 * xdisp.c (row_hash): New function, body extracted from
962 compute_line_metrics.
963 (compute_line_metrics): Call row_hash, instead of computing the
964 hash code inline.
965
966 * dispnew.c (verify_row_hash): Call row_hash for computing the
967 hash code of a row, instead of duplicating code from xdisp.c.
968
969 * dispextern.h (row_hash): Add prototype.
970
a2addb04
TH
9712011-11-18 Tassilo Horn <tassilo@member.fsf.org>
972
973 * frame.c (delete_frame): Don't delete the terminal when the last
974 X frame is closed if emacs is built with GTK toolkit.
975
df85d315
JB
9762011-11-17 Juanma Barranquero <lekktu@gmail.com>
977
978 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
979
a0c2d0ae
MR
9802011-11-17 Martin Rudalics <rudalics@gmx.at>
981
982 * window.c (Vwindow_splits): Rename to
983 Vwindow_combination_resize. Suggested by Juri Linkov.
984 (Fsplit_window_internal): Use Vwindow_combination_resize instead
985 of Vwindow_splits.
986
58179cce
JB
9872011-11-16 Juanma Barranquero <lekktu@gmail.com>
988
7877f373
JB
989 * nsfns.m (Fns_font_name):
990 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 991
b6f67890
MR
9922011-11-16 Martin Rudalics <rudalics@gmx.at>
993
994 * window.h (window): Rename slot "nest" to "combination_limit".
995 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
996 (Fset_window_nest): Rename to Fset_window_combination_limit.
997 (Vwindow_nest): Rename to Vwindow_combination_limit.
998 (recombine_windows, make_parent_window, make_window)
999 (Fsplit_window_internal, saved_window)
1000 (Fset_window_configuration, save_window_save): Rename all
1001 occurrences of window_nest to window_combination_limit.
1002
c7015153
JB
10032011-11-15 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * image.c (imagemagick_load_image): Fix typo.
1006
322ad6ec
EZ
10072011-11-14 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (display_line): Move the call to
1010 highlight_trailing_whitespace before the call to
1011 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1012 faces of all the glyphs to compute ROW's hash value.
1013 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1014
f067b8ec
JB
10152011-11-14 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1018 just return (bug#10044).
1019
1e5b2111
EZ
10202011-11-12 Eli Zaretskii <eliz@gnu.org>
1021
7ef3cbd5
EZ
1022 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1023 with user-defined heap size. Bump the default size of the temacs
1024 heap to 27MB, to avoid memory warning when running temacs.
1025 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1026
1e5b2111
EZ
1027 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1028 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1029 (verify_row_hash) [XASSERTS]: New function.
1030 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1031 that the hash value of glyph rows is correct.
1e5b2111 1032
89d61221
MR
10332011-11-12 Martin Rudalics <rudalics@gmx.at>
1034
1035 * window.h (window): Remove splits slot.
1036 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1037 (Fdelete_other_windows_internal, make_parent_window)
1038 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1039 (Fset_window_configuration, save_window_save): Don't deal with
1040 split status of windows.
1041 (saved_window): Remove splits slot.
1042 (Vwindow_splits): Rewrite doc-string.
1043
97f18cc8
JD
10442011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * xfns.c (unwind_create_frame):
1047 * nsfns.m (unwind_create_frame):
1048 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1049 Vframe_list (Bug#9999).
1050
22a648b4
DA
10512011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1052
0b381c7e 1053 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1054
659afede
KH
10552011-11-11 Kenichi Handa <handa@m17n.org>
1056
1057 * callproc.c (Fcall_process): Set the member dst_multibyte of
1058 process_coding.
1059
9ac0394b
KH
10602011-11-11 Johan Bockgård <bojohan@gnu.org>
1061
1062 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1063 avoid a crash (bug#9496).
1064
2fbdc249
CY
10652011-11-09 Chong Yidong <cyd@gnu.org>
1066
1067 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1068 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1069
ac6b1f81
PE
10702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1073
09db192c
PE
10742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1075
1076 Avoid some portability problems by eschewing 'extern inline' functions.
1077 The trivial performance wins aren't worth the portability hassles; see
1078 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1079 et seq.
1080 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1081 (window_box_width, window_box_left, window_box_left_offset)
1082 (window_box_right, window_box_right_offset): Undo previous change,
1083 by removing the "extern"s.
1084 * intervals.c (adjust_intervals_for_insertion)
1085 (adjust_intervals_for_deletion): Undo previous change,
1086 making these static again.
1087 (offset_intervals, temp_set_point_both, temp_set_point)
1088 (copy_intervals_to_string): No longer inline.
1089 * xdisp.c (window_text_bottom_y, window_box_width)
1090 (window_box_height, window_box_left_offset)
1091 (window_box_right_offset, window_box_left, window_box_right)
1092 (window_box): No longer inline.
1093
105216ed
CY
10942011-11-08 Chong Yidong <cyd@gnu.org>
1095
1096 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1097 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1098 Signal an error if not a live window.
105216ed
CY
1099 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1100 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1101
ae9e237f
JB
11022011-11-07 Juanma Barranquero <lekktu@gmail.com>
1103
1104 * lisp.h (syms_of_abbrev): Remove declaration.
1105 Reported by CHENG Gao <chenggao@royau.me>.
1106
c7aa8333
EZ
11072011-11-07 Eli Zaretskii <eliz@gnu.org>
1108
1109 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1110 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1111 of temacs in GUI mode.
1112
be7f5545
MR
11132011-11-07 Martin Rudalics <rudalics@gmx.at>
1114
1115 * window.h: Declare delete_all_child_windows instead of
1116 delete_all_subwindows.
1117 * window.c (Fwindow_nest, Fset_window_nest)
1118 (Fset_window_new_total, Fset_window_new_normal)
1119 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1120 (delete_all_subwindows): Rename to delete_all_child_windows.
1121 (Fdelete_other_windows_internal, Fset_window_configuration):
1122 Call delete_all_child_windows instead of delete_all_subwindows.
1123 * frame.c (delete_frame): Call delete_all_child_windows instead
1124 of delete_all_subwindows.
1125
ca78dc43
PE
11262011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1129 This is also needed for porting to any host where GC_MARK_STACK is
1130 not GC_MAKE_GCPROS_NOOPS.
1131 (which_symbols): Use it.
1132
a0241d01
KH
11332011-11-07 Kenichi Handa <handa@m17n.org>
1134
1135 * coding.c (coding_set_destination): Check coding->src_pos only
1136 when coding->src_object is a buffer (bug#9910).
1137
1138 * process.c (send_process): Set the member src_multibyte of coding
1139 to 0 (bug#9911) when sending a unibyte text.
1140
1141 * callproc.c (Fcall_process): Set the member src_multibyte of
1142 process_coding to 0 (bug#9912).
1143
a64bfdfa 11442011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1145
1146 * xmenu.c (cleanup_widget_value_tree): New function.
1147 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1148 calling free_menubar_widget_value_tree directly (Bug#9830).
1149
cb41b32a
PE
11502011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Fix some portability problems with 'inline'.
1153 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1154 (window_box_width, window_box_left, window_box_left_offset)
1155 (window_box_right, window_box_right_offset): Declare extern.
1156 Otherwise, these inline functions do not conform to C99 and
1157 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1158 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1159 * intervals.c (adjust_intervals_for_insertion)
1160 (adjust_intervals_for_deletion): Now extern, because otherwise the
1161 extern inline functions 'offset_intervals' couldn't refer to it.
1162 (static_offset_intervals): Remove.
1163 (offset_intervals): Rewrite using the old contents of
1164 static_offset_intervals. The old version didn't conform to C99
1165 because an extern inline function contained a reference to an
1166 identifier with static linkage.
1167
b7041366
AS
11682011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1169
1170 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1171 GC.
1172
88a37c4d
EZ
11732011-11-06 Eli Zaretskii <eliz@gnu.org>
1174
1175 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1176 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1177 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1178 return Qleft_to_right.
1179
49745b39
CY
11802011-11-06 Chong Yidong <cyd@gnu.org>
1181
1182 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1183 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1184 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1185 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1186 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1187 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1188 (Fwindow_vscroll): Doc fix.
1189 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1190 argument, since it makes no sense to pass a live window and for
1191 consistency with window-child.
1192
1f05cd82
CS
11932011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1194
1195 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1196 support MSVC.
1197
22610910
JR
11982011-11-05 Jason Rumney <jasonr@gnu.org>
1199
1200 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1201 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1202 fonts (Bug#6029).
1203 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1204 bitwise arithmetic preventing use of unicode-sip and non-truetype
1205 opentype fonts.
1206
a06776b2
EZ
12072011-11-05 Eli Zaretskii <eliz@gnu.org>
1208
3ad924ba
EZ
1209 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1210 "emacs"-only part.
1211
a06776b2
EZ
1212 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1213 initialization code to keep similarity to xfns.c after changes
1214 from 2011-11-05.
1215
c9e7db78
JD
12162011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1217
a97f8f3f
JD
1218 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1219 (unwind_create_frame): New function (Bug#9943).
1220 (Fx_create_frame): Restructure code to be more similar to the one in
1221 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1222 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1223 Move terminal->reference_count++ just before making the frame official
1224 (Bug#9943).
1225
1226 * nsterm.m (x_free_frame_resources): New function.
1227 (x_destroy_window): Move code to x_free_frame_resources.
1228
c9e7db78 1229 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1230 (Fx_create_frame, x_create_tip_frame):
1231 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1232 official. Move initialization of image_cache_refcount and
1233 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1234
a6fc3b5c
EZ
12352011-11-05 Eli Zaretskii <eliz@gnu.org>
1236
1237 Support MSVC build with newer versions of Visual Studio.
1238 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1239 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1240 nt/gmake.defs.
1241
1242 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1243 which are not supported by MSVC.
1244 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1245 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1246 bitfields.
1247 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1248 types in bitfields.
1249 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1250
1251 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1252
58179cce 12532011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1254
1255 Support MSVC build with newer versions of Visual Studio.
1256 * w32.c: Don't include w32api.h for MSVC.
1257 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1258
1259 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1260 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1261 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1262 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1263 e_* cousins.
1264 (alloca) [_MSC_VER]: Define to _alloca.
1265
1266 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1267
1268 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1269
a58c13ed
EZ
12702011-11-04 Eli Zaretskii <eliz@gnu.org>
1271
1272 * xdisp.c (note_mouse_highlight): If either of
1273 previous/next-single-property-change returns nil, treat that as
1274 the beginning or the end of the buffer. (Bug#9955)
1275
fe0b6370
JD
12762011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1277
a58c13ed 1278 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1279 label is not null (Bug#9951).
1280 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1281 may be NULL.
1282
89bd5ee1
EZ
12832011-11-04 Eli Zaretskii <eliz@gnu.org>
1284
1285 * window.c (Fwindow_body_size): Mention in the doc string that the
1286 return value is in frame's canonical units. (Bug#9949)
1287
84c3edb9
EZ
12882011-11-03 Eli Zaretskii <eliz@gnu.org>
1289
4e2fb5c7
EZ
1290 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1291
84c3edb9 1292 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1293 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1294 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1295
bc17a887
EZ
12962011-11-01 Eli Zaretskii <eliz@gnu.org>
1297
1298 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1299 Don't stop backward scan on the continuation glyph, even though
1300 its CHARPOS is positive.
6d5eb5b0
SM
1301 (mouse_face_from_buffer_pos, note_mouse_highlight):
1302 Rename cover_string to disp_string.
bc17a887 1303
4ee88440
MR
13042011-11-01 Martin Rudalics <rudalics@gmx.at>
1305
1306 * window.c (temp_output_buffer_show): Don't use
1307 Vtemp_buffer_show_specifiers.
1308 (Vtemp_buffer_show_specifiers): Remove unused variable.
1309
c2ff3c02
EZ
13102011-10-30 Eli Zaretskii <eliz@gnu.org>
1311
1312 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1313 past the beginning of the current glyph matrix.
1314
58179cce 13152011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1316
1317 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1318 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1319 HAVE_GTK3 (Bug#9869).
b77a6a7f 1320
3b574623
JD
1321 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1322 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1323
b77a6a7f
JD
1324 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1325
1326 * xterm.c: Declare x_handle_net_wm_state to return int.
1327 (handle_one_xevent): Check if we are iconified but don't have
1328 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1329 (get_current_wm_state): Return non-zero if not hidden,
1330 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1331 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1332 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1333 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1334
196e41e4
PE
13352011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1336
1337 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1338 so that this new function doesn't get optimized away by a
1339 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1340
021f2e1a
AS
13412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1342
1343 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1344
8b058d44
EZ
13452011-10-29 Eli Zaretskii <eliz@gnu.org>
1346
1347 Fix the `xbytecode' command.
1348 * .gdbinit (xprintbytestr): New command.
b50a28de 1349 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1350 (xbytecode): Print the byte-code string as well.
1351
4452fb80
EZ
13522011-10-29 Kim Storm <storm@cua.dk>
1353
8b058d44
EZ
1354 * alloc.c (which_symbols): New function.
1355
21b72067
AS
13562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1357
1358 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1359 line. (Bug#9903)
1360
83ed7b5c
GM
13612011-10-29 Glenn Morris <rgm@gnu.org>
1362
1363 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1364 Not clear what it was for, and it causes various bugs. (Bug#9839)
1365
5a7a728b
EZ
13662011-10-28 Eli Zaretskii <eliz@gnu.org>
1367
1368 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1369 possible random value that matches one of those tested as
1370 condition to clear the mouse face.
1371
d3d0842f
CY
13722011-10-28 Chong Yidong <cyd@gnu.org>
1373
1374 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1375
31b39d13
DN
13762011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1377
1378 * window.c (make_window): Initialize phys_cursor_on_p.
1379
9aba6043
SM
13802011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1381
1382 * lisp.h (struct Lisp_Symbol): Update comments.
1383
c20992f4
JB
13842011-10-28 Juanma Barranquero <lekktu@gmail.com>
1385
1386 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1387
db4f02f2
EZ
13882011-10-28 Eli Zaretskii <eliz@gnu.org>
1389
1390 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1391 <oslsachem@gmail.com> for helping to debug this.
1392
1393 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1394 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1395 (g_b_init_get_glyph_outline_w): New static variables.
1396 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1397 (GetGlyphOutlineW_Proc): New typedefs.
1398 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1399 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1400 New functions.
1401 (w32font_open_internal, compute_metrics):
1402 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1403 instead of calling the "wide" APIs directly.
1404
1405 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1406
1407 * w32.h (syms_of_w32font): Add prototype.
1408
87e68db4
JB
14092011-10-27 Juanma Barranquero <lekktu@gmail.com>
1410
1411 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1412 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1413 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1414 (Fmove_to_window_line): Doc fix.
1415
435c1d67
CY
14162011-10-27 Chong Yidong <cyd@gnu.org>
1417
1418 * process.c (make_process): Set gnutls_state to NULL.
1419
1420 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1421 non-NULL, regardless of GNUTLS_INITSTAGE.
1422 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1423 an error. Set process slots as soon as we allocate them.
1424
1425 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1426
9c6c6f49
CY
14272011-10-27 Chong Yidong <cyd@gnu.org>
1428
9aba6043
SM
1429 * gnutls.c (emacs_gnutls_deinit): New function.
1430 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1431 (Fgnutls_deinit, Fgnutls_boot): Use it.
1432
1433 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1434 (deactivate_process): Call emacs_gnutls_deinit.
1435
657d08d3
JB
14362011-10-27 Juanma Barranquero <lekktu@gmail.com>
1437
1438 * image.c (x_create_x_image_and_pixmap):
1439 * w32.c (sys_rename, w32_delayed_load):
1440 * w32font.c (fill_in_logfont):
1441 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1442
5430d399
JB
14432011-10-26 Juanma Barranquero <lekktu@gmail.com>
1444
1445 * w32fns.c (w32_default_color_map): New function,
1446 extracted from Fw32_default_color_map.
a7ef684b 1447 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1448
fe0055fa
PE
14492011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1452
e6346438
SM
14532011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1454
1455 * keyboard.c (test_undefined): New function (bug#9751).
1456 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1457
e112cc37
ET
14582011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1459
1460 * sysdep.c (init_sys_modes): Fix the check for the controlling
1461 terminal (Bug#6649).
1462
7b5d6677
EZ
14632011-10-20 Eli Zaretskii <eliz@gnu.org>
1464
1465 * dispextern.h (struct bidi_it): New member next_en_type.
1466
1467 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1468 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1469 current character, check also for next_en_type being WEAK_EN.
1470 (bidi_resolve_weak): Don't enter the expensive loop if the current
1471 position is before next_en_pos. Record the bidi type of the first
1472 non-ET, non-BN character we find, in addition to its position.
1473 (bidi_level_of_next_char): Invalidate next_en_type when
1474 next_en_pos is over-stepped.
1475
7da0b018
PE
14762011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1477
1478 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1479 * editfns.c: Rewrite current-time-zone so that it invokes
1480 the equivalent of (format-time-string "%Z") to get the time zone name.
1481 This fixes a bug when the time zone name contains characters that
1482 need converting from the system time locale to Emacs internal format.
1483 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1484 that patch fixed format-time-string to do the conversion, but
1485 I forgot to fix current-time-zone.
1486 (format_time_string): New function, containing most of
1487 what Fformat_time_string used to contain.
1488 (Fformat_time_string): Rewrite in terms of format_time_string.
1489 This doesn't change this function's behavior.
1490 (current-time-zone): Rewrite to use format_time_string.
1491 This fixes the bug reported by Michael Schierl in
1492 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1493 Jason Rumney's 2007-06-07 change worked around this bug, but
1494 didn't fix it.
1495 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1496
8547b010
EZ
14972011-10-19 Eli Zaretskii <eliz@gnu.org>
1498
1499 * xdisp.c (start_display): If the character at POS is displayed
1500 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1501 (try_window_reusing_current_matrix): If a line ends in a display
1502 vector or the next line starts in a display vector, continue
1503 redrawing the window even though the character position of
1504 start_row was reached.
8547b010
EZ
1505 (Bug#9771, part 2)
1506
4e948d15
CY
15072011-10-18 Chong Yidong <cyd@gnu.org>
1508
1509 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1510 with nobreak-char-display too.
1511
4787455f
EZ
15122011-10-18 Eli Zaretskii <eliz@gnu.org>
1513
1514 Fix part 3 of bug#9771.
1515 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1516 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1517 non-neutral characters if the current character is a paragraph
1518 separator (a.k.a. Newline). This avoids running the same
1519 expensive loop twice, once when we consume the preceding newline
1520 and the other time when the line actually needs to be displayed.
1521 Avoid the loop when we see neutrals on the base embedding level
1522 following a character whose directionality is the same as the
1523 paragraph's. This avoids running the expensive loop when a line
1524 ends in a long sequence of neutrals, like control characters.
1525 Add assertion against STRONG_AL type. Slightly rearrange code
1526 that determines the type of a neutral given the first non-neutral
1527 that follows it.
1528 (bidi_level_of_next_char): Set next_en_pos to zero when
1529 invalidating its info.
1530
2c91f553
EZ
15312011-10-17 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (push_display_prop): Determine whether to record string
1534 or buffer position by IT->string, not by IT->method. Allow
1535 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1536 (move_it_vertically_backward): Don't look for character position
1537 immediately after the newline when in a continuation line.
1538 (Bug#9771, part 1)
2c91f553 1539
c7b08b0d
MR
15402011-10-15 Martin Rudalics <rudalics@gmx.at>
1541
1542 * window.c (coordinates_in_window): Rewrite and delabelize
1543 vertical border check. (Bug#5357) (Bug#9618)
1544
6b02f655
SM
15452011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1546
1547 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1548 errors in XSetWindowBorder (bug#9310).
1549
81d40c92
DA
15502011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1553 avoid crash when xmalloc overrun checking is enabled.
1554
d4172c3b
EZ
15552011-10-13 Eli Zaretskii <eliz@gnu.org>
1556
1557 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1558 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1559 cursor motion with <left> and <right> arrow keys.
1560
1561 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1562 some callers set that themselves.
1563
b00eea75
EZ
15642011-10-12 Eli Zaretskii <eliz@gnu.org>
1565
1566 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1567 display string and the previous row comes from the same string and
1568 is empty. (Bug#9739) (Bug#9738)
1569
8fe012c4
SM
15702011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * doc.c (get_doc_string): Encode file name (bug#9735).
1573
0074aef2
EZ
15742011-10-12 Eli Zaretskii <eliz@gnu.org>
1575
79beb178
EZ
1576 * bidi.c (bidi_level_of_next_char):
1577 * xdisp.c (get_visually_first_element): Remove old incorrect
1578 comments regarding the Unicode Line Separator character.
1579
0074aef2
EZ
1580 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1581
6e4b3fbe
DA
15822011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1583
1584 * alloc.c (Fgc_status): Do not access beyond zombies array
1585 boundary if nzombies > MAX_ZOMBIES.
1586 * alloc.c (dump_zombies): Add missing format specifier.
1587
0324f3af
PE
15882011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1589
b5525cac
PE
1590 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1591 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1592
0324f3af
PE
1593 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1594 Some packages use them to denote characters with modifiers.
1595
e9b5f888
AS
15962011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1597
1598 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1599 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1600 matching a pp-number. Rename parameter var to var1.
1601
127827c0
SM
16022011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1603
1604 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1605
c8fd3bd0
GM
16062011-10-08 Glenn Morris <rgm@gnu.org>
1607
1608 * callint.c (Fcall_interactively): Give a more explicit error for the
1609 'c' case with a non-character input. (Bug#8479)
1610
352ec8ff
EZ
16112011-10-08 Eli Zaretskii <eliz@gnu.org>
1612
03669ccb
EZ
1613 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1614 lines.
7061c986
EZ
1615 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1616 lines that are hscrolled on the left.
03669ccb 1617
352ec8ff
EZ
1618 * dispnew.c (buffer_posn_from_coords): Account for a possible
1619 presence of header-line. (Bug#4426)
1620
a66cfb1c
SM
16212011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1622
6b02f655
SM
1623 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1624 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1625
7c5ee88e
PE
16262011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1629 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1630 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1631 this makes Emacs dump core during garbage collection on rare
1632 occasions. sizeof is obviously inferior to offsetof here, so
1633 stick with offsetof.
1634 (GC_POINTER_ALIGNMENT): New macro.
1635 (mark_memory): Omit 3rd (offset) arg; caller changed.
1636 Don't assume EMACS_INT alignment is the same as pointer alignment.
1637
df1bbe5b
SM
16382011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1639
1640 * keyboard.c (read_key_sequence_remapped): New var.
1641 (read_key_sequence): Compute remapping in the right buffer.
1642 (command_loop_1): Use read_key_sequence's remapping directly.
1643
51553db6
SM
16442011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1645
32c1fffd
SM
1646 * dired.c (file_name_completion): Don't expand file name.
1647 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1648 before checking file name handler.
1649
51553db6
SM
1650 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1651 they've been requested explicitly (bug#9591).
1652
b6bd1599 16532011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1654
1655 * keymap.c (Fsingle_key_description): Use make_specified_string
1656 instead of build_string to build string from push_key_description.
1657 (Bug#5193)
1658
f701dc2a
PE
16592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1660
4222c55d
PE
1661 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1662 This fixes a Y2038 bug on 64-bit hosts.
1663 * buffer.c (reset_buffer):
1664 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1665 (Fclear_buffer_auto_save_failure):
1666 Use 0, not -1, to represent an unset failure time, since time_t
1667 might not be signed.
1668
f701dc2a
PE
1669 Remove dependency on glibc malloc internals.
1670 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1671 Move back here from lisp.h, but with their new implementations.
1672 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1673 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1674 * charset.c (charset_table_init): New static var.
1675 (syms_of_charset): Use it instead of xmalloc. This removes a
1676 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1677 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1678 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1679 Move back to alloc.c.
1680 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1681 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1682
9ceebf39
JD
16832011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * nsterm.m (windowDidResize): Call x_set_window_size only when
1686 ns_in_resize is true. Otherwise set pixelwidth/height and
1687 call change_frame_size (Bug#9628).
1688
cb993c58
PE
16892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1690
3930c88b
PE
1691 Port --enable-checking=all to Fedora 14 x86-64.
1692 * charset.c (syms_of_charset): Also account for glibc malloc's
1693 internal overhead when calculating the initial malloc maximum.
1694
cb993c58
PE
1695 Port --enable-checking=all to Fedora 14 x86.
1696 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1697 Move to lisp.h.
1698 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1699 (overrun_check_realloc, overrun_check_free):
1700 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1701 That way, xmalloc returns a properly-aligned pointer even if
1702 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1703 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1704 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1705 into account when calculating the initial malloc maximum.
1706 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1707 Move here from alloc.c, so that charset.c can use it too.
1708 Properly align; the old code wasn't right for common 32-bit hosts
1709 when configured with --enable-checking=all.
1710 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1711 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1712
31bed486
EZ
17132011-09-29 Eli Zaretskii <eliz@gnu.org>
1714
04c70788 1715 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1716 use EDOM.
1717
fbcaa2f3
EZ
17182011-09-28 Eli Zaretskii <eliz@gnu.org>
1719
1720 * xdisp.c (compute_display_string_end): If there's no display
1721 string at CHARPOS, return -1.
1722
1723 * bidi.c (bidi_fetch_char): When compute_display_string_end
1724 returns a negative value, treat the character as a normal
1725 character not covered by a display string. (Bug#9624)
1726
a239d4e9
JB
17272011-09-28 Juanma Barranquero <lekktu@gmail.com>
1728
1729 * lread.c (Fread_from_string): Fix typo in docstring.
1730
88652fd5
EZ
17312011-09-27 Eli Zaretskii <eliz@gnu.org>
1732
1733 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1734 newline, reseat the iterator instead of bidi-iterating there one
1735 character at a time. (Bug#9610)
32c1fffd
SM
1736 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1737 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1738
ed497dd4
AS
17392011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1740
1741 * lread.c (readevalloop): Use correct code for NBSP.
1742 (read1): Likewise. (Bug#9608)
1743
b2bf61aa
MA
17442011-09-25 Michael Albinus <michael.albinus@gmx.de>
1745
1746 * dbusbind.c (Fdbus_register_signal): When service is not
1747 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1748
32bbb17c
GM
17492011-09-25 Glenn Morris <rgm@gnu.org>
1750
1751 * buffer.c (truncate-lines): Doc fix.
1752
94e0933e
CY
17532011-09-24 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1756 (Fset_window_next_buffers): Doc fix.
1757
cddde921
GM
17582011-09-24 Glenn Morris <rgm@gnu.org>
1759
1760 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1761
1260aef1
PE
17622011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1763
25b4bfa0
PE
1764 Fix minor problems found by static checking.
1765 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1766 * indent.c (Fvertical_motion): Fix == vs = typo.
1767
e3cbd34b
EZ
17682011-09-24 Eli Zaretskii <eliz@gnu.org>
1769
a66cfb1c
SM
1770 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1771 Default value is now t. Doc fix.
6bf7006f 1772
e3cbd34b 1773 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1774 logic when moving up, not only when moving down. Fix the
e3cbd34b 1775 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1776 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1777
1778 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1779 CHARPOS is covered by a display string which includes newlines.
1780 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1781 is covered by a display string with embedded newlines.
1782
a3de0cbd
MA
17832011-09-24 Michael Albinus <michael.albinus@gmx.de>
1784
1785 * dbusbind.c (Fdbus_register_signal): Add match rule to
1786 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1787 (Fdbus_register_method, Vdbus_registered_objects_table):
1788 Fix docstring.
a3de0cbd 1789
b260039d
JM
17902011-09-24 Jim Meyering <meyering@redhat.com>
1791
32c1fffd 1792 do not ignore write error for any output size
b260039d
JM
1793 The previous change was incomplete.
1794 While it makes emacs --batch detect the vast majority of stdout
1795 write failures, errors were still ignored whenever the output size is
1796 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1797 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1798 && echo FAIL: ignored write error
1799 FAIL: ignored write error
1800 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1801 && echo FAIL: ignored write error
1802 FAIL: ignored write error
1803 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1804
8eca8a7c
AS
18052011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1806
1807 * emacs.c (Fkill_emacs): In noninteractive mode exit
1808 non-successfully if a write error occurred on stdout. (Bug#9574)
1809
3341db62
EZ
18102011-09-21 Eli Zaretskii <eliz@gnu.org>
1811
1812 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1813 the xassert test.
1814
1815 * dispextern.h (struct it): Update the comment documenting what
1816 can it->OBJECT be.
1817
8c203dbf
EZ
18182011-09-20 Eli Zaretskii <eliz@gnu.org>
1819
1820 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1821 a display string, extend search for cursor position to end of row.
1822 (find_row_edges): If the row ends in a newline from a display
1823 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1824 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1825 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1826 non-empty line. Fixes confusing cursor motion with arrow keys at
1827 the beginning of a line that starts with whitespace.
8c203dbf 1828
a4824228
LMI
18292011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1830
1831 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1832 (bug#9493).
1833
33ed493b
CY
18342011-09-18 Chong Yidong <cyd@stupidchicken.com>
1835
1836 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1837 boolean (Bug#9154).
1838
56cd55c8
EZ
18392011-09-18 Eli Zaretskii <eliz@gnu.org>
1840
1841 * xdisp.c (display_line): Record maximum and minimum buffer
1842 positions even if no glyphs were produced (e.g., by a zero-width
1843 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1844 buffer positions that will be removed from the glyph row because
1845 they don't fit.
c02dcedf
EZ
1846 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1847 column is beyond frame width: don't subtract 1 "pixel" when
1848 computing width of the stretch.
3e62b7e0
EZ
1849 (reseat_at_next_visible_line_start): Undo the change made on
1850 2011-09-17 that saved paragraph information and restored it after
1851 the call to `reseat'. (Bug#9545)
56cd55c8 1852
5ed99d36 18532011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1854
1855 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1856 and turn window cursor on if cleared (Bug#9415).
1857
5ed99d36 18582011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1859
1860 * search.c (boyer_moore): Take unibyte characters from pattern
1861 literally. (Bug#9458)
1862
9bade7b2
EZ
18632011-09-18 Eli Zaretskii <eliz@gnu.org>
1864
1865 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1866
e5e9d610
PE
18672011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1868
87e4427a
PE
1869 Fix minor problem found by static checking.
1870 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1871 initialized, to pacify gcc -Wuninitialized.
1872
e5e9d610
PE
1873 * fileio.c: Report proper errno when syscall falls.
1874 (Finsert_file_contents): Save and restore errno,
1875 so that report_file_error outputs the correct diagnostic.
1876 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1877
a1674f0b
EZ
18782011-09-18 Eli Zaretskii <eliz@gnu.org>
1879
1880 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1881
fbfb6dd4
EZ
18822011-09-17 Eli Zaretskii <eliz@gnu.org>
1883
1884 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1885 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1886
bb187662
EZ
18872011-09-17 Eli Zaretskii <eliz@gnu.org>
1888
1137e8b8 1889 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1890 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1891
1892 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1893 (bidi_find_paragraph_start): Search back for paragraph beginning
1894 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1895 (bidi_move_to_visually_next): Only trigger paragraph-related
1896 computations when the last character is a newline or at EOB, not
1897 just any NEUTRAL_B. (Bug#9470)
1898
bb187662
EZ
1899 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1900 truncated lines if point is covered by a display string. (Bug#9524)
1901
2e621251
PE
19022011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1905 (cons_to_x_long): New function.
1906 (lisp_data_to_selection_data): Use it. Correct the test for
1907 short-versus-long data; it was negated. Break out of vector
1908 loop, for efficiency, when a long datum is discovered.
1909
91a15bc6
SM
19102011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1911
1912 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1913
b41c3a35
EZ
19142011-09-16 Eli Zaretskii <eliz@gnu.org>
1915
1916 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1917 GCC PR/17406) by declaring this function with external scope.
1918
7812ba2d
PE
19192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1922 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1923
cf7edc2a
AS
19242011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1925
1926 * editfns.c (Fformat): Correctly handle text properties on "%%".
1927
bd01620e
EZ
19282011-09-15 Eli Zaretskii <eliz@gnu.org>
1929
1930 * xterm.c (x_draw_composite_glyph_string_foreground):
1931 * w32term.c (x_draw_composite_glyph_string_foreground):
1932 * term.c (encode_terminal_code):
1933 * composite.c (composition_update_it, get_composition_id):
1934 * xdisp.c (get_next_display_element)
1935 (fill_composite_glyph_string): Add comments about special meaning
1936 of TAB characters in a composition.
1937
a02719a3
PE
19382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1939
1940 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1941 This occurs when processing a multibyte format.
1942 Problem reported by Wolfgang Jenker.
a02719a3 1943
72589a3c
JB
19442011-09-15 Johan Bockgård <bojohan@gnu.org>
1945
1946 * xdisp.c (try_cursor_movement): Only check for exact match if
1947 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1948
1c14176c
PE
19492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1950
1951 Remove unused external symbols.
1952 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1953 * xdisp.c (calc_pixel_width_or_height): Now static.
1954 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1955 * indent.c (check_display_width):
1956 * w32term.c: Fix comment to match code.
1957 * xterm.c, xterm.h (x_catching_errors): Remove.
1958
d2eea5b5
PE
19592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 * xselect.c: Use signed conversions more consistently (Bug#9498).
1962 (selection_data_to_lisp_data): Assume incoming selection data are
1963 signed integers, not unsigned. This is to be consistent with
1964 outgoing selection data, which was modified to use signed integers
1965 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1966 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1967 expects long, not unsigned long.
1968
46888499
EZ
19692011-09-14 Eli Zaretskii <eliz@gnu.org>
1970
1971 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1972 computation of loop end. Reported by Johan Bockgård
1973 <bojohan@gnu.org>.
1974
ef8ef9fb
CY
19752011-09-13 Chong Yidong <cyd@stupidchicken.com>
1976
1977 * frame.c (Fother_visible_frames_p): Function deleted.
1978
fa819fed
EZ
19792011-09-12 Eli Zaretskii <eliz@gnu.org>
1980
1981 * indent.c (compute_motion): Process display vector front to back
1982 rather than the other way around. (Bug#2496)
1983
2ba8e008
SM
19842011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1985
1986 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1987
20f53c69
CY
19882011-09-11 Chong Yidong <cyd@stupidchicken.com>
1989
1990 * minibuf.c (Fread_from_minibuffer): Doc fix.
1991
d562d7a4
EZ
19922011-09-11 Eli Zaretskii <eliz@gnu.org>
1993
1994 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1995 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1996
1c4d7f3d
LMI
19972011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1998
1999 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2000 value for non-existent files.
2001
b885bf36
EZ
20022011-09-11 Eli Zaretskii <eliz@gnu.org>
2003
2004 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2005 set its "size" to -1. This will set the modtime_size field of
2006 the corresponding buffer to -1, which is what
2007 verify-visited-file-modtime expects for files that do not exist.
2008 (Bug#9139)
2009
6612f0bf
PE
20102011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2013 here ...
2014 * lisp.h: ... from here. push_key_description is no longer
2015 defined in keyboard.c, so its declaration should not be in
2016 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2017 logically belongs with push_key_description.
2018
dfb3f755
PE
20192011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2020
2021 * buffer.h: Include <sys/types.h> instead of <time.h>.
2022 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2023 Problem reported by Herbert J. Skuhra.
2024
3134906c
LMI
20252011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2026
2027 * xml.c (parse_region): Make the parsing work for
2028 non-comment-starting XML files again (bug#9144).
2029
8d903f4e
AS
20302011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2031
2032 * image.c (gif_load): Fix calculation of bottom and right corner.
2033 (Bug#9468)
2034
80ad64f4
EZ
20352011-09-10 Eli Zaretskii <eliz@gnu.org>
2036
2037 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2038 redisplay in small windows.
2039
208a048d
EZ
20402011-09-09 Eli Zaretskii <eliz@gnu.org>
2041
2042 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2043
9b1c252e
MR
20442011-09-08 Martin Rudalics <rudalics@gmx.at>
2045
2046 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2047 Operate on live windows only.
2048
2949f33b
JB
20492011-09-08 Juanma Barranquero <lekktu@gmail.com>
2050
2051 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2052
e08dcafd
EZ
20532011-09-07 Eli Zaretskii <eliz@gnu.org>
2054
2055 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2056 only under bidi iteration.
2057
115b96bd
JD
20582011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2059
2060 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2061
c8199d0f
PE
20622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2063
2064 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2065 Without this fix, the command to link temacs failed due to an
2066 undefined symbol __builtin_isnan. This is because
2067 /usr/include/iso/math_c99.h #defines isnan(x) to
2068 __builtin_isnan(x), but the bundled gcc, which identifies itself
2069 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2070 a __builtin_isnan.
2071 * floatfns.c (isnan): #undef, and then #define to a clone of
2072 what's in data.c.
2073 (Fisnan): Always define, since it's always available now.
2074 (syms_of_floatfns): Always define isnan at the Lisp level.
2075
e39b275c 20762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2077
2078 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2079
b2db44d9 20802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2081
f4af5137 2082 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2083 The previous code assumed that file offsets (off_t values) fit in
2084 EMACS_INT variables, which is not true on typical 32-bit hosts.
2085 The code messed up by falsely reporting buffer overflow in cases
2086 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2087 when "big" contains more than 2**29 bytes, even though this
2088 inserts just one byte and does not overflow the buffer.
2089 (Finsert_file_contents): Store file offsets as off_t
2090 values, not as EMACS_INT values. Check for overflow when
2091 converting between EMACS_INT and off_t. When checking for
2092 buffer overflow or for overlap, take the offsets into account.
2093 Don't use EMACS_INT for small values where int suffices.
2094 When checking for overlap, fix a typo: ZV was used where
2095 ZV_BYTE was intended.
2096 (Fwrite_region): Don't assume off_t fits into 'long'.
2097 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2098
ecfc0a49
MA
20992011-09-05 Michael Albinus <michael.albinus@gmx.de>
2100
2101 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2102
6511acf2 21032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2104
0999621a 2105 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2106
2107 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2108 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2109 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2110 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2111 (modify_event_symbol): Do not assume that the length of
2112 name_alist_or_stem is safe to alloca and fits in int.
2113 (Fexecute_extended_command): Likewise for function name and binding.
2114 (Frecursion_depth): Wrap around reliably on integer overflow.
2115 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2116 since some callers pass EMACS_INT values.
2117 (Fsingle_key_description): Don't crash if symbol name contains more
2118 than MAX_ALLOCA bytes.
2119 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2120 (get_minibuffer): Arg is now EMACS_INT, not int.
2121 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2122 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2123 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2124
2be7d702
PE
2125 * dbusbind.c (signature_cat): New function.
2126 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2127 Do not overrun buffer; instead, report string overflow.
2128
9d1df220
PE
2129 * dispnew.c (add_window_display_history): Don't overrun buffer.
2130 Truncate instead; this is OK since it's just a log.
2131
33ef5c64
PE
2132 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2133 even if the time zone offset is outlandishly large.
2134 Don't mishandle offset == INT_MIN.
2135
66c6fdd5
PE
2136 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2137 when creating daemon; the previous buffer-overflow check was incorrect.
2138
d749b01b
PE
2139 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2140 which has the guts of the old verror function.
2141
b5cd1905
PE
2142 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2143 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2144
6e1a67fb
PE
2145 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2146 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2147 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2148 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2149 length of string rather than counting it via multiple sprintfs;
2150 that's simpler and more reliable.
c21721cc
PE
2151 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2152 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2153 sprintf, in case result does not fit in int.
2154
c57b67fc
PE
2155 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2156 (fontset_from_font): Print it.
2157
8a401434
PE
2158 * frame.c (tty_frame_count): Now printmax_t, not int.
2159 (make_terminal_frame, set_term_frame_name): Print it.
2160 (x_report_frame_params): In X, window IDs are unsigned long,
2161 not signed long, so print them as unsigned.
2162 (validate_x_resource_name): Check for implausibly long names,
2163 and don't assume name length fits in 'int'.
2164 (x_get_resource_string): Don't blindly alloca invocation name;
2165 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2166 not fit in int.
2167
6e1a67fb
PE
2168 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2169 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2170 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2171
0df02bf3
PE
2172 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2173 Use esprintf, not sprintf, in case result does not fit in int.
2174
48e30793
PE
2175 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2176 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2177 it as a large positive number.
2178 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2179 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2180
a66ff6d8
PE
2181 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2182 in case result does not fit in int.
2183
aca216ff
PE
2184 * print.c (float_to_string): Detect width overflow more reliably.
2185 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2186 buffer overrun. Don't assume list length fits in 'int'. Treat
2187 print length of 0 as 0, not as infinity; to be consistent with other
2188 uses of print length in this function. Don't overflow print length
2189 index. Don't assume hash table size fits in 'long', or that
2190 vectorlike size fits in 'unsigned long'.
2191
31c286f7
PE
2192 * process.c (make_process): Use printmax_t, not int, to format
2193 process-name gensyms.
2194
55e5faa1
PE
2195 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2196
80f2e268
PE
2197 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2198 to avoid potential buffer overrun.
2199
670741ab
PE
2200 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2201 if X resource line is longer than 512 bytes.
2202
b7163a50
PE
2203 * xfns.c (x_window): Make sprintf buffer a bit bigger
2204 to avoid potential buffer overrun.
2205
ae58ff1f
PE
2206 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2207
c43c8a6a
PE
2208 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2209
3f8236f4
PE
22102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2211
53e9fe90 2212 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2213 Without these, Emacs silently mishandles large integers sometimes.
2214 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2215 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2216
6511acf2
PE
2217 * xdisp.c (try_window_id): Check Emacs fixnum range before
2218 converting to 'int'.
806add1d 2219
6511acf2 2220 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2221 Check that an Emacs fixnum is in range before assigning it to 'int'.
2222 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2223 values converted from Emacs fixnums.
2224 (Frecenter): Don't wrap around a line count if it is out of 'int'
2225 range; instead, treat it as an extreme value.
2226 (Fset_window_configuration, compare_window_configurations):
2227 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2228
6511acf2
PE
2229 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2230 that can exceed INT_MAX. Check that EMACS_INT value is in range
2231 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2232 (match_limit): Don't assume that a fixnum can fit in 'int'.
2233
6511acf2 2234 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2235 exceed INT_MAX.
2236
6511acf2 2237 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2238 (Fvertical_motion): Don't wrap around LINES values that don't fit
2239 in 'int'. Instead, treat them as extreme values. This is good
2240 enough for windows, which can't have more than INT_MAX lines anyway.
2241
fcb901a7
LMI
22422011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2243
0f2f6b6d
LMI
2244 * Require libxml/parser.h to avoid compilation warning.
2245
fcb901a7
LMI
2246 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2247
2248 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2249 since this reportedly can destroy thread storage.
2250
6e20a0d4
CY
22512011-08-30 Chong Yidong <cyd@stupidchicken.com>
2252
2253 * syntax.c (find_defun_start): Update all cache variables if
2254 exiting early (Bug#9401).
2255
148ae00e
EZ
22562011-08-30 Eli Zaretskii <eliz@gnu.org>
2257
f6cfbd8f
EZ
2258 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2259
148ae00e
EZ
2260 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2261 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2262 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2263
2264 * term.c (tty_append_glyph): New function.
2265 (produce_stretch_glyph): Static function and its prototype deleted.
2266
a66cfb1c
SM
2267 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2268 Add prototypes.
148ae00e 2269
c4a07a4c
PE
22702011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2271
2272 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2273 when checking :margin (Bug#9390).
2274 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2275 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2276 so that the name doesn't mislead. All uses changed.
2277
6bc8cd65
JB
22782011-08-28 Johan Bockgård <bojohan@gnu.org>
2279
2280 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2281 set_tty_hooks.
2282
dca4927e
EZ
22832011-08-27 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (move_it_to): Don't bail out early when reaching
2286 position beyond to_charpos, if we are scanning backwards.
2287 (move_it_vertically_backward): When DY == 0, make sure we get to
2288 the first character in the line after the newline.
2289
f2cad773
PE
22902011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2291
2292 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2293 (ccl_driver): Do not generate an out-of-range pointer.
2294 (Fccl_execute_on_string): Remove unnecessary check for
2295 integer overflow, noted by Stefan Monnier in
2296 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2297 Remove a FIXME that didn't need fixing.
2298 Simplify the newly-introduced buffer reallocation code.
2299
0cae2cdb
JB
23002011-08-27 Juanma Barranquero <lekktu@gmail.com>
2301
2302 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2303
5fc295a4 23042011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2305
70c60eb2 2306 Integer and memory overflow issues (Bug#9196).
726e0ab1 2307
d31850da
PE
2308 * doc.c (get_doc_string): Rework so that
2309 get_doc_string_buffer_size is the actual buffer size, rather than
2310 being 1 less than the actual buffer size; this makes xpalloc more
2311 convenient.
2312
a69fbedb
PE
2313 * image.c (x_allocate_bitmap_record, cache_image):
2314 * xselect.c (Fx_register_dnd_atom):
2315 Simplify previous changes by using xpalloc.
2316
fe5c5d37
PE
2317 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2318 since either will do and ptrdiff_t is convenient with xpalloc.
2319
0065d054
PE
2320 * charset.c (charset_table_size)
2321 (struct charset_sort_data.priority): Now ptrdiff_t.
2322 (charset_compare): Don't overflow if priorities differ greatly.
2323 (Fsort_charsets): Don't assume list length fits in int.
2324 Check for size-calculation overflow when allocating sort data.
2325 (syms_of_charset): Allocate an initial charset table that is
2326 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2327
2328 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2329
2330 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2331 The actual value is always <= INT_MAX, and leaving it unsigned made
2332 overflow checking harder.
2333
2334 * dispextern.h (struct glyph_matrix.rows_allocated)
2335 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2336 with xpalloc. The values are still always <= INT_MAX.
2337
2338 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2339
2340 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2341 (SAFE_NALLOCA): New macro.
2342
2343 * region-cache.c (struct boundary.pos, find_cache_boundary)
2344 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2345 (set_cache_region, invalidate_region_cache)
2346 (revalidate_region_cache, know_region_cache, region_cache_forward)
2347 (region_cache_backward, pp_cache):
2348 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2349 so that ptrdiff_t * can be passed to xpalloc.
2350 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2351 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2352 (pp_cache): Don't assume cache_len fits in int.
2353 * region-cache.h: Adjust extern decls to match.
2354
2355 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2356 EMACS_INT, since either will do, for xpalloc.
2357
2358 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2359 (xnmalloc, xnrealloc, xpalloc): New functions.
2360
726e0ab1
PE
2361 * bidi.c (bidi_shelve_header_size): New constant.
2362 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2363 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2364
51f30bc5 2365 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2366 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2367 (overlay_strings):
2368 Don't update size of array until after memory allocation succeeds,
2369 because xmalloc/xrealloc may not return.
0065d054
PE
2370 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2371 now that we have proper integer overflow checking.
2372 (record_overlay_string, overlay_strings): Catch overflows when
2373 calculating size of overlay_str_buf.
726e0ab1 2374
0065d054
PE
2375 * callproc.c (Fcall_process): Check for size overflow when
2376 calculating size of args2.
2377 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2378 Normally we prefer signed values, but sticking with ptrdiff_t would
2379 require adding more-complicated checks.
726e0ab1
PE
2380
2381 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2382 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2383 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2384 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2385
2386 * character.c (Fstring): Check for size-calculation overflow.
2387
2388 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2389 unnecessary integer overflow. Check for size overflow.
2390 (encode_coding_object): Don't update size until xmalloc succeeds.
2391
2392 * composite.c (get_composition_id): Check for overflow in glyph
2393 length calculations.
2394
2395 Integer and memory overflow fixes for display code.
2396 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2397 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2398 (scrolling_window): Check for overflow in size calculations.
2399 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2400 Don't assume glyph table len fits in int.
2401 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2402 (row_table_size): Now ptrdiff_t, not int.
2403 (scrolling_window): Avoid overflow in size calculations.
2404 Don't update size until allocation succeeds.
2405 * fns.c (concat): Check for overflow in size calculations.
2406 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2407 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2408 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2409
2410 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2411 (get_doc_string): Check for size calculation overflow.
2412 Don't update size until allocation succeeds.
2413 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2414 EMACS_INT, where ptrdiff_t will do.
2415 (Fsubstitute_command_keys): Check for string overflow.
2416
2417 * editfns.c (set_time_zone_rule): Don't assume environment length
2418 fits in int.
2419 (message_length): Now ptrdiff_t, not int.
2420 (Fmessage_box): Don't update size until allocation succeeds.
2421 Don't assume message length fits in int.
2422 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2423
0065d054
PE
2424 * emacs.c (main): Do not reallocate argv, since there is a null at
2425 the end that can be overwritten, and this way there's no need to
2426 worry about size-calculation overflow.
2427 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2428
2429 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2430 alloc succeeds.
2431 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2432
2433 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2434 (x_set_scroll_bar_width, x_figure_window_size):
2435 Check for integer overflow.
2436 (x_set_alpha): Do not assume XINT fits in int.
2437
2438 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2439 This is for the members text_lines, text_cols, total_lines, total_cols,
2440 where the system imposes an 'int' limit.
2441
2442 * fringe.c (Fdefine_fringe_bitmap):
2443 Don't update size until alloc works.
2444
2445 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2446 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2447
2448 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2449 Check for size-calculation overflow.
2450 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2451 do, as we prefer signed integers.
2452 (id_to_widget.max_size, id_to_widget.used)
2453 (xg_store_widget_in_map, xg_remove_widget_from_map)
2454 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2455 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2456 Use and return ptrdiff_t, not int.
2457 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2458 * gtkutil.h: Change prototypes to match the above.
2459
2460 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2461 are duplicate now that they've been promoted to lisp.h.
2462 (x_allocate_bitmap_record, x_alloc_image_color)
2463 (make_image_cache, cache_image, xpm_load):
2464 Don't update size until alloc is done.
2465 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2466 (x_detect_edges):
3256efce 2467 Check for size calculation overflow.
726e0ab1
PE
2468 (ct_colors_allocated_max): New constant.
2469 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2470 overflow.
3256efce 2471
726e0ab1
PE
2472 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2473 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2474 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2475 Use ptrdiff_t, not int, to count maps.
2476 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2477 calculations. Don't update size until allocation succeeds.
2478 Redo calculations to avoid overflow.
726e0ab1
PE
2479 * keyboard.h: Change prototypes to match the above.
2480
2481 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2482 to count maps.
2483 (current_minor_maps): Check for size calculation overflow.
2484 * keymap.h: Change prototypes to match the above.
2485
2486 * lread.c (read1, init_obarray): Don't update size until alloc done.
2487
2488 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2489 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2490
726e0ab1
PE
2491 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2492 Now ptrdiff_t, not int.
2493 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2494 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2495
2496 * process.c (Fnetwork_interface_list): Check for overflow
2497 in size calculation.
2498
2499 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2500
2501 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2502 overflow. Don't bother calling xmalloc when xrealloc will do.
2503
2504 * search.c (Freplace_match): Check for size calculation overflow.
2505 (Fset_match_data): Don't assume list lengths fit in 'int'.
2506
2507 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2508 for command line length. Do not attempt to address one before the
2509 beginning of an array, as that's not portable.
2510
2511 * term.c (max_frame_lines): Remove; unused.
2512 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2513 not int.
2514 (encode_terminal_code, calculate_costs): Check for size
2515 calculation overflow.
2516 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2517 table lengths and related sizes. Don't update size until alloc
2518 done. Redo calculations to avoid overflow.
2519 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2520
2521 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2522 subtracting pointers.
2523 (gobble_line): Check for overflow more carefully. Don't update size
2524 until alloc done.
2525
2526 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2527 Don't update size until alloc done.
2528 Redo size calculations to avoid overflow.
2529 Check for size calculation overflow.
0065d054 2530 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2531
2532 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2533 Use ptrdiff_t, not int, for sizes.
2534 (store_mode_line_noprop_char): Don't update size until alloc done.
2535
0065d054
PE
2536 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2537 Use ptrdiff_t, not int, for sizes.
2538 (Finternal_make_lisp_face, cache_face):
2539 Check for size calculation overflow.
2540 (cache_face): Treat size calculation overflows as if they were
2541 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2542
2543 * xfns.c (x_encode_text, x_set_name_internal)
2544 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2545 sizes, since they can exceed INT_MAX in size. Check for size
2546 calculation overflow.
2547
0065d054
PE
2548 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2549 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2550 Don't update size until alloc done.
2551
0065d054 2552 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2553 as sprintf is limited to int lengths.
1d526e2f 2554
252c5ee1
PE
2555 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2556 (X_LONG_MIN): New macros.
864d7ce7
PE
2557 Use them to make the following changes clearer.
2558 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2559 This change doesn't affect the value now, but it may help remind
2560 future maintainers not to raise the value too much later.
2561 (SELECTION_QUANTUM): Remove, replacing with ...
2562 (selection_quantum): ... new function, which avoids overflow.
2563 All uses changed.
2564 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2565 assumption that selection length fits in 'int'.
2566 (x_reply_selection_request, x_handle_selection_request)
2567 (x_get_window_property, receive_incremental_selection)
2568 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2569 (lisp_data_to_selection_data, clean_local_selection_data):
2570 Use ptrdiff_t, not int, to record length of selection.
2571 (x_reply_selection_request, x_get_window_property)
2572 (receive_incremental_selection, x_property_data_to_lisp):
2573 Redo calculations to avoid overflow.
2574 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2575 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2576 something.
2577 (x_get_window_property, receive_incremental_selection)
2578 (lisp_data_to_selection_data, x_property_data_to_lisp):
2579 Check for size-calculation overflow.
2580 (x_get_window_property, receive_incremental_selection)
2581 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2582 Don't store size until memory allocation succeeds.
2583 (x_get_window_property): Plug memory leak on memory exhaustion.
2584 Don't double-block input; malloc is safe here. Don't assume 2**34
2585 - 4 fits in unsigned long. Add an xassert to check
2586 XGetWindowProperty overflow. Be more careful about overflow
2587 calculations, and distinguish size from memory overflow better.
2588 (receive_incremental_selection): When tracing, don't assume
2589 unsigned int is less than INT_MAX.
2590 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2591 harmful) conversions of unsigned short to int.
2592 (lisp_data_to_selection_data): Don't assume that integers
2593 in the range -65535 through -1 fit in an X unsigned short.
2594 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2595 result parameters unless successful. Rely on cons_to_unsigned
2596 to report problems with elements; the old code wasn't right anyway.
2597 (x_check_property_data): Check for int overflow; we cannot use
2598 a wider type due to X limits.
2599 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2600
726e0ab1 2601 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2602
0065d054
PE
2603 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2604 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2605 (x_color_cells): Don't store size until memory allocation succeeds.
2606 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2607 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2608 (x_term_init): Don't assume length fits in int (sprintf is limited
2609 to int size).
bc18e09d 2610
ebfa62c0
PE
2611 Use ptrdiff_t for composition IDs.
2612 * character.c (lisp_string_width):
2613 * composite.c (composition_table_size, n_compositions)
2614 (get_composition_id, composition_gstring_from_id):
2615 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2616 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2617 * window.c (Frecenter):
2618 Use ptrdiff_t, not int, for composition IDs.
2619 * composite.c (get_composition_id): Check for integer overflow.
2620 * composite.h: Adjust prototypes to match the above changes.
2621
d3411f89
PE
2622 Use ptrdiff_t for hash table indexes.
2623 * category.c (hash_get_category_set):
2624 * ccl.c (ccl_driver):
2625 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2626 * coding.c (coding_system_charset_list, detect_coding_system):
2627 * coding.h (struct coding_system.id):
2628 * composite.c (get_composition_id, gstring_lookup_cache):
2629 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2630 * image.c (xpm_get_color_table_h):
2631 * lisp.h (hash_lookup, hash_put):
2632 * minibuf.c (Ftest_completion):
2633 Use ptrdiff_t for hash table indexes, not int (which is too
2634 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2635 32-bit --with-wide-int hosts).
2636
e097a6fa
PE
2637 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2638 Add a FIXME comment about memory leaks.
2639 (syms_of_charset): Don't assume xmalloc returns.
2640
5637687f
PE
2641 Don't assume that stated character widths fit in int.
2642 * character.c (Fchar_width, c_string_width, lisp_string_width):
2643 * character.h (CHAR_WIDTH):
2644 * indent.c (MULTIBYTE_BYTES_WIDTH):
2645 Use sanitize_char_width to avoid undefined and/or bad behavior
2646 with outlandish widths.
a66cfb1c 2647 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2648 now that we have two such functions. All uses changed.
2649 (sanitize_char_width): New inline function.
2650
a2271ba2
PE
2651 Don't assume that tab-width fits in int.
2652 * character.h (sanitize_width): New inline function.
2653 (SANE_TAB_WIDTH): New macro.
2654 (ASCII_CHAR_WIDTH): Use it.
2655 * indent.c (sane_tab_width): Remove. All uses replaced by
2656 SANE_TAB_WIDTH (current_buffer).
2657 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2658
18c52557
PE
2659 * fileio.c: Integer overflow issues with file modes.
2660 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2661
caeeedc1
PE
2662 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2663 Remove unreachable code.
2664 (read_hex, load_charset_map_from_file): Check for integer overflow.
2665
6df6ae42 2666 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2667 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2668 (x_send_scroll_bar_event): Likewise. Check that the size does not
2669 exceed limits imposed by XClientMessageEvent, as well as the usual
2670 ptrdiff_t and size_t limits.
2671
b13995db
PE
2672 * keyboard.c: Overflow, signedness and related fixes.
2673 (make_lispy_movement): Use same integer type in forward decl
2674 that is used in the definition.
2675 (read_key_sequence, keyremap_step):
2676 Change bufsize argument back to int, undoing my 2011-03-30 change.
2677 We prefer signed types, and int is wide enough here.
2678 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2679 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2680 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2681 length, not size_t. Use ptrdiff_t for index, not int.
2682 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2683 possibility of integer overflow.
2684
13464394
PE
2685 Overflow, signedness and related fixes for images.
2686
2687 * dispextern.h (struct it.stack[0].u.image.image_id)
2688 (struct_it.image_id, struct image.id, struct image_cache.size)
2689 (struct image_cache.used, struct image_cache.ref_count):
2690 * gtkutil.c (update_frame_tool_bar):
2691 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2692 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2693 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2694 * nsmenu.m (update_frame_tool_bar):
2695 * xdisp.c (calc_pixel_width_or_height):
2696 * xfns.c (image_cache_refcount):
2697 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2698 on typical 64-bit hosts.
2699
2700 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2701 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2702 Omit unnecessary casts to int.
2703 (parse_image_spec): Check that integers fall into 'int' range
2704 when the callers expect that.
2705 (image_ascent): Redo ascent calculation to avoid int overflow.
2706 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2707 (lookup_image): Remove unnecessary tests.
2708 (xbm_image_p): Locals are now of int, not EMACS_INT,
2709 since parse_image_check makes sure they fit into int.
2710 (png_load, gif_load, svg_load_image):
2711 Prefer int to unsigned where either will do.
2712 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2713 old tiff_error_handler and tiff_warning_handler.
2714 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2715 stack buffer overflows. It uses only the features of vsnprintf
2716 that are common to both POSIX and native Microsoft.
2717 (tiff_error_handler, tiff_warning_handler): Use it.
2718 (tiff_load, gif_load, imagemagick_load_image):
2719 Don't assume :index value fits in 'int'.
2720 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2721 (imagemagick_load_image): Check that crop parameters fit into
2722 the integer types that MagickCropImage accepts. Don't assume
2723 Vimagemagick_render_type has a nonnegative value. Don't assume
2724 size_t fits in 'long'.
2725 (gs_load): Use printmax_t to print the widest integers possible.
2726 Check for integer overflow when computing image height and width.
2727
c11821d4
EZ
27282011-08-26 Eli Zaretskii <eliz@gnu.org>
2729
2730 * xdisp.c (redisplay_window): Don't force window start if point
2731 will be invisible in the resulting window. (Bug#9324)
2732
0c95fcf7
EZ
27332011-08-25 Eli Zaretskii <eliz@gnu.org>
2734
2735 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2736 the display spec is of the form `(space ...)'.
2737 (handle_display_spec): Return the value returned by
2738 handle_single_display_spec, not just 1 or zero.
2739 (handle_single_display_spec): If the display spec is of the form
2740 `(space ...)', and specifies display in the text area, return 2
2741 rather than 1.
fee65a97 2742 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2743 accurately, and prefer exact match for point under bidi.
2744 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2745
2746 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2747 into disp_prop; all users changed.
2748
2749 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2750 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2751 for the text covered by the display property.
2752
e4ed06f1
CY
27532011-08-25 Chong Yidong <cyd@stupidchicken.com>
2754
2755 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2756 Change return value to nil.
2757 (Frecord_buffer): Delete unused function.
2758
f67cdd7f
EZ
27592011-08-24 Eli Zaretskii <eliz@gnu.org>
2760
5980d4c6
EZ
2761 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2762 buffers, return left-to-right.
8610fe8b
EZ
2763 (set_cursor_from_row): Consider candidate row a win if its glyph
2764 represents a newline and point is on that newline. Fixes cursor
2765 positioning on the newline at EOL of R2L text within L2R
2766 paragraph, and vice versa.
2767 (try_cursor_movement): Check continued rows, in addition to
2768 continuation rows. Fixes unwarranted scroll when point enters a
2769 continued line of R2L text within an L2R paragraph, or vice versa.
2770 (cursor_row_p): Consider the case of point being equal to
2771 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2772 from the end of a short line to the beginning of a continued line
2773 of R2L text within L2R paragraph.
2774 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2775 composed characters.
5980d4c6 2776
f67cdd7f
EZ
2777 * bidi.c (bidi_check_type): Use xassert.
2778 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2779 members.
2780
bca633fb
EZ
27812011-08-23 Eli Zaretskii <eliz@gnu.org>
2782
2783 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2784 a character.
2785
4a5885a7
CY
27862011-08-23 Chong Yidong <cyd@stupidchicken.com>
2787
2788 * nsfont.m (ns_otf_to_script): Fix typo.
2789
0902a04e
KH
27902011-08-22 Kenichi Handa <handa@m17n.org>
2791
2792 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2793 extra slot even if the purpose is char-code-property-table.
2794
1a2e6670
EZ
27952011-08-23 Eli Zaretskii <eliz@gnu.org>
2796
8ddde651
EZ
2797 * xdisp.c (redisplay_window): When computing centering_position,
2798 account for the height of the header line. (Bug#8874)
2799
425cc014
EZ
2800 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2801 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2802 candidate is selected by the mouse, and that candidate has a
2803 composed character under the mouse.
2804
1a2e6670
EZ
2805 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2806 coordinates reported by pos-visible-in-window-p for a composed
2807 character in column zero.
2808
8b76d6f8
SM
28092011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2810
2811 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2812
dac347dd
EZ
28132011-08-22 Eli Zaretskii <eliz@gnu.org>
2814
2815 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2816 consider it a hit if to_charpos is anywhere in the range of the
2817 composed buffer positions.
2818
e013fb34
CY
28192011-08-22 Chong Yidong <cyd@stupidchicken.com>
2820
2821 * image.c (gif_load): Don't assume that each subimage has the same
2822 dimensions as the base image. Handle disposal method that is
2823 "undefined" by the gif spec (Bug#9335).
2824
bd1ba3e8
CY
28252011-08-20 Chong Yidong <cyd@stupidchicken.com>
2826
2827 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2828 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2829
54a1215b
EZ
28302011-08-19 Eli Zaretskii <eliz@gnu.org>
2831
823564e5
EZ
2832 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2833 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2834 from an Org mode buffer to a Speedbar frame.
2835
54a1215b
EZ
2836 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2837 a composition, take its buffer position from IT->cmp_it.charpos.
2838 Fixes cursor positioning at the beginning of a line that begins
2839 with a composed character.
2840
9778ebcc
EZ
28412011-08-18 Eli Zaretskii <eliz@gnu.org>
2842
0be6ee06
EZ
2843 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2844 character bidirectional type, use STRONG_L instead. Fixes crashes
2845 in a buffer produced by `describe-categories'.
2846
9778ebcc
EZ
2847 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2848 members before the level stack, so they would be saved and
2849 restored when copying iterator state. Fixes incorrect reordering
2850 around TABs covered by display properties.
2851
156bffbe
AS
28522011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2853
6b02f655 2854 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2855
72ad093b
CY
28562011-08-17 Chong Yidong <cyd@stupidchicken.com>
2857
2858 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2859 (internal_condition_case_2, internal_condition_case_n):
2860 Remove unnecessary aborts (Bug#9081).
72ad093b 2861
35774242
EZ
28622011-08-17 Eli Zaretskii <eliz@gnu.org>
2863
2864 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2865 has no `load' handler, try opening the file locally. (Bug#9311)
2866
db76dd85
KB
28672011-08-16 Ken Brown <kbrown@cornell.edu>
2868
2869 * gmalloc.c: Expand comment.
2870
b215eee5
EZ
28712011-08-16 Eli Zaretskii <eliz@gnu.org>
2872
2873 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2874 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2875
a4579d33
KB
28762011-08-16 Ken Brown <kbrown@cornell.edu>
2877
2878 Fix memory allocation problems in Cygwin build (Bug#9273).
2879
2880 * unexcw.c ( __malloc_initialized): Declare external variable.
2881 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2882
8b76d6f8
SM
2883 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2884 New variables.
a4579d33
KB
2885 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2886 dumped emacs.
2887 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2888 in the static heap.
2889 [CYGWIN] (special_realloc): New function.
2890 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2891 requests to realloc storage in the static heap.
2892
3ebec551
PE
28932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2894
2895 * bidi.c (bidi_initialize): Remove unused local.
2896
9fd8be00
EZ
28972011-08-15 Eli Zaretskii <eliz@gnu.org>
2898
6b02f655
SM
2899 * bidimirror.h:
2900 * biditype.h: Remove file.
2901 * makefile.w32-in ($(BLD)/bidi.$(O)):
2902 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2903
2904 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2905
2906 * chartab.c: Improve commentary for the uniprop_table API.
2907
32413314
EZ
2908 * bidi.c (bidi_paragraph_init): Support zero value of
2909 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2910 (bidi_initialize): Use uniprop_table instead of including
2911 biditype.h and bidimirror.h.
32413314 2912
9fd8be00
EZ
2913 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2914 coordinates of the iterator when restoring from ppos_it.
2915 (Bug#9296)
2916
5cf2b69b
KH
29172011-08-14 Kenichi Handa <handa@m17n.org>
2918
2919 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2920 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2921
daf17d00
EZ
29222011-08-14 Eli Zaretskii <eliz@gnu.org>
2923
2924 * xdisp.c (move_it_in_display_line_to): Don't invoke
2925 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2926 ppos_it. Fixes vertical cursor motion when line beginning is
2927 covered by an image. (Bug#9296)
2928
08e3161a
JD
29292011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2930
2931 * nsterm.h (ns_run_ascript): Declare.
2932 (NSAPP_DATA2_RUNASSCRIPT): Define.
2933
2934 * nsfns.m (as_script, as_result, as_status): New static variables.
2935 (ns_run_ascript): New function.
5e617bc2 2936 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2937 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2938 the event loop. Get status from as_status (Bug#7276).
2939
2940 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2941 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2942 the event loop (Bug#7276).
2943
a3720aa2
AS
29442011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2945
2946 * gnutls.c (QCgnutls_bootprop_priority)
2947 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2948 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2949 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2950 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2951 (QCgnutls_bootprop_verify_hostname_error)
2952 (QCgnutls_bootprop_callbacks_verify): Rename from
2953 Qgnutls_bootprop_..., all uses changed.
2954
2955 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2956 uses changed.
2957
0a0d27fb
PE
29582011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2959
19d5c50c
PE
2960 * xfaces.c (Qframe_set_background_mode): Now static.
2961 * dispextern.h (Qframe_set_background_mode): Remove decl.
2962
0a0d27fb
PE
2963 * process.c (Fnetwork_interface_info): Declare local only if needed.
2964
377538cb
JD
29652011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2968 (Fnetwork_interface_list): Allocate in increments of bytes instead
2969 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2970 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2971 sockaddr.
2972 (struct ifflag_def): notrailers is smart on OSX.
2973 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2974 Get hardware address with getifaddrs if available.
2975
08fff70c
EZ
29762011-08-12 Eli Zaretskii <eliz@gnu.org>
2977
2978 * xdisp.c (iterate_out_of_display_property): xassert that
2979 IT->position is set to within IT->object's boundaries. Break from
2980 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2981 when IT->position is set up wrongly due to some bug.
2982 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2983 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2984 entry. Force push_it to save on the stack the current
2985 buffer/string position, to be restored by pop_it. Fix flags in
2986 the iterator structure wrt the object coming from a display
2987 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2988 properties. (Bug#9284)
2989
7be1c708 29902011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2991
7be1c708
CY
2992 * fontset.c (fontset_get_font_group): Add proper type checks.
2993 (Bug#9172)
aac0c6e3 2994
7be1c708 29952011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2996
7be1c708
CY
2997 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2998 and LC_VERSION_MIN_MACOSX.
2999 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3000 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3001
97bb72a6
EZ
30022011-08-08 Eli Zaretskii <eliz@gnu.org>
3003
3004 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3005 no-display-properties-and-no-overlays under bidi display.
3006 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3007 properties and overlays.
97bb72a6 3008
d5617611
CY
30092011-08-08 Chong Yidong <cyd@stupidchicken.com>
3010
37e11a63
CY
3011 * editfns.c (Fset_time_zone_rule): Document relationship with the
3012 setenv function.
3013
d5617611
CY
3014 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3015 the font entity extracted from the cache (Bug#8109).
3016
58872834
CY
30172011-08-07 Chong Yidong <cyd@stupidchicken.com>
3018
3019 * composite.c (autocmp_chars): Don't reset point. That is done by
3020 restore_point_unwind (Bug#5984).
3021
75bfc667
JL
30222011-08-07 Juri Linkov <juri@jurta.org>
3023
3024 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3025 to show the arg `TIME' instead of `TIMEVAL'.
3026
d1410150
EZ
30272011-08-06 Eli Zaretskii <eliz@gnu.org>
3028
3029 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3030 display property strides EOL and includes a newline, as in
3031 longlines-mode. (Bug#9254)
75b771e4
EZ
3032 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3033 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3034
3035 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3036 is non-zero, even if the data buffer is NULL. Fixes a crash in
3037 vertical-motion with longlines-mode. (Bug#9254)
3038
35928349
EZ
30392011-08-05 Eli Zaretskii <eliz@gnu.org>
3040
ec7cc85b
EZ
3041 * bidi.c <bidi_cache_total_alloc>: Now static.
3042 (bidi_initialize): Initialize bidi_cache_total_alloc.
3043
8b76d6f8 3044 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3045 cache. (Bug#9221)
3046
3047 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3048 amount allocated this far in `bidi_cache_total_alloc'.
3049 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3050 non-zero, only free the data buffer without restoring the cache
3051 contents. All callers changed.
3052
3053 * dispextern.h (bidi_unshelve_cache): Update prototype.
3054
3055 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3056 (move_it_in_display_line, move_it_to)
3057 (move_it_vertically_backward, move_it_by_lines): Replace the call
3058 to xfree to an equivalent call to bidi_unshelve_cache.
3059 (move_it_in_display_line_to): Fix logic of returning
412b6358 3060 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3061
e2e2423b
EZ
30622011-08-05 Eli Zaretskii <eliz@gnu.org>
3063
3064 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3065 came from a string character with a `cursor' property. (Bug#9229)
3066
ae9e757a
JD
30672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3068
3069 * Makefile.in (LIB_PTHREAD): New variable.
3070 (LIBES): Add LIB_PTHREAD (Bug#9216).
3071
3072 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3073 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3074
213bd7f2
AS
30752011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3076
6b02f655 3077 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3078
99aaf75f
JD
30792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3080
3081 * xterm.c (x_find_topmost_parent): New function.
3082 (x_set_frame_alpha): Find topmost parent window with
3083 x_find_topmost_parent and set the property there also (bug#9181).
3084 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3085
c74e9d86
PE
30862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 * callproc.c (Fcall_process): Avoid vfork clobbering
3089 the local vars buffer, coding_systems, current_dir.
3090
640c8776
SM
30912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3092
3093 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3094
f26d0e4c
PE
30952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3096
8a10d76c
PE
3097 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3098 so that it is not optimized away.
3099
f26d0e4c
PE
3100 * xdisp.c (compute_display_string_pos): Remove unused local.
3101
55439c61
EZ
31022011-08-02 Eli Zaretskii <eliz@gnu.org>
3103
3104 Fix slow cursor motion and scrolling in large buffers with
3105 selective display, like Org Mode buffers. (Bug#9218)
3106
3107 * dispextern.h (struct bidi_it): New member disp_prop_p.
3108
3109 * xdisp.c: Remove one-slot cache of display string positions.
3110 (compute_display_string_pos): Accept an additional argument
5e617bc2 3111 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3112 for a display string or property. If found, set DISP_PROP_P
3113 non-zero.
3114
3115 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3116 DISP_PROP_P, and pass it to compute_display_string_pos.
3117 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3118 non-zero. All callers of bidi_fetch_char changed.
3119
fb33fa43
SM
31202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3121
3122 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3123
b099e063
DM
31242010-12-03 Don March <don@ohspite.net>
3125
3126 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3127 last character M-[char] is translated to ESC [char] (bug#7541).
3128
5cc7f7af
KH
31292011-08-02 Kenichi Handa <handa@m17n.org>
3130
d0fffa3f 3131 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3132
3133 * chartab.c (uniprop_table): Make it non-static.
3134
525d5e6e
EZ
31352011-08-01 Eli Zaretskii <eliz@gnu.org>
3136
3137 * xdisp.c (forward_to_next_line_start): Accept additional argument
3138 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3139 on the newline.
3140 (reseat_at_next_visible_line_start): Use the bidi iterator state
3141 returned by forward_to_next_line_start to restore the state of
3142 it->bidi_it after backing up to previous newline. (Bug#9212)
3143
31011111
AS
31442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3145
3146 * regex.c (re_comp): Protoize.
3147 (re_exec): Fix return type.
3148 (regexec): Fix type of `ret'. (Bug#9203)
3149
476371c4
PE
31502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3151
e5d76069
PE
3152 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3153 This is needed if max-image-size is a floating-point number.
3154
9a79b20c
AS
31552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3156
3157 * print.c (print_object): Print empty symbol as ##.
3158
3159 * lread.c (read1): Read ## as empty symbol.
3160
d8c2fa78
AA
31612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3162
3163 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3164 setting frame foreground color (Bug#9175).
3165 (x_set_background_color): Likewise.
3166
ffe57a7a
AA
3167 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3168 contents (Bug#9176).
3169 (EmacsTooltip -init): Remove bezels and add shadows to
3170 tooltip windows.
3171
bf3492a5
AA
3172 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3173 or scroll bar (Bug#8470).
3174
d55e9c53
AA
3175 * nsfont.m (nsfont_open): Remove assignment to voffset and
3176 unnecessary vars hshink, expand, hd, full_height, min_height.
3177 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3178
3179 * nsterm.h (nsfont_info): Remove voffset field.
3180
d8c2fa78 31812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3182
3183 Implement strike-through and overline on NextStep (Bug#8863).
3184
3185 * nsfont.m (nsfont_open): Use underline position provided by font,
3186 instead of hard-coded value of 2.
3187 (nsfont_draw): Call ns_draw_text_decoration instead.
3188
3189 * nsterm.h: Add declaration for ns_draw_text_decoration.
3190
3191 * nsterm.m (ns_draw_text_decoration): New function for drawing
3192 underline, overline, and strike-through.
3193 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3194 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3195 accommodate underlining, etc.
4843aac3 3196
4cc60b9b
EZ
31972011-07-28 Eli Zaretskii <eliz@gnu.org>
3198
bc7ece87
EZ
3199 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3200 default.
4cc60b9b 3201
476371c4
PE
32022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3203
66606eea
PE
3204 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3205 Without this fix, if a signal arrives just after memory fills up,
3206 'malloc' might be invoked reentrantly.
3207
476371c4
PE
3208 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3209 In other words, assume that every image size is allowed, on non-X
3210 hosts. This assumption is probably wrong, but it lets Emacs compile.
3211
f3fcc40d
AS
32122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3213
3214 * regex.c (re_iswctype): Convert return values to boolean.
3215
350c992f
EZ
32162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3217
3218 * xdisp.c (compute_display_string_pos): Don't use cached display
3219 string position if the buffer had its restriction changed.
3220 (Bug#9184)
3221
5266b4bb
PE
32222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3225
2573a837 32262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3227
41f55ccd 3228 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3229
39e378da
PE
3230 * bidi.c: Integer size and overflow fixes.
3231 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3232 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3233 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3234 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3235 (bidi_find_other_level_edge):
3236 Use ptrdiff_t instead of EMACS_INT where either will do.
3237 This works better on 32-bit hosts configured --with-wide-int.
3238 (bidi_cache_ensure_space): Check for size-calculation overflow.
3239 Use % rather than repeated addition, for better worst-case speed.
3240 Don't set bidi_cache_size until after xrealloc returns, because it
3241 might not return.
3242 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3243 (bidi_cache_ensure_space): Also check that the bidi cache size
3244 does not exceed that of the largest Lisp string or buffer. See Eli
3245 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3246
5e927815
PE
3247 * alloc.c (__malloc_size_t): Remove.
3248 All uses replaced by size_t. See Andreas Schwab's note
3249 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3250
ca4aa935
PE
3251 * image.c: Improve checking for integer overflow.
3252 (check_image_size): Assume that f is nonnull, since
3253 it is always nonnull in practice. This is one less thing to
3254 worry about when checking for integer overflow later.
3255 (x_check_image_size): New function, which checks for integer
3256 overflow issues inside X.
3257 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3258 This removes the need for a memory_full check.
3259 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3260 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3261 (xbm_read_bitmap_data): Change locals back to 'int', since
3262 their values must fit in 'int'.
3263 (xpm_load_image, png_load, tiff_load):
3264 Invoke x_create_x_image_and_pixmap earlier,
3265 to avoid much needless work if the image is too large.
3266 (tiff_load): Treat overly large images as if
3267 x_create_x_image_and_pixmap failed, not as malloc failures.
3268 (gs_load): Use x_check_image_size.
3269
5f8f9cc2
PE
3270 * gtkutil.c: Omit integer casts.
3271 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3272 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3273
5adf60bc
PE
3274 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3275
c8907a93
PE
3276 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3277 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3278 would wrongly return t on a 64-bit host.
3279
e3c25c68
PE
3280 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3281 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3282 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3283 and therefore cause GCC to emit a bogus diagnostic in some cases.
3284
3f791afe
PE
3285 * image.c: Integer signedness and overflow and related fixes.
3286 This is not an exhaustive set of fixes, but it's time to
3287 record what I've got.
3288 (lookup_pixel_color, check_image_size): Remove redundant decls.
3289 (check_image_size): Don't assume that arbitrary EMACS_INT values
3290 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3291 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3292 (tiff_load, imagemagick_load_image):
3293 Check for overflow in size calculations.
3294 (x_create_x_image_and_pixmap): Remove unnecessary test for
3295 xmalloc returning NULL; that can't happen.
3296 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3297 (xpm_color_bucket): Use better integer hashing function.
3298 (xpm_cache_color): Don't possibly over-allocate memory.
3299 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3300 (gif_memory_source):
3301 Use ptrdiff_t, not int or size_t, to record sizes.
3302 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3303 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3304 either works, as we prefer signed integers.
3305 (tiff_read_from_memory, tiff_write_from_memory):
3306 Return tsize_t, not size_t, since that's what the TIFF API wants.
3307 (tiff_read_from_memory): Don't fail simply because the read would
3308 go past EOF; instead, return a short read.
3309 (tiff_load): Omit no-longer-needed casts.
3310 (Fimagemagick_types): Don't assume size fits into 'int'.
3311
3cc5a532
PE
3312 Improve hashing quality when configured --with-wide-int.
3313 * fns.c (hash_string): New function, taken from sxhash_string.
3314 Do not discard information about ASCII character case; this
3315 discarding is no longer needed.
3316 (sxhash-string): Use it. Change sig to match it. Caller changed.
3317 * lisp.h: Declare it.
3318 * lread.c (hash_string): Remove, since we now use fns.c's version.
3319 The fns.c version returns a wider integer if --with-wide-int is
3320 specified, so this should help the quality of the hashing a bit.
3321
b312a492
PE
3322 * emacs.c: Integer overflow minor fix.
3323 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3324 Define only if GNU_LINUX.
3325 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3326
dfd153ae
PE
3327 * dispnew.c: Integer signedness and overflow fixes.
3328 Remove unnecessary forward decls, that were a maintenance hassle.
3329 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3330 All uses changed.
3331 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3332 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3333 (prepare_desired_row, line_draw_cost):
3334 Use int, not unsigned, where either works.
3335 (save_current_matrix, restore_current_matrix):
3336 Use ptrdiff_t, not size_t, where either works.
3337 (init_display): Check for overflow more accurately, and without
3338 relying on undefined behavior.
3339
a81d11a3
PE
3340 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3341 Remove, replacing with the new symbols in lisp.h. All uses changed.
3342 * fileio.c (make_temp_name):
3343 * filelock.c (lock_file_1, lock_file):
3344 * xdisp.c (message_dolog):
3345 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3346 Use pMd etc. instead.
3347 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3348 replacing the pWIDE etc. symbols removed from editfns.c.
3349
3300e6fd
PE
3350 * keyboard.h (num_input_events): Now uintmax_t.
3351 This is (very slightly) less likely to mess up due to wraparound.
3352 All uses changed.
3353
fd05c7e9
PE
3354 * buffer.c: Integer signedness fixes.
3355 (alloc_buffer_text, enlarge_buffer_text):
3356 Use ptrdiff_t rather than size_t when either will do, as we prefer
3357 signed integers.
3358
903fe15d
PE
3359 * alloc.c: Integer signedness and overflow fixes.
3360 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3361 (__malloc_size_t): Default to size_t, not to int.
3362 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3363 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3364 Prefer ptrdiff_t to size_t when either would do, as we prefer
3365 signed integers.
3366 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3367 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3368 Now const. Initialize with values that are in range even if char
3369 is signed.
3370 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3371 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3372 These functions do the right thing with sizes > 2**32.
3373 (check_depth): Now ptrdiff_t, not int.
3374 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3375 Adjust to new way of storing sizes. Check for size overflow bugs
3376 in rest of code.
3377 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3378 slightly wrong anyway, as it missed one instance of
3379 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3380 (refill_memory_reserve): Omit needless cast to size_t.
3381 (mark_object_loop_halt): Mark as externally visible.
3382
ac82cc6a
PE
3383 * xselect.c: Integer signedness and overflow fixes.
3384 (Fx_register_dnd_atom, x_handle_dnd_message):
3385 Use ptrdiff_t, not size_t, since we prefer signed.
3386 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3387 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3388 x_dnd_atoms_size and x_dnd_atoms_length.
3389
c2d1e36d
PE
3390 * doprnt.c: Prefer signed to unsigned when either works.
3391 * eval.c (verror):
3392 * doprnt.c (doprnt):
3393 * lisp.h (doprnt):
3394 * xdisp.c (vmessage):
3395 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3396 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3397 prefer signed arithmetic to avoid comparison confusion.
3398 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3399 but is a bit tricky.
3400
0e926e56
PE
3401 Assume freestanding C89 headers, string.h, stdlib.h.
3402 * data.c, doprnt.c, floatfns.c, print.c:
3403 Include float.h unconditionally.
3404 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3405 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3406 * regex.c: Likewise for stddef.h, string.h.
3407 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3408 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3409 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3410 (STDC_HEADERS): Remove obsolete defines.
3411 * sysdep.c: Include limits.h unconditionally.
3412
9cfdb3ec
PE
3413 Assume support for memcmp, memcpy, memmove, memset.
3414 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3415 * regex.c (memcmp, memcpy):
3416 Remove; we assume C89 now.
3417
3418 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3419 (__malloc_safe_bcopy): Remove; no longer needed.
3420
cf950e6b 3421 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3422 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3423 well either way, and we prefer signed to unsigned.
3424
dbf38e02
LMI
34252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3426
3427 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3428 closes the connection while we're reading (bug#9182).
3429
d6f0886c 34302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3431
d6f0886c
JD
3432 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3433 are specified (Bug#9168).
24e0f6b1 3434
2eb1f9e6
PE
34352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3436
3437 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3438 Found by GCC static checking and --with-wide-int on a 32-bit host.
3439
22381272 34402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3441
3442 * xdisp.c (compute_display_string_pos): Fix logic of caching
3443 previous display string position. Initialize cached_prev_pos to
3444 -1. Fixes slow-down at the beginning of a buffer.
3445
f25e39b4
EZ
34462011-07-24 Eli Zaretskii <eliz@gnu.org>
3447
3448 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3449 for attrs[LFACE_FONTSET_INDEX].
3450
04c4b52e
PE
34512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3452
3453 * xml.c (parse_region): Remove unused local
3454 that was recently introduced.
3455
c1734fbd
EZ
34562011-07-23 Eli Zaretskii <eliz@gnu.org>
3457
be18c5a5
EZ
3458 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3459 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3460
c1734fbd
EZ
3461 * xdisp.c (move_it_in_display_line_to): Record the best matching
3462 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3463 exit if none of the characters scanned was an exact match.
3464 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3465 when exact match is impossible due to invisible text, and the
3466 lines are truncated.
3467
a258d627
JD
34682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3469
3470 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3471 for OSX >= 10.7.
3472
b6d5a689
EZ
34732011-07-22 Eli Zaretskii <eliz@gnu.org>
3474
0f74f785
EZ
3475 Fix a significant slow-down of cursor motion with C-n, C-p,
3476 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3477 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3478 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3479 (next_element_from_buffer): Call compute_stop_pos_backwards to
3480 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3481 base_level_stop.
3482 (reseat): Don't look for prev_stop, as that could mean a very long
3483 run.
3484 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3485 <cached_disp_overlay_modiff>: Cache for last found display string
3486 position.
551918c1 3487 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3488 about the same buffer in the same area of character positions, and
3489 the buffer wasn't changed since the time the display string
3490 position was cached.
551918c1 3491
b2d0c91a
EZ
34922011-07-22 Eli Zaretskii <eliz@gnu.org>
3493
3494 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3495 is an integer, which is important for empty lines. (Bug#9149)
3496
043604ee
CY
34972011-07-22 Chong Yidong <cyd@stupidchicken.com>
3498
3499 * frame.c (Fmodify_frame_parameters): In tty case, update the
3500 default face if necessary (Bug#4238).
3501
da4adb04
CY
35022011-07-21 Chong Yidong <cyd@stupidchicken.com>
3503
3504 * editfns.c (Fstring_to_char): No need to explain what a character
3505 is in the docstring (Bug#6576).
3506
9abd0532
LMI
35072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3508
3509 * xml.c (parse_region): Make sure we always return a tree.
3510
36881d16
HK
35112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3512
3513 * xml.c (parse_region): If a document contains only comments,
3514 return that, too.
3515
1e98674d
LMI
35162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3517
3518 * xml.c (make_dom): Return comments, too.
3519
590bd467
PE
35202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 Port to OpenBSD.
3523 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3524 and the surrounding thread.
3525 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3526 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3527 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3528 timer goes off.
3529 * s/openbsd.h (BROKEN_SIGIO): Define.
3530 * unexelf.c (unexec) [__OpenBSD__]:
3531 Don't update the .mdebug section of the Alpha COFF symbol table.
3532
f41628b2
LMI
35332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3534
3535 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3536 (bug#8460).
3537
b59b67c5
PE
35382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3539
15e3a074
PE
3540 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3541 This fixes some race conditions on the permissions of any newly
3542 created file.
3543
41bed37d
PE
3544 * alloc.c (valid_pointer_p): Use pipe, not open.
3545 This fixes some permissions issues when debugging.
3546
b59b67c5
PE
3547 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3548 If fchown fails to set both uid and gid, try to set just gid,
3549 as that is sometimes allowed. Adjust the file's mode to eliminate
3550 setuid or setgid bits that are inappropriate if fchown fails.
3551
925a6be7
SM
35522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3553
3554 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3555 to compare Lisp_Objects.
3556 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3557 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3558 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3559
52968808
AS
35602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3561
0a6a104b
AS
3562 * lread.c (read_integer): Unread even EOF character.
3563 (read1): Likewise. Properly record start position of symbol.
3564
52968808
AS
3565 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3566 symbol character follows.
3567
9e381cdd
PE
35682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3571 This works around a problem with the previous change to Fcopy_file.
3572 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3573 and without this change, GCC might complain about discarding
3574 fchown's return value.
3575
b5641435
JB
35762011-07-16 Juanma Barranquero <lekktu@gmail.com>
3577
3578 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3579
a8031457
PE
35802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3583
dd889327
LMI
35842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3585
750c33f7
LMI
3586 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3587 it's used from the C level.
3588
dd889327
LMI
3589 * process.c: Use the same condition for POLL_FOR_INPUT in both
3590 keyboard.c and process.c (bug#1858).
3591
87e86684
LM
35922011-07-09 Lawrence Mitchell <wence@gmx.li>
3593
3594 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3595 (Fgnutls_boot): Use it.
3596
64348f40
AS
35972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3598
3599 * doc.c (Fsubstitute_command_keys): Revert last change.
3600
1d698799
LMI
36012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3602
f863868c
LMI
3603 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3604 quotes the next character, and doesn't affect other longer
3605 sequences (bug#8935).
3606
1d698799
LMI
3607 * lread.c (syms_of_lread): Clarify that is isn't only
3608 `eval-buffer' and `eval-defun' that's affected by
3609 `lexical-binding' (bug#8460).
3610
aa4b6df6
EZ
36112011-07-15 Eli Zaretskii <eliz@gnu.org>
3612
3613 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3614 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3615
5d856da6
PE
36162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3617
ad6042bb
PE
3618 Fix minor problems found by static checking.
3619 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3620 (elsz): Now a signed constant, not a size_t var. We prefer signed
3621 types to unsigned, to avoid integer comparison confusion. Without
3622 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3623 "cannot optimize loop, the loop counter may overflow", a symptom
3624 of the confusion.
f00bbb22 3625 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3626 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3627
6468f31c
LMI
36282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3629
49080b10
LMI
3630 * search.c (Fre_search_backward): Mention `case-fold-search' in
3631 all the re_search_* functions (bug#8138).
3632
6468f31c
LMI
3633 * keyboard.c (Fopen_dribble_file): Document when the file is
3634 closed (bug#8056).
3635
c965adc5
EZ
36362011-07-14 Eli Zaretskii <eliz@gnu.org>
3637
df9733bf
EZ
3638 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3639 bidi_cache_idx.
3640
0bb23927
EZ
3641 Support bidi reordering of display and overlay strings.
3642 * xdisp.c (compute_display_string_pos)
3643 (compute_display_string_end): Accept additional argument STRING.
3644 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3645 (reseat_to_string): Initialize bidi_it->string.s and
3646 bidi_it->string.schars.
3647 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3648 NULL (avoids a crash in bidi_paragraph_init).
3649 Initialize itb.string.lstring.
0bb23927
EZ
3650 (init_iterator): Call bidi_init_it only of a valid
3651 buffer position was specified. Initialize paragraph_embedding to
3652 L2R.
3653 (reseat_to_string): Initialize the bidi iterator.
3654 (display_string): If we need to ignore text properties of
3655 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3656 original value of -1 will not work with bidi.)
3657 (compute_display_string_pos): First arg is now struct
3658 `text_pos *'; all callers changed. Support display properties on
3659 Lisp strings.
3660 (compute_display_string_end): Support display properties on Lisp
3661 strings.
3662 (init_iterator, reseat_1, reseat_to_string): Initialize the
3663 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3664 when iterating on a string not from display properties).
640c8776
SM
3665 (compute_display_string_pos, compute_display_string_end):
3666 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3667 arrow keys.
3668 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3669 base_level_stop; instead, set base_level_stop to BEGV.
3670 Fixes crashes in vertical-motion.
0bb23927
EZ
3671 (next_element_from_buffer): Improve commentary for when
3672 the iterator is before prev_stop.
3673 (init_iterator): Initialize bidi_p from the default value of
3674 bidi-display-reordering, not from buffer-local value. Use the
3675 buffer-local value only if initializing for buffer iteration.
3676 (handle_invisible_prop): Support invisible properties on strings
3677 that are being bidi-reordered.
3678 (set_iterator_to_next): Support bidi reordering of C strings and
3679 Lisp strings.
3680 (next_element_from_string): Support bidi reordering of Lisp
3681 strings.
3682 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3683 (display_string): Support display of R2L glyph rows.
3684 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3685 (init_iterator): Don't initialize it->bidi_p for strings
3686 here.
3687 (reseat_to_string): Initialize it->bidi_p for strings here.
3688 (next_element_from_string, next_element_from_c_string)
3689 (next_element_from_buffer): Add xassert's for correspondence
3690 between IT's object being iterated and it->bidi_it.string
3691 structure.
3692 (face_before_or_after_it_pos): Support bidi iteration.
3693 (next_element_from_c_string): Handle the case of the first string
3694 character that is not the first one in the visual order.
3695 (get_visually_first_element): New function, refactored from common
3696 parts of next_element_from_buffer, next_element_from_string, and
3697 next_element_from_c_string.
3698 (tool_bar_lines_needed, redisplay_tool_bar)
3699 (display_menu_bar): Force left-to-right direction. Add a FIXME
3700 comment for making that be controlled by a user option.
3701 (push_it, pop_it): Save and restore the state of the
3702 bidi iterator. Save and restore the bidi_p flag.
3703 (pop_it): Iterate out of display property for string iteration as
3704 well.
3705 (iterate_out_of_display_property): Support iteration over strings.
3706 (handle_single_display_spec): Set up it->bidi_it for iteration
3707 over a display string, and call bidi_init_it.
3708 (handle_single_display_spec, next_overlay_string)
3709 (get_overlay_strings_1, push_display_prop): Set up the bidi
3710 iterator for displaying display or overlay strings.
3711 (forward_to_next_line_start): Don't use the shortcut if
3712 bidi-iterating.
3713 (back_to_previous_visible_line_start): If handle_display_prop
3714 pushed the iterator stack, restore the internal state of the bidi
3715 iterator by calling bidi_pop_it same number of times.
3716 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3717 and we are bidi-iterating, don't decrement the iterator position;
3718 instead, set the first_elt flag in the bidi iterator, to produce
3719 the same effect.
3720 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3721 (push_display_prop): xassert that we are iterating a buffer.
3722 (push_it, pop_it): Save and restore paragraph_embedding member.
3723 (handle_single_display_spec, next_overlay_string)
3724 (get_overlay_strings_1, reseat_1, reseat_to_string)
3725 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3726 correctly. Don't assume unibyte strings are not bidi-reordered.
3727 (compute_display_string_pos)
3728 (compute_display_string_end): Fix handling the case of C string.
3729 (push_it, pop_it): Save and restore from_disp_prop_p.
3730 (handle_single_display_spec, push_display_prop): Set the
3731 from_disp_prop_p flag.
3732 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3733 (pop_it): Call iterate_out_of_display_property only if we are
3734 popping after iteration over a string that came from a display
3735 property. Fix a typo in popping stretch info. Add an assertion
3736 for verifying that the iterator position is in sync with the bidi
3737 iterator.
3738 (handle_single_display_spec, get_overlay_strings_1)
3739 (push_display_prop): Fix initialization of paragraph direction for
3740 string when that of the parent object is not yet determined.
3741 (reseat_1): Call bidi_init_it to resync the bidi
3742 iterator with IT's position. (Bug#7616)
3743 (find_row_edges): If ROW->start.pos gives position
3744 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3745 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3746 Reset the from_disp_prop_p flag.
3747 (SAVE_IT, RESTORE_IT): New macros.
3748 (pos_visible_p, face_before_or_after_it_pos)
3749 (back_to_previous_visible_line_start)
3750 (move_it_in_display_line_to, move_it_in_display_line)
3751 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3752 (try_scrolling, redisplay_window, display_line): Use them when
3753 saving a temporary copy of the iterator and restoring it back.
3754 (back_to_previous_visible_line_start, reseat_1)
3755 (init_iterator): Empty the bidi cache "stack".
3756 (move_it_in_display_line_to): If iterator ended up at
3757 EOL, but we never saw any buffer positions smaller than
3758 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3759 motion in bidi-reordered lines.
3760 (move_it_in_display_line_to): Record prev_method and prev_pos
3761 immediately before the call to set_iterator_to_next. Fixes cursor
3762 motion in bidi-reordered lines with stretch glyphs and strings
3763 displayed in margins. (Bug#8133) (Bug#8867)
3764 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3765 TO_CHARPOS.
640c8776
SM
3766 (pos_visible_p): Support positions in bidi-reordered lines.
3767 Save and restore bidi cache.
0bb23927
EZ
3768
3769 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3770 (bidi_paragraph_info): Delete unused struct.
3771 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3772 (bidi_cache_start): New variable.
3773 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3774 to zero.
3775 (bidi_cache_fetch_state, bidi_cache_search)
3776 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3777 (bidi_cache_find, bidi_peek_at_next_level)
3778 (bidi_level_of_next_char, bidi_find_other_level_edge)
3779 (bidi_move_to_visually_next): Compare cache index with
3780 bidi_cache_start rather than with zero.
3781 (bidi_fetch_char): Accept new argument STRING; all callers
3782 changed. Support iteration over a string. Support strings with
3783 display properties. Support unibyte strings. Fix the type of
3784 `len' according to what STRING_CHAR_AND_LENGTH expects.
3785 (bidi_paragraph_init, bidi_resolve_explicit_1)
3786 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3787 (bidi_level_of_next_char, bidi_move_to_visually_next):
3788 Support iteration over a string.
0bb23927
EZ
3789 (bidi_set_sor_type, bidi_resolve_explicit_1)
3790 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3791 can now be zero (for strings); special values 0 and -1 were
3792 changed to -1 and -2, respectively.
3793 (bidi_char_at_pos): New function.
3794 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3795 Call it instead of FETCH_MULTIBYTE_CHAR.
3796 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3797 initialized to valid values.
3798 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3799 values.
3800 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3801 the test for valid cached positions. Fix the logic for looking up
3802 the sentinel state in the cache. GCPRO the Lisp string we are
3803 iterating.
3804 (bidi_push_it, bidi_pop_it): New functions.
3805 (bidi_initialize): Initialize the bidi cache start stack pointer.
3806 (bidi_cache_ensure_space): New function, refactored from part of
3807 bidi_cache_iterator_state. Don't assume the required size is just
3808 one BIDI_CACHE_CHUNK away.
3809 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3810 (bidi_count_bytes, bidi_char_at_pos): New functions.
3811 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3812 always valid if bidi_cache_idx is valid.
3813 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3814 is valid if it's going to be used.
3815 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3816 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3817 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3818 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3819 (bidi_find_other_level_edge, bidi_cache_start_stack):
3820 All variables related to cache indices are now EMACS_INT.
c965adc5 3821
0bb23927
EZ
3822 * dispextern.h (struct bidi_string_data): New structure.
3823 (struct bidi_it): New member `string'. Make flag members be 1-bit
3824 fields, and put them last in the struct.
640c8776
SM
3825 (compute_display_string_pos, compute_display_string_end):
3826 Update prototypes.
0bb23927
EZ
3827 (bidi_push_it, bidi_pop_it): Add prototypes.
3828 (struct iterator_stack_entry): New members bidi_p,
3829 paragraph_embedding, and from_disp_prop_p.
3830 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3831 (bidi_shelve_cache, bidi_unshelve_cache):
3832 Declare prototypes.
0bb23927
EZ
3833
3834 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3835 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3836 and vector-like objects.
3837
3838 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3839 cache around display iteration.
3840
3841 * window.c (Fwindow_end, window_scroll_pixel_based)
3842 (displayed_window_lines, Frecenter): Save and restore the bidi
3843 cache around display iteration.
3844
3bbd2265
LMI
38452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3846
3847 * editfns.c (Fdelete_region): Clarify the use of the named
3848 parameters (bug#6788).
3849
adc47434
MR
38502011-07-14 Martin Rudalics <rudalics@gmx.at>
3851
3852 * indent.c (Fvertical_motion): Set and restore w->pointm when
3853 saving and restoring the window's buffer (Bug#9006).
3854
837c31f8
LMI
38552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3856
3857 * editfns.c (Fstring_to_char): Clarify just what is returned
3858 (bug#6576). Text by Eli Zaretskii.
3859
ac389d0c
JB
38602011-07-13 Juanma Barranquero <lekktu@gmail.com>
3861
3862 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3863
0be0ce47
EZ
38642011-07-13 Eli Zaretskii <eliz@gnu.org>
3865
3866 * buffer.c (mmap_find): Fix a typo.
3867
cd18e7e3
JB
38682011-07-13 Johan Bockgård <bojohan@gnu.org>
3869
3870 Fix execution of x selection hooks.
3871 * xselect.c (Qx_lost_selection_functions)
3872 (Qx_sent_selection_functions): New vars.
3873 (syms_of_xselect): DEFSYM them.
3874 (x_handle_selection_request): Pass Qx_sent_selection_functions
3875 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3876 (x_handle_selection_clear,x_clear_frame_selections):
3877 Pass Qx_lost_selection_functions rather than
3878 Vx_lost_selection_functions to Frun_hook_with_args.
3879
47ea7f44
PE
38802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3881
ac389d0c 3882 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3883 The old code sometimes used this field without initializing it.
3884
47ea7f44
PE
3885 * alloc.c (gc_sweep): Don't read past end of array.
3886 In theory, the old code could also have corrupted Emacs internals,
3887 though it'd be very unlikely.
3888
bc985c87
AS
38892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3890
3891 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3892 argument. (Bug#4026)
bc985c87 3893
0cf34688
LMI
38942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3895
b3dadd76
LMI
3896 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3897 key" (bug#4257).
3898
0cf34688
LMI
3899 * window.c (Fset_window_start): Doc fix (bug#4199).
3900 (Fset_window_hscroll): Ditto.
3901
270768cd
PE
39022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3903
077e3dda 3904 Fix minor new problems caught by GCC 4.6.1.
270768cd 3905 * term.c (init_tty): Remove unused local.
490011a6 3906 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3907 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3908 not used otherwise.
270768cd 3909
b1f58454
CY
39102011-07-12 Chong Yidong <cyd@stupidchicken.com>
3911
3912 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3913
22b9578d
LMI
39142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3915
6e70ab07
LMI
3916 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3917 are the mini-buffer and the echo area (bug#3320).
3918
22b9578d
LMI
3919 * term.c (init_tty): Remove support for supdup, c10 and perq
3920 terminals, which are no longer supported (bug#1482).
3921
8974cc9f
JB
39222011-07-10 Johan Bockgård <bojohan@gnu.org>
3923
3924 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3925
a560d974
JD
39262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3927
3928 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3929 for non-popups (Bug#3642).
3930
1dae0f0a
AS
39312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3932
268c2c36 3933 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3934 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3935 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3936 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3937 * data.c (fmod): Likewise.
3938 * dispnew.c (swap_glyphs_in_rows): Likewise.
3939 * emacs.c (memory_warning_signal): Likewise.
3940 * floatfns.c (float_error): Likewise.
3941 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3942 (otf_open, font_otf_capability, generate_otf_features)
3943 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3944 Likewise.
3945 * image.c (pbm_read_file): Likewise.
3946 * indent.c (string_display_width): Likewise.
3947 * intervals.c (check_for_interval, search_for_interval)
3948 (inc_interval_count, count_intervals, root_interval)
3949 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3950 * lread.c (defalias): Likewise.
268c2c36 3951 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3952 * regex.c (set_image_of_range_1, set_image_of_range)
3953 (regex_grow_registers): Likewise.
3954 * sysdep.c (strerror): Likewise.
3955 * termcap.c (valid_filename_p, tprint, main): Likewise.
3956 * tparam.c (main): Likewise.
3957 * unexhp9k800.c (run_time_remap, save_data_space)
3958 (update_file_ptrs, read_header, write_header, calculate_checksum)
3959 (copy_file, copy_rest, display_header): Likewise.
3960 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3961 Likewise.
3962 * xdisp.c (check_it): Likewise.
3963 * xfaces.c (register_color, unregister_color, unregister_colors):
3964 Likewise.
3965 * xfns.c (print_fontset_result): Likewise.
3966 * xrdb.c (member, fatal, main): Likewise.
3967
99033785
PE
39682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3969
3970 Fix minor problems found by static checking (Bug#9031).
3971 * chartab.c (char_table_set_range, map_sub_char_table):
3972 Remove unused locals.
3973 (uniprop_table): Now static.
3974 * composite.c (_work_char): Remove unused static var.
3975
9cb2ac56
JB
39762011-07-09 Juanma Barranquero <lekktu@gmail.com>
3977
3978 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3979
f25661f0
JD
39802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3981
3982 * gtkutil.c (qttip_cb): Remove code without function.
3983
8278c4fe
EZ
39842011-07-09 Eli Zaretskii <eliz@gnu.org>
3985
3986 * w32.c (pthread_sigmask): New stub.
3987
1692ae2d 39882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3989
8a6ebd58 3990 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3991 sigprocmask is portable only for single-threaded applications, and
3992 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3993 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3994 (LIBES): Use it.
3995 * callproc.c (Fcall_process):
3996 * process.c (create_process):
3997 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3998 Use pthread_sigmask, not sigprocmask.
123403e4 3999
1b854618
JD
40002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4001
4002 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4003 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4004 wrong (Bug#8591).
4005
3fe4b549
JD
40062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4007
0ce7e563
JD
4008 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4009 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4010 (xg_hide_tooltip): Fix comment.
4011
3fe4b549
JD
4012 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4013 in registerServicesMenuSendTypes.
4014 (validRequestorForSendType): Don't check ns_return_types.
4015
4016 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4017 ns_return_type.
4018
5df75e47
JR
40192011-07-08 Jason Rumney <jasonr@gnu.org>
4020
22610910
JR
4021 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4022 SH_SHOW for hidden windows (Bug#5482).
4023
5df75e47
JR
4024 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4025 frame struct members of non-existent frames (Bug#6284).
4026
699c10bd
JD
40272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4028
4393663b
JD
4029 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4030 variable firstTime not needed on OSX >= 10.6.
4031 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4032 >= 10.5. Use setKnobProportion, setDoubleValue.
4033
4034 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4035 (MAC_OS_X_VERSION_10_5): Define if not defined.
4036 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4037 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4038 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4039
4040 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4041 cString and lossyCString on OSX >= 10.4
4042
58179cce 4043 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4044 sizeToFit on OSX >= 10.2.
4045
4046 * nsimage.m (allocInitFromFile): Don't use deprecated method
4047 bestRepresentationForDevice on OSX >= 10.6.
4048
4049 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4050 to avoid warning.
4051
4052 * emacs.c: Declare unexec_init_emacs_zone.
4053
a63e0781
JD
4054 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4055
699c10bd
JD
4056 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4057
4058 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4059 on svcsMenu (Bug#8842).
4060
4061 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4062 ns_return_types.
4063 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4064
4065 * nsterm.m (QUTF8_STRING): Declare.
4066 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4067 (validRequestorForSendType): Return type is (id).
4068 Change indexOfObjectIdenticalTo to indexOfObject.
4069 Check if we have local selection before returning self (Bug#8842).
4070 (writeSelectionToPasteboard): Put local selection into paste board
4071 if we have a local selection (Bug#8842).
4072 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4073
4074 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4075 (ns_get_local_selection): Declare.
4076
54e10184
LMI
40772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4078
9888ff71
LMI
4079 * keymap.c (describe_map_tree): Don't insert a double newline at
4080 the end of the buffer (bug#1169) and return whether we inserted
4081 something.
4082
54e10184
LMI
4083 * callint.c (Fcall_interactively): Change "reading args" to
4084 "providing args" to try to clarify what it does (bug#1010).
4085
15fa4783
KH
40862011-07-07 Kenichi Handa <handa@m17n.org>
4087
4088 * composite.c (composition_compute_stop_pos): Ignore a static
4089 composition starting before CHARPOS (Bug#8915).
4090
4091 * xdisp.c (handle_composition_prop): Likewise.
4092
a8815b00
EZ
40932011-07-07 Eli Zaretskii <eliz@gnu.org>
4094
4095 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4096 (Bug#9015)
4097
ef7b981d 40982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4099
4100 * character.h (unicode_category_t): New enum type.
4101
4102 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4103 (Qchar_code_property_table): New variable.
4104 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4105 (UNIPROP_COMPRESSED_FORM_P): New macros.
4106 (char_table_ascii): Uncompress the compressed values.
4107 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4108 Uncompress the compressed values.
ac389d0c 4109 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4110 (char_table_ref_and_range): Uncompress the compressed values.
4111 (sub_char_table_set): New arg is_uniprop. Callers changed.
4112 Uncompress the compressed values.
4113 (sub_char_table_set_range): Args changed. Callers changed.
4114 (char_table_set_range): Adjuted for the above change.
4115 (map_sub_char_table): Delete args default_val and parent. Add arg
4116 top. Give decoded values to a Lisp function.
640c8776 4117 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4118 values to a Lisp function. Gcpro more variables.
4119 (uniprop_table_uncompress)
4120 (uniprop_decode_value_run_length): New functions.
4121 (uniprop_decoder, uniprop_decoder_count): New variables.
4122 (uniprop_get_decoder, uniprop_encode_value_character)
4123 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4124 New functions.
4125 (uniprop_encoder, uniprop_encoder_count): New variables.
4126 (uniprop_get_encoder, uniprop_table)
4127 (Funicode_property_table_internal, Fget_unicode_property_internal)
4128 (Fput_unicode_property_internal): New functions.
4129 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4130 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4131 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4132 char-code-property-alist.
4133
640c8776 4134 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4135 Vunicode_category_table.
4136
640c8776 4137 * font.c (font_range): Adjust for the change of
c805dec0
KH
4138 Vunicode_category_table.
4139
76b397fb
DN
41402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4141
4142 * m/iris4d.h: Remove file, move contents ...
4143 * s/irix6-5.h: ... here.
4144
22b4128e
PE
41452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4146
4147 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4148 * alloc.c (mark_buffer):
4149 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4150 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4151 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4152 This isn't true in general, and it's particularly not true
4153 if Emacs is configured with --with-wide-int.
4154 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4155 New macros, used in the buffer.c change.
4156
869795d6
JD
41572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4158
4159 * xsettings.c: Use both GConf and GSettings if both are available.
4160 (store_config_changed_event): Add comment.
4161 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4162 (store_tool_bar_style_changed): New functions.
5e617bc2 4163 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4164 (struct xsettings): Move font inside HAVE_XFT.
4165 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4166 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4167 Move inside HAVE_XFT.
640c8776 4168 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4169 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4170 also.
4171 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4172 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4173 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4174 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4175 (parse_settings): Move check for font inside HAVE_XFT.
4176 (read_settings, apply_xft_settings): Add comment.
4177 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4178 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4179 call store_font_name_changed.
4180 (xft_settings_event): Add comment.
4181 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4182 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4183 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4184 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4185 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4186 (xsettings_get_system_font, xsettings_get_system_normal_font):
4187 Add comment.
869795d6 4188
d8ed26bd
PE
41892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 Random fixes. E.g., (random) never returned negative values.
4192 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4193 subseconds part to the entropy, as that's a bit more random.
4194 Prefer signed to unsigned, since the signedness doesn't matter and
4195 in general we prefer signed. When given a limit, use a
4196 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4197 latter isn't right if USE_2_TAGS_FOR_INTS.
4198 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4199 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4200
cabf1cac
SM
42012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4202
4203 * textprop.c (text_property_stickiness):
4204 Obey Vtext_property_default_nonsticky.
4205 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4206 * w32fns.c (syms_of_w32fns):
4207 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4208
6e9b2be9
PE
42092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4210
4211 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4212 This is more efficient than Ffile_directory_p and avoids a minor race.
4213
90186c68
LMI
42142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4215
7c301272
LMI
4216 * buffer.c (Foverlay_put): Say what the return value is
4217 (bug#7835).
4218
c4f2d8d4
LMI
4219 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4220 is a directory before asking whether to use the file name
4221 (bug#7564).
ad637907
LMI
4222 (barf_or_query_if_file_exists): Make the "File is a directory"
4223 error be more correct.
c4f2d8d4 4224
90186c68
LMI
4225 * fns.c (Frequire): Remove the mention of the .gz files, since
4226 that's installation-specific, but keep the mention of
4227 `get-load-suffixes'.
4228
da64016e
PE
42292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4232 Report string overflow if the output is too long.
4233
7d47b580
JB
42342011-07-04 Juanma Barranquero <lekktu@gmail.com>
4235
a555cb87
JB
4236 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4237 (syms_of_gnutls): Remove duplicate DEFSYM for
4238 Qgnutls_bootprop_verify_hostname_error, an error for
4239 Qgnutls_bootprop_verify_error (which is no longer used).
4240
7d47b580
JB
4241 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4242 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4243 Also (re)move comments that are misplaced or no longer relevant.
4244
1e49bfab
LMI
42452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4246
4247 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4248
1485f4c0
CY
42492011-07-03 Chong Yidong <cyd@stupidchicken.com>
4250
4251 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4252 and background color parameters if they have been changed.
4253
a9ab721e
LMI
42542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4255
4256 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4257
cf7cff57
PE
42582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4259
2e13213d
PE
4260 * xsettings.c (SYSTEM_FONT): Define only when used.
4261 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4262
cf7cff57
PE
4263 * keymap.c (access_keymap_1): Now static.
4264
7a8e04f7
CY
42652011-07-02 Chong Yidong <cyd@stupidchicken.com>
4266
4267 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4268 leave any prefix arg for the up event (Bug#1586).
4269
61352f62
LMI
42702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4271
69bb1ef7
LMI
4272 * lread.c (syms_of_lread): Mention single symbols defined by
4273 `defvar' or `defconst' (bug#7154).
4274
61352f62 4275 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4276 (Frequire): Mention get-load-suffixes.
61352f62 4277
28545e04
MR
42782011-07-02 Martin Rudalics <rudalics@gmx.at>
4279
4280 * window.h (window): Remove clone_number slot.
4281 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4282 Remove.
4283 (make_parent_window, make_window, saved_window)
4284 (Fset_window_configuration, save_window_save): Don't deal with
4285 clone numbers.
4286 * buffer.c (Qclone_number): Remove declaration.
4287 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4288
3349e122
SM
42892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 Add multiple inheritance to keymaps.
4292 * keymap.c (Fmake_composed_keymap): New function.
4293 (Fset_keymap_parent): Simplify.
4294 (fix_submap_inheritance): Remove.
4295 (access_keymap_1): New function extracted from access_keymap to handle
4296 embedded parents and handle lists of maps.
4297 (access_keymap): Use it.
4298 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4299 (Fcopy_keymap): Handle embedded parents.
4300 (Fcommand_remapping, define_as_prefix): Simplify.
4301 (Fkey_binding): Simplify.
4302 (syms_of_keymap): Move minibuffer-local-completion-map,
4303 minibuffer-local-filename-completion-map,
4304 minibuffer-local-must-match-map, and
4305 minibuffer-local-filename-must-match-map to Elisp.
4306 (syms_of_keymap): Defsubr make-composed-keymap.
4307 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4308 (parse_menu_item): Trivial simplification.
4309
3279eb87
GM
43102011-07-01 Glenn Morris <rgm@gnu.org>
4311
4312 * Makefile.in (SETTINGS_LIBS): Fix typo.
4313
4550efdf
KI
43142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4315
4316 * coding.c (Fencode_coding_string): Record the last coding system
4317 used, as the function doc string says (bug#8738).
4318
0949d2b6
JD
43192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4320
4321 * xsettings.c (store_monospaced_changed): Take new font as arg and
4322 check for change against current_mono_font.
4323 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4324 (emacs_settings_constructor, emacs_settings_get_property)
4325 (emacs_settings_set_property, emacs_settings_class_init)
4326 (emacs_settings_init, gsettings_obj): Remove.
4327 (something_changedCB): New function for HAVE_GSETTINGS.
4328 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4329 with value as argument.
4330 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4331 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4332 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4333 "changed".
4334
4335 * xgselect.c: Add defined (HAVE_GSETTINGS).
4336 (xgselect_initialize): Ditto.
4337
4338 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4339 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4340 xg_select.
4341
bbc6b304
PE
43422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 * eval.c (struct backtrace): Simplify and port the data structure.
4345 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4346 signed bit field, as this assumption is not portable and it makes
4347 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4348 "char debug_on_exit : 1" as this is not portable either; instead,
4349 use the portable "unsigned int debug_on_exit : 1". Remove unused
4350 member evalargs. Remove obsolete comments about cc bombing out.
4351
9851bfc5
JD
43522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4353
51bb811f 4354 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4355 Let HAVE_GSETTINGS override HAVE_GCONF.
4356 (store_monospaced_changed): New function.
4357 (EMACS_SETTINGS): A new type derived from GObject to handle
4358 GSettings notifications.
4359 (emacs_settings_constructor, emacs_settings_get_property)
4360 (emacs_settings_set_property, emacs_settings_class_init):
4361 New functions.
4362 (gsettings_client, gsettings_obj): New variables.
4363 (GSETTINGS_SCHEMA): New define.
4364 (something_changedCB): Call store_monospaced_changed.
4365 (init_gsettings): New function.
4366 (xsettings_initialize): Call init_gsettings.
4367 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4368 to NULL.
4369
640c8776 4370 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4371 GCONF_CFLAGS/LIBS.
4372
5386012d
MR
43732011-06-29 Martin Rudalics <rudalics@gmx.at>
4374
4375 * window.c (resize_root_window, grow_mini_window)
4376 (shrink_mini_window): Rename Qresize_root_window to
4377 Qwindow_resize_root_window and Qresize_root_window_vertically to
4378 Qwindow_resize_root_window_vertically.
4379
f13e0b08
PE
43802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4381
4382 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4383
94515237
JB
43842011-06-27 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * makefile.w32-in: Redesign dependencies so they reflect more
4387 clearly which files are directly included by each source file,
4388 and not through other includes.
4389
e43b6e43
MR
43902011-06-27 Martin Rudalics <rudalics@gmx.at>
4391
4392 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4393 (sort_overlays, overlay_strings): When an overlay's clone number
4394 matches the window's clone number process the overlay even if
4395 the overlay's window property doesn't match the current window.
4396
d68443dc
MR
4397 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4398 (Fwindow_hchild): Rename to Fwindow_left_child.
4399 (Fwindow_next): Rename to Fwindow_next_sibling.
4400 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4401 (resize_window_check): Rename to window_resize_check.
4402 (resize_window_apply): Rename to window_resize_apply.
4403 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4404 (Fdelete_other_windows_internal, resize_frame_windows)
4405 (Fsplit_window_internal, Fdelete_window_internal)
4406 (grow_mini_window, shrink_mini_window)
4407 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4408
c7e73be5
JD
44092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4410
4411 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4412 (emacs_fixed_set_min_size): Remove.
4413 (emacs_fixed_new): Take frame as argument.
4414
4415 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4416 (_EmacsFixedPrivate): Remove minwidth/height.
4417 Add struct frame *f.
4418 (emacs_fixed_init): Initialize priv->f.
4419 (get_parent_class, emacs_fixed_set_min_size): Remove.
4420 (emacs_fixed_new): Set priv->f to argument.
4421 (emacs_fixed_get_preferred_width)
4422 (emacs_fixed_get_preferred_height): Use min_width/height from
4423 frames size_hint to set minimum and natural (Bug#8919).
4424 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4425 and use min_width/height from frames size_hint to set
4426 min_width/height (Bug#8919).
4427
4428 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4429 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4430 Fix indentation.
c7e73be5 4431
cf99dcf8
EZ
44322011-06-26 Eli Zaretskii <eliz@gnu.org>
4433
4434 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4435 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4436 called at ZV.
4437
029529ac
CY
44382011-06-26 Chong Yidong <cyd@stupidchicken.com>
4439
4440 * process.c (wait_reading_process_output): Bypass select if
4441 waiting for a cell while ignoring keyboard input, and input is
4442 pending. Suggested by Jan Djärv (Bug#8869).
4443
7a7ef429
PE
44442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 Use gnulib's dup2 module instead of rolling our own.
4447 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4448
11fdef7d 44492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4450
4451 * dispnew.c (scrolling_window): Before scrolling, turn off a
4452 mouse-highlight in the window being scrolled.
4453
cd3520a4
JB
44542011-06-24 Juanma Barranquero <lekktu@gmail.com>
4455
4456 Move DEFSYM to lisp.h and use everywhere.
4457
4458 * character.h (DEFSYM): Move declaration...
4459 * lisp.h (DEFSYM): ...here.
4460
4461 * gnutls.c:
4462 * minibuf.c:
4463 * w32menu.c:
4464 * w32proc.c:
4465 * w32select.c: Don't include character.h.
4466
4467 * alloc.c (syms_of_alloc):
4468 * buffer.c (syms_of_buffer):
4469 * bytecode.c (syms_of_bytecode):
4470 * callint.c (syms_of_callint):
4471 * casefiddle.c (syms_of_casefiddle):
4472 * casetab.c (init_casetab_once):
4473 * category.c (init_category_once, syms_of_category):
4474 * ccl.c (syms_of_ccl):
4475 * cmds.c (syms_of_cmds):
4476 * composite.c (syms_of_composite):
4477 * dbusbind.c (syms_of_dbusbind):
4478 * dired.c (syms_of_dired):
4479 * dispnew.c (syms_of_display):
4480 * doc.c (syms_of_doc):
4481 * editfns.c (syms_of_editfns):
4482 * emacs.c (syms_of_emacs):
4483 * eval.c (syms_of_eval):
4484 * fileio.c (syms_of_fileio):
4485 * fns.c (syms_of_fns):
4486 * frame.c (syms_of_frame):
4487 * fringe.c (syms_of_fringe):
4488 * insdel.c (syms_of_insdel):
4489 * keymap.c (syms_of_keymap):
4490 * lread.c (init_obarray, syms_of_lread):
4491 * macros.c (syms_of_macros):
4492 * msdos.c (syms_of_msdos):
4493 * print.c (syms_of_print):
4494 * process.c (syms_of_process):
4495 * search.c (syms_of_search):
4496 * sound.c (syms_of_sound):
4497 * syntax.c (init_syntax_once, syms_of_syntax):
4498 * terminal.c (syms_of_terminal):
4499 * textprop.c (syms_of_textprop):
4500 * undo.c (syms_of_undo):
4501 * w32.c (globals_of_w32):
4502 * window.c (syms_of_window):
4503 * xdisp.c (syms_of_xdisp):
4504 * xfaces.c (syms_of_xfaces):
4505 * xfns.c (syms_of_xfns):
4506 * xmenu.c (syms_of_xmenu):
4507 * xsettings.c (syms_of_xsettings):
4508 * xterm.c (syms_of_xterm): Use DEFSYM.
4509
4228cf16
TZ
45102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4511
cd3520a4 4512 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4513
7fcccf1e
PE
45142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4515
7efb4e0e
PE
4516 Integer and buffer overflow fixes (Bug#8873).
4517
ff5844ad
PE
4518 * print.c (printchar, strout): Check for string overflow.
4519 (PRINTPREPARE, printchar, strout):
4520 Don't set size unless allocation succeeds.
4521
90532f02
PE
4522 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4523 for sizes. Check for string overflow more accurately.
4524 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4525
6d84508d
PE
4526 * macros.c: Integer and buffer overflow fixes.
4527 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4528 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4529 Use ptrdiff_t, not int, for sizes.
4530 Don't increment bufsize until after realloc succeeds.
4531 Check for size-calculation overflow.
4532 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4533
437b2cb4
PE
4534 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4535
8b9ac8b4
PE
4536 * lread.c: Integer overflow fixes.
4537 (read_integer): Radix is now EMACS_INT, not int,
4538 to improve quality of diagnostics for out-of-range radices.
4539 Calculate buffer size correctly for out-of-range radices.
4540 (read1): Check for integer overflow in radices, and in
4541 read-circle numbers.
82cb60d3
PE
4542 (read_escape): Avoid int overflow.
4543 (Fload, openp, read_buffer_size, read1)
4544 (substitute_object_recurse, read_vector, read_list, map_obarray):
4545 Use ptrdiff_t, not int, for sizes.
4546 (read1): Use EMACS_INT, not int, for sizes.
20270765 4547 Check for size overflow.
8b9ac8b4 4548
7fcccf1e
PE
4549 * image.c (cache_image): Check for size arithmetic overflow.
4550
bfbbd7e7
PE
4551 * lread.c: Integer overflow issues.
4552 (saved_doc_string_size, saved_doc_string_length)
4553 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4554 Now ptrdiff_t, not int.
4555 (read1): Don't assume doc string length fits in int. Check for
4556 out-of-range doc string lengths.
4557 (read_list): Don't assume file position fits in int.
39019e54 4558 (read_escape): Check for hex character overflow.
bfbbd7e7 4559
4e323265
LL
45602011-06-22 Leo Liu <sdl.web@gmail.com>
4561
4562 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4563 Move to minibuffer.el.
4564
85fece3e
PE
45652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4566
20b84ce9 4567 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4568 The following patches are for when GLYPH_DEBUG && !XASSERT.
4569 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4570 * dispnew.c (flush_stdout):
4571 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4572 Mark as externally visible.
4573 * dispnew.c (check_window_matrix_pointers): Now static.
4574 * dispnew.c (window_to_frame_vpos):
4575 * xfns.c (unwind_create_frame):
4576 * xterm.c (x_check_font): Remove unused local.
4577 * scroll.c (CHECK_BOUNDS):
4578 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4579 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4580 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4581 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4582 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4583 Now static.
4584 (debug_method_add): Use va_list and vsprintf rather than relying
4585 on undefined behavior with wrong number of arguments.
4586 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4587 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4588 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4589 since we're not interested in debugging glyphs with old libraries.
4590 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4591 GCC 4.6.0's static checking.
4592
0766b489
PE
45932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4594
31fd4b32
PE
4595 Integer overflow and signedness fixes (Bug#8873).
4596 A few related buffer overrun fixes, too.
4597
b79e8648
PE
4598 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4599
0766b489
PE
4600 * dispextern.h (struct face.stipple):
4601 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4602 (x_bitmap_mask, x_allocate_bitmap_record)
4603 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4604 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4605 (x_create_bitmap_from_xpm_data):
4606 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4607 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4608 (.bitmaps_last):
4609 * xfaces.c (load_pixmap):
4610 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4611 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4612 (.bitmaps_last, struct x_output.icon_bitmap):
4613 Use ptrdiff_t, not int, for bitmap indexes.
4614 (x_allocate_bitmap_record): Check for size overflow.
4615 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4616
b081724f
PE
4617 Use ptrdiff_t, not int, for overlay counts.
4618 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4619 * editfns.c (overlays_around, get_pos_property):
4620 * textprop.c (get_char_property_and_overlay):
4621 * xdisp.c (next_overlay_change, note_mouse_highlight):
4622 * xfaces.c (face_at_buffer_position):
21514da7
PE
4623 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4624 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4625 (Fnext_overlay_change, Fprevious_overlay_change)
4626 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4627 Use ptrdiff_t, not int, for sizes.
21514da7 4628 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4629
3de73e5e
PE
4630 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4631
2606c57b
PE
4632 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4633 (x_session_initialize): Do not assume string length fits in int.
4634
aaafe47a
PE
4635 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4636 This is unlikely, but can occur if DPI is outlandish.
4637
2674ddc8 4638 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4639 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4640
28154962
PE
4641 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4642 * xrdb.c (magic_file_p, search_magic_path):
4643 Omit last arg SUFFIX; it was always 0. All callers changed.
4644 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4645
7de51af5
PE
4646 * xfont.c (xfont_match): Avoid need for strlen.
4647
25ed6cc3
PE
4648 * xfns.c: Don't assume strlen fits in int.
4649 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4650
4eab31dd
PE
4651 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4652 not unsigned long, as we prefer signed integers. All callers changed.
4653 Detect integer overflow in repeat count.
4654 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4655 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4656
171e2a58
PE
4657 * termcap.c: Don't assume sizes fit in int and never overflow.
4658 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4659 (gobble_line): Check for size-calculation overflow.
4660
ad39faca 4661 * minibuf.c (Fread_buffer):
6e5bb2dc 4662 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4663 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4664 Don't assume string length fits in int.
4665
52c61c22 4666 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4667 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4668
b5b8c9e5
PE
4669 * font.c: Don't assume string length fits in int.
4670 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4671 Use ptrdiff_t, not int.
ccd6111c
PE
4672 (font_intern_prop): Don't assume string length fits in int.
4673 Don't assume integer property fits in fixnum.
4674 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4675
882f0d81 4676 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4677 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4678 Reformulate so as not to need the command string.
4679 Invoke gzip -cd rather than gunzip, as it's more portable.
4680 (lock_info_type, lock_file_1, lock_file):
4681 Don't assume pid_t and time_t fit in unsigned long.
4682 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4683 (current_lock_owner): Prefer signed type for sizes.
4684 Use memcpy, not strncpy, where memcpy is what is really wanted.
4685 Don't assume (via atoi) that time_t and pid_t fit in int.
4686 Check for time_t and/or pid_t out of range, e.g., via a network share.
4687 Don't alloca where an auto var works fine.
4688
93f4cf88
PE
4689 * fileio.c: Fix some integer overflow issues.
4690 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4691 Don't assume string length fits in int.
4692 (directory_file_name): Don't assume string length fits in long.
4693 (make_temp_name): Don't assume pid fits in int, or that its print
4694 length is less than 20.
4695
f3e92b69
PE
4696 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4697
1bfdaf10
PE
4698 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4699
35016e9a
PE
4700 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4701
3d1e65a1
PE
4702 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4703 We prefer signed integers, even for size calculations.
4704
0b963a93
PE
4705 * emacs.c: Don't assume string length fits in 'int'.
4706 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4707 (main): Don't invoke strlen when not needed.
4708
573f4b54
PE
4709 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4710 (XD_DEBUG_MESSAGE): Don't waste a byte.
4711
989f33ba
PE
4712 * callproc.c (getenv_internal_1, getenv_internal)
4713 (Fgetenv_internal):
965d34eb
PE
4714 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4715
e4d29b33
PE
4716 * lread.c (invalid_syntax): Omit length argument.
4717 All uses changed. This doesn't fix a bug, but it simplifies the
4718 code away from its former Hollerith-constant appearance, and it's
4719 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4720 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4721
eb49b136
PE
4722 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4723 This didn't break anything, but it didn't help either.
4724 It's confusing to put a bogus integer in a place where the actual
4725 value does not matter.
9f62aeb1 4726 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4727 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4728
15375a22
PE
4729 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4730 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4731 implementation.
b61cc01c
PE
4732 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4733 We prefer signed types, and the value cannot exceed the EMACS_INT
4734 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4735 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4736 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4737 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4738
53b2623d
PE
4739 * indent.c (sane_tab_width): New function.
4740 (current_column, scan_for_column, Findent_to, position_indentation)
4741 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4742 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4743
51cab52b 4744 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4745
f2ed8a70
PE
4746 * lisp.h (lint_assume): New macro.
4747 * composite.c (composition_gstring_put_cache):
4748 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4749
abe80cc6
PE
4750 * editfns.c, insdel.c:
4751 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4752
b02c740e
PE
4753 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4754
ebc96716
PE
4755 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4756
b4e50fa0 4757 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4758 Use much-faster test for byte-length change.
311d5d7c 4759 Don't assume string byte-length fits in 'int'.
a4cf38e4 4760 Check that character arg fits in 'int'.
85461888 4761 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4762
c0c1ee9f
PE
4763 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4764
a498d7f4
PE
4765 * fns.c (concat): Catch string overflow earlier.
4766 Do not rely on integer wraparound.
4767
51cab52b
PE
4768 * dispextern.h (struct it.overlay_strings_charpos)
4769 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4770 * xdisp.c (forward_to_next_line_start)
4771 (back_to_previous_visible_line_start)
4772 (reseat_at_next_visible_line_start, next_element_from_buffer):
4773 Don't arbitrarily truncate the value of 'selective' to int.
4774
76031fad
PE
4775 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4776
5eb55db9
PE
4777 * composite.c: Don't truncate sizes to 'int'.
4778 (composition_gstring_p, composition_reseat_it)
4779 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4780 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4781 not EMACS_UINT, for indexes.
5eb55db9 4782
0703a717
PE
4783 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4784
d6202519
PE
4785 * buffer.c: Include <verify.h>.
4786 (struct sortvec.priority, struct sortstr.priority):
8961a454 4787 Now EMACS_INT, not int.
c20998a7 4788 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4789 (struct sortstr.size, record_overlay_string)
4790 (struct sortstrlist.size, struct sortlist.used):
4791 Don't truncate size to int.
4792 (record_overlay_string): Check for size-calculation overflow.
d6202519 4793 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4794
d5a19415
JM
47952011-06-22 Jim Meyering <meyering@redhat.com>
4796
029529ac 4797 Don't leak an XBM-image-sized buffer
d5a19415
JM
4798 * image.c (xbm_load): Free the image buffer after using it.
4799
a9041e6c
PE
48002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 Port to Sun C.
4803 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4804 that Sun C diagnosed.
4805 * fns.c (secure_hash): Fix pointer signedness issue.
4806 * intervals.c (static_offset_intervals): New function.
4807 (offset_intervals): Use it.
4808
7f3f739f
LL
48092011-06-21 Leo Liu <sdl.web@gmail.com>
4810
4811 * deps.mk (fns.o):
4812 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4813 sha512.h.
4814
4815 * fns.c (secure_hash): Rename from crypto_hash_function and change
4816 the first arg to accept symbols.
5b66d427 4817 (Fsecure_hash): New primitive.
7f3f739f
LL
4818 (syms_of_fns): New symbols.
4819
76147d94
DD
48202011-06-20 Deniz Dogan <deniz@dogan.se>
4821
4822 * process.c (Fset_process_buffer): Clarify return value in
4823 docstring.
4824
7d7d0045
CY
48252011-06-18 Chong Yidong <cyd@stupidchicken.com>
4826
4827 * dispnew.c (add_window_display_history): Use BVAR.
4828
4829 * xdisp.c (debug_method_add): Use BVAR.
4830 (check_window_end, dump_glyph_matrix, dump_glyph)
4831 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4832
4833 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4834 Likewise.
4835
4836 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4837 check till after the cache is created in init_frame_faces.
4838
ff2bc410
SM
48392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4840
4841 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4842
28177add
PE
48432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4844
dd3482fe
PE
4845 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4846 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4847 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4848
393d71f3 4849 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4850 * fileio.c (Finsert_file_contents):
4851 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4852 Remove the old (too-loose) buffer overflow checks.
4853 They weren't needed, since make_gap checks for buffer overflow.
4854 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4855 The old code merely checked for Emacs fixnum overflow, and relied
4856 on undefined (wraparound) behavior. The new code avoids undefined
4857 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4858
2e6813b0 4859 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4860 Tune. Don't use wider integers than needed. Don't use alloca.
4861 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4862
599a9e4f
PE
4863 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4864
99561444
PE
4865 * insdel.c, lisp.h (buffer_overflow): New function.
4866 (insert_from_buffer_1, replace_range, replace_range_2):
4867 * insdel.c (make_gap_larger):
4868 * editfns.c (Finsert_char):
4869 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4870
28177add
PE
4871 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4872
e69dafad
PE
48732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4874
4baa020d 4875 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4876
b1c46f02
PE
4877 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4878 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4879
e69dafad
PE
4880 * fileio.c: Don't assume EMACS_INT fits in off_t.
4881 (emacs_lseek): New static function.
4882 (Finsert_file_contents, Fwrite_region): Use it.
4883 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4884
566684ea
PE
4885 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4886
e6966cd6
PE
4887 * fns.c: Don't overflow int when computing a list length.
4888 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4889 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4890 truncation on 64-bit hosts. Check for QUIT every
4891 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4892 faster and is responsive enough.
4893 (Flength): Report an error instead of overflowing an integer.
4894 (Fsafe_length): Return a float if the value is not representable
4895 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4896 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4897 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4898
dd0b0efb
PE
4899 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4900 (header_size, word_size): New constants.
4901 (allocate_vectorlike): Don't check size overflow here.
4902 (allocate_vector): Check it here instead, since this is the only
4903 caller of allocate_vectorlike that could cause overflow.
4904 Check that the new vector's length is representable as a fixnum.
4905
86fe5cfe
PE
4906 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4907 The previous code was bogus. For example, next_almost_prime (32)
4908 returned 39, which is undesirable as it is a multiple of 3; and
4909 next_almost_prime (24) returned 25, which is a multiple of 5 so
4910 why was the code bothering to check for multiples of 7?
4911
80e88859
PE
4912 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4913
4a2f0ad6
PE
4914 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4915
f66c7cf8
PE
4916 Variadic C functions now count arguments with ptrdiff_t.
4917 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4918 Back then I didn't know that the Emacs coding style prefers signed int.
4919 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4920 were being counted with int, which may truncate counts on 64-bit
4921 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4922 * lisp.h (struct Lisp_Subr.function.aMANY)
4923 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4924 Arg counts are now ptrdiff_t, not size_t.
4925 All variadic functions and their callers changed accordingly.
4926 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4927 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4928 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4929 * callint.c (Fcall_interactively): Check arg count for overflow,
4930 to avoid potential buffer overrun. Use signed char, not 'int',
4931 for 'varies' array, so that we needn't bother to check its size
4932 calculation for overflow.
4933 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4934 * eval.c (apply_lambda):
4935 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4936 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4937 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4938
a1759b76
PE
4939 * callint.c (Fcall_interactively): Don't use index var as event count.
4940
d96be9fc
PE
4941 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4942 * mem-limits.h (SIZE): Remove; no longer used.
4943
a690a978 4944 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4945
578c21e6
PE
4946 Remove unnecessary casts.
4947 * xterm.c (x_term_init):
4948 * xfns.c (x_set_border_pixel):
4949 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4950 These aren't needed now that we assume ANSI C.
4951
96f53c6c
PE
4952 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4953 It's more likely to cause problems (due to unsigned overflow)
4954 than to cure them.
4955
83c77d31
PE
4956 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4957
ee2079f1
PE
4958 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4959
6da65536
PE
4960 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4961
7147c4a4
PE
4962 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4963
193e32d9
PE
4964 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4965
e5533da6
PE
4966 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4967
9910e595
PE
4968 GLYPH_CODE_FACE returns EMACS_INT, not int.
4969 * dispextern.h (merge_faces):
4970 * xfaces.c (merge_faces):
01103c44
PE
4971 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4972 Don't assume EMACS_INT fits in int.
9910e595 4973
2638320e
PE
4974 * character.h (CHAR_VALID_P): Remove unused parameter.
4975 * fontset.c, lisp.h, xdisp.c: All uses changed.
4976
045eb8d9
PE
4977 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4978
c1f134b5
PE
4979 * fns.c (concat): Minor tuning based on overflow analysis.
4980 This doesn't fix any bugs. Use int to hold character, instead
4981 of constantly refetching from Emacs object. Use XFASTINT, not
4982 XINT, for value known to be a character. Don't bother comparing
4983 a single byte to 0400, as it's always less.
4984
395fcb93 4985 * floatfns.c (Fexpt):
327eeec8
PE
4986 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4987
abbd3d23
PE
4988 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4989 for characters.
4990
684a03ef
PE
4991 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4992
0fed43f3
PE
4993 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4994 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4995 incorrectly succeed when S was a string, because 4294967386 was
4996 truncated before it was used.
4997
8fd02eb7
PE
4998 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4999 Otherwise, an out-of-range integer could cause undefined behavior
5000 on a 64-bit host.
5001
f8c86b69
PE
5002 * composite.c: Use int, not EMACS_INT, for characters.
5003 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5004 EMACS_INT, for values that are known to be in character range.
5005 This doesn't fix any bugs but is the usual style inside Emacs and
5006 may generate better code on 32-bit machines.
5007
34206dd2
PE
5008 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5009 This is for reasons similar to the recent CHAR_STRING fix.
5010 * charset.c (Fencode_char): Check that character arg is actually
5011 a character. Pass an int to ENCODE_CHAR.
5012 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5013 wider than 'int', as a compile-time check to prevent future regressions
5014 in this area.
5015
c5958d4c 5016 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5017
5018 Make sure a 64-bit char is never passed to CHAR_STRING.
5019 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5020 by silently ignoring the top 32 bits, allowing some values
5021 that were far too large to be valid characters.
5022 * character.h: Include <verify.h>.
5023 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5024 arguments are no wider than unsigned, as a compile-time check
5025 to prevent future regressions in this area.
5026 * data.c (Faset):
01103c44 5027 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5028 (Fsubst_char_in_region):
5029 * fns.c (concat):
5030 * xdisp.c (decode_mode_spec_coding):
5031 Adjust to CHAR_STRING's new requirement.
5032 * editfns.c (Finsert_char, Fsubst_char_in_region):
5033 * fns.c (concat): Check that character args are actually
5034 characters. Without this test, these functions did the wrong
5035 thing with wildly out-of-range values on 64-bit hosts.
5036
d37ca623
PE
5037 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5038 These casts should not be needed on 32-bit hosts, either.
5039 * keyboard.c (read_char):
5040 * lread.c (Fload): Remove casts to unsigned.
5041
ea204efb
PE
5042 * lisp.h (UNSIGNED_CMP): New macro.
5043 This fixes comparison bugs on 64-bit hosts.
5044 (ASCII_CHAR_P): Use it.
5045 * casefiddle.c (casify_object):
01103c44 5046 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5047 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5048 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5049 * dispextern.h (FACE_FROM_ID):
5050 * keyboard.c (read_char): Use UNSIGNED_CMP.
5051
41cb286c
PE
5052 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5053 not to EMACS_INT, to avoid GCC warning.
5054
4a1b9832
PE
5055 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5056
55daad71
PE
5057 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5058 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5059 isn't needed on 32-bit machines.
8f95c75c 5060
01103c44
PE
5061 * buffer.c (Fgenerate_new_buffer_name):
5062 Use EMACS_INT for count, not int.
0ceccced 5063 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5064
5065 * data.c (Qcompiled_function): Now static.
5066
c6f072e7
PE
5067 * window.c (window_body_lines): Now static.
5068
20ce5912
PE
5069 * image.c (gif_load): Rename local to avoid shadowing.
5070
9c4c5f81
PE
5071 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5072 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5073 * alloc.c (make_save_value): Integer argument is now of type
5074 ptrdiff_t, not int.
5075 (mark_object): Use ptrdiff_t, not int.
5076 * lisp.h (pD): New macro.
5077 * print.c (print_object): Use it.
5078
c0c5c8ae
PE
5079 * alloc.c: Use EMACS_INT, not int, to count objects.
5080 (total_conses, total_markers, total_symbols, total_vector_size)
5081 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5082 (total_free_floats, total_floats, total_free_intervals)
5083 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5084 Now EMACS_INT, not int. All uses changed.
5085 (Fgarbage_collect): Compute overall total using a double, so that
5086 integer overflow is less likely to be a problem. Check for overflow
5087 when converting back to an integer.
5a25e253
PE
5088 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5089 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5090 These were 'int' variables that could overflow on 64-bit hosts;
5091 they were never used, so remove them instead of repairing them.
211a0b2a 5092 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5093 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5094 Previously, this ceilinged at INT_MAX, but that doesn't work on
5095 64-bit machines.
e46bb31a 5096 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5097
c78baabf 5098 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5099 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5100 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5101 when a (possibly-narrower) signed value would do just as well.
5102 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5103
c9d624c6
PE
5104 * alloc.c: Catch some string size overflows that we were missing.
5105 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5106 for convenience in STRING_BYTES_MAX.
5107 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5108 The definition here is exact; the one in lisp.h was approximate.
5109 (allocate_string_data): Check for string overflow. This catches
5110 some instances we weren't catching before. Also, it catches
5111 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5112 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5113 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5114
c9d624c6
PE
5115 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5116 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5117 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5118
353032ce
PE
5119 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5120
2bccce07
PE
5121 * alloc.c (Fmake_string): Check for out-of-range init.
5122
0ac30604
SM
51232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5124
5125 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5126
c195f2de
JD
51272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5128
5129 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5130 xg_get_default_scrollbar_width.
5131
5132 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5133 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5134 (style_changed_cb): Call update_theme_scrollbar_width and call
5135 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5136 all frames (Bug#8505).
5137 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5138 Call gtk_window_set_resizable if HAVE_GTK3.
5139 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5140 and height if HAVE_GTK3 (Bug#8505).
5141 (scroll_bar_width_for_theme): New variable.
5142 (update_theme_scrollbar_width): New function.
5143 (xg_get_default_scrollbar_width): Move code to
5144 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5145 (xg_initialize): Call update_theme_scrollbar_width.
5146
5147 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5148
5149 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5150
e10ac9f1
MR
51512011-06-12 Martin Rudalics <rudalics@gmx.at>
5152
5153 * frame.c (make_frame): Call other_buffer_safely instead of
5154 other_buffer.
5155
5156 * window.c (temp_output_buffer_show): Call display_buffer with
5157 second argument Vtemp_buffer_show_specifiers and reset latter
5158 immediately after the call.
5159 (Vtemp_buffer_show_specifiers): New variable.
5160 (auto_window_vscroll_p, next_screen_context_lines)
5161 (Vscroll_preserve_screen_position): Remove leading asterisks from
5162 doc-strings.
5163
2d3c217e 51642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5165
7b7f97e8 5166 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5167 * buffer.c (Qclone_number): Remove for now, as it's unused.
5168 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5169 (record_buffer): Remove unused local.
5170 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5171 (set_frame_buffer_list): Remove; unused.
5172 * frame.h (other_visible_frames): Remove decl.
5173 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5174 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5175 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5176 if HAVE_GPM.
5177 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5178 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5179 Define only if HAVE_GPM.
5180 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5181 (update_hints_inhibit): Remove; never set. All uses removed.
5182 * widgetprv.h (emacsFrameClassRec): Remove decl.
5183 * window.c (delete_deletable_window): Now returns void, since it
5184 wasn't returning anything.
5185 (compare_window_configurations): Remove unused locals.
5186 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5187 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5188 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5189 the same widths as pointers. This follows up on the 2011-05-06 patch.
5190 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5191 * xterm.h: Likewise.
5192 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5193
1384b89e
JB
51942011-06-12 Juanma Barranquero <lekktu@gmail.com>
5195
5196 * makefile.w32-in: Update dependencies.
5197 (LISP_H): Add lib/intprops.h.
5198
1100a63c
CY
51992011-06-11 Chong Yidong <cyd@stupidchicken.com>
5200
5201 * image.c (gif_load): Add animation frame delay to the metadata.
5202 (syms_of_image): Use DEFSYM. New symbol `delay'.
5203
6198ccd0
MR
52042011-06-11 Martin Rudalics <rudalics@gmx.at>
5205
5206 * window.c (delete_deletable_window): Re-add.
5207 (Fset_window_configuration): Rewrite to handle dead buffers and
5208 consequently deletable windows.
5209 (window_tree, Fwindow_tree): Remove. Supply functionality in
5210 window.el.
5211 (compare_window_configurations): Simplify code.
5212
b6e3633c
AS
52132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5214
1ab0dee5
AS
5215 * image.c (imagemagick_load_image): Fix type mismatch.
5216 (Fimagemagick_types): Likewise.
5217
b6e3633c
AS
5218 * window.h (replace_buffer_in_windows): Declare.
5219
9397e56f
MR
52202011-06-11 Martin Rudalics <rudalics@gmx.at>
5221
5222 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5223 Qclone_number. Remove external declaration of Qdelete_window.
5224 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5225 code.
640c8776
SM
5226 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5227 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5228 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5229 buffer list implementation.
5230 (other_buffer_safely): New function.
5231 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5232 calls to replace_buffer_in_windows and
5233 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5234 if allowed.
5235 (record_buffer): Inhibit quitting and rewrite using quittable
5236 functions. Run Qbuffer_list_update_hook if allowed.
5237 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5238 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5239 Move switch-to-buffer to window.el.
9397e56f
MR
5240 (bury-buffer): Move to window.el.
5241 (Vbuffer_list_update_hook): New variable.
5242
5243 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5244 section.
5245
5246 * window.h (resize_frame_windows): Move up in code.
5247 (Fwindow_frame): Remove EXFUN.
5248 (replace_buffer_in_all_windows): Remove prototype.
5249 (replace_buffer_in_windows_safely): Add prototype.
5250
5251 * window.c: Declare Qdelete_window static again. Move down
5252 declaration of select_count.
5253 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5254 (Fother_window): Move to window.el.
5255 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5256 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5257 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5258 window.el.
5259 (replace_buffer_in_windows): Implement by calling
5260 Qreplace_buffer_in_windows.
5261 (replace_buffer_in_all_windows): Remove with some functionality
5262 moved into replace_buffer_in_windows_safely.
5263 (replace_buffer_in_windows_safely): New function.
5264 (select_window_norecord, select_frame_norecord): Move in front
5265 of run_window_configuration_change_hook. Remove now obsolete
5266 declarations.
640c8776
SM
5267 (Fset_window_buffer): Rewrite doc-string.
5268 Call Qrecord_window_buffer.
9397e56f
MR
5269 (keys_of_window): Move binding for other-window to window.el.
5270
b50691aa
CY
52712011-06-11 Chong Yidong <cyd@stupidchicken.com>
5272
5273 * dispextern.h (struct image): Replace data member, whose int_val
5274 and ptr_val fields were not used by anything, with a single
5275 lisp_val object.
5276
5277 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5278 (gif_clear_image, gif_load, imagemagick_load_image)
5279 (gs_clear_image, gs_load): Callers changed.
5280
3f754b86
PE
52812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5282
cca69397
PE
5283 * buffer.h: Include <time.h>, for time_t.
5284 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5285
109e28d0
PE
5286 Fix minor problems found by static checking.
5287
60737f02
PE
5288 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5289
4b66faf3
PE
5290 Make identifiers static if they are not used in other modules.
5291 * data.c (Qcompiled_function, Qframe, Qvector):
5292 * image.c (QimageMagick, Qsvg):
5293 * minibuf.c (Qmetadata):
5294 * window.c (resize_window_check, resize_root_window): Now static.
5295 * window.h (resize_window_check, resize_root_window): Remove decls.
5296
109e28d0
PE
5297 * window.c (window_deletion_count, delete_deletable_window):
5298 Remove; unused.
46a4ce9e
PE
5299 (window_body_lines): Now static.
5300 (Fdelete_other_windows_internal): Mark vars as initialized.
5301 Make sure 'resize_failed' is initialized.
5302 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5303 (resize_window_apply): Remove unused local.
5304 * window.h (delete_deletable_window): Remove decl.
5305
109e28d0 5306 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5307 (imagemagick_load_image): Fix pointer signedness problem by changing
5308 last arg from unsigned char * to char *. All uses changed.
5309 Also, fix a local for similar reasons.
5310 Remove unused locals. Remove locals to avoid shadowing.
5311 (fn_rsvg_handle_free): Remove; unused.
5312 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5313 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5314
3f754b86
PE
5315 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5316
2547adb1
CY
53172011-06-10 Chong Yidong <cyd@stupidchicken.com>
5318
5319 * image.c (gif_load): Fix omitted cast error introduced by
5320 2011-06-06 change.
5321
2c8e37d4
MR
53222011-06-10 Martin Rudalics <rudalics@gmx.at>
5323
5324 * window.h (resize_proportionally, orig_total_lines)
5325 (orig_top_line): Remove from window structure.
5326 (set_window_height, set_window_width, change_window_heights)
5327 (Fdelete_window): Remove prototypes.
5328 (resize_frame_windows): Remove duplicate declaration.
5329
440a42e3
EZ
53302011-06-10 Eli Zaretskii <eliz@gnu.org>
5331
5332 * window.h (resize_frame_windows, resize_window_check)
5333 (delete_deletable_window, resize_root_window)
5334 (resize_frame_windows): Declare prototypes.
5335
5336 * window.c (resize_window_apply): Make definition be "static" to
5337 match the prototype.
5338
562dd5e9
MR
53392011-06-10 Martin Rudalics <rudalics@gmx.at>
5340
5341 * window.c: Remove declarations of Qwindow_size_fixed,
5342 window_min_size_1, window_min_size_2, window_min_size,
5343 size_window, window_fixed_size_p, enlarge_window, delete_window.
5344 Remove static from declaration of Qdelete_window, it's
5345 temporarily needed by Fbury_buffer.
5346 (replace_window): Don't assign orig_top_line and
5347 orig_total_lines.
5348 (Fdelete_window, delete_window): Remove. Window deletion is
5349 handled by window.el.
640c8776
SM
5350 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5351 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5352 (Fdelete_other_windows): Remove. Deleting other windows is
5353 handled by window.el.
5354 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5355 handled in window.el.
5356 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5357 Window minimum sizes are handled in window.el.
5358 (shrink_windows, size_window, set_window_height)
5359 (set_window_width, change_window_heights, window_height)
5360 (window_width, CURBEG, CURSIZE, enlarge_window)
5361 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5362 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5363 handled in window.el.
5364 (make_dummy_parent): Rename to make_parent_window and give it a
5365 second argument horflag.
5366 (make_window): Don't set resize_proportionally any more.
5367 (Fsplit_window): Remove. Windows are split in window.el.
5368 (save_restore_action, save_restore_orig_size)
5369 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5370 Resize mini windows in window.el.
5371 (grow_mini_window, shrink_mini_window): Implement by calling
5372 Qresize_root_window_vertically, resize_window_check and
5373 resize_window_apply.
640c8776
SM
5374 (saved_window, Fset_window_configuration, save_window_save):
5375 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5376 resize_proportionally.
5377 (window_min_height, window_min_width): Move to window.el.
5378 (keys_of_window): Move bindings for delete-other-windows,
5379 split-window, delete-window and enlarge-window to window.el.
5380
5381 * buffer.c: Temporarily extern Qdelete_window.
5382 (Fbury_buffer): Temporarily call Qdelete_window instead of
5383 Fdelete_window (Fbury_buffer will move to window.el soon).
5384
5385 * frame.c (set_menu_bar_lines_1): Remove code handling
5386 orig_top_line and orig_total_lines.
5387
5388 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5389 set_window_height but set heights directly.
5390 (change_frame_size_1): Use resize_frame_windows.
5391
5392 * xdisp.c (init_xdisp): Don't use set_window_height but set
5393 heights directly.
5394
640c8776
SM
5395 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5396 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5397 run_window_configuration_change_hook.
5398
5399 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5400 instead of change_window_heights and run
5401 run_window_configuration_change_hook.
5402
1a13852e
MR
54032011-06-09 Martin Rudalics <rudalics@gmx.at>
5404
5405 * window.c (replace_window): Rename second argument REPLACEMENT to
5406 NEW. New third argument SETFLAG. Rewrite.
5407 (delete_window, make_dummy_parent): Call replace_window with
5408 third argument 1.
5409 (window_list_1): Move down in code.
5410 (run_window_configuration_change_hook): Move set_buffer part
5411 before select_frame_norecord part in order to unwind correctly.
5412 Rename count1 to count.
5413 (recombine_windows, delete_deletable_window, resize_root_window)
5414 (Fdelete_other_windows_internal)
5415 (Frun_window_configuration_change_hook, make_parent_window)
5416 (resize_window_check, resize_window_apply, Fresize_window_apply)
5417 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5418 (Fdelete_window_internal, Fresize_mini_window_internal):
5419 New functions.
1a13852e
MR
5420 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5421
f3d1777e
MR
54222011-06-08 Martin Rudalics <rudalics@gmx.at>
5423
496e208e
MR
5424 * window.h (window): Add some new members to window structure -
5425 normal_lines, normal_cols, new_total, new_normal, clone_number,
5426 splits, nest, prev_buffers, next_buffers.
5427 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5428 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5429
f3d1777e
MR
5430 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5431 Remove.
496e208e
MR
5432 (make_dummy_parent): Set new members of windows structure.
5433 (make_window): Move down in code. Handle new members of window
5434 structure.
5435 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5436 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5437 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5438 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5439 (Fset_window_next_buffers, Fset_window_clone_number):
5440 New functions.
496e208e
MR
5441 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5442 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5443 Doc-string fixes.
5444 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5445 Argument WINDOW can be now internal window too.
5446 (Fwindow_use_time): Move up in code.
5447 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5448 Rewrite doc-string.
5449 (Fset_window_configuration, saved_window)
5450 (Fcurrent_window_configuration, save_window_save): Handle new
5451 members of window structure.
b9e809c2
MR
5452 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5453 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5454 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5455 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5456 Qget_mru_window, Qresize_root_window,
5457 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5458 Qauto_buffer_name; staticpro them.
f3d1777e 5459
abde8f8c
MR
54602011-06-07 Martin Rudalics <rudalics@gmx.at>
5461
5462 * window.c (Fwindow_total_size, Fwindow_left_column)
5463 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5464 (Fwindow_list_1): New functions.
5465 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5466 (Fwindow_width, Fscroll_left, Fscroll_right):
5467 Use window_body_cols instead of window_box_text_cols.
5468 (delete_window, Fset_window_configuration):
5469 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5470 (delete_all_subwindows): Take a window as argument and not a
5471 structure. Rewrite.
190b47e6
MR
5472 (window_loop): Remove handling of GET_LRU_WINDOW and
5473 GET_LARGEST_WINDOW.
5474 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5475
5476 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5477 window_box_text_cols. delete_all_subwindows now takes a
5478 Lisp_Object as argument.
abde8f8c 5479
640c8776
SM
5480 * indent.c (compute_motion, Fcompute_motion):
5481 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5482
fa8a67e6
MR
5483 * frame.c (delete_frame): Call delete_all_subwindows with root
5484 window as argument.
5485
a54e3482
DC
54862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5487
5488 * fns.c (Fputhash): Document return value.
5489
60002bf5
CY
54902011-06-06 Chong Yidong <cyd@stupidchicken.com>
5491
5492 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5493
0c671da6 54942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5495
b862a52a 5496 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5497
be44ca6c
PE
5498 Check for overflow when converting integer to cons and back.
5499 * charset.c (Fdefine_charset_internal, Fdecode_char):
5500 Use cons_to_unsigned to catch overflow.
5501 (Fencode_char): Use INTEGER_TO_CONS.
5502 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5503 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5504 * data.c (long_to_cons, cons_to_long): Remove.
5505 (cons_to_unsigned, cons_to_signed): New functions.
5506 These signal an error for invalid or out-of-range values.
5507 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5508 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5509 * font.c (Ffont_variation_glyphs):
5510 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5511 * lisp.h: Include <intprops.h>.
5512 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5513 (cons_to_signed, cons_to_unsigned): New decls.
5514 (long_to_cons, cons_to_long): Remove decls.
5515 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5516 (Fprimitive_undo): Use CONS_TO_INTEGER.
5517 * xfns.c (Fx_window_property): Likewise.
5518 * xselect.c: Include <limits.h>.
5519 (x_own_selection, selection_data_to_lisp_data):
5520 Use INTEGER_TO_CONS.
5521 (x_handle_selection_request, x_handle_selection_clear)
5522 (x_get_foreign_selection, Fx_disown_selection_internal)
5523 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5524 (lisp_data_to_selection_data): Use cons_to_unsigned.
5525 (x_fill_property_data): Use cons_to_signed.
5526 Report values out of range.
5527
d1f3d2af
PE
5528 Check for buffer and string overflow more precisely.
5529 * buffer.h (BUF_BYTES_MAX): New macro.
5530 * lisp.h (STRING_BYTES_MAX): New macro.
5531 * alloc.c (Fmake_string):
5532 * character.c (string_escape_byte8):
5533 * coding.c (coding_alloc_by_realloc):
5534 * doprnt.c (doprnt):
5535 * editfns.c (Fformat):
5536 * eval.c (verror):
5537 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5538 since they may not be the same number.
5539 * editfns.c (Finsert_char):
5540 * fileio.c (Finsert_file_contents):
5541 Likewise for BUF_BYTES_MAX.
5542
dd52fcea
PE
5543 * image.c: Use ptrdiff_t, not int, for sizes.
5544 (slurp_file): Switch from int to ptrdiff_t.
5545 All uses changed.
5546 (slurp_file): Check that file size fits in both size_t (for
5547 malloc) and ptrdiff_t (for sanity and safety).
5548
7f9bbdbb
PE
5549 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5550 if b->modtime has its maximal value.
5551
dfe18f82
PE
5552 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5553
84acfcf0
PE
5554 Don't assume time_t can fit into int.
5555 * buffer.h (struct buffer.modtime): Now time_t, not int.
5556 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5557 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5558
ccd9a01a
PE
5559 Minor fixes for signed vs unsigned integers.
5560 * character.h (MAYBE_UNIFY_CHAR):
5561 * charset.c (maybe_unify_char):
5562 * keyboard.c (read_char, reorder_modifiers):
5563 XINT -> XFASTINT, since the integer must be nonnegative.
5564 * ftfont.c (ftfont_spec_pattern):
5565 * keymap.c (access_keymap, silly_event_symbol_error):
5566 XUINT -> XFASTINT, since the integer must be nonnegative.
5567 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5568 since it makes no difference and we prefer signed.
5569 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5570 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5571 nonnegative.
5572
d6d100dd
SM
55732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5574
5575 * window.h (Fwindow_frame): Declare.
5576
2b6148e4
PE
55772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5578
5579 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5580 (SPARE_MEMORY): Always define.
5581 (LARGE_REQUEST): Remove.
5582 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5583
f230ecc9
MR
55842011-06-06 Martin Rudalics <rudalics@gmx.at>
5585
727e958e
MR
5586 * lisp.h: Move EXFUNS for Fframe_root_window,
5587 Fframe_first_window and Fset_frame_selected_window to window.h.
5588
5589 * window.h: Move EXFUNS for Fframe_root_window,
5590 Fframe_first_window and Fset_frame_selected_window here from
5591 lisp.h.
5592
5593 * frame.c (Fwindow_frame, Fframe_first_window)
5594 (Fframe_root_window, Fframe_selected_window)
5595 (Fset_frame_selected_window): Move to window.c.
5596 (Factive_minibuffer_window): Move to minibuf.c.
5597 (Fother_visible_frames_p): New function.
5598
5599 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5600
f230ecc9
MR
5601 * window.c (decode_window, decode_any_window): Move up in code.
5602 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5603 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5604 (Fwindow_buffer): Move up and rewrite doc-string.
5605 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5606 (Fwindow_prev): New functions.
727e958e
MR
5607 (Fwindow_frame): Move here from frame.c. Accept any window as
5608 argument.
5609 (Fframe_root_window, Fframe_first_window)
5610 (Fframe_selected_window): Move here from frame.c. Accept frame
5611 or arbitrary window as argument. Update doc-strings.
5612 (Fminibuffer_window): Move up in code.
5613 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5614 (Fset_frame_selected_window): Move here from frame.c.
5615 Marginal rewrite.
727e958e
MR
5616 (Fselected_window, select_window, Fselect_window): Move up in
5617 code. Minor doc-string fixes.
f230ecc9 5618
4d09bcf6
PE
56192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5622 Do not assume that spare memory exists; that assumption is valid
5623 only if SYSTEM_MALLOC.
5624 (LARGE_REQUEST): New macro, so that the issue of large requests
5625 is separated from the issue of spare memory.
5626
810928a2
AS
56272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5628
172418ad
AS
5629 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5630 format. (Bug#8806)
5631
43f862f7
AS
5632 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5633
810928a2
AS
5634 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5635 before statements.
5636
a059fe24
JD
56372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5638
5639 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5640
5641 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5642
5643 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5644 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5645
989bf368
JB
56462011-06-05 Juanma Barranquero <lekktu@gmail.com>
5647
5648 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5649
4b80f674
CY
56502011-06-04 Chong Yidong <cyd@stupidchicken.com>
5651
5652 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5653 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5654 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5655 New error handlers.
4b80f674
CY
5656 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5657 Obey Vx_select_enable_clipboard_manager. Catch errors in
5658 x_clipboard_manager_save (Bug#8779).
5659 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5660 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5661
99a33b77 56622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5663
5664 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5665
99a33b77 56662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5667
5668 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5669 in the current matrix if keep_current_p is non-zero.
5670
8264569d
EZ
56712011-06-04 Eli Zaretskii <eliz@gnu.org>
5672
5673 * bidi.c (bidi_level_of_next_char): Fix last change.
5674
57f97249
EZ
56752011-06-03 Eli Zaretskii <eliz@gnu.org>
5676
fec2107c 5677 Support bidi reordering of text covered by display properties.
57f97249 5678
fec2107c
EZ
5679 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5680 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5681 (bidi_cache_search, bidi_cache_iterator_state)
5682 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5683 (bidi_level_of_next_char, bidi_move_to_visually_next):
5684 Support character positions inside a run of characters covered by a
fec2107c
EZ
5685 display string.
5686 (bidi_paragraph_init, bidi_resolve_explicit_1)
5687 (bidi_level_of_next_char): Call bidi_fetch_char and
5688 bidi_fetch_char_advance instead of FETCH_CHAR and
5689 FETCH_CHAR_ADVANCE.
5690 (bidi_init_it): Initialize new members.
5691 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5692 definitions.
5693 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5694 instead of using explicit *_CHAR codes.
d6d100dd
SM
5695 (bidi_resolve_explicit, bidi_resolve_weak):
5696 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5697 bidirectional text is supported only in multibyte buffers.
5698 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5699 it to initialize the frame_window_p member of struct bidi_it.
5700 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5701 (bidi_resolve_explicit, bidi_resolve_weak)
5702 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5703 bidi_it->nchars is non-positive.
5704 (bidi_level_of_next_char): Don't try to lookup the cache for the
5705 next/previous character if nothing is cached there yet, or if we
5706 were just reseat()'ed to a new position.
c40e2fb2 5707
0e14fe90
EZ
5708 * xdisp.c (set_cursor_from_row): Set start and stop points
5709 according to the row's direction when priming the loop that looks
5710 for the glyph on which to display cursor.
5711 (single_display_spec_intangible_p): Function deleted.
5712 (display_prop_intangible_p): Reimplement to call
5713 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5714 Accept 3 additional arguments needed by handle_display_spec.
5715 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5716 values: lists, `(when COND...)' forms, etc.
5717 (single_display_spec_string_p): Support property values that are
5718 lists with the argument STRING its top-level element.
5719 (display_prop_string_p): Fix the condition for processing a
5720 property that is a list to be consistent with handle_display_spec.
fec2107c 5721 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5722 last portion of handle_display_prop.
5723 (compute_display_string_pos): Accept additional argument
5724 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5725 value of a `display' property is a "replacing spec".
5726 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5727 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5728 the display property, but just return a value indicating whether
5729 the display property will replace the characters it covers.
5730 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5731 frame_window_p members of struct bidi_it.
d6d100dd
SM
5732 (compute_display_string_pos, compute_display_string_end):
5733 New functions.
fec2107c
EZ
5734 (push_it): Accept second argument POSITION, where pop_it should
5735 jump to continue iteration.
5736 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5737
fec2107c
EZ
5738 * keyboard.c (adjust_point_for_property): Adjust the call to
5739 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5740
5741 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5742 (bidi_init_it): Update prototypes.
5743 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5744 (compute_display_string_pos, compute_display_string_end):
5745 Declare prototypes.
fec2107c
EZ
5746 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5747 EMACS_INT.
fc6f18ce 5748
40087514 57492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5750
57f53182
PE
5751 Malloc failure behavior now depends on size of allocation.
5752 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5753 * lisp.h: Change signatures accordingly.
5754 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5755 All callers changed. (Bug#8762)
5756
5757 * gnutls.c: Use Emacs's memory allocators.
5758 Without this change, the gnutls library would invoke malloc etc.
5759 directly, which causes problems on non-SYNC_INPUT hosts, and which
5760 runs afoul of improving memory_full behavior. (Bug#8761)
5761 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5762 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5763 xfree instead of the default malloc, realloc, free.
5764 (Fgnutls_boot): No need to check for memory allocation failure,
5765 since xmalloc does that for us.
5766
ac32cd99 5767 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5768 * category.c (hash_get_category_set):
5769 * ccl.c (ccl_driver):
5770 * charset.c (Fdefine_charset_internal):
5771 * charset.h (struct charset.hash_index):
5772 * composite.c (get_composition_id, gstring_lookup_cache)
5773 (composition_gstring_put_cache):
5774 * composite.h (struct composition.hash_index):
5775 * dispextern.h (struct image.hash):
5776 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5777 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5778 (hashfn_equal, hashfn_user_defined, make_hash_table)
5779 (maybe_resize_hash_table, hash_lookup, hash_put)
5780 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5781 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5782 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5783 * image.c (make_image, search_image_cache, lookup_image)
5784 (xpm_put_color_table_h):
5785 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5786 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5787 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5788 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5789 * alloc.c (allocate_vectorlike):
5790 Check for overflow in vector size calculations.
5791 * ccl.c (ccl_driver):
5792 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5793 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5794 need to be updated by these changes.
40087514
PE
5795 * fns.c (make_hash_table, maybe_resize_hash_table):
5796 Check for integer overflow with large hash tables.
0de4bb68
PE
5797 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5798 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5799 (SXHASH_REDUCE): New macro.
5800 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5801 Use it instead of discarding useful hash info with large hash values.
5802 (sxhash_float): New function.
5803 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5804 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5805 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5806 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5807 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5808 Adjust signatures to match updated version of code.
5809 (consing_since_gc): Now EMACS_INT, since a single hash table can
5810 use more than INT_MAX bytes.
5811
698d32e2
DN
58122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5813
5814 Make it possible to build with GCC-4.6+ -O2 -flto.
5815
5816 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5817
fd6fa53f
SM
58182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5819
5820 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5821 Call minibuffer-inactive-mode.
5822
864db017
JB
58232011-05-31 Juanma Barranquero <lekktu@gmail.com>
5824
5825 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5826 Update dependencies.
5827
2ad0baf4
DN
58282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5829
5830 * data.c (init_data): Remove code for UTS, this system is not
5831 supported anymore.
5832
4fcc2638
DN
58332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5834
5835 Don't force ./temacs to start in terminal mode.
5836
5837 * frame.c (make_initial_frame): Initialize faces in all cases, not
5838 only when CANNOT_DUMP is defined.
5839 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5840
c56e0fd5
DN
58412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5842
5843 * dispnew.c (add_window_display_history): Use const for the string
5844 pointer. Remove declaration, not needed.
5845
333d54da 58462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5847
55d4c1b2 5848 Use 'inline', not 'INLINE'.
333d54da 5849 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5850 * alloc.c, fontset.c (INLINE): Remove.
5851 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5852 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5853 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5854 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5855 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5856
738db178
DN
58572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5858
5859 Make it possible to run ./temacs.
5860
5861 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5862 syms_of_callproc does the same thing. Remove test for
5863 "initialized", do it in the caller.
5864 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5865
620c53a6
SM
58662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5867
5868 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5869 (read_minibuf): Use get_minibuffer.
5870 (syms_of_minibuf): Use DEFSYM.
5871 (Qmetadata): New var.
5872 * data.c (Qbuffer): Don't make it static.
5873 (syms_of_data): Use DEFSYM.
5874
e003a292
PE
58752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5876
5877 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5878 (CCL_CODE_MIN): New macro.
5879
ed008a6d
PE
58802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5881
3687c2ef
PE
5882 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5883
ed008a6d
PE
5884 * eval.c (Qdebug): Now static.
5885 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5886 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5887 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5888
d66c4c7c
CY
58892011-05-29 Chong Yidong <cyd@stupidchicken.com>
5890
5891 * image.c: Various fixes to ImageMagick code comments.
5892 (Fimagemagick_types): Doc fix.
5893
5fbc2025
PE
58942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5895
0196f88a
PE
5896 Minor fixes prompted by GCC 4.6.0 warnings.
5897
5898 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5899
5fbc2025
PE
5900 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5901 (x_clipboard_manager_save_all): Move extern decl to ...
5902 * xterm.h: ... here, so that it can be checked for consistency.
5903
1dd3c2d9
CY
59042011-05-29 Chong Yidong <cyd@stupidchicken.com>
5905
5906 * xselect.c (x_clipboard_manager_save_frame)
5907 (x_clipboard_manager_save_all): New functions.
5908 (Fx_clipboard_manager_save): Lisp function deleted.
5909
5910 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5911 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5912
5913 * xterm.h: Update prototype.
5914
5ba6571d
WX
59152011-05-28 William Xu <william.xwl@gmail.com>
5916
5917 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5918 exiting (Bug#8239).
5919
3eaff834
JM
59202011-05-28 Jim Meyering <meyering@redhat.com>
5921
e1900994 5922 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5923 * fns.c (to_uchar): Define.
5924 (crypto_hash_function): Use it to convert some newly-signed
5925 variables to unsigned, to avoid sign-extension bugs. For example,
5926 without this change, (md5 "truc") would evaluate to
5927 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5928 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5929 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5930
0f6990a7
PE
59312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5932
5933 Integer overflow fixes.
c8a9ca5a 5934
08686060
PE
5935 * dbusbind.c: Serial number integer overflow fixes.
5936 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5937 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5938 to hold a serial number that is too large for a fixnum.
5939 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5940 Check for serial numbers out of range. Decode any serial number
59568bf0 5941 that was so large that it became a float. (Bug#8722)
08686060 5942
2d1fc3c7
PE
5943 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5944 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5945 Use XFASTINT rather than XUINT when numbers are nonnegative.
5946 (xd_append_arg, Fdbus_method_return_internal):
5947 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5948 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5949 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5950 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5951 (Bug#8722)
2d1fc3c7 5952
c8a9ca5a
PE
5953 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5954
519e1d69
PE
5955 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5956
6df6ae42 5957 ccl: Add integer overflow checks.
30569699
PE
5958 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5959 (IN_INT_RANGE): New macros.
5960 (ccl_driver): Use them to check for integer overflow when
5961 decoding a CCL program. Many of the new checks are whether XINT (x)
5962 fits in int; it doesn't always, on 64-bit hosts. The new version
5963 doesn't catch all possible integer overflows, but it's an
847044ea 5964 improvement. (Bug#8719)
30569699 5965
c11285dc
PE
5966 * alloc.c (make_event_array): Use XINT, not XUINT.
5967 There's no need for unsigned here.
5968
fdccd48e
PE
5969 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5970 This follows up to the 2011-05-06 change that substituted uintptr_t
5971 for EMACS_INT. This case wasn't caught back then.
5972
37910ab2
PE
5973 Rework Fformat to avoid integer overflow issues.
5974 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5975 now (part of C89). Include <verify.h>.
5976 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5977 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5978 (Fformat): Avoid the prepass trying to compute sizes; it was only
5979 approximate and thus did not catch overflow reliably. Instead, walk
5980 through the format just once, formatting and computing sizes as we go,
5981 checking for integer overflow at every step, and allocating a larger
5982 buffer as needed. Keep track separately whether the format is
5983 multibyte. Keep only the most-recently calculated precision, rather
5984 than them all. Record whether each argument has been converted to
5985 string. Use EMACS_INT, not int, for byte and char and arg counts.
5986 Support field widths and precisions larger than INT_MAX. Avoid
5987 sprintf's undefined behavior with conversion specifications such as %#d
5988 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5989 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5990 formatting out-of-range floating point numbers with int
9173deec 5991 formats. (Bug#8668)
37910ab2 5992
2e6578fb
PE
5993 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5994
0ae6bdee
PE
5995 * data.c: Avoid integer truncation in expressions involving floats.
5996 * data.c: Include <intprops.h>.
5997 (arith_driver): When there's an integer overflow in an expression
5998 involving floating point, convert the integers to floating point
5999 so that the resulting value does not suffer from catastrophic
6000 integer truncation. For example, on a 64-bit host (* 4
6001 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6002 Do not rely on undefined behavior after integer overflow.
6003
de883a70
PE
6004 merge count_size_as_multibyte, parse_str_to_multibyte
6005 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6006 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6007 Check for integer overflow.
6008 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6009 since it's now a duplicate of the other. This is more of
6010 a character than a buffer op, so better that it's in character.c.
6011 * fns.c, print.c: Adjust to above changes.
6012
2ff916cb
PE
60132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6014
6015 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6016
f1b54466
PE
60172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6018
fb1ac845
PE
6019 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6020 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6021 (x_clipboard_manager_save): Now static.
6022 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6023
f1b54466
PE
6024 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6025 (crypto_hash_function): Now static.
6026 Fix pointer signedness problems. Avoid unnecessary initializations.
6027
a9f737ee
CY
60282011-05-27 Chong Yidong <cyd@stupidchicken.com>
6029
6030 * termhooks.h (Vselection_alist): Make it terminal-local.
6031
6032 * terminal.c (create_terminal): Initialize it.
6033
6034 * xselect.c: Support for clipboard managers.
6035 (Vselection_alist): Move to termhooks.h as terminal-local var.
6036 (LOCAL_SELECTION): New macro.
6037 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6038 (symbol_to_x_atom): Remove gratuitous arg.
6039 (x_handle_selection_request, lisp_data_to_selection_data)
6040 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6041 (x_own_selection, x_get_local_selection, x_convert_selection):
6042 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6043 (some_frame_on_display): Delete unused function.
6044 (Fx_own_selection_internal, Fx_get_selection_internal)
6045 (Fx_disown_selection_internal, Fx_selection_owner_p)
6046 (Fx_selection_exists_p): New optional frame arg.
6047 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6048 (x_handle_selection_clear): Don't treat other terminals with the
6049 same keyboard specially. Use the terminal-local Vselection_alist.
6050 (x_clear_frame_selections): Use Frun_hook_with_args.
6051
6052 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6053
6054 * xterm.h: Add support for those atoms.
6055
e067f0c1
CY
60562011-05-26 Chong Yidong <cyd@stupidchicken.com>
6057
6058 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6059 (converted_selections, conversion_fail_tag): New global variables.
6060 (x_selection_request_lisp_error): Free the above.
6061 (x_get_local_selection): Remove unnecessary code.
6062 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6063 of converted selections stored in converted_selections.
6064 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6065 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6066 (x_convert_selection): New function.
6067 (x_handle_selection_event): Simplify.
6068 (x_get_foreign_selection): Don't ignore incoming requests while
6069 waiting for an answer; this will fail when we implement
6070 SAVE_TARGETS, and seems unnecessary anyway.
6071 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6072 (Vx_sent_selection_functions): Doc fix.
6073
0f4aebc0
LL
60742011-05-26 Leo Liu <sdl.web@gmail.com>
6075
6076 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6077
e61124cd
YM
60782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6079
6080 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6081
6082 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6083 for fringe update if it has periodic bitmap.
ac389d0c 6084 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6085 and fringe_bitmap_periodic_p.
6086
6087 * fringe.c (get_fringe_bitmap_data): New function.
6088 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6089 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6090 row. Mark glyph row for fringe update if periodicity changed.
6091
6092 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6093 for fringe update unless it has periodic bitmap.
6094
f16d9837
KH
60952011-05-25 Kenichi Handa <handa@m17n.org>
6096
6097 * xdisp.c (get_next_display_element): Set correct it->face_id for
6098 a static composition.
6099
e1b90ef6
LL
61002011-05-24 Leo Liu <sdl.web@gmail.com>
6101
6102 * deps.mk (fns.o):
6103 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6104
6105 * fns.c (crypto_hash_function, Fsha1): New function.
6106 (Fmd5): Use crypto_hash_function.
6107 (syms_of_fns): Add Ssha1.
6108
7400048f
PE
61092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6110
6111 * gnutls.c: Remove unused macros.
6112 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6113 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6114 Remove macros that are defined and never used.
6115 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6116
abb71cf4
CY
61172011-05-22 Chong Yidong <cyd@stupidchicken.com>
6118
6119 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6120 (Fx_get_selection_internal): Minor cleanup.
6121 (Fx_own_selection_internal): Rename arguments for consistency with
6122 select.el.
6123
6307db39
PE
61242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6125
6126 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6127
f3d4e0a4
CY
61282011-05-22 Chong Yidong <cyd@stupidchicken.com>
6129
6130 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6131
4d8ade89
YM
61322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6133
6134 * dispnew.c (scrolling_window): Don't exclude the case that the
6135 last enabled row in the desired matrix touches the bottom boundary.
6136
32078c8d
GM
61372011-05-21 Glenn Morris <rgm@gnu.org>
6138
6139 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6140 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6141 and add some more files.
32078c8d 6142
7285dc67
EZ
61432011-05-20 Eli Zaretskii <eliz@gnu.org>
6144
6145 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6146 report_file_error introduced by the change from 2011-05-07.
6147
89d1bd22
PE
61482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6149
6150 * systime.h (Time): Define only if emacs is defined.
6151 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6152 where the include path doesn't have X11/X.h by default. See
6153 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6154
cd394be1 61552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6156
6157 * composite.c (find_automatic_composition): Fix previous change.
6158
b9704ad9
GM
61592011-05-20 Glenn Morris <rgm@gnu.org>
6160
6161 * lisp.mk: New file, split from Makefile.in.
6162 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6163 (shortlisp): Remove.
6164 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6165
4a720484
GM
61662011-05-19 Glenn Morris <rgm@gnu.org>
6167
6168 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6169 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6170 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6171 (lisp): Set the order to that of loadup.el.
6172 (shortlisp): Make it a copy of $lisp.
6173 (SOME_MACHINE_LISP): Remove.
6174 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6175 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6176
a28d4396
KH
61772011-05-18 Kenichi Handa <handa@m17n.org>
6178
6179 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6180 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6181 (find_automatic_composition): Mostly rewrite for efficiency.
6182
a2b1fa8e
JB
61832011-05-18 Juanma Barranquero <lekktu@gmail.com>
6184
6185 * makefile.w32-in: Update dependencies.
6186
8e1f5610
CS
61872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6188
6189 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6190 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6191
7025ee00 61922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6193
cdfa6eab
PE
6194 Fix some integer overflow issues, such as string length overflow.
6195
06d6db33
PE
6196 * insdel.c (count_size_as_multibyte): Check for string overflow.
6197
2b4560a8
PE
6198 * character.c (lisp_string_width): Check for string overflow.
6199 Use EMACS_INT, not int, for string indexes and lengths; in
6200 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6201 the resulting string length overflows an EMACS_INT; instead,
6202 report a string overflow if no precision given. When checking for
6203 precision exhaustion, use a check that cannot possibly have
6204 integer overflow. (Bug#8675)
6205 * character.h (lisp_string_width): Adjust to new signature.
6206
cb93f9be
PE
6207 * alloc.c (string_overflow): New function.
6208 (Fmake_string): Use it. This doesn't change behavior, but saves
6209 a few bytes and will simplify future changes.
6210 * character.c (string_escape_byte8): Likewise.
6211 * lisp.h (string_overflow): New decl.
6212
1a1f3366
PE
6213 Fixups, following up to the user-interface timestamp change.
6214 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6215 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6216 * msdos.c (mouse_get_pos): Likewise.
6217 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6218 * w32gui.h (Time): Define by including "systime.h" rather than by
6219 declaring it ourselves. (Bug#8664)
6220
d4e3e4d3
PE
6221 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6222 * image.c (clear_image_cache): Likewise.
6223
f6a24d19
PE
6224 * term.c (term_mouse_position): Don't assume time_t wraparound.
6225
08dc5ae6
PE
6226 Be more systematic about user-interface timestamps.
6227 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6228 and sometimes 'EMACS_UINT', to represent these timestamps.
6229 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6230 This makes the code easier to follow, and makes it easier to catch
6231 integer overflow bugs such as Bug#8664.
6232 * frame.c (Fmouse_position, Fmouse_pixel_position):
6233 Use Time, not unsigned long, for user-interface timestamps.
6234 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6235 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6236 * keyboard.h (last_event_timestamp): Likewise.
6237 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6238 * menu.h (xmenu_show): Likewise.
6239 * term.c (term_mouse_position): Likewise.
6240 * termhooks.h (struct input_event.timestamp): Likewise.
6241 (struct terminal.mouse_position_hook): Likewise.
6242 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6243 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6244 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6245 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6246 what it was before.
6247 * menu.h, termhooks.h: Include "systime.h", for Time.
6248
8e55734a
PE
6249 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6250 Don't assume that the difference between two unsigned long values
6251 can fit into an integer. At this point, we know button_down_time
6252 <= event->timestamp, so the difference must be nonnegative, so
6253 there's no need to cast the result if double-click-time is
6254 nonnegative, as it should be; check that it's nonnegative, just in
6255 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6256 apart (about 25 days). (Bug#8664)
8e55734a 6257
841f1b75 6258 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6259 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6260
3e26f69c
PE
6261 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6262 that always fit in int. Use a sentinel instead of a counter, to
6263 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6264 * frame.h (struct frame): Use int for menu_bar_items_used
6265 instead of EMACS_INT, since it always fits in int.
3e26f69c 6266
5cc152c0
PE
6267 * menu.c (grow_menu_items): Check for int overflow.
6268
d89eb65e
PE
6269 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6270
5235bd3e
PE
6271 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6272 Before, the code was not consistent. These values cannot exceed
6273 2**31 - 1 so there's no need to make them unsigned.
6274 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6275 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6276 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6277 as modifiers.
6278 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6279
bc827e23
PE
6280 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6281 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6282 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6283 presumably because the widths might not match.
6284
78eb494e
PE
6285 * window.c (size_window): Avoid needless test at loop start.
6286
04f2d78b
CB
62872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6288
6289 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6290
d2fc7e3d 62912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6292
6293 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6294
d2fc7e3d 62952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6296
6297 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6298 `width' to `bar_area_x' and `bar_area_width', respectively.
6299 (x_scroll_run): Take account of fringe background extension.
6300
04f2d78b
CB
6301 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6302 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6303 `bar_area_width', respectively.
6304 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6305 background extension.
6306
79b70037
GM
63072011-05-10 Jim Meyering <meyering@redhat.com>
6308
6309 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6310
2f142cc5
JB
63112011-05-10 Juanma Barranquero <lekktu@gmail.com>
6312
6313 * image.c (Finit_image_library): Return t for built-in image types,
6314 like pbm and xbm. (Bug#8640)
6315
57679c86
AS
63162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6317
6318 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6319
888c9e86
EZ
63202011-05-07 Eli Zaretskii <eliz@gnu.org>
6321
b0512a1d
EZ
6322 * w32console.c (Fset_screen_color): Doc fix.
6323 (Fget_screen_color): New function.
6324 (syms_of_ntterm): Defsubr it.
6325
7285dc67
EZ
6326 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6327 unlink the temporary file if Fcall_process didn't create it in the
6328 first place.
6329 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6330 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6331 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6332 cue to call_process_cleanup not to close that handle.
6333
4d3fcc8e
BK
63342011-05-07 Ben Key <bkey76@gmail.com>
6335
6336 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6337 one of two shell specific rules, either bootstrap-temacs-CMD or
6338 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6339 to the previous implementation of the bootstrap-temacs rule.
6340 The bootstrap-temacs-CMD rule is similar to the previous
6341 implementation of the bootstrap-temacs rule except that it
6342 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6343 variable.
6344
6345 These changes, along with some changes to nt/configure.bat,
6346 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6347 earlier fix to add support for --cflags and --ldflags options
6348 that include quotes so that it works whether make uses cmd or
6349 sh as the shell.
6350
b4289b64
MA
63512011-05-06 Michael Albinus <michael.albinus@gmx.de>
6352
6353 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6354 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6355 is a constant.
6356 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6357 a string. Handle both cases.
6358 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6359 (Fdbus_register_method): Use Qinvalid_function.
6360
af4c0e28
JB
63612011-05-06 Juanma Barranquero <lekktu@gmail.com>
6362
6363 * makefile.w32-in: Update dependencies.
6364 (LISP_H): Add inttypes.h and stdin.h.
6365 (PROCESS_H): Add unistd.h.
6366
c51453d9
EZ
63672011-05-06 Eli Zaretskii <eliz@gnu.org>
6368
6369 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6370 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6371
8ff0ac3c 63722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6373
4c4b566b
PE
6374 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6375
aab2b9b5
PE
6376 * term.c (vfatal): Remove stray call to va_end.
6377 It's not needed and the C Standard doesn't allow it here anyway.
6378
c378da0b
PE
6379 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6380 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6381
288b08c7
PE
6382 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6383 bytes.
6384
e3601888
PE
6385 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6386
db6c0e74
PE
6387 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6388
dd5963ea
PE
6389 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6390
88c9450f
PE
6391 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6392
2f9442b8
PE
6393 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6394
c032b5f8
PE
6395 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6396 * charset.c (Fdefine_charset_internal): Don't initialize
6397 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6398 32-bit int (Bug#8600).
a108c10b
PE
6399
6400 * lread.c (read_integer): Be more consistent with string-to-number.
6401 Use string_to_number to do the actual conversion; this avoids
6402 rounding errors and fixes some other screwups. Without this fix,
6403 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6404 (digit_to_number): Move earlier, for benefit of read_integer.
6405 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6406 not a digit in any supported base. (Bug#8602)
a108c10b 6407
ad5f9eea
PE
6408 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6409
aec1708a
PE
6410 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6411 to match comment at start of function. This also removes a
6412 GCC warning about overflow in a 32+64-bit port.
6413
47be4ab5
PE
6414 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6415
371cac43
PE
6416 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6417 Reported by Stefan Monnier in
6418 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6419 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6420 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6421
d01a7826
PE
6422 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6423 (EMACS_UINTPTR): Likewise, with uintptr_t.
6424
7fd47d5c
PE
6425 * lisp.h: Prefer 64-bit EMACS_INT if available.
6426 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6427 on 32-bit hosts that have 64-bit int, so that they can access
6428 large files.
122b0c86
PE
6429 However, temporarily disable this change unless the temporary
6430 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6431
8727937b
PE
6432 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6433
8ac068ac
PE
6434 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6435 This removes an assumption that EMACS_INT and long are the same
6436 width as pointers. The assumption is true for Emacs porting targets
6437 now, but we want to make other targets possible.
6438 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6439 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6440 In the rest of the code, change types of integers that hold casted
6441 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6442 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6443 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6444 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6445 No need to cast type when ORing.
6446 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6447 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6448 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6449 assume EMACS_INT is the same width as char *.
6450 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6451 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6452 Remove no-longer-needed casts.
6453 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6454 (xg_tool_bar_help_callback, xg_make_tool_item):
6455 Use EMACS_INTPTR to hold an integer
6456 that will be cast to void *; this can avoid a GCC warning
6457 if EMACS_INT is not the same width as void *.
6458 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6459 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6460 (current_message_1, set_message_1):
6461 Use a local to convert to proper width without a cast.
6462 * xmenu.c (dialog_selection_callback): Likewise.
6463
ede49d71
PE
6464 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6465 Also, don't assume VALBITS / RAND_BITS is less than 5,
6466 and don't rely on undefined behavior when shifting a 1 left into
6467 the sign bit.
6468 * lisp.h (get_random): Change signature to match.
6469
2f30ecd0
PE
6470 * lread.c (hash_string): Use size_t, not int, for hash computation.
6471 Normally we prefer signed values; but hashing is special, because
6472 it's better to use unsigned division on hash table sizes so that
6473 the remainder is nonnegative. Also, size_t is the natural width
6474 for hashing into memory. The previous code used 'int', which doesn't
6475 retain enough info to hash well into very large tables.
6476 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6477
2a866e7b
PE
6478 * dbusbind.c: Don't possibly lose pointer info when converting.
6479 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6480 Use XPNTR rather than XHASH, so that the high-order bits of
6481 the pointer aren't lost when converting through void *.
6482
51639eac
PE
6483 * eval.c (Fautoload): Don't double-shift a pointer.
6484
92394119
PE
6485 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6486
dbdb9a7c
JB
64872011-05-06 Juanma Barranquero <lekktu@gmail.com>
6488
6489 * gnutls.c (DEF_GNUTLS_FN):
6490 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6491
db7a0b4f
AS
64922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6493
6494 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6495 marker. (Bug#8610)
6496
cd394be1 64972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6498
6499 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6500 New version that can reserve upto 2GB of heap space.
6501
f7ff1b0f 65022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6503
6504 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6505
639c109b
TZ
65062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6507
6508 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6509 `gnutls_certificate_set_x509_key_file'.
6510
d2127135
JB
65112011-05-05 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6514 Update dependencies.
6515
e968f4f3
JB
65162011-05-04 Juanma Barranquero <lekktu@gmail.com>
6517
6518 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6519 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6520 Remove unused parameter `fildes'.
6521 * process.c (read_process_output, send_process): Don't pass it.
6522
84d358f0
JB
65232011-05-04 Juanma Barranquero <lekktu@gmail.com>
6524
6525 Fix previous change: the library cache is defined in w32.c.
6526 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6527 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6528
0898ca10
JB
65292011-05-04 Juanma Barranquero <lekktu@gmail.com>
6530
6531 Implement dynamic loading of GnuTLS on Windows.
6532
6533 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6534 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6535 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6536 Declare.
6537
6538 * gnutls.c (Qgnutls_dll): Define.
6539 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6540 (gnutls_*): Declare function pointers.
6541 (init_gnutls_functions): New function to initialize function pointers.
6542 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6543 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6545 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6546 (emacs_gnutls_write, emacs_gnutls_read)
6547 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6548 (Fgnutls_available_p): New function.
6549 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6550 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6551 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6552
6553 * image.c: Include w32.h.
6554 (Vimage_type_cache): Delete.
6555 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6556 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6557 (w32_delayed_load): Move to w32.c.
6558
6559 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6560
6561 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6562 (w32_delayed_load): Move from image.c. When loading a library, record
6563 its filename in the :loaded-from property of the library id.
6564 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6565 Initialize and staticpro them.
6566 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6567
6568 * process.c: Include lisp.h before w32.h, not after.
6569 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6570 instead of gnutls_record_check_pending.
6571
6572 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6573
ff4de4aa
TZ
65742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6575
6576 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6577 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6578 as passed in.
6579
abe95abb
JD
65802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6581
6582 * xterm.c (x_set_frame_alpha): Do not set property on anything
6583 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6584
e16e55d4
JB
65852011-05-02 Juanma Barranquero <lekktu@gmail.com>
6586
6587 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6588
bafcf6a5
JB
65892011-05-02 Juanma Barranquero <lekktu@gmail.com>
6590
6591 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6592 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6593 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6594 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6595 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6596 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6597 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6598 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6599 (Qgnutls_bootprop_callbacks_verify): Make static.
6600
e7a6747f
AS
66012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6602
19ed11ba
AS
6603 * callproc.c: Indentation fixup.
6604
e7a6747f 6605 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6606 (wait_for_termination, interruptible_wait_for_termination):
6607 Move after wait_for_termination_1.
e7a6747f 6608
1ef14cb4
LMI
66092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6610
6611 * sysdep.c (interruptible_wait_for_termination): New function
6612 which is like wait_for_termination, but allows keyboard
6613 interruptions.
6614
6615 * callproc.c (Fcall_process): Add (:file "file") as an option for
6616 the STDOUT buffer.
6617 (Fcall_process_region): Ditto.
6618
330d880c
EZ
66192011-04-30 Eli Zaretskii <eliz@gnu.org>
6620
8db90b73
EZ
6621 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6622 rather than `XVECTOR (FOO)->size'.
6623
330d880c
EZ
6624 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6625 inttypes.h, as a gnulib replacement is used if it not available in
6626 system headers.
6627
15cbd324
EZ
66282011-04-21 Eli Zaretskii <eliz@gnu.org>
6629
6630 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6631 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6632 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6633
6634 * coding.c (coding_alloc_by_realloc): Error out if destination
6635 will grow beyond MOST_POSITIVE_FIXNUM.
6636 (decode_coding_emacs_mule): Abort if there isn't enough place in
6637 charbuf for the composition carryover bytes. Reserve an extra
6638 space for up to 2 characters produced in a loop.
6639 (decode_coding_iso_2022): Abort if there isn't enough place in
6640 charbuf for the composition carryover bytes.
6641
66422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6643
ae940cca
EZ
6644 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6645 aborting when %lld or %lll format is passed.
6646 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6647 %llo or %llx format is passed. (Bug#8545)
6648
03ab8921
EZ
6649 * window.c (window_scroll_line_based): Use a marker instead of
6650 simple variables to record original value of point. (Bug#7952)
6651
afda1437
EZ
6652 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6653 produced by %s or %c overflows available buffer space. (Bug#8545)
6654
f76dee0c
PE
66552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6656
6657 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6658 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6659
fdc5744d
JB
66602011-04-28 Juanma Barranquero <lekktu@gmail.com>
6661
6662 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6663
638f053a
JB
66642011-04-28 Juanma Barranquero <lekktu@gmail.com>
6665
6666 * keyboard.c (Qdelayed_warnings_hook): Define.
6667 (command_loop_1): Run `delayed-warnings-hook'
6668 if Vdelayed_warnings_list is non-nil.
6669 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6670 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6671
d178f871
EZ
66722011-04-28 Eli Zaretskii <eliz@gnu.org>
6673
6674 * doprnt.c (doprnt): Don't return value smaller than the buffer
6675 size if the message was truncated. (Bug#8545).
6676
b124fd93
JB
66772011-04-28 Juanma Barranquero <lekktu@gmail.com>
6678
6679 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6680 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6681
e810457d
PE
66822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6683
6684 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6685
ea51cceb
JB
66862011-04-27 Juanma Barranquero <lekktu@gmail.com>
6687
6688 * makefile.w32-in: Update dependencies.
6689
94dcfacf
EZ
66902011-04-27 Eli Zaretskii <eliz@gnu.org>
6691
6692 Improve `doprnt' and its usage. (Bug#8545)
6693 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6694 `format_end'. Remove support for %l as a conversion specifier.
6695 Don't use xrealloc. Improve diagnostics when the %l size modifier
6696 is used. Update the commentary.
6697
6698 * eval.c (verror): Simplify calculation of size_t.
6699
6700 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6701 messages.
6702
f61f41d7
PE
67032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6704
6705 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6706 change.
6707
96fb4434
PE
67082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6709
6710 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6711 This makes this file independent of the recent pseudovector change.
6712
671875da 67132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6714
69e9b5a3
PE
6715 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6716
b5f869a7 6717 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6718 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6719 Remove unused local.
c8926152 6720 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6721
841a1577 6722 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6723 GCC 4.6.0 optimizes based on type-based alias analysis.
6724 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6725 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6726 != &v->size, and therefore "v->size = 1; b->size = 2; return
6727 v->size;" must therefore return 1. This assumption is incorrect
6728 for Emacs, since it type-puns struct Lisp_Vector * with many other
6729 types. To fix this problem, this patch adds a new type struct
f904488f 6730 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6731 and pseudovectors, and helps optimizing compilers not get fooled
6732 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6733 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6734 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6735 the size member.
eab3844f
PE
6736 (XSETPVECTYPE): Rewrite in terms of new macro.
6737 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6738 This is a bit clearer, and further avoids the possibility of
6739 undesirable aliasing.
6740 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6741 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6742 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6743 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6744 (ASIZE): Now uses header.size rather than size.
6745 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6746 to avoid the hassle of writing XVECTOR (foo)->header.size.
6747 (struct vectorlike_header): New type.
eab3844f
PE
6748 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6749 object, to help avoid aliasing.
6750 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6751 (SUBRP): Likewise, since Lisp_Subr is a special case.
6752 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6753 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6754 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6755 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6756 changed to be "header.size" and "header.next".
6757 * buffer.h (struct buffer): Likewise.
6758 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6759 * frame.h (struct frame): Likewise.
6760 * process.h (struct Lisp_Process): Likewise.
6761 * termhooks.h (struct terminal): Likewise.
6762 * window.c (struct save_window_data, struct saved_window): Likewise.
6763 * window.h (struct window): Likewise.
6764 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6765 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6766 * buffer.c (init_buffer_once): Likewise.
6767 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6768 special case.
6769 * process.c (Fformat_network_address): Use local var for size,
6770 for brevity.
6771
0df1eac5
PE
6772 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6773
847ab9d1 6774 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6775 * data.c (atof): Remove decl; no longer used or needed.
6776 (digit_to_number): Move to lread.c.
6777 (Fstring_to_number): Use new string_to_number function, to be
6778 consistent with how the Lisp reader treats infinities and NaNs.
6779 Do not assume that floating-point numbers represent EMACS_INT
6780 without losing information; this is not true on most 64-bit hosts.
6781 Avoid double-rounding errors, by insisting on integers when
6782 parsing non-base-10 numbers, as the documentation specifies.
6783 * lisp.h (string_to_number): New decl, replacing ...
6784 (isfloat_string): Remove.
bc0a5c13 6785 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6786 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6787 appears to have been a coding error. Similarly, do not accept
6788 strings like +-1e0 as floating point numbers. Do not report
6789 overflow for integer overflows unless the base is not 10 which
6790 means we have no simple and reliable way to continue.
6791 Break out the floating-point parsing into a new
6792 function string_to_number, so that Fstring_to_number parses
6793 floating point numbers consistently with the Lisp reader.
04f2d78b 6794 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6795 (E_CHAR, EXP_INT): Remove, replacing with ...
6796 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6797 (string_to_number): New function, replacing isfloat_string.
6798 This function checks for valid syntax and produces the resulting
6799 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6800 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6801 so that overflow for non-base-10 numbers is reported only when
6802 there's no portable and simple way to convert to floating point.
452f4150 6803
67769ffc
PE
6804 * textprop.c (set_text_properties_1): Rewrite for clarity,
6805 and to avoid GCC warning about integer overflow.
6806
c20db43f
PE
6807 * intervals.h (struct interval): Use EMACS_INT for members
6808 where EMACS_UINT might cause problems. See
6809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6810 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6811 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6812 All uses changed.
37aa2f85
PE
6813 (offset_intervals): Tell GCC not to worry about length overflow
6814 when negating a negative length.
c20db43f 6815
2538aa2f
PE
6816 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6817 (overrun_check_free): Likewise.
6818
f2d3008d
PE
6819 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6820 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6821 word size.
6822
ec8df744
PE
6823 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6824 (gnutls_make_error): Rename local to avoid shadowing.
6825 (gnutls_emacs_global_deinit): ifdef out; not used.
6826 (Fgnutls_boot): Use const for pointer to readonly storage.
6827 Comment out unused local. Fix pointer signedness problems.
6828
640ee02d
PE
6829 * lread.c (openp): Don't stuff size_t into an 'int'.
6830 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6831 about possible signed overflow.
6832
6048fb2a
PE
6833 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6834 (GDK_KEY_g): Don't define if already defined.
6835 (xg_prepare_tooltip): Avoid pointer signedness problem.
6836 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6837
fa3c87e1
PE
6838 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6839 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6840
2172544b
PE
6841 * xfns.c (Fx_window_property): Simplify a bit,
6842 to make a bit faster and to avoid GCC 4.6.0 warning.
6843 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6844
9b821a21
PE
6845 * fns.c (internal_equal): Don't assume size_t fits in int.
6846
3c616cfa
PE
6847 * alloc.c (compact_small_strings): Tighten assertion a little.
6848
c2982e87
PE
6849 Replace pEd with more-general pI, and fix some printf arg casts.
6850 * lisp.h (pI): New macro, generalizing old pEd macro to other
6851 conversion specifiers. For example, use "...%"pI"d..." rather
6852 than "...%"pEd"...".
6853 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6854 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6855 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6856 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6857 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6858 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6859 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6860 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6861 64-bit hosts.
6862 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6863 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6864 * print.c (safe_debug_print, print_object): Likewise.
6865 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6866 to int.
6f04d126
PE
6867 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6868 avoiding the 0 flag, which is not portable.
c2982e87
PE
6869 * process.c (Fmake_network_process): Use pI to avoid cast.
6870 * region-cache.c (pp_cache): Likewise.
6871 * xdisp.c (decode_mode_spec): Likewise.
6872 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6873 behavior on 64-bit hosts with printf arg.
6f04d126 6874 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6875 (x_stop_queuing_selection_requests): Likewise.
6876 (x_get_window_property): Don't truncate byte count to an 'int'
6877 when tracing.
0b432f21 6878
5e073ec7
PE
6879 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6880 here, since it parses constructs like leading '-' and spaces,
6881 which are not wanted; and it overflows with large numbers.
6882 Instead, simply match F[0-9]+, which is what is wanted anyway.
6883
36372bf9
PE
6884 * alloc.c: Remove unportable assumptions about struct layout.
6885 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6886 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6887 (allocate_vectorlike, make_pure_vector): Use the new macros,
6888 plus offsetof, to remove unportable assumptions about struct layout.
6889 These assumptions hold on all porting targets that I know of, but
6890 they are not guaranteed, they're easy to remove, and removing them
6891 makes further changes easier.
6892
0b432f21
PE
6893 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6894 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6895 (string_overrun_cookie): Now const. Use initializers that
6896 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6897 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6898 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6899 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6900 multiple of sizeof (EMACS_INT); it need not be, if
6901 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6902 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6903
895009e1
JB
69042011-04-26 Juanma Barranquero <lekktu@gmail.com>
6905
6906 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6907
6a7a1b0b
TZ
69082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6909
6910 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6911 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6912 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6913
841a1577 69142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6915
6916 * lisp.h (Qdebug): List symbol.
895009e1 6917 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6918 * keyboard.c (debug-on-event): New variable.
6919 (handle_user_signal): Break into debugger when debug-on-event
6920 matches the current signal symbol.
6921
f2d3ba6f
DN
69222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6923
6924 * alloc.c (check_sblock, check_string_bytes)
6925 (check_string_free_list): Convert to standard C.
6926
42ce4c63
TZ
69272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6928
6929 * w32.c (emacs_gnutls_push): Fix typo.
6930
825cd63c
EZ
69312011-04-25 Eli Zaretskii <eliz@gnu.org>
6932
fb11d64d
EZ
6933 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6934 "cast to pointer from integer of different size".
6935
825cd63c
EZ
6936 Improve doprnt and its use in verror. (Bug#8545)
6937 * doprnt.c (doprnt): Document the set of format control sequences
6938 supported by the function. Use SAFE_ALLOCA instead of always
6939 using `alloca'.
6940
6941 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6942 is one byte too soon. Don't use xrealloc; instead xfree and
6943 xmalloc anew.
6944
e061a11b
TZ
69452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6946
6947 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6948 callbacks stage.
6949
6950 * gnutls.c: Renamed global_initialized to
6951 gnutls_global_initialized. Added internals for the
6952 :verify-hostname-error, :verify-error, and :verify-flags
6953 parameters of `gnutls-boot' and documented those parameters in the
6954 docstring. Start callback support.
9173deec
JB
6955 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6956 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6957 on error. Return error code.
e061a11b
TZ
6958 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6959 (emacs_gnutls_read): Likewise.
6960 (Fgnutls_boot): Return handshake error code.
6961 (emacs_gnutls_handle_error): New function.
6962 (wsaerror_to_errno): Likewise.
6963
6964 * w32.h (emacs_gnutls_pull): Add prototype.
6965 (emacs_gnutls_push): Likewise.
6966
6967 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6968 (emacs_gnutls_push): Likewise.
6969
69702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6971
6972 * process.c (wait_reading_process_output): Check if GnuTLS
6973 buffered some data internally if no FDs are set for TLS
6974 connections.
6975
6976 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6977 (LIBS): Link to USER_LIBS.
6978 ($(BLD)/gnutls.$(0)): New target.
6979
fa6996bc
EZ
69802011-04-24 Eli Zaretskii <eliz@gnu.org>
6981
eb35682e
EZ
6982 * xdisp.c (handle_single_display_spec): Rename the
6983 display_replaced_before_p argument into display_replaced_p, to
6984 make it consistent with the commentary. Fix typos in the
6985 commentary.
6986
e2ad650c
EZ
6987 * textprop.c (syms_of_textprop): Remove dead code.
6988 (copy_text_properties): Delete obsolete commentary about an
6989 interface that was deleted long ago. Fix typos in the description
6990 of arguments.
6991
1b2de274
EZ
6992 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6993 to changes in oldXMenu/XMenu.h from 2011-04-16.
6994 <menu_help_message, prev_menu_help_message>: Constify.
6995 (IT_menu_make_room): menu->help_text is now `const char **';
6996 adjust.
6997
6998 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6999 to changes in oldXMenu/XMenu.h from 2011-04-16.
7000 (struct XMenu): Declare `help_text' `const char **'.
7001
7002 * xfaces.c <Qunspecified>: Make extern again.
7003
7004 * syntax.c: Include sys/types.h before including regex.h, as
7005 required by Posix.
7006
762b15be
EZ
7007 * doc.c (get_doc_string): Improve the format passed to `error'.
7008
7009 * doprnt.c (doprnt): Improve commentary.
7010
7011 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7012
7013 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7014 them with etags.
7015
f1052e5d
EZ
7016 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7017 changes in globals.h immediately force recompilation.
762b15be
EZ
7018 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7019 $(CURDIR)/s/ms-w32.h.
7020 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7021
fa6996bc
EZ
7022 * character.c (Fchar_direction): Function deleted.
7023 (syms_of_character): Don't defsubr it.
7024 <char-direction-table>: Deleted.
7025
e6c3da20
EZ
70262011-04-23 Eli Zaretskii <eliz@gnu.org>
7027
7028 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7029 * doprnt.c: Include limits.h.
7030 (SIZE_MAX): New macro.
04f2d78b
CB
7031 (doprnt): Return a size_t value. 2nd arg is now size_t.
7032 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7033 Improve overflow protection. Support `l' modifier for integer
7034 conversions. Support %l conversion. Don't assume an EMACS_INT
7035 argument for integer conversions and for %c.
7036
7037 * lisp.h (doprnt): Restore prototype.
7038
7039 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7040 $(SRC)/character.h.
7041
7042 * Makefile.in (base_obj): Add back doprnt.o.
7043
7044 * deps.mk (doprnt.o): Add back prerequisites.
7045 (callint.o): Depend on character.h.
7046
7047 * eval.c (internal_lisp_condition_case): Include the handler
7048 representation in the error message.
7049 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7050 when breaking from the loop.
7051
7052 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7053
7054 * callint.c (Fcall_interactively): When displaying error message
7055 about invalid control letter, pass the character's codepoint, not
7056 a pointer to its multibyte form. Improve display of the character
7057 in octal and display also its hex code.
7058
7059 * character.c (char_string): Use %x to display the (unsigned)
7060 codepoint of an invalid character, to avoid displaying a bogus
7061 negative value.
7062
7063 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7064 `error', not SYMBOL_NAME itself.
7065
7066 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7067 character arguments to `error'.
7068
7069 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7070 to `error' in error message about FINAL_CHAR argument. Make sure
7071 FINAL_CHAR is a character, and use %c when it is passed as
7072 argument to `error'.
7073
4ffd0d6b 70742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7075
7076 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7077
7078 * w32.c: Include <time.h>.
7079 (sys_localtime): New function.
7080
4ffd0d6b 70812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7082
7083 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7084
4ffd0d6b 7085 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7086
4ffd0d6b 70872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7088
4ffd0d6b
GM
7089 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7090 zombies (Bug#8467).
aac0c6e3 7091
04c56954
EZ
70922011-04-19 Eli Zaretskii <eliz@gnu.org>
7093
7094 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7095 gl_state.e_property when gl_state.object is Qt.
7096
7097 * insdel.c (make_gap_larger): Remove limitation of buffer size
7098 to <= INT_MAX.
7099
16a43933
CY
71002011-04-18 Chong Yidong <cyd@stupidchicken.com>
7101
7102 * xdisp.c (lookup_glyphless_char_display)
7103 (produce_glyphless_glyph): Handle cons cell entry in
7104 glyphless-char-display.
7105 (Vglyphless_char_display): Document it.
7106
7107 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7108 glyphless-char-display.
7109
4581706e
CY
71102011-04-17 Chong Yidong <cyd@stupidchicken.com>
7111
7112 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7113
7114 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7115
7116 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7117 definition for no-X builds.
7118
4887c6e2 71192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7120
fd35b6f9
PE
7121 Static checks with GCC 4.6.0 and non-default toolkits.
7122
5c1ccb01
PE
7123 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7124
006c5daa
PE
7125 * process.c (keyboard_bit_set): Define only if SIGIO.
7126 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7127 (send_process): Repair possible setjmp clobbering.
7128
efc736d3
PE
7129 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7130
4e2fe2e6
PE
7131 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7132
f97334a2
PE
7133 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7134
4e75f29d
PE
7135 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7136 Define only if needed.
7137
90efadd1
PE
7138 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7139 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7140 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7141
3c647824
PE
7142 * dispextern.h (struct redisplay_interface): Rename param
7143 to avoid shadowing.
e264f262 7144 * termhooks.h (struct terminal): Likewise.
761383f4 7145 * xterm.c (xembed_send_message): Likewise.
3c647824 7146
b58c5c4a
PE
7147 * insdel.c (make_gap_smaller): Define only if
7148 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7149
cad59032
PE
7150 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7151 it.
7152
c339dc2e
PE
7153 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7154 so that we aren't warned about unused symbols.
7155
91a3e27b
PE
7156 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7157
399c71d3 7158 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7159
8ffc96f5
PE
7160 * xfns.c (x_real_positions): Mark locals as initialized.
7161
eef9bc79
PE
7162 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7163
098db9dd
PE
7164 * xterm.c: Fix problems found by static analysis with other toolkits.
7165 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7166 (x_dispatch_event): Declare static if USE_GTK, and
7167 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7168 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7169 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7170 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7171 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7172
eb18f6cc
PE
7173 * xmenu.c (menu_help_callback): Pointer type fixes.
7174 Use const pointers when pointing at readonly data. Avoid pointer
7175 signedness clashes.
7176 (FALSE): Remove unused macro.
7177 (update_frame_menubar): Remove unused decl.
7178
1fe72bf8
PE
7179 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7180
60d9e1db
PE
7181 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7182 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7183 (single_menu_item): Rename local to avoid shadowing.
7184
39261c26
PE
7185 * keyboard.c (make_lispy_event): Remove unused local var.
7186
018c5e19
PE
7187 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7188 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7189
63d2b86e
PE
7190 * bitmaps: Change bitmaps from unsigned char back to the X11
7191 compatible char. Avoid the old compiler warnings about
7192 out-of-range initializers by using, for example, '\xab' rather
7193 than 0xab.
7194
aefd87e1
PE
7195 * xgselect.c (xgselect_initialize): Check vs interface
7196 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7197
bf501fb9
PE
7198 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7199
e9829fdf
PE
7200 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7201 to read-only memory.
7202
1086c095
PE
7203 * fns.c (vector): Remove; this old hack is no longer needed.
7204
2baccd04 7205 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7206 Remove unused var.
dde42981 7207 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7208
72391843 7209 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7210
436c16df 7211 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7212 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7213 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7214
92bb796d 7215 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7216 (x_term_init): Remove local to avoid shadowing.
92bb796d 7217
764430a3 7218 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7219
7220 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7221 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7222
d1dfb56c
EZ
72232011-04-16 Eli Zaretskii <eliz@gnu.org>
7224
c4354cb4
EZ
7225 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7226
d1dfb56c
EZ
7227 Fix regex.c, syntax.c and friends for buffers > 2GB.
7228 * syntax.h (struct gl_state_s): Declare character position members
7229 EMACS_INT.
7230
7231 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7232
04f2d78b
CB
7233 * textprop.c (verify_interval_modification, interval_of):
7234 Declare arguments EMACS_INT.
d1dfb56c
EZ
7235
7236 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7237 EMACS_INT.
7238
7239 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7240
7241 * indent.c (Fvertical_motion): Local variable it_start is now
7242 EMACS_INT.
7243
7244 * regex.c (re_match, re_match_2, re_match_2_internal)
7245 (bcmp_translate, regcomp, regexec, print_double_string)
7246 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7247 (re_compile_pattern, re_exec): Declare arguments and local
7248 variables `size_t' and `ssize_t' and return values `regoff_t', as
7249 appropriate.
7250 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7251 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7252 <compile_stack_type>: `size' and `avail' are now `size_t'.
7253
7254 * regex.h <regoff_t>: Use ssize_t, not int.
7255 (re_search, re_search_2, re_match, re_match_2): Arguments that
7256 specify buffer/string position and length are now ssize_t and
7257 size_t. Return type is regoff_t.
7258
613052cd
BK
72592011-04-16 Ben Key <bkey76@gmail.com>
7260
7261 * nsfont.m: Fixed bugs in ns_get_family and
7262 ns_descriptor_to_entity that were caused by using free to
7263 deallocate memory blocks that were allocated by xmalloc (via
7264 xstrdup). This caused Emacs to crash when compiled with
7265 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7266 --enable-checking=xmallocoverrun). xfree is now used to
7267 deallocate these memory blocks.
7268
4170f62f 72692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7270
71b41406
PE
7271 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7272
9587a89d
PE
7273 emacs_write: Accept and return EMACS_INT for sizes.
7274 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7275 et seq.
7276 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7277 Accept and return EMACS_INT.
7278 (emacs_gnutls_write): Return the number of bytes written on
7279 partial writes.
7280 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7281 (emacs_read, emacs_write): Remove check for negative size, as the
7282 Emacs source code has been audited now.
9587a89d
PE
7283 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7284 (emacs_read, emacs_write): Use it.
273a5f82
PE
7285 * process.c (send_process): Adjust to the new signatures of
7286 emacs_write and emacs_gnutls_write. Do not attempt to store
7287 a byte offset into an 'int'; it might overflow.
9587a89d 7288 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7289
3e047f51
PE
7290 * sound.c: Don't assume sizes fit in 'int'.
7291 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7292 Return EMACS_INT, not int.
3e047f51 7293 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7294 Accept EMACS_INT, not int.
7295 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7296 record read return values.
7297
cc39a9db
BK
72982011-04-15 Ben Key <bkey76@gmail.com>
7299
c9d0ec6d
JB
7300 * keyboard.c (Qundefined): Don't declare static since it is used
7301 in nsfns.m.
7302 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7303 static since they are used in nsfont.m.
cc39a9db 7304
6c60eb9f
SM
73052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7306
7307 * process.c (Qprocessp): Don't declare static.
7308 * lisp.h (Qprocessp): Declare again.
7309
7990b61a
JB
73102011-04-15 Juanma Barranquero <lekktu@gmail.com>
7311
7312 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7313
5d4cb038
PE
73142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7315
8bd7b830 7316 Improve C-level modularity by making more things 'static'.
cd64ea1d 7317
e3b27b31
PE
7318 Don't publish debugger-only interfaces to other modules.
7319 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7320 (verify_bytepos, count_markers): Move decls to the only modules
7321 that need them.
7322 * region-cache.h (pp_cache): Likewise.
7323 * window.h (check_all_windows): Likewise.
7324 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7325
5d4cb038
PE
7326 * sysdep.c (croak): Now static, if
7327 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7328 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7329
7330 * alloc.c (refill_memory_reserve): Now static if
7331 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7332 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7333
e87b6180
PE
7334 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7335 Define only if USE_LUCID.
7336
ac64929e
PE
7337 * xrdb.c (x_customization_string, x_rm_string): Now static.
7338
6f37259d
PE
7339 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7340 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7341
1683e3ab
PE
7342 * xdisp.c (draw_row_with_mouse_face): Now static.
7343 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7344
de9c2632
PE
7345 * window.h (check_all_windows): Mark externally visible.
7346
2b96acb7
PE
7347 * window.c (window_deletion_count): Now static.
7348
7349 * undo.c: Make symbols static if they're not exported.
7350 (last_undo_buffer, last_boundary_position, pending_boundary):
7351 Now static.
7352
50436f33
PE
7353 * textprop.c (interval_insert_behind_hooks): Now static.
7354 (interval_insert_in_front_hooks): Likewise.
7355
64520e5c
PE
7356 * term.c: Make symbols static if they're not exported.
7357 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7358 (max_frame_lines, tty_set_terminal_modes):
7359 (tty_reset_terminal_modes, tty_turn_off_highlight):
7360 (get_tty_terminal): Now static.
7361 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7362 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7363 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7364 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7365 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7366
1fa53021
PE
7367 * sysdep.c: Make symbols static if they're not exported.
7368 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7369 Now static.
7370 (sigprocmask_set, full_mask): Remove; unused.
7371 (wait_debugging): Mark as visible.
7372 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7373 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7374
d4b43b22
PE
7375 * syntax.c (syntax_temp): Define only if !__GNUC__.
7376
b7c513d0
PE
7377 * sound.c (current_sound_device, current_sound): Now static.
7378
989b29ad
PE
7379 * search.c (searchbufs, searchbuf_head): Now static.
7380
13a55a78
PE
7381 * scroll.c (scroll_cost): Remove; unused.
7382 * dispextern.h (scroll_cost): Remove decl.
7383
de68a1fc
PE
7384 * region-cache.h (pp_cache): Mark as externally visible.
7385
40ccffa6
PE
7386 * process.c: Make symbols static if they're not exported.
7387 (process_tick, update_tick, create_process, chan_process):
7388 (Vprocess_alist, proc_buffered_char, datagram_access):
7389 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7390 (deactivate_process): Mark defn as static, as well as decl.
7391 * lisp.h (create_process): Remove decl.
7392 * process.h (chan_process, Vprocess_alist): Remove decls.
7393
ad64fc97
PE
7394 * print.c: Make symbols static if they're not exported.
7395 (print_depth, new_backquote_output, being_printed, print_buffer):
7396 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7397 (print_interval, print_number_index, initial_stderr_stream):
7398 Now static.
7399 * lisp.h (Fprinc): Remove decl.
7400 (debug_output_compilation_hack): Mark as externally visible.
7401
adddb265
PE
7402 * sysdep.c (croak): Move decl from here to syssignal.h.
7403 * syssignal.h (croak): Put it here, so the API can be checked when
7404 'croak' is called from dissociate_if_controlling_tty.
7405
1717ede2
PE
7406 * minibuf.c: Make symbols static if they're not exported.
7407 (minibuf_save_list, choose_minibuf_frame): Now static.
7408 * lisp.h (choose_minibuf_frame): Remove decl.
7409
fa5fb2bc
PE
7410 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7411
1e3890d1
PE
7412 * lread.c: Make symbols static if they're not exported.
7413 (read_objects, initial_obarray, oblookup_last_bucket_number):
7414 Now static.
7415 (make_symbol): Remove; unused.
7416 * lisp.h (initial_obarray, make_symbol): Remove decls.
7417
8a1414fa
PE
7418 * keyboard.c: Make symbols static if they're not exported.
7419 (single_kboard, recent_keys_index, total_keys, recent_keys):
7420 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7421 (this_single_command_key_start, echoing, last_auto_save):
7422 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7423 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7424 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7425 (Vlispy_mouse_stem, double_click_count):
7426 Now static.
7427 (force_auto_save_soon): Define only if SIGDANGER.
7428 (ignore_mouse_drag_p): Now static if
7429 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7430 (print_help): Remove; unused.
7431 (stop_character, last_timer_event): Mark as externally visible.
7432 * keyboard.h (ignore_mouse_drag_p): Declare only if
7433 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7434 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7435 * lisp.h (echoing): Remove decl.
7436 (force_auto_save_soon): Declare only if SIGDANGER.
7437 * xdisp.c (redisplay_window): Simplify code, to make it more
7438 obvious that ignore_mouse_drag_p is not accessed if !defined
7439 USE_GTK && !defined HAVE_NS.
7440
93ea6e8f
PE
7441 * intervals.c: Make symbols static if they're not exported.
7442 (merge_properties_sticky, merge_interval_right, delete_interval):
7443 Now static.
7444 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7445
77382fcc
PE
7446 * insdel.c: Make symbols static if they're not exported.
7447 However, leave prepare_to_modify_buffer alone. It's never
7448 called from outside this function, but that appears to be a bug.
7449 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7450 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7451 (adjust_after_replace_noundo): Remove; unused.
7452 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7453 (signal_before_change): Remove decls.
77382fcc 7454
9306c32e
PE
7455 * indent.c (val_compute_motion, val_vmotion): Now static.
7456
cd44d2eb
PE
7457 * image.c: Make symbols static if they're not exported.
7458 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7459 if USE_GTK.
7460 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7461 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7462
ad9a7a06
PE
7463 * fringe.c (standard_bitmaps): Now static.
7464 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7465
81626931
PE
7466 * frame.c: Make symbols static if they're not exported.
7467 (x_report_frame_params, make_terminal_frame): Now static.
7468 (get_frame_param): Now static, unless HAVE_NS.
7469 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7470 (x_get_resource_string): Remove; not used.
7471 * frame.h (make_terminal_frame, x_report_frame_params):
7472 (x_get_resource_string); Remove decls.
7473 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7474 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7475
239f9db9
PE
7476 * font.c, fontset.c: Make symbols static if they're not exported.
7477 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7478 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7479 * font.c (font_close_object): Now static.
7480 * font.h (font_close_object): Remove.
7481 * fontset.c (FONTSET_OBJLIST): Remove.
7482 (free_realized_fontset) #if-0 the body, which does nothing.
7483 (face_suitable_for_char_p): #if-0, as it's never called.
7484 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7485 * xfaces.c (face_at_string_position):
7486 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7487 since 0 is always ASCII.
7488
dfcf3579
PE
7489 * fns.c (weak_hash_tables): Now static.
7490
5045092b
PE
7491 * fileio.c: Make symbols static if they're not exported.
7492 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7493 (Vwrite_region_annotation_buffers): Now static.
7494
57a96f5c
PE
7495 * eval.c: Make symbols static if they're not exported.
7496 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7497 * lisp.h (backtrace_list): Remove decl.
7498
35f08c38
PE
7499 * emacs.c: Make symbols static if they're not exported.
7500 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7501 (fatal_error_code, fatal_error_signal_hook, standard_args):
7502 Now static.
7503 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7504 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7505 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7506 * lisp.h (fatal_error_signal_hook): Remove decl.
7507 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7508
f44bd759
PE
7509 * editfns.c: Move a (normally-unused) function to its only use.
7510 * editfns.c, lisp.h (get_operating_system_release): Remove.
7511 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7512 worth the hassle of breaking this out.
7513
b532497d
PE
7514 * xterm.c: Make symbols static if they're not exported.
7515 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7516 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7517 (x_destroy_window, x_delete_display):
7518 Now static.
7519 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7520 (x_mouse_leave): Remove; unused.
7521 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7522 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7523 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7524 Remove decls.
7525 (x_mouse_leave): Declare only if WINDOWSNT.
7526 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7527 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7528 USE_X_TOOLKIT.
7529
1675728f
PE
7530 * ftxfont.c: Make symbols static if they're not exported.
7531 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7532 HAVE_FREETYPE.
7533 * font.h (ftxfont_driver): Likewise.
7534
e4cebfca
PE
7535 * xfns.c: Make symbols static if they're not exported.
7536 (x_last_font_name, x_display_info_for_name):
7537 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7538 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7539 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7540 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7541 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7542 (last_show_tip_args): Now static.
7543 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7544 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7545 (x_screen_planes): Remove; unused.
7546 * dispextern.h (x_screen_planes): Remove decl.
7547
5bf46f05
PE
7548 * dispnew.c: Make symbols static if they're not exported.
7549 * dispextern.h (redraw_garbaged_frames, scrolling):
7550 (increment_row_positions): Remove.
7551 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7552 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7553 Now static.
7554 (redraw_garbaged_frames): Remove; unused.
7555
435f4c28
PE
7556 * xfaces.c: Make symbols static if they're not exported.
7557 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7558 Remove decls.
7559 * xterm.h (defined_color): Remove decls.
7560 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7561 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7562 (menu_face_changed_default, defined_color, free_realized_face):
7563 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7564 (ascii_face_of_lisp_face): Remove; unused.
7565
8524aef3
PE
7566 * xdisp.c: Make symbols static if they're not exported.
7567 * dispextern.h (scratch_glyph_row, window_box_edges):
7568 (glyph_to_pixel_coords, set_cursor_from_row):
7569 (get_next_display_element, set_iterator_to_next):
7570 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7571 (show_mouse_face): Remove decls
7572 * frame.h (message_buf_print): Likewise.
7573 * lisp.h (pop_message, set_message, check_point_in_composition):
7574 Likewise.
7575 * xterm.h (set_vertical_scroll_bar): Likewise.
7576 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7577 (message_buf_print, scratch_glyph_row, displayed_buffer):
7578 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7579 (get_next_display_element, show_mouse_face, window_box_edges):
7580 (frame_to_window_pixel_xy, check_point_in_composition):
7581 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7582 (glyph_to_pixel_coords): Remove; unused.
7583
16390cd2
PE
7584 * dired.c (file_name_completion): Now static.
7585
7586 * dbusbind.c (xd_in_read_queued_messages): Now static.
7587
a25f4dfa
PE
7588 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7589 * data.c (circular_list_error): Remove.
7590
14a9c8df
PE
7591 * commands.h (last_point_position, last_point_position_buffer):
7592 (last_point_position_window): Remove decls.
7593 * keyboard.c: Make these variables static.
7594
04f2d78b
CB
7595 * coding.h (coding, code_convert_region, encode_coding_gap):
7596 Remove decls.
74ab6df5
PE
7597 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7598 (iso_code_class, detect_coding, code_convert_region): Now static.
7599 (encode_coding_gap): Remove; unused.
7600
38dfbee1
PE
7601 * chartab.c (chartab_chars, chartab_bits): Now static.
7602
a2cb4e63
PE
7603 * charset.h (charset_iso_8859_1): Remove decl.
7604 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7605 Now static.
7606
127198fd
PE
7607 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7608 * ccl.c (Vccl_program_table): Now static.
7609 (check_ccl_update): Remove; unused.
7610
d85b608f
PE
7611 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7612 * category.h: ... from here.
7613 * category.c (check_category_table, set_category_set): Now static.
7614
31cd66f3
PE
7615 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7616 * lisp.h: Remove these decls.
7617
c358e587
PE
7618 * buffer.c (buffer_count): Remove unused var.
7619
e78aecca
PE
7620 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7621 so that it's not optimized away.
7622 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7623 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7624 exported only to the debugger.
7625
e192d7d3 7626 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7627 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7628
92470028
PE
7629 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7630 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7631 was inaccessible from Lisp.
7632 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7633 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7634
244ed907
PE
7635 alloc.c: Import and export fewer symbols, and remove unused items.
7636 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7637 is defined.
7638 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7639 it's not optimized away by whole-program optimization.
7640 (message_enable_multibyte, free_misc): Remove.
7641 (catchlist, handlerlist, mark_backtrace):
7642 Declare only if BYTE_MARK_STACK.
7643 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7644 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7645 (message_enable_multibyte): Remove decl.
7646 (free_misc, interval_free_list, float_block, float_block_index):
7647 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7648 (cons_free_list, last_marked_index):
7649 Now static.
7650 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7651 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7652 (mark_backtrace): Define only if BYTE_MARK_STACK.
7653 * xdisp.c (message_enable_multibyte): Now static.
7654
61c2b50e 7655 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7656 This makes it easier for human readers (and static analyzers)
7657 to see whether these variables are used from other modules.
7658 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7659 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7660 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7661 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7662 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7663 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7664 * xmenu.c, xselect.c:
7665 Declare Q* vars static if they are not used in other modules.
7666 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7667 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7668 Remove decls of unexported vars.
7669 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7670
95c82688
PE
7671 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7672
16a97296
PE
7673 Make Emacs functions such as Fatom 'static' by default.
7674 This makes it easier for human readers (and static analyzers)
7675 to see whether these functions can be called from other modules.
7676 DEFUN now defines a static function. To make the function external
7677 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7678 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7679 (Finit_image_library):
16a97296
PE
7680 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7681 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7682 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7683 Remove decls, since these functions are now static.
7684 (Funintern, Fget_internal_run_time): New decls, since these functions
7685 were already external.
95c82688 7686
16a97296
PE
7687 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7688 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7689 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7690 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7691 * keyboard.c, keymap.c, lread.c:
7692 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7693 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7694 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7695 Mark functions with DEFUE instead of DEFUN,
7696 if they are used in other modules.
7697 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7698 decls for now-static functions.
7699 * buffer.h (Fdelete_overlay): Remove decl.
7700 * callproc.c (Fgetenv_internal): Mark as internal.
7701 * composite.c (Fremove_list_of_text_properties): Remove decl.
7702 (Fcomposition_get_gstring): New forward static decl.
7703 * composite.h (Fcomposite_get_gstring): Remove decl.
7704 * dired.c (Ffile_attributes): New forward static decl.
7705 * doc.c (Fdocumntation_property): New forward static decl.
7706 * eval.c (Ffetch_bytecode): New forward static decl.
7707 (Funintern): Remove extern decl; now in .h file where it belongs.
7708 * fileio.c (Fmake_symbolic_link): New forward static decl.
7709 * image.c (Finit_image_library): New forward static decl.
7710 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7711 * intervals.h (Fprevious_property_change):
7712 (Fremove_list_of_text_properties): Remove decls.
7713 * keyboard.c (Fthis_command_keys): Remove decl.
7714 (Fcommand_execute): New forward static decl.
7715 * keymap.c (Flookup_key): New forward static decl.
7716 (Fcopy_keymap): Now static.
7717 * keymap.h (Flookup_key): Remove decl.
7718 * process.c (Fget_process): New forward static decl.
7719 (Fprocess_datagram_address): Mark as internal.
7720 * syntax.c (Fsyntax_table_p): New forward static decl.
7721 (skip_chars): Remove duplicate decl.
7722 * textprop.c (Fprevious_property_change): New forward static decl.
7723 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7724 Now internal.
7725 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7726 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7727
785bbd42
PE
7728 * editfns.c (Fformat): Remove unreachable code.
7729
8b913b57
AS
77302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7731
7732 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7733 change. (Bug#8496)
7734
a6744a35
EZ
77352011-04-13 Eli Zaretskii <eliz@gnu.org>
7736
7737 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7738 when at ZV. (Bug#8487)
7739
e7974947
AS
77402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7741
baad03f0
AS
7742 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7743 (Bug#8437)
7744 * keyboard.c (parse_tool_bar_item): Likewise.
7745 * sound.c (sound_cleanup, alsa_close): Likewise.
7746 * termcap.c (tgetent): Likewise.
7747 * xfns.c (x_default_font_parameter): Likewise.
7748 * xsettings.c (read_and_apply_settings): Likewise.
7749
e7974947
AS
7750 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7751 (overrun_check_free): Protoize.
7752
28272684
PE
77532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7754
7755 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7756 since callers should never pass a negative size.
7757 Change the signature to match that of plain 'read' and 'write'; see
7758 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7759 * lisp.h: Update prototypes of emacs_write and emacs_read.
7760
11997c76
EZ
77612011-04-11 Eli Zaretskii <eliz@gnu.org>
7762
7763 * xdisp.c (redisplay_window): Don't try to determine the character
7764 position of the scroll margin if the window start point w->startp
e896f03c 7765 is outside the buffer's accessible region. (Bug#8468)
11997c76 7766
8a2cbd72
EZ
77672011-04-10 Eli Zaretskii <eliz@gnu.org>
7768
7769 Fix write-region and its subroutines for buffers > 2GB.
7770 * fileio.c (a_write, e_write): Modify declaration of arguments and
7771 local variables to support buffers larger than 2GB.
7772 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7773
7774 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7775 argument, local variables, and return value.
7776
7777 * lisp.h: Update prototypes of emacs_write and emacs_read.
7778
7779 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7780
4073e537 77812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7782
1ebfdcb6
PE
7783 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7784
b2ded58d
PE
7785 Fix more problems found by GCC 4.6.0's static checks.
7786
7d66342c
PE
7787 * xdisp.c (vmessage): Use a better test for character truncation.
7788
bbf47d44
PE
7789 * charset.c (load_charset_map): <, not <=, for optimization,
7790 and to avoid potential problems with integer overflow.
9248994d 7791 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7792 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7793 * editfns.c (Fformat): Likewise.
1e69125e 7794 * syntax.c (skip_chars): Likewise.
3befa583 7795
e3019616
PE
7796 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7797 This also lets GCC 4.6.0 generate slightly better loop code.
7798
becfa255
PE
7799 * callint.c (Fcall_interactively): <, not <=, for optimization.
7800 (Fcall_interactively): Count the number of arguments produced,
7801 not the number of arguments given. This is simpler and lets GCC
7802 4.6.0 generate slightly better code.
7803
dae0cd48
PE
7804 * ftfont.c: Distingish more carefully between FcChar8 and char.
7805 The previous code passed unsigned char * to a functions like
7806 strlen and xstrcasecmp that expect char *, which does not
7807 conform to the C standard.
7808 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7809 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7810 char * when the C standard requires it.
7811
76032d70
PE
7812 * keyboard.c (read_char): Remove unused var.
7813
eb3f1cc8
PE
7814 * eval.c: Port to Windows vsnprintf (Bug#8435).
7815 Include <limits.h>.
7816 (SIZE_MAX): Define if the headers do not.
7817 (verror): Do not give up if vsnprintf returns a negative count.
7818 Instead, grow the buffer. This ports to Windows vsnprintf, which
7819 does not conform to C99. Problem reported by Eli Zaretskii.
7820 Also, simplify the allocation scheme, by avoiding the need for
7821 calling realloc, and removing the ALLOCATED variable.
7822
70476b54
PE
7823 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7824
12020a9e
PE
7825 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7826 But keep the doprint source code for now, as we might revamp it
7827 and use it again (Bug#8435).
ea6c7ae6
PE
7828 * lisp.h (doprnt): Remove.
7829 * Makefile.in (base_obj): Remove doprnt.o.
7830 * deps.mk (doprnt.o): Remove.
7831
5fdb398c
PE
7832 error: Print 32- and 64-bit integers portably (Bug#8435).
7833 Without this change, on typical 64-bit hosts error ("...%d...", N)
7834 was used to print both 32- and 64-bit integers N, which relied on
7835 undefined behavior.
61bdb816 7836 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7837 * lisp.h (error, verror): Mark as printf-like functions.
7838 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7839 Report overflow in size calculations when allocating printf buffer.
7840 Do not truncate output string at its first null byte.
7841 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7842 Truncate the output at a character boundary, since vsnprintf does not
7843 do that.
7844 * charset.c (check_iso_charset_parameter): Convert internal
7845 character to string before calling 'error', since %c now has the
7846 printf meaning.
7847 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7848 overflow when computing char to be passed to 'error'. Do not
7849 pass Lisp_Object to 'error'; pass the integer instead.
7850 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7851 formatted with plain %d.
7852
b189fa66
PE
7853 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7854
bff87ef0
PE
7855 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7856
7e2cac20
PE
7857 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7858
ce4d90b5
PE
7859 * xterm.c (x_catch_errors): Remove duplicate declaration.
7860
266c9547
PE
7861 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7862
79c49ad2
PE
7863 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7864
368f4090
JM
78652011-04-10 Jim Meyering <meyering@redhat.com>
7866
7867 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7868 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7869 return ssize_t not "int", and use size_t as the buffer length.
7870 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7871 * gnutls.h: Update declarations.
7872 * process.c (read_process_output): Use ssize_t, to match.
7873 (send_process): Likewise.
7874
a32d4040
CY
78752011-04-09 Chong Yidong <cyd@stupidchicken.com>
7876
7877 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7878
8546720e 78792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7880
04f2d78b
CB
7881 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7882 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7883
8546720e
GM
7884 * xterm.c (handle_one_xevent):
7885 * xmenu.c (create_and_show_popup_menu):
7886 * xselect.c (x_decline_selection_request)
7887 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7888
0a2f5c1a 78892011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7890
7891 Fix some uses of `int' instead of EMACS_INT.
7892 * search.c (string_match_1, fast_string_match)
7893 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7894 (scan_buffer, find_next_newline_no_quit)
7895 (find_before_next_newline, search_command, Freplace_match)
7896 (Fmatch_data): Make some `int' variables be EMACS_INT.
7897
7898 * xdisp.c (display_count_lines): 3rd argument and return value now
7899 EMACS_INT. All callers changed.
7900 (pint2hrstr): Last argument is now EMACS_INT.
7901
7902 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7903 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7904 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7905 (decode_coding_utf_16, decode_coding_emacs_mule)
7906 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7907 (decode_coding_ccl, decode_coding_charset)
7908 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7909 (decode_coding_iso_2022, decode_coding_emacs_mule)
7910 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7911 <char_offset, last_offset>: Declare EMACS_INT.
7912 (encode_coding_utf_8, encode_coding_utf_16)
7913 (encode_coding_emacs_mule, encode_invocation_designation)
7914 (encode_designation_at_bol, encode_coding_iso_2022)
7915 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7916 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7917 Declare EMACS_INT.
7918 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7919 (encode_invocation_designation): Last argument P_NCHARS is now
7920 EMACS_INT.
7921 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7922 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7923
7924 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7925 All users changed.
7926
7927 * ccl.c (Fccl_execute_on_string): Declare some variables
7928 EMACS_INT.
7929
8546720e 79302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7931
7932 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7933
4e19a977
CS
79342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7935
7936 * process.c (Fformat_network_address): Doc fix.
7937
87302331
R
79382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7939
ee7683eb 7940 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7941
cbb59342
CY
79422011-04-08 Chong Yidong <cyd@stupidchicken.com>
7943
7944 * keyboard.c (read_char): Call Lisp function help-form-show,
7945 instead of using internal_with_output_to_temp_buffer.
7946 (Qhelp_form_show): New var.
e0d38eeb 7947 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7948
7949 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7950
7951 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7952
e67a13ab
CY
79532011-04-06 Chong Yidong <cyd@stupidchicken.com>
7954
04f2d78b
CB
7955 * process.c (Flist_processes): Remove to Lisp.
7956 (list_processes_1): Delete.
e67a13ab 7957
973f782d
EZ
79582011-04-06 Eli Zaretskii <eliz@gnu.org>
7959
7c106b1e
EZ
7960 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7961
973f782d
EZ
7962 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7963
41cf7d1a 79642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7965
ca23cc88
PE
7966 Fix more problems found by GCC 4.6.0's static checks.
7967
f390e2d5
PE
7968 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7969
42eea0d0
PE
7970 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7971
b69769da 7972 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7973
f9541e84
PE
7974 * xdisp.c (vmessage): Mark as a printf-like function.
7975
13841b55
PE
7976 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7977
c136c10f
PE
7978 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7979
5e2d4a30
PE
7980 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7981 printf-like functions.
7982 (tiff_load): Add casts to remove these marks before passing them
7983 to system-supplied API.
7984
583f48b9
PE
7985 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7986
b25d760e
PE
7987 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7988 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7989 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7990 directly, rather than having caller test rule sign. This avoids
7991 some unnecessary tests.
7992 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7993 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7994 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7995
bc7b6697 7996 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7997 (xfont_open): Avoid unnecessary tests.
bc7b6697 7998
27ccc379
PE
7999 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8000
dcd5c89a
PE
8001 * composite.h, composite.c (composition_gstring_put_cache):
8002 Use EMACS_INT, not int, for length.
8003
b13a45c6
PE
8004 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8005 breaking out part of COMPOSITION_DECODE_RULE.
8006 (COMPOSITION_DECODE_RULE): Use it.
8007 * composite.c (get_composition_id): Remove unused local vars,
8008 by using the new macro.
8009
1e792e4d
PE
8010 * textprop.c (set_text_properties_1): Change while to do-while,
8011 since the condition is always true at first.
8012
dc6c6455 8013 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8014 (interval_deletion_adjustment): Return unsigned value.
8015 All uses changed.
dc6c6455 8016
aba7731a
PE
8017 * process.c (list_processes_1, create_pty, read_process_output):
8018 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8019 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8020 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8021 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8022 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8023
fdfc4bf3
PE
8024 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8025
fca8fe46 8026 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8027 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8028
06a0259a 8029 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8030 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8031 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8032
e7b9e80f
PE
8033 * print.c (print_error_message): Avoid int overflow.
8034
56201685
PE
8035 * font.c (font_list_entities): Redo for clarity,
8036 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8037
78834453 8038 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8039 (font_score): Avoid potential overflow in diff calculation.
78834453 8040
0bc0b309 8041 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8042 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8043
e610eaca
PE
8044 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8045
b895abce
PE
8046 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8047 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8048 can always succeed if overflow has undefined behavior.
8049
1f1d9321 8050 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8051 (wordify): Omit three unnecessary tests.
1f1d9321 8052
c59478bc
PE
8053 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8054 All callers changed. This avoids the need for an unused var.
8055
79b73827
PE
8056 * casefiddle.c (casify_region): Remove var that is set but not used.
8057
a4db5dfe
PE
8058 * dired.c (file_name_completion): Remove var that is set but not used.
8059
43aae36e
PE
8060 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8061
2a47c44d 8062 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8063 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8064
a37c69bf
PE
8065 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8066 Check for integer overflow on size calculations.
8067
328ab8e7
PE
8068 * buffer.c (Fprevious_overlay_change): Remove var that is set
8069 but not used.
8070
e5a2a5cb
PE
8071 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8072 Remove vars that are set but not used.
8d84a6eb 8073 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8074 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8075
a60e5f68
PE
8076 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8077
f661cb61 8078 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8079 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8080
f0397f5a
PE
8081 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8082 that are set but not used.
8083
8664db06 8084 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8085 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8086
6abdaa4a
PE
8087 * xselect.c (x_get_local_selection, x_handle_property_notify):
8088 Remove vars that are set but not used.
8089
0ce7538d 8090 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8091 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8092
9ae848fc
PE
8093 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8094 Remove var that is set but not used.
0b918413
PE
8095 (scroll_bar_windows_size): Now size_t, not int.
8096 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8097 Check for overflow.
9ae848fc 8098
a5a62657
PE
8099 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8100 (map_tty_color) [!defined MSDOS]: Likewise.
8101
5c5cdd39
PE
8102 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8103
66ebf983
PE
8104 * coding.c: Remove vars that are set but not used.
8105 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8106 All callers changed.
8107 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8108 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8109 (decode_coding_charset): Remove vars that are set but not used.
8110
1be4d761
PE
8111 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8112 that is set but not used.
8113
47553fa8
PE
8114 * print.c (print_object): Remove var that is set but not used.
8115
1f7196bf 8116 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8117 The gnulib version avoids calling malloc in the usual case,
8118 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8119 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8120 * filelock.c (current_lock_owner): Likewise.
8121 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8122 * sysdep.c: Include allocator.h, careadlinkat.h.
8123 (emacs_no_realloc_allocator): New static constant.
8124 (emacs_readlink): New function.
fdb61804
PE
8125 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8126 ../lib/careadlinkat.h.
d1fdcab7 8127
f84c17c7
SM
81282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8129
8130 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8131 first non-nil return value).
8132
ef3862ad
JD
81332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8134
8135 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8136 if not defined (Bug#8403).
8137
376a7006
JB
81382011-04-02 Juanma Barranquero <lekktu@gmail.com>
8139
8140 * xdisp.c (display_count_lines): Remove parameter `start',
8141 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8142 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8143 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8144 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8145 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8146 and thereabouts. All callers changed.
8147 (get_per_char_metric): Remove parameter `f', unused since
8148 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8149
6ca3801d
JM
81502011-04-02 Jim Meyering <meyering@redhat.com>
8151
8152 do not dereference NULL upon failed strdup
8153 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8154 (ns_get_family): Likewise.
8155
d8e2b5ba
JB
81562011-04-02 Juanma Barranquero <lekktu@gmail.com>
8157
8158 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8159
8c74fcbd
JD
81602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8161
8162 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8163 later (Bug#8403).
8164
7200d79c
SM
81652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8166
03408648 8167 Add lexical binding.
7200d79c 8168
03408648
SM
8169 * window.c (Ftemp_output_buffer_show): New fun.
8170 (Fsave_window_excursion):
8171 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8172
8173 * lread.c (lisp_file_lexically_bound_p): New function.
8174 (Fload): Bind Qlexical_binding.
8175 (readevalloop): Remove `evalfun' arg.
8176 Bind Qinternal_interpreter_environment.
8177 (Feval_buffer): Bind Qlexical_binding.
8178 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8179 Mark as dynamic.
8180 (syms_of_lread): Declare `lexical-binding'.
8181
8182 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8183
8184 * keyboard.c (eval_dyn): New fun.
8185 (menu_item_eval_property): Use it.
ca105506
SM
8186
8187 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8188
03408648
SM
8189 * fns.c (concat, mapcar1): Accept byte-code-functions.
8190
8191 * eval.c (Fsetq): Handle lexical vars.
8192 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8193 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8194 (FletX, Flet): Obey lexical binding.
8195 (Fcommandp): Handle closures.
8196 (Feval): New `lexical' arg.
8197 (eval_sub): New function extracted from Feval. Use it almost
8198 everywhere where Feval was used. Look up vars in lexical env.
8199 Handle closures.
8200 (Ffunctionp): Move from subr.el.
8201 (Ffuncall): Handle closures.
8202 (apply_lambda): Remove `eval_flags'.
8203 (funcall_lambda): Handle closures and new byte-code-functions.
8204 (Fspecial_variable_p): New function.
8205 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8206 but without exporting it to Lisp.
23aba0ea 8207
23aba0ea 8208 * doc.c (Fdocumentation, store_function_docstring):
03408648 8209 * data.c (Finteractive_form): Handle closures.
23aba0ea 8210
03408648
SM
8211 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8212 interactive spec.
ba83908c 8213
04f2d78b
CB
8214 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8215 New byte-codes.
03408648
SM
8216 (exec_byte_code): New function extracted from Fbyte_code to handle new
8217 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8218
03408648 8219 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8220
03408648 8221 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8222
e2abce01
JB
82232011-03-31 Juanma Barranquero <lekktu@gmail.com>
8224
8225 * xdisp.c (redisplay_internal): Fix prototype.
8226
63696a73 82272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8228
63696a73 8229 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8230 (try_scrolling): Use it when setting scroll_limit.
8231 Limit scrolling to 100 screen lines.
63696a73
EZ
8232 (redisplay_window): Even when falling back on "recentering",
8233 position point in the window according to scroll-conservatively,
8234 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8235
8236 (try_scrolling): When point is above the window, allow searching
8237 as far as scroll_max, or one screenful, to compute vertical
8238 distance from PT to the scroll margin position. This prevents
8239 try_scrolling from unnecessarily failing when
8240 scroll-conservatively is set to a value slightly larger than the
8241 window height. Clean up the case of PT below the margin at bottom
8242 of window: scroll_max can no longer be INT_MAX. When aggressive
8243 scrolling is in use, don't let point enter the opposite scroll
8244 margin as result of the scroll.
8245 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8246 threshold of 100 lines for never-recentering scrolling.
8247
e4cc2dfc
JB
82482011-03-31 Juanma Barranquero <lekktu@gmail.com>
8249
8250 * dispextern.h (move_it_by_lines):
8251 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8252 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8253 (message_log_check_duplicate): Remove parameters `prev_bol' and
8254 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8255 (redisplay_internal): Remove parameter `preserve_echo_area',
8256 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8257
8258 * indent.c (Fvertical_motion):
8259 * window.c (window_scroll_pixel_based, Frecenter):
8260 Don't pass `need_y_p' to `move_it_by_lines'.
8261
1c470562
SM
82622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8263
44f230aa
SM
8264 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8265 steal a few bits to be more compact.
8266 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8267 Remove unneeded casts.
8268
1c470562
SM
8269 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8270
888adce9
ZK
82712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8272
8273 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8274 binding" message (bug#7967).
8275
f838ed7b
PE
82762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8277
77861b95
PE
8278 Fix more problems found by GCC 4.6.0's static checks.
8279
de6dbc14
PE
8280 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8281 Remove unused local var.
8282
f838ed7b
PE
8283 * editfns.c (Fmessage_box): Remove unused local var.
8284
792c7b2b
PE
8285 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8286 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8287 Omit unused local vars.
c499e557 8288 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8289 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8290 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8291 Omit unused local var.
8292
ba0165e1
PE
8293 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8294 Don't assume string length fits in int.
32ad8845 8295 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8296 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8297
3c59b4c9
PE
8298 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8299 instead of alloca (Bug#8344).
8300
a3eed478 8301 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8302 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8303
eb4d412d
PE
8304 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8305
1658b401
PE
8306 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8307 concerns.
8308
8309 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8310
8311 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8312
9a2c6e05
PE
8313 * keyboard.c (syms_of_keyboard): Use the same style as later
8314 in this function when indexing through an array. This also
8315 works around GCC bug 48267.
8316
03d0a109
PE
8317 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8318
44f730c8
PE
8319 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8320
fe75f926
PE
8321 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8322 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8323
ffa8c828
PE
8324 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8325 This avoids undefined behavior on integer overflow, and is a bit
8326 more convenient anyway since it is compared to a size_t variable.
8327
c5101a77
PE
8328 Variadic C functions now count arguments with size_t, not int.
8329 This avoids an unnecessary limitation on 64-bit machines, which
8330 caused (substring ...) to crash on large vectors (Bug#8344).
8331 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8332 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8333 All variadic functions and their callers changed accordingly.
c5101a77
PE
8334 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8335 * data.c (arith_driver, float_arith_driver): Likewise.
8336 * editfns.c (general_insert_function): Likewise.
8337 * eval.c (struct backtrace.nargs, interactive_p)
8338 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8339 (funcall_lambda, mark_backtrace): Likewise.
8340 * fns.c (concat): Likewise.
8341 * frame.c (x_set_frame_parameters): Likewise.
8342 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8343 0 if not found, not -1. All callers changed.
8344
dd3f25f7
PE
8345 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8346 (stack_copy_size): Now size_t, not int.
8347 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8348
461c2ab9
JB
83492011-03-28 Juanma Barranquero <lekktu@gmail.com>
8350
8351 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8352 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8353 All callers changed.
8354
8355 * lisp.h (multibyte_char_to_unibyte):
8356 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8357 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8358 * character.h (CHAR_TO_BYTE8):
8359 * cmds.c (internal_self_insert):
8360 * editfns.c (general_insert_function):
8361 * keymap.c (push_key_description):
8362 * search.c (Freplace_match):
8363 * xdisp.c (message_dolog, set_message_1): All callers changed.
8364
f6d62986
SM
83652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8366
8367 * keyboard.c (safe_run_hook_funcall): New function.
8368 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8369 don't set the hook to nil, but remove the offending function instead.
8370 (Qcommand_hook_internal): Remove, unused.
8371 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8372 Vcommand_hook_internal.
8373
8374 * eval.c (enum run_hooks_condition): Remove.
8375 (funcall_nil, funcall_not): New functions.
8376 (run_hook_with_args): Call each function through a `funcall' argument.
8377 Remove `cond' argument, now redundant.
8378 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8379 (Frun_hook_with_args_until_failure): Adjust accordingly.
8380 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8381
1db5b1ad
JB
83822011-03-28 Juanma Barranquero <lekktu@gmail.com>
8383
8384 * dispextern.h (string_buffer_position): Remove declaration.
8385
8386 * print.c (strout): Remove parameter `multibyte', unused since
8387 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8388
8389 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8390 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8391 All callers changed.
8392
8393 * w32.c (_wsa_errlist): Use braces for struct initializers.
8394
8395 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8396 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8397 All callers changed.
8398 (string_buffer_position): Likewise. Also, make static (it's never
8399 used outside xdisp.c).
8400 (cursor_row_p): Remove parameter `w', unused since
8401 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8402 (decode_mode_spec): Remove parameter `precision', introduced during
8403 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8404 All callers changed.
8405
5ffb62aa
JD
84062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8407
8408 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8409
461c2ab9 84102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8411
8412 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8413 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8414 (ns_update_auto_hide_menu_bar): New functions.
8415 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8416 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8417 ns_constrain_all_frames.
8418 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8419 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8420
5c380ffb
JD
84212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8422
8423 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8424
9af30bdf
GM
84252011-03-27 Glenn Morris <rgm@gnu.org>
8426
8427 * syssignal.h: Replace RETSIGTYPE with void.
8428 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8429 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8430 Replace SIGTYPE with void everywhere.
8431 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8432 * s/template.h (SIGTYPE): Remove commented out definition.
8433
e2abce01
JB
84342011-03-26 Eli Zaretskii <eliz@gnu.org>
8435
8436 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8437 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8438
f868cd8a
JB
84392011-03-26 Juanma Barranquero <lekktu@gmail.com>
8440
59eb0929
JB
8441 * w32.c (read_unc_volume): Use parameter `henum', instead of
8442 global variable `wget_enum_handle'.
8443
8444 * keymap.c (describe_vector): Remove parameters `indices' and
8445 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8446 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8447
f868cd8a
JB
8448 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8449
8450 * keyboard.c (timer_check): Remove parameter `do_it_now',
8451 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8452 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8453 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8454
8455 * keyboard.c (read_char):
8456 * w32menu.c (w32_menu_display_help):
8457 * xmenu.c (show_help_event, menu_help_callback):
8458 Adjust calls to `show_help_echo'.
8459
8460 * gtkutil.c (xg_maybe_add_timer):
8461 * keyboard.c (readable_events):
8462 * process.c (wait_reading_process_output):
8463 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8464
8465 * insdel.c (adjust_markers_gap_motion):
8466 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8467 (gap_left, gap_right): Don't call it.
8468
2ecf6fdb
CY
84692011-03-25 Chong Yidong <cyd@stupidchicken.com>
8470
8471 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8472 incurred during fontification.
8473
6b1f9ba4
JB
84742011-03-25 Juanma Barranquero <lekktu@gmail.com>
8475
8476 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8477 (DEFVAR_PER_BUFFER): Don't pass it.
8478
8479 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8480 (scrolling_window): Don't pass it.
8481
0f4a96b5
JB
84822011-03-25 Juanma Barranquero <lekktu@gmail.com>
8483
8484 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8485
8486 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8487 and `suffix'.
8488 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8489 of variables specific to SELinux and computation of `encoded_absname'.
8490
8491 * image.c (XPutPixel): Remove unused variable `height'.
8492
8493 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8494
8495 * unexw32.c (get_section_info): Remove unused variable `section'.
8496
8497 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8498 (system_process_attributes): Remove unused variable `sess'.
8499 (sys_read): Remove unused variable `err'.
8500
8501 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8502 (w32_wnd_proc): Remove unused variable `isdead'.
8503 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8504 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8505 (x_create_tip_frame): Remove unused variable `tem'.
8506
8507 * w32inevt.c (w32_console_read_socket):
8508 Remove unused variable `no_events'.
8509
8510 * w32term.c (x_draw_composite_glyph_string_foreground):
8511 Remove unused variable `width'.
8512
1149507c
JB
85132011-03-24 Juanma Barranquero <lekktu@gmail.com>
8514
8515 * w32term.c (x_set_glyph_string_clipping):
8516 Don't pass uninitialized region to CombineRgn.
8517
9c88f339
JB
85182011-03-23 Juanma Barranquero <lekktu@gmail.com>
8519
8520 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8521 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8522 (Fx_close_connection): Remove unused variable `i'.
8523
8524 * w32font.c (w32font_draw): Return number of glyphs.
8525 (w32font_open_internal): Remove unused variable `i'.
8526 (w32font_driver): Add missing initializer.
8527
8528 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8529 (fill_in_menu): Remove unused variable `items_added'.
8530
8531 * w32term.c (last_mouse_press_frame): Remove static global variable.
8532 (w32_clip_to_row): Remove unused variable `f'.
8533 (x_delete_terminal): Remove unused variable `i'.
8534
8535 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8536 (NOTHING): Remove unused static global variable.
8537 (uniscribe_check_otf): Remove unused variable `table'.
8538 (uniscribe_font_driver): Add missing initializers.
8539
dee091a3
JD
85402011-03-23 Julien Danjou <julien@danjou.info>
8541
8542 * term.c (Fsuspend_tty, Fresume_tty):
8543 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8544 * window.c (temp_output_buffer_show):
8545 * insdel.c (signal_before_change):
8546 * frame.c (Fhandle_switch_frame):
8547 * fileio.c (Fdo_auto_save):
8548 * emacs.c (Fkill_emacs):
8549 * editfns.c (save_excursion_restore):
8550 * cmds.c (internal_self_insert):
8551 * callint.c (Fcall_interactively):
8552 * buffer.c (Fkill_all_local_variables):
8553 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8554 Use Frun_hooks.
0f4a96b5 8555 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8556 unconditionally since it does the check itself.
dee091a3 8557
2c520ab5 85582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8559
c9c49752
PE
8560 Fix more problems found by GCC 4.5.2's static checks.
8561
8abc3f12
PE
8562 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8563 the first time through the loop, since we know p0 < p1 then.
8564 This also avoids a gcc -Wstrict-overflow warning.
8565
a2d26660
PE
8566 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8567 leading to a memory leak, possible in functions like
8568 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8569 of objects (Bug#8318).
a2d26660 8570
916c72e9
PE
8571 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8572 that could (at least in theory) be that large.
8573
19ab8a18
PE
8574 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8575 This is less likely to overflow, and avoids undefined behavior if
8576 overflow does occur. All callers changed. Use strtoul to scan
8577 for the unsigned long integer.
b7cbbd6f
PE
8578 (pint2hrstr): Simplify and tune code slightly.
8579 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8580
f0641eff
PE
8581 * scroll.c (do_scrolling): Work around GCC bug 48228.
8582 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8583
7f650bb9
PE
8584 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8585 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8586 (validate_x_resource_name): Simplify count usage.
8587 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8588
37dd57d1
PE
8589 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8590 fail (Bug#8306).
81e56e61 8591
699979fc 8592 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8593
401bf9b4
PE
8594 * process.c (Fmake_network_process): Use socklen_t, not int,
8595 where POSIX says socklen_t is required in portable programs.
8596 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8597 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8598 (Fmake_network_process, server_accept_connection):
8599 (wait_reading_process_output, read_process_output):
8600 Likewise.
8601
b93aacde
PE
8602 * process.c: Rename or move locals to avoid shadowing.
8603 (list_processes_1, Fmake_network_process):
8604 (read_process_output_error_handler, exec_sentinel_error_handler):
8605 Rename or move locals.
4dc343ee 8606 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8607 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8608 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8609 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8610 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8611
af8a867c 8612 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8613 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8614 Include tparam.h instead, since it declares them.
af8a867c
PE
8615 * cm.h (PC): Remove extern decl; tparam.h now does this.
8616 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8617 * terminfo.c: Include tparam.h, to check interfaces.
8618 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8619 (tparam): Adjust signature to match interface in tparam.h;
8620 this removes some undefined behavior. Check that outstring and len
8621 are zero, which they always are with Emacs.
8622 * tparam.h (PC, BC, UP): New extern decls.
8623
0248044d 8624 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8625 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8626
8ff096c1 8627 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8628 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8629 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8630 (ftfont_list): Remove unused local.
49eaafba
PE
8631 (get_adstyle_property, ftfont_pattern_entity):
8632 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8633 Rename locals to avoid shadowing.
8ff096c1 8634
e2be39f6
PE
8635 * xfont.c (xfont_list_family): Mark var as initialized.
8636
c9735e30
PE
8637 * xml.c (make_dom): Now static.
8638
8f5201ae
PE
8639 * composite.c (composition_compute_stop_pos): Rename local to
8640 avoid shadowing.
b246f932
PE
8641 (composition_reseat_it): Remove unused locals.
8642 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8643 (composition_update_it): Mark var as initialized.
11b61122
PE
8644 (find_automatic_composition): Mark vars as initialized,
8645 with a FIXME (Bug#8290).
8f5201ae 8646
760fbc2c
PE
8647 character.h: Rename locals to avoid shadowing.
8648 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8649 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8650 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8651 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8652 to avoid shadowing.
8653
ff08eb85
PE
8654 * textprop.c (property_change_between_p): Remove; unused.
8655
fc7bf025
PE
8656 * intervals.c (interval_start_pos): Now static.
8657
235d7abc
PE
8658 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8659
44f230aa
SM
8660 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8661 Rename locals to avoid shadowing.
3e7d6594 8662
50060332
PE
8663 * sound.c (wav_play, au_play, Fplay_sound_internal):
8664 Fix pointer signedness.
d01f234b 8665 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8666 (wav_play): Initialize a variable to 0, to prevent undefined
8667 behavior (Bug#8278).
50060332 8668
c4fc4e30
PE
8669 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8670
918436ed
PE
8671 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8672
c939f91b
PE
8673 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8674 clobbering (Bug#8298).
b9c7f648
PE
8675 * sysdep.c (sys_subshell): Likewise.
8676 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8677
6bd8c144
PE
8678 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8679 This should get cleaned up, so that child_setup has the
8680 same signature on all platforms.
8681
7710357c 8682 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8683 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8684
c59da222
CY
86852011-03-22 Chong Yidong <cyd@stupidchicken.com>
8686
8687 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8688 not to be necessary, and produces flickering.
8689
66b87493
GM
86902011-03-20 Glenn Morris <rgm@gnu.org>
8691
8692 * config.in: Remove file.
8693
45b6f6d5
JB
86942011-03-20 Juanma Barranquero <lekktu@gmail.com>
8695
8696 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8697 are now in src/globals.h.
8698 (syms_of_minibuf): Remove spurious & from previous change.
8699
cd394be1 87002011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8701
8702 * minibuf.c (completing-read-function): New variable.
8703 (completing-read-default): Rename from completing-read.
8704 (completing-read): Call completing-read-function.
8705
b14e3e21
CY
87062011-03-19 Juanma Barranquero <lekktu@gmail.com>
8707
8708 * xfaces.c (Fx_load_color_file):
8709 Read color file from absolute filename (bug#8250).
8710
f2b726e6
JB
87112011-03-19 Juanma Barranquero <lekktu@gmail.com>
8712
8713 * makefile.w32-in: Update dependencies.
8714
09f6ff02
EZ
87152011-03-17 Eli Zaretskii <eliz@gnu.org>
8716
8717 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8718
29a6015a
PE
87192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8720
a3a6c54e
PE
8721 Fix more problems found by GCC 4.5.2's static checks.
8722
b766f867
PE
8723 * process.c (make_serial_process_unwind, send_process_trap):
8724 (sigchld_handler): Now static.
8725
be02381c
PE
8726 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8727 That way, the code declares only the vars that it needs.
8728 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8729 * s/cygwin.h (PTY_ITERATION): Likewise.
8730 * s/darwin.h (PTY_ITERATION): Likewise.
8731 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8732
57048744
PE
8733 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8734 * process.c (allocate_pty): Don't declare stb unless it's needed.
8735
7914961c 8736 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8737 (CONSTANTLIM): Remove; unused.
8738 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8739 Define only if needed.
7914961c 8740
b3967b18
PE
8741 * unexelf.c (unexec): Name an expression,
8742 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8743 Use a different way to cause a compilation error if anyone uses
8744 n rather than nn, a way that does not involve shadowing.
73366a00 8745 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8746
29a6015a
PE
8747 * deps.mk (unexalpha.o): Remove; unused.
8748
43cfc33e 8749 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8750 * unexec.h: New file.
ce701a33
PE
8751 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8752 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8753 Depend on unexec.h.
8754 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8755 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8756 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8757 Change as necessary to match prototype in unexec.h.
ce701a33 8758
01f44d5a
PE
8759 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8760 shadowing.
4f63c6bb 8761 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8762
a6670b0b
PE
8763 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8764 Rename locals to avoid shadowing.
8765
cef2010d 8766 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8767 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8768
d4d7173a
PE
8769 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8770
f08b802a
PE
8771 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8772 warning when compiling print.c.
8773
3ddb0639
PE
8774 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8775 instead of using an uninitialized var.
5ad03b97 8776 (font_sort_entities): Mark var as initialized.
3ddb0639 8777
170a2692
PE
8778 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8779
e663c700
PE
8780 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8781 pointers to constants.
89bc529a 8782 (font_parse_fcname): Remove unused vars.
7b81e2d0 8783 (font_delete_unmatched): Now static.
ea838e10 8784 (font_get_spec): Remove; unused.
13a547c6
PE
8785 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8786 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8787 Rename or move locals to avoid shadowing.
e663c700 8788
2a80c887 8789 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8790 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8791
1384fa33 8792 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8793 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8794
8b2c52e9
PE
8795 * alloc.c (mark_backtrace): Move decl from here ...
8796 * lisp.h: ... to here, so that it can be checked.
8797
475545b5 8798 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8799 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8800 (lisp_indirect_variable): Name an expression,
8801 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8802 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8803
b1349114 8804 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8805 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8806 Use const pointer when appropriate.
b1349114 8807
a2928364
PE
8808 * lisp.h (get_system_name, get_operating_system_release):
8809 Move decls here, to check interfaces.
8810 * process.c (get_operating_system_release): Move decl to lisp.h.
8811 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8812 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8813 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8814 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8815 (Fformat_time_string, Fencode_time, Finsert_char):
8816 (Ftranslate_region_internal, Fformat):
8817 Rename or remove local vars to avoid shadowing.
9710023e 8818 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8819
a415e694
PE
8820 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8821 avoid shadowing.
8822
8ef4622d
PE
8823 * lisp.h (eassert): Check that the argument compiles, even if
8824 ENABLE_CHECKING is not defined.
8825
946f9a5b
PE
8826 * data.c (Findirect_variable): Name an expression, to avoid
8827 gcc -Wbad-function-cast warning.
112396d6 8828 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8829 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8830 (Fmake_variable_buffer_local, Fmake_local_variable):
8831 Mark variables as initialized.
52746918 8832 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8833
e5aab7e7 8834 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8835 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8836 Rename locals to avoid shadowing.
dff45157
PE
8837 (mark_stack): Move local variables into the #ifdef region where
8838 they're used.
7bc26fdb
PE
8839 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8840 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8841 needed otherwise.
8842 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8843 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8844 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8845
e5aab7e7
PE
8846 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8847 avoids undefined behavior in theory.
8848
4da60324
PE
8849 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8850
88043301
PE
8851 Use functions, not macros, for up- and down-casing (Bug#8254).
8852 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8853 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8854 to use the following functions instead of these macros.
8855 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8856 EMACS_INT, since callers assume the returned value fits in int.
8857 (upcase1): Likewise, for UPCASE_TABLE.
8858 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8859 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8860 the race-condition problem in the old DOWNCASE.
88043301 8861
19ed5445
PE
8862 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8863 Rename locals to avoid shadowing.
8864 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8865 (regex_compile, re_search_2, re_match_2_internal):
8866 Remove unused local vars.
952db0d7
PE
8867 (FREE_VAR): Rewrite so as not to use empty "else",
8868 which gcc can warn about.
da053e48 8869 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8870 (RETALLOC_IF): Define only if needed.
8871 (WORDCHAR_P): Likewise. This one is never needed, but is used
8872 only in a comment talking about a compiler bug, so put inside
8873 the #if 0 of that comment.
8874 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8875 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8876 Remove; unused.
19ed5445 8877
1f3561e4 8878 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8879 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8880 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8881
ded6f8f7
PE
8882 * search.c (simple_search): Remove unused var.
8883
dbd37a95
PE
8884 * dired.c (compile_pattern): Move decl from here ...
8885 * lisp.h: ... to here, so that it can be checked.
8886 (struct re_registers): New forward decl.
8887
7e47afad
PE
8888 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8889
85f24f61
PE
8890 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8891 All uses changed.
8892 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8893 Rename locals to avoid shadowing.
5671df8f 8894 (Fvertical_motion): Mark locals as initialized.
85f24f61 8895
181aa2be 8896 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8897 (casify_region): Mark local as initialized.
181aa2be 8898
930d429c
PE
8899 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8900
7082eac6
PE
8901 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8902 New macros, so that the caller can use some names other than
8903 gcpro1, gcpro2, etc.
8904 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8905 of the new macros.
8906 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8907 argument, for consistency with GCPRO2_VAR, etc: it is now the
8908 prefix of the variable, not the variable itself. All uses
8909 changed.
38b2c076
PE
8910 * dired.c (directory_files_internal, file_name_completion):
8911 Rename locals to avoid shadowing.
8912
15206ed9
PE
8913 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8914 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8915 dired.c's scmp function, had undefined behavior.
8916 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8917 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8918 * buffer.h: ... to here, because these macros use current_buffer,
8919 and the new implementation with inline functions needs to have
8920 current_buffer in scope now, rather than later when the macros
8921 are used.
8922 (downcase, upcase1): New static inline functions.
8923 (DOWNCASE, UPCASE1): Reimplement using these functions.
8924 This avoids undefined behavior in expressions like
8925 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8926 from race conditions in accessing the global variables
8927 case_temp1 and case_temp2.
8928 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8929 * lisp.h (case_temp1, case_temp2): Remove their decls.
8930 * character.h (ASCII_CHAR_P): Move from here ...
8931 * lisp.h: ... to here, so that the inline functions mentioned
8932 above can use them.
8933
4a6bea26
PE
8934 * dired.c (directory_files_internal_unwind): Now static.
8935
f14b7e14
PE
8936 * fileio.c (file_name_as_directory, directory_file_name):
8937 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8938 Now static.
2893f146
PE
8939 (file_name_as_directory): Use const pointers when appropriate.
8940 (Fexpand_file_name): Likewise. In particular, newdir might
8941 point at constant storage, so make it a const pointer.
fd4ead52 8942 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8943 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8944 signedness issues.
f839df0c
PE
8945 (Fset_file_times, Finsert_file_contents, auto_save_error):
8946 Rename locals to avoid shadowing.
f14b7e14 8947
5716756e 8948 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8949 (Ftry_completion, Fall_completions): Rename or remove locals
8950 to avoid shadowing.
5716756e 8951
b4c3046a
PE
8952 * marker.c (bytepos_to_charpos): Remove; unused.
8953
b45db522
PE
8954 * lisp.h (verify_bytepos, count_markers): New decls,
8955 so that gcc does not warn that these functions aren't declared.
8956
85876d07
PE
8957 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8958 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8959 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8960 (copy_text): Remove unused local var.
85876d07 8961
03d78a21 8962 * filelock.c (within_one_second): Now static.
b3dd38ab 8963 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8964
5df8f01b
PE
8965 * buffer.c (fix_overlays_before): Mark locals as initialized.
8966 (fix_start_end_in_overlays): Likewise. This function should be
8967 simplified by using pointers-to-pointers, but that's a different
8968 matter.
b1d876f1 8969 (switch_to_buffer_1): Now static.
8f54f30a
PE
8970 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8971 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8972
a70072c9 8973 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8974 Fix pointer signedness issue.
edced198
PE
8975 (sys_subshell): Mark local as volatile if checking for lint,
8976 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8977 (MAXPATHLEN): Define only if needed.
a70072c9 8978
a0977c44
PE
8979 * process.c (serial_open, serial_configure): Move decls from here ...
8980 * systty.h: ... to here, so that they can be checked.
8981
a884fdcc
PE
8982 * fns.c (get_random, seed_random): Move extern decls from here ...
8983 * lisp.h: ... to here, so that they can be checked.
8984
604efe86 8985 * sysdep.c (reset_io): Now static.
b8950c94 8986 (wait_for_termination_signal): Remove; unused.
604efe86 8987
38fc62d9
PE
8988 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8989 (copy_keymap_item, append_key, push_text_char_description):
8990 Now static.
1004a21a 8991 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8992 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8993 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8994 (describe_map_tree):
8995 Rename locals to avoid shadowing.
38fc62d9 8996
2f2650da
PE
8997 * keyboard.c: Declare functions static if they are not used elsewhere.
8998 (echo_char, echo_dash, cmd_error, top_level_2):
8999 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9000 (read_char, kbd_buffer_get_event, make_lispy_position):
9001 (make_lispy_event, make_lispy_movement, apply_modifiers):
9002 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9003 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9004 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9005 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9006 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9007
a053e86c 9008 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9009 (mark_kboards): Move decl here ...
9010 * alloc.c (mark_kboards): ... from here.
a053e86c 9011
4752793e
PE
9012 * lisp.h (force_auto_save_soon): New decl.
9013
74f10ca7 9014 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9015 (DEFINE_DUMMY_FUNCTION): New macro.
9016 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9017 Use it.
c03cd23f
PE
9018 (main): Add casts to avoid warnings
9019 if GCC considers string literals to be constants.
74f10ca7 9020
022e70d4
PE
9021 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9022
59d6fe83
PE
9023 * dbusbind.c: Pointer signedness fixes.
9024 (xd_signature, xd_append_arg, xd_initialize):
9025 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9026 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9027 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9028 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9029
78320123
PE
9030 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9031 if GCC considers string literals to be constants.
49cebcca 9032 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9033
35ac2a97
SM
90342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9035
fb103ca9
SM
9036 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9037 (print_preprocess, print_object): New macro to fix last change.
9038
35ac2a97
SM
9039 * print.c (print_preprocess): Don't forget font objects.
9040
62973b41
JB
90412011-03-16 Juanma Barranquero <lekktu@gmail.com>
9042
9043 * emacs.c (USAGE3): Doc fixes.
9044
0e48bb22
AS
90452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9046
9047 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9048 structure.
9049
7684e57b
JB
90502011-03-14 Juanma Barranquero <lekktu@gmail.com>
9051
9052 * lisp.h (VWindow_system, Qfile_name_history):
9053 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9054 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9055 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9056
9057 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9058 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9059
9060 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9061 * w32console.c (detect_input_pending, read_input_pending)
9062 (encode_terminal_code):
9063 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9064 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9065 (w32_system_caret_y, Qfile_name_history):
9066 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9067 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9068 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9069 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9070 * w32proc.c (Qlocal, report_file_error):
9071 * w32term.c (Vwindow_system, updating_frame):
9072 * w32uniscribe.c (initialized, uniscribe_font_driver):
9073 Remove unneeded extern declarations.
9074
2aa46d6c
CY
90752011-03-14 Chong Yidong <cyd@stupidchicken.com>
9076
c96bbc66 9077 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9078
cffc6f3b
CY
90792011-03-13 Chong Yidong <cyd@stupidchicken.com>
9080
9081 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9082 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9083 These macros can no longer be used for assignment.
9084
44f230aa
SM
9085 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9086 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9087 (record_buffer_markers, fetch_buffer_markers): New functions for
9088 recording and fetching special buffer markers.
9089 (set_buffer_internal_1, set_buffer_temp): Use them.
9090
9091 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9092
9093 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9094
9095 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9096 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9097
9098 * xdisp.c (hscroll_window_tree):
9099 (reconsider_clip_changes): Use PT instead of BUF_PT.
9100
d251f04b
EZ
91012011-03-13 Eli Zaretskii <eliz@gnu.org>
9102
9103 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9104 $(EMACS_ROOT)/lib/intprops.h.
9105
f0c77cd1
PE
91062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9107
3eca4629
PE
9108 Fix more problems found by GCC 4.5.2's static checks.
9109
7c86ee98
PE
9110 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9111 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9112 (xg_free_frame_widgets): Make it clear that a local variable is
9113 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9114 (gdk_window_get_screen): Make it clear that this macro is needed
9115 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9116 (int_gtk_range_get_value): New function, which avoids a diagnostic
9117 from gcc -Wbad-function-cast.
9118 (xg_set_toolkit_scroll_bar_thumb): Use it.
9119 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9120 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9121 (get_utf8_string, xg_get_file_with_chooser):
9122 Rename locals to avoid shadowing.
9123 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9124
41729b81
PE
9125 * xgselect.c (xg_select): Remove unused var.
9126
f0c77cd1
PE
9127 * image.c (four_corners_best): Mark locals as initialized.
9128 (gif_load): Initialize transparent_p to zero (Bug#8238).
9129 Mark another local as initialized.
ec6cf4c6 9130 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9131
ce0ad53d 9132 * image.c (clear_image_cache): Now static.
d5d5a617 9133 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9134 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9135 (x_edge_detection): Remove unnecessary cast that
9136 gcc -Wbad-function-cast diagnoses.
2037898d 9137 (gif_load): Fix pointer signedness.
6ae141d6
PE
9138 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9139 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9140
33383987 91412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9142
d32df629
PE
9143 Improve quality of tests for time stamp overflow.
9144 For example, without this patch (encode-time 0 0 0 1 1
9145 1152921504606846976) returns the obviously-bogus value (-948597
9146 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9147 reports time overflow. See
9148 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9149 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9150 * editfns.c: Include limits.h and intprops.h.
9151 (TIME_T_MIN, TIME_T_MAX): New macros.
9152 (time_overflow): Move earlier, to before first use.
9153 (hi_time, lo_time): New functions, for an accurate test for
9154 out-of-range times.
9155 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9156 (Fget_internal_run_time): Don't assume time_t fits in int.
9157 (make_time): Use list2 instead of Fcons twice.
9158 (Fdecode_time): More accurate test for out-of-range times.
9159 (check_tm_member): New function.
9160 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9161 (lisp_time_argument): Don't rely on undefined left-shift and
9162 right-shift behavior when checking for time stamp overflow.
8be6f318 9163
fe31d94c
PE
9164 * editfns.c (time_overflow): New function, refactoring common code.
9165 (Fformat_time_string, Fdecode_time, Fencode_time):
9166 (Fcurrent_time_string): Use it.
9167
8be6f318
PE
9168 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9169 * dired.c (make_time): Move to ...
9170 * editfns.c (make_time): ... here.
9171 * systime.h: Note the move.
9172
09d9db2c 91732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9174
126bc0dc
YM
9175 * fringe.c (update_window_fringes): Remove unused variables.
9176
c47cbdfd
YM
9177 * unexmacosx.c (copy_data_segment): Also copy __got section.
9178 (Bug#8223)
9179
7ac80be9
EZ
91802011-03-12 Eli Zaretskii <eliz@gnu.org>
9181
c96bbc66 9182 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9183 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9184 Constify `char *' arguments and their references according to
9185 prototypes in tparam.h.
9186
ecb0f94d 9187 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9188
7ac80be9
EZ
9189 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9190 Adapt all references accordingly.
9191
9192 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9193
ef1fd07e
TT
91942011-03-11 Tom Tromey <tromey@redhat.com>
9195
9196 * buffer.c (syms_of_buffer): Remove obsolete comment.
9197
7ef4b50c
EZ
91982011-03-11 Eli Zaretskii <eliz@gnu.org>
9199
9200 * termhooks.h (encode_terminal_code): Declare prototype.
9201
9202 * msdos.c (encode_terminal_code): Don't declare prototype.
9203
9204 * term.c (encode_terminal_code): Now external again, used by
9205 w32console.c and msdos.c.
9206
44f230aa
SM
9207 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9208 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9209
4b1ec863 92102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9211
1714f52b 9212 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9213
4b1ec863
PE
9214 * fringe.c (update_window_fringes): Mark locals as initialized
9215 (Bug#8227).
9216 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9217
524c7aa6
PE
9218 * alloc.c (mark_fringe_data): Move decl from here ...
9219 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9220 to check its interface.
9221 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9222
a5c0af81 9223 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9224 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9225 (fontset_font): Mark local as initialized.
a9a06e0b 9226 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9227
b4716021
PE
9228 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9229
811e9bac 9230 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9231 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9232 (x_own_selection, Fx_disown_selection_internal): Rename locals
9233 to avoid shadowing.
9234 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9235
7e3ab302
PE
9236 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9237 so that the caller can use some name other than gcpro1.
9238 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9239 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9240 (Fx_backspace_delete_keys_p):
9241 Use them to avoid shadowing, and rename vars to avoid shadowing.
9242 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9243 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9244 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9245 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9246 Remove unused locals.
7e3ab302
PE
9247 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9248 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9249 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9250 macros.
f78faa98 9251
e2b13473
PE
9252 * xterm.h (x_mouse_leave): New decl.
9253
77f23912
PE
9254 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9255 Remove unused functions.
cdf4ba58
PE
9256 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9257 (x_calc_absolute_position): Now static.
7411c686 9258 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9259 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9260 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9261 unless they are used.
38d0b34a
PE
9262 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9263 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9264 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9265 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9266 (x_error_catcher, x_connection_closed, x_error_handler):
9267 (x_error_quitter, xembed_send_message, x_iconify_frame):
9268 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9269 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9270 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9271
44f230aa
SM
9272 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9273 Rename or move locals to avoid shadowing.
6b463e58 9274 (tty_defined_color, merge_face_heights): Now static.
5967d051 9275 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9276 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9277 does not deduce is never used uninitialized.
73719eba
PE
9278 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9279 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9280
426994c3 9281 * terminal.c (store_terminal_param): Now static.
5489860b 9282
032f1620 9283 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9284 (set_frame_menubar): Remove unused local.
d4323972 9285 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9286 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9287 since they might point to immutable storage.
281585b0
PE
9288 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9289 since it's unused otherwise.
032f1620 9290
367c19e5 9291 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9292 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9293 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9294 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9295 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9296 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9297 does not deduce are never used uninitialized.
70739cbe 9298
07b48fa9
PE
9299 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9300
8868a238 9301 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9302 * window.c (window_loop, size_window):
9303 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9304
7e5cf297 9305 * window.c (display_buffer): Now static.
d6550a9f
PE
9306 (size_window): Mark variables that gcc -Wuninitialized
9307 does not deduce are never used uninitialized.
a586633d
PE
9308 * window.h (check_all_windows): New decl, to forestall
9309 gcc -Wmissing-prototypes diagnostic.
5b555da1 9310 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9311
f6095868
PE
9312 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9313 shadowing.
9314 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9315 Include <limits.h>.
9316 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9317 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9318 (load_charset_map): Mark variables that gcc -Wuninitialized
9319 does not deduce are never used uninitialized.
53df7c11 9320 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9321
f38b440c
PE
9322 * coding.c (coding_set_source, coding_set_destination):
9323 Use "else { /* comment */ }" rather than "else /* comment */;"
9324 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9325 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9326 a block, when the outer 'i' will do.
9327 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9328 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9329 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9330 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9331 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9332 Rename locals to avoid shadowing.
9333 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9334 * coding.c (emacs_mule_char, encode_invocation_designation):
9335 Now static, since they're not used elsewhere.
413bb2db 9336 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9337 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9338 (decode_coding_emacs_mule): Mark variables that gcc
9339 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9340 (detect_coding_iso_2022): Initialize a local variable that might
9341 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9342 this initialization is needed. (Bug#8211)
5f58e762
PE
9343 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9344 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9345 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9346 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9347 Remove unused macros.
f38b440c 9348
232b38b9 9349 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9350 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9351 * character.c (string_count_byte8): Likewise.
232b38b9 9352
fb90da1b
PE
9353 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9354 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9355
fb93dbc2
PE
9356 * chartab.c (copy_sub_char_table): Now static, since it's not used
9357 elsewhere.
5c156ace
PE
9358 (sub_char_table_ref_and_range, char_table_ref_and_range):
9359 Rename locals to avoid shadowing.
bbcd0949 9360 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9361
7d3b3862 9362 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9363 (BIDI_BOB): Remove unused macro.
7d3b3862 9364
6be7d3da
PE
9365 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9366 deduce are never used uninitialized.
c2ed9c8b 9367 * term.c (encode_terminal_code): Likewise.
6be7d3da 9368
75f8807f 9369 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9370
50938595
PE
9371 * tparam.h: New file.
9372 * term.c, tparam.h: Include it.
9373 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9374 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9375 Move these decls to tparam.h, and make them agree with what
9376 is actually in tparam.c. The previous trick of using incompatible
9377 decls in different modules does not conform to the C standard.
9378 All callers of tparam changed to use tparam's actual API.
9379 * tparam.c (tparam1, tparam, tgoto):
9380 Use const pointers where appropriate.
9381
fbceeba2
PE
9382 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9383 * cm.h (struct cm): Likewise.
9384 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9385 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9386 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9387 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9388 (turn_on_face, init_tty): Likewise.
9389 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9390
7f3f1250
PE
9391 * term.c (term_mouse_position): Rename local to avoid shadowing.
9392
e6ca6543
PE
9393 * alloc.c (mark_ttys): Move decl from here ...
9394 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9395
c40f8d15
AS
93962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9397
9398 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9399
cfe0661d
JB
94002011-03-09 Juanma Barranquero <lekktu@gmail.com>
9401
9402 * search.c (compile_pattern_1): Remove argument regp, unused since
9403 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9404 (compile_pattern): Don't pass it.
9405
0afb4571
J
94062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9407
9408 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9409 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9410 for ! HAVE_GTK3.
9411 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9412
9413 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9414
9415 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9416 gdk_window_get_screen, gdk_window_get_geometry,
9417 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9418 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9419 (xg_get_pixbuf_from_pixmap): New function.
9420 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9421 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9422 Call xg_get_pixbuf_from_pixmap instead of
9423 gdk_pixbuf_get_from_drawable.
9424 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9425 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9426 (xg_check_special_colors): Use GtkStyleContext and its functions
9427 for HAVE_GTK3.
9428 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9429 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9430 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9431 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9432 Call gtk_widget_get_preferred_size.
0afb4571
J
9433 (xg_frame_resized): gdk_window_get_geometry only takes 5
9434 parameters.
44f230aa
SM
9435 (xg_win_to_widget, xg_event_is_for_menubar):
9436 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9437 (xg_set_widget_bg): New function.
9438 (delete_cb): New function.
895009e1 9439 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9440 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9441 (xg_set_background_color): Call xg_set_widget_bg.
9442 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9443 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9444 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9445 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9446 if ! HAVE_GTK3.
9447 (update_frame_tool_bar): Call gtk_widget_hide.
9448 (xg_initialize): Use GDK_KEY_g.
9449
9450 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9451 if ! HAVE_GTK3
9452 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9453
9454 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9455 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9456 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9457
1c2cc4ef
JB
94582011-03-08 Juanma Barranquero <lekktu@gmail.com>
9459
9460 * w32xfns.c (select_palette): Check success of RealizePalette against
9461 GDI_ERROR, not zero.
9462
33383987 9463See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9464
9465;; Local Variables:
9466;; coding: utf-8
aac0c6e3
MR
9467;; End:
9468
acaf905b 9469 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9470
9471 This file is part of GNU Emacs.
9472
9473 GNU Emacs is free software: you can redistribute it and/or modify
9474 it under the terms of the GNU General Public License as published by
9475 the Free Software Foundation, either version 3 of the License, or
9476 (at your option) any later version.
9477
9478 GNU Emacs is distributed in the hope that it will be useful,
9479 but WITHOUT ANY WARRANTY; without even the implied warranty of
9480 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9481 GNU General Public License for more details.
9482
9483 You should have received a copy of the GNU General Public License
9484 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.