* gtkutil.c (x_wm_set_size_hint): Use one row in call to
[bpt/emacs.git] / src / ChangeLog
CommitLineData
89c94350
JD
12012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5 zero (Bug#10954).
6
999dd333
GM
72012-03-03 Glenn Morris <rgm@gnu.org>
8
01a6dcc8 9 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 10
de0100f2
EZ
112012-03-02 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
14 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
15 (redisplay_window, next_element_from_string): Fix typos in
16 comments.
3e441275
EZ
17 (redisplay_window): Pass to move_it_vertically the margin in
18 pixels, not in screen lines.
de0100f2 19
96a72ee9
GM
202012-03-02 Glenn Morris <rgm@gnu.org>
21
22 * buffer.c (buffer-list-update-hook): Doc fix.
23
312508d7
EZ
242012-02-29 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
27 push_it before setting up the iterator for the first overlay
28 string, even if we have an empty string loaded.
29 (next_overlay_string): If there's an empty string on the iterator
30 stack, pop the stack. (Bug#10903)
31
27f3c637
PE
322012-02-25 Paul Eggert <eggert@cs.ucla.edu>
33
34 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
35 Suggested by Stefan Monnier in
36 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
37 * alloc.c (widen_to_Lisp_Object): New static function.
38 (mark_memory): Also mark Lisp_Objects by fetching pointer words
39 and widening them to Lisp_Objects. This would work even if
40 USE_LSB_TAG is defined and wide integers are used, which might
41 happen in a future version of Emacs.
42
3c9dfce6
CY
432012-02-25 Chong Yidong <cyd@gnu.org>
44
fa74b241
CY
45 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
46 Doc fix.
47
3c9dfce6
CY
48 * xselect.c (Fx_selection_exists_p): Doc fix.
49 (x_clipboard_manager_save_all): Print an informative message
50 before saving to clipboard manager.
51
9486df08
CY
522012-02-24 Chong Yidong <cyd@gnu.org>
53
54 * keyboard.c (process_special_events): Handle all X selection
55 requests in kbd_buffer, not just the next one (Bug#8869).
56
f01d3321
CY
572012-02-23 Chong Yidong <cyd@gnu.org>
58
59 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
60 call when setting menu-bar-lines and tool-bar-lines parameters.
61 (unwind_create_frame_1): New helper function.
62
63 * window.c (inhibit_window_configuration_change_hook): New var.
64 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 65 (syms_of_window): Initialize it.
f01d3321 66
86b847b6
CY
672012-02-22 Chong Yidong <cyd@gnu.org>
68
69 * xterm.c (x_draw_image_relief): Add missing type check for
70 Vtool_bar_button_margin (Bug#10743).
71
a59225b1
CY
722012-02-21 Chong Yidong <cyd@gnu.org>
73
74 * fileio.c (Vfile_name_handler_alist): Doc fix.
75
76 * buffer.c (Fget_file_buffer): Protect against invalid file
77 handler return value.
78
310f5bd4
PE
792012-02-20 Paul Eggert <eggert@cs.ucla.edu>
80
cb3a28cc
PE
81 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
82 when computing $valmask.
83
310f5bd4
PE
84 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
85 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
86 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
87 It's useless in that case, and it can cause problems on hosts
88 that allocate halves of EMACS_INT values separately.
89 Reported by Dan Horák. Diagnosed by Andreas Schwab in
90 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
91 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
92 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
93 it avoids undefined behavior on hosts where shifting right by more
94 than the word width has undefined behavior.
95
2375c96a
CY
962012-02-19 Chong Yidong <cyd@gnu.org>
97
98 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
99 (Funhandled_file_name_directory, Ffile_name_as_directory)
100 (Fdirectory_file_name, Fexpand_file_name)
101 (Fsubstitute_in_file_name): Protect against invalid file handler
102 return values (Bug#10845).
103
3eb49e71
EZ
1042012-02-18 Eli Zaretskii <eliz@gnu.org>
105
106 * .gdbinit (pitx): Fix incorrect references to fields of the
107 iterator stack.
108
7b926f3f
CY
1092012-02-17 Chong Yidong <cyd@gnu.org>
110
111 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
112
11273115
PE
1132012-02-15 Paul Eggert <eggert@cs.ucla.edu>
114
115 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
116 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
117
c3a70e2b
CY
1182012-02-15 Chong Yidong <cyd@gnu.org>
119
120 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
121 marked as special. Also, starting docstrings with * is obsolete.
122
0ca43699
AS
1232012-02-13 Andreas Schwab <schwab@linux-m68k.org>
124
125 * gnutls.c (emacs_gnutls_write): Fix last change.
126
2e8f3c56
LI
1272012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
128
129 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
130 send_process.
131
af70074f
SM
1322012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
133
134 * keymap.c (Fsingle_key_description): Handle char ranges.
135
95986d52
CY
1362012-02-12 Chong Yidong <cyd@gnu.org>
137
afd83bd1
CY
138 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
139 as that creates a dangerous corner case.
140
95986d52
CY
141 * window.c (Fdelete_window_internal): Invalidate the mouse
142 highlight (Bug#9904).
143
bd7da63e
GM
1442012-02-12 Glenn Morris <rgm@gnu.org>
145
146 * xselect.c (Fx_own_selection_internal)
147 (Fx_get_selection_internal, Fx_disown_selection_internal)
148 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
149 * nsselect.m (Fx_own_selection_internal)
150 (Fx_disown_selection_internal, Fx_selection_exists_p)
151 (Fx_selection_owner_p, Fx_get_selection_internal):
152 Sync docs and argument specs with the xselect.c versions.
153
77abcbc2
LI
1542012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
155
156 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
157
90b671e2
EZ
1582012-02-11 Eli Zaretskii <eliz@gnu.org>
159
1c0ca0b7
EZ
160 * w32select.c (Fx_selection_exists_p): Sync doc string and
161 argument list with xselect.c. (Bug#10783)
162
163 * w16select.c (Fx_selection_exists_p): Sync doc string and
164 argument list with xselect.c. (Bug#10783)
90b671e2 165
49241268
GM
1662012-02-10 Glenn Morris <rgm@gnu.org>
167
168 * fns.c (Fsecure_hash): Doc fix.
169
f998bbe7 1702012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
171
172 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
173
0992bd9c
CY
1742012-02-07 Chong Yidong <cyd@gnu.org>
175
176 * buffer.c (Fbuffer_local_variables)
177 (buffer_lisp_local_variables): Handle unbound vars correctly;
178 don't let Qunbound leak into Lisp.
179
af008560
GM
1802012-02-07 Glenn Morris <rgm@gnu.org>
181
dd605cc4
GM
182 * image.c (Fimagemagick_types): Doc fix.
183
af008560
GM
184 * image.c (imagemagick-render-type): Change it from a lisp object
185 to an integer. Move the doc here from the lisp manual.
186 Treat all values not equal to 0 the same.
187
1449fa1d
CY
1882012-02-06 Chong Yidong <cyd@gnu.org>
189
190 * doc.c (store_function_docstring): Avoid applying docstring of
191 alias to base function (Bug#2603).
192
3723ec07
AS
1932012-02-04 Andreas Schwab <schwab@linux-m68k.org>
194
195 * .gdbinit (pp1, pv1): Remove redundant defines.
196 (pr): Use pp.
197
79c1cc1e
CY
1982012-02-04 Chong Yidong <cyd@gnu.org>
199
200 * nsterm.m: Declare a global (Bug#10694).
201
d7f29f8e
EZ
2022012-02-04 Eli Zaretskii <eliz@gnu.org>
203
204 * w32.c (get_emacs_configuration_options): Include
205 --enable-checking, if specified, in the return value.
206
3b95a6f9
MR
2072012-02-04 Martin Rudalics <rudalics@gmx.at>
208
209 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
210 after rounding frame sizes. (Bug#9723)
211
d6fa96a6
EZ
2122012-02-04 Eli Zaretskii <eliz@gnu.org>
213
214 * keyboard.c (adjust_point_for_property): Don't position point
215 before BEGV. (Bug#10696)
216
df0b2940
PE
2172012-02-03 Paul Eggert <eggert@cs.ucla.edu>
218
219 Handle overflow when computing char display width (Bug#9496).
220 * character.c (char_width): Return EMACS_INT, not int.
221 (char_width, c_string_width): Check for overflow when
222 computing the width; this is possible now that individual
223 characters can have unbounded width. Problem introduced
224 by merge from Emacs 23 on 2012-01-19.
225
6bee44d6
MA
2262012-02-02 Michael Albinus <michael.albinus@gmx.de>
227
228 * dbusbind.c (Fdbus_register_method): Mention the return value
229 :ignore in the docstring.
230
44f92739
GM
2312012-02-02 Glenn Morris <rgm@gnu.org>
232
1b9f60cc
GM
233 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
234
44f92739
GM
235 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
236 Unconditionally set to t. (Bug#10673)
237 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
238 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
239 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
240
c5d3843c
KH
2412012-02-02 Kenichi Handa <handa@m17n.org>
242
243 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
244 0, do not call append_composite_glyph.
245
159462d4 2462012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
247
248 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
249 NULL (Bug#6988).
250 (x_produce_glyphs): If the component of a composition is a null
251 string, set it->pixel_width to 1 to avoid zero-width glyph.
252
78cef877
EZ
2532012-02-01 Eli Zaretskii <eliz@gnu.org>
254
255 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
256 first 2 arguments are identical. This makes inserting large
257 output from a subprocess an order of magnitude faster on
258 MS-Windows, where all sbrk'ed memory is always contiguous.
259
97897668
GM
2602012-01-31 Glenn Morris <rgm@gnu.org>
261
262 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 263 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
264 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
265
31fd3586
GM
2662012-01-29 Glenn Morris <rgm@gnu.org>
267
268 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
269
0e24a8b2
CY
2702012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
271
272 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
273
cc0adcb0
CY
2742012-01-28 Chong Yidong <cyd@gnu.org>
275
276 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
277
acc28cb9
CY
2782012-01-26 Chong Yidong <cyd@gnu.org>
279
9c69cfb7
CY
280 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
281
acc28cb9
CY
282 * search.c (Fsearch_forward, Fsearch_backward): Document negative
283 repeat counts (Bug#10507).
284
48da7392
GM
2852012-01-26 Glenn Morris <rgm@gnu.org>
286
287 * lread.c (syms_of_lread): Doc fix.
288
14af5f7f
CY
2892012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
290
291 * coding.c (encode_designation_at_bol): Change return value to
292 EMACS_INT.
293
0b21c100
CY
2942012-01-25 Chong Yidong <cyd@gnu.org>
295
296 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
297
3c2907f7
CY
2982012-01-21 Chong Yidong <cyd@gnu.org>
299
300 * floatfns.c (Fcopysign): Make the second argument non-optional,
301 since nil is not allowed anyway.
302
959ad23f
AS
3032012-01-21 Andreas Schwab <schwab@linux-m68k.org>
304
305 * process.c (read_process_output): Use p instead of XPROCESS (proc).
306 (send_process): Likewise.
307
34a02f46
MR
3082012-01-19 Martin Rudalics <rudalics@gmx.at>
309
310 * window.c (save_window_save, Fcurrent_window_configuration)
311 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
312 doc-strings.
313
1259009a 3142012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
315
316 * character.c (char_width): New function.
70d4fdf6
GM
317 (Fchar_width, c_string_width, lisp_string_width):
318 Use char_width (Bug#9496).
25ed9e61 319
6a6ee00d
MR
3202012-01-16 Martin Rudalics <rudalics@gmx.at>
321
322 * window.c (Vwindow_persistent_parameters): New variable.
323 (Fset_window_configuration, save_window_save): Handle persistent
324 window parameters.
325
c85efaf7
EZ
3262012-01-14 Eli Zaretskii <eliz@gnu.org>
327
328 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
329 thrashing the stack of the thread. (Bug#9087)
330
5944709e
PE
3312012-01-12 Paul Eggert <eggert@cs.ucla.edu>
332
333 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
334
e71f5d99
EZ
3352012-01-11 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (rows_from_pos_range): Handle the case where the
338 highlight ends on a newline. (Bug#10464)
339 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
340 he end column for display of highlight that ends on a newline
341 before a R2L line.
342
ce316182
GM
3432012-01-11 Glenn Morris <rgm@gnu.org>
344
345 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
346 from load-path also when installation-directory is nil. (Bug#10208)
347
5b43da69
GM
3482012-01-10 Glenn Morris <rgm@gnu.org>
349
74cc8ff9
GM
350 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
351
7d8d6e4e
GM
352 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
353 Update template values to be closer to their typical values these days.
5b43da69 354
a0db8d43
EZ
3552012-01-09 Eli Zaretskii <eliz@gnu.org>
356
357 * xdisp.c (rows_from_pos_range): Accept additional argument
358 DISP_STRING, and accept any glyph in a row whose object is that
359 string as eligible for mouse highlight. Fixes mouse highlight of
360 display strings from overlays. (Bug#10464)
361
9a0115ab 3622012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 363
b9110d6a 364 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
365 * fileio.c (auto_saving_dir_umask): New static var.
366 (Fmake_directory_internal): Use it.
367 (do_auto_save_make_dir): Set it, instead of invoking chmod after
368 creating the directory. The old code temporarily assigns
369 too-generous permissions to the directory.
370 (do_auto_save_eh): Clear it.
b9110d6a 371 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
372 that the var is always cleared.
373
6c1bd3f3
EZ
3742012-01-07 Eli Zaretskii <eliz@gnu.org>
375
376 * search.c (scan_buffer): Pass character positions to
377 know_region_cache, not byte positions. (Bug#6540)
378
069d2b50
L
3792012-01-07 LynX <_LynX@bk.ru> (tiny change)
380
381 * w32.c (sys_rename): Report EXDEV when rename of a directory
382 fails because the target is on another logical disk. (Bug#10284)
383
75bf0d33
DB
3842012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
385
386 * xterm.c (x_embed_request_focus): New function.
387
388 * xterm.h: Add prototype.
389
390 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
391
1c6e5a32
GM
3922012-01-05 Glenn Morris <rgm@gnu.org>
393
394 * emacs.c (emacs_copyright): Update short copyright year to 2012.
395
651e947e
EZ
3962012-01-01 Eli Zaretskii <eliz@gnu.org>
397
398 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
399 Load gnutls_transport_set_lowat only if GnuTLS version is below
400 2.11.1.
401 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
402 GnuTLS versions below 2.11.1.
403
3778cdd8
AL
4042011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
405
406 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
407 to the doc string advising against its use for altering the way
408 windows are scrolled.
409
0e5317f7
KH
4102011-12-28 Kenichi Handa <handa@m17n.org>
411
412 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
413 coding-system ASCII compatible only when it does not produce BOM
414 on encoding (Bug#10383).
415
93d5ca1f
JD
4162011-12-26 Jan Djärv <jan.h.d@swipnet.se>
417
418 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
419 can scroll.
420 (create_and_show_popup_menu): Always use menu_position_func for
421 Gtk3 (Bug#10361).
422
ca22b785
AS
4232011-12-24 Andreas Schwab <schwab@linux-m68k.org>
424
425 * callint.c (Fcall_interactively): Don't truncate prompt string.
426
d048e1e6
EZ
4272011-12-23 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
430 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 431 resumed from there (after widening). (Bug#10360)
d048e1e6 432
5ccaba1f
JD
4332011-12-22 Jan Djärv <jan.h.d@swipnet.se>
434
435 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
436
204ee57f
JD
4372011-12-21 Jan Djärv <jan.h.d@swipnet.se>
438
b81d40f0
JB
439 * nsterm.m (x_free_frame_resources):
440 Release f->output_data.ns->miniimage.
204ee57f
JD
441 (ns_index_color): Fix indentation. Do not retain
442 color_table->colors[i].
443
444 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
445 before returning.
446
447 * nsfns.m (x_set_background_color): Assign return value from
448 ns_index_color to face-background instead of NSColor*.
449 (ns_implicitly_set_icon_type): Fix indentation.
450 Change assignment in for loop to comparison.
451
452 * emacs.c (ns_pool): New variable.
453 (main): Assign ns_pool.
454 (Fkill_emacs): Call ns_release_autorelease_pool.
455
456 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
457 autorelease fdesc, release fdAttrs and tdict.
458 (ns_get_covering_families): Release charset.
459 (ns_findfonts): Release NSFontDescriptor created with new.
460 (ns_uni_to_glyphs): Fix indentation.
461 (setString): Release attrStr before assigning new value.
462
c803b2b7
JD
4632011-12-18 Jan Djärv <jan.h.d@swipnet.se>
464
678f4426
JD
465 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
466 and NS_IMPL_COCOA.
467 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
468 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
469
cd394be1 4702011-12-18 David Reitter <reitter@cmu.edu>
678f4426 471
5fecd5fc
JD
472 * nsterm.m (ns_term_init): Subscribe for notifications
473 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
474 to method trackingNotification in EmacsMenu.
475
476 * nsmenu.m (trackingMenu): New variable.
3771cb17 477 (trackingNotification): New method (from Aquamacs).
5fecd5fc 478 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 479 from Aquamacs (Bug#7030).
678f4426
JD
480
4812011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 482
c803b2b7
JD
483 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
484 (symbol_to_nsstring): Fix indentation.
485 (ns_symbol_to_pb): New function.
486 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
487 (Fns_rotate_cut_buffers_internal): Removed.
488 (Fns_store_selection_internal): Renamed from
489 Fns_store_cut_buffer_internal.
490 (ns_get_foreign_selection, Fx_own_selection_internal)
491 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
492 (Fns_get_selection_internal, Fns_store_selection_internal):
493 Use ns_symbol_to_pb and check if return value is nil.
494 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
495 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
496 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
497 renamed to Sns_store_selection_internal.
498 (ns_handle_selection_request): Move code to Fx_own_selection_internal
499 and remove this function.
500 (ns_handle_selection_clear): Remove, never used.
501 (Fx_own_selection_internal): Move code from ns_handle_selection_request
502 here.
503
e1b01a3a
KB
5042011-12-17 Ken Brown <kbrown@cornell.edu>
505
506 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
507 GID is unknown (Bug#10257).
508
2adb6e85
PE
5092011-12-17 Paul Eggert <eggert@cs.ucla.edu>
510
511 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
512 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
513 which caused a build failure on GNU/Linux IA-64. This problem was
514 introduced by my 2011-10-07 patch.
515
d1d7b339
JL
5162011-12-15 Juri Linkov <juri@jurta.org>
517
518 * image.c (imagemagick_error): New function. (Bug#10112)
519 (imagemagick_load_image): Comment out `MagickSetResolution' call.
520 Use `imagemagick_error' where ImageMagick functions return
521 `MagickFalse'.
522 (Fimagemagick_types): Add `Fnreverse' to return the list in the
523 proper order.
524
100d5755
KH
5252011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
526
527 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
528 fill background (Bug#8992).
529
454592a6
MR
5302011-12-13 Martin Rudalics <rudalics@gmx.at>
531
532 * window.c (Vwindow_combination_resize)
533 (Vwindow_combination_limit): Use t instead of non-nil in
534 doc-strings.
61d4b438
MR
535 (Vrecenter_redisplay): Add first sentence of doc-string on
536 separate line.
53524d93 537 (Frecenter): Fix doc-string typo.
454592a6 538
3633e3aa
KH
5392011-12-11 Kenichi Handa <handa@m17n.org>
540
541 * coding.c (Funencodable_char_position): Pay attention to the
542 buffer text relocation (Bug#9389).
543
7b9d523a
JD
5442011-12-10 Jan Djärv <jan.h.d@swipnet.se>
545
546 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
547 gtk_init (Bug#10100).
548
b73189c6
EZ
5492011-12-10 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
552 IT->string is nil. (Bug#10263)
553
f7dfe5d6
JD
5542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
555
83faebb4
JD
556 * nsterm.h (x_free_frame_resources): Declare.
557
f7dfe5d6
JD
558 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
559 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
560
561 * nsterm.h (ns_get_defaults_value): Declare.
562
563 * nsterm.m (ns_default): Call ns_get_defaults_value.
564
7cd4e72c
EZ
5652011-12-09 Eli Zaretskii <eliz@gnu.org>
566
567 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
568 (Bug#10170)
569
b34d7317
YM
5702011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
571
572 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
573 that where the value of an _OBJC_* symbol points to is in the .bss
574 section (Bug#10240).
575
76470ad1
KH
5762011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
577
578 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 579 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 580
745fff94
KH
5812011-12-08 Kenichi Handa <handa@m17n.org>
582
583 * ftfont.c (get_adstyle_property): Fix previous change
584 (Bug#10233).
585
6e44397c
JB
5862011-12-07 Juanma Barranquero <lekktu@gmail.com>
587
588 * w32.c (init_environment): If no_site_lisp, remove site-lisp
589 dirs from the default value of EMACSLOADPATH (bug#10208).
590
7efa6272
GM
5912011-12-07 Glenn Morris <rgm@gnu.org>
592
593 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
594 installation and source directories as well. (Bug#10208)
595
f6fc4d87
CY
5962011-12-06 Chong Yidong <cyd@gnu.org>
597
598 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
599
2bf26180
GM
6002011-12-06 Glenn Morris <rgm@gnu.org>
601
602 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
603 as an error, not just -1. (Bug#10217)
604
3a6ad4f0
CY
6052011-12-05 Chong Yidong <cyd@gnu.org>
606
607 * keyboard.c (process_special_events): New function.
608 (swallow_events, Finput_pending_p): Use it (Bug#10195).
609
75a3b399
PE
6102011-12-05 Paul Eggert <eggert@cs.ucla.edu>
611
612 * coding.c (encode_designation_at_bol): Don't use uninitialized
613 local variable (Bug#9318).
614
c3c9e25e
KH
6152011-12-05 Kenichi Handa <handa@m17n.org>
616
617 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
618 return Qnil (Bug#8046, Bug#10193).
619
5eb05ea3
KH
6202011-12-05 Kenichi Handa <handa@m17n.org>
621
622 * coding.c (encode_designation_at_bol): New args charbuf_end and
623 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
624 (coding_set_source): Return how many bytes coding->source was
625 relocated.
626 (coding_set_destination): Return how many bytes
627 coding->destination was relocated.
628 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
629 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
630
6312011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
632
633 * coding.c (CODING_CHAR_CHARSET_P): New macro.
634 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
635 macro (Bug#9318).
636
6372011-12-05 Andreas Schwab <schwab@linux-m68k.org>
638
639 The following changes are to fix Bug#9318.
640
a79703f5 641 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
642 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
643 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 644 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 645
7dbda6df
JB
6462011-12-05 Juanma Barranquero <lekktu@gmail.com>
647
648 * lisp.h (process_quit_flag): Fix external declaration.
649
6d5eb5b0
SM
6502011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
651
652 Don't macro-inline non-performance-critical code.
653 * eval.c (process_quit_flag): New function.
654 * lisp.h (QUIT): Use it.
655
a0c3fad0
JD
6562011-12-04 Jan Djärv <jan.h.d@swipnet.se>
657
658 * nsfns.m (get_geometry_from_preferences): New function.
659 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
660
6c07aac2
AS
6612011-12-04 Andreas Schwab <schwab@linux-m68k.org>
662
663 * emacs.c (Qkill_emacs): Define.
664 (syms_of_emacs): Initialize it.
665 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
666 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
667 (quit_throw_to_read_char): Add parameter `from_signal'.
668 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
669 * lisp.h (QUIT): Call Fkill_emacs if requested.
670
c052ead4
JD
6712011-12-03 Jan Djärv <jan.h.d@swipnet.se>
672
673 * widget.c (update_wm_hints): Return if wmshell is null.
674 (widget_update_wm_size_hints): New function.
675
676 * widget.h (widget_update_wm_size_hints): Declare.
677
678 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
679 widget_update_wm_size_hints (Bug#10104).
680
9e49252b
EZ
6812011-12-03 Eli Zaretskii <eliz@gnu.org>
682
683 * xdisp.c (handle_invisible_prop): If the invisible text ends just
684 before a newline, prepare the bidi iterator for consuming the
685 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 686 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 687
02b16839
JL
6882011-12-02 Juri Linkov <juri@jurta.org>
689
690 * search.c (Fword_search_regexp): New Lisp function created from
691 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
692 (Fword_search_backward, Fword_search_forward)
693 (Fword_search_backward_lax, Fword_search_forward_lax):
694 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
695 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
696
0068070e
SM
6972011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
698
699 * fileio.c (Finsert_file_contents): Move after-change-function call
700 to before the "handled:" label, since all "goto handled" appear in
701 cases where the *-change-functions have already been properly called
702 (bug#10117).
703
3360a3fc
AS
7042011-12-01 Andreas Schwab <schwab@linux-m68k.org>
705
706 * keyboard.c (interrupt_signal): Don't call kill-emacs when
707 waiting for input. (Bug#10169)
708
73d6c093
EZ
7092011-11-30 Eli Zaretskii <eliz@gnu.org>
710
711 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
712 verifies glyph row's hash code--we have just reallocated the
713 glyphs, so their contents can be complete garbage. (Bug#10164)
714
febe6bea
JB
7152011-11-30 Juanma Barranquero <lekktu@gmail.com>
716
717 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
718
801a4313
EZ
7192011-11-30 Eli Zaretskii <eliz@gnu.org>
720
721 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
722 attributes are tested _before_ calling verify_row_hash, to protect
723 against GCC re-ordering of the tests. (Bug#10164)
724
2b56b87e
JD
7252011-11-29 Jan Djärv <jan.h.d@swipnet.se>
726
727 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
728
729 * xterm.c (handle_one_xevent): Only set async_visible and friends
730 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 731 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
732 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
733
dbf31225
PE
7342011-11-28 Paul Eggert <eggert@cs.ucla.edu>
735
736 Remove GCPRO-related macros that exist only to avoid shadowing locals.
737 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
738 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
739 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
740 All uses changed to use GCPRO1 etc.
741 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
742 Revert to old implementation (i.e., before 2011-03-11).
743
1305621b
YM
7442011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
745
746 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
747 of scroll runs so as to avoid assigning disabled bogus rows and
748 unnecessary graphics copy operations.
749
8c9afb46
EZ
7502011-11-27 Eli Zaretskii <eliz@gnu.org>
751
752 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
753 (snprintf) [_MSC_VER]: Redirect to _snprintf.
754 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
755 (malloc, free, realloc, calloc): Redirect to e_* only when
756 compiling Emacs.
757
758 * lisp.h (GCTYPEBITS): Move before first use.
759 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
760 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
761 this macro definition.
762
763 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
764 _MSC_VER.
765
54e9e3bf
JD
7662011-11-27 Jan Djärv <jan.h.d@swipnet.se>
767
6d5eb5b0
SM
768 * gtkutil.c (xg_create_frame_widgets):
769 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
770 present with Gtk+ 2.0.
771
83aca1cb
PE
7722011-11-26 Paul Eggert <eggert@cs.ucla.edu>
773
774 * fileio.c (Finsert_file_contents): Undo previous change; see
775 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
776
5b76caa4
PE
7772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
778
779 Rename locals to avoid shadowing.
780 * fileio.c (Finsert_file_contents):
781 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
782 * process.c (wait_reading_process_output):
783 Rename inner 'proc' to 'p' to avoid shadowing.
784 Indent for consistency with usual Emacs style.
785
8c535114
EZ
7862011-11-25 Eli Zaretskii <eliz@gnu.org>
787
788 * xdisp.c (redisplay_window): If cursor row is not fully visible
789 after recentering, and scroll-conservatively is set to a large
790 number, scroll window by a few more lines to make the cursor fully
791 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
792 (start_display): Don't move to the next line if the display should
793 start at a newline that is part of a display vector or an overlay
794 string. (Bug#10119)
8c535114 795
fa4fdb5c
JL
7962011-11-24 Juri Linkov <juri@jurta.org>
797
798 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
799 after the `MagickPingImage' call. (Bug#10112)
800
90ec88df
CY
8012011-11-23 Chong Yidong <cyd@gnu.org>
802
803 * window.c (Fcoordinates_in_window_p): Accept only live windows.
804
56e2e794
MR
8052011-11-23 Martin Rudalics <rudalics@gmx.at>
806
807 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
808 making another buffer current. (Bug#10114)
809
b6e64c41
GM
8102011-11-23 Glenn Morris <rgm@gnu.org>
811
812 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
813
6b21de18
CY
8142011-11-23 Chong Yidong <cyd@gnu.org>
815
816 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
817 using it (Bug#5984).
818
b12cd789
EZ
8192011-11-22 Eli Zaretskii <eliz@gnu.org>
820
821 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
822 and header-lines, as they don't have one computed for them.
823 (Bug#10098)
824
825 * .gdbinit (prow): Make displayed values more self-explaining.
826 Add row's hash code.
827
261b6fd4
LMI
8282011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
829
830 * process.c (wait_reading_process_output): Fix asynchrounous
831 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 832 (wait_reading_process_output): Add comment and URL.
261b6fd4 833
e7cfd277
JD
8342011-11-21 Jan Djärv <jan.h.d@swipnet.se>
835
836 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
837
a9b9b7f5
CY
8382011-11-21 Chong Yidong <cyd@gnu.org>
839
840 * window.c (Fnext_window, Fprevious_window): Doc fix.
841
b0d15b4f
SM
8422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
845
fe7a3057
JB
8462011-11-20 Juanma Barranquero <lekktu@gmail.com>
847
848 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
849
d2999b1a
MR
8502011-11-20 Martin Rudalics <rudalics@gmx.at>
851
852 * window.c (Fset_window_combination_limit): Rename argument
853 STATUS to LIMIT.
854 (Vwindow_combination_limit): Remove "status" from doc-string.
855
d5ff9cd0
AS
8562011-11-20 Andreas Schwab <schwab@linux-m68k.org>
857
858 * m/ibms390.h: Remove.
859 * m/ibms390x.h: Don't include "ibms390.h".
860
a5bb9bd3
SM
8612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
862
863 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
864 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
865
cd1181db
JB
8662011-11-20 Juanma Barranquero <lekktu@gmail.com>
867
868 * casetab.c (Fset_case_table):
869 * charset.c (Fcharset_after): Fix typos.
870
615a3b8d 8712011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 872
17e845af
PE
873 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
874 Otherwise, valgrind does not work on some platforms.
875 Problem reported by Andreas Schwab in
6a0bf43d
PE
876 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
877 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
878 is set, removing the need for VIRT_ADDRESS_VARIES.
879 (PURE_P): Use a more-efficient implementation that needs just one
880 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
881 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
882 to 4 (xorl, subq, cmpq, setbe).
883 * alloc.c (pure): Always extern now, since that's the
884 VIRT_ADDR_VARIES behavior.
885 (PURE_POINTER_P): Use a single comparison, not two, for
886 consistency with the new puresize.h.
887 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
888 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
889 Remove VIRT_ADDR_VARIES no longer needed.
890
f8fe6f96
EZ
8912011-11-19 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
894 (erase_phys_cursor, update_window_cursor, show_mouse_face)
895 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
896 behave as if the cursor position were at the window margin.
897
898 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
899 and the cursor position is out of bounds, behave as if the cursor
900 position were at the window margin. (Bug#10075)
901
df05a53c
CY
9022011-11-18 Chong Yidong <cyd@gnu.org>
903
904 * window.c (Fwindow_combination_limit): Make first argument
905 non-optional, since it is meaningless for live windows like the
906 selected window.
907
2071918e
DA
9082011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
909
910 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
911
b50a28de
SM
9122011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
913
914 * intervals.c: Fix grafting over the whole buffer (bug#10071).
915 (graft_intervals_into_buffer): Simplify.
916
015137db
EZ
9172011-11-18 Eli Zaretskii <eliz@gnu.org>
918
919 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
920 hash values of the two rows.
921 (copy_row_except_pointers): Preserve the used[] arrays and the
922 hash values of the two rows. (Bug#10035)
68c95424 923 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
924
925 * xdisp.c (row_hash): New function, body extracted from
926 compute_line_metrics.
927 (compute_line_metrics): Call row_hash, instead of computing the
928 hash code inline.
929
930 * dispnew.c (verify_row_hash): Call row_hash for computing the
931 hash code of a row, instead of duplicating code from xdisp.c.
932
933 * dispextern.h (row_hash): Add prototype.
934
a2addb04
TH
9352011-11-18 Tassilo Horn <tassilo@member.fsf.org>
936
937 * frame.c (delete_frame): Don't delete the terminal when the last
938 X frame is closed if emacs is built with GTK toolkit.
939
df85d315
JB
9402011-11-17 Juanma Barranquero <lekktu@gmail.com>
941
942 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
943
a0c2d0ae
MR
9442011-11-17 Martin Rudalics <rudalics@gmx.at>
945
946 * window.c (Vwindow_splits): Rename to
947 Vwindow_combination_resize. Suggested by Juri Linkov.
948 (Fsplit_window_internal): Use Vwindow_combination_resize instead
949 of Vwindow_splits.
950
58179cce
JB
9512011-11-16 Juanma Barranquero <lekktu@gmail.com>
952
7877f373
JB
953 * nsfns.m (Fns_font_name):
954 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 955
b6f67890
MR
9562011-11-16 Martin Rudalics <rudalics@gmx.at>
957
958 * window.h (window): Rename slot "nest" to "combination_limit".
959 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
960 (Fset_window_nest): Rename to Fset_window_combination_limit.
961 (Vwindow_nest): Rename to Vwindow_combination_limit.
962 (recombine_windows, make_parent_window, make_window)
963 (Fsplit_window_internal, saved_window)
964 (Fset_window_configuration, save_window_save): Rename all
965 occurrences of window_nest to window_combination_limit.
966
c7015153
JB
9672011-11-15 Juanma Barranquero <lekktu@gmail.com>
968
969 * image.c (imagemagick_load_image): Fix typo.
970
322ad6ec
EZ
9712011-11-14 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (display_line): Move the call to
974 highlight_trailing_whitespace before the call to
975 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
976 faces of all the glyphs to compute ROW's hash value.
977 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 978
f067b8ec
JB
9792011-11-14 Juanma Barranquero <lekktu@gmail.com>
980
981 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
982 just return (bug#10044).
983
1e5b2111
EZ
9842011-11-12 Eli Zaretskii <eliz@gnu.org>
985
7ef3cbd5
EZ
986 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
987 with user-defined heap size. Bump the default size of the temacs
988 heap to 27MB, to avoid memory warning when running temacs.
989 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
990
1e5b2111
EZ
991 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
992 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
993 (verify_row_hash) [XASSERTS]: New function.
994 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
995 that the hash value of glyph rows is correct.
1e5b2111 996
89d61221
MR
9972011-11-12 Martin Rudalics <rudalics@gmx.at>
998
999 * window.h (window): Remove splits slot.
1000 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1001 (Fdelete_other_windows_internal, make_parent_window)
1002 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1003 (Fset_window_configuration, save_window_save): Don't deal with
1004 split status of windows.
1005 (saved_window): Remove splits slot.
1006 (Vwindow_splits): Rewrite doc-string.
1007
97f18cc8
JD
10082011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1009
1010 * xfns.c (unwind_create_frame):
1011 * nsfns.m (unwind_create_frame):
1012 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1013 Vframe_list (Bug#9999).
1014
22a648b4
DA
10152011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1016
0b381c7e 1017 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1018
659afede
KH
10192011-11-11 Kenichi Handa <handa@m17n.org>
1020
1021 * callproc.c (Fcall_process): Set the member dst_multibyte of
1022 process_coding.
1023
9ac0394b
KH
10242011-11-11 Johan Bockgård <bojohan@gnu.org>
1025
1026 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1027 avoid a crash (bug#9496).
1028
2fbdc249
CY
10292011-11-09 Chong Yidong <cyd@gnu.org>
1030
1031 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1032 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1033
ac6b1f81
PE
10342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1037
09db192c
PE
10382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 Avoid some portability problems by eschewing 'extern inline' functions.
1041 The trivial performance wins aren't worth the portability hassles; see
1042 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1043 et seq.
1044 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1045 (window_box_width, window_box_left, window_box_left_offset)
1046 (window_box_right, window_box_right_offset): Undo previous change,
1047 by removing the "extern"s.
1048 * intervals.c (adjust_intervals_for_insertion)
1049 (adjust_intervals_for_deletion): Undo previous change,
1050 making these static again.
1051 (offset_intervals, temp_set_point_both, temp_set_point)
1052 (copy_intervals_to_string): No longer inline.
1053 * xdisp.c (window_text_bottom_y, window_box_width)
1054 (window_box_height, window_box_left_offset)
1055 (window_box_right_offset, window_box_left, window_box_right)
1056 (window_box): No longer inline.
1057
105216ed
CY
10582011-11-08 Chong Yidong <cyd@gnu.org>
1059
1060 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1061 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1062 Signal an error if not a live window.
105216ed
CY
1063 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1064 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1065
ae9e237f
JB
10662011-11-07 Juanma Barranquero <lekktu@gmail.com>
1067
1068 * lisp.h (syms_of_abbrev): Remove declaration.
1069 Reported by CHENG Gao <chenggao@royau.me>.
1070
c7aa8333
EZ
10712011-11-07 Eli Zaretskii <eliz@gnu.org>
1072
1073 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1074 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1075 of temacs in GUI mode.
1076
be7f5545
MR
10772011-11-07 Martin Rudalics <rudalics@gmx.at>
1078
1079 * window.h: Declare delete_all_child_windows instead of
1080 delete_all_subwindows.
1081 * window.c (Fwindow_nest, Fset_window_nest)
1082 (Fset_window_new_total, Fset_window_new_normal)
1083 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1084 (delete_all_subwindows): Rename to delete_all_child_windows.
1085 (Fdelete_other_windows_internal, Fset_window_configuration):
1086 Call delete_all_child_windows instead of delete_all_subwindows.
1087 * frame.c (delete_frame): Call delete_all_child_windows instead
1088 of delete_all_subwindows.
1089
ca78dc43
PE
10902011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1093 This is also needed for porting to any host where GC_MARK_STACK is
1094 not GC_MAKE_GCPROS_NOOPS.
1095 (which_symbols): Use it.
1096
a0241d01
KH
10972011-11-07 Kenichi Handa <handa@m17n.org>
1098
1099 * coding.c (coding_set_destination): Check coding->src_pos only
1100 when coding->src_object is a buffer (bug#9910).
1101
1102 * process.c (send_process): Set the member src_multibyte of coding
1103 to 0 (bug#9911) when sending a unibyte text.
1104
1105 * callproc.c (Fcall_process): Set the member src_multibyte of
1106 process_coding to 0 (bug#9912).
1107
a64bfdfa 11082011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1109
1110 * xmenu.c (cleanup_widget_value_tree): New function.
1111 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1112 calling free_menubar_widget_value_tree directly (Bug#9830).
1113
cb41b32a
PE
11142011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 Fix some portability problems with 'inline'.
1117 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1118 (window_box_width, window_box_left, window_box_left_offset)
1119 (window_box_right, window_box_right_offset): Declare extern.
1120 Otherwise, these inline functions do not conform to C99 and
1121 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1122 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1123 * intervals.c (adjust_intervals_for_insertion)
1124 (adjust_intervals_for_deletion): Now extern, because otherwise the
1125 extern inline functions 'offset_intervals' couldn't refer to it.
1126 (static_offset_intervals): Remove.
1127 (offset_intervals): Rewrite using the old contents of
1128 static_offset_intervals. The old version didn't conform to C99
1129 because an extern inline function contained a reference to an
1130 identifier with static linkage.
1131
b7041366
AS
11322011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1135 GC.
1136
88a37c4d
EZ
11372011-11-06 Eli Zaretskii <eliz@gnu.org>
1138
1139 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1140 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1141 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1142 return Qleft_to_right.
1143
49745b39
CY
11442011-11-06 Chong Yidong <cyd@gnu.org>
1145
1146 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1147 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1148 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1149 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1150 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1151 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1152 (Fwindow_vscroll): Doc fix.
1153 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1154 argument, since it makes no sense to pass a live window and for
1155 consistency with window-child.
1156
1f05cd82
CS
11572011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1158
1159 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1160 support MSVC.
1161
22610910
JR
11622011-11-05 Jason Rumney <jasonr@gnu.org>
1163
1164 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1165 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1166 fonts (Bug#6029).
1167 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1168 bitwise arithmetic preventing use of unicode-sip and non-truetype
1169 opentype fonts.
1170
a06776b2
EZ
11712011-11-05 Eli Zaretskii <eliz@gnu.org>
1172
3ad924ba
EZ
1173 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1174 "emacs"-only part.
1175
a06776b2
EZ
1176 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1177 initialization code to keep similarity to xfns.c after changes
1178 from 2011-11-05.
1179
c9e7db78
JD
11802011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1181
a97f8f3f
JD
1182 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1183 (unwind_create_frame): New function (Bug#9943).
1184 (Fx_create_frame): Restructure code to be more similar to the one in
1185 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1186 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1187 Move terminal->reference_count++ just before making the frame official
1188 (Bug#9943).
1189
1190 * nsterm.m (x_free_frame_resources): New function.
1191 (x_destroy_window): Move code to x_free_frame_resources.
1192
c9e7db78 1193 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1194 (Fx_create_frame, x_create_tip_frame):
1195 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1196 official. Move initialization of image_cache_refcount and
1197 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1198
a6fc3b5c
EZ
11992011-11-05 Eli Zaretskii <eliz@gnu.org>
1200
1201 Support MSVC build with newer versions of Visual Studio.
1202 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1203 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1204 nt/gmake.defs.
1205
1206 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1207 which are not supported by MSVC.
1208 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1209 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1210 bitfields.
1211 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1212 types in bitfields.
1213 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1214
1215 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1216
58179cce 12172011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1218
1219 Support MSVC build with newer versions of Visual Studio.
1220 * w32.c: Don't include w32api.h for MSVC.
1221 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1222
1223 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1224 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1225 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1226 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1227 e_* cousins.
1228 (alloca) [_MSC_VER]: Define to _alloca.
1229
1230 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1231
1232 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1233
a58c13ed
EZ
12342011-11-04 Eli Zaretskii <eliz@gnu.org>
1235
1236 * xdisp.c (note_mouse_highlight): If either of
1237 previous/next-single-property-change returns nil, treat that as
1238 the beginning or the end of the buffer. (Bug#9955)
1239
fe0b6370
JD
12402011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1241
a58c13ed 1242 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1243 label is not null (Bug#9951).
1244 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1245 may be NULL.
1246
89bd5ee1
EZ
12472011-11-04 Eli Zaretskii <eliz@gnu.org>
1248
1249 * window.c (Fwindow_body_size): Mention in the doc string that the
1250 return value is in frame's canonical units. (Bug#9949)
1251
84c3edb9
EZ
12522011-11-03 Eli Zaretskii <eliz@gnu.org>
1253
4e2fb5c7
EZ
1254 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1255
84c3edb9 1256 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1257 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1258 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1259
bc17a887
EZ
12602011-11-01 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1263 Don't stop backward scan on the continuation glyph, even though
1264 its CHARPOS is positive.
6d5eb5b0
SM
1265 (mouse_face_from_buffer_pos, note_mouse_highlight):
1266 Rename cover_string to disp_string.
bc17a887 1267
4ee88440
MR
12682011-11-01 Martin Rudalics <rudalics@gmx.at>
1269
1270 * window.c (temp_output_buffer_show): Don't use
1271 Vtemp_buffer_show_specifiers.
1272 (Vtemp_buffer_show_specifiers): Remove unused variable.
1273
c2ff3c02
EZ
12742011-10-30 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1277 past the beginning of the current glyph matrix.
1278
58179cce 12792011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1280
1281 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1282 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1283 HAVE_GTK3 (Bug#9869).
b77a6a7f 1284
3b574623
JD
1285 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1286 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1287
b77a6a7f
JD
1288 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1289
1290 * xterm.c: Declare x_handle_net_wm_state to return int.
1291 (handle_one_xevent): Check if we are iconified but don't have
1292 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1293 (get_current_wm_state): Return non-zero if not hidden,
1294 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1295 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1296 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1297 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1298
196e41e4
PE
12992011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1300
1301 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1302 so that this new function doesn't get optimized away by a
1303 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1304
021f2e1a
AS
13052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1306
1307 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1308
8b058d44
EZ
13092011-10-29 Eli Zaretskii <eliz@gnu.org>
1310
1311 Fix the `xbytecode' command.
1312 * .gdbinit (xprintbytestr): New command.
b50a28de 1313 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1314 (xbytecode): Print the byte-code string as well.
1315
4452fb80
EZ
13162011-10-29 Kim Storm <storm@cua.dk>
1317
8b058d44
EZ
1318 * alloc.c (which_symbols): New function.
1319
21b72067
AS
13202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1321
1322 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1323 line. (Bug#9903)
1324
83ed7b5c
GM
13252011-10-29 Glenn Morris <rgm@gnu.org>
1326
1327 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1328 Not clear what it was for, and it causes various bugs. (Bug#9839)
1329
5a7a728b
EZ
13302011-10-28 Eli Zaretskii <eliz@gnu.org>
1331
1332 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1333 possible random value that matches one of those tested as
1334 condition to clear the mouse face.
1335
d3d0842f
CY
13362011-10-28 Chong Yidong <cyd@gnu.org>
1337
1338 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1339
31b39d13
DN
13402011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1341
1342 * window.c (make_window): Initialize phys_cursor_on_p.
1343
9aba6043
SM
13442011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * lisp.h (struct Lisp_Symbol): Update comments.
1347
c20992f4
JB
13482011-10-28 Juanma Barranquero <lekktu@gmail.com>
1349
1350 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1351
db4f02f2
EZ
13522011-10-28 Eli Zaretskii <eliz@gnu.org>
1353
1354 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1355 <oslsachem@gmail.com> for helping to debug this.
1356
1357 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1358 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1359 (g_b_init_get_glyph_outline_w): New static variables.
1360 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1361 (GetGlyphOutlineW_Proc): New typedefs.
1362 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1363 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1364 New functions.
1365 (w32font_open_internal, compute_metrics):
1366 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1367 instead of calling the "wide" APIs directly.
1368
1369 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1370
1371 * w32.h (syms_of_w32font): Add prototype.
1372
87e68db4
JB
13732011-10-27 Juanma Barranquero <lekktu@gmail.com>
1374
1375 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1376 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1377 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1378 (Fmove_to_window_line): Doc fix.
1379
435c1d67
CY
13802011-10-27 Chong Yidong <cyd@gnu.org>
1381
1382 * process.c (make_process): Set gnutls_state to NULL.
1383
1384 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1385 non-NULL, regardless of GNUTLS_INITSTAGE.
1386 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1387 an error. Set process slots as soon as we allocate them.
1388
1389 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1390
9c6c6f49
CY
13912011-10-27 Chong Yidong <cyd@gnu.org>
1392
9aba6043
SM
1393 * gnutls.c (emacs_gnutls_deinit): New function.
1394 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1395 (Fgnutls_deinit, Fgnutls_boot): Use it.
1396
1397 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1398 (deactivate_process): Call emacs_gnutls_deinit.
1399
657d08d3
JB
14002011-10-27 Juanma Barranquero <lekktu@gmail.com>
1401
1402 * image.c (x_create_x_image_and_pixmap):
1403 * w32.c (sys_rename, w32_delayed_load):
1404 * w32font.c (fill_in_logfont):
1405 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1406
5430d399
JB
14072011-10-26 Juanma Barranquero <lekktu@gmail.com>
1408
1409 * w32fns.c (w32_default_color_map): New function,
1410 extracted from Fw32_default_color_map.
a7ef684b 1411 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1412
fe0055fa
PE
14132011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1416
e6346438
SM
14172011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * keyboard.c (test_undefined): New function (bug#9751).
1420 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1421
e112cc37
ET
14222011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1423
1424 * sysdep.c (init_sys_modes): Fix the check for the controlling
1425 terminal (Bug#6649).
1426
7b5d6677
EZ
14272011-10-20 Eli Zaretskii <eliz@gnu.org>
1428
1429 * dispextern.h (struct bidi_it): New member next_en_type.
1430
1431 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1432 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1433 current character, check also for next_en_type being WEAK_EN.
1434 (bidi_resolve_weak): Don't enter the expensive loop if the current
1435 position is before next_en_pos. Record the bidi type of the first
1436 non-ET, non-BN character we find, in addition to its position.
1437 (bidi_level_of_next_char): Invalidate next_en_type when
1438 next_en_pos is over-stepped.
1439
7da0b018
PE
14402011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1443 * editfns.c: Rewrite current-time-zone so that it invokes
1444 the equivalent of (format-time-string "%Z") to get the time zone name.
1445 This fixes a bug when the time zone name contains characters that
1446 need converting from the system time locale to Emacs internal format.
1447 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1448 that patch fixed format-time-string to do the conversion, but
1449 I forgot to fix current-time-zone.
1450 (format_time_string): New function, containing most of
1451 what Fformat_time_string used to contain.
1452 (Fformat_time_string): Rewrite in terms of format_time_string.
1453 This doesn't change this function's behavior.
1454 (current-time-zone): Rewrite to use format_time_string.
1455 This fixes the bug reported by Michael Schierl in
1456 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1457 Jason Rumney's 2007-06-07 change worked around this bug, but
1458 didn't fix it.
1459 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1460
8547b010
EZ
14612011-10-19 Eli Zaretskii <eliz@gnu.org>
1462
1463 * xdisp.c (start_display): If the character at POS is displayed
1464 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1465 (try_window_reusing_current_matrix): If a line ends in a display
1466 vector or the next line starts in a display vector, continue
1467 redrawing the window even though the character position of
1468 start_row was reached.
8547b010
EZ
1469 (Bug#9771, part 2)
1470
4e948d15
CY
14712011-10-18 Chong Yidong <cyd@gnu.org>
1472
1473 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1474 with nobreak-char-display too.
1475
4787455f
EZ
14762011-10-18 Eli Zaretskii <eliz@gnu.org>
1477
1478 Fix part 3 of bug#9771.
1479 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1480 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1481 non-neutral characters if the current character is a paragraph
1482 separator (a.k.a. Newline). This avoids running the same
1483 expensive loop twice, once when we consume the preceding newline
1484 and the other time when the line actually needs to be displayed.
1485 Avoid the loop when we see neutrals on the base embedding level
1486 following a character whose directionality is the same as the
1487 paragraph's. This avoids running the expensive loop when a line
1488 ends in a long sequence of neutrals, like control characters.
1489 Add assertion against STRONG_AL type. Slightly rearrange code
1490 that determines the type of a neutral given the first non-neutral
1491 that follows it.
1492 (bidi_level_of_next_char): Set next_en_pos to zero when
1493 invalidating its info.
1494
2c91f553
EZ
14952011-10-17 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xdisp.c (push_display_prop): Determine whether to record string
1498 or buffer position by IT->string, not by IT->method. Allow
1499 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1500 (move_it_vertically_backward): Don't look for character position
1501 immediately after the newline when in a continuation line.
1502 (Bug#9771, part 1)
2c91f553 1503
c7b08b0d
MR
15042011-10-15 Martin Rudalics <rudalics@gmx.at>
1505
1506 * window.c (coordinates_in_window): Rewrite and delabelize
1507 vertical border check. (Bug#5357) (Bug#9618)
1508
6b02f655
SM
15092011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1510
1511 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1512 errors in XSetWindowBorder (bug#9310).
1513
81d40c92
DA
15142011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1515
1516 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1517 avoid crash when xmalloc overrun checking is enabled.
1518
d4172c3b
EZ
15192011-10-13 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1522 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1523 cursor motion with <left> and <right> arrow keys.
1524
1525 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1526 some callers set that themselves.
1527
b00eea75
EZ
15282011-10-12 Eli Zaretskii <eliz@gnu.org>
1529
1530 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1531 display string and the previous row comes from the same string and
1532 is empty. (Bug#9739) (Bug#9738)
1533
8fe012c4
SM
15342011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1535
1536 * doc.c (get_doc_string): Encode file name (bug#9735).
1537
0074aef2
EZ
15382011-10-12 Eli Zaretskii <eliz@gnu.org>
1539
79beb178
EZ
1540 * bidi.c (bidi_level_of_next_char):
1541 * xdisp.c (get_visually_first_element): Remove old incorrect
1542 comments regarding the Unicode Line Separator character.
1543
0074aef2
EZ
1544 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1545
6e4b3fbe
DA
15462011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1547
1548 * alloc.c (Fgc_status): Do not access beyond zombies array
1549 boundary if nzombies > MAX_ZOMBIES.
1550 * alloc.c (dump_zombies): Add missing format specifier.
1551
0324f3af
PE
15522011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1553
b5525cac
PE
1554 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1555 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1556
0324f3af
PE
1557 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1558 Some packages use them to denote characters with modifiers.
1559
e9b5f888
AS
15602011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1561
1562 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1563 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1564 matching a pp-number. Rename parameter var to var1.
1565
127827c0
SM
15662011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1567
1568 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1569
c8fd3bd0
GM
15702011-10-08 Glenn Morris <rgm@gnu.org>
1571
1572 * callint.c (Fcall_interactively): Give a more explicit error for the
1573 'c' case with a non-character input. (Bug#8479)
1574
352ec8ff
EZ
15752011-10-08 Eli Zaretskii <eliz@gnu.org>
1576
03669ccb
EZ
1577 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1578 lines.
7061c986
EZ
1579 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1580 lines that are hscrolled on the left.
03669ccb 1581
352ec8ff
EZ
1582 * dispnew.c (buffer_posn_from_coords): Account for a possible
1583 presence of header-line. (Bug#4426)
1584
a66cfb1c
SM
15852011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1586
6b02f655
SM
1587 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1588 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1589
7c5ee88e
PE
15902011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1591
1592 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1593 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1594 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1595 this makes Emacs dump core during garbage collection on rare
1596 occasions. sizeof is obviously inferior to offsetof here, so
1597 stick with offsetof.
1598 (GC_POINTER_ALIGNMENT): New macro.
1599 (mark_memory): Omit 3rd (offset) arg; caller changed.
1600 Don't assume EMACS_INT alignment is the same as pointer alignment.
1601
df1bbe5b
SM
16022011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1603
1604 * keyboard.c (read_key_sequence_remapped): New var.
1605 (read_key_sequence): Compute remapping in the right buffer.
1606 (command_loop_1): Use read_key_sequence's remapping directly.
1607
51553db6
SM
16082011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1609
32c1fffd
SM
1610 * dired.c (file_name_completion): Don't expand file name.
1611 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1612 before checking file name handler.
1613
51553db6
SM
1614 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1615 they've been requested explicitly (bug#9591).
1616
b6bd1599 16172011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1618
1619 * keymap.c (Fsingle_key_description): Use make_specified_string
1620 instead of build_string to build string from push_key_description.
1621 (Bug#5193)
1622
f701dc2a
PE
16232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1624
4222c55d
PE
1625 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1626 This fixes a Y2038 bug on 64-bit hosts.
1627 * buffer.c (reset_buffer):
1628 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1629 (Fclear_buffer_auto_save_failure):
1630 Use 0, not -1, to represent an unset failure time, since time_t
1631 might not be signed.
1632
f701dc2a
PE
1633 Remove dependency on glibc malloc internals.
1634 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1635 Move back here from lisp.h, but with their new implementations.
1636 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1637 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1638 * charset.c (charset_table_init): New static var.
1639 (syms_of_charset): Use it instead of xmalloc. This removes a
1640 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1641 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1642 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1643 Move back to alloc.c.
1644 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1645 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1646
9ceebf39
JD
16472011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1648
1649 * nsterm.m (windowDidResize): Call x_set_window_size only when
1650 ns_in_resize is true. Otherwise set pixelwidth/height and
1651 call change_frame_size (Bug#9628).
1652
cb993c58
PE
16532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1654
3930c88b
PE
1655 Port --enable-checking=all to Fedora 14 x86-64.
1656 * charset.c (syms_of_charset): Also account for glibc malloc's
1657 internal overhead when calculating the initial malloc maximum.
1658
cb993c58
PE
1659 Port --enable-checking=all to Fedora 14 x86.
1660 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1661 Move to lisp.h.
1662 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1663 (overrun_check_realloc, overrun_check_free):
1664 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1665 That way, xmalloc returns a properly-aligned pointer even if
1666 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1667 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1668 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1669 into account when calculating the initial malloc maximum.
1670 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1671 Move here from alloc.c, so that charset.c can use it too.
1672 Properly align; the old code wasn't right for common 32-bit hosts
1673 when configured with --enable-checking=all.
1674 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1675 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1676
31bed486
EZ
16772011-09-29 Eli Zaretskii <eliz@gnu.org>
1678
04c70788 1679 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1680 use EDOM.
1681
fbcaa2f3
EZ
16822011-09-28 Eli Zaretskii <eliz@gnu.org>
1683
1684 * xdisp.c (compute_display_string_end): If there's no display
1685 string at CHARPOS, return -1.
1686
1687 * bidi.c (bidi_fetch_char): When compute_display_string_end
1688 returns a negative value, treat the character as a normal
1689 character not covered by a display string. (Bug#9624)
1690
a239d4e9
JB
16912011-09-28 Juanma Barranquero <lekktu@gmail.com>
1692
1693 * lread.c (Fread_from_string): Fix typo in docstring.
1694
88652fd5
EZ
16952011-09-27 Eli Zaretskii <eliz@gnu.org>
1696
1697 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1698 newline, reseat the iterator instead of bidi-iterating there one
1699 character at a time. (Bug#9610)
32c1fffd
SM
1700 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1701 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1702
ed497dd4
AS
17032011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1704
1705 * lread.c (readevalloop): Use correct code for NBSP.
1706 (read1): Likewise. (Bug#9608)
1707
b2bf61aa
MA
17082011-09-25 Michael Albinus <michael.albinus@gmx.de>
1709
1710 * dbusbind.c (Fdbus_register_signal): When service is not
1711 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1712
32bbb17c
GM
17132011-09-25 Glenn Morris <rgm@gnu.org>
1714
1715 * buffer.c (truncate-lines): Doc fix.
1716
94e0933e
CY
17172011-09-24 Chong Yidong <cyd@stupidchicken.com>
1718
1719 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1720 (Fset_window_next_buffers): Doc fix.
1721
cddde921
GM
17222011-09-24 Glenn Morris <rgm@gnu.org>
1723
1724 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1725
1260aef1
PE
17262011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1727
25b4bfa0
PE
1728 Fix minor problems found by static checking.
1729 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1730 * indent.c (Fvertical_motion): Fix == vs = typo.
1731
e3cbd34b
EZ
17322011-09-24 Eli Zaretskii <eliz@gnu.org>
1733
a66cfb1c
SM
1734 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1735 Default value is now t. Doc fix.
6bf7006f 1736
e3cbd34b 1737 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1738 logic when moving up, not only when moving down. Fix the
e3cbd34b 1739 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1740 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1741
1742 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1743 CHARPOS is covered by a display string which includes newlines.
1744 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1745 is covered by a display string with embedded newlines.
1746
a3de0cbd
MA
17472011-09-24 Michael Albinus <michael.albinus@gmx.de>
1748
1749 * dbusbind.c (Fdbus_register_signal): Add match rule to
1750 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1751 (Fdbus_register_method, Vdbus_registered_objects_table):
1752 Fix docstring.
a3de0cbd 1753
b260039d
JM
17542011-09-24 Jim Meyering <meyering@redhat.com>
1755
32c1fffd 1756 do not ignore write error for any output size
b260039d
JM
1757 The previous change was incomplete.
1758 While it makes emacs --batch detect the vast majority of stdout
1759 write failures, errors were still ignored whenever the output size is
1760 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1761 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1762 && echo FAIL: ignored write error
1763 FAIL: ignored write error
1764 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1765 && echo FAIL: ignored write error
1766 FAIL: ignored write error
1767 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1768
8eca8a7c
AS
17692011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1770
1771 * emacs.c (Fkill_emacs): In noninteractive mode exit
1772 non-successfully if a write error occurred on stdout. (Bug#9574)
1773
3341db62
EZ
17742011-09-21 Eli Zaretskii <eliz@gnu.org>
1775
1776 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1777 the xassert test.
1778
1779 * dispextern.h (struct it): Update the comment documenting what
1780 can it->OBJECT be.
1781
8c203dbf
EZ
17822011-09-20 Eli Zaretskii <eliz@gnu.org>
1783
1784 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1785 a display string, extend search for cursor position to end of row.
1786 (find_row_edges): If the row ends in a newline from a display
1787 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1788 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1789 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1790 non-empty line. Fixes confusing cursor motion with arrow keys at
1791 the beginning of a line that starts with whitespace.
8c203dbf 1792
a4824228
LMI
17932011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1794
1795 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1796 (bug#9493).
1797
33ed493b
CY
17982011-09-18 Chong Yidong <cyd@stupidchicken.com>
1799
1800 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1801 boolean (Bug#9154).
1802
56cd55c8
EZ
18032011-09-18 Eli Zaretskii <eliz@gnu.org>
1804
1805 * xdisp.c (display_line): Record maximum and minimum buffer
1806 positions even if no glyphs were produced (e.g., by a zero-width
1807 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1808 buffer positions that will be removed from the glyph row because
1809 they don't fit.
c02dcedf
EZ
1810 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1811 column is beyond frame width: don't subtract 1 "pixel" when
1812 computing width of the stretch.
3e62b7e0
EZ
1813 (reseat_at_next_visible_line_start): Undo the change made on
1814 2011-09-17 that saved paragraph information and restored it after
1815 the call to `reseat'. (Bug#9545)
56cd55c8 1816
5ed99d36 18172011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1818
1819 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1820 and turn window cursor on if cleared (Bug#9415).
1821
5ed99d36 18222011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1823
1824 * search.c (boyer_moore): Take unibyte characters from pattern
1825 literally. (Bug#9458)
1826
9bade7b2
EZ
18272011-09-18 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1830
e5e9d610
PE
18312011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1832
87e4427a
PE
1833 Fix minor problem found by static checking.
1834 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1835 initialized, to pacify gcc -Wuninitialized.
1836
e5e9d610
PE
1837 * fileio.c: Report proper errno when syscall falls.
1838 (Finsert_file_contents): Save and restore errno,
1839 so that report_file_error outputs the correct diagnostic.
1840 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1841
a1674f0b
EZ
18422011-09-18 Eli Zaretskii <eliz@gnu.org>
1843
1844 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1845
fbfb6dd4
EZ
18462011-09-17 Eli Zaretskii <eliz@gnu.org>
1847
1848 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1849 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1850
bb187662
EZ
18512011-09-17 Eli Zaretskii <eliz@gnu.org>
1852
1137e8b8 1853 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1854 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1855
1856 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1857 (bidi_find_paragraph_start): Search back for paragraph beginning
1858 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1859 (bidi_move_to_visually_next): Only trigger paragraph-related
1860 computations when the last character is a newline or at EOB, not
1861 just any NEUTRAL_B. (Bug#9470)
1862
bb187662
EZ
1863 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1864 truncated lines if point is covered by a display string. (Bug#9524)
1865
2e621251
PE
18662011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1869 (cons_to_x_long): New function.
1870 (lisp_data_to_selection_data): Use it. Correct the test for
1871 short-versus-long data; it was negated. Break out of vector
1872 loop, for efficiency, when a long datum is discovered.
1873
91a15bc6
SM
18742011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1875
1876 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1877
b41c3a35
EZ
18782011-09-16 Eli Zaretskii <eliz@gnu.org>
1879
1880 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1881 GCC PR/17406) by declaring this function with external scope.
1882
7812ba2d
PE
18832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1884
1885 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1886 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1887
cf7edc2a
AS
18882011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1889
1890 * editfns.c (Fformat): Correctly handle text properties on "%%".
1891
bd01620e
EZ
18922011-09-15 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xterm.c (x_draw_composite_glyph_string_foreground):
1895 * w32term.c (x_draw_composite_glyph_string_foreground):
1896 * term.c (encode_terminal_code):
1897 * composite.c (composition_update_it, get_composition_id):
1898 * xdisp.c (get_next_display_element)
1899 (fill_composite_glyph_string): Add comments about special meaning
1900 of TAB characters in a composition.
1901
a02719a3
PE
19022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1905 This occurs when processing a multibyte format.
1906 Problem reported by Wolfgang Jenker.
a02719a3 1907
72589a3c
JB
19082011-09-15 Johan Bockgård <bojohan@gnu.org>
1909
1910 * xdisp.c (try_cursor_movement): Only check for exact match if
1911 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1912
1c14176c
PE
19132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 Remove unused external symbols.
1916 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1917 * xdisp.c (calc_pixel_width_or_height): Now static.
1918 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1919 * indent.c (check_display_width):
1920 * w32term.c: Fix comment to match code.
1921 * xterm.c, xterm.h (x_catching_errors): Remove.
1922
d2eea5b5
PE
19232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 * xselect.c: Use signed conversions more consistently (Bug#9498).
1926 (selection_data_to_lisp_data): Assume incoming selection data are
1927 signed integers, not unsigned. This is to be consistent with
1928 outgoing selection data, which was modified to use signed integers
1929 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1930 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1931 expects long, not unsigned long.
1932
46888499
EZ
19332011-09-14 Eli Zaretskii <eliz@gnu.org>
1934
1935 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1936 computation of loop end. Reported by Johan Bockgård
1937 <bojohan@gnu.org>.
1938
ef8ef9fb
CY
19392011-09-13 Chong Yidong <cyd@stupidchicken.com>
1940
1941 * frame.c (Fother_visible_frames_p): Function deleted.
1942
fa819fed
EZ
19432011-09-12 Eli Zaretskii <eliz@gnu.org>
1944
1945 * indent.c (compute_motion): Process display vector front to back
1946 rather than the other way around. (Bug#2496)
1947
2ba8e008
SM
19482011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1949
1950 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1951
20f53c69
CY
19522011-09-11 Chong Yidong <cyd@stupidchicken.com>
1953
1954 * minibuf.c (Fread_from_minibuffer): Doc fix.
1955
d562d7a4
EZ
19562011-09-11 Eli Zaretskii <eliz@gnu.org>
1957
1958 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1959 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1960
1c4d7f3d
LMI
19612011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962
1963 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1964 value for non-existent files.
1965
b885bf36
EZ
19662011-09-11 Eli Zaretskii <eliz@gnu.org>
1967
1968 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1969 set its "size" to -1. This will set the modtime_size field of
1970 the corresponding buffer to -1, which is what
1971 verify-visited-file-modtime expects for files that do not exist.
1972 (Bug#9139)
1973
6612f0bf
PE
19742011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1977 here ...
1978 * lisp.h: ... from here. push_key_description is no longer
1979 defined in keyboard.c, so its declaration should not be in
1980 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1981 logically belongs with push_key_description.
1982
dfb3f755
PE
19832011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 * buffer.h: Include <sys/types.h> instead of <time.h>.
1986 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1987 Problem reported by Herbert J. Skuhra.
1988
3134906c
LMI
19892011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1990
1991 * xml.c (parse_region): Make the parsing work for
1992 non-comment-starting XML files again (bug#9144).
1993
8d903f4e
AS
19942011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1995
1996 * image.c (gif_load): Fix calculation of bottom and right corner.
1997 (Bug#9468)
1998
80ad64f4
EZ
19992011-09-10 Eli Zaretskii <eliz@gnu.org>
2000
2001 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2002 redisplay in small windows.
2003
208a048d
EZ
20042011-09-09 Eli Zaretskii <eliz@gnu.org>
2005
2006 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2007
9b1c252e
MR
20082011-09-08 Martin Rudalics <rudalics@gmx.at>
2009
2010 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2011 Operate on live windows only.
2012
2949f33b
JB
20132011-09-08 Juanma Barranquero <lekktu@gmail.com>
2014
2015 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2016
e08dcafd
EZ
20172011-09-07 Eli Zaretskii <eliz@gnu.org>
2018
2019 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2020 only under bidi iteration.
2021
115b96bd
JD
20222011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2023
2024 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2025
c8199d0f
PE
20262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2029 Without this fix, the command to link temacs failed due to an
2030 undefined symbol __builtin_isnan. This is because
2031 /usr/include/iso/math_c99.h #defines isnan(x) to
2032 __builtin_isnan(x), but the bundled gcc, which identifies itself
2033 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2034 a __builtin_isnan.
2035 * floatfns.c (isnan): #undef, and then #define to a clone of
2036 what's in data.c.
2037 (Fisnan): Always define, since it's always available now.
2038 (syms_of_floatfns): Always define isnan at the Lisp level.
2039
e39b275c 20402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2041
2042 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2043
b2db44d9 20442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2045
f4af5137 2046 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2047 The previous code assumed that file offsets (off_t values) fit in
2048 EMACS_INT variables, which is not true on typical 32-bit hosts.
2049 The code messed up by falsely reporting buffer overflow in cases
2050 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2051 when "big" contains more than 2**29 bytes, even though this
2052 inserts just one byte and does not overflow the buffer.
2053 (Finsert_file_contents): Store file offsets as off_t
2054 values, not as EMACS_INT values. Check for overflow when
2055 converting between EMACS_INT and off_t. When checking for
2056 buffer overflow or for overlap, take the offsets into account.
2057 Don't use EMACS_INT for small values where int suffices.
2058 When checking for overlap, fix a typo: ZV was used where
2059 ZV_BYTE was intended.
2060 (Fwrite_region): Don't assume off_t fits into 'long'.
2061 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2062
ecfc0a49
MA
20632011-09-05 Michael Albinus <michael.albinus@gmx.de>
2064
2065 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2066
6511acf2 20672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2068
0999621a 2069 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2070
2071 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2072 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2073 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2074 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2075 (modify_event_symbol): Do not assume that the length of
2076 name_alist_or_stem is safe to alloca and fits in int.
2077 (Fexecute_extended_command): Likewise for function name and binding.
2078 (Frecursion_depth): Wrap around reliably on integer overflow.
2079 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2080 since some callers pass EMACS_INT values.
2081 (Fsingle_key_description): Don't crash if symbol name contains more
2082 than MAX_ALLOCA bytes.
2083 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2084 (get_minibuffer): Arg is now EMACS_INT, not int.
2085 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2086 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2087 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2088
2be7d702
PE
2089 * dbusbind.c (signature_cat): New function.
2090 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2091 Do not overrun buffer; instead, report string overflow.
2092
9d1df220
PE
2093 * dispnew.c (add_window_display_history): Don't overrun buffer.
2094 Truncate instead; this is OK since it's just a log.
2095
33ef5c64
PE
2096 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2097 even if the time zone offset is outlandishly large.
2098 Don't mishandle offset == INT_MIN.
2099
66c6fdd5
PE
2100 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2101 when creating daemon; the previous buffer-overflow check was incorrect.
2102
d749b01b
PE
2103 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2104 which has the guts of the old verror function.
2105
b5cd1905
PE
2106 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2107 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2108
6e1a67fb
PE
2109 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2110 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2111 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2112 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2113 length of string rather than counting it via multiple sprintfs;
2114 that's simpler and more reliable.
c21721cc
PE
2115 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2116 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2117 sprintf, in case result does not fit in int.
2118
c57b67fc
PE
2119 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2120 (fontset_from_font): Print it.
2121
8a401434
PE
2122 * frame.c (tty_frame_count): Now printmax_t, not int.
2123 (make_terminal_frame, set_term_frame_name): Print it.
2124 (x_report_frame_params): In X, window IDs are unsigned long,
2125 not signed long, so print them as unsigned.
2126 (validate_x_resource_name): Check for implausibly long names,
2127 and don't assume name length fits in 'int'.
2128 (x_get_resource_string): Don't blindly alloca invocation name;
2129 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2130 not fit in int.
2131
6e1a67fb
PE
2132 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2133 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2134 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2135
0df02bf3
PE
2136 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2137 Use esprintf, not sprintf, in case result does not fit in int.
2138
48e30793
PE
2139 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2140 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2141 it as a large positive number.
2142 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2143 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2144
a66ff6d8
PE
2145 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2146 in case result does not fit in int.
2147
aca216ff
PE
2148 * print.c (float_to_string): Detect width overflow more reliably.
2149 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2150 buffer overrun. Don't assume list length fits in 'int'. Treat
2151 print length of 0 as 0, not as infinity; to be consistent with other
2152 uses of print length in this function. Don't overflow print length
2153 index. Don't assume hash table size fits in 'long', or that
2154 vectorlike size fits in 'unsigned long'.
2155
31c286f7
PE
2156 * process.c (make_process): Use printmax_t, not int, to format
2157 process-name gensyms.
2158
55e5faa1
PE
2159 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2160
80f2e268
PE
2161 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2162 to avoid potential buffer overrun.
2163
670741ab
PE
2164 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2165 if X resource line is longer than 512 bytes.
2166
b7163a50
PE
2167 * xfns.c (x_window): Make sprintf buffer a bit bigger
2168 to avoid potential buffer overrun.
2169
ae58ff1f
PE
2170 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2171
c43c8a6a
PE
2172 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2173
3f8236f4
PE
21742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2175
53e9fe90 2176 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2177 Without these, Emacs silently mishandles large integers sometimes.
2178 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2179 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2180
6511acf2
PE
2181 * xdisp.c (try_window_id): Check Emacs fixnum range before
2182 converting to 'int'.
806add1d 2183
6511acf2 2184 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2185 Check that an Emacs fixnum is in range before assigning it to 'int'.
2186 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2187 values converted from Emacs fixnums.
2188 (Frecenter): Don't wrap around a line count if it is out of 'int'
2189 range; instead, treat it as an extreme value.
2190 (Fset_window_configuration, compare_window_configurations):
2191 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2192
6511acf2
PE
2193 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2194 that can exceed INT_MAX. Check that EMACS_INT value is in range
2195 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2196 (match_limit): Don't assume that a fixnum can fit in 'int'.
2197
6511acf2 2198 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2199 exceed INT_MAX.
2200
6511acf2 2201 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2202 (Fvertical_motion): Don't wrap around LINES values that don't fit
2203 in 'int'. Instead, treat them as extreme values. This is good
2204 enough for windows, which can't have more than INT_MAX lines anyway.
2205
fcb901a7
LMI
22062011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2207
0f2f6b6d
LMI
2208 * Require libxml/parser.h to avoid compilation warning.
2209
fcb901a7
LMI
2210 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2211
2212 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2213 since this reportedly can destroy thread storage.
2214
6e20a0d4
CY
22152011-08-30 Chong Yidong <cyd@stupidchicken.com>
2216
2217 * syntax.c (find_defun_start): Update all cache variables if
2218 exiting early (Bug#9401).
2219
148ae00e
EZ
22202011-08-30 Eli Zaretskii <eliz@gnu.org>
2221
f6cfbd8f
EZ
2222 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2223
148ae00e
EZ
2224 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2225 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2226 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2227
2228 * term.c (tty_append_glyph): New function.
2229 (produce_stretch_glyph): Static function and its prototype deleted.
2230
a66cfb1c
SM
2231 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2232 Add prototypes.
148ae00e 2233
c4a07a4c
PE
22342011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2237 when checking :margin (Bug#9390).
2238 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2239 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2240 so that the name doesn't mislead. All uses changed.
2241
6bc8cd65
JB
22422011-08-28 Johan Bockgård <bojohan@gnu.org>
2243
2244 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2245 set_tty_hooks.
2246
dca4927e
EZ
22472011-08-27 Eli Zaretskii <eliz@gnu.org>
2248
2249 * xdisp.c (move_it_to): Don't bail out early when reaching
2250 position beyond to_charpos, if we are scanning backwards.
2251 (move_it_vertically_backward): When DY == 0, make sure we get to
2252 the first character in the line after the newline.
2253
f2cad773
PE
22542011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2257 (ccl_driver): Do not generate an out-of-range pointer.
2258 (Fccl_execute_on_string): Remove unnecessary check for
2259 integer overflow, noted by Stefan Monnier in
2260 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2261 Remove a FIXME that didn't need fixing.
2262 Simplify the newly-introduced buffer reallocation code.
2263
0cae2cdb
JB
22642011-08-27 Juanma Barranquero <lekktu@gmail.com>
2265
2266 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2267
5fc295a4 22682011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2269
70c60eb2 2270 Integer and memory overflow issues (Bug#9196).
726e0ab1 2271
d31850da
PE
2272 * doc.c (get_doc_string): Rework so that
2273 get_doc_string_buffer_size is the actual buffer size, rather than
2274 being 1 less than the actual buffer size; this makes xpalloc more
2275 convenient.
2276
a69fbedb
PE
2277 * image.c (x_allocate_bitmap_record, cache_image):
2278 * xselect.c (Fx_register_dnd_atom):
2279 Simplify previous changes by using xpalloc.
2280
fe5c5d37
PE
2281 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2282 since either will do and ptrdiff_t is convenient with xpalloc.
2283
0065d054
PE
2284 * charset.c (charset_table_size)
2285 (struct charset_sort_data.priority): Now ptrdiff_t.
2286 (charset_compare): Don't overflow if priorities differ greatly.
2287 (Fsort_charsets): Don't assume list length fits in int.
2288 Check for size-calculation overflow when allocating sort data.
2289 (syms_of_charset): Allocate an initial charset table that is
2290 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2291
2292 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2293
2294 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2295 The actual value is always <= INT_MAX, and leaving it unsigned made
2296 overflow checking harder.
2297
2298 * dispextern.h (struct glyph_matrix.rows_allocated)
2299 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2300 with xpalloc. The values are still always <= INT_MAX.
2301
2302 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2303
2304 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2305 (SAFE_NALLOCA): New macro.
2306
2307 * region-cache.c (struct boundary.pos, find_cache_boundary)
2308 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2309 (set_cache_region, invalidate_region_cache)
2310 (revalidate_region_cache, know_region_cache, region_cache_forward)
2311 (region_cache_backward, pp_cache):
2312 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2313 so that ptrdiff_t * can be passed to xpalloc.
2314 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2315 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2316 (pp_cache): Don't assume cache_len fits in int.
2317 * region-cache.h: Adjust extern decls to match.
2318
2319 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2320 EMACS_INT, since either will do, for xpalloc.
2321
2322 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2323 (xnmalloc, xnrealloc, xpalloc): New functions.
2324
726e0ab1
PE
2325 * bidi.c (bidi_shelve_header_size): New constant.
2326 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2327 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2328
51f30bc5 2329 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2330 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2331 (overlay_strings):
2332 Don't update size of array until after memory allocation succeeds,
2333 because xmalloc/xrealloc may not return.
0065d054
PE
2334 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2335 now that we have proper integer overflow checking.
2336 (record_overlay_string, overlay_strings): Catch overflows when
2337 calculating size of overlay_str_buf.
726e0ab1 2338
0065d054
PE
2339 * callproc.c (Fcall_process): Check for size overflow when
2340 calculating size of args2.
2341 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2342 Normally we prefer signed values, but sticking with ptrdiff_t would
2343 require adding more-complicated checks.
726e0ab1
PE
2344
2345 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2346 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2347 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2348 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2349
2350 * character.c (Fstring): Check for size-calculation overflow.
2351
2352 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2353 unnecessary integer overflow. Check for size overflow.
2354 (encode_coding_object): Don't update size until xmalloc succeeds.
2355
2356 * composite.c (get_composition_id): Check for overflow in glyph
2357 length calculations.
2358
2359 Integer and memory overflow fixes for display code.
2360 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2361 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2362 (scrolling_window): Check for overflow in size calculations.
2363 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2364 Don't assume glyph table len fits in int.
2365 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2366 (row_table_size): Now ptrdiff_t, not int.
2367 (scrolling_window): Avoid overflow in size calculations.
2368 Don't update size until allocation succeeds.
2369 * fns.c (concat): Check for overflow in size calculations.
2370 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2371 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2372 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2373
2374 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2375 (get_doc_string): Check for size calculation overflow.
2376 Don't update size until allocation succeeds.
2377 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2378 EMACS_INT, where ptrdiff_t will do.
2379 (Fsubstitute_command_keys): Check for string overflow.
2380
2381 * editfns.c (set_time_zone_rule): Don't assume environment length
2382 fits in int.
2383 (message_length): Now ptrdiff_t, not int.
2384 (Fmessage_box): Don't update size until allocation succeeds.
2385 Don't assume message length fits in int.
2386 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2387
0065d054
PE
2388 * emacs.c (main): Do not reallocate argv, since there is a null at
2389 the end that can be overwritten, and this way there's no need to
2390 worry about size-calculation overflow.
2391 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2392
2393 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2394 alloc succeeds.
2395 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2396
2397 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2398 (x_set_scroll_bar_width, x_figure_window_size):
2399 Check for integer overflow.
2400 (x_set_alpha): Do not assume XINT fits in int.
2401
2402 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2403 This is for the members text_lines, text_cols, total_lines, total_cols,
2404 where the system imposes an 'int' limit.
2405
2406 * fringe.c (Fdefine_fringe_bitmap):
2407 Don't update size until alloc works.
2408
2409 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2410 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2411
2412 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2413 Check for size-calculation overflow.
2414 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2415 do, as we prefer signed integers.
2416 (id_to_widget.max_size, id_to_widget.used)
2417 (xg_store_widget_in_map, xg_remove_widget_from_map)
2418 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2419 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2420 Use and return ptrdiff_t, not int.
2421 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2422 * gtkutil.h: Change prototypes to match the above.
2423
2424 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2425 are duplicate now that they've been promoted to lisp.h.
2426 (x_allocate_bitmap_record, x_alloc_image_color)
2427 (make_image_cache, cache_image, xpm_load):
2428 Don't update size until alloc is done.
2429 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2430 (x_detect_edges):
3256efce 2431 Check for size calculation overflow.
726e0ab1
PE
2432 (ct_colors_allocated_max): New constant.
2433 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2434 overflow.
3256efce 2435
726e0ab1
PE
2436 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2437 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2438 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2439 Use ptrdiff_t, not int, to count maps.
2440 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2441 calculations. Don't update size until allocation succeeds.
2442 Redo calculations to avoid overflow.
726e0ab1
PE
2443 * keyboard.h: Change prototypes to match the above.
2444
2445 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2446 to count maps.
2447 (current_minor_maps): Check for size calculation overflow.
2448 * keymap.h: Change prototypes to match the above.
2449
2450 * lread.c (read1, init_obarray): Don't update size until alloc done.
2451
2452 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2453 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2454
726e0ab1
PE
2455 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2456 Now ptrdiff_t, not int.
2457 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2458 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2459
2460 * process.c (Fnetwork_interface_list): Check for overflow
2461 in size calculation.
2462
2463 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2464
2465 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2466 overflow. Don't bother calling xmalloc when xrealloc will do.
2467
2468 * search.c (Freplace_match): Check for size calculation overflow.
2469 (Fset_match_data): Don't assume list lengths fit in 'int'.
2470
2471 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2472 for command line length. Do not attempt to address one before the
2473 beginning of an array, as that's not portable.
2474
2475 * term.c (max_frame_lines): Remove; unused.
2476 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2477 not int.
2478 (encode_terminal_code, calculate_costs): Check for size
2479 calculation overflow.
2480 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2481 table lengths and related sizes. Don't update size until alloc
2482 done. Redo calculations to avoid overflow.
2483 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2484
2485 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2486 subtracting pointers.
2487 (gobble_line): Check for overflow more carefully. Don't update size
2488 until alloc done.
2489
2490 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2491 Don't update size until alloc done.
2492 Redo size calculations to avoid overflow.
2493 Check for size calculation overflow.
0065d054 2494 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2495
2496 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2497 Use ptrdiff_t, not int, for sizes.
2498 (store_mode_line_noprop_char): Don't update size until alloc done.
2499
0065d054
PE
2500 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2501 Use ptrdiff_t, not int, for sizes.
2502 (Finternal_make_lisp_face, cache_face):
2503 Check for size calculation overflow.
2504 (cache_face): Treat size calculation overflows as if they were
2505 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2506
2507 * xfns.c (x_encode_text, x_set_name_internal)
2508 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2509 sizes, since they can exceed INT_MAX in size. Check for size
2510 calculation overflow.
2511
0065d054
PE
2512 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2513 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2514 Don't update size until alloc done.
2515
0065d054 2516 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2517 as sprintf is limited to int lengths.
1d526e2f 2518
252c5ee1
PE
2519 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2520 (X_LONG_MIN): New macros.
864d7ce7
PE
2521 Use them to make the following changes clearer.
2522 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2523 This change doesn't affect the value now, but it may help remind
2524 future maintainers not to raise the value too much later.
2525 (SELECTION_QUANTUM): Remove, replacing with ...
2526 (selection_quantum): ... new function, which avoids overflow.
2527 All uses changed.
2528 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2529 assumption that selection length fits in 'int'.
2530 (x_reply_selection_request, x_handle_selection_request)
2531 (x_get_window_property, receive_incremental_selection)
2532 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2533 (lisp_data_to_selection_data, clean_local_selection_data):
2534 Use ptrdiff_t, not int, to record length of selection.
2535 (x_reply_selection_request, x_get_window_property)
2536 (receive_incremental_selection, x_property_data_to_lisp):
2537 Redo calculations to avoid overflow.
2538 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2539 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2540 something.
2541 (x_get_window_property, receive_incremental_selection)
2542 (lisp_data_to_selection_data, x_property_data_to_lisp):
2543 Check for size-calculation overflow.
2544 (x_get_window_property, receive_incremental_selection)
2545 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2546 Don't store size until memory allocation succeeds.
2547 (x_get_window_property): Plug memory leak on memory exhaustion.
2548 Don't double-block input; malloc is safe here. Don't assume 2**34
2549 - 4 fits in unsigned long. Add an xassert to check
2550 XGetWindowProperty overflow. Be more careful about overflow
2551 calculations, and distinguish size from memory overflow better.
2552 (receive_incremental_selection): When tracing, don't assume
2553 unsigned int is less than INT_MAX.
2554 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2555 harmful) conversions of unsigned short to int.
2556 (lisp_data_to_selection_data): Don't assume that integers
2557 in the range -65535 through -1 fit in an X unsigned short.
2558 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2559 result parameters unless successful. Rely on cons_to_unsigned
2560 to report problems with elements; the old code wasn't right anyway.
2561 (x_check_property_data): Check for int overflow; we cannot use
2562 a wider type due to X limits.
2563 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2564
726e0ab1 2565 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2566
0065d054
PE
2567 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2568 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2569 (x_color_cells): Don't store size until memory allocation succeeds.
2570 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2571 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2572 (x_term_init): Don't assume length fits in int (sprintf is limited
2573 to int size).
bc18e09d 2574
ebfa62c0
PE
2575 Use ptrdiff_t for composition IDs.
2576 * character.c (lisp_string_width):
2577 * composite.c (composition_table_size, n_compositions)
2578 (get_composition_id, composition_gstring_from_id):
2579 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2580 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2581 * window.c (Frecenter):
2582 Use ptrdiff_t, not int, for composition IDs.
2583 * composite.c (get_composition_id): Check for integer overflow.
2584 * composite.h: Adjust prototypes to match the above changes.
2585
d3411f89
PE
2586 Use ptrdiff_t for hash table indexes.
2587 * category.c (hash_get_category_set):
2588 * ccl.c (ccl_driver):
2589 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2590 * coding.c (coding_system_charset_list, detect_coding_system):
2591 * coding.h (struct coding_system.id):
2592 * composite.c (get_composition_id, gstring_lookup_cache):
2593 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2594 * image.c (xpm_get_color_table_h):
2595 * lisp.h (hash_lookup, hash_put):
2596 * minibuf.c (Ftest_completion):
2597 Use ptrdiff_t for hash table indexes, not int (which is too
2598 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2599 32-bit --with-wide-int hosts).
2600
e097a6fa
PE
2601 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2602 Add a FIXME comment about memory leaks.
2603 (syms_of_charset): Don't assume xmalloc returns.
2604
5637687f
PE
2605 Don't assume that stated character widths fit in int.
2606 * character.c (Fchar_width, c_string_width, lisp_string_width):
2607 * character.h (CHAR_WIDTH):
2608 * indent.c (MULTIBYTE_BYTES_WIDTH):
2609 Use sanitize_char_width to avoid undefined and/or bad behavior
2610 with outlandish widths.
a66cfb1c 2611 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2612 now that we have two such functions. All uses changed.
2613 (sanitize_char_width): New inline function.
2614
a2271ba2
PE
2615 Don't assume that tab-width fits in int.
2616 * character.h (sanitize_width): New inline function.
2617 (SANE_TAB_WIDTH): New macro.
2618 (ASCII_CHAR_WIDTH): Use it.
2619 * indent.c (sane_tab_width): Remove. All uses replaced by
2620 SANE_TAB_WIDTH (current_buffer).
2621 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2622
18c52557
PE
2623 * fileio.c: Integer overflow issues with file modes.
2624 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2625
caeeedc1
PE
2626 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2627 Remove unreachable code.
2628 (read_hex, load_charset_map_from_file): Check for integer overflow.
2629
6df6ae42 2630 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2631 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2632 (x_send_scroll_bar_event): Likewise. Check that the size does not
2633 exceed limits imposed by XClientMessageEvent, as well as the usual
2634 ptrdiff_t and size_t limits.
2635
b13995db
PE
2636 * keyboard.c: Overflow, signedness and related fixes.
2637 (make_lispy_movement): Use same integer type in forward decl
2638 that is used in the definition.
2639 (read_key_sequence, keyremap_step):
2640 Change bufsize argument back to int, undoing my 2011-03-30 change.
2641 We prefer signed types, and int is wide enough here.
2642 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2643 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2644 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2645 length, not size_t. Use ptrdiff_t for index, not int.
2646 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2647 possibility of integer overflow.
2648
13464394
PE
2649 Overflow, signedness and related fixes for images.
2650
2651 * dispextern.h (struct it.stack[0].u.image.image_id)
2652 (struct_it.image_id, struct image.id, struct image_cache.size)
2653 (struct image_cache.used, struct image_cache.ref_count):
2654 * gtkutil.c (update_frame_tool_bar):
2655 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2656 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2657 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2658 * nsmenu.m (update_frame_tool_bar):
2659 * xdisp.c (calc_pixel_width_or_height):
2660 * xfns.c (image_cache_refcount):
2661 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2662 on typical 64-bit hosts.
2663
2664 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2665 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2666 Omit unnecessary casts to int.
2667 (parse_image_spec): Check that integers fall into 'int' range
2668 when the callers expect that.
2669 (image_ascent): Redo ascent calculation to avoid int overflow.
2670 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2671 (lookup_image): Remove unnecessary tests.
2672 (xbm_image_p): Locals are now of int, not EMACS_INT,
2673 since parse_image_check makes sure they fit into int.
2674 (png_load, gif_load, svg_load_image):
2675 Prefer int to unsigned where either will do.
2676 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2677 old tiff_error_handler and tiff_warning_handler.
2678 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2679 stack buffer overflows. It uses only the features of vsnprintf
2680 that are common to both POSIX and native Microsoft.
2681 (tiff_error_handler, tiff_warning_handler): Use it.
2682 (tiff_load, gif_load, imagemagick_load_image):
2683 Don't assume :index value fits in 'int'.
2684 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2685 (imagemagick_load_image): Check that crop parameters fit into
2686 the integer types that MagickCropImage accepts. Don't assume
2687 Vimagemagick_render_type has a nonnegative value. Don't assume
2688 size_t fits in 'long'.
2689 (gs_load): Use printmax_t to print the widest integers possible.
2690 Check for integer overflow when computing image height and width.
2691
c11821d4
EZ
26922011-08-26 Eli Zaretskii <eliz@gnu.org>
2693
2694 * xdisp.c (redisplay_window): Don't force window start if point
2695 will be invisible in the resulting window. (Bug#9324)
2696
0c95fcf7
EZ
26972011-08-25 Eli Zaretskii <eliz@gnu.org>
2698
2699 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2700 the display spec is of the form `(space ...)'.
2701 (handle_display_spec): Return the value returned by
2702 handle_single_display_spec, not just 1 or zero.
2703 (handle_single_display_spec): If the display spec is of the form
2704 `(space ...)', and specifies display in the text area, return 2
2705 rather than 1.
fee65a97 2706 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2707 accurately, and prefer exact match for point under bidi.
2708 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2709
2710 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2711 into disp_prop; all users changed.
2712
2713 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2714 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2715 for the text covered by the display property.
2716
e4ed06f1
CY
27172011-08-25 Chong Yidong <cyd@stupidchicken.com>
2718
2719 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2720 Change return value to nil.
2721 (Frecord_buffer): Delete unused function.
2722
f67cdd7f
EZ
27232011-08-24 Eli Zaretskii <eliz@gnu.org>
2724
5980d4c6
EZ
2725 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2726 buffers, return left-to-right.
8610fe8b
EZ
2727 (set_cursor_from_row): Consider candidate row a win if its glyph
2728 represents a newline and point is on that newline. Fixes cursor
2729 positioning on the newline at EOL of R2L text within L2R
2730 paragraph, and vice versa.
2731 (try_cursor_movement): Check continued rows, in addition to
2732 continuation rows. Fixes unwarranted scroll when point enters a
2733 continued line of R2L text within an L2R paragraph, or vice versa.
2734 (cursor_row_p): Consider the case of point being equal to
2735 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2736 from the end of a short line to the beginning of a continued line
2737 of R2L text within L2R paragraph.
2738 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2739 composed characters.
5980d4c6 2740
f67cdd7f
EZ
2741 * bidi.c (bidi_check_type): Use xassert.
2742 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2743 members.
2744
bca633fb
EZ
27452011-08-23 Eli Zaretskii <eliz@gnu.org>
2746
2747 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2748 a character.
2749
4a5885a7
CY
27502011-08-23 Chong Yidong <cyd@stupidchicken.com>
2751
2752 * nsfont.m (ns_otf_to_script): Fix typo.
2753
0902a04e
KH
27542011-08-22 Kenichi Handa <handa@m17n.org>
2755
2756 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2757 extra slot even if the purpose is char-code-property-table.
2758
1a2e6670
EZ
27592011-08-23 Eli Zaretskii <eliz@gnu.org>
2760
8ddde651
EZ
2761 * xdisp.c (redisplay_window): When computing centering_position,
2762 account for the height of the header line. (Bug#8874)
2763
425cc014
EZ
2764 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2765 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2766 candidate is selected by the mouse, and that candidate has a
2767 composed character under the mouse.
2768
1a2e6670
EZ
2769 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2770 coordinates reported by pos-visible-in-window-p for a composed
2771 character in column zero.
2772
8b76d6f8
SM
27732011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2774
2775 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2776
dac347dd
EZ
27772011-08-22 Eli Zaretskii <eliz@gnu.org>
2778
2779 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2780 consider it a hit if to_charpos is anywhere in the range of the
2781 composed buffer positions.
2782
e013fb34
CY
27832011-08-22 Chong Yidong <cyd@stupidchicken.com>
2784
2785 * image.c (gif_load): Don't assume that each subimage has the same
2786 dimensions as the base image. Handle disposal method that is
2787 "undefined" by the gif spec (Bug#9335).
2788
bd1ba3e8
CY
27892011-08-20 Chong Yidong <cyd@stupidchicken.com>
2790
2791 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2792 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2793
54a1215b
EZ
27942011-08-19 Eli Zaretskii <eliz@gnu.org>
2795
823564e5
EZ
2796 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2797 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2798 from an Org mode buffer to a Speedbar frame.
2799
54a1215b
EZ
2800 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2801 a composition, take its buffer position from IT->cmp_it.charpos.
2802 Fixes cursor positioning at the beginning of a line that begins
2803 with a composed character.
2804
9778ebcc
EZ
28052011-08-18 Eli Zaretskii <eliz@gnu.org>
2806
0be6ee06
EZ
2807 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2808 character bidirectional type, use STRONG_L instead. Fixes crashes
2809 in a buffer produced by `describe-categories'.
2810
9778ebcc
EZ
2811 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2812 members before the level stack, so they would be saved and
2813 restored when copying iterator state. Fixes incorrect reordering
2814 around TABs covered by display properties.
2815
156bffbe
AS
28162011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2817
6b02f655 2818 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2819
72ad093b
CY
28202011-08-17 Chong Yidong <cyd@stupidchicken.com>
2821
2822 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2823 (internal_condition_case_2, internal_condition_case_n):
2824 Remove unnecessary aborts (Bug#9081).
72ad093b 2825
35774242
EZ
28262011-08-17 Eli Zaretskii <eliz@gnu.org>
2827
2828 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2829 has no `load' handler, try opening the file locally. (Bug#9311)
2830
db76dd85
KB
28312011-08-16 Ken Brown <kbrown@cornell.edu>
2832
2833 * gmalloc.c: Expand comment.
2834
b215eee5
EZ
28352011-08-16 Eli Zaretskii <eliz@gnu.org>
2836
2837 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2838 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2839
a4579d33
KB
28402011-08-16 Ken Brown <kbrown@cornell.edu>
2841
2842 Fix memory allocation problems in Cygwin build (Bug#9273).
2843
2844 * unexcw.c ( __malloc_initialized): Declare external variable.
2845 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2846
8b76d6f8
SM
2847 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2848 New variables.
a4579d33
KB
2849 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2850 dumped emacs.
2851 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2852 in the static heap.
2853 [CYGWIN] (special_realloc): New function.
2854 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2855 requests to realloc storage in the static heap.
2856
3ebec551
PE
28572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2858
2859 * bidi.c (bidi_initialize): Remove unused local.
2860
9fd8be00
EZ
28612011-08-15 Eli Zaretskii <eliz@gnu.org>
2862
6b02f655
SM
2863 * bidimirror.h:
2864 * biditype.h: Remove file.
2865 * makefile.w32-in ($(BLD)/bidi.$(O)):
2866 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2867
2868 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2869
2870 * chartab.c: Improve commentary for the uniprop_table API.
2871
32413314
EZ
2872 * bidi.c (bidi_paragraph_init): Support zero value of
2873 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2874 (bidi_initialize): Use uniprop_table instead of including
2875 biditype.h and bidimirror.h.
32413314 2876
9fd8be00
EZ
2877 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2878 coordinates of the iterator when restoring from ppos_it.
2879 (Bug#9296)
2880
5cf2b69b
KH
28812011-08-14 Kenichi Handa <handa@m17n.org>
2882
2883 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2884 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2885
daf17d00
EZ
28862011-08-14 Eli Zaretskii <eliz@gnu.org>
2887
2888 * xdisp.c (move_it_in_display_line_to): Don't invoke
2889 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2890 ppos_it. Fixes vertical cursor motion when line beginning is
2891 covered by an image. (Bug#9296)
2892
08e3161a
JD
28932011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2894
2895 * nsterm.h (ns_run_ascript): Declare.
2896 (NSAPP_DATA2_RUNASSCRIPT): Define.
2897
2898 * nsfns.m (as_script, as_result, as_status): New static variables.
2899 (ns_run_ascript): New function.
5e617bc2 2900 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2901 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2902 the event loop. Get status from as_status (Bug#7276).
2903
2904 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2905 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2906 the event loop (Bug#7276).
2907
a3720aa2
AS
29082011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2909
2910 * gnutls.c (QCgnutls_bootprop_priority)
2911 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2912 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2913 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2914 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2915 (QCgnutls_bootprop_verify_hostname_error)
2916 (QCgnutls_bootprop_callbacks_verify): Rename from
2917 Qgnutls_bootprop_..., all uses changed.
2918
2919 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2920 uses changed.
2921
0a0d27fb
PE
29222011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2923
19d5c50c
PE
2924 * xfaces.c (Qframe_set_background_mode): Now static.
2925 * dispextern.h (Qframe_set_background_mode): Remove decl.
2926
0a0d27fb
PE
2927 * process.c (Fnetwork_interface_info): Declare local only if needed.
2928
377538cb
JD
29292011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2930
2931 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2932 (Fnetwork_interface_list): Allocate in increments of bytes instead
2933 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2934 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2935 sockaddr.
2936 (struct ifflag_def): notrailers is smart on OSX.
2937 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2938 Get hardware address with getifaddrs if available.
2939
08fff70c
EZ
29402011-08-12 Eli Zaretskii <eliz@gnu.org>
2941
2942 * xdisp.c (iterate_out_of_display_property): xassert that
2943 IT->position is set to within IT->object's boundaries. Break from
2944 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2945 when IT->position is set up wrongly due to some bug.
2946 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2947 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2948 entry. Force push_it to save on the stack the current
2949 buffer/string position, to be restored by pop_it. Fix flags in
2950 the iterator structure wrt the object coming from a display
2951 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2952 properties. (Bug#9284)
2953
7be1c708 29542011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2955
7be1c708
CY
2956 * fontset.c (fontset_get_font_group): Add proper type checks.
2957 (Bug#9172)
aac0c6e3 2958
7be1c708 29592011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2960
7be1c708
CY
2961 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2962 and LC_VERSION_MIN_MACOSX.
2963 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2964 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2965
97bb72a6
EZ
29662011-08-08 Eli Zaretskii <eliz@gnu.org>
2967
2968 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2969 no-display-properties-and-no-overlays under bidi display.
2970 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2971 properties and overlays.
97bb72a6 2972
d5617611
CY
29732011-08-08 Chong Yidong <cyd@stupidchicken.com>
2974
37e11a63
CY
2975 * editfns.c (Fset_time_zone_rule): Document relationship with the
2976 setenv function.
2977
d5617611
CY
2978 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2979 the font entity extracted from the cache (Bug#8109).
2980
58872834
CY
29812011-08-07 Chong Yidong <cyd@stupidchicken.com>
2982
2983 * composite.c (autocmp_chars): Don't reset point. That is done by
2984 restore_point_unwind (Bug#5984).
2985
75bfc667
JL
29862011-08-07 Juri Linkov <juri@jurta.org>
2987
2988 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2989 to show the arg `TIME' instead of `TIMEVAL'.
2990
d1410150
EZ
29912011-08-06 Eli Zaretskii <eliz@gnu.org>
2992
2993 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2994 display property strides EOL and includes a newline, as in
2995 longlines-mode. (Bug#9254)
75b771e4
EZ
2996 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2997 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2998
2999 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3000 is non-zero, even if the data buffer is NULL. Fixes a crash in
3001 vertical-motion with longlines-mode. (Bug#9254)
3002
35928349
EZ
30032011-08-05 Eli Zaretskii <eliz@gnu.org>
3004
ec7cc85b
EZ
3005 * bidi.c <bidi_cache_total_alloc>: Now static.
3006 (bidi_initialize): Initialize bidi_cache_total_alloc.
3007
8b76d6f8 3008 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3009 cache. (Bug#9221)
3010
3011 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3012 amount allocated this far in `bidi_cache_total_alloc'.
3013 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3014 non-zero, only free the data buffer without restoring the cache
3015 contents. All callers changed.
3016
3017 * dispextern.h (bidi_unshelve_cache): Update prototype.
3018
3019 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3020 (move_it_in_display_line, move_it_to)
3021 (move_it_vertically_backward, move_it_by_lines): Replace the call
3022 to xfree to an equivalent call to bidi_unshelve_cache.
3023 (move_it_in_display_line_to): Fix logic of returning
412b6358 3024 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3025
e2e2423b
EZ
30262011-08-05 Eli Zaretskii <eliz@gnu.org>
3027
3028 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3029 came from a string character with a `cursor' property. (Bug#9229)
3030
ae9e757a
JD
30312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3032
3033 * Makefile.in (LIB_PTHREAD): New variable.
3034 (LIBES): Add LIB_PTHREAD (Bug#9216).
3035
3036 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3037 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3038
213bd7f2
AS
30392011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3040
6b02f655 3041 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3042
99aaf75f
JD
30432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3044
3045 * xterm.c (x_find_topmost_parent): New function.
3046 (x_set_frame_alpha): Find topmost parent window with
3047 x_find_topmost_parent and set the property there also (bug#9181).
3048 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3049
c74e9d86
PE
30502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3051
3052 * callproc.c (Fcall_process): Avoid vfork clobbering
3053 the local vars buffer, coding_systems, current_dir.
3054
640c8776
SM
30552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3056
3057 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3058
f26d0e4c
PE
30592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3060
8a10d76c
PE
3061 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3062 so that it is not optimized away.
3063
f26d0e4c
PE
3064 * xdisp.c (compute_display_string_pos): Remove unused local.
3065
55439c61
EZ
30662011-08-02 Eli Zaretskii <eliz@gnu.org>
3067
3068 Fix slow cursor motion and scrolling in large buffers with
3069 selective display, like Org Mode buffers. (Bug#9218)
3070
3071 * dispextern.h (struct bidi_it): New member disp_prop_p.
3072
3073 * xdisp.c: Remove one-slot cache of display string positions.
3074 (compute_display_string_pos): Accept an additional argument
5e617bc2 3075 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3076 for a display string or property. If found, set DISP_PROP_P
3077 non-zero.
3078
3079 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3080 DISP_PROP_P, and pass it to compute_display_string_pos.
3081 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3082 non-zero. All callers of bidi_fetch_char changed.
3083
fb33fa43
SM
30842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3085
3086 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3087
b099e063
DM
30882010-12-03 Don March <don@ohspite.net>
3089
3090 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3091 last character M-[char] is translated to ESC [char] (bug#7541).
3092
5cc7f7af
KH
30932011-08-02 Kenichi Handa <handa@m17n.org>
3094
d0fffa3f 3095 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3096
3097 * chartab.c (uniprop_table): Make it non-static.
3098
525d5e6e
EZ
30992011-08-01 Eli Zaretskii <eliz@gnu.org>
3100
3101 * xdisp.c (forward_to_next_line_start): Accept additional argument
3102 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3103 on the newline.
3104 (reseat_at_next_visible_line_start): Use the bidi iterator state
3105 returned by forward_to_next_line_start to restore the state of
3106 it->bidi_it after backing up to previous newline. (Bug#9212)
3107
31011111
AS
31082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3109
3110 * regex.c (re_comp): Protoize.
3111 (re_exec): Fix return type.
3112 (regexec): Fix type of `ret'. (Bug#9203)
3113
476371c4
PE
31142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3115
e5d76069
PE
3116 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3117 This is needed if max-image-size is a floating-point number.
3118
9a79b20c
AS
31192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3120
3121 * print.c (print_object): Print empty symbol as ##.
3122
3123 * lread.c (read1): Read ## as empty symbol.
3124
d8c2fa78
AA
31252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3126
3127 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3128 setting frame foreground color (Bug#9175).
3129 (x_set_background_color): Likewise.
3130
ffe57a7a
AA
3131 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3132 contents (Bug#9176).
3133 (EmacsTooltip -init): Remove bezels and add shadows to
3134 tooltip windows.
3135
bf3492a5
AA
3136 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3137 or scroll bar (Bug#8470).
3138
d55e9c53
AA
3139 * nsfont.m (nsfont_open): Remove assignment to voffset and
3140 unnecessary vars hshink, expand, hd, full_height, min_height.
3141 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3142
3143 * nsterm.h (nsfont_info): Remove voffset field.
3144
d8c2fa78 31452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3146
3147 Implement strike-through and overline on NextStep (Bug#8863).
3148
3149 * nsfont.m (nsfont_open): Use underline position provided by font,
3150 instead of hard-coded value of 2.
3151 (nsfont_draw): Call ns_draw_text_decoration instead.
3152
3153 * nsterm.h: Add declaration for ns_draw_text_decoration.
3154
3155 * nsterm.m (ns_draw_text_decoration): New function for drawing
3156 underline, overline, and strike-through.
3157 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3158 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3159 accommodate underlining, etc.
4843aac3 3160
4cc60b9b
EZ
31612011-07-28 Eli Zaretskii <eliz@gnu.org>
3162
bc7ece87
EZ
3163 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3164 default.
4cc60b9b 3165
476371c4
PE
31662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3167
66606eea
PE
3168 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3169 Without this fix, if a signal arrives just after memory fills up,
3170 'malloc' might be invoked reentrantly.
3171
476371c4
PE
3172 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3173 In other words, assume that every image size is allowed, on non-X
3174 hosts. This assumption is probably wrong, but it lets Emacs compile.
3175
f3fcc40d
AS
31762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3177
3178 * regex.c (re_iswctype): Convert return values to boolean.
3179
350c992f
EZ
31802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3181
3182 * xdisp.c (compute_display_string_pos): Don't use cached display
3183 string position if the buffer had its restriction changed.
3184 (Bug#9184)
3185
5266b4bb
PE
31862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3187
3188 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3189
2573a837 31902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3191
41f55ccd 3192 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3193
39e378da
PE
3194 * bidi.c: Integer size and overflow fixes.
3195 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3196 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3197 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3198 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3199 (bidi_find_other_level_edge):
3200 Use ptrdiff_t instead of EMACS_INT where either will do.
3201 This works better on 32-bit hosts configured --with-wide-int.
3202 (bidi_cache_ensure_space): Check for size-calculation overflow.
3203 Use % rather than repeated addition, for better worst-case speed.
3204 Don't set bidi_cache_size until after xrealloc returns, because it
3205 might not return.
3206 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3207 (bidi_cache_ensure_space): Also check that the bidi cache size
3208 does not exceed that of the largest Lisp string or buffer. See Eli
3209 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3210
5e927815
PE
3211 * alloc.c (__malloc_size_t): Remove.
3212 All uses replaced by size_t. See Andreas Schwab's note
3213 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3214
ca4aa935
PE
3215 * image.c: Improve checking for integer overflow.
3216 (check_image_size): Assume that f is nonnull, since
3217 it is always nonnull in practice. This is one less thing to
3218 worry about when checking for integer overflow later.
3219 (x_check_image_size): New function, which checks for integer
3220 overflow issues inside X.
3221 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3222 This removes the need for a memory_full check.
3223 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3224 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3225 (xbm_read_bitmap_data): Change locals back to 'int', since
3226 their values must fit in 'int'.
3227 (xpm_load_image, png_load, tiff_load):
3228 Invoke x_create_x_image_and_pixmap earlier,
3229 to avoid much needless work if the image is too large.
3230 (tiff_load): Treat overly large images as if
3231 x_create_x_image_and_pixmap failed, not as malloc failures.
3232 (gs_load): Use x_check_image_size.
3233
5f8f9cc2
PE
3234 * gtkutil.c: Omit integer casts.
3235 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3236 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3237
5adf60bc
PE
3238 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3239
c8907a93
PE
3240 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3241 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3242 would wrongly return t on a 64-bit host.
3243
e3c25c68
PE
3244 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3245 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3246 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3247 and therefore cause GCC to emit a bogus diagnostic in some cases.
3248
3f791afe
PE
3249 * image.c: Integer signedness and overflow and related fixes.
3250 This is not an exhaustive set of fixes, but it's time to
3251 record what I've got.
3252 (lookup_pixel_color, check_image_size): Remove redundant decls.
3253 (check_image_size): Don't assume that arbitrary EMACS_INT values
3254 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3255 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3256 (tiff_load, imagemagick_load_image):
3257 Check for overflow in size calculations.
3258 (x_create_x_image_and_pixmap): Remove unnecessary test for
3259 xmalloc returning NULL; that can't happen.
3260 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3261 (xpm_color_bucket): Use better integer hashing function.
3262 (xpm_cache_color): Don't possibly over-allocate memory.
3263 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3264 (gif_memory_source):
3265 Use ptrdiff_t, not int or size_t, to record sizes.
3266 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3267 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3268 either works, as we prefer signed integers.
3269 (tiff_read_from_memory, tiff_write_from_memory):
3270 Return tsize_t, not size_t, since that's what the TIFF API wants.
3271 (tiff_read_from_memory): Don't fail simply because the read would
3272 go past EOF; instead, return a short read.
3273 (tiff_load): Omit no-longer-needed casts.
3274 (Fimagemagick_types): Don't assume size fits into 'int'.
3275
3cc5a532
PE
3276 Improve hashing quality when configured --with-wide-int.
3277 * fns.c (hash_string): New function, taken from sxhash_string.
3278 Do not discard information about ASCII character case; this
3279 discarding is no longer needed.
3280 (sxhash-string): Use it. Change sig to match it. Caller changed.
3281 * lisp.h: Declare it.
3282 * lread.c (hash_string): Remove, since we now use fns.c's version.
3283 The fns.c version returns a wider integer if --with-wide-int is
3284 specified, so this should help the quality of the hashing a bit.
3285
b312a492
PE
3286 * emacs.c: Integer overflow minor fix.
3287 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3288 Define only if GNU_LINUX.
3289 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3290
dfd153ae
PE
3291 * dispnew.c: Integer signedness and overflow fixes.
3292 Remove unnecessary forward decls, that were a maintenance hassle.
3293 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3294 All uses changed.
3295 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3296 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3297 (prepare_desired_row, line_draw_cost):
3298 Use int, not unsigned, where either works.
3299 (save_current_matrix, restore_current_matrix):
3300 Use ptrdiff_t, not size_t, where either works.
3301 (init_display): Check for overflow more accurately, and without
3302 relying on undefined behavior.
3303
a81d11a3
PE
3304 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3305 Remove, replacing with the new symbols in lisp.h. All uses changed.
3306 * fileio.c (make_temp_name):
3307 * filelock.c (lock_file_1, lock_file):
3308 * xdisp.c (message_dolog):
3309 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3310 Use pMd etc. instead.
3311 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3312 replacing the pWIDE etc. symbols removed from editfns.c.
3313
3300e6fd
PE
3314 * keyboard.h (num_input_events): Now uintmax_t.
3315 This is (very slightly) less likely to mess up due to wraparound.
3316 All uses changed.
3317
fd05c7e9
PE
3318 * buffer.c: Integer signedness fixes.
3319 (alloc_buffer_text, enlarge_buffer_text):
3320 Use ptrdiff_t rather than size_t when either will do, as we prefer
3321 signed integers.
3322
903fe15d
PE
3323 * alloc.c: Integer signedness and overflow fixes.
3324 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3325 (__malloc_size_t): Default to size_t, not to int.
3326 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3327 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3328 Prefer ptrdiff_t to size_t when either would do, as we prefer
3329 signed integers.
3330 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3331 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3332 Now const. Initialize with values that are in range even if char
3333 is signed.
3334 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3335 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3336 These functions do the right thing with sizes > 2**32.
3337 (check_depth): Now ptrdiff_t, not int.
3338 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3339 Adjust to new way of storing sizes. Check for size overflow bugs
3340 in rest of code.
3341 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3342 slightly wrong anyway, as it missed one instance of
3343 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3344 (refill_memory_reserve): Omit needless cast to size_t.
3345 (mark_object_loop_halt): Mark as externally visible.
3346
ac82cc6a
PE
3347 * xselect.c: Integer signedness and overflow fixes.
3348 (Fx_register_dnd_atom, x_handle_dnd_message):
3349 Use ptrdiff_t, not size_t, since we prefer signed.
3350 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3351 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3352 x_dnd_atoms_size and x_dnd_atoms_length.
3353
c2d1e36d
PE
3354 * doprnt.c: Prefer signed to unsigned when either works.
3355 * eval.c (verror):
3356 * doprnt.c (doprnt):
3357 * lisp.h (doprnt):
3358 * xdisp.c (vmessage):
3359 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3360 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3361 prefer signed arithmetic to avoid comparison confusion.
3362 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3363 but is a bit tricky.
3364
0e926e56
PE
3365 Assume freestanding C89 headers, string.h, stdlib.h.
3366 * data.c, doprnt.c, floatfns.c, print.c:
3367 Include float.h unconditionally.
3368 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3369 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3370 * regex.c: Likewise for stddef.h, string.h.
3371 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3372 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3373 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3374 (STDC_HEADERS): Remove obsolete defines.
3375 * sysdep.c: Include limits.h unconditionally.
3376
9cfdb3ec
PE
3377 Assume support for memcmp, memcpy, memmove, memset.
3378 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3379 * regex.c (memcmp, memcpy):
3380 Remove; we assume C89 now.
3381
3382 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3383 (__malloc_safe_bcopy): Remove; no longer needed.
3384
cf950e6b 3385 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3386 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3387 well either way, and we prefer signed to unsigned.
3388
dbf38e02
LMI
33892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3390
3391 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3392 closes the connection while we're reading (bug#9182).
3393
d6f0886c 33942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3395
d6f0886c
JD
3396 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3397 are specified (Bug#9168).
24e0f6b1 3398
2eb1f9e6
PE
33992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3400
3401 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3402 Found by GCC static checking and --with-wide-int on a 32-bit host.
3403
22381272 34042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3405
3406 * xdisp.c (compute_display_string_pos): Fix logic of caching
3407 previous display string position. Initialize cached_prev_pos to
3408 -1. Fixes slow-down at the beginning of a buffer.
3409
f25e39b4
EZ
34102011-07-24 Eli Zaretskii <eliz@gnu.org>
3411
3412 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3413 for attrs[LFACE_FONTSET_INDEX].
3414
04c4b52e
PE
34152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 * xml.c (parse_region): Remove unused local
3418 that was recently introduced.
3419
c1734fbd
EZ
34202011-07-23 Eli Zaretskii <eliz@gnu.org>
3421
be18c5a5
EZ
3422 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3423 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3424
c1734fbd
EZ
3425 * xdisp.c (move_it_in_display_line_to): Record the best matching
3426 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3427 exit if none of the characters scanned was an exact match.
3428 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3429 when exact match is impossible due to invisible text, and the
3430 lines are truncated.
3431
a258d627
JD
34322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3433
3434 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3435 for OSX >= 10.7.
3436
b6d5a689
EZ
34372011-07-22 Eli Zaretskii <eliz@gnu.org>
3438
0f74f785
EZ
3439 Fix a significant slow-down of cursor motion with C-n, C-p,
3440 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3441 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3442 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3443 (next_element_from_buffer): Call compute_stop_pos_backwards to
3444 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3445 base_level_stop.
3446 (reseat): Don't look for prev_stop, as that could mean a very long
3447 run.
3448 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3449 <cached_disp_overlay_modiff>: Cache for last found display string
3450 position.
551918c1 3451 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3452 about the same buffer in the same area of character positions, and
3453 the buffer wasn't changed since the time the display string
3454 position was cached.
551918c1 3455
b2d0c91a
EZ
34562011-07-22 Eli Zaretskii <eliz@gnu.org>
3457
3458 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3459 is an integer, which is important for empty lines. (Bug#9149)
3460
043604ee
CY
34612011-07-22 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * frame.c (Fmodify_frame_parameters): In tty case, update the
3464 default face if necessary (Bug#4238).
3465
da4adb04
CY
34662011-07-21 Chong Yidong <cyd@stupidchicken.com>
3467
3468 * editfns.c (Fstring_to_char): No need to explain what a character
3469 is in the docstring (Bug#6576).
3470
9abd0532
LMI
34712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3472
3473 * xml.c (parse_region): Make sure we always return a tree.
3474
36881d16
HK
34752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3476
3477 * xml.c (parse_region): If a document contains only comments,
3478 return that, too.
3479
1e98674d
LMI
34802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3481
3482 * xml.c (make_dom): Return comments, too.
3483
590bd467
PE
34842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 Port to OpenBSD.
3487 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3488 and the surrounding thread.
3489 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3490 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3491 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3492 timer goes off.
3493 * s/openbsd.h (BROKEN_SIGIO): Define.
3494 * unexelf.c (unexec) [__OpenBSD__]:
3495 Don't update the .mdebug section of the Alpha COFF symbol table.
3496
f41628b2
LMI
34972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498
3499 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3500 (bug#8460).
3501
b59b67c5
PE
35022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3503
15e3a074
PE
3504 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3505 This fixes some race conditions on the permissions of any newly
3506 created file.
3507
41bed37d
PE
3508 * alloc.c (valid_pointer_p): Use pipe, not open.
3509 This fixes some permissions issues when debugging.
3510
b59b67c5
PE
3511 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3512 If fchown fails to set both uid and gid, try to set just gid,
3513 as that is sometimes allowed. Adjust the file's mode to eliminate
3514 setuid or setgid bits that are inappropriate if fchown fails.
3515
925a6be7
SM
35162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3517
3518 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3519 to compare Lisp_Objects.
3520 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3521 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3522 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3523
52968808
AS
35242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3525
0a6a104b
AS
3526 * lread.c (read_integer): Unread even EOF character.
3527 (read1): Likewise. Properly record start position of symbol.
3528
52968808
AS
3529 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3530 symbol character follows.
3531
9e381cdd
PE
35322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3535 This works around a problem with the previous change to Fcopy_file.
3536 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3537 and without this change, GCC might complain about discarding
3538 fchown's return value.
3539
b5641435
JB
35402011-07-16 Juanma Barranquero <lekktu@gmail.com>
3541
3542 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3543
a8031457
PE
35442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3547
dd889327
LMI
35482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3549
750c33f7
LMI
3550 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3551 it's used from the C level.
3552
dd889327
LMI
3553 * process.c: Use the same condition for POLL_FOR_INPUT in both
3554 keyboard.c and process.c (bug#1858).
3555
87e86684
LM
35562011-07-09 Lawrence Mitchell <wence@gmx.li>
3557
3558 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3559 (Fgnutls_boot): Use it.
3560
64348f40
AS
35612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3562
3563 * doc.c (Fsubstitute_command_keys): Revert last change.
3564
1d698799
LMI
35652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3566
f863868c
LMI
3567 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3568 quotes the next character, and doesn't affect other longer
3569 sequences (bug#8935).
3570
1d698799
LMI
3571 * lread.c (syms_of_lread): Clarify that is isn't only
3572 `eval-buffer' and `eval-defun' that's affected by
3573 `lexical-binding' (bug#8460).
3574
aa4b6df6
EZ
35752011-07-15 Eli Zaretskii <eliz@gnu.org>
3576
3577 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3578 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3579
5d856da6
PE
35802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3581
ad6042bb
PE
3582 Fix minor problems found by static checking.
3583 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3584 (elsz): Now a signed constant, not a size_t var. We prefer signed
3585 types to unsigned, to avoid integer comparison confusion. Without
3586 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3587 "cannot optimize loop, the loop counter may overflow", a symptom
3588 of the confusion.
f00bbb22 3589 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3590 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3591
6468f31c
LMI
35922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3593
49080b10
LMI
3594 * search.c (Fre_search_backward): Mention `case-fold-search' in
3595 all the re_search_* functions (bug#8138).
3596
6468f31c
LMI
3597 * keyboard.c (Fopen_dribble_file): Document when the file is
3598 closed (bug#8056).
3599
c965adc5
EZ
36002011-07-14 Eli Zaretskii <eliz@gnu.org>
3601
df9733bf
EZ
3602 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3603 bidi_cache_idx.
3604
0bb23927
EZ
3605 Support bidi reordering of display and overlay strings.
3606 * xdisp.c (compute_display_string_pos)
3607 (compute_display_string_end): Accept additional argument STRING.
3608 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3609 (reseat_to_string): Initialize bidi_it->string.s and
3610 bidi_it->string.schars.
3611 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3612 NULL (avoids a crash in bidi_paragraph_init).
3613 Initialize itb.string.lstring.
0bb23927
EZ
3614 (init_iterator): Call bidi_init_it only of a valid
3615 buffer position was specified. Initialize paragraph_embedding to
3616 L2R.
3617 (reseat_to_string): Initialize the bidi iterator.
3618 (display_string): If we need to ignore text properties of
3619 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3620 original value of -1 will not work with bidi.)
3621 (compute_display_string_pos): First arg is now struct
3622 `text_pos *'; all callers changed. Support display properties on
3623 Lisp strings.
3624 (compute_display_string_end): Support display properties on Lisp
3625 strings.
3626 (init_iterator, reseat_1, reseat_to_string): Initialize the
3627 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3628 when iterating on a string not from display properties).
640c8776
SM
3629 (compute_display_string_pos, compute_display_string_end):
3630 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3631 arrow keys.
3632 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3633 base_level_stop; instead, set base_level_stop to BEGV.
3634 Fixes crashes in vertical-motion.
0bb23927
EZ
3635 (next_element_from_buffer): Improve commentary for when
3636 the iterator is before prev_stop.
3637 (init_iterator): Initialize bidi_p from the default value of
3638 bidi-display-reordering, not from buffer-local value. Use the
3639 buffer-local value only if initializing for buffer iteration.
3640 (handle_invisible_prop): Support invisible properties on strings
3641 that are being bidi-reordered.
3642 (set_iterator_to_next): Support bidi reordering of C strings and
3643 Lisp strings.
3644 (next_element_from_string): Support bidi reordering of Lisp
3645 strings.
3646 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3647 (display_string): Support display of R2L glyph rows.
3648 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3649 (init_iterator): Don't initialize it->bidi_p for strings
3650 here.
3651 (reseat_to_string): Initialize it->bidi_p for strings here.
3652 (next_element_from_string, next_element_from_c_string)
3653 (next_element_from_buffer): Add xassert's for correspondence
3654 between IT's object being iterated and it->bidi_it.string
3655 structure.
3656 (face_before_or_after_it_pos): Support bidi iteration.
3657 (next_element_from_c_string): Handle the case of the first string
3658 character that is not the first one in the visual order.
3659 (get_visually_first_element): New function, refactored from common
3660 parts of next_element_from_buffer, next_element_from_string, and
3661 next_element_from_c_string.
3662 (tool_bar_lines_needed, redisplay_tool_bar)
3663 (display_menu_bar): Force left-to-right direction. Add a FIXME
3664 comment for making that be controlled by a user option.
3665 (push_it, pop_it): Save and restore the state of the
3666 bidi iterator. Save and restore the bidi_p flag.
3667 (pop_it): Iterate out of display property for string iteration as
3668 well.
3669 (iterate_out_of_display_property): Support iteration over strings.
3670 (handle_single_display_spec): Set up it->bidi_it for iteration
3671 over a display string, and call bidi_init_it.
3672 (handle_single_display_spec, next_overlay_string)
3673 (get_overlay_strings_1, push_display_prop): Set up the bidi
3674 iterator for displaying display or overlay strings.
3675 (forward_to_next_line_start): Don't use the shortcut if
3676 bidi-iterating.
3677 (back_to_previous_visible_line_start): If handle_display_prop
3678 pushed the iterator stack, restore the internal state of the bidi
3679 iterator by calling bidi_pop_it same number of times.
3680 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3681 and we are bidi-iterating, don't decrement the iterator position;
3682 instead, set the first_elt flag in the bidi iterator, to produce
3683 the same effect.
3684 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3685 (push_display_prop): xassert that we are iterating a buffer.
3686 (push_it, pop_it): Save and restore paragraph_embedding member.
3687 (handle_single_display_spec, next_overlay_string)
3688 (get_overlay_strings_1, reseat_1, reseat_to_string)
3689 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3690 correctly. Don't assume unibyte strings are not bidi-reordered.
3691 (compute_display_string_pos)
3692 (compute_display_string_end): Fix handling the case of C string.
3693 (push_it, pop_it): Save and restore from_disp_prop_p.
3694 (handle_single_display_spec, push_display_prop): Set the
3695 from_disp_prop_p flag.
3696 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3697 (pop_it): Call iterate_out_of_display_property only if we are
3698 popping after iteration over a string that came from a display
3699 property. Fix a typo in popping stretch info. Add an assertion
3700 for verifying that the iterator position is in sync with the bidi
3701 iterator.
3702 (handle_single_display_spec, get_overlay_strings_1)
3703 (push_display_prop): Fix initialization of paragraph direction for
3704 string when that of the parent object is not yet determined.
3705 (reseat_1): Call bidi_init_it to resync the bidi
3706 iterator with IT's position. (Bug#7616)
3707 (find_row_edges): If ROW->start.pos gives position
3708 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3709 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3710 Reset the from_disp_prop_p flag.
3711 (SAVE_IT, RESTORE_IT): New macros.
3712 (pos_visible_p, face_before_or_after_it_pos)
3713 (back_to_previous_visible_line_start)
3714 (move_it_in_display_line_to, move_it_in_display_line)
3715 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3716 (try_scrolling, redisplay_window, display_line): Use them when
3717 saving a temporary copy of the iterator and restoring it back.
3718 (back_to_previous_visible_line_start, reseat_1)
3719 (init_iterator): Empty the bidi cache "stack".
3720 (move_it_in_display_line_to): If iterator ended up at
3721 EOL, but we never saw any buffer positions smaller than
3722 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3723 motion in bidi-reordered lines.
3724 (move_it_in_display_line_to): Record prev_method and prev_pos
3725 immediately before the call to set_iterator_to_next. Fixes cursor
3726 motion in bidi-reordered lines with stretch glyphs and strings
3727 displayed in margins. (Bug#8133) (Bug#8867)
3728 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3729 TO_CHARPOS.
640c8776
SM
3730 (pos_visible_p): Support positions in bidi-reordered lines.
3731 Save and restore bidi cache.
0bb23927
EZ
3732
3733 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3734 (bidi_paragraph_info): Delete unused struct.
3735 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3736 (bidi_cache_start): New variable.
3737 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3738 to zero.
3739 (bidi_cache_fetch_state, bidi_cache_search)
3740 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3741 (bidi_cache_find, bidi_peek_at_next_level)
3742 (bidi_level_of_next_char, bidi_find_other_level_edge)
3743 (bidi_move_to_visually_next): Compare cache index with
3744 bidi_cache_start rather than with zero.
3745 (bidi_fetch_char): Accept new argument STRING; all callers
3746 changed. Support iteration over a string. Support strings with
3747 display properties. Support unibyte strings. Fix the type of
3748 `len' according to what STRING_CHAR_AND_LENGTH expects.
3749 (bidi_paragraph_init, bidi_resolve_explicit_1)
3750 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3751 (bidi_level_of_next_char, bidi_move_to_visually_next):
3752 Support iteration over a string.
0bb23927
EZ
3753 (bidi_set_sor_type, bidi_resolve_explicit_1)
3754 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3755 can now be zero (for strings); special values 0 and -1 were
3756 changed to -1 and -2, respectively.
3757 (bidi_char_at_pos): New function.
3758 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3759 Call it instead of FETCH_MULTIBYTE_CHAR.
3760 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3761 initialized to valid values.
3762 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3763 values.
3764 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3765 the test for valid cached positions. Fix the logic for looking up
3766 the sentinel state in the cache. GCPRO the Lisp string we are
3767 iterating.
3768 (bidi_push_it, bidi_pop_it): New functions.
3769 (bidi_initialize): Initialize the bidi cache start stack pointer.
3770 (bidi_cache_ensure_space): New function, refactored from part of
3771 bidi_cache_iterator_state. Don't assume the required size is just
3772 one BIDI_CACHE_CHUNK away.
3773 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3774 (bidi_count_bytes, bidi_char_at_pos): New functions.
3775 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3776 always valid if bidi_cache_idx is valid.
3777 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3778 is valid if it's going to be used.
3779 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3780 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3781 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3782 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3783 (bidi_find_other_level_edge, bidi_cache_start_stack):
3784 All variables related to cache indices are now EMACS_INT.
c965adc5 3785
0bb23927
EZ
3786 * dispextern.h (struct bidi_string_data): New structure.
3787 (struct bidi_it): New member `string'. Make flag members be 1-bit
3788 fields, and put them last in the struct.
640c8776
SM
3789 (compute_display_string_pos, compute_display_string_end):
3790 Update prototypes.
0bb23927
EZ
3791 (bidi_push_it, bidi_pop_it): Add prototypes.
3792 (struct iterator_stack_entry): New members bidi_p,
3793 paragraph_embedding, and from_disp_prop_p.
3794 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3795 (bidi_shelve_cache, bidi_unshelve_cache):
3796 Declare prototypes.
0bb23927
EZ
3797
3798 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3799 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3800 and vector-like objects.
3801
3802 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3803 cache around display iteration.
3804
3805 * window.c (Fwindow_end, window_scroll_pixel_based)
3806 (displayed_window_lines, Frecenter): Save and restore the bidi
3807 cache around display iteration.
3808
3bbd2265
LMI
38092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3810
3811 * editfns.c (Fdelete_region): Clarify the use of the named
3812 parameters (bug#6788).
3813
adc47434
MR
38142011-07-14 Martin Rudalics <rudalics@gmx.at>
3815
3816 * indent.c (Fvertical_motion): Set and restore w->pointm when
3817 saving and restoring the window's buffer (Bug#9006).
3818
837c31f8
LMI
38192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3820
3821 * editfns.c (Fstring_to_char): Clarify just what is returned
3822 (bug#6576). Text by Eli Zaretskii.
3823
ac389d0c
JB
38242011-07-13 Juanma Barranquero <lekktu@gmail.com>
3825
3826 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3827
0be0ce47
EZ
38282011-07-13 Eli Zaretskii <eliz@gnu.org>
3829
3830 * buffer.c (mmap_find): Fix a typo.
3831
cd18e7e3
JB
38322011-07-13 Johan Bockgård <bojohan@gnu.org>
3833
3834 Fix execution of x selection hooks.
3835 * xselect.c (Qx_lost_selection_functions)
3836 (Qx_sent_selection_functions): New vars.
3837 (syms_of_xselect): DEFSYM them.
3838 (x_handle_selection_request): Pass Qx_sent_selection_functions
3839 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3840 (x_handle_selection_clear,x_clear_frame_selections):
3841 Pass Qx_lost_selection_functions rather than
3842 Vx_lost_selection_functions to Frun_hook_with_args.
3843
47ea7f44
PE
38442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3845
ac389d0c 3846 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3847 The old code sometimes used this field without initializing it.
3848
47ea7f44
PE
3849 * alloc.c (gc_sweep): Don't read past end of array.
3850 In theory, the old code could also have corrupted Emacs internals,
3851 though it'd be very unlikely.
3852
bc985c87
AS
38532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3854
3855 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3856 argument. (Bug#4026)
bc985c87 3857
0cf34688
LMI
38582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3859
b3dadd76
LMI
3860 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3861 key" (bug#4257).
3862
0cf34688
LMI
3863 * window.c (Fset_window_start): Doc fix (bug#4199).
3864 (Fset_window_hscroll): Ditto.
3865
270768cd
PE
38662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3867
077e3dda 3868 Fix minor new problems caught by GCC 4.6.1.
270768cd 3869 * term.c (init_tty): Remove unused local.
490011a6 3870 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3871 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3872 not used otherwise.
270768cd 3873
b1f58454
CY
38742011-07-12 Chong Yidong <cyd@stupidchicken.com>
3875
3876 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3877
22b9578d
LMI
38782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3879
6e70ab07
LMI
3880 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3881 are the mini-buffer and the echo area (bug#3320).
3882
22b9578d
LMI
3883 * term.c (init_tty): Remove support for supdup, c10 and perq
3884 terminals, which are no longer supported (bug#1482).
3885
8974cc9f
JB
38862011-07-10 Johan Bockgård <bojohan@gnu.org>
3887
3888 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3889
a560d974
JD
38902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3891
3892 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3893 for non-popups (Bug#3642).
3894
1dae0f0a
AS
38952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3896
268c2c36 3897 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3898 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3899 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3900 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3901 * data.c (fmod): Likewise.
3902 * dispnew.c (swap_glyphs_in_rows): Likewise.
3903 * emacs.c (memory_warning_signal): Likewise.
3904 * floatfns.c (float_error): Likewise.
3905 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3906 (otf_open, font_otf_capability, generate_otf_features)
3907 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3908 Likewise.
3909 * image.c (pbm_read_file): Likewise.
3910 * indent.c (string_display_width): Likewise.
3911 * intervals.c (check_for_interval, search_for_interval)
3912 (inc_interval_count, count_intervals, root_interval)
3913 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3914 * lread.c (defalias): Likewise.
268c2c36 3915 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3916 * regex.c (set_image_of_range_1, set_image_of_range)
3917 (regex_grow_registers): Likewise.
3918 * sysdep.c (strerror): Likewise.
3919 * termcap.c (valid_filename_p, tprint, main): Likewise.
3920 * tparam.c (main): Likewise.
3921 * unexhp9k800.c (run_time_remap, save_data_space)
3922 (update_file_ptrs, read_header, write_header, calculate_checksum)
3923 (copy_file, copy_rest, display_header): Likewise.
3924 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3925 Likewise.
3926 * xdisp.c (check_it): Likewise.
3927 * xfaces.c (register_color, unregister_color, unregister_colors):
3928 Likewise.
3929 * xfns.c (print_fontset_result): Likewise.
3930 * xrdb.c (member, fatal, main): Likewise.
3931
99033785
PE
39322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3933
3934 Fix minor problems found by static checking (Bug#9031).
3935 * chartab.c (char_table_set_range, map_sub_char_table):
3936 Remove unused locals.
3937 (uniprop_table): Now static.
3938 * composite.c (_work_char): Remove unused static var.
3939
9cb2ac56
JB
39402011-07-09 Juanma Barranquero <lekktu@gmail.com>
3941
3942 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3943
f25661f0
JD
39442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3945
3946 * gtkutil.c (qttip_cb): Remove code without function.
3947
8278c4fe
EZ
39482011-07-09 Eli Zaretskii <eliz@gnu.org>
3949
3950 * w32.c (pthread_sigmask): New stub.
3951
1692ae2d 39522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3953
8a6ebd58 3954 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3955 sigprocmask is portable only for single-threaded applications, and
3956 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3957 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3958 (LIBES): Use it.
3959 * callproc.c (Fcall_process):
3960 * process.c (create_process):
3961 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3962 Use pthread_sigmask, not sigprocmask.
123403e4 3963
1b854618
JD
39642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3965
3966 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3967 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3968 wrong (Bug#8591).
3969
3fe4b549
JD
39702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3971
0ce7e563
JD
3972 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3973 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3974 (xg_hide_tooltip): Fix comment.
3975
3fe4b549
JD
3976 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3977 in registerServicesMenuSendTypes.
3978 (validRequestorForSendType): Don't check ns_return_types.
3979
3980 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3981 ns_return_type.
3982
5df75e47
JR
39832011-07-08 Jason Rumney <jasonr@gnu.org>
3984
22610910
JR
3985 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3986 SH_SHOW for hidden windows (Bug#5482).
3987
5df75e47
JR
3988 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3989 frame struct members of non-existent frames (Bug#6284).
3990
699c10bd
JD
39912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3992
4393663b
JD
3993 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3994 variable firstTime not needed on OSX >= 10.6.
3995 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3996 >= 10.5. Use setKnobProportion, setDoubleValue.
3997
3998 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3999 (MAC_OS_X_VERSION_10_5): Define if not defined.
4000 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4001 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4002 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4003
4004 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4005 cString and lossyCString on OSX >= 10.4
4006
58179cce 4007 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4008 sizeToFit on OSX >= 10.2.
4009
4010 * nsimage.m (allocInitFromFile): Don't use deprecated method
4011 bestRepresentationForDevice on OSX >= 10.6.
4012
4013 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4014 to avoid warning.
4015
4016 * emacs.c: Declare unexec_init_emacs_zone.
4017
a63e0781
JD
4018 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4019
699c10bd
JD
4020 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4021
4022 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4023 on svcsMenu (Bug#8842).
4024
4025 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4026 ns_return_types.
4027 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4028
4029 * nsterm.m (QUTF8_STRING): Declare.
4030 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4031 (validRequestorForSendType): Return type is (id).
4032 Change indexOfObjectIdenticalTo to indexOfObject.
4033 Check if we have local selection before returning self (Bug#8842).
4034 (writeSelectionToPasteboard): Put local selection into paste board
4035 if we have a local selection (Bug#8842).
4036 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4037
4038 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4039 (ns_get_local_selection): Declare.
4040
54e10184
LMI
40412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4042
9888ff71
LMI
4043 * keymap.c (describe_map_tree): Don't insert a double newline at
4044 the end of the buffer (bug#1169) and return whether we inserted
4045 something.
4046
54e10184
LMI
4047 * callint.c (Fcall_interactively): Change "reading args" to
4048 "providing args" to try to clarify what it does (bug#1010).
4049
15fa4783
KH
40502011-07-07 Kenichi Handa <handa@m17n.org>
4051
4052 * composite.c (composition_compute_stop_pos): Ignore a static
4053 composition starting before CHARPOS (Bug#8915).
4054
4055 * xdisp.c (handle_composition_prop): Likewise.
4056
a8815b00
EZ
40572011-07-07 Eli Zaretskii <eliz@gnu.org>
4058
4059 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4060 (Bug#9015)
4061
ef7b981d 40622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4063
4064 * character.h (unicode_category_t): New enum type.
4065
4066 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4067 (Qchar_code_property_table): New variable.
4068 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4069 (UNIPROP_COMPRESSED_FORM_P): New macros.
4070 (char_table_ascii): Uncompress the compressed values.
4071 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4072 Uncompress the compressed values.
ac389d0c 4073 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4074 (char_table_ref_and_range): Uncompress the compressed values.
4075 (sub_char_table_set): New arg is_uniprop. Callers changed.
4076 Uncompress the compressed values.
4077 (sub_char_table_set_range): Args changed. Callers changed.
4078 (char_table_set_range): Adjuted for the above change.
4079 (map_sub_char_table): Delete args default_val and parent. Add arg
4080 top. Give decoded values to a Lisp function.
640c8776 4081 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4082 values to a Lisp function. Gcpro more variables.
4083 (uniprop_table_uncompress)
4084 (uniprop_decode_value_run_length): New functions.
4085 (uniprop_decoder, uniprop_decoder_count): New variables.
4086 (uniprop_get_decoder, uniprop_encode_value_character)
4087 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4088 New functions.
4089 (uniprop_encoder, uniprop_encoder_count): New variables.
4090 (uniprop_get_encoder, uniprop_table)
4091 (Funicode_property_table_internal, Fget_unicode_property_internal)
4092 (Fput_unicode_property_internal): New functions.
4093 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4094 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4095 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4096 char-code-property-alist.
4097
640c8776 4098 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4099 Vunicode_category_table.
4100
640c8776 4101 * font.c (font_range): Adjust for the change of
c805dec0
KH
4102 Vunicode_category_table.
4103
76b397fb
DN
41042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4105
4106 * m/iris4d.h: Remove file, move contents ...
4107 * s/irix6-5.h: ... here.
4108
22b4128e
PE
41092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4112 * alloc.c (mark_buffer):
4113 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4114 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4115 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4116 This isn't true in general, and it's particularly not true
4117 if Emacs is configured with --with-wide-int.
4118 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4119 New macros, used in the buffer.c change.
4120
869795d6
JD
41212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4122
4123 * xsettings.c: Use both GConf and GSettings if both are available.
4124 (store_config_changed_event): Add comment.
4125 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4126 (store_tool_bar_style_changed): New functions.
5e617bc2 4127 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4128 (struct xsettings): Move font inside HAVE_XFT.
4129 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4130 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4131 Move inside HAVE_XFT.
640c8776 4132 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4133 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4134 also.
4135 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4136 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4137 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4138 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4139 (parse_settings): Move check for font inside HAVE_XFT.
4140 (read_settings, apply_xft_settings): Add comment.
4141 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4142 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4143 call store_font_name_changed.
4144 (xft_settings_event): Add comment.
4145 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4146 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4147 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4148 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4149 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4150 (xsettings_get_system_font, xsettings_get_system_normal_font):
4151 Add comment.
869795d6 4152
d8ed26bd
PE
41532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4154
4155 Random fixes. E.g., (random) never returned negative values.
4156 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4157 subseconds part to the entropy, as that's a bit more random.
4158 Prefer signed to unsigned, since the signedness doesn't matter and
4159 in general we prefer signed. When given a limit, use a
4160 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4161 latter isn't right if USE_2_TAGS_FOR_INTS.
4162 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4163 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4164
cabf1cac
SM
41652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4166
4167 * textprop.c (text_property_stickiness):
4168 Obey Vtext_property_default_nonsticky.
4169 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4170 * w32fns.c (syms_of_w32fns):
4171 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4172
6e9b2be9
PE
41732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4174
4175 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4176 This is more efficient than Ffile_directory_p and avoids a minor race.
4177
90186c68
LMI
41782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4179
7c301272
LMI
4180 * buffer.c (Foverlay_put): Say what the return value is
4181 (bug#7835).
4182
c4f2d8d4
LMI
4183 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4184 is a directory before asking whether to use the file name
4185 (bug#7564).
ad637907
LMI
4186 (barf_or_query_if_file_exists): Make the "File is a directory"
4187 error be more correct.
c4f2d8d4 4188
90186c68
LMI
4189 * fns.c (Frequire): Remove the mention of the .gz files, since
4190 that's installation-specific, but keep the mention of
4191 `get-load-suffixes'.
4192
da64016e
PE
41932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4196 Report string overflow if the output is too long.
4197
7d47b580
JB
41982011-07-04 Juanma Barranquero <lekktu@gmail.com>
4199
a555cb87
JB
4200 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4201 (syms_of_gnutls): Remove duplicate DEFSYM for
4202 Qgnutls_bootprop_verify_hostname_error, an error for
4203 Qgnutls_bootprop_verify_error (which is no longer used).
4204
7d47b580
JB
4205 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4206 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4207 Also (re)move comments that are misplaced or no longer relevant.
4208
1e49bfab
LMI
42092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4210
4211 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4212
1485f4c0
CY
42132011-07-03 Chong Yidong <cyd@stupidchicken.com>
4214
4215 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4216 and background color parameters if they have been changed.
4217
a9ab721e
LMI
42182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4219
4220 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4221
cf7cff57
PE
42222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4223
2e13213d
PE
4224 * xsettings.c (SYSTEM_FONT): Define only when used.
4225 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4226
cf7cff57
PE
4227 * keymap.c (access_keymap_1): Now static.
4228
7a8e04f7
CY
42292011-07-02 Chong Yidong <cyd@stupidchicken.com>
4230
4231 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4232 leave any prefix arg for the up event (Bug#1586).
4233
61352f62
LMI
42342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4235
69bb1ef7
LMI
4236 * lread.c (syms_of_lread): Mention single symbols defined by
4237 `defvar' or `defconst' (bug#7154).
4238
61352f62 4239 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4240 (Frequire): Mention get-load-suffixes.
61352f62 4241
28545e04
MR
42422011-07-02 Martin Rudalics <rudalics@gmx.at>
4243
4244 * window.h (window): Remove clone_number slot.
4245 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4246 Remove.
4247 (make_parent_window, make_window, saved_window)
4248 (Fset_window_configuration, save_window_save): Don't deal with
4249 clone numbers.
4250 * buffer.c (Qclone_number): Remove declaration.
4251 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4252
3349e122
SM
42532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4254
4255 Add multiple inheritance to keymaps.
4256 * keymap.c (Fmake_composed_keymap): New function.
4257 (Fset_keymap_parent): Simplify.
4258 (fix_submap_inheritance): Remove.
4259 (access_keymap_1): New function extracted from access_keymap to handle
4260 embedded parents and handle lists of maps.
4261 (access_keymap): Use it.
4262 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4263 (Fcopy_keymap): Handle embedded parents.
4264 (Fcommand_remapping, define_as_prefix): Simplify.
4265 (Fkey_binding): Simplify.
4266 (syms_of_keymap): Move minibuffer-local-completion-map,
4267 minibuffer-local-filename-completion-map,
4268 minibuffer-local-must-match-map, and
4269 minibuffer-local-filename-must-match-map to Elisp.
4270 (syms_of_keymap): Defsubr make-composed-keymap.
4271 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4272 (parse_menu_item): Trivial simplification.
4273
3279eb87
GM
42742011-07-01 Glenn Morris <rgm@gnu.org>
4275
4276 * Makefile.in (SETTINGS_LIBS): Fix typo.
4277
4550efdf
KI
42782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4279
4280 * coding.c (Fencode_coding_string): Record the last coding system
4281 used, as the function doc string says (bug#8738).
4282
0949d2b6
JD
42832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4284
4285 * xsettings.c (store_monospaced_changed): Take new font as arg and
4286 check for change against current_mono_font.
4287 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4288 (emacs_settings_constructor, emacs_settings_get_property)
4289 (emacs_settings_set_property, emacs_settings_class_init)
4290 (emacs_settings_init, gsettings_obj): Remove.
4291 (something_changedCB): New function for HAVE_GSETTINGS.
4292 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4293 with value as argument.
4294 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4295 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4296 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4297 "changed".
4298
4299 * xgselect.c: Add defined (HAVE_GSETTINGS).
4300 (xgselect_initialize): Ditto.
4301
4302 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4303 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4304 xg_select.
4305
bbc6b304
PE
43062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 * eval.c (struct backtrace): Simplify and port the data structure.
4309 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4310 signed bit field, as this assumption is not portable and it makes
4311 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4312 "char debug_on_exit : 1" as this is not portable either; instead,
4313 use the portable "unsigned int debug_on_exit : 1". Remove unused
4314 member evalargs. Remove obsolete comments about cc bombing out.
4315
9851bfc5
JD
43162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4317
51bb811f 4318 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4319 Let HAVE_GSETTINGS override HAVE_GCONF.
4320 (store_monospaced_changed): New function.
4321 (EMACS_SETTINGS): A new type derived from GObject to handle
4322 GSettings notifications.
4323 (emacs_settings_constructor, emacs_settings_get_property)
4324 (emacs_settings_set_property, emacs_settings_class_init):
4325 New functions.
4326 (gsettings_client, gsettings_obj): New variables.
4327 (GSETTINGS_SCHEMA): New define.
4328 (something_changedCB): Call store_monospaced_changed.
4329 (init_gsettings): New function.
4330 (xsettings_initialize): Call init_gsettings.
4331 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4332 to NULL.
4333
640c8776 4334 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4335 GCONF_CFLAGS/LIBS.
4336
5386012d
MR
43372011-06-29 Martin Rudalics <rudalics@gmx.at>
4338
4339 * window.c (resize_root_window, grow_mini_window)
4340 (shrink_mini_window): Rename Qresize_root_window to
4341 Qwindow_resize_root_window and Qresize_root_window_vertically to
4342 Qwindow_resize_root_window_vertically.
4343
f13e0b08
PE
43442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4347
94515237
JB
43482011-06-27 Juanma Barranquero <lekktu@gmail.com>
4349
4350 * makefile.w32-in: Redesign dependencies so they reflect more
4351 clearly which files are directly included by each source file,
4352 and not through other includes.
4353
e43b6e43
MR
43542011-06-27 Martin Rudalics <rudalics@gmx.at>
4355
4356 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4357 (sort_overlays, overlay_strings): When an overlay's clone number
4358 matches the window's clone number process the overlay even if
4359 the overlay's window property doesn't match the current window.
4360
d68443dc
MR
4361 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4362 (Fwindow_hchild): Rename to Fwindow_left_child.
4363 (Fwindow_next): Rename to Fwindow_next_sibling.
4364 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4365 (resize_window_check): Rename to window_resize_check.
4366 (resize_window_apply): Rename to window_resize_apply.
4367 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4368 (Fdelete_other_windows_internal, resize_frame_windows)
4369 (Fsplit_window_internal, Fdelete_window_internal)
4370 (grow_mini_window, shrink_mini_window)
4371 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4372
c7e73be5
JD
43732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4374
4375 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4376 (emacs_fixed_set_min_size): Remove.
4377 (emacs_fixed_new): Take frame as argument.
4378
4379 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4380 (_EmacsFixedPrivate): Remove minwidth/height.
4381 Add struct frame *f.
4382 (emacs_fixed_init): Initialize priv->f.
4383 (get_parent_class, emacs_fixed_set_min_size): Remove.
4384 (emacs_fixed_new): Set priv->f to argument.
4385 (emacs_fixed_get_preferred_width)
4386 (emacs_fixed_get_preferred_height): Use min_width/height from
4387 frames size_hint to set minimum and natural (Bug#8919).
4388 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4389 and use min_width/height from frames size_hint to set
4390 min_width/height (Bug#8919).
4391
4392 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4393 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4394 Fix indentation.
c7e73be5 4395
cf99dcf8
EZ
43962011-06-26 Eli Zaretskii <eliz@gnu.org>
4397
4398 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4399 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4400 called at ZV.
4401
029529ac
CY
44022011-06-26 Chong Yidong <cyd@stupidchicken.com>
4403
4404 * process.c (wait_reading_process_output): Bypass select if
4405 waiting for a cell while ignoring keyboard input, and input is
4406 pending. Suggested by Jan Djärv (Bug#8869).
4407
7a7ef429
PE
44082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 Use gnulib's dup2 module instead of rolling our own.
4411 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4412
11fdef7d 44132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4414
4415 * dispnew.c (scrolling_window): Before scrolling, turn off a
4416 mouse-highlight in the window being scrolled.
4417
cd3520a4
JB
44182011-06-24 Juanma Barranquero <lekktu@gmail.com>
4419
4420 Move DEFSYM to lisp.h and use everywhere.
4421
4422 * character.h (DEFSYM): Move declaration...
4423 * lisp.h (DEFSYM): ...here.
4424
4425 * gnutls.c:
4426 * minibuf.c:
4427 * w32menu.c:
4428 * w32proc.c:
4429 * w32select.c: Don't include character.h.
4430
4431 * alloc.c (syms_of_alloc):
4432 * buffer.c (syms_of_buffer):
4433 * bytecode.c (syms_of_bytecode):
4434 * callint.c (syms_of_callint):
4435 * casefiddle.c (syms_of_casefiddle):
4436 * casetab.c (init_casetab_once):
4437 * category.c (init_category_once, syms_of_category):
4438 * ccl.c (syms_of_ccl):
4439 * cmds.c (syms_of_cmds):
4440 * composite.c (syms_of_composite):
4441 * dbusbind.c (syms_of_dbusbind):
4442 * dired.c (syms_of_dired):
4443 * dispnew.c (syms_of_display):
4444 * doc.c (syms_of_doc):
4445 * editfns.c (syms_of_editfns):
4446 * emacs.c (syms_of_emacs):
4447 * eval.c (syms_of_eval):
4448 * fileio.c (syms_of_fileio):
4449 * fns.c (syms_of_fns):
4450 * frame.c (syms_of_frame):
4451 * fringe.c (syms_of_fringe):
4452 * insdel.c (syms_of_insdel):
4453 * keymap.c (syms_of_keymap):
4454 * lread.c (init_obarray, syms_of_lread):
4455 * macros.c (syms_of_macros):
4456 * msdos.c (syms_of_msdos):
4457 * print.c (syms_of_print):
4458 * process.c (syms_of_process):
4459 * search.c (syms_of_search):
4460 * sound.c (syms_of_sound):
4461 * syntax.c (init_syntax_once, syms_of_syntax):
4462 * terminal.c (syms_of_terminal):
4463 * textprop.c (syms_of_textprop):
4464 * undo.c (syms_of_undo):
4465 * w32.c (globals_of_w32):
4466 * window.c (syms_of_window):
4467 * xdisp.c (syms_of_xdisp):
4468 * xfaces.c (syms_of_xfaces):
4469 * xfns.c (syms_of_xfns):
4470 * xmenu.c (syms_of_xmenu):
4471 * xsettings.c (syms_of_xsettings):
4472 * xterm.c (syms_of_xterm): Use DEFSYM.
4473
4228cf16
TZ
44742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4475
cd3520a4 4476 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4477
7fcccf1e
PE
44782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4479
7efb4e0e
PE
4480 Integer and buffer overflow fixes (Bug#8873).
4481
ff5844ad
PE
4482 * print.c (printchar, strout): Check for string overflow.
4483 (PRINTPREPARE, printchar, strout):
4484 Don't set size unless allocation succeeds.
4485
90532f02
PE
4486 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4487 for sizes. Check for string overflow more accurately.
4488 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4489
6d84508d
PE
4490 * macros.c: Integer and buffer overflow fixes.
4491 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4492 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4493 Use ptrdiff_t, not int, for sizes.
4494 Don't increment bufsize until after realloc succeeds.
4495 Check for size-calculation overflow.
4496 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4497
437b2cb4
PE
4498 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4499
8b9ac8b4
PE
4500 * lread.c: Integer overflow fixes.
4501 (read_integer): Radix is now EMACS_INT, not int,
4502 to improve quality of diagnostics for out-of-range radices.
4503 Calculate buffer size correctly for out-of-range radices.
4504 (read1): Check for integer overflow in radices, and in
4505 read-circle numbers.
82cb60d3
PE
4506 (read_escape): Avoid int overflow.
4507 (Fload, openp, read_buffer_size, read1)
4508 (substitute_object_recurse, read_vector, read_list, map_obarray):
4509 Use ptrdiff_t, not int, for sizes.
4510 (read1): Use EMACS_INT, not int, for sizes.
20270765 4511 Check for size overflow.
8b9ac8b4 4512
7fcccf1e
PE
4513 * image.c (cache_image): Check for size arithmetic overflow.
4514
bfbbd7e7
PE
4515 * lread.c: Integer overflow issues.
4516 (saved_doc_string_size, saved_doc_string_length)
4517 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4518 Now ptrdiff_t, not int.
4519 (read1): Don't assume doc string length fits in int. Check for
4520 out-of-range doc string lengths.
4521 (read_list): Don't assume file position fits in int.
39019e54 4522 (read_escape): Check for hex character overflow.
bfbbd7e7 4523
4e323265
LL
45242011-06-22 Leo Liu <sdl.web@gmail.com>
4525
4526 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4527 Move to minibuffer.el.
4528
85fece3e
PE
45292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4530
20b84ce9 4531 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4532 The following patches are for when GLYPH_DEBUG && !XASSERT.
4533 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4534 * dispnew.c (flush_stdout):
4535 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4536 Mark as externally visible.
4537 * dispnew.c (check_window_matrix_pointers): Now static.
4538 * dispnew.c (window_to_frame_vpos):
4539 * xfns.c (unwind_create_frame):
4540 * xterm.c (x_check_font): Remove unused local.
4541 * scroll.c (CHECK_BOUNDS):
4542 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4543 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4544 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4545 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4546 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4547 Now static.
4548 (debug_method_add): Use va_list and vsprintf rather than relying
4549 on undefined behavior with wrong number of arguments.
4550 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4551 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4552 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4553 since we're not interested in debugging glyphs with old libraries.
4554 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4555 GCC 4.6.0's static checking.
4556
0766b489
PE
45572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4558
31fd4b32
PE
4559 Integer overflow and signedness fixes (Bug#8873).
4560 A few related buffer overrun fixes, too.
4561
b79e8648
PE
4562 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4563
0766b489
PE
4564 * dispextern.h (struct face.stipple):
4565 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4566 (x_bitmap_mask, x_allocate_bitmap_record)
4567 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4568 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4569 (x_create_bitmap_from_xpm_data):
4570 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4571 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4572 (.bitmaps_last):
4573 * xfaces.c (load_pixmap):
4574 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4575 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4576 (.bitmaps_last, struct x_output.icon_bitmap):
4577 Use ptrdiff_t, not int, for bitmap indexes.
4578 (x_allocate_bitmap_record): Check for size overflow.
4579 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4580
b081724f
PE
4581 Use ptrdiff_t, not int, for overlay counts.
4582 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4583 * editfns.c (overlays_around, get_pos_property):
4584 * textprop.c (get_char_property_and_overlay):
4585 * xdisp.c (next_overlay_change, note_mouse_highlight):
4586 * xfaces.c (face_at_buffer_position):
21514da7
PE
4587 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4588 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4589 (Fnext_overlay_change, Fprevious_overlay_change)
4590 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4591 Use ptrdiff_t, not int, for sizes.
21514da7 4592 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4593
3de73e5e
PE
4594 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4595
2606c57b
PE
4596 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4597 (x_session_initialize): Do not assume string length fits in int.
4598
aaafe47a
PE
4599 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4600 This is unlikely, but can occur if DPI is outlandish.
4601
2674ddc8 4602 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4603 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4604
28154962
PE
4605 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4606 * xrdb.c (magic_file_p, search_magic_path):
4607 Omit last arg SUFFIX; it was always 0. All callers changed.
4608 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4609
7de51af5
PE
4610 * xfont.c (xfont_match): Avoid need for strlen.
4611
25ed6cc3
PE
4612 * xfns.c: Don't assume strlen fits in int.
4613 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4614
4eab31dd
PE
4615 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4616 not unsigned long, as we prefer signed integers. All callers changed.
4617 Detect integer overflow in repeat count.
4618 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4619 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4620
171e2a58
PE
4621 * termcap.c: Don't assume sizes fit in int and never overflow.
4622 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4623 (gobble_line): Check for size-calculation overflow.
4624
ad39faca 4625 * minibuf.c (Fread_buffer):
6e5bb2dc 4626 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4627 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4628 Don't assume string length fits in int.
4629
52c61c22 4630 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4631 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4632
b5b8c9e5
PE
4633 * font.c: Don't assume string length fits in int.
4634 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4635 Use ptrdiff_t, not int.
ccd6111c
PE
4636 (font_intern_prop): Don't assume string length fits in int.
4637 Don't assume integer property fits in fixnum.
4638 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4639
882f0d81 4640 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4641 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4642 Reformulate so as not to need the command string.
4643 Invoke gzip -cd rather than gunzip, as it's more portable.
4644 (lock_info_type, lock_file_1, lock_file):
4645 Don't assume pid_t and time_t fit in unsigned long.
4646 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4647 (current_lock_owner): Prefer signed type for sizes.
4648 Use memcpy, not strncpy, where memcpy is what is really wanted.
4649 Don't assume (via atoi) that time_t and pid_t fit in int.
4650 Check for time_t and/or pid_t out of range, e.g., via a network share.
4651 Don't alloca where an auto var works fine.
4652
93f4cf88
PE
4653 * fileio.c: Fix some integer overflow issues.
4654 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4655 Don't assume string length fits in int.
4656 (directory_file_name): Don't assume string length fits in long.
4657 (make_temp_name): Don't assume pid fits in int, or that its print
4658 length is less than 20.
4659
f3e92b69
PE
4660 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4661
1bfdaf10
PE
4662 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4663
35016e9a
PE
4664 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4665
3d1e65a1
PE
4666 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4667 We prefer signed integers, even for size calculations.
4668
0b963a93
PE
4669 * emacs.c: Don't assume string length fits in 'int'.
4670 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4671 (main): Don't invoke strlen when not needed.
4672
573f4b54
PE
4673 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4674 (XD_DEBUG_MESSAGE): Don't waste a byte.
4675
989f33ba
PE
4676 * callproc.c (getenv_internal_1, getenv_internal)
4677 (Fgetenv_internal):
965d34eb
PE
4678 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4679
e4d29b33
PE
4680 * lread.c (invalid_syntax): Omit length argument.
4681 All uses changed. This doesn't fix a bug, but it simplifies the
4682 code away from its former Hollerith-constant appearance, and it's
4683 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4684 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4685
eb49b136
PE
4686 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4687 This didn't break anything, but it didn't help either.
4688 It's confusing to put a bogus integer in a place where the actual
4689 value does not matter.
9f62aeb1 4690 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4691 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4692
15375a22
PE
4693 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4694 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4695 implementation.
b61cc01c
PE
4696 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4697 We prefer signed types, and the value cannot exceed the EMACS_INT
4698 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4699 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4700 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4701 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4702
53b2623d
PE
4703 * indent.c (sane_tab_width): New function.
4704 (current_column, scan_for_column, Findent_to, position_indentation)
4705 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4706 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4707
51cab52b 4708 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4709
f2ed8a70
PE
4710 * lisp.h (lint_assume): New macro.
4711 * composite.c (composition_gstring_put_cache):
4712 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4713
abe80cc6
PE
4714 * editfns.c, insdel.c:
4715 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4716
b02c740e
PE
4717 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4718
ebc96716
PE
4719 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4720
b4e50fa0 4721 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4722 Use much-faster test for byte-length change.
311d5d7c 4723 Don't assume string byte-length fits in 'int'.
a4cf38e4 4724 Check that character arg fits in 'int'.
85461888 4725 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4726
c0c1ee9f
PE
4727 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4728
a498d7f4
PE
4729 * fns.c (concat): Catch string overflow earlier.
4730 Do not rely on integer wraparound.
4731
51cab52b
PE
4732 * dispextern.h (struct it.overlay_strings_charpos)
4733 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4734 * xdisp.c (forward_to_next_line_start)
4735 (back_to_previous_visible_line_start)
4736 (reseat_at_next_visible_line_start, next_element_from_buffer):
4737 Don't arbitrarily truncate the value of 'selective' to int.
4738
76031fad
PE
4739 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4740
5eb55db9
PE
4741 * composite.c: Don't truncate sizes to 'int'.
4742 (composition_gstring_p, composition_reseat_it)
4743 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4744 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4745 not EMACS_UINT, for indexes.
5eb55db9 4746
0703a717
PE
4747 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4748
d6202519
PE
4749 * buffer.c: Include <verify.h>.
4750 (struct sortvec.priority, struct sortstr.priority):
8961a454 4751 Now EMACS_INT, not int.
c20998a7 4752 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4753 (struct sortstr.size, record_overlay_string)
4754 (struct sortstrlist.size, struct sortlist.used):
4755 Don't truncate size to int.
4756 (record_overlay_string): Check for size-calculation overflow.
d6202519 4757 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4758
d5a19415
JM
47592011-06-22 Jim Meyering <meyering@redhat.com>
4760
029529ac 4761 Don't leak an XBM-image-sized buffer
d5a19415
JM
4762 * image.c (xbm_load): Free the image buffer after using it.
4763
a9041e6c
PE
47642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4765
4766 Port to Sun C.
4767 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4768 that Sun C diagnosed.
4769 * fns.c (secure_hash): Fix pointer signedness issue.
4770 * intervals.c (static_offset_intervals): New function.
4771 (offset_intervals): Use it.
4772
7f3f739f
LL
47732011-06-21 Leo Liu <sdl.web@gmail.com>
4774
4775 * deps.mk (fns.o):
4776 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4777 sha512.h.
4778
4779 * fns.c (secure_hash): Rename from crypto_hash_function and change
4780 the first arg to accept symbols.
5b66d427 4781 (Fsecure_hash): New primitive.
7f3f739f
LL
4782 (syms_of_fns): New symbols.
4783
76147d94
DD
47842011-06-20 Deniz Dogan <deniz@dogan.se>
4785
4786 * process.c (Fset_process_buffer): Clarify return value in
4787 docstring.
4788
7d7d0045
CY
47892011-06-18 Chong Yidong <cyd@stupidchicken.com>
4790
4791 * dispnew.c (add_window_display_history): Use BVAR.
4792
4793 * xdisp.c (debug_method_add): Use BVAR.
4794 (check_window_end, dump_glyph_matrix, dump_glyph)
4795 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4796
4797 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4798 Likewise.
4799
4800 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4801 check till after the cache is created in init_frame_faces.
4802
ff2bc410
SM
48032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4804
4805 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4806
28177add
PE
48072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4808
dd3482fe
PE
4809 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4810 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4811 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4812
393d71f3 4813 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4814 * fileio.c (Finsert_file_contents):
4815 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4816 Remove the old (too-loose) buffer overflow checks.
4817 They weren't needed, since make_gap checks for buffer overflow.
4818 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4819 The old code merely checked for Emacs fixnum overflow, and relied
4820 on undefined (wraparound) behavior. The new code avoids undefined
4821 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4822
2e6813b0 4823 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4824 Tune. Don't use wider integers than needed. Don't use alloca.
4825 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4826
599a9e4f
PE
4827 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4828
99561444
PE
4829 * insdel.c, lisp.h (buffer_overflow): New function.
4830 (insert_from_buffer_1, replace_range, replace_range_2):
4831 * insdel.c (make_gap_larger):
4832 * editfns.c (Finsert_char):
4833 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4834
28177add
PE
4835 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4836
e69dafad
PE
48372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4838
4baa020d 4839 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4840
b1c46f02
PE
4841 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4842 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4843
e69dafad
PE
4844 * fileio.c: Don't assume EMACS_INT fits in off_t.
4845 (emacs_lseek): New static function.
4846 (Finsert_file_contents, Fwrite_region): Use it.
4847 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4848
566684ea
PE
4849 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4850
e6966cd6
PE
4851 * fns.c: Don't overflow int when computing a list length.
4852 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4853 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4854 truncation on 64-bit hosts. Check for QUIT every
4855 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4856 faster and is responsive enough.
4857 (Flength): Report an error instead of overflowing an integer.
4858 (Fsafe_length): Return a float if the value is not representable
4859 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4860 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4861 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4862
dd0b0efb
PE
4863 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4864 (header_size, word_size): New constants.
4865 (allocate_vectorlike): Don't check size overflow here.
4866 (allocate_vector): Check it here instead, since this is the only
4867 caller of allocate_vectorlike that could cause overflow.
4868 Check that the new vector's length is representable as a fixnum.
4869
86fe5cfe
PE
4870 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4871 The previous code was bogus. For example, next_almost_prime (32)
4872 returned 39, which is undesirable as it is a multiple of 3; and
4873 next_almost_prime (24) returned 25, which is a multiple of 5 so
4874 why was the code bothering to check for multiples of 7?
4875
80e88859
PE
4876 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4877
4a2f0ad6
PE
4878 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4879
f66c7cf8
PE
4880 Variadic C functions now count arguments with ptrdiff_t.
4881 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4882 Back then I didn't know that the Emacs coding style prefers signed int.
4883 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4884 were being counted with int, which may truncate counts on 64-bit
4885 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4886 * lisp.h (struct Lisp_Subr.function.aMANY)
4887 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4888 Arg counts are now ptrdiff_t, not size_t.
4889 All variadic functions and their callers changed accordingly.
4890 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4891 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4892 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4893 * callint.c (Fcall_interactively): Check arg count for overflow,
4894 to avoid potential buffer overrun. Use signed char, not 'int',
4895 for 'varies' array, so that we needn't bother to check its size
4896 calculation for overflow.
4897 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4898 * eval.c (apply_lambda):
4899 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4900 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4901 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4902
a1759b76
PE
4903 * callint.c (Fcall_interactively): Don't use index var as event count.
4904
d96be9fc
PE
4905 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4906 * mem-limits.h (SIZE): Remove; no longer used.
4907
a690a978 4908 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4909
578c21e6
PE
4910 Remove unnecessary casts.
4911 * xterm.c (x_term_init):
4912 * xfns.c (x_set_border_pixel):
4913 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4914 These aren't needed now that we assume ANSI C.
4915
96f53c6c
PE
4916 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4917 It's more likely to cause problems (due to unsigned overflow)
4918 than to cure them.
4919
83c77d31
PE
4920 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4921
ee2079f1
PE
4922 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4923
6da65536
PE
4924 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4925
7147c4a4
PE
4926 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4927
193e32d9
PE
4928 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4929
e5533da6
PE
4930 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4931
9910e595
PE
4932 GLYPH_CODE_FACE returns EMACS_INT, not int.
4933 * dispextern.h (merge_faces):
4934 * xfaces.c (merge_faces):
01103c44
PE
4935 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4936 Don't assume EMACS_INT fits in int.
9910e595 4937
2638320e
PE
4938 * character.h (CHAR_VALID_P): Remove unused parameter.
4939 * fontset.c, lisp.h, xdisp.c: All uses changed.
4940
045eb8d9
PE
4941 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4942
c1f134b5
PE
4943 * fns.c (concat): Minor tuning based on overflow analysis.
4944 This doesn't fix any bugs. Use int to hold character, instead
4945 of constantly refetching from Emacs object. Use XFASTINT, not
4946 XINT, for value known to be a character. Don't bother comparing
4947 a single byte to 0400, as it's always less.
4948
395fcb93 4949 * floatfns.c (Fexpt):
327eeec8
PE
4950 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4951
abbd3d23
PE
4952 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4953 for characters.
4954
684a03ef
PE
4955 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4956
0fed43f3
PE
4957 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4958 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4959 incorrectly succeed when S was a string, because 4294967386 was
4960 truncated before it was used.
4961
8fd02eb7
PE
4962 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4963 Otherwise, an out-of-range integer could cause undefined behavior
4964 on a 64-bit host.
4965
f8c86b69
PE
4966 * composite.c: Use int, not EMACS_INT, for characters.
4967 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4968 EMACS_INT, for values that are known to be in character range.
4969 This doesn't fix any bugs but is the usual style inside Emacs and
4970 may generate better code on 32-bit machines.
4971
34206dd2
PE
4972 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4973 This is for reasons similar to the recent CHAR_STRING fix.
4974 * charset.c (Fencode_char): Check that character arg is actually
4975 a character. Pass an int to ENCODE_CHAR.
4976 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4977 wider than 'int', as a compile-time check to prevent future regressions
4978 in this area.
4979
c5958d4c 4980 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4981
4982 Make sure a 64-bit char is never passed to CHAR_STRING.
4983 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4984 by silently ignoring the top 32 bits, allowing some values
4985 that were far too large to be valid characters.
4986 * character.h: Include <verify.h>.
4987 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4988 arguments are no wider than unsigned, as a compile-time check
4989 to prevent future regressions in this area.
4990 * data.c (Faset):
01103c44 4991 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4992 (Fsubst_char_in_region):
4993 * fns.c (concat):
4994 * xdisp.c (decode_mode_spec_coding):
4995 Adjust to CHAR_STRING's new requirement.
4996 * editfns.c (Finsert_char, Fsubst_char_in_region):
4997 * fns.c (concat): Check that character args are actually
4998 characters. Without this test, these functions did the wrong
4999 thing with wildly out-of-range values on 64-bit hosts.
5000
d37ca623
PE
5001 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5002 These casts should not be needed on 32-bit hosts, either.
5003 * keyboard.c (read_char):
5004 * lread.c (Fload): Remove casts to unsigned.
5005
ea204efb
PE
5006 * lisp.h (UNSIGNED_CMP): New macro.
5007 This fixes comparison bugs on 64-bit hosts.
5008 (ASCII_CHAR_P): Use it.
5009 * casefiddle.c (casify_object):
01103c44 5010 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5011 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5012 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5013 * dispextern.h (FACE_FROM_ID):
5014 * keyboard.c (read_char): Use UNSIGNED_CMP.
5015
41cb286c
PE
5016 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5017 not to EMACS_INT, to avoid GCC warning.
5018
4a1b9832
PE
5019 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5020
55daad71
PE
5021 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5022 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5023 isn't needed on 32-bit machines.
8f95c75c 5024
01103c44
PE
5025 * buffer.c (Fgenerate_new_buffer_name):
5026 Use EMACS_INT for count, not int.
0ceccced 5027 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5028
5029 * data.c (Qcompiled_function): Now static.
5030
c6f072e7
PE
5031 * window.c (window_body_lines): Now static.
5032
20ce5912
PE
5033 * image.c (gif_load): Rename local to avoid shadowing.
5034
9c4c5f81
PE
5035 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5036 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5037 * alloc.c (make_save_value): Integer argument is now of type
5038 ptrdiff_t, not int.
5039 (mark_object): Use ptrdiff_t, not int.
5040 * lisp.h (pD): New macro.
5041 * print.c (print_object): Use it.
5042
c0c5c8ae
PE
5043 * alloc.c: Use EMACS_INT, not int, to count objects.
5044 (total_conses, total_markers, total_symbols, total_vector_size)
5045 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5046 (total_free_floats, total_floats, total_free_intervals)
5047 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5048 Now EMACS_INT, not int. All uses changed.
5049 (Fgarbage_collect): Compute overall total using a double, so that
5050 integer overflow is less likely to be a problem. Check for overflow
5051 when converting back to an integer.
5a25e253
PE
5052 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5053 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5054 These were 'int' variables that could overflow on 64-bit hosts;
5055 they were never used, so remove them instead of repairing them.
211a0b2a 5056 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5057 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5058 Previously, this ceilinged at INT_MAX, but that doesn't work on
5059 64-bit machines.
e46bb31a 5060 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5061
c78baabf 5062 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5063 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5064 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5065 when a (possibly-narrower) signed value would do just as well.
5066 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5067
c9d624c6
PE
5068 * alloc.c: Catch some string size overflows that we were missing.
5069 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5070 for convenience in STRING_BYTES_MAX.
5071 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5072 The definition here is exact; the one in lisp.h was approximate.
5073 (allocate_string_data): Check for string overflow. This catches
5074 some instances we weren't catching before. Also, it catches
5075 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5076 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5077 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5078
c9d624c6
PE
5079 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5080 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5081 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5082
353032ce
PE
5083 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5084
2bccce07
PE
5085 * alloc.c (Fmake_string): Check for out-of-range init.
5086
0ac30604
SM
50872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5088
5089 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5090
c195f2de
JD
50912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5092
5093 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5094 xg_get_default_scrollbar_width.
5095
5096 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5097 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5098 (style_changed_cb): Call update_theme_scrollbar_width and call
5099 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5100 all frames (Bug#8505).
5101 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5102 Call gtk_window_set_resizable if HAVE_GTK3.
5103 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5104 and height if HAVE_GTK3 (Bug#8505).
5105 (scroll_bar_width_for_theme): New variable.
5106 (update_theme_scrollbar_width): New function.
5107 (xg_get_default_scrollbar_width): Move code to
5108 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5109 (xg_initialize): Call update_theme_scrollbar_width.
5110
5111 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5112
5113 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5114
e10ac9f1
MR
51152011-06-12 Martin Rudalics <rudalics@gmx.at>
5116
5117 * frame.c (make_frame): Call other_buffer_safely instead of
5118 other_buffer.
5119
5120 * window.c (temp_output_buffer_show): Call display_buffer with
5121 second argument Vtemp_buffer_show_specifiers and reset latter
5122 immediately after the call.
5123 (Vtemp_buffer_show_specifiers): New variable.
5124 (auto_window_vscroll_p, next_screen_context_lines)
5125 (Vscroll_preserve_screen_position): Remove leading asterisks from
5126 doc-strings.
5127
2d3c217e 51282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5129
7b7f97e8 5130 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5131 * buffer.c (Qclone_number): Remove for now, as it's unused.
5132 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5133 (record_buffer): Remove unused local.
5134 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5135 (set_frame_buffer_list): Remove; unused.
5136 * frame.h (other_visible_frames): Remove decl.
5137 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5138 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5139 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5140 if HAVE_GPM.
5141 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5142 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5143 Define only if HAVE_GPM.
5144 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5145 (update_hints_inhibit): Remove; never set. All uses removed.
5146 * widgetprv.h (emacsFrameClassRec): Remove decl.
5147 * window.c (delete_deletable_window): Now returns void, since it
5148 wasn't returning anything.
5149 (compare_window_configurations): Remove unused locals.
5150 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5151 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5152 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5153 the same widths as pointers. This follows up on the 2011-05-06 patch.
5154 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5155 * xterm.h: Likewise.
5156 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5157
1384b89e
JB
51582011-06-12 Juanma Barranquero <lekktu@gmail.com>
5159
5160 * makefile.w32-in: Update dependencies.
5161 (LISP_H): Add lib/intprops.h.
5162
1100a63c
CY
51632011-06-11 Chong Yidong <cyd@stupidchicken.com>
5164
5165 * image.c (gif_load): Add animation frame delay to the metadata.
5166 (syms_of_image): Use DEFSYM. New symbol `delay'.
5167
6198ccd0
MR
51682011-06-11 Martin Rudalics <rudalics@gmx.at>
5169
5170 * window.c (delete_deletable_window): Re-add.
5171 (Fset_window_configuration): Rewrite to handle dead buffers and
5172 consequently deletable windows.
5173 (window_tree, Fwindow_tree): Remove. Supply functionality in
5174 window.el.
5175 (compare_window_configurations): Simplify code.
5176
b6e3633c
AS
51772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5178
1ab0dee5
AS
5179 * image.c (imagemagick_load_image): Fix type mismatch.
5180 (Fimagemagick_types): Likewise.
5181
b6e3633c
AS
5182 * window.h (replace_buffer_in_windows): Declare.
5183
9397e56f
MR
51842011-06-11 Martin Rudalics <rudalics@gmx.at>
5185
5186 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5187 Qclone_number. Remove external declaration of Qdelete_window.
5188 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5189 code.
640c8776
SM
5190 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5191 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5192 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5193 buffer list implementation.
5194 (other_buffer_safely): New function.
5195 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5196 calls to replace_buffer_in_windows and
5197 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5198 if allowed.
5199 (record_buffer): Inhibit quitting and rewrite using quittable
5200 functions. Run Qbuffer_list_update_hook if allowed.
5201 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5202 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5203 Move switch-to-buffer to window.el.
9397e56f
MR
5204 (bury-buffer): Move to window.el.
5205 (Vbuffer_list_update_hook): New variable.
5206
5207 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5208 section.
5209
5210 * window.h (resize_frame_windows): Move up in code.
5211 (Fwindow_frame): Remove EXFUN.
5212 (replace_buffer_in_all_windows): Remove prototype.
5213 (replace_buffer_in_windows_safely): Add prototype.
5214
5215 * window.c: Declare Qdelete_window static again. Move down
5216 declaration of select_count.
5217 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5218 (Fother_window): Move to window.el.
5219 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5220 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5221 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5222 window.el.
5223 (replace_buffer_in_windows): Implement by calling
5224 Qreplace_buffer_in_windows.
5225 (replace_buffer_in_all_windows): Remove with some functionality
5226 moved into replace_buffer_in_windows_safely.
5227 (replace_buffer_in_windows_safely): New function.
5228 (select_window_norecord, select_frame_norecord): Move in front
5229 of run_window_configuration_change_hook. Remove now obsolete
5230 declarations.
640c8776
SM
5231 (Fset_window_buffer): Rewrite doc-string.
5232 Call Qrecord_window_buffer.
9397e56f
MR
5233 (keys_of_window): Move binding for other-window to window.el.
5234
b50691aa
CY
52352011-06-11 Chong Yidong <cyd@stupidchicken.com>
5236
5237 * dispextern.h (struct image): Replace data member, whose int_val
5238 and ptr_val fields were not used by anything, with a single
5239 lisp_val object.
5240
5241 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5242 (gif_clear_image, gif_load, imagemagick_load_image)
5243 (gs_clear_image, gs_load): Callers changed.
5244
3f754b86
PE
52452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5246
cca69397
PE
5247 * buffer.h: Include <time.h>, for time_t.
5248 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5249
109e28d0
PE
5250 Fix minor problems found by static checking.
5251
60737f02
PE
5252 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5253
4b66faf3
PE
5254 Make identifiers static if they are not used in other modules.
5255 * data.c (Qcompiled_function, Qframe, Qvector):
5256 * image.c (QimageMagick, Qsvg):
5257 * minibuf.c (Qmetadata):
5258 * window.c (resize_window_check, resize_root_window): Now static.
5259 * window.h (resize_window_check, resize_root_window): Remove decls.
5260
109e28d0
PE
5261 * window.c (window_deletion_count, delete_deletable_window):
5262 Remove; unused.
46a4ce9e
PE
5263 (window_body_lines): Now static.
5264 (Fdelete_other_windows_internal): Mark vars as initialized.
5265 Make sure 'resize_failed' is initialized.
5266 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5267 (resize_window_apply): Remove unused local.
5268 * window.h (delete_deletable_window): Remove decl.
5269
109e28d0 5270 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5271 (imagemagick_load_image): Fix pointer signedness problem by changing
5272 last arg from unsigned char * to char *. All uses changed.
5273 Also, fix a local for similar reasons.
5274 Remove unused locals. Remove locals to avoid shadowing.
5275 (fn_rsvg_handle_free): Remove; unused.
5276 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5277 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5278
3f754b86
PE
5279 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5280
2547adb1
CY
52812011-06-10 Chong Yidong <cyd@stupidchicken.com>
5282
5283 * image.c (gif_load): Fix omitted cast error introduced by
5284 2011-06-06 change.
5285
2c8e37d4
MR
52862011-06-10 Martin Rudalics <rudalics@gmx.at>
5287
5288 * window.h (resize_proportionally, orig_total_lines)
5289 (orig_top_line): Remove from window structure.
5290 (set_window_height, set_window_width, change_window_heights)
5291 (Fdelete_window): Remove prototypes.
5292 (resize_frame_windows): Remove duplicate declaration.
5293
440a42e3
EZ
52942011-06-10 Eli Zaretskii <eliz@gnu.org>
5295
5296 * window.h (resize_frame_windows, resize_window_check)
5297 (delete_deletable_window, resize_root_window)
5298 (resize_frame_windows): Declare prototypes.
5299
5300 * window.c (resize_window_apply): Make definition be "static" to
5301 match the prototype.
5302
562dd5e9
MR
53032011-06-10 Martin Rudalics <rudalics@gmx.at>
5304
5305 * window.c: Remove declarations of Qwindow_size_fixed,
5306 window_min_size_1, window_min_size_2, window_min_size,
5307 size_window, window_fixed_size_p, enlarge_window, delete_window.
5308 Remove static from declaration of Qdelete_window, it's
5309 temporarily needed by Fbury_buffer.
5310 (replace_window): Don't assign orig_top_line and
5311 orig_total_lines.
5312 (Fdelete_window, delete_window): Remove. Window deletion is
5313 handled by window.el.
640c8776
SM
5314 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5315 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5316 (Fdelete_other_windows): Remove. Deleting other windows is
5317 handled by window.el.
5318 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5319 handled in window.el.
5320 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5321 Window minimum sizes are handled in window.el.
5322 (shrink_windows, size_window, set_window_height)
5323 (set_window_width, change_window_heights, window_height)
5324 (window_width, CURBEG, CURSIZE, enlarge_window)
5325 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5326 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5327 handled in window.el.
5328 (make_dummy_parent): Rename to make_parent_window and give it a
5329 second argument horflag.
5330 (make_window): Don't set resize_proportionally any more.
5331 (Fsplit_window): Remove. Windows are split in window.el.
5332 (save_restore_action, save_restore_orig_size)
5333 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5334 Resize mini windows in window.el.
5335 (grow_mini_window, shrink_mini_window): Implement by calling
5336 Qresize_root_window_vertically, resize_window_check and
5337 resize_window_apply.
640c8776
SM
5338 (saved_window, Fset_window_configuration, save_window_save):
5339 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5340 resize_proportionally.
5341 (window_min_height, window_min_width): Move to window.el.
5342 (keys_of_window): Move bindings for delete-other-windows,
5343 split-window, delete-window and enlarge-window to window.el.
5344
5345 * buffer.c: Temporarily extern Qdelete_window.
5346 (Fbury_buffer): Temporarily call Qdelete_window instead of
5347 Fdelete_window (Fbury_buffer will move to window.el soon).
5348
5349 * frame.c (set_menu_bar_lines_1): Remove code handling
5350 orig_top_line and orig_total_lines.
5351
5352 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5353 set_window_height but set heights directly.
5354 (change_frame_size_1): Use resize_frame_windows.
5355
5356 * xdisp.c (init_xdisp): Don't use set_window_height but set
5357 heights directly.
5358
640c8776
SM
5359 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5360 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5361 run_window_configuration_change_hook.
5362
5363 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5364 instead of change_window_heights and run
5365 run_window_configuration_change_hook.
5366
1a13852e
MR
53672011-06-09 Martin Rudalics <rudalics@gmx.at>
5368
5369 * window.c (replace_window): Rename second argument REPLACEMENT to
5370 NEW. New third argument SETFLAG. Rewrite.
5371 (delete_window, make_dummy_parent): Call replace_window with
5372 third argument 1.
5373 (window_list_1): Move down in code.
5374 (run_window_configuration_change_hook): Move set_buffer part
5375 before select_frame_norecord part in order to unwind correctly.
5376 Rename count1 to count.
5377 (recombine_windows, delete_deletable_window, resize_root_window)
5378 (Fdelete_other_windows_internal)
5379 (Frun_window_configuration_change_hook, make_parent_window)
5380 (resize_window_check, resize_window_apply, Fresize_window_apply)
5381 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5382 (Fdelete_window_internal, Fresize_mini_window_internal):
5383 New functions.
1a13852e
MR
5384 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5385
f3d1777e
MR
53862011-06-08 Martin Rudalics <rudalics@gmx.at>
5387
496e208e
MR
5388 * window.h (window): Add some new members to window structure -
5389 normal_lines, normal_cols, new_total, new_normal, clone_number,
5390 splits, nest, prev_buffers, next_buffers.
5391 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5392 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5393
f3d1777e
MR
5394 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5395 Remove.
496e208e
MR
5396 (make_dummy_parent): Set new members of windows structure.
5397 (make_window): Move down in code. Handle new members of window
5398 structure.
5399 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5400 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5401 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5402 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5403 (Fset_window_next_buffers, Fset_window_clone_number):
5404 New functions.
496e208e
MR
5405 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5406 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5407 Doc-string fixes.
5408 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5409 Argument WINDOW can be now internal window too.
5410 (Fwindow_use_time): Move up in code.
5411 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5412 Rewrite doc-string.
5413 (Fset_window_configuration, saved_window)
5414 (Fcurrent_window_configuration, save_window_save): Handle new
5415 members of window structure.
b9e809c2
MR
5416 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5417 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5418 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5419 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5420 Qget_mru_window, Qresize_root_window,
5421 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5422 Qauto_buffer_name; staticpro them.
f3d1777e 5423
abde8f8c
MR
54242011-06-07 Martin Rudalics <rudalics@gmx.at>
5425
5426 * window.c (Fwindow_total_size, Fwindow_left_column)
5427 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5428 (Fwindow_list_1): New functions.
5429 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5430 (Fwindow_width, Fscroll_left, Fscroll_right):
5431 Use window_body_cols instead of window_box_text_cols.
5432 (delete_window, Fset_window_configuration):
5433 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5434 (delete_all_subwindows): Take a window as argument and not a
5435 structure. Rewrite.
190b47e6
MR
5436 (window_loop): Remove handling of GET_LRU_WINDOW and
5437 GET_LARGEST_WINDOW.
5438 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5439
5440 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5441 window_box_text_cols. delete_all_subwindows now takes a
5442 Lisp_Object as argument.
abde8f8c 5443
640c8776
SM
5444 * indent.c (compute_motion, Fcompute_motion):
5445 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5446
fa8a67e6
MR
5447 * frame.c (delete_frame): Call delete_all_subwindows with root
5448 window as argument.
5449
a54e3482
DC
54502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5451
5452 * fns.c (Fputhash): Document return value.
5453
60002bf5
CY
54542011-06-06 Chong Yidong <cyd@stupidchicken.com>
5455
5456 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5457
0c671da6 54582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5459
b862a52a 5460 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5461
be44ca6c
PE
5462 Check for overflow when converting integer to cons and back.
5463 * charset.c (Fdefine_charset_internal, Fdecode_char):
5464 Use cons_to_unsigned to catch overflow.
5465 (Fencode_char): Use INTEGER_TO_CONS.
5466 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5467 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5468 * data.c (long_to_cons, cons_to_long): Remove.
5469 (cons_to_unsigned, cons_to_signed): New functions.
5470 These signal an error for invalid or out-of-range values.
5471 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5472 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5473 * font.c (Ffont_variation_glyphs):
5474 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5475 * lisp.h: Include <intprops.h>.
5476 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5477 (cons_to_signed, cons_to_unsigned): New decls.
5478 (long_to_cons, cons_to_long): Remove decls.
5479 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5480 (Fprimitive_undo): Use CONS_TO_INTEGER.
5481 * xfns.c (Fx_window_property): Likewise.
5482 * xselect.c: Include <limits.h>.
5483 (x_own_selection, selection_data_to_lisp_data):
5484 Use INTEGER_TO_CONS.
5485 (x_handle_selection_request, x_handle_selection_clear)
5486 (x_get_foreign_selection, Fx_disown_selection_internal)
5487 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5488 (lisp_data_to_selection_data): Use cons_to_unsigned.
5489 (x_fill_property_data): Use cons_to_signed.
5490 Report values out of range.
5491
d1f3d2af
PE
5492 Check for buffer and string overflow more precisely.
5493 * buffer.h (BUF_BYTES_MAX): New macro.
5494 * lisp.h (STRING_BYTES_MAX): New macro.
5495 * alloc.c (Fmake_string):
5496 * character.c (string_escape_byte8):
5497 * coding.c (coding_alloc_by_realloc):
5498 * doprnt.c (doprnt):
5499 * editfns.c (Fformat):
5500 * eval.c (verror):
5501 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5502 since they may not be the same number.
5503 * editfns.c (Finsert_char):
5504 * fileio.c (Finsert_file_contents):
5505 Likewise for BUF_BYTES_MAX.
5506
dd52fcea
PE
5507 * image.c: Use ptrdiff_t, not int, for sizes.
5508 (slurp_file): Switch from int to ptrdiff_t.
5509 All uses changed.
5510 (slurp_file): Check that file size fits in both size_t (for
5511 malloc) and ptrdiff_t (for sanity and safety).
5512
7f9bbdbb
PE
5513 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5514 if b->modtime has its maximal value.
5515
dfe18f82
PE
5516 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5517
84acfcf0
PE
5518 Don't assume time_t can fit into int.
5519 * buffer.h (struct buffer.modtime): Now time_t, not int.
5520 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5521 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5522
ccd9a01a
PE
5523 Minor fixes for signed vs unsigned integers.
5524 * character.h (MAYBE_UNIFY_CHAR):
5525 * charset.c (maybe_unify_char):
5526 * keyboard.c (read_char, reorder_modifiers):
5527 XINT -> XFASTINT, since the integer must be nonnegative.
5528 * ftfont.c (ftfont_spec_pattern):
5529 * keymap.c (access_keymap, silly_event_symbol_error):
5530 XUINT -> XFASTINT, since the integer must be nonnegative.
5531 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5532 since it makes no difference and we prefer signed.
5533 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5534 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5535 nonnegative.
5536
d6d100dd
SM
55372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5538
5539 * window.h (Fwindow_frame): Declare.
5540
2b6148e4
PE
55412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5542
5543 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5544 (SPARE_MEMORY): Always define.
5545 (LARGE_REQUEST): Remove.
5546 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5547
f230ecc9
MR
55482011-06-06 Martin Rudalics <rudalics@gmx.at>
5549
727e958e
MR
5550 * lisp.h: Move EXFUNS for Fframe_root_window,
5551 Fframe_first_window and Fset_frame_selected_window to window.h.
5552
5553 * window.h: Move EXFUNS for Fframe_root_window,
5554 Fframe_first_window and Fset_frame_selected_window here from
5555 lisp.h.
5556
5557 * frame.c (Fwindow_frame, Fframe_first_window)
5558 (Fframe_root_window, Fframe_selected_window)
5559 (Fset_frame_selected_window): Move to window.c.
5560 (Factive_minibuffer_window): Move to minibuf.c.
5561 (Fother_visible_frames_p): New function.
5562
5563 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5564
f230ecc9
MR
5565 * window.c (decode_window, decode_any_window): Move up in code.
5566 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5567 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5568 (Fwindow_buffer): Move up and rewrite doc-string.
5569 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5570 (Fwindow_prev): New functions.
727e958e
MR
5571 (Fwindow_frame): Move here from frame.c. Accept any window as
5572 argument.
5573 (Fframe_root_window, Fframe_first_window)
5574 (Fframe_selected_window): Move here from frame.c. Accept frame
5575 or arbitrary window as argument. Update doc-strings.
5576 (Fminibuffer_window): Move up in code.
5577 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5578 (Fset_frame_selected_window): Move here from frame.c.
5579 Marginal rewrite.
727e958e
MR
5580 (Fselected_window, select_window, Fselect_window): Move up in
5581 code. Minor doc-string fixes.
f230ecc9 5582
4d09bcf6
PE
55832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5584
5585 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5586 Do not assume that spare memory exists; that assumption is valid
5587 only if SYSTEM_MALLOC.
5588 (LARGE_REQUEST): New macro, so that the issue of large requests
5589 is separated from the issue of spare memory.
5590
810928a2
AS
55912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5592
172418ad
AS
5593 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5594 format. (Bug#8806)
5595
43f862f7
AS
5596 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5597
810928a2
AS
5598 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5599 before statements.
5600
a059fe24
JD
56012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5602
5603 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5604
5605 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5606
5607 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5608 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5609
989bf368
JB
56102011-06-05 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5613
4b80f674
CY
56142011-06-04 Chong Yidong <cyd@stupidchicken.com>
5615
5616 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5617 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5618 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5619 New error handlers.
4b80f674
CY
5620 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5621 Obey Vx_select_enable_clipboard_manager. Catch errors in
5622 x_clipboard_manager_save (Bug#8779).
5623 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5624 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5625
99a33b77 56262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5627
5628 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5629
99a33b77 56302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5631
5632 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5633 in the current matrix if keep_current_p is non-zero.
5634
8264569d
EZ
56352011-06-04 Eli Zaretskii <eliz@gnu.org>
5636
5637 * bidi.c (bidi_level_of_next_char): Fix last change.
5638
57f97249
EZ
56392011-06-03 Eli Zaretskii <eliz@gnu.org>
5640
fec2107c 5641 Support bidi reordering of text covered by display properties.
57f97249 5642
fec2107c
EZ
5643 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5644 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5645 (bidi_cache_search, bidi_cache_iterator_state)
5646 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5647 (bidi_level_of_next_char, bidi_move_to_visually_next):
5648 Support character positions inside a run of characters covered by a
fec2107c
EZ
5649 display string.
5650 (bidi_paragraph_init, bidi_resolve_explicit_1)
5651 (bidi_level_of_next_char): Call bidi_fetch_char and
5652 bidi_fetch_char_advance instead of FETCH_CHAR and
5653 FETCH_CHAR_ADVANCE.
5654 (bidi_init_it): Initialize new members.
5655 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5656 definitions.
5657 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5658 instead of using explicit *_CHAR codes.
d6d100dd
SM
5659 (bidi_resolve_explicit, bidi_resolve_weak):
5660 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5661 bidirectional text is supported only in multibyte buffers.
5662 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5663 it to initialize the frame_window_p member of struct bidi_it.
5664 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5665 (bidi_resolve_explicit, bidi_resolve_weak)
5666 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5667 bidi_it->nchars is non-positive.
5668 (bidi_level_of_next_char): Don't try to lookup the cache for the
5669 next/previous character if nothing is cached there yet, or if we
5670 were just reseat()'ed to a new position.
c40e2fb2 5671
0e14fe90
EZ
5672 * xdisp.c (set_cursor_from_row): Set start and stop points
5673 according to the row's direction when priming the loop that looks
5674 for the glyph on which to display cursor.
5675 (single_display_spec_intangible_p): Function deleted.
5676 (display_prop_intangible_p): Reimplement to call
5677 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5678 Accept 3 additional arguments needed by handle_display_spec.
5679 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5680 values: lists, `(when COND...)' forms, etc.
5681 (single_display_spec_string_p): Support property values that are
5682 lists with the argument STRING its top-level element.
5683 (display_prop_string_p): Fix the condition for processing a
5684 property that is a list to be consistent with handle_display_spec.
fec2107c 5685 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5686 last portion of handle_display_prop.
5687 (compute_display_string_pos): Accept additional argument
5688 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5689 value of a `display' property is a "replacing spec".
5690 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5691 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5692 the display property, but just return a value indicating whether
5693 the display property will replace the characters it covers.
5694 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5695 frame_window_p members of struct bidi_it.
d6d100dd
SM
5696 (compute_display_string_pos, compute_display_string_end):
5697 New functions.
fec2107c
EZ
5698 (push_it): Accept second argument POSITION, where pop_it should
5699 jump to continue iteration.
5700 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5701
fec2107c
EZ
5702 * keyboard.c (adjust_point_for_property): Adjust the call to
5703 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5704
5705 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5706 (bidi_init_it): Update prototypes.
5707 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5708 (compute_display_string_pos, compute_display_string_end):
5709 Declare prototypes.
fec2107c
EZ
5710 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5711 EMACS_INT.
fc6f18ce 5712
40087514 57132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5714
57f53182
PE
5715 Malloc failure behavior now depends on size of allocation.
5716 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5717 * lisp.h: Change signatures accordingly.
5718 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5719 All callers changed. (Bug#8762)
5720
5721 * gnutls.c: Use Emacs's memory allocators.
5722 Without this change, the gnutls library would invoke malloc etc.
5723 directly, which causes problems on non-SYNC_INPUT hosts, and which
5724 runs afoul of improving memory_full behavior. (Bug#8761)
5725 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5726 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5727 xfree instead of the default malloc, realloc, free.
5728 (Fgnutls_boot): No need to check for memory allocation failure,
5729 since xmalloc does that for us.
5730
ac32cd99 5731 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5732 * category.c (hash_get_category_set):
5733 * ccl.c (ccl_driver):
5734 * charset.c (Fdefine_charset_internal):
5735 * charset.h (struct charset.hash_index):
5736 * composite.c (get_composition_id, gstring_lookup_cache)
5737 (composition_gstring_put_cache):
5738 * composite.h (struct composition.hash_index):
5739 * dispextern.h (struct image.hash):
5740 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5741 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5742 (hashfn_equal, hashfn_user_defined, make_hash_table)
5743 (maybe_resize_hash_table, hash_lookup, hash_put)
5744 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5745 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5746 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5747 * image.c (make_image, search_image_cache, lookup_image)
5748 (xpm_put_color_table_h):
5749 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5750 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5751 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5752 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5753 * alloc.c (allocate_vectorlike):
5754 Check for overflow in vector size calculations.
5755 * ccl.c (ccl_driver):
5756 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5757 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5758 need to be updated by these changes.
40087514
PE
5759 * fns.c (make_hash_table, maybe_resize_hash_table):
5760 Check for integer overflow with large hash tables.
0de4bb68
PE
5761 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5762 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5763 (SXHASH_REDUCE): New macro.
5764 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5765 Use it instead of discarding useful hash info with large hash values.
5766 (sxhash_float): New function.
5767 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5768 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5769 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5770 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5771 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5772 Adjust signatures to match updated version of code.
5773 (consing_since_gc): Now EMACS_INT, since a single hash table can
5774 use more than INT_MAX bytes.
5775
698d32e2
DN
57762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5777
5778 Make it possible to build with GCC-4.6+ -O2 -flto.
5779
5780 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5781
fd6fa53f
SM
57822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5783
5784 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5785 Call minibuffer-inactive-mode.
5786
864db017
JB
57872011-05-31 Juanma Barranquero <lekktu@gmail.com>
5788
5789 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5790 Update dependencies.
5791
2ad0baf4
DN
57922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5793
5794 * data.c (init_data): Remove code for UTS, this system is not
5795 supported anymore.
5796
4fcc2638
DN
57972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5798
5799 Don't force ./temacs to start in terminal mode.
5800
5801 * frame.c (make_initial_frame): Initialize faces in all cases, not
5802 only when CANNOT_DUMP is defined.
5803 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5804
c56e0fd5
DN
58052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5806
5807 * dispnew.c (add_window_display_history): Use const for the string
5808 pointer. Remove declaration, not needed.
5809
333d54da 58102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5811
55d4c1b2 5812 Use 'inline', not 'INLINE'.
333d54da 5813 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5814 * alloc.c, fontset.c (INLINE): Remove.
5815 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5816 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5817 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5818 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5819 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5820
738db178
DN
58212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5822
5823 Make it possible to run ./temacs.
5824
5825 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5826 syms_of_callproc does the same thing. Remove test for
5827 "initialized", do it in the caller.
5828 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5829
620c53a6
SM
58302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5831
5832 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5833 (read_minibuf): Use get_minibuffer.
5834 (syms_of_minibuf): Use DEFSYM.
5835 (Qmetadata): New var.
5836 * data.c (Qbuffer): Don't make it static.
5837 (syms_of_data): Use DEFSYM.
5838
e003a292
PE
58392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5842 (CCL_CODE_MIN): New macro.
5843
ed008a6d
PE
58442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5845
3687c2ef
PE
5846 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5847
ed008a6d
PE
5848 * eval.c (Qdebug): Now static.
5849 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5850 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5851 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5852
d66c4c7c
CY
58532011-05-29 Chong Yidong <cyd@stupidchicken.com>
5854
5855 * image.c: Various fixes to ImageMagick code comments.
5856 (Fimagemagick_types): Doc fix.
5857
5fbc2025
PE
58582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5859
0196f88a
PE
5860 Minor fixes prompted by GCC 4.6.0 warnings.
5861
5862 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5863
5fbc2025
PE
5864 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5865 (x_clipboard_manager_save_all): Move extern decl to ...
5866 * xterm.h: ... here, so that it can be checked for consistency.
5867
1dd3c2d9
CY
58682011-05-29 Chong Yidong <cyd@stupidchicken.com>
5869
5870 * xselect.c (x_clipboard_manager_save_frame)
5871 (x_clipboard_manager_save_all): New functions.
5872 (Fx_clipboard_manager_save): Lisp function deleted.
5873
5874 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5875 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5876
5877 * xterm.h: Update prototype.
5878
5ba6571d
WX
58792011-05-28 William Xu <william.xwl@gmail.com>
5880
5881 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5882 exiting (Bug#8239).
5883
3eaff834
JM
58842011-05-28 Jim Meyering <meyering@redhat.com>
5885
e1900994 5886 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5887 * fns.c (to_uchar): Define.
5888 (crypto_hash_function): Use it to convert some newly-signed
5889 variables to unsigned, to avoid sign-extension bugs. For example,
5890 without this change, (md5 "truc") would evaluate to
5891 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5892 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5893 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5894
0f6990a7
PE
58952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 Integer overflow fixes.
c8a9ca5a 5898
08686060
PE
5899 * dbusbind.c: Serial number integer overflow fixes.
5900 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5901 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5902 to hold a serial number that is too large for a fixnum.
5903 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5904 Check for serial numbers out of range. Decode any serial number
59568bf0 5905 that was so large that it became a float. (Bug#8722)
08686060 5906
2d1fc3c7
PE
5907 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5908 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5909 Use XFASTINT rather than XUINT when numbers are nonnegative.
5910 (xd_append_arg, Fdbus_method_return_internal):
5911 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5912 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5913 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5914 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5915 (Bug#8722)
2d1fc3c7 5916
c8a9ca5a
PE
5917 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5918
519e1d69
PE
5919 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5920
6df6ae42 5921 ccl: Add integer overflow checks.
30569699
PE
5922 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5923 (IN_INT_RANGE): New macros.
5924 (ccl_driver): Use them to check for integer overflow when
5925 decoding a CCL program. Many of the new checks are whether XINT (x)
5926 fits in int; it doesn't always, on 64-bit hosts. The new version
5927 doesn't catch all possible integer overflows, but it's an
847044ea 5928 improvement. (Bug#8719)
30569699 5929
c11285dc
PE
5930 * alloc.c (make_event_array): Use XINT, not XUINT.
5931 There's no need for unsigned here.
5932
fdccd48e
PE
5933 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5934 This follows up to the 2011-05-06 change that substituted uintptr_t
5935 for EMACS_INT. This case wasn't caught back then.
5936
37910ab2
PE
5937 Rework Fformat to avoid integer overflow issues.
5938 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5939 now (part of C89). Include <verify.h>.
5940 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5941 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5942 (Fformat): Avoid the prepass trying to compute sizes; it was only
5943 approximate and thus did not catch overflow reliably. Instead, walk
5944 through the format just once, formatting and computing sizes as we go,
5945 checking for integer overflow at every step, and allocating a larger
5946 buffer as needed. Keep track separately whether the format is
5947 multibyte. Keep only the most-recently calculated precision, rather
5948 than them all. Record whether each argument has been converted to
5949 string. Use EMACS_INT, not int, for byte and char and arg counts.
5950 Support field widths and precisions larger than INT_MAX. Avoid
5951 sprintf's undefined behavior with conversion specifications such as %#d
5952 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5953 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5954 formatting out-of-range floating point numbers with int
9173deec 5955 formats. (Bug#8668)
37910ab2 5956
2e6578fb
PE
5957 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5958
0ae6bdee
PE
5959 * data.c: Avoid integer truncation in expressions involving floats.
5960 * data.c: Include <intprops.h>.
5961 (arith_driver): When there's an integer overflow in an expression
5962 involving floating point, convert the integers to floating point
5963 so that the resulting value does not suffer from catastrophic
5964 integer truncation. For example, on a 64-bit host (* 4
5965 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5966 Do not rely on undefined behavior after integer overflow.
5967
de883a70
PE
5968 merge count_size_as_multibyte, parse_str_to_multibyte
5969 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5970 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5971 Check for integer overflow.
5972 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5973 since it's now a duplicate of the other. This is more of
5974 a character than a buffer op, so better that it's in character.c.
5975 * fns.c, print.c: Adjust to above changes.
5976
2ff916cb
PE
59772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5978
5979 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5980
f1b54466
PE
59812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5982
fb1ac845
PE
5983 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5984 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5985 (x_clipboard_manager_save): Now static.
5986 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5987
f1b54466
PE
5988 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5989 (crypto_hash_function): Now static.
5990 Fix pointer signedness problems. Avoid unnecessary initializations.
5991
a9f737ee
CY
59922011-05-27 Chong Yidong <cyd@stupidchicken.com>
5993
5994 * termhooks.h (Vselection_alist): Make it terminal-local.
5995
5996 * terminal.c (create_terminal): Initialize it.
5997
5998 * xselect.c: Support for clipboard managers.
5999 (Vselection_alist): Move to termhooks.h as terminal-local var.
6000 (LOCAL_SELECTION): New macro.
6001 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6002 (symbol_to_x_atom): Remove gratuitous arg.
6003 (x_handle_selection_request, lisp_data_to_selection_data)
6004 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6005 (x_own_selection, x_get_local_selection, x_convert_selection):
6006 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6007 (some_frame_on_display): Delete unused function.
6008 (Fx_own_selection_internal, Fx_get_selection_internal)
6009 (Fx_disown_selection_internal, Fx_selection_owner_p)
6010 (Fx_selection_exists_p): New optional frame arg.
6011 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6012 (x_handle_selection_clear): Don't treat other terminals with the
6013 same keyboard specially. Use the terminal-local Vselection_alist.
6014 (x_clear_frame_selections): Use Frun_hook_with_args.
6015
6016 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6017
6018 * xterm.h: Add support for those atoms.
6019
e067f0c1
CY
60202011-05-26 Chong Yidong <cyd@stupidchicken.com>
6021
6022 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6023 (converted_selections, conversion_fail_tag): New global variables.
6024 (x_selection_request_lisp_error): Free the above.
6025 (x_get_local_selection): Remove unnecessary code.
6026 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6027 of converted selections stored in converted_selections.
6028 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6029 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6030 (x_convert_selection): New function.
6031 (x_handle_selection_event): Simplify.
6032 (x_get_foreign_selection): Don't ignore incoming requests while
6033 waiting for an answer; this will fail when we implement
6034 SAVE_TARGETS, and seems unnecessary anyway.
6035 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6036 (Vx_sent_selection_functions): Doc fix.
6037
0f4aebc0
LL
60382011-05-26 Leo Liu <sdl.web@gmail.com>
6039
6040 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6041
e61124cd
YM
60422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6043
6044 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6045
6046 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6047 for fringe update if it has periodic bitmap.
ac389d0c 6048 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6049 and fringe_bitmap_periodic_p.
6050
6051 * fringe.c (get_fringe_bitmap_data): New function.
6052 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6053 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6054 row. Mark glyph row for fringe update if periodicity changed.
6055
6056 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6057 for fringe update unless it has periodic bitmap.
6058
f16d9837
KH
60592011-05-25 Kenichi Handa <handa@m17n.org>
6060
6061 * xdisp.c (get_next_display_element): Set correct it->face_id for
6062 a static composition.
6063
e1b90ef6
LL
60642011-05-24 Leo Liu <sdl.web@gmail.com>
6065
6066 * deps.mk (fns.o):
6067 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6068
6069 * fns.c (crypto_hash_function, Fsha1): New function.
6070 (Fmd5): Use crypto_hash_function.
6071 (syms_of_fns): Add Ssha1.
6072
7400048f
PE
60732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 * gnutls.c: Remove unused macros.
6076 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6077 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6078 Remove macros that are defined and never used.
6079 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6080
abb71cf4
CY
60812011-05-22 Chong Yidong <cyd@stupidchicken.com>
6082
6083 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6084 (Fx_get_selection_internal): Minor cleanup.
6085 (Fx_own_selection_internal): Rename arguments for consistency with
6086 select.el.
6087
6307db39
PE
60882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6089
6090 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6091
f3d4e0a4
CY
60922011-05-22 Chong Yidong <cyd@stupidchicken.com>
6093
6094 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6095
4d8ade89
YM
60962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6097
6098 * dispnew.c (scrolling_window): Don't exclude the case that the
6099 last enabled row in the desired matrix touches the bottom boundary.
6100
32078c8d
GM
61012011-05-21 Glenn Morris <rgm@gnu.org>
6102
6103 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6104 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6105 and add some more files.
32078c8d 6106
7285dc67
EZ
61072011-05-20 Eli Zaretskii <eliz@gnu.org>
6108
6109 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6110 report_file_error introduced by the change from 2011-05-07.
6111
89d1bd22
PE
61122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 * systime.h (Time): Define only if emacs is defined.
6115 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6116 where the include path doesn't have X11/X.h by default. See
6117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6118
cd394be1 61192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6120
6121 * composite.c (find_automatic_composition): Fix previous change.
6122
b9704ad9
GM
61232011-05-20 Glenn Morris <rgm@gnu.org>
6124
6125 * lisp.mk: New file, split from Makefile.in.
6126 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6127 (shortlisp): Remove.
6128 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6129
4a720484
GM
61302011-05-19 Glenn Morris <rgm@gnu.org>
6131
6132 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6133 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6134 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6135 (lisp): Set the order to that of loadup.el.
6136 (shortlisp): Make it a copy of $lisp.
6137 (SOME_MACHINE_LISP): Remove.
6138 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6139 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6140
a28d4396
KH
61412011-05-18 Kenichi Handa <handa@m17n.org>
6142
6143 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6144 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6145 (find_automatic_composition): Mostly rewrite for efficiency.
6146
a2b1fa8e
JB
61472011-05-18 Juanma Barranquero <lekktu@gmail.com>
6148
6149 * makefile.w32-in: Update dependencies.
6150
8e1f5610
CS
61512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6152
6153 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6154 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6155
7025ee00 61562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6157
cdfa6eab
PE
6158 Fix some integer overflow issues, such as string length overflow.
6159
06d6db33
PE
6160 * insdel.c (count_size_as_multibyte): Check for string overflow.
6161
2b4560a8
PE
6162 * character.c (lisp_string_width): Check for string overflow.
6163 Use EMACS_INT, not int, for string indexes and lengths; in
6164 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6165 the resulting string length overflows an EMACS_INT; instead,
6166 report a string overflow if no precision given. When checking for
6167 precision exhaustion, use a check that cannot possibly have
6168 integer overflow. (Bug#8675)
6169 * character.h (lisp_string_width): Adjust to new signature.
6170
cb93f9be
PE
6171 * alloc.c (string_overflow): New function.
6172 (Fmake_string): Use it. This doesn't change behavior, but saves
6173 a few bytes and will simplify future changes.
6174 * character.c (string_escape_byte8): Likewise.
6175 * lisp.h (string_overflow): New decl.
6176
1a1f3366
PE
6177 Fixups, following up to the user-interface timestamp change.
6178 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6179 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6180 * msdos.c (mouse_get_pos): Likewise.
6181 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6182 * w32gui.h (Time): Define by including "systime.h" rather than by
6183 declaring it ourselves. (Bug#8664)
6184
d4e3e4d3
PE
6185 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6186 * image.c (clear_image_cache): Likewise.
6187
f6a24d19
PE
6188 * term.c (term_mouse_position): Don't assume time_t wraparound.
6189
08dc5ae6
PE
6190 Be more systematic about user-interface timestamps.
6191 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6192 and sometimes 'EMACS_UINT', to represent these timestamps.
6193 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6194 This makes the code easier to follow, and makes it easier to catch
6195 integer overflow bugs such as Bug#8664.
6196 * frame.c (Fmouse_position, Fmouse_pixel_position):
6197 Use Time, not unsigned long, for user-interface timestamps.
6198 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6199 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6200 * keyboard.h (last_event_timestamp): Likewise.
6201 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6202 * menu.h (xmenu_show): Likewise.
6203 * term.c (term_mouse_position): Likewise.
6204 * termhooks.h (struct input_event.timestamp): Likewise.
6205 (struct terminal.mouse_position_hook): Likewise.
6206 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6207 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6208 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6209 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6210 what it was before.
6211 * menu.h, termhooks.h: Include "systime.h", for Time.
6212
8e55734a
PE
6213 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6214 Don't assume that the difference between two unsigned long values
6215 can fit into an integer. At this point, we know button_down_time
6216 <= event->timestamp, so the difference must be nonnegative, so
6217 there's no need to cast the result if double-click-time is
6218 nonnegative, as it should be; check that it's nonnegative, just in
6219 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6220 apart (about 25 days). (Bug#8664)
8e55734a 6221
841f1b75 6222 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6223 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6224
3e26f69c
PE
6225 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6226 that always fit in int. Use a sentinel instead of a counter, to
6227 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6228 * frame.h (struct frame): Use int for menu_bar_items_used
6229 instead of EMACS_INT, since it always fits in int.
3e26f69c 6230
5cc152c0
PE
6231 * menu.c (grow_menu_items): Check for int overflow.
6232
d89eb65e
PE
6233 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6234
5235bd3e
PE
6235 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6236 Before, the code was not consistent. These values cannot exceed
6237 2**31 - 1 so there's no need to make them unsigned.
6238 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6239 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6240 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6241 as modifiers.
6242 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6243
bc827e23
PE
6244 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6245 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6246 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6247 presumably because the widths might not match.
6248
78eb494e
PE
6249 * window.c (size_window): Avoid needless test at loop start.
6250
04f2d78b
CB
62512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6252
6253 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6254
d2fc7e3d 62552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6256
6257 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6258
d2fc7e3d 62592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6260
6261 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6262 `width' to `bar_area_x' and `bar_area_width', respectively.
6263 (x_scroll_run): Take account of fringe background extension.
6264
04f2d78b
CB
6265 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6266 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6267 `bar_area_width', respectively.
6268 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6269 background extension.
6270
79b70037
GM
62712011-05-10 Jim Meyering <meyering@redhat.com>
6272
6273 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6274
2f142cc5
JB
62752011-05-10 Juanma Barranquero <lekktu@gmail.com>
6276
6277 * image.c (Finit_image_library): Return t for built-in image types,
6278 like pbm and xbm. (Bug#8640)
6279
57679c86
AS
62802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6281
6282 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6283
888c9e86
EZ
62842011-05-07 Eli Zaretskii <eliz@gnu.org>
6285
b0512a1d
EZ
6286 * w32console.c (Fset_screen_color): Doc fix.
6287 (Fget_screen_color): New function.
6288 (syms_of_ntterm): Defsubr it.
6289
7285dc67
EZ
6290 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6291 unlink the temporary file if Fcall_process didn't create it in the
6292 first place.
6293 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6294 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6295 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6296 cue to call_process_cleanup not to close that handle.
6297
4d3fcc8e
BK
62982011-05-07 Ben Key <bkey76@gmail.com>
6299
6300 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6301 one of two shell specific rules, either bootstrap-temacs-CMD or
6302 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6303 to the previous implementation of the bootstrap-temacs rule.
6304 The bootstrap-temacs-CMD rule is similar to the previous
6305 implementation of the bootstrap-temacs rule except that it
6306 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6307 variable.
6308
6309 These changes, along with some changes to nt/configure.bat,
6310 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6311 earlier fix to add support for --cflags and --ldflags options
6312 that include quotes so that it works whether make uses cmd or
6313 sh as the shell.
6314
b4289b64
MA
63152011-05-06 Michael Albinus <michael.albinus@gmx.de>
6316
6317 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6318 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6319 is a constant.
6320 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6321 a string. Handle both cases.
6322 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6323 (Fdbus_register_method): Use Qinvalid_function.
6324
af4c0e28
JB
63252011-05-06 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * makefile.w32-in: Update dependencies.
6328 (LISP_H): Add inttypes.h and stdin.h.
6329 (PROCESS_H): Add unistd.h.
6330
c51453d9
EZ
63312011-05-06 Eli Zaretskii <eliz@gnu.org>
6332
6333 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6334 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6335
8ff0ac3c 63362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6337
4c4b566b
PE
6338 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6339
aab2b9b5
PE
6340 * term.c (vfatal): Remove stray call to va_end.
6341 It's not needed and the C Standard doesn't allow it here anyway.
6342
c378da0b
PE
6343 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6344 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6345
288b08c7
PE
6346 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6347 bytes.
6348
e3601888
PE
6349 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6350
db6c0e74
PE
6351 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6352
dd5963ea
PE
6353 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6354
88c9450f
PE
6355 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6356
2f9442b8
PE
6357 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6358
c032b5f8
PE
6359 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6360 * charset.c (Fdefine_charset_internal): Don't initialize
6361 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6362 32-bit int (Bug#8600).
a108c10b
PE
6363
6364 * lread.c (read_integer): Be more consistent with string-to-number.
6365 Use string_to_number to do the actual conversion; this avoids
6366 rounding errors and fixes some other screwups. Without this fix,
6367 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6368 (digit_to_number): Move earlier, for benefit of read_integer.
6369 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6370 not a digit in any supported base. (Bug#8602)
a108c10b 6371
ad5f9eea
PE
6372 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6373
aec1708a
PE
6374 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6375 to match comment at start of function. This also removes a
6376 GCC warning about overflow in a 32+64-bit port.
6377
47be4ab5
PE
6378 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6379
371cac43
PE
6380 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6381 Reported by Stefan Monnier in
6382 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6383 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6384 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6385
d01a7826
PE
6386 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6387 (EMACS_UINTPTR): Likewise, with uintptr_t.
6388
7fd47d5c
PE
6389 * lisp.h: Prefer 64-bit EMACS_INT if available.
6390 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6391 on 32-bit hosts that have 64-bit int, so that they can access
6392 large files.
122b0c86
PE
6393 However, temporarily disable this change unless the temporary
6394 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6395
8727937b
PE
6396 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6397
8ac068ac
PE
6398 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6399 This removes an assumption that EMACS_INT and long are the same
6400 width as pointers. The assumption is true for Emacs porting targets
6401 now, but we want to make other targets possible.
6402 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6403 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6404 In the rest of the code, change types of integers that hold casted
6405 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6406 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6407 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6408 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6409 No need to cast type when ORing.
6410 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6411 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6412 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6413 assume EMACS_INT is the same width as char *.
6414 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6415 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6416 Remove no-longer-needed casts.
6417 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6418 (xg_tool_bar_help_callback, xg_make_tool_item):
6419 Use EMACS_INTPTR to hold an integer
6420 that will be cast to void *; this can avoid a GCC warning
6421 if EMACS_INT is not the same width as void *.
6422 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6423 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6424 (current_message_1, set_message_1):
6425 Use a local to convert to proper width without a cast.
6426 * xmenu.c (dialog_selection_callback): Likewise.
6427
ede49d71
PE
6428 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6429 Also, don't assume VALBITS / RAND_BITS is less than 5,
6430 and don't rely on undefined behavior when shifting a 1 left into
6431 the sign bit.
6432 * lisp.h (get_random): Change signature to match.
6433
2f30ecd0
PE
6434 * lread.c (hash_string): Use size_t, not int, for hash computation.
6435 Normally we prefer signed values; but hashing is special, because
6436 it's better to use unsigned division on hash table sizes so that
6437 the remainder is nonnegative. Also, size_t is the natural width
6438 for hashing into memory. The previous code used 'int', which doesn't
6439 retain enough info to hash well into very large tables.
6440 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6441
2a866e7b
PE
6442 * dbusbind.c: Don't possibly lose pointer info when converting.
6443 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6444 Use XPNTR rather than XHASH, so that the high-order bits of
6445 the pointer aren't lost when converting through void *.
6446
51639eac
PE
6447 * eval.c (Fautoload): Don't double-shift a pointer.
6448
92394119
PE
6449 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6450
dbdb9a7c
JB
64512011-05-06 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * gnutls.c (DEF_GNUTLS_FN):
6454 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6455
db7a0b4f
AS
64562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6457
6458 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6459 marker. (Bug#8610)
6460
cd394be1 64612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6462
6463 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6464 New version that can reserve upto 2GB of heap space.
6465
f7ff1b0f 64662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6467
6468 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6469
639c109b
TZ
64702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6471
6472 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6473 `gnutls_certificate_set_x509_key_file'.
6474
d2127135
JB
64752011-05-05 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6478 Update dependencies.
6479
e968f4f3
JB
64802011-05-04 Juanma Barranquero <lekktu@gmail.com>
6481
6482 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6483 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6484 Remove unused parameter `fildes'.
6485 * process.c (read_process_output, send_process): Don't pass it.
6486
84d358f0
JB
64872011-05-04 Juanma Barranquero <lekktu@gmail.com>
6488
6489 Fix previous change: the library cache is defined in w32.c.
6490 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6491 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6492
0898ca10
JB
64932011-05-04 Juanma Barranquero <lekktu@gmail.com>
6494
6495 Implement dynamic loading of GnuTLS on Windows.
6496
6497 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6498 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6499 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6500 Declare.
6501
6502 * gnutls.c (Qgnutls_dll): Define.
6503 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6504 (gnutls_*): Declare function pointers.
6505 (init_gnutls_functions): New function to initialize function pointers.
6506 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6507 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6508 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6509 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6510 (emacs_gnutls_write, emacs_gnutls_read)
6511 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6512 (Fgnutls_available_p): New function.
6513 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6514 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6515 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6516
6517 * image.c: Include w32.h.
6518 (Vimage_type_cache): Delete.
6519 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6520 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6521 (w32_delayed_load): Move to w32.c.
6522
6523 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6524
6525 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6526 (w32_delayed_load): Move from image.c. When loading a library, record
6527 its filename in the :loaded-from property of the library id.
6528 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6529 Initialize and staticpro them.
6530 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6531
6532 * process.c: Include lisp.h before w32.h, not after.
6533 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6534 instead of gnutls_record_check_pending.
6535
6536 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6537
ff4de4aa
TZ
65382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6539
6540 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6541 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6542 as passed in.
6543
abe95abb
JD
65442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6545
6546 * xterm.c (x_set_frame_alpha): Do not set property on anything
6547 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6548
e16e55d4
JB
65492011-05-02 Juanma Barranquero <lekktu@gmail.com>
6550
6551 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6552
bafcf6a5
JB
65532011-05-02 Juanma Barranquero <lekktu@gmail.com>
6554
6555 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6556 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6557 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6558 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6559 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6560 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6561 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6562 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6563 (Qgnutls_bootprop_callbacks_verify): Make static.
6564
e7a6747f
AS
65652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6566
19ed11ba
AS
6567 * callproc.c: Indentation fixup.
6568
e7a6747f 6569 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6570 (wait_for_termination, interruptible_wait_for_termination):
6571 Move after wait_for_termination_1.
e7a6747f 6572
1ef14cb4
LMI
65732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6574
6575 * sysdep.c (interruptible_wait_for_termination): New function
6576 which is like wait_for_termination, but allows keyboard
6577 interruptions.
6578
6579 * callproc.c (Fcall_process): Add (:file "file") as an option for
6580 the STDOUT buffer.
6581 (Fcall_process_region): Ditto.
6582
330d880c
EZ
65832011-04-30 Eli Zaretskii <eliz@gnu.org>
6584
8db90b73
EZ
6585 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6586 rather than `XVECTOR (FOO)->size'.
6587
330d880c
EZ
6588 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6589 inttypes.h, as a gnulib replacement is used if it not available in
6590 system headers.
6591
15cbd324
EZ
65922011-04-21 Eli Zaretskii <eliz@gnu.org>
6593
6594 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6595 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6596 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6597
6598 * coding.c (coding_alloc_by_realloc): Error out if destination
6599 will grow beyond MOST_POSITIVE_FIXNUM.
6600 (decode_coding_emacs_mule): Abort if there isn't enough place in
6601 charbuf for the composition carryover bytes. Reserve an extra
6602 space for up to 2 characters produced in a loop.
6603 (decode_coding_iso_2022): Abort if there isn't enough place in
6604 charbuf for the composition carryover bytes.
6605
66062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6607
ae940cca
EZ
6608 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6609 aborting when %lld or %lll format is passed.
6610 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6611 %llo or %llx format is passed. (Bug#8545)
6612
03ab8921
EZ
6613 * window.c (window_scroll_line_based): Use a marker instead of
6614 simple variables to record original value of point. (Bug#7952)
6615
afda1437
EZ
6616 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6617 produced by %s or %c overflows available buffer space. (Bug#8545)
6618
f76dee0c
PE
66192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6620
6621 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6622 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6623
fdc5744d
JB
66242011-04-28 Juanma Barranquero <lekktu@gmail.com>
6625
6626 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6627
638f053a
JB
66282011-04-28 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * keyboard.c (Qdelayed_warnings_hook): Define.
6631 (command_loop_1): Run `delayed-warnings-hook'
6632 if Vdelayed_warnings_list is non-nil.
6633 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6634 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6635
d178f871
EZ
66362011-04-28 Eli Zaretskii <eliz@gnu.org>
6637
6638 * doprnt.c (doprnt): Don't return value smaller than the buffer
6639 size if the message was truncated. (Bug#8545).
6640
b124fd93
JB
66412011-04-28 Juanma Barranquero <lekktu@gmail.com>
6642
6643 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6644 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6645
e810457d
PE
66462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6647
6648 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6649
ea51cceb
JB
66502011-04-27 Juanma Barranquero <lekktu@gmail.com>
6651
6652 * makefile.w32-in: Update dependencies.
6653
94dcfacf
EZ
66542011-04-27 Eli Zaretskii <eliz@gnu.org>
6655
6656 Improve `doprnt' and its usage. (Bug#8545)
6657 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6658 `format_end'. Remove support for %l as a conversion specifier.
6659 Don't use xrealloc. Improve diagnostics when the %l size modifier
6660 is used. Update the commentary.
6661
6662 * eval.c (verror): Simplify calculation of size_t.
6663
6664 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6665 messages.
6666
f61f41d7
PE
66672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6668
6669 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6670 change.
6671
96fb4434
PE
66722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6673
6674 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6675 This makes this file independent of the recent pseudovector change.
6676
671875da 66772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6678
69e9b5a3
PE
6679 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6680
b5f869a7 6681 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6682 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6683 Remove unused local.
c8926152 6684 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6685
841a1577 6686 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6687 GCC 4.6.0 optimizes based on type-based alias analysis.
6688 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6689 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6690 != &v->size, and therefore "v->size = 1; b->size = 2; return
6691 v->size;" must therefore return 1. This assumption is incorrect
6692 for Emacs, since it type-puns struct Lisp_Vector * with many other
6693 types. To fix this problem, this patch adds a new type struct
f904488f 6694 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6695 and pseudovectors, and helps optimizing compilers not get fooled
6696 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6697 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6698 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6699 the size member.
eab3844f
PE
6700 (XSETPVECTYPE): Rewrite in terms of new macro.
6701 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6702 This is a bit clearer, and further avoids the possibility of
6703 undesirable aliasing.
6704 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6705 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6706 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6707 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6708 (ASIZE): Now uses header.size rather than size.
6709 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6710 to avoid the hassle of writing XVECTOR (foo)->header.size.
6711 (struct vectorlike_header): New type.
eab3844f
PE
6712 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6713 object, to help avoid aliasing.
6714 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6715 (SUBRP): Likewise, since Lisp_Subr is a special case.
6716 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6717 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6718 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6719 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6720 changed to be "header.size" and "header.next".
6721 * buffer.h (struct buffer): Likewise.
6722 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6723 * frame.h (struct frame): Likewise.
6724 * process.h (struct Lisp_Process): Likewise.
6725 * termhooks.h (struct terminal): Likewise.
6726 * window.c (struct save_window_data, struct saved_window): Likewise.
6727 * window.h (struct window): Likewise.
6728 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6729 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6730 * buffer.c (init_buffer_once): Likewise.
6731 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6732 special case.
6733 * process.c (Fformat_network_address): Use local var for size,
6734 for brevity.
6735
0df1eac5
PE
6736 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6737
847ab9d1 6738 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6739 * data.c (atof): Remove decl; no longer used or needed.
6740 (digit_to_number): Move to lread.c.
6741 (Fstring_to_number): Use new string_to_number function, to be
6742 consistent with how the Lisp reader treats infinities and NaNs.
6743 Do not assume that floating-point numbers represent EMACS_INT
6744 without losing information; this is not true on most 64-bit hosts.
6745 Avoid double-rounding errors, by insisting on integers when
6746 parsing non-base-10 numbers, as the documentation specifies.
6747 * lisp.h (string_to_number): New decl, replacing ...
6748 (isfloat_string): Remove.
bc0a5c13 6749 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6750 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6751 appears to have been a coding error. Similarly, do not accept
6752 strings like +-1e0 as floating point numbers. Do not report
6753 overflow for integer overflows unless the base is not 10 which
6754 means we have no simple and reliable way to continue.
6755 Break out the floating-point parsing into a new
6756 function string_to_number, so that Fstring_to_number parses
6757 floating point numbers consistently with the Lisp reader.
04f2d78b 6758 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6759 (E_CHAR, EXP_INT): Remove, replacing with ...
6760 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6761 (string_to_number): New function, replacing isfloat_string.
6762 This function checks for valid syntax and produces the resulting
6763 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6764 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6765 so that overflow for non-base-10 numbers is reported only when
6766 there's no portable and simple way to convert to floating point.
452f4150 6767
67769ffc
PE
6768 * textprop.c (set_text_properties_1): Rewrite for clarity,
6769 and to avoid GCC warning about integer overflow.
6770
c20db43f
PE
6771 * intervals.h (struct interval): Use EMACS_INT for members
6772 where EMACS_UINT might cause problems. See
6773 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6774 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6775 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6776 All uses changed.
37aa2f85
PE
6777 (offset_intervals): Tell GCC not to worry about length overflow
6778 when negating a negative length.
c20db43f 6779
2538aa2f
PE
6780 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6781 (overrun_check_free): Likewise.
6782
f2d3008d
PE
6783 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6784 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6785 word size.
6786
ec8df744
PE
6787 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6788 (gnutls_make_error): Rename local to avoid shadowing.
6789 (gnutls_emacs_global_deinit): ifdef out; not used.
6790 (Fgnutls_boot): Use const for pointer to readonly storage.
6791 Comment out unused local. Fix pointer signedness problems.
6792
640ee02d
PE
6793 * lread.c (openp): Don't stuff size_t into an 'int'.
6794 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6795 about possible signed overflow.
6796
6048fb2a
PE
6797 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6798 (GDK_KEY_g): Don't define if already defined.
6799 (xg_prepare_tooltip): Avoid pointer signedness problem.
6800 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6801
fa3c87e1
PE
6802 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6803 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6804
2172544b
PE
6805 * xfns.c (Fx_window_property): Simplify a bit,
6806 to make a bit faster and to avoid GCC 4.6.0 warning.
6807 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6808
9b821a21
PE
6809 * fns.c (internal_equal): Don't assume size_t fits in int.
6810
3c616cfa
PE
6811 * alloc.c (compact_small_strings): Tighten assertion a little.
6812
c2982e87
PE
6813 Replace pEd with more-general pI, and fix some printf arg casts.
6814 * lisp.h (pI): New macro, generalizing old pEd macro to other
6815 conversion specifiers. For example, use "...%"pI"d..." rather
6816 than "...%"pEd"...".
6817 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6818 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6819 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6820 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6821 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6822 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6823 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6824 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6825 64-bit hosts.
6826 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6827 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6828 * print.c (safe_debug_print, print_object): Likewise.
6829 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6830 to int.
6f04d126
PE
6831 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6832 avoiding the 0 flag, which is not portable.
c2982e87
PE
6833 * process.c (Fmake_network_process): Use pI to avoid cast.
6834 * region-cache.c (pp_cache): Likewise.
6835 * xdisp.c (decode_mode_spec): Likewise.
6836 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6837 behavior on 64-bit hosts with printf arg.
6f04d126 6838 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6839 (x_stop_queuing_selection_requests): Likewise.
6840 (x_get_window_property): Don't truncate byte count to an 'int'
6841 when tracing.
0b432f21 6842
5e073ec7
PE
6843 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6844 here, since it parses constructs like leading '-' and spaces,
6845 which are not wanted; and it overflows with large numbers.
6846 Instead, simply match F[0-9]+, which is what is wanted anyway.
6847
36372bf9
PE
6848 * alloc.c: Remove unportable assumptions about struct layout.
6849 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6850 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6851 (allocate_vectorlike, make_pure_vector): Use the new macros,
6852 plus offsetof, to remove unportable assumptions about struct layout.
6853 These assumptions hold on all porting targets that I know of, but
6854 they are not guaranteed, they're easy to remove, and removing them
6855 makes further changes easier.
6856
0b432f21
PE
6857 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6858 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6859 (string_overrun_cookie): Now const. Use initializers that
6860 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6861 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6862 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6863 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6864 multiple of sizeof (EMACS_INT); it need not be, if
6865 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6866 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6867
895009e1
JB
68682011-04-26 Juanma Barranquero <lekktu@gmail.com>
6869
6870 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6871
6a7a1b0b
TZ
68722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6873
6874 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6875 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6876 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6877
841a1577 68782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6879
6880 * lisp.h (Qdebug): List symbol.
895009e1 6881 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6882 * keyboard.c (debug-on-event): New variable.
6883 (handle_user_signal): Break into debugger when debug-on-event
6884 matches the current signal symbol.
6885
f2d3ba6f
DN
68862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6887
6888 * alloc.c (check_sblock, check_string_bytes)
6889 (check_string_free_list): Convert to standard C.
6890
42ce4c63
TZ
68912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6892
6893 * w32.c (emacs_gnutls_push): Fix typo.
6894
825cd63c
EZ
68952011-04-25 Eli Zaretskii <eliz@gnu.org>
6896
fb11d64d
EZ
6897 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6898 "cast to pointer from integer of different size".
6899
825cd63c
EZ
6900 Improve doprnt and its use in verror. (Bug#8545)
6901 * doprnt.c (doprnt): Document the set of format control sequences
6902 supported by the function. Use SAFE_ALLOCA instead of always
6903 using `alloca'.
6904
6905 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6906 is one byte too soon. Don't use xrealloc; instead xfree and
6907 xmalloc anew.
6908
e061a11b
TZ
69092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6910
6911 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6912 callbacks stage.
6913
6914 * gnutls.c: Renamed global_initialized to
6915 gnutls_global_initialized. Added internals for the
6916 :verify-hostname-error, :verify-error, and :verify-flags
6917 parameters of `gnutls-boot' and documented those parameters in the
6918 docstring. Start callback support.
9173deec
JB
6919 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6920 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6921 on error. Return error code.
e061a11b
TZ
6922 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6923 (emacs_gnutls_read): Likewise.
6924 (Fgnutls_boot): Return handshake error code.
6925 (emacs_gnutls_handle_error): New function.
6926 (wsaerror_to_errno): Likewise.
6927
6928 * w32.h (emacs_gnutls_pull): Add prototype.
6929 (emacs_gnutls_push): Likewise.
6930
6931 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6932 (emacs_gnutls_push): Likewise.
6933
69342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6935
6936 * process.c (wait_reading_process_output): Check if GnuTLS
6937 buffered some data internally if no FDs are set for TLS
6938 connections.
6939
6940 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6941 (LIBS): Link to USER_LIBS.
6942 ($(BLD)/gnutls.$(0)): New target.
6943
fa6996bc
EZ
69442011-04-24 Eli Zaretskii <eliz@gnu.org>
6945
eb35682e
EZ
6946 * xdisp.c (handle_single_display_spec): Rename the
6947 display_replaced_before_p argument into display_replaced_p, to
6948 make it consistent with the commentary. Fix typos in the
6949 commentary.
6950
e2ad650c
EZ
6951 * textprop.c (syms_of_textprop): Remove dead code.
6952 (copy_text_properties): Delete obsolete commentary about an
6953 interface that was deleted long ago. Fix typos in the description
6954 of arguments.
6955
1b2de274
EZ
6956 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6957 to changes in oldXMenu/XMenu.h from 2011-04-16.
6958 <menu_help_message, prev_menu_help_message>: Constify.
6959 (IT_menu_make_room): menu->help_text is now `const char **';
6960 adjust.
6961
6962 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6963 to changes in oldXMenu/XMenu.h from 2011-04-16.
6964 (struct XMenu): Declare `help_text' `const char **'.
6965
6966 * xfaces.c <Qunspecified>: Make extern again.
6967
6968 * syntax.c: Include sys/types.h before including regex.h, as
6969 required by Posix.
6970
762b15be
EZ
6971 * doc.c (get_doc_string): Improve the format passed to `error'.
6972
6973 * doprnt.c (doprnt): Improve commentary.
6974
6975 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6976
6977 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6978 them with etags.
6979
f1052e5d
EZ
6980 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6981 changes in globals.h immediately force recompilation.
762b15be
EZ
6982 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6983 $(CURDIR)/s/ms-w32.h.
6984 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6985
fa6996bc
EZ
6986 * character.c (Fchar_direction): Function deleted.
6987 (syms_of_character): Don't defsubr it.
6988 <char-direction-table>: Deleted.
6989
e6c3da20
EZ
69902011-04-23 Eli Zaretskii <eliz@gnu.org>
6991
6992 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6993 * doprnt.c: Include limits.h.
6994 (SIZE_MAX): New macro.
04f2d78b
CB
6995 (doprnt): Return a size_t value. 2nd arg is now size_t.
6996 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6997 Improve overflow protection. Support `l' modifier for integer
6998 conversions. Support %l conversion. Don't assume an EMACS_INT
6999 argument for integer conversions and for %c.
7000
7001 * lisp.h (doprnt): Restore prototype.
7002
7003 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7004 $(SRC)/character.h.
7005
7006 * Makefile.in (base_obj): Add back doprnt.o.
7007
7008 * deps.mk (doprnt.o): Add back prerequisites.
7009 (callint.o): Depend on character.h.
7010
7011 * eval.c (internal_lisp_condition_case): Include the handler
7012 representation in the error message.
7013 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7014 when breaking from the loop.
7015
7016 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7017
7018 * callint.c (Fcall_interactively): When displaying error message
7019 about invalid control letter, pass the character's codepoint, not
7020 a pointer to its multibyte form. Improve display of the character
7021 in octal and display also its hex code.
7022
7023 * character.c (char_string): Use %x to display the (unsigned)
7024 codepoint of an invalid character, to avoid displaying a bogus
7025 negative value.
7026
7027 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7028 `error', not SYMBOL_NAME itself.
7029
7030 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7031 character arguments to `error'.
7032
7033 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7034 to `error' in error message about FINAL_CHAR argument. Make sure
7035 FINAL_CHAR is a character, and use %c when it is passed as
7036 argument to `error'.
7037
4ffd0d6b 70382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7039
7040 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7041
7042 * w32.c: Include <time.h>.
7043 (sys_localtime): New function.
7044
4ffd0d6b 70452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7046
7047 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7048
4ffd0d6b 7049 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7050
4ffd0d6b 70512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7052
4ffd0d6b
GM
7053 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7054 zombies (Bug#8467).
aac0c6e3 7055
04c56954
EZ
70562011-04-19 Eli Zaretskii <eliz@gnu.org>
7057
7058 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7059 gl_state.e_property when gl_state.object is Qt.
7060
7061 * insdel.c (make_gap_larger): Remove limitation of buffer size
7062 to <= INT_MAX.
7063
16a43933
CY
70642011-04-18 Chong Yidong <cyd@stupidchicken.com>
7065
7066 * xdisp.c (lookup_glyphless_char_display)
7067 (produce_glyphless_glyph): Handle cons cell entry in
7068 glyphless-char-display.
7069 (Vglyphless_char_display): Document it.
7070
7071 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7072 glyphless-char-display.
7073
4581706e
CY
70742011-04-17 Chong Yidong <cyd@stupidchicken.com>
7075
7076 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7077
7078 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7079
7080 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7081 definition for no-X builds.
7082
4887c6e2 70832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7084
fd35b6f9
PE
7085 Static checks with GCC 4.6.0 and non-default toolkits.
7086
5c1ccb01
PE
7087 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7088
006c5daa
PE
7089 * process.c (keyboard_bit_set): Define only if SIGIO.
7090 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7091 (send_process): Repair possible setjmp clobbering.
7092
efc736d3
PE
7093 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7094
4e2fe2e6
PE
7095 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7096
f97334a2
PE
7097 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7098
4e75f29d
PE
7099 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7100 Define only if needed.
7101
90efadd1
PE
7102 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7103 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7104 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7105
3c647824
PE
7106 * dispextern.h (struct redisplay_interface): Rename param
7107 to avoid shadowing.
e264f262 7108 * termhooks.h (struct terminal): Likewise.
761383f4 7109 * xterm.c (xembed_send_message): Likewise.
3c647824 7110
b58c5c4a
PE
7111 * insdel.c (make_gap_smaller): Define only if
7112 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7113
cad59032
PE
7114 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7115 it.
7116
c339dc2e
PE
7117 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7118 so that we aren't warned about unused symbols.
7119
91a3e27b
PE
7120 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7121
399c71d3 7122 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7123
8ffc96f5
PE
7124 * xfns.c (x_real_positions): Mark locals as initialized.
7125
eef9bc79
PE
7126 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7127
098db9dd
PE
7128 * xterm.c: Fix problems found by static analysis with other toolkits.
7129 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7130 (x_dispatch_event): Declare static if USE_GTK, and
7131 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7132 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7133 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7134 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7135 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7136
eb18f6cc
PE
7137 * xmenu.c (menu_help_callback): Pointer type fixes.
7138 Use const pointers when pointing at readonly data. Avoid pointer
7139 signedness clashes.
7140 (FALSE): Remove unused macro.
7141 (update_frame_menubar): Remove unused decl.
7142
1fe72bf8
PE
7143 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7144
60d9e1db
PE
7145 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7146 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7147 (single_menu_item): Rename local to avoid shadowing.
7148
39261c26
PE
7149 * keyboard.c (make_lispy_event): Remove unused local var.
7150
018c5e19
PE
7151 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7152 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7153
63d2b86e
PE
7154 * bitmaps: Change bitmaps from unsigned char back to the X11
7155 compatible char. Avoid the old compiler warnings about
7156 out-of-range initializers by using, for example, '\xab' rather
7157 than 0xab.
7158
aefd87e1
PE
7159 * xgselect.c (xgselect_initialize): Check vs interface
7160 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7161
bf501fb9
PE
7162 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7163
e9829fdf
PE
7164 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7165 to read-only memory.
7166
1086c095
PE
7167 * fns.c (vector): Remove; this old hack is no longer needed.
7168
2baccd04 7169 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7170 Remove unused var.
dde42981 7171 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7172
72391843 7173 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7174
436c16df 7175 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7176 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7177 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7178
92bb796d 7179 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7180 (x_term_init): Remove local to avoid shadowing.
92bb796d 7181
764430a3 7182 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7183
7184 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7185 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7186
d1dfb56c
EZ
71872011-04-16 Eli Zaretskii <eliz@gnu.org>
7188
c4354cb4
EZ
7189 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7190
d1dfb56c
EZ
7191 Fix regex.c, syntax.c and friends for buffers > 2GB.
7192 * syntax.h (struct gl_state_s): Declare character position members
7193 EMACS_INT.
7194
7195 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7196
04f2d78b
CB
7197 * textprop.c (verify_interval_modification, interval_of):
7198 Declare arguments EMACS_INT.
d1dfb56c
EZ
7199
7200 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7201 EMACS_INT.
7202
7203 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7204
7205 * indent.c (Fvertical_motion): Local variable it_start is now
7206 EMACS_INT.
7207
7208 * regex.c (re_match, re_match_2, re_match_2_internal)
7209 (bcmp_translate, regcomp, regexec, print_double_string)
7210 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7211 (re_compile_pattern, re_exec): Declare arguments and local
7212 variables `size_t' and `ssize_t' and return values `regoff_t', as
7213 appropriate.
7214 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7215 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7216 <compile_stack_type>: `size' and `avail' are now `size_t'.
7217
7218 * regex.h <regoff_t>: Use ssize_t, not int.
7219 (re_search, re_search_2, re_match, re_match_2): Arguments that
7220 specify buffer/string position and length are now ssize_t and
7221 size_t. Return type is regoff_t.
7222
613052cd
BK
72232011-04-16 Ben Key <bkey76@gmail.com>
7224
7225 * nsfont.m: Fixed bugs in ns_get_family and
7226 ns_descriptor_to_entity that were caused by using free to
7227 deallocate memory blocks that were allocated by xmalloc (via
7228 xstrdup). This caused Emacs to crash when compiled with
7229 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7230 --enable-checking=xmallocoverrun). xfree is now used to
7231 deallocate these memory blocks.
7232
4170f62f 72332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7234
71b41406
PE
7235 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7236
9587a89d
PE
7237 emacs_write: Accept and return EMACS_INT for sizes.
7238 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7239 et seq.
7240 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7241 Accept and return EMACS_INT.
7242 (emacs_gnutls_write): Return the number of bytes written on
7243 partial writes.
7244 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7245 (emacs_read, emacs_write): Remove check for negative size, as the
7246 Emacs source code has been audited now.
9587a89d
PE
7247 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7248 (emacs_read, emacs_write): Use it.
273a5f82
PE
7249 * process.c (send_process): Adjust to the new signatures of
7250 emacs_write and emacs_gnutls_write. Do not attempt to store
7251 a byte offset into an 'int'; it might overflow.
9587a89d 7252 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7253
3e047f51
PE
7254 * sound.c: Don't assume sizes fit in 'int'.
7255 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7256 Return EMACS_INT, not int.
3e047f51 7257 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7258 Accept EMACS_INT, not int.
7259 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7260 record read return values.
7261
cc39a9db
BK
72622011-04-15 Ben Key <bkey76@gmail.com>
7263
c9d0ec6d
JB
7264 * keyboard.c (Qundefined): Don't declare static since it is used
7265 in nsfns.m.
7266 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7267 static since they are used in nsfont.m.
cc39a9db 7268
6c60eb9f
SM
72692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7270
7271 * process.c (Qprocessp): Don't declare static.
7272 * lisp.h (Qprocessp): Declare again.
7273
7990b61a
JB
72742011-04-15 Juanma Barranquero <lekktu@gmail.com>
7275
7276 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7277
5d4cb038
PE
72782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7279
8bd7b830 7280 Improve C-level modularity by making more things 'static'.
cd64ea1d 7281
e3b27b31
PE
7282 Don't publish debugger-only interfaces to other modules.
7283 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7284 (verify_bytepos, count_markers): Move decls to the only modules
7285 that need them.
7286 * region-cache.h (pp_cache): Likewise.
7287 * window.h (check_all_windows): Likewise.
7288 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7289
5d4cb038
PE
7290 * sysdep.c (croak): Now static, if
7291 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7292 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7293
7294 * alloc.c (refill_memory_reserve): Now static if
7295 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7296 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7297
e87b6180
PE
7298 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7299 Define only if USE_LUCID.
7300
ac64929e
PE
7301 * xrdb.c (x_customization_string, x_rm_string): Now static.
7302
6f37259d
PE
7303 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7304 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7305
1683e3ab
PE
7306 * xdisp.c (draw_row_with_mouse_face): Now static.
7307 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7308
de9c2632
PE
7309 * window.h (check_all_windows): Mark externally visible.
7310
2b96acb7
PE
7311 * window.c (window_deletion_count): Now static.
7312
7313 * undo.c: Make symbols static if they're not exported.
7314 (last_undo_buffer, last_boundary_position, pending_boundary):
7315 Now static.
7316
50436f33
PE
7317 * textprop.c (interval_insert_behind_hooks): Now static.
7318 (interval_insert_in_front_hooks): Likewise.
7319
64520e5c
PE
7320 * term.c: Make symbols static if they're not exported.
7321 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7322 (max_frame_lines, tty_set_terminal_modes):
7323 (tty_reset_terminal_modes, tty_turn_off_highlight):
7324 (get_tty_terminal): Now static.
7325 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7326 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7327 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7328 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7329 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7330
1fa53021
PE
7331 * sysdep.c: Make symbols static if they're not exported.
7332 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7333 Now static.
7334 (sigprocmask_set, full_mask): Remove; unused.
7335 (wait_debugging): Mark as visible.
7336 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7337 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7338
d4b43b22
PE
7339 * syntax.c (syntax_temp): Define only if !__GNUC__.
7340
b7c513d0
PE
7341 * sound.c (current_sound_device, current_sound): Now static.
7342
989b29ad
PE
7343 * search.c (searchbufs, searchbuf_head): Now static.
7344
13a55a78
PE
7345 * scroll.c (scroll_cost): Remove; unused.
7346 * dispextern.h (scroll_cost): Remove decl.
7347
de68a1fc
PE
7348 * region-cache.h (pp_cache): Mark as externally visible.
7349
40ccffa6
PE
7350 * process.c: Make symbols static if they're not exported.
7351 (process_tick, update_tick, create_process, chan_process):
7352 (Vprocess_alist, proc_buffered_char, datagram_access):
7353 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7354 (deactivate_process): Mark defn as static, as well as decl.
7355 * lisp.h (create_process): Remove decl.
7356 * process.h (chan_process, Vprocess_alist): Remove decls.
7357
ad64fc97
PE
7358 * print.c: Make symbols static if they're not exported.
7359 (print_depth, new_backquote_output, being_printed, print_buffer):
7360 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7361 (print_interval, print_number_index, initial_stderr_stream):
7362 Now static.
7363 * lisp.h (Fprinc): Remove decl.
7364 (debug_output_compilation_hack): Mark as externally visible.
7365
adddb265
PE
7366 * sysdep.c (croak): Move decl from here to syssignal.h.
7367 * syssignal.h (croak): Put it here, so the API can be checked when
7368 'croak' is called from dissociate_if_controlling_tty.
7369
1717ede2
PE
7370 * minibuf.c: Make symbols static if they're not exported.
7371 (minibuf_save_list, choose_minibuf_frame): Now static.
7372 * lisp.h (choose_minibuf_frame): Remove decl.
7373
fa5fb2bc
PE
7374 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7375
1e3890d1
PE
7376 * lread.c: Make symbols static if they're not exported.
7377 (read_objects, initial_obarray, oblookup_last_bucket_number):
7378 Now static.
7379 (make_symbol): Remove; unused.
7380 * lisp.h (initial_obarray, make_symbol): Remove decls.
7381
8a1414fa
PE
7382 * keyboard.c: Make symbols static if they're not exported.
7383 (single_kboard, recent_keys_index, total_keys, recent_keys):
7384 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7385 (this_single_command_key_start, echoing, last_auto_save):
7386 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7387 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7388 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7389 (Vlispy_mouse_stem, double_click_count):
7390 Now static.
7391 (force_auto_save_soon): Define only if SIGDANGER.
7392 (ignore_mouse_drag_p): Now static if
7393 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7394 (print_help): Remove; unused.
7395 (stop_character, last_timer_event): Mark as externally visible.
7396 * keyboard.h (ignore_mouse_drag_p): Declare only if
7397 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7398 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7399 * lisp.h (echoing): Remove decl.
7400 (force_auto_save_soon): Declare only if SIGDANGER.
7401 * xdisp.c (redisplay_window): Simplify code, to make it more
7402 obvious that ignore_mouse_drag_p is not accessed if !defined
7403 USE_GTK && !defined HAVE_NS.
7404
93ea6e8f
PE
7405 * intervals.c: Make symbols static if they're not exported.
7406 (merge_properties_sticky, merge_interval_right, delete_interval):
7407 Now static.
7408 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7409
77382fcc
PE
7410 * insdel.c: Make symbols static if they're not exported.
7411 However, leave prepare_to_modify_buffer alone. It's never
7412 called from outside this function, but that appears to be a bug.
7413 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7414 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7415 (adjust_after_replace_noundo): Remove; unused.
7416 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7417 (signal_before_change): Remove decls.
77382fcc 7418
9306c32e
PE
7419 * indent.c (val_compute_motion, val_vmotion): Now static.
7420
cd44d2eb
PE
7421 * image.c: Make symbols static if they're not exported.
7422 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7423 if USE_GTK.
7424 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7425 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7426
ad9a7a06
PE
7427 * fringe.c (standard_bitmaps): Now static.
7428 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7429
81626931
PE
7430 * frame.c: Make symbols static if they're not exported.
7431 (x_report_frame_params, make_terminal_frame): Now static.
7432 (get_frame_param): Now static, unless HAVE_NS.
7433 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7434 (x_get_resource_string): Remove; not used.
7435 * frame.h (make_terminal_frame, x_report_frame_params):
7436 (x_get_resource_string); Remove decls.
7437 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7438 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7439
239f9db9
PE
7440 * font.c, fontset.c: Make symbols static if they're not exported.
7441 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7442 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7443 * font.c (font_close_object): Now static.
7444 * font.h (font_close_object): Remove.
7445 * fontset.c (FONTSET_OBJLIST): Remove.
7446 (free_realized_fontset) #if-0 the body, which does nothing.
7447 (face_suitable_for_char_p): #if-0, as it's never called.
7448 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7449 * xfaces.c (face_at_string_position):
7450 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7451 since 0 is always ASCII.
7452
dfcf3579
PE
7453 * fns.c (weak_hash_tables): Now static.
7454
5045092b
PE
7455 * fileio.c: Make symbols static if they're not exported.
7456 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7457 (Vwrite_region_annotation_buffers): Now static.
7458
57a96f5c
PE
7459 * eval.c: Make symbols static if they're not exported.
7460 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7461 * lisp.h (backtrace_list): Remove decl.
7462
35f08c38
PE
7463 * emacs.c: Make symbols static if they're not exported.
7464 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7465 (fatal_error_code, fatal_error_signal_hook, standard_args):
7466 Now static.
7467 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7468 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7469 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7470 * lisp.h (fatal_error_signal_hook): Remove decl.
7471 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7472
f44bd759
PE
7473 * editfns.c: Move a (normally-unused) function to its only use.
7474 * editfns.c, lisp.h (get_operating_system_release): Remove.
7475 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7476 worth the hassle of breaking this out.
7477
b532497d
PE
7478 * xterm.c: Make symbols static if they're not exported.
7479 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7480 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7481 (x_destroy_window, x_delete_display):
7482 Now static.
7483 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7484 (x_mouse_leave): Remove; unused.
7485 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7486 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7487 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7488 Remove decls.
7489 (x_mouse_leave): Declare only if WINDOWSNT.
7490 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7491 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7492 USE_X_TOOLKIT.
7493
1675728f
PE
7494 * ftxfont.c: Make symbols static if they're not exported.
7495 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7496 HAVE_FREETYPE.
7497 * font.h (ftxfont_driver): Likewise.
7498
e4cebfca
PE
7499 * xfns.c: Make symbols static if they're not exported.
7500 (x_last_font_name, x_display_info_for_name):
7501 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7502 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7503 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7504 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7505 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7506 (last_show_tip_args): Now static.
7507 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7508 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7509 (x_screen_planes): Remove; unused.
7510 * dispextern.h (x_screen_planes): Remove decl.
7511
5bf46f05
PE
7512 * dispnew.c: Make symbols static if they're not exported.
7513 * dispextern.h (redraw_garbaged_frames, scrolling):
7514 (increment_row_positions): Remove.
7515 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7516 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7517 Now static.
7518 (redraw_garbaged_frames): Remove; unused.
7519
435f4c28
PE
7520 * xfaces.c: Make symbols static if they're not exported.
7521 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7522 Remove decls.
7523 * xterm.h (defined_color): Remove decls.
7524 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7525 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7526 (menu_face_changed_default, defined_color, free_realized_face):
7527 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7528 (ascii_face_of_lisp_face): Remove; unused.
7529
8524aef3
PE
7530 * xdisp.c: Make symbols static if they're not exported.
7531 * dispextern.h (scratch_glyph_row, window_box_edges):
7532 (glyph_to_pixel_coords, set_cursor_from_row):
7533 (get_next_display_element, set_iterator_to_next):
7534 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7535 (show_mouse_face): Remove decls
7536 * frame.h (message_buf_print): Likewise.
7537 * lisp.h (pop_message, set_message, check_point_in_composition):
7538 Likewise.
7539 * xterm.h (set_vertical_scroll_bar): Likewise.
7540 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7541 (message_buf_print, scratch_glyph_row, displayed_buffer):
7542 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7543 (get_next_display_element, show_mouse_face, window_box_edges):
7544 (frame_to_window_pixel_xy, check_point_in_composition):
7545 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7546 (glyph_to_pixel_coords): Remove; unused.
7547
16390cd2
PE
7548 * dired.c (file_name_completion): Now static.
7549
7550 * dbusbind.c (xd_in_read_queued_messages): Now static.
7551
a25f4dfa
PE
7552 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7553 * data.c (circular_list_error): Remove.
7554
14a9c8df
PE
7555 * commands.h (last_point_position, last_point_position_buffer):
7556 (last_point_position_window): Remove decls.
7557 * keyboard.c: Make these variables static.
7558
04f2d78b
CB
7559 * coding.h (coding, code_convert_region, encode_coding_gap):
7560 Remove decls.
74ab6df5
PE
7561 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7562 (iso_code_class, detect_coding, code_convert_region): Now static.
7563 (encode_coding_gap): Remove; unused.
7564
38dfbee1
PE
7565 * chartab.c (chartab_chars, chartab_bits): Now static.
7566
a2cb4e63
PE
7567 * charset.h (charset_iso_8859_1): Remove decl.
7568 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7569 Now static.
7570
127198fd
PE
7571 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7572 * ccl.c (Vccl_program_table): Now static.
7573 (check_ccl_update): Remove; unused.
7574
d85b608f
PE
7575 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7576 * category.h: ... from here.
7577 * category.c (check_category_table, set_category_set): Now static.
7578
31cd66f3
PE
7579 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7580 * lisp.h: Remove these decls.
7581
c358e587
PE
7582 * buffer.c (buffer_count): Remove unused var.
7583
e78aecca
PE
7584 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7585 so that it's not optimized away.
7586 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7587 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7588 exported only to the debugger.
7589
e192d7d3 7590 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7591 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7592
92470028
PE
7593 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7594 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7595 was inaccessible from Lisp.
7596 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7597 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7598
244ed907
PE
7599 alloc.c: Import and export fewer symbols, and remove unused items.
7600 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7601 is defined.
7602 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7603 it's not optimized away by whole-program optimization.
7604 (message_enable_multibyte, free_misc): Remove.
7605 (catchlist, handlerlist, mark_backtrace):
7606 Declare only if BYTE_MARK_STACK.
7607 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7608 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7609 (message_enable_multibyte): Remove decl.
7610 (free_misc, interval_free_list, float_block, float_block_index):
7611 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7612 (cons_free_list, last_marked_index):
7613 Now static.
7614 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7615 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7616 (mark_backtrace): Define only if BYTE_MARK_STACK.
7617 * xdisp.c (message_enable_multibyte): Now static.
7618
61c2b50e 7619 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7620 This makes it easier for human readers (and static analyzers)
7621 to see whether these variables are used from other modules.
7622 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7623 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7624 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7625 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7626 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7627 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7628 * xmenu.c, xselect.c:
7629 Declare Q* vars static if they are not used in other modules.
7630 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7631 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7632 Remove decls of unexported vars.
7633 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7634
95c82688
PE
7635 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7636
16a97296
PE
7637 Make Emacs functions such as Fatom 'static' by default.
7638 This makes it easier for human readers (and static analyzers)
7639 to see whether these functions can be called from other modules.
7640 DEFUN now defines a static function. To make the function external
7641 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7642 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7643 (Finit_image_library):
16a97296
PE
7644 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7645 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7646 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7647 Remove decls, since these functions are now static.
7648 (Funintern, Fget_internal_run_time): New decls, since these functions
7649 were already external.
95c82688 7650
16a97296
PE
7651 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7652 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7653 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7654 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7655 * keyboard.c, keymap.c, lread.c:
7656 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7657 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7658 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7659 Mark functions with DEFUE instead of DEFUN,
7660 if they are used in other modules.
7661 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7662 decls for now-static functions.
7663 * buffer.h (Fdelete_overlay): Remove decl.
7664 * callproc.c (Fgetenv_internal): Mark as internal.
7665 * composite.c (Fremove_list_of_text_properties): Remove decl.
7666 (Fcomposition_get_gstring): New forward static decl.
7667 * composite.h (Fcomposite_get_gstring): Remove decl.
7668 * dired.c (Ffile_attributes): New forward static decl.
7669 * doc.c (Fdocumntation_property): New forward static decl.
7670 * eval.c (Ffetch_bytecode): New forward static decl.
7671 (Funintern): Remove extern decl; now in .h file where it belongs.
7672 * fileio.c (Fmake_symbolic_link): New forward static decl.
7673 * image.c (Finit_image_library): New forward static decl.
7674 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7675 * intervals.h (Fprevious_property_change):
7676 (Fremove_list_of_text_properties): Remove decls.
7677 * keyboard.c (Fthis_command_keys): Remove decl.
7678 (Fcommand_execute): New forward static decl.
7679 * keymap.c (Flookup_key): New forward static decl.
7680 (Fcopy_keymap): Now static.
7681 * keymap.h (Flookup_key): Remove decl.
7682 * process.c (Fget_process): New forward static decl.
7683 (Fprocess_datagram_address): Mark as internal.
7684 * syntax.c (Fsyntax_table_p): New forward static decl.
7685 (skip_chars): Remove duplicate decl.
7686 * textprop.c (Fprevious_property_change): New forward static decl.
7687 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7688 Now internal.
7689 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7690 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7691
785bbd42
PE
7692 * editfns.c (Fformat): Remove unreachable code.
7693
8b913b57
AS
76942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7695
7696 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7697 change. (Bug#8496)
7698
a6744a35
EZ
76992011-04-13 Eli Zaretskii <eliz@gnu.org>
7700
7701 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7702 when at ZV. (Bug#8487)
7703
e7974947
AS
77042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7705
baad03f0
AS
7706 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7707 (Bug#8437)
7708 * keyboard.c (parse_tool_bar_item): Likewise.
7709 * sound.c (sound_cleanup, alsa_close): Likewise.
7710 * termcap.c (tgetent): Likewise.
7711 * xfns.c (x_default_font_parameter): Likewise.
7712 * xsettings.c (read_and_apply_settings): Likewise.
7713
e7974947
AS
7714 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7715 (overrun_check_free): Protoize.
7716
28272684
PE
77172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7718
7719 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7720 since callers should never pass a negative size.
7721 Change the signature to match that of plain 'read' and 'write'; see
7722 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7723 * lisp.h: Update prototypes of emacs_write and emacs_read.
7724
11997c76
EZ
77252011-04-11 Eli Zaretskii <eliz@gnu.org>
7726
7727 * xdisp.c (redisplay_window): Don't try to determine the character
7728 position of the scroll margin if the window start point w->startp
e896f03c 7729 is outside the buffer's accessible region. (Bug#8468)
11997c76 7730
8a2cbd72
EZ
77312011-04-10 Eli Zaretskii <eliz@gnu.org>
7732
7733 Fix write-region and its subroutines for buffers > 2GB.
7734 * fileio.c (a_write, e_write): Modify declaration of arguments and
7735 local variables to support buffers larger than 2GB.
7736 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7737
7738 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7739 argument, local variables, and return value.
7740
7741 * lisp.h: Update prototypes of emacs_write and emacs_read.
7742
7743 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7744
4073e537 77452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7746
1ebfdcb6
PE
7747 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7748
b2ded58d
PE
7749 Fix more problems found by GCC 4.6.0's static checks.
7750
7d66342c
PE
7751 * xdisp.c (vmessage): Use a better test for character truncation.
7752
bbf47d44
PE
7753 * charset.c (load_charset_map): <, not <=, for optimization,
7754 and to avoid potential problems with integer overflow.
9248994d 7755 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7756 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7757 * editfns.c (Fformat): Likewise.
1e69125e 7758 * syntax.c (skip_chars): Likewise.
3befa583 7759
e3019616
PE
7760 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7761 This also lets GCC 4.6.0 generate slightly better loop code.
7762
becfa255
PE
7763 * callint.c (Fcall_interactively): <, not <=, for optimization.
7764 (Fcall_interactively): Count the number of arguments produced,
7765 not the number of arguments given. This is simpler and lets GCC
7766 4.6.0 generate slightly better code.
7767
dae0cd48
PE
7768 * ftfont.c: Distingish more carefully between FcChar8 and char.
7769 The previous code passed unsigned char * to a functions like
7770 strlen and xstrcasecmp that expect char *, which does not
7771 conform to the C standard.
7772 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7773 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7774 char * when the C standard requires it.
7775
76032d70
PE
7776 * keyboard.c (read_char): Remove unused var.
7777
eb3f1cc8
PE
7778 * eval.c: Port to Windows vsnprintf (Bug#8435).
7779 Include <limits.h>.
7780 (SIZE_MAX): Define if the headers do not.
7781 (verror): Do not give up if vsnprintf returns a negative count.
7782 Instead, grow the buffer. This ports to Windows vsnprintf, which
7783 does not conform to C99. Problem reported by Eli Zaretskii.
7784 Also, simplify the allocation scheme, by avoiding the need for
7785 calling realloc, and removing the ALLOCATED variable.
7786
70476b54
PE
7787 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7788
12020a9e
PE
7789 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7790 But keep the doprint source code for now, as we might revamp it
7791 and use it again (Bug#8435).
ea6c7ae6
PE
7792 * lisp.h (doprnt): Remove.
7793 * Makefile.in (base_obj): Remove doprnt.o.
7794 * deps.mk (doprnt.o): Remove.
7795
5fdb398c
PE
7796 error: Print 32- and 64-bit integers portably (Bug#8435).
7797 Without this change, on typical 64-bit hosts error ("...%d...", N)
7798 was used to print both 32- and 64-bit integers N, which relied on
7799 undefined behavior.
61bdb816 7800 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7801 * lisp.h (error, verror): Mark as printf-like functions.
7802 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7803 Report overflow in size calculations when allocating printf buffer.
7804 Do not truncate output string at its first null byte.
7805 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7806 Truncate the output at a character boundary, since vsnprintf does not
7807 do that.
7808 * charset.c (check_iso_charset_parameter): Convert internal
7809 character to string before calling 'error', since %c now has the
7810 printf meaning.
7811 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7812 overflow when computing char to be passed to 'error'. Do not
7813 pass Lisp_Object to 'error'; pass the integer instead.
7814 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7815 formatted with plain %d.
7816
b189fa66
PE
7817 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7818
bff87ef0
PE
7819 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7820
7e2cac20
PE
7821 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7822
ce4d90b5
PE
7823 * xterm.c (x_catch_errors): Remove duplicate declaration.
7824
266c9547
PE
7825 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7826
79c49ad2
PE
7827 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7828
368f4090
JM
78292011-04-10 Jim Meyering <meyering@redhat.com>
7830
7831 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7832 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7833 return ssize_t not "int", and use size_t as the buffer length.
7834 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7835 * gnutls.h: Update declarations.
7836 * process.c (read_process_output): Use ssize_t, to match.
7837 (send_process): Likewise.
7838
a32d4040
CY
78392011-04-09 Chong Yidong <cyd@stupidchicken.com>
7840
7841 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7842
8546720e 78432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7844
04f2d78b
CB
7845 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7846 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7847
8546720e
GM
7848 * xterm.c (handle_one_xevent):
7849 * xmenu.c (create_and_show_popup_menu):
7850 * xselect.c (x_decline_selection_request)
7851 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7852
0a2f5c1a 78532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7854
7855 Fix some uses of `int' instead of EMACS_INT.
7856 * search.c (string_match_1, fast_string_match)
7857 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7858 (scan_buffer, find_next_newline_no_quit)
7859 (find_before_next_newline, search_command, Freplace_match)
7860 (Fmatch_data): Make some `int' variables be EMACS_INT.
7861
7862 * xdisp.c (display_count_lines): 3rd argument and return value now
7863 EMACS_INT. All callers changed.
7864 (pint2hrstr): Last argument is now EMACS_INT.
7865
7866 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7867 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7868 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7869 (decode_coding_utf_16, decode_coding_emacs_mule)
7870 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7871 (decode_coding_ccl, decode_coding_charset)
7872 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7873 (decode_coding_iso_2022, decode_coding_emacs_mule)
7874 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7875 <char_offset, last_offset>: Declare EMACS_INT.
7876 (encode_coding_utf_8, encode_coding_utf_16)
7877 (encode_coding_emacs_mule, encode_invocation_designation)
7878 (encode_designation_at_bol, encode_coding_iso_2022)
7879 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7880 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7881 Declare EMACS_INT.
7882 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7883 (encode_invocation_designation): Last argument P_NCHARS is now
7884 EMACS_INT.
7885 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7886 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7887
7888 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7889 All users changed.
7890
7891 * ccl.c (Fccl_execute_on_string): Declare some variables
7892 EMACS_INT.
7893
8546720e 78942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7895
7896 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7897
4e19a977
CS
78982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7899
7900 * process.c (Fformat_network_address): Doc fix.
7901
87302331
R
79022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7903
ee7683eb 7904 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7905
cbb59342
CY
79062011-04-08 Chong Yidong <cyd@stupidchicken.com>
7907
7908 * keyboard.c (read_char): Call Lisp function help-form-show,
7909 instead of using internal_with_output_to_temp_buffer.
7910 (Qhelp_form_show): New var.
e0d38eeb 7911 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7912
7913 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7914
7915 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7916
e67a13ab
CY
79172011-04-06 Chong Yidong <cyd@stupidchicken.com>
7918
04f2d78b
CB
7919 * process.c (Flist_processes): Remove to Lisp.
7920 (list_processes_1): Delete.
e67a13ab 7921
973f782d
EZ
79222011-04-06 Eli Zaretskii <eliz@gnu.org>
7923
7c106b1e
EZ
7924 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7925
973f782d
EZ
7926 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7927
41cf7d1a 79282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7929
ca23cc88
PE
7930 Fix more problems found by GCC 4.6.0's static checks.
7931
f390e2d5
PE
7932 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7933
42eea0d0
PE
7934 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7935
b69769da 7936 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7937
f9541e84
PE
7938 * xdisp.c (vmessage): Mark as a printf-like function.
7939
13841b55
PE
7940 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7941
c136c10f
PE
7942 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7943
5e2d4a30
PE
7944 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7945 printf-like functions.
7946 (tiff_load): Add casts to remove these marks before passing them
7947 to system-supplied API.
7948
583f48b9
PE
7949 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7950
b25d760e
PE
7951 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7952 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7953 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7954 directly, rather than having caller test rule sign. This avoids
7955 some unnecessary tests.
7956 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7957 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7958 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7959
bc7b6697 7960 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7961 (xfont_open): Avoid unnecessary tests.
bc7b6697 7962
27ccc379
PE
7963 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7964
dcd5c89a
PE
7965 * composite.h, composite.c (composition_gstring_put_cache):
7966 Use EMACS_INT, not int, for length.
7967
b13a45c6
PE
7968 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7969 breaking out part of COMPOSITION_DECODE_RULE.
7970 (COMPOSITION_DECODE_RULE): Use it.
7971 * composite.c (get_composition_id): Remove unused local vars,
7972 by using the new macro.
7973
1e792e4d
PE
7974 * textprop.c (set_text_properties_1): Change while to do-while,
7975 since the condition is always true at first.
7976
dc6c6455 7977 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7978 (interval_deletion_adjustment): Return unsigned value.
7979 All uses changed.
dc6c6455 7980
aba7731a
PE
7981 * process.c (list_processes_1, create_pty, read_process_output):
7982 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7983 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7984 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7985 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7986 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7987
fdfc4bf3
PE
7988 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7989
fca8fe46 7990 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7991 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7992
06a0259a 7993 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7994 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7995 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7996
e7b9e80f
PE
7997 * print.c (print_error_message): Avoid int overflow.
7998
56201685
PE
7999 * font.c (font_list_entities): Redo for clarity,
8000 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8001
78834453 8002 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8003 (font_score): Avoid potential overflow in diff calculation.
78834453 8004
0bc0b309 8005 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8006 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8007
e610eaca
PE
8008 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8009
b895abce
PE
8010 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8011 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8012 can always succeed if overflow has undefined behavior.
8013
1f1d9321 8014 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8015 (wordify): Omit three unnecessary tests.
1f1d9321 8016
c59478bc
PE
8017 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8018 All callers changed. This avoids the need for an unused var.
8019
79b73827
PE
8020 * casefiddle.c (casify_region): Remove var that is set but not used.
8021
a4db5dfe
PE
8022 * dired.c (file_name_completion): Remove var that is set but not used.
8023
43aae36e
PE
8024 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8025
2a47c44d 8026 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8027 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8028
a37c69bf
PE
8029 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8030 Check for integer overflow on size calculations.
8031
328ab8e7
PE
8032 * buffer.c (Fprevious_overlay_change): Remove var that is set
8033 but not used.
8034
e5a2a5cb
PE
8035 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8036 Remove vars that are set but not used.
8d84a6eb 8037 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8038 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8039
a60e5f68
PE
8040 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8041
f661cb61 8042 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8043 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8044
f0397f5a
PE
8045 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8046 that are set but not used.
8047
8664db06 8048 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8049 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8050
6abdaa4a
PE
8051 * xselect.c (x_get_local_selection, x_handle_property_notify):
8052 Remove vars that are set but not used.
8053
0ce7538d 8054 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8055 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8056
9ae848fc
PE
8057 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8058 Remove var that is set but not used.
0b918413
PE
8059 (scroll_bar_windows_size): Now size_t, not int.
8060 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8061 Check for overflow.
9ae848fc 8062
a5a62657
PE
8063 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8064 (map_tty_color) [!defined MSDOS]: Likewise.
8065
5c5cdd39
PE
8066 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8067
66ebf983
PE
8068 * coding.c: Remove vars that are set but not used.
8069 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8070 All callers changed.
8071 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8072 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8073 (decode_coding_charset): Remove vars that are set but not used.
8074
1be4d761
PE
8075 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8076 that is set but not used.
8077
47553fa8
PE
8078 * print.c (print_object): Remove var that is set but not used.
8079
1f7196bf 8080 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8081 The gnulib version avoids calling malloc in the usual case,
8082 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8083 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8084 * filelock.c (current_lock_owner): Likewise.
8085 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8086 * sysdep.c: Include allocator.h, careadlinkat.h.
8087 (emacs_no_realloc_allocator): New static constant.
8088 (emacs_readlink): New function.
fdb61804
PE
8089 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8090 ../lib/careadlinkat.h.
d1fdcab7 8091
f84c17c7
SM
80922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8093
8094 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8095 first non-nil return value).
8096
ef3862ad
JD
80972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8098
8099 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8100 if not defined (Bug#8403).
8101
376a7006
JB
81022011-04-02 Juanma Barranquero <lekktu@gmail.com>
8103
8104 * xdisp.c (display_count_lines): Remove parameter `start',
8105 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8106 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8107 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8108 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8109 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8110 and thereabouts. All callers changed.
8111 (get_per_char_metric): Remove parameter `f', unused since
8112 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8113
6ca3801d
JM
81142011-04-02 Jim Meyering <meyering@redhat.com>
8115
8116 do not dereference NULL upon failed strdup
8117 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8118 (ns_get_family): Likewise.
8119
d8e2b5ba
JB
81202011-04-02 Juanma Barranquero <lekktu@gmail.com>
8121
8122 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8123
8c74fcbd
JD
81242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8125
8126 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8127 later (Bug#8403).
8128
7200d79c
SM
81292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8130
03408648 8131 Add lexical binding.
7200d79c 8132
03408648
SM
8133 * window.c (Ftemp_output_buffer_show): New fun.
8134 (Fsave_window_excursion):
8135 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8136
8137 * lread.c (lisp_file_lexically_bound_p): New function.
8138 (Fload): Bind Qlexical_binding.
8139 (readevalloop): Remove `evalfun' arg.
8140 Bind Qinternal_interpreter_environment.
8141 (Feval_buffer): Bind Qlexical_binding.
8142 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8143 Mark as dynamic.
8144 (syms_of_lread): Declare `lexical-binding'.
8145
8146 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8147
8148 * keyboard.c (eval_dyn): New fun.
8149 (menu_item_eval_property): Use it.
ca105506
SM
8150
8151 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8152
03408648
SM
8153 * fns.c (concat, mapcar1): Accept byte-code-functions.
8154
8155 * eval.c (Fsetq): Handle lexical vars.
8156 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8157 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8158 (FletX, Flet): Obey lexical binding.
8159 (Fcommandp): Handle closures.
8160 (Feval): New `lexical' arg.
8161 (eval_sub): New function extracted from Feval. Use it almost
8162 everywhere where Feval was used. Look up vars in lexical env.
8163 Handle closures.
8164 (Ffunctionp): Move from subr.el.
8165 (Ffuncall): Handle closures.
8166 (apply_lambda): Remove `eval_flags'.
8167 (funcall_lambda): Handle closures and new byte-code-functions.
8168 (Fspecial_variable_p): New function.
8169 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8170 but without exporting it to Lisp.
23aba0ea 8171
23aba0ea 8172 * doc.c (Fdocumentation, store_function_docstring):
03408648 8173 * data.c (Finteractive_form): Handle closures.
23aba0ea 8174
03408648
SM
8175 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8176 interactive spec.
ba83908c 8177
04f2d78b
CB
8178 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8179 New byte-codes.
03408648
SM
8180 (exec_byte_code): New function extracted from Fbyte_code to handle new
8181 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8182
03408648 8183 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8184
03408648 8185 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8186
e2abce01
JB
81872011-03-31 Juanma Barranquero <lekktu@gmail.com>
8188
8189 * xdisp.c (redisplay_internal): Fix prototype.
8190
63696a73 81912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8192
63696a73 8193 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8194 (try_scrolling): Use it when setting scroll_limit.
8195 Limit scrolling to 100 screen lines.
63696a73
EZ
8196 (redisplay_window): Even when falling back on "recentering",
8197 position point in the window according to scroll-conservatively,
8198 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8199
8200 (try_scrolling): When point is above the window, allow searching
8201 as far as scroll_max, or one screenful, to compute vertical
8202 distance from PT to the scroll margin position. This prevents
8203 try_scrolling from unnecessarily failing when
8204 scroll-conservatively is set to a value slightly larger than the
8205 window height. Clean up the case of PT below the margin at bottom
8206 of window: scroll_max can no longer be INT_MAX. When aggressive
8207 scrolling is in use, don't let point enter the opposite scroll
8208 margin as result of the scroll.
8209 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8210 threshold of 100 lines for never-recentering scrolling.
8211
e4cc2dfc
JB
82122011-03-31 Juanma Barranquero <lekktu@gmail.com>
8213
8214 * dispextern.h (move_it_by_lines):
8215 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8216 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8217 (message_log_check_duplicate): Remove parameters `prev_bol' and
8218 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8219 (redisplay_internal): Remove parameter `preserve_echo_area',
8220 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8221
8222 * indent.c (Fvertical_motion):
8223 * window.c (window_scroll_pixel_based, Frecenter):
8224 Don't pass `need_y_p' to `move_it_by_lines'.
8225
1c470562
SM
82262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8227
44f230aa
SM
8228 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8229 steal a few bits to be more compact.
8230 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8231 Remove unneeded casts.
8232
1c470562
SM
8233 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8234
888adce9
ZK
82352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8236
8237 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8238 binding" message (bug#7967).
8239
f838ed7b
PE
82402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8241
77861b95
PE
8242 Fix more problems found by GCC 4.6.0's static checks.
8243
de6dbc14
PE
8244 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8245 Remove unused local var.
8246
f838ed7b
PE
8247 * editfns.c (Fmessage_box): Remove unused local var.
8248
792c7b2b
PE
8249 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8250 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8251 Omit unused local vars.
c499e557 8252 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8253 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8254 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8255 Omit unused local var.
8256
ba0165e1
PE
8257 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8258 Don't assume string length fits in int.
32ad8845 8259 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8260 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8261
3c59b4c9
PE
8262 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8263 instead of alloca (Bug#8344).
8264
a3eed478 8265 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8266 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8267
eb4d412d
PE
8268 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8269
1658b401
PE
8270 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8271 concerns.
8272
8273 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8274
8275 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8276
9a2c6e05
PE
8277 * keyboard.c (syms_of_keyboard): Use the same style as later
8278 in this function when indexing through an array. This also
8279 works around GCC bug 48267.
8280
03d0a109
PE
8281 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8282
44f730c8
PE
8283 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8284
fe75f926
PE
8285 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8286 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8287
ffa8c828
PE
8288 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8289 This avoids undefined behavior on integer overflow, and is a bit
8290 more convenient anyway since it is compared to a size_t variable.
8291
c5101a77
PE
8292 Variadic C functions now count arguments with size_t, not int.
8293 This avoids an unnecessary limitation on 64-bit machines, which
8294 caused (substring ...) to crash on large vectors (Bug#8344).
8295 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8296 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8297 All variadic functions and their callers changed accordingly.
c5101a77
PE
8298 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8299 * data.c (arith_driver, float_arith_driver): Likewise.
8300 * editfns.c (general_insert_function): Likewise.
8301 * eval.c (struct backtrace.nargs, interactive_p)
8302 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8303 (funcall_lambda, mark_backtrace): Likewise.
8304 * fns.c (concat): Likewise.
8305 * frame.c (x_set_frame_parameters): Likewise.
8306 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8307 0 if not found, not -1. All callers changed.
8308
dd3f25f7
PE
8309 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8310 (stack_copy_size): Now size_t, not int.
8311 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8312
461c2ab9
JB
83132011-03-28 Juanma Barranquero <lekktu@gmail.com>
8314
8315 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8316 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8317 All callers changed.
8318
8319 * lisp.h (multibyte_char_to_unibyte):
8320 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8321 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8322 * character.h (CHAR_TO_BYTE8):
8323 * cmds.c (internal_self_insert):
8324 * editfns.c (general_insert_function):
8325 * keymap.c (push_key_description):
8326 * search.c (Freplace_match):
8327 * xdisp.c (message_dolog, set_message_1): All callers changed.
8328
f6d62986
SM
83292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8330
8331 * keyboard.c (safe_run_hook_funcall): New function.
8332 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8333 don't set the hook to nil, but remove the offending function instead.
8334 (Qcommand_hook_internal): Remove, unused.
8335 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8336 Vcommand_hook_internal.
8337
8338 * eval.c (enum run_hooks_condition): Remove.
8339 (funcall_nil, funcall_not): New functions.
8340 (run_hook_with_args): Call each function through a `funcall' argument.
8341 Remove `cond' argument, now redundant.
8342 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8343 (Frun_hook_with_args_until_failure): Adjust accordingly.
8344 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8345
1db5b1ad
JB
83462011-03-28 Juanma Barranquero <lekktu@gmail.com>
8347
8348 * dispextern.h (string_buffer_position): Remove declaration.
8349
8350 * print.c (strout): Remove parameter `multibyte', unused since
8351 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8352
8353 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8354 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8355 All callers changed.
8356
8357 * w32.c (_wsa_errlist): Use braces for struct initializers.
8358
8359 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8360 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8361 All callers changed.
8362 (string_buffer_position): Likewise. Also, make static (it's never
8363 used outside xdisp.c).
8364 (cursor_row_p): Remove parameter `w', unused since
8365 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8366 (decode_mode_spec): Remove parameter `precision', introduced during
8367 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8368 All callers changed.
8369
5ffb62aa
JD
83702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8371
8372 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8373
461c2ab9 83742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8375
8376 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8377 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8378 (ns_update_auto_hide_menu_bar): New functions.
8379 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8380 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8381 ns_constrain_all_frames.
8382 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8383 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8384
5c380ffb
JD
83852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8386
8387 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8388
9af30bdf
GM
83892011-03-27 Glenn Morris <rgm@gnu.org>
8390
8391 * syssignal.h: Replace RETSIGTYPE with void.
8392 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8393 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8394 Replace SIGTYPE with void everywhere.
8395 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8396 * s/template.h (SIGTYPE): Remove commented out definition.
8397
e2abce01
JB
83982011-03-26 Eli Zaretskii <eliz@gnu.org>
8399
8400 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8401 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8402
f868cd8a
JB
84032011-03-26 Juanma Barranquero <lekktu@gmail.com>
8404
59eb0929
JB
8405 * w32.c (read_unc_volume): Use parameter `henum', instead of
8406 global variable `wget_enum_handle'.
8407
8408 * keymap.c (describe_vector): Remove parameters `indices' and
8409 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8410 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8411
f868cd8a
JB
8412 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8413
8414 * keyboard.c (timer_check): Remove parameter `do_it_now',
8415 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8416 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8417 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8418
8419 * keyboard.c (read_char):
8420 * w32menu.c (w32_menu_display_help):
8421 * xmenu.c (show_help_event, menu_help_callback):
8422 Adjust calls to `show_help_echo'.
8423
8424 * gtkutil.c (xg_maybe_add_timer):
8425 * keyboard.c (readable_events):
8426 * process.c (wait_reading_process_output):
8427 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8428
8429 * insdel.c (adjust_markers_gap_motion):
8430 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8431 (gap_left, gap_right): Don't call it.
8432
2ecf6fdb
CY
84332011-03-25 Chong Yidong <cyd@stupidchicken.com>
8434
8435 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8436 incurred during fontification.
8437
6b1f9ba4
JB
84382011-03-25 Juanma Barranquero <lekktu@gmail.com>
8439
8440 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8441 (DEFVAR_PER_BUFFER): Don't pass it.
8442
8443 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8444 (scrolling_window): Don't pass it.
8445
0f4a96b5
JB
84462011-03-25 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8449
8450 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8451 and `suffix'.
8452 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8453 of variables specific to SELinux and computation of `encoded_absname'.
8454
8455 * image.c (XPutPixel): Remove unused variable `height'.
8456
8457 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8458
8459 * unexw32.c (get_section_info): Remove unused variable `section'.
8460
8461 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8462 (system_process_attributes): Remove unused variable `sess'.
8463 (sys_read): Remove unused variable `err'.
8464
8465 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8466 (w32_wnd_proc): Remove unused variable `isdead'.
8467 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8468 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8469 (x_create_tip_frame): Remove unused variable `tem'.
8470
8471 * w32inevt.c (w32_console_read_socket):
8472 Remove unused variable `no_events'.
8473
8474 * w32term.c (x_draw_composite_glyph_string_foreground):
8475 Remove unused variable `width'.
8476
1149507c
JB
84772011-03-24 Juanma Barranquero <lekktu@gmail.com>
8478
8479 * w32term.c (x_set_glyph_string_clipping):
8480 Don't pass uninitialized region to CombineRgn.
8481
9c88f339
JB
84822011-03-23 Juanma Barranquero <lekktu@gmail.com>
8483
8484 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8485 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8486 (Fx_close_connection): Remove unused variable `i'.
8487
8488 * w32font.c (w32font_draw): Return number of glyphs.
8489 (w32font_open_internal): Remove unused variable `i'.
8490 (w32font_driver): Add missing initializer.
8491
8492 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8493 (fill_in_menu): Remove unused variable `items_added'.
8494
8495 * w32term.c (last_mouse_press_frame): Remove static global variable.
8496 (w32_clip_to_row): Remove unused variable `f'.
8497 (x_delete_terminal): Remove unused variable `i'.
8498
8499 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8500 (NOTHING): Remove unused static global variable.
8501 (uniscribe_check_otf): Remove unused variable `table'.
8502 (uniscribe_font_driver): Add missing initializers.
8503
dee091a3
JD
85042011-03-23 Julien Danjou <julien@danjou.info>
8505
8506 * term.c (Fsuspend_tty, Fresume_tty):
8507 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8508 * window.c (temp_output_buffer_show):
8509 * insdel.c (signal_before_change):
8510 * frame.c (Fhandle_switch_frame):
8511 * fileio.c (Fdo_auto_save):
8512 * emacs.c (Fkill_emacs):
8513 * editfns.c (save_excursion_restore):
8514 * cmds.c (internal_self_insert):
8515 * callint.c (Fcall_interactively):
8516 * buffer.c (Fkill_all_local_variables):
8517 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8518 Use Frun_hooks.
0f4a96b5 8519 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8520 unconditionally since it does the check itself.
dee091a3 8521
2c520ab5 85222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8523
c9c49752
PE
8524 Fix more problems found by GCC 4.5.2's static checks.
8525
8abc3f12
PE
8526 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8527 the first time through the loop, since we know p0 < p1 then.
8528 This also avoids a gcc -Wstrict-overflow warning.
8529
a2d26660
PE
8530 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8531 leading to a memory leak, possible in functions like
8532 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8533 of objects (Bug#8318).
a2d26660 8534
916c72e9
PE
8535 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8536 that could (at least in theory) be that large.
8537
19ab8a18
PE
8538 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8539 This is less likely to overflow, and avoids undefined behavior if
8540 overflow does occur. All callers changed. Use strtoul to scan
8541 for the unsigned long integer.
b7cbbd6f
PE
8542 (pint2hrstr): Simplify and tune code slightly.
8543 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8544
f0641eff
PE
8545 * scroll.c (do_scrolling): Work around GCC bug 48228.
8546 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8547
7f650bb9
PE
8548 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8549 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8550 (validate_x_resource_name): Simplify count usage.
8551 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8552
37dd57d1
PE
8553 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8554 fail (Bug#8306).
81e56e61 8555
699979fc 8556 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8557
401bf9b4
PE
8558 * process.c (Fmake_network_process): Use socklen_t, not int,
8559 where POSIX says socklen_t is required in portable programs.
8560 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8561 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8562 (Fmake_network_process, server_accept_connection):
8563 (wait_reading_process_output, read_process_output):
8564 Likewise.
8565
b93aacde
PE
8566 * process.c: Rename or move locals to avoid shadowing.
8567 (list_processes_1, Fmake_network_process):
8568 (read_process_output_error_handler, exec_sentinel_error_handler):
8569 Rename or move locals.
4dc343ee 8570 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8571 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8572 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8573 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8574 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8575
af8a867c 8576 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8577 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8578 Include tparam.h instead, since it declares them.
af8a867c
PE
8579 * cm.h (PC): Remove extern decl; tparam.h now does this.
8580 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8581 * terminfo.c: Include tparam.h, to check interfaces.
8582 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8583 (tparam): Adjust signature to match interface in tparam.h;
8584 this removes some undefined behavior. Check that outstring and len
8585 are zero, which they always are with Emacs.
8586 * tparam.h (PC, BC, UP): New extern decls.
8587
0248044d 8588 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8589 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8590
8ff096c1 8591 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8592 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8593 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8594 (ftfont_list): Remove unused local.
49eaafba
PE
8595 (get_adstyle_property, ftfont_pattern_entity):
8596 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8597 Rename locals to avoid shadowing.
8ff096c1 8598
e2be39f6
PE
8599 * xfont.c (xfont_list_family): Mark var as initialized.
8600
c9735e30
PE
8601 * xml.c (make_dom): Now static.
8602
8f5201ae
PE
8603 * composite.c (composition_compute_stop_pos): Rename local to
8604 avoid shadowing.
b246f932
PE
8605 (composition_reseat_it): Remove unused locals.
8606 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8607 (composition_update_it): Mark var as initialized.
11b61122
PE
8608 (find_automatic_composition): Mark vars as initialized,
8609 with a FIXME (Bug#8290).
8f5201ae 8610
760fbc2c
PE
8611 character.h: Rename locals to avoid shadowing.
8612 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8613 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8614 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8615 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8616 to avoid shadowing.
8617
ff08eb85
PE
8618 * textprop.c (property_change_between_p): Remove; unused.
8619
fc7bf025
PE
8620 * intervals.c (interval_start_pos): Now static.
8621
235d7abc
PE
8622 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8623
44f230aa
SM
8624 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8625 Rename locals to avoid shadowing.
3e7d6594 8626
50060332
PE
8627 * sound.c (wav_play, au_play, Fplay_sound_internal):
8628 Fix pointer signedness.
d01f234b 8629 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8630 (wav_play): Initialize a variable to 0, to prevent undefined
8631 behavior (Bug#8278).
50060332 8632
c4fc4e30
PE
8633 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8634
918436ed
PE
8635 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8636
c939f91b
PE
8637 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8638 clobbering (Bug#8298).
b9c7f648
PE
8639 * sysdep.c (sys_subshell): Likewise.
8640 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8641
6bd8c144
PE
8642 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8643 This should get cleaned up, so that child_setup has the
8644 same signature on all platforms.
8645
7710357c 8646 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8647 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8648
c59da222
CY
86492011-03-22 Chong Yidong <cyd@stupidchicken.com>
8650
8651 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8652 not to be necessary, and produces flickering.
8653
66b87493
GM
86542011-03-20 Glenn Morris <rgm@gnu.org>
8655
8656 * config.in: Remove file.
8657
45b6f6d5
JB
86582011-03-20 Juanma Barranquero <lekktu@gmail.com>
8659
8660 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8661 are now in src/globals.h.
8662 (syms_of_minibuf): Remove spurious & from previous change.
8663
cd394be1 86642011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8665
8666 * minibuf.c (completing-read-function): New variable.
8667 (completing-read-default): Rename from completing-read.
8668 (completing-read): Call completing-read-function.
8669
b14e3e21
CY
86702011-03-19 Juanma Barranquero <lekktu@gmail.com>
8671
8672 * xfaces.c (Fx_load_color_file):
8673 Read color file from absolute filename (bug#8250).
8674
f2b726e6
JB
86752011-03-19 Juanma Barranquero <lekktu@gmail.com>
8676
8677 * makefile.w32-in: Update dependencies.
8678
09f6ff02
EZ
86792011-03-17 Eli Zaretskii <eliz@gnu.org>
8680
8681 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8682
29a6015a
PE
86832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8684
a3a6c54e
PE
8685 Fix more problems found by GCC 4.5.2's static checks.
8686
b766f867
PE
8687 * process.c (make_serial_process_unwind, send_process_trap):
8688 (sigchld_handler): Now static.
8689
be02381c
PE
8690 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8691 That way, the code declares only the vars that it needs.
8692 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8693 * s/cygwin.h (PTY_ITERATION): Likewise.
8694 * s/darwin.h (PTY_ITERATION): Likewise.
8695 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8696
57048744
PE
8697 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8698 * process.c (allocate_pty): Don't declare stb unless it's needed.
8699
7914961c 8700 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8701 (CONSTANTLIM): Remove; unused.
8702 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8703 Define only if needed.
7914961c 8704
b3967b18
PE
8705 * unexelf.c (unexec): Name an expression,
8706 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8707 Use a different way to cause a compilation error if anyone uses
8708 n rather than nn, a way that does not involve shadowing.
73366a00 8709 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8710
29a6015a
PE
8711 * deps.mk (unexalpha.o): Remove; unused.
8712
43cfc33e 8713 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8714 * unexec.h: New file.
ce701a33
PE
8715 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8716 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8717 Depend on unexec.h.
8718 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8719 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8720 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8721 Change as necessary to match prototype in unexec.h.
ce701a33 8722
01f44d5a
PE
8723 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8724 shadowing.
4f63c6bb 8725 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8726
a6670b0b
PE
8727 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8728 Rename locals to avoid shadowing.
8729
cef2010d 8730 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8731 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8732
d4d7173a
PE
8733 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8734
f08b802a
PE
8735 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8736 warning when compiling print.c.
8737
3ddb0639
PE
8738 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8739 instead of using an uninitialized var.
5ad03b97 8740 (font_sort_entities): Mark var as initialized.
3ddb0639 8741
170a2692
PE
8742 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8743
e663c700
PE
8744 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8745 pointers to constants.
89bc529a 8746 (font_parse_fcname): Remove unused vars.
7b81e2d0 8747 (font_delete_unmatched): Now static.
ea838e10 8748 (font_get_spec): Remove; unused.
13a547c6
PE
8749 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8750 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8751 Rename or move locals to avoid shadowing.
e663c700 8752
2a80c887 8753 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8754 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8755
1384fa33 8756 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8757 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8758
8b2c52e9
PE
8759 * alloc.c (mark_backtrace): Move decl from here ...
8760 * lisp.h: ... to here, so that it can be checked.
8761
475545b5 8762 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8763 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8764 (lisp_indirect_variable): Name an expression,
8765 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8766 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8767
b1349114 8768 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8769 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8770 Use const pointer when appropriate.
b1349114 8771
a2928364
PE
8772 * lisp.h (get_system_name, get_operating_system_release):
8773 Move decls here, to check interfaces.
8774 * process.c (get_operating_system_release): Move decl to lisp.h.
8775 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8776 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8777 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8778 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8779 (Fformat_time_string, Fencode_time, Finsert_char):
8780 (Ftranslate_region_internal, Fformat):
8781 Rename or remove local vars to avoid shadowing.
9710023e 8782 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8783
a415e694
PE
8784 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8785 avoid shadowing.
8786
8ef4622d
PE
8787 * lisp.h (eassert): Check that the argument compiles, even if
8788 ENABLE_CHECKING is not defined.
8789
946f9a5b
PE
8790 * data.c (Findirect_variable): Name an expression, to avoid
8791 gcc -Wbad-function-cast warning.
112396d6 8792 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8793 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8794 (Fmake_variable_buffer_local, Fmake_local_variable):
8795 Mark variables as initialized.
52746918 8796 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8797
e5aab7e7 8798 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8799 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8800 Rename locals to avoid shadowing.
dff45157
PE
8801 (mark_stack): Move local variables into the #ifdef region where
8802 they're used.
7bc26fdb
PE
8803 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8804 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8805 needed otherwise.
8806 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8807 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8808 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8809
e5aab7e7
PE
8810 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8811 avoids undefined behavior in theory.
8812
4da60324
PE
8813 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8814
88043301
PE
8815 Use functions, not macros, for up- and down-casing (Bug#8254).
8816 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8817 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8818 to use the following functions instead of these macros.
8819 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8820 EMACS_INT, since callers assume the returned value fits in int.
8821 (upcase1): Likewise, for UPCASE_TABLE.
8822 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8823 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8824 the race-condition problem in the old DOWNCASE.
88043301 8825
19ed5445
PE
8826 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8827 Rename locals to avoid shadowing.
8828 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8829 (regex_compile, re_search_2, re_match_2_internal):
8830 Remove unused local vars.
952db0d7
PE
8831 (FREE_VAR): Rewrite so as not to use empty "else",
8832 which gcc can warn about.
da053e48 8833 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8834 (RETALLOC_IF): Define only if needed.
8835 (WORDCHAR_P): Likewise. This one is never needed, but is used
8836 only in a comment talking about a compiler bug, so put inside
8837 the #if 0 of that comment.
8838 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8839 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8840 Remove; unused.
19ed5445 8841
1f3561e4 8842 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8843 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8844 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8845
ded6f8f7
PE
8846 * search.c (simple_search): Remove unused var.
8847
dbd37a95
PE
8848 * dired.c (compile_pattern): Move decl from here ...
8849 * lisp.h: ... to here, so that it can be checked.
8850 (struct re_registers): New forward decl.
8851
7e47afad
PE
8852 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8853
85f24f61
PE
8854 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8855 All uses changed.
8856 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8857 Rename locals to avoid shadowing.
5671df8f 8858 (Fvertical_motion): Mark locals as initialized.
85f24f61 8859
181aa2be 8860 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8861 (casify_region): Mark local as initialized.
181aa2be 8862
930d429c
PE
8863 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8864
7082eac6
PE
8865 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8866 New macros, so that the caller can use some names other than
8867 gcpro1, gcpro2, etc.
8868 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8869 of the new macros.
8870 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8871 argument, for consistency with GCPRO2_VAR, etc: it is now the
8872 prefix of the variable, not the variable itself. All uses
8873 changed.
38b2c076
PE
8874 * dired.c (directory_files_internal, file_name_completion):
8875 Rename locals to avoid shadowing.
8876
15206ed9
PE
8877 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8878 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8879 dired.c's scmp function, had undefined behavior.
8880 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8881 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8882 * buffer.h: ... to here, because these macros use current_buffer,
8883 and the new implementation with inline functions needs to have
8884 current_buffer in scope now, rather than later when the macros
8885 are used.
8886 (downcase, upcase1): New static inline functions.
8887 (DOWNCASE, UPCASE1): Reimplement using these functions.
8888 This avoids undefined behavior in expressions like
8889 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8890 from race conditions in accessing the global variables
8891 case_temp1 and case_temp2.
8892 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8893 * lisp.h (case_temp1, case_temp2): Remove their decls.
8894 * character.h (ASCII_CHAR_P): Move from here ...
8895 * lisp.h: ... to here, so that the inline functions mentioned
8896 above can use them.
8897
4a6bea26
PE
8898 * dired.c (directory_files_internal_unwind): Now static.
8899
f14b7e14
PE
8900 * fileio.c (file_name_as_directory, directory_file_name):
8901 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8902 Now static.
2893f146
PE
8903 (file_name_as_directory): Use const pointers when appropriate.
8904 (Fexpand_file_name): Likewise. In particular, newdir might
8905 point at constant storage, so make it a const pointer.
fd4ead52 8906 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8907 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8908 signedness issues.
f839df0c
PE
8909 (Fset_file_times, Finsert_file_contents, auto_save_error):
8910 Rename locals to avoid shadowing.
f14b7e14 8911
5716756e 8912 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8913 (Ftry_completion, Fall_completions): Rename or remove locals
8914 to avoid shadowing.
5716756e 8915
b4c3046a
PE
8916 * marker.c (bytepos_to_charpos): Remove; unused.
8917
b45db522
PE
8918 * lisp.h (verify_bytepos, count_markers): New decls,
8919 so that gcc does not warn that these functions aren't declared.
8920
85876d07
PE
8921 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8922 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8923 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8924 (copy_text): Remove unused local var.
85876d07 8925
03d78a21 8926 * filelock.c (within_one_second): Now static.
b3dd38ab 8927 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8928
5df8f01b
PE
8929 * buffer.c (fix_overlays_before): Mark locals as initialized.
8930 (fix_start_end_in_overlays): Likewise. This function should be
8931 simplified by using pointers-to-pointers, but that's a different
8932 matter.
b1d876f1 8933 (switch_to_buffer_1): Now static.
8f54f30a
PE
8934 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8935 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8936
a70072c9 8937 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8938 Fix pointer signedness issue.
edced198
PE
8939 (sys_subshell): Mark local as volatile if checking for lint,
8940 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8941 (MAXPATHLEN): Define only if needed.
a70072c9 8942
a0977c44
PE
8943 * process.c (serial_open, serial_configure): Move decls from here ...
8944 * systty.h: ... to here, so that they can be checked.
8945
a884fdcc
PE
8946 * fns.c (get_random, seed_random): Move extern decls from here ...
8947 * lisp.h: ... to here, so that they can be checked.
8948
604efe86 8949 * sysdep.c (reset_io): Now static.
b8950c94 8950 (wait_for_termination_signal): Remove; unused.
604efe86 8951
38fc62d9
PE
8952 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8953 (copy_keymap_item, append_key, push_text_char_description):
8954 Now static.
1004a21a 8955 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8956 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8957 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8958 (describe_map_tree):
8959 Rename locals to avoid shadowing.
38fc62d9 8960
2f2650da
PE
8961 * keyboard.c: Declare functions static if they are not used elsewhere.
8962 (echo_char, echo_dash, cmd_error, top_level_2):
8963 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8964 (read_char, kbd_buffer_get_event, make_lispy_position):
8965 (make_lispy_event, make_lispy_movement, apply_modifiers):
8966 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8967 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8968 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8969 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8970 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8971
a053e86c 8972 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8973 (mark_kboards): Move decl here ...
8974 * alloc.c (mark_kboards): ... from here.
a053e86c 8975
4752793e
PE
8976 * lisp.h (force_auto_save_soon): New decl.
8977
74f10ca7 8978 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8979 (DEFINE_DUMMY_FUNCTION): New macro.
8980 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8981 Use it.
c03cd23f
PE
8982 (main): Add casts to avoid warnings
8983 if GCC considers string literals to be constants.
74f10ca7 8984
022e70d4
PE
8985 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8986
59d6fe83
PE
8987 * dbusbind.c: Pointer signedness fixes.
8988 (xd_signature, xd_append_arg, xd_initialize):
8989 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8990 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8991 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8992 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8993
78320123
PE
8994 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8995 if GCC considers string literals to be constants.
49cebcca 8996 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8997
35ac2a97
SM
89982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8999
fb103ca9
SM
9000 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9001 (print_preprocess, print_object): New macro to fix last change.
9002
35ac2a97
SM
9003 * print.c (print_preprocess): Don't forget font objects.
9004
62973b41
JB
90052011-03-16 Juanma Barranquero <lekktu@gmail.com>
9006
9007 * emacs.c (USAGE3): Doc fixes.
9008
0e48bb22
AS
90092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9010
9011 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9012 structure.
9013
7684e57b
JB
90142011-03-14 Juanma Barranquero <lekktu@gmail.com>
9015
9016 * lisp.h (VWindow_system, Qfile_name_history):
9017 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9018 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9019 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9020
9021 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9022 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9023
9024 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9025 * w32console.c (detect_input_pending, read_input_pending)
9026 (encode_terminal_code):
9027 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9028 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9029 (w32_system_caret_y, Qfile_name_history):
9030 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9031 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9032 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9033 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9034 * w32proc.c (Qlocal, report_file_error):
9035 * w32term.c (Vwindow_system, updating_frame):
9036 * w32uniscribe.c (initialized, uniscribe_font_driver):
9037 Remove unneeded extern declarations.
9038
2aa46d6c
CY
90392011-03-14 Chong Yidong <cyd@stupidchicken.com>
9040
c96bbc66 9041 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9042
cffc6f3b
CY
90432011-03-13 Chong Yidong <cyd@stupidchicken.com>
9044
9045 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9046 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9047 These macros can no longer be used for assignment.
9048
44f230aa
SM
9049 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9050 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9051 (record_buffer_markers, fetch_buffer_markers): New functions for
9052 recording and fetching special buffer markers.
9053 (set_buffer_internal_1, set_buffer_temp): Use them.
9054
9055 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9056
9057 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9058
9059 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9060 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9061
9062 * xdisp.c (hscroll_window_tree):
9063 (reconsider_clip_changes): Use PT instead of BUF_PT.
9064
d251f04b
EZ
90652011-03-13 Eli Zaretskii <eliz@gnu.org>
9066
9067 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9068 $(EMACS_ROOT)/lib/intprops.h.
9069
f0c77cd1
PE
90702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9071
3eca4629
PE
9072 Fix more problems found by GCC 4.5.2's static checks.
9073
7c86ee98
PE
9074 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9075 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9076 (xg_free_frame_widgets): Make it clear that a local variable is
9077 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9078 (gdk_window_get_screen): Make it clear that this macro is needed
9079 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9080 (int_gtk_range_get_value): New function, which avoids a diagnostic
9081 from gcc -Wbad-function-cast.
9082 (xg_set_toolkit_scroll_bar_thumb): Use it.
9083 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9084 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9085 (get_utf8_string, xg_get_file_with_chooser):
9086 Rename locals to avoid shadowing.
9087 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9088
41729b81
PE
9089 * xgselect.c (xg_select): Remove unused var.
9090
f0c77cd1
PE
9091 * image.c (four_corners_best): Mark locals as initialized.
9092 (gif_load): Initialize transparent_p to zero (Bug#8238).
9093 Mark another local as initialized.
ec6cf4c6 9094 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9095
ce0ad53d 9096 * image.c (clear_image_cache): Now static.
d5d5a617 9097 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9098 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9099 (x_edge_detection): Remove unnecessary cast that
9100 gcc -Wbad-function-cast diagnoses.
2037898d 9101 (gif_load): Fix pointer signedness.
6ae141d6
PE
9102 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9103 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9104
33383987 91052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9106
d32df629
PE
9107 Improve quality of tests for time stamp overflow.
9108 For example, without this patch (encode-time 0 0 0 1 1
9109 1152921504606846976) returns the obviously-bogus value (-948597
9110 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9111 reports time overflow. See
9112 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9113 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9114 * editfns.c: Include limits.h and intprops.h.
9115 (TIME_T_MIN, TIME_T_MAX): New macros.
9116 (time_overflow): Move earlier, to before first use.
9117 (hi_time, lo_time): New functions, for an accurate test for
9118 out-of-range times.
9119 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9120 (Fget_internal_run_time): Don't assume time_t fits in int.
9121 (make_time): Use list2 instead of Fcons twice.
9122 (Fdecode_time): More accurate test for out-of-range times.
9123 (check_tm_member): New function.
9124 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9125 (lisp_time_argument): Don't rely on undefined left-shift and
9126 right-shift behavior when checking for time stamp overflow.
8be6f318 9127
fe31d94c
PE
9128 * editfns.c (time_overflow): New function, refactoring common code.
9129 (Fformat_time_string, Fdecode_time, Fencode_time):
9130 (Fcurrent_time_string): Use it.
9131
8be6f318
PE
9132 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9133 * dired.c (make_time): Move to ...
9134 * editfns.c (make_time): ... here.
9135 * systime.h: Note the move.
9136
09d9db2c 91372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9138
126bc0dc
YM
9139 * fringe.c (update_window_fringes): Remove unused variables.
9140
c47cbdfd
YM
9141 * unexmacosx.c (copy_data_segment): Also copy __got section.
9142 (Bug#8223)
9143
7ac80be9
EZ
91442011-03-12 Eli Zaretskii <eliz@gnu.org>
9145
c96bbc66 9146 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9147 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9148 Constify `char *' arguments and their references according to
9149 prototypes in tparam.h.
9150
ecb0f94d 9151 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9152
7ac80be9
EZ
9153 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9154 Adapt all references accordingly.
9155
9156 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9157
ef1fd07e
TT
91582011-03-11 Tom Tromey <tromey@redhat.com>
9159
9160 * buffer.c (syms_of_buffer): Remove obsolete comment.
9161
7ef4b50c
EZ
91622011-03-11 Eli Zaretskii <eliz@gnu.org>
9163
9164 * termhooks.h (encode_terminal_code): Declare prototype.
9165
9166 * msdos.c (encode_terminal_code): Don't declare prototype.
9167
9168 * term.c (encode_terminal_code): Now external again, used by
9169 w32console.c and msdos.c.
9170
44f230aa
SM
9171 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9172 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9173
4b1ec863 91742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9175
1714f52b 9176 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9177
4b1ec863
PE
9178 * fringe.c (update_window_fringes): Mark locals as initialized
9179 (Bug#8227).
9180 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9181
524c7aa6
PE
9182 * alloc.c (mark_fringe_data): Move decl from here ...
9183 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9184 to check its interface.
9185 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9186
a5c0af81 9187 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9188 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9189 (fontset_font): Mark local as initialized.
a9a06e0b 9190 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9191
b4716021
PE
9192 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9193
811e9bac 9194 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9195 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9196 (x_own_selection, Fx_disown_selection_internal): Rename locals
9197 to avoid shadowing.
9198 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9199
7e3ab302
PE
9200 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9201 so that the caller can use some name other than gcpro1.
9202 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9203 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9204 (Fx_backspace_delete_keys_p):
9205 Use them to avoid shadowing, and rename vars to avoid shadowing.
9206 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9207 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9208 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9209 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9210 Remove unused locals.
7e3ab302
PE
9211 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9212 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9213 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9214 macros.
f78faa98 9215
e2b13473
PE
9216 * xterm.h (x_mouse_leave): New decl.
9217
77f23912
PE
9218 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9219 Remove unused functions.
cdf4ba58
PE
9220 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9221 (x_calc_absolute_position): Now static.
7411c686 9222 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9223 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9224 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9225 unless they are used.
38d0b34a
PE
9226 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9227 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9228 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9229 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9230 (x_error_catcher, x_connection_closed, x_error_handler):
9231 (x_error_quitter, xembed_send_message, x_iconify_frame):
9232 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9233 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9234 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9235
44f230aa
SM
9236 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9237 Rename or move locals to avoid shadowing.
6b463e58 9238 (tty_defined_color, merge_face_heights): Now static.
5967d051 9239 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9240 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9241 does not deduce is never used uninitialized.
73719eba
PE
9242 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9243 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9244
426994c3 9245 * terminal.c (store_terminal_param): Now static.
5489860b 9246
032f1620 9247 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9248 (set_frame_menubar): Remove unused local.
d4323972 9249 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9250 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9251 since they might point to immutable storage.
281585b0
PE
9252 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9253 since it's unused otherwise.
032f1620 9254
367c19e5 9255 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9256 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9257 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9258 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9259 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9260 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9261 does not deduce are never used uninitialized.
70739cbe 9262
07b48fa9
PE
9263 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9264
8868a238 9265 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9266 * window.c (window_loop, size_window):
9267 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9268
7e5cf297 9269 * window.c (display_buffer): Now static.
d6550a9f
PE
9270 (size_window): Mark variables that gcc -Wuninitialized
9271 does not deduce are never used uninitialized.
a586633d
PE
9272 * window.h (check_all_windows): New decl, to forestall
9273 gcc -Wmissing-prototypes diagnostic.
5b555da1 9274 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9275
f6095868
PE
9276 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9277 shadowing.
9278 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9279 Include <limits.h>.
9280 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9281 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9282 (load_charset_map): Mark variables that gcc -Wuninitialized
9283 does not deduce are never used uninitialized.
53df7c11 9284 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9285
f38b440c
PE
9286 * coding.c (coding_set_source, coding_set_destination):
9287 Use "else { /* comment */ }" rather than "else /* comment */;"
9288 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9289 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9290 a block, when the outer 'i' will do.
9291 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9292 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9293 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9294 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9295 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9296 Rename locals to avoid shadowing.
9297 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9298 * coding.c (emacs_mule_char, encode_invocation_designation):
9299 Now static, since they're not used elsewhere.
413bb2db 9300 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9301 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9302 (decode_coding_emacs_mule): Mark variables that gcc
9303 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9304 (detect_coding_iso_2022): Initialize a local variable that might
9305 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9306 this initialization is needed. (Bug#8211)
5f58e762
PE
9307 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9308 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9309 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9310 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9311 Remove unused macros.
f38b440c 9312
232b38b9 9313 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9314 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9315 * character.c (string_count_byte8): Likewise.
232b38b9 9316
fb90da1b
PE
9317 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9318 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9319
fb93dbc2
PE
9320 * chartab.c (copy_sub_char_table): Now static, since it's not used
9321 elsewhere.
5c156ace
PE
9322 (sub_char_table_ref_and_range, char_table_ref_and_range):
9323 Rename locals to avoid shadowing.
bbcd0949 9324 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9325
7d3b3862 9326 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9327 (BIDI_BOB): Remove unused macro.
7d3b3862 9328
6be7d3da
PE
9329 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9330 deduce are never used uninitialized.
c2ed9c8b 9331 * term.c (encode_terminal_code): Likewise.
6be7d3da 9332
75f8807f 9333 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9334
50938595
PE
9335 * tparam.h: New file.
9336 * term.c, tparam.h: Include it.
9337 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9338 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9339 Move these decls to tparam.h, and make them agree with what
9340 is actually in tparam.c. The previous trick of using incompatible
9341 decls in different modules does not conform to the C standard.
9342 All callers of tparam changed to use tparam's actual API.
9343 * tparam.c (tparam1, tparam, tgoto):
9344 Use const pointers where appropriate.
9345
fbceeba2
PE
9346 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9347 * cm.h (struct cm): Likewise.
9348 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9349 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9350 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9351 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9352 (turn_on_face, init_tty): Likewise.
9353 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9354
7f3f1250
PE
9355 * term.c (term_mouse_position): Rename local to avoid shadowing.
9356
e6ca6543
PE
9357 * alloc.c (mark_ttys): Move decl from here ...
9358 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9359
c40f8d15
AS
93602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9361
9362 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9363
cfe0661d
JB
93642011-03-09 Juanma Barranquero <lekktu@gmail.com>
9365
9366 * search.c (compile_pattern_1): Remove argument regp, unused since
9367 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9368 (compile_pattern): Don't pass it.
9369
0afb4571
J
93702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9371
9372 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9373 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9374 for ! HAVE_GTK3.
9375 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9376
9377 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9378
9379 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9380 gdk_window_get_screen, gdk_window_get_geometry,
9381 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9382 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9383 (xg_get_pixbuf_from_pixmap): New function.
9384 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9385 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9386 Call xg_get_pixbuf_from_pixmap instead of
9387 gdk_pixbuf_get_from_drawable.
9388 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9389 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9390 (xg_check_special_colors): Use GtkStyleContext and its functions
9391 for HAVE_GTK3.
9392 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9393 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9394 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9395 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9396 Call gtk_widget_get_preferred_size.
0afb4571
J
9397 (xg_frame_resized): gdk_window_get_geometry only takes 5
9398 parameters.
44f230aa
SM
9399 (xg_win_to_widget, xg_event_is_for_menubar):
9400 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9401 (xg_set_widget_bg): New function.
9402 (delete_cb): New function.
895009e1 9403 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9404 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9405 (xg_set_background_color): Call xg_set_widget_bg.
9406 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9407 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9408 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9409 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9410 if ! HAVE_GTK3.
9411 (update_frame_tool_bar): Call gtk_widget_hide.
9412 (xg_initialize): Use GDK_KEY_g.
9413
9414 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9415 if ! HAVE_GTK3
9416 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9417
9418 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9419 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9420 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9421
1c2cc4ef
JB
94222011-03-08 Juanma Barranquero <lekktu@gmail.com>
9423
9424 * w32xfns.c (select_palette): Check success of RealizePalette against
9425 GDI_ERROR, not zero.
9426
33383987 9427See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9428
9429;; Local Variables:
9430;; coding: utf-8
aac0c6e3
MR
9431;; End:
9432
acaf905b 9433 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9434
9435 This file is part of GNU Emacs.
9436
9437 GNU Emacs is free software: you can redistribute it and/or modify
9438 it under the terms of the GNU General Public License as published by
9439 the Free Software Foundation, either version 3 of the License, or
9440 (at your option) any later version.
9441
9442 GNU Emacs is distributed in the hope that it will be useful,
9443 but WITHOUT ANY WARRANTY; without even the implied warranty of
9444 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9445 GNU General Public License for more details.
9446
9447 You should have received a copy of the GNU General Public License
9448 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.