1 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
7 2012-03-03 Glenn Morris <rgm@gnu.org>
9 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
11 2012-03-02 Eli Zaretskii <eliz@gnu.org>
13 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
14 position past the first glyph_row that ends at ZV. (Bug#10902)
15 (redisplay_window, next_element_from_string): Fix typos in
17 (redisplay_window): Pass to move_it_vertically the margin in
18 pixels, not in screen lines.
20 2012-03-02 Glenn Morris <rgm@gnu.org>
22 * buffer.c (buffer-list-update-hook): Doc fix.
24 2012-02-29 Eli Zaretskii <eliz@gnu.org>
26 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
27 push_it before setting up the iterator for the first overlay
28 string, even if we have an empty string loaded.
29 (next_overlay_string): If there's an empty string on the iterator
30 stack, pop the stack. (Bug#10903)
32 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
34 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
35 Suggested by Stefan Monnier in
36 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
37 * alloc.c (widen_to_Lisp_Object): New static function.
38 (mark_memory): Also mark Lisp_Objects by fetching pointer words
39 and widening them to Lisp_Objects. This would work even if
40 USE_LSB_TAG is defined and wide integers are used, which might
41 happen in a future version of Emacs.
43 2012-02-25 Chong Yidong <cyd@gnu.org>
45 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
48 * xselect.c (Fx_selection_exists_p): Doc fix.
49 (x_clipboard_manager_save_all): Print an informative message
50 before saving to clipboard manager.
52 2012-02-24 Chong Yidong <cyd@gnu.org>
54 * keyboard.c (process_special_events): Handle all X selection
55 requests in kbd_buffer, not just the next one (Bug#8869).
57 2012-02-23 Chong Yidong <cyd@gnu.org>
59 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
60 call when setting menu-bar-lines and tool-bar-lines parameters.
61 (unwind_create_frame_1): New helper function.
63 * window.c (inhibit_window_configuration_change_hook): New var.
64 (run_window_configuration_change_hook): Obey it.
65 (syms_of_window): Initialize it.
67 2012-02-22 Chong Yidong <cyd@gnu.org>
69 * xterm.c (x_draw_image_relief): Add missing type check for
70 Vtool_bar_button_margin (Bug#10743).
72 2012-02-21 Chong Yidong <cyd@gnu.org>
74 * fileio.c (Vfile_name_handler_alist): Doc fix.
76 * buffer.c (Fget_file_buffer): Protect against invalid file
79 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
81 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
82 when computing $valmask.
84 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
85 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
86 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
87 It's useless in that case, and it can cause problems on hosts
88 that allocate halves of EMACS_INT values separately.
89 Reported by Dan Horák. Diagnosed by Andreas Schwab in
90 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
91 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
92 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
93 it avoids undefined behavior on hosts where shifting right by more
94 than the word width has undefined behavior.
96 2012-02-19 Chong Yidong <cyd@gnu.org>
98 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
99 (Funhandled_file_name_directory, Ffile_name_as_directory)
100 (Fdirectory_file_name, Fexpand_file_name)
101 (Fsubstitute_in_file_name): Protect against invalid file handler
102 return values (Bug#10845).
104 2012-02-18 Eli Zaretskii <eliz@gnu.org>
106 * .gdbinit (pitx): Fix incorrect references to fields of the
109 2012-02-17 Chong Yidong <cyd@gnu.org>
111 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
113 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
115 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
116 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
118 2012-02-15 Chong Yidong <cyd@gnu.org>
120 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
121 marked as special. Also, starting docstrings with * is obsolete.
123 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
125 * gnutls.c (emacs_gnutls_write): Fix last change.
127 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
129 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
132 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
134 * keymap.c (Fsingle_key_description): Handle char ranges.
136 2012-02-12 Chong Yidong <cyd@gnu.org>
138 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
139 as that creates a dangerous corner case.
141 * window.c (Fdelete_window_internal): Invalidate the mouse
142 highlight (Bug#9904).
144 2012-02-12 Glenn Morris <rgm@gnu.org>
146 * xselect.c (Fx_own_selection_internal)
147 (Fx_get_selection_internal, Fx_disown_selection_internal)
148 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
149 * nsselect.m (Fx_own_selection_internal)
150 (Fx_disown_selection_internal, Fx_selection_exists_p)
151 (Fx_selection_owner_p, Fx_get_selection_internal):
152 Sync docs and argument specs with the xselect.c versions.
154 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
156 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
158 2012-02-11 Eli Zaretskii <eliz@gnu.org>
160 * w32select.c (Fx_selection_exists_p): Sync doc string and
161 argument list with xselect.c. (Bug#10783)
163 * w16select.c (Fx_selection_exists_p): Sync doc string and
164 argument list with xselect.c. (Bug#10783)
166 2012-02-10 Glenn Morris <rgm@gnu.org>
168 * fns.c (Fsecure_hash): Doc fix.
170 2012-02-09 Kenichi Handa <handa@m17n.org>
172 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
174 2012-02-07 Chong Yidong <cyd@gnu.org>
176 * buffer.c (Fbuffer_local_variables)
177 (buffer_lisp_local_variables): Handle unbound vars correctly;
178 don't let Qunbound leak into Lisp.
180 2012-02-07 Glenn Morris <rgm@gnu.org>
182 * image.c (Fimagemagick_types): Doc fix.
184 * image.c (imagemagick-render-type): Change it from a lisp object
185 to an integer. Move the doc here from the lisp manual.
186 Treat all values not equal to 0 the same.
188 2012-02-06 Chong Yidong <cyd@gnu.org>
190 * doc.c (store_function_docstring): Avoid applying docstring of
191 alias to base function (Bug#2603).
193 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
195 * .gdbinit (pp1, pv1): Remove redundant defines.
198 2012-02-04 Chong Yidong <cyd@gnu.org>
200 * nsterm.m: Declare a global (Bug#10694).
202 2012-02-04 Eli Zaretskii <eliz@gnu.org>
204 * w32.c (get_emacs_configuration_options): Include
205 --enable-checking, if specified, in the return value.
207 2012-02-04 Martin Rudalics <rudalics@gmx.at>
209 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
210 after rounding frame sizes. (Bug#9723)
212 2012-02-04 Eli Zaretskii <eliz@gnu.org>
214 * keyboard.c (adjust_point_for_property): Don't position point
215 before BEGV. (Bug#10696)
217 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
219 Handle overflow when computing char display width (Bug#9496).
220 * character.c (char_width): Return EMACS_INT, not int.
221 (char_width, c_string_width): Check for overflow when
222 computing the width; this is possible now that individual
223 characters can have unbounded width. Problem introduced
224 by merge from Emacs 23 on 2012-01-19.
226 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
228 * dbusbind.c (Fdbus_register_method): Mention the return value
229 :ignore in the docstring.
231 2012-02-02 Glenn Morris <rgm@gnu.org>
233 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
235 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
236 Unconditionally set to t. (Bug#10673)
237 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
238 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
239 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
241 2012-02-02 Kenichi Handa <handa@m17n.org>
243 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
244 0, do not call append_composite_glyph.
246 2012-02-02 Kenichi Handa <handa@m17n.org>
248 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
250 (x_produce_glyphs): If the component of a composition is a null
251 string, set it->pixel_width to 1 to avoid zero-width glyph.
253 2012-02-01 Eli Zaretskii <eliz@gnu.org>
255 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
256 first 2 arguments are identical. This makes inserting large
257 output from a subprocess an order of magnitude faster on
258 MS-Windows, where all sbrk'ed memory is always contiguous.
260 2012-01-31 Glenn Morris <rgm@gnu.org>
262 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
263 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
264 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
266 2012-01-29 Glenn Morris <rgm@gnu.org>
268 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
270 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
272 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
274 2012-01-28 Chong Yidong <cyd@gnu.org>
276 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
278 2012-01-26 Chong Yidong <cyd@gnu.org>
280 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
282 * search.c (Fsearch_forward, Fsearch_backward): Document negative
283 repeat counts (Bug#10507).
285 2012-01-26 Glenn Morris <rgm@gnu.org>
287 * lread.c (syms_of_lread): Doc fix.
289 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
291 * coding.c (encode_designation_at_bol): Change return value to
294 2012-01-25 Chong Yidong <cyd@gnu.org>
296 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
298 2012-01-21 Chong Yidong <cyd@gnu.org>
300 * floatfns.c (Fcopysign): Make the second argument non-optional,
301 since nil is not allowed anyway.
303 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
305 * process.c (read_process_output): Use p instead of XPROCESS (proc).
306 (send_process): Likewise.
308 2012-01-19 Martin Rudalics <rudalics@gmx.at>
310 * window.c (save_window_save, Fcurrent_window_configuration)
311 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
314 2012-01-19 Kenichi Handa <handa@m17n.org>
316 * character.c (char_width): New function.
317 (Fchar_width, c_string_width, lisp_string_width):
318 Use char_width (Bug#9496).
320 2012-01-16 Martin Rudalics <rudalics@gmx.at>
322 * window.c (Vwindow_persistent_parameters): New variable.
323 (Fset_window_configuration, save_window_save): Handle persistent
326 2012-01-14 Eli Zaretskii <eliz@gnu.org>
328 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
329 thrashing the stack of the thread. (Bug#9087)
331 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
333 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
335 2012-01-11 Eli Zaretskii <eliz@gnu.org>
337 * xdisp.c (rows_from_pos_range): Handle the case where the
338 highlight ends on a newline. (Bug#10464)
339 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
340 he end column for display of highlight that ends on a newline
343 2012-01-11 Glenn Morris <rgm@gnu.org>
345 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
346 from load-path also when installation-directory is nil. (Bug#10208)
348 2012-01-10 Glenn Morris <rgm@gnu.org>
350 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
352 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
353 Update template values to be closer to their typical values these days.
355 2012-01-09 Eli Zaretskii <eliz@gnu.org>
357 * xdisp.c (rows_from_pos_range): Accept additional argument
358 DISP_STRING, and accept any glyph in a row whose object is that
359 string as eligible for mouse highlight. Fixes mouse highlight of
360 display strings from overlays. (Bug#10464)
362 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
364 emacs: fix an auto-save permissions race condition (Bug#10400)
365 * fileio.c (auto_saving_dir_umask): New static var.
366 (Fmake_directory_internal): Use it.
367 (do_auto_save_make_dir): Set it, instead of invoking chmod after
368 creating the directory. The old code temporarily assigns
369 too-generous permissions to the directory.
370 (do_auto_save_eh): Clear it.
371 (Fdo_auto_save): Catch all errors, not just file errors, so
372 that the var is always cleared.
374 2012-01-07 Eli Zaretskii <eliz@gnu.org>
376 * search.c (scan_buffer): Pass character positions to
377 know_region_cache, not byte positions. (Bug#6540)
379 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
381 * w32.c (sys_rename): Report EXDEV when rename of a directory
382 fails because the target is on another logical disk. (Bug#10284)
384 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
386 * xterm.c (x_embed_request_focus): New function.
388 * xterm.h: Add prototype.
390 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
392 2012-01-05 Glenn Morris <rgm@gnu.org>
394 * emacs.c (emacs_copyright): Update short copyright year to 2012.
396 2012-01-01 Eli Zaretskii <eliz@gnu.org>
398 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
399 Load gnutls_transport_set_lowat only if GnuTLS version is below
401 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
402 GnuTLS versions below 2.11.1.
404 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
406 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
407 to the doc string advising against its use for altering the way
408 windows are scrolled.
410 2011-12-28 Kenichi Handa <handa@m17n.org>
412 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
413 coding-system ASCII compatible only when it does not produce BOM
414 on encoding (Bug#10383).
416 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
418 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
420 (create_and_show_popup_menu): Always use menu_position_func for
423 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
425 * callint.c (Fcall_interactively): Don't truncate prompt string.
427 2011-12-23 Eli Zaretskii <eliz@gnu.org>
429 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
430 property that ends at ZV, so that the bidi iteration could be
431 resumed from there (after widening). (Bug#10360)
433 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
435 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
437 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
439 * nsterm.m (x_free_frame_resources):
440 Release f->output_data.ns->miniimage.
441 (ns_index_color): Fix indentation. Do not retain
442 color_table->colors[i].
444 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
447 * nsfns.m (x_set_background_color): Assign return value from
448 ns_index_color to face-background instead of NSColor*.
449 (ns_implicitly_set_icon_type): Fix indentation.
450 Change assignment in for loop to comparison.
452 * emacs.c (ns_pool): New variable.
453 (main): Assign ns_pool.
454 (Fkill_emacs): Call ns_release_autorelease_pool.
456 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
457 autorelease fdesc, release fdAttrs and tdict.
458 (ns_get_covering_families): Release charset.
459 (ns_findfonts): Release NSFontDescriptor created with new.
460 (ns_uni_to_glyphs): Fix indentation.
461 (setString): Release attrStr before assigning new value.
463 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
465 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
467 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
468 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
470 2011-12-18 David Reitter <reitter@cmu.edu>
472 * nsterm.m (ns_term_init): Subscribe for notifications
473 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
474 to method trackingNotification in EmacsMenu.
476 * nsmenu.m (trackingMenu): New variable.
477 (trackingNotification): New method (from Aquamacs).
478 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
479 from Aquamacs (Bug#7030).
481 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
483 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
484 (symbol_to_nsstring): Fix indentation.
485 (ns_symbol_to_pb): New function.
486 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
487 (Fns_rotate_cut_buffers_internal): Removed.
488 (Fns_store_selection_internal): Renamed from
489 Fns_store_cut_buffer_internal.
490 (ns_get_foreign_selection, Fx_own_selection_internal)
491 (Fx_disown_selection_internal, Fx_selection_exists_p)
492 (Fns_get_selection_internal, Fns_store_selection_internal):
493 Use ns_symbol_to_pb and check if return value is nil.
494 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
495 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
496 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
497 renamed to Sns_store_selection_internal.
498 (ns_handle_selection_request): Move code to Fx_own_selection_internal
499 and remove this function.
500 (ns_handle_selection_clear): Remove, never used.
501 (Fx_own_selection_internal): Move code from ns_handle_selection_request
504 2011-12-17 Ken Brown <kbrown@cornell.edu>
506 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
507 GID is unknown (Bug#10257).
509 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
511 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
512 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
513 which caused a build failure on GNU/Linux IA-64. This problem was
514 introduced by my 2011-10-07 patch.
516 2011-12-15 Juri Linkov <juri@jurta.org>
518 * image.c (imagemagick_error): New function. (Bug#10112)
519 (imagemagick_load_image): Comment out `MagickSetResolution' call.
520 Use `imagemagick_error' where ImageMagick functions return
522 (Fimagemagick_types): Add `Fnreverse' to return the list in the
525 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
527 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
528 fill background (Bug#8992).
530 2011-12-13 Martin Rudalics <rudalics@gmx.at>
532 * window.c (Vwindow_combination_resize)
533 (Vwindow_combination_limit): Use t instead of non-nil in
535 (Vrecenter_redisplay): Add first sentence of doc-string on
537 (Frecenter): Fix doc-string typo.
539 2011-12-11 Kenichi Handa <handa@m17n.org>
541 * coding.c (Funencodable_char_position): Pay attention to the
542 buffer text relocation (Bug#9389).
544 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
546 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
547 gtk_init (Bug#10100).
549 2011-12-10 Eli Zaretskii <eliz@gnu.org>
551 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
552 IT->string is nil. (Bug#10263)
554 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
556 * nsterm.h (x_free_frame_resources): Declare.
558 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
559 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
561 * nsterm.h (ns_get_defaults_value): Declare.
563 * nsterm.m (ns_default): Call ns_get_defaults_value.
565 2011-12-09 Eli Zaretskii <eliz@gnu.org>
567 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
570 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
572 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
573 that where the value of an _OBJC_* symbol points to is in the .bss
576 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
578 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
579 after the loop to call ccl_driver at least once (Bug#8619).
581 2011-12-08 Kenichi Handa <handa@m17n.org>
583 * ftfont.c (get_adstyle_property): Fix previous change
586 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
588 * w32.c (init_environment): If no_site_lisp, remove site-lisp
589 dirs from the default value of EMACSLOADPATH (bug#10208).
591 2011-12-07 Glenn Morris <rgm@gnu.org>
593 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
594 installation and source directories as well. (Bug#10208)
596 2011-12-06 Chong Yidong <cyd@gnu.org>
598 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
600 2011-12-06 Glenn Morris <rgm@gnu.org>
602 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
603 as an error, not just -1. (Bug#10217)
605 2011-12-05 Chong Yidong <cyd@gnu.org>
607 * keyboard.c (process_special_events): New function.
608 (swallow_events, Finput_pending_p): Use it (Bug#10195).
610 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
612 * coding.c (encode_designation_at_bol): Don't use uninitialized
613 local variable (Bug#9318).
615 2011-12-05 Kenichi Handa <handa@m17n.org>
617 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
618 return Qnil (Bug#8046, Bug#10193).
620 2011-12-05 Kenichi Handa <handa@m17n.org>
622 * coding.c (encode_designation_at_bol): New args charbuf_end and
623 dst. Return the number of produced bytes. Callers changed.
624 (coding_set_source): Return how many bytes coding->source was
626 (coding_set_destination): Return how many bytes
627 coding->destination was relocated.
628 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
629 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
631 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
633 * coding.c (CODING_CHAR_CHARSET_P): New macro.
634 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
637 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
639 The following changes are to fix Bug#9318.
641 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
642 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
643 (encode_coding_iso_2022, encode_coding_sjis)
644 (encode_coding_big5, encode_coding_charset): Use the above macros.
646 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
648 * lisp.h (process_quit_flag): Fix external declaration.
650 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
652 Don't macro-inline non-performance-critical code.
653 * eval.c (process_quit_flag): New function.
654 * lisp.h (QUIT): Use it.
656 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
658 * nsfns.m (get_geometry_from_preferences): New function.
659 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
661 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
663 * emacs.c (Qkill_emacs): Define.
664 (syms_of_emacs): Initialize it.
665 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
666 Qquit_flag to `kill-emacs' instead.
667 (quit_throw_to_read_char): Add parameter `from_signal'.
668 All callers changed. Call Fkill_emacs if requested and safe.
669 * lisp.h (QUIT): Call Fkill_emacs if requested.
671 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
673 * widget.c (update_wm_hints): Return if wmshell is null.
674 (widget_update_wm_size_hints): New function.
676 * widget.h (widget_update_wm_size_hints): Declare.
678 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
679 widget_update_wm_size_hints (Bug#10104).
681 2011-12-03 Eli Zaretskii <eliz@gnu.org>
683 * xdisp.c (handle_invisible_prop): If the invisible text ends just
684 before a newline, prepare the bidi iterator for consuming the
685 newline, and keep the current paragraph direction. (Bug#10183)
686 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
688 2011-12-02 Juri Linkov <juri@jurta.org>
690 * search.c (Fword_search_regexp): New Lisp function created from
691 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
692 (Fword_search_backward, Fword_search_forward)
693 (Fword_search_backward_lax, Fword_search_forward_lax):
694 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
695 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
697 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
699 * fileio.c (Finsert_file_contents): Move after-change-function call
700 to before the "handled:" label, since all "goto handled" appear in
701 cases where the *-change-functions have already been properly called
704 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
706 * keyboard.c (interrupt_signal): Don't call kill-emacs when
707 waiting for input. (Bug#10169)
709 2011-11-30 Eli Zaretskii <eliz@gnu.org>
711 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
712 verifies glyph row's hash code--we have just reallocated the
713 glyphs, so their contents can be complete garbage. (Bug#10164)
715 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
717 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
719 2011-11-30 Eli Zaretskii <eliz@gnu.org>
721 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
722 attributes are tested _before_ calling verify_row_hash, to protect
723 against GCC re-ordering of the tests. (Bug#10164)
725 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
727 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
729 * xterm.c (handle_one_xevent): Only set async_visible and friends
730 if net_wm_state_hidden_seen is non-zero (Bug#10002)
731 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
732 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
734 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
736 Remove GCPRO-related macros that exist only to avoid shadowing locals.
737 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
738 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
739 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
740 All uses changed to use GCPRO1 etc.
741 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
742 Revert to old implementation (i.e., before 2011-03-11).
744 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
746 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
747 of scroll runs so as to avoid assigning disabled bogus rows and
748 unnecessary graphics copy operations.
750 2011-11-27 Eli Zaretskii <eliz@gnu.org>
752 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
753 (snprintf) [_MSC_VER]: Redirect to _snprintf.
754 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
755 (malloc, free, realloc, calloc): Redirect to e_* only when
758 * lisp.h (GCTYPEBITS): Move before first use.
759 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
760 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
761 this macro definition.
763 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
766 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
768 * gtkutil.c (xg_create_frame_widgets):
769 Call gtk_window_set_has_resize_grip (FALSE) if that function is
770 present with Gtk+ 2.0.
772 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
774 * fileio.c (Finsert_file_contents): Undo previous change; see
775 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
777 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
779 Rename locals to avoid shadowing.
780 * fileio.c (Finsert_file_contents):
781 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
782 * process.c (wait_reading_process_output):
783 Rename inner 'proc' to 'p' to avoid shadowing.
784 Indent for consistency with usual Emacs style.
786 2011-11-25 Eli Zaretskii <eliz@gnu.org>
788 * xdisp.c (redisplay_window): If cursor row is not fully visible
789 after recentering, and scroll-conservatively is set to a large
790 number, scroll window by a few more lines to make the cursor fully
791 visible and out of scroll-margin. (Bug#10105)
792 (start_display): Don't move to the next line if the display should
793 start at a newline that is part of a display vector or an overlay
796 2011-11-24 Juri Linkov <juri@jurta.org>
798 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
799 after the `MagickPingImage' call. (Bug#10112)
801 2011-11-23 Chong Yidong <cyd@gnu.org>
803 * window.c (Fcoordinates_in_window_p): Accept only live windows.
805 2011-11-23 Martin Rudalics <rudalics@gmx.at>
807 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
808 making another buffer current. (Bug#10114)
810 2011-11-23 Glenn Morris <rgm@gnu.org>
812 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
814 2011-11-23 Chong Yidong <cyd@gnu.org>
816 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
819 2011-11-22 Eli Zaretskii <eliz@gnu.org>
821 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
822 and header-lines, as they don't have one computed for them.
825 * .gdbinit (prow): Make displayed values more self-explaining.
828 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
830 * process.c (wait_reading_process_output): Fix asynchrounous
831 GnuTLS socket handling on some versions of the GnuTLS library.
832 (wait_reading_process_output): Add comment and URL.
834 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
836 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
838 2011-11-21 Chong Yidong <cyd@gnu.org>
840 * window.c (Fnext_window, Fprevious_window): Doc fix.
842 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
844 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
846 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
848 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
850 2011-11-20 Martin Rudalics <rudalics@gmx.at>
852 * window.c (Fset_window_combination_limit): Rename argument
854 (Vwindow_combination_limit): Remove "status" from doc-string.
856 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
858 * m/ibms390.h: Remove.
859 * m/ibms390x.h: Don't include "ibms390.h".
861 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
863 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
864 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
866 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
868 * casetab.c (Fset_case_table):
869 * charset.c (Fcharset_after): Fix typos.
871 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
873 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
874 Otherwise, valgrind does not work on some platforms.
875 Problem reported by Andreas Schwab in
876 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
877 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
878 is set, removing the need for VIRT_ADDRESS_VARIES.
879 (PURE_P): Use a more-efficient implementation that needs just one
880 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
881 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
882 to 4 (xorl, subq, cmpq, setbe).
883 * alloc.c (pure): Always extern now, since that's the
884 VIRT_ADDR_VARIES behavior.
885 (PURE_POINTER_P): Use a single comparison, not two, for
886 consistency with the new puresize.h.
887 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
888 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
889 Remove VIRT_ADDR_VARIES no longer needed.
891 2011-11-19 Eli Zaretskii <eliz@gnu.org>
893 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
894 (erase_phys_cursor, update_window_cursor, show_mouse_face)
895 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
896 behave as if the cursor position were at the window margin.
898 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
899 and the cursor position is out of bounds, behave as if the cursor
900 position were at the window margin. (Bug#10075)
902 2011-11-18 Chong Yidong <cyd@gnu.org>
904 * window.c (Fwindow_combination_limit): Make first argument
905 non-optional, since it is meaningless for live windows like the
908 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
910 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
912 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
914 * intervals.c: Fix grafting over the whole buffer (bug#10071).
915 (graft_intervals_into_buffer): Simplify.
917 2011-11-18 Eli Zaretskii <eliz@gnu.org>
919 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
920 hash values of the two rows.
921 (copy_row_except_pointers): Preserve the used[] arrays and the
922 hash values of the two rows. (Bug#10035)
923 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
925 * xdisp.c (row_hash): New function, body extracted from
926 compute_line_metrics.
927 (compute_line_metrics): Call row_hash, instead of computing the
930 * dispnew.c (verify_row_hash): Call row_hash for computing the
931 hash code of a row, instead of duplicating code from xdisp.c.
933 * dispextern.h (row_hash): Add prototype.
935 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
937 * frame.c (delete_frame): Don't delete the terminal when the last
938 X frame is closed if emacs is built with GTK toolkit.
940 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
942 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
944 2011-11-17 Martin Rudalics <rudalics@gmx.at>
946 * window.c (Vwindow_splits): Rename to
947 Vwindow_combination_resize. Suggested by Juri Linkov.
948 (Fsplit_window_internal): Use Vwindow_combination_resize instead
951 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
953 * nsfns.m (Fns_font_name):
954 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
956 2011-11-16 Martin Rudalics <rudalics@gmx.at>
958 * window.h (window): Rename slot "nest" to "combination_limit".
959 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
960 (Fset_window_nest): Rename to Fset_window_combination_limit.
961 (Vwindow_nest): Rename to Vwindow_combination_limit.
962 (recombine_windows, make_parent_window, make_window)
963 (Fsplit_window_internal, saved_window)
964 (Fset_window_configuration, save_window_save): Rename all
965 occurrences of window_nest to window_combination_limit.
967 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
969 * image.c (imagemagick_load_image): Fix typo.
971 2011-11-14 Eli Zaretskii <eliz@gnu.org>
973 * xdisp.c (display_line): Move the call to
974 highlight_trailing_whitespace before the call to
975 compute_line_metrics, since the latter needs to see the final
976 faces of all the glyphs to compute ROW's hash value.
977 Fixes assertion violations in row_equal_p. (Bug#10035)
979 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
981 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
982 just return (bug#10044).
984 2011-11-12 Eli Zaretskii <eliz@gnu.org>
986 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
987 with user-defined heap size. Bump the default size of the temacs
988 heap to 27MB, to avoid memory warning when running temacs.
989 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
991 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
992 current_matrix and desired_matrix. (Bug#9990)
993 (verify_row_hash) [XASSERTS]: New function.
994 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
995 that the hash value of glyph rows is correct.
997 2011-11-12 Martin Rudalics <rudalics@gmx.at>
999 * window.h (window): Remove splits slot.
1000 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1001 (Fdelete_other_windows_internal, make_parent_window)
1002 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1003 (Fset_window_configuration, save_window_save): Don't deal with
1004 split status of windows.
1005 (saved_window): Remove splits slot.
1006 (Vwindow_splits): Rewrite doc-string.
1008 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1010 * xfns.c (unwind_create_frame):
1011 * nsfns.m (unwind_create_frame):
1012 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1013 Vframe_list (Bug#9999).
1015 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1017 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1019 2011-11-11 Kenichi Handa <handa@m17n.org>
1021 * callproc.c (Fcall_process): Set the member dst_multibyte of
1024 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1026 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1027 avoid a crash (bug#9496).
1029 2011-11-09 Chong Yidong <cyd@gnu.org>
1031 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1032 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1034 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1036 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1038 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1040 Avoid some portability problems by eschewing 'extern inline' functions.
1041 The trivial performance wins aren't worth the portability hassles; see
1042 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1044 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1045 (window_box_width, window_box_left, window_box_left_offset)
1046 (window_box_right, window_box_right_offset): Undo previous change,
1047 by removing the "extern"s.
1048 * intervals.c (adjust_intervals_for_insertion)
1049 (adjust_intervals_for_deletion): Undo previous change,
1050 making these static again.
1051 (offset_intervals, temp_set_point_both, temp_set_point)
1052 (copy_intervals_to_string): No longer inline.
1053 * xdisp.c (window_text_bottom_y, window_box_width)
1054 (window_box_height, window_box_left_offset)
1055 (window_box_right_offset, window_box_left, window_box_right)
1056 (window_box): No longer inline.
1058 2011-11-08 Chong Yidong <cyd@gnu.org>
1060 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1061 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1062 Signal an error if not a live window.
1063 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1064 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1066 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1068 * lisp.h (syms_of_abbrev): Remove declaration.
1069 Reported by CHENG Gao <chenggao@royau.me>.
1071 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1073 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1074 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1075 of temacs in GUI mode.
1077 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1079 * window.h: Declare delete_all_child_windows instead of
1080 delete_all_subwindows.
1081 * window.c (Fwindow_nest, Fset_window_nest)
1082 (Fset_window_new_total, Fset_window_new_normal)
1083 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1084 (delete_all_subwindows): Rename to delete_all_child_windows.
1085 (Fdelete_other_windows_internal, Fset_window_configuration):
1086 Call delete_all_child_windows instead of delete_all_subwindows.
1087 * frame.c (delete_frame): Call delete_all_child_windows instead
1088 of delete_all_subwindows.
1090 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1092 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1093 This is also needed for porting to any host where GC_MARK_STACK is
1094 not GC_MAKE_GCPROS_NOOPS.
1095 (which_symbols): Use it.
1097 2011-11-07 Kenichi Handa <handa@m17n.org>
1099 * coding.c (coding_set_destination): Check coding->src_pos only
1100 when coding->src_object is a buffer (bug#9910).
1102 * process.c (send_process): Set the member src_multibyte of coding
1103 to 0 (bug#9911) when sending a unibyte text.
1105 * callproc.c (Fcall_process): Set the member src_multibyte of
1106 process_coding to 0 (bug#9912).
1108 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1110 * xmenu.c (cleanup_widget_value_tree): New function.
1111 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1112 calling free_menubar_widget_value_tree directly (Bug#9830).
1114 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1116 Fix some portability problems with 'inline'.
1117 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1118 (window_box_width, window_box_left, window_box_left_offset)
1119 (window_box_right, window_box_right_offset): Declare extern.
1120 Otherwise, these inline functions do not conform to C99 and
1121 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1122 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1123 * intervals.c (adjust_intervals_for_insertion)
1124 (adjust_intervals_for_deletion): Now extern, because otherwise the
1125 extern inline functions 'offset_intervals' couldn't refer to it.
1126 (static_offset_intervals): Remove.
1127 (offset_intervals): Rewrite using the old contents of
1128 static_offset_intervals. The old version didn't conform to C99
1129 because an extern inline function contained a reference to an
1130 identifier with static linkage.
1132 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1134 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1137 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1139 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1140 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1141 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1142 return Qleft_to_right.
1144 2011-11-06 Chong Yidong <cyd@gnu.org>
1146 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1147 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1148 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1149 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1150 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1151 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1152 (Fwindow_vscroll): Doc fix.
1153 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1154 argument, since it makes no sense to pass a live window and for
1155 consistency with window-child.
1157 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1159 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1162 2011-11-05 Jason Rumney <jasonr@gnu.org>
1164 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1165 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1167 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1168 bitwise arithmetic preventing use of unicode-sip and non-truetype
1171 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1173 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1176 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1177 initialization code to keep similarity to xfns.c after changes
1180 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1182 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1183 (unwind_create_frame): New function (Bug#9943).
1184 (Fx_create_frame): Restructure code to be more similar to the one in
1185 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1186 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1187 Move terminal->reference_count++ just before making the frame official
1190 * nsterm.m (x_free_frame_resources): New function.
1191 (x_destroy_window): Move code to x_free_frame_resources.
1193 * xfns.c (unwind_create_frame): Fix comment.
1194 (Fx_create_frame, x_create_tip_frame):
1195 Move terminal->reference_count++ just before making the frame
1196 official. Move initialization of image_cache_refcount and
1197 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1199 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1201 Support MSVC build with newer versions of Visual Studio.
1202 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1203 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1206 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1207 which are not supported by MSVC.
1208 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1209 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1211 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1213 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1215 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1217 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1219 Support MSVC build with newer versions of Visual Studio.
1220 * w32.c: Don't include w32api.h for MSVC.
1221 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1223 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1224 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1225 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1226 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1228 (alloca) [_MSC_VER]: Define to _alloca.
1230 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1232 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1234 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1236 * xdisp.c (note_mouse_highlight): If either of
1237 previous/next-single-property-change returns nil, treat that as
1238 the beginning or the end of the buffer. (Bug#9955)
1240 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1242 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1243 label is not null (Bug#9951).
1244 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1247 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1249 * window.c (Fwindow_body_size): Mention in the doc string that the
1250 return value is in frame's canonical units. (Bug#9949)
1252 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1254 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1256 * w32fns.c (unwind_create_frame): If needed, free the glyph
1257 matrices of the partially constructed frame. (Bug#9943)
1258 * xfns.c (unwind_create_frame): Likewise.
1260 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1263 Don't stop backward scan on the continuation glyph, even though
1264 its CHARPOS is positive.
1265 (mouse_face_from_buffer_pos, note_mouse_highlight):
1266 Rename cover_string to disp_string.
1268 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1270 * window.c (temp_output_buffer_show): Don't use
1271 Vtemp_buffer_show_specifiers.
1272 (Vtemp_buffer_show_specifiers): Remove unused variable.
1274 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1276 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1277 past the beginning of the current glyph matrix.
1279 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1281 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1282 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1283 HAVE_GTK3 (Bug#9869).
1285 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1286 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1288 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1290 * xterm.c: Declare x_handle_net_wm_state to return int.
1291 (handle_one_xevent): Check if we are iconified but don't have
1292 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1293 (get_current_wm_state): Return non-zero if not hidden,
1294 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1295 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1296 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1297 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1299 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1301 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1302 so that this new function doesn't get optimized away by a
1303 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1305 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1307 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1309 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1311 Fix the `xbytecode' command.
1312 * .gdbinit (xprintbytestr): New command.
1313 (xwhichsymbols): Rename from `which'; all callers changed.
1314 (xbytecode): Print the byte-code string as well.
1316 2011-10-29 Kim Storm <storm@cua.dk>
1318 * alloc.c (which_symbols): New function.
1320 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1322 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1325 2011-10-29 Glenn Morris <rgm@gnu.org>
1327 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1328 Not clear what it was for, and it causes various bugs. (Bug#9839)
1330 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1332 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1333 possible random value that matches one of those tested as
1334 condition to clear the mouse face.
1336 2011-10-28 Chong Yidong <cyd@gnu.org>
1338 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1340 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1342 * window.c (make_window): Initialize phys_cursor_on_p.
1344 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1346 * lisp.h (struct Lisp_Symbol): Update comments.
1348 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1350 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1352 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1354 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1355 <oslsachem@gmail.com> for helping to debug this.
1357 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1358 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1359 (g_b_init_get_glyph_outline_w): New static variables.
1360 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1361 (GetGlyphOutlineW_Proc): New typedefs.
1362 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1363 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1365 (w32font_open_internal, compute_metrics):
1366 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1367 instead of calling the "wide" APIs directly.
1369 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1371 * w32.h (syms_of_w32font): Add prototype.
1373 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1375 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1376 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1377 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1378 (Fmove_to_window_line): Doc fix.
1380 2011-10-27 Chong Yidong <cyd@gnu.org>
1382 * process.c (make_process): Set gnutls_state to NULL.
1384 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1385 non-NULL, regardless of GNUTLS_INITSTAGE.
1386 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1387 an error. Set process slots as soon as we allocate them.
1389 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1391 2011-10-27 Chong Yidong <cyd@gnu.org>
1393 * gnutls.c (emacs_gnutls_deinit): New function.
1394 Deallocate credentials structures as well as calling gnutls_deinit.
1395 (Fgnutls_deinit, Fgnutls_boot): Use it.
1397 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1398 (deactivate_process): Call emacs_gnutls_deinit.
1400 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1402 * image.c (x_create_x_image_and_pixmap):
1403 * w32.c (sys_rename, w32_delayed_load):
1404 * w32font.c (fill_in_logfont):
1405 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1407 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1409 * w32fns.c (w32_default_color_map): New function,
1410 extracted from Fw32_default_color_map.
1411 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1413 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1415 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1417 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1419 * keyboard.c (test_undefined): New function (bug#9751).
1420 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1422 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1424 * sysdep.c (init_sys_modes): Fix the check for the controlling
1425 terminal (Bug#6649).
1427 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1429 * dispextern.h (struct bidi_it): New member next_en_type.
1431 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1432 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1433 current character, check also for next_en_type being WEAK_EN.
1434 (bidi_resolve_weak): Don't enter the expensive loop if the current
1435 position is before next_en_pos. Record the bidi type of the first
1436 non-ET, non-BN character we find, in addition to its position.
1437 (bidi_level_of_next_char): Invalidate next_en_type when
1438 next_en_pos is over-stepped.
1440 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1442 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1443 * editfns.c: Rewrite current-time-zone so that it invokes
1444 the equivalent of (format-time-string "%Z") to get the time zone name.
1445 This fixes a bug when the time zone name contains characters that
1446 need converting from the system time locale to Emacs internal format.
1447 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1448 that patch fixed format-time-string to do the conversion, but
1449 I forgot to fix current-time-zone.
1450 (format_time_string): New function, containing most of
1451 what Fformat_time_string used to contain.
1452 (Fformat_time_string): Rewrite in terms of format_time_string.
1453 This doesn't change this function's behavior.
1454 (current-time-zone): Rewrite to use format_time_string.
1455 This fixes the bug reported by Michael Schierl in
1456 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1457 Jason Rumney's 2007-06-07 change worked around this bug, but
1459 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1461 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1463 * xdisp.c (start_display): If the character at POS is displayed
1464 via a display vector, reset IT->current.dpvec_index to zero.
1465 (try_window_reusing_current_matrix): If a line ends in a display
1466 vector or the next line starts in a display vector, continue
1467 redrawing the window even though the character position of
1468 start_row was reached.
1471 2011-10-18 Chong Yidong <cyd@gnu.org>
1473 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1474 with nobreak-char-display too.
1476 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1478 Fix part 3 of bug#9771.
1479 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1480 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1481 non-neutral characters if the current character is a paragraph
1482 separator (a.k.a. Newline). This avoids running the same
1483 expensive loop twice, once when we consume the preceding newline
1484 and the other time when the line actually needs to be displayed.
1485 Avoid the loop when we see neutrals on the base embedding level
1486 following a character whose directionality is the same as the
1487 paragraph's. This avoids running the expensive loop when a line
1488 ends in a long sequence of neutrals, like control characters.
1489 Add assertion against STRONG_AL type. Slightly rearrange code
1490 that determines the type of a neutral given the first non-neutral
1492 (bidi_level_of_next_char): Set next_en_pos to zero when
1493 invalidating its info.
1495 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1497 * xdisp.c (push_display_prop): Determine whether to record string
1498 or buffer position by IT->string, not by IT->method. Allow
1499 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1500 (move_it_vertically_backward): Don't look for character position
1501 immediately after the newline when in a continuation line.
1504 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1506 * window.c (coordinates_in_window): Rewrite and delabelize
1507 vertical border check. (Bug#5357) (Bug#9618)
1509 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1511 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1512 errors in XSetWindowBorder (bug#9310).
1514 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1516 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1517 avoid crash when xmalloc overrun checking is enabled.
1519 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1521 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1522 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1523 cursor motion with <left> and <right> arrow keys.
1525 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1526 some callers set that themselves.
1528 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1530 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1531 display string and the previous row comes from the same string and
1532 is empty. (Bug#9739) (Bug#9738)
1534 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1536 * doc.c (get_doc_string): Encode file name (bug#9735).
1538 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1540 * bidi.c (bidi_level_of_next_char):
1541 * xdisp.c (get_visually_first_element): Remove old incorrect
1542 comments regarding the Unicode Line Separator character.
1544 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1546 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1548 * alloc.c (Fgc_status): Do not access beyond zombies array
1549 boundary if nzombies > MAX_ZOMBIES.
1550 * alloc.c (dump_zombies): Add missing format specifier.
1552 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1554 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1555 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1557 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1558 Some packages use them to denote characters with modifiers.
1560 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1562 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1563 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1564 matching a pp-number. Rename parameter var to var1.
1566 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1568 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1570 2011-10-08 Glenn Morris <rgm@gnu.org>
1572 * callint.c (Fcall_interactively): Give a more explicit error for the
1573 'c' case with a non-character input. (Bug#8479)
1575 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1577 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1579 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1580 lines that are hscrolled on the left.
1582 * dispnew.c (buffer_posn_from_coords): Account for a possible
1583 presence of header-line. (Bug#4426)
1585 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1587 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1588 Don't advertise functionality which we discourage or doesn't work.
1590 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1592 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1593 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1594 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1595 this makes Emacs dump core during garbage collection on rare
1596 occasions. sizeof is obviously inferior to offsetof here, so
1597 stick with offsetof.
1598 (GC_POINTER_ALIGNMENT): New macro.
1599 (mark_memory): Omit 3rd (offset) arg; caller changed.
1600 Don't assume EMACS_INT alignment is the same as pointer alignment.
1602 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1604 * keyboard.c (read_key_sequence_remapped): New var.
1605 (read_key_sequence): Compute remapping in the right buffer.
1606 (command_loop_1): Use read_key_sequence's remapping directly.
1608 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1610 * dired.c (file_name_completion): Don't expand file name.
1611 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1612 before checking file name handler.
1614 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1615 they've been requested explicitly (bug#9591).
1617 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1619 * keymap.c (Fsingle_key_description): Use make_specified_string
1620 instead of build_string to build string from push_key_description.
1623 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1625 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1626 This fixes a Y2038 bug on 64-bit hosts.
1627 * buffer.c (reset_buffer):
1628 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1629 (Fclear_buffer_auto_save_failure):
1630 Use 0, not -1, to represent an unset failure time, since time_t
1631 might not be signed.
1633 Remove dependency on glibc malloc internals.
1634 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1635 Move back here from lisp.h, but with their new implementations.
1636 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1637 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1638 * charset.c (charset_table_init): New static var.
1639 (syms_of_charset): Use it instead of xmalloc. This removes a
1640 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1641 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1642 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1643 Move back to alloc.c.
1644 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1645 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1647 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1649 * nsterm.m (windowDidResize): Call x_set_window_size only when
1650 ns_in_resize is true. Otherwise set pixelwidth/height and
1651 call change_frame_size (Bug#9628).
1653 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1655 Port --enable-checking=all to Fedora 14 x86-64.
1656 * charset.c (syms_of_charset): Also account for glibc malloc's
1657 internal overhead when calculating the initial malloc maximum.
1659 Port --enable-checking=all to Fedora 14 x86.
1660 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1662 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1663 (overrun_check_realloc, overrun_check_free):
1664 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1665 That way, xmalloc returns a properly-aligned pointer even if
1666 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1667 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1668 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1669 into account when calculating the initial malloc maximum.
1670 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1671 Move here from alloc.c, so that charset.c can use it too.
1672 Properly align; the old code wasn't right for common 32-bit hosts
1673 when configured with --enable-checking=all.
1674 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1675 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1677 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1679 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1682 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1684 * xdisp.c (compute_display_string_end): If there's no display
1685 string at CHARPOS, return -1.
1687 * bidi.c (bidi_fetch_char): When compute_display_string_end
1688 returns a negative value, treat the character as a normal
1689 character not covered by a display string. (Bug#9624)
1691 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1693 * lread.c (Fread_from_string): Fix typo in docstring.
1695 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1697 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1698 newline, reseat the iterator instead of bidi-iterating there one
1699 character at a time. (Bug#9610)
1700 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1701 TO_CHARPOS if the bidi iterator is at base embedding level.
1703 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1705 * lread.c (readevalloop): Use correct code for NBSP.
1706 (read1): Likewise. (Bug#9608)
1708 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1710 * dbusbind.c (Fdbus_register_signal): When service is not
1711 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1713 2011-09-25 Glenn Morris <rgm@gnu.org>
1715 * buffer.c (truncate-lines): Doc fix.
1717 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1719 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1720 (Fset_window_next_buffers): Doc fix.
1722 2011-09-24 Glenn Morris <rgm@gnu.org>
1724 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1726 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1728 Fix minor problems found by static checking.
1729 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1730 * indent.c (Fvertical_motion): Fix == vs = typo.
1732 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1734 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1735 Default value is now t. Doc fix.
1737 * indent.c (Fvertical_motion): Compute and apply the overshoot
1738 logic when moving up, not only when moving down. Fix the
1739 confusing name and values of the it_overshoot_expected variable;
1740 logic changes accordingly. (Bug#9254) (Bug#9549)
1742 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1743 CHARPOS is covered by a display string which includes newlines.
1744 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1745 is covered by a display string with embedded newlines.
1747 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1749 * dbusbind.c (Fdbus_register_signal): Add match rule to
1750 Vdbus_registered_objects_table. (Bug#9581)
1751 (Fdbus_register_method, Vdbus_registered_objects_table):
1754 2011-09-24 Jim Meyering <meyering@redhat.com>
1756 do not ignore write error for any output size
1757 The previous change was incomplete.
1758 While it makes emacs --batch detect the vast majority of stdout
1759 write failures, errors were still ignored whenever the output size is
1760 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1761 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1762 && echo FAIL: ignored write error
1763 FAIL: ignored write error
1764 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1765 && echo FAIL: ignored write error
1766 FAIL: ignored write error
1767 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1769 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1771 * emacs.c (Fkill_emacs): In noninteractive mode exit
1772 non-successfully if a write error occurred on stdout. (Bug#9574)
1774 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1776 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1779 * dispextern.h (struct it): Update the comment documenting what
1782 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1784 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1785 a display string, extend search for cursor position to end of row.
1786 (find_row_edges): If the row ends in a newline from a display
1787 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1788 Handle the case of a display string with multiple newlines.
1789 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1790 non-empty line. Fixes confusing cursor motion with arrow keys at
1791 the beginning of a line that starts with whitespace.
1793 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1795 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1798 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1800 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1803 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1805 * xdisp.c (display_line): Record maximum and minimum buffer
1806 positions even if no glyphs were produced (e.g., by a zero-width
1807 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1808 buffer positions that will be removed from the glyph row because
1810 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1811 column is beyond frame width: don't subtract 1 "pixel" when
1812 computing width of the stretch.
1813 (reseat_at_next_visible_line_start): Undo the change made on
1814 2011-09-17 that saved paragraph information and restored it after
1815 the call to `reseat'. (Bug#9545)
1817 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1819 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1820 and turn window cursor on if cleared (Bug#9415).
1822 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1824 * search.c (boyer_moore): Take unibyte characters from pattern
1825 literally. (Bug#9458)
1827 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1829 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1831 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1833 Fix minor problem found by static checking.
1834 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1835 initialized, to pacify gcc -Wuninitialized.
1837 * fileio.c: Report proper errno when syscall falls.
1838 (Finsert_file_contents): Save and restore errno,
1839 so that report_file_error outputs the correct diagnostic.
1840 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1842 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1844 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1846 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1848 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1849 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1851 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1853 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1854 about the current paragraph and restore it after the call to reseat.
1856 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1857 (bidi_find_paragraph_start): Search back for paragraph beginning
1858 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1859 (bidi_move_to_visually_next): Only trigger paragraph-related
1860 computations when the last character is a newline or at EOB, not
1861 just any NEUTRAL_B. (Bug#9470)
1863 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1864 truncated lines if point is covered by a display string. (Bug#9524)
1866 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1868 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1869 (cons_to_x_long): New function.
1870 (lisp_data_to_selection_data): Use it. Correct the test for
1871 short-versus-long data; it was negated. Break out of vector
1872 loop, for efficiency, when a long datum is discovered.
1874 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1876 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1878 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1880 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1881 GCC PR/17406) by declaring this function with external scope.
1883 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1885 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1886 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1888 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1890 * editfns.c (Fformat): Correctly handle text properties on "%%".
1892 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1894 * xterm.c (x_draw_composite_glyph_string_foreground):
1895 * w32term.c (x_draw_composite_glyph_string_foreground):
1896 * term.c (encode_terminal_code):
1897 * composite.c (composition_update_it, get_composition_id):
1898 * xdisp.c (get_next_display_element)
1899 (fill_composite_glyph_string): Add comments about special meaning
1900 of TAB characters in a composition.
1902 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1904 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1905 This occurs when processing a multibyte format.
1906 Problem reported by Wolfgang Jenker.
1908 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1910 * xdisp.c (try_cursor_movement): Only check for exact match if
1911 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1913 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1915 Remove unused external symbols.
1916 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1917 * xdisp.c (calc_pixel_width_or_height): Now static.
1918 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1919 * indent.c (check_display_width):
1920 * w32term.c: Fix comment to match code.
1921 * xterm.c, xterm.h (x_catching_errors): Remove.
1923 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1925 * xselect.c: Use signed conversions more consistently (Bug#9498).
1926 (selection_data_to_lisp_data): Assume incoming selection data are
1927 signed integers, not unsigned. This is to be consistent with
1928 outgoing selection data, which was modified to use signed integers
1929 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1930 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1931 expects long, not unsigned long.
1933 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1935 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1936 computation of loop end. Reported by Johan Bockgård
1939 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1941 * frame.c (Fother_visible_frames_p): Function deleted.
1943 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1945 * indent.c (compute_motion): Process display vector front to back
1946 rather than the other way around. (Bug#2496)
1948 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1950 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1952 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1954 * minibuf.c (Fread_from_minibuffer): Doc fix.
1956 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1958 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1959 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1961 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1963 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1964 value for non-existent files.
1966 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1968 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1969 set its "size" to -1. This will set the modtime_size field of
1970 the corresponding buffer to -1, which is what
1971 verify-visited-file-modtime expects for files that do not exist.
1974 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1976 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1978 * lisp.h: ... from here. push_key_description is no longer
1979 defined in keyboard.c, so its declaration should not be in
1980 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1981 logically belongs with push_key_description.
1983 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1985 * buffer.h: Include <sys/types.h> instead of <time.h>.
1986 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1987 Problem reported by Herbert J. Skuhra.
1989 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1991 * xml.c (parse_region): Make the parsing work for
1992 non-comment-starting XML files again (bug#9144).
1994 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1996 * image.c (gif_load): Fix calculation of bottom and right corner.
1999 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2001 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2002 redisplay in small windows.
2004 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2006 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2008 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2010 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2011 Operate on live windows only.
2013 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2015 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2017 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2019 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2020 only under bidi iteration.
2022 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2024 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2026 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2028 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2029 Without this fix, the command to link temacs failed due to an
2030 undefined symbol __builtin_isnan. This is because
2031 /usr/include/iso/math_c99.h #defines isnan(x) to
2032 __builtin_isnan(x), but the bundled gcc, which identifies itself
2033 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2035 * floatfns.c (isnan): #undef, and then #define to a clone of
2037 (Fisnan): Always define, since it's always available now.
2038 (syms_of_floatfns): Always define isnan at the Lisp level.
2040 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2042 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2044 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2046 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2047 The previous code assumed that file offsets (off_t values) fit in
2048 EMACS_INT variables, which is not true on typical 32-bit hosts.
2049 The code messed up by falsely reporting buffer overflow in cases
2050 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2051 when "big" contains more than 2**29 bytes, even though this
2052 inserts just one byte and does not overflow the buffer.
2053 (Finsert_file_contents): Store file offsets as off_t
2054 values, not as EMACS_INT values. Check for overflow when
2055 converting between EMACS_INT and off_t. When checking for
2056 buffer overflow or for overlap, take the offsets into account.
2057 Don't use EMACS_INT for small values where int suffices.
2058 When checking for overlap, fix a typo: ZV was used where
2059 ZV_BYTE was intended.
2060 (Fwrite_region): Don't assume off_t fits into 'long'.
2061 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2063 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2065 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2067 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2069 sprintf-related integer and memory overflow issues (Bug#9412).
2071 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2072 (esprintf, exprintf, evxprintf): New functions.
2073 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2074 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2075 (modify_event_symbol): Do not assume that the length of
2076 name_alist_or_stem is safe to alloca and fits in int.
2077 (Fexecute_extended_command): Likewise for function name and binding.
2078 (Frecursion_depth): Wrap around reliably on integer overflow.
2079 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2080 since some callers pass EMACS_INT values.
2081 (Fsingle_key_description): Don't crash if symbol name contains more
2082 than MAX_ALLOCA bytes.
2083 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2084 (get_minibuffer): Arg is now EMACS_INT, not int.
2085 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2086 (esprintf, exprintf, evxprintf): New decls.
2087 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2089 * dbusbind.c (signature_cat): New function.
2090 (xd_signature, Fdbus_register_signal):
2091 Do not overrun buffer; instead, report string overflow.
2093 * dispnew.c (add_window_display_history): Don't overrun buffer.
2094 Truncate instead; this is OK since it's just a log.
2096 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2097 even if the time zone offset is outlandishly large.
2098 Don't mishandle offset == INT_MIN.
2100 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2101 when creating daemon; the previous buffer-overflow check was incorrect.
2103 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2104 which has the guts of the old verror function.
2106 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2107 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2109 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2110 (font_unparse_xlfd): Don't blindly alloca long strings.
2111 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2112 fits in int, when using sprintf. Use single snprintf to count
2113 length of string rather than counting it via multiple sprintfs;
2114 that's simpler and more reliable.
2115 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2116 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2117 sprintf, in case result does not fit in int.
2119 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2120 (fontset_from_font): Print it.
2122 * frame.c (tty_frame_count): Now printmax_t, not int.
2123 (make_terminal_frame, set_term_frame_name): Print it.
2124 (x_report_frame_params): In X, window IDs are unsigned long,
2125 not signed long, so print them as unsigned.
2126 (validate_x_resource_name): Check for implausibly long names,
2127 and don't assume name length fits in 'int'.
2128 (x_get_resource_string): Don't blindly alloca invocation name;
2129 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2132 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2133 (xg_check_special_colors, xg_set_geometry):
2134 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2136 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2137 Use esprintf, not sprintf, in case result does not fit in int.
2139 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2140 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2141 it as a large positive number.
2142 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2143 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2145 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2146 in case result does not fit in int.
2148 * print.c (float_to_string): Detect width overflow more reliably.
2149 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2150 buffer overrun. Don't assume list length fits in 'int'. Treat
2151 print length of 0 as 0, not as infinity; to be consistent with other
2152 uses of print length in this function. Don't overflow print length
2153 index. Don't assume hash table size fits in 'long', or that
2154 vectorlike size fits in 'unsigned long'.
2156 * process.c (make_process): Use printmax_t, not int, to format
2157 process-name gensyms.
2159 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2161 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2162 to avoid potential buffer overrun.
2164 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2165 if X resource line is longer than 512 bytes.
2167 * xfns.c (x_window): Make sprintf buffer a bit bigger
2168 to avoid potential buffer overrun.
2170 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2172 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2174 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2176 Integer overflow fixes for scrolling, etc.
2177 Without these, Emacs silently mishandles large integers sometimes.
2178 For example, "C-u 4294967297 M-x recenter" was treated as if
2179 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2181 * xdisp.c (try_window_id): Check Emacs fixnum range before
2182 converting to 'int'.
2184 * window.c (window_scroll_line_based, Frecenter):
2185 Check that an Emacs fixnum is in range before assigning it to 'int'.
2186 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2187 values converted from Emacs fixnums.
2188 (Frecenter): Don't wrap around a line count if it is out of 'int'
2189 range; instead, treat it as an extreme value.
2190 (Fset_window_configuration, compare_window_configurations):
2191 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2193 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2194 that can exceed INT_MAX. Check that EMACS_INT value is in range
2195 before assigning it to the (possibly-narrower) index.
2196 (match_limit): Don't assume that a fixnum can fit in 'int'.
2198 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2201 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2202 (Fvertical_motion): Don't wrap around LINES values that don't fit
2203 in 'int'. Instead, treat them as extreme values. This is good
2204 enough for windows, which can't have more than INT_MAX lines anyway.
2206 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2208 * Require libxml/parser.h to avoid compilation warning.
2210 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2212 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2213 since this reportedly can destroy thread storage.
2215 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2217 * syntax.c (find_defun_start): Update all cache variables if
2218 exiting early (Bug#9401).
2220 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2222 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2224 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2225 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2226 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2228 * term.c (tty_append_glyph): New function.
2229 (produce_stretch_glyph): Static function and its prototype deleted.
2231 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2234 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2236 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2237 when checking :margin (Bug#9390).
2238 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2239 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2240 so that the name doesn't mislead. All uses changed.
2242 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2244 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2247 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2249 * xdisp.c (move_it_to): Don't bail out early when reaching
2250 position beyond to_charpos, if we are scanning backwards.
2251 (move_it_vertically_backward): When DY == 0, make sure we get to
2252 the first character in the line after the newline.
2254 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2256 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2257 (ccl_driver): Do not generate an out-of-range pointer.
2258 (Fccl_execute_on_string): Remove unnecessary check for
2259 integer overflow, noted by Stefan Monnier in
2260 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2261 Remove a FIXME that didn't need fixing.
2262 Simplify the newly-introduced buffer reallocation code.
2264 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2266 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2268 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2270 Integer and memory overflow issues (Bug#9196).
2272 * doc.c (get_doc_string): Rework so that
2273 get_doc_string_buffer_size is the actual buffer size, rather than
2274 being 1 less than the actual buffer size; this makes xpalloc more
2277 * image.c (x_allocate_bitmap_record, cache_image):
2278 * xselect.c (Fx_register_dnd_atom):
2279 Simplify previous changes by using xpalloc.
2281 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2282 since either will do and ptrdiff_t is convenient with xpalloc.
2284 * charset.c (charset_table_size)
2285 (struct charset_sort_data.priority): Now ptrdiff_t.
2286 (charset_compare): Don't overflow if priorities differ greatly.
2287 (Fsort_charsets): Don't assume list length fits in int.
2288 Check for size-calculation overflow when allocating sort data.
2289 (syms_of_charset): Allocate an initial charset table that is
2290 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2292 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2294 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2295 The actual value is always <= INT_MAX, and leaving it unsigned made
2296 overflow checking harder.
2298 * dispextern.h (struct glyph_matrix.rows_allocated)
2299 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2300 with xpalloc. The values are still always <= INT_MAX.
2302 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2304 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2305 (SAFE_NALLOCA): New macro.
2307 * region-cache.c (struct boundary.pos, find_cache_boundary)
2308 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2309 (set_cache_region, invalidate_region_cache)
2310 (revalidate_region_cache, know_region_cache, region_cache_forward)
2311 (region_cache_backward, pp_cache):
2312 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2313 so that ptrdiff_t * can be passed to xpalloc.
2314 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2315 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2316 (pp_cache): Don't assume cache_len fits in int.
2317 * region-cache.h: Adjust extern decls to match.
2319 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2320 EMACS_INT, since either will do, for xpalloc.
2322 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2323 (xnmalloc, xnrealloc, xpalloc): New functions.
2325 * bidi.c (bidi_shelve_header_size): New constant.
2326 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2327 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2329 * bidi.c (bidi_cache_shrink):
2330 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2332 Don't update size of array until after memory allocation succeeds,
2333 because xmalloc/xrealloc may not return.
2334 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2335 now that we have proper integer overflow checking.
2336 (record_overlay_string, overlay_strings): Catch overflows when
2337 calculating size of overlay_str_buf.
2339 * callproc.c (Fcall_process): Check for size overflow when
2340 calculating size of args2.
2341 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2342 Normally we prefer signed values, but sticking with ptrdiff_t would
2343 require adding more-complicated checks.
2345 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2346 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2347 Redo buffer-overflow calculations to avoid integer overflow.
2348 Add a FIXME comment where memory seems to be over-allocated.
2350 * character.c (Fstring): Check for size-calculation overflow.
2352 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2353 unnecessary integer overflow. Check for size overflow.
2354 (encode_coding_object): Don't update size until xmalloc succeeds.
2356 * composite.c (get_composition_id): Check for overflow in glyph
2357 length calculations.
2359 Integer and memory overflow fixes for display code.
2360 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2361 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2362 (scrolling_window): Check for overflow in size calculations.
2363 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2364 Don't assume glyph table len fits in int.
2365 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2366 (row_table_size): Now ptrdiff_t, not int.
2367 (scrolling_window): Avoid overflow in size calculations.
2368 Don't update size until allocation succeeds.
2369 * fns.c (concat): Check for overflow in size calculations.
2370 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2371 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2372 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2374 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2375 (get_doc_string): Check for size calculation overflow.
2376 Don't update size until allocation succeeds.
2377 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2378 EMACS_INT, where ptrdiff_t will do.
2379 (Fsubstitute_command_keys): Check for string overflow.
2381 * editfns.c (set_time_zone_rule): Don't assume environment length
2383 (message_length): Now ptrdiff_t, not int.
2384 (Fmessage_box): Don't update size until allocation succeeds.
2385 Don't assume message length fits in int.
2386 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2388 * emacs.c (main): Do not reallocate argv, since there is a null at
2389 the end that can be overwritten, and this way there's no need to
2390 worry about size-calculation overflow.
2391 (sort_args): Check for size-calculation overflow.
2393 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2395 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2397 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2398 (x_set_scroll_bar_width, x_figure_window_size):
2399 Check for integer overflow.
2400 (x_set_alpha): Do not assume XINT fits in int.
2402 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2403 This is for the members text_lines, text_cols, total_lines, total_cols,
2404 where the system imposes an 'int' limit.
2406 * fringe.c (Fdefine_fringe_bitmap):
2407 Don't update size until alloc works.
2409 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2410 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2412 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2413 Check for size-calculation overflow.
2414 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2415 do, as we prefer signed integers.
2416 (id_to_widget.max_size, id_to_widget.used)
2417 (xg_store_widget_in_map, xg_remove_widget_from_map)
2418 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2419 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2420 Use and return ptrdiff_t, not int.
2421 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2422 * gtkutil.h: Change prototypes to match the above.
2424 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2425 are duplicate now that they've been promoted to lisp.h.
2426 (x_allocate_bitmap_record, x_alloc_image_color)
2427 (make_image_cache, cache_image, xpm_load):
2428 Don't update size until alloc is done.
2429 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2431 Check for size calculation overflow.
2432 (ct_colors_allocated_max): New constant.
2433 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2436 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2437 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2438 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2439 Use ptrdiff_t, not int, to count maps.
2440 (read_char_minibuf_menu_prompt): Check for overflow in size
2441 calculations. Don't update size until allocation succeeds.
2442 Redo calculations to avoid overflow.
2443 * keyboard.h: Change prototypes to match the above.
2445 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2447 (current_minor_maps): Check for size calculation overflow.
2448 * keymap.h: Change prototypes to match the above.
2450 * lread.c (read1, init_obarray): Don't update size until alloc done.
2452 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2453 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2455 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2456 Now ptrdiff_t, not int.
2457 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2458 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2460 * process.c (Fnetwork_interface_list): Check for overflow
2461 in size calculation.
2463 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2465 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2466 overflow. Don't bother calling xmalloc when xrealloc will do.
2468 * search.c (Freplace_match): Check for size calculation overflow.
2469 (Fset_match_data): Don't assume list lengths fit in 'int'.
2471 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2472 for command line length. Do not attempt to address one before the
2473 beginning of an array, as that's not portable.
2475 * term.c (max_frame_lines): Remove; unused.
2476 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2478 (encode_terminal_code, calculate_costs): Check for size
2479 calculation overflow.
2480 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2481 table lengths and related sizes. Don't update size until alloc
2482 done. Redo calculations to avoid overflow.
2483 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2485 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2486 subtracting pointers.
2487 (gobble_line): Check for overflow more carefully. Don't update size
2490 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2491 Don't update size until alloc done.
2492 Redo size calculations to avoid overflow.
2493 Check for size calculation overflow.
2494 (main) [DEBUG]: Fix typo in invoking tparam1.
2496 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2497 Use ptrdiff_t, not int, for sizes.
2498 (store_mode_line_noprop_char): Don't update size until alloc done.
2500 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2501 Use ptrdiff_t, not int, for sizes.
2502 (Finternal_make_lisp_face, cache_face):
2503 Check for size calculation overflow.
2504 (cache_face): Treat size calculation overflows as if they were
2505 memory exhaustion (the usual treatment), rather than aborting.
2507 * xfns.c (x_encode_text, x_set_name_internal)
2508 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2509 sizes, since they can exceed INT_MAX in size. Check for size
2510 calculation overflow.
2512 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2513 (xg_select): Check for size calculation overflow.
2514 Don't update size until alloc done.
2516 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2517 as sprintf is limited to int lengths.
2519 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2520 (X_LONG_MIN): New macros.
2521 Use them to make the following changes clearer.
2522 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2523 This change doesn't affect the value now, but it may help remind
2524 future maintainers not to raise the value too much later.
2525 (SELECTION_QUANTUM): Remove, replacing with ...
2526 (selection_quantum): ... new function, which avoids overflow.
2528 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2529 assumption that selection length fits in 'int'.
2530 (x_reply_selection_request, x_handle_selection_request)
2531 (x_get_window_property, receive_incremental_selection)
2532 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2533 (lisp_data_to_selection_data, clean_local_selection_data):
2534 Use ptrdiff_t, not int, to record length of selection.
2535 (x_reply_selection_request, x_get_window_property)
2536 (receive_incremental_selection, x_property_data_to_lisp):
2537 Redo calculations to avoid overflow.
2538 (x_reply_selection_request): When sending hint, ceiling it at
2539 X_LONG_MAX rather than relying on wraparound overflow to send
2541 (x_get_window_property, receive_incremental_selection)
2542 (lisp_data_to_selection_data, x_property_data_to_lisp):
2543 Check for size-calculation overflow.
2544 (x_get_window_property, receive_incremental_selection)
2545 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2546 Don't store size until memory allocation succeeds.
2547 (x_get_window_property): Plug memory leak on memory exhaustion.
2548 Don't double-block input; malloc is safe here. Don't assume 2**34
2549 - 4 fits in unsigned long. Add an xassert to check
2550 XGetWindowProperty overflow. Be more careful about overflow
2551 calculations, and distinguish size from memory overflow better.
2552 (receive_incremental_selection): When tracing, don't assume
2553 unsigned int is less than INT_MAX.
2554 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2555 harmful) conversions of unsigned short to int.
2556 (lisp_data_to_selection_data): Don't assume that integers
2557 in the range -65535 through -1 fit in an X unsigned short.
2558 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2559 result parameters unless successful. Rely on cons_to_unsigned
2560 to report problems with elements; the old code wasn't right anyway.
2561 (x_check_property_data): Check for int overflow; we cannot use
2562 a wider type due to X limits.
2563 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2565 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2567 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2568 (x_term_init): Check for size calculation overflow.
2569 (x_color_cells): Don't store size until memory allocation succeeds.
2570 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2571 Don't assume alloca size is less than MAX_ALLOCA.
2572 (x_term_init): Don't assume length fits in int (sprintf is limited
2575 Use ptrdiff_t for composition IDs.
2576 * character.c (lisp_string_width):
2577 * composite.c (composition_table_size, n_compositions)
2578 (get_composition_id, composition_gstring_from_id):
2579 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2580 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2581 * window.c (Frecenter):
2582 Use ptrdiff_t, not int, for composition IDs.
2583 * composite.c (get_composition_id): Check for integer overflow.
2584 * composite.h: Adjust prototypes to match the above changes.
2586 Use ptrdiff_t for hash table indexes.
2587 * category.c (hash_get_category_set):
2588 * ccl.c (ccl_driver):
2589 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2590 * coding.c (coding_system_charset_list, detect_coding_system):
2591 * coding.h (struct coding_system.id):
2592 * composite.c (get_composition_id, gstring_lookup_cache):
2593 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2594 * image.c (xpm_get_color_table_h):
2595 * lisp.h (hash_lookup, hash_put):
2596 * minibuf.c (Ftest_completion):
2597 Use ptrdiff_t for hash table indexes, not int (which is too
2598 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2599 32-bit --with-wide-int hosts).
2601 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2602 Add a FIXME comment about memory leaks.
2603 (syms_of_charset): Don't assume xmalloc returns.
2605 Don't assume that stated character widths fit in int.
2606 * character.c (Fchar_width, c_string_width, lisp_string_width):
2607 * character.h (CHAR_WIDTH):
2608 * indent.c (MULTIBYTE_BYTES_WIDTH):
2609 Use sanitize_char_width to avoid undefined and/or bad behavior
2610 with outlandish widths.
2611 * character.h (sanitize_tab_width): Rename from sanitize_width,
2612 now that we have two such functions. All uses changed.
2613 (sanitize_char_width): New inline function.
2615 Don't assume that tab-width fits in int.
2616 * character.h (sanitize_width): New inline function.
2617 (SANE_TAB_WIDTH): New macro.
2618 (ASCII_CHAR_WIDTH): Use it.
2619 * indent.c (sane_tab_width): Remove. All uses replaced by
2620 SANE_TAB_WIDTH (current_buffer).
2621 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2623 * fileio.c: Integer overflow issues with file modes.
2624 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2626 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2627 Remove unreachable code.
2628 (read_hex, load_charset_map_from_file): Check for integer overflow.
2630 * xterm.c: Don't go over XClientMessageEvent limit.
2631 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2632 (x_send_scroll_bar_event): Likewise. Check that the size does not
2633 exceed limits imposed by XClientMessageEvent, as well as the usual
2634 ptrdiff_t and size_t limits.
2636 * keyboard.c: Overflow, signedness and related fixes.
2637 (make_lispy_movement): Use same integer type in forward decl
2638 that is used in the definition.
2639 (read_key_sequence, keyremap_step):
2640 Change bufsize argument back to int, undoing my 2011-03-30 change.
2641 We prefer signed types, and int is wide enough here.
2642 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2643 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2644 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2645 length, not size_t. Use ptrdiff_t for index, not int.
2646 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2647 possibility of integer overflow.
2649 Overflow, signedness and related fixes for images.
2651 * dispextern.h (struct it.stack[0].u.image.image_id)
2652 (struct_it.image_id, struct image.id, struct image_cache.size)
2653 (struct image_cache.used, struct image_cache.ref_count):
2654 * gtkutil.c (update_frame_tool_bar):
2655 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2656 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2657 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2658 * nsmenu.m (update_frame_tool_bar):
2659 * xdisp.c (calc_pixel_width_or_height):
2660 * xfns.c (image_cache_refcount):
2661 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2662 on typical 64-bit hosts.
2664 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2665 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2666 Omit unnecessary casts to int.
2667 (parse_image_spec): Check that integers fall into 'int' range
2668 when the callers expect that.
2669 (image_ascent): Redo ascent calculation to avoid int overflow.
2670 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2671 (lookup_image): Remove unnecessary tests.
2672 (xbm_image_p): Locals are now of int, not EMACS_INT,
2673 since parse_image_check makes sure they fit into int.
2674 (png_load, gif_load, svg_load_image):
2675 Prefer int to unsigned where either will do.
2676 (tiff_handler): New function, combining the cores of the
2677 old tiff_error_handler and tiff_warning_handler.
2678 This function is rewritten to use vsnprintf and thereby avoid
2679 stack buffer overflows. It uses only the features of vsnprintf
2680 that are common to both POSIX and native Microsoft.
2681 (tiff_error_handler, tiff_warning_handler): Use it.
2682 (tiff_load, gif_load, imagemagick_load_image):
2683 Don't assume :index value fits in 'int'.
2684 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2685 (imagemagick_load_image): Check that crop parameters fit into
2686 the integer types that MagickCropImage accepts. Don't assume
2687 Vimagemagick_render_type has a nonnegative value. Don't assume
2688 size_t fits in 'long'.
2689 (gs_load): Use printmax_t to print the widest integers possible.
2690 Check for integer overflow when computing image height and width.
2692 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2694 * xdisp.c (redisplay_window): Don't force window start if point
2695 will be invisible in the resulting window. (Bug#9324)
2697 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2699 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2700 the display spec is of the form `(space ...)'.
2701 (handle_display_spec): Return the value returned by
2702 handle_single_display_spec, not just 1 or zero.
2703 (handle_single_display_spec): If the display spec is of the form
2704 `(space ...)', and specifies display in the text area, return 2
2706 (try_cursor_movement): Check for the need to scroll more
2707 accurately, and prefer exact match for point under bidi.
2708 Don't advance `row' beyond the last row of the window.
2710 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2711 into disp_prop; all users changed.
2713 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2714 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2715 for the text covered by the display property.
2717 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2719 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2720 Change return value to nil.
2721 (Frecord_buffer): Delete unused function.
2723 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2725 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2726 buffers, return left-to-right.
2727 (set_cursor_from_row): Consider candidate row a win if its glyph
2728 represents a newline and point is on that newline. Fixes cursor
2729 positioning on the newline at EOL of R2L text within L2R
2730 paragraph, and vice versa.
2731 (try_cursor_movement): Check continued rows, in addition to
2732 continuation rows. Fixes unwarranted scroll when point enters a
2733 continued line of R2L text within an L2R paragraph, or vice versa.
2734 (cursor_row_p): Consider the case of point being equal to
2735 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2736 from the end of a short line to the beginning of a continued line
2737 of R2L text within L2R paragraph.
2738 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2739 composed characters.
2741 * bidi.c (bidi_check_type): Use xassert.
2742 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2745 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2747 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2750 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2752 * nsfont.m (ns_otf_to_script): Fix typo.
2754 2011-08-22 Kenichi Handa <handa@m17n.org>
2756 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2757 extra slot even if the purpose is char-code-property-table.
2759 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2761 * xdisp.c (redisplay_window): When computing centering_position,
2762 account for the height of the header line. (Bug#8874)
2764 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2765 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2766 candidate is selected by the mouse, and that candidate has a
2767 composed character under the mouse.
2769 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2770 coordinates reported by pos-visible-in-window-p for a composed
2771 character in column zero.
2773 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2775 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2777 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2779 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2780 consider it a hit if to_charpos is anywhere in the range of the
2781 composed buffer positions.
2783 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2785 * image.c (gif_load): Don't assume that each subimage has the same
2786 dimensions as the base image. Handle disposal method that is
2787 "undefined" by the gif spec (Bug#9335).
2789 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2791 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2792 (Fcondition_case): Document `debug' symbol in error handler.
2794 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2796 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2797 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2798 from an Org mode buffer to a Speedbar frame.
2800 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2801 a composition, take its buffer position from IT->cmp_it.charpos.
2802 Fixes cursor positioning at the beginning of a line that begins
2803 with a composed character.
2805 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2807 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2808 character bidirectional type, use STRONG_L instead. Fixes crashes
2809 in a buffer produced by `describe-categories'.
2811 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2812 members before the level stack, so they would be saved and
2813 restored when copying iterator state. Fixes incorrect reordering
2814 around TABs covered by display properties.
2816 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2818 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2820 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2822 * eval.c (internal_condition_case, internal_condition_case_1)
2823 (internal_condition_case_2, internal_condition_case_n):
2824 Remove unnecessary aborts (Bug#9081).
2826 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2828 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2829 has no `load' handler, try opening the file locally. (Bug#9311)
2831 2011-08-16 Ken Brown <kbrown@cornell.edu>
2833 * gmalloc.c: Expand comment.
2835 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2837 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2838 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2840 2011-08-16 Ken Brown <kbrown@cornell.edu>
2842 Fix memory allocation problems in Cygwin build (Bug#9273).
2844 * unexcw.c ( __malloc_initialized): Declare external variable.
2845 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2847 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2849 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2851 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2853 [CYGWIN] (special_realloc): New function.
2854 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2855 requests to realloc storage in the static heap.
2857 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2859 * bidi.c (bidi_initialize): Remove unused local.
2861 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2864 * biditype.h: Remove file.
2865 * makefile.w32-in ($(BLD)/bidi.$(O)):
2866 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2868 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2870 * chartab.c: Improve commentary for the uniprop_table API.
2872 * bidi.c (bidi_paragraph_init): Support zero value of
2873 bidi_ignore_explicit_marks_for_paragraph_level.
2874 (bidi_initialize): Use uniprop_table instead of including
2875 biditype.h and bidimirror.h.
2877 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2878 coordinates of the iterator when restoring from ppos_it.
2881 2011-08-14 Kenichi Handa <handa@m17n.org>
2883 * process.c (create_process): Call setup_process_coding_systems
2884 after the pid of the process is set to -1 (Bug#8162).
2886 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2888 * xdisp.c (move_it_in_display_line_to): Don't invoke
2889 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2890 ppos_it. Fixes vertical cursor motion when line beginning is
2891 covered by an image. (Bug#9296)
2893 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2895 * nsterm.h (ns_run_ascript): Declare.
2896 (NSAPP_DATA2_RUNASSCRIPT): Define.
2898 * nsfns.m (as_script, as_result, as_status): New static variables.
2899 (ns_run_ascript): New function.
2900 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2901 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2902 the event loop. Get status from as_status (Bug#7276).
2904 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2905 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2906 the event loop (Bug#7276).
2908 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2910 * gnutls.c (QCgnutls_bootprop_priority)
2911 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2912 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2913 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2914 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2915 (QCgnutls_bootprop_verify_hostname_error)
2916 (QCgnutls_bootprop_callbacks_verify): Rename from
2917 Qgnutls_bootprop_..., all uses changed.
2919 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2922 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2924 * xfaces.c (Qframe_set_background_mode): Now static.
2925 * dispextern.h (Qframe_set_background_mode): Remove decl.
2927 * process.c (Fnetwork_interface_info): Declare local only if needed.
2929 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2931 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2932 (Fnetwork_interface_list): Allocate in increments of bytes instead
2933 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2934 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2936 (struct ifflag_def): notrailers is smart on OSX.
2937 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2938 Get hardware address with getifaddrs if available.
2940 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2942 * xdisp.c (iterate_out_of_display_property): xassert that
2943 IT->position is set to within IT->object's boundaries. Break from
2944 the loop as soon as EOB is reached; avoids infloops in redisplay
2945 when IT->position is set up wrongly due to some bug.
2946 Set IT->current to match the bidi iterator unconditionally.
2947 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2948 entry. Force push_it to save on the stack the current
2949 buffer/string position, to be restored by pop_it. Fix flags in
2950 the iterator structure wrt the object coming from a display
2951 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2952 properties. (Bug#9284)
2954 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2956 * fontset.c (fontset_get_font_group): Add proper type checks.
2959 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2961 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2962 and LC_VERSION_MIN_MACOSX.
2963 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2964 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2966 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2968 * xdisp.c (forward_to_next_line_start): Allow to use the
2969 no-display-properties-and-no-overlays under bidi display.
2970 Set disp_pos in the bidi iterator to avoid searches for display
2971 properties and overlays.
2973 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2975 * editfns.c (Fset_time_zone_rule): Document relationship with the
2978 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2979 the font entity extracted from the cache (Bug#8109).
2981 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2983 * composite.c (autocmp_chars): Don't reset point. That is done by
2984 restore_point_unwind (Bug#5984).
2986 2011-08-07 Juri Linkov <juri@jurta.org>
2988 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2989 to show the arg `TIME' instead of `TIMEVAL'.
2991 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2993 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2994 display property strides EOL and includes a newline, as in
2995 longlines-mode. (Bug#9254)
2996 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2997 word-wrap under bidirectional display. (Bug#9224)
2999 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3000 is non-zero, even if the data buffer is NULL. Fixes a crash in
3001 vertical-motion with longlines-mode. (Bug#9254)
3003 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3005 * bidi.c <bidi_cache_total_alloc>: Now static.
3006 (bidi_initialize): Initialize bidi_cache_total_alloc.
3008 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3011 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3012 amount allocated this far in `bidi_cache_total_alloc'.
3013 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3014 non-zero, only free the data buffer without restoring the cache
3015 contents. All callers changed.
3017 * dispextern.h (bidi_unshelve_cache): Update prototype.
3019 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3020 (move_it_in_display_line, move_it_to)
3021 (move_it_vertically_backward, move_it_by_lines): Replace the call
3022 to xfree to an equivalent call to bidi_unshelve_cache.
3023 (move_it_in_display_line_to): Fix logic of returning
3024 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3026 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3028 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3029 came from a string character with a `cursor' property. (Bug#9229)
3031 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3033 * Makefile.in (LIB_PTHREAD): New variable.
3034 (LIBES): Add LIB_PTHREAD (Bug#9216).
3036 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3037 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3039 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3041 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3043 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3045 * xterm.c (x_find_topmost_parent): New function.
3046 (x_set_frame_alpha): Find topmost parent window with
3047 x_find_topmost_parent and set the property there also (bug#9181).
3048 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3050 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3052 * callproc.c (Fcall_process): Avoid vfork clobbering
3053 the local vars buffer, coding_systems, current_dir.
3055 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3057 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3059 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3061 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3062 so that it is not optimized away.
3064 * xdisp.c (compute_display_string_pos): Remove unused local.
3066 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3068 Fix slow cursor motion and scrolling in large buffers with
3069 selective display, like Org Mode buffers. (Bug#9218)
3071 * dispextern.h (struct bidi_it): New member disp_prop_p.
3073 * xdisp.c: Remove one-slot cache of display string positions.
3074 (compute_display_string_pos): Accept an additional argument
3075 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3076 for a display string or property. If found, set DISP_PROP_P
3079 * bidi.c (bidi_fetch_char): Accept an additional argument
3080 DISP_PROP_P, and pass it to compute_display_string_pos.
3081 Only handle text covered by a display string if DISP_PROP_P is returned
3082 non-zero. All callers of bidi_fetch_char changed.
3084 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3086 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3088 2010-12-03 Don March <don@ohspite.net>
3090 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3091 last character M-[char] is translated to ESC [char] (bug#7541).
3093 2011-08-02 Kenichi Handa <handa@m17n.org>
3095 * lisp.h (uniprop_table): Extern it.
3097 * chartab.c (uniprop_table): Make it non-static.
3099 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3101 * xdisp.c (forward_to_next_line_start): Accept additional argument
3102 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3104 (reseat_at_next_visible_line_start): Use the bidi iterator state
3105 returned by forward_to_next_line_start to restore the state of
3106 it->bidi_it after backing up to previous newline. (Bug#9212)
3108 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3110 * regex.c (re_comp): Protoize.
3111 (re_exec): Fix return type.
3112 (regexec): Fix type of `ret'. (Bug#9203)
3114 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3116 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3117 This is needed if max-image-size is a floating-point number.
3119 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3121 * print.c (print_object): Print empty symbol as ##.
3123 * lread.c (read1): Read ## as empty symbol.
3125 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3127 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3128 setting frame foreground color (Bug#9175).
3129 (x_set_background_color): Likewise.
3131 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3132 contents (Bug#9176).
3133 (EmacsTooltip -init): Remove bezels and add shadows to
3136 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3137 or scroll bar (Bug#8470).
3139 * nsfont.m (nsfont_open): Remove assignment to voffset and
3140 unnecessary vars hshink, expand, hd, full_height, min_height.
3141 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3143 * nsterm.h (nsfont_info): Remove voffset field.
3145 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3147 Implement strike-through and overline on NextStep (Bug#8863).
3149 * nsfont.m (nsfont_open): Use underline position provided by font,
3150 instead of hard-coded value of 2.
3151 (nsfont_draw): Call ns_draw_text_decoration instead.
3153 * nsterm.h: Add declaration for ns_draw_text_decoration.
3155 * nsterm.m (ns_draw_text_decoration): New function for drawing
3156 underline, overline, and strike-through.
3157 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3158 ns_draw_text_decoration. Change treatment of cursor drawing to
3159 accommodate underlining, etc.
3161 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3163 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3166 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3168 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3169 Without this fix, if a signal arrives just after memory fills up,
3170 'malloc' might be invoked reentrantly.
3172 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3173 In other words, assume that every image size is allowed, on non-X
3174 hosts. This assumption is probably wrong, but it lets Emacs compile.
3176 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3178 * regex.c (re_iswctype): Convert return values to boolean.
3180 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3182 * xdisp.c (compute_display_string_pos): Don't use cached display
3183 string position if the buffer had its restriction changed.
3186 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3188 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3190 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3192 Integer signedness and overflow and related fixes. (Bug#9079)
3194 * bidi.c: Integer size and overflow fixes.
3195 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3196 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3197 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3198 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3199 (bidi_find_other_level_edge):
3200 Use ptrdiff_t instead of EMACS_INT where either will do.
3201 This works better on 32-bit hosts configured --with-wide-int.
3202 (bidi_cache_ensure_space): Check for size-calculation overflow.
3203 Use % rather than repeated addition, for better worst-case speed.
3204 Don't set bidi_cache_size until after xrealloc returns, because it
3206 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3207 (bidi_cache_ensure_space): Also check that the bidi cache size
3208 does not exceed that of the largest Lisp string or buffer. See Eli
3209 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3211 * alloc.c (__malloc_size_t): Remove.
3212 All uses replaced by size_t. See Andreas Schwab's note
3213 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3215 * image.c: Improve checking for integer overflow.
3216 (check_image_size): Assume that f is nonnull, since
3217 it is always nonnull in practice. This is one less thing to
3218 worry about when checking for integer overflow later.
3219 (x_check_image_size): New function, which checks for integer
3220 overflow issues inside X.
3221 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3222 This removes the need for a memory_full check.
3223 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3224 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3225 (xbm_read_bitmap_data): Change locals back to 'int', since
3226 their values must fit in 'int'.
3227 (xpm_load_image, png_load, tiff_load):
3228 Invoke x_create_x_image_and_pixmap earlier,
3229 to avoid much needless work if the image is too large.
3230 (tiff_load): Treat overly large images as if
3231 x_create_x_image_and_pixmap failed, not as malloc failures.
3232 (gs_load): Use x_check_image_size.
3234 * gtkutil.c: Omit integer casts.
3235 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3236 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3238 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3240 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3241 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3242 would wrongly return t on a 64-bit host.
3244 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3245 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3246 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3247 and therefore cause GCC to emit a bogus diagnostic in some cases.
3249 * image.c: Integer signedness and overflow and related fixes.
3250 This is not an exhaustive set of fixes, but it's time to
3251 record what I've got.
3252 (lookup_pixel_color, check_image_size): Remove redundant decls.
3253 (check_image_size): Don't assume that arbitrary EMACS_INT values
3254 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3255 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3256 (tiff_load, imagemagick_load_image):
3257 Check for overflow in size calculations.
3258 (x_create_x_image_and_pixmap): Remove unnecessary test for
3259 xmalloc returning NULL; that can't happen.
3260 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3261 (xpm_color_bucket): Use better integer hashing function.
3262 (xpm_cache_color): Don't possibly over-allocate memory.
3263 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3264 (gif_memory_source):
3265 Use ptrdiff_t, not int or size_t, to record sizes.
3266 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3267 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3268 either works, as we prefer signed integers.
3269 (tiff_read_from_memory, tiff_write_from_memory):
3270 Return tsize_t, not size_t, since that's what the TIFF API wants.
3271 (tiff_read_from_memory): Don't fail simply because the read would
3272 go past EOF; instead, return a short read.
3273 (tiff_load): Omit no-longer-needed casts.
3274 (Fimagemagick_types): Don't assume size fits into 'int'.
3276 Improve hashing quality when configured --with-wide-int.
3277 * fns.c (hash_string): New function, taken from sxhash_string.
3278 Do not discard information about ASCII character case; this
3279 discarding is no longer needed.
3280 (sxhash-string): Use it. Change sig to match it. Caller changed.
3281 * lisp.h: Declare it.
3282 * lread.c (hash_string): Remove, since we now use fns.c's version.
3283 The fns.c version returns a wider integer if --with-wide-int is
3284 specified, so this should help the quality of the hashing a bit.
3286 * emacs.c: Integer overflow minor fix.
3287 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3288 Define only if GNU_LINUX.
3289 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3291 * dispnew.c: Integer signedness and overflow fixes.
3292 Remove unnecessary forward decls, that were a maintenance hassle.
3293 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3295 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3296 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3297 (prepare_desired_row, line_draw_cost):
3298 Use int, not unsigned, where either works.
3299 (save_current_matrix, restore_current_matrix):
3300 Use ptrdiff_t, not size_t, where either works.
3301 (init_display): Check for overflow more accurately, and without
3302 relying on undefined behavior.
3304 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3305 Remove, replacing with the new symbols in lisp.h. All uses changed.
3306 * fileio.c (make_temp_name):
3307 * filelock.c (lock_file_1, lock_file):
3308 * xdisp.c (message_dolog):
3309 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3310 Use pMd etc. instead.
3311 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3312 replacing the pWIDE etc. symbols removed from editfns.c.
3314 * keyboard.h (num_input_events): Now uintmax_t.
3315 This is (very slightly) less likely to mess up due to wraparound.
3318 * buffer.c: Integer signedness fixes.
3319 (alloc_buffer_text, enlarge_buffer_text):
3320 Use ptrdiff_t rather than size_t when either will do, as we prefer
3323 * alloc.c: Integer signedness and overflow fixes.
3324 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3325 (__malloc_size_t): Default to size_t, not to int.
3326 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3327 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3328 Prefer ptrdiff_t to size_t when either would do, as we prefer
3330 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3331 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3332 Now const. Initialize with values that are in range even if char
3334 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3335 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3336 These functions do the right thing with sizes > 2**32.
3337 (check_depth): Now ptrdiff_t, not int.
3338 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3339 Adjust to new way of storing sizes. Check for size overflow bugs
3341 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3342 slightly wrong anyway, as it missed one instance of
3343 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3344 (refill_memory_reserve): Omit needless cast to size_t.
3345 (mark_object_loop_halt): Mark as externally visible.
3347 * xselect.c: Integer signedness and overflow fixes.
3348 (Fx_register_dnd_atom, x_handle_dnd_message):
3349 Use ptrdiff_t, not size_t, since we prefer signed.
3350 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3351 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3352 x_dnd_atoms_size and x_dnd_atoms_length.
3354 * doprnt.c: Prefer signed to unsigned when either works.
3356 * doprnt.c (doprnt):
3358 * xdisp.c (vmessage):
3359 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3360 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3361 prefer signed arithmetic to avoid comparison confusion.
3362 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3363 but is a bit tricky.
3365 Assume freestanding C89 headers, string.h, stdlib.h.
3366 * data.c, doprnt.c, floatfns.c, print.c:
3367 Include float.h unconditionally.
3368 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3369 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3370 * regex.c: Likewise for stddef.h, string.h.
3371 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3372 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3373 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3374 (STDC_HEADERS): Remove obsolete defines.
3375 * sysdep.c: Include limits.h unconditionally.
3377 Assume support for memcmp, memcpy, memmove, memset.
3378 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3379 * regex.c (memcmp, memcpy):
3380 Remove; we assume C89 now.
3382 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3383 (__malloc_safe_bcopy): Remove; no longer needed.
3385 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3386 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3387 well either way, and we prefer signed to unsigned.
3389 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3391 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3392 closes the connection while we're reading (bug#9182).
3394 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3396 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3397 are specified (Bug#9168).
3399 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3401 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3402 Found by GCC static checking and --with-wide-int on a 32-bit host.
3404 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3406 * xdisp.c (compute_display_string_pos): Fix logic of caching
3407 previous display string position. Initialize cached_prev_pos to
3408 -1. Fixes slow-down at the beginning of a buffer.
3410 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3412 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3413 for attrs[LFACE_FONTSET_INDEX].
3415 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3417 * xml.c (parse_region): Remove unused local
3418 that was recently introduced.
3420 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3422 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3423 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3425 * xdisp.c (move_it_in_display_line_to): Record the best matching
3426 position for TO_CHARPOS while scanning the line, and restore it on
3427 exit if none of the characters scanned was an exact match.
3428 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3429 when exact match is impossible due to invisible text, and the
3430 lines are truncated.
3432 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3434 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3437 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3439 Fix a significant slow-down of cursor motion with C-n, C-p,
3440 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3441 auto-repeat under bidi redisplay in fontified buffers.
3442 * xdisp.c (compute_stop_pos_backwards): New function.
3443 (next_element_from_buffer): Call compute_stop_pos_backwards to
3444 find a suitable prev_stop when we find ourselves before
3446 (reseat): Don't look for prev_stop, as that could mean a very long
3448 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3449 <cached_disp_overlay_modiff>: Cache for last found display string
3451 (compute_display_string_pos): Return the cached position if asked
3452 about the same buffer in the same area of character positions, and
3453 the buffer wasn't changed since the time the display string
3454 position was cached.
3456 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3458 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3459 is an integer, which is important for empty lines. (Bug#9149)
3461 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3463 * frame.c (Fmodify_frame_parameters): In tty case, update the
3464 default face if necessary (Bug#4238).
3466 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3468 * editfns.c (Fstring_to_char): No need to explain what a character
3469 is in the docstring (Bug#6576).
3471 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3473 * xml.c (parse_region): Make sure we always return a tree.
3475 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3477 * xml.c (parse_region): If a document contains only comments,
3480 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3482 * xml.c (make_dom): Return comments, too.
3484 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3487 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3488 and the surrounding thread.
3489 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3490 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3491 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3493 * s/openbsd.h (BROKEN_SIGIO): Define.
3494 * unexelf.c (unexec) [__OpenBSD__]:
3495 Don't update the .mdebug section of the Alpha COFF symbol table.
3497 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3499 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3502 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3504 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3505 This fixes some race conditions on the permissions of any newly
3508 * alloc.c (valid_pointer_p): Use pipe, not open.
3509 This fixes some permissions issues when debugging.
3511 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3512 If fchown fails to set both uid and gid, try to set just gid,
3513 as that is sometimes allowed. Adjust the file's mode to eliminate
3514 setuid or setgid bits that are inappropriate if fchown fails.
3516 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3518 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3519 to compare Lisp_Objects.
3520 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3521 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3522 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3524 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3526 * lread.c (read_integer): Unread even EOF character.
3527 (read1): Likewise. Properly record start position of symbol.
3529 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3530 symbol character follows.
3532 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3534 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3535 This works around a problem with the previous change to Fcopy_file.
3536 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3537 and without this change, GCC might complain about discarding
3538 fchown's return value.
3540 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3542 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3544 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3546 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3548 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3550 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3551 it's used from the C level.
3553 * process.c: Use the same condition for POLL_FOR_INPUT in both
3554 keyboard.c and process.c (bug#1858).
3556 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3558 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3559 (Fgnutls_boot): Use it.
3561 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3563 * doc.c (Fsubstitute_command_keys): Revert last change.
3565 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3567 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3568 quotes the next character, and doesn't affect other longer
3569 sequences (bug#8935).
3571 * lread.c (syms_of_lread): Clarify that is isn't only
3572 `eval-buffer' and `eval-defun' that's affected by
3573 `lexical-binding' (bug#8460).
3575 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3577 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3578 bidi redisplay when a line includes both an image and is truncated.
3580 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3582 Fix minor problems found by static checking.
3583 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3584 (elsz): Now a signed constant, not a size_t var. We prefer signed
3585 types to unsigned, to avoid integer comparison confusion. Without
3586 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3587 "cannot optimize loop, the loop counter may overflow", a symptom
3589 * indent.c (Fvertical_motion): Mark locals as initialized.
3590 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3592 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3594 * search.c (Fre_search_backward): Mention `case-fold-search' in
3595 all the re_search_* functions (bug#8138).
3597 * keyboard.c (Fopen_dribble_file): Document when the file is
3600 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3602 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3605 Support bidi reordering of display and overlay strings.
3606 * xdisp.c (compute_display_string_pos)
3607 (compute_display_string_end): Accept additional argument STRING.
3608 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3609 (reseat_to_string): Initialize bidi_it->string.s and
3610 bidi_it->string.schars.
3611 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3612 NULL (avoids a crash in bidi_paragraph_init).
3613 Initialize itb.string.lstring.
3614 (init_iterator): Call bidi_init_it only of a valid
3615 buffer position was specified. Initialize paragraph_embedding to
3617 (reseat_to_string): Initialize the bidi iterator.
3618 (display_string): If we need to ignore text properties of
3619 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3620 original value of -1 will not work with bidi.)
3621 (compute_display_string_pos): First arg is now struct
3622 `text_pos *'; all callers changed. Support display properties on
3624 (compute_display_string_end): Support display properties on Lisp
3626 (init_iterator, reseat_1, reseat_to_string): Initialize the
3627 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3628 when iterating on a string not from display properties).
3629 (compute_display_string_pos, compute_display_string_end):
3630 Fix calculation of the object to scan. Fixes an error when using
3632 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3633 base_level_stop; instead, set base_level_stop to BEGV.
3634 Fixes crashes in vertical-motion.
3635 (next_element_from_buffer): Improve commentary for when
3636 the iterator is before prev_stop.
3637 (init_iterator): Initialize bidi_p from the default value of
3638 bidi-display-reordering, not from buffer-local value. Use the
3639 buffer-local value only if initializing for buffer iteration.
3640 (handle_invisible_prop): Support invisible properties on strings
3641 that are being bidi-reordered.
3642 (set_iterator_to_next): Support bidi reordering of C strings and
3644 (next_element_from_string): Support bidi reordering of Lisp
3646 (handle_stop_backwards): Support Lisp strings as well.
3647 (display_string): Support display of R2L glyph rows.
3648 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3649 (init_iterator): Don't initialize it->bidi_p for strings
3651 (reseat_to_string): Initialize it->bidi_p for strings here.
3652 (next_element_from_string, next_element_from_c_string)
3653 (next_element_from_buffer): Add xassert's for correspondence
3654 between IT's object being iterated and it->bidi_it.string
3656 (face_before_or_after_it_pos): Support bidi iteration.
3657 (next_element_from_c_string): Handle the case of the first string
3658 character that is not the first one in the visual order.
3659 (get_visually_first_element): New function, refactored from common
3660 parts of next_element_from_buffer, next_element_from_string, and
3661 next_element_from_c_string.
3662 (tool_bar_lines_needed, redisplay_tool_bar)
3663 (display_menu_bar): Force left-to-right direction. Add a FIXME
3664 comment for making that be controlled by a user option.
3665 (push_it, pop_it): Save and restore the state of the
3666 bidi iterator. Save and restore the bidi_p flag.
3667 (pop_it): Iterate out of display property for string iteration as
3669 (iterate_out_of_display_property): Support iteration over strings.
3670 (handle_single_display_spec): Set up it->bidi_it for iteration
3671 over a display string, and call bidi_init_it.
3672 (handle_single_display_spec, next_overlay_string)
3673 (get_overlay_strings_1, push_display_prop): Set up the bidi
3674 iterator for displaying display or overlay strings.
3675 (forward_to_next_line_start): Don't use the shortcut if
3677 (back_to_previous_visible_line_start): If handle_display_prop
3678 pushed the iterator stack, restore the internal state of the bidi
3679 iterator by calling bidi_pop_it same number of times.
3680 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3681 and we are bidi-iterating, don't decrement the iterator position;
3682 instead, set the first_elt flag in the bidi iterator, to produce
3684 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3685 (push_display_prop): xassert that we are iterating a buffer.
3686 (push_it, pop_it): Save and restore paragraph_embedding member.
3687 (handle_single_display_spec, next_overlay_string)
3688 (get_overlay_strings_1, reseat_1, reseat_to_string)
3689 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3690 correctly. Don't assume unibyte strings are not bidi-reordered.
3691 (compute_display_string_pos)
3692 (compute_display_string_end): Fix handling the case of C string.
3693 (push_it, pop_it): Save and restore from_disp_prop_p.
3694 (handle_single_display_spec, push_display_prop): Set the
3695 from_disp_prop_p flag.
3696 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3697 (pop_it): Call iterate_out_of_display_property only if we are
3698 popping after iteration over a string that came from a display
3699 property. Fix a typo in popping stretch info. Add an assertion
3700 for verifying that the iterator position is in sync with the bidi
3702 (handle_single_display_spec, get_overlay_strings_1)
3703 (push_display_prop): Fix initialization of paragraph direction for
3704 string when that of the parent object is not yet determined.
3705 (reseat_1): Call bidi_init_it to resync the bidi
3706 iterator with IT's position. (Bug#7616)
3707 (find_row_edges): If ROW->start.pos gives position
3708 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3709 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3710 Reset the from_disp_prop_p flag.
3711 (SAVE_IT, RESTORE_IT): New macros.
3712 (pos_visible_p, face_before_or_after_it_pos)
3713 (back_to_previous_visible_line_start)
3714 (move_it_in_display_line_to, move_it_in_display_line)
3715 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3716 (try_scrolling, redisplay_window, display_line): Use them when
3717 saving a temporary copy of the iterator and restoring it back.
3718 (back_to_previous_visible_line_start, reseat_1)
3719 (init_iterator): Empty the bidi cache "stack".
3720 (move_it_in_display_line_to): If iterator ended up at
3721 EOL, but we never saw any buffer positions smaller than
3722 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3723 motion in bidi-reordered lines.
3724 (move_it_in_display_line_to): Record prev_method and prev_pos
3725 immediately before the call to set_iterator_to_next. Fixes cursor
3726 motion in bidi-reordered lines with stretch glyphs and strings
3727 displayed in margins. (Bug#8133) (Bug#8867)
3728 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3730 (pos_visible_p): Support positions in bidi-reordered lines.
3731 Save and restore bidi cache.
3733 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3734 (bidi_paragraph_info): Delete unused struct.
3735 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3736 (bidi_cache_start): New variable.
3737 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3739 (bidi_cache_fetch_state, bidi_cache_search)
3740 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3741 (bidi_cache_find, bidi_peek_at_next_level)
3742 (bidi_level_of_next_char, bidi_find_other_level_edge)
3743 (bidi_move_to_visually_next): Compare cache index with
3744 bidi_cache_start rather than with zero.
3745 (bidi_fetch_char): Accept new argument STRING; all callers
3746 changed. Support iteration over a string. Support strings with
3747 display properties. Support unibyte strings. Fix the type of
3748 `len' according to what STRING_CHAR_AND_LENGTH expects.
3749 (bidi_paragraph_init, bidi_resolve_explicit_1)
3750 (bidi_resolve_explicit, bidi_resolve_weak)
3751 (bidi_level_of_next_char, bidi_move_to_visually_next):
3752 Support iteration over a string.
3753 (bidi_set_sor_type, bidi_resolve_explicit_1)
3754 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3755 can now be zero (for strings); special values 0 and -1 were
3756 changed to -1 and -2, respectively.
3757 (bidi_char_at_pos): New function.
3758 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3759 Call it instead of FETCH_MULTIBYTE_CHAR.
3760 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3761 initialized to valid values.
3762 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3764 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3765 the test for valid cached positions. Fix the logic for looking up
3766 the sentinel state in the cache. GCPRO the Lisp string we are
3768 (bidi_push_it, bidi_pop_it): New functions.
3769 (bidi_initialize): Initialize the bidi cache start stack pointer.
3770 (bidi_cache_ensure_space): New function, refactored from part of
3771 bidi_cache_iterator_state. Don't assume the required size is just
3772 one BIDI_CACHE_CHUNK away.
3773 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3774 (bidi_count_bytes, bidi_char_at_pos): New functions.
3775 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3776 always valid if bidi_cache_idx is valid.
3777 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3778 is valid if it's going to be used.
3779 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3780 (bidi_cache_fetch_state, bidi_cache_search)
3781 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3782 (bidi_cache_iterator_state, bidi_cache_find)
3783 (bidi_find_other_level_edge, bidi_cache_start_stack):
3784 All variables related to cache indices are now EMACS_INT.
3786 * dispextern.h (struct bidi_string_data): New structure.
3787 (struct bidi_it): New member `string'. Make flag members be 1-bit
3788 fields, and put them last in the struct.
3789 (compute_display_string_pos, compute_display_string_end):
3791 (bidi_push_it, bidi_pop_it): Add prototypes.
3792 (struct iterator_stack_entry): New members bidi_p,
3793 paragraph_embedding, and from_disp_prop_p.
3794 (struct it): Member bidi_p is now a bit field 1 bit wide.
3795 (bidi_shelve_cache, bidi_unshelve_cache):
3798 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3799 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3800 and vector-like objects.
3802 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3803 cache around display iteration.
3805 * window.c (Fwindow_end, window_scroll_pixel_based)
3806 (displayed_window_lines, Frecenter): Save and restore the bidi
3807 cache around display iteration.
3809 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3811 * editfns.c (Fdelete_region): Clarify the use of the named
3812 parameters (bug#6788).
3814 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3816 * indent.c (Fvertical_motion): Set and restore w->pointm when
3817 saving and restoring the window's buffer (Bug#9006).
3819 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3821 * editfns.c (Fstring_to_char): Clarify just what is returned
3822 (bug#6576). Text by Eli Zaretskii.
3824 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3826 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3828 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3830 * buffer.c (mmap_find): Fix a typo.
3832 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3834 Fix execution of x selection hooks.
3835 * xselect.c (Qx_lost_selection_functions)
3836 (Qx_sent_selection_functions): New vars.
3837 (syms_of_xselect): DEFSYM them.
3838 (x_handle_selection_request): Pass Qx_sent_selection_functions
3839 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3840 (x_handle_selection_clear,x_clear_frame_selections):
3841 Pass Qx_lost_selection_functions rather than
3842 Vx_lost_selection_functions to Frun_hook_with_args.
3844 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3846 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3847 The old code sometimes used this field without initializing it.
3849 * alloc.c (gc_sweep): Don't read past end of array.
3850 In theory, the old code could also have corrupted Emacs internals,
3851 though it'd be very unlikely.
3853 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3855 * character.c (Fcharacterp): Don't advertise optional ignored
3856 argument. (Bug#4026)
3858 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3860 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3863 * window.c (Fset_window_start): Doc fix (bug#4199).
3864 (Fset_window_hscroll): Ditto.
3866 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3868 Fix minor new problems caught by GCC 4.6.1.
3869 * term.c (init_tty): Remove unused local.
3870 * xsettings.c (store_monospaced_changed): Define this function only
3871 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3874 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3876 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3878 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3880 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3881 are the mini-buffer and the echo area (bug#3320).
3883 * term.c (init_tty): Remove support for supdup, c10 and perq
3884 terminals, which are no longer supported (bug#1482).
3886 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3888 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3890 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3892 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3893 for non-popups (Bug#3642).
3895 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3897 * alloc.c (reset_malloc_hooks): Protoize.
3898 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3899 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3900 * cm.c (losecursor): Likewise.
3901 * data.c (fmod): Likewise.
3902 * dispnew.c (swap_glyphs_in_rows): Likewise.
3903 * emacs.c (memory_warning_signal): Likewise.
3904 * floatfns.c (float_error): Likewise.
3905 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3906 (otf_open, font_otf_capability, generate_otf_features)
3907 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3909 * image.c (pbm_read_file): Likewise.
3910 * indent.c (string_display_width): Likewise.
3911 * intervals.c (check_for_interval, search_for_interval)
3912 (inc_interval_count, count_intervals, root_interval)
3913 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3914 * lread.c (defalias): Likewise.
3915 * ralloc.c (r_alloc_check): Likewise.
3916 * regex.c (set_image_of_range_1, set_image_of_range)
3917 (regex_grow_registers): Likewise.
3918 * sysdep.c (strerror): Likewise.
3919 * termcap.c (valid_filename_p, tprint, main): Likewise.
3920 * tparam.c (main): Likewise.
3921 * unexhp9k800.c (run_time_remap, save_data_space)
3922 (update_file_ptrs, read_header, write_header, calculate_checksum)
3923 (copy_file, copy_rest, display_header): Likewise.
3924 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3926 * xdisp.c (check_it): Likewise.
3927 * xfaces.c (register_color, unregister_color, unregister_colors):
3929 * xfns.c (print_fontset_result): Likewise.
3930 * xrdb.c (member, fatal, main): Likewise.
3932 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3934 Fix minor problems found by static checking (Bug#9031).
3935 * chartab.c (char_table_set_range, map_sub_char_table):
3936 Remove unused locals.
3937 (uniprop_table): Now static.
3938 * composite.c (_work_char): Remove unused static var.
3940 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3942 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3944 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3946 * gtkutil.c (qttip_cb): Remove code without function.
3948 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3950 * w32.c (pthread_sigmask): New stub.
3952 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3954 Use pthread_sigmask, not sigprocmask (Bug#9010).
3955 sigprocmask is portable only for single-threaded applications, and
3956 Emacs can be multi-threaded when it uses GTK.
3957 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3959 * callproc.c (Fcall_process):
3960 * process.c (create_process):
3961 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3962 Use pthread_sigmask, not sigprocmask.
3964 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3966 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3967 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3970 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3972 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3973 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3974 (xg_hide_tooltip): Fix comment.
3976 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3977 in registerServicesMenuSendTypes.
3978 (validRequestorForSendType): Don't check ns_return_types.
3980 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3983 2011-07-08 Jason Rumney <jasonr@gnu.org>
3985 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3986 SH_SHOW for hidden windows (Bug#5482).
3988 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3989 frame struct members of non-existent frames (Bug#6284).
3991 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3993 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3994 variable firstTime not needed on OSX >= 10.6.
3995 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3996 >= 10.5. Use setKnobProportion, setDoubleValue.
3998 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3999 (MAC_OS_X_VERSION_10_5): Define if not defined.
4000 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4001 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4002 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4004 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4005 cString and lossyCString on OSX >= 10.4
4007 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4008 sizeToFit on OSX >= 10.2.
4010 * nsimage.m (allocInitFromFile): Don't use deprecated method
4011 bestRepresentationForDevice on OSX >= 10.6.
4013 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4016 * emacs.c: Declare unexec_init_emacs_zone.
4018 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4020 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4022 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4023 on svcsMenu (Bug#8842).
4025 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4027 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4029 * nsterm.m (QUTF8_STRING): Declare.
4030 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4031 (validRequestorForSendType): Return type is (id).
4032 Change indexOfObjectIdenticalTo to indexOfObject.
4033 Check if we have local selection before returning self (Bug#8842).
4034 (writeSelectionToPasteboard): Put local selection into paste board
4035 if we have a local selection (Bug#8842).
4036 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4038 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4039 (ns_get_local_selection): Declare.
4041 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4043 * keymap.c (describe_map_tree): Don't insert a double newline at
4044 the end of the buffer (bug#1169) and return whether we inserted
4047 * callint.c (Fcall_interactively): Change "reading args" to
4048 "providing args" to try to clarify what it does (bug#1010).
4050 2011-07-07 Kenichi Handa <handa@m17n.org>
4052 * composite.c (composition_compute_stop_pos): Ignore a static
4053 composition starting before CHARPOS (Bug#8915).
4055 * xdisp.c (handle_composition_prop): Likewise.
4057 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4059 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4062 2011-07-07 Kenichi Handa <handa@m17n.org>
4064 * character.h (unicode_category_t): New enum type.
4066 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4067 (Qchar_code_property_table): New variable.
4068 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4069 (UNIPROP_COMPRESSED_FORM_P): New macros.
4070 (char_table_ascii): Uncompress the compressed values.
4071 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4072 Uncompress the compressed values.
4073 (sub_char_table_ref_and_range): Likewise.
4074 (char_table_ref_and_range): Uncompress the compressed values.
4075 (sub_char_table_set): New arg is_uniprop. Callers changed.
4076 Uncompress the compressed values.
4077 (sub_char_table_set_range): Args changed. Callers changed.
4078 (char_table_set_range): Adjuted for the above change.
4079 (map_sub_char_table): Delete args default_val and parent. Add arg
4080 top. Give decoded values to a Lisp function.
4081 (map_char_table): Adjust for the above change. Give decoded
4082 values to a Lisp function. Gcpro more variables.
4083 (uniprop_table_uncompress)
4084 (uniprop_decode_value_run_length): New functions.
4085 (uniprop_decoder, uniprop_decoder_count): New variables.
4086 (uniprop_get_decoder, uniprop_encode_value_character)
4087 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4089 (uniprop_encoder, uniprop_encoder_count): New variables.
4090 (uniprop_get_encoder, uniprop_table)
4091 (Funicode_property_table_internal, Fget_unicode_property_internal)
4092 (Fput_unicode_property_internal): New functions.
4093 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4094 Sunicode_property_table_internal, Sget_unicode_property_internal,
4095 and Sput_unicode_property_internal. Defvar_lisp
4096 char-code-property-alist.
4098 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4099 Vunicode_category_table.
4101 * font.c (font_range): Adjust for the change of
4102 Vunicode_category_table.
4104 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4106 * m/iris4d.h: Remove file, move contents ...
4107 * s/irix6-5.h: ... here.
4109 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4111 Remove unportable assumption about struct layout (Bug#8884).
4112 * alloc.c (mark_buffer):
4113 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4114 (clone_per_buffer_values): Don't assume that
4115 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4116 This isn't true in general, and it's particularly not true
4117 if Emacs is configured with --with-wide-int.
4118 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4119 New macros, used in the buffer.c change.
4121 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4123 * xsettings.c: Use both GConf and GSettings if both are available.
4124 (store_config_changed_event): Add comment.
4125 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4126 (store_tool_bar_style_changed): New functions.
4127 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4128 (struct xsettings): Move font inside HAVE_XFT.
4129 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4130 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4131 Move inside HAVE_XFT.
4132 (something_changed_gsettingsCB): Rename from something_changedCB.
4133 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4135 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4136 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4137 (something_changed_gconfCB): Rename from something_changedCB.
4138 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4139 (parse_settings): Move check for font inside HAVE_XFT.
4140 (read_settings, apply_xft_settings): Add comment.
4141 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4142 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4143 call store_font_name_changed.
4144 (xft_settings_event): Add comment.
4145 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4146 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4147 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4148 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4149 (xsettings_initialize): Call init_gsettings last.
4150 (xsettings_get_system_font, xsettings_get_system_normal_font):
4153 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4155 Random fixes. E.g., (random) never returned negative values.
4156 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4157 subseconds part to the entropy, as that's a bit more random.
4158 Prefer signed to unsigned, since the signedness doesn't matter and
4159 in general we prefer signed. When given a limit, use a
4160 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4161 latter isn't right if USE_2_TAGS_FOR_INTS.
4162 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4163 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4165 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4167 * textprop.c (text_property_stickiness):
4168 Obey Vtext_property_default_nonsticky.
4169 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4170 * w32fns.c (syms_of_w32fns):
4171 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4173 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4175 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4176 This is more efficient than Ffile_directory_p and avoids a minor race.
4178 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4180 * buffer.c (Foverlay_put): Say what the return value is
4183 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4184 is a directory before asking whether to use the file name
4186 (barf_or_query_if_file_exists): Make the "File is a directory"
4187 error be more correct.
4189 * fns.c (Frequire): Remove the mention of the .gz files, since
4190 that's installation-specific, but keep the mention of
4191 `get-load-suffixes'.
4193 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4195 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4196 Report string overflow if the output is too long.
4198 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4200 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4201 (syms_of_gnutls): Remove duplicate DEFSYM for
4202 Qgnutls_bootprop_verify_hostname_error, an error for
4203 Qgnutls_bootprop_verify_error (which is no longer used).
4205 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4206 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4207 Also (re)move comments that are misplaced or no longer relevant.
4209 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4211 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4213 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4215 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4216 and background color parameters if they have been changed.
4218 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4220 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4222 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4224 * xsettings.c (SYSTEM_FONT): Define only when used.
4225 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4227 * keymap.c (access_keymap_1): Now static.
4229 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4231 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4232 leave any prefix arg for the up event (Bug#1586).
4234 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4236 * lread.c (syms_of_lread): Mention single symbols defined by
4237 `defvar' or `defconst' (bug#7154).
4239 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4240 (Frequire): Mention get-load-suffixes.
4242 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4244 * window.h (window): Remove clone_number slot.
4245 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4247 (make_parent_window, make_window, saved_window)
4248 (Fset_window_configuration, save_window_save): Don't deal with
4250 * buffer.c (Qclone_number): Remove declaration.
4251 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4253 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4255 Add multiple inheritance to keymaps.
4256 * keymap.c (Fmake_composed_keymap): New function.
4257 (Fset_keymap_parent): Simplify.
4258 (fix_submap_inheritance): Remove.
4259 (access_keymap_1): New function extracted from access_keymap to handle
4260 embedded parents and handle lists of maps.
4261 (access_keymap): Use it.
4262 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4263 (Fcopy_keymap): Handle embedded parents.
4264 (Fcommand_remapping, define_as_prefix): Simplify.
4265 (Fkey_binding): Simplify.
4266 (syms_of_keymap): Move minibuffer-local-completion-map,
4267 minibuffer-local-filename-completion-map,
4268 minibuffer-local-must-match-map, and
4269 minibuffer-local-filename-must-match-map to Elisp.
4270 (syms_of_keymap): Defsubr make-composed-keymap.
4271 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4272 (parse_menu_item): Trivial simplification.
4274 2011-07-01 Glenn Morris <rgm@gnu.org>
4276 * Makefile.in (SETTINGS_LIBS): Fix typo.
4278 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4280 * coding.c (Fencode_coding_string): Record the last coding system
4281 used, as the function doc string says (bug#8738).
4283 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4285 * xsettings.c (store_monospaced_changed): Take new font as arg and
4286 check for change against current_mono_font.
4287 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4288 (emacs_settings_constructor, emacs_settings_get_property)
4289 (emacs_settings_set_property, emacs_settings_class_init)
4290 (emacs_settings_init, gsettings_obj): Remove.
4291 (something_changedCB): New function for HAVE_GSETTINGS.
4292 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4293 with value as argument.
4294 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4295 g_settings_new (Bug#8967). Do not create gsettings_obj.
4296 Remove calls to g_settings_bind. Connect something_changedCB to
4299 * xgselect.c: Add defined (HAVE_GSETTINGS).
4300 (xgselect_initialize): Ditto.
4302 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4303 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4306 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4308 * eval.c (struct backtrace): Simplify and port the data structure.
4309 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4310 signed bit field, as this assumption is not portable and it makes
4311 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4312 "char debug_on_exit : 1" as this is not portable either; instead,
4313 use the portable "unsigned int debug_on_exit : 1". Remove unused
4314 member evalargs. Remove obsolete comments about cc bombing out.
4316 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4318 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4319 Let HAVE_GSETTINGS override HAVE_GCONF.
4320 (store_monospaced_changed): New function.
4321 (EMACS_SETTINGS): A new type derived from GObject to handle
4322 GSettings notifications.
4323 (emacs_settings_constructor, emacs_settings_get_property)
4324 (emacs_settings_set_property, emacs_settings_class_init):
4326 (gsettings_client, gsettings_obj): New variables.
4327 (GSETTINGS_SCHEMA): New define.
4328 (something_changedCB): Call store_monospaced_changed.
4329 (init_gsettings): New function.
4330 (xsettings_initialize): Call init_gsettings.
4331 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4334 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4337 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4339 * window.c (resize_root_window, grow_mini_window)
4340 (shrink_mini_window): Rename Qresize_root_window to
4341 Qwindow_resize_root_window and Qresize_root_window_vertically to
4342 Qwindow_resize_root_window_vertically.
4344 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4346 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4348 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4350 * makefile.w32-in: Redesign dependencies so they reflect more
4351 clearly which files are directly included by each source file,
4352 and not through other includes.
4354 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4356 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4357 (sort_overlays, overlay_strings): When an overlay's clone number
4358 matches the window's clone number process the overlay even if
4359 the overlay's window property doesn't match the current window.
4361 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4362 (Fwindow_hchild): Rename to Fwindow_left_child.
4363 (Fwindow_next): Rename to Fwindow_next_sibling.
4364 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4365 (resize_window_check): Rename to window_resize_check.
4366 (resize_window_apply): Rename to window_resize_apply.
4367 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4368 (Fdelete_other_windows_internal, resize_frame_windows)
4369 (Fsplit_window_internal, Fdelete_window_internal)
4370 (grow_mini_window, shrink_mini_window)
4371 (Fresize_mini_window_internal): Fix callers accordingly.
4373 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4375 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4376 (emacs_fixed_set_min_size): Remove.
4377 (emacs_fixed_new): Take frame as argument.
4379 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4380 (_EmacsFixedPrivate): Remove minwidth/height.
4381 Add struct frame *f.
4382 (emacs_fixed_init): Initialize priv->f.
4383 (get_parent_class, emacs_fixed_set_min_size): Remove.
4384 (emacs_fixed_new): Set priv->f to argument.
4385 (emacs_fixed_get_preferred_width)
4386 (emacs_fixed_get_preferred_height): Use min_width/height from
4387 frames size_hint to set minimum and natural (Bug#8919).
4388 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4389 and use min_width/height from frames size_hint to set
4390 min_width/height (Bug#8919).
4392 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4393 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4396 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4398 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4399 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4402 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4404 * process.c (wait_reading_process_output): Bypass select if
4405 waiting for a cell while ignoring keyboard input, and input is
4406 pending. Suggested by Jan Djärv (Bug#8869).
4408 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4410 Use gnulib's dup2 module instead of rolling our own.
4411 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4413 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4415 * dispnew.c (scrolling_window): Before scrolling, turn off a
4416 mouse-highlight in the window being scrolled.
4418 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4420 Move DEFSYM to lisp.h and use everywhere.
4422 * character.h (DEFSYM): Move declaration...
4423 * lisp.h (DEFSYM): ...here.
4429 * w32select.c: Don't include character.h.
4431 * alloc.c (syms_of_alloc):
4432 * buffer.c (syms_of_buffer):
4433 * bytecode.c (syms_of_bytecode):
4434 * callint.c (syms_of_callint):
4435 * casefiddle.c (syms_of_casefiddle):
4436 * casetab.c (init_casetab_once):
4437 * category.c (init_category_once, syms_of_category):
4438 * ccl.c (syms_of_ccl):
4439 * cmds.c (syms_of_cmds):
4440 * composite.c (syms_of_composite):
4441 * dbusbind.c (syms_of_dbusbind):
4442 * dired.c (syms_of_dired):
4443 * dispnew.c (syms_of_display):
4444 * doc.c (syms_of_doc):
4445 * editfns.c (syms_of_editfns):
4446 * emacs.c (syms_of_emacs):
4447 * eval.c (syms_of_eval):
4448 * fileio.c (syms_of_fileio):
4449 * fns.c (syms_of_fns):
4450 * frame.c (syms_of_frame):
4451 * fringe.c (syms_of_fringe):
4452 * insdel.c (syms_of_insdel):
4453 * keymap.c (syms_of_keymap):
4454 * lread.c (init_obarray, syms_of_lread):
4455 * macros.c (syms_of_macros):
4456 * msdos.c (syms_of_msdos):
4457 * print.c (syms_of_print):
4458 * process.c (syms_of_process):
4459 * search.c (syms_of_search):
4460 * sound.c (syms_of_sound):
4461 * syntax.c (init_syntax_once, syms_of_syntax):
4462 * terminal.c (syms_of_terminal):
4463 * textprop.c (syms_of_textprop):
4464 * undo.c (syms_of_undo):
4465 * w32.c (globals_of_w32):
4466 * window.c (syms_of_window):
4467 * xdisp.c (syms_of_xdisp):
4468 * xfaces.c (syms_of_xfaces):
4469 * xfns.c (syms_of_xfns):
4470 * xmenu.c (syms_of_xmenu):
4471 * xsettings.c (syms_of_xsettings):
4472 * xterm.c (syms_of_xterm): Use DEFSYM.
4474 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4476 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4478 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4480 Integer and buffer overflow fixes (Bug#8873).
4482 * print.c (printchar, strout): Check for string overflow.
4483 (PRINTPREPARE, printchar, strout):
4484 Don't set size unless allocation succeeds.
4486 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4487 for sizes. Check for string overflow more accurately.
4488 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4490 * macros.c: Integer and buffer overflow fixes.
4491 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4492 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4493 Use ptrdiff_t, not int, for sizes.
4494 Don't increment bufsize until after realloc succeeds.
4495 Check for size-calculation overflow.
4496 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4498 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4500 * lread.c: Integer overflow fixes.
4501 (read_integer): Radix is now EMACS_INT, not int,
4502 to improve quality of diagnostics for out-of-range radices.
4503 Calculate buffer size correctly for out-of-range radices.
4504 (read1): Check for integer overflow in radices, and in
4505 read-circle numbers.
4506 (read_escape): Avoid int overflow.
4507 (Fload, openp, read_buffer_size, read1)
4508 (substitute_object_recurse, read_vector, read_list, map_obarray):
4509 Use ptrdiff_t, not int, for sizes.
4510 (read1): Use EMACS_INT, not int, for sizes.
4511 Check for size overflow.
4513 * image.c (cache_image): Check for size arithmetic overflow.
4515 * lread.c: Integer overflow issues.
4516 (saved_doc_string_size, saved_doc_string_length)
4517 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4518 Now ptrdiff_t, not int.
4519 (read1): Don't assume doc string length fits in int. Check for
4520 out-of-range doc string lengths.
4521 (read_list): Don't assume file position fits in int.
4522 (read_escape): Check for hex character overflow.
4524 2011-06-22 Leo Liu <sdl.web@gmail.com>
4526 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4527 Move to minibuffer.el.
4529 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4531 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4532 The following patches are for when GLYPH_DEBUG && !XASSERT.
4533 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4534 * dispnew.c (flush_stdout):
4535 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4536 Mark as externally visible.
4537 * dispnew.c (check_window_matrix_pointers): Now static.
4538 * dispnew.c (window_to_frame_vpos):
4539 * xfns.c (unwind_create_frame):
4540 * xterm.c (x_check_font): Remove unused local.
4541 * scroll.c (CHECK_BOUNDS):
4542 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4543 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4544 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4545 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4546 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4548 (debug_method_add): Use va_list and vsprintf rather than relying
4549 on undefined behavior with wrong number of arguments.
4550 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4551 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4552 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4553 since we're not interested in debugging glyphs with old libraries.
4554 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4555 GCC 4.6.0's static checking.
4557 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4559 Integer overflow and signedness fixes (Bug#8873).
4560 A few related buffer overrun fixes, too.
4562 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4564 * dispextern.h (struct face.stipple):
4565 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4566 (x_bitmap_mask, x_allocate_bitmap_record)
4567 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4568 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4569 (x_create_bitmap_from_xpm_data):
4570 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4571 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4573 * xfaces.c (load_pixmap):
4574 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4575 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4576 (.bitmaps_last, struct x_output.icon_bitmap):
4577 Use ptrdiff_t, not int, for bitmap indexes.
4578 (x_allocate_bitmap_record): Check for size overflow.
4579 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4581 Use ptrdiff_t, not int, for overlay counts.
4582 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4583 * editfns.c (overlays_around, get_pos_property):
4584 * textprop.c (get_char_property_and_overlay):
4585 * xdisp.c (next_overlay_change, note_mouse_highlight):
4586 * xfaces.c (face_at_buffer_position):
4587 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4588 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4589 (Fnext_overlay_change, Fprevious_overlay_change)
4590 (mouse_face_overlay_overlaps, Foverlays_in):
4591 Use ptrdiff_t, not int, for sizes.
4592 (overlays_at, overlays_in): Check for size-calculation overflow.
4594 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4596 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4597 (x_session_initialize): Do not assume string length fits in int.
4599 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4600 This is unlikely, but can occur if DPI is outlandish.
4602 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4603 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4605 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4606 * xrdb.c (magic_file_p, search_magic_path):
4607 Omit last arg SUFFIX; it was always 0. All callers changed.
4608 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4610 * xfont.c (xfont_match): Avoid need for strlen.
4612 * xfns.c: Don't assume strlen fits in int.
4613 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4615 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4616 not unsigned long, as we prefer signed integers. All callers changed.
4617 Detect integer overflow in repeat count.
4618 (message_dolog): Don't assume print length fits in 39 bytes.
4619 (display_mode_element): Don't assume strlen fits in int.
4621 * termcap.c: Don't assume sizes fit in int and never overflow.
4622 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4623 (gobble_line): Check for size-calculation overflow.
4625 * minibuf.c (Fread_buffer):
4626 * lread.c (intern, intern_c_string):
4627 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4628 Don't assume string length fits in int.
4630 * keyboard.c (parse_tool_bar_item):
4631 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4633 * font.c: Don't assume string length fits in int.
4634 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4635 Use ptrdiff_t, not int.
4636 (font_intern_prop): Don't assume string length fits in int.
4637 Don't assume integer property fits in fixnum.
4638 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4640 * filelock.c: Fix some buffer overrun and integer overflow issues.
4641 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4642 Reformulate so as not to need the command string.
4643 Invoke gzip -cd rather than gunzip, as it's more portable.
4644 (lock_info_type, lock_file_1, lock_file):
4645 Don't assume pid_t and time_t fit in unsigned long.
4646 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4647 (current_lock_owner): Prefer signed type for sizes.
4648 Use memcpy, not strncpy, where memcpy is what is really wanted.
4649 Don't assume (via atoi) that time_t and pid_t fit in int.
4650 Check for time_t and/or pid_t out of range, e.g., via a network share.
4651 Don't alloca where an auto var works fine.
4653 * fileio.c: Fix some integer overflow issues.
4654 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4655 Don't assume string length fits in int.
4656 (directory_file_name): Don't assume string length fits in long.
4657 (make_temp_name): Don't assume pid fits in int, or that its print
4658 length is less than 20.
4660 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4662 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4664 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4666 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4667 We prefer signed integers, even for size calculations.
4669 * emacs.c: Don't assume string length fits in 'int'.
4670 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4671 (main): Don't invoke strlen when not needed.
4673 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4674 (XD_DEBUG_MESSAGE): Don't waste a byte.
4676 * callproc.c (getenv_internal_1, getenv_internal)
4678 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4680 * lread.c (invalid_syntax): Omit length argument.
4681 All uses changed. This doesn't fix a bug, but it simplifies the
4682 code away from its former Hollerith-constant appearance, and it's
4683 one less 'int' to worry about when looking at integer-overflow issues.
4684 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4686 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4687 This didn't break anything, but it didn't help either.
4688 It's confusing to put a bogus integer in a place where the actual
4689 value does not matter.
4690 (LIST_END_P): Remove unused macro and its bogus comment.
4691 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4693 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4694 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4696 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4697 We prefer signed types, and the value cannot exceed the EMACS_INT
4698 range anyway (because otherwise the length would not be representable).
4699 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4700 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4701 This avoids a GCC warning when WIDE_EMACS_INT.
4703 * indent.c (sane_tab_width): New function.
4704 (current_column, scan_for_column, Findent_to, position_indentation)
4705 (compute_motion): Use it. This is just for clarity.
4706 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4708 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4710 * lisp.h (lint_assume): New macro.
4711 * composite.c (composition_gstring_put_cache):
4712 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4714 * editfns.c, insdel.c:
4715 Omit unnecessary forward decls, to simplify future changes.
4717 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4719 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4721 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4722 Use much-faster test for byte-length change.
4723 Don't assume string byte-length fits in 'int'.
4724 Check that character arg fits in 'int'.
4725 (mapcar1): Declare byte as byte, for clarity.
4727 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4729 * fns.c (concat): Catch string overflow earlier.
4730 Do not rely on integer wraparound.
4732 * dispextern.h (struct it.overlay_strings_charpos)
4733 (struct it.selective): Now EMACS_INT, not int.
4734 * xdisp.c (forward_to_next_line_start)
4735 (back_to_previous_visible_line_start)
4736 (reseat_at_next_visible_line_start, next_element_from_buffer):
4737 Don't arbitrarily truncate the value of 'selective' to int.
4739 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4741 * composite.c: Don't truncate sizes to 'int'.
4742 (composition_gstring_p, composition_reseat_it)
4743 (composition_adjust_point): Use EMACS_INT, not int.
4744 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4745 not EMACS_UINT, for indexes.
4747 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4749 * buffer.c: Include <verify.h>.
4750 (struct sortvec.priority, struct sortstr.priority):
4751 Now EMACS_INT, not int.
4752 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4753 (struct sortstr.size, record_overlay_string)
4754 (struct sortstrlist.size, struct sortlist.used):
4755 Don't truncate size to int.
4756 (record_overlay_string): Check for size-calculation overflow.
4757 (init_buffer_once): Check at compile-time, not run-time.
4759 2011-06-22 Jim Meyering <meyering@redhat.com>
4761 Don't leak an XBM-image-sized buffer
4762 * image.c (xbm_load): Free the image buffer after using it.
4764 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4767 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4768 that Sun C diagnosed.
4769 * fns.c (secure_hash): Fix pointer signedness issue.
4770 * intervals.c (static_offset_intervals): New function.
4771 (offset_intervals): Use it.
4773 2011-06-21 Leo Liu <sdl.web@gmail.com>
4776 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4779 * fns.c (secure_hash): Rename from crypto_hash_function and change
4780 the first arg to accept symbols.
4781 (Fsecure_hash): New primitive.
4782 (syms_of_fns): New symbols.
4784 2011-06-20 Deniz Dogan <deniz@dogan.se>
4786 * process.c (Fset_process_buffer): Clarify return value in
4789 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4791 * dispnew.c (add_window_display_history): Use BVAR.
4793 * xdisp.c (debug_method_add): Use BVAR.
4794 (check_window_end, dump_glyph_matrix, dump_glyph)
4795 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4797 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4800 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4801 check till after the cache is created in init_frame_faces.
4803 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4805 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4807 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4809 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4810 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4811 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4813 Improve buffer-overflow checking (Bug#8873).
4814 * fileio.c (Finsert_file_contents):
4815 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4816 Remove the old (too-loose) buffer overflow checks.
4817 They weren't needed, since make_gap checks for buffer overflow.
4818 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4819 The old code merely checked for Emacs fixnum overflow, and relied
4820 on undefined (wraparound) behavior. The new code avoids undefined
4821 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4823 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4824 Tune. Don't use wider integers than needed. Don't use alloca.
4825 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4827 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4829 * insdel.c, lisp.h (buffer_overflow): New function.
4830 (insert_from_buffer_1, replace_range, replace_range_2):
4831 * insdel.c (make_gap_larger):
4832 * editfns.c (Finsert_char):
4833 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4835 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4837 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4839 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4841 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4842 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4844 * fileio.c: Don't assume EMACS_INT fits in off_t.
4845 (emacs_lseek): New static function.
4846 (Finsert_file_contents, Fwrite_region): Use it.
4847 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4849 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4851 * fns.c: Don't overflow int when computing a list length.
4852 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4853 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4854 truncation on 64-bit hosts. Check for QUIT every
4855 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4856 faster and is responsive enough.
4857 (Flength): Report an error instead of overflowing an integer.
4858 (Fsafe_length): Return a float if the value is not representable
4859 as a fixnum. This shouldn't happen except in contrived situations.
4860 (Fnthcdr, Fsort): Don't assume list length fits in int.
4861 (Fcopy_sequence): Don't assume vector length fits in int.
4863 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4864 (header_size, word_size): New constants.
4865 (allocate_vectorlike): Don't check size overflow here.
4866 (allocate_vector): Check it here instead, since this is the only
4867 caller of allocate_vectorlike that could cause overflow.
4868 Check that the new vector's length is representable as a fixnum.
4870 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4871 The previous code was bogus. For example, next_almost_prime (32)
4872 returned 39, which is undesirable as it is a multiple of 3; and
4873 next_almost_prime (24) returned 25, which is a multiple of 5 so
4874 why was the code bothering to check for multiples of 7?
4876 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4878 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4880 Variadic C functions now count arguments with ptrdiff_t.
4881 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4882 Back then I didn't know that the Emacs coding style prefers signed int.
4883 Also, in the meantime I found a few more instances where arguments
4884 were being counted with int, which may truncate counts on 64-bit
4885 machines, or EMACS_INT, which may be unnecessarily wide.
4886 * lisp.h (struct Lisp_Subr.function.aMANY)
4887 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4888 Arg counts are now ptrdiff_t, not size_t.
4889 All variadic functions and their callers changed accordingly.
4890 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4891 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4892 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4893 * callint.c (Fcall_interactively): Check arg count for overflow,
4894 to avoid potential buffer overrun. Use signed char, not 'int',
4895 for 'varies' array, so that we needn't bother to check its size
4896 calculation for overflow.
4897 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4898 * eval.c (apply_lambda):
4899 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4900 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4901 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4903 * callint.c (Fcall_interactively): Don't use index var as event count.
4905 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4906 * mem-limits.h (SIZE): Remove; no longer used.
4908 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4910 Remove unnecessary casts.
4911 * xterm.c (x_term_init):
4912 * xfns.c (x_set_border_pixel):
4913 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4914 These aren't needed now that we assume ANSI C.
4916 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4917 It's more likely to cause problems (due to unsigned overflow)
4920 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4922 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4924 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4926 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4928 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4930 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4932 GLYPH_CODE_FACE returns EMACS_INT, not int.
4933 * dispextern.h (merge_faces):
4934 * xfaces.c (merge_faces):
4935 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4936 Don't assume EMACS_INT fits in int.
4938 * character.h (CHAR_VALID_P): Remove unused parameter.
4939 * fontset.c, lisp.h, xdisp.c: All uses changed.
4941 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4943 * fns.c (concat): Minor tuning based on overflow analysis.
4944 This doesn't fix any bugs. Use int to hold character, instead
4945 of constantly refetching from Emacs object. Use XFASTINT, not
4946 XINT, for value known to be a character. Don't bother comparing
4947 a single byte to 0400, as it's always less.
4949 * floatfns.c (Fexpt):
4950 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4952 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4955 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4957 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4958 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4959 incorrectly succeed when S was a string, because 4294967386 was
4960 truncated before it was used.
4962 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4963 Otherwise, an out-of-range integer could cause undefined behavior
4966 * composite.c: Use int, not EMACS_INT, for characters.
4967 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4968 EMACS_INT, for values that are known to be in character range.
4969 This doesn't fix any bugs but is the usual style inside Emacs and
4970 may generate better code on 32-bit machines.
4972 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4973 This is for reasons similar to the recent CHAR_STRING fix.
4974 * charset.c (Fencode_char): Check that character arg is actually
4975 a character. Pass an int to ENCODE_CHAR.
4976 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4977 wider than 'int', as a compile-time check to prevent future regressions
4980 * character.c (char_string): Remove unnecessary casts.
4982 Make sure a 64-bit char is never passed to CHAR_STRING.
4983 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4984 by silently ignoring the top 32 bits, allowing some values
4985 that were far too large to be valid characters.
4986 * character.h: Include <verify.h>.
4987 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4988 arguments are no wider than unsigned, as a compile-time check
4989 to prevent future regressions in this area.
4991 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4992 (Fsubst_char_in_region):
4994 * xdisp.c (decode_mode_spec_coding):
4995 Adjust to CHAR_STRING's new requirement.
4996 * editfns.c (Finsert_char, Fsubst_char_in_region):
4997 * fns.c (concat): Check that character args are actually
4998 characters. Without this test, these functions did the wrong
4999 thing with wildly out-of-range values on 64-bit hosts.
5001 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5002 These casts should not be needed on 32-bit hosts, either.
5003 * keyboard.c (read_char):
5004 * lread.c (Fload): Remove casts to unsigned.
5006 * lisp.h (UNSIGNED_CMP): New macro.
5007 This fixes comparison bugs on 64-bit hosts.
5008 (ASCII_CHAR_P): Use it.
5009 * casefiddle.c (casify_object):
5010 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5011 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5012 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5013 * dispextern.h (FACE_FROM_ID):
5014 * keyboard.c (read_char): Use UNSIGNED_CMP.
5016 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5017 not to EMACS_INT, to avoid GCC warning.
5019 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5021 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5022 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5023 isn't needed on 32-bit machines.
5025 * buffer.c (Fgenerate_new_buffer_name):
5026 Use EMACS_INT for count, not int.
5027 (advance_to_char_boundary): Return EMACS_INT, not int.
5029 * data.c (Qcompiled_function): Now static.
5031 * window.c (window_body_lines): Now static.
5033 * image.c (gif_load): Rename local to avoid shadowing.
5035 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5036 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5037 * alloc.c (make_save_value): Integer argument is now of type
5039 (mark_object): Use ptrdiff_t, not int.
5040 * lisp.h (pD): New macro.
5041 * print.c (print_object): Use it.
5043 * alloc.c: Use EMACS_INT, not int, to count objects.
5044 (total_conses, total_markers, total_symbols, total_vector_size)
5045 (total_free_conses, total_free_markers, total_free_symbols)
5046 (total_free_floats, total_floats, total_free_intervals)
5047 (total_intervals, total_strings, total_free_strings):
5048 Now EMACS_INT, not int. All uses changed.
5049 (Fgarbage_collect): Compute overall total using a double, so that
5050 integer overflow is less likely to be a problem. Check for overflow
5051 when converting back to an integer.
5052 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5053 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5054 These were 'int' variables that could overflow on 64-bit hosts;
5055 they were never used, so remove them instead of repairing them.
5056 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5057 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5058 Previously, this ceilinged at INT_MAX, but that doesn't work on
5060 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5062 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5063 (allocate_vectorlike): Check for ptrdiff_t overflow.
5064 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5065 when a (possibly-narrower) signed value would do just as well.
5066 We prefer using signed arithmetic, to avoid comparison confusion.
5068 * alloc.c: Catch some string size overflows that we were missing.
5069 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5070 for convenience in STRING_BYTES_MAX.
5071 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5072 The definition here is exact; the one in lisp.h was approximate.
5073 (allocate_string_data): Check for string overflow. This catches
5074 some instances we weren't catching before. Also, it catches
5075 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5076 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5077 and ptrdiff_t and EMACS_INT are both 64 bits.
5079 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5080 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5081 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5083 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5085 * alloc.c (Fmake_string): Check for out-of-range init.
5087 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5089 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5091 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5093 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5094 xg_get_default_scrollbar_width.
5096 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5097 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5098 (style_changed_cb): Call update_theme_scrollbar_width and call
5099 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5100 all frames (Bug#8505).
5101 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5102 Call gtk_window_set_resizable if HAVE_GTK3.
5103 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5104 and height if HAVE_GTK3 (Bug#8505).
5105 (scroll_bar_width_for_theme): New variable.
5106 (update_theme_scrollbar_width): New function.
5107 (xg_get_default_scrollbar_width): Move code to
5108 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5109 (xg_initialize): Call update_theme_scrollbar_width.
5111 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5113 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5115 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5117 * frame.c (make_frame): Call other_buffer_safely instead of
5120 * window.c (temp_output_buffer_show): Call display_buffer with
5121 second argument Vtemp_buffer_show_specifiers and reset latter
5122 immediately after the call.
5123 (Vtemp_buffer_show_specifiers): New variable.
5124 (auto_window_vscroll_p, next_screen_context_lines)
5125 (Vscroll_preserve_screen_position): Remove leading asterisks from
5128 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5130 Fix minor problems found by GCC 4.6.0 static checking.
5131 * buffer.c (Qclone_number): Remove for now, as it's unused.
5132 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5133 (record_buffer): Remove unused local.
5134 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5135 (set_frame_buffer_list): Remove; unused.
5136 * frame.h (other_visible_frames): Remove decl.
5137 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5138 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5139 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5141 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5142 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5143 Define only if HAVE_GPM.
5144 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5145 (update_hints_inhibit): Remove; never set. All uses removed.
5146 * widgetprv.h (emacsFrameClassRec): Remove decl.
5147 * window.c (delete_deletable_window): Now returns void, since it
5148 wasn't returning anything.
5149 (compare_window_configurations): Remove unused locals.
5150 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5151 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5152 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5153 the same widths as pointers. This follows up on the 2011-05-06 patch.
5154 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5155 * xterm.h: Likewise.
5156 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5158 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5160 * makefile.w32-in: Update dependencies.
5161 (LISP_H): Add lib/intprops.h.
5163 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5165 * image.c (gif_load): Add animation frame delay to the metadata.
5166 (syms_of_image): Use DEFSYM. New symbol `delay'.
5168 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5170 * window.c (delete_deletable_window): Re-add.
5171 (Fset_window_configuration): Rewrite to handle dead buffers and
5172 consequently deletable windows.
5173 (window_tree, Fwindow_tree): Remove. Supply functionality in
5175 (compare_window_configurations): Simplify code.
5177 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5179 * image.c (imagemagick_load_image): Fix type mismatch.
5180 (Fimagemagick_types): Likewise.
5182 * window.h (replace_buffer_in_windows): Declare.
5184 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5186 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5187 Qclone_number. Remove external declaration of Qdelete_window.
5188 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5190 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5191 Run Qbuffer_list_update_hook if allowed.
5192 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5193 buffer list implementation.
5194 (other_buffer_safely): New function.
5195 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5196 calls to replace_buffer_in_windows and
5197 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5199 (record_buffer): Inhibit quitting and rewrite using quittable
5200 functions. Run Qbuffer_list_update_hook if allowed.
5201 (Frecord_buffer, Funrecord_buffer): New functions.
5202 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5203 Move switch-to-buffer to window.el.
5204 (bury-buffer): Move to window.el.
5205 (Vbuffer_list_update_hook): New variable.
5207 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5210 * window.h (resize_frame_windows): Move up in code.
5211 (Fwindow_frame): Remove EXFUN.
5212 (replace_buffer_in_all_windows): Remove prototype.
5213 (replace_buffer_in_windows_safely): Add prototype.
5215 * window.c: Declare Qdelete_window static again. Move down
5216 declaration of select_count.
5217 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5218 (Fother_window): Move to window.el.
5219 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5220 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5221 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5223 (replace_buffer_in_windows): Implement by calling
5224 Qreplace_buffer_in_windows.
5225 (replace_buffer_in_all_windows): Remove with some functionality
5226 moved into replace_buffer_in_windows_safely.
5227 (replace_buffer_in_windows_safely): New function.
5228 (select_window_norecord, select_frame_norecord): Move in front
5229 of run_window_configuration_change_hook. Remove now obsolete
5231 (Fset_window_buffer): Rewrite doc-string.
5232 Call Qrecord_window_buffer.
5233 (keys_of_window): Move binding for other-window to window.el.
5235 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5237 * dispextern.h (struct image): Replace data member, whose int_val
5238 and ptr_val fields were not used by anything, with a single
5241 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5242 (gif_clear_image, gif_load, imagemagick_load_image)
5243 (gs_clear_image, gs_load): Callers changed.
5245 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5247 * buffer.h: Include <time.h>, for time_t.
5248 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5250 Fix minor problems found by static checking.
5252 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5254 Make identifiers static if they are not used in other modules.
5255 * data.c (Qcompiled_function, Qframe, Qvector):
5256 * image.c (QimageMagick, Qsvg):
5257 * minibuf.c (Qmetadata):
5258 * window.c (resize_window_check, resize_root_window): Now static.
5259 * window.h (resize_window_check, resize_root_window): Remove decls.
5261 * window.c (window_deletion_count, delete_deletable_window):
5263 (window_body_lines): Now static.
5264 (Fdelete_other_windows_internal): Mark vars as initialized.
5265 Make sure 'resize_failed' is initialized.
5266 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5267 (resize_window_apply): Remove unused local.
5268 * window.h (delete_deletable_window): Remove decl.
5270 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5271 (imagemagick_load_image): Fix pointer signedness problem by changing
5272 last arg from unsigned char * to char *. All uses changed.
5273 Also, fix a local for similar reasons.
5274 Remove unused locals. Remove locals to avoid shadowing.
5275 (fn_rsvg_handle_free): Remove; unused.
5276 (svg_load, svg_load_image): Fix pointer signedness problem.
5277 (imagemagick_load_image): Don't use garbage pointer image_wand.
5279 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5281 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5283 * image.c (gif_load): Fix omitted cast error introduced by
5286 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5288 * window.h (resize_proportionally, orig_total_lines)
5289 (orig_top_line): Remove from window structure.
5290 (set_window_height, set_window_width, change_window_heights)
5291 (Fdelete_window): Remove prototypes.
5292 (resize_frame_windows): Remove duplicate declaration.
5294 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5296 * window.h (resize_frame_windows, resize_window_check)
5297 (delete_deletable_window, resize_root_window)
5298 (resize_frame_windows): Declare prototypes.
5300 * window.c (resize_window_apply): Make definition be "static" to
5301 match the prototype.
5303 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5305 * window.c: Remove declarations of Qwindow_size_fixed,
5306 window_min_size_1, window_min_size_2, window_min_size,
5307 size_window, window_fixed_size_p, enlarge_window, delete_window.
5308 Remove static from declaration of Qdelete_window, it's
5309 temporarily needed by Fbury_buffer.
5310 (replace_window): Don't assign orig_top_line and
5312 (Fdelete_window, delete_window): Remove. Window deletion is
5313 handled by window.el.
5314 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5315 Replace Fdelete_window calls with calls to Qdelete_window.
5316 (Fdelete_other_windows): Remove. Deleting other windows is
5317 handled by window.el.
5318 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5319 handled in window.el.
5320 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5321 Window minimum sizes are handled in window.el.
5322 (shrink_windows, size_window, set_window_height)
5323 (set_window_width, change_window_heights, window_height)
5324 (window_width, CURBEG, CURSIZE, enlarge_window)
5325 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5326 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5327 handled in window.el.
5328 (make_dummy_parent): Rename to make_parent_window and give it a
5329 second argument horflag.
5330 (make_window): Don't set resize_proportionally any more.
5331 (Fsplit_window): Remove. Windows are split in window.el.
5332 (save_restore_action, save_restore_orig_size)
5333 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5334 Resize mini windows in window.el.
5335 (grow_mini_window, shrink_mini_window): Implement by calling
5336 Qresize_root_window_vertically, resize_window_check and
5337 resize_window_apply.
5338 (saved_window, Fset_window_configuration, save_window_save):
5339 Do not handle orig_top_line, orig_total_lines, and
5340 resize_proportionally.
5341 (window_min_height, window_min_width): Move to window.el.
5342 (keys_of_window): Move bindings for delete-other-windows,
5343 split-window, delete-window and enlarge-window to window.el.
5345 * buffer.c: Temporarily extern Qdelete_window.
5346 (Fbury_buffer): Temporarily call Qdelete_window instead of
5347 Fdelete_window (Fbury_buffer will move to window.el soon).
5349 * frame.c (set_menu_bar_lines_1): Remove code handling
5350 orig_top_line and orig_total_lines.
5352 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5353 set_window_height but set heights directly.
5354 (change_frame_size_1): Use resize_frame_windows.
5356 * xdisp.c (init_xdisp): Don't use set_window_height but set
5359 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5360 Use resize_frame_windows instead of change_window_heights and run
5361 run_window_configuration_change_hook.
5363 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5364 instead of change_window_heights and run
5365 run_window_configuration_change_hook.
5367 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5369 * window.c (replace_window): Rename second argument REPLACEMENT to
5370 NEW. New third argument SETFLAG. Rewrite.
5371 (delete_window, make_dummy_parent): Call replace_window with
5373 (window_list_1): Move down in code.
5374 (run_window_configuration_change_hook): Move set_buffer part
5375 before select_frame_norecord part in order to unwind correctly.
5376 Rename count1 to count.
5377 (recombine_windows, delete_deletable_window, resize_root_window)
5378 (Fdelete_other_windows_internal)
5379 (Frun_window_configuration_change_hook, make_parent_window)
5380 (resize_window_check, resize_window_apply, Fresize_window_apply)
5381 (resize_frame_windows, Fsplit_window_internal)
5382 (Fdelete_window_internal, Fresize_mini_window_internal):
5384 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5386 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5388 * window.h (window): Add some new members to window structure -
5389 normal_lines, normal_cols, new_total, new_normal, clone_number,
5390 splits, nest, prev_buffers, next_buffers.
5391 (WINDOW_TOTAL_SIZE): Move here from window.c.
5392 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5394 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5396 (make_dummy_parent): Set new members of windows structure.
5397 (make_window): Move down in code. Handle new members of window
5399 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5400 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5401 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5402 (Fset_window_prev_buffers, Fwindow_next_buffers)
5403 (Fset_window_next_buffers, Fset_window_clone_number):
5405 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5406 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5408 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5409 Argument WINDOW can be now internal window too.
5410 (Fwindow_use_time): Move up in code.
5411 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5413 (Fset_window_configuration, saved_window)
5414 (Fcurrent_window_configuration, save_window_save): Handle new
5415 members of window structure.
5416 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5417 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5418 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5419 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5420 Qget_mru_window, Qresize_root_window,
5421 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5422 Qauto_buffer_name; staticpro them.
5424 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5426 * window.c (Fwindow_total_size, Fwindow_left_column)
5427 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5428 (Fwindow_list_1): New functions.
5429 (window_box_text_cols): Replace with window_body_cols.
5430 (Fwindow_width, Fscroll_left, Fscroll_right):
5431 Use window_body_cols instead of window_box_text_cols.
5432 (delete_window, Fset_window_configuration):
5433 Call delete_all_subwindows with window as argument.
5434 (delete_all_subwindows): Take a window as argument and not a
5436 (window_loop): Remove handling of GET_LRU_WINDOW and
5438 (Fget_lru_window, Fget_largest_window): Move to window.el.
5440 * window.h: Extern window_body_cols instead of
5441 window_box_text_cols. delete_all_subwindows now takes a
5442 Lisp_Object as argument.
5444 * indent.c (compute_motion, Fcompute_motion):
5445 Use window_body_cols instead of window_box_text_cols.
5447 * frame.c (delete_frame): Call delete_all_subwindows with root
5450 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5452 * fns.c (Fputhash): Document return value.
5454 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5456 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5458 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5460 Cons<->int and similar integer overflow fixes (Bug#8794).
5462 Check for overflow when converting integer to cons and back.
5463 * charset.c (Fdefine_charset_internal, Fdecode_char):
5464 Use cons_to_unsigned to catch overflow.
5465 (Fencode_char): Use INTEGER_TO_CONS.
5466 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5467 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5468 * data.c (long_to_cons, cons_to_long): Remove.
5469 (cons_to_unsigned, cons_to_signed): New functions.
5470 These signal an error for invalid or out-of-range values.
5471 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5472 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5473 * font.c (Ffont_variation_glyphs):
5474 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5475 * lisp.h: Include <intprops.h>.
5476 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5477 (cons_to_signed, cons_to_unsigned): New decls.
5478 (long_to_cons, cons_to_long): Remove decls.
5479 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5480 (Fprimitive_undo): Use CONS_TO_INTEGER.
5481 * xfns.c (Fx_window_property): Likewise.
5482 * xselect.c: Include <limits.h>.
5483 (x_own_selection, selection_data_to_lisp_data):
5484 Use INTEGER_TO_CONS.
5485 (x_handle_selection_request, x_handle_selection_clear)
5486 (x_get_foreign_selection, Fx_disown_selection_internal)
5487 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5488 (lisp_data_to_selection_data): Use cons_to_unsigned.
5489 (x_fill_property_data): Use cons_to_signed.
5490 Report values out of range.
5492 Check for buffer and string overflow more precisely.
5493 * buffer.h (BUF_BYTES_MAX): New macro.
5494 * lisp.h (STRING_BYTES_MAX): New macro.
5495 * alloc.c (Fmake_string):
5496 * character.c (string_escape_byte8):
5497 * coding.c (coding_alloc_by_realloc):
5498 * doprnt.c (doprnt):
5499 * editfns.c (Fformat):
5501 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5502 since they may not be the same number.
5503 * editfns.c (Finsert_char):
5504 * fileio.c (Finsert_file_contents):
5505 Likewise for BUF_BYTES_MAX.
5507 * image.c: Use ptrdiff_t, not int, for sizes.
5508 (slurp_file): Switch from int to ptrdiff_t.
5510 (slurp_file): Check that file size fits in both size_t (for
5511 malloc) and ptrdiff_t (for sanity and safety).
5513 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5514 if b->modtime has its maximal value.
5516 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5518 Don't assume time_t can fit into int.
5519 * buffer.h (struct buffer.modtime): Now time_t, not int.
5520 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5521 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5523 Minor fixes for signed vs unsigned integers.
5524 * character.h (MAYBE_UNIFY_CHAR):
5525 * charset.c (maybe_unify_char):
5526 * keyboard.c (read_char, reorder_modifiers):
5527 XINT -> XFASTINT, since the integer must be nonnegative.
5528 * ftfont.c (ftfont_spec_pattern):
5529 * keymap.c (access_keymap, silly_event_symbol_error):
5530 XUINT -> XFASTINT, since the integer must be nonnegative.
5531 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5532 since it makes no difference and we prefer signed.
5533 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5534 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5537 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5539 * window.h (Fwindow_frame): Declare.
5541 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5543 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5544 (SPARE_MEMORY): Always define.
5545 (LARGE_REQUEST): Remove.
5546 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5548 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5550 * lisp.h: Move EXFUNS for Fframe_root_window,
5551 Fframe_first_window and Fset_frame_selected_window to window.h.
5553 * window.h: Move EXFUNS for Fframe_root_window,
5554 Fframe_first_window and Fset_frame_selected_window here from
5557 * frame.c (Fwindow_frame, Fframe_first_window)
5558 (Fframe_root_window, Fframe_selected_window)
5559 (Fset_frame_selected_window): Move to window.c.
5560 (Factive_minibuffer_window): Move to minibuf.c.
5561 (Fother_visible_frames_p): New function.
5563 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5565 * window.c (decode_window, decode_any_window): Move up in code.
5566 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5567 (inhibit_frame_unsplittable): Remove unused variable.
5568 (Fwindow_buffer): Move up and rewrite doc-string.
5569 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5570 (Fwindow_prev): New functions.
5571 (Fwindow_frame): Move here from frame.c. Accept any window as
5573 (Fframe_root_window, Fframe_first_window)
5574 (Fframe_selected_window): Move here from frame.c. Accept frame
5575 or arbitrary window as argument. Update doc-strings.
5576 (Fminibuffer_window): Move up in code.
5577 (Fwindow_minibuffer_p): Move up in code and simplify.
5578 (Fset_frame_selected_window): Move here from frame.c.
5580 (Fselected_window, select_window, Fselect_window): Move up in
5581 code. Minor doc-string fixes.
5583 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5585 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5586 Do not assume that spare memory exists; that assumption is valid
5587 only if SYSTEM_MALLOC.
5588 (LARGE_REQUEST): New macro, so that the issue of large requests
5589 is separated from the issue of spare memory.
5591 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5593 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5596 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5598 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5601 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5603 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5605 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5607 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5608 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5610 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5612 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5614 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5616 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5617 (x_clipboard_manager_save): Add return value.
5618 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5620 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5621 Obey Vx_select_enable_clipboard_manager. Catch errors in
5622 x_clipboard_manager_save (Bug#8779).
5623 (Vx_select_enable_clipboard_manager): New variable.
5624 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5626 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5628 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5630 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5632 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5633 in the current matrix if keep_current_p is non-zero.
5635 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5637 * bidi.c (bidi_level_of_next_char): Fix last change.
5639 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5641 Support bidi reordering of text covered by display properties.
5643 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5644 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5645 (bidi_cache_search, bidi_cache_iterator_state)
5646 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5647 (bidi_level_of_next_char, bidi_move_to_visually_next):
5648 Support character positions inside a run of characters covered by a
5650 (bidi_paragraph_init, bidi_resolve_explicit_1)
5651 (bidi_level_of_next_char): Call bidi_fetch_char and
5652 bidi_fetch_char_advance instead of FETCH_CHAR and
5654 (bidi_init_it): Initialize new members.
5655 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5657 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5658 instead of using explicit *_CHAR codes.
5659 (bidi_resolve_explicit, bidi_resolve_weak):
5660 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5661 bidirectional text is supported only in multibyte buffers.
5662 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5663 it to initialize the frame_window_p member of struct bidi_it.
5664 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5665 (bidi_resolve_explicit, bidi_resolve_weak)
5666 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5667 bidi_it->nchars is non-positive.
5668 (bidi_level_of_next_char): Don't try to lookup the cache for the
5669 next/previous character if nothing is cached there yet, or if we
5670 were just reseat()'ed to a new position.
5672 * xdisp.c (set_cursor_from_row): Set start and stop points
5673 according to the row's direction when priming the loop that looks
5674 for the glyph on which to display cursor.
5675 (single_display_spec_intangible_p): Function deleted.
5676 (display_prop_intangible_p): Reimplement to call
5677 handle_display_spec instead of single_display_spec_intangible_p.
5678 Accept 3 additional arguments needed by handle_display_spec.
5679 This fixes incorrect cursor motion across display property with complex
5680 values: lists, `(when COND...)' forms, etc.
5681 (single_display_spec_string_p): Support property values that are
5682 lists with the argument STRING its top-level element.
5683 (display_prop_string_p): Fix the condition for processing a
5684 property that is a list to be consistent with handle_display_spec.
5685 (handle_display_spec): New function, refactored from the
5686 last portion of handle_display_prop.
5687 (compute_display_string_pos): Accept additional argument
5688 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5689 value of a `display' property is a "replacing spec".
5690 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5691 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5692 the display property, but just return a value indicating whether
5693 the display property will replace the characters it covers.
5694 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5695 frame_window_p members of struct bidi_it.
5696 (compute_display_string_pos, compute_display_string_end):
5698 (push_it): Accept second argument POSITION, where pop_it should
5699 jump to continue iteration.
5700 (reseat_1): Initialize bidi_it.disp_pos.
5702 * keyboard.c (adjust_point_for_property): Adjust the call to
5703 display_prop_intangible_p to its new signature.
5705 * dispextern.h (struct bidi_it): New member frame_window_p.
5706 (bidi_init_it): Update prototypes.
5707 (display_prop_intangible_p): Update prototype.
5708 (compute_display_string_pos, compute_display_string_end):
5710 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5713 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5715 Malloc failure behavior now depends on size of allocation.
5716 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5717 * lisp.h: Change signatures accordingly.
5718 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5719 All callers changed. (Bug#8762)
5721 * gnutls.c: Use Emacs's memory allocators.
5722 Without this change, the gnutls library would invoke malloc etc.
5723 directly, which causes problems on non-SYNC_INPUT hosts, and which
5724 runs afoul of improving memory_full behavior. (Bug#8761)
5725 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5726 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5727 xfree instead of the default malloc, realloc, free.
5728 (Fgnutls_boot): No need to check for memory allocation failure,
5729 since xmalloc does that for us.
5731 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5732 * category.c (hash_get_category_set):
5733 * ccl.c (ccl_driver):
5734 * charset.c (Fdefine_charset_internal):
5735 * charset.h (struct charset.hash_index):
5736 * composite.c (get_composition_id, gstring_lookup_cache)
5737 (composition_gstring_put_cache):
5738 * composite.h (struct composition.hash_index):
5739 * dispextern.h (struct image.hash):
5740 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5741 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5742 (hashfn_equal, hashfn_user_defined, make_hash_table)
5743 (maybe_resize_hash_table, hash_lookup, hash_put)
5744 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5745 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5746 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5747 * image.c (make_image, search_image_cache, lookup_image)
5748 (xpm_put_color_table_h):
5749 * lisp.h (struct Lisp_Hash_Table):
5750 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5751 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5752 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5753 * alloc.c (allocate_vectorlike):
5754 Check for overflow in vector size calculations.
5755 * ccl.c (ccl_driver):
5756 Check for overflow when converting EMACS_INT to int.
5757 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5758 need to be updated by these changes.
5759 * fns.c (make_hash_table, maybe_resize_hash_table):
5760 Check for integer overflow with large hash tables.
5761 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5762 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5763 (SXHASH_REDUCE): New macro.
5764 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5765 Use it instead of discarding useful hash info with large hash values.
5766 (sxhash_float): New function.
5767 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5768 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5769 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5770 Rewrite to use FIXNUM_BITS, as this simplifies things.
5771 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5772 Adjust signatures to match updated version of code.
5773 (consing_since_gc): Now EMACS_INT, since a single hash table can
5774 use more than INT_MAX bytes.
5776 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5778 Make it possible to build with GCC-4.6+ -O2 -flto.
5780 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5782 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5784 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5785 Call minibuffer-inactive-mode.
5787 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5789 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5790 Update dependencies.
5792 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5794 * data.c (init_data): Remove code for UTS, this system is not
5797 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5799 Don't force ./temacs to start in terminal mode.
5801 * frame.c (make_initial_frame): Initialize faces in all cases, not
5802 only when CANNOT_DUMP is defined.
5803 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5805 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5807 * dispnew.c (add_window_display_history): Use const for the string
5808 pointer. Remove declaration, not needed.
5810 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5812 Use 'inline', not 'INLINE'.
5813 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5814 * alloc.c, fontset.c (INLINE): Remove.
5815 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5816 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5817 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5818 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5819 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5821 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5823 Make it possible to run ./temacs.
5825 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5826 syms_of_callproc does the same thing. Remove test for
5827 "initialized", do it in the caller.
5828 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5830 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5832 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5833 (read_minibuf): Use get_minibuffer.
5834 (syms_of_minibuf): Use DEFSYM.
5835 (Qmetadata): New var.
5836 * data.c (Qbuffer): Don't make it static.
5837 (syms_of_data): Use DEFSYM.
5839 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5841 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5842 (CCL_CODE_MIN): New macro.
5844 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5846 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5848 * eval.c (Qdebug): Now static.
5849 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5850 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5851 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5853 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5855 * image.c: Various fixes to ImageMagick code comments.
5856 (Fimagemagick_types): Doc fix.
5858 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5860 Minor fixes prompted by GCC 4.6.0 warnings.
5862 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5864 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5865 (x_clipboard_manager_save_all): Move extern decl to ...
5866 * xterm.h: ... here, so that it can be checked for consistency.
5868 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5870 * xselect.c (x_clipboard_manager_save_frame)
5871 (x_clipboard_manager_save_all): New functions.
5872 (Fx_clipboard_manager_save): Lisp function deleted.
5874 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5875 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5877 * xterm.h: Update prototype.
5879 2011-05-28 William Xu <william.xwl@gmail.com>
5881 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5884 2011-05-28 Jim Meyering <meyering@redhat.com>
5886 Avoid a sign-extension bug in crypto_hash_function.
5887 * fns.c (to_uchar): Define.
5888 (crypto_hash_function): Use it to convert some newly-signed
5889 variables to unsigned, to avoid sign-extension bugs. For example,
5890 without this change, (md5 "truc") would evaluate to
5891 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5892 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5893 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5895 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5897 Integer overflow fixes.
5899 * dbusbind.c: Serial number integer overflow fixes.
5900 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5901 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5902 to hold a serial number that is too large for a fixnum.
5903 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5904 Check for serial numbers out of range. Decode any serial number
5905 that was so large that it became a float. (Bug#8722)
5907 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5908 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5909 Use XFASTINT rather than XUINT when numbers are nonnegative.
5910 (xd_append_arg, Fdbus_method_return_internal):
5911 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5912 arguments, check that Lisp number is nonnegative, rather than
5913 silently wrapping negative numbers around. (Bug#8722)
5914 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5917 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5919 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5921 ccl: Add integer overflow checks.
5922 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5923 (IN_INT_RANGE): New macros.
5924 (ccl_driver): Use them to check for integer overflow when
5925 decoding a CCL program. Many of the new checks are whether XINT (x)
5926 fits in int; it doesn't always, on 64-bit hosts. The new version
5927 doesn't catch all possible integer overflows, but it's an
5928 improvement. (Bug#8719)
5930 * alloc.c (make_event_array): Use XINT, not XUINT.
5931 There's no need for unsigned here.
5933 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5934 This follows up to the 2011-05-06 change that substituted uintptr_t
5935 for EMACS_INT. This case wasn't caught back then.
5937 Rework Fformat to avoid integer overflow issues.
5938 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5939 now (part of C89). Include <verify.h>.
5940 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5941 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5942 (Fformat): Avoid the prepass trying to compute sizes; it was only
5943 approximate and thus did not catch overflow reliably. Instead, walk
5944 through the format just once, formatting and computing sizes as we go,
5945 checking for integer overflow at every step, and allocating a larger
5946 buffer as needed. Keep track separately whether the format is
5947 multibyte. Keep only the most-recently calculated precision, rather
5948 than them all. Record whether each argument has been converted to
5949 string. Use EMACS_INT, not int, for byte and char and arg counts.
5950 Support field widths and precisions larger than INT_MAX. Avoid
5951 sprintf's undefined behavior with conversion specifications such as %#d
5952 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5953 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5954 formatting out-of-range floating point numbers with int
5957 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5959 * data.c: Avoid integer truncation in expressions involving floats.
5960 * data.c: Include <intprops.h>.
5961 (arith_driver): When there's an integer overflow in an expression
5962 involving floating point, convert the integers to floating point
5963 so that the resulting value does not suffer from catastrophic
5964 integer truncation. For example, on a 64-bit host (* 4
5965 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5966 Do not rely on undefined behavior after integer overflow.
5968 merge count_size_as_multibyte, parse_str_to_multibyte
5969 * character.c, character.h (count_size_as_multibyte):
5970 Rename from parse_str_to_multibyte; all uses changed.
5971 Check for integer overflow.
5972 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5973 since it's now a duplicate of the other. This is more of
5974 a character than a buffer op, so better that it's in character.c.
5975 * fns.c, print.c: Adjust to above changes.
5977 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5979 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5981 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5983 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5984 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5985 (x_clipboard_manager_save): Now static.
5986 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5988 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5989 (crypto_hash_function): Now static.
5990 Fix pointer signedness problems. Avoid unnecessary initializations.
5992 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5994 * termhooks.h (Vselection_alist): Make it terminal-local.
5996 * terminal.c (create_terminal): Initialize it.
5998 * xselect.c: Support for clipboard managers.
5999 (Vselection_alist): Move to termhooks.h as terminal-local var.
6000 (LOCAL_SELECTION): New macro.
6001 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6002 (symbol_to_x_atom): Remove gratuitous arg.
6003 (x_handle_selection_request, lisp_data_to_selection_data)
6004 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6005 (x_own_selection, x_get_local_selection, x_convert_selection):
6006 New arg, specifying work frame. Use terminal-local Vselection_alist.
6007 (some_frame_on_display): Delete unused function.
6008 (Fx_own_selection_internal, Fx_get_selection_internal)
6009 (Fx_disown_selection_internal, Fx_selection_owner_p)
6010 (Fx_selection_exists_p): New optional frame arg.
6011 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6012 (x_handle_selection_clear): Don't treat other terminals with the
6013 same keyboard specially. Use the terminal-local Vselection_alist.
6014 (x_clear_frame_selections): Use Frun_hook_with_args.
6016 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6018 * xterm.h: Add support for those atoms.
6020 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6022 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6023 (converted_selections, conversion_fail_tag): New global variables.
6024 (x_selection_request_lisp_error): Free the above.
6025 (x_get_local_selection): Remove unnecessary code.
6026 (x_reply_selection_request): Args changed; handle arbitrary array
6027 of converted selections stored in converted_selections.
6028 Separate the XChangeProperty and SelectionNotify steps.
6029 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6030 (x_convert_selection): New function.
6031 (x_handle_selection_event): Simplify.
6032 (x_get_foreign_selection): Don't ignore incoming requests while
6033 waiting for an answer; this will fail when we implement
6034 SAVE_TARGETS, and seems unnecessary anyway.
6035 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6036 (Vx_sent_selection_functions): Doc fix.
6038 2011-05-26 Leo Liu <sdl.web@gmail.com>
6040 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6042 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6044 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6046 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6047 for fringe update if it has periodic bitmap.
6048 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6049 and fringe_bitmap_periodic_p.
6051 * fringe.c (get_fringe_bitmap_data): New function.
6052 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6053 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6054 row. Mark glyph row for fringe update if periodicity changed.
6056 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6057 for fringe update unless it has periodic bitmap.
6059 2011-05-25 Kenichi Handa <handa@m17n.org>
6061 * xdisp.c (get_next_display_element): Set correct it->face_id for
6062 a static composition.
6064 2011-05-24 Leo Liu <sdl.web@gmail.com>
6067 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6069 * fns.c (crypto_hash_function, Fsha1): New function.
6070 (Fmd5): Use crypto_hash_function.
6071 (syms_of_fns): Add Ssha1.
6073 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6075 * gnutls.c: Remove unused macros.
6076 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6077 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6078 Remove macros that are defined and never used.
6079 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6081 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6083 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6084 (Fx_get_selection_internal): Minor cleanup.
6085 (Fx_own_selection_internal): Rename arguments for consistency with
6088 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6090 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6092 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6094 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6096 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6098 * dispnew.c (scrolling_window): Don't exclude the case that the
6099 last enabled row in the desired matrix touches the bottom boundary.
6101 2011-05-21 Glenn Morris <rgm@gnu.org>
6103 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6104 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6105 and add some more files.
6107 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6109 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6110 report_file_error introduced by the change from 2011-05-07.
6112 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6114 * systime.h (Time): Define only if emacs is defined.
6115 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6116 where the include path doesn't have X11/X.h by default. See
6117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6119 2011-05-20 Kenichi Handa <handa@m17n.org>
6121 * composite.c (find_automatic_composition): Fix previous change.
6123 2011-05-20 Glenn Morris <rgm@gnu.org>
6125 * lisp.mk: New file, split from Makefile.in.
6126 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6127 (shortlisp): Remove.
6128 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6130 2011-05-19 Glenn Morris <rgm@gnu.org>
6132 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6133 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6134 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6135 (lisp): Set the order to that of loadup.el.
6136 (shortlisp): Make it a copy of $lisp.
6137 (SOME_MACHINE_LISP): Remove.
6138 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6139 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6141 2011-05-18 Kenichi Handa <handa@m17n.org>
6143 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6144 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6145 (find_automatic_composition): Mostly rewrite for efficiency.
6147 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6149 * makefile.w32-in: Update dependencies.
6151 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6153 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6154 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6156 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6158 Fix some integer overflow issues, such as string length overflow.
6160 * insdel.c (count_size_as_multibyte): Check for string overflow.
6162 * character.c (lisp_string_width): Check for string overflow.
6163 Use EMACS_INT, not int, for string indexes and lengths; in
6164 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6165 the resulting string length overflows an EMACS_INT; instead,
6166 report a string overflow if no precision given. When checking for
6167 precision exhaustion, use a check that cannot possibly have
6168 integer overflow. (Bug#8675)
6169 * character.h (lisp_string_width): Adjust to new signature.
6171 * alloc.c (string_overflow): New function.
6172 (Fmake_string): Use it. This doesn't change behavior, but saves
6173 a few bytes and will simplify future changes.
6174 * character.c (string_escape_byte8): Likewise.
6175 * lisp.h (string_overflow): New decl.
6177 Fixups, following up to the user-interface timestamp change.
6178 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6179 for UI timestamps, instead of unsigned long.
6180 * msdos.c (mouse_get_pos): Likewise.
6181 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6182 * w32gui.h (Time): Define by including "systime.h" rather than by
6183 declaring it ourselves. (Bug#8664)
6185 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6186 * image.c (clear_image_cache): Likewise.
6188 * term.c (term_mouse_position): Don't assume time_t wraparound.
6190 Be more systematic about user-interface timestamps.
6191 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6192 and sometimes 'EMACS_UINT', to represent these timestamps.
6193 This change causes it to use 'Time' uniformly, as that's what X uses.
6194 This makes the code easier to follow, and makes it easier to catch
6195 integer overflow bugs such as Bug#8664.
6196 * frame.c (Fmouse_position, Fmouse_pixel_position):
6197 Use Time, not unsigned long, for user-interface timestamps.
6198 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6199 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6200 * keyboard.h (last_event_timestamp): Likewise.
6201 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6202 * menu.h (xmenu_show): Likewise.
6203 * term.c (term_mouse_position): Likewise.
6204 * termhooks.h (struct input_event.timestamp): Likewise.
6205 (struct terminal.mouse_position_hook): Likewise.
6206 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6207 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6208 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6209 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6211 * menu.h, termhooks.h: Include "systime.h", for Time.
6213 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6214 Don't assume that the difference between two unsigned long values
6215 can fit into an integer. At this point, we know button_down_time
6216 <= event->timestamp, so the difference must be nonnegative, so
6217 there's no need to cast the result if double-click-time is
6218 nonnegative, as it should be; check that it's nonnegative, just in
6219 case. This bug is triggered when events are more than 2**31 ms
6220 apart (about 25 days). (Bug#8664)
6222 * xselect.c (last_event_timestamp): Remove duplicate decl.
6223 (x_own_selection): Remove needless cast to unsigned long.
6225 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6226 that always fit in int. Use a sentinel instead of a counter, to
6227 avoid a temp and to allay GCC's concerns about possible int overflow.
6228 * frame.h (struct frame): Use int for menu_bar_items_used
6229 instead of EMACS_INT, since it always fits in int.
6231 * menu.c (grow_menu_items): Check for int overflow.
6233 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6235 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6236 Before, the code was not consistent. These values cannot exceed
6237 2**31 - 1 so there's no need to make them unsigned.
6238 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6239 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6240 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6242 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6244 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6245 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6246 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6247 presumably because the widths might not match.
6249 * window.c (size_window): Avoid needless test at loop start.
6251 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6253 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6255 2011-05-12 Drew Adams <drew.adams@oracle.com>
6257 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6259 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6261 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6262 `width' to `bar_area_x' and `bar_area_width', respectively.
6263 (x_scroll_run): Take account of fringe background extension.
6265 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6266 Rename local vars `left' and `width' to `bar_area_x' and
6267 `bar_area_width', respectively.
6268 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6269 background extension.
6271 2011-05-10 Jim Meyering <meyering@redhat.com>
6273 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6275 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6277 * image.c (Finit_image_library): Return t for built-in image types,
6278 like pbm and xbm. (Bug#8640)
6280 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6282 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6284 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6286 * w32console.c (Fset_screen_color): Doc fix.
6287 (Fget_screen_color): New function.
6288 (syms_of_ntterm): Defsubr it.
6290 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6291 unlink the temporary file if Fcall_process didn't create it in the
6293 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6294 child process will be redirected to a file specified with `:file'.
6295 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6296 cue to call_process_cleanup not to close that handle.
6298 2011-05-07 Ben Key <bkey76@gmail.com>
6300 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6301 one of two shell specific rules, either bootstrap-temacs-CMD or
6302 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6303 to the previous implementation of the bootstrap-temacs rule.
6304 The bootstrap-temacs-CMD rule is similar to the previous
6305 implementation of the bootstrap-temacs rule except that it
6306 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6309 These changes, along with some changes to nt/configure.bat,
6310 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6311 earlier fix to add support for --cflags and --ldflags options
6312 that include quotes so that it works whether make uses cmd or
6315 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6317 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6318 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6320 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6321 a string. Handle both cases.
6322 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6323 (Fdbus_register_method): Use Qinvalid_function.
6325 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6327 * makefile.w32-in: Update dependencies.
6328 (LISP_H): Add inttypes.h and stdin.h.
6329 (PROCESS_H): Add unistd.h.
6331 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6333 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6334 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6336 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6338 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6340 * term.c (vfatal): Remove stray call to va_end.
6341 It's not needed and the C Standard doesn't allow it here anyway.
6343 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6344 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6346 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6349 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6351 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6353 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6355 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6357 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6359 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6360 * charset.c (Fdefine_charset_internal): Don't initialize
6361 charset.code_space[15]. The value was garbage, on hosts with
6362 32-bit int (Bug#8600).
6364 * lread.c (read_integer): Be more consistent with string-to-number.
6365 Use string_to_number to do the actual conversion; this avoids
6366 rounding errors and fixes some other screwups. Without this fix,
6367 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6368 (digit_to_number): Move earlier, for benefit of read_integer.
6369 Return -1 if the digit is out of range for the base, -2 if it is
6370 not a digit in any supported base. (Bug#8602)
6372 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6374 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6375 to match comment at start of function. This also removes a
6376 GCC warning about overflow in a 32+64-bit port.
6378 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6380 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6381 Reported by Stefan Monnier in
6382 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6383 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6384 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6386 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6387 (EMACS_UINTPTR): Likewise, with uintptr_t.
6389 * lisp.h: Prefer 64-bit EMACS_INT if available.
6390 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6391 on 32-bit hosts that have 64-bit int, so that they can access
6393 However, temporarily disable this change unless the temporary
6394 symbol WIDE_EMACS_INT is defined.
6396 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6398 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6399 This removes an assumption that EMACS_INT and long are the same
6400 width as pointers. The assumption is true for Emacs porting targets
6401 now, but we want to make other targets possible.
6402 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6403 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6404 In the rest of the code, change types of integers that hold casted
6405 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6406 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6407 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6408 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6409 No need to cast type when ORing.
6410 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6411 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6412 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6413 assume EMACS_INT is the same width as char *.
6414 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6415 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6416 Remove no-longer-needed casts.
6417 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6418 (xg_tool_bar_help_callback, xg_make_tool_item):
6419 Use EMACS_INTPTR to hold an integer
6420 that will be cast to void *; this can avoid a GCC warning
6421 if EMACS_INT is not the same width as void *.
6422 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6423 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6424 (current_message_1, set_message_1):
6425 Use a local to convert to proper width without a cast.
6426 * xmenu.c (dialog_selection_callback): Likewise.
6428 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6429 Also, don't assume VALBITS / RAND_BITS is less than 5,
6430 and don't rely on undefined behavior when shifting a 1 left into
6432 * lisp.h (get_random): Change signature to match.
6434 * lread.c (hash_string): Use size_t, not int, for hash computation.
6435 Normally we prefer signed values; but hashing is special, because
6436 it's better to use unsigned division on hash table sizes so that
6437 the remainder is nonnegative. Also, size_t is the natural width
6438 for hashing into memory. The previous code used 'int', which doesn't
6439 retain enough info to hash well into very large tables.
6440 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6442 * dbusbind.c: Don't possibly lose pointer info when converting.
6443 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6444 Use XPNTR rather than XHASH, so that the high-order bits of
6445 the pointer aren't lost when converting through void *.
6447 * eval.c (Fautoload): Don't double-shift a pointer.
6449 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6451 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6453 * gnutls.c (DEF_GNUTLS_FN):
6454 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6456 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6458 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6461 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6463 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6464 New version that can reserve upto 2GB of heap space.
6466 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6468 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6470 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6472 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6473 `gnutls_certificate_set_x509_key_file'.
6475 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6477 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6478 Update dependencies.
6480 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6482 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6483 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6484 Remove unused parameter `fildes'.
6485 * process.c (read_process_output, send_process): Don't pass it.
6487 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6489 Fix previous change: the library cache is defined in w32.c.
6490 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6491 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6493 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6495 Implement dynamic loading of GnuTLS on Windows.
6497 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6498 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6499 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6502 * gnutls.c (Qgnutls_dll): Define.
6503 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6504 (gnutls_*): Declare function pointers.
6505 (init_gnutls_functions): New function to initialize function pointers.
6506 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6507 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6508 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6509 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6510 (emacs_gnutls_write, emacs_gnutls_read)
6511 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6512 (Fgnutls_available_p): New function.
6513 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6514 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6515 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6517 * image.c: Include w32.h.
6518 (Vimage_type_cache): Delete.
6519 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6520 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6521 (w32_delayed_load): Move to w32.c.
6523 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6525 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6526 (w32_delayed_load): Move from image.c. When loading a library, record
6527 its filename in the :loaded-from property of the library id.
6528 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6529 Initialize and staticpro them.
6530 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6532 * process.c: Include lisp.h before w32.h, not after.
6533 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6534 instead of gnutls_record_check_pending.
6536 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6538 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6540 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6541 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6544 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6546 * xterm.c (x_set_frame_alpha): Do not set property on anything
6547 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6549 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6551 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6553 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6555 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6556 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6557 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6558 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6559 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6560 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6561 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6562 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6563 (Qgnutls_bootprop_callbacks_verify): Make static.
6565 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6567 * callproc.c: Indentation fixup.
6569 * sysdep.c (wait_for_termination_1): Make static.
6570 (wait_for_termination, interruptible_wait_for_termination):
6571 Move after wait_for_termination_1.
6573 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6575 * sysdep.c (interruptible_wait_for_termination): New function
6576 which is like wait_for_termination, but allows keyboard
6579 * callproc.c (Fcall_process): Add (:file "file") as an option for
6581 (Fcall_process_region): Ditto.
6583 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6585 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6586 rather than `XVECTOR (FOO)->size'.
6588 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6589 inttypes.h, as a gnulib replacement is used if it not available in
6592 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6594 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6595 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6596 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6598 * coding.c (coding_alloc_by_realloc): Error out if destination
6599 will grow beyond MOST_POSITIVE_FIXNUM.
6600 (decode_coding_emacs_mule): Abort if there isn't enough place in
6601 charbuf for the composition carryover bytes. Reserve an extra
6602 space for up to 2 characters produced in a loop.
6603 (decode_coding_iso_2022): Abort if there isn't enough place in
6604 charbuf for the composition carryover bytes.
6606 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6608 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6609 aborting when %lld or %lll format is passed.
6610 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6611 %llo or %llx format is passed. (Bug#8545)
6613 * window.c (window_scroll_line_based): Use a marker instead of
6614 simple variables to record original value of point. (Bug#7952)
6616 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6617 produced by %s or %c overflows available buffer space. (Bug#8545)
6619 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6621 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6622 (SIZE_MAX): Move defn after all includes, as they might #define it.
6624 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6626 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6628 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6630 * keyboard.c (Qdelayed_warnings_hook): Define.
6631 (command_loop_1): Run `delayed-warnings-hook'
6632 if Vdelayed_warnings_list is non-nil.
6633 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6634 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6636 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6638 * doprnt.c (doprnt): Don't return value smaller than the buffer
6639 size if the message was truncated. (Bug#8545).
6641 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6643 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6644 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6646 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6648 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6650 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6652 * makefile.w32-in: Update dependencies.
6654 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6656 Improve `doprnt' and its usage. (Bug#8545)
6657 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6658 `format_end'. Remove support for %l as a conversion specifier.
6659 Don't use xrealloc. Improve diagnostics when the %l size modifier
6660 is used. Update the commentary.
6662 * eval.c (verror): Simplify calculation of size_t.
6664 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6667 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6669 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6672 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6674 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6675 This makes this file independent of the recent pseudovector change.
6677 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6679 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6681 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6682 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6683 Remove unused local.
6684 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6686 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6687 GCC 4.6.0 optimizes based on type-based alias analysis.
6688 For example, if b is of type struct buffer * and v of type struct
6689 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6690 != &v->size, and therefore "v->size = 1; b->size = 2; return
6691 v->size;" must therefore return 1. This assumption is incorrect
6692 for Emacs, since it type-puns struct Lisp_Vector * with many other
6693 types. To fix this problem, this patch adds a new type struct
6694 vectorlike_header that documents the constraints on layout of vectors
6695 and pseudovectors, and helps optimizing compilers not get fooled
6696 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6697 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6698 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6700 (XSETPVECTYPE): Rewrite in terms of new macro.
6701 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6702 This is a bit clearer, and further avoids the possibility of
6703 undesirable aliasing.
6704 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6705 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6706 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6707 since Lisp_Subr is a special case (no "next" field).
6708 (ASIZE): Now uses header.size rather than size.
6709 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6710 to avoid the hassle of writing XVECTOR (foo)->header.size.
6711 (struct vectorlike_header): New type.
6712 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6713 object, to help avoid aliasing.
6714 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6715 (SUBRP): Likewise, since Lisp_Subr is a special case.
6716 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6717 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6718 (struct Lisp_Hash_Table): Combine first two members into a single
6719 struct vectorlike_header member. All uses of "size" and "next" members
6720 changed to be "header.size" and "header.next".
6721 * buffer.h (struct buffer): Likewise.
6722 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6723 * frame.h (struct frame): Likewise.
6724 * process.h (struct Lisp_Process): Likewise.
6725 * termhooks.h (struct terminal): Likewise.
6726 * window.c (struct save_window_data, struct saved_window): Likewise.
6727 * window.h (struct window): Likewise.
6728 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6729 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6730 * buffer.c (init_buffer_once): Likewise.
6731 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6733 * process.c (Fformat_network_address): Use local var for size,
6736 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6738 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6739 * data.c (atof): Remove decl; no longer used or needed.
6740 (digit_to_number): Move to lread.c.
6741 (Fstring_to_number): Use new string_to_number function, to be
6742 consistent with how the Lisp reader treats infinities and NaNs.
6743 Do not assume that floating-point numbers represent EMACS_INT
6744 without losing information; this is not true on most 64-bit hosts.
6745 Avoid double-rounding errors, by insisting on integers when
6746 parsing non-base-10 numbers, as the documentation specifies.
6747 * lisp.h (string_to_number): New decl, replacing ...
6748 (isfloat_string): Remove.
6749 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6750 (read1): Do not accept +. and -. as integers; this
6751 appears to have been a coding error. Similarly, do not accept
6752 strings like +-1e0 as floating point numbers. Do not report
6753 overflow for integer overflows unless the base is not 10 which
6754 means we have no simple and reliable way to continue.
6755 Break out the floating-point parsing into a new
6756 function string_to_number, so that Fstring_to_number parses
6757 floating point numbers consistently with the Lisp reader.
6758 (digit_to_number): Move here from data.c. Make it static inline.
6759 (E_CHAR, EXP_INT): Remove, replacing with ...
6760 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6761 (string_to_number): New function, replacing isfloat_string.
6762 This function checks for valid syntax and produces the resulting
6763 Lisp float number too. Rework it so that string-to-number
6764 no longer mishandles examples like "1.0e+". Use strtoumax,
6765 so that overflow for non-base-10 numbers is reported only when
6766 there's no portable and simple way to convert to floating point.
6768 * textprop.c (set_text_properties_1): Rewrite for clarity,
6769 and to avoid GCC warning about integer overflow.
6771 * intervals.h (struct interval): Use EMACS_INT for members
6772 where EMACS_UINT might cause problems. See
6773 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6774 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6775 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6777 (offset_intervals): Tell GCC not to worry about length overflow
6778 when negating a negative length.
6780 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6781 (overrun_check_free): Likewise.
6783 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6784 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6787 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6788 (gnutls_make_error): Rename local to avoid shadowing.
6789 (gnutls_emacs_global_deinit): ifdef out; not used.
6790 (Fgnutls_boot): Use const for pointer to readonly storage.
6791 Comment out unused local. Fix pointer signedness problems.
6793 * lread.c (openp): Don't stuff size_t into an 'int'.
6794 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6795 about possible signed overflow.
6797 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6798 (GDK_KEY_g): Don't define if already defined.
6799 (xg_prepare_tooltip): Avoid pointer signedness problem.
6800 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6802 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6803 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6805 * xfns.c (Fx_window_property): Simplify a bit,
6806 to make a bit faster and to avoid GCC 4.6.0 warning.
6807 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6809 * fns.c (internal_equal): Don't assume size_t fits in int.
6811 * alloc.c (compact_small_strings): Tighten assertion a little.
6813 Replace pEd with more-general pI, and fix some printf arg casts.
6814 * lisp.h (pI): New macro, generalizing old pEd macro to other
6815 conversion specifiers. For example, use "...%"pI"d..." rather
6816 than "...%"pEd"...".
6817 (pEd): Remove. All uses replaced with similar uses of pI.
6818 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6819 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6820 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6821 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6822 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6823 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6824 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6826 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6827 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6828 * print.c (safe_debug_print, print_object): Likewise.
6829 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6831 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6832 avoiding the 0 flag, which is not portable.
6833 * process.c (Fmake_network_process): Use pI to avoid cast.
6834 * region-cache.c (pp_cache): Likewise.
6835 * xdisp.c (decode_mode_spec): Likewise.
6836 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6837 behavior on 64-bit hosts with printf arg.
6838 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6839 (x_stop_queuing_selection_requests): Likewise.
6840 (x_get_window_property): Don't truncate byte count to an 'int'
6843 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6844 here, since it parses constructs like leading '-' and spaces,
6845 which are not wanted; and it overflows with large numbers.
6846 Instead, simply match F[0-9]+, which is what is wanted anyway.
6848 * alloc.c: Remove unportable assumptions about struct layout.
6849 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6850 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6851 (allocate_vectorlike, make_pure_vector): Use the new macros,
6852 plus offsetof, to remove unportable assumptions about struct layout.
6853 These assumptions hold on all porting targets that I know of, but
6854 they are not guaranteed, they're easy to remove, and removing them
6855 makes further changes easier.
6857 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6858 This doesn't fix a bug but makes the code clearer.
6859 (string_overrun_cookie): Now const. Use initializers that
6860 don't formally overflow signed char, to avoid warnings.
6861 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6862 can cause Emacs to crash when string overrun checking is enabled.
6863 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6864 multiple of sizeof (EMACS_INT); it need not be, if
6865 alignof(EMACS_INT) < sizeof (EMACS_INT).
6866 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6868 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6870 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6872 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6874 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6875 supposed to be handshaking. (Bug#8556)
6876 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6878 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6880 * lisp.h (Qdebug): List symbol.
6881 * eval.c (Qdebug): Restore global linkage.
6882 * keyboard.c (debug-on-event): New variable.
6883 (handle_user_signal): Break into debugger when debug-on-event
6884 matches the current signal symbol.
6886 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6888 * alloc.c (check_sblock, check_string_bytes)
6889 (check_string_free_list): Convert to standard C.
6891 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6893 * w32.c (emacs_gnutls_push): Fix typo.
6895 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6897 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6898 "cast to pointer from integer of different size".
6900 Improve doprnt and its use in verror. (Bug#8545)
6901 * doprnt.c (doprnt): Document the set of format control sequences
6902 supported by the function. Use SAFE_ALLOCA instead of always
6905 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6906 is one byte too soon. Don't use xrealloc; instead xfree and
6909 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6911 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6914 * gnutls.c: Renamed global_initialized to
6915 gnutls_global_initialized. Added internals for the
6916 :verify-hostname-error, :verify-error, and :verify-flags
6917 parameters of `gnutls-boot' and documented those parameters in the
6918 docstring. Start callback support.
6919 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6920 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6921 on error. Return error code.
6922 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6923 (emacs_gnutls_read): Likewise.
6924 (Fgnutls_boot): Return handshake error code.
6925 (emacs_gnutls_handle_error): New function.
6926 (wsaerror_to_errno): Likewise.
6928 * w32.h (emacs_gnutls_pull): Add prototype.
6929 (emacs_gnutls_push): Likewise.
6931 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6932 (emacs_gnutls_push): Likewise.
6934 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6936 * process.c (wait_reading_process_output): Check if GnuTLS
6937 buffered some data internally if no FDs are set for TLS
6940 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6941 (LIBS): Link to USER_LIBS.
6942 ($(BLD)/gnutls.$(0)): New target.
6944 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6946 * xdisp.c (handle_single_display_spec): Rename the
6947 display_replaced_before_p argument into display_replaced_p, to
6948 make it consistent with the commentary. Fix typos in the
6951 * textprop.c (syms_of_textprop): Remove dead code.
6952 (copy_text_properties): Delete obsolete commentary about an
6953 interface that was deleted long ago. Fix typos in the description
6956 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6957 to changes in oldXMenu/XMenu.h from 2011-04-16.
6958 <menu_help_message, prev_menu_help_message>: Constify.
6959 (IT_menu_make_room): menu->help_text is now `const char **';
6962 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6963 to changes in oldXMenu/XMenu.h from 2011-04-16.
6964 (struct XMenu): Declare `help_text' `const char **'.
6966 * xfaces.c <Qunspecified>: Make extern again.
6968 * syntax.c: Include sys/types.h before including regex.h, as
6971 * doc.c (get_doc_string): Improve the format passed to `error'.
6973 * doprnt.c (doprnt): Improve commentary.
6975 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6977 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6980 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6981 changes in globals.h immediately force recompilation.
6982 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6983 $(CURDIR)/s/ms-w32.h.
6984 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6986 * character.c (Fchar_direction): Function deleted.
6987 (syms_of_character): Don't defsubr it.
6988 <char-direction-table>: Deleted.
6990 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6992 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6993 * doprnt.c: Include limits.h.
6994 (SIZE_MAX): New macro.
6995 (doprnt): Return a size_t value. 2nd arg is now size_t.
6996 Many local variables are now size_t instead of int or unsigned.
6997 Improve overflow protection. Support `l' modifier for integer
6998 conversions. Support %l conversion. Don't assume an EMACS_INT
6999 argument for integer conversions and for %c.
7001 * lisp.h (doprnt): Restore prototype.
7003 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7006 * Makefile.in (base_obj): Add back doprnt.o.
7008 * deps.mk (doprnt.o): Add back prerequisites.
7009 (callint.o): Depend on character.h.
7011 * eval.c (internal_lisp_condition_case): Include the handler
7012 representation in the error message.
7013 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7014 when breaking from the loop.
7016 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7018 * callint.c (Fcall_interactively): When displaying error message
7019 about invalid control letter, pass the character's codepoint, not
7020 a pointer to its multibyte form. Improve display of the character
7021 in octal and display also its hex code.
7023 * character.c (char_string): Use %x to display the (unsigned)
7024 codepoint of an invalid character, to avoid displaying a bogus
7027 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7028 `error', not SYMBOL_NAME itself.
7030 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7031 character arguments to `error'.
7033 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7034 to `error' in error message about FINAL_CHAR argument. Make sure
7035 FINAL_CHAR is a character, and use %c when it is passed as
7036 argument to `error'.
7038 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7040 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7042 * w32.c: Include <time.h>.
7043 (sys_localtime): New function.
7045 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7047 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7049 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7051 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7053 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7056 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7058 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7059 gl_state.e_property when gl_state.object is Qt.
7061 * insdel.c (make_gap_larger): Remove limitation of buffer size
7064 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7066 * xdisp.c (lookup_glyphless_char_display)
7067 (produce_glyphless_glyph): Handle cons cell entry in
7068 glyphless-char-display.
7069 (Vglyphless_char_display): Document it.
7071 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7072 glyphless-char-display.
7074 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7076 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7078 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7080 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7081 definition for no-X builds.
7083 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7085 Static checks with GCC 4.6.0 and non-default toolkits.
7087 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7089 * process.c (keyboard_bit_set): Define only if SIGIO.
7090 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7091 (send_process): Repair possible setjmp clobbering.
7093 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7095 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7097 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7099 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7100 Define only if needed.
7102 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7103 by pacifying GCC about it. Maybe it's time to retire it?
7104 * xfaces.c (USG, __TIMEVAL__): Likewise.
7106 * dispextern.h (struct redisplay_interface): Rename param
7108 * termhooks.h (struct terminal): Likewise.
7109 * xterm.c (xembed_send_message): Likewise.
7111 * insdel.c (make_gap_smaller): Define only if
7112 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7114 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7117 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7118 so that we aren't warned about unused symbols.
7120 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7122 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7124 * xfns.c (x_real_positions): Mark locals as initialized.
7126 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7128 * xterm.c: Fix problems found by static analysis with other toolkits.
7129 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7130 (x_dispatch_event): Declare static if USE_GTK, and
7131 define if USE_GTK || USE_X_TOOLKIT.
7132 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7133 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7134 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7135 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7137 * xmenu.c (menu_help_callback): Pointer type fixes.
7138 Use const pointers when pointing at readonly data. Avoid pointer
7140 (FALSE): Remove unused macro.
7141 (update_frame_menubar): Remove unused decl.
7143 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7145 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7146 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7147 (single_menu_item): Rename local to avoid shadowing.
7149 * keyboard.c (make_lispy_event): Remove unused local var.
7151 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7152 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7154 * bitmaps: Change bitmaps from unsigned char back to the X11
7155 compatible char. Avoid the old compiler warnings about
7156 out-of-range initializers by using, for example, '\xab' rather
7159 * xgselect.c (xgselect_initialize): Check vs interface
7160 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7162 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7164 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7165 to read-only memory.
7167 * fns.c (vector): Remove; this old hack is no longer needed.
7169 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7171 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7173 * xrdb.c (x_load_resources): Omit unused local.
7175 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7176 (x_window): Rename locals to avoid shadowing.
7177 (USG): Use the kludged USG macro, to pacify gcc.
7179 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7180 (x_term_init): Remove local to avoid shadowing.
7182 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7184 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7185 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7187 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7189 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7191 Fix regex.c, syntax.c and friends for buffers > 2GB.
7192 * syntax.h (struct gl_state_s): Declare character position members
7195 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7197 * textprop.c (verify_interval_modification, interval_of):
7198 Declare arguments EMACS_INT.
7200 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7203 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7205 * indent.c (Fvertical_motion): Local variable it_start is now
7208 * regex.c (re_match, re_match_2, re_match_2_internal)
7209 (bcmp_translate, regcomp, regexec, print_double_string)
7210 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7211 (re_compile_pattern, re_exec): Declare arguments and local
7212 variables `size_t' and `ssize_t' and return values `regoff_t', as
7214 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7215 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7216 <compile_stack_type>: `size' and `avail' are now `size_t'.
7218 * regex.h <regoff_t>: Use ssize_t, not int.
7219 (re_search, re_search_2, re_match, re_match_2): Arguments that
7220 specify buffer/string position and length are now ssize_t and
7221 size_t. Return type is regoff_t.
7223 2011-04-16 Ben Key <bkey76@gmail.com>
7225 * nsfont.m: Fixed bugs in ns_get_family and
7226 ns_descriptor_to_entity that were caused by using free to
7227 deallocate memory blocks that were allocated by xmalloc (via
7228 xstrdup). This caused Emacs to crash when compiled with
7229 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7230 --enable-checking=xmallocoverrun). xfree is now used to
7231 deallocate these memory blocks.
7233 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7235 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7237 emacs_write: Accept and return EMACS_INT for sizes.
7238 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7240 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7241 Accept and return EMACS_INT.
7242 (emacs_gnutls_write): Return the number of bytes written on
7244 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7245 (emacs_read, emacs_write): Remove check for negative size, as the
7246 Emacs source code has been audited now.
7247 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7248 (emacs_read, emacs_write): Use it.
7249 * process.c (send_process): Adjust to the new signatures of
7250 emacs_write and emacs_gnutls_write. Do not attempt to store
7251 a byte offset into an 'int'; it might overflow.
7252 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7254 * sound.c: Don't assume sizes fit in 'int'.
7255 (struct sound_device.period_size, alsa_period_size):
7256 Return EMACS_INT, not int.
7257 (struct sound_device.write, vox_write, alsa_write):
7258 Accept EMACS_INT, not int.
7259 (wav_play, au_play): Use EMACS_INT to store sizes and to
7260 record read return values.
7262 2011-04-15 Ben Key <bkey76@gmail.com>
7264 * keyboard.c (Qundefined): Don't declare static since it is used
7266 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7267 static since they are used in nsfont.m.
7269 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7271 * process.c (Qprocessp): Don't declare static.
7272 * lisp.h (Qprocessp): Declare again.
7274 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7276 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7278 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7280 Improve C-level modularity by making more things 'static'.
7282 Don't publish debugger-only interfaces to other modules.
7283 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7284 (verify_bytepos, count_markers): Move decls to the only modules
7286 * region-cache.h (pp_cache): Likewise.
7287 * window.h (check_all_windows): Likewise.
7288 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7290 * sysdep.c (croak): Now static, if
7291 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7292 * syssignal.h (croak): Declare only if not static.
7294 * alloc.c (refill_memory_reserve): Now static if
7295 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7296 * lisp.h (refill_memory_reserve): Declare only if not static.
7298 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7299 Define only if USE_LUCID.
7301 * xrdb.c (x_customization_string, x_rm_string): Now static.
7303 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7304 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7306 * xdisp.c (draw_row_with_mouse_face): Now static.
7307 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7309 * window.h (check_all_windows): Mark externally visible.
7311 * window.c (window_deletion_count): Now static.
7313 * undo.c: Make symbols static if they're not exported.
7314 (last_undo_buffer, last_boundary_position, pending_boundary):
7317 * textprop.c (interval_insert_behind_hooks): Now static.
7318 (interval_insert_in_front_hooks): Likewise.
7320 * term.c: Make symbols static if they're not exported.
7321 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7322 (max_frame_lines, tty_set_terminal_modes):
7323 (tty_reset_terminal_modes, tty_turn_off_highlight):
7324 (get_tty_terminal): Now static.
7325 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7326 * termhooks.h (term_mouse_moveto): Do not declare if
7328 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7329 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7331 * sysdep.c: Make symbols static if they're not exported.
7332 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7334 (sigprocmask_set, full_mask): Remove; unused.
7335 (wait_debugging): Mark as visible.
7336 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7337 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7339 * syntax.c (syntax_temp): Define only if !__GNUC__.
7341 * sound.c (current_sound_device, current_sound): Now static.
7343 * search.c (searchbufs, searchbuf_head): Now static.
7345 * scroll.c (scroll_cost): Remove; unused.
7346 * dispextern.h (scroll_cost): Remove decl.
7348 * region-cache.h (pp_cache): Mark as externally visible.
7350 * process.c: Make symbols static if they're not exported.
7351 (process_tick, update_tick, create_process, chan_process):
7352 (Vprocess_alist, proc_buffered_char, datagram_access):
7353 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7354 (deactivate_process): Mark defn as static, as well as decl.
7355 * lisp.h (create_process): Remove decl.
7356 * process.h (chan_process, Vprocess_alist): Remove decls.
7358 * print.c: Make symbols static if they're not exported.
7359 (print_depth, new_backquote_output, being_printed, print_buffer):
7360 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7361 (print_interval, print_number_index, initial_stderr_stream):
7363 * lisp.h (Fprinc): Remove decl.
7364 (debug_output_compilation_hack): Mark as externally visible.
7366 * sysdep.c (croak): Move decl from here to syssignal.h.
7367 * syssignal.h (croak): Put it here, so the API can be checked when
7368 'croak' is called from dissociate_if_controlling_tty.
7370 * minibuf.c: Make symbols static if they're not exported.
7371 (minibuf_save_list, choose_minibuf_frame): Now static.
7372 * lisp.h (choose_minibuf_frame): Remove decl.
7374 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7376 * lread.c: Make symbols static if they're not exported.
7377 (read_objects, initial_obarray, oblookup_last_bucket_number):
7379 (make_symbol): Remove; unused.
7380 * lisp.h (initial_obarray, make_symbol): Remove decls.
7382 * keyboard.c: Make symbols static if they're not exported.
7383 (single_kboard, recent_keys_index, total_keys, recent_keys):
7384 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7385 (this_single_command_key_start, echoing, last_auto_save):
7386 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7387 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7388 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7389 (Vlispy_mouse_stem, double_click_count):
7391 (force_auto_save_soon): Define only if SIGDANGER.
7392 (ignore_mouse_drag_p): Now static if
7393 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7394 (print_help): Remove; unused.
7395 (stop_character, last_timer_event): Mark as externally visible.
7396 * keyboard.h (ignore_mouse_drag_p): Declare only if
7397 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7398 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7399 * lisp.h (echoing): Remove decl.
7400 (force_auto_save_soon): Declare only if SIGDANGER.
7401 * xdisp.c (redisplay_window): Simplify code, to make it more
7402 obvious that ignore_mouse_drag_p is not accessed if !defined
7403 USE_GTK && !defined HAVE_NS.
7405 * intervals.c: Make symbols static if they're not exported.
7406 (merge_properties_sticky, merge_interval_right, delete_interval):
7408 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7410 * insdel.c: Make symbols static if they're not exported.
7411 However, leave prepare_to_modify_buffer alone. It's never
7412 called from outside this function, but that appears to be a bug.
7413 (combine_after_change_list, combine_after_change_buffer):
7414 (adjust_after_replace, signal_before_change): Now static.
7415 (adjust_after_replace_noundo): Remove; unused.
7416 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7417 (signal_before_change): Remove decls.
7419 * indent.c (val_compute_motion, val_vmotion): Now static.
7421 * image.c: Make symbols static if they're not exported.
7422 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7424 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7425 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7427 * fringe.c (standard_bitmaps): Now static.
7428 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7430 * frame.c: Make symbols static if they're not exported.
7431 (x_report_frame_params, make_terminal_frame): Now static.
7432 (get_frame_param): Now static, unless HAVE_NS.
7433 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7434 (x_get_resource_string): Remove; not used.
7435 * frame.h (make_terminal_frame, x_report_frame_params):
7436 (x_get_resource_string); Remove decls.
7437 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7438 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7440 * font.c, fontset.c: Make symbols static if they're not exported.
7441 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7442 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7443 * font.c (font_close_object): Now static.
7444 * font.h (font_close_object): Remove.
7445 * fontset.c (FONTSET_OBJLIST): Remove.
7446 (free_realized_fontset) #if-0 the body, which does nothing.
7447 (face_suitable_for_char_p): #if-0, as it's never called.
7448 * fontset.h (face_suitable_for_char_p): Remove decl.
7449 * xfaces.c (face_at_string_position):
7450 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7451 since 0 is always ASCII.
7453 * fns.c (weak_hash_tables): Now static.
7455 * fileio.c: Make symbols static if they're not exported.
7456 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7457 (Vwrite_region_annotation_buffers): Now static.
7459 * eval.c: Make symbols static if they're not exported.
7460 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7461 * lisp.h (backtrace_list): Remove decl.
7463 * emacs.c: Make symbols static if they're not exported.
7464 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7465 (fatal_error_code, fatal_error_signal_hook, standard_args):
7467 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7468 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7469 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7470 * lisp.h (fatal_error_signal_hook): Remove decl.
7471 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7473 * editfns.c: Move a (normally-unused) function to its only use.
7474 * editfns.c, lisp.h (get_operating_system_release): Remove.
7475 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7476 worth the hassle of breaking this out.
7478 * xterm.c: Make symbols static if they're not exported.
7479 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7480 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7481 (x_destroy_window, x_delete_display):
7483 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7484 (x_mouse_leave): Remove; unused.
7485 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7486 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7487 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7489 (x_mouse_leave): Declare only if WINDOWSNT.
7490 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7491 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7494 * ftxfont.c: Make symbols static if they're not exported.
7495 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7497 * font.h (ftxfont_driver): Likewise.
7499 * xfns.c: Make symbols static if they're not exported.
7500 (x_last_font_name, x_display_info_for_name):
7501 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7502 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7503 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7504 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7505 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7506 (last_show_tip_args): Now static.
7507 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7508 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7509 (x_screen_planes): Remove; unused.
7510 * dispextern.h (x_screen_planes): Remove decl.
7512 * dispnew.c: Make symbols static if they're not exported.
7513 * dispextern.h (redraw_garbaged_frames, scrolling):
7514 (increment_row_positions): Remove.
7515 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7516 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7518 (redraw_garbaged_frames): Remove; unused.
7520 * xfaces.c: Make symbols static if they're not exported.
7521 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7523 * xterm.h (defined_color): Remove decls.
7524 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7525 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7526 (menu_face_changed_default, defined_color, free_realized_face):
7527 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7528 (ascii_face_of_lisp_face): Remove; unused.
7530 * xdisp.c: Make symbols static if they're not exported.
7531 * dispextern.h (scratch_glyph_row, window_box_edges):
7532 (glyph_to_pixel_coords, set_cursor_from_row):
7533 (get_next_display_element, set_iterator_to_next):
7534 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7535 (show_mouse_face): Remove decls
7536 * frame.h (message_buf_print): Likewise.
7537 * lisp.h (pop_message, set_message, check_point_in_composition):
7539 * xterm.h (set_vertical_scroll_bar): Likewise.
7540 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7541 (message_buf_print, scratch_glyph_row, displayed_buffer):
7542 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7543 (get_next_display_element, show_mouse_face, window_box_edges):
7544 (frame_to_window_pixel_xy, check_point_in_composition):
7545 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7546 (glyph_to_pixel_coords): Remove; unused.
7548 * dired.c (file_name_completion): Now static.
7550 * dbusbind.c (xd_in_read_queued_messages): Now static.
7552 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7553 * data.c (circular_list_error): Remove.
7555 * commands.h (last_point_position, last_point_position_buffer):
7556 (last_point_position_window): Remove decls.
7557 * keyboard.c: Make these variables static.
7559 * coding.h (coding, code_convert_region, encode_coding_gap):
7561 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7562 (iso_code_class, detect_coding, code_convert_region): Now static.
7563 (encode_coding_gap): Remove; unused.
7565 * chartab.c (chartab_chars, chartab_bits): Now static.
7567 * charset.h (charset_iso_8859_1): Remove decl.
7568 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7571 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7572 * ccl.c (Vccl_program_table): Now static.
7573 (check_ccl_update): Remove; unused.
7575 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7576 * category.h: ... from here.
7577 * category.c (check_category_table, set_category_set): Now static.
7579 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7580 * lisp.h: Remove these decls.
7582 * buffer.c (buffer_count): Remove unused var.
7584 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7585 so that it's not optimized away.
7586 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7587 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7588 exported only to the debugger.
7590 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7591 * atimer.h (run_all_atimers): Remove; not exported.
7593 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7594 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7595 was inaccessible from Lisp.
7596 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7597 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7599 alloc.c: Import and export fewer symbols, and remove unused items.
7600 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7602 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7603 it's not optimized away by whole-program optimization.
7604 (message_enable_multibyte, free_misc): Remove.
7605 (catchlist, handlerlist, mark_backtrace):
7606 Declare only if BYTE_MARK_STACK.
7607 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7608 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7609 (message_enable_multibyte): Remove decl.
7610 (free_misc, interval_free_list, float_block, float_block_index):
7611 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7612 (cons_free_list, last_marked_index):
7614 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7615 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7616 (mark_backtrace): Define only if BYTE_MARK_STACK.
7617 * xdisp.c (message_enable_multibyte): Now static.
7619 Declare Lisp_Object Q* variables to be 'static' if not exported.
7620 This makes it easier for human readers (and static analyzers)
7621 to see whether these variables are used from other modules.
7622 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7623 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7624 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7625 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7626 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7627 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7628 * xmenu.c, xselect.c:
7629 Declare Q* vars static if they are not used in other modules.
7630 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7631 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7632 Remove decls of unexported vars.
7633 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7635 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7637 Make Emacs functions such as Fatom 'static' by default.
7638 This makes it easier for human readers (and static analyzers)
7639 to see whether these functions can be called from other modules.
7640 DEFUN now defines a static function. To make the function external
7641 so that it can be used in other C modules, use the new macro DEFUE.
7642 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7643 (Finit_image_library):
7644 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7645 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7646 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7647 Remove decls, since these functions are now static.
7648 (Funintern, Fget_internal_run_time): New decls, since these functions
7649 were already external.
7651 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7652 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7653 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7654 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7655 * keyboard.c, keymap.c, lread.c:
7656 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7657 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7658 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7659 Mark functions with DEFUE instead of DEFUN,
7660 if they are used in other modules.
7661 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7662 decls for now-static functions.
7663 * buffer.h (Fdelete_overlay): Remove decl.
7664 * callproc.c (Fgetenv_internal): Mark as internal.
7665 * composite.c (Fremove_list_of_text_properties): Remove decl.
7666 (Fcomposition_get_gstring): New forward static decl.
7667 * composite.h (Fcomposite_get_gstring): Remove decl.
7668 * dired.c (Ffile_attributes): New forward static decl.
7669 * doc.c (Fdocumntation_property): New forward static decl.
7670 * eval.c (Ffetch_bytecode): New forward static decl.
7671 (Funintern): Remove extern decl; now in .h file where it belongs.
7672 * fileio.c (Fmake_symbolic_link): New forward static decl.
7673 * image.c (Finit_image_library): New forward static decl.
7674 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7675 * intervals.h (Fprevious_property_change):
7676 (Fremove_list_of_text_properties): Remove decls.
7677 * keyboard.c (Fthis_command_keys): Remove decl.
7678 (Fcommand_execute): New forward static decl.
7679 * keymap.c (Flookup_key): New forward static decl.
7680 (Fcopy_keymap): Now static.
7681 * keymap.h (Flookup_key): Remove decl.
7682 * process.c (Fget_process): New forward static decl.
7683 (Fprocess_datagram_address): Mark as internal.
7684 * syntax.c (Fsyntax_table_p): New forward static decl.
7685 (skip_chars): Remove duplicate decl.
7686 * textprop.c (Fprevious_property_change): New forward static decl.
7687 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7689 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7690 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7692 * editfns.c (Fformat): Remove unreachable code.
7694 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7696 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7699 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7701 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7702 when at ZV. (Bug#8487)
7704 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7706 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7708 * keyboard.c (parse_tool_bar_item): Likewise.
7709 * sound.c (sound_cleanup, alsa_close): Likewise.
7710 * termcap.c (tgetent): Likewise.
7711 * xfns.c (x_default_font_parameter): Likewise.
7712 * xsettings.c (read_and_apply_settings): Likewise.
7714 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7715 (overrun_check_free): Protoize.
7717 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7719 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7720 since callers should never pass a negative size.
7721 Change the signature to match that of plain 'read' and 'write'; see
7722 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7723 * lisp.h: Update prototypes of emacs_write and emacs_read.
7725 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7727 * xdisp.c (redisplay_window): Don't try to determine the character
7728 position of the scroll margin if the window start point w->startp
7729 is outside the buffer's accessible region. (Bug#8468)
7731 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7733 Fix write-region and its subroutines for buffers > 2GB.
7734 * fileio.c (a_write, e_write): Modify declaration of arguments and
7735 local variables to support buffers larger than 2GB.
7736 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7738 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7739 argument, local variables, and return value.
7741 * lisp.h: Update prototypes of emacs_write and emacs_read.
7743 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7745 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7747 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7749 Fix more problems found by GCC 4.6.0's static checks.
7751 * xdisp.c (vmessage): Use a better test for character truncation.
7753 * charset.c (load_charset_map): <, not <=, for optimization,
7754 and to avoid potential problems with integer overflow.
7755 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7756 * casetab.c (set_identity, shuffle): Likewise.
7757 * editfns.c (Fformat): Likewise.
7758 * syntax.c (skip_chars): Likewise.
7760 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7761 This also lets GCC 4.6.0 generate slightly better loop code.
7763 * callint.c (Fcall_interactively): <, not <=, for optimization.
7764 (Fcall_interactively): Count the number of arguments produced,
7765 not the number of arguments given. This is simpler and lets GCC
7766 4.6.0 generate slightly better code.
7768 * ftfont.c: Distingish more carefully between FcChar8 and char.
7769 The previous code passed unsigned char * to a functions like
7770 strlen and xstrcasecmp that expect char *, which does not
7771 conform to the C standard.
7772 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7773 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7774 char * when the C standard requires it.
7776 * keyboard.c (read_char): Remove unused var.
7778 * eval.c: Port to Windows vsnprintf (Bug#8435).
7780 (SIZE_MAX): Define if the headers do not.
7781 (verror): Do not give up if vsnprintf returns a negative count.
7782 Instead, grow the buffer. This ports to Windows vsnprintf, which
7783 does not conform to C99. Problem reported by Eli Zaretskii.
7784 Also, simplify the allocation scheme, by avoiding the need for
7785 calling realloc, and removing the ALLOCATED variable.
7787 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7789 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7790 But keep the doprint source code for now, as we might revamp it
7791 and use it again (Bug#8435).
7792 * lisp.h (doprnt): Remove.
7793 * Makefile.in (base_obj): Remove doprnt.o.
7794 * deps.mk (doprnt.o): Remove.
7796 error: Print 32- and 64-bit integers portably (Bug#8435).
7797 Without this change, on typical 64-bit hosts error ("...%d...", N)
7798 was used to print both 32- and 64-bit integers N, which relied on
7800 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7801 * lisp.h (error, verror): Mark as printf-like functions.
7802 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7803 Report overflow in size calculations when allocating printf buffer.
7804 Do not truncate output string at its first null byte.
7805 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7806 Truncate the output at a character boundary, since vsnprintf does not
7808 * charset.c (check_iso_charset_parameter): Convert internal
7809 character to string before calling 'error', since %c now has the
7811 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7812 overflow when computing char to be passed to 'error'. Do not
7813 pass Lisp_Object to 'error'; pass the integer instead.
7814 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7815 formatted with plain %d.
7817 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7819 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7821 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7823 * xterm.c (x_catch_errors): Remove duplicate declaration.
7825 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7827 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7829 2011-04-10 Jim Meyering <meyering@redhat.com>
7831 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7832 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7833 return ssize_t not "int", and use size_t as the buffer length.
7834 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7835 * gnutls.h: Update declarations.
7836 * process.c (read_process_output): Use ssize_t, to match.
7837 (send_process): Likewise.
7839 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7841 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7843 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7845 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7846 Use unsigned char, to match FcChar8 type definition.
7848 * xterm.c (handle_one_xevent):
7849 * xmenu.c (create_and_show_popup_menu):
7850 * xselect.c (x_decline_selection_request)
7851 (x_reply_selection_request): Avoid type-punned deref of X events.
7853 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7855 Fix some uses of `int' instead of EMACS_INT.
7856 * search.c (string_match_1, fast_string_match)
7857 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7858 (scan_buffer, find_next_newline_no_quit)
7859 (find_before_next_newline, search_command, Freplace_match)
7860 (Fmatch_data): Make some `int' variables be EMACS_INT.
7862 * xdisp.c (display_count_lines): 3rd argument and return value now
7863 EMACS_INT. All callers changed.
7864 (pint2hrstr): Last argument is now EMACS_INT.
7866 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7867 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7868 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7869 (decode_coding_utf_16, decode_coding_emacs_mule)
7870 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7871 (decode_coding_ccl, decode_coding_charset)
7872 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7873 (decode_coding_iso_2022, decode_coding_emacs_mule)
7874 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7875 <char_offset, last_offset>: Declare EMACS_INT.
7876 (encode_coding_utf_8, encode_coding_utf_16)
7877 (encode_coding_emacs_mule, encode_invocation_designation)
7878 (encode_designation_at_bol, encode_coding_iso_2022)
7879 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7880 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7882 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7883 (encode_invocation_designation): Last argument P_NCHARS is now
7885 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7886 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7888 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7891 * ccl.c (Fccl_execute_on_string): Declare some variables
7894 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7896 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7898 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7900 * process.c (Fformat_network_address): Doc fix.
7902 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7904 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7906 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7908 * keyboard.c (read_char): Call Lisp function help-form-show,
7909 instead of using internal_with_output_to_temp_buffer.
7910 (Qhelp_form_show): New var.
7911 (syms_of_keyboard): Use DEFSYM macro.
7913 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7915 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7917 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7919 * process.c (Flist_processes): Remove to Lisp.
7920 (list_processes_1): Delete.
7922 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7924 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7926 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7928 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7930 Fix more problems found by GCC 4.6.0's static checks.
7932 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7934 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7936 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7938 * xdisp.c (vmessage): Mark as a printf-like function.
7940 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7942 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7944 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7945 printf-like functions.
7946 (tiff_load): Add casts to remove these marks before passing them
7947 to system-supplied API.
7949 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7951 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7952 This avoids several warnings with gcc -Wstrict-overflow.
7953 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7954 directly, rather than having caller test rule sign. This avoids
7955 some unnecessary tests.
7956 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7957 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7958 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7960 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7961 (xfont_open): Avoid unnecessary tests.
7963 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7965 * composite.h, composite.c (composition_gstring_put_cache):
7966 Use EMACS_INT, not int, for length.
7968 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7969 breaking out part of COMPOSITION_DECODE_RULE.
7970 (COMPOSITION_DECODE_RULE): Use it.
7971 * composite.c (get_composition_id): Remove unused local vars,
7972 by using the new macro.
7974 * textprop.c (set_text_properties_1): Change while to do-while,
7975 since the condition is always true at first.
7977 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7978 (interval_deletion_adjustment): Return unsigned value.
7981 * process.c (list_processes_1, create_pty, read_process_output):
7982 (exec_sentinel): Remove vars that were set but not used.
7983 (create_pty): Remove unnecessary "volatile"s.
7984 (Fnetwork_interface_info): Avoid possibility of int overflow.
7985 (read_process_output): Do adaptive read buffering even if carryover.
7986 (read_process_output): Simplify nbytes computation if buffered.
7988 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7990 * syntax.c (scan_words): Remove var that was set but not used.
7991 (update_syntax_table): Use unsigned instead of int.
7993 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7994 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7995 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7997 * print.c (print_error_message): Avoid int overflow.
7999 * font.c (font_list_entities): Redo for clarity,
8000 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8002 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8003 (font_score): Avoid potential overflow in diff calculation.
8005 * fns.c (substring_both): Remove var that is set but not used.
8006 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8008 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8010 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8011 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8012 can always succeed if overflow has undefined behavior.
8014 * search.c (boyer_moore, wordify): Remove vars set but not used.
8015 (wordify): Omit three unnecessary tests.
8017 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8018 All callers changed. This avoids the need for an unused var.
8020 * casefiddle.c (casify_region): Remove var that is set but not used.
8022 * dired.c (file_name_completion): Remove var that is set but not used.
8024 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8026 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8027 (Finsert_file_contents): Remove unnecessary code checking fd.
8029 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8030 Check for integer overflow on size calculations.
8032 * buffer.c (Fprevious_overlay_change): Remove var that is set
8035 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8036 Remove vars that are set but not used.
8037 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8038 (timer_check_2): Mark vars as initialized.
8040 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8042 * image.c (lookup_image): Remove var that is set but not used.
8043 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8045 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8046 that are set but not used.
8048 * xfns.c (make_invisible_cursor): Don't return garbage
8049 if XCreateBitmapFromData fails (Bug#8410).
8051 * xselect.c (x_get_local_selection, x_handle_property_notify):
8052 Remove vars that are set but not used.
8054 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8055 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8057 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8058 Remove var that is set but not used.
8059 (scroll_bar_windows_size): Now size_t, not int.
8060 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8063 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8064 (map_tty_color) [!defined MSDOS]: Likewise.
8066 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8068 * coding.c: Remove vars that are set but not used.
8069 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8070 All callers changed.
8071 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8072 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8073 (decode_coding_charset): Remove vars that are set but not used.
8075 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8076 that is set but not used.
8078 * print.c (print_object): Remove var that is set but not used.
8080 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8081 The gnulib version avoids calling malloc in the usual case,
8082 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8083 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8084 * filelock.c (current_lock_owner): Likewise.
8085 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8086 * sysdep.c: Include allocator.h, careadlinkat.h.
8087 (emacs_no_realloc_allocator): New static constant.
8088 (emacs_readlink): New function.
8089 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8090 ../lib/careadlinkat.h.
8092 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8094 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8095 first non-nil return value).
8097 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8099 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8100 if not defined (Bug#8403).
8102 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8104 * xdisp.c (display_count_lines): Remove parameter `start',
8105 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8106 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8107 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8108 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8109 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8110 and thereabouts. All callers changed.
8111 (get_per_char_metric): Remove parameter `f', unused since
8112 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8114 2011-04-02 Jim Meyering <meyering@redhat.com>
8116 do not dereference NULL upon failed strdup
8117 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8118 (ns_get_family): Likewise.
8120 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8122 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8124 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8126 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8129 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8131 Add lexical binding.
8133 * window.c (Ftemp_output_buffer_show): New fun.
8134 (Fsave_window_excursion):
8135 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8137 * lread.c (lisp_file_lexically_bound_p): New function.
8138 (Fload): Bind Qlexical_binding.
8139 (readevalloop): Remove `evalfun' arg.
8140 Bind Qinternal_interpreter_environment.
8141 (Feval_buffer): Bind Qlexical_binding.
8142 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8144 (syms_of_lread): Declare `lexical-binding'.
8146 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8148 * keyboard.c (eval_dyn): New fun.
8149 (menu_item_eval_property): Use it.
8151 * image.c (parse_image_spec): Use Ffunctionp.
8153 * fns.c (concat, mapcar1): Accept byte-code-functions.
8155 * eval.c (Fsetq): Handle lexical vars.
8156 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8157 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8158 (FletX, Flet): Obey lexical binding.
8159 (Fcommandp): Handle closures.
8160 (Feval): New `lexical' arg.
8161 (eval_sub): New function extracted from Feval. Use it almost
8162 everywhere where Feval was used. Look up vars in lexical env.
8164 (Ffunctionp): Move from subr.el.
8165 (Ffuncall): Handle closures.
8166 (apply_lambda): Remove `eval_flags'.
8167 (funcall_lambda): Handle closures and new byte-code-functions.
8168 (Fspecial_variable_p): New function.
8169 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8170 but without exporting it to Lisp.
8172 * doc.c (Fdocumentation, store_function_docstring):
8173 * data.c (Finteractive_form): Handle closures.
8175 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8178 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8180 (exec_byte_code): New function extracted from Fbyte_code to handle new
8181 calling convention for byte-code-functions. Add new byte-codes.
8183 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8185 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8187 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8189 * xdisp.c (redisplay_internal): Fix prototype.
8191 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8193 * xdisp.c (SCROLL_LIMIT): New macro.
8194 (try_scrolling): Use it when setting scroll_limit.
8195 Limit scrolling to 100 screen lines.
8196 (redisplay_window): Even when falling back on "recentering",
8197 position point in the window according to scroll-conservatively,
8198 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8200 (try_scrolling): When point is above the window, allow searching
8201 as far as scroll_max, or one screenful, to compute vertical
8202 distance from PT to the scroll margin position. This prevents
8203 try_scrolling from unnecessarily failing when
8204 scroll-conservatively is set to a value slightly larger than the
8205 window height. Clean up the case of PT below the margin at bottom
8206 of window: scroll_max can no longer be INT_MAX. When aggressive
8207 scrolling is in use, don't let point enter the opposite scroll
8208 margin as result of the scroll.
8209 (syms_of_xdisp) <scroll-conservatively>: Document the
8210 threshold of 100 lines for never-recentering scrolling.
8212 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8214 * dispextern.h (move_it_by_lines):
8215 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8216 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8217 (message_log_check_duplicate): Remove parameters `prev_bol' and
8218 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8219 (redisplay_internal): Remove parameter `preserve_echo_area',
8220 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8222 * indent.c (Fvertical_motion):
8223 * window.c (window_scroll_pixel_based, Frecenter):
8224 Don't pass `need_y_p' to `move_it_by_lines'.
8226 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8228 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8229 steal a few bits to be more compact.
8230 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8231 Remove unneeded casts.
8233 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8235 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8237 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8238 binding" message (bug#7967).
8240 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8242 Fix more problems found by GCC 4.6.0's static checks.
8244 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8245 Remove unused local var.
8247 * editfns.c (Fmessage_box): Remove unused local var.
8249 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8250 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8251 Omit unused local vars.
8252 * window.c (shrink_windows): Omit unused local var.
8253 * menu.c (digest_single_submenu): Omit unused local var.
8254 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8255 Omit unused local var.
8257 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8258 Don't assume string length fits in int.
8259 (keyremap_step, read_key_sequence): Use size_t for sizes.
8260 (read_key_sequence): Don't check last_real_key_start redundantly.
8262 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8263 instead of alloca (Bug#8344).
8265 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8266 (Fbacktrace_frame): Don't assume nframes fits in int.
8268 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8270 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8273 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8275 * cm.c (calccost): Turn while-do into do-while, for clarity.
8277 * keyboard.c (syms_of_keyboard): Use the same style as later
8278 in this function when indexing through an array. This also
8279 works around GCC bug 48267.
8281 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8283 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8285 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8286 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8288 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8289 This avoids undefined behavior on integer overflow, and is a bit
8290 more convenient anyway since it is compared to a size_t variable.
8292 Variadic C functions now count arguments with size_t, not int.
8293 This avoids an unnecessary limitation on 64-bit machines, which
8294 caused (substring ...) to crash on large vectors (Bug#8344).
8295 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8296 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8297 All variadic functions and their callers changed accordingly.
8298 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8299 * data.c (arith_driver, float_arith_driver): Likewise.
8300 * editfns.c (general_insert_function): Likewise.
8301 * eval.c (struct backtrace.nargs, interactive_p)
8302 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8303 (funcall_lambda, mark_backtrace): Likewise.
8304 * fns.c (concat): Likewise.
8305 * frame.c (x_set_frame_parameters): Likewise.
8306 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8307 0 if not found, not -1. All callers changed.
8309 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8310 (stack_copy_size): Now size_t, not int.
8311 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8313 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8315 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8316 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8317 All callers changed.
8319 * lisp.h (multibyte_char_to_unibyte):
8320 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8321 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8322 * character.h (CHAR_TO_BYTE8):
8323 * cmds.c (internal_self_insert):
8324 * editfns.c (general_insert_function):
8325 * keymap.c (push_key_description):
8326 * search.c (Freplace_match):
8327 * xdisp.c (message_dolog, set_message_1): All callers changed.
8329 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8331 * keyboard.c (safe_run_hook_funcall): New function.
8332 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8333 don't set the hook to nil, but remove the offending function instead.
8334 (Qcommand_hook_internal): Remove, unused.
8335 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8336 Vcommand_hook_internal.
8338 * eval.c (enum run_hooks_condition): Remove.
8339 (funcall_nil, funcall_not): New functions.
8340 (run_hook_with_args): Call each function through a `funcall' argument.
8341 Remove `cond' argument, now redundant.
8342 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8343 (Frun_hook_with_args_until_failure): Adjust accordingly.
8344 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8346 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8348 * dispextern.h (string_buffer_position): Remove declaration.
8350 * print.c (strout): Remove parameter `multibyte', unused since
8351 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8353 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8354 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8355 All callers changed.
8357 * w32.c (_wsa_errlist): Use braces for struct initializers.
8359 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8360 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8361 All callers changed.
8362 (string_buffer_position): Likewise. Also, make static (it's never
8363 used outside xdisp.c).
8364 (cursor_row_p): Remove parameter `w', unused since
8365 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8366 (decode_mode_spec): Remove parameter `precision', introduced during
8367 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8368 All callers changed.
8370 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8372 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8374 2011-03-27 Anders Lindgren <andlind@gmail.com>
8376 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8377 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8378 (ns_update_auto_hide_menu_bar): New functions.
8379 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8380 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8381 ns_constrain_all_frames.
8382 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8383 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8385 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8387 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8389 2011-03-27 Glenn Morris <rgm@gnu.org>
8391 * syssignal.h: Replace RETSIGTYPE with void.
8392 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8393 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8394 Replace SIGTYPE with void everywhere.
8395 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8396 * s/template.h (SIGTYPE): Remove commented out definition.
8398 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8400 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8401 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8403 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8405 * w32.c (read_unc_volume): Use parameter `henum', instead of
8406 global variable `wget_enum_handle'.
8408 * keymap.c (describe_vector): Remove parameters `indices' and
8409 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8410 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8412 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8414 * keyboard.c (timer_check): Remove parameter `do_it_now',
8415 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8416 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8417 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8419 * keyboard.c (read_char):
8420 * w32menu.c (w32_menu_display_help):
8421 * xmenu.c (show_help_event, menu_help_callback):
8422 Adjust calls to `show_help_echo'.
8424 * gtkutil.c (xg_maybe_add_timer):
8425 * keyboard.c (readable_events):
8426 * process.c (wait_reading_process_output):
8427 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8429 * insdel.c (adjust_markers_gap_motion):
8430 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8431 (gap_left, gap_right): Don't call it.
8433 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8435 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8436 incurred during fontification.
8438 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8440 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8441 (DEFVAR_PER_BUFFER): Don't pass it.
8443 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8444 (scrolling_window): Don't pass it.
8446 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8448 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8450 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8452 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8453 of variables specific to SELinux and computation of `encoded_absname'.
8455 * image.c (XPutPixel): Remove unused variable `height'.
8457 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8459 * unexw32.c (get_section_info): Remove unused variable `section'.
8461 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8462 (system_process_attributes): Remove unused variable `sess'.
8463 (sys_read): Remove unused variable `err'.
8465 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8466 (w32_wnd_proc): Remove unused variable `isdead'.
8467 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8468 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8469 (x_create_tip_frame): Remove unused variable `tem'.
8471 * w32inevt.c (w32_console_read_socket):
8472 Remove unused variable `no_events'.
8474 * w32term.c (x_draw_composite_glyph_string_foreground):
8475 Remove unused variable `width'.
8477 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8479 * w32term.c (x_set_glyph_string_clipping):
8480 Don't pass uninitialized region to CombineRgn.
8482 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8484 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8485 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8486 (Fx_close_connection): Remove unused variable `i'.
8488 * w32font.c (w32font_draw): Return number of glyphs.
8489 (w32font_open_internal): Remove unused variable `i'.
8490 (w32font_driver): Add missing initializer.
8492 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8493 (fill_in_menu): Remove unused variable `items_added'.
8495 * w32term.c (last_mouse_press_frame): Remove static global variable.
8496 (w32_clip_to_row): Remove unused variable `f'.
8497 (x_delete_terminal): Remove unused variable `i'.
8499 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8500 (NOTHING): Remove unused static global variable.
8501 (uniscribe_check_otf): Remove unused variable `table'.
8502 (uniscribe_font_driver): Add missing initializers.
8504 2011-03-23 Julien Danjou <julien@danjou.info>
8506 * term.c (Fsuspend_tty, Fresume_tty):
8507 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8508 * window.c (temp_output_buffer_show):
8509 * insdel.c (signal_before_change):
8510 * frame.c (Fhandle_switch_frame):
8511 * fileio.c (Fdo_auto_save):
8512 * emacs.c (Fkill_emacs):
8513 * editfns.c (save_excursion_restore):
8514 * cmds.c (internal_self_insert):
8515 * callint.c (Fcall_interactively):
8516 * buffer.c (Fkill_all_local_variables):
8517 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8519 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8520 unconditionally since it does the check itself.
8522 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8524 Fix more problems found by GCC 4.5.2's static checks.
8526 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8527 the first time through the loop, since we know p0 < p1 then.
8528 This also avoids a gcc -Wstrict-overflow warning.
8530 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8531 leading to a memory leak, possible in functions like
8532 load_charset_map_from_file that can allocate an unbounded number
8533 of objects (Bug#8318).
8535 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8536 that could (at least in theory) be that large.
8538 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8539 This is less likely to overflow, and avoids undefined behavior if
8540 overflow does occur. All callers changed. Use strtoul to scan
8541 for the unsigned long integer.
8542 (pint2hrstr): Simplify and tune code slightly.
8543 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8545 * scroll.c (do_scrolling): Work around GCC bug 48228.
8546 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8548 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8549 This also avoids a warning with gcc -Wstrict-overflow.
8550 (validate_x_resource_name): Simplify count usage.
8551 This also avoids a warning with gcc -Wstrict-overflow.
8553 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8556 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8558 * process.c (Fmake_network_process): Use socklen_t, not int,
8559 where POSIX says socklen_t is required in portable programs.
8560 This fixes a porting bug on hosts like 64-bit HP-UX, where
8561 socklen_t is wider than int (Bug#8277).
8562 (Fmake_network_process, server_accept_connection):
8563 (wait_reading_process_output, read_process_output):
8566 * process.c: Rename or move locals to avoid shadowing.
8567 (list_processes_1, Fmake_network_process):
8568 (read_process_output_error_handler, exec_sentinel_error_handler):
8569 Rename or move locals.
8570 (Fmake_network_process): Define label "retry_connect" only if needed.
8571 (Fnetwork_interface_info): Fix pointer signedness.
8572 (process_send_signal): Add cast to avoid pointer signedness problem.
8573 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8574 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8576 Make tparam.h and terminfo.c consistent.
8577 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8578 Include tparam.h instead, since it declares them.
8579 * cm.h (PC): Remove extern decl; tparam.h now does this.
8580 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8581 * terminfo.c: Include tparam.h, to check interfaces.
8582 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8583 (tparam): Adjust signature to match interface in tparam.h;
8584 this removes some undefined behavior. Check that outstring and len
8585 are zero, which they always are with Emacs.
8586 * tparam.h (PC, BC, UP): New extern decls.
8588 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8589 (xftfont_open): Rename locals to avoid shadowing.
8591 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8592 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8593 (OTF_TAG_SYM): Omit macro if not needed.
8594 (ftfont_list): Remove unused local.
8595 (get_adstyle_property, ftfont_pattern_entity):
8596 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8597 Rename locals to avoid shadowing.
8599 * xfont.c (xfont_list_family): Mark var as initialized.
8601 * xml.c (make_dom): Now static.
8603 * composite.c (composition_compute_stop_pos): Rename local to
8605 (composition_reseat_it): Remove unused locals.
8606 (find_automatic_composition, composition_adjust_point): Likewise.
8607 (composition_update_it): Mark var as initialized.
8608 (find_automatic_composition): Mark vars as initialized,
8609 with a FIXME (Bug#8290).
8611 character.h: Rename locals to avoid shadowing.
8612 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8613 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8614 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8615 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8618 * textprop.c (property_change_between_p): Remove; unused.
8620 * intervals.c (interval_start_pos): Now static.
8622 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8624 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8625 Rename locals to avoid shadowing.
8627 * sound.c (wav_play, au_play, Fplay_sound_internal):
8628 Fix pointer signedness.
8629 (alsa_choose_format): Remove unused local var.
8630 (wav_play): Initialize a variable to 0, to prevent undefined
8631 behavior (Bug#8278).
8633 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8635 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8637 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8638 clobbering (Bug#8298).
8639 * sysdep.c (sys_subshell): Likewise.
8640 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8642 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8643 This should get cleaned up, so that child_setup has the
8644 same signature on all platforms.
8646 * callproc.c (call_process_cleanup): Now static.
8647 (relocate_fd): Rename locals to avoid shadowing.
8649 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8651 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8652 not to be necessary, and produces flickering.
8654 2011-03-20 Glenn Morris <rgm@gnu.org>
8656 * config.in: Remove file.
8658 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8660 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8661 are now in src/globals.h.
8662 (syms_of_minibuf): Remove spurious & from previous change.
8664 2011-03-20 Leo Liu <sdl.web@gmail.com>
8666 * minibuf.c (completing-read-function): New variable.
8667 (completing-read-default): Rename from completing-read.
8668 (completing-read): Call completing-read-function.
8670 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8672 * xfaces.c (Fx_load_color_file):
8673 Read color file from absolute filename (bug#8250).
8675 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8677 * makefile.w32-in: Update dependencies.
8679 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8681 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8683 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8685 Fix more problems found by GCC 4.5.2's static checks.
8687 * process.c (make_serial_process_unwind, send_process_trap):
8688 (sigchld_handler): Now static.
8690 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8691 That way, the code declares only the vars that it needs.
8692 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8693 * s/cygwin.h (PTY_ITERATION): Likewise.
8694 * s/darwin.h (PTY_ITERATION): Likewise.
8695 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8697 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8698 * process.c (allocate_pty): Don't declare stb unless it's needed.
8700 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8701 (CONSTANTLIM): Remove; unused.
8702 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8703 Define only if needed.
8705 * unexelf.c (unexec): Name an expression,
8706 to avoid gcc -Wbad-function-cast warning.
8707 Use a different way to cause a compilation error if anyone uses
8708 n rather than nn, a way that does not involve shadowing.
8709 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8711 * deps.mk (unexalpha.o): Remove; unused.
8713 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8714 * unexec.h: New file.
8715 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8716 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8718 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8719 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8720 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8721 Change as necessary to match prototype in unexec.h.
8723 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8725 (back_comment, skip_chars): Mark vars as initialized.
8727 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8728 Rename locals to avoid shadowing.
8730 * lread.c (read1): Rewrite so as not to use empty "else".
8731 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8733 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8735 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8736 warning when compiling print.c.
8738 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8739 instead of using an uninitialized var.
8740 (font_sort_entities): Mark var as initialized.
8742 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8744 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8745 pointers to constants.
8746 (font_parse_fcname): Remove unused vars.
8747 (font_delete_unmatched): Now static.
8748 (font_get_spec): Remove; unused.
8749 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8750 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8751 Rename or move locals to avoid shadowing.
8753 * fns.c (require_nesting_list, require_unwind): Now static.
8754 (Ffillarray): Rename locals to avoid shadowing.
8756 * floatfns.c (domain_error2): Define only if needed.
8757 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8759 * alloc.c (mark_backtrace): Move decl from here ...
8760 * lisp.h: ... to here, so that it can be checked.
8762 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8763 (Fdefvar): Rewrite so as not to use empty "else".
8764 (lisp_indirect_variable): Name an expression,
8765 to avoid gcc -Wbad-function-cast warning.
8766 (Fdefvar): Rename locals to avoid shadowing.
8768 * callint.c (quotify_arg, quotify_args): Now static.
8769 (Fcall_interactively): Rename locals to avoid shadowing.
8770 Use const pointer when appropriate.
8772 * lisp.h (get_system_name, get_operating_system_release):
8773 Move decls here, to check interfaces.
8774 * process.c (get_operating_system_release): Move decl to lisp.h.
8775 * xrdb.c (get_system_name): Likewise.
8776 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8777 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8778 some of which prompt warnings from gcc -Wbad-function-cast.
8779 (Fformat_time_string, Fencode_time, Finsert_char):
8780 (Ftranslate_region_internal, Fformat):
8781 Rename or remove local vars to avoid shadowing.
8782 (Ftranslate_region_internal): Mark var as initialized.
8784 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8787 * lisp.h (eassert): Check that the argument compiles, even if
8788 ENABLE_CHECKING is not defined.
8790 * data.c (Findirect_variable): Name an expression, to avoid
8791 gcc -Wbad-function-cast warning.
8792 (default_value, arithcompare, arith_driver, arith_error): Now static.
8793 (store_symval_forwarding): Rename local to avoid shadowing.
8794 (Fmake_variable_buffer_local, Fmake_local_variable):
8795 Mark variables as initialized.
8796 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8798 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8799 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8800 Rename locals to avoid shadowing.
8801 (mark_stack): Move local variables into the #ifdef region where
8803 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8804 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8806 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8807 (GC_STRING_CHARS): Remove; not used.
8808 (Fmemory_limit): Cast sbrk's returned value to char *.
8810 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8811 avoids undefined behavior in theory.
8813 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8815 Use functions, not macros, for up- and down-casing (Bug#8254).
8816 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8817 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8818 to use the following functions instead of these macros.
8819 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8820 EMACS_INT, since callers assume the returned value fits in int.
8821 (upcase1): Likewise, for UPCASE_TABLE.
8822 (uppercasep, lowercasep, upcase): New static inline functions.
8823 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8824 the race-condition problem in the old DOWNCASE.
8826 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8827 Rename locals to avoid shadowing.
8828 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8829 (regex_compile, re_search_2, re_match_2_internal):
8830 Remove unused local vars.
8831 (FREE_VAR): Rewrite so as not to use empty "else",
8832 which gcc can warn about.
8833 (regex_compile, re_match_2_internal): Mark locals as initialized.
8834 (RETALLOC_IF): Define only if needed.
8835 (WORDCHAR_P): Likewise. This one is never needed, but is used
8836 only in a comment talking about a compiler bug, so put inside
8837 the #if 0 of that comment.
8838 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8839 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8842 * search.c (boyer_moore): Rename locals to avoid shadowing.
8843 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8844 (PREV_CHAR_BOUNDARY): Likewise.
8846 * search.c (simple_search): Remove unused var.
8848 * dired.c (compile_pattern): Move decl from here ...
8849 * lisp.h: ... to here, so that it can be checked.
8850 (struct re_registers): New forward decl.
8852 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8854 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8856 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8857 Rename locals to avoid shadowing.
8858 (Fvertical_motion): Mark locals as initialized.
8860 * casefiddle.c (casify_object, casify_region): Now static.
8861 (casify_region): Mark local as initialized.
8863 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8865 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8866 New macros, so that the caller can use some names other than
8867 gcpro1, gcpro2, etc.
8868 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8870 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8871 argument, for consistency with GCPRO2_VAR, etc: it is now the
8872 prefix of the variable, not the variable itself. All uses
8874 * dired.c (directory_files_internal, file_name_completion):
8875 Rename locals to avoid shadowing.
8877 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8878 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8879 dired.c's scmp function, had undefined behavior.
8880 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8881 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8882 * buffer.h: ... to here, because these macros use current_buffer,
8883 and the new implementation with inline functions needs to have
8884 current_buffer in scope now, rather than later when the macros
8886 (downcase, upcase1): New static inline functions.
8887 (DOWNCASE, UPCASE1): Reimplement using these functions.
8888 This avoids undefined behavior in expressions like
8889 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8890 from race conditions in accessing the global variables
8891 case_temp1 and case_temp2.
8892 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8893 * lisp.h (case_temp1, case_temp2): Remove their decls.
8894 * character.h (ASCII_CHAR_P): Move from here ...
8895 * lisp.h: ... to here, so that the inline functions mentioned
8898 * dired.c (directory_files_internal_unwind): Now static.
8900 * fileio.c (file_name_as_directory, directory_file_name):
8901 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8903 (file_name_as_directory): Use const pointers when appropriate.
8904 (Fexpand_file_name): Likewise. In particular, newdir might
8905 point at constant storage, so make it a const pointer.
8906 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8907 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8909 (Fset_file_times, Finsert_file_contents, auto_save_error):
8910 Rename locals to avoid shadowing.
8912 * minibuf.c (choose_minibuf_frame_1): Now static.
8913 (Ftry_completion, Fall_completions): Rename or remove locals
8916 * marker.c (bytepos_to_charpos): Remove; unused.
8918 * lisp.h (verify_bytepos, count_markers): New decls,
8919 so that gcc does not warn that these functions aren't declared.
8921 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8922 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8923 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8924 (copy_text): Remove unused local var.
8926 * filelock.c (within_one_second): Now static.
8927 (lock_file_1): Rename local to avoid shadowing.
8929 * buffer.c (fix_overlays_before): Mark locals as initialized.
8930 (fix_start_end_in_overlays): Likewise. This function should be
8931 simplified by using pointers-to-pointers, but that's a different
8933 (switch_to_buffer_1): Now static.
8934 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8935 (report_overlay_modification): Rename locals to avoid shadowing.
8937 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8938 Fix pointer signedness issue.
8939 (sys_subshell): Mark local as volatile if checking for lint,
8940 to suppress a gcc -Wclobbered warning that does not seem to be right.
8941 (MAXPATHLEN): Define only if needed.
8943 * process.c (serial_open, serial_configure): Move decls from here ...
8944 * systty.h: ... to here, so that they can be checked.
8946 * fns.c (get_random, seed_random): Move extern decls from here ...
8947 * lisp.h: ... to here, so that they can be checked.
8949 * sysdep.c (reset_io): Now static.
8950 (wait_for_termination_signal): Remove; unused.
8952 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8953 (copy_keymap_item, append_key, push_text_char_description):
8955 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8956 (DENSE_TABLE_SIZE): Remove; unused.
8957 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8958 (describe_map_tree):
8959 Rename locals to avoid shadowing.
8961 * keyboard.c: Declare functions static if they are not used elsewhere.
8962 (echo_char, echo_dash, cmd_error, top_level_2):
8963 (poll_for_input, handle_async_input): Now static.
8964 (read_char, kbd_buffer_get_event, make_lispy_position):
8965 (make_lispy_event, make_lispy_movement, apply_modifiers):
8966 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8967 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8968 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8969 (read_key_sequence, read_char): Mark locals as initialized.
8970 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8972 * keyboard.h (make_ctrl_char): New decl.
8973 (mark_kboards): Move decl here ...
8974 * alloc.c (mark_kboards): ... from here.
8976 * lisp.h (force_auto_save_soon): New decl.
8978 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8979 (DEFINE_DUMMY_FUNCTION): New macro.
8980 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8982 (main): Add casts to avoid warnings
8983 if GCC considers string literals to be constants.
8985 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8987 * dbusbind.c: Pointer signedness fixes.
8988 (xd_signature, xd_append_arg, xd_initialize):
8989 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8990 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8991 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8992 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8994 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8995 if GCC considers string literals to be constants.
8996 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8998 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9000 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9001 (print_preprocess, print_object): New macro to fix last change.
9003 * print.c (print_preprocess): Don't forget font objects.
9005 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9007 * emacs.c (USAGE3): Doc fixes.
9009 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9011 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9014 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9016 * lisp.h (VWindow_system, Qfile_name_history):
9017 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9018 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9019 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9021 * w32select.c: Don't #include "keyboard.h".
9022 (run_protected): Add extern declaration for waiting_for_input.
9024 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9025 * w32console.c (detect_input_pending, read_input_pending)
9026 (encode_terminal_code):
9027 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9028 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9029 (w32_system_caret_y, Qfile_name_history):
9030 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9031 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9032 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9033 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9034 * w32proc.c (Qlocal, report_file_error):
9035 * w32term.c (Vwindow_system, updating_frame):
9036 * w32uniscribe.c (initialized, uniscribe_font_driver):
9037 Remove unneeded extern declarations.
9039 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9041 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9043 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9045 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9046 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9047 These macros can no longer be used for assignment.
9049 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9050 Assign struct members directly, instead of using BUF_BEGV etc.
9051 (record_buffer_markers, fetch_buffer_markers): New functions for
9052 recording and fetching special buffer markers.
9053 (set_buffer_internal_1, set_buffer_temp): Use them.
9055 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9057 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9059 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9060 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9062 * xdisp.c (hscroll_window_tree):
9063 (reconsider_clip_changes): Use PT instead of BUF_PT.
9065 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9067 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9068 $(EMACS_ROOT)/lib/intprops.h.
9070 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9072 Fix more problems found by GCC 4.5.2's static checks.
9074 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9075 to unsigned char * to avoid compiler diagnostic.
9076 (xg_free_frame_widgets): Make it clear that a local variable is
9077 needed only if USE_GTK_TOOLTIP.
9078 (gdk_window_get_screen): Make it clear that this macro is needed
9079 only if USE_GTK_TOOLTIP.
9080 (int_gtk_range_get_value): New function, which avoids a diagnostic
9081 from gcc -Wbad-function-cast.
9082 (xg_set_toolkit_scroll_bar_thumb): Use it.
9083 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9084 diagnostic from gcc -Wbad-function-cast.
9085 (get_utf8_string, xg_get_file_with_chooser):
9086 Rename locals to avoid shadowing.
9087 (create_dialog): Move locals to avoid shadowing.
9089 * xgselect.c (xg_select): Remove unused var.
9091 * image.c (four_corners_best): Mark locals as initialized.
9092 (gif_load): Initialize transparent_p to zero (Bug#8238).
9093 Mark another local as initialized.
9094 (my_png_error, my_error_exit): Mark with NO_RETURN.
9096 * image.c (clear_image_cache): Now static.
9097 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9098 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9099 (x_edge_detection): Remove unnecessary cast that
9100 gcc -Wbad-function-cast diagnoses.
9101 (gif_load): Fix pointer signedness.
9102 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9103 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9105 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9107 Improve quality of tests for time stamp overflow.
9108 For example, without this patch (encode-time 0 0 0 1 1
9109 1152921504606846976) returns the obviously-bogus value (-948597
9110 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9111 reports time overflow. See
9112 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9113 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9114 * editfns.c: Include limits.h and intprops.h.
9115 (TIME_T_MIN, TIME_T_MAX): New macros.
9116 (time_overflow): Move earlier, to before first use.
9117 (hi_time, lo_time): New functions, for an accurate test for
9119 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9120 (Fget_internal_run_time): Don't assume time_t fits in int.
9121 (make_time): Use list2 instead of Fcons twice.
9122 (Fdecode_time): More accurate test for out-of-range times.
9123 (check_tm_member): New function.
9124 (Fencode_time): Use it, to test for out-of-range times.
9125 (lisp_time_argument): Don't rely on undefined left-shift and
9126 right-shift behavior when checking for time stamp overflow.
9128 * editfns.c (time_overflow): New function, refactoring common code.
9129 (Fformat_time_string, Fdecode_time, Fencode_time):
9130 (Fcurrent_time_string): Use it.
9132 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9133 * dired.c (make_time): Move to ...
9134 * editfns.c (make_time): ... here.
9135 * systime.h: Note the move.
9137 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9139 * fringe.c (update_window_fringes): Remove unused variables.
9141 * unexmacosx.c (copy_data_segment): Also copy __got section.
9144 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9146 * termcap.c [MSDOS]: Include "msdos.h".
9147 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9148 Constify `char *' arguments and their references according to
9149 prototypes in tparam.h.
9151 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9153 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9154 Adapt all references accordingly.
9156 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9158 2011-03-11 Tom Tromey <tromey@redhat.com>
9160 * buffer.c (syms_of_buffer): Remove obsolete comment.
9162 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9164 * termhooks.h (encode_terminal_code): Declare prototype.
9166 * msdos.c (encode_terminal_code): Don't declare prototype.
9168 * term.c (encode_terminal_code): Now external again, used by
9169 w32console.c and msdos.c.
9171 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9172 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9174 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9176 Fix some minor problems found by GCC 4.5.2's static checks.
9178 * fringe.c (update_window_fringes): Mark locals as initialized
9180 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9182 * alloc.c (mark_fringe_data): Move decl from here ...
9183 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9184 to check its interface.
9185 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9187 * fontset.c (free_realized_fontset): Now static.
9188 (Fset_fontset_font): Rename local to avoid shadowing.
9189 (fontset_font): Mark local as initialized.
9190 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9192 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9194 * xselect.c (x_disown_buffer_selections): Remove; not used.
9195 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9196 (x_own_selection, Fx_disown_selection_internal): Rename locals
9198 (x_handle_dnd_message): Remove local to avoid shadowing.
9200 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9201 so that the caller can use some name other than gcpro1.
9202 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9203 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9204 (Fx_backspace_delete_keys_p):
9205 Use them to avoid shadowing, and rename vars to avoid shadowing.
9206 (x_decode_color, x_set_name, x_window): Now static.
9207 (Fx_create_frame): Add braces to silence GCC warning.
9208 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9209 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9210 Remove unused locals.
9211 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9212 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9213 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9216 * xterm.h (x_mouse_leave): New decl.
9218 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9219 Remove unused functions.
9220 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9221 (x_calc_absolute_position): Now static.
9222 (XTread_socket): Don't define label "out" unless it's used.
9223 Don't declare local "event" unless it's used.
9224 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9225 unless they are used.
9226 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9227 (x_fatal_error_signal): Remove; not used.
9228 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9229 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9230 (x_error_catcher, x_connection_closed, x_error_handler):
9231 (x_error_quitter, xembed_send_message, x_iconify_frame):
9232 (my_log_handler): Rename locals to avoid shadowing.
9233 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9234 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9236 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9237 Rename or move locals to avoid shadowing.
9238 (tty_defined_color, merge_face_heights): Now static.
9239 (free_realized_faces_for_fontset): Remove; not used.
9240 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9241 does not deduce is never used uninitialized.
9242 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9243 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9245 * terminal.c (store_terminal_param): Now static.
9247 * xmenu.c (menu_highlight_callback): Now static.
9248 (set_frame_menubar): Remove unused local.
9249 (xmenu_show): Rename parameter to avoid shadowing.
9250 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9251 since they might point to immutable storage.
9252 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9253 since it's unused otherwise.
9255 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9256 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9257 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9258 avoids a gcc -Wuninitialized diagnostic.
9259 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9260 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9261 does not deduce are never used uninitialized.
9263 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9265 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9266 * window.c (window_loop, size_window):
9267 (run_window_configuration_change_hook, enlarge_window): Likewise.
9269 * window.c (display_buffer): Now static.
9270 (size_window): Mark variables that gcc -Wuninitialized
9271 does not deduce are never used uninitialized.
9272 * window.h (check_all_windows): New decl, to forestall
9273 gcc -Wmissing-prototypes diagnostic.
9274 * dispextern.h (bidi_dump_cached_states): Likewise.
9276 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9278 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9280 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9281 and to avoid gcc -Wuninitialized warning.
9282 (load_charset_map): Mark variables that gcc -Wuninitialized
9283 does not deduce are never used uninitialized.
9284 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9286 * coding.c (coding_set_source, coding_set_destination):
9287 Use "else { /* comment */ }" rather than "else /* comment */;"
9288 for clarity, and to avoid gcc -Wempty-body warning.
9289 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9290 a block, when the outer 'i' will do.
9291 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9292 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9293 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9294 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9295 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9296 Rename locals to avoid shadowing.
9297 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9298 * coding.c (emacs_mule_char, encode_invocation_designation):
9299 Now static, since they're not used elsewhere.
9300 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9301 (decode_coding_object, encode_coding_object, detect_coding_system):
9302 (decode_coding_emacs_mule): Mark variables that gcc
9303 -Wuninitialized does not deduce are never used uninitialized.
9304 (detect_coding_iso_2022): Initialize a local variable that might
9305 be used uninitialized. Leave a FIXME because it's not clear that
9306 this initialization is needed. (Bug#8211)
9307 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9308 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9309 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9310 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9311 Remove unused macros.
9313 * category.c (hash_get_category_set): Remove unused local var.
9314 (copy_category_table): Now static, since it's not used elsewhere.
9315 * character.c (string_count_byte8): Likewise.
9317 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9318 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9320 * chartab.c (copy_sub_char_table): Now static, since it's not used
9322 (sub_char_table_ref_and_range, char_table_ref_and_range):
9323 Rename locals to avoid shadowing.
9324 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9326 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9327 (BIDI_BOB): Remove unused macro.
9329 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9330 deduce are never used uninitialized.
9331 * term.c (encode_terminal_code): Likewise.
9333 * term.c (encode_terminal_code): Now static. Remove unused local.
9335 * tparam.h: New file.
9336 * term.c, tparam.h: Include it.
9337 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9338 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9339 Move these decls to tparam.h, and make them agree with what
9340 is actually in tparam.c. The previous trick of using incompatible
9341 decls in different modules does not conform to the C standard.
9342 All callers of tparam changed to use tparam's actual API.
9343 * tparam.c (tparam1, tparam, tgoto):
9344 Use const pointers where appropriate.
9346 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9347 * cm.h (struct cm): Likewise.
9348 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9349 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9350 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9351 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9352 (turn_on_face, init_tty): Likewise.
9353 * termchar.h (struct tty_display_info): Likewise.
9355 * term.c (term_mouse_position): Rename local to avoid shadowing.
9357 * alloc.c (mark_ttys): Move decl from here ...
9358 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9360 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9362 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9364 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9366 * search.c (compile_pattern_1): Remove argument regp, unused since
9367 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9368 (compile_pattern): Don't pass it.
9370 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9372 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9373 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9375 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9377 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9379 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9380 gdk_window_get_screen, gdk_window_get_geometry,
9381 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9382 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9383 (xg_get_pixbuf_from_pixmap): New function.
9384 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9385 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9386 Call xg_get_pixbuf_from_pixmap instead of
9387 gdk_pixbuf_get_from_drawable.
9388 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9389 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9390 (xg_check_special_colors): Use GtkStyleContext and its functions
9392 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9393 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9394 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9395 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9396 Call gtk_widget_get_preferred_size.
9397 (xg_frame_resized): gdk_window_get_geometry only takes 5
9399 (xg_win_to_widget, xg_event_is_for_menubar):
9400 Call gdk_x11_window_lookup_for_display.
9401 (xg_set_widget_bg): New function.
9402 (delete_cb): New function.
9403 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9404 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9405 (xg_set_background_color): Call xg_set_widget_bg.
9406 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9407 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9408 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9409 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9411 (update_frame_tool_bar): Call gtk_widget_hide.
9412 (xg_initialize): Use GDK_KEY_g.
9414 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9416 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9418 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9419 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9420 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9422 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9424 * w32xfns.c (select_palette): Check success of RealizePalette against
9425 GDI_ERROR, not zero.
9427 See ChangeLog.11 for earlier changes.
9433 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9435 This file is part of GNU Emacs.
9437 GNU Emacs is free software: you can redistribute it and/or modify
9438 it under the terms of the GNU General Public License as published by
9439 the Free Software Foundation, either version 3 of the License, or
9440 (at your option) any later version.
9442 GNU Emacs is distributed in the hope that it will be useful,
9443 but WITHOUT ANY WARRANTY; without even the implied warranty of
9444 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9445 GNU General Public License for more details.
9447 You should have received a copy of the GNU General Public License
9448 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.