Handle overflow when computing char display width (Bug#9496).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
df0b2940
PE
12012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 Handle overflow when computing char display width (Bug#9496).
4 * character.c (char_width): Return EMACS_INT, not int.
5 (char_width, c_string_width): Check for overflow when
6 computing the width; this is possible now that individual
7 characters can have unbounded width. Problem introduced
8 by merge from Emacs 23 on 2012-01-19.
9
6bee44d6
MA
102012-02-02 Michael Albinus <michael.albinus@gmx.de>
11
12 * dbusbind.c (Fdbus_register_method): Mention the return value
13 :ignore in the docstring.
14
44f92739
GM
152012-02-02 Glenn Morris <rgm@gnu.org>
16
1b9f60cc
GM
17 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
18
44f92739
GM
19 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
20 Unconditionally set to t. (Bug#10673)
21 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
22 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
23 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
24
c5d3843c
KH
252012-02-02 Kenichi Handa <handa@m17n.org>
26
27 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
28 0, do not call append_composite_glyph.
29
159462d4 302012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
31
32 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
33 NULL (Bug#6988).
34 (x_produce_glyphs): If the component of a composition is a null
35 string, set it->pixel_width to 1 to avoid zero-width glyph.
36
78cef877
EZ
372012-02-01 Eli Zaretskii <eliz@gnu.org>
38
39 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
40 first 2 arguments are identical. This makes inserting large
41 output from a subprocess an order of magnitude faster on
42 MS-Windows, where all sbrk'ed memory is always contiguous.
43
97897668
GM
442012-01-31 Glenn Morris <rgm@gnu.org>
45
46 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 47 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
48 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
49
31fd3586
GM
502012-01-29 Glenn Morris <rgm@gnu.org>
51
52 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
53
0e24a8b2
CY
542012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
55
56 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
57
cc0adcb0
CY
582012-01-28 Chong Yidong <cyd@gnu.org>
59
60 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
61
acc28cb9
CY
622012-01-26 Chong Yidong <cyd@gnu.org>
63
9c69cfb7
CY
64 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
65
acc28cb9
CY
66 * search.c (Fsearch_forward, Fsearch_backward): Document negative
67 repeat counts (Bug#10507).
68
48da7392
GM
692012-01-26 Glenn Morris <rgm@gnu.org>
70
71 * lread.c (syms_of_lread): Doc fix.
72
14af5f7f
CY
732012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
74
75 * coding.c (encode_designation_at_bol): Change return value to
76 EMACS_INT.
77
0b21c100
CY
782012-01-25 Chong Yidong <cyd@gnu.org>
79
80 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
81
3c2907f7
CY
822012-01-21 Chong Yidong <cyd@gnu.org>
83
84 * floatfns.c (Fcopysign): Make the second argument non-optional,
85 since nil is not allowed anyway.
86
959ad23f
AS
872012-01-21 Andreas Schwab <schwab@linux-m68k.org>
88
89 * process.c (read_process_output): Use p instead of XPROCESS (proc).
90 (send_process): Likewise.
91
34a02f46
MR
922012-01-19 Martin Rudalics <rudalics@gmx.at>
93
94 * window.c (save_window_save, Fcurrent_window_configuration)
95 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
96 doc-strings.
97
1259009a 982012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
99
100 * character.c (char_width): New function.
70d4fdf6
GM
101 (Fchar_width, c_string_width, lisp_string_width):
102 Use char_width (Bug#9496).
25ed9e61 103
6a6ee00d
MR
1042012-01-16 Martin Rudalics <rudalics@gmx.at>
105
106 * window.c (Vwindow_persistent_parameters): New variable.
107 (Fset_window_configuration, save_window_save): Handle persistent
108 window parameters.
109
c85efaf7
EZ
1102012-01-14 Eli Zaretskii <eliz@gnu.org>
111
112 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
113 thrashing the stack of the thread. (Bug#9087)
114
5944709e
PE
1152012-01-12 Paul Eggert <eggert@cs.ucla.edu>
116
117 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
118
e71f5d99
EZ
1192012-01-11 Eli Zaretskii <eliz@gnu.org>
120
121 * xdisp.c (rows_from_pos_range): Handle the case where the
122 highlight ends on a newline. (Bug#10464)
123 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
124 he end column for display of highlight that ends on a newline
125 before a R2L line.
126
ce316182
GM
1272012-01-11 Glenn Morris <rgm@gnu.org>
128
129 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
130 from load-path also when installation-directory is nil. (Bug#10208)
131
5b43da69
GM
1322012-01-10 Glenn Morris <rgm@gnu.org>
133
74cc8ff9
GM
134 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
135
7d8d6e4e
GM
136 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
137 Update template values to be closer to their typical values these days.
5b43da69 138
a0db8d43
EZ
1392012-01-09 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (rows_from_pos_range): Accept additional argument
142 DISP_STRING, and accept any glyph in a row whose object is that
143 string as eligible for mouse highlight. Fixes mouse highlight of
144 display strings from overlays. (Bug#10464)
145
9a0115ab 1462012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 147
b9110d6a 148 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
149 * fileio.c (auto_saving_dir_umask): New static var.
150 (Fmake_directory_internal): Use it.
151 (do_auto_save_make_dir): Set it, instead of invoking chmod after
152 creating the directory. The old code temporarily assigns
153 too-generous permissions to the directory.
154 (do_auto_save_eh): Clear it.
b9110d6a 155 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
156 that the var is always cleared.
157
6c1bd3f3
EZ
1582012-01-07 Eli Zaretskii <eliz@gnu.org>
159
160 * search.c (scan_buffer): Pass character positions to
161 know_region_cache, not byte positions. (Bug#6540)
162
069d2b50
L
1632012-01-07 LynX <_LynX@bk.ru> (tiny change)
164
165 * w32.c (sys_rename): Report EXDEV when rename of a directory
166 fails because the target is on another logical disk. (Bug#10284)
167
75bf0d33
DB
1682012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
169
170 * xterm.c (x_embed_request_focus): New function.
171
172 * xterm.h: Add prototype.
173
174 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
175
1c6e5a32
GM
1762012-01-05 Glenn Morris <rgm@gnu.org>
177
178 * emacs.c (emacs_copyright): Update short copyright year to 2012.
179
651e947e
EZ
1802012-01-01 Eli Zaretskii <eliz@gnu.org>
181
182 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
183 Load gnutls_transport_set_lowat only if GnuTLS version is below
184 2.11.1.
185 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
186 GnuTLS versions below 2.11.1.
187
3778cdd8
AL
1882011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
189
190 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
191 to the doc string advising against its use for altering the way
192 windows are scrolled.
193
0e5317f7
KH
1942011-12-28 Kenichi Handa <handa@m17n.org>
195
196 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
197 coding-system ASCII compatible only when it does not produce BOM
198 on encoding (Bug#10383).
199
93d5ca1f
JD
2002011-12-26 Jan Djärv <jan.h.d@swipnet.se>
201
202 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
203 can scroll.
204 (create_and_show_popup_menu): Always use menu_position_func for
205 Gtk3 (Bug#10361).
206
ca22b785
AS
2072011-12-24 Andreas Schwab <schwab@linux-m68k.org>
208
209 * callint.c (Fcall_interactively): Don't truncate prompt string.
210
d048e1e6
EZ
2112011-12-23 Eli Zaretskii <eliz@gnu.org>
212
213 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
214 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 215 resumed from there (after widening). (Bug#10360)
d048e1e6 216
5ccaba1f
JD
2172011-12-22 Jan Djärv <jan.h.d@swipnet.se>
218
219 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
220
204ee57f
JD
2212011-12-21 Jan Djärv <jan.h.d@swipnet.se>
222
b81d40f0
JB
223 * nsterm.m (x_free_frame_resources):
224 Release f->output_data.ns->miniimage.
204ee57f
JD
225 (ns_index_color): Fix indentation. Do not retain
226 color_table->colors[i].
227
228 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
229 before returning.
230
231 * nsfns.m (x_set_background_color): Assign return value from
232 ns_index_color to face-background instead of NSColor*.
233 (ns_implicitly_set_icon_type): Fix indentation.
234 Change assignment in for loop to comparison.
235
236 * emacs.c (ns_pool): New variable.
237 (main): Assign ns_pool.
238 (Fkill_emacs): Call ns_release_autorelease_pool.
239
240 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
241 autorelease fdesc, release fdAttrs and tdict.
242 (ns_get_covering_families): Release charset.
243 (ns_findfonts): Release NSFontDescriptor created with new.
244 (ns_uni_to_glyphs): Fix indentation.
245 (setString): Release attrStr before assigning new value.
246
c803b2b7
JD
2472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
248
678f4426
JD
249 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
250 and NS_IMPL_COCOA.
251 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
252 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
253
cd394be1 2542011-12-18 David Reitter <reitter@cmu.edu>
678f4426 255
5fecd5fc
JD
256 * nsterm.m (ns_term_init): Subscribe for notifications
257 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
258 to method trackingNotification in EmacsMenu.
259
260 * nsmenu.m (trackingMenu): New variable.
3771cb17 261 (trackingNotification): New method (from Aquamacs).
5fecd5fc 262 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 263 from Aquamacs (Bug#7030).
678f4426
JD
264
2652011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 266
c803b2b7
JD
267 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
268 (symbol_to_nsstring): Fix indentation.
269 (ns_symbol_to_pb): New function.
270 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
271 (Fns_rotate_cut_buffers_internal): Removed.
272 (Fns_store_selection_internal): Renamed from
273 Fns_store_cut_buffer_internal.
274 (ns_get_foreign_selection, Fx_own_selection_internal)
275 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
276 (Fns_get_selection_internal, Fns_store_selection_internal):
277 Use ns_symbol_to_pb and check if return value is nil.
278 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
279 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
280 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
281 renamed to Sns_store_selection_internal.
282 (ns_handle_selection_request): Move code to Fx_own_selection_internal
283 and remove this function.
284 (ns_handle_selection_clear): Remove, never used.
285 (Fx_own_selection_internal): Move code from ns_handle_selection_request
286 here.
287
e1b01a3a
KB
2882011-12-17 Ken Brown <kbrown@cornell.edu>
289
290 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
291 GID is unknown (Bug#10257).
292
2adb6e85
PE
2932011-12-17 Paul Eggert <eggert@cs.ucla.edu>
294
295 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
296 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
297 which caused a build failure on GNU/Linux IA-64. This problem was
298 introduced by my 2011-10-07 patch.
299
d1d7b339
JL
3002011-12-15 Juri Linkov <juri@jurta.org>
301
302 * image.c (imagemagick_error): New function. (Bug#10112)
303 (imagemagick_load_image): Comment out `MagickSetResolution' call.
304 Use `imagemagick_error' where ImageMagick functions return
305 `MagickFalse'.
306 (Fimagemagick_types): Add `Fnreverse' to return the list in the
307 proper order.
308
100d5755
KH
3092011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
310
311 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
312 fill background (Bug#8992).
313
454592a6
MR
3142011-12-13 Martin Rudalics <rudalics@gmx.at>
315
316 * window.c (Vwindow_combination_resize)
317 (Vwindow_combination_limit): Use t instead of non-nil in
318 doc-strings.
61d4b438
MR
319 (Vrecenter_redisplay): Add first sentence of doc-string on
320 separate line.
53524d93 321 (Frecenter): Fix doc-string typo.
454592a6 322
3633e3aa
KH
3232011-12-11 Kenichi Handa <handa@m17n.org>
324
325 * coding.c (Funencodable_char_position): Pay attention to the
326 buffer text relocation (Bug#9389).
327
7b9d523a
JD
3282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
329
330 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
331 gtk_init (Bug#10100).
332
b73189c6
EZ
3332011-12-10 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
336 IT->string is nil. (Bug#10263)
337
f7dfe5d6
JD
3382011-12-10 Jan Djärv <jan.h.d@swipnet.se>
339
83faebb4
JD
340 * nsterm.h (x_free_frame_resources): Declare.
341
f7dfe5d6
JD
342 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
343 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
344
345 * nsterm.h (ns_get_defaults_value): Declare.
346
347 * nsterm.m (ns_default): Call ns_get_defaults_value.
348
7cd4e72c
EZ
3492011-12-09 Eli Zaretskii <eliz@gnu.org>
350
351 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
352 (Bug#10170)
353
b34d7317
YM
3542011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
355
356 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
357 that where the value of an _OBJC_* symbol points to is in the .bss
358 section (Bug#10240).
359
76470ad1
KH
3602011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
361
362 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 363 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 364
745fff94
KH
3652011-12-08 Kenichi Handa <handa@m17n.org>
366
367 * ftfont.c (get_adstyle_property): Fix previous change
368 (Bug#10233).
369
6e44397c
JB
3702011-12-07 Juanma Barranquero <lekktu@gmail.com>
371
372 * w32.c (init_environment): If no_site_lisp, remove site-lisp
373 dirs from the default value of EMACSLOADPATH (bug#10208).
374
7efa6272
GM
3752011-12-07 Glenn Morris <rgm@gnu.org>
376
377 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
378 installation and source directories as well. (Bug#10208)
379
f6fc4d87
CY
3802011-12-06 Chong Yidong <cyd@gnu.org>
381
382 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
383
2bf26180
GM
3842011-12-06 Glenn Morris <rgm@gnu.org>
385
386 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
387 as an error, not just -1. (Bug#10217)
388
3a6ad4f0
CY
3892011-12-05 Chong Yidong <cyd@gnu.org>
390
391 * keyboard.c (process_special_events): New function.
392 (swallow_events, Finput_pending_p): Use it (Bug#10195).
393
75a3b399
PE
3942011-12-05 Paul Eggert <eggert@cs.ucla.edu>
395
396 * coding.c (encode_designation_at_bol): Don't use uninitialized
397 local variable (Bug#9318).
398
c3c9e25e
KH
3992011-12-05 Kenichi Handa <handa@m17n.org>
400
401 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
402 return Qnil (Bug#8046, Bug#10193).
403
5eb05ea3
KH
4042011-12-05 Kenichi Handa <handa@m17n.org>
405
406 * coding.c (encode_designation_at_bol): New args charbuf_end and
407 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
408 (coding_set_source): Return how many bytes coding->source was
409 relocated.
410 (coding_set_destination): Return how many bytes
411 coding->destination was relocated.
412 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
413 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
414
4152011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
416
417 * coding.c (CODING_CHAR_CHARSET_P): New macro.
418 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
419 macro (Bug#9318).
420
4212011-12-05 Andreas Schwab <schwab@linux-m68k.org>
422
423 The following changes are to fix Bug#9318.
424
a79703f5 425 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
426 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
427 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 428 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 429
7dbda6df
JB
4302011-12-05 Juanma Barranquero <lekktu@gmail.com>
431
432 * lisp.h (process_quit_flag): Fix external declaration.
433
6d5eb5b0
SM
4342011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
435
436 Don't macro-inline non-performance-critical code.
437 * eval.c (process_quit_flag): New function.
438 * lisp.h (QUIT): Use it.
439
a0c3fad0
JD
4402011-12-04 Jan Djärv <jan.h.d@swipnet.se>
441
442 * nsfns.m (get_geometry_from_preferences): New function.
443 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
444
6c07aac2
AS
4452011-12-04 Andreas Schwab <schwab@linux-m68k.org>
446
447 * emacs.c (Qkill_emacs): Define.
448 (syms_of_emacs): Initialize it.
449 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
450 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
451 (quit_throw_to_read_char): Add parameter `from_signal'.
452 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
453 * lisp.h (QUIT): Call Fkill_emacs if requested.
454
c052ead4
JD
4552011-12-03 Jan Djärv <jan.h.d@swipnet.se>
456
457 * widget.c (update_wm_hints): Return if wmshell is null.
458 (widget_update_wm_size_hints): New function.
459
460 * widget.h (widget_update_wm_size_hints): Declare.
461
462 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
463 widget_update_wm_size_hints (Bug#10104).
464
9e49252b
EZ
4652011-12-03 Eli Zaretskii <eliz@gnu.org>
466
467 * xdisp.c (handle_invisible_prop): If the invisible text ends just
468 before a newline, prepare the bidi iterator for consuming the
469 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 470 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 471
02b16839
JL
4722011-12-02 Juri Linkov <juri@jurta.org>
473
474 * search.c (Fword_search_regexp): New Lisp function created from
475 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
476 (Fword_search_backward, Fword_search_forward)
477 (Fword_search_backward_lax, Fword_search_forward_lax):
478 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
479 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
480
0068070e
SM
4812011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
482
483 * fileio.c (Finsert_file_contents): Move after-change-function call
484 to before the "handled:" label, since all "goto handled" appear in
485 cases where the *-change-functions have already been properly called
486 (bug#10117).
487
3360a3fc
AS
4882011-12-01 Andreas Schwab <schwab@linux-m68k.org>
489
490 * keyboard.c (interrupt_signal): Don't call kill-emacs when
491 waiting for input. (Bug#10169)
492
73d6c093
EZ
4932011-11-30 Eli Zaretskii <eliz@gnu.org>
494
495 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
496 verifies glyph row's hash code--we have just reallocated the
497 glyphs, so their contents can be complete garbage. (Bug#10164)
498
febe6bea
JB
4992011-11-30 Juanma Barranquero <lekktu@gmail.com>
500
501 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
502
801a4313
EZ
5032011-11-30 Eli Zaretskii <eliz@gnu.org>
504
505 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
506 attributes are tested _before_ calling verify_row_hash, to protect
507 against GCC re-ordering of the tests. (Bug#10164)
508
2b56b87e
JD
5092011-11-29 Jan Djärv <jan.h.d@swipnet.se>
510
511 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
512
513 * xterm.c (handle_one_xevent): Only set async_visible and friends
514 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 515 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
516 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
517
dbf31225
PE
5182011-11-28 Paul Eggert <eggert@cs.ucla.edu>
519
520 Remove GCPRO-related macros that exist only to avoid shadowing locals.
521 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
522 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
523 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
524 All uses changed to use GCPRO1 etc.
525 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
526 Revert to old implementation (i.e., before 2011-03-11).
527
1305621b
YM
5282011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
529
530 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
531 of scroll runs so as to avoid assigning disabled bogus rows and
532 unnecessary graphics copy operations.
533
8c9afb46
EZ
5342011-11-27 Eli Zaretskii <eliz@gnu.org>
535
536 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
537 (snprintf) [_MSC_VER]: Redirect to _snprintf.
538 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
539 (malloc, free, realloc, calloc): Redirect to e_* only when
540 compiling Emacs.
541
542 * lisp.h (GCTYPEBITS): Move before first use.
543 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
544 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
545 this macro definition.
546
547 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
548 _MSC_VER.
549
54e9e3bf
JD
5502011-11-27 Jan Djärv <jan.h.d@swipnet.se>
551
6d5eb5b0
SM
552 * gtkutil.c (xg_create_frame_widgets):
553 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
554 present with Gtk+ 2.0.
555
83aca1cb
PE
5562011-11-26 Paul Eggert <eggert@cs.ucla.edu>
557
558 * fileio.c (Finsert_file_contents): Undo previous change; see
559 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
560
5b76caa4
PE
5612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
562
563 Rename locals to avoid shadowing.
564 * fileio.c (Finsert_file_contents):
565 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
566 * process.c (wait_reading_process_output):
567 Rename inner 'proc' to 'p' to avoid shadowing.
568 Indent for consistency with usual Emacs style.
569
8c535114
EZ
5702011-11-25 Eli Zaretskii <eliz@gnu.org>
571
572 * xdisp.c (redisplay_window): If cursor row is not fully visible
573 after recentering, and scroll-conservatively is set to a large
574 number, scroll window by a few more lines to make the cursor fully
575 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
576 (start_display): Don't move to the next line if the display should
577 start at a newline that is part of a display vector or an overlay
578 string. (Bug#10119)
8c535114 579
fa4fdb5c
JL
5802011-11-24 Juri Linkov <juri@jurta.org>
581
582 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
583 after the `MagickPingImage' call. (Bug#10112)
584
90ec88df
CY
5852011-11-23 Chong Yidong <cyd@gnu.org>
586
587 * window.c (Fcoordinates_in_window_p): Accept only live windows.
588
56e2e794
MR
5892011-11-23 Martin Rudalics <rudalics@gmx.at>
590
591 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
592 making another buffer current. (Bug#10114)
593
b6e64c41
GM
5942011-11-23 Glenn Morris <rgm@gnu.org>
595
596 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
597
6b21de18
CY
5982011-11-23 Chong Yidong <cyd@gnu.org>
599
600 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
601 using it (Bug#5984).
602
b12cd789
EZ
6032011-11-22 Eli Zaretskii <eliz@gnu.org>
604
605 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
606 and header-lines, as they don't have one computed for them.
607 (Bug#10098)
608
609 * .gdbinit (prow): Make displayed values more self-explaining.
610 Add row's hash code.
611
261b6fd4
LMI
6122011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
613
614 * process.c (wait_reading_process_output): Fix asynchrounous
615 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 616 (wait_reading_process_output): Add comment and URL.
261b6fd4 617
e7cfd277
JD
6182011-11-21 Jan Djärv <jan.h.d@swipnet.se>
619
620 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
621
a9b9b7f5
CY
6222011-11-21 Chong Yidong <cyd@gnu.org>
623
624 * window.c (Fnext_window, Fprevious_window): Doc fix.
625
b0d15b4f
SM
6262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
627
628 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
629
fe7a3057
JB
6302011-11-20 Juanma Barranquero <lekktu@gmail.com>
631
632 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
633
d2999b1a
MR
6342011-11-20 Martin Rudalics <rudalics@gmx.at>
635
636 * window.c (Fset_window_combination_limit): Rename argument
637 STATUS to LIMIT.
638 (Vwindow_combination_limit): Remove "status" from doc-string.
639
d5ff9cd0
AS
6402011-11-20 Andreas Schwab <schwab@linux-m68k.org>
641
642 * m/ibms390.h: Remove.
643 * m/ibms390x.h: Don't include "ibms390.h".
644
a5bb9bd3
SM
6452011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
646
647 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
648 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
649
cd1181db
JB
6502011-11-20 Juanma Barranquero <lekktu@gmail.com>
651
652 * casetab.c (Fset_case_table):
653 * charset.c (Fcharset_after): Fix typos.
654
615a3b8d 6552011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 656
17e845af
PE
657 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
658 Otherwise, valgrind does not work on some platforms.
659 Problem reported by Andreas Schwab in
6a0bf43d
PE
660 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
661 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
662 is set, removing the need for VIRT_ADDRESS_VARIES.
663 (PURE_P): Use a more-efficient implementation that needs just one
664 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
665 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
666 to 4 (xorl, subq, cmpq, setbe).
667 * alloc.c (pure): Always extern now, since that's the
668 VIRT_ADDR_VARIES behavior.
669 (PURE_POINTER_P): Use a single comparison, not two, for
670 consistency with the new puresize.h.
671 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
672 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
673 Remove VIRT_ADDR_VARIES no longer needed.
674
f8fe6f96
EZ
6752011-11-19 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
678 (erase_phys_cursor, update_window_cursor, show_mouse_face)
679 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
680 behave as if the cursor position were at the window margin.
681
682 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
683 and the cursor position is out of bounds, behave as if the cursor
684 position were at the window margin. (Bug#10075)
685
df05a53c
CY
6862011-11-18 Chong Yidong <cyd@gnu.org>
687
688 * window.c (Fwindow_combination_limit): Make first argument
689 non-optional, since it is meaningless for live windows like the
690 selected window.
691
2071918e
DA
6922011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
693
694 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
695
b50a28de
SM
6962011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
697
698 * intervals.c: Fix grafting over the whole buffer (bug#10071).
699 (graft_intervals_into_buffer): Simplify.
700
015137db
EZ
7012011-11-18 Eli Zaretskii <eliz@gnu.org>
702
703 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
704 hash values of the two rows.
705 (copy_row_except_pointers): Preserve the used[] arrays and the
706 hash values of the two rows. (Bug#10035)
68c95424 707 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
708
709 * xdisp.c (row_hash): New function, body extracted from
710 compute_line_metrics.
711 (compute_line_metrics): Call row_hash, instead of computing the
712 hash code inline.
713
714 * dispnew.c (verify_row_hash): Call row_hash for computing the
715 hash code of a row, instead of duplicating code from xdisp.c.
716
717 * dispextern.h (row_hash): Add prototype.
718
a2addb04
TH
7192011-11-18 Tassilo Horn <tassilo@member.fsf.org>
720
721 * frame.c (delete_frame): Don't delete the terminal when the last
722 X frame is closed if emacs is built with GTK toolkit.
723
df85d315
JB
7242011-11-17 Juanma Barranquero <lekktu@gmail.com>
725
726 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
727
a0c2d0ae
MR
7282011-11-17 Martin Rudalics <rudalics@gmx.at>
729
730 * window.c (Vwindow_splits): Rename to
731 Vwindow_combination_resize. Suggested by Juri Linkov.
732 (Fsplit_window_internal): Use Vwindow_combination_resize instead
733 of Vwindow_splits.
734
58179cce
JB
7352011-11-16 Juanma Barranquero <lekktu@gmail.com>
736
7877f373
JB
737 * nsfns.m (Fns_font_name):
738 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 739
b6f67890
MR
7402011-11-16 Martin Rudalics <rudalics@gmx.at>
741
742 * window.h (window): Rename slot "nest" to "combination_limit".
743 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
744 (Fset_window_nest): Rename to Fset_window_combination_limit.
745 (Vwindow_nest): Rename to Vwindow_combination_limit.
746 (recombine_windows, make_parent_window, make_window)
747 (Fsplit_window_internal, saved_window)
748 (Fset_window_configuration, save_window_save): Rename all
749 occurrences of window_nest to window_combination_limit.
750
c7015153
JB
7512011-11-15 Juanma Barranquero <lekktu@gmail.com>
752
753 * image.c (imagemagick_load_image): Fix typo.
754
322ad6ec
EZ
7552011-11-14 Eli Zaretskii <eliz@gnu.org>
756
757 * xdisp.c (display_line): Move the call to
758 highlight_trailing_whitespace before the call to
759 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
760 faces of all the glyphs to compute ROW's hash value.
761 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 762
f067b8ec
JB
7632011-11-14 Juanma Barranquero <lekktu@gmail.com>
764
765 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
766 just return (bug#10044).
767
1e5b2111
EZ
7682011-11-12 Eli Zaretskii <eliz@gnu.org>
769
7ef3cbd5
EZ
770 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
771 with user-defined heap size. Bump the default size of the temacs
772 heap to 27MB, to avoid memory warning when running temacs.
773 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
774
1e5b2111
EZ
775 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
776 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
777 (verify_row_hash) [XASSERTS]: New function.
778 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
779 that the hash value of glyph rows is correct.
1e5b2111 780
89d61221
MR
7812011-11-12 Martin Rudalics <rudalics@gmx.at>
782
783 * window.h (window): Remove splits slot.
784 * window.c (Fwindow_splits, Fset_window_splits): Remove.
785 (Fdelete_other_windows_internal, make_parent_window)
786 (make_window, Fsplit_window_internal, Fdelete_window_internal)
787 (Fset_window_configuration, save_window_save): Don't deal with
788 split status of windows.
789 (saved_window): Remove splits slot.
790 (Vwindow_splits): Rewrite doc-string.
791
97f18cc8
JD
7922011-11-11 Jan Djärv <jan.h.d@swipnet.se>
793
794 * xfns.c (unwind_create_frame):
795 * nsfns.m (unwind_create_frame):
796 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
797 Vframe_list (Bug#9999).
798
22a648b4
DA
7992011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
800
0b381c7e 801 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 802
659afede
KH
8032011-11-11 Kenichi Handa <handa@m17n.org>
804
805 * callproc.c (Fcall_process): Set the member dst_multibyte of
806 process_coding.
807
9ac0394b
KH
8082011-11-11 Johan Bockgård <bojohan@gnu.org>
809
810 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
811 avoid a crash (bug#9496).
812
2fbdc249
CY
8132011-11-09 Chong Yidong <cyd@gnu.org>
814
815 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
816 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
817
ac6b1f81
PE
8182011-11-08 Paul Eggert <eggert@cs.ucla.edu>
819
820 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
821
09db192c
PE
8222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
823
824 Avoid some portability problems by eschewing 'extern inline' functions.
825 The trivial performance wins aren't worth the portability hassles; see
826 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
827 et seq.
828 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
829 (window_box_width, window_box_left, window_box_left_offset)
830 (window_box_right, window_box_right_offset): Undo previous change,
831 by removing the "extern"s.
832 * intervals.c (adjust_intervals_for_insertion)
833 (adjust_intervals_for_deletion): Undo previous change,
834 making these static again.
835 (offset_intervals, temp_set_point_both, temp_set_point)
836 (copy_intervals_to_string): No longer inline.
837 * xdisp.c (window_text_bottom_y, window_box_width)
838 (window_box_height, window_box_left_offset)
839 (window_box_right_offset, window_box_left, window_box_right)
840 (window_box): No longer inline.
841
105216ed
CY
8422011-11-08 Chong Yidong <cyd@gnu.org>
843
844 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
845 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
846 Signal an error if not a live window.
105216ed
CY
847 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
848 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
849
ae9e237f
JB
8502011-11-07 Juanma Barranquero <lekktu@gmail.com>
851
852 * lisp.h (syms_of_abbrev): Remove declaration.
853 Reported by CHENG Gao <chenggao@royau.me>.
854
c7aa8333
EZ
8552011-11-07 Eli Zaretskii <eliz@gnu.org>
856
857 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
858 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
859 of temacs in GUI mode.
860
be7f5545
MR
8612011-11-07 Martin Rudalics <rudalics@gmx.at>
862
863 * window.h: Declare delete_all_child_windows instead of
864 delete_all_subwindows.
865 * window.c (Fwindow_nest, Fset_window_nest)
866 (Fset_window_new_total, Fset_window_new_normal)
867 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
868 (delete_all_subwindows): Rename to delete_all_child_windows.
869 (Fdelete_other_windows_internal, Fset_window_configuration):
870 Call delete_all_child_windows instead of delete_all_subwindows.
871 * frame.c (delete_frame): Call delete_all_child_windows instead
872 of delete_all_subwindows.
873
ca78dc43
PE
8742011-11-07 Paul Eggert <eggert@cs.ucla.edu>
875
876 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
877 This is also needed for porting to any host where GC_MARK_STACK is
878 not GC_MAKE_GCPROS_NOOPS.
879 (which_symbols): Use it.
880
a0241d01
KH
8812011-11-07 Kenichi Handa <handa@m17n.org>
882
883 * coding.c (coding_set_destination): Check coding->src_pos only
884 when coding->src_object is a buffer (bug#9910).
885
886 * process.c (send_process): Set the member src_multibyte of coding
887 to 0 (bug#9911) when sending a unibyte text.
888
889 * callproc.c (Fcall_process): Set the member src_multibyte of
890 process_coding to 0 (bug#9912).
891
a64bfdfa 8922011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
893
894 * xmenu.c (cleanup_widget_value_tree): New function.
895 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
896 calling free_menubar_widget_value_tree directly (Bug#9830).
897
cb41b32a
PE
8982011-11-06 Paul Eggert <eggert@cs.ucla.edu>
899
900 Fix some portability problems with 'inline'.
901 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
902 (window_box_width, window_box_left, window_box_left_offset)
903 (window_box_right, window_box_right_offset): Declare extern.
904 Otherwise, these inline functions do not conform to C99 and
905 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
906 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
907 * intervals.c (adjust_intervals_for_insertion)
908 (adjust_intervals_for_deletion): Now extern, because otherwise the
909 extern inline functions 'offset_intervals' couldn't refer to it.
910 (static_offset_intervals): Remove.
911 (offset_intervals): Rewrite using the old contents of
912 static_offset_intervals. The old version didn't conform to C99
913 because an extern inline function contained a reference to an
914 identifier with static linkage.
915
b7041366
AS
9162011-11-06 Andreas Schwab <schwab@linux-m68k.org>
917
918 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
919 GC.
920
88a37c4d
EZ
9212011-11-06 Eli Zaretskii <eliz@gnu.org>
922
923 * xdisp.c (init_iterator, reseat_to_string): Don't set the
924 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
925 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
926 return Qleft_to_right.
927
49745b39
CY
9282011-11-06 Chong Yidong <cyd@gnu.org>
929
930 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
931 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
932 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
933 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
934 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
935 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
936 (Fwindow_vscroll): Doc fix.
937 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
938 argument, since it makes no sense to pass a live window and for
939 consistency with window-child.
940
1f05cd82
CS
9412011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
942
943 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
944 support MSVC.
945
22610910
JR
9462011-11-05 Jason Rumney <jasonr@gnu.org>
947
948 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
949 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
950 fonts (Bug#6029).
951 (add_font_entity_to_list): Fix logic errors in mixed boolean and
952 bitwise arithmetic preventing use of unicode-sip and non-truetype
953 opentype fonts.
954
a06776b2
EZ
9552011-11-05 Eli Zaretskii <eliz@gnu.org>
956
3ad924ba
EZ
957 * s/ms-w32.h (fstat, stat, utime): Move redirections to
958 "emacs"-only part.
959
a06776b2
EZ
960 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
961 initialization code to keep similarity to xfns.c after changes
962 from 2011-11-05.
963
c9e7db78
JD
9642011-11-05 Jan Djärv <jan.h.d@swipnet.se>
965
a97f8f3f
JD
966 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
967 (unwind_create_frame): New function (Bug#9943).
968 (Fx_create_frame): Restructure code to be more similar to the one in
969 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
970 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
971 Move terminal->reference_count++ just before making the frame official
972 (Bug#9943).
973
974 * nsterm.m (x_free_frame_resources): New function.
975 (x_destroy_window): Move code to x_free_frame_resources.
976
c9e7db78 977 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
978 (Fx_create_frame, x_create_tip_frame):
979 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
980 official. Move initialization of image_cache_refcount and
981 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
982
a6fc3b5c
EZ
9832011-11-05 Eli Zaretskii <eliz@gnu.org>
984
985 Support MSVC build with newer versions of Visual Studio.
986 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
987 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
988 nt/gmake.defs.
989
990 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
991 which are not supported by MSVC.
992 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
993 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
994 bitfields.
995 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
996 types in bitfields.
997 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
998
999 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1000
58179cce 10012011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1002
1003 Support MSVC build with newer versions of Visual Studio.
1004 * w32.c: Don't include w32api.h for MSVC.
1005 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1006
1007 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1008 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1009 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1010 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1011 e_* cousins.
1012 (alloca) [_MSC_VER]: Define to _alloca.
1013
1014 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1015
1016 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1017
a58c13ed
EZ
10182011-11-04 Eli Zaretskii <eliz@gnu.org>
1019
1020 * xdisp.c (note_mouse_highlight): If either of
1021 previous/next-single-property-change returns nil, treat that as
1022 the beginning or the end of the buffer. (Bug#9955)
1023
fe0b6370
JD
10242011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1025
a58c13ed 1026 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1027 label is not null (Bug#9951).
1028 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1029 may be NULL.
1030
89bd5ee1
EZ
10312011-11-04 Eli Zaretskii <eliz@gnu.org>
1032
1033 * window.c (Fwindow_body_size): Mention in the doc string that the
1034 return value is in frame's canonical units. (Bug#9949)
1035
84c3edb9
EZ
10362011-11-03 Eli Zaretskii <eliz@gnu.org>
1037
4e2fb5c7
EZ
1038 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1039
84c3edb9 1040 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1041 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1042 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1043
bc17a887
EZ
10442011-11-01 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1047 Don't stop backward scan on the continuation glyph, even though
1048 its CHARPOS is positive.
6d5eb5b0
SM
1049 (mouse_face_from_buffer_pos, note_mouse_highlight):
1050 Rename cover_string to disp_string.
bc17a887 1051
4ee88440
MR
10522011-11-01 Martin Rudalics <rudalics@gmx.at>
1053
1054 * window.c (temp_output_buffer_show): Don't use
1055 Vtemp_buffer_show_specifiers.
1056 (Vtemp_buffer_show_specifiers): Remove unused variable.
1057
c2ff3c02
EZ
10582011-10-30 Eli Zaretskii <eliz@gnu.org>
1059
1060 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1061 past the beginning of the current glyph matrix.
1062
58179cce 10632011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1064
1065 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1066 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1067 HAVE_GTK3 (Bug#9869).
b77a6a7f 1068
3b574623
JD
1069 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1070 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1071
b77a6a7f
JD
1072 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1073
1074 * xterm.c: Declare x_handle_net_wm_state to return int.
1075 (handle_one_xevent): Check if we are iconified but don't have
1076 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1077 (get_current_wm_state): Return non-zero if not hidden,
1078 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1079 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1080 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1081 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1082
196e41e4
PE
10832011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1086 so that this new function doesn't get optimized away by a
1087 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1088
021f2e1a
AS
10892011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1090
1091 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1092
8b058d44
EZ
10932011-10-29 Eli Zaretskii <eliz@gnu.org>
1094
1095 Fix the `xbytecode' command.
1096 * .gdbinit (xprintbytestr): New command.
b50a28de 1097 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1098 (xbytecode): Print the byte-code string as well.
1099
4452fb80
EZ
11002011-10-29 Kim Storm <storm@cua.dk>
1101
8b058d44
EZ
1102 * alloc.c (which_symbols): New function.
1103
21b72067
AS
11042011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1105
1106 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1107 line. (Bug#9903)
1108
83ed7b5c
GM
11092011-10-29 Glenn Morris <rgm@gnu.org>
1110
1111 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1112 Not clear what it was for, and it causes various bugs. (Bug#9839)
1113
5a7a728b
EZ
11142011-10-28 Eli Zaretskii <eliz@gnu.org>
1115
1116 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1117 possible random value that matches one of those tested as
1118 condition to clear the mouse face.
1119
d3d0842f
CY
11202011-10-28 Chong Yidong <cyd@gnu.org>
1121
1122 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1123
31b39d13
DN
11242011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1125
1126 * window.c (make_window): Initialize phys_cursor_on_p.
1127
9aba6043
SM
11282011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1129
1130 * lisp.h (struct Lisp_Symbol): Update comments.
1131
c20992f4
JB
11322011-10-28 Juanma Barranquero <lekktu@gmail.com>
1133
1134 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1135
db4f02f2
EZ
11362011-10-28 Eli Zaretskii <eliz@gnu.org>
1137
1138 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1139 <oslsachem@gmail.com> for helping to debug this.
1140
1141 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1142 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1143 (g_b_init_get_glyph_outline_w): New static variables.
1144 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1145 (GetGlyphOutlineW_Proc): New typedefs.
1146 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1147 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1148 New functions.
1149 (w32font_open_internal, compute_metrics):
1150 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1151 instead of calling the "wide" APIs directly.
1152
1153 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1154
1155 * w32.h (syms_of_w32font): Add prototype.
1156
87e68db4
JB
11572011-10-27 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1160 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1161 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1162 (Fmove_to_window_line): Doc fix.
1163
435c1d67
CY
11642011-10-27 Chong Yidong <cyd@gnu.org>
1165
1166 * process.c (make_process): Set gnutls_state to NULL.
1167
1168 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1169 non-NULL, regardless of GNUTLS_INITSTAGE.
1170 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1171 an error. Set process slots as soon as we allocate them.
1172
1173 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1174
9c6c6f49
CY
11752011-10-27 Chong Yidong <cyd@gnu.org>
1176
9aba6043
SM
1177 * gnutls.c (emacs_gnutls_deinit): New function.
1178 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1179 (Fgnutls_deinit, Fgnutls_boot): Use it.
1180
1181 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1182 (deactivate_process): Call emacs_gnutls_deinit.
1183
657d08d3
JB
11842011-10-27 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * image.c (x_create_x_image_and_pixmap):
1187 * w32.c (sys_rename, w32_delayed_load):
1188 * w32font.c (fill_in_logfont):
1189 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1190
5430d399
JB
11912011-10-26 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * w32fns.c (w32_default_color_map): New function,
1194 extracted from Fw32_default_color_map.
a7ef684b 1195 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1196
fe0055fa
PE
11972011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1200
e6346438
SM
12012011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1202
1203 * keyboard.c (test_undefined): New function (bug#9751).
1204 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1205
e112cc37
ET
12062011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1207
1208 * sysdep.c (init_sys_modes): Fix the check for the controlling
1209 terminal (Bug#6649).
1210
7b5d6677
EZ
12112011-10-20 Eli Zaretskii <eliz@gnu.org>
1212
1213 * dispextern.h (struct bidi_it): New member next_en_type.
1214
1215 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1216 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1217 current character, check also for next_en_type being WEAK_EN.
1218 (bidi_resolve_weak): Don't enter the expensive loop if the current
1219 position is before next_en_pos. Record the bidi type of the first
1220 non-ET, non-BN character we find, in addition to its position.
1221 (bidi_level_of_next_char): Invalidate next_en_type when
1222 next_en_pos is over-stepped.
1223
7da0b018
PE
12242011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1227 * editfns.c: Rewrite current-time-zone so that it invokes
1228 the equivalent of (format-time-string "%Z") to get the time zone name.
1229 This fixes a bug when the time zone name contains characters that
1230 need converting from the system time locale to Emacs internal format.
1231 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1232 that patch fixed format-time-string to do the conversion, but
1233 I forgot to fix current-time-zone.
1234 (format_time_string): New function, containing most of
1235 what Fformat_time_string used to contain.
1236 (Fformat_time_string): Rewrite in terms of format_time_string.
1237 This doesn't change this function's behavior.
1238 (current-time-zone): Rewrite to use format_time_string.
1239 This fixes the bug reported by Michael Schierl in
1240 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1241 Jason Rumney's 2007-06-07 change worked around this bug, but
1242 didn't fix it.
1243 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1244
8547b010
EZ
12452011-10-19 Eli Zaretskii <eliz@gnu.org>
1246
1247 * xdisp.c (start_display): If the character at POS is displayed
1248 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1249 (try_window_reusing_current_matrix): If a line ends in a display
1250 vector or the next line starts in a display vector, continue
1251 redrawing the window even though the character position of
1252 start_row was reached.
8547b010
EZ
1253 (Bug#9771, part 2)
1254
4e948d15
CY
12552011-10-18 Chong Yidong <cyd@gnu.org>
1256
1257 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1258 with nobreak-char-display too.
1259
4787455f
EZ
12602011-10-18 Eli Zaretskii <eliz@gnu.org>
1261
1262 Fix part 3 of bug#9771.
1263 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1264 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1265 non-neutral characters if the current character is a paragraph
1266 separator (a.k.a. Newline). This avoids running the same
1267 expensive loop twice, once when we consume the preceding newline
1268 and the other time when the line actually needs to be displayed.
1269 Avoid the loop when we see neutrals on the base embedding level
1270 following a character whose directionality is the same as the
1271 paragraph's. This avoids running the expensive loop when a line
1272 ends in a long sequence of neutrals, like control characters.
1273 Add assertion against STRONG_AL type. Slightly rearrange code
1274 that determines the type of a neutral given the first non-neutral
1275 that follows it.
1276 (bidi_level_of_next_char): Set next_en_pos to zero when
1277 invalidating its info.
1278
2c91f553
EZ
12792011-10-17 Eli Zaretskii <eliz@gnu.org>
1280
1281 * xdisp.c (push_display_prop): Determine whether to record string
1282 or buffer position by IT->string, not by IT->method. Allow
1283 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1284 (move_it_vertically_backward): Don't look for character position
1285 immediately after the newline when in a continuation line.
1286 (Bug#9771, part 1)
2c91f553 1287
c7b08b0d
MR
12882011-10-15 Martin Rudalics <rudalics@gmx.at>
1289
1290 * window.c (coordinates_in_window): Rewrite and delabelize
1291 vertical border check. (Bug#5357) (Bug#9618)
1292
6b02f655
SM
12932011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1296 errors in XSetWindowBorder (bug#9310).
1297
81d40c92
DA
12982011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1301 avoid crash when xmalloc overrun checking is enabled.
1302
d4172c3b
EZ
13032011-10-13 Eli Zaretskii <eliz@gnu.org>
1304
1305 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1306 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1307 cursor motion with <left> and <right> arrow keys.
1308
1309 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1310 some callers set that themselves.
1311
b00eea75
EZ
13122011-10-12 Eli Zaretskii <eliz@gnu.org>
1313
1314 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1315 display string and the previous row comes from the same string and
1316 is empty. (Bug#9739) (Bug#9738)
1317
8fe012c4
SM
13182011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1319
1320 * doc.c (get_doc_string): Encode file name (bug#9735).
1321
0074aef2
EZ
13222011-10-12 Eli Zaretskii <eliz@gnu.org>
1323
79beb178
EZ
1324 * bidi.c (bidi_level_of_next_char):
1325 * xdisp.c (get_visually_first_element): Remove old incorrect
1326 comments regarding the Unicode Line Separator character.
1327
0074aef2
EZ
1328 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1329
6e4b3fbe
DA
13302011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1331
1332 * alloc.c (Fgc_status): Do not access beyond zombies array
1333 boundary if nzombies > MAX_ZOMBIES.
1334 * alloc.c (dump_zombies): Add missing format specifier.
1335
0324f3af
PE
13362011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1337
b5525cac
PE
1338 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1339 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1340
0324f3af
PE
1341 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1342 Some packages use them to denote characters with modifiers.
1343
e9b5f888
AS
13442011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1345
1346 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1347 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1348 matching a pp-number. Rename parameter var to var1.
1349
127827c0
SM
13502011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1351
1352 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1353
c8fd3bd0
GM
13542011-10-08 Glenn Morris <rgm@gnu.org>
1355
1356 * callint.c (Fcall_interactively): Give a more explicit error for the
1357 'c' case with a non-character input. (Bug#8479)
1358
352ec8ff
EZ
13592011-10-08 Eli Zaretskii <eliz@gnu.org>
1360
03669ccb
EZ
1361 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1362 lines.
7061c986
EZ
1363 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1364 lines that are hscrolled on the left.
03669ccb 1365
352ec8ff
EZ
1366 * dispnew.c (buffer_posn_from_coords): Account for a possible
1367 presence of header-line. (Bug#4426)
1368
a66cfb1c
SM
13692011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1370
6b02f655
SM
1371 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1372 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1373
7c5ee88e
PE
13742011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1377 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1378 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1379 this makes Emacs dump core during garbage collection on rare
1380 occasions. sizeof is obviously inferior to offsetof here, so
1381 stick with offsetof.
1382 (GC_POINTER_ALIGNMENT): New macro.
1383 (mark_memory): Omit 3rd (offset) arg; caller changed.
1384 Don't assume EMACS_INT alignment is the same as pointer alignment.
1385
df1bbe5b
SM
13862011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1387
1388 * keyboard.c (read_key_sequence_remapped): New var.
1389 (read_key_sequence): Compute remapping in the right buffer.
1390 (command_loop_1): Use read_key_sequence's remapping directly.
1391
51553db6
SM
13922011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1393
32c1fffd
SM
1394 * dired.c (file_name_completion): Don't expand file name.
1395 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1396 before checking file name handler.
1397
51553db6
SM
1398 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1399 they've been requested explicitly (bug#9591).
1400
b6bd1599 14012011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1402
1403 * keymap.c (Fsingle_key_description): Use make_specified_string
1404 instead of build_string to build string from push_key_description.
1405 (Bug#5193)
1406
f701dc2a
PE
14072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1408
4222c55d
PE
1409 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1410 This fixes a Y2038 bug on 64-bit hosts.
1411 * buffer.c (reset_buffer):
1412 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1413 (Fclear_buffer_auto_save_failure):
1414 Use 0, not -1, to represent an unset failure time, since time_t
1415 might not be signed.
1416
f701dc2a
PE
1417 Remove dependency on glibc malloc internals.
1418 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1419 Move back here from lisp.h, but with their new implementations.
1420 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1421 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1422 * charset.c (charset_table_init): New static var.
1423 (syms_of_charset): Use it instead of xmalloc. This removes a
1424 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1425 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1426 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1427 Move back to alloc.c.
1428 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1429 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1430
9ceebf39
JD
14312011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1432
1433 * nsterm.m (windowDidResize): Call x_set_window_size only when
1434 ns_in_resize is true. Otherwise set pixelwidth/height and
1435 call change_frame_size (Bug#9628).
1436
cb993c58
PE
14372011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1438
3930c88b
PE
1439 Port --enable-checking=all to Fedora 14 x86-64.
1440 * charset.c (syms_of_charset): Also account for glibc malloc's
1441 internal overhead when calculating the initial malloc maximum.
1442
cb993c58
PE
1443 Port --enable-checking=all to Fedora 14 x86.
1444 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1445 Move to lisp.h.
1446 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1447 (overrun_check_realloc, overrun_check_free):
1448 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1449 That way, xmalloc returns a properly-aligned pointer even if
1450 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1451 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1452 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1453 into account when calculating the initial malloc maximum.
1454 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1455 Move here from alloc.c, so that charset.c can use it too.
1456 Properly align; the old code wasn't right for common 32-bit hosts
1457 when configured with --enable-checking=all.
1458 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1459 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1460
31bed486
EZ
14612011-09-29 Eli Zaretskii <eliz@gnu.org>
1462
04c70788 1463 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1464 use EDOM.
1465
fbcaa2f3
EZ
14662011-09-28 Eli Zaretskii <eliz@gnu.org>
1467
1468 * xdisp.c (compute_display_string_end): If there's no display
1469 string at CHARPOS, return -1.
1470
1471 * bidi.c (bidi_fetch_char): When compute_display_string_end
1472 returns a negative value, treat the character as a normal
1473 character not covered by a display string. (Bug#9624)
1474
a239d4e9
JB
14752011-09-28 Juanma Barranquero <lekktu@gmail.com>
1476
1477 * lread.c (Fread_from_string): Fix typo in docstring.
1478
88652fd5
EZ
14792011-09-27 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1482 newline, reseat the iterator instead of bidi-iterating there one
1483 character at a time. (Bug#9610)
32c1fffd
SM
1484 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1485 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1486
ed497dd4
AS
14872011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1488
1489 * lread.c (readevalloop): Use correct code for NBSP.
1490 (read1): Likewise. (Bug#9608)
1491
b2bf61aa
MA
14922011-09-25 Michael Albinus <michael.albinus@gmx.de>
1493
1494 * dbusbind.c (Fdbus_register_signal): When service is not
1495 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1496
32bbb17c
GM
14972011-09-25 Glenn Morris <rgm@gnu.org>
1498
1499 * buffer.c (truncate-lines): Doc fix.
1500
94e0933e
CY
15012011-09-24 Chong Yidong <cyd@stupidchicken.com>
1502
1503 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1504 (Fset_window_next_buffers): Doc fix.
1505
cddde921
GM
15062011-09-24 Glenn Morris <rgm@gnu.org>
1507
1508 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1509
1260aef1
PE
15102011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1511
25b4bfa0
PE
1512 Fix minor problems found by static checking.
1513 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1514 * indent.c (Fvertical_motion): Fix == vs = typo.
1515
e3cbd34b
EZ
15162011-09-24 Eli Zaretskii <eliz@gnu.org>
1517
a66cfb1c
SM
1518 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1519 Default value is now t. Doc fix.
6bf7006f 1520
e3cbd34b 1521 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1522 logic when moving up, not only when moving down. Fix the
e3cbd34b 1523 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1524 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1525
1526 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1527 CHARPOS is covered by a display string which includes newlines.
1528 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1529 is covered by a display string with embedded newlines.
1530
a3de0cbd
MA
15312011-09-24 Michael Albinus <michael.albinus@gmx.de>
1532
1533 * dbusbind.c (Fdbus_register_signal): Add match rule to
1534 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1535 (Fdbus_register_method, Vdbus_registered_objects_table):
1536 Fix docstring.
a3de0cbd 1537
b260039d
JM
15382011-09-24 Jim Meyering <meyering@redhat.com>
1539
32c1fffd 1540 do not ignore write error for any output size
b260039d
JM
1541 The previous change was incomplete.
1542 While it makes emacs --batch detect the vast majority of stdout
1543 write failures, errors were still ignored whenever the output size is
1544 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1545 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1546 && echo FAIL: ignored write error
1547 FAIL: ignored write error
1548 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1549 && echo FAIL: ignored write error
1550 FAIL: ignored write error
1551 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1552
8eca8a7c
AS
15532011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1554
1555 * emacs.c (Fkill_emacs): In noninteractive mode exit
1556 non-successfully if a write error occurred on stdout. (Bug#9574)
1557
3341db62
EZ
15582011-09-21 Eli Zaretskii <eliz@gnu.org>
1559
1560 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1561 the xassert test.
1562
1563 * dispextern.h (struct it): Update the comment documenting what
1564 can it->OBJECT be.
1565
8c203dbf
EZ
15662011-09-20 Eli Zaretskii <eliz@gnu.org>
1567
1568 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1569 a display string, extend search for cursor position to end of row.
1570 (find_row_edges): If the row ends in a newline from a display
1571 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1572 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1573 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1574 non-empty line. Fixes confusing cursor motion with arrow keys at
1575 the beginning of a line that starts with whitespace.
8c203dbf 1576
a4824228
LMI
15772011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1578
1579 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1580 (bug#9493).
1581
33ed493b
CY
15822011-09-18 Chong Yidong <cyd@stupidchicken.com>
1583
1584 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1585 boolean (Bug#9154).
1586
56cd55c8
EZ
15872011-09-18 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (display_line): Record maximum and minimum buffer
1590 positions even if no glyphs were produced (e.g., by a zero-width
1591 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1592 buffer positions that will be removed from the glyph row because
1593 they don't fit.
c02dcedf
EZ
1594 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1595 column is beyond frame width: don't subtract 1 "pixel" when
1596 computing width of the stretch.
3e62b7e0
EZ
1597 (reseat_at_next_visible_line_start): Undo the change made on
1598 2011-09-17 that saved paragraph information and restored it after
1599 the call to `reseat'. (Bug#9545)
56cd55c8 1600
5ed99d36 16012011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1602
1603 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1604 and turn window cursor on if cleared (Bug#9415).
1605
5ed99d36 16062011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1607
1608 * search.c (boyer_moore): Take unibyte characters from pattern
1609 literally. (Bug#9458)
1610
9bade7b2
EZ
16112011-09-18 Eli Zaretskii <eliz@gnu.org>
1612
1613 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1614
e5e9d610
PE
16152011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1616
87e4427a
PE
1617 Fix minor problem found by static checking.
1618 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1619 initialized, to pacify gcc -Wuninitialized.
1620
e5e9d610
PE
1621 * fileio.c: Report proper errno when syscall falls.
1622 (Finsert_file_contents): Save and restore errno,
1623 so that report_file_error outputs the correct diagnostic.
1624 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1625
a1674f0b
EZ
16262011-09-18 Eli Zaretskii <eliz@gnu.org>
1627
1628 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1629
fbfb6dd4
EZ
16302011-09-17 Eli Zaretskii <eliz@gnu.org>
1631
1632 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1633 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1634
bb187662
EZ
16352011-09-17 Eli Zaretskii <eliz@gnu.org>
1636
1137e8b8 1637 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1638 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1639
1640 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1641 (bidi_find_paragraph_start): Search back for paragraph beginning
1642 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1643 (bidi_move_to_visually_next): Only trigger paragraph-related
1644 computations when the last character is a newline or at EOB, not
1645 just any NEUTRAL_B. (Bug#9470)
1646
bb187662
EZ
1647 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1648 truncated lines if point is covered by a display string. (Bug#9524)
1649
2e621251
PE
16502011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1653 (cons_to_x_long): New function.
1654 (lisp_data_to_selection_data): Use it. Correct the test for
1655 short-versus-long data; it was negated. Break out of vector
1656 loop, for efficiency, when a long datum is discovered.
1657
91a15bc6
SM
16582011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1659
1660 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1661
b41c3a35
EZ
16622011-09-16 Eli Zaretskii <eliz@gnu.org>
1663
1664 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1665 GCC PR/17406) by declaring this function with external scope.
1666
7812ba2d
PE
16672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1670 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1671
cf7edc2a
AS
16722011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1673
1674 * editfns.c (Fformat): Correctly handle text properties on "%%".
1675
bd01620e
EZ
16762011-09-15 Eli Zaretskii <eliz@gnu.org>
1677
1678 * xterm.c (x_draw_composite_glyph_string_foreground):
1679 * w32term.c (x_draw_composite_glyph_string_foreground):
1680 * term.c (encode_terminal_code):
1681 * composite.c (composition_update_it, get_composition_id):
1682 * xdisp.c (get_next_display_element)
1683 (fill_composite_glyph_string): Add comments about special meaning
1684 of TAB characters in a composition.
1685
a02719a3
PE
16862011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1689 This occurs when processing a multibyte format.
1690 Problem reported by Wolfgang Jenker.
a02719a3 1691
72589a3c
JB
16922011-09-15 Johan Bockgård <bojohan@gnu.org>
1693
1694 * xdisp.c (try_cursor_movement): Only check for exact match if
1695 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1696
1c14176c
PE
16972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Remove unused external symbols.
1700 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1701 * xdisp.c (calc_pixel_width_or_height): Now static.
1702 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1703 * indent.c (check_display_width):
1704 * w32term.c: Fix comment to match code.
1705 * xterm.c, xterm.h (x_catching_errors): Remove.
1706
d2eea5b5
PE
17072011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 * xselect.c: Use signed conversions more consistently (Bug#9498).
1710 (selection_data_to_lisp_data): Assume incoming selection data are
1711 signed integers, not unsigned. This is to be consistent with
1712 outgoing selection data, which was modified to use signed integers
1713 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1714 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1715 expects long, not unsigned long.
1716
46888499
EZ
17172011-09-14 Eli Zaretskii <eliz@gnu.org>
1718
1719 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1720 computation of loop end. Reported by Johan Bockgård
1721 <bojohan@gnu.org>.
1722
ef8ef9fb
CY
17232011-09-13 Chong Yidong <cyd@stupidchicken.com>
1724
1725 * frame.c (Fother_visible_frames_p): Function deleted.
1726
fa819fed
EZ
17272011-09-12 Eli Zaretskii <eliz@gnu.org>
1728
1729 * indent.c (compute_motion): Process display vector front to back
1730 rather than the other way around. (Bug#2496)
1731
2ba8e008
SM
17322011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1733
1734 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1735
20f53c69
CY
17362011-09-11 Chong Yidong <cyd@stupidchicken.com>
1737
1738 * minibuf.c (Fread_from_minibuffer): Doc fix.
1739
d562d7a4
EZ
17402011-09-11 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1743 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1744
1c4d7f3d
LMI
17452011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1746
1747 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1748 value for non-existent files.
1749
b885bf36
EZ
17502011-09-11 Eli Zaretskii <eliz@gnu.org>
1751
1752 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1753 set its "size" to -1. This will set the modtime_size field of
1754 the corresponding buffer to -1, which is what
1755 verify-visited-file-modtime expects for files that do not exist.
1756 (Bug#9139)
1757
6612f0bf
PE
17582011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1761 here ...
1762 * lisp.h: ... from here. push_key_description is no longer
1763 defined in keyboard.c, so its declaration should not be in
1764 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1765 logically belongs with push_key_description.
1766
dfb3f755
PE
17672011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 * buffer.h: Include <sys/types.h> instead of <time.h>.
1770 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1771 Problem reported by Herbert J. Skuhra.
1772
3134906c
LMI
17732011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1774
1775 * xml.c (parse_region): Make the parsing work for
1776 non-comment-starting XML files again (bug#9144).
1777
8d903f4e
AS
17782011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1779
1780 * image.c (gif_load): Fix calculation of bottom and right corner.
1781 (Bug#9468)
1782
80ad64f4
EZ
17832011-09-10 Eli Zaretskii <eliz@gnu.org>
1784
1785 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1786 redisplay in small windows.
1787
208a048d
EZ
17882011-09-09 Eli Zaretskii <eliz@gnu.org>
1789
1790 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1791
9b1c252e
MR
17922011-09-08 Martin Rudalics <rudalics@gmx.at>
1793
1794 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1795 Operate on live windows only.
1796
2949f33b
JB
17972011-09-08 Juanma Barranquero <lekktu@gmail.com>
1798
1799 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1800
e08dcafd
EZ
18012011-09-07 Eli Zaretskii <eliz@gnu.org>
1802
1803 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1804 only under bidi iteration.
1805
115b96bd
JD
18062011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1807
1808 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1809
c8199d0f
PE
18102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1813 Without this fix, the command to link temacs failed due to an
1814 undefined symbol __builtin_isnan. This is because
1815 /usr/include/iso/math_c99.h #defines isnan(x) to
1816 __builtin_isnan(x), but the bundled gcc, which identifies itself
1817 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1818 a __builtin_isnan.
1819 * floatfns.c (isnan): #undef, and then #define to a clone of
1820 what's in data.c.
1821 (Fisnan): Always define, since it's always available now.
1822 (syms_of_floatfns): Always define isnan at the Lisp level.
1823
e39b275c 18242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1825
1826 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1827
b2db44d9 18282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1829
f4af5137 1830 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1831 The previous code assumed that file offsets (off_t values) fit in
1832 EMACS_INT variables, which is not true on typical 32-bit hosts.
1833 The code messed up by falsely reporting buffer overflow in cases
1834 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1835 when "big" contains more than 2**29 bytes, even though this
1836 inserts just one byte and does not overflow the buffer.
1837 (Finsert_file_contents): Store file offsets as off_t
1838 values, not as EMACS_INT values. Check for overflow when
1839 converting between EMACS_INT and off_t. When checking for
1840 buffer overflow or for overlap, take the offsets into account.
1841 Don't use EMACS_INT for small values where int suffices.
1842 When checking for overlap, fix a typo: ZV was used where
1843 ZV_BYTE was intended.
1844 (Fwrite_region): Don't assume off_t fits into 'long'.
1845 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1846
ecfc0a49
MA
18472011-09-05 Michael Albinus <michael.albinus@gmx.de>
1848
1849 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1850
6511acf2 18512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1852
0999621a 1853 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1854
1855 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1856 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1857 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1858 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1859 (modify_event_symbol): Do not assume that the length of
1860 name_alist_or_stem is safe to alloca and fits in int.
1861 (Fexecute_extended_command): Likewise for function name and binding.
1862 (Frecursion_depth): Wrap around reliably on integer overflow.
1863 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1864 since some callers pass EMACS_INT values.
1865 (Fsingle_key_description): Don't crash if symbol name contains more
1866 than MAX_ALLOCA bytes.
1867 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1868 (get_minibuffer): Arg is now EMACS_INT, not int.
1869 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1870 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1871 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1872
2be7d702
PE
1873 * dbusbind.c (signature_cat): New function.
1874 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1875 Do not overrun buffer; instead, report string overflow.
1876
9d1df220
PE
1877 * dispnew.c (add_window_display_history): Don't overrun buffer.
1878 Truncate instead; this is OK since it's just a log.
1879
33ef5c64
PE
1880 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1881 even if the time zone offset is outlandishly large.
1882 Don't mishandle offset == INT_MIN.
1883
66c6fdd5
PE
1884 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1885 when creating daemon; the previous buffer-overflow check was incorrect.
1886
d749b01b
PE
1887 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1888 which has the guts of the old verror function.
1889
b5cd1905
PE
1890 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1891 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1892
6e1a67fb
PE
1893 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1894 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1895 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1896 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1897 length of string rather than counting it via multiple sprintfs;
1898 that's simpler and more reliable.
c21721cc
PE
1899 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1900 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1901 sprintf, in case result does not fit in int.
1902
c57b67fc
PE
1903 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1904 (fontset_from_font): Print it.
1905
8a401434
PE
1906 * frame.c (tty_frame_count): Now printmax_t, not int.
1907 (make_terminal_frame, set_term_frame_name): Print it.
1908 (x_report_frame_params): In X, window IDs are unsigned long,
1909 not signed long, so print them as unsigned.
1910 (validate_x_resource_name): Check for implausibly long names,
1911 and don't assume name length fits in 'int'.
1912 (x_get_resource_string): Don't blindly alloca invocation name;
1913 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1914 not fit in int.
1915
6e1a67fb
PE
1916 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1917 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1918 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1919
0df02bf3
PE
1920 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1921 Use esprintf, not sprintf, in case result does not fit in int.
1922
48e30793
PE
1923 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1924 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1925 it as a large positive number.
1926 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1927 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1928
a66ff6d8
PE
1929 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1930 in case result does not fit in int.
1931
aca216ff
PE
1932 * print.c (float_to_string): Detect width overflow more reliably.
1933 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1934 buffer overrun. Don't assume list length fits in 'int'. Treat
1935 print length of 0 as 0, not as infinity; to be consistent with other
1936 uses of print length in this function. Don't overflow print length
1937 index. Don't assume hash table size fits in 'long', or that
1938 vectorlike size fits in 'unsigned long'.
1939
31c286f7
PE
1940 * process.c (make_process): Use printmax_t, not int, to format
1941 process-name gensyms.
1942
55e5faa1
PE
1943 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1944
80f2e268
PE
1945 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1946 to avoid potential buffer overrun.
1947
670741ab
PE
1948 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1949 if X resource line is longer than 512 bytes.
1950
b7163a50
PE
1951 * xfns.c (x_window): Make sprintf buffer a bit bigger
1952 to avoid potential buffer overrun.
1953
ae58ff1f
PE
1954 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1955
c43c8a6a
PE
1956 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1957
3f8236f4
PE
19582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1959
53e9fe90 1960 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1961 Without these, Emacs silently mishandles large integers sometimes.
1962 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1963 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1964
6511acf2
PE
1965 * xdisp.c (try_window_id): Check Emacs fixnum range before
1966 converting to 'int'.
806add1d 1967
6511acf2 1968 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1969 Check that an Emacs fixnum is in range before assigning it to 'int'.
1970 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1971 values converted from Emacs fixnums.
1972 (Frecenter): Don't wrap around a line count if it is out of 'int'
1973 range; instead, treat it as an extreme value.
1974 (Fset_window_configuration, compare_window_configurations):
1975 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1976
6511acf2
PE
1977 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1978 that can exceed INT_MAX. Check that EMACS_INT value is in range
1979 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1980 (match_limit): Don't assume that a fixnum can fit in 'int'.
1981
6511acf2 1982 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1983 exceed INT_MAX.
1984
6511acf2 1985 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1986 (Fvertical_motion): Don't wrap around LINES values that don't fit
1987 in 'int'. Instead, treat them as extreme values. This is good
1988 enough for windows, which can't have more than INT_MAX lines anyway.
1989
fcb901a7
LMI
19902011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1991
0f2f6b6d
LMI
1992 * Require libxml/parser.h to avoid compilation warning.
1993
fcb901a7
LMI
1994 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1995
1996 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1997 since this reportedly can destroy thread storage.
1998
6e20a0d4
CY
19992011-08-30 Chong Yidong <cyd@stupidchicken.com>
2000
2001 * syntax.c (find_defun_start): Update all cache variables if
2002 exiting early (Bug#9401).
2003
148ae00e
EZ
20042011-08-30 Eli Zaretskii <eliz@gnu.org>
2005
f6cfbd8f
EZ
2006 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2007
148ae00e
EZ
2008 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2009 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2010 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2011
2012 * term.c (tty_append_glyph): New function.
2013 (produce_stretch_glyph): Static function and its prototype deleted.
2014
a66cfb1c
SM
2015 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2016 Add prototypes.
148ae00e 2017
c4a07a4c
PE
20182011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2021 when checking :margin (Bug#9390).
2022 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2023 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2024 so that the name doesn't mislead. All uses changed.
2025
6bc8cd65
JB
20262011-08-28 Johan Bockgård <bojohan@gnu.org>
2027
2028 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2029 set_tty_hooks.
2030
dca4927e
EZ
20312011-08-27 Eli Zaretskii <eliz@gnu.org>
2032
2033 * xdisp.c (move_it_to): Don't bail out early when reaching
2034 position beyond to_charpos, if we are scanning backwards.
2035 (move_it_vertically_backward): When DY == 0, make sure we get to
2036 the first character in the line after the newline.
2037
f2cad773
PE
20382011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2039
2040 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2041 (ccl_driver): Do not generate an out-of-range pointer.
2042 (Fccl_execute_on_string): Remove unnecessary check for
2043 integer overflow, noted by Stefan Monnier in
2044 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2045 Remove a FIXME that didn't need fixing.
2046 Simplify the newly-introduced buffer reallocation code.
2047
0cae2cdb
JB
20482011-08-27 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2051
5fc295a4 20522011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2053
70c60eb2 2054 Integer and memory overflow issues (Bug#9196).
726e0ab1 2055
d31850da
PE
2056 * doc.c (get_doc_string): Rework so that
2057 get_doc_string_buffer_size is the actual buffer size, rather than
2058 being 1 less than the actual buffer size; this makes xpalloc more
2059 convenient.
2060
a69fbedb
PE
2061 * image.c (x_allocate_bitmap_record, cache_image):
2062 * xselect.c (Fx_register_dnd_atom):
2063 Simplify previous changes by using xpalloc.
2064
fe5c5d37
PE
2065 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2066 since either will do and ptrdiff_t is convenient with xpalloc.
2067
0065d054
PE
2068 * charset.c (charset_table_size)
2069 (struct charset_sort_data.priority): Now ptrdiff_t.
2070 (charset_compare): Don't overflow if priorities differ greatly.
2071 (Fsort_charsets): Don't assume list length fits in int.
2072 Check for size-calculation overflow when allocating sort data.
2073 (syms_of_charset): Allocate an initial charset table that is
2074 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2075
2076 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2077
2078 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2079 The actual value is always <= INT_MAX, and leaving it unsigned made
2080 overflow checking harder.
2081
2082 * dispextern.h (struct glyph_matrix.rows_allocated)
2083 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2084 with xpalloc. The values are still always <= INT_MAX.
2085
2086 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2087
2088 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2089 (SAFE_NALLOCA): New macro.
2090
2091 * region-cache.c (struct boundary.pos, find_cache_boundary)
2092 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2093 (set_cache_region, invalidate_region_cache)
2094 (revalidate_region_cache, know_region_cache, region_cache_forward)
2095 (region_cache_backward, pp_cache):
2096 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2097 so that ptrdiff_t * can be passed to xpalloc.
2098 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2099 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2100 (pp_cache): Don't assume cache_len fits in int.
2101 * region-cache.h: Adjust extern decls to match.
2102
2103 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2104 EMACS_INT, since either will do, for xpalloc.
2105
2106 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2107 (xnmalloc, xnrealloc, xpalloc): New functions.
2108
726e0ab1
PE
2109 * bidi.c (bidi_shelve_header_size): New constant.
2110 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2111 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2112
51f30bc5 2113 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2114 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2115 (overlay_strings):
2116 Don't update size of array until after memory allocation succeeds,
2117 because xmalloc/xrealloc may not return.
0065d054
PE
2118 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2119 now that we have proper integer overflow checking.
2120 (record_overlay_string, overlay_strings): Catch overflows when
2121 calculating size of overlay_str_buf.
726e0ab1 2122
0065d054
PE
2123 * callproc.c (Fcall_process): Check for size overflow when
2124 calculating size of args2.
2125 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2126 Normally we prefer signed values, but sticking with ptrdiff_t would
2127 require adding more-complicated checks.
726e0ab1
PE
2128
2129 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2130 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2131 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2132 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2133
2134 * character.c (Fstring): Check for size-calculation overflow.
2135
2136 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2137 unnecessary integer overflow. Check for size overflow.
2138 (encode_coding_object): Don't update size until xmalloc succeeds.
2139
2140 * composite.c (get_composition_id): Check for overflow in glyph
2141 length calculations.
2142
2143 Integer and memory overflow fixes for display code.
2144 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2145 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2146 (scrolling_window): Check for overflow in size calculations.
2147 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2148 Don't assume glyph table len fits in int.
2149 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2150 (row_table_size): Now ptrdiff_t, not int.
2151 (scrolling_window): Avoid overflow in size calculations.
2152 Don't update size until allocation succeeds.
2153 * fns.c (concat): Check for overflow in size calculations.
2154 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2155 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2156 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2157
2158 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2159 (get_doc_string): Check for size calculation overflow.
2160 Don't update size until allocation succeeds.
2161 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2162 EMACS_INT, where ptrdiff_t will do.
2163 (Fsubstitute_command_keys): Check for string overflow.
2164
2165 * editfns.c (set_time_zone_rule): Don't assume environment length
2166 fits in int.
2167 (message_length): Now ptrdiff_t, not int.
2168 (Fmessage_box): Don't update size until allocation succeeds.
2169 Don't assume message length fits in int.
2170 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2171
0065d054
PE
2172 * emacs.c (main): Do not reallocate argv, since there is a null at
2173 the end that can be overwritten, and this way there's no need to
2174 worry about size-calculation overflow.
2175 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2176
2177 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2178 alloc succeeds.
2179 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2180
2181 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2182 (x_set_scroll_bar_width, x_figure_window_size):
2183 Check for integer overflow.
2184 (x_set_alpha): Do not assume XINT fits in int.
2185
2186 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2187 This is for the members text_lines, text_cols, total_lines, total_cols,
2188 where the system imposes an 'int' limit.
2189
2190 * fringe.c (Fdefine_fringe_bitmap):
2191 Don't update size until alloc works.
2192
2193 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2194 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2195
2196 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2197 Check for size-calculation overflow.
2198 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2199 do, as we prefer signed integers.
2200 (id_to_widget.max_size, id_to_widget.used)
2201 (xg_store_widget_in_map, xg_remove_widget_from_map)
2202 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2203 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2204 Use and return ptrdiff_t, not int.
2205 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2206 * gtkutil.h: Change prototypes to match the above.
2207
2208 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2209 are duplicate now that they've been promoted to lisp.h.
2210 (x_allocate_bitmap_record, x_alloc_image_color)
2211 (make_image_cache, cache_image, xpm_load):
2212 Don't update size until alloc is done.
2213 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2214 (x_detect_edges):
3256efce 2215 Check for size calculation overflow.
726e0ab1
PE
2216 (ct_colors_allocated_max): New constant.
2217 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2218 overflow.
3256efce 2219
726e0ab1
PE
2220 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2221 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2222 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2223 Use ptrdiff_t, not int, to count maps.
2224 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2225 calculations. Don't update size until allocation succeeds.
2226 Redo calculations to avoid overflow.
726e0ab1
PE
2227 * keyboard.h: Change prototypes to match the above.
2228
2229 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2230 to count maps.
2231 (current_minor_maps): Check for size calculation overflow.
2232 * keymap.h: Change prototypes to match the above.
2233
2234 * lread.c (read1, init_obarray): Don't update size until alloc done.
2235
2236 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2237 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2238
726e0ab1
PE
2239 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2240 Now ptrdiff_t, not int.
2241 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2242 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2243
2244 * process.c (Fnetwork_interface_list): Check for overflow
2245 in size calculation.
2246
2247 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2248
2249 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2250 overflow. Don't bother calling xmalloc when xrealloc will do.
2251
2252 * search.c (Freplace_match): Check for size calculation overflow.
2253 (Fset_match_data): Don't assume list lengths fit in 'int'.
2254
2255 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2256 for command line length. Do not attempt to address one before the
2257 beginning of an array, as that's not portable.
2258
2259 * term.c (max_frame_lines): Remove; unused.
2260 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2261 not int.
2262 (encode_terminal_code, calculate_costs): Check for size
2263 calculation overflow.
2264 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2265 table lengths and related sizes. Don't update size until alloc
2266 done. Redo calculations to avoid overflow.
2267 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2268
2269 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2270 subtracting pointers.
2271 (gobble_line): Check for overflow more carefully. Don't update size
2272 until alloc done.
2273
2274 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2275 Don't update size until alloc done.
2276 Redo size calculations to avoid overflow.
2277 Check for size calculation overflow.
0065d054 2278 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2279
2280 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2281 Use ptrdiff_t, not int, for sizes.
2282 (store_mode_line_noprop_char): Don't update size until alloc done.
2283
0065d054
PE
2284 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2285 Use ptrdiff_t, not int, for sizes.
2286 (Finternal_make_lisp_face, cache_face):
2287 Check for size calculation overflow.
2288 (cache_face): Treat size calculation overflows as if they were
2289 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2290
2291 * xfns.c (x_encode_text, x_set_name_internal)
2292 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2293 sizes, since they can exceed INT_MAX in size. Check for size
2294 calculation overflow.
2295
0065d054
PE
2296 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2297 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2298 Don't update size until alloc done.
2299
0065d054 2300 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2301 as sprintf is limited to int lengths.
1d526e2f 2302
252c5ee1
PE
2303 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2304 (X_LONG_MIN): New macros.
864d7ce7
PE
2305 Use them to make the following changes clearer.
2306 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2307 This change doesn't affect the value now, but it may help remind
2308 future maintainers not to raise the value too much later.
2309 (SELECTION_QUANTUM): Remove, replacing with ...
2310 (selection_quantum): ... new function, which avoids overflow.
2311 All uses changed.
2312 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2313 assumption that selection length fits in 'int'.
2314 (x_reply_selection_request, x_handle_selection_request)
2315 (x_get_window_property, receive_incremental_selection)
2316 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2317 (lisp_data_to_selection_data, clean_local_selection_data):
2318 Use ptrdiff_t, not int, to record length of selection.
2319 (x_reply_selection_request, x_get_window_property)
2320 (receive_incremental_selection, x_property_data_to_lisp):
2321 Redo calculations to avoid overflow.
2322 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2323 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2324 something.
2325 (x_get_window_property, receive_incremental_selection)
2326 (lisp_data_to_selection_data, x_property_data_to_lisp):
2327 Check for size-calculation overflow.
2328 (x_get_window_property, receive_incremental_selection)
2329 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2330 Don't store size until memory allocation succeeds.
2331 (x_get_window_property): Plug memory leak on memory exhaustion.
2332 Don't double-block input; malloc is safe here. Don't assume 2**34
2333 - 4 fits in unsigned long. Add an xassert to check
2334 XGetWindowProperty overflow. Be more careful about overflow
2335 calculations, and distinguish size from memory overflow better.
2336 (receive_incremental_selection): When tracing, don't assume
2337 unsigned int is less than INT_MAX.
2338 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2339 harmful) conversions of unsigned short to int.
2340 (lisp_data_to_selection_data): Don't assume that integers
2341 in the range -65535 through -1 fit in an X unsigned short.
2342 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2343 result parameters unless successful. Rely on cons_to_unsigned
2344 to report problems with elements; the old code wasn't right anyway.
2345 (x_check_property_data): Check for int overflow; we cannot use
2346 a wider type due to X limits.
2347 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2348
726e0ab1 2349 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2350
0065d054
PE
2351 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2352 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2353 (x_color_cells): Don't store size until memory allocation succeeds.
2354 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2355 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2356 (x_term_init): Don't assume length fits in int (sprintf is limited
2357 to int size).
bc18e09d 2358
ebfa62c0
PE
2359 Use ptrdiff_t for composition IDs.
2360 * character.c (lisp_string_width):
2361 * composite.c (composition_table_size, n_compositions)
2362 (get_composition_id, composition_gstring_from_id):
2363 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2364 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2365 * window.c (Frecenter):
2366 Use ptrdiff_t, not int, for composition IDs.
2367 * composite.c (get_composition_id): Check for integer overflow.
2368 * composite.h: Adjust prototypes to match the above changes.
2369
d3411f89
PE
2370 Use ptrdiff_t for hash table indexes.
2371 * category.c (hash_get_category_set):
2372 * ccl.c (ccl_driver):
2373 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2374 * coding.c (coding_system_charset_list, detect_coding_system):
2375 * coding.h (struct coding_system.id):
2376 * composite.c (get_composition_id, gstring_lookup_cache):
2377 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2378 * image.c (xpm_get_color_table_h):
2379 * lisp.h (hash_lookup, hash_put):
2380 * minibuf.c (Ftest_completion):
2381 Use ptrdiff_t for hash table indexes, not int (which is too
2382 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2383 32-bit --with-wide-int hosts).
2384
e097a6fa
PE
2385 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2386 Add a FIXME comment about memory leaks.
2387 (syms_of_charset): Don't assume xmalloc returns.
2388
5637687f
PE
2389 Don't assume that stated character widths fit in int.
2390 * character.c (Fchar_width, c_string_width, lisp_string_width):
2391 * character.h (CHAR_WIDTH):
2392 * indent.c (MULTIBYTE_BYTES_WIDTH):
2393 Use sanitize_char_width to avoid undefined and/or bad behavior
2394 with outlandish widths.
a66cfb1c 2395 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2396 now that we have two such functions. All uses changed.
2397 (sanitize_char_width): New inline function.
2398
a2271ba2
PE
2399 Don't assume that tab-width fits in int.
2400 * character.h (sanitize_width): New inline function.
2401 (SANE_TAB_WIDTH): New macro.
2402 (ASCII_CHAR_WIDTH): Use it.
2403 * indent.c (sane_tab_width): Remove. All uses replaced by
2404 SANE_TAB_WIDTH (current_buffer).
2405 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2406
18c52557
PE
2407 * fileio.c: Integer overflow issues with file modes.
2408 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2409
caeeedc1
PE
2410 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2411 Remove unreachable code.
2412 (read_hex, load_charset_map_from_file): Check for integer overflow.
2413
6df6ae42 2414 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2415 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2416 (x_send_scroll_bar_event): Likewise. Check that the size does not
2417 exceed limits imposed by XClientMessageEvent, as well as the usual
2418 ptrdiff_t and size_t limits.
2419
b13995db
PE
2420 * keyboard.c: Overflow, signedness and related fixes.
2421 (make_lispy_movement): Use same integer type in forward decl
2422 that is used in the definition.
2423 (read_key_sequence, keyremap_step):
2424 Change bufsize argument back to int, undoing my 2011-03-30 change.
2425 We prefer signed types, and int is wide enough here.
2426 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2427 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2428 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2429 length, not size_t. Use ptrdiff_t for index, not int.
2430 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2431 possibility of integer overflow.
2432
13464394
PE
2433 Overflow, signedness and related fixes for images.
2434
2435 * dispextern.h (struct it.stack[0].u.image.image_id)
2436 (struct_it.image_id, struct image.id, struct image_cache.size)
2437 (struct image_cache.used, struct image_cache.ref_count):
2438 * gtkutil.c (update_frame_tool_bar):
2439 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2440 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2441 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2442 * nsmenu.m (update_frame_tool_bar):
2443 * xdisp.c (calc_pixel_width_or_height):
2444 * xfns.c (image_cache_refcount):
2445 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2446 on typical 64-bit hosts.
2447
2448 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2449 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2450 Omit unnecessary casts to int.
2451 (parse_image_spec): Check that integers fall into 'int' range
2452 when the callers expect that.
2453 (image_ascent): Redo ascent calculation to avoid int overflow.
2454 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2455 (lookup_image): Remove unnecessary tests.
2456 (xbm_image_p): Locals are now of int, not EMACS_INT,
2457 since parse_image_check makes sure they fit into int.
2458 (png_load, gif_load, svg_load_image):
2459 Prefer int to unsigned where either will do.
2460 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2461 old tiff_error_handler and tiff_warning_handler.
2462 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2463 stack buffer overflows. It uses only the features of vsnprintf
2464 that are common to both POSIX and native Microsoft.
2465 (tiff_error_handler, tiff_warning_handler): Use it.
2466 (tiff_load, gif_load, imagemagick_load_image):
2467 Don't assume :index value fits in 'int'.
2468 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2469 (imagemagick_load_image): Check that crop parameters fit into
2470 the integer types that MagickCropImage accepts. Don't assume
2471 Vimagemagick_render_type has a nonnegative value. Don't assume
2472 size_t fits in 'long'.
2473 (gs_load): Use printmax_t to print the widest integers possible.
2474 Check for integer overflow when computing image height and width.
2475
c11821d4
EZ
24762011-08-26 Eli Zaretskii <eliz@gnu.org>
2477
2478 * xdisp.c (redisplay_window): Don't force window start if point
2479 will be invisible in the resulting window. (Bug#9324)
2480
0c95fcf7
EZ
24812011-08-25 Eli Zaretskii <eliz@gnu.org>
2482
2483 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2484 the display spec is of the form `(space ...)'.
2485 (handle_display_spec): Return the value returned by
2486 handle_single_display_spec, not just 1 or zero.
2487 (handle_single_display_spec): If the display spec is of the form
2488 `(space ...)', and specifies display in the text area, return 2
2489 rather than 1.
fee65a97 2490 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2491 accurately, and prefer exact match for point under bidi.
2492 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2493
2494 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2495 into disp_prop; all users changed.
2496
2497 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2498 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2499 for the text covered by the display property.
2500
e4ed06f1
CY
25012011-08-25 Chong Yidong <cyd@stupidchicken.com>
2502
2503 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2504 Change return value to nil.
2505 (Frecord_buffer): Delete unused function.
2506
f67cdd7f
EZ
25072011-08-24 Eli Zaretskii <eliz@gnu.org>
2508
5980d4c6
EZ
2509 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2510 buffers, return left-to-right.
8610fe8b
EZ
2511 (set_cursor_from_row): Consider candidate row a win if its glyph
2512 represents a newline and point is on that newline. Fixes cursor
2513 positioning on the newline at EOL of R2L text within L2R
2514 paragraph, and vice versa.
2515 (try_cursor_movement): Check continued rows, in addition to
2516 continuation rows. Fixes unwarranted scroll when point enters a
2517 continued line of R2L text within an L2R paragraph, or vice versa.
2518 (cursor_row_p): Consider the case of point being equal to
2519 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2520 from the end of a short line to the beginning of a continued line
2521 of R2L text within L2R paragraph.
2522 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2523 composed characters.
5980d4c6 2524
f67cdd7f
EZ
2525 * bidi.c (bidi_check_type): Use xassert.
2526 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2527 members.
2528
bca633fb
EZ
25292011-08-23 Eli Zaretskii <eliz@gnu.org>
2530
2531 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2532 a character.
2533
4a5885a7
CY
25342011-08-23 Chong Yidong <cyd@stupidchicken.com>
2535
2536 * nsfont.m (ns_otf_to_script): Fix typo.
2537
0902a04e
KH
25382011-08-22 Kenichi Handa <handa@m17n.org>
2539
2540 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2541 extra slot even if the purpose is char-code-property-table.
2542
1a2e6670
EZ
25432011-08-23 Eli Zaretskii <eliz@gnu.org>
2544
8ddde651
EZ
2545 * xdisp.c (redisplay_window): When computing centering_position,
2546 account for the height of the header line. (Bug#8874)
2547
425cc014
EZ
2548 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2549 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2550 candidate is selected by the mouse, and that candidate has a
2551 composed character under the mouse.
2552
1a2e6670
EZ
2553 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2554 coordinates reported by pos-visible-in-window-p for a composed
2555 character in column zero.
2556
8b76d6f8
SM
25572011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2558
2559 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2560
dac347dd
EZ
25612011-08-22 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2564 consider it a hit if to_charpos is anywhere in the range of the
2565 composed buffer positions.
2566
e013fb34
CY
25672011-08-22 Chong Yidong <cyd@stupidchicken.com>
2568
2569 * image.c (gif_load): Don't assume that each subimage has the same
2570 dimensions as the base image. Handle disposal method that is
2571 "undefined" by the gif spec (Bug#9335).
2572
bd1ba3e8
CY
25732011-08-20 Chong Yidong <cyd@stupidchicken.com>
2574
2575 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2576 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2577
54a1215b
EZ
25782011-08-19 Eli Zaretskii <eliz@gnu.org>
2579
823564e5
EZ
2580 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2581 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2582 from an Org mode buffer to a Speedbar frame.
2583
54a1215b
EZ
2584 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2585 a composition, take its buffer position from IT->cmp_it.charpos.
2586 Fixes cursor positioning at the beginning of a line that begins
2587 with a composed character.
2588
9778ebcc
EZ
25892011-08-18 Eli Zaretskii <eliz@gnu.org>
2590
0be6ee06
EZ
2591 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2592 character bidirectional type, use STRONG_L instead. Fixes crashes
2593 in a buffer produced by `describe-categories'.
2594
9778ebcc
EZ
2595 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2596 members before the level stack, so they would be saved and
2597 restored when copying iterator state. Fixes incorrect reordering
2598 around TABs covered by display properties.
2599
156bffbe
AS
26002011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2601
6b02f655 2602 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2603
72ad093b
CY
26042011-08-17 Chong Yidong <cyd@stupidchicken.com>
2605
2606 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2607 (internal_condition_case_2, internal_condition_case_n):
2608 Remove unnecessary aborts (Bug#9081).
72ad093b 2609
35774242
EZ
26102011-08-17 Eli Zaretskii <eliz@gnu.org>
2611
2612 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2613 has no `load' handler, try opening the file locally. (Bug#9311)
2614
db76dd85
KB
26152011-08-16 Ken Brown <kbrown@cornell.edu>
2616
2617 * gmalloc.c: Expand comment.
2618
b215eee5
EZ
26192011-08-16 Eli Zaretskii <eliz@gnu.org>
2620
2621 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2622 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2623
a4579d33
KB
26242011-08-16 Ken Brown <kbrown@cornell.edu>
2625
2626 Fix memory allocation problems in Cygwin build (Bug#9273).
2627
2628 * unexcw.c ( __malloc_initialized): Declare external variable.
2629 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2630
8b76d6f8
SM
2631 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2632 New variables.
a4579d33
KB
2633 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2634 dumped emacs.
2635 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2636 in the static heap.
2637 [CYGWIN] (special_realloc): New function.
2638 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2639 requests to realloc storage in the static heap.
2640
3ebec551
PE
26412011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 * bidi.c (bidi_initialize): Remove unused local.
2644
9fd8be00
EZ
26452011-08-15 Eli Zaretskii <eliz@gnu.org>
2646
6b02f655
SM
2647 * bidimirror.h:
2648 * biditype.h: Remove file.
2649 * makefile.w32-in ($(BLD)/bidi.$(O)):
2650 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2651
2652 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2653
2654 * chartab.c: Improve commentary for the uniprop_table API.
2655
32413314
EZ
2656 * bidi.c (bidi_paragraph_init): Support zero value of
2657 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2658 (bidi_initialize): Use uniprop_table instead of including
2659 biditype.h and bidimirror.h.
32413314 2660
9fd8be00
EZ
2661 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2662 coordinates of the iterator when restoring from ppos_it.
2663 (Bug#9296)
2664
5cf2b69b
KH
26652011-08-14 Kenichi Handa <handa@m17n.org>
2666
2667 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2668 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2669
daf17d00
EZ
26702011-08-14 Eli Zaretskii <eliz@gnu.org>
2671
2672 * xdisp.c (move_it_in_display_line_to): Don't invoke
2673 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2674 ppos_it. Fixes vertical cursor motion when line beginning is
2675 covered by an image. (Bug#9296)
2676
08e3161a
JD
26772011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2678
2679 * nsterm.h (ns_run_ascript): Declare.
2680 (NSAPP_DATA2_RUNASSCRIPT): Define.
2681
2682 * nsfns.m (as_script, as_result, as_status): New static variables.
2683 (ns_run_ascript): New function.
5e617bc2 2684 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2685 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2686 the event loop. Get status from as_status (Bug#7276).
2687
2688 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2689 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2690 the event loop (Bug#7276).
2691
a3720aa2
AS
26922011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2693
2694 * gnutls.c (QCgnutls_bootprop_priority)
2695 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2696 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2697 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2698 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2699 (QCgnutls_bootprop_verify_hostname_error)
2700 (QCgnutls_bootprop_callbacks_verify): Rename from
2701 Qgnutls_bootprop_..., all uses changed.
2702
2703 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2704 uses changed.
2705
0a0d27fb
PE
27062011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2707
19d5c50c
PE
2708 * xfaces.c (Qframe_set_background_mode): Now static.
2709 * dispextern.h (Qframe_set_background_mode): Remove decl.
2710
0a0d27fb
PE
2711 * process.c (Fnetwork_interface_info): Declare local only if needed.
2712
377538cb
JD
27132011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2714
2715 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2716 (Fnetwork_interface_list): Allocate in increments of bytes instead
2717 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2718 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2719 sockaddr.
2720 (struct ifflag_def): notrailers is smart on OSX.
2721 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2722 Get hardware address with getifaddrs if available.
2723
08fff70c
EZ
27242011-08-12 Eli Zaretskii <eliz@gnu.org>
2725
2726 * xdisp.c (iterate_out_of_display_property): xassert that
2727 IT->position is set to within IT->object's boundaries. Break from
2728 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2729 when IT->position is set up wrongly due to some bug.
2730 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2731 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2732 entry. Force push_it to save on the stack the current
2733 buffer/string position, to be restored by pop_it. Fix flags in
2734 the iterator structure wrt the object coming from a display
2735 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2736 properties. (Bug#9284)
2737
7be1c708 27382011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2739
7be1c708
CY
2740 * fontset.c (fontset_get_font_group): Add proper type checks.
2741 (Bug#9172)
aac0c6e3 2742
7be1c708 27432011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2744
7be1c708
CY
2745 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2746 and LC_VERSION_MIN_MACOSX.
2747 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2748 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2749
97bb72a6
EZ
27502011-08-08 Eli Zaretskii <eliz@gnu.org>
2751
2752 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2753 no-display-properties-and-no-overlays under bidi display.
2754 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2755 properties and overlays.
97bb72a6 2756
d5617611
CY
27572011-08-08 Chong Yidong <cyd@stupidchicken.com>
2758
37e11a63
CY
2759 * editfns.c (Fset_time_zone_rule): Document relationship with the
2760 setenv function.
2761
d5617611
CY
2762 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2763 the font entity extracted from the cache (Bug#8109).
2764
58872834
CY
27652011-08-07 Chong Yidong <cyd@stupidchicken.com>
2766
2767 * composite.c (autocmp_chars): Don't reset point. That is done by
2768 restore_point_unwind (Bug#5984).
2769
75bfc667
JL
27702011-08-07 Juri Linkov <juri@jurta.org>
2771
2772 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2773 to show the arg `TIME' instead of `TIMEVAL'.
2774
d1410150
EZ
27752011-08-06 Eli Zaretskii <eliz@gnu.org>
2776
2777 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2778 display property strides EOL and includes a newline, as in
2779 longlines-mode. (Bug#9254)
75b771e4
EZ
2780 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2781 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2782
2783 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2784 is non-zero, even if the data buffer is NULL. Fixes a crash in
2785 vertical-motion with longlines-mode. (Bug#9254)
2786
35928349
EZ
27872011-08-05 Eli Zaretskii <eliz@gnu.org>
2788
ec7cc85b
EZ
2789 * bidi.c <bidi_cache_total_alloc>: Now static.
2790 (bidi_initialize): Initialize bidi_cache_total_alloc.
2791
8b76d6f8 2792 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2793 cache. (Bug#9221)
2794
2795 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2796 amount allocated this far in `bidi_cache_total_alloc'.
2797 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2798 non-zero, only free the data buffer without restoring the cache
2799 contents. All callers changed.
2800
2801 * dispextern.h (bidi_unshelve_cache): Update prototype.
2802
2803 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2804 (move_it_in_display_line, move_it_to)
2805 (move_it_vertically_backward, move_it_by_lines): Replace the call
2806 to xfree to an equivalent call to bidi_unshelve_cache.
2807 (move_it_in_display_line_to): Fix logic of returning
412b6358 2808 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2809
e2e2423b
EZ
28102011-08-05 Eli Zaretskii <eliz@gnu.org>
2811
2812 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2813 came from a string character with a `cursor' property. (Bug#9229)
2814
ae9e757a
JD
28152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2816
2817 * Makefile.in (LIB_PTHREAD): New variable.
2818 (LIBES): Add LIB_PTHREAD (Bug#9216).
2819
2820 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2821 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2822
213bd7f2
AS
28232011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2824
6b02f655 2825 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2826
99aaf75f
JD
28272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2828
2829 * xterm.c (x_find_topmost_parent): New function.
2830 (x_set_frame_alpha): Find topmost parent window with
2831 x_find_topmost_parent and set the property there also (bug#9181).
2832 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2833
c74e9d86
PE
28342011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * callproc.c (Fcall_process): Avoid vfork clobbering
2837 the local vars buffer, coding_systems, current_dir.
2838
640c8776
SM
28392011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2840
2841 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2842
f26d0e4c
PE
28432011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2844
8a10d76c
PE
2845 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2846 so that it is not optimized away.
2847
f26d0e4c
PE
2848 * xdisp.c (compute_display_string_pos): Remove unused local.
2849
55439c61
EZ
28502011-08-02 Eli Zaretskii <eliz@gnu.org>
2851
2852 Fix slow cursor motion and scrolling in large buffers with
2853 selective display, like Org Mode buffers. (Bug#9218)
2854
2855 * dispextern.h (struct bidi_it): New member disp_prop_p.
2856
2857 * xdisp.c: Remove one-slot cache of display string positions.
2858 (compute_display_string_pos): Accept an additional argument
5e617bc2 2859 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2860 for a display string or property. If found, set DISP_PROP_P
2861 non-zero.
2862
2863 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2864 DISP_PROP_P, and pass it to compute_display_string_pos.
2865 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2866 non-zero. All callers of bidi_fetch_char changed.
2867
fb33fa43
SM
28682011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2869
2870 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2871
b099e063
DM
28722010-12-03 Don March <don@ohspite.net>
2873
2874 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2875 last character M-[char] is translated to ESC [char] (bug#7541).
2876
5cc7f7af
KH
28772011-08-02 Kenichi Handa <handa@m17n.org>
2878
d0fffa3f 2879 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2880
2881 * chartab.c (uniprop_table): Make it non-static.
2882
525d5e6e
EZ
28832011-08-01 Eli Zaretskii <eliz@gnu.org>
2884
2885 * xdisp.c (forward_to_next_line_start): Accept additional argument
2886 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2887 on the newline.
2888 (reseat_at_next_visible_line_start): Use the bidi iterator state
2889 returned by forward_to_next_line_start to restore the state of
2890 it->bidi_it after backing up to previous newline. (Bug#9212)
2891
31011111
AS
28922011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2893
2894 * regex.c (re_comp): Protoize.
2895 (re_exec): Fix return type.
2896 (regexec): Fix type of `ret'. (Bug#9203)
2897
476371c4
PE
28982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2899
e5d76069
PE
2900 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2901 This is needed if max-image-size is a floating-point number.
2902
9a79b20c
AS
29032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2904
2905 * print.c (print_object): Print empty symbol as ##.
2906
2907 * lread.c (read1): Read ## as empty symbol.
2908
d8c2fa78
AA
29092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2910
2911 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2912 setting frame foreground color (Bug#9175).
2913 (x_set_background_color): Likewise.
2914
ffe57a7a
AA
2915 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2916 contents (Bug#9176).
2917 (EmacsTooltip -init): Remove bezels and add shadows to
2918 tooltip windows.
2919
bf3492a5
AA
2920 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2921 or scroll bar (Bug#8470).
2922
d55e9c53
AA
2923 * nsfont.m (nsfont_open): Remove assignment to voffset and
2924 unnecessary vars hshink, expand, hd, full_height, min_height.
2925 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2926
2927 * nsterm.h (nsfont_info): Remove voffset field.
2928
d8c2fa78 29292011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2930
2931 Implement strike-through and overline on NextStep (Bug#8863).
2932
2933 * nsfont.m (nsfont_open): Use underline position provided by font,
2934 instead of hard-coded value of 2.
2935 (nsfont_draw): Call ns_draw_text_decoration instead.
2936
2937 * nsterm.h: Add declaration for ns_draw_text_decoration.
2938
2939 * nsterm.m (ns_draw_text_decoration): New function for drawing
2940 underline, overline, and strike-through.
2941 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2942 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2943 accommodate underlining, etc.
4843aac3 2944
4cc60b9b
EZ
29452011-07-28 Eli Zaretskii <eliz@gnu.org>
2946
bc7ece87
EZ
2947 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2948 default.
4cc60b9b 2949
476371c4
PE
29502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2951
66606eea
PE
2952 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2953 Without this fix, if a signal arrives just after memory fills up,
2954 'malloc' might be invoked reentrantly.
2955
476371c4
PE
2956 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2957 In other words, assume that every image size is allowed, on non-X
2958 hosts. This assumption is probably wrong, but it lets Emacs compile.
2959
f3fcc40d
AS
29602011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2961
2962 * regex.c (re_iswctype): Convert return values to boolean.
2963
350c992f
EZ
29642011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2965
2966 * xdisp.c (compute_display_string_pos): Don't use cached display
2967 string position if the buffer had its restriction changed.
2968 (Bug#9184)
2969
5266b4bb
PE
29702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2971
2972 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2973
2573a837 29742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2975
41f55ccd 2976 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2977
39e378da
PE
2978 * bidi.c: Integer size and overflow fixes.
2979 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2980 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2982 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2983 (bidi_find_other_level_edge):
2984 Use ptrdiff_t instead of EMACS_INT where either will do.
2985 This works better on 32-bit hosts configured --with-wide-int.
2986 (bidi_cache_ensure_space): Check for size-calculation overflow.
2987 Use % rather than repeated addition, for better worst-case speed.
2988 Don't set bidi_cache_size until after xrealloc returns, because it
2989 might not return.
2990 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2991 (bidi_cache_ensure_space): Also check that the bidi cache size
2992 does not exceed that of the largest Lisp string or buffer. See Eli
2993 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2994
5e927815
PE
2995 * alloc.c (__malloc_size_t): Remove.
2996 All uses replaced by size_t. See Andreas Schwab's note
2997 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2998
ca4aa935
PE
2999 * image.c: Improve checking for integer overflow.
3000 (check_image_size): Assume that f is nonnull, since
3001 it is always nonnull in practice. This is one less thing to
3002 worry about when checking for integer overflow later.
3003 (x_check_image_size): New function, which checks for integer
3004 overflow issues inside X.
3005 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3006 This removes the need for a memory_full check.
3007 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3008 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3009 (xbm_read_bitmap_data): Change locals back to 'int', since
3010 their values must fit in 'int'.
3011 (xpm_load_image, png_load, tiff_load):
3012 Invoke x_create_x_image_and_pixmap earlier,
3013 to avoid much needless work if the image is too large.
3014 (tiff_load): Treat overly large images as if
3015 x_create_x_image_and_pixmap failed, not as malloc failures.
3016 (gs_load): Use x_check_image_size.
3017
5f8f9cc2
PE
3018 * gtkutil.c: Omit integer casts.
3019 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3020 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3021
5adf60bc
PE
3022 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3023
c8907a93
PE
3024 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3025 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3026 would wrongly return t on a 64-bit host.
3027
e3c25c68
PE
3028 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3029 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3030 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3031 and therefore cause GCC to emit a bogus diagnostic in some cases.
3032
3f791afe
PE
3033 * image.c: Integer signedness and overflow and related fixes.
3034 This is not an exhaustive set of fixes, but it's time to
3035 record what I've got.
3036 (lookup_pixel_color, check_image_size): Remove redundant decls.
3037 (check_image_size): Don't assume that arbitrary EMACS_INT values
3038 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3039 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3040 (tiff_load, imagemagick_load_image):
3041 Check for overflow in size calculations.
3042 (x_create_x_image_and_pixmap): Remove unnecessary test for
3043 xmalloc returning NULL; that can't happen.
3044 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3045 (xpm_color_bucket): Use better integer hashing function.
3046 (xpm_cache_color): Don't possibly over-allocate memory.
3047 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3048 (gif_memory_source):
3049 Use ptrdiff_t, not int or size_t, to record sizes.
3050 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3051 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3052 either works, as we prefer signed integers.
3053 (tiff_read_from_memory, tiff_write_from_memory):
3054 Return tsize_t, not size_t, since that's what the TIFF API wants.
3055 (tiff_read_from_memory): Don't fail simply because the read would
3056 go past EOF; instead, return a short read.
3057 (tiff_load): Omit no-longer-needed casts.
3058 (Fimagemagick_types): Don't assume size fits into 'int'.
3059
3cc5a532
PE
3060 Improve hashing quality when configured --with-wide-int.
3061 * fns.c (hash_string): New function, taken from sxhash_string.
3062 Do not discard information about ASCII character case; this
3063 discarding is no longer needed.
3064 (sxhash-string): Use it. Change sig to match it. Caller changed.
3065 * lisp.h: Declare it.
3066 * lread.c (hash_string): Remove, since we now use fns.c's version.
3067 The fns.c version returns a wider integer if --with-wide-int is
3068 specified, so this should help the quality of the hashing a bit.
3069
b312a492
PE
3070 * emacs.c: Integer overflow minor fix.
3071 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3072 Define only if GNU_LINUX.
3073 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3074
dfd153ae
PE
3075 * dispnew.c: Integer signedness and overflow fixes.
3076 Remove unnecessary forward decls, that were a maintenance hassle.
3077 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3078 All uses changed.
3079 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3080 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3081 (prepare_desired_row, line_draw_cost):
3082 Use int, not unsigned, where either works.
3083 (save_current_matrix, restore_current_matrix):
3084 Use ptrdiff_t, not size_t, where either works.
3085 (init_display): Check for overflow more accurately, and without
3086 relying on undefined behavior.
3087
a81d11a3
PE
3088 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3089 Remove, replacing with the new symbols in lisp.h. All uses changed.
3090 * fileio.c (make_temp_name):
3091 * filelock.c (lock_file_1, lock_file):
3092 * xdisp.c (message_dolog):
3093 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3094 Use pMd etc. instead.
3095 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3096 replacing the pWIDE etc. symbols removed from editfns.c.
3097
3300e6fd
PE
3098 * keyboard.h (num_input_events): Now uintmax_t.
3099 This is (very slightly) less likely to mess up due to wraparound.
3100 All uses changed.
3101
fd05c7e9
PE
3102 * buffer.c: Integer signedness fixes.
3103 (alloc_buffer_text, enlarge_buffer_text):
3104 Use ptrdiff_t rather than size_t when either will do, as we prefer
3105 signed integers.
3106
903fe15d
PE
3107 * alloc.c: Integer signedness and overflow fixes.
3108 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3109 (__malloc_size_t): Default to size_t, not to int.
3110 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3111 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3112 Prefer ptrdiff_t to size_t when either would do, as we prefer
3113 signed integers.
3114 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3115 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3116 Now const. Initialize with values that are in range even if char
3117 is signed.
3118 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3119 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3120 These functions do the right thing with sizes > 2**32.
3121 (check_depth): Now ptrdiff_t, not int.
3122 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3123 Adjust to new way of storing sizes. Check for size overflow bugs
3124 in rest of code.
3125 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3126 slightly wrong anyway, as it missed one instance of
3127 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3128 (refill_memory_reserve): Omit needless cast to size_t.
3129 (mark_object_loop_halt): Mark as externally visible.
3130
ac82cc6a
PE
3131 * xselect.c: Integer signedness and overflow fixes.
3132 (Fx_register_dnd_atom, x_handle_dnd_message):
3133 Use ptrdiff_t, not size_t, since we prefer signed.
3134 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3135 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3136 x_dnd_atoms_size and x_dnd_atoms_length.
3137
c2d1e36d
PE
3138 * doprnt.c: Prefer signed to unsigned when either works.
3139 * eval.c (verror):
3140 * doprnt.c (doprnt):
3141 * lisp.h (doprnt):
3142 * xdisp.c (vmessage):
3143 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3144 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3145 prefer signed arithmetic to avoid comparison confusion.
3146 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3147 but is a bit tricky.
3148
0e926e56
PE
3149 Assume freestanding C89 headers, string.h, stdlib.h.
3150 * data.c, doprnt.c, floatfns.c, print.c:
3151 Include float.h unconditionally.
3152 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3153 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3154 * regex.c: Likewise for stddef.h, string.h.
3155 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3156 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3157 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3158 (STDC_HEADERS): Remove obsolete defines.
3159 * sysdep.c: Include limits.h unconditionally.
3160
9cfdb3ec
PE
3161 Assume support for memcmp, memcpy, memmove, memset.
3162 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3163 * regex.c (memcmp, memcpy):
3164 Remove; we assume C89 now.
3165
3166 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3167 (__malloc_safe_bcopy): Remove; no longer needed.
3168
cf950e6b 3169 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3170 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3171 well either way, and we prefer signed to unsigned.
3172
dbf38e02
LMI
31732011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3174
3175 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3176 closes the connection while we're reading (bug#9182).
3177
d6f0886c 31782011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3179
d6f0886c
JD
3180 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3181 are specified (Bug#9168).
24e0f6b1 3182
2eb1f9e6
PE
31832011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3186 Found by GCC static checking and --with-wide-int on a 32-bit host.
3187
22381272 31882011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3189
3190 * xdisp.c (compute_display_string_pos): Fix logic of caching
3191 previous display string position. Initialize cached_prev_pos to
3192 -1. Fixes slow-down at the beginning of a buffer.
3193
f25e39b4
EZ
31942011-07-24 Eli Zaretskii <eliz@gnu.org>
3195
3196 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3197 for attrs[LFACE_FONTSET_INDEX].
3198
04c4b52e
PE
31992011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3200
3201 * xml.c (parse_region): Remove unused local
3202 that was recently introduced.
3203
c1734fbd
EZ
32042011-07-23 Eli Zaretskii <eliz@gnu.org>
3205
be18c5a5
EZ
3206 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3207 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3208
c1734fbd
EZ
3209 * xdisp.c (move_it_in_display_line_to): Record the best matching
3210 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3211 exit if none of the characters scanned was an exact match.
3212 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3213 when exact match is impossible due to invisible text, and the
3214 lines are truncated.
3215
a258d627
JD
32162011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3217
3218 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3219 for OSX >= 10.7.
3220
b6d5a689
EZ
32212011-07-22 Eli Zaretskii <eliz@gnu.org>
3222
0f74f785
EZ
3223 Fix a significant slow-down of cursor motion with C-n, C-p,
3224 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3225 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3226 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3227 (next_element_from_buffer): Call compute_stop_pos_backwards to
3228 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3229 base_level_stop.
3230 (reseat): Don't look for prev_stop, as that could mean a very long
3231 run.
3232 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3233 <cached_disp_overlay_modiff>: Cache for last found display string
3234 position.
551918c1 3235 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3236 about the same buffer in the same area of character positions, and
3237 the buffer wasn't changed since the time the display string
3238 position was cached.
551918c1 3239
b2d0c91a
EZ
32402011-07-22 Eli Zaretskii <eliz@gnu.org>
3241
3242 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3243 is an integer, which is important for empty lines. (Bug#9149)
3244
043604ee
CY
32452011-07-22 Chong Yidong <cyd@stupidchicken.com>
3246
3247 * frame.c (Fmodify_frame_parameters): In tty case, update the
3248 default face if necessary (Bug#4238).
3249
da4adb04
CY
32502011-07-21 Chong Yidong <cyd@stupidchicken.com>
3251
3252 * editfns.c (Fstring_to_char): No need to explain what a character
3253 is in the docstring (Bug#6576).
3254
9abd0532
LMI
32552011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3256
3257 * xml.c (parse_region): Make sure we always return a tree.
3258
36881d16
HK
32592011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3260
3261 * xml.c (parse_region): If a document contains only comments,
3262 return that, too.
3263
1e98674d
LMI
32642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3265
3266 * xml.c (make_dom): Return comments, too.
3267
590bd467
PE
32682011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 Port to OpenBSD.
3271 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3272 and the surrounding thread.
3273 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3274 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3275 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3276 timer goes off.
3277 * s/openbsd.h (BROKEN_SIGIO): Define.
3278 * unexelf.c (unexec) [__OpenBSD__]:
3279 Don't update the .mdebug section of the Alpha COFF symbol table.
3280
f41628b2
LMI
32812011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3282
3283 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3284 (bug#8460).
3285
b59b67c5
PE
32862011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3287
15e3a074
PE
3288 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3289 This fixes some race conditions on the permissions of any newly
3290 created file.
3291
41bed37d
PE
3292 * alloc.c (valid_pointer_p): Use pipe, not open.
3293 This fixes some permissions issues when debugging.
3294
b59b67c5
PE
3295 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3296 If fchown fails to set both uid and gid, try to set just gid,
3297 as that is sometimes allowed. Adjust the file's mode to eliminate
3298 setuid or setgid bits that are inappropriate if fchown fails.
3299
925a6be7
SM
33002011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3301
3302 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3303 to compare Lisp_Objects.
3304 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3305 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3306 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3307
52968808
AS
33082011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3309
0a6a104b
AS
3310 * lread.c (read_integer): Unread even EOF character.
3311 (read1): Likewise. Properly record start position of symbol.
3312
52968808
AS
3313 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3314 symbol character follows.
3315
9e381cdd
PE
33162011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3317
3318 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3319 This works around a problem with the previous change to Fcopy_file.
3320 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3321 and without this change, GCC might complain about discarding
3322 fchown's return value.
3323
b5641435
JB
33242011-07-16 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3327
a8031457
PE
33282011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3331
dd889327
LMI
33322011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3333
750c33f7
LMI
3334 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3335 it's used from the C level.
3336
dd889327
LMI
3337 * process.c: Use the same condition for POLL_FOR_INPUT in both
3338 keyboard.c and process.c (bug#1858).
3339
87e86684
LM
33402011-07-09 Lawrence Mitchell <wence@gmx.li>
3341
3342 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3343 (Fgnutls_boot): Use it.
3344
64348f40
AS
33452011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3346
3347 * doc.c (Fsubstitute_command_keys): Revert last change.
3348
1d698799
LMI
33492011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3350
f863868c
LMI
3351 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3352 quotes the next character, and doesn't affect other longer
3353 sequences (bug#8935).
3354
1d698799
LMI
3355 * lread.c (syms_of_lread): Clarify that is isn't only
3356 `eval-buffer' and `eval-defun' that's affected by
3357 `lexical-binding' (bug#8460).
3358
aa4b6df6
EZ
33592011-07-15 Eli Zaretskii <eliz@gnu.org>
3360
3361 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3362 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3363
5d856da6
PE
33642011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3365
ad6042bb
PE
3366 Fix minor problems found by static checking.
3367 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3368 (elsz): Now a signed constant, not a size_t var. We prefer signed
3369 types to unsigned, to avoid integer comparison confusion. Without
3370 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3371 "cannot optimize loop, the loop counter may overflow", a symptom
3372 of the confusion.
f00bbb22 3373 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3374 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3375
6468f31c
LMI
33762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3377
49080b10
LMI
3378 * search.c (Fre_search_backward): Mention `case-fold-search' in
3379 all the re_search_* functions (bug#8138).
3380
6468f31c
LMI
3381 * keyboard.c (Fopen_dribble_file): Document when the file is
3382 closed (bug#8056).
3383
c965adc5
EZ
33842011-07-14 Eli Zaretskii <eliz@gnu.org>
3385
df9733bf
EZ
3386 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3387 bidi_cache_idx.
3388
0bb23927
EZ
3389 Support bidi reordering of display and overlay strings.
3390 * xdisp.c (compute_display_string_pos)
3391 (compute_display_string_end): Accept additional argument STRING.
3392 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3393 (reseat_to_string): Initialize bidi_it->string.s and
3394 bidi_it->string.schars.
3395 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3396 NULL (avoids a crash in bidi_paragraph_init).
3397 Initialize itb.string.lstring.
0bb23927
EZ
3398 (init_iterator): Call bidi_init_it only of a valid
3399 buffer position was specified. Initialize paragraph_embedding to
3400 L2R.
3401 (reseat_to_string): Initialize the bidi iterator.
3402 (display_string): If we need to ignore text properties of
3403 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3404 original value of -1 will not work with bidi.)
3405 (compute_display_string_pos): First arg is now struct
3406 `text_pos *'; all callers changed. Support display properties on
3407 Lisp strings.
3408 (compute_display_string_end): Support display properties on Lisp
3409 strings.
3410 (init_iterator, reseat_1, reseat_to_string): Initialize the
3411 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3412 when iterating on a string not from display properties).
640c8776
SM
3413 (compute_display_string_pos, compute_display_string_end):
3414 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3415 arrow keys.
3416 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3417 base_level_stop; instead, set base_level_stop to BEGV.
3418 Fixes crashes in vertical-motion.
0bb23927
EZ
3419 (next_element_from_buffer): Improve commentary for when
3420 the iterator is before prev_stop.
3421 (init_iterator): Initialize bidi_p from the default value of
3422 bidi-display-reordering, not from buffer-local value. Use the
3423 buffer-local value only if initializing for buffer iteration.
3424 (handle_invisible_prop): Support invisible properties on strings
3425 that are being bidi-reordered.
3426 (set_iterator_to_next): Support bidi reordering of C strings and
3427 Lisp strings.
3428 (next_element_from_string): Support bidi reordering of Lisp
3429 strings.
3430 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3431 (display_string): Support display of R2L glyph rows.
3432 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3433 (init_iterator): Don't initialize it->bidi_p for strings
3434 here.
3435 (reseat_to_string): Initialize it->bidi_p for strings here.
3436 (next_element_from_string, next_element_from_c_string)
3437 (next_element_from_buffer): Add xassert's for correspondence
3438 between IT's object being iterated and it->bidi_it.string
3439 structure.
3440 (face_before_or_after_it_pos): Support bidi iteration.
3441 (next_element_from_c_string): Handle the case of the first string
3442 character that is not the first one in the visual order.
3443 (get_visually_first_element): New function, refactored from common
3444 parts of next_element_from_buffer, next_element_from_string, and
3445 next_element_from_c_string.
3446 (tool_bar_lines_needed, redisplay_tool_bar)
3447 (display_menu_bar): Force left-to-right direction. Add a FIXME
3448 comment for making that be controlled by a user option.
3449 (push_it, pop_it): Save and restore the state of the
3450 bidi iterator. Save and restore the bidi_p flag.
3451 (pop_it): Iterate out of display property for string iteration as
3452 well.
3453 (iterate_out_of_display_property): Support iteration over strings.
3454 (handle_single_display_spec): Set up it->bidi_it for iteration
3455 over a display string, and call bidi_init_it.
3456 (handle_single_display_spec, next_overlay_string)
3457 (get_overlay_strings_1, push_display_prop): Set up the bidi
3458 iterator for displaying display or overlay strings.
3459 (forward_to_next_line_start): Don't use the shortcut if
3460 bidi-iterating.
3461 (back_to_previous_visible_line_start): If handle_display_prop
3462 pushed the iterator stack, restore the internal state of the bidi
3463 iterator by calling bidi_pop_it same number of times.
3464 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3465 and we are bidi-iterating, don't decrement the iterator position;
3466 instead, set the first_elt flag in the bidi iterator, to produce
3467 the same effect.
3468 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3469 (push_display_prop): xassert that we are iterating a buffer.
3470 (push_it, pop_it): Save and restore paragraph_embedding member.
3471 (handle_single_display_spec, next_overlay_string)
3472 (get_overlay_strings_1, reseat_1, reseat_to_string)
3473 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3474 correctly. Don't assume unibyte strings are not bidi-reordered.
3475 (compute_display_string_pos)
3476 (compute_display_string_end): Fix handling the case of C string.
3477 (push_it, pop_it): Save and restore from_disp_prop_p.
3478 (handle_single_display_spec, push_display_prop): Set the
3479 from_disp_prop_p flag.
3480 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3481 (pop_it): Call iterate_out_of_display_property only if we are
3482 popping after iteration over a string that came from a display
3483 property. Fix a typo in popping stretch info. Add an assertion
3484 for verifying that the iterator position is in sync with the bidi
3485 iterator.
3486 (handle_single_display_spec, get_overlay_strings_1)
3487 (push_display_prop): Fix initialization of paragraph direction for
3488 string when that of the parent object is not yet determined.
3489 (reseat_1): Call bidi_init_it to resync the bidi
3490 iterator with IT's position. (Bug#7616)
3491 (find_row_edges): If ROW->start.pos gives position
3492 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3493 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3494 Reset the from_disp_prop_p flag.
3495 (SAVE_IT, RESTORE_IT): New macros.
3496 (pos_visible_p, face_before_or_after_it_pos)
3497 (back_to_previous_visible_line_start)
3498 (move_it_in_display_line_to, move_it_in_display_line)
3499 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3500 (try_scrolling, redisplay_window, display_line): Use them when
3501 saving a temporary copy of the iterator and restoring it back.
3502 (back_to_previous_visible_line_start, reseat_1)
3503 (init_iterator): Empty the bidi cache "stack".
3504 (move_it_in_display_line_to): If iterator ended up at
3505 EOL, but we never saw any buffer positions smaller than
3506 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3507 motion in bidi-reordered lines.
3508 (move_it_in_display_line_to): Record prev_method and prev_pos
3509 immediately before the call to set_iterator_to_next. Fixes cursor
3510 motion in bidi-reordered lines with stretch glyphs and strings
3511 displayed in margins. (Bug#8133) (Bug#8867)
3512 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3513 TO_CHARPOS.
640c8776
SM
3514 (pos_visible_p): Support positions in bidi-reordered lines.
3515 Save and restore bidi cache.
0bb23927
EZ
3516
3517 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3518 (bidi_paragraph_info): Delete unused struct.
3519 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3520 (bidi_cache_start): New variable.
3521 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3522 to zero.
3523 (bidi_cache_fetch_state, bidi_cache_search)
3524 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3525 (bidi_cache_find, bidi_peek_at_next_level)
3526 (bidi_level_of_next_char, bidi_find_other_level_edge)
3527 (bidi_move_to_visually_next): Compare cache index with
3528 bidi_cache_start rather than with zero.
3529 (bidi_fetch_char): Accept new argument STRING; all callers
3530 changed. Support iteration over a string. Support strings with
3531 display properties. Support unibyte strings. Fix the type of
3532 `len' according to what STRING_CHAR_AND_LENGTH expects.
3533 (bidi_paragraph_init, bidi_resolve_explicit_1)
3534 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3535 (bidi_level_of_next_char, bidi_move_to_visually_next):
3536 Support iteration over a string.
0bb23927
EZ
3537 (bidi_set_sor_type, bidi_resolve_explicit_1)
3538 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3539 can now be zero (for strings); special values 0 and -1 were
3540 changed to -1 and -2, respectively.
3541 (bidi_char_at_pos): New function.
3542 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3543 Call it instead of FETCH_MULTIBYTE_CHAR.
3544 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3545 initialized to valid values.
3546 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3547 values.
3548 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3549 the test for valid cached positions. Fix the logic for looking up
3550 the sentinel state in the cache. GCPRO the Lisp string we are
3551 iterating.
3552 (bidi_push_it, bidi_pop_it): New functions.
3553 (bidi_initialize): Initialize the bidi cache start stack pointer.
3554 (bidi_cache_ensure_space): New function, refactored from part of
3555 bidi_cache_iterator_state. Don't assume the required size is just
3556 one BIDI_CACHE_CHUNK away.
3557 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3558 (bidi_count_bytes, bidi_char_at_pos): New functions.
3559 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3560 always valid if bidi_cache_idx is valid.
3561 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3562 is valid if it's going to be used.
3563 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3564 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3565 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3566 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3567 (bidi_find_other_level_edge, bidi_cache_start_stack):
3568 All variables related to cache indices are now EMACS_INT.
c965adc5 3569
0bb23927
EZ
3570 * dispextern.h (struct bidi_string_data): New structure.
3571 (struct bidi_it): New member `string'. Make flag members be 1-bit
3572 fields, and put them last in the struct.
640c8776
SM
3573 (compute_display_string_pos, compute_display_string_end):
3574 Update prototypes.
0bb23927
EZ
3575 (bidi_push_it, bidi_pop_it): Add prototypes.
3576 (struct iterator_stack_entry): New members bidi_p,
3577 paragraph_embedding, and from_disp_prop_p.
3578 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3579 (bidi_shelve_cache, bidi_unshelve_cache):
3580 Declare prototypes.
0bb23927
EZ
3581
3582 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3583 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3584 and vector-like objects.
3585
3586 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3587 cache around display iteration.
3588
3589 * window.c (Fwindow_end, window_scroll_pixel_based)
3590 (displayed_window_lines, Frecenter): Save and restore the bidi
3591 cache around display iteration.
3592
3bbd2265
LMI
35932011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3594
3595 * editfns.c (Fdelete_region): Clarify the use of the named
3596 parameters (bug#6788).
3597
adc47434
MR
35982011-07-14 Martin Rudalics <rudalics@gmx.at>
3599
3600 * indent.c (Fvertical_motion): Set and restore w->pointm when
3601 saving and restoring the window's buffer (Bug#9006).
3602
837c31f8
LMI
36032011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3604
3605 * editfns.c (Fstring_to_char): Clarify just what is returned
3606 (bug#6576). Text by Eli Zaretskii.
3607
ac389d0c
JB
36082011-07-13 Juanma Barranquero <lekktu@gmail.com>
3609
3610 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3611
0be0ce47
EZ
36122011-07-13 Eli Zaretskii <eliz@gnu.org>
3613
3614 * buffer.c (mmap_find): Fix a typo.
3615
cd18e7e3
JB
36162011-07-13 Johan Bockgård <bojohan@gnu.org>
3617
3618 Fix execution of x selection hooks.
3619 * xselect.c (Qx_lost_selection_functions)
3620 (Qx_sent_selection_functions): New vars.
3621 (syms_of_xselect): DEFSYM them.
3622 (x_handle_selection_request): Pass Qx_sent_selection_functions
3623 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3624 (x_handle_selection_clear,x_clear_frame_selections):
3625 Pass Qx_lost_selection_functions rather than
3626 Vx_lost_selection_functions to Frun_hook_with_args.
3627
47ea7f44
PE
36282011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3629
ac389d0c 3630 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3631 The old code sometimes used this field without initializing it.
3632
47ea7f44
PE
3633 * alloc.c (gc_sweep): Don't read past end of array.
3634 In theory, the old code could also have corrupted Emacs internals,
3635 though it'd be very unlikely.
3636
bc985c87
AS
36372011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3638
3639 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3640 argument. (Bug#4026)
bc985c87 3641
0cf34688
LMI
36422011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3643
b3dadd76
LMI
3644 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3645 key" (bug#4257).
3646
0cf34688
LMI
3647 * window.c (Fset_window_start): Doc fix (bug#4199).
3648 (Fset_window_hscroll): Ditto.
3649
270768cd
PE
36502011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3651
077e3dda 3652 Fix minor new problems caught by GCC 4.6.1.
270768cd 3653 * term.c (init_tty): Remove unused local.
490011a6 3654 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3655 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3656 not used otherwise.
270768cd 3657
b1f58454
CY
36582011-07-12 Chong Yidong <cyd@stupidchicken.com>
3659
3660 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3661
22b9578d
LMI
36622011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3663
6e70ab07
LMI
3664 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3665 are the mini-buffer and the echo area (bug#3320).
3666
22b9578d
LMI
3667 * term.c (init_tty): Remove support for supdup, c10 and perq
3668 terminals, which are no longer supported (bug#1482).
3669
8974cc9f
JB
36702011-07-10 Johan Bockgård <bojohan@gnu.org>
3671
3672 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3673
a560d974
JD
36742011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3675
3676 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3677 for non-popups (Bug#3642).
3678
1dae0f0a
AS
36792011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3680
268c2c36 3681 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3682 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3683 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3684 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3685 * data.c (fmod): Likewise.
3686 * dispnew.c (swap_glyphs_in_rows): Likewise.
3687 * emacs.c (memory_warning_signal): Likewise.
3688 * floatfns.c (float_error): Likewise.
3689 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3690 (otf_open, font_otf_capability, generate_otf_features)
3691 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3692 Likewise.
3693 * image.c (pbm_read_file): Likewise.
3694 * indent.c (string_display_width): Likewise.
3695 * intervals.c (check_for_interval, search_for_interval)
3696 (inc_interval_count, count_intervals, root_interval)
3697 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3698 * lread.c (defalias): Likewise.
268c2c36 3699 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3700 * regex.c (set_image_of_range_1, set_image_of_range)
3701 (regex_grow_registers): Likewise.
3702 * sysdep.c (strerror): Likewise.
3703 * termcap.c (valid_filename_p, tprint, main): Likewise.
3704 * tparam.c (main): Likewise.
3705 * unexhp9k800.c (run_time_remap, save_data_space)
3706 (update_file_ptrs, read_header, write_header, calculate_checksum)
3707 (copy_file, copy_rest, display_header): Likewise.
3708 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3709 Likewise.
3710 * xdisp.c (check_it): Likewise.
3711 * xfaces.c (register_color, unregister_color, unregister_colors):
3712 Likewise.
3713 * xfns.c (print_fontset_result): Likewise.
3714 * xrdb.c (member, fatal, main): Likewise.
3715
99033785
PE
37162011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3717
3718 Fix minor problems found by static checking (Bug#9031).
3719 * chartab.c (char_table_set_range, map_sub_char_table):
3720 Remove unused locals.
3721 (uniprop_table): Now static.
3722 * composite.c (_work_char): Remove unused static var.
3723
9cb2ac56
JB
37242011-07-09 Juanma Barranquero <lekktu@gmail.com>
3725
3726 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3727
f25661f0
JD
37282011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3729
3730 * gtkutil.c (qttip_cb): Remove code without function.
3731
8278c4fe
EZ
37322011-07-09 Eli Zaretskii <eliz@gnu.org>
3733
3734 * w32.c (pthread_sigmask): New stub.
3735
1692ae2d 37362011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3737
8a6ebd58 3738 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3739 sigprocmask is portable only for single-threaded applications, and
3740 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3741 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3742 (LIBES): Use it.
3743 * callproc.c (Fcall_process):
3744 * process.c (create_process):
3745 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3746 Use pthread_sigmask, not sigprocmask.
123403e4 3747
1b854618
JD
37482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3749
3750 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3751 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3752 wrong (Bug#8591).
3753
3fe4b549
JD
37542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3755
0ce7e563
JD
3756 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3757 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3758 (xg_hide_tooltip): Fix comment.
3759
3fe4b549
JD
3760 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3761 in registerServicesMenuSendTypes.
3762 (validRequestorForSendType): Don't check ns_return_types.
3763
3764 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3765 ns_return_type.
3766
5df75e47
JR
37672011-07-08 Jason Rumney <jasonr@gnu.org>
3768
22610910
JR
3769 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3770 SH_SHOW for hidden windows (Bug#5482).
3771
5df75e47
JR
3772 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3773 frame struct members of non-existent frames (Bug#6284).
3774
699c10bd
JD
37752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3776
4393663b
JD
3777 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3778 variable firstTime not needed on OSX >= 10.6.
3779 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3780 >= 10.5. Use setKnobProportion, setDoubleValue.
3781
3782 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3783 (MAC_OS_X_VERSION_10_5): Define if not defined.
3784 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3785 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3786 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3787
3788 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3789 cString and lossyCString on OSX >= 10.4
3790
58179cce 3791 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3792 sizeToFit on OSX >= 10.2.
3793
3794 * nsimage.m (allocInitFromFile): Don't use deprecated method
3795 bestRepresentationForDevice on OSX >= 10.6.
3796
3797 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3798 to avoid warning.
3799
3800 * emacs.c: Declare unexec_init_emacs_zone.
3801
a63e0781
JD
3802 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3803
699c10bd
JD
3804 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3805
3806 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3807 on svcsMenu (Bug#8842).
3808
3809 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3810 ns_return_types.
3811 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3812
3813 * nsterm.m (QUTF8_STRING): Declare.
3814 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3815 (validRequestorForSendType): Return type is (id).
3816 Change indexOfObjectIdenticalTo to indexOfObject.
3817 Check if we have local selection before returning self (Bug#8842).
3818 (writeSelectionToPasteboard): Put local selection into paste board
3819 if we have a local selection (Bug#8842).
3820 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3821
3822 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3823 (ns_get_local_selection): Declare.
3824
54e10184
LMI
38252011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826
9888ff71
LMI
3827 * keymap.c (describe_map_tree): Don't insert a double newline at
3828 the end of the buffer (bug#1169) and return whether we inserted
3829 something.
3830
54e10184
LMI
3831 * callint.c (Fcall_interactively): Change "reading args" to
3832 "providing args" to try to clarify what it does (bug#1010).
3833
15fa4783
KH
38342011-07-07 Kenichi Handa <handa@m17n.org>
3835
3836 * composite.c (composition_compute_stop_pos): Ignore a static
3837 composition starting before CHARPOS (Bug#8915).
3838
3839 * xdisp.c (handle_composition_prop): Likewise.
3840
a8815b00
EZ
38412011-07-07 Eli Zaretskii <eliz@gnu.org>
3842
3843 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3844 (Bug#9015)
3845
ef7b981d 38462011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3847
3848 * character.h (unicode_category_t): New enum type.
3849
3850 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3851 (Qchar_code_property_table): New variable.
3852 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3853 (UNIPROP_COMPRESSED_FORM_P): New macros.
3854 (char_table_ascii): Uncompress the compressed values.
3855 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3856 Uncompress the compressed values.
ac389d0c 3857 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3858 (char_table_ref_and_range): Uncompress the compressed values.
3859 (sub_char_table_set): New arg is_uniprop. Callers changed.
3860 Uncompress the compressed values.
3861 (sub_char_table_set_range): Args changed. Callers changed.
3862 (char_table_set_range): Adjuted for the above change.
3863 (map_sub_char_table): Delete args default_val and parent. Add arg
3864 top. Give decoded values to a Lisp function.
640c8776 3865 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3866 values to a Lisp function. Gcpro more variables.
3867 (uniprop_table_uncompress)
3868 (uniprop_decode_value_run_length): New functions.
3869 (uniprop_decoder, uniprop_decoder_count): New variables.
3870 (uniprop_get_decoder, uniprop_encode_value_character)
3871 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3872 New functions.
3873 (uniprop_encoder, uniprop_encoder_count): New variables.
3874 (uniprop_get_encoder, uniprop_table)
3875 (Funicode_property_table_internal, Fget_unicode_property_internal)
3876 (Fput_unicode_property_internal): New functions.
3877 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3878 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3879 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3880 char-code-property-alist.
3881
640c8776 3882 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3883 Vunicode_category_table.
3884
640c8776 3885 * font.c (font_range): Adjust for the change of
c805dec0
KH
3886 Vunicode_category_table.
3887
76b397fb
DN
38882011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3889
3890 * m/iris4d.h: Remove file, move contents ...
3891 * s/irix6-5.h: ... here.
3892
22b4128e
PE
38932011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3894
3895 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3896 * alloc.c (mark_buffer):
3897 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3898 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3899 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3900 This isn't true in general, and it's particularly not true
3901 if Emacs is configured with --with-wide-int.
3902 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3903 New macros, used in the buffer.c change.
3904
869795d6
JD
39052011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3906
3907 * xsettings.c: Use both GConf and GSettings if both are available.
3908 (store_config_changed_event): Add comment.
3909 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3910 (store_tool_bar_style_changed): New functions.
5e617bc2 3911 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3912 (struct xsettings): Move font inside HAVE_XFT.
3913 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3914 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3915 Move inside HAVE_XFT.
640c8776 3916 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3917 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3918 also.
3919 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3920 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3921 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3922 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3923 (parse_settings): Move check for font inside HAVE_XFT.
3924 (read_settings, apply_xft_settings): Add comment.
3925 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3926 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3927 call store_font_name_changed.
3928 (xft_settings_event): Add comment.
3929 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3930 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3931 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3932 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3933 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3934 (xsettings_get_system_font, xsettings_get_system_normal_font):
3935 Add comment.
869795d6 3936
d8ed26bd
PE
39372011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 Random fixes. E.g., (random) never returned negative values.
3940 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3941 subseconds part to the entropy, as that's a bit more random.
3942 Prefer signed to unsigned, since the signedness doesn't matter and
3943 in general we prefer signed. When given a limit, use a
3944 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3945 latter isn't right if USE_2_TAGS_FOR_INTS.
3946 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3947 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3948
cabf1cac
SM
39492011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3950
3951 * textprop.c (text_property_stickiness):
3952 Obey Vtext_property_default_nonsticky.
3953 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3954 * w32fns.c (syms_of_w32fns):
3955 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3956
6e9b2be9
PE
39572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3960 This is more efficient than Ffile_directory_p and avoids a minor race.
3961
90186c68
LMI
39622011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3963
7c301272
LMI
3964 * buffer.c (Foverlay_put): Say what the return value is
3965 (bug#7835).
3966
c4f2d8d4
LMI
3967 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3968 is a directory before asking whether to use the file name
3969 (bug#7564).
ad637907
LMI
3970 (barf_or_query_if_file_exists): Make the "File is a directory"
3971 error be more correct.
c4f2d8d4 3972
90186c68
LMI
3973 * fns.c (Frequire): Remove the mention of the .gz files, since
3974 that's installation-specific, but keep the mention of
3975 `get-load-suffixes'.
3976
da64016e
PE
39772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3980 Report string overflow if the output is too long.
3981
7d47b580
JB
39822011-07-04 Juanma Barranquero <lekktu@gmail.com>
3983
a555cb87
JB
3984 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3985 (syms_of_gnutls): Remove duplicate DEFSYM for
3986 Qgnutls_bootprop_verify_hostname_error, an error for
3987 Qgnutls_bootprop_verify_error (which is no longer used).
3988
7d47b580
JB
3989 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3990 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3991 Also (re)move comments that are misplaced or no longer relevant.
3992
1e49bfab
LMI
39932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3994
3995 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3996
1485f4c0
CY
39972011-07-03 Chong Yidong <cyd@stupidchicken.com>
3998
3999 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4000 and background color parameters if they have been changed.
4001
a9ab721e
LMI
40022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4003
4004 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4005
cf7cff57
PE
40062011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4007
2e13213d
PE
4008 * xsettings.c (SYSTEM_FONT): Define only when used.
4009 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4010
cf7cff57
PE
4011 * keymap.c (access_keymap_1): Now static.
4012
7a8e04f7
CY
40132011-07-02 Chong Yidong <cyd@stupidchicken.com>
4014
4015 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4016 leave any prefix arg for the up event (Bug#1586).
4017
61352f62
LMI
40182011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4019
69bb1ef7
LMI
4020 * lread.c (syms_of_lread): Mention single symbols defined by
4021 `defvar' or `defconst' (bug#7154).
4022
61352f62 4023 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4024 (Frequire): Mention get-load-suffixes.
61352f62 4025
28545e04
MR
40262011-07-02 Martin Rudalics <rudalics@gmx.at>
4027
4028 * window.h (window): Remove clone_number slot.
4029 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4030 Remove.
4031 (make_parent_window, make_window, saved_window)
4032 (Fset_window_configuration, save_window_save): Don't deal with
4033 clone numbers.
4034 * buffer.c (Qclone_number): Remove declaration.
4035 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4036
3349e122
SM
40372011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4038
4039 Add multiple inheritance to keymaps.
4040 * keymap.c (Fmake_composed_keymap): New function.
4041 (Fset_keymap_parent): Simplify.
4042 (fix_submap_inheritance): Remove.
4043 (access_keymap_1): New function extracted from access_keymap to handle
4044 embedded parents and handle lists of maps.
4045 (access_keymap): Use it.
4046 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4047 (Fcopy_keymap): Handle embedded parents.
4048 (Fcommand_remapping, define_as_prefix): Simplify.
4049 (Fkey_binding): Simplify.
4050 (syms_of_keymap): Move minibuffer-local-completion-map,
4051 minibuffer-local-filename-completion-map,
4052 minibuffer-local-must-match-map, and
4053 minibuffer-local-filename-must-match-map to Elisp.
4054 (syms_of_keymap): Defsubr make-composed-keymap.
4055 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4056 (parse_menu_item): Trivial simplification.
4057
3279eb87
GM
40582011-07-01 Glenn Morris <rgm@gnu.org>
4059
4060 * Makefile.in (SETTINGS_LIBS): Fix typo.
4061
4550efdf
KI
40622011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4063
4064 * coding.c (Fencode_coding_string): Record the last coding system
4065 used, as the function doc string says (bug#8738).
4066
0949d2b6
JD
40672011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4068
4069 * xsettings.c (store_monospaced_changed): Take new font as arg and
4070 check for change against current_mono_font.
4071 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4072 (emacs_settings_constructor, emacs_settings_get_property)
4073 (emacs_settings_set_property, emacs_settings_class_init)
4074 (emacs_settings_init, gsettings_obj): Remove.
4075 (something_changedCB): New function for HAVE_GSETTINGS.
4076 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4077 with value as argument.
4078 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4079 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4080 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4081 "changed".
4082
4083 * xgselect.c: Add defined (HAVE_GSETTINGS).
4084 (xgselect_initialize): Ditto.
4085
4086 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4087 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4088 xg_select.
4089
bbc6b304
PE
40902011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4091
4092 * eval.c (struct backtrace): Simplify and port the data structure.
4093 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4094 signed bit field, as this assumption is not portable and it makes
4095 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4096 "char debug_on_exit : 1" as this is not portable either; instead,
4097 use the portable "unsigned int debug_on_exit : 1". Remove unused
4098 member evalargs. Remove obsolete comments about cc bombing out.
4099
9851bfc5
JD
41002011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4101
51bb811f 4102 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4103 Let HAVE_GSETTINGS override HAVE_GCONF.
4104 (store_monospaced_changed): New function.
4105 (EMACS_SETTINGS): A new type derived from GObject to handle
4106 GSettings notifications.
4107 (emacs_settings_constructor, emacs_settings_get_property)
4108 (emacs_settings_set_property, emacs_settings_class_init):
4109 New functions.
4110 (gsettings_client, gsettings_obj): New variables.
4111 (GSETTINGS_SCHEMA): New define.
4112 (something_changedCB): Call store_monospaced_changed.
4113 (init_gsettings): New function.
4114 (xsettings_initialize): Call init_gsettings.
4115 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4116 to NULL.
4117
640c8776 4118 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4119 GCONF_CFLAGS/LIBS.
4120
5386012d
MR
41212011-06-29 Martin Rudalics <rudalics@gmx.at>
4122
4123 * window.c (resize_root_window, grow_mini_window)
4124 (shrink_mini_window): Rename Qresize_root_window to
4125 Qwindow_resize_root_window and Qresize_root_window_vertically to
4126 Qwindow_resize_root_window_vertically.
4127
f13e0b08
PE
41282011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4131
94515237
JB
41322011-06-27 Juanma Barranquero <lekktu@gmail.com>
4133
4134 * makefile.w32-in: Redesign dependencies so they reflect more
4135 clearly which files are directly included by each source file,
4136 and not through other includes.
4137
e43b6e43
MR
41382011-06-27 Martin Rudalics <rudalics@gmx.at>
4139
4140 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4141 (sort_overlays, overlay_strings): When an overlay's clone number
4142 matches the window's clone number process the overlay even if
4143 the overlay's window property doesn't match the current window.
4144
d68443dc
MR
4145 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4146 (Fwindow_hchild): Rename to Fwindow_left_child.
4147 (Fwindow_next): Rename to Fwindow_next_sibling.
4148 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4149 (resize_window_check): Rename to window_resize_check.
4150 (resize_window_apply): Rename to window_resize_apply.
4151 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4152 (Fdelete_other_windows_internal, resize_frame_windows)
4153 (Fsplit_window_internal, Fdelete_window_internal)
4154 (grow_mini_window, shrink_mini_window)
4155 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4156
c7e73be5
JD
41572011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4158
4159 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4160 (emacs_fixed_set_min_size): Remove.
4161 (emacs_fixed_new): Take frame as argument.
4162
4163 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4164 (_EmacsFixedPrivate): Remove minwidth/height.
4165 Add struct frame *f.
4166 (emacs_fixed_init): Initialize priv->f.
4167 (get_parent_class, emacs_fixed_set_min_size): Remove.
4168 (emacs_fixed_new): Set priv->f to argument.
4169 (emacs_fixed_get_preferred_width)
4170 (emacs_fixed_get_preferred_height): Use min_width/height from
4171 frames size_hint to set minimum and natural (Bug#8919).
4172 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4173 and use min_width/height from frames size_hint to set
4174 min_width/height (Bug#8919).
4175
4176 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4177 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4178 Fix indentation.
c7e73be5 4179
cf99dcf8
EZ
41802011-06-26 Eli Zaretskii <eliz@gnu.org>
4181
4182 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4183 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4184 called at ZV.
4185
029529ac
CY
41862011-06-26 Chong Yidong <cyd@stupidchicken.com>
4187
4188 * process.c (wait_reading_process_output): Bypass select if
4189 waiting for a cell while ignoring keyboard input, and input is
4190 pending. Suggested by Jan Djärv (Bug#8869).
4191
7a7ef429
PE
41922011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 Use gnulib's dup2 module instead of rolling our own.
4195 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4196
11fdef7d 41972011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4198
4199 * dispnew.c (scrolling_window): Before scrolling, turn off a
4200 mouse-highlight in the window being scrolled.
4201
cd3520a4
JB
42022011-06-24 Juanma Barranquero <lekktu@gmail.com>
4203
4204 Move DEFSYM to lisp.h and use everywhere.
4205
4206 * character.h (DEFSYM): Move declaration...
4207 * lisp.h (DEFSYM): ...here.
4208
4209 * gnutls.c:
4210 * minibuf.c:
4211 * w32menu.c:
4212 * w32proc.c:
4213 * w32select.c: Don't include character.h.
4214
4215 * alloc.c (syms_of_alloc):
4216 * buffer.c (syms_of_buffer):
4217 * bytecode.c (syms_of_bytecode):
4218 * callint.c (syms_of_callint):
4219 * casefiddle.c (syms_of_casefiddle):
4220 * casetab.c (init_casetab_once):
4221 * category.c (init_category_once, syms_of_category):
4222 * ccl.c (syms_of_ccl):
4223 * cmds.c (syms_of_cmds):
4224 * composite.c (syms_of_composite):
4225 * dbusbind.c (syms_of_dbusbind):
4226 * dired.c (syms_of_dired):
4227 * dispnew.c (syms_of_display):
4228 * doc.c (syms_of_doc):
4229 * editfns.c (syms_of_editfns):
4230 * emacs.c (syms_of_emacs):
4231 * eval.c (syms_of_eval):
4232 * fileio.c (syms_of_fileio):
4233 * fns.c (syms_of_fns):
4234 * frame.c (syms_of_frame):
4235 * fringe.c (syms_of_fringe):
4236 * insdel.c (syms_of_insdel):
4237 * keymap.c (syms_of_keymap):
4238 * lread.c (init_obarray, syms_of_lread):
4239 * macros.c (syms_of_macros):
4240 * msdos.c (syms_of_msdos):
4241 * print.c (syms_of_print):
4242 * process.c (syms_of_process):
4243 * search.c (syms_of_search):
4244 * sound.c (syms_of_sound):
4245 * syntax.c (init_syntax_once, syms_of_syntax):
4246 * terminal.c (syms_of_terminal):
4247 * textprop.c (syms_of_textprop):
4248 * undo.c (syms_of_undo):
4249 * w32.c (globals_of_w32):
4250 * window.c (syms_of_window):
4251 * xdisp.c (syms_of_xdisp):
4252 * xfaces.c (syms_of_xfaces):
4253 * xfns.c (syms_of_xfns):
4254 * xmenu.c (syms_of_xmenu):
4255 * xsettings.c (syms_of_xsettings):
4256 * xterm.c (syms_of_xterm): Use DEFSYM.
4257
4228cf16
TZ
42582011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4259
cd3520a4 4260 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4261
7fcccf1e
PE
42622011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4263
7efb4e0e
PE
4264 Integer and buffer overflow fixes (Bug#8873).
4265
ff5844ad
PE
4266 * print.c (printchar, strout): Check for string overflow.
4267 (PRINTPREPARE, printchar, strout):
4268 Don't set size unless allocation succeeds.
4269
90532f02
PE
4270 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4271 for sizes. Check for string overflow more accurately.
4272 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4273
6d84508d
PE
4274 * macros.c: Integer and buffer overflow fixes.
4275 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4276 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4277 Use ptrdiff_t, not int, for sizes.
4278 Don't increment bufsize until after realloc succeeds.
4279 Check for size-calculation overflow.
4280 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4281
437b2cb4
PE
4282 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4283
8b9ac8b4
PE
4284 * lread.c: Integer overflow fixes.
4285 (read_integer): Radix is now EMACS_INT, not int,
4286 to improve quality of diagnostics for out-of-range radices.
4287 Calculate buffer size correctly for out-of-range radices.
4288 (read1): Check for integer overflow in radices, and in
4289 read-circle numbers.
82cb60d3
PE
4290 (read_escape): Avoid int overflow.
4291 (Fload, openp, read_buffer_size, read1)
4292 (substitute_object_recurse, read_vector, read_list, map_obarray):
4293 Use ptrdiff_t, not int, for sizes.
4294 (read1): Use EMACS_INT, not int, for sizes.
20270765 4295 Check for size overflow.
8b9ac8b4 4296
7fcccf1e
PE
4297 * image.c (cache_image): Check for size arithmetic overflow.
4298
bfbbd7e7
PE
4299 * lread.c: Integer overflow issues.
4300 (saved_doc_string_size, saved_doc_string_length)
4301 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4302 Now ptrdiff_t, not int.
4303 (read1): Don't assume doc string length fits in int. Check for
4304 out-of-range doc string lengths.
4305 (read_list): Don't assume file position fits in int.
39019e54 4306 (read_escape): Check for hex character overflow.
bfbbd7e7 4307
4e323265
LL
43082011-06-22 Leo Liu <sdl.web@gmail.com>
4309
4310 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4311 Move to minibuffer.el.
4312
85fece3e
PE
43132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4314
20b84ce9 4315 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4316 The following patches are for when GLYPH_DEBUG && !XASSERT.
4317 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4318 * dispnew.c (flush_stdout):
4319 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4320 Mark as externally visible.
4321 * dispnew.c (check_window_matrix_pointers): Now static.
4322 * dispnew.c (window_to_frame_vpos):
4323 * xfns.c (unwind_create_frame):
4324 * xterm.c (x_check_font): Remove unused local.
4325 * scroll.c (CHECK_BOUNDS):
4326 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4327 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4328 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4329 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4330 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4331 Now static.
4332 (debug_method_add): Use va_list and vsprintf rather than relying
4333 on undefined behavior with wrong number of arguments.
4334 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4335 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4336 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4337 since we're not interested in debugging glyphs with old libraries.
4338 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4339 GCC 4.6.0's static checking.
4340
0766b489
PE
43412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4342
31fd4b32
PE
4343 Integer overflow and signedness fixes (Bug#8873).
4344 A few related buffer overrun fixes, too.
4345
b79e8648
PE
4346 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4347
0766b489
PE
4348 * dispextern.h (struct face.stipple):
4349 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4350 (x_bitmap_mask, x_allocate_bitmap_record)
4351 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4352 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4353 (x_create_bitmap_from_xpm_data):
4354 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4355 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4356 (.bitmaps_last):
4357 * xfaces.c (load_pixmap):
4358 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4359 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4360 (.bitmaps_last, struct x_output.icon_bitmap):
4361 Use ptrdiff_t, not int, for bitmap indexes.
4362 (x_allocate_bitmap_record): Check for size overflow.
4363 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4364
b081724f
PE
4365 Use ptrdiff_t, not int, for overlay counts.
4366 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4367 * editfns.c (overlays_around, get_pos_property):
4368 * textprop.c (get_char_property_and_overlay):
4369 * xdisp.c (next_overlay_change, note_mouse_highlight):
4370 * xfaces.c (face_at_buffer_position):
21514da7
PE
4371 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4372 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4373 (Fnext_overlay_change, Fprevious_overlay_change)
4374 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4375 Use ptrdiff_t, not int, for sizes.
21514da7 4376 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4377
3de73e5e
PE
4378 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4379
2606c57b
PE
4380 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4381 (x_session_initialize): Do not assume string length fits in int.
4382
aaafe47a
PE
4383 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4384 This is unlikely, but can occur if DPI is outlandish.
4385
2674ddc8 4386 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4387 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4388
28154962
PE
4389 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4390 * xrdb.c (magic_file_p, search_magic_path):
4391 Omit last arg SUFFIX; it was always 0. All callers changed.
4392 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4393
7de51af5
PE
4394 * xfont.c (xfont_match): Avoid need for strlen.
4395
25ed6cc3
PE
4396 * xfns.c: Don't assume strlen fits in int.
4397 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4398
4eab31dd
PE
4399 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4400 not unsigned long, as we prefer signed integers. All callers changed.
4401 Detect integer overflow in repeat count.
4402 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4403 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4404
171e2a58
PE
4405 * termcap.c: Don't assume sizes fit in int and never overflow.
4406 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4407 (gobble_line): Check for size-calculation overflow.
4408
ad39faca 4409 * minibuf.c (Fread_buffer):
6e5bb2dc 4410 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4411 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4412 Don't assume string length fits in int.
4413
52c61c22 4414 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4415 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4416
b5b8c9e5
PE
4417 * font.c: Don't assume string length fits in int.
4418 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4419 Use ptrdiff_t, not int.
ccd6111c
PE
4420 (font_intern_prop): Don't assume string length fits in int.
4421 Don't assume integer property fits in fixnum.
4422 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4423
882f0d81 4424 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4425 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4426 Reformulate so as not to need the command string.
4427 Invoke gzip -cd rather than gunzip, as it's more portable.
4428 (lock_info_type, lock_file_1, lock_file):
4429 Don't assume pid_t and time_t fit in unsigned long.
4430 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4431 (current_lock_owner): Prefer signed type for sizes.
4432 Use memcpy, not strncpy, where memcpy is what is really wanted.
4433 Don't assume (via atoi) that time_t and pid_t fit in int.
4434 Check for time_t and/or pid_t out of range, e.g., via a network share.
4435 Don't alloca where an auto var works fine.
4436
93f4cf88
PE
4437 * fileio.c: Fix some integer overflow issues.
4438 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4439 Don't assume string length fits in int.
4440 (directory_file_name): Don't assume string length fits in long.
4441 (make_temp_name): Don't assume pid fits in int, or that its print
4442 length is less than 20.
4443
f3e92b69
PE
4444 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4445
1bfdaf10
PE
4446 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4447
35016e9a
PE
4448 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4449
3d1e65a1
PE
4450 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4451 We prefer signed integers, even for size calculations.
4452
0b963a93
PE
4453 * emacs.c: Don't assume string length fits in 'int'.
4454 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4455 (main): Don't invoke strlen when not needed.
4456
573f4b54
PE
4457 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4458 (XD_DEBUG_MESSAGE): Don't waste a byte.
4459
989f33ba
PE
4460 * callproc.c (getenv_internal_1, getenv_internal)
4461 (Fgetenv_internal):
965d34eb
PE
4462 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4463
e4d29b33
PE
4464 * lread.c (invalid_syntax): Omit length argument.
4465 All uses changed. This doesn't fix a bug, but it simplifies the
4466 code away from its former Hollerith-constant appearance, and it's
4467 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4468 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4469
eb49b136
PE
4470 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4471 This didn't break anything, but it didn't help either.
4472 It's confusing to put a bogus integer in a place where the actual
4473 value does not matter.
9f62aeb1 4474 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4475 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4476
15375a22
PE
4477 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4478 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4479 implementation.
b61cc01c
PE
4480 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4481 We prefer signed types, and the value cannot exceed the EMACS_INT
4482 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4483 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4484 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4485 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4486
53b2623d
PE
4487 * indent.c (sane_tab_width): New function.
4488 (current_column, scan_for_column, Findent_to, position_indentation)
4489 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4490 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4491
51cab52b 4492 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4493
f2ed8a70
PE
4494 * lisp.h (lint_assume): New macro.
4495 * composite.c (composition_gstring_put_cache):
4496 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4497
abe80cc6
PE
4498 * editfns.c, insdel.c:
4499 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4500
b02c740e
PE
4501 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4502
ebc96716
PE
4503 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4504
b4e50fa0 4505 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4506 Use much-faster test for byte-length change.
311d5d7c 4507 Don't assume string byte-length fits in 'int'.
a4cf38e4 4508 Check that character arg fits in 'int'.
85461888 4509 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4510
c0c1ee9f
PE
4511 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4512
a498d7f4
PE
4513 * fns.c (concat): Catch string overflow earlier.
4514 Do not rely on integer wraparound.
4515
51cab52b
PE
4516 * dispextern.h (struct it.overlay_strings_charpos)
4517 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4518 * xdisp.c (forward_to_next_line_start)
4519 (back_to_previous_visible_line_start)
4520 (reseat_at_next_visible_line_start, next_element_from_buffer):
4521 Don't arbitrarily truncate the value of 'selective' to int.
4522
76031fad
PE
4523 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4524
5eb55db9
PE
4525 * composite.c: Don't truncate sizes to 'int'.
4526 (composition_gstring_p, composition_reseat_it)
4527 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4528 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4529 not EMACS_UINT, for indexes.
5eb55db9 4530
0703a717
PE
4531 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4532
d6202519
PE
4533 * buffer.c: Include <verify.h>.
4534 (struct sortvec.priority, struct sortstr.priority):
8961a454 4535 Now EMACS_INT, not int.
c20998a7 4536 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4537 (struct sortstr.size, record_overlay_string)
4538 (struct sortstrlist.size, struct sortlist.used):
4539 Don't truncate size to int.
4540 (record_overlay_string): Check for size-calculation overflow.
d6202519 4541 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4542
d5a19415
JM
45432011-06-22 Jim Meyering <meyering@redhat.com>
4544
029529ac 4545 Don't leak an XBM-image-sized buffer
d5a19415
JM
4546 * image.c (xbm_load): Free the image buffer after using it.
4547
a9041e6c
PE
45482011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4549
4550 Port to Sun C.
4551 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4552 that Sun C diagnosed.
4553 * fns.c (secure_hash): Fix pointer signedness issue.
4554 * intervals.c (static_offset_intervals): New function.
4555 (offset_intervals): Use it.
4556
7f3f739f
LL
45572011-06-21 Leo Liu <sdl.web@gmail.com>
4558
4559 * deps.mk (fns.o):
4560 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4561 sha512.h.
4562
4563 * fns.c (secure_hash): Rename from crypto_hash_function and change
4564 the first arg to accept symbols.
5b66d427 4565 (Fsecure_hash): New primitive.
7f3f739f
LL
4566 (syms_of_fns): New symbols.
4567
76147d94
DD
45682011-06-20 Deniz Dogan <deniz@dogan.se>
4569
4570 * process.c (Fset_process_buffer): Clarify return value in
4571 docstring.
4572
7d7d0045
CY
45732011-06-18 Chong Yidong <cyd@stupidchicken.com>
4574
4575 * dispnew.c (add_window_display_history): Use BVAR.
4576
4577 * xdisp.c (debug_method_add): Use BVAR.
4578 (check_window_end, dump_glyph_matrix, dump_glyph)
4579 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4580
4581 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4582 Likewise.
4583
4584 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4585 check till after the cache is created in init_frame_faces.
4586
ff2bc410
SM
45872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4588
4589 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4590
28177add
PE
45912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4592
dd3482fe
PE
4593 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4594 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4595 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4596
393d71f3 4597 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4598 * fileio.c (Finsert_file_contents):
4599 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4600 Remove the old (too-loose) buffer overflow checks.
4601 They weren't needed, since make_gap checks for buffer overflow.
4602 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4603 The old code merely checked for Emacs fixnum overflow, and relied
4604 on undefined (wraparound) behavior. The new code avoids undefined
4605 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4606
2e6813b0 4607 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4608 Tune. Don't use wider integers than needed. Don't use alloca.
4609 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4610
599a9e4f
PE
4611 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4612
99561444
PE
4613 * insdel.c, lisp.h (buffer_overflow): New function.
4614 (insert_from_buffer_1, replace_range, replace_range_2):
4615 * insdel.c (make_gap_larger):
4616 * editfns.c (Finsert_char):
4617 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4618
28177add
PE
4619 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4620
e69dafad
PE
46212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4622
4baa020d 4623 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4624
b1c46f02
PE
4625 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4626 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4627
e69dafad
PE
4628 * fileio.c: Don't assume EMACS_INT fits in off_t.
4629 (emacs_lseek): New static function.
4630 (Finsert_file_contents, Fwrite_region): Use it.
4631 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4632
566684ea
PE
4633 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4634
e6966cd6
PE
4635 * fns.c: Don't overflow int when computing a list length.
4636 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4637 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4638 truncation on 64-bit hosts. Check for QUIT every
4639 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4640 faster and is responsive enough.
4641 (Flength): Report an error instead of overflowing an integer.
4642 (Fsafe_length): Return a float if the value is not representable
4643 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4644 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4645 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4646
dd0b0efb
PE
4647 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4648 (header_size, word_size): New constants.
4649 (allocate_vectorlike): Don't check size overflow here.
4650 (allocate_vector): Check it here instead, since this is the only
4651 caller of allocate_vectorlike that could cause overflow.
4652 Check that the new vector's length is representable as a fixnum.
4653
86fe5cfe
PE
4654 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4655 The previous code was bogus. For example, next_almost_prime (32)
4656 returned 39, which is undesirable as it is a multiple of 3; and
4657 next_almost_prime (24) returned 25, which is a multiple of 5 so
4658 why was the code bothering to check for multiples of 7?
4659
80e88859
PE
4660 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4661
4a2f0ad6
PE
4662 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4663
f66c7cf8
PE
4664 Variadic C functions now count arguments with ptrdiff_t.
4665 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4666 Back then I didn't know that the Emacs coding style prefers signed int.
4667 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4668 were being counted with int, which may truncate counts on 64-bit
4669 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4670 * lisp.h (struct Lisp_Subr.function.aMANY)
4671 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4672 Arg counts are now ptrdiff_t, not size_t.
4673 All variadic functions and their callers changed accordingly.
4674 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4675 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4676 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4677 * callint.c (Fcall_interactively): Check arg count for overflow,
4678 to avoid potential buffer overrun. Use signed char, not 'int',
4679 for 'varies' array, so that we needn't bother to check its size
4680 calculation for overflow.
4681 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4682 * eval.c (apply_lambda):
4683 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4684 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4685 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4686
a1759b76
PE
4687 * callint.c (Fcall_interactively): Don't use index var as event count.
4688
d96be9fc
PE
4689 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4690 * mem-limits.h (SIZE): Remove; no longer used.
4691
a690a978 4692 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4693
578c21e6
PE
4694 Remove unnecessary casts.
4695 * xterm.c (x_term_init):
4696 * xfns.c (x_set_border_pixel):
4697 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4698 These aren't needed now that we assume ANSI C.
4699
96f53c6c
PE
4700 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4701 It's more likely to cause problems (due to unsigned overflow)
4702 than to cure them.
4703
83c77d31
PE
4704 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4705
ee2079f1
PE
4706 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4707
6da65536
PE
4708 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4709
7147c4a4
PE
4710 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4711
193e32d9
PE
4712 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4713
e5533da6
PE
4714 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4715
9910e595
PE
4716 GLYPH_CODE_FACE returns EMACS_INT, not int.
4717 * dispextern.h (merge_faces):
4718 * xfaces.c (merge_faces):
01103c44
PE
4719 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4720 Don't assume EMACS_INT fits in int.
9910e595 4721
2638320e
PE
4722 * character.h (CHAR_VALID_P): Remove unused parameter.
4723 * fontset.c, lisp.h, xdisp.c: All uses changed.
4724
045eb8d9
PE
4725 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4726
c1f134b5
PE
4727 * fns.c (concat): Minor tuning based on overflow analysis.
4728 This doesn't fix any bugs. Use int to hold character, instead
4729 of constantly refetching from Emacs object. Use XFASTINT, not
4730 XINT, for value known to be a character. Don't bother comparing
4731 a single byte to 0400, as it's always less.
4732
395fcb93 4733 * floatfns.c (Fexpt):
327eeec8
PE
4734 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4735
abbd3d23
PE
4736 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4737 for characters.
4738
684a03ef
PE
4739 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4740
0fed43f3
PE
4741 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4742 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4743 incorrectly succeed when S was a string, because 4294967386 was
4744 truncated before it was used.
4745
8fd02eb7
PE
4746 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4747 Otherwise, an out-of-range integer could cause undefined behavior
4748 on a 64-bit host.
4749
f8c86b69
PE
4750 * composite.c: Use int, not EMACS_INT, for characters.
4751 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4752 EMACS_INT, for values that are known to be in character range.
4753 This doesn't fix any bugs but is the usual style inside Emacs and
4754 may generate better code on 32-bit machines.
4755
34206dd2
PE
4756 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4757 This is for reasons similar to the recent CHAR_STRING fix.
4758 * charset.c (Fencode_char): Check that character arg is actually
4759 a character. Pass an int to ENCODE_CHAR.
4760 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4761 wider than 'int', as a compile-time check to prevent future regressions
4762 in this area.
4763
c5958d4c 4764 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4765
4766 Make sure a 64-bit char is never passed to CHAR_STRING.
4767 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4768 by silently ignoring the top 32 bits, allowing some values
4769 that were far too large to be valid characters.
4770 * character.h: Include <verify.h>.
4771 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4772 arguments are no wider than unsigned, as a compile-time check
4773 to prevent future regressions in this area.
4774 * data.c (Faset):
01103c44 4775 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4776 (Fsubst_char_in_region):
4777 * fns.c (concat):
4778 * xdisp.c (decode_mode_spec_coding):
4779 Adjust to CHAR_STRING's new requirement.
4780 * editfns.c (Finsert_char, Fsubst_char_in_region):
4781 * fns.c (concat): Check that character args are actually
4782 characters. Without this test, these functions did the wrong
4783 thing with wildly out-of-range values on 64-bit hosts.
4784
d37ca623
PE
4785 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4786 These casts should not be needed on 32-bit hosts, either.
4787 * keyboard.c (read_char):
4788 * lread.c (Fload): Remove casts to unsigned.
4789
ea204efb
PE
4790 * lisp.h (UNSIGNED_CMP): New macro.
4791 This fixes comparison bugs on 64-bit hosts.
4792 (ASCII_CHAR_P): Use it.
4793 * casefiddle.c (casify_object):
01103c44 4794 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4795 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4796 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4797 * dispextern.h (FACE_FROM_ID):
4798 * keyboard.c (read_char): Use UNSIGNED_CMP.
4799
41cb286c
PE
4800 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4801 not to EMACS_INT, to avoid GCC warning.
4802
4a1b9832
PE
4803 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4804
55daad71
PE
4805 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4806 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4807 isn't needed on 32-bit machines.
8f95c75c 4808
01103c44
PE
4809 * buffer.c (Fgenerate_new_buffer_name):
4810 Use EMACS_INT for count, not int.
0ceccced 4811 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4812
4813 * data.c (Qcompiled_function): Now static.
4814
c6f072e7
PE
4815 * window.c (window_body_lines): Now static.
4816
20ce5912
PE
4817 * image.c (gif_load): Rename local to avoid shadowing.
4818
9c4c5f81
PE
4819 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4820 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4821 * alloc.c (make_save_value): Integer argument is now of type
4822 ptrdiff_t, not int.
4823 (mark_object): Use ptrdiff_t, not int.
4824 * lisp.h (pD): New macro.
4825 * print.c (print_object): Use it.
4826
c0c5c8ae
PE
4827 * alloc.c: Use EMACS_INT, not int, to count objects.
4828 (total_conses, total_markers, total_symbols, total_vector_size)
4829 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4830 (total_free_floats, total_floats, total_free_intervals)
4831 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4832 Now EMACS_INT, not int. All uses changed.
4833 (Fgarbage_collect): Compute overall total using a double, so that
4834 integer overflow is less likely to be a problem. Check for overflow
4835 when converting back to an integer.
5a25e253
PE
4836 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4837 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4838 These were 'int' variables that could overflow on 64-bit hosts;
4839 they were never used, so remove them instead of repairing them.
211a0b2a 4840 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4841 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4842 Previously, this ceilinged at INT_MAX, but that doesn't work on
4843 64-bit machines.
e46bb31a 4844 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4845
c78baabf 4846 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4847 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4848 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4849 when a (possibly-narrower) signed value would do just as well.
4850 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4851
c9d624c6
PE
4852 * alloc.c: Catch some string size overflows that we were missing.
4853 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4854 for convenience in STRING_BYTES_MAX.
4855 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4856 The definition here is exact; the one in lisp.h was approximate.
4857 (allocate_string_data): Check for string overflow. This catches
4858 some instances we weren't catching before. Also, it catches
4859 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4860 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4861 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4862
c9d624c6
PE
4863 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4864 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4865 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4866
353032ce
PE
4867 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4868
2bccce07
PE
4869 * alloc.c (Fmake_string): Check for out-of-range init.
4870
0ac30604
SM
48712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4872
4873 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4874
c195f2de
JD
48752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4876
4877 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4878 xg_get_default_scrollbar_width.
4879
4880 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4881 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4882 (style_changed_cb): Call update_theme_scrollbar_width and call
4883 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4884 all frames (Bug#8505).
4885 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4886 Call gtk_window_set_resizable if HAVE_GTK3.
4887 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4888 and height if HAVE_GTK3 (Bug#8505).
4889 (scroll_bar_width_for_theme): New variable.
4890 (update_theme_scrollbar_width): New function.
4891 (xg_get_default_scrollbar_width): Move code to
4892 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4893 (xg_initialize): Call update_theme_scrollbar_width.
4894
4895 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4896
4897 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4898
e10ac9f1
MR
48992011-06-12 Martin Rudalics <rudalics@gmx.at>
4900
4901 * frame.c (make_frame): Call other_buffer_safely instead of
4902 other_buffer.
4903
4904 * window.c (temp_output_buffer_show): Call display_buffer with
4905 second argument Vtemp_buffer_show_specifiers and reset latter
4906 immediately after the call.
4907 (Vtemp_buffer_show_specifiers): New variable.
4908 (auto_window_vscroll_p, next_screen_context_lines)
4909 (Vscroll_preserve_screen_position): Remove leading asterisks from
4910 doc-strings.
4911
2d3c217e 49122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4913
7b7f97e8 4914 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4915 * buffer.c (Qclone_number): Remove for now, as it's unused.
4916 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4917 (record_buffer): Remove unused local.
4918 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4919 (set_frame_buffer_list): Remove; unused.
4920 * frame.h (other_visible_frames): Remove decl.
4921 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4922 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4923 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4924 if HAVE_GPM.
4925 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4926 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4927 Define only if HAVE_GPM.
4928 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4929 (update_hints_inhibit): Remove; never set. All uses removed.
4930 * widgetprv.h (emacsFrameClassRec): Remove decl.
4931 * window.c (delete_deletable_window): Now returns void, since it
4932 wasn't returning anything.
4933 (compare_window_configurations): Remove unused locals.
4934 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4935 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4936 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4937 the same widths as pointers. This follows up on the 2011-05-06 patch.
4938 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4939 * xterm.h: Likewise.
4940 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4941
1384b89e
JB
49422011-06-12 Juanma Barranquero <lekktu@gmail.com>
4943
4944 * makefile.w32-in: Update dependencies.
4945 (LISP_H): Add lib/intprops.h.
4946
1100a63c
CY
49472011-06-11 Chong Yidong <cyd@stupidchicken.com>
4948
4949 * image.c (gif_load): Add animation frame delay to the metadata.
4950 (syms_of_image): Use DEFSYM. New symbol `delay'.
4951
6198ccd0
MR
49522011-06-11 Martin Rudalics <rudalics@gmx.at>
4953
4954 * window.c (delete_deletable_window): Re-add.
4955 (Fset_window_configuration): Rewrite to handle dead buffers and
4956 consequently deletable windows.
4957 (window_tree, Fwindow_tree): Remove. Supply functionality in
4958 window.el.
4959 (compare_window_configurations): Simplify code.
4960
b6e3633c
AS
49612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4962
1ab0dee5
AS
4963 * image.c (imagemagick_load_image): Fix type mismatch.
4964 (Fimagemagick_types): Likewise.
4965
b6e3633c
AS
4966 * window.h (replace_buffer_in_windows): Declare.
4967
9397e56f
MR
49682011-06-11 Martin Rudalics <rudalics@gmx.at>
4969
4970 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4971 Qclone_number. Remove external declaration of Qdelete_window.
4972 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4973 code.
640c8776
SM
4974 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4975 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4976 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4977 buffer list implementation.
4978 (other_buffer_safely): New function.
4979 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4980 calls to replace_buffer_in_windows and
4981 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4982 if allowed.
4983 (record_buffer): Inhibit quitting and rewrite using quittable
4984 functions. Run Qbuffer_list_update_hook if allowed.
4985 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4986 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4987 Move switch-to-buffer to window.el.
9397e56f
MR
4988 (bury-buffer): Move to window.el.
4989 (Vbuffer_list_update_hook): New variable.
4990
4991 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4992 section.
4993
4994 * window.h (resize_frame_windows): Move up in code.
4995 (Fwindow_frame): Remove EXFUN.
4996 (replace_buffer_in_all_windows): Remove prototype.
4997 (replace_buffer_in_windows_safely): Add prototype.
4998
4999 * window.c: Declare Qdelete_window static again. Move down
5000 declaration of select_count.
5001 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5002 (Fother_window): Move to window.el.
5003 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5004 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5005 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5006 window.el.
5007 (replace_buffer_in_windows): Implement by calling
5008 Qreplace_buffer_in_windows.
5009 (replace_buffer_in_all_windows): Remove with some functionality
5010 moved into replace_buffer_in_windows_safely.
5011 (replace_buffer_in_windows_safely): New function.
5012 (select_window_norecord, select_frame_norecord): Move in front
5013 of run_window_configuration_change_hook. Remove now obsolete
5014 declarations.
640c8776
SM
5015 (Fset_window_buffer): Rewrite doc-string.
5016 Call Qrecord_window_buffer.
9397e56f
MR
5017 (keys_of_window): Move binding for other-window to window.el.
5018
b50691aa
CY
50192011-06-11 Chong Yidong <cyd@stupidchicken.com>
5020
5021 * dispextern.h (struct image): Replace data member, whose int_val
5022 and ptr_val fields were not used by anything, with a single
5023 lisp_val object.
5024
5025 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5026 (gif_clear_image, gif_load, imagemagick_load_image)
5027 (gs_clear_image, gs_load): Callers changed.
5028
3f754b86
PE
50292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5030
cca69397
PE
5031 * buffer.h: Include <time.h>, for time_t.
5032 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5033
109e28d0
PE
5034 Fix minor problems found by static checking.
5035
60737f02
PE
5036 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5037
4b66faf3
PE
5038 Make identifiers static if they are not used in other modules.
5039 * data.c (Qcompiled_function, Qframe, Qvector):
5040 * image.c (QimageMagick, Qsvg):
5041 * minibuf.c (Qmetadata):
5042 * window.c (resize_window_check, resize_root_window): Now static.
5043 * window.h (resize_window_check, resize_root_window): Remove decls.
5044
109e28d0
PE
5045 * window.c (window_deletion_count, delete_deletable_window):
5046 Remove; unused.
46a4ce9e
PE
5047 (window_body_lines): Now static.
5048 (Fdelete_other_windows_internal): Mark vars as initialized.
5049 Make sure 'resize_failed' is initialized.
5050 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5051 (resize_window_apply): Remove unused local.
5052 * window.h (delete_deletable_window): Remove decl.
5053
109e28d0 5054 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5055 (imagemagick_load_image): Fix pointer signedness problem by changing
5056 last arg from unsigned char * to char *. All uses changed.
5057 Also, fix a local for similar reasons.
5058 Remove unused locals. Remove locals to avoid shadowing.
5059 (fn_rsvg_handle_free): Remove; unused.
5060 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5061 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5062
3f754b86
PE
5063 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5064
2547adb1
CY
50652011-06-10 Chong Yidong <cyd@stupidchicken.com>
5066
5067 * image.c (gif_load): Fix omitted cast error introduced by
5068 2011-06-06 change.
5069
2c8e37d4
MR
50702011-06-10 Martin Rudalics <rudalics@gmx.at>
5071
5072 * window.h (resize_proportionally, orig_total_lines)
5073 (orig_top_line): Remove from window structure.
5074 (set_window_height, set_window_width, change_window_heights)
5075 (Fdelete_window): Remove prototypes.
5076 (resize_frame_windows): Remove duplicate declaration.
5077
440a42e3
EZ
50782011-06-10 Eli Zaretskii <eliz@gnu.org>
5079
5080 * window.h (resize_frame_windows, resize_window_check)
5081 (delete_deletable_window, resize_root_window)
5082 (resize_frame_windows): Declare prototypes.
5083
5084 * window.c (resize_window_apply): Make definition be "static" to
5085 match the prototype.
5086
562dd5e9
MR
50872011-06-10 Martin Rudalics <rudalics@gmx.at>
5088
5089 * window.c: Remove declarations of Qwindow_size_fixed,
5090 window_min_size_1, window_min_size_2, window_min_size,
5091 size_window, window_fixed_size_p, enlarge_window, delete_window.
5092 Remove static from declaration of Qdelete_window, it's
5093 temporarily needed by Fbury_buffer.
5094 (replace_window): Don't assign orig_top_line and
5095 orig_total_lines.
5096 (Fdelete_window, delete_window): Remove. Window deletion is
5097 handled by window.el.
640c8776
SM
5098 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5099 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5100 (Fdelete_other_windows): Remove. Deleting other windows is
5101 handled by window.el.
5102 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5103 handled in window.el.
5104 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5105 Window minimum sizes are handled in window.el.
5106 (shrink_windows, size_window, set_window_height)
5107 (set_window_width, change_window_heights, window_height)
5108 (window_width, CURBEG, CURSIZE, enlarge_window)
5109 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5110 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5111 handled in window.el.
5112 (make_dummy_parent): Rename to make_parent_window and give it a
5113 second argument horflag.
5114 (make_window): Don't set resize_proportionally any more.
5115 (Fsplit_window): Remove. Windows are split in window.el.
5116 (save_restore_action, save_restore_orig_size)
5117 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5118 Resize mini windows in window.el.
5119 (grow_mini_window, shrink_mini_window): Implement by calling
5120 Qresize_root_window_vertically, resize_window_check and
5121 resize_window_apply.
640c8776
SM
5122 (saved_window, Fset_window_configuration, save_window_save):
5123 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5124 resize_proportionally.
5125 (window_min_height, window_min_width): Move to window.el.
5126 (keys_of_window): Move bindings for delete-other-windows,
5127 split-window, delete-window and enlarge-window to window.el.
5128
5129 * buffer.c: Temporarily extern Qdelete_window.
5130 (Fbury_buffer): Temporarily call Qdelete_window instead of
5131 Fdelete_window (Fbury_buffer will move to window.el soon).
5132
5133 * frame.c (set_menu_bar_lines_1): Remove code handling
5134 orig_top_line and orig_total_lines.
5135
5136 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5137 set_window_height but set heights directly.
5138 (change_frame_size_1): Use resize_frame_windows.
5139
5140 * xdisp.c (init_xdisp): Don't use set_window_height but set
5141 heights directly.
5142
640c8776
SM
5143 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5144 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5145 run_window_configuration_change_hook.
5146
5147 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5148 instead of change_window_heights and run
5149 run_window_configuration_change_hook.
5150
1a13852e
MR
51512011-06-09 Martin Rudalics <rudalics@gmx.at>
5152
5153 * window.c (replace_window): Rename second argument REPLACEMENT to
5154 NEW. New third argument SETFLAG. Rewrite.
5155 (delete_window, make_dummy_parent): Call replace_window with
5156 third argument 1.
5157 (window_list_1): Move down in code.
5158 (run_window_configuration_change_hook): Move set_buffer part
5159 before select_frame_norecord part in order to unwind correctly.
5160 Rename count1 to count.
5161 (recombine_windows, delete_deletable_window, resize_root_window)
5162 (Fdelete_other_windows_internal)
5163 (Frun_window_configuration_change_hook, make_parent_window)
5164 (resize_window_check, resize_window_apply, Fresize_window_apply)
5165 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5166 (Fdelete_window_internal, Fresize_mini_window_internal):
5167 New functions.
1a13852e
MR
5168 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5169
f3d1777e
MR
51702011-06-08 Martin Rudalics <rudalics@gmx.at>
5171
496e208e
MR
5172 * window.h (window): Add some new members to window structure -
5173 normal_lines, normal_cols, new_total, new_normal, clone_number,
5174 splits, nest, prev_buffers, next_buffers.
5175 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5176 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5177
f3d1777e
MR
5178 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5179 Remove.
496e208e
MR
5180 (make_dummy_parent): Set new members of windows structure.
5181 (make_window): Move down in code. Handle new members of window
5182 structure.
5183 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5184 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5185 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5186 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5187 (Fset_window_next_buffers, Fset_window_clone_number):
5188 New functions.
496e208e
MR
5189 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5190 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5191 Doc-string fixes.
5192 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5193 Argument WINDOW can be now internal window too.
5194 (Fwindow_use_time): Move up in code.
5195 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5196 Rewrite doc-string.
5197 (Fset_window_configuration, saved_window)
5198 (Fcurrent_window_configuration, save_window_save): Handle new
5199 members of window structure.
b9e809c2
MR
5200 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5201 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5202 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5203 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5204 Qget_mru_window, Qresize_root_window,
5205 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5206 Qauto_buffer_name; staticpro them.
f3d1777e 5207
abde8f8c
MR
52082011-06-07 Martin Rudalics <rudalics@gmx.at>
5209
5210 * window.c (Fwindow_total_size, Fwindow_left_column)
5211 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5212 (Fwindow_list_1): New functions.
5213 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5214 (Fwindow_width, Fscroll_left, Fscroll_right):
5215 Use window_body_cols instead of window_box_text_cols.
5216 (delete_window, Fset_window_configuration):
5217 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5218 (delete_all_subwindows): Take a window as argument and not a
5219 structure. Rewrite.
190b47e6
MR
5220 (window_loop): Remove handling of GET_LRU_WINDOW and
5221 GET_LARGEST_WINDOW.
5222 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5223
5224 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5225 window_box_text_cols. delete_all_subwindows now takes a
5226 Lisp_Object as argument.
abde8f8c 5227
640c8776
SM
5228 * indent.c (compute_motion, Fcompute_motion):
5229 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5230
fa8a67e6
MR
5231 * frame.c (delete_frame): Call delete_all_subwindows with root
5232 window as argument.
5233
a54e3482
DC
52342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5235
5236 * fns.c (Fputhash): Document return value.
5237
60002bf5
CY
52382011-06-06 Chong Yidong <cyd@stupidchicken.com>
5239
5240 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5241
0c671da6 52422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5243
b862a52a 5244 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5245
be44ca6c
PE
5246 Check for overflow when converting integer to cons and back.
5247 * charset.c (Fdefine_charset_internal, Fdecode_char):
5248 Use cons_to_unsigned to catch overflow.
5249 (Fencode_char): Use INTEGER_TO_CONS.
5250 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5251 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5252 * data.c (long_to_cons, cons_to_long): Remove.
5253 (cons_to_unsigned, cons_to_signed): New functions.
5254 These signal an error for invalid or out-of-range values.
5255 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5256 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5257 * font.c (Ffont_variation_glyphs):
5258 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5259 * lisp.h: Include <intprops.h>.
5260 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5261 (cons_to_signed, cons_to_unsigned): New decls.
5262 (long_to_cons, cons_to_long): Remove decls.
5263 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5264 (Fprimitive_undo): Use CONS_TO_INTEGER.
5265 * xfns.c (Fx_window_property): Likewise.
5266 * xselect.c: Include <limits.h>.
5267 (x_own_selection, selection_data_to_lisp_data):
5268 Use INTEGER_TO_CONS.
5269 (x_handle_selection_request, x_handle_selection_clear)
5270 (x_get_foreign_selection, Fx_disown_selection_internal)
5271 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5272 (lisp_data_to_selection_data): Use cons_to_unsigned.
5273 (x_fill_property_data): Use cons_to_signed.
5274 Report values out of range.
5275
d1f3d2af
PE
5276 Check for buffer and string overflow more precisely.
5277 * buffer.h (BUF_BYTES_MAX): New macro.
5278 * lisp.h (STRING_BYTES_MAX): New macro.
5279 * alloc.c (Fmake_string):
5280 * character.c (string_escape_byte8):
5281 * coding.c (coding_alloc_by_realloc):
5282 * doprnt.c (doprnt):
5283 * editfns.c (Fformat):
5284 * eval.c (verror):
5285 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5286 since they may not be the same number.
5287 * editfns.c (Finsert_char):
5288 * fileio.c (Finsert_file_contents):
5289 Likewise for BUF_BYTES_MAX.
5290
dd52fcea
PE
5291 * image.c: Use ptrdiff_t, not int, for sizes.
5292 (slurp_file): Switch from int to ptrdiff_t.
5293 All uses changed.
5294 (slurp_file): Check that file size fits in both size_t (for
5295 malloc) and ptrdiff_t (for sanity and safety).
5296
7f9bbdbb
PE
5297 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5298 if b->modtime has its maximal value.
5299
dfe18f82
PE
5300 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5301
84acfcf0
PE
5302 Don't assume time_t can fit into int.
5303 * buffer.h (struct buffer.modtime): Now time_t, not int.
5304 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5305 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5306
ccd9a01a
PE
5307 Minor fixes for signed vs unsigned integers.
5308 * character.h (MAYBE_UNIFY_CHAR):
5309 * charset.c (maybe_unify_char):
5310 * keyboard.c (read_char, reorder_modifiers):
5311 XINT -> XFASTINT, since the integer must be nonnegative.
5312 * ftfont.c (ftfont_spec_pattern):
5313 * keymap.c (access_keymap, silly_event_symbol_error):
5314 XUINT -> XFASTINT, since the integer must be nonnegative.
5315 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5316 since it makes no difference and we prefer signed.
5317 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5318 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5319 nonnegative.
5320
d6d100dd
SM
53212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5322
5323 * window.h (Fwindow_frame): Declare.
5324
2b6148e4
PE
53252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5326
5327 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5328 (SPARE_MEMORY): Always define.
5329 (LARGE_REQUEST): Remove.
5330 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5331
f230ecc9
MR
53322011-06-06 Martin Rudalics <rudalics@gmx.at>
5333
727e958e
MR
5334 * lisp.h: Move EXFUNS for Fframe_root_window,
5335 Fframe_first_window and Fset_frame_selected_window to window.h.
5336
5337 * window.h: Move EXFUNS for Fframe_root_window,
5338 Fframe_first_window and Fset_frame_selected_window here from
5339 lisp.h.
5340
5341 * frame.c (Fwindow_frame, Fframe_first_window)
5342 (Fframe_root_window, Fframe_selected_window)
5343 (Fset_frame_selected_window): Move to window.c.
5344 (Factive_minibuffer_window): Move to minibuf.c.
5345 (Fother_visible_frames_p): New function.
5346
5347 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5348
f230ecc9
MR
5349 * window.c (decode_window, decode_any_window): Move up in code.
5350 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5351 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5352 (Fwindow_buffer): Move up and rewrite doc-string.
5353 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5354 (Fwindow_prev): New functions.
727e958e
MR
5355 (Fwindow_frame): Move here from frame.c. Accept any window as
5356 argument.
5357 (Fframe_root_window, Fframe_first_window)
5358 (Fframe_selected_window): Move here from frame.c. Accept frame
5359 or arbitrary window as argument. Update doc-strings.
5360 (Fminibuffer_window): Move up in code.
5361 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5362 (Fset_frame_selected_window): Move here from frame.c.
5363 Marginal rewrite.
727e958e
MR
5364 (Fselected_window, select_window, Fselect_window): Move up in
5365 code. Minor doc-string fixes.
f230ecc9 5366
4d09bcf6
PE
53672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5368
5369 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5370 Do not assume that spare memory exists; that assumption is valid
5371 only if SYSTEM_MALLOC.
5372 (LARGE_REQUEST): New macro, so that the issue of large requests
5373 is separated from the issue of spare memory.
5374
810928a2
AS
53752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5376
172418ad
AS
5377 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5378 format. (Bug#8806)
5379
43f862f7
AS
5380 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5381
810928a2
AS
5382 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5383 before statements.
5384
a059fe24
JD
53852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5386
5387 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5388
5389 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5390
5391 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5392 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5393
989bf368
JB
53942011-06-05 Juanma Barranquero <lekktu@gmail.com>
5395
5396 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5397
4b80f674
CY
53982011-06-04 Chong Yidong <cyd@stupidchicken.com>
5399
5400 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5401 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5402 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5403 New error handlers.
4b80f674
CY
5404 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5405 Obey Vx_select_enable_clipboard_manager. Catch errors in
5406 x_clipboard_manager_save (Bug#8779).
5407 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5408 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5409
99a33b77 54102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5411
5412 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5413
99a33b77 54142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5415
5416 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5417 in the current matrix if keep_current_p is non-zero.
5418
8264569d
EZ
54192011-06-04 Eli Zaretskii <eliz@gnu.org>
5420
5421 * bidi.c (bidi_level_of_next_char): Fix last change.
5422
57f97249
EZ
54232011-06-03 Eli Zaretskii <eliz@gnu.org>
5424
fec2107c 5425 Support bidi reordering of text covered by display properties.
57f97249 5426
fec2107c
EZ
5427 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5428 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5429 (bidi_cache_search, bidi_cache_iterator_state)
5430 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5431 (bidi_level_of_next_char, bidi_move_to_visually_next):
5432 Support character positions inside a run of characters covered by a
fec2107c
EZ
5433 display string.
5434 (bidi_paragraph_init, bidi_resolve_explicit_1)
5435 (bidi_level_of_next_char): Call bidi_fetch_char and
5436 bidi_fetch_char_advance instead of FETCH_CHAR and
5437 FETCH_CHAR_ADVANCE.
5438 (bidi_init_it): Initialize new members.
5439 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5440 definitions.
5441 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5442 instead of using explicit *_CHAR codes.
d6d100dd
SM
5443 (bidi_resolve_explicit, bidi_resolve_weak):
5444 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5445 bidirectional text is supported only in multibyte buffers.
5446 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5447 it to initialize the frame_window_p member of struct bidi_it.
5448 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5449 (bidi_resolve_explicit, bidi_resolve_weak)
5450 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5451 bidi_it->nchars is non-positive.
5452 (bidi_level_of_next_char): Don't try to lookup the cache for the
5453 next/previous character if nothing is cached there yet, or if we
5454 were just reseat()'ed to a new position.
c40e2fb2 5455
0e14fe90
EZ
5456 * xdisp.c (set_cursor_from_row): Set start and stop points
5457 according to the row's direction when priming the loop that looks
5458 for the glyph on which to display cursor.
5459 (single_display_spec_intangible_p): Function deleted.
5460 (display_prop_intangible_p): Reimplement to call
5461 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5462 Accept 3 additional arguments needed by handle_display_spec.
5463 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5464 values: lists, `(when COND...)' forms, etc.
5465 (single_display_spec_string_p): Support property values that are
5466 lists with the argument STRING its top-level element.
5467 (display_prop_string_p): Fix the condition for processing a
5468 property that is a list to be consistent with handle_display_spec.
fec2107c 5469 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5470 last portion of handle_display_prop.
5471 (compute_display_string_pos): Accept additional argument
5472 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5473 value of a `display' property is a "replacing spec".
5474 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5475 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5476 the display property, but just return a value indicating whether
5477 the display property will replace the characters it covers.
5478 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5479 frame_window_p members of struct bidi_it.
d6d100dd
SM
5480 (compute_display_string_pos, compute_display_string_end):
5481 New functions.
fec2107c
EZ
5482 (push_it): Accept second argument POSITION, where pop_it should
5483 jump to continue iteration.
5484 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5485
fec2107c
EZ
5486 * keyboard.c (adjust_point_for_property): Adjust the call to
5487 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5488
5489 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5490 (bidi_init_it): Update prototypes.
5491 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5492 (compute_display_string_pos, compute_display_string_end):
5493 Declare prototypes.
fec2107c
EZ
5494 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5495 EMACS_INT.
fc6f18ce 5496
40087514 54972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5498
57f53182
PE
5499 Malloc failure behavior now depends on size of allocation.
5500 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5501 * lisp.h: Change signatures accordingly.
5502 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5503 All callers changed. (Bug#8762)
5504
5505 * gnutls.c: Use Emacs's memory allocators.
5506 Without this change, the gnutls library would invoke malloc etc.
5507 directly, which causes problems on non-SYNC_INPUT hosts, and which
5508 runs afoul of improving memory_full behavior. (Bug#8761)
5509 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5510 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5511 xfree instead of the default malloc, realloc, free.
5512 (Fgnutls_boot): No need to check for memory allocation failure,
5513 since xmalloc does that for us.
5514
ac32cd99 5515 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5516 * category.c (hash_get_category_set):
5517 * ccl.c (ccl_driver):
5518 * charset.c (Fdefine_charset_internal):
5519 * charset.h (struct charset.hash_index):
5520 * composite.c (get_composition_id, gstring_lookup_cache)
5521 (composition_gstring_put_cache):
5522 * composite.h (struct composition.hash_index):
5523 * dispextern.h (struct image.hash):
5524 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5525 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5526 (hashfn_equal, hashfn_user_defined, make_hash_table)
5527 (maybe_resize_hash_table, hash_lookup, hash_put)
5528 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5529 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5530 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5531 * image.c (make_image, search_image_cache, lookup_image)
5532 (xpm_put_color_table_h):
5533 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5534 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5535 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5536 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5537 * alloc.c (allocate_vectorlike):
5538 Check for overflow in vector size calculations.
5539 * ccl.c (ccl_driver):
5540 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5541 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5542 need to be updated by these changes.
40087514
PE
5543 * fns.c (make_hash_table, maybe_resize_hash_table):
5544 Check for integer overflow with large hash tables.
0de4bb68
PE
5545 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5546 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5547 (SXHASH_REDUCE): New macro.
5548 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5549 Use it instead of discarding useful hash info with large hash values.
5550 (sxhash_float): New function.
5551 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5552 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5553 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5554 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5555 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5556 Adjust signatures to match updated version of code.
5557 (consing_since_gc): Now EMACS_INT, since a single hash table can
5558 use more than INT_MAX bytes.
5559
698d32e2
DN
55602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5561
5562 Make it possible to build with GCC-4.6+ -O2 -flto.
5563
5564 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5565
fd6fa53f
SM
55662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5567
5568 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5569 Call minibuffer-inactive-mode.
5570
864db017
JB
55712011-05-31 Juanma Barranquero <lekktu@gmail.com>
5572
5573 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5574 Update dependencies.
5575
2ad0baf4
DN
55762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5577
5578 * data.c (init_data): Remove code for UTS, this system is not
5579 supported anymore.
5580
4fcc2638
DN
55812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5582
5583 Don't force ./temacs to start in terminal mode.
5584
5585 * frame.c (make_initial_frame): Initialize faces in all cases, not
5586 only when CANNOT_DUMP is defined.
5587 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5588
c56e0fd5
DN
55892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5590
5591 * dispnew.c (add_window_display_history): Use const for the string
5592 pointer. Remove declaration, not needed.
5593
333d54da 55942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5595
55d4c1b2 5596 Use 'inline', not 'INLINE'.
333d54da 5597 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5598 * alloc.c, fontset.c (INLINE): Remove.
5599 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5600 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5601 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5602 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5603 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5604
738db178
DN
56052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5606
5607 Make it possible to run ./temacs.
5608
5609 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5610 syms_of_callproc does the same thing. Remove test for
5611 "initialized", do it in the caller.
5612 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5613
620c53a6
SM
56142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5615
5616 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5617 (read_minibuf): Use get_minibuffer.
5618 (syms_of_minibuf): Use DEFSYM.
5619 (Qmetadata): New var.
5620 * data.c (Qbuffer): Don't make it static.
5621 (syms_of_data): Use DEFSYM.
5622
e003a292
PE
56232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5626 (CCL_CODE_MIN): New macro.
5627
ed008a6d
PE
56282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5629
3687c2ef
PE
5630 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5631
ed008a6d
PE
5632 * eval.c (Qdebug): Now static.
5633 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5634 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5635 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5636
d66c4c7c
CY
56372011-05-29 Chong Yidong <cyd@stupidchicken.com>
5638
5639 * image.c: Various fixes to ImageMagick code comments.
5640 (Fimagemagick_types): Doc fix.
5641
5fbc2025
PE
56422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5643
0196f88a
PE
5644 Minor fixes prompted by GCC 4.6.0 warnings.
5645
5646 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5647
5fbc2025
PE
5648 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5649 (x_clipboard_manager_save_all): Move extern decl to ...
5650 * xterm.h: ... here, so that it can be checked for consistency.
5651
1dd3c2d9
CY
56522011-05-29 Chong Yidong <cyd@stupidchicken.com>
5653
5654 * xselect.c (x_clipboard_manager_save_frame)
5655 (x_clipboard_manager_save_all): New functions.
5656 (Fx_clipboard_manager_save): Lisp function deleted.
5657
5658 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5659 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5660
5661 * xterm.h: Update prototype.
5662
5ba6571d
WX
56632011-05-28 William Xu <william.xwl@gmail.com>
5664
5665 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5666 exiting (Bug#8239).
5667
3eaff834
JM
56682011-05-28 Jim Meyering <meyering@redhat.com>
5669
e1900994 5670 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5671 * fns.c (to_uchar): Define.
5672 (crypto_hash_function): Use it to convert some newly-signed
5673 variables to unsigned, to avoid sign-extension bugs. For example,
5674 without this change, (md5 "truc") would evaluate to
5675 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5676 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5677 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5678
0f6990a7
PE
56792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 Integer overflow fixes.
c8a9ca5a 5682
08686060
PE
5683 * dbusbind.c: Serial number integer overflow fixes.
5684 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5685 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5686 to hold a serial number that is too large for a fixnum.
5687 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5688 Check for serial numbers out of range. Decode any serial number
59568bf0 5689 that was so large that it became a float. (Bug#8722)
08686060 5690
2d1fc3c7
PE
5691 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5692 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5693 Use XFASTINT rather than XUINT when numbers are nonnegative.
5694 (xd_append_arg, Fdbus_method_return_internal):
5695 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5696 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5697 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5698 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5699 (Bug#8722)
2d1fc3c7 5700
c8a9ca5a
PE
5701 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5702
519e1d69
PE
5703 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5704
6df6ae42 5705 ccl: Add integer overflow checks.
30569699
PE
5706 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5707 (IN_INT_RANGE): New macros.
5708 (ccl_driver): Use them to check for integer overflow when
5709 decoding a CCL program. Many of the new checks are whether XINT (x)
5710 fits in int; it doesn't always, on 64-bit hosts. The new version
5711 doesn't catch all possible integer overflows, but it's an
847044ea 5712 improvement. (Bug#8719)
30569699 5713
c11285dc
PE
5714 * alloc.c (make_event_array): Use XINT, not XUINT.
5715 There's no need for unsigned here.
5716
fdccd48e
PE
5717 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5718 This follows up to the 2011-05-06 change that substituted uintptr_t
5719 for EMACS_INT. This case wasn't caught back then.
5720
37910ab2
PE
5721 Rework Fformat to avoid integer overflow issues.
5722 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5723 now (part of C89). Include <verify.h>.
5724 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5725 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5726 (Fformat): Avoid the prepass trying to compute sizes; it was only
5727 approximate and thus did not catch overflow reliably. Instead, walk
5728 through the format just once, formatting and computing sizes as we go,
5729 checking for integer overflow at every step, and allocating a larger
5730 buffer as needed. Keep track separately whether the format is
5731 multibyte. Keep only the most-recently calculated precision, rather
5732 than them all. Record whether each argument has been converted to
5733 string. Use EMACS_INT, not int, for byte and char and arg counts.
5734 Support field widths and precisions larger than INT_MAX. Avoid
5735 sprintf's undefined behavior with conversion specifications such as %#d
5736 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5737 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5738 formatting out-of-range floating point numbers with int
9173deec 5739 formats. (Bug#8668)
37910ab2 5740
2e6578fb
PE
5741 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5742
0ae6bdee
PE
5743 * data.c: Avoid integer truncation in expressions involving floats.
5744 * data.c: Include <intprops.h>.
5745 (arith_driver): When there's an integer overflow in an expression
5746 involving floating point, convert the integers to floating point
5747 so that the resulting value does not suffer from catastrophic
5748 integer truncation. For example, on a 64-bit host (* 4
5749 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5750 Do not rely on undefined behavior after integer overflow.
5751
de883a70
PE
5752 merge count_size_as_multibyte, parse_str_to_multibyte
5753 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5754 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5755 Check for integer overflow.
5756 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5757 since it's now a duplicate of the other. This is more of
5758 a character than a buffer op, so better that it's in character.c.
5759 * fns.c, print.c: Adjust to above changes.
5760
2ff916cb
PE
57612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5762
5763 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5764
f1b54466
PE
57652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5766
fb1ac845
PE
5767 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5768 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5769 (x_clipboard_manager_save): Now static.
5770 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5771
f1b54466
PE
5772 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5773 (crypto_hash_function): Now static.
5774 Fix pointer signedness problems. Avoid unnecessary initializations.
5775
a9f737ee
CY
57762011-05-27 Chong Yidong <cyd@stupidchicken.com>
5777
5778 * termhooks.h (Vselection_alist): Make it terminal-local.
5779
5780 * terminal.c (create_terminal): Initialize it.
5781
5782 * xselect.c: Support for clipboard managers.
5783 (Vselection_alist): Move to termhooks.h as terminal-local var.
5784 (LOCAL_SELECTION): New macro.
5785 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5786 (symbol_to_x_atom): Remove gratuitous arg.
5787 (x_handle_selection_request, lisp_data_to_selection_data)
5788 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5789 (x_own_selection, x_get_local_selection, x_convert_selection):
5790 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5791 (some_frame_on_display): Delete unused function.
5792 (Fx_own_selection_internal, Fx_get_selection_internal)
5793 (Fx_disown_selection_internal, Fx_selection_owner_p)
5794 (Fx_selection_exists_p): New optional frame arg.
5795 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5796 (x_handle_selection_clear): Don't treat other terminals with the
5797 same keyboard specially. Use the terminal-local Vselection_alist.
5798 (x_clear_frame_selections): Use Frun_hook_with_args.
5799
5800 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5801
5802 * xterm.h: Add support for those atoms.
5803
e067f0c1
CY
58042011-05-26 Chong Yidong <cyd@stupidchicken.com>
5805
5806 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5807 (converted_selections, conversion_fail_tag): New global variables.
5808 (x_selection_request_lisp_error): Free the above.
5809 (x_get_local_selection): Remove unnecessary code.
5810 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5811 of converted selections stored in converted_selections.
5812 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5813 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5814 (x_convert_selection): New function.
5815 (x_handle_selection_event): Simplify.
5816 (x_get_foreign_selection): Don't ignore incoming requests while
5817 waiting for an answer; this will fail when we implement
5818 SAVE_TARGETS, and seems unnecessary anyway.
5819 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5820 (Vx_sent_selection_functions): Doc fix.
5821
0f4aebc0
LL
58222011-05-26 Leo Liu <sdl.web@gmail.com>
5823
5824 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5825
e61124cd
YM
58262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5827
5828 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5829
5830 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5831 for fringe update if it has periodic bitmap.
ac389d0c 5832 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5833 and fringe_bitmap_periodic_p.
5834
5835 * fringe.c (get_fringe_bitmap_data): New function.
5836 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5837 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5838 row. Mark glyph row for fringe update if periodicity changed.
5839
5840 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5841 for fringe update unless it has periodic bitmap.
5842
f16d9837
KH
58432011-05-25 Kenichi Handa <handa@m17n.org>
5844
5845 * xdisp.c (get_next_display_element): Set correct it->face_id for
5846 a static composition.
5847
e1b90ef6
LL
58482011-05-24 Leo Liu <sdl.web@gmail.com>
5849
5850 * deps.mk (fns.o):
5851 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5852
5853 * fns.c (crypto_hash_function, Fsha1): New function.
5854 (Fmd5): Use crypto_hash_function.
5855 (syms_of_fns): Add Ssha1.
5856
7400048f
PE
58572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5858
5859 * gnutls.c: Remove unused macros.
5860 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5861 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5862 Remove macros that are defined and never used.
5863 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5864
abb71cf4
CY
58652011-05-22 Chong Yidong <cyd@stupidchicken.com>
5866
5867 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5868 (Fx_get_selection_internal): Minor cleanup.
5869 (Fx_own_selection_internal): Rename arguments for consistency with
5870 select.el.
5871
6307db39
PE
58722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5875
f3d4e0a4
CY
58762011-05-22 Chong Yidong <cyd@stupidchicken.com>
5877
5878 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5879
4d8ade89
YM
58802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5881
5882 * dispnew.c (scrolling_window): Don't exclude the case that the
5883 last enabled row in the desired matrix touches the bottom boundary.
5884
32078c8d
GM
58852011-05-21 Glenn Morris <rgm@gnu.org>
5886
5887 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5888 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5889 and add some more files.
32078c8d 5890
7285dc67
EZ
58912011-05-20 Eli Zaretskii <eliz@gnu.org>
5892
5893 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5894 report_file_error introduced by the change from 2011-05-07.
5895
89d1bd22
PE
58962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5897
5898 * systime.h (Time): Define only if emacs is defined.
5899 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5900 where the include path doesn't have X11/X.h by default. See
5901 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5902
cd394be1 59032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5904
5905 * composite.c (find_automatic_composition): Fix previous change.
5906
b9704ad9
GM
59072011-05-20 Glenn Morris <rgm@gnu.org>
5908
5909 * lisp.mk: New file, split from Makefile.in.
5910 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5911 (shortlisp): Remove.
5912 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5913
4a720484
GM
59142011-05-19 Glenn Morris <rgm@gnu.org>
5915
5916 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5917 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5918 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5919 (lisp): Set the order to that of loadup.el.
5920 (shortlisp): Make it a copy of $lisp.
5921 (SOME_MACHINE_LISP): Remove.
5922 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5923 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5924
a28d4396
KH
59252011-05-18 Kenichi Handa <handa@m17n.org>
5926
5927 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5928 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5929 (find_automatic_composition): Mostly rewrite for efficiency.
5930
a2b1fa8e
JB
59312011-05-18 Juanma Barranquero <lekktu@gmail.com>
5932
5933 * makefile.w32-in: Update dependencies.
5934
8e1f5610
CS
59352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5936
5937 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5938 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5939
7025ee00 59402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5941
cdfa6eab
PE
5942 Fix some integer overflow issues, such as string length overflow.
5943
06d6db33
PE
5944 * insdel.c (count_size_as_multibyte): Check for string overflow.
5945
2b4560a8
PE
5946 * character.c (lisp_string_width): Check for string overflow.
5947 Use EMACS_INT, not int, for string indexes and lengths; in
5948 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5949 the resulting string length overflows an EMACS_INT; instead,
5950 report a string overflow if no precision given. When checking for
5951 precision exhaustion, use a check that cannot possibly have
5952 integer overflow. (Bug#8675)
5953 * character.h (lisp_string_width): Adjust to new signature.
5954
cb93f9be
PE
5955 * alloc.c (string_overflow): New function.
5956 (Fmake_string): Use it. This doesn't change behavior, but saves
5957 a few bytes and will simplify future changes.
5958 * character.c (string_escape_byte8): Likewise.
5959 * lisp.h (string_overflow): New decl.
5960
1a1f3366
PE
5961 Fixups, following up to the user-interface timestamp change.
5962 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5963 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5964 * msdos.c (mouse_get_pos): Likewise.
5965 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5966 * w32gui.h (Time): Define by including "systime.h" rather than by
5967 declaring it ourselves. (Bug#8664)
5968
d4e3e4d3
PE
5969 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5970 * image.c (clear_image_cache): Likewise.
5971
f6a24d19
PE
5972 * term.c (term_mouse_position): Don't assume time_t wraparound.
5973
08dc5ae6
PE
5974 Be more systematic about user-interface timestamps.
5975 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5976 and sometimes 'EMACS_UINT', to represent these timestamps.
5977 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5978 This makes the code easier to follow, and makes it easier to catch
5979 integer overflow bugs such as Bug#8664.
5980 * frame.c (Fmouse_position, Fmouse_pixel_position):
5981 Use Time, not unsigned long, for user-interface timestamps.
5982 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5983 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5984 * keyboard.h (last_event_timestamp): Likewise.
5985 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5986 * menu.h (xmenu_show): Likewise.
5987 * term.c (term_mouse_position): Likewise.
5988 * termhooks.h (struct input_event.timestamp): Likewise.
5989 (struct terminal.mouse_position_hook): Likewise.
5990 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5991 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5992 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5993 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5994 what it was before.
5995 * menu.h, termhooks.h: Include "systime.h", for Time.
5996
8e55734a
PE
5997 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5998 Don't assume that the difference between two unsigned long values
5999 can fit into an integer. At this point, we know button_down_time
6000 <= event->timestamp, so the difference must be nonnegative, so
6001 there's no need to cast the result if double-click-time is
6002 nonnegative, as it should be; check that it's nonnegative, just in
6003 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6004 apart (about 25 days). (Bug#8664)
8e55734a 6005
841f1b75 6006 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6007 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6008
3e26f69c
PE
6009 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6010 that always fit in int. Use a sentinel instead of a counter, to
6011 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6012 * frame.h (struct frame): Use int for menu_bar_items_used
6013 instead of EMACS_INT, since it always fits in int.
3e26f69c 6014
5cc152c0
PE
6015 * menu.c (grow_menu_items): Check for int overflow.
6016
d89eb65e
PE
6017 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6018
5235bd3e
PE
6019 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6020 Before, the code was not consistent. These values cannot exceed
6021 2**31 - 1 so there's no need to make them unsigned.
6022 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6023 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6024 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6025 as modifiers.
6026 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6027
bc827e23
PE
6028 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6029 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6030 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6031 presumably because the widths might not match.
6032
78eb494e
PE
6033 * window.c (size_window): Avoid needless test at loop start.
6034
04f2d78b
CB
60352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6036
6037 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6038
d2fc7e3d 60392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6040
6041 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6042
d2fc7e3d 60432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6044
6045 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6046 `width' to `bar_area_x' and `bar_area_width', respectively.
6047 (x_scroll_run): Take account of fringe background extension.
6048
04f2d78b
CB
6049 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6050 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6051 `bar_area_width', respectively.
6052 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6053 background extension.
6054
79b70037
GM
60552011-05-10 Jim Meyering <meyering@redhat.com>
6056
6057 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6058
2f142cc5
JB
60592011-05-10 Juanma Barranquero <lekktu@gmail.com>
6060
6061 * image.c (Finit_image_library): Return t for built-in image types,
6062 like pbm and xbm. (Bug#8640)
6063
57679c86
AS
60642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6065
6066 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6067
888c9e86
EZ
60682011-05-07 Eli Zaretskii <eliz@gnu.org>
6069
b0512a1d
EZ
6070 * w32console.c (Fset_screen_color): Doc fix.
6071 (Fget_screen_color): New function.
6072 (syms_of_ntterm): Defsubr it.
6073
7285dc67
EZ
6074 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6075 unlink the temporary file if Fcall_process didn't create it in the
6076 first place.
6077 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6078 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6079 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6080 cue to call_process_cleanup not to close that handle.
6081
4d3fcc8e
BK
60822011-05-07 Ben Key <bkey76@gmail.com>
6083
6084 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6085 one of two shell specific rules, either bootstrap-temacs-CMD or
6086 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6087 to the previous implementation of the bootstrap-temacs rule.
6088 The bootstrap-temacs-CMD rule is similar to the previous
6089 implementation of the bootstrap-temacs rule except that it
6090 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6091 variable.
6092
6093 These changes, along with some changes to nt/configure.bat,
6094 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6095 earlier fix to add support for --cflags and --ldflags options
6096 that include quotes so that it works whether make uses cmd or
6097 sh as the shell.
6098
b4289b64
MA
60992011-05-06 Michael Albinus <michael.albinus@gmx.de>
6100
6101 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6102 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6103 is a constant.
6104 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6105 a string. Handle both cases.
6106 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6107 (Fdbus_register_method): Use Qinvalid_function.
6108
af4c0e28
JB
61092011-05-06 Juanma Barranquero <lekktu@gmail.com>
6110
6111 * makefile.w32-in: Update dependencies.
6112 (LISP_H): Add inttypes.h and stdin.h.
6113 (PROCESS_H): Add unistd.h.
6114
c51453d9
EZ
61152011-05-06 Eli Zaretskii <eliz@gnu.org>
6116
6117 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6118 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6119
8ff0ac3c 61202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6121
4c4b566b
PE
6122 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6123
aab2b9b5
PE
6124 * term.c (vfatal): Remove stray call to va_end.
6125 It's not needed and the C Standard doesn't allow it here anyway.
6126
c378da0b
PE
6127 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6128 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6129
288b08c7
PE
6130 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6131 bytes.
6132
e3601888
PE
6133 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6134
db6c0e74
PE
6135 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6136
dd5963ea
PE
6137 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6138
88c9450f
PE
6139 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6140
2f9442b8
PE
6141 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6142
c032b5f8
PE
6143 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6144 * charset.c (Fdefine_charset_internal): Don't initialize
6145 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6146 32-bit int (Bug#8600).
a108c10b
PE
6147
6148 * lread.c (read_integer): Be more consistent with string-to-number.
6149 Use string_to_number to do the actual conversion; this avoids
6150 rounding errors and fixes some other screwups. Without this fix,
6151 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6152 (digit_to_number): Move earlier, for benefit of read_integer.
6153 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6154 not a digit in any supported base. (Bug#8602)
a108c10b 6155
ad5f9eea
PE
6156 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6157
aec1708a
PE
6158 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6159 to match comment at start of function. This also removes a
6160 GCC warning about overflow in a 32+64-bit port.
6161
47be4ab5
PE
6162 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6163
371cac43
PE
6164 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6165 Reported by Stefan Monnier in
6166 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6167 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6168 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6169
d01a7826
PE
6170 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6171 (EMACS_UINTPTR): Likewise, with uintptr_t.
6172
7fd47d5c
PE
6173 * lisp.h: Prefer 64-bit EMACS_INT if available.
6174 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6175 on 32-bit hosts that have 64-bit int, so that they can access
6176 large files.
122b0c86
PE
6177 However, temporarily disable this change unless the temporary
6178 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6179
8727937b
PE
6180 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6181
8ac068ac
PE
6182 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6183 This removes an assumption that EMACS_INT and long are the same
6184 width as pointers. The assumption is true for Emacs porting targets
6185 now, but we want to make other targets possible.
6186 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6187 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6188 In the rest of the code, change types of integers that hold casted
6189 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6190 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6191 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6192 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6193 No need to cast type when ORing.
6194 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6195 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6196 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6197 assume EMACS_INT is the same width as char *.
6198 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6199 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6200 Remove no-longer-needed casts.
6201 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6202 (xg_tool_bar_help_callback, xg_make_tool_item):
6203 Use EMACS_INTPTR to hold an integer
6204 that will be cast to void *; this can avoid a GCC warning
6205 if EMACS_INT is not the same width as void *.
6206 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6207 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6208 (current_message_1, set_message_1):
6209 Use a local to convert to proper width without a cast.
6210 * xmenu.c (dialog_selection_callback): Likewise.
6211
ede49d71
PE
6212 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6213 Also, don't assume VALBITS / RAND_BITS is less than 5,
6214 and don't rely on undefined behavior when shifting a 1 left into
6215 the sign bit.
6216 * lisp.h (get_random): Change signature to match.
6217
2f30ecd0
PE
6218 * lread.c (hash_string): Use size_t, not int, for hash computation.
6219 Normally we prefer signed values; but hashing is special, because
6220 it's better to use unsigned division on hash table sizes so that
6221 the remainder is nonnegative. Also, size_t is the natural width
6222 for hashing into memory. The previous code used 'int', which doesn't
6223 retain enough info to hash well into very large tables.
6224 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6225
2a866e7b
PE
6226 * dbusbind.c: Don't possibly lose pointer info when converting.
6227 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6228 Use XPNTR rather than XHASH, so that the high-order bits of
6229 the pointer aren't lost when converting through void *.
6230
51639eac
PE
6231 * eval.c (Fautoload): Don't double-shift a pointer.
6232
92394119
PE
6233 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6234
dbdb9a7c
JB
62352011-05-06 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * gnutls.c (DEF_GNUTLS_FN):
6238 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6239
db7a0b4f
AS
62402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6241
6242 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6243 marker. (Bug#8610)
6244
cd394be1 62452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6246
6247 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6248 New version that can reserve upto 2GB of heap space.
6249
f7ff1b0f 62502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6251
6252 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6253
639c109b
TZ
62542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6255
6256 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6257 `gnutls_certificate_set_x509_key_file'.
6258
d2127135
JB
62592011-05-05 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6262 Update dependencies.
6263
e968f4f3
JB
62642011-05-04 Juanma Barranquero <lekktu@gmail.com>
6265
6266 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6267 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6268 Remove unused parameter `fildes'.
6269 * process.c (read_process_output, send_process): Don't pass it.
6270
84d358f0
JB
62712011-05-04 Juanma Barranquero <lekktu@gmail.com>
6272
6273 Fix previous change: the library cache is defined in w32.c.
6274 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6275 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6276
0898ca10
JB
62772011-05-04 Juanma Barranquero <lekktu@gmail.com>
6278
6279 Implement dynamic loading of GnuTLS on Windows.
6280
6281 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6282 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6283 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6284 Declare.
6285
6286 * gnutls.c (Qgnutls_dll): Define.
6287 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6288 (gnutls_*): Declare function pointers.
6289 (init_gnutls_functions): New function to initialize function pointers.
6290 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6291 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6292 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6293 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6294 (emacs_gnutls_write, emacs_gnutls_read)
6295 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6296 (Fgnutls_available_p): New function.
6297 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6298 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6299 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6300
6301 * image.c: Include w32.h.
6302 (Vimage_type_cache): Delete.
6303 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6304 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6305 (w32_delayed_load): Move to w32.c.
6306
6307 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6308
6309 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6310 (w32_delayed_load): Move from image.c. When loading a library, record
6311 its filename in the :loaded-from property of the library id.
6312 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6313 Initialize and staticpro them.
6314 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6315
6316 * process.c: Include lisp.h before w32.h, not after.
6317 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6318 instead of gnutls_record_check_pending.
6319
6320 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6321
ff4de4aa
TZ
63222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6323
6324 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6325 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6326 as passed in.
6327
abe95abb
JD
63282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6329
6330 * xterm.c (x_set_frame_alpha): Do not set property on anything
6331 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6332
e16e55d4
JB
63332011-05-02 Juanma Barranquero <lekktu@gmail.com>
6334
6335 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6336
bafcf6a5
JB
63372011-05-02 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6340 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6341 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6342 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6343 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6344 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6345 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6346 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6347 (Qgnutls_bootprop_callbacks_verify): Make static.
6348
e7a6747f
AS
63492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6350
19ed11ba
AS
6351 * callproc.c: Indentation fixup.
6352
e7a6747f 6353 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6354 (wait_for_termination, interruptible_wait_for_termination):
6355 Move after wait_for_termination_1.
e7a6747f 6356
1ef14cb4
LMI
63572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6358
6359 * sysdep.c (interruptible_wait_for_termination): New function
6360 which is like wait_for_termination, but allows keyboard
6361 interruptions.
6362
6363 * callproc.c (Fcall_process): Add (:file "file") as an option for
6364 the STDOUT buffer.
6365 (Fcall_process_region): Ditto.
6366
330d880c
EZ
63672011-04-30 Eli Zaretskii <eliz@gnu.org>
6368
8db90b73
EZ
6369 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6370 rather than `XVECTOR (FOO)->size'.
6371
330d880c
EZ
6372 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6373 inttypes.h, as a gnulib replacement is used if it not available in
6374 system headers.
6375
15cbd324
EZ
63762011-04-21 Eli Zaretskii <eliz@gnu.org>
6377
6378 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6379 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6380 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6381
6382 * coding.c (coding_alloc_by_realloc): Error out if destination
6383 will grow beyond MOST_POSITIVE_FIXNUM.
6384 (decode_coding_emacs_mule): Abort if there isn't enough place in
6385 charbuf for the composition carryover bytes. Reserve an extra
6386 space for up to 2 characters produced in a loop.
6387 (decode_coding_iso_2022): Abort if there isn't enough place in
6388 charbuf for the composition carryover bytes.
6389
63902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6391
ae940cca
EZ
6392 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6393 aborting when %lld or %lll format is passed.
6394 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6395 %llo or %llx format is passed. (Bug#8545)
6396
03ab8921
EZ
6397 * window.c (window_scroll_line_based): Use a marker instead of
6398 simple variables to record original value of point. (Bug#7952)
6399
afda1437
EZ
6400 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6401 produced by %s or %c overflows available buffer space. (Bug#8545)
6402
f76dee0c
PE
64032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6404
6405 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6406 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6407
fdc5744d
JB
64082011-04-28 Juanma Barranquero <lekktu@gmail.com>
6409
6410 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6411
638f053a
JB
64122011-04-28 Juanma Barranquero <lekktu@gmail.com>
6413
6414 * keyboard.c (Qdelayed_warnings_hook): Define.
6415 (command_loop_1): Run `delayed-warnings-hook'
6416 if Vdelayed_warnings_list is non-nil.
6417 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6418 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6419
d178f871
EZ
64202011-04-28 Eli Zaretskii <eliz@gnu.org>
6421
6422 * doprnt.c (doprnt): Don't return value smaller than the buffer
6423 size if the message was truncated. (Bug#8545).
6424
b124fd93
JB
64252011-04-28 Juanma Barranquero <lekktu@gmail.com>
6426
6427 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6428 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6429
e810457d
PE
64302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6431
6432 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6433
ea51cceb
JB
64342011-04-27 Juanma Barranquero <lekktu@gmail.com>
6435
6436 * makefile.w32-in: Update dependencies.
6437
94dcfacf
EZ
64382011-04-27 Eli Zaretskii <eliz@gnu.org>
6439
6440 Improve `doprnt' and its usage. (Bug#8545)
6441 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6442 `format_end'. Remove support for %l as a conversion specifier.
6443 Don't use xrealloc. Improve diagnostics when the %l size modifier
6444 is used. Update the commentary.
6445
6446 * eval.c (verror): Simplify calculation of size_t.
6447
6448 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6449 messages.
6450
f61f41d7
PE
64512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6452
6453 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6454 change.
6455
96fb4434
PE
64562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6457
6458 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6459 This makes this file independent of the recent pseudovector change.
6460
671875da 64612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6462
69e9b5a3
PE
6463 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6464
b5f869a7 6465 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6466 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6467 Remove unused local.
c8926152 6468 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6469
841a1577 6470 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6471 GCC 4.6.0 optimizes based on type-based alias analysis.
6472 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6473 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6474 != &v->size, and therefore "v->size = 1; b->size = 2; return
6475 v->size;" must therefore return 1. This assumption is incorrect
6476 for Emacs, since it type-puns struct Lisp_Vector * with many other
6477 types. To fix this problem, this patch adds a new type struct
f904488f 6478 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6479 and pseudovectors, and helps optimizing compilers not get fooled
6480 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6481 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6482 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6483 the size member.
eab3844f
PE
6484 (XSETPVECTYPE): Rewrite in terms of new macro.
6485 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6486 This is a bit clearer, and further avoids the possibility of
6487 undesirable aliasing.
6488 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6489 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6490 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6491 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6492 (ASIZE): Now uses header.size rather than size.
6493 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6494 to avoid the hassle of writing XVECTOR (foo)->header.size.
6495 (struct vectorlike_header): New type.
eab3844f
PE
6496 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6497 object, to help avoid aliasing.
6498 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6499 (SUBRP): Likewise, since Lisp_Subr is a special case.
6500 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6501 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6502 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6503 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6504 changed to be "header.size" and "header.next".
6505 * buffer.h (struct buffer): Likewise.
6506 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6507 * frame.h (struct frame): Likewise.
6508 * process.h (struct Lisp_Process): Likewise.
6509 * termhooks.h (struct terminal): Likewise.
6510 * window.c (struct save_window_data, struct saved_window): Likewise.
6511 * window.h (struct window): Likewise.
6512 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6513 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6514 * buffer.c (init_buffer_once): Likewise.
6515 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6516 special case.
6517 * process.c (Fformat_network_address): Use local var for size,
6518 for brevity.
6519
0df1eac5
PE
6520 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6521
847ab9d1 6522 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6523 * data.c (atof): Remove decl; no longer used or needed.
6524 (digit_to_number): Move to lread.c.
6525 (Fstring_to_number): Use new string_to_number function, to be
6526 consistent with how the Lisp reader treats infinities and NaNs.
6527 Do not assume that floating-point numbers represent EMACS_INT
6528 without losing information; this is not true on most 64-bit hosts.
6529 Avoid double-rounding errors, by insisting on integers when
6530 parsing non-base-10 numbers, as the documentation specifies.
6531 * lisp.h (string_to_number): New decl, replacing ...
6532 (isfloat_string): Remove.
bc0a5c13 6533 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6534 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6535 appears to have been a coding error. Similarly, do not accept
6536 strings like +-1e0 as floating point numbers. Do not report
6537 overflow for integer overflows unless the base is not 10 which
6538 means we have no simple and reliable way to continue.
6539 Break out the floating-point parsing into a new
6540 function string_to_number, so that Fstring_to_number parses
6541 floating point numbers consistently with the Lisp reader.
04f2d78b 6542 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6543 (E_CHAR, EXP_INT): Remove, replacing with ...
6544 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6545 (string_to_number): New function, replacing isfloat_string.
6546 This function checks for valid syntax and produces the resulting
6547 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6548 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6549 so that overflow for non-base-10 numbers is reported only when
6550 there's no portable and simple way to convert to floating point.
452f4150 6551
67769ffc
PE
6552 * textprop.c (set_text_properties_1): Rewrite for clarity,
6553 and to avoid GCC warning about integer overflow.
6554
c20db43f
PE
6555 * intervals.h (struct interval): Use EMACS_INT for members
6556 where EMACS_UINT might cause problems. See
6557 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6558 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6559 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6560 All uses changed.
37aa2f85
PE
6561 (offset_intervals): Tell GCC not to worry about length overflow
6562 when negating a negative length.
c20db43f 6563
2538aa2f
PE
6564 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6565 (overrun_check_free): Likewise.
6566
f2d3008d
PE
6567 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6568 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6569 word size.
6570
ec8df744
PE
6571 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6572 (gnutls_make_error): Rename local to avoid shadowing.
6573 (gnutls_emacs_global_deinit): ifdef out; not used.
6574 (Fgnutls_boot): Use const for pointer to readonly storage.
6575 Comment out unused local. Fix pointer signedness problems.
6576
640ee02d
PE
6577 * lread.c (openp): Don't stuff size_t into an 'int'.
6578 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6579 about possible signed overflow.
6580
6048fb2a
PE
6581 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6582 (GDK_KEY_g): Don't define if already defined.
6583 (xg_prepare_tooltip): Avoid pointer signedness problem.
6584 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6585
fa3c87e1
PE
6586 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6587 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6588
2172544b
PE
6589 * xfns.c (Fx_window_property): Simplify a bit,
6590 to make a bit faster and to avoid GCC 4.6.0 warning.
6591 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6592
9b821a21
PE
6593 * fns.c (internal_equal): Don't assume size_t fits in int.
6594
3c616cfa
PE
6595 * alloc.c (compact_small_strings): Tighten assertion a little.
6596
c2982e87
PE
6597 Replace pEd with more-general pI, and fix some printf arg casts.
6598 * lisp.h (pI): New macro, generalizing old pEd macro to other
6599 conversion specifiers. For example, use "...%"pI"d..." rather
6600 than "...%"pEd"...".
6601 (pEd): Remove. All uses replaced with similar uses of pI.
6602 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6603 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6604 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6605 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6606 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6607 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6608 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6609 64-bit hosts.
6610 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6611 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6612 * print.c (safe_debug_print, print_object): Likewise.
6613 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6614 to int.
6f04d126
PE
6615 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6616 avoiding the 0 flag, which is not portable.
c2982e87
PE
6617 * process.c (Fmake_network_process): Use pI to avoid cast.
6618 * region-cache.c (pp_cache): Likewise.
6619 * xdisp.c (decode_mode_spec): Likewise.
6620 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6621 behavior on 64-bit hosts with printf arg.
6f04d126 6622 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6623 (x_stop_queuing_selection_requests): Likewise.
6624 (x_get_window_property): Don't truncate byte count to an 'int'
6625 when tracing.
0b432f21 6626
5e073ec7
PE
6627 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6628 here, since it parses constructs like leading '-' and spaces,
6629 which are not wanted; and it overflows with large numbers.
6630 Instead, simply match F[0-9]+, which is what is wanted anyway.
6631
36372bf9
PE
6632 * alloc.c: Remove unportable assumptions about struct layout.
6633 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6634 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6635 (allocate_vectorlike, make_pure_vector): Use the new macros,
6636 plus offsetof, to remove unportable assumptions about struct layout.
6637 These assumptions hold on all porting targets that I know of, but
6638 they are not guaranteed, they're easy to remove, and removing them
6639 makes further changes easier.
6640
0b432f21
PE
6641 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6642 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6643 (string_overrun_cookie): Now const. Use initializers that
6644 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6645 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6646 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6647 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6648 multiple of sizeof (EMACS_INT); it need not be, if
6649 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6650 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6651
895009e1
JB
66522011-04-26 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6655
6a7a1b0b
TZ
66562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6657
6658 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6659 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6660 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6661
841a1577 66622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6663
6664 * lisp.h (Qdebug): List symbol.
895009e1 6665 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6666 * keyboard.c (debug-on-event): New variable.
6667 (handle_user_signal): Break into debugger when debug-on-event
6668 matches the current signal symbol.
6669
f2d3ba6f
DN
66702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6671
6672 * alloc.c (check_sblock, check_string_bytes)
6673 (check_string_free_list): Convert to standard C.
6674
42ce4c63
TZ
66752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6676
6677 * w32.c (emacs_gnutls_push): Fix typo.
6678
825cd63c
EZ
66792011-04-25 Eli Zaretskii <eliz@gnu.org>
6680
fb11d64d
EZ
6681 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6682 "cast to pointer from integer of different size".
6683
825cd63c
EZ
6684 Improve doprnt and its use in verror. (Bug#8545)
6685 * doprnt.c (doprnt): Document the set of format control sequences
6686 supported by the function. Use SAFE_ALLOCA instead of always
6687 using `alloca'.
6688
6689 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6690 is one byte too soon. Don't use xrealloc; instead xfree and
6691 xmalloc anew.
6692
e061a11b
TZ
66932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6694
6695 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6696 callbacks stage.
6697
6698 * gnutls.c: Renamed global_initialized to
6699 gnutls_global_initialized. Added internals for the
6700 :verify-hostname-error, :verify-error, and :verify-flags
6701 parameters of `gnutls-boot' and documented those parameters in the
6702 docstring. Start callback support.
9173deec
JB
6703 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6704 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6705 on error. Return error code.
e061a11b
TZ
6706 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6707 (emacs_gnutls_read): Likewise.
6708 (Fgnutls_boot): Return handshake error code.
6709 (emacs_gnutls_handle_error): New function.
6710 (wsaerror_to_errno): Likewise.
6711
6712 * w32.h (emacs_gnutls_pull): Add prototype.
6713 (emacs_gnutls_push): Likewise.
6714
6715 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6716 (emacs_gnutls_push): Likewise.
6717
67182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6719
6720 * process.c (wait_reading_process_output): Check if GnuTLS
6721 buffered some data internally if no FDs are set for TLS
6722 connections.
6723
6724 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6725 (LIBS): Link to USER_LIBS.
6726 ($(BLD)/gnutls.$(0)): New target.
6727
fa6996bc
EZ
67282011-04-24 Eli Zaretskii <eliz@gnu.org>
6729
eb35682e
EZ
6730 * xdisp.c (handle_single_display_spec): Rename the
6731 display_replaced_before_p argument into display_replaced_p, to
6732 make it consistent with the commentary. Fix typos in the
6733 commentary.
6734
e2ad650c
EZ
6735 * textprop.c (syms_of_textprop): Remove dead code.
6736 (copy_text_properties): Delete obsolete commentary about an
6737 interface that was deleted long ago. Fix typos in the description
6738 of arguments.
6739
1b2de274
EZ
6740 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6741 to changes in oldXMenu/XMenu.h from 2011-04-16.
6742 <menu_help_message, prev_menu_help_message>: Constify.
6743 (IT_menu_make_room): menu->help_text is now `const char **';
6744 adjust.
6745
6746 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6747 to changes in oldXMenu/XMenu.h from 2011-04-16.
6748 (struct XMenu): Declare `help_text' `const char **'.
6749
6750 * xfaces.c <Qunspecified>: Make extern again.
6751
6752 * syntax.c: Include sys/types.h before including regex.h, as
6753 required by Posix.
6754
762b15be
EZ
6755 * doc.c (get_doc_string): Improve the format passed to `error'.
6756
6757 * doprnt.c (doprnt): Improve commentary.
6758
6759 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6760
6761 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6762 them with etags.
6763
f1052e5d
EZ
6764 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6765 changes in globals.h immediately force recompilation.
762b15be
EZ
6766 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6767 $(CURDIR)/s/ms-w32.h.
6768 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6769
fa6996bc
EZ
6770 * character.c (Fchar_direction): Function deleted.
6771 (syms_of_character): Don't defsubr it.
6772 <char-direction-table>: Deleted.
6773
e6c3da20
EZ
67742011-04-23 Eli Zaretskii <eliz@gnu.org>
6775
6776 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6777 * doprnt.c: Include limits.h.
6778 (SIZE_MAX): New macro.
04f2d78b
CB
6779 (doprnt): Return a size_t value. 2nd arg is now size_t.
6780 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6781 Improve overflow protection. Support `l' modifier for integer
6782 conversions. Support %l conversion. Don't assume an EMACS_INT
6783 argument for integer conversions and for %c.
6784
6785 * lisp.h (doprnt): Restore prototype.
6786
6787 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6788 $(SRC)/character.h.
6789
6790 * Makefile.in (base_obj): Add back doprnt.o.
6791
6792 * deps.mk (doprnt.o): Add back prerequisites.
6793 (callint.o): Depend on character.h.
6794
6795 * eval.c (internal_lisp_condition_case): Include the handler
6796 representation in the error message.
6797 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6798 when breaking from the loop.
6799
6800 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6801
6802 * callint.c (Fcall_interactively): When displaying error message
6803 about invalid control letter, pass the character's codepoint, not
6804 a pointer to its multibyte form. Improve display of the character
6805 in octal and display also its hex code.
6806
6807 * character.c (char_string): Use %x to display the (unsigned)
6808 codepoint of an invalid character, to avoid displaying a bogus
6809 negative value.
6810
6811 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6812 `error', not SYMBOL_NAME itself.
6813
6814 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6815 character arguments to `error'.
6816
6817 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6818 to `error' in error message about FINAL_CHAR argument. Make sure
6819 FINAL_CHAR is a character, and use %c when it is passed as
6820 argument to `error'.
6821
4ffd0d6b 68222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6823
6824 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6825
6826 * w32.c: Include <time.h>.
6827 (sys_localtime): New function.
6828
4ffd0d6b 68292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6830
6831 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6832
4ffd0d6b 6833 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6834
4ffd0d6b 68352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6836
4ffd0d6b
GM
6837 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6838 zombies (Bug#8467).
aac0c6e3 6839
04c56954
EZ
68402011-04-19 Eli Zaretskii <eliz@gnu.org>
6841
6842 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6843 gl_state.e_property when gl_state.object is Qt.
6844
6845 * insdel.c (make_gap_larger): Remove limitation of buffer size
6846 to <= INT_MAX.
6847
16a43933
CY
68482011-04-18 Chong Yidong <cyd@stupidchicken.com>
6849
6850 * xdisp.c (lookup_glyphless_char_display)
6851 (produce_glyphless_glyph): Handle cons cell entry in
6852 glyphless-char-display.
6853 (Vglyphless_char_display): Document it.
6854
6855 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6856 glyphless-char-display.
6857
4581706e
CY
68582011-04-17 Chong Yidong <cyd@stupidchicken.com>
6859
6860 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6861
6862 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6863
6864 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6865 definition for no-X builds.
6866
4887c6e2 68672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6868
fd35b6f9
PE
6869 Static checks with GCC 4.6.0 and non-default toolkits.
6870
5c1ccb01
PE
6871 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6872
006c5daa
PE
6873 * process.c (keyboard_bit_set): Define only if SIGIO.
6874 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6875 (send_process): Repair possible setjmp clobbering.
6876
efc736d3
PE
6877 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6878
4e2fe2e6
PE
6879 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6880
f97334a2
PE
6881 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6882
4e75f29d
PE
6883 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6884 Define only if needed.
6885
90efadd1
PE
6886 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6887 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6888 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6889
3c647824
PE
6890 * dispextern.h (struct redisplay_interface): Rename param
6891 to avoid shadowing.
e264f262 6892 * termhooks.h (struct terminal): Likewise.
761383f4 6893 * xterm.c (xembed_send_message): Likewise.
3c647824 6894
b58c5c4a
PE
6895 * insdel.c (make_gap_smaller): Define only if
6896 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6897
cad59032
PE
6898 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6899 it.
6900
c339dc2e
PE
6901 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6902 so that we aren't warned about unused symbols.
6903
91a3e27b
PE
6904 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6905
399c71d3 6906 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6907
8ffc96f5
PE
6908 * xfns.c (x_real_positions): Mark locals as initialized.
6909
eef9bc79
PE
6910 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6911
098db9dd
PE
6912 * xterm.c: Fix problems found by static analysis with other toolkits.
6913 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6914 (x_dispatch_event): Declare static if USE_GTK, and
6915 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6916 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6917 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6918 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6919 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6920
eb18f6cc
PE
6921 * xmenu.c (menu_help_callback): Pointer type fixes.
6922 Use const pointers when pointing at readonly data. Avoid pointer
6923 signedness clashes.
6924 (FALSE): Remove unused macro.
6925 (update_frame_menubar): Remove unused decl.
6926
1fe72bf8
PE
6927 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6928
60d9e1db
PE
6929 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6930 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6931 (single_menu_item): Rename local to avoid shadowing.
6932
39261c26
PE
6933 * keyboard.c (make_lispy_event): Remove unused local var.
6934
018c5e19
PE
6935 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6936 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6937
63d2b86e
PE
6938 * bitmaps: Change bitmaps from unsigned char back to the X11
6939 compatible char. Avoid the old compiler warnings about
6940 out-of-range initializers by using, for example, '\xab' rather
6941 than 0xab.
6942
aefd87e1
PE
6943 * xgselect.c (xgselect_initialize): Check vs interface
6944 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6945
bf501fb9
PE
6946 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6947
e9829fdf
PE
6948 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6949 to read-only memory.
6950
1086c095
PE
6951 * fns.c (vector): Remove; this old hack is no longer needed.
6952
2baccd04 6953 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6954 Remove unused var.
dde42981 6955 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6956
72391843 6957 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6958
436c16df 6959 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6960 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6961 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6962
92bb796d 6963 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6964 (x_term_init): Remove local to avoid shadowing.
92bb796d 6965
764430a3 6966 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6967
6968 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6969 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6970
d1dfb56c
EZ
69712011-04-16 Eli Zaretskii <eliz@gnu.org>
6972
c4354cb4
EZ
6973 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6974
d1dfb56c
EZ
6975 Fix regex.c, syntax.c and friends for buffers > 2GB.
6976 * syntax.h (struct gl_state_s): Declare character position members
6977 EMACS_INT.
6978
6979 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6980
04f2d78b
CB
6981 * textprop.c (verify_interval_modification, interval_of):
6982 Declare arguments EMACS_INT.
d1dfb56c
EZ
6983
6984 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6985 EMACS_INT.
6986
6987 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6988
6989 * indent.c (Fvertical_motion): Local variable it_start is now
6990 EMACS_INT.
6991
6992 * regex.c (re_match, re_match_2, re_match_2_internal)
6993 (bcmp_translate, regcomp, regexec, print_double_string)
6994 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6995 (re_compile_pattern, re_exec): Declare arguments and local
6996 variables `size_t' and `ssize_t' and return values `regoff_t', as
6997 appropriate.
6998 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6999 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7000 <compile_stack_type>: `size' and `avail' are now `size_t'.
7001
7002 * regex.h <regoff_t>: Use ssize_t, not int.
7003 (re_search, re_search_2, re_match, re_match_2): Arguments that
7004 specify buffer/string position and length are now ssize_t and
7005 size_t. Return type is regoff_t.
7006
613052cd
BK
70072011-04-16 Ben Key <bkey76@gmail.com>
7008
7009 * nsfont.m: Fixed bugs in ns_get_family and
7010 ns_descriptor_to_entity that were caused by using free to
7011 deallocate memory blocks that were allocated by xmalloc (via
7012 xstrdup). This caused Emacs to crash when compiled with
7013 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7014 --enable-checking=xmallocoverrun). xfree is now used to
7015 deallocate these memory blocks.
7016
4170f62f 70172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7018
71b41406
PE
7019 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7020
9587a89d
PE
7021 emacs_write: Accept and return EMACS_INT for sizes.
7022 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7023 et seq.
7024 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7025 Accept and return EMACS_INT.
7026 (emacs_gnutls_write): Return the number of bytes written on
7027 partial writes.
7028 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7029 (emacs_read, emacs_write): Remove check for negative size, as the
7030 Emacs source code has been audited now.
9587a89d
PE
7031 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7032 (emacs_read, emacs_write): Use it.
273a5f82
PE
7033 * process.c (send_process): Adjust to the new signatures of
7034 emacs_write and emacs_gnutls_write. Do not attempt to store
7035 a byte offset into an 'int'; it might overflow.
9587a89d 7036 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7037
3e047f51
PE
7038 * sound.c: Don't assume sizes fit in 'int'.
7039 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7040 Return EMACS_INT, not int.
3e047f51 7041 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7042 Accept EMACS_INT, not int.
7043 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7044 record read return values.
7045
cc39a9db
BK
70462011-04-15 Ben Key <bkey76@gmail.com>
7047
c9d0ec6d
JB
7048 * keyboard.c (Qundefined): Don't declare static since it is used
7049 in nsfns.m.
7050 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7051 static since they are used in nsfont.m.
cc39a9db 7052
6c60eb9f
SM
70532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7054
7055 * process.c (Qprocessp): Don't declare static.
7056 * lisp.h (Qprocessp): Declare again.
7057
7990b61a
JB
70582011-04-15 Juanma Barranquero <lekktu@gmail.com>
7059
7060 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7061
5d4cb038
PE
70622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7063
8bd7b830 7064 Improve C-level modularity by making more things 'static'.
cd64ea1d 7065
e3b27b31
PE
7066 Don't publish debugger-only interfaces to other modules.
7067 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7068 (verify_bytepos, count_markers): Move decls to the only modules
7069 that need them.
7070 * region-cache.h (pp_cache): Likewise.
7071 * window.h (check_all_windows): Likewise.
7072 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7073
5d4cb038
PE
7074 * sysdep.c (croak): Now static, if
7075 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7076 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7077
7078 * alloc.c (refill_memory_reserve): Now static if
7079 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7080 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7081
e87b6180
PE
7082 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7083 Define only if USE_LUCID.
7084
ac64929e
PE
7085 * xrdb.c (x_customization_string, x_rm_string): Now static.
7086
6f37259d
PE
7087 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7088 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7089
1683e3ab
PE
7090 * xdisp.c (draw_row_with_mouse_face): Now static.
7091 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7092
de9c2632
PE
7093 * window.h (check_all_windows): Mark externally visible.
7094
2b96acb7
PE
7095 * window.c (window_deletion_count): Now static.
7096
7097 * undo.c: Make symbols static if they're not exported.
7098 (last_undo_buffer, last_boundary_position, pending_boundary):
7099 Now static.
7100
50436f33
PE
7101 * textprop.c (interval_insert_behind_hooks): Now static.
7102 (interval_insert_in_front_hooks): Likewise.
7103
64520e5c
PE
7104 * term.c: Make symbols static if they're not exported.
7105 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7106 (max_frame_lines, tty_set_terminal_modes):
7107 (tty_reset_terminal_modes, tty_turn_off_highlight):
7108 (get_tty_terminal): Now static.
7109 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7110 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7111 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7112 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7113 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7114
1fa53021
PE
7115 * sysdep.c: Make symbols static if they're not exported.
7116 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7117 Now static.
7118 (sigprocmask_set, full_mask): Remove; unused.
7119 (wait_debugging): Mark as visible.
7120 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7121 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7122
d4b43b22
PE
7123 * syntax.c (syntax_temp): Define only if !__GNUC__.
7124
b7c513d0
PE
7125 * sound.c (current_sound_device, current_sound): Now static.
7126
989b29ad
PE
7127 * search.c (searchbufs, searchbuf_head): Now static.
7128
13a55a78
PE
7129 * scroll.c (scroll_cost): Remove; unused.
7130 * dispextern.h (scroll_cost): Remove decl.
7131
de68a1fc
PE
7132 * region-cache.h (pp_cache): Mark as externally visible.
7133
40ccffa6
PE
7134 * process.c: Make symbols static if they're not exported.
7135 (process_tick, update_tick, create_process, chan_process):
7136 (Vprocess_alist, proc_buffered_char, datagram_access):
7137 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7138 (deactivate_process): Mark defn as static, as well as decl.
7139 * lisp.h (create_process): Remove decl.
7140 * process.h (chan_process, Vprocess_alist): Remove decls.
7141
ad64fc97
PE
7142 * print.c: Make symbols static if they're not exported.
7143 (print_depth, new_backquote_output, being_printed, print_buffer):
7144 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7145 (print_interval, print_number_index, initial_stderr_stream):
7146 Now static.
7147 * lisp.h (Fprinc): Remove decl.
7148 (debug_output_compilation_hack): Mark as externally visible.
7149
adddb265
PE
7150 * sysdep.c (croak): Move decl from here to syssignal.h.
7151 * syssignal.h (croak): Put it here, so the API can be checked when
7152 'croak' is called from dissociate_if_controlling_tty.
7153
1717ede2
PE
7154 * minibuf.c: Make symbols static if they're not exported.
7155 (minibuf_save_list, choose_minibuf_frame): Now static.
7156 * lisp.h (choose_minibuf_frame): Remove decl.
7157
fa5fb2bc
PE
7158 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7159
1e3890d1
PE
7160 * lread.c: Make symbols static if they're not exported.
7161 (read_objects, initial_obarray, oblookup_last_bucket_number):
7162 Now static.
7163 (make_symbol): Remove; unused.
7164 * lisp.h (initial_obarray, make_symbol): Remove decls.
7165
8a1414fa
PE
7166 * keyboard.c: Make symbols static if they're not exported.
7167 (single_kboard, recent_keys_index, total_keys, recent_keys):
7168 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7169 (this_single_command_key_start, echoing, last_auto_save):
7170 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7171 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7172 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7173 (Vlispy_mouse_stem, double_click_count):
7174 Now static.
7175 (force_auto_save_soon): Define only if SIGDANGER.
7176 (ignore_mouse_drag_p): Now static if
7177 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7178 (print_help): Remove; unused.
7179 (stop_character, last_timer_event): Mark as externally visible.
7180 * keyboard.h (ignore_mouse_drag_p): Declare only if
7181 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7182 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7183 * lisp.h (echoing): Remove decl.
7184 (force_auto_save_soon): Declare only if SIGDANGER.
7185 * xdisp.c (redisplay_window): Simplify code, to make it more
7186 obvious that ignore_mouse_drag_p is not accessed if !defined
7187 USE_GTK && !defined HAVE_NS.
7188
93ea6e8f
PE
7189 * intervals.c: Make symbols static if they're not exported.
7190 (merge_properties_sticky, merge_interval_right, delete_interval):
7191 Now static.
7192 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7193
77382fcc
PE
7194 * insdel.c: Make symbols static if they're not exported.
7195 However, leave prepare_to_modify_buffer alone. It's never
7196 called from outside this function, but that appears to be a bug.
7197 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7198 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7199 (adjust_after_replace_noundo): Remove; unused.
7200 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7201 (signal_before_change): Remove decls.
77382fcc 7202
9306c32e
PE
7203 * indent.c (val_compute_motion, val_vmotion): Now static.
7204
cd44d2eb
PE
7205 * image.c: Make symbols static if they're not exported.
7206 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7207 if USE_GTK.
7208 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7209 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7210
ad9a7a06
PE
7211 * fringe.c (standard_bitmaps): Now static.
7212 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7213
81626931
PE
7214 * frame.c: Make symbols static if they're not exported.
7215 (x_report_frame_params, make_terminal_frame): Now static.
7216 (get_frame_param): Now static, unless HAVE_NS.
7217 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7218 (x_get_resource_string): Remove; not used.
7219 * frame.h (make_terminal_frame, x_report_frame_params):
7220 (x_get_resource_string); Remove decls.
7221 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7222 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7223
239f9db9
PE
7224 * font.c, fontset.c: Make symbols static if they're not exported.
7225 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7226 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7227 * font.c (font_close_object): Now static.
7228 * font.h (font_close_object): Remove.
7229 * fontset.c (FONTSET_OBJLIST): Remove.
7230 (free_realized_fontset) #if-0 the body, which does nothing.
7231 (face_suitable_for_char_p): #if-0, as it's never called.
7232 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7233 * xfaces.c (face_at_string_position):
7234 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7235 since 0 is always ASCII.
7236
dfcf3579
PE
7237 * fns.c (weak_hash_tables): Now static.
7238
5045092b
PE
7239 * fileio.c: Make symbols static if they're not exported.
7240 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7241 (Vwrite_region_annotation_buffers): Now static.
7242
57a96f5c
PE
7243 * eval.c: Make symbols static if they're not exported.
7244 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7245 * lisp.h (backtrace_list): Remove decl.
7246
35f08c38
PE
7247 * emacs.c: Make symbols static if they're not exported.
7248 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7249 (fatal_error_code, fatal_error_signal_hook, standard_args):
7250 Now static.
7251 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7252 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7253 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7254 * lisp.h (fatal_error_signal_hook): Remove decl.
7255 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7256
f44bd759
PE
7257 * editfns.c: Move a (normally-unused) function to its only use.
7258 * editfns.c, lisp.h (get_operating_system_release): Remove.
7259 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7260 worth the hassle of breaking this out.
7261
b532497d
PE
7262 * xterm.c: Make symbols static if they're not exported.
7263 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7264 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7265 (x_destroy_window, x_delete_display):
7266 Now static.
7267 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7268 (x_mouse_leave): Remove; unused.
7269 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7270 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7271 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7272 Remove decls.
7273 (x_mouse_leave): Declare only if WINDOWSNT.
7274 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7275 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7276 USE_X_TOOLKIT.
7277
1675728f
PE
7278 * ftxfont.c: Make symbols static if they're not exported.
7279 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7280 HAVE_FREETYPE.
7281 * font.h (ftxfont_driver): Likewise.
7282
e4cebfca
PE
7283 * xfns.c: Make symbols static if they're not exported.
7284 (x_last_font_name, x_display_info_for_name):
7285 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7286 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7287 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7288 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7289 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7290 (last_show_tip_args): Now static.
7291 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7292 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7293 (x_screen_planes): Remove; unused.
7294 * dispextern.h (x_screen_planes): Remove decl.
7295
5bf46f05
PE
7296 * dispnew.c: Make symbols static if they're not exported.
7297 * dispextern.h (redraw_garbaged_frames, scrolling):
7298 (increment_row_positions): Remove.
7299 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7300 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7301 Now static.
7302 (redraw_garbaged_frames): Remove; unused.
7303
435f4c28
PE
7304 * xfaces.c: Make symbols static if they're not exported.
7305 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7306 Remove decls.
7307 * xterm.h (defined_color): Remove decls.
7308 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7309 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7310 (menu_face_changed_default, defined_color, free_realized_face):
7311 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7312 (ascii_face_of_lisp_face): Remove; unused.
7313
8524aef3
PE
7314 * xdisp.c: Make symbols static if they're not exported.
7315 * dispextern.h (scratch_glyph_row, window_box_edges):
7316 (glyph_to_pixel_coords, set_cursor_from_row):
7317 (get_next_display_element, set_iterator_to_next):
7318 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7319 (show_mouse_face): Remove decls
7320 * frame.h (message_buf_print): Likewise.
7321 * lisp.h (pop_message, set_message, check_point_in_composition):
7322 Likewise.
7323 * xterm.h (set_vertical_scroll_bar): Likewise.
7324 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7325 (message_buf_print, scratch_glyph_row, displayed_buffer):
7326 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7327 (get_next_display_element, show_mouse_face, window_box_edges):
7328 (frame_to_window_pixel_xy, check_point_in_composition):
7329 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7330 (glyph_to_pixel_coords): Remove; unused.
7331
16390cd2
PE
7332 * dired.c (file_name_completion): Now static.
7333
7334 * dbusbind.c (xd_in_read_queued_messages): Now static.
7335
a25f4dfa
PE
7336 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7337 * data.c (circular_list_error): Remove.
7338
14a9c8df
PE
7339 * commands.h (last_point_position, last_point_position_buffer):
7340 (last_point_position_window): Remove decls.
7341 * keyboard.c: Make these variables static.
7342
04f2d78b
CB
7343 * coding.h (coding, code_convert_region, encode_coding_gap):
7344 Remove decls.
74ab6df5
PE
7345 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7346 (iso_code_class, detect_coding, code_convert_region): Now static.
7347 (encode_coding_gap): Remove; unused.
7348
38dfbee1
PE
7349 * chartab.c (chartab_chars, chartab_bits): Now static.
7350
a2cb4e63
PE
7351 * charset.h (charset_iso_8859_1): Remove decl.
7352 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7353 Now static.
7354
127198fd
PE
7355 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7356 * ccl.c (Vccl_program_table): Now static.
7357 (check_ccl_update): Remove; unused.
7358
d85b608f
PE
7359 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7360 * category.h: ... from here.
7361 * category.c (check_category_table, set_category_set): Now static.
7362
31cd66f3
PE
7363 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7364 * lisp.h: Remove these decls.
7365
c358e587
PE
7366 * buffer.c (buffer_count): Remove unused var.
7367
e78aecca
PE
7368 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7369 so that it's not optimized away.
7370 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7371 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7372 exported only to the debugger.
7373
e192d7d3 7374 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7375 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7376
92470028
PE
7377 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7378 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7379 was inaccessible from Lisp.
7380 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7381 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7382
244ed907
PE
7383 alloc.c: Import and export fewer symbols, and remove unused items.
7384 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7385 is defined.
7386 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7387 it's not optimized away by whole-program optimization.
7388 (message_enable_multibyte, free_misc): Remove.
7389 (catchlist, handlerlist, mark_backtrace):
7390 Declare only if BYTE_MARK_STACK.
7391 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7392 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7393 (message_enable_multibyte): Remove decl.
7394 (free_misc, interval_free_list, float_block, float_block_index):
7395 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7396 (cons_free_list, last_marked_index):
7397 Now static.
7398 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7399 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7400 (mark_backtrace): Define only if BYTE_MARK_STACK.
7401 * xdisp.c (message_enable_multibyte): Now static.
7402
61c2b50e 7403 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7404 This makes it easier for human readers (and static analyzers)
7405 to see whether these variables are used from other modules.
7406 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7407 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7408 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7409 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7410 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7411 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7412 * xmenu.c, xselect.c:
7413 Declare Q* vars static if they are not used in other modules.
7414 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7415 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7416 Remove decls of unexported vars.
7417 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7418
95c82688
PE
7419 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7420
16a97296
PE
7421 Make Emacs functions such as Fatom 'static' by default.
7422 This makes it easier for human readers (and static analyzers)
7423 to see whether these functions can be called from other modules.
7424 DEFUN now defines a static function. To make the function external
7425 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7426 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7427 (Finit_image_library):
16a97296
PE
7428 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7429 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7430 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7431 Remove decls, since these functions are now static.
7432 (Funintern, Fget_internal_run_time): New decls, since these functions
7433 were already external.
95c82688 7434
16a97296
PE
7435 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7436 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7437 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7438 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7439 * keyboard.c, keymap.c, lread.c:
7440 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7441 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7442 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7443 Mark functions with DEFUE instead of DEFUN,
7444 if they are used in other modules.
7445 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7446 decls for now-static functions.
7447 * buffer.h (Fdelete_overlay): Remove decl.
7448 * callproc.c (Fgetenv_internal): Mark as internal.
7449 * composite.c (Fremove_list_of_text_properties): Remove decl.
7450 (Fcomposition_get_gstring): New forward static decl.
7451 * composite.h (Fcomposite_get_gstring): Remove decl.
7452 * dired.c (Ffile_attributes): New forward static decl.
7453 * doc.c (Fdocumntation_property): New forward static decl.
7454 * eval.c (Ffetch_bytecode): New forward static decl.
7455 (Funintern): Remove extern decl; now in .h file where it belongs.
7456 * fileio.c (Fmake_symbolic_link): New forward static decl.
7457 * image.c (Finit_image_library): New forward static decl.
7458 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7459 * intervals.h (Fprevious_property_change):
7460 (Fremove_list_of_text_properties): Remove decls.
7461 * keyboard.c (Fthis_command_keys): Remove decl.
7462 (Fcommand_execute): New forward static decl.
7463 * keymap.c (Flookup_key): New forward static decl.
7464 (Fcopy_keymap): Now static.
7465 * keymap.h (Flookup_key): Remove decl.
7466 * process.c (Fget_process): New forward static decl.
7467 (Fprocess_datagram_address): Mark as internal.
7468 * syntax.c (Fsyntax_table_p): New forward static decl.
7469 (skip_chars): Remove duplicate decl.
7470 * textprop.c (Fprevious_property_change): New forward static decl.
7471 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7472 Now internal.
7473 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7474 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7475
785bbd42
PE
7476 * editfns.c (Fformat): Remove unreachable code.
7477
8b913b57
AS
74782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7479
7480 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7481 change. (Bug#8496)
7482
a6744a35
EZ
74832011-04-13 Eli Zaretskii <eliz@gnu.org>
7484
7485 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7486 when at ZV. (Bug#8487)
7487
e7974947
AS
74882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7489
baad03f0
AS
7490 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7491 (Bug#8437)
7492 * keyboard.c (parse_tool_bar_item): Likewise.
7493 * sound.c (sound_cleanup, alsa_close): Likewise.
7494 * termcap.c (tgetent): Likewise.
7495 * xfns.c (x_default_font_parameter): Likewise.
7496 * xsettings.c (read_and_apply_settings): Likewise.
7497
e7974947
AS
7498 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7499 (overrun_check_free): Protoize.
7500
28272684
PE
75012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7502
7503 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7504 since callers should never pass a negative size.
7505 Change the signature to match that of plain 'read' and 'write'; see
7506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7507 * lisp.h: Update prototypes of emacs_write and emacs_read.
7508
11997c76
EZ
75092011-04-11 Eli Zaretskii <eliz@gnu.org>
7510
7511 * xdisp.c (redisplay_window): Don't try to determine the character
7512 position of the scroll margin if the window start point w->startp
e896f03c 7513 is outside the buffer's accessible region. (Bug#8468)
11997c76 7514
8a2cbd72
EZ
75152011-04-10 Eli Zaretskii <eliz@gnu.org>
7516
7517 Fix write-region and its subroutines for buffers > 2GB.
7518 * fileio.c (a_write, e_write): Modify declaration of arguments and
7519 local variables to support buffers larger than 2GB.
7520 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7521
7522 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7523 argument, local variables, and return value.
7524
7525 * lisp.h: Update prototypes of emacs_write and emacs_read.
7526
7527 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7528
4073e537 75292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7530
1ebfdcb6
PE
7531 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7532
b2ded58d
PE
7533 Fix more problems found by GCC 4.6.0's static checks.
7534
7d66342c
PE
7535 * xdisp.c (vmessage): Use a better test for character truncation.
7536
bbf47d44
PE
7537 * charset.c (load_charset_map): <, not <=, for optimization,
7538 and to avoid potential problems with integer overflow.
9248994d 7539 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7540 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7541 * editfns.c (Fformat): Likewise.
1e69125e 7542 * syntax.c (skip_chars): Likewise.
3befa583 7543
e3019616
PE
7544 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7545 This also lets GCC 4.6.0 generate slightly better loop code.
7546
becfa255
PE
7547 * callint.c (Fcall_interactively): <, not <=, for optimization.
7548 (Fcall_interactively): Count the number of arguments produced,
7549 not the number of arguments given. This is simpler and lets GCC
7550 4.6.0 generate slightly better code.
7551
dae0cd48
PE
7552 * ftfont.c: Distingish more carefully between FcChar8 and char.
7553 The previous code passed unsigned char * to a functions like
7554 strlen and xstrcasecmp that expect char *, which does not
7555 conform to the C standard.
7556 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7557 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7558 char * when the C standard requires it.
7559
76032d70
PE
7560 * keyboard.c (read_char): Remove unused var.
7561
eb3f1cc8
PE
7562 * eval.c: Port to Windows vsnprintf (Bug#8435).
7563 Include <limits.h>.
7564 (SIZE_MAX): Define if the headers do not.
7565 (verror): Do not give up if vsnprintf returns a negative count.
7566 Instead, grow the buffer. This ports to Windows vsnprintf, which
7567 does not conform to C99. Problem reported by Eli Zaretskii.
7568 Also, simplify the allocation scheme, by avoiding the need for
7569 calling realloc, and removing the ALLOCATED variable.
7570
70476b54
PE
7571 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7572
12020a9e
PE
7573 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7574 But keep the doprint source code for now, as we might revamp it
7575 and use it again (Bug#8435).
ea6c7ae6
PE
7576 * lisp.h (doprnt): Remove.
7577 * Makefile.in (base_obj): Remove doprnt.o.
7578 * deps.mk (doprnt.o): Remove.
7579
5fdb398c
PE
7580 error: Print 32- and 64-bit integers portably (Bug#8435).
7581 Without this change, on typical 64-bit hosts error ("...%d...", N)
7582 was used to print both 32- and 64-bit integers N, which relied on
7583 undefined behavior.
7584 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7585 New macro.
7586 * lisp.h (error, verror): Mark as printf-like functions.
7587 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7588 Report overflow in size calculations when allocating printf buffer.
7589 Do not truncate output string at its first null byte.
7590 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7591 Truncate the output at a character boundary, since vsnprintf does not
7592 do that.
7593 * charset.c (check_iso_charset_parameter): Convert internal
7594 character to string before calling 'error', since %c now has the
7595 printf meaning.
7596 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7597 overflow when computing char to be passed to 'error'. Do not
7598 pass Lisp_Object to 'error'; pass the integer instead.
7599 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7600 formatted with plain %d.
7601
b189fa66
PE
7602 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7603
bff87ef0
PE
7604 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7605
7e2cac20
PE
7606 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7607
ce4d90b5
PE
7608 * xterm.c (x_catch_errors): Remove duplicate declaration.
7609
266c9547
PE
7610 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7611
79c49ad2
PE
7612 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7613
368f4090
JM
76142011-04-10 Jim Meyering <meyering@redhat.com>
7615
7616 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7617 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7618 return ssize_t not "int", and use size_t as the buffer length.
7619 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7620 * gnutls.h: Update declarations.
7621 * process.c (read_process_output): Use ssize_t, to match.
7622 (send_process): Likewise.
7623
a32d4040
CY
76242011-04-09 Chong Yidong <cyd@stupidchicken.com>
7625
7626 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7627
8546720e 76282011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7629
04f2d78b
CB
7630 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7631 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7632
8546720e
GM
7633 * xterm.c (handle_one_xevent):
7634 * xmenu.c (create_and_show_popup_menu):
7635 * xselect.c (x_decline_selection_request)
7636 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7637
0a2f5c1a 76382011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7639
7640 Fix some uses of `int' instead of EMACS_INT.
7641 * search.c (string_match_1, fast_string_match)
7642 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7643 (scan_buffer, find_next_newline_no_quit)
7644 (find_before_next_newline, search_command, Freplace_match)
7645 (Fmatch_data): Make some `int' variables be EMACS_INT.
7646
7647 * xdisp.c (display_count_lines): 3rd argument and return value now
7648 EMACS_INT. All callers changed.
7649 (pint2hrstr): Last argument is now EMACS_INT.
7650
7651 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7652 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7653 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7654 (decode_coding_utf_16, decode_coding_emacs_mule)
7655 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7656 (decode_coding_ccl, decode_coding_charset)
7657 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7658 (decode_coding_iso_2022, decode_coding_emacs_mule)
7659 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7660 <char_offset, last_offset>: Declare EMACS_INT.
7661 (encode_coding_utf_8, encode_coding_utf_16)
7662 (encode_coding_emacs_mule, encode_invocation_designation)
7663 (encode_designation_at_bol, encode_coding_iso_2022)
7664 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7665 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7666 Declare EMACS_INT.
7667 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7668 (encode_invocation_designation): Last argument P_NCHARS is now
7669 EMACS_INT.
7670 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7671 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7672
7673 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7674 All users changed.
7675
7676 * ccl.c (Fccl_execute_on_string): Declare some variables
7677 EMACS_INT.
7678
8546720e 76792011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7680
7681 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7682
4e19a977
CS
76832011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7684
7685 * process.c (Fformat_network_address): Doc fix.
7686
87302331
R
76872011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7688
ee7683eb 7689 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7690
cbb59342
CY
76912011-04-08 Chong Yidong <cyd@stupidchicken.com>
7692
7693 * keyboard.c (read_char): Call Lisp function help-form-show,
7694 instead of using internal_with_output_to_temp_buffer.
7695 (Qhelp_form_show): New var.
e0d38eeb 7696 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7697
7698 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7699
7700 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7701
e67a13ab
CY
77022011-04-06 Chong Yidong <cyd@stupidchicken.com>
7703
04f2d78b
CB
7704 * process.c (Flist_processes): Remove to Lisp.
7705 (list_processes_1): Delete.
e67a13ab 7706
973f782d
EZ
77072011-04-06 Eli Zaretskii <eliz@gnu.org>
7708
7c106b1e
EZ
7709 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7710
973f782d
EZ
7711 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7712
41cf7d1a 77132011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7714
ca23cc88
PE
7715 Fix more problems found by GCC 4.6.0's static checks.
7716
f390e2d5
PE
7717 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7718
42eea0d0
PE
7719 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7720
b69769da 7721 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7722
f9541e84
PE
7723 * xdisp.c (vmessage): Mark as a printf-like function.
7724
13841b55
PE
7725 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7726
c136c10f
PE
7727 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7728
5e2d4a30
PE
7729 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7730 printf-like functions.
7731 (tiff_load): Add casts to remove these marks before passing them
7732 to system-supplied API.
7733
583f48b9
PE
7734 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7735
b25d760e
PE
7736 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7737 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7738 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7739 directly, rather than having caller test rule sign. This avoids
7740 some unnecessary tests.
7741 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7742 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7743 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7744
bc7b6697 7745 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7746 (xfont_open): Avoid unnecessary tests.
bc7b6697 7747
27ccc379
PE
7748 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7749
dcd5c89a
PE
7750 * composite.h, composite.c (composition_gstring_put_cache):
7751 Use EMACS_INT, not int, for length.
7752
b13a45c6
PE
7753 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7754 breaking out part of COMPOSITION_DECODE_RULE.
7755 (COMPOSITION_DECODE_RULE): Use it.
7756 * composite.c (get_composition_id): Remove unused local vars,
7757 by using the new macro.
7758
1e792e4d
PE
7759 * textprop.c (set_text_properties_1): Change while to do-while,
7760 since the condition is always true at first.
7761
dc6c6455 7762 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7763 (interval_deletion_adjustment): Return unsigned value.
7764 All uses changed.
dc6c6455 7765
aba7731a
PE
7766 * process.c (list_processes_1, create_pty, read_process_output):
7767 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7768 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7769 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7770 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7771 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7772
fdfc4bf3
PE
7773 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7774
fca8fe46 7775 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7776 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7777
06a0259a 7778 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7779 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7780 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7781
e7b9e80f
PE
7782 * print.c (print_error_message): Avoid int overflow.
7783
56201685
PE
7784 * font.c (font_list_entities): Redo for clarity,
7785 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7786
78834453 7787 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7788 (font_score): Avoid potential overflow in diff calculation.
78834453 7789
0bc0b309 7790 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7791 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7792
e610eaca
PE
7793 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7794
b895abce
PE
7795 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7796 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7797 can always succeed if overflow has undefined behavior.
7798
1f1d9321 7799 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7800 (wordify): Omit three unnecessary tests.
1f1d9321 7801
c59478bc
PE
7802 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7803 All callers changed. This avoids the need for an unused var.
7804
79b73827
PE
7805 * casefiddle.c (casify_region): Remove var that is set but not used.
7806
a4db5dfe
PE
7807 * dired.c (file_name_completion): Remove var that is set but not used.
7808
43aae36e
PE
7809 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7810
2a47c44d 7811 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7812 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7813
a37c69bf
PE
7814 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7815 Check for integer overflow on size calculations.
7816
328ab8e7
PE
7817 * buffer.c (Fprevious_overlay_change): Remove var that is set
7818 but not used.
7819
e5a2a5cb
PE
7820 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7821 Remove vars that are set but not used.
8d84a6eb 7822 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7823 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7824
a60e5f68
PE
7825 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7826
f661cb61 7827 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7828 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7829
f0397f5a
PE
7830 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7831 that are set but not used.
7832
8664db06 7833 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7834 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7835
6abdaa4a
PE
7836 * xselect.c (x_get_local_selection, x_handle_property_notify):
7837 Remove vars that are set but not used.
7838
0ce7538d 7839 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7840 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7841
9ae848fc
PE
7842 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7843 Remove var that is set but not used.
0b918413
PE
7844 (scroll_bar_windows_size): Now size_t, not int.
7845 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7846 Check for overflow.
9ae848fc 7847
a5a62657
PE
7848 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7849 (map_tty_color) [!defined MSDOS]: Likewise.
7850
5c5cdd39
PE
7851 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7852
66ebf983
PE
7853 * coding.c: Remove vars that are set but not used.
7854 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7855 All callers changed.
7856 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7857 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7858 (decode_coding_charset): Remove vars that are set but not used.
7859
1be4d761
PE
7860 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7861 that is set but not used.
7862
47553fa8
PE
7863 * print.c (print_object): Remove var that is set but not used.
7864
1f7196bf 7865 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7866 The gnulib version avoids calling malloc in the usual case,
7867 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7868 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7869 * filelock.c (current_lock_owner): Likewise.
7870 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7871 * sysdep.c: Include allocator.h, careadlinkat.h.
7872 (emacs_no_realloc_allocator): New static constant.
7873 (emacs_readlink): New function.
fdb61804
PE
7874 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7875 ../lib/careadlinkat.h.
d1fdcab7 7876
f84c17c7
SM
78772011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7878
7879 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7880 first non-nil return value).
7881
ef3862ad
JD
78822011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7883
7884 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7885 if not defined (Bug#8403).
7886
376a7006
JB
78872011-04-02 Juanma Barranquero <lekktu@gmail.com>
7888
7889 * xdisp.c (display_count_lines): Remove parameter `start',
7890 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7891 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7892 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7893 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7894 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7895 and thereabouts. All callers changed.
7896 (get_per_char_metric): Remove parameter `f', unused since
7897 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7898
6ca3801d
JM
78992011-04-02 Jim Meyering <meyering@redhat.com>
7900
7901 do not dereference NULL upon failed strdup
7902 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7903 (ns_get_family): Likewise.
7904
d8e2b5ba
JB
79052011-04-02 Juanma Barranquero <lekktu@gmail.com>
7906
7907 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7908
8c74fcbd
JD
79092011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7910
7911 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7912 later (Bug#8403).
7913
7200d79c
SM
79142011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7915
03408648 7916 Add lexical binding.
7200d79c 7917
03408648
SM
7918 * window.c (Ftemp_output_buffer_show): New fun.
7919 (Fsave_window_excursion):
7920 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7921
7922 * lread.c (lisp_file_lexically_bound_p): New function.
7923 (Fload): Bind Qlexical_binding.
7924 (readevalloop): Remove `evalfun' arg.
7925 Bind Qinternal_interpreter_environment.
7926 (Feval_buffer): Bind Qlexical_binding.
7927 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7928 Mark as dynamic.
7929 (syms_of_lread): Declare `lexical-binding'.
7930
7931 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7932
7933 * keyboard.c (eval_dyn): New fun.
7934 (menu_item_eval_property): Use it.
ca105506
SM
7935
7936 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7937
03408648
SM
7938 * fns.c (concat, mapcar1): Accept byte-code-functions.
7939
7940 * eval.c (Fsetq): Handle lexical vars.
7941 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7942 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7943 (FletX, Flet): Obey lexical binding.
7944 (Fcommandp): Handle closures.
7945 (Feval): New `lexical' arg.
7946 (eval_sub): New function extracted from Feval. Use it almost
7947 everywhere where Feval was used. Look up vars in lexical env.
7948 Handle closures.
7949 (Ffunctionp): Move from subr.el.
7950 (Ffuncall): Handle closures.
7951 (apply_lambda): Remove `eval_flags'.
7952 (funcall_lambda): Handle closures and new byte-code-functions.
7953 (Fspecial_variable_p): New function.
7954 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7955 but without exporting it to Lisp.
23aba0ea 7956
23aba0ea 7957 * doc.c (Fdocumentation, store_function_docstring):
03408648 7958 * data.c (Finteractive_form): Handle closures.
23aba0ea 7959
03408648
SM
7960 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7961 interactive spec.
ba83908c 7962
04f2d78b
CB
7963 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7964 New byte-codes.
03408648
SM
7965 (exec_byte_code): New function extracted from Fbyte_code to handle new
7966 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7967
03408648 7968 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7969
03408648 7970 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7971
e2abce01
JB
79722011-03-31 Juanma Barranquero <lekktu@gmail.com>
7973
7974 * xdisp.c (redisplay_internal): Fix prototype.
7975
63696a73 79762011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7977
63696a73 7978 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7979 (try_scrolling): Use it when setting scroll_limit.
7980 Limit scrolling to 100 screen lines.
63696a73
EZ
7981 (redisplay_window): Even when falling back on "recentering",
7982 position point in the window according to scroll-conservatively,
7983 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7984
7985 (try_scrolling): When point is above the window, allow searching
7986 as far as scroll_max, or one screenful, to compute vertical
7987 distance from PT to the scroll margin position. This prevents
7988 try_scrolling from unnecessarily failing when
7989 scroll-conservatively is set to a value slightly larger than the
7990 window height. Clean up the case of PT below the margin at bottom
7991 of window: scroll_max can no longer be INT_MAX. When aggressive
7992 scrolling is in use, don't let point enter the opposite scroll
7993 margin as result of the scroll.
7994 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7995 threshold of 100 lines for never-recentering scrolling.
7996
e4cc2dfc
JB
79972011-03-31 Juanma Barranquero <lekktu@gmail.com>
7998
7999 * dispextern.h (move_it_by_lines):
8000 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8001 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8002 (message_log_check_duplicate): Remove parameters `prev_bol' and
8003 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8004 (redisplay_internal): Remove parameter `preserve_echo_area',
8005 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8006
8007 * indent.c (Fvertical_motion):
8008 * window.c (window_scroll_pixel_based, Frecenter):
8009 Don't pass `need_y_p' to `move_it_by_lines'.
8010
1c470562
SM
80112011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8012
44f230aa
SM
8013 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8014 steal a few bits to be more compact.
8015 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8016 Remove unneeded casts.
8017
1c470562
SM
8018 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8019
888adce9
ZK
80202011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8021
8022 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8023 binding" message (bug#7967).
8024
f838ed7b
PE
80252011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8026
77861b95
PE
8027 Fix more problems found by GCC 4.6.0's static checks.
8028
de6dbc14
PE
8029 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8030 Remove unused local var.
8031
f838ed7b
PE
8032 * editfns.c (Fmessage_box): Remove unused local var.
8033
792c7b2b
PE
8034 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8035 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8036 Omit unused local vars.
c499e557 8037 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8038 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8039 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8040 Omit unused local var.
8041
ba0165e1
PE
8042 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8043 Don't assume string length fits in int.
32ad8845 8044 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8045 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8046
3c59b4c9
PE
8047 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8048 instead of alloca (Bug#8344).
8049
a3eed478 8050 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8051 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8052
eb4d412d
PE
8053 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8054
1658b401
PE
8055 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8056 concerns.
8057
8058 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8059
8060 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8061
9a2c6e05
PE
8062 * keyboard.c (syms_of_keyboard): Use the same style as later
8063 in this function when indexing through an array. This also
8064 works around GCC bug 48267.
8065
03d0a109
PE
8066 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8067
44f730c8
PE
8068 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8069
fe75f926
PE
8070 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8071 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8072
ffa8c828
PE
8073 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8074 This avoids undefined behavior on integer overflow, and is a bit
8075 more convenient anyway since it is compared to a size_t variable.
8076
c5101a77
PE
8077 Variadic C functions now count arguments with size_t, not int.
8078 This avoids an unnecessary limitation on 64-bit machines, which
8079 caused (substring ...) to crash on large vectors (Bug#8344).
8080 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8081 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8082 All variadic functions and their callers changed accordingly.
c5101a77
PE
8083 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8084 * data.c (arith_driver, float_arith_driver): Likewise.
8085 * editfns.c (general_insert_function): Likewise.
8086 * eval.c (struct backtrace.nargs, interactive_p)
8087 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8088 (funcall_lambda, mark_backtrace): Likewise.
8089 * fns.c (concat): Likewise.
8090 * frame.c (x_set_frame_parameters): Likewise.
8091 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8092 0 if not found, not -1. All callers changed.
8093
dd3f25f7
PE
8094 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8095 (stack_copy_size): Now size_t, not int.
8096 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8097
461c2ab9
JB
80982011-03-28 Juanma Barranquero <lekktu@gmail.com>
8099
8100 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8101 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8102 All callers changed.
8103
8104 * lisp.h (multibyte_char_to_unibyte):
8105 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8106 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8107 * character.h (CHAR_TO_BYTE8):
8108 * cmds.c (internal_self_insert):
8109 * editfns.c (general_insert_function):
8110 * keymap.c (push_key_description):
8111 * search.c (Freplace_match):
8112 * xdisp.c (message_dolog, set_message_1): All callers changed.
8113
f6d62986
SM
81142011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8115
8116 * keyboard.c (safe_run_hook_funcall): New function.
8117 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8118 don't set the hook to nil, but remove the offending function instead.
8119 (Qcommand_hook_internal): Remove, unused.
8120 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8121 Vcommand_hook_internal.
8122
8123 * eval.c (enum run_hooks_condition): Remove.
8124 (funcall_nil, funcall_not): New functions.
8125 (run_hook_with_args): Call each function through a `funcall' argument.
8126 Remove `cond' argument, now redundant.
8127 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8128 (Frun_hook_with_args_until_failure): Adjust accordingly.
8129 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8130
1db5b1ad
JB
81312011-03-28 Juanma Barranquero <lekktu@gmail.com>
8132
8133 * dispextern.h (string_buffer_position): Remove declaration.
8134
8135 * print.c (strout): Remove parameter `multibyte', unused since
8136 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8137
8138 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8139 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8140 All callers changed.
8141
8142 * w32.c (_wsa_errlist): Use braces for struct initializers.
8143
8144 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8145 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8146 All callers changed.
8147 (string_buffer_position): Likewise. Also, make static (it's never
8148 used outside xdisp.c).
8149 (cursor_row_p): Remove parameter `w', unused since
8150 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8151 (decode_mode_spec): Remove parameter `precision', introduced during
8152 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8153 All callers changed.
8154
5ffb62aa
JD
81552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8156
8157 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8158
461c2ab9 81592011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8160
8161 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8162 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8163 (ns_update_auto_hide_menu_bar): New functions.
8164 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8165 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8166 ns_constrain_all_frames.
8167 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8168 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8169
5c380ffb
JD
81702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8171
8172 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8173
9af30bdf
GM
81742011-03-27 Glenn Morris <rgm@gnu.org>
8175
8176 * syssignal.h: Replace RETSIGTYPE with void.
8177 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8178 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8179 Replace SIGTYPE with void everywhere.
8180 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8181 * s/template.h (SIGTYPE): Remove commented out definition.
8182
e2abce01
JB
81832011-03-26 Eli Zaretskii <eliz@gnu.org>
8184
8185 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8186 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8187
f868cd8a
JB
81882011-03-26 Juanma Barranquero <lekktu@gmail.com>
8189
59eb0929
JB
8190 * w32.c (read_unc_volume): Use parameter `henum', instead of
8191 global variable `wget_enum_handle'.
8192
8193 * keymap.c (describe_vector): Remove parameters `indices' and
8194 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8195 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8196
f868cd8a
JB
8197 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8198
8199 * keyboard.c (timer_check): Remove parameter `do_it_now',
8200 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8201 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8202 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8203
8204 * keyboard.c (read_char):
8205 * w32menu.c (w32_menu_display_help):
8206 * xmenu.c (show_help_event, menu_help_callback):
8207 Adjust calls to `show_help_echo'.
8208
8209 * gtkutil.c (xg_maybe_add_timer):
8210 * keyboard.c (readable_events):
8211 * process.c (wait_reading_process_output):
8212 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8213
8214 * insdel.c (adjust_markers_gap_motion):
8215 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8216 (gap_left, gap_right): Don't call it.
8217
2ecf6fdb
CY
82182011-03-25 Chong Yidong <cyd@stupidchicken.com>
8219
8220 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8221 incurred during fontification.
8222
6b1f9ba4
JB
82232011-03-25 Juanma Barranquero <lekktu@gmail.com>
8224
8225 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8226 (DEFVAR_PER_BUFFER): Don't pass it.
8227
8228 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8229 (scrolling_window): Don't pass it.
8230
0f4a96b5
JB
82312011-03-25 Juanma Barranquero <lekktu@gmail.com>
8232
8233 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8234
8235 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8236 and `suffix'.
8237 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8238 of variables specific to SELinux and computation of `encoded_absname'.
8239
8240 * image.c (XPutPixel): Remove unused variable `height'.
8241
8242 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8243
8244 * unexw32.c (get_section_info): Remove unused variable `section'.
8245
8246 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8247 (system_process_attributes): Remove unused variable `sess'.
8248 (sys_read): Remove unused variable `err'.
8249
8250 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8251 (w32_wnd_proc): Remove unused variable `isdead'.
8252 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8253 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8254 (x_create_tip_frame): Remove unused variable `tem'.
8255
8256 * w32inevt.c (w32_console_read_socket):
8257 Remove unused variable `no_events'.
8258
8259 * w32term.c (x_draw_composite_glyph_string_foreground):
8260 Remove unused variable `width'.
8261
1149507c
JB
82622011-03-24 Juanma Barranquero <lekktu@gmail.com>
8263
8264 * w32term.c (x_set_glyph_string_clipping):
8265 Don't pass uninitialized region to CombineRgn.
8266
9c88f339
JB
82672011-03-23 Juanma Barranquero <lekktu@gmail.com>
8268
8269 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8270 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8271 (Fx_close_connection): Remove unused variable `i'.
8272
8273 * w32font.c (w32font_draw): Return number of glyphs.
8274 (w32font_open_internal): Remove unused variable `i'.
8275 (w32font_driver): Add missing initializer.
8276
8277 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8278 (fill_in_menu): Remove unused variable `items_added'.
8279
8280 * w32term.c (last_mouse_press_frame): Remove static global variable.
8281 (w32_clip_to_row): Remove unused variable `f'.
8282 (x_delete_terminal): Remove unused variable `i'.
8283
8284 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8285 (NOTHING): Remove unused static global variable.
8286 (uniscribe_check_otf): Remove unused variable `table'.
8287 (uniscribe_font_driver): Add missing initializers.
8288
dee091a3
JD
82892011-03-23 Julien Danjou <julien@danjou.info>
8290
8291 * term.c (Fsuspend_tty, Fresume_tty):
8292 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8293 * window.c (temp_output_buffer_show):
8294 * insdel.c (signal_before_change):
8295 * frame.c (Fhandle_switch_frame):
8296 * fileio.c (Fdo_auto_save):
8297 * emacs.c (Fkill_emacs):
8298 * editfns.c (save_excursion_restore):
8299 * cmds.c (internal_self_insert):
8300 * callint.c (Fcall_interactively):
8301 * buffer.c (Fkill_all_local_variables):
8302 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8303 Use Frun_hooks.
0f4a96b5 8304 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8305 unconditionally since it does the check itself.
dee091a3 8306
2c520ab5 83072011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8308
c9c49752
PE
8309 Fix more problems found by GCC 4.5.2's static checks.
8310
8abc3f12
PE
8311 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8312 the first time through the loop, since we know p0 < p1 then.
8313 This also avoids a gcc -Wstrict-overflow warning.
8314
a2d26660
PE
8315 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8316 leading to a memory leak, possible in functions like
8317 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8318 of objects (Bug#8318).
a2d26660 8319
916c72e9
PE
8320 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8321 that could (at least in theory) be that large.
8322
19ab8a18
PE
8323 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8324 This is less likely to overflow, and avoids undefined behavior if
8325 overflow does occur. All callers changed. Use strtoul to scan
8326 for the unsigned long integer.
b7cbbd6f
PE
8327 (pint2hrstr): Simplify and tune code slightly.
8328 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8329
f0641eff
PE
8330 * scroll.c (do_scrolling): Work around GCC bug 48228.
8331 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8332
7f650bb9
PE
8333 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8334 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8335 (validate_x_resource_name): Simplify count usage.
8336 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8337
37dd57d1
PE
8338 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8339 fail (Bug#8306).
81e56e61 8340
699979fc 8341 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8342
401bf9b4
PE
8343 * process.c (Fmake_network_process): Use socklen_t, not int,
8344 where POSIX says socklen_t is required in portable programs.
8345 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8346 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8347 (Fmake_network_process, server_accept_connection):
8348 (wait_reading_process_output, read_process_output):
8349 Likewise.
8350
b93aacde
PE
8351 * process.c: Rename or move locals to avoid shadowing.
8352 (list_processes_1, Fmake_network_process):
8353 (read_process_output_error_handler, exec_sentinel_error_handler):
8354 Rename or move locals.
4dc343ee 8355 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8356 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8357 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8358 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8359 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8360
af8a867c 8361 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8362 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8363 Include tparam.h instead, since it declares them.
af8a867c
PE
8364 * cm.h (PC): Remove extern decl; tparam.h now does this.
8365 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8366 * terminfo.c: Include tparam.h, to check interfaces.
8367 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8368 (tparam): Adjust signature to match interface in tparam.h;
8369 this removes some undefined behavior. Check that outstring and len
8370 are zero, which they always are with Emacs.
8371 * tparam.h (PC, BC, UP): New extern decls.
8372
0248044d 8373 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8374 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8375
8ff096c1 8376 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8377 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8378 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8379 (ftfont_list): Remove unused local.
49eaafba
PE
8380 (get_adstyle_property, ftfont_pattern_entity):
8381 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8382 Rename locals to avoid shadowing.
8ff096c1 8383
e2be39f6
PE
8384 * xfont.c (xfont_list_family): Mark var as initialized.
8385
c9735e30
PE
8386 * xml.c (make_dom): Now static.
8387
8f5201ae
PE
8388 * composite.c (composition_compute_stop_pos): Rename local to
8389 avoid shadowing.
b246f932
PE
8390 (composition_reseat_it): Remove unused locals.
8391 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8392 (composition_update_it): Mark var as initialized.
11b61122
PE
8393 (find_automatic_composition): Mark vars as initialized,
8394 with a FIXME (Bug#8290).
8f5201ae 8395
760fbc2c
PE
8396 character.h: Rename locals to avoid shadowing.
8397 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8398 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8399 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8400 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8401 to avoid shadowing.
8402
ff08eb85
PE
8403 * textprop.c (property_change_between_p): Remove; unused.
8404
fc7bf025
PE
8405 * intervals.c (interval_start_pos): Now static.
8406
235d7abc
PE
8407 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8408
44f230aa
SM
8409 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8410 Rename locals to avoid shadowing.
3e7d6594 8411
50060332
PE
8412 * sound.c (wav_play, au_play, Fplay_sound_internal):
8413 Fix pointer signedness.
d01f234b 8414 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8415 (wav_play): Initialize a variable to 0, to prevent undefined
8416 behavior (Bug#8278).
50060332 8417
c4fc4e30
PE
8418 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8419
918436ed
PE
8420 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8421
c939f91b
PE
8422 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8423 clobbering (Bug#8298).
b9c7f648
PE
8424 * sysdep.c (sys_subshell): Likewise.
8425 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8426
6bd8c144
PE
8427 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8428 This should get cleaned up, so that child_setup has the
8429 same signature on all platforms.
8430
7710357c 8431 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8432 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8433
c59da222
CY
84342011-03-22 Chong Yidong <cyd@stupidchicken.com>
8435
8436 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8437 not to be necessary, and produces flickering.
8438
66b87493
GM
84392011-03-20 Glenn Morris <rgm@gnu.org>
8440
8441 * config.in: Remove file.
8442
45b6f6d5
JB
84432011-03-20 Juanma Barranquero <lekktu@gmail.com>
8444
8445 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8446 are now in src/globals.h.
8447 (syms_of_minibuf): Remove spurious & from previous change.
8448
cd394be1 84492011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8450
8451 * minibuf.c (completing-read-function): New variable.
8452 (completing-read-default): Rename from completing-read.
8453 (completing-read): Call completing-read-function.
8454
b14e3e21
CY
84552011-03-19 Juanma Barranquero <lekktu@gmail.com>
8456
8457 * xfaces.c (Fx_load_color_file):
8458 Read color file from absolute filename (bug#8250).
8459
f2b726e6
JB
84602011-03-19 Juanma Barranquero <lekktu@gmail.com>
8461
8462 * makefile.w32-in: Update dependencies.
8463
09f6ff02
EZ
84642011-03-17 Eli Zaretskii <eliz@gnu.org>
8465
8466 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8467
29a6015a
PE
84682011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8469
a3a6c54e
PE
8470 Fix more problems found by GCC 4.5.2's static checks.
8471
b766f867
PE
8472 * process.c (make_serial_process_unwind, send_process_trap):
8473 (sigchld_handler): Now static.
8474
be02381c
PE
8475 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8476 That way, the code declares only the vars that it needs.
8477 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8478 * s/cygwin.h (PTY_ITERATION): Likewise.
8479 * s/darwin.h (PTY_ITERATION): Likewise.
8480 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8481
57048744
PE
8482 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8483 * process.c (allocate_pty): Don't declare stb unless it's needed.
8484
7914961c 8485 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8486 (CONSTANTLIM): Remove; unused.
8487 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8488 Define only if needed.
7914961c 8489
b3967b18
PE
8490 * unexelf.c (unexec): Name an expression,
8491 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8492 Use a different way to cause a compilation error if anyone uses
8493 n rather than nn, a way that does not involve shadowing.
73366a00 8494 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8495
29a6015a
PE
8496 * deps.mk (unexalpha.o): Remove; unused.
8497
43cfc33e 8498 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8499 * unexec.h: New file.
ce701a33
PE
8500 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8501 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8502 Depend on unexec.h.
8503 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8504 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8505 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8506 Change as necessary to match prototype in unexec.h.
ce701a33 8507
01f44d5a
PE
8508 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8509 shadowing.
4f63c6bb 8510 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8511
a6670b0b
PE
8512 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8513 Rename locals to avoid shadowing.
8514
cef2010d 8515 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8516 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8517
d4d7173a
PE
8518 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8519
f08b802a
PE
8520 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8521 warning when compiling print.c.
8522
3ddb0639
PE
8523 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8524 instead of using an uninitialized var.
5ad03b97 8525 (font_sort_entities): Mark var as initialized.
3ddb0639 8526
170a2692
PE
8527 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8528
e663c700
PE
8529 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8530 pointers to constants.
89bc529a 8531 (font_parse_fcname): Remove unused vars.
7b81e2d0 8532 (font_delete_unmatched): Now static.
ea838e10 8533 (font_get_spec): Remove; unused.
13a547c6
PE
8534 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8535 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8536 Rename or move locals to avoid shadowing.
e663c700 8537
2a80c887 8538 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8539 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8540
1384fa33 8541 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8542 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8543
8b2c52e9
PE
8544 * alloc.c (mark_backtrace): Move decl from here ...
8545 * lisp.h: ... to here, so that it can be checked.
8546
475545b5 8547 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8548 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8549 (lisp_indirect_variable): Name an expression,
8550 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8551 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8552
b1349114 8553 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8554 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8555 Use const pointer when appropriate.
b1349114 8556
a2928364
PE
8557 * lisp.h (get_system_name, get_operating_system_release):
8558 Move decls here, to check interfaces.
8559 * process.c (get_operating_system_release): Move decl to lisp.h.
8560 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8561 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8562 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8563 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8564 (Fformat_time_string, Fencode_time, Finsert_char):
8565 (Ftranslate_region_internal, Fformat):
8566 Rename or remove local vars to avoid shadowing.
9710023e 8567 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8568
a415e694
PE
8569 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8570 avoid shadowing.
8571
8ef4622d
PE
8572 * lisp.h (eassert): Check that the argument compiles, even if
8573 ENABLE_CHECKING is not defined.
8574
946f9a5b
PE
8575 * data.c (Findirect_variable): Name an expression, to avoid
8576 gcc -Wbad-function-cast warning.
112396d6 8577 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8578 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8579 (Fmake_variable_buffer_local, Fmake_local_variable):
8580 Mark variables as initialized.
52746918 8581 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8582
e5aab7e7 8583 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8584 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8585 Rename locals to avoid shadowing.
dff45157
PE
8586 (mark_stack): Move local variables into the #ifdef region where
8587 they're used.
7bc26fdb
PE
8588 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8589 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8590 needed otherwise.
8591 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8592 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8593 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8594
e5aab7e7
PE
8595 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8596 avoids undefined behavior in theory.
8597
4da60324
PE
8598 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8599
88043301
PE
8600 Use functions, not macros, for up- and down-casing (Bug#8254).
8601 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8602 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8603 to use the following functions instead of these macros.
8604 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8605 EMACS_INT, since callers assume the returned value fits in int.
8606 (upcase1): Likewise, for UPCASE_TABLE.
8607 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8608 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8609 the race-condition problem in the old DOWNCASE.
88043301 8610
19ed5445
PE
8611 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8612 Rename locals to avoid shadowing.
8613 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8614 (regex_compile, re_search_2, re_match_2_internal):
8615 Remove unused local vars.
952db0d7
PE
8616 (FREE_VAR): Rewrite so as not to use empty "else",
8617 which gcc can warn about.
da053e48 8618 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8619 (RETALLOC_IF): Define only if needed.
8620 (WORDCHAR_P): Likewise. This one is never needed, but is used
8621 only in a comment talking about a compiler bug, so put inside
8622 the #if 0 of that comment.
8623 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8624 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8625 Remove; unused.
19ed5445 8626
1f3561e4 8627 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8628 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8629 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8630
ded6f8f7
PE
8631 * search.c (simple_search): Remove unused var.
8632
dbd37a95
PE
8633 * dired.c (compile_pattern): Move decl from here ...
8634 * lisp.h: ... to here, so that it can be checked.
8635 (struct re_registers): New forward decl.
8636
7e47afad
PE
8637 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8638
85f24f61
PE
8639 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8640 All uses changed.
8641 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8642 Rename locals to avoid shadowing.
5671df8f 8643 (Fvertical_motion): Mark locals as initialized.
85f24f61 8644
181aa2be 8645 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8646 (casify_region): Mark local as initialized.
181aa2be 8647
930d429c
PE
8648 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8649
7082eac6
PE
8650 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8651 New macros, so that the caller can use some names other than
8652 gcpro1, gcpro2, etc.
8653 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8654 of the new macros.
8655 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8656 argument, for consistency with GCPRO2_VAR, etc: it is now the
8657 prefix of the variable, not the variable itself. All uses
8658 changed.
38b2c076
PE
8659 * dired.c (directory_files_internal, file_name_completion):
8660 Rename locals to avoid shadowing.
8661
15206ed9
PE
8662 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8663 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8664 dired.c's scmp function, had undefined behavior.
8665 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8666 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8667 * buffer.h: ... to here, because these macros use current_buffer,
8668 and the new implementation with inline functions needs to have
8669 current_buffer in scope now, rather than later when the macros
8670 are used.
8671 (downcase, upcase1): New static inline functions.
8672 (DOWNCASE, UPCASE1): Reimplement using these functions.
8673 This avoids undefined behavior in expressions like
8674 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8675 from race conditions in accessing the global variables
8676 case_temp1 and case_temp2.
8677 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8678 * lisp.h (case_temp1, case_temp2): Remove their decls.
8679 * character.h (ASCII_CHAR_P): Move from here ...
8680 * lisp.h: ... to here, so that the inline functions mentioned
8681 above can use them.
8682
4a6bea26
PE
8683 * dired.c (directory_files_internal_unwind): Now static.
8684
f14b7e14
PE
8685 * fileio.c (file_name_as_directory, directory_file_name):
8686 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8687 Now static.
2893f146
PE
8688 (file_name_as_directory): Use const pointers when appropriate.
8689 (Fexpand_file_name): Likewise. In particular, newdir might
8690 point at constant storage, so make it a const pointer.
fd4ead52 8691 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8692 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8693 signedness issues.
f839df0c
PE
8694 (Fset_file_times, Finsert_file_contents, auto_save_error):
8695 Rename locals to avoid shadowing.
f14b7e14 8696
5716756e 8697 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8698 (Ftry_completion, Fall_completions): Rename or remove locals
8699 to avoid shadowing.
5716756e 8700
b4c3046a
PE
8701 * marker.c (bytepos_to_charpos): Remove; unused.
8702
b45db522
PE
8703 * lisp.h (verify_bytepos, count_markers): New decls,
8704 so that gcc does not warn that these functions aren't declared.
8705
85876d07
PE
8706 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8707 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8708 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8709 (copy_text): Remove unused local var.
85876d07 8710
03d78a21 8711 * filelock.c (within_one_second): Now static.
b3dd38ab 8712 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8713
5df8f01b
PE
8714 * buffer.c (fix_overlays_before): Mark locals as initialized.
8715 (fix_start_end_in_overlays): Likewise. This function should be
8716 simplified by using pointers-to-pointers, but that's a different
8717 matter.
b1d876f1 8718 (switch_to_buffer_1): Now static.
8f54f30a
PE
8719 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8720 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8721
a70072c9 8722 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8723 Fix pointer signedness issue.
edced198
PE
8724 (sys_subshell): Mark local as volatile if checking for lint,
8725 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8726 (MAXPATHLEN): Define only if needed.
a70072c9 8727
a0977c44
PE
8728 * process.c (serial_open, serial_configure): Move decls from here ...
8729 * systty.h: ... to here, so that they can be checked.
8730
a884fdcc
PE
8731 * fns.c (get_random, seed_random): Move extern decls from here ...
8732 * lisp.h: ... to here, so that they can be checked.
8733
604efe86 8734 * sysdep.c (reset_io): Now static.
b8950c94 8735 (wait_for_termination_signal): Remove; unused.
604efe86 8736
38fc62d9
PE
8737 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8738 (copy_keymap_item, append_key, push_text_char_description):
8739 Now static.
1004a21a 8740 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8741 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8742 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8743 (describe_map_tree):
8744 Rename locals to avoid shadowing.
38fc62d9 8745
2f2650da
PE
8746 * keyboard.c: Declare functions static if they are not used elsewhere.
8747 (echo_char, echo_dash, cmd_error, top_level_2):
8748 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8749 (read_char, kbd_buffer_get_event, make_lispy_position):
8750 (make_lispy_event, make_lispy_movement, apply_modifiers):
8751 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8752 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8753 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8754 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8755 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8756
a053e86c 8757 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8758 (mark_kboards): Move decl here ...
8759 * alloc.c (mark_kboards): ... from here.
a053e86c 8760
4752793e
PE
8761 * lisp.h (force_auto_save_soon): New decl.
8762
74f10ca7 8763 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8764 (DEFINE_DUMMY_FUNCTION): New macro.
8765 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8766 Use it.
c03cd23f
PE
8767 (main): Add casts to avoid warnings
8768 if GCC considers string literals to be constants.
74f10ca7 8769
022e70d4
PE
8770 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8771
59d6fe83
PE
8772 * dbusbind.c: Pointer signedness fixes.
8773 (xd_signature, xd_append_arg, xd_initialize):
8774 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8775 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8776 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8777 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8778
78320123
PE
8779 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8780 if GCC considers string literals to be constants.
49cebcca 8781 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8782
35ac2a97
SM
87832011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8784
fb103ca9
SM
8785 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8786 (print_preprocess, print_object): New macro to fix last change.
8787
35ac2a97
SM
8788 * print.c (print_preprocess): Don't forget font objects.
8789
62973b41
JB
87902011-03-16 Juanma Barranquero <lekktu@gmail.com>
8791
8792 * emacs.c (USAGE3): Doc fixes.
8793
0e48bb22
AS
87942011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8795
8796 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8797 structure.
8798
7684e57b
JB
87992011-03-14 Juanma Barranquero <lekktu@gmail.com>
8800
8801 * lisp.h (VWindow_system, Qfile_name_history):
8802 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8803 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8804 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8805
8806 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8807 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8808
8809 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8810 * w32console.c (detect_input_pending, read_input_pending)
8811 (encode_terminal_code):
8812 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8813 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8814 (w32_system_caret_y, Qfile_name_history):
8815 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8816 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8817 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8818 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8819 * w32proc.c (Qlocal, report_file_error):
8820 * w32term.c (Vwindow_system, updating_frame):
8821 * w32uniscribe.c (initialized, uniscribe_font_driver):
8822 Remove unneeded extern declarations.
8823
2aa46d6c
CY
88242011-03-14 Chong Yidong <cyd@stupidchicken.com>
8825
c96bbc66 8826 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8827
cffc6f3b
CY
88282011-03-13 Chong Yidong <cyd@stupidchicken.com>
8829
8830 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8831 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8832 These macros can no longer be used for assignment.
8833
44f230aa
SM
8834 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8835 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8836 (record_buffer_markers, fetch_buffer_markers): New functions for
8837 recording and fetching special buffer markers.
8838 (set_buffer_internal_1, set_buffer_temp): Use them.
8839
8840 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8841
8842 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8843
8844 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8845 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8846
8847 * xdisp.c (hscroll_window_tree):
8848 (reconsider_clip_changes): Use PT instead of BUF_PT.
8849
d251f04b
EZ
88502011-03-13 Eli Zaretskii <eliz@gnu.org>
8851
8852 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8853 $(EMACS_ROOT)/lib/intprops.h.
8854
f0c77cd1
PE
88552011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8856
3eca4629
PE
8857 Fix more problems found by GCC 4.5.2's static checks.
8858
7c86ee98
PE
8859 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8860 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8861 (xg_free_frame_widgets): Make it clear that a local variable is
8862 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8863 (gdk_window_get_screen): Make it clear that this macro is needed
8864 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8865 (int_gtk_range_get_value): New function, which avoids a diagnostic
8866 from gcc -Wbad-function-cast.
8867 (xg_set_toolkit_scroll_bar_thumb): Use it.
8868 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8869 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8870 (get_utf8_string, xg_get_file_with_chooser):
8871 Rename locals to avoid shadowing.
8872 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8873
41729b81
PE
8874 * xgselect.c (xg_select): Remove unused var.
8875
f0c77cd1
PE
8876 * image.c (four_corners_best): Mark locals as initialized.
8877 (gif_load): Initialize transparent_p to zero (Bug#8238).
8878 Mark another local as initialized.
ec6cf4c6 8879 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8880
ce0ad53d 8881 * image.c (clear_image_cache): Now static.
d5d5a617 8882 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8883 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8884 (x_edge_detection): Remove unnecessary cast that
8885 gcc -Wbad-function-cast diagnoses.
2037898d 8886 (gif_load): Fix pointer signedness.
6ae141d6
PE
8887 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8888 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8889
33383987 88902011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8891
d32df629
PE
8892 Improve quality of tests for time stamp overflow.
8893 For example, without this patch (encode-time 0 0 0 1 1
8894 1152921504606846976) returns the obviously-bogus value (-948597
8895 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8896 reports time overflow. See
8897 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8898 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8899 * editfns.c: Include limits.h and intprops.h.
8900 (TIME_T_MIN, TIME_T_MAX): New macros.
8901 (time_overflow): Move earlier, to before first use.
8902 (hi_time, lo_time): New functions, for an accurate test for
8903 out-of-range times.
8904 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8905 (Fget_internal_run_time): Don't assume time_t fits in int.
8906 (make_time): Use list2 instead of Fcons twice.
8907 (Fdecode_time): More accurate test for out-of-range times.
8908 (check_tm_member): New function.
8909 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8910 (lisp_time_argument): Don't rely on undefined left-shift and
8911 right-shift behavior when checking for time stamp overflow.
8be6f318 8912
fe31d94c
PE
8913 * editfns.c (time_overflow): New function, refactoring common code.
8914 (Fformat_time_string, Fdecode_time, Fencode_time):
8915 (Fcurrent_time_string): Use it.
8916
8be6f318
PE
8917 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8918 * dired.c (make_time): Move to ...
8919 * editfns.c (make_time): ... here.
8920 * systime.h: Note the move.
8921
09d9db2c 89222011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8923
126bc0dc
YM
8924 * fringe.c (update_window_fringes): Remove unused variables.
8925
c47cbdfd
YM
8926 * unexmacosx.c (copy_data_segment): Also copy __got section.
8927 (Bug#8223)
8928
7ac80be9
EZ
89292011-03-12 Eli Zaretskii <eliz@gnu.org>
8930
c96bbc66 8931 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8932 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8933 Constify `char *' arguments and their references according to
8934 prototypes in tparam.h.
8935
ecb0f94d 8936 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8937
7ac80be9
EZ
8938 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8939 Adapt all references accordingly.
8940
8941 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8942
ef1fd07e
TT
89432011-03-11 Tom Tromey <tromey@redhat.com>
8944
8945 * buffer.c (syms_of_buffer): Remove obsolete comment.
8946
7ef4b50c
EZ
89472011-03-11 Eli Zaretskii <eliz@gnu.org>
8948
8949 * termhooks.h (encode_terminal_code): Declare prototype.
8950
8951 * msdos.c (encode_terminal_code): Don't declare prototype.
8952
8953 * term.c (encode_terminal_code): Now external again, used by
8954 w32console.c and msdos.c.
8955
44f230aa
SM
8956 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8957 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8958
4b1ec863 89592011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8960
1714f52b 8961 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8962
4b1ec863
PE
8963 * fringe.c (update_window_fringes): Mark locals as initialized
8964 (Bug#8227).
8965 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8966
524c7aa6
PE
8967 * alloc.c (mark_fringe_data): Move decl from here ...
8968 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8969 to check its interface.
8970 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8971
a5c0af81 8972 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8973 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8974 (fontset_font): Mark local as initialized.
a9a06e0b 8975 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8976
b4716021
PE
8977 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8978
811e9bac 8979 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8980 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8981 (x_own_selection, Fx_disown_selection_internal): Rename locals
8982 to avoid shadowing.
8983 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8984
7e3ab302
PE
8985 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8986 so that the caller can use some name other than gcpro1.
8987 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8988 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8989 (Fx_backspace_delete_keys_p):
8990 Use them to avoid shadowing, and rename vars to avoid shadowing.
8991 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8992 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8993 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8994 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8995 Remove unused locals.
7e3ab302
PE
8996 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8997 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8998 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8999 macros.
f78faa98 9000
e2b13473
PE
9001 * xterm.h (x_mouse_leave): New decl.
9002
77f23912
PE
9003 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9004 Remove unused functions.
cdf4ba58
PE
9005 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9006 (x_calc_absolute_position): Now static.
7411c686 9007 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9008 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9009 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9010 unless they are used.
38d0b34a
PE
9011 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9012 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9013 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9014 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9015 (x_error_catcher, x_connection_closed, x_error_handler):
9016 (x_error_quitter, xembed_send_message, x_iconify_frame):
9017 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9018 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9019 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9020
44f230aa
SM
9021 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9022 Rename or move locals to avoid shadowing.
6b463e58 9023 (tty_defined_color, merge_face_heights): Now static.
5967d051 9024 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9025 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9026 does not deduce is never used uninitialized.
73719eba
PE
9027 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9028 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9029
426994c3 9030 * terminal.c (store_terminal_param): Now static.
5489860b 9031
032f1620 9032 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9033 (set_frame_menubar): Remove unused local.
d4323972 9034 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9035 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9036 since they might point to immutable storage.
281585b0
PE
9037 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9038 since it's unused otherwise.
032f1620 9039
367c19e5 9040 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9041 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9042 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9043 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9044 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9045 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9046 does not deduce are never used uninitialized.
70739cbe 9047
07b48fa9
PE
9048 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9049
8868a238 9050 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9051 * window.c (window_loop, size_window):
9052 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9053
7e5cf297 9054 * window.c (display_buffer): Now static.
d6550a9f
PE
9055 (size_window): Mark variables that gcc -Wuninitialized
9056 does not deduce are never used uninitialized.
a586633d
PE
9057 * window.h (check_all_windows): New decl, to forestall
9058 gcc -Wmissing-prototypes diagnostic.
5b555da1 9059 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9060
f6095868
PE
9061 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9062 shadowing.
9063 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9064 Include <limits.h>.
9065 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9066 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9067 (load_charset_map): Mark variables that gcc -Wuninitialized
9068 does not deduce are never used uninitialized.
53df7c11 9069 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9070
f38b440c
PE
9071 * coding.c (coding_set_source, coding_set_destination):
9072 Use "else { /* comment */ }" rather than "else /* comment */;"
9073 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9074 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9075 a block, when the outer 'i' will do.
9076 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9077 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9078 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9079 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9080 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9081 Rename locals to avoid shadowing.
9082 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9083 * coding.c (emacs_mule_char, encode_invocation_designation):
9084 Now static, since they're not used elsewhere.
413bb2db 9085 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9086 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9087 (decode_coding_emacs_mule): Mark variables that gcc
9088 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9089 (detect_coding_iso_2022): Initialize a local variable that might
9090 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9091 this initialization is needed. (Bug#8211)
5f58e762
PE
9092 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9093 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9094 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9095 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9096 Remove unused macros.
f38b440c 9097
232b38b9 9098 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9099 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9100 * character.c (string_count_byte8): Likewise.
232b38b9 9101
fb90da1b
PE
9102 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9103 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9104
fb93dbc2
PE
9105 * chartab.c (copy_sub_char_table): Now static, since it's not used
9106 elsewhere.
5c156ace
PE
9107 (sub_char_table_ref_and_range, char_table_ref_and_range):
9108 Rename locals to avoid shadowing.
bbcd0949 9109 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9110
7d3b3862 9111 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9112 (BIDI_BOB): Remove unused macro.
7d3b3862 9113
6be7d3da
PE
9114 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9115 deduce are never used uninitialized.
c2ed9c8b 9116 * term.c (encode_terminal_code): Likewise.
6be7d3da 9117
75f8807f 9118 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9119
50938595
PE
9120 * tparam.h: New file.
9121 * term.c, tparam.h: Include it.
9122 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9123 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9124 Move these decls to tparam.h, and make them agree with what
9125 is actually in tparam.c. The previous trick of using incompatible
9126 decls in different modules does not conform to the C standard.
9127 All callers of tparam changed to use tparam's actual API.
9128 * tparam.c (tparam1, tparam, tgoto):
9129 Use const pointers where appropriate.
9130
fbceeba2
PE
9131 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9132 * cm.h (struct cm): Likewise.
9133 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9134 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9135 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9136 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9137 (turn_on_face, init_tty): Likewise.
9138 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9139
7f3f1250
PE
9140 * term.c (term_mouse_position): Rename local to avoid shadowing.
9141
e6ca6543
PE
9142 * alloc.c (mark_ttys): Move decl from here ...
9143 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9144
c40f8d15
AS
91452011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9146
9147 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9148
cfe0661d
JB
91492011-03-09 Juanma Barranquero <lekktu@gmail.com>
9150
9151 * search.c (compile_pattern_1): Remove argument regp, unused since
9152 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9153 (compile_pattern): Don't pass it.
9154
0afb4571
J
91552011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9156
9157 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9158 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9159 for ! HAVE_GTK3.
9160 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9161
9162 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9163
9164 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9165 gdk_window_get_screen, gdk_window_get_geometry,
9166 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9167 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9168 (xg_get_pixbuf_from_pixmap): New function.
9169 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9170 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9171 Call xg_get_pixbuf_from_pixmap instead of
9172 gdk_pixbuf_get_from_drawable.
9173 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9174 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9175 (xg_check_special_colors): Use GtkStyleContext and its functions
9176 for HAVE_GTK3.
9177 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9178 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9179 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9180 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9181 Call gtk_widget_get_preferred_size.
0afb4571
J
9182 (xg_frame_resized): gdk_window_get_geometry only takes 5
9183 parameters.
44f230aa
SM
9184 (xg_win_to_widget, xg_event_is_for_menubar):
9185 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9186 (xg_set_widget_bg): New function.
9187 (delete_cb): New function.
895009e1 9188 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9189 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9190 (xg_set_background_color): Call xg_set_widget_bg.
9191 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9192 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9193 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9194 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9195 if ! HAVE_GTK3.
9196 (update_frame_tool_bar): Call gtk_widget_hide.
9197 (xg_initialize): Use GDK_KEY_g.
9198
9199 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9200 if ! HAVE_GTK3
9201 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9202
9203 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9204 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9205 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9206
1c2cc4ef
JB
92072011-03-08 Juanma Barranquero <lekktu@gmail.com>
9208
9209 * w32xfns.c (select_palette): Check success of RealizePalette against
9210 GDI_ERROR, not zero.
9211
33383987 9212See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9213
9214;; Local Variables:
9215;; coding: utf-8
aac0c6e3
MR
9216;; End:
9217
acaf905b 9218 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9219
9220 This file is part of GNU Emacs.
9221
9222 GNU Emacs is free software: you can redistribute it and/or modify
9223 it under the terms of the GNU General Public License as published by
9224 the Free Software Foundation, either version 3 of the License, or
9225 (at your option) any later version.
9226
9227 GNU Emacs is distributed in the hope that it will be useful,
9228 but WITHOUT ANY WARRANTY; without even the implied warranty of
9229 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9230 GNU General Public License for more details.
9231
9232 You should have received a copy of the GNU General Public License
9233 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.