* lisp/newcomment.el (comment-start-skip, comment-end-skip, comment-end):
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f99714ce
DC
12012-10-08 Daniel Colascione <dancol@dancol.org>
2
3 * xdisp.c (start_hourglass): Call w32_note_current_window when
2b1f11ed
EZ
4 HAVE_NTGUI, not just WINDOWSNT, resolving a problem in the cygw32
5 build that caused Emacs to display the hourglass cursor forever.
f99714ce 6
fd59cb29
GM
7 * w32fns.c (Fx_display_color_cells): Instead of using NCOLORS,
8 which is broken under remote desktop, calculate the number of
9 colors available for a display based on the display's number of
10 planes and number of bits per pixel per plane. (bug#10397).
11
62c480c9 122012-10-08 Jan Djärv <jan.h.d@swipnet.se>
fd59cb29 13
62c480c9
JD
14 * nsfont.m (Vfonts_in_cache): New variable.
15 (nsfont_open): Use unsignedLongLongValue for cache in case wide ints
16 are used. Add cached fonts to Vfonts_in_cache.
17 (syms_of_nsfont): Initialize and staticpro Vfonts_in_cache.
18
607446ba
JB
192012-10-08 Juanma Barranquero <lekktu@gmail.com>
20
fd5125ad
JB
21 * makefile.w32-in (LOCAL_FLAGS): Don't define HAVE_NTGUI, it's now
22 in nt/config.nt.
46979e0b
JB
23 (FONT_H): Define after FRAME_H.
24 ($(BLD)/emacs.$(O), $(BLD)/process.$(O), $(BLD)/w32heap.$(O)):
25 Update dependencies.
fd5125ad 26
607446ba
JB
27 * w32term.c: Remove leftover declaration of keyboard_codepage.
28
b6f4e300
EZ
292012-10-08 Eli Zaretskii <eliz@gnu.org>
30
c54ebba4
EZ
31 * makefile.w32-in (FONT_H): Add $(FRAME_H).
32 (W32TERM_H): Add $(ATIMER_H) and $(FRAME_H).
33 ($(BLD)/emacs.$(O), $(BLD)/w32console.$(O)): Update dependencies.
34 (GLOBAL_SOURCES): Add cygw32.c.
fd59cb29
GM
35 ($(BLD)/unexw32.$(O)):
36 ($(BLD)/w32.$(O)):
37 ($(BLD)/w32console.$(O)):
38 ($(BLD)/w32fns.$(O)):
39 ($(BLD)/w32heap.$(O)):
40 ($(BLD)/w32menu.$(O)):
15c720a3 41 ($(BLD)/w32proc.$(O)): Add w32common.h.
c54ebba4 42
b6f4e300
EZ
43 * w32fns.c (w32_color_map_lookup, x_to_w32_color): Argument is now
44 'const char *'.
45 (x_to_w32_color): Don't modify the argument, modify a copy instead.
46
501199a3
DC
472012-10-08 Daniel Colascione <dancol@dancol.org>
48
49 * w32term.h (WM_EMACS_BRINGTOTOP, WM_EMACS_INPUT_READY)
50 (WM_EMACS_END): Change WM_EMACS_BRINGTOTOP from 22 to 21 to close
51 accidental message numbering hole. Change other messages to
52 match.
53
54 * w32select.h (HAVE_W32SELECT): Remove.
55
56 * w32select.c, w32proc.c, w32menu.c, w32console.c, w32.c: Include
57 w32common.h instead of w32heap.h
58
59 * w32heap.h (ROUND_UP, ROUND_DOWN, get_page_size)
60 (get_allocation_unit, get_processor_type, get_w32_major_version)
61 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
62 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
63 (OS_NT, os_subtype, cache_system_info): Move declarations to
64 w32common.
65
66 * w32heap.c: Include w32common.h.
67 (sysinfo_cache, syspage_mask, osinfo_cache, w32_major_version)
68 (w32_minor_version, w32_build_number, w32_subtype): Remove
69 duplicate definitions.
70
71 * w32fns.c: Include w32common.h; include w32heap.h only in
72 WINDOWSNT.
73
74 (Fx_file_dialog): Clarify comment on GetOpenFileName structure.
75 Use `report_file_error' instead of `error' in order to better
76 inform users of what went wrong. Increase NTGUI_UNICODE file
77 dialog box file name length to 32k, the maximum allowed by the NT
78 kernel.
79
80 * w32common.h: New file.
81 (ROUND_UP, ROUND_DOWN, get_page_size)
82 (get_allocation_unit, get_processor_type, get_w32_major_version)
83 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
84 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
85 (OS_NT, os_subtype, cache_system_info): Move here.
86
87 * unexw32.c, unexcw.c: Include w32common.h.
88
89 * emacs.c (main): Use (defined (WINDOWSNT) || defined
90 HAVE_NTGUI) instead of removed HAVE_W32SELECT to decide whether
91 to call syms_of_w32select.
92
93 * cygw32.h: Remove obsolete EXFUN declarations.
94
95 * cygw32.c (Qutf_16_le): Rename to Qutf_16le.
96
97 * Makefile.in (SOME_MACHINE_OBJECTS): Reverse accidental removal
98 of w32inevt.o from SOME_MACHINE_OBJECTS.
99
93aa5c81
DC
1002012-10-08 Daniel Colascione <dancol@dancol.org>
101
102 * image.c: Permanent fix for JPEG compilation issue --- limit
103 jpeglib `boolean' redefinition to Cygwin builds.
104
d424f3d8
EZ
1052012-10-08 Eli Zaretskii <eliz@gnu.org>
106
8ee4c6ce
EZ
107 * image.c (CHECK_LIB_AVAILABLE): Remove, no longer used.
108
d424f3d8
EZ
109 * emacs.c (DAEMON_MUST_EXEC) [HAVE_NTGUI]: Define this only on
110 Cygwin.
111
e08348a0
DC
1122012-10-08 Daniel Colascione <dancol@dancol.org>
113
114 * xfaces.c, xdisp.c, window.c, w32xfns.c, w32term.h, w32term.c,
115 w32select.h w32select.c, w32proc.c, w32menu.c, w32inevt.c,
116 w32help.c, w32font.c, w32font.c, w32fns.c, w32console.c, w32.h,
117 w32.c, unexw32.c, termhooks.h, process.c, menu.c, keyboard.h,
118 keyboard.c, image.c, frame.h, frame.c, fontset.c, font.h, font.c,
119 emacs.c, dispextern.h, cygw32.h, cygw32.c, conf_post.h,
120 Makefile.in: use HAVE_NTGUI for W32 GUI and WINDOWSNT for the
121 operating system. defined(HAVE_NTGUI) && !defined(WINDOWSNT) is
122 now a supported configuration.
123
124 * Makefile.in: consolidate image variables into LIBIMAGE; add
125 W32_OBJ and W32_LIBS. Compile new files.
126
127 * conf_post.h:
128 (_DebPrint) declare tracing facility for W32 debugging. We need
129 to unify tracing later.
130
131 (NTGUI_UNICODE) Define when compiling for Cygwin to allow the
132 unconditional use of W32 Unicode functions. Cygwin runs only on
133 100% Unicode operating systems.
134
135 * cygw32.c: New file. Define Cygwin-specific facilities.
136 (Fcygwin_convert_path_to_windows)
137 (Fcygwin_convert_path_from_windows): New user functions for
138 accessing Cygwin path-munging routines.
139
140 * cygw32.h: New file.
141 (WCSDATA, to_unicode, from_unicode): Define facilities for storing
142 UTF-16LE strings temporarily inside non-Lisp-visible string
143 objects.
144
145 (w32_strerror): Just what it says on the tin.
146
147 * emacs.c: Make the NS fork-then-exec code for daemon-launching
148 also run for Cygwin; both systems have the same problem with using
149 GUI facilities in a forked child. Also call syms_of_cygw32,
150 syms_of_w32select in correct places.
151
152 (DAEMON_MUST_EXEC): new macro defined to signal that a platform
153 needs fork-then-exec for daemon launching.
154
155 * font.h: Include frame.h.
156
157 * image.c: Use the image library cache machinery only when we're
158 compiling for native WINDOWSNT; Cygwin can use shared libraries
159 like any other Unixlike system.
160
161 * keyboard.c: Clarify a comment regarding the input loop.
162
163 * menu.c: When NTGUI_UNICODE is defined, use Unicode menu
164 functions directly instead of trying to detect at runtime that our
165 host operating system supports them. We make this change for two
166 reasons: Cygwin lacks support for the multibyte character
167 conversion functions used by the legacy menu code, and Cygwin
168 never needs to rely on non-Unicode APIs.
169
170 * unexw32.c (hinst): Declare extern.
171
172 * w32.c: Change header order;
173 (w32_strerror): Move to w32fns.c because we need it for
174 non-WINDOWSNT builds.
175
176 * w32.h: Add #error macro to make sure we don't include w32.h for
177 Cygwin builds. Remove w32select declarations.
178
179 * w32console.c (w32_sys_ring_bell, Fset_message_beep): Move to
180 w32fns.c. w32console.c is WINDOWSNT-only.
181
182 * w32fns.c: Include cygw32.h or w32.h depending on CYGWIN; more
183 NTGUI_UNICODE tweaks. (See above.) Change _snprintf to the more
184 POSIXy alternative.
185 (faked_key, sysinfo_cache, osinfo_cahce, syspage_mask)
186 (w32_major_version, w32_minor_version, w32_build_number)
187 (os_subtype, sound_type): Define here
188 (w32_defined_color): Make color parameter const for consistency
189 with other _defined_color functions.
190 (w32_createwindow): Unconditionally call w32_init_class instead of
191 doing so only when hprevinst is non-NULL. Plumbing hprevinst
192 through the code is complex and unnecessary because class
193 registration is practically free.
194 (w32_name_of_message): New EMACSDEBUG-only function.
195 (Fset_message_beep): Move here
196 (Fx_open_connection): Require that the display name for Windows be
197 "w32" for consistency, emacsclient disambiguation, and maybe, one
198 day, multi-window-system support.
199 (file_dialog_callback): NTGUI_UNICODE changes; encode and decode
200 Cygwin files for W32 GUI facilities, since these clearly don't
201 expect Cygwin names.
202 (_DebPrint): Define.
203 (w32_strerror, w32_console_toggle_lock_key, w32_kbd_mods_to_emacs)
204 (w32_kbd_patch_key, w32_sys_ring_bell): Move here.
205 (Ssystem_move_file_to_trash): Define only for native WINDOWSNT.
206 (w32_last_error): Remove.
207
208 * w32font.c: Define _strlwr to strlwr for non-WINDOWSNT builds.
209
210 * w32heap.c (syspage_mask): Declare here.
211 (cache_system_info): Remove.
212
213 * w32inevt.c (faked_key): Define globally, not statically.
214 (w32_kbd_mods_to_emacs, w32_kbd_patch_key, faked_key)
215 (w32_console_toggle_lock_key): Move to w32fns.c.
216
217 * w32menu.c: Include setjmp.h. NTGUI_UNICODE changes throughout.
218
219 * w32proc.c (_DebPrint): Move to w32fns.c.
220 * w32select.c: Include string.h, stdio.h for Cygwin.
221 * w32select.h: New File.
222
223 * w32term.c: Include io.h for non-CYGWIN builds; needed for
224 get_osfhandle.
225 (w32_message_fd): New variable. Under Cygwin, holds the file
226 descriptor the system used to tell us about pending thread
227 messages.
228
229 (w32_init_term): Remove incorrect calls to fcntl and init_sigio
230 that prevented compilation under non-WINDOWSNT systems.
231
232 (w32_initialize): Open /dev/windows and assign it to
233 w32_message_fd. Provide w32 feature.
234
235 * w32term.h: Include frame.h, atimer.h. Declare various frame functions.
236 (WM_EMACS_INPUT_READY): add.
237 (prepend_msg, w32_message_fd): Declare globally.
238
239 * w32xfns.c:
240 (keyboard_handle): Use only when WINDOWSNT.
241 (notify_msg_ready): New function. Posts a message to the main
242 thread's message queue under CYGWIN, which wakes up the main
243 thread from select(2) by making the /dev/windows file descriptor
244 ready. Under WINDOWSNT, it sets an event the same way the old
245 code did.
246
247 (post, prepend_msg): Actually call notify_msg_ready instead of
248 setting the input event directly.
249
98daa893
EZ
2502012-10-07 Eli Zaretskii <eliz@gnu.org>
251
252 * ralloc.c (relinquish): If a heap is ready to be relinquished,
253 but it still has blocs in it, don't return it to the system,
254 instead of aborting. (Bug#12402)
255
3bc0a2f7
JD
2562012-10-07 Jan Djärv <jan.h.d@swipnet.se>
257
8ad5b73b 258 * nsterm.m (ns_dumpglyphs_image): Only draw slice of image (Bug#12506).
493b5b1c 259
335f5ae4
JD
260 * nsterm.m (ns_update_auto_hide_menu_bar): Remove defintion of
261 MAC_OS_X_VERSION_10_6.
8ad5b73b
JD
262 (syms_of_nsterm): Remove comment about Panther and above for
263 ns-antialias-text.
335f5ae4
JD
264 * nsterm.h (MAC_OS_X_VERSION_10_3, onTiger): Remove.
265 (EmacsApp): Remove check for >= MAC_OS_X_VERSION_10_4.
266 (struct nsfont_info): Remove check for >= MAC_OS_X_VERSION_10_3.
267
268 * nsselect.m (ns_string_from_pasteboard): Remove check for >=
269 MAC_OS_X_VERSION_10_4.
270
8ad5b73b
JD
271 * nsmenu.m (fillWithWidgetValue:): Remove code for <
272 MAC_OS_X_VERSION_10_2.
335f5ae4
JD
273
274 * nsimage.m (setPixmapData, getPixelAtX, setAlphaAtX): Remove onTiger.
275
276 * nsfns.m (Fns_list_services): Remove comment and check for OSX < 10.4.
277 (ns_do_applescript): Remove check for >= MAC_OS_X_VERSION_10_4.
278
3bc0a2f7
JD
279 * nsterm.m (ns_in_resize): Remove (Bug#12479).
280 (ns_resize_handle_rect, mouseDown, mouseUp, mouseDragged): Remove.
8ad5b73b
JD
281 (ns_clear_frame, sendEvent, windowDidResize, drawRect:): Remove
282 ns_in_resize check.
3bc0a2f7
JD
283 (ns_clear_frame_area): Remove resize handle code.
284
285 * nsfns.m (ns_in_resize): Remove.
8ad5b73b
JD
286 (x_set_icon_name, ns_set_name, ns_set_name_as_filename): Remove
287 ns_in_resize check.
3bc0a2f7 288
c622b48f
PE
2892012-10-07 Paul Eggert <eggert@cs.ucla.edu>
290
291 Improve sys_siglist detection.
292 * sysdep.c (sys_siglist, init_signals): Use _sys_siglist if it's
293 defined as a macro, as is done in Solaris.
294 (sys_siglist_entries): New macro.
295 (save_strsignal): Use it.
296 * syssignal.h (safe_strsignal): Now ATTRIBUTE_CONST, to pacify
297 GCC 4.7.2 on Fedora 17 with the fixed sys_siglist detection.
298
04fafa46
JD
2992012-10-06 Jan Djärv <jan.h.d@swipnet.se>
300
301 * nsfns.m (Fx_create_frame): Call x_default_parameter with
302 fullscreen/Fullscreen.
303
304 * nsterm.h (EmacsView): Rename tbar_height to tibar_height.
305 tobar_height is new.
306
307 * nsterm.m (x_make_frame_visible): Check for fullscreen.
308 (ns_fullscreen_hook): Activate old style fullscreen with a timer.
309 (ns_term_init): Set activateIgnoringOtherApps if old style fullscreen.
310 (windowDidResize:): Check for correct window if old style fullscreen.
311 Capitalize word in comment. Remove incorrect comment.
312 (initFrameFromEmacs:): tbar_height renamed tibar_height.
313 (windowDidEnterFullScreen:): Toggle toolbar for fullscreen to fix
314 error in drawing background.
315 (toggleFullScreen:): Remove comment. Rearrange calls.
316 Set toolbar values to zero, save old height in tobar_height.
317 Restore tool bar height when leaving fullscreen.
318 (canBecomeMainWindow): New function.
319
c6e21c03
PE
3202012-10-06 Paul Eggert <eggert@cs.ucla.edu>
321
322 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
323
0d9f584b
EZ
3242012-10-05 Eli Zaretskii <eliz@gnu.org>
325
a65fbb5f
EZ
326 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
327
0d9f584b
EZ
328 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
329 that time stamps of directories could also be changed. Don't
330 request the too broad GENERIC_WRITE, only the more restrictive
331 FILE_WRITE_ATTRIBUTES access rights.
332
333 * fileio.c (Fset_file_times): Special-case ignoring errors for
334 directories only on MSDOS, not on MS-Windows.
335
e8757f09 3362012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
337
338 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
339
7604f298
EZ
3402012-10-04 Eli Zaretskii <eliz@gnu.org>
341
342 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
343 see whether CreateFile failed.
344
88d69b7d
PE
3452012-10-04 Paul Eggert <eggert@cs.ucla.edu>
346
347 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
348 to avoid similar races.
349 * keyboard.c (pending_signals): Now bool, not int.
350
7509f454
PE
351 Port timers to OpenBSD, plus check for timer failures.
352 OpenBSD problem reported by Han Boetes.
353 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
354 and/or setitimer.
355 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
356 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
357 like OpenBSD, which has timer_settime but does not declare it.
358 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
359 whether to use itimerspec-related primitives. All uses of
360 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
361
a3c5c0c5
PE
3622012-10-02 Paul Eggert <eggert@cs.ucla.edu>
363
364 * profiler.c (handle_profiler_signal): Fix a malloc race
365 that caused Emacs to hang on Fedora 17 when profiling Lisp.
366
914e743b
JD
3672012-10-02 Jan Djärv <jan.h.d@swipnet.se>
368
369 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
370
d8ab37a8
EZ
3712012-10-02 Eli Zaretskii <eliz@gnu.org>
372
373 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
374 consistent with the change in return value of 'safe_strsignal'.
375
b3ecad33
PE
3762012-10-02 Paul Eggert <eggert@cs.ucla.edu>
377
0a99eee1
PE
378 Prefer plain 'static' to 'static inline' (Bug#12541).
379 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
380 (bidi_set_sor_type, bidi_push_embedding_level)
381 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
382 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
383 (bidi_cache_search, bidi_cache_ensure_space)
384 (bidi_cache_iterator_state, bidi_cache_find)
385 (bidi_peek_at_next_level, bidi_set_paragraph_end)
386 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
387 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
388 Now 'static', not 'static inline'.
389
b3ecad33
PE
390 Count overruns when profiling; change units to ns.
391 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
392 Give extra weight to samples after overruns, to attempt to count
393 the time more accurately.
394 (setup_cpu_timer): Change sampling interval units from ms to ns, since
395 the underlying primitives nominally do ns.
396 (Fprofiler_cpu_start): Document the change. Mention that
397 the sampling intervals are only approximate.
398
090cf9db
SM
3992012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
400
401 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
402
403 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
404 case for the special 0 coding-system.
405
406 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
407 (Fmake_overlay): Remove redundant tests.
64edc777 408 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 409
81550bf4
JB
4102012-10-02 Juanma Barranquero <lekktu@gmail.com>
411
412 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
413 Update dependencies.
414
aa1ba90e
PE
4152012-10-01 Paul Eggert <eggert@cs.ucla.edu>
416
417 Fix a malloc race condition involving strsignal.
418 A signal can arrive in the middle of a malloc, and Emacs's signal
419 handler can invoke strsignal, which can invoke malloc, which is
420 not portable. This race condition bug makes Emacs hang on GNU/Linux.
421 Fix it by altering the signal handler so that it does not invoke
422 strsignal.
423 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
424 * process.c (status_message): Use const pointer, in case strsignal
425 is #defined to safe_strsignal.
426 * sysdep.c (sys_siglist, init_signals): Always define and
427 initialize a substitute sys_siglist if the system does not define
428 one, even if HAVE_STRSIGNAL.
429 (safe_strsignal): Rename from strsignal. Always define,
430 using sys_siglist. Return a const pointer.
431 * syssignal.h (safe_strsignal): New decl.
432 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
433
ace917bd
EZ
4342012-10-01 Eli Zaretskii <eliz@gnu.org>
435
436 * w32proc.c (timer_loop): Fix code that waits for timer
437 expiration, to avoid high CPU usage.
438
9eb71b9c
SM
4392012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
440
441 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
442 (sweep_weak_table): Remove redundant prototypes.
443
b3317662
FP
4442012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
445
446 * emacs.c: Move the inclusion of TERM_HEADER after including
447 windows.h on WINDOWSNT. This avoids compilation problems with
448 MSVC.
449
f0e5f225
EZ
4502012-10-01 Eli Zaretskii <eliz@gnu.org>
451
2d7d1608
EZ
452 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
453 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
454 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
455 as the previous version used 'void *'.
456
457 * ralloc.c (ROUNDUP): Fix last change.
458 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
459 'size_t'.
460
f0e5f225
EZ
461 * w32proc.c <disable_itimers>: New static flag.
462 (init_timers): Initialize it to zero, after creating the critical
463 sections used by the timer threads.
464 (term_timers): Set to 1 before deleting the critical sections.
465 (getitimer, setitimer): If disable_itimers is non-zero, return an
466 error indication without doing anything. Reported by Fabrice
467 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
468 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
469 return results.
470 [!HAVE_SETITIMER]: Behave as the previous version that didn't
471 support timers.
f0e5f225
EZ
472
473 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
474 term_ntproc after all the other bookkeeping, to get timers working
475 as long as possible.
476
82ef37c1
PE
4772012-10-01 Paul Eggert <eggert@cs.ucla.edu>
478
b3a4c387
PE
479 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
480 Suggested by Juri Linkov in
481 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
482
b0ab8123
PE
483 Prefer plain 'static' to 'static inline' (Bug#12541).
484 With static functions, modern compilers inline pretty well by
485 themselves; advice from programmers often hurts as much as it helps.
486 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
487 this change shrinks the text size of the Emacs executable by 1.1%
488 without affecting CPU significantly in my benchmark.
489 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
490 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
491 (mark_maybe_object, mark_maybe_pointer, bounded_number):
492 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
493 (bset_auto_fill_function, bset_auto_save_file_format)
494 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
495 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
496 (bset_cache_long_line_scans, bset_case_fold_search)
497 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
498 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
499 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
500 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
501 (bset_header_line_format, bset_indicate_buffer_boundaries)
502 (bset_indicate_empty_lines, bset_invisibility_spec)
503 (bset_left_fringe_width, bset_major_mode, bset_mark)
504 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
505 (bset_name, bset_overwrite_mode, bset_pt_marker)
506 (bset_right_fringe_width, bset_save_length)
507 (bset_scroll_bar_width, bset_scroll_down_aggressively)
508 (bset_scroll_up_aggressively, bset_selective_display)
509 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
510 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
511 (set_buffer_overlays_after):
512 * category.c (bset_category_table):
513 * charset.c (read_hex):
514 * coding.c (produce_composition, produce_charset)
515 (handle_composition_annotation, handle_charset_annotation)
516 (char_encodable_p):
517 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
518 (assign_row, set_frame_matrix_frame, make_current)
519 (add_row_entry):
520 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
521 * fns.c (maybe_resize_hash_table):
522 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
523 * gmalloc.c (register_heapinfo):
524 * image.c (lookup_image_type):
525 * intervals.c (set_interval_object, set_interval_left)
526 (set_interval_right, copy_interval_parent, rotate_right)
527 (rotate_left, balance_possible_root_interval):
528 * keyboard.c (kset_echo_string, kset_kbd_queue)
529 (kset_keyboard_translate_table, kset_last_prefix_arg)
530 (kset_last_repeatable_command, kset_local_function_key_map)
531 (kset_overriding_terminal_local_map, kset_real_last_command)
532 (kset_system_key_syms, clear_event, set_prop):
533 * lread.c (digit_to_number):
534 * marker.c (attach_marker, live_buffer, set_marker_internal):
535 * nsterm.m (ns_compute_glyph_string_overhangs):
536 * process.c (pset_buffer, pset_command)
537 (pset_decode_coding_system, pset_decoding_buf)
538 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
539 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
540 (pset_status, pset_tty_name, pset_type, pset_write_queue):
541 * syntax.c (bset_syntax_table, dec_bytepos):
542 * terminal.c (tset_param_alist):
543 * textprop.c (interval_has_some_properties)
544 (interval_has_some_properties_list):
545 * window.c (wset_combination_limit, wset_dedicated)
546 (wset_display_table, wset_hchild, wset_left_fringe_width)
547 (wset_left_margin_cols, wset_new_normal, wset_new_total)
548 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
549 (wset_right_fringe_width, wset_right_margin_cols)
550 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
551 (wset_vertical_scroll_bar_type, wset_window_parameters):
552 * xdisp.c (wset_base_line_number, wset_base_line_pos)
553 (wset_column_number_displayed, wset_region_showing)
554 (window_box_edges, run_window_scroll_functions)
555 (append_glyph_string_lists, prepend_glyph_string_lists)
556 (append_glyph_string, set_glyph_string_background_width)
557 (append_glyph, append_composite_glyph)
558 (take_vertical_position_into_account):
559 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
560 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
561 (lface_hash, lface_same_font_attributes_p, lookup_face):
562 * xml.c (libxml2_loaded_p):
563 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
564 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
565 Now 'static', not 'static inline'.
566
05584c31
PE
567 * bidi.c: Tune.
568 (bidi_copy_it): Do the whole copy with a single memcpy.
569 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
570
86ec63ba
PE
571 Revert the FOLLOW-SYMLINKS change for file-attributes.
572 Doing it right would require several changes to Tramp, and there's
573 not enough time to get that tested before the freeze today.
574 * dired.c (directory_files_internal, Ffile_attributes):
575 Undo last change.
576
82ef37c1
PE
577 * frame.c (x_report_frame_params): Port better to wider ints.
578 Do not assume that EMACS_UINT is the same width as uprintmax_t,
579 or that pointers can be printed in 15 decimal digits.
580 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
581
62aba0d4
FP
5822012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
583
584 Support x64 build on MS-Windows.
585 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
586 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
587 compatibility with x64.
5e4daaf3 588 (x_get_focus_frame): Add prototype.
62aba0d4
FP
589
590 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
591 defining an XRectangle structure.
592
593 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
594 arithmetics for compatibility with x64.
595
596 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
597 compatibility with x64.
598
599 * w32heap.h: Adjust prototypes and declarations.
600
601 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
602 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
603 DWORD, long, and unsigned long, for compatibility with x64.
604 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
605 (sbrk): Argument is now of type ptrdiff_t.
606
607 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
608 less than 0x0500.
609 (w32_msg_pump): Use WPARAM type for 'result'.
610
611 * w32.c (init_environment, get_emacs_configuration): Support AMD64
612 architecture.
613 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
614 compatibility with x64.
615
616 * vm-limit.c (lim_data): Now size_t.
617 (check_memory_limits): Adjust prototypes of real_morecore and
618 __morecore to receive argument of type ptrdiff_t. Use size_t for
619 five_percent and data_size.
620
621 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
622 variables, for compatibility with x64.
623 (rva_to_section, offset_to_section, relocate_offset)
624 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
625 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
626 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
627 for compatibility with x64.
628
629 * sysdep.c (STDERR_FILENO): Define if not already defined.
630
631 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
632 (__morecore): Argument type is now ptrdiff_t.
633 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
634 (relinquish): Use ptrdiff_t type for 'excess'.
635 (r_alloc_sbrk): Argument type is now ptrdiff_t.
636
637 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
638 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
639 instead of a literal number.
640
641 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
642 (min): Define only if not already defined.
643
644 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
645 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
646 hosts.
647
648 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
649 'bitmaps' is a pointer.
650
651 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
652
653 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
654
e7a2937b
PE
6552012-09-30 Paul Eggert <eggert@cs.ucla.edu>
656
657 file-attributes has a new optional arg FOLLOW-SYMLINKS.
658 * dired.c (directory_files_internal, Ffile_attributes):
659 New arg follow_symlinks. All uses changed.
660
b43d62ae
SM
6612012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
662
663 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
664
c06c382a
EZ
6652012-09-30 Eli Zaretskii <eliz@gnu.org>
666
667 Support atimers and CPU profiler via profile.c on MS-Windows.
668 * w32proc.c (sig_mask, crit_sig): New static variables.
669 (sys_signal): Support SIGALRM and SIGPROF.
670 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 671 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
672 sigfillset, and sigprocmask are no longer no-ops.
673 (sigismember): New function.
674 (struct itimer_data): New definition.
675 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
676 (crit_prof): New static variables.
677 (MAX_SINGLE_SLEEP): New definition.
678 (timer_loop, stop_timer_thread, term_timers, init_timers)
679 (start_timer_thread, getitimer, setitimer): New functions.
680 (alarm): No longer a no-op, calls setitimer.
681
682 * w32.c (term_ntproc): Call term_timers.
683 (init_ntproc): Make sure all signals are unblocked at startup, to
684 erase any traces of dumping. Call init_timers.
685
686 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
687 Windows-specific code to display the hourglass mouse pointer is no
688 longer used.
689 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
690 to hourglass timer expiration.
691 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
692 Remove, no longer used.
b43d62ae
SM
693 (w32_note_current_window, show_hourglass, hide_hourglass):
694 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
695 window systems.
696 (syms_of_w32fns): Don't initialize hourglass_timer.
697
698 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
699 WINDOWSNT as well.
700 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
701
702 * w32.h (init_timers, term_timers): Add prototypes.
703
95402d5f
KH
7042012-09-30 Kenichi Handa <handa@gnu.org>
705
706 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
707 to the buffer relocation which may be caused by ccl_driver.
708
dd946752
JD
7092012-09-30 Jan Djärv <jan.h.d@swipnet.se>
710
d7e642cc
JD
711 * xfns.c (Fx_file_dialog): Update comment.
712
713 * w32fns.c (Fx_file_dialog): Update comment.
714
715 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
716 Initialize panel name field if OSX >= 10.6.
717
718 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
719
dd946752
JD
720 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
721
722 * nsterm.m (NEW_STYLE_FS): New define.
723 (ns_fullscreen_hook, windowWillEnterFullScreen)
724 (windowDidEnterFullScreen, windowWillExitFullScreen)
725 (windowDidExitFullScreen, toggleFullScreen, handleFS)
726 (setFSValue): New functions.
727 (EmacsFSWindow): New implementation.
728 (canBecomeKeyWindow): New function for EmacsFSWindow.
729 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
730 (dealloc): Release nonfs_window if in fullscreen.
731 (updateFrameSize:): Call windowDidMove to update top/left.
732 (windowWillResize:toSize:): Check if frame is still maximized.
733 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
734 next_maximized, maximized_width, maximized_height and nonfs_window.
735 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
736 tbar_height.
737 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
738 fullscreen. Set maximized_width/height. Act on next_maximized.
739
740 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
741 (EmacsView): Add variables for fullscreen.
742 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
743 (EmacsFSWindow): New interface for fullscreen.
744
427730eb
JB
7452012-09-30 Juanma Barranquero <lekktu@gmail.com>
746
747 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
748
48de8b12
CY
7492012-09-30 Chong Yidong <cyd@gnu.org>
750
751 * fns.c (Frandom): Doc fix.
752
5938d519
MR
7532012-09-30 Martin Rudalics <rudalics@gmx.at>
754
755 * window.c (Vwindow_combination_limit): New default value.
756 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
757
cb5b0266
PE
7582012-09-30 Paul Eggert <eggert@cs.ucla.edu>
759
760 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
761 Suggested by Eli Zaretskii in
762 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
763
84f72efd
EZ
7642012-09-30 Eli Zaretskii <eliz@gnu.org>
765
766 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
767 HAVE_TIMER_SETTIME is defined.
768
9d4dcdc9
PE
7692012-09-30 Paul Eggert <eggert@cs.ucla.edu>
770
d89460ed
PE
771 Profiler improvements: more-accurate timers, overflow checks.
772 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
773 signal.h, setjmp.h. Include systime.h instead.
774 (saturated_add): New function.
775 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
776 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
777 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
778 New static vars.
84f72efd 779 (enum profiler_cpu_running): New enum.
d89460ed
PE
780 (profiler_cpu_running): Now of that enum type, not bool.
781 All uses changed to store the new value.
782 (handle_profiler_signal): Rename from sigprof_handler_1,
783 for consistency with other handlers. Do not check whether
784 cpu_log is a hash-table if garbage collecting, since it
785 doesn't matter in that case.
786 (deliver_profiler_signal): Rename from sigprof_handler,
787 for consistency with other handlers.
788 (setup_cpu_timer): New function, with much of what used to be in
789 Fprofiler_cpu_start. Check for out-of-range argument.
790 Prefer timer_settime if available, and prefer
791 thread cputime clocks, then process cputime clocks, then
792 monotonic clocks, to the old realtime clock. Use make_timeval
793 to round more-correctly when falling back to setitimer.
794 (Fprofiler_cpu_start): Use it.
795 (Fprofiler_cpu_stop): Prefer timer_settime if available.
796 Don't assume that passing NULL as the 2nd argument of setitimer
797 is the same as passing a pointer to all-zero storage.
798 Ignore SIGPROF afterwards.
799 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
800 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
801 non-fatal signal handlers. Ignore SIGPROF on startup.
802 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
803 in profiler.c, since sysdep.c now uses it.
804
9d4dcdc9
PE
805 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
806 Suggested by Eli Zaretskii in
807 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
808
8e5691a0
JB
8092012-09-29 Juanma Barranquero <lekktu@gmail.com>
810
811 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
812
e7c1b6ef
SM
8132012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
814
815 * lisp.h (struct backtrace): Remove indirection for `function' field.
816 * xdisp.c (redisplay_internal):
817 * profiler.c (record_backtrace, sigprof_handler_1):
818 * alloc.c (Fgarbage_collect):
819 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
820 (Fbacktrace_frame): Adjust accordingly.
821
e61d39cd 8222012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
823
824 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
825 (Frun_hook_with_args_until_failure): Doc fixes.
826
404043ea
EZ
8272012-09-28 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
830 Qautomatic_redisplay and change the symbol name. All users changed.
831
704d3f45
TM
8322012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
833
834 * profiler.c (sigprof_handler): Fix race condition.
835
757140ff
GM
8362012-09-28 Glenn Morris <rgm@gnu.org>
837
838 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
839
a615a3ae
PE
8402012-09-27 Paul Eggert <eggert@cs.ucla.edu>
841
842 Check more robustly for timer_settime.
89d17fd0
PE
843 * Makefile.in (LIB_TIMER_TIME): New macro.
844 (LIBES): Add it.
a615a3ae
PE
845 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
846 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
847 call timer_settime.
848
3670daf7
TM
8492012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
850
851 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
852
6a586b7f
JB
8532012-09-26 Juanma Barranquero <lekktu@gmail.com>
854
855 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
856
41c8bfcf
PE
8572012-09-26 Paul Eggert <eggert@cs.ucla.edu>
858
859 * character.h (MAYBE_UNIFY_CHAR): Remove.
860 * charset.c, charset.h (maybe_unify_char): Now static.
861 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
862 Since this stuff is now private to charset.c, there's no need for
863 a public macro and no need to inline by hand.
864
3a880af4
SM
8652012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
866 Stefan Monnier <monnier@iro.umontreal.ca>
867 Juanma Barranquero <lekktu@gmail.com>
611b7507 868
3a880af4
SM
869 * profiler.c: New file.
870 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
871 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
872 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
873 * emacs.c (main): Call syms_of_profiler.
874 * alloc.c (Qautomatic_gc): New constant.
875 (MALLOC_PROBE): New macro.
876 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
877 (total_bytes_of_live_objects): New function.
878 (Fgarbage_collect): Use it. Record itself in backtrace_list.
879 Call malloc_probe for the memory profiler.
880 (syms_of_alloc): Define Qautomatic_gc.
881 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
882 race condition.
883 (struct backtrace): Move definition...
884 * lisp.h (struct backtrace): ..here.
885 (Qautomatic_gc, profiler_memory_running): Declare vars.
886 (malloc_probe, syms_of_profiler): Declare functions.
887 * xdisp.c (Qautomatic_redisplay): New constant.
888 (redisplay_internal): Record itself in backtrace_list.
889 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 890
5938d519 8912012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
8922012-09-25 Juanma Barranquero <lekktu@gmail.com>
893
894 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
895
e26fd2e4
PE
8962012-09-25 Paul Eggert <eggert@cs.ucla.edu>
897
898 Prefer POSIX timers if available.
899 They avoid a race if the timer is too close to the current time.
900 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
901 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 902 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 903
eedec3ee
EZ
9042012-09-25 Eli Zaretskii <eliz@gnu.org>
905
906 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
907 CHAR_STRING_ADVANCE.
908 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
909 STRING_CHAR_ADVANCE.
910
aa15c6bb
JB
9112012-09-25 Juanma Barranquero <lekktu@gmail.com>
912
913 Move Vlibrary_cache to emacs.c and reset before dumping.
914
915 * lisp.h (reset_image_types): Declare.
916 [WINDOWSNT] (Vlibrary_cache): Declare.
917
918 * image.c (reset_image_types): New function.
919
920 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
921 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
922 (Fdump_emacs): Reset Vlibrary_cache and image_types.
923
924 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
925 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
926
927 * w32.h (Vlibrary_cache): Do not declare.
928
54d629be
EZ
9292012-09-25 Eli Zaretskii <eliz@gnu.org>
930
16b22fef
EZ
931 * w32proc.c (sys_signal): Handle all signals defined by the
932 MS-Windows runtime, not just SIGCHLD. Actually install the signal
933 handlers for signals supported by Windows. Don't override
934 term_ntproc as the handler for SIGABRT.
935 (sigaction): Rewrite to call sys_signal instead of duplicating its
936 code.
937 (sys_kill): Improve commentary.
938
939 * w32.c (term_ntproc): Accept (and ignore) one argument, for
940 consistency with a signature of a signal handler. All callers
941 changed.
942 (init_ntproc): Accept an argument DUMPING. If dumping, don't
943 install term_ntproc as a signal handler for SIGABRT, as that
944 should be done by the dumped Emacs.
945
946 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
947
948 * w32select.c (term_w32select): Protect against repeated
949 invocation by setting clipboard_owner to NULL after calling
950 DestroyWindow.
951
952 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
953 and term_ntproc to their modified signatures.
954
54d629be
EZ
955 * character.c (char_string, string_char): Remove calls to
956 MAYBE_UNIFY_CHAR. See the discussion starting at
957 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
958 for the details.
959
59f7af81
CY
9602012-09-25 Chong Yidong <cyd@gnu.org>
961
962 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
963
22e8cf4a
SM
9642012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
965
966 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
967 when encountering an unknown bytecode.
968
578098f3
PE
9692012-09-24 Paul Eggert <eggert@cs.ucla.edu>
970
971 image.c, indent.c: Use bool for booleans.
972 * dispextern.h (struct image_type): Members valid_p, load, init
973 now return bool, not int. All uses changed.
974 * image.c: Omit unnecessary static decls.
975 (x_create_bitmap_mask, x_build_heuristic_mask):
976 Return void, not int, since callers don't care about the return value.
977 (x_create_bitmap_mask, define_image_type, valid_image_p)
978 (struct image_keyword, parse_image_spec, image_spec_value)
979 (check_image_size, image_background)
980 (image_background_transparent, x_clear_image_1)
981 (postprocess_image, lookup_image, x_check_image_size)
982 (x_create_x_image_and_pixmap, xbm_image_p)
983 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
984 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
985 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
986 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
987 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
988 (png_image_p, init_png_functions, png_load_body, png_load)
989 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
990 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
991 (init_gif_functions, gif_load, imagemagick_image_p)
992 (imagemagick_load_image, imagemagick_load, svg_image_p)
993 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
994 (gs_load):
995 * nsimage.m (ns_load_image):
996 * nsterm.m (ns_defined_color):
997 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
998 * xfns.c (x_defined_color):
999 * xterm.c (x_alloc_lighter_color_for_widget)
1000 (x_alloc_nearest_color_1, x_alloc_nearest_color)
1001 (x_alloc_lighter_color):
1002 * indent.c (disptab_matches_widthtab, current_column)
1003 (scan_for_column, string_display_width, indented_beyond_p)
1004 (compute_motion, vmotion, Fvertical_motion):
1005 Use bool for booleans.
1006
a5f2b6ec
CY
10072012-09-24 Chong Yidong <cyd@gnu.org>
1008
1009 * chartab.c (Fset_char_table_default): Obsolete function removed.
1010
18e27ea8
PE
10112012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1012
afea8a8a
PE
1013 Move pid_t related decls out of lisp.h.
1014 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
1015 (interruptible_wait_for_termination):
1016 Move these decls from lisp.h to syswait.h, since they use pid_t.
1017 Needed on FreeBSD; see Herbert J. Skuhra in
1018 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
1019 * callproc.c: Include syswait.h.
1020
18e27ea8
PE
1021 gnutls.c, gtkutil.c: Use bool for boolean.
1022 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
1023 (emacs_gnutls_handle_error):
1024 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
1025 (xg_hide_tooltip, xg_create_frame_widgets)
1026 (create_dialog, xg_uses_old_file_dialog)
1027 (xg_get_file_with_chooser, xg_get_file_with_selection)
1028 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
1029 (xg_item_label_same_p, xg_update_menubar)
1030 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
1031 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
1032 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
1033 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
1034 (update_frame_tool_bar, free_frame_tool_bar):
1035 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
1036 * nsmenu.m (ns_update_menubar):
1037 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
1038 * xfns.c (Fx_show_tip) [USE_GTK]:
1039 Use bool for boolean.
1040 * gtkutil.c (xg_update_frame_menubar):
1041 * xmenu.c (update_frame_menubar):
1042 Return void, not int, since caller ignores return value.
1043 * gtkutil.c (xg_change_toolbar_position):
1044 Return void, not 1.
1045
af0e9f75
JB
10462012-09-23 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * makefile.w32-in (BLOCKINPUT_H): Remove.
1049 (SYSSIGNAL_H): New macro.
1050 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
1051 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
1052 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
1053 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
1054 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
1055 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
1056 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
1057 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
1058 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
1059 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
1060 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
1061 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
1062 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
1063 ($(BLD)/w32xfns.$(O)): Update dependencies.
1064
5101529e
EZ
10652012-09-23 Eli Zaretskii <eliz@gnu.org>
1066
1067 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
1068 fatal_error_backtrace.
1069
1070 * w32proc.c (sys_kill): Undo last change: don't do anything when
1071 invoked to deliver SIGABRT to our own process. This is now
1072 handled by emacs_raise.
1073
2c3ee0ad
JB
10742012-09-23 Juanma Barranquero <lekktu@gmail.com>
1075
1076 * w32term.c (w32_read_socket): Remove leftover reference to
1077 interrupt_input_pending.
1078
62a1d661
PE
10792012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Do not use SA_NODEFER.
1082 Problem reported by Dani Moncayo in
1083 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
1084 * alloc.c (die):
1085 * sysdep.c (emacs_abort): Do not reset signal handler.
1086 * emacs.c (terminate_due_to_signal): Reset signal handler here.
1087 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
1088 wanted even on POSIXish hosts, and it doesn't work on Windows.
1089
a0942b9a
JD
10902012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1091
1092 * xterm.c (x_term_init): Call fixup_locale before and after calling
1093 gtk_init (Bug#12392).
1094
d07ff9db
CY
10952012-09-23 Chong Yidong <cyd@gnu.org>
1096
1097 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
1098 Vdynamic_library_alist.
1099
1100 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
1101 (Fgnutls_available_p): Caller changed.
1102
1103 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
1104 (Flibxml_parse_xml_region): Likewise.
1105
1106 * dispextern.h (struct image_type): Remove arg from init function.
1107
1108 * image.c (Finit_image_library, lookup_image_type)
1109 (define_image_type): Remove now-unneeded second arg.
1110 (init_xpm_functions, init_png_functions, init_jpeg_functions)
1111 (init_tiff_functions, init_gif_functions, init_svg_functions):
1112 Arglist and w32_delayed_load calling convention changed.
1113 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 1114 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 1115
4d7e6e51
PE
11162012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 Simplify and avoid signal-handling races (Bug#12471).
1119 * alloc.c (die):
1120 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
1121 Avoid recursive loop if there's a fatal error in the function itself.
1122 * atimer.c (pending_atimers):
1123 * blockinput.h: Don't include "atimer.h"; no longer needed.
1124 (interrupt_input_pending): Remove. All uses removed.
1125 pending_signals now counts both atimers and ordinary interrupts.
1126 This is less racy than having three separate pending-signal flags.
1127 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
1128 (input_blocked_p):
1129 Rename from their upper-case counterparts BLOCK_INPUT,
1130 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
1131 INPUT_BLOCKED_P, and turn into functions. All uses changed.
1132 This makes it easier to access volatile variables more accurately.
1133 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
1134 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
1135 that's more reliable if the code is buggy and sets
1136 interrupt_input_blocked to a negative value. All uses changed.
1137 * atimer.c (deliver_alarm_signal):
1138 Remove. No need to deliver this to the parent; any thread can
1139 handle this signal now. All uses replaced by underlying handler.
1140 * atimer.c (turn_on_atimers):
1141 * dispnew.c (handle_window_change_signal):
1142 * emacs.c (handle_danger_signal):
1143 * keyboard.c (kbd_buffer_get_event):
1144 Don't reestablish signal handler; not needed with sigaction.
1145 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
1146 (UNBLOCK_INPUT_TO):
1147 Rework to avoid unnecessary accesses to volatile variables.
1148 (UNBLOCK_INPUT_TO): Now a function.
1149 (totally_unblock_input, unblock_input): New decls.
1150 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
1151 (init_data): Remove. Necessary stuff now done in init_signal.
1152 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
1153 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
1154 (fatal_error_code): Remove; no longer needed.
1155 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
1156 it doesn't always backtrace. All uses changed. No need to reset
1157 signal to default, since sigaction and/or die does that for us now.
1158 Use emacs_raise (FOO), not kill (getpid (), FOO).
1159 (main): Check more-accurately whether we're dumping.
1160 Move fatal-error setup to sysdep.c
1161 * floatfns.c: Do not include "syssignal.h"; no longer needed.
1162 * gtkutil.c (xg_get_file_name, xg_get_font):
1163 Remove no-longer-needed signal-mask manipulation.
1164 * keyboard.c, process.c (POLL_FOR_INPUT):
1165 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
1166 * keyboard.c (read_avail_input): Remove.
1167 All uses replaced by gobble_input.
1168 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
1169 (kbd_buffer_store_event_hold, gobble_input):
1170 (record_asynch_buffer_change) [USABLE_SIGIO]:
1171 (store_user_signal_events):
1172 No need to mess with signal mask.
1173 (gobble_input): If blocking input and there are terminals, simply
1174 set pending_signals to 1 and return. All hooks changed to not
1175 worry about whether input is blocked.
1176 (process_pending_signals): Clear pending_signals before processing
1177 them, in case a signal comes in while we're processing.
1178 By convention callers now test pending_signals before calling us.
1179 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
1180 New functions, to support changes to blockinput.h.
1181 (handle_input_available_signal): Now extern.
1182 (reinvoke_input_signal): Remove. All uses replaced by
1183 handle_async_input.
1184 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
1185 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
1186 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
1187 Clear sigmask reliably, even if Fsignal returns, which it can.
1188 Omit unnecessary accesses to volatile var.
1189 (quit_throw_to_read_char): No need to restore sigmask.
1190 * keyboard.c (gobble_input, handle_user_signal):
1191 * process.c (wait_reading_process_output):
1192 Call signal-handling code rather than killing ourselves.
1193 * lisp.h: Include <float.h>, for...
1194 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
1195 (pending_signals): Now volatile.
1196 (syms_of_data): Now const if IEEE floating point.
1197 (handle_input_available_signal) [USABLE_SIGIO]:
1198 (terminate_due_to_signal, record_child_status_change): New decls.
1199 * process.c (create_process): Avoid disaster if memory is exhausted
1200 while we're processing a vfork, by tightening the critical section
1201 around the vfork.
1202 (send_process_frame, process_sent_to, handle_pipe_signal)
1203 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
1204 ignores SIGPIPE.
1205 (send_process): No need for setjmp/longjmp any more, since the
1206 SIGPIPE stuff is now gone. Instead, report an error if errno
1207 is EPIPE.
1208 (record_child_status_change): Now extern. PID and W are now args.
1209 Return void, not bool. All callers changed.
1210 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
1211 Remove. All uses removed. This bug should be fixed now in a
1212 different way.
1213 (wait_for_termination_1): Use waitpid rather than sigsuspend,
1214 and record the child status change directly. This avoids the
1215 need to futz with the signal mask.
1216 (process_fatal_action): Move here from emacs.c.
1217 (emacs_sigaction_flags): New function, containing
1218 much of what used to be in emacs_sigaction_init.
1219 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
1220 caught by emacs, to make races less likely.
1221 (deliver_process_signal): Rename from handle_on_main_thread.
1222 All uses changed.
1223 (BACKTRACE_LIMIT_MAX): Now at top level.
1224 (thread_backtrace_buffer, threadback_backtrace_pointers):
1225 New static vars.
1226 (deliver_thread_signal, deliver_fatal_thread_signal):
1227 New functions, for more-accurate delivery of thread-specific signals.
1228 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
1229 (deliver_arith_signal): Handle in this thread, not
1230 in the main thread, since it's triggered by this thread.
1231 (maybe_fatal_sig): New function.
1232 (init_signals): New arg DUMPING so that we can be more accurate
1233 about whether we're dumping. Caller changed.
1234 Treat thread-specific signals differently from process-general signals.
1235 Block all signals while handling fatal error; that's safer.
1236 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
1237 on IEEE hosts.
1238 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
1239 Ignore SIGPIPE unless batch.
1240 (emacs_backtrace): Output backtrace for the appropriate thread,
1241 which is not necessarily the main thread.
1242 * syssignal.h: Include <stdbool.h>.
1243 (emacs_raise): New macro.
1244 * xterm.c (x_connection_signal): Remove; no longer needed
1245 now that we use sigaction.
1246 (x_connection_closed): No need to mess with sigmask now.
1247 (x_initialize): No need to reset SIGPIPE handler here, since
1248 init_signals does this for us now.
1249
8f4635e9
JD
12502012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1251
1252 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 1253 background rect may be larger (Bug#12245).
8f4635e9 1254
3296976d
CY
12552012-09-23 Chong Yidong <cyd@gnu.org>
1256
1257 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
1258
d41e491e
PE
12592012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * .gdbinit: Just stop at fatal_error_backtrace.
1262 See Stefan Monnier's request in
1263 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
1264 Remove no-longer-used query of system type.
1265
c88b867f
CY
12662012-09-22 Chong Yidong <cyd@gnu.org>
1267
1268 * search.c (Freplace_match): Doc fix (Bug#12325).
1269
1270 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
1271
1272 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
1273 (Fline_end_position): Doc fix.
1274
1275 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
1276
bb4d86b4
CY
12772012-09-22 Chong Yidong <cyd@gnu.org>
1278
1279 * dispextern.h (struct image_type): Add new slot, storing a type
1280 initialization function.
1281
1282 * image.c (define_image_type): Call the image initializer function
1283 if it is defined. Arguments and return value changed.
1284 (valid_image_p, make_image): Callers changed.
1285 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
1286 (gif_type, imagemagick_type, svg_type, gs_type):
1287 Add initialization functions.
bb4d86b4
CY
1288 (Finit_image_library): Call lookup_image_type.
1289 (CHECK_LIB_AVAILABLE): Macro deleted.
1290 (lookup_image_type): Call define_image_type here, rather than via
1291 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
1292 (syms_of_image): Move define_image_type calls for xbm_type and
1293 pbm_type to lookup_image_type.
1294
df9685f3
EZ
12952012-09-22 Eli Zaretskii <eliz@gnu.org>
1296
1297 * keyboard.c (timer_check_2): Move calculation of 'timers' and
1298 'idle_timers' from here ...
1299 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
1300 lists, to avoid infloops when the timer does something stupid,
1301 like reinvoke itself with the same or smaller time-out.
1302 (Bug#12447)
1303
8e17c9ba
MR
13042012-09-22 Martin Rudalics <rudalics@gmx.at>
1305
1306 * window.c (Fsplit_window_internal): Handle only Qt value of
1307 Vwindow_combination_limit separately.
1308 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
1309 (Vwindow_combination_limit): New default value.
1310 Rewrite doc-string.
8e17c9ba 1311
589bd69b
EZ
13122012-09-22 Eli Zaretskii <eliz@gnu.org>
1313
1314 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
1315 the new overlay string. (Bug#10159)
1316
01108e3f
PE
13172012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
1320 or that fprintf is async-signal-safe. POSIX doesn't require
1321 either assumption.
1322
82f8cd94
CY
13232012-09-22 Chong Yidong <cyd@gnu.org>
1324
1325 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
1326 (Bug#8207).
1327
3cccbd87
KH
13282012-09-22 Kenichi Handa <handa@gnu.org>
1329
1330 * composite.c (composition_reseat_it): Handle the case that a
1331 grapheme cluster is not covered by a single font (Bug#12352).
1332
09c01941
CY
13332012-09-21 Chong Yidong <cyd@gnu.org>
1334
1335 * image.c (define_image_type): Avoid adding duplicate types to
1336 image_types (Bug#12463). Suggested by Jörg Walter.
1337
acfa068f 13382012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
1339
1340 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
1341 (print_load_command_name): Add case LC_DATA_IN_CODE.
1342 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
1343
acfa068f 13442012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
1345
1346 * eval.c (Frun_hook_with_args_until_success)
1347 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
1348
acfa068f 13492012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
1350
1351 * fileio.c (Ffile_selinux_context): Only call freecon when
1352 lgetfilecon succeeded.
1353 (Fset_file_selinux_context): Likewise. (Bug#12444)
1354
acfa068f 13552012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
1356
1357 * xdisp.c (try_window_reusing_current_matrix): Under bidi
1358 reordering, locate the cursor by calling set_cursor_from_row; if
1359 that fails, clear the desired glyph matrix before returning a
1360 failure indication to the caller. Fixes leaving garbled display
1361 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
1362 (compute_stop_pos_backwards): Fix a typo that caused crashes while
1363 scrolling through multibyte text.
aa36e4d2 1364
e99f70c8
SM
13652012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
1368 calling mark_vectorlike since that's the one that marks the window.
1369 (mark_discard_killed_buffers): Mark the final cdr.
1370 * window.h (struct window): Move prev/next_buffers to the
1371 non-standard fields.
1372 * window.c (make_window): Initialize prev/next_buffers manually.
1373
f75beb47
PE
13742012-09-20 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Omit unused arg EXPECTED from socket hooks.
1377 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
1378 * nsterm.m (ns_term_init):
1379 * termhooks.h (struct terminal.read_socket_hook):
1380 * w32inevt.c (w32_console_read_socket):
1381 * w32term.c (w32_read_socket):
1382 * xterm.c (XTread_socket):
1383 Omit unused arg EXPECTED. All callers changed.
1384 (store_user_signal_events): Return void, not int, since callers no
1385 longer care about the return value. All uses changed.
1386
b019b76a
JB
13872012-09-20 Juanma Barranquero <lekktu@gmail.com>
1388
1389 * w32gui.h (XParseGeometry): Do not declare.
1390
05642592
PE
13912012-09-19 Paul Eggert <eggert@cs.ucla.edu>
1392
e4bce92a
PE
1393 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1394 Ignore 'expected'. See Eli Zaretskii in
1395 <http://bugs.gnu.org/12471#8> (last line).
1396
05642592
PE
1397 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
1398 (XParseGeometry): Now static. Substitute extremal values for
1399 values that are out of range.
1400
e543ae91
JD
14012012-09-19 Jan Djärv <jan.h.d@swipnet.se>
1402
1403 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
1404
1405 * nsfns.m (XParseGeometry): Remove.
1406 (Fx_create_frame): Call x_set_offset to correctly interpret
1407 top_pos in geometry.
1408
3a880af4 1409 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
1410 (Fx_parse_geometry): If there is a space in string, call
1411 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
1412
45ba16c7
EZ
14132012-09-17 Eli Zaretskii <eliz@gnu.org>
1414
c8b9f1bc
EZ
1415 * search.c (scan_buffer): Use character positions in calls to
1416 region_cache_forward and region_cache_backward, not byte
1417 positions. (Bug#12196)
1418
b4c932a2
EZ
1419 * w32term.c (w32_read_socket): Set pending_signals to 1, like
1420 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
1421
45ba16c7
EZ
1422 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
1423 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
1424 emacs_blocked_malloc, now deleted.
1425
eeceac93
PE
14262012-09-17 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
1429 The workaround was for improving performance on Solaris 2.4, but
1430 is getting in the way now. Emacs will still work if someone is
1431 still running Solaris 2.4 in a museum somewhere; Sun dropped
1432 support for Solaris 2.4 in 2003.
1433 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
1434 * process.c (create_process) [HAVE_WORKING_VFORK]:
1435 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
1436 since Emacs no longer uses vfork on that platform.
1437
78f83752
GM
14382012-09-17 Glenn Morris <rgm@gnu.org>
1439
1440 * emacs.c: Use COPYRIGHT.
1441
634b8cac
PE
14422012-09-16 Paul Eggert <eggert@cs.ucla.edu>
1443
0caaedb1
PE
1444 Remove configure's --without-sync-input option (Bug#12450).
1445 When auditing signal-handling in preparation for cleaning it up,
1446 I found that SYNC_INPUT has race conditions and would be a real
1447 pain to fix. Since it's an undocumented and deprecated
1448 configure-time option, now seems like a good time to remove it.
1449 Also see <http://bugs.gnu.org/11080#16>.
1450 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
1451 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
1452 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1453 (malloc_hysteresis):
1454 (check_depth) [XMALLOC_OVERRUN_CHECK]:
1455 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
1456 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
1457 (dont_register_blocks, bytes_used_when_reconsidered)
1458 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
1459 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
1460 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1461 Remove. All uses removed.
1462 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
1463 implementation, one that depends on whether the new macro
1464 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
1465 is defined.
1466 * atimer.c (run_timers, handle_alarm_signal):
1467 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
1468 (handle_async_input, process_pending_signals)
1469 (handle_input_available_signal, init_keyboard):
1470 * nsterm.m (ns_read_socket):
1471 * process.c (wait_reading_process_output):
1472 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
1473 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
1474 (emacs_write):
1475 * xterm.c (XTread_socket):
1476 Assume SYNC_INPUT.
1477 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
1478 * eval.c (handling_signal): Remove. All uses removed.
1479 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
1480 All uses replaced with the SYNC_INPUT version.
1481 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
1482 Remove decls.
1483 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1484 Now static.
1485
634b8cac
PE
1486 * font.c (Ffont_shape_gstring): Remove unused local.
1487
83da1b55
GM
14882012-09-16 Glenn Morris <rgm@gnu.org>
1489
518650a5
GM
1490 * Makefile.in (clean): No longer run nextstep's clean.
1491
83da1b55
GM
1492 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
1493 (ns_frag): Remove.
1494 (ns-app): Move here from ns.mk, and simplify.
1495 (clean): Simplify nextstep entry.
1496 * ns.mk: Remove file.
1497
85a43e2e
KH
14982012-09-17 Kenichi Handa <handa@gnu.org>
1499
1500 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
1501 not covert the last few charactes.
1502
ba13e616 15032012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
1504
1505 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
1506 here, but just check the validity of glyphs in the glyph-string.
1507
a8c729af
MR
15082012-09-16 Martin Rudalics <rudalics@gmx.at>
1509
3a880af4
SM
1510 * window.c (Fwindow_parameter, Fset_window_parameter):
1511 Accept any window as argument (Bug#12452).
a8c729af 1512
c077c059
JD
15132012-09-16 Jan Djärv <jan.h.d@swipnet.se>
1514
1515 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
1516 to ns_term_init to avoid memory leak.
1517
1518 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
1519 explicit retain/release.
1520 (ns_term_init): Only allow one display. Initialize outerpool and
1521 ns_*_types.
1522
39a57ad0
PE
15232012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 Port _setjmp fix to POSIXish hosts as well as Microsoft.
1526 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
1527 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
1528 the Microsoft problem in a different way, by altering ../nt/config.nt.
1529
7105c8cb
EZ
15302012-09-15 Eli Zaretskii <eliz@gnu.org>
1531
1532 * w32xfns.c:
1533 * w32uniscribe.c:
1534 * w32term.c:
1535 * w32select.c:
1536 * w32reg.c:
1537 * w32proc.c:
1538 * w32menu.c:
1539 * w32inevt.c:
1540 * w32heap.c:
1541 * w32font.c:
1542 * w32fns.c:
1543 * w32console.c:
1544 * w32.c:
1545 * w16select.c: Remove inclusion of setjmp.h, as it is now included
1546 by lisp.h. This completes removal of setjmp.h inclusion
1547 erroneously announced in the previous commit. (Bug#12446)
1548
1549 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
1550 more accurate.
1551
1552 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
1553 not defined as a macro. The latter happens on MS-Windows.
1554 (Bug#12446)
1555
0328b6de
PE
15562012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 Port better to POSIX hosts lacking _setjmp (Bug#12446).
1559 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 1560 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
1561 only reason for the instance was because "lisp.h" was included.
1562 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
1563 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
1564 and _longjmp with the new symbols. Emacs already uses _setjmp if
1565 available, so this change affects only POSIXish hosts that have
1566 sigsetjmp but not _setjmp, such as some versions of Solaris and
1567 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
1568 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
1569 (png_load_body) [HAVE_PNG]:
1570 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
1571 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
1572 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
1573 since PNG requires jmp_buf. This is the only exception to the
1574 general rule that we now use sys_setjmp and sys_longjmp.
1575 This exception is OK since this code does not change the signal
1576 mask or longjmp out of a signal handler.
1577
2af03429
PE
15782012-09-14 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1581 Include "syssignal.h", for 'main_thread'.
1582
2f294edf
DA
15832012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
1584
1585 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
1586 * insdel.c (replace_range, replace_range_2):
1587 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
1588 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
1589 Remove redundant check before calling offset_intervals.
1590
6b533e9c
MR
15912012-09-14 Martin Rudalics <rudalics@gmx.at>
1592
1593 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
1594 current buffer (Bug#12387).
1595
2a7931e3
JB
15962012-09-14 Juanma Barranquero <lekktu@gmail.com>
1597
1598 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
1599
c18e885b
PE
16002012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Use a more backwards-compatible timer format (Bug#12430).
1603 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
1604 vector element, not from the 4th, since PSECS is now at the end.
1605 (Fcurrent_idle_time): Doc fix.
1606
d59a1afb
DA
16072012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 Function to mark objects and remove killed buffers at once.
1610 * alloc.c (discard_killed_buffers): Rename to ...
1611 (mark_discard_killed buffers) ... new name. Add marking
1612 of remaining objects. Fix comment. Adjust users.
1613 (mark_object): Do not touch frame buffer lists here.
1614 * frame.c (delete_frame): Reset frame buffer lists here.
1615
5f0cb45a
PE
16162012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1617
8ea47e3a
PE
1618 Better workaround for GNOME bug when --enable-gcc-warnings.
1619 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
1620 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
1621 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
1622
4a4bbad2
PE
1623 Simplify SIGIO usage (Bug#12408).
1624 The code that dealt with SIGIO was crufty and confusing, e.g., it
1625 played tricks like "#undef SIGIO" but these tricks were not used
1626 consistently. Simplify mostly by not #undeffing standard symbols,
1627 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
1628 or not as we please) rather than "defined SIGIO" (standard symbol
1629 that we probably shouldn't #undef).
1630 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
1631 Modules that need it can include it.
1632 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
1633 * dispextern.h (ignore_sigio): New decl.
1634 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
1635 unconditionally, since it's now a no-op if !USABLE_SIGIO.
1636 * emacs.c (shut_down_emacs):
1637 * keyboard.c (kbd_buffer_store_event_hold):
1638 Use ignore_sigio rather than invoking 'signal' directly.
1639 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
1640 for FIONREAD.
1641 (FIONREAD, SIGIO): Do not #undef.
1642 (tty_read_avail_input): Use #error rather than a syntax error.
1643 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
1644 for I_PIPE, used by SETUP_SLAVE_PTY.
1645 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
1646 * sysdep.c (croak): Remove; no longer needed. This bit of
1647 temporary code, with Fred N. Fish's comment that it's temporary,
1648 has been in Emacs since at least 1992!
1649 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
1650 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
1651 * syssignal.h (croak): Remove decl.
1652 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
1653 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
1654 now that we're termios-only.
1655 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
1656 * term.c (dissociate_if_controlling_tty): Use #error rather than
1657 a run-time error.
1658
5f0cb45a
PE
1659 Work around GCC and GNOME bugs when --enable-gcc-warnings.
1660 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
1661 to work around GNOME bug 683906.
1662 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
1663 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
1664 This works around GCC bug 54561.
1665
40bce90b
PE
16662012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1667
1668 More fixes for 'volatile' and setjmp/longjmp.
1669 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
1670 * image.c (struct png_load_context) [HAVE_PNG]: New type.
1671 (png_load_body) [HAVE_PNG]:
1672 (jpeg_load_body) [HAVE_JPEG]:
1673 New function, with most of the old parent function's body.
1674 (png_load) [HAVE_PNG]:
1675 (jpeg_load) [HAVE_JPEG]:
1676 Invoke the new function, to avoid longjmp munging our locals.
1677 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
1678 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
1679 longjmp is passed 2, as the C standard doesn't guarantee this.
1680 Instead, store the failure code into mgr->failure_code.
1681
bfeae2cf
SM
16822012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1683
1684 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
1685 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
1686 (syms_of_keyboard): Remove support for unread-command-char.
1687
8099e36b
EZ
16882012-09-12 Eli Zaretskii <eliz@gnu.org>
1689
1690 * w32proc.c (sys_kill): If PID is our process ID and the signal is
1691 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
1692 violation. (Bug#12426)
1693
92547ff9
PE
16942012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
1697
45b82ad0
SM
16982012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1699
1700 * eval.c: Add `inhibit-debugger'.
1701 (Qinhibit_debugger): New symbol.
1702 (call_debugger): Bind it instead of Qdebug_on_error.
1703 (maybe_call_debugger): Test Vinhibit_debugger.
1704 (syms_of_eval): Define inhibit-debugger.
1705 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
1706 (syms_of_xdisp): Remove inhibit-debug-on-message.
1707
5779a1dc
PE
17082012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1709
50f2e553
PE
1710 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
1711 If a nonvolatile local variable is written before a _longjmp to
1712 the frame containing the variable, and is read after the _longjmp,
1713 the value read is indeterminate. Some local variables of type
1714 'struct handler' and 'struct catchtag' are used in this way, so
1715 mark each of their slots as volatile if the slot can be set before
1716 _longjmp and read afterwards.
1717 * lisp.h (struct handler): var and chosen_clause are now volatile.
1718 (struct catchtag): val, next, and pdlcount are now volatile.
1719
ae1d87e2
PE
1720 * bidi.c (bidi_push_it, bidi_pop_it):
1721 * fns.c (copy_hash_table):
1722 * image.c (define_image_type):
1723 * keyboard.c (kbd_buffer_store_event_hold):
1724 * process.c (Fprocess_send_eof):
1725 * xfaces.c (x_create_gc) [HAVE_NS]:
1726 * xgselect.c (xg_select):
1727 Prefer assignment to memcpy when either will do.
1728
5779a1dc
PE
1729 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
1730 Use pointer-to-a-pointer to simplify and avoid a NILP check each
1731 time an item is removed. No need to mark this function 'inline';
1732 the compiler knows better than we do.
1733
c4c9756b
JD
17342012-09-11 Jan Djärv <jan.h.d@swipnet.se>
1735
1736 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
1737 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
1738 to change_frame_size (Bug#12388).
1739 (windowDidResize:): Pass YES to updateFrameSize.
1740
1741 * nsterm.h: Add delay parameter to updateFrameSize.
1742
d73e321c
DA
17432012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1744
1745 Discard killed buffers from deleted window and frame objects.
1746 This reduces an amount of references to killed buffers and
1747 helps GC to reclaim them faster.
1748 * alloc.c (discard_killed_buffers): New function.
1749 (mark_object): Use it for deleted windows and frames.
1750 (mark_object): If symbol's value is set up for a killed buffer
1751 or deleted frame, restore it's global binding.
1752 * data.c (swap_in_global_binding): Add GC notice.
1753 (swap_in_symval_forwarding): Use convenient set_blv_where.
1754 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1755 * window.h: ... to here.
1756
e578f381
DA
17572012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1758
1759 Convenient macro to check whether the buffer is live.
1760 * buffer.h (BUFFER_LIVE_P): New macro.
1761 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1762 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1763
3057e615
YM
17642012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1765
1766 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1767 composition cases (Bug#12364).
1768
1769 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1770 overhang of succeeding glyphs overlapping box cursor.
1771
1772 * w32term.c (x_draw_glyph_string): Likewise.
1773
6fda35f2
PE
17742012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1775
c990426a
PE
1776 Simplify, document, and port floating-point (Bug#12381).
1777 The porting part of this patch fixes bugs on non-IEEE platforms
1778 with frexp, ldexp, logb.
1779 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1780 Now static.
1781 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1782 support, by removing commented-out code and briefly listing the
1783 C89 functions excluded. The commented-out stuff was confusing
1784 maintenance, e.g., we thought we needed cbrt but it was commented out.
1785 (logb): Remove decl; no longer needed.
1786 (isfinite): New macro, if not already supplied.
1787 (isnan): Don't replace any existing macro.
1788 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1789 are present on all C89 platforms.
1790 (Ffrexp): Do not special-case zero, as frexp does the right thing
1791 for that case.
1792 (Flogb): Do not use logb, as it doesn't have the desired meaning
1793 on hosts that use non-base-2 floating point. Instead, stick with
1794 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1795 frexp, to avoid getting an unspecified result.
1796
6fda35f2
PE
1797 * xdisp.c (Qinhibit_debug_on_message): Now static.
1798
16130a58
JD
17992012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1800
1801 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1802 NSBezierPath (Bug#12131).
1803
d105a573
CY
18042012-09-10 Chong Yidong <cyd@gnu.org>
1805
1806 * fns.c (Fdelq, Fdelete): Doc fix.
1807
ff55dfe8
PE
18082012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1811 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1812
e7032e7c
SM
18132012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1816 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1817 Use it.
1818
e9957956
EZ
18192012-09-09 Eli Zaretskii <eliz@gnu.org>
1820
aba05ce9
EZ
1821 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1822 left fringe if the window has a left margin. This avoids leaving
1823 traces of the cursor because its leftmost pixel is not drawn over.
1824
e9957956
EZ
1825 * dispnew.c (update_window_line): When the left margin area of a
1826 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1827 that screen line. (Bug#12277)
1828
f6196b87
PE
18292012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 Assume C89 or later for math functions (Bug#12381).
1832 This simplifies the code, and makes it a bit smaller and faster,
1833 and (most important) makes it easier to clean up signal handling
1834 since we can stop worring about floating-point exceptions in
1835 library code. That was a problem before C89, but the problem
1836 went away many years ago on all practical Emacs targets.
1837 * data.c, image.c, lread.c, print.c:
1838 Don't include <math.h>; no longer needed.
1839 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1840 might be autoconfigured, as that never happens.
1841 * data.c (fmod):
1842 * doprnt.c (DBL_MAX_10_EXP):
1843 * print.c (DBL_DIG):
1844 Remove. C89 or later always defines these.
1845 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1846 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1847 (arith_error, domain_error, domain_error2):
1848 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1849 no longer needed -- we simply return what C returns. All uses removed.
1850 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1851 the wrapped code.
1852 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1853 Remove. All uses expanded, as these macros are no longer used
1854 more than once and are now more trouble than they're worth.
1855 (Ftan): Use tan, not sin / cos.
1856 (Flogb): Assume C89 frexp.
1857 (fmod_float): Assume C89 fmod.
1858 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1859 (init_floatfns): Remove. All uses removed.
1860
9d7f1863
JD
18612012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1862
1863 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1864 compositeToPoint for OSX < 10.6 (Bug#12390).
1865
eabf0404
PE
18662012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1869 This produces more-accurate results.
1870
0b3b1d23
JD
18712012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1872
1873 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1874 changes (Bug#12088).
1875
6dcef6ec
CY
18762012-09-08 Chong Yidong <cyd@gnu.org>
1877
1878 * syntax.c (Fstring_to_syntax): Doc fix.
1879
aa7d57c5
JD
18802012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1881
1882 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1883 in the internal border.
1884 (x_set_window_size): Remove static variables and their usage.
1885 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1886 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1887 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1888 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1889 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1890 (ns_fix_rect_ibw): Remove.
1891 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1892 (ns_dumpglyphs_box_or_relief): Ditto.
1893 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1894 adjustment.
1895 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1896 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1897 border adjustment.
1898 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1899 their usage. Add fringe_extended_p and its use as in other terms.
1900 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1901 scroll bar was removed.
1902 (updateFrameSize): New function.
1903 (windowDidResize): Move code to updateFrameSize and call it.
1904
1905 * nsterm.h (EmacsView): Add updateFrameSize.
1906
1a5432bc
CY
19072012-09-07 Chong Yidong <cyd@gnu.org>
1908
b4f5313e
CY
1909 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1910
1a5432bc
CY
1911 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1912
1a4f1e9b
PE
19132012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1916 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1917 Problem introduced when merging patches. Noted by Eli Zaretskii in
1918 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1919 * floatfns.c: Comment fix.
1920 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1921 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1922 and anyway the declaration is harmless even if SIGDANGER is not defined.
1923 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1924 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1925 source files not surprisingly expected syssignal.h to define, or
1926 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1927 Include <sys/ioctl.h>, for FIONREAD.
1928 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1929 This eliminates a problem whereby other files mysteriously had
1930 to include "syssignal.h" before including "systty.h" if they
1931 wanted to use "#ifdef SIGIO".
1932
bc8000ff
EZ
19332012-09-07 Eli Zaretskii <eliz@gnu.org>
1934
3e6d6928
EZ
1935 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1936
1937 * w32.c (sigemptyset): Empty the set.
1938 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1939
bc8000ff
EZ
1940 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1941
b4fa72f2
DA
19422012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1943
1944 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1945 (mark_object): Likewise for frame objects.
1946
30730c93
PE
19472012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 * syssignal.h (handle_on_main_thread): Always declare,
1950 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1951 This ports to platforms without HAVE_PTHREAD.
1952
2fe28299
PE
19532012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 Signal-handler cleanup (Bug#12327).
1956 Emacs's signal handlers were written in the old 4.2BSD style with
1957 sigblock and sigmask and so forth, and this led to some
1958 inefficiencies and confusion. Rewrite these to use
1959 pthread_sigmask etc. without copying signal sets around. Also,
1960 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1961 'signal', and instead use functions that do not attempt to take
1962 over the system name space. This patch causes Emacs's text
1963 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1964 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1965 Do not include <signal.h> or "syssignal.h", as these
1966 modules do not use signals.
1967 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1968 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1969 Do not include <signal.h>, as "syssignal.h" does that for us now.
1970 * atimer.c (sigmask_atimers): New function.
1971 (block_atimers, unblock_atimers): New functions,
1972 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1973 All uses replaced.
1974 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1975 no longer needed here.
1976 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1977 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1978 * sysdep.c (struct save_signal): New member 'action', replacing
1979 old member 'handler'.
1980 (save_signal_handlers, restore_signal_handlers):
1981 Use sigaction instead of 'signal' to save and restore.
1982 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1983 New function. All users of 'signal' modified to use set_sighandler
1984 if they're writeonly, and to use sys_signal if they're read+write.
1985 (emacs_sigaction_init, forwarded_signal): New functions.
1986 (sys_signal): Remove. All uses replaced by calls to sigaction
1987 and emacs_sigaction_init, or by direct calls to 'signal'.
1988 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1989 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1990 all uses replaced by pthread_sigmask etc. calls.
1991 * syssignal.h: Include <signal.h>.
1992 (emacs_sigaction_init, forwarded_signal): New decls.
1993 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1994 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1995 (sigmask, sys_sigmask): Remove; no longer needed.
1996 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1997 (sigblock, sigunblock, sigfree):
1998 (sigsetmask) [!defined sigsetmask]:
1999 Remove. All uses replaced by pthread_sigmask.
2000 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
2001 no longer need to be replaced, and its typical old uses
2002 are now done via emacs_sigaction_init and sigaction.
2003 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
2004 (sys_sigdel): Remove; unused.
2005 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
2006
0216c128
EZ
20072012-09-06 Eli Zaretskii <eliz@gnu.org>
2008
2009 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
2010 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
2011
c752cfa9
DA
20122012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2013
2014 Explicitly mark buffer_defaults and buffer_local_symbols.
2015 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
2016 mark_local_symbols here.
2017 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
2018 since special buffers aren't marked here any more.
2019 (allocate_buffer): Chain new buffer with all_buffers here...
2020 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
2021 not here.
2022 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
2023 (syms_of_buffer): Remove staticpro of the above.
2024 (init_buffer_once): Set names for buffer_defaults and
2025 buffer_local_symbols.
2026
a864ef14
PE
20272012-09-06 Paul Eggert <eggert@cs.ucla.edu>
2028
2029 Use bool for booleans in font-related modules.
2030 * font.c (font_intern_prop, font_style_to_value)
2031 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
2032 (generate_otf_features, font_check_otf_features, font_check_otf)
2033 (font_match_p, font_list_entities, font_at):
2034 * fontset.c (fontset_id_valid_p, reorder_font_vector
2035 (fontset_find_font, Fset_fontset_font)
2036 (face_suitable_for_char_p) [0]:
2037 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
2038 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
2039 (m17n_flt_initialized, ftfont_shape_by_flt):
2040 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
2041 * nsfont.m (nsfont_draw):
2042 * w32font.c (w32font_draw):
2043 * w32term.c (x_draw_glyphless_glyph_string_foreground):
2044 Use bool for booleans.
2045 * font.h: Adjust to above API changes.
2046 (struct font, struct font_driver, struct font_driver_list):
2047 Use bool for booleans.
2048 (struct font): Remove useless member encoding_type.
2049 All users removed.
2050 * fontset.c, xftfont.c: Omit unnecessary static decls.
2051
0699fc18
DA
20522012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2053
2054 * alloc.c (mark_object): Revert window marking code
2055 since it's unsafe for the Fset_window_configuration.
2056
20ef56db
PE
20572012-09-05 Paul Eggert <eggert@cs.ucla.edu>
2058
2fe28299 2059 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
2060 Be more systematic about preserving errno whenever a signal
2061 handler returns, even if it's not in the main thread. Do this by
2062 renaming signal handlers to distinguish between signal delivery
2063 and signal handling. All uses changed.
2064 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
2065 * data.c (deliver_arith_signal): Rename from arith_error.
2066 * dispnew.c (deliver_window_change_signal): Rename from
2067 window_change_signal.
2068 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
2069 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
2070 * keyboard.c (deliver_input_available_signal): Rename from
2071 input_available_signal.
2072 (deliver_user_signal): Rename from handle_user_signal.
2073 (deliver_interrupt_signal): Rename from interrupt_signal.
2074 * process.c (deliver_pipe_signal): Rename from send_process_trap.
2075 (deliver_child_signal): Rename from sigchld_handler.
2076 * atimer.c (handle_alarm_signal):
2077 * data.c (handle_arith_signal):
2078 * dispnew.c (handle_window_change_signal):
2079 * emacs.c (handle_fatal_signal, handle_danger_signal):
2080 * keyboard.c (handle_input_available_signal):
2081 * keyboard.c (handle_user_signal, handle_interrupt_signal):
2082 * process.c (handle_pipe_signal, handle_child_signal):
2083 New functions, with the actual signal-handling code taken from the
2084 original respective signal handlers, sans the sporadic attempts to
2085 preserve errno, since that's now done by handle_on_main_thread.
2086 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
2087 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
2088 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2089 Move to sysdep.c.
2090 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2091 Move initialization of main_thread to sysdep.c's init_signals.
2092 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
2093 our usage, and simplifies the mainline code.
2094 (record_child_status_change): New static function, as a helper
2095 for handle_child_signal, and with most of the old child handler's
2096 contents.
2097 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
2098 (handle_child_signal): Use the above.
2099 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2100 Moved here from emacs.c.
2101 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
2102 code moved here from emacs.c's main function.
2103 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
2104 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
2105 This lets callers save and restore errno properly.
20ef56db 2106
e3ccf108
DA
21072012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2108
2109 Remove redundant or unused things here and there.
2110 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
2111 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
2112 * editfns.c (Fcompare_buffer_substrings): Likewise.
2113 * frame.h (struct terminal, struct font_driver_list):
2114 Remove redundant declarations.
2115 * window.h (Qleft, Qright): Likewise.
2116
697e1e39
DA
21172012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2118
2119 Do not mark objects from deleted buffers, windows and frames.
2120 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
2121 (mark_object): Likewise for windows and frames.
2122
c1ca42ca
DA
21232012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2124
2125 * alloc.c (valid_lisp_object_p): Treat killed buffers,
2126 buffer_defaults and buffer_local_symbols as valid objects.
2127 Return special value to denote them.
2128
014d93be
PE
21292012-09-05 Paul Eggert <eggert@cs.ucla.edu>
2130
f75d7a91
PE
2131 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
2132 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
2133 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
2134 (file_name_absolute_p, Fsubstitute_in_file_name):
2135 (check_executable, check_writable, Ffile_accessible_directory_p)
2136 (Fset_file_selinux_context, Fdefault_file_modes)
2137 (Finsert_file_contents, choose_write_coding_system)
2138 (Fwrite_region, build_annotations, a_write, e_write)
2139 (Fdo_auto_save):
2140 * filelock.c (boot_time_initialized, get_boot_time)
2141 (get_boot_time_1, lock_file_1, within_one_second):
2142 * floatfns.c (in_float):
2143 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
2144 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
2145 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
2146 * lisp.h (struct Lisp_Hash_Table.cmpfn):
2147 * window.c (compare_window_configurations):
2148 Use bool for booleans.
2149 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
2150 (Fdefault_file_modes): Now mode_t, not int, for modes.
2151 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
2152 (internal_delete_file): Now returns void, not a (boolean) int,
2153 since nobody was looking at the return value.
2154 * lisp.h, window.h: Adjust to above API changes.
2155
014d93be
PE
2156 * xdisp.c (set_message): Simplify and reindent last change.
2157
776f29e1
JB
21582012-09-05 Juanma Barranquero <lekktu@gmail.com>
2159
2160 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
2161
7f7e0167
LI
21622012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
2163
2164 * eval.c (call_debugger): Make the function non-static so that we
2165 can call it from set_message.
2166
2167 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
2168 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
2169
cf29dd84
PE
21702012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2171
2172 Give more-useful info on a fatal error (Bug#12328).
2173 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
2174 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
2175 of doing the work ourselves.
2176 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
2177 do most of the work.
2178 (fatal_error_backtrace): New function, taken from the guts
2179 of the old fatal_error_signal, but with a new option to output
2180 a backtrace.
2181 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
2182 info about the signal than just its number.
2183 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
2184 * sysdep.c: Include <execinfo.h>
2185 (emacs_backtrace): New function, taken partly from the previous
2186 code of the 'die' function.
2187 (emacs_abort): Call fatal_error_backtrace rather than abort.
2188
972debf2
SM
21892012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
2190
2191 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
2192 eager (load-time) macro-expansion.
2193 * lisp.mk (lisp): Add macroexp.
2194
1088b922
PE
21952012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 Simplify redefinition of 'abort' (Bug#12316).
2198 Do not try to redefine the 'abort' function. Instead, redo
2199 the code so that it calls 'emacs_abort' rather than 'abort'.
2200 This removes the need for the NO_ABORT configure-time macro
2201 and makes it easier to change the abort code to do a backtrace.
2202 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
2203 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
2204 Remove; sysdep.c's emacs_abort now takes its place.
2205 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
2206 'abort' changed to use 'emacs_abort'.
2207 * msdos.c (dos_abort) [defined abort]: Remove; not used.
2208 (abort) [!defined abort]: Rename to ...
2209 (emacs_abort): ... new name.
2210 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
2211 the place of the old 'abort' in emacs.c.
2212 * w32.c, w32fns.c (abort): Do not #undef.
2213 * w32.c (emacs_abort): Rename from w32_abort.
2214
30934d33
EZ
22152012-09-04 Eli Zaretskii <eliz@gnu.org>
2216
2217 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
2218 offsets[j].dv, since the y axis of the screen coordinates points
2219 down, while the y axis of the font definition coordinates points
2220 up. This fixes display of Arabic diacritics such as KASRA and
2221 KASRATAN. (Bug#11860)
2222
af26b72c
PE
22232012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 Be more systematic about _setjmp vs setjmp.
2226 * alloc.c (test_setjmp, mark_stack):
2227 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
2228 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
2229 (png_load, my_error_exit, jpeg_load):
2230 * process.c (send_process_trap, send_process):
2231 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
2232 The underscored versions are up to 30x faster on some hosts.
2233 Formerly, the code used setjmp+longjmp sometimes and
2234 _setjmp+_longjmp at other times, with no particular reason to
2235 prefer setjmp+longjmp.
2236
26d4541d
PE
22372012-09-03 Paul Eggert <eggert@cs.ucla.edu>
2238
d42f4f0f 2239 Fix minor problem found by static checking.
26d4541d 2240 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 2241
c5e28e39
MR
22422012-09-03 Martin Rudalics <rudalics@gmx.at>
2243
2244 * buffer.c (Fdelete_all_overlays): New function.
2245
3eab3ca9
CY
22462012-09-03 Chong Yidong <cyd@gnu.org>
2247
2248 * gtkutil.c: Add extern decl for Qxft.
2249
c04889f8
PE
22502012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2251
1882aa38
PE
2252 * emacs.c, eval.c: Use bool for boolean.
2253 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
2254 (malloc_using_checking) [DOUG_LEA_MALLOC]:
2255 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
2256 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
2257 (main, decode_env_path, Fdaemon_initialized):
2258 * eval.c (call_debugger, Finteractive_p, interactive_p):
2259 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
2260 (maybe_call_debugger, Fbacktrace):
2261 * process.c (read_process_output, exec_sentinel):
2262 Use bool for booleans.
2263 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
2264 All callers changed.
2265 * eval.c (interactive_p): Omit always-true boolean argument
2266 EXCLUDE_SUBRS_P. All callers changed.
2267 * dispextern.h, lisp.h: Reflect above API changes.
2268 * firstfile.c (dummy): Use the address of 'main', whose signature
2269 won't change, instead of the address of 'initialize', whose
2270 signature just changed from int to bool.
2271 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
2272 * msdos.c (fatal_error_in_progress): ... from here.
2273 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
2274 of incrementing it.
2275 (redisplay_internal, unwind_redisplay): Simply clear
2276 REDISPLAYING_P when unwinding, instead of saving its previous,
2277 always-false value and then restoring it.
2278
a411ac43
PE
2279 Clean up some extern decls.
2280 Mostly, this hoists extern decls out of .c files and into .h files.
2281 That way, we're more likely to catch errors if the interfaces change.
2282 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
2283 declare xg_mark_data.
2284 * dispextern.h (x_frame_parm_handlers):
2285 * font.h (Qxft):
2286 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
2287 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
2288 (Qultra_bold, Qoblique, Qitalic):
2289 Move extern decl here from .c file.
2290 * alloc.c (xg_mark_data) [USE_GTK]:
2291 * doc.c (Qclosure):
2292 * eval.c (Qlexical_binding):
2293 * fns.c (time) [!HAVE_UNISTD_H]:
2294 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
2295 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
2296 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
2297 * lread.c (Qinternal_interpreter_environment):
2298 * minibuf.c (Qbuffer):
2299 * process.c (QCfamily, QCfilter):
2300 * widget.c (free_frame_faces):
2301 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
2302 * xfont.c (x_clear_errors):
2303 * xterm.c (x_frame_parm_handlers):
2304 Remove now-redundant extern decls.
2305 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
2306 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
2307 Now static.
2308 * xfaces.c: Remove unnecessary static decls.
2309 * xterm.c (updating_frame): Remove decl of nonexistent object.
2310
c04889f8
PE
2311 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
2312 when building globals.h, as the objects that are not built on
2313 this host are not needed to compile C files on this host.
2314
8b339673
JD
23152012-09-02 Jan Djärv <jan.h.d@swipnet.se>
2316
2317 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
2318
2319 * frame.h: Add missing prototype for x_wm_set_size_hint.
2320
a08d4ba7
PE
23212012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
2324 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
2325 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
2326 (Fsubstitute_command_keys):
2327 * editfns.c (region_limit, find_field, Fconstrain_to_field)
2328 (save_excursion_save, save_excursion_restore)
2329 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
2330 (format_time_string, general_insert_function)
2331 (make_buffer_string, make_buffer_string_both)
2332 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
2333 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
2334 (copy_text, insert_1, insert_1_both, insert_from_string)
2335 (insert_from_string_before_markers, insert_from_string_1)
2336 (insert_from_buffer, insert_from_buffer_1, replace_range)
2337 (replace_range_2, del_range_1, del_range_byte, del_range_both)
2338 (del_range_2, modify_region):
2339 * intervals.c (intervals_equal, balance_possible_root_interval)
2340 (adjust_intervals_for_insertion, merge_properties_sticky)
2341 (graft_intervals_into_buffer, lookup_char_property)
2342 (adjust_for_invis_intang, set_point_both)
2343 (get_property_and_range, compare_string_intervals)
2344 (set_intervals_multibyte_1, set_intervals_multibyte):
2345 * keyboard.c (decode_timer):
2346 Use bool for boolean.
2347 * intervals.h, lisp.h, systime.h: Reflect above API changes.
2348 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
2349
48c948de
CY
23502012-09-02 Chong Yidong <cyd@gnu.org>
2351
2352 * keymap.c (push_key_description): Print M-TAB as C-M-i
2353 (Bug#11758).
2354
6c49a40b
JB
23552012-09-02 Juanma Barranquero <lekktu@gmail.com>
2356
2357 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
2358 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
2359 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
2360 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
2361 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
2362 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
2363 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2364
4dfbd238
EZ
23652012-09-01 Eli Zaretskii <eliz@gnu.org>
2366
7e510e28
EZ
2367 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
2368 more than one grapheme cluster passed to the shaper: compute the
2369 offset adjustment values separately for each cluster. (Bug#11860)
2370
4dfbd238
EZ
2371 * image.c: Restore mistakenly removed inclusion of w32.h. Without
2372 it, GCC doesn't see prototypes of w32_delayed_load, and complains
2373 about implicit conversions from integer to pointer.
2374
86571ae0
DC
23752012-09-01 Daniel Colascione <dancol@dancol.org>
2376
2377 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
2378 system used too early.
2379
0e23ef9d
PE
23802012-09-01 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 Better seed support for (random).
2383 * emacs.c (main): Call init_random.
2384 * fns.c (Frandom): Set the seed from a string argument, if given.
2385 Remove long-obsolete Gentzel cruft.
2386 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
2387 (init_random): New function.
2388
17a2cbbd
DC
23892012-09-01 Daniel Colascione <dancol@dancol.org>
2390
2391 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
2392 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
2393 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
2394 x_wm_set_size_hint, x_query_colors, x_real_positions,
2395 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
2396 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
2397 all of which have been moved to common code.
2398
2399 * xfaces.c: Include TERM_HEADER instead of listing all possible
2400 window-system headers.
2401
2402 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
2403 to match header.
2404
2405 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
2406 directly accessing frame internals.
2407
f18cbb28 2408 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
2409 globals_of_w32font.
2410
2411 * process.c: Include TERM_HEADER instead of listing all possible
2412 window-system headers.
2413
3a880af4
SM
2414 * nsterm.h: Remove declarations now in frame.h.
2415 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
2416
2417 * menu.c: Include TERM_HEADER instead of listing all possible
2418 window-system headers.
2419
2420 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
2421 window system.
2422
2423 * keyboard.c: Include TERM_HEADER instead of listing all possible
2424 window-system headers.
2425
2426 * image.c: Include TERM_HEADER instead of listing all possible
2427 window-system headers. Declare Vlibrary_cache when compiling for
2428 Windows.
2429
2430 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
2431 window system declarations.
2432
2433 * frame.h: Move common functions here: set_frame_menubar,
2434 x_set_window_size, x_sync, x_get_focus_frame,
2435 x_set_mouse_position, x_set_mouse_pixel_position,
2436 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
2437 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
2438 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
2439 x_activate_menubar, x_real_positions, x_bitmap_icon,
2440 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
2441 and x_query_colors.
2442
2443 * frame.c: Include TERM_HEADER instead of listing all possible
2444 window-system headers.
2445
2446 * font.c: Include TERM_HEADER instead of listing all possible
2447 window-system headers.
2448
2449 * emacs.c: Include TERM_HEADER.
2450
f18cbb28
EZ
2451 * dispnew.c: Include TERM_HEADER instead of listing all possible
2452 window-system headers.
17a2cbbd 2453
f18cbb28 2454 * ccl.h: Include character.h.
17a2cbbd
DC
2455
2456 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
2457 the current window system; include in list of objects to link into
2458 Emacs.
2459
c650a5de
DA
24602012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2461
2462 Remove mark_ttys function and fix tty_display_info initialization.
2463 * lisp.h (mark_ttys): Remove prototype.
2464 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
2465 to mark_ttys because all possible values of 'top_frame' slot are
2466 the frames which are reachable from Vframe_list.
2467 * term.c (mark_ttys): Remove.
2468 (init_tty): Safely initialize 'top_frame' slot with Qnil.
2469
4e0f6479
DA
24702012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2471
2472 Change struct frame bitfields from unsigned char to unsigned.
2473 * frame.h (struct frame): Change type of 'display_preempted',
2474 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
2475 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
2476 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
2477 bitfields from unsigned char to unsigned.
2478
8b96a52c
DA
24792012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2480
2481 Remove unused member of struct x_output and struct w32_output.
2482 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
2483 * w32term.h (struct w32_output): Likewise.
2484
b4444c8a
JD
24852012-08-30 Jan Djärv <jan.h.d@swipnet.se>
2486
2487 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
2488 does not become zero (Bug#12234).
2489
b98521db
PE
24902012-08-30 Paul Eggert <eggert@cs.ucla.edu>
2491
2492 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
2493 for GCC 4.7.1 x86-64.
2494
31d02438
GM
24952012-08-30 Glenn Morris <rgm@gnu.org>
2496
2497 * lread.c (init_lread): For out-of-tree builds, only add the
2498 source directory's site-lisp dir to the load-path if it exists,
2499 consistent with in-tree builds. (Bug#12302)
2500
7f8941d8
JD
25012012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2502
2503 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 2504 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
2505 (windowShouldClose:): Set window_closed.
2506 (dealloc): New member, free button_values.
fc0c31f8
JB
2507 (process_dialog:): Make member function. Remove window argument,
2508 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
2509 in button_values.
2510 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 2511 with tag. Remove return self, declare return value as void.
7f8941d8
JD
2512 (addString:row:): Remove return self, declare return value as void.
2513 (addSplit): Remove return self, declare return value as void.
2514 (clicked:): Remove return self, declare return value as void.
fc0c31f8 2515 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
2516 (initFromContents:isQuestion:): Adjust call to process_dialog.
2517 Code formatting change.
2518 (timeout_handler:): Set timer_fired to YES.
2519 (runDialogAt:): Set timer_fired to NO.
2520 Handle click on close button as quit.
2521
2522 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
2523 Add window_closed and button_values. Add void as return value for
2524 add(Button|String|Split). addButton takes int instead of Lisp_Object.
2525 Add process_dialog as new member.
2526
eada0861 25272012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 2528
eada0861
GM
2529 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
2530 is not one of the heaps we manage. (Bug#12242)
2531
25322012-08-28 Glenn Morris <rgm@gnu.org>
2533
2534 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
2535
457294dd
MR
25362012-08-28 Martin Rudalics <rudalics@gmx.at>
2537
2538 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
2539 auto-buffer-name window parameter. Install revision of reverted
2540 fix.
457294dd 2541
4f2daf31
DA
25422012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2543
2544 Do not allow to set major mode for a dead buffer.
2545 * buffer.c (Fset_buffer_major_mode): Signal an error
2546 if the buffer is dead.
2547 (Fother_buffer, other_buffer_safely): Remove redundant
2548 nested declaration.
2549
66322887
DA
25502012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2551
2552 Always use set_buffer_if_live to restore original buffer at unwind.
2553 * buffer.h (record_unwind_current_buffer): New function.
2554 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
2555 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
2556 * undo.c, window.c: Adjust users.
2557 * buffer.c (set_buffer_if_live): Fix comment.
2558
a3d794a1
DA
25592012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2560
2561 Fix usage of set_buffer_internal.
2562 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
2563 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
2564 * coding.c (decode_coding): Omit redundant test.
2565 * fileio.c (decide_coding_unwind): Likewise.
2566 * fns.c (secure_hash): Likewise.
2567 * insdel.c (modify_region): Likewise.
2568 * keyboard.c (command_loop_1): Likewise.
2569 * print.c (PRINTFINISH): Likewise.
2570 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
2571
59ea14cd
PE
25722012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 * dispnew.c: Use bool for boolean.
2575 (frame_garbaged, display_completed, delayed_size_change)
2576 (fonts_changed_p, add_window_display_history)
2577 (add_frame_display_history, verify_row_hash)
2578 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
2579 (row_equal_p, realloc_glyph_pool)
2580 (allocate_matrices_for_frame_redisplay)
2581 (showing_window_margins_p)
2582 (adjust_frame_glyphs_for_frame_redisplay)
2583 (build_frame_matrix_from_leaf_window, make_current)
2584 (mirrored_line_dance, mirror_line_dance, update_frame)
2585 (update_window_tree, update_single_window)
2586 (check_current_matrix_flags, update_window, update_text_area)
2587 (update_window_line, set_window_update_flags, scrolling_window)
2588 (update_frame_1, scrolling, buffer_posn_from_coords)
2589 (do_pending_window_change, change_frame_size)
2590 (change_frame_size_1, sit_for):
2591 Use bool for boolean.
2592 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
2593 and remove last int (actually boolean) argument, which was always 0.
2594 All callers changed.
2595 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
2596 * dispextern.h (struct composition_it): Use bool for boolean.
2597 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
2598 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
2599 * dired.c (file_name_completion):
2600 Use bool for boolean. (This was missed in an earlier change.)
2601
95072a94
MR
26022012-08-27 Martin Rudalics <rudalics@gmx.at>
2603
2604 * window.c (Fset_window_configuration): Revert first part of
2605 last change.
2606
0f19feff
JD
26072012-08-27 Jan Djärv <jan.h.d@swipnet.se>
2608
2609 * nsterm.h (NSPanel): New class variable dialog_return.
2610
3a880af4
SM
2611 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
2612 Initialize dialog_return.
0f19feff
JD
2613 (windowShouldClose:): Use stop instead of stopModalWithCode.
2614 (clicked:): Ditto, and also set dialog_return (Bug#12258).
2615 (timeout_handler:): Use stop instead of abortModal. Send a dummy
2616 event.
2617 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
2618 modal loop returns.
2619
f10fe38f
PE
26202012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2621
de1339b0
PE
2622 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
2623 * composite.c (find_composition, composition_gstring_p)
2624 (composition_reseat_it, find_automatic_composition):
2625 * data.c (let_shadows_buffer_binding_p)
2626 (let_shadows_global_binding_p, set_internal, make_blv)
2627 (Fmake_variable_buffer_local, Fmake_local_variable)
2628 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
2629 (cons_to_signed, arith_driver):
2630 * dbusbind.c (xd_in_read_queued_messages):
2631 * dired.c (directory_files_internal, file_name_completion):
2632 Use bool for booleans.
2633 * dired.c (file_name_completion):
2634 * process.h (fd_callback):
2635 Omit int (actually boolean) argument. It wasn't being used.
2636 All uses changed.
2637 * composite.h, lisp.h: Reflect above API changes.
2638
f10fe38f
PE
2639 * cmds.c, coding.c: Use bool for booleans.
2640 * cmds.c (move_point, Fself_insert_command):
2641 * coding.h (struct composition status, struct coding_system):
2642 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
2643 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
2644 (emacs_mule_char, decode_coding_emacs_mule)
2645 (encode_coding_emacs_mule, detect_coding_iso_2022)
2646 (decode_coding_iso_2022, encode_invocation_designation)
2647 (encode_designation_at_bol, encode_coding_iso_2022)
2648 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
2649 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
2650 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
2651 (encode_coding_raw_text, detect_coding_charset)
2652 (decode_coding_charset, encode_coding_charset, detect_eol)
2653 (detect_coding, get_translation_table, produce_chars)
2654 (consume_chars, reused_workbuf_in_use)
2655 (make_conversion_work_buffer, code_conversion_save)
2656 (decode_coding_object, encode_coding_object)
2657 (detect_coding_system, char_encodable_p)
2658 (Funencodable_char_position, code_convert_region)
2659 (code_convert_string, code_convert_string_norecord)
2660 (Fset_coding_system_priority):
2661 * fileio.c (Finsert_file_contents):
2662 Use bool for booleans.
2663 * coding.h, lisp.h: Reflect above API changes.
2664 * coding.c: Remove unnecessary static function decls.
2665 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
2666 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
2667 not a boolean 'int', since callers never look at the return value.
2668 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
2669 * coding.h (decoding_buffer_size, encoding_buffer_size)
2670 (emacs_mule_string_char): Remove unused extern decls.
2671 (struct iso_2022_spec, struct coding_system):
2672 Use 'unsigned int : 1' for boolean fields, since there's more than one.
2673 (struct emacs_mule_spec): Remove unused field 'full_support'.
2674 All initializations removed.
2675 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
2676
5474c384
DA
26772012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2678
f10fe38f 2679 Fix spare memory change (Bug#12286).
5474c384
DA
2680 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
2681 (valid_lisp_object_p): Likewise.
2682
c4b6914d
MR
26832012-08-27 Martin Rudalics <rudalics@gmx.at>
2684
2685 * window.c (Fset_window_configuration): Record any window's old
2686 buffer if it's replaced (see Bug#8789). If the new current
2687 buffer doesn't appear in the selected window, go to its old
2688 point (Bug#12208).
2689
35aaa1ea
DA
26902012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2691
2692 Special MEM_TYPE_SPARE to denote reserved memory.
2693 * alloc.c (enum mem_type): New memory type.
2694 (refill_memory_reserve): Use new type for spare memory.
2695 This prevents live_cons_p and live_string_p from incorrect
2696 detection of uninitialized objects from spare memory as live.
2697
6af64513
PE
26982012-08-26 Paul Eggert <eggert@cs.ucla.edu>
2699
8b2e00a3
PE
2700 Spelling fixes.
2701 * Makefile.in (.PHONY): versioclean -> versionclean.
2702
b52d6985
PE
2703 Remove unused external symbols.
2704 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
2705 * window.c (Qwindow_valid_p, decode_valid_window):
2706 Now static, not extern.
2707 * data.c (Qinterval): Remove; unused.
2708 (syms_of_data): Do not define 'interval'.
2709 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
2710 * window.h (decode_valid_window):
2711 Remove decls.
2712
d5172d4f
PE
2713 * character.c, charset.c, chartab.c: Use bool for booleans.
2714 * character.c (lisp_string_width, string_count_byte8)
2715 (string_escape_byte8):
2716 * charset.c (charset_map_loaded, load_charset_map, read_hex):
2717 (load_charset_map_from_file, map_charset_chars)
2718 (Fdefine_charset_internal, define_charset_internal)
2719 (Fdeclare_equiv_charset, find_charsets_in_text)
2720 (Ffind_charset_region, char_charset, Fiso_charset):
2721 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
2722 (sub_char_table_set, sub_char_table_set_range)
2723 (char_table_set_range, optimize_sub_char_table)
2724 (map_sub_char_table):
2725 Use bool for boolean.
2726 * character.c (str_to_unibyte): Omit last boolean argument; it was
2727 always 0. All callers changed.
2728 * character.h, charset.h: Adjust to match previous changes.
2729 * character.h (char_printable_p): Remove decl of nonexistent function.
2730 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
2731 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
2732 are all boolean, so make them single-bit bitfields.
2733
6af64513
PE
2734 * lisp.h (ASET): Remove attempt to detect side effects.
2735 It was meant to be temporary and it often doesn't work,
2736 because when IDX has side effects the behavior of IDX==IDX
2737 is undefined. See Stefan Monnier in
2738 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
2739
e1f29348
BR
27402012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2741
2742 * lisp.h (functionp): New function (extracted from Ffunctionp).
2743 (FUNCTIONP): Use it.
2744 * eval.c (Ffunctionp): Use it.
2745
17c05d74
PE
27462012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2747
0f46bc75
PE
2748 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2749 as that's faster and simpler than static storage. Don't bother
2750 with the g_main_context_query overhead if g_main_context_pending
2751 says no events are pending.
2752 (gfds, gfds_size): Remove these static vars.
2753 (xgselect_initialize): Remove; no longer needed.
2754 All uses and decls removed.
2755
ee4c0f69
PE
2756 * emacs.c (fatal_error_signal_hook): Remove.
2757 All uses removed. This leftover from old code was always 0.
2758
17c05d74
PE
2759 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2760 * casefiddle.c (casify_object, casify_region):
2761 * casetab.c (set_case_table):
2762 * category.c, category.h (word_boundary_p):
2763 * category.h (CHAR_HAS_CATEGORY):
2764 Use bool for booleans, instead of int.
2765
391ceac5
EZ
27662012-08-25 Eli Zaretskii <eliz@gnu.org>
2767
2768 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2769
2f221583
PE
27702012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2771
f4a681b0
PE
2772 On assertion failure, print backtrace if available.
2773 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2774 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2775 * Makefile.in (LIB_EXECINFO): New macro.
2776 (LIBES): Use it.
2777
2f221583
PE
2778 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2779 * bytecode.c (exec_byte_code):
2780 * callint.c (check_mark, Fcall_interactively):
2781 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2782 (getenv_internal, sync_process_alive, call_process_exited):
2783 * lisp.h (USE_SAFE_ALLOCA):
2784 Use bool for booleans, instead of int.
2785 * lisp.h, process.h: Adjust prototypes to match above changes.
2786 * callint.c (Fcall_interactively): Don't assume the mark's
2787 offset fits in 'int'.
2788
37ef52bb
PE
27892012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2790
2791 * buffer.c, buffer.h: Use bool for boolean.
2792 * buffer.c (reset_buffer_local_variables)
2793 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2794 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2795 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2796 (overlay_touches_p, overlay_strings, Foverlay_put)
2797 (report_overlay_modification, call_overlay_mod_hooks):
2798 (mmap_enlarge, mmap_set_vars):
2799 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2800 Use bool for booleans, instead of int.
2801 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2802 since the 1-or-0 return value is always ignored anyway.
2803 (mmap_initialized_p):
2804 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2805 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2806
2cc21167
PE
28072012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 * bidi.c: Use bool for boolean.
2810 This is a bit more readable, and makes the text segment of bidi.o
2811 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2812 Presumably it's faster too.
2813 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2814 Now bool.
2815 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2816 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2817 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2818 (bidi_explicit_dir_char, bidi_level_of_next_char)
2819 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2820 Use bool for booleans, instead of int.
2821 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2822 (bidi_unshelve_cache): Adjust decls to match code.
2823
7db4ddf4
MR
28242012-08-23 Martin Rudalics <rudalics@gmx.at>
2825
2826 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2827 argument.
2828
b1bb8011
PE
28292012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2832 * atimer.h: Include <stdbool.h>.
2833
ff687885
DN
28342012-08-22 Dan Nicolaescu <dann@gnu.org>
2835
2836 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2837 compile time tests instead of run time tests on systems that do
2838 not use them.
2839 (FRAME_MAC_P): Remove leftover from deleted code.
2840 * frame.c (syms_of_frame): Remove leftover from deleted code.
2841
4ce7a138
JD
28422012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2843
2844 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2845
d733ec6d
PE
28462012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2849 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2850 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2851 (fontset_add): Return void, for FONTSET_ADD.
2852
d0d2d26f
PE
28532012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2854
fce31d69
PE
2855 * alloc.c: Use bool for booleans.
2856 (gc_in_progress, abort_on_gc)
2857 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2858 (dont_register_blocks) [GC_MALLOC_CHECK]:
2859 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2860 (check_string_bytes, make_specified_string, memory_full)
2861 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2862 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2863 (mark_stack, valid_pointer_p, make_pure_string)
2864 (Fgarbage_collect, survives_gc_p, gc_sweep):
2865 Use bool for booleans, instead of int.
2866 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2867 Remove unused local.
2868 * alloc.c (PURE_POINTER_P):
2869 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2870 * editfns.c (Fformat):
2871 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2872 (Fdo_auto_save):
2873 * fns.c (sweep_weak_table):
2874 * lisp.h (suppress_checking, push_message, survives_gc_p)
2875 (make_pure_string, gc_in_progress, abort_on_gc):
2876 * lread.c (readchar, read1):
2877 * print.c (Fprin1_to_string):
2878 * xdisp.c (push_message):
2879 Use bool for booleans affected directly or indirectly by
2880 alloc.c's changes.
2881
d0d2d26f
PE
2882 Make recently-introduced setters macros.
2883 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2884 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2885 (set_fontset_default, set_fontset_fallback): Rename from their
2886 upper-case counterparts, and make them functions rather than macros.
2887 This is more consistent with the other recently-introduced setters.
2888 These don't need to be inline, since they're local.
2889
d18e2bb6
JD
28902012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2891
2892 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2893 the loop (Bug#12247).
2894
1b9d9d16
PE
28952012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * lisp.h (vcopy): Use memcpy rather than our own loop.
2898 This fixes a performance regression introduced by the recent
2899 addition of vcopy. This means 'vcopy' will need to be modified
2900 for a copying collector, but that's OK. Also, tighten the
2901 checking in the assertion.
2902
b2f09701
EZ
29032012-08-21 Eli Zaretskii <eliz@gnu.org>
2904
2905 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2906 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2907 non-base glyph for the width of the base character, according to
e1f29348
BR
2908 what x_draw_composite_glyph_string_foreground expects.
2909 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2910 expectations, to produce correct width of the composed character.
2911 Reverse the sign of the DU offset produced by ScriptPlace.
2912
9b994fed
PE
29132012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2916
086ca913
DA
29172012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2918
2919 Avoid direct writes to contents member of struct Lisp_Vector.
2920 * lisp.h (vcopy): New function to copy data into vector.
2921 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2922 * fns.c (Ffillarray): Use ASET.
2923 * keyboard.c (timer_check_2): Use AREF and ASET.
2924 (append_tool_bar_item, Frecent_keys): Use vcopy.
2925 * lread.c (read_vector): Use ASET.
2926 * msdos.c (Frecent_doskeys): Use vcopy.
2927 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2928 (Finternal_merge_in_global_face): Use ASET and vcopy.
2929 * xfont.c (xfont_list_pattern): Likewise.
2930
5481664a
MR
29312012-08-21 Martin Rudalics <rudalics@gmx.at>
2932
2933 * window.c (Fwindow_point): For the selected window always return
2934 the position of its buffer's point.
2935 (Fset_window_point): For the selected window always go in its
2936 buffer to the specified position.
2937
6d470bdd
DA
29382012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2939
2940 Setter macros for fontsets.
2941 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2942 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2943 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2944 Adjust users.
2945
24564fe1
GM
29462012-08-20 Glenn Morris <rgm@gnu.org>
2947
2948 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2949 Don't assume that `ln -f' works.
2950
0a05a035
EZ
29512012-08-20 Eli Zaretskii <eliz@gnu.org>
2952
2953 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2954 and later about non-assignments with no effect. See discussion at
2955 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2956 details.
2957
e46f2325
DA
29582012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2959
2960 Inline setter functions for Lisp_Objects slots of struct specbinding.
2961 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2962 Adjust users.
2963
734fbd86
MR
29642012-08-20 Martin Rudalics <rudalics@gmx.at>
2965
2966 * window.c (select_window): Always make selected window's buffer
2967 current.
2968
f1a95992
DA
29692012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2970
2971 Use AREF and ASET for docstrings of category tables.
2972 * category.h (CATEGORY_DOCSTRING): Use AREF.
2973 (SET_CATEGORY_DOCSTRING): Use ASET.
2974 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2975
e83064be
DA
29762012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2977
2978 Inline setter functions for hash table members.
2979 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2980 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2981 (set_hash_key_and_value, set_hash_index, set_hash_next)
2982 (set_hash_hash): New functions.
2983 * charset.c, fns.c: Adjust users.
2984
4ce60d2e
DA
29852012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2986
2987 Inline getter and setter functions for per-buffer values.
2988 * buffer.h (per_buffer_default, set_per_buffer_default)
2989 (per_buffer_value, set_per_buffer_value): New functions.
2990 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2991 * buffer.c, data.c: Adjust users.
2992
c06c9690
JB
29932012-08-20 Juanma Barranquero <lekktu@gmail.com>
2994
2995 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2996
32bd4250
PE
29972012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2998
bad03192 2999 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
3000 as gnulib does this if the system doesn't.
3001 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
3002 Remove declaration. MS-Windows declares it on stdlib.h which is
3003 included by conf_post.h.
b69a6d22
PE
3004 * emacs.c (environ) [DOUG_LEA_MALLOC]:
3005 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
3006 * vm-limit.c: Include <unistd.h>, for 'environ'.
3007
22d7feb2
PE
3008 * unexaix.c, unexcoff.c: Include "mem-limits.h".
3009 (start_of_data): Remove decl; mem-limits.h provides it.
3010
32bd4250
PE
3011 * xdisp.c (handle_invisible_prop): Make it a bit faster
3012 and avoid a gcc -Wmaybe-uninitialized diagnostic.
3013
450809af
CY
30142012-08-19 Chong Yidong <cyd@gnu.org>
3015
3016 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
3017 ends (Bug#3874).
3018
9e677988
AS
30192012-08-19 Andreas Schwab <schwab@linux-m68k.org>
3020
6b1319ce
AS
3021 * .gdbinit: Use call instead of set when calling a function in the
3022 inferior.
3023
9e677988
AS
3024 * data.c (set_internal): Don't use set_blv_found.
3025 (Fkill_local_variable): Likewise.
3026
d7191076
AA
30272012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
3028
3029 * nsfont.m (ns_ascii_average_width): Ensure the string
3030 ascii_printable is initialized with a null-terminated character
3031 array. Otherwise, it can contain undesired extra characters.
3032
e757f1c6
PE
30332012-08-18 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 port new setting code to Sun C 5.8 2005/10/13
3036 * chartab.c, lisp.h (char_table_set, char_table_set_range):
3037 Return void, not Lisp_Object. Otherwise, the compiler
3038 complains about (A?B:C) where B is void and C is Lisp_Object
3039 when compiling CHAR_TABLE_SET, due to the recent change to
3040 the API of sub_char_table_set_contents.
3041
a999ce26
CY
30422012-08-18 Chong Yidong <cyd@gnu.org>
3043
3044 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
3045 for the string case (Bug#3874).
3046
3f22b86f
PE
30472012-08-18 Paul Eggert <eggert@cs.ucla.edu>
3048
39eb03f1
PE
3049 * buffer.h (BSET): Remove (Bug#12215).
3050 Replace all uses with calls to new setter functions.
3051 (bset_bidi_paragraph_direction, bset_case_canon_table)
3052 (bset_case_eqv_table, bset_directory, bset_display_count)
3053 (bset_display_time, bset_downcase_table)
3054 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
3055 (bset_last_selected_window, bset_local_var_alist)
3056 (bset_mark_active, bset_point_before_scroll, bset_read_only)
3057 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
3058 (bset_width_table):
3059 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
3060 (bset_auto_fill_function, bset_auto_save_file_format)
3061 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
3062 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
3063 (bset_cache_long_line_scans, bset_case_fold_search)
3064 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
3065 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
3066 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
3067 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
3068 (bset_header_line_format, bset_indicate_buffer_boundaries)
3069 (bset_indicate_empty_lines, bset_invisibility_spec)
3070 (bset_left_fringe_width, bset_major_mode, bset_mark)
3071 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
3072 (bset_name, bset_overwrite_mode, bset_pt_marker)
3073 (bset_right_fringe_width, bset_save_length)
3074 (bset_scroll_bar_width, bset_scroll_down_aggressively)
3075 (bset_scroll_up_aggressively, bset_selective_display)
3076 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
3077 (bset_word_wrap, bset_zv_marker):
3078 * category.c (bset_category_table):
3079 * syntax.c (bset_syntax_table):
3080 New setter functions.
3081
6a09a33b
PE
3082 * process.h (PSET): Remove (Bug#12215).
3083 Replace all uses with calls to new setter functions.
3084 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3085 (PROCESS_INLINE): New macro.
3086 (pset_childp): New setter function.
3087 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
3088 * process.c (PROCESS_INLINE):
3089 Define to EXTERN_INLINE, so that the corresponding functions
3090 are compiled into code.
3091 (pset_buffer, pset_command, pset_decode_coding_system)
3092 (pset_decoding_buf, pset_encode_coding_system)
3093 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
3094 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
3095 (pset_type, pset_write_queue): New setter functions.
3096
e8c17b81
PE
3097 * window.h (WSET): Remove (Bug#12215).
3098 Replace all uses with calls to new setter functions.
3099 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3100 (WINDOW_INLINE): New macro.
3101 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
3102 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
3103 (wset_total_lines, wset_vertical_scroll_bar)
3104 (wset_window_end_pos, wset_window_end_valid)
3105 (wset_window_end_vpos): New setter functions.
3106 * window.c (WINDOW_INLINE):
3107 Define to EXTERN_INLINE, so that the corresponding functions
3108 are compiled into code.
3109 (wset_combination_limit, wset_dedicated, wset_display_table)
3110 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
3111 (wset_new_normal, wset_new_total, wset_next_buffers)
3112 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
3113 (wset_prev_buffers, wset_right_fringe_width)
3114 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
3115 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
3116 (wset_window_parameters):
3117 * xdisp.c (wset_base_line_number, wset_base_line_pos)
3118 (wset_column_number_displayed, wset_region_showing):
3119 New setter functions.
3120
3f22b86f
PE
3121 * termhooks.h (TSET): Remove (Bug#12215).
3122 Replace all uses with calls to new setter functions.
3123 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3124 (TERMHOOKS_INLINE): New macro.
3125 (tset_charset_list, tset_selection_alist): New setter functions.
3126 * terminal.c (TERMHOOKS_INLINE):
3127 Define to EXTERN_INLINE, so that the corresponding functions
3128 are compiled into code.
3129 (tset_param_alist): New setter function.
3130
742af32f
PE
31312012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3132
15dbb4d6
PE
3133 * keyboard.h (KSET): Remove (Bug#12215).
3134 Replace all uses with calls to new setter functions.
3135 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3136 (KEYBOARD_INLINE): New macro.
3137 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
3138 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
3139 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
3140 New setter functions.
3141 * keyboard.c (KEYBOARD_INLINE):
3142 Define to EXTERN_INLINE, so that the corresponding functions
3143 are compiled into code.
3144 (kset_echo_string, kset_kbd_queue)
3145 (kset_keyboard_translate_table, kset_last_prefix_arg)
3146 (kset_last_repeatable_command, kset_local_function_key_map)
3147 (kset_overriding_terminal_local_map, kset_real_last_command)
3148 (kset_system_key_syms): New setter functions.
3149
f00af5b1
PE
3150 * frame.h (FSET): Remove (Bug#12215).
3151 Replace all uses with calls to new setter functions.
3152 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3153 (FRAME_INLINE): New macro.
3154 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
3155 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
3156 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
3157 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
3158 (fset_param_alist, fset_root_window, fset_scroll_bars)
3159 (fset_selected_window, fset_title, fset_tool_bar_items)
3160 (fset_tool_bar_position, fset_tool_bar_window): New functions.
3161 * frame.c (FRAME_INLINE):
3162 Define to EXTERN_INLINE, so that the corresponding functions
3163 are compiled into code.
3164 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
3165
0c94c8d6
PE
3166 A few more naming-convention fixes for getters and setters.
3167 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
3168 and rename from buffer_overlays_set_before.
3169 (set_buffer_overlays_after): Move here from buffer.h, and rename
3170 from buffer_overlays_set_after.
3171 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
3172 All uses changed.
3173 (set_buffer_intervals): Rename from buffer_set_intervals.
3174 * intervals.c (set_interval_object): Move here from intervals.h,
3175 and rename from interval_set_object.
3176 (set_interval_left): Move here from intervals.h, and rename from
3177 interval_set_left.
3178 (set_interval_right): Move here from intervals.h, and rename from
3179 interval_set_right.
3180 (copy_interval_parent): Move here from intervals.h, and rename from
3181 interval_copy_parent.
3182 * intervals.h (set_interval_parent): Rename from interval_set_parent.
3183 (set_interval_plist): Rename from interval_set_plist.
3184 Return void, not Lisp_Object, since no caller uses the result.
3185 * lisp.h (string_intervals): Rename from string_get_intervals.
3186 (set_string_intervals): Rename from string_set_intervals.
3187
34dabdb7
PE
3188 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
3189 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 3190 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
3191 All uses changed. See the end of
3192 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
3193
742af32f
PE
3194 * lisp.h (CSET): Remove (Bug#12215).
3195 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
3196 (set_char_table_purpose): New functions,
3197 replacing CSET. All uses changed. For example, replace
3198 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 3199 "set_char_table_parent (char_table, parent);".
742af32f
PE
3200 The old version was confusing because it used the same name
3201 'parent' for two different things.
3202
a04e2c62
DA
32032012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
3204
3205 Functions to get and set Lisp_Object fields of buffer-local variables.
3206 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
3207 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
3208 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
3209 * data.c, eval.c, frame.c: Adjust users.
3210
383dcbf9
CY
32112012-08-17 Chong Yidong <cyd@gnu.org>
3212
3213 * xfaces.c (merge_face_vectors): If the target font specfies a
3214 font spec, make the font's attributes take precedence over
3215 directly-specified attributes.
3216 (merge_face_ref): Recognize :font.
3217
44386687
DA
32182012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
3219
3220 Do not use memcpy for copying intervals.
3221 * intervals.c (reproduce_interval): New function.
3222 (reproduce_tree, reproduce_tree_obj): Use it.
3223 (reproduce_tree_obj): Remove prototype.
3224
927c7216
PE
32252012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 * lisp.h (duration_to_sec_usec): Remove unused decl.
3228
93044f7b
AA
32292012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
3230
3231 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
3232 to an allocated instance of NSString, not to the class itself.
3233
9851e4a5
JB
32342012-08-17 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * makefile.w32-in (C_CTYPE_H): New macro.
3237 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
3238 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
3239 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
3240
620f13b0
PE
32412012-08-16 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 Use ASCII tests for character types.
3244 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
3245 * xfns.c, xterm.c:
3246 Don't include <ctype.h>; was not needed.
3247 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
3248 * sysdep.c, xfaces.c:
3249 Include <c-ctype.h> instead of <ctype.h>.
3250 * nsterm.m: Include <c-ctype.h>.
3251 * charset.c (read_hex):
3252 * doc.c (Fsnarf_documentation):
3253 * fileio.c (IS_DRIVE) [WINDOWSNT]:
3254 (DRIVE_LETTER) [DOS_NT]:
3255 (Ffile_name_directory, Fexpand_file_name)
3256 (Fsubstitute_in_file_name):
3257 * font.c (font_parse_xlfd, font_parse_fcname):
3258 * frame.c (x_set_font_backend):
3259 * gtkutil.c (xg_get_font):
3260 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
3261 * nsimage.m (hexchar):
3262 * nsterm.m (ns_xlfd_to_fontname):
3263 * sysdep.c (system_process_attributes):
3264 * xfaces.c (hash_string_case_insensitive):
3265 Use C-locale tests instead of locale-specific tests for character
3266 types, since we want the ASCII interpretation here, not the
3267 interpretation suitable for whatever happens to be the current locale.
3268
52162052
MR
32692012-08-16 Martin Rudalics <rudalics@gmx.at>
3270
3271 Consistently check windows for validity/liveness
3272 (Bug#11984, Bug#12025, Bug#12026).
3273 * lisp.h (CHECK_VALID_WINDOW): New macro.
3274 * window.c (decode_window): Rename to decode_live_window.
3275 (decode_valid_window, Fwindow_valid_p): New functions.
3276 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
3277 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
3278 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
3279 (Fwindow_prev_sibling, Fwindow_combination_limit)
3280 (Fset_window_combination_limit, Fwindow_use_time)
3281 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
3282 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
3283 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
3284 (Fwindow_hscroll, Fset_window_hscroll)
3285 (Fwindow_redisplay_end_trigger)
3286 (Fset_window_redisplay_end_trigger, Fwindow_edges)
3287 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
3288 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3289 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
3290 (Fwindow_end, Fset_window_point, Fset_window_start)
3291 (Fpos_visible_in_window_p, Fwindow_line_height)
3292 (Fwindow_dedicated_p, Fset_window_dedicated_p)
3293 (Fwindow_prev_buffers, Fset_window_prev_buffers)
3294 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
3295 (Fset_window_parameter, Fwindow_display_table)
3296 (Fset_window_display_table, Fdelete_other_windows_internal)
3297 (Fset_window_buffer, Fset_window_new_total)
3298 (Fset_window_new_normal, Fdelete_window_internal)
3299 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
3300 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
3301 (Fwindow_scroll_bars): Check whether argument window is a valid or
3302 live window. Update doc-strings.
3303 (syms_of_window): New symbol Qwindow_valid_p.
3304 * keyboard.c (Fposn_at_x_y): Check whether argument
3305 frame_or_window denotes a valid window.
3306
2751c80f
DA
33072012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3308
3309 Fix previous char table change.
3310 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
3311 * chartab.c (optimize_sub_char_table): Likewise.
3312
032a42c8
CY
33132012-08-16 Chong Yidong <cyd@gnu.org>
3314
a2d19368
CY
3315 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
3316
032a42c8
CY
3317 * xfont.c (xfont_open):
3318 * xftfont.c (xftfont_open): Set the font's max_width field.
3319
3320 * nsfont.m (nsfont_open): Similar to the Xft backend, set
3321 min_width to space_width and average_width to the average over
3322 printable ASCII characters.
3323 (ns_char_width): Code cleanup.
3324 (ns_ascii_average_width): New utility function.
3325
3326 * font.h (struct font): Update comments.
3327
a098c930
DA
33282012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3329
032a42c8 3330 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
3331 * lisp.h (CSET): New macro.
3332 (char_table_set_extras, char_table_set_contents)
3333 (sub_char_table_set_contents): New function.
3334 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
3335 * syntax.c: Adjust users.
3336
8be3a09c
SM
33372012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
3338
3339 * eval.c (eval_sub): Bind lexical-binding.
3340 * lread.c (Qlexical_binding): Make non-static.
3341
ac4845a6
JD
33422012-08-15 Jan Djärv <jan.h.d@swipnet.se>
3343
ddee6515
JD
3344 * nsmenu.m (popupSession): Remove.
3345 (pop_down_menu): Remove endModalSession.
3346 (timeout_handler:): New method.
3347 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
3348 Call runModalForWindow. Check timer_fired when it returns.
3349 If not set, cancel timer and break out of loop.
3350 Otherwise loop again, with a new timeout.
3351
3352 * nsterm.m: Include fcntl.h if present.
3353 (fd_entry, t_readfds, inNsSelect): Remove.
3354 (select_writefds, select_valid, select_timeout, selfds)
3355 (select_mutex, apploopnr): Add.
3356 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
3357 Otherwise call kbd_buffer_store_event.
3358 (ns_send_appdefined): Remove release of fd_entry.
3359 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
3360 Increment and decrement apploopnr.
3361 (ns_select): If no file descriptors, just do a NSTimer.
3362 Otherwise copy read/write masks and start select thread (fd_handler).
3363 Start main loop and wait for application defined event.
3364 Inform select thread to stop selecting after main loop is exited.
3365 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 3366 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
3367 (fd_handler:): Loop forever, wait for info from the main thread
3368 to either start or stop selecting. When select returns, send
3369 and appdefined event.
3370 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
3371 If not call kbd_buffer_store_event.
3372
3373 * nsterm.h (EmacsApp): fd_handler takes id argument.
3374 (EmacsDialogPanel): Add timer_fired and timeout_handler.
3375
ac4845a6
JD
3376 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
3377
eb424fe3
EZ
33782012-08-15 Eli Zaretskii <eliz@gnu.org>
3379
3380 * region-cache.c (move_cache_gap): Update gap_len using the actual
3381 growth of the boundaries array. Do not change cache_len.
3382 (Bug#12196)
3383
4e6a86c6
DA
33842012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3385
3386 Generalize and cleanup font subsystem checks.
3387 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
3388 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
3389 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 3390
5bf192ca
DA
33912012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3392
3393 * gtkutil.c (xg_get_font): Use pango_units_to_double.
3394
f2045622
CY
33952012-08-15 Chong Yidong <cyd@gnu.org>
3396
8be3a09c
SM
3397 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
3398 When using the new font chooser, use gtk_font_chooser_get_font_desc to
3399 extract the font descriptor instead of just the font name.
3400 In that case, return a font spec instead of a string.
f2045622
CY
3401 (x_last_font_name): Move to this file from xfns.c.
3402
3403 * xfns.c (Fx_select_font): The return value can also be a font
3404 spec. Move x_last_font_name management to gtkutil.c.
3405
3406 * xfaces.c: Make font weight and style symbols non-static.
3407
7f6feb56
SM
34082012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
3409
3410 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
3411 (bug#12117).
3412
fecbd8ff
SM
34132012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
3414
3415 * alloc.c (Fgarbage_collect): Use plural form consistently.
3416
9b8d5165
EZ
34172012-08-14 Eli Zaretskii <eliz@gnu.org>
3418
3419 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
3420 iteration through the command loop. Fixes a problem whereby mouse
3421 movements are ignored until the first mouse click.
3422
f5d9e83a
PE
34232012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3424
3425 Use bool, not int, for Lisp booleans.
3426 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
3427 makes Emacs a bit smaller and presumably a bit faster.
3428 * lisp.h: Include <stdbool.h>.
3429 (struct Lisp_Boolfwd, defvar_bool):
3430 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
3431 * regex.c [!emacs]: Include <stdbool.h>.
3432 (false, true): Remove; <stdbool.h> does this for us now.
3433
55802e4a
CY
34342012-08-14 Chong Yidong <cyd@gnu.org>
3435
4abcdac8
CY
3436 * character.c (Fcharacterp): Doc fix (Bug#12076).
3437
3438 * data.c (Findirect_variable): Doc fix (Bug#11040).
3439
55802e4a
CY
3440 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
3441
3442 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 3443 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 3444
8e99d072
BR
34452012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3446
3447 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
3448 (bug#12022).
3449
08908aca
MR
34502012-08-14 Martin Rudalics <rudalics@gmx.at>
3451
3452 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
3453 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
3454 * minibuf.c (choose_minibuf_frame, read_minibuf):
3455 * w32fns.c (x_create_tip_frame):
3456 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
3457 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
3458
56120d6f
PE
34592012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * intervals.c (offset_intervals): Remove obsolete comment.
3462
67b77c0b
AS
34632012-08-14 Andreas Schwab <schwab@linux-m68k.org>
3464
3465 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
3466
f48b82fd
GR
34672012-08-14 Gergely Risko <gergely@risko.hu>
3468
3469 * coding.c (decode_coding): Record buffer modification before
3470 disabling undo_list (Bug#11773).
3471
fd318b54
DA
34722012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3473
3474 Revert and cleanup some recent overlay changes.
3475 * buffer.h (enum overlay_type): Remove.
3476 (buffer_get_overlays, buffer_set_overlays): Likewise.
3477 (buffer_set_overlays_before, buffer_set_overlays_after):
3478 New function. Adjust users.
3479 (unchain_both): Add eassert.
3480
41a62dd9
DA
34812012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3482
3483 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
3484
5884c324
PE
34852012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3486
3487 * gtkutil.c (xg_mark_data): Don't assume C99.
3488
ca06f160
JD
34892012-08-13 Jan Djärv <jan.h.d@swipnet.se>
3490
3491 * gtkutil.c (xg_frame_tb_info): New struct.
3492 (TB_INFO_KEY): New define.
3493 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
3494 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
3495 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
3496 if not present.
3497 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 3498 is up to date. Otherwise store new data.
ca06f160
JD
3499 (free_frame_tool_bar): Free xg_frame_tb_info if present.
3500
7864a3f7
DA
35012012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3502
3503 Use KSET for write access to Lisp_Object members of struct kboard.
3504 * keyboard.h (KSET): New macro.
3505 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
3506 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
3507 * xterm.c: Adjust users.
3508
4c31be61
DA
35092012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3510
3511 Use BSET for write access to Lisp_Object members of struct buffer.
3512 * buffer.h (BSET): New macro.
3513 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
3514 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
3515 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
3516 * window.c, xdisp.c, xfns.c: Adjust users.
3517
14ae4239
BT
35182012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
3519
3520 * lread.c (syms_of_lread): Initialize Vlexical_binding.
3521
32bcadb4
JD
35222012-08-11 Jan Djärv <jan.h.d@swipnet.se>
3523
3d29b2ce 3524 * nsterm.m (not_in_argv): New function.
fc0c31f8 3525 (application:openFile, application:openTempFile:):
3d29b2ce
JD
3526 (application:openFileWithoutUI:, application:openFiles:): Open file
3527 if not_in_argv returns non-zero (bug#12171).
3528
32bcadb4 3529 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
3530 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
3531 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
3532 (xg_get_font_name): Use those functions/macros here.
3533 Reported by Frans Oilinki <moilinki@gmail.com>.
3534
9ff9402d 35352012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
3536
3537 * unexmacosx.c (copy_data_segment): Copy initialized data in
3538 statically linked libraries from input file rather than memory.
3539
db74a5fc
YM
3540 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
3541 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
3542 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
3543
25e65510
GM
35442012-08-10 Glenn Morris <rgm@gnu.org>
3545
3546 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
3547 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
3548
7961135c
DA
35492012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3550
3551 Fix last change to allow compilation with low optimization levels.
3552 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
3553 Reported by Jan Djärv <jan.h.d@swipnet.se>.
3554
42b3a444
DA
35552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3556
3557 Use common inline syntax in intervals.h.
3558 * intervals.h (INTERVALS_INLINE): New macro.
3559 Change all users from LISP_INLINE.
3560
9fb0c957
DA
35612012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3562
3563 Define Qnone once for all platforms.
3564 * frame.c (Qnone): Define here.
3565 (syms_of_frame): DEFSYM it.
3566 * lisp.h (Qnone): New declaration.
3567 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
3568 * xfns.c: Remove duplication. Adjust users.
3569
65e8ee52
DA
35702012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3571
3572 Remove unused macros from intervals.h.
3573 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
3574 * intervals.c: Adjust comment.
3575
9b855fd6
EZ
35762012-08-10 Eli Zaretskii <eliz@gnu.org>
3577
3578 * w32fns.c <w32_unicode_gui>: New static variable.
3579 (globals_of_w32fns): Initialize it according to os_subtype.
3580 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
3581 testing os_subtype.
3582
39cb9e56 35832012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
3584 Eli Zaretskii <eliz@gnu.org>
3585
3586 Fix bug #10299 with Unicode characters sent by customized
3587 keyboards created by MSKLC.
3588 * w32fns.c (INIT_WINDOW_CLASS): New macro.
3589 (w32_init_class): Use it to initialize the Emacs class with either
3590 ANSI or Unicode API calls.
3591 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
3592 later.
3593 (w32_wnd_proc): If the character code sent by WM_CHAR or
3594 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
3595 original message. Call DefWindowProcW on NT and later.
3596
9374581a
GM
35972012-08-10 Glenn Morris <rgm@gnu.org>
3598
4b94e8cf
GM
3599 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
3600
9374581a
GM
3601 * lisp.h (DIRECTORY_SEP): Let configure set it.
3602
a2752828
DA
36032012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
3604
3605 Use TSET for write access to Lisp_Object slots of struct terminal.
3606 * termhooks.h (TSET): New macro.
3607 * coding.c, terminal.c, xselect.c: Adjust users.
3608
cc92c454
SM
36092012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
3610
3611 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
3612 the failing expression, include them in the error message.
3613 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
3614 * lisp.h (internal_condition_case_n): Update declaration.
3615
4cb3e6b3
DA
36162012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3617
3618 Inline functions to examine and change buffer overlays.
3619 * buffer.c (unchain_both): New function.
3620 * buffer.h (buffer_get_overlays, buffer_set_overlays):
3621 (buffer_has_overlays): New function.
3622 (enum overlay_type): New enum.
3623 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
3624 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
3625
8707c1e5
DA
36262012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3627
3628 Inline functions to examine and change buffer intervals.
3629 * alloc.c (mark_interval_tree): Remove.
3630 (MARK_INTERVAL_TREE): Simplify.
3631 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
3632 * intervals.c (buffer_balance_intervals): New function.
3633 (graft_intervals_into_buffer): Adjust indentation.
3634 (set_intervals_multibyte): Simplify.
3635 * buffer.h (BUF_INTERVALS): Remove.
3636 (buffer_get_intervals, buffer_set_intervals): New function.
3637 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
3638 * intervals.c, textprop.c: Adjust users.
3639
ad8c997f
DA
36402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3641
3642 Inline functions to examine and change string intervals.
3643 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
3644 (string_get_intervals, string_set_intervals): New function.
3645 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3646 * lread.c, print.c, textprop.c: Adjust users.
3647
32ac3a6b
GM
36482012-08-08 Glenn Morris <rgm@gnu.org>
3649
3650 * lisp.mk (lisp): Remove language/persian.elc.
3651
77c7bcb1
DA
36522012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3653
3654 Cleanup intervals.
3655 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
3656 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
3657 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
3658 Adjust comment. Move under #if 0.
77c7bcb1
DA
3659 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3660 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
3661
9c08a8d4
DA
36622012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3663
3664 Check total length of intervals with eassert.
3665 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
3666 * intervals.c: Change all users to eassert.
3667
26d16b35
EZ
36682012-08-07 Eli Zaretskii <eliz@gnu.org>
3669
14ae4239
BT
3670 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
3671 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
3672 INTERNAL_FIELD in Lisp_Cons.
3673
c644523b
DA
36742012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3675
3676 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
3677 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
3678 name since all xname users are fixed long time ago. Do not
3679 use INTERNAL_FIELD.
3680 (set_symbol_name, set_symbol_function, set_symbol_plist):
3681 (set_symbol_next, set_overlay_plist): New function.
3682 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
3683 (struct Lisp_Overlay): Likewise.
3684 (CVAR, MVAR, SVAR): Remove.
3685 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
3686 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
3687 * xterm.c: Adjust users.
3688 * .gdbinit: Change to use name field of struct Lisp_Symbol
3689 where appropriate.
3690
6a3d20cc
DA
36912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3692
3693 Basic functions to set Lisp_Object and pointer slots of intervals.
3694 * intervals.h (interval_set_parent, interval_set_object):
3695 (interval_set_left, interval_set_right, interval_set_plist):
3696 (interval_copy_parent): New function.
3697 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
3698 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
3699 Adjust indentation.
6a3d20cc
DA
3700 (INTERVAL_SIZE): Remove. Adjust users.
3701 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
3702
4d2b044c
DA
37032012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3704
3705 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
3706 * process.h (PGET): Remove.
3707 (struct Lisp_Process): Do not use INTERNAL_FIELD.
3708 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3709
d3d50620
DA
37102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3711
3712 Drop WGET and revert read access to Lisp_Objects slots of struct window.
3713 * window.h (WGET): Remove.
3714 (struct window): Do not use INTERNAL_FIELD.
3715 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3716 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3717 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3718 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3719 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3720 Adjust users.
3721
d10a51dc
CY
37222012-08-07 Chong Yidong <cyd@gnu.org>
3723
3724 * window.c (Fwindow_edges, Fwindow_pixel_edges)
3725 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
3726 (Fdelete_window_internal): Signal an error if the window is not on
3727 a live frame (Bug#12025).
3728
e69b0960
DA
37292012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3730
3731 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
3732 * frame.h (FGET): Remove.
3733 (struct frame): Do not use INTERNAL_FIELD.
3734 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3735 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3736 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3737 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3738
25a20a3a
JB
37392012-08-06 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * w32.c: Silence compiler warnings.
3742 (map_w32_filename): Remove unused variable `is_fat'.
3743 (chase_symlinks): Add parentheses around expression.
3744
1c6f11f4
GM
37452012-08-06 Glenn Morris <rgm@gnu.org>
3746
1db4583a
GM
3747 * sysdep.c: Respect BROKEN_GETWD.
3748
1c6f11f4
GM
3749 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3750 Let configure handle it.
3751 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3752
2b90362b
DA
37532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3754
3755 Use GCALIGNMENT where appropriate.
3756 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3757 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3758 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3759
5f50daf2
EZ
37602012-08-06 Eli Zaretskii <eliz@gnu.org>
3761
14ae4239
BT
3762 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3763 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3764
cbcc7007
SM
37652012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3766
3767 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3768 that should be sufficient for everyone.
3769
4d365fa4
JD
37702012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3771
3772 * keyboard.c (timer_check_2): Add break so timer_check returns next
3773 timeout.
3774
dd86bd82
DA
37752012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3776
3777 Fix Windows build errors introduced after converting to WGET and WSET.
3778 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3779 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3780
054e1668
JD
37812012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3782
3783 * nsterm.m (ns_frame_rehighlight): Use FSET.
3784
3785 * nsmenu.m (ns_update_menubar): Use FSET.
3786
21238f11
DA
37872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3788
3789 Separate read and write access to Lisp_Object slots of Lisp_Process.
3790 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3791 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3792
077288cf
DA
37932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3794
3795 Separate read and write access to Lisp_Object slots of struct window.
3796 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3797 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3798 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3799 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3800 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3801 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3802 Adjust users.
3803
71688bd7
DA
38042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3805
3806 Fix Windows build errors introduced after converting to FGET and FSET.
3807 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3808 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3809 (w32_judge_scroll_bars): Change to use FSET.
3810 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3811
f99bac93
DA
38122012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3813
3814 Fix replacement typo.
3815 * window.c (replace_window): Set root_window instead of
3816 selected_window. This fixes a total window subsystem
3817 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3818
8c2a0f2d
GM
38192012-08-06 Glenn Morris <rgm@gnu.org>
3820
3821 * lisp.mk (lisp): Add language/persian.elc.
3822
edd74c35
DA
38232012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3824
3825 Separate read and write access to Lisp_Object slots of struct frame.
3826 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3827 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3828 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3829 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3830 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3831
8671676c
AS
38322012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3833
3834 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3835
663e2b3f
DA
38362012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3837
3838 Generalize common compile-time constants.
3839 * lisp.h (header_size, bool_header_size, word_size): Now here.
3840 (struct Lisp_Vector): Add comment.
3841 (struct Lisp_Bool_Vector): Move up to define handy constants.
3842 (VECSIZE, PSEUDOVECSIZE): Simplify.
3843 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3844 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3845 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3846 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3847 * xfont.c, xmenu.c: Use word_size where appropriate.
3848
d32e47af
LM
38492012-08-05 Lawrence Mitchell <wence@gmx.li>
3850
3851 * search.c (Freplace_match): Treat \? in the replacement text
3852 literally (Bug#8161).
3853
e5d9c0d1
CY
38542012-08-05 Chong Yidong <cyd@gnu.org>
3855
3856 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3857 * frame.c (Vdelete_frame_functions):
3858 * emacs.c (Vkill_emacs_hook): Doc fix.
3859
8da0576b
EZ
38602012-08-04 Eli Zaretskii <eliz@gnu.org>
3861
3862 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3863 --with-x-toolkit=no builds.
3864 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3865
02676e5d
CY
38662012-08-04 Chong Yidong <cyd@gnu.org>
3867
3868 * syntax.c (Fmodify_syntax_entry): Doc fix.
3869
97147da9
EZ
38702012-08-04 Eli Zaretskii <eliz@gnu.org>
3871
76151e2c
EZ
3872 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3873 * w32.c (init_environment): Change the default values of many
3874 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3875 them into environment when they were not already defined.
3876 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3877 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3878 (check_windows_init_file): Now external, not static.
3879 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3880 called when Vload_path is already set up.
3881
3882 * w32.h (check_windows_init_file): Add prototype.
3883
3884 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3885 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3886 compatibility with Posix platforms.
3887 (main): Move the call to check_windows_init_file to here from
3888 w32.c.
3889 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3890 any, in the DEFALT argument into the root of the Emacs build or
3891 installation tree, as appropriate.
3892
3893 * callproc.c (init_callproc_1): Call decode_env_path instead of
3894 doing its equivalent by hand.
3895 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3896 the code that sets Vexec_path run on MS-Windows.
3897
3898 * lread.c (init_lread): Add comments to #ifdef's.
3899
97147da9
EZ
3900 * msdos.c (dos_set_window_size, IT_update_begin)
3901 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3902 instead of direct references.
3903
185ee146
PE
39042012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3905
3906 Export DEFAULT_REHASH_* to GDB.
3907 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3908 Now constants, not macros.
3909
8834c57a
PE
39102012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3911
98c6f1e3
PE
3912 Remove unnecessary casts involving pointers.
3913 These casts are no longer needed now that we assume C89 or later,
3914 since they involve casting to or from void *.
3915 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3916 (make_pure_float, make_pure_vector):
3917 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3918 * macros.c (Fstart_kbd_macro):
3919 * menu.c (find_and_return_menu_selection):
3920 * minibuf.c (read_minibuf_noninteractive):
3921 * sysdep.c (closedir):
3922 * xdisp.c (x_produce_glyphs):
3923 * xfaces.c (compare_fonts_by_sort_order):
3924 * xfns.c (x_real_positions, select_visual):
3925 * xselect.c (x_stop_queuing_selection_requests)
3926 (x_get_window_property, x_get_window_property_as_lisp_data):
3927 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3928 Remove unnecessary pointer casts.
3929 * alloc.c (record_xmalloc): New function.
3930 * lisp.h (record_xmalloc): New decl.
3931 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3932 more like a function. This is because the pointer cast is not
3933 needed. All uses changed.
3934 * print.c (print_string, print_error_message): Avoid length recalc.
3935
8834c57a
PE
3936 Improve fix for macroexp crash with debugging (Bug#12118).
3937 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3938 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3939 not supposed to be invoked from the garbage collector.
3940 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3941 (gc_aset): New function, which is like ASET but can be
3942 used in the garbage collector.
3943 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3944 (set_hash_index): Use it instead of ASET.
3945
6dad7178
EZ
39462012-08-03 Eli Zaretskii <eliz@gnu.org>
3947
3948 Support symlinks on latest versions of MS-Windows.
3949 * w32.c: Include winioctl.h and aclapi.h.
3950 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3951 (revert_to_self): Forward declarations of static functions.
3952 <static BOOL g_b_init_get_security_info>:
3953 <g_b_init_create_symbolic_link>: New static flags.
3954 (globals_of_w32): Initialize them to zero.
3955 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3956 (map_w32_filename): Improve commentary. Simplify switch.
3957 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3958 headers (most versions of MinGW w32api don't).
3959 (get_security_info, create_symbolic_link)
3960 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3961 New functions.
3962 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3963 in the argument file name.
3964 (sys_access): Call unc_volume_file_attributes only if
3965 GetFileAttributes fails with network-related error codes.
3966 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3967 have the required privileges.
14ae4239 3968 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3969 get_file_security_desc.
3970 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3971 with addition of handling of symlinks and support for 'lstat'.
3972 If possible, get file's attributes and security information by
6dad7178
EZ
3973 handle, not by name. Produce S_IFLNK bit for symlinks, when
3974 called from 'lstat'.
3975 (stat, lstat): New functions, call 'stat_worker'.
3976 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3977 symlinks when the underlying filesystem supports them.
3978
f162bcc3
PE
39792012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3980
79ea6c20
PE
3981 Fix macroexp crash on Windows with debugging (Bug#12118).
3982 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3983 checking subscripts; problem introduced with the recent
3984 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3985 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3986 since it's used in non-static inline functions now.
3987
c0ce93fd
PE
3988 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3989 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3990
f162bcc3
PE
3991 Use C99-style 'extern inline' if available.
3992 * buffer.h (BUFFER_INLINE):
3993 * category.h (CATEGORY_INLINE):
3994 * character.h (CHARACTER_INLINE):
3995 * charset.h (CHARSET_INLINE):
3996 * composite.h (COMPOSITE_INLINE):
3997 * dispextern.h (DISPEXTERN_INLINE):
3998 * lisp.h (LISP_INLINE):
3999 * systime.h (SYSTIME_INLINE):
4000 New macro, replacing 'static inline' in this header.
4001 * buffer.h, category.h, character.h, charset.h, composite.h:
4002 * dispextern.h, lisp.h, systime.h:
4003 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4004 * alloc.c (LISP_INLINE):
4005 * buffer.c (BUFFER_INLINE):
4006 * category.c (CATEGORY_INLINE):
4007 * character.c (CHARACTER_INLINE):
4008 * charset.c (CHARSET_INLINE):
4009 * composite.c (COMPOSITE_INLINE):
4010 * dispnew.c (DISPEXTERN_INLINE):
4011 * sysdep.c (SYSTIME_INLINE):
4012 Define to EXTERN_INLINE, so that the corresponding functions
4013 are compiled into code.
4014 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
4015 (INLINE_HEADER_END): New macros.
4016 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
4017 since it's used in non-static inline functions now.
a8333d03 4018 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 4019
837b365b
GM
40202012-08-02 Glenn Morris <rgm@gnu.org>
4021
d66b744d
GM
4022 * s/: Remove empty directory.
4023
837b365b
GM
4024 * s/ms-w32.h: Move to ../nt/inc.
4025 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
4026 Update for new ms-w32.h location.
4027
13294f95
PE
40282012-08-02 Paul Eggert <eggert@cs.ucla.edu>
4029
4030 Port to Solaris 8.
4031 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
4032
90df0db3
GM
40332012-08-02 Glenn Morris <rgm@gnu.org>
4034
4035 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
4036 hard-coding the path separator.
4037
4939150c
PE
40382012-08-01 Paul Eggert <eggert@cs.ucla.edu>
4039
4040 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
4041 This how ASET and AREF are supposed to work, and makes
4042 it easier to think about future improvements. See
4043 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
4044 * charset.h (set_charset_attr): New function.
4045 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
4046 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
4047 (aref_addr): New function. All uses of &AREF(...) changed.
4048 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
4049 (set_hash_index): New functions. All lvalue-style uses of
4050 HASH_KEY etc. changed.
4051 * keyboard.c (set_prop): New function. All lvalue-style uses
4052 of PROP changed.
4053
947b2afd
AA
40542012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
4055
4056 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
4057 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
4058 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
4059 * nsfns.m (ns_set_name_as_filename): Likewise.
4060 * nsmenu.m (ns_update_menubar): Likewise.
4061 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
4062
4f5d0325
EZ
40632012-08-01 Eli Zaretskii <eliz@gnu.org>
4064
2008beae
EZ
4065 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
4066 Adapt to latest changes in field names of the corresponding Lisp
288479f6 4067 objects.
2008beae 4068
4f5d0325
EZ
4069 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
4070
fe3cc771
GM
40712012-08-01 Glenn Morris <rgm@gnu.org>
4072
4073 * s/msdos.h: Remove file.
4074 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
4075 * Makefile.in (S_FILE): Remove.
4076 (config_h): Remove S_FILE.
4077
c90acc54
JB
40782012-08-01 Juanma Barranquero <lekktu@gmail.com>
4079
4080 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
4081 Remove; moved to nt/config.nt.
4082
d8a05828
DA
40832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4084
4085 Use INTERNAL_FIELD for conses and overlays.
4086 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
4087 Remove obsolete comment.
4088 (MVAR): New macro.
4089 (struct Lisp_Overlay): Use INTERNAL_FIELD.
4090 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
4091
8271d590
DA
40922012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4093
4094 Use INTERNAL_FIELD for symbols.
4095 * lisp.h (SVAR): New macro. Adjust users.
4096 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
4097 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
4098
3193acd2
DA
40992012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4100
4101 Use INTERNAL_FIELD for processes.
4102 * process.h (PVAR): New macro. Adjust style.
4103 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
4104 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
4105
3a45383a
DA
41062012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4107
4108 Use INTERNAL_FIELD for windows.
4109 * window.h (WVAR): New macro.
4110 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
4111 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
4112 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
4113 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
4114 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
4115 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
4116
c1dbc63c
PE
41172012-08-01 Paul Eggert <eggert@cs.ucla.edu>
4118
4119 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
4120
5c0c0e8a
GM
41212012-08-01 Glenn Morris <rgm@gnu.org>
4122
4123 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
4124 Move to configure.ac.
4125
552a99b4
JB
41262012-08-01 Juanma Barranquero <lekktu@gmail.com>
4127
4128 * makefile.w32-in (CONFIG_H): Update dependencies.
4129 (CONF_POST_H): New macro.
4130
4131 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
4132
8d8e2dfe
GM
41332012-07-31 Glenn Morris <rgm@gnu.org>
4134
bc96620a
GM
4135 * Makefile.in (S_FILE): No longer set by configure.
4136
476b1b2d
GM
4137 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
4138 is available.
4139 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
4140
b2c7a106
GM
4141 * process.h (NULL_DEVICE):
4142 * emacs.c (SEPCHAR):
4143 * editfns.c (USER_FULL_NAME): Let configure set them.
4144
d53d062a
GM
4145 * s/README, s/template.h: Remove files.
4146
4515017f
GM
4147 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
4148
8d8e2dfe
GM
4149 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
4150 Move to configure.ac.
4151
5b20b3cc
EZ
41522012-07-31 Eli Zaretskii <eliz@gnu.org>
4153
1e0afd9a
EZ
4154 * .gdbinit (xframe): Adapt to introduction of FVAR and the
4155 resulting renaming of 'struct frame' members.
4156
5b20b3cc
EZ
4157 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
4158
4159 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
4160 after introduction of FVAR.
4161
f1310128
JD
41622012-07-31 Jan Djärv <jan.h.d@swipnet.se>
4163
79e721e0
JD
4164 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
4165
4166 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
4167 instead of compositeToPoint.
4168 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
4169
8d7c7eed 4170 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 4171
e34f7f79
DA
41722012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
4173
4174 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
4175 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 4176 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
4177 (BVAR): Change to use INTERNAL_FIELD.
4178 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
4179 (KVAR): Change to use INTERNAL_FIELD.
4180 * frame.h (FVAR): New macro.
4181 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
4182 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
4183 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
4184 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
4185 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
4186
c09bfb2f
DA
41872012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
4188
4189 Miscellaneous fixes for non-default X toolkits.
4190 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
4191 * xterm.c (x_frame_of_widget): Remove redundant prototype.
4192 Move under #ifdef USE_LUCID.
4193 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
4194 definition and usage to avoid warnings.
4195
14c114ae
JD
41962012-07-31 Jan Djärv <jan.h.d@swipnet.se>
4197
4198 * nsterm.m (openFiles): Fix previous checkin.
4199
3bd21e82
PE
42002012-07-31 Paul Eggert <eggert@cs.ucla.edu>
4201
4202 * indent.c (compute_motion): Remove unused local.
4203
c1529ded
GM
42042012-07-31 Glenn Morris <rgm@gnu.org>
4205
400d5621
GM
4206 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
4207
268e2432
GM
4208 * conf_post.h [USG5_4]:
4209 Move remaining contents of s/usg5-4-common.h here.
4210 * s/usg5-4-common.h: Remove file.
4211
7552f3ee
GM
4212 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
4213 * s/irix6-5.h: Remove file.
4214
6a381852
GM
4215 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
4216 * s/darwin.h: Remove file.
4217
c1529ded
GM
4218 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
4219 * s/hpux10-20.h: Remove file, which is now empty.
4220
b429a4ee
GM
42212012-07-30 Glenn Morris <rgm@gnu.org>
4222
4223 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
4224 * Makefile.in (config_h): Add conf_post.h.
4225 * makefile.w32-in (CONFIG_H): Add conf_post.h.
4226
adff3182
JD
42272012-07-30 Jan Djärv <jan.h.d@swipnet.se>
4228
4229 * nsterm.m (ns_do_open_file): New variable.
b9031d69 4230 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
4231 (openFile, openTempFile, openFileWithoutUI, openFiles):
4232 Open files only if ns_do_open_file.
adff3182 4233
c32af1e4
PE
42342012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4235
7393bcbb
PE
4236 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
4237 This no-op macro hasn't been needed for many years.
4238 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
4239
c32af1e4
PE
4240 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
4241 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
4242 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
4243 gdb_make_enums_visible.
4244 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
4245 (DIRECTORY_SEP): Now a constant, not a macro.
4246
302fc036
EZ
42472012-07-30 Eli Zaretskii <eliz@gnu.org>
4248
4249 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
4250 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
4251
4252 * w32term.c <w32_keyboard_codepage>: Renamed from
4253 keyboard_codepage and now external. All users changed.
4254
4255 * w32term.h: Add declaration of w32_keyboard_codepage.
4256
4257 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
4258 the codepage to translate keys to Unicode. If this argument is
4259 -1, use the value returned by GetConsoleCP. All callers changed.
4260
88fb40b4
PE
42612012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4262
0aee6912
PE
4263 Update .PHONY listings in makefiles.
4264 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
4265 bootstrap-clean, distclean, maintainer-clean, versioclean,
4266 extraclean, frc.
4267
88fb40b4
PE
4268 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
4269 This is a bit clearer. Fix some commentary typos.
4270
0a763bd1
GM
42712012-07-30 Glenn Morris <rgm@gnu.org>
4272
32bac6d6
GM
4273 * s/netbsd.h: Let configure include signal.h if needed.
4274 Remove file, which is now empty.
4275
b65e7c46
GM
4276 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
4277 Let configure set them.
4278 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
4279 No more need to undefine.
0a763bd1 4280
169304bd
AS
42812012-07-30 Andreas Schwab <schwab@linux-m68k.org>
4282
4283 * keymap.c (Fkey_description): Don't remove 0x80 bit from
4284 non-single-byte char when adding meta modifier. (Bug#12090)
4285
6cd7a139
DA
42862012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4287
4288 Convert safe_call to use variable number of arguments.
4289 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
4290 (safe_call2): Fix comment.
4291 * lisp.h (safe_call): Adjust prototype.
4292 * coding.c (encode_coding_object): Change to use safe_call2.
4293 * xfaces.c (merge_face_heights): Change to use safe_call1.
4294
d34d6ffc
GM
42952012-07-30 Glenn Morris <rgm@gnu.org>
4296
7b8a48e4 4297 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 4298 does that unconditionally. Remove file, which is now empty.
7b8a48e4 4299
d34d6ffc
GM
4300 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
4301 Remove empty files.
4302
03a660a6
PE
43032012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4304
4305 Export to GDB most of lisp.h's remaining object-like macros.
4306 * lisp.h (min, max): Move earlier, because they're used earlier now.
4307 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
4308 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
4309 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
4310 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
4311 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
4312 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
4313 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
4314 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
4315 Now constants, for GDB. They need not be macros.
4316 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
4317 Now constants, for GDB, as well as macros, for static initializers.
4318 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
4319 Move to after the definition of struct Lisp_Char_Table,
4320 since the former now needs that type defined.
4321 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
4322 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
4323 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
4324 New enums, for gdb_make_enums_visible.
4325 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 4326 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
4327 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
4328 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
4329 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
4330 enum maxargs, enum MAX_ALLOCA.
4331 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
4332 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
4333 no longer needed, now that they are done in lisp.h.
4334
e499d0ee
DA
43352012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4336
4337 Cleanup string bytes checking.
4338 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
4339 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
4340 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
4341 (check_sblock, compact_small_strings): Simplify.
4342
d5040d2d
PE
43432012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4344
4345 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
4346 These macros are confusing and no longer need to be defined, as
4347 the enum values now suffice. All uses replaced with definiens.
4348 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
4349
7f259ae6
JB
43502012-07-29 Juanma Barranquero <lekktu@gmail.com>
4351
4352 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
4353 ($(BLD)/w32console.$(O)): Update dependencies.
4354
7e63e0c3
DA
43552012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4356
4357 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
4358 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
4359 time. Adjust users.
4360 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
4361
ffd817eb
JD
43622012-07-29 Jan Djärv <jan.h.d@swipnet.se>
4363
4364 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
4365 setting sitelisp (Bug#12010).
4366
417a7a0e
EZ
43672012-07-29 Eli Zaretskii <eliz@gnu.org>
4368
14ae4239 4369 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
4370
4371 * w32heap.c (cache_system_info):
4372 * w32.c (sys_rename):
4373 * w32proc.c (find_child_console, sys_kill): All users changed.
4374
387d4d92
PE
43752012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4376
4377 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
4378
55a6cca6
EZ
43792012-07-29 Eli Zaretskii <eliz@gnu.org>
4380
4381 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
4382
dbcf001c
DA
43832012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4384
4385 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
4386 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
4387 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 4388
e2688e4a
DA
43892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4390
4391 Generalize marker debugging code under MARKER_DEBUG and use eassert.
4392 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
4393 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
4394 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
4395 (replace_range, replace_range_2, del_range_2): Change to eassert.
4396 * marker.c (byte_char_debug_check): Adjust style.
4397
b46a6a83
PE
43982012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
4401 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
4402 long-ago-commented-out code that talks about "WIN32".
4403 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
4404 All uses changed.
4405
e32a5799
PE
44062012-07-28 Paul Eggert <eggert@cs.ucla.edu>
4407
4408 Use Gnulib stdalign module (Bug#9772, Bug#9960).
4409 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
4410 Simplify by using alignof.
4411 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
4412 * lisp.h: Include <stdalign.h>.
4413 (GCALIGNMENT): New macro and constant.
4414 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
4415 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
4416 (stdalign): New macro, if not already defined.
4417
df81cd29
EZ
44182012-07-28 Eli Zaretskii <eliz@gnu.org>
4419
01bd1b0d
EZ
4420 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
4421 * w32inevt.c: Include w32inevt.h.
4422 (w32_read_console_input): New inline function, calls either
4423 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
4424 w32_console_unicode_input.
4425 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
4426 (w32_kbd_patch_key, key_event): Use the codepage returned by
4427 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
4428 (key_event): use uChar.UnicodeChar only if
4429 w32_console_unicode_input is non-zero.
4430
4431 * w32console.c: Include w32heap.h.
4432 <w32_console_unicode_input>: New global variable.
4433 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
4434 family of Windows, zero otherwise.
4435
4436 * w32inevt.h: Declare w32_console_unicode_input.
4437
df81cd29
EZ
4438 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4439 --without-x. (Bug#11742)
4440
c20fdd9e
PE
44412012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4442
4443 Adjust GDB to reflect pvec_type changes (Bug#12036).
4444 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
4445 2012-07-04 changes to pseudovector representation.
4446 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 4447
32770973 44482012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
4449
4450 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
4451 bus address.
4452 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
4453
3438fe21
EZ
44542012-07-27 Eli Zaretskii <eliz@gnu.org>
4455
bcfbc9de
EZ
4456 * alloc.c (listn): Fix the order the arguments are consed onto the
4457 list.
4458
3438fe21
EZ
4459 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
4460 enumeration constants, as PURE and HEAP are too general, and clash
4461 with other headers and sources, such as gmalloc.c and the
4462 MS-Windows system headers. All users changed.
4463
eeaea515
DA
44642012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4465
4466 Revert last save_excursion_save and save_excursion_restore changes.
4467 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
4468 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
4469
073c88c2
DA
44702012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4471
4472 Fix recently-introduced typos in Windows port.
4473 Reported by Martin Rudalics <rudalics@gmx.at>.
4474 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 4475 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 4476
4706125e
PE
44772012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 Improve GDB symbol export (Bug#12036).
4480 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
4481 arms of an 'if', not using conditional expressions; otherwise GDB
4482 complains about the types in the unevaluated arm when the argument
4483 is an integer literal.
4484 (xgetint): Simplify expression.
4485 * alloc.c (gdb_make_enums_visible): New constant. This ports to
4486 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
4487 Zaretskii in <http://bugs.gnu.org/12036#13>.
4488 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
4489 needed now that we have gdb_make_enums_visible.
4490 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
4491 (enum enum_USE_LSB_TAG):
4492 New enum types, packaging up enums that need to be exported to GDB.
4493
694b6c97
DA
44942012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4495
4496 Utility function to make a list from specified amount of objects.
4497 * lisp.h (enum constype): New datatype.
4498 (listn): New prototype.
4499 * alloc.c (listn): New function.
4500 (Fmemory_use_count, syms_of_alloc): Use it.
4501 * buffer.c (syms_of_buffer): Likewise.
4502 * callint.c (syms_of_callint): Likewise.
4503 * charset.c (define_charset_internal): Likewise.
4504 * coding.c (syms_of_coding): Likewise.
4505 * keymap.c (syms_of_keymap): Likewise.
4506 * search.c (syms_of_search): Likewise.
4507 * syntax.c (syms_of_syntax): Likewise.
4508 * w32.c (init_environment): Likewise.
4509 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
4510 * xdisp.c (syms_of_xdisp): Likewise.
4511 * xfns.c (syms_of_xfns): Likewise.
4512
6195f384
DA
45132012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4514
4515 Fast save_excursion_save and save_excursion_restore.
4516 * lisp.h (struct Lisp_Excursion): New data type.
4517 (PVEC_EXCURSION): New pseudovector type.
4518 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
4519 to deal with it. Adjust comments.
4520 (init_marker, attach_marker): New prototype.
4521 (unchain_marker): Adjust prototype.
4522 * marker.c (attach_marker): Change to global.
4523 (init_marker): New function.
4524 * alloc.c (Fmake_marker, build_marker): Use it.
4525 (build_marker): More easserts.
4526 (mark_object): Handle struct Lisp_Excursion.
4527 * editfns.c (save_excursion_save, save_excursion_restore):
4528 Reimplement to use struct Lisp_Excursion. Add comments.
4529
5eceb8fb
PE
45302012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4531
4532 Fix export of symbols to GDB (Bug#12036).
4533 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
4534 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
4535 emacs.c, as this is a more-suitable home. Had this been done earlier
4536 the fix for 12036 would have avoided some of the problems noted in
4537 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
4538 would have been more obvious.
562157c8
PE
4539 * emacs.c: Do not include <verify.h>; no longer needed.
4540 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
4541 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
4542 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4543 Remove; now done in lisp.h.
4544 * lisp.h (PUBLISH_TO_GDB): New macro.
4545 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
4546 (DATA_SEG_BITS): Use it.
4547 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
4548 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
4549 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
4550 not be usable in #if. This simplifies things.
4551
d6749401
JB
45522012-07-26 Juanma Barranquero <lekktu@gmail.com>
4553
4554 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
4555
1781b9e9
PE
45562012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4557
d89518db 4558 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
4559 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
4560 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
4561 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
4562 Adjust to changes in lisp.h and emacs.c, by using
4563 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
4564 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
4565 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
4566 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
4567 instead of gdb_valbits.
4568 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
4569 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
4570 instead of gdb_array_mark_flag.
4571 (xboolvector): Get size from $->size, not $->header.size.
4572 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
4573 (xreload, hook-run, hookpost-run): Remove.
4574 * emacs.c: Include <verify.h>.
4575 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
4576 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
4577 Remove.
4578 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
4579 (gdb_USE_LSB_TAG): New enum constants.
4580 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4581 Also define these as enum constants, so they're visible to GDB.
4582 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
4583 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
4584 as constants, so they're visible to GDB.
4585 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
4586 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
4587 Now enum constants, not macros, so they're visible to GDB.
4588 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
4589 more convenient now. All uses changed.
4590 (VALMASK) [USE_LSB_TAG]: Also define in this case.
4591 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
4592
3628596a
DA
45932012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
4594
4595 Explicitly free restriction data that are not needed anymore.
4596 * editfns.c (save_restriction_restore): Free restriction data.
4597
7abaf5cc
SM
45982012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
4599
4600 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
4601 add argument, tune behavior, and adjust all callers.
4602
71f88e00
PE
46032012-07-25 Paul Eggert <eggert@cs.ucla.edu>
4604
4605 Use typedef for EMACS_INT, EMACS_UINT.
4606 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
4607 than macros. This simplifies debugging in the usual case, since
4608 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
4609 and it allows expressions involving EMACS_INT casts.
4610 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
4611
57ec3034
JD
46122012-07-25 Jan Djärv <jan.h.d@swipnet.se>
4613
4614 * nsterm.m (ns_read_socket): Return early if there is a modal
4615 window (Bug#12043).
4616
8137e7b3
MR
46172012-07-25 Martin Rudalics <rudalics@gmx.at>
4618
4619 * frame.c (Fredirect_frame_focus): In doc-string don't mention
4620 that FOCUS-FRAME can be omitted.
4621
04e9897c
DA
46222012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
4623
4624 Adjust buffer text indirection counters at the end of Fkill_buffer.
4625 * buffer.c (Fkill_buffer): Adjust indirection counters when the
4626 buffer is definitely dead. This should really fix an issue reported
4627 by Christoph Scholtes again. (Bug#12007).
4628 (init_buffer_once): Initialize indirection counters of
4629 buffer_defaults and buffer_local_symbols (for sanity and safety).
4630
8a0484e1
EZ
46312012-07-24 Eli Zaretskii <eliz@gnu.org>
4632
4633 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4634 and continuation glyphs on tooltip frames, leave them at zero.
4635 Avoids continued lines in tooltips. (Bug#11832)
4636
fa691a83
DA
46372012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
4638
4639 Simplify copy_overlay.
04e9897c 4640 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
4641 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
4642
436bc8e0
EZ
46432012-07-23 Eli Zaretskii <eliz@gnu.org>
4644
4645 * print.c (print_object): Don't crash when a frame's name is nil
4646 or invalid. (Bug#12025)
4647
4648 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
4649 it signals an error when a tooltip frame is being created.
4650
d7a7fda3
DA
46512012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
4652
4653 Cleanup miscellaneous objects allocation and initialization.
4654 * alloc.c (allocate_misc): Change to static. Add argument to
4655 specify the subtype. Adjust comment and users.
4656 (build_overlay): New function.
4657 * buffer.c (copy_overlays, Fmake_overlay): Use it.
4658 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
4659 (allocate_misc): Remove prototype.
4660 (build_overlay): Add prototype.
4661
46622012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
4663
4664 Swap buffer text indirection counters in Fbuffer_swap_text.
4665 * buffer.c (Fbuffer_swap_text): Swap indirections too.
4666 This avoids crash reported by Christoph Scholtes at
4667 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
4668
9d7fa573
JD
46692012-07-22 Jan Djärv <jan.h.d@swipnet.se>
4670
4671 * nsmenu.m (Popdown_data): New struct.
4672 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
4673 free Popdown_data.
4674 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
4675 (initWithContentRect): Make imgView and contentView non-static
4676 and autorelease them. Also autorelease img and matrix (Bug#12005).
4677 (dealloc): Remove (Bug#12005).
4678
0dd6d66d
DA
46792012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4680
4681 Adjust consing_since_gc when objects are explicitly freed.
4682 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
4683 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
4684 (free_cons, free_misc): Subtract object size from consing_since_gc.
4685
d36d71df
DA
46862012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4687
4688 Simplify and cleanup markers positioning code.
4689 * marker.c (attach_marker): More useful eassert.
4690 (live_buffer, set_marker_internal): New function.
4691 (Fset_marker, set_marker_restricted): Use set_marker_internal.
4692 (set_marker_both, set_marker_restricted_both): Use live_buffer.
4693
fb9ea40f
PE
46942012-07-22 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4697 as it's limited by the amount of memory, not by INT_MAX.
4698
2d5c5f7d
EZ
46992012-07-21 Eli Zaretskii <eliz@gnu.org>
4700
07fb592e
EZ
4701 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4702 in special-event-map. See the discussion at
4703 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
4704 for the reasons.
4705
37a9eac8 4706 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
4707 info.dwItemData. Fixes crashes on 64-bit Windows.
4708 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 4709
c4328746
JD
47102012-07-21 Jan Djärv <jan.h.d@swipnet.se>
4711
fc0c31f8 4712 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 4713 (conversationIdentifier): Return value is NSInteger.
784051c4 4714 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 4715
6e5d1c12
CY
47162012-07-21 Chong Yidong <cyd@gnu.org>
4717
4718 * window.c (decode_any_window): Signal an error if the window is
4719 on a dead frame (Bug#11984).
4720
9928463d
DA
47212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4722
4723 Add indirection counting to speed up Fkill_buffer.
4724 * buffer.h (struct buffer): New member.
4725 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
4726 (Fmake_indirect_buffer): Set indirection counter to -1, increment
4727 base buffer indirection counter.
4728 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
4729 (Fkill_buffer): Adjust indirection counters as needed, don't walk
4730 through buffer list if indirection counter is 0.
4731
f8643a6b
DA
47322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4733
4734 Extend the value returned by Fgarbage_collect with heap statistics.
4735 * alloc.c (Qheap): New symbol.
4736 (syms_of_alloc): DEFSYM it.
4737 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
4738 (Fmemory_free): Remove.
4739 (syms_of_alloc): Don't defsubr it.
4740 * buffer.c (Fcompact_buffer): Remove.
4741 (syms_of_buffer): Don't defsubr it.
4742
dac616ff
DA
47432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4744
4745 Make maybe_gc inline.
4746 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
4747 * lisp.h (consing_since_gc, gc_relative_threshold)
4748 (memory_full_cons_threshold): Revert declaration.
4749 (maybe_gc): Remove prototype, define as inline.
4750 * alloc.c: Remove old commented-out code.
4751 (consing_since_gc, gc_relative_threshold)
4752 (memory_full_cons_threshold): Revert to global.
4753 (maybe_gc): Remove.
4754
d7ea76b4
DA
47552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4756
4757 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4758 * lisp.h (build_unibyte_string): New function.
4759 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4760 * sysdep.c, w32fns.c, xfns.c: Use it.
4761 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4762 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4763 Adjust users accordingly.
4764 * font.h (font_open_by_name): Adjust prototype.
4765
765e61e3
DA
47662012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4767
4768 Cleanup calls to Fgarbage_collect.
4769 * lisp.h (maybe_gc): New prototype.
4770 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4771 Remove declarations.
4772 * alloc.c (maybe_gc): New function.
4773 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4774 Make them static.
4775 * bytecode.c (MAYBE_GC): Use maybe_gc.
4776 * eval.c (eval_sub, Ffuncall): Likewise.
4777 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4778 to avoid dependency from auto-save feature.
4779
52b852c7
PE
47802012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4783 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4784 'for_each_per_buffer_object_at'.
4785 All uses changed. It's better to use upper-case for macros that
4786 cannot be implemented as functions, to give the reader a clue
4787 that they're special.
4788
5db81e33
SM
47892012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4790
4791 * alloc.c (Fgarbage_collect): Tweak docstring.
4792
5b835e1d
DA
47932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4794
4795 Tweak the value returned from Fgarbage_collect again.
4796 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4797 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4798 Adjust documentation.
4799 (total_vector_bytes): Rename to total_vector_slots, adjust
4800 accounting.
4801 (total_free_vector_bytes): Rename to total_free_vector_slots,
4802 adjust accounting.
4803 (Qstring_bytes, Qvector_slots): New symbols.
4804 (syms_of_alloc): DEFSYM them.
4805
9cd47b72
DA
48062012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4807
4808 Buffer compaction primitive which may be used from Lisp.
4809 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4810 (syms_of_buffer): Register Fcompact_buffer.
4811 * alloc.c (Fgarbage_collect): Use compact_buffer.
4812 * buffer.h (compact_buffer): New prototype.
4813 (struct buffer_text): New member.
4814
d17337e5
DA
48152012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4816
4817 New macro to iterate over all buffers, miscellaneous cleanups.
4818 * lisp.h (all_buffers): Remove declaration.
4819 * buffer.h (all_buffers): Add declaration, with comment.
4820 (for_each_buffer): New macro.
4821 * alloc.c (Fgarbage_collect, mark_object): Use it.
4822 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4823 (init_buffer): Likewise.
4824 * data.c (Fset_default): Likewise.
4825 * coding.c (code_conversion_restore): Remove redundant check
4826 for dead buffer.
4827 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4828
60cfd278
AS
48292012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4830
4831 Fix bug that created negative-length intervals.
4832 * intervals.c (merge_interval_right, merge_interval_left):
4833 Do not zero out this interval if it is absorbed by its children,
4834 as this interval's total length doesn't change in that case. See
4835 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4836
d06714cb
PE
48372012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4838
83713154
PE
4839 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4840 when invoking (make-bool-vector N t) and N is a positive
4841 multiple of 8 -- the last 8 bits were mistakenly cleared.
4842
d06714cb
PE
4843 Remove some struct layout assumptions in bool vectors.
4844 * alloc.c (bool_header_size): New constant.
4845 (header_size, word_size): Move earlier, as they're now used earlier.
4846 Use 'word_size' in a few more places, where it's appropriate.
4847 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4848 padding before the data member of a bool vector.
4849 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4850 than doing the check by hand with an abort ().
4851
464d5a5e
SM
48522012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4853
5fbc0409
SM
4854 * eval.c (Fdefvar): Don't check constants since we only set the var if
4855 it's not yet defined anyway (bug#11904).
4856
464d5a5e
SM
4857 * lisp.h (last_undo_boundary): Declare new var.
4858 * keyboard.c (command_loop_1): Set it.
4859 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4860 were auto-added by the command loop (bug#11774).
4861
8dc2e44a
AS
48622012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4863
4864 * w32font.c (Qsymbol): Remove local definition.
4865 (syms_of_w32font): Don't DEFSYM it.
4866
169925ec
DA
48672012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4868
4869 Fix sweep_vectors to handle large bool vectors correctly.
4870 * alloc.c (sweep_vectors): Account total_vector_bytes for
4871 bool vectors larger than VBLOCK_BYTES_MAX.
4872
5fbfb018
CY
48732012-07-18 Chong Yidong <cyd@gnu.org>
4874
4875 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4876 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4877
3ab6e069
DA
48782012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4879
4880 Return more descriptive data from Fgarbage_collect.
4881 Suggested by Stefan Monnier in
4882 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4883 * alloc.c (bounded_number): New function.
4884 (total_buffers, total_vectors): New variable.
4885 (total_string_size): Rename to total_string_bytes, adjust users.
4886 (total_vector_size): Rename to total_vector_bytes, adjust users.
4887 (sweep_vectors): Account total_vectors and total_vector_bytes.
4888 (Fgarbage_collect): New return value. Adjust documentation.
4889 (gc_sweep): Account total_buffers.
4890 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4891 (VECTOR_SIZE): Remove.
4892 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4893 (Qinterval, Qmisc): New symbols.
4894 (syms_of_data): Initialize them.
4895 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4896 (Qcons, Qbuffer): New declarations.
4897
6d02fe5b
PE
48982012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4899
4900 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4901 Round up, not down. Improve doc.
4902
b7ffe040
DA
49032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4904
4905 Restore old code in allocate_string_data to avoid Faset breakage.
4906 Reported by Julien Danjou <julien@danjou.info> in
4907 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4908 * alloc.c (allocate_string_data): Restore old code with minor
4909 adjustments, fix comment to explain this subtle issue.
4910
4dc7c8d5
SM
49112012-07-17 Eli Zaretskii <eliz@gnu.org>
4912
4913 Remove FILE_SYSTEM_CASE.
4914 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4915
4916 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4917 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4918 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4919 call-process-region passes it through expand-file-name.
4920
4921 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4922
49232012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4924
4925 Fix crash when creating indirect buffer (Bug#11917)
4926 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4927 Don't handle unbound variables specially if non-zero.
4928 (Fbuffer_local_variables): Pass zero.
4929 (clone_per_buffer_values): Pass non-zero.
4930
49312012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4932
4933 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4934 to make the loop interruptible.
4935
49362012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4937
4938 * gnutls.c (emacs_gnutls_handshake): Only retry if
4939 GNUTLS_E_INTERRUPTED.
4940
cce7fefc
DA
49412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4942
4943 Cleanup and convert miscellaneous checks to eassert.
4944 * alloc.c (mark_interval): Fix comment, partially rephrase
4945 old comment from intervals.h (see below).
4946 * intervals.c (find_interval, adjust_intervals_for_insertion)
4947 (delete_interval, adjust_intervals_for_deletion)
4948 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4949 Convert to eassert.
4950 (adjust_intervals_for_insertion, make_new_interval):
4951 Remove obsolete and unused code.
4952 * intervals.h (struct interval): Remove obsolete comment.
4953 * textprotp.c (erase_properties): Remove unused code.
4954 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4955 (Fremove_list_of_text_properties): Convert to eassert.
4956
9ea10cc3
CY
49572012-07-17 Chong Yidong <cyd@gnu.org>
4958
4959 * editfns.c (Finsert_char): Doc fix.
4960
3900d5de
DA
49612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4962
4963 Fix previous change to make Fmemory_free always accurate.
4964 * alloc.c (make_interval): Update total_free_intervals.
4965 (make_float): Likewise for total_free_floats.
4966 (free_cons, Fcons): Likewise for total_free_conses.
4967 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4968 Likewise for total_free_vector_bytes.
4969 (Fmake_symbol): Likewise for total_free_symbols.
4970 (bytes_free): Remove.
4971
7098646f
DA
49722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4973
4974 Simple free memory accounting feature.
4975 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4976 (sweep_vectors): Accumulate size of free vectors.
4977 (Fgarbage_collect): Setup bytes_free.
4978 (Fmemory_free): New function.
4979 (syms_of_alloc): Register it.
4980
22657b40
DA
49812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4982
4983 Cleanup overlays checking.
4984 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4985 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4986 eassert and OVERLAYP.
4987 (sort_overlays): Change to use OVERLAYP.
4988
ddfc8813
RK
49892012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4990
4991 * editfns.c (Finsert_char): Make it interactive, and make the
4992 second arg optional. Copy interactive spec and docstring from
4993 ucs-insert.
4994
7c26cf3c
PE
49952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4996
4997 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4998 Unlike the other wrapped functions, fabs has an unspecified
4999 effect on errno.
5000
5d127af9
JD
50012012-07-16 Jan Djärv <jan.h.d@swipnet.se>
5002
5003 * nsterm.m (keyDown): Interpret flags without left/right bits
5004 as the left key (Bug#11670).
5005
6a0dd1d7
DA
50062012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
5007
5008 Remove empty and useless init functions.
5009 * lisp.h (init_character_once, init_fns, init_image)
5010 (init_filelock, init_sound): Remove prototype.
5011 * character.c (init_character_once): Remove.
5012 * filelock.c (init_filelock): Likewise.
5013 * fns.c (init_fns): Likewise.
5014 * image.c (init_image): Likewise.
5015 * sound.c (init_sound): Likewise.
5016 * emacs.c (main): Adjust accordingly.
5017
7a6136fd
DA
50182012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
5019
5020 * gtkutil.h: Tiny cleanups.
5021 (use_old_gtk_file_dialog): Remove useless declaration.
5022 (xg_uses_old_file_dialog): Add suggested const attribute.
5023
ce811ad9
EZ
50242012-07-15 Eli Zaretskii <eliz@gnu.org>
5025
5026 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
5027 (bidi_paragraph_init): Use it to limit search forward for a strong
5028 directional character in abnormally large paragraphs full of
5029 neutral or weak characters. (Bug#11943)
5030
c9adfeaa
SF
50312012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
5032
5033 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
5034 the toolbar (Bug#9451).
5035 (xg_make_tool_item): Give the widget event box a transparent
5036 background.
5037
fff62aa9
DA
50382012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
5039
5040 Cleanup basic allocation variables and functions.
5041 * alloc.c (ignore_warnings, init_intervals, init_float)
5042 (init_cons, init_symbol, init_marker): Remove.
5043 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
5044 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
5045 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
5046 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
5047 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
5048 (staticidx, init_alloc_once, init_strings, free_ablock):
5049 Remove redundant initialization.
5050 * fns.c (init_weak_hash_tables): Remove.
5051 * lisp.h (init_weak_hash_tables): Remove prototype.
5052
9730daca
DA
50532012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
5054
5055 Use zero_vector where appropriate.
5056 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
5057 accordingly.
5058 * lisp.h (zero_vector): New declaration.
5059 * font.c (null_vector): Remove.
5060 (syms_of_font): Remove initialization and staticpro.
5061 (font_list_entities, font_find_for_lface): Change to use zero_vector.
5062 * keymap.c (Faccessible_keymaps): Likewise.
5063
2e2d2a13
LL
50642012-07-15 Leo Liu <sdl.web@gmail.com>
5065
5066 * fringe.c: Fix typo in comments.
5067
cd276f6e
LL
50682012-07-14 Leo Liu <sdl.web@gmail.com>
5069
5070 * fringe.c: Add a new bitmap exclamation-mark.
5071
5a1131d9
EZ
50722012-07-14 Eli Zaretskii <eliz@gnu.org>
5073
5074 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
5075
5076 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
5077 (HAVE_MENUS): Don't define, defined by editing config.in with
5078 msdos/sed2v2.inp.
5079 (GMALLOC_INHIBIT_VALLOC): Don't define.
5080 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
5081
22e983b7
JB
50822012-07-14 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
5085
5b3f250f
GM
50862012-07-14 Glenn Morris <rgm@gnu.org>
5087
5088 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
5089 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
5090 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
5091
33d63ff4
GM
50922012-07-13 Glenn Morris <rgm@gnu.org>
5093
5b633342
GM
5094 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
5095
33d63ff4
GM
5096 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
5097 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
5098
b55b9f85
JD
50992012-07-13 Jan Djärv <jan.h.d@swipnet.se>
5100
0dc8cf50
JD
5101 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
5102 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
5103 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
5104 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
5105 where appropriate.
5106 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
5107 as boolean expression.
5108 (x_set_window_size): Remove unused variable toolbar.
5109 (ns_get_color_default, ns_mod_to_lisp): Remove.
5110 (ns_mouse_position): Remove unused variables xchar and ychar.
5111 (ns_compute_glyph_string_overhangs): Remove unused variable face.
5112 (ns_set_vertical_scroll_bar): Remove unused variable count.
5113 (ns_delete_terminal): Remove unused variable i.
5114 (ns_term_init): Remove unused variables r, g and b.
5115 (mouseDown): Remove unused variable window.
5116 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
5117 (initFrameFromEmacs): Remove unused variable vbextra.
5118 (mouseEntered): Remove unused variables p and dpyinfo.
5119 (mouseExited): Remove unused variables p and r.
5120 (ns_define_frame_cursor, ns_clear_frame_area)
5121 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
5122 (menuDown): Assign [sender tag] to variable and cast the variable.
5123
5124 * nsterm.h (menuDown): Add id as type to argument sender.
5125 (ns_display_info_for_name): Add Lisp_Object argument.
5126 (ns_term_init): Add Lisp_Object argument.
5127 (ns_map_event_to_object): Add void argument.
5128 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
5129 prototype with arguments and only declare if __OBJC__.
5130 (nxatoms_of_nsselect): Add void argument.
5131 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
5132 (ns_alloc_autorelease_pool): Add void argument.
5133 (ns_release_autorelease_pool): Add void* argument.
5134 (ns_get_defaults_value): Add const char* argument.
5135
5136 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
5137 (initFromContents): Use SSDATA where appropriate.
5138 (ns_update_menubar): Add braces to ambigous if-else.
5139 (initWithTitle): Put () around assignment in if statement.
5140 (ns_menu_show): Remove unused variables window and keymap.
5141 (update_frame_tool_bar): Remove unused variable selected_p.
5142 (initWithContentRect): Remove unused variable this_cmd_name.
5143
5144 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
5145 appropriate.
5146 (setXBMColor): Remove unused variable len.
5147 (setPixmapData): Put () around assignment in loop statement.
5148
5149 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
5150 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
5151 where appropriate.
5152 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
5153 around assignment in loop statement.
5154 (nsfont_open): Remove unused variable i.
5155 (nsfont_open): Remove unused variable len.
5156 (nsfont_draw): Remove unused variable cs.
5157
5158 * nsfns.m (x_set_icon_name, ns_set_name_internal)
5159 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
5160 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
5161 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
5162 (Fns_font_name, Fns_perform_service)
5163 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
5164 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
5165 (ns_set_name): Remove unused variable view.
5166 (x_set_menu_bar_lines): Remove unused variable olines.
5167 (x_set_tool_bar_lines): Remove unused variable root_window.
5168 (Fns_list_colors): Put () around assignment in while statement.
5169 (Fns_perform_service): Remove unused variable len.
5170 (Fns_display_usable_bounds): Remove unused variable top.
5171 (syms_of_nsfns): Remove unused variable i.
5172
b55b9f85
JD
5173 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
5174 memcpy (Bug#11907).
5175
ed9265fc 51762012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
5177
5178 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
5179 and free it with DestroyExceptionInfo (Bug#11558).
5180
ef099b57
JB
51812012-07-13 Juanma Barranquero <lekktu@gmail.com>
5182
5183 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
5184 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
5185 Set here, not in nt/config.nt.
5186
ea814a5d
EZ
51872012-07-13 Eli Zaretskii <eliz@gnu.org>
5188
5189 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
5190 cursor overflow into the last glyph on display line when the right
5191 fringe is off. (Bug#11832)
5192
1a952767
PE
51932012-07-13 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 * xdisp.c (produce_special_glyphs): Now static.
5196 * dispextern.h (produce_special_glyphs): Remove decl.
5197
983188fd
GM
51982012-07-13 Glenn Morris <rgm@gnu.org>
5199
8d7c7eed 5200 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
5201 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
5202
983188fd
GM
5203 * s/usg5-4-common.h (USG, USG5):
5204 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
5205 * s/sol2-6.h (SOLARIS2):
5206 * s/irix6-5.h (IRIX6_5):
5207 * s/hpux10-20.h (USG, USG5, HPUX):
5208 * s/gnu-linux.h (USG, GNU_LINUX):
5209 * s/freebsd.h (BSD_SYSTEM):
5210 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
5211 * s/cygwin.h (CYGWIN):
5212 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
5213 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
5214
d1e68667 52152012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
5216
5217 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 5218
6de0e799
GM
52192012-07-13 Glenn Morris <rgm@gnu.org>
5220
739ae010
GM
5221 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
5222
dbee5793
GM
5223 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
5224
6de0e799
GM
5225 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
5226 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
5227
b82da769
GM
52282012-07-12 Glenn Morris <rgm@gnu.org>
5229
4fae5a7a 5230 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
5231
5232 * process.c (init_process_emacs): Rename from init_process.
5233 The old name is also the name of a Mach system call.
5234 * lisp.h, emacs.c: Update for this name change.
5235 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
5236 longer needed.
5237
5a979817
EZ
52382012-07-12 Eli Zaretskii <eliz@gnu.org>
5239
5240 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
5241 memmove call that removes glyphs covered by the left truncation
5242 glyph. Improve commentary.
5243 (display_line): Fix display of continuation glyphs on GUI frames
5244 when the right fringe is turned off and variable-size fonts are
5245 used in the window. Move the code that appends a stretch glyph to
5246 produce_special_glyphs, so that it could be used for truncation
5247 and continuation glyphs alike.
5248 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
5249 glyph of a suitably computed width, to align the special glyphs at
5250 the window margin. Code moved from display_line. (Bug#11832)
5251
3e91a053
GM
52522012-07-12 Glenn Morris <rgm@gnu.org>
5253
ba9e4b84
GM
5254 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
5255
5256 * s/gnu-linux.h, s/hpux10-20.h:
5257 Do not unconditionally define HAVE_XRMSETDATABASE.
5258
3e91a053
GM
5259 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
5260
b300b1f4
PE
52612012-07-12 Paul Eggert <eggert@cs.ucla.edu>
5262
5263 Fix typos that broke OS X build.
5264 Reported by Randal L. Schwartz in
5265 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
5266 * nsterm.m (ns_timeout): Add missing local decl.
5267 (ns_get_color): snprintf -> sprintf, to fix typo.
5268
6e777848
GM
52692012-07-12 Glenn Morris <rgm@gnu.org>
5270
3f922c37
GM
5271 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
5272 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
5273 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
5274 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
5275
0ab7b23a
GM
5276 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
5277 Move PTY_OPEN to configure.
5278
6e777848
GM
5279 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5280 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
5281 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
5282
4a7edc24
DA
52832012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
5284
5285 Use empty_unibyte_string where applicable.
5286 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
5287 * lread.c (read1): Likewise.
5288 * xsettings.c (syms_of_xsettings): Likewise.
5289
308aab79
GM
52902012-07-12 Glenn Morris <rgm@gnu.org>
5291
42bd1719
GM
5292 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
5293 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
5294 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
5295 * s/hpux10-20.h (RUN_TIME_REMAP):
5296 * s/bsd-common.h (TABDLY): Move to configure.
5297
5298 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
5299
5300 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
5301
ea0bbd17 5302 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 5303 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
5304
5305 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 5306
308aab79
GM
5307 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
5308 * s/template.h: Move NARROWPROTO to configure.
5309
ee1cf5cf
GM
53102012-07-11 Glenn Morris <rgm@gnu.org>
5311
30fe9bf4
GM
5312 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
5313 unused since 2011-01-17 change to systty.h.
5314
ee1cf5cf
GM
5315 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
5316 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5317 Move HAVE_PTYS and HAVE_SOCKETS to configure.
5318
63e47e07
PE
53192012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5320
5321 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
5322
c43fb4c3
GM
53232012-07-11 Glenn Morris <rgm@gnu.org>
5324
5325 * s/darwin.h, s/gnu-linux.h, s/template.h:
5326 Move INTERRUPT_INPUT to configure.
5327
e8df9267
DA
53282012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5329
5330 Minor adjustments to interning code.
5331 * lisp.h (intern, intern_c_string): Redefine as static inline
5332 wrappers for intern_1 and intern_c_string_1, respectively.
5333 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
5334 * lread.c (intern_1, intern_c_string_1, oblookup):
5335 Simplify Vobarray checking.
e8df9267
DA
5336 * font.c (font_intern_prop): Likewise. Adjust comment.
5337 * w32font.c (intern_font_name): Likewise.
5338
34348bd4
AS
53392012-07-11 Andreas Schwab <schwab@linux-m68k.org>
5340
d96a1e0c
AS
5341 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
5342
34348bd4
AS
5343 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
5344 of Fcar/Fcdr if possible.
5345 * font.c (check_otf_features): Likewise.
5346 * fontset.c (Fnew_fontset): Likewise.
5347 * gnutls.c (Fgnutls_boot): Likewise.
5348 * minibuf.c (read_minibuf): Likewise.
5349 * msdos.c (IT_set_frame_parameters): Likewise.
5350 * xmenu.c (Fx_popup_dialog): Likewise.
5351 * w32menu.c (Fx_popup_dialog): Likewise.
5352
c8add24e
GM
53532012-07-11 Glenn Morris <rgm@gnu.org>
5354
4b575b3c
GM
5355 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
5356 since nothing has defined it on these platforms.
5357
09f4e3b0
GM
5358 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
5359 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
5360
172bedef
GM
5361 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5362 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5363 Move CLASH_DETECTION to configure.
5364
249685df
GM
5365 * s/gnu.h: Remove file, which is now empty.
5366
c8add24e
GM
5367 * s/gnu.h, s/gnu-linux.h:
5368 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
5369
b41253a3
JW
53702012-07-11 John Wiegley <johnw@newartisans.com>
5371
5372 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
5373 function attribute, so we only use it if it exists in the
5374 compiler.
5375
d923b542
DA
53762012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5377
5378 Avoid call to strlen in fast_c_string_match_ignore_case.
5379 * search.c (fast_c_string_match_ignore_case): Change to use
5380 length argument. Adjust users accordingly.
5381 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
5382
5ebbef1d
PE
53832012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5384
bb352260
PE
5385 Assume mkdir, rmdir.
5386 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
5387 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
5388
57054ddd
PE
5389 Assume rename.
5390 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
5391
b747d3f7
PE
5392 Assume perror.
5393 * s/hpux10-20.h (HAVE_PERROR): Remove.
5394 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
5395 Remove dummy definition, as this problem was obsolete long ago.
5396
5ebbef1d
PE
5397 Assume strerror.
5398 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
5399
984e7f30
DA
54002012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5401
5402 Avoid calls to strlen in font processing functions.
5403 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
5404 (font_open_by_name): Change to use length argument.
5405 Adjust users accordingly.
d923b542
DA
5406 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
5407 Adjust prototypes.
5408 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
5409 Change to return ptrdiff_t.
984e7f30
DA
5410 (xfont_list_pattern, xfont_match): Use length returned by
5411 xfont_decode_coding_xlfd.
5412 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
5413
20e94fdd
GM
54142012-07-11 Glenn Morris <rgm@gnu.org>
5415
9d596af3
GM
5416 * s/darwin.h, s/freebsd.h, s/netbsd.h:
5417 Move DONT_REOPEN_PTY to configure.
5418
20e94fdd
GM
5419 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
5420 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
5421
e99a530f
PE
54222012-07-10 Paul Eggert <eggert@cs.ucla.edu>
5423
22ffb973
PE
5424 Remove "#define unix" that is no longer needed (Bug#11905).
5425 * s/aix4-2.h (unix): Remove; no longer needed.
5426
e9a9ae03
PE
5427 EMACS_TIME simplification (Bug#11875).
5428 This replaces macros (which typically do not work in GDB)
5429 with functions, typedefs and enums, making the code easier to debug.
5430 The functional style also makes code easier to read and maintain.
5431 * systime.h: Include <sys/time.h> on all hosts, not just if
5432 WINDOWSNT, since 'struct timeval' is needed in general.
5433 (EMACS_TIME): Now a typedef, not a macro.
5434 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
5435 not macros.
5436 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
5437 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
5438 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
5439 (EMACS_TIME_LE): Now functions, not macros.
5440 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
5441 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
5442 which are not functions. All uses rewritten to use:
5443 (make_emacs_time): New function.
5444 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
5445 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
5446 not functions. All uses rewritten to use the following, respectively:
5447 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
5448 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 5449 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
5450 * fileio.c (Fcopy_file):
5451 * xterm.c (XTflash): Get the current time closer to when it's used.
5452 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
5453
ffacb126
PE
5454 * bytecode.c (targets): Suppress -Woverride-init warnings.
5455
e99a530f
PE
5456 Simplify by avoiding confusing use of strncpy etc.
5457 * doc.c (Fsnarf_documentation):
5458 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
5459 * frame.c (Fmake_terminal_frame):
5460 * gtkutil.c (get_utf8_string):
5461 * lread.c (openp):
5462 * nsmenu.m (ns_update_menubar):
5463 * regex.c (regerror):
5464 Prefer memcpy to strncpy and strncat when either will do.
5465 * fileio.c (Fsubstitute_in_file_name):
5466 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
5467 (menu_separator_name_p):
5468 * nsmenu.m (ns_update_menubar):
5469 Prefer memcmp to strncmp when either will do.
5470 * nsterm.m: Include <ftoastr.h>.
5471 (ns_get_color):
5472 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
5473 Prefer snprintf to strncpy.
5474 * nsterm.m (ns_term_init):
5475 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
5476 * nsterm.m (ns_term_init):
5477 Avoid the need for strncpy, by using build_string or
5478 make_unibyte_string directly. Use dtoastr, not snprintf.
5479 * process.c (Fmake_network_process): Diagnose service names that
5480 are too long, rather than silently truncating them or creating
5481 non-null-terminated names.
5482 (Fnetwork_interface_info): Likewise, for interface names.
5483 * sysdep.c (system_process_attributes) [GNU_LINUX]:
5484 Prefer sprintf to strncat.
5485 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
5486 Prefer vsnprintf to vsprintf + strncpy.
5487
c59592b3
GM
54882012-07-10 Glenn Morris <rgm@gnu.org>
5489
5490 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
5491 Clarify fallback case.
5492
7d7bbefd
DA
54932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5494
5495 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
5496 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
5497 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 5498 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
5499 where argument type is known to be a Lisp_Cons.
5500
3a4c8000
TT
55012012-07-10 Tom Tromey <tromey@redhat.com>
5502
5503 * bytecode.c (BYTE_CODE_THREADED): New macro.
5504 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5505 (enum byte_code_op): New type.
5506 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
5507 (exec_byte_code): Use them. Use token threading when applicable.
5508
2a0213a6
DA
55092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5510
5511 Optimize pure C strings initialization.
5512 * lisp.h (make_pure_string): Fix prototype.
5513 (build_pure_c_string): New function, defined as static inline. This
5514 provides a better opportunity to optimize away calls to strlen when
5515 the function is called with compile-time constant argument.
5516 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
5517 argument, adjust users accordingly. Use build_pure_c_string where
5518 appropriate.
5519 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
5520 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
5521 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
5522
cb1caeaf
DA
55232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5524
5525 Avoid calls to strlen in miscellaneous functions.
5526 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5527 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
5528 * lread.c (openp): Likewise.
5529
c293e30c
DA
55302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5531
5532 Avoid calls to strlen in path processing functions.
5533 * fileio.c (file_name_as_directory): Add comment. Change to add
5534 srclen argument and return the length of result. Adjust users
5535 accordingly.
5536 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
5537 swap 1st and 2nd arguments to obey the common convention.
5538 Adjust users accordingly.
c293e30c
DA
5539 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
5540
9e059e3f
GM
55412012-07-10 Glenn Morris <rgm@gnu.org>
5542
d02eb359
GM
5543 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
5544 Move PENDING_OUTPUT_COUNT definition to configure.
5545
882cf227
GM
5546 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
5547 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
5548 * s/gnu.h (DATA_START): Move definitions to configure.
5549
af6e839f
GM
5550 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
5551 We include usg5-4-common.h, which defines them both.
5552
40289a12
GM
5553 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
5554 O_RDONLY already includes it).
5555
9e059e3f
GM
5556 Stop ns builds setting the EMACSLOADPATH environment variable.
5557 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5558 Now it does not set EMACSLOADPATH, just returns the load-path string.
5559 * nsterm.h: Update accordingly.
5560 * lread.c [HAVE_NS]: Include nsterm.h.
5561 (init_lread) [HAVE_NS]: Use ns_load_path.
5562 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
5563
7c4e8ec0
GM
55642012-07-09 Glenn Morris <rgm@gnu.org>
5565
d4f600ff
GM
5566 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
5567 since the included bsd-common.h does so.
5568
cbb31951
GM
5569 Stop ns builds setting the EMACSPATH environment variable.
5570 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5571 (ns_init_paths): Do not set EMACSPATH.
5572 * nsterm.h (ns_exec_path): Add it.
5573 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
5574 Use ns_exec_path.
5575
7c4e8ec0
GM
5576 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
5577
26bccfae
PE
55782012-07-09 Paul Eggert <eggert@cs.ucla.edu>
5579
a0bee46f
PE
5580 * process.c (wait_reading_process_output): 'waitchannels' was unset
5581 when read_kbd || !NILP (wait_for_cell); fix this.
5582
5994c183
PE
5583 Add GCC-style 'const' attribute to functions that can use it.
5584 * character.h (char_resolve_modifier_mask):
5585 * keyboard.h (make_ctrl_char):
5586 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
5587 (init_character_once, next_almost_prime, init_fns, init_image)
5588 (flush_pending_output, init_sound):
5589 * mem-limits.h (start_of_data):
5590 * menu.h (finish_menu_items):
5591 Add ATTRIBUTE_CONST.
5592 * emacs.c (DEFINE_DUMMY_FUNCTION):
5593 Declare the dummy function with ATTRIBUTE_CONST.
5594 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
5595 Add decls with ATTRIBUTE_CONST.
5596
26bccfae
PE
5597 Minor improvements to make_formatted_string.
5598 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
5599 where int is good enough, as vsprintf returns an int.
5600 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
5601
a8290ec3
DA
56022012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5603
5604 Use make_formatted_string to avoid double length calculation.
5605 * lisp.h (make_formatted_string): New prototype.
5606 * alloc.c (make_formatted_string): New function.
5607 * buffer.c (Fgenerate_new_buffer_name): Use it.
5608 * dbus.c (syms_of_dbusbind): Likewise.
5609 * editfns.c (Fcurrent_time_zone): Likewise.
5610 * filelock.c (get_boot_time): Likewise.
5611 * frame.c (make_terminal_frame, set_term_frame_name)
5612 (x_report_frame_params): Likewise.
5613 * image.c (gs_load): Likewise.
5614 * minibuf.c (get_minibuffer): Likewise.
5615 * msdos.c (dos_set_window_size): Likewise.
5616 * process.c (make_process): Likewise.
5617 * xdisp.c (ensure_echo_area_buffers): Likewise.
5618 * xsettings.c (apply_xft_settings): Likewise.
5619
d01ba2f1
GM
56202012-07-09 Glenn Morris <rgm@gnu.org>
5621
5622 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
5623 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
5624 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
5625 * nsterm.h (ns_etc_directory): Add it.
5626 * callproc.c [HAVE_NS]: Include nsterm.h.
5627 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
5628
f1f924b6
DA
56292012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5630
5631 Move marker debugging code under MARKER_DEBUG.
5632 * marker.c (MARKER_DEBUG): Move marker debugging code under
5633 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
5634 for bootstrap with --enable-checking (~3x slowdown reported
5635 by Juanma Barranquero <lekktu@gmail.com>).
5636 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
5637
ab531b66
PE
56382012-07-08 Paul Eggert <eggert@cs.ucla.edu>
5639
5640 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
5641 See <http://bugs.gnu.org/11825#29>.
5642
c4b3bc8a
EZ
56432012-07-08 Eli Zaretskii <eliz@gnu.org>
5644
5645 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
5646 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
5647 (display_line): Add commentary about displaying truncation glyphs
5648 on GUI frames.
5649 (produce_special_glyphs): Move here from term.c.
5650
5651 * term.c (produce_special_glyphs): Move to xdisp.c.
5652
5653 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
5654 section.
c4b3bc8a 5655
b676b881
AS
56562012-07-07 Andreas Schwab <schwab@linux-m68k.org>
5657
f17c5273
AS
5658 * xdisp.c (display_line): Avoid warning about implicit declaration
5659 of FRAME_FONT.
5660
298819b9
AS
5661 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
5662
b676b881
AS
5663 * lisp.h: Remove empty conditional.
5664
6045c4fd
PE
56652012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5666
b3350bf9
PE
5667 * lread.c (load_path_check): Now static.
5668
6045c4fd
PE
5669 Fix some minor --with-ns problems found by static checking.
5670 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
5671 (x_set_font) [!HAVE_X_WINDOWS]:
5672 * image.c (xpm_load_image) [HAVE_NS]:
5673 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
5674 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
5675 Remove unused local.
5676 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
5677 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
5678 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
5679 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
5680 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
5681 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
5682 Fix pointer signedness problem.
5683 * xfaces.c (FRAME_X_FONT_TABLE):
5684 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
5685
929e7845
GM
56862012-07-07 Glenn Morris <rgm@gnu.org>
5687
5688 * lread.c (load_path_check): New function, split from init_lread.
5689 (init_lread): Reorganize. Motivation:
5690 If EMACSLOADPATH is set, check/warn about that rather than the
5691 defaults, which we are not going to use. Hence we can remove
5692 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
5693 Don't warn if site-lisp directories are missing.
5694 If not installed, start from a blank load-path, since
5695 PATH_LOADSEARCH refers to the eventual installation directories.
5696
58dd0aa4
EZ
56972012-07-07 Eli Zaretskii <eliz@gnu.org>
5698
5699 Support truncation and continuation glyphs on GUI frames, when
5700 fringes are disabled. (Bug#11832)
5701 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
5702 continuation glyphs even if on GUI frames.
5703 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
5704 or both, are absent.
5705 (start_display, move_it_in_display_line_to): Handle the case of a
5706 GUI frame without a fringe to display continuation or truncation
5707 glyphs.
5708 (insert_left_trunc_glyphs): Support GUI frames: make sure
5709 truncation glyphs overwrite enough glyphs from the current line to
5710 have sufficient space in pixels.
5711 (display_line): Support truncation and continuation glyphs on GUI
5712 frames. If some spare pixels are left on the line after inserting
5713 the truncation glyphs, fill that space with a stretch glyph of a
5714 suitably computed width.
5715
5716 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
5717 produce_glyphs, to support GUI sessions.
5718
31571fd7
PE
57192012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5720
5a16b9bc
PE
5721 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
5722
f3047c75
PE
5723 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
5724
31571fd7
PE
5725 Do not require float-time's arg to fit in time_t (Bug#11825).
5726 This works better on hosts where time_t is unsigned, and where
5727 float-time is applied to the (negative) difference between two times.
5728 * editfns.c (decode_time_components): Last arg is now double *,
5729 not int *, and means to store all the result as a double, without
5730 worrying about whether the seconds part fits in time_t.
5731 All callers changed.
5732 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
5733 All callers changed.
5734 (Ffloat_time): Do not fail merely because the specified time falls
5735 outside of time_t range.
5736
4516fbef
GM
57372012-07-07 Glenn Morris <rgm@gnu.org>
5738
5739 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
5740 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5741 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
5742
07adc2c6
JB
57432012-07-07 Juanma Barranquero <lekktu@gmail.com>
5744
5745 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
5746 Update dependencies.
5747
5748 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5749
fd573f31
PE
57502012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5751
fee5959d
PE
5752 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5753 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5754 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5755 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5756 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5757 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5758
fd573f31
PE
5759 * xfont.c (compare_font_names): Redo to omit the need for casts.
5760
ddadbc0e
AS
57612012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5762
fca8d6b6
AS
5763 * xfns.c (Fx_change_window_property): Doc fix.
5764 * w32fns.c (Fx_change_window_property): Doc fix.
5765
ddadbc0e
AS
5766 * w32fns.c (Fx_window_property): Accept the same arguments as the
5767 X Windows version. Doc fix.
5768 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5769
ed9265fc 57702012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5771 Eli Zaretskii <eliz@gnu.org>
5772
5773 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5774 Windows-specific code from nt/config.nt moved here.
5775 Obsolete settings removed.
5776
216ee680
PE
57772012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5778
5779 * process.c: Avoid unnecessary calls to gettime.
5780 (wait_reading_process_output): Don't get the time of day
5781 when gobbling data immediately and not waiting, as there's no need
5782 for it in that case. This removes a FIXME.
5783
bdd091e4
JD
57842012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5785
5786 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5787 is defined (Bug#11768).
5788
9d44f8ce
DA
57892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5790
5791 Fix marker debugging code.
5792 * marker.c (byte_char_debug_check): Do not perform the check
5793 if buffer is not multibyte.
090bd7cb
JB
5794 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5795 Call byte_char_debug_check with correct arguments.
9d44f8ce 5796
90fc4786
DA
57972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5798
5799 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5800 * marker.c (byte_char_debug_check, count_markers):
5801 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5802 (byte_debug_flag): Remove.
5803 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5804 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5805
7b7ae965
DA
58062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5807
4e57b342
DA
5808 Avoid code repetition in marker-related functions.
5809 * marker.c (attach_marker): New function.
5810 (Fset_marker, set_marker_restricted, set_marker_both)
5811 (set_marker_restricted_both): Use it.
5812 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5813 Consistently rename charno to charpos.
5814 (marker_position): Add eassert.
5815 (marker_byte_position): Convert to eassert.
5816
58172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5818
5819 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5820 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5821 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5822
657924ff
DA
58232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5824
5825 Introduce fast path for the widely used marker operation.
5826 * alloc.c (build_marker): New function.
5827 * lisp.h (build_marker): New prototype.
5828 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5829 * composite.c (autocmp_chars): Likewise.
5830 * editfns.c (buildmark): Remove.
5831 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5832 (save_restriction_save): Use build_marker.
5833 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5834 * window.c (save_window_save): Likewise.
5835
041a49a6
DA
58362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5837
5838 Do not use Fdelete_overlay in delete_all_overlays
5839 to avoid redundant calls to unchain_overlay.
5840 * buffer.c (drop_overlay): New function.
5841 (delete_all_overlays, Fdelete_overlay): Use it.
5842 * minibuf.c (get_minibuffer): Fix comment.
5843
7dca65a4
PE
58442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5845
5846 Port to OpenBSD 5.1 amd64.
5847 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5848 This is needed for OpenBSD, and should be harmless on all BSD systems.
5849 Also, include <sys/sysctl.h>, as it should be available on all
5850 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5851 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5852 use p_pid member, not kp_proc.pid.
5853
8eb876e2
GM
58542012-07-06 Glenn Morris <rgm@gnu.org>
5855
5856 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5857
38182d90
PE
58582012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5859
5860 More xmalloc and related cleanup.
5861 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5862 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5863 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5864 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5865 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5866 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5867 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5868 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5869 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5870 * xterm.c:
5871 Omit needless casts involving void * pointers and allocation.
5872 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5873 as the former is more robust if P's type is changed.
5874 Prefer xzalloc to xmalloc + memset 0.
5875 Simplify malloc-or-realloc to realloc.
5876 Don't worry about xmalloc returning a null pointer.
5877 Prefer xstrdup to xmalloc + strcpy.
5878 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5879 growing it.
5880 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5881 alloca of a constant.
5882
6dd5a677
EZ
58832012-07-05 Eli Zaretskii <eliz@gnu.org>
5884
5885 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5886 hscroll is larger than the line width. Fixes long and futile
5887 looping inside extend_face_to_end_of_line (on a TTY) producing
5888 glyphs that are not needed and thrown away.
5889
6b312f0f
DA
58902012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5891
5892 * marker.c (set_marker_restricted_both): Simplify by using
5893 clip_to_bounds.
5894
f520ef9b
PE
58952012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5898
383b7c95
JD
58992012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5900
5901 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5902 not defined (Bug#11768).
5903 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5904 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5905 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5906 followed by gtk_box_set_homogeneous (Bug#11768).
5907 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5908 (update_theme_scrollbar_width, xg_create_scroll_bar):
5909 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5910 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5911 (is_box_type): New function (Bug#11768).
5912 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5913 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5914 with default display (Bug#11768).
5915
d6e7bf45
EZ
59162012-07-05 Eli Zaretskii <eliz@gnu.org>
5917
5918 * xdisp.c (window_hscroll_limited): New function.
5919 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5920 coordinates when window's hscroll is set to insanely large
5921 values. (Bug#11857)
5922
431391ec
JB
59232012-07-05 Juanma Barranquero <lekktu@gmail.com>
5924
5925 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5926 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5927
23f86fce
DA
59282012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5929
5930 Cleanup xmalloc.
5931 * lisp.h (xzalloc): New prototype. Omit needless casts.
5932 * alloc.c (xzalloc): New function. Omit needless casts.
5933 * charset.c: Omit needless casts. Convert all calls to
5934 xmalloc with following memset to xzalloc.
5935 * dispnew.c: Likewise.
5936 * fringe.c: Likewise.
5937 * image.c: Likewise.
5938 * sound.c: Likewise.
5939 * term.c: Likewise.
5940 * w32fns.c: Likewise.
5941 * w32font.c: Likewise.
5942 * w32term.c: Likewise.
5943 * xfaces.c: Likewise.
5944 * xfns.c: Likewise.
5945 * xterm.c: Likewise.
5946 * atimer.c: Omit needless casts.
5947 * buffer.c: Likewise.
5948 * callproc.c: Likewise.
5949 * ccl.c: Likewise.
5950 * coding.c: Likewise.
5951 * composite.c: Likewise.
5952 * doc.c: Likewise.
5953 * doprnt.c: Likewise.
5954 * editfns.c: Likewise.
5955 * emacs.c: Likewise.
5956 * eval.c: Likewise.
5957 * filelock.c: Likewise.
5958 * fns.c: Likewise.
5959 * gtkutil.c: Likewise.
5960 * keyboard.c: Likewise.
5961 * lisp.h: Likewise.
5962 * lread.c: Likewise.
5963 * minibuf.c: Likewise.
5964 * msdos.c: Likewise.
5965 * print.c: Likewise.
5966 * process.c: Likewise.
5967 * region-cache.c: Likewise.
5968 * search.c: Likewise.
5969 * sysdep.c: Likewise.
5970 * termcap.c: Likewise.
5971 * terminal.c: Likewise.
5972 * tparam.c: Likewise.
5973 * w16select.c: Likewise.
5974 * w32.c: Likewise.
5975 * w32reg.c: Likewise.
5976 * w32select.c: Likewise.
5977 * w32uniscribe.c: Likewise.
5978 * widget.c: Likewise.
5979 * xdisp.c: Likewise.
5980 * xmenu.c: Likewise.
5981 * xrdb.c: Likewise.
5982 * xselect.c: Likewise.
5983
0497dc44
PE
59842012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5985
5986 * fileio.c (time_error_value): Check the right error number.
5987 Problem reported by Troels Nielsen in
5988 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5989
356e7178
PE
59902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5991
4e71fd89
PE
5992 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5993 This should be fixed in a better way; see Eli Zaretskii in
5994 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5995 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5996
f0941253
PE
5997 * fileio.c (time_error_value): Rename from special_mtime.
5998 The old name's problems were noted by Eli Zaretskii in
5999 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
6000
065c9eb4
PE
6001 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
6002 This variable's comment says Emacs needs at least one GDB-visible
6003 symbol of type enum pvec_type, to work around GDB problems.
6004 The symbol's value doesn't matter.
6005
356e7178
PE
6006 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
6007 that causes compilation to fail on pre-C99 compilers.
6008
ed9265fc 60092012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
6010
6011 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
6012 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
6013
3884d954
DA
60142012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6015
d209e2fb 6016 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
6017 headers for buffer_defaults and buffer_local_symbols.
6018 Reported by Juanma Barranquero <lekktu@gmail.com>.
6019
ee28be33
SM
60202012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6021
6022 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
6023 * lisp.h (enum pvec_type): Use fewer bits.
6024 (PSEUDOVECTOR_SIZE_BITS): New constant.
6025 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
6026 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
6027 change in pvec_type.
6028 (PSEUDOVECTOR_TYPEP): New macro.
6029 (TYPED_PSEUDOVECTORP): Use it.
6030 * fns.c (internal_equal): Adapt code to extract pvectype.
6031 * emacs.c (gdb_pvec_type): Update type.
6032 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
6033 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
6034 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
6035 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
6036 (sweep_vectors): Use it. Use local var `total_bytes' instead of
6037 abusing vector->header.next.nbytes.
6038 (live_vector_p): Use PVEC_TYPE.
6039 (mark_object): Adapt code to extract pvectype. Use switch.
6040
c7f2cd7f
PE
60412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6042
6043 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
6044 Tighten new eassert a bit.
6045
8ce70ed2
DA
60462012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6047
6048 Fix compilation with --enable-gcc-warnings and -O1
6049 optimization level.
6050 * doprnt.c (doprnt): Change type of tem to int, initialize
6051 to avoid compiler warning. Add eassert.
6052 * search.c (simple_search): Initialize match_byte to avoid
6053 compiler warning. Add eassert.
6054
dea7f1e5
PE
60552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6056
24a212eb
PE
6057 Avoid weird behavior with large horizontal scrolls.
6058 Without this change, for example, large hscroll values would
6059 mess up Emacs's display on Fedora 15 x86, presumably due to
6060 overflows in int calculations in the display code.
6061 Also, if buffers had long lines, Emacs would freeze.
6062 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
6063 (set_window_hscroll): New function, containing the old guts of
6064 Fset_window_hscroll. Return the clipped value.
6065 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
6066 This avoids the need to check against PTRDIFF_MAX.
6067
dea7f1e5
PE
6068 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
6069
76046526
DA
60702012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6071
6072 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
6073
39adff0d
PE
60742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6075
63807d47
PE
6076 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
6077 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
6078 since GCC 4.4.6 issues a bogus warning for them.
6079
39adff0d
PE
6080 Fix bugs in file timestamp newness comparisons.
6081 * fileio.c (Ffile_newer_than_file_p):
6082 * lread.c (Fload): Use full timestamp resolution of files,
6083 not just the 1-second resolution, so that files that are only
6084 slightly newer still count as newer.
6085 * fileio.c (Ffile_newer_than_file_p): Don't assume file
6086 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
6087
dbeed9a6
PE
60882012-07-03 Paul Eggert <eggert@cs.ucla.edu>
6089
6090 * fileio.c: Improve handling of file time marker. (Bug#11852)
6091 (special_mtime): New function.
6092 (Finsert_file_contents, Fverify_visited_file_modtime):
6093 Use it to set special mtime values consistently.
6094
636334d6
AS
60952012-07-03 Andreas Schwab <schwab@linux-m68k.org>
6096
6097 * fileio.c (Finsert_file_contents): Properly handle st_mtime
6098 marker for non-existing file. (Bug#11852)
6099
e2017fe2
GM
61002012-07-03 Glenn Morris <rgm@gnu.org>
6101
6102 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
6103 and did not make it into globals.h).
6104
404dbd37
TT
61052012-07-03 Tom Tromey <tromey@redhat.com>
6106
6107 * window.c (Fset_window_margins, Fset_window_fringes)
6108 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
6109 * textprop.c (Fprevious_property_change): No longer static.
6110 * syntax.c (Fsyntax_table_p): No longer static.
6111 * process.c (Fget_process, Fprocess_datagram_address): No longer
6112 static.
6113 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
6114 * keyboard.c (Fcommand_execute): No longer static.
6115 Remove EXFUN.
6116 * insdel.c (Fcombine_after_change_execute): No longer static.
6117 * image.c (Finit_image_library): No longer static.
6118 * fileio.c (Fmake_symbolic_link): No longer static.
6119 * eval.c (Ffetch_bytecode): No longer static.
6120 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
6121 * doc.c (Fdocumentation_property, Fsnarf_documentation):
6122 No longer static.
404dbd37
TT
6123 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
6124 static.
6125 * dired.c (Ffile_attributes): No longer static.
6126 * composite.c (Fcomposition_get_gstring): No longer static.
6127 * callproc.c (Fgetenv_internal): No longer static.
6128
6129 * ccl.h: Remove EXFUNs.
6130 * buffer.h: Remove EXFUNs.
6131 * dispextern.h: Remove EXFUNs.
6132 * intervals.h: Remove EXFUNs.
6133 * fontset.h: Remove EXFUN.
6134 * font.h: Remove EXFUNs.
6135 * dosfns.c (system_process_attributes): Remove EXFUN.
6136 * keymap.h: Remove EXFUNs.
6137 * lisp.h: Remove EXFUNs.
6138 * w32term.h: Remove EXFUNs.
6139 * window.h: Remove EXFUNs.
6140 * xsettings.h: Remove EXFUN.
6141 * xterm.h: Remove EXFUN.
6142
8e4fd1e1
GM
61432012-07-03 Glenn Morris <rgm@gnu.org>
6144
6145 * lisp.h (Frandom): Make it visible to C.
6146 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
6147 buffer for invisible buffers. (Bug#1229)
6148
ca95b3eb
DA
61492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6150
6151 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
6152 values which aren't power of 2.
14ae4239
BT
6153 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
6154 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
6155 accordingly.
6156
7555c33f
SM
61572012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
6158
6159 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
6160
6161 * alloc.c (mark_object): Revert part of last patch to use `switch'.
6162
d12e8f5a
DA
61632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6164
6165 * alloc.c (allocate_vector_block): Remove redundant
6166 calls to mallopt if DOUG_LEA_MALLOC is defined.
6167 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
6168 avoid calls to mallopt if zero_vector is returned.
6169
296094c3
DA
61702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6171
6172 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
6173 is enabled, avoid dereferencing NULL current_sblock if
6174 running undumped.
6175
36429c89
DA
61762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6177
6178 Cleanup basic buffer management.
6179 * buffer.h (struct buffer): Change layout to use generic vector
6180 marking code. Fix some comments. Change type of 'clip_changed'
6181 to bitfield. Remove unused #ifndef old.
6182 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
6183 (GET_OVERLAYS_AT): Fix indentation.
6184 (for_each_per_buffer_object_at): New macro.
6185 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
6186 (Fbuffer_local_variables): Use it.
6187 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
6188 * alloc.c (allocate_buffer): Adjust to match new layout of
6189 struct buffer. Fix comment.
6190 (mark_overlay): New function.
6191 (mark_buffer): Use it. Use mark_vectorlike to mark normal
6192 Lisp area of struct buffer.
6193 (mark_object): Use it. Adjust marking of misc objects
6194 and related comments.
6195
3b3e4cac
PE
61962012-07-02 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
6199 wrapper that is not needed because the wrapped code is a no-op (zero
6200 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
6201 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
6202
cf5c0175
DA
62032012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
6204
6205 * alloc.c (mark_buffer): Simplify. Remove prototype.
6206 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 6207 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
6208 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
6209 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 6210
ca26824c
GM
62112012-06-30 Glenn Morris <rgm@gnu.org>
6212
2e4c5312
GM
6213 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
6214
ca26824c
GM
6215 * epaths.in (PATH_SITELOADSEARCH): New.
6216 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
6217 This is rather than relying on --enable-locallisppath elements
6218 having "site-lisp" in their names. (Bug#10208#25, 11658)
6219
0d23c240
EZ
62202012-06-30 Eli Zaretskii <eliz@gnu.org>
6221
c9240d7a
EZ
6222 * w32proc.c (sys_select): Accept and ignore one more argument.
6223
6224 * w32.c (emacs_gnutls_pull): Call select with one more argument.
6225
0d23c240 6226 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 6227 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
6228
6229 * sysdep.c: Don't include dos.h and dosfns.h.
6230
6231 * process.c (sys_select):
6232 * msdos.c (sys_select): Accept one more argument and ignore it.
6233
6234 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
6235 adapt data types and code to that.
6236
6237 * dosfns.c:
6238 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
6239 which clashes with the gnulib function of the same name.
6240
af5a5a98
AS
62412012-06-30 Andreas Schwab <schwab@linux-m68k.org>
6242
c5e4379c
AS
6243 * font.c (font_style_to_value, font_style_symbolic)
6244 (font_prop_validate_style): Add type checks for values in
6245 font_style_table.
6246
af5a5a98
AS
6247 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
6248 argument.
6249 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
6250 uses.
6251
8d38f461
EZ
62522012-06-29 Eli Zaretskii <eliz@gnu.org>
6253
2e5a6631
EZ
6254 * xdisp.c (try_window_id): Undo last change.
6255
8d38f461
EZ
6256 * w32.c (getwd): Adjust commentary about startup_dir.
6257 (init_environment): Always call sys_access, even in non-MSVC
6258 builds. Don't chdir to the directory of the Emacs executable.
6259 This undoes code from 1997 which was justified by the need to
6260 "avoid conflicts when removing and renaming directories". But its
6261 downside was that every relative file name was being interpreted
6262 relative to the directory of the Emacs executable, which can never
6263 be TRT. In particular, it broke sys_access when called with
6264 relative file names.
6265 (sys_access): Map GetLastError to errno.
6266
2af3565e
DA
62672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6268
6269 * window.h (struct window): Change type of 'fringes_outside_margins'
6270 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 6271 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
6272 Adjust comment.
6273 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
6274 to ptrdiff_t.
6275
c8d3a25c 62762012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 6277
c8d3a25c
GM
6278 * gnutls.c (emacs_gnutls_handshake):
6279 Add QUIT to make the loop interruptible.
57570cd3 6280
c8d3a25c 62812012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 6282
c8d3a25c
GM
6283 * charset.c (init_charset): Make lack of etc/charsets fatal.
6284
3e984ee8
DA
62852012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6286
6287 * editfns.c (region_limit): Fix type mismatch.
6288
ef884f23
DA
62892012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6290
6291 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
6292 undefined. Convert from xassert to eassert.
6293 * nsmenu.m: Convert from xassert to eassert.
6294 * nsterm.m: Likewise.
6295
7d7e0027
SM
62962012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
6297
6298 * editfns.c (region_limit): Clip to narrowing (bug#11770).
6299
aa754e6a
PE
63002012-06-28 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 Avoid integer overflow on scroll-left and scroll-right.
6303 * window.c (HSCROLL_MAX): New macro.
6304 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
6305 overflow when requested scroll falls outside ptrdiff_t range.
6306
80b00b08
DA
63072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6308
6309 * window.h (struct window): Change type of 'hscroll',
6310 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
6311 'last_modified' and 'last_overlay_modified' to EMACS_INT.
6312 Adjust users accordingly.
6313 * xdisp.c (try_cursor_movement): Replace type check with eassert.
6314 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
6315 from EMACS_INT to ptrdiff_t.
6316 (make_window): Omit redundant initialization.
6317
62b2bcf6
JB
63182012-06-28 Juanma Barranquero <lekktu@gmail.com>
6319
6320 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
6321
45942c7d
DA
63222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6323
6324 * window.h (struct window): Change type of 'use_time' and
6325 'sequence_number' from Lisp_Object to int.
6326 * frame.c (make_frame): Adjust users accordingly.
6327 * print.c (print_object): Likewise.
6328 * window.c (select_window, Fwindow_use_time, make_parent_window)
6329 (make_window): Likewise.
6330
e509cfa6
DA
63312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6332
6333 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
6334 enabled with --enable-checking=[all,glyphs] configure option.
6335 Fix GLYPH_DEBUG usage assuming that it may be undefined,
6336 adjust comments accordingly.
6337 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
6338 undefined, adjust comments accordingly.
6339 * image.c: Likewise.
6340 * scroll.c: Likewise.
6341 * w32fns.c: Likewise.
6342 * w32term.c: Likewise.
6343 * xdisp.c: Likewise.
6344 * xfaces.c: Likewise.
6345 * xfns.c: Likewise.
6346 * xterm.c: Likewise.
6347
a54e2c05
DA
63482012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6349
6350 Generalize run-time debugging checks.
6351 * dispextern.h (XASSERTS): Remove.
6352 * fontset.c (xassert): Remove.
6353 Convert from xassert to eassert.
6354 * alloc.c: Convert from xassert to eassert.
6355 * bidi.c: Likewise.
6356 * dispnew.c: Likewise.
6357 * fns.c: Likewise.
6358 * fringe.c: Likewise.
6359 * ftfont.c: Likewise.
6360 * gtkutil.c: Likewise.
6361 * image.c: Likewise.
6362 * keyboard.c: Likewise.
6363 * menu.c: Likewise.
6364 * process.c: Likewise.
6365 * scroll.c: Likewise.
6366 * sound.c: Likewise.
6367 * term.c: Likewise.
6368 * w32console.c: Likewise.
6369 * w32fns.c: Likewise.
6370 * w32term.c: Likewise.
6371 * window.c: Likewise.
6372 * xdisp.c: Likewise.
6373 * xfaces.c: Likewise.
6374 * xfns.c: Likewise.
6375 * xselect.c: Likewise.
6376 * xterm.c: Likewise.
6377
1ec4b7b2
SM
63782012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
6379
6380 * fns.c (maybe_resize_hash_table): Output message when growing the
6381 purify-hashtable.
6382
2014308a
DA
63832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6384
6385 * alloc.c (allocate_string_data): Remove dead code.
6386 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
6387 avoid GCC warning about unused macro.
6388
246155eb
DA
63892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6390
6391 * alloc.c (allocate_string): Omit intervals initialization.
6392 * alloc.c (make_uninit_multibyte_string): Initialize intervals
6393 as in make_pure_string and make_pure_c_string.
6394
43184b7b
DA
63952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6396
d209e2fb 6397 * alloc.c (allocate_string): Fix last change.
43184b7b 6398
3fe6dd74
DA
63992012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6400
d209e2fb 6401 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
6402 to memset, add explicit initialization where appropriate.
6403
1ba6038a
GM
64042012-06-27 Glenn Morris <rgm@gnu.org>
6405
6406 * lisp.mk (lisp): Remove paths.elc.
6407
c89926a5
CY
64082012-06-27 Chong Yidong <cyd@gnu.org>
6409
6410 * doc.c (Fsubstitute_command_keys): Fix punctuation.
6411
ed6b3510
JW
64122012-06-26 John Wiegley <johnw@newartisans.com>
6413
1ec4b7b2 6414 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
6415 on Mac OS X Lion: __mod_init_func and __mod_term_func.
6416
ed6b3510
JW
6417 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
6418 when building with Clang.
6419
8edd4a2b
SM
64202012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
6421
6422 * eval.c (Fapply): Allow calling it with a single argument.
6423
f6f62d1b
EZ
64242012-06-26 Eli Zaretskii <eliz@gnu.org>
6425
6426 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
6427 _stricmp and _strnicmp.
6428 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
6429
62efea5e
DA
64302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6431
6432 * alloc.c (allocate_window): Zero out non-Lisp part of newly
6433 allocated window.
6434 (allocate_process): Likewise for new process.
8edd4a2b 6435 (allocate_terminal): Change to use offsetof.
62efea5e
DA
6436 (allocate_frame): Likewise.
6437 * frame.c (make_frame): Omit redundant initialization.
6438 * window.c (make_parent_window): Use memset.
6439 (make_window): Omit redundant initialization.
6440 * process.c (make_process): Omit redundant initialization.
6441 * terminal.c (create_terminal): Likewise.
6442
42997f4d
DA
64432012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6444
6445 * term.c (delete_tty): Remove redundant call to memset.
6446
1130ecfc
DA
64472012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6448
6449 * alloc.c: Remove build_string.
6450 * lisp.h: Define build_string as static inline. This provides
6451 a better opportunity to optimize away calls to strlen when the
6452 function is called with compile-time constant argument.
6453 * image.c (imagemagick_error): Convert to build_string.
6454 * w32proc.c (sys_spawnve): Likewise.
6455 * xterm.c (x_term_init): Likewise.
6456
cf38a720
PE
64572012-06-26 Paul Eggert <eggert@cs.ucla.edu>
6458
99027bdd
PE
6459 Use sprintf return value instead of invoking strlen on result.
6460 In the old days this wasn't portable, since some sprintf
6461 implementations returned char *. But they died out years ago and
6462 Emacs already assumes sprintf returns int.
6463 Similarly for float_to_string.
6464 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
6465 * ccl.c (ccl_driver):
6466 * character.c (string_escape_byte8):
6467 * data.c (Fnumber_to_string):
6468 * doprnt.c (doprnt):
6469 * print.c (print_object):
6470 * xdisp.c (message_dolog):
6471 * xfns.c (syms_of_xfns):
6472 Use sprintf or float_to_string result to avoid need to call strlen.
6473 * data.c (Fnumber_to_string):
6474 Use make_unibyte_string, since the string must be ASCII.
6475 * lisp.h, print.c (float_to_string): Now returns int length.
6476 * term.c (produce_glyphless_glyph):
6477 Use sprintf result rather than recomputing it.
6478
cf38a720
PE
6479 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
6480 * Makefile.in (ALL_CFLAGS):
6481 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6482 * gmalloc.c, regex.c: Include <config.h> unconditionally.
6483
3511c784
DA
64842012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6485
0a08eb21 6486 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
6487 strcasecmp if available.
6488 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6489
fb7da12e
AS
64902012-06-25 Andreas Schwab <schwab@linux-m68k.org>
6491
6492 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
6493 Avoid comma operator.
6494 * menu.c (push_submenu_start, push_submenu_end)
6495 (push_left_right_boundary, push_menu_pane): Likewise.
6496 * msdos.c (dos_rawgetc): Likewise.
6497
afa2ffd8
DA
64982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6499
6500 * xfns.c (xic_create_fontsetname): Remove redundant calls
6501 to memset.
6502
b3b4476b
PE
65032012-06-25 Paul Eggert <eggert@cs.ucla.edu>
6504
4495ff38
PE
6505 * gtkutil.c (get_utf8_string): Remove redundant assignment.
6506 sprintf already null-terminates its output.
6507
b3b4476b
PE
6508 * xfns.c (x_window): Remove redundant cast.
6509
b00876c9
DA
65102012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6511
6512 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
6513 `const char *' to `char *' to avoid compiler warning.
6514
d188e26b
PE
65152012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6516
885d1d74
PE
6517 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
6518 instead of truncating it to 63 (admittedly a generous limit).
6519
d188e26b
PE
6520 * process.c: Fix spelling and caps in comments.
6521
e2f560b1
DN
65222012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
6523
e86db54b 6524 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
6525 * sysdep.c (setpgrp): Remove definition, not used in this file.
6526
7583a3a1
JB
65272012-06-24 Juanma Barranquero <lekktu@gmail.com>
6528
6529 * makefile.w32-in: Update dependencies.
6530
696056c2
EZ
65312012-06-24 Eli Zaretskii <eliz@gnu.org>
6532
6533 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
6534 (SYSTIME_H): Add nt/inc/sys/time.h.
6535
6536 * systime.h [WINDOWSNT]: Include sys/time.h.
6537
6538 * s/ms-w32.h (struct timespec): Definition moved from
6539 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
6540
845ca893
PE
65412012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
6544 * buffer.h (buffer_slot_type_mismatch):
6545 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6546 * eval.c (unwind_to_catch):
6547 * image.c (my_png_error, my_error_exit):
6548 * keyboard.c (quit_throw_to_read_char, user_error)
6549 (Fexit_recursive_edit, Fabort_recursive_edit):
6550 * lisp.h (die, args_out_of_range, args_out_of_range_3)
6551 (wrong_type_argument, buffer_overflow, __executable_start)
6552 (memory_full, buffer_memory_full, string_overflow, Fthrow)
6553 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
6554 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
6555 (fatal):
6556 (child_setup) [!DOS_NT]:
6557 * lread.c (end_of_file_error, invalid_syntax):
6558 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6559 * puresize.h (pure_write_error):
6560 * search.c (matcher_overflow):
6561 * sound.c (sound_perror, alsa_sound_perror):
6562 * sysdep.c, syssignal.h (croak):
6563 * term.c (maybe_fatal, vfatal):
6564 * textprop.c (text_read_only):
6565 * undo.c (user_error):
6566 * unexmacosx.c (unexec_error):
6567 * xterm.c (x_ins_del_lines, x_delete_glyphs):
6568 Use _Noreturn rather than NO_RETURN.
6569 No need for separate decl merely because of _Noreturn.
6570 * sound.c (sound_warning, parse_sound):
6571 Remove unnecessary forward decls.
6572
f1dd8073
PE
65732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6574
6575 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
6576 * lisp.h (WAIT_READING_MAX): New macro.
6577 * dispnew.c (Fsleep_for, sit_for):
6578 * keyboard.c (kbd_buffer_get_event):
6579 * process.c (Faccept_process_output):
6580 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
6581 This improves on the previous patch, which introduced a bug
6582 when time_t is unsigned and as wide as intmax_t.
6583 See <http://bugs.gnu.org/9000#51>.
6584
b82c1755
EZ
65852012-06-23 Eli Zaretskii <eliz@gnu.org>
6586
6587 * dispnew.c (sit_for, Fsleep_for):
6588 * keyboard.c (kbd_buffer_get_event):
6589 * process.c (Faccept_process_output): Avoid compiler warnings when
6590 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
6591
ca300656
JB
65922012-06-23 Juanma Barranquero <lekktu@gmail.com>
6593
049ec95b
JB
6594 * makefile.w32-in: Update dependencies.
6595
ca300656
JB
6596 * w32.c (ltime): Add return type and declare static.
6597 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
6598
db7b8d06
PE
65992012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6600
6601 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
6602 Privately reported by Herbert J. Skuhra.
6603 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6604 All uses changed.
6605 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
6606 not make_lisp_timeval, when the argument is of type EMACS_TIME.
6607
0bd8297f
EZ
66082012-06-23 Eli Zaretskii <eliz@gnu.org>
6609
96512555
EZ
6610 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
6611 last argument of make_unibyte_string.
6612
0bd8297f
EZ
6613 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
6614 language ID in the event parameters.
6615
6616 * w32term.c (w32_read_socket): Put the new keyboard codepage into
6617 event.code, not the obscure "character set ID".
6618
63def6b6
CY
66192012-06-23 Chong Yidong <cyd@gnu.org>
6620
6621 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
6622
e8a02204
EZ
66232012-06-23 Eli Zaretskii <eliz@gnu.org>
6624
388cdec0
EZ
6625 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
6626 * w32.c (fdutimens): New function.
6627
6628 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
6629
6630 * s/ms-w32.h (pselect): Redirect to sys_select.
6631
6632 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
6633
e8a02204
EZ
6634 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
6635 in the logic of incrementing and decrementing the value of
6636 use_relocatable_buffers.
6637
d054f3fb
PE
66382012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6639
6640 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
6641 Privately reported by Herbert J. Skuhra.
6642 [__FreeBSD__]: Remove "*/" typo after "#include".
6643 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
6644 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
6645 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
6646 Don't assume EMACS_TIME and struct timeval are the same type.
6647
d35af63c
PE
66482012-06-22 Paul Eggert <eggert@cs.ucla.edu>
6649
6650 Support higher-resolution time stamps (Bug#9000).
6651 The time stamps are only nanosecond-resolution at the C level,
6652 since that's the best that any real-world system supports now.
6653 But they are picosecond-resolution at the Lisp level, as that's
6654 easy, and leaves room for future OS improvements.
6655
6656 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
6657 (LIBES): Use it.
6658
6659 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
6660 Don't get current time unless it's needed.
6661
6662 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
6663 now provides it if it's absent.
6664 (start_atimer): Port to higher-res time stamps.
6665 Check for time stamp overflow. Don't get current time more
6666 often than is needed.
6667
6668 * buffer.h (struct buffer): Buffer modtime now has high resolution.
6669 Include systime.h, not time.h.
6670 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
6671
6672 * dired.c: Include stat-time.h.
6673 (Ffile-attributes): File times now have higher resolution.
6674
6675 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
6676 (struct image): Timestamp now has higher resolution.
6677
6678 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
6679 has at least microseconds now. All uses removed.
6680 (update_frame, update_single_window, update_window, update_frame_1)
6681 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 6682 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
6683
6684 * editfns.c (time_overflow): Now extern.
6685 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
6686 (float-time, Fformat_time_string, Fcurrent_time_string)
6687 (Fcurrent_time_zone): Accept and generate higher-resolution
6688 time stamps.
6689 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
6690 (decode_time_components, lisp_seconds_argument): New functions.
6691 (make_time): Now static.
6692 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
6693 Report an error if the time is invalid, rather than having the caller
6694 do that.
6695
6696 * fileio.c: Include <stat-time.h>
6697 (Fcopy_file): Copy higher-resolution time stamps.
6698 Prefer to set the time stamp via a file descriptor if that works.
6699 (Fset_file_times, Finsert_file_contents, Fwrite_region)
6700 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
6701 (Fvisited_file_modtime, Fset_visited_file_modtime):
6702 Support higher-resolution time stamps.
6703
6704 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
6705
6706 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
6707
6708 * image.c (prepare_image_for_display, clear_image_cache)
6709 (lookup_image): Port to higer-resolution time stamps.
6710
6711 * keyboard.c (start_polling, bind_polling_period):
6712 Check for time stamp overflow.
6713 (read_char, kbd_buffer_get_event, timer_start_idle)
6714 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
6715 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
6716 Port to higher-resolution time stamps. Do not assume time_t is signed.
6717 (decode_timer): New function. Timers are now vectors of length 9,
6718 not 8, to accommodate the picosecond component.
6719 (timer_check_2): Use it.
6720
6721 * nsterm.m (select_timeout, timeval_subtract): Remove.
6722 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
6723 as they're a bit more accurate and handle overflow better.
6724 (ns_select): Change prototype to be compatible with pselect.
6725 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
6726 * nsterm.h (ns_select): Adjust prototype.
6727
6728 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
6729 us-resolution time stamps.
6730 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
6731
6732 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
6733
6734 * lisp.h (time_overflow): New decl.
6735 (wait_reading_process_output): First arg is now intmax_t, not int,
6736 to accommodate larger waits.
6737
6738 * process.h (struct Lisp_Process.read_output_delay):
6739 Now counts nanoseconds, not microseconds.
6740 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
6741 EMACS_HAS_USECS.
6742 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
6743 (wait_reading_process_output):
6744 Port to ns-resolution time stamps.
6745 (Faccept_process_output, wait_reading_process_output):
6746 Check for time stamp overflow. Do not assume time_t is signed.
6747 (select_wrapper): Remove; we now use pselect.
6748 (Fprocess_attributes): Now generates ns-resolution time stamps.
6749
6750 * sysdep.c: Include utimens.h. Don't include utime.h
6751 or worry about struct utimbuf; gnulib does that for us now.
6752 (gettimeofday): Remove; gnulib provides a substitute.
6753 (make_timeval): New function.
6754 (set_file_times): Now sets ns-resolution time stamps.
6755 New arg FD; all uses changed.
6756 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6757 (system_process_attributes):
6758 Now returns ns-resolution time stamp. All uses changed.
6759 Check for time stamp overflow.
6760
6761 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6762 provides a substitute now.
6763
6764 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6765 since it guarantees struct timespec.
6766 (EMACS_TIME): Now struct timespec, so that we can support
6767 ns-resolution time stamps.
6768 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6769 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6770 (EMACS_USECS): Remove.
6771 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6772 so multiply the arg by 1000 before storing it.
6773 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6774 New macros.
6775 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6776 Port to ns-resolution time stamps.
6777 (EMACS_TIME_NEG_P): Remove; replaced by....
6778 (EMACS_TIME_SIGN): New macro.
6779 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6780 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6781 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6782 (make_timeval, make_lisp_time, decode_time_components): New decls.
6783 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6784 that it mishandled time_t overflow. You can't compare by subtracting!
6785 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6786 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6787
6788 * term.c: Include <sys/time.h>.
6789 (timeval_to_Time): New function, for proper overflow wraparound.
6790 (term_mouse_position, term_mouse_click): Use it.
6791
6792 * undo.c (record_first_change): Support higher-resolution time stamps
6793 in the undo buffer.
6794 (Fprimitive_undo): Use them when restoring time stamps.
6795
6796 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6797 (w32_get_internal_run_time):
6798 Port to higher-resolution Emacs time stamps.
6799 (ltime): Now accepts single 64-bit integer, as that's more convenient
6800 for callers.
6801
6802 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6803
6804 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6805 for compatibility with pselect. Support ns-resolution time stamps.
6806
6807 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6808
6809 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6810 Check for time stamp overflow, and support ns-resolution time stamps.
6811
6812 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6813 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6814 (timeval_subtract): Remove; no longer needed.
6815 (XTflash, XTring_bell, x_wait_for_event):
6816 Port to ns-resolution time stamps. Don't assume time_t is signed.
6817
b6a92dfe
CY
68182012-06-22 Chong Yidong <cyd@gnu.org>
6819
6820 * xdisp.c (x_consider_frame_title): Revert last change.
6821
d251c37c
EZ
68222012-06-22 Eli Zaretskii <eliz@gnu.org>
6823
6824 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6825 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6826 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6827 staticidx goes up to 1597 out of 1600 = 0x640.)
6828
f10deafb
PE
68292012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6830
6831 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6832 Otherwise, the umask might be mistakenly 0 while handling input signals.
6833
ec6de1e2
SM
68342012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6835
6836 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6837
28be1ada
DA
68382012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6839
6840 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6841 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6842 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6843 access to `contents' member of Lisp_Vector objects with AREF and ASET
6844 where appropriate.
6845
c6bf3022
CY
68462012-06-19 Chong Yidong <cyd@gnu.org>
6847
6848 * frame.c (delete_frame): When selecting a frame on a different
6849 text terminal, do not alter the terminal's top-frame.
6850
6851 * xdisp.c (format_mode_line_unwind_data): Record the target
6852 frame's selected window and its terminal's top-frame.
6853 (unwind_format_mode_line): Restore them.
6854 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6855 Callers changed.
6856 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6857 since tty frames can be explicitly named.
6858 (prepare_menu_bars): Likewise.
6859
6860 * term.c (Ftty_top_frame): New function.
6861
defd4196
PE
68622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6863
6864 Port byte-code-meter to modern targets.
6865 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6866 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6867 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6868 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6869 (METER_1, METER_2): Simplify.
6870
1053a871
SM
68712012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6872
6873 * data.c (Fdefalias): Return `symbol' (bug#11686).
6874
b7e8d081
MR
68752012-06-18 Martin Rudalics <rudalics@gmx.at>
6876
6877 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6878 gets killed during executing of this function (Bug#11665).
6879 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6880 (Vkill_buffer_query_functions): In doc-string say that functions
6881 run by this hook should not change the current buffer.
6882
7ea2b339
PE
68832012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6884
6885 Fix recently-introduced process.c problems found by static checking.
6886 * process.c (write_queue_push, write_queue_pop, send_process):
6887 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6888 (write_queue_pop): Fix pointer signedness problem.
6889 (send_process): Remove unused local.
6890
96a313a1
CY
68912012-06-17 Chong Yidong <cyd@gnu.org>
6892
6893 * xdisp.c (redisplay_internal): No need to redisplay terminal
6894 frames that are not on top.
6895
20ca2e94
TN
68962012-06-17 Troels Nielsen <bn.troels@gmail.com>
6897
6898 * process.c (make_process): Initialize write_queue.
6899 (write_queue_push, write_queue_pop): New functions.
6900 (send_process): Use them to maintain correct ordering of process
6901 writes (Bug#10815).
6902
9a900ca9
PE
69032012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6904
310fbfa8
PE
6905 * lisp.h (eassert): Assume C89 or later.
6906 This removes the need for CHECK.
6907 (CHECK): Remove. Its comments about always evaluating its
6908 argument were confusing, as 'eassert' typically does not evaluate
6909 its argument.
6910
27bb1ca4
PE
6911 * coding.c (produce_chars): Use ptrdiff_t, not int.
6912
9a900ca9
PE
6913 * xterm.c (x_draw_underwave): Check for integer overflow.
6914 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6915
41b7f8bc 69162012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6917
6918 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6919 referenced (Bug#11583).
6920
9b0e3eba
AA
69212012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6922
6923 Implement wave-style variant of underlining.
6924 * dispextern.h (face_underline_type): New enum.
6925 (face): Add field for underline type.
6926 * nsterm.m (ns_draw_underwave): New function.
6927 (ns_draw_text_decoration): Use it.
6928 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6929 New functions.
6930 (x_draw_glyph_string): Use them.
6931 * xfaces.c (Qline, Qwave): New Lisp objects.
6932 (check_lface_attrs, merge_face_ref)
1053a871
SM
6933 (Finternal_set_lisp_face_attribute, realize_x_face):
6934 Handle wave-style underline face attributes.
9b0e3eba
AA
6935 * xterm.c (x_draw_underwave): New function.
6936 (x_draw_glyph_string): Use it.
6937
0fb52f11
JB
69382012-06-16 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6941 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6942 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6943 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6944 ($(BLD)/w32select.$(O)): Update dependencies.
6945
e5560ff7
AS
69462012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6947
6948 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6949 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6950 * character.c (_fetch_multibyte_char_p): Remove.
6951 * alloc.c: Include "character.h" before "buffer.h".
6952 * bidi.c: Likewise.
6953 * buffer.c: Likewise.
6954 * bytecode.c: Likewise.
6955 * callint.c: Likewise.
6956 * callproc.c: Likewise.
6957 * casefiddle.c: Likewise.
6958 * casetab.c: Likewise.
6959 * category.c: Likewise.
6960 * cmds.c: Likewise.
6961 * coding.c: Likewise.
6962 * composite.c: Likewise.
6963 * dired.c: Likewise.
6964 * dispnew.c: Likewise.
6965 * doc.c: Likewise.
6966 * dosfns.c: Likewise.
6967 * editfns.c: Likewise.
6968 * emacs.c: Likewise.
6969 * fileio.c: Likewise.
6970 * filelock.c: Likewise.
6971 * font.c: Likewise.
6972 * fontset.c: Likewise.
6973 * fringe.c: Likewise.
6974 * indent.c: Likewise.
6975 * insdel.c: Likewise.
6976 * intervals.c: Likewise.
6977 * keyboard.c: Likewise.
6978 * keymap.c: Likewise.
6979 * lread.c: Likewise.
6980 * macros.c: Likewise.
6981 * marker.c: Likewise.
6982 * minibuf.c: Likewise.
6983 * nsfns.m: Likewise.
6984 * nsmenu.m: Likewise.
6985 * print.c: Likewise.
6986 * process.c: Likewise.
6987 * regex.c: Likewise.
6988 * region-cache.c: Likewise.
6989 * search.c: Likewise.
6990 * syntax.c: Likewise.
6991 * term.c: Likewise.
6992 * textprop.c: Likewise.
6993 * undo.c: Likewise.
6994 * unexsol.c: Likewise.
6995 * w16select.c: Likewise.
6996 * w32fns.c: Likewise.
6997 * w32menu.c: Likewise.
6998 * window.c: Likewise.
6999 * xdisp.c: Likewise.
7000 * xfns.c: Likewise.
7001 * xmenu.c: Likewise.
7002 * xml.c: Likewise.
7003 * xselect.c: Likewise.
7004
2f07e6af
EZ
70052012-06-16 Eli Zaretskii <eliz@gnu.org>
7006
1053a871
SM
7007 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
7008 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 7009 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
7010 row.
7011 (handle_face_prop): Use chunk-relative overlay string index when
7012 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
7013 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
7014 the rightmost. (Bug#11720)
2f07e6af 7015
29b83cec
AS
70162012-06-16 Andreas Schwab <schwab@linux-m68k.org>
7017
7018 * category.h (CHAR_HAS_CATEGORY): Define as inline.
7019 (CATEGORY_MEMBER): Enforce 1/0 value.
7020 * category.c (_temp_category_set): Remove.
7021
4c5501e9
EZ
70222012-06-16 Eli Zaretskii <eliz@gnu.org>
7023
7024 * window.c (Fdelete_other_windows_internal)
7025 (Fdelete_window_internal): Don't access frame's mouse highlight
7026 info of the initial frame. (Bug#11677)
7027
2b570124
PE
70282012-06-14 Paul Eggert <eggert@cs.ucla.edu>
7029
e93864f9
PE
7030 * .gdbinit (xgetint): Fix recently-introduced paren typo.
7031 Assume USE_2_TAGS_FOR_INTS.
7032 (xreload): Adjust $tagmask width to match recent lisp.h change.
7033
2b570124
PE
7034 Simplify lisp.h in minor ways that should not affect code.
7035 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
7036 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
7037 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
7038 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
7039 (INTTYPEBITS): New macro, for clarity.
7040 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
7041 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
7042 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
7043 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
7044 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
7045
81755f69
JB
70462012-06-13 Juanma Barranquero <lekktu@gmail.com>
7047
7048 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
7049
16192a57
GM
70502012-06-13 Glenn Morris <rgm@gnu.org>
7051
7052 * s/bsd-common.h (BSD4_3):
7053 * s/usg5-4-common.h (USG5_4): No longer define; unused.
7054
646b5f55
AS
70552012-06-13 Andreas Schwab <schwab@linux-m68k.org>
7056
7057 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
7058 instead of union.
7059 (XLI, XIL): Define.
1053a871
SM
7060 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
7061 Use them.
7062 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 7063 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 7064 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
7065 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
7066 * frame.c (delete_frame): Remove outdated comment.
7067 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
7068 USE_LISP_UNION_TYPE.
7069 (Fw32_unregister_hot_key): Likewise.
7070 (Fw32_toggle_lock_key): Likewise.
7071 * w32menu.c (add_menu_item): Likewise.
7072 (w32_menu_display_help): Use XIL instead of checking
7073 USE_LISP_UNION_TYPE.
7074 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
7075 (init_heap): Likewise.
7076 * w32term.c (w32_read_socket): Update comment.
7077
1d3823c9
GM
70782012-06-13 Glenn Morris <rgm@gnu.org>
7079
c62ff706
GM
7080 * s/usg5-4-common.h, src/s/unixware.h:
7081 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
7082
1d3823c9
GM
7083 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
7084
bfe3e0a2
PE
70852012-06-13 Paul Eggert <eggert@cs.ucla.edu>
7086
7087 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
7088 * alloc.c (make_number) [!defined make_number]:
7089 Remove, as lisp.h always defines this now.
7090 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
7091 (roundup_size): Verify that it is a power of 2.
7092 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
7093 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
7094 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
7095 -DUSE_LSB_TAG=0, to override the automatically-selected default.
7096 USE_LSB_TAG now is always defined to be either 0 or 1.
7097 All uses changed.
7098 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
7099 code works fine either way, and efficiency is not a concern here,
7100 as the union type is for debugging, not for production.
7101 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
7102 Use an inline function on all platforms when using the union type,
7103 since this is simpler and 'static inline' can be used portably
7104 within Emacs now.
7105 (LISP_INITIALLY_ZERO): New macro.
7106 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
7107 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
7108
45fa9c0f
GM
71092012-06-12 Glenn Morris <rgm@gnu.org>
7110
b4492cba
GM
7111 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
7112
7113 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 7114
45fa9c0f
GM
7115 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
7116 Move BROKEN_SIGIO to configure.
7117
7118 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
7119 Move NO_TERMIO to configure.
7120
0e25d334
CY
71212012-06-12 Chong Yidong <cyd@gnu.org>
7122
7123 * image.c (imagemagick_load_image): Use MagickFlattenImage if
7124 MagickMergeImageLayers is undefined. Use pixel pusher loop if
7125 MagickExportImagePixels is undefined.
7126
43682bb6
PE
71272012-06-12 Paul Eggert <eggert@cs.ucla.edu>
7128
7129 * image.c (imagemagick_load_image): Remove unused label.
7130
a9be7d2b
GM
71312012-06-11 Glenn Morris <rgm@gnu.org>
7132
7133 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
7134 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
7135 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
7136 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
7137
3017f87f
SM
71382012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
7139
7140 * alloc.c (make_byte_code): New function.
7141 (Fmake_byte_code): Use it. Don't purify here.
7142 * lread.c (read1): Use it as well to avoid extra allocation.
7143
1b9b4cf4
CY
71442012-06-11 Chong Yidong <cyd@gnu.org>
7145
7146 * image.c (imagemagick_load_image): Implement transparency.
7147
95988fcf
AS
71482012-06-10 Andreas Schwab <schwab@linux-m68k.org>
7149
7150 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
7151 account for preceding backslashes. (Bug#11663)
7152
cd4eb164
CY
71532012-06-09 Chong Yidong <cyd@gnu.org>
7154
7155 * term.c: Support italics in capable terminals (Bug#9652).
7156 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
7157 (turn_on_face): Output using TS_enter_italic_mode if available.
7158 Don't handle unused blinking and alt-charset cases.
7159 (turn_off_face): Handle italic case; discard unused tty_blinking_p
7160 and tty_alt_charset_p cases.
7161 (tty_capable_p, init_tty): Support italics.
7162
7163 * termchar.h (struct tty_display_info): Add field for italics.
7164 Remove unused blink field.
7165
7166 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
7167 Handle slant.
7168
7169 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
7170 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
7171 tty_alt_charset_p. Add tty_italic_p.
7172
ff88beb8
MA
71732012-06-09 Michael Albinus <michael.albinus@gmx.de>
7174
7175 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
7176 dbus_type_is_basic if available.
7177 (xd_extract_signed, xd_extract_unsigned): Rename from
7178 extract_signed and extract_unsigned, respectively. Adapt callers.
7179
44286096
CY
71802012-06-09 Chong Yidong <cyd@gnu.org>
7181
1682701f
CY
7182 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
7183
44286096
CY
7184 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
7185 case (Bug#9752).
7186
d86feb17
PE
71872012-06-08 Paul Eggert <eggert@cs.ucla.edu>
7188
7189 * xdisp.c (vmessage): Treat frame message as multibyte.
7190 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
7191 would generate the diagnostic "Making \302\247 buffer-local while
7192 let-bound!".
7193
d5c20fe8
EZ
71942012-06-08 Eli Zaretskii <eliz@gnu.org>
7195
7196 * dispnew.c (showing_window_margins_p): Undo last change, which
7197 was done due to an inadvertent commit.
7198 (adjust_frame_glyphs_for_frame_redisplay): Do call
7199 showing_window_margins_p.
7200
513749ee
SM
72012012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7202
7203 * eval.c (Fmake_var_non_special): New primitive.
7204 (syms_of_eval): Defsubr it.
7205 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
7206
d4a8f5c1
JB
72072012-06-08 Juanma Barranquero <lekktu@gmail.com>
7208
7209 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
7210 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
7211
8bbbc977
EZ
72122012-06-08 Eli Zaretskii <eliz@gnu.org>
7213
7214 * alloc.c (allocate_vectorlike): Fix last change.
7215
f3372c87
DA
72162012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
7217
7218 Block-based vector allocation of small vectors.
7219 * lisp.h (struct vectorlike_header): New field `nbytes',
7220 adjust comment accordingly.
7221 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 7222 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
7223 mark_maybe_pointer, valid_lisp_object_p) accordingly.
7224 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
7225 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
7226 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
7227 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
7228 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
7229 (roundup_size): New constant.
7230 (struct vector_block): New data type.
7231 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 7232 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
7233 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
7234 (sweep_vectors): New functions.
7235 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 7236 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
7237 or equal to VBLOCK_BYTES_MAX.
7238 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
7239 (init_alloc_once): Add call to init_vectors.
7240
4f18a4ed
SM
72412012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7242
7243 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
7244
86f158bc
PE
72452012-06-07 Paul Eggert <eggert@cs.ucla.edu>
7246
7247 * doprnt.c (doprnt): Truncate multibyte char correctly.
7248 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
7249 would mishandle a string argument "Xc" if X was a multibyte
7250 character of length 2: it would truncate after X's first byte
7251 rather than including all of X.
7252
c5cfcbe0
CY
72532012-06-06 Chong Yidong <cyd@gnu.org>
7254
7255 * buffer.c (word_wrap): Doc fix.
7256
c05cf390
PE
72572012-06-04 Paul Eggert <eggert@cs.ucla.edu>
7258
7259 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
7260
0c3461de
GM
72612012-06-03 Glenn Morris <rgm@gnu.org>
7262
7263 * xdisp.c (tool-bar-style): Doc fix.
7264
c71232db
UM
72652012-06-03 Ulrich Müller <ulm@gentoo.org>
7266
7267 * Makefile.in (PAXCTL): Define.
7268 (temacs$(EXEEXT)): Disable memory randomization for the temacs
7269 binary via PaX flags if the paxctl utility is available.
7270 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7271 Restore PaX flags to their default. (Bug#11398)
7272
383f7350
CY
72732012-06-03 Chong Yidong <cyd@gnu.org>
7274
7275 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
7276 buffer (Bug#11226).
7277
5f2c76c6
CY
72782012-06-03 Chong Yidong <cyd@gnu.org>
7279
7280 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
7281 (note_mode_line_or_margin_highlight): If there is no help echo,
7282 use mode-line-default-help-echo. Handle the case where the mouse
7283 position is past the end of the mode line string.
7284
7285 * buffer.c (buffer_local_value_1): New function, split from
7286 Fbuffer_local_value; can return Qunbound.
7287 (Fbuffer_local_value): Use it.
7288 (Vmode_line_format): Docstring tweaks.
7289
773d47f6
PE
72902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7291
7292 * sysdep.c (system_process_attributes): Improve comment.
7293
f2d6a3df
SM
72942012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
7295
7296 * keyboard.c: Export real-this-command to Elisp.
7297 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
7298 and DEFVAR it. Update all users.
7299
63810350
PE
73002012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7301
7bd5c1f4
PE
7302 * minibuf.c (Fassoc_string): Remove duplicate declaration.
7303
63810350
PE
7304 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
7305 Convert pctcpu and pctmem to Lisp float properly.
7306 Let the compiler fold better, as 100.0/0x8000 is exact.
7307
a2821611
AS
73082012-06-02 Andreas Schwab <schwab@linux-m68k.org>
7309
7310 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
7311 cons_block.
7312
5fceba1d
PE
73132012-06-01 Paul Eggert <eggert@cs.ucla.edu>
7314
7315 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
7316
c98ff5dd
DA
73172012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
7318
7319 For a 'struct window', replace some Lisp_Object fields to
7320 bitfields where appropriate, remove unused fields.
7321 * window.h (struct window): Remove unused 'last_mark_x' and
7322 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
7323 change it's type from Lisp_Object to bitfield.
7324 Change type of 'force_start', 'optional_new_start',
7325 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 7326 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 7327
ca34e0be
PE
73282012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7329
7330 Pacify gcc -Wdouble-precision when using Xaw.
7331 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
7332 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
7333 Use 'float' consistently, rather than 'float' in most places
7334 and 'double' in a couple of places.
7335
efc00ab1 73362012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
7337
7338 * xdisp.c (handle_stop): Detect whether we have overlay strings
7339 loaded by testing it->current.overlay_string_index to be
7340 non-negative, instead of checking whether n_overlay_strings is
7341 positive. (Bug#11587)
7342
efc00ab1 73432012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
7344
7345 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
7346
7347 * doc.c (Fsubstitute_command_keys): Doc fix.
7348
efc00ab1 73492012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
7350
7351 * search.c (search_buffer): Remove calls to
7352 r_alloc_inhibit_buffer_relocation, as it is now called by
7353 maybe_unify_char, which was the cause of relocation of buffer text
7354 in bug#11519.
7355
efc00ab1 73562012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
7357
7358 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
7359 for the duration of call to load_charset, to avoid problems with
7360 callers of maybe_unify_char that access buffer text through C
7361 pointers.
7362
7363 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
7364 decrement the inhibition flag, instead of just setting or
7365 resetting it.
7366
ba93a187
PE
73672012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7368
7369 Remove obsolete '#define static' cruft.
7370 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
7371 This #undef was "temporary" in 2000; it is no longer needed
7372 now that '#define static' has gone away.
7373 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
7374 (gray_bitmap_bits): Remove; no longer needed.
7375 All uses replaced with definiens.
7376 * xterm.c: Include "bitmaps/gray.xbm".
7377
9e4bf381
PE
73782012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7379
7380 Clean up __executable_start, monstartup when --enable-profiling.
7381 The following changes affect the code only when profiling.
7382 * dispnew.c (__executable_start): Rename from safe_bcopy.
7383 Define only on platforms that need it.
7384 * emacs.c: Include <sys/gmon.h> when profiling.
7385 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
7386 (__executable_start): Remove decl, since lisp.h does it now.
7387 (safe_bcopy): Remove decl; no longer has that name.
7388 (main): Coalesce #if into single bit of code, for simplicity.
7389 Cast pointers to uintptr_t, since standard libraries want integers
7390 and not pointers.
7391 * lisp.h (__executable_start): New decl.
7392
32d72c2f
GM
73932012-05-31 Glenn Morris <rgm@gnu.org>
7394
7395 * image.c (Fimagemagick_types): Doc fix.
7396
baac5bc7
JM
73972012-05-30 Jim Meyering <meyering@redhat.com>
7398
7399 * callproc.c (Fcall_process_region): Include directory component
7400 in mkstemp error message (Bug#11586).
7401
72cb32cf
PE
74022012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7403
7404 * alloc.c, lisp.h (make_pure_vector): Now static.
7405
61b108cc
SM
74062012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
7407
7408 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
7409 Move to byte-run.el.
7410 (Fautoload): Do the hash-doc more carefully.
7411 * data.c (Fdefalias): Purify definition, except for keymaps.
7412 (Qdefun): Move from eval.c.
7413 * lisp.h (Qdefun): Remove.
7414 * lread.c (read1): Tiny simplification.
7415
471fe23d
TN
74162012-05-29 Troels Nielsen <bn.troels@gmail.com>
7417
934f3f58 7418 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
7419 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
7420 Bug#9642, but explicitly check that the buffer the overlay would
7421 be moved to is live and rearrange lines to make sure that errors
7422 will not put the overlay in an inconsistent state.
7423 (Fdelete_overlay): Cosmetics.
7424
85d0efd1
EZ
74252012-05-28 Eli Zaretskii <eliz@gnu.org>
7426
7427 * w32term.c (my_bring_window_to_top): New function.
7428 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
7429 could be different from the original one.
7430 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
7431 (Bug#11513)
7432
7433 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
7434 by calling BringWindowToTop.
7435
7436 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
7437 (WM_EMACS_END): Increase by one.
7438
da92a98c
PE
74392012-05-28 Paul Eggert <eggert@cs.ucla.edu>
7440
7441 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
7442 This avoids undefined behavior that might cause the eassert
7443 to not catch an out-of-range value.
7444
74d1f848
JB
74452012-05-28 Juanma Barranquero <lekktu@gmail.com>
7446
7447 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
7448 Update dependencies.
7449
9e1a06fc
EZ
74502012-05-27 Eli Zaretskii <eliz@gnu.org>
7451
7452 * bidi.c (bidi_mirror_char): Fix last change.
7453
f3dd7312
AS
74542012-05-27 Andreas Schwab <schwab@linux-m68k.org>
7455
7456 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
7457 when referring to sectname field in printf format.
7458
81899c91
PE
74592012-05-27 Paul Eggert <eggert@cs.ucla.edu>
7460
57b81a9f
PE
7461 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
7462 Only r_alloc_inhibit_buffer_relocation needed to be added;
7463 the others were already declared.
7464
81899c91
PE
7465 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
7466 before checking whether it's out of range. Put the check inside
7467 eassert. See
7468 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
7469
33017faf 74702012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
7471
7472 * callproc.c (Fcall_process): Restore a line that was accidentally
7473 commented out in the 2011-02-13 change (bug#11547).
7474
33017faf 74752012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7476
7477 * lisp.h [REL_ALLOC]: Add prototypes for external functions
7478 defined on ralloc.c.
7479
7480 * buffer.c [REL_ALLOC]: Remove prototypes of
7481 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
7482 they are now on lisp.h.
7483
7484 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
7485
7486 * search.c (search_buffer): Use it to inhibit relocation of buffer
7487 text while re_search_2 is doing its job, because re_search_2 is
7488 passed C pointers to buffer text. (Bug#11519)
7489
23415acf
EZ
7490 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
7491 Update value to 24.
7492
44e27368
EZ
7493 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
7494 state after an additional call to move_it_in_display_line_to, keep
7495 the values of it->max_ascent and it->max_descent found for the
7496 entire line.
7497 (pos_visible_p): Revert the comparison against bottom_y to what it
7498 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
7499 (Bug#11464)
7500
c1892f11
PE
75012012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7502
7503 Fix coding-related core dumps with gcc -ftrapv.
7504 The code was computing A - B, where A and B are pointers, and B is
7505 random garbage. This can lead to core dumps on platforms that
7506 have special pointer registers, and it also leads to core dumps on
7507 x86-64 when compiled with gcc -ftrapv. The fix is to compute
7508 A - B only when B is initialized properly.
7509 * coding.c (coding_set_source, coding_set_destination): Return void.
7510 (coding_change_source, coding_change_destinations): New functions,
7511 with the old behaviors of coding_set_source and coding_set_destination.
7512 All callers that need an offset changed to use these new functions.
7513
eb7afdad
GM
75142012-05-26 Glenn Morris <rgm@gnu.org>
7515
7516 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
7517
f12fdf02
EZ
75182012-05-26 Eli Zaretskii <eliz@gnu.org>
7519
53a63be6 7520 Extend mouse support on W32 text-mode console.
61b108cc
SM
7521 * xdisp.c (draw_row_with_mouse_face):
7522 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 7523
eb3f6f01 7524 * w32console.c: Include window.h.
61b108cc
SM
7525 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
7526 New functions.
eb3f6f01
EZ
7527 (initialize_w32_display): Initialize mouse-highlight data.
7528
53a63be6
EZ
7529 * w32inevt.c: Include termchar.h and window.h.
7530 (do_mouse_event): Support mouse-autoselect-window. When the mouse
7531 moves, call note_mouse_highlight. If help_echo changed, call
7532 gen_help_event to produce help-echo message in the echo area.
7533 Call clear_mouse_face if mouse_face_hidden is set in the mouse
7534 highlight info.
7535
4cfd81f6
PE
75362012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7537
7538 * lread.c (read1): Simplify slightly to avoid an overflow warning
7539 with GCC 4.7.0 on x86-64.
7540
4446092a
EZ
75412012-05-26 Eli Zaretskii <eliz@gnu.org>
7542
7543 * bidi.c (bidi_mirror_char): Revert last change: an int is
7544 definitely wide enough here.
7545
42b2a986 75462012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7547
42b2a986 7548 Fix integer width and related bugs (Bug#9874).
eb106a49 7549 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7550 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
7551 (string_bytes, check_sblock, allocate_string_data):
7552 (compact_small_strings, Fmake_bool_vector, make_string)
7553 (make_unibyte_string, make_multibyte_string)
7554 (make_string_from_bytes, make_specified_string)
7555 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
7556 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
7557 (mark_vectorlike):
7558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7559 (allocate_pseudovector):
7560 Use int, not EMACS_INT, where int is wide enough.
7561 (inhibit_garbage_collection, Fgarbage_collect):
7562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7563 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
7564 int might not be wide enough.
7565 (bidi_cache_search, bidi_cache_find, bidi_init_it)
7566 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
7567 (bidi_at_paragraph_end, bidi_find_paragraph_start)
7568 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7569 (bidi_level_of_next_char, bidi_move_to_visually_next):
7570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7571 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
7572 (Fkill_buffer, Fset_buffer_major_mode)
7573 (advance_to_char_boundary, Fbuffer_swap_text)
7574 (Fset_buffer_multibyte, overlays_at, overlays_in)
7575 (overlay_touches_p, struct sortvec, record_overlay_string)
7576 (overlay_strings, recenter_overlay_lists)
7577 (adjust_overlays_for_insert, adjust_overlays_for_delete)
7578 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
7579 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
7580 (Foverlay_recenter, last_overlay_modification_hooks_used)
7581 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
7582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
7583 (validate_region): Omit unnecessary test for b <= e,
7584 since that's guaranteed by the previous test.
d311d28c
PE
7585 (adjust_overlays_for_delete): Avoid pos + length overflow.
7586 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
7587 (report_overlay_modification):
7588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7589 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
7590 Omit pointer cast, which isn't needed anyway, and doesn't work
7591 after the EMACS_INT -> ptrdiff_t change.
02481186 7592 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
7593 * buffer.h: Adjust decls to match defn changes elsewhere.
7594 (struct buffer_text, struct buffer):
7595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7596 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
7597 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
7598 not int, to avoid needless 32-bit limit on 64-bit hosts.
7599 (exec_byte_code): Use tighter memory-full test, one that checks
7600 for alloca overflow. Don't compute the address of the object just
7601 before an array, as that's not portable. Use EMACS_INT, not
7602 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
7603 * callint.c (Fcall_interactively):
7604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7605 * callproc.c (call_process_kill, Fcall_process):
7606 Don't assume pid_t fits into an Emacs fixnum.
7607 (call_process_cleanup, Fcall_process, child_setup):
7608 Don't assume pid_t fits into int.
7609 (call_process_cleanup, Fcall_process, delete_temp_file)
7610 (Fcall_process_region):
7611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7612 (Fcall_process): Simplify handling of volatile integers.
7613 Use int, not EMACS_INT, where int will do.
7614 * casefiddle.c (casify_object, casify_region, operate_on_word)
7615 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
7616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7617 (casify_object): Avoid integer overflow when overallocating buffer.
7618 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 7619 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
7620 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
7621 * category.h (CATEGORYP): Don't assume arg is nonnegative.
7622 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
7623 integers are now checked earlier. All uses replaced with XINT.
7624 (ccl_driver):
7625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7626 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
7627 (ccl_driver, Fregister_code_conversion_map):
7628 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
7629 (resolve_symbol_ccl_program): Check that vector header is in range.
7630 Always copy the vector, so that we can check its contents reliably
7631 now rather than having to recheck each instruction as it's being
7632 executed. Check that vector words fit in 'int'.
7633 (ccl_get_compiled_code, Fregister_ccl_program)
7634 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
7635 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
7636 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
7637 contents are in range.
7638 (Fccl_execute_on_string): Check that status is in range.
7639 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
7640 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
7641 Accept and return EMACS_INT, not int, because callers can pass values
7642 out of 'int' range.
7643 (c_string_width, strwidth, lisp_string_width, chars_in_text)
7644 (multibyte_chars_in_text, parse_str_as_multibyte)
7645 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
7646 (str_as_unibyte, str_to_unibyte, string_count_byte8)
7647 (string_escape_byte8, Fget_byte):
7648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 7649 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
7650 avoid mishandling large integers.
7651 * character.h: Adjust decls to match defn changes elsewhere.
7652 * charset.c (load_charset_map_from_file, find_charsets_in_text)
7653 (Ffind_charset_region):
7654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7655 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
7656 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 7657 Don't assume fixnum fits in int.
d311d28c
PE
7658 (load_charset_map_from_vector, Fmap_charset_chars):
7659 Remove now-unnecessary CHECK_NATNUMs.
7660 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
7661 Don't rely on undefined behavior with signed left shift overflow.
7662 Don't assume unsigned int fits into fixnum, or that fixnum fits
7663 into unsigned int. Don't require max_code to be a valid fixnum;
7664 that's not true for gb10830 4-byte on a 32-bit host. Allow
7665 invalid_code to be a cons, for the same reason. Require code_offset
7666 to be a character. Avoid int overflow if max_char is close
7667 to INT_MAX.
7668 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
7669 this is intended anyway and avoids some undefined behavior.
7670 (load_charset_map): Pass unsigned, not int, as 2nd arg of
7671 INDEX_TO_CODE_POINT, as that's what it expects.
7672 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
7673 * charset.h (DECODE_CHAR): Return int, not unsigned;
7674 this is what was intended anyway, and it avoids undefined behavior.
7675 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
7676 integer-overflow issues.
7677 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
7678 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
7679 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
7680 * chartab.c (Fmake_char_table, Fset_char_table_range)
7681 (uniprop_get_decoder, uniprop_get_encoder):
7682 Don't assume fixnum fits in int.
7683 * cmds.c (move_point): New function, that does the gist of
7684 Fforward_char and Fbackward_char, but does so while checking
7685 for integer overflow more accurately.
c96e5d6a 7686 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
7687 (Fforward_line, Fend_of_line, internal_self_insert)
7688 (internal_self_insert):
7689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7690 Fix a FIXME, by checking for integer overflow when calculating
7691 target_clm and actual_clm.
7692 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 7693 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
7694 (ASSURE_DESTINATION, coding_alloc_by_realloc)
7695 (coding_alloc_by_making_gap, alloc_destination)
7696 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
7697 (encode_coding_utf_16, detect_coding_emacs_mule)
7698 (decode_coding_emacs_mule, encode_coding_emacs_mule)
7699 (detect_coding_iso_2022, decode_coding_iso_2022)
7700 (encode_invocation_designation, encode_designation_at_bol)
7701 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7702 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
7703 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
7704 (encode_coding_ccl, encode_coding_raw_text)
7705 (detect_coding_charset, decode_coding_charset)
7706 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
7707 (produce_composition, produce_charset, produce_annotation)
7708 (decode_coding, handle_composition_annotation)
7709 (handle_charset_annotation, consume_chars, decode_coding_gap)
7710 (decode_coding_object, encode_coding_object, detect_coding_system)
7711 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
7712 (code_convert_region, code_convert_string)
8f50130c
PE
7713 (Fdefine_coding_system_internal)
7714 (coding_set_source, coding_set_destination):
d311d28c
PE
7715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7716 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
7717 (Fdefine_coding_system_internal):
7718 Don't assume fixnums fit in int.
7719 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 7720 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
7721 (Funencodable_char_position, Fcheck_coding_systems_region)
7722 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 7723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 7724 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 7725 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 7726 Don't access memory outside of the args array.
d311d28c 7727 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
7728 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
7729 result of ENCODE_CHAR.
d311d28c
PE
7730 * coding.h: Adjust decls to match defn changes elsewhere.
7731 (struct coding_system):
7732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7733 * composite.c (get_composition_id, find_composition)
7734 (run_composition_function, update_compositions)
7735 (compose_text, composition_gstring_put_cache)
7736 (composition_gstring_p, composition_gstring_width)
7737 (fill_gstring_header, fill_gstring_body, autocmp_chars)
7738 (composition_compute_stop_pos, composition_reseat_it)
7739 (composition_update_it, struct position_record)
7740 (find_automatic_composition, composition_adjust_point)
7741 (Fcomposition_get_gstring, Ffind_composition_internal):
7742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7743 (update_compositions):
7744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7745 * composite.h: Adjust decls to match defn changes elsewhere.
7746 (struct composition):
7747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7748 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7749 Do not attempt to compute the address of the object just before a
7750 buffer; this is not portable.
7751 (Faref, Faset):
7752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7753 (Faset): Use int, not EMACS_INT, where int is wide enough.
7754 (Fstring_to_number): Don't assume fixnums fit in int.
7755 (Frem): Don't assume arg is nonnegative.
7756 * dbusbind.c (xd_append_arg): Check for integers out of range.
7757 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7758 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7759 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7760 (xd_get_connection_references): Return ptrdiff_t, not int.
7761 All uses changed.
7762 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7763 (xd_read_message_1):
7764 Use int, not unsigned, where the dbus API uses int.
7765 (Fdbus_message_internal): Don't overflow mtype.
7766 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7767 * dired.c (directory_files_internal, file_name_completion, scmp)
7768 (file_name_completion_stat):
7769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7770 (file_name_completion): Don't overflow matchcount.
7771 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7772 * dispextern.h: Adjust decls to match defn changes elsewhere.
7773 (struct text_pos, struct glyph, struct bidi_saved_info)
7774 (struct bidi_string_data, struct bidi_it, struct composition_it)
7775 (struct it):
7776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7777 (struct display_pos, struct composition_it, struct it):
7778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7779 * dispnew.c (increment_matrix_positions)
7780 (increment_row_positions, mode_line_string)
7781 (marginal_area_string):
7782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7783 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7785 (duration_to_sec_usec): New function, to check for overflow better.
7786 (Fsleep_for, sit_for): Use it.
7787 * doc.c (get_doc_string, store_function_docstring):
7788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7789 (get_doc_string, Fsnarf_documentation):
7790 Use int, not EMACS_INT, where int is wide enough.
7791 (get_doc_string):
7792 Use SAFE_ALLOCA, not alloca.
7793 Check for overflow when converting EMACS_INT to off_t.
7794 * doprnt.c (doprnt):
7795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7796 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7797 Don't assume uid_t fits into fixnum.
7798 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7799 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7800 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7801 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7802 (general_insert_function)
7803 (Finsert_char, make_buffer_string, make_buffer_string_both)
7804 (update_buffer_properties, Fbuffer_substring)
7805 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7806 (Fsubst_char_in_region, check_translation)
7807 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7808 (transpose_markers, Ftranspose_regions):
7809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7810 (clip_to_bounds): Move to lisp.h as an inline function).
7811 (Fconstrain_to_field): Don't assume integers are nonnegative.
7812 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7813 (Fsubst_char_in_region, Fsave_restriction):
7814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7815 (Femacs_pid): Don't assume pid_t fits into fixnum.
7816 (lo_time): Use int, not EMACS_INT, when int suffices.
7817 (lisp_time_argument): Check for usec out of range.
7818 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7819 (Fuser_login_name, Fuser_full_name): Signal an error
7820 if a uid argument is out of range, rather than relying on
7821 undefined behavior.
c8d5c857
PE
7822 (Fformat_time_string): Remove now-unnecessary check.
7823 lisp_time_argument checks for out-of-range usec now.
243e0530 7824 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7825 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7826 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7827 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7828 (init_cmdargs, Fdump_emacs):
7829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7830 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7831 the bottom (typically) 32 bits of the fixnum.
7832 * eval.c (specpdl_size, call_debugger):
7833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7834 (when_entered_debugger, Fbacktrace_debug):
7835 Don't assume fixnum can fit in int.
7836 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7837 the object just before a buffer; this is not portable.
7838 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7839 (grow_specpdl, unbind_to):
7840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7841 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7842 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7843 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7844 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7845 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7847 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7848 (a_write, e_write):
7849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7850 (Fcopy_file, non_regular_nbytes, read_non_regular)
7851 (Finsert_file_contents):
7852 Use int, not EMACS_INT, where int is wide enough.
7853 (READ_BUF_SIZE): Verify that it fits in int.
7854 (Finsert_file_contents): Check that counts are in proper range,
7855 rather than assuming fixnums fit into ptrdiff_t etc.
7856 Don't assume fixnums fit into int.
125b3835 7857 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7858 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7859 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7860 (string_char_to_byte, string_byte_to_char)
7861 (string_make_multibyte, string_to_multibyte)
7862 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7863 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7864 (substring_both, Fdelete, internal_equal, Ffillarray)
7865 (Fclear_string, mapcar1)
7866 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7867 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7868 (larger_vector, make_hash_table, maybe_resize_hash_table)
7869 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7870 (Fmaphash, secure_hash):
7871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7872 (concat): Check for string index and length overflow.
7873 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7874 (Frequire):
7875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7876 (larger_vector): New API (vec, incr_min, size_max) replaces old
7877 one (vec, new_size, init). This catches size overflow.
7878 INIT was removed because it was always Qnil.
7879 All callers changed.
7880 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7881 the upper bound on a hash table index size.
7882 (make_hash_table, maybe_resize_hash_table): Use it.
7883 (secure_hash): Computer start_byte and end_byte only after
7884 they're known to be in ptrdiff_t range.
7885 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7886 (Ffont_get_glyphs, Ffont_at):
7887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7888 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7889 (Flist_fonts, Fopen_font):
7890 Don't assume fixnum can fit in int.
7891 (check_gstring): Don't assume index can fit in int.
7892 (font_match_p): Check that fixnum is a character, not a nonnegative
7893 fixnum, since the later code needs to stuff it into an int.
7894 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7895 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7896 conversion overflow issues.
7897 (Fopen_font): Check for integer out of range.
7898 (Ffont_get_glyphs): Don't assume index can fit in int.
7899 * font.h: Adjust decls to match defn changes elsewhere.
7900 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7901 integer overflow.
7902 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7903 printmax_t, where ptrdiff_t is wide enough.
7904 (Finternal_char_font):
7905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7906 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7907 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7908 (Fset_frame_position, x_set_frame_parameters)
7909 (x_set_line_spacing, x_set_border_width)
7910 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7911 Check that fixnums are in proper range for system types.
7912 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7914 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7915 Use SAFE_ALLOCA_LISP, not alloca.
7916 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7917 intptr_t is wide enough.
7918 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7919 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7920 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7921 Check for fixnum out of range.
7922 * ftfont.c (ftfont_list): Don't assume index fits in int.
7923 Check that fixnums are in proper range for system types.
7924 (ftfont_shape_by_flt):
7925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7926 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7928 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7929 Check that fixnums are in proper range for system types.
7930 * gnutls.h: Adjust decls to match defn changes elsewhere.
7931 * gtkutil.c (xg_dialog_run):
7932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7933 (update_frame_tool_bar):
7934 Check that fixnums are in proper range for system types.
7935 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7936 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7937 * indent.c (last_known_column, last_known_column_point):
7938 (current_column_bol_cache):
7939 (skip_invisible, current_column, check_display_width):
7940 (check_display_width, scan_for_column, current_column_1)
7941 (Findent_to, Fcurrent_indentation, position_indentation)
7942 (indented_beyond_p, Fmove_to_column, compute_motion):
7943 (Fcompute_motion, Fvertical_motion):
7944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7945 (last_known_column_modified): Use EMACS_INT, not int.
7946 (check_display_width):
7947 (Fcompute_motion):
7948 Check that fixnums and floats are in proper range for system types.
7949 (compute_motion): Don't assume index or fixnum fits in int.
7950 (compute_motion, Fcompute_motion):
7951 Use int, not EMACS_INT, when it is wide enough.
7952 (vmotion): Omit local var start_hpos that is always 0; that way
7953 we don't need to worry about overflow in expressions involving it.
7954 * indent.h: Adjust decls to match defn changes elsewhere.
7955 (struct position):
7956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7957 Use int, not EMACS_INT, where int is wide enough.
7958 Remove unused members ovstring_chars_done and tab_offset;
7959 all uses removed.
7960 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7961 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7962 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7963 (make_gap, copy_text, insert, insert_and_inherit)
7964 (insert_before_markers, insert_before_markers_and_inherit)
7965 (insert_1, count_combining_before, count_combining_after)
7966 (insert_1_both, insert_from_string)
7967 (insert_from_string_before_markers, insert_from_string_1)
7968 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7969 (adjust_after_replace, adjust_after_insert, replace_range)
7970 (replace_range_2, del_range, del_range_1, del_range_byte)
7971 (del_range_both, del_range_2, modify_region)
7972 (prepare_to_modify_buffer, signal_before_change)
7973 (signal_after_change, Fcombine_after_change_execute):
7974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7975 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7976 (balance_an_interval, split_interval_right, split_interval_left)
7977 (find_interval, next_interval, update_interval)
7978 (adjust_intervals_for_insertion, delete_node, delete_interval)
7979 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7980 (static_offset_intervals, offset_intervals)
7981 (merge_interval_right, merge_interval_left, make_new_interval)
7982 (graft_intervals_into_buffer, temp_set_point_both)
7983 (temp_set_point, set_point, adjust_for_invis_intang)
7984 (set_point_both, move_if_not_intangible, get_property_and_range)
7985 (get_local_map, copy_intervals, copy_intervals_to_string)
7986 (compare_string_intervals, set_intervals_multibyte_1):
7987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7988 * intervals.h: Adjust decls to match defn changes elsewhere.
7989 (struct interval):
7990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7991 * keyboard.c (this_command_key_count, this_single_command_key_start)
7992 (before_command_key_count, before_command_echo_length, echo_now)
7993 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7994 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7995 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7996 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7998 (last_non_minibuf_size, last_point_position, echo_truncate)
7999 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
8000 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
8001 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
8002 (stuff_buffered_input):
8003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8004 (last_auto_save, command_loop_1, read_char):
8005 Use EMACS_INT, not int, to avoid integer overflow.
8006 (record_char): Avoid overflow in total_keys computation.
8007 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
8008 * keyboard.h: Adjust decls to match defn changes elsewhere.
8009 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
8010 (Fkey_description, Fdescribe_vector, Flookup_key):
8011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8012 (click_position): New function, to check that positions are in range.
8013 (Fcurrent_active_maps):
8014 (describe_command):
8015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8016 (Faccessible_keymaps, Fkey_description):
8017 (preferred_sequence_p):
8018 Don't assume fixnum can fit into int.
8019 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
8020 Check for integer overflow in size calculations.
8021 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
8022 avoid mishandling large integers.
8023 * lisp.h: Adjust decls to match defn changes elsewhere.
8024 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
8025 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
8026 (struct Lisp_Marker):
8027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8028 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
8029 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
8030 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
8031 All callers changed.
8032 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
8033 Assume the arg has valid form, since it always does.
8034 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
8035 unsigned integer system type.
8036 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
8037 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
8038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8039 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
8040 (duration_to_sec_usec): New decl.
8041 * lread.c (read_from_string_index, read_from_string_index_byte)
8042 (read_from_string_limit, readchar, unreadchar, openp)
8043 (read_internal_start, read1, oblookup):
8044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8045 (Fload, readevalloop, Feval_buffer, Feval_region):
8046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8047 (openp): Check for out-of-range argument to 'access'.
8048 (read1): Use int, not EMACS_INT, where int is wide enough.
8049 Don't assume fixnum fits into int.
6efdadfd 8050 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
8051 (read_filtered_event): Use duration_to_sec_usec
8052 to do proper overflow checking on durations.
d311d28c
PE
8053 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
8054 in size calculation.
8055 (Fexecute_kbd_macro):
8056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8057 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
8058 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
8059 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
8060 (set_marker_both, set_marker_restricted_both, marker_position)
8061 (marker_byte_position, Fbuffer_has_markers_at):
8062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8063 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 8064 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
8065 It now merely ensures that the menu is large enough, without
8066 necessarily growing it, as this avoids some integer overflow issues.
8067 All callers changed.
8068 (keymap_panes, parse_single_submenu, Fx_popup_menu):
8069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8070 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
8071 Use SAFE_ALLOCA_LISP, not alloca.
8072 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
8073 to EMACS_INT. Check that fixnums are in proper range for system types.
8074 * minibuf.c (minibuf_prompt_width, string_to_object)
8075 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
8076 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
8077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8078 (get_minibuffer, read_minibuf_unwind):
8079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8080 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
8081 this simplifies overflow checking. All callers changed.
8082 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
8083 (Ftest_completion):
8084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8085 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
8086 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
8087 Check that fixnums are in proper range for system types.
8088 (Fx_create_frame, Fx_show_tip):
8089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8090 * nsfont.m (ns_findfonts, nsfont_list_family):
8091 Don't assume fixnum fits in long.
8092 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
8093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8094 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
8095 wide enough.
17fdb222 8096 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
8097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8098 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
8099 (PRINTDECLARE, PRINTPREPARE):
8100 (strout, print_string):
8101 (print, print_preprocess, print_check_string_charset_prop)
8102 (print_object):
8103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8104 (PRINTDECLARE):
8105 (temp_output_buffer_setup, Fprin1_to_string, print_object):
8106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8107 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 8108 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 8109 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
8110 (print_error_message): Use SAFE_ALLOCA, not alloca.
8111 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
8112 (print_depth, new_backquote_output, print_number_index):
8113 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
8114 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
8115 (Fset_process_window_size, Fformat_network_address)
8116 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 8117 (sigchld_handler):
d311d28c 8118 Check that fixnums are in proper range for system types.
d44287d4 8119 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
8120 Check for process-ids out of pid_t range rather than relying on
8121 undefined behavior.
e4d81efc 8122 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
8123 (Fformat_network_address, read_process_output, send_process)
8124 (Fprocess_send_region, status_notify):
8125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8126 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
8127 (wait_reading_process_output, read_process_output, exec_sentinel):
8128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8129 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
8130 (Faccept_process_output): Use duration_to_sec_usec to do proper
8131 overflow checking on durations.
dde14581
PE
8132 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
8133 Don't assume pid_t fits in int.
02481186
PE
8134 * process.h (struct Lisp_Process): Members tick and update_tick
8135 are now of type EMACS_INT, not int.
b62b53e8
PE
8136 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
8137 configured --with-wide-int.
d311d28c
PE
8138 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
8139 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
8140 * search.c (looking_at_1, string_match_1):
8141 (fast_string_match, fast_c_string_match_ignore_case)
8142 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
8143 (scan_newline, find_before_next_newline, search_command)
8144 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
8145 (set_search_regs, wordify):
8146 (Freplace_match):
8147 (Fmatch_data):
8148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8149 (string_match_1, search_buffer, set_search_regs):
8150 (Fmatch_data):
8151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8152 (wordify): Check for overflow in size calculation.
8153 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
8154 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
8155 Check that fixnums are in proper range for system types.
8156 * sound.c (struct sound_device)
8157 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
8158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8159 (Fplay_sound_internal):
8160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 8161 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
8162 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
8163 (Fparse_partial_sexp):
8164 Don't assume fixnums can fit in int.
8165 (struct lisp_parse_state, find_start_pos, find_start_value)
8166 (find_start_value_byte, find_start_begv)
8167 (update_syntax_table, char_quoted, dec_bytepos)
8168 (find_defun_start, prev_char_comend_first, back_comment):
8169 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
8170 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
8171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8172 (Finternal_describe_syntax_value): Check that match_lisp is a
8173 character, not an integer, since the code stuffs it into int.
8174 (scan_words, scan_sexps_forward):
8175 Check that fixnums are in proper range for system types.
8176 (Fforward_word):
8177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8178 (scan_sexps_forward):
8179 Use CHARACTERP, not INTEGERP, since the value must fit into int.
8180 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
8181 * syntax.h: Adjust decls to match defn changes elsewhere.
8182 (struct gl_state_s):
8183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
8184 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
8185 MOST_POSITIVE_FIXNUM.
d311d28c
PE
8186 * sysdep.c (wait_for_termination_1, wait_for_termination)
8187 (interruptible_wait_for_termination, mkdir):
8188 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
8189 (emacs_read, emacs_write):
8190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
8191 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
8192 and double all fit in int.
d311d28c
PE
8193 * term.c (set_tty_color_mode):
8194 Check that fixnums are in proper range for system types.
8195 * termhooks.h (struct input_event):
8196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8197 * textprop.c (validate_interval_range, interval_of)
8198 (Fadd_text_properties, set_text_properties_1)
8199 (Fremove_text_properties, Fremove_list_of_text_properties)
8200 (Ftext_property_any, Ftext_property_not_all)
8201 (copy_text_properties, text_property_list, extend_property_ranges)
8202 (verify_interval_modification):
8203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8204 (Fnext_single_char_property_change)
8205 (Fprevious_single_char_property_change):
8206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
8207 (copy_text_properties):
8208 Check for integer overflow in index calculation.
d311d28c
PE
8209 * undo.c (last_boundary_position, record_point, record_insert)
8210 (record_delete, record_marker_adjustment, record_change)
8211 (record_property_change):
8212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8213 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
8214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8215 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8216 (Fx_hide_tip, Fx_file_dialog):
8217 * w32menu.c (set_frame_menubar):
8218 Use ptrdiff_t, not int, for consistency with rest of code.
8219 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
8220 (select_window, Fdelete_other_windows_internal)
8221 (window_scroll_pixel_based, window_scroll_line_based)
8222 (Frecenter, Fset_window_configuration):
8223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8224 (Fset_window_hscroll, run_window_configuration_change_hook)
8225 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 8226 (Fscroll_other_window, Frecenter):
d311d28c
PE
8227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8228 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
8229 Don't assume fixnum fits in int.
8230 (Fset_window_scroll_bars):
8231 Check that fixnums are in proper range for system types.
8232 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
8233 (string_pos, c_string_pos, number_of_chars, init_iterator)
8234 (in_ellipses_for_invisible_text_p, init_from_display_pos)
8235 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
8236 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
8237 (face_before_or_after_it_pos, handle_invisible_prop)
8238 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
8239 (display_prop_intangible_p, string_buffer_position_lim)
8240 (string_buffer_position, handle_composition_prop, load_overlay_strings)
8241 (get_overlay_strings_1, get_overlay_strings)
8242 (iterate_out_of_display_property, forward_to_next_line_start)
8243 (back_to_previous_visible_line_start, reseat, reseat_to_string)
8244 (get_next_display_element, set_iterator_to_next)
8245 (get_visually_first_element, compute_stop_pos_backwards)
8246 (handle_stop_backwards, next_element_from_buffer)
8247 (move_it_in_display_line_to, move_it_in_display_line)
8248 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8249 (add_to_log, message_dolog, message_log_check_duplicate)
8250 (message2, message2_nolog, message3, message3_nolog
8251 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
8252 (current_message_1, truncate_echo_area, truncate_message_1)
8253 (set_message, set_message_1, store_mode_line_noprop)
8254 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
8255 (text_outside_line_unchanged_p, check_point_in_composition)
8256 (reconsider_clip_changes)
8257 (redisplay_internal, set_cursor_from_row, try_scrolling)
8258 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
8259 (redisplay_window, find_last_unchanged_at_beg_row)
8260 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
8261 (trailing_whitespace_p, find_row_edges, display_line)
8262 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
8263 (display_mode_element, store_mode_line_string)
8264 (pint2str, pint2hrstr, decode_mode_spec)
8265 (display_count_lines, display_string, draw_glyphs)
8266 (x_produce_glyphs, x_insert_glyphs)
8267 (rows_from_pos_range, mouse_face_from_buffer_pos)
8268 (fast_find_string_pos, mouse_face_from_string_pos)
8269 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8271 (safe_call, init_from_display_pos, handle_fontified_prop)
8272 (handle_single_display_spec, load_overlay_strings)
8273 (with_echo_area_buffer, setup_echo_area_for_printing)
8274 (display_echo_area, echo_area_display)
8275 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
8276 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
8277 (redisplay_window, dump_glyph_row, display_mode_line)
8278 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 8279 (handle_display_spec, display_prop_string_p):
d311d28c
PE
8280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8281 (handle_single_display_spec, build_desired_tool_bar_string)
8282 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
8283 (get_specified_cursor_type):
8284 Check that fixnums are in proper range for system types.
8285 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
8286 (Flookup_image_map):
8287 Don't assume fixnums fit in int.
8288 (compare_overlay_entries):
8289 Avoid mishandling comparisons due to subtraction overflow.
8290 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
8291 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
8292 (handle_tool_bar_click):
8293 Use int, not unsigned, since we prefer signed and the signedness
8294 doesn't matter here.
8295 (get_next_display_element, next_element_from_display_vector):
8296 Use int, not EMACS_INT, when int is wide enough.
8297 (start_hourglass): Use duration_to_sec_usec to do proper
8298 overflow checking on durations.
8299 * xfaces.c (Fbitmap_spec_p):
8300 Check that fixnums are in proper range for system types.
8301 (compare_fonts_by_sort_order):
8302 Avoid mishandling comparisons due to subtraction overflow.
8303 (Fx_family_fonts, realize_basic_faces):
8304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8305 (Fx_family_fonts):
8306 Don't assume fixnum fits in int.
8307 Use SAFE_ALLOCA_LISP, not alloca.
8308 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
8309 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
8310 (face_at_buffer_position, face_for_overlay_string)
8311 (face_at_string_position):
8312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8313 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
8314 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
8315 (Fx_show_tip):
8316 Check that fixnums are in proper range for system types.
8317 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8318 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
8319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8320 (Fx_change_window_property): Don't assume fixnums fit in int.
8321 * xfont.c (xfont_chars_supported):
8322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8323 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
8324 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
8325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8326 * xml.c (parse_region):
8327 * xrdb.c (magic_file_p):
8328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8329 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
8330 (x_get_local_selection, x_reply_selection_request)
8331 (x_handle_selection_request, wait_for_property_change):
8332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8333 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
8334 short is wide enough.
8335 (x_send_client_event): Don't assume fixnum fits in int.
8336 * xterm.c (x_x_to_emacs_modifiers):
8337 Don't assume EMACS_INT overflows nicely into int.
8338 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
8339 may come from Lisp.
8340 (handle_one_xevent): NATNUMP can eval its arg twice.
8341 (x_connection_closed):
8342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8343 * xterm.h: Adjust decls to match defn changes elsewhere.
8344 (struct scroll_bar): Use struct vectorlike_header
8345 rather than rolling our own approximation.
8346 (SCROLL_BAR_VEC_SIZE): Remove; not used.
8347
c6574eb5
GM
83482012-05-25 Glenn Morris <rgm@gnu.org>
8349
8350 * lisp.mk (lisp): Update for more files being compiled now.
8351
e8d32c7e
SM
83522012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
8353
48def666
SM
8354 * lread.c: Remove `read_pure' which makes no difference.
8355 (read_pure): Remove var.
8356 (unreadpure): Remove function.
8357 (readevalloop): Don't call read_list with -1 flag.
8358 (read1, read_vector): Don't test read_pure any more.
8359 (read_list): Simplify.
8360
e8d32c7e
SM
8361 * fileio.c, character.h: Minor style tweaks.
8362
4b2addb7
DA
83632012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
8364
8365 * window.h (clip_changed): Remove useless declaration.
8366
584461b2
JB
83672012-05-22 Juanma Barranquero <lekktu@gmail.com>
8368
8369 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
8370 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
8371
34374650
PE
83722012-05-22 Paul Eggert <eggert@cs.ucla.edu>
8373
8374 Remove src/m/*.
8375 This directory predates autoconf and is no longer needed nowadays.
8376 Move its few remaining bits of functionality to where they're needed.
8377 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
8378 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
8379 * m/template.h: Remove.
8380 * Makefile.in (M_FILE): Remove. All uses removed.
8381 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
8382 * lisp.h (USE_LSB_TAG):
8383 * mem-limits.h (EXCEEDS_LISP_PTR):
8384 Use VAL_MAX, not VALBITS, in #if.
8385 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
8386 (EMACS_UINT): Define unconditionally now.
8387 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
8388 (BITS_PER_EMACS_INT): New constants, replacing
8389 what used to be in config.h, but not useful in #if.
8390 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
8391 define them any more.
8392 (VAL_MAX): New macro.
8393 (VALMASK): Use it.
8394 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
8395 BITS_PER_EMACS_INT, in #if.
8396 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
8397 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
8398 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
8399 * s/ms-w32.h (DATA_START):
8400 Move here from removed file m/intel386.h.
8401 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
8402 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
8403
261cb4bb
PE
84042012-05-21 Paul Eggert <eggert@cs.ucla.edu>
8405
8406 Assume C89 or later.
8407 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
8408 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
8409 (xrealloc):
8410 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
8411 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
8412 * textprop.c, tparam.c (NULL): Remove.
8413 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
8414 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
8415 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
8416 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
8417 * xterm.c (input_signal_count): Assume volatile works.
8418
ff23cd9f
KB
84192012-05-21 Ken Brown <kbrown@cornell.edu>
8420
8421 * xgselect.c (xg_select): Fix first argument in call to 'select'
8422 (bug#11508).
8423
1b170bc6
KB
84242012-05-20 Ken Brown <kbrown@cornell.edu>
8425
8426 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 8427 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 8428
b2f4d39f
KB
84292012-05-19 Ken Brown <kbrown@cornell.edu>
8430
8431 * xfns.c (x_in_use): Remove `static' qualifier.
8432 * xterm.h (x_in_use): Declare.
8433 * xgselect.c: Include xterm.h.
8434 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
8435 and `display_arg' (bug#9754).
8436
003fdae2
PE
84372012-05-19 Paul Eggert <eggert@cs.ucla.edu>
8438
9232a6d9
PE
8439 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
8440
003fdae2
PE
8441 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
8442 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8443
784b56e2
EZ
84442012-05-18 Eli Zaretskii <eliz@gnu.org>
8445
8446 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
8447
8448 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 8449 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
8450
8451 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
8452 reference to image_cache->refcount.
8453 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
8454
a0a79cde
JL
84552012-05-17 Juri Linkov <juri@jurta.org>
8456
8457 * search.c (Fword_search_regexp, Fword_search_backward)
8458 (Fword_search_forward, Fword_search_backward_lax)
8459 (Fword_search_forward_lax): Move functions to isearch.el
8460 (bug#10145, bug#11381).
8461
b0572523
PE
84622012-05-16 Paul Eggert <eggert@cs.ucla.edu>
8463
8464 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
8465
9660f5fc
SM
84662012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
8467
8468 * lread.c (init_obarray): Declare Qt and Qnil as special.
8469
4374de83
GM
84702012-05-14 Glenn Morris <rgm@gnu.org>
8471
8472 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 8473 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 8474
dc44c39a
PE
84752012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8476
078c97cb
PE
8477 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
8478
dc44c39a
PE
8479 * unexaix.c: Port to more-recent AIX compilers.
8480 (report_error, report_error_1, make_hdr, copy_sym)
8481 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8482 Make arguments const char *, not char *, to avoid violations of C
8483 standard and to fix some AIX warnings reported by Gilles Pion.
8484
e18afed7 84852012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
8486
8487 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
8488 already have overlays loaded.
8489 (handle_single_display_spec): Before returning without displaying
8490 fringe bitmap, synchronize the bidi iterator with the main display
8491 iterator, by calling iterate_out_of_display_property.
8492 (iterate_out_of_display_property): Detect buffer iteration by
8493 testing that it->string is a Lisp string.
8494 (get_next_display_element): When the current object is exhausted,
8495 and there's something on it->stack, call set_iterator_to_next to
8496 proceed with what's on the stack, instead of returning zero.
8497 (set_iterator_to_next): If called at the end of a Lisp string,
8498 proceed to consider_string_end without incrementing string
8499 position. Don't increment display vector index past the end of
8500 the display vector. (Bug#11417)
c8fb9dc6
EZ
8501 (pos_visible_p): Don't report a position visible when move_it_to
8502 stopped at the last line of window, which happens to be scanned
8503 backwards by the bidi iteration. (Bug#11464)
ac268e67 8504
e18afed7 85052012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
8506
8507 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
8508 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
8509 are on a TTY, and thus unable to display on the fringes.
8510 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
8511 so we need to signal to the caller that this is a "replacing"
8512 display spec. This fixes display when the spec is invalid or we
8513 are on a TTY.
8514
e18afed7 85152012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
8516
8517 * unexaix.c (make_hdr): Fix typo in prototype.
8518 This bug broke the build on AIX. Problem reported by Gilles Pion.
8519
9d0a235a
MA
85202012-05-14 Michael Albinus <michael.albinus@gmx.de>
8521
8522 * keyboard.c (kbd_buffer_get_event): Read special events also in
8523 batch mode. (Bug#11415)
8524
9e6b06ed
GM
85252012-05-12 Glenn Morris <rgm@gnu.org>
8526
8527 * ns.mk: Update for ns_appbindir no longer having trailing "/".
8528
c1a1d7a3
EZ
85292012-05-12 Eli Zaretskii <eliz@gnu.org>
8530
8531 * lisp.mk (lisp): Add newcomment.elc.
8532
3fe7cdc8
GM
85332012-05-12 Glenn Morris <rgm@gnu.org>
8534
8535 * Makefile.in (MKDIR_P): New, set by configure.
8536 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
8537
53f7d2c0
PE
85382012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8539
8540 Remove unused function hourglass_started.
8541 * dispextern.h (hourglass_started):
8542 * w32fns.c (hourglass_started):
8543 * xdisp.c (hourglass_started): Remove.
8544
75aafb17
JB
85452012-05-10 Juanma Barranquero <lekktu@gmail.com>
8546
8547 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
8548 Update dependencies.
8549
12959e8e
PE
85502012-05-10 Paul Eggert <eggert@cs.ucla.edu>
8551
97107e2e
PE
8552 * xgselect.c (xg_select): Put maxfds+1 into a var.
8553 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
8554
12959e8e
PE
8555 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
8556
836d29b3
DA
85572012-05-10 Dave Abrahams <dave@boostpro.com>
8558
8559 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
8560 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
8561
5cb67954
MA
85622012-05-09 Michael Albinus <michael.albinus@gmx.de>
8563
8564 * dbusbind.c (xd_registered_buses): New internal Lisp object.
8565 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
8566 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
8567 Initialize xd_registered_buses.
8568
3478ec45
PE
85692012-05-09 Paul Eggert <eggert@cs.ucla.edu>
8570
b263a6b0
PE
8571 Untag more efficiently if USE_LSB_TAG.
8572 This is based on a proposal by YAMAMOTO Mitsuharu in
8573 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
8574 For an admittedly artificial (nth 8000 longlist) benchmark on
8575 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8576 Emacs's overall text size by 1%.
8577 * lisp.h (XUNTAG): New macro.
8578 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
8579 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
8580 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
8581 * eval.c (Fautoload):
8582 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
8583 * frame.h (XFRAME): Use XUNTAG.
8584
3478ec45
PE
8585 Port recent dbusbind.c changes to 32-bit --with-wide-int.
8586 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
8587 Remove unportable assumptions about print widths of types like
8588 dbus_uint32_t.
8589 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8590 intptr_t when converting between pointer and integer, to avoid GCC
8591 warnings about wrong width.
8592
666b903b 85932012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
8594
8595 * w32proc.c (new_child): Force Windows to reserve only 64KB of
8596 stack for each reader_thread, instead of defaulting to 8MB
8597 determined by the linker. This avoids failures in creating
8598 subprocesses on Windows 7, see the discussion in this thread:
8599 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8600
b120cc17
JC
86012012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
8602
8603 Fix up display of the *Minibuf-0* buffer in the mini window.
8604 * keyboard.c (read_char): Don't clear the echo area if there's no
8605 message to clear.
8606 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 8607 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 8608
9a4b36f8
MA
86092012-05-07 Michael Albinus <michael.albinus@gmx.de>
8610
8611 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
8612 batch mode.
8613
e5f9458f
CY
86142012-05-06 Chong Yidong <cyd@gnu.org>
8615
8616 * lisp.mk (lisp): Update.
8617
eceeb5fc 86182012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
8619
8620 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
8621
71873e2b
SM
86222012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
8623
8624 * data.c (PUT_ERROR): New macro.
8625 (syms_of_data): Use it. Add new error type `user-error'.
8626 * undo.c (user_error): New function.
8627 (Fprimitive_undo): Use it.
8628 * print.c (print_error_message): Adjust print style for `user-error'.
8629 * keyboard.c (user_error): New function.
8630 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
8631
ab0fa4e4
PE
86322012-05-03 Paul Eggert <eggert@cs.ucla.edu>
8633
8634 Do not limit current-time-string to years 1000..9999.
8635 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
8636 (Fcurrent_time_string): Support any year that is supported by the
8637 underlying localtime representation. Don't use asctime, as it
8638 has undefined behavior for years outside the range -999..9999.
8639
7ed806a7
PE
86402012-05-02 Paul Eggert <eggert@cs.ucla.edu>
8641
8642 Fix race conditions involving setenv, gmtime, localtime, asctime.
8643 Without this fix, interrupts could mess up code that uses these
8644 nonreentrant functions, since setting TZ invalidates existing
8645 tm_zone or tzname values, and since most of these functions return
8646 pointers to static storage.
8647 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
8648 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
8649 Grow the critical sections to include not just invoking
8650 localtime/gmtime, but also accessing these functions' results
8651 including their tm_zone values if any, and any related TZ setting.
8652 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
8653 so that the struct tm is saved in the critical section.
8654 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
8655 motivated by the fact that memory allocation needs to be outside
8656 the critical section.
8657
0c16dfed
DA
86582012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
8659
8660 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
8661 with RESET_INTERVAL.
8662
8663 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8664 Remove duplicated buffer name initialization.
8665
3f83ace8
JM
86662012-05-02 Jim Meyering <jim@meyering.net>
8667
8668 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
8669
c7b8541e
JM
8670 * xfns.c (x_window): Use xstrdup (Bug#11375).
8671
90207a15 86722012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
8673
8674 * xdisp.c (pos_visible_p): If already at a newline from the
8675 display string before the 'while' loop, don't walk back the glyphs
8676 from it3.glyph_row. Solves assertion violation when the display
8677 string begins with a newline (egg.el). (Bug#11367)
8678
b593d6a9
AH
86792012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
8680
8681 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
8682 Move to simple.el.
8683
4737362e
GM
86842012-05-01 Glenn Morris <rgm@gnu.org>
8685
99cf43f9
GM
8686 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
8687 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
8688 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
8689 All were removed before 23.1.
8690
9311dcff
GM
8691 * dispnew.c: Remove HAVE_LIBNCURSES test;
8692 it is always true on relevant platforms.
8693
4d5c6349
GM
8694 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
8695 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8696
4737362e
GM
8697 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
8698
74dd3a6b
AS
86992012-04-30 Andreas Schwab <schwab@linux-m68k.org>
8700
8701 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8702 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
8703 Remove.
8704
13c379ee
PE
87052012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8706
8707 Do not avoid creating empty evaporating overlays (Bug#9642).
8708 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
8709 That is, do not delete an evaporating overlay if it becomes
8710 empty after its bounds are adjusted to fit within its buffer.
8711 This fix caused other problems, and I'm reverting it until we get
8712 to the bottom of them.
8713
a8e7d6d7 87142012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
8715
8716 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
8717
a8e7d6d7 87182012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
8719
8720 * xdisp.c (pos_visible_p): If the window start position is beyond
8721 ZV, start the display from buffer beginning. Prevents assertion
8722 violation in init_iterator when the minibuffer window is scrolled
8723 via the scroll bar.
8724
8725 * window.c (window_scroll_pixel_based): Likewise.
8726
a8e7d6d7 87272012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
8728
8729 * keymap.c (where_is_internal): Doc fix (Bug#10872).
8730
a8e7d6d7 87312012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
8732
8733 * fileio.c (Fcopy_file, Fset_file_selinux_context):
8734 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
8735
a8e7d6d7 87362012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 8737
b593d6a9
AH
8738 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
8739 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 8740
1c6900d9
EZ
87412012-04-26 Eli Zaretskii <eliz@gnu.org>
8742
4c3fa1d9
EZ
8743 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
8744 display element, check also the underlying string or buffer
8745 character. (Bug#11341)
8746
1c6900d9
EZ
8747 * w32menu.c: Include w32heap.h.
8748 (add_menu_item): If the call to AppendMenuW (via
8749 unicode_append_menu) fails, disable Unicode menus only if we are
8750 running on Windows 9X/Me.
8751
42bf8205
AS
87522012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8753
8754 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8755 (xgetint): Add missing shift for LSB tags.
8756
b1bac16e
MR
87572012-04-24 Martin Rudalics <rudalics@gmx.at>
8758
8759 * keyboard.c (read_char): Don't wipe echo area for select window
8760 events: These might get delayed via `mouse-autoselect-window'
8761 (Bug#11304).
8762
d69621cc
JB
87632012-04-24 Juanma Barranquero <lekktu@gmail.com>
8764
8765 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8766 manipulation of :loaded-from data.
8767
02fd101b
JB
87682012-04-23 Juanma Barranquero <lekktu@gmail.com>
8769
8770 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8771 now a cons (bug#11311).
8772
888bec30
PE
87732012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8774
89a438bd
PE
8775 Do not create empty overlays with the evaporate property (Bug#9642).
8776 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8777 if it becomes empty after its bounds are adjusted to fit within
8778 its buffer. Without this fix, in a nonempty buffer (let ((o
8779 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8780 yields an empty overlay that has the evaporate property, which is
8781 not supposed to happen.
8782
1068fe4d
PE
8783 Fix minor GTK3 problems found by static checking.
8784 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8785 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8786 (struct _EmacsFixedClass, emacs_fixed_get_type):
8787 Move decls here from emacsgtkfixed.h, since they needn't be public.
8788 (emacs_fixed_get_type): Now static.
8789 (emacs_fixed_class_init): Omit unused local.
8790 (emacs_fixed_child_type): Remove; unused.
8791 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8792 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8793 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8794 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8795 (EMACS_FIXED_GET_CLASS): Remove; unused.
8796 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8797
888bec30
PE
8798 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8799 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8800
de85e130
PE
88012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8802
d0baac98 8803 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8804 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8805 (__malloc_size_t, __malloc_ptrdiff_t):
8806 Remove. All uses removed, replaced by the definiens if needed,
8807 since we can assume C89 or better now.
8808 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8809 (protect_malloc_state, align, get_contiguous_space)
8810 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8811 (malloc_atfork_handler_child, malloc_enable_thread)
8812 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8813 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8814 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8815 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8816 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8817 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8818 Define using prototypes, not old style.
8819 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8820 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8821 (align): Don't assume that signed integer overflow wraps around.
8822 Omit unused local var.
8823 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8824 (_free_internal_nolock, memalign, mallochook, reallochook):
8825 Omit no-longer-needed casts.
8826 (valloc): Use getpagesize, not __getpagesize.
8827 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8828 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8829
de85e130
PE
8830 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8831
dcbf5805
MA
88322012-04-22 Michael Albinus <michael.albinus@gmx.de>
8833
8834 Move functions from C to Lisp. Make non-blocking method calls
8835 the default. Implement further D-Bus standard interfaces.
8836
8837 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8838 (QCdbus_request_name_allow_replacement)
8839 (QCdbus_request_name_replace_existing)
8840 (QCdbus_request_name_do_not_queue)
8841 (QCdbus_request_name_reply_primary_owner)
8842 (QCdbus_request_name_reply_in_queue)
8843 (QCdbus_request_name_reply_exists)
8844 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8845 (QCdbus_registered_serial, QCdbus_registered_method)
8846 (QCdbus_registered_signal): New Lisp objects.
8847 (XD_DEBUG_MESSAGE): Use sizeof.
8848 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8849 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8850 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8851 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8852 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8853 (xd_signature, xd_append_arg): Allow float for integer types.
8854 (xd_get_connection_references): New function.
b593d6a9
AH
8855 (xd_get_connection_address): Rename from xd_initialize.
8856 Return cached address.
dcbf5805
MA
8857 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8858 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8859 level.
8860 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8861 Return number of refcounts.
dcbf5805
MA
8862 (Fdbus_get_unique_name): Make stronger parameter check.
8863 (Fdbus_message_internal): New defun.
8864 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8865 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8866 (Fdbus_send_signal, Fdbus_register_service)
8867 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8868 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8869 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8870 (Vdbus_compiled_version, Vdbus_runtime_version)
8871 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8872 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8873 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8874 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8875 Adapt docstring.
dcbf5805 8876
52828e02
PE
88772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8878
da05bc4c
PE
8879 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8880 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8881 Do not assume ptrdiff_t is the same width as 'int'.
8882
52828e02
PE
8883 * alloc.c: Handle unusual debugging option combinations.
8884 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8885 since the two debugging options are incompatible.
8886 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8887 is defined.
8888 (mem_init, mem_insert, mem_insert_fixup):
8889 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8890 (NEED_MEM_INSERT): Remove; no longer needed.
8891
f01769f9
LL
88922012-04-22 Leo Liu <sdl.web@gmail.com>
8893
8894 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8895
5790543d
PE
88962012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8897
8898 * sysdep.c [__FreeBSD__]: Minor cleanups.
8899 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8900 Use Emacs indenting style more consistently. Avoid some casts.
8901 Use 'double' consistently rather than mixing 'float' and 'double'.
8902
b91b7e4d
EW
89032012-04-21 Eduard Wiebe <usenet@pusto.de>
8904
b593d6a9
AH
8905 * sysdep.c (list_system_processes, system_process_attributes):
8906 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8907
6114eb15
AS
89082012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8909
8910 * lisp.mk (lisp): Update.
8911
2f38dff7
PE
89122012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8913
8914 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8915 It is never used otherwise.
8916
4ae29f89
SM
89172012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8918
8919 * print.c (print_preprocess): Only check print_depth if print-circle
8920 is nil.
8921 (print_object): Check for cycles even when print-circle is nil and
8922 print-gensym is t, but only check print_depth if print-circle is nil.
8923
f30d612a
CY
89242012-04-20 Chong Yidong <cyd@gnu.org>
8925
8926 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8927 set the status to "failed" and ensure that sentinel is run.
8928
c07a4c0b 89292012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8930
8931 * process.c (Fset_process_inherit_coding_system_flag)
8932 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8933 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8934
c07a4c0b 89352012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8936
8937 * xdisp.c (string_buffer_position_lim): Limit starting position to
8938 BEGV.
8939 (set_cursor_from_row): If called for a mode-line or header-line
8940 row, return zero immediately.
8941 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8942 farther than the first row after the header line, if any.
8943 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8944 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8945
c07a4c0b 89462012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8947
4ae29f89
SM
8948 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8949 (bug#11238).
ad3a2b41 8950
c07a4c0b 89512012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 89522012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8953
8954 configure: new option --enable-gcc-warnings (Bug#11207)
8955 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8956 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8957 (ALL_CFLAGS): Use new macros rather than old.
8958 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8959 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8960 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8961 -Wunused-result, -Wunused-variable. This should go away once
8962 the Emacs and Gnulib regex code is merged.
8963 (xmalloc, xrealloc): Now static.
8964
aba027e8
PE
89652012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8966
8967 * dired.c (Fsystem_groups): Remove unused local.
8968
e5a36063
GM
89692012-04-17 Glenn Morris <rgm@gnu.org>
8970
8971 * dired.c (Fsystem_users): Doc fix.
8972
316411f0
DA
89732012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8974
8975 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8976 (syms_of_dired): Add them.
8977
9426aba4
PE
89782012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8979
b62a57be
PE
8980 Fix minor alloc.c problems found by static checking.
8981 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8982 New extern decls, to avoid calling undeclared functions.
8983 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8984 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8985 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8986 (NEED_MEM_INSERT): New macro.
8987 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8988 Remove one incorrect comment and fix another.
b62a57be 8989
3539f31f
PE
8990 Fix minor ralloc.c problems found by static checking.
8991 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8992 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8993 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8994 (r_alloc_sbrk): Now static.
8995
a041960a
PE
8996 Improve ralloc.c interface checking.
8997 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8998 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8999 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
9000 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
9001 [REL_ALLOC]: ... to here, to check interface.
9002 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
9003 Remove decls. This fixes an "It stinks!".
9004
9426aba4
PE
9005 * alloc.c (which_symbols): Fix alignment issue / type clash.
9006
d55c12ed
AS
90072012-04-15 Andreas Schwab <schwab@linux-m68k.org>
9008
9009 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
9010 (struct Lisp_Misc_Any): Likewise.
9011 (struct Lisp_Free): Likewise.
9012 * alloc.c (union aligned_Lisp_Symbol): Define.
9013 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
9014 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
9015 (union aligned_Lisp_Misc): Define.
9016 (MARKER_BLOCK_SIZE, struct marker_block): Use union
9017 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 9018 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 9019
b948ce8b
PE
90202012-04-14 Paul Eggert <eggert@cs.ucla.edu>
9021
9022 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
9023 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
9024 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
9025 * s/netbsd.h, s/sol2-6.h:
9026 Remove definition of GC_MARK_STACK, since the default now works.
9027 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
9028 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
9029 no longer the default.
9030 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
9031
35dc09a1 90322012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 9033
35dc09a1
GM
9034 * lread.c (lisp_file_lexically_bound_p):
9035 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 9036
35dc09a1
GM
90372012-04-14 Eli Zaretskii <eliz@gnu.org>
9038
9039 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
9040 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
9041
90422012-04-14 Jan Djärv <jan.h.d@swipnet.se>
9043
9044 * nsterm.m (constrainFrameRect): Always constrain when there is only
9045 one screen (Bug#10962).
9046
bcd86815
KB
90472012-04-13 Ken Brown <kbrown@cornell.edu>
9048
9049 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
9050
c25df26e
RT
90512012-04-13 Reuben Thomas <rrt@sc3d.org>
9052
9053 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
9054
0fc59f1e
DC
90552012-04-11 Daniel Colascione <dancol@dancol.org>
9056
9057 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
9058 against is gone. It's better to use vfork now so that when Cygwin
9059 gains a new, working vfork, we use it automatically (bug#10398).
9060
de8c03dc
SM
90612012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
9062
9063 * window.c (save_window_save): Obey window-point-insertion-type.
9064
2f097256
GM
90652012-04-11 Glenn Morris <rgm@gnu.org>
9066
9067 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
9068
453b951e
SM
90692012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
9070
9071 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
9072
75f1671a 90732012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
9074
9075 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
9076 (force_quit_count): New var.
9077 (handle_interrupt): Use it.
9078
2a8ce227
JB
90792012-04-10 Juanma Barranquero <lekktu@gmail.com>
9080
9081 * w32.c (w32_delayed_load): Record the full path of the library
9082 being loaded (bug#10424).
9083
935396c0
GM
90842012-04-09 Glenn Morris <rgm@gnu.org>
9085
05920a43
GM
9086 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
9087 not just in the obarray, before snarfing them. (Bug#11036)
9088
935396c0
GM
9089 * Makefile.in ($(leimdir)/leim-list.el):
9090 Pass EMACS rather than BUILT_EMACS.
9091
a18ecafa
TZ
90922012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
9093
9094 * process.c (make_process):
9095 * process.h: Add integer `gnutls_handshakes_tried' member to
9096 process struct.
9097
6bbef4e5
JC
9098 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
9099 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
9100
9101 * gnutls.c (gnutls_log_function2i): Convenience log function.
9102 (emacs_gnutls_read): Use new log functions,
9103 `gnutls_handshakes_tried' process member, and
9104 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
9105 attempts per process (connection).
9106
b4d3bc10
CY
91072012-04-09 Chong Yidong <cyd@gnu.org>
9108
9109 * eval.c (Fuser_variable_p, user_variable_p_eh)
9110 (lisp_indirect_variable): Functions deleted.
9111 (Fdefvar): Caller changed.
9112
9113 * callint.c (Finteractive, Fcall_interactively):
9114 * minibuf.c (Fread_variable): Callers changed.
9115
70f4d973
EZ
91162012-04-09 Eli Zaretskii <eliz@gnu.org>
9117
9118 * xdisp.c (set_cursor_from_row): If the display string appears in
9119 the buffer at position that is closer to point than the position
9120 after the display string, display the cursor on the first glyph of
9121 the display string. Fixes cursor display when a 'display' text
9122 property immediately follows invisible text. (Bug#11094)
9123
cb3c2e3e
PE
91242012-04-09 Paul Eggert <eggert@cs.ucla.edu>
9125
9126 composite.c: use 'double' consistently
9127 * composite.c (get_composition_id): Use 'double' consistently
9128 instead of converting 'float' to 'double' and vice versa; this is
9129 easier to understand and avoids a GCC warning.
9130
fd06db5d
GM
91312012-04-09 Glenn Morris <rgm@gnu.org>
9132
50fe702a
GM
9133 * Makefile.in: Generate leim-list with bootstrap-emacs, in
9134 preparation for dumping it with emacs. (Bug#4789)
9135 (leimdir): New variable.
9136 ($(leimdir)/leim-list.el): New rule.
9137 (emacs$(EXEEXT)): Depend on leim-list.el.
9138
fd06db5d
GM
9139 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
9140 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
9141 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
9142
55c131ee
AS
91432012-04-08 Andreas Schwab <schwab@linux-m68k.org>
9144
9145 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
9146 proper alignment.
9147
9209588f
JB
91482012-04-07 Juanma Barranquero <lekktu@gmail.com>
9149
9150 * xml.c (init_libxml2_functions) [WINDOWSNT]:
9151 Remove unused local variable.
9152
e3fb2efb
PE
91532012-04-07 Paul Eggert <eggert@cs.ucla.edu>
9154
9155 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
9156 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
9157 (mark_memory): Mark Lisp_Objects only if pointers might hide in
9158 objects, as mark_maybe_pointer will catch them otherwise.
9159 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
9160 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
9161
b5385551
PE
91622012-04-07 Paul Eggert <eggert@cs.ucla.edu>
9163
9164 Fix typo that broke non-Windows builds.
9165 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
9166
9078ead6
EZ
91672012-04-07 Eli Zaretskii <eliz@gnu.org>
9168
9169 Support building on MS-Windows with libxml2.
9170
9171 * makefile.w32-in (OBJ2): Add xml.$(O).
9172 (GLOBAL_SOURCES): Add xml.c.
9173 ($(BLD)/xml.$(O)): New dependency list.
9174
9175 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
9176 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
9177 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
9178 [!WINDOWSNT]: New macros.
9179 (init_libxml2_functions, libxml2_loaded_p): New functions.
9180 (parse_region): Call fn_xmlCheckVersion instead of using the macro
9181 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
9182 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
9183 Calls xmlCleanupParser only if libxml2 was loaded (or statically
9184 linked in).
6bbef4e5
JC
9185 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
9186 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
9187 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
9188
9189 * emacs.c: Don't include libxml/parser.h.
9190 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
9191 xmlCleanupParser directly.
9192
9193 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
9194
3811fdf3
EZ
91952012-04-07 Eli Zaretskii <eliz@gnu.org>
9196
9197 * indent.c (Fvertical_motion): If there is a display string at
9198 point, use it.vpos to compute how many lines to backtrack after
9199 move_it_to point. (Bug#11133)
9200
2f8e16b2
EZ
92012012-04-06 Eli Zaretskii <eliz@gnu.org>
9202
9203 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
9204 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
9205 about subtle differences between FETCH_CHAR* and STRING_CHAR*
9206 macros related to unification of CJK characters. For the details,
9207 see the discussion following the message here:
9208 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
9209
3d439cd1
CY
92102012-04-04 Chong Yidong <cyd@gnu.org>
9211
9212 * keyboard.c (Vdelayed_warnings_list): Doc fix.
9213
8bc53d00
EZ
92142012-04-01 Eli Zaretskii <eliz@gnu.org>
9215
9216 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
9217 instead of alloca. (Bug#11138)
9218
3b0512a3
AS
92192012-04-01 Andreas Schwab <schwab@linux-m68k.org>
9220
9221 * w32menu.c (is_simple_dialog): Properly check lisp types.
9222 (Bug#11141)
9223
8427ddd2
EZ
92242012-03-31 Eli Zaretskii <eliz@gnu.org>
9225
979022ef
EZ
9226 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
9227 position we get to after a call to move_it_to fails the
9228 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
9229 only if we wind up in a string from display property. (Bug#11063)
9230
a6b1c7cc
EZ
9231 * window.c (Fdelete_other_windows_internal): Invalidate the row
9232 and column information about mouse highlight, so that redisplay
9233 restores it after reallocating the glyph matrices. (Bug#7464)
9234
8427ddd2
EZ
9235 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
9236 string comes from a `display' text property, use the buffer
9237 position of that property as if we actually saw that position in
9238 the row's glyphs.
697ba24b
EZ
9239 (move_it_by_lines): Remove the assertion that
9240 "it->current_x == 0 && it->hpos == 0" which can be legitimately
9241 violated when there's a before-string at the beginning of a line.
9242 (Bug#11063)
8427ddd2 9243
65a0a738
EZ
92442012-03-30 Eli Zaretskii <eliz@gnu.org>
9245
9246 * xdisp.c (append_space_for_newline): If the default face was
9247 remapped, use the remapped face for the appended newline.
9248 (extend_face_to_end_of_line): Use the remapped default face for
9249 extending the face to the end of the line.
9250 (display_line): Call extend_face_to_end_of_line when the default
9251 face was remapped. (Bug#11068)
9252
581355cc
EZ
92532012-03-29 Eli Zaretskii <eliz@gnu.org>
9254
9255 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
9256
e8fc049f
SM
92572012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9258
9259 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
9260
4fb9a543
GM
92612012-03-27 Glenn Morris <rgm@gnu.org>
9262
9263 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
9264 Doc fixes.
9265
679910f1
KH
92662012-03-26 Kenichi Handa <handa@m17n.org>
9267
9268 * dispextern.h (struct glyph): Fix previous change. Change the
9269 bit length of glyphless.ch to 25 (Bug#11082).
9270
90d49b7f
CY
92712012-03-26 Chong Yidong <cyd@gnu.org>
9272
9273 * keyboard.c (Vselection_inhibit_update_commands): New variable.
9274 (command_loop_1): Use it; inhibit selection update for
9275 handle-select-window too (Bug#8996).
9276
f514f6f0
FP
92772012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
9278
e8fc049f 9279 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 9280
bf43fa51
KH
92812012-03-25 Kenichi Handa <handa@m17n.org>
9282
9283 * dispextern.h (struct glyph): Change the bit length of
9284 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
9285
8a0c01dd
EZ
92862012-03-24 Eli Zaretskii <eliz@gnu.org>
9287
9288 * s/ms-w32.h (tzname): Include time.h before redirecting to
9289 _tzname. Fixes the MSVC build. (Bug#9960)
9290
7d1c3a76
AS
92912012-03-24 Andreas Schwab <schwab@linux-m68k.org>
9292
8ed79523
AS
9293 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
9294 characters.
9295
7d1c3a76
AS
9296 * xterm.c (XTread_socket): Only modify handling_signal if
9297 !SYNC_INPUT. (Bug#11080)
9298
e99a9b8b
EZ
92992012-03-23 Eli Zaretskii <eliz@gnu.org>
9300
9301 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
9302 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
9303 when fetching a multibyte character consumes more bytes than
9304 CHAR_BYTES returns, due to unification of CJK characters in
9305 string_char. (Bug#11073)
9306
5063c0e1
TN
93072012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
9308
9309 * process.c (wait_reading_process_output): Handle pty disconnect
9310 by refraining from sending oneself a SIGCHLD (bug#10933).
9311
9f851fbd
CY
93122012-03-22 Chong Yidong <cyd@gnu.org>
9313
9314 * dispextern.h (struct it): New member string_from_prefix_prop_p.
9315
5063c0e1 9316 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
9317 Mark string as coming from a prefix property.
9318 (handle_face_prop): Use default face for prefix strings (Bug#4281).
9319 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
9320
fb5b8aca
CY
93212012-03-21 Chong Yidong <cyd@gnu.org>
9322
9323 * xfaces.c (Vface_remapping_alist): Doc fix.
9324
62356a1b
EZ
93252012-03-20 Eli Zaretskii <eliz@gnu.org>
9326
9327 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
9328 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
9329 Doc fixes.
62356a1b 9330
025de85b
CY
93312012-03-20 Chong Yidong <cyd@gnu.org>
9332
9333 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
9334 to reflect default non-nil value of redisplay-dont-pause.
9335
4827f94e
KH
93362012-03-19 Kenichi Handa <handa@m17n.org>
9337
9338 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
9339 it fit in a valid range (Bug#11003).
9340
e50a24a2
EZ
93412012-03-18 Eli Zaretskii <eliz@gnu.org>
9342
9343 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
9344 that is not from display property, accept the row as a "cursor
9345 row" if one of the string's character has a non-nil `cursor'
9346 property. Fixes cursor positioning when there are newlines in
9347 overlay strings, e.g. in icomplete.el. (Bug#11035)
9348
9af5ed87
PE
93492012-03-12 Paul Eggert <eggert@cs.ucla.edu>
9350
9351 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
9352
d1f55f16
CY
93532012-03-12 Chong Yidong <cyd@gnu.org>
9354
9355 * eval.c (inhibit_lisp_code): Rename from
9356 inhibit_window_configuration_change_hook; move from window.c.
9357
9358 * xfns.c (unwind_create_frame_1, Fx_create_frame):
9359 * window.c (run_window_configuration_change_hook)
9360 (syms_of_window): Callers changed.
9361
66c5eebd
CY
93622012-03-11 Chong Yidong <cyd@gnu.org>
9363
413df973
CY
9364 * keymap.c (Fkey_description): Doc fix (Bug#9700).
9365
66c5eebd
CY
9366 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
9367
1de11f56
CY
93682012-03-10 Chong Yidong <cyd@gnu.org>
9369
9370 * frame.c (other_visible_frames): Don't assume the selected frame
9371 is visible (Bug#10955).
9372
cae07000
SM
93732012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
9374
9375 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
9376
89c94350
JD
93772012-03-08 Jan Djärv <jan.h.d@swipnet.se>
9378
9379 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
9380 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
9381 zero (Bug#10954).
9382
999dd333
GM
93832012-03-03 Glenn Morris <rgm@gnu.org>
9384
01a6dcc8 9385 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 9386
de0100f2
EZ
93872012-03-02 Eli Zaretskii <eliz@gnu.org>
9388
9389 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
9390 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
9391 (redisplay_window, next_element_from_string): Fix typos in
9392 comments.
3e441275
EZ
9393 (redisplay_window): Pass to move_it_vertically the margin in
9394 pixels, not in screen lines.
de0100f2 9395
96a72ee9
GM
93962012-03-02 Glenn Morris <rgm@gnu.org>
9397
9398 * buffer.c (buffer-list-update-hook): Doc fix.
9399
312508d7
EZ
94002012-02-29 Eli Zaretskii <eliz@gnu.org>
9401
9402 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
9403 push_it before setting up the iterator for the first overlay
9404 string, even if we have an empty string loaded.
9405 (next_overlay_string): If there's an empty string on the iterator
9406 stack, pop the stack. (Bug#10903)
9407
27f3c637
PE
94082012-02-25 Paul Eggert <eggert@cs.ucla.edu>
9409
9410 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
9411 Suggested by Stefan Monnier in
9412 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
9413 * alloc.c (widen_to_Lisp_Object): New static function.
9414 (mark_memory): Also mark Lisp_Objects by fetching pointer words
9415 and widening them to Lisp_Objects. This would work even if
9416 USE_LSB_TAG is defined and wide integers are used, which might
9417 happen in a future version of Emacs.
9418
3c9dfce6
CY
94192012-02-25 Chong Yidong <cyd@gnu.org>
9420
fa74b241
CY
9421 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
9422 Doc fix.
9423
3c9dfce6
CY
9424 * xselect.c (Fx_selection_exists_p): Doc fix.
9425 (x_clipboard_manager_save_all): Print an informative message
9426 before saving to clipboard manager.
9427
9486df08
CY
94282012-02-24 Chong Yidong <cyd@gnu.org>
9429
9430 * keyboard.c (process_special_events): Handle all X selection
9431 requests in kbd_buffer, not just the next one (Bug#8869).
9432
f01d3321
CY
94332012-02-23 Chong Yidong <cyd@gnu.org>
9434
9435 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9436 call when setting menu-bar-lines and tool-bar-lines parameters.
9437 (unwind_create_frame_1): New helper function.
9438
9439 * window.c (inhibit_window_configuration_change_hook): New var.
9440 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9441 (syms_of_window): Initialize it.
f01d3321 9442
86b847b6
CY
94432012-02-22 Chong Yidong <cyd@gnu.org>
9444
9445 * xterm.c (x_draw_image_relief): Add missing type check for
9446 Vtool_bar_button_margin (Bug#10743).
9447
a59225b1
CY
94482012-02-21 Chong Yidong <cyd@gnu.org>
9449
9450 * fileio.c (Vfile_name_handler_alist): Doc fix.
9451
9452 * buffer.c (Fget_file_buffer): Protect against invalid file
9453 handler return value.
9454
310f5bd4
PE
94552012-02-20 Paul Eggert <eggert@cs.ucla.edu>
9456
cb3a28cc
PE
9457 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
9458 when computing $valmask.
9459
310f5bd4
PE
9460 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
9461 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
9462 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9463 It's useless in that case, and it can cause problems on hosts
9464 that allocate halves of EMACS_INT values separately.
9465 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9466 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
9467 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
9468 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
9469 it avoids undefined behavior on hosts where shifting right by more
9470 than the word width has undefined behavior.
9471
2375c96a
CY
94722012-02-19 Chong Yidong <cyd@gnu.org>
9473
9474 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
9475 (Funhandled_file_name_directory, Ffile_name_as_directory)
9476 (Fdirectory_file_name, Fexpand_file_name)
9477 (Fsubstitute_in_file_name): Protect against invalid file handler
9478 return values (Bug#10845).
9479
3eb49e71
EZ
94802012-02-18 Eli Zaretskii <eliz@gnu.org>
9481
9482 * .gdbinit (pitx): Fix incorrect references to fields of the
9483 iterator stack.
9484
7b926f3f
CY
94852012-02-17 Chong Yidong <cyd@gnu.org>
9486
9487 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
9488
11273115
PE
94892012-02-15 Paul Eggert <eggert@cs.ucla.edu>
9490
9491 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
9492 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
9493
c3a70e2b
CY
94942012-02-15 Chong Yidong <cyd@gnu.org>
9495
9496 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
9497 marked as special. Also, starting docstrings with * is obsolete.
9498
0ca43699
AS
94992012-02-13 Andreas Schwab <schwab@linux-m68k.org>
9500
9501 * gnutls.c (emacs_gnutls_write): Fix last change.
9502
2e8f3c56
LI
95032012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
9504
9505 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
9506 send_process.
9507
af70074f
SM
95082012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
9509
9510 * keymap.c (Fsingle_key_description): Handle char ranges.
9511
95986d52
CY
95122012-02-12 Chong Yidong <cyd@gnu.org>
9513
afd83bd1
CY
9514 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
9515 as that creates a dangerous corner case.
9516
95986d52
CY
9517 * window.c (Fdelete_window_internal): Invalidate the mouse
9518 highlight (Bug#9904).
9519
bd7da63e
GM
95202012-02-12 Glenn Morris <rgm@gnu.org>
9521
9522 * xselect.c (Fx_own_selection_internal)
9523 (Fx_get_selection_internal, Fx_disown_selection_internal)
9524 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
9525 * nsselect.m (Fx_own_selection_internal)
9526 (Fx_disown_selection_internal, Fx_selection_exists_p)
9527 (Fx_selection_owner_p, Fx_get_selection_internal):
9528 Sync docs and argument specs with the xselect.c versions.
9529
77abcbc2
LI
95302012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
9531
9532 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
9533
90b671e2
EZ
95342012-02-11 Eli Zaretskii <eliz@gnu.org>
9535
1c0ca0b7
EZ
9536 * w32select.c (Fx_selection_exists_p): Sync doc string and
9537 argument list with xselect.c. (Bug#10783)
9538
9539 * w16select.c (Fx_selection_exists_p): Sync doc string and
9540 argument list with xselect.c. (Bug#10783)
90b671e2 9541
49241268
GM
95422012-02-10 Glenn Morris <rgm@gnu.org>
9543
9544 * fns.c (Fsecure_hash): Doc fix.
9545
f998bbe7 95462012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
9547
9548 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
9549
0992bd9c
CY
95502012-02-07 Chong Yidong <cyd@gnu.org>
9551
9552 * buffer.c (Fbuffer_local_variables)
9553 (buffer_lisp_local_variables): Handle unbound vars correctly;
9554 don't let Qunbound leak into Lisp.
9555
af008560
GM
95562012-02-07 Glenn Morris <rgm@gnu.org>
9557
dd605cc4
GM
9558 * image.c (Fimagemagick_types): Doc fix.
9559
af008560
GM
9560 * image.c (imagemagick-render-type): Change it from a lisp object
9561 to an integer. Move the doc here from the lisp manual.
9562 Treat all values not equal to 0 the same.
9563
1449fa1d
CY
95642012-02-06 Chong Yidong <cyd@gnu.org>
9565
9566 * doc.c (store_function_docstring): Avoid applying docstring of
9567 alias to base function (Bug#2603).
9568
3723ec07
AS
95692012-02-04 Andreas Schwab <schwab@linux-m68k.org>
9570
9571 * .gdbinit (pp1, pv1): Remove redundant defines.
9572 (pr): Use pp.
9573
79c1cc1e
CY
95742012-02-04 Chong Yidong <cyd@gnu.org>
9575
9576 * nsterm.m: Declare a global (Bug#10694).
9577
d7f29f8e
EZ
95782012-02-04 Eli Zaretskii <eliz@gnu.org>
9579
cae07000
SM
9580 * w32.c (get_emacs_configuration_options):
9581 Include --enable-checking, if specified, in the return value.
d7f29f8e 9582
3b95a6f9
MR
95832012-02-04 Martin Rudalics <rudalics@gmx.at>
9584
9585 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
9586 after rounding frame sizes. (Bug#9723)
9587
d6fa96a6
EZ
95882012-02-04 Eli Zaretskii <eliz@gnu.org>
9589
9590 * keyboard.c (adjust_point_for_property): Don't position point
9591 before BEGV. (Bug#10696)
9592
df0b2940
PE
95932012-02-03 Paul Eggert <eggert@cs.ucla.edu>
9594
9595 Handle overflow when computing char display width (Bug#9496).
9596 * character.c (char_width): Return EMACS_INT, not int.
9597 (char_width, c_string_width): Check for overflow when
9598 computing the width; this is possible now that individual
9599 characters can have unbounded width. Problem introduced
9600 by merge from Emacs 23 on 2012-01-19.
9601
6bee44d6
MA
96022012-02-02 Michael Albinus <michael.albinus@gmx.de>
9603
9604 * dbusbind.c (Fdbus_register_method): Mention the return value
9605 :ignore in the docstring.
9606
44f92739
GM
96072012-02-02 Glenn Morris <rgm@gnu.org>
9608
1b9f60cc
GM
9609 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9610
44f92739
GM
9611 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9612 Unconditionally set to t. (Bug#10673)
9613 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9614 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9615 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
9616
c5d3843c
KH
96172012-02-02 Kenichi Handa <handa@m17n.org>
9618
9619 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
9620 0, do not call append_composite_glyph.
9621
159462d4 96222012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
9623
9624 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9625 NULL (Bug#6988).
9626 (x_produce_glyphs): If the component of a composition is a null
9627 string, set it->pixel_width to 1 to avoid zero-width glyph.
9628
78cef877
EZ
96292012-02-01 Eli Zaretskii <eliz@gnu.org>
9630
9631 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
9632 first 2 arguments are identical. This makes inserting large
9633 output from a subprocess an order of magnitude faster on
9634 MS-Windows, where all sbrk'ed memory is always contiguous.
9635
97897668
GM
96362012-01-31 Glenn Morris <rgm@gnu.org>
9637
9638 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 9639 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
9640 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
9641
31fd3586
GM
96422012-01-29 Glenn Morris <rgm@gnu.org>
9643
9644 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
9645
0e24a8b2
CY
96462012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
9647
9648 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
9649
cc0adcb0
CY
96502012-01-28 Chong Yidong <cyd@gnu.org>
9651
9652 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
9653
acc28cb9
CY
96542012-01-26 Chong Yidong <cyd@gnu.org>
9655
9c69cfb7
CY
9656 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
9657
acc28cb9
CY
9658 * search.c (Fsearch_forward, Fsearch_backward): Document negative
9659 repeat counts (Bug#10507).
9660
48da7392
GM
96612012-01-26 Glenn Morris <rgm@gnu.org>
9662
9663 * lread.c (syms_of_lread): Doc fix.
9664
14af5f7f
CY
96652012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
9666
9667 * coding.c (encode_designation_at_bol): Change return value to
9668 EMACS_INT.
9669
0b21c100
CY
96702012-01-25 Chong Yidong <cyd@gnu.org>
9671
9672 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
9673
3c2907f7
CY
96742012-01-21 Chong Yidong <cyd@gnu.org>
9675
9676 * floatfns.c (Fcopysign): Make the second argument non-optional,
9677 since nil is not allowed anyway.
9678
959ad23f
AS
96792012-01-21 Andreas Schwab <schwab@linux-m68k.org>
9680
9681 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9682 (send_process): Likewise.
9683
34a02f46
MR
96842012-01-19 Martin Rudalics <rudalics@gmx.at>
9685
9686 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
9687 (Vwindow_persistent_parameters): Do not use Qstate.
9688 Rewrite doc-strings.
34a02f46 9689
1259009a 96902012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
9691
9692 * character.c (char_width): New function.
70d4fdf6
GM
9693 (Fchar_width, c_string_width, lisp_string_width):
9694 Use char_width (Bug#9496).
25ed9e61 9695
6a6ee00d
MR
96962012-01-16 Martin Rudalics <rudalics@gmx.at>
9697
9698 * window.c (Vwindow_persistent_parameters): New variable.
9699 (Fset_window_configuration, save_window_save): Handle persistent
9700 window parameters.
9701
c85efaf7
EZ
97022012-01-14 Eli Zaretskii <eliz@gnu.org>
9703
9704 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
9705 thrashing the stack of the thread. (Bug#9087)
9706
5944709e
PE
97072012-01-12 Paul Eggert <eggert@cs.ucla.edu>
9708
9709 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9710
e71f5d99
EZ
97112012-01-11 Eli Zaretskii <eliz@gnu.org>
9712
9713 * xdisp.c (rows_from_pos_range): Handle the case where the
9714 highlight ends on a newline. (Bug#10464)
9715 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
9716 he end column for display of highlight that ends on a newline
9717 before a R2L line.
9718
ce316182
GM
97192012-01-11 Glenn Morris <rgm@gnu.org>
9720
9721 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
9722 from load-path also when installation-directory is nil. (Bug#10208)
9723
5b43da69
GM
97242012-01-10 Glenn Morris <rgm@gnu.org>
9725
74cc8ff9
GM
9726 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
9727
7d8d6e4e
GM
9728 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
9729 Update template values to be closer to their typical values these days.
5b43da69 9730
a0db8d43
EZ
97312012-01-09 Eli Zaretskii <eliz@gnu.org>
9732
9733 * xdisp.c (rows_from_pos_range): Accept additional argument
9734 DISP_STRING, and accept any glyph in a row whose object is that
9735 string as eligible for mouse highlight. Fixes mouse highlight of
9736 display strings from overlays. (Bug#10464)
9737
9a0115ab 97382012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 9739
b9110d6a 9740 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
9741 * fileio.c (auto_saving_dir_umask): New static var.
9742 (Fmake_directory_internal): Use it.
9743 (do_auto_save_make_dir): Set it, instead of invoking chmod after
9744 creating the directory. The old code temporarily assigns
9745 too-generous permissions to the directory.
9746 (do_auto_save_eh): Clear it.
b9110d6a 9747 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9748 that the var is always cleared.
9749
6c1bd3f3
EZ
97502012-01-07 Eli Zaretskii <eliz@gnu.org>
9751
9752 * search.c (scan_buffer): Pass character positions to
9753 know_region_cache, not byte positions. (Bug#6540)
9754
069d2b50
L
97552012-01-07 LynX <_LynX@bk.ru> (tiny change)
9756
9757 * w32.c (sys_rename): Report EXDEV when rename of a directory
9758 fails because the target is on another logical disk. (Bug#10284)
9759
75bf0d33
DB
97602012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9761
9762 * xterm.c (x_embed_request_focus): New function.
9763
9764 * xterm.h: Add prototype.
9765
9766 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9767
1c6e5a32
GM
97682012-01-05 Glenn Morris <rgm@gnu.org>
9769
9770 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9771
651e947e
EZ
97722012-01-01 Eli Zaretskii <eliz@gnu.org>
9773
9774 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9775 Load gnutls_transport_set_lowat only if GnuTLS version is below
9776 2.11.1.
9777 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9778 GnuTLS versions below 2.11.1.
9779
3778cdd8
AL
97802011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9781
9782 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9783 to the doc string advising against its use for altering the way
9784 windows are scrolled.
9785
0e5317f7
KH
97862011-12-28 Kenichi Handa <handa@m17n.org>
9787
9788 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9789 coding-system ASCII compatible only when it does not produce BOM
9790 on encoding (Bug#10383).
9791
93d5ca1f
JD
97922011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9793
9794 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9795 can scroll.
9796 (create_and_show_popup_menu): Always use menu_position_func for
9797 Gtk3 (Bug#10361).
9798
ca22b785
AS
97992011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9800
9801 * callint.c (Fcall_interactively): Don't truncate prompt string.
9802
d048e1e6
EZ
98032011-12-23 Eli Zaretskii <eliz@gnu.org>
9804
9805 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9806 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9807 resumed from there (after widening). (Bug#10360)
d048e1e6 9808
5ccaba1f
JD
98092011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9810
9811 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9812
204ee57f
JD
98132011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9814
b81d40f0
JB
9815 * nsterm.m (x_free_frame_resources):
9816 Release f->output_data.ns->miniimage.
204ee57f
JD
9817 (ns_index_color): Fix indentation. Do not retain
9818 color_table->colors[i].
9819
9820 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9821 before returning.
9822
9823 * nsfns.m (x_set_background_color): Assign return value from
9824 ns_index_color to face-background instead of NSColor*.
9825 (ns_implicitly_set_icon_type): Fix indentation.
9826 Change assignment in for loop to comparison.
9827
9828 * emacs.c (ns_pool): New variable.
9829 (main): Assign ns_pool.
9830 (Fkill_emacs): Call ns_release_autorelease_pool.
9831
9832 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9833 autorelease fdesc, release fdAttrs and tdict.
9834 (ns_get_covering_families): Release charset.
9835 (ns_findfonts): Release NSFontDescriptor created with new.
9836 (ns_uni_to_glyphs): Fix indentation.
9837 (setString): Release attrStr before assigning new value.
9838
c803b2b7
JD
98392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9840
678f4426
JD
9841 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9842 and NS_IMPL_COCOA.
9843 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9844 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9845
cd394be1 98462011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9847
5fecd5fc
JD
9848 * nsterm.m (ns_term_init): Subscribe for notifications
9849 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9850 to method trackingNotification in EmacsMenu.
9851
9852 * nsmenu.m (trackingMenu): New variable.
3771cb17 9853 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9854 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9855 from Aquamacs (Bug#7030).
678f4426
JD
9856
98572011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9858
c803b2b7
JD
9859 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9860 (symbol_to_nsstring): Fix indentation.
9861 (ns_symbol_to_pb): New function.
cae07000
SM
9862 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9863 (Fns_rotate_cut_buffers_internal): Remove.
9864 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9865 Fns_store_cut_buffer_internal.
9866 (ns_get_foreign_selection, Fx_own_selection_internal)
9867 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9868 (Fns_get_selection_internal, Fns_store_selection_internal):
9869 Use ns_symbol_to_pb and check if return value is nil.
9870 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9871 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9872 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9873 renamed to Sns_store_selection_internal.
9874 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9875 and remove this function.
9876 (ns_handle_selection_clear): Remove, never used.
9877 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9878 here.
9879
e1b01a3a
KB
98802011-12-17 Ken Brown <kbrown@cornell.edu>
9881
9882 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9883 GID is unknown (Bug#10257).
9884
2adb6e85
PE
98852011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9886
9887 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9888 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9889 which caused a build failure on GNU/Linux IA-64. This problem was
9890 introduced by my 2011-10-07 patch.
9891
d1d7b339
JL
98922011-12-15 Juri Linkov <juri@jurta.org>
9893
9894 * image.c (imagemagick_error): New function. (Bug#10112)
9895 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9896 Use `imagemagick_error' where ImageMagick functions return
9897 `MagickFalse'.
9898 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9899 proper order.
9900
100d5755
KH
99012011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9902
9903 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9904 fill background (Bug#8992).
9905
454592a6
MR
99062011-12-13 Martin Rudalics <rudalics@gmx.at>
9907
9908 * window.c (Vwindow_combination_resize)
9909 (Vwindow_combination_limit): Use t instead of non-nil in
9910 doc-strings.
61d4b438
MR
9911 (Vrecenter_redisplay): Add first sentence of doc-string on
9912 separate line.
53524d93 9913 (Frecenter): Fix doc-string typo.
454592a6 9914
3633e3aa
KH
99152011-12-11 Kenichi Handa <handa@m17n.org>
9916
9917 * coding.c (Funencodable_char_position): Pay attention to the
9918 buffer text relocation (Bug#9389).
9919
7b9d523a 99202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9921
7b9d523a
JD
9922 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9923 gtk_init (Bug#10100).
9924
b73189c6
EZ
99252011-12-10 Eli Zaretskii <eliz@gnu.org>
9926
9927 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9928 IT->string is nil. (Bug#10263)
9929
f7dfe5d6
JD
99302011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9931
83faebb4
JD
9932 * nsterm.h (x_free_frame_resources): Declare.
9933
f7dfe5d6
JD
9934 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9935 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9936
9937 * nsterm.h (ns_get_defaults_value): Declare.
9938
9939 * nsterm.m (ns_default): Call ns_get_defaults_value.
9940
7cd4e72c
EZ
99412011-12-09 Eli Zaretskii <eliz@gnu.org>
9942
9943 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9944 (Bug#10170)
9945
b34d7317
YM
99462011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9947
9948 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9949 that where the value of an _OBJC_* symbol points to is in the .bss
9950 section (Bug#10240).
9951
76470ad1
KH
99522011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9953
9954 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9955 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9956
745fff94
KH
99572011-12-08 Kenichi Handa <handa@m17n.org>
9958
9959 * ftfont.c (get_adstyle_property): Fix previous change
9960 (Bug#10233).
9961
6e44397c
JB
99622011-12-07 Juanma Barranquero <lekktu@gmail.com>
9963
9964 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9965 dirs from the default value of EMACSLOADPATH (bug#10208).
9966
7efa6272
GM
99672011-12-07 Glenn Morris <rgm@gnu.org>
9968
9969 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9970 installation and source directories as well. (Bug#10208)
9971
f6fc4d87
CY
99722011-12-06 Chong Yidong <cyd@gnu.org>
9973
9974 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9975
2bf26180
GM
99762011-12-06 Glenn Morris <rgm@gnu.org>
9977
9978 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9979 as an error, not just -1. (Bug#10217)
9980
3a6ad4f0
CY
99812011-12-05 Chong Yidong <cyd@gnu.org>
9982
9983 * keyboard.c (process_special_events): New function.
9984 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9985
75a3b399
PE
99862011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9987
9988 * coding.c (encode_designation_at_bol): Don't use uninitialized
9989 local variable (Bug#9318).
9990
c3c9e25e
KH
99912011-12-05 Kenichi Handa <handa@m17n.org>
9992
9993 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9994 return Qnil (Bug#8046, Bug#10193).
9995
5eb05ea3
KH
99962011-12-05 Kenichi Handa <handa@m17n.org>
9997
9998 * coding.c (encode_designation_at_bol): New args charbuf_end and
9999 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
10000 (coding_set_source): Return how many bytes coding->source was
10001 relocated.
10002 (coding_set_destination): Return how many bytes
10003 coding->destination was relocated.
10004 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 10005 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
10006
100072011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10008
10009 * coding.c (CODING_CHAR_CHARSET_P): New macro.
10010 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
10011 macro (Bug#9318).
10012
100132011-12-05 Andreas Schwab <schwab@linux-m68k.org>
10014
10015 The following changes are to fix Bug#9318.
10016
a79703f5 10017 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
10018 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
10019 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 10020 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 10021
7dbda6df
JB
100222011-12-05 Juanma Barranquero <lekktu@gmail.com>
10023
10024 * lisp.h (process_quit_flag): Fix external declaration.
10025
6d5eb5b0
SM
100262011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
10027
10028 Don't macro-inline non-performance-critical code.
10029 * eval.c (process_quit_flag): New function.
10030 * lisp.h (QUIT): Use it.
10031
a0c3fad0
JD
100322011-12-04 Jan Djärv <jan.h.d@swipnet.se>
10033
10034 * nsfns.m (get_geometry_from_preferences): New function.
10035 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
10036
6c07aac2
AS
100372011-12-04 Andreas Schwab <schwab@linux-m68k.org>
10038
10039 * emacs.c (Qkill_emacs): Define.
10040 (syms_of_emacs): Initialize it.
10041 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
10042 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
10043 (quit_throw_to_read_char): Add parameter `from_signal'.
10044 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
10045 * lisp.h (QUIT): Call Fkill_emacs if requested.
10046
c052ead4
JD
100472011-12-03 Jan Djärv <jan.h.d@swipnet.se>
10048
10049 * widget.c (update_wm_hints): Return if wmshell is null.
10050 (widget_update_wm_size_hints): New function.
10051
10052 * widget.h (widget_update_wm_size_hints): Declare.
10053
10054 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
10055 widget_update_wm_size_hints (Bug#10104).
10056
9e49252b
EZ
100572011-12-03 Eli Zaretskii <eliz@gnu.org>
10058
10059 * xdisp.c (handle_invisible_prop): If the invisible text ends just
10060 before a newline, prepare the bidi iterator for consuming the
10061 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 10062 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 10063
02b16839
JL
100642011-12-02 Juri Linkov <juri@jurta.org>
10065
10066 * search.c (Fword_search_regexp): New Lisp function created from
10067 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
10068 (Fword_search_backward, Fword_search_forward)
10069 (Fword_search_backward_lax, Fword_search_forward_lax):
10070 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
10071 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
10072
0068070e
SM
100732011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
10074
10075 * fileio.c (Finsert_file_contents): Move after-change-function call
10076 to before the "handled:" label, since all "goto handled" appear in
10077 cases where the *-change-functions have already been properly called
10078 (bug#10117).
10079
3360a3fc
AS
100802011-12-01 Andreas Schwab <schwab@linux-m68k.org>
10081
10082 * keyboard.c (interrupt_signal): Don't call kill-emacs when
10083 waiting for input. (Bug#10169)
10084
73d6c093
EZ
100852011-11-30 Eli Zaretskii <eliz@gnu.org>
10086
10087 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
10088 verifies glyph row's hash code--we have just reallocated the
10089 glyphs, so their contents can be complete garbage. (Bug#10164)
10090
febe6bea
JB
100912011-11-30 Juanma Barranquero <lekktu@gmail.com>
10092
10093 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
10094
801a4313
EZ
100952011-11-30 Eli Zaretskii <eliz@gnu.org>
10096
10097 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
10098 attributes are tested _before_ calling verify_row_hash, to protect
10099 against GCC re-ordering of the tests. (Bug#10164)
10100
2b56b87e
JD
101012011-11-29 Jan Djärv <jan.h.d@swipnet.se>
10102
10103 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
10104
10105 * xterm.c (handle_one_xevent): Only set async_visible and friends
10106 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 10107 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
10108 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
10109
dbf31225
PE
101102011-11-28 Paul Eggert <eggert@cs.ucla.edu>
10111
10112 Remove GCPRO-related macros that exist only to avoid shadowing locals.
10113 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
10114 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
10115 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
10116 All uses changed to use GCPRO1 etc.
10117 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
10118 Revert to old implementation (i.e., before 2011-03-11).
10119
1305621b
YM
101202011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10121
10122 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
10123 of scroll runs so as to avoid assigning disabled bogus rows and
10124 unnecessary graphics copy operations.
10125
8c9afb46
EZ
101262011-11-27 Eli Zaretskii <eliz@gnu.org>
10127
10128 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
10129 (snprintf) [_MSC_VER]: Redirect to _snprintf.
10130 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
10131 (malloc, free, realloc, calloc): Redirect to e_* only when
10132 compiling Emacs.
10133
10134 * lisp.h (GCTYPEBITS): Move before first use.
10135 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
10136 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
10137 this macro definition.
10138
10139 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
10140 _MSC_VER.
10141
54e9e3bf
JD
101422011-11-27 Jan Djärv <jan.h.d@swipnet.se>
10143
6d5eb5b0
SM
10144 * gtkutil.c (xg_create_frame_widgets):
10145 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
10146 present with Gtk+ 2.0.
10147
83aca1cb
PE
101482011-11-26 Paul Eggert <eggert@cs.ucla.edu>
10149
10150 * fileio.c (Finsert_file_contents): Undo previous change; see
10151 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
10152
5b76caa4
PE
101532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
10154
10155 Rename locals to avoid shadowing.
10156 * fileio.c (Finsert_file_contents):
10157 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
10158 * process.c (wait_reading_process_output):
10159 Rename inner 'proc' to 'p' to avoid shadowing.
10160 Indent for consistency with usual Emacs style.
10161
8c535114
EZ
101622011-11-25 Eli Zaretskii <eliz@gnu.org>
10163
10164 * xdisp.c (redisplay_window): If cursor row is not fully visible
10165 after recentering, and scroll-conservatively is set to a large
10166 number, scroll window by a few more lines to make the cursor fully
10167 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
10168 (start_display): Don't move to the next line if the display should
10169 start at a newline that is part of a display vector or an overlay
10170 string. (Bug#10119)
8c535114 10171
fa4fdb5c
JL
101722011-11-24 Juri Linkov <juri@jurta.org>
10173
10174 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
10175 after the `MagickPingImage' call. (Bug#10112)
10176
90ec88df
CY
101772011-11-23 Chong Yidong <cyd@gnu.org>
10178
10179 * window.c (Fcoordinates_in_window_p): Accept only live windows.
10180
56e2e794
MR
101812011-11-23 Martin Rudalics <rudalics@gmx.at>
10182
10183 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
10184 making another buffer current. (Bug#10114)
10185
b6e64c41
GM
101862011-11-23 Glenn Morris <rgm@gnu.org>
10187
10188 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
10189
6b21de18
CY
101902011-11-23 Chong Yidong <cyd@gnu.org>
10191
10192 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
10193 using it (Bug#5984).
10194
b12cd789
EZ
101952011-11-22 Eli Zaretskii <eliz@gnu.org>
10196
10197 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
10198 and header-lines, as they don't have one computed for them.
10199 (Bug#10098)
10200
10201 * .gdbinit (prow): Make displayed values more self-explaining.
10202 Add row's hash code.
10203
261b6fd4
LMI
102042011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
10205
10206 * process.c (wait_reading_process_output): Fix asynchrounous
10207 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 10208 (wait_reading_process_output): Add comment and URL.
261b6fd4 10209
e7cfd277
JD
102102011-11-21 Jan Djärv <jan.h.d@swipnet.se>
10211
10212 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
10213
a9b9b7f5
CY
102142011-11-21 Chong Yidong <cyd@gnu.org>
10215
10216 * window.c (Fnext_window, Fprevious_window): Doc fix.
10217
b0d15b4f
SM
102182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10219
10220 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
10221
fe7a3057
JB
102222011-11-20 Juanma Barranquero <lekktu@gmail.com>
10223
10224 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
10225
d2999b1a
MR
102262011-11-20 Martin Rudalics <rudalics@gmx.at>
10227
10228 * window.c (Fset_window_combination_limit): Rename argument
10229 STATUS to LIMIT.
10230 (Vwindow_combination_limit): Remove "status" from doc-string.
10231
d5ff9cd0
AS
102322011-11-20 Andreas Schwab <schwab@linux-m68k.org>
10233
10234 * m/ibms390.h: Remove.
10235 * m/ibms390x.h: Don't include "ibms390.h".
10236
a5bb9bd3
SM
102372011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10238
10239 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
10240 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
10241
cd1181db
JB
102422011-11-20 Juanma Barranquero <lekktu@gmail.com>
10243
10244 * casetab.c (Fset_case_table):
10245 * charset.c (Fcharset_after): Fix typos.
10246
615a3b8d 102472011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 10248
17e845af
PE
10249 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
10250 Otherwise, valgrind does not work on some platforms.
10251 Problem reported by Andreas Schwab in
6a0bf43d
PE
10252 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
10253 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
10254 is set, removing the need for VIRT_ADDRESS_VARIES.
10255 (PURE_P): Use a more-efficient implementation that needs just one
10256 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
10257 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
10258 to 4 (xorl, subq, cmpq, setbe).
10259 * alloc.c (pure): Always extern now, since that's the
10260 VIRT_ADDR_VARIES behavior.
10261 (PURE_POINTER_P): Use a single comparison, not two, for
10262 consistency with the new puresize.h.
10263 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
10264 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
10265 Remove VIRT_ADDR_VARIES no longer needed.
10266
f8fe6f96
EZ
102672011-11-19 Eli Zaretskii <eliz@gnu.org>
10268
10269 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
10270 (erase_phys_cursor, update_window_cursor, show_mouse_face)
10271 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
10272 behave as if the cursor position were at the window margin.
10273
10274 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
10275 and the cursor position is out of bounds, behave as if the cursor
10276 position were at the window margin. (Bug#10075)
10277
df05a53c
CY
102782011-11-18 Chong Yidong <cyd@gnu.org>
10279
10280 * window.c (Fwindow_combination_limit): Make first argument
10281 non-optional, since it is meaningless for live windows like the
10282 selected window.
61ccba97 10283
2071918e
DA
102842011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
10285
10286 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
10287
b50a28de
SM
102882011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
10289
10290 * intervals.c: Fix grafting over the whole buffer (bug#10071).
10291 (graft_intervals_into_buffer): Simplify.
10292
015137db
EZ
102932011-11-18 Eli Zaretskii <eliz@gnu.org>
10294
10295 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
10296 hash values of the two rows.
10297 (copy_row_except_pointers): Preserve the used[] arrays and the
10298 hash values of the two rows. (Bug#10035)
68c95424 10299 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
10300
10301 * xdisp.c (row_hash): New function, body extracted from
10302 compute_line_metrics.
10303 (compute_line_metrics): Call row_hash, instead of computing the
10304 hash code inline.
10305
10306 * dispnew.c (verify_row_hash): Call row_hash for computing the
10307 hash code of a row, instead of duplicating code from xdisp.c.
10308
10309 * dispextern.h (row_hash): Add prototype.
10310
a2addb04
TH
103112011-11-18 Tassilo Horn <tassilo@member.fsf.org>
10312
10313 * frame.c (delete_frame): Don't delete the terminal when the last
10314 X frame is closed if emacs is built with GTK toolkit.
10315
df85d315
JB
103162011-11-17 Juanma Barranquero <lekktu@gmail.com>
10317
10318 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
10319
a0c2d0ae
MR
103202011-11-17 Martin Rudalics <rudalics@gmx.at>
10321
10322 * window.c (Vwindow_splits): Rename to
10323 Vwindow_combination_resize. Suggested by Juri Linkov.
10324 (Fsplit_window_internal): Use Vwindow_combination_resize instead
10325 of Vwindow_splits.
10326
58179cce
JB
103272011-11-16 Juanma Barranquero <lekktu@gmail.com>
10328
7877f373
JB
10329 * nsfns.m (Fns_font_name):
10330 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 10331
b6f67890
MR
103322011-11-16 Martin Rudalics <rudalics@gmx.at>
10333
10334 * window.h (window): Rename slot "nest" to "combination_limit".
10335 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
10336 (Fset_window_nest): Rename to Fset_window_combination_limit.
10337 (Vwindow_nest): Rename to Vwindow_combination_limit.
10338 (recombine_windows, make_parent_window, make_window)
10339 (Fsplit_window_internal, saved_window)
10340 (Fset_window_configuration, save_window_save): Rename all
10341 occurrences of window_nest to window_combination_limit.
10342
c7015153
JB
103432011-11-15 Juanma Barranquero <lekktu@gmail.com>
10344
10345 * image.c (imagemagick_load_image): Fix typo.
10346
322ad6ec
EZ
103472011-11-14 Eli Zaretskii <eliz@gnu.org>
10348
10349 * xdisp.c (display_line): Move the call to
10350 highlight_trailing_whitespace before the call to
10351 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
10352 faces of all the glyphs to compute ROW's hash value.
10353 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 10354
f067b8ec
JB
103552011-11-14 Juanma Barranquero <lekktu@gmail.com>
10356
10357 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
10358 just return (bug#10044).
10359
1e5b2111
EZ
103602011-11-12 Eli Zaretskii <eliz@gnu.org>
10361
7ef3cbd5
EZ
10362 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
10363 with user-defined heap size. Bump the default size of the temacs
10364 heap to 27MB, to avoid memory warning when running temacs.
10365 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
10366
1e5b2111
EZ
10367 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
10368 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
10369 (verify_row_hash) [XASSERTS]: New function.
10370 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
10371 that the hash value of glyph rows is correct.
1e5b2111 10372
89d61221
MR
103732011-11-12 Martin Rudalics <rudalics@gmx.at>
10374
10375 * window.h (window): Remove splits slot.
10376 * window.c (Fwindow_splits, Fset_window_splits): Remove.
10377 (Fdelete_other_windows_internal, make_parent_window)
10378 (make_window, Fsplit_window_internal, Fdelete_window_internal)
10379 (Fset_window_configuration, save_window_save): Don't deal with
10380 split status of windows.
10381 (saved_window): Remove splits slot.
10382 (Vwindow_splits): Rewrite doc-string.
10383
97f18cc8
JD
103842011-11-11 Jan Djärv <jan.h.d@swipnet.se>
10385
10386 * xfns.c (unwind_create_frame):
10387 * nsfns.m (unwind_create_frame):
10388 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
10389 Vframe_list (Bug#9999).
10390
22a648b4
DA
103912011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
10392
0b381c7e 10393 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 10394
659afede
KH
103952011-11-11 Kenichi Handa <handa@m17n.org>
10396
10397 * callproc.c (Fcall_process): Set the member dst_multibyte of
10398 process_coding.
10399
9ac0394b
KH
104002011-11-11 Johan Bockgård <bojohan@gnu.org>
10401
10402 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
10403 avoid a crash (bug#9496).
10404
2fbdc249
CY
104052011-11-09 Chong Yidong <cyd@gnu.org>
10406
10407 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
10408 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
10409
ac6b1f81
PE
104102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10411
10412 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
10413
09db192c
PE
104142011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10415
10416 Avoid some portability problems by eschewing 'extern inline' functions.
10417 The trivial performance wins aren't worth the portability hassles; see
10418 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
10419 et seq.
10420 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10421 (window_box_width, window_box_left, window_box_left_offset)
10422 (window_box_right, window_box_right_offset): Undo previous change,
10423 by removing the "extern"s.
10424 * intervals.c (adjust_intervals_for_insertion)
10425 (adjust_intervals_for_deletion): Undo previous change,
10426 making these static again.
10427 (offset_intervals, temp_set_point_both, temp_set_point)
10428 (copy_intervals_to_string): No longer inline.
10429 * xdisp.c (window_text_bottom_y, window_box_width)
10430 (window_box_height, window_box_left_offset)
10431 (window_box_right_offset, window_box_left, window_box_right)
10432 (window_box): No longer inline.
10433
105216ed
CY
104342011-11-08 Chong Yidong <cyd@gnu.org>
10435
10436 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
10437 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
10438 Signal an error if not a live window.
105216ed
CY
10439 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
10440 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
10441
ae9e237f
JB
104422011-11-07 Juanma Barranquero <lekktu@gmail.com>
10443
10444 * lisp.h (syms_of_abbrev): Remove declaration.
10445 Reported by CHENG Gao <chenggao@royau.me>.
10446
c7aa8333
EZ
104472011-11-07 Eli Zaretskii <eliz@gnu.org>
10448
10449 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
10450 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10451 of temacs in GUI mode.
10452
be7f5545
MR
104532011-11-07 Martin Rudalics <rudalics@gmx.at>
10454
10455 * window.h: Declare delete_all_child_windows instead of
10456 delete_all_subwindows.
10457 * window.c (Fwindow_nest, Fset_window_nest)
10458 (Fset_window_new_total, Fset_window_new_normal)
10459 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
10460 (delete_all_subwindows): Rename to delete_all_child_windows.
10461 (Fdelete_other_windows_internal, Fset_window_configuration):
10462 Call delete_all_child_windows instead of delete_all_subwindows.
10463 * frame.c (delete_frame): Call delete_all_child_windows instead
10464 of delete_all_subwindows.
10465
ca78dc43
PE
104662011-11-07 Paul Eggert <eggert@cs.ucla.edu>
10467
10468 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
10469 This is also needed for porting to any host where GC_MARK_STACK is
10470 not GC_MAKE_GCPROS_NOOPS.
10471 (which_symbols): Use it.
10472
a0241d01
KH
104732011-11-07 Kenichi Handa <handa@m17n.org>
10474
10475 * coding.c (coding_set_destination): Check coding->src_pos only
10476 when coding->src_object is a buffer (bug#9910).
10477
10478 * process.c (send_process): Set the member src_multibyte of coding
10479 to 0 (bug#9911) when sending a unibyte text.
10480
10481 * callproc.c (Fcall_process): Set the member src_multibyte of
10482 process_coding to 0 (bug#9912).
10483
a64bfdfa 104842011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
10485
10486 * xmenu.c (cleanup_widget_value_tree): New function.
10487 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
10488 calling free_menubar_widget_value_tree directly (Bug#9830).
10489
cb41b32a
PE
104902011-11-06 Paul Eggert <eggert@cs.ucla.edu>
10491
10492 Fix some portability problems with 'inline'.
10493 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10494 (window_box_width, window_box_left, window_box_left_offset)
10495 (window_box_right, window_box_right_offset): Declare extern.
10496 Otherwise, these inline functions do not conform to C99 and
10497 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
10498 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
10499 * intervals.c (adjust_intervals_for_insertion)
10500 (adjust_intervals_for_deletion): Now extern, because otherwise the
10501 extern inline functions 'offset_intervals' couldn't refer to it.
10502 (static_offset_intervals): Remove.
10503 (offset_intervals): Rewrite using the old contents of
10504 static_offset_intervals. The old version didn't conform to C99
10505 because an extern inline function contained a reference to an
10506 identifier with static linkage.
10507
b7041366
AS
105082011-11-06 Andreas Schwab <schwab@linux-m68k.org>
10509
10510 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
10511 GC.
10512
88a37c4d
EZ
105132011-11-06 Eli Zaretskii <eliz@gnu.org>
10514
10515 * xdisp.c (init_iterator, reseat_to_string): Don't set the
10516 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
10517 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
10518 return Qleft_to_right.
10519
49745b39
CY
105202011-11-06 Chong Yidong <cyd@gnu.org>
10521
10522 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
10523 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
10524 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
10525 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
10526 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
10527 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
10528 (Fwindow_vscroll): Doc fix.
10529 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
10530 argument, since it makes no sense to pass a live window and for
10531 consistency with window-child.
10532
1f05cd82
CS
105332011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
10534
10535 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
10536 support MSVC.
10537
22610910
JR
105382011-11-05 Jason Rumney <jasonr@gnu.org>
10539
10540 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
10541 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10542 fonts (Bug#6029).
10543 (add_font_entity_to_list): Fix logic errors in mixed boolean and
10544 bitwise arithmetic preventing use of unicode-sip and non-truetype
10545 opentype fonts.
10546
a06776b2
EZ
105472011-11-05 Eli Zaretskii <eliz@gnu.org>
10548
3ad924ba
EZ
10549 * s/ms-w32.h (fstat, stat, utime): Move redirections to
10550 "emacs"-only part.
10551
a06776b2
EZ
10552 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
10553 initialization code to keep similarity to xfns.c after changes
10554 from 2011-11-05.
10555
c9e7db78
JD
105562011-11-05 Jan Djärv <jan.h.d@swipnet.se>
10557
a97f8f3f
JD
10558 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
10559 (unwind_create_frame): New function (Bug#9943).
10560 (Fx_create_frame): Restructure code to be more similar to the one in
10561 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
10562 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
10563 Move terminal->reference_count++ just before making the frame official
10564 (Bug#9943).
10565
10566 * nsterm.m (x_free_frame_resources): New function.
10567 (x_destroy_window): Move code to x_free_frame_resources.
10568
c9e7db78 10569 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
10570 (Fx_create_frame, x_create_tip_frame):
10571 Move terminal->reference_count++ just before making the frame
75f1671a 10572 official. Move initialization of image_cache_refcount and
c9e7db78
JD
10573 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
10574
a6fc3b5c
EZ
105752011-11-05 Eli Zaretskii <eliz@gnu.org>
10576
10577 Support MSVC build with newer versions of Visual Studio.
10578 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
10579 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
10580 nt/gmake.defs.
10581
10582 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
10583 which are not supported by MSVC.
10584 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
10585 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
10586 bitfields.
10587 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
10588 types in bitfields.
10589 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
10590
10591 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
10592
58179cce 105932011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
10594
10595 Support MSVC build with newer versions of Visual Studio.
10596 * w32.c: Don't include w32api.h for MSVC.
10597 (init_environment) [_MSC_VER]: Call sys_access, not _access.
10598
10599 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
10600 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
10601 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
10602 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
10603 e_* cousins.
10604 (alloca) [_MSC_VER]: Define to _alloca.
10605
10606 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
10607
10608 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
10609
a58c13ed
EZ
106102011-11-04 Eli Zaretskii <eliz@gnu.org>
10611
10612 * xdisp.c (note_mouse_highlight): If either of
10613 previous/next-single-property-change returns nil, treat that as
10614 the beginning or the end of the buffer. (Bug#9955)
10615
fe0b6370
JD
106162011-11-04 Jan Djärv <jan.h.d@swipnet.se>
10617
a58c13ed 10618 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
10619 label is not null (Bug#9951).
10620 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
10621 may be NULL.
10622
89bd5ee1
EZ
106232011-11-04 Eli Zaretskii <eliz@gnu.org>
10624
10625 * window.c (Fwindow_body_size): Mention in the doc string that the
10626 return value is in frame's canonical units. (Bug#9949)
10627
84c3edb9
EZ
106282011-11-03 Eli Zaretskii <eliz@gnu.org>
10629
4e2fb5c7
EZ
10630 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
10631
84c3edb9 10632 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 10633 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 10634 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 10635
bc17a887
EZ
106362011-11-01 Eli Zaretskii <eliz@gnu.org>
10637
10638 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
10639 Don't stop backward scan on the continuation glyph, even though
10640 its CHARPOS is positive.
6d5eb5b0
SM
10641 (mouse_face_from_buffer_pos, note_mouse_highlight):
10642 Rename cover_string to disp_string.
bc17a887 10643
4ee88440
MR
106442011-11-01 Martin Rudalics <rudalics@gmx.at>
10645
10646 * window.c (temp_output_buffer_show): Don't use
10647 Vtemp_buffer_show_specifiers.
10648 (Vtemp_buffer_show_specifiers): Remove unused variable.
10649
c2ff3c02
EZ
106502011-10-30 Eli Zaretskii <eliz@gnu.org>
10651
10652 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10653 past the beginning of the current glyph matrix.
10654
58179cce 106552011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
10656
10657 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
10658 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10659 HAVE_GTK3 (Bug#9869).
b77a6a7f 10660
3b574623
JD
10661 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
10662 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
10663
b77a6a7f
JD
10664 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
10665
10666 * xterm.c: Declare x_handle_net_wm_state to return int.
10667 (handle_one_xevent): Check if we are iconified but don't have
10668 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
10669 (get_current_wm_state): Return non-zero if not hidden,
10670 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10671 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
10672 (x_handle_net_wm_state): Return what get_current_wm_state returns.
10673 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
10674
196e41e4
PE
106752011-10-29 Paul Eggert <eggert@cs.ucla.edu>
10676
10677 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
10678 so that this new function doesn't get optimized away by a
10679 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
10680
021f2e1a
AS
106812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10682
10683 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10684
8b058d44
EZ
106852011-10-29 Eli Zaretskii <eliz@gnu.org>
10686
10687 Fix the `xbytecode' command.
10688 * .gdbinit (xprintbytestr): New command.
b50a28de 10689 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
10690 (xbytecode): Print the byte-code string as well.
10691
4452fb80
EZ
106922011-10-29 Kim Storm <storm@cua.dk>
10693
8b058d44
EZ
10694 * alloc.c (which_symbols): New function.
10695
21b72067
AS
106962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10697
10698 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
10699 line. (Bug#9903)
10700
83ed7b5c
GM
107012011-10-29 Glenn Morris <rgm@gnu.org>
10702
10703 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
10704 Not clear what it was for, and it causes various bugs. (Bug#9839)
10705
5a7a728b
EZ
107062011-10-28 Eli Zaretskii <eliz@gnu.org>
10707
10708 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
10709 possible random value that matches one of those tested as
10710 condition to clear the mouse face.
10711
d3d0842f
CY
107122011-10-28 Chong Yidong <cyd@gnu.org>
10713
10714 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10715
31b39d13
DN
107162011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
10717
10718 * window.c (make_window): Initialize phys_cursor_on_p.
10719
9aba6043
SM
107202011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
10721
10722 * lisp.h (struct Lisp_Symbol): Update comments.
10723
c20992f4
JB
107242011-10-28 Juanma Barranquero <lekktu@gmail.com>
10725
10726 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
10727
db4f02f2
EZ
107282011-10-28 Eli Zaretskii <eliz@gnu.org>
10729
10730 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
10731 <oslsachem@gmail.com> for helping to debug this.
10732
10733 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
10734 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
10735 (g_b_init_get_glyph_outline_w): New static variables.
10736 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
10737 (GetGlyphOutlineW_Proc): New typedefs.
10738 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
10739 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
10740 New functions.
10741 (w32font_open_internal, compute_metrics):
10742 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
10743 instead of calling the "wide" APIs directly.
10744
10745 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
10746
10747 * w32.h (syms_of_w32font): Add prototype.
10748
87e68db4
JB
107492011-10-27 Juanma Barranquero <lekktu@gmail.com>
10750
10751 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10752 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10753 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10754 (Fmove_to_window_line): Doc fix.
10755
435c1d67
CY
107562011-10-27 Chong Yidong <cyd@gnu.org>
10757
10758 * process.c (make_process): Set gnutls_state to NULL.
10759
10760 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10761 non-NULL, regardless of GNUTLS_INITSTAGE.
10762 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10763 an error. Set process slots as soon as we allocate them.
10764
10765 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10766
9c6c6f49
CY
107672011-10-27 Chong Yidong <cyd@gnu.org>
10768
9aba6043
SM
10769 * gnutls.c (emacs_gnutls_deinit): New function.
10770 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10771 (Fgnutls_deinit, Fgnutls_boot): Use it.
10772
10773 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10774 (deactivate_process): Call emacs_gnutls_deinit.
10775
657d08d3
JB
107762011-10-27 Juanma Barranquero <lekktu@gmail.com>
10777
10778 * image.c (x_create_x_image_and_pixmap):
10779 * w32.c (sys_rename, w32_delayed_load):
10780 * w32font.c (fill_in_logfont):
10781 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10782
5430d399
JB
107832011-10-26 Juanma Barranquero <lekktu@gmail.com>
10784
10785 * w32fns.c (w32_default_color_map): New function,
10786 extracted from Fw32_default_color_map.
a7ef684b 10787 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10788
fe0055fa
PE
107892011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10790
10791 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10792
e6346438
SM
107932011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10794
10795 * keyboard.c (test_undefined): New function (bug#9751).
10796 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10797
e112cc37
ET
107982011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10799
10800 * sysdep.c (init_sys_modes): Fix the check for the controlling
10801 terminal (Bug#6649).
10802
7b5d6677
EZ
108032011-10-20 Eli Zaretskii <eliz@gnu.org>
10804
10805 * dispextern.h (struct bidi_it): New member next_en_type.
10806
10807 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10808 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10809 current character, check also for next_en_type being WEAK_EN.
10810 (bidi_resolve_weak): Don't enter the expensive loop if the current
10811 position is before next_en_pos. Record the bidi type of the first
10812 non-ET, non-BN character we find, in addition to its position.
10813 (bidi_level_of_next_char): Invalidate next_en_type when
10814 next_en_pos is over-stepped.
10815
7da0b018
PE
108162011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10817
10818 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10819 * editfns.c: Rewrite current-time-zone so that it invokes
10820 the equivalent of (format-time-string "%Z") to get the time zone name.
10821 This fixes a bug when the time zone name contains characters that
10822 need converting from the system time locale to Emacs internal format.
10823 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10824 that patch fixed format-time-string to do the conversion, but
10825 I forgot to fix current-time-zone.
10826 (format_time_string): New function, containing most of
10827 what Fformat_time_string used to contain.
10828 (Fformat_time_string): Rewrite in terms of format_time_string.
10829 This doesn't change this function's behavior.
10830 (current-time-zone): Rewrite to use format_time_string.
10831 This fixes the bug reported by Michael Schierl in
10832 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10833 Jason Rumney's 2007-06-07 change worked around this bug, but
10834 didn't fix it.
10835 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10836
8547b010
EZ
108372011-10-19 Eli Zaretskii <eliz@gnu.org>
10838
10839 * xdisp.c (start_display): If the character at POS is displayed
10840 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10841 (try_window_reusing_current_matrix): If a line ends in a display
10842 vector or the next line starts in a display vector, continue
10843 redrawing the window even though the character position of
10844 start_row was reached.
8547b010
EZ
10845 (Bug#9771, part 2)
10846
4e948d15
CY
108472011-10-18 Chong Yidong <cyd@gnu.org>
10848
10849 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10850 with nobreak-char-display too.
10851
4787455f
EZ
108522011-10-18 Eli Zaretskii <eliz@gnu.org>
10853
10854 Fix part 3 of bug#9771.
10855 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10856 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10857 non-neutral characters if the current character is a paragraph
10858 separator (a.k.a. Newline). This avoids running the same
10859 expensive loop twice, once when we consume the preceding newline
10860 and the other time when the line actually needs to be displayed.
10861 Avoid the loop when we see neutrals on the base embedding level
10862 following a character whose directionality is the same as the
10863 paragraph's. This avoids running the expensive loop when a line
10864 ends in a long sequence of neutrals, like control characters.
10865 Add assertion against STRONG_AL type. Slightly rearrange code
10866 that determines the type of a neutral given the first non-neutral
10867 that follows it.
10868 (bidi_level_of_next_char): Set next_en_pos to zero when
10869 invalidating its info.
10870
2c91f553
EZ
108712011-10-17 Eli Zaretskii <eliz@gnu.org>
10872
10873 * xdisp.c (push_display_prop): Determine whether to record string
10874 or buffer position by IT->string, not by IT->method. Allow
10875 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10876 (move_it_vertically_backward): Don't look for character position
10877 immediately after the newline when in a continuation line.
10878 (Bug#9771, part 1)
2c91f553 10879
c7b08b0d
MR
108802011-10-15 Martin Rudalics <rudalics@gmx.at>
10881
10882 * window.c (coordinates_in_window): Rewrite and delabelize
10883 vertical border check. (Bug#5357) (Bug#9618)
10884
6b02f655
SM
108852011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10886
10887 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10888 errors in XSetWindowBorder (bug#9310).
10889
81d40c92
DA
108902011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10891
10892 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10893 avoid crash when xmalloc overrun checking is enabled.
10894
d4172c3b
EZ
108952011-10-13 Eli Zaretskii <eliz@gnu.org>
10896
10897 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10898 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10899 cursor motion with <left> and <right> arrow keys.
10900
10901 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10902 some callers set that themselves.
10903
b00eea75
EZ
109042011-10-12 Eli Zaretskii <eliz@gnu.org>
10905
10906 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10907 display string and the previous row comes from the same string and
10908 is empty. (Bug#9739) (Bug#9738)
10909
8fe012c4
SM
109102011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10911
10912 * doc.c (get_doc_string): Encode file name (bug#9735).
10913
0074aef2
EZ
109142011-10-12 Eli Zaretskii <eliz@gnu.org>
10915
79beb178
EZ
10916 * bidi.c (bidi_level_of_next_char):
10917 * xdisp.c (get_visually_first_element): Remove old incorrect
10918 comments regarding the Unicode Line Separator character.
10919
0074aef2
EZ
10920 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10921
6e4b3fbe
DA
109222011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10923
10924 * alloc.c (Fgc_status): Do not access beyond zombies array
10925 boundary if nzombies > MAX_ZOMBIES.
10926 * alloc.c (dump_zombies): Add missing format specifier.
10927
0324f3af
PE
109282011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10929
b5525cac
PE
10930 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10931 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10932
0324f3af
PE
10933 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10934 Some packages use them to denote characters with modifiers.
10935
e9b5f888
AS
109362011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10937
10938 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10939 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10940 matching a pp-number. Rename parameter var to var1.
10941
127827c0
SM
109422011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10943
10944 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10945
c8fd3bd0
GM
109462011-10-08 Glenn Morris <rgm@gnu.org>
10947
10948 * callint.c (Fcall_interactively): Give a more explicit error for the
10949 'c' case with a non-character input. (Bug#8479)
10950
352ec8ff
EZ
109512011-10-08 Eli Zaretskii <eliz@gnu.org>
10952
03669ccb
EZ
10953 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10954 lines.
7061c986
EZ
10955 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10956 lines that are hscrolled on the left.
03669ccb 10957
352ec8ff
EZ
10958 * dispnew.c (buffer_posn_from_coords): Account for a possible
10959 presence of header-line. (Bug#4426)
10960
a66cfb1c
SM
109612011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10962
6b02f655
SM
10963 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10964 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10965
7c5ee88e
PE
109662011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10967
10968 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10969 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10970 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10971 this makes Emacs dump core during garbage collection on rare
10972 occasions. sizeof is obviously inferior to offsetof here, so
10973 stick with offsetof.
10974 (GC_POINTER_ALIGNMENT): New macro.
10975 (mark_memory): Omit 3rd (offset) arg; caller changed.
10976 Don't assume EMACS_INT alignment is the same as pointer alignment.
10977
df1bbe5b
SM
109782011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10979
10980 * keyboard.c (read_key_sequence_remapped): New var.
10981 (read_key_sequence): Compute remapping in the right buffer.
10982 (command_loop_1): Use read_key_sequence's remapping directly.
10983
51553db6
SM
109842011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10985
32c1fffd
SM
10986 * dired.c (file_name_completion): Don't expand file name.
10987 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10988 before checking file name handler.
10989
51553db6
SM
10990 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10991 they've been requested explicitly (bug#9591).
10992
b6bd1599 109932011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10994
10995 * keymap.c (Fsingle_key_description): Use make_specified_string
10996 instead of build_string to build string from push_key_description.
10997 (Bug#5193)
10998
f701dc2a
PE
109992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
11000
4222c55d
PE
11001 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
11002 This fixes a Y2038 bug on 64-bit hosts.
11003 * buffer.c (reset_buffer):
11004 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
11005 (Fclear_buffer_auto_save_failure):
11006 Use 0, not -1, to represent an unset failure time, since time_t
11007 might not be signed.
11008
f701dc2a
PE
11009 Remove dependency on glibc malloc internals.
11010 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11011 Move back here from lisp.h, but with their new implementations.
11012 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11013 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
11014 * charset.c (charset_table_init): New static var.
11015 (syms_of_charset): Use it instead of xmalloc. This removes a
11016 dependency on glibc malloc internals. See Eli Zaretskii's comment in
11017 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
11018 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11019 Move back to alloc.c.
11020 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11021 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
11022
9ceebf39
JD
110232011-09-30 Jan Djärv <jan.h.d@swipnet.se>
11024
11025 * nsterm.m (windowDidResize): Call x_set_window_size only when
11026 ns_in_resize is true. Otherwise set pixelwidth/height and
11027 call change_frame_size (Bug#9628).
11028
cb993c58
PE
110292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
11030
3930c88b
PE
11031 Port --enable-checking=all to Fedora 14 x86-64.
11032 * charset.c (syms_of_charset): Also account for glibc malloc's
11033 internal overhead when calculating the initial malloc maximum.
11034
cb993c58
PE
11035 Port --enable-checking=all to Fedora 14 x86.
11036 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11037 Move to lisp.h.
11038 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
11039 (overrun_check_realloc, overrun_check_free):
11040 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
11041 That way, xmalloc returns a properly-aligned pointer even if
11042 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
11043 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
11044 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
11045 into account when calculating the initial malloc maximum.
11046 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11047 Move here from alloc.c, so that charset.c can use it too.
11048 Properly align; the old code wasn't right for common 32-bit hosts
11049 when configured with --enable-checking=all.
11050 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11051 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
11052
31bed486
EZ
110532011-09-29 Eli Zaretskii <eliz@gnu.org>
11054
04c70788 11055 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
11056 use EDOM.
11057
fbcaa2f3
EZ
110582011-09-28 Eli Zaretskii <eliz@gnu.org>
11059
11060 * xdisp.c (compute_display_string_end): If there's no display
11061 string at CHARPOS, return -1.
11062
11063 * bidi.c (bidi_fetch_char): When compute_display_string_end
11064 returns a negative value, treat the character as a normal
11065 character not covered by a display string. (Bug#9624)
11066
a239d4e9
JB
110672011-09-28 Juanma Barranquero <lekktu@gmail.com>
11068
11069 * lread.c (Fread_from_string): Fix typo in docstring.
11070
88652fd5
EZ
110712011-09-27 Eli Zaretskii <eliz@gnu.org>
11072
11073 * xdisp.c (handle_invisible_prop): If invisible text ends on a
11074 newline, reseat the iterator instead of bidi-iterating there one
11075 character at a time. (Bug#9610)
32c1fffd
SM
11076 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
11077 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 11078
ed497dd4
AS
110792011-09-27 Andreas Schwab <schwab@linux-m68k.org>
11080
11081 * lread.c (readevalloop): Use correct code for NBSP.
11082 (read1): Likewise. (Bug#9608)
11083
b2bf61aa
MA
110842011-09-25 Michael Albinus <michael.albinus@gmx.de>
11085
11086 * dbusbind.c (Fdbus_register_signal): When service is not
11087 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
11088
32bbb17c
GM
110892011-09-25 Glenn Morris <rgm@gnu.org>
11090
11091 * buffer.c (truncate-lines): Doc fix.
11092
94e0933e
CY
110932011-09-24 Chong Yidong <cyd@stupidchicken.com>
11094
11095 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
11096 (Fset_window_next_buffers): Doc fix.
11097
cddde921
GM
110982011-09-24 Glenn Morris <rgm@gnu.org>
11099
11100 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
11101
1260aef1
PE
111022011-09-24 Paul Eggert <eggert@cs.ucla.edu>
11103
25b4bfa0
PE
11104 Fix minor problems found by static checking.
11105 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
11106 * indent.c (Fvertical_motion): Fix == vs = typo.
11107
e3cbd34b
EZ
111082011-09-24 Eli Zaretskii <eliz@gnu.org>
11109
a66cfb1c
SM
11110 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
11111 Default value is now t. Doc fix.
6bf7006f 11112
e3cbd34b 11113 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 11114 logic when moving up, not only when moving down. Fix the
e3cbd34b 11115 confusing name and values of the it_overshoot_expected variable;
32c1fffd 11116 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
11117
11118 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
11119 CHARPOS is covered by a display string which includes newlines.
11120 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
11121 is covered by a display string with embedded newlines.
11122
a3de0cbd
MA
111232011-09-24 Michael Albinus <michael.albinus@gmx.de>
11124
11125 * dbusbind.c (Fdbus_register_signal): Add match rule to
11126 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
11127 (Fdbus_register_method, Vdbus_registered_objects_table):
11128 Fix docstring.
a3de0cbd 11129
b260039d
JM
111302011-09-24 Jim Meyering <meyering@redhat.com>
11131
32c1fffd 11132 do not ignore write error for any output size
b260039d
JM
11133 The previous change was incomplete.
11134 While it makes emacs --batch detect the vast majority of stdout
11135 write failures, errors were still ignored whenever the output size is
11136 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
11137 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
11138 && echo FAIL: ignored write error
11139 FAIL: ignored write error
11140 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
11141 && echo FAIL: ignored write error
11142 FAIL: ignored write error
11143 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
11144
8eca8a7c
AS
111452011-09-23 Andreas Schwab <schwab@linux-m68k.org>
11146
11147 * emacs.c (Fkill_emacs): In noninteractive mode exit
11148 non-successfully if a write error occurred on stdout. (Bug#9574)
11149
3341db62
EZ
111502011-09-21 Eli Zaretskii <eliz@gnu.org>
11151
11152 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
11153 the xassert test.
11154
11155 * dispextern.h (struct it): Update the comment documenting what
11156 can it->OBJECT be.
11157
8c203dbf
EZ
111582011-09-20 Eli Zaretskii <eliz@gnu.org>
11159
11160 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
11161 a display string, extend search for cursor position to end of row.
11162 (find_row_edges): If the row ends in a newline from a display
11163 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
11164 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
11165 (Fcurrent_bidi_paragraph_direction): Fix search for previous
11166 non-empty line. Fixes confusing cursor motion with arrow keys at
11167 the beginning of a line that starts with whitespace.
8c203dbf 11168
a4824228
LMI
111692011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11170
11171 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
11172 (bug#9493).
11173
33ed493b
CY
111742011-09-18 Chong Yidong <cyd@stupidchicken.com>
11175
11176 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
11177 boolean (Bug#9154).
11178
56cd55c8
EZ
111792011-09-18 Eli Zaretskii <eliz@gnu.org>
11180
11181 * xdisp.c (display_line): Record maximum and minimum buffer
11182 positions even if no glyphs were produced (e.g., by a zero-width
11183 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
11184 buffer positions that will be removed from the glyph row because
11185 they don't fit.
c02dcedf
EZ
11186 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
11187 column is beyond frame width: don't subtract 1 "pixel" when
11188 computing width of the stretch.
3e62b7e0
EZ
11189 (reseat_at_next_visible_line_start): Undo the change made on
11190 2011-09-17 that saved paragraph information and restored it after
11191 the call to `reseat'. (Bug#9545)
56cd55c8 11192
5ed99d36 111932011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
11194
11195 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
11196 and turn window cursor on if cleared (Bug#9415).
11197
5ed99d36 111982011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
11199
11200 * search.c (boyer_moore): Take unibyte characters from pattern
11201 literally. (Bug#9458)
11202
9bade7b2
EZ
112032011-09-18 Eli Zaretskii <eliz@gnu.org>
11204
11205 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
11206
e5e9d610
PE
112072011-09-18 Paul Eggert <eggert@cs.ucla.edu>
11208
87e4427a
PE
11209 Fix minor problem found by static checking.
11210 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
11211 initialized, to pacify gcc -Wuninitialized.
11212
e5e9d610
PE
11213 * fileio.c: Report proper errno when syscall falls.
11214 (Finsert_file_contents): Save and restore errno,
11215 so that report_file_error outputs the correct diagnostic.
11216 (Fwrite_region) [CLASH_DETECTION]: Likewise.
11217
a1674f0b
EZ
112182011-09-18 Eli Zaretskii <eliz@gnu.org>
11219
11220 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
11221
fbfb6dd4
EZ
112222011-09-17 Eli Zaretskii <eliz@gnu.org>
11223
11224 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
11225 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
11226
bb187662
EZ
112272011-09-17 Eli Zaretskii <eliz@gnu.org>
11228
1137e8b8 11229 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 11230 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
11231
11232 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
11233 (bidi_find_paragraph_start): Search back for paragraph beginning
11234 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
11235 (bidi_move_to_visually_next): Only trigger paragraph-related
11236 computations when the last character is a newline or at EOB, not
11237 just any NEUTRAL_B. (Bug#9470)
11238
bb187662
EZ
11239 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
11240 truncated lines if point is covered by a display string. (Bug#9524)
11241
2e621251
PE
112422011-09-16 Paul Eggert <eggert@cs.ucla.edu>
11243
11244 * xselect.c: Relax test for outgoing X longs (Bug#9498).
11245 (cons_to_x_long): New function.
11246 (lisp_data_to_selection_data): Use it. Correct the test for
11247 short-versus-long data; it was negated. Break out of vector
11248 loop, for efficiency, when a long datum is discovered.
11249
91a15bc6
SM
112502011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
11251
11252 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
11253
b41c3a35
EZ
112542011-09-16 Eli Zaretskii <eliz@gnu.org>
11255
11256 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
11257 GCC PR/17406) by declaring this function with external scope.
11258
7812ba2d
PE
112592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11260
11261 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
11262 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
11263
cf7edc2a
AS
112642011-09-15 Andreas Schwab <schwab@linux-m68k.org>
11265
11266 * editfns.c (Fformat): Correctly handle text properties on "%%".
11267
bd01620e
EZ
112682011-09-15 Eli Zaretskii <eliz@gnu.org>
11269
11270 * xterm.c (x_draw_composite_glyph_string_foreground):
11271 * w32term.c (x_draw_composite_glyph_string_foreground):
11272 * term.c (encode_terminal_code):
11273 * composite.c (composition_update_it, get_composition_id):
11274 * xdisp.c (get_next_display_element)
11275 (fill_composite_glyph_string): Add comments about special meaning
11276 of TAB characters in a composition.
11277
a02719a3
PE
112782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11279
11280 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
11281 This occurs when processing a multibyte format.
11282 Problem reported by Wolfgang Jenker.
a02719a3 11283
72589a3c
JB
112842011-09-15 Johan Bockgård <bojohan@gnu.org>
11285
11286 * xdisp.c (try_cursor_movement): Only check for exact match if
11287 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
11288
1c14176c
PE
112892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11290
11291 Remove unused external symbols.
11292 * dispextern.h (calc_pixel_width_or_height): Remove decl.
11293 * xdisp.c (calc_pixel_width_or_height): Now static.
11294 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
11295 * indent.c (check_display_width):
11296 * w32term.c: Fix comment to match code.
11297 * xterm.c, xterm.h (x_catching_errors): Remove.
11298
d2eea5b5
PE
112992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11300
11301 * xselect.c: Use signed conversions more consistently (Bug#9498).
11302 (selection_data_to_lisp_data): Assume incoming selection data are
11303 signed integers, not unsigned. This is to be consistent with
11304 outgoing selection data, which was modified to use signed integers
11305 in as part of the fix to Bug#9196 in response to Jan D.'s comment
11306 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
11307 expects long, not unsigned long.
11308
46888499
EZ
113092011-09-14 Eli Zaretskii <eliz@gnu.org>
11310
11311 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
11312 computation of loop end. Reported by Johan Bockgård
11313 <bojohan@gnu.org>.
11314
ef8ef9fb
CY
113152011-09-13 Chong Yidong <cyd@stupidchicken.com>
11316
11317 * frame.c (Fother_visible_frames_p): Function deleted.
11318
fa819fed
EZ
113192011-09-12 Eli Zaretskii <eliz@gnu.org>
11320
11321 * indent.c (compute_motion): Process display vector front to back
11322 rather than the other way around. (Bug#2496)
11323
2ba8e008
SM
113242011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
11325
11326 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
11327
20f53c69
CY
113282011-09-11 Chong Yidong <cyd@stupidchicken.com>
11329
11330 * minibuf.c (Fread_from_minibuffer): Doc fix.
11331
d562d7a4
EZ
113322011-09-11 Eli Zaretskii <eliz@gnu.org>
11333
11334 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
11335 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
11336
1c4d7f3d
LMI
113372011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11338
11339 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
11340 value for non-existent files.
11341
b885bf36
EZ
113422011-09-11 Eli Zaretskii <eliz@gnu.org>
11343
11344 * fileio.c (Finsert_file_contents): If the file cannot be opened,
11345 set its "size" to -1. This will set the modtime_size field of
11346 the corresponding buffer to -1, which is what
11347 verify-visited-file-modtime expects for files that do not exist.
11348 (Bug#9139)
11349
6612f0bf
PE
113502011-09-11 Paul Eggert <eggert@cs.ucla.edu>
11351
11352 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
11353 here ...
11354 * lisp.h: ... from here. push_key_description is no longer
11355 defined in keyboard.c, so its declaration should not be in
11356 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
11357 logically belongs with push_key_description.
11358
dfb3f755
PE
113592011-09-10 Paul Eggert <eggert@cs.ucla.edu>
11360
11361 * buffer.h: Include <sys/types.h> instead of <time.h>.
11362 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
11363 Problem reported by Herbert J. Skuhra.
11364
3134906c
LMI
113652011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
11366
11367 * xml.c (parse_region): Make the parsing work for
11368 non-comment-starting XML files again (bug#9144).
11369
8d903f4e
AS
113702011-09-10 Andreas Schwab <schwab@linux-m68k.org>
11371
11372 * image.c (gif_load): Fix calculation of bottom and right corner.
11373 (Bug#9468)
11374
80ad64f4
EZ
113752011-09-10 Eli Zaretskii <eliz@gnu.org>
11376
11377 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
11378 redisplay in small windows.
11379
208a048d
EZ
113802011-09-09 Eli Zaretskii <eliz@gnu.org>
11381
11382 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
11383
9b1c252e
MR
113842011-09-08 Martin Rudalics <rudalics@gmx.at>
11385
11386 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
11387 Operate on live windows only.
11388
2949f33b
JB
113892011-09-08 Juanma Barranquero <lekktu@gmail.com>
11390
11391 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
11392
e08dcafd
EZ
113932011-09-07 Eli Zaretskii <eliz@gnu.org>
11394
11395 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
11396 only under bidi iteration.
11397
115b96bd
JD
113982011-09-07 Jan Djärv <jan.h.d@swipnet.se>
11399
11400 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
11401
c8199d0f
PE
114022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
11403
11404 isnan: Fix porting problem to Solaris 10 with bundled gcc.
11405 Without this fix, the command to link temacs failed due to an
11406 undefined symbol __builtin_isnan. This is because
11407 /usr/include/iso/math_c99.h #defines isnan(x) to
11408 __builtin_isnan(x), but the bundled gcc, which identifies itself
11409 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
11410 a __builtin_isnan.
11411 * floatfns.c (isnan): #undef, and then #define to a clone of
11412 what's in data.c.
11413 (Fisnan): Always define, since it's always available now.
11414 (syms_of_floatfns): Always define isnan at the Lisp level.
11415
e39b275c 114162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
11417
11418 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
11419
b2db44d9 114202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 11421
f4af5137 11422 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
11423 The previous code assumed that file offsets (off_t values) fit in
11424 EMACS_INT variables, which is not true on typical 32-bit hosts.
11425 The code messed up by falsely reporting buffer overflow in cases
11426 such as (insert-file-contents "big" nil 1 2) into an empty buffer
11427 when "big" contains more than 2**29 bytes, even though this
11428 inserts just one byte and does not overflow the buffer.
11429 (Finsert_file_contents): Store file offsets as off_t
11430 values, not as EMACS_INT values. Check for overflow when
11431 converting between EMACS_INT and off_t. When checking for
11432 buffer overflow or for overlap, take the offsets into account.
11433 Don't use EMACS_INT for small values where int suffices.
11434 When checking for overlap, fix a typo: ZV was used where
11435 ZV_BYTE was intended.
11436 (Fwrite_region): Don't assume off_t fits into 'long'.
11437 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
11438
ecfc0a49
MA
114392011-09-05 Michael Albinus <michael.albinus@gmx.de>
11440
11441 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
11442
6511acf2 114432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 11444
0999621a 11445 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
11446
11447 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 11448 (esprintf, exprintf, evxprintf): New functions.
62f19c19 11449 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 11450 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
11451 (modify_event_symbol): Do not assume that the length of
11452 name_alist_or_stem is safe to alloca and fits in int.
11453 (Fexecute_extended_command): Likewise for function name and binding.
11454 (Frecursion_depth): Wrap around reliably on integer overflow.
11455 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
11456 since some callers pass EMACS_INT values.
11457 (Fsingle_key_description): Don't crash if symbol name contains more
11458 than MAX_ALLOCA bytes.
11459 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
11460 (get_minibuffer): Arg is now EMACS_INT, not int.
11461 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 11462 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
11463 * window.h (command_loop_level, minibuf_level): Reflect API changes.
11464
2be7d702
PE
11465 * dbusbind.c (signature_cat): New function.
11466 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
11467 Do not overrun buffer; instead, report string overflow.
11468
9d1df220
PE
11469 * dispnew.c (add_window_display_history): Don't overrun buffer.
11470 Truncate instead; this is OK since it's just a log.
11471
33ef5c64
PE
11472 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
11473 even if the time zone offset is outlandishly large.
11474 Don't mishandle offset == INT_MIN.
11475
66c6fdd5
PE
11476 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
11477 when creating daemon; the previous buffer-overflow check was incorrect.
11478
d749b01b
PE
11479 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
11480 which has the guts of the old verror function.
11481
b5cd1905
PE
11482 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
11483 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
11484
6e1a67fb
PE
11485 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
11486 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 11487 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 11488 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
11489 length of string rather than counting it via multiple sprintfs;
11490 that's simpler and more reliable.
c21721cc
PE
11491 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
11492 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
11493 sprintf, in case result does not fit in int.
11494
c57b67fc
PE
11495 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
11496 (fontset_from_font): Print it.
11497
8a401434
PE
11498 * frame.c (tty_frame_count): Now printmax_t, not int.
11499 (make_terminal_frame, set_term_frame_name): Print it.
11500 (x_report_frame_params): In X, window IDs are unsigned long,
11501 not signed long, so print them as unsigned.
11502 (validate_x_resource_name): Check for implausibly long names,
11503 and don't assume name length fits in 'int'.
11504 (x_get_resource_string): Don't blindly alloca invocation name;
11505 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
11506 not fit in int.
11507
6e1a67fb
PE
11508 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
11509 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
11510 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
11511
0df02bf3
PE
11512 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
11513 Use esprintf, not sprintf, in case result does not fit in int.
11514
48e30793
PE
11515 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11516 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
11517 it as a large positive number.
11518 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
11519 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11520
a66ff6d8
PE
11521 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
11522 in case result does not fit in int.
11523
aca216ff
PE
11524 * print.c (float_to_string): Detect width overflow more reliably.
11525 (print_object): Make sprintf buffer a bit bigger, to avoid potential
11526 buffer overrun. Don't assume list length fits in 'int'. Treat
11527 print length of 0 as 0, not as infinity; to be consistent with other
11528 uses of print length in this function. Don't overflow print length
11529 index. Don't assume hash table size fits in 'long', or that
11530 vectorlike size fits in 'unsigned long'.
11531
31c286f7
PE
11532 * process.c (make_process): Use printmax_t, not int, to format
11533 process-name gensyms.
11534
55e5faa1
PE
11535 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
11536
80f2e268
PE
11537 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
11538 to avoid potential buffer overrun.
11539
670741ab
PE
11540 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
11541 if X resource line is longer than 512 bytes.
11542
b7163a50
PE
11543 * xfns.c (x_window): Make sprintf buffer a bit bigger
11544 to avoid potential buffer overrun.
11545
ae58ff1f
PE
11546 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
11547
c43c8a6a
PE
11548 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
11549
3f8236f4
PE
115502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
11551
53e9fe90 11552 Integer overflow fixes for scrolling, etc.
6511acf2
PE
11553 Without these, Emacs silently mishandles large integers sometimes.
11554 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
11555 it were "C-u 1 M-x recenter" on a typical 64-bit host.
11556
6511acf2
PE
11557 * xdisp.c (try_window_id): Check Emacs fixnum range before
11558 converting to 'int'.
806add1d 11559
6511acf2 11560 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
11561 Check that an Emacs fixnum is in range before assigning it to 'int'.
11562 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
11563 values converted from Emacs fixnums.
11564 (Frecenter): Don't wrap around a line count if it is out of 'int'
11565 range; instead, treat it as an extreme value.
11566 (Fset_window_configuration, compare_window_configurations):
11567 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
11568
6511acf2
PE
11569 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
11570 that can exceed INT_MAX. Check that EMACS_INT value is in range
11571 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
11572 (match_limit): Don't assume that a fixnum can fit in 'int'.
11573
6511acf2 11574 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
11575 exceed INT_MAX.
11576
6511acf2 11577 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
11578 (Fvertical_motion): Don't wrap around LINES values that don't fit
11579 in 'int'. Instead, treat them as extreme values. This is good
11580 enough for windows, which can't have more than INT_MAX lines anyway.
11581
fcb901a7
LMI
115822011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11583
0f2f6b6d
LMI
11584 * Require libxml/parser.h to avoid compilation warning.
11585
fcb901a7
LMI
11586 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
11587
11588 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
11589 since this reportedly can destroy thread storage.
11590
6e20a0d4
CY
115912011-08-30 Chong Yidong <cyd@stupidchicken.com>
11592
11593 * syntax.c (find_defun_start): Update all cache variables if
11594 exiting early (Bug#9401).
11595
148ae00e
EZ
115962011-08-30 Eli Zaretskii <eliz@gnu.org>
11597
f6cfbd8f
EZ
11598 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
11599
148ae00e
EZ
11600 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11601 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
11602 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
11603
11604 * term.c (tty_append_glyph): New function.
11605 (produce_stretch_glyph): Static function and its prototype deleted.
11606
a66cfb1c
SM
11607 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
11608 Add prototypes.
148ae00e 11609
c4a07a4c
PE
116102011-08-29 Paul Eggert <eggert@cs.ucla.edu>
11611
11612 * image.c (parse_image_spec): Check for nonnegative, not for positive,
11613 when checking :margin (Bug#9390).
11614 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 11615 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
11616 so that the name doesn't mislead. All uses changed.
11617
6bc8cd65
JB
116182011-08-28 Johan Bockgård <bojohan@gnu.org>
11619
11620 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
11621 set_tty_hooks.
11622
dca4927e
EZ
116232011-08-27 Eli Zaretskii <eliz@gnu.org>
11624
11625 * xdisp.c (move_it_to): Don't bail out early when reaching
11626 position beyond to_charpos, if we are scanning backwards.
11627 (move_it_vertically_backward): When DY == 0, make sure we get to
11628 the first character in the line after the newline.
11629
f2cad773
PE
116302011-08-27 Paul Eggert <eggert@cs.ucla.edu>
11631
11632 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11633 (ccl_driver): Do not generate an out-of-range pointer.
11634 (Fccl_execute_on_string): Remove unnecessary check for
11635 integer overflow, noted by Stefan Monnier in
11636 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
11637 Remove a FIXME that didn't need fixing.
11638 Simplify the newly-introduced buffer reallocation code.
11639
0cae2cdb
JB
116402011-08-27 Juanma Barranquero <lekktu@gmail.com>
11641
11642 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
11643
5fc295a4 116442011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 11645
70c60eb2 11646 Integer and memory overflow issues (Bug#9196).
726e0ab1 11647
d31850da
PE
11648 * doc.c (get_doc_string): Rework so that
11649 get_doc_string_buffer_size is the actual buffer size, rather than
11650 being 1 less than the actual buffer size; this makes xpalloc more
11651 convenient.
11652
a69fbedb
PE
11653 * image.c (x_allocate_bitmap_record, cache_image):
11654 * xselect.c (Fx_register_dnd_atom):
11655 Simplify previous changes by using xpalloc.
11656
fe5c5d37
PE
11657 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
11658 since either will do and ptrdiff_t is convenient with xpalloc.
11659
0065d054
PE
11660 * charset.c (charset_table_size)
11661 (struct charset_sort_data.priority): Now ptrdiff_t.
11662 (charset_compare): Don't overflow if priorities differ greatly.
11663 (Fsort_charsets): Don't assume list length fits in int.
11664 Check for size-calculation overflow when allocating sort data.
11665 (syms_of_charset): Allocate an initial charset table that is
11666 just under 64 KiB, to avoid problems with glibc malloc and mmap.
11667
11668 * cmds.c (internal_self_insert): Check for size-calculation overflow.
11669
11670 * composite.h (struct composition.glyph_len): Now int, not unsigned.
11671 The actual value is always <= INT_MAX, and leaving it unsigned made
11672 overflow checking harder.
11673
11674 * dispextern.h (struct glyph_matrix.rows_allocated)
11675 (struct face_cache.size): Now ptrdiff_t, for convenience in use
11676 with xpalloc. The values are still always <= INT_MAX.
11677
11678 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
11679
11680 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
11681 (SAFE_NALLOCA): New macro.
11682
11683 * region-cache.c (struct boundary.pos, find_cache_boundary)
11684 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
11685 (set_cache_region, invalidate_region_cache)
11686 (revalidate_region_cache, know_region_cache, region_cache_forward)
11687 (region_cache_backward, pp_cache):
11688 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
11689 so that ptrdiff_t * can be passed to xpalloc.
11690 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
11691 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
11692 (pp_cache): Don't assume cache_len fits in int.
11693 * region-cache.h: Adjust extern decls to match.
11694
11695 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
11696 EMACS_INT, since either will do, for xpalloc.
11697
11698 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
11699 (xnmalloc, xnrealloc, xpalloc): New functions.
11700
726e0ab1
PE
11701 * bidi.c (bidi_shelve_header_size): New constant.
11702 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11703 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
11704
51f30bc5 11705 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
11706 * buffer.c (overlays_at, overlays_in, record_overlay_string)
11707 (overlay_strings):
11708 Don't update size of array until after memory allocation succeeds,
11709 because xmalloc/xrealloc may not return.
0065d054
PE
11710 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
11711 now that we have proper integer overflow checking.
11712 (record_overlay_string, overlay_strings): Catch overflows when
11713 calculating size of overlay_str_buf.
726e0ab1 11714
0065d054
PE
11715 * callproc.c (Fcall_process): Check for size overflow when
11716 calculating size of args2.
11717 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
11718 Normally we prefer signed values, but sticking with ptrdiff_t would
11719 require adding more-complicated checks.
726e0ab1
PE
11720
11721 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
11722 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
11723 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 11724 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
11725
11726 * character.c (Fstring): Check for size-calculation overflow.
11727
11728 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
11729 unnecessary integer overflow. Check for size overflow.
11730 (encode_coding_object): Don't update size until xmalloc succeeds.
11731
11732 * composite.c (get_composition_id): Check for overflow in glyph
11733 length calculations.
11734
11735 Integer and memory overflow fixes for display code.
11736 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
11737 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
11738 (scrolling_window): Check for overflow in size calculations.
11739 (line_draw_cost, realloc_glyph_pool, add_row_entry):
11740 Don't assume glyph table len fits in int.
11741 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
11742 (row_table_size): Now ptrdiff_t, not int.
11743 (scrolling_window): Avoid overflow in size calculations.
11744 Don't update size until allocation succeeds.
11745 * fns.c (concat): Check for overflow in size calculations.
11746 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
11747 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11748 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11749
11750 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11751 (get_doc_string): Check for size calculation overflow.
11752 Don't update size until allocation succeeds.
11753 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11754 EMACS_INT, where ptrdiff_t will do.
11755 (Fsubstitute_command_keys): Check for string overflow.
11756
11757 * editfns.c (set_time_zone_rule): Don't assume environment length
11758 fits in int.
11759 (message_length): Now ptrdiff_t, not int.
11760 (Fmessage_box): Don't update size until allocation succeeds.
11761 Don't assume message length fits in int.
11762 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11763
0065d054
PE
11764 * emacs.c (main): Do not reallocate argv, since there is a null at
11765 the end that can be overwritten, and this way there's no need to
11766 worry about size-calculation overflow.
11767 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11768
11769 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11770 alloc succeeds.
11771 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11772
11773 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11774 (x_set_scroll_bar_width, x_figure_window_size):
11775 Check for integer overflow.
11776 (x_set_alpha): Do not assume XINT fits in int.
11777
11778 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11779 This is for the members text_lines, text_cols, total_lines, total_cols,
11780 where the system imposes an 'int' limit.
11781
11782 * fringe.c (Fdefine_fringe_bitmap):
11783 Don't update size until alloc works.
11784
11785 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11786 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11787
11788 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11789 Check for size-calculation overflow.
11790 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11791 do, as we prefer signed integers.
11792 (id_to_widget.max_size, id_to_widget.used)
11793 (xg_store_widget_in_map, xg_remove_widget_from_map)
11794 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11795 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11796 Use and return ptrdiff_t, not int.
11797 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11798 * gtkutil.h: Change prototypes to match the above.
11799
11800 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11801 are duplicate now that they've been promoted to lisp.h.
11802 (x_allocate_bitmap_record, x_alloc_image_color)
11803 (make_image_cache, cache_image, xpm_load):
11804 Don't update size until alloc is done.
11805 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11806 (x_detect_edges):
3256efce 11807 Check for size calculation overflow.
726e0ab1
PE
11808 (ct_colors_allocated_max): New constant.
11809 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11810 overflow.
3256efce 11811
726e0ab1
PE
11812 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11813 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11814 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11815 Use ptrdiff_t, not int, to count maps.
11816 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11817 calculations. Don't update size until allocation succeeds.
11818 Redo calculations to avoid overflow.
726e0ab1
PE
11819 * keyboard.h: Change prototypes to match the above.
11820
11821 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11822 to count maps.
11823 (current_minor_maps): Check for size calculation overflow.
11824 * keymap.h: Change prototypes to match the above.
11825
11826 * lread.c (read1, init_obarray): Don't update size until alloc done.
11827
11828 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11829 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11830
726e0ab1
PE
11831 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11832 Now ptrdiff_t, not int.
11833 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11834 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11835
11836 * process.c (Fnetwork_interface_list): Check for overflow
11837 in size calculation.
11838
11839 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11840
11841 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11842 overflow. Don't bother calling xmalloc when xrealloc will do.
11843
11844 * search.c (Freplace_match): Check for size calculation overflow.
11845 (Fset_match_data): Don't assume list lengths fit in 'int'.
11846
11847 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11848 for command line length. Do not attempt to address one before the
11849 beginning of an array, as that's not portable.
11850
11851 * term.c (max_frame_lines): Remove; unused.
11852 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11853 not int.
11854 (encode_terminal_code, calculate_costs): Check for size
11855 calculation overflow.
11856 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11857 table lengths and related sizes. Don't update size until alloc
11858 done. Redo calculations to avoid overflow.
11859 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11860
11861 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11862 subtracting pointers.
11863 (gobble_line): Check for overflow more carefully. Don't update size
11864 until alloc done.
11865
11866 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11867 Don't update size until alloc done.
11868 Redo size calculations to avoid overflow.
11869 Check for size calculation overflow.
0065d054 11870 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11871
11872 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11873 Use ptrdiff_t, not int, for sizes.
11874 (store_mode_line_noprop_char): Don't update size until alloc done.
11875
0065d054
PE
11876 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11877 Use ptrdiff_t, not int, for sizes.
11878 (Finternal_make_lisp_face, cache_face):
11879 Check for size calculation overflow.
11880 (cache_face): Treat size calculation overflows as if they were
11881 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11882
11883 * xfns.c (x_encode_text, x_set_name_internal)
11884 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11885 sizes, since they can exceed INT_MAX in size. Check for size
11886 calculation overflow.
11887
0065d054
PE
11888 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11889 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11890 Don't update size until alloc done.
11891
0065d054 11892 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11893 as sprintf is limited to int lengths.
1d526e2f 11894
252c5ee1
PE
11895 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11896 (X_LONG_MIN): New macros.
864d7ce7
PE
11897 Use them to make the following changes clearer.
11898 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11899 This change doesn't affect the value now, but it may help remind
11900 future maintainers not to raise the value too much later.
11901 (SELECTION_QUANTUM): Remove, replacing with ...
11902 (selection_quantum): ... new function, which avoids overflow.
11903 All uses changed.
11904 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11905 assumption that selection length fits in 'int'.
11906 (x_reply_selection_request, x_handle_selection_request)
11907 (x_get_window_property, receive_incremental_selection)
11908 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11909 (lisp_data_to_selection_data, clean_local_selection_data):
11910 Use ptrdiff_t, not int, to record length of selection.
11911 (x_reply_selection_request, x_get_window_property)
11912 (receive_incremental_selection, x_property_data_to_lisp):
11913 Redo calculations to avoid overflow.
11914 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11915 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11916 something.
11917 (x_get_window_property, receive_incremental_selection)
11918 (lisp_data_to_selection_data, x_property_data_to_lisp):
11919 Check for size-calculation overflow.
11920 (x_get_window_property, receive_incremental_selection)
11921 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11922 Don't store size until memory allocation succeeds.
11923 (x_get_window_property): Plug memory leak on memory exhaustion.
11924 Don't double-block input; malloc is safe here. Don't assume 2**34
11925 - 4 fits in unsigned long. Add an xassert to check
11926 XGetWindowProperty overflow. Be more careful about overflow
11927 calculations, and distinguish size from memory overflow better.
11928 (receive_incremental_selection): When tracing, don't assume
11929 unsigned int is less than INT_MAX.
11930 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11931 harmful) conversions of unsigned short to int.
11932 (lisp_data_to_selection_data): Don't assume that integers
11933 in the range -65535 through -1 fit in an X unsigned short.
11934 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11935 result parameters unless successful. Rely on cons_to_unsigned
11936 to report problems with elements; the old code wasn't right anyway.
11937 (x_check_property_data): Check for int overflow; we cannot use
11938 a wider type due to X limits.
11939 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11940
726e0ab1 11941 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11942
0065d054
PE
11943 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11944 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11945 (x_color_cells): Don't store size until memory allocation succeeds.
11946 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11947 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11948 (x_term_init): Don't assume length fits in int (sprintf is limited
11949 to int size).
bc18e09d 11950
ebfa62c0
PE
11951 Use ptrdiff_t for composition IDs.
11952 * character.c (lisp_string_width):
11953 * composite.c (composition_table_size, n_compositions)
11954 (get_composition_id, composition_gstring_from_id):
11955 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11956 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11957 * window.c (Frecenter):
11958 Use ptrdiff_t, not int, for composition IDs.
11959 * composite.c (get_composition_id): Check for integer overflow.
11960 * composite.h: Adjust prototypes to match the above changes.
11961
d3411f89
PE
11962 Use ptrdiff_t for hash table indexes.
11963 * category.c (hash_get_category_set):
11964 * ccl.c (ccl_driver):
11965 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11966 * coding.c (coding_system_charset_list, detect_coding_system):
11967 * coding.h (struct coding_system.id):
11968 * composite.c (get_composition_id, gstring_lookup_cache):
11969 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11970 * image.c (xpm_get_color_table_h):
11971 * lisp.h (hash_lookup, hash_put):
11972 * minibuf.c (Ftest_completion):
11973 Use ptrdiff_t for hash table indexes, not int (which is too
11974 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11975 32-bit --with-wide-int hosts).
11976
e097a6fa
PE
11977 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11978 Add a FIXME comment about memory leaks.
11979 (syms_of_charset): Don't assume xmalloc returns.
11980
5637687f
PE
11981 Don't assume that stated character widths fit in int.
11982 * character.c (Fchar_width, c_string_width, lisp_string_width):
11983 * character.h (CHAR_WIDTH):
11984 * indent.c (MULTIBYTE_BYTES_WIDTH):
11985 Use sanitize_char_width to avoid undefined and/or bad behavior
11986 with outlandish widths.
a66cfb1c 11987 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11988 now that we have two such functions. All uses changed.
11989 (sanitize_char_width): New inline function.
11990
a2271ba2
PE
11991 Don't assume that tab-width fits in int.
11992 * character.h (sanitize_width): New inline function.
11993 (SANE_TAB_WIDTH): New macro.
11994 (ASCII_CHAR_WIDTH): Use it.
11995 * indent.c (sane_tab_width): Remove. All uses replaced by
11996 SANE_TAB_WIDTH (current_buffer).
11997 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11998
18c52557
PE
11999 * fileio.c: Integer overflow issues with file modes.
12000 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
12001
caeeedc1
PE
12002 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
12003 Remove unreachable code.
12004 (read_hex, load_charset_map_from_file): Check for integer overflow.
12005
6df6ae42 12006 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
12007 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
12008 (x_send_scroll_bar_event): Likewise. Check that the size does not
12009 exceed limits imposed by XClientMessageEvent, as well as the usual
12010 ptrdiff_t and size_t limits.
12011
b13995db
PE
12012 * keyboard.c: Overflow, signedness and related fixes.
12013 (make_lispy_movement): Use same integer type in forward decl
12014 that is used in the definition.
12015 (read_key_sequence, keyremap_step):
12016 Change bufsize argument back to int, undoing my 2011-03-30 change.
12017 We prefer signed types, and int is wide enough here.
12018 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
12019 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
12020 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
12021 length, not size_t. Use ptrdiff_t for index, not int.
12022 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
12023 possibility of integer overflow.
12024
13464394
PE
12025 Overflow, signedness and related fixes for images.
12026
12027 * dispextern.h (struct it.stack[0].u.image.image_id)
12028 (struct_it.image_id, struct image.id, struct image_cache.size)
12029 (struct image_cache.used, struct image_cache.ref_count):
12030 * gtkutil.c (update_frame_tool_bar):
12031 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
12032 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
12033 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
12034 * nsmenu.m (update_frame_tool_bar):
12035 * xdisp.c (calc_pixel_width_or_height):
12036 * xfns.c (image_cache_refcount):
12037 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
12038 on typical 64-bit hosts.
12039
12040 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
12041 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
12042 Omit unnecessary casts to int.
12043 (parse_image_spec): Check that integers fall into 'int' range
12044 when the callers expect that.
12045 (image_ascent): Redo ascent calculation to avoid int overflow.
12046 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
12047 (lookup_image): Remove unnecessary tests.
12048 (xbm_image_p): Locals are now of int, not EMACS_INT,
12049 since parse_image_check makes sure they fit into int.
12050 (png_load, gif_load, svg_load_image):
12051 Prefer int to unsigned where either will do.
12052 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
12053 old tiff_error_handler and tiff_warning_handler.
12054 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
12055 stack buffer overflows. It uses only the features of vsnprintf
12056 that are common to both POSIX and native Microsoft.
12057 (tiff_error_handler, tiff_warning_handler): Use it.
12058 (tiff_load, gif_load, imagemagick_load_image):
12059 Don't assume :index value fits in 'int'.
12060 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
12061 (imagemagick_load_image): Check that crop parameters fit into
12062 the integer types that MagickCropImage accepts. Don't assume
12063 Vimagemagick_render_type has a nonnegative value. Don't assume
12064 size_t fits in 'long'.
12065 (gs_load): Use printmax_t to print the widest integers possible.
12066 Check for integer overflow when computing image height and width.
12067
c11821d4
EZ
120682011-08-26 Eli Zaretskii <eliz@gnu.org>
12069
12070 * xdisp.c (redisplay_window): Don't force window start if point
12071 will be invisible in the resulting window. (Bug#9324)
12072
0c95fcf7
EZ
120732011-08-25 Eli Zaretskii <eliz@gnu.org>
12074
12075 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
12076 the display spec is of the form `(space ...)'.
12077 (handle_display_spec): Return the value returned by
12078 handle_single_display_spec, not just 1 or zero.
12079 (handle_single_display_spec): If the display spec is of the form
12080 `(space ...)', and specifies display in the text area, return 2
12081 rather than 1.
fee65a97 12082 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
12083 accurately, and prefer exact match for point under bidi.
12084 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
12085
12086 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
12087 into disp_prop; all users changed.
12088
12089 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
12090 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
12091 for the text covered by the display property.
12092
e4ed06f1
CY
120932011-08-25 Chong Yidong <cyd@stupidchicken.com>
12094
12095 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
12096 Change return value to nil.
12097 (Frecord_buffer): Delete unused function.
12098
f67cdd7f
EZ
120992011-08-24 Eli Zaretskii <eliz@gnu.org>
12100
5980d4c6
EZ
12101 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
12102 buffers, return left-to-right.
8610fe8b
EZ
12103 (set_cursor_from_row): Consider candidate row a win if its glyph
12104 represents a newline and point is on that newline. Fixes cursor
12105 positioning on the newline at EOL of R2L text within L2R
12106 paragraph, and vice versa.
12107 (try_cursor_movement): Check continued rows, in addition to
12108 continuation rows. Fixes unwarranted scroll when point enters a
12109 continued line of R2L text within an L2R paragraph, or vice versa.
12110 (cursor_row_p): Consider the case of point being equal to
12111 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
12112 from the end of a short line to the beginning of a continued line
12113 of R2L text within L2R paragraph.
12114 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
12115 composed characters.
5980d4c6 12116
f67cdd7f
EZ
12117 * bidi.c (bidi_check_type): Use xassert.
12118 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
12119 members.
12120
bca633fb
EZ
121212011-08-23 Eli Zaretskii <eliz@gnu.org>
12122
12123 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
12124 a character.
12125
4a5885a7
CY
121262011-08-23 Chong Yidong <cyd@stupidchicken.com>
12127
12128 * nsfont.m (ns_otf_to_script): Fix typo.
12129
0902a04e
KH
121302011-08-22 Kenichi Handa <handa@m17n.org>
12131
12132 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
12133 extra slot even if the purpose is char-code-property-table.
12134
1a2e6670
EZ
121352011-08-23 Eli Zaretskii <eliz@gnu.org>
12136
8ddde651
EZ
12137 * xdisp.c (redisplay_window): When computing centering_position,
12138 account for the height of the header line. (Bug#8874)
12139
425cc014
EZ
12140 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
12141 instead of CHAR_TO_BYTE. Fixes a crash when a completion
12142 candidate is selected by the mouse, and that candidate has a
12143 composed character under the mouse.
12144
1a2e6670
EZ
12145 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
12146 coordinates reported by pos-visible-in-window-p for a composed
12147 character in column zero.
12148
8b76d6f8
SM
121492011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
12150
12151 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
12152
dac347dd
EZ
121532011-08-22 Eli Zaretskii <eliz@gnu.org>
12154
12155 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
12156 consider it a hit if to_charpos is anywhere in the range of the
12157 composed buffer positions.
12158
e013fb34
CY
121592011-08-22 Chong Yidong <cyd@stupidchicken.com>
12160
12161 * image.c (gif_load): Don't assume that each subimage has the same
12162 dimensions as the base image. Handle disposal method that is
12163 "undefined" by the gif spec (Bug#9335).
12164
bd1ba3e8
CY
121652011-08-20 Chong Yidong <cyd@stupidchicken.com>
12166
12167 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 12168 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 12169
54a1215b
EZ
121702011-08-19 Eli Zaretskii <eliz@gnu.org>
12171
823564e5
EZ
12172 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
12173 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
12174 from an Org mode buffer to a Speedbar frame.
12175
54a1215b
EZ
12176 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
12177 a composition, take its buffer position from IT->cmp_it.charpos.
12178 Fixes cursor positioning at the beginning of a line that begins
12179 with a composed character.
12180
9778ebcc
EZ
121812011-08-18 Eli Zaretskii <eliz@gnu.org>
12182
0be6ee06
EZ
12183 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
12184 character bidirectional type, use STRONG_L instead. Fixes crashes
12185 in a buffer produced by `describe-categories'.
12186
9778ebcc
EZ
12187 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
12188 members before the level stack, so they would be saved and
12189 restored when copying iterator state. Fixes incorrect reordering
12190 around TABs covered by display properties.
12191
156bffbe
AS
121922011-08-18 Andreas Schwab <schwab@linux-m68k.org>
12193
6b02f655 12194 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 12195
72ad093b
CY
121962011-08-17 Chong Yidong <cyd@stupidchicken.com>
12197
12198 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
12199 (internal_condition_case_2, internal_condition_case_n):
12200 Remove unnecessary aborts (Bug#9081).
72ad093b 12201
35774242
EZ
122022011-08-17 Eli Zaretskii <eliz@gnu.org>
12203
12204 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
12205 has no `load' handler, try opening the file locally. (Bug#9311)
12206
db76dd85
KB
122072011-08-16 Ken Brown <kbrown@cornell.edu>
12208
12209 * gmalloc.c: Expand comment.
12210
b215eee5
EZ
122112011-08-16 Eli Zaretskii <eliz@gnu.org>
12212
12213 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
12214 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
12215
a4579d33
KB
122162011-08-16 Ken Brown <kbrown@cornell.edu>
12217
12218 Fix memory allocation problems in Cygwin build (Bug#9273).
12219
12220 * unexcw.c ( __malloc_initialized): Declare external variable.
12221 (fixup_executable): Force the dumped emacs to reinitialize malloc.
12222
8b76d6f8
SM
12223 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
12224 New variables.
a4579d33
KB
12225 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
12226 dumped emacs.
12227 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
12228 in the static heap.
12229 [CYGWIN] (special_realloc): New function.
12230 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
12231 requests to realloc storage in the static heap.
12232
3ebec551
PE
122332011-08-15 Paul Eggert <eggert@cs.ucla.edu>
12234
12235 * bidi.c (bidi_initialize): Remove unused local.
12236
9fd8be00
EZ
122372011-08-15 Eli Zaretskii <eliz@gnu.org>
12238
6b02f655
SM
12239 * bidimirror.h:
12240 * biditype.h: Remove file.
12241 * makefile.w32-in ($(BLD)/bidi.$(O)):
12242 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
12243
12244 * dispextern.h: Fix a typo in the comment to bidi_type_t.
12245
12246 * chartab.c: Improve commentary for the uniprop_table API.
12247
32413314
EZ
12248 * bidi.c (bidi_paragraph_init): Support zero value of
12249 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
12250 (bidi_initialize): Use uniprop_table instead of including
12251 biditype.h and bidimirror.h.
32413314 12252
9fd8be00
EZ
12253 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
12254 coordinates of the iterator when restoring from ppos_it.
12255 (Bug#9296)
12256
5cf2b69b
KH
122572011-08-14 Kenichi Handa <handa@m17n.org>
12258
12259 * process.c (create_process): Call setup_process_coding_systems
72ad093b 12260 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 12261
daf17d00
EZ
122622011-08-14 Eli Zaretskii <eliz@gnu.org>
12263
12264 * xdisp.c (move_it_in_display_line_to): Don't invoke
12265 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
12266 ppos_it. Fixes vertical cursor motion when line beginning is
12267 covered by an image. (Bug#9296)
12268
08e3161a
JD
122692011-08-14 Jan Djärv <jan.h.d@swipnet.se>
12270
12271 * nsterm.h (ns_run_ascript): Declare.
12272 (NSAPP_DATA2_RUNASSCRIPT): Define.
12273
12274 * nsfns.m (as_script, as_result, as_status): New static variables.
12275 (ns_run_ascript): New function.
5e617bc2 12276 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
12277 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
12278 the event loop. Get status from as_status (Bug#7276).
12279
12280 * nsterm.m (sendEvent): If event is NSApplicationDefined and
12281 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
12282 the event loop (Bug#7276).
12283
a3720aa2
AS
122842011-08-14 Andreas Schwab <schwab@linux-m68k.org>
12285
12286 * gnutls.c (QCgnutls_bootprop_priority)
12287 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
12288 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
12289 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
12290 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
12291 (QCgnutls_bootprop_verify_hostname_error)
12292 (QCgnutls_bootprop_callbacks_verify): Rename from
12293 Qgnutls_bootprop_..., all uses changed.
12294
12295 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
12296 uses changed.
12297
0a0d27fb
PE
122982011-08-14 Paul Eggert <eggert@cs.ucla.edu>
12299
19d5c50c
PE
12300 * xfaces.c (Qframe_set_background_mode): Now static.
12301 * dispextern.h (Qframe_set_background_mode): Remove decl.
12302
0a0d27fb
PE
12303 * process.c (Fnetwork_interface_info): Declare local only if needed.
12304
377538cb
JD
123052011-08-13 Jan Djärv <jan.h.d@swipnet.se>
12306
12307 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
12308 (Fnetwork_interface_list): Allocate in increments of bytes instead
12309 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
12310 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
12311 sockaddr.
12312 (struct ifflag_def): notrailers is smart on OSX.
12313 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
12314 Get hardware address with getifaddrs if available.
12315
08fff70c
EZ
123162011-08-12 Eli Zaretskii <eliz@gnu.org>
12317
12318 * xdisp.c (iterate_out_of_display_property): xassert that
12319 IT->position is set to within IT->object's boundaries. Break from
12320 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
12321 when IT->position is set up wrongly due to some bug.
12322 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
12323 (push_display_prop): Allow GET_FROM_STRING as IT->method on
12324 entry. Force push_it to save on the stack the current
12325 buffer/string position, to be restored by pop_it. Fix flags in
12326 the iterator structure wrt the object coming from a display
12327 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
12328 properties. (Bug#9284)
12329
7be1c708 123302011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 12331
7be1c708
CY
12332 * fontset.c (fontset_get_font_group): Add proper type checks.
12333 (Bug#9172)
aac0c6e3 12334
7be1c708 123352011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 12336
7be1c708
CY
12337 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
12338 and LC_VERSION_MIN_MACOSX.
12339 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
12340 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 12341
97bb72a6
EZ
123422011-08-08 Eli Zaretskii <eliz@gnu.org>
12343
12344 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
12345 no-display-properties-and-no-overlays under bidi display.
12346 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 12347 properties and overlays.
97bb72a6 12348
d5617611
CY
123492011-08-08 Chong Yidong <cyd@stupidchicken.com>
12350
37e11a63
CY
12351 * editfns.c (Fset_time_zone_rule): Document relationship with the
12352 setenv function.
12353
d5617611
CY
12354 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
12355 the font entity extracted from the cache (Bug#8109).
12356
58872834
CY
123572011-08-07 Chong Yidong <cyd@stupidchicken.com>
12358
12359 * composite.c (autocmp_chars): Don't reset point. That is done by
12360 restore_point_unwind (Bug#5984).
12361
75bfc667
JL
123622011-08-07 Juri Linkov <juri@jurta.org>
12363
12364 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
12365 to show the arg `TIME' instead of `TIMEVAL'.
12366
d1410150
EZ
123672011-08-06 Eli Zaretskii <eliz@gnu.org>
12368
12369 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
12370 display property strides EOL and includes a newline, as in
12371 longlines-mode. (Bug#9254)
75b771e4
EZ
12372 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
12373 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
12374
12375 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
12376 is non-zero, even if the data buffer is NULL. Fixes a crash in
12377 vertical-motion with longlines-mode. (Bug#9254)
12378
35928349
EZ
123792011-08-05 Eli Zaretskii <eliz@gnu.org>
12380
ec7cc85b
EZ
12381 * bidi.c <bidi_cache_total_alloc>: Now static.
12382 (bidi_initialize): Initialize bidi_cache_total_alloc.
12383
8b76d6f8 12384 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
12385 cache. (Bug#9221)
12386
12387 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
12388 amount allocated this far in `bidi_cache_total_alloc'.
12389 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
12390 non-zero, only free the data buffer without restoring the cache
12391 contents. All callers changed.
12392
12393 * dispextern.h (bidi_unshelve_cache): Update prototype.
12394
12395 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
12396 (move_it_in_display_line, move_it_to)
12397 (move_it_vertically_backward, move_it_by_lines): Replace the call
12398 to xfree to an equivalent call to bidi_unshelve_cache.
12399 (move_it_in_display_line_to): Fix logic of returning
412b6358 12400 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 12401
e2e2423b
EZ
124022011-08-05 Eli Zaretskii <eliz@gnu.org>
12403
12404 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
12405 came from a string character with a `cursor' property. (Bug#9229)
12406
ae9e757a
JD
124072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12408
12409 * Makefile.in (LIB_PTHREAD): New variable.
12410 (LIBES): Add LIB_PTHREAD (Bug#9216).
12411
12412 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
12413 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
12414
213bd7f2
AS
124152011-08-04 Andreas Schwab <schwab@linux-m68k.org>
12416
6b02f655 12417 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 12418
99aaf75f
JD
124192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12420
12421 * xterm.c (x_find_topmost_parent): New function.
12422 (x_set_frame_alpha): Find topmost parent window with
12423 x_find_topmost_parent and set the property there also (bug#9181).
12424 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
12425
c74e9d86
PE
124262011-08-04 Paul Eggert <eggert@cs.ucla.edu>
12427
12428 * callproc.c (Fcall_process): Avoid vfork clobbering
12429 the local vars buffer, coding_systems, current_dir.
12430
640c8776
SM
124312011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
12432
12433 * keymap.c (Fmake_composed_keymap): Move to subr.el.
12434
f26d0e4c
PE
124352011-08-03 Paul Eggert <eggert@cs.ucla.edu>
12436
8a10d76c
PE
12437 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
12438 so that it is not optimized away.
12439
f26d0e4c
PE
12440 * xdisp.c (compute_display_string_pos): Remove unused local.
12441
55439c61
EZ
124422011-08-02 Eli Zaretskii <eliz@gnu.org>
12443
12444 Fix slow cursor motion and scrolling in large buffers with
12445 selective display, like Org Mode buffers. (Bug#9218)
12446
12447 * dispextern.h (struct bidi_it): New member disp_prop_p.
12448
12449 * xdisp.c: Remove one-slot cache of display string positions.
12450 (compute_display_string_pos): Accept an additional argument
5e617bc2 12451 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
12452 for a display string or property. If found, set DISP_PROP_P
12453 non-zero.
12454
12455 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
12456 DISP_PROP_P, and pass it to compute_display_string_pos.
12457 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
12458 non-zero. All callers of bidi_fetch_char changed.
12459
fb33fa43
SM
124602011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
12461
12462 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
12463
b099e063
DM
124642010-12-03 Don March <don@ohspite.net>
12465
12466 * keymap.c (Fdefine_key): Fix non-prefix key error message when
12467 last character M-[char] is translated to ESC [char] (bug#7541).
12468
5cc7f7af
KH
124692011-08-02 Kenichi Handa <handa@m17n.org>
12470
d0fffa3f 12471 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
12472
12473 * chartab.c (uniprop_table): Make it non-static.
12474
525d5e6e
EZ
124752011-08-01 Eli Zaretskii <eliz@gnu.org>
12476
12477 * xdisp.c (forward_to_next_line_start): Accept additional argument
12478 BIDI_IT_PREV, and store into it the state of the bidi iterator had
12479 on the newline.
12480 (reseat_at_next_visible_line_start): Use the bidi iterator state
12481 returned by forward_to_next_line_start to restore the state of
12482 it->bidi_it after backing up to previous newline. (Bug#9212)
12483
31011111
AS
124842011-07-30 Andreas Schwab <schwab@linux-m68k.org>
12485
12486 * regex.c (re_comp): Protoize.
12487 (re_exec): Fix return type.
12488 (regexec): Fix type of `ret'. (Bug#9203)
12489
476371c4
PE
124902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12491
e5d76069
PE
12492 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
12493 This is needed if max-image-size is a floating-point number.
12494
9a79b20c
AS
124952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12496
12497 * print.c (print_object): Print empty symbol as ##.
12498
12499 * lread.c (read1): Read ## as empty symbol.
12500
d8c2fa78
AA
125012011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
12502
12503 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
12504 setting frame foreground color (Bug#9175).
12505 (x_set_background_color): Likewise.
12506
ffe57a7a
AA
12507 * nsmenu.m (-setText): Size tooltip dimensions precisely to
12508 contents (Bug#9176).
12509 (EmacsTooltip -init): Remove bezels and add shadows to
12510 tooltip windows.
12511
bf3492a5
AA
12512 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
12513 or scroll bar (Bug#8470).
12514
d55e9c53
AA
12515 * nsfont.m (nsfont_open): Remove assignment to voffset and
12516 unnecessary vars hshink, expand, hd, full_height, min_height.
12517 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
12518
12519 * nsterm.h (nsfont_info): Remove voffset field.
12520
d8c2fa78 125212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
12522
12523 Implement strike-through and overline on NextStep (Bug#8863).
12524
12525 * nsfont.m (nsfont_open): Use underline position provided by font,
12526 instead of hard-coded value of 2.
12527 (nsfont_draw): Call ns_draw_text_decoration instead.
12528
12529 * nsterm.h: Add declaration for ns_draw_text_decoration.
12530
12531 * nsterm.m (ns_draw_text_decoration): New function for drawing
12532 underline, overline, and strike-through.
12533 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
12534 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 12535 accommodate underlining, etc.
4843aac3 12536
4cc60b9b
EZ
125372011-07-28 Eli Zaretskii <eliz@gnu.org>
12538
bc7ece87
EZ
12539 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
12540 default.
4cc60b9b 12541
476371c4
PE
125422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12543
66606eea
PE
12544 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
12545 Without this fix, if a signal arrives just after memory fills up,
12546 'malloc' might be invoked reentrantly.
12547
476371c4
PE
12548 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
12549 In other words, assume that every image size is allowed, on non-X
12550 hosts. This assumption is probably wrong, but it lets Emacs compile.
12551
f3fcc40d
AS
125522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12553
12554 * regex.c (re_iswctype): Convert return values to boolean.
12555
350c992f
EZ
125562011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12557
12558 * xdisp.c (compute_display_string_pos): Don't use cached display
12559 string position if the buffer had its restriction changed.
12560 (Bug#9184)
12561
5266b4bb
PE
125622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12563
12564 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12565
2573a837 125662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 12567
41f55ccd 12568 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 12569
39e378da
PE
12570 * bidi.c: Integer size and overflow fixes.
12571 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
12572 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
12573 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12574 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
12575 (bidi_find_other_level_edge):
12576 Use ptrdiff_t instead of EMACS_INT where either will do.
12577 This works better on 32-bit hosts configured --with-wide-int.
12578 (bidi_cache_ensure_space): Check for size-calculation overflow.
12579 Use % rather than repeated addition, for better worst-case speed.
12580 Don't set bidi_cache_size until after xrealloc returns, because it
12581 might not return.
12582 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
12583 (bidi_cache_ensure_space): Also check that the bidi cache size
12584 does not exceed that of the largest Lisp string or buffer. See Eli
12585 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 12586
5e927815
PE
12587 * alloc.c (__malloc_size_t): Remove.
12588 All uses replaced by size_t. See Andreas Schwab's note
12589 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
12590
ca4aa935
PE
12591 * image.c: Improve checking for integer overflow.
12592 (check_image_size): Assume that f is nonnull, since
12593 it is always nonnull in practice. This is one less thing to
12594 worry about when checking for integer overflow later.
12595 (x_check_image_size): New function, which checks for integer
12596 overflow issues inside X.
12597 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12598 This removes the need for a memory_full check.
12599 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12600 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
12601 (xbm_read_bitmap_data): Change locals back to 'int', since
12602 their values must fit in 'int'.
12603 (xpm_load_image, png_load, tiff_load):
12604 Invoke x_create_x_image_and_pixmap earlier,
12605 to avoid much needless work if the image is too large.
12606 (tiff_load): Treat overly large images as if
12607 x_create_x_image_and_pixmap failed, not as malloc failures.
12608 (gs_load): Use x_check_image_size.
12609
5f8f9cc2
PE
12610 * gtkutil.c: Omit integer casts.
12611 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
12612 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
12613
5adf60bc
PE
12614 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
12615
c8907a93
PE
12616 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12617 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
12618 would wrongly return t on a 64-bit host.
12619
e3c25c68
PE
12620 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
12621 The plain *_OVERFLOW macros run afoul of GCC bug 49705
12622 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
12623 and therefore cause GCC to emit a bogus diagnostic in some cases.
12624
3f791afe
PE
12625 * image.c: Integer signedness and overflow and related fixes.
12626 This is not an exhaustive set of fixes, but it's time to
12627 record what I've got.
12628 (lookup_pixel_color, check_image_size): Remove redundant decls.
12629 (check_image_size): Don't assume that arbitrary EMACS_INT values
12630 fit in 'int', or that arbitrary 'double' values fit in 'int'.
12631 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
12632 (tiff_load, imagemagick_load_image):
12633 Check for overflow in size calculations.
12634 (x_create_x_image_and_pixmap): Remove unnecessary test for
12635 xmalloc returning NULL; that can't happen.
12636 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
12637 (xpm_color_bucket): Use better integer hashing function.
12638 (xpm_cache_color): Don't possibly over-allocate memory.
12639 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
12640 (gif_memory_source):
12641 Use ptrdiff_t, not int or size_t, to record sizes.
12642 (png_load): Don't assume values greater than 2**31 fit in 'int'.
12643 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
12644 either works, as we prefer signed integers.
12645 (tiff_read_from_memory, tiff_write_from_memory):
12646 Return tsize_t, not size_t, since that's what the TIFF API wants.
12647 (tiff_read_from_memory): Don't fail simply because the read would
12648 go past EOF; instead, return a short read.
12649 (tiff_load): Omit no-longer-needed casts.
12650 (Fimagemagick_types): Don't assume size fits into 'int'.
12651
3cc5a532
PE
12652 Improve hashing quality when configured --with-wide-int.
12653 * fns.c (hash_string): New function, taken from sxhash_string.
12654 Do not discard information about ASCII character case; this
12655 discarding is no longer needed.
12656 (sxhash-string): Use it. Change sig to match it. Caller changed.
12657 * lisp.h: Declare it.
12658 * lread.c (hash_string): Remove, since we now use fns.c's version.
12659 The fns.c version returns a wider integer if --with-wide-int is
12660 specified, so this should help the quality of the hashing a bit.
12661
b312a492
PE
12662 * emacs.c: Integer overflow minor fix.
12663 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
12664 Define only if GNU_LINUX.
12665 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
12666
dfd153ae
PE
12667 * dispnew.c: Integer signedness and overflow fixes.
12668 Remove unnecessary forward decls, that were a maintenance hassle.
12669 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
12670 All uses changed.
12671 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
12672 (scrolling_window): Use ptrdiff_t, not int, for byte count.
12673 (prepare_desired_row, line_draw_cost):
12674 Use int, not unsigned, where either works.
12675 (save_current_matrix, restore_current_matrix):
12676 Use ptrdiff_t, not size_t, where either works.
12677 (init_display): Check for overflow more accurately, and without
12678 relying on undefined behavior.
12679
a81d11a3
PE
12680 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
12681 Remove, replacing with the new symbols in lisp.h. All uses changed.
12682 * fileio.c (make_temp_name):
12683 * filelock.c (lock_file_1, lock_file):
12684 * xdisp.c (message_dolog):
12685 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
12686 Use pMd etc. instead.
12687 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
12688 replacing the pWIDE etc. symbols removed from editfns.c.
12689
3300e6fd
PE
12690 * keyboard.h (num_input_events): Now uintmax_t.
12691 This is (very slightly) less likely to mess up due to wraparound.
12692 All uses changed.
12693
fd05c7e9
PE
12694 * buffer.c: Integer signedness fixes.
12695 (alloc_buffer_text, enlarge_buffer_text):
12696 Use ptrdiff_t rather than size_t when either will do, as we prefer
12697 signed integers.
12698
903fe15d
PE
12699 * alloc.c: Integer signedness and overflow fixes.
12700 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
12701 (__malloc_size_t): Default to size_t, not to int.
12702 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
12703 (Fgarbage_collect, mark_object_loop_halt, mark_object):
12704 Prefer ptrdiff_t to size_t when either would do, as we prefer
12705 signed integers.
12706 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
12707 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
12708 Now const. Initialize with values that are in range even if char
12709 is signed.
12710 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
12711 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
12712 These functions do the right thing with sizes > 2**32.
12713 (check_depth): Now ptrdiff_t, not int.
12714 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
12715 Adjust to new way of storing sizes. Check for size overflow bugs
12716 in rest of code.
12717 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
12718 slightly wrong anyway, as it missed one instance of
12719 XMALLOC_OVERRUN_CHECK_OVERHEAD.
12720 (refill_memory_reserve): Omit needless cast to size_t.
12721 (mark_object_loop_halt): Mark as externally visible.
12722
ac82cc6a
PE
12723 * xselect.c: Integer signedness and overflow fixes.
12724 (Fx_register_dnd_atom, x_handle_dnd_message):
12725 Use ptrdiff_t, not size_t, since we prefer signed.
12726 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
12727 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
12728 x_dnd_atoms_size and x_dnd_atoms_length.
12729
c2d1e36d
PE
12730 * doprnt.c: Prefer signed to unsigned when either works.
12731 * eval.c (verror):
12732 * doprnt.c (doprnt):
12733 * lisp.h (doprnt):
12734 * xdisp.c (vmessage):
12735 Use ptrdiff_t, not size_t, when using or implementing doprnt,
12736 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
12737 prefer signed arithmetic to avoid comparison confusion.
12738 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12739 but is a bit tricky.
12740
0e926e56
PE
12741 Assume freestanding C89 headers, string.h, stdlib.h.
12742 * data.c, doprnt.c, floatfns.c, print.c:
12743 Include float.h unconditionally.
12744 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
12745 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
12746 * regex.c: Likewise for stddef.h, string.h.
12747 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12748 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12749 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12750 (STDC_HEADERS): Remove obsolete defines.
12751 * sysdep.c: Include limits.h unconditionally.
12752
9cfdb3ec
PE
12753 Assume support for memcmp, memcpy, memmove, memset.
12754 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12755 * regex.c (memcmp, memcpy):
12756 Remove; we assume C89 now.
12757
12758 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12759 (__malloc_safe_bcopy): Remove; no longer needed.
12760
cf950e6b 12761 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12762 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12763 well either way, and we prefer signed to unsigned.
12764
dbf38e02
LMI
127652011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12766
12767 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12768 closes the connection while we're reading (bug#9182).
12769
d6f0886c 127702011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12771
d6f0886c
JD
12772 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12773 are specified (Bug#9168).
24e0f6b1 12774
2eb1f9e6
PE
127752011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12776
12777 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12778 Found by GCC static checking and --with-wide-int on a 32-bit host.
12779
22381272 127802011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12781
12782 * xdisp.c (compute_display_string_pos): Fix logic of caching
12783 previous display string position. Initialize cached_prev_pos to
12784 -1. Fixes slow-down at the beginning of a buffer.
12785
f25e39b4
EZ
127862011-07-24 Eli Zaretskii <eliz@gnu.org>
12787
12788 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12789 for attrs[LFACE_FONTSET_INDEX].
12790
04c4b52e
PE
127912011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12792
12793 * xml.c (parse_region): Remove unused local
12794 that was recently introduced.
12795
c1734fbd
EZ
127962011-07-23 Eli Zaretskii <eliz@gnu.org>
12797
be18c5a5
EZ
12798 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12799 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12800
c1734fbd
EZ
12801 * xdisp.c (move_it_in_display_line_to): Record the best matching
12802 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12803 exit if none of the characters scanned was an exact match.
12804 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12805 when exact match is impossible due to invisible text, and the
12806 lines are truncated.
12807
a258d627
JD
128082011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12809
12810 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12811 for OSX >= 10.7.
12812
b6d5a689
EZ
128132011-07-22 Eli Zaretskii <eliz@gnu.org>
12814
0f74f785
EZ
12815 Fix a significant slow-down of cursor motion with C-n, C-p,
12816 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12817 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12818 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12819 (next_element_from_buffer): Call compute_stop_pos_backwards to
12820 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12821 base_level_stop.
12822 (reseat): Don't look for prev_stop, as that could mean a very long
12823 run.
12824 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12825 <cached_disp_overlay_modiff>: Cache for last found display string
12826 position.
551918c1 12827 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12828 about the same buffer in the same area of character positions, and
12829 the buffer wasn't changed since the time the display string
12830 position was cached.
551918c1 12831
b2d0c91a
EZ
128322011-07-22 Eli Zaretskii <eliz@gnu.org>
12833
12834 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12835 is an integer, which is important for empty lines. (Bug#9149)
12836
043604ee
CY
128372011-07-22 Chong Yidong <cyd@stupidchicken.com>
12838
12839 * frame.c (Fmodify_frame_parameters): In tty case, update the
12840 default face if necessary (Bug#4238).
12841
da4adb04
CY
128422011-07-21 Chong Yidong <cyd@stupidchicken.com>
12843
12844 * editfns.c (Fstring_to_char): No need to explain what a character
12845 is in the docstring (Bug#6576).
12846
9abd0532
LMI
128472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12848
12849 * xml.c (parse_region): Make sure we always return a tree.
12850
36881d16
HK
128512011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12852
12853 * xml.c (parse_region): If a document contains only comments,
12854 return that, too.
12855
1e98674d
LMI
128562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12857
12858 * xml.c (make_dom): Return comments, too.
12859
590bd467
PE
128602011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12861
12862 Port to OpenBSD.
12863 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12864 and the surrounding thread.
12865 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12866 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12867 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12868 timer goes off.
12869 * s/openbsd.h (BROKEN_SIGIO): Define.
12870 * unexelf.c (unexec) [__OpenBSD__]:
12871 Don't update the .mdebug section of the Alpha COFF symbol table.
12872
f41628b2
LMI
128732011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12874
12875 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12876 (bug#8460).
12877
b59b67c5
PE
128782011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12879
15e3a074
PE
12880 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12881 This fixes some race conditions on the permissions of any newly
12882 created file.
12883
41bed37d
PE
12884 * alloc.c (valid_pointer_p): Use pipe, not open.
12885 This fixes some permissions issues when debugging.
12886
b59b67c5
PE
12887 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12888 If fchown fails to set both uid and gid, try to set just gid,
12889 as that is sometimes allowed. Adjust the file's mode to eliminate
12890 setuid or setgid bits that are inappropriate if fchown fails.
12891
925a6be7
SM
128922011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12893
12894 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12895 to compare Lisp_Objects.
12896 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12897 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12898 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12899
52968808
AS
129002011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12901
0a6a104b
AS
12902 * lread.c (read_integer): Unread even EOF character.
12903 (read1): Likewise. Properly record start position of symbol.
12904
52968808
AS
12905 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12906 symbol character follows.
12907
9e381cdd
PE
129082011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12909
12910 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12911 This works around a problem with the previous change to Fcopy_file.
12912 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12913 and without this change, GCC might complain about discarding
12914 fchown's return value.
12915
b5641435
JB
129162011-07-16 Juanma Barranquero <lekktu@gmail.com>
12917
12918 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12919
a8031457
PE
129202011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12921
12922 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12923
dd889327
LMI
129242011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12925
750c33f7
LMI
12926 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12927 it's used from the C level.
12928
dd889327
LMI
12929 * process.c: Use the same condition for POLL_FOR_INPUT in both
12930 keyboard.c and process.c (bug#1858).
12931
87e86684
LM
129322011-07-09 Lawrence Mitchell <wence@gmx.li>
12933
12934 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12935 (Fgnutls_boot): Use it.
12936
64348f40
AS
129372011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12938
12939 * doc.c (Fsubstitute_command_keys): Revert last change.
12940
1d698799
LMI
129412011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12942
f863868c
LMI
12943 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12944 quotes the next character, and doesn't affect other longer
12945 sequences (bug#8935).
12946
1d698799
LMI
12947 * lread.c (syms_of_lread): Clarify that is isn't only
12948 `eval-buffer' and `eval-defun' that's affected by
12949 `lexical-binding' (bug#8460).
12950
aa4b6df6
EZ
129512011-07-15 Eli Zaretskii <eliz@gnu.org>
12952
12953 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12954 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12955
5d856da6
PE
129562011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12957
ad6042bb
PE
12958 Fix minor problems found by static checking.
12959 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12960 (elsz): Now a signed constant, not a size_t var. We prefer signed
12961 types to unsigned, to avoid integer comparison confusion. Without
12962 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12963 "cannot optimize loop, the loop counter may overflow", a symptom
12964 of the confusion.
f00bbb22 12965 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12966 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12967
6468f31c
LMI
129682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12969
49080b10
LMI
12970 * search.c (Fre_search_backward): Mention `case-fold-search' in
12971 all the re_search_* functions (bug#8138).
12972
6468f31c
LMI
12973 * keyboard.c (Fopen_dribble_file): Document when the file is
12974 closed (bug#8056).
12975
c965adc5
EZ
129762011-07-14 Eli Zaretskii <eliz@gnu.org>
12977
df9733bf
EZ
12978 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12979 bidi_cache_idx.
12980
0bb23927
EZ
12981 Support bidi reordering of display and overlay strings.
12982 * xdisp.c (compute_display_string_pos)
12983 (compute_display_string_end): Accept additional argument STRING.
12984 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12985 (reseat_to_string): Initialize bidi_it->string.s and
12986 bidi_it->string.schars.
12987 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12988 NULL (avoids a crash in bidi_paragraph_init).
12989 Initialize itb.string.lstring.
0bb23927
EZ
12990 (init_iterator): Call bidi_init_it only of a valid
12991 buffer position was specified. Initialize paragraph_embedding to
12992 L2R.
12993 (reseat_to_string): Initialize the bidi iterator.
12994 (display_string): If we need to ignore text properties of
12995 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12996 original value of -1 will not work with bidi.)
12997 (compute_display_string_pos): First arg is now struct
12998 `text_pos *'; all callers changed. Support display properties on
12999 Lisp strings.
13000 (compute_display_string_end): Support display properties on Lisp
13001 strings.
13002 (init_iterator, reseat_1, reseat_to_string): Initialize the
13003 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
13004 when iterating on a string not from display properties).
640c8776
SM
13005 (compute_display_string_pos, compute_display_string_end):
13006 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
13007 arrow keys.
13008 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
13009 base_level_stop; instead, set base_level_stop to BEGV.
13010 Fixes crashes in vertical-motion.
0bb23927
EZ
13011 (next_element_from_buffer): Improve commentary for when
13012 the iterator is before prev_stop.
13013 (init_iterator): Initialize bidi_p from the default value of
13014 bidi-display-reordering, not from buffer-local value. Use the
13015 buffer-local value only if initializing for buffer iteration.
13016 (handle_invisible_prop): Support invisible properties on strings
13017 that are being bidi-reordered.
13018 (set_iterator_to_next): Support bidi reordering of C strings and
13019 Lisp strings.
13020 (next_element_from_string): Support bidi reordering of Lisp
13021 strings.
13022 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
13023 (display_string): Support display of R2L glyph rows.
13024 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
13025 (init_iterator): Don't initialize it->bidi_p for strings
13026 here.
13027 (reseat_to_string): Initialize it->bidi_p for strings here.
13028 (next_element_from_string, next_element_from_c_string)
13029 (next_element_from_buffer): Add xassert's for correspondence
13030 between IT's object being iterated and it->bidi_it.string
13031 structure.
13032 (face_before_or_after_it_pos): Support bidi iteration.
13033 (next_element_from_c_string): Handle the case of the first string
13034 character that is not the first one in the visual order.
13035 (get_visually_first_element): New function, refactored from common
13036 parts of next_element_from_buffer, next_element_from_string, and
13037 next_element_from_c_string.
13038 (tool_bar_lines_needed, redisplay_tool_bar)
13039 (display_menu_bar): Force left-to-right direction. Add a FIXME
13040 comment for making that be controlled by a user option.
13041 (push_it, pop_it): Save and restore the state of the
13042 bidi iterator. Save and restore the bidi_p flag.
13043 (pop_it): Iterate out of display property for string iteration as
13044 well.
13045 (iterate_out_of_display_property): Support iteration over strings.
13046 (handle_single_display_spec): Set up it->bidi_it for iteration
13047 over a display string, and call bidi_init_it.
13048 (handle_single_display_spec, next_overlay_string)
13049 (get_overlay_strings_1, push_display_prop): Set up the bidi
13050 iterator for displaying display or overlay strings.
13051 (forward_to_next_line_start): Don't use the shortcut if
13052 bidi-iterating.
13053 (back_to_previous_visible_line_start): If handle_display_prop
13054 pushed the iterator stack, restore the internal state of the bidi
13055 iterator by calling bidi_pop_it same number of times.
13056 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
13057 and we are bidi-iterating, don't decrement the iterator position;
13058 instead, set the first_elt flag in the bidi iterator, to produce
13059 the same effect.
13060 (reseat_1): Remove redundant setting of string_from_display_prop_p.
13061 (push_display_prop): xassert that we are iterating a buffer.
13062 (push_it, pop_it): Save and restore paragraph_embedding member.
13063 (handle_single_display_spec, next_overlay_string)
13064 (get_overlay_strings_1, reseat_1, reseat_to_string)
13065 (push_display_prop): Set up the `unibyte' member of bidi_it.string
13066 correctly. Don't assume unibyte strings are not bidi-reordered.
13067 (compute_display_string_pos)
13068 (compute_display_string_end): Fix handling the case of C string.
13069 (push_it, pop_it): Save and restore from_disp_prop_p.
13070 (handle_single_display_spec, push_display_prop): Set the
13071 from_disp_prop_p flag.
13072 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
13073 (pop_it): Call iterate_out_of_display_property only if we are
13074 popping after iteration over a string that came from a display
13075 property. Fix a typo in popping stretch info. Add an assertion
13076 for verifying that the iterator position is in sync with the bidi
13077 iterator.
13078 (handle_single_display_spec, get_overlay_strings_1)
13079 (push_display_prop): Fix initialization of paragraph direction for
13080 string when that of the parent object is not yet determined.
13081 (reseat_1): Call bidi_init_it to resync the bidi
13082 iterator with IT's position. (Bug#7616)
13083 (find_row_edges): If ROW->start.pos gives position
13084 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
13085 (handle_stop, back_to_previous_visible_line_start, reseat_1):
13086 Reset the from_disp_prop_p flag.
13087 (SAVE_IT, RESTORE_IT): New macros.
13088 (pos_visible_p, face_before_or_after_it_pos)
13089 (back_to_previous_visible_line_start)
13090 (move_it_in_display_line_to, move_it_in_display_line)
13091 (move_it_to, move_it_vertically_backward, move_it_by_lines)
13092 (try_scrolling, redisplay_window, display_line): Use them when
13093 saving a temporary copy of the iterator and restoring it back.
13094 (back_to_previous_visible_line_start, reseat_1)
13095 (init_iterator): Empty the bidi cache "stack".
13096 (move_it_in_display_line_to): If iterator ended up at
13097 EOL, but we never saw any buffer positions smaller than
13098 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
13099 motion in bidi-reordered lines.
13100 (move_it_in_display_line_to): Record prev_method and prev_pos
13101 immediately before the call to set_iterator_to_next. Fixes cursor
13102 motion in bidi-reordered lines with stretch glyphs and strings
13103 displayed in margins. (Bug#8133) (Bug#8867)
13104 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
13105 TO_CHARPOS.
640c8776
SM
13106 (pos_visible_p): Support positions in bidi-reordered lines.
13107 Save and restore bidi cache.
0bb23927
EZ
13108
13109 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
13110 (bidi_paragraph_info): Delete unused struct.
13111 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
13112 (bidi_cache_start): New variable.
13113 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
13114 to zero.
13115 (bidi_cache_fetch_state, bidi_cache_search)
13116 (bidi_cache_find_level_change, bidi_cache_iterator_state)
13117 (bidi_cache_find, bidi_peek_at_next_level)
13118 (bidi_level_of_next_char, bidi_find_other_level_edge)
13119 (bidi_move_to_visually_next): Compare cache index with
13120 bidi_cache_start rather than with zero.
13121 (bidi_fetch_char): Accept new argument STRING; all callers
13122 changed. Support iteration over a string. Support strings with
13123 display properties. Support unibyte strings. Fix the type of
13124 `len' according to what STRING_CHAR_AND_LENGTH expects.
13125 (bidi_paragraph_init, bidi_resolve_explicit_1)
13126 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
13127 (bidi_level_of_next_char, bidi_move_to_visually_next):
13128 Support iteration over a string.
0bb23927
EZ
13129 (bidi_set_sor_type, bidi_resolve_explicit_1)
13130 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
13131 can now be zero (for strings); special values 0 and -1 were
13132 changed to -1 and -2, respectively.
13133 (bidi_char_at_pos): New function.
13134 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
13135 Call it instead of FETCH_MULTIBYTE_CHAR.
13136 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
13137 initialized to valid values.
13138 (bidi_init_it): Don't initialize charpos and bytepos with invalid
13139 values.
13140 (bidi_level_of_next_char): Allow the sentinel "position" to pass
13141 the test for valid cached positions. Fix the logic for looking up
13142 the sentinel state in the cache. GCPRO the Lisp string we are
13143 iterating.
13144 (bidi_push_it, bidi_pop_it): New functions.
13145 (bidi_initialize): Initialize the bidi cache start stack pointer.
13146 (bidi_cache_ensure_space): New function, refactored from part of
13147 bidi_cache_iterator_state. Don't assume the required size is just
13148 one BIDI_CACHE_CHUNK away.
13149 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
13150 (bidi_count_bytes, bidi_char_at_pos): New functions.
13151 (bidi_cache_search): Don't assume bidi_cache_last_idx is
13152 always valid if bidi_cache_idx is valid.
13153 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
13154 is valid if it's going to be used.
13155 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
13156 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
13157 (bidi_cache_find_level_change, bidi_cache_ensure_space)
13158 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
13159 (bidi_find_other_level_edge, bidi_cache_start_stack):
13160 All variables related to cache indices are now EMACS_INT.
c965adc5 13161
0bb23927
EZ
13162 * dispextern.h (struct bidi_string_data): New structure.
13163 (struct bidi_it): New member `string'. Make flag members be 1-bit
13164 fields, and put them last in the struct.
640c8776
SM
13165 (compute_display_string_pos, compute_display_string_end):
13166 Update prototypes.
0bb23927
EZ
13167 (bidi_push_it, bidi_pop_it): Add prototypes.
13168 (struct iterator_stack_entry): New members bidi_p,
13169 paragraph_embedding, and from_disp_prop_p.
13170 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
13171 (bidi_shelve_cache, bidi_unshelve_cache):
13172 Declare prototypes.
0bb23927
EZ
13173
13174 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
13175 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
13176 and vector-like objects.
13177
13178 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
13179 cache around display iteration.
13180
13181 * window.c (Fwindow_end, window_scroll_pixel_based)
13182 (displayed_window_lines, Frecenter): Save and restore the bidi
13183 cache around display iteration.
13184
3bbd2265
LMI
131852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
13186
13187 * editfns.c (Fdelete_region): Clarify the use of the named
13188 parameters (bug#6788).
13189
adc47434
MR
131902011-07-14 Martin Rudalics <rudalics@gmx.at>
13191
13192 * indent.c (Fvertical_motion): Set and restore w->pointm when
13193 saving and restoring the window's buffer (Bug#9006).
13194
837c31f8
LMI
131952011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
13196
13197 * editfns.c (Fstring_to_char): Clarify just what is returned
13198 (bug#6576). Text by Eli Zaretskii.
13199
ac389d0c
JB
132002011-07-13 Juanma Barranquero <lekktu@gmail.com>
13201
13202 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
13203
0be0ce47
EZ
132042011-07-13 Eli Zaretskii <eliz@gnu.org>
13205
13206 * buffer.c (mmap_find): Fix a typo.
13207
cd18e7e3
JB
132082011-07-13 Johan Bockgård <bojohan@gnu.org>
13209
13210 Fix execution of x selection hooks.
13211 * xselect.c (Qx_lost_selection_functions)
13212 (Qx_sent_selection_functions): New vars.
13213 (syms_of_xselect): DEFSYM them.
13214 (x_handle_selection_request): Pass Qx_sent_selection_functions
13215 rather than Vx_sent_selection_functions to Frun_hook_with_args.
13216 (x_handle_selection_clear,x_clear_frame_selections):
13217 Pass Qx_lost_selection_functions rather than
13218 Vx_lost_selection_functions to Frun_hook_with_args.
13219
47ea7f44
PE
132202011-07-13 Paul Eggert <eggert@cs.ucla.edu>
13221
ac389d0c 13222 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
13223 The old code sometimes used this field without initializing it.
13224
47ea7f44
PE
13225 * alloc.c (gc_sweep): Don't read past end of array.
13226 In theory, the old code could also have corrupted Emacs internals,
13227 though it'd be very unlikely.
13228
bc985c87
AS
132292011-07-12 Andreas Schwab <schwab@linux-m68k.org>
13230
13231 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 13232 argument. (Bug#4026)
bc985c87 13233
0cf34688
LMI
132342011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
13235
b3dadd76
LMI
13236 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
13237 key" (bug#4257).
13238
0cf34688
LMI
13239 * window.c (Fset_window_start): Doc fix (bug#4199).
13240 (Fset_window_hscroll): Ditto.
13241
270768cd
PE
132422011-07-12 Paul Eggert <eggert@cs.ucla.edu>
13243
077e3dda 13244 Fix minor new problems caught by GCC 4.6.1.
270768cd 13245 * term.c (init_tty): Remove unused local.
490011a6 13246 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 13247 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 13248 not used otherwise.
270768cd 13249
b1f58454
CY
132502011-07-12 Chong Yidong <cyd@stupidchicken.com>
13251
13252 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
13253
22b9578d
LMI
132542011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
13255
6e70ab07
LMI
13256 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
13257 are the mini-buffer and the echo area (bug#3320).
13258
22b9578d
LMI
13259 * term.c (init_tty): Remove support for supdup, c10 and perq
13260 terminals, which are no longer supported (bug#1482).
13261
8974cc9f
JB
132622011-07-10 Johan Bockgård <bojohan@gnu.org>
13263
13264 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
13265
a560d974
JD
132662011-07-10 Jan Djärv <jan.h.d@swipnet.se>
13267
13268 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
13269 for non-popups (Bug#3642).
13270
1dae0f0a
AS
132712011-07-10 Andreas Schwab <schwab@linux-m68k.org>
13272
268c2c36 13273 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 13274 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
13275 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
13276 * cm.c (losecursor): Likewise.
1dae0f0a
AS
13277 * data.c (fmod): Likewise.
13278 * dispnew.c (swap_glyphs_in_rows): Likewise.
13279 * emacs.c (memory_warning_signal): Likewise.
13280 * floatfns.c (float_error): Likewise.
13281 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
13282 (otf_open, font_otf_capability, generate_otf_features)
13283 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
13284 Likewise.
13285 * image.c (pbm_read_file): Likewise.
13286 * indent.c (string_display_width): Likewise.
13287 * intervals.c (check_for_interval, search_for_interval)
13288 (inc_interval_count, count_intervals, root_interval)
13289 (adjust_intervals_for_insertion, make_new_interval): Likewise.
13290 * lread.c (defalias): Likewise.
268c2c36 13291 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
13292 * regex.c (set_image_of_range_1, set_image_of_range)
13293 (regex_grow_registers): Likewise.
13294 * sysdep.c (strerror): Likewise.
13295 * termcap.c (valid_filename_p, tprint, main): Likewise.
13296 * tparam.c (main): Likewise.
13297 * unexhp9k800.c (run_time_remap, save_data_space)
13298 (update_file_ptrs, read_header, write_header, calculate_checksum)
13299 (copy_file, copy_rest, display_header): Likewise.
13300 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
13301 Likewise.
13302 * xdisp.c (check_it): Likewise.
13303 * xfaces.c (register_color, unregister_color, unregister_colors):
13304 Likewise.
13305 * xfns.c (print_fontset_result): Likewise.
13306 * xrdb.c (member, fatal, main): Likewise.
13307
99033785
PE
133082011-07-10 Paul Eggert <eggert@cs.ucla.edu>
13309
13310 Fix minor problems found by static checking (Bug#9031).
13311 * chartab.c (char_table_set_range, map_sub_char_table):
13312 Remove unused locals.
13313 (uniprop_table): Now static.
13314 * composite.c (_work_char): Remove unused static var.
13315
9cb2ac56
JB
133162011-07-09 Juanma Barranquero <lekktu@gmail.com>
13317
13318 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
13319
f25661f0
JD
133202011-07-09 Jan Djärv <jan.h.d@swipnet.se>
13321
13322 * gtkutil.c (qttip_cb): Remove code without function.
13323
8278c4fe
EZ
133242011-07-09 Eli Zaretskii <eliz@gnu.org>
13325
13326 * w32.c (pthread_sigmask): New stub.
13327
1692ae2d 133282011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 13329
8a6ebd58 13330 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
13331 sigprocmask is portable only for single-threaded applications, and
13332 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
13333 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
13334 (LIBES): Use it.
13335 * callproc.c (Fcall_process):
13336 * process.c (create_process):
13337 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
13338 Use pthread_sigmask, not sigprocmask.
123403e4 13339
1b854618
JD
133402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13341
13342 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
13343 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
13344 wrong (Bug#8591).
13345
3fe4b549
JD
133462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13347
0ce7e563
JD
13348 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
13349 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
13350 (xg_hide_tooltip): Fix comment.
13351
3fe4b549
JD
13352 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
13353 in registerServicesMenuSendTypes.
13354 (validRequestorForSendType): Don't check ns_return_types.
13355
13356 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
13357 ns_return_type.
13358
5df75e47
JR
133592011-07-08 Jason Rumney <jasonr@gnu.org>
13360
22610910
JR
13361 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
13362 SH_SHOW for hidden windows (Bug#5482).
13363
5df75e47
JR
13364 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
13365 frame struct members of non-existent frames (Bug#6284).
13366
699c10bd
JD
133672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13368
4393663b
JD
13369 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
13370 variable firstTime not needed on OSX >= 10.6.
13371 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
13372 >= 10.5. Use setKnobProportion, setDoubleValue.
13373
13374 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
13375 (MAC_OS_X_VERSION_10_5): Define if not defined.
13376 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
13377 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
13378 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
13379
13380 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 13381 cString and lossyCString on OSX >= 10.4.
4393663b 13382
58179cce 13383 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
13384 sizeToFit on OSX >= 10.2.
13385
13386 * nsimage.m (allocInitFromFile): Don't use deprecated method
13387 bestRepresentationForDevice on OSX >= 10.6.
13388
13389 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
13390 to avoid warning.
13391
13392 * emacs.c: Declare unexec_init_emacs_zone.
13393
a63e0781
JD
13394 * nsgui.h: Fix compiler warning about gnulib redefining verify.
13395
699c10bd
JD
13396 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
13397
13398 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
13399 on svcsMenu (Bug#8842).
13400
13401 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
13402 ns_return_types.
13403 (Fns_list_services): Just return Qnil on 10.6, code not working there.
13404
13405 * nsterm.m (QUTF8_STRING): Declare.
13406 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
13407 (validRequestorForSendType): Return type is (id).
13408 Change indexOfObjectIdenticalTo to indexOfObject.
13409 Check if we have local selection before returning self (Bug#8842).
13410 (writeSelectionToPasteboard): Put local selection into paste board
13411 if we have a local selection (Bug#8842).
13412 (syms_of_nsterm): DEFSYM QUTF8_STRING.
13413
13414 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
13415 (ns_get_local_selection): Declare.
13416
54e10184
LMI
134172011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
13418
9888ff71
LMI
13419 * keymap.c (describe_map_tree): Don't insert a double newline at
13420 the end of the buffer (bug#1169) and return whether we inserted
13421 something.
13422
54e10184
LMI
13423 * callint.c (Fcall_interactively): Change "reading args" to
13424 "providing args" to try to clarify what it does (bug#1010).
13425
15fa4783
KH
134262011-07-07 Kenichi Handa <handa@m17n.org>
13427
13428 * composite.c (composition_compute_stop_pos): Ignore a static
13429 composition starting before CHARPOS (Bug#8915).
13430
13431 * xdisp.c (handle_composition_prop): Likewise.
13432
a8815b00
EZ
134332011-07-07 Eli Zaretskii <eliz@gnu.org>
13434
13435 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
13436 (Bug#9015)
13437
ef7b981d 134382011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
13439
13440 * character.h (unicode_category_t): New enum type.
13441
13442 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
13443 (Qchar_code_property_table): New variable.
13444 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
13445 (UNIPROP_COMPRESSED_FORM_P): New macros.
13446 (char_table_ascii): Uncompress the compressed values.
13447 (sub_char_table_ref): New arg is_uniprop. Callers changed.
13448 Uncompress the compressed values.
ac389d0c 13449 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
13450 (char_table_ref_and_range): Uncompress the compressed values.
13451 (sub_char_table_set): New arg is_uniprop. Callers changed.
13452 Uncompress the compressed values.
13453 (sub_char_table_set_range): Args changed. Callers changed.
13454 (char_table_set_range): Adjuted for the above change.
13455 (map_sub_char_table): Delete args default_val and parent. Add arg
13456 top. Give decoded values to a Lisp function.
640c8776 13457 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
13458 values to a Lisp function. Gcpro more variables.
13459 (uniprop_table_uncompress)
13460 (uniprop_decode_value_run_length): New functions.
13461 (uniprop_decoder, uniprop_decoder_count): New variables.
13462 (uniprop_get_decoder, uniprop_encode_value_character)
13463 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
13464 New functions.
13465 (uniprop_encoder, uniprop_encoder_count): New variables.
13466 (uniprop_get_encoder, uniprop_table)
13467 (Funicode_property_table_internal, Fget_unicode_property_internal)
13468 (Fput_unicode_property_internal): New functions.
13469 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
13470 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 13471 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
13472 char-code-property-alist.
13473
640c8776 13474 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
13475 Vunicode_category_table.
13476
640c8776 13477 * font.c (font_range): Adjust for the change of
c805dec0
KH
13478 Vunicode_category_table.
13479
76b397fb
DN
134802011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
13481
13482 * m/iris4d.h: Remove file, move contents ...
13483 * s/irix6-5.h: ... here.
13484
22b4128e
PE
134852011-07-06 Paul Eggert <eggert@cs.ucla.edu>
13486
13487 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
13488 * alloc.c (mark_buffer):
13489 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
13490 (clone_per_buffer_values): Don't assume that
22b4128e
PE
13491 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13492 This isn't true in general, and it's particularly not true
13493 if Emacs is configured with --with-wide-int.
13494 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
13495 New macros, used in the buffer.c change.
13496
869795d6
JD
134972011-07-05 Jan Djärv <jan.h.d@swipnet.se>
13498
13499 * xsettings.c: Use both GConf and GSettings if both are available.
13500 (store_config_changed_event): Add comment.
13501 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
13502 (store_tool_bar_style_changed): New functions.
5e617bc2 13503 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
13504 (struct xsettings): Move font inside HAVE_XFT.
13505 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 13506 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 13507 Move inside HAVE_XFT.
640c8776 13508 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
13509 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
13510 also.
13511 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 13512 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 13513 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
13514 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
13515 (parse_settings): Move check for font inside HAVE_XFT.
13516 (read_settings, apply_xft_settings): Add comment.
13517 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
13518 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
13519 call store_font_name_changed.
13520 (xft_settings_event): Add comment.
13521 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
13522 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
13523 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
13524 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
13525 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
13526 (xsettings_get_system_font, xsettings_get_system_normal_font):
13527 Add comment.
869795d6 13528
d8ed26bd
PE
135292011-07-05 Paul Eggert <eggert@cs.ucla.edu>
13530
13531 Random fixes. E.g., (random) never returned negative values.
13532 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
13533 subseconds part to the entropy, as that's a bit more random.
13534 Prefer signed to unsigned, since the signedness doesn't matter and
13535 in general we prefer signed. When given a limit, use a
13536 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13537 latter isn't right if USE_2_TAGS_FOR_INTS.
13538 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
13539 not 0..VALMASK. Don't discard "excess" bits that random () returns.
13540
cabf1cac
SM
135412011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13542
13543 * textprop.c (text_property_stickiness):
13544 Obey Vtext_property_default_nonsticky.
13545 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
13546 * w32fns.c (syms_of_w32fns):
13547 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
13548
6e9b2be9
PE
135492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13550
13551 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
13552 This is more efficient than Ffile_directory_p and avoids a minor race.
13553
90186c68
LMI
135542011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
13555
7c301272
LMI
13556 * buffer.c (Foverlay_put): Say what the return value is
13557 (bug#7835).
13558
c4f2d8d4
LMI
13559 * fileio.c (barf_or_query_if_file_exists): Check first if the file
13560 is a directory before asking whether to use the file name
13561 (bug#7564).
ad637907
LMI
13562 (barf_or_query_if_file_exists): Make the "File is a directory"
13563 error be more correct.
c4f2d8d4 13564
90186c68
LMI
13565 * fns.c (Frequire): Remove the mention of the .gz files, since
13566 that's installation-specific, but keep the mention of
13567 `get-load-suffixes'.
13568
da64016e
PE
135692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13570
13571 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
13572 Report string overflow if the output is too long.
13573
7d47b580
JB
135742011-07-04 Juanma Barranquero <lekktu@gmail.com>
13575
a555cb87
JB
13576 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
13577 (syms_of_gnutls): Remove duplicate DEFSYM for
13578 Qgnutls_bootprop_verify_hostname_error, an error for
13579 Qgnutls_bootprop_verify_error (which is no longer used).
13580
7d47b580
JB
13581 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
13582 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
13583 Also (re)move comments that are misplaced or no longer relevant.
13584
1e49bfab
LMI
135852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13586
13587 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
13588
1485f4c0
CY
135892011-07-03 Chong Yidong <cyd@stupidchicken.com>
13590
13591 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
13592 and background color parameters if they have been changed.
13593
a9ab721e
LMI
135942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13595
13596 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13597
cf7cff57
PE
135982011-07-03 Paul Eggert <eggert@cs.ucla.edu>
13599
2e13213d
PE
13600 * xsettings.c (SYSTEM_FONT): Define only when used.
13601 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
13602
cf7cff57
PE
13603 * keymap.c (access_keymap_1): Now static.
13604
7a8e04f7
CY
136052011-07-02 Chong Yidong <cyd@stupidchicken.com>
13606
13607 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
13608 leave any prefix arg for the up event (Bug#1586).
13609
61352f62
LMI
136102011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
13611
69bb1ef7
LMI
13612 * lread.c (syms_of_lread): Mention single symbols defined by
13613 `defvar' or `defconst' (bug#7154).
13614
61352f62 13615 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 13616 (Frequire): Mention get-load-suffixes.
61352f62 13617
28545e04
MR
136182011-07-02 Martin Rudalics <rudalics@gmx.at>
13619
13620 * window.h (window): Remove clone_number slot.
13621 * window.c (Fwindow_clone_number, Fset_window_clone_number):
13622 Remove.
13623 (make_parent_window, make_window, saved_window)
13624 (Fset_window_configuration, save_window_save): Don't deal with
13625 clone numbers.
13626 * buffer.c (Qclone_number): Remove declaration.
13627 (sort_overlays, overlay_strings): Don't deal with clone numbers.
13628
3349e122
SM
136292011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13630
13631 Add multiple inheritance to keymaps.
13632 * keymap.c (Fmake_composed_keymap): New function.
13633 (Fset_keymap_parent): Simplify.
13634 (fix_submap_inheritance): Remove.
13635 (access_keymap_1): New function extracted from access_keymap to handle
13636 embedded parents and handle lists of maps.
13637 (access_keymap): Use it.
13638 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
13639 (Fcopy_keymap): Handle embedded parents.
13640 (Fcommand_remapping, define_as_prefix): Simplify.
13641 (Fkey_binding): Simplify.
13642 (syms_of_keymap): Move minibuffer-local-completion-map,
13643 minibuffer-local-filename-completion-map,
13644 minibuffer-local-must-match-map, and
13645 minibuffer-local-filename-must-match-map to Elisp.
13646 (syms_of_keymap): Defsubr make-composed-keymap.
13647 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
13648 (parse_menu_item): Trivial simplification.
13649
3279eb87
GM
136502011-07-01 Glenn Morris <rgm@gnu.org>
13651
13652 * Makefile.in (SETTINGS_LIBS): Fix typo.
13653
39cb9e56 136542011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
13655
13656 * coding.c (Fencode_coding_string): Record the last coding system
13657 used, as the function doc string says (bug#8738).
13658
0949d2b6
JD
136592011-07-01 Jan Djärv <jan.h.d@swipnet.se>
13660
13661 * xsettings.c (store_monospaced_changed): Take new font as arg and
13662 check for change against current_mono_font.
13663 (EMACS_TYPE_SETTINGS): Remove this and related defines.
13664 (emacs_settings_constructor, emacs_settings_get_property)
13665 (emacs_settings_set_property, emacs_settings_class_init)
13666 (emacs_settings_init, gsettings_obj): Remove.
13667 (something_changedCB): New function for HAVE_GSETTINGS.
13668 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
13669 with value as argument.
13670 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
13671 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 13672 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
13673 "changed".
13674
13675 * xgselect.c: Add defined (HAVE_GSETTINGS).
13676 (xgselect_initialize): Ditto.
13677
13678 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
13679 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
13680 xg_select.
13681
bbc6b304
PE
136822011-07-01 Paul Eggert <eggert@cs.ucla.edu>
13683
13684 * eval.c (struct backtrace): Simplify and port the data structure.
13685 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
13686 signed bit field, as this assumption is not portable and it makes
13687 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
13688 "char debug_on_exit : 1" as this is not portable either; instead,
13689 use the portable "unsigned int debug_on_exit : 1". Remove unused
13690 member evalargs. Remove obsolete comments about cc bombing out.
13691
9851bfc5
JD
136922011-06-30 Jan Djärv <jan.h.d@swipnet.se>
13693
51bb811f 13694 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
13695 Let HAVE_GSETTINGS override HAVE_GCONF.
13696 (store_monospaced_changed): New function.
13697 (EMACS_SETTINGS): A new type derived from GObject to handle
13698 GSettings notifications.
13699 (emacs_settings_constructor, emacs_settings_get_property)
13700 (emacs_settings_set_property, emacs_settings_class_init):
13701 New functions.
13702 (gsettings_client, gsettings_obj): New variables.
13703 (GSETTINGS_SCHEMA): New define.
13704 (something_changedCB): Call store_monospaced_changed.
13705 (init_gsettings): New function.
13706 (xsettings_initialize): Call init_gsettings.
13707 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
13708 to NULL.
13709
640c8776 13710 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
13711 GCONF_CFLAGS/LIBS.
13712
5386012d
MR
137132011-06-29 Martin Rudalics <rudalics@gmx.at>
13714
13715 * window.c (resize_root_window, grow_mini_window)
13716 (shrink_mini_window): Rename Qresize_root_window to
13717 Qwindow_resize_root_window and Qresize_root_window_vertically to
13718 Qwindow_resize_root_window_vertically.
13719
f13e0b08
PE
137202011-06-28 Paul Eggert <eggert@cs.ucla.edu>
13721
13722 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
13723
94515237
JB
137242011-06-27 Juanma Barranquero <lekktu@gmail.com>
13725
13726 * makefile.w32-in: Redesign dependencies so they reflect more
13727 clearly which files are directly included by each source file,
13728 and not through other includes.
13729
e43b6e43
MR
137302011-06-27 Martin Rudalics <rudalics@gmx.at>
13731
13732 * buffer.c (Qclone_number): Declare static and DEFSYM it.
13733 (sort_overlays, overlay_strings): When an overlay's clone number
13734 matches the window's clone number process the overlay even if
13735 the overlay's window property doesn't match the current window.
13736
d68443dc
MR
13737 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
13738 (Fwindow_hchild): Rename to Fwindow_left_child.
13739 (Fwindow_next): Rename to Fwindow_next_sibling.
13740 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
13741 (resize_window_check): Rename to window_resize_check.
13742 (resize_window_apply): Rename to window_resize_apply.
13743 (Fresize_window_apply): Rename to Fwindow_resize_apply.
13744 (Fdelete_other_windows_internal, resize_frame_windows)
13745 (Fsplit_window_internal, Fdelete_window_internal)
13746 (grow_mini_window, shrink_mini_window)
13747 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13748
c7e73be5
JD
137492011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13750
13751 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13752 (emacs_fixed_set_min_size): Remove.
13753 (emacs_fixed_new): Take frame as argument.
13754
13755 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13756 (_EmacsFixedPrivate): Remove minwidth/height.
13757 Add struct frame *f.
13758 (emacs_fixed_init): Initialize priv->f.
13759 (get_parent_class, emacs_fixed_set_min_size): Remove.
13760 (emacs_fixed_new): Set priv->f to argument.
13761 (emacs_fixed_get_preferred_width)
13762 (emacs_fixed_get_preferred_height): Use min_width/height from
13763 frames size_hint to set minimum and natural (Bug#8919).
13764 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13765 and use min_width/height from frames size_hint to set
13766 min_width/height (Bug#8919).
13767
13768 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13769 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13770 Fix indentation.
c7e73be5 13771
cf99dcf8
EZ
137722011-06-26 Eli Zaretskii <eliz@gnu.org>
13773
13774 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13775 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13776 called at ZV.
13777
029529ac
CY
137782011-06-26 Chong Yidong <cyd@stupidchicken.com>
13779
13780 * process.c (wait_reading_process_output): Bypass select if
13781 waiting for a cell while ignoring keyboard input, and input is
13782 pending. Suggested by Jan Djärv (Bug#8869).
13783
7a7ef429
PE
137842011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13785
13786 Use gnulib's dup2 module instead of rolling our own.
13787 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13788
11fdef7d 137892011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13790
13791 * dispnew.c (scrolling_window): Before scrolling, turn off a
13792 mouse-highlight in the window being scrolled.
13793
cd3520a4
JB
137942011-06-24 Juanma Barranquero <lekktu@gmail.com>
13795
13796 Move DEFSYM to lisp.h and use everywhere.
13797
13798 * character.h (DEFSYM): Move declaration...
13799 * lisp.h (DEFSYM): ...here.
13800
13801 * gnutls.c:
13802 * minibuf.c:
13803 * w32menu.c:
13804 * w32proc.c:
13805 * w32select.c: Don't include character.h.
13806
13807 * alloc.c (syms_of_alloc):
13808 * buffer.c (syms_of_buffer):
13809 * bytecode.c (syms_of_bytecode):
13810 * callint.c (syms_of_callint):
13811 * casefiddle.c (syms_of_casefiddle):
13812 * casetab.c (init_casetab_once):
13813 * category.c (init_category_once, syms_of_category):
13814 * ccl.c (syms_of_ccl):
13815 * cmds.c (syms_of_cmds):
13816 * composite.c (syms_of_composite):
13817 * dbusbind.c (syms_of_dbusbind):
13818 * dired.c (syms_of_dired):
13819 * dispnew.c (syms_of_display):
13820 * doc.c (syms_of_doc):
13821 * editfns.c (syms_of_editfns):
13822 * emacs.c (syms_of_emacs):
13823 * eval.c (syms_of_eval):
13824 * fileio.c (syms_of_fileio):
13825 * fns.c (syms_of_fns):
13826 * frame.c (syms_of_frame):
13827 * fringe.c (syms_of_fringe):
13828 * insdel.c (syms_of_insdel):
13829 * keymap.c (syms_of_keymap):
13830 * lread.c (init_obarray, syms_of_lread):
13831 * macros.c (syms_of_macros):
13832 * msdos.c (syms_of_msdos):
13833 * print.c (syms_of_print):
13834 * process.c (syms_of_process):
13835 * search.c (syms_of_search):
13836 * sound.c (syms_of_sound):
13837 * syntax.c (init_syntax_once, syms_of_syntax):
13838 * terminal.c (syms_of_terminal):
13839 * textprop.c (syms_of_textprop):
13840 * undo.c (syms_of_undo):
13841 * w32.c (globals_of_w32):
13842 * window.c (syms_of_window):
13843 * xdisp.c (syms_of_xdisp):
13844 * xfaces.c (syms_of_xfaces):
13845 * xfns.c (syms_of_xfns):
13846 * xmenu.c (syms_of_xmenu):
13847 * xsettings.c (syms_of_xsettings):
13848 * xterm.c (syms_of_xterm): Use DEFSYM.
13849
4228cf16
TZ
138502011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13851
cd3520a4 13852 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13853
7fcccf1e
PE
138542011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13855
7efb4e0e
PE
13856 Integer and buffer overflow fixes (Bug#8873).
13857
ff5844ad
PE
13858 * print.c (printchar, strout): Check for string overflow.
13859 (PRINTPREPARE, printchar, strout):
13860 Don't set size unless allocation succeeds.
13861
90532f02
PE
13862 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13863 for sizes. Check for string overflow more accurately.
13864 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13865
6d84508d
PE
13866 * macros.c: Integer and buffer overflow fixes.
13867 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13868 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13869 Use ptrdiff_t, not int, for sizes.
13870 Don't increment bufsize until after realloc succeeds.
13871 Check for size-calculation overflow.
13872 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13873
437b2cb4
PE
13874 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13875
8b9ac8b4
PE
13876 * lread.c: Integer overflow fixes.
13877 (read_integer): Radix is now EMACS_INT, not int,
13878 to improve quality of diagnostics for out-of-range radices.
13879 Calculate buffer size correctly for out-of-range radices.
13880 (read1): Check for integer overflow in radices, and in
13881 read-circle numbers.
82cb60d3
PE
13882 (read_escape): Avoid int overflow.
13883 (Fload, openp, read_buffer_size, read1)
13884 (substitute_object_recurse, read_vector, read_list, map_obarray):
13885 Use ptrdiff_t, not int, for sizes.
13886 (read1): Use EMACS_INT, not int, for sizes.
20270765 13887 Check for size overflow.
8b9ac8b4 13888
7fcccf1e
PE
13889 * image.c (cache_image): Check for size arithmetic overflow.
13890
bfbbd7e7
PE
13891 * lread.c: Integer overflow issues.
13892 (saved_doc_string_size, saved_doc_string_length)
13893 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13894 Now ptrdiff_t, not int.
13895 (read1): Don't assume doc string length fits in int. Check for
13896 out-of-range doc string lengths.
13897 (read_list): Don't assume file position fits in int.
39019e54 13898 (read_escape): Check for hex character overflow.
bfbbd7e7 13899
4e323265
LL
139002011-06-22 Leo Liu <sdl.web@gmail.com>
13901
13902 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13903 Move to minibuffer.el.
13904
85fece3e
PE
139052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13906
20b84ce9 13907 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13908 The following patches are for when GLYPH_DEBUG && !XASSERT.
13909 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13910 * dispnew.c (flush_stdout):
13911 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13912 Mark as externally visible.
13913 * dispnew.c (check_window_matrix_pointers): Now static.
13914 * dispnew.c (window_to_frame_vpos):
13915 * xfns.c (unwind_create_frame):
13916 * xterm.c (x_check_font): Remove unused local.
13917 * scroll.c (CHECK_BOUNDS):
13918 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13919 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13920 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13921 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13922 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13923 Now static.
13924 (debug_method_add): Use va_list and vsprintf rather than relying
13925 on undefined behavior with wrong number of arguments.
13926 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13927 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13928 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13929 since we're not interested in debugging glyphs with old libraries.
13930 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13931 GCC 4.6.0's static checking.
13932
0766b489
PE
139332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13934
31fd4b32
PE
13935 Integer overflow and signedness fixes (Bug#8873).
13936 A few related buffer overrun fixes, too.
13937
b79e8648
PE
13938 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13939
0766b489
PE
13940 * dispextern.h (struct face.stipple):
13941 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13942 (x_bitmap_mask, x_allocate_bitmap_record)
13943 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13944 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13945 (x_create_bitmap_from_xpm_data):
13946 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13947 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13948 (.bitmaps_last):
13949 * xfaces.c (load_pixmap):
13950 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13951 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13952 (.bitmaps_last, struct x_output.icon_bitmap):
13953 Use ptrdiff_t, not int, for bitmap indexes.
13954 (x_allocate_bitmap_record): Check for size overflow.
13955 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13956
b081724f
PE
13957 Use ptrdiff_t, not int, for overlay counts.
13958 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13959 * editfns.c (overlays_around, get_pos_property):
13960 * textprop.c (get_char_property_and_overlay):
13961 * xdisp.c (next_overlay_change, note_mouse_highlight):
13962 * xfaces.c (face_at_buffer_position):
21514da7
PE
13963 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13964 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13965 (Fnext_overlay_change, Fprevious_overlay_change)
13966 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13967 Use ptrdiff_t, not int, for sizes.
21514da7 13968 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13969
3de73e5e
PE
13970 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13971
2606c57b
PE
13972 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13973 (x_session_initialize): Do not assume string length fits in int.
13974
aaafe47a
PE
13975 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13976 This is unlikely, but can occur if DPI is outlandish.
13977
2674ddc8 13978 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13979 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13980
28154962
PE
13981 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13982 * xrdb.c (magic_file_p, search_magic_path):
13983 Omit last arg SUFFIX; it was always 0. All callers changed.
13984 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13985
7de51af5
PE
13986 * xfont.c (xfont_match): Avoid need for strlen.
13987
25ed6cc3
PE
13988 * xfns.c: Don't assume strlen fits in int.
13989 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13990
4eab31dd
PE
13991 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13992 not unsigned long, as we prefer signed integers. All callers changed.
13993 Detect integer overflow in repeat count.
13994 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13995 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13996
171e2a58
PE
13997 * termcap.c: Don't assume sizes fit in int and never overflow.
13998 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13999 (gobble_line): Check for size-calculation overflow.
14000
ad39faca 14001 * minibuf.c (Fread_buffer):
6e5bb2dc 14002 * lread.c (intern, intern_c_string):
74ca2eb3
PE
14003 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
14004 Don't assume string length fits in int.
14005
52c61c22 14006 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
14007 * gtkutil.c (style_changed_cb): Avoid need for strlen.
14008
b5b8c9e5
PE
14009 * font.c: Don't assume string length fits in int.
14010 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
14011 Use ptrdiff_t, not int.
ccd6111c
PE
14012 (font_intern_prop): Don't assume string length fits in int.
14013 Don't assume integer property fits in fixnum.
14014 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 14015
882f0d81 14016 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 14017 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
14018 Reformulate so as not to need the command string.
14019 Invoke gzip -cd rather than gunzip, as it's more portable.
14020 (lock_info_type, lock_file_1, lock_file):
14021 Don't assume pid_t and time_t fit in unsigned long.
14022 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
14023 (current_lock_owner): Prefer signed type for sizes.
14024 Use memcpy, not strncpy, where memcpy is what is really wanted.
14025 Don't assume (via atoi) that time_t and pid_t fit in int.
14026 Check for time_t and/or pid_t out of range, e.g., via a network share.
14027 Don't alloca where an auto var works fine.
14028
93f4cf88
PE
14029 * fileio.c: Fix some integer overflow issues.
14030 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
14031 Don't assume string length fits in int.
14032 (directory_file_name): Don't assume string length fits in long.
14033 (make_temp_name): Don't assume pid fits in int, or that its print
14034 length is less than 20.
14035
f3e92b69
PE
14036 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
14037
1bfdaf10
PE
14038 * coding.c (make_subsidiaries): Don't assume string length fits in int.
14039
35016e9a
PE
14040 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
14041
3d1e65a1
PE
14042 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
14043 We prefer signed integers, even for size calculations.
14044
0b963a93
PE
14045 * emacs.c: Don't assume string length fits in 'int'.
14046 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
14047 (main): Don't invoke strlen when not needed.
14048
573f4b54
PE
14049 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
14050 (XD_DEBUG_MESSAGE): Don't waste a byte.
14051
989f33ba
PE
14052 * callproc.c (getenv_internal_1, getenv_internal)
14053 (Fgetenv_internal):
965d34eb
PE
14054 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
14055
e4d29b33
PE
14056 * lread.c (invalid_syntax): Omit length argument.
14057 All uses changed. This doesn't fix a bug, but it simplifies the
14058 code away from its former Hollerith-constant appearance, and it's
14059 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 14060 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 14061
eb49b136
PE
14062 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
14063 This didn't break anything, but it didn't help either.
14064 It's confusing to put a bogus integer in a place where the actual
14065 value does not matter.
9f62aeb1 14066 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 14067 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 14068
15375a22
PE
14069 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
14070 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
14071 implementation.
b61cc01c
PE
14072 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
14073 We prefer signed types, and the value cannot exceed the EMACS_INT
14074 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
14075 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
14076 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
14077 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 14078
53b2623d
PE
14079 * indent.c (sane_tab_width): New function.
14080 (current_column, scan_for_column, Findent_to, position_indentation)
14081 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 14082 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 14083
51cab52b 14084 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 14085
f2ed8a70
PE
14086 * lisp.h (lint_assume): New macro.
14087 * composite.c (composition_gstring_put_cache):
14088 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
14089
abe80cc6
PE
14090 * editfns.c, insdel.c:
14091 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 14092
b02c740e
PE
14093 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
14094
ebc96716
PE
14095 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
14096
b4e50fa0 14097 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 14098 Use much-faster test for byte-length change.
311d5d7c 14099 Don't assume string byte-length fits in 'int'.
a4cf38e4 14100 Check that character arg fits in 'int'.
85461888 14101 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 14102
c0c1ee9f
PE
14103 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
14104
a498d7f4
PE
14105 * fns.c (concat): Catch string overflow earlier.
14106 Do not rely on integer wraparound.
14107
51cab52b
PE
14108 * dispextern.h (struct it.overlay_strings_charpos)
14109 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
14110 * xdisp.c (forward_to_next_line_start)
14111 (back_to_previous_visible_line_start)
14112 (reseat_at_next_visible_line_start, next_element_from_buffer):
14113 Don't arbitrarily truncate the value of 'selective' to int.
14114
76031fad
PE
14115 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
14116
5eb55db9
PE
14117 * composite.c: Don't truncate sizes to 'int'.
14118 (composition_gstring_p, composition_reseat_it)
14119 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
14120 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
14121 not EMACS_UINT, for indexes.
5eb55db9 14122
0703a717
PE
14123 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
14124
d6202519
PE
14125 * buffer.c: Include <verify.h>.
14126 (struct sortvec.priority, struct sortstr.priority):
8961a454 14127 Now EMACS_INT, not int.
c20998a7 14128 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
14129 (struct sortstr.size, record_overlay_string)
14130 (struct sortstrlist.size, struct sortlist.used):
14131 Don't truncate size to int.
14132 (record_overlay_string): Check for size-calculation overflow.
d6202519 14133 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 14134
d5a19415
JM
141352011-06-22 Jim Meyering <meyering@redhat.com>
14136
029529ac 14137 Don't leak an XBM-image-sized buffer
d5a19415
JM
14138 * image.c (xbm_load): Free the image buffer after using it.
14139
a9041e6c
PE
141402011-06-21 Paul Eggert <eggert@cs.ucla.edu>
14141
14142 Port to Sun C.
14143 * composite.c (find_automatic_composition): Omit needless 'return 0;'
14144 that Sun C diagnosed.
14145 * fns.c (secure_hash): Fix pointer signedness issue.
14146 * intervals.c (static_offset_intervals): New function.
14147 (offset_intervals): Use it.
14148
7f3f739f
LL
141492011-06-21 Leo Liu <sdl.web@gmail.com>
14150
14151 * deps.mk (fns.o):
14152 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
14153 sha512.h.
14154
14155 * fns.c (secure_hash): Rename from crypto_hash_function and change
14156 the first arg to accept symbols.
5b66d427 14157 (Fsecure_hash): New primitive.
7f3f739f
LL
14158 (syms_of_fns): New symbols.
14159
76147d94
DD
141602011-06-20 Deniz Dogan <deniz@dogan.se>
14161
14162 * process.c (Fset_process_buffer): Clarify return value in
14163 docstring.
14164
7d7d0045
CY
141652011-06-18 Chong Yidong <cyd@stupidchicken.com>
14166
14167 * dispnew.c (add_window_display_history): Use BVAR.
14168
14169 * xdisp.c (debug_method_add): Use BVAR.
14170 (check_window_end, dump_glyph_matrix, dump_glyph)
14171 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
14172
14173 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
14174 Likewise.
14175
14176 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
14177 check till after the cache is created in init_frame_faces.
14178
ff2bc410
SM
141792011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
14180
14181 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
14182
28177add
PE
141832011-06-16 Paul Eggert <eggert@cs.ucla.edu>
14184
dd3482fe
PE
14185 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
14186 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
14187 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
14188
393d71f3 14189 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
14190 * fileio.c (Finsert_file_contents):
14191 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
14192 Remove the old (too-loose) buffer overflow checks.
14193 They weren't needed, since make_gap checks for buffer overflow.
14194 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
14195 The old code merely checked for Emacs fixnum overflow, and relied
14196 on undefined (wraparound) behavior. The new code avoids undefined
14197 behavior, and also checks for ptrdiff_t and/or size_t overflow.
14198
2e6813b0 14199 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
14200 Tune. Don't use wider integers than needed. Don't use alloca.
14201 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 14202
599a9e4f
PE
14203 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
14204
99561444
PE
14205 * insdel.c, lisp.h (buffer_overflow): New function.
14206 (insert_from_buffer_1, replace_range, replace_range_2):
14207 * insdel.c (make_gap_larger):
14208 * editfns.c (Finsert_char):
14209 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
14210
28177add
PE
14211 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
14212
e69dafad
PE
142132011-06-15 Paul Eggert <eggert@cs.ucla.edu>
14214
4baa020d 14215 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 14216
b1c46f02
PE
14217 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
14218 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
14219
e69dafad
PE
14220 * fileio.c: Don't assume EMACS_INT fits in off_t.
14221 (emacs_lseek): New static function.
14222 (Finsert_file_contents, Fwrite_region): Use it.
14223 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
14224
566684ea
PE
14225 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
14226
e6966cd6
PE
14227 * fns.c: Don't overflow int when computing a list length.
14228 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
14229 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
14230 truncation on 64-bit hosts. Check for QUIT every
14231 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
14232 faster and is responsive enough.
14233 (Flength): Report an error instead of overflowing an integer.
14234 (Fsafe_length): Return a float if the value is not representable
14235 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 14236 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 14237 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 14238
dd0b0efb
PE
14239 * alloc.c: Check that resized vectors' lengths fit in fixnums.
14240 (header_size, word_size): New constants.
14241 (allocate_vectorlike): Don't check size overflow here.
14242 (allocate_vector): Check it here instead, since this is the only
14243 caller of allocate_vectorlike that could cause overflow.
14244 Check that the new vector's length is representable as a fixnum.
14245
86fe5cfe
PE
14246 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
14247 The previous code was bogus. For example, next_almost_prime (32)
14248 returned 39, which is undesirable as it is a multiple of 3; and
14249 next_almost_prime (24) returned 25, which is a multiple of 5 so
14250 why was the code bothering to check for multiples of 7?
14251
80e88859
PE
14252 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
14253
4a2f0ad6
PE
14254 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
14255
f66c7cf8
PE
14256 Variadic C functions now count arguments with ptrdiff_t.
14257 This partly undoes my 2011-03-30 change, which replaced int with size_t.
14258 Back then I didn't know that the Emacs coding style prefers signed int.
14259 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
14260 were being counted with int, which may truncate counts on 64-bit
14261 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
14262 * lisp.h (struct Lisp_Subr.function.aMANY)
14263 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
14264 Arg counts are now ptrdiff_t, not size_t.
14265 All variadic functions and their callers changed accordingly.
14266 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
14267 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
14268 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
14269 * callint.c (Fcall_interactively): Check arg count for overflow,
14270 to avoid potential buffer overrun. Use signed char, not 'int',
14271 for 'varies' array, so that we needn't bother to check its size
14272 calculation for overflow.
14273 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
14274 * eval.c (apply_lambda):
14275 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
14276 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
14277 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
14278
a1759b76
PE
14279 * callint.c (Fcall_interactively): Don't use index var as event count.
14280
d96be9fc
PE
14281 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
14282 * mem-limits.h (SIZE): Remove; no longer used.
14283
a690a978 14284 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 14285
578c21e6
PE
14286 Remove unnecessary casts.
14287 * xterm.c (x_term_init):
14288 * xfns.c (x_set_border_pixel):
14289 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
14290 These aren't needed now that we assume ANSI C.
14291
96f53c6c
PE
14292 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
14293 It's more likely to cause problems (due to unsigned overflow)
14294 than to cure them.
14295
83c77d31
PE
14296 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
14297
ee2079f1
PE
14298 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
14299
6da65536
PE
14300 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
14301
7147c4a4
PE
14302 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
14303
193e32d9
PE
14304 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
14305
e5533da6
PE
14306 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
14307
9910e595
PE
14308 GLYPH_CODE_FACE returns EMACS_INT, not int.
14309 * dispextern.h (merge_faces):
14310 * xfaces.c (merge_faces):
01103c44
PE
14311 * xdisp.c (get_next_display_element, next_element_from_display_vector):
14312 Don't assume EMACS_INT fits in int.
9910e595 14313
2638320e
PE
14314 * character.h (CHAR_VALID_P): Remove unused parameter.
14315 * fontset.c, lisp.h, xdisp.c: All uses changed.
14316
045eb8d9
PE
14317 * editfns.c (Ftranslate_region_internal): Omit redundant test.
14318
c1f134b5
PE
14319 * fns.c (concat): Minor tuning based on overflow analysis.
14320 This doesn't fix any bugs. Use int to hold character, instead
14321 of constantly refetching from Emacs object. Use XFASTINT, not
14322 XINT, for value known to be a character. Don't bother comparing
14323 a single byte to 0400, as it's always less.
14324
395fcb93 14325 * floatfns.c (Fexpt):
327eeec8
PE
14326 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
14327
abbd3d23
PE
14328 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
14329 for characters.
14330
684a03ef
PE
14331 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
14332
0fed43f3
PE
14333 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
14334 Without this fix, on a 64-bit host (aset S 0 4294967386) would
14335 incorrectly succeed when S was a string, because 4294967386 was
14336 truncated before it was used.
14337
8fd02eb7
PE
14338 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
14339 Otherwise, an out-of-range integer could cause undefined behavior
14340 on a 64-bit host.
14341
f8c86b69
PE
14342 * composite.c: Use int, not EMACS_INT, for characters.
14343 (fill_gstring_body, composition_compute_stop_pos): Use int, not
14344 EMACS_INT, for values that are known to be in character range.
14345 This doesn't fix any bugs but is the usual style inside Emacs and
14346 may generate better code on 32-bit machines.
14347
34206dd2
PE
14348 Make sure a 64-bit char is never passed to ENCODE_CHAR.
14349 This is for reasons similar to the recent CHAR_STRING fix.
14350 * charset.c (Fencode_char): Check that character arg is actually
14351 a character. Pass an int to ENCODE_CHAR.
14352 * charset.h (ENCODE_CHAR): Verify that the character argument is no
14353 wider than 'int', as a compile-time check to prevent future regressions
14354 in this area.
14355
c5958d4c 14356 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
14357
14358 Make sure a 64-bit char is never passed to CHAR_STRING.
14359 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
14360 by silently ignoring the top 32 bits, allowing some values
14361 that were far too large to be valid characters.
14362 * character.h: Include <verify.h>.
14363 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
14364 arguments are no wider than unsigned, as a compile-time check
14365 to prevent future regressions in this area.
14366 * data.c (Faset):
01103c44 14367 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
14368 (Fsubst_char_in_region):
14369 * fns.c (concat):
14370 * xdisp.c (decode_mode_spec_coding):
14371 Adjust to CHAR_STRING's new requirement.
14372 * editfns.c (Finsert_char, Fsubst_char_in_region):
14373 * fns.c (concat): Check that character args are actually
14374 characters. Without this test, these functions did the wrong
14375 thing with wildly out-of-range values on 64-bit hosts.
14376
d37ca623
PE
14377 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
14378 These casts should not be needed on 32-bit hosts, either.
14379 * keyboard.c (read_char):
14380 * lread.c (Fload): Remove casts to unsigned.
14381
ea204efb
PE
14382 * lisp.h (UNSIGNED_CMP): New macro.
14383 This fixes comparison bugs on 64-bit hosts.
14384 (ASCII_CHAR_P): Use it.
14385 * casefiddle.c (casify_object):
01103c44 14386 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
14387 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
14388 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
14389 * dispextern.h (FACE_FROM_ID):
14390 * keyboard.c (read_char): Use UNSIGNED_CMP.
14391
41cb286c
PE
14392 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
14393 not to EMACS_INT, to avoid GCC warning.
14394
4a1b9832
PE
14395 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
14396
55daad71
PE
14397 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
14398 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
14399 isn't needed on 32-bit machines.
8f95c75c 14400
01103c44
PE
14401 * buffer.c (Fgenerate_new_buffer_name):
14402 Use EMACS_INT for count, not int.
0ceccced 14403 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
14404
14405 * data.c (Qcompiled_function): Now static.
14406
c6f072e7
PE
14407 * window.c (window_body_lines): Now static.
14408
20ce5912
PE
14409 * image.c (gif_load): Rename local to avoid shadowing.
14410
9c4c5f81
PE
14411 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
14412 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
14413 * alloc.c (make_save_value): Integer argument is now of type
14414 ptrdiff_t, not int.
14415 (mark_object): Use ptrdiff_t, not int.
14416 * lisp.h (pD): New macro.
14417 * print.c (print_object): Use it.
14418
c0c5c8ae
PE
14419 * alloc.c: Use EMACS_INT, not int, to count objects.
14420 (total_conses, total_markers, total_symbols, total_vector_size)
14421 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
14422 (total_free_floats, total_floats, total_free_intervals)
14423 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
14424 Now EMACS_INT, not int. All uses changed.
14425 (Fgarbage_collect): Compute overall total using a double, so that
14426 integer overflow is less likely to be a problem. Check for overflow
14427 when converting back to an integer.
5a25e253
PE
14428 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
14429 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14430 These were 'int' variables that could overflow on 64-bit hosts;
14431 they were never used, so remove them instead of repairing them.
211a0b2a 14432 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
14433 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
14434 Previously, this ceilinged at INT_MAX, but that doesn't work on
14435 64-bit machines.
e46bb31a 14436 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 14437
c78baabf 14438 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 14439 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
14440 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
14441 when a (possibly-narrower) signed value would do just as well.
14442 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 14443
c9d624c6
PE
14444 * alloc.c: Catch some string size overflows that we were missing.
14445 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
14446 for convenience in STRING_BYTES_MAX.
14447 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
14448 The definition here is exact; the one in lisp.h was approximate.
14449 (allocate_string_data): Check for string overflow. This catches
14450 some instances we weren't catching before. Also, it catches
14451 size_t overflow on (unusual) hosts where SIZE_MAX <= min
14452 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14453 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 14454
c9d624c6
PE
14455 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
14456 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 14457 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 14458
353032ce
PE
14459 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
14460
2bccce07
PE
14461 * alloc.c (Fmake_string): Check for out-of-range init.
14462
0ac30604
SM
144632011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
14464
14465 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
14466
c195f2de
JD
144672011-06-14 Jan Djärv <jan.h.d@swipnet.se>
14468
14469 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
14470 xg_get_default_scrollbar_width.
14471
14472 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
14473 (int_gtk_range_get_value): Move to the scroll bar part of the file.
14474 (style_changed_cb): Call update_theme_scrollbar_width and call
14475 x_set_scroll_bar_default_width and xg_frame_set_char_size for
14476 all frames (Bug#8505).
14477 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
14478 Call gtk_window_set_resizable if HAVE_GTK3.
14479 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14480 and height if HAVE_GTK3 (Bug#8505).
14481 (scroll_bar_width_for_theme): New variable.
14482 (update_theme_scrollbar_width): New function.
14483 (xg_get_default_scrollbar_width): Move code to
14484 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
14485 (xg_initialize): Call update_theme_scrollbar_width.
14486
14487 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
14488
14489 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
14490
e10ac9f1
MR
144912011-06-12 Martin Rudalics <rudalics@gmx.at>
14492
14493 * frame.c (make_frame): Call other_buffer_safely instead of
14494 other_buffer.
14495
14496 * window.c (temp_output_buffer_show): Call display_buffer with
14497 second argument Vtemp_buffer_show_specifiers and reset latter
14498 immediately after the call.
14499 (Vtemp_buffer_show_specifiers): New variable.
14500 (auto_window_vscroll_p, next_screen_context_lines)
14501 (Vscroll_preserve_screen_position): Remove leading asterisks from
14502 doc-strings.
14503
2d3c217e 145042011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 14505
7b7f97e8 14506 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
14507 * buffer.c (Qclone_number): Remove for now, as it's unused.
14508 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
14509 (record_buffer): Remove unused local.
14510 * frame.c (other_visible_frames, frame_buffer_list): Now static.
14511 (set_frame_buffer_list): Remove; unused.
14512 * frame.h (other_visible_frames): Remove decl.
14513 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
14514 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
14515 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
14516 if HAVE_GPM.
14517 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14518 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
14519 Define only if HAVE_GPM.
14520 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
14521 (update_hints_inhibit): Remove; never set. All uses removed.
14522 * widgetprv.h (emacsFrameClassRec): Remove decl.
14523 * window.c (delete_deletable_window): Now returns void, since it
14524 wasn't returning anything.
14525 (compare_window_configurations): Remove unused locals.
14526 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
14527 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
14528 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
14529 the same widths as pointers. This follows up on the 2011-05-06 patch.
14530 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
14531 * xterm.h: Likewise.
14532 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
14533
1384b89e
JB
145342011-06-12 Juanma Barranquero <lekktu@gmail.com>
14535
14536 * makefile.w32-in: Update dependencies.
14537 (LISP_H): Add lib/intprops.h.
14538
1100a63c
CY
145392011-06-11 Chong Yidong <cyd@stupidchicken.com>
14540
14541 * image.c (gif_load): Add animation frame delay to the metadata.
14542 (syms_of_image): Use DEFSYM. New symbol `delay'.
14543
6198ccd0
MR
145442011-06-11 Martin Rudalics <rudalics@gmx.at>
14545
14546 * window.c (delete_deletable_window): Re-add.
14547 (Fset_window_configuration): Rewrite to handle dead buffers and
14548 consequently deletable windows.
14549 (window_tree, Fwindow_tree): Remove. Supply functionality in
14550 window.el.
14551 (compare_window_configurations): Simplify code.
14552
b6e3633c
AS
145532011-06-11 Andreas Schwab <schwab@linux-m68k.org>
14554
1ab0dee5
AS
14555 * image.c (imagemagick_load_image): Fix type mismatch.
14556 (Fimagemagick_types): Likewise.
14557
b6e3633c
AS
14558 * window.h (replace_buffer_in_windows): Declare.
14559
9397e56f
MR
145602011-06-11 Martin Rudalics <rudalics@gmx.at>
14561
14562 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
14563 Qclone_number. Remove external declaration of Qdelete_window.
14564 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
14565 code.
640c8776
SM
14566 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
14567 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
14568 (Fother_buffer): Rewrite doc-string. Major rewrite for new
14569 buffer list implementation.
14570 (other_buffer_safely): New function.
14571 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
14572 calls to replace_buffer_in_windows and
14573 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
14574 if allowed.
14575 (record_buffer): Inhibit quitting and rewrite using quittable
14576 functions. Run Qbuffer_list_update_hook if allowed.
14577 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
14578 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
14579 Move switch-to-buffer to window.el.
9397e56f
MR
14580 (bury-buffer): Move to window.el.
14581 (Vbuffer_list_update_hook): New variable.
14582
14583 * lisp.h (other_buffer_safely): Add prototype in buffer.c
14584 section.
14585
14586 * window.h (resize_frame_windows): Move up in code.
14587 (Fwindow_frame): Remove EXFUN.
14588 (replace_buffer_in_all_windows): Remove prototype.
14589 (replace_buffer_in_windows_safely): Add prototype.
14590
14591 * window.c: Declare Qdelete_window static again. Move down
14592 declaration of select_count.
14593 (Fnext_window, Fprevious_window): Rewrite doc-strings.
14594 (Fother_window): Move to window.el.
14595 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
14596 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
14597 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
14598 window.el.
14599 (replace_buffer_in_windows): Implement by calling
14600 Qreplace_buffer_in_windows.
14601 (replace_buffer_in_all_windows): Remove with some functionality
14602 moved into replace_buffer_in_windows_safely.
14603 (replace_buffer_in_windows_safely): New function.
14604 (select_window_norecord, select_frame_norecord): Move in front
14605 of run_window_configuration_change_hook. Remove now obsolete
14606 declarations.
640c8776
SM
14607 (Fset_window_buffer): Rewrite doc-string.
14608 Call Qrecord_window_buffer.
9397e56f
MR
14609 (keys_of_window): Move binding for other-window to window.el.
14610
b50691aa
CY
146112011-06-11 Chong Yidong <cyd@stupidchicken.com>
14612
14613 * dispextern.h (struct image): Replace data member, whose int_val
14614 and ptr_val fields were not used by anything, with a single
14615 lisp_val object.
14616
14617 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
14618 (gif_clear_image, gif_load, imagemagick_load_image)
14619 (gs_clear_image, gs_load): Callers changed.
14620
3f754b86
PE
146212011-06-10 Paul Eggert <eggert@cs.ucla.edu>
14622
cca69397
PE
14623 * buffer.h: Include <time.h>, for time_t.
14624 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
14625
109e28d0
PE
14626 Fix minor problems found by static checking.
14627
60737f02
PE
14628 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
14629
4b66faf3
PE
14630 Make identifiers static if they are not used in other modules.
14631 * data.c (Qcompiled_function, Qframe, Qvector):
14632 * image.c (QimageMagick, Qsvg):
14633 * minibuf.c (Qmetadata):
14634 * window.c (resize_window_check, resize_root_window): Now static.
14635 * window.h (resize_window_check, resize_root_window): Remove decls.
14636
109e28d0
PE
14637 * window.c (window_deletion_count, delete_deletable_window):
14638 Remove; unused.
46a4ce9e
PE
14639 (window_body_lines): Now static.
14640 (Fdelete_other_windows_internal): Mark vars as initialized.
14641 Make sure 'resize_failed' is initialized.
14642 (run_window_configuration_change_hook): Rename local to avoid shadowing.
14643 (resize_window_apply): Remove unused local.
14644 * window.h (delete_deletable_window): Remove decl.
14645
109e28d0 14646 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
14647 (imagemagick_load_image): Fix pointer signedness problem by changing
14648 last arg from unsigned char * to char *. All uses changed.
14649 Also, fix a local for similar reasons.
14650 Remove unused locals. Remove locals to avoid shadowing.
14651 (fn_rsvg_handle_free): Remove; unused.
14652 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 14653 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 14654
3f754b86
PE
14655 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
14656
2547adb1
CY
146572011-06-10 Chong Yidong <cyd@stupidchicken.com>
14658
14659 * image.c (gif_load): Fix omitted cast error introduced by
14660 2011-06-06 change.
14661
2c8e37d4
MR
146622011-06-10 Martin Rudalics <rudalics@gmx.at>
14663
14664 * window.h (resize_proportionally, orig_total_lines)
14665 (orig_top_line): Remove from window structure.
14666 (set_window_height, set_window_width, change_window_heights)
14667 (Fdelete_window): Remove prototypes.
14668 (resize_frame_windows): Remove duplicate declaration.
14669
440a42e3
EZ
146702011-06-10 Eli Zaretskii <eliz@gnu.org>
14671
14672 * window.h (resize_frame_windows, resize_window_check)
14673 (delete_deletable_window, resize_root_window)
14674 (resize_frame_windows): Declare prototypes.
14675
14676 * window.c (resize_window_apply): Make definition be "static" to
14677 match the prototype.
14678
562dd5e9
MR
146792011-06-10 Martin Rudalics <rudalics@gmx.at>
14680
14681 * window.c: Remove declarations of Qwindow_size_fixed,
14682 window_min_size_1, window_min_size_2, window_min_size,
14683 size_window, window_fixed_size_p, enlarge_window, delete_window.
14684 Remove static from declaration of Qdelete_window, it's
14685 temporarily needed by Fbury_buffer.
14686 (replace_window): Don't assign orig_top_line and
14687 orig_total_lines.
14688 (Fdelete_window, delete_window): Remove. Window deletion is
14689 handled by window.el.
640c8776
SM
14690 (window_loop): Remove DELETE_OTHER_WINDOWS case.
14691 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
14692 (Fdelete_other_windows): Remove. Deleting other windows is
14693 handled by window.el.
14694 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
14695 handled in window.el.
14696 (window_min_size_2, window_min_size_1, window_min_size): Remove.
14697 Window minimum sizes are handled in window.el.
14698 (shrink_windows, size_window, set_window_height)
14699 (set_window_width, change_window_heights, window_height)
14700 (window_width, CURBEG, CURSIZE, enlarge_window)
14701 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
14702 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
14703 handled in window.el.
14704 (make_dummy_parent): Rename to make_parent_window and give it a
14705 second argument horflag.
14706 (make_window): Don't set resize_proportionally any more.
14707 (Fsplit_window): Remove. Windows are split in window.el.
14708 (save_restore_action, save_restore_orig_size)
14709 (shrink_window_lowest_first, save_restore_orig_size): Remove.
14710 Resize mini windows in window.el.
14711 (grow_mini_window, shrink_mini_window): Implement by calling
14712 Qresize_root_window_vertically, resize_window_check and
14713 resize_window_apply.
640c8776
SM
14714 (saved_window, Fset_window_configuration, save_window_save):
14715 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
14716 resize_proportionally.
14717 (window_min_height, window_min_width): Move to window.el.
14718 (keys_of_window): Move bindings for delete-other-windows,
14719 split-window, delete-window and enlarge-window to window.el.
14720
14721 * buffer.c: Temporarily extern Qdelete_window.
14722 (Fbury_buffer): Temporarily call Qdelete_window instead of
14723 Fdelete_window (Fbury_buffer will move to window.el soon).
14724
14725 * frame.c (set_menu_bar_lines_1): Remove code handling
14726 orig_top_line and orig_total_lines.
14727
14728 * dispnew.c (adjust_frame_glyphs_initially): Don't use
14729 set_window_height but set heights directly.
14730 (change_frame_size_1): Use resize_frame_windows.
14731
14732 * xdisp.c (init_xdisp): Don't use set_window_height but set
14733 heights directly.
14734
640c8776
SM
14735 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
14736 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
14737 run_window_configuration_change_hook.
14738
14739 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
14740 instead of change_window_heights and run
14741 run_window_configuration_change_hook.
14742
1a13852e
MR
147432011-06-09 Martin Rudalics <rudalics@gmx.at>
14744
14745 * window.c (replace_window): Rename second argument REPLACEMENT to
14746 NEW. New third argument SETFLAG. Rewrite.
14747 (delete_window, make_dummy_parent): Call replace_window with
14748 third argument 1.
14749 (window_list_1): Move down in code.
14750 (run_window_configuration_change_hook): Move set_buffer part
14751 before select_frame_norecord part in order to unwind correctly.
14752 Rename count1 to count.
14753 (recombine_windows, delete_deletable_window, resize_root_window)
14754 (Fdelete_other_windows_internal)
14755 (Frun_window_configuration_change_hook, make_parent_window)
14756 (resize_window_check, resize_window_apply, Fresize_window_apply)
14757 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14758 (Fdelete_window_internal, Fresize_mini_window_internal):
14759 New functions.
1a13852e
MR
14760 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14761
f3d1777e
MR
147622011-06-08 Martin Rudalics <rudalics@gmx.at>
14763
496e208e
MR
14764 * window.h (window): Add some new members to window structure -
14765 normal_lines, normal_cols, new_total, new_normal, clone_number,
14766 splits, nest, prev_buffers, next_buffers.
14767 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14768 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14769
f3d1777e
MR
14770 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14771 Remove.
496e208e
MR
14772 (make_dummy_parent): Set new members of windows structure.
14773 (make_window): Move down in code. Handle new members of window
14774 structure.
14775 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14776 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14777 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14778 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14779 (Fset_window_next_buffers, Fset_window_clone_number):
14780 New functions.
496e208e
MR
14781 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14782 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14783 Doc-string fixes.
14784 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14785 Argument WINDOW can be now internal window too.
14786 (Fwindow_use_time): Move up in code.
14787 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14788 Rewrite doc-string.
14789 (Fset_window_configuration, saved_window)
14790 (Fcurrent_window_configuration, save_window_save): Handle new
14791 members of window structure.
b9e809c2
MR
14792 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14793 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14794 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14795 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14796 Qget_mru_window, Qresize_root_window,
14797 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14798 Qauto_buffer_name; staticpro them.
f3d1777e 14799
abde8f8c
MR
148002011-06-07 Martin Rudalics <rudalics@gmx.at>
14801
14802 * window.c (Fwindow_total_size, Fwindow_left_column)
14803 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14804 (Fwindow_list_1): New functions.
14805 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14806 (Fwindow_width, Fscroll_left, Fscroll_right):
14807 Use window_body_cols instead of window_box_text_cols.
14808 (delete_window, Fset_window_configuration):
14809 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14810 (delete_all_subwindows): Take a window as argument and not a
14811 structure. Rewrite.
190b47e6
MR
14812 (window_loop): Remove handling of GET_LRU_WINDOW and
14813 GET_LARGEST_WINDOW.
14814 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14815
14816 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14817 window_box_text_cols. delete_all_subwindows now takes a
14818 Lisp_Object as argument.
abde8f8c 14819
640c8776
SM
14820 * indent.c (compute_motion, Fcompute_motion):
14821 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14822
fa8a67e6
MR
14823 * frame.c (delete_frame): Call delete_all_subwindows with root
14824 window as argument.
14825
a54e3482
DC
148262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14827
14828 * fns.c (Fputhash): Document return value.
14829
60002bf5
CY
148302011-06-06 Chong Yidong <cyd@stupidchicken.com>
14831
14832 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14833
0c671da6 148342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14835
b862a52a 14836 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14837
be44ca6c
PE
14838 Check for overflow when converting integer to cons and back.
14839 * charset.c (Fdefine_charset_internal, Fdecode_char):
14840 Use cons_to_unsigned to catch overflow.
14841 (Fencode_char): Use INTEGER_TO_CONS.
14842 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14843 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14844 * data.c (long_to_cons, cons_to_long): Remove.
14845 (cons_to_unsigned, cons_to_signed): New functions.
14846 These signal an error for invalid or out-of-range values.
14847 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14848 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14849 * font.c (Ffont_variation_glyphs):
14850 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14851 * lisp.h: Include <intprops.h>.
14852 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14853 (cons_to_signed, cons_to_unsigned): New decls.
14854 (long_to_cons, cons_to_long): Remove decls.
14855 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14856 (Fprimitive_undo): Use CONS_TO_INTEGER.
14857 * xfns.c (Fx_window_property): Likewise.
14858 * xselect.c: Include <limits.h>.
14859 (x_own_selection, selection_data_to_lisp_data):
14860 Use INTEGER_TO_CONS.
14861 (x_handle_selection_request, x_handle_selection_clear)
14862 (x_get_foreign_selection, Fx_disown_selection_internal)
14863 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14864 (lisp_data_to_selection_data): Use cons_to_unsigned.
14865 (x_fill_property_data): Use cons_to_signed.
14866 Report values out of range.
14867
d1f3d2af
PE
14868 Check for buffer and string overflow more precisely.
14869 * buffer.h (BUF_BYTES_MAX): New macro.
14870 * lisp.h (STRING_BYTES_MAX): New macro.
14871 * alloc.c (Fmake_string):
14872 * character.c (string_escape_byte8):
14873 * coding.c (coding_alloc_by_realloc):
14874 * doprnt.c (doprnt):
14875 * editfns.c (Fformat):
14876 * eval.c (verror):
14877 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14878 since they may not be the same number.
14879 * editfns.c (Finsert_char):
14880 * fileio.c (Finsert_file_contents):
14881 Likewise for BUF_BYTES_MAX.
14882
dd52fcea
PE
14883 * image.c: Use ptrdiff_t, not int, for sizes.
14884 (slurp_file): Switch from int to ptrdiff_t.
14885 All uses changed.
14886 (slurp_file): Check that file size fits in both size_t (for
14887 malloc) and ptrdiff_t (for sanity and safety).
14888
7f9bbdbb
PE
14889 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14890 if b->modtime has its maximal value.
14891
dfe18f82
PE
14892 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14893
84acfcf0
PE
14894 Don't assume time_t can fit into int.
14895 * buffer.h (struct buffer.modtime): Now time_t, not int.
14896 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14897 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14898
ccd9a01a
PE
14899 Minor fixes for signed vs unsigned integers.
14900 * character.h (MAYBE_UNIFY_CHAR):
14901 * charset.c (maybe_unify_char):
14902 * keyboard.c (read_char, reorder_modifiers):
14903 XINT -> XFASTINT, since the integer must be nonnegative.
14904 * ftfont.c (ftfont_spec_pattern):
14905 * keymap.c (access_keymap, silly_event_symbol_error):
14906 XUINT -> XFASTINT, since the integer must be nonnegative.
14907 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14908 since it makes no difference and we prefer signed.
14909 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14910 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14911 nonnegative.
14912
d6d100dd
SM
149132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14914
14915 * window.h (Fwindow_frame): Declare.
14916
2b6148e4
PE
149172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14918
14919 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14920 (SPARE_MEMORY): Always define.
14921 (LARGE_REQUEST): Remove.
14922 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14923
f230ecc9
MR
149242011-06-06 Martin Rudalics <rudalics@gmx.at>
14925
727e958e
MR
14926 * lisp.h: Move EXFUNS for Fframe_root_window,
14927 Fframe_first_window and Fset_frame_selected_window to window.h.
14928
14929 * window.h: Move EXFUNS for Fframe_root_window,
14930 Fframe_first_window and Fset_frame_selected_window here from
14931 lisp.h.
14932
14933 * frame.c (Fwindow_frame, Fframe_first_window)
14934 (Fframe_root_window, Fframe_selected_window)
14935 (Fset_frame_selected_window): Move to window.c.
14936 (Factive_minibuffer_window): Move to minibuf.c.
14937 (Fother_visible_frames_p): New function.
14938
14939 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14940
f230ecc9
MR
14941 * window.c (decode_window, decode_any_window): Move up in code.
14942 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14943 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14944 (Fwindow_buffer): Move up and rewrite doc-string.
14945 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14946 (Fwindow_prev): New functions.
727e958e
MR
14947 (Fwindow_frame): Move here from frame.c. Accept any window as
14948 argument.
14949 (Fframe_root_window, Fframe_first_window)
14950 (Fframe_selected_window): Move here from frame.c. Accept frame
14951 or arbitrary window as argument. Update doc-strings.
14952 (Fminibuffer_window): Move up in code.
14953 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14954 (Fset_frame_selected_window): Move here from frame.c.
14955 Marginal rewrite.
727e958e
MR
14956 (Fselected_window, select_window, Fselect_window): Move up in
14957 code. Minor doc-string fixes.
f230ecc9 14958
4d09bcf6
PE
149592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14960
14961 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14962 Do not assume that spare memory exists; that assumption is valid
14963 only if SYSTEM_MALLOC.
14964 (LARGE_REQUEST): New macro, so that the issue of large requests
14965 is separated from the issue of spare memory.
14966
810928a2
AS
149672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14968
172418ad
AS
14969 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14970 format. (Bug#8806)
14971
43f862f7
AS
14972 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14973
810928a2
AS
14974 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14975 before statements.
14976
a059fe24
JD
149772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14978
14979 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14980
14981 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14982
14983 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14984 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14985
989bf368
JB
149862011-06-05 Juanma Barranquero <lekktu@gmail.com>
14987
14988 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14989
4b80f674
CY
149902011-06-04 Chong Yidong <cyd@stupidchicken.com>
14991
14992 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14993 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14994 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14995 New error handlers.
4b80f674
CY
14996 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14997 Obey Vx_select_enable_clipboard_manager. Catch errors in
14998 x_clipboard_manager_save (Bug#8779).
14999 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 15000 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 15001
99a33b77 150022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
15003
15004 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
15005
99a33b77 150062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
15007
15008 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
15009 in the current matrix if keep_current_p is non-zero.
15010
8264569d
EZ
150112011-06-04 Eli Zaretskii <eliz@gnu.org>
15012
15013 * bidi.c (bidi_level_of_next_char): Fix last change.
15014
57f97249
EZ
150152011-06-03 Eli Zaretskii <eliz@gnu.org>
15016
fec2107c 15017 Support bidi reordering of text covered by display properties.
57f97249 15018
fec2107c
EZ
15019 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
15020 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
15021 (bidi_cache_search, bidi_cache_iterator_state)
15022 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
15023 (bidi_level_of_next_char, bidi_move_to_visually_next):
15024 Support character positions inside a run of characters covered by a
fec2107c
EZ
15025 display string.
15026 (bidi_paragraph_init, bidi_resolve_explicit_1)
15027 (bidi_level_of_next_char): Call bidi_fetch_char and
15028 bidi_fetch_char_advance instead of FETCH_CHAR and
15029 FETCH_CHAR_ADVANCE.
15030 (bidi_init_it): Initialize new members.
15031 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
15032 definitions.
15033 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
15034 instead of using explicit *_CHAR codes.
d6d100dd
SM
15035 (bidi_resolve_explicit, bidi_resolve_weak):
15036 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
15037 bidirectional text is supported only in multibyte buffers.
15038 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
15039 it to initialize the frame_window_p member of struct bidi_it.
15040 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
15041 (bidi_resolve_explicit, bidi_resolve_weak)
15042 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
15043 bidi_it->nchars is non-positive.
15044 (bidi_level_of_next_char): Don't try to lookup the cache for the
15045 next/previous character if nothing is cached there yet, or if we
15046 were just reseat()'ed to a new position.
c40e2fb2 15047
0e14fe90
EZ
15048 * xdisp.c (set_cursor_from_row): Set start and stop points
15049 according to the row's direction when priming the loop that looks
15050 for the glyph on which to display cursor.
15051 (single_display_spec_intangible_p): Function deleted.
15052 (display_prop_intangible_p): Reimplement to call
15053 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
15054 Accept 3 additional arguments needed by handle_display_spec.
15055 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
15056 values: lists, `(when COND...)' forms, etc.
15057 (single_display_spec_string_p): Support property values that are
15058 lists with the argument STRING its top-level element.
15059 (display_prop_string_p): Fix the condition for processing a
15060 property that is a list to be consistent with handle_display_spec.
fec2107c 15061 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
15062 last portion of handle_display_prop.
15063 (compute_display_string_pos): Accept additional argument
15064 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
15065 value of a `display' property is a "replacing spec".
15066 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
15067 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
15068 the display property, but just return a value indicating whether
15069 the display property will replace the characters it covers.
15070 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
15071 frame_window_p members of struct bidi_it.
d6d100dd
SM
15072 (compute_display_string_pos, compute_display_string_end):
15073 New functions.
fec2107c
EZ
15074 (push_it): Accept second argument POSITION, where pop_it should
15075 jump to continue iteration.
15076 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 15077
fec2107c
EZ
15078 * keyboard.c (adjust_point_for_property): Adjust the call to
15079 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
15080
15081 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
15082 (bidi_init_it): Update prototypes.
15083 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
15084 (compute_display_string_pos, compute_display_string_end):
15085 Declare prototypes.
fec2107c
EZ
15086 (struct bidi_it): New members nchars and disp_pos. ch_len is now
15087 EMACS_INT.
fc6f18ce 15088
40087514 150892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 15090
57f53182
PE
15091 Malloc failure behavior now depends on size of allocation.
15092 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
15093 * lisp.h: Change signatures accordingly.
15094 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
15095 All callers changed. (Bug#8762)
15096
15097 * gnutls.c: Use Emacs's memory allocators.
15098 Without this change, the gnutls library would invoke malloc etc.
15099 directly, which causes problems on non-SYNC_INPUT hosts, and which
15100 runs afoul of improving memory_full behavior. (Bug#8761)
15101 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
15102 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
15103 xfree instead of the default malloc, realloc, free.
15104 (Fgnutls_boot): No need to check for memory allocation failure,
15105 since xmalloc does that for us.
15106
ac32cd99 15107 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
15108 * category.c (hash_get_category_set):
15109 * ccl.c (ccl_driver):
15110 * charset.c (Fdefine_charset_internal):
15111 * charset.h (struct charset.hash_index):
15112 * composite.c (get_composition_id, gstring_lookup_cache)
15113 (composition_gstring_put_cache):
15114 * composite.h (struct composition.hash_index):
15115 * dispextern.h (struct image.hash):
15116 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
15117 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
15118 (hashfn_equal, hashfn_user_defined, make_hash_table)
15119 (maybe_resize_hash_table, hash_lookup, hash_put)
15120 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
15121 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
15122 (Fsxhash, Fgethash, Fputhash, Fmaphash):
15123 * image.c (make_image, search_image_cache, lookup_image)
15124 (xpm_put_color_table_h):
15125 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 15126 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 15127 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 15128 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
15129 * alloc.c (allocate_vectorlike):
15130 Check for overflow in vector size calculations.
15131 * ccl.c (ccl_driver):
15132 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
15133 * fns.c, image.c: Remove unnecessary static decls that would otherwise
15134 need to be updated by these changes.
40087514
PE
15135 * fns.c (make_hash_table, maybe_resize_hash_table):
15136 Check for integer overflow with large hash tables.
0de4bb68
PE
15137 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
15138 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
15139 (SXHASH_REDUCE): New macro.
15140 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
15141 Use it instead of discarding useful hash info with large hash values.
15142 (sxhash_float): New function.
15143 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
15144 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
15145 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
15146 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
15147 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
15148 Adjust signatures to match updated version of code.
15149 (consing_since_gc): Now EMACS_INT, since a single hash table can
15150 use more than INT_MAX bytes.
15151
698d32e2
DN
151522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
15153
15154 Make it possible to build with GCC-4.6+ -O2 -flto.
15155
15156 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
15157
fd6fa53f
SM
151582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
15159
15160 * minibuf.c (get_minibuffer, read_minibuf_unwind):
15161 Call minibuffer-inactive-mode.
15162
864db017
JB
151632011-05-31 Juanma Barranquero <lekktu@gmail.com>
15164
15165 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
15166 Update dependencies.
15167
2ad0baf4
DN
151682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15169
15170 * data.c (init_data): Remove code for UTS, this system is not
15171 supported anymore.
15172
4fcc2638
DN
151732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15174
15175 Don't force ./temacs to start in terminal mode.
15176
15177 * frame.c (make_initial_frame): Initialize faces in all cases, not
15178 only when CANNOT_DUMP is defined.
15179 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
15180
c56e0fd5
DN
151812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15182
15183 * dispnew.c (add_window_display_history): Use const for the string
15184 pointer. Remove declaration, not needed.
15185
333d54da 151862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 15187
55d4c1b2 15188 Use 'inline', not 'INLINE'.
333d54da 15189 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
15190 * alloc.c, fontset.c (INLINE): Remove.
15191 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
15192 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
15193 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
15194 * gmalloc.c (register_heapinfo): Use inline unconditionally.
15195 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
15196
738db178
DN
151972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15198
15199 Make it possible to run ./temacs.
15200
15201 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
15202 syms_of_callproc does the same thing. Remove test for
15203 "initialized", do it in the caller.
15204 * emacs.c (main): Avoid calling set_initial_environment when dumping.
15205
620c53a6
SM
152062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
15207
15208 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
15209 (read_minibuf): Use get_minibuffer.
15210 (syms_of_minibuf): Use DEFSYM.
15211 (Qmetadata): New var.
15212 * data.c (Qbuffer): Don't make it static.
15213 (syms_of_data): Use DEFSYM.
15214
e003a292
PE
152152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
15216
15217 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
15218 (CCL_CODE_MIN): New macro.
15219
ed008a6d
PE
152202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
15221
3687c2ef
PE
15222 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
15223
ed008a6d
PE
15224 * eval.c (Qdebug): Now static.
15225 * lisp.h (Qdebug): Remove decl. This reverts a part of the
15226 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
15227 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
15228
d66c4c7c
CY
152292011-05-29 Chong Yidong <cyd@stupidchicken.com>
15230
15231 * image.c: Various fixes to ImageMagick code comments.
15232 (Fimagemagick_types): Doc fix.
15233
5fbc2025
PE
152342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
15235
0196f88a
PE
15236 Minor fixes prompted by GCC 4.6.0 warnings.
15237
15238 * xselect.c (converted_selections, conversion_fail_tag): Now static.
15239
5fbc2025
PE
15240 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
15241 (x_clipboard_manager_save_all): Move extern decl to ...
15242 * xterm.h: ... here, so that it can be checked for consistency.
15243
1dd3c2d9
CY
152442011-05-29 Chong Yidong <cyd@stupidchicken.com>
15245
15246 * xselect.c (x_clipboard_manager_save_frame)
15247 (x_clipboard_manager_save_all): New functions.
15248 (Fx_clipboard_manager_save): Lisp function deleted.
15249
15250 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
15251 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
15252
15253 * xterm.h: Update prototype.
15254
5ba6571d
WX
152552011-05-28 William Xu <william.xwl@gmail.com>
15256
15257 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
15258 exiting (Bug#8239).
15259
3eaff834
JM
152602011-05-28 Jim Meyering <meyering@redhat.com>
15261
e1900994 15262 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
15263 * fns.c (to_uchar): Define.
15264 (crypto_hash_function): Use it to convert some newly-signed
15265 variables to unsigned, to avoid sign-extension bugs. For example,
15266 without this change, (md5 "truc") would evaluate to
15267 45723a2aff78ff4fff7fff1114760e62 rather than the expected
15268 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 15269 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 15270
0f6990a7
PE
152712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15272
15273 Integer overflow fixes.
c8a9ca5a 15274
08686060
PE
15275 * dbusbind.c: Serial number integer overflow fixes.
15276 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
15277 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
15278 to hold a serial number that is too large for a fixnum.
15279 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15280 Check for serial numbers out of range. Decode any serial number
59568bf0 15281 that was so large that it became a float. (Bug#8722)
08686060 15282
2d1fc3c7
PE
15283 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
15284 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15285 Use XFASTINT rather than XUINT when numbers are nonnegative.
15286 (xd_append_arg, Fdbus_method_return_internal):
15287 (Fdbus_method_error_internal): Likewise. Also, for unsigned
15288 arguments, check that Lisp number is nonnegative, rather than
59568bf0 15289 silently wrapping negative numbers around. (Bug#8722)
30217ff0 15290 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 15291 (Bug#8722)
2d1fc3c7 15292
c8a9ca5a
PE
15293 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
15294
519e1d69
PE
15295 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
15296
6df6ae42 15297 ccl: Add integer overflow checks.
30569699
PE
15298 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
15299 (IN_INT_RANGE): New macros.
15300 (ccl_driver): Use them to check for integer overflow when
15301 decoding a CCL program. Many of the new checks are whether XINT (x)
15302 fits in int; it doesn't always, on 64-bit hosts. The new version
15303 doesn't catch all possible integer overflows, but it's an
847044ea 15304 improvement. (Bug#8719)
30569699 15305
c11285dc
PE
15306 * alloc.c (make_event_array): Use XINT, not XUINT.
15307 There's no need for unsigned here.
15308
fdccd48e
PE
15309 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
15310 This follows up to the 2011-05-06 change that substituted uintptr_t
15311 for EMACS_INT. This case wasn't caught back then.
15312
37910ab2
PE
15313 Rework Fformat to avoid integer overflow issues.
15314 * editfns.c: Include <float.h> unconditionally, as it's everywhere
15315 now (part of C89). Include <verify.h>.
15316 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
15317 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
15318 (Fformat): Avoid the prepass trying to compute sizes; it was only
15319 approximate and thus did not catch overflow reliably. Instead, walk
15320 through the format just once, formatting and computing sizes as we go,
15321 checking for integer overflow at every step, and allocating a larger
15322 buffer as needed. Keep track separately whether the format is
15323 multibyte. Keep only the most-recently calculated precision, rather
15324 than them all. Record whether each argument has been converted to
15325 string. Use EMACS_INT, not int, for byte and char and arg counts.
15326 Support field widths and precisions larger than INT_MAX. Avoid
15327 sprintf's undefined behavior with conversion specifications such as %#d
15328 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
15329 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
15330 formatting out-of-range floating point numbers with int
9173deec 15331 formats. (Bug#8668)
37910ab2 15332
2e6578fb
PE
15333 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
15334
0ae6bdee
PE
15335 * data.c: Avoid integer truncation in expressions involving floats.
15336 * data.c: Include <intprops.h>.
15337 (arith_driver): When there's an integer overflow in an expression
15338 involving floating point, convert the integers to floating point
15339 so that the resulting value does not suffer from catastrophic
15340 integer truncation. For example, on a 64-bit host (* 4
15341 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
15342 Do not rely on undefined behavior after integer overflow.
15343
de883a70
PE
15344 merge count_size_as_multibyte, parse_str_to_multibyte
15345 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 15346 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
15347 Check for integer overflow.
15348 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
15349 since it's now a duplicate of the other. This is more of
15350 a character than a buffer op, so better that it's in character.c.
15351 * fns.c, print.c: Adjust to above changes.
15352
2ff916cb
PE
153532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
15354
15355 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
15356
f1b54466
PE
153572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15358
fb1ac845
PE
15359 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15360 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
15361 (x_clipboard_manager_save): Now static.
15362 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
15363
f1b54466
PE
15364 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15365 (crypto_hash_function): Now static.
15366 Fix pointer signedness problems. Avoid unnecessary initializations.
15367
a9f737ee
CY
153682011-05-27 Chong Yidong <cyd@stupidchicken.com>
15369
15370 * termhooks.h (Vselection_alist): Make it terminal-local.
15371
15372 * terminal.c (create_terminal): Initialize it.
15373
15374 * xselect.c: Support for clipboard managers.
15375 (Vselection_alist): Move to termhooks.h as terminal-local var.
15376 (LOCAL_SELECTION): New macro.
15377 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
15378 (symbol_to_x_atom): Remove gratuitous arg.
15379 (x_handle_selection_request, lisp_data_to_selection_data)
15380 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
15381 (x_own_selection, x_get_local_selection, x_convert_selection):
15382 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
15383 (some_frame_on_display): Delete unused function.
15384 (Fx_own_selection_internal, Fx_get_selection_internal)
15385 (Fx_disown_selection_internal, Fx_selection_owner_p)
15386 (Fx_selection_exists_p): New optional frame arg.
15387 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
15388 (x_handle_selection_clear): Don't treat other terminals with the
15389 same keyboard specially. Use the terminal-local Vselection_alist.
15390 (x_clear_frame_selections): Use Frun_hook_with_args.
15391
15392 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
15393
15394 * xterm.h: Add support for those atoms.
15395
e067f0c1
CY
153962011-05-26 Chong Yidong <cyd@stupidchicken.com>
15397
15398 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
15399 (converted_selections, conversion_fail_tag): New global variables.
15400 (x_selection_request_lisp_error): Free the above.
15401 (x_get_local_selection): Remove unnecessary code.
15402 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
15403 of converted selections stored in converted_selections.
15404 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
15405 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
15406 (x_convert_selection): New function.
15407 (x_handle_selection_event): Simplify.
15408 (x_get_foreign_selection): Don't ignore incoming requests while
15409 waiting for an answer; this will fail when we implement
15410 SAVE_TARGETS, and seems unnecessary anyway.
15411 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
15412 (Vx_sent_selection_functions): Doc fix.
15413
0f4aebc0
LL
154142011-05-26 Leo Liu <sdl.web@gmail.com>
15415
15416 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
15417
e61124cd
YM
154182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15419
15420 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
15421
15422 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
15423 for fringe update if it has periodic bitmap.
ac389d0c 15424 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
15425 and fringe_bitmap_periodic_p.
15426
15427 * fringe.c (get_fringe_bitmap_data): New function.
15428 (draw_fringe_bitmap_1, update_window_fringes): Use it.
15429 (update_window_fringes): Record periodicity of fringe bitmap in glyph
15430 row. Mark glyph row for fringe update if periodicity changed.
15431
15432 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
15433 for fringe update unless it has periodic bitmap.
15434
f16d9837
KH
154352011-05-25 Kenichi Handa <handa@m17n.org>
15436
15437 * xdisp.c (get_next_display_element): Set correct it->face_id for
15438 a static composition.
15439
e1b90ef6
LL
154402011-05-24 Leo Liu <sdl.web@gmail.com>
15441
15442 * deps.mk (fns.o):
15443 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
15444
15445 * fns.c (crypto_hash_function, Fsha1): New function.
15446 (Fmd5): Use crypto_hash_function.
15447 (syms_of_fns): Add Ssha1.
15448
7400048f
PE
154492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15450
15451 * gnutls.c: Remove unused macros.
15452 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
15453 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
15454 Remove macros that are defined and never used.
15455 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
15456
abb71cf4
CY
154572011-05-22 Chong Yidong <cyd@stupidchicken.com>
15458
15459 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
15460 (Fx_get_selection_internal): Minor cleanup.
15461 (Fx_own_selection_internal): Rename arguments for consistency with
15462 select.el.
15463
6307db39
PE
154642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15465
15466 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
15467
f3d4e0a4
CY
154682011-05-22 Chong Yidong <cyd@stupidchicken.com>
15469
15470 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
15471
4d8ade89
YM
154722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15473
15474 * dispnew.c (scrolling_window): Don't exclude the case that the
15475 last enabled row in the desired matrix touches the bottom boundary.
15476
32078c8d
GM
154772011-05-21 Glenn Morris <rgm@gnu.org>
15478
15479 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
15480 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
15481 and add some more files.
32078c8d 15482
7285dc67
EZ
154832011-05-20 Eli Zaretskii <eliz@gnu.org>
15484
15485 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15486 report_file_error introduced by the change from 2011-05-07.
15487
89d1bd22
PE
154882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
15489
15490 * systime.h (Time): Define only if emacs is defined.
15491 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
15492 where the include path doesn't have X11/X.h by default. See
15493 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
15494
cd394be1 154952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
15496
15497 * composite.c (find_automatic_composition): Fix previous change.
15498
b9704ad9
GM
154992011-05-20 Glenn Morris <rgm@gnu.org>
15500
15501 * lisp.mk: New file, split from Makefile.in.
15502 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
15503 (shortlisp): Remove.
15504 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
15505
4a720484
GM
155062011-05-19 Glenn Morris <rgm@gnu.org>
15507
15508 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15509 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
15510 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
15511 (lisp): Set the order to that of loadup.el.
15512 (shortlisp): Make it a copy of $lisp.
15513 (SOME_MACHINE_LISP): Remove.
15514 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
15515 Use just $shortlisp, not $SOME_MACHINE_LISP too.
15516
a28d4396
KH
155172011-05-18 Kenichi Handa <handa@m17n.org>
15518
15519 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15520 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
15521 (find_automatic_composition): Mostly rewrite for efficiency.
15522
a2b1fa8e
JB
155232011-05-18 Juanma Barranquero <lekktu@gmail.com>
15524
15525 * makefile.w32-in: Update dependencies.
15526
8e1f5610
CS
155272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
15528
15529 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 15530 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 15531
7025ee00 155322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 15533
cdfa6eab
PE
15534 Fix some integer overflow issues, such as string length overflow.
15535
06d6db33
PE
15536 * insdel.c (count_size_as_multibyte): Check for string overflow.
15537
2b4560a8
PE
15538 * character.c (lisp_string_width): Check for string overflow.
15539 Use EMACS_INT, not int, for string indexes and lengths; in
15540 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15541 the resulting string length overflows an EMACS_INT; instead,
15542 report a string overflow if no precision given. When checking for
15543 precision exhaustion, use a check that cannot possibly have
15544 integer overflow. (Bug#8675)
15545 * character.h (lisp_string_width): Adjust to new signature.
15546
cb93f9be
PE
15547 * alloc.c (string_overflow): New function.
15548 (Fmake_string): Use it. This doesn't change behavior, but saves
15549 a few bytes and will simplify future changes.
15550 * character.c (string_escape_byte8): Likewise.
15551 * lisp.h (string_overflow): New decl.
15552
1a1f3366
PE
15553 Fixups, following up to the user-interface timestamp change.
15554 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
15555 for UI timestamps, instead of unsigned long.
9fbd6841
PE
15556 * msdos.c (mouse_get_pos): Likewise.
15557 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
15558 * w32gui.h (Time): Define by including "systime.h" rather than by
15559 declaring it ourselves. (Bug#8664)
15560
d4e3e4d3
PE
15561 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
15562 * image.c (clear_image_cache): Likewise.
15563
f6a24d19
PE
15564 * term.c (term_mouse_position): Don't assume time_t wraparound.
15565
08dc5ae6
PE
15566 Be more systematic about user-interface timestamps.
15567 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
15568 and sometimes 'EMACS_UINT', to represent these timestamps.
15569 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
15570 This makes the code easier to follow, and makes it easier to catch
15571 integer overflow bugs such as Bug#8664.
15572 * frame.c (Fmouse_position, Fmouse_pixel_position):
15573 Use Time, not unsigned long, for user-interface timestamps.
15574 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
15575 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
15576 * keyboard.h (last_event_timestamp): Likewise.
15577 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15578 * menu.h (xmenu_show): Likewise.
15579 * term.c (term_mouse_position): Likewise.
15580 * termhooks.h (struct input_event.timestamp): Likewise.
15581 (struct terminal.mouse_position_hook): Likewise.
15582 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
15583 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
15584 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
15585 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
15586 what it was before.
15587 * menu.h, termhooks.h: Include "systime.h", for Time.
15588
8e55734a
PE
15589 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
15590 Don't assume that the difference between two unsigned long values
15591 can fit into an integer. At this point, we know button_down_time
15592 <= event->timestamp, so the difference must be nonnegative, so
15593 there's no need to cast the result if double-click-time is
15594 nonnegative, as it should be; check that it's nonnegative, just in
15595 case. This bug is triggered when events are more than 2**31 ms
86db42d2 15596 apart (about 25 days). (Bug#8664)
8e55734a 15597
841f1b75 15598 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 15599 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 15600
3e26f69c
PE
15601 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
15602 that always fit in int. Use a sentinel instead of a counter, to
15603 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
15604 * frame.h (struct frame): Use int for menu_bar_items_used
15605 instead of EMACS_INT, since it always fits in int.
3e26f69c 15606
5cc152c0
PE
15607 * menu.c (grow_menu_items): Check for int overflow.
15608
d89eb65e
PE
15609 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
15610
5235bd3e
PE
15611 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
15612 Before, the code was not consistent. These values cannot exceed
15613 2**31 - 1 so there's no need to make them unsigned.
15614 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
15615 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
15616 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
15617 as modifiers.
15618 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15619
bc827e23
PE
15620 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
15621 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
15622 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15623 presumably because the widths might not match.
15624
78eb494e
PE
15625 * window.c (size_window): Avoid needless test at loop start.
15626
04f2d78b
CB
156272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
15628
15629 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
15630
d2fc7e3d 156312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
15632
15633 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
15634
d2fc7e3d 156352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
15636
15637 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
15638 `width' to `bar_area_x' and `bar_area_width', respectively.
15639 (x_scroll_run): Take account of fringe background extension.
15640
04f2d78b
CB
15641 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
15642 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
15643 `bar_area_width', respectively.
15644 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
15645 background extension.
15646
79b70037
GM
156472011-05-10 Jim Meyering <meyering@redhat.com>
15648
15649 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
15650
2f142cc5
JB
156512011-05-10 Juanma Barranquero <lekktu@gmail.com>
15652
15653 * image.c (Finit_image_library): Return t for built-in image types,
15654 like pbm and xbm. (Bug#8640)
15655
57679c86
AS
156562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
15657
15658 * w32menu.c (set_frame_menubar): Fix submenu allocation.
15659
888c9e86
EZ
156602011-05-07 Eli Zaretskii <eliz@gnu.org>
15661
b0512a1d
EZ
15662 * w32console.c (Fset_screen_color): Doc fix.
15663 (Fget_screen_color): New function.
15664 (syms_of_ntterm): Defsubr it.
15665
7285dc67
EZ
15666 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
15667 unlink the temporary file if Fcall_process didn't create it in the
15668 first place.
15669 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
15670 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
15671 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
15672 cue to call_process_cleanup not to close that handle.
15673
4d3fcc8e
BK
156742011-05-07 Ben Key <bkey76@gmail.com>
15675
15676 * makefile.w32-in: The bootstrap-temacs rule now makes use of
15677 one of two shell specific rules, either bootstrap-temacs-CMD or
15678 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
15679 to the previous implementation of the bootstrap-temacs rule.
15680 The bootstrap-temacs-CMD rule is similar to the previous
15681 implementation of the bootstrap-temacs rule except that it
15682 makes use of the ESC_CFLAGS variable instead of the CFLAGS
15683 variable.
15684
15685 These changes, along with some changes to nt/configure.bat,
15686 nt/gmake.defs, and nt/nmake.defs, are required to extend my
15687 earlier fix to add support for --cflags and --ldflags options
15688 that include quotes so that it works whether make uses cmd or
15689 sh as the shell.
15690
b4289b64
MA
156912011-05-06 Michael Albinus <michael.albinus@gmx.de>
15692
15693 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
15694 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
15695 is a constant.
15696 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
15697 a string. Handle both cases.
15698 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
15699 (Fdbus_register_method): Use Qinvalid_function.
15700
af4c0e28
JB
157012011-05-06 Juanma Barranquero <lekktu@gmail.com>
15702
15703 * makefile.w32-in: Update dependencies.
15704 (LISP_H): Add inttypes.h and stdin.h.
15705 (PROCESS_H): Add unistd.h.
15706
c51453d9
EZ
157072011-05-06 Eli Zaretskii <eliz@gnu.org>
15708
15709 * lread.c: Include limits.h (fixes the MS-Windows build broken by
15710 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
15711
8ff0ac3c 157122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 15713
4c4b566b
PE
15714 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
15715
aab2b9b5
PE
15716 * term.c (vfatal): Remove stray call to va_end.
15717 It's not needed and the C Standard doesn't allow it here anyway.
15718
c378da0b
PE
15719 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
15720 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
15721
288b08c7
PE
15722 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
15723 bytes.
15724
e3601888
PE
15725 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15726
db6c0e74
PE
15727 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15728
dd5963ea
PE
15729 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
15730
88c9450f
PE
15731 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
15732
2f9442b8
PE
15733 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
15734
c032b5f8
PE
15735 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
15736 * charset.c (Fdefine_charset_internal): Don't initialize
15737 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 15738 32-bit int (Bug#8600).
a108c10b
PE
15739
15740 * lread.c (read_integer): Be more consistent with string-to-number.
15741 Use string_to_number to do the actual conversion; this avoids
15742 rounding errors and fixes some other screwups. Without this fix,
15743 for example, #x1fffffffffffffff was misread as -2305843009213693952.
15744 (digit_to_number): Move earlier, for benefit of read_integer.
15745 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 15746 not a digit in any supported base. (Bug#8602)
a108c10b 15747
ad5f9eea
PE
15748 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15749
aec1708a
PE
15750 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15751 to match comment at start of function. This also removes a
15752 GCC warning about overflow in a 32+64-bit port.
15753
47be4ab5
PE
15754 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15755
371cac43
PE
15756 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15757 Reported by Stefan Monnier in
15758 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15759 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15760 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15761
d01a7826
PE
15762 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15763 (EMACS_UINTPTR): Likewise, with uintptr_t.
15764
7fd47d5c
PE
15765 * lisp.h: Prefer 64-bit EMACS_INT if available.
15766 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15767 on 32-bit hosts that have 64-bit int, so that they can access
15768 large files.
122b0c86
PE
15769 However, temporarily disable this change unless the temporary
15770 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15771
8727937b
PE
15772 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15773
8ac068ac
PE
15774 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15775 This removes an assumption that EMACS_INT and long are the same
15776 width as pointers. The assumption is true for Emacs porting targets
15777 now, but we want to make other targets possible.
15778 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15779 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15780 In the rest of the code, change types of integers that hold casted
15781 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15782 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15783 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15784 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15785 No need to cast type when ORing.
15786 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15787 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15788 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15789 assume EMACS_INT is the same width as char *.
15790 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15791 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15792 Remove no-longer-needed casts.
15793 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15794 (xg_tool_bar_help_callback, xg_make_tool_item):
15795 Use EMACS_INTPTR to hold an integer
15796 that will be cast to void *; this can avoid a GCC warning
15797 if EMACS_INT is not the same width as void *.
15798 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15799 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15800 (current_message_1, set_message_1):
15801 Use a local to convert to proper width without a cast.
15802 * xmenu.c (dialog_selection_callback): Likewise.
15803
ede49d71
PE
15804 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15805 Also, don't assume VALBITS / RAND_BITS is less than 5,
15806 and don't rely on undefined behavior when shifting a 1 left into
15807 the sign bit.
15808 * lisp.h (get_random): Change signature to match.
15809
2f30ecd0
PE
15810 * lread.c (hash_string): Use size_t, not int, for hash computation.
15811 Normally we prefer signed values; but hashing is special, because
15812 it's better to use unsigned division on hash table sizes so that
15813 the remainder is nonnegative. Also, size_t is the natural width
15814 for hashing into memory. The previous code used 'int', which doesn't
15815 retain enough info to hash well into very large tables.
15816 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15817
2a866e7b
PE
15818 * dbusbind.c: Don't possibly lose pointer info when converting.
15819 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15820 Use XPNTR rather than XHASH, so that the high-order bits of
15821 the pointer aren't lost when converting through void *.
15822
51639eac
PE
15823 * eval.c (Fautoload): Don't double-shift a pointer.
15824
92394119
PE
15825 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15826
dbdb9a7c
JB
158272011-05-06 Juanma Barranquero <lekktu@gmail.com>
15828
15829 * gnutls.c (DEF_GNUTLS_FN):
15830 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15831
db7a0b4f
AS
158322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15833
15834 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15835 marker. (Bug#8610)
15836
cd394be1 158372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15838
15839 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15840 New version that can reserve upto 2GB of heap space.
15841
f7ff1b0f 158422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15843
15844 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15845
639c109b
TZ
158462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15847
15848 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15849 `gnutls_certificate_set_x509_key_file'.
15850
d2127135
JB
158512011-05-05 Juanma Barranquero <lekktu@gmail.com>
15852
15853 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15854 Update dependencies.
15855
e968f4f3
JB
158562011-05-04 Juanma Barranquero <lekktu@gmail.com>
15857
15858 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15859 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15860 Remove unused parameter `fildes'.
15861 * process.c (read_process_output, send_process): Don't pass it.
15862
84d358f0
JB
158632011-05-04 Juanma Barranquero <lekktu@gmail.com>
15864
15865 Fix previous change: the library cache is defined in w32.c.
15866 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15867 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15868
0898ca10
JB
158692011-05-04 Juanma Barranquero <lekktu@gmail.com>
15870
15871 Implement dynamic loading of GnuTLS on Windows.
15872
15873 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15874 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15875 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15876 Declare.
15877
15878 * gnutls.c (Qgnutls_dll): Define.
15879 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15880 (gnutls_*): Declare function pointers.
15881 (init_gnutls_functions): New function to initialize function pointers.
15882 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15883 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15884 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15885 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15886 (emacs_gnutls_write, emacs_gnutls_read)
15887 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15888 (Fgnutls_available_p): New function.
15889 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15890 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15891 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15892
15893 * image.c: Include w32.h.
15894 (Vimage_type_cache): Delete.
15895 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15896 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15897 (w32_delayed_load): Move to w32.c.
15898
15899 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15900
15901 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15902 (w32_delayed_load): Move from image.c. When loading a library, record
15903 its filename in the :loaded-from property of the library id.
15904 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15905 Initialize and staticpro them.
15906 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15907
15908 * process.c: Include lisp.h before w32.h, not after.
15909 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15910 instead of gnutls_record_check_pending.
15911
15912 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15913
ff4de4aa
TZ
159142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15915
15916 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15917 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15918 as passed in.
15919
abe95abb
JD
159202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15921
15922 * xterm.c (x_set_frame_alpha): Do not set property on anything
15923 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15924
e16e55d4
JB
159252011-05-02 Juanma Barranquero <lekktu@gmail.com>
15926
15927 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15928
bafcf6a5
JB
159292011-05-02 Juanma Barranquero <lekktu@gmail.com>
15930
15931 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15932 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15933 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15934 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15935 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15936 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15937 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15938 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15939 (Qgnutls_bootprop_callbacks_verify): Make static.
15940
e7a6747f
AS
159412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15942
19ed11ba
AS
15943 * callproc.c: Indentation fixup.
15944
e7a6747f 15945 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15946 (wait_for_termination, interruptible_wait_for_termination):
15947 Move after wait_for_termination_1.
e7a6747f 15948
1ef14cb4
LMI
159492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15950
15951 * sysdep.c (interruptible_wait_for_termination): New function
15952 which is like wait_for_termination, but allows keyboard
15953 interruptions.
15954
15955 * callproc.c (Fcall_process): Add (:file "file") as an option for
15956 the STDOUT buffer.
15957 (Fcall_process_region): Ditto.
15958
330d880c
EZ
159592011-04-30 Eli Zaretskii <eliz@gnu.org>
15960
8db90b73
EZ
15961 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15962 rather than `XVECTOR (FOO)->size'.
15963
330d880c
EZ
15964 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15965 inttypes.h, as a gnulib replacement is used if it not available in
15966 system headers.
15967
15cbd324
EZ
159682011-04-21 Eli Zaretskii <eliz@gnu.org>
15969
15970 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15971 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15972 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15973
15974 * coding.c (coding_alloc_by_realloc): Error out if destination
15975 will grow beyond MOST_POSITIVE_FIXNUM.
15976 (decode_coding_emacs_mule): Abort if there isn't enough place in
15977 charbuf for the composition carryover bytes. Reserve an extra
15978 space for up to 2 characters produced in a loop.
15979 (decode_coding_iso_2022): Abort if there isn't enough place in
15980 charbuf for the composition carryover bytes.
15981
159822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15983
ae940cca
EZ
15984 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15985 aborting when %lld or %lll format is passed.
15986 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15987 %llo or %llx format is passed. (Bug#8545)
15988
03ab8921
EZ
15989 * window.c (window_scroll_line_based): Use a marker instead of
15990 simple variables to record original value of point. (Bug#7952)
15991
afda1437
EZ
15992 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15993 produced by %s or %c overflows available buffer space. (Bug#8545)
15994
f76dee0c
PE
159952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15996
15997 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15998 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15999
fdc5744d
JB
160002011-04-28 Juanma Barranquero <lekktu@gmail.com>
16001
16002 * w32.c (init_environment): Warn about defaulting HOME to C:\.
16003
638f053a
JB
160042011-04-28 Juanma Barranquero <lekktu@gmail.com>
16005
16006 * keyboard.c (Qdelayed_warnings_hook): Define.
16007 (command_loop_1): Run `delayed-warnings-hook'
16008 if Vdelayed_warnings_list is non-nil.
16009 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
16010 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
16011
d178f871
EZ
160122011-04-28 Eli Zaretskii <eliz@gnu.org>
16013
16014 * doprnt.c (doprnt): Don't return value smaller than the buffer
16015 size if the message was truncated. (Bug#8545).
16016
b124fd93
JB
160172011-04-28 Juanma Barranquero <lekktu@gmail.com>
16018
16019 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
16020 (Fx_window_property): #if-0 the whole functions, not just the bodies.
16021
e810457d
PE
160222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
16023
16024 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
16025
ea51cceb
JB
160262011-04-27 Juanma Barranquero <lekktu@gmail.com>
16027
16028 * makefile.w32-in: Update dependencies.
16029
94dcfacf
EZ
160302011-04-27 Eli Zaretskii <eliz@gnu.org>
16031
16032 Improve `doprnt' and its usage. (Bug#8545)
16033 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
16034 `format_end'. Remove support for %l as a conversion specifier.
16035 Don't use xrealloc. Improve diagnostics when the %l size modifier
16036 is used. Update the commentary.
16037
16038 * eval.c (verror): Simplify calculation of size_t.
16039
16040 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
16041 messages.
16042
f61f41d7
PE
160432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
16044
16045 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
16046 change.
16047
96fb4434
PE
160482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
16049
16050 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
16051 This makes this file independent of the recent pseudovector change.
16052
671875da 160532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 16054
69e9b5a3
PE
16055 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
16056
b5f869a7 16057 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 16058 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 16059 Remove unused local.
c8926152 16060 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 16061
841a1577 16062 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
16063 GCC 4.6.0 optimizes based on type-based alias analysis.
16064 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
16065 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
16066 != &v->size, and therefore "v->size = 1; b->size = 2; return
16067 v->size;" must therefore return 1. This assumption is incorrect
16068 for Emacs, since it type-puns struct Lisp_Vector * with many other
16069 types. To fix this problem, this patch adds a new type struct
f904488f 16070 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
16071 and pseudovectors, and helps optimizing compilers not get fooled
16072 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
16073 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
16074 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
16075 the size member.
eab3844f
PE
16076 (XSETPVECTYPE): Rewrite in terms of new macro.
16077 (XSETPVECTYPESIZE): New macro, specifying both type and size.
16078 This is a bit clearer, and further avoids the possibility of
16079 undesirable aliasing.
16080 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 16081 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
16082 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
16083 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
16084 (ASIZE): Now uses header.size rather than size.
16085 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
16086 to avoid the hassle of writing XVECTOR (foo)->header.size.
16087 (struct vectorlike_header): New type.
eab3844f
PE
16088 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
16089 object, to help avoid aliasing.
16090 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
16091 (SUBRP): Likewise, since Lisp_Subr is a special case.
16092 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
16093 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
16094 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 16095 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
16096 changed to be "header.size" and "header.next".
16097 * buffer.h (struct buffer): Likewise.
16098 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
16099 * frame.h (struct frame): Likewise.
16100 * process.h (struct Lisp_Process): Likewise.
16101 * termhooks.h (struct terminal): Likewise.
16102 * window.c (struct save_window_data, struct saved_window): Likewise.
16103 * window.h (struct window): Likewise.
16104 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
16105 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
16106 * buffer.c (init_buffer_once): Likewise.
16107 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
16108 special case.
16109 * process.c (Fformat_network_address): Use local var for size,
16110 for brevity.
16111
0df1eac5
PE
16112 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
16113
847ab9d1 16114 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
16115 * data.c (atof): Remove decl; no longer used or needed.
16116 (digit_to_number): Move to lread.c.
16117 (Fstring_to_number): Use new string_to_number function, to be
16118 consistent with how the Lisp reader treats infinities and NaNs.
16119 Do not assume that floating-point numbers represent EMACS_INT
16120 without losing information; this is not true on most 64-bit hosts.
16121 Avoid double-rounding errors, by insisting on integers when
16122 parsing non-base-10 numbers, as the documentation specifies.
16123 * lisp.h (string_to_number): New decl, replacing ...
16124 (isfloat_string): Remove.
bc0a5c13 16125 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 16126 (read1): Do not accept +. and -. as integers; this
452f4150
PE
16127 appears to have been a coding error. Similarly, do not accept
16128 strings like +-1e0 as floating point numbers. Do not report
16129 overflow for integer overflows unless the base is not 10 which
16130 means we have no simple and reliable way to continue.
16131 Break out the floating-point parsing into a new
16132 function string_to_number, so that Fstring_to_number parses
16133 floating point numbers consistently with the Lisp reader.
04f2d78b 16134 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
16135 (E_CHAR, EXP_INT): Remove, replacing with ...
16136 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
16137 (string_to_number): New function, replacing isfloat_string.
16138 This function checks for valid syntax and produces the resulting
16139 Lisp float number too. Rework it so that string-to-number
bc0a5c13 16140 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
16141 so that overflow for non-base-10 numbers is reported only when
16142 there's no portable and simple way to convert to floating point.
452f4150 16143
67769ffc
PE
16144 * textprop.c (set_text_properties_1): Rewrite for clarity,
16145 and to avoid GCC warning about integer overflow.
16146
c20db43f
PE
16147 * intervals.h (struct interval): Use EMACS_INT for members
16148 where EMACS_UINT might cause problems. See
16149 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
16150 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
16151 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
16152 All uses changed.
37aa2f85
PE
16153 (offset_intervals): Tell GCC not to worry about length overflow
16154 when negating a negative length.
c20db43f 16155
2538aa2f
PE
16156 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
16157 (overrun_check_free): Likewise.
16158
f2d3008d
PE
16159 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
16160 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
16161 word size.
16162
ec8df744
PE
16163 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
16164 (gnutls_make_error): Rename local to avoid shadowing.
16165 (gnutls_emacs_global_deinit): ifdef out; not used.
16166 (Fgnutls_boot): Use const for pointer to readonly storage.
16167 Comment out unused local. Fix pointer signedness problems.
16168
640ee02d
PE
16169 * lread.c (openp): Don't stuff size_t into an 'int'.
16170 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
16171 about possible signed overflow.
16172
6048fb2a
PE
16173 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
16174 (GDK_KEY_g): Don't define if already defined.
16175 (xg_prepare_tooltip): Avoid pointer signedness problem.
16176 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
16177
fa3c87e1
PE
16178 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
16179 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
16180
2172544b
PE
16181 * xfns.c (Fx_window_property): Simplify a bit,
16182 to make a bit faster and to avoid GCC 4.6.0 warning.
16183 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
16184
9b821a21
PE
16185 * fns.c (internal_equal): Don't assume size_t fits in int.
16186
3c616cfa
PE
16187 * alloc.c (compact_small_strings): Tighten assertion a little.
16188
c2982e87
PE
16189 Replace pEd with more-general pI, and fix some printf arg casts.
16190 * lisp.h (pI): New macro, generalizing old pEd macro to other
16191 conversion specifiers. For example, use "...%"pI"d..." rather
16192 than "...%"pEd"...".
16193 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 16194 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
16195 * alloc.c (check_pure_size): Don't overflow by converting size to int.
16196 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
16197 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
16198 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
16199 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
16200 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
16201 64-bit hosts.
16202 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
16203 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
16204 * print.c (safe_debug_print, print_object): Likewise.
16205 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
16206 to int.
6f04d126
PE
16207 Use pI instead of if-then-else-abort. Use %p to avoid casts,
16208 avoiding the 0 flag, which is not portable.
c2982e87
PE
16209 * process.c (Fmake_network_process): Use pI to avoid cast.
16210 * region-cache.c (pp_cache): Likewise.
16211 * xdisp.c (decode_mode_spec): Likewise.
16212 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
16213 behavior on 64-bit hosts with printf arg.
6f04d126 16214 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
16215 (x_stop_queuing_selection_requests): Likewise.
16216 (x_get_window_property): Don't truncate byte count to an 'int'
16217 when tracing.
0b432f21 16218
5e073ec7
PE
16219 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
16220 here, since it parses constructs like leading '-' and spaces,
16221 which are not wanted; and it overflows with large numbers.
16222 Instead, simply match F[0-9]+, which is what is wanted anyway.
16223
36372bf9
PE
16224 * alloc.c: Remove unportable assumptions about struct layout.
16225 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
16226 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
16227 (allocate_vectorlike, make_pure_vector): Use the new macros,
16228 plus offsetof, to remove unportable assumptions about struct layout.
16229 These assumptions hold on all porting targets that I know of, but
16230 they are not guaranteed, they're easy to remove, and removing them
16231 makes further changes easier.
16232
0b432f21
PE
16233 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
16234 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
16235 (string_overrun_cookie): Now const. Use initializers that
16236 don't formally overflow signed char, to avoid warnings.
000098c1
PE
16237 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
16238 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
16239 (allocate_buffer): Don't assume sizeof (struct buffer) is a
16240 multiple of sizeof (EMACS_INT); it need not be, if
16241 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 16242 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 16243
895009e1
JB
162442011-04-26 Juanma Barranquero <lekktu@gmail.com>
16245
16246 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
16247
6a7a1b0b
TZ
162482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
16249
16250 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 16251 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
16252 Reported by Paul Eggert <eggert@cs.ucla.edu>.
16253
841a1577 162542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
16255
16256 * lisp.h (Qdebug): List symbol.
895009e1 16257 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
16258 * keyboard.c (debug-on-event): New variable.
16259 (handle_user_signal): Break into debugger when debug-on-event
16260 matches the current signal symbol.
16261
f2d3ba6f
DN
162622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
16263
16264 * alloc.c (check_sblock, check_string_bytes)
16265 (check_string_free_list): Convert to standard C.
16266
42ce4c63
TZ
162672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
16268
16269 * w32.c (emacs_gnutls_push): Fix typo.
16270
825cd63c
EZ
162712011-04-25 Eli Zaretskii <eliz@gnu.org>
16272
fb11d64d
EZ
16273 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
16274 "cast to pointer from integer of different size".
16275
825cd63c
EZ
16276 Improve doprnt and its use in verror. (Bug#8545)
16277 * doprnt.c (doprnt): Document the set of format control sequences
16278 supported by the function. Use SAFE_ALLOCA instead of always
16279 using `alloca'.
16280
16281 * eval.c (verror): Don't limit the buffer size at size_max-1, that
16282 is one byte too soon. Don't use xrealloc; instead xfree and
16283 xmalloc anew.
16284
e061a11b
TZ
162852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
16286
16287 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
16288 callbacks stage.
16289
16290 * gnutls.c: Renamed global_initialized to
16291 gnutls_global_initialized. Added internals for the
16292 :verify-hostname-error, :verify-error, and :verify-flags
16293 parameters of `gnutls-boot' and documented those parameters in the
16294 docstring. Start callback support.
9173deec
JB
16295 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
16296 unless a fatal error occurred. Call gnutls_alert_send_appropriate
16297 on error. Return error code.
e061a11b
TZ
16298 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
16299 (emacs_gnutls_read): Likewise.
16300 (Fgnutls_boot): Return handshake error code.
16301 (emacs_gnutls_handle_error): New function.
16302 (wsaerror_to_errno): Likewise.
16303
16304 * w32.h (emacs_gnutls_pull): Add prototype.
16305 (emacs_gnutls_push): Likewise.
16306
16307 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
16308 (emacs_gnutls_push): Likewise.
16309
163102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
16311
16312 * process.c (wait_reading_process_output): Check if GnuTLS
16313 buffered some data internally if no FDs are set for TLS
16314 connections.
16315
16316 * makefile.w32-in (OBJ2): Add gnutls.$(O).
16317 (LIBS): Link to USER_LIBS.
16318 ($(BLD)/gnutls.$(0)): New target.
16319
fa6996bc
EZ
163202011-04-24 Eli Zaretskii <eliz@gnu.org>
16321
eb35682e
EZ
16322 * xdisp.c (handle_single_display_spec): Rename the
16323 display_replaced_before_p argument into display_replaced_p, to
16324 make it consistent with the commentary. Fix typos in the
16325 commentary.
16326
e2ad650c
EZ
16327 * textprop.c (syms_of_textprop): Remove dead code.
16328 (copy_text_properties): Delete obsolete commentary about an
16329 interface that was deleted long ago. Fix typos in the description
16330 of arguments.
16331
1b2de274
EZ
16332 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
16333 to changes in oldXMenu/XMenu.h from 2011-04-16.
16334 <menu_help_message, prev_menu_help_message>: Constify.
16335 (IT_menu_make_room): menu->help_text is now `const char **';
16336 adjust.
16337
16338 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
16339 to changes in oldXMenu/XMenu.h from 2011-04-16.
16340 (struct XMenu): Declare `help_text' `const char **'.
16341
16342 * xfaces.c <Qunspecified>: Make extern again.
16343
16344 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 16345 required by POSIX.
1b2de274 16346
762b15be
EZ
16347 * doc.c (get_doc_string): Improve the format passed to `error'.
16348
16349 * doprnt.c (doprnt): Improve commentary.
16350
16351 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
16352
16353 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
16354 them with etags.
16355
f1052e5d
EZ
16356 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
16357 changes in globals.h immediately force recompilation.
762b15be
EZ
16358 (TAGS): Depend on $(CURDIR)/m/intel386.h and
16359 $(CURDIR)/s/ms-w32.h.
16360 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 16361
fa6996bc
EZ
16362 * character.c (Fchar_direction): Function deleted.
16363 (syms_of_character): Don't defsubr it.
16364 <char-direction-table>: Deleted.
16365
e6c3da20
EZ
163662011-04-23 Eli Zaretskii <eliz@gnu.org>
16367
16368 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
16369 * doprnt.c: Include limits.h.
16370 (SIZE_MAX): New macro.
04f2d78b
CB
16371 (doprnt): Return a size_t value. 2nd arg is now size_t.
16372 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
16373 Improve overflow protection. Support `l' modifier for integer
16374 conversions. Support %l conversion. Don't assume an EMACS_INT
16375 argument for integer conversions and for %c.
16376
16377 * lisp.h (doprnt): Restore prototype.
16378
16379 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
16380 $(SRC)/character.h.
16381
16382 * Makefile.in (base_obj): Add back doprnt.o.
16383
16384 * deps.mk (doprnt.o): Add back prerequisites.
16385 (callint.o): Depend on character.h.
16386
16387 * eval.c (internal_lisp_condition_case): Include the handler
16388 representation in the error message.
16389 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
16390 when breaking from the loop.
16391
16392 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
16393
16394 * callint.c (Fcall_interactively): When displaying error message
16395 about invalid control letter, pass the character's codepoint, not
16396 a pointer to its multibyte form. Improve display of the character
16397 in octal and display also its hex code.
16398
16399 * character.c (char_string): Use %x to display the (unsigned)
16400 codepoint of an invalid character, to avoid displaying a bogus
16401 negative value.
16402
16403 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
16404 `error', not SYMBOL_NAME itself.
16405
16406 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
16407 character arguments to `error'.
16408
16409 * charset.c (check_iso_charset_parameter): Fix incorrect argument
16410 to `error' in error message about FINAL_CHAR argument. Make sure
16411 FINAL_CHAR is a character, and use %c when it is passed as
16412 argument to `error'.
16413
4ffd0d6b 164142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
16415
16416 * s/ms-w32.h (localtime): Redirect to sys_localtime.
16417
16418 * w32.c: Include <time.h>.
16419 (sys_localtime): New function.
16420
4ffd0d6b 164212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
16422
16423 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
16424
4ffd0d6b 16425 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 16426
4ffd0d6b 164272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 16428
4ffd0d6b
GM
16429 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
16430 zombies (Bug#8467).
aac0c6e3 16431
04c56954
EZ
164322011-04-19 Eli Zaretskii <eliz@gnu.org>
16433
16434 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
16435 gl_state.e_property when gl_state.object is Qt.
16436
16437 * insdel.c (make_gap_larger): Remove limitation of buffer size
16438 to <= INT_MAX.
16439
16a43933
CY
164402011-04-18 Chong Yidong <cyd@stupidchicken.com>
16441
16442 * xdisp.c (lookup_glyphless_char_display)
16443 (produce_glyphless_glyph): Handle cons cell entry in
16444 glyphless-char-display.
16445 (Vglyphless_char_display): Document it.
16446
16447 * term.c (produce_glyphless_glyph): Handle cons cell entry in
16448 glyphless-char-display.
16449
4581706e
CY
164502011-04-17 Chong Yidong <cyd@stupidchicken.com>
16451
16452 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
16453
16454 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
16455
16456 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
16457 definition for no-X builds.
16458
4887c6e2 164592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 16460
fd35b6f9
PE
16461 Static checks with GCC 4.6.0 and non-default toolkits.
16462
5c1ccb01
PE
16463 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
16464
006c5daa
PE
16465 * process.c (keyboard_bit_set): Define only if SIGIO.
16466 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
16467 (send_process): Repair possible setjmp clobbering.
16468
efc736d3
PE
16469 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
16470
4e2fe2e6
PE
16471 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
16472
f97334a2
PE
16473 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
16474
4e75f29d
PE
16475 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16476 Define only if needed.
16477
90efadd1
PE
16478 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
16479 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 16480 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 16481
3c647824
PE
16482 * dispextern.h (struct redisplay_interface): Rename param
16483 to avoid shadowing.
e264f262 16484 * termhooks.h (struct terminal): Likewise.
761383f4 16485 * xterm.c (xembed_send_message): Likewise.
3c647824 16486
b58c5c4a
PE
16487 * insdel.c (make_gap_smaller): Define only if
16488 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
16489
cad59032
PE
16490 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
16491 it.
16492
c339dc2e
PE
16493 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
16494 so that we aren't warned about unused symbols.
16495
91a3e27b
PE
16496 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
16497
399c71d3 16498 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 16499
8ffc96f5
PE
16500 * xfns.c (x_real_positions): Mark locals as initialized.
16501
eef9bc79
PE
16502 * xmenu.c (xmenu_show): Don't use uninitialized vars.
16503
098db9dd
PE
16504 * xterm.c: Fix problems found by static analysis with other toolkits.
16505 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
16506 (x_dispatch_event): Declare static if USE_GTK, and
16507 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 16508 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 16509 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
16510 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
16511 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 16512
eb18f6cc
PE
16513 * xmenu.c (menu_help_callback): Pointer type fixes.
16514 Use const pointers when pointing at readonly data. Avoid pointer
16515 signedness clashes.
16516 (FALSE): Remove unused macro.
16517 (update_frame_menubar): Remove unused decl.
16518
1fe72bf8
PE
16519 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
16520
60d9e1db
PE
16521 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
16522 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
16523 (single_menu_item): Rename local to avoid shadowing.
16524
39261c26
PE
16525 * keyboard.c (make_lispy_event): Remove unused local var.
16526
018c5e19
PE
16527 * frame.c, frame.h (x_get_resource_string): Bring this back, but
16528 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
16529
63d2b86e
PE
16530 * bitmaps: Change bitmaps from unsigned char back to the X11
16531 compatible char. Avoid the old compiler warnings about
16532 out-of-range initializers by using, for example, '\xab' rather
16533 than 0xab.
16534
aefd87e1
PE
16535 * xgselect.c (xgselect_initialize): Check vs interface
16536 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
16537
bf501fb9
PE
16538 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16539
e9829fdf
PE
16540 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
16541 to read-only memory.
16542
1086c095
PE
16543 * fns.c (vector): Remove; this old hack is no longer needed.
16544
2baccd04 16545 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 16546 Remove unused var.
dde42981 16547 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 16548
72391843 16549 * xrdb.c (x_load_resources): Omit unused local.
3565b346 16550
436c16df 16551 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 16552 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16553 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 16554
92bb796d 16555 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16556 (x_term_init): Remove local to avoid shadowing.
92bb796d 16557
764430a3 16558 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
16559
16560 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
16561 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
16562
d1dfb56c
EZ
165632011-04-16 Eli Zaretskii <eliz@gnu.org>
16564
c4354cb4
EZ
16565 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
16566
d1dfb56c
EZ
16567 Fix regex.c, syntax.c and friends for buffers > 2GB.
16568 * syntax.h (struct gl_state_s): Declare character position members
16569 EMACS_INT.
16570
16571 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
16572
04f2d78b
CB
16573 * textprop.c (verify_interval_modification, interval_of):
16574 Declare arguments EMACS_INT.
d1dfb56c
EZ
16575
16576 * intervals.c (adjust_intervals_for_insertion): Declare arguments
16577 EMACS_INT.
16578
16579 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
16580
16581 * indent.c (Fvertical_motion): Local variable it_start is now
16582 EMACS_INT.
16583
16584 * regex.c (re_match, re_match_2, re_match_2_internal)
16585 (bcmp_translate, regcomp, regexec, print_double_string)
16586 (group_in_compile_stack, re_search, re_search_2, regex_compile)
16587 (re_compile_pattern, re_exec): Declare arguments and local
16588 variables `size_t' and `ssize_t' and return values `regoff_t', as
16589 appropriate.
16590 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
16591 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
16592 <compile_stack_type>: `size' and `avail' are now `size_t'.
16593
16594 * regex.h <regoff_t>: Use ssize_t, not int.
16595 (re_search, re_search_2, re_match, re_match_2): Arguments that
16596 specify buffer/string position and length are now ssize_t and
16597 size_t. Return type is regoff_t.
16598
613052cd
BK
165992011-04-16 Ben Key <bkey76@gmail.com>
16600
16601 * nsfont.m: Fixed bugs in ns_get_family and
16602 ns_descriptor_to_entity that were caused by using free to
16603 deallocate memory blocks that were allocated by xmalloc (via
16604 xstrdup). This caused Emacs to crash when compiled with
16605 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
16606 --enable-checking=xmallocoverrun). xfree is now used to
16607 deallocate these memory blocks.
16608
4170f62f 166092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16610
71b41406
PE
16611 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16612
9587a89d
PE
16613 emacs_write: Accept and return EMACS_INT for sizes.
16614 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
16615 et seq.
16616 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
16617 Accept and return EMACS_INT.
16618 (emacs_gnutls_write): Return the number of bytes written on
16619 partial writes.
16620 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
16621 (emacs_read, emacs_write): Remove check for negative size, as the
16622 Emacs source code has been audited now.
9587a89d
PE
16623 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
16624 (emacs_read, emacs_write): Use it.
273a5f82
PE
16625 * process.c (send_process): Adjust to the new signatures of
16626 emacs_write and emacs_gnutls_write. Do not attempt to store
16627 a byte offset into an 'int'; it might overflow.
9587a89d 16628 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 16629
3e047f51
PE
16630 * sound.c: Don't assume sizes fit in 'int'.
16631 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 16632 Return EMACS_INT, not int.
3e047f51 16633 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
16634 Accept EMACS_INT, not int.
16635 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
16636 record read return values.
16637
cc39a9db
BK
166382011-04-15 Ben Key <bkey76@gmail.com>
16639
c9d0ec6d
JB
16640 * keyboard.c (Qundefined): Don't declare static since it is used
16641 in nsfns.m.
16642 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
16643 static since they are used in nsfont.m.
cc39a9db 16644
6c60eb9f
SM
166452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
16646
16647 * process.c (Qprocessp): Don't declare static.
16648 * lisp.h (Qprocessp): Declare again.
16649
7990b61a
JB
166502011-04-15 Juanma Barranquero <lekktu@gmail.com>
16651
16652 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
16653
5d4cb038
PE
166542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
16655
8bd7b830 16656 Improve C-level modularity by making more things 'static'.
cd64ea1d 16657
e3b27b31
PE
16658 Don't publish debugger-only interfaces to other modules.
16659 * lisp.h (safe_debug_print, debug_output_compilation_hack):
16660 (verify_bytepos, count_markers): Move decls to the only modules
16661 that need them.
16662 * region-cache.h (pp_cache): Likewise.
16663 * window.h (check_all_windows): Likewise.
16664 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
16665
5d4cb038
PE
16666 * sysdep.c (croak): Now static, if
16667 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
16668 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
16669
16670 * alloc.c (refill_memory_reserve): Now static if
16671 !defined REL_ALLOC || defined SYSTEM_MALLOC.
16672 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 16673
e87b6180
PE
16674 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
16675 Define only if USE_LUCID.
16676
ac64929e
PE
16677 * xrdb.c (x_customization_string, x_rm_string): Now static.
16678
6f37259d
PE
16679 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
16680 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
16681
1683e3ab
PE
16682 * xdisp.c (draw_row_with_mouse_face): Now static.
16683 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
16684
de9c2632
PE
16685 * window.h (check_all_windows): Mark externally visible.
16686
2b96acb7
PE
16687 * window.c (window_deletion_count): Now static.
16688
16689 * undo.c: Make symbols static if they're not exported.
16690 (last_undo_buffer, last_boundary_position, pending_boundary):
16691 Now static.
16692
50436f33
PE
16693 * textprop.c (interval_insert_behind_hooks): Now static.
16694 (interval_insert_in_front_hooks): Likewise.
16695
64520e5c
PE
16696 * term.c: Make symbols static if they're not exported.
16697 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
16698 (max_frame_lines, tty_set_terminal_modes):
16699 (tty_reset_terminal_modes, tty_turn_off_highlight):
16700 (get_tty_terminal): Now static.
16701 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
16702 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 16703 HAVE_WINDOW_SYSTEM.
64520e5c
PE
16704 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
16705 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
16706
1fa53021
PE
16707 * sysdep.c: Make symbols static if they're not exported.
16708 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
16709 Now static.
16710 (sigprocmask_set, full_mask): Remove; unused.
16711 (wait_debugging): Mark as visible.
16712 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
16713 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
16714
d4b43b22
PE
16715 * syntax.c (syntax_temp): Define only if !__GNUC__.
16716
b7c513d0
PE
16717 * sound.c (current_sound_device, current_sound): Now static.
16718
989b29ad
PE
16719 * search.c (searchbufs, searchbuf_head): Now static.
16720
13a55a78
PE
16721 * scroll.c (scroll_cost): Remove; unused.
16722 * dispextern.h (scroll_cost): Remove decl.
16723
de68a1fc
PE
16724 * region-cache.h (pp_cache): Mark as externally visible.
16725
40ccffa6
PE
16726 * process.c: Make symbols static if they're not exported.
16727 (process_tick, update_tick, create_process, chan_process):
16728 (Vprocess_alist, proc_buffered_char, datagram_access):
16729 (fd_callback_data, send_process_frame, process_sent_to): Now static.
16730 (deactivate_process): Mark defn as static, as well as decl.
16731 * lisp.h (create_process): Remove decl.
16732 * process.h (chan_process, Vprocess_alist): Remove decls.
16733
ad64fc97
PE
16734 * print.c: Make symbols static if they're not exported.
16735 (print_depth, new_backquote_output, being_printed, print_buffer):
16736 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
16737 (print_interval, print_number_index, initial_stderr_stream):
16738 Now static.
16739 * lisp.h (Fprinc): Remove decl.
16740 (debug_output_compilation_hack): Mark as externally visible.
16741
adddb265
PE
16742 * sysdep.c (croak): Move decl from here to syssignal.h.
16743 * syssignal.h (croak): Put it here, so the API can be checked when
16744 'croak' is called from dissociate_if_controlling_tty.
16745
1717ede2
PE
16746 * minibuf.c: Make symbols static if they're not exported.
16747 (minibuf_save_list, choose_minibuf_frame): Now static.
16748 * lisp.h (choose_minibuf_frame): Remove decl.
16749
fa5fb2bc
PE
16750 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16751
1e3890d1
PE
16752 * lread.c: Make symbols static if they're not exported.
16753 (read_objects, initial_obarray, oblookup_last_bucket_number):
16754 Now static.
16755 (make_symbol): Remove; unused.
16756 * lisp.h (initial_obarray, make_symbol): Remove decls.
16757
8a1414fa
PE
16758 * keyboard.c: Make symbols static if they're not exported.
16759 (single_kboard, recent_keys_index, total_keys, recent_keys):
16760 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16761 (this_single_command_key_start, echoing, last_auto_save):
16762 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16763 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16764 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16765 (Vlispy_mouse_stem, double_click_count):
16766 Now static.
16767 (force_auto_save_soon): Define only if SIGDANGER.
16768 (ignore_mouse_drag_p): Now static if
16769 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16770 (print_help): Remove; unused.
16771 (stop_character, last_timer_event): Mark as externally visible.
16772 * keyboard.h (ignore_mouse_drag_p): Declare only if
16773 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16774 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16775 * lisp.h (echoing): Remove decl.
16776 (force_auto_save_soon): Declare only if SIGDANGER.
16777 * xdisp.c (redisplay_window): Simplify code, to make it more
16778 obvious that ignore_mouse_drag_p is not accessed if !defined
16779 USE_GTK && !defined HAVE_NS.
16780
93ea6e8f
PE
16781 * intervals.c: Make symbols static if they're not exported.
16782 (merge_properties_sticky, merge_interval_right, delete_interval):
16783 Now static.
16784 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16785
77382fcc
PE
16786 * insdel.c: Make symbols static if they're not exported.
16787 However, leave prepare_to_modify_buffer alone. It's never
16788 called from outside this function, but that appears to be a bug.
16789 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16790 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16791 (adjust_after_replace_noundo): Remove; unused.
16792 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16793 (signal_before_change): Remove decls.
77382fcc 16794
9306c32e
PE
16795 * indent.c (val_compute_motion, val_vmotion): Now static.
16796
cd44d2eb
PE
16797 * image.c: Make symbols static if they're not exported.
16798 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16799 if USE_GTK.
16800 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16801 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16802
ad9a7a06
PE
16803 * fringe.c (standard_bitmaps): Now static.
16804 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16805
81626931
PE
16806 * frame.c: Make symbols static if they're not exported.
16807 (x_report_frame_params, make_terminal_frame): Now static.
16808 (get_frame_param): Now static, unless HAVE_NS.
16809 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16810 (x_get_resource_string): Remove; not used.
16811 * frame.h (make_terminal_frame, x_report_frame_params):
16812 (x_get_resource_string); Remove decls.
16813 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16814 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16815
239f9db9
PE
16816 * font.c, fontset.c: Make symbols static if they're not exported.
16817 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16818 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16819 * font.c (font_close_object): Now static.
16820 * font.h (font_close_object): Remove.
16821 * fontset.c (FONTSET_OBJLIST): Remove.
16822 (free_realized_fontset) #if-0 the body, which does nothing.
16823 (face_suitable_for_char_p): #if-0, as it's never called.
16824 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16825 * xfaces.c (face_at_string_position):
16826 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16827 since 0 is always ASCII.
16828
dfcf3579
PE
16829 * fns.c (weak_hash_tables): Now static.
16830
5045092b
PE
16831 * fileio.c: Make symbols static if they're not exported.
16832 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16833 (Vwrite_region_annotation_buffers): Now static.
16834
57a96f5c
PE
16835 * eval.c: Make symbols static if they're not exported.
16836 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16837 * lisp.h (backtrace_list): Remove decl.
16838
35f08c38
PE
16839 * emacs.c: Make symbols static if they're not exported.
16840 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16841 (fatal_error_code, fatal_error_signal_hook, standard_args):
16842 Now static.
16843 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16844 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16845 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16846 * lisp.h (fatal_error_signal_hook): Remove decl.
16847 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16848
f44bd759
PE
16849 * editfns.c: Move a (normally-unused) function to its only use.
16850 * editfns.c, lisp.h (get_operating_system_release): Remove.
16851 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16852 worth the hassle of breaking this out.
16853
b532497d
PE
16854 * xterm.c: Make symbols static if they're not exported.
16855 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16856 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16857 (x_destroy_window, x_delete_display):
16858 Now static.
16859 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16860 (x_mouse_leave): Remove; unused.
16861 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16862 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16863 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16864 Remove decls.
16865 (x_mouse_leave): Declare only if WINDOWSNT.
16866 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16867 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16868 USE_X_TOOLKIT.
16869
1675728f
PE
16870 * ftxfont.c: Make symbols static if they're not exported.
16871 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16872 HAVE_FREETYPE.
16873 * font.h (ftxfont_driver): Likewise.
16874
e4cebfca
PE
16875 * xfns.c: Make symbols static if they're not exported.
16876 (x_last_font_name, x_display_info_for_name):
16877 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16878 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16879 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16880 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16881 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16882 (last_show_tip_args): Now static.
16883 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16884 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16885 (x_screen_planes): Remove; unused.
16886 * dispextern.h (x_screen_planes): Remove decl.
16887
5bf46f05
PE
16888 * dispnew.c: Make symbols static if they're not exported.
16889 * dispextern.h (redraw_garbaged_frames, scrolling):
16890 (increment_row_positions): Remove.
16891 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16892 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16893 Now static.
16894 (redraw_garbaged_frames): Remove; unused.
16895
435f4c28
PE
16896 * xfaces.c: Make symbols static if they're not exported.
16897 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16898 Remove decls.
16899 * xterm.h (defined_color): Remove decls.
16900 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16901 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16902 (menu_face_changed_default, defined_color, free_realized_face):
16903 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16904 (ascii_face_of_lisp_face): Remove; unused.
16905
8524aef3
PE
16906 * xdisp.c: Make symbols static if they're not exported.
16907 * dispextern.h (scratch_glyph_row, window_box_edges):
16908 (glyph_to_pixel_coords, set_cursor_from_row):
16909 (get_next_display_element, set_iterator_to_next):
16910 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16911 (show_mouse_face): Remove decls
16912 * frame.h (message_buf_print): Likewise.
16913 * lisp.h (pop_message, set_message, check_point_in_composition):
16914 Likewise.
16915 * xterm.h (set_vertical_scroll_bar): Likewise.
16916 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16917 (message_buf_print, scratch_glyph_row, displayed_buffer):
16918 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16919 (get_next_display_element, show_mouse_face, window_box_edges):
16920 (frame_to_window_pixel_xy, check_point_in_composition):
16921 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16922 (glyph_to_pixel_coords): Remove; unused.
16923
16390cd2
PE
16924 * dired.c (file_name_completion): Now static.
16925
16926 * dbusbind.c (xd_in_read_queued_messages): Now static.
16927
a25f4dfa
PE
16928 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16929 * data.c (circular_list_error): Remove.
16930
14a9c8df
PE
16931 * commands.h (last_point_position, last_point_position_buffer):
16932 (last_point_position_window): Remove decls.
16933 * keyboard.c: Make these variables static.
16934
04f2d78b
CB
16935 * coding.h (coding, code_convert_region, encode_coding_gap):
16936 Remove decls.
74ab6df5
PE
16937 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16938 (iso_code_class, detect_coding, code_convert_region): Now static.
16939 (encode_coding_gap): Remove; unused.
16940
38dfbee1
PE
16941 * chartab.c (chartab_chars, chartab_bits): Now static.
16942
a2cb4e63
PE
16943 * charset.h (charset_iso_8859_1): Remove decl.
16944 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16945 Now static.
16946
127198fd
PE
16947 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16948 * ccl.c (Vccl_program_table): Now static.
16949 (check_ccl_update): Remove; unused.
16950
d85b608f
PE
16951 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16952 * category.h: ... from here.
16953 * category.c (check_category_table, set_category_set): Now static.
16954
31cd66f3
PE
16955 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16956 * lisp.h: Remove these decls.
16957
c358e587
PE
16958 * buffer.c (buffer_count): Remove unused var.
16959
e78aecca
PE
16960 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16961 so that it's not optimized away.
16962 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16963 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16964 exported only to the debugger.
16965
e192d7d3 16966 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16967 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16968
92470028
PE
16969 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16970 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16971 was inaccessible from Lisp.
16972 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16973 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16974
244ed907
PE
16975 alloc.c: Import and export fewer symbols, and remove unused items.
16976 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16977 is defined.
16978 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16979 it's not optimized away by whole-program optimization.
16980 (message_enable_multibyte, free_misc): Remove.
16981 (catchlist, handlerlist, mark_backtrace):
16982 Declare only if BYTE_MARK_STACK.
16983 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16984 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16985 (message_enable_multibyte): Remove decl.
16986 (free_misc, interval_free_list, float_block, float_block_index):
16987 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16988 (cons_free_list, last_marked_index):
16989 Now static.
16990 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16991 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16992 (mark_backtrace): Define only if BYTE_MARK_STACK.
16993 * xdisp.c (message_enable_multibyte): Now static.
16994
61c2b50e 16995 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16996 This makes it easier for human readers (and static analyzers)
16997 to see whether these variables are used from other modules.
16998 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16999 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
17000 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
17001 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
17002 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
17003 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
17004 * xmenu.c, xselect.c:
17005 Declare Q* vars static if they are not used in other modules.
17006 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
17007 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
17008 Remove decls of unexported vars.
17009 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
17010
95c82688
PE
17011 * lisp.h (DEFINE_FUNC): Make sname 'static'.
17012
16a97296
PE
17013 Make Emacs functions such as Fatom 'static' by default.
17014 This makes it easier for human readers (and static analyzers)
17015 to see whether these functions can be called from other modules.
17016 DEFUN now defines a static function. To make the function external
17017 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
17018 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
17019 (Finit_image_library):
16a97296
PE
17020 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
17021 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
17022 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
17023 Remove decls, since these functions are now static.
17024 (Funintern, Fget_internal_run_time): New decls, since these functions
17025 were already external.
95c82688 17026
16a97296
PE
17027 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
17028 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
17029 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
17030 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
17031 * keyboard.c, keymap.c, lread.c:
17032 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
17033 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
17034 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
17035 Mark functions with DEFUE instead of DEFUN,
17036 if they are used in other modules.
17037 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
17038 decls for now-static functions.
17039 * buffer.h (Fdelete_overlay): Remove decl.
17040 * callproc.c (Fgetenv_internal): Mark as internal.
17041 * composite.c (Fremove_list_of_text_properties): Remove decl.
17042 (Fcomposition_get_gstring): New forward static decl.
17043 * composite.h (Fcomposite_get_gstring): Remove decl.
17044 * dired.c (Ffile_attributes): New forward static decl.
17045 * doc.c (Fdocumntation_property): New forward static decl.
17046 * eval.c (Ffetch_bytecode): New forward static decl.
17047 (Funintern): Remove extern decl; now in .h file where it belongs.
17048 * fileio.c (Fmake_symbolic_link): New forward static decl.
17049 * image.c (Finit_image_library): New forward static decl.
17050 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
17051 * intervals.h (Fprevious_property_change):
17052 (Fremove_list_of_text_properties): Remove decls.
17053 * keyboard.c (Fthis_command_keys): Remove decl.
17054 (Fcommand_execute): New forward static decl.
17055 * keymap.c (Flookup_key): New forward static decl.
17056 (Fcopy_keymap): Now static.
17057 * keymap.h (Flookup_key): Remove decl.
17058 * process.c (Fget_process): New forward static decl.
17059 (Fprocess_datagram_address): Mark as internal.
17060 * syntax.c (Fsyntax_table_p): New forward static decl.
17061 (skip_chars): Remove duplicate decl.
17062 * textprop.c (Fprevious_property_change): New forward static decl.
17063 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
17064 Now internal.
17065 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
17066 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
17067
785bbd42
PE
17068 * editfns.c (Fformat): Remove unreachable code.
17069
8b913b57
AS
170702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
17071
17072 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
17073 change. (Bug#8496)
17074
a6744a35
EZ
170752011-04-13 Eli Zaretskii <eliz@gnu.org>
17076
17077 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
17078 when at ZV. (Bug#8487)
17079
e7974947
AS
170802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
17081
baad03f0
AS
17082 * charset.c (Fclear_charset_maps): Use xfree instead of free.
17083 (Bug#8437)
17084 * keyboard.c (parse_tool_bar_item): Likewise.
17085 * sound.c (sound_cleanup, alsa_close): Likewise.
17086 * termcap.c (tgetent): Likewise.
17087 * xfns.c (x_default_font_parameter): Likewise.
17088 * xsettings.c (read_and_apply_settings): Likewise.
17089
e7974947
AS
17090 * alloc.c (overrun_check_malloc, overrun_check_realloc)
17091 (overrun_check_free): Protoize.
17092
28272684
PE
170932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
17094
17095 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
17096 since callers should never pass a negative size.
17097 Change the signature to match that of plain 'read' and 'write'; see
17098 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
17099 * lisp.h: Update prototypes of emacs_write and emacs_read.
17100
11997c76
EZ
171012011-04-11 Eli Zaretskii <eliz@gnu.org>
17102
17103 * xdisp.c (redisplay_window): Don't try to determine the character
17104 position of the scroll margin if the window start point w->startp
e896f03c 17105 is outside the buffer's accessible region. (Bug#8468)
11997c76 17106
8a2cbd72
EZ
171072011-04-10 Eli Zaretskii <eliz@gnu.org>
17108
17109 Fix write-region and its subroutines for buffers > 2GB.
17110 * fileio.c (a_write, e_write): Modify declaration of arguments and
17111 local variables to support buffers larger than 2GB.
17112 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
17113
17114 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
17115 argument, local variables, and return value.
17116
17117 * lisp.h: Update prototypes of emacs_write and emacs_read.
17118
17119 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
17120
4073e537 171212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 17122
1ebfdcb6
PE
17123 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
17124
b2ded58d
PE
17125 Fix more problems found by GCC 4.6.0's static checks.
17126
7d66342c
PE
17127 * xdisp.c (vmessage): Use a better test for character truncation.
17128
bbf47d44
PE
17129 * charset.c (load_charset_map): <, not <=, for optimization,
17130 and to avoid potential problems with integer overflow.
9248994d 17131 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 17132 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 17133 * editfns.c (Fformat): Likewise.
1e69125e 17134 * syntax.c (skip_chars): Likewise.
3befa583 17135
e3019616
PE
17136 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
17137 This also lets GCC 4.6.0 generate slightly better loop code.
17138
becfa255
PE
17139 * callint.c (Fcall_interactively): <, not <=, for optimization.
17140 (Fcall_interactively): Count the number of arguments produced,
17141 not the number of arguments given. This is simpler and lets GCC
17142 4.6.0 generate slightly better code.
17143
dae0cd48
PE
17144 * ftfont.c: Distingish more carefully between FcChar8 and char.
17145 The previous code passed unsigned char * to a functions like
17146 strlen and xstrcasecmp that expect char *, which does not
17147 conform to the C standard.
17148 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
17149 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
17150 char * when the C standard requires it.
17151
76032d70
PE
17152 * keyboard.c (read_char): Remove unused var.
17153
eb3f1cc8
PE
17154 * eval.c: Port to Windows vsnprintf (Bug#8435).
17155 Include <limits.h>.
17156 (SIZE_MAX): Define if the headers do not.
17157 (verror): Do not give up if vsnprintf returns a negative count.
17158 Instead, grow the buffer. This ports to Windows vsnprintf, which
17159 does not conform to C99. Problem reported by Eli Zaretskii.
17160 Also, simplify the allocation scheme, by avoiding the need for
17161 calling realloc, and removing the ALLOCATED variable.
17162
70476b54
PE
17163 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
17164
12020a9e
PE
17165 Remove invocations of doprnt, as Emacs now uses vsnprintf.
17166 But keep the doprint source code for now, as we might revamp it
17167 and use it again (Bug#8435).
ea6c7ae6
PE
17168 * lisp.h (doprnt): Remove.
17169 * Makefile.in (base_obj): Remove doprnt.o.
17170 * deps.mk (doprnt.o): Remove.
17171
5fdb398c
PE
17172 error: Print 32- and 64-bit integers portably (Bug#8435).
17173 Without this change, on typical 64-bit hosts error ("...%d...", N)
17174 was used to print both 32- and 64-bit integers N, which relied on
17175 undefined behavior.
61bdb816 17176 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
17177 * lisp.h (error, verror): Mark as printf-like functions.
17178 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
17179 Report overflow in size calculations when allocating printf buffer.
17180 Do not truncate output string at its first null byte.
17181 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
17182 Truncate the output at a character boundary, since vsnprintf does not
17183 do that.
17184 * charset.c (check_iso_charset_parameter): Convert internal
17185 character to string before calling 'error', since %c now has the
17186 printf meaning.
17187 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
17188 overflow when computing char to be passed to 'error'. Do not
17189 pass Lisp_Object to 'error'; pass the integer instead.
17190 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
17191 formatted with plain %d.
17192
b189fa66
PE
17193 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
17194
bff87ef0
PE
17195 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
17196
7e2cac20
PE
17197 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
17198
ce4d90b5
PE
17199 * xterm.c (x_catch_errors): Remove duplicate declaration.
17200
266c9547
PE
17201 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
17202
79c49ad2
PE
17203 * xdisp.c, lisp.h (message_nolog): Remove; unused.
17204
368f4090
JM
172052011-04-10 Jim Meyering <meyering@redhat.com>
17206
17207 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
17208 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
17209 return ssize_t not "int", and use size_t as the buffer length.
17210 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
17211 * gnutls.h: Update declarations.
17212 * process.c (read_process_output): Use ssize_t, to match.
17213 (send_process): Likewise.
17214
a32d4040
CY
172152011-04-09 Chong Yidong <cyd@stupidchicken.com>
17216
17217 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
17218
8546720e 172192011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 17220
04f2d78b
CB
17221 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
17222 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 17223
8546720e
GM
17224 * xterm.c (handle_one_xevent):
17225 * xmenu.c (create_and_show_popup_menu):
17226 * xselect.c (x_decline_selection_request)
17227 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 17228
0a2f5c1a 172292011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
17230
17231 Fix some uses of `int' instead of EMACS_INT.
17232 * search.c (string_match_1, fast_string_match)
17233 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
17234 (scan_buffer, find_next_newline_no_quit)
17235 (find_before_next_newline, search_command, Freplace_match)
17236 (Fmatch_data): Make some `int' variables be EMACS_INT.
17237
17238 * xdisp.c (display_count_lines): 3rd argument and return value now
17239 EMACS_INT. All callers changed.
17240 (pint2hrstr): Last argument is now EMACS_INT.
17241
17242 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
17243 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
17244 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
17245 (decode_coding_utf_16, decode_coding_emacs_mule)
17246 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
17247 (decode_coding_ccl, decode_coding_charset)
17248 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
17249 (decode_coding_iso_2022, decode_coding_emacs_mule)
17250 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
17251 <char_offset, last_offset>: Declare EMACS_INT.
17252 (encode_coding_utf_8, encode_coding_utf_16)
17253 (encode_coding_emacs_mule, encode_invocation_designation)
17254 (encode_designation_at_bol, encode_coding_iso_2022)
17255 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
17256 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
17257 Declare EMACS_INT.
17258 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
17259 (encode_invocation_designation): Last argument P_NCHARS is now
17260 EMACS_INT.
17261 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
17262 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
17263
17264 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
17265 All users changed.
17266
17267 * ccl.c (Fccl_execute_on_string): Declare some variables
17268 EMACS_INT.
17269
8546720e 172702011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
17271
17272 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
17273
4e19a977
CS
172742011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
17275
17276 * process.c (Fformat_network_address): Doc fix.
17277
87302331
R
172782011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
17279
ee7683eb 17280 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 17281
cbb59342
CY
172822011-04-08 Chong Yidong <cyd@stupidchicken.com>
17283
17284 * keyboard.c (read_char): Call Lisp function help-form-show,
17285 instead of using internal_with_output_to_temp_buffer.
17286 (Qhelp_form_show): New var.
e0d38eeb 17287 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
17288
17289 * print.c (internal_with_output_to_temp_buffer): Function deleted.
17290
17291 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
17292
e67a13ab
CY
172932011-04-06 Chong Yidong <cyd@stupidchicken.com>
17294
04f2d78b
CB
17295 * process.c (Flist_processes): Remove to Lisp.
17296 (list_processes_1): Delete.
e67a13ab 17297
973f782d
EZ
172982011-04-06 Eli Zaretskii <eliz@gnu.org>
17299
7c106b1e
EZ
17300 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
17301
973f782d
EZ
17302 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
17303
41cf7d1a 173042011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 17305
ca23cc88
PE
17306 Fix more problems found by GCC 4.6.0's static checks.
17307
f390e2d5
PE
17308 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
17309
42eea0d0
PE
17310 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
17311
b69769da 17312 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 17313
f9541e84
PE
17314 * xdisp.c (vmessage): Mark as a printf-like function.
17315
13841b55
PE
17316 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
17317
c136c10f
PE
17318 * sound.c (sound_warning): Don't crash if arg contains a printf format.
17319
5e2d4a30
PE
17320 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
17321 printf-like functions.
17322 (tiff_load): Add casts to remove these marks before passing them
17323 to system-supplied API.
17324
583f48b9
PE
17325 * eval.c (Fsignal): Remove excess argument to 'fatal'.
17326
b25d760e
PE
17327 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
17328 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
17329 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
17330 directly, rather than having caller test rule sign. This avoids
17331 some unnecessary tests.
17332 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
17333 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
17334 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 17335
bc7b6697 17336 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 17337 (xfont_open): Avoid unnecessary tests.
bc7b6697 17338
27ccc379
PE
17339 * composite.c (composition_gstring_put_cache): Use unsigned integer.
17340
dcd5c89a
PE
17341 * composite.h, composite.c (composition_gstring_put_cache):
17342 Use EMACS_INT, not int, for length.
17343
b13a45c6
PE
17344 * composite.h (COMPOSITION_DECODE_REFS): New macro,
17345 breaking out part of COMPOSITION_DECODE_RULE.
17346 (COMPOSITION_DECODE_RULE): Use it.
17347 * composite.c (get_composition_id): Remove unused local vars,
17348 by using the new macro.
17349
1e792e4d
PE
17350 * textprop.c (set_text_properties_1): Change while to do-while,
17351 since the condition is always true at first.
17352
dc6c6455 17353 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
17354 (interval_deletion_adjustment): Return unsigned value.
17355 All uses changed.
dc6c6455 17356
aba7731a
PE
17357 * process.c (list_processes_1, create_pty, read_process_output):
17358 (exec_sentinel): Remove vars that were set but not used.
afd4052b 17359 (create_pty): Remove unnecessary "volatile"s.
bc57d757 17360 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 17361 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 17362 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 17363
fdfc4bf3
PE
17364 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
17365
fca8fe46 17366 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 17367 (update_syntax_table): Use unsigned instead of int.
fca8fe46 17368
06a0259a 17369 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 17370 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 17371 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 17372
e7b9e80f
PE
17373 * print.c (print_error_message): Avoid int overflow.
17374
56201685
PE
17375 * font.c (font_list_entities): Redo for clarity,
17376 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
17377
78834453 17378 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 17379 (font_score): Avoid potential overflow in diff calculation.
78834453 17380
0bc0b309 17381 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 17382 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 17383
e610eaca
PE
17384 * eval.c (funcall_lambda): Rename local to avoid shadowing.
17385
b895abce
PE
17386 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
17387 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
17388 can always succeed if overflow has undefined behavior.
17389
1f1d9321 17390 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 17391 (wordify): Omit three unnecessary tests.
1f1d9321 17392
c59478bc
PE
17393 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
17394 All callers changed. This avoids the need for an unused var.
17395
79b73827
PE
17396 * casefiddle.c (casify_region): Remove var that is set but not used.
17397
a4db5dfe
PE
17398 * dired.c (file_name_completion): Remove var that is set but not used.
17399
43aae36e
PE
17400 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
17401
2a47c44d 17402 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 17403 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 17404
a37c69bf
PE
17405 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
17406 Check for integer overflow on size calculations.
17407
328ab8e7
PE
17408 * buffer.c (Fprevious_overlay_change): Remove var that is set
17409 but not used.
17410
e5a2a5cb
PE
17411 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
17412 Remove vars that are set but not used.
8d84a6eb 17413 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 17414 (timer_check_2): Mark vars as initialized.
e5a2a5cb 17415
a60e5f68
PE
17416 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
17417
f661cb61 17418 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 17419 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 17420
f0397f5a
PE
17421 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
17422 that are set but not used.
17423
8664db06 17424 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 17425 if XCreateBitmapFromData fails (Bug#8410).
8664db06 17426
6abdaa4a
PE
17427 * xselect.c (x_get_local_selection, x_handle_property_notify):
17428 Remove vars that are set but not used.
17429
0ce7538d 17430 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 17431 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 17432
9ae848fc
PE
17433 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
17434 Remove var that is set but not used.
0b918413
PE
17435 (scroll_bar_windows_size): Now size_t, not int.
17436 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
17437 Check for overflow.
9ae848fc 17438
a5a62657
PE
17439 * xfaces.c (realize_named_face): Remove vars that are set but not used.
17440 (map_tty_color) [!defined MSDOS]: Likewise.
17441
5c5cdd39
PE
17442 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
17443
66ebf983
PE
17444 * coding.c: Remove vars that are set but not used.
17445 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
17446 All callers changed.
17447 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
17448 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
17449 (decode_coding_charset): Remove vars that are set but not used.
17450
1be4d761
PE
17451 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
17452 that is set but not used.
17453
47553fa8
PE
17454 * print.c (print_object): Remove var that is set but not used.
17455
1f7196bf 17456 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
17457 The gnulib version avoids calling malloc in the usual case,
17458 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
17459 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
17460 * filelock.c (current_lock_owner): Likewise.
17461 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
17462 * sysdep.c: Include allocator.h, careadlinkat.h.
17463 (emacs_no_realloc_allocator): New static constant.
17464 (emacs_readlink): New function.
fdb61804
PE
17465 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
17466 ../lib/careadlinkat.h.
d1fdcab7 17467
f84c17c7
SM
174682011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
17469
17470 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
17471 first non-nil return value).
17472
ef3862ad
JD
174732011-04-03 Jan Djärv <jan.h.d@swipnet.se>
17474
17475 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
17476 if not defined (Bug#8403).
17477
376a7006
JB
174782011-04-02 Juanma Barranquero <lekktu@gmail.com>
17479
17480 * xdisp.c (display_count_lines): Remove parameter `start',
17481 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17482 (get_char_face_and_encoding): Remove parameter `multibyte_p',
17483 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17484 (fill_stretch_glyph_string): Remove parameters `row' and `area',
17485 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
17486 and thereabouts. All callers changed.
17487 (get_per_char_metric): Remove parameter `f', unused since
17488 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17489
6ca3801d
JM
174902011-04-02 Jim Meyering <meyering@redhat.com>
17491
17492 do not dereference NULL upon failed strdup
17493 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
17494 (ns_get_family): Likewise.
17495
d8e2b5ba
JB
174962011-04-02 Juanma Barranquero <lekktu@gmail.com>
17497
17498 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
17499
8c74fcbd
JD
175002011-04-02 Jan Djärv <jan.h.d@swipnet.se>
17501
17502 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
17503 later (Bug#8403).
17504
7200d79c
SM
175052011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
17506
03408648 17507 Add lexical binding.
7200d79c 17508
03408648
SM
17509 * window.c (Ftemp_output_buffer_show): New fun.
17510 (Fsave_window_excursion):
17511 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
17512
17513 * lread.c (lisp_file_lexically_bound_p): New function.
17514 (Fload): Bind Qlexical_binding.
17515 (readevalloop): Remove `evalfun' arg.
17516 Bind Qinternal_interpreter_environment.
17517 (Feval_buffer): Bind Qlexical_binding.
17518 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
17519 Mark as dynamic.
17520 (syms_of_lread): Declare `lexical-binding'.
17521
17522 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
17523
17524 * keyboard.c (eval_dyn): New fun.
17525 (menu_item_eval_property): Use it.
ca105506
SM
17526
17527 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 17528
03408648
SM
17529 * fns.c (concat, mapcar1): Accept byte-code-functions.
17530
17531 * eval.c (Fsetq): Handle lexical vars.
17532 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
17533 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
17534 (FletX, Flet): Obey lexical binding.
17535 (Fcommandp): Handle closures.
17536 (Feval): New `lexical' arg.
17537 (eval_sub): New function extracted from Feval. Use it almost
17538 everywhere where Feval was used. Look up vars in lexical env.
17539 Handle closures.
17540 (Ffunctionp): Move from subr.el.
17541 (Ffuncall): Handle closures.
17542 (apply_lambda): Remove `eval_flags'.
17543 (funcall_lambda): Handle closures and new byte-code-functions.
17544 (Fspecial_variable_p): New function.
17545 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
17546 but without exporting it to Lisp.
23aba0ea 17547
23aba0ea 17548 * doc.c (Fdocumentation, store_function_docstring):
03408648 17549 * data.c (Finteractive_form): Handle closures.
23aba0ea 17550
03408648
SM
17551 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
17552 interactive spec.
ba83908c 17553
04f2d78b
CB
17554 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
17555 New byte-codes.
03408648
SM
17556 (exec_byte_code): New function extracted from Fbyte_code to handle new
17557 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 17558
03408648 17559 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 17560
03408648 17561 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 17562
e2abce01
JB
175632011-03-31 Juanma Barranquero <lekktu@gmail.com>
17564
17565 * xdisp.c (redisplay_internal): Fix prototype.
17566
63696a73 175672011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 17568
63696a73 17569 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
17570 (try_scrolling): Use it when setting scroll_limit.
17571 Limit scrolling to 100 screen lines.
63696a73
EZ
17572 (redisplay_window): Even when falling back on "recentering",
17573 position point in the window according to scroll-conservatively,
17574 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
17575
17576 (try_scrolling): When point is above the window, allow searching
17577 as far as scroll_max, or one screenful, to compute vertical
17578 distance from PT to the scroll margin position. This prevents
17579 try_scrolling from unnecessarily failing when
17580 scroll-conservatively is set to a value slightly larger than the
17581 window height. Clean up the case of PT below the margin at bottom
17582 of window: scroll_max can no longer be INT_MAX. When aggressive
17583 scrolling is in use, don't let point enter the opposite scroll
17584 margin as result of the scroll.
17585 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
17586 threshold of 100 lines for never-recentering scrolling.
17587
e4cc2dfc
JB
175882011-03-31 Juanma Barranquero <lekktu@gmail.com>
17589
17590 * dispextern.h (move_it_by_lines):
17591 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
17592 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
17593 (message_log_check_duplicate): Remove parameters `prev_bol' and
17594 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17595 (redisplay_internal): Remove parameter `preserve_echo_area',
17596 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
17597
17598 * indent.c (Fvertical_motion):
17599 * window.c (window_scroll_pixel_based, Frecenter):
17600 Don't pass `need_y_p' to `move_it_by_lines'.
17601
1c470562
SM
176022011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
17603
44f230aa
SM
17604 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
17605 steal a few bits to be more compact.
17606 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
17607 Remove unneeded casts.
17608
1c470562
SM
17609 * bytecode.c (Fbyte_code): CAR and CDR can GC.
17610
888adce9
ZK
176112011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
17612
17613 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
17614 binding" message (bug#7967).
17615
f838ed7b
PE
176162011-03-30 Paul Eggert <eggert@cs.ucla.edu>
17617
77861b95
PE
17618 Fix more problems found by GCC 4.6.0's static checks.
17619
de6dbc14
PE
17620 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
17621 Remove unused local var.
17622
f838ed7b
PE
17623 * editfns.c (Fmessage_box): Remove unused local var.
17624
792c7b2b
PE
17625 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
17626 (note_mode_line_or_margin_highlight, note_mouse_highlight):
17627 Omit unused local vars.
c499e557 17628 * window.c (shrink_windows): Omit unused local var.
b01a1c29 17629 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
17630 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
17631 Omit unused local var.
17632
ba0165e1
PE
17633 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
17634 Don't assume string length fits in int.
32ad8845 17635 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 17636 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 17637
3c59b4c9
PE
17638 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
17639 instead of alloca (Bug#8344).
17640
a3eed478 17641 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 17642 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 17643
eb4d412d
PE
17644 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
17645
1658b401
PE
17646 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
17647 concerns.
17648
17649 * term.c (produce_glyphless_glyph): Remove unnecessary test.
17650
17651 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 17652
9a2c6e05
PE
17653 * keyboard.c (syms_of_keyboard): Use the same style as later
17654 in this function when indexing through an array. This also
17655 works around GCC bug 48267.
17656
03d0a109
PE
17657 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
17658
44f730c8
PE
17659 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
17660
fe75f926
PE
17661 * chartab.c (sub_char_table_ref_and_range): Redo for slight
17662 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
17663
ffa8c828
PE
17664 * keyboard.c, keyboard.h (num_input_events): Now size_t.
17665 This avoids undefined behavior on integer overflow, and is a bit
17666 more convenient anyway since it is compared to a size_t variable.
17667
c5101a77
PE
17668 Variadic C functions now count arguments with size_t, not int.
17669 This avoids an unnecessary limitation on 64-bit machines, which
17670 caused (substring ...) to crash on large vectors (Bug#8344).
17671 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
17672 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 17673 All variadic functions and their callers changed accordingly.
c5101a77
PE
17674 (struct gcpro.nvars): Now size_t, not int. All uses changed.
17675 * data.c (arith_driver, float_arith_driver): Likewise.
17676 * editfns.c (general_insert_function): Likewise.
17677 * eval.c (struct backtrace.nargs, interactive_p)
17678 (internal_condition_case_n, run_hook_with_args, apply_lambda)
17679 (funcall_lambda, mark_backtrace): Likewise.
17680 * fns.c (concat): Likewise.
17681 * frame.c (x_set_frame_parameters): Likewise.
17682 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
17683 0 if not found, not -1. All callers changed.
17684
dd3f25f7
PE
17685 * alloc.c (garbage_collect): Don't assume stack size fits in int.
17686 (stack_copy_size): Now size_t, not int.
17687 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
17688
461c2ab9
JB
176892011-03-28 Juanma Barranquero <lekktu@gmail.com>
17690
17691 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
17692 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17693 All callers changed.
17694
17695 * lisp.h (multibyte_char_to_unibyte):
17696 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
17697 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17698 * character.h (CHAR_TO_BYTE8):
17699 * cmds.c (internal_self_insert):
17700 * editfns.c (general_insert_function):
17701 * keymap.c (push_key_description):
17702 * search.c (Freplace_match):
17703 * xdisp.c (message_dolog, set_message_1): All callers changed.
17704
f6d62986
SM
177052011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
17706
17707 * keyboard.c (safe_run_hook_funcall): New function.
17708 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
17709 don't set the hook to nil, but remove the offending function instead.
17710 (Qcommand_hook_internal): Remove, unused.
17711 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
17712 Vcommand_hook_internal.
17713
17714 * eval.c (enum run_hooks_condition): Remove.
17715 (funcall_nil, funcall_not): New functions.
17716 (run_hook_with_args): Call each function through a `funcall' argument.
17717 Remove `cond' argument, now redundant.
17718 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
17719 (Frun_hook_with_args_until_failure): Adjust accordingly.
17720 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
17721
1db5b1ad
JB
177222011-03-28 Juanma Barranquero <lekktu@gmail.com>
17723
17724 * dispextern.h (string_buffer_position): Remove declaration.
17725
17726 * print.c (strout): Remove parameter `multibyte', unused since
17727 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
17728
17729 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
17730 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
17731 All callers changed.
17732
17733 * w32.c (_wsa_errlist): Use braces for struct initializers.
17734
17735 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
17736 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
17737 All callers changed.
17738 (string_buffer_position): Likewise. Also, make static (it's never
17739 used outside xdisp.c).
17740 (cursor_row_p): Remove parameter `w', unused since
17741 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
17742 (decode_mode_spec): Remove parameter `precision', introduced during
17743 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
17744 All callers changed.
17745
5ffb62aa
JD
177462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17747
17748 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17749
461c2ab9 177502011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17751
17752 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17753 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17754 (ns_update_auto_hide_menu_bar): New functions.
17755 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17756 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17757 ns_constrain_all_frames.
17758 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17759 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17760
5c380ffb
JD
177612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17762
17763 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17764
9af30bdf
GM
177652011-03-27 Glenn Morris <rgm@gnu.org>
17766
17767 * syssignal.h: Replace RETSIGTYPE with void.
17768 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17769 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17770 Replace SIGTYPE with void everywhere.
17771 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17772 * s/template.h (SIGTYPE): Remove commented out definition.
17773
e2abce01
JB
177742011-03-26 Eli Zaretskii <eliz@gnu.org>
17775
17776 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17777 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17778
f868cd8a
JB
177792011-03-26 Juanma Barranquero <lekktu@gmail.com>
17780
59eb0929
JB
17781 * w32.c (read_unc_volume): Use parameter `henum', instead of
17782 global variable `wget_enum_handle'.
17783
17784 * keymap.c (describe_vector): Remove parameters `indices' and
17785 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17786 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17787
f868cd8a
JB
17788 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17789
17790 * keyboard.c (timer_check): Remove parameter `do_it_now',
17791 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17792 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17793 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17794
17795 * keyboard.c (read_char):
17796 * w32menu.c (w32_menu_display_help):
17797 * xmenu.c (show_help_event, menu_help_callback):
17798 Adjust calls to `show_help_echo'.
17799
17800 * gtkutil.c (xg_maybe_add_timer):
17801 * keyboard.c (readable_events):
17802 * process.c (wait_reading_process_output):
17803 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17804
17805 * insdel.c (adjust_markers_gap_motion):
17806 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17807 (gap_left, gap_right): Don't call it.
17808
2ecf6fdb
CY
178092011-03-25 Chong Yidong <cyd@stupidchicken.com>
17810
17811 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17812 incurred during fontification.
17813
6b1f9ba4
JB
178142011-03-25 Juanma Barranquero <lekktu@gmail.com>
17815
17816 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17817 (DEFVAR_PER_BUFFER): Don't pass it.
17818
17819 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17820 (scrolling_window): Don't pass it.
17821
0f4a96b5
JB
178222011-03-25 Juanma Barranquero <lekktu@gmail.com>
17823
17824 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17825
17826 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17827 and `suffix'.
17828 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17829 of variables specific to SELinux and computation of `encoded_absname'.
17830
17831 * image.c (XPutPixel): Remove unused variable `height'.
17832
17833 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17834
17835 * unexw32.c (get_section_info): Remove unused variable `section'.
17836
17837 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17838 (system_process_attributes): Remove unused variable `sess'.
17839 (sys_read): Remove unused variable `err'.
17840
17841 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17842 (w32_wnd_proc): Remove unused variable `isdead'.
17843 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17844 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17845 (x_create_tip_frame): Remove unused variable `tem'.
17846
17847 * w32inevt.c (w32_console_read_socket):
17848 Remove unused variable `no_events'.
17849
17850 * w32term.c (x_draw_composite_glyph_string_foreground):
17851 Remove unused variable `width'.
17852
1149507c
JB
178532011-03-24 Juanma Barranquero <lekktu@gmail.com>
17854
17855 * w32term.c (x_set_glyph_string_clipping):
17856 Don't pass uninitialized region to CombineRgn.
17857
9c88f339
JB
178582011-03-23 Juanma Barranquero <lekktu@gmail.com>
17859
17860 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17861 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17862 (Fx_close_connection): Remove unused variable `i'.
17863
17864 * w32font.c (w32font_draw): Return number of glyphs.
17865 (w32font_open_internal): Remove unused variable `i'.
17866 (w32font_driver): Add missing initializer.
17867
17868 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17869 (fill_in_menu): Remove unused variable `items_added'.
17870
17871 * w32term.c (last_mouse_press_frame): Remove static global variable.
17872 (w32_clip_to_row): Remove unused variable `f'.
17873 (x_delete_terminal): Remove unused variable `i'.
17874
17875 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17876 (NOTHING): Remove unused static global variable.
17877 (uniscribe_check_otf): Remove unused variable `table'.
17878 (uniscribe_font_driver): Add missing initializers.
17879
dee091a3
JD
178802011-03-23 Julien Danjou <julien@danjou.info>
17881
17882 * term.c (Fsuspend_tty, Fresume_tty):
17883 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17884 * window.c (temp_output_buffer_show):
17885 * insdel.c (signal_before_change):
17886 * frame.c (Fhandle_switch_frame):
17887 * fileio.c (Fdo_auto_save):
17888 * emacs.c (Fkill_emacs):
17889 * editfns.c (save_excursion_restore):
17890 * cmds.c (internal_self_insert):
17891 * callint.c (Fcall_interactively):
17892 * buffer.c (Fkill_all_local_variables):
17893 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17894 Use Frun_hooks.
0f4a96b5 17895 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17896 unconditionally since it does the check itself.
dee091a3 17897
2c520ab5 178982011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17899
c9c49752
PE
17900 Fix more problems found by GCC 4.5.2's static checks.
17901
8abc3f12
PE
17902 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17903 the first time through the loop, since we know p0 < p1 then.
17904 This also avoids a gcc -Wstrict-overflow warning.
17905
a2d26660
PE
17906 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17907 leading to a memory leak, possible in functions like
17908 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17909 of objects (Bug#8318).
a2d26660 17910
916c72e9
PE
17911 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17912 that could (at least in theory) be that large.
17913
19ab8a18
PE
17914 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17915 This is less likely to overflow, and avoids undefined behavior if
17916 overflow does occur. All callers changed. Use strtoul to scan
17917 for the unsigned long integer.
b7cbbd6f
PE
17918 (pint2hrstr): Simplify and tune code slightly.
17919 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17920
f0641eff
PE
17921 * scroll.c (do_scrolling): Work around GCC bug 48228.
17922 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17923
7f650bb9
PE
17924 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17925 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17926 (validate_x_resource_name): Simplify count usage.
17927 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17928
37dd57d1
PE
17929 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17930 fail (Bug#8306).
81e56e61 17931
699979fc 17932 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17933
401bf9b4
PE
17934 * process.c (Fmake_network_process): Use socklen_t, not int,
17935 where POSIX says socklen_t is required in portable programs.
17936 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17937 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17938 (Fmake_network_process, server_accept_connection):
17939 (wait_reading_process_output, read_process_output):
17940 Likewise.
17941
b93aacde
PE
17942 * process.c: Rename or move locals to avoid shadowing.
17943 (list_processes_1, Fmake_network_process):
17944 (read_process_output_error_handler, exec_sentinel_error_handler):
17945 Rename or move locals.
4dc343ee 17946 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17947 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17948 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17949 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17950 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17951
af8a867c 17952 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17953 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17954 Include tparam.h instead, since it declares them.
af8a867c
PE
17955 * cm.h (PC): Remove extern decl; tparam.h now does this.
17956 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17957 * terminfo.c: Include tparam.h, to check interfaces.
17958 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17959 (tparam): Adjust signature to match interface in tparam.h;
17960 this removes some undefined behavior. Check that outstring and len
17961 are zero, which they always are with Emacs.
17962 * tparam.h (PC, BC, UP): New extern decls.
17963
0248044d 17964 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17965 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17966
8ff096c1 17967 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17968 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17969 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17970 (ftfont_list): Remove unused local.
49eaafba
PE
17971 (get_adstyle_property, ftfont_pattern_entity):
17972 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17973 Rename locals to avoid shadowing.
8ff096c1 17974
e2be39f6
PE
17975 * xfont.c (xfont_list_family): Mark var as initialized.
17976
c9735e30
PE
17977 * xml.c (make_dom): Now static.
17978
8f5201ae
PE
17979 * composite.c (composition_compute_stop_pos): Rename local to
17980 avoid shadowing.
b246f932
PE
17981 (composition_reseat_it): Remove unused locals.
17982 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17983 (composition_update_it): Mark var as initialized.
11b61122
PE
17984 (find_automatic_composition): Mark vars as initialized,
17985 with a FIXME (Bug#8290).
8f5201ae 17986
760fbc2c
PE
17987 character.h: Rename locals to avoid shadowing.
17988 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17989 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17990 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17991 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17992 to avoid shadowing.
17993
ff08eb85
PE
17994 * textprop.c (property_change_between_p): Remove; unused.
17995
fc7bf025
PE
17996 * intervals.c (interval_start_pos): Now static.
17997
235d7abc
PE
17998 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17999
44f230aa
SM
18000 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
18001 Rename locals to avoid shadowing.
3e7d6594 18002
50060332
PE
18003 * sound.c (wav_play, au_play, Fplay_sound_internal):
18004 Fix pointer signedness.
d01f234b 18005 (alsa_choose_format): Remove unused local var.
c83b8872
PE
18006 (wav_play): Initialize a variable to 0, to prevent undefined
18007 behavior (Bug#8278).
50060332 18008
c4fc4e30
PE
18009 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
18010
918436ed
PE
18011 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
18012
c939f91b
PE
18013 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
18014 clobbering (Bug#8298).
b9c7f648
PE
18015 * sysdep.c (sys_subshell): Likewise.
18016 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 18017
6bd8c144
PE
18018 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
18019 This should get cleaned up, so that child_setup has the
18020 same signature on all platforms.
18021
7710357c 18022 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 18023 (relocate_fd): Rename locals to avoid shadowing.
7710357c 18024
c59da222
CY
180252011-03-22 Chong Yidong <cyd@stupidchicken.com>
18026
18027 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
18028 not to be necessary, and produces flickering.
18029
66b87493
GM
180302011-03-20 Glenn Morris <rgm@gnu.org>
18031
18032 * config.in: Remove file.
18033
45b6f6d5
JB
180342011-03-20 Juanma Barranquero <lekktu@gmail.com>
18035
18036 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
18037 are now in src/globals.h.
18038 (syms_of_minibuf): Remove spurious & from previous change.
18039
cd394be1 180402011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
18041
18042 * minibuf.c (completing-read-function): New variable.
18043 (completing-read-default): Rename from completing-read.
18044 (completing-read): Call completing-read-function.
18045
b14e3e21
CY
180462011-03-19 Juanma Barranquero <lekktu@gmail.com>
18047
18048 * xfaces.c (Fx_load_color_file):
18049 Read color file from absolute filename (bug#8250).
18050
f2b726e6
JB
180512011-03-19 Juanma Barranquero <lekktu@gmail.com>
18052
18053 * makefile.w32-in: Update dependencies.
18054
09f6ff02
EZ
180552011-03-17 Eli Zaretskii <eliz@gnu.org>
18056
18057 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
18058
29a6015a
PE
180592011-03-17 Paul Eggert <eggert@cs.ucla.edu>
18060
a3a6c54e
PE
18061 Fix more problems found by GCC 4.5.2's static checks.
18062
b766f867
PE
18063 * process.c (make_serial_process_unwind, send_process_trap):
18064 (sigchld_handler): Now static.
18065
be02381c
PE
18066 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
18067 That way, the code declares only the vars that it needs.
18068 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
18069 * s/cygwin.h (PTY_ITERATION): Likewise.
18070 * s/darwin.h (PTY_ITERATION): Likewise.
18071 * s/gnu-linux.h (PTY_ITERATION): Likewise.
18072
57048744
PE
18073 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
18074 * process.c (allocate_pty): Don't declare stb unless it's needed.
18075
7914961c 18076 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
18077 (CONSTANTLIM): Remove; unused.
18078 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
18079 Define only if needed.
7914961c 18080
b3967b18
PE
18081 * unexelf.c (unexec): Name an expression,
18082 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
18083 Use a different way to cause a compilation error if anyone uses
18084 n rather than nn, a way that does not involve shadowing.
73366a00 18085 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 18086
29a6015a
PE
18087 * deps.mk (unexalpha.o): Remove; unused.
18088
43cfc33e 18089 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 18090 * unexec.h: New file.
ce701a33
PE
18091 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
18092 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
18093 Depend on unexec.h.
18094 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
18095 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
18096 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 18097 Change as necessary to match prototype in unexec.h.
ce701a33 18098
01f44d5a
PE
18099 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
18100 shadowing.
4f63c6bb 18101 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 18102
a6670b0b
PE
18103 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
18104 Rename locals to avoid shadowing.
18105
cef2010d 18106 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 18107 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 18108
d4d7173a
PE
18109 * print.c (Fredirect_debugging_output): Fix pointer signedess.
18110
f08b802a
PE
18111 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
18112 warning when compiling print.c.
18113
3ddb0639
PE
18114 * font.c (font_unparse_fcname): Abort in an "impossible" situation
18115 instead of using an uninitialized var.
5ad03b97 18116 (font_sort_entities): Mark var as initialized.
3ddb0639 18117
170a2692
PE
18118 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
18119
e663c700
PE
18120 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
18121 pointers to constants.
89bc529a 18122 (font_parse_fcname): Remove unused vars.
7b81e2d0 18123 (font_delete_unmatched): Now static.
ea838e10 18124 (font_get_spec): Remove; unused.
13a547c6
PE
18125 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
18126 (font_update_drivers, Ffont_get_glyphs, font_add_log):
18127 Rename or move locals to avoid shadowing.
e663c700 18128
2a80c887 18129 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 18130 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 18131
1384fa33 18132 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 18133 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 18134
8b2c52e9
PE
18135 * alloc.c (mark_backtrace): Move decl from here ...
18136 * lisp.h: ... to here, so that it can be checked.
18137
475545b5 18138 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 18139 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
18140 (lisp_indirect_variable): Name an expression,
18141 to avoid gcc -Wbad-function-cast warning.
1faed8ae 18142 (Fdefvar): Rename locals to avoid shadowing.
475545b5 18143
b1349114 18144 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 18145 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 18146 Use const pointer when appropriate.
b1349114 18147
a2928364
PE
18148 * lisp.h (get_system_name, get_operating_system_release):
18149 Move decls here, to check interfaces.
18150 * process.c (get_operating_system_release): Move decl to lisp.h.
18151 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
18152 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
18153 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
18154 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
18155 (Fformat_time_string, Fencode_time, Finsert_char):
18156 (Ftranslate_region_internal, Fformat):
18157 Rename or remove local vars to avoid shadowing.
9710023e 18158 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 18159
a415e694
PE
18160 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
18161 avoid shadowing.
18162
8ef4622d
PE
18163 * lisp.h (eassert): Check that the argument compiles, even if
18164 ENABLE_CHECKING is not defined.
18165
946f9a5b
PE
18166 * data.c (Findirect_variable): Name an expression, to avoid
18167 gcc -Wbad-function-cast warning.
112396d6 18168 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 18169 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
18170 (Fmake_variable_buffer_local, Fmake_local_variable):
18171 Mark variables as initialized.
52746918 18172 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 18173
e5aab7e7 18174 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
18175 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
18176 Rename locals to avoid shadowing.
dff45157
PE
18177 (mark_stack): Move local variables into the #ifdef region where
18178 they're used.
7bc26fdb
PE
18179 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
18180 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
18181 needed otherwise.
18182 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
18183 (GC_STRING_CHARS): Remove; not used.
d40d4be1 18184 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 18185
e5aab7e7
PE
18186 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
18187 avoids undefined behavior in theory.
18188
4da60324
PE
18189 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
18190
88043301
PE
18191 Use functions, not macros, for up- and down-casing (Bug#8254).
18192 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18193 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
18194 to use the following functions instead of these macros.
18195 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
18196 EMACS_INT, since callers assume the returned value fits in int.
18197 (upcase1): Likewise, for UPCASE_TABLE.
18198 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 18199 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 18200 the race-condition problem in the old DOWNCASE.
88043301 18201
19ed5445
PE
18202 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
18203 Rename locals to avoid shadowing.
18204 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
18205 (regex_compile, re_search_2, re_match_2_internal):
18206 Remove unused local vars.
952db0d7
PE
18207 (FREE_VAR): Rewrite so as not to use empty "else",
18208 which gcc can warn about.
da053e48 18209 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
18210 (RETALLOC_IF): Define only if needed.
18211 (WORDCHAR_P): Likewise. This one is never needed, but is used
18212 only in a comment talking about a compiler bug, so put inside
18213 the #if 0 of that comment.
18214 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
18215 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
18216 Remove; unused.
19ed5445 18217
1f3561e4 18218 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
18219 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
18220 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 18221
ded6f8f7
PE
18222 * search.c (simple_search): Remove unused var.
18223
dbd37a95
PE
18224 * dired.c (compile_pattern): Move decl from here ...
18225 * lisp.h: ... to here, so that it can be checked.
18226 (struct re_registers): New forward decl.
18227
7e47afad
PE
18228 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
18229
85f24f61
PE
18230 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
18231 All uses changed.
18232 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
18233 Rename locals to avoid shadowing.
5671df8f 18234 (Fvertical_motion): Mark locals as initialized.
85f24f61 18235
181aa2be 18236 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 18237 (casify_region): Mark local as initialized.
181aa2be 18238
930d429c
PE
18239 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
18240
7082eac6
PE
18241 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
18242 New macros, so that the caller can use some names other than
18243 gcpro1, gcpro2, etc.
18244 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
18245 of the new macros.
18246 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
18247 argument, for consistency with GCPRO2_VAR, etc: it is now the
18248 prefix of the variable, not the variable itself. All uses
18249 changed.
38b2c076
PE
18250 * dired.c (directory_files_internal, file_name_completion):
18251 Rename locals to avoid shadowing.
18252
15206ed9
PE
18253 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
18254 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
18255 dired.c's scmp function, had undefined behavior.
18256 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18257 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
18258 * buffer.h: ... to here, because these macros use current_buffer,
18259 and the new implementation with inline functions needs to have
18260 current_buffer in scope now, rather than later when the macros
18261 are used.
18262 (downcase, upcase1): New static inline functions.
18263 (DOWNCASE, UPCASE1): Reimplement using these functions.
18264 This avoids undefined behavior in expressions like
18265 DOWNCASE (x) == DOWNCASE (y), which previously suffered
18266 from race conditions in accessing the global variables
18267 case_temp1 and case_temp2.
18268 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
18269 * lisp.h (case_temp1, case_temp2): Remove their decls.
18270 * character.h (ASCII_CHAR_P): Move from here ...
18271 * lisp.h: ... to here, so that the inline functions mentioned
18272 above can use them.
18273
4a6bea26
PE
18274 * dired.c (directory_files_internal_unwind): Now static.
18275
f14b7e14
PE
18276 * fileio.c (file_name_as_directory, directory_file_name):
18277 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
18278 Now static.
2893f146
PE
18279 (file_name_as_directory): Use const pointers when appropriate.
18280 (Fexpand_file_name): Likewise. In particular, newdir might
18281 point at constant storage, so make it a const pointer.
fd4ead52 18282 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
18283 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
18284 signedness issues.
f839df0c
PE
18285 (Fset_file_times, Finsert_file_contents, auto_save_error):
18286 Rename locals to avoid shadowing.
f14b7e14 18287
5716756e 18288 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
18289 (Ftry_completion, Fall_completions): Rename or remove locals
18290 to avoid shadowing.
5716756e 18291
b4c3046a
PE
18292 * marker.c (bytepos_to_charpos): Remove; unused.
18293
b45db522
PE
18294 * lisp.h (verify_bytepos, count_markers): New decls,
18295 so that gcc does not warn that these functions aren't declared.
18296
85876d07
PE
18297 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
18298 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 18299 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 18300 (copy_text): Remove unused local var.
85876d07 18301
03d78a21 18302 * filelock.c (within_one_second): Now static.
b3dd38ab 18303 (lock_file_1): Rename local to avoid shadowing.
03d78a21 18304
5df8f01b
PE
18305 * buffer.c (fix_overlays_before): Mark locals as initialized.
18306 (fix_start_end_in_overlays): Likewise. This function should be
18307 simplified by using pointers-to-pointers, but that's a different
18308 matter.
b1d876f1 18309 (switch_to_buffer_1): Now static.
8f54f30a
PE
18310 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
18311 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 18312
a70072c9 18313 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 18314 Fix pointer signedness issue.
edced198
PE
18315 (sys_subshell): Mark local as volatile if checking for lint,
18316 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 18317 (MAXPATHLEN): Define only if needed.
a70072c9 18318
a0977c44
PE
18319 * process.c (serial_open, serial_configure): Move decls from here ...
18320 * systty.h: ... to here, so that they can be checked.
18321
a884fdcc
PE
18322 * fns.c (get_random, seed_random): Move extern decls from here ...
18323 * lisp.h: ... to here, so that they can be checked.
18324
604efe86 18325 * sysdep.c (reset_io): Now static.
b8950c94 18326 (wait_for_termination_signal): Remove; unused.
604efe86 18327
38fc62d9
PE
18328 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
18329 (copy_keymap_item, append_key, push_text_char_description):
18330 Now static.
1004a21a 18331 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 18332 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
18333 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
18334 (describe_map_tree):
18335 Rename locals to avoid shadowing.
38fc62d9 18336
2f2650da
PE
18337 * keyboard.c: Declare functions static if they are not used elsewhere.
18338 (echo_char, echo_dash, cmd_error, top_level_2):
18339 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
18340 (read_char, kbd_buffer_get_event, make_lispy_position):
18341 (make_lispy_event, make_lispy_movement, apply_modifiers):
18342 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
18343 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
18344 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 18345 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 18346 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 18347
a053e86c 18348 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
18349 (mark_kboards): Move decl here ...
18350 * alloc.c (mark_kboards): ... from here.
a053e86c 18351
4752793e
PE
18352 * lisp.h (force_auto_save_soon): New decl.
18353
74f10ca7 18354 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
18355 (DEFINE_DUMMY_FUNCTION): New macro.
18356 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
18357 Use it.
c03cd23f
PE
18358 (main): Add casts to avoid warnings
18359 if GCC considers string literals to be constants.
74f10ca7 18360
022e70d4
PE
18361 * lisp.h (fatal_error_signal): Add decl, since it's exported.
18362
59d6fe83
PE
18363 * dbusbind.c: Pointer signedness fixes.
18364 (xd_signature, xd_append_arg, xd_initialize):
18365 (Fdbus_call_method, Fdbus_call_method_asynchronously):
18366 (Fdbus_method_return_internal, Fdbus_method_error_internal):
18367 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
18368 (Fdbus_register_signal): Use SSDATA when the context wants char *.
18369
78320123
PE
18370 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
18371 if GCC considers string literals to be constants.
49cebcca 18372 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 18373
35ac2a97
SM
183742011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
18375
fb103ca9
SM
18376 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
18377 (print_preprocess, print_object): New macro to fix last change.
18378
35ac2a97
SM
18379 * print.c (print_preprocess): Don't forget font objects.
18380
62973b41
JB
183812011-03-16 Juanma Barranquero <lekktu@gmail.com>
18382
18383 * emacs.c (USAGE3): Doc fixes.
18384
0e48bb22
AS
183852011-03-15 Andreas Schwab <schwab@linux-m68k.org>
18386
18387 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
18388 structure.
18389
7684e57b
JB
183902011-03-14 Juanma Barranquero <lekktu@gmail.com>
18391
18392 * lisp.h (VWindow_system, Qfile_name_history):
18393 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
18394 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
18395 (w32_system_caret_x, w32_system_caret_y): Declare extern.
18396
18397 * w32select.c: Don't #include "keyboard.h".
c96bbc66 18398 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
18399
18400 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
18401 * w32console.c (detect_input_pending, read_input_pending)
18402 (encode_terminal_code):
18403 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
18404 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
18405 (w32_system_caret_y, Qfile_name_history):
18406 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
18407 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
18408 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
18409 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
18410 * w32proc.c (Qlocal, report_file_error):
18411 * w32term.c (Vwindow_system, updating_frame):
18412 * w32uniscribe.c (initialized, uniscribe_font_driver):
18413 Remove unneeded extern declarations.
18414
2aa46d6c
CY
184152011-03-14 Chong Yidong <cyd@stupidchicken.com>
18416
c96bbc66 18417 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 18418
cffc6f3b
CY
184192011-03-13 Chong Yidong <cyd@stupidchicken.com>
18420
18421 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
18422 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
18423 These macros can no longer be used for assignment.
18424
44f230aa
SM
18425 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
18426 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
18427 (record_buffer_markers, fetch_buffer_markers): New functions for
18428 recording and fetching special buffer markers.
18429 (set_buffer_internal_1, set_buffer_temp): Use them.
18430
18431 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
18432
18433 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
18434
18435 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
18436 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
18437
18438 * xdisp.c (hscroll_window_tree):
18439 (reconsider_clip_changes): Use PT instead of BUF_PT.
18440
d251f04b
EZ
184412011-03-13 Eli Zaretskii <eliz@gnu.org>
18442
18443 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
18444 $(EMACS_ROOT)/lib/intprops.h.
18445
f0c77cd1
PE
184462011-03-13 Paul Eggert <eggert@cs.ucla.edu>
18447
3eca4629
PE
18448 Fix more problems found by GCC 4.5.2's static checks.
18449
7c86ee98
PE
18450 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
18451 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
18452 (xg_free_frame_widgets): Make it clear that a local variable is
18453 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
18454 (gdk_window_get_screen): Make it clear that this macro is needed
18455 only if USE_GTK_TOOLTIP.
1e5524e7
PE
18456 (int_gtk_range_get_value): New function, which avoids a diagnostic
18457 from gcc -Wbad-function-cast.
18458 (xg_set_toolkit_scroll_bar_thumb): Use it.
18459 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
18460 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
18461 (get_utf8_string, xg_get_file_with_chooser):
18462 Rename locals to avoid shadowing.
18463 (create_dialog): Move locals to avoid shadowing.
7c86ee98 18464
41729b81
PE
18465 * xgselect.c (xg_select): Remove unused var.
18466
f0c77cd1
PE
18467 * image.c (four_corners_best): Mark locals as initialized.
18468 (gif_load): Initialize transparent_p to zero (Bug#8238).
18469 Mark another local as initialized.
ec6cf4c6 18470 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 18471
ce0ad53d 18472 * image.c (clear_image_cache): Now static.
d5d5a617 18473 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 18474 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
18475 (x_edge_detection): Remove unnecessary cast that
18476 gcc -Wbad-function-cast diagnoses.
2037898d 18477 (gif_load): Fix pointer signedness.
6ae141d6
PE
18478 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
18479 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 18480
33383987 184812011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 18482
d32df629
PE
18483 Improve quality of tests for time stamp overflow.
18484 For example, without this patch (encode-time 0 0 0 1 1
18485 1152921504606846976) returns the obviously-bogus value (-948597
18486 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
18487 reports time overflow. See
18488 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
18489 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
18490 * editfns.c: Include limits.h and intprops.h.
18491 (TIME_T_MIN, TIME_T_MAX): New macros.
18492 (time_overflow): Move earlier, to before first use.
18493 (hi_time, lo_time): New functions, for an accurate test for
18494 out-of-range times.
18495 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
18496 (Fget_internal_run_time): Don't assume time_t fits in int.
18497 (make_time): Use list2 instead of Fcons twice.
18498 (Fdecode_time): More accurate test for out-of-range times.
18499 (check_tm_member): New function.
18500 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
18501 (lisp_time_argument): Don't rely on undefined left-shift and
18502 right-shift behavior when checking for time stamp overflow.
8be6f318 18503
fe31d94c
PE
18504 * editfns.c (time_overflow): New function, refactoring common code.
18505 (Fformat_time_string, Fdecode_time, Fencode_time):
18506 (Fcurrent_time_string): Use it.
18507
8be6f318
PE
18508 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
18509 * dired.c (make_time): Move to ...
18510 * editfns.c (make_time): ... here.
18511 * systime.h: Note the move.
18512
09d9db2c 185132011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 18514
126bc0dc
YM
18515 * fringe.c (update_window_fringes): Remove unused variables.
18516
c47cbdfd
YM
18517 * unexmacosx.c (copy_data_segment): Also copy __got section.
18518 (Bug#8223)
18519
7ac80be9
EZ
185202011-03-12 Eli Zaretskii <eliz@gnu.org>
18521
c96bbc66 18522 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
18523 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
18524 Constify `char *' arguments and their references according to
18525 prototypes in tparam.h.
18526
ecb0f94d 18527 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 18528
7ac80be9
EZ
18529 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
18530 Adapt all references accordingly.
18531
18532 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
18533
ef1fd07e
TT
185342011-03-11 Tom Tromey <tromey@redhat.com>
18535
18536 * buffer.c (syms_of_buffer): Remove obsolete comment.
18537
7ef4b50c
EZ
185382011-03-11 Eli Zaretskii <eliz@gnu.org>
18539
18540 * termhooks.h (encode_terminal_code): Declare prototype.
18541
18542 * msdos.c (encode_terminal_code): Don't declare prototype.
18543
18544 * term.c (encode_terminal_code): Now external again, used by
18545 w32console.c and msdos.c.
18546
44f230aa
SM
18547 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
18548 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 18549
4b1ec863 185502011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 18551
1714f52b 18552 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 18553
4b1ec863
PE
18554 * fringe.c (update_window_fringes): Mark locals as initialized
18555 (Bug#8227).
18556 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 18557
524c7aa6
PE
18558 * alloc.c (mark_fringe_data): Move decl from here ...
18559 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
18560 to check its interface.
18561 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
18562
a5c0af81 18563 * fontset.c (free_realized_fontset): Now static.
7519b8cd 18564 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 18565 (fontset_font): Mark local as initialized.
a9a06e0b 18566 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 18567
b4716021
PE
18568 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
18569
811e9bac 18570 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 18571 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
18572 (x_own_selection, Fx_disown_selection_internal): Rename locals
18573 to avoid shadowing.
18574 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 18575
7e3ab302
PE
18576 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
18577 so that the caller can use some name other than gcpro1.
18578 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
18579 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18580 (Fx_backspace_delete_keys_p):
18581 Use them to avoid shadowing, and rename vars to avoid shadowing.
18582 (x_decode_color, x_set_name, x_window): Now static.
6b437900 18583 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 18584 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
18585 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
18586 Remove unused locals.
7e3ab302
PE
18587 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18588 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
18589 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
18590 macros.
f78faa98 18591
e2b13473
PE
18592 * xterm.h (x_mouse_leave): New decl.
18593
77f23912
PE
18594 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
18595 Remove unused functions.
cdf4ba58
PE
18596 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
18597 (x_calc_absolute_position): Now static.
7411c686 18598 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 18599 Don't declare local "event" unless it's used.
ed7bf3a5
PE
18600 (x_iconify_frame, x_free_frame_resources): Don't declare locals
18601 unless they are used.
38d0b34a
PE
18602 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
18603 (x_fatal_error_signal): Remove; not used.
a6067996
PE
18604 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
18605 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
18606 (x_error_catcher, x_connection_closed, x_error_handler):
18607 (x_error_quitter, xembed_send_message, x_iconify_frame):
18608 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 18609 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 18610 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 18611
44f230aa
SM
18612 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
18613 Rename or move locals to avoid shadowing.
6b463e58 18614 (tty_defined_color, merge_face_heights): Now static.
5967d051 18615 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
18616 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
18617 does not deduce is never used uninitialized.
73719eba
PE
18618 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
18619 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 18620
426994c3 18621 * terminal.c (store_terminal_param): Now static.
5489860b 18622
032f1620 18623 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 18624 (set_frame_menubar): Remove unused local.
d4323972 18625 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
18626 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
18627 since they might point to immutable storage.
281585b0
PE
18628 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
18629 since it's unused otherwise.
032f1620 18630
367c19e5 18631 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 18632 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
18633 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
18634 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 18635 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
18636 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
18637 does not deduce are never used uninitialized.
70739cbe 18638
07b48fa9
PE
18639 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
18640
8868a238 18641 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
18642 * window.c (window_loop, size_window):
18643 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 18644
7e5cf297 18645 * window.c (display_buffer): Now static.
d6550a9f
PE
18646 (size_window): Mark variables that gcc -Wuninitialized
18647 does not deduce are never used uninitialized.
a586633d
PE
18648 * window.h (check_all_windows): New decl, to forestall
18649 gcc -Wmissing-prototypes diagnostic.
5b555da1 18650 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 18651
f6095868
PE
18652 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
18653 shadowing.
18654 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
18655 Include <limits.h>.
18656 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
18657 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
18658 (load_charset_map): Mark variables that gcc -Wuninitialized
18659 does not deduce are never used uninitialized.
53df7c11 18660 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 18661
f38b440c
PE
18662 * coding.c (coding_set_source, coding_set_destination):
18663 Use "else { /* comment */ }" rather than "else /* comment */;"
18664 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
18665 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
18666 a block, when the outer 'i' will do.
18667 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
18668 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
18669 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
18670 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
18671 (Fdecode_sjis_char, Fdefine_coding_system_internal):
18672 Rename locals to avoid shadowing.
18673 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
18674 * coding.c (emacs_mule_char, encode_invocation_designation):
18675 Now static, since they're not used elsewhere.
413bb2db 18676 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 18677 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
18678 (decode_coding_emacs_mule): Mark variables that gcc
18679 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
18680 (detect_coding_iso_2022): Initialize a local variable that might
18681 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 18682 this initialization is needed. (Bug#8211)
5f58e762
PE
18683 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
18684 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
18685 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
18686 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
18687 Remove unused macros.
f38b440c 18688
232b38b9 18689 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 18690 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 18691 * character.c (string_count_byte8): Likewise.
232b38b9 18692
fb90da1b
PE
18693 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
18694 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
18695
fb93dbc2
PE
18696 * chartab.c (copy_sub_char_table): Now static, since it's not used
18697 elsewhere.
5c156ace
PE
18698 (sub_char_table_ref_and_range, char_table_ref_and_range):
18699 Rename locals to avoid shadowing.
bbcd0949 18700 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 18701
7d3b3862 18702 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 18703 (BIDI_BOB): Remove unused macro.
7d3b3862 18704
6be7d3da
PE
18705 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
18706 deduce are never used uninitialized.
c2ed9c8b 18707 * term.c (encode_terminal_code): Likewise.
6be7d3da 18708
75f8807f 18709 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 18710
50938595
PE
18711 * tparam.h: New file.
18712 * term.c, tparam.h: Include it.
18713 * deps.mk (term.o, tparam.o): Depend on tparam.h.
18714 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
18715 Move these decls to tparam.h, and make them agree with what
18716 is actually in tparam.c. The previous trick of using incompatible
18717 decls in different modules does not conform to the C standard.
18718 All callers of tparam changed to use tparam's actual API.
18719 * tparam.c (tparam1, tparam, tgoto):
18720 Use const pointers where appropriate.
18721
fbceeba2
PE
18722 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
18723 * cm.h (struct cm): Likewise.
18724 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
18725 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
18726 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
18727 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
18728 (turn_on_face, init_tty): Likewise.
18729 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 18730
7f3f1250
PE
18731 * term.c (term_mouse_position): Rename local to avoid shadowing.
18732
e6ca6543
PE
18733 * alloc.c (mark_ttys): Move decl from here ...
18734 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
18735
c40f8d15
AS
187362011-03-11 Andreas Schwab <schwab@linux-m68k.org>
18737
18738 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
18739
cfe0661d
JB
187402011-03-09 Juanma Barranquero <lekktu@gmail.com>
18741
18742 * search.c (compile_pattern_1): Remove argument regp, unused since
18743 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
18744 (compile_pattern): Don't pass it.
18745
0afb4571
J
187462011-03-08 Jan Djärv <jan.h.d@swipnet.se>
18747
18748 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18749 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18750 for ! HAVE_GTK3.
18751 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18752
18753 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18754
18755 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18756 gdk_window_get_screen, gdk_window_get_geometry,
18757 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18758 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18759 (xg_get_pixbuf_from_pixmap): New function.
18760 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18761 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18762 Call xg_get_pixbuf_from_pixmap instead of
18763 gdk_pixbuf_get_from_drawable.
18764 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18765 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18766 (xg_check_special_colors): Use GtkStyleContext and its functions
18767 for HAVE_GTK3.
18768 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18769 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18770 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18771 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18772 Call gtk_widget_get_preferred_size.
0afb4571
J
18773 (xg_frame_resized): gdk_window_get_geometry only takes 5
18774 parameters.
44f230aa
SM
18775 (xg_win_to_widget, xg_event_is_for_menubar):
18776 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18777 (xg_set_widget_bg): New function.
18778 (delete_cb): New function.
895009e1 18779 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18780 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18781 (xg_set_background_color): Call xg_set_widget_bg.
18782 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18783 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18784 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18785 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18786 if ! HAVE_GTK3.
18787 (update_frame_tool_bar): Call gtk_widget_hide.
18788 (xg_initialize): Use GDK_KEY_g.
18789
18790 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18791 if ! HAVE_GTK3
18792 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18793
18794 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18795 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18796 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18797
1c2cc4ef
JB
187982011-03-08 Juanma Barranquero <lekktu@gmail.com>
18799
18800 * w32xfns.c (select_palette): Check success of RealizePalette against
18801 GDI_ERROR, not zero.
18802
33383987 18803See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18804
18805;; Local Variables:
18806;; coding: utf-8
aac0c6e3
MR
18807;; End:
18808
2f097256 18809 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18810
18811 This file is part of GNU Emacs.
18812
18813 GNU Emacs is free software: you can redistribute it and/or modify
18814 it under the terms of the GNU General Public License as published by
18815 the Free Software Foundation, either version 3 of the License, or
18816 (at your option) any later version.
18817
18818 GNU Emacs is distributed in the hope that it will be useful,
18819 but WITHOUT ANY WARRANTY; without even the implied warranty of
18820 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18821 GNU General Public License for more details.
18822
18823 You should have received a copy of the GNU General Public License
18824 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.