* nsfont.m (ns_charset_covers): Don't abort if no bitmap.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
24ef80ae
PE
12012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2
3 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
4 Report and trivial fix by BT Templeton.
5
6de0e799
GM
62012-07-13 Glenn Morris <rgm@gnu.org>
7
739ae010
GM
8 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
9
dbee5793
GM
10 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
11
6de0e799
GM
12 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
13 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
14
b82da769
GM
152012-07-12 Glenn Morris <rgm@gnu.org>
16
4fae5a7a 17 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
18
19 * process.c (init_process_emacs): Rename from init_process.
20 The old name is also the name of a Mach system call.
21 * lisp.h, emacs.c: Update for this name change.
22 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
23 longer needed.
24
5a979817
EZ
252012-07-12 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
28 memmove call that removes glyphs covered by the left truncation
29 glyph. Improve commentary.
30 (display_line): Fix display of continuation glyphs on GUI frames
31 when the right fringe is turned off and variable-size fonts are
32 used in the window. Move the code that appends a stretch glyph to
33 produce_special_glyphs, so that it could be used for truncation
34 and continuation glyphs alike.
35 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
36 glyph of a suitably computed width, to align the special glyphs at
37 the window margin. Code moved from display_line. (Bug#11832)
38
3e91a053
GM
392012-07-12 Glenn Morris <rgm@gnu.org>
40
ba9e4b84
GM
41 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
42
43 * s/gnu-linux.h, s/hpux10-20.h:
44 Do not unconditionally define HAVE_XRMSETDATABASE.
45
3e91a053
GM
46 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
47
b300b1f4
PE
482012-07-12 Paul Eggert <eggert@cs.ucla.edu>
49
50 Fix typos that broke OS X build.
51 Reported by Randal L. Schwartz in
52 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
53 * nsterm.m (ns_timeout): Add missing local decl.
54 (ns_get_color): snprintf -> sprintf, to fix typo.
55
6e777848
GM
562012-07-12 Glenn Morris <rgm@gnu.org>
57
3f922c37
GM
58 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
59 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
60 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
61 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
62
0ab7b23a
GM
63 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
64 Move PTY_OPEN to configure.
65
6e777848
GM
66 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
67 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
68 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
69
4a7edc24
DA
702012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
71
72 Use empty_unibyte_string where applicable.
73 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
74 * lread.c (read1): Likewise.
75 * xsettings.c (syms_of_xsettings): Likewise.
76
308aab79
GM
772012-07-12 Glenn Morris <rgm@gnu.org>
78
42bd1719
GM
79 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
80 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
81 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
82 * s/hpux10-20.h (RUN_TIME_REMAP):
83 * s/bsd-common.h (TABDLY): Move to configure.
84
85 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
86
87 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
88
ea0bbd17 89 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 90 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
91
92 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 93
308aab79
GM
94 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
95 * s/template.h: Move NARROWPROTO to configure.
96
ee1cf5cf
GM
972012-07-11 Glenn Morris <rgm@gnu.org>
98
30fe9bf4
GM
99 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
100 unused since 2011-01-17 change to systty.h.
101
ee1cf5cf
GM
102 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
103 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
104 Move HAVE_PTYS and HAVE_SOCKETS to configure.
105
63e47e07
PE
1062012-07-11 Paul Eggert <eggert@cs.ucla.edu>
107
108 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
109
c43fb4c3
GM
1102012-07-11 Glenn Morris <rgm@gnu.org>
111
112 * s/darwin.h, s/gnu-linux.h, s/template.h:
113 Move INTERRUPT_INPUT to configure.
114
e8df9267
DA
1152012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
116
117 Minor adjustments to interning code.
118 * lisp.h (intern, intern_c_string): Redefine as static inline
119 wrappers for intern_1 and intern_c_string_1, respectively.
120 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
121 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
122 Vobarray checking.
e8df9267
DA
123 * font.c (font_intern_prop): Likewise. Adjust comment.
124 * w32font.c (intern_font_name): Likewise.
125
34348bd4
AS
1262012-07-11 Andreas Schwab <schwab@linux-m68k.org>
127
d96a1e0c
AS
128 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
129
34348bd4
AS
130 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
131 of Fcar/Fcdr if possible.
132 * font.c (check_otf_features): Likewise.
133 * fontset.c (Fnew_fontset): Likewise.
134 * gnutls.c (Fgnutls_boot): Likewise.
135 * minibuf.c (read_minibuf): Likewise.
136 * msdos.c (IT_set_frame_parameters): Likewise.
137 * xmenu.c (Fx_popup_dialog): Likewise.
138 * w32menu.c (Fx_popup_dialog): Likewise.
139
c8add24e
GM
1402012-07-11 Glenn Morris <rgm@gnu.org>
141
4b575b3c
GM
142 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
143 since nothing has defined it on these platforms.
144
09f4e3b0
GM
145 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
146 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
147
172bedef
GM
148 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
149 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
150 Move CLASH_DETECTION to configure.
151
249685df
GM
152 * s/gnu.h: Remove file, which is now empty.
153
c8add24e
GM
154 * s/gnu.h, s/gnu-linux.h:
155 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
156
b41253a3
JW
1572012-07-11 John Wiegley <johnw@newartisans.com>
158
159 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
160 function attribute, so we only use it if it exists in the
161 compiler.
162
d923b542
DA
1632012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Avoid call to strlen in fast_c_string_match_ignore_case.
166 * search.c (fast_c_string_match_ignore_case): Change to use
167 length argument. Adjust users accordingly.
168 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
169
5ebbef1d
PE
1702012-07-11 Paul Eggert <eggert@cs.ucla.edu>
171
bb352260
PE
172 Assume mkdir, rmdir.
173 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
174 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
175
57054ddd
PE
176 Assume rename.
177 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
178
b747d3f7
PE
179 Assume perror.
180 * s/hpux10-20.h (HAVE_PERROR): Remove.
181 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
182 Remove dummy definition, as this problem was obsolete long ago.
183
5ebbef1d
PE
184 Assume strerror.
185 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
186
984e7f30
DA
1872012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Avoid calls to strlen in font processing functions.
190 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 191 (font_open_by_name): Change to use length argument. Adjust
984e7f30 192 users accordingly.
d923b542
DA
193 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
194 Adjust prototypes.
195 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
196 Change to return ptrdiff_t.
984e7f30
DA
197 (xfont_list_pattern, xfont_match): Use length returned by
198 xfont_decode_coding_xlfd.
199 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
200
20e94fdd
GM
2012012-07-11 Glenn Morris <rgm@gnu.org>
202
9d596af3
GM
203 * s/darwin.h, s/freebsd.h, s/netbsd.h:
204 Move DONT_REOPEN_PTY to configure.
205
20e94fdd
GM
206 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
207 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
208
e99a530f
PE
2092012-07-10 Paul Eggert <eggert@cs.ucla.edu>
210
22ffb973
PE
211 Remove "#define unix" that is no longer needed (Bug#11905).
212 * s/aix4-2.h (unix): Remove; no longer needed.
213
e9a9ae03
PE
214 EMACS_TIME simplification (Bug#11875).
215 This replaces macros (which typically do not work in GDB)
216 with functions, typedefs and enums, making the code easier to debug.
217 The functional style also makes code easier to read and maintain.
218 * systime.h: Include <sys/time.h> on all hosts, not just if
219 WINDOWSNT, since 'struct timeval' is needed in general.
220 (EMACS_TIME): Now a typedef, not a macro.
221 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
222 not macros.
223 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
224 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
225 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
226 (EMACS_TIME_LE): Now functions, not macros.
227 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
228 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
229 which are not functions. All uses rewritten to use:
230 (make_emacs_time): New function.
231 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
232 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
233 not functions. All uses rewritten to use the following, respectively:
234 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
235 (add_emacs_time, sub_emacs_time): New functions.
236 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
237 * fileio.c (Fcopy_file):
238 * xterm.c (XTflash): Get the current time closer to when it's used.
239 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
240
ffacb126
PE
241 * bytecode.c (targets): Suppress -Woverride-init warnings.
242
e99a530f
PE
243 Simplify by avoiding confusing use of strncpy etc.
244 * doc.c (Fsnarf_documentation):
245 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
246 * frame.c (Fmake_terminal_frame):
247 * gtkutil.c (get_utf8_string):
248 * lread.c (openp):
249 * nsmenu.m (ns_update_menubar):
250 * regex.c (regerror):
251 Prefer memcpy to strncpy and strncat when either will do.
252 * fileio.c (Fsubstitute_in_file_name):
253 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
254 (menu_separator_name_p):
255 * nsmenu.m (ns_update_menubar):
256 Prefer memcmp to strncmp when either will do.
257 * nsterm.m: Include <ftoastr.h>.
258 (ns_get_color):
259 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
260 Prefer snprintf to strncpy.
261 * nsterm.m (ns_term_init):
262 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
263 * nsterm.m (ns_term_init):
264 Avoid the need for strncpy, by using build_string or
265 make_unibyte_string directly. Use dtoastr, not snprintf.
266 * process.c (Fmake_network_process): Diagnose service names that
267 are too long, rather than silently truncating them or creating
268 non-null-terminated names.
269 (Fnetwork_interface_info): Likewise, for interface names.
270 * sysdep.c (system_process_attributes) [GNU_LINUX]:
271 Prefer sprintf to strncat.
272 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
273 Prefer vsnprintf to vsprintf + strncpy.
274
c59592b3
GM
2752012-07-10 Glenn Morris <rgm@gnu.org>
276
277 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
278 Clarify fallback case.
279
7d7bbefd
DA
2802012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
283 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
284 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 285 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
286 where argument type is known to be a Lisp_Cons.
287
3a4c8000
TT
2882012-07-10 Tom Tromey <tromey@redhat.com>
289
290 * bytecode.c (BYTE_CODE_THREADED): New macro.
291 (BYTE_CODES): New macro. Replaces all old byte-code defines.
292 (enum byte_code_op): New type.
293 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
294 (exec_byte_code): Use them. Use token threading when applicable.
295
2a0213a6
DA
2962012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
297
298 Optimize pure C strings initialization.
299 * lisp.h (make_pure_string): Fix prototype.
300 (build_pure_c_string): New function, defined as static inline. This
301 provides a better opportunity to optimize away calls to strlen when
302 the function is called with compile-time constant argument.
303 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
304 argument, adjust users accordingly. Use build_pure_c_string where
305 appropriate.
306 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
307 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
308 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
309
cb1caeaf
DA
3102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
311
312 Avoid calls to strlen in miscellaneous functions.
313 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
314 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
315 * lread.c (openp): Likewise.
316
c293e30c
DA
3172012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
318
319 Avoid calls to strlen in path processing functions.
320 * fileio.c (file_name_as_directory): Add comment. Change to add
321 srclen argument and return the length of result. Adjust users
322 accordingly.
323 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 324 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
325 users accordingly.
326 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
327
9e059e3f
GM
3282012-07-10 Glenn Morris <rgm@gnu.org>
329
d02eb359
GM
330 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
331 Move PENDING_OUTPUT_COUNT definition to configure.
332
882cf227
GM
333 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
334 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
335 * s/gnu.h (DATA_START): Move definitions to configure.
336
af6e839f
GM
337 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
338 We include usg5-4-common.h, which defines them both.
339
40289a12
GM
340 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
341 O_RDONLY already includes it).
342
9e059e3f
GM
343 Stop ns builds setting the EMACSLOADPATH environment variable.
344 * nsterm.m (ns_load_path): Rename from ns_init_paths.
345 Now it does not set EMACSLOADPATH, just returns the load-path string.
346 * nsterm.h: Update accordingly.
347 * lread.c [HAVE_NS]: Include nsterm.h.
348 (init_lread) [HAVE_NS]: Use ns_load_path.
349 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
350
7c4e8ec0
GM
3512012-07-09 Glenn Morris <rgm@gnu.org>
352
d4f600ff
GM
353 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
354 since the included bsd-common.h does so.
355
cbb31951
GM
356 Stop ns builds setting the EMACSPATH environment variable.
357 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
358 (ns_init_paths): Do not set EMACSPATH.
359 * nsterm.h (ns_exec_path): Add it.
360 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
361 Use ns_exec_path.
362
7c4e8ec0
GM
363 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
364
26bccfae
PE
3652012-07-09 Paul Eggert <eggert@cs.ucla.edu>
366
a0bee46f
PE
367 * process.c (wait_reading_process_output): 'waitchannels' was unset
368 when read_kbd || !NILP (wait_for_cell); fix this.
369
5994c183
PE
370 Add GCC-style 'const' attribute to functions that can use it.
371 * character.h (char_resolve_modifier_mask):
372 * keyboard.h (make_ctrl_char):
373 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
374 (init_character_once, next_almost_prime, init_fns, init_image)
375 (flush_pending_output, init_sound):
376 * mem-limits.h (start_of_data):
377 * menu.h (finish_menu_items):
378 Add ATTRIBUTE_CONST.
379 * emacs.c (DEFINE_DUMMY_FUNCTION):
380 Declare the dummy function with ATTRIBUTE_CONST.
381 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
382 Add decls with ATTRIBUTE_CONST.
383
26bccfae
PE
384 Minor improvements to make_formatted_string.
385 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
386 where int is good enough, as vsprintf returns an int.
387 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
388
a8290ec3
DA
3892012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
390
391 Use make_formatted_string to avoid double length calculation.
392 * lisp.h (make_formatted_string): New prototype.
393 * alloc.c (make_formatted_string): New function.
394 * buffer.c (Fgenerate_new_buffer_name): Use it.
395 * dbus.c (syms_of_dbusbind): Likewise.
396 * editfns.c (Fcurrent_time_zone): Likewise.
397 * filelock.c (get_boot_time): Likewise.
398 * frame.c (make_terminal_frame, set_term_frame_name)
399 (x_report_frame_params): Likewise.
400 * image.c (gs_load): Likewise.
401 * minibuf.c (get_minibuffer): Likewise.
402 * msdos.c (dos_set_window_size): Likewise.
403 * process.c (make_process): Likewise.
404 * xdisp.c (ensure_echo_area_buffers): Likewise.
405 * xsettings.c (apply_xft_settings): Likewise.
406
d01ba2f1
GM
4072012-07-09 Glenn Morris <rgm@gnu.org>
408
409 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
410 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
411 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
412 * nsterm.h (ns_etc_directory): Add it.
413 * callproc.c [HAVE_NS]: Include nsterm.h.
414 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
415
f1f924b6
DA
4162012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Move marker debugging code under MARKER_DEBUG.
419 * marker.c (MARKER_DEBUG): Move marker debugging code under
420 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
421 for bootstrap with --enable-checking (~3x slowdown reported
422 by Juanma Barranquero <lekktu@gmail.com>).
423 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
424
ab531b66
PE
4252012-07-08 Paul Eggert <eggert@cs.ucla.edu>
426
427 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
428 See <http://bugs.gnu.org/11825#29>.
429
c4b3bc8a
EZ
4302012-07-08 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
433 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
434 (display_line): Add commentary about displaying truncation glyphs
435 on GUI frames.
436 (produce_special_glyphs): Move here from term.c.
437
438 * term.c (produce_special_glyphs): Move to xdisp.c.
439
440 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
441 section.
c4b3bc8a 442
b676b881
AS
4432012-07-07 Andreas Schwab <schwab@linux-m68k.org>
444
f17c5273
AS
445 * xdisp.c (display_line): Avoid warning about implicit declaration
446 of FRAME_FONT.
447
298819b9
AS
448 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
449
b676b881
AS
450 * lisp.h: Remove empty conditional.
451
6045c4fd
PE
4522012-07-07 Paul Eggert <eggert@cs.ucla.edu>
453
b3350bf9
PE
454 * lread.c (load_path_check): Now static.
455
6045c4fd
PE
456 Fix some minor --with-ns problems found by static checking.
457 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
458 (x_set_font) [!HAVE_X_WINDOWS]:
459 * image.c (xpm_load_image) [HAVE_NS]:
460 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
461 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
462 Remove unused local.
463 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
464 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
465 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
466 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
467 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
468 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
469 Fix pointer signedness problem.
470 * xfaces.c (FRAME_X_FONT_TABLE):
471 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
472
929e7845
GM
4732012-07-07 Glenn Morris <rgm@gnu.org>
474
475 * lread.c (load_path_check): New function, split from init_lread.
476 (init_lread): Reorganize. Motivation:
477 If EMACSLOADPATH is set, check/warn about that rather than the
478 defaults, which we are not going to use. Hence we can remove
479 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
480 Don't warn if site-lisp directories are missing.
481 If not installed, start from a blank load-path, since
482 PATH_LOADSEARCH refers to the eventual installation directories.
483
58dd0aa4
EZ
4842012-07-07 Eli Zaretskii <eliz@gnu.org>
485
486 Support truncation and continuation glyphs on GUI frames, when
487 fringes are disabled. (Bug#11832)
488 * xdisp.c (init_iterator): Get dimensions of truncation and
489 continuation glyphs even if on GUI frames. Adjust
490 it->last_visible_x on GUI frames when the left or right fringes,
491 or both, are absent.
492 (start_display, move_it_in_display_line_to): Handle the case of a
493 GUI frame without a fringe to display continuation or truncation
494 glyphs.
495 (insert_left_trunc_glyphs): Support GUI frames: make sure
496 truncation glyphs overwrite enough glyphs from the current line to
497 have sufficient space in pixels.
498 (display_line): Support truncation and continuation glyphs on GUI
499 frames. If some spare pixels are left on the line after inserting
500 the truncation glyphs, fill that space with a stretch glyph of a
501 suitably computed width.
502
503 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
504 produce_glyphs, to support GUI sessions.
505
31571fd7
PE
5062012-07-07 Paul Eggert <eggert@cs.ucla.edu>
507
5a16b9bc
PE
508 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
509
f3047c75
PE
510 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
511
31571fd7
PE
512 Do not require float-time's arg to fit in time_t (Bug#11825).
513 This works better on hosts where time_t is unsigned, and where
514 float-time is applied to the (negative) difference between two times.
515 * editfns.c (decode_time_components): Last arg is now double *,
516 not int *, and means to store all the result as a double, without
517 worrying about whether the seconds part fits in time_t.
518 All callers changed.
519 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
520 All callers changed.
521 (Ffloat_time): Do not fail merely because the specified time falls
522 outside of time_t range.
523
4516fbef
GM
5242012-07-07 Glenn Morris <rgm@gnu.org>
525
526 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
527 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
528 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
529
07adc2c6
JB
5302012-07-07 Juanma Barranquero <lekktu@gmail.com>
531
532 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
533 Update dependencies.
534
535 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
536
fd573f31
PE
5372012-07-06 Paul Eggert <eggert@cs.ucla.edu>
538
fee5959d
PE
539 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
540 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
541 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
542 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
543 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
544 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
545
fd573f31
PE
546 * xfont.c (compare_font_names): Redo to omit the need for casts.
547
ddadbc0e
AS
5482012-07-06 Andreas Schwab <schwab@linux-m68k.org>
549
fca8d6b6
AS
550 * xfns.c (Fx_change_window_property): Doc fix.
551 * w32fns.c (Fx_change_window_property): Doc fix.
552
ddadbc0e
AS
553 * w32fns.c (Fx_window_property): Accept the same arguments as the
554 X Windows version. Doc fix.
555 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
556
f247498e
JB
5572012-07-06 Juanma Barranquero <lekktu@gmail.com>
558 Eli Zaretskii <eliz@gnu.org>
559
560 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
561 Windows-specific code from nt/config.nt moved here.
562 Obsolete settings removed.
563
216ee680
PE
5642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
565
566 * process.c: Avoid unnecessary calls to gettime.
567 (wait_reading_process_output): Don't get the time of day
568 when gobbling data immediately and not waiting, as there's no need
569 for it in that case. This removes a FIXME.
570
bdd091e4
JD
5712012-07-06 Jan Djärv <jan.h.d@swipnet.se>
572
573 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
574 is defined (Bug#11768).
575
9d44f8ce
DA
5762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
577
578 Fix marker debugging code.
579 * marker.c (byte_char_debug_check): Do not perform the check
580 if buffer is not multibyte.
090bd7cb
JB
581 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
582 Call byte_char_debug_check with correct arguments.
9d44f8ce 583
90fc4786
DA
5842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
587 * marker.c (byte_char_debug_check, count_markers):
588 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
589 (byte_debug_flag): Remove.
590 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
591 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
592
7b7ae965
DA
5932012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
594
4e57b342
DA
595 Avoid code repetition in marker-related functions.
596 * marker.c (attach_marker): New function.
597 (Fset_marker, set_marker_restricted, set_marker_both)
598 (set_marker_restricted_both): Use it.
599 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
600 Consistently rename charno to charpos.
601 (marker_position): Add eassert.
602 (marker_byte_position): Convert to eassert.
603
6042012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
605
606 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 607 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 608 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 609
657924ff
DA
6102012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
611
612 Introduce fast path for the widely used marker operation.
613 * alloc.c (build_marker): New function.
614 * lisp.h (build_marker): New prototype.
615 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
616 * composite.c (autocmp_chars): Likewise.
617 * editfns.c (buildmark): Remove.
618 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
619 (save_restriction_save): Use build_marker.
620 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
621 * window.c (save_window_save): Likewise.
622
041a49a6
DA
6232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
624
625 Do not use Fdelete_overlay in delete_all_overlays
626 to avoid redundant calls to unchain_overlay.
627 * buffer.c (drop_overlay): New function.
628 (delete_all_overlays, Fdelete_overlay): Use it.
629 * minibuf.c (get_minibuffer): Fix comment.
630
7dca65a4
PE
6312012-07-06 Paul Eggert <eggert@cs.ucla.edu>
632
633 Port to OpenBSD 5.1 amd64.
634 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
635 This is needed for OpenBSD, and should be harmless on all BSD systems.
636 Also, include <sys/sysctl.h>, as it should be available on all
637 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
638 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
639 use p_pid member, not kp_proc.pid.
640
8eb876e2
GM
6412012-07-06 Glenn Morris <rgm@gnu.org>
642
643 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
644
38182d90
PE
6452012-07-05 Paul Eggert <eggert@cs.ucla.edu>
646
647 More xmalloc and related cleanup.
648 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
649 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
650 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
651 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
652 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
653 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
654 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
655 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
656 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
657 * xterm.c:
658 Omit needless casts involving void * pointers and allocation.
659 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
660 as the former is more robust if P's type is changed.
661 Prefer xzalloc to xmalloc + memset 0.
662 Simplify malloc-or-realloc to realloc.
663 Don't worry about xmalloc returning a null pointer.
664 Prefer xstrdup to xmalloc + strcpy.
665 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
666 growing it.
667 * keyboard.c (apply_modifiers_uncached): Prefer local array to
668 alloca of a constant.
669
6dd5a677
EZ
6702012-07-05 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (display_line): Fix horizontal pixel coordinates when
673 hscroll is larger than the line width. Fixes long and futile
674 looping inside extend_face_to_end_of_line (on a TTY) producing
675 glyphs that are not needed and thrown away.
676
6b312f0f
DA
6772012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
678
679 * marker.c (set_marker_restricted_both): Simplify by using
680 clip_to_bounds.
681
f520ef9b
PE
6822012-07-05 Paul Eggert <eggert@cs.ucla.edu>
683
684 * editfns.c (region_limit): Simplify by using clip_to_bounds.
685
383b7c95
JD
6862012-07-05 Jan Djärv <jan.h.d@swipnet.se>
687
688 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
689 not defined (Bug#11768).
690 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
691 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
692 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
693 followed by gtk_box_set_homogeneous (Bug#11768).
694 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
695 (update_theme_scrollbar_width, xg_create_scroll_bar):
696 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
697 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
698 (is_box_type): New function (Bug#11768).
699 (xg_tool_item_stale_p): Call is_box_type.
5293d758 700 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
701 with default display (Bug#11768).
702
d6e7bf45
EZ
7032012-07-05 Eli Zaretskii <eliz@gnu.org>
704
705 * xdisp.c (window_hscroll_limited): New function.
706 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
707 coordinates when window's hscroll is set to insanely large
708 values. (Bug#11857)
709
431391ec
JB
7102012-07-05 Juanma Barranquero <lekktu@gmail.com>
711
712 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
713 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
714
23f86fce
DA
7152012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
716
717 Cleanup xmalloc.
718 * lisp.h (xzalloc): New prototype. Omit needless casts.
719 * alloc.c (xzalloc): New function. Omit needless casts.
720 * charset.c: Omit needless casts. Convert all calls to
721 xmalloc with following memset to xzalloc.
722 * dispnew.c: Likewise.
723 * fringe.c: Likewise.
724 * image.c: Likewise.
725 * sound.c: Likewise.
726 * term.c: Likewise.
727 * w32fns.c: Likewise.
728 * w32font.c: Likewise.
729 * w32term.c: Likewise.
730 * xfaces.c: Likewise.
731 * xfns.c: Likewise.
732 * xterm.c: Likewise.
733 * atimer.c: Omit needless casts.
734 * buffer.c: Likewise.
735 * callproc.c: Likewise.
736 * ccl.c: Likewise.
737 * coding.c: Likewise.
738 * composite.c: Likewise.
739 * doc.c: Likewise.
740 * doprnt.c: Likewise.
741 * editfns.c: Likewise.
742 * emacs.c: Likewise.
743 * eval.c: Likewise.
744 * filelock.c: Likewise.
745 * fns.c: Likewise.
746 * gtkutil.c: Likewise.
747 * keyboard.c: Likewise.
748 * lisp.h: Likewise.
749 * lread.c: Likewise.
750 * minibuf.c: Likewise.
751 * msdos.c: Likewise.
752 * print.c: Likewise.
753 * process.c: Likewise.
754 * region-cache.c: Likewise.
755 * search.c: Likewise.
756 * sysdep.c: Likewise.
757 * termcap.c: Likewise.
758 * terminal.c: Likewise.
759 * tparam.c: Likewise.
760 * w16select.c: Likewise.
761 * w32.c: Likewise.
762 * w32reg.c: Likewise.
763 * w32select.c: Likewise.
764 * w32uniscribe.c: Likewise.
765 * widget.c: Likewise.
766 * xdisp.c: Likewise.
767 * xmenu.c: Likewise.
768 * xrdb.c: Likewise.
769 * xselect.c: Likewise.
770
0497dc44
PE
7712012-07-05 Paul Eggert <eggert@cs.ucla.edu>
772
773 * fileio.c (time_error_value): Check the right error number.
774 Problem reported by Troels Nielsen in
775 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
776
356e7178
PE
7772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
778
4e71fd89
PE
779 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
780 This should be fixed in a better way; see Eli Zaretskii in
781 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
782 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
783
f0941253
PE
784 * fileio.c (time_error_value): Rename from special_mtime.
785 The old name's problems were noted by Eli Zaretskii in
786 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
787
065c9eb4
PE
788 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
789 This variable's comment says Emacs needs at least one GDB-visible
790 symbol of type enum pvec_type, to work around GDB problems.
791 The symbol's value doesn't matter.
792
356e7178
PE
793 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
794 that causes compilation to fail on pre-C99 compilers.
795
95f61aa2
JB
7962012-07-04 Juanma Barranquero <lekktu@gmail.com>
797
798 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
799 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
800
3884d954
DA
8012012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
802
d209e2fb 803 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
804 headers for buffer_defaults and buffer_local_symbols.
805 Reported by Juanma Barranquero <lekktu@gmail.com>.
806
ee28be33
SM
8072012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
808
809 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
810 * lisp.h (enum pvec_type): Use fewer bits.
811 (PSEUDOVECTOR_SIZE_BITS): New constant.
812 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
813 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
814 change in pvec_type.
815 (PSEUDOVECTOR_TYPEP): New macro.
816 (TYPED_PSEUDOVECTORP): Use it.
817 * fns.c (internal_equal): Adapt code to extract pvectype.
818 * emacs.c (gdb_pvec_type): Update type.
819 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
820 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
821 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
822 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
823 (sweep_vectors): Use it. Use local var `total_bytes' instead of
824 abusing vector->header.next.nbytes.
825 (live_vector_p): Use PVEC_TYPE.
826 (mark_object): Adapt code to extract pvectype. Use switch.
827
c7f2cd7f
PE
8282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
829
830 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
831 Tighten new eassert a bit.
832
8ce70ed2
DA
8332012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
834
835 Fix compilation with --enable-gcc-warnings and -O1
836 optimization level.
837 * doprnt.c (doprnt): Change type of tem to int, initialize
838 to avoid compiler warning. Add eassert.
839 * search.c (simple_search): Initialize match_byte to avoid
840 compiler warning. Add eassert.
841
dea7f1e5
PE
8422012-07-04 Paul Eggert <eggert@cs.ucla.edu>
843
24a212eb
PE
844 Avoid weird behavior with large horizontal scrolls.
845 Without this change, for example, large hscroll values would
846 mess up Emacs's display on Fedora 15 x86, presumably due to
847 overflows in int calculations in the display code.
848 Also, if buffers had long lines, Emacs would freeze.
849 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
850 (set_window_hscroll): New function, containing the old guts of
851 Fset_window_hscroll. Return the clipped value.
852 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
853 This avoids the need to check against PTRDIFF_MAX.
854
dea7f1e5
PE
855 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
856
76046526
DA
8572012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
858
859 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
860
39adff0d
PE
8612012-07-04 Paul Eggert <eggert@cs.ucla.edu>
862
63807d47
PE
863 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
864 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
865 since GCC 4.4.6 issues a bogus warning for them.
866
39adff0d
PE
867 Fix bugs in file timestamp newness comparisons.
868 * fileio.c (Ffile_newer_than_file_p):
869 * lread.c (Fload): Use full timestamp resolution of files,
870 not just the 1-second resolution, so that files that are only
871 slightly newer still count as newer.
872 * fileio.c (Ffile_newer_than_file_p): Don't assume file
873 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
874
dbeed9a6
PE
8752012-07-03 Paul Eggert <eggert@cs.ucla.edu>
876
877 * fileio.c: Improve handling of file time marker. (Bug#11852)
878 (special_mtime): New function.
879 (Finsert_file_contents, Fverify_visited_file_modtime):
880 Use it to set special mtime values consistently.
881
636334d6
AS
8822012-07-03 Andreas Schwab <schwab@linux-m68k.org>
883
884 * fileio.c (Finsert_file_contents): Properly handle st_mtime
885 marker for non-existing file. (Bug#11852)
886
e2017fe2
GM
8872012-07-03 Glenn Morris <rgm@gnu.org>
888
889 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
890 and did not make it into globals.h).
891
404dbd37
TT
8922012-07-03 Tom Tromey <tromey@redhat.com>
893
894 * window.c (Fset_window_margins, Fset_window_fringes)
895 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
896 * textprop.c (Fprevious_property_change): No longer static.
897 * syntax.c (Fsyntax_table_p): No longer static.
898 * process.c (Fget_process, Fprocess_datagram_address): No longer
899 static.
900 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
901 * keyboard.c (Fcommand_execute): No longer static.
902 Remove EXFUN.
903 * insdel.c (Fcombine_after_change_execute): No longer static.
904 * image.c (Finit_image_library): No longer static.
905 * fileio.c (Fmake_symbolic_link): No longer static.
906 * eval.c (Ffetch_bytecode): No longer static.
907 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
908 * doc.c (Fdocumentation_property, Fsnarf_documentation):
909 No longer static.
404dbd37
TT
910 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
911 static.
912 * dired.c (Ffile_attributes): No longer static.
913 * composite.c (Fcomposition_get_gstring): No longer static.
914 * callproc.c (Fgetenv_internal): No longer static.
915
916 * ccl.h: Remove EXFUNs.
917 * buffer.h: Remove EXFUNs.
918 * dispextern.h: Remove EXFUNs.
919 * intervals.h: Remove EXFUNs.
920 * fontset.h: Remove EXFUN.
921 * font.h: Remove EXFUNs.
922 * dosfns.c (system_process_attributes): Remove EXFUN.
923 * keymap.h: Remove EXFUNs.
924 * lisp.h: Remove EXFUNs.
925 * w32term.h: Remove EXFUNs.
926 * window.h: Remove EXFUNs.
927 * xsettings.h: Remove EXFUN.
928 * xterm.h: Remove EXFUN.
929
8e4fd1e1
GM
9302012-07-03 Glenn Morris <rgm@gnu.org>
931
932 * lisp.h (Frandom): Make it visible to C.
933 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
934 buffer for invisible buffers. (Bug#1229)
935
ca95b3eb
DA
9362012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
937
938 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
939 values which aren't power of 2.
940 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
941 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
942 accordingly.
943
7555c33f
SM
9442012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
945
946 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
947
948 * alloc.c (mark_object): Revert part of last patch to use `switch'.
949
d12e8f5a
DA
9502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
951
952 * alloc.c (allocate_vector_block): Remove redundant
953 calls to mallopt if DOUG_LEA_MALLOC is defined.
954 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
955 avoid calls to mallopt if zero_vector is returned.
956
296094c3
DA
9572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
958
959 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
960 is enabled, avoid dereferencing NULL current_sblock if
961 running undumped.
962
36429c89
DA
9632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
964
965 Cleanup basic buffer management.
966 * buffer.h (struct buffer): Change layout to use generic vector
967 marking code. Fix some comments. Change type of 'clip_changed'
968 to bitfield. Remove unused #ifndef old.
969 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
970 (GET_OVERLAYS_AT): Fix indentation.
971 (for_each_per_buffer_object_at): New macro.
972 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
973 (Fbuffer_local_variables): Use it.
974 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
975 * alloc.c (allocate_buffer): Adjust to match new layout of
976 struct buffer. Fix comment.
977 (mark_overlay): New function.
978 (mark_buffer): Use it. Use mark_vectorlike to mark normal
979 Lisp area of struct buffer.
980 (mark_object): Use it. Adjust marking of misc objects
981 and related comments.
982
3b3e4cac
PE
9832012-07-02 Paul Eggert <eggert@cs.ucla.edu>
984
985 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
986 wrapper that is not needed because the wrapped code is a no-op (zero
987 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
988 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
989
cf5c0175
DA
9902012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
991
992 * alloc.c (mark_buffer): Simplify. Remove prototype.
993 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 994 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
995 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
996 redundant calls to mark_vectorlike for bool vectors.
997
ca26824c
GM
9982012-06-30 Glenn Morris <rgm@gnu.org>
999
2e4c5312
GM
1000 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1001
ca26824c
GM
1002 * epaths.in (PATH_SITELOADSEARCH): New.
1003 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1004 This is rather than relying on --enable-locallisppath elements
1005 having "site-lisp" in their names. (Bug#10208#25, 11658)
1006
0d23c240
EZ
10072012-06-30 Eli Zaretskii <eliz@gnu.org>
1008
c9240d7a
EZ
1009 * w32proc.c (sys_select): Accept and ignore one more argument.
1010
1011 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1012
0d23c240 1013 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1014 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1015
1016 * sysdep.c: Don't include dos.h and dosfns.h.
1017
1018 * process.c (sys_select):
1019 * msdos.c (sys_select): Accept one more argument and ignore it.
1020
1021 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1022 adapt data types and code to that.
1023
1024 * dosfns.c:
1025 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1026 which clashes with the gnulib function of the same name.
1027
af5a5a98
AS
10282012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1029
c5e4379c
AS
1030 * font.c (font_style_to_value, font_style_symbolic)
1031 (font_prop_validate_style): Add type checks for values in
1032 font_style_table.
1033
af5a5a98
AS
1034 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1035 argument.
1036 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1037 uses.
1038
8d38f461
EZ
10392012-06-29 Eli Zaretskii <eliz@gnu.org>
1040
2e5a6631
EZ
1041 * xdisp.c (try_window_id): Undo last change.
1042
8d38f461
EZ
1043 * w32.c (getwd): Adjust commentary about startup_dir.
1044 (init_environment): Always call sys_access, even in non-MSVC
1045 builds. Don't chdir to the directory of the Emacs executable.
1046 This undoes code from 1997 which was justified by the need to
1047 "avoid conflicts when removing and renaming directories". But its
1048 downside was that every relative file name was being interpreted
1049 relative to the directory of the Emacs executable, which can never
1050 be TRT. In particular, it broke sys_access when called with
1051 relative file names.
1052 (sys_access): Map GetLastError to errno.
1053
2af3565e
DA
10542012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1055
1056 * window.h (struct window): Change type of 'fringes_outside_margins'
1057 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1058 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1059 Adjust comment.
1060 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1061 to ptrdiff_t.
1062
c8d3a25c 10632012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1064
c8d3a25c
GM
1065 * gnutls.c (emacs_gnutls_handshake):
1066 Add QUIT to make the loop interruptible.
57570cd3 1067
c8d3a25c 10682012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1069
c8d3a25c
GM
1070 * charset.c (init_charset): Make lack of etc/charsets fatal.
1071
3e984ee8
DA
10722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1073
1074 * editfns.c (region_limit): Fix type mismatch.
1075
ef884f23
DA
10762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1077
1078 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1079 undefined. Convert from xassert to eassert.
1080 * nsmenu.m: Convert from xassert to eassert.
1081 * nsterm.m: Likewise.
1082
7d7e0027
SM
10832012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1084
1085 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1086
aa754e6a
PE
10872012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 Avoid integer overflow on scroll-left and scroll-right.
1090 * window.c (HSCROLL_MAX): New macro.
1091 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1092 overflow when requested scroll falls outside ptrdiff_t range.
1093
80b00b08
DA
10942012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1095
1096 * window.h (struct window): Change type of 'hscroll',
1097 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1098 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1099 Adjust users accordingly.
1100 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1101 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1102 from EMACS_INT to ptrdiff_t.
1103 (make_window): Omit redundant initialization.
1104
62b2bcf6
JB
11052012-06-28 Juanma Barranquero <lekktu@gmail.com>
1106
1107 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1108
45942c7d
DA
11092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 * window.h (struct window): Change type of 'use_time' and
1112 'sequence_number' from Lisp_Object to int.
1113 * frame.c (make_frame): Adjust users accordingly.
1114 * print.c (print_object): Likewise.
1115 * window.c (select_window, Fwindow_use_time, make_parent_window)
1116 (make_window): Likewise.
1117
e509cfa6
DA
11182012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1119
1120 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1121 enabled with --enable-checking=[all,glyphs] configure option.
1122 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1123 adjust comments accordingly.
1124 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1125 undefined, adjust comments accordingly.
1126 * image.c: Likewise.
1127 * scroll.c: Likewise.
1128 * w32fns.c: Likewise.
1129 * w32term.c: Likewise.
1130 * xdisp.c: Likewise.
1131 * xfaces.c: Likewise.
1132 * xfns.c: Likewise.
1133 * xterm.c: Likewise.
1134
a54e2c05
DA
11352012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1136
1137 Generalize run-time debugging checks.
1138 * dispextern.h (XASSERTS): Remove.
1139 * fontset.c (xassert): Remove.
1140 Convert from xassert to eassert.
1141 * alloc.c: Convert from xassert to eassert.
1142 * bidi.c: Likewise.
1143 * dispnew.c: Likewise.
1144 * fns.c: Likewise.
1145 * fringe.c: Likewise.
1146 * ftfont.c: Likewise.
1147 * gtkutil.c: Likewise.
1148 * image.c: Likewise.
1149 * keyboard.c: Likewise.
1150 * menu.c: Likewise.
1151 * process.c: Likewise.
1152 * scroll.c: Likewise.
1153 * sound.c: Likewise.
1154 * term.c: Likewise.
1155 * w32console.c: Likewise.
1156 * w32fns.c: Likewise.
1157 * w32term.c: Likewise.
1158 * window.c: Likewise.
1159 * xdisp.c: Likewise.
1160 * xfaces.c: Likewise.
1161 * xfns.c: Likewise.
1162 * xselect.c: Likewise.
1163 * xterm.c: Likewise.
1164
1ec4b7b2
SM
11652012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1166
1167 * fns.c (maybe_resize_hash_table): Output message when growing the
1168 purify-hashtable.
1169
2014308a
DA
11702012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 * alloc.c (allocate_string_data): Remove dead code.
1173 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1174 avoid GCC warning about unused macro.
1175
246155eb
DA
11762012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1177
1178 * alloc.c (allocate_string): Omit intervals initialization.
1179 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1180 as in make_pure_string and make_pure_c_string.
1181
43184b7b
DA
11822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1183
d209e2fb 1184 * alloc.c (allocate_string): Fix last change.
43184b7b 1185
3fe6dd74
DA
11862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1187
d209e2fb 1188 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1189 to memset, add explicit initialization where appropriate.
1190
1ba6038a
GM
11912012-06-27 Glenn Morris <rgm@gnu.org>
1192
1193 * lisp.mk (lisp): Remove paths.elc.
1194
c89926a5
CY
11952012-06-27 Chong Yidong <cyd@gnu.org>
1196
1197 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1198
ed6b3510
JW
11992012-06-26 John Wiegley <johnw@newartisans.com>
1200
1ec4b7b2 1201 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1202 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1203
ed6b3510
JW
1204 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1205 when building with Clang.
1206
8edd4a2b
SM
12072012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1208
1209 * eval.c (Fapply): Allow calling it with a single argument.
1210
f6f62d1b
EZ
12112012-06-26 Eli Zaretskii <eliz@gnu.org>
1212
1213 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1214 _stricmp and _strnicmp.
1215 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1216
62efea5e
DA
12172012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1218
1219 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1220 allocated window.
1221 (allocate_process): Likewise for new process.
8edd4a2b 1222 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1223 (allocate_frame): Likewise.
1224 * frame.c (make_frame): Omit redundant initialization.
1225 * window.c (make_parent_window): Use memset.
1226 (make_window): Omit redundant initialization.
1227 * process.c (make_process): Omit redundant initialization.
1228 * terminal.c (create_terminal): Likewise.
1229
42997f4d
DA
12302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 * term.c (delete_tty): Remove redundant call to memset.
1233
1130ecfc
DA
12342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 * alloc.c: Remove build_string.
1237 * lisp.h: Define build_string as static inline. This provides
1238 a better opportunity to optimize away calls to strlen when the
1239 function is called with compile-time constant argument.
1240 * image.c (imagemagick_error): Convert to build_string.
1241 * w32proc.c (sys_spawnve): Likewise.
1242 * xterm.c (x_term_init): Likewise.
1243
cf38a720
PE
12442012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1245
99027bdd
PE
1246 Use sprintf return value instead of invoking strlen on result.
1247 In the old days this wasn't portable, since some sprintf
1248 implementations returned char *. But they died out years ago and
1249 Emacs already assumes sprintf returns int.
1250 Similarly for float_to_string.
1251 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1252 * ccl.c (ccl_driver):
1253 * character.c (string_escape_byte8):
1254 * data.c (Fnumber_to_string):
1255 * doprnt.c (doprnt):
1256 * print.c (print_object):
1257 * xdisp.c (message_dolog):
1258 * xfns.c (syms_of_xfns):
1259 Use sprintf or float_to_string result to avoid need to call strlen.
1260 * data.c (Fnumber_to_string):
1261 Use make_unibyte_string, since the string must be ASCII.
1262 * lisp.h, print.c (float_to_string): Now returns int length.
1263 * term.c (produce_glyphless_glyph):
1264 Use sprintf result rather than recomputing it.
1265
cf38a720
PE
1266 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1267 * Makefile.in (ALL_CFLAGS):
1268 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1269 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1270
3511c784
DA
12712012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1272
0a08eb21 1273 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1274 strcasecmp if available.
1275 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1276
fb7da12e
AS
12772012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1278
1279 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1280 Avoid comma operator.
1281 * menu.c (push_submenu_start, push_submenu_end)
1282 (push_left_right_boundary, push_menu_pane): Likewise.
1283 * msdos.c (dos_rawgetc): Likewise.
1284
afa2ffd8
DA
12852012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 * xfns.c (xic_create_fontsetname): Remove redundant calls
1288 to memset.
1289
b3b4476b
PE
12902012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1291
4495ff38
PE
1292 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1293 sprintf already null-terminates its output.
1294
b3b4476b
PE
1295 * xfns.c (x_window): Remove redundant cast.
1296
b00876c9
DA
12972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1300 `const char *' to `char *' to avoid compiler warning.
1301
d188e26b
PE
13022012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1303
885d1d74
PE
1304 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1305 instead of truncating it to 63 (admittedly a generous limit).
1306
d188e26b
PE
1307 * process.c: Fix spelling and caps in comments.
1308
e2f560b1
DN
13092012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1310
e86db54b 1311 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1312 * sysdep.c (setpgrp): Remove definition, not used in this file.
1313
7583a3a1
JB
13142012-06-24 Juanma Barranquero <lekktu@gmail.com>
1315
1316 * makefile.w32-in: Update dependencies.
1317
696056c2
EZ
13182012-06-24 Eli Zaretskii <eliz@gnu.org>
1319
1320 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1321 (SYSTIME_H): Add nt/inc/sys/time.h.
1322
1323 * systime.h [WINDOWSNT]: Include sys/time.h.
1324
1325 * s/ms-w32.h (struct timespec): Definition moved from
1326 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1327
845ca893
PE
13282012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1331 * buffer.h (buffer_slot_type_mismatch):
1332 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1333 * eval.c (unwind_to_catch):
1334 * image.c (my_png_error, my_error_exit):
1335 * keyboard.c (quit_throw_to_read_char, user_error)
1336 (Fexit_recursive_edit, Fabort_recursive_edit):
1337 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1338 (wrong_type_argument, buffer_overflow, __executable_start)
1339 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1340 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1341 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1342 (fatal):
1343 (child_setup) [!DOS_NT]:
1344 * lread.c (end_of_file_error, invalid_syntax):
1345 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1346 * puresize.h (pure_write_error):
1347 * search.c (matcher_overflow):
1348 * sound.c (sound_perror, alsa_sound_perror):
1349 * sysdep.c, syssignal.h (croak):
1350 * term.c (maybe_fatal, vfatal):
1351 * textprop.c (text_read_only):
1352 * undo.c (user_error):
1353 * unexmacosx.c (unexec_error):
1354 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1355 Use _Noreturn rather than NO_RETURN.
1356 No need for separate decl merely because of _Noreturn.
1357 * sound.c (sound_warning, parse_sound):
1358 Remove unnecessary forward decls.
1359
f1dd8073
PE
13602012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1363 * lisp.h (WAIT_READING_MAX): New macro.
1364 * dispnew.c (Fsleep_for, sit_for):
1365 * keyboard.c (kbd_buffer_get_event):
1366 * process.c (Faccept_process_output):
1367 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1368 This improves on the previous patch, which introduced a bug
1369 when time_t is unsigned and as wide as intmax_t.
1370 See <http://bugs.gnu.org/9000#51>.
1371
b82c1755
EZ
13722012-06-23 Eli Zaretskii <eliz@gnu.org>
1373
1374 * dispnew.c (sit_for, Fsleep_for):
1375 * keyboard.c (kbd_buffer_get_event):
1376 * process.c (Faccept_process_output): Avoid compiler warnings when
1377 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1378
ca300656
JB
13792012-06-23 Juanma Barranquero <lekktu@gmail.com>
1380
049ec95b
JB
1381 * makefile.w32-in: Update dependencies.
1382
ca300656
JB
1383 * w32.c (ltime): Add return type and declare static.
1384 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1385
db7b8d06
PE
13862012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1389 Privately reported by Herbert J. Skuhra.
1390 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1391 All uses changed.
1392 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1393 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1394
0bd8297f
EZ
13952012-06-23 Eli Zaretskii <eliz@gnu.org>
1396
96512555
EZ
1397 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1398 last argument of make_unibyte_string.
1399
0bd8297f
EZ
1400 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1401 language ID in the event parameters.
1402
1403 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1404 event.code, not the obscure "character set ID".
1405
63def6b6
CY
14062012-06-23 Chong Yidong <cyd@gnu.org>
1407
1408 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1409
e8a02204
EZ
14102012-06-23 Eli Zaretskii <eliz@gnu.org>
1411
388cdec0
EZ
1412 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1413 * w32.c (fdutimens): New function.
1414
1415 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1416
1417 * s/ms-w32.h (pselect): Redirect to sys_select.
1418
1419 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1420
e8a02204
EZ
1421 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1422 in the logic of incrementing and decrementing the value of
1423 use_relocatable_buffers.
1424
d054f3fb
PE
14252012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1428 Privately reported by Herbert J. Skuhra.
1429 [__FreeBSD__]: Remove "*/" typo after "#include".
1430 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1431 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1432 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1433 Don't assume EMACS_TIME and struct timeval are the same type.
1434
d35af63c
PE
14352012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Support higher-resolution time stamps (Bug#9000).
1438 The time stamps are only nanosecond-resolution at the C level,
1439 since that's the best that any real-world system supports now.
1440 But they are picosecond-resolution at the Lisp level, as that's
1441 easy, and leaves room for future OS improvements.
1442
1443 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1444 (LIBES): Use it.
1445
1446 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1447 Don't get current time unless it's needed.
1448
1449 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1450 now provides it if it's absent.
1451 (start_atimer): Port to higher-res time stamps.
1452 Check for time stamp overflow. Don't get current time more
1453 often than is needed.
1454
1455 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1456 Include systime.h, not time.h.
1457 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1458
1459 * dired.c: Include stat-time.h.
1460 (Ffile-attributes): File times now have higher resolution.
1461
1462 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1463 (struct image): Timestamp now has higher resolution.
1464
1465 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1466 has at least microseconds now. All uses removed.
1467 (update_frame, update_single_window, update_window, update_frame_1)
1468 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1469
1470 * editfns.c (time_overflow): Now extern.
1471 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1472 (float-time, Fformat_time_string, Fcurrent_time_string)
1473 (Fcurrent_time_zone): Accept and generate higher-resolution
1474 time stamps.
1475 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1476 (decode_time_components, lisp_seconds_argument): New functions.
1477 (make_time): Now static.
1478 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1479 Report an error if the time is invalid, rather than having the caller
1480 do that.
1481
1482 * fileio.c: Include <stat-time.h>
1483 (Fcopy_file): Copy higher-resolution time stamps.
1484 Prefer to set the time stamp via a file descriptor if that works.
1485 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1486 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1487 (Fvisited_file_modtime, Fset_visited_file_modtime):
1488 Support higher-resolution time stamps.
1489
1490 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1491
1492 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1493
1494 * image.c (prepare_image_for_display, clear_image_cache)
1495 (lookup_image): Port to higer-resolution time stamps.
1496
1497 * keyboard.c (start_polling, bind_polling_period):
1498 Check for time stamp overflow.
1499 (read_char, kbd_buffer_get_event, timer_start_idle)
1500 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1501 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1502 Port to higher-resolution time stamps. Do not assume time_t is signed.
1503 (decode_timer): New function. Timers are now vectors of length 9,
1504 not 8, to accommodate the picosecond component.
1505 (timer_check_2): Use it.
1506
1507 * nsterm.m (select_timeout, timeval_subtract): Remove.
1508 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1509 as they're a bit more accurate and handle overflow better.
1510 (ns_select): Change prototype to be compatible with pselect.
1511 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1512 * nsterm.h (ns_select): Adjust prototype.
1513
1514 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1515 us-resolution time stamps.
1516 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1517
1518 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1519
1520 * lisp.h (time_overflow): New decl.
1521 (wait_reading_process_output): First arg is now intmax_t, not int,
1522 to accommodate larger waits.
1523
1524 * process.h (struct Lisp_Process.read_output_delay):
1525 Now counts nanoseconds, not microseconds.
1526 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1527 EMACS_HAS_USECS.
1528 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1529 (wait_reading_process_output):
1530 Port to ns-resolution time stamps.
1531 (Faccept_process_output, wait_reading_process_output):
1532 Check for time stamp overflow. Do not assume time_t is signed.
1533 (select_wrapper): Remove; we now use pselect.
1534 (Fprocess_attributes): Now generates ns-resolution time stamps.
1535
1536 * sysdep.c: Include utimens.h. Don't include utime.h
1537 or worry about struct utimbuf; gnulib does that for us now.
1538 (gettimeofday): Remove; gnulib provides a substitute.
1539 (make_timeval): New function.
1540 (set_file_times): Now sets ns-resolution time stamps.
1541 New arg FD; all uses changed.
1542 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1543 (system_process_attributes):
1544 Now returns ns-resolution time stamp. All uses changed.
1545 Check for time stamp overflow.
1546
1547 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1548 provides a substitute now.
1549
1550 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1551 since it guarantees struct timespec.
1552 (EMACS_TIME): Now struct timespec, so that we can support
1553 ns-resolution time stamps.
1554 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1555 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1556 (EMACS_USECS): Remove.
1557 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1558 so multiply the arg by 1000 before storing it.
1559 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1560 New macros.
1561 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1562 Port to ns-resolution time stamps.
1563 (EMACS_TIME_NEG_P): Remove; replaced by....
1564 (EMACS_TIME_SIGN): New macro.
1565 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1566 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1567 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1568 (make_timeval, make_lisp_time, decode_time_components): New decls.
1569 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1570 that it mishandled time_t overflow. You can't compare by subtracting!
1571 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1572 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1573
1574 * term.c: Include <sys/time.h>.
1575 (timeval_to_Time): New function, for proper overflow wraparound.
1576 (term_mouse_position, term_mouse_click): Use it.
1577
1578 * undo.c (record_first_change): Support higher-resolution time stamps
1579 in the undo buffer.
1580 (Fprimitive_undo): Use them when restoring time stamps.
1581
1582 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1583 (w32_get_internal_run_time):
1584 Port to higher-resolution Emacs time stamps.
1585 (ltime): Now accepts single 64-bit integer, as that's more convenient
1586 for callers.
1587
1588 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1589
1590 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1591 for compatibility with pselect. Support ns-resolution time stamps.
1592
1593 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1594
1595 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1596 Check for time stamp overflow, and support ns-resolution time stamps.
1597
1598 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1599 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1600 (timeval_subtract): Remove; no longer needed.
1601 (XTflash, XTring_bell, x_wait_for_event):
1602 Port to ns-resolution time stamps. Don't assume time_t is signed.
1603
b6a92dfe
CY
16042012-06-22 Chong Yidong <cyd@gnu.org>
1605
1606 * xdisp.c (x_consider_frame_title): Revert last change.
1607
d251c37c
EZ
16082012-06-22 Eli Zaretskii <eliz@gnu.org>
1609
1610 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1611 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1612 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1613 staticidx goes up to 1597 out of 1600 = 0x640.)
1614
f10deafb
PE
16152012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1618 Otherwise, the umask might be mistakenly 0 while handling input signals.
1619
ec6de1e2
SM
16202012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1621
1622 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1623
28be1ada
DA
16242012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1627 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1628 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1629 access to `contents' member of Lisp_Vector objects with AREF and ASET
1630 where appropriate.
1631
c6bf3022
CY
16322012-06-19 Chong Yidong <cyd@gnu.org>
1633
1634 * frame.c (delete_frame): When selecting a frame on a different
1635 text terminal, do not alter the terminal's top-frame.
1636
1637 * xdisp.c (format_mode_line_unwind_data): Record the target
1638 frame's selected window and its terminal's top-frame.
1639 (unwind_format_mode_line): Restore them.
1640 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1641 Callers changed.
1642 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1643 since tty frames can be explicitly named.
1644 (prepare_menu_bars): Likewise.
1645
1646 * term.c (Ftty_top_frame): New function.
1647
defd4196
PE
16482012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 Port byte-code-meter to modern targets.
1651 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1652 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1653 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1654 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1655 (METER_1, METER_2): Simplify.
1656
1053a871
SM
16572012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1658
1659 * data.c (Fdefalias): Return `symbol' (bug#11686).
1660
b7e8d081
MR
16612012-06-18 Martin Rudalics <rudalics@gmx.at>
1662
1663 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1664 gets killed during executing of this function (Bug#11665).
1665 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1666 (Vkill_buffer_query_functions): In doc-string say that functions
1667 run by this hook should not change the current buffer.
1668
7ea2b339
PE
16692012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 Fix recently-introduced process.c problems found by static checking.
1672 * process.c (write_queue_push, write_queue_pop, send_process):
1673 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1674 (write_queue_pop): Fix pointer signedness problem.
1675 (send_process): Remove unused local.
1676
96a313a1
CY
16772012-06-17 Chong Yidong <cyd@gnu.org>
1678
1679 * xdisp.c (redisplay_internal): No need to redisplay terminal
1680 frames that are not on top.
1681
20ca2e94
TN
16822012-06-17 Troels Nielsen <bn.troels@gmail.com>
1683
1684 * process.c (make_process): Initialize write_queue.
1685 (write_queue_push, write_queue_pop): New functions.
1686 (send_process): Use them to maintain correct ordering of process
1687 writes (Bug#10815).
1688
9a900ca9
PE
16892012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1690
310fbfa8
PE
1691 * lisp.h (eassert): Assume C89 or later.
1692 This removes the need for CHECK.
1693 (CHECK): Remove. Its comments about always evaluating its
1694 argument were confusing, as 'eassert' typically does not evaluate
1695 its argument.
1696
27bb1ca4
PE
1697 * coding.c (produce_chars): Use ptrdiff_t, not int.
1698
9a900ca9
PE
1699 * xterm.c (x_draw_underwave): Check for integer overflow.
1700 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1701
41b7f8bc 17022012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1703
1704 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1705 referenced (Bug#11583).
1706
9b0e3eba
AA
17072012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1708
1709 Implement wave-style variant of underlining.
1710 * dispextern.h (face_underline_type): New enum.
1711 (face): Add field for underline type.
1712 * nsterm.m (ns_draw_underwave): New function.
1713 (ns_draw_text_decoration): Use it.
1714 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1715 New functions.
1716 (x_draw_glyph_string): Use them.
1717 * xfaces.c (Qline, Qwave): New Lisp objects.
1718 (check_lface_attrs, merge_face_ref)
1053a871
SM
1719 (Finternal_set_lisp_face_attribute, realize_x_face):
1720 Handle wave-style underline face attributes.
9b0e3eba
AA
1721 * xterm.c (x_draw_underwave): New function.
1722 (x_draw_glyph_string): Use it.
1723
0fb52f11
JB
17242012-06-16 Juanma Barranquero <lekktu@gmail.com>
1725
1726 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1727 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1728 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1729 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1730 ($(BLD)/w32select.$(O)): Update dependencies.
1731
e5560ff7
AS
17322012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1733
1734 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1735 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1736 * character.c (_fetch_multibyte_char_p): Remove.
1737 * alloc.c: Include "character.h" before "buffer.h".
1738 * bidi.c: Likewise.
1739 * buffer.c: Likewise.
1740 * bytecode.c: Likewise.
1741 * callint.c: Likewise.
1742 * callproc.c: Likewise.
1743 * casefiddle.c: Likewise.
1744 * casetab.c: Likewise.
1745 * category.c: Likewise.
1746 * cmds.c: Likewise.
1747 * coding.c: Likewise.
1748 * composite.c: Likewise.
1749 * dired.c: Likewise.
1750 * dispnew.c: Likewise.
1751 * doc.c: Likewise.
1752 * dosfns.c: Likewise.
1753 * editfns.c: Likewise.
1754 * emacs.c: Likewise.
1755 * fileio.c: Likewise.
1756 * filelock.c: Likewise.
1757 * font.c: Likewise.
1758 * fontset.c: Likewise.
1759 * fringe.c: Likewise.
1760 * indent.c: Likewise.
1761 * insdel.c: Likewise.
1762 * intervals.c: Likewise.
1763 * keyboard.c: Likewise.
1764 * keymap.c: Likewise.
1765 * lread.c: Likewise.
1766 * macros.c: Likewise.
1767 * marker.c: Likewise.
1768 * minibuf.c: Likewise.
1769 * nsfns.m: Likewise.
1770 * nsmenu.m: Likewise.
1771 * print.c: Likewise.
1772 * process.c: Likewise.
1773 * regex.c: Likewise.
1774 * region-cache.c: Likewise.
1775 * search.c: Likewise.
1776 * syntax.c: Likewise.
1777 * term.c: Likewise.
1778 * textprop.c: Likewise.
1779 * undo.c: Likewise.
1780 * unexsol.c: Likewise.
1781 * w16select.c: Likewise.
1782 * w32fns.c: Likewise.
1783 * w32menu.c: Likewise.
1784 * window.c: Likewise.
1785 * xdisp.c: Likewise.
1786 * xfns.c: Likewise.
1787 * xmenu.c: Likewise.
1788 * xml.c: Likewise.
1789 * xselect.c: Likewise.
1790
2f07e6af
EZ
17912012-06-16 Eli Zaretskii <eliz@gnu.org>
1792
1053a871
SM
1793 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1794 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1795 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1796 row.
1797 (handle_face_prop): Use chunk-relative overlay string index when
1798 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1799 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1800 the rightmost. (Bug#11720)
2f07e6af 1801
29b83cec
AS
18022012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1803
1804 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1805 (CATEGORY_MEMBER): Enforce 1/0 value.
1806 * category.c (_temp_category_set): Remove.
1807
4c5501e9
EZ
18082012-06-16 Eli Zaretskii <eliz@gnu.org>
1809
1810 * window.c (Fdelete_other_windows_internal)
1811 (Fdelete_window_internal): Don't access frame's mouse highlight
1812 info of the initial frame. (Bug#11677)
1813
2b570124
PE
18142012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1815
e93864f9
PE
1816 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1817 Assume USE_2_TAGS_FOR_INTS.
1818 (xreload): Adjust $tagmask width to match recent lisp.h change.
1819
2b570124
PE
1820 Simplify lisp.h in minor ways that should not affect code.
1821 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1822 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1823 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1824 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1825 (INTTYPEBITS): New macro, for clarity.
1826 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1827 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1828 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1829 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1830 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1831
81755f69
JB
18322012-06-13 Juanma Barranquero <lekktu@gmail.com>
1833
1834 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1835
16192a57
GM
18362012-06-13 Glenn Morris <rgm@gnu.org>
1837
1838 * s/bsd-common.h (BSD4_3):
1839 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1840
646b5f55
AS
18412012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1842
1843 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1844 instead of union.
1845 (XLI, XIL): Define.
1053a871
SM
1846 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1847 Use them.
1848 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1849 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1850 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1851 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1852 * frame.c (delete_frame): Remove outdated comment.
1853 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1854 USE_LISP_UNION_TYPE.
1855 (Fw32_unregister_hot_key): Likewise.
1856 (Fw32_toggle_lock_key): Likewise.
1857 * w32menu.c (add_menu_item): Likewise.
1858 (w32_menu_display_help): Use XIL instead of checking
1859 USE_LISP_UNION_TYPE.
1860 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1861 (init_heap): Likewise.
1862 * w32term.c (w32_read_socket): Update comment.
1863
1d3823c9
GM
18642012-06-13 Glenn Morris <rgm@gnu.org>
1865
c62ff706
GM
1866 * s/usg5-4-common.h, src/s/unixware.h:
1867 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1868
1d3823c9
GM
1869 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1870
bfe3e0a2
PE
18712012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1874 * alloc.c (make_number) [!defined make_number]:
1875 Remove, as lisp.h always defines this now.
1876 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1877 (roundup_size): Verify that it is a power of 2.
1878 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1879 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1880 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1881 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1882 USE_LSB_TAG now is always defined to be either 0 or 1.
1883 All uses changed.
1884 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1885 code works fine either way, and efficiency is not a concern here,
1886 as the union type is for debugging, not for production.
1887 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1888 Use an inline function on all platforms when using the union type,
1889 since this is simpler and 'static inline' can be used portably
1890 within Emacs now.
1891 (LISP_INITIALLY_ZERO): New macro.
1892 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1893 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1894
45fa9c0f
GM
18952012-06-12 Glenn Morris <rgm@gnu.org>
1896
b4492cba
GM
1897 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1898
1899 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1900
45fa9c0f
GM
1901 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1902 Move BROKEN_SIGIO to configure.
1903
1904 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1905 Move NO_TERMIO to configure.
1906
0e25d334
CY
19072012-06-12 Chong Yidong <cyd@gnu.org>
1908
1909 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1910 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1911 MagickExportImagePixels is undefined.
1912
43682bb6
PE
19132012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 * image.c (imagemagick_load_image): Remove unused label.
1916
a9be7d2b
GM
19172012-06-11 Glenn Morris <rgm@gnu.org>
1918
1919 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1920 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1921 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1922 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1923
3017f87f
SM
19242012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1925
1926 * alloc.c (make_byte_code): New function.
1927 (Fmake_byte_code): Use it. Don't purify here.
1928 * lread.c (read1): Use it as well to avoid extra allocation.
1929
1b9b4cf4
CY
19302012-06-11 Chong Yidong <cyd@gnu.org>
1931
1932 * image.c (imagemagick_load_image): Implement transparency.
1933
95988fcf
AS
19342012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1935
1936 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1937 account for preceding backslashes. (Bug#11663)
1938
cd4eb164
CY
19392012-06-09 Chong Yidong <cyd@gnu.org>
1940
1941 * term.c: Support italics in capable terminals (Bug#9652).
1942 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1943 (turn_on_face): Output using TS_enter_italic_mode if available.
1944 Don't handle unused blinking and alt-charset cases.
1945 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1946 and tty_alt_charset_p cases.
1947 (tty_capable_p, init_tty): Support italics.
1948
1949 * termchar.h (struct tty_display_info): Add field for italics.
1950 Remove unused blink field.
1951
1952 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1953 Handle slant.
1954
1955 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1956 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1957 tty_alt_charset_p. Add tty_italic_p.
1958
ff88beb8
MA
19592012-06-09 Michael Albinus <michael.albinus@gmx.de>
1960
1961 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1962 dbus_type_is_basic if available.
1963 (xd_extract_signed, xd_extract_unsigned): Rename from
1964 extract_signed and extract_unsigned, respectively. Adapt callers.
1965
44286096
CY
19662012-06-09 Chong Yidong <cyd@gnu.org>
1967
1682701f
CY
1968 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1969
44286096
CY
1970 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1971 case (Bug#9752).
1972
d86feb17
PE
19732012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1974
1975 * xdisp.c (vmessage): Treat frame message as multibyte.
1976 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1977 would generate the diagnostic "Making \302\247 buffer-local while
1978 let-bound!".
1979
d5c20fe8
EZ
19802012-06-08 Eli Zaretskii <eliz@gnu.org>
1981
1982 * dispnew.c (showing_window_margins_p): Undo last change, which
1983 was done due to an inadvertent commit.
1984 (adjust_frame_glyphs_for_frame_redisplay): Do call
1985 showing_window_margins_p.
1986
513749ee
SM
19872012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1988
1989 * eval.c (Fmake_var_non_special): New primitive.
1990 (syms_of_eval): Defsubr it.
1991 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1992
d4a8f5c1
JB
19932012-06-08 Juanma Barranquero <lekktu@gmail.com>
1994
1995 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1996 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1997
8bbbc977
EZ
19982012-06-08 Eli Zaretskii <eliz@gnu.org>
1999
2000 * alloc.c (allocate_vectorlike): Fix last change.
2001
f3372c87
DA
20022012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2003
2004 Block-based vector allocation of small vectors.
2005 * lisp.h (struct vectorlike_header): New field `nbytes',
2006 adjust comment accordingly.
2007 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2008 to denote vector blocks. Adjust users (live_vector_p,
2009 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2010 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2011 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2012 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2013 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2014 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2015 (roundup_size): New constant.
2016 (struct vector_block): New data type.
2017 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2018 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2019 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2020 (sweep_vectors): New functions.
2021 (allocate_vectorlike): Return `zero_vector' as the only vector of
2022 0 items. Allocate new vector from block if vector size is less than
2023 or equal to VBLOCK_BYTES_MAX.
2024 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2025 (init_alloc_once): Add call to init_vectors.
2026
4f18a4ed
SM
20272012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2028
2029 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2030
86f158bc
PE
20312012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 * doprnt.c (doprnt): Truncate multibyte char correctly.
2034 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2035 would mishandle a string argument "Xc" if X was a multibyte
2036 character of length 2: it would truncate after X's first byte
2037 rather than including all of X.
2038
c5cfcbe0
CY
20392012-06-06 Chong Yidong <cyd@gnu.org>
2040
2041 * buffer.c (word_wrap): Doc fix.
2042
c05cf390
PE
20432012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2046
0c3461de
GM
20472012-06-03 Glenn Morris <rgm@gnu.org>
2048
2049 * xdisp.c (tool-bar-style): Doc fix.
2050
c71232db
UM
20512012-06-03 Ulrich Müller <ulm@gentoo.org>
2052
2053 * Makefile.in (PAXCTL): Define.
2054 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2055 binary via PaX flags if the paxctl utility is available.
2056 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2057 Restore PaX flags to their default. (Bug#11398)
2058
383f7350
CY
20592012-06-03 Chong Yidong <cyd@gnu.org>
2060
2061 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2062 buffer (Bug#11226).
2063
5f2c76c6
CY
20642012-06-03 Chong Yidong <cyd@gnu.org>
2065
2066 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2067 (note_mode_line_or_margin_highlight): If there is no help echo,
2068 use mode-line-default-help-echo. Handle the case where the mouse
2069 position is past the end of the mode line string.
2070
2071 * buffer.c (buffer_local_value_1): New function, split from
2072 Fbuffer_local_value; can return Qunbound.
2073 (Fbuffer_local_value): Use it.
2074 (Vmode_line_format): Docstring tweaks.
2075
773d47f6
PE
20762012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * sysdep.c (system_process_attributes): Improve comment.
2079
f2d6a3df
SM
20802012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2081
2082 * keyboard.c: Export real-this-command to Elisp.
2083 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2084 and DEFVAR it. Update all users.
2085
63810350
PE
20862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2087
7bd5c1f4
PE
2088 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2089
63810350
PE
2090 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2091 Convert pctcpu and pctmem to Lisp float properly.
2092 Let the compiler fold better, as 100.0/0x8000 is exact.
2093
a2821611
AS
20942012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2095
2096 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2097 cons_block.
2098
5fceba1d
PE
20992012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2102
c98ff5dd
DA
21032012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2104
2105 For a 'struct window', replace some Lisp_Object fields to
2106 bitfields where appropriate, remove unused fields.
2107 * window.h (struct window): Remove unused 'last_mark_x' and
2108 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2109 change it's type from Lisp_Object to bitfield.
2110 Change type of 'force_start', 'optional_new_start',
2111 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2112 fields from Lisp_Object to bitfield. Adjust users accordingly.
2113
ca34e0be
PE
21142012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 Pacify gcc -Wdouble-precision when using Xaw.
2117 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2118 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2119 Use 'float' consistently, rather than 'float' in most places
2120 and 'double' in a couple of places.
2121
efc00ab1 21222012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2123
2124 * xdisp.c (handle_stop): Detect whether we have overlay strings
2125 loaded by testing it->current.overlay_string_index to be
2126 non-negative, instead of checking whether n_overlay_strings is
2127 positive. (Bug#11587)
2128
efc00ab1 21292012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2130
2131 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2132
2133 * doc.c (Fsubstitute_command_keys): Doc fix.
2134
efc00ab1 21352012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2136
2137 * search.c (search_buffer): Remove calls to
2138 r_alloc_inhibit_buffer_relocation, as it is now called by
2139 maybe_unify_char, which was the cause of relocation of buffer text
2140 in bug#11519.
2141
efc00ab1 21422012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2143
2144 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2145 for the duration of call to load_charset, to avoid problems with
2146 callers of maybe_unify_char that access buffer text through C
2147 pointers.
2148
2149 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2150 decrement the inhibition flag, instead of just setting or
2151 resetting it.
2152
ba93a187
PE
21532012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 Remove obsolete '#define static' cruft.
2156 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2157 This #undef was "temporary" in 2000; it is no longer needed
2158 now that '#define static' has gone away.
2159 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2160 (gray_bitmap_bits): Remove; no longer needed.
2161 All uses replaced with definiens.
2162 * xterm.c: Include "bitmaps/gray.xbm".
2163
9e4bf381
PE
21642012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 Clean up __executable_start, monstartup when --enable-profiling.
2167 The following changes affect the code only when profiling.
2168 * dispnew.c (__executable_start): Rename from safe_bcopy.
2169 Define only on platforms that need it.
2170 * emacs.c: Include <sys/gmon.h> when profiling.
2171 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2172 (__executable_start): Remove decl, since lisp.h does it now.
2173 (safe_bcopy): Remove decl; no longer has that name.
2174 (main): Coalesce #if into single bit of code, for simplicity.
2175 Cast pointers to uintptr_t, since standard libraries want integers
2176 and not pointers.
2177 * lisp.h (__executable_start): New decl.
2178
32d72c2f
GM
21792012-05-31 Glenn Morris <rgm@gnu.org>
2180
2181 * image.c (Fimagemagick_types): Doc fix.
2182
baac5bc7
JM
21832012-05-30 Jim Meyering <meyering@redhat.com>
2184
2185 * callproc.c (Fcall_process_region): Include directory component
2186 in mkstemp error message (Bug#11586).
2187
72cb32cf
PE
21882012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * alloc.c, lisp.h (make_pure_vector): Now static.
2191
61b108cc
SM
21922012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2195 Move to byte-run.el.
2196 (Fautoload): Do the hash-doc more carefully.
2197 * data.c (Fdefalias): Purify definition, except for keymaps.
2198 (Qdefun): Move from eval.c.
2199 * lisp.h (Qdefun): Remove.
2200 * lread.c (read1): Tiny simplification.
2201
471fe23d
TN
22022012-05-29 Troels Nielsen <bn.troels@gmail.com>
2203
934f3f58 2204 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2205 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2206 Bug#9642, but explicitly check that the buffer the overlay would
2207 be moved to is live and rearrange lines to make sure that errors
2208 will not put the overlay in an inconsistent state.
2209 (Fdelete_overlay): Cosmetics.
2210
85d0efd1
EZ
22112012-05-28 Eli Zaretskii <eliz@gnu.org>
2212
2213 * w32term.c (my_bring_window_to_top): New function.
2214 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2215 could be different from the original one.
2216 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2217 (Bug#11513)
2218
2219 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2220 by calling BringWindowToTop.
2221
2222 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2223 (WM_EMACS_END): Increase by one.
2224
da92a98c
PE
22252012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2228 This avoids undefined behavior that might cause the eassert
2229 to not catch an out-of-range value.
2230
74d1f848
JB
22312012-05-28 Juanma Barranquero <lekktu@gmail.com>
2232
2233 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2234 Update dependencies.
2235
9e1a06fc
EZ
22362012-05-27 Eli Zaretskii <eliz@gnu.org>
2237
2238 * bidi.c (bidi_mirror_char): Fix last change.
2239
f3dd7312
AS
22402012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2241
2242 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2243 when referring to sectname field in printf format.
2244
81899c91
PE
22452012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2246
57b81a9f
PE
2247 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2248 Only r_alloc_inhibit_buffer_relocation needed to be added;
2249 the others were already declared.
2250
81899c91
PE
2251 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2252 before checking whether it's out of range. Put the check inside
2253 eassert. See
2254 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2255
33017faf 22562012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2257
2258 * callproc.c (Fcall_process): Restore a line that was accidentally
2259 commented out in the 2011-02-13 change (bug#11547).
2260
33017faf 22612012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2262
2263 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2264 defined on ralloc.c.
2265
2266 * buffer.c [REL_ALLOC]: Remove prototypes of
2267 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2268 they are now on lisp.h.
2269
2270 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2271
2272 * search.c (search_buffer): Use it to inhibit relocation of buffer
2273 text while re_search_2 is doing its job, because re_search_2 is
2274 passed C pointers to buffer text. (Bug#11519)
2275
23415acf
EZ
2276 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2277 Update value to 24.
2278
44e27368
EZ
2279 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2280 state after an additional call to move_it_in_display_line_to, keep
2281 the values of it->max_ascent and it->max_descent found for the
2282 entire line.
2283 (pos_visible_p): Revert the comparison against bottom_y to what it
2284 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2285 (Bug#11464)
2286
c1892f11
PE
22872012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 Fix coding-related core dumps with gcc -ftrapv.
2290 The code was computing A - B, where A and B are pointers, and B is
2291 random garbage. This can lead to core dumps on platforms that
2292 have special pointer registers, and it also leads to core dumps on
2293 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2294 A - B only when B is initialized properly.
2295 * coding.c (coding_set_source, coding_set_destination): Return void.
2296 (coding_change_source, coding_change_destinations): New functions,
2297 with the old behaviors of coding_set_source and coding_set_destination.
2298 All callers that need an offset changed to use these new functions.
2299
eb7afdad
GM
23002012-05-26 Glenn Morris <rgm@gnu.org>
2301
2302 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2303
f12fdf02
EZ
23042012-05-26 Eli Zaretskii <eliz@gnu.org>
2305
53a63be6 2306 Extend mouse support on W32 text-mode console.
61b108cc
SM
2307 * xdisp.c (draw_row_with_mouse_face):
2308 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2309
eb3f6f01 2310 * w32console.c: Include window.h.
61b108cc
SM
2311 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2312 New functions.
eb3f6f01
EZ
2313 (initialize_w32_display): Initialize mouse-highlight data.
2314
53a63be6
EZ
2315 * w32inevt.c: Include termchar.h and window.h.
2316 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2317 moves, call note_mouse_highlight. If help_echo changed, call
2318 gen_help_event to produce help-echo message in the echo area.
2319 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2320 highlight info.
2321
4cfd81f6
PE
23222012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2323
2324 * lread.c (read1): Simplify slightly to avoid an overflow warning
2325 with GCC 4.7.0 on x86-64.
2326
4446092a
EZ
23272012-05-26 Eli Zaretskii <eliz@gnu.org>
2328
2329 * bidi.c (bidi_mirror_char): Revert last change: an int is
2330 definitely wide enough here.
2331
42b2a986 23322012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2333
42b2a986 2334 Fix integer width and related bugs (Bug#9874).
eb106a49 2335 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2336 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2337 (string_bytes, check_sblock, allocate_string_data):
2338 (compact_small_strings, Fmake_bool_vector, make_string)
2339 (make_unibyte_string, make_multibyte_string)
2340 (make_string_from_bytes, make_specified_string)
2341 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2342 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2343 (mark_vectorlike):
2344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2345 (allocate_pseudovector):
2346 Use int, not EMACS_INT, where int is wide enough.
2347 (inhibit_garbage_collection, Fgarbage_collect):
2348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2349 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2350 int might not be wide enough.
2351 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2352 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2353 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2354 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2355 (bidi_level_of_next_char, bidi_move_to_visually_next):
2356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2357 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2358 (Fkill_buffer, Fset_buffer_major_mode)
2359 (advance_to_char_boundary, Fbuffer_swap_text)
2360 (Fset_buffer_multibyte, overlays_at, overlays_in)
2361 (overlay_touches_p, struct sortvec, record_overlay_string)
2362 (overlay_strings, recenter_overlay_lists)
2363 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2364 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2365 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2366 (Foverlay_recenter, last_overlay_modification_hooks_used)
2367 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2369 (validate_region): Omit unnecessary test for b <= e,
2370 since that's guaranteed by the previous test.
d311d28c
PE
2371 (adjust_overlays_for_delete): Avoid pos + length overflow.
2372 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2373 (report_overlay_modification):
2374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2375 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2376 Omit pointer cast, which isn't needed anyway, and doesn't work
2377 after the EMACS_INT -> ptrdiff_t change.
02481186 2378 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2379 * buffer.h: Adjust decls to match defn changes elsewhere.
2380 (struct buffer_text, struct buffer):
2381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2382 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2383 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2384 not int, to avoid needless 32-bit limit on 64-bit hosts.
2385 (exec_byte_code): Use tighter memory-full test, one that checks
2386 for alloca overflow. Don't compute the address of the object just
2387 before an array, as that's not portable. Use EMACS_INT, not
2388 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2389 * callint.c (Fcall_interactively):
2390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2391 * callproc.c (call_process_kill, Fcall_process):
2392 Don't assume pid_t fits into an Emacs fixnum.
2393 (call_process_cleanup, Fcall_process, child_setup):
2394 Don't assume pid_t fits into int.
2395 (call_process_cleanup, Fcall_process, delete_temp_file)
2396 (Fcall_process_region):
2397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2398 (Fcall_process): Simplify handling of volatile integers.
2399 Use int, not EMACS_INT, where int will do.
2400 * casefiddle.c (casify_object, casify_region, operate_on_word)
2401 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2403 (casify_object): Avoid integer overflow when overallocating buffer.
2404 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2405 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2406 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2407 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2408 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2409 integers are now checked earlier. All uses replaced with XINT.
2410 (ccl_driver):
2411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2412 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2413 (ccl_driver, Fregister_code_conversion_map):
2414 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2415 (resolve_symbol_ccl_program): Check that vector header is in range.
2416 Always copy the vector, so that we can check its contents reliably
2417 now rather than having to recheck each instruction as it's being
2418 executed. Check that vector words fit in 'int'.
2419 (ccl_get_compiled_code, Fregister_ccl_program)
2420 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2421 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2422 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2423 contents are in range.
2424 (Fccl_execute_on_string): Check that status is in range.
2425 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2426 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2427 Accept and return EMACS_INT, not int, because callers can pass values
2428 out of 'int' range.
2429 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2430 (multibyte_chars_in_text, parse_str_as_multibyte)
2431 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2432 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2433 (string_escape_byte8, Fget_byte):
2434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2435 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2436 avoid mishandling large integers.
2437 * character.h: Adjust decls to match defn changes elsewhere.
2438 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2439 (Ffind_charset_region):
2440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2441 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2442 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2443 Don't assume fixnum fits in int.
d311d28c
PE
2444 (load_charset_map_from_vector, Fmap_charset_chars):
2445 Remove now-unnecessary CHECK_NATNUMs.
2446 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2447 Don't rely on undefined behavior with signed left shift overflow.
2448 Don't assume unsigned int fits into fixnum, or that fixnum fits
2449 into unsigned int. Don't require max_code to be a valid fixnum;
2450 that's not true for gb10830 4-byte on a 32-bit host. Allow
2451 invalid_code to be a cons, for the same reason. Require code_offset
2452 to be a character. Avoid int overflow if max_char is close
2453 to INT_MAX.
2454 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2455 this is intended anyway and avoids some undefined behavior.
2456 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2457 INDEX_TO_CODE_POINT, as that's what it expects.
2458 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2459 * charset.h (DECODE_CHAR): Return int, not unsigned;
2460 this is what was intended anyway, and it avoids undefined behavior.
2461 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2462 integer-overflow issues.
2463 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2464 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2465 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2466 * chartab.c (Fmake_char_table, Fset_char_table_range)
2467 (uniprop_get_decoder, uniprop_get_encoder):
2468 Don't assume fixnum fits in int.
2469 * cmds.c (move_point): New function, that does the gist of
2470 Fforward_char and Fbackward_char, but does so while checking
2471 for integer overflow more accurately.
c96e5d6a 2472 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2473 (Fforward_line, Fend_of_line, internal_self_insert)
2474 (internal_self_insert):
2475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2476 Fix a FIXME, by checking for integer overflow when calculating
2477 target_clm and actual_clm.
2478 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2479 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2480 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2481 (coding_alloc_by_making_gap, alloc_destination)
2482 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2483 (encode_coding_utf_16, detect_coding_emacs_mule)
2484 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2485 (detect_coding_iso_2022, decode_coding_iso_2022)
2486 (encode_invocation_designation, encode_designation_at_bol)
2487 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2488 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2489 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2490 (encode_coding_ccl, encode_coding_raw_text)
2491 (detect_coding_charset, decode_coding_charset)
2492 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2493 (produce_composition, produce_charset, produce_annotation)
2494 (decode_coding, handle_composition_annotation)
2495 (handle_charset_annotation, consume_chars, decode_coding_gap)
2496 (decode_coding_object, encode_coding_object, detect_coding_system)
2497 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2498 (code_convert_region, code_convert_string)
8f50130c
PE
2499 (Fdefine_coding_system_internal)
2500 (coding_set_source, coding_set_destination):
d311d28c
PE
2501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2502 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2503 (Fdefine_coding_system_internal):
2504 Don't assume fixnums fit in int.
2505 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2506 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2507 (Funencodable_char_position, Fcheck_coding_systems_region)
2508 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2510 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2511 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2512 Don't access memory outside of the args array.
d311d28c 2513 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2514 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2515 result of ENCODE_CHAR.
d311d28c
PE
2516 * coding.h: Adjust decls to match defn changes elsewhere.
2517 (struct coding_system):
2518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2519 * composite.c (get_composition_id, find_composition)
2520 (run_composition_function, update_compositions)
2521 (compose_text, composition_gstring_put_cache)
2522 (composition_gstring_p, composition_gstring_width)
2523 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2524 (composition_compute_stop_pos, composition_reseat_it)
2525 (composition_update_it, struct position_record)
2526 (find_automatic_composition, composition_adjust_point)
2527 (Fcomposition_get_gstring, Ffind_composition_internal):
2528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2529 (update_compositions):
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 * composite.h: Adjust decls to match defn changes elsewhere.
2532 (struct composition):
2533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2534 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2535 Do not attempt to compute the address of the object just before a
2536 buffer; this is not portable.
2537 (Faref, Faset):
2538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2539 (Faset): Use int, not EMACS_INT, where int is wide enough.
2540 (Fstring_to_number): Don't assume fixnums fit in int.
2541 (Frem): Don't assume arg is nonnegative.
2542 * dbusbind.c (xd_append_arg): Check for integers out of range.
2543 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2544 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2545 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2546 (xd_get_connection_references): Return ptrdiff_t, not int.
2547 All uses changed.
2548 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2549 (xd_read_message_1):
2550 Use int, not unsigned, where the dbus API uses int.
2551 (Fdbus_message_internal): Don't overflow mtype.
2552 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2553 * dired.c (directory_files_internal, file_name_completion, scmp)
2554 (file_name_completion_stat):
2555 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 (file_name_completion): Don't overflow matchcount.
2557 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2558 * dispextern.h: Adjust decls to match defn changes elsewhere.
2559 (struct text_pos, struct glyph, struct bidi_saved_info)
2560 (struct bidi_string_data, struct bidi_it, struct composition_it)
2561 (struct it):
2562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2563 (struct display_pos, struct composition_it, struct it):
2564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2565 * dispnew.c (increment_matrix_positions)
2566 (increment_row_positions, mode_line_string)
2567 (marginal_area_string):
2568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2569 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2571 (duration_to_sec_usec): New function, to check for overflow better.
2572 (Fsleep_for, sit_for): Use it.
2573 * doc.c (get_doc_string, store_function_docstring):
2574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2575 (get_doc_string, Fsnarf_documentation):
2576 Use int, not EMACS_INT, where int is wide enough.
2577 (get_doc_string):
2578 Use SAFE_ALLOCA, not alloca.
2579 Check for overflow when converting EMACS_INT to off_t.
2580 * doprnt.c (doprnt):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2583 Don't assume uid_t fits into fixnum.
2584 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2585 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2586 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2587 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2588 (general_insert_function)
2589 (Finsert_char, make_buffer_string, make_buffer_string_both)
2590 (update_buffer_properties, Fbuffer_substring)
2591 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2592 (Fsubst_char_in_region, check_translation)
2593 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2594 (transpose_markers, Ftranspose_regions):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2596 (clip_to_bounds): Move to lisp.h as an inline function).
2597 (Fconstrain_to_field): Don't assume integers are nonnegative.
2598 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2599 (Fsubst_char_in_region, Fsave_restriction):
2600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2601 (Femacs_pid): Don't assume pid_t fits into fixnum.
2602 (lo_time): Use int, not EMACS_INT, when int suffices.
2603 (lisp_time_argument): Check for usec out of range.
2604 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2605 (Fuser_login_name, Fuser_full_name): Signal an error
2606 if a uid argument is out of range, rather than relying on
2607 undefined behavior.
c8d5c857
PE
2608 (Fformat_time_string): Remove now-unnecessary check.
2609 lisp_time_argument checks for out-of-range usec now.
243e0530 2610 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2611 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2612 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2613 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2614 (init_cmdargs, Fdump_emacs):
2615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2616 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2617 the bottom (typically) 32 bits of the fixnum.
2618 * eval.c (specpdl_size, call_debugger):
2619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2620 (when_entered_debugger, Fbacktrace_debug):
2621 Don't assume fixnum can fit in int.
2622 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2623 the object just before a buffer; this is not portable.
2624 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2625 (grow_specpdl, unbind_to):
2626 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2627 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2628 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2629 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2630 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2631 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2633 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2634 (a_write, e_write):
2635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2636 (Fcopy_file, non_regular_nbytes, read_non_regular)
2637 (Finsert_file_contents):
2638 Use int, not EMACS_INT, where int is wide enough.
2639 (READ_BUF_SIZE): Verify that it fits in int.
2640 (Finsert_file_contents): Check that counts are in proper range,
2641 rather than assuming fixnums fit into ptrdiff_t etc.
2642 Don't assume fixnums fit into int.
125b3835 2643 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2644 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2645 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2646 (string_char_to_byte, string_byte_to_char)
2647 (string_make_multibyte, string_to_multibyte)
2648 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2649 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2650 (substring_both, Fdelete, internal_equal, Ffillarray)
2651 (Fclear_string, mapcar1)
2652 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2653 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2654 (larger_vector, make_hash_table, maybe_resize_hash_table)
2655 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2656 (Fmaphash, secure_hash):
2657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2658 (concat): Check for string index and length overflow.
2659 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2660 (Frequire):
2661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2662 (larger_vector): New API (vec, incr_min, size_max) replaces old
2663 one (vec, new_size, init). This catches size overflow.
2664 INIT was removed because it was always Qnil.
2665 All callers changed.
2666 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2667 the upper bound on a hash table index size.
2668 (make_hash_table, maybe_resize_hash_table): Use it.
2669 (secure_hash): Computer start_byte and end_byte only after
2670 they're known to be in ptrdiff_t range.
2671 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2672 (Ffont_get_glyphs, Ffont_at):
2673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2674 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2675 (Flist_fonts, Fopen_font):
2676 Don't assume fixnum can fit in int.
2677 (check_gstring): Don't assume index can fit in int.
2678 (font_match_p): Check that fixnum is a character, not a nonnegative
2679 fixnum, since the later code needs to stuff it into an int.
2680 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2681 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2682 conversion overflow issues.
2683 (Fopen_font): Check for integer out of range.
2684 (Ffont_get_glyphs): Don't assume index can fit in int.
2685 * font.h: Adjust decls to match defn changes elsewhere.
2686 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2687 integer overflow.
2688 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2689 printmax_t, where ptrdiff_t is wide enough.
2690 (Finternal_char_font):
2691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2692 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2693 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2694 (Fset_frame_position, x_set_frame_parameters)
2695 (x_set_line_spacing, x_set_border_width)
2696 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2697 Check that fixnums are in proper range for system types.
2698 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2700 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2701 Use SAFE_ALLOCA_LISP, not alloca.
2702 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2703 intptr_t is wide enough.
2704 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2705 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2706 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2707 Check for fixnum out of range.
2708 * ftfont.c (ftfont_list): Don't assume index fits in int.
2709 Check that fixnums are in proper range for system types.
2710 (ftfont_shape_by_flt):
2711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2712 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2714 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2715 Check that fixnums are in proper range for system types.
2716 * gnutls.h: Adjust decls to match defn changes elsewhere.
2717 * gtkutil.c (xg_dialog_run):
2718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2719 (update_frame_tool_bar):
2720 Check that fixnums are in proper range for system types.
2721 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2722 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2723 * indent.c (last_known_column, last_known_column_point):
2724 (current_column_bol_cache):
2725 (skip_invisible, current_column, check_display_width):
2726 (check_display_width, scan_for_column, current_column_1)
2727 (Findent_to, Fcurrent_indentation, position_indentation)
2728 (indented_beyond_p, Fmove_to_column, compute_motion):
2729 (Fcompute_motion, Fvertical_motion):
2730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2731 (last_known_column_modified): Use EMACS_INT, not int.
2732 (check_display_width):
2733 (Fcompute_motion):
2734 Check that fixnums and floats are in proper range for system types.
2735 (compute_motion): Don't assume index or fixnum fits in int.
2736 (compute_motion, Fcompute_motion):
2737 Use int, not EMACS_INT, when it is wide enough.
2738 (vmotion): Omit local var start_hpos that is always 0; that way
2739 we don't need to worry about overflow in expressions involving it.
2740 * indent.h: Adjust decls to match defn changes elsewhere.
2741 (struct position):
2742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2743 Use int, not EMACS_INT, where int is wide enough.
2744 Remove unused members ovstring_chars_done and tab_offset;
2745 all uses removed.
2746 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2747 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2748 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2749 (make_gap, copy_text, insert, insert_and_inherit)
2750 (insert_before_markers, insert_before_markers_and_inherit)
2751 (insert_1, count_combining_before, count_combining_after)
2752 (insert_1_both, insert_from_string)
2753 (insert_from_string_before_markers, insert_from_string_1)
2754 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2755 (adjust_after_replace, adjust_after_insert, replace_range)
2756 (replace_range_2, del_range, del_range_1, del_range_byte)
2757 (del_range_both, del_range_2, modify_region)
2758 (prepare_to_modify_buffer, signal_before_change)
2759 (signal_after_change, Fcombine_after_change_execute):
2760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2761 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2762 (balance_an_interval, split_interval_right, split_interval_left)
2763 (find_interval, next_interval, update_interval)
2764 (adjust_intervals_for_insertion, delete_node, delete_interval)
2765 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2766 (static_offset_intervals, offset_intervals)
2767 (merge_interval_right, merge_interval_left, make_new_interval)
2768 (graft_intervals_into_buffer, temp_set_point_both)
2769 (temp_set_point, set_point, adjust_for_invis_intang)
2770 (set_point_both, move_if_not_intangible, get_property_and_range)
2771 (get_local_map, copy_intervals, copy_intervals_to_string)
2772 (compare_string_intervals, set_intervals_multibyte_1):
2773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2774 * intervals.h: Adjust decls to match defn changes elsewhere.
2775 (struct interval):
2776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2777 * keyboard.c (this_command_key_count, this_single_command_key_start)
2778 (before_command_key_count, before_command_echo_length, echo_now)
2779 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2780 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2781 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2782 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2784 (last_non_minibuf_size, last_point_position, echo_truncate)
2785 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2786 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2787 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2788 (stuff_buffered_input):
2789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2790 (last_auto_save, command_loop_1, read_char):
2791 Use EMACS_INT, not int, to avoid integer overflow.
2792 (record_char): Avoid overflow in total_keys computation.
2793 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2794 * keyboard.h: Adjust decls to match defn changes elsewhere.
2795 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2796 (Fkey_description, Fdescribe_vector, Flookup_key):
2797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2798 (click_position): New function, to check that positions are in range.
2799 (Fcurrent_active_maps):
2800 (describe_command):
2801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2802 (Faccessible_keymaps, Fkey_description):
2803 (preferred_sequence_p):
2804 Don't assume fixnum can fit into int.
2805 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2806 Check for integer overflow in size calculations.
2807 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2808 avoid mishandling large integers.
2809 * lisp.h: Adjust decls to match defn changes elsewhere.
2810 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2811 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2812 (struct Lisp_Marker):
2813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2814 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2815 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2816 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2817 All callers changed.
2818 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2819 Assume the arg has valid form, since it always does.
2820 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2821 unsigned integer system type.
2822 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2823 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2825 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2826 (duration_to_sec_usec): New decl.
2827 * lread.c (read_from_string_index, read_from_string_index_byte)
2828 (read_from_string_limit, readchar, unreadchar, openp)
2829 (read_internal_start, read1, oblookup):
2830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2831 (Fload, readevalloop, Feval_buffer, Feval_region):
2832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2833 (openp): Check for out-of-range argument to 'access'.
2834 (read1): Use int, not EMACS_INT, where int is wide enough.
2835 Don't assume fixnum fits into int.
6efdadfd 2836 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2837 (read_filtered_event): Use duration_to_sec_usec
2838 to do proper overflow checking on durations.
d311d28c
PE
2839 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2840 in size calculation.
2841 (Fexecute_kbd_macro):
2842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2843 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2844 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2845 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2846 (set_marker_both, set_marker_restricted_both, marker_position)
2847 (marker_byte_position, Fbuffer_has_markers_at):
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2849 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2850 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2851 It now merely ensures that the menu is large enough, without
2852 necessarily growing it, as this avoids some integer overflow issues.
2853 All callers changed.
2854 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2856 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2857 Use SAFE_ALLOCA_LISP, not alloca.
2858 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2859 to EMACS_INT. Check that fixnums are in proper range for system types.
2860 * minibuf.c (minibuf_prompt_width, string_to_object)
2861 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2862 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2864 (get_minibuffer, read_minibuf_unwind):
2865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2866 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2867 this simplifies overflow checking. All callers changed.
2868 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2869 (Ftest_completion):
2870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2871 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2872 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2873 Check that fixnums are in proper range for system types.
2874 (Fx_create_frame, Fx_show_tip):
2875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2876 * nsfont.m (ns_findfonts, nsfont_list_family):
2877 Don't assume fixnum fits in long.
2878 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2880 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2881 wide enough.
17fdb222 2882 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2884 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2885 (PRINTDECLARE, PRINTPREPARE):
2886 (strout, print_string):
2887 (print, print_preprocess, print_check_string_charset_prop)
2888 (print_object):
2889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2890 (PRINTDECLARE):
2891 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2893 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2894 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2895 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2896 (print_error_message): Use SAFE_ALLOCA, not alloca.
2897 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2898 (print_depth, new_backquote_output, print_number_index):
2899 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2900 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2901 (Fset_process_window_size, Fformat_network_address)
2902 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2903 (sigchld_handler):
d311d28c 2904 Check that fixnums are in proper range for system types.
d44287d4 2905 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2906 Check for process-ids out of pid_t range rather than relying on
2907 undefined behavior.
e4d81efc 2908 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2909 (Fformat_network_address, read_process_output, send_process)
2910 (Fprocess_send_region, status_notify):
2911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2912 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2913 (wait_reading_process_output, read_process_output, exec_sentinel):
2914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2915 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2916 (Faccept_process_output): Use duration_to_sec_usec to do proper
2917 overflow checking on durations.
dde14581
PE
2918 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2919 Don't assume pid_t fits in int.
02481186
PE
2920 * process.h (struct Lisp_Process): Members tick and update_tick
2921 are now of type EMACS_INT, not int.
b62b53e8
PE
2922 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2923 configured --with-wide-int.
d311d28c
PE
2924 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2925 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2926 * search.c (looking_at_1, string_match_1):
2927 (fast_string_match, fast_c_string_match_ignore_case)
2928 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2929 (scan_newline, find_before_next_newline, search_command)
2930 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2931 (set_search_regs, wordify):
2932 (Freplace_match):
2933 (Fmatch_data):
2934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2935 (string_match_1, search_buffer, set_search_regs):
2936 (Fmatch_data):
2937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2938 (wordify): Check for overflow in size calculation.
2939 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2940 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2941 Check that fixnums are in proper range for system types.
2942 * sound.c (struct sound_device)
2943 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2945 (Fplay_sound_internal):
2946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2947 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2948 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2949 (Fparse_partial_sexp):
2950 Don't assume fixnums can fit in int.
2951 (struct lisp_parse_state, find_start_pos, find_start_value)
2952 (find_start_value_byte, find_start_begv)
2953 (update_syntax_table, char_quoted, dec_bytepos)
2954 (find_defun_start, prev_char_comend_first, back_comment):
2955 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2956 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2958 (Finternal_describe_syntax_value): Check that match_lisp is a
2959 character, not an integer, since the code stuffs it into int.
2960 (scan_words, scan_sexps_forward):
2961 Check that fixnums are in proper range for system types.
2962 (Fforward_word):
2963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2964 (scan_sexps_forward):
2965 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2966 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2967 * syntax.h: Adjust decls to match defn changes elsewhere.
2968 (struct gl_state_s):
2969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2970 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2971 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2972 * sysdep.c (wait_for_termination_1, wait_for_termination)
2973 (interruptible_wait_for_termination, mkdir):
2974 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2975 (emacs_read, emacs_write):
2976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2977 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2978 and double all fit in int.
d311d28c
PE
2979 * term.c (set_tty_color_mode):
2980 Check that fixnums are in proper range for system types.
2981 * termhooks.h (struct input_event):
2982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2983 * textprop.c (validate_interval_range, interval_of)
2984 (Fadd_text_properties, set_text_properties_1)
2985 (Fremove_text_properties, Fremove_list_of_text_properties)
2986 (Ftext_property_any, Ftext_property_not_all)
2987 (copy_text_properties, text_property_list, extend_property_ranges)
2988 (verify_interval_modification):
2989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2990 (Fnext_single_char_property_change)
2991 (Fprevious_single_char_property_change):
2992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2993 (copy_text_properties):
2994 Check for integer overflow in index calculation.
d311d28c
PE
2995 * undo.c (last_boundary_position, record_point, record_insert)
2996 (record_delete, record_marker_adjustment, record_change)
2997 (record_property_change):
2998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2999 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3001 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3002 (Fx_hide_tip, Fx_file_dialog):
3003 * w32menu.c (set_frame_menubar):
3004 Use ptrdiff_t, not int, for consistency with rest of code.
3005 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3006 (select_window, Fdelete_other_windows_internal)
3007 (window_scroll_pixel_based, window_scroll_line_based)
3008 (Frecenter, Fset_window_configuration):
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 (Fset_window_hscroll, run_window_configuration_change_hook)
3011 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3012 (Fscroll_other_window, Frecenter):
d311d28c
PE
3013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3014 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3015 Don't assume fixnum fits in int.
3016 (Fset_window_scroll_bars):
3017 Check that fixnums are in proper range for system types.
3018 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3019 (string_pos, c_string_pos, number_of_chars, init_iterator)
3020 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3021 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3022 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3023 (face_before_or_after_it_pos, handle_invisible_prop)
3024 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3025 (display_prop_intangible_p, string_buffer_position_lim)
3026 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3027 (get_overlay_strings_1, get_overlay_strings)
3028 (iterate_out_of_display_property, forward_to_next_line_start)
3029 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3030 (get_next_display_element, set_iterator_to_next)
3031 (get_visually_first_element, compute_stop_pos_backwards)
3032 (handle_stop_backwards, next_element_from_buffer)
3033 (move_it_in_display_line_to, move_it_in_display_line)
3034 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3035 (add_to_log, message_dolog, message_log_check_duplicate)
3036 (message2, message2_nolog, message3, message3_nolog
3037 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3038 (current_message_1, truncate_echo_area, truncate_message_1)
3039 (set_message, set_message_1, store_mode_line_noprop)
3040 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3041 (text_outside_line_unchanged_p, check_point_in_composition)
3042 (reconsider_clip_changes)
3043 (redisplay_internal, set_cursor_from_row, try_scrolling)
3044 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3045 (redisplay_window, find_last_unchanged_at_beg_row)
3046 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3047 (trailing_whitespace_p, find_row_edges, display_line)
3048 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3049 (display_mode_element, store_mode_line_string)
3050 (pint2str, pint2hrstr, decode_mode_spec)
3051 (display_count_lines, display_string, draw_glyphs)
3052 (x_produce_glyphs, x_insert_glyphs)
3053 (rows_from_pos_range, mouse_face_from_buffer_pos)
3054 (fast_find_string_pos, mouse_face_from_string_pos)
3055 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3057 (safe_call, init_from_display_pos, handle_fontified_prop)
3058 (handle_single_display_spec, load_overlay_strings)
3059 (with_echo_area_buffer, setup_echo_area_for_printing)
3060 (display_echo_area, echo_area_display)
3061 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3062 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3063 (redisplay_window, dump_glyph_row, display_mode_line)
3064 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3065 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3067 (handle_single_display_spec, build_desired_tool_bar_string)
3068 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3069 (get_specified_cursor_type):
3070 Check that fixnums are in proper range for system types.
3071 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3072 (Flookup_image_map):
3073 Don't assume fixnums fit in int.
3074 (compare_overlay_entries):
3075 Avoid mishandling comparisons due to subtraction overflow.
3076 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3077 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3078 (handle_tool_bar_click):
3079 Use int, not unsigned, since we prefer signed and the signedness
3080 doesn't matter here.
3081 (get_next_display_element, next_element_from_display_vector):
3082 Use int, not EMACS_INT, when int is wide enough.
3083 (start_hourglass): Use duration_to_sec_usec to do proper
3084 overflow checking on durations.
3085 * xfaces.c (Fbitmap_spec_p):
3086 Check that fixnums are in proper range for system types.
3087 (compare_fonts_by_sort_order):
3088 Avoid mishandling comparisons due to subtraction overflow.
3089 (Fx_family_fonts, realize_basic_faces):
3090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3091 (Fx_family_fonts):
3092 Don't assume fixnum fits in int.
3093 Use SAFE_ALLOCA_LISP, not alloca.
3094 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3095 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3096 (face_at_buffer_position, face_for_overlay_string)
3097 (face_at_string_position):
3098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3099 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3100 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3101 (Fx_show_tip):
3102 Check that fixnums are in proper range for system types.
3103 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3104 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3106 (Fx_change_window_property): Don't assume fixnums fit in int.
3107 * xfont.c (xfont_chars_supported):
3108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3109 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3110 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3112 * xml.c (parse_region):
3113 * xrdb.c (magic_file_p):
3114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3115 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3116 (x_get_local_selection, x_reply_selection_request)
3117 (x_handle_selection_request, wait_for_property_change):
3118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3119 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3120 short is wide enough.
3121 (x_send_client_event): Don't assume fixnum fits in int.
3122 * xterm.c (x_x_to_emacs_modifiers):
3123 Don't assume EMACS_INT overflows nicely into int.
3124 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3125 may come from Lisp.
3126 (handle_one_xevent): NATNUMP can eval its arg twice.
3127 (x_connection_closed):
3128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3129 * xterm.h: Adjust decls to match defn changes elsewhere.
3130 (struct scroll_bar): Use struct vectorlike_header
3131 rather than rolling our own approximation.
3132 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3133
c6574eb5
GM
31342012-05-25 Glenn Morris <rgm@gnu.org>
3135
3136 * lisp.mk (lisp): Update for more files being compiled now.
3137
e8d32c7e
SM
31382012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3139
48def666
SM
3140 * lread.c: Remove `read_pure' which makes no difference.
3141 (read_pure): Remove var.
3142 (unreadpure): Remove function.
3143 (readevalloop): Don't call read_list with -1 flag.
3144 (read1, read_vector): Don't test read_pure any more.
3145 (read_list): Simplify.
3146
e8d32c7e
SM
3147 * fileio.c, character.h: Minor style tweaks.
3148
4b2addb7
DA
31492012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3150
3151 * window.h (clip_changed): Remove useless declaration.
3152
584461b2
JB
31532012-05-22 Juanma Barranquero <lekktu@gmail.com>
3154
3155 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3156 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3157
34374650
PE
31582012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 Remove src/m/*.
3161 This directory predates autoconf and is no longer needed nowadays.
3162 Move its few remaining bits of functionality to where they're needed.
3163 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3164 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3165 * m/template.h: Remove.
3166 * Makefile.in (M_FILE): Remove. All uses removed.
3167 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3168 * lisp.h (USE_LSB_TAG):
3169 * mem-limits.h (EXCEEDS_LISP_PTR):
3170 Use VAL_MAX, not VALBITS, in #if.
3171 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3172 (EMACS_UINT): Define unconditionally now.
3173 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3174 (BITS_PER_EMACS_INT): New constants, replacing
3175 what used to be in config.h, but not useful in #if.
3176 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3177 define them any more.
3178 (VAL_MAX): New macro.
3179 (VALMASK): Use it.
3180 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3181 BITS_PER_EMACS_INT, in #if.
3182 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3183 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3184 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3185 * s/ms-w32.h (DATA_START):
3186 Move here from removed file m/intel386.h.
3187 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3188 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3189
261cb4bb
PE
31902012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 Assume C89 or later.
3193 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3194 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3195 (xrealloc):
3196 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3197 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3198 * textprop.c, tparam.c (NULL): Remove.
3199 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3200 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3201 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3202 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3203 * xterm.c (input_signal_count): Assume volatile works.
3204
ff23cd9f
KB
32052012-05-21 Ken Brown <kbrown@cornell.edu>
3206
3207 * xgselect.c (xg_select): Fix first argument in call to 'select'
3208 (bug#11508).
3209
1b170bc6
KB
32102012-05-20 Ken Brown <kbrown@cornell.edu>
3211
3212 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3213 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3214
b2f4d39f
KB
32152012-05-19 Ken Brown <kbrown@cornell.edu>
3216
3217 * xfns.c (x_in_use): Remove `static' qualifier.
3218 * xterm.h (x_in_use): Declare.
3219 * xgselect.c: Include xterm.h.
3220 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3221 and `display_arg' (bug#9754).
3222
003fdae2
PE
32232012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3224
9232a6d9
PE
3225 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3226
003fdae2
PE
3227 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3228 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3229
784b56e2
EZ
32302012-05-18 Eli Zaretskii <eliz@gnu.org>
3231
3232 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3233
3234 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3235 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3236
3237 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3238 reference to image_cache->refcount.
3239 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3240
a0a79cde
JL
32412012-05-17 Juri Linkov <juri@jurta.org>
3242
3243 * search.c (Fword_search_regexp, Fword_search_backward)
3244 (Fword_search_forward, Fword_search_backward_lax)
3245 (Fword_search_forward_lax): Move functions to isearch.el
3246 (bug#10145, bug#11381).
3247
b0572523
PE
32482012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3249
3250 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3251
9660f5fc
SM
32522012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3253
3254 * lread.c (init_obarray): Declare Qt and Qnil as special.
3255
4374de83
GM
32562012-05-14 Glenn Morris <rgm@gnu.org>
3257
3258 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3259 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3260
dc44c39a
PE
32612012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3262
078c97cb
PE
3263 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3264
dc44c39a
PE
3265 * unexaix.c: Port to more-recent AIX compilers.
3266 (report_error, report_error_1, make_hdr, copy_sym)
3267 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3268 Make arguments const char *, not char *, to avoid violations of C
3269 standard and to fix some AIX warnings reported by Gilles Pion.
3270
e18afed7 32712012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3272
3273 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3274 already have overlays loaded.
3275 (handle_single_display_spec): Before returning without displaying
3276 fringe bitmap, synchronize the bidi iterator with the main display
3277 iterator, by calling iterate_out_of_display_property.
3278 (iterate_out_of_display_property): Detect buffer iteration by
3279 testing that it->string is a Lisp string.
3280 (get_next_display_element): When the current object is exhausted,
3281 and there's something on it->stack, call set_iterator_to_next to
3282 proceed with what's on the stack, instead of returning zero.
3283 (set_iterator_to_next): If called at the end of a Lisp string,
3284 proceed to consider_string_end without incrementing string
3285 position. Don't increment display vector index past the end of
3286 the display vector. (Bug#11417)
c8fb9dc6
EZ
3287 (pos_visible_p): Don't report a position visible when move_it_to
3288 stopped at the last line of window, which happens to be scanned
3289 backwards by the bidi iteration. (Bug#11464)
ac268e67 3290
e18afed7 32912012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3292
3293 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3294 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3295 are on a TTY, and thus unable to display on the fringes.
3296 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3297 so we need to signal to the caller that this is a "replacing"
3298 display spec. This fixes display when the spec is invalid or we
3299 are on a TTY.
3300
e18afed7 33012012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3302
3303 * unexaix.c (make_hdr): Fix typo in prototype.
3304 This bug broke the build on AIX. Problem reported by Gilles Pion.
3305
9d0a235a
MA
33062012-05-14 Michael Albinus <michael.albinus@gmx.de>
3307
3308 * keyboard.c (kbd_buffer_get_event): Read special events also in
3309 batch mode. (Bug#11415)
3310
9e6b06ed
GM
33112012-05-12 Glenn Morris <rgm@gnu.org>
3312
3313 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3314
c1a1d7a3
EZ
33152012-05-12 Eli Zaretskii <eliz@gnu.org>
3316
3317 * lisp.mk (lisp): Add newcomment.elc.
3318
3fe7cdc8
GM
33192012-05-12 Glenn Morris <rgm@gnu.org>
3320
3321 * Makefile.in (MKDIR_P): New, set by configure.
3322 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3323
53f7d2c0
PE
33242012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3325
3326 Remove unused function hourglass_started.
3327 * dispextern.h (hourglass_started):
3328 * w32fns.c (hourglass_started):
3329 * xdisp.c (hourglass_started): Remove.
3330
75aafb17
JB
33312012-05-10 Juanma Barranquero <lekktu@gmail.com>
3332
3333 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3334 Update dependencies.
3335
12959e8e
PE
33362012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3337
97107e2e
PE
3338 * xgselect.c (xg_select): Put maxfds+1 into a var.
3339 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3340
12959e8e
PE
3341 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3342
836d29b3
DA
33432012-05-10 Dave Abrahams <dave@boostpro.com>
3344
3345 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3346 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3347
5cb67954
MA
33482012-05-09 Michael Albinus <michael.albinus@gmx.de>
3349
3350 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3351 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3352 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3353 Initialize xd_registered_buses.
3354
3478ec45
PE
33552012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3356
b263a6b0
PE
3357 Untag more efficiently if USE_LSB_TAG.
3358 This is based on a proposal by YAMAMOTO Mitsuharu in
3359 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3360 For an admittedly artificial (nth 8000 longlist) benchmark on
3361 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3362 Emacs's overall text size by 1%.
3363 * lisp.h (XUNTAG): New macro.
3364 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3365 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3366 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3367 * eval.c (Fautoload):
3368 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3369 * frame.h (XFRAME): Use XUNTAG.
3370
3478ec45
PE
3371 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3372 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3373 Remove unportable assumptions about print widths of types like
3374 dbus_uint32_t.
3375 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3376 intptr_t when converting between pointer and integer, to avoid GCC
3377 warnings about wrong width.
3378
666b903b 33792012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3380
3381 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3382 stack for each reader_thread, instead of defaulting to 8MB
3383 determined by the linker. This avoids failures in creating
3384 subprocesses on Windows 7, see the discussion in this thread:
3385 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3386
b120cc17
JC
33872012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3388
3389 Fix up display of the *Minibuf-0* buffer in the mini window.
3390 * keyboard.c (read_char): Don't clear the echo area if there's no
3391 message to clear.
3392 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3393 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3394
9a4b36f8
MA
33952012-05-07 Michael Albinus <michael.albinus@gmx.de>
3396
3397 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3398 batch mode.
3399
e5f9458f
CY
34002012-05-06 Chong Yidong <cyd@gnu.org>
3401
3402 * lisp.mk (lisp): Update.
3403
eceeb5fc 34042012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3405
3406 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3407
71873e2b
SM
34082012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3409
3410 * data.c (PUT_ERROR): New macro.
3411 (syms_of_data): Use it. Add new error type `user-error'.
3412 * undo.c (user_error): New function.
3413 (Fprimitive_undo): Use it.
3414 * print.c (print_error_message): Adjust print style for `user-error'.
3415 * keyboard.c (user_error): New function.
3416 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3417
ab0fa4e4
PE
34182012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3419
3420 Do not limit current-time-string to years 1000..9999.
3421 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3422 (Fcurrent_time_string): Support any year that is supported by the
3423 underlying localtime representation. Don't use asctime, as it
3424 has undefined behavior for years outside the range -999..9999.
3425
7ed806a7
PE
34262012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3427
3428 Fix race conditions involving setenv, gmtime, localtime, asctime.
3429 Without this fix, interrupts could mess up code that uses these
3430 nonreentrant functions, since setting TZ invalidates existing
3431 tm_zone or tzname values, and since most of these functions return
3432 pointers to static storage.
3433 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3434 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3435 Grow the critical sections to include not just invoking
3436 localtime/gmtime, but also accessing these functions' results
3437 including their tm_zone values if any, and any related TZ setting.
3438 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3439 so that the struct tm is saved in the critical section.
3440 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3441 motivated by the fact that memory allocation needs to be outside
3442 the critical section.
3443
0c16dfed
DA
34442012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3445
3446 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3447 with RESET_INTERVAL.
3448
3449 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3450 Remove duplicated buffer name initialization.
3451
3f83ace8
JM
34522012-05-02 Jim Meyering <jim@meyering.net>
3453
3454 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3455
c7b8541e
JM
3456 * xfns.c (x_window): Use xstrdup (Bug#11375).
3457
90207a15 34582012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3459
3460 * xdisp.c (pos_visible_p): If already at a newline from the
3461 display string before the 'while' loop, don't walk back the glyphs
3462 from it3.glyph_row. Solves assertion violation when the display
3463 string begins with a newline (egg.el). (Bug#11367)
3464
b593d6a9
AH
34652012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3466
3467 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3468 Move to simple.el.
3469
4737362e
GM
34702012-05-01 Glenn Morris <rgm@gnu.org>
3471
99cf43f9
GM
3472 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3473 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3474 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3475 All were removed before 23.1.
3476
9311dcff
GM
3477 * dispnew.c: Remove HAVE_LIBNCURSES test;
3478 it is always true on relevant platforms.
3479
4d5c6349
GM
3480 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3481 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3482
4737362e
GM
3483 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3484
74dd3a6b
AS
34852012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3486
3487 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3488 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3489 Remove.
3490
13c379ee
PE
34912012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3492
3493 Do not avoid creating empty evaporating overlays (Bug#9642).
3494 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3495 That is, do not delete an evaporating overlay if it becomes
3496 empty after its bounds are adjusted to fit within its buffer.
3497 This fix caused other problems, and I'm reverting it until we get
3498 to the bottom of them.
3499
a8e7d6d7 35002012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3501
3502 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3503
a8e7d6d7 35042012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3505
3506 * xdisp.c (pos_visible_p): If the window start position is beyond
3507 ZV, start the display from buffer beginning. Prevents assertion
3508 violation in init_iterator when the minibuffer window is scrolled
3509 via the scroll bar.
3510
3511 * window.c (window_scroll_pixel_based): Likewise.
3512
a8e7d6d7 35132012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3514
3515 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3516
a8e7d6d7 35172012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3518
3519 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3520 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3521
a8e7d6d7 35222012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3523
b593d6a9
AH
3524 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3525 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3526
1c6900d9
EZ
35272012-04-26 Eli Zaretskii <eliz@gnu.org>
3528
4c3fa1d9
EZ
3529 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3530 display element, check also the underlying string or buffer
3531 character. (Bug#11341)
3532
1c6900d9
EZ
3533 * w32menu.c: Include w32heap.h.
3534 (add_menu_item): If the call to AppendMenuW (via
3535 unicode_append_menu) fails, disable Unicode menus only if we are
3536 running on Windows 9X/Me.
3537
42bf8205
AS
35382012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3539
3540 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3541 (xgetint): Add missing shift for LSB tags.
3542
b1bac16e
MR
35432012-04-24 Martin Rudalics <rudalics@gmx.at>
3544
3545 * keyboard.c (read_char): Don't wipe echo area for select window
3546 events: These might get delayed via `mouse-autoselect-window'
3547 (Bug#11304).
3548
d69621cc
JB
35492012-04-24 Juanma Barranquero <lekktu@gmail.com>
3550
3551 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3552 manipulation of :loaded-from data.
3553
02fd101b
JB
35542012-04-23 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3557 now a cons (bug#11311).
3558
888bec30
PE
35592012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3560
89a438bd
PE
3561 Do not create empty overlays with the evaporate property (Bug#9642).
3562 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3563 if it becomes empty after its bounds are adjusted to fit within
3564 its buffer. Without this fix, in a nonempty buffer (let ((o
3565 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3566 yields an empty overlay that has the evaporate property, which is
3567 not supposed to happen.
3568
1068fe4d
PE
3569 Fix minor GTK3 problems found by static checking.
3570 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3571 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3572 (struct _EmacsFixedClass, emacs_fixed_get_type):
3573 Move decls here from emacsgtkfixed.h, since they needn't be public.
3574 (emacs_fixed_get_type): Now static.
3575 (emacs_fixed_class_init): Omit unused local.
3576 (emacs_fixed_child_type): Remove; unused.
3577 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3578 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3579 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3580 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3581 (EMACS_FIXED_GET_CLASS): Remove; unused.
3582 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3583
888bec30
PE
3584 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3585 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3586
de85e130
PE
35872012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3588
d0baac98 3589 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3590 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3591 (__malloc_size_t, __malloc_ptrdiff_t):
3592 Remove. All uses removed, replaced by the definiens if needed,
3593 since we can assume C89 or better now.
3594 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3595 (protect_malloc_state, align, get_contiguous_space)
3596 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3597 (malloc_atfork_handler_child, malloc_enable_thread)
3598 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3599 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3600 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3601 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3602 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3603 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3604 Define using prototypes, not old style.
3605 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3606 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3607 (align): Don't assume that signed integer overflow wraps around.
3608 Omit unused local var.
3609 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3610 (_free_internal_nolock, memalign, mallochook, reallochook):
3611 Omit no-longer-needed casts.
3612 (valloc): Use getpagesize, not __getpagesize.
3613 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3614 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3615
de85e130
PE
3616 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3617
dcbf5805
MA
36182012-04-22 Michael Albinus <michael.albinus@gmx.de>
3619
3620 Move functions from C to Lisp. Make non-blocking method calls
3621 the default. Implement further D-Bus standard interfaces.
3622
3623 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3624 (QCdbus_request_name_allow_replacement)
3625 (QCdbus_request_name_replace_existing)
3626 (QCdbus_request_name_do_not_queue)
3627 (QCdbus_request_name_reply_primary_owner)
3628 (QCdbus_request_name_reply_in_queue)
3629 (QCdbus_request_name_reply_exists)
3630 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3631 (QCdbus_registered_serial, QCdbus_registered_method)
3632 (QCdbus_registered_signal): New Lisp objects.
3633 (XD_DEBUG_MESSAGE): Use sizeof.
3634 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3635 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3636 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3637 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3638 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3639 (xd_signature, xd_append_arg): Allow float for integer types.
3640 (xd_get_connection_references): New function.
b593d6a9
AH
3641 (xd_get_connection_address): Rename from xd_initialize.
3642 Return cached address.
dcbf5805
MA
3643 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3644 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3645 level.
3646 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3647 Return number of refcounts.
dcbf5805
MA
3648 (Fdbus_get_unique_name): Make stronger parameter check.
3649 (Fdbus_message_internal): New defun.
3650 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3651 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3652 (Fdbus_send_signal, Fdbus_register_service)
3653 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3654 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3655 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3656 (Vdbus_compiled_version, Vdbus_runtime_version)
3657 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3658 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3659 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3660 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3661 Adapt docstring.
dcbf5805 3662
52828e02
PE
36632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3664
da05bc4c
PE
3665 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3666 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3667 Do not assume ptrdiff_t is the same width as 'int'.
3668
52828e02
PE
3669 * alloc.c: Handle unusual debugging option combinations.
3670 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3671 since the two debugging options are incompatible.
3672 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3673 is defined.
3674 (mem_init, mem_insert, mem_insert_fixup):
3675 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3676 (NEED_MEM_INSERT): Remove; no longer needed.
3677
f01769f9
LL
36782012-04-22 Leo Liu <sdl.web@gmail.com>
3679
3680 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3681
5790543d
PE
36822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3683
3684 * sysdep.c [__FreeBSD__]: Minor cleanups.
3685 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3686 Use Emacs indenting style more consistently. Avoid some casts.
3687 Use 'double' consistently rather than mixing 'float' and 'double'.
3688
b91b7e4d
EW
36892012-04-21 Eduard Wiebe <usenet@pusto.de>
3690
b593d6a9
AH
3691 * sysdep.c (list_system_processes, system_process_attributes):
3692 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3693
6114eb15
AS
36942012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3695
3696 * lisp.mk (lisp): Update.
3697
2f38dff7
PE
36982012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3699
3700 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3701 It is never used otherwise.
3702
4ae29f89
SM
37032012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3704
3705 * print.c (print_preprocess): Only check print_depth if print-circle
3706 is nil.
3707 (print_object): Check for cycles even when print-circle is nil and
3708 print-gensym is t, but only check print_depth if print-circle is nil.
3709
f30d612a
CY
37102012-04-20 Chong Yidong <cyd@gnu.org>
3711
3712 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3713 set the status to "failed" and ensure that sentinel is run.
3714
c07a4c0b 37152012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3716
3717 * process.c (Fset_process_inherit_coding_system_flag)
3718 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3719 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3720
c07a4c0b 37212012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3722
3723 * xdisp.c (string_buffer_position_lim): Limit starting position to
3724 BEGV.
3725 (set_cursor_from_row): If called for a mode-line or header-line
3726 row, return zero immediately.
3727 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3728 farther than the first row after the header line, if any.
3729 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3730 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3731
c07a4c0b 37322012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3733
4ae29f89
SM
3734 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3735 (bug#11238).
ad3a2b41 3736
c07a4c0b 37372012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 37382012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3739
3740 configure: new option --enable-gcc-warnings (Bug#11207)
3741 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3742 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3743 (ALL_CFLAGS): Use new macros rather than old.
3744 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3745 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3746 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3747 -Wunused-result, -Wunused-variable. This should go away once
3748 the Emacs and Gnulib regex code is merged.
3749 (xmalloc, xrealloc): Now static.
3750
aba027e8
PE
37512012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3752
3753 * dired.c (Fsystem_groups): Remove unused local.
3754
e5a36063
GM
37552012-04-17 Glenn Morris <rgm@gnu.org>
3756
3757 * dired.c (Fsystem_users): Doc fix.
3758
316411f0
DA
37592012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3760
3761 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3762 (syms_of_dired): Add them.
3763
9426aba4
PE
37642012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3765
b62a57be
PE
3766 Fix minor alloc.c problems found by static checking.
3767 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3768 New extern decls, to avoid calling undeclared functions.
3769 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3770 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3771 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3772 (NEED_MEM_INSERT): New macro.
3773 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3774 Remove one incorrect comment and fix another.
b62a57be 3775
3539f31f
PE
3776 Fix minor ralloc.c problems found by static checking.
3777 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3778 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3779 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3780 (r_alloc_sbrk): Now static.
3781
a041960a
PE
3782 Improve ralloc.c interface checking.
3783 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3784 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3785 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3786 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3787 [REL_ALLOC]: ... to here, to check interface.
3788 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3789 Remove decls. This fixes an "It stinks!".
3790
9426aba4
PE
3791 * alloc.c (which_symbols): Fix alignment issue / type clash.
3792
d55c12ed
AS
37932012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3794
3795 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3796 (struct Lisp_Misc_Any): Likewise.
3797 (struct Lisp_Free): Likewise.
3798 * alloc.c (union aligned_Lisp_Symbol): Define.
3799 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3800 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3801 (union aligned_Lisp_Misc): Define.
3802 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3803 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3804 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3805
b948ce8b
PE
38062012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3809 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3810 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3811 * s/netbsd.h, s/sol2-6.h:
3812 Remove definition of GC_MARK_STACK, since the default now works.
3813 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3814 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3815 no longer the default.
3816 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3817
35dc09a1 38182012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3819
35dc09a1
GM
3820 * lread.c (lisp_file_lexically_bound_p):
3821 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3822
35dc09a1
GM
38232012-04-14 Eli Zaretskii <eliz@gnu.org>
3824
3825 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3826 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3827
38282012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3829
3830 * nsterm.m (constrainFrameRect): Always constrain when there is only
3831 one screen (Bug#10962).
3832
bcd86815
KB
38332012-04-13 Ken Brown <kbrown@cornell.edu>
3834
3835 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3836
c25df26e
RT
38372012-04-13 Reuben Thomas <rrt@sc3d.org>
3838
3839 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3840
0fc59f1e
DC
38412012-04-11 Daniel Colascione <dancol@dancol.org>
3842
3843 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3844 against is gone. It's better to use vfork now so that when Cygwin
3845 gains a new, working vfork, we use it automatically (bug#10398).
3846
de8c03dc
SM
38472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3848
3849 * window.c (save_window_save): Obey window-point-insertion-type.
3850
2f097256
GM
38512012-04-11 Glenn Morris <rgm@gnu.org>
3852
3853 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3854
453b951e
SM
38552012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3856
3857 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3858
75f1671a 38592012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3860
3861 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3862 (force_quit_count): New var.
3863 (handle_interrupt): Use it.
3864
2a8ce227
JB
38652012-04-10 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * w32.c (w32_delayed_load): Record the full path of the library
3868 being loaded (bug#10424).
3869
935396c0
GM
38702012-04-09 Glenn Morris <rgm@gnu.org>
3871
05920a43
GM
3872 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3873 not just in the obarray, before snarfing them. (Bug#11036)
3874
935396c0
GM
3875 * Makefile.in ($(leimdir)/leim-list.el):
3876 Pass EMACS rather than BUILT_EMACS.
3877
a18ecafa
TZ
38782012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3879
3880 * process.c (make_process):
3881 * process.h: Add integer `gnutls_handshakes_tried' member to
3882 process struct.
3883
6bbef4e5
JC
3884 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3885 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3886
3887 * gnutls.c (gnutls_log_function2i): Convenience log function.
3888 (emacs_gnutls_read): Use new log functions,
3889 `gnutls_handshakes_tried' process member, and
3890 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3891 attempts per process (connection).
3892
b4d3bc10
CY
38932012-04-09 Chong Yidong <cyd@gnu.org>
3894
3895 * eval.c (Fuser_variable_p, user_variable_p_eh)
3896 (lisp_indirect_variable): Functions deleted.
3897 (Fdefvar): Caller changed.
3898
3899 * callint.c (Finteractive, Fcall_interactively):
3900 * minibuf.c (Fread_variable): Callers changed.
3901
70f4d973
EZ
39022012-04-09 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (set_cursor_from_row): If the display string appears in
3905 the buffer at position that is closer to point than the position
3906 after the display string, display the cursor on the first glyph of
3907 the display string. Fixes cursor display when a 'display' text
3908 property immediately follows invisible text. (Bug#11094)
3909
cb3c2e3e
PE
39102012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 composite.c: use 'double' consistently
3913 * composite.c (get_composition_id): Use 'double' consistently
3914 instead of converting 'float' to 'double' and vice versa; this is
3915 easier to understand and avoids a GCC warning.
3916
fd06db5d
GM
39172012-04-09 Glenn Morris <rgm@gnu.org>
3918
50fe702a
GM
3919 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3920 preparation for dumping it with emacs. (Bug#4789)
3921 (leimdir): New variable.
3922 ($(leimdir)/leim-list.el): New rule.
3923 (emacs$(EXEEXT)): Depend on leim-list.el.
3924
fd06db5d
GM
3925 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3926 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3927 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3928
55c131ee
AS
39292012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3930
3931 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3932 proper alignment.
3933
9209588f
JB
39342012-04-07 Juanma Barranquero <lekktu@gmail.com>
3935
3936 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3937 Remove unused local variable.
3938
e3fb2efb
PE
39392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3940
3941 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3942 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3943 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3944 objects, as mark_maybe_pointer will catch them otherwise.
3945 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3946 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3947
b5385551
PE
39482012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 Fix typo that broke non-Windows builds.
3951 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3952
9078ead6
EZ
39532012-04-07 Eli Zaretskii <eliz@gnu.org>
3954
3955 Support building on MS-Windows with libxml2.
3956
3957 * makefile.w32-in (OBJ2): Add xml.$(O).
3958 (GLOBAL_SOURCES): Add xml.c.
3959 ($(BLD)/xml.$(O)): New dependency list.
3960
3961 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3962 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3963 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3964 [!WINDOWSNT]: New macros.
3965 (init_libxml2_functions, libxml2_loaded_p): New functions.
3966 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3967 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3968 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3969 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3970 linked in).
6bbef4e5
JC
3971 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3972 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3973 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3974
3975 * emacs.c: Don't include libxml/parser.h.
3976 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3977 xmlCleanupParser directly.
3978
3979 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3980
3811fdf3
EZ
39812012-04-07 Eli Zaretskii <eliz@gnu.org>
3982
3983 * indent.c (Fvertical_motion): If there is a display string at
3984 point, use it.vpos to compute how many lines to backtrack after
3985 move_it_to point. (Bug#11133)
3986
2f8e16b2
EZ
39872012-04-06 Eli Zaretskii <eliz@gnu.org>
3988
3989 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3990 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3991 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3992 macros related to unification of CJK characters. For the details,
3993 see the discussion following the message here:
3994 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3995
3d439cd1
CY
39962012-04-04 Chong Yidong <cyd@gnu.org>
3997
3998 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3999
8bc53d00
EZ
40002012-04-01 Eli Zaretskii <eliz@gnu.org>
4001
4002 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4003 instead of alloca. (Bug#11138)
4004
3b0512a3
AS
40052012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4006
4007 * w32menu.c (is_simple_dialog): Properly check lisp types.
4008 (Bug#11141)
4009
8427ddd2
EZ
40102012-03-31 Eli Zaretskii <eliz@gnu.org>
4011
979022ef
EZ
4012 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4013 position we get to after a call to move_it_to fails the
4014 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4015 only if we wind up in a string from display property. (Bug#11063)
4016
a6b1c7cc
EZ
4017 * window.c (Fdelete_other_windows_internal): Invalidate the row
4018 and column information about mouse highlight, so that redisplay
4019 restores it after reallocating the glyph matrices. (Bug#7464)
4020
8427ddd2
EZ
4021 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4022 string comes from a `display' text property, use the buffer
4023 position of that property as if we actually saw that position in
4024 the row's glyphs.
697ba24b
EZ
4025 (move_it_by_lines): Remove the assertion that
4026 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4027 violated when there's a before-string at the beginning of a line.
4028 (Bug#11063)
8427ddd2 4029
65a0a738
EZ
40302012-03-30 Eli Zaretskii <eliz@gnu.org>
4031
4032 * xdisp.c (append_space_for_newline): If the default face was
4033 remapped, use the remapped face for the appended newline.
4034 (extend_face_to_end_of_line): Use the remapped default face for
4035 extending the face to the end of the line.
4036 (display_line): Call extend_face_to_end_of_line when the default
4037 face was remapped. (Bug#11068)
4038
581355cc
EZ
40392012-03-29 Eli Zaretskii <eliz@gnu.org>
4040
4041 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4042
e8fc049f
SM
40432012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4044
4045 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4046
4fb9a543
GM
40472012-03-27 Glenn Morris <rgm@gnu.org>
4048
4049 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4050 Doc fixes.
4051
679910f1
KH
40522012-03-26 Kenichi Handa <handa@m17n.org>
4053
4054 * dispextern.h (struct glyph): Fix previous change. Change the
4055 bit length of glyphless.ch to 25 (Bug#11082).
4056
90d49b7f
CY
40572012-03-26 Chong Yidong <cyd@gnu.org>
4058
4059 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4060 (command_loop_1): Use it; inhibit selection update for
4061 handle-select-window too (Bug#8996).
4062
f514f6f0
FP
40632012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4064
e8fc049f 4065 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4066
bf43fa51
KH
40672012-03-25 Kenichi Handa <handa@m17n.org>
4068
4069 * dispextern.h (struct glyph): Change the bit length of
4070 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4071
8a0c01dd
EZ
40722012-03-24 Eli Zaretskii <eliz@gnu.org>
4073
4074 * s/ms-w32.h (tzname): Include time.h before redirecting to
4075 _tzname. Fixes the MSVC build. (Bug#9960)
4076
7d1c3a76
AS
40772012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4078
8ed79523
AS
4079 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4080 characters.
4081
7d1c3a76
AS
4082 * xterm.c (XTread_socket): Only modify handling_signal if
4083 !SYNC_INPUT. (Bug#11080)
4084
e99a9b8b
EZ
40852012-03-23 Eli Zaretskii <eliz@gnu.org>
4086
4087 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4088 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4089 when fetching a multibyte character consumes more bytes than
4090 CHAR_BYTES returns, due to unification of CJK characters in
4091 string_char. (Bug#11073)
4092
5063c0e1
TN
40932012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4094
4095 * process.c (wait_reading_process_output): Handle pty disconnect
4096 by refraining from sending oneself a SIGCHLD (bug#10933).
4097
9f851fbd
CY
40982012-03-22 Chong Yidong <cyd@gnu.org>
4099
4100 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4101
5063c0e1 4102 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4103 Mark string as coming from a prefix property.
4104 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4105 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4106
fb5b8aca
CY
41072012-03-21 Chong Yidong <cyd@gnu.org>
4108
4109 * xfaces.c (Vface_remapping_alist): Doc fix.
4110
62356a1b
EZ
41112012-03-20 Eli Zaretskii <eliz@gnu.org>
4112
4113 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4114 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4115 Doc fixes.
62356a1b 4116
025de85b
CY
41172012-03-20 Chong Yidong <cyd@gnu.org>
4118
4119 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4120 to reflect default non-nil value of redisplay-dont-pause.
4121
4827f94e
KH
41222012-03-19 Kenichi Handa <handa@m17n.org>
4123
4124 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4125 it fit in a valid range (Bug#11003).
4126
e50a24a2
EZ
41272012-03-18 Eli Zaretskii <eliz@gnu.org>
4128
4129 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4130 that is not from display property, accept the row as a "cursor
4131 row" if one of the string's character has a non-nil `cursor'
4132 property. Fixes cursor positioning when there are newlines in
4133 overlay strings, e.g. in icomplete.el. (Bug#11035)
4134
9af5ed87
PE
41352012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4136
4137 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4138
d1f55f16
CY
41392012-03-12 Chong Yidong <cyd@gnu.org>
4140
4141 * eval.c (inhibit_lisp_code): Rename from
4142 inhibit_window_configuration_change_hook; move from window.c.
4143
4144 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4145 * window.c (run_window_configuration_change_hook)
4146 (syms_of_window): Callers changed.
4147
66c5eebd
CY
41482012-03-11 Chong Yidong <cyd@gnu.org>
4149
413df973
CY
4150 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4151
66c5eebd
CY
4152 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4153
1de11f56
CY
41542012-03-10 Chong Yidong <cyd@gnu.org>
4155
4156 * frame.c (other_visible_frames): Don't assume the selected frame
4157 is visible (Bug#10955).
4158
cae07000
SM
41592012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4160
4161 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4162
89c94350
JD
41632012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4164
4165 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4166 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4167 zero (Bug#10954).
4168
999dd333
GM
41692012-03-03 Glenn Morris <rgm@gnu.org>
4170
01a6dcc8 4171 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4172
de0100f2
EZ
41732012-03-02 Eli Zaretskii <eliz@gnu.org>
4174
4175 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4176 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4177 (redisplay_window, next_element_from_string): Fix typos in
4178 comments.
3e441275
EZ
4179 (redisplay_window): Pass to move_it_vertically the margin in
4180 pixels, not in screen lines.
de0100f2 4181
96a72ee9
GM
41822012-03-02 Glenn Morris <rgm@gnu.org>
4183
4184 * buffer.c (buffer-list-update-hook): Doc fix.
4185
312508d7
EZ
41862012-02-29 Eli Zaretskii <eliz@gnu.org>
4187
4188 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4189 push_it before setting up the iterator for the first overlay
4190 string, even if we have an empty string loaded.
4191 (next_overlay_string): If there's an empty string on the iterator
4192 stack, pop the stack. (Bug#10903)
4193
27f3c637
PE
41942012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4197 Suggested by Stefan Monnier in
4198 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4199 * alloc.c (widen_to_Lisp_Object): New static function.
4200 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4201 and widening them to Lisp_Objects. This would work even if
4202 USE_LSB_TAG is defined and wide integers are used, which might
4203 happen in a future version of Emacs.
4204
3c9dfce6
CY
42052012-02-25 Chong Yidong <cyd@gnu.org>
4206
fa74b241
CY
4207 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4208 Doc fix.
4209
3c9dfce6
CY
4210 * xselect.c (Fx_selection_exists_p): Doc fix.
4211 (x_clipboard_manager_save_all): Print an informative message
4212 before saving to clipboard manager.
4213
9486df08
CY
42142012-02-24 Chong Yidong <cyd@gnu.org>
4215
4216 * keyboard.c (process_special_events): Handle all X selection
4217 requests in kbd_buffer, not just the next one (Bug#8869).
4218
f01d3321
CY
42192012-02-23 Chong Yidong <cyd@gnu.org>
4220
4221 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4222 call when setting menu-bar-lines and tool-bar-lines parameters.
4223 (unwind_create_frame_1): New helper function.
4224
4225 * window.c (inhibit_window_configuration_change_hook): New var.
4226 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4227 (syms_of_window): Initialize it.
f01d3321 4228
86b847b6
CY
42292012-02-22 Chong Yidong <cyd@gnu.org>
4230
4231 * xterm.c (x_draw_image_relief): Add missing type check for
4232 Vtool_bar_button_margin (Bug#10743).
4233
a59225b1
CY
42342012-02-21 Chong Yidong <cyd@gnu.org>
4235
4236 * fileio.c (Vfile_name_handler_alist): Doc fix.
4237
4238 * buffer.c (Fget_file_buffer): Protect against invalid file
4239 handler return value.
4240
310f5bd4
PE
42412012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4242
cb3a28cc
PE
4243 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4244 when computing $valmask.
4245
310f5bd4
PE
4246 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4247 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4248 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4249 It's useless in that case, and it can cause problems on hosts
4250 that allocate halves of EMACS_INT values separately.
4251 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4252 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4253 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4254 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4255 it avoids undefined behavior on hosts where shifting right by more
4256 than the word width has undefined behavior.
4257
2375c96a
CY
42582012-02-19 Chong Yidong <cyd@gnu.org>
4259
4260 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4261 (Funhandled_file_name_directory, Ffile_name_as_directory)
4262 (Fdirectory_file_name, Fexpand_file_name)
4263 (Fsubstitute_in_file_name): Protect against invalid file handler
4264 return values (Bug#10845).
4265
3eb49e71
EZ
42662012-02-18 Eli Zaretskii <eliz@gnu.org>
4267
4268 * .gdbinit (pitx): Fix incorrect references to fields of the
4269 iterator stack.
4270
7b926f3f
CY
42712012-02-17 Chong Yidong <cyd@gnu.org>
4272
4273 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4274
11273115
PE
42752012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4276
4277 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4278 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4279
c3a70e2b
CY
42802012-02-15 Chong Yidong <cyd@gnu.org>
4281
4282 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4283 marked as special. Also, starting docstrings with * is obsolete.
4284
0ca43699
AS
42852012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4286
4287 * gnutls.c (emacs_gnutls_write): Fix last change.
4288
2e8f3c56
LI
42892012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4290
4291 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4292 send_process.
4293
af70074f
SM
42942012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4295
4296 * keymap.c (Fsingle_key_description): Handle char ranges.
4297
95986d52
CY
42982012-02-12 Chong Yidong <cyd@gnu.org>
4299
afd83bd1
CY
4300 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4301 as that creates a dangerous corner case.
4302
95986d52
CY
4303 * window.c (Fdelete_window_internal): Invalidate the mouse
4304 highlight (Bug#9904).
4305
bd7da63e
GM
43062012-02-12 Glenn Morris <rgm@gnu.org>
4307
4308 * xselect.c (Fx_own_selection_internal)
4309 (Fx_get_selection_internal, Fx_disown_selection_internal)
4310 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4311 * nsselect.m (Fx_own_selection_internal)
4312 (Fx_disown_selection_internal, Fx_selection_exists_p)
4313 (Fx_selection_owner_p, Fx_get_selection_internal):
4314 Sync docs and argument specs with the xselect.c versions.
4315
77abcbc2
LI
43162012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4317
4318 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4319
90b671e2
EZ
43202012-02-11 Eli Zaretskii <eliz@gnu.org>
4321
1c0ca0b7
EZ
4322 * w32select.c (Fx_selection_exists_p): Sync doc string and
4323 argument list with xselect.c. (Bug#10783)
4324
4325 * w16select.c (Fx_selection_exists_p): Sync doc string and
4326 argument list with xselect.c. (Bug#10783)
90b671e2 4327
49241268
GM
43282012-02-10 Glenn Morris <rgm@gnu.org>
4329
4330 * fns.c (Fsecure_hash): Doc fix.
4331
f998bbe7 43322012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4333
4334 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4335
0992bd9c
CY
43362012-02-07 Chong Yidong <cyd@gnu.org>
4337
4338 * buffer.c (Fbuffer_local_variables)
4339 (buffer_lisp_local_variables): Handle unbound vars correctly;
4340 don't let Qunbound leak into Lisp.
4341
af008560
GM
43422012-02-07 Glenn Morris <rgm@gnu.org>
4343
dd605cc4
GM
4344 * image.c (Fimagemagick_types): Doc fix.
4345
af008560
GM
4346 * image.c (imagemagick-render-type): Change it from a lisp object
4347 to an integer. Move the doc here from the lisp manual.
4348 Treat all values not equal to 0 the same.
4349
1449fa1d
CY
43502012-02-06 Chong Yidong <cyd@gnu.org>
4351
4352 * doc.c (store_function_docstring): Avoid applying docstring of
4353 alias to base function (Bug#2603).
4354
3723ec07
AS
43552012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4356
4357 * .gdbinit (pp1, pv1): Remove redundant defines.
4358 (pr): Use pp.
4359
79c1cc1e
CY
43602012-02-04 Chong Yidong <cyd@gnu.org>
4361
4362 * nsterm.m: Declare a global (Bug#10694).
4363
d7f29f8e
EZ
43642012-02-04 Eli Zaretskii <eliz@gnu.org>
4365
cae07000
SM
4366 * w32.c (get_emacs_configuration_options):
4367 Include --enable-checking, if specified, in the return value.
d7f29f8e 4368
3b95a6f9
MR
43692012-02-04 Martin Rudalics <rudalics@gmx.at>
4370
4371 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4372 after rounding frame sizes. (Bug#9723)
4373
d6fa96a6
EZ
43742012-02-04 Eli Zaretskii <eliz@gnu.org>
4375
4376 * keyboard.c (adjust_point_for_property): Don't position point
4377 before BEGV. (Bug#10696)
4378
df0b2940
PE
43792012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4380
4381 Handle overflow when computing char display width (Bug#9496).
4382 * character.c (char_width): Return EMACS_INT, not int.
4383 (char_width, c_string_width): Check for overflow when
4384 computing the width; this is possible now that individual
4385 characters can have unbounded width. Problem introduced
4386 by merge from Emacs 23 on 2012-01-19.
4387
6bee44d6
MA
43882012-02-02 Michael Albinus <michael.albinus@gmx.de>
4389
4390 * dbusbind.c (Fdbus_register_method): Mention the return value
4391 :ignore in the docstring.
4392
44f92739
GM
43932012-02-02 Glenn Morris <rgm@gnu.org>
4394
1b9f60cc
GM
4395 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4396
44f92739
GM
4397 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4398 Unconditionally set to t. (Bug#10673)
4399 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4400 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4401 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4402
c5d3843c
KH
44032012-02-02 Kenichi Handa <handa@m17n.org>
4404
4405 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4406 0, do not call append_composite_glyph.
4407
159462d4 44082012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4409
4410 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4411 NULL (Bug#6988).
4412 (x_produce_glyphs): If the component of a composition is a null
4413 string, set it->pixel_width to 1 to avoid zero-width glyph.
4414
78cef877
EZ
44152012-02-01 Eli Zaretskii <eliz@gnu.org>
4416
4417 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4418 first 2 arguments are identical. This makes inserting large
4419 output from a subprocess an order of magnitude faster on
4420 MS-Windows, where all sbrk'ed memory is always contiguous.
4421
97897668
GM
44222012-01-31 Glenn Morris <rgm@gnu.org>
4423
4424 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4425 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4426 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4427
31fd3586
GM
44282012-01-29 Glenn Morris <rgm@gnu.org>
4429
4430 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4431
0e24a8b2
CY
44322012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4433
4434 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4435
cc0adcb0
CY
44362012-01-28 Chong Yidong <cyd@gnu.org>
4437
4438 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4439
acc28cb9
CY
44402012-01-26 Chong Yidong <cyd@gnu.org>
4441
9c69cfb7
CY
4442 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4443
acc28cb9
CY
4444 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4445 repeat counts (Bug#10507).
4446
48da7392
GM
44472012-01-26 Glenn Morris <rgm@gnu.org>
4448
4449 * lread.c (syms_of_lread): Doc fix.
4450
14af5f7f
CY
44512012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4452
4453 * coding.c (encode_designation_at_bol): Change return value to
4454 EMACS_INT.
4455
0b21c100
CY
44562012-01-25 Chong Yidong <cyd@gnu.org>
4457
4458 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4459
3c2907f7
CY
44602012-01-21 Chong Yidong <cyd@gnu.org>
4461
4462 * floatfns.c (Fcopysign): Make the second argument non-optional,
4463 since nil is not allowed anyway.
4464
959ad23f
AS
44652012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4466
4467 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4468 (send_process): Likewise.
4469
34a02f46
MR
44702012-01-19 Martin Rudalics <rudalics@gmx.at>
4471
4472 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4473 (Vwindow_persistent_parameters): Do not use Qstate.
4474 Rewrite doc-strings.
34a02f46 4475
1259009a 44762012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4477
4478 * character.c (char_width): New function.
70d4fdf6
GM
4479 (Fchar_width, c_string_width, lisp_string_width):
4480 Use char_width (Bug#9496).
25ed9e61 4481
6a6ee00d
MR
44822012-01-16 Martin Rudalics <rudalics@gmx.at>
4483
4484 * window.c (Vwindow_persistent_parameters): New variable.
4485 (Fset_window_configuration, save_window_save): Handle persistent
4486 window parameters.
4487
c85efaf7
EZ
44882012-01-14 Eli Zaretskii <eliz@gnu.org>
4489
4490 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4491 thrashing the stack of the thread. (Bug#9087)
4492
5944709e
PE
44932012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4494
4495 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4496
e71f5d99
EZ
44972012-01-11 Eli Zaretskii <eliz@gnu.org>
4498
4499 * xdisp.c (rows_from_pos_range): Handle the case where the
4500 highlight ends on a newline. (Bug#10464)
4501 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4502 he end column for display of highlight that ends on a newline
4503 before a R2L line.
4504
ce316182
GM
45052012-01-11 Glenn Morris <rgm@gnu.org>
4506
4507 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4508 from load-path also when installation-directory is nil. (Bug#10208)
4509
5b43da69
GM
45102012-01-10 Glenn Morris <rgm@gnu.org>
4511
74cc8ff9
GM
4512 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4513
7d8d6e4e
GM
4514 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4515 Update template values to be closer to their typical values these days.
5b43da69 4516
a0db8d43
EZ
45172012-01-09 Eli Zaretskii <eliz@gnu.org>
4518
4519 * xdisp.c (rows_from_pos_range): Accept additional argument
4520 DISP_STRING, and accept any glyph in a row whose object is that
4521 string as eligible for mouse highlight. Fixes mouse highlight of
4522 display strings from overlays. (Bug#10464)
4523
9a0115ab 45242012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4525
b9110d6a 4526 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4527 * fileio.c (auto_saving_dir_umask): New static var.
4528 (Fmake_directory_internal): Use it.
4529 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4530 creating the directory. The old code temporarily assigns
4531 too-generous permissions to the directory.
4532 (do_auto_save_eh): Clear it.
b9110d6a 4533 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4534 that the var is always cleared.
4535
6c1bd3f3
EZ
45362012-01-07 Eli Zaretskii <eliz@gnu.org>
4537
4538 * search.c (scan_buffer): Pass character positions to
4539 know_region_cache, not byte positions. (Bug#6540)
4540
069d2b50
L
45412012-01-07 LynX <_LynX@bk.ru> (tiny change)
4542
4543 * w32.c (sys_rename): Report EXDEV when rename of a directory
4544 fails because the target is on another logical disk. (Bug#10284)
4545
75bf0d33
DB
45462012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4547
4548 * xterm.c (x_embed_request_focus): New function.
4549
4550 * xterm.h: Add prototype.
4551
4552 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4553
1c6e5a32
GM
45542012-01-05 Glenn Morris <rgm@gnu.org>
4555
4556 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4557
651e947e
EZ
45582012-01-01 Eli Zaretskii <eliz@gnu.org>
4559
4560 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4561 Load gnutls_transport_set_lowat only if GnuTLS version is below
4562 2.11.1.
4563 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4564 GnuTLS versions below 2.11.1.
4565
3778cdd8
AL
45662011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4567
4568 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4569 to the doc string advising against its use for altering the way
4570 windows are scrolled.
4571
0e5317f7
KH
45722011-12-28 Kenichi Handa <handa@m17n.org>
4573
4574 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4575 coding-system ASCII compatible only when it does not produce BOM
4576 on encoding (Bug#10383).
4577
93d5ca1f
JD
45782011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4579
4580 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4581 can scroll.
4582 (create_and_show_popup_menu): Always use menu_position_func for
4583 Gtk3 (Bug#10361).
4584
ca22b785
AS
45852011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4586
4587 * callint.c (Fcall_interactively): Don't truncate prompt string.
4588
d048e1e6
EZ
45892011-12-23 Eli Zaretskii <eliz@gnu.org>
4590
4591 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4592 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4593 resumed from there (after widening). (Bug#10360)
d048e1e6 4594
5ccaba1f
JD
45952011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4596
4597 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4598
204ee57f
JD
45992011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4600
b81d40f0
JB
4601 * nsterm.m (x_free_frame_resources):
4602 Release f->output_data.ns->miniimage.
204ee57f
JD
4603 (ns_index_color): Fix indentation. Do not retain
4604 color_table->colors[i].
4605
4606 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4607 before returning.
4608
4609 * nsfns.m (x_set_background_color): Assign return value from
4610 ns_index_color to face-background instead of NSColor*.
4611 (ns_implicitly_set_icon_type): Fix indentation.
4612 Change assignment in for loop to comparison.
4613
4614 * emacs.c (ns_pool): New variable.
4615 (main): Assign ns_pool.
4616 (Fkill_emacs): Call ns_release_autorelease_pool.
4617
4618 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4619 autorelease fdesc, release fdAttrs and tdict.
4620 (ns_get_covering_families): Release charset.
4621 (ns_findfonts): Release NSFontDescriptor created with new.
4622 (ns_uni_to_glyphs): Fix indentation.
4623 (setString): Release attrStr before assigning new value.
4624
c803b2b7
JD
46252011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4626
678f4426
JD
4627 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4628 and NS_IMPL_COCOA.
4629 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4630 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4631
cd394be1 46322011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4633
5fecd5fc
JD
4634 * nsterm.m (ns_term_init): Subscribe for notifications
4635 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4636 to method trackingNotification in EmacsMenu.
4637
4638 * nsmenu.m (trackingMenu): New variable.
3771cb17 4639 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4640 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4641 from Aquamacs (Bug#7030).
678f4426
JD
4642
46432011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4644
c803b2b7
JD
4645 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4646 (symbol_to_nsstring): Fix indentation.
4647 (ns_symbol_to_pb): New function.
cae07000
SM
4648 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4649 (Fns_rotate_cut_buffers_internal): Remove.
4650 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4651 Fns_store_cut_buffer_internal.
4652 (ns_get_foreign_selection, Fx_own_selection_internal)
4653 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4654 (Fns_get_selection_internal, Fns_store_selection_internal):
4655 Use ns_symbol_to_pb and check if return value is nil.
4656 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4657 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4658 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4659 renamed to Sns_store_selection_internal.
4660 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4661 and remove this function.
4662 (ns_handle_selection_clear): Remove, never used.
4663 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4664 here.
4665
e1b01a3a
KB
46662011-12-17 Ken Brown <kbrown@cornell.edu>
4667
4668 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4669 GID is unknown (Bug#10257).
4670
2adb6e85
PE
46712011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4672
4673 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4674 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4675 which caused a build failure on GNU/Linux IA-64. This problem was
4676 introduced by my 2011-10-07 patch.
4677
d1d7b339
JL
46782011-12-15 Juri Linkov <juri@jurta.org>
4679
4680 * image.c (imagemagick_error): New function. (Bug#10112)
4681 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4682 Use `imagemagick_error' where ImageMagick functions return
4683 `MagickFalse'.
4684 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4685 proper order.
4686
100d5755
KH
46872011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4688
4689 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4690 fill background (Bug#8992).
4691
454592a6
MR
46922011-12-13 Martin Rudalics <rudalics@gmx.at>
4693
4694 * window.c (Vwindow_combination_resize)
4695 (Vwindow_combination_limit): Use t instead of non-nil in
4696 doc-strings.
61d4b438
MR
4697 (Vrecenter_redisplay): Add first sentence of doc-string on
4698 separate line.
53524d93 4699 (Frecenter): Fix doc-string typo.
454592a6 4700
3633e3aa
KH
47012011-12-11 Kenichi Handa <handa@m17n.org>
4702
4703 * coding.c (Funencodable_char_position): Pay attention to the
4704 buffer text relocation (Bug#9389).
4705
7b9d523a 47062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4707
7b9d523a
JD
4708 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4709 gtk_init (Bug#10100).
4710
b73189c6
EZ
47112011-12-10 Eli Zaretskii <eliz@gnu.org>
4712
4713 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4714 IT->string is nil. (Bug#10263)
4715
f7dfe5d6
JD
47162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4717
83faebb4
JD
4718 * nsterm.h (x_free_frame_resources): Declare.
4719
f7dfe5d6
JD
4720 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4721 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4722
4723 * nsterm.h (ns_get_defaults_value): Declare.
4724
4725 * nsterm.m (ns_default): Call ns_get_defaults_value.
4726
7cd4e72c
EZ
47272011-12-09 Eli Zaretskii <eliz@gnu.org>
4728
4729 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4730 (Bug#10170)
4731
b34d7317
YM
47322011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4733
4734 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4735 that where the value of an _OBJC_* symbol points to is in the .bss
4736 section (Bug#10240).
4737
76470ad1
KH
47382011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4739
4740 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4741 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4742
745fff94
KH
47432011-12-08 Kenichi Handa <handa@m17n.org>
4744
4745 * ftfont.c (get_adstyle_property): Fix previous change
4746 (Bug#10233).
4747
6e44397c
JB
47482011-12-07 Juanma Barranquero <lekktu@gmail.com>
4749
4750 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4751 dirs from the default value of EMACSLOADPATH (bug#10208).
4752
7efa6272
GM
47532011-12-07 Glenn Morris <rgm@gnu.org>
4754
4755 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4756 installation and source directories as well. (Bug#10208)
4757
f6fc4d87
CY
47582011-12-06 Chong Yidong <cyd@gnu.org>
4759
4760 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4761
2bf26180
GM
47622011-12-06 Glenn Morris <rgm@gnu.org>
4763
4764 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4765 as an error, not just -1. (Bug#10217)
4766
3a6ad4f0
CY
47672011-12-05 Chong Yidong <cyd@gnu.org>
4768
4769 * keyboard.c (process_special_events): New function.
4770 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4771
75a3b399
PE
47722011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4773
4774 * coding.c (encode_designation_at_bol): Don't use uninitialized
4775 local variable (Bug#9318).
4776
c3c9e25e
KH
47772011-12-05 Kenichi Handa <handa@m17n.org>
4778
4779 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4780 return Qnil (Bug#8046, Bug#10193).
4781
5eb05ea3
KH
47822011-12-05 Kenichi Handa <handa@m17n.org>
4783
4784 * coding.c (encode_designation_at_bol): New args charbuf_end and
4785 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4786 (coding_set_source): Return how many bytes coding->source was
4787 relocated.
4788 (coding_set_destination): Return how many bytes
4789 coding->destination was relocated.
4790 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4791 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4792
47932011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4794
4795 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4796 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4797 macro (Bug#9318).
4798
47992011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4800
4801 The following changes are to fix Bug#9318.
4802
a79703f5 4803 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4804 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4805 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4806 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4807
7dbda6df
JB
48082011-12-05 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * lisp.h (process_quit_flag): Fix external declaration.
4811
6d5eb5b0
SM
48122011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4813
4814 Don't macro-inline non-performance-critical code.
4815 * eval.c (process_quit_flag): New function.
4816 * lisp.h (QUIT): Use it.
4817
a0c3fad0
JD
48182011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4819
4820 * nsfns.m (get_geometry_from_preferences): New function.
4821 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4822
6c07aac2
AS
48232011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4824
4825 * emacs.c (Qkill_emacs): Define.
4826 (syms_of_emacs): Initialize it.
4827 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4828 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4829 (quit_throw_to_read_char): Add parameter `from_signal'.
4830 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4831 * lisp.h (QUIT): Call Fkill_emacs if requested.
4832
c052ead4
JD
48332011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4834
4835 * widget.c (update_wm_hints): Return if wmshell is null.
4836 (widget_update_wm_size_hints): New function.
4837
4838 * widget.h (widget_update_wm_size_hints): Declare.
4839
4840 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4841 widget_update_wm_size_hints (Bug#10104).
4842
9e49252b
EZ
48432011-12-03 Eli Zaretskii <eliz@gnu.org>
4844
4845 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4846 before a newline, prepare the bidi iterator for consuming the
4847 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4848 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4849
02b16839
JL
48502011-12-02 Juri Linkov <juri@jurta.org>
4851
4852 * search.c (Fword_search_regexp): New Lisp function created from
4853 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4854 (Fword_search_backward, Fword_search_forward)
4855 (Fword_search_backward_lax, Fword_search_forward_lax):
4856 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4857 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4858
0068070e
SM
48592011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4860
4861 * fileio.c (Finsert_file_contents): Move after-change-function call
4862 to before the "handled:" label, since all "goto handled" appear in
4863 cases where the *-change-functions have already been properly called
4864 (bug#10117).
4865
3360a3fc
AS
48662011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4867
4868 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4869 waiting for input. (Bug#10169)
4870
73d6c093
EZ
48712011-11-30 Eli Zaretskii <eliz@gnu.org>
4872
4873 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4874 verifies glyph row's hash code--we have just reallocated the
4875 glyphs, so their contents can be complete garbage. (Bug#10164)
4876
febe6bea
JB
48772011-11-30 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4880
801a4313
EZ
48812011-11-30 Eli Zaretskii <eliz@gnu.org>
4882
4883 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4884 attributes are tested _before_ calling verify_row_hash, to protect
4885 against GCC re-ordering of the tests. (Bug#10164)
4886
2b56b87e
JD
48872011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4888
4889 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4890
4891 * xterm.c (handle_one_xevent): Only set async_visible and friends
4892 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4893 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4894 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4895
dbf31225
PE
48962011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4899 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4900 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4901 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4902 All uses changed to use GCPRO1 etc.
4903 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4904 Revert to old implementation (i.e., before 2011-03-11).
4905
1305621b
YM
49062011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4907
4908 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4909 of scroll runs so as to avoid assigning disabled bogus rows and
4910 unnecessary graphics copy operations.
4911
8c9afb46
EZ
49122011-11-27 Eli Zaretskii <eliz@gnu.org>
4913
4914 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4915 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4916 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4917 (malloc, free, realloc, calloc): Redirect to e_* only when
4918 compiling Emacs.
4919
4920 * lisp.h (GCTYPEBITS): Move before first use.
4921 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4922 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4923 this macro definition.
4924
4925 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4926 _MSC_VER.
4927
54e9e3bf
JD
49282011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4929
6d5eb5b0
SM
4930 * gtkutil.c (xg_create_frame_widgets):
4931 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4932 present with Gtk+ 2.0.
4933
83aca1cb
PE
49342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4935
4936 * fileio.c (Finsert_file_contents): Undo previous change; see
4937 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4938
5b76caa4
PE
49392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4940
4941 Rename locals to avoid shadowing.
4942 * fileio.c (Finsert_file_contents):
4943 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4944 * process.c (wait_reading_process_output):
4945 Rename inner 'proc' to 'p' to avoid shadowing.
4946 Indent for consistency with usual Emacs style.
4947
8c535114
EZ
49482011-11-25 Eli Zaretskii <eliz@gnu.org>
4949
4950 * xdisp.c (redisplay_window): If cursor row is not fully visible
4951 after recentering, and scroll-conservatively is set to a large
4952 number, scroll window by a few more lines to make the cursor fully
4953 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4954 (start_display): Don't move to the next line if the display should
4955 start at a newline that is part of a display vector or an overlay
4956 string. (Bug#10119)
8c535114 4957
fa4fdb5c
JL
49582011-11-24 Juri Linkov <juri@jurta.org>
4959
4960 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4961 after the `MagickPingImage' call. (Bug#10112)
4962
90ec88df
CY
49632011-11-23 Chong Yidong <cyd@gnu.org>
4964
4965 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4966
56e2e794
MR
49672011-11-23 Martin Rudalics <rudalics@gmx.at>
4968
4969 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4970 making another buffer current. (Bug#10114)
4971
b6e64c41
GM
49722011-11-23 Glenn Morris <rgm@gnu.org>
4973
4974 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4975
6b21de18
CY
49762011-11-23 Chong Yidong <cyd@gnu.org>
4977
4978 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4979 using it (Bug#5984).
4980
b12cd789
EZ
49812011-11-22 Eli Zaretskii <eliz@gnu.org>
4982
4983 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4984 and header-lines, as they don't have one computed for them.
4985 (Bug#10098)
4986
4987 * .gdbinit (prow): Make displayed values more self-explaining.
4988 Add row's hash code.
4989
261b6fd4
LMI
49902011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4991
4992 * process.c (wait_reading_process_output): Fix asynchrounous
4993 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4994 (wait_reading_process_output): Add comment and URL.
261b6fd4 4995
e7cfd277
JD
49962011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4997
4998 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4999
a9b9b7f5
CY
50002011-11-21 Chong Yidong <cyd@gnu.org>
5001
5002 * window.c (Fnext_window, Fprevious_window): Doc fix.
5003
b0d15b4f
SM
50042011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5005
5006 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5007
fe7a3057
JB
50082011-11-20 Juanma Barranquero <lekktu@gmail.com>
5009
5010 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5011
d2999b1a
MR
50122011-11-20 Martin Rudalics <rudalics@gmx.at>
5013
5014 * window.c (Fset_window_combination_limit): Rename argument
5015 STATUS to LIMIT.
5016 (Vwindow_combination_limit): Remove "status" from doc-string.
5017
d5ff9cd0
AS
50182011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5019
5020 * m/ibms390.h: Remove.
5021 * m/ibms390x.h: Don't include "ibms390.h".
5022
a5bb9bd3
SM
50232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5024
5025 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5026 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5027
cd1181db
JB
50282011-11-20 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * casetab.c (Fset_case_table):
5031 * charset.c (Fcharset_after): Fix typos.
5032
615a3b8d 50332011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5034
17e845af
PE
5035 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5036 Otherwise, valgrind does not work on some platforms.
5037 Problem reported by Andreas Schwab in
6a0bf43d
PE
5038 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5039 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5040 is set, removing the need for VIRT_ADDRESS_VARIES.
5041 (PURE_P): Use a more-efficient implementation that needs just one
5042 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5043 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5044 to 4 (xorl, subq, cmpq, setbe).
5045 * alloc.c (pure): Always extern now, since that's the
5046 VIRT_ADDR_VARIES behavior.
5047 (PURE_POINTER_P): Use a single comparison, not two, for
5048 consistency with the new puresize.h.
5049 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5050 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5051 Remove VIRT_ADDR_VARIES no longer needed.
5052
f8fe6f96
EZ
50532011-11-19 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5056 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5057 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5058 behave as if the cursor position were at the window margin.
5059
5060 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5061 and the cursor position is out of bounds, behave as if the cursor
5062 position were at the window margin. (Bug#10075)
5063
df05a53c
CY
50642011-11-18 Chong Yidong <cyd@gnu.org>
5065
5066 * window.c (Fwindow_combination_limit): Make first argument
5067 non-optional, since it is meaningless for live windows like the
5068 selected window.
61ccba97 5069
2071918e
DA
50702011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5071
5072 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5073
b50a28de
SM
50742011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5075
5076 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5077 (graft_intervals_into_buffer): Simplify.
5078
015137db
EZ
50792011-11-18 Eli Zaretskii <eliz@gnu.org>
5080
5081 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5082 hash values of the two rows.
5083 (copy_row_except_pointers): Preserve the used[] arrays and the
5084 hash values of the two rows. (Bug#10035)
68c95424 5085 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5086
5087 * xdisp.c (row_hash): New function, body extracted from
5088 compute_line_metrics.
5089 (compute_line_metrics): Call row_hash, instead of computing the
5090 hash code inline.
5091
5092 * dispnew.c (verify_row_hash): Call row_hash for computing the
5093 hash code of a row, instead of duplicating code from xdisp.c.
5094
5095 * dispextern.h (row_hash): Add prototype.
5096
a2addb04
TH
50972011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5098
5099 * frame.c (delete_frame): Don't delete the terminal when the last
5100 X frame is closed if emacs is built with GTK toolkit.
5101
df85d315
JB
51022011-11-17 Juanma Barranquero <lekktu@gmail.com>
5103
5104 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5105
a0c2d0ae
MR
51062011-11-17 Martin Rudalics <rudalics@gmx.at>
5107
5108 * window.c (Vwindow_splits): Rename to
5109 Vwindow_combination_resize. Suggested by Juri Linkov.
5110 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5111 of Vwindow_splits.
5112
58179cce
JB
51132011-11-16 Juanma Barranquero <lekktu@gmail.com>
5114
7877f373
JB
5115 * nsfns.m (Fns_font_name):
5116 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5117
b6f67890
MR
51182011-11-16 Martin Rudalics <rudalics@gmx.at>
5119
5120 * window.h (window): Rename slot "nest" to "combination_limit".
5121 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5122 (Fset_window_nest): Rename to Fset_window_combination_limit.
5123 (Vwindow_nest): Rename to Vwindow_combination_limit.
5124 (recombine_windows, make_parent_window, make_window)
5125 (Fsplit_window_internal, saved_window)
5126 (Fset_window_configuration, save_window_save): Rename all
5127 occurrences of window_nest to window_combination_limit.
5128
c7015153
JB
51292011-11-15 Juanma Barranquero <lekktu@gmail.com>
5130
5131 * image.c (imagemagick_load_image): Fix typo.
5132
322ad6ec
EZ
51332011-11-14 Eli Zaretskii <eliz@gnu.org>
5134
5135 * xdisp.c (display_line): Move the call to
5136 highlight_trailing_whitespace before the call to
5137 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5138 faces of all the glyphs to compute ROW's hash value.
5139 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5140
f067b8ec
JB
51412011-11-14 Juanma Barranquero <lekktu@gmail.com>
5142
5143 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5144 just return (bug#10044).
5145
1e5b2111
EZ
51462011-11-12 Eli Zaretskii <eliz@gnu.org>
5147
7ef3cbd5
EZ
5148 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5149 with user-defined heap size. Bump the default size of the temacs
5150 heap to 27MB, to avoid memory warning when running temacs.
5151 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5152
1e5b2111
EZ
5153 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5154 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5155 (verify_row_hash) [XASSERTS]: New function.
5156 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5157 that the hash value of glyph rows is correct.
1e5b2111 5158
89d61221
MR
51592011-11-12 Martin Rudalics <rudalics@gmx.at>
5160
5161 * window.h (window): Remove splits slot.
5162 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5163 (Fdelete_other_windows_internal, make_parent_window)
5164 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5165 (Fset_window_configuration, save_window_save): Don't deal with
5166 split status of windows.
5167 (saved_window): Remove splits slot.
5168 (Vwindow_splits): Rewrite doc-string.
5169
97f18cc8
JD
51702011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5171
5172 * xfns.c (unwind_create_frame):
5173 * nsfns.m (unwind_create_frame):
5174 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5175 Vframe_list (Bug#9999).
5176
22a648b4
DA
51772011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5178
0b381c7e 5179 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5180
659afede
KH
51812011-11-11 Kenichi Handa <handa@m17n.org>
5182
5183 * callproc.c (Fcall_process): Set the member dst_multibyte of
5184 process_coding.
5185
9ac0394b
KH
51862011-11-11 Johan Bockgård <bojohan@gnu.org>
5187
5188 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5189 avoid a crash (bug#9496).
5190
2fbdc249
CY
51912011-11-09 Chong Yidong <cyd@gnu.org>
5192
5193 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5194 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5195
ac6b1f81
PE
51962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5197
5198 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5199
09db192c
PE
52002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5201
5202 Avoid some portability problems by eschewing 'extern inline' functions.
5203 The trivial performance wins aren't worth the portability hassles; see
5204 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5205 et seq.
5206 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5207 (window_box_width, window_box_left, window_box_left_offset)
5208 (window_box_right, window_box_right_offset): Undo previous change,
5209 by removing the "extern"s.
5210 * intervals.c (adjust_intervals_for_insertion)
5211 (adjust_intervals_for_deletion): Undo previous change,
5212 making these static again.
5213 (offset_intervals, temp_set_point_both, temp_set_point)
5214 (copy_intervals_to_string): No longer inline.
5215 * xdisp.c (window_text_bottom_y, window_box_width)
5216 (window_box_height, window_box_left_offset)
5217 (window_box_right_offset, window_box_left, window_box_right)
5218 (window_box): No longer inline.
5219
105216ed
CY
52202011-11-08 Chong Yidong <cyd@gnu.org>
5221
5222 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5223 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5224 Signal an error if not a live window.
105216ed
CY
5225 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5226 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5227
ae9e237f
JB
52282011-11-07 Juanma Barranquero <lekktu@gmail.com>
5229
5230 * lisp.h (syms_of_abbrev): Remove declaration.
5231 Reported by CHENG Gao <chenggao@royau.me>.
5232
c7aa8333
EZ
52332011-11-07 Eli Zaretskii <eliz@gnu.org>
5234
5235 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5236 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5237 of temacs in GUI mode.
5238
be7f5545
MR
52392011-11-07 Martin Rudalics <rudalics@gmx.at>
5240
5241 * window.h: Declare delete_all_child_windows instead of
5242 delete_all_subwindows.
5243 * window.c (Fwindow_nest, Fset_window_nest)
5244 (Fset_window_new_total, Fset_window_new_normal)
5245 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5246 (delete_all_subwindows): Rename to delete_all_child_windows.
5247 (Fdelete_other_windows_internal, Fset_window_configuration):
5248 Call delete_all_child_windows instead of delete_all_subwindows.
5249 * frame.c (delete_frame): Call delete_all_child_windows instead
5250 of delete_all_subwindows.
5251
ca78dc43
PE
52522011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5255 This is also needed for porting to any host where GC_MARK_STACK is
5256 not GC_MAKE_GCPROS_NOOPS.
5257 (which_symbols): Use it.
5258
a0241d01
KH
52592011-11-07 Kenichi Handa <handa@m17n.org>
5260
5261 * coding.c (coding_set_destination): Check coding->src_pos only
5262 when coding->src_object is a buffer (bug#9910).
5263
5264 * process.c (send_process): Set the member src_multibyte of coding
5265 to 0 (bug#9911) when sending a unibyte text.
5266
5267 * callproc.c (Fcall_process): Set the member src_multibyte of
5268 process_coding to 0 (bug#9912).
5269
a64bfdfa 52702011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5271
5272 * xmenu.c (cleanup_widget_value_tree): New function.
5273 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5274 calling free_menubar_widget_value_tree directly (Bug#9830).
5275
cb41b32a
PE
52762011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5277
5278 Fix some portability problems with 'inline'.
5279 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5280 (window_box_width, window_box_left, window_box_left_offset)
5281 (window_box_right, window_box_right_offset): Declare extern.
5282 Otherwise, these inline functions do not conform to C99 and
5283 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5284 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5285 * intervals.c (adjust_intervals_for_insertion)
5286 (adjust_intervals_for_deletion): Now extern, because otherwise the
5287 extern inline functions 'offset_intervals' couldn't refer to it.
5288 (static_offset_intervals): Remove.
5289 (offset_intervals): Rewrite using the old contents of
5290 static_offset_intervals. The old version didn't conform to C99
5291 because an extern inline function contained a reference to an
5292 identifier with static linkage.
5293
b7041366
AS
52942011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5295
5296 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5297 GC.
5298
88a37c4d
EZ
52992011-11-06 Eli Zaretskii <eliz@gnu.org>
5300
5301 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5302 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5303 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5304 return Qleft_to_right.
5305
49745b39
CY
53062011-11-06 Chong Yidong <cyd@gnu.org>
5307
5308 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5309 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5310 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5311 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5312 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5313 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5314 (Fwindow_vscroll): Doc fix.
5315 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5316 argument, since it makes no sense to pass a live window and for
5317 consistency with window-child.
5318
1f05cd82
CS
53192011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5320
5321 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5322 support MSVC.
5323
22610910
JR
53242011-11-05 Jason Rumney <jasonr@gnu.org>
5325
5326 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5327 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5328 fonts (Bug#6029).
5329 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5330 bitwise arithmetic preventing use of unicode-sip and non-truetype
5331 opentype fonts.
5332
a06776b2
EZ
53332011-11-05 Eli Zaretskii <eliz@gnu.org>
5334
3ad924ba
EZ
5335 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5336 "emacs"-only part.
5337
a06776b2
EZ
5338 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5339 initialization code to keep similarity to xfns.c after changes
5340 from 2011-11-05.
5341
c9e7db78
JD
53422011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5343
a97f8f3f
JD
5344 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5345 (unwind_create_frame): New function (Bug#9943).
5346 (Fx_create_frame): Restructure code to be more similar to the one in
5347 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5348 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5349 Move terminal->reference_count++ just before making the frame official
5350 (Bug#9943).
5351
5352 * nsterm.m (x_free_frame_resources): New function.
5353 (x_destroy_window): Move code to x_free_frame_resources.
5354
c9e7db78 5355 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5356 (Fx_create_frame, x_create_tip_frame):
5357 Move terminal->reference_count++ just before making the frame
75f1671a 5358 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5359 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5360
a6fc3b5c
EZ
53612011-11-05 Eli Zaretskii <eliz@gnu.org>
5362
5363 Support MSVC build with newer versions of Visual Studio.
5364 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5365 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5366 nt/gmake.defs.
5367
5368 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5369 which are not supported by MSVC.
5370 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5371 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5372 bitfields.
5373 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5374 types in bitfields.
5375 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5376
5377 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5378
58179cce 53792011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5380
5381 Support MSVC build with newer versions of Visual Studio.
5382 * w32.c: Don't include w32api.h for MSVC.
5383 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5384
5385 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5386 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5387 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5388 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5389 e_* cousins.
5390 (alloca) [_MSC_VER]: Define to _alloca.
5391
5392 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5393
5394 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5395
a58c13ed
EZ
53962011-11-04 Eli Zaretskii <eliz@gnu.org>
5397
5398 * xdisp.c (note_mouse_highlight): If either of
5399 previous/next-single-property-change returns nil, treat that as
5400 the beginning or the end of the buffer. (Bug#9955)
5401
fe0b6370
JD
54022011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5403
a58c13ed 5404 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5405 label is not null (Bug#9951).
5406 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5407 may be NULL.
5408
89bd5ee1
EZ
54092011-11-04 Eli Zaretskii <eliz@gnu.org>
5410
5411 * window.c (Fwindow_body_size): Mention in the doc string that the
5412 return value is in frame's canonical units. (Bug#9949)
5413
84c3edb9
EZ
54142011-11-03 Eli Zaretskii <eliz@gnu.org>
5415
4e2fb5c7
EZ
5416 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5417
84c3edb9 5418 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5419 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5420 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5421
bc17a887
EZ
54222011-11-01 Eli Zaretskii <eliz@gnu.org>
5423
5424 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5425 Don't stop backward scan on the continuation glyph, even though
5426 its CHARPOS is positive.
6d5eb5b0
SM
5427 (mouse_face_from_buffer_pos, note_mouse_highlight):
5428 Rename cover_string to disp_string.
bc17a887 5429
4ee88440
MR
54302011-11-01 Martin Rudalics <rudalics@gmx.at>
5431
5432 * window.c (temp_output_buffer_show): Don't use
5433 Vtemp_buffer_show_specifiers.
5434 (Vtemp_buffer_show_specifiers): Remove unused variable.
5435
c2ff3c02
EZ
54362011-10-30 Eli Zaretskii <eliz@gnu.org>
5437
5438 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5439 past the beginning of the current glyph matrix.
5440
58179cce 54412011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5442
5443 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5444 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5445 HAVE_GTK3 (Bug#9869).
b77a6a7f 5446
3b574623
JD
5447 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5448 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5449
b77a6a7f
JD
5450 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5451
5452 * xterm.c: Declare x_handle_net_wm_state to return int.
5453 (handle_one_xevent): Check if we are iconified but don't have
5454 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5455 (get_current_wm_state): Return non-zero if not hidden,
5456 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5457 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5458 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5459 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5460
196e41e4
PE
54612011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5462
5463 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5464 so that this new function doesn't get optimized away by a
5465 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5466
021f2e1a
AS
54672011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5468
5469 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5470
8b058d44
EZ
54712011-10-29 Eli Zaretskii <eliz@gnu.org>
5472
5473 Fix the `xbytecode' command.
5474 * .gdbinit (xprintbytestr): New command.
b50a28de 5475 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5476 (xbytecode): Print the byte-code string as well.
5477
4452fb80
EZ
54782011-10-29 Kim Storm <storm@cua.dk>
5479
8b058d44
EZ
5480 * alloc.c (which_symbols): New function.
5481
21b72067
AS
54822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5483
5484 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5485 line. (Bug#9903)
5486
83ed7b5c
GM
54872011-10-29 Glenn Morris <rgm@gnu.org>
5488
5489 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5490 Not clear what it was for, and it causes various bugs. (Bug#9839)
5491
5a7a728b
EZ
54922011-10-28 Eli Zaretskii <eliz@gnu.org>
5493
5494 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5495 possible random value that matches one of those tested as
5496 condition to clear the mouse face.
5497
d3d0842f
CY
54982011-10-28 Chong Yidong <cyd@gnu.org>
5499
5500 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5501
31b39d13
DN
55022011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5503
5504 * window.c (make_window): Initialize phys_cursor_on_p.
5505
9aba6043
SM
55062011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5507
5508 * lisp.h (struct Lisp_Symbol): Update comments.
5509
c20992f4
JB
55102011-10-28 Juanma Barranquero <lekktu@gmail.com>
5511
5512 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5513
db4f02f2
EZ
55142011-10-28 Eli Zaretskii <eliz@gnu.org>
5515
5516 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5517 <oslsachem@gmail.com> for helping to debug this.
5518
5519 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5520 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5521 (g_b_init_get_glyph_outline_w): New static variables.
5522 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5523 (GetGlyphOutlineW_Proc): New typedefs.
5524 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5525 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5526 New functions.
5527 (w32font_open_internal, compute_metrics):
5528 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5529 instead of calling the "wide" APIs directly.
5530
5531 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5532
5533 * w32.h (syms_of_w32font): Add prototype.
5534
87e68db4
JB
55352011-10-27 Juanma Barranquero <lekktu@gmail.com>
5536
5537 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5538 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5539 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5540 (Fmove_to_window_line): Doc fix.
5541
435c1d67
CY
55422011-10-27 Chong Yidong <cyd@gnu.org>
5543
5544 * process.c (make_process): Set gnutls_state to NULL.
5545
5546 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5547 non-NULL, regardless of GNUTLS_INITSTAGE.
5548 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5549 an error. Set process slots as soon as we allocate them.
5550
5551 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5552
9c6c6f49
CY
55532011-10-27 Chong Yidong <cyd@gnu.org>
5554
9aba6043
SM
5555 * gnutls.c (emacs_gnutls_deinit): New function.
5556 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5557 (Fgnutls_deinit, Fgnutls_boot): Use it.
5558
5559 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5560 (deactivate_process): Call emacs_gnutls_deinit.
5561
657d08d3
JB
55622011-10-27 Juanma Barranquero <lekktu@gmail.com>
5563
5564 * image.c (x_create_x_image_and_pixmap):
5565 * w32.c (sys_rename, w32_delayed_load):
5566 * w32font.c (fill_in_logfont):
5567 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5568
5430d399
JB
55692011-10-26 Juanma Barranquero <lekktu@gmail.com>
5570
5571 * w32fns.c (w32_default_color_map): New function,
5572 extracted from Fw32_default_color_map.
a7ef684b 5573 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5574
fe0055fa
PE
55752011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5576
5577 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5578
e6346438
SM
55792011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5580
5581 * keyboard.c (test_undefined): New function (bug#9751).
5582 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5583
e112cc37
ET
55842011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5585
5586 * sysdep.c (init_sys_modes): Fix the check for the controlling
5587 terminal (Bug#6649).
5588
7b5d6677
EZ
55892011-10-20 Eli Zaretskii <eliz@gnu.org>
5590
5591 * dispextern.h (struct bidi_it): New member next_en_type.
5592
5593 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5594 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5595 current character, check also for next_en_type being WEAK_EN.
5596 (bidi_resolve_weak): Don't enter the expensive loop if the current
5597 position is before next_en_pos. Record the bidi type of the first
5598 non-ET, non-BN character we find, in addition to its position.
5599 (bidi_level_of_next_char): Invalidate next_en_type when
5600 next_en_pos is over-stepped.
5601
7da0b018
PE
56022011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5603
5604 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5605 * editfns.c: Rewrite current-time-zone so that it invokes
5606 the equivalent of (format-time-string "%Z") to get the time zone name.
5607 This fixes a bug when the time zone name contains characters that
5608 need converting from the system time locale to Emacs internal format.
5609 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5610 that patch fixed format-time-string to do the conversion, but
5611 I forgot to fix current-time-zone.
5612 (format_time_string): New function, containing most of
5613 what Fformat_time_string used to contain.
5614 (Fformat_time_string): Rewrite in terms of format_time_string.
5615 This doesn't change this function's behavior.
5616 (current-time-zone): Rewrite to use format_time_string.
5617 This fixes the bug reported by Michael Schierl in
5618 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5619 Jason Rumney's 2007-06-07 change worked around this bug, but
5620 didn't fix it.
5621 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5622
8547b010
EZ
56232011-10-19 Eli Zaretskii <eliz@gnu.org>
5624
5625 * xdisp.c (start_display): If the character at POS is displayed
5626 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5627 (try_window_reusing_current_matrix): If a line ends in a display
5628 vector or the next line starts in a display vector, continue
5629 redrawing the window even though the character position of
5630 start_row was reached.
8547b010
EZ
5631 (Bug#9771, part 2)
5632
4e948d15
CY
56332011-10-18 Chong Yidong <cyd@gnu.org>
5634
5635 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5636 with nobreak-char-display too.
5637
4787455f
EZ
56382011-10-18 Eli Zaretskii <eliz@gnu.org>
5639
5640 Fix part 3 of bug#9771.
5641 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5642 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5643 non-neutral characters if the current character is a paragraph
5644 separator (a.k.a. Newline). This avoids running the same
5645 expensive loop twice, once when we consume the preceding newline
5646 and the other time when the line actually needs to be displayed.
5647 Avoid the loop when we see neutrals on the base embedding level
5648 following a character whose directionality is the same as the
5649 paragraph's. This avoids running the expensive loop when a line
5650 ends in a long sequence of neutrals, like control characters.
5651 Add assertion against STRONG_AL type. Slightly rearrange code
5652 that determines the type of a neutral given the first non-neutral
5653 that follows it.
5654 (bidi_level_of_next_char): Set next_en_pos to zero when
5655 invalidating its info.
5656
2c91f553
EZ
56572011-10-17 Eli Zaretskii <eliz@gnu.org>
5658
5659 * xdisp.c (push_display_prop): Determine whether to record string
5660 or buffer position by IT->string, not by IT->method. Allow
5661 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5662 (move_it_vertically_backward): Don't look for character position
5663 immediately after the newline when in a continuation line.
5664 (Bug#9771, part 1)
2c91f553 5665
c7b08b0d
MR
56662011-10-15 Martin Rudalics <rudalics@gmx.at>
5667
5668 * window.c (coordinates_in_window): Rewrite and delabelize
5669 vertical border check. (Bug#5357) (Bug#9618)
5670
6b02f655
SM
56712011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5672
5673 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5674 errors in XSetWindowBorder (bug#9310).
5675
81d40c92
DA
56762011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5677
5678 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5679 avoid crash when xmalloc overrun checking is enabled.
5680
d4172c3b
EZ
56812011-10-13 Eli Zaretskii <eliz@gnu.org>
5682
5683 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5684 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5685 cursor motion with <left> and <right> arrow keys.
5686
5687 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5688 some callers set that themselves.
5689
b00eea75
EZ
56902011-10-12 Eli Zaretskii <eliz@gnu.org>
5691
5692 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5693 display string and the previous row comes from the same string and
5694 is empty. (Bug#9739) (Bug#9738)
5695
8fe012c4
SM
56962011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5697
5698 * doc.c (get_doc_string): Encode file name (bug#9735).
5699
0074aef2
EZ
57002011-10-12 Eli Zaretskii <eliz@gnu.org>
5701
79beb178
EZ
5702 * bidi.c (bidi_level_of_next_char):
5703 * xdisp.c (get_visually_first_element): Remove old incorrect
5704 comments regarding the Unicode Line Separator character.
5705
0074aef2
EZ
5706 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5707
6e4b3fbe
DA
57082011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5709
5710 * alloc.c (Fgc_status): Do not access beyond zombies array
5711 boundary if nzombies > MAX_ZOMBIES.
5712 * alloc.c (dump_zombies): Add missing format specifier.
5713
0324f3af
PE
57142011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5715
b5525cac
PE
5716 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5717 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5718
0324f3af
PE
5719 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5720 Some packages use them to denote characters with modifiers.
5721
e9b5f888
AS
57222011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5723
5724 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5725 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5726 matching a pp-number. Rename parameter var to var1.
5727
127827c0
SM
57282011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5729
5730 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5731
c8fd3bd0
GM
57322011-10-08 Glenn Morris <rgm@gnu.org>
5733
5734 * callint.c (Fcall_interactively): Give a more explicit error for the
5735 'c' case with a non-character input. (Bug#8479)
5736
352ec8ff
EZ
57372011-10-08 Eli Zaretskii <eliz@gnu.org>
5738
03669ccb
EZ
5739 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5740 lines.
7061c986
EZ
5741 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5742 lines that are hscrolled on the left.
03669ccb 5743
352ec8ff
EZ
5744 * dispnew.c (buffer_posn_from_coords): Account for a possible
5745 presence of header-line. (Bug#4426)
5746
a66cfb1c
SM
57472011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5748
6b02f655
SM
5749 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5750 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5751
7c5ee88e
PE
57522011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5753
5754 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5755 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5756 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5757 this makes Emacs dump core during garbage collection on rare
5758 occasions. sizeof is obviously inferior to offsetof here, so
5759 stick with offsetof.
5760 (GC_POINTER_ALIGNMENT): New macro.
5761 (mark_memory): Omit 3rd (offset) arg; caller changed.
5762 Don't assume EMACS_INT alignment is the same as pointer alignment.
5763
df1bbe5b
SM
57642011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5765
5766 * keyboard.c (read_key_sequence_remapped): New var.
5767 (read_key_sequence): Compute remapping in the right buffer.
5768 (command_loop_1): Use read_key_sequence's remapping directly.
5769
51553db6
SM
57702011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5771
32c1fffd
SM
5772 * dired.c (file_name_completion): Don't expand file name.
5773 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5774 before checking file name handler.
5775
51553db6
SM
5776 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5777 they've been requested explicitly (bug#9591).
5778
b6bd1599 57792011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5780
5781 * keymap.c (Fsingle_key_description): Use make_specified_string
5782 instead of build_string to build string from push_key_description.
5783 (Bug#5193)
5784
f701dc2a
PE
57852011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5786
4222c55d
PE
5787 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5788 This fixes a Y2038 bug on 64-bit hosts.
5789 * buffer.c (reset_buffer):
5790 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5791 (Fclear_buffer_auto_save_failure):
5792 Use 0, not -1, to represent an unset failure time, since time_t
5793 might not be signed.
5794
f701dc2a
PE
5795 Remove dependency on glibc malloc internals.
5796 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5797 Move back here from lisp.h, but with their new implementations.
5798 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5799 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5800 * charset.c (charset_table_init): New static var.
5801 (syms_of_charset): Use it instead of xmalloc. This removes a
5802 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5803 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5804 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5805 Move back to alloc.c.
5806 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5807 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5808
9ceebf39
JD
58092011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5810
5811 * nsterm.m (windowDidResize): Call x_set_window_size only when
5812 ns_in_resize is true. Otherwise set pixelwidth/height and
5813 call change_frame_size (Bug#9628).
5814
cb993c58
PE
58152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5816
3930c88b
PE
5817 Port --enable-checking=all to Fedora 14 x86-64.
5818 * charset.c (syms_of_charset): Also account for glibc malloc's
5819 internal overhead when calculating the initial malloc maximum.
5820
cb993c58
PE
5821 Port --enable-checking=all to Fedora 14 x86.
5822 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5823 Move to lisp.h.
5824 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5825 (overrun_check_realloc, overrun_check_free):
5826 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5827 That way, xmalloc returns a properly-aligned pointer even if
5828 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5829 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5830 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5831 into account when calculating the initial malloc maximum.
5832 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5833 Move here from alloc.c, so that charset.c can use it too.
5834 Properly align; the old code wasn't right for common 32-bit hosts
5835 when configured with --enable-checking=all.
5836 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5837 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5838
31bed486
EZ
58392011-09-29 Eli Zaretskii <eliz@gnu.org>
5840
04c70788 5841 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5842 use EDOM.
5843
fbcaa2f3
EZ
58442011-09-28 Eli Zaretskii <eliz@gnu.org>
5845
5846 * xdisp.c (compute_display_string_end): If there's no display
5847 string at CHARPOS, return -1.
5848
5849 * bidi.c (bidi_fetch_char): When compute_display_string_end
5850 returns a negative value, treat the character as a normal
5851 character not covered by a display string. (Bug#9624)
5852
a239d4e9
JB
58532011-09-28 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * lread.c (Fread_from_string): Fix typo in docstring.
5856
88652fd5
EZ
58572011-09-27 Eli Zaretskii <eliz@gnu.org>
5858
5859 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5860 newline, reseat the iterator instead of bidi-iterating there one
5861 character at a time. (Bug#9610)
32c1fffd
SM
5862 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5863 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5864
ed497dd4
AS
58652011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5866
5867 * lread.c (readevalloop): Use correct code for NBSP.
5868 (read1): Likewise. (Bug#9608)
5869
b2bf61aa
MA
58702011-09-25 Michael Albinus <michael.albinus@gmx.de>
5871
5872 * dbusbind.c (Fdbus_register_signal): When service is not
5873 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5874
32bbb17c
GM
58752011-09-25 Glenn Morris <rgm@gnu.org>
5876
5877 * buffer.c (truncate-lines): Doc fix.
5878
94e0933e
CY
58792011-09-24 Chong Yidong <cyd@stupidchicken.com>
5880
5881 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5882 (Fset_window_next_buffers): Doc fix.
5883
cddde921
GM
58842011-09-24 Glenn Morris <rgm@gnu.org>
5885
5886 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5887
1260aef1
PE
58882011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5889
25b4bfa0
PE
5890 Fix minor problems found by static checking.
5891 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5892 * indent.c (Fvertical_motion): Fix == vs = typo.
5893
e3cbd34b
EZ
58942011-09-24 Eli Zaretskii <eliz@gnu.org>
5895
a66cfb1c
SM
5896 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5897 Default value is now t. Doc fix.
6bf7006f 5898
e3cbd34b 5899 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5900 logic when moving up, not only when moving down. Fix the
e3cbd34b 5901 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5902 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5903
5904 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5905 CHARPOS is covered by a display string which includes newlines.
5906 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5907 is covered by a display string with embedded newlines.
5908
a3de0cbd
MA
59092011-09-24 Michael Albinus <michael.albinus@gmx.de>
5910
5911 * dbusbind.c (Fdbus_register_signal): Add match rule to
5912 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5913 (Fdbus_register_method, Vdbus_registered_objects_table):
5914 Fix docstring.
a3de0cbd 5915
b260039d
JM
59162011-09-24 Jim Meyering <meyering@redhat.com>
5917
32c1fffd 5918 do not ignore write error for any output size
b260039d
JM
5919 The previous change was incomplete.
5920 While it makes emacs --batch detect the vast majority of stdout
5921 write failures, errors were still ignored whenever the output size is
5922 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5923 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5924 && echo FAIL: ignored write error
5925 FAIL: ignored write error
5926 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5927 && echo FAIL: ignored write error
5928 FAIL: ignored write error
5929 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5930
8eca8a7c
AS
59312011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5932
5933 * emacs.c (Fkill_emacs): In noninteractive mode exit
5934 non-successfully if a write error occurred on stdout. (Bug#9574)
5935
3341db62
EZ
59362011-09-21 Eli Zaretskii <eliz@gnu.org>
5937
5938 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5939 the xassert test.
5940
5941 * dispextern.h (struct it): Update the comment documenting what
5942 can it->OBJECT be.
5943
8c203dbf
EZ
59442011-09-20 Eli Zaretskii <eliz@gnu.org>
5945
5946 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5947 a display string, extend search for cursor position to end of row.
5948 (find_row_edges): If the row ends in a newline from a display
5949 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5950 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5951 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5952 non-empty line. Fixes confusing cursor motion with arrow keys at
5953 the beginning of a line that starts with whitespace.
8c203dbf 5954
a4824228
LMI
59552011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5956
5957 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5958 (bug#9493).
5959
33ed493b
CY
59602011-09-18 Chong Yidong <cyd@stupidchicken.com>
5961
5962 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5963 boolean (Bug#9154).
5964
56cd55c8
EZ
59652011-09-18 Eli Zaretskii <eliz@gnu.org>
5966
5967 * xdisp.c (display_line): Record maximum and minimum buffer
5968 positions even if no glyphs were produced (e.g., by a zero-width
5969 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5970 buffer positions that will be removed from the glyph row because
5971 they don't fit.
c02dcedf
EZ
5972 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5973 column is beyond frame width: don't subtract 1 "pixel" when
5974 computing width of the stretch.
3e62b7e0
EZ
5975 (reseat_at_next_visible_line_start): Undo the change made on
5976 2011-09-17 that saved paragraph information and restored it after
5977 the call to `reseat'. (Bug#9545)
56cd55c8 5978
5ed99d36 59792011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5980
5981 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5982 and turn window cursor on if cleared (Bug#9415).
5983
5ed99d36 59842011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5985
5986 * search.c (boyer_moore): Take unibyte characters from pattern
5987 literally. (Bug#9458)
5988
9bade7b2
EZ
59892011-09-18 Eli Zaretskii <eliz@gnu.org>
5990
5991 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5992
e5e9d610
PE
59932011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5994
87e4427a
PE
5995 Fix minor problem found by static checking.
5996 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5997 initialized, to pacify gcc -Wuninitialized.
5998
e5e9d610
PE
5999 * fileio.c: Report proper errno when syscall falls.
6000 (Finsert_file_contents): Save and restore errno,
6001 so that report_file_error outputs the correct diagnostic.
6002 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6003
a1674f0b
EZ
60042011-09-18 Eli Zaretskii <eliz@gnu.org>
6005
6006 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6007
fbfb6dd4
EZ
60082011-09-17 Eli Zaretskii <eliz@gnu.org>
6009
6010 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6011 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6012
bb187662
EZ
60132011-09-17 Eli Zaretskii <eliz@gnu.org>
6014
1137e8b8 6015 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6016 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6017
6018 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6019 (bidi_find_paragraph_start): Search back for paragraph beginning
6020 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6021 (bidi_move_to_visually_next): Only trigger paragraph-related
6022 computations when the last character is a newline or at EOB, not
6023 just any NEUTRAL_B. (Bug#9470)
6024
bb187662
EZ
6025 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6026 truncated lines if point is covered by a display string. (Bug#9524)
6027
2e621251
PE
60282011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6029
6030 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6031 (cons_to_x_long): New function.
6032 (lisp_data_to_selection_data): Use it. Correct the test for
6033 short-versus-long data; it was negated. Break out of vector
6034 loop, for efficiency, when a long datum is discovered.
6035
91a15bc6
SM
60362011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6037
6038 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6039
b41c3a35
EZ
60402011-09-16 Eli Zaretskii <eliz@gnu.org>
6041
6042 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6043 GCC PR/17406) by declaring this function with external scope.
6044
7812ba2d
PE
60452011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6046
6047 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6048 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6049
cf7edc2a
AS
60502011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6051
6052 * editfns.c (Fformat): Correctly handle text properties on "%%".
6053
bd01620e
EZ
60542011-09-15 Eli Zaretskii <eliz@gnu.org>
6055
6056 * xterm.c (x_draw_composite_glyph_string_foreground):
6057 * w32term.c (x_draw_composite_glyph_string_foreground):
6058 * term.c (encode_terminal_code):
6059 * composite.c (composition_update_it, get_composition_id):
6060 * xdisp.c (get_next_display_element)
6061 (fill_composite_glyph_string): Add comments about special meaning
6062 of TAB characters in a composition.
6063
a02719a3
PE
60642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6065
6066 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6067 This occurs when processing a multibyte format.
6068 Problem reported by Wolfgang Jenker.
a02719a3 6069
72589a3c
JB
60702011-09-15 Johan Bockgård <bojohan@gnu.org>
6071
6072 * xdisp.c (try_cursor_movement): Only check for exact match if
6073 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6074
1c14176c
PE
60752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6076
6077 Remove unused external symbols.
6078 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6079 * xdisp.c (calc_pixel_width_or_height): Now static.
6080 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6081 * indent.c (check_display_width):
6082 * w32term.c: Fix comment to match code.
6083 * xterm.c, xterm.h (x_catching_errors): Remove.
6084
d2eea5b5
PE
60852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6086
6087 * xselect.c: Use signed conversions more consistently (Bug#9498).
6088 (selection_data_to_lisp_data): Assume incoming selection data are
6089 signed integers, not unsigned. This is to be consistent with
6090 outgoing selection data, which was modified to use signed integers
6091 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6092 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6093 expects long, not unsigned long.
6094
46888499
EZ
60952011-09-14 Eli Zaretskii <eliz@gnu.org>
6096
6097 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6098 computation of loop end. Reported by Johan Bockgård
6099 <bojohan@gnu.org>.
6100
ef8ef9fb
CY
61012011-09-13 Chong Yidong <cyd@stupidchicken.com>
6102
6103 * frame.c (Fother_visible_frames_p): Function deleted.
6104
fa819fed
EZ
61052011-09-12 Eli Zaretskii <eliz@gnu.org>
6106
6107 * indent.c (compute_motion): Process display vector front to back
6108 rather than the other way around. (Bug#2496)
6109
2ba8e008
SM
61102011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6111
6112 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6113
20f53c69
CY
61142011-09-11 Chong Yidong <cyd@stupidchicken.com>
6115
6116 * minibuf.c (Fread_from_minibuffer): Doc fix.
6117
d562d7a4
EZ
61182011-09-11 Eli Zaretskii <eliz@gnu.org>
6119
6120 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6121 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6122
1c4d7f3d
LMI
61232011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6124
6125 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6126 value for non-existent files.
6127
b885bf36
EZ
61282011-09-11 Eli Zaretskii <eliz@gnu.org>
6129
6130 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6131 set its "size" to -1. This will set the modtime_size field of
6132 the corresponding buffer to -1, which is what
6133 verify-visited-file-modtime expects for files that do not exist.
6134 (Bug#9139)
6135
6612f0bf
PE
61362011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6137
6138 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6139 here ...
6140 * lisp.h: ... from here. push_key_description is no longer
6141 defined in keyboard.c, so its declaration should not be in
6142 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6143 logically belongs with push_key_description.
6144
dfb3f755
PE
61452011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6146
6147 * buffer.h: Include <sys/types.h> instead of <time.h>.
6148 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6149 Problem reported by Herbert J. Skuhra.
6150
3134906c
LMI
61512011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6152
6153 * xml.c (parse_region): Make the parsing work for
6154 non-comment-starting XML files again (bug#9144).
6155
8d903f4e
AS
61562011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6157
6158 * image.c (gif_load): Fix calculation of bottom and right corner.
6159 (Bug#9468)
6160
80ad64f4
EZ
61612011-09-10 Eli Zaretskii <eliz@gnu.org>
6162
6163 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6164 redisplay in small windows.
6165
208a048d
EZ
61662011-09-09 Eli Zaretskii <eliz@gnu.org>
6167
6168 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6169
9b1c252e
MR
61702011-09-08 Martin Rudalics <rudalics@gmx.at>
6171
6172 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6173 Operate on live windows only.
6174
2949f33b
JB
61752011-09-08 Juanma Barranquero <lekktu@gmail.com>
6176
6177 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6178
e08dcafd
EZ
61792011-09-07 Eli Zaretskii <eliz@gnu.org>
6180
6181 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6182 only under bidi iteration.
6183
115b96bd
JD
61842011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6185
6186 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6187
c8199d0f
PE
61882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6189
6190 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6191 Without this fix, the command to link temacs failed due to an
6192 undefined symbol __builtin_isnan. This is because
6193 /usr/include/iso/math_c99.h #defines isnan(x) to
6194 __builtin_isnan(x), but the bundled gcc, which identifies itself
6195 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6196 a __builtin_isnan.
6197 * floatfns.c (isnan): #undef, and then #define to a clone of
6198 what's in data.c.
6199 (Fisnan): Always define, since it's always available now.
6200 (syms_of_floatfns): Always define isnan at the Lisp level.
6201
e39b275c 62022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6203
6204 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6205
b2db44d9 62062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6207
f4af5137 6208 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6209 The previous code assumed that file offsets (off_t values) fit in
6210 EMACS_INT variables, which is not true on typical 32-bit hosts.
6211 The code messed up by falsely reporting buffer overflow in cases
6212 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6213 when "big" contains more than 2**29 bytes, even though this
6214 inserts just one byte and does not overflow the buffer.
6215 (Finsert_file_contents): Store file offsets as off_t
6216 values, not as EMACS_INT values. Check for overflow when
6217 converting between EMACS_INT and off_t. When checking for
6218 buffer overflow or for overlap, take the offsets into account.
6219 Don't use EMACS_INT for small values where int suffices.
6220 When checking for overlap, fix a typo: ZV was used where
6221 ZV_BYTE was intended.
6222 (Fwrite_region): Don't assume off_t fits into 'long'.
6223 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6224
ecfc0a49
MA
62252011-09-05 Michael Albinus <michael.albinus@gmx.de>
6226
6227 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6228
6511acf2 62292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6230
0999621a 6231 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6232
6233 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6234 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6235 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6236 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6237 (modify_event_symbol): Do not assume that the length of
6238 name_alist_or_stem is safe to alloca and fits in int.
6239 (Fexecute_extended_command): Likewise for function name and binding.
6240 (Frecursion_depth): Wrap around reliably on integer overflow.
6241 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6242 since some callers pass EMACS_INT values.
6243 (Fsingle_key_description): Don't crash if symbol name contains more
6244 than MAX_ALLOCA bytes.
6245 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6246 (get_minibuffer): Arg is now EMACS_INT, not int.
6247 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6248 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6249 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6250
2be7d702
PE
6251 * dbusbind.c (signature_cat): New function.
6252 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6253 Do not overrun buffer; instead, report string overflow.
6254
9d1df220
PE
6255 * dispnew.c (add_window_display_history): Don't overrun buffer.
6256 Truncate instead; this is OK since it's just a log.
6257
33ef5c64
PE
6258 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6259 even if the time zone offset is outlandishly large.
6260 Don't mishandle offset == INT_MIN.
6261
66c6fdd5
PE
6262 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6263 when creating daemon; the previous buffer-overflow check was incorrect.
6264
d749b01b
PE
6265 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6266 which has the guts of the old verror function.
6267
b5cd1905
PE
6268 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6269 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6270
6e1a67fb
PE
6271 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6272 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6273 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6274 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6275 length of string rather than counting it via multiple sprintfs;
6276 that's simpler and more reliable.
c21721cc
PE
6277 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6278 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6279 sprintf, in case result does not fit in int.
6280
c57b67fc
PE
6281 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6282 (fontset_from_font): Print it.
6283
8a401434
PE
6284 * frame.c (tty_frame_count): Now printmax_t, not int.
6285 (make_terminal_frame, set_term_frame_name): Print it.
6286 (x_report_frame_params): In X, window IDs are unsigned long,
6287 not signed long, so print them as unsigned.
6288 (validate_x_resource_name): Check for implausibly long names,
6289 and don't assume name length fits in 'int'.
6290 (x_get_resource_string): Don't blindly alloca invocation name;
6291 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6292 not fit in int.
6293
6e1a67fb
PE
6294 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6295 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6296 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6297
0df02bf3
PE
6298 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6299 Use esprintf, not sprintf, in case result does not fit in int.
6300
48e30793
PE
6301 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6302 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6303 it as a large positive number.
6304 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6305 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6306
a66ff6d8
PE
6307 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6308 in case result does not fit in int.
6309
aca216ff
PE
6310 * print.c (float_to_string): Detect width overflow more reliably.
6311 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6312 buffer overrun. Don't assume list length fits in 'int'. Treat
6313 print length of 0 as 0, not as infinity; to be consistent with other
6314 uses of print length in this function. Don't overflow print length
6315 index. Don't assume hash table size fits in 'long', or that
6316 vectorlike size fits in 'unsigned long'.
6317
31c286f7
PE
6318 * process.c (make_process): Use printmax_t, not int, to format
6319 process-name gensyms.
6320
55e5faa1
PE
6321 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6322
80f2e268
PE
6323 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6324 to avoid potential buffer overrun.
6325
670741ab
PE
6326 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6327 if X resource line is longer than 512 bytes.
6328
b7163a50
PE
6329 * xfns.c (x_window): Make sprintf buffer a bit bigger
6330 to avoid potential buffer overrun.
6331
ae58ff1f
PE
6332 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6333
c43c8a6a
PE
6334 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6335
3f8236f4
PE
63362011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6337
53e9fe90 6338 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6339 Without these, Emacs silently mishandles large integers sometimes.
6340 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6341 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6342
6511acf2
PE
6343 * xdisp.c (try_window_id): Check Emacs fixnum range before
6344 converting to 'int'.
806add1d 6345
6511acf2 6346 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6347 Check that an Emacs fixnum is in range before assigning it to 'int'.
6348 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6349 values converted from Emacs fixnums.
6350 (Frecenter): Don't wrap around a line count if it is out of 'int'
6351 range; instead, treat it as an extreme value.
6352 (Fset_window_configuration, compare_window_configurations):
6353 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6354
6511acf2
PE
6355 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6356 that can exceed INT_MAX. Check that EMACS_INT value is in range
6357 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6358 (match_limit): Don't assume that a fixnum can fit in 'int'.
6359
6511acf2 6360 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6361 exceed INT_MAX.
6362
6511acf2 6363 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6364 (Fvertical_motion): Don't wrap around LINES values that don't fit
6365 in 'int'. Instead, treat them as extreme values. This is good
6366 enough for windows, which can't have more than INT_MAX lines anyway.
6367
fcb901a7
LMI
63682011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6369
0f2f6b6d
LMI
6370 * Require libxml/parser.h to avoid compilation warning.
6371
fcb901a7
LMI
6372 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6373
6374 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6375 since this reportedly can destroy thread storage.
6376
6e20a0d4
CY
63772011-08-30 Chong Yidong <cyd@stupidchicken.com>
6378
6379 * syntax.c (find_defun_start): Update all cache variables if
6380 exiting early (Bug#9401).
6381
148ae00e
EZ
63822011-08-30 Eli Zaretskii <eliz@gnu.org>
6383
f6cfbd8f
EZ
6384 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6385
148ae00e
EZ
6386 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6387 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6388 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6389
6390 * term.c (tty_append_glyph): New function.
6391 (produce_stretch_glyph): Static function and its prototype deleted.
6392
a66cfb1c
SM
6393 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6394 Add prototypes.
148ae00e 6395
c4a07a4c
PE
63962011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6397
6398 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6399 when checking :margin (Bug#9390).
6400 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6401 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6402 so that the name doesn't mislead. All uses changed.
6403
6bc8cd65
JB
64042011-08-28 Johan Bockgård <bojohan@gnu.org>
6405
6406 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6407 set_tty_hooks.
6408
dca4927e
EZ
64092011-08-27 Eli Zaretskii <eliz@gnu.org>
6410
6411 * xdisp.c (move_it_to): Don't bail out early when reaching
6412 position beyond to_charpos, if we are scanning backwards.
6413 (move_it_vertically_backward): When DY == 0, make sure we get to
6414 the first character in the line after the newline.
6415
f2cad773
PE
64162011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6417
6418 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6419 (ccl_driver): Do not generate an out-of-range pointer.
6420 (Fccl_execute_on_string): Remove unnecessary check for
6421 integer overflow, noted by Stefan Monnier in
6422 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6423 Remove a FIXME that didn't need fixing.
6424 Simplify the newly-introduced buffer reallocation code.
6425
0cae2cdb
JB
64262011-08-27 Juanma Barranquero <lekktu@gmail.com>
6427
6428 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6429
5fc295a4 64302011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6431
70c60eb2 6432 Integer and memory overflow issues (Bug#9196).
726e0ab1 6433
d31850da
PE
6434 * doc.c (get_doc_string): Rework so that
6435 get_doc_string_buffer_size is the actual buffer size, rather than
6436 being 1 less than the actual buffer size; this makes xpalloc more
6437 convenient.
6438
a69fbedb
PE
6439 * image.c (x_allocate_bitmap_record, cache_image):
6440 * xselect.c (Fx_register_dnd_atom):
6441 Simplify previous changes by using xpalloc.
6442
fe5c5d37
PE
6443 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6444 since either will do and ptrdiff_t is convenient with xpalloc.
6445
0065d054
PE
6446 * charset.c (charset_table_size)
6447 (struct charset_sort_data.priority): Now ptrdiff_t.
6448 (charset_compare): Don't overflow if priorities differ greatly.
6449 (Fsort_charsets): Don't assume list length fits in int.
6450 Check for size-calculation overflow when allocating sort data.
6451 (syms_of_charset): Allocate an initial charset table that is
6452 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6453
6454 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6455
6456 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6457 The actual value is always <= INT_MAX, and leaving it unsigned made
6458 overflow checking harder.
6459
6460 * dispextern.h (struct glyph_matrix.rows_allocated)
6461 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6462 with xpalloc. The values are still always <= INT_MAX.
6463
6464 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6465
6466 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6467 (SAFE_NALLOCA): New macro.
6468
6469 * region-cache.c (struct boundary.pos, find_cache_boundary)
6470 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6471 (set_cache_region, invalidate_region_cache)
6472 (revalidate_region_cache, know_region_cache, region_cache_forward)
6473 (region_cache_backward, pp_cache):
6474 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6475 so that ptrdiff_t * can be passed to xpalloc.
6476 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6477 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6478 (pp_cache): Don't assume cache_len fits in int.
6479 * region-cache.h: Adjust extern decls to match.
6480
6481 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6482 EMACS_INT, since either will do, for xpalloc.
6483
6484 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6485 (xnmalloc, xnrealloc, xpalloc): New functions.
6486
726e0ab1
PE
6487 * bidi.c (bidi_shelve_header_size): New constant.
6488 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6489 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6490
51f30bc5 6491 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6492 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6493 (overlay_strings):
6494 Don't update size of array until after memory allocation succeeds,
6495 because xmalloc/xrealloc may not return.
0065d054
PE
6496 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6497 now that we have proper integer overflow checking.
6498 (record_overlay_string, overlay_strings): Catch overflows when
6499 calculating size of overlay_str_buf.
726e0ab1 6500
0065d054
PE
6501 * callproc.c (Fcall_process): Check for size overflow when
6502 calculating size of args2.
6503 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6504 Normally we prefer signed values, but sticking with ptrdiff_t would
6505 require adding more-complicated checks.
726e0ab1
PE
6506
6507 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6508 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6509 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6510 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6511
6512 * character.c (Fstring): Check for size-calculation overflow.
6513
6514 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6515 unnecessary integer overflow. Check for size overflow.
6516 (encode_coding_object): Don't update size until xmalloc succeeds.
6517
6518 * composite.c (get_composition_id): Check for overflow in glyph
6519 length calculations.
6520
6521 Integer and memory overflow fixes for display code.
6522 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6523 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6524 (scrolling_window): Check for overflow in size calculations.
6525 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6526 Don't assume glyph table len fits in int.
6527 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6528 (row_table_size): Now ptrdiff_t, not int.
6529 (scrolling_window): Avoid overflow in size calculations.
6530 Don't update size until allocation succeeds.
6531 * fns.c (concat): Check for overflow in size calculations.
6532 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6533 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6534 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6535
6536 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6537 (get_doc_string): Check for size calculation overflow.
6538 Don't update size until allocation succeeds.
6539 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6540 EMACS_INT, where ptrdiff_t will do.
6541 (Fsubstitute_command_keys): Check for string overflow.
6542
6543 * editfns.c (set_time_zone_rule): Don't assume environment length
6544 fits in int.
6545 (message_length): Now ptrdiff_t, not int.
6546 (Fmessage_box): Don't update size until allocation succeeds.
6547 Don't assume message length fits in int.
6548 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6549
0065d054
PE
6550 * emacs.c (main): Do not reallocate argv, since there is a null at
6551 the end that can be overwritten, and this way there's no need to
6552 worry about size-calculation overflow.
6553 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6554
6555 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6556 alloc succeeds.
6557 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6558
6559 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6560 (x_set_scroll_bar_width, x_figure_window_size):
6561 Check for integer overflow.
6562 (x_set_alpha): Do not assume XINT fits in int.
6563
6564 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6565 This is for the members text_lines, text_cols, total_lines, total_cols,
6566 where the system imposes an 'int' limit.
6567
6568 * fringe.c (Fdefine_fringe_bitmap):
6569 Don't update size until alloc works.
6570
6571 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6572 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6573
6574 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6575 Check for size-calculation overflow.
6576 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6577 do, as we prefer signed integers.
6578 (id_to_widget.max_size, id_to_widget.used)
6579 (xg_store_widget_in_map, xg_remove_widget_from_map)
6580 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6581 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6582 Use and return ptrdiff_t, not int.
6583 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6584 * gtkutil.h: Change prototypes to match the above.
6585
6586 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6587 are duplicate now that they've been promoted to lisp.h.
6588 (x_allocate_bitmap_record, x_alloc_image_color)
6589 (make_image_cache, cache_image, xpm_load):
6590 Don't update size until alloc is done.
6591 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6592 (x_detect_edges):
3256efce 6593 Check for size calculation overflow.
726e0ab1
PE
6594 (ct_colors_allocated_max): New constant.
6595 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6596 overflow.
3256efce 6597
726e0ab1
PE
6598 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6599 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6600 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6601 Use ptrdiff_t, not int, to count maps.
6602 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6603 calculations. Don't update size until allocation succeeds.
6604 Redo calculations to avoid overflow.
726e0ab1
PE
6605 * keyboard.h: Change prototypes to match the above.
6606
6607 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6608 to count maps.
6609 (current_minor_maps): Check for size calculation overflow.
6610 * keymap.h: Change prototypes to match the above.
6611
6612 * lread.c (read1, init_obarray): Don't update size until alloc done.
6613
6614 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6615 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6616
726e0ab1
PE
6617 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6618 Now ptrdiff_t, not int.
6619 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6620 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6621
6622 * process.c (Fnetwork_interface_list): Check for overflow
6623 in size calculation.
6624
6625 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6626
6627 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6628 overflow. Don't bother calling xmalloc when xrealloc will do.
6629
6630 * search.c (Freplace_match): Check for size calculation overflow.
6631 (Fset_match_data): Don't assume list lengths fit in 'int'.
6632
6633 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6634 for command line length. Do not attempt to address one before the
6635 beginning of an array, as that's not portable.
6636
6637 * term.c (max_frame_lines): Remove; unused.
6638 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6639 not int.
6640 (encode_terminal_code, calculate_costs): Check for size
6641 calculation overflow.
6642 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6643 table lengths and related sizes. Don't update size until alloc
6644 done. Redo calculations to avoid overflow.
6645 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6646
6647 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6648 subtracting pointers.
6649 (gobble_line): Check for overflow more carefully. Don't update size
6650 until alloc done.
6651
6652 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6653 Don't update size until alloc done.
6654 Redo size calculations to avoid overflow.
6655 Check for size calculation overflow.
0065d054 6656 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6657
6658 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6659 Use ptrdiff_t, not int, for sizes.
6660 (store_mode_line_noprop_char): Don't update size until alloc done.
6661
0065d054
PE
6662 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6663 Use ptrdiff_t, not int, for sizes.
6664 (Finternal_make_lisp_face, cache_face):
6665 Check for size calculation overflow.
6666 (cache_face): Treat size calculation overflows as if they were
6667 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6668
6669 * xfns.c (x_encode_text, x_set_name_internal)
6670 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6671 sizes, since they can exceed INT_MAX in size. Check for size
6672 calculation overflow.
6673
0065d054
PE
6674 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6675 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6676 Don't update size until alloc done.
6677
0065d054 6678 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6679 as sprintf is limited to int lengths.
1d526e2f 6680
252c5ee1
PE
6681 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6682 (X_LONG_MIN): New macros.
864d7ce7
PE
6683 Use them to make the following changes clearer.
6684 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6685 This change doesn't affect the value now, but it may help remind
6686 future maintainers not to raise the value too much later.
6687 (SELECTION_QUANTUM): Remove, replacing with ...
6688 (selection_quantum): ... new function, which avoids overflow.
6689 All uses changed.
6690 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6691 assumption that selection length fits in 'int'.
6692 (x_reply_selection_request, x_handle_selection_request)
6693 (x_get_window_property, receive_incremental_selection)
6694 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6695 (lisp_data_to_selection_data, clean_local_selection_data):
6696 Use ptrdiff_t, not int, to record length of selection.
6697 (x_reply_selection_request, x_get_window_property)
6698 (receive_incremental_selection, x_property_data_to_lisp):
6699 Redo calculations to avoid overflow.
6700 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6701 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6702 something.
6703 (x_get_window_property, receive_incremental_selection)
6704 (lisp_data_to_selection_data, x_property_data_to_lisp):
6705 Check for size-calculation overflow.
6706 (x_get_window_property, receive_incremental_selection)
6707 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6708 Don't store size until memory allocation succeeds.
6709 (x_get_window_property): Plug memory leak on memory exhaustion.
6710 Don't double-block input; malloc is safe here. Don't assume 2**34
6711 - 4 fits in unsigned long. Add an xassert to check
6712 XGetWindowProperty overflow. Be more careful about overflow
6713 calculations, and distinguish size from memory overflow better.
6714 (receive_incremental_selection): When tracing, don't assume
6715 unsigned int is less than INT_MAX.
6716 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6717 harmful) conversions of unsigned short to int.
6718 (lisp_data_to_selection_data): Don't assume that integers
6719 in the range -65535 through -1 fit in an X unsigned short.
6720 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6721 result parameters unless successful. Rely on cons_to_unsigned
6722 to report problems with elements; the old code wasn't right anyway.
6723 (x_check_property_data): Check for int overflow; we cannot use
6724 a wider type due to X limits.
6725 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6726
726e0ab1 6727 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6728
0065d054
PE
6729 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6730 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6731 (x_color_cells): Don't store size until memory allocation succeeds.
6732 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6733 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6734 (x_term_init): Don't assume length fits in int (sprintf is limited
6735 to int size).
bc18e09d 6736
ebfa62c0
PE
6737 Use ptrdiff_t for composition IDs.
6738 * character.c (lisp_string_width):
6739 * composite.c (composition_table_size, n_compositions)
6740 (get_composition_id, composition_gstring_from_id):
6741 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6742 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6743 * window.c (Frecenter):
6744 Use ptrdiff_t, not int, for composition IDs.
6745 * composite.c (get_composition_id): Check for integer overflow.
6746 * composite.h: Adjust prototypes to match the above changes.
6747
d3411f89
PE
6748 Use ptrdiff_t for hash table indexes.
6749 * category.c (hash_get_category_set):
6750 * ccl.c (ccl_driver):
6751 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6752 * coding.c (coding_system_charset_list, detect_coding_system):
6753 * coding.h (struct coding_system.id):
6754 * composite.c (get_composition_id, gstring_lookup_cache):
6755 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6756 * image.c (xpm_get_color_table_h):
6757 * lisp.h (hash_lookup, hash_put):
6758 * minibuf.c (Ftest_completion):
6759 Use ptrdiff_t for hash table indexes, not int (which is too
6760 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6761 32-bit --with-wide-int hosts).
6762
e097a6fa
PE
6763 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6764 Add a FIXME comment about memory leaks.
6765 (syms_of_charset): Don't assume xmalloc returns.
6766
5637687f
PE
6767 Don't assume that stated character widths fit in int.
6768 * character.c (Fchar_width, c_string_width, lisp_string_width):
6769 * character.h (CHAR_WIDTH):
6770 * indent.c (MULTIBYTE_BYTES_WIDTH):
6771 Use sanitize_char_width to avoid undefined and/or bad behavior
6772 with outlandish widths.
a66cfb1c 6773 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6774 now that we have two such functions. All uses changed.
6775 (sanitize_char_width): New inline function.
6776
a2271ba2
PE
6777 Don't assume that tab-width fits in int.
6778 * character.h (sanitize_width): New inline function.
6779 (SANE_TAB_WIDTH): New macro.
6780 (ASCII_CHAR_WIDTH): Use it.
6781 * indent.c (sane_tab_width): Remove. All uses replaced by
6782 SANE_TAB_WIDTH (current_buffer).
6783 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6784
18c52557
PE
6785 * fileio.c: Integer overflow issues with file modes.
6786 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6787
caeeedc1
PE
6788 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6789 Remove unreachable code.
6790 (read_hex, load_charset_map_from_file): Check for integer overflow.
6791
6df6ae42 6792 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6793 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6794 (x_send_scroll_bar_event): Likewise. Check that the size does not
6795 exceed limits imposed by XClientMessageEvent, as well as the usual
6796 ptrdiff_t and size_t limits.
6797
b13995db
PE
6798 * keyboard.c: Overflow, signedness and related fixes.
6799 (make_lispy_movement): Use same integer type in forward decl
6800 that is used in the definition.
6801 (read_key_sequence, keyremap_step):
6802 Change bufsize argument back to int, undoing my 2011-03-30 change.
6803 We prefer signed types, and int is wide enough here.
6804 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6805 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6806 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6807 length, not size_t. Use ptrdiff_t for index, not int.
6808 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6809 possibility of integer overflow.
6810
13464394
PE
6811 Overflow, signedness and related fixes for images.
6812
6813 * dispextern.h (struct it.stack[0].u.image.image_id)
6814 (struct_it.image_id, struct image.id, struct image_cache.size)
6815 (struct image_cache.used, struct image_cache.ref_count):
6816 * gtkutil.c (update_frame_tool_bar):
6817 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6818 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6819 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6820 * nsmenu.m (update_frame_tool_bar):
6821 * xdisp.c (calc_pixel_width_or_height):
6822 * xfns.c (image_cache_refcount):
6823 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6824 on typical 64-bit hosts.
6825
6826 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6827 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6828 Omit unnecessary casts to int.
6829 (parse_image_spec): Check that integers fall into 'int' range
6830 when the callers expect that.
6831 (image_ascent): Redo ascent calculation to avoid int overflow.
6832 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6833 (lookup_image): Remove unnecessary tests.
6834 (xbm_image_p): Locals are now of int, not EMACS_INT,
6835 since parse_image_check makes sure they fit into int.
6836 (png_load, gif_load, svg_load_image):
6837 Prefer int to unsigned where either will do.
6838 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6839 old tiff_error_handler and tiff_warning_handler.
6840 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6841 stack buffer overflows. It uses only the features of vsnprintf
6842 that are common to both POSIX and native Microsoft.
6843 (tiff_error_handler, tiff_warning_handler): Use it.
6844 (tiff_load, gif_load, imagemagick_load_image):
6845 Don't assume :index value fits in 'int'.
6846 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6847 (imagemagick_load_image): Check that crop parameters fit into
6848 the integer types that MagickCropImage accepts. Don't assume
6849 Vimagemagick_render_type has a nonnegative value. Don't assume
6850 size_t fits in 'long'.
6851 (gs_load): Use printmax_t to print the widest integers possible.
6852 Check for integer overflow when computing image height and width.
6853
c11821d4
EZ
68542011-08-26 Eli Zaretskii <eliz@gnu.org>
6855
6856 * xdisp.c (redisplay_window): Don't force window start if point
6857 will be invisible in the resulting window. (Bug#9324)
6858
0c95fcf7
EZ
68592011-08-25 Eli Zaretskii <eliz@gnu.org>
6860
6861 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6862 the display spec is of the form `(space ...)'.
6863 (handle_display_spec): Return the value returned by
6864 handle_single_display_spec, not just 1 or zero.
6865 (handle_single_display_spec): If the display spec is of the form
6866 `(space ...)', and specifies display in the text area, return 2
6867 rather than 1.
fee65a97 6868 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6869 accurately, and prefer exact match for point under bidi.
6870 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6871
6872 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6873 into disp_prop; all users changed.
6874
6875 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6876 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6877 for the text covered by the display property.
6878
e4ed06f1
CY
68792011-08-25 Chong Yidong <cyd@stupidchicken.com>
6880
6881 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6882 Change return value to nil.
6883 (Frecord_buffer): Delete unused function.
6884
f67cdd7f
EZ
68852011-08-24 Eli Zaretskii <eliz@gnu.org>
6886
5980d4c6
EZ
6887 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6888 buffers, return left-to-right.
8610fe8b
EZ
6889 (set_cursor_from_row): Consider candidate row a win if its glyph
6890 represents a newline and point is on that newline. Fixes cursor
6891 positioning on the newline at EOL of R2L text within L2R
6892 paragraph, and vice versa.
6893 (try_cursor_movement): Check continued rows, in addition to
6894 continuation rows. Fixes unwarranted scroll when point enters a
6895 continued line of R2L text within an L2R paragraph, or vice versa.
6896 (cursor_row_p): Consider the case of point being equal to
6897 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6898 from the end of a short line to the beginning of a continued line
6899 of R2L text within L2R paragraph.
6900 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6901 composed characters.
5980d4c6 6902
f67cdd7f
EZ
6903 * bidi.c (bidi_check_type): Use xassert.
6904 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6905 members.
6906
bca633fb
EZ
69072011-08-23 Eli Zaretskii <eliz@gnu.org>
6908
6909 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6910 a character.
6911
4a5885a7
CY
69122011-08-23 Chong Yidong <cyd@stupidchicken.com>
6913
6914 * nsfont.m (ns_otf_to_script): Fix typo.
6915
0902a04e
KH
69162011-08-22 Kenichi Handa <handa@m17n.org>
6917
6918 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6919 extra slot even if the purpose is char-code-property-table.
6920
1a2e6670
EZ
69212011-08-23 Eli Zaretskii <eliz@gnu.org>
6922
8ddde651
EZ
6923 * xdisp.c (redisplay_window): When computing centering_position,
6924 account for the height of the header line. (Bug#8874)
6925
425cc014
EZ
6926 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6927 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6928 candidate is selected by the mouse, and that candidate has a
6929 composed character under the mouse.
6930
1a2e6670
EZ
6931 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6932 coordinates reported by pos-visible-in-window-p for a composed
6933 character in column zero.
6934
8b76d6f8
SM
69352011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6936
6937 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6938
dac347dd
EZ
69392011-08-22 Eli Zaretskii <eliz@gnu.org>
6940
6941 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6942 consider it a hit if to_charpos is anywhere in the range of the
6943 composed buffer positions.
6944
e013fb34
CY
69452011-08-22 Chong Yidong <cyd@stupidchicken.com>
6946
6947 * image.c (gif_load): Don't assume that each subimage has the same
6948 dimensions as the base image. Handle disposal method that is
6949 "undefined" by the gif spec (Bug#9335).
6950
bd1ba3e8
CY
69512011-08-20 Chong Yidong <cyd@stupidchicken.com>
6952
6953 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6954 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6955
54a1215b
EZ
69562011-08-19 Eli Zaretskii <eliz@gnu.org>
6957
823564e5
EZ
6958 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6959 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6960 from an Org mode buffer to a Speedbar frame.
6961
54a1215b
EZ
6962 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6963 a composition, take its buffer position from IT->cmp_it.charpos.
6964 Fixes cursor positioning at the beginning of a line that begins
6965 with a composed character.
6966
9778ebcc
EZ
69672011-08-18 Eli Zaretskii <eliz@gnu.org>
6968
0be6ee06
EZ
6969 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6970 character bidirectional type, use STRONG_L instead. Fixes crashes
6971 in a buffer produced by `describe-categories'.
6972
9778ebcc
EZ
6973 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6974 members before the level stack, so they would be saved and
6975 restored when copying iterator state. Fixes incorrect reordering
6976 around TABs covered by display properties.
6977
156bffbe
AS
69782011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6979
6b02f655 6980 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6981
72ad093b
CY
69822011-08-17 Chong Yidong <cyd@stupidchicken.com>
6983
6984 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6985 (internal_condition_case_2, internal_condition_case_n):
6986 Remove unnecessary aborts (Bug#9081).
72ad093b 6987
35774242
EZ
69882011-08-17 Eli Zaretskii <eliz@gnu.org>
6989
6990 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6991 has no `load' handler, try opening the file locally. (Bug#9311)
6992
db76dd85
KB
69932011-08-16 Ken Brown <kbrown@cornell.edu>
6994
6995 * gmalloc.c: Expand comment.
6996
b215eee5
EZ
69972011-08-16 Eli Zaretskii <eliz@gnu.org>
6998
6999 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7000 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7001
a4579d33
KB
70022011-08-16 Ken Brown <kbrown@cornell.edu>
7003
7004 Fix memory allocation problems in Cygwin build (Bug#9273).
7005
7006 * unexcw.c ( __malloc_initialized): Declare external variable.
7007 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7008
8b76d6f8
SM
7009 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7010 New variables.
a4579d33
KB
7011 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7012 dumped emacs.
7013 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7014 in the static heap.
7015 [CYGWIN] (special_realloc): New function.
7016 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7017 requests to realloc storage in the static heap.
7018
3ebec551
PE
70192011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7020
7021 * bidi.c (bidi_initialize): Remove unused local.
7022
9fd8be00
EZ
70232011-08-15 Eli Zaretskii <eliz@gnu.org>
7024
6b02f655
SM
7025 * bidimirror.h:
7026 * biditype.h: Remove file.
7027 * makefile.w32-in ($(BLD)/bidi.$(O)):
7028 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7029
7030 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7031
7032 * chartab.c: Improve commentary for the uniprop_table API.
7033
32413314
EZ
7034 * bidi.c (bidi_paragraph_init): Support zero value of
7035 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7036 (bidi_initialize): Use uniprop_table instead of including
7037 biditype.h and bidimirror.h.
32413314 7038
9fd8be00
EZ
7039 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7040 coordinates of the iterator when restoring from ppos_it.
7041 (Bug#9296)
7042
5cf2b69b
KH
70432011-08-14 Kenichi Handa <handa@m17n.org>
7044
7045 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7046 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7047
daf17d00
EZ
70482011-08-14 Eli Zaretskii <eliz@gnu.org>
7049
7050 * xdisp.c (move_it_in_display_line_to): Don't invoke
7051 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7052 ppos_it. Fixes vertical cursor motion when line beginning is
7053 covered by an image. (Bug#9296)
7054
08e3161a
JD
70552011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7056
7057 * nsterm.h (ns_run_ascript): Declare.
7058 (NSAPP_DATA2_RUNASSCRIPT): Define.
7059
7060 * nsfns.m (as_script, as_result, as_status): New static variables.
7061 (ns_run_ascript): New function.
5e617bc2 7062 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7063 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7064 the event loop. Get status from as_status (Bug#7276).
7065
7066 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7067 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7068 the event loop (Bug#7276).
7069
a3720aa2
AS
70702011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7071
7072 * gnutls.c (QCgnutls_bootprop_priority)
7073 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7074 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7075 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7076 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7077 (QCgnutls_bootprop_verify_hostname_error)
7078 (QCgnutls_bootprop_callbacks_verify): Rename from
7079 Qgnutls_bootprop_..., all uses changed.
7080
7081 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7082 uses changed.
7083
0a0d27fb
PE
70842011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7085
19d5c50c
PE
7086 * xfaces.c (Qframe_set_background_mode): Now static.
7087 * dispextern.h (Qframe_set_background_mode): Remove decl.
7088
0a0d27fb
PE
7089 * process.c (Fnetwork_interface_info): Declare local only if needed.
7090
377538cb
JD
70912011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7092
7093 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7094 (Fnetwork_interface_list): Allocate in increments of bytes instead
7095 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7096 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7097 sockaddr.
7098 (struct ifflag_def): notrailers is smart on OSX.
7099 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7100 Get hardware address with getifaddrs if available.
7101
08fff70c
EZ
71022011-08-12 Eli Zaretskii <eliz@gnu.org>
7103
7104 * xdisp.c (iterate_out_of_display_property): xassert that
7105 IT->position is set to within IT->object's boundaries. Break from
7106 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7107 when IT->position is set up wrongly due to some bug.
7108 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7109 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7110 entry. Force push_it to save on the stack the current
7111 buffer/string position, to be restored by pop_it. Fix flags in
7112 the iterator structure wrt the object coming from a display
7113 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7114 properties. (Bug#9284)
7115
7be1c708 71162011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7117
7be1c708
CY
7118 * fontset.c (fontset_get_font_group): Add proper type checks.
7119 (Bug#9172)
aac0c6e3 7120
7be1c708 71212011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7122
7be1c708
CY
7123 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7124 and LC_VERSION_MIN_MACOSX.
7125 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7126 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7127
97bb72a6
EZ
71282011-08-08 Eli Zaretskii <eliz@gnu.org>
7129
7130 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7131 no-display-properties-and-no-overlays under bidi display.
7132 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7133 properties and overlays.
97bb72a6 7134
d5617611
CY
71352011-08-08 Chong Yidong <cyd@stupidchicken.com>
7136
37e11a63
CY
7137 * editfns.c (Fset_time_zone_rule): Document relationship with the
7138 setenv function.
7139
d5617611
CY
7140 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7141 the font entity extracted from the cache (Bug#8109).
7142
58872834
CY
71432011-08-07 Chong Yidong <cyd@stupidchicken.com>
7144
7145 * composite.c (autocmp_chars): Don't reset point. That is done by
7146 restore_point_unwind (Bug#5984).
7147
75bfc667
JL
71482011-08-07 Juri Linkov <juri@jurta.org>
7149
7150 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7151 to show the arg `TIME' instead of `TIMEVAL'.
7152
d1410150
EZ
71532011-08-06 Eli Zaretskii <eliz@gnu.org>
7154
7155 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7156 display property strides EOL and includes a newline, as in
7157 longlines-mode. (Bug#9254)
75b771e4
EZ
7158 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7159 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7160
7161 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7162 is non-zero, even if the data buffer is NULL. Fixes a crash in
7163 vertical-motion with longlines-mode. (Bug#9254)
7164
35928349
EZ
71652011-08-05 Eli Zaretskii <eliz@gnu.org>
7166
ec7cc85b
EZ
7167 * bidi.c <bidi_cache_total_alloc>: Now static.
7168 (bidi_initialize): Initialize bidi_cache_total_alloc.
7169
8b76d6f8 7170 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7171 cache. (Bug#9221)
7172
7173 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7174 amount allocated this far in `bidi_cache_total_alloc'.
7175 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7176 non-zero, only free the data buffer without restoring the cache
7177 contents. All callers changed.
7178
7179 * dispextern.h (bidi_unshelve_cache): Update prototype.
7180
7181 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7182 (move_it_in_display_line, move_it_to)
7183 (move_it_vertically_backward, move_it_by_lines): Replace the call
7184 to xfree to an equivalent call to bidi_unshelve_cache.
7185 (move_it_in_display_line_to): Fix logic of returning
412b6358 7186 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7187
e2e2423b
EZ
71882011-08-05 Eli Zaretskii <eliz@gnu.org>
7189
7190 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7191 came from a string character with a `cursor' property. (Bug#9229)
7192
ae9e757a
JD
71932011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7194
7195 * Makefile.in (LIB_PTHREAD): New variable.
7196 (LIBES): Add LIB_PTHREAD (Bug#9216).
7197
7198 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7199 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7200
213bd7f2
AS
72012011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7202
6b02f655 7203 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7204
99aaf75f
JD
72052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7206
7207 * xterm.c (x_find_topmost_parent): New function.
7208 (x_set_frame_alpha): Find topmost parent window with
7209 x_find_topmost_parent and set the property there also (bug#9181).
7210 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7211
c74e9d86
PE
72122011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7213
7214 * callproc.c (Fcall_process): Avoid vfork clobbering
7215 the local vars buffer, coding_systems, current_dir.
7216
640c8776
SM
72172011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7218
7219 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7220
f26d0e4c
PE
72212011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7222
8a10d76c
PE
7223 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7224 so that it is not optimized away.
7225
f26d0e4c
PE
7226 * xdisp.c (compute_display_string_pos): Remove unused local.
7227
55439c61
EZ
72282011-08-02 Eli Zaretskii <eliz@gnu.org>
7229
7230 Fix slow cursor motion and scrolling in large buffers with
7231 selective display, like Org Mode buffers. (Bug#9218)
7232
7233 * dispextern.h (struct bidi_it): New member disp_prop_p.
7234
7235 * xdisp.c: Remove one-slot cache of display string positions.
7236 (compute_display_string_pos): Accept an additional argument
5e617bc2 7237 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7238 for a display string or property. If found, set DISP_PROP_P
7239 non-zero.
7240
7241 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7242 DISP_PROP_P, and pass it to compute_display_string_pos.
7243 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7244 non-zero. All callers of bidi_fetch_char changed.
7245
fb33fa43
SM
72462011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7247
7248 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7249
b099e063
DM
72502010-12-03 Don March <don@ohspite.net>
7251
7252 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7253 last character M-[char] is translated to ESC [char] (bug#7541).
7254
5cc7f7af
KH
72552011-08-02 Kenichi Handa <handa@m17n.org>
7256
d0fffa3f 7257 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7258
7259 * chartab.c (uniprop_table): Make it non-static.
7260
525d5e6e
EZ
72612011-08-01 Eli Zaretskii <eliz@gnu.org>
7262
7263 * xdisp.c (forward_to_next_line_start): Accept additional argument
7264 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7265 on the newline.
7266 (reseat_at_next_visible_line_start): Use the bidi iterator state
7267 returned by forward_to_next_line_start to restore the state of
7268 it->bidi_it after backing up to previous newline. (Bug#9212)
7269
31011111
AS
72702011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7271
7272 * regex.c (re_comp): Protoize.
7273 (re_exec): Fix return type.
7274 (regexec): Fix type of `ret'. (Bug#9203)
7275
476371c4
PE
72762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7277
e5d76069
PE
7278 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7279 This is needed if max-image-size is a floating-point number.
7280
9a79b20c
AS
72812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7282
7283 * print.c (print_object): Print empty symbol as ##.
7284
7285 * lread.c (read1): Read ## as empty symbol.
7286
d8c2fa78
AA
72872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7288
7289 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7290 setting frame foreground color (Bug#9175).
7291 (x_set_background_color): Likewise.
7292
ffe57a7a
AA
7293 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7294 contents (Bug#9176).
7295 (EmacsTooltip -init): Remove bezels and add shadows to
7296 tooltip windows.
7297
bf3492a5
AA
7298 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7299 or scroll bar (Bug#8470).
7300
d55e9c53
AA
7301 * nsfont.m (nsfont_open): Remove assignment to voffset and
7302 unnecessary vars hshink, expand, hd, full_height, min_height.
7303 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7304
7305 * nsterm.h (nsfont_info): Remove voffset field.
7306
d8c2fa78 73072011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7308
7309 Implement strike-through and overline on NextStep (Bug#8863).
7310
7311 * nsfont.m (nsfont_open): Use underline position provided by font,
7312 instead of hard-coded value of 2.
7313 (nsfont_draw): Call ns_draw_text_decoration instead.
7314
7315 * nsterm.h: Add declaration for ns_draw_text_decoration.
7316
7317 * nsterm.m (ns_draw_text_decoration): New function for drawing
7318 underline, overline, and strike-through.
7319 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7320 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7321 accommodate underlining, etc.
4843aac3 7322
4cc60b9b
EZ
73232011-07-28 Eli Zaretskii <eliz@gnu.org>
7324
bc7ece87
EZ
7325 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7326 default.
4cc60b9b 7327
476371c4
PE
73282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7329
66606eea
PE
7330 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7331 Without this fix, if a signal arrives just after memory fills up,
7332 'malloc' might be invoked reentrantly.
7333
476371c4
PE
7334 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7335 In other words, assume that every image size is allowed, on non-X
7336 hosts. This assumption is probably wrong, but it lets Emacs compile.
7337
f3fcc40d
AS
73382011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7339
7340 * regex.c (re_iswctype): Convert return values to boolean.
7341
350c992f
EZ
73422011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7343
7344 * xdisp.c (compute_display_string_pos): Don't use cached display
7345 string position if the buffer had its restriction changed.
7346 (Bug#9184)
7347
5266b4bb
PE
73482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7349
7350 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7351
2573a837 73522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7353
41f55ccd 7354 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7355
39e378da
PE
7356 * bidi.c: Integer size and overflow fixes.
7357 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7358 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7359 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7360 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7361 (bidi_find_other_level_edge):
7362 Use ptrdiff_t instead of EMACS_INT where either will do.
7363 This works better on 32-bit hosts configured --with-wide-int.
7364 (bidi_cache_ensure_space): Check for size-calculation overflow.
7365 Use % rather than repeated addition, for better worst-case speed.
7366 Don't set bidi_cache_size until after xrealloc returns, because it
7367 might not return.
7368 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7369 (bidi_cache_ensure_space): Also check that the bidi cache size
7370 does not exceed that of the largest Lisp string or buffer. See Eli
7371 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7372
5e927815
PE
7373 * alloc.c (__malloc_size_t): Remove.
7374 All uses replaced by size_t. See Andreas Schwab's note
7375 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7376
ca4aa935
PE
7377 * image.c: Improve checking for integer overflow.
7378 (check_image_size): Assume that f is nonnull, since
7379 it is always nonnull in practice. This is one less thing to
7380 worry about when checking for integer overflow later.
7381 (x_check_image_size): New function, which checks for integer
7382 overflow issues inside X.
7383 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7384 This removes the need for a memory_full check.
7385 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7386 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7387 (xbm_read_bitmap_data): Change locals back to 'int', since
7388 their values must fit in 'int'.
7389 (xpm_load_image, png_load, tiff_load):
7390 Invoke x_create_x_image_and_pixmap earlier,
7391 to avoid much needless work if the image is too large.
7392 (tiff_load): Treat overly large images as if
7393 x_create_x_image_and_pixmap failed, not as malloc failures.
7394 (gs_load): Use x_check_image_size.
7395
5f8f9cc2
PE
7396 * gtkutil.c: Omit integer casts.
7397 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7398 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7399
5adf60bc
PE
7400 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7401
c8907a93
PE
7402 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7403 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7404 would wrongly return t on a 64-bit host.
7405
e3c25c68
PE
7406 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7407 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7408 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7409 and therefore cause GCC to emit a bogus diagnostic in some cases.
7410
3f791afe
PE
7411 * image.c: Integer signedness and overflow and related fixes.
7412 This is not an exhaustive set of fixes, but it's time to
7413 record what I've got.
7414 (lookup_pixel_color, check_image_size): Remove redundant decls.
7415 (check_image_size): Don't assume that arbitrary EMACS_INT values
7416 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7417 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7418 (tiff_load, imagemagick_load_image):
7419 Check for overflow in size calculations.
7420 (x_create_x_image_and_pixmap): Remove unnecessary test for
7421 xmalloc returning NULL; that can't happen.
7422 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7423 (xpm_color_bucket): Use better integer hashing function.
7424 (xpm_cache_color): Don't possibly over-allocate memory.
7425 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7426 (gif_memory_source):
7427 Use ptrdiff_t, not int or size_t, to record sizes.
7428 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7429 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7430 either works, as we prefer signed integers.
7431 (tiff_read_from_memory, tiff_write_from_memory):
7432 Return tsize_t, not size_t, since that's what the TIFF API wants.
7433 (tiff_read_from_memory): Don't fail simply because the read would
7434 go past EOF; instead, return a short read.
7435 (tiff_load): Omit no-longer-needed casts.
7436 (Fimagemagick_types): Don't assume size fits into 'int'.
7437
3cc5a532
PE
7438 Improve hashing quality when configured --with-wide-int.
7439 * fns.c (hash_string): New function, taken from sxhash_string.
7440 Do not discard information about ASCII character case; this
7441 discarding is no longer needed.
7442 (sxhash-string): Use it. Change sig to match it. Caller changed.
7443 * lisp.h: Declare it.
7444 * lread.c (hash_string): Remove, since we now use fns.c's version.
7445 The fns.c version returns a wider integer if --with-wide-int is
7446 specified, so this should help the quality of the hashing a bit.
7447
b312a492
PE
7448 * emacs.c: Integer overflow minor fix.
7449 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7450 Define only if GNU_LINUX.
7451 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7452
dfd153ae
PE
7453 * dispnew.c: Integer signedness and overflow fixes.
7454 Remove unnecessary forward decls, that were a maintenance hassle.
7455 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7456 All uses changed.
7457 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7458 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7459 (prepare_desired_row, line_draw_cost):
7460 Use int, not unsigned, where either works.
7461 (save_current_matrix, restore_current_matrix):
7462 Use ptrdiff_t, not size_t, where either works.
7463 (init_display): Check for overflow more accurately, and without
7464 relying on undefined behavior.
7465
a81d11a3
PE
7466 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7467 Remove, replacing with the new symbols in lisp.h. All uses changed.
7468 * fileio.c (make_temp_name):
7469 * filelock.c (lock_file_1, lock_file):
7470 * xdisp.c (message_dolog):
7471 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7472 Use pMd etc. instead.
7473 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7474 replacing the pWIDE etc. symbols removed from editfns.c.
7475
3300e6fd
PE
7476 * keyboard.h (num_input_events): Now uintmax_t.
7477 This is (very slightly) less likely to mess up due to wraparound.
7478 All uses changed.
7479
fd05c7e9
PE
7480 * buffer.c: Integer signedness fixes.
7481 (alloc_buffer_text, enlarge_buffer_text):
7482 Use ptrdiff_t rather than size_t when either will do, as we prefer
7483 signed integers.
7484
903fe15d
PE
7485 * alloc.c: Integer signedness and overflow fixes.
7486 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7487 (__malloc_size_t): Default to size_t, not to int.
7488 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7489 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7490 Prefer ptrdiff_t to size_t when either would do, as we prefer
7491 signed integers.
7492 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7493 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7494 Now const. Initialize with values that are in range even if char
7495 is signed.
7496 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7497 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7498 These functions do the right thing with sizes > 2**32.
7499 (check_depth): Now ptrdiff_t, not int.
7500 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7501 Adjust to new way of storing sizes. Check for size overflow bugs
7502 in rest of code.
7503 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7504 slightly wrong anyway, as it missed one instance of
7505 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7506 (refill_memory_reserve): Omit needless cast to size_t.
7507 (mark_object_loop_halt): Mark as externally visible.
7508
ac82cc6a
PE
7509 * xselect.c: Integer signedness and overflow fixes.
7510 (Fx_register_dnd_atom, x_handle_dnd_message):
7511 Use ptrdiff_t, not size_t, since we prefer signed.
7512 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7513 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7514 x_dnd_atoms_size and x_dnd_atoms_length.
7515
c2d1e36d
PE
7516 * doprnt.c: Prefer signed to unsigned when either works.
7517 * eval.c (verror):
7518 * doprnt.c (doprnt):
7519 * lisp.h (doprnt):
7520 * xdisp.c (vmessage):
7521 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7522 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7523 prefer signed arithmetic to avoid comparison confusion.
7524 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7525 but is a bit tricky.
7526
0e926e56
PE
7527 Assume freestanding C89 headers, string.h, stdlib.h.
7528 * data.c, doprnt.c, floatfns.c, print.c:
7529 Include float.h unconditionally.
7530 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7531 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7532 * regex.c: Likewise for stddef.h, string.h.
7533 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7534 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7535 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7536 (STDC_HEADERS): Remove obsolete defines.
7537 * sysdep.c: Include limits.h unconditionally.
7538
9cfdb3ec
PE
7539 Assume support for memcmp, memcpy, memmove, memset.
7540 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7541 * regex.c (memcmp, memcpy):
7542 Remove; we assume C89 now.
7543
7544 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7545 (__malloc_safe_bcopy): Remove; no longer needed.
7546
cf950e6b 7547 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7548 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7549 well either way, and we prefer signed to unsigned.
7550
dbf38e02
LMI
75512011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7552
7553 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7554 closes the connection while we're reading (bug#9182).
7555
d6f0886c 75562011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7557
d6f0886c
JD
7558 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7559 are specified (Bug#9168).
24e0f6b1 7560
2eb1f9e6
PE
75612011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7562
7563 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7564 Found by GCC static checking and --with-wide-int on a 32-bit host.
7565
22381272 75662011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7567
7568 * xdisp.c (compute_display_string_pos): Fix logic of caching
7569 previous display string position. Initialize cached_prev_pos to
7570 -1. Fixes slow-down at the beginning of a buffer.
7571
f25e39b4
EZ
75722011-07-24 Eli Zaretskii <eliz@gnu.org>
7573
7574 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7575 for attrs[LFACE_FONTSET_INDEX].
7576
04c4b52e
PE
75772011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7578
7579 * xml.c (parse_region): Remove unused local
7580 that was recently introduced.
7581
c1734fbd
EZ
75822011-07-23 Eli Zaretskii <eliz@gnu.org>
7583
be18c5a5
EZ
7584 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7585 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7586
c1734fbd
EZ
7587 * xdisp.c (move_it_in_display_line_to): Record the best matching
7588 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7589 exit if none of the characters scanned was an exact match.
7590 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7591 when exact match is impossible due to invisible text, and the
7592 lines are truncated.
7593
a258d627
JD
75942011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7595
7596 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7597 for OSX >= 10.7.
7598
b6d5a689
EZ
75992011-07-22 Eli Zaretskii <eliz@gnu.org>
7600
0f74f785
EZ
7601 Fix a significant slow-down of cursor motion with C-n, C-p,
7602 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7603 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7604 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7605 (next_element_from_buffer): Call compute_stop_pos_backwards to
7606 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7607 base_level_stop.
7608 (reseat): Don't look for prev_stop, as that could mean a very long
7609 run.
7610 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7611 <cached_disp_overlay_modiff>: Cache for last found display string
7612 position.
551918c1 7613 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7614 about the same buffer in the same area of character positions, and
7615 the buffer wasn't changed since the time the display string
7616 position was cached.
551918c1 7617
b2d0c91a
EZ
76182011-07-22 Eli Zaretskii <eliz@gnu.org>
7619
7620 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7621 is an integer, which is important for empty lines. (Bug#9149)
7622
043604ee
CY
76232011-07-22 Chong Yidong <cyd@stupidchicken.com>
7624
7625 * frame.c (Fmodify_frame_parameters): In tty case, update the
7626 default face if necessary (Bug#4238).
7627
da4adb04
CY
76282011-07-21 Chong Yidong <cyd@stupidchicken.com>
7629
7630 * editfns.c (Fstring_to_char): No need to explain what a character
7631 is in the docstring (Bug#6576).
7632
9abd0532
LMI
76332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7634
7635 * xml.c (parse_region): Make sure we always return a tree.
7636
36881d16
HK
76372011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7638
7639 * xml.c (parse_region): If a document contains only comments,
7640 return that, too.
7641
1e98674d
LMI
76422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7643
7644 * xml.c (make_dom): Return comments, too.
7645
590bd467
PE
76462011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7647
7648 Port to OpenBSD.
7649 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7650 and the surrounding thread.
7651 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7652 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7653 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7654 timer goes off.
7655 * s/openbsd.h (BROKEN_SIGIO): Define.
7656 * unexelf.c (unexec) [__OpenBSD__]:
7657 Don't update the .mdebug section of the Alpha COFF symbol table.
7658
f41628b2
LMI
76592011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7660
7661 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7662 (bug#8460).
7663
b59b67c5
PE
76642011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7665
15e3a074
PE
7666 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7667 This fixes some race conditions on the permissions of any newly
7668 created file.
7669
41bed37d
PE
7670 * alloc.c (valid_pointer_p): Use pipe, not open.
7671 This fixes some permissions issues when debugging.
7672
b59b67c5
PE
7673 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7674 If fchown fails to set both uid and gid, try to set just gid,
7675 as that is sometimes allowed. Adjust the file's mode to eliminate
7676 setuid or setgid bits that are inappropriate if fchown fails.
7677
925a6be7
SM
76782011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7679
7680 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7681 to compare Lisp_Objects.
7682 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7683 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7684 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7685
52968808
AS
76862011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7687
0a6a104b
AS
7688 * lread.c (read_integer): Unread even EOF character.
7689 (read1): Likewise. Properly record start position of symbol.
7690
52968808
AS
7691 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7692 symbol character follows.
7693
9e381cdd
PE
76942011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7695
7696 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7697 This works around a problem with the previous change to Fcopy_file.
7698 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7699 and without this change, GCC might complain about discarding
7700 fchown's return value.
7701
b5641435
JB
77022011-07-16 Juanma Barranquero <lekktu@gmail.com>
7703
7704 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7705
a8031457
PE
77062011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7707
7708 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7709
dd889327
LMI
77102011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7711
750c33f7
LMI
7712 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7713 it's used from the C level.
7714
dd889327
LMI
7715 * process.c: Use the same condition for POLL_FOR_INPUT in both
7716 keyboard.c and process.c (bug#1858).
7717
87e86684
LM
77182011-07-09 Lawrence Mitchell <wence@gmx.li>
7719
7720 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7721 (Fgnutls_boot): Use it.
7722
64348f40
AS
77232011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7724
7725 * doc.c (Fsubstitute_command_keys): Revert last change.
7726
1d698799
LMI
77272011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7728
f863868c
LMI
7729 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7730 quotes the next character, and doesn't affect other longer
7731 sequences (bug#8935).
7732
1d698799
LMI
7733 * lread.c (syms_of_lread): Clarify that is isn't only
7734 `eval-buffer' and `eval-defun' that's affected by
7735 `lexical-binding' (bug#8460).
7736
aa4b6df6
EZ
77372011-07-15 Eli Zaretskii <eliz@gnu.org>
7738
7739 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7740 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7741
5d856da6
PE
77422011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7743
ad6042bb
PE
7744 Fix minor problems found by static checking.
7745 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7746 (elsz): Now a signed constant, not a size_t var. We prefer signed
7747 types to unsigned, to avoid integer comparison confusion. Without
7748 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7749 "cannot optimize loop, the loop counter may overflow", a symptom
7750 of the confusion.
f00bbb22 7751 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7752 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7753
6468f31c
LMI
77542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7755
49080b10
LMI
7756 * search.c (Fre_search_backward): Mention `case-fold-search' in
7757 all the re_search_* functions (bug#8138).
7758
6468f31c
LMI
7759 * keyboard.c (Fopen_dribble_file): Document when the file is
7760 closed (bug#8056).
7761
c965adc5
EZ
77622011-07-14 Eli Zaretskii <eliz@gnu.org>
7763
df9733bf
EZ
7764 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7765 bidi_cache_idx.
7766
0bb23927
EZ
7767 Support bidi reordering of display and overlay strings.
7768 * xdisp.c (compute_display_string_pos)
7769 (compute_display_string_end): Accept additional argument STRING.
7770 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7771 (reseat_to_string): Initialize bidi_it->string.s and
7772 bidi_it->string.schars.
7773 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7774 NULL (avoids a crash in bidi_paragraph_init).
7775 Initialize itb.string.lstring.
0bb23927
EZ
7776 (init_iterator): Call bidi_init_it only of a valid
7777 buffer position was specified. Initialize paragraph_embedding to
7778 L2R.
7779 (reseat_to_string): Initialize the bidi iterator.
7780 (display_string): If we need to ignore text properties of
7781 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7782 original value of -1 will not work with bidi.)
7783 (compute_display_string_pos): First arg is now struct
7784 `text_pos *'; all callers changed. Support display properties on
7785 Lisp strings.
7786 (compute_display_string_end): Support display properties on Lisp
7787 strings.
7788 (init_iterator, reseat_1, reseat_to_string): Initialize the
7789 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7790 when iterating on a string not from display properties).
640c8776
SM
7791 (compute_display_string_pos, compute_display_string_end):
7792 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7793 arrow keys.
7794 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7795 base_level_stop; instead, set base_level_stop to BEGV.
7796 Fixes crashes in vertical-motion.
0bb23927
EZ
7797 (next_element_from_buffer): Improve commentary for when
7798 the iterator is before prev_stop.
7799 (init_iterator): Initialize bidi_p from the default value of
7800 bidi-display-reordering, not from buffer-local value. Use the
7801 buffer-local value only if initializing for buffer iteration.
7802 (handle_invisible_prop): Support invisible properties on strings
7803 that are being bidi-reordered.
7804 (set_iterator_to_next): Support bidi reordering of C strings and
7805 Lisp strings.
7806 (next_element_from_string): Support bidi reordering of Lisp
7807 strings.
7808 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7809 (display_string): Support display of R2L glyph rows.
7810 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7811 (init_iterator): Don't initialize it->bidi_p for strings
7812 here.
7813 (reseat_to_string): Initialize it->bidi_p for strings here.
7814 (next_element_from_string, next_element_from_c_string)
7815 (next_element_from_buffer): Add xassert's for correspondence
7816 between IT's object being iterated and it->bidi_it.string
7817 structure.
7818 (face_before_or_after_it_pos): Support bidi iteration.
7819 (next_element_from_c_string): Handle the case of the first string
7820 character that is not the first one in the visual order.
7821 (get_visually_first_element): New function, refactored from common
7822 parts of next_element_from_buffer, next_element_from_string, and
7823 next_element_from_c_string.
7824 (tool_bar_lines_needed, redisplay_tool_bar)
7825 (display_menu_bar): Force left-to-right direction. Add a FIXME
7826 comment for making that be controlled by a user option.
7827 (push_it, pop_it): Save and restore the state of the
7828 bidi iterator. Save and restore the bidi_p flag.
7829 (pop_it): Iterate out of display property for string iteration as
7830 well.
7831 (iterate_out_of_display_property): Support iteration over strings.
7832 (handle_single_display_spec): Set up it->bidi_it for iteration
7833 over a display string, and call bidi_init_it.
7834 (handle_single_display_spec, next_overlay_string)
7835 (get_overlay_strings_1, push_display_prop): Set up the bidi
7836 iterator for displaying display or overlay strings.
7837 (forward_to_next_line_start): Don't use the shortcut if
7838 bidi-iterating.
7839 (back_to_previous_visible_line_start): If handle_display_prop
7840 pushed the iterator stack, restore the internal state of the bidi
7841 iterator by calling bidi_pop_it same number of times.
7842 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7843 and we are bidi-iterating, don't decrement the iterator position;
7844 instead, set the first_elt flag in the bidi iterator, to produce
7845 the same effect.
7846 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7847 (push_display_prop): xassert that we are iterating a buffer.
7848 (push_it, pop_it): Save and restore paragraph_embedding member.
7849 (handle_single_display_spec, next_overlay_string)
7850 (get_overlay_strings_1, reseat_1, reseat_to_string)
7851 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7852 correctly. Don't assume unibyte strings are not bidi-reordered.
7853 (compute_display_string_pos)
7854 (compute_display_string_end): Fix handling the case of C string.
7855 (push_it, pop_it): Save and restore from_disp_prop_p.
7856 (handle_single_display_spec, push_display_prop): Set the
7857 from_disp_prop_p flag.
7858 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7859 (pop_it): Call iterate_out_of_display_property only if we are
7860 popping after iteration over a string that came from a display
7861 property. Fix a typo in popping stretch info. Add an assertion
7862 for verifying that the iterator position is in sync with the bidi
7863 iterator.
7864 (handle_single_display_spec, get_overlay_strings_1)
7865 (push_display_prop): Fix initialization of paragraph direction for
7866 string when that of the parent object is not yet determined.
7867 (reseat_1): Call bidi_init_it to resync the bidi
7868 iterator with IT's position. (Bug#7616)
7869 (find_row_edges): If ROW->start.pos gives position
7870 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7871 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7872 Reset the from_disp_prop_p flag.
7873 (SAVE_IT, RESTORE_IT): New macros.
7874 (pos_visible_p, face_before_or_after_it_pos)
7875 (back_to_previous_visible_line_start)
7876 (move_it_in_display_line_to, move_it_in_display_line)
7877 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7878 (try_scrolling, redisplay_window, display_line): Use them when
7879 saving a temporary copy of the iterator and restoring it back.
7880 (back_to_previous_visible_line_start, reseat_1)
7881 (init_iterator): Empty the bidi cache "stack".
7882 (move_it_in_display_line_to): If iterator ended up at
7883 EOL, but we never saw any buffer positions smaller than
7884 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7885 motion in bidi-reordered lines.
7886 (move_it_in_display_line_to): Record prev_method and prev_pos
7887 immediately before the call to set_iterator_to_next. Fixes cursor
7888 motion in bidi-reordered lines with stretch glyphs and strings
7889 displayed in margins. (Bug#8133) (Bug#8867)
7890 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7891 TO_CHARPOS.
640c8776
SM
7892 (pos_visible_p): Support positions in bidi-reordered lines.
7893 Save and restore bidi cache.
0bb23927
EZ
7894
7895 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7896 (bidi_paragraph_info): Delete unused struct.
7897 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7898 (bidi_cache_start): New variable.
7899 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7900 to zero.
7901 (bidi_cache_fetch_state, bidi_cache_search)
7902 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7903 (bidi_cache_find, bidi_peek_at_next_level)
7904 (bidi_level_of_next_char, bidi_find_other_level_edge)
7905 (bidi_move_to_visually_next): Compare cache index with
7906 bidi_cache_start rather than with zero.
7907 (bidi_fetch_char): Accept new argument STRING; all callers
7908 changed. Support iteration over a string. Support strings with
7909 display properties. Support unibyte strings. Fix the type of
7910 `len' according to what STRING_CHAR_AND_LENGTH expects.
7911 (bidi_paragraph_init, bidi_resolve_explicit_1)
7912 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7913 (bidi_level_of_next_char, bidi_move_to_visually_next):
7914 Support iteration over a string.
0bb23927
EZ
7915 (bidi_set_sor_type, bidi_resolve_explicit_1)
7916 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7917 can now be zero (for strings); special values 0 and -1 were
7918 changed to -1 and -2, respectively.
7919 (bidi_char_at_pos): New function.
7920 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7921 Call it instead of FETCH_MULTIBYTE_CHAR.
7922 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7923 initialized to valid values.
7924 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7925 values.
7926 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7927 the test for valid cached positions. Fix the logic for looking up
7928 the sentinel state in the cache. GCPRO the Lisp string we are
7929 iterating.
7930 (bidi_push_it, bidi_pop_it): New functions.
7931 (bidi_initialize): Initialize the bidi cache start stack pointer.
7932 (bidi_cache_ensure_space): New function, refactored from part of
7933 bidi_cache_iterator_state. Don't assume the required size is just
7934 one BIDI_CACHE_CHUNK away.
7935 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7936 (bidi_count_bytes, bidi_char_at_pos): New functions.
7937 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7938 always valid if bidi_cache_idx is valid.
7939 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7940 is valid if it's going to be used.
7941 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7942 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7943 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7944 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7945 (bidi_find_other_level_edge, bidi_cache_start_stack):
7946 All variables related to cache indices are now EMACS_INT.
c965adc5 7947
0bb23927
EZ
7948 * dispextern.h (struct bidi_string_data): New structure.
7949 (struct bidi_it): New member `string'. Make flag members be 1-bit
7950 fields, and put them last in the struct.
640c8776
SM
7951 (compute_display_string_pos, compute_display_string_end):
7952 Update prototypes.
0bb23927
EZ
7953 (bidi_push_it, bidi_pop_it): Add prototypes.
7954 (struct iterator_stack_entry): New members bidi_p,
7955 paragraph_embedding, and from_disp_prop_p.
7956 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7957 (bidi_shelve_cache, bidi_unshelve_cache):
7958 Declare prototypes.
0bb23927
EZ
7959
7960 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7961 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7962 and vector-like objects.
7963
7964 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7965 cache around display iteration.
7966
7967 * window.c (Fwindow_end, window_scroll_pixel_based)
7968 (displayed_window_lines, Frecenter): Save and restore the bidi
7969 cache around display iteration.
7970
3bbd2265
LMI
79712011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7972
7973 * editfns.c (Fdelete_region): Clarify the use of the named
7974 parameters (bug#6788).
7975
adc47434
MR
79762011-07-14 Martin Rudalics <rudalics@gmx.at>
7977
7978 * indent.c (Fvertical_motion): Set and restore w->pointm when
7979 saving and restoring the window's buffer (Bug#9006).
7980
837c31f8
LMI
79812011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7982
7983 * editfns.c (Fstring_to_char): Clarify just what is returned
7984 (bug#6576). Text by Eli Zaretskii.
7985
ac389d0c
JB
79862011-07-13 Juanma Barranquero <lekktu@gmail.com>
7987
7988 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7989
0be0ce47
EZ
79902011-07-13 Eli Zaretskii <eliz@gnu.org>
7991
7992 * buffer.c (mmap_find): Fix a typo.
7993
cd18e7e3
JB
79942011-07-13 Johan Bockgård <bojohan@gnu.org>
7995
7996 Fix execution of x selection hooks.
7997 * xselect.c (Qx_lost_selection_functions)
7998 (Qx_sent_selection_functions): New vars.
7999 (syms_of_xselect): DEFSYM them.
8000 (x_handle_selection_request): Pass Qx_sent_selection_functions
8001 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8002 (x_handle_selection_clear,x_clear_frame_selections):
8003 Pass Qx_lost_selection_functions rather than
8004 Vx_lost_selection_functions to Frun_hook_with_args.
8005
47ea7f44
PE
80062011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8007
ac389d0c 8008 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8009 The old code sometimes used this field without initializing it.
8010
47ea7f44
PE
8011 * alloc.c (gc_sweep): Don't read past end of array.
8012 In theory, the old code could also have corrupted Emacs internals,
8013 though it'd be very unlikely.
8014
bc985c87
AS
80152011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8016
8017 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8018 argument. (Bug#4026)
bc985c87 8019
0cf34688
LMI
80202011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8021
b3dadd76
LMI
8022 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8023 key" (bug#4257).
8024
0cf34688
LMI
8025 * window.c (Fset_window_start): Doc fix (bug#4199).
8026 (Fset_window_hscroll): Ditto.
8027
270768cd
PE
80282011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8029
077e3dda 8030 Fix minor new problems caught by GCC 4.6.1.
270768cd 8031 * term.c (init_tty): Remove unused local.
490011a6 8032 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8033 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8034 not used otherwise.
270768cd 8035
b1f58454
CY
80362011-07-12 Chong Yidong <cyd@stupidchicken.com>
8037
8038 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8039
22b9578d
LMI
80402011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8041
6e70ab07
LMI
8042 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8043 are the mini-buffer and the echo area (bug#3320).
8044
22b9578d
LMI
8045 * term.c (init_tty): Remove support for supdup, c10 and perq
8046 terminals, which are no longer supported (bug#1482).
8047
8974cc9f
JB
80482011-07-10 Johan Bockgård <bojohan@gnu.org>
8049
8050 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8051
a560d974
JD
80522011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8053
8054 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8055 for non-popups (Bug#3642).
8056
1dae0f0a
AS
80572011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8058
268c2c36 8059 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8060 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8061 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8062 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8063 * data.c (fmod): Likewise.
8064 * dispnew.c (swap_glyphs_in_rows): Likewise.
8065 * emacs.c (memory_warning_signal): Likewise.
8066 * floatfns.c (float_error): Likewise.
8067 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8068 (otf_open, font_otf_capability, generate_otf_features)
8069 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8070 Likewise.
8071 * image.c (pbm_read_file): Likewise.
8072 * indent.c (string_display_width): Likewise.
8073 * intervals.c (check_for_interval, search_for_interval)
8074 (inc_interval_count, count_intervals, root_interval)
8075 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8076 * lread.c (defalias): Likewise.
268c2c36 8077 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8078 * regex.c (set_image_of_range_1, set_image_of_range)
8079 (regex_grow_registers): Likewise.
8080 * sysdep.c (strerror): Likewise.
8081 * termcap.c (valid_filename_p, tprint, main): Likewise.
8082 * tparam.c (main): Likewise.
8083 * unexhp9k800.c (run_time_remap, save_data_space)
8084 (update_file_ptrs, read_header, write_header, calculate_checksum)
8085 (copy_file, copy_rest, display_header): Likewise.
8086 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8087 Likewise.
8088 * xdisp.c (check_it): Likewise.
8089 * xfaces.c (register_color, unregister_color, unregister_colors):
8090 Likewise.
8091 * xfns.c (print_fontset_result): Likewise.
8092 * xrdb.c (member, fatal, main): Likewise.
8093
99033785
PE
80942011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8095
8096 Fix minor problems found by static checking (Bug#9031).
8097 * chartab.c (char_table_set_range, map_sub_char_table):
8098 Remove unused locals.
8099 (uniprop_table): Now static.
8100 * composite.c (_work_char): Remove unused static var.
8101
9cb2ac56
JB
81022011-07-09 Juanma Barranquero <lekktu@gmail.com>
8103
8104 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8105
f25661f0
JD
81062011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8107
8108 * gtkutil.c (qttip_cb): Remove code without function.
8109
8278c4fe
EZ
81102011-07-09 Eli Zaretskii <eliz@gnu.org>
8111
8112 * w32.c (pthread_sigmask): New stub.
8113
1692ae2d 81142011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8115
8a6ebd58 8116 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8117 sigprocmask is portable only for single-threaded applications, and
8118 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8119 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8120 (LIBES): Use it.
8121 * callproc.c (Fcall_process):
8122 * process.c (create_process):
8123 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8124 Use pthread_sigmask, not sigprocmask.
123403e4 8125
1b854618
JD
81262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8127
8128 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8129 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8130 wrong (Bug#8591).
8131
3fe4b549
JD
81322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8133
0ce7e563
JD
8134 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8135 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8136 (xg_hide_tooltip): Fix comment.
8137
3fe4b549
JD
8138 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8139 in registerServicesMenuSendTypes.
8140 (validRequestorForSendType): Don't check ns_return_types.
8141
8142 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8143 ns_return_type.
8144
5df75e47
JR
81452011-07-08 Jason Rumney <jasonr@gnu.org>
8146
22610910
JR
8147 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8148 SH_SHOW for hidden windows (Bug#5482).
8149
5df75e47
JR
8150 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8151 frame struct members of non-existent frames (Bug#6284).
8152
699c10bd
JD
81532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8154
4393663b
JD
8155 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8156 variable firstTime not needed on OSX >= 10.6.
8157 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8158 >= 10.5. Use setKnobProportion, setDoubleValue.
8159
8160 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8161 (MAC_OS_X_VERSION_10_5): Define if not defined.
8162 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8163 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8164 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8165
8166 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8167 cString and lossyCString on OSX >= 10.4.
4393663b 8168
58179cce 8169 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8170 sizeToFit on OSX >= 10.2.
8171
8172 * nsimage.m (allocInitFromFile): Don't use deprecated method
8173 bestRepresentationForDevice on OSX >= 10.6.
8174
8175 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8176 to avoid warning.
8177
8178 * emacs.c: Declare unexec_init_emacs_zone.
8179
a63e0781
JD
8180 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8181
699c10bd
JD
8182 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8183
8184 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8185 on svcsMenu (Bug#8842).
8186
8187 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8188 ns_return_types.
8189 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8190
8191 * nsterm.m (QUTF8_STRING): Declare.
8192 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8193 (validRequestorForSendType): Return type is (id).
8194 Change indexOfObjectIdenticalTo to indexOfObject.
8195 Check if we have local selection before returning self (Bug#8842).
8196 (writeSelectionToPasteboard): Put local selection into paste board
8197 if we have a local selection (Bug#8842).
8198 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8199
8200 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8201 (ns_get_local_selection): Declare.
8202
54e10184
LMI
82032011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8204
9888ff71
LMI
8205 * keymap.c (describe_map_tree): Don't insert a double newline at
8206 the end of the buffer (bug#1169) and return whether we inserted
8207 something.
8208
54e10184
LMI
8209 * callint.c (Fcall_interactively): Change "reading args" to
8210 "providing args" to try to clarify what it does (bug#1010).
8211
15fa4783
KH
82122011-07-07 Kenichi Handa <handa@m17n.org>
8213
8214 * composite.c (composition_compute_stop_pos): Ignore a static
8215 composition starting before CHARPOS (Bug#8915).
8216
8217 * xdisp.c (handle_composition_prop): Likewise.
8218
a8815b00
EZ
82192011-07-07 Eli Zaretskii <eliz@gnu.org>
8220
8221 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8222 (Bug#9015)
8223
ef7b981d 82242011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8225
8226 * character.h (unicode_category_t): New enum type.
8227
8228 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8229 (Qchar_code_property_table): New variable.
8230 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8231 (UNIPROP_COMPRESSED_FORM_P): New macros.
8232 (char_table_ascii): Uncompress the compressed values.
8233 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8234 Uncompress the compressed values.
ac389d0c 8235 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8236 (char_table_ref_and_range): Uncompress the compressed values.
8237 (sub_char_table_set): New arg is_uniprop. Callers changed.
8238 Uncompress the compressed values.
8239 (sub_char_table_set_range): Args changed. Callers changed.
8240 (char_table_set_range): Adjuted for the above change.
8241 (map_sub_char_table): Delete args default_val and parent. Add arg
8242 top. Give decoded values to a Lisp function.
640c8776 8243 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8244 values to a Lisp function. Gcpro more variables.
8245 (uniprop_table_uncompress)
8246 (uniprop_decode_value_run_length): New functions.
8247 (uniprop_decoder, uniprop_decoder_count): New variables.
8248 (uniprop_get_decoder, uniprop_encode_value_character)
8249 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8250 New functions.
8251 (uniprop_encoder, uniprop_encoder_count): New variables.
8252 (uniprop_get_encoder, uniprop_table)
8253 (Funicode_property_table_internal, Fget_unicode_property_internal)
8254 (Fput_unicode_property_internal): New functions.
8255 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8256 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8257 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8258 char-code-property-alist.
8259
640c8776 8260 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8261 Vunicode_category_table.
8262
640c8776 8263 * font.c (font_range): Adjust for the change of
c805dec0
KH
8264 Vunicode_category_table.
8265
76b397fb
DN
82662011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8267
8268 * m/iris4d.h: Remove file, move contents ...
8269 * s/irix6-5.h: ... here.
8270
22b4128e
PE
82712011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8272
8273 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8274 * alloc.c (mark_buffer):
8275 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8276 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8277 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8278 This isn't true in general, and it's particularly not true
8279 if Emacs is configured with --with-wide-int.
8280 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8281 New macros, used in the buffer.c change.
8282
869795d6
JD
82832011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8284
8285 * xsettings.c: Use both GConf and GSettings if both are available.
8286 (store_config_changed_event): Add comment.
8287 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8288 (store_tool_bar_style_changed): New functions.
5e617bc2 8289 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8290 (struct xsettings): Move font inside HAVE_XFT.
8291 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8292 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8293 Move inside HAVE_XFT.
640c8776 8294 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8295 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8296 also.
8297 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8298 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8299 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8300 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8301 (parse_settings): Move check for font inside HAVE_XFT.
8302 (read_settings, apply_xft_settings): Add comment.
8303 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8304 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8305 call store_font_name_changed.
8306 (xft_settings_event): Add comment.
8307 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8308 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8309 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8310 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8311 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8312 (xsettings_get_system_font, xsettings_get_system_normal_font):
8313 Add comment.
869795d6 8314
d8ed26bd
PE
83152011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8316
8317 Random fixes. E.g., (random) never returned negative values.
8318 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8319 subseconds part to the entropy, as that's a bit more random.
8320 Prefer signed to unsigned, since the signedness doesn't matter and
8321 in general we prefer signed. When given a limit, use a
8322 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8323 latter isn't right if USE_2_TAGS_FOR_INTS.
8324 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8325 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8326
cabf1cac
SM
83272011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8328
8329 * textprop.c (text_property_stickiness):
8330 Obey Vtext_property_default_nonsticky.
8331 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8332 * w32fns.c (syms_of_w32fns):
8333 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8334
6e9b2be9
PE
83352011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8336
8337 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8338 This is more efficient than Ffile_directory_p and avoids a minor race.
8339
90186c68
LMI
83402011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8341
7c301272
LMI
8342 * buffer.c (Foverlay_put): Say what the return value is
8343 (bug#7835).
8344
c4f2d8d4
LMI
8345 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8346 is a directory before asking whether to use the file name
8347 (bug#7564).
ad637907
LMI
8348 (barf_or_query_if_file_exists): Make the "File is a directory"
8349 error be more correct.
c4f2d8d4 8350
90186c68
LMI
8351 * fns.c (Frequire): Remove the mention of the .gz files, since
8352 that's installation-specific, but keep the mention of
8353 `get-load-suffixes'.
8354
da64016e
PE
83552011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8356
8357 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8358 Report string overflow if the output is too long.
8359
7d47b580
JB
83602011-07-04 Juanma Barranquero <lekktu@gmail.com>
8361
a555cb87
JB
8362 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8363 (syms_of_gnutls): Remove duplicate DEFSYM for
8364 Qgnutls_bootprop_verify_hostname_error, an error for
8365 Qgnutls_bootprop_verify_error (which is no longer used).
8366
7d47b580
JB
8367 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8368 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8369 Also (re)move comments that are misplaced or no longer relevant.
8370
1e49bfab
LMI
83712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8372
8373 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8374
1485f4c0
CY
83752011-07-03 Chong Yidong <cyd@stupidchicken.com>
8376
8377 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8378 and background color parameters if they have been changed.
8379
a9ab721e
LMI
83802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8381
8382 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8383
cf7cff57
PE
83842011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8385
2e13213d
PE
8386 * xsettings.c (SYSTEM_FONT): Define only when used.
8387 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8388
cf7cff57
PE
8389 * keymap.c (access_keymap_1): Now static.
8390
7a8e04f7
CY
83912011-07-02 Chong Yidong <cyd@stupidchicken.com>
8392
8393 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8394 leave any prefix arg for the up event (Bug#1586).
8395
61352f62
LMI
83962011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8397
69bb1ef7
LMI
8398 * lread.c (syms_of_lread): Mention single symbols defined by
8399 `defvar' or `defconst' (bug#7154).
8400
61352f62 8401 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8402 (Frequire): Mention get-load-suffixes.
61352f62 8403
28545e04
MR
84042011-07-02 Martin Rudalics <rudalics@gmx.at>
8405
8406 * window.h (window): Remove clone_number slot.
8407 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8408 Remove.
8409 (make_parent_window, make_window, saved_window)
8410 (Fset_window_configuration, save_window_save): Don't deal with
8411 clone numbers.
8412 * buffer.c (Qclone_number): Remove declaration.
8413 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8414
3349e122
SM
84152011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8416
8417 Add multiple inheritance to keymaps.
8418 * keymap.c (Fmake_composed_keymap): New function.
8419 (Fset_keymap_parent): Simplify.
8420 (fix_submap_inheritance): Remove.
8421 (access_keymap_1): New function extracted from access_keymap to handle
8422 embedded parents and handle lists of maps.
8423 (access_keymap): Use it.
8424 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8425 (Fcopy_keymap): Handle embedded parents.
8426 (Fcommand_remapping, define_as_prefix): Simplify.
8427 (Fkey_binding): Simplify.
8428 (syms_of_keymap): Move minibuffer-local-completion-map,
8429 minibuffer-local-filename-completion-map,
8430 minibuffer-local-must-match-map, and
8431 minibuffer-local-filename-must-match-map to Elisp.
8432 (syms_of_keymap): Defsubr make-composed-keymap.
8433 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8434 (parse_menu_item): Trivial simplification.
8435
3279eb87
GM
84362011-07-01 Glenn Morris <rgm@gnu.org>
8437
8438 * Makefile.in (SETTINGS_LIBS): Fix typo.
8439
4550efdf
KI
84402011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8441
8442 * coding.c (Fencode_coding_string): Record the last coding system
8443 used, as the function doc string says (bug#8738).
8444
0949d2b6
JD
84452011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8446
8447 * xsettings.c (store_monospaced_changed): Take new font as arg and
8448 check for change against current_mono_font.
8449 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8450 (emacs_settings_constructor, emacs_settings_get_property)
8451 (emacs_settings_set_property, emacs_settings_class_init)
8452 (emacs_settings_init, gsettings_obj): Remove.
8453 (something_changedCB): New function for HAVE_GSETTINGS.
8454 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8455 with value as argument.
8456 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8457 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8458 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8459 "changed".
8460
8461 * xgselect.c: Add defined (HAVE_GSETTINGS).
8462 (xgselect_initialize): Ditto.
8463
8464 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8465 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8466 xg_select.
8467
bbc6b304
PE
84682011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8469
8470 * eval.c (struct backtrace): Simplify and port the data structure.
8471 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8472 signed bit field, as this assumption is not portable and it makes
8473 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8474 "char debug_on_exit : 1" as this is not portable either; instead,
8475 use the portable "unsigned int debug_on_exit : 1". Remove unused
8476 member evalargs. Remove obsolete comments about cc bombing out.
8477
9851bfc5
JD
84782011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8479
51bb811f 8480 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8481 Let HAVE_GSETTINGS override HAVE_GCONF.
8482 (store_monospaced_changed): New function.
8483 (EMACS_SETTINGS): A new type derived from GObject to handle
8484 GSettings notifications.
8485 (emacs_settings_constructor, emacs_settings_get_property)
8486 (emacs_settings_set_property, emacs_settings_class_init):
8487 New functions.
8488 (gsettings_client, gsettings_obj): New variables.
8489 (GSETTINGS_SCHEMA): New define.
8490 (something_changedCB): Call store_monospaced_changed.
8491 (init_gsettings): New function.
8492 (xsettings_initialize): Call init_gsettings.
8493 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8494 to NULL.
8495
640c8776 8496 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8497 GCONF_CFLAGS/LIBS.
8498
5386012d
MR
84992011-06-29 Martin Rudalics <rudalics@gmx.at>
8500
8501 * window.c (resize_root_window, grow_mini_window)
8502 (shrink_mini_window): Rename Qresize_root_window to
8503 Qwindow_resize_root_window and Qresize_root_window_vertically to
8504 Qwindow_resize_root_window_vertically.
8505
f13e0b08
PE
85062011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8507
8508 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8509
94515237
JB
85102011-06-27 Juanma Barranquero <lekktu@gmail.com>
8511
8512 * makefile.w32-in: Redesign dependencies so they reflect more
8513 clearly which files are directly included by each source file,
8514 and not through other includes.
8515
e43b6e43
MR
85162011-06-27 Martin Rudalics <rudalics@gmx.at>
8517
8518 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8519 (sort_overlays, overlay_strings): When an overlay's clone number
8520 matches the window's clone number process the overlay even if
8521 the overlay's window property doesn't match the current window.
8522
d68443dc
MR
8523 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8524 (Fwindow_hchild): Rename to Fwindow_left_child.
8525 (Fwindow_next): Rename to Fwindow_next_sibling.
8526 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8527 (resize_window_check): Rename to window_resize_check.
8528 (resize_window_apply): Rename to window_resize_apply.
8529 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8530 (Fdelete_other_windows_internal, resize_frame_windows)
8531 (Fsplit_window_internal, Fdelete_window_internal)
8532 (grow_mini_window, shrink_mini_window)
8533 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8534
c7e73be5
JD
85352011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8536
8537 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8538 (emacs_fixed_set_min_size): Remove.
8539 (emacs_fixed_new): Take frame as argument.
8540
8541 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8542 (_EmacsFixedPrivate): Remove minwidth/height.
8543 Add struct frame *f.
8544 (emacs_fixed_init): Initialize priv->f.
8545 (get_parent_class, emacs_fixed_set_min_size): Remove.
8546 (emacs_fixed_new): Set priv->f to argument.
8547 (emacs_fixed_get_preferred_width)
8548 (emacs_fixed_get_preferred_height): Use min_width/height from
8549 frames size_hint to set minimum and natural (Bug#8919).
8550 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8551 and use min_width/height from frames size_hint to set
8552 min_width/height (Bug#8919).
8553
8554 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8555 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8556 Fix indentation.
c7e73be5 8557
cf99dcf8
EZ
85582011-06-26 Eli Zaretskii <eliz@gnu.org>
8559
8560 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8561 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8562 called at ZV.
8563
029529ac
CY
85642011-06-26 Chong Yidong <cyd@stupidchicken.com>
8565
8566 * process.c (wait_reading_process_output): Bypass select if
8567 waiting for a cell while ignoring keyboard input, and input is
8568 pending. Suggested by Jan Djärv (Bug#8869).
8569
7a7ef429
PE
85702011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8571
8572 Use gnulib's dup2 module instead of rolling our own.
8573 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8574
11fdef7d 85752011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8576
8577 * dispnew.c (scrolling_window): Before scrolling, turn off a
8578 mouse-highlight in the window being scrolled.
8579
cd3520a4
JB
85802011-06-24 Juanma Barranquero <lekktu@gmail.com>
8581
8582 Move DEFSYM to lisp.h and use everywhere.
8583
8584 * character.h (DEFSYM): Move declaration...
8585 * lisp.h (DEFSYM): ...here.
8586
8587 * gnutls.c:
8588 * minibuf.c:
8589 * w32menu.c:
8590 * w32proc.c:
8591 * w32select.c: Don't include character.h.
8592
8593 * alloc.c (syms_of_alloc):
8594 * buffer.c (syms_of_buffer):
8595 * bytecode.c (syms_of_bytecode):
8596 * callint.c (syms_of_callint):
8597 * casefiddle.c (syms_of_casefiddle):
8598 * casetab.c (init_casetab_once):
8599 * category.c (init_category_once, syms_of_category):
8600 * ccl.c (syms_of_ccl):
8601 * cmds.c (syms_of_cmds):
8602 * composite.c (syms_of_composite):
8603 * dbusbind.c (syms_of_dbusbind):
8604 * dired.c (syms_of_dired):
8605 * dispnew.c (syms_of_display):
8606 * doc.c (syms_of_doc):
8607 * editfns.c (syms_of_editfns):
8608 * emacs.c (syms_of_emacs):
8609 * eval.c (syms_of_eval):
8610 * fileio.c (syms_of_fileio):
8611 * fns.c (syms_of_fns):
8612 * frame.c (syms_of_frame):
8613 * fringe.c (syms_of_fringe):
8614 * insdel.c (syms_of_insdel):
8615 * keymap.c (syms_of_keymap):
8616 * lread.c (init_obarray, syms_of_lread):
8617 * macros.c (syms_of_macros):
8618 * msdos.c (syms_of_msdos):
8619 * print.c (syms_of_print):
8620 * process.c (syms_of_process):
8621 * search.c (syms_of_search):
8622 * sound.c (syms_of_sound):
8623 * syntax.c (init_syntax_once, syms_of_syntax):
8624 * terminal.c (syms_of_terminal):
8625 * textprop.c (syms_of_textprop):
8626 * undo.c (syms_of_undo):
8627 * w32.c (globals_of_w32):
8628 * window.c (syms_of_window):
8629 * xdisp.c (syms_of_xdisp):
8630 * xfaces.c (syms_of_xfaces):
8631 * xfns.c (syms_of_xfns):
8632 * xmenu.c (syms_of_xmenu):
8633 * xsettings.c (syms_of_xsettings):
8634 * xterm.c (syms_of_xterm): Use DEFSYM.
8635
4228cf16
TZ
86362011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8637
cd3520a4 8638 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8639
7fcccf1e
PE
86402011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8641
7efb4e0e
PE
8642 Integer and buffer overflow fixes (Bug#8873).
8643
ff5844ad
PE
8644 * print.c (printchar, strout): Check for string overflow.
8645 (PRINTPREPARE, printchar, strout):
8646 Don't set size unless allocation succeeds.
8647
90532f02
PE
8648 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8649 for sizes. Check for string overflow more accurately.
8650 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8651
6d84508d
PE
8652 * macros.c: Integer and buffer overflow fixes.
8653 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8654 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8655 Use ptrdiff_t, not int, for sizes.
8656 Don't increment bufsize until after realloc succeeds.
8657 Check for size-calculation overflow.
8658 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8659
437b2cb4
PE
8660 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8661
8b9ac8b4
PE
8662 * lread.c: Integer overflow fixes.
8663 (read_integer): Radix is now EMACS_INT, not int,
8664 to improve quality of diagnostics for out-of-range radices.
8665 Calculate buffer size correctly for out-of-range radices.
8666 (read1): Check for integer overflow in radices, and in
8667 read-circle numbers.
82cb60d3
PE
8668 (read_escape): Avoid int overflow.
8669 (Fload, openp, read_buffer_size, read1)
8670 (substitute_object_recurse, read_vector, read_list, map_obarray):
8671 Use ptrdiff_t, not int, for sizes.
8672 (read1): Use EMACS_INT, not int, for sizes.
20270765 8673 Check for size overflow.
8b9ac8b4 8674
7fcccf1e
PE
8675 * image.c (cache_image): Check for size arithmetic overflow.
8676
bfbbd7e7
PE
8677 * lread.c: Integer overflow issues.
8678 (saved_doc_string_size, saved_doc_string_length)
8679 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8680 Now ptrdiff_t, not int.
8681 (read1): Don't assume doc string length fits in int. Check for
8682 out-of-range doc string lengths.
8683 (read_list): Don't assume file position fits in int.
39019e54 8684 (read_escape): Check for hex character overflow.
bfbbd7e7 8685
4e323265
LL
86862011-06-22 Leo Liu <sdl.web@gmail.com>
8687
8688 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8689 Move to minibuffer.el.
8690
85fece3e
PE
86912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8692
20b84ce9 8693 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8694 The following patches are for when GLYPH_DEBUG && !XASSERT.
8695 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8696 * dispnew.c (flush_stdout):
8697 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8698 Mark as externally visible.
8699 * dispnew.c (check_window_matrix_pointers): Now static.
8700 * dispnew.c (window_to_frame_vpos):
8701 * xfns.c (unwind_create_frame):
8702 * xterm.c (x_check_font): Remove unused local.
8703 * scroll.c (CHECK_BOUNDS):
8704 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8705 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8706 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8707 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8708 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8709 Now static.
8710 (debug_method_add): Use va_list and vsprintf rather than relying
8711 on undefined behavior with wrong number of arguments.
8712 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8713 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8714 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8715 since we're not interested in debugging glyphs with old libraries.
8716 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8717 GCC 4.6.0's static checking.
8718
0766b489
PE
87192011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8720
31fd4b32
PE
8721 Integer overflow and signedness fixes (Bug#8873).
8722 A few related buffer overrun fixes, too.
8723
b79e8648
PE
8724 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8725
0766b489
PE
8726 * dispextern.h (struct face.stipple):
8727 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8728 (x_bitmap_mask, x_allocate_bitmap_record)
8729 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8730 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8731 (x_create_bitmap_from_xpm_data):
8732 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8733 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8734 (.bitmaps_last):
8735 * xfaces.c (load_pixmap):
8736 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8737 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8738 (.bitmaps_last, struct x_output.icon_bitmap):
8739 Use ptrdiff_t, not int, for bitmap indexes.
8740 (x_allocate_bitmap_record): Check for size overflow.
8741 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8742
b081724f
PE
8743 Use ptrdiff_t, not int, for overlay counts.
8744 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8745 * editfns.c (overlays_around, get_pos_property):
8746 * textprop.c (get_char_property_and_overlay):
8747 * xdisp.c (next_overlay_change, note_mouse_highlight):
8748 * xfaces.c (face_at_buffer_position):
21514da7
PE
8749 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8750 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8751 (Fnext_overlay_change, Fprevious_overlay_change)
8752 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8753 Use ptrdiff_t, not int, for sizes.
21514da7 8754 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8755
3de73e5e
PE
8756 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8757
2606c57b
PE
8758 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8759 (x_session_initialize): Do not assume string length fits in int.
8760
aaafe47a
PE
8761 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8762 This is unlikely, but can occur if DPI is outlandish.
8763
2674ddc8 8764 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8765 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8766
28154962
PE
8767 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8768 * xrdb.c (magic_file_p, search_magic_path):
8769 Omit last arg SUFFIX; it was always 0. All callers changed.
8770 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8771
7de51af5
PE
8772 * xfont.c (xfont_match): Avoid need for strlen.
8773
25ed6cc3
PE
8774 * xfns.c: Don't assume strlen fits in int.
8775 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8776
4eab31dd
PE
8777 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8778 not unsigned long, as we prefer signed integers. All callers changed.
8779 Detect integer overflow in repeat count.
8780 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8781 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8782
171e2a58
PE
8783 * termcap.c: Don't assume sizes fit in int and never overflow.
8784 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8785 (gobble_line): Check for size-calculation overflow.
8786
ad39faca 8787 * minibuf.c (Fread_buffer):
6e5bb2dc 8788 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8789 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8790 Don't assume string length fits in int.
8791
52c61c22 8792 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8793 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8794
b5b8c9e5
PE
8795 * font.c: Don't assume string length fits in int.
8796 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8797 Use ptrdiff_t, not int.
ccd6111c
PE
8798 (font_intern_prop): Don't assume string length fits in int.
8799 Don't assume integer property fits in fixnum.
8800 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8801
882f0d81 8802 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8803 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8804 Reformulate so as not to need the command string.
8805 Invoke gzip -cd rather than gunzip, as it's more portable.
8806 (lock_info_type, lock_file_1, lock_file):
8807 Don't assume pid_t and time_t fit in unsigned long.
8808 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8809 (current_lock_owner): Prefer signed type for sizes.
8810 Use memcpy, not strncpy, where memcpy is what is really wanted.
8811 Don't assume (via atoi) that time_t and pid_t fit in int.
8812 Check for time_t and/or pid_t out of range, e.g., via a network share.
8813 Don't alloca where an auto var works fine.
8814
93f4cf88
PE
8815 * fileio.c: Fix some integer overflow issues.
8816 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8817 Don't assume string length fits in int.
8818 (directory_file_name): Don't assume string length fits in long.
8819 (make_temp_name): Don't assume pid fits in int, or that its print
8820 length is less than 20.
8821
f3e92b69
PE
8822 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8823
1bfdaf10
PE
8824 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8825
35016e9a
PE
8826 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8827
3d1e65a1
PE
8828 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8829 We prefer signed integers, even for size calculations.
8830
0b963a93
PE
8831 * emacs.c: Don't assume string length fits in 'int'.
8832 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8833 (main): Don't invoke strlen when not needed.
8834
573f4b54
PE
8835 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8836 (XD_DEBUG_MESSAGE): Don't waste a byte.
8837
989f33ba
PE
8838 * callproc.c (getenv_internal_1, getenv_internal)
8839 (Fgetenv_internal):
965d34eb
PE
8840 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8841
e4d29b33
PE
8842 * lread.c (invalid_syntax): Omit length argument.
8843 All uses changed. This doesn't fix a bug, but it simplifies the
8844 code away from its former Hollerith-constant appearance, and it's
8845 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8846 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8847
eb49b136
PE
8848 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8849 This didn't break anything, but it didn't help either.
8850 It's confusing to put a bogus integer in a place where the actual
8851 value does not matter.
9f62aeb1 8852 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8853 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8854
15375a22
PE
8855 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8856 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8857 implementation.
b61cc01c
PE
8858 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8859 We prefer signed types, and the value cannot exceed the EMACS_INT
8860 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8861 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8862 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8863 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8864
53b2623d
PE
8865 * indent.c (sane_tab_width): New function.
8866 (current_column, scan_for_column, Findent_to, position_indentation)
8867 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8868 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8869
51cab52b 8870 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8871
f2ed8a70
PE
8872 * lisp.h (lint_assume): New macro.
8873 * composite.c (composition_gstring_put_cache):
8874 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8875
abe80cc6
PE
8876 * editfns.c, insdel.c:
8877 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8878
b02c740e
PE
8879 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8880
ebc96716
PE
8881 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8882
b4e50fa0 8883 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8884 Use much-faster test for byte-length change.
311d5d7c 8885 Don't assume string byte-length fits in 'int'.
a4cf38e4 8886 Check that character arg fits in 'int'.
85461888 8887 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8888
c0c1ee9f
PE
8889 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8890
a498d7f4
PE
8891 * fns.c (concat): Catch string overflow earlier.
8892 Do not rely on integer wraparound.
8893
51cab52b
PE
8894 * dispextern.h (struct it.overlay_strings_charpos)
8895 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8896 * xdisp.c (forward_to_next_line_start)
8897 (back_to_previous_visible_line_start)
8898 (reseat_at_next_visible_line_start, next_element_from_buffer):
8899 Don't arbitrarily truncate the value of 'selective' to int.
8900
76031fad
PE
8901 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8902
5eb55db9
PE
8903 * composite.c: Don't truncate sizes to 'int'.
8904 (composition_gstring_p, composition_reseat_it)
8905 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8906 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8907 not EMACS_UINT, for indexes.
5eb55db9 8908
0703a717
PE
8909 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8910
d6202519
PE
8911 * buffer.c: Include <verify.h>.
8912 (struct sortvec.priority, struct sortstr.priority):
8961a454 8913 Now EMACS_INT, not int.
c20998a7 8914 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8915 (struct sortstr.size, record_overlay_string)
8916 (struct sortstrlist.size, struct sortlist.used):
8917 Don't truncate size to int.
8918 (record_overlay_string): Check for size-calculation overflow.
d6202519 8919 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8920
d5a19415
JM
89212011-06-22 Jim Meyering <meyering@redhat.com>
8922
029529ac 8923 Don't leak an XBM-image-sized buffer
d5a19415
JM
8924 * image.c (xbm_load): Free the image buffer after using it.
8925
a9041e6c
PE
89262011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8927
8928 Port to Sun C.
8929 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8930 that Sun C diagnosed.
8931 * fns.c (secure_hash): Fix pointer signedness issue.
8932 * intervals.c (static_offset_intervals): New function.
8933 (offset_intervals): Use it.
8934
7f3f739f
LL
89352011-06-21 Leo Liu <sdl.web@gmail.com>
8936
8937 * deps.mk (fns.o):
8938 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8939 sha512.h.
8940
8941 * fns.c (secure_hash): Rename from crypto_hash_function and change
8942 the first arg to accept symbols.
5b66d427 8943 (Fsecure_hash): New primitive.
7f3f739f
LL
8944 (syms_of_fns): New symbols.
8945
76147d94
DD
89462011-06-20 Deniz Dogan <deniz@dogan.se>
8947
8948 * process.c (Fset_process_buffer): Clarify return value in
8949 docstring.
8950
7d7d0045
CY
89512011-06-18 Chong Yidong <cyd@stupidchicken.com>
8952
8953 * dispnew.c (add_window_display_history): Use BVAR.
8954
8955 * xdisp.c (debug_method_add): Use BVAR.
8956 (check_window_end, dump_glyph_matrix, dump_glyph)
8957 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8958
8959 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8960 Likewise.
8961
8962 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8963 check till after the cache is created in init_frame_faces.
8964
ff2bc410
SM
89652011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8966
8967 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8968
28177add
PE
89692011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8970
dd3482fe
PE
8971 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8972 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8973 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8974
393d71f3 8975 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8976 * fileio.c (Finsert_file_contents):
8977 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8978 Remove the old (too-loose) buffer overflow checks.
8979 They weren't needed, since make_gap checks for buffer overflow.
8980 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8981 The old code merely checked for Emacs fixnum overflow, and relied
8982 on undefined (wraparound) behavior. The new code avoids undefined
8983 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8984
2e6813b0 8985 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8986 Tune. Don't use wider integers than needed. Don't use alloca.
8987 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8988
599a9e4f
PE
8989 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8990
99561444
PE
8991 * insdel.c, lisp.h (buffer_overflow): New function.
8992 (insert_from_buffer_1, replace_range, replace_range_2):
8993 * insdel.c (make_gap_larger):
8994 * editfns.c (Finsert_char):
8995 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8996
28177add
PE
8997 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8998
e69dafad
PE
89992011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9000
4baa020d 9001 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9002
b1c46f02
PE
9003 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9004 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9005
e69dafad
PE
9006 * fileio.c: Don't assume EMACS_INT fits in off_t.
9007 (emacs_lseek): New static function.
9008 (Finsert_file_contents, Fwrite_region): Use it.
9009 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9010
566684ea
PE
9011 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9012
e6966cd6
PE
9013 * fns.c: Don't overflow int when computing a list length.
9014 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9015 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9016 truncation on 64-bit hosts. Check for QUIT every
9017 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9018 faster and is responsive enough.
9019 (Flength): Report an error instead of overflowing an integer.
9020 (Fsafe_length): Return a float if the value is not representable
9021 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9022 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9023 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9024
dd0b0efb
PE
9025 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9026 (header_size, word_size): New constants.
9027 (allocate_vectorlike): Don't check size overflow here.
9028 (allocate_vector): Check it here instead, since this is the only
9029 caller of allocate_vectorlike that could cause overflow.
9030 Check that the new vector's length is representable as a fixnum.
9031
86fe5cfe
PE
9032 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9033 The previous code was bogus. For example, next_almost_prime (32)
9034 returned 39, which is undesirable as it is a multiple of 3; and
9035 next_almost_prime (24) returned 25, which is a multiple of 5 so
9036 why was the code bothering to check for multiples of 7?
9037
80e88859
PE
9038 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9039
4a2f0ad6
PE
9040 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9041
f66c7cf8
PE
9042 Variadic C functions now count arguments with ptrdiff_t.
9043 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9044 Back then I didn't know that the Emacs coding style prefers signed int.
9045 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9046 were being counted with int, which may truncate counts on 64-bit
9047 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9048 * lisp.h (struct Lisp_Subr.function.aMANY)
9049 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9050 Arg counts are now ptrdiff_t, not size_t.
9051 All variadic functions and their callers changed accordingly.
9052 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9053 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9054 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9055 * callint.c (Fcall_interactively): Check arg count for overflow,
9056 to avoid potential buffer overrun. Use signed char, not 'int',
9057 for 'varies' array, so that we needn't bother to check its size
9058 calculation for overflow.
9059 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9060 * eval.c (apply_lambda):
9061 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9062 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9063 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9064
a1759b76
PE
9065 * callint.c (Fcall_interactively): Don't use index var as event count.
9066
d96be9fc
PE
9067 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9068 * mem-limits.h (SIZE): Remove; no longer used.
9069
a690a978 9070 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9071
578c21e6
PE
9072 Remove unnecessary casts.
9073 * xterm.c (x_term_init):
9074 * xfns.c (x_set_border_pixel):
9075 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9076 These aren't needed now that we assume ANSI C.
9077
96f53c6c
PE
9078 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9079 It's more likely to cause problems (due to unsigned overflow)
9080 than to cure them.
9081
83c77d31
PE
9082 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9083
ee2079f1
PE
9084 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9085
6da65536
PE
9086 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9087
7147c4a4
PE
9088 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9089
193e32d9
PE
9090 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9091
e5533da6
PE
9092 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9093
9910e595
PE
9094 GLYPH_CODE_FACE returns EMACS_INT, not int.
9095 * dispextern.h (merge_faces):
9096 * xfaces.c (merge_faces):
01103c44
PE
9097 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9098 Don't assume EMACS_INT fits in int.
9910e595 9099
2638320e
PE
9100 * character.h (CHAR_VALID_P): Remove unused parameter.
9101 * fontset.c, lisp.h, xdisp.c: All uses changed.
9102
045eb8d9
PE
9103 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9104
c1f134b5
PE
9105 * fns.c (concat): Minor tuning based on overflow analysis.
9106 This doesn't fix any bugs. Use int to hold character, instead
9107 of constantly refetching from Emacs object. Use XFASTINT, not
9108 XINT, for value known to be a character. Don't bother comparing
9109 a single byte to 0400, as it's always less.
9110
395fcb93 9111 * floatfns.c (Fexpt):
327eeec8
PE
9112 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9113
abbd3d23
PE
9114 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9115 for characters.
9116
684a03ef
PE
9117 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9118
0fed43f3
PE
9119 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9120 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9121 incorrectly succeed when S was a string, because 4294967386 was
9122 truncated before it was used.
9123
8fd02eb7
PE
9124 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9125 Otherwise, an out-of-range integer could cause undefined behavior
9126 on a 64-bit host.
9127
f8c86b69
PE
9128 * composite.c: Use int, not EMACS_INT, for characters.
9129 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9130 EMACS_INT, for values that are known to be in character range.
9131 This doesn't fix any bugs but is the usual style inside Emacs and
9132 may generate better code on 32-bit machines.
9133
34206dd2
PE
9134 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9135 This is for reasons similar to the recent CHAR_STRING fix.
9136 * charset.c (Fencode_char): Check that character arg is actually
9137 a character. Pass an int to ENCODE_CHAR.
9138 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9139 wider than 'int', as a compile-time check to prevent future regressions
9140 in this area.
9141
c5958d4c 9142 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9143
9144 Make sure a 64-bit char is never passed to CHAR_STRING.
9145 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9146 by silently ignoring the top 32 bits, allowing some values
9147 that were far too large to be valid characters.
9148 * character.h: Include <verify.h>.
9149 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9150 arguments are no wider than unsigned, as a compile-time check
9151 to prevent future regressions in this area.
9152 * data.c (Faset):
01103c44 9153 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9154 (Fsubst_char_in_region):
9155 * fns.c (concat):
9156 * xdisp.c (decode_mode_spec_coding):
9157 Adjust to CHAR_STRING's new requirement.
9158 * editfns.c (Finsert_char, Fsubst_char_in_region):
9159 * fns.c (concat): Check that character args are actually
9160 characters. Without this test, these functions did the wrong
9161 thing with wildly out-of-range values on 64-bit hosts.
9162
d37ca623
PE
9163 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9164 These casts should not be needed on 32-bit hosts, either.
9165 * keyboard.c (read_char):
9166 * lread.c (Fload): Remove casts to unsigned.
9167
ea204efb
PE
9168 * lisp.h (UNSIGNED_CMP): New macro.
9169 This fixes comparison bugs on 64-bit hosts.
9170 (ASCII_CHAR_P): Use it.
9171 * casefiddle.c (casify_object):
01103c44 9172 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9173 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9174 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9175 * dispextern.h (FACE_FROM_ID):
9176 * keyboard.c (read_char): Use UNSIGNED_CMP.
9177
41cb286c
PE
9178 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9179 not to EMACS_INT, to avoid GCC warning.
9180
4a1b9832
PE
9181 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9182
55daad71
PE
9183 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9184 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9185 isn't needed on 32-bit machines.
8f95c75c 9186
01103c44
PE
9187 * buffer.c (Fgenerate_new_buffer_name):
9188 Use EMACS_INT for count, not int.
0ceccced 9189 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9190
9191 * data.c (Qcompiled_function): Now static.
9192
c6f072e7
PE
9193 * window.c (window_body_lines): Now static.
9194
20ce5912
PE
9195 * image.c (gif_load): Rename local to avoid shadowing.
9196
9c4c5f81
PE
9197 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9198 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9199 * alloc.c (make_save_value): Integer argument is now of type
9200 ptrdiff_t, not int.
9201 (mark_object): Use ptrdiff_t, not int.
9202 * lisp.h (pD): New macro.
9203 * print.c (print_object): Use it.
9204
c0c5c8ae
PE
9205 * alloc.c: Use EMACS_INT, not int, to count objects.
9206 (total_conses, total_markers, total_symbols, total_vector_size)
9207 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9208 (total_free_floats, total_floats, total_free_intervals)
9209 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9210 Now EMACS_INT, not int. All uses changed.
9211 (Fgarbage_collect): Compute overall total using a double, so that
9212 integer overflow is less likely to be a problem. Check for overflow
9213 when converting back to an integer.
5a25e253
PE
9214 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9215 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9216 These were 'int' variables that could overflow on 64-bit hosts;
9217 they were never used, so remove them instead of repairing them.
211a0b2a 9218 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9219 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9220 Previously, this ceilinged at INT_MAX, but that doesn't work on
9221 64-bit machines.
e46bb31a 9222 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9223
c78baabf 9224 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9225 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9226 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9227 when a (possibly-narrower) signed value would do just as well.
9228 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9229
c9d624c6
PE
9230 * alloc.c: Catch some string size overflows that we were missing.
9231 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9232 for convenience in STRING_BYTES_MAX.
9233 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9234 The definition here is exact; the one in lisp.h was approximate.
9235 (allocate_string_data): Check for string overflow. This catches
9236 some instances we weren't catching before. Also, it catches
9237 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9238 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9239 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9240
c9d624c6
PE
9241 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9242 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9243 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9244
353032ce
PE
9245 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9246
2bccce07
PE
9247 * alloc.c (Fmake_string): Check for out-of-range init.
9248
0ac30604
SM
92492011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9250
9251 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9252
c195f2de
JD
92532011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9254
9255 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9256 xg_get_default_scrollbar_width.
9257
9258 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9259 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9260 (style_changed_cb): Call update_theme_scrollbar_width and call
9261 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9262 all frames (Bug#8505).
9263 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9264 Call gtk_window_set_resizable if HAVE_GTK3.
9265 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9266 and height if HAVE_GTK3 (Bug#8505).
9267 (scroll_bar_width_for_theme): New variable.
9268 (update_theme_scrollbar_width): New function.
9269 (xg_get_default_scrollbar_width): Move code to
9270 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9271 (xg_initialize): Call update_theme_scrollbar_width.
9272
9273 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9274
9275 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9276
e10ac9f1
MR
92772011-06-12 Martin Rudalics <rudalics@gmx.at>
9278
9279 * frame.c (make_frame): Call other_buffer_safely instead of
9280 other_buffer.
9281
9282 * window.c (temp_output_buffer_show): Call display_buffer with
9283 second argument Vtemp_buffer_show_specifiers and reset latter
9284 immediately after the call.
9285 (Vtemp_buffer_show_specifiers): New variable.
9286 (auto_window_vscroll_p, next_screen_context_lines)
9287 (Vscroll_preserve_screen_position): Remove leading asterisks from
9288 doc-strings.
9289
2d3c217e 92902011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9291
7b7f97e8 9292 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9293 * buffer.c (Qclone_number): Remove for now, as it's unused.
9294 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9295 (record_buffer): Remove unused local.
9296 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9297 (set_frame_buffer_list): Remove; unused.
9298 * frame.h (other_visible_frames): Remove decl.
9299 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9300 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9301 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9302 if HAVE_GPM.
9303 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9304 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9305 Define only if HAVE_GPM.
9306 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9307 (update_hints_inhibit): Remove; never set. All uses removed.
9308 * widgetprv.h (emacsFrameClassRec): Remove decl.
9309 * window.c (delete_deletable_window): Now returns void, since it
9310 wasn't returning anything.
9311 (compare_window_configurations): Remove unused locals.
9312 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9313 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9314 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9315 the same widths as pointers. This follows up on the 2011-05-06 patch.
9316 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9317 * xterm.h: Likewise.
9318 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9319
1384b89e
JB
93202011-06-12 Juanma Barranquero <lekktu@gmail.com>
9321
9322 * makefile.w32-in: Update dependencies.
9323 (LISP_H): Add lib/intprops.h.
9324
1100a63c
CY
93252011-06-11 Chong Yidong <cyd@stupidchicken.com>
9326
9327 * image.c (gif_load): Add animation frame delay to the metadata.
9328 (syms_of_image): Use DEFSYM. New symbol `delay'.
9329
6198ccd0
MR
93302011-06-11 Martin Rudalics <rudalics@gmx.at>
9331
9332 * window.c (delete_deletable_window): Re-add.
9333 (Fset_window_configuration): Rewrite to handle dead buffers and
9334 consequently deletable windows.
9335 (window_tree, Fwindow_tree): Remove. Supply functionality in
9336 window.el.
9337 (compare_window_configurations): Simplify code.
9338
b6e3633c
AS
93392011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9340
1ab0dee5
AS
9341 * image.c (imagemagick_load_image): Fix type mismatch.
9342 (Fimagemagick_types): Likewise.
9343
b6e3633c
AS
9344 * window.h (replace_buffer_in_windows): Declare.
9345
9397e56f
MR
93462011-06-11 Martin Rudalics <rudalics@gmx.at>
9347
9348 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9349 Qclone_number. Remove external declaration of Qdelete_window.
9350 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9351 code.
640c8776
SM
9352 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9353 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9354 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9355 buffer list implementation.
9356 (other_buffer_safely): New function.
9357 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9358 calls to replace_buffer_in_windows and
9359 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9360 if allowed.
9361 (record_buffer): Inhibit quitting and rewrite using quittable
9362 functions. Run Qbuffer_list_update_hook if allowed.
9363 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9364 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9365 Move switch-to-buffer to window.el.
9397e56f
MR
9366 (bury-buffer): Move to window.el.
9367 (Vbuffer_list_update_hook): New variable.
9368
9369 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9370 section.
9371
9372 * window.h (resize_frame_windows): Move up in code.
9373 (Fwindow_frame): Remove EXFUN.
9374 (replace_buffer_in_all_windows): Remove prototype.
9375 (replace_buffer_in_windows_safely): Add prototype.
9376
9377 * window.c: Declare Qdelete_window static again. Move down
9378 declaration of select_count.
9379 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9380 (Fother_window): Move to window.el.
9381 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9382 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9383 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9384 window.el.
9385 (replace_buffer_in_windows): Implement by calling
9386 Qreplace_buffer_in_windows.
9387 (replace_buffer_in_all_windows): Remove with some functionality
9388 moved into replace_buffer_in_windows_safely.
9389 (replace_buffer_in_windows_safely): New function.
9390 (select_window_norecord, select_frame_norecord): Move in front
9391 of run_window_configuration_change_hook. Remove now obsolete
9392 declarations.
640c8776
SM
9393 (Fset_window_buffer): Rewrite doc-string.
9394 Call Qrecord_window_buffer.
9397e56f
MR
9395 (keys_of_window): Move binding for other-window to window.el.
9396
b50691aa
CY
93972011-06-11 Chong Yidong <cyd@stupidchicken.com>
9398
9399 * dispextern.h (struct image): Replace data member, whose int_val
9400 and ptr_val fields were not used by anything, with a single
9401 lisp_val object.
9402
9403 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9404 (gif_clear_image, gif_load, imagemagick_load_image)
9405 (gs_clear_image, gs_load): Callers changed.
9406
3f754b86
PE
94072011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9408
cca69397
PE
9409 * buffer.h: Include <time.h>, for time_t.
9410 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9411
109e28d0
PE
9412 Fix minor problems found by static checking.
9413
60737f02
PE
9414 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9415
4b66faf3
PE
9416 Make identifiers static if they are not used in other modules.
9417 * data.c (Qcompiled_function, Qframe, Qvector):
9418 * image.c (QimageMagick, Qsvg):
9419 * minibuf.c (Qmetadata):
9420 * window.c (resize_window_check, resize_root_window): Now static.
9421 * window.h (resize_window_check, resize_root_window): Remove decls.
9422
109e28d0
PE
9423 * window.c (window_deletion_count, delete_deletable_window):
9424 Remove; unused.
46a4ce9e
PE
9425 (window_body_lines): Now static.
9426 (Fdelete_other_windows_internal): Mark vars as initialized.
9427 Make sure 'resize_failed' is initialized.
9428 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9429 (resize_window_apply): Remove unused local.
9430 * window.h (delete_deletable_window): Remove decl.
9431
109e28d0 9432 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9433 (imagemagick_load_image): Fix pointer signedness problem by changing
9434 last arg from unsigned char * to char *. All uses changed.
9435 Also, fix a local for similar reasons.
9436 Remove unused locals. Remove locals to avoid shadowing.
9437 (fn_rsvg_handle_free): Remove; unused.
9438 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9439 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9440
3f754b86
PE
9441 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9442
2547adb1
CY
94432011-06-10 Chong Yidong <cyd@stupidchicken.com>
9444
9445 * image.c (gif_load): Fix omitted cast error introduced by
9446 2011-06-06 change.
9447
2c8e37d4
MR
94482011-06-10 Martin Rudalics <rudalics@gmx.at>
9449
9450 * window.h (resize_proportionally, orig_total_lines)
9451 (orig_top_line): Remove from window structure.
9452 (set_window_height, set_window_width, change_window_heights)
9453 (Fdelete_window): Remove prototypes.
9454 (resize_frame_windows): Remove duplicate declaration.
9455
440a42e3
EZ
94562011-06-10 Eli Zaretskii <eliz@gnu.org>
9457
9458 * window.h (resize_frame_windows, resize_window_check)
9459 (delete_deletable_window, resize_root_window)
9460 (resize_frame_windows): Declare prototypes.
9461
9462 * window.c (resize_window_apply): Make definition be "static" to
9463 match the prototype.
9464
562dd5e9
MR
94652011-06-10 Martin Rudalics <rudalics@gmx.at>
9466
9467 * window.c: Remove declarations of Qwindow_size_fixed,
9468 window_min_size_1, window_min_size_2, window_min_size,
9469 size_window, window_fixed_size_p, enlarge_window, delete_window.
9470 Remove static from declaration of Qdelete_window, it's
9471 temporarily needed by Fbury_buffer.
9472 (replace_window): Don't assign orig_top_line and
9473 orig_total_lines.
9474 (Fdelete_window, delete_window): Remove. Window deletion is
9475 handled by window.el.
640c8776
SM
9476 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9477 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9478 (Fdelete_other_windows): Remove. Deleting other windows is
9479 handled by window.el.
9480 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9481 handled in window.el.
9482 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9483 Window minimum sizes are handled in window.el.
9484 (shrink_windows, size_window, set_window_height)
9485 (set_window_width, change_window_heights, window_height)
9486 (window_width, CURBEG, CURSIZE, enlarge_window)
9487 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9488 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9489 handled in window.el.
9490 (make_dummy_parent): Rename to make_parent_window and give it a
9491 second argument horflag.
9492 (make_window): Don't set resize_proportionally any more.
9493 (Fsplit_window): Remove. Windows are split in window.el.
9494 (save_restore_action, save_restore_orig_size)
9495 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9496 Resize mini windows in window.el.
9497 (grow_mini_window, shrink_mini_window): Implement by calling
9498 Qresize_root_window_vertically, resize_window_check and
9499 resize_window_apply.
640c8776
SM
9500 (saved_window, Fset_window_configuration, save_window_save):
9501 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9502 resize_proportionally.
9503 (window_min_height, window_min_width): Move to window.el.
9504 (keys_of_window): Move bindings for delete-other-windows,
9505 split-window, delete-window and enlarge-window to window.el.
9506
9507 * buffer.c: Temporarily extern Qdelete_window.
9508 (Fbury_buffer): Temporarily call Qdelete_window instead of
9509 Fdelete_window (Fbury_buffer will move to window.el soon).
9510
9511 * frame.c (set_menu_bar_lines_1): Remove code handling
9512 orig_top_line and orig_total_lines.
9513
9514 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9515 set_window_height but set heights directly.
9516 (change_frame_size_1): Use resize_frame_windows.
9517
9518 * xdisp.c (init_xdisp): Don't use set_window_height but set
9519 heights directly.
9520
640c8776
SM
9521 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9522 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9523 run_window_configuration_change_hook.
9524
9525 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9526 instead of change_window_heights and run
9527 run_window_configuration_change_hook.
9528
1a13852e
MR
95292011-06-09 Martin Rudalics <rudalics@gmx.at>
9530
9531 * window.c (replace_window): Rename second argument REPLACEMENT to
9532 NEW. New third argument SETFLAG. Rewrite.
9533 (delete_window, make_dummy_parent): Call replace_window with
9534 third argument 1.
9535 (window_list_1): Move down in code.
9536 (run_window_configuration_change_hook): Move set_buffer part
9537 before select_frame_norecord part in order to unwind correctly.
9538 Rename count1 to count.
9539 (recombine_windows, delete_deletable_window, resize_root_window)
9540 (Fdelete_other_windows_internal)
9541 (Frun_window_configuration_change_hook, make_parent_window)
9542 (resize_window_check, resize_window_apply, Fresize_window_apply)
9543 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9544 (Fdelete_window_internal, Fresize_mini_window_internal):
9545 New functions.
1a13852e
MR
9546 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9547
f3d1777e
MR
95482011-06-08 Martin Rudalics <rudalics@gmx.at>
9549
496e208e
MR
9550 * window.h (window): Add some new members to window structure -
9551 normal_lines, normal_cols, new_total, new_normal, clone_number,
9552 splits, nest, prev_buffers, next_buffers.
9553 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9554 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9555
f3d1777e
MR
9556 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9557 Remove.
496e208e
MR
9558 (make_dummy_parent): Set new members of windows structure.
9559 (make_window): Move down in code. Handle new members of window
9560 structure.
9561 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9562 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9563 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9564 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9565 (Fset_window_next_buffers, Fset_window_clone_number):
9566 New functions.
496e208e
MR
9567 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9568 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9569 Doc-string fixes.
9570 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9571 Argument WINDOW can be now internal window too.
9572 (Fwindow_use_time): Move up in code.
9573 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9574 Rewrite doc-string.
9575 (Fset_window_configuration, saved_window)
9576 (Fcurrent_window_configuration, save_window_save): Handle new
9577 members of window structure.
b9e809c2
MR
9578 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9579 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9580 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9581 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9582 Qget_mru_window, Qresize_root_window,
9583 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9584 Qauto_buffer_name; staticpro them.
f3d1777e 9585
abde8f8c
MR
95862011-06-07 Martin Rudalics <rudalics@gmx.at>
9587
9588 * window.c (Fwindow_total_size, Fwindow_left_column)
9589 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9590 (Fwindow_list_1): New functions.
9591 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9592 (Fwindow_width, Fscroll_left, Fscroll_right):
9593 Use window_body_cols instead of window_box_text_cols.
9594 (delete_window, Fset_window_configuration):
9595 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9596 (delete_all_subwindows): Take a window as argument and not a
9597 structure. Rewrite.
190b47e6
MR
9598 (window_loop): Remove handling of GET_LRU_WINDOW and
9599 GET_LARGEST_WINDOW.
9600 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9601
9602 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9603 window_box_text_cols. delete_all_subwindows now takes a
9604 Lisp_Object as argument.
abde8f8c 9605
640c8776
SM
9606 * indent.c (compute_motion, Fcompute_motion):
9607 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9608
fa8a67e6
MR
9609 * frame.c (delete_frame): Call delete_all_subwindows with root
9610 window as argument.
9611
a54e3482
DC
96122011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9613
9614 * fns.c (Fputhash): Document return value.
9615
60002bf5
CY
96162011-06-06 Chong Yidong <cyd@stupidchicken.com>
9617
9618 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9619
0c671da6 96202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9621
b862a52a 9622 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9623
be44ca6c
PE
9624 Check for overflow when converting integer to cons and back.
9625 * charset.c (Fdefine_charset_internal, Fdecode_char):
9626 Use cons_to_unsigned to catch overflow.
9627 (Fencode_char): Use INTEGER_TO_CONS.
9628 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9629 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9630 * data.c (long_to_cons, cons_to_long): Remove.
9631 (cons_to_unsigned, cons_to_signed): New functions.
9632 These signal an error for invalid or out-of-range values.
9633 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9634 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9635 * font.c (Ffont_variation_glyphs):
9636 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9637 * lisp.h: Include <intprops.h>.
9638 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9639 (cons_to_signed, cons_to_unsigned): New decls.
9640 (long_to_cons, cons_to_long): Remove decls.
9641 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9642 (Fprimitive_undo): Use CONS_TO_INTEGER.
9643 * xfns.c (Fx_window_property): Likewise.
9644 * xselect.c: Include <limits.h>.
9645 (x_own_selection, selection_data_to_lisp_data):
9646 Use INTEGER_TO_CONS.
9647 (x_handle_selection_request, x_handle_selection_clear)
9648 (x_get_foreign_selection, Fx_disown_selection_internal)
9649 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9650 (lisp_data_to_selection_data): Use cons_to_unsigned.
9651 (x_fill_property_data): Use cons_to_signed.
9652 Report values out of range.
9653
d1f3d2af
PE
9654 Check for buffer and string overflow more precisely.
9655 * buffer.h (BUF_BYTES_MAX): New macro.
9656 * lisp.h (STRING_BYTES_MAX): New macro.
9657 * alloc.c (Fmake_string):
9658 * character.c (string_escape_byte8):
9659 * coding.c (coding_alloc_by_realloc):
9660 * doprnt.c (doprnt):
9661 * editfns.c (Fformat):
9662 * eval.c (verror):
9663 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9664 since they may not be the same number.
9665 * editfns.c (Finsert_char):
9666 * fileio.c (Finsert_file_contents):
9667 Likewise for BUF_BYTES_MAX.
9668
dd52fcea
PE
9669 * image.c: Use ptrdiff_t, not int, for sizes.
9670 (slurp_file): Switch from int to ptrdiff_t.
9671 All uses changed.
9672 (slurp_file): Check that file size fits in both size_t (for
9673 malloc) and ptrdiff_t (for sanity and safety).
9674
7f9bbdbb
PE
9675 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9676 if b->modtime has its maximal value.
9677
dfe18f82
PE
9678 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9679
84acfcf0
PE
9680 Don't assume time_t can fit into int.
9681 * buffer.h (struct buffer.modtime): Now time_t, not int.
9682 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9683 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9684
ccd9a01a
PE
9685 Minor fixes for signed vs unsigned integers.
9686 * character.h (MAYBE_UNIFY_CHAR):
9687 * charset.c (maybe_unify_char):
9688 * keyboard.c (read_char, reorder_modifiers):
9689 XINT -> XFASTINT, since the integer must be nonnegative.
9690 * ftfont.c (ftfont_spec_pattern):
9691 * keymap.c (access_keymap, silly_event_symbol_error):
9692 XUINT -> XFASTINT, since the integer must be nonnegative.
9693 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9694 since it makes no difference and we prefer signed.
9695 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9696 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9697 nonnegative.
9698
d6d100dd
SM
96992011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9700
9701 * window.h (Fwindow_frame): Declare.
9702
2b6148e4
PE
97032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9704
9705 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9706 (SPARE_MEMORY): Always define.
9707 (LARGE_REQUEST): Remove.
9708 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9709
f230ecc9
MR
97102011-06-06 Martin Rudalics <rudalics@gmx.at>
9711
727e958e
MR
9712 * lisp.h: Move EXFUNS for Fframe_root_window,
9713 Fframe_first_window and Fset_frame_selected_window to window.h.
9714
9715 * window.h: Move EXFUNS for Fframe_root_window,
9716 Fframe_first_window and Fset_frame_selected_window here from
9717 lisp.h.
9718
9719 * frame.c (Fwindow_frame, Fframe_first_window)
9720 (Fframe_root_window, Fframe_selected_window)
9721 (Fset_frame_selected_window): Move to window.c.
9722 (Factive_minibuffer_window): Move to minibuf.c.
9723 (Fother_visible_frames_p): New function.
9724
9725 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9726
f230ecc9
MR
9727 * window.c (decode_window, decode_any_window): Move up in code.
9728 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9729 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9730 (Fwindow_buffer): Move up and rewrite doc-string.
9731 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9732 (Fwindow_prev): New functions.
727e958e
MR
9733 (Fwindow_frame): Move here from frame.c. Accept any window as
9734 argument.
9735 (Fframe_root_window, Fframe_first_window)
9736 (Fframe_selected_window): Move here from frame.c. Accept frame
9737 or arbitrary window as argument. Update doc-strings.
9738 (Fminibuffer_window): Move up in code.
9739 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9740 (Fset_frame_selected_window): Move here from frame.c.
9741 Marginal rewrite.
727e958e
MR
9742 (Fselected_window, select_window, Fselect_window): Move up in
9743 code. Minor doc-string fixes.
f230ecc9 9744
4d09bcf6
PE
97452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9746
9747 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9748 Do not assume that spare memory exists; that assumption is valid
9749 only if SYSTEM_MALLOC.
9750 (LARGE_REQUEST): New macro, so that the issue of large requests
9751 is separated from the issue of spare memory.
9752
810928a2
AS
97532011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9754
172418ad
AS
9755 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9756 format. (Bug#8806)
9757
43f862f7
AS
9758 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9759
810928a2
AS
9760 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9761 before statements.
9762
a059fe24
JD
97632011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9764
9765 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9766
9767 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9768
9769 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9770 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9771
989bf368
JB
97722011-06-05 Juanma Barranquero <lekktu@gmail.com>
9773
9774 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9775
4b80f674
CY
97762011-06-04 Chong Yidong <cyd@stupidchicken.com>
9777
9778 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9779 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9780 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9781 New error handlers.
4b80f674
CY
9782 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9783 Obey Vx_select_enable_clipboard_manager. Catch errors in
9784 x_clipboard_manager_save (Bug#8779).
9785 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9786 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9787
99a33b77 97882011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9789
9790 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9791
99a33b77 97922011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9793
9794 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9795 in the current matrix if keep_current_p is non-zero.
9796
8264569d
EZ
97972011-06-04 Eli Zaretskii <eliz@gnu.org>
9798
9799 * bidi.c (bidi_level_of_next_char): Fix last change.
9800
57f97249
EZ
98012011-06-03 Eli Zaretskii <eliz@gnu.org>
9802
fec2107c 9803 Support bidi reordering of text covered by display properties.
57f97249 9804
fec2107c
EZ
9805 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9806 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9807 (bidi_cache_search, bidi_cache_iterator_state)
9808 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9809 (bidi_level_of_next_char, bidi_move_to_visually_next):
9810 Support character positions inside a run of characters covered by a
fec2107c
EZ
9811 display string.
9812 (bidi_paragraph_init, bidi_resolve_explicit_1)
9813 (bidi_level_of_next_char): Call bidi_fetch_char and
9814 bidi_fetch_char_advance instead of FETCH_CHAR and
9815 FETCH_CHAR_ADVANCE.
9816 (bidi_init_it): Initialize new members.
9817 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9818 definitions.
9819 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9820 instead of using explicit *_CHAR codes.
d6d100dd
SM
9821 (bidi_resolve_explicit, bidi_resolve_weak):
9822 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9823 bidirectional text is supported only in multibyte buffers.
9824 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9825 it to initialize the frame_window_p member of struct bidi_it.
9826 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9827 (bidi_resolve_explicit, bidi_resolve_weak)
9828 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9829 bidi_it->nchars is non-positive.
9830 (bidi_level_of_next_char): Don't try to lookup the cache for the
9831 next/previous character if nothing is cached there yet, or if we
9832 were just reseat()'ed to a new position.
c40e2fb2 9833
0e14fe90
EZ
9834 * xdisp.c (set_cursor_from_row): Set start and stop points
9835 according to the row's direction when priming the loop that looks
9836 for the glyph on which to display cursor.
9837 (single_display_spec_intangible_p): Function deleted.
9838 (display_prop_intangible_p): Reimplement to call
9839 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9840 Accept 3 additional arguments needed by handle_display_spec.
9841 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9842 values: lists, `(when COND...)' forms, etc.
9843 (single_display_spec_string_p): Support property values that are
9844 lists with the argument STRING its top-level element.
9845 (display_prop_string_p): Fix the condition for processing a
9846 property that is a list to be consistent with handle_display_spec.
fec2107c 9847 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9848 last portion of handle_display_prop.
9849 (compute_display_string_pos): Accept additional argument
9850 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9851 value of a `display' property is a "replacing spec".
9852 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9853 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9854 the display property, but just return a value indicating whether
9855 the display property will replace the characters it covers.
9856 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9857 frame_window_p members of struct bidi_it.
d6d100dd
SM
9858 (compute_display_string_pos, compute_display_string_end):
9859 New functions.
fec2107c
EZ
9860 (push_it): Accept second argument POSITION, where pop_it should
9861 jump to continue iteration.
9862 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9863
fec2107c
EZ
9864 * keyboard.c (adjust_point_for_property): Adjust the call to
9865 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9866
9867 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9868 (bidi_init_it): Update prototypes.
9869 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9870 (compute_display_string_pos, compute_display_string_end):
9871 Declare prototypes.
fec2107c
EZ
9872 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9873 EMACS_INT.
fc6f18ce 9874
40087514 98752011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9876
57f53182
PE
9877 Malloc failure behavior now depends on size of allocation.
9878 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9879 * lisp.h: Change signatures accordingly.
9880 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9881 All callers changed. (Bug#8762)
9882
9883 * gnutls.c: Use Emacs's memory allocators.
9884 Without this change, the gnutls library would invoke malloc etc.
9885 directly, which causes problems on non-SYNC_INPUT hosts, and which
9886 runs afoul of improving memory_full behavior. (Bug#8761)
9887 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9888 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9889 xfree instead of the default malloc, realloc, free.
9890 (Fgnutls_boot): No need to check for memory allocation failure,
9891 since xmalloc does that for us.
9892
ac32cd99 9893 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9894 * category.c (hash_get_category_set):
9895 * ccl.c (ccl_driver):
9896 * charset.c (Fdefine_charset_internal):
9897 * charset.h (struct charset.hash_index):
9898 * composite.c (get_composition_id, gstring_lookup_cache)
9899 (composition_gstring_put_cache):
9900 * composite.h (struct composition.hash_index):
9901 * dispextern.h (struct image.hash):
9902 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9903 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9904 (hashfn_equal, hashfn_user_defined, make_hash_table)
9905 (maybe_resize_hash_table, hash_lookup, hash_put)
9906 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9907 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9908 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9909 * image.c (make_image, search_image_cache, lookup_image)
9910 (xpm_put_color_table_h):
9911 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9912 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9913 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9914 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9915 * alloc.c (allocate_vectorlike):
9916 Check for overflow in vector size calculations.
9917 * ccl.c (ccl_driver):
9918 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9919 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9920 need to be updated by these changes.
40087514
PE
9921 * fns.c (make_hash_table, maybe_resize_hash_table):
9922 Check for integer overflow with large hash tables.
0de4bb68
PE
9923 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9924 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9925 (SXHASH_REDUCE): New macro.
9926 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9927 Use it instead of discarding useful hash info with large hash values.
9928 (sxhash_float): New function.
9929 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9930 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9931 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9932 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9933 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9934 Adjust signatures to match updated version of code.
9935 (consing_since_gc): Now EMACS_INT, since a single hash table can
9936 use more than INT_MAX bytes.
9937
698d32e2
DN
99382011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9939
9940 Make it possible to build with GCC-4.6+ -O2 -flto.
9941
9942 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9943
fd6fa53f
SM
99442011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9945
9946 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9947 Call minibuffer-inactive-mode.
9948
864db017
JB
99492011-05-31 Juanma Barranquero <lekktu@gmail.com>
9950
9951 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9952 Update dependencies.
9953
2ad0baf4
DN
99542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9955
9956 * data.c (init_data): Remove code for UTS, this system is not
9957 supported anymore.
9958
4fcc2638
DN
99592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9960
9961 Don't force ./temacs to start in terminal mode.
9962
9963 * frame.c (make_initial_frame): Initialize faces in all cases, not
9964 only when CANNOT_DUMP is defined.
9965 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9966
c56e0fd5
DN
99672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9968
9969 * dispnew.c (add_window_display_history): Use const for the string
9970 pointer. Remove declaration, not needed.
9971
333d54da 99722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9973
55d4c1b2 9974 Use 'inline', not 'INLINE'.
333d54da 9975 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9976 * alloc.c, fontset.c (INLINE): Remove.
9977 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9978 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9979 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9980 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9981 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9982
738db178
DN
99832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9984
9985 Make it possible to run ./temacs.
9986
9987 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9988 syms_of_callproc does the same thing. Remove test for
9989 "initialized", do it in the caller.
9990 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9991
620c53a6
SM
99922011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9993
9994 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9995 (read_minibuf): Use get_minibuffer.
9996 (syms_of_minibuf): Use DEFSYM.
9997 (Qmetadata): New var.
9998 * data.c (Qbuffer): Don't make it static.
9999 (syms_of_data): Use DEFSYM.
10000
e003a292
PE
100012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10002
10003 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10004 (CCL_CODE_MIN): New macro.
10005
ed008a6d
PE
100062011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10007
3687c2ef
PE
10008 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10009
ed008a6d
PE
10010 * eval.c (Qdebug): Now static.
10011 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10012 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10013 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10014
d66c4c7c
CY
100152011-05-29 Chong Yidong <cyd@stupidchicken.com>
10016
10017 * image.c: Various fixes to ImageMagick code comments.
10018 (Fimagemagick_types): Doc fix.
10019
5fbc2025
PE
100202011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10021
0196f88a
PE
10022 Minor fixes prompted by GCC 4.6.0 warnings.
10023
10024 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10025
5fbc2025
PE
10026 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10027 (x_clipboard_manager_save_all): Move extern decl to ...
10028 * xterm.h: ... here, so that it can be checked for consistency.
10029
1dd3c2d9
CY
100302011-05-29 Chong Yidong <cyd@stupidchicken.com>
10031
10032 * xselect.c (x_clipboard_manager_save_frame)
10033 (x_clipboard_manager_save_all): New functions.
10034 (Fx_clipboard_manager_save): Lisp function deleted.
10035
10036 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10037 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10038
10039 * xterm.h: Update prototype.
10040
5ba6571d
WX
100412011-05-28 William Xu <william.xwl@gmail.com>
10042
10043 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10044 exiting (Bug#8239).
10045
3eaff834
JM
100462011-05-28 Jim Meyering <meyering@redhat.com>
10047
e1900994 10048 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10049 * fns.c (to_uchar): Define.
10050 (crypto_hash_function): Use it to convert some newly-signed
10051 variables to unsigned, to avoid sign-extension bugs. For example,
10052 without this change, (md5 "truc") would evaluate to
10053 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10054 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10055 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10056
0f6990a7
PE
100572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10058
10059 Integer overflow fixes.
c8a9ca5a 10060
08686060
PE
10061 * dbusbind.c: Serial number integer overflow fixes.
10062 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10063 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10064 to hold a serial number that is too large for a fixnum.
10065 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10066 Check for serial numbers out of range. Decode any serial number
59568bf0 10067 that was so large that it became a float. (Bug#8722)
08686060 10068
2d1fc3c7
PE
10069 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10070 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10071 Use XFASTINT rather than XUINT when numbers are nonnegative.
10072 (xd_append_arg, Fdbus_method_return_internal):
10073 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10074 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10075 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10076 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10077 (Bug#8722)
2d1fc3c7 10078
c8a9ca5a
PE
10079 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10080
519e1d69
PE
10081 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10082
6df6ae42 10083 ccl: Add integer overflow checks.
30569699
PE
10084 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10085 (IN_INT_RANGE): New macros.
10086 (ccl_driver): Use them to check for integer overflow when
10087 decoding a CCL program. Many of the new checks are whether XINT (x)
10088 fits in int; it doesn't always, on 64-bit hosts. The new version
10089 doesn't catch all possible integer overflows, but it's an
847044ea 10090 improvement. (Bug#8719)
30569699 10091
c11285dc
PE
10092 * alloc.c (make_event_array): Use XINT, not XUINT.
10093 There's no need for unsigned here.
10094
fdccd48e
PE
10095 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10096 This follows up to the 2011-05-06 change that substituted uintptr_t
10097 for EMACS_INT. This case wasn't caught back then.
10098
37910ab2
PE
10099 Rework Fformat to avoid integer overflow issues.
10100 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10101 now (part of C89). Include <verify.h>.
10102 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10103 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10104 (Fformat): Avoid the prepass trying to compute sizes; it was only
10105 approximate and thus did not catch overflow reliably. Instead, walk
10106 through the format just once, formatting and computing sizes as we go,
10107 checking for integer overflow at every step, and allocating a larger
10108 buffer as needed. Keep track separately whether the format is
10109 multibyte. Keep only the most-recently calculated precision, rather
10110 than them all. Record whether each argument has been converted to
10111 string. Use EMACS_INT, not int, for byte and char and arg counts.
10112 Support field widths and precisions larger than INT_MAX. Avoid
10113 sprintf's undefined behavior with conversion specifications such as %#d
10114 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10115 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10116 formatting out-of-range floating point numbers with int
9173deec 10117 formats. (Bug#8668)
37910ab2 10118
2e6578fb
PE
10119 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10120
0ae6bdee
PE
10121 * data.c: Avoid integer truncation in expressions involving floats.
10122 * data.c: Include <intprops.h>.
10123 (arith_driver): When there's an integer overflow in an expression
10124 involving floating point, convert the integers to floating point
10125 so that the resulting value does not suffer from catastrophic
10126 integer truncation. For example, on a 64-bit host (* 4
10127 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10128 Do not rely on undefined behavior after integer overflow.
10129
de883a70
PE
10130 merge count_size_as_multibyte, parse_str_to_multibyte
10131 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10132 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10133 Check for integer overflow.
10134 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10135 since it's now a duplicate of the other. This is more of
10136 a character than a buffer op, so better that it's in character.c.
10137 * fns.c, print.c: Adjust to above changes.
10138
2ff916cb
PE
101392011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10140
10141 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10142
f1b54466
PE
101432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10144
fb1ac845
PE
10145 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10146 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10147 (x_clipboard_manager_save): Now static.
10148 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10149
f1b54466
PE
10150 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10151 (crypto_hash_function): Now static.
10152 Fix pointer signedness problems. Avoid unnecessary initializations.
10153
a9f737ee
CY
101542011-05-27 Chong Yidong <cyd@stupidchicken.com>
10155
10156 * termhooks.h (Vselection_alist): Make it terminal-local.
10157
10158 * terminal.c (create_terminal): Initialize it.
10159
10160 * xselect.c: Support for clipboard managers.
10161 (Vselection_alist): Move to termhooks.h as terminal-local var.
10162 (LOCAL_SELECTION): New macro.
10163 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10164 (symbol_to_x_atom): Remove gratuitous arg.
10165 (x_handle_selection_request, lisp_data_to_selection_data)
10166 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10167 (x_own_selection, x_get_local_selection, x_convert_selection):
10168 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10169 (some_frame_on_display): Delete unused function.
10170 (Fx_own_selection_internal, Fx_get_selection_internal)
10171 (Fx_disown_selection_internal, Fx_selection_owner_p)
10172 (Fx_selection_exists_p): New optional frame arg.
10173 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10174 (x_handle_selection_clear): Don't treat other terminals with the
10175 same keyboard specially. Use the terminal-local Vselection_alist.
10176 (x_clear_frame_selections): Use Frun_hook_with_args.
10177
10178 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10179
10180 * xterm.h: Add support for those atoms.
10181
e067f0c1
CY
101822011-05-26 Chong Yidong <cyd@stupidchicken.com>
10183
10184 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10185 (converted_selections, conversion_fail_tag): New global variables.
10186 (x_selection_request_lisp_error): Free the above.
10187 (x_get_local_selection): Remove unnecessary code.
10188 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10189 of converted selections stored in converted_selections.
10190 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10191 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10192 (x_convert_selection): New function.
10193 (x_handle_selection_event): Simplify.
10194 (x_get_foreign_selection): Don't ignore incoming requests while
10195 waiting for an answer; this will fail when we implement
10196 SAVE_TARGETS, and seems unnecessary anyway.
10197 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10198 (Vx_sent_selection_functions): Doc fix.
10199
0f4aebc0
LL
102002011-05-26 Leo Liu <sdl.web@gmail.com>
10201
10202 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10203
e61124cd
YM
102042011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10205
10206 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10207
10208 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10209 for fringe update if it has periodic bitmap.
ac389d0c 10210 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10211 and fringe_bitmap_periodic_p.
10212
10213 * fringe.c (get_fringe_bitmap_data): New function.
10214 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10215 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10216 row. Mark glyph row for fringe update if periodicity changed.
10217
10218 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10219 for fringe update unless it has periodic bitmap.
10220
f16d9837
KH
102212011-05-25 Kenichi Handa <handa@m17n.org>
10222
10223 * xdisp.c (get_next_display_element): Set correct it->face_id for
10224 a static composition.
10225
e1b90ef6
LL
102262011-05-24 Leo Liu <sdl.web@gmail.com>
10227
10228 * deps.mk (fns.o):
10229 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10230
10231 * fns.c (crypto_hash_function, Fsha1): New function.
10232 (Fmd5): Use crypto_hash_function.
10233 (syms_of_fns): Add Ssha1.
10234
7400048f
PE
102352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10236
10237 * gnutls.c: Remove unused macros.
10238 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10239 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10240 Remove macros that are defined and never used.
10241 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10242
abb71cf4
CY
102432011-05-22 Chong Yidong <cyd@stupidchicken.com>
10244
10245 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10246 (Fx_get_selection_internal): Minor cleanup.
10247 (Fx_own_selection_internal): Rename arguments for consistency with
10248 select.el.
10249
6307db39
PE
102502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10251
10252 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10253
f3d4e0a4
CY
102542011-05-22 Chong Yidong <cyd@stupidchicken.com>
10255
10256 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10257
4d8ade89
YM
102582011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10259
10260 * dispnew.c (scrolling_window): Don't exclude the case that the
10261 last enabled row in the desired matrix touches the bottom boundary.
10262
32078c8d
GM
102632011-05-21 Glenn Morris <rgm@gnu.org>
10264
10265 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10266 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10267 and add some more files.
32078c8d 10268
7285dc67
EZ
102692011-05-20 Eli Zaretskii <eliz@gnu.org>
10270
10271 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10272 report_file_error introduced by the change from 2011-05-07.
10273
89d1bd22
PE
102742011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10275
10276 * systime.h (Time): Define only if emacs is defined.
10277 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10278 where the include path doesn't have X11/X.h by default. See
10279 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10280
cd394be1 102812011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10282
10283 * composite.c (find_automatic_composition): Fix previous change.
10284
b9704ad9
GM
102852011-05-20 Glenn Morris <rgm@gnu.org>
10286
10287 * lisp.mk: New file, split from Makefile.in.
10288 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10289 (shortlisp): Remove.
10290 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10291
4a720484
GM
102922011-05-19 Glenn Morris <rgm@gnu.org>
10293
10294 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10295 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10296 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10297 (lisp): Set the order to that of loadup.el.
10298 (shortlisp): Make it a copy of $lisp.
10299 (SOME_MACHINE_LISP): Remove.
10300 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10301 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10302
a28d4396
KH
103032011-05-18 Kenichi Handa <handa@m17n.org>
10304
10305 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10306 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10307 (find_automatic_composition): Mostly rewrite for efficiency.
10308
a2b1fa8e
JB
103092011-05-18 Juanma Barranquero <lekktu@gmail.com>
10310
10311 * makefile.w32-in: Update dependencies.
10312
8e1f5610
CS
103132011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10314
10315 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10316 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10317
7025ee00 103182011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10319
cdfa6eab
PE
10320 Fix some integer overflow issues, such as string length overflow.
10321
06d6db33
PE
10322 * insdel.c (count_size_as_multibyte): Check for string overflow.
10323
2b4560a8
PE
10324 * character.c (lisp_string_width): Check for string overflow.
10325 Use EMACS_INT, not int, for string indexes and lengths; in
10326 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10327 the resulting string length overflows an EMACS_INT; instead,
10328 report a string overflow if no precision given. When checking for
10329 precision exhaustion, use a check that cannot possibly have
10330 integer overflow. (Bug#8675)
10331 * character.h (lisp_string_width): Adjust to new signature.
10332
cb93f9be
PE
10333 * alloc.c (string_overflow): New function.
10334 (Fmake_string): Use it. This doesn't change behavior, but saves
10335 a few bytes and will simplify future changes.
10336 * character.c (string_escape_byte8): Likewise.
10337 * lisp.h (string_overflow): New decl.
10338
1a1f3366
PE
10339 Fixups, following up to the user-interface timestamp change.
10340 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10341 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10342 * msdos.c (mouse_get_pos): Likewise.
10343 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10344 * w32gui.h (Time): Define by including "systime.h" rather than by
10345 declaring it ourselves. (Bug#8664)
10346
d4e3e4d3
PE
10347 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10348 * image.c (clear_image_cache): Likewise.
10349
f6a24d19
PE
10350 * term.c (term_mouse_position): Don't assume time_t wraparound.
10351
08dc5ae6
PE
10352 Be more systematic about user-interface timestamps.
10353 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10354 and sometimes 'EMACS_UINT', to represent these timestamps.
10355 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10356 This makes the code easier to follow, and makes it easier to catch
10357 integer overflow bugs such as Bug#8664.
10358 * frame.c (Fmouse_position, Fmouse_pixel_position):
10359 Use Time, not unsigned long, for user-interface timestamps.
10360 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10361 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10362 * keyboard.h (last_event_timestamp): Likewise.
10363 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10364 * menu.h (xmenu_show): Likewise.
10365 * term.c (term_mouse_position): Likewise.
10366 * termhooks.h (struct input_event.timestamp): Likewise.
10367 (struct terminal.mouse_position_hook): Likewise.
10368 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10369 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10370 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10371 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10372 what it was before.
10373 * menu.h, termhooks.h: Include "systime.h", for Time.
10374
8e55734a
PE
10375 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10376 Don't assume that the difference between two unsigned long values
10377 can fit into an integer. At this point, we know button_down_time
10378 <= event->timestamp, so the difference must be nonnegative, so
10379 there's no need to cast the result if double-click-time is
10380 nonnegative, as it should be; check that it's nonnegative, just in
10381 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10382 apart (about 25 days). (Bug#8664)
8e55734a 10383
841f1b75 10384 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10385 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10386
3e26f69c
PE
10387 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10388 that always fit in int. Use a sentinel instead of a counter, to
10389 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10390 * frame.h (struct frame): Use int for menu_bar_items_used
10391 instead of EMACS_INT, since it always fits in int.
3e26f69c 10392
5cc152c0
PE
10393 * menu.c (grow_menu_items): Check for int overflow.
10394
d89eb65e
PE
10395 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10396
5235bd3e
PE
10397 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10398 Before, the code was not consistent. These values cannot exceed
10399 2**31 - 1 so there's no need to make them unsigned.
10400 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10401 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10402 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10403 as modifiers.
10404 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10405
bc827e23
PE
10406 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10407 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10408 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10409 presumably because the widths might not match.
10410
78eb494e
PE
10411 * window.c (size_window): Avoid needless test at loop start.
10412
04f2d78b
CB
104132011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10414
10415 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10416
d2fc7e3d 104172011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10418
10419 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10420
d2fc7e3d 104212011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10422
10423 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10424 `width' to `bar_area_x' and `bar_area_width', respectively.
10425 (x_scroll_run): Take account of fringe background extension.
10426
04f2d78b
CB
10427 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10428 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10429 `bar_area_width', respectively.
10430 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10431 background extension.
10432
79b70037
GM
104332011-05-10 Jim Meyering <meyering@redhat.com>
10434
10435 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10436
2f142cc5
JB
104372011-05-10 Juanma Barranquero <lekktu@gmail.com>
10438
10439 * image.c (Finit_image_library): Return t for built-in image types,
10440 like pbm and xbm. (Bug#8640)
10441
57679c86
AS
104422011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10443
10444 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10445
888c9e86
EZ
104462011-05-07 Eli Zaretskii <eliz@gnu.org>
10447
b0512a1d
EZ
10448 * w32console.c (Fset_screen_color): Doc fix.
10449 (Fget_screen_color): New function.
10450 (syms_of_ntterm): Defsubr it.
10451
7285dc67
EZ
10452 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10453 unlink the temporary file if Fcall_process didn't create it in the
10454 first place.
10455 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10456 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10457 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10458 cue to call_process_cleanup not to close that handle.
10459
4d3fcc8e
BK
104602011-05-07 Ben Key <bkey76@gmail.com>
10461
10462 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10463 one of two shell specific rules, either bootstrap-temacs-CMD or
10464 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10465 to the previous implementation of the bootstrap-temacs rule.
10466 The bootstrap-temacs-CMD rule is similar to the previous
10467 implementation of the bootstrap-temacs rule except that it
10468 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10469 variable.
10470
10471 These changes, along with some changes to nt/configure.bat,
10472 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10473 earlier fix to add support for --cflags and --ldflags options
10474 that include quotes so that it works whether make uses cmd or
10475 sh as the shell.
10476
b4289b64
MA
104772011-05-06 Michael Albinus <michael.albinus@gmx.de>
10478
10479 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10480 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10481 is a constant.
10482 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10483 a string. Handle both cases.
10484 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10485 (Fdbus_register_method): Use Qinvalid_function.
10486
af4c0e28
JB
104872011-05-06 Juanma Barranquero <lekktu@gmail.com>
10488
10489 * makefile.w32-in: Update dependencies.
10490 (LISP_H): Add inttypes.h and stdin.h.
10491 (PROCESS_H): Add unistd.h.
10492
c51453d9
EZ
104932011-05-06 Eli Zaretskii <eliz@gnu.org>
10494
10495 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10496 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10497
8ff0ac3c 104982011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10499
4c4b566b
PE
10500 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10501
aab2b9b5
PE
10502 * term.c (vfatal): Remove stray call to va_end.
10503 It's not needed and the C Standard doesn't allow it here anyway.
10504
c378da0b
PE
10505 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10506 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10507
288b08c7
PE
10508 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10509 bytes.
10510
e3601888
PE
10511 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10512
db6c0e74
PE
10513 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10514
dd5963ea
PE
10515 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10516
88c9450f
PE
10517 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10518
2f9442b8
PE
10519 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10520
c032b5f8
PE
10521 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10522 * charset.c (Fdefine_charset_internal): Don't initialize
10523 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10524 32-bit int (Bug#8600).
a108c10b
PE
10525
10526 * lread.c (read_integer): Be more consistent with string-to-number.
10527 Use string_to_number to do the actual conversion; this avoids
10528 rounding errors and fixes some other screwups. Without this fix,
10529 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10530 (digit_to_number): Move earlier, for benefit of read_integer.
10531 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10532 not a digit in any supported base. (Bug#8602)
a108c10b 10533
ad5f9eea
PE
10534 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10535
aec1708a
PE
10536 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10537 to match comment at start of function. This also removes a
10538 GCC warning about overflow in a 32+64-bit port.
10539
47be4ab5
PE
10540 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10541
371cac43
PE
10542 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10543 Reported by Stefan Monnier in
10544 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10545 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10546 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10547
d01a7826
PE
10548 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10549 (EMACS_UINTPTR): Likewise, with uintptr_t.
10550
7fd47d5c
PE
10551 * lisp.h: Prefer 64-bit EMACS_INT if available.
10552 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10553 on 32-bit hosts that have 64-bit int, so that they can access
10554 large files.
122b0c86
PE
10555 However, temporarily disable this change unless the temporary
10556 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10557
8727937b
PE
10558 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10559
8ac068ac
PE
10560 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10561 This removes an assumption that EMACS_INT and long are the same
10562 width as pointers. The assumption is true for Emacs porting targets
10563 now, but we want to make other targets possible.
10564 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10565 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10566 In the rest of the code, change types of integers that hold casted
10567 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10568 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10569 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10570 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10571 No need to cast type when ORing.
10572 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10573 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10574 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10575 assume EMACS_INT is the same width as char *.
10576 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10577 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10578 Remove no-longer-needed casts.
10579 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10580 (xg_tool_bar_help_callback, xg_make_tool_item):
10581 Use EMACS_INTPTR to hold an integer
10582 that will be cast to void *; this can avoid a GCC warning
10583 if EMACS_INT is not the same width as void *.
10584 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10585 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10586 (current_message_1, set_message_1):
10587 Use a local to convert to proper width without a cast.
10588 * xmenu.c (dialog_selection_callback): Likewise.
10589
ede49d71
PE
10590 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10591 Also, don't assume VALBITS / RAND_BITS is less than 5,
10592 and don't rely on undefined behavior when shifting a 1 left into
10593 the sign bit.
10594 * lisp.h (get_random): Change signature to match.
10595
2f30ecd0
PE
10596 * lread.c (hash_string): Use size_t, not int, for hash computation.
10597 Normally we prefer signed values; but hashing is special, because
10598 it's better to use unsigned division on hash table sizes so that
10599 the remainder is nonnegative. Also, size_t is the natural width
10600 for hashing into memory. The previous code used 'int', which doesn't
10601 retain enough info to hash well into very large tables.
10602 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10603
2a866e7b
PE
10604 * dbusbind.c: Don't possibly lose pointer info when converting.
10605 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10606 Use XPNTR rather than XHASH, so that the high-order bits of
10607 the pointer aren't lost when converting through void *.
10608
51639eac
PE
10609 * eval.c (Fautoload): Don't double-shift a pointer.
10610
92394119
PE
10611 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10612
dbdb9a7c
JB
106132011-05-06 Juanma Barranquero <lekktu@gmail.com>
10614
10615 * gnutls.c (DEF_GNUTLS_FN):
10616 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10617
db7a0b4f
AS
106182011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10619
10620 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10621 marker. (Bug#8610)
10622
cd394be1 106232011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10624
10625 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10626 New version that can reserve upto 2GB of heap space.
10627
f7ff1b0f 106282011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10629
10630 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10631
639c109b
TZ
106322011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10633
10634 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10635 `gnutls_certificate_set_x509_key_file'.
10636
d2127135
JB
106372011-05-05 Juanma Barranquero <lekktu@gmail.com>
10638
10639 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10640 Update dependencies.
10641
e968f4f3
JB
106422011-05-04 Juanma Barranquero <lekktu@gmail.com>
10643
10644 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10645 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10646 Remove unused parameter `fildes'.
10647 * process.c (read_process_output, send_process): Don't pass it.
10648
84d358f0
JB
106492011-05-04 Juanma Barranquero <lekktu@gmail.com>
10650
10651 Fix previous change: the library cache is defined in w32.c.
10652 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10653 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10654
0898ca10
JB
106552011-05-04 Juanma Barranquero <lekktu@gmail.com>
10656
10657 Implement dynamic loading of GnuTLS on Windows.
10658
10659 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10660 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10661 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10662 Declare.
10663
10664 * gnutls.c (Qgnutls_dll): Define.
10665 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10666 (gnutls_*): Declare function pointers.
10667 (init_gnutls_functions): New function to initialize function pointers.
10668 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10669 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10670 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10671 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10672 (emacs_gnutls_write, emacs_gnutls_read)
10673 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10674 (Fgnutls_available_p): New function.
10675 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10676 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10677 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10678
10679 * image.c: Include w32.h.
10680 (Vimage_type_cache): Delete.
10681 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10682 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10683 (w32_delayed_load): Move to w32.c.
10684
10685 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10686
10687 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10688 (w32_delayed_load): Move from image.c. When loading a library, record
10689 its filename in the :loaded-from property of the library id.
10690 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10691 Initialize and staticpro them.
10692 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10693
10694 * process.c: Include lisp.h before w32.h, not after.
10695 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10696 instead of gnutls_record_check_pending.
10697
10698 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10699
ff4de4aa
TZ
107002011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10701
10702 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10703 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10704 as passed in.
10705
abe95abb
JD
107062011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10707
10708 * xterm.c (x_set_frame_alpha): Do not set property on anything
10709 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10710
e16e55d4
JB
107112011-05-02 Juanma Barranquero <lekktu@gmail.com>
10712
10713 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10714
bafcf6a5
JB
107152011-05-02 Juanma Barranquero <lekktu@gmail.com>
10716
10717 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10718 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10719 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10720 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10721 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10722 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10723 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10724 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10725 (Qgnutls_bootprop_callbacks_verify): Make static.
10726
e7a6747f
AS
107272011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10728
19ed11ba
AS
10729 * callproc.c: Indentation fixup.
10730
e7a6747f 10731 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10732 (wait_for_termination, interruptible_wait_for_termination):
10733 Move after wait_for_termination_1.
e7a6747f 10734
1ef14cb4
LMI
107352011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10736
10737 * sysdep.c (interruptible_wait_for_termination): New function
10738 which is like wait_for_termination, but allows keyboard
10739 interruptions.
10740
10741 * callproc.c (Fcall_process): Add (:file "file") as an option for
10742 the STDOUT buffer.
10743 (Fcall_process_region): Ditto.
10744
330d880c
EZ
107452011-04-30 Eli Zaretskii <eliz@gnu.org>
10746
8db90b73
EZ
10747 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10748 rather than `XVECTOR (FOO)->size'.
10749
330d880c
EZ
10750 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10751 inttypes.h, as a gnulib replacement is used if it not available in
10752 system headers.
10753
15cbd324
EZ
107542011-04-21 Eli Zaretskii <eliz@gnu.org>
10755
10756 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10757 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10758 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10759
10760 * coding.c (coding_alloc_by_realloc): Error out if destination
10761 will grow beyond MOST_POSITIVE_FIXNUM.
10762 (decode_coding_emacs_mule): Abort if there isn't enough place in
10763 charbuf for the composition carryover bytes. Reserve an extra
10764 space for up to 2 characters produced in a loop.
10765 (decode_coding_iso_2022): Abort if there isn't enough place in
10766 charbuf for the composition carryover bytes.
10767
107682011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10769
ae940cca
EZ
10770 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10771 aborting when %lld or %lll format is passed.
10772 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10773 %llo or %llx format is passed. (Bug#8545)
10774
03ab8921
EZ
10775 * window.c (window_scroll_line_based): Use a marker instead of
10776 simple variables to record original value of point. (Bug#7952)
10777
afda1437
EZ
10778 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10779 produced by %s or %c overflows available buffer space. (Bug#8545)
10780
f76dee0c
PE
107812011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10782
10783 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10784 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10785
fdc5744d
JB
107862011-04-28 Juanma Barranquero <lekktu@gmail.com>
10787
10788 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10789
638f053a
JB
107902011-04-28 Juanma Barranquero <lekktu@gmail.com>
10791
10792 * keyboard.c (Qdelayed_warnings_hook): Define.
10793 (command_loop_1): Run `delayed-warnings-hook'
10794 if Vdelayed_warnings_list is non-nil.
10795 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10796 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10797
d178f871
EZ
107982011-04-28 Eli Zaretskii <eliz@gnu.org>
10799
10800 * doprnt.c (doprnt): Don't return value smaller than the buffer
10801 size if the message was truncated. (Bug#8545).
10802
b124fd93
JB
108032011-04-28 Juanma Barranquero <lekktu@gmail.com>
10804
10805 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10806 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10807
e810457d
PE
108082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10809
10810 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10811
ea51cceb
JB
108122011-04-27 Juanma Barranquero <lekktu@gmail.com>
10813
10814 * makefile.w32-in: Update dependencies.
10815
94dcfacf
EZ
108162011-04-27 Eli Zaretskii <eliz@gnu.org>
10817
10818 Improve `doprnt' and its usage. (Bug#8545)
10819 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10820 `format_end'. Remove support for %l as a conversion specifier.
10821 Don't use xrealloc. Improve diagnostics when the %l size modifier
10822 is used. Update the commentary.
10823
10824 * eval.c (verror): Simplify calculation of size_t.
10825
10826 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10827 messages.
10828
f61f41d7
PE
108292011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10830
10831 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10832 change.
10833
96fb4434
PE
108342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10835
10836 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10837 This makes this file independent of the recent pseudovector change.
10838
671875da 108392011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10840
69e9b5a3
PE
10841 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10842
b5f869a7 10843 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10844 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10845 Remove unused local.
c8926152 10846 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10847
841a1577 10848 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10849 GCC 4.6.0 optimizes based on type-based alias analysis.
10850 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10851 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10852 != &v->size, and therefore "v->size = 1; b->size = 2; return
10853 v->size;" must therefore return 1. This assumption is incorrect
10854 for Emacs, since it type-puns struct Lisp_Vector * with many other
10855 types. To fix this problem, this patch adds a new type struct
f904488f 10856 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10857 and pseudovectors, and helps optimizing compilers not get fooled
10858 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10859 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10860 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10861 the size member.
eab3844f
PE
10862 (XSETPVECTYPE): Rewrite in terms of new macro.
10863 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10864 This is a bit clearer, and further avoids the possibility of
10865 undesirable aliasing.
10866 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10867 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10868 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10869 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10870 (ASIZE): Now uses header.size rather than size.
10871 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10872 to avoid the hassle of writing XVECTOR (foo)->header.size.
10873 (struct vectorlike_header): New type.
eab3844f
PE
10874 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10875 object, to help avoid aliasing.
10876 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10877 (SUBRP): Likewise, since Lisp_Subr is a special case.
10878 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10879 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10880 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10881 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10882 changed to be "header.size" and "header.next".
10883 * buffer.h (struct buffer): Likewise.
10884 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10885 * frame.h (struct frame): Likewise.
10886 * process.h (struct Lisp_Process): Likewise.
10887 * termhooks.h (struct terminal): Likewise.
10888 * window.c (struct save_window_data, struct saved_window): Likewise.
10889 * window.h (struct window): Likewise.
10890 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10891 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10892 * buffer.c (init_buffer_once): Likewise.
10893 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10894 special case.
10895 * process.c (Fformat_network_address): Use local var for size,
10896 for brevity.
10897
0df1eac5
PE
10898 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10899
847ab9d1 10900 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10901 * data.c (atof): Remove decl; no longer used or needed.
10902 (digit_to_number): Move to lread.c.
10903 (Fstring_to_number): Use new string_to_number function, to be
10904 consistent with how the Lisp reader treats infinities and NaNs.
10905 Do not assume that floating-point numbers represent EMACS_INT
10906 without losing information; this is not true on most 64-bit hosts.
10907 Avoid double-rounding errors, by insisting on integers when
10908 parsing non-base-10 numbers, as the documentation specifies.
10909 * lisp.h (string_to_number): New decl, replacing ...
10910 (isfloat_string): Remove.
bc0a5c13 10911 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10912 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10913 appears to have been a coding error. Similarly, do not accept
10914 strings like +-1e0 as floating point numbers. Do not report
10915 overflow for integer overflows unless the base is not 10 which
10916 means we have no simple and reliable way to continue.
10917 Break out the floating-point parsing into a new
10918 function string_to_number, so that Fstring_to_number parses
10919 floating point numbers consistently with the Lisp reader.
04f2d78b 10920 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10921 (E_CHAR, EXP_INT): Remove, replacing with ...
10922 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10923 (string_to_number): New function, replacing isfloat_string.
10924 This function checks for valid syntax and produces the resulting
10925 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10926 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10927 so that overflow for non-base-10 numbers is reported only when
10928 there's no portable and simple way to convert to floating point.
452f4150 10929
67769ffc
PE
10930 * textprop.c (set_text_properties_1): Rewrite for clarity,
10931 and to avoid GCC warning about integer overflow.
10932
c20db43f
PE
10933 * intervals.h (struct interval): Use EMACS_INT for members
10934 where EMACS_UINT might cause problems. See
10935 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10936 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10937 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10938 All uses changed.
37aa2f85
PE
10939 (offset_intervals): Tell GCC not to worry about length overflow
10940 when negating a negative length.
c20db43f 10941
2538aa2f
PE
10942 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10943 (overrun_check_free): Likewise.
10944
f2d3008d
PE
10945 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10946 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10947 word size.
10948
ec8df744
PE
10949 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10950 (gnutls_make_error): Rename local to avoid shadowing.
10951 (gnutls_emacs_global_deinit): ifdef out; not used.
10952 (Fgnutls_boot): Use const for pointer to readonly storage.
10953 Comment out unused local. Fix pointer signedness problems.
10954
640ee02d
PE
10955 * lread.c (openp): Don't stuff size_t into an 'int'.
10956 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10957 about possible signed overflow.
10958
6048fb2a
PE
10959 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10960 (GDK_KEY_g): Don't define if already defined.
10961 (xg_prepare_tooltip): Avoid pointer signedness problem.
10962 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10963
fa3c87e1
PE
10964 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10965 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10966
2172544b
PE
10967 * xfns.c (Fx_window_property): Simplify a bit,
10968 to make a bit faster and to avoid GCC 4.6.0 warning.
10969 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10970
9b821a21
PE
10971 * fns.c (internal_equal): Don't assume size_t fits in int.
10972
3c616cfa
PE
10973 * alloc.c (compact_small_strings): Tighten assertion a little.
10974
c2982e87
PE
10975 Replace pEd with more-general pI, and fix some printf arg casts.
10976 * lisp.h (pI): New macro, generalizing old pEd macro to other
10977 conversion specifiers. For example, use "...%"pI"d..." rather
10978 than "...%"pEd"...".
10979 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10980 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10981 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10982 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10983 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10984 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10985 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10986 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10987 64-bit hosts.
10988 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10989 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10990 * print.c (safe_debug_print, print_object): Likewise.
10991 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10992 to int.
6f04d126
PE
10993 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10994 avoiding the 0 flag, which is not portable.
c2982e87
PE
10995 * process.c (Fmake_network_process): Use pI to avoid cast.
10996 * region-cache.c (pp_cache): Likewise.
10997 * xdisp.c (decode_mode_spec): Likewise.
10998 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10999 behavior on 64-bit hosts with printf arg.
6f04d126 11000 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11001 (x_stop_queuing_selection_requests): Likewise.
11002 (x_get_window_property): Don't truncate byte count to an 'int'
11003 when tracing.
0b432f21 11004
5e073ec7
PE
11005 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11006 here, since it parses constructs like leading '-' and spaces,
11007 which are not wanted; and it overflows with large numbers.
11008 Instead, simply match F[0-9]+, which is what is wanted anyway.
11009
36372bf9
PE
11010 * alloc.c: Remove unportable assumptions about struct layout.
11011 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11012 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11013 (allocate_vectorlike, make_pure_vector): Use the new macros,
11014 plus offsetof, to remove unportable assumptions about struct layout.
11015 These assumptions hold on all porting targets that I know of, but
11016 they are not guaranteed, they're easy to remove, and removing them
11017 makes further changes easier.
11018
0b432f21
PE
11019 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11020 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11021 (string_overrun_cookie): Now const. Use initializers that
11022 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11023 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11024 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11025 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11026 multiple of sizeof (EMACS_INT); it need not be, if
11027 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11028 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11029
895009e1
JB
110302011-04-26 Juanma Barranquero <lekktu@gmail.com>
11031
11032 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11033
6a7a1b0b
TZ
110342011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11035
11036 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11037 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11038 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11039
841a1577 110402011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11041
11042 * lisp.h (Qdebug): List symbol.
895009e1 11043 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11044 * keyboard.c (debug-on-event): New variable.
11045 (handle_user_signal): Break into debugger when debug-on-event
11046 matches the current signal symbol.
11047
f2d3ba6f
DN
110482011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11049
11050 * alloc.c (check_sblock, check_string_bytes)
11051 (check_string_free_list): Convert to standard C.
11052
42ce4c63
TZ
110532011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11054
11055 * w32.c (emacs_gnutls_push): Fix typo.
11056
825cd63c
EZ
110572011-04-25 Eli Zaretskii <eliz@gnu.org>
11058
fb11d64d
EZ
11059 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11060 "cast to pointer from integer of different size".
11061
825cd63c
EZ
11062 Improve doprnt and its use in verror. (Bug#8545)
11063 * doprnt.c (doprnt): Document the set of format control sequences
11064 supported by the function. Use SAFE_ALLOCA instead of always
11065 using `alloca'.
11066
11067 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11068 is one byte too soon. Don't use xrealloc; instead xfree and
11069 xmalloc anew.
11070
e061a11b
TZ
110712011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11072
11073 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11074 callbacks stage.
11075
11076 * gnutls.c: Renamed global_initialized to
11077 gnutls_global_initialized. Added internals for the
11078 :verify-hostname-error, :verify-error, and :verify-flags
11079 parameters of `gnutls-boot' and documented those parameters in the
11080 docstring. Start callback support.
9173deec
JB
11081 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11082 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11083 on error. Return error code.
e061a11b
TZ
11084 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11085 (emacs_gnutls_read): Likewise.
11086 (Fgnutls_boot): Return handshake error code.
11087 (emacs_gnutls_handle_error): New function.
11088 (wsaerror_to_errno): Likewise.
11089
11090 * w32.h (emacs_gnutls_pull): Add prototype.
11091 (emacs_gnutls_push): Likewise.
11092
11093 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11094 (emacs_gnutls_push): Likewise.
11095
110962011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11097
11098 * process.c (wait_reading_process_output): Check if GnuTLS
11099 buffered some data internally if no FDs are set for TLS
11100 connections.
11101
11102 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11103 (LIBS): Link to USER_LIBS.
11104 ($(BLD)/gnutls.$(0)): New target.
11105
fa6996bc
EZ
111062011-04-24 Eli Zaretskii <eliz@gnu.org>
11107
eb35682e
EZ
11108 * xdisp.c (handle_single_display_spec): Rename the
11109 display_replaced_before_p argument into display_replaced_p, to
11110 make it consistent with the commentary. Fix typos in the
11111 commentary.
11112
e2ad650c
EZ
11113 * textprop.c (syms_of_textprop): Remove dead code.
11114 (copy_text_properties): Delete obsolete commentary about an
11115 interface that was deleted long ago. Fix typos in the description
11116 of arguments.
11117
1b2de274
EZ
11118 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11119 to changes in oldXMenu/XMenu.h from 2011-04-16.
11120 <menu_help_message, prev_menu_help_message>: Constify.
11121 (IT_menu_make_room): menu->help_text is now `const char **';
11122 adjust.
11123
11124 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11125 to changes in oldXMenu/XMenu.h from 2011-04-16.
11126 (struct XMenu): Declare `help_text' `const char **'.
11127
11128 * xfaces.c <Qunspecified>: Make extern again.
11129
11130 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11131 required by POSIX.
1b2de274 11132
762b15be
EZ
11133 * doc.c (get_doc_string): Improve the format passed to `error'.
11134
11135 * doprnt.c (doprnt): Improve commentary.
11136
11137 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11138
11139 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11140 them with etags.
11141
f1052e5d
EZ
11142 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11143 changes in globals.h immediately force recompilation.
762b15be
EZ
11144 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11145 $(CURDIR)/s/ms-w32.h.
11146 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11147
fa6996bc
EZ
11148 * character.c (Fchar_direction): Function deleted.
11149 (syms_of_character): Don't defsubr it.
11150 <char-direction-table>: Deleted.
11151
e6c3da20
EZ
111522011-04-23 Eli Zaretskii <eliz@gnu.org>
11153
11154 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11155 * doprnt.c: Include limits.h.
11156 (SIZE_MAX): New macro.
04f2d78b
CB
11157 (doprnt): Return a size_t value. 2nd arg is now size_t.
11158 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11159 Improve overflow protection. Support `l' modifier for integer
11160 conversions. Support %l conversion. Don't assume an EMACS_INT
11161 argument for integer conversions and for %c.
11162
11163 * lisp.h (doprnt): Restore prototype.
11164
11165 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11166 $(SRC)/character.h.
11167
11168 * Makefile.in (base_obj): Add back doprnt.o.
11169
11170 * deps.mk (doprnt.o): Add back prerequisites.
11171 (callint.o): Depend on character.h.
11172
11173 * eval.c (internal_lisp_condition_case): Include the handler
11174 representation in the error message.
11175 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11176 when breaking from the loop.
11177
11178 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11179
11180 * callint.c (Fcall_interactively): When displaying error message
11181 about invalid control letter, pass the character's codepoint, not
11182 a pointer to its multibyte form. Improve display of the character
11183 in octal and display also its hex code.
11184
11185 * character.c (char_string): Use %x to display the (unsigned)
11186 codepoint of an invalid character, to avoid displaying a bogus
11187 negative value.
11188
11189 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11190 `error', not SYMBOL_NAME itself.
11191
11192 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11193 character arguments to `error'.
11194
11195 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11196 to `error' in error message about FINAL_CHAR argument. Make sure
11197 FINAL_CHAR is a character, and use %c when it is passed as
11198 argument to `error'.
11199
4ffd0d6b 112002011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11201
11202 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11203
11204 * w32.c: Include <time.h>.
11205 (sys_localtime): New function.
11206
4ffd0d6b 112072011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11208
11209 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11210
4ffd0d6b 11211 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11212
4ffd0d6b 112132011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11214
4ffd0d6b
GM
11215 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11216 zombies (Bug#8467).
aac0c6e3 11217
04c56954
EZ
112182011-04-19 Eli Zaretskii <eliz@gnu.org>
11219
11220 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11221 gl_state.e_property when gl_state.object is Qt.
11222
11223 * insdel.c (make_gap_larger): Remove limitation of buffer size
11224 to <= INT_MAX.
11225
16a43933
CY
112262011-04-18 Chong Yidong <cyd@stupidchicken.com>
11227
11228 * xdisp.c (lookup_glyphless_char_display)
11229 (produce_glyphless_glyph): Handle cons cell entry in
11230 glyphless-char-display.
11231 (Vglyphless_char_display): Document it.
11232
11233 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11234 glyphless-char-display.
11235
4581706e
CY
112362011-04-17 Chong Yidong <cyd@stupidchicken.com>
11237
11238 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11239
11240 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11241
11242 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11243 definition for no-X builds.
11244
4887c6e2 112452011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11246
fd35b6f9
PE
11247 Static checks with GCC 4.6.0 and non-default toolkits.
11248
5c1ccb01
PE
11249 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11250
006c5daa
PE
11251 * process.c (keyboard_bit_set): Define only if SIGIO.
11252 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11253 (send_process): Repair possible setjmp clobbering.
11254
efc736d3
PE
11255 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11256
4e2fe2e6
PE
11257 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11258
f97334a2
PE
11259 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11260
4e75f29d
PE
11261 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11262 Define only if needed.
11263
90efadd1
PE
11264 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11265 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11266 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11267
3c647824
PE
11268 * dispextern.h (struct redisplay_interface): Rename param
11269 to avoid shadowing.
e264f262 11270 * termhooks.h (struct terminal): Likewise.
761383f4 11271 * xterm.c (xembed_send_message): Likewise.
3c647824 11272
b58c5c4a
PE
11273 * insdel.c (make_gap_smaller): Define only if
11274 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11275
cad59032
PE
11276 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11277 it.
11278
c339dc2e
PE
11279 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11280 so that we aren't warned about unused symbols.
11281
91a3e27b
PE
11282 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11283
399c71d3 11284 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11285
8ffc96f5
PE
11286 * xfns.c (x_real_positions): Mark locals as initialized.
11287
eef9bc79
PE
11288 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11289
098db9dd
PE
11290 * xterm.c: Fix problems found by static analysis with other toolkits.
11291 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11292 (x_dispatch_event): Declare static if USE_GTK, and
11293 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11294 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11295 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11296 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11297 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11298
eb18f6cc
PE
11299 * xmenu.c (menu_help_callback): Pointer type fixes.
11300 Use const pointers when pointing at readonly data. Avoid pointer
11301 signedness clashes.
11302 (FALSE): Remove unused macro.
11303 (update_frame_menubar): Remove unused decl.
11304
1fe72bf8
PE
11305 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11306
60d9e1db
PE
11307 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11308 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11309 (single_menu_item): Rename local to avoid shadowing.
11310
39261c26
PE
11311 * keyboard.c (make_lispy_event): Remove unused local var.
11312
018c5e19
PE
11313 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11314 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11315
63d2b86e
PE
11316 * bitmaps: Change bitmaps from unsigned char back to the X11
11317 compatible char. Avoid the old compiler warnings about
11318 out-of-range initializers by using, for example, '\xab' rather
11319 than 0xab.
11320
aefd87e1
PE
11321 * xgselect.c (xgselect_initialize): Check vs interface
11322 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11323
bf501fb9
PE
11324 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11325
e9829fdf
PE
11326 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11327 to read-only memory.
11328
1086c095
PE
11329 * fns.c (vector): Remove; this old hack is no longer needed.
11330
2baccd04 11331 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11332 Remove unused var.
dde42981 11333 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11334
72391843 11335 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11336
436c16df 11337 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11338 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11339 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11340
92bb796d 11341 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11342 (x_term_init): Remove local to avoid shadowing.
92bb796d 11343
764430a3 11344 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11345
11346 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11347 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11348
d1dfb56c
EZ
113492011-04-16 Eli Zaretskii <eliz@gnu.org>
11350
c4354cb4
EZ
11351 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11352
d1dfb56c
EZ
11353 Fix regex.c, syntax.c and friends for buffers > 2GB.
11354 * syntax.h (struct gl_state_s): Declare character position members
11355 EMACS_INT.
11356
11357 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11358
04f2d78b
CB
11359 * textprop.c (verify_interval_modification, interval_of):
11360 Declare arguments EMACS_INT.
d1dfb56c
EZ
11361
11362 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11363 EMACS_INT.
11364
11365 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11366
11367 * indent.c (Fvertical_motion): Local variable it_start is now
11368 EMACS_INT.
11369
11370 * regex.c (re_match, re_match_2, re_match_2_internal)
11371 (bcmp_translate, regcomp, regexec, print_double_string)
11372 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11373 (re_compile_pattern, re_exec): Declare arguments and local
11374 variables `size_t' and `ssize_t' and return values `regoff_t', as
11375 appropriate.
11376 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11377 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11378 <compile_stack_type>: `size' and `avail' are now `size_t'.
11379
11380 * regex.h <regoff_t>: Use ssize_t, not int.
11381 (re_search, re_search_2, re_match, re_match_2): Arguments that
11382 specify buffer/string position and length are now ssize_t and
11383 size_t. Return type is regoff_t.
11384
613052cd
BK
113852011-04-16 Ben Key <bkey76@gmail.com>
11386
11387 * nsfont.m: Fixed bugs in ns_get_family and
11388 ns_descriptor_to_entity that were caused by using free to
11389 deallocate memory blocks that were allocated by xmalloc (via
11390 xstrdup). This caused Emacs to crash when compiled with
11391 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11392 --enable-checking=xmallocoverrun). xfree is now used to
11393 deallocate these memory blocks.
11394
4170f62f 113952011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11396
71b41406
PE
11397 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11398
9587a89d
PE
11399 emacs_write: Accept and return EMACS_INT for sizes.
11400 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11401 et seq.
11402 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11403 Accept and return EMACS_INT.
11404 (emacs_gnutls_write): Return the number of bytes written on
11405 partial writes.
11406 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11407 (emacs_read, emacs_write): Remove check for negative size, as the
11408 Emacs source code has been audited now.
9587a89d
PE
11409 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11410 (emacs_read, emacs_write): Use it.
273a5f82
PE
11411 * process.c (send_process): Adjust to the new signatures of
11412 emacs_write and emacs_gnutls_write. Do not attempt to store
11413 a byte offset into an 'int'; it might overflow.
9587a89d 11414 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11415
3e047f51
PE
11416 * sound.c: Don't assume sizes fit in 'int'.
11417 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11418 Return EMACS_INT, not int.
3e047f51 11419 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11420 Accept EMACS_INT, not int.
11421 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11422 record read return values.
11423
cc39a9db
BK
114242011-04-15 Ben Key <bkey76@gmail.com>
11425
c9d0ec6d
JB
11426 * keyboard.c (Qundefined): Don't declare static since it is used
11427 in nsfns.m.
11428 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11429 static since they are used in nsfont.m.
cc39a9db 11430
6c60eb9f
SM
114312011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11432
11433 * process.c (Qprocessp): Don't declare static.
11434 * lisp.h (Qprocessp): Declare again.
11435
7990b61a
JB
114362011-04-15 Juanma Barranquero <lekktu@gmail.com>
11437
11438 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11439
5d4cb038
PE
114402011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11441
8bd7b830 11442 Improve C-level modularity by making more things 'static'.
cd64ea1d 11443
e3b27b31
PE
11444 Don't publish debugger-only interfaces to other modules.
11445 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11446 (verify_bytepos, count_markers): Move decls to the only modules
11447 that need them.
11448 * region-cache.h (pp_cache): Likewise.
11449 * window.h (check_all_windows): Likewise.
11450 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11451
5d4cb038
PE
11452 * sysdep.c (croak): Now static, if
11453 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11454 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11455
11456 * alloc.c (refill_memory_reserve): Now static if
11457 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11458 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11459
e87b6180
PE
11460 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11461 Define only if USE_LUCID.
11462
ac64929e
PE
11463 * xrdb.c (x_customization_string, x_rm_string): Now static.
11464
6f37259d
PE
11465 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11466 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11467
1683e3ab
PE
11468 * xdisp.c (draw_row_with_mouse_face): Now static.
11469 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11470
de9c2632
PE
11471 * window.h (check_all_windows): Mark externally visible.
11472
2b96acb7
PE
11473 * window.c (window_deletion_count): Now static.
11474
11475 * undo.c: Make symbols static if they're not exported.
11476 (last_undo_buffer, last_boundary_position, pending_boundary):
11477 Now static.
11478
50436f33
PE
11479 * textprop.c (interval_insert_behind_hooks): Now static.
11480 (interval_insert_in_front_hooks): Likewise.
11481
64520e5c
PE
11482 * term.c: Make symbols static if they're not exported.
11483 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11484 (max_frame_lines, tty_set_terminal_modes):
11485 (tty_reset_terminal_modes, tty_turn_off_highlight):
11486 (get_tty_terminal): Now static.
11487 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11488 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11489 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11490 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11491 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11492
1fa53021
PE
11493 * sysdep.c: Make symbols static if they're not exported.
11494 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11495 Now static.
11496 (sigprocmask_set, full_mask): Remove; unused.
11497 (wait_debugging): Mark as visible.
11498 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11499 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11500
d4b43b22
PE
11501 * syntax.c (syntax_temp): Define only if !__GNUC__.
11502
b7c513d0
PE
11503 * sound.c (current_sound_device, current_sound): Now static.
11504
989b29ad
PE
11505 * search.c (searchbufs, searchbuf_head): Now static.
11506
13a55a78
PE
11507 * scroll.c (scroll_cost): Remove; unused.
11508 * dispextern.h (scroll_cost): Remove decl.
11509
de68a1fc
PE
11510 * region-cache.h (pp_cache): Mark as externally visible.
11511
40ccffa6
PE
11512 * process.c: Make symbols static if they're not exported.
11513 (process_tick, update_tick, create_process, chan_process):
11514 (Vprocess_alist, proc_buffered_char, datagram_access):
11515 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11516 (deactivate_process): Mark defn as static, as well as decl.
11517 * lisp.h (create_process): Remove decl.
11518 * process.h (chan_process, Vprocess_alist): Remove decls.
11519
ad64fc97
PE
11520 * print.c: Make symbols static if they're not exported.
11521 (print_depth, new_backquote_output, being_printed, print_buffer):
11522 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11523 (print_interval, print_number_index, initial_stderr_stream):
11524 Now static.
11525 * lisp.h (Fprinc): Remove decl.
11526 (debug_output_compilation_hack): Mark as externally visible.
11527
adddb265
PE
11528 * sysdep.c (croak): Move decl from here to syssignal.h.
11529 * syssignal.h (croak): Put it here, so the API can be checked when
11530 'croak' is called from dissociate_if_controlling_tty.
11531
1717ede2
PE
11532 * minibuf.c: Make symbols static if they're not exported.
11533 (minibuf_save_list, choose_minibuf_frame): Now static.
11534 * lisp.h (choose_minibuf_frame): Remove decl.
11535
fa5fb2bc
PE
11536 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11537
1e3890d1
PE
11538 * lread.c: Make symbols static if they're not exported.
11539 (read_objects, initial_obarray, oblookup_last_bucket_number):
11540 Now static.
11541 (make_symbol): Remove; unused.
11542 * lisp.h (initial_obarray, make_symbol): Remove decls.
11543
8a1414fa
PE
11544 * keyboard.c: Make symbols static if they're not exported.
11545 (single_kboard, recent_keys_index, total_keys, recent_keys):
11546 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11547 (this_single_command_key_start, echoing, last_auto_save):
11548 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11549 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11550 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11551 (Vlispy_mouse_stem, double_click_count):
11552 Now static.
11553 (force_auto_save_soon): Define only if SIGDANGER.
11554 (ignore_mouse_drag_p): Now static if
11555 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11556 (print_help): Remove; unused.
11557 (stop_character, last_timer_event): Mark as externally visible.
11558 * keyboard.h (ignore_mouse_drag_p): Declare only if
11559 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11560 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11561 * lisp.h (echoing): Remove decl.
11562 (force_auto_save_soon): Declare only if SIGDANGER.
11563 * xdisp.c (redisplay_window): Simplify code, to make it more
11564 obvious that ignore_mouse_drag_p is not accessed if !defined
11565 USE_GTK && !defined HAVE_NS.
11566
93ea6e8f
PE
11567 * intervals.c: Make symbols static if they're not exported.
11568 (merge_properties_sticky, merge_interval_right, delete_interval):
11569 Now static.
11570 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11571
77382fcc
PE
11572 * insdel.c: Make symbols static if they're not exported.
11573 However, leave prepare_to_modify_buffer alone. It's never
11574 called from outside this function, but that appears to be a bug.
11575 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11576 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11577 (adjust_after_replace_noundo): Remove; unused.
11578 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11579 (signal_before_change): Remove decls.
77382fcc 11580
9306c32e
PE
11581 * indent.c (val_compute_motion, val_vmotion): Now static.
11582
cd44d2eb
PE
11583 * image.c: Make symbols static if they're not exported.
11584 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11585 if USE_GTK.
11586 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11587 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11588
ad9a7a06
PE
11589 * fringe.c (standard_bitmaps): Now static.
11590 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11591
81626931
PE
11592 * frame.c: Make symbols static if they're not exported.
11593 (x_report_frame_params, make_terminal_frame): Now static.
11594 (get_frame_param): Now static, unless HAVE_NS.
11595 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11596 (x_get_resource_string): Remove; not used.
11597 * frame.h (make_terminal_frame, x_report_frame_params):
11598 (x_get_resource_string); Remove decls.
11599 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11600 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11601
239f9db9
PE
11602 * font.c, fontset.c: Make symbols static if they're not exported.
11603 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11604 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11605 * font.c (font_close_object): Now static.
11606 * font.h (font_close_object): Remove.
11607 * fontset.c (FONTSET_OBJLIST): Remove.
11608 (free_realized_fontset) #if-0 the body, which does nothing.
11609 (face_suitable_for_char_p): #if-0, as it's never called.
11610 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11611 * xfaces.c (face_at_string_position):
11612 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11613 since 0 is always ASCII.
11614
dfcf3579
PE
11615 * fns.c (weak_hash_tables): Now static.
11616
5045092b
PE
11617 * fileio.c: Make symbols static if they're not exported.
11618 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11619 (Vwrite_region_annotation_buffers): Now static.
11620
57a96f5c
PE
11621 * eval.c: Make symbols static if they're not exported.
11622 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11623 * lisp.h (backtrace_list): Remove decl.
11624
35f08c38
PE
11625 * emacs.c: Make symbols static if they're not exported.
11626 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11627 (fatal_error_code, fatal_error_signal_hook, standard_args):
11628 Now static.
11629 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11630 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11631 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11632 * lisp.h (fatal_error_signal_hook): Remove decl.
11633 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11634
f44bd759
PE
11635 * editfns.c: Move a (normally-unused) function to its only use.
11636 * editfns.c, lisp.h (get_operating_system_release): Remove.
11637 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11638 worth the hassle of breaking this out.
11639
b532497d
PE
11640 * xterm.c: Make symbols static if they're not exported.
11641 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11642 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11643 (x_destroy_window, x_delete_display):
11644 Now static.
11645 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11646 (x_mouse_leave): Remove; unused.
11647 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11648 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11649 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11650 Remove decls.
11651 (x_mouse_leave): Declare only if WINDOWSNT.
11652 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11653 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11654 USE_X_TOOLKIT.
11655
1675728f
PE
11656 * ftxfont.c: Make symbols static if they're not exported.
11657 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11658 HAVE_FREETYPE.
11659 * font.h (ftxfont_driver): Likewise.
11660
e4cebfca
PE
11661 * xfns.c: Make symbols static if they're not exported.
11662 (x_last_font_name, x_display_info_for_name):
11663 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11664 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11665 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11666 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11667 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11668 (last_show_tip_args): Now static.
11669 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11670 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11671 (x_screen_planes): Remove; unused.
11672 * dispextern.h (x_screen_planes): Remove decl.
11673
5bf46f05
PE
11674 * dispnew.c: Make symbols static if they're not exported.
11675 * dispextern.h (redraw_garbaged_frames, scrolling):
11676 (increment_row_positions): Remove.
11677 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11678 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11679 Now static.
11680 (redraw_garbaged_frames): Remove; unused.
11681
435f4c28
PE
11682 * xfaces.c: Make symbols static if they're not exported.
11683 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11684 Remove decls.
11685 * xterm.h (defined_color): Remove decls.
11686 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11687 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11688 (menu_face_changed_default, defined_color, free_realized_face):
11689 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11690 (ascii_face_of_lisp_face): Remove; unused.
11691
8524aef3
PE
11692 * xdisp.c: Make symbols static if they're not exported.
11693 * dispextern.h (scratch_glyph_row, window_box_edges):
11694 (glyph_to_pixel_coords, set_cursor_from_row):
11695 (get_next_display_element, set_iterator_to_next):
11696 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11697 (show_mouse_face): Remove decls
11698 * frame.h (message_buf_print): Likewise.
11699 * lisp.h (pop_message, set_message, check_point_in_composition):
11700 Likewise.
11701 * xterm.h (set_vertical_scroll_bar): Likewise.
11702 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11703 (message_buf_print, scratch_glyph_row, displayed_buffer):
11704 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11705 (get_next_display_element, show_mouse_face, window_box_edges):
11706 (frame_to_window_pixel_xy, check_point_in_composition):
11707 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11708 (glyph_to_pixel_coords): Remove; unused.
11709
16390cd2
PE
11710 * dired.c (file_name_completion): Now static.
11711
11712 * dbusbind.c (xd_in_read_queued_messages): Now static.
11713
a25f4dfa
PE
11714 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11715 * data.c (circular_list_error): Remove.
11716
14a9c8df
PE
11717 * commands.h (last_point_position, last_point_position_buffer):
11718 (last_point_position_window): Remove decls.
11719 * keyboard.c: Make these variables static.
11720
04f2d78b
CB
11721 * coding.h (coding, code_convert_region, encode_coding_gap):
11722 Remove decls.
74ab6df5
PE
11723 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11724 (iso_code_class, detect_coding, code_convert_region): Now static.
11725 (encode_coding_gap): Remove; unused.
11726
38dfbee1
PE
11727 * chartab.c (chartab_chars, chartab_bits): Now static.
11728
a2cb4e63
PE
11729 * charset.h (charset_iso_8859_1): Remove decl.
11730 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11731 Now static.
11732
127198fd
PE
11733 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11734 * ccl.c (Vccl_program_table): Now static.
11735 (check_ccl_update): Remove; unused.
11736
d85b608f
PE
11737 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11738 * category.h: ... from here.
11739 * category.c (check_category_table, set_category_set): Now static.
11740
31cd66f3
PE
11741 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11742 * lisp.h: Remove these decls.
11743
c358e587
PE
11744 * buffer.c (buffer_count): Remove unused var.
11745
e78aecca
PE
11746 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11747 so that it's not optimized away.
11748 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11749 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11750 exported only to the debugger.
11751
e192d7d3 11752 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11753 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11754
92470028
PE
11755 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11756 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11757 was inaccessible from Lisp.
11758 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11759 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11760
244ed907
PE
11761 alloc.c: Import and export fewer symbols, and remove unused items.
11762 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11763 is defined.
11764 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11765 it's not optimized away by whole-program optimization.
11766 (message_enable_multibyte, free_misc): Remove.
11767 (catchlist, handlerlist, mark_backtrace):
11768 Declare only if BYTE_MARK_STACK.
11769 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11770 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11771 (message_enable_multibyte): Remove decl.
11772 (free_misc, interval_free_list, float_block, float_block_index):
11773 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11774 (cons_free_list, last_marked_index):
11775 Now static.
11776 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11777 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11778 (mark_backtrace): Define only if BYTE_MARK_STACK.
11779 * xdisp.c (message_enable_multibyte): Now static.
11780
61c2b50e 11781 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11782 This makes it easier for human readers (and static analyzers)
11783 to see whether these variables are used from other modules.
11784 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11785 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11786 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11787 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11788 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11789 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11790 * xmenu.c, xselect.c:
11791 Declare Q* vars static if they are not used in other modules.
11792 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11793 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11794 Remove decls of unexported vars.
11795 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11796
95c82688
PE
11797 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11798
16a97296
PE
11799 Make Emacs functions such as Fatom 'static' by default.
11800 This makes it easier for human readers (and static analyzers)
11801 to see whether these functions can be called from other modules.
11802 DEFUN now defines a static function. To make the function external
11803 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11804 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11805 (Finit_image_library):
16a97296
PE
11806 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11807 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11808 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11809 Remove decls, since these functions are now static.
11810 (Funintern, Fget_internal_run_time): New decls, since these functions
11811 were already external.
95c82688 11812
16a97296
PE
11813 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11814 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11815 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11816 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11817 * keyboard.c, keymap.c, lread.c:
11818 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11819 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11820 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11821 Mark functions with DEFUE instead of DEFUN,
11822 if they are used in other modules.
11823 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11824 decls for now-static functions.
11825 * buffer.h (Fdelete_overlay): Remove decl.
11826 * callproc.c (Fgetenv_internal): Mark as internal.
11827 * composite.c (Fremove_list_of_text_properties): Remove decl.
11828 (Fcomposition_get_gstring): New forward static decl.
11829 * composite.h (Fcomposite_get_gstring): Remove decl.
11830 * dired.c (Ffile_attributes): New forward static decl.
11831 * doc.c (Fdocumntation_property): New forward static decl.
11832 * eval.c (Ffetch_bytecode): New forward static decl.
11833 (Funintern): Remove extern decl; now in .h file where it belongs.
11834 * fileio.c (Fmake_symbolic_link): New forward static decl.
11835 * image.c (Finit_image_library): New forward static decl.
11836 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11837 * intervals.h (Fprevious_property_change):
11838 (Fremove_list_of_text_properties): Remove decls.
11839 * keyboard.c (Fthis_command_keys): Remove decl.
11840 (Fcommand_execute): New forward static decl.
11841 * keymap.c (Flookup_key): New forward static decl.
11842 (Fcopy_keymap): Now static.
11843 * keymap.h (Flookup_key): Remove decl.
11844 * process.c (Fget_process): New forward static decl.
11845 (Fprocess_datagram_address): Mark as internal.
11846 * syntax.c (Fsyntax_table_p): New forward static decl.
11847 (skip_chars): Remove duplicate decl.
11848 * textprop.c (Fprevious_property_change): New forward static decl.
11849 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11850 Now internal.
11851 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11852 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11853
785bbd42
PE
11854 * editfns.c (Fformat): Remove unreachable code.
11855
8b913b57
AS
118562011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11857
11858 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11859 change. (Bug#8496)
11860
a6744a35
EZ
118612011-04-13 Eli Zaretskii <eliz@gnu.org>
11862
11863 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11864 when at ZV. (Bug#8487)
11865
e7974947
AS
118662011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11867
baad03f0
AS
11868 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11869 (Bug#8437)
11870 * keyboard.c (parse_tool_bar_item): Likewise.
11871 * sound.c (sound_cleanup, alsa_close): Likewise.
11872 * termcap.c (tgetent): Likewise.
11873 * xfns.c (x_default_font_parameter): Likewise.
11874 * xsettings.c (read_and_apply_settings): Likewise.
11875
e7974947
AS
11876 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11877 (overrun_check_free): Protoize.
11878
28272684
PE
118792011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11880
11881 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11882 since callers should never pass a negative size.
11883 Change the signature to match that of plain 'read' and 'write'; see
11884 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11885 * lisp.h: Update prototypes of emacs_write and emacs_read.
11886
11997c76
EZ
118872011-04-11 Eli Zaretskii <eliz@gnu.org>
11888
11889 * xdisp.c (redisplay_window): Don't try to determine the character
11890 position of the scroll margin if the window start point w->startp
e896f03c 11891 is outside the buffer's accessible region. (Bug#8468)
11997c76 11892
8a2cbd72
EZ
118932011-04-10 Eli Zaretskii <eliz@gnu.org>
11894
11895 Fix write-region and its subroutines for buffers > 2GB.
11896 * fileio.c (a_write, e_write): Modify declaration of arguments and
11897 local variables to support buffers larger than 2GB.
11898 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11899
11900 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11901 argument, local variables, and return value.
11902
11903 * lisp.h: Update prototypes of emacs_write and emacs_read.
11904
11905 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11906
4073e537 119072011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11908
1ebfdcb6
PE
11909 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11910
b2ded58d
PE
11911 Fix more problems found by GCC 4.6.0's static checks.
11912
7d66342c
PE
11913 * xdisp.c (vmessage): Use a better test for character truncation.
11914
bbf47d44
PE
11915 * charset.c (load_charset_map): <, not <=, for optimization,
11916 and to avoid potential problems with integer overflow.
9248994d 11917 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11918 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11919 * editfns.c (Fformat): Likewise.
1e69125e 11920 * syntax.c (skip_chars): Likewise.
3befa583 11921
e3019616
PE
11922 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11923 This also lets GCC 4.6.0 generate slightly better loop code.
11924
becfa255
PE
11925 * callint.c (Fcall_interactively): <, not <=, for optimization.
11926 (Fcall_interactively): Count the number of arguments produced,
11927 not the number of arguments given. This is simpler and lets GCC
11928 4.6.0 generate slightly better code.
11929
dae0cd48
PE
11930 * ftfont.c: Distingish more carefully between FcChar8 and char.
11931 The previous code passed unsigned char * to a functions like
11932 strlen and xstrcasecmp that expect char *, which does not
11933 conform to the C standard.
11934 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11935 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11936 char * when the C standard requires it.
11937
76032d70
PE
11938 * keyboard.c (read_char): Remove unused var.
11939
eb3f1cc8
PE
11940 * eval.c: Port to Windows vsnprintf (Bug#8435).
11941 Include <limits.h>.
11942 (SIZE_MAX): Define if the headers do not.
11943 (verror): Do not give up if vsnprintf returns a negative count.
11944 Instead, grow the buffer. This ports to Windows vsnprintf, which
11945 does not conform to C99. Problem reported by Eli Zaretskii.
11946 Also, simplify the allocation scheme, by avoiding the need for
11947 calling realloc, and removing the ALLOCATED variable.
11948
70476b54
PE
11949 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11950
12020a9e
PE
11951 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11952 But keep the doprint source code for now, as we might revamp it
11953 and use it again (Bug#8435).
ea6c7ae6
PE
11954 * lisp.h (doprnt): Remove.
11955 * Makefile.in (base_obj): Remove doprnt.o.
11956 * deps.mk (doprnt.o): Remove.
11957
5fdb398c
PE
11958 error: Print 32- and 64-bit integers portably (Bug#8435).
11959 Without this change, on typical 64-bit hosts error ("...%d...", N)
11960 was used to print both 32- and 64-bit integers N, which relied on
11961 undefined behavior.
61bdb816 11962 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11963 * lisp.h (error, verror): Mark as printf-like functions.
11964 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11965 Report overflow in size calculations when allocating printf buffer.
11966 Do not truncate output string at its first null byte.
11967 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11968 Truncate the output at a character boundary, since vsnprintf does not
11969 do that.
11970 * charset.c (check_iso_charset_parameter): Convert internal
11971 character to string before calling 'error', since %c now has the
11972 printf meaning.
11973 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11974 overflow when computing char to be passed to 'error'. Do not
11975 pass Lisp_Object to 'error'; pass the integer instead.
11976 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11977 formatted with plain %d.
11978
b189fa66
PE
11979 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11980
bff87ef0
PE
11981 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11982
7e2cac20
PE
11983 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11984
ce4d90b5
PE
11985 * xterm.c (x_catch_errors): Remove duplicate declaration.
11986
266c9547
PE
11987 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11988
79c49ad2
PE
11989 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11990
368f4090
JM
119912011-04-10 Jim Meyering <meyering@redhat.com>
11992
11993 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11994 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11995 return ssize_t not "int", and use size_t as the buffer length.
11996 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11997 * gnutls.h: Update declarations.
11998 * process.c (read_process_output): Use ssize_t, to match.
11999 (send_process): Likewise.
12000
a32d4040
CY
120012011-04-09 Chong Yidong <cyd@stupidchicken.com>
12002
12003 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12004
8546720e 120052011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12006
04f2d78b
CB
12007 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12008 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12009
8546720e
GM
12010 * xterm.c (handle_one_xevent):
12011 * xmenu.c (create_and_show_popup_menu):
12012 * xselect.c (x_decline_selection_request)
12013 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12014
0a2f5c1a 120152011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12016
12017 Fix some uses of `int' instead of EMACS_INT.
12018 * search.c (string_match_1, fast_string_match)
12019 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12020 (scan_buffer, find_next_newline_no_quit)
12021 (find_before_next_newline, search_command, Freplace_match)
12022 (Fmatch_data): Make some `int' variables be EMACS_INT.
12023
12024 * xdisp.c (display_count_lines): 3rd argument and return value now
12025 EMACS_INT. All callers changed.
12026 (pint2hrstr): Last argument is now EMACS_INT.
12027
12028 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12029 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12030 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12031 (decode_coding_utf_16, decode_coding_emacs_mule)
12032 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12033 (decode_coding_ccl, decode_coding_charset)
12034 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12035 (decode_coding_iso_2022, decode_coding_emacs_mule)
12036 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12037 <char_offset, last_offset>: Declare EMACS_INT.
12038 (encode_coding_utf_8, encode_coding_utf_16)
12039 (encode_coding_emacs_mule, encode_invocation_designation)
12040 (encode_designation_at_bol, encode_coding_iso_2022)
12041 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12042 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12043 Declare EMACS_INT.
12044 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12045 (encode_invocation_designation): Last argument P_NCHARS is now
12046 EMACS_INT.
12047 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12048 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12049
12050 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12051 All users changed.
12052
12053 * ccl.c (Fccl_execute_on_string): Declare some variables
12054 EMACS_INT.
12055
8546720e 120562011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12057
12058 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12059
4e19a977
CS
120602011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12061
12062 * process.c (Fformat_network_address): Doc fix.
12063
87302331
R
120642011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12065
ee7683eb 12066 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12067
cbb59342
CY
120682011-04-08 Chong Yidong <cyd@stupidchicken.com>
12069
12070 * keyboard.c (read_char): Call Lisp function help-form-show,
12071 instead of using internal_with_output_to_temp_buffer.
12072 (Qhelp_form_show): New var.
e0d38eeb 12073 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12074
12075 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12076
12077 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12078
e67a13ab
CY
120792011-04-06 Chong Yidong <cyd@stupidchicken.com>
12080
04f2d78b
CB
12081 * process.c (Flist_processes): Remove to Lisp.
12082 (list_processes_1): Delete.
e67a13ab 12083
973f782d
EZ
120842011-04-06 Eli Zaretskii <eliz@gnu.org>
12085
7c106b1e
EZ
12086 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12087
973f782d
EZ
12088 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12089
41cf7d1a 120902011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12091
ca23cc88
PE
12092 Fix more problems found by GCC 4.6.0's static checks.
12093
f390e2d5
PE
12094 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12095
42eea0d0
PE
12096 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12097
b69769da 12098 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12099
f9541e84
PE
12100 * xdisp.c (vmessage): Mark as a printf-like function.
12101
13841b55
PE
12102 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12103
c136c10f
PE
12104 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12105
5e2d4a30
PE
12106 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12107 printf-like functions.
12108 (tiff_load): Add casts to remove these marks before passing them
12109 to system-supplied API.
12110
583f48b9
PE
12111 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12112
b25d760e
PE
12113 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12114 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12115 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12116 directly, rather than having caller test rule sign. This avoids
12117 some unnecessary tests.
12118 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12119 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12120 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12121
bc7b6697 12122 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12123 (xfont_open): Avoid unnecessary tests.
bc7b6697 12124
27ccc379
PE
12125 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12126
dcd5c89a
PE
12127 * composite.h, composite.c (composition_gstring_put_cache):
12128 Use EMACS_INT, not int, for length.
12129
b13a45c6
PE
12130 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12131 breaking out part of COMPOSITION_DECODE_RULE.
12132 (COMPOSITION_DECODE_RULE): Use it.
12133 * composite.c (get_composition_id): Remove unused local vars,
12134 by using the new macro.
12135
1e792e4d
PE
12136 * textprop.c (set_text_properties_1): Change while to do-while,
12137 since the condition is always true at first.
12138
dc6c6455 12139 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12140 (interval_deletion_adjustment): Return unsigned value.
12141 All uses changed.
dc6c6455 12142
aba7731a
PE
12143 * process.c (list_processes_1, create_pty, read_process_output):
12144 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12145 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12146 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12147 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12148 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12149
fdfc4bf3
PE
12150 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12151
fca8fe46 12152 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12153 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12154
06a0259a 12155 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12156 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12157 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12158
e7b9e80f
PE
12159 * print.c (print_error_message): Avoid int overflow.
12160
56201685
PE
12161 * font.c (font_list_entities): Redo for clarity,
12162 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12163
78834453 12164 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12165 (font_score): Avoid potential overflow in diff calculation.
78834453 12166
0bc0b309 12167 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12168 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12169
e610eaca
PE
12170 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12171
b895abce
PE
12172 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12173 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12174 can always succeed if overflow has undefined behavior.
12175
1f1d9321 12176 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12177 (wordify): Omit three unnecessary tests.
1f1d9321 12178
c59478bc
PE
12179 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12180 All callers changed. This avoids the need for an unused var.
12181
79b73827
PE
12182 * casefiddle.c (casify_region): Remove var that is set but not used.
12183
a4db5dfe
PE
12184 * dired.c (file_name_completion): Remove var that is set but not used.
12185
43aae36e
PE
12186 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12187
2a47c44d 12188 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12189 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12190
a37c69bf
PE
12191 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12192 Check for integer overflow on size calculations.
12193
328ab8e7
PE
12194 * buffer.c (Fprevious_overlay_change): Remove var that is set
12195 but not used.
12196
e5a2a5cb
PE
12197 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12198 Remove vars that are set but not used.
8d84a6eb 12199 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12200 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12201
a60e5f68
PE
12202 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12203
f661cb61 12204 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12205 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12206
f0397f5a
PE
12207 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12208 that are set but not used.
12209
8664db06 12210 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12211 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12212
6abdaa4a
PE
12213 * xselect.c (x_get_local_selection, x_handle_property_notify):
12214 Remove vars that are set but not used.
12215
0ce7538d 12216 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12217 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12218
9ae848fc
PE
12219 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12220 Remove var that is set but not used.
0b918413
PE
12221 (scroll_bar_windows_size): Now size_t, not int.
12222 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12223 Check for overflow.
9ae848fc 12224
a5a62657
PE
12225 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12226 (map_tty_color) [!defined MSDOS]: Likewise.
12227
5c5cdd39
PE
12228 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12229
66ebf983
PE
12230 * coding.c: Remove vars that are set but not used.
12231 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12232 All callers changed.
12233 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12234 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12235 (decode_coding_charset): Remove vars that are set but not used.
12236
1be4d761
PE
12237 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12238 that is set but not used.
12239
47553fa8
PE
12240 * print.c (print_object): Remove var that is set but not used.
12241
1f7196bf 12242 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12243 The gnulib version avoids calling malloc in the usual case,
12244 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12245 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12246 * filelock.c (current_lock_owner): Likewise.
12247 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12248 * sysdep.c: Include allocator.h, careadlinkat.h.
12249 (emacs_no_realloc_allocator): New static constant.
12250 (emacs_readlink): New function.
fdb61804
PE
12251 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12252 ../lib/careadlinkat.h.
d1fdcab7 12253
f84c17c7
SM
122542011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12255
12256 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12257 first non-nil return value).
12258
ef3862ad
JD
122592011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12260
12261 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12262 if not defined (Bug#8403).
12263
376a7006
JB
122642011-04-02 Juanma Barranquero <lekktu@gmail.com>
12265
12266 * xdisp.c (display_count_lines): Remove parameter `start',
12267 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12268 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12269 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12270 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12271 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12272 and thereabouts. All callers changed.
12273 (get_per_char_metric): Remove parameter `f', unused since
12274 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12275
6ca3801d
JM
122762011-04-02 Jim Meyering <meyering@redhat.com>
12277
12278 do not dereference NULL upon failed strdup
12279 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12280 (ns_get_family): Likewise.
12281
d8e2b5ba
JB
122822011-04-02 Juanma Barranquero <lekktu@gmail.com>
12283
12284 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12285
8c74fcbd
JD
122862011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12287
12288 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12289 later (Bug#8403).
12290
7200d79c
SM
122912011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12292
03408648 12293 Add lexical binding.
7200d79c 12294
03408648
SM
12295 * window.c (Ftemp_output_buffer_show): New fun.
12296 (Fsave_window_excursion):
12297 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12298
12299 * lread.c (lisp_file_lexically_bound_p): New function.
12300 (Fload): Bind Qlexical_binding.
12301 (readevalloop): Remove `evalfun' arg.
12302 Bind Qinternal_interpreter_environment.
12303 (Feval_buffer): Bind Qlexical_binding.
12304 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12305 Mark as dynamic.
12306 (syms_of_lread): Declare `lexical-binding'.
12307
12308 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12309
12310 * keyboard.c (eval_dyn): New fun.
12311 (menu_item_eval_property): Use it.
ca105506
SM
12312
12313 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12314
03408648
SM
12315 * fns.c (concat, mapcar1): Accept byte-code-functions.
12316
12317 * eval.c (Fsetq): Handle lexical vars.
12318 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12319 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12320 (FletX, Flet): Obey lexical binding.
12321 (Fcommandp): Handle closures.
12322 (Feval): New `lexical' arg.
12323 (eval_sub): New function extracted from Feval. Use it almost
12324 everywhere where Feval was used. Look up vars in lexical env.
12325 Handle closures.
12326 (Ffunctionp): Move from subr.el.
12327 (Ffuncall): Handle closures.
12328 (apply_lambda): Remove `eval_flags'.
12329 (funcall_lambda): Handle closures and new byte-code-functions.
12330 (Fspecial_variable_p): New function.
12331 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12332 but without exporting it to Lisp.
23aba0ea 12333
23aba0ea 12334 * doc.c (Fdocumentation, store_function_docstring):
03408648 12335 * data.c (Finteractive_form): Handle closures.
23aba0ea 12336
03408648
SM
12337 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12338 interactive spec.
ba83908c 12339
04f2d78b
CB
12340 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12341 New byte-codes.
03408648
SM
12342 (exec_byte_code): New function extracted from Fbyte_code to handle new
12343 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12344
03408648 12345 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12346
03408648 12347 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12348
e2abce01
JB
123492011-03-31 Juanma Barranquero <lekktu@gmail.com>
12350
12351 * xdisp.c (redisplay_internal): Fix prototype.
12352
63696a73 123532011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12354
63696a73 12355 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12356 (try_scrolling): Use it when setting scroll_limit.
12357 Limit scrolling to 100 screen lines.
63696a73
EZ
12358 (redisplay_window): Even when falling back on "recentering",
12359 position point in the window according to scroll-conservatively,
12360 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12361
12362 (try_scrolling): When point is above the window, allow searching
12363 as far as scroll_max, or one screenful, to compute vertical
12364 distance from PT to the scroll margin position. This prevents
12365 try_scrolling from unnecessarily failing when
12366 scroll-conservatively is set to a value slightly larger than the
12367 window height. Clean up the case of PT below the margin at bottom
12368 of window: scroll_max can no longer be INT_MAX. When aggressive
12369 scrolling is in use, don't let point enter the opposite scroll
12370 margin as result of the scroll.
12371 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12372 threshold of 100 lines for never-recentering scrolling.
12373
e4cc2dfc
JB
123742011-03-31 Juanma Barranquero <lekktu@gmail.com>
12375
12376 * dispextern.h (move_it_by_lines):
12377 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12378 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12379 (message_log_check_duplicate): Remove parameters `prev_bol' and
12380 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12381 (redisplay_internal): Remove parameter `preserve_echo_area',
12382 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12383
12384 * indent.c (Fvertical_motion):
12385 * window.c (window_scroll_pixel_based, Frecenter):
12386 Don't pass `need_y_p' to `move_it_by_lines'.
12387
1c470562
SM
123882011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12389
44f230aa
SM
12390 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12391 steal a few bits to be more compact.
12392 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12393 Remove unneeded casts.
12394
1c470562
SM
12395 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12396
888adce9
ZK
123972011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12398
12399 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12400 binding" message (bug#7967).
12401
f838ed7b
PE
124022011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12403
77861b95
PE
12404 Fix more problems found by GCC 4.6.0's static checks.
12405
de6dbc14
PE
12406 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12407 Remove unused local var.
12408
f838ed7b
PE
12409 * editfns.c (Fmessage_box): Remove unused local var.
12410
792c7b2b
PE
12411 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12412 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12413 Omit unused local vars.
c499e557 12414 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12415 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12416 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12417 Omit unused local var.
12418
ba0165e1
PE
12419 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12420 Don't assume string length fits in int.
32ad8845 12421 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12422 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12423
3c59b4c9
PE
12424 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12425 instead of alloca (Bug#8344).
12426
a3eed478 12427 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12428 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12429
eb4d412d
PE
12430 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12431
1658b401
PE
12432 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12433 concerns.
12434
12435 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12436
12437 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12438
9a2c6e05
PE
12439 * keyboard.c (syms_of_keyboard): Use the same style as later
12440 in this function when indexing through an array. This also
12441 works around GCC bug 48267.
12442
03d0a109
PE
12443 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12444
44f730c8
PE
12445 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12446
fe75f926
PE
12447 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12448 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12449
ffa8c828
PE
12450 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12451 This avoids undefined behavior on integer overflow, and is a bit
12452 more convenient anyway since it is compared to a size_t variable.
12453
c5101a77
PE
12454 Variadic C functions now count arguments with size_t, not int.
12455 This avoids an unnecessary limitation on 64-bit machines, which
12456 caused (substring ...) to crash on large vectors (Bug#8344).
12457 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12458 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12459 All variadic functions and their callers changed accordingly.
c5101a77
PE
12460 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12461 * data.c (arith_driver, float_arith_driver): Likewise.
12462 * editfns.c (general_insert_function): Likewise.
12463 * eval.c (struct backtrace.nargs, interactive_p)
12464 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12465 (funcall_lambda, mark_backtrace): Likewise.
12466 * fns.c (concat): Likewise.
12467 * frame.c (x_set_frame_parameters): Likewise.
12468 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12469 0 if not found, not -1. All callers changed.
12470
dd3f25f7
PE
12471 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12472 (stack_copy_size): Now size_t, not int.
12473 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12474
461c2ab9
JB
124752011-03-28 Juanma Barranquero <lekktu@gmail.com>
12476
12477 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12478 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12479 All callers changed.
12480
12481 * lisp.h (multibyte_char_to_unibyte):
12482 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12483 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12484 * character.h (CHAR_TO_BYTE8):
12485 * cmds.c (internal_self_insert):
12486 * editfns.c (general_insert_function):
12487 * keymap.c (push_key_description):
12488 * search.c (Freplace_match):
12489 * xdisp.c (message_dolog, set_message_1): All callers changed.
12490
f6d62986
SM
124912011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12492
12493 * keyboard.c (safe_run_hook_funcall): New function.
12494 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12495 don't set the hook to nil, but remove the offending function instead.
12496 (Qcommand_hook_internal): Remove, unused.
12497 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12498 Vcommand_hook_internal.
12499
12500 * eval.c (enum run_hooks_condition): Remove.
12501 (funcall_nil, funcall_not): New functions.
12502 (run_hook_with_args): Call each function through a `funcall' argument.
12503 Remove `cond' argument, now redundant.
12504 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12505 (Frun_hook_with_args_until_failure): Adjust accordingly.
12506 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12507
1db5b1ad
JB
125082011-03-28 Juanma Barranquero <lekktu@gmail.com>
12509
12510 * dispextern.h (string_buffer_position): Remove declaration.
12511
12512 * print.c (strout): Remove parameter `multibyte', unused since
12513 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12514
12515 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12516 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12517 All callers changed.
12518
12519 * w32.c (_wsa_errlist): Use braces for struct initializers.
12520
12521 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12522 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12523 All callers changed.
12524 (string_buffer_position): Likewise. Also, make static (it's never
12525 used outside xdisp.c).
12526 (cursor_row_p): Remove parameter `w', unused since
12527 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12528 (decode_mode_spec): Remove parameter `precision', introduced during
12529 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12530 All callers changed.
12531
5ffb62aa
JD
125322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12533
12534 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12535
461c2ab9 125362011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12537
12538 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12539 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12540 (ns_update_auto_hide_menu_bar): New functions.
12541 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12542 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12543 ns_constrain_all_frames.
12544 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12545 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12546
5c380ffb
JD
125472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12548
12549 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12550
9af30bdf
GM
125512011-03-27 Glenn Morris <rgm@gnu.org>
12552
12553 * syssignal.h: Replace RETSIGTYPE with void.
12554 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12555 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12556 Replace SIGTYPE with void everywhere.
12557 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12558 * s/template.h (SIGTYPE): Remove commented out definition.
12559
e2abce01
JB
125602011-03-26 Eli Zaretskii <eliz@gnu.org>
12561
12562 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12563 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12564
f868cd8a
JB
125652011-03-26 Juanma Barranquero <lekktu@gmail.com>
12566
59eb0929
JB
12567 * w32.c (read_unc_volume): Use parameter `henum', instead of
12568 global variable `wget_enum_handle'.
12569
12570 * keymap.c (describe_vector): Remove parameters `indices' and
12571 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12572 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12573
f868cd8a
JB
12574 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12575
12576 * keyboard.c (timer_check): Remove parameter `do_it_now',
12577 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12578 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12579 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12580
12581 * keyboard.c (read_char):
12582 * w32menu.c (w32_menu_display_help):
12583 * xmenu.c (show_help_event, menu_help_callback):
12584 Adjust calls to `show_help_echo'.
12585
12586 * gtkutil.c (xg_maybe_add_timer):
12587 * keyboard.c (readable_events):
12588 * process.c (wait_reading_process_output):
12589 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12590
12591 * insdel.c (adjust_markers_gap_motion):
12592 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12593 (gap_left, gap_right): Don't call it.
12594
2ecf6fdb
CY
125952011-03-25 Chong Yidong <cyd@stupidchicken.com>
12596
12597 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12598 incurred during fontification.
12599
6b1f9ba4
JB
126002011-03-25 Juanma Barranquero <lekktu@gmail.com>
12601
12602 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12603 (DEFVAR_PER_BUFFER): Don't pass it.
12604
12605 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12606 (scrolling_window): Don't pass it.
12607
0f4a96b5
JB
126082011-03-25 Juanma Barranquero <lekktu@gmail.com>
12609
12610 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12611
12612 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12613 and `suffix'.
12614 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12615 of variables specific to SELinux and computation of `encoded_absname'.
12616
12617 * image.c (XPutPixel): Remove unused variable `height'.
12618
12619 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12620
12621 * unexw32.c (get_section_info): Remove unused variable `section'.
12622
12623 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12624 (system_process_attributes): Remove unused variable `sess'.
12625 (sys_read): Remove unused variable `err'.
12626
12627 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12628 (w32_wnd_proc): Remove unused variable `isdead'.
12629 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12630 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12631 (x_create_tip_frame): Remove unused variable `tem'.
12632
12633 * w32inevt.c (w32_console_read_socket):
12634 Remove unused variable `no_events'.
12635
12636 * w32term.c (x_draw_composite_glyph_string_foreground):
12637 Remove unused variable `width'.
12638
1149507c
JB
126392011-03-24 Juanma Barranquero <lekktu@gmail.com>
12640
12641 * w32term.c (x_set_glyph_string_clipping):
12642 Don't pass uninitialized region to CombineRgn.
12643
9c88f339
JB
126442011-03-23 Juanma Barranquero <lekktu@gmail.com>
12645
12646 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12647 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12648 (Fx_close_connection): Remove unused variable `i'.
12649
12650 * w32font.c (w32font_draw): Return number of glyphs.
12651 (w32font_open_internal): Remove unused variable `i'.
12652 (w32font_driver): Add missing initializer.
12653
12654 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12655 (fill_in_menu): Remove unused variable `items_added'.
12656
12657 * w32term.c (last_mouse_press_frame): Remove static global variable.
12658 (w32_clip_to_row): Remove unused variable `f'.
12659 (x_delete_terminal): Remove unused variable `i'.
12660
12661 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12662 (NOTHING): Remove unused static global variable.
12663 (uniscribe_check_otf): Remove unused variable `table'.
12664 (uniscribe_font_driver): Add missing initializers.
12665
dee091a3
JD
126662011-03-23 Julien Danjou <julien@danjou.info>
12667
12668 * term.c (Fsuspend_tty, Fresume_tty):
12669 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12670 * window.c (temp_output_buffer_show):
12671 * insdel.c (signal_before_change):
12672 * frame.c (Fhandle_switch_frame):
12673 * fileio.c (Fdo_auto_save):
12674 * emacs.c (Fkill_emacs):
12675 * editfns.c (save_excursion_restore):
12676 * cmds.c (internal_self_insert):
12677 * callint.c (Fcall_interactively):
12678 * buffer.c (Fkill_all_local_variables):
12679 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12680 Use Frun_hooks.
0f4a96b5 12681 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12682 unconditionally since it does the check itself.
dee091a3 12683
2c520ab5 126842011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12685
c9c49752
PE
12686 Fix more problems found by GCC 4.5.2's static checks.
12687
8abc3f12
PE
12688 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12689 the first time through the loop, since we know p0 < p1 then.
12690 This also avoids a gcc -Wstrict-overflow warning.
12691
a2d26660
PE
12692 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12693 leading to a memory leak, possible in functions like
12694 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12695 of objects (Bug#8318).
a2d26660 12696
916c72e9
PE
12697 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12698 that could (at least in theory) be that large.
12699
19ab8a18
PE
12700 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12701 This is less likely to overflow, and avoids undefined behavior if
12702 overflow does occur. All callers changed. Use strtoul to scan
12703 for the unsigned long integer.
b7cbbd6f
PE
12704 (pint2hrstr): Simplify and tune code slightly.
12705 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12706
f0641eff
PE
12707 * scroll.c (do_scrolling): Work around GCC bug 48228.
12708 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12709
7f650bb9
PE
12710 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12711 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12712 (validate_x_resource_name): Simplify count usage.
12713 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12714
37dd57d1
PE
12715 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12716 fail (Bug#8306).
81e56e61 12717
699979fc 12718 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12719
401bf9b4
PE
12720 * process.c (Fmake_network_process): Use socklen_t, not int,
12721 where POSIX says socklen_t is required in portable programs.
12722 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12723 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12724 (Fmake_network_process, server_accept_connection):
12725 (wait_reading_process_output, read_process_output):
12726 Likewise.
12727
b93aacde
PE
12728 * process.c: Rename or move locals to avoid shadowing.
12729 (list_processes_1, Fmake_network_process):
12730 (read_process_output_error_handler, exec_sentinel_error_handler):
12731 Rename or move locals.
4dc343ee 12732 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12733 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12734 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12735 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12736 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12737
af8a867c 12738 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12739 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12740 Include tparam.h instead, since it declares them.
af8a867c
PE
12741 * cm.h (PC): Remove extern decl; tparam.h now does this.
12742 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12743 * terminfo.c: Include tparam.h, to check interfaces.
12744 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12745 (tparam): Adjust signature to match interface in tparam.h;
12746 this removes some undefined behavior. Check that outstring and len
12747 are zero, which they always are with Emacs.
12748 * tparam.h (PC, BC, UP): New extern decls.
12749
0248044d 12750 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12751 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12752
8ff096c1 12753 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12754 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12755 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12756 (ftfont_list): Remove unused local.
49eaafba
PE
12757 (get_adstyle_property, ftfont_pattern_entity):
12758 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12759 Rename locals to avoid shadowing.
8ff096c1 12760
e2be39f6
PE
12761 * xfont.c (xfont_list_family): Mark var as initialized.
12762
c9735e30
PE
12763 * xml.c (make_dom): Now static.
12764
8f5201ae
PE
12765 * composite.c (composition_compute_stop_pos): Rename local to
12766 avoid shadowing.
b246f932
PE
12767 (composition_reseat_it): Remove unused locals.
12768 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12769 (composition_update_it): Mark var as initialized.
11b61122
PE
12770 (find_automatic_composition): Mark vars as initialized,
12771 with a FIXME (Bug#8290).
8f5201ae 12772
760fbc2c
PE
12773 character.h: Rename locals to avoid shadowing.
12774 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12775 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12776 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12777 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12778 to avoid shadowing.
12779
ff08eb85
PE
12780 * textprop.c (property_change_between_p): Remove; unused.
12781
fc7bf025
PE
12782 * intervals.c (interval_start_pos): Now static.
12783
235d7abc
PE
12784 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12785
44f230aa
SM
12786 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12787 Rename locals to avoid shadowing.
3e7d6594 12788
50060332
PE
12789 * sound.c (wav_play, au_play, Fplay_sound_internal):
12790 Fix pointer signedness.
d01f234b 12791 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12792 (wav_play): Initialize a variable to 0, to prevent undefined
12793 behavior (Bug#8278).
50060332 12794
c4fc4e30
PE
12795 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12796
918436ed
PE
12797 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12798
c939f91b
PE
12799 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12800 clobbering (Bug#8298).
b9c7f648
PE
12801 * sysdep.c (sys_subshell): Likewise.
12802 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12803
6bd8c144
PE
12804 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12805 This should get cleaned up, so that child_setup has the
12806 same signature on all platforms.
12807
7710357c 12808 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12809 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12810
c59da222
CY
128112011-03-22 Chong Yidong <cyd@stupidchicken.com>
12812
12813 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12814 not to be necessary, and produces flickering.
12815
66b87493
GM
128162011-03-20 Glenn Morris <rgm@gnu.org>
12817
12818 * config.in: Remove file.
12819
45b6f6d5
JB
128202011-03-20 Juanma Barranquero <lekktu@gmail.com>
12821
12822 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12823 are now in src/globals.h.
12824 (syms_of_minibuf): Remove spurious & from previous change.
12825
cd394be1 128262011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12827
12828 * minibuf.c (completing-read-function): New variable.
12829 (completing-read-default): Rename from completing-read.
12830 (completing-read): Call completing-read-function.
12831
b14e3e21
CY
128322011-03-19 Juanma Barranquero <lekktu@gmail.com>
12833
12834 * xfaces.c (Fx_load_color_file):
12835 Read color file from absolute filename (bug#8250).
12836
f2b726e6
JB
128372011-03-19 Juanma Barranquero <lekktu@gmail.com>
12838
12839 * makefile.w32-in: Update dependencies.
12840
09f6ff02
EZ
128412011-03-17 Eli Zaretskii <eliz@gnu.org>
12842
12843 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12844
29a6015a
PE
128452011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12846
a3a6c54e
PE
12847 Fix more problems found by GCC 4.5.2's static checks.
12848
b766f867
PE
12849 * process.c (make_serial_process_unwind, send_process_trap):
12850 (sigchld_handler): Now static.
12851
be02381c
PE
12852 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12853 That way, the code declares only the vars that it needs.
12854 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12855 * s/cygwin.h (PTY_ITERATION): Likewise.
12856 * s/darwin.h (PTY_ITERATION): Likewise.
12857 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12858
57048744
PE
12859 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12860 * process.c (allocate_pty): Don't declare stb unless it's needed.
12861
7914961c 12862 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12863 (CONSTANTLIM): Remove; unused.
12864 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12865 Define only if needed.
7914961c 12866
b3967b18
PE
12867 * unexelf.c (unexec): Name an expression,
12868 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12869 Use a different way to cause a compilation error if anyone uses
12870 n rather than nn, a way that does not involve shadowing.
73366a00 12871 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12872
29a6015a
PE
12873 * deps.mk (unexalpha.o): Remove; unused.
12874
43cfc33e 12875 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12876 * unexec.h: New file.
ce701a33
PE
12877 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12878 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12879 Depend on unexec.h.
12880 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12881 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12882 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12883 Change as necessary to match prototype in unexec.h.
ce701a33 12884
01f44d5a
PE
12885 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12886 shadowing.
4f63c6bb 12887 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12888
a6670b0b
PE
12889 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12890 Rename locals to avoid shadowing.
12891
cef2010d 12892 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12893 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12894
d4d7173a
PE
12895 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12896
f08b802a
PE
12897 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12898 warning when compiling print.c.
12899
3ddb0639
PE
12900 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12901 instead of using an uninitialized var.
5ad03b97 12902 (font_sort_entities): Mark var as initialized.
3ddb0639 12903
170a2692
PE
12904 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12905
e663c700
PE
12906 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12907 pointers to constants.
89bc529a 12908 (font_parse_fcname): Remove unused vars.
7b81e2d0 12909 (font_delete_unmatched): Now static.
ea838e10 12910 (font_get_spec): Remove; unused.
13a547c6
PE
12911 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12912 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12913 Rename or move locals to avoid shadowing.
e663c700 12914
2a80c887 12915 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12916 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12917
1384fa33 12918 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12919 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12920
8b2c52e9
PE
12921 * alloc.c (mark_backtrace): Move decl from here ...
12922 * lisp.h: ... to here, so that it can be checked.
12923
475545b5 12924 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12925 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12926 (lisp_indirect_variable): Name an expression,
12927 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12928 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12929
b1349114 12930 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12931 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12932 Use const pointer when appropriate.
b1349114 12933
a2928364
PE
12934 * lisp.h (get_system_name, get_operating_system_release):
12935 Move decls here, to check interfaces.
12936 * process.c (get_operating_system_release): Move decl to lisp.h.
12937 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12938 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12939 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12940 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12941 (Fformat_time_string, Fencode_time, Finsert_char):
12942 (Ftranslate_region_internal, Fformat):
12943 Rename or remove local vars to avoid shadowing.
9710023e 12944 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12945
a415e694
PE
12946 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12947 avoid shadowing.
12948
8ef4622d
PE
12949 * lisp.h (eassert): Check that the argument compiles, even if
12950 ENABLE_CHECKING is not defined.
12951
946f9a5b
PE
12952 * data.c (Findirect_variable): Name an expression, to avoid
12953 gcc -Wbad-function-cast warning.
112396d6 12954 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12955 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12956 (Fmake_variable_buffer_local, Fmake_local_variable):
12957 Mark variables as initialized.
52746918 12958 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12959
e5aab7e7 12960 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12961 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12962 Rename locals to avoid shadowing.
dff45157
PE
12963 (mark_stack): Move local variables into the #ifdef region where
12964 they're used.
7bc26fdb
PE
12965 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12966 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12967 needed otherwise.
12968 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12969 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12970 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12971
e5aab7e7
PE
12972 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12973 avoids undefined behavior in theory.
12974
4da60324
PE
12975 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12976
88043301
PE
12977 Use functions, not macros, for up- and down-casing (Bug#8254).
12978 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12979 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12980 to use the following functions instead of these macros.
12981 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12982 EMACS_INT, since callers assume the returned value fits in int.
12983 (upcase1): Likewise, for UPCASE_TABLE.
12984 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12985 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12986 the race-condition problem in the old DOWNCASE.
88043301 12987
19ed5445
PE
12988 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12989 Rename locals to avoid shadowing.
12990 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12991 (regex_compile, re_search_2, re_match_2_internal):
12992 Remove unused local vars.
952db0d7
PE
12993 (FREE_VAR): Rewrite so as not to use empty "else",
12994 which gcc can warn about.
da053e48 12995 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12996 (RETALLOC_IF): Define only if needed.
12997 (WORDCHAR_P): Likewise. This one is never needed, but is used
12998 only in a comment talking about a compiler bug, so put inside
12999 the #if 0 of that comment.
13000 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13001 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13002 Remove; unused.
19ed5445 13003
1f3561e4 13004 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13005 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13006 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13007
ded6f8f7
PE
13008 * search.c (simple_search): Remove unused var.
13009
dbd37a95
PE
13010 * dired.c (compile_pattern): Move decl from here ...
13011 * lisp.h: ... to here, so that it can be checked.
13012 (struct re_registers): New forward decl.
13013
7e47afad
PE
13014 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13015
85f24f61
PE
13016 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13017 All uses changed.
13018 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13019 Rename locals to avoid shadowing.
5671df8f 13020 (Fvertical_motion): Mark locals as initialized.
85f24f61 13021
181aa2be 13022 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13023 (casify_region): Mark local as initialized.
181aa2be 13024
930d429c
PE
13025 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13026
7082eac6
PE
13027 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13028 New macros, so that the caller can use some names other than
13029 gcpro1, gcpro2, etc.
13030 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13031 of the new macros.
13032 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13033 argument, for consistency with GCPRO2_VAR, etc: it is now the
13034 prefix of the variable, not the variable itself. All uses
13035 changed.
38b2c076
PE
13036 * dired.c (directory_files_internal, file_name_completion):
13037 Rename locals to avoid shadowing.
13038
15206ed9
PE
13039 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13040 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13041 dired.c's scmp function, had undefined behavior.
13042 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13043 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13044 * buffer.h: ... to here, because these macros use current_buffer,
13045 and the new implementation with inline functions needs to have
13046 current_buffer in scope now, rather than later when the macros
13047 are used.
13048 (downcase, upcase1): New static inline functions.
13049 (DOWNCASE, UPCASE1): Reimplement using these functions.
13050 This avoids undefined behavior in expressions like
13051 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13052 from race conditions in accessing the global variables
13053 case_temp1 and case_temp2.
13054 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13055 * lisp.h (case_temp1, case_temp2): Remove their decls.
13056 * character.h (ASCII_CHAR_P): Move from here ...
13057 * lisp.h: ... to here, so that the inline functions mentioned
13058 above can use them.
13059
4a6bea26
PE
13060 * dired.c (directory_files_internal_unwind): Now static.
13061
f14b7e14
PE
13062 * fileio.c (file_name_as_directory, directory_file_name):
13063 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13064 Now static.
2893f146
PE
13065 (file_name_as_directory): Use const pointers when appropriate.
13066 (Fexpand_file_name): Likewise. In particular, newdir might
13067 point at constant storage, so make it a const pointer.
fd4ead52 13068 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13069 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13070 signedness issues.
f839df0c
PE
13071 (Fset_file_times, Finsert_file_contents, auto_save_error):
13072 Rename locals to avoid shadowing.
f14b7e14 13073
5716756e 13074 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13075 (Ftry_completion, Fall_completions): Rename or remove locals
13076 to avoid shadowing.
5716756e 13077
b4c3046a
PE
13078 * marker.c (bytepos_to_charpos): Remove; unused.
13079
b45db522
PE
13080 * lisp.h (verify_bytepos, count_markers): New decls,
13081 so that gcc does not warn that these functions aren't declared.
13082
85876d07
PE
13083 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13084 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13085 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13086 (copy_text): Remove unused local var.
85876d07 13087
03d78a21 13088 * filelock.c (within_one_second): Now static.
b3dd38ab 13089 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13090
5df8f01b
PE
13091 * buffer.c (fix_overlays_before): Mark locals as initialized.
13092 (fix_start_end_in_overlays): Likewise. This function should be
13093 simplified by using pointers-to-pointers, but that's a different
13094 matter.
b1d876f1 13095 (switch_to_buffer_1): Now static.
8f54f30a
PE
13096 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13097 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13098
a70072c9 13099 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13100 Fix pointer signedness issue.
edced198
PE
13101 (sys_subshell): Mark local as volatile if checking for lint,
13102 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13103 (MAXPATHLEN): Define only if needed.
a70072c9 13104
a0977c44
PE
13105 * process.c (serial_open, serial_configure): Move decls from here ...
13106 * systty.h: ... to here, so that they can be checked.
13107
a884fdcc
PE
13108 * fns.c (get_random, seed_random): Move extern decls from here ...
13109 * lisp.h: ... to here, so that they can be checked.
13110
604efe86 13111 * sysdep.c (reset_io): Now static.
b8950c94 13112 (wait_for_termination_signal): Remove; unused.
604efe86 13113
38fc62d9
PE
13114 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13115 (copy_keymap_item, append_key, push_text_char_description):
13116 Now static.
1004a21a 13117 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13118 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13119 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13120 (describe_map_tree):
13121 Rename locals to avoid shadowing.
38fc62d9 13122
2f2650da
PE
13123 * keyboard.c: Declare functions static if they are not used elsewhere.
13124 (echo_char, echo_dash, cmd_error, top_level_2):
13125 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13126 (read_char, kbd_buffer_get_event, make_lispy_position):
13127 (make_lispy_event, make_lispy_movement, apply_modifiers):
13128 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13129 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13130 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13131 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13132 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13133
a053e86c 13134 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13135 (mark_kboards): Move decl here ...
13136 * alloc.c (mark_kboards): ... from here.
a053e86c 13137
4752793e
PE
13138 * lisp.h (force_auto_save_soon): New decl.
13139
74f10ca7 13140 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13141 (DEFINE_DUMMY_FUNCTION): New macro.
13142 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13143 Use it.
c03cd23f
PE
13144 (main): Add casts to avoid warnings
13145 if GCC considers string literals to be constants.
74f10ca7 13146
022e70d4
PE
13147 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13148
59d6fe83
PE
13149 * dbusbind.c: Pointer signedness fixes.
13150 (xd_signature, xd_append_arg, xd_initialize):
13151 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13152 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13153 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13154 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13155
78320123
PE
13156 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13157 if GCC considers string literals to be constants.
49cebcca 13158 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13159
35ac2a97
SM
131602011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13161
fb103ca9
SM
13162 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13163 (print_preprocess, print_object): New macro to fix last change.
13164
35ac2a97
SM
13165 * print.c (print_preprocess): Don't forget font objects.
13166
62973b41
JB
131672011-03-16 Juanma Barranquero <lekktu@gmail.com>
13168
13169 * emacs.c (USAGE3): Doc fixes.
13170
0e48bb22
AS
131712011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13172
13173 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13174 structure.
13175
7684e57b
JB
131762011-03-14 Juanma Barranquero <lekktu@gmail.com>
13177
13178 * lisp.h (VWindow_system, Qfile_name_history):
13179 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13180 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13181 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13182
13183 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13184 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13185
13186 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13187 * w32console.c (detect_input_pending, read_input_pending)
13188 (encode_terminal_code):
13189 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13190 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13191 (w32_system_caret_y, Qfile_name_history):
13192 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13193 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13194 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13195 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13196 * w32proc.c (Qlocal, report_file_error):
13197 * w32term.c (Vwindow_system, updating_frame):
13198 * w32uniscribe.c (initialized, uniscribe_font_driver):
13199 Remove unneeded extern declarations.
13200
2aa46d6c
CY
132012011-03-14 Chong Yidong <cyd@stupidchicken.com>
13202
c96bbc66 13203 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13204
cffc6f3b
CY
132052011-03-13 Chong Yidong <cyd@stupidchicken.com>
13206
13207 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13208 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13209 These macros can no longer be used for assignment.
13210
44f230aa
SM
13211 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13212 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13213 (record_buffer_markers, fetch_buffer_markers): New functions for
13214 recording and fetching special buffer markers.
13215 (set_buffer_internal_1, set_buffer_temp): Use them.
13216
13217 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13218
13219 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13220
13221 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13222 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13223
13224 * xdisp.c (hscroll_window_tree):
13225 (reconsider_clip_changes): Use PT instead of BUF_PT.
13226
d251f04b
EZ
132272011-03-13 Eli Zaretskii <eliz@gnu.org>
13228
13229 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13230 $(EMACS_ROOT)/lib/intprops.h.
13231
f0c77cd1
PE
132322011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13233
3eca4629
PE
13234 Fix more problems found by GCC 4.5.2's static checks.
13235
7c86ee98
PE
13236 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13237 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13238 (xg_free_frame_widgets): Make it clear that a local variable is
13239 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13240 (gdk_window_get_screen): Make it clear that this macro is needed
13241 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13242 (int_gtk_range_get_value): New function, which avoids a diagnostic
13243 from gcc -Wbad-function-cast.
13244 (xg_set_toolkit_scroll_bar_thumb): Use it.
13245 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13246 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13247 (get_utf8_string, xg_get_file_with_chooser):
13248 Rename locals to avoid shadowing.
13249 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13250
41729b81
PE
13251 * xgselect.c (xg_select): Remove unused var.
13252
f0c77cd1
PE
13253 * image.c (four_corners_best): Mark locals as initialized.
13254 (gif_load): Initialize transparent_p to zero (Bug#8238).
13255 Mark another local as initialized.
ec6cf4c6 13256 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13257
ce0ad53d 13258 * image.c (clear_image_cache): Now static.
d5d5a617 13259 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13260 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13261 (x_edge_detection): Remove unnecessary cast that
13262 gcc -Wbad-function-cast diagnoses.
2037898d 13263 (gif_load): Fix pointer signedness.
6ae141d6
PE
13264 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13265 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13266
33383987 132672011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13268
d32df629
PE
13269 Improve quality of tests for time stamp overflow.
13270 For example, without this patch (encode-time 0 0 0 1 1
13271 1152921504606846976) returns the obviously-bogus value (-948597
13272 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13273 reports time overflow. See
13274 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13275 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13276 * editfns.c: Include limits.h and intprops.h.
13277 (TIME_T_MIN, TIME_T_MAX): New macros.
13278 (time_overflow): Move earlier, to before first use.
13279 (hi_time, lo_time): New functions, for an accurate test for
13280 out-of-range times.
13281 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13282 (Fget_internal_run_time): Don't assume time_t fits in int.
13283 (make_time): Use list2 instead of Fcons twice.
13284 (Fdecode_time): More accurate test for out-of-range times.
13285 (check_tm_member): New function.
13286 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13287 (lisp_time_argument): Don't rely on undefined left-shift and
13288 right-shift behavior when checking for time stamp overflow.
8be6f318 13289
fe31d94c
PE
13290 * editfns.c (time_overflow): New function, refactoring common code.
13291 (Fformat_time_string, Fdecode_time, Fencode_time):
13292 (Fcurrent_time_string): Use it.
13293
8be6f318
PE
13294 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13295 * dired.c (make_time): Move to ...
13296 * editfns.c (make_time): ... here.
13297 * systime.h: Note the move.
13298
09d9db2c 132992011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13300
126bc0dc
YM
13301 * fringe.c (update_window_fringes): Remove unused variables.
13302
c47cbdfd
YM
13303 * unexmacosx.c (copy_data_segment): Also copy __got section.
13304 (Bug#8223)
13305
7ac80be9
EZ
133062011-03-12 Eli Zaretskii <eliz@gnu.org>
13307
c96bbc66 13308 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13309 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13310 Constify `char *' arguments and their references according to
13311 prototypes in tparam.h.
13312
ecb0f94d 13313 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13314
7ac80be9
EZ
13315 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13316 Adapt all references accordingly.
13317
13318 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13319
ef1fd07e
TT
133202011-03-11 Tom Tromey <tromey@redhat.com>
13321
13322 * buffer.c (syms_of_buffer): Remove obsolete comment.
13323
7ef4b50c
EZ
133242011-03-11 Eli Zaretskii <eliz@gnu.org>
13325
13326 * termhooks.h (encode_terminal_code): Declare prototype.
13327
13328 * msdos.c (encode_terminal_code): Don't declare prototype.
13329
13330 * term.c (encode_terminal_code): Now external again, used by
13331 w32console.c and msdos.c.
13332
44f230aa
SM
13333 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13334 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13335
4b1ec863 133362011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13337
1714f52b 13338 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13339
4b1ec863
PE
13340 * fringe.c (update_window_fringes): Mark locals as initialized
13341 (Bug#8227).
13342 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13343
524c7aa6
PE
13344 * alloc.c (mark_fringe_data): Move decl from here ...
13345 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13346 to check its interface.
13347 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13348
a5c0af81 13349 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13350 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13351 (fontset_font): Mark local as initialized.
a9a06e0b 13352 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13353
b4716021
PE
13354 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13355
811e9bac 13356 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13357 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13358 (x_own_selection, Fx_disown_selection_internal): Rename locals
13359 to avoid shadowing.
13360 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13361
7e3ab302
PE
13362 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13363 so that the caller can use some name other than gcpro1.
13364 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13365 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13366 (Fx_backspace_delete_keys_p):
13367 Use them to avoid shadowing, and rename vars to avoid shadowing.
13368 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13369 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13370 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13371 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13372 Remove unused locals.
7e3ab302
PE
13373 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13374 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13375 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13376 macros.
f78faa98 13377
e2b13473
PE
13378 * xterm.h (x_mouse_leave): New decl.
13379
77f23912
PE
13380 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13381 Remove unused functions.
cdf4ba58
PE
13382 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13383 (x_calc_absolute_position): Now static.
7411c686 13384 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13385 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13386 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13387 unless they are used.
38d0b34a
PE
13388 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13389 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13390 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13391 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13392 (x_error_catcher, x_connection_closed, x_error_handler):
13393 (x_error_quitter, xembed_send_message, x_iconify_frame):
13394 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13395 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13396 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13397
44f230aa
SM
13398 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13399 Rename or move locals to avoid shadowing.
6b463e58 13400 (tty_defined_color, merge_face_heights): Now static.
5967d051 13401 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13402 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13403 does not deduce is never used uninitialized.
73719eba
PE
13404 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13405 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13406
426994c3 13407 * terminal.c (store_terminal_param): Now static.
5489860b 13408
032f1620 13409 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13410 (set_frame_menubar): Remove unused local.
d4323972 13411 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13412 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13413 since they might point to immutable storage.
281585b0
PE
13414 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13415 since it's unused otherwise.
032f1620 13416
367c19e5 13417 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13418 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13419 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13420 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13421 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13422 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13423 does not deduce are never used uninitialized.
70739cbe 13424
07b48fa9
PE
13425 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13426
8868a238 13427 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13428 * window.c (window_loop, size_window):
13429 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13430
7e5cf297 13431 * window.c (display_buffer): Now static.
d6550a9f
PE
13432 (size_window): Mark variables that gcc -Wuninitialized
13433 does not deduce are never used uninitialized.
a586633d
PE
13434 * window.h (check_all_windows): New decl, to forestall
13435 gcc -Wmissing-prototypes diagnostic.
5b555da1 13436 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13437
f6095868
PE
13438 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13439 shadowing.
13440 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13441 Include <limits.h>.
13442 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13443 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13444 (load_charset_map): Mark variables that gcc -Wuninitialized
13445 does not deduce are never used uninitialized.
53df7c11 13446 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13447
f38b440c
PE
13448 * coding.c (coding_set_source, coding_set_destination):
13449 Use "else { /* comment */ }" rather than "else /* comment */;"
13450 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13451 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13452 a block, when the outer 'i' will do.
13453 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13454 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13455 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13456 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13457 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13458 Rename locals to avoid shadowing.
13459 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13460 * coding.c (emacs_mule_char, encode_invocation_designation):
13461 Now static, since they're not used elsewhere.
413bb2db 13462 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13463 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13464 (decode_coding_emacs_mule): Mark variables that gcc
13465 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13466 (detect_coding_iso_2022): Initialize a local variable that might
13467 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13468 this initialization is needed. (Bug#8211)
5f58e762
PE
13469 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13470 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13471 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13472 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13473 Remove unused macros.
f38b440c 13474
232b38b9 13475 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13476 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13477 * character.c (string_count_byte8): Likewise.
232b38b9 13478
fb90da1b
PE
13479 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13480 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13481
fb93dbc2
PE
13482 * chartab.c (copy_sub_char_table): Now static, since it's not used
13483 elsewhere.
5c156ace
PE
13484 (sub_char_table_ref_and_range, char_table_ref_and_range):
13485 Rename locals to avoid shadowing.
bbcd0949 13486 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13487
7d3b3862 13488 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13489 (BIDI_BOB): Remove unused macro.
7d3b3862 13490
6be7d3da
PE
13491 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13492 deduce are never used uninitialized.
c2ed9c8b 13493 * term.c (encode_terminal_code): Likewise.
6be7d3da 13494
75f8807f 13495 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13496
50938595
PE
13497 * tparam.h: New file.
13498 * term.c, tparam.h: Include it.
13499 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13500 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13501 Move these decls to tparam.h, and make them agree with what
13502 is actually in tparam.c. The previous trick of using incompatible
13503 decls in different modules does not conform to the C standard.
13504 All callers of tparam changed to use tparam's actual API.
13505 * tparam.c (tparam1, tparam, tgoto):
13506 Use const pointers where appropriate.
13507
fbceeba2
PE
13508 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13509 * cm.h (struct cm): Likewise.
13510 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13511 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13512 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13513 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13514 (turn_on_face, init_tty): Likewise.
13515 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13516
7f3f1250
PE
13517 * term.c (term_mouse_position): Rename local to avoid shadowing.
13518
e6ca6543
PE
13519 * alloc.c (mark_ttys): Move decl from here ...
13520 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13521
c40f8d15
AS
135222011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13523
13524 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13525
cfe0661d
JB
135262011-03-09 Juanma Barranquero <lekktu@gmail.com>
13527
13528 * search.c (compile_pattern_1): Remove argument regp, unused since
13529 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13530 (compile_pattern): Don't pass it.
13531
0afb4571
J
135322011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13533
13534 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13535 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13536 for ! HAVE_GTK3.
13537 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13538
13539 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13540
13541 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13542 gdk_window_get_screen, gdk_window_get_geometry,
13543 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13544 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13545 (xg_get_pixbuf_from_pixmap): New function.
13546 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13547 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13548 Call xg_get_pixbuf_from_pixmap instead of
13549 gdk_pixbuf_get_from_drawable.
13550 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13551 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13552 (xg_check_special_colors): Use GtkStyleContext and its functions
13553 for HAVE_GTK3.
13554 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13555 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13556 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13557 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13558 Call gtk_widget_get_preferred_size.
0afb4571
J
13559 (xg_frame_resized): gdk_window_get_geometry only takes 5
13560 parameters.
44f230aa
SM
13561 (xg_win_to_widget, xg_event_is_for_menubar):
13562 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13563 (xg_set_widget_bg): New function.
13564 (delete_cb): New function.
895009e1 13565 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13566 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13567 (xg_set_background_color): Call xg_set_widget_bg.
13568 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13569 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13570 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13571 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13572 if ! HAVE_GTK3.
13573 (update_frame_tool_bar): Call gtk_widget_hide.
13574 (xg_initialize): Use GDK_KEY_g.
13575
13576 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13577 if ! HAVE_GTK3
13578 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13579
13580 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13581 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13582 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13583
1c2cc4ef
JB
135842011-03-08 Juanma Barranquero <lekktu@gmail.com>
13585
13586 * w32xfns.c (select_palette): Check success of RealizePalette against
13587 GDI_ERROR, not zero.
13588
33383987 13589See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13590
13591;; Local Variables:
13592;; coding: utf-8
aac0c6e3
MR
13593;; End:
13594
2f097256 13595 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13596
13597 This file is part of GNU Emacs.
13598
13599 GNU Emacs is free software: you can redistribute it and/or modify
13600 it under the terms of the GNU General Public License as published by
13601 the Free Software Foundation, either version 3 of the License, or
13602 (at your option) any later version.
13603
13604 GNU Emacs is distributed in the hope that it will be useful,
13605 but WITHOUT ANY WARRANTY; without even the implied warranty of
13606 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13607 GNU General Public License for more details.
13608
13609 You should have received a copy of the GNU General Public License
13610 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.