Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3164aeac
PE
12011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c (mark_memory): Omit 3rd (offset) arg; caller changed.
4 Don't assume EMACS_INT alignment is the same as pointer alignment.
5 (GC_POINTER_ALIGNMENT): New macro.
f2b31075 6 (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
8 (string_bytes, check_sblock, allocate_string_data):
9 (compact_small_strings, Fmake_bool_vector, make_string)
10 (make_unibyte_string, make_multibyte_string)
11 (make_string_from_bytes, make_specified_string)
12 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
13 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
14 (mark_vectorlike):
15 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
16 (allocate_pseudovector):
17 Use int, not EMACS_INT, where int is wide enough.
18 (inhibit_garbage_collection, Fgarbage_collect):
19 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
c9af454e
PE
20 (GC_LISP_OBJECT_ARGUMENT):
21 Use offsetof, not __alignof__ or sizeof. __alignof__ gives
22 the wrong answer on the x86 with GCC.
d311d28c
PE
23 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
24 int might not be wide enough.
25 (bidi_cache_search, bidi_cache_find, bidi_init_it)
26 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
27 (bidi_at_paragraph_end, bidi_find_paragraph_start)
28 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
29 (bidi_level_of_next_char, bidi_move_to_visually_next):
30 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
31 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
32 (Fkill_buffer, Fset_buffer_major_mode)
33 (advance_to_char_boundary, Fbuffer_swap_text)
34 (Fset_buffer_multibyte, overlays_at, overlays_in)
35 (overlay_touches_p, struct sortvec, record_overlay_string)
36 (overlay_strings, recenter_overlay_lists)
37 (adjust_overlays_for_insert, adjust_overlays_for_delete)
38 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
39 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
40 (Foverlay_recenter, last_overlay_modification_hooks_used)
41 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
42 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
43 (validate_region): Omit unnecessary test for b <= e, since
44 that's guaranteed by the previous test.
45 (adjust_overlays_for_delete): Avoid pos + length overflow.
46 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
47 (report_overlay_modification):
48 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
49 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
50 Omit pointer cast, which isn't needed anyway, and doesn't work
51 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
52 (Fmove_overlay): Delete an evaporating overlay
53 if it becomes empty after its bounds are adjusted to fit within
54 its buffer. Without this fix, in a nonempty buffer (let ((o
55 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
56 yields an empty overlay that has the evaporate property, which is
57 not supposed to happen. (Bug#9642)
d311d28c
PE
58 * buffer.h: Adjust decls to match defn changes elsewhere.
59 (struct buffer_text, struct buffer):
60 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
61 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
62 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
63 not int, to avoid needless 32-bit limit on 64-bit hosts.
64 (exec_byte_code): Use tighter memory-full test, one that checks
65 for alloca overflow. Don't compute the address of the object just
66 before an array, as that's not portable. Use EMACS_INT, not
67 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
68 * callint.c (Fcall_interactively):
69 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
70 * callproc.c (call_process_kill, Fcall_process):
71 Don't assume pid_t fits into an Emacs fixnum.
72 (call_process_cleanup, Fcall_process, child_setup):
73 Don't assume pid_t fits into int.
74 (call_process_cleanup, Fcall_process, delete_temp_file)
75 (Fcall_process_region):
76 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
77 (Fcall_process): Simplify handling of volatile integers.
78 Use int, not EMACS_INT, where int will do.
79 * casefiddle.c (casify_object, casify_region, operate_on_word)
80 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
81 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
82 (casify_object): Avoid integer overflow when overallocating buffer.
83 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 84 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
85 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
86 * category.h (CATEGORYP): Don't assume arg is nonnegative.
87 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
88 integers are now checked earlier. All uses replaced with XINT.
89 (ccl_driver):
90 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
91 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
92 (ccl_driver, Fregister_code_conversion_map):
93 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
94 (resolve_symbol_ccl_program): Check that vector header is in range.
95 Always copy the vector, so that we can check its contents reliably
96 now rather than having to recheck each instruction as it's being
97 executed. Check that vector words fit in 'int'.
98 (ccl_get_compiled_code, Fregister_ccl_program)
99 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
100 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
101 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
102 contents are in range.
103 (Fccl_execute_on_string): Check that status is in range.
104 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
105 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
106 Accept and return EMACS_INT, not int, because callers can pass values
107 out of 'int' range.
108 (c_string_width, strwidth, lisp_string_width, chars_in_text)
109 (multibyte_chars_in_text, parse_str_as_multibyte)
110 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
111 (str_as_unibyte, str_to_unibyte, string_count_byte8)
112 (string_escape_byte8, Fget_byte):
113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
114 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
115 avoid mishandling large integers.
116 * character.h: Adjust decls to match defn changes elsewhere.
117 * charset.c (load_charset_map_from_file, find_charsets_in_text)
118 (Ffind_charset_region):
119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
120 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
121 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 122 Don't assume fixnum fits in int.
d311d28c
PE
123 (load_charset_map_from_vector, Fmap_charset_chars):
124 Remove now-unnecessary CHECK_NATNUMs.
125 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
126 Don't rely on undefined behavior with signed left shift overflow.
127 Don't assume unsigned int fits into fixnum, or that fixnum fits
128 into unsigned int. Don't require max_code to be a valid fixnum;
129 that's not true for gb10830 4-byte on a 32-bit host. Allow
130 invalid_code to be a cons, for the same reason. Require code_offset
131 to be a character. Avoid int overflow if max_char is close
132 to INT_MAX.
133 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
134 this is intended anyway and avoids some undefined behavior.
135 (load_charset_map): Pass unsigned, not int, as 2nd arg of
136 INDEX_TO_CODE_POINT, as that's what it expects.
137 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
138 * charset.h (DECODE_CHAR): Return int, not unsigned;
139 this is what was intended anyway, and it avoids undefined behavior.
140 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
141 integer-overflow issues.
142 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
143 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
144 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
145 * chartab.c (Fmake_char_table, Fset_char_table_range)
146 (uniprop_get_decoder, uniprop_get_encoder):
147 Don't assume fixnum fits in int.
148 * cmds.c (move_point): New function, that does the gist of
149 Fforward_char and Fbackward_char, but does so while checking
150 for integer overflow more accurately.
c96e5d6a 151 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
152 (Fforward_line, Fend_of_line, internal_self_insert)
153 (internal_self_insert):
154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
155 Fix a FIXME, by checking for integer overflow when calculating
156 target_clm and actual_clm.
157 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
158 (ASSURE_DESTINATION, coding_alloc_by_realloc)
159 (coding_alloc_by_making_gap, alloc_destination)
160 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
161 (encode_coding_utf_16, detect_coding_emacs_mule)
162 (decode_coding_emacs_mule, encode_coding_emacs_mule)
163 (detect_coding_iso_2022, decode_coding_iso_2022)
164 (encode_invocation_designation, encode_designation_at_bol)
165 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
166 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
167 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
168 (encode_coding_ccl, encode_coding_raw_text)
169 (detect_coding_charset, decode_coding_charset)
170 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
171 (produce_composition, produce_charset, produce_annotation)
172 (decode_coding, handle_composition_annotation)
173 (handle_charset_annotation, consume_chars, decode_coding_gap)
174 (decode_coding_object, encode_coding_object, detect_coding_system)
175 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
176 (code_convert_region, code_convert_string)
177 (Fdefine_coding_system_internal):
178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
179 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
180 (Fdefine_coding_system_internal):
181 Don't assume fixnums fit in int.
182 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 183 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
184 (Funencodable_char_position, Fcheck_coding_systems_region)
185 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2c6a9faa 187 (consume_chars): Rewrite to avoid calculating an address outside buffer.
d311d28c 188 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 189 Don't access memory outside of the args array.
d311d28c 190 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
191 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
192 result of ENCODE_CHAR.
d311d28c
PE
193 * coding.h: Adjust decls to match defn changes elsewhere.
194 (struct coding_system):
195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
196 * composite.c (get_composition_id, find_composition)
197 (run_composition_function, update_compositions)
198 (compose_text, composition_gstring_put_cache)
199 (composition_gstring_p, composition_gstring_width)
200 (fill_gstring_header, fill_gstring_body, autocmp_chars)
201 (composition_compute_stop_pos, composition_reseat_it)
202 (composition_update_it, struct position_record)
203 (find_automatic_composition, composition_adjust_point)
204 (Fcomposition_get_gstring, Ffind_composition_internal):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 (update_compositions):
207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
208 * composite.h: Adjust decls to match defn changes elsewhere.
209 (struct composition):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
212 Do not attempt to compute the address of the object just before a
213 buffer; this is not portable.
214 (Faref, Faset):
215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
216 (Faset): Use int, not EMACS_INT, where int is wide enough.
217 (Fstring_to_number): Don't assume fixnums fit in int.
218 (Frem): Don't assume arg is nonnegative.
219 * dbusbind.c (xd_append_arg): Check for integers out of range.
220 (Fdbus_call_method): Don't overflow the timeout int.
221 * dired.c (directory_files_internal, file_name_completion, scmp)
222 (file_name_completion_stat):
223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
224 (file_name_completion): Don't overflow matchcount.
225 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
226 * dispextern.h: Adjust decls to match defn changes elsewhere.
227 (struct text_pos, struct glyph, struct bidi_saved_info)
228 (struct bidi_string_data, struct bidi_it, struct composition_it)
229 (struct it):
230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
231 (struct display_pos, struct composition_it, struct it):
232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
233 * dispnew.c (increment_matrix_positions)
234 (increment_row_positions, mode_line_string)
235 (marginal_area_string):
236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 237 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
239 (duration_to_sec_usec): New function, to check for overflow better.
240 (Fsleep_for, sit_for): Use it.
241 * doc.c (get_doc_string, store_function_docstring):
242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
243 (get_doc_string, Fsnarf_documentation):
244 Use int, not EMACS_INT, where int is wide enough.
245 (get_doc_string):
246 Use SAFE_ALLOCA, not alloca.
247 Check for overflow when converting EMACS_INT to off_t.
248 * doprnt.c (doprnt):
249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
250 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
251 Don't assume uid_t fits into fixnum.
252 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
253 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
254 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
255 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
256 (general_insert_function)
257 (Finsert_char, make_buffer_string, make_buffer_string_both)
258 (update_buffer_properties, Fbuffer_substring)
259 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
260 (Fsubst_char_in_region, check_translation)
261 (Ftranslate_region_internal, save_restriction_restore, Fformat)
262 (transpose_markers, Ftranspose_regions):
263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
264 (clip_to_bounds): Move to lisp.h as an inline function).
265 (Fconstrain_to_field): Don't assume integers are nonnegative.
266 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
267 (Fsubst_char_in_region, Fsave_restriction):
268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
269 (Femacs_pid): Don't assume pid_t fits into fixnum.
270 (lo_time): Use int, not EMACS_INT, when int suffices.
271 (lisp_time_argument): Check for usec out of range.
272 (Fencode_time): Don't assume fixnum fits in int.
273 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
274 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
275 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
276 (init_cmdargs, Fdump_emacs):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
279 the bottom (typically) 32 bits of the fixnum.
280 * eval.c (specpdl_size, call_debugger):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (when_entered_debugger, Fbacktrace_debug):
283 Don't assume fixnum can fit in int.
284 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
285 the object just before a buffer; this is not portable.
286 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
287 (grow_specpdl, unbind_to):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
290 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 291 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
292 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
293 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
295 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
296 (a_write, e_write):
297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
298 (Fcopy_file, non_regular_nbytes, read_non_regular)
299 (Finsert_file_contents):
300 Use int, not EMACS_INT, where int is wide enough.
301 (READ_BUF_SIZE): Verify that it fits in int.
302 (Finsert_file_contents): Check that counts are in proper range,
303 rather than assuming fixnums fit into ptrdiff_t etc.
304 Don't assume fixnums fit into int.
125b3835 305 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
306 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
307 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
308 (string_char_to_byte, string_byte_to_char)
309 (string_make_multibyte, string_to_multibyte)
310 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
311 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
312 (substring_both, Fdelete, internal_equal, Ffillarray)
313 (Fclear_string, mapcar1)
314 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
315 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
316 (larger_vector, make_hash_table, maybe_resize_hash_table)
317 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
318 (Fmaphash, secure_hash):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (concat): Check for string index and length overflow.
321 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
322 (Frequire):
323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
324 (larger_vector): New API (vec, incr_min, size_max) replaces old
325 one (vec, new_size, init). This catches size overflow.
326 INIT was removed because it was always Qnil.
327 All callers changed.
328 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
329 the upper bound on a hash table index size.
330 (make_hash_table, maybe_resize_hash_table): Use it.
331 (secure_hash): Computer start_byte and end_byte only after
332 they're known to be in ptrdiff_t range.
333 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
334 (Ffont_get_glyphs, Ffont_at):
335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
336 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
337 (Flist_fonts, Fopen_font):
338 Don't assume fixnum can fit in int.
339 (check_gstring): Don't assume index can fit in int.
340 (font_match_p): Check that fixnum is a character, not a nonnegative
341 fixnum, since the later code needs to stuff it into an int.
342 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
343 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
344 conversion overflow issues.
345 (Fopen_font): Check for integer out of range.
346 (Ffont_get_glyphs): Don't assume index can fit in int.
347 * font.h: Adjust decls to match defn changes elsewhere.
348 * fontset.c (reorder_font_vector): Redo score calculation to avoid
349 integer overflow.
350 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
351 printmax_t, where ptrdiff_t is wide enough.
352 (Finternal_char_font):
353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
354 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
355 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
356 (Fset_frame_position, x_set_frame_parameters)
357 (x_set_line_spacing, x_set_border_width)
358 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
359 Check that fixnums are in proper range for system types.
360 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
363 Use SAFE_ALLOCA_LISP, not alloca.
364 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
365 intptr_t is wide enough.
366 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
367 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
368 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
369 Check for fixnum out of range.
370 * ftfont.c (ftfont_list): Don't assume index fits in int.
371 Check that fixnums are in proper range for system types.
372 (ftfont_shape_by_flt):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
377 Check that fixnums are in proper range for system types.
378 * gnutls.h: Adjust decls to match defn changes elsewhere.
379 * gtkutil.c (xg_dialog_run):
380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
381 (update_frame_tool_bar):
382 Check that fixnums are in proper range for system types.
383 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 384 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
385 * indent.c (last_known_column, last_known_column_point):
386 (current_column_bol_cache):
387 (skip_invisible, current_column, check_display_width):
388 (check_display_width, scan_for_column, current_column_1)
389 (Findent_to, Fcurrent_indentation, position_indentation)
390 (indented_beyond_p, Fmove_to_column, compute_motion):
391 (Fcompute_motion, Fvertical_motion):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (last_known_column_modified): Use EMACS_INT, not int.
394 (check_display_width):
395 (Fcompute_motion):
396 Check that fixnums and floats are in proper range for system types.
397 (compute_motion): Don't assume index or fixnum fits in int.
398 (compute_motion, Fcompute_motion):
399 Use int, not EMACS_INT, when it is wide enough.
400 (vmotion): Omit local var start_hpos that is always 0; that way
401 we don't need to worry about overflow in expressions involving it.
402 * indent.h: Adjust decls to match defn changes elsewhere.
403 (struct position):
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 Use int, not EMACS_INT, where int is wide enough.
406 Remove unused members ovstring_chars_done and tab_offset;
407 all uses removed.
408 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
409 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
410 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
411 (make_gap, copy_text, insert, insert_and_inherit)
412 (insert_before_markers, insert_before_markers_and_inherit)
413 (insert_1, count_combining_before, count_combining_after)
414 (insert_1_both, insert_from_string)
415 (insert_from_string_before_markers, insert_from_string_1)
416 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
417 (adjust_after_replace, adjust_after_insert, replace_range)
418 (replace_range_2, del_range, del_range_1, del_range_byte)
419 (del_range_both, del_range_2, modify_region)
420 (prepare_to_modify_buffer, signal_before_change)
421 (signal_after_change, Fcombine_after_change_execute):
422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
423 * intervals.c (traverse_intervals, rotate_right, rotate_left)
424 (balance_an_interval, split_interval_right, split_interval_left)
425 (find_interval, next_interval, update_interval)
426 (adjust_intervals_for_insertion, delete_node, delete_interval)
427 (interval_deletion_adjustment, adjust_intervals_for_deletion)
428 (static_offset_intervals, offset_intervals)
429 (merge_interval_right, merge_interval_left, make_new_interval)
430 (graft_intervals_into_buffer, temp_set_point_both)
431 (temp_set_point, set_point, adjust_for_invis_intang)
432 (set_point_both, move_if_not_intangible, get_property_and_range)
433 (get_local_map, copy_intervals, copy_intervals_to_string)
434 (compare_string_intervals, set_intervals_multibyte_1):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * intervals.h: Adjust decls to match defn changes elsewhere.
437 (struct interval):
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 * keyboard.c (this_command_key_count, this_single_command_key_start)
440 (before_command_key_count, before_command_echo_length, echo_now)
441 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
442 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
443 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
444 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (last_non_minibuf_size, last_point_position, echo_truncate)
447 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
448 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
449 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
450 (stuff_buffered_input):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (last_auto_save, command_loop_1, read_char):
453 Use EMACS_INT, not int, to avoid integer overflow.
454 (record_char): Avoid overflow in total_keys computation.
455 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
456 * keyboard.h: Adjust decls to match defn changes elsewhere.
457 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
458 (Fkey_description, Fdescribe_vector, Flookup_key):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (click_position): New function, to check that positions are in range.
461 (Fcurrent_active_maps):
462 (describe_command):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (Faccessible_keymaps, Fkey_description):
465 (preferred_sequence_p):
466 Don't assume fixnum can fit into int.
467 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
468 Check for integer overflow in size calculations.
469 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
470 avoid mishandling large integers.
471 * lisp.h: Adjust decls to match defn changes elsewhere.
472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
473 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
474 (struct Lisp_Marker):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
477 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
478 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
479 All callers changed.
480 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
481 Assume the arg has valid form, since it always does.
482 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
483 unsigned integer system type.
484 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
485 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
487 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
488 (duration_to_sec_usec): New decl.
489 * lread.c (read_from_string_index, read_from_string_index_byte)
490 (read_from_string_limit, readchar, unreadchar, openp)
491 (read_internal_start, read1, oblookup):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 (Fload, readevalloop, Feval_buffer, Feval_region):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (openp): Check for out-of-range argument to 'access'.
496 (read1): Use int, not EMACS_INT, where int is wide enough.
497 Don't assume fixnum fits into int.
1ab7b8ac
PE
498 (read_filtered_event): Use duration_to_sec_usec
499 to do proper overflow checking on durations.
d311d28c
PE
500 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
501 in size calculation.
502 (Fexecute_kbd_macro):
503 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
504 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
505 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
506 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
507 (set_marker_both, set_marker_restricted_both, marker_position)
508 (marker_byte_position, Fbuffer_has_markers_at):
509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
510 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
511 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
512 It now merely ensures that the menu is large enough, without
513 necessarily growing it, as this avoids some integer overflow issues.
514 All callers changed.
515 (keymap_panes, parse_single_submenu, Fx_popup_menu):
516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
517 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
518 Use SAFE_ALLOCA_LISP, not alloca.
519 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
520 to EMACS_INT. Check that fixnums are in proper range for system types.
521 * minibuf.c (minibuf_prompt_width, string_to_object)
522 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
523 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
525 (get_minibuffer, read_minibuf_unwind):
526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
527 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
528 this simplifies overflow checking. All callers changed.
529 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
530 (Ftest_completion):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
533 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
534 Check that fixnums are in proper range for system types.
535 (Fx_create_frame, Fx_show_tip):
536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
537 * nsfont.m (ns_findfonts, nsfont_list_family):
538 Don't assume fixnum fits in long.
539 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
541 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
542 wide enough.
17fdb222 543 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
545 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
546 (PRINTDECLARE, PRINTPREPARE):
547 (strout, print_string):
548 (print, print_preprocess, print_check_string_charset_prop)
549 (print_object):
550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
551 (PRINTDECLARE):
552 (temp_output_buffer_setup, Fprin1_to_string, print_object):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
555 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
556 (printchar, strout): Use xpalloc to catch size calculation overflow.
557 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
558 to avoid mishandling large integers.
559 (print_error_message): Use SAFE_ALLOCA, not alloca.
560 (print_object): Use int, not EMACS_INT, where int is wide enough.
561 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
562 (Fset_process_window_size, Fformat_network_address)
563 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
564 (Fsignal_process, sigchld_handler):
565 Check that fixnums are in proper range for system types.
566 (Fformat_network_address, read_process_output, send_process)
567 (Fprocess_send_region, status_notify):
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
569 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
570 (wait_reading_process_output, read_process_output, exec_sentinel):
571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
572 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
573 (Faccept_process_output): Use duration_to_sec_usec to do proper
574 overflow checking on durations.
b62b53e8
PE
575 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
576 configured --with-wide-int.
d311d28c
PE
577 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
578 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
579 * search.c (looking_at_1, string_match_1):
580 (fast_string_match, fast_c_string_match_ignore_case)
581 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
582 (scan_newline, find_before_next_newline, search_command)
583 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
584 (set_search_regs, wordify):
585 (Freplace_match):
586 (Fmatch_data):
587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
588 (string_match_1, search_buffer, set_search_regs):
589 (Fmatch_data):
590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
591 (wordify): Check for overflow in size calculation.
592 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
593 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
594 Check that fixnums are in proper range for system types.
595 * sound.c (struct sound_device)
596 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
598 (Fplay_sound_internal):
599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
600 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
601 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
602 for the respective integer ranges. This fixes a bug with
603 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
604 (struct lisp_parse_state, find_start_modiff)
605 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
606 (Fparse_partial_sexp):
607 Don't assume fixnums can fit in int.
608 (struct lisp_parse_state, find_start_pos, find_start_value)
609 (find_start_value_byte, find_start_begv)
610 (update_syntax_table, char_quoted, dec_bytepos)
611 (find_defun_start, prev_char_comend_first, back_comment):
612 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
613 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (Finternal_describe_syntax_value): Check that match_lisp is a
616 character, not an integer, since the code stuffs it into int.
617 (scan_words, scan_sexps_forward):
618 Check that fixnums are in proper range for system types.
619 (Fforward_word):
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 (scan_sexps_forward):
622 Use CHARACTERP, not INTEGERP, since the value must fit into int.
623 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
624 * syntax.h: Adjust decls to match defn changes elsewhere.
625 (struct gl_state_s):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 * sysdep.c (wait_for_termination_1, wait_for_termination)
628 (interruptible_wait_for_termination, mkdir):
629 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
630 (emacs_read, emacs_write):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (system_process_attributes): Don't assume uid_t, gid_t, and
633 double all fit in int or even EMACS_INT.
634 * term.c (set_tty_color_mode):
635 Check that fixnums are in proper range for system types.
636 * termhooks.h (struct input_event):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 * textprop.c (validate_interval_range, interval_of)
639 (Fadd_text_properties, set_text_properties_1)
640 (Fremove_text_properties, Fremove_list_of_text_properties)
641 (Ftext_property_any, Ftext_property_not_all)
642 (copy_text_properties, text_property_list, extend_property_ranges)
643 (verify_interval_modification):
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 (Fnext_single_char_property_change)
646 (Fprevious_single_char_property_change):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
648 (copy_text_properties):
649 Check for integer overflow in index calculation.
d311d28c
PE
650 * undo.c (last_boundary_position, record_point, record_insert)
651 (record_delete, record_marker_adjustment, record_change)
652 (record_property_change):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
654 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
657 (Fx_hide_tip, Fx_file_dialog):
658 * w32menu.c (set_frame_menubar):
659 Use ptrdiff_t, not int, for consistency with rest of code.
660 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
661 (select_window, Fdelete_other_windows_internal)
662 (window_scroll_pixel_based, window_scroll_line_based)
663 (Frecenter, Fset_window_configuration):
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (Fset_window_hscroll, run_window_configuration_change_hook)
666 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 667 (Fscroll_other_window, Frecenter):
d311d28c
PE
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
670 Don't assume fixnum fits in int.
671 (Fset_window_scroll_bars):
672 Check that fixnums are in proper range for system types.
673 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
674 (string_pos, c_string_pos, number_of_chars, init_iterator)
675 (in_ellipses_for_invisible_text_p, init_from_display_pos)
676 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
677 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
678 (face_before_or_after_it_pos, handle_invisible_prop)
679 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
680 (display_prop_intangible_p, string_buffer_position_lim)
681 (string_buffer_position, handle_composition_prop, load_overlay_strings)
682 (get_overlay_strings_1, get_overlay_strings)
683 (iterate_out_of_display_property, forward_to_next_line_start)
684 (back_to_previous_visible_line_start, reseat, reseat_to_string)
685 (get_next_display_element, set_iterator_to_next)
686 (get_visually_first_element, compute_stop_pos_backwards)
687 (handle_stop_backwards, next_element_from_buffer)
688 (move_it_in_display_line_to, move_it_in_display_line)
689 (move_it_to, move_it_vertically_backward, move_it_by_lines)
690 (add_to_log, message_dolog, message_log_check_duplicate)
691 (message2, message2_nolog, message3, message3_nolog
692 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
693 (current_message_1, truncate_echo_area, truncate_message_1)
694 (set_message, set_message_1, store_mode_line_noprop)
695 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
696 (text_outside_line_unchanged_p, check_point_in_composition)
697 (reconsider_clip_changes)
698 (redisplay_internal, set_cursor_from_row, try_scrolling)
699 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
700 (redisplay_window, find_last_unchanged_at_beg_row)
701 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
702 (trailing_whitespace_p, find_row_edges, display_line)
703 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
704 (display_mode_element, store_mode_line_string)
705 (pint2str, pint2hrstr, decode_mode_spec)
706 (display_count_lines, display_string, draw_glyphs)
707 (x_produce_glyphs, x_insert_glyphs)
708 (rows_from_pos_range, mouse_face_from_buffer_pos)
709 (fast_find_string_pos, mouse_face_from_string_pos)
710 (note_mode_line_or_margin_highlight, note_mouse_highlight):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (safe_call, init_from_display_pos, handle_fontified_prop)
713 (handle_single_display_spec, load_overlay_strings)
714 (with_echo_area_buffer, setup_echo_area_for_printing)
715 (display_echo_area, echo_area_display)
716 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
717 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
718 (redisplay_window, dump_glyph_row, display_mode_line)
719 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 720 (handle_display_spec, display_prop_string_p):
d311d28c
PE
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (handle_single_display_spec, build_desired_tool_bar_string)
723 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
724 (get_specified_cursor_type):
725 Check that fixnums are in proper range for system types.
726 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
727 (Flookup_image_map):
728 Don't assume fixnums fit in int.
729 (compare_overlay_entries):
730 Avoid mishandling comparisons due to subtraction overflow.
731 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
732 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
733 (handle_tool_bar_click):
734 Use int, not unsigned, since we prefer signed and the signedness
735 doesn't matter here.
736 (get_next_display_element, next_element_from_display_vector):
737 Use int, not EMACS_INT, when int is wide enough.
738 (start_hourglass): Use duration_to_sec_usec to do proper
739 overflow checking on durations.
740 * xfaces.c (Fbitmap_spec_p):
741 Check that fixnums are in proper range for system types.
742 (compare_fonts_by_sort_order):
743 Avoid mishandling comparisons due to subtraction overflow.
744 (Fx_family_fonts, realize_basic_faces):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (Fx_family_fonts):
747 Don't assume fixnum fits in int.
748 Use SAFE_ALLOCA_LISP, not alloca.
749 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
750 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
751 (face_at_buffer_position, face_for_overlay_string)
752 (face_at_string_position):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
755 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
756 (Fx_show_tip):
757 Check that fixnums are in proper range for system types.
758 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
759 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Fx_change_window_property): Don't assume fixnums fit in int.
762 * xfont.c (xfont_chars_supported):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
765 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 * xml.c (parse_region):
768 * xrdb.c (magic_file_p):
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
771 (x_get_local_selection, x_reply_selection_request)
772 (x_handle_selection_request, wait_for_property_change):
773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
774 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
775 short is wide enough.
776 (x_send_client_event): Don't assume fixnum fits in int.
777 * xterm.c (x_x_to_emacs_modifiers):
778 Don't assume EMACS_INT overflows nicely into int.
779 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
780 may come from Lisp.
781 (handle_one_xevent): NATNUMP can eval its arg twice.
782 (x_connection_closed):
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 * xterm.h: Adjust decls to match defn changes elsewhere.
785 (struct scroll_bar): Use struct vectorlike_header
786 rather than rolling our own approximation.
787 (SCROLL_BAR_VEC_SIZE): Remove; not used.
788
df1bbe5b
SM
7892011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
790
791 * keyboard.c (read_key_sequence_remapped): New var.
792 (read_key_sequence): Compute remapping in the right buffer.
793 (command_loop_1): Use read_key_sequence's remapping directly.
794
51553db6
SM
7952011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
796
32c1fffd
SM
797 * dired.c (file_name_completion): Don't expand file name.
798 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
799 before checking file name handler.
800
51553db6
SM
801 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
802 they've been requested explicitly (bug#9591).
803
b6bd1599 8042011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
805
806 * keymap.c (Fsingle_key_description): Use make_specified_string
807 instead of build_string to build string from push_key_description.
808 (Bug#5193)
809
f701dc2a
PE
8102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
811
4222c55d
PE
812 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
813 This fixes a Y2038 bug on 64-bit hosts.
814 * buffer.c (reset_buffer):
815 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
816 (Fclear_buffer_auto_save_failure):
817 Use 0, not -1, to represent an unset failure time, since time_t
818 might not be signed.
819
f701dc2a
PE
820 Remove dependency on glibc malloc internals.
821 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
822 Move back here from lisp.h, but with their new implementations.
823 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
824 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
825 * charset.c (charset_table_init): New static var.
826 (syms_of_charset): Use it instead of xmalloc. This removes a
827 dependency on glibc malloc internals. See Eli Zaretskii's comment in
828 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
829 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
830 Move back to alloc.c.
831 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
832 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
833
9ceebf39
JD
8342011-09-30 Jan Djärv <jan.h.d@swipnet.se>
835
836 * nsterm.m (windowDidResize): Call x_set_window_size only when
837 ns_in_resize is true. Otherwise set pixelwidth/height and
838 call change_frame_size (Bug#9628).
839
cb993c58
PE
8402011-09-30 Paul Eggert <eggert@cs.ucla.edu>
841
3930c88b
PE
842 Port --enable-checking=all to Fedora 14 x86-64.
843 * charset.c (syms_of_charset): Also account for glibc malloc's
844 internal overhead when calculating the initial malloc maximum.
845
cb993c58
PE
846 Port --enable-checking=all to Fedora 14 x86.
847 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
848 Move to lisp.h.
849 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
850 (overrun_check_realloc, overrun_check_free):
851 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
852 That way, xmalloc returns a properly-aligned pointer even if
853 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
854 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
855 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
856 into account when calculating the initial malloc maximum.
857 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
858 Move here from alloc.c, so that charset.c can use it too.
859 Properly align; the old code wasn't right for common 32-bit hosts
860 when configured with --enable-checking=all.
861 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
862 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
863
31bed486
EZ
8642011-09-29 Eli Zaretskii <eliz@gnu.org>
865
04c70788 866 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
867 use EDOM.
868
fbcaa2f3
EZ
8692011-09-28 Eli Zaretskii <eliz@gnu.org>
870
871 * xdisp.c (compute_display_string_end): If there's no display
872 string at CHARPOS, return -1.
873
874 * bidi.c (bidi_fetch_char): When compute_display_string_end
875 returns a negative value, treat the character as a normal
876 character not covered by a display string. (Bug#9624)
877
a239d4e9
JB
8782011-09-28 Juanma Barranquero <lekktu@gmail.com>
879
880 * lread.c (Fread_from_string): Fix typo in docstring.
881
88652fd5
EZ
8822011-09-27 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (handle_invisible_prop): If invisible text ends on a
885 newline, reseat the iterator instead of bidi-iterating there one
886 character at a time. (Bug#9610)
32c1fffd
SM
887 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
888 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 889
ed497dd4
AS
8902011-09-27 Andreas Schwab <schwab@linux-m68k.org>
891
892 * lread.c (readevalloop): Use correct code for NBSP.
893 (read1): Likewise. (Bug#9608)
894
b2bf61aa
MA
8952011-09-25 Michael Albinus <michael.albinus@gmx.de>
896
897 * dbusbind.c (Fdbus_register_signal): When service is not
898 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
899
32bbb17c
GM
9002011-09-25 Glenn Morris <rgm@gnu.org>
901
902 * buffer.c (truncate-lines): Doc fix.
903
94e0933e
CY
9042011-09-24 Chong Yidong <cyd@stupidchicken.com>
905
906 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
907 (Fset_window_next_buffers): Doc fix.
908
cddde921
GM
9092011-09-24 Glenn Morris <rgm@gnu.org>
910
911 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
912
1260aef1
PE
9132011-09-24 Paul Eggert <eggert@cs.ucla.edu>
914
25b4bfa0
PE
915 Fix minor problems found by static checking.
916 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
917 * indent.c (Fvertical_motion): Fix == vs = typo.
918
e3cbd34b
EZ
9192011-09-24 Eli Zaretskii <eliz@gnu.org>
920
6bf7006f
EZ
921 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
922 value is now t. Doc fix.
923
e3cbd34b 924 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 925 logic when moving up, not only when moving down. Fix the
e3cbd34b 926 confusing name and values of the it_overshoot_expected variable;
32c1fffd 927 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
928
929 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
930 CHARPOS is covered by a display string which includes newlines.
931 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
932 is covered by a display string with embedded newlines.
933
a3de0cbd
MA
9342011-09-24 Michael Albinus <michael.albinus@gmx.de>
935
936 * dbusbind.c (Fdbus_register_signal): Add match rule to
937 Vdbus_registered_objects_table. (Bug#9581)
938 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
939 docstring.
940
b260039d
JM
9412011-09-24 Jim Meyering <meyering@redhat.com>
942
32c1fffd 943 do not ignore write error for any output size
b260039d
JM
944 The previous change was incomplete.
945 While it makes emacs --batch detect the vast majority of stdout
946 write failures, errors were still ignored whenever the output size is
947 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
948 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
949 && echo FAIL: ignored write error
950 FAIL: ignored write error
951 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
952 && echo FAIL: ignored write error
953 FAIL: ignored write error
954 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
955
8eca8a7c
AS
9562011-09-23 Andreas Schwab <schwab@linux-m68k.org>
957
958 * emacs.c (Fkill_emacs): In noninteractive mode exit
959 non-successfully if a write error occurred on stdout. (Bug#9574)
960
3341db62
EZ
9612011-09-21 Eli Zaretskii <eliz@gnu.org>
962
963 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
964 the xassert test.
965
966 * dispextern.h (struct it): Update the comment documenting what
967 can it->OBJECT be.
968
8c203dbf
EZ
9692011-09-20 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
972 a display string, extend search for cursor position to end of row.
973 (find_row_edges): If the row ends in a newline from a display
974 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
975 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
976 (Fcurrent_bidi_paragraph_direction): Fix search for previous
977 non-empty line. Fixes confusing cursor motion with arrow keys at
978 the beginning of a line that starts with whitespace.
8c203dbf 979
a4824228
LMI
9802011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
981
982 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
983 (bug#9493).
984
33ed493b
CY
9852011-09-18 Chong Yidong <cyd@stupidchicken.com>
986
987 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
988 boolean (Bug#9154).
989
56cd55c8
EZ
9902011-09-18 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (display_line): Record maximum and minimum buffer
993 positions even if no glyphs were produced (e.g., by a zero-width
994 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
995 buffer positions that will be removed from the glyph row because
996 they don't fit.
c02dcedf
EZ
997 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
998 column is beyond frame width: don't subtract 1 "pixel" when
999 computing width of the stretch.
3e62b7e0
EZ
1000 (reseat_at_next_visible_line_start): Undo the change made on
1001 2011-09-17 that saved paragraph information and restored it after
1002 the call to `reseat'. (Bug#9545)
56cd55c8 1003
5ed99d36 10042011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1005
1006 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1007 and turn window cursor on if cleared (Bug#9415).
1008
5ed99d36 10092011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1010
1011 * search.c (boyer_moore): Take unibyte characters from pattern
1012 literally. (Bug#9458)
1013
9bade7b2
EZ
10142011-09-18 Eli Zaretskii <eliz@gnu.org>
1015
1016 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1017
e5e9d610
PE
10182011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1019
87e4427a
PE
1020 Fix minor problem found by static checking.
1021 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1022 initialized, to pacify gcc -Wuninitialized.
1023
e5e9d610
PE
1024 * fileio.c: Report proper errno when syscall falls.
1025 (Finsert_file_contents): Save and restore errno,
1026 so that report_file_error outputs the correct diagnostic.
1027 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1028
a1674f0b
EZ
10292011-09-18 Eli Zaretskii <eliz@gnu.org>
1030
1031 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1032
fbfb6dd4
EZ
10332011-09-17 Eli Zaretskii <eliz@gnu.org>
1034
1035 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1036 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1037
bb187662
EZ
10382011-09-17 Eli Zaretskii <eliz@gnu.org>
1039
1137e8b8
EZ
1040 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1041 about the current paragraph and restore it after the call to
1042 reseat.
1043
1044 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1045 (bidi_find_paragraph_start): Search back for paragraph beginning
1046 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1047 (bidi_move_to_visually_next): Only trigger paragraph-related
1048 computations when the last character is a newline or at EOB, not
1049 just any NEUTRAL_B. (Bug#9470)
1050
bb187662
EZ
1051 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1052 truncated lines if point is covered by a display string. (Bug#9524)
1053
2e621251
PE
10542011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1057 (cons_to_x_long): New function.
1058 (lisp_data_to_selection_data): Use it. Correct the test for
1059 short-versus-long data; it was negated. Break out of vector
1060 loop, for efficiency, when a long datum is discovered.
1061
91a15bc6
SM
10622011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1063
1064 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1065
b41c3a35
EZ
10662011-09-16 Eli Zaretskii <eliz@gnu.org>
1067
1068 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1069 GCC PR/17406) by declaring this function with external scope.
1070
7812ba2d
PE
10712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1074 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1075
cf7edc2a
AS
10762011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1077
1078 * editfns.c (Fformat): Correctly handle text properties on "%%".
1079
bd01620e
EZ
10802011-09-15 Eli Zaretskii <eliz@gnu.org>
1081
1082 * xterm.c (x_draw_composite_glyph_string_foreground):
1083 * w32term.c (x_draw_composite_glyph_string_foreground):
1084 * term.c (encode_terminal_code):
1085 * composite.c (composition_update_it, get_composition_id):
1086 * xdisp.c (get_next_display_element)
1087 (fill_composite_glyph_string): Add comments about special meaning
1088 of TAB characters in a composition.
1089
a02719a3
PE
10902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1091
1092 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1093 This occurs when processing a multibyte format.
1094 Problem reported by Wolfgang Jenker.
a02719a3 1095
72589a3c
JB
10962011-09-15 Johan Bockgård <bojohan@gnu.org>
1097
1098 * xdisp.c (try_cursor_movement): Only check for exact match if
1099 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1100
1c14176c
PE
11012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1102
1103 Remove unused external symbols.
1104 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1105 * xdisp.c (calc_pixel_width_or_height): Now static.
1106 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1107 * indent.c (check_display_width):
1108 * w32term.c: Fix comment to match code.
1109 * xterm.c, xterm.h (x_catching_errors): Remove.
1110
d2eea5b5
PE
11112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1112
1113 * xselect.c: Use signed conversions more consistently (Bug#9498).
1114 (selection_data_to_lisp_data): Assume incoming selection data are
1115 signed integers, not unsigned. This is to be consistent with
1116 outgoing selection data, which was modified to use signed integers
1117 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1118 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1119 expects long, not unsigned long.
1120
46888499
EZ
11212011-09-14 Eli Zaretskii <eliz@gnu.org>
1122
1123 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1124 computation of loop end. Reported by Johan Bockgård
1125 <bojohan@gnu.org>.
1126
ef8ef9fb
CY
11272011-09-13 Chong Yidong <cyd@stupidchicken.com>
1128
1129 * frame.c (Fother_visible_frames_p): Function deleted.
1130
fa819fed
EZ
11312011-09-12 Eli Zaretskii <eliz@gnu.org>
1132
1133 * indent.c (compute_motion): Process display vector front to back
1134 rather than the other way around. (Bug#2496)
1135
2ba8e008
SM
11362011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1137
1138 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1139
20f53c69
CY
11402011-09-11 Chong Yidong <cyd@stupidchicken.com>
1141
1142 * minibuf.c (Fread_from_minibuffer): Doc fix.
1143
d562d7a4
EZ
11442011-09-11 Eli Zaretskii <eliz@gnu.org>
1145
1146 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1147 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1148
1c4d7f3d
LMI
11492011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1150
1151 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1152 value for non-existent files.
1153
b885bf36
EZ
11542011-09-11 Eli Zaretskii <eliz@gnu.org>
1155
1156 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1157 set its "size" to -1. This will set the modtime_size field of
1158 the corresponding buffer to -1, which is what
1159 verify-visited-file-modtime expects for files that do not exist.
1160 (Bug#9139)
1161
6612f0bf
PE
11622011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1165 here ...
1166 * lisp.h: ... from here. push_key_description is no longer
1167 defined in keyboard.c, so its declaration should not be in
1168 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1169 logically belongs with push_key_description.
1170
dfb3f755
PE
11712011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 * buffer.h: Include <sys/types.h> instead of <time.h>.
1174 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1175 Problem reported by Herbert J. Skuhra.
1176
3134906c
LMI
11772011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1178
1179 * xml.c (parse_region): Make the parsing work for
1180 non-comment-starting XML files again (bug#9144).
1181
8d903f4e
AS
11822011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1183
1184 * image.c (gif_load): Fix calculation of bottom and right corner.
1185 (Bug#9468)
1186
80ad64f4
EZ
11872011-09-10 Eli Zaretskii <eliz@gnu.org>
1188
1189 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1190 redisplay in small windows.
1191
208a048d
EZ
11922011-09-09 Eli Zaretskii <eliz@gnu.org>
1193
1194 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1195
9b1c252e
MR
11962011-09-08 Martin Rudalics <rudalics@gmx.at>
1197
1198 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1199 Operate on live windows only.
1200
2949f33b
JB
12012011-09-08 Juanma Barranquero <lekktu@gmail.com>
1202
1203 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1204
e08dcafd
EZ
12052011-09-07 Eli Zaretskii <eliz@gnu.org>
1206
1207 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1208 only under bidi iteration.
1209
115b96bd
JD
12102011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1211
1212 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1213
c8199d0f
PE
12142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1217 Without this fix, the command to link temacs failed due to an
1218 undefined symbol __builtin_isnan. This is because
1219 /usr/include/iso/math_c99.h #defines isnan(x) to
1220 __builtin_isnan(x), but the bundled gcc, which identifies itself
1221 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1222 a __builtin_isnan.
1223 * floatfns.c (isnan): #undef, and then #define to a clone of
1224 what's in data.c.
1225 (Fisnan): Always define, since it's always available now.
1226 (syms_of_floatfns): Always define isnan at the Lisp level.
1227
e39b275c 12282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1229
1230 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1231
b2db44d9 12322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1233
f4af5137 1234 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1235 The previous code assumed that file offsets (off_t values) fit in
1236 EMACS_INT variables, which is not true on typical 32-bit hosts.
1237 The code messed up by falsely reporting buffer overflow in cases
1238 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1239 when "big" contains more than 2**29 bytes, even though this
1240 inserts just one byte and does not overflow the buffer.
1241 (Finsert_file_contents): Store file offsets as off_t
1242 values, not as EMACS_INT values. Check for overflow when
1243 converting between EMACS_INT and off_t. When checking for
1244 buffer overflow or for overlap, take the offsets into account.
1245 Don't use EMACS_INT for small values where int suffices.
1246 When checking for overlap, fix a typo: ZV was used where
1247 ZV_BYTE was intended.
1248 (Fwrite_region): Don't assume off_t fits into 'long'.
1249 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1250
ecfc0a49
MA
12512011-09-05 Michael Albinus <michael.albinus@gmx.de>
1252
1253 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1254
6511acf2 12552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1256
0999621a 1257 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1258
1259 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1260 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1261 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1262 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1263 (modify_event_symbol): Do not assume that the length of
1264 name_alist_or_stem is safe to alloca and fits in int.
1265 (Fexecute_extended_command): Likewise for function name and binding.
1266 (Frecursion_depth): Wrap around reliably on integer overflow.
1267 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1268 since some callers pass EMACS_INT values.
1269 (Fsingle_key_description): Don't crash if symbol name contains more
1270 than MAX_ALLOCA bytes.
1271 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1272 (get_minibuffer): Arg is now EMACS_INT, not int.
1273 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1274 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1275 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1276
2be7d702
PE
1277 * dbusbind.c (signature_cat): New function.
1278 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1279 Do not overrun buffer; instead, report string overflow.
1280
9d1df220
PE
1281 * dispnew.c (add_window_display_history): Don't overrun buffer.
1282 Truncate instead; this is OK since it's just a log.
1283
33ef5c64
PE
1284 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1285 even if the time zone offset is outlandishly large.
1286 Don't mishandle offset == INT_MIN.
1287
66c6fdd5
PE
1288 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1289 when creating daemon; the previous buffer-overflow check was incorrect.
1290
d749b01b
PE
1291 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1292 which has the guts of the old verror function.
1293
b5cd1905
PE
1294 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1295 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1296
6e1a67fb
PE
1297 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1298 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1299 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1300 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1301 length of string rather than counting it via multiple sprintfs;
1302 that's simpler and more reliable.
c21721cc
PE
1303 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1304 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1305 sprintf, in case result does not fit in int.
1306
c57b67fc
PE
1307 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1308 (fontset_from_font): Print it.
1309
8a401434
PE
1310 * frame.c (tty_frame_count): Now printmax_t, not int.
1311 (make_terminal_frame, set_term_frame_name): Print it.
1312 (x_report_frame_params): In X, window IDs are unsigned long,
1313 not signed long, so print them as unsigned.
1314 (validate_x_resource_name): Check for implausibly long names,
1315 and don't assume name length fits in 'int'.
1316 (x_get_resource_string): Don't blindly alloca invocation name;
1317 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1318 not fit in int.
1319
6e1a67fb
PE
1320 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1321 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1322 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1323
0df02bf3
PE
1324 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1325 Use esprintf, not sprintf, in case result does not fit in int.
1326
48e30793
PE
1327 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1328 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1329 it as a large positive number.
1330 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1331 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1332
a66ff6d8
PE
1333 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1334 in case result does not fit in int.
1335
aca216ff
PE
1336 * print.c (float_to_string): Detect width overflow more reliably.
1337 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1338 buffer overrun. Don't assume list length fits in 'int'. Treat
1339 print length of 0 as 0, not as infinity; to be consistent with other
1340 uses of print length in this function. Don't overflow print length
1341 index. Don't assume hash table size fits in 'long', or that
1342 vectorlike size fits in 'unsigned long'.
1343
31c286f7
PE
1344 * process.c (make_process): Use printmax_t, not int, to format
1345 process-name gensyms.
1346
55e5faa1
PE
1347 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1348
80f2e268
PE
1349 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1350 to avoid potential buffer overrun.
1351
670741ab
PE
1352 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1353 if X resource line is longer than 512 bytes.
1354
b7163a50
PE
1355 * xfns.c (x_window): Make sprintf buffer a bit bigger
1356 to avoid potential buffer overrun.
1357
ae58ff1f
PE
1358 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1359
c43c8a6a
PE
1360 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1361
3f8236f4
PE
13622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1363
53e9fe90 1364 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1365 Without these, Emacs silently mishandles large integers sometimes.
1366 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1367 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1368
6511acf2
PE
1369 * xdisp.c (try_window_id): Check Emacs fixnum range before
1370 converting to 'int'.
806add1d 1371
6511acf2 1372 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1373 Check that an Emacs fixnum is in range before assigning it to 'int'.
1374 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1375 values converted from Emacs fixnums.
1376 (Frecenter): Don't wrap around a line count if it is out of 'int'
1377 range; instead, treat it as an extreme value.
1378 (Fset_window_configuration, compare_window_configurations):
1379 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1380
6511acf2
PE
1381 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1382 that can exceed INT_MAX. Check that EMACS_INT value is in range
1383 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1384 (match_limit): Don't assume that a fixnum can fit in 'int'.
1385
6511acf2 1386 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1387 exceed INT_MAX.
1388
6511acf2 1389 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1390 (Fvertical_motion): Don't wrap around LINES values that don't fit
1391 in 'int'. Instead, treat them as extreme values. This is good
1392 enough for windows, which can't have more than INT_MAX lines anyway.
1393
fcb901a7
LMI
13942011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1395
0f2f6b6d
LMI
1396 * Require libxml/parser.h to avoid compilation warning.
1397
fcb901a7
LMI
1398 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1399
1400 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1401 since this reportedly can destroy thread storage.
1402
6e20a0d4
CY
14032011-08-30 Chong Yidong <cyd@stupidchicken.com>
1404
1405 * syntax.c (find_defun_start): Update all cache variables if
1406 exiting early (Bug#9401).
1407
148ae00e
EZ
14082011-08-30 Eli Zaretskii <eliz@gnu.org>
1409
f6cfbd8f
EZ
1410 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1411
148ae00e
EZ
1412 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1413 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1414 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1415
1416 * term.c (tty_append_glyph): New function.
1417 (produce_stretch_glyph): Static function and its prototype deleted.
1418
1419 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
1420 prototypes.
1421
c4a07a4c
PE
14222011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1425 when checking :margin (Bug#9390).
1426 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1427 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1428 so that the name doesn't mislead. All uses changed.
1429
6bc8cd65
JB
14302011-08-28 Johan Bockgård <bojohan@gnu.org>
1431
1432 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1433 set_tty_hooks.
1434
dca4927e
EZ
14352011-08-27 Eli Zaretskii <eliz@gnu.org>
1436
1437 * xdisp.c (move_it_to): Don't bail out early when reaching
1438 position beyond to_charpos, if we are scanning backwards.
1439 (move_it_vertically_backward): When DY == 0, make sure we get to
1440 the first character in the line after the newline.
1441
f2cad773
PE
14422011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1443
1444 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1445 (ccl_driver): Do not generate an out-of-range pointer.
1446 (Fccl_execute_on_string): Remove unnecessary check for
1447 integer overflow, noted by Stefan Monnier in
1448 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1449 Remove a FIXME that didn't need fixing.
1450 Simplify the newly-introduced buffer reallocation code.
1451
0cae2cdb
JB
14522011-08-27 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1455
5fc295a4 14562011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1457
70c60eb2 1458 Integer and memory overflow issues (Bug#9196).
726e0ab1 1459
d31850da
PE
1460 * doc.c (get_doc_string): Rework so that
1461 get_doc_string_buffer_size is the actual buffer size, rather than
1462 being 1 less than the actual buffer size; this makes xpalloc more
1463 convenient.
1464
a69fbedb
PE
1465 * image.c (x_allocate_bitmap_record, cache_image):
1466 * xselect.c (Fx_register_dnd_atom):
1467 Simplify previous changes by using xpalloc.
1468
fe5c5d37
PE
1469 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1470 since either will do and ptrdiff_t is convenient with xpalloc.
1471
0065d054
PE
1472 * charset.c (charset_table_size)
1473 (struct charset_sort_data.priority): Now ptrdiff_t.
1474 (charset_compare): Don't overflow if priorities differ greatly.
1475 (Fsort_charsets): Don't assume list length fits in int.
1476 Check for size-calculation overflow when allocating sort data.
1477 (syms_of_charset): Allocate an initial charset table that is
1478 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1479
1480 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1481
1482 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1483 The actual value is always <= INT_MAX, and leaving it unsigned made
1484 overflow checking harder.
1485
1486 * dispextern.h (struct glyph_matrix.rows_allocated)
1487 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1488 with xpalloc. The values are still always <= INT_MAX.
1489
1490 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1491
1492 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1493 (SAFE_NALLOCA): New macro.
1494
1495 * region-cache.c (struct boundary.pos, find_cache_boundary)
1496 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1497 (set_cache_region, invalidate_region_cache)
1498 (revalidate_region_cache, know_region_cache, region_cache_forward)
1499 (region_cache_backward, pp_cache):
1500 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1501 so that ptrdiff_t * can be passed to xpalloc.
1502 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1503 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1504 (pp_cache): Don't assume cache_len fits in int.
1505 * region-cache.h: Adjust extern decls to match.
1506
1507 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1508 EMACS_INT, since either will do, for xpalloc.
1509
1510 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1511 (xnmalloc, xnrealloc, xpalloc): New functions.
1512
726e0ab1
PE
1513 * bidi.c (bidi_shelve_header_size): New constant.
1514 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1515 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1516
51f30bc5 1517 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1518 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1519 (overlay_strings):
1520 Don't update size of array until after memory allocation succeeds,
1521 because xmalloc/xrealloc may not return.
0065d054
PE
1522 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1523 now that we have proper integer overflow checking.
1524 (record_overlay_string, overlay_strings): Catch overflows when
1525 calculating size of overlay_str_buf.
726e0ab1 1526
0065d054
PE
1527 * callproc.c (Fcall_process): Check for size overflow when
1528 calculating size of args2.
1529 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1530 Normally we prefer signed values, but sticking with ptrdiff_t would
1531 require adding more-complicated checks.
726e0ab1
PE
1532
1533 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1534 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1535 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1536 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1537
1538 * character.c (Fstring): Check for size-calculation overflow.
1539
1540 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1541 unnecessary integer overflow. Check for size overflow.
1542 (encode_coding_object): Don't update size until xmalloc succeeds.
1543
1544 * composite.c (get_composition_id): Check for overflow in glyph
1545 length calculations.
1546
1547 Integer and memory overflow fixes for display code.
1548 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1549 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1550 (scrolling_window): Check for overflow in size calculations.
1551 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1552 Don't assume glyph table len fits in int.
1553 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1554 (row_table_size): Now ptrdiff_t, not int.
1555 (scrolling_window): Avoid overflow in size calculations.
1556 Don't update size until allocation succeeds.
1557 * fns.c (concat): Check for overflow in size calculations.
1558 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1559 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1560 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1561
1562 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1563 (get_doc_string): Check for size calculation overflow.
1564 Don't update size until allocation succeeds.
1565 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1566 EMACS_INT, where ptrdiff_t will do.
1567 (Fsubstitute_command_keys): Check for string overflow.
1568
1569 * editfns.c (set_time_zone_rule): Don't assume environment length
1570 fits in int.
1571 (message_length): Now ptrdiff_t, not int.
1572 (Fmessage_box): Don't update size until allocation succeeds.
1573 Don't assume message length fits in int.
1574 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1575
0065d054
PE
1576 * emacs.c (main): Do not reallocate argv, since there is a null at
1577 the end that can be overwritten, and this way there's no need to
1578 worry about size-calculation overflow.
1579 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1580
1581 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1582 alloc succeeds.
1583 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1584
1585 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1586 (x_set_scroll_bar_width, x_figure_window_size):
1587 Check for integer overflow.
1588 (x_set_alpha): Do not assume XINT fits in int.
1589
1590 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1591 This is for the members text_lines, text_cols, total_lines, total_cols,
1592 where the system imposes an 'int' limit.
1593
1594 * fringe.c (Fdefine_fringe_bitmap):
1595 Don't update size until alloc works.
1596
1597 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1598 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1599
1600 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1601 Check for size-calculation overflow.
1602 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1603 do, as we prefer signed integers.
1604 (id_to_widget.max_size, id_to_widget.used)
1605 (xg_store_widget_in_map, xg_remove_widget_from_map)
1606 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1607 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1608 Use and return ptrdiff_t, not int.
1609 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1610 * gtkutil.h: Change prototypes to match the above.
1611
1612 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1613 are duplicate now that they've been promoted to lisp.h.
1614 (x_allocate_bitmap_record, x_alloc_image_color)
1615 (make_image_cache, cache_image, xpm_load):
1616 Don't update size until alloc is done.
1617 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1618 (x_detect_edges):
3256efce 1619 Check for size calculation overflow.
726e0ab1
PE
1620 (ct_colors_allocated_max): New constant.
1621 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1622 overflow.
3256efce 1623
726e0ab1
PE
1624 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1625 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1626 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1627 Use ptrdiff_t, not int, to count maps.
1628 (read_char_minibuf_menu_prompt): Check for overflow in size
1629 calculations. Don't update size until allocation succeeds. Redo
1630 calculations to avoid overflow.
1631 * keyboard.h: Change prototypes to match the above.
1632
1633 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1634 to count maps.
1635 (current_minor_maps): Check for size calculation overflow.
1636 * keymap.h: Change prototypes to match the above.
1637
1638 * lread.c (read1, init_obarray): Don't update size until alloc done.
1639
1640 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1641 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1642
726e0ab1
PE
1643 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1644 Now ptrdiff_t, not int.
1645 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1646 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1647
1648 * process.c (Fnetwork_interface_list): Check for overflow
1649 in size calculation.
1650
1651 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1652
1653 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1654 overflow. Don't bother calling xmalloc when xrealloc will do.
1655
1656 * search.c (Freplace_match): Check for size calculation overflow.
1657 (Fset_match_data): Don't assume list lengths fit in 'int'.
1658
1659 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1660 for command line length. Do not attempt to address one before the
1661 beginning of an array, as that's not portable.
1662
1663 * term.c (max_frame_lines): Remove; unused.
1664 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1665 not int.
1666 (encode_terminal_code, calculate_costs): Check for size
1667 calculation overflow.
1668 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1669 table lengths and related sizes. Don't update size until alloc
1670 done. Redo calculations to avoid overflow.
1671 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1672
1673 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1674 subtracting pointers.
1675 (gobble_line): Check for overflow more carefully. Don't update size
1676 until alloc done.
1677
1678 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1679 Don't update size until alloc done.
1680 Redo size calculations to avoid overflow.
1681 Check for size calculation overflow.
0065d054 1682 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1683
1684 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1685 Use ptrdiff_t, not int, for sizes.
1686 (store_mode_line_noprop_char): Don't update size until alloc done.
1687
0065d054
PE
1688 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1689 Use ptrdiff_t, not int, for sizes.
1690 (Finternal_make_lisp_face, cache_face):
1691 Check for size calculation overflow.
1692 (cache_face): Treat size calculation overflows as if they were
1693 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1694
1695 * xfns.c (x_encode_text, x_set_name_internal)
1696 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1697 sizes, since they can exceed INT_MAX in size. Check for size
1698 calculation overflow.
1699
0065d054
PE
1700 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1701 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1702 Don't update size until alloc done.
1703
0065d054 1704 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1705 as sprintf is limited to int lengths.
1d526e2f 1706
252c5ee1
PE
1707 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1708 (X_LONG_MIN): New macros.
864d7ce7
PE
1709 Use them to make the following changes clearer.
1710 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1711 This change doesn't affect the value now, but it may help remind
1712 future maintainers not to raise the value too much later.
1713 (SELECTION_QUANTUM): Remove, replacing with ...
1714 (selection_quantum): ... new function, which avoids overflow.
1715 All uses changed.
1716 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1717 assumption that selection length fits in 'int'.
1718 (x_reply_selection_request, x_handle_selection_request)
1719 (x_get_window_property, receive_incremental_selection)
1720 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1721 (lisp_data_to_selection_data, clean_local_selection_data):
1722 Use ptrdiff_t, not int, to record length of selection.
1723 (x_reply_selection_request, x_get_window_property)
1724 (receive_incremental_selection, x_property_data_to_lisp):
1725 Redo calculations to avoid overflow.
1726 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1727 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1728 something.
1729 (x_get_window_property, receive_incremental_selection)
1730 (lisp_data_to_selection_data, x_property_data_to_lisp):
1731 Check for size-calculation overflow.
1732 (x_get_window_property, receive_incremental_selection)
1733 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1734 Don't store size until memory allocation succeeds.
1735 (x_get_window_property): Plug memory leak on memory exhaustion.
1736 Don't double-block input; malloc is safe here. Don't assume 2**34
1737 - 4 fits in unsigned long. Add an xassert to check
1738 XGetWindowProperty overflow. Be more careful about overflow
1739 calculations, and distinguish size from memory overflow better.
1740 (receive_incremental_selection): When tracing, don't assume
1741 unsigned int is less than INT_MAX.
1742 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1743 harmful) conversions of unsigned short to int.
1744 (lisp_data_to_selection_data): Don't assume that integers
1745 in the range -65535 through -1 fit in an X unsigned short.
1746 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1747 result parameters unless successful. Rely on cons_to_unsigned
1748 to report problems with elements; the old code wasn't right anyway.
1749 (x_check_property_data): Check for int overflow; we cannot use
1750 a wider type due to X limits.
1751 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1752
726e0ab1 1753 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1754
0065d054
PE
1755 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1756 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1757 (x_color_cells): Don't store size until memory allocation succeeds.
1758 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1759 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1760 (x_term_init): Don't assume length fits in int (sprintf is limited
1761 to int size).
bc18e09d 1762
ebfa62c0
PE
1763 Use ptrdiff_t for composition IDs.
1764 * character.c (lisp_string_width):
1765 * composite.c (composition_table_size, n_compositions)
1766 (get_composition_id, composition_gstring_from_id):
1767 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1768 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1769 * window.c (Frecenter):
1770 Use ptrdiff_t, not int, for composition IDs.
1771 * composite.c (get_composition_id): Check for integer overflow.
1772 * composite.h: Adjust prototypes to match the above changes.
1773
d3411f89
PE
1774 Use ptrdiff_t for hash table indexes.
1775 * category.c (hash_get_category_set):
1776 * ccl.c (ccl_driver):
1777 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1778 * coding.c (coding_system_charset_list, detect_coding_system):
1779 * coding.h (struct coding_system.id):
1780 * composite.c (get_composition_id, gstring_lookup_cache):
1781 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1782 * image.c (xpm_get_color_table_h):
1783 * lisp.h (hash_lookup, hash_put):
1784 * minibuf.c (Ftest_completion):
1785 Use ptrdiff_t for hash table indexes, not int (which is too
1786 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1787 32-bit --with-wide-int hosts).
1788
e097a6fa
PE
1789 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1790 Add a FIXME comment about memory leaks.
1791 (syms_of_charset): Don't assume xmalloc returns.
1792
5637687f
PE
1793 Don't assume that stated character widths fit in int.
1794 * character.c (Fchar_width, c_string_width, lisp_string_width):
1795 * character.h (CHAR_WIDTH):
1796 * indent.c (MULTIBYTE_BYTES_WIDTH):
1797 Use sanitize_char_width to avoid undefined and/or bad behavior
1798 with outlandish widths.
1799 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1800 now that we have two such functions. All uses changed.
1801 (sanitize_char_width): New inline function.
1802
a2271ba2
PE
1803 Don't assume that tab-width fits in int.
1804 * character.h (sanitize_width): New inline function.
1805 (SANE_TAB_WIDTH): New macro.
1806 (ASCII_CHAR_WIDTH): Use it.
1807 * indent.c (sane_tab_width): Remove. All uses replaced by
1808 SANE_TAB_WIDTH (current_buffer).
1809 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1810
18c52557
PE
1811 * fileio.c: Integer overflow issues with file modes.
1812 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1813
caeeedc1
PE
1814 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1815 Remove unreachable code.
1816 (read_hex, load_charset_map_from_file): Check for integer overflow.
1817
50849c52
PE
1818 * xterm.c: don't go over XClientMessageEvent limit
1819 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1820 (x_send_scroll_bar_event): Likewise. Check that the size does not
1821 exceed limits imposed by XClientMessageEvent, as well as the usual
1822 ptrdiff_t and size_t limits.
1823
b13995db
PE
1824 * keyboard.c: Overflow, signedness and related fixes.
1825 (make_lispy_movement): Use same integer type in forward decl
1826 that is used in the definition.
1827 (read_key_sequence, keyremap_step):
1828 Change bufsize argument back to int, undoing my 2011-03-30 change.
1829 We prefer signed types, and int is wide enough here.
1830 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1831 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1832 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1833 length, not size_t. Use ptrdiff_t for index, not int.
1834 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1835 possibility of integer overflow.
1836
13464394
PE
1837 Overflow, signedness and related fixes for images.
1838
1839 * dispextern.h (struct it.stack[0].u.image.image_id)
1840 (struct_it.image_id, struct image.id, struct image_cache.size)
1841 (struct image_cache.used, struct image_cache.ref_count):
1842 * gtkutil.c (update_frame_tool_bar):
1843 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1844 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1845 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1846 * nsmenu.m (update_frame_tool_bar):
1847 * xdisp.c (calc_pixel_width_or_height):
1848 * xfns.c (image_cache_refcount):
1849 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1850 on typical 64-bit hosts.
1851
1852 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1853 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1854 Omit unnecessary casts to int.
1855 (parse_image_spec): Check that integers fall into 'int' range
1856 when the callers expect that.
1857 (image_ascent): Redo ascent calculation to avoid int overflow.
1858 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1859 (lookup_image): Remove unnecessary tests.
1860 (xbm_image_p): Locals are now of int, not EMACS_INT,
1861 since parse_image_check makes sure they fit into int.
1862 (png_load, gif_load, svg_load_image):
1863 Prefer int to unsigned where either will do.
1864 (tiff_handler): New function, combining the cores of the
1865 old tiff_error_handler and tiff_warning_handler. This
1866 function is rewritten to use vsnprintf and thereby avoid
1867 stack buffer overflows. It uses only the features of vsnprintf
1868 that are common to both POSIX and native Microsoft.
1869 (tiff_error_handler, tiff_warning_handler): Use it.
1870 (tiff_load, gif_load, imagemagick_load_image):
1871 Don't assume :index value fits in 'int'.
1872 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1873 (imagemagick_load_image): Check that crop parameters fit into
1874 the integer types that MagickCropImage accepts. Don't assume
1875 Vimagemagick_render_type has a nonnegative value. Don't assume
1876 size_t fits in 'long'.
1877 (gs_load): Use printmax_t to print the widest integers possible.
1878 Check for integer overflow when computing image height and width.
1879
c11821d4
EZ
18802011-08-26 Eli Zaretskii <eliz@gnu.org>
1881
1882 * xdisp.c (redisplay_window): Don't force window start if point
1883 will be invisible in the resulting window. (Bug#9324)
1884
0c95fcf7
EZ
18852011-08-25 Eli Zaretskii <eliz@gnu.org>
1886
1887 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1888 the display spec is of the form `(space ...)'.
1889 (handle_display_spec): Return the value returned by
1890 handle_single_display_spec, not just 1 or zero.
1891 (handle_single_display_spec): If the display spec is of the form
1892 `(space ...)', and specifies display in the text area, return 2
1893 rather than 1.
fee65a97 1894 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1895 accurately, and prefer exact match for point under bidi. Don't
1896 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1897
1898 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1899 into disp_prop; all users changed.
1900
1901 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1902 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1903 for the text covered by the display property.
1904
e4ed06f1
CY
19052011-08-25 Chong Yidong <cyd@stupidchicken.com>
1906
1907 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1908 Change return value to nil.
1909 (Frecord_buffer): Delete unused function.
1910
f67cdd7f
EZ
19112011-08-24 Eli Zaretskii <eliz@gnu.org>
1912
5980d4c6
EZ
1913 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1914 buffers, return left-to-right.
8610fe8b
EZ
1915 (set_cursor_from_row): Consider candidate row a win if its glyph
1916 represents a newline and point is on that newline. Fixes cursor
1917 positioning on the newline at EOL of R2L text within L2R
1918 paragraph, and vice versa.
1919 (try_cursor_movement): Check continued rows, in addition to
1920 continuation rows. Fixes unwarranted scroll when point enters a
1921 continued line of R2L text within an L2R paragraph, or vice versa.
1922 (cursor_row_p): Consider the case of point being equal to
1923 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1924 from the end of a short line to the beginning of a continued line
1925 of R2L text within L2R paragraph.
1926 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1927 composed characters.
5980d4c6 1928
f67cdd7f
EZ
1929 * bidi.c (bidi_check_type): Use xassert.
1930 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1931 members.
1932
bca633fb
EZ
19332011-08-23 Eli Zaretskii <eliz@gnu.org>
1934
1935 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1936 a character.
1937
4a5885a7
CY
19382011-08-23 Chong Yidong <cyd@stupidchicken.com>
1939
1940 * nsfont.m (ns_otf_to_script): Fix typo.
1941
0902a04e
KH
19422011-08-22 Kenichi Handa <handa@m17n.org>
1943
1944 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1945 extra slot even if the purpose is char-code-property-table.
1946
1a2e6670
EZ
19472011-08-23 Eli Zaretskii <eliz@gnu.org>
1948
8ddde651
EZ
1949 * xdisp.c (redisplay_window): When computing centering_position,
1950 account for the height of the header line. (Bug#8874)
1951
425cc014
EZ
1952 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1953 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1954 candidate is selected by the mouse, and that candidate has a
1955 composed character under the mouse.
1956
1a2e6670
EZ
1957 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1958 coordinates reported by pos-visible-in-window-p for a composed
1959 character in column zero.
1960
8b76d6f8
SM
19612011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1962
1963 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1964
dac347dd
EZ
19652011-08-22 Eli Zaretskii <eliz@gnu.org>
1966
1967 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1968 consider it a hit if to_charpos is anywhere in the range of the
1969 composed buffer positions.
1970
e013fb34
CY
19712011-08-22 Chong Yidong <cyd@stupidchicken.com>
1972
1973 * image.c (gif_load): Don't assume that each subimage has the same
1974 dimensions as the base image. Handle disposal method that is
1975 "undefined" by the gif spec (Bug#9335).
1976
bd1ba3e8
CY
19772011-08-20 Chong Yidong <cyd@stupidchicken.com>
1978
1979 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1980 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1981
54a1215b
EZ
19822011-08-19 Eli Zaretskii <eliz@gnu.org>
1983
823564e5
EZ
1984 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1985 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1986 from an Org mode buffer to a Speedbar frame.
1987
54a1215b
EZ
1988 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1989 a composition, take its buffer position from IT->cmp_it.charpos.
1990 Fixes cursor positioning at the beginning of a line that begins
1991 with a composed character.
1992
9778ebcc
EZ
19932011-08-18 Eli Zaretskii <eliz@gnu.org>
1994
0be6ee06
EZ
1995 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1996 character bidirectional type, use STRONG_L instead. Fixes crashes
1997 in a buffer produced by `describe-categories'.
1998
9778ebcc
EZ
1999 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2000 members before the level stack, so they would be saved and
2001 restored when copying iterator state. Fixes incorrect reordering
2002 around TABs covered by display properties.
2003
156bffbe
AS
20042011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2005
2006 * process.c (Fnetwork_interface_list): Correctly determine buffer
2007 size.
2008
72ad093b
CY
20092011-08-17 Chong Yidong <cyd@stupidchicken.com>
2010
2011 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2012 (internal_condition_case_2, internal_condition_case_n):
2013 Remove unnecessary aborts (Bug#9081).
72ad093b 2014
35774242
EZ
20152011-08-17 Eli Zaretskii <eliz@gnu.org>
2016
2017 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2018 has no `load' handler, try opening the file locally. (Bug#9311)
2019
db76dd85
KB
20202011-08-16 Ken Brown <kbrown@cornell.edu>
2021
2022 * gmalloc.c: Expand comment.
2023
b215eee5
EZ
20242011-08-16 Eli Zaretskii <eliz@gnu.org>
2025
2026 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2027 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2028
a4579d33
KB
20292011-08-16 Ken Brown <kbrown@cornell.edu>
2030
2031 Fix memory allocation problems in Cygwin build (Bug#9273).
2032
2033 * unexcw.c ( __malloc_initialized): Declare external variable.
2034 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2035
8b76d6f8
SM
2036 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2037 New variables.
a4579d33
KB
2038 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2039 dumped emacs.
2040 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2041 in the static heap.
2042 [CYGWIN] (special_realloc): New function.
2043 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2044 requests to realloc storage in the static heap.
2045
3ebec551
PE
20462011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * bidi.c (bidi_initialize): Remove unused local.
2049
9fd8be00
EZ
20502011-08-15 Eli Zaretskii <eliz@gnu.org>
2051
474a8465
EZ
2052 * biditype.h: File removed.
2053
2054 * bidimirror.h: File removed.
2055
2056 * deps.mk (bidi.o): Remove biditype.h and
2057 bidimirror.h.
2058
2059 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2060 bidimirror.h.
2061
2062 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2063
2064 * chartab.c: Improve commentary for the uniprop_table API.
2065
32413314
EZ
2066 * bidi.c (bidi_paragraph_init): Support zero value of
2067 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2068 (bidi_initialize): Use uniprop_table instead of including
2069 biditype.h and bidimirror.h.
32413314 2070
9fd8be00
EZ
2071 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2072 coordinates of the iterator when restoring from ppos_it.
2073 (Bug#9296)
2074
5cf2b69b
KH
20752011-08-14 Kenichi Handa <handa@m17n.org>
2076
2077 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2078 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2079
daf17d00
EZ
20802011-08-14 Eli Zaretskii <eliz@gnu.org>
2081
2082 * xdisp.c (move_it_in_display_line_to): Don't invoke
2083 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2084 ppos_it. Fixes vertical cursor motion when line beginning is
2085 covered by an image. (Bug#9296)
2086
08e3161a
JD
20872011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2088
2089 * nsterm.h (ns_run_ascript): Declare.
2090 (NSAPP_DATA2_RUNASSCRIPT): Define.
2091
2092 * nsfns.m (as_script, as_result, as_status): New static variables.
2093 (ns_run_ascript): New function.
5e617bc2 2094 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2095 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2096 the event loop. Get status from as_status (Bug#7276).
2097
2098 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2099 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2100 the event loop (Bug#7276).
2101
a3720aa2
AS
21022011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2103
2104 * gnutls.c (QCgnutls_bootprop_priority)
2105 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2106 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2107 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2108 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2109 (QCgnutls_bootprop_verify_hostname_error)
2110 (QCgnutls_bootprop_callbacks_verify): Rename from
2111 Qgnutls_bootprop_..., all uses changed.
2112
2113 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2114 uses changed.
2115
0a0d27fb
PE
21162011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2117
19d5c50c
PE
2118 * xfaces.c (Qframe_set_background_mode): Now static.
2119 * dispextern.h (Qframe_set_background_mode): Remove decl.
2120
0a0d27fb
PE
2121 * process.c (Fnetwork_interface_info): Declare local only if needed.
2122
377538cb
JD
21232011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2124
2125 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2126 (Fnetwork_interface_list): Allocate in increments of bytes instead
2127 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2128 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2129 sockaddr.
2130 (struct ifflag_def): notrailers is smart on OSX.
2131 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2132 Get hardware address with getifaddrs if available.
2133
08fff70c
EZ
21342011-08-12 Eli Zaretskii <eliz@gnu.org>
2135
2136 * xdisp.c (iterate_out_of_display_property): xassert that
2137 IT->position is set to within IT->object's boundaries. Break from
2138 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2139 when IT->position is set up wrongly due to some bug.
2140 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2141 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2142 entry. Force push_it to save on the stack the current
2143 buffer/string position, to be restored by pop_it. Fix flags in
2144 the iterator structure wrt the object coming from a display
2145 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2146 properties. (Bug#9284)
2147
7be1c708 21482011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2149
7be1c708
CY
2150 * fontset.c (fontset_get_font_group): Add proper type checks.
2151 (Bug#9172)
aac0c6e3 2152
7be1c708 21532011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2154
7be1c708
CY
2155 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2156 and LC_VERSION_MIN_MACOSX.
2157 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2158 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2159
97bb72a6
EZ
21602011-08-08 Eli Zaretskii <eliz@gnu.org>
2161
2162 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2163 no-display-properties-and-no-overlays under bidi display.
2164 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2165 properties and overlays.
97bb72a6 2166
d5617611
CY
21672011-08-08 Chong Yidong <cyd@stupidchicken.com>
2168
37e11a63
CY
2169 * editfns.c (Fset_time_zone_rule): Document relationship with the
2170 setenv function.
2171
d5617611
CY
2172 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2173 the font entity extracted from the cache (Bug#8109).
2174
58872834
CY
21752011-08-07 Chong Yidong <cyd@stupidchicken.com>
2176
2177 * composite.c (autocmp_chars): Don't reset point. That is done by
2178 restore_point_unwind (Bug#5984).
2179
75bfc667
JL
21802011-08-07 Juri Linkov <juri@jurta.org>
2181
2182 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2183 to show the arg `TIME' instead of `TIMEVAL'.
2184
d1410150
EZ
21852011-08-06 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2188 display property strides EOL and includes a newline, as in
2189 longlines-mode. (Bug#9254)
75b771e4
EZ
2190 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2191 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2192
2193 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2194 is non-zero, even if the data buffer is NULL. Fixes a crash in
2195 vertical-motion with longlines-mode. (Bug#9254)
2196
35928349
EZ
21972011-08-05 Eli Zaretskii <eliz@gnu.org>
2198
ec7cc85b
EZ
2199 * bidi.c <bidi_cache_total_alloc>: Now static.
2200 (bidi_initialize): Initialize bidi_cache_total_alloc.
2201
8b76d6f8 2202 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2203 cache. (Bug#9221)
2204
2205 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2206 amount allocated this far in `bidi_cache_total_alloc'.
2207 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2208 non-zero, only free the data buffer without restoring the cache
2209 contents. All callers changed.
2210
2211 * dispextern.h (bidi_unshelve_cache): Update prototype.
2212
2213 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2214 (move_it_in_display_line, move_it_to)
2215 (move_it_vertically_backward, move_it_by_lines): Replace the call
2216 to xfree to an equivalent call to bidi_unshelve_cache.
2217 (move_it_in_display_line_to): Fix logic of returning
412b6358 2218 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2219
e2e2423b
EZ
22202011-08-05 Eli Zaretskii <eliz@gnu.org>
2221
2222 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2223 came from a string character with a `cursor' property. (Bug#9229)
2224
ae9e757a
JD
22252011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2226
2227 * Makefile.in (LIB_PTHREAD): New variable.
2228 (LIBES): Add LIB_PTHREAD (Bug#9216).
2229
2230 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2231 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2232
213bd7f2
AS
22332011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * regex.c (re_iswctype): Remove some redundant boolean
2236 conversions.
2237
99aaf75f
JD
22382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2239
2240 * xterm.c (x_find_topmost_parent): New function.
2241 (x_set_frame_alpha): Find topmost parent window with
2242 x_find_topmost_parent and set the property there also (bug#9181).
2243 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2244
c74e9d86
PE
22452011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 * callproc.c (Fcall_process): Avoid vfork clobbering
2248 the local vars buffer, coding_systems, current_dir.
2249
640c8776
SM
22502011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2251
2252 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2253
f26d0e4c
PE
22542011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2255
8a10d76c
PE
2256 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2257 so that it is not optimized away.
2258
f26d0e4c
PE
2259 * xdisp.c (compute_display_string_pos): Remove unused local.
2260
55439c61
EZ
22612011-08-02 Eli Zaretskii <eliz@gnu.org>
2262
2263 Fix slow cursor motion and scrolling in large buffers with
2264 selective display, like Org Mode buffers. (Bug#9218)
2265
2266 * dispextern.h (struct bidi_it): New member disp_prop_p.
2267
2268 * xdisp.c: Remove one-slot cache of display string positions.
2269 (compute_display_string_pos): Accept an additional argument
5e617bc2 2270 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2271 for a display string or property. If found, set DISP_PROP_P
2272 non-zero.
2273
2274 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2275 DISP_PROP_P, and pass it to compute_display_string_pos.
2276 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2277 non-zero. All callers of bidi_fetch_char changed.
2278
fb33fa43
SM
22792011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2280
2281 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2282
b099e063
DM
22832010-12-03 Don March <don@ohspite.net>
2284
2285 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2286 last character M-[char] is translated to ESC [char] (bug#7541).
2287
5cc7f7af
KH
22882011-08-02 Kenichi Handa <handa@m17n.org>
2289
d0fffa3f 2290 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2291
2292 * chartab.c (uniprop_table): Make it non-static.
2293
525d5e6e
EZ
22942011-08-01 Eli Zaretskii <eliz@gnu.org>
2295
2296 * xdisp.c (forward_to_next_line_start): Accept additional argument
2297 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2298 on the newline.
2299 (reseat_at_next_visible_line_start): Use the bidi iterator state
2300 returned by forward_to_next_line_start to restore the state of
2301 it->bidi_it after backing up to previous newline. (Bug#9212)
2302
31011111
AS
23032011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2304
2305 * regex.c (re_comp): Protoize.
2306 (re_exec): Fix return type.
2307 (regexec): Fix type of `ret'. (Bug#9203)
2308
476371c4
PE
23092011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2310
e5d76069
PE
2311 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2312 This is needed if max-image-size is a floating-point number.
2313
9a79b20c
AS
23142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2315
2316 * print.c (print_object): Print empty symbol as ##.
2317
2318 * lread.c (read1): Read ## as empty symbol.
2319
d8c2fa78
AA
23202011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2321
2322 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2323 setting frame foreground color (Bug#9175).
2324 (x_set_background_color): Likewise.
2325
ffe57a7a
AA
2326 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2327 contents (Bug#9176).
2328 (EmacsTooltip -init): Remove bezels and add shadows to
2329 tooltip windows.
2330
bf3492a5
AA
2331 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2332 or scroll bar (Bug#8470).
2333
d55e9c53
AA
2334 * nsfont.m (nsfont_open): Remove assignment to voffset and
2335 unnecessary vars hshink, expand, hd, full_height, min_height.
2336 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2337
2338 * nsterm.h (nsfont_info): Remove voffset field.
2339
d8c2fa78 23402011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2341
2342 Implement strike-through and overline on NextStep (Bug#8863).
2343
2344 * nsfont.m (nsfont_open): Use underline position provided by font,
2345 instead of hard-coded value of 2.
2346 (nsfont_draw): Call ns_draw_text_decoration instead.
2347
2348 * nsterm.h: Add declaration for ns_draw_text_decoration.
2349
2350 * nsterm.m (ns_draw_text_decoration): New function for drawing
2351 underline, overline, and strike-through.
2352 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2353 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2354 accommodate underlining, etc.
4843aac3 2355
4cc60b9b
EZ
23562011-07-28 Eli Zaretskii <eliz@gnu.org>
2357
bc7ece87
EZ
2358 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2359 default.
4cc60b9b 2360
476371c4
PE
23612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2362
66606eea
PE
2363 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2364 Without this fix, if a signal arrives just after memory fills up,
2365 'malloc' might be invoked reentrantly.
2366
476371c4
PE
2367 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2368 In other words, assume that every image size is allowed, on non-X
2369 hosts. This assumption is probably wrong, but it lets Emacs compile.
2370
f3fcc40d
AS
23712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2372
2373 * regex.c (re_iswctype): Convert return values to boolean.
2374
350c992f
EZ
23752011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2376
2377 * xdisp.c (compute_display_string_pos): Don't use cached display
2378 string position if the buffer had its restriction changed.
2379 (Bug#9184)
2380
5266b4bb
PE
23812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2384
2573a837 23852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2386
41f55ccd 2387 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2388
39e378da
PE
2389 * bidi.c: Integer size and overflow fixes.
2390 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2391 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2392 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2393 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2394 (bidi_find_other_level_edge):
2395 Use ptrdiff_t instead of EMACS_INT where either will do.
2396 This works better on 32-bit hosts configured --with-wide-int.
2397 (bidi_cache_ensure_space): Check for size-calculation overflow.
2398 Use % rather than repeated addition, for better worst-case speed.
2399 Don't set bidi_cache_size until after xrealloc returns, because it
2400 might not return.
2401 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2402 (bidi_cache_ensure_space): Also check that the bidi cache size
2403 does not exceed that of the largest Lisp string or buffer. See Eli
2404 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2405
5e927815
PE
2406 * alloc.c (__malloc_size_t): Remove.
2407 All uses replaced by size_t. See Andreas Schwab's note
2408 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2409
ca4aa935
PE
2410 * image.c: Improve checking for integer overflow.
2411 (check_image_size): Assume that f is nonnull, since
2412 it is always nonnull in practice. This is one less thing to
2413 worry about when checking for integer overflow later.
2414 (x_check_image_size): New function, which checks for integer
2415 overflow issues inside X.
2416 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2417 This removes the need for a memory_full check.
2418 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2419 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2420 (xbm_read_bitmap_data): Change locals back to 'int', since
2421 their values must fit in 'int'.
2422 (xpm_load_image, png_load, tiff_load):
2423 Invoke x_create_x_image_and_pixmap earlier,
2424 to avoid much needless work if the image is too large.
2425 (tiff_load): Treat overly large images as if
2426 x_create_x_image_and_pixmap failed, not as malloc failures.
2427 (gs_load): Use x_check_image_size.
2428
5f8f9cc2
PE
2429 * gtkutil.c: Omit integer casts.
2430 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2431 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2432
5adf60bc
PE
2433 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2434
c8907a93
PE
2435 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2436 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2437 would wrongly return t on a 64-bit host.
2438
e3c25c68
PE
2439 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2440 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2441 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2442 and therefore cause GCC to emit a bogus diagnostic in some cases.
2443
3f791afe
PE
2444 * image.c: Integer signedness and overflow and related fixes.
2445 This is not an exhaustive set of fixes, but it's time to
2446 record what I've got.
2447 (lookup_pixel_color, check_image_size): Remove redundant decls.
2448 (check_image_size): Don't assume that arbitrary EMACS_INT values
2449 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2450 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2451 (tiff_load, imagemagick_load_image):
2452 Check for overflow in size calculations.
2453 (x_create_x_image_and_pixmap): Remove unnecessary test for
2454 xmalloc returning NULL; that can't happen.
2455 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2456 (xpm_color_bucket): Use better integer hashing function.
2457 (xpm_cache_color): Don't possibly over-allocate memory.
2458 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2459 (gif_memory_source):
2460 Use ptrdiff_t, not int or size_t, to record sizes.
2461 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2462 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2463 either works, as we prefer signed integers.
2464 (tiff_read_from_memory, tiff_write_from_memory):
2465 Return tsize_t, not size_t, since that's what the TIFF API wants.
2466 (tiff_read_from_memory): Don't fail simply because the read would
2467 go past EOF; instead, return a short read.
2468 (tiff_load): Omit no-longer-needed casts.
2469 (Fimagemagick_types): Don't assume size fits into 'int'.
2470
3cc5a532
PE
2471 Improve hashing quality when configured --with-wide-int.
2472 * fns.c (hash_string): New function, taken from sxhash_string.
2473 Do not discard information about ASCII character case; this
2474 discarding is no longer needed.
2475 (sxhash-string): Use it. Change sig to match it. Caller changed.
2476 * lisp.h: Declare it.
2477 * lread.c (hash_string): Remove, since we now use fns.c's version.
2478 The fns.c version returns a wider integer if --with-wide-int is
2479 specified, so this should help the quality of the hashing a bit.
2480
b312a492
PE
2481 * emacs.c: Integer overflow minor fix.
2482 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2483 Define only if GNU_LINUX.
2484 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2485
dfd153ae
PE
2486 * dispnew.c: Integer signedness and overflow fixes.
2487 Remove unnecessary forward decls, that were a maintenance hassle.
2488 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2489 All uses changed.
2490 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2491 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2492 (prepare_desired_row, line_draw_cost):
2493 Use int, not unsigned, where either works.
2494 (save_current_matrix, restore_current_matrix):
2495 Use ptrdiff_t, not size_t, where either works.
2496 (init_display): Check for overflow more accurately, and without
2497 relying on undefined behavior.
2498
a81d11a3
PE
2499 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2500 Remove, replacing with the new symbols in lisp.h. All uses changed.
2501 * fileio.c (make_temp_name):
2502 * filelock.c (lock_file_1, lock_file):
2503 * xdisp.c (message_dolog):
2504 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2505 Use pMd etc. instead.
2506 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2507 replacing the pWIDE etc. symbols removed from editfns.c.
2508
3300e6fd
PE
2509 * keyboard.h (num_input_events): Now uintmax_t.
2510 This is (very slightly) less likely to mess up due to wraparound.
2511 All uses changed.
2512
fd05c7e9
PE
2513 * buffer.c: Integer signedness fixes.
2514 (alloc_buffer_text, enlarge_buffer_text):
2515 Use ptrdiff_t rather than size_t when either will do, as we prefer
2516 signed integers.
2517
903fe15d
PE
2518 * alloc.c: Integer signedness and overflow fixes.
2519 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2520 (__malloc_size_t): Default to size_t, not to int.
2521 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2522 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2523 Prefer ptrdiff_t to size_t when either would do, as we prefer
2524 signed integers.
2525 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2526 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2527 Now const. Initialize with values that are in range even if char
2528 is signed.
2529 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2530 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2531 These functions do the right thing with sizes > 2**32.
2532 (check_depth): Now ptrdiff_t, not int.
2533 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2534 Adjust to new way of storing sizes. Check for size overflow bugs
2535 in rest of code.
2536 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2537 slightly wrong anyway, as it missed one instance of
2538 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2539 (refill_memory_reserve): Omit needless cast to size_t.
2540 (mark_object_loop_halt): Mark as externally visible.
2541
ac82cc6a
PE
2542 * xselect.c: Integer signedness and overflow fixes.
2543 (Fx_register_dnd_atom, x_handle_dnd_message):
2544 Use ptrdiff_t, not size_t, since we prefer signed.
2545 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2546 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2547 x_dnd_atoms_size and x_dnd_atoms_length.
2548
c2d1e36d
PE
2549 * doprnt.c: Prefer signed to unsigned when either works.
2550 * eval.c (verror):
2551 * doprnt.c (doprnt):
2552 * lisp.h (doprnt):
2553 * xdisp.c (vmessage):
2554 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2555 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2556 prefer signed arithmetic to avoid comparison confusion.
2557 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2558 but is a bit tricky.
2559
0e926e56
PE
2560 Assume freestanding C89 headers, string.h, stdlib.h.
2561 * data.c, doprnt.c, floatfns.c, print.c:
2562 Include float.h unconditionally.
2563 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2564 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2565 * regex.c: Likewise for stddef.h, string.h.
2566 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2567 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2568 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2569 (STDC_HEADERS): Remove obsolete defines.
2570 * sysdep.c: Include limits.h unconditionally.
2571
9cfdb3ec
PE
2572 Assume support for memcmp, memcpy, memmove, memset.
2573 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2574 * regex.c (memcmp, memcpy):
2575 Remove; we assume C89 now.
2576
2577 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2578 (__malloc_safe_bcopy): Remove; no longer needed.
2579
cf950e6b 2580 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2581 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2582 well either way, and we prefer signed to unsigned.
2583
dbf38e02
LMI
25842011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2585
2586 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2587 closes the connection while we're reading (bug#9182).
2588
d6f0886c 25892011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2590
d6f0886c
JD
2591 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2592 are specified (Bug#9168).
24e0f6b1 2593
2eb1f9e6
PE
25942011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2597 Found by GCC static checking and --with-wide-int on a 32-bit host.
2598
22381272 25992011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2600
2601 * xdisp.c (compute_display_string_pos): Fix logic of caching
2602 previous display string position. Initialize cached_prev_pos to
2603 -1. Fixes slow-down at the beginning of a buffer.
2604
f25e39b4
EZ
26052011-07-24 Eli Zaretskii <eliz@gnu.org>
2606
2607 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2608 for attrs[LFACE_FONTSET_INDEX].
2609
04c4b52e
PE
26102011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * xml.c (parse_region): Remove unused local
2613 that was recently introduced.
2614
c1734fbd
EZ
26152011-07-23 Eli Zaretskii <eliz@gnu.org>
2616
be18c5a5
EZ
2617 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2618 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2619
c1734fbd
EZ
2620 * xdisp.c (move_it_in_display_line_to): Record the best matching
2621 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2622 exit if none of the characters scanned was an exact match.
2623 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2624 when exact match is impossible due to invisible text, and the
2625 lines are truncated.
2626
a258d627
JD
26272011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2628
2629 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2630 for OSX >= 10.7.
2631
b6d5a689
EZ
26322011-07-22 Eli Zaretskii <eliz@gnu.org>
2633
0f74f785
EZ
2634 Fix a significant slow-down of cursor motion with C-n, C-p,
2635 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2636 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2637 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2638 (next_element_from_buffer): Call compute_stop_pos_backwards to
2639 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2640 base_level_stop.
2641 (reseat): Don't look for prev_stop, as that could mean a very long
2642 run.
2643 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2644 <cached_disp_overlay_modiff>: Cache for last found display string
2645 position.
551918c1 2646 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2647 about the same buffer in the same area of character positions, and
2648 the buffer wasn't changed since the time the display string
2649 position was cached.
551918c1 2650
b2d0c91a
EZ
26512011-07-22 Eli Zaretskii <eliz@gnu.org>
2652
2653 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2654 is an integer, which is important for empty lines. (Bug#9149)
2655
043604ee
CY
26562011-07-22 Chong Yidong <cyd@stupidchicken.com>
2657
2658 * frame.c (Fmodify_frame_parameters): In tty case, update the
2659 default face if necessary (Bug#4238).
2660
da4adb04
CY
26612011-07-21 Chong Yidong <cyd@stupidchicken.com>
2662
2663 * editfns.c (Fstring_to_char): No need to explain what a character
2664 is in the docstring (Bug#6576).
2665
9abd0532
LMI
26662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2667
2668 * xml.c (parse_region): Make sure we always return a tree.
2669
36881d16
HK
26702011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2671
2672 * xml.c (parse_region): If a document contains only comments,
2673 return that, too.
2674
1e98674d
LMI
26752011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2676
2677 * xml.c (make_dom): Return comments, too.
2678
590bd467
PE
26792011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 Port to OpenBSD.
2682 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2683 and the surrounding thread.
2684 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2685 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2686 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2687 timer goes off.
2688 * s/openbsd.h (BROKEN_SIGIO): Define.
2689 * unexelf.c (unexec) [__OpenBSD__]:
2690 Don't update the .mdebug section of the Alpha COFF symbol table.
2691
f41628b2
LMI
26922011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2693
2694 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2695 (bug#8460).
2696
b59b67c5
PE
26972011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2698
15e3a074
PE
2699 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2700 This fixes some race conditions on the permissions of any newly
2701 created file.
2702
41bed37d
PE
2703 * alloc.c (valid_pointer_p): Use pipe, not open.
2704 This fixes some permissions issues when debugging.
2705
b59b67c5
PE
2706 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2707 If fchown fails to set both uid and gid, try to set just gid,
2708 as that is sometimes allowed. Adjust the file's mode to eliminate
2709 setuid or setgid bits that are inappropriate if fchown fails.
2710
925a6be7
SM
27112011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2712
2713 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2714 to compare Lisp_Objects.
2715 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2716 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2717 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2718
52968808
AS
27192011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2720
0a6a104b
AS
2721 * lread.c (read_integer): Unread even EOF character.
2722 (read1): Likewise. Properly record start position of symbol.
2723
52968808
AS
2724 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2725 symbol character follows.
2726
9e381cdd
PE
27272011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2728
2729 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2730 This works around a problem with the previous change to Fcopy_file.
2731 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2732 and without this change, GCC might complain about discarding
2733 fchown's return value.
2734
b5641435
JB
27352011-07-16 Juanma Barranquero <lekktu@gmail.com>
2736
2737 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2738
a8031457
PE
27392011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2742
dd889327
LMI
27432011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2744
750c33f7
LMI
2745 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2746 it's used from the C level.
2747
dd889327
LMI
2748 * process.c: Use the same condition for POLL_FOR_INPUT in both
2749 keyboard.c and process.c (bug#1858).
2750
87e86684
LM
27512011-07-09 Lawrence Mitchell <wence@gmx.li>
2752
2753 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2754 (Fgnutls_boot): Use it.
2755
64348f40
AS
27562011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2757
2758 * doc.c (Fsubstitute_command_keys): Revert last change.
2759
1d698799
LMI
27602011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2761
f863868c
LMI
2762 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2763 quotes the next character, and doesn't affect other longer
2764 sequences (bug#8935).
2765
1d698799
LMI
2766 * lread.c (syms_of_lread): Clarify that is isn't only
2767 `eval-buffer' and `eval-defun' that's affected by
2768 `lexical-binding' (bug#8460).
2769
aa4b6df6
EZ
27702011-07-15 Eli Zaretskii <eliz@gnu.org>
2771
2772 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2773 bidi redisplay when a line includes both an image and is
2774 truncated.
2775
5d856da6
PE
27762011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2777
ad6042bb
PE
2778 Fix minor problems found by static checking.
2779 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2780 (elsz): Now a signed constant, not a size_t var. We prefer signed
2781 types to unsigned, to avoid integer comparison confusion. Without
2782 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2783 "cannot optimize loop, the loop counter may overflow", a symptom
2784 of the confusion.
f00bbb22 2785 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2786 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2787
6468f31c
LMI
27882011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2789
49080b10
LMI
2790 * search.c (Fre_search_backward): Mention `case-fold-search' in
2791 all the re_search_* functions (bug#8138).
2792
6468f31c
LMI
2793 * keyboard.c (Fopen_dribble_file): Document when the file is
2794 closed (bug#8056).
2795
c965adc5
EZ
27962011-07-14 Eli Zaretskii <eliz@gnu.org>
2797
df9733bf
EZ
2798 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2799 bidi_cache_idx.
2800
0bb23927
EZ
2801 Support bidi reordering of display and overlay strings.
2802 * xdisp.c (compute_display_string_pos)
2803 (compute_display_string_end): Accept additional argument STRING.
2804 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2805 (reseat_to_string): Initialize bidi_it->string.s and
2806 bidi_it->string.schars.
2807 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2808 NULL (avoids a crash in bidi_paragraph_init).
2809 Initialize itb.string.lstring.
0bb23927
EZ
2810 (init_iterator): Call bidi_init_it only of a valid
2811 buffer position was specified. Initialize paragraph_embedding to
2812 L2R.
2813 (reseat_to_string): Initialize the bidi iterator.
2814 (display_string): If we need to ignore text properties of
2815 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2816 original value of -1 will not work with bidi.)
2817 (compute_display_string_pos): First arg is now struct
2818 `text_pos *'; all callers changed. Support display properties on
2819 Lisp strings.
2820 (compute_display_string_end): Support display properties on Lisp
2821 strings.
2822 (init_iterator, reseat_1, reseat_to_string): Initialize the
2823 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2824 when iterating on a string not from display properties).
640c8776
SM
2825 (compute_display_string_pos, compute_display_string_end):
2826 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2827 arrow keys.
2828 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2829 base_level_stop; instead, set base_level_stop to BEGV.
2830 Fixes crashes in vertical-motion.
0bb23927
EZ
2831 (next_element_from_buffer): Improve commentary for when
2832 the iterator is before prev_stop.
2833 (init_iterator): Initialize bidi_p from the default value of
2834 bidi-display-reordering, not from buffer-local value. Use the
2835 buffer-local value only if initializing for buffer iteration.
2836 (handle_invisible_prop): Support invisible properties on strings
2837 that are being bidi-reordered.
2838 (set_iterator_to_next): Support bidi reordering of C strings and
2839 Lisp strings.
2840 (next_element_from_string): Support bidi reordering of Lisp
2841 strings.
2842 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2843 (display_string): Support display of R2L glyph rows.
2844 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2845 (init_iterator): Don't initialize it->bidi_p for strings
2846 here.
2847 (reseat_to_string): Initialize it->bidi_p for strings here.
2848 (next_element_from_string, next_element_from_c_string)
2849 (next_element_from_buffer): Add xassert's for correspondence
2850 between IT's object being iterated and it->bidi_it.string
2851 structure.
2852 (face_before_or_after_it_pos): Support bidi iteration.
2853 (next_element_from_c_string): Handle the case of the first string
2854 character that is not the first one in the visual order.
2855 (get_visually_first_element): New function, refactored from common
2856 parts of next_element_from_buffer, next_element_from_string, and
2857 next_element_from_c_string.
2858 (tool_bar_lines_needed, redisplay_tool_bar)
2859 (display_menu_bar): Force left-to-right direction. Add a FIXME
2860 comment for making that be controlled by a user option.
2861 (push_it, pop_it): Save and restore the state of the
2862 bidi iterator. Save and restore the bidi_p flag.
2863 (pop_it): Iterate out of display property for string iteration as
2864 well.
2865 (iterate_out_of_display_property): Support iteration over strings.
2866 (handle_single_display_spec): Set up it->bidi_it for iteration
2867 over a display string, and call bidi_init_it.
2868 (handle_single_display_spec, next_overlay_string)
2869 (get_overlay_strings_1, push_display_prop): Set up the bidi
2870 iterator for displaying display or overlay strings.
2871 (forward_to_next_line_start): Don't use the shortcut if
2872 bidi-iterating.
2873 (back_to_previous_visible_line_start): If handle_display_prop
2874 pushed the iterator stack, restore the internal state of the bidi
2875 iterator by calling bidi_pop_it same number of times.
2876 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2877 and we are bidi-iterating, don't decrement the iterator position;
2878 instead, set the first_elt flag in the bidi iterator, to produce
2879 the same effect.
2880 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2881 (push_display_prop): xassert that we are iterating a buffer.
2882 (push_it, pop_it): Save and restore paragraph_embedding member.
2883 (handle_single_display_spec, next_overlay_string)
2884 (get_overlay_strings_1, reseat_1, reseat_to_string)
2885 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2886 correctly. Don't assume unibyte strings are not bidi-reordered.
2887 (compute_display_string_pos)
2888 (compute_display_string_end): Fix handling the case of C string.
2889 (push_it, pop_it): Save and restore from_disp_prop_p.
2890 (handle_single_display_spec, push_display_prop): Set the
2891 from_disp_prop_p flag.
2892 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2893 (pop_it): Call iterate_out_of_display_property only if we are
2894 popping after iteration over a string that came from a display
2895 property. Fix a typo in popping stretch info. Add an assertion
2896 for verifying that the iterator position is in sync with the bidi
2897 iterator.
2898 (handle_single_display_spec, get_overlay_strings_1)
2899 (push_display_prop): Fix initialization of paragraph direction for
2900 string when that of the parent object is not yet determined.
2901 (reseat_1): Call bidi_init_it to resync the bidi
2902 iterator with IT's position. (Bug#7616)
2903 (find_row_edges): If ROW->start.pos gives position
2904 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2905 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2906 Reset the from_disp_prop_p flag.
2907 (SAVE_IT, RESTORE_IT): New macros.
2908 (pos_visible_p, face_before_or_after_it_pos)
2909 (back_to_previous_visible_line_start)
2910 (move_it_in_display_line_to, move_it_in_display_line)
2911 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2912 (try_scrolling, redisplay_window, display_line): Use them when
2913 saving a temporary copy of the iterator and restoring it back.
2914 (back_to_previous_visible_line_start, reseat_1)
2915 (init_iterator): Empty the bidi cache "stack".
2916 (move_it_in_display_line_to): If iterator ended up at
2917 EOL, but we never saw any buffer positions smaller than
2918 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2919 motion in bidi-reordered lines.
2920 (move_it_in_display_line_to): Record prev_method and prev_pos
2921 immediately before the call to set_iterator_to_next. Fixes cursor
2922 motion in bidi-reordered lines with stretch glyphs and strings
2923 displayed in margins. (Bug#8133) (Bug#8867)
2924 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2925 TO_CHARPOS.
640c8776
SM
2926 (pos_visible_p): Support positions in bidi-reordered lines.
2927 Save and restore bidi cache.
0bb23927
EZ
2928
2929 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2930 (bidi_paragraph_info): Delete unused struct.
2931 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2932 (bidi_cache_start): New variable.
2933 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2934 to zero.
2935 (bidi_cache_fetch_state, bidi_cache_search)
2936 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2937 (bidi_cache_find, bidi_peek_at_next_level)
2938 (bidi_level_of_next_char, bidi_find_other_level_edge)
2939 (bidi_move_to_visually_next): Compare cache index with
2940 bidi_cache_start rather than with zero.
2941 (bidi_fetch_char): Accept new argument STRING; all callers
2942 changed. Support iteration over a string. Support strings with
2943 display properties. Support unibyte strings. Fix the type of
2944 `len' according to what STRING_CHAR_AND_LENGTH expects.
2945 (bidi_paragraph_init, bidi_resolve_explicit_1)
2946 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2947 (bidi_level_of_next_char, bidi_move_to_visually_next):
2948 Support iteration over a string.
0bb23927
EZ
2949 (bidi_set_sor_type, bidi_resolve_explicit_1)
2950 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2951 can now be zero (for strings); special values 0 and -1 were
2952 changed to -1 and -2, respectively.
2953 (bidi_char_at_pos): New function.
2954 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2955 Call it instead of FETCH_MULTIBYTE_CHAR.
2956 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2957 initialized to valid values.
2958 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2959 values.
2960 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2961 the test for valid cached positions. Fix the logic for looking up
2962 the sentinel state in the cache. GCPRO the Lisp string we are
2963 iterating.
2964 (bidi_push_it, bidi_pop_it): New functions.
2965 (bidi_initialize): Initialize the bidi cache start stack pointer.
2966 (bidi_cache_ensure_space): New function, refactored from part of
2967 bidi_cache_iterator_state. Don't assume the required size is just
2968 one BIDI_CACHE_CHUNK away.
2969 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2970 (bidi_count_bytes, bidi_char_at_pos): New functions.
2971 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2972 always valid if bidi_cache_idx is valid.
2973 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2974 is valid if it's going to be used.
2975 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2976 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2977 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2978 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2979 (bidi_find_other_level_edge, bidi_cache_start_stack):
2980 All variables related to cache indices are now EMACS_INT.
c965adc5 2981
0bb23927
EZ
2982 * dispextern.h (struct bidi_string_data): New structure.
2983 (struct bidi_it): New member `string'. Make flag members be 1-bit
2984 fields, and put them last in the struct.
640c8776
SM
2985 (compute_display_string_pos, compute_display_string_end):
2986 Update prototypes.
0bb23927
EZ
2987 (bidi_push_it, bidi_pop_it): Add prototypes.
2988 (struct iterator_stack_entry): New members bidi_p,
2989 paragraph_embedding, and from_disp_prop_p.
2990 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2991 (bidi_shelve_cache, bidi_unshelve_cache):
2992 Declare prototypes.
0bb23927
EZ
2993
2994 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2995 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2996 and vector-like objects.
2997
2998 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2999 cache around display iteration.
3000
3001 * window.c (Fwindow_end, window_scroll_pixel_based)
3002 (displayed_window_lines, Frecenter): Save and restore the bidi
3003 cache around display iteration.
3004
3bbd2265
LMI
30052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3006
3007 * editfns.c (Fdelete_region): Clarify the use of the named
3008 parameters (bug#6788).
3009
adc47434
MR
30102011-07-14 Martin Rudalics <rudalics@gmx.at>
3011
3012 * indent.c (Fvertical_motion): Set and restore w->pointm when
3013 saving and restoring the window's buffer (Bug#9006).
3014
837c31f8
LMI
30152011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3016
3017 * editfns.c (Fstring_to_char): Clarify just what is returned
3018 (bug#6576). Text by Eli Zaretskii.
3019
ac389d0c
JB
30202011-07-13 Juanma Barranquero <lekktu@gmail.com>
3021
3022 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3023
0be0ce47
EZ
30242011-07-13 Eli Zaretskii <eliz@gnu.org>
3025
3026 * buffer.c (mmap_find): Fix a typo.
3027
cd18e7e3
JB
30282011-07-13 Johan Bockgård <bojohan@gnu.org>
3029
3030 Fix execution of x selection hooks.
3031 * xselect.c (Qx_lost_selection_functions)
3032 (Qx_sent_selection_functions): New vars.
3033 (syms_of_xselect): DEFSYM them.
3034 (x_handle_selection_request): Pass Qx_sent_selection_functions
3035 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3036 (x_handle_selection_clear,x_clear_frame_selections):
3037 Pass Qx_lost_selection_functions rather than
3038 Vx_lost_selection_functions to Frun_hook_with_args.
3039
47ea7f44
PE
30402011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3041
ac389d0c 3042 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3043 The old code sometimes used this field without initializing it.
3044
47ea7f44
PE
3045 * alloc.c (gc_sweep): Don't read past end of array.
3046 In theory, the old code could also have corrupted Emacs internals,
3047 though it'd be very unlikely.
3048
bc985c87
AS
30492011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3050
3051 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3052 argument. (Bug#4026)
bc985c87 3053
0cf34688
LMI
30542011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3055
b3dadd76
LMI
3056 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3057 key" (bug#4257).
3058
0cf34688
LMI
3059 * window.c (Fset_window_start): Doc fix (bug#4199).
3060 (Fset_window_hscroll): Ditto.
3061
270768cd
PE
30622011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3063
077e3dda 3064 Fix minor new problems caught by GCC 4.6.1.
270768cd 3065 * term.c (init_tty): Remove unused local.
490011a6 3066 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3067 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3068 not used otherwise.
270768cd 3069
b1f58454
CY
30702011-07-12 Chong Yidong <cyd@stupidchicken.com>
3071
3072 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3073
22b9578d
LMI
30742011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3075
6e70ab07
LMI
3076 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3077 are the mini-buffer and the echo area (bug#3320).
3078
22b9578d
LMI
3079 * term.c (init_tty): Remove support for supdup, c10 and perq
3080 terminals, which are no longer supported (bug#1482).
3081
8974cc9f
JB
30822011-07-10 Johan Bockgård <bojohan@gnu.org>
3083
3084 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3085
a560d974
JD
30862011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3087
3088 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3089 for non-popups (Bug#3642).
3090
1dae0f0a
AS
30912011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3092
268c2c36 3093 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3094 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3095 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3096 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3097 * data.c (fmod): Likewise.
3098 * dispnew.c (swap_glyphs_in_rows): Likewise.
3099 * emacs.c (memory_warning_signal): Likewise.
3100 * floatfns.c (float_error): Likewise.
3101 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3102 (otf_open, font_otf_capability, generate_otf_features)
3103 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3104 Likewise.
3105 * image.c (pbm_read_file): Likewise.
3106 * indent.c (string_display_width): Likewise.
3107 * intervals.c (check_for_interval, search_for_interval)
3108 (inc_interval_count, count_intervals, root_interval)
3109 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3110 * lread.c (defalias): Likewise.
268c2c36 3111 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3112 * regex.c (set_image_of_range_1, set_image_of_range)
3113 (regex_grow_registers): Likewise.
3114 * sysdep.c (strerror): Likewise.
3115 * termcap.c (valid_filename_p, tprint, main): Likewise.
3116 * tparam.c (main): Likewise.
3117 * unexhp9k800.c (run_time_remap, save_data_space)
3118 (update_file_ptrs, read_header, write_header, calculate_checksum)
3119 (copy_file, copy_rest, display_header): Likewise.
3120 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3121 Likewise.
3122 * xdisp.c (check_it): Likewise.
3123 * xfaces.c (register_color, unregister_color, unregister_colors):
3124 Likewise.
3125 * xfns.c (print_fontset_result): Likewise.
3126 * xrdb.c (member, fatal, main): Likewise.
3127
99033785
PE
31282011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 Fix minor problems found by static checking (Bug#9031).
3131 * chartab.c (char_table_set_range, map_sub_char_table):
3132 Remove unused locals.
3133 (uniprop_table): Now static.
3134 * composite.c (_work_char): Remove unused static var.
3135
9cb2ac56
JB
31362011-07-09 Juanma Barranquero <lekktu@gmail.com>
3137
3138 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3139
f25661f0
JD
31402011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3141
3142 * gtkutil.c (qttip_cb): Remove code without function.
3143
8278c4fe
EZ
31442011-07-09 Eli Zaretskii <eliz@gnu.org>
3145
3146 * w32.c (pthread_sigmask): New stub.
3147
1692ae2d 31482011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3149
8a6ebd58 3150 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3151 sigprocmask is portable only for single-threaded applications, and
3152 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3153 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3154 (LIBES): Use it.
3155 * callproc.c (Fcall_process):
3156 * process.c (create_process):
3157 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3158 Use pthread_sigmask, not sigprocmask.
123403e4 3159
1b854618
JD
31602011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3161
3162 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3163 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3164 wrong (Bug#8591).
3165
3fe4b549
JD
31662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3167
0ce7e563
JD
3168 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3169 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3170 (xg_hide_tooltip): Fix comment.
3171
3fe4b549
JD
3172 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3173 in registerServicesMenuSendTypes.
3174 (validRequestorForSendType): Don't check ns_return_types.
3175
3176 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3177 ns_return_type.
3178
5df75e47
JR
31792011-07-08 Jason Rumney <jasonr@gnu.org>
3180
3181 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3182 frame struct members of non-existent frames (Bug#6284).
3183
699c10bd
JD
31842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3185
4393663b
JD
3186 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3187 variable firstTime not needed on OSX >= 10.6.
3188 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3189 >= 10.5. Use setKnobProportion, setDoubleValue.
3190
3191 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3192 (MAC_OS_X_VERSION_10_5): Define if not defined.
3193 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3194 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3195 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3196
3197 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3198 cString and lossyCString on OSX >= 10.4
3199
3200 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3201 sizeToFit on OSX >= 10.2.
3202
3203 * nsimage.m (allocInitFromFile): Don't use deprecated method
3204 bestRepresentationForDevice on OSX >= 10.6.
3205
3206 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3207 to avoid warning.
3208
3209 * emacs.c: Declare unexec_init_emacs_zone.
3210
a63e0781
JD
3211 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3212
699c10bd
JD
3213 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3214
3215 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3216 on svcsMenu (Bug#8842).
3217
3218 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3219 ns_return_types.
3220 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3221
3222 * nsterm.m (QUTF8_STRING): Declare.
3223 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3224 (validRequestorForSendType): Return type is (id).
3225 Change indexOfObjectIdenticalTo to indexOfObject.
3226 Check if we have local selection before returning self (Bug#8842).
3227 (writeSelectionToPasteboard): Put local selection into paste board
3228 if we have a local selection (Bug#8842).
3229 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3230
3231 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3232 (ns_get_local_selection): Declare.
3233
54e10184
LMI
32342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3235
9888ff71
LMI
3236 * keymap.c (describe_map_tree): Don't insert a double newline at
3237 the end of the buffer (bug#1169) and return whether we inserted
3238 something.
3239
54e10184
LMI
3240 * callint.c (Fcall_interactively): Change "reading args" to
3241 "providing args" to try to clarify what it does (bug#1010).
3242
15fa4783
KH
32432011-07-07 Kenichi Handa <handa@m17n.org>
3244
3245 * composite.c (composition_compute_stop_pos): Ignore a static
3246 composition starting before CHARPOS (Bug#8915).
3247
3248 * xdisp.c (handle_composition_prop): Likewise.
3249
a8815b00
EZ
32502011-07-07 Eli Zaretskii <eliz@gnu.org>
3251
3252 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3253 (Bug#9015)
3254
ef7b981d 32552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3256
3257 * character.h (unicode_category_t): New enum type.
3258
3259 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3260 (Qchar_code_property_table): New variable.
3261 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3262 (UNIPROP_COMPRESSED_FORM_P): New macros.
3263 (char_table_ascii): Uncompress the compressed values.
3264 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3265 Uncompress the compressed values.
ac389d0c 3266 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3267 (char_table_ref_and_range): Uncompress the compressed values.
3268 (sub_char_table_set): New arg is_uniprop. Callers changed.
3269 Uncompress the compressed values.
3270 (sub_char_table_set_range): Args changed. Callers changed.
3271 (char_table_set_range): Adjuted for the above change.
3272 (map_sub_char_table): Delete args default_val and parent. Add arg
3273 top. Give decoded values to a Lisp function.
640c8776 3274 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3275 values to a Lisp function. Gcpro more variables.
3276 (uniprop_table_uncompress)
3277 (uniprop_decode_value_run_length): New functions.
3278 (uniprop_decoder, uniprop_decoder_count): New variables.
3279 (uniprop_get_decoder, uniprop_encode_value_character)
3280 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3281 New functions.
3282 (uniprop_encoder, uniprop_encoder_count): New variables.
3283 (uniprop_get_encoder, uniprop_table)
3284 (Funicode_property_table_internal, Fget_unicode_property_internal)
3285 (Fput_unicode_property_internal): New functions.
3286 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3287 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3288 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3289 char-code-property-alist.
3290
640c8776 3291 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3292 Vunicode_category_table.
3293
640c8776 3294 * font.c (font_range): Adjust for the change of
c805dec0
KH
3295 Vunicode_category_table.
3296
76b397fb
DN
32972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3298
3299 * m/iris4d.h: Remove file, move contents ...
3300 * s/irix6-5.h: ... here.
3301
22b4128e
PE
33022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3305 * alloc.c (mark_buffer):
3306 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3307 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3308 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3309 This isn't true in general, and it's particularly not true
3310 if Emacs is configured with --with-wide-int.
3311 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3312 New macros, used in the buffer.c change.
3313
869795d6
JD
33142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3315
3316 * xsettings.c: Use both GConf and GSettings if both are available.
3317 (store_config_changed_event): Add comment.
3318 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3319 (store_tool_bar_style_changed): New functions.
5e617bc2 3320 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3321 (struct xsettings): Move font inside HAVE_XFT.
3322 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3323 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3324 Move inside HAVE_XFT.
640c8776 3325 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3326 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3327 also.
3328 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3329 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3330 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3331 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3332 (parse_settings): Move check for font inside HAVE_XFT.
3333 (read_settings, apply_xft_settings): Add comment.
3334 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3335 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3336 call store_font_name_changed.
3337 (xft_settings_event): Add comment.
3338 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3339 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3340 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3341 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3342 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3343 (xsettings_get_system_font, xsettings_get_system_normal_font):
3344 Add comment.
869795d6 3345
d8ed26bd
PE
33462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3347
3348 Random fixes. E.g., (random) never returned negative values.
3349 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3350 subseconds part to the entropy, as that's a bit more random.
3351 Prefer signed to unsigned, since the signedness doesn't matter and
3352 in general we prefer signed. When given a limit, use a
3353 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3354 latter isn't right if USE_2_TAGS_FOR_INTS.
3355 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3356 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3357
cabf1cac
SM
33582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3359
3360 * textprop.c (text_property_stickiness):
3361 Obey Vtext_property_default_nonsticky.
3362 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3363 * w32fns.c (syms_of_w32fns):
3364 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3365
6e9b2be9
PE
33662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3369 This is more efficient than Ffile_directory_p and avoids a minor race.
3370
90186c68
LMI
33712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3372
7c301272
LMI
3373 * buffer.c (Foverlay_put): Say what the return value is
3374 (bug#7835).
3375
c4f2d8d4
LMI
3376 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3377 is a directory before asking whether to use the file name
3378 (bug#7564).
ad637907
LMI
3379 (barf_or_query_if_file_exists): Make the "File is a directory"
3380 error be more correct.
c4f2d8d4 3381
90186c68
LMI
3382 * fns.c (Frequire): Remove the mention of the .gz files, since
3383 that's installation-specific, but keep the mention of
3384 `get-load-suffixes'.
3385
da64016e
PE
33862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3389 Report string overflow if the output is too long.
3390
7d47b580
JB
33912011-07-04 Juanma Barranquero <lekktu@gmail.com>
3392
a555cb87
JB
3393 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3394 (syms_of_gnutls): Remove duplicate DEFSYM for
3395 Qgnutls_bootprop_verify_hostname_error, an error for
3396 Qgnutls_bootprop_verify_error (which is no longer used).
3397
7d47b580
JB
3398 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3399 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3400 Also (re)move comments that are misplaced or no longer relevant.
3401
1e49bfab
LMI
34022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
3404 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3405
1485f4c0
CY
34062011-07-03 Chong Yidong <cyd@stupidchicken.com>
3407
3408 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3409 and background color parameters if they have been changed.
3410
a9ab721e
LMI
34112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3412
3413 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3414
cf7cff57
PE
34152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3416
2e13213d
PE
3417 * xsettings.c (SYSTEM_FONT): Define only when used.
3418 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3419
cf7cff57
PE
3420 * keymap.c (access_keymap_1): Now static.
3421
7a8e04f7
CY
34222011-07-02 Chong Yidong <cyd@stupidchicken.com>
3423
3424 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3425 leave any prefix arg for the up event (Bug#1586).
3426
61352f62
LMI
34272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3428
69bb1ef7
LMI
3429 * lread.c (syms_of_lread): Mention single symbols defined by
3430 `defvar' or `defconst' (bug#7154).
3431
61352f62 3432 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3433 (Frequire): Mention get-load-suffixes.
61352f62 3434
28545e04
MR
34352011-07-02 Martin Rudalics <rudalics@gmx.at>
3436
3437 * window.h (window): Remove clone_number slot.
3438 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3439 Remove.
3440 (make_parent_window, make_window, saved_window)
3441 (Fset_window_configuration, save_window_save): Don't deal with
3442 clone numbers.
3443 * buffer.c (Qclone_number): Remove declaration.
3444 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3445
3349e122
SM
34462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3447
3448 Add multiple inheritance to keymaps.
3449 * keymap.c (Fmake_composed_keymap): New function.
3450 (Fset_keymap_parent): Simplify.
3451 (fix_submap_inheritance): Remove.
3452 (access_keymap_1): New function extracted from access_keymap to handle
3453 embedded parents and handle lists of maps.
3454 (access_keymap): Use it.
3455 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3456 (Fcopy_keymap): Handle embedded parents.
3457 (Fcommand_remapping, define_as_prefix): Simplify.
3458 (Fkey_binding): Simplify.
3459 (syms_of_keymap): Move minibuffer-local-completion-map,
3460 minibuffer-local-filename-completion-map,
3461 minibuffer-local-must-match-map, and
3462 minibuffer-local-filename-must-match-map to Elisp.
3463 (syms_of_keymap): Defsubr make-composed-keymap.
3464 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3465 (parse_menu_item): Trivial simplification.
3466
3279eb87
GM
34672011-07-01 Glenn Morris <rgm@gnu.org>
3468
3469 * Makefile.in (SETTINGS_LIBS): Fix typo.
3470
4550efdf
KI
34712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3472
3473 * coding.c (Fencode_coding_string): Record the last coding system
3474 used, as the function doc string says (bug#8738).
3475
0949d2b6
JD
34762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3477
3478 * xsettings.c (store_monospaced_changed): Take new font as arg and
3479 check for change against current_mono_font.
3480 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3481 (emacs_settings_constructor, emacs_settings_get_property)
3482 (emacs_settings_set_property, emacs_settings_class_init)
3483 (emacs_settings_init, gsettings_obj): Remove.
3484 (something_changedCB): New function for HAVE_GSETTINGS.
3485 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3486 with value as argument.
3487 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3488 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3489 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3490 "changed".
3491
3492 * xgselect.c: Add defined (HAVE_GSETTINGS).
3493 (xgselect_initialize): Ditto.
3494
3495 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3496 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3497 xg_select.
3498
bbc6b304
PE
34992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 * eval.c (struct backtrace): Simplify and port the data structure.
3502 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3503 signed bit field, as this assumption is not portable and it makes
3504 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3505 "char debug_on_exit : 1" as this is not portable either; instead,
3506 use the portable "unsigned int debug_on_exit : 1". Remove unused
3507 member evalargs. Remove obsolete comments about cc bombing out.
3508
9851bfc5
JD
35092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3510
51bb811f 3511 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3512 Let HAVE_GSETTINGS override HAVE_GCONF.
3513 (store_monospaced_changed): New function.
3514 (EMACS_SETTINGS): A new type derived from GObject to handle
3515 GSettings notifications.
3516 (emacs_settings_constructor, emacs_settings_get_property)
3517 (emacs_settings_set_property, emacs_settings_class_init):
3518 New functions.
3519 (gsettings_client, gsettings_obj): New variables.
3520 (GSETTINGS_SCHEMA): New define.
3521 (something_changedCB): Call store_monospaced_changed.
3522 (init_gsettings): New function.
3523 (xsettings_initialize): Call init_gsettings.
3524 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3525 to NULL.
3526
640c8776 3527 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3528 GCONF_CFLAGS/LIBS.
3529
5386012d
MR
35302011-06-29 Martin Rudalics <rudalics@gmx.at>
3531
3532 * window.c (resize_root_window, grow_mini_window)
3533 (shrink_mini_window): Rename Qresize_root_window to
3534 Qwindow_resize_root_window and Qresize_root_window_vertically to
3535 Qwindow_resize_root_window_vertically.
3536
f13e0b08
PE
35372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3538
3539 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3540
94515237
JB
35412011-06-27 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * makefile.w32-in: Redesign dependencies so they reflect more
3544 clearly which files are directly included by each source file,
3545 and not through other includes.
3546
e43b6e43
MR
35472011-06-27 Martin Rudalics <rudalics@gmx.at>
3548
3549 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3550 (sort_overlays, overlay_strings): When an overlay's clone number
3551 matches the window's clone number process the overlay even if
3552 the overlay's window property doesn't match the current window.
3553
d68443dc
MR
3554 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3555 (Fwindow_hchild): Rename to Fwindow_left_child.
3556 (Fwindow_next): Rename to Fwindow_next_sibling.
3557 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3558 (resize_window_check): Rename to window_resize_check.
3559 (resize_window_apply): Rename to window_resize_apply.
3560 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3561 (Fdelete_other_windows_internal, resize_frame_windows)
3562 (Fsplit_window_internal, Fdelete_window_internal)
3563 (grow_mini_window, shrink_mini_window)
3564 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3565
c7e73be5
JD
35662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3567
3568 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3569 (emacs_fixed_set_min_size): Remove.
3570 (emacs_fixed_new): Take frame as argument.
3571
3572 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3573 (_EmacsFixedPrivate): Remove minwidth/height.
3574 Add struct frame *f.
3575 (emacs_fixed_init): Initialize priv->f.
3576 (get_parent_class, emacs_fixed_set_min_size): Remove.
3577 (emacs_fixed_new): Set priv->f to argument.
3578 (emacs_fixed_get_preferred_width)
3579 (emacs_fixed_get_preferred_height): Use min_width/height from
3580 frames size_hint to set minimum and natural (Bug#8919).
3581 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3582 and use min_width/height from frames size_hint to set
3583 min_width/height (Bug#8919).
3584
3585 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3586 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3587 Fix indentation.
c7e73be5 3588
cf99dcf8
EZ
35892011-06-26 Eli Zaretskii <eliz@gnu.org>
3590
3591 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3592 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3593 called at ZV.
3594
029529ac
CY
35952011-06-26 Chong Yidong <cyd@stupidchicken.com>
3596
3597 * process.c (wait_reading_process_output): Bypass select if
3598 waiting for a cell while ignoring keyboard input, and input is
3599 pending. Suggested by Jan Djärv (Bug#8869).
3600
7a7ef429
PE
36012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3602
3603 Use gnulib's dup2 module instead of rolling our own.
3604 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3605
11fdef7d 36062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3607
3608 * dispnew.c (scrolling_window): Before scrolling, turn off a
3609 mouse-highlight in the window being scrolled.
3610
cd3520a4
JB
36112011-06-24 Juanma Barranquero <lekktu@gmail.com>
3612
3613 Move DEFSYM to lisp.h and use everywhere.
3614
3615 * character.h (DEFSYM): Move declaration...
3616 * lisp.h (DEFSYM): ...here.
3617
3618 * gnutls.c:
3619 * minibuf.c:
3620 * w32menu.c:
3621 * w32proc.c:
3622 * w32select.c: Don't include character.h.
3623
3624 * alloc.c (syms_of_alloc):
3625 * buffer.c (syms_of_buffer):
3626 * bytecode.c (syms_of_bytecode):
3627 * callint.c (syms_of_callint):
3628 * casefiddle.c (syms_of_casefiddle):
3629 * casetab.c (init_casetab_once):
3630 * category.c (init_category_once, syms_of_category):
3631 * ccl.c (syms_of_ccl):
3632 * cmds.c (syms_of_cmds):
3633 * composite.c (syms_of_composite):
3634 * dbusbind.c (syms_of_dbusbind):
3635 * dired.c (syms_of_dired):
3636 * dispnew.c (syms_of_display):
3637 * doc.c (syms_of_doc):
3638 * editfns.c (syms_of_editfns):
3639 * emacs.c (syms_of_emacs):
3640 * eval.c (syms_of_eval):
3641 * fileio.c (syms_of_fileio):
3642 * fns.c (syms_of_fns):
3643 * frame.c (syms_of_frame):
3644 * fringe.c (syms_of_fringe):
3645 * insdel.c (syms_of_insdel):
3646 * keymap.c (syms_of_keymap):
3647 * lread.c (init_obarray, syms_of_lread):
3648 * macros.c (syms_of_macros):
3649 * msdos.c (syms_of_msdos):
3650 * print.c (syms_of_print):
3651 * process.c (syms_of_process):
3652 * search.c (syms_of_search):
3653 * sound.c (syms_of_sound):
3654 * syntax.c (init_syntax_once, syms_of_syntax):
3655 * terminal.c (syms_of_terminal):
3656 * textprop.c (syms_of_textprop):
3657 * undo.c (syms_of_undo):
3658 * w32.c (globals_of_w32):
3659 * window.c (syms_of_window):
3660 * xdisp.c (syms_of_xdisp):
3661 * xfaces.c (syms_of_xfaces):
3662 * xfns.c (syms_of_xfns):
3663 * xmenu.c (syms_of_xmenu):
3664 * xsettings.c (syms_of_xsettings):
3665 * xterm.c (syms_of_xterm): Use DEFSYM.
3666
4228cf16
TZ
36672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3668
cd3520a4 3669 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3670
7fcccf1e
PE
36712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3672
7efb4e0e
PE
3673 Integer and buffer overflow fixes (Bug#8873).
3674
ff5844ad
PE
3675 * print.c (printchar, strout): Check for string overflow.
3676 (PRINTPREPARE, printchar, strout):
3677 Don't set size unless allocation succeeds.
3678
90532f02
PE
3679 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3680 for sizes. Check for string overflow more accurately.
3681 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3682
6d84508d
PE
3683 * macros.c: Integer and buffer overflow fixes.
3684 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3685 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3686 Use ptrdiff_t, not int, for sizes.
3687 Don't increment bufsize until after realloc succeeds.
3688 Check for size-calculation overflow.
3689 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3690
437b2cb4
PE
3691 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3692
8b9ac8b4
PE
3693 * lread.c: Integer overflow fixes.
3694 (read_integer): Radix is now EMACS_INT, not int,
3695 to improve quality of diagnostics for out-of-range radices.
3696 Calculate buffer size correctly for out-of-range radices.
3697 (read1): Check for integer overflow in radices, and in
3698 read-circle numbers.
82cb60d3
PE
3699 (read_escape): Avoid int overflow.
3700 (Fload, openp, read_buffer_size, read1)
3701 (substitute_object_recurse, read_vector, read_list, map_obarray):
3702 Use ptrdiff_t, not int, for sizes.
3703 (read1): Use EMACS_INT, not int, for sizes.
20270765 3704 Check for size overflow.
8b9ac8b4 3705
7fcccf1e
PE
3706 * image.c (cache_image): Check for size arithmetic overflow.
3707
bfbbd7e7
PE
3708 * lread.c: Integer overflow issues.
3709 (saved_doc_string_size, saved_doc_string_length)
3710 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3711 Now ptrdiff_t, not int.
3712 (read1): Don't assume doc string length fits in int. Check for
3713 out-of-range doc string lengths.
3714 (read_list): Don't assume file position fits in int.
39019e54 3715 (read_escape): Check for hex character overflow.
bfbbd7e7 3716
4e323265
LL
37172011-06-22 Leo Liu <sdl.web@gmail.com>
3718
3719 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3720 Move to minibuffer.el.
3721
85fece3e
PE
37222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3723
20b84ce9 3724 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3725 The following patches are for when GLYPH_DEBUG && !XASSERT.
3726 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3727 * dispnew.c (flush_stdout):
3728 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3729 Mark as externally visible.
3730 * dispnew.c (check_window_matrix_pointers): Now static.
3731 * dispnew.c (window_to_frame_vpos):
3732 * xfns.c (unwind_create_frame):
3733 * xterm.c (x_check_font): Remove unused local.
3734 * scroll.c (CHECK_BOUNDS):
3735 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3736 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3737 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3738 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3739 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3740 Now static.
3741 (debug_method_add): Use va_list and vsprintf rather than relying
3742 on undefined behavior with wrong number of arguments.
3743 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3744 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3745 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3746 since we're not interested in debugging glyphs with old libraries.
3747 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3748 GCC 4.6.0's static checking.
3749
0766b489
PE
37502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3751
31fd4b32
PE
3752 Integer overflow and signedness fixes (Bug#8873).
3753 A few related buffer overrun fixes, too.
3754
b79e8648
PE
3755 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3756
0766b489
PE
3757 * dispextern.h (struct face.stipple):
3758 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3759 (x_bitmap_mask, x_allocate_bitmap_record)
3760 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3761 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3762 (x_create_bitmap_from_xpm_data):
3763 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3764 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3765 (.bitmaps_last):
3766 * xfaces.c (load_pixmap):
3767 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3768 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3769 (.bitmaps_last, struct x_output.icon_bitmap):
3770 Use ptrdiff_t, not int, for bitmap indexes.
3771 (x_allocate_bitmap_record): Check for size overflow.
3772 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3773
b081724f
PE
3774 Use ptrdiff_t, not int, for overlay counts.
3775 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3776 * editfns.c (overlays_around, get_pos_property):
3777 * textprop.c (get_char_property_and_overlay):
3778 * xdisp.c (next_overlay_change, note_mouse_highlight):
3779 * xfaces.c (face_at_buffer_position):
21514da7
PE
3780 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3781 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3782 (Fnext_overlay_change, Fprevious_overlay_change)
3783 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3784 Use ptrdiff_t, not int, for sizes.
21514da7 3785 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3786
3de73e5e
PE
3787 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3788
2606c57b
PE
3789 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3790 (x_session_initialize): Do not assume string length fits in int.
3791
aaafe47a
PE
3792 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3793 This is unlikely, but can occur if DPI is outlandish.
3794
2674ddc8 3795 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3796 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3797
28154962
PE
3798 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3799 * xrdb.c (magic_file_p, search_magic_path):
3800 Omit last arg SUFFIX; it was always 0. All callers changed.
3801 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3802
7de51af5
PE
3803 * xfont.c (xfont_match): Avoid need for strlen.
3804
25ed6cc3
PE
3805 * xfns.c: Don't assume strlen fits in int.
3806 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3807
4eab31dd
PE
3808 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3809 not unsigned long, as we prefer signed integers. All callers changed.
3810 Detect integer overflow in repeat count.
3811 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3812 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3813
171e2a58
PE
3814 * termcap.c: Don't assume sizes fit in int and never overflow.
3815 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3816 (gobble_line): Check for size-calculation overflow.
3817
ad39faca 3818 * minibuf.c (Fread_buffer):
6e5bb2dc 3819 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3820 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3821 Don't assume string length fits in int.
3822
52c61c22 3823 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3824 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3825
b5b8c9e5
PE
3826 * font.c: Don't assume string length fits in int.
3827 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3828 Use ptrdiff_t, not int.
ccd6111c
PE
3829 (font_intern_prop): Don't assume string length fits in int.
3830 Don't assume integer property fits in fixnum.
3831 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3832
882f0d81 3833 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3834 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3835 Reformulate so as not to need the command string.
3836 Invoke gzip -cd rather than gunzip, as it's more portable.
3837 (lock_info_type, lock_file_1, lock_file):
3838 Don't assume pid_t and time_t fit in unsigned long.
3839 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3840 (current_lock_owner): Prefer signed type for sizes.
3841 Use memcpy, not strncpy, where memcpy is what is really wanted.
3842 Don't assume (via atoi) that time_t and pid_t fit in int.
3843 Check for time_t and/or pid_t out of range, e.g., via a network share.
3844 Don't alloca where an auto var works fine.
3845
93f4cf88
PE
3846 * fileio.c: Fix some integer overflow issues.
3847 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3848 Don't assume string length fits in int.
3849 (directory_file_name): Don't assume string length fits in long.
3850 (make_temp_name): Don't assume pid fits in int, or that its print
3851 length is less than 20.
3852
f3e92b69
PE
3853 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3854
1bfdaf10
PE
3855 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3856
35016e9a
PE
3857 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3858
3d1e65a1
PE
3859 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3860 We prefer signed integers, even for size calculations.
3861
0b963a93
PE
3862 * emacs.c: Don't assume string length fits in 'int'.
3863 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3864 (main): Don't invoke strlen when not needed.
3865
573f4b54
PE
3866 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3867 (XD_DEBUG_MESSAGE): Don't waste a byte.
3868
989f33ba
PE
3869 * callproc.c (getenv_internal_1, getenv_internal)
3870 (Fgetenv_internal):
965d34eb
PE
3871 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3872
e4d29b33
PE
3873 * lread.c (invalid_syntax): Omit length argument.
3874 All uses changed. This doesn't fix a bug, but it simplifies the
3875 code away from its former Hollerith-constant appearance, and it's
3876 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3877 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3878
eb49b136
PE
3879 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3880 This didn't break anything, but it didn't help either.
3881 It's confusing to put a bogus integer in a place where the actual
3882 value does not matter.
9f62aeb1 3883 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3884 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3885
15375a22
PE
3886 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3887 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3888 implementation.
b61cc01c
PE
3889 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3890 We prefer signed types, and the value cannot exceed the EMACS_INT
3891 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3892 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3893 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3894 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3895
53b2623d
PE
3896 * indent.c (sane_tab_width): New function.
3897 (current_column, scan_for_column, Findent_to, position_indentation)
3898 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3899 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3900
51cab52b 3901 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3902
f2ed8a70
PE
3903 * lisp.h (lint_assume): New macro.
3904 * composite.c (composition_gstring_put_cache):
3905 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3906
abe80cc6
PE
3907 * editfns.c, insdel.c:
3908 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3909
b02c740e
PE
3910 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3911
ebc96716
PE
3912 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3913
b4e50fa0 3914 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3915 Use much-faster test for byte-length change.
311d5d7c 3916 Don't assume string byte-length fits in 'int'.
a4cf38e4 3917 Check that character arg fits in 'int'.
85461888 3918 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3919
c0c1ee9f
PE
3920 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3921
a498d7f4
PE
3922 * fns.c (concat): Catch string overflow earlier.
3923 Do not rely on integer wraparound.
3924
51cab52b
PE
3925 * dispextern.h (struct it.overlay_strings_charpos)
3926 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3927 * xdisp.c (forward_to_next_line_start)
3928 (back_to_previous_visible_line_start)
3929 (reseat_at_next_visible_line_start, next_element_from_buffer):
3930 Don't arbitrarily truncate the value of 'selective' to int.
3931
76031fad
PE
3932 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3933
5eb55db9
PE
3934 * composite.c: Don't truncate sizes to 'int'.
3935 (composition_gstring_p, composition_reseat_it)
3936 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3937 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3938 not EMACS_UINT, for indexes.
5eb55db9 3939
0703a717
PE
3940 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3941
d6202519
PE
3942 * buffer.c: Include <verify.h>.
3943 (struct sortvec.priority, struct sortstr.priority):
8961a454 3944 Now EMACS_INT, not int.
c20998a7 3945 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3946 (struct sortstr.size, record_overlay_string)
3947 (struct sortstrlist.size, struct sortlist.used):
3948 Don't truncate size to int.
3949 (record_overlay_string): Check for size-calculation overflow.
d6202519 3950 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3951
d5a19415
JM
39522011-06-22 Jim Meyering <meyering@redhat.com>
3953
029529ac 3954 Don't leak an XBM-image-sized buffer
d5a19415
JM
3955 * image.c (xbm_load): Free the image buffer after using it.
3956
a9041e6c
PE
39572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 Port to Sun C.
3960 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3961 that Sun C diagnosed.
3962 * fns.c (secure_hash): Fix pointer signedness issue.
3963 * intervals.c (static_offset_intervals): New function.
3964 (offset_intervals): Use it.
3965
7f3f739f
LL
39662011-06-21 Leo Liu <sdl.web@gmail.com>
3967
3968 * deps.mk (fns.o):
3969 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3970 sha512.h.
3971
3972 * fns.c (secure_hash): Rename from crypto_hash_function and change
3973 the first arg to accept symbols.
5b66d427 3974 (Fsecure_hash): New primitive.
7f3f739f
LL
3975 (syms_of_fns): New symbols.
3976
76147d94
DD
39772011-06-20 Deniz Dogan <deniz@dogan.se>
3978
3979 * process.c (Fset_process_buffer): Clarify return value in
3980 docstring.
3981
7d7d0045
CY
39822011-06-18 Chong Yidong <cyd@stupidchicken.com>
3983
3984 * dispnew.c (add_window_display_history): Use BVAR.
3985
3986 * xdisp.c (debug_method_add): Use BVAR.
3987 (check_window_end, dump_glyph_matrix, dump_glyph)
3988 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3989
3990 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3991 Likewise.
3992
3993 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3994 check till after the cache is created in init_frame_faces.
3995
ff2bc410
SM
39962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3997
3998 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3999
28177add
PE
40002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4001
dd3482fe
PE
4002 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4003 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4004 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4005
393d71f3 4006 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4007 * fileio.c (Finsert_file_contents):
4008 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4009 Remove the old (too-loose) buffer overflow checks.
4010 They weren't needed, since make_gap checks for buffer overflow.
4011 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4012 The old code merely checked for Emacs fixnum overflow, and relied
4013 on undefined (wraparound) behavior. The new code avoids undefined
4014 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4015
2e6813b0 4016 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4017 Tune. Don't use wider integers than needed. Don't use alloca.
4018 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4019
599a9e4f
PE
4020 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4021
99561444
PE
4022 * insdel.c, lisp.h (buffer_overflow): New function.
4023 (insert_from_buffer_1, replace_range, replace_range_2):
4024 * insdel.c (make_gap_larger):
4025 * editfns.c (Finsert_char):
4026 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4027
28177add
PE
4028 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4029
e69dafad
PE
40302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4031
a7af7fde 4032 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4033
b1c46f02
PE
4034 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4035 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4036
e69dafad
PE
4037 * fileio.c: Don't assume EMACS_INT fits in off_t.
4038 (emacs_lseek): New static function.
4039 (Finsert_file_contents, Fwrite_region): Use it.
4040 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4041
566684ea
PE
4042 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4043
e6966cd6
PE
4044 * fns.c: Don't overflow int when computing a list length.
4045 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4046 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4047 truncation on 64-bit hosts. Check for QUIT every
4048 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4049 faster and is responsive enough.
4050 (Flength): Report an error instead of overflowing an integer.
4051 (Fsafe_length): Return a float if the value is not representable
4052 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4053 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4054 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4055
dd0b0efb
PE
4056 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4057 (header_size, word_size): New constants.
4058 (allocate_vectorlike): Don't check size overflow here.
4059 (allocate_vector): Check it here instead, since this is the only
4060 caller of allocate_vectorlike that could cause overflow.
4061 Check that the new vector's length is representable as a fixnum.
4062
86fe5cfe
PE
4063 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4064 The previous code was bogus. For example, next_almost_prime (32)
4065 returned 39, which is undesirable as it is a multiple of 3; and
4066 next_almost_prime (24) returned 25, which is a multiple of 5 so
4067 why was the code bothering to check for multiples of 7?
4068
80e88859
PE
4069 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4070
4a2f0ad6
PE
4071 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4072
f66c7cf8
PE
4073 Variadic C functions now count arguments with ptrdiff_t.
4074 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4075 Back then I didn't know that the Emacs coding style prefers signed int.
4076 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4077 were being counted with int, which may truncate counts on 64-bit
4078 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4079 * lisp.h (struct Lisp_Subr.function.aMANY)
4080 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4081 Arg counts are now ptrdiff_t, not size_t.
4082 All variadic functions and their callers changed accordingly.
4083 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4084 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4085 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4086 * callint.c (Fcall_interactively): Check arg count for overflow,
4087 to avoid potential buffer overrun. Use signed char, not 'int',
4088 for 'varies' array, so that we needn't bother to check its size
4089 calculation for overflow.
4090 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4091 * eval.c (apply_lambda):
4092 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4093 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4094 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4095
a1759b76
PE
4096 * callint.c (Fcall_interactively): Don't use index var as event count.
4097
d96be9fc
PE
4098 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4099 * mem-limits.h (SIZE): Remove; no longer used.
4100
a690a978 4101 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4102
578c21e6
PE
4103 Remove unnecessary casts.
4104 * xterm.c (x_term_init):
4105 * xfns.c (x_set_border_pixel):
4106 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4107 These aren't needed now that we assume ANSI C.
4108
96f53c6c
PE
4109 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4110 It's more likely to cause problems (due to unsigned overflow)
4111 than to cure them.
4112
83c77d31
PE
4113 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4114
ee2079f1
PE
4115 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4116
6da65536
PE
4117 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4118
7147c4a4
PE
4119 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4120
193e32d9
PE
4121 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4122
e5533da6
PE
4123 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4124
9910e595
PE
4125 GLYPH_CODE_FACE returns EMACS_INT, not int.
4126 * dispextern.h (merge_faces):
4127 * xfaces.c (merge_faces):
01103c44
PE
4128 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4129 Don't assume EMACS_INT fits in int.
9910e595 4130
2638320e
PE
4131 * character.h (CHAR_VALID_P): Remove unused parameter.
4132 * fontset.c, lisp.h, xdisp.c: All uses changed.
4133
045eb8d9
PE
4134 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4135
c1f134b5
PE
4136 * fns.c (concat): Minor tuning based on overflow analysis.
4137 This doesn't fix any bugs. Use int to hold character, instead
4138 of constantly refetching from Emacs object. Use XFASTINT, not
4139 XINT, for value known to be a character. Don't bother comparing
4140 a single byte to 0400, as it's always less.
4141
395fcb93 4142 * floatfns.c (Fexpt):
327eeec8
PE
4143 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4144
abbd3d23
PE
4145 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4146 for characters.
4147
684a03ef
PE
4148 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4149
0fed43f3
PE
4150 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4151 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4152 incorrectly succeed when S was a string, because 4294967386 was
4153 truncated before it was used.
4154
8fd02eb7
PE
4155 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4156 Otherwise, an out-of-range integer could cause undefined behavior
4157 on a 64-bit host.
4158
f8c86b69
PE
4159 * composite.c: Use int, not EMACS_INT, for characters.
4160 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4161 EMACS_INT, for values that are known to be in character range.
4162 This doesn't fix any bugs but is the usual style inside Emacs and
4163 may generate better code on 32-bit machines.
4164
34206dd2
PE
4165 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4166 This is for reasons similar to the recent CHAR_STRING fix.
4167 * charset.c (Fencode_char): Check that character arg is actually
4168 a character. Pass an int to ENCODE_CHAR.
4169 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4170 wider than 'int', as a compile-time check to prevent future regressions
4171 in this area.
4172
c5958d4c 4173 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4174
4175 Make sure a 64-bit char is never passed to CHAR_STRING.
4176 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4177 by silently ignoring the top 32 bits, allowing some values
4178 that were far too large to be valid characters.
4179 * character.h: Include <verify.h>.
4180 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4181 arguments are no wider than unsigned, as a compile-time check
4182 to prevent future regressions in this area.
4183 * data.c (Faset):
01103c44 4184 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4185 (Fsubst_char_in_region):
4186 * fns.c (concat):
4187 * xdisp.c (decode_mode_spec_coding):
4188 Adjust to CHAR_STRING's new requirement.
4189 * editfns.c (Finsert_char, Fsubst_char_in_region):
4190 * fns.c (concat): Check that character args are actually
4191 characters. Without this test, these functions did the wrong
4192 thing with wildly out-of-range values on 64-bit hosts.
4193
d37ca623
PE
4194 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4195 These casts should not be needed on 32-bit hosts, either.
4196 * keyboard.c (read_char):
4197 * lread.c (Fload): Remove casts to unsigned.
4198
ea204efb
PE
4199 * lisp.h (UNSIGNED_CMP): New macro.
4200 This fixes comparison bugs on 64-bit hosts.
4201 (ASCII_CHAR_P): Use it.
4202 * casefiddle.c (casify_object):
01103c44 4203 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4204 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4205 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4206 * dispextern.h (FACE_FROM_ID):
4207 * keyboard.c (read_char): Use UNSIGNED_CMP.
4208
41cb286c
PE
4209 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4210 not to EMACS_INT, to avoid GCC warning.
4211
4a1b9832
PE
4212 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4213
55daad71
PE
4214 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4215 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4216 isn't needed on 32-bit machines.
8f95c75c 4217
01103c44
PE
4218 * buffer.c (Fgenerate_new_buffer_name):
4219 Use EMACS_INT for count, not int.
0ceccced 4220 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4221
4222 * data.c (Qcompiled_function): Now static.
4223
c6f072e7
PE
4224 * window.c (window_body_lines): Now static.
4225
20ce5912
PE
4226 * image.c (gif_load): Rename local to avoid shadowing.
4227
9c4c5f81
PE
4228 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4229 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4230 * alloc.c (make_save_value): Integer argument is now of type
4231 ptrdiff_t, not int.
4232 (mark_object): Use ptrdiff_t, not int.
4233 * lisp.h (pD): New macro.
4234 * print.c (print_object): Use it.
4235
c0c5c8ae
PE
4236 * alloc.c: Use EMACS_INT, not int, to count objects.
4237 (total_conses, total_markers, total_symbols, total_vector_size)
4238 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4239 (total_free_floats, total_floats, total_free_intervals)
4240 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4241 Now EMACS_INT, not int. All uses changed.
4242 (Fgarbage_collect): Compute overall total using a double, so that
4243 integer overflow is less likely to be a problem. Check for overflow
4244 when converting back to an integer.
5a25e253
PE
4245 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4246 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4247 These were 'int' variables that could overflow on 64-bit hosts;
4248 they were never used, so remove them instead of repairing them.
211a0b2a 4249 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4250 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4251 Previously, this ceilinged at INT_MAX, but that doesn't work on
4252 64-bit machines.
e46bb31a 4253 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4254
c78baabf 4255 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4256 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4257 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4258 when a (possibly-narrower) signed value would do just as well.
4259 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4260
c9d624c6
PE
4261 * alloc.c: Catch some string size overflows that we were missing.
4262 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4263 for convenience in STRING_BYTES_MAX.
4264 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4265 The definition here is exact; the one in lisp.h was approximate.
4266 (allocate_string_data): Check for string overflow. This catches
4267 some instances we weren't catching before. Also, it catches
4268 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4269 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4270 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4271
c9d624c6
PE
4272 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4273 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4274 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4275
353032ce
PE
4276 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4277
2bccce07
PE
4278 * alloc.c (Fmake_string): Check for out-of-range init.
4279
0ac30604
SM
42802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4281
4282 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4283
c195f2de
JD
42842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4285
4286 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4287 xg_get_default_scrollbar_width.
4288
4289 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4290 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4291 (style_changed_cb): Call update_theme_scrollbar_width and call
4292 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4293 all frames (Bug#8505).
4294 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4295 Call gtk_window_set_resizable if HAVE_GTK3.
4296 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4297 and height if HAVE_GTK3 (Bug#8505).
4298 (scroll_bar_width_for_theme): New variable.
4299 (update_theme_scrollbar_width): New function.
4300 (xg_get_default_scrollbar_width): Move code to
4301 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4302 (xg_initialize): Call update_theme_scrollbar_width.
4303
4304 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4305
4306 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4307
e10ac9f1
MR
43082011-06-12 Martin Rudalics <rudalics@gmx.at>
4309
4310 * frame.c (make_frame): Call other_buffer_safely instead of
4311 other_buffer.
4312
4313 * window.c (temp_output_buffer_show): Call display_buffer with
4314 second argument Vtemp_buffer_show_specifiers and reset latter
4315 immediately after the call.
4316 (Vtemp_buffer_show_specifiers): New variable.
4317 (auto_window_vscroll_p, next_screen_context_lines)
4318 (Vscroll_preserve_screen_position): Remove leading asterisks from
4319 doc-strings.
4320
2d3c217e 43212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4322
7b7f97e8 4323 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4324 * buffer.c (Qclone_number): Remove for now, as it's unused.
4325 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4326 (record_buffer): Remove unused local.
4327 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4328 (set_frame_buffer_list): Remove; unused.
4329 * frame.h (other_visible_frames): Remove decl.
4330 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4331 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4332 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4333 if HAVE_GPM.
4334 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4335 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4336 Define only if HAVE_GPM.
4337 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4338 (update_hints_inhibit): Remove; never set. All uses removed.
4339 * widgetprv.h (emacsFrameClassRec): Remove decl.
4340 * window.c (delete_deletable_window): Now returns void, since it
4341 wasn't returning anything.
4342 (compare_window_configurations): Remove unused locals.
4343 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4344 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4345 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4346 the same widths as pointers. This follows up on the 2011-05-06 patch.
4347 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4348 * xterm.h: Likewise.
4349 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4350
1384b89e
JB
43512011-06-12 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * makefile.w32-in: Update dependencies.
4354 (LISP_H): Add lib/intprops.h.
4355
1100a63c
CY
43562011-06-11 Chong Yidong <cyd@stupidchicken.com>
4357
4358 * image.c (gif_load): Add animation frame delay to the metadata.
4359 (syms_of_image): Use DEFSYM. New symbol `delay'.
4360
6198ccd0
MR
43612011-06-11 Martin Rudalics <rudalics@gmx.at>
4362
4363 * window.c (delete_deletable_window): Re-add.
4364 (Fset_window_configuration): Rewrite to handle dead buffers and
4365 consequently deletable windows.
4366 (window_tree, Fwindow_tree): Remove. Supply functionality in
4367 window.el.
4368 (compare_window_configurations): Simplify code.
4369
b6e3633c
AS
43702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4371
1ab0dee5
AS
4372 * image.c (imagemagick_load_image): Fix type mismatch.
4373 (Fimagemagick_types): Likewise.
4374
b6e3633c
AS
4375 * window.h (replace_buffer_in_windows): Declare.
4376
9397e56f
MR
43772011-06-11 Martin Rudalics <rudalics@gmx.at>
4378
4379 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4380 Qclone_number. Remove external declaration of Qdelete_window.
4381 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4382 code.
640c8776
SM
4383 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4384 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4385 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4386 buffer list implementation.
4387 (other_buffer_safely): New function.
4388 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4389 calls to replace_buffer_in_windows and
4390 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4391 if allowed.
4392 (record_buffer): Inhibit quitting and rewrite using quittable
4393 functions. Run Qbuffer_list_update_hook if allowed.
4394 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4395 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4396 Move switch-to-buffer to window.el.
9397e56f
MR
4397 (bury-buffer): Move to window.el.
4398 (Vbuffer_list_update_hook): New variable.
4399
4400 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4401 section.
4402
4403 * window.h (resize_frame_windows): Move up in code.
4404 (Fwindow_frame): Remove EXFUN.
4405 (replace_buffer_in_all_windows): Remove prototype.
4406 (replace_buffer_in_windows_safely): Add prototype.
4407
4408 * window.c: Declare Qdelete_window static again. Move down
4409 declaration of select_count.
4410 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4411 (Fother_window): Move to window.el.
4412 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4413 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4414 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4415 window.el.
4416 (replace_buffer_in_windows): Implement by calling
4417 Qreplace_buffer_in_windows.
4418 (replace_buffer_in_all_windows): Remove with some functionality
4419 moved into replace_buffer_in_windows_safely.
4420 (replace_buffer_in_windows_safely): New function.
4421 (select_window_norecord, select_frame_norecord): Move in front
4422 of run_window_configuration_change_hook. Remove now obsolete
4423 declarations.
640c8776
SM
4424 (Fset_window_buffer): Rewrite doc-string.
4425 Call Qrecord_window_buffer.
9397e56f
MR
4426 (keys_of_window): Move binding for other-window to window.el.
4427
b50691aa
CY
44282011-06-11 Chong Yidong <cyd@stupidchicken.com>
4429
4430 * dispextern.h (struct image): Replace data member, whose int_val
4431 and ptr_val fields were not used by anything, with a single
4432 lisp_val object.
4433
4434 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4435 (gif_clear_image, gif_load, imagemagick_load_image)
4436 (gs_clear_image, gs_load): Callers changed.
4437
3f754b86
PE
44382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4439
cca69397
PE
4440 * buffer.h: Include <time.h>, for time_t.
4441 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4442
109e28d0
PE
4443 Fix minor problems found by static checking.
4444
60737f02
PE
4445 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4446
4b66faf3
PE
4447 Make identifiers static if they are not used in other modules.
4448 * data.c (Qcompiled_function, Qframe, Qvector):
4449 * image.c (QimageMagick, Qsvg):
4450 * minibuf.c (Qmetadata):
4451 * window.c (resize_window_check, resize_root_window): Now static.
4452 * window.h (resize_window_check, resize_root_window): Remove decls.
4453
109e28d0
PE
4454 * window.c (window_deletion_count, delete_deletable_window):
4455 Remove; unused.
46a4ce9e
PE
4456 (window_body_lines): Now static.
4457 (Fdelete_other_windows_internal): Mark vars as initialized.
4458 Make sure 'resize_failed' is initialized.
4459 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4460 (resize_window_apply): Remove unused local.
4461 * window.h (delete_deletable_window): Remove decl.
4462
109e28d0 4463 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4464 (imagemagick_load_image): Fix pointer signedness problem by changing
4465 last arg from unsigned char * to char *. All uses changed.
4466 Also, fix a local for similar reasons.
4467 Remove unused locals. Remove locals to avoid shadowing.
4468 (fn_rsvg_handle_free): Remove; unused.
4469 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4470 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4471
3f754b86
PE
4472 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4473
2547adb1
CY
44742011-06-10 Chong Yidong <cyd@stupidchicken.com>
4475
4476 * image.c (gif_load): Fix omitted cast error introduced by
4477 2011-06-06 change.
4478
2c8e37d4
MR
44792011-06-10 Martin Rudalics <rudalics@gmx.at>
4480
4481 * window.h (resize_proportionally, orig_total_lines)
4482 (orig_top_line): Remove from window structure.
4483 (set_window_height, set_window_width, change_window_heights)
4484 (Fdelete_window): Remove prototypes.
4485 (resize_frame_windows): Remove duplicate declaration.
4486
440a42e3
EZ
44872011-06-10 Eli Zaretskii <eliz@gnu.org>
4488
4489 * window.h (resize_frame_windows, resize_window_check)
4490 (delete_deletable_window, resize_root_window)
4491 (resize_frame_windows): Declare prototypes.
4492
4493 * window.c (resize_window_apply): Make definition be "static" to
4494 match the prototype.
4495
562dd5e9
MR
44962011-06-10 Martin Rudalics <rudalics@gmx.at>
4497
4498 * window.c: Remove declarations of Qwindow_size_fixed,
4499 window_min_size_1, window_min_size_2, window_min_size,
4500 size_window, window_fixed_size_p, enlarge_window, delete_window.
4501 Remove static from declaration of Qdelete_window, it's
4502 temporarily needed by Fbury_buffer.
4503 (replace_window): Don't assign orig_top_line and
4504 orig_total_lines.
4505 (Fdelete_window, delete_window): Remove. Window deletion is
4506 handled by window.el.
640c8776
SM
4507 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4508 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4509 (Fdelete_other_windows): Remove. Deleting other windows is
4510 handled by window.el.
4511 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4512 handled in window.el.
4513 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4514 Window minimum sizes are handled in window.el.
4515 (shrink_windows, size_window, set_window_height)
4516 (set_window_width, change_window_heights, window_height)
4517 (window_width, CURBEG, CURSIZE, enlarge_window)
4518 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4519 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4520 handled in window.el.
4521 (make_dummy_parent): Rename to make_parent_window and give it a
4522 second argument horflag.
4523 (make_window): Don't set resize_proportionally any more.
4524 (Fsplit_window): Remove. Windows are split in window.el.
4525 (save_restore_action, save_restore_orig_size)
4526 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4527 Resize mini windows in window.el.
4528 (grow_mini_window, shrink_mini_window): Implement by calling
4529 Qresize_root_window_vertically, resize_window_check and
4530 resize_window_apply.
640c8776
SM
4531 (saved_window, Fset_window_configuration, save_window_save):
4532 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4533 resize_proportionally.
4534 (window_min_height, window_min_width): Move to window.el.
4535 (keys_of_window): Move bindings for delete-other-windows,
4536 split-window, delete-window and enlarge-window to window.el.
4537
4538 * buffer.c: Temporarily extern Qdelete_window.
4539 (Fbury_buffer): Temporarily call Qdelete_window instead of
4540 Fdelete_window (Fbury_buffer will move to window.el soon).
4541
4542 * frame.c (set_menu_bar_lines_1): Remove code handling
4543 orig_top_line and orig_total_lines.
4544
4545 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4546 set_window_height but set heights directly.
4547 (change_frame_size_1): Use resize_frame_windows.
4548
4549 * xdisp.c (init_xdisp): Don't use set_window_height but set
4550 heights directly.
4551
640c8776
SM
4552 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4553 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4554 run_window_configuration_change_hook.
4555
4556 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4557 instead of change_window_heights and run
4558 run_window_configuration_change_hook.
4559
1a13852e
MR
45602011-06-09 Martin Rudalics <rudalics@gmx.at>
4561
4562 * window.c (replace_window): Rename second argument REPLACEMENT to
4563 NEW. New third argument SETFLAG. Rewrite.
4564 (delete_window, make_dummy_parent): Call replace_window with
4565 third argument 1.
4566 (window_list_1): Move down in code.
4567 (run_window_configuration_change_hook): Move set_buffer part
4568 before select_frame_norecord part in order to unwind correctly.
4569 Rename count1 to count.
4570 (recombine_windows, delete_deletable_window, resize_root_window)
4571 (Fdelete_other_windows_internal)
4572 (Frun_window_configuration_change_hook, make_parent_window)
4573 (resize_window_check, resize_window_apply, Fresize_window_apply)
4574 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4575 (Fdelete_window_internal, Fresize_mini_window_internal):
4576 New functions.
1a13852e
MR
4577 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4578
f3d1777e
MR
45792011-06-08 Martin Rudalics <rudalics@gmx.at>
4580
496e208e
MR
4581 * window.h (window): Add some new members to window structure -
4582 normal_lines, normal_cols, new_total, new_normal, clone_number,
4583 splits, nest, prev_buffers, next_buffers.
4584 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4585 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4586
f3d1777e
MR
4587 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4588 Remove.
496e208e
MR
4589 (make_dummy_parent): Set new members of windows structure.
4590 (make_window): Move down in code. Handle new members of window
4591 structure.
4592 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4593 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4594 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4595 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4596 (Fset_window_next_buffers, Fset_window_clone_number):
4597 New functions.
496e208e
MR
4598 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4599 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4600 Doc-string fixes.
4601 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4602 Argument WINDOW can be now internal window too.
4603 (Fwindow_use_time): Move up in code.
4604 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4605 Rewrite doc-string.
4606 (Fset_window_configuration, saved_window)
4607 (Fcurrent_window_configuration, save_window_save): Handle new
4608 members of window structure.
b9e809c2
MR
4609 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4610 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4611 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4612 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4613 Qget_mru_window, Qresize_root_window,
4614 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4615 Qauto_buffer_name; staticpro them.
f3d1777e 4616
abde8f8c
MR
46172011-06-07 Martin Rudalics <rudalics@gmx.at>
4618
4619 * window.c (Fwindow_total_size, Fwindow_left_column)
4620 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4621 (Fwindow_list_1): New functions.
4622 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4623 (Fwindow_width, Fscroll_left, Fscroll_right):
4624 Use window_body_cols instead of window_box_text_cols.
4625 (delete_window, Fset_window_configuration):
4626 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4627 (delete_all_subwindows): Take a window as argument and not a
4628 structure. Rewrite.
190b47e6
MR
4629 (window_loop): Remove handling of GET_LRU_WINDOW and
4630 GET_LARGEST_WINDOW.
4631 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4632
4633 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4634 window_box_text_cols. delete_all_subwindows now takes a
4635 Lisp_Object as argument.
abde8f8c 4636
640c8776
SM
4637 * indent.c (compute_motion, Fcompute_motion):
4638 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4639
fa8a67e6
MR
4640 * frame.c (delete_frame): Call delete_all_subwindows with root
4641 window as argument.
4642
a54e3482
DC
46432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4644
4645 * fns.c (Fputhash): Document return value.
4646
60002bf5
CY
46472011-06-06 Chong Yidong <cyd@stupidchicken.com>
4648
4649 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4650
0c671da6 46512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4652
b862a52a 4653 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4654
be44ca6c
PE
4655 Check for overflow when converting integer to cons and back.
4656 * charset.c (Fdefine_charset_internal, Fdecode_char):
4657 Use cons_to_unsigned to catch overflow.
4658 (Fencode_char): Use INTEGER_TO_CONS.
4659 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4660 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4661 * data.c (long_to_cons, cons_to_long): Remove.
4662 (cons_to_unsigned, cons_to_signed): New functions.
4663 These signal an error for invalid or out-of-range values.
4664 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4665 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4666 * font.c (Ffont_variation_glyphs):
4667 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4668 * lisp.h: Include <intprops.h>.
4669 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4670 (cons_to_signed, cons_to_unsigned): New decls.
4671 (long_to_cons, cons_to_long): Remove decls.
4672 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4673 (Fprimitive_undo): Use CONS_TO_INTEGER.
4674 * xfns.c (Fx_window_property): Likewise.
4675 * xselect.c: Include <limits.h>.
4676 (x_own_selection, selection_data_to_lisp_data):
4677 Use INTEGER_TO_CONS.
4678 (x_handle_selection_request, x_handle_selection_clear)
4679 (x_get_foreign_selection, Fx_disown_selection_internal)
4680 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4681 (lisp_data_to_selection_data): Use cons_to_unsigned.
4682 (x_fill_property_data): Use cons_to_signed.
4683 Report values out of range.
4684
d1f3d2af
PE
4685 Check for buffer and string overflow more precisely.
4686 * buffer.h (BUF_BYTES_MAX): New macro.
4687 * lisp.h (STRING_BYTES_MAX): New macro.
4688 * alloc.c (Fmake_string):
4689 * character.c (string_escape_byte8):
4690 * coding.c (coding_alloc_by_realloc):
4691 * doprnt.c (doprnt):
4692 * editfns.c (Fformat):
4693 * eval.c (verror):
4694 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4695 since they may not be the same number.
4696 * editfns.c (Finsert_char):
4697 * fileio.c (Finsert_file_contents):
4698 Likewise for BUF_BYTES_MAX.
4699
dd52fcea
PE
4700 * image.c: Use ptrdiff_t, not int, for sizes.
4701 (slurp_file): Switch from int to ptrdiff_t.
4702 All uses changed.
4703 (slurp_file): Check that file size fits in both size_t (for
4704 malloc) and ptrdiff_t (for sanity and safety).
4705
7f9bbdbb
PE
4706 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4707 if b->modtime has its maximal value.
4708
dfe18f82
PE
4709 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4710
84acfcf0
PE
4711 Don't assume time_t can fit into int.
4712 * buffer.h (struct buffer.modtime): Now time_t, not int.
4713 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4714 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4715
ccd9a01a
PE
4716 Minor fixes for signed vs unsigned integers.
4717 * character.h (MAYBE_UNIFY_CHAR):
4718 * charset.c (maybe_unify_char):
4719 * keyboard.c (read_char, reorder_modifiers):
4720 XINT -> XFASTINT, since the integer must be nonnegative.
4721 * ftfont.c (ftfont_spec_pattern):
4722 * keymap.c (access_keymap, silly_event_symbol_error):
4723 XUINT -> XFASTINT, since the integer must be nonnegative.
4724 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4725 since it makes no difference and we prefer signed.
4726 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4727 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4728 nonnegative.
4729
d6d100dd
SM
47302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4731
4732 * window.h (Fwindow_frame): Declare.
4733
2b6148e4
PE
47342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4737 (SPARE_MEMORY): Always define.
4738 (LARGE_REQUEST): Remove.
4739 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4740
f230ecc9
MR
47412011-06-06 Martin Rudalics <rudalics@gmx.at>
4742
727e958e
MR
4743 * lisp.h: Move EXFUNS for Fframe_root_window,
4744 Fframe_first_window and Fset_frame_selected_window to window.h.
4745
4746 * window.h: Move EXFUNS for Fframe_root_window,
4747 Fframe_first_window and Fset_frame_selected_window here from
4748 lisp.h.
4749
4750 * frame.c (Fwindow_frame, Fframe_first_window)
4751 (Fframe_root_window, Fframe_selected_window)
4752 (Fset_frame_selected_window): Move to window.c.
4753 (Factive_minibuffer_window): Move to minibuf.c.
4754 (Fother_visible_frames_p): New function.
4755
4756 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4757
f230ecc9
MR
4758 * window.c (decode_window, decode_any_window): Move up in code.
4759 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4760 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4761 (Fwindow_buffer): Move up and rewrite doc-string.
4762 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4763 (Fwindow_prev): New functions.
727e958e
MR
4764 (Fwindow_frame): Move here from frame.c. Accept any window as
4765 argument.
4766 (Fframe_root_window, Fframe_first_window)
4767 (Fframe_selected_window): Move here from frame.c. Accept frame
4768 or arbitrary window as argument. Update doc-strings.
4769 (Fminibuffer_window): Move up in code.
4770 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4771 (Fset_frame_selected_window): Move here from frame.c.
4772 Marginal rewrite.
727e958e
MR
4773 (Fselected_window, select_window, Fselect_window): Move up in
4774 code. Minor doc-string fixes.
f230ecc9 4775
4d09bcf6
PE
47762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4779 Do not assume that spare memory exists; that assumption is valid
4780 only if SYSTEM_MALLOC.
4781 (LARGE_REQUEST): New macro, so that the issue of large requests
4782 is separated from the issue of spare memory.
4783
810928a2
AS
47842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4785
172418ad
AS
4786 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4787 format. (Bug#8806)
4788
43f862f7
AS
4789 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4790
810928a2
AS
4791 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4792 before statements.
4793
a059fe24
JD
47942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4795
4796 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4797
4798 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4799
4800 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4801 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4802
989bf368
JB
48032011-06-05 Juanma Barranquero <lekktu@gmail.com>
4804
4805 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4806
4b80f674
CY
48072011-06-04 Chong Yidong <cyd@stupidchicken.com>
4808
4809 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4810 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4811 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4812 New error handlers.
4b80f674
CY
4813 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4814 Obey Vx_select_enable_clipboard_manager. Catch errors in
4815 x_clipboard_manager_save (Bug#8779).
4816 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4817 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4818
99a33b77 48192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4820
4821 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4822
99a33b77 48232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4824
4825 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4826 in the current matrix if keep_current_p is non-zero.
4827
8264569d
EZ
48282011-06-04 Eli Zaretskii <eliz@gnu.org>
4829
4830 * bidi.c (bidi_level_of_next_char): Fix last change.
4831
57f97249
EZ
48322011-06-03 Eli Zaretskii <eliz@gnu.org>
4833
fec2107c 4834 Support bidi reordering of text covered by display properties.
57f97249 4835
fec2107c
EZ
4836 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4837 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4838 (bidi_cache_search, bidi_cache_iterator_state)
4839 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4840 (bidi_level_of_next_char, bidi_move_to_visually_next):
4841 Support character positions inside a run of characters covered by a
fec2107c
EZ
4842 display string.
4843 (bidi_paragraph_init, bidi_resolve_explicit_1)
4844 (bidi_level_of_next_char): Call bidi_fetch_char and
4845 bidi_fetch_char_advance instead of FETCH_CHAR and
4846 FETCH_CHAR_ADVANCE.
4847 (bidi_init_it): Initialize new members.
4848 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4849 definitions.
4850 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4851 instead of using explicit *_CHAR codes.
d6d100dd
SM
4852 (bidi_resolve_explicit, bidi_resolve_weak):
4853 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4854 bidirectional text is supported only in multibyte buffers.
4855 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4856 it to initialize the frame_window_p member of struct bidi_it.
4857 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4858 (bidi_resolve_explicit, bidi_resolve_weak)
4859 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4860 bidi_it->nchars is non-positive.
4861 (bidi_level_of_next_char): Don't try to lookup the cache for the
4862 next/previous character if nothing is cached there yet, or if we
4863 were just reseat()'ed to a new position.
c40e2fb2 4864
0e14fe90
EZ
4865 * xdisp.c (set_cursor_from_row): Set start and stop points
4866 according to the row's direction when priming the loop that looks
4867 for the glyph on which to display cursor.
4868 (single_display_spec_intangible_p): Function deleted.
4869 (display_prop_intangible_p): Reimplement to call
4870 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4871 Accept 3 additional arguments needed by handle_display_spec.
4872 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4873 values: lists, `(when COND...)' forms, etc.
4874 (single_display_spec_string_p): Support property values that are
4875 lists with the argument STRING its top-level element.
4876 (display_prop_string_p): Fix the condition for processing a
4877 property that is a list to be consistent with handle_display_spec.
fec2107c 4878 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4879 last portion of handle_display_prop.
4880 (compute_display_string_pos): Accept additional argument
4881 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4882 value of a `display' property is a "replacing spec".
4883 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4884 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4885 the display property, but just return a value indicating whether
4886 the display property will replace the characters it covers.
4887 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4888 frame_window_p members of struct bidi_it.
d6d100dd
SM
4889 (compute_display_string_pos, compute_display_string_end):
4890 New functions.
fec2107c
EZ
4891 (push_it): Accept second argument POSITION, where pop_it should
4892 jump to continue iteration.
4893 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4894
fec2107c
EZ
4895 * keyboard.c (adjust_point_for_property): Adjust the call to
4896 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4897
4898 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4899 (bidi_init_it): Update prototypes.
4900 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4901 (compute_display_string_pos, compute_display_string_end):
4902 Declare prototypes.
fec2107c
EZ
4903 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4904 EMACS_INT.
fc6f18ce 4905
40087514 49062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4907
57f53182
PE
4908 Malloc failure behavior now depends on size of allocation.
4909 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4910 * lisp.h: Change signatures accordingly.
4911 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4912 All callers changed. (Bug#8762)
4913
4914 * gnutls.c: Use Emacs's memory allocators.
4915 Without this change, the gnutls library would invoke malloc etc.
4916 directly, which causes problems on non-SYNC_INPUT hosts, and which
4917 runs afoul of improving memory_full behavior. (Bug#8761)
4918 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4919 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4920 xfree instead of the default malloc, realloc, free.
4921 (Fgnutls_boot): No need to check for memory allocation failure,
4922 since xmalloc does that for us.
4923
ac32cd99 4924 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4925 * category.c (hash_get_category_set):
4926 * ccl.c (ccl_driver):
4927 * charset.c (Fdefine_charset_internal):
4928 * charset.h (struct charset.hash_index):
4929 * composite.c (get_composition_id, gstring_lookup_cache)
4930 (composition_gstring_put_cache):
4931 * composite.h (struct composition.hash_index):
4932 * dispextern.h (struct image.hash):
4933 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4934 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4935 (hashfn_equal, hashfn_user_defined, make_hash_table)
4936 (maybe_resize_hash_table, hash_lookup, hash_put)
4937 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4938 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4939 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4940 * image.c (make_image, search_image_cache, lookup_image)
4941 (xpm_put_color_table_h):
4942 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4943 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4944 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4945 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4946 * alloc.c (allocate_vectorlike):
4947 Check for overflow in vector size calculations.
4948 * ccl.c (ccl_driver):
4949 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4950 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4951 need to be updated by these changes.
40087514
PE
4952 * fns.c (make_hash_table, maybe_resize_hash_table):
4953 Check for integer overflow with large hash tables.
0de4bb68
PE
4954 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4955 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4956 (SXHASH_REDUCE): New macro.
4957 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4958 Use it instead of discarding useful hash info with large hash values.
4959 (sxhash_float): New function.
4960 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4961 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4962 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4963 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4964 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4965 Adjust signatures to match updated version of code.
4966 (consing_since_gc): Now EMACS_INT, since a single hash table can
4967 use more than INT_MAX bytes.
4968
698d32e2
DN
49692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4970
4971 Make it possible to build with GCC-4.6+ -O2 -flto.
4972
4973 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4974
fd6fa53f
SM
49752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4976
4977 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4978 Call minibuffer-inactive-mode.
4979
864db017
JB
49802011-05-31 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4983 Update dependencies.
4984
2ad0baf4
DN
49852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4986
4987 * data.c (init_data): Remove code for UTS, this system is not
4988 supported anymore.
4989
4fcc2638
DN
49902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4991
4992 Don't force ./temacs to start in terminal mode.
4993
4994 * frame.c (make_initial_frame): Initialize faces in all cases, not
4995 only when CANNOT_DUMP is defined.
4996 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4997
c56e0fd5
DN
49982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4999
5000 * dispnew.c (add_window_display_history): Use const for the string
5001 pointer. Remove declaration, not needed.
5002
333d54da 50032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5004
55d4c1b2 5005 Use 'inline', not 'INLINE'.
333d54da 5006 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5007 * alloc.c, fontset.c (INLINE): Remove.
5008 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5009 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5010 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5011 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5012 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5013
738db178
DN
50142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5015
5016 Make it possible to run ./temacs.
5017
5018 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5019 syms_of_callproc does the same thing. Remove test for
5020 "initialized", do it in the caller.
5021 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5022
620c53a6
SM
50232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5024
5025 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5026 (read_minibuf): Use get_minibuffer.
5027 (syms_of_minibuf): Use DEFSYM.
5028 (Qmetadata): New var.
5029 * data.c (Qbuffer): Don't make it static.
5030 (syms_of_data): Use DEFSYM.
5031
e003a292
PE
50322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5035 (CCL_CODE_MIN): New macro.
5036
ed008a6d
PE
50372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5038
3687c2ef
PE
5039 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5040
ed008a6d
PE
5041 * eval.c (Qdebug): Now static.
5042 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5043 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5044 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5045
d66c4c7c
CY
50462011-05-29 Chong Yidong <cyd@stupidchicken.com>
5047
5048 * image.c: Various fixes to ImageMagick code comments.
5049 (Fimagemagick_types): Doc fix.
5050
5fbc2025
PE
50512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5052
0196f88a
PE
5053 Minor fixes prompted by GCC 4.6.0 warnings.
5054
5055 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5056
5fbc2025
PE
5057 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5058 (x_clipboard_manager_save_all): Move extern decl to ...
5059 * xterm.h: ... here, so that it can be checked for consistency.
5060
1dd3c2d9
CY
50612011-05-29 Chong Yidong <cyd@stupidchicken.com>
5062
5063 * xselect.c (x_clipboard_manager_save_frame)
5064 (x_clipboard_manager_save_all): New functions.
5065 (Fx_clipboard_manager_save): Lisp function deleted.
5066
5067 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5068 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5069
5070 * xterm.h: Update prototype.
5071
5ba6571d
WX
50722011-05-28 William Xu <william.xwl@gmail.com>
5073
5074 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5075 exiting (Bug#8239).
5076
3eaff834
JM
50772011-05-28 Jim Meyering <meyering@redhat.com>
5078
e1900994 5079 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5080 * fns.c (to_uchar): Define.
5081 (crypto_hash_function): Use it to convert some newly-signed
5082 variables to unsigned, to avoid sign-extension bugs. For example,
5083 without this change, (md5 "truc") would evaluate to
5084 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5085 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5086 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5087
0f6990a7
PE
50882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5089
5090 Integer overflow fixes.
c8a9ca5a 5091
08686060
PE
5092 * dbusbind.c: Serial number integer overflow fixes.
5093 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5094 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5095 to hold a serial number that is too large for a fixnum.
5096 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5097 Check for serial numbers out of range. Decode any serial number
59568bf0 5098 that was so large that it became a float. (Bug#8722)
08686060 5099
2d1fc3c7
PE
5100 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5101 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5102 Use XFASTINT rather than XUINT when numbers are nonnegative.
5103 (xd_append_arg, Fdbus_method_return_internal):
5104 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5105 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5106 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5107 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5108 (Bug#8722)
2d1fc3c7 5109
c8a9ca5a
PE
5110 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5111
519e1d69
PE
5112 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5113
30569699
PE
5114 ccl: add integer overflow checks
5115 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5116 (IN_INT_RANGE): New macros.
5117 (ccl_driver): Use them to check for integer overflow when
5118 decoding a CCL program. Many of the new checks are whether XINT (x)
5119 fits in int; it doesn't always, on 64-bit hosts. The new version
5120 doesn't catch all possible integer overflows, but it's an
847044ea 5121 improvement. (Bug#8719)
30569699 5122
c11285dc
PE
5123 * alloc.c (make_event_array): Use XINT, not XUINT.
5124 There's no need for unsigned here.
5125
fdccd48e
PE
5126 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5127 This follows up to the 2011-05-06 change that substituted uintptr_t
5128 for EMACS_INT. This case wasn't caught back then.
5129
37910ab2
PE
5130 Rework Fformat to avoid integer overflow issues.
5131 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5132 now (part of C89). Include <verify.h>.
5133 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5134 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5135 (Fformat): Avoid the prepass trying to compute sizes; it was only
5136 approximate and thus did not catch overflow reliably. Instead, walk
5137 through the format just once, formatting and computing sizes as we go,
5138 checking for integer overflow at every step, and allocating a larger
5139 buffer as needed. Keep track separately whether the format is
5140 multibyte. Keep only the most-recently calculated precision, rather
5141 than them all. Record whether each argument has been converted to
5142 string. Use EMACS_INT, not int, for byte and char and arg counts.
5143 Support field widths and precisions larger than INT_MAX. Avoid
5144 sprintf's undefined behavior with conversion specifications such as %#d
5145 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5146 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5147 formatting out-of-range floating point numbers with int
9173deec 5148 formats. (Bug#8668)
37910ab2 5149
2e6578fb
PE
5150 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5151
0ae6bdee
PE
5152 * data.c: Avoid integer truncation in expressions involving floats.
5153 * data.c: Include <intprops.h>.
5154 (arith_driver): When there's an integer overflow in an expression
5155 involving floating point, convert the integers to floating point
5156 so that the resulting value does not suffer from catastrophic
5157 integer truncation. For example, on a 64-bit host (* 4
5158 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5159 Do not rely on undefined behavior after integer overflow.
5160
de883a70
PE
5161 merge count_size_as_multibyte, parse_str_to_multibyte
5162 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5163 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5164 Check for integer overflow.
5165 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5166 since it's now a duplicate of the other. This is more of
5167 a character than a buffer op, so better that it's in character.c.
5168 * fns.c, print.c: Adjust to above changes.
5169
2ff916cb
PE
51702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5171
5172 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5173
f1b54466
PE
51742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5175
fb1ac845
PE
5176 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5177 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5178 (x_clipboard_manager_save): Now static.
5179 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5180
f1b54466
PE
5181 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5182 (crypto_hash_function): Now static.
5183 Fix pointer signedness problems. Avoid unnecessary initializations.
5184
a9f737ee
CY
51852011-05-27 Chong Yidong <cyd@stupidchicken.com>
5186
5187 * termhooks.h (Vselection_alist): Make it terminal-local.
5188
5189 * terminal.c (create_terminal): Initialize it.
5190
5191 * xselect.c: Support for clipboard managers.
5192 (Vselection_alist): Move to termhooks.h as terminal-local var.
5193 (LOCAL_SELECTION): New macro.
5194 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5195 (symbol_to_x_atom): Remove gratuitous arg.
5196 (x_handle_selection_request, lisp_data_to_selection_data)
5197 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5198 (x_own_selection, x_get_local_selection, x_convert_selection):
5199 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5200 (some_frame_on_display): Delete unused function.
5201 (Fx_own_selection_internal, Fx_get_selection_internal)
5202 (Fx_disown_selection_internal, Fx_selection_owner_p)
5203 (Fx_selection_exists_p): New optional frame arg.
5204 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5205 (x_handle_selection_clear): Don't treat other terminals with the
5206 same keyboard specially. Use the terminal-local Vselection_alist.
5207 (x_clear_frame_selections): Use Frun_hook_with_args.
5208
5209 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5210
5211 * xterm.h: Add support for those atoms.
5212
e067f0c1
CY
52132011-05-26 Chong Yidong <cyd@stupidchicken.com>
5214
5215 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5216 (converted_selections, conversion_fail_tag): New global variables.
5217 (x_selection_request_lisp_error): Free the above.
5218 (x_get_local_selection): Remove unnecessary code.
5219 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5220 of converted selections stored in converted_selections.
5221 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5222 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5223 (x_convert_selection): New function.
5224 (x_handle_selection_event): Simplify.
5225 (x_get_foreign_selection): Don't ignore incoming requests while
5226 waiting for an answer; this will fail when we implement
5227 SAVE_TARGETS, and seems unnecessary anyway.
5228 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5229 (Vx_sent_selection_functions): Doc fix.
5230
0f4aebc0
LL
52312011-05-26 Leo Liu <sdl.web@gmail.com>
5232
5233 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5234
e61124cd
YM
52352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5236
5237 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5238
5239 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5240 for fringe update if it has periodic bitmap.
ac389d0c 5241 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5242 and fringe_bitmap_periodic_p.
5243
5244 * fringe.c (get_fringe_bitmap_data): New function.
5245 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5246 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5247 row. Mark glyph row for fringe update if periodicity changed.
5248
5249 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5250 for fringe update unless it has periodic bitmap.
5251
f16d9837
KH
52522011-05-25 Kenichi Handa <handa@m17n.org>
5253
5254 * xdisp.c (get_next_display_element): Set correct it->face_id for
5255 a static composition.
5256
e1b90ef6
LL
52572011-05-24 Leo Liu <sdl.web@gmail.com>
5258
5259 * deps.mk (fns.o):
5260 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5261
5262 * fns.c (crypto_hash_function, Fsha1): New function.
5263 (Fmd5): Use crypto_hash_function.
5264 (syms_of_fns): Add Ssha1.
5265
7400048f
PE
52662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5267
5268 * gnutls.c: Remove unused macros.
5269 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5270 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5271 Remove macros that are defined and never used.
5272 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5273
abb71cf4
CY
52742011-05-22 Chong Yidong <cyd@stupidchicken.com>
5275
5276 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5277 (Fx_get_selection_internal): Minor cleanup.
5278 (Fx_own_selection_internal): Rename arguments for consistency with
5279 select.el.
5280
6307db39
PE
52812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5282
5283 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5284
f3d4e0a4
CY
52852011-05-22 Chong Yidong <cyd@stupidchicken.com>
5286
5287 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5288
4d8ade89
YM
52892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5290
5291 * dispnew.c (scrolling_window): Don't exclude the case that the
5292 last enabled row in the desired matrix touches the bottom boundary.
5293
32078c8d
GM
52942011-05-21 Glenn Morris <rgm@gnu.org>
5295
5296 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5297 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5298 and add some more files.
32078c8d 5299
7285dc67
EZ
53002011-05-20 Eli Zaretskii <eliz@gnu.org>
5301
5302 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5303 report_file_error introduced by the change from 2011-05-07.
5304
89d1bd22
PE
53052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5306
5307 * systime.h (Time): Define only if emacs is defined.
5308 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5309 where the include path doesn't have X11/X.h by default. See
5310 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5311
e23640bb 53122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5313
5314 * composite.c (find_automatic_composition): Fix previous change.
5315
b9704ad9
GM
53162011-05-20 Glenn Morris <rgm@gnu.org>
5317
5318 * lisp.mk: New file, split from Makefile.in.
5319 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5320 (shortlisp): Remove.
5321 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5322
4a720484
GM
53232011-05-19 Glenn Morris <rgm@gnu.org>
5324
5325 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5326 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5327 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5328 (lisp): Set the order to that of loadup.el.
5329 (shortlisp): Make it a copy of $lisp.
5330 (SOME_MACHINE_LISP): Remove.
5331 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5332 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5333
a28d4396
KH
53342011-05-18 Kenichi Handa <handa@m17n.org>
5335
5336 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5337 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5338 (find_automatic_composition): Mostly rewrite for efficiency.
5339
a2b1fa8e
JB
53402011-05-18 Juanma Barranquero <lekktu@gmail.com>
5341
5342 * makefile.w32-in: Update dependencies.
5343
8e1f5610
CS
53442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5345
5346 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5347 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5348
7025ee00 53492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5350
cdfa6eab
PE
5351 Fix some integer overflow issues, such as string length overflow.
5352
06d6db33
PE
5353 * insdel.c (count_size_as_multibyte): Check for string overflow.
5354
2b4560a8
PE
5355 * character.c (lisp_string_width): Check for string overflow.
5356 Use EMACS_INT, not int, for string indexes and lengths; in
5357 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5358 the resulting string length overflows an EMACS_INT; instead,
5359 report a string overflow if no precision given. When checking for
5360 precision exhaustion, use a check that cannot possibly have
5361 integer overflow. (Bug#8675)
5362 * character.h (lisp_string_width): Adjust to new signature.
5363
cb93f9be
PE
5364 * alloc.c (string_overflow): New function.
5365 (Fmake_string): Use it. This doesn't change behavior, but saves
5366 a few bytes and will simplify future changes.
5367 * character.c (string_escape_byte8): Likewise.
5368 * lisp.h (string_overflow): New decl.
5369
1a1f3366
PE
5370 Fixups, following up to the user-interface timestamp change.
5371 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5372 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5373 * msdos.c (mouse_get_pos): Likewise.
5374 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5375 * w32gui.h (Time): Define by including "systime.h" rather than by
5376 declaring it ourselves. (Bug#8664)
5377
d4e3e4d3
PE
5378 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5379 * image.c (clear_image_cache): Likewise.
5380
f6a24d19
PE
5381 * term.c (term_mouse_position): Don't assume time_t wraparound.
5382
08dc5ae6
PE
5383 Be more systematic about user-interface timestamps.
5384 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5385 and sometimes 'EMACS_UINT', to represent these timestamps.
5386 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5387 This makes the code easier to follow, and makes it easier to catch
5388 integer overflow bugs such as Bug#8664.
5389 * frame.c (Fmouse_position, Fmouse_pixel_position):
5390 Use Time, not unsigned long, for user-interface timestamps.
5391 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5392 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5393 * keyboard.h (last_event_timestamp): Likewise.
5394 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5395 * menu.h (xmenu_show): Likewise.
5396 * term.c (term_mouse_position): Likewise.
5397 * termhooks.h (struct input_event.timestamp): Likewise.
5398 (struct terminal.mouse_position_hook): Likewise.
5399 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5400 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5401 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5402 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5403 what it was before.
5404 * menu.h, termhooks.h: Include "systime.h", for Time.
5405
8e55734a
PE
5406 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5407 Don't assume that the difference between two unsigned long values
5408 can fit into an integer. At this point, we know button_down_time
5409 <= event->timestamp, so the difference must be nonnegative, so
5410 there's no need to cast the result if double-click-time is
5411 nonnegative, as it should be; check that it's nonnegative, just in
5412 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5413 apart (about 25 days). (Bug#8664)
8e55734a 5414
841f1b75 5415 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5416 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5417
3e26f69c
PE
5418 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5419 that always fit in int. Use a sentinel instead of a counter, to
5420 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5421 * frame.h (struct frame): Use int for menu_bar_items_used
5422 instead of EMACS_INT, since it always fits in int.
3e26f69c 5423
5cc152c0
PE
5424 * menu.c (grow_menu_items): Check for int overflow.
5425
d89eb65e
PE
5426 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5427
5235bd3e
PE
5428 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5429 Before, the code was not consistent. These values cannot exceed
5430 2**31 - 1 so there's no need to make them unsigned.
5431 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5432 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5433 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5434 as modifiers.
5435 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5436
bc827e23
PE
5437 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5438 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5439 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5440 presumably because the widths might not match.
5441
78eb494e
PE
5442 * window.c (size_window): Avoid needless test at loop start.
5443
04f2d78b
CB
54442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5445
5446 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5447
d2fc7e3d 54482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5449
5450 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5451
d2fc7e3d 54522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5453
5454 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5455 `width' to `bar_area_x' and `bar_area_width', respectively.
5456 (x_scroll_run): Take account of fringe background extension.
5457
04f2d78b
CB
5458 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5459 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5460 `bar_area_width', respectively.
5461 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5462 background extension.
5463
79b70037
GM
54642011-05-10 Jim Meyering <meyering@redhat.com>
5465
5466 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5467
2f142cc5
JB
54682011-05-10 Juanma Barranquero <lekktu@gmail.com>
5469
5470 * image.c (Finit_image_library): Return t for built-in image types,
5471 like pbm and xbm. (Bug#8640)
5472
57679c86
AS
54732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5474
5475 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5476
888c9e86
EZ
54772011-05-07 Eli Zaretskii <eliz@gnu.org>
5478
b0512a1d
EZ
5479 * w32console.c (Fset_screen_color): Doc fix.
5480 (Fget_screen_color): New function.
5481 (syms_of_ntterm): Defsubr it.
5482
7285dc67
EZ
5483 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5484 unlink the temporary file if Fcall_process didn't create it in the
5485 first place.
5486 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5487 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5488 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5489 cue to call_process_cleanup not to close that handle.
5490
4d3fcc8e
BK
54912011-05-07 Ben Key <bkey76@gmail.com>
5492
5493 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5494 one of two shell specific rules, either bootstrap-temacs-CMD or
5495 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5496 to the previous implementation of the bootstrap-temacs rule.
5497 The bootstrap-temacs-CMD rule is similar to the previous
5498 implementation of the bootstrap-temacs rule except that it
5499 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5500 variable.
5501
5502 These changes, along with some changes to nt/configure.bat,
5503 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5504 earlier fix to add support for --cflags and --ldflags options
5505 that include quotes so that it works whether make uses cmd or
5506 sh as the shell.
5507
b4289b64
MA
55082011-05-06 Michael Albinus <michael.albinus@gmx.de>
5509
5510 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5511 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5512 is a constant.
5513 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5514 a string. Handle both cases.
5515 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5516 (Fdbus_register_method): Use Qinvalid_function.
5517
af4c0e28
JB
55182011-05-06 Juanma Barranquero <lekktu@gmail.com>
5519
5520 * makefile.w32-in: Update dependencies.
5521 (LISP_H): Add inttypes.h and stdin.h.
5522 (PROCESS_H): Add unistd.h.
5523
c51453d9
EZ
55242011-05-06 Eli Zaretskii <eliz@gnu.org>
5525
5526 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5527 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5528
8ff0ac3c 55292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5530
4c4b566b
PE
5531 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5532
aab2b9b5
PE
5533 * term.c (vfatal): Remove stray call to va_end.
5534 It's not needed and the C Standard doesn't allow it here anyway.
5535
c378da0b
PE
5536 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5537 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5538
288b08c7
PE
5539 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5540 bytes.
5541
e3601888
PE
5542 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5543
db6c0e74
PE
5544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5545
dd5963ea
PE
5546 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5547
88c9450f
PE
5548 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5549
2f9442b8
PE
5550 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5551
c032b5f8
PE
5552 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5553 * charset.c (Fdefine_charset_internal): Don't initialize
5554 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5555 32-bit int (Bug#8600).
a108c10b
PE
5556
5557 * lread.c (read_integer): Be more consistent with string-to-number.
5558 Use string_to_number to do the actual conversion; this avoids
5559 rounding errors and fixes some other screwups. Without this fix,
5560 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5561 (digit_to_number): Move earlier, for benefit of read_integer.
5562 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5563 not a digit in any supported base. (Bug#8602)
a108c10b 5564
ad5f9eea
PE
5565 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5566
aec1708a
PE
5567 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5568 to match comment at start of function. This also removes a
5569 GCC warning about overflow in a 32+64-bit port.
5570
47be4ab5
PE
5571 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5572
371cac43
PE
5573 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5574 Reported by Stefan Monnier in
5575 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5576 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5577 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5578
d01a7826
PE
5579 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5580 (EMACS_UINTPTR): Likewise, with uintptr_t.
5581
7fd47d5c
PE
5582 * lisp.h: Prefer 64-bit EMACS_INT if available.
5583 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5584 on 32-bit hosts that have 64-bit int, so that they can access
5585 large files.
122b0c86
PE
5586 However, temporarily disable this change unless the temporary
5587 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5588
8727937b
PE
5589 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5590
8ac068ac
PE
5591 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5592 This removes an assumption that EMACS_INT and long are the same
5593 width as pointers. The assumption is true for Emacs porting targets
5594 now, but we want to make other targets possible.
5595 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5596 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5597 In the rest of the code, change types of integers that hold casted
5598 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5599 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5600 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5601 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5602 No need to cast type when ORing.
5603 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5604 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5605 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5606 assume EMACS_INT is the same width as char *.
5607 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5608 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5609 Remove no-longer-needed casts.
5610 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5611 (xg_tool_bar_help_callback, xg_make_tool_item):
5612 Use EMACS_INTPTR to hold an integer
5613 that will be cast to void *; this can avoid a GCC warning
5614 if EMACS_INT is not the same width as void *.
5615 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5616 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5617 (current_message_1, set_message_1):
5618 Use a local to convert to proper width without a cast.
5619 * xmenu.c (dialog_selection_callback): Likewise.
5620
ede49d71
PE
5621 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5622 Also, don't assume VALBITS / RAND_BITS is less than 5,
5623 and don't rely on undefined behavior when shifting a 1 left into
5624 the sign bit.
5625 * lisp.h (get_random): Change signature to match.
5626
2f30ecd0
PE
5627 * lread.c (hash_string): Use size_t, not int, for hash computation.
5628 Normally we prefer signed values; but hashing is special, because
5629 it's better to use unsigned division on hash table sizes so that
5630 the remainder is nonnegative. Also, size_t is the natural width
5631 for hashing into memory. The previous code used 'int', which doesn't
5632 retain enough info to hash well into very large tables.
5633 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5634
2a866e7b
PE
5635 * dbusbind.c: Don't possibly lose pointer info when converting.
5636 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5637 Use XPNTR rather than XHASH, so that the high-order bits of
5638 the pointer aren't lost when converting through void *.
5639
51639eac
PE
5640 * eval.c (Fautoload): Don't double-shift a pointer.
5641
92394119
PE
5642 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5643
dbdb9a7c
JB
56442011-05-06 Juanma Barranquero <lekktu@gmail.com>
5645
5646 * gnutls.c (DEF_GNUTLS_FN):
5647 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5648
db7a0b4f
AS
56492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5650
5651 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5652 marker. (Bug#8610)
5653
f7ff1b0f 56542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5655
5656 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5657 New version that can reserve upto 2GB of heap space.
5658
f7ff1b0f 56592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5660
5661 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5662
639c109b
TZ
56632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5664
5665 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5666 `gnutls_certificate_set_x509_key_file'.
5667
d2127135
JB
56682011-05-05 Juanma Barranquero <lekktu@gmail.com>
5669
5670 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5671 Update dependencies.
5672
e968f4f3
JB
56732011-05-04 Juanma Barranquero <lekktu@gmail.com>
5674
5675 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5676 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5677 Remove unused parameter `fildes'.
5678 * process.c (read_process_output, send_process): Don't pass it.
5679
84d358f0
JB
56802011-05-04 Juanma Barranquero <lekktu@gmail.com>
5681
5682 Fix previous change: the library cache is defined in w32.c.
5683 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5684 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5685
0898ca10
JB
56862011-05-04 Juanma Barranquero <lekktu@gmail.com>
5687
5688 Implement dynamic loading of GnuTLS on Windows.
5689
5690 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5691 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5692 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5693 Declare.
5694
5695 * gnutls.c (Qgnutls_dll): Define.
5696 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5697 (gnutls_*): Declare function pointers.
5698 (init_gnutls_functions): New function to initialize function pointers.
5699 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5700 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5701 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5702 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5703 (emacs_gnutls_write, emacs_gnutls_read)
5704 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5705 (Fgnutls_available_p): New function.
5706 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5707 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5708 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5709
5710 * image.c: Include w32.h.
5711 (Vimage_type_cache): Delete.
5712 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5713 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5714 (w32_delayed_load): Move to w32.c.
5715
5716 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5717
5718 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5719 (w32_delayed_load): Move from image.c. When loading a library, record
5720 its filename in the :loaded-from property of the library id.
5721 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5722 Initialize and staticpro them.
5723 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5724
5725 * process.c: Include lisp.h before w32.h, not after.
5726 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5727 instead of gnutls_record_check_pending.
5728
5729 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5730
ff4de4aa
TZ
57312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5732
5733 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5734 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5735 as passed in.
5736
abe95abb
JD
57372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5738
5739 * xterm.c (x_set_frame_alpha): Do not set property on anything
5740 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5741
e16e55d4
JB
57422011-05-02 Juanma Barranquero <lekktu@gmail.com>
5743
5744 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5745
bafcf6a5
JB
57462011-05-02 Juanma Barranquero <lekktu@gmail.com>
5747
5748 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5749 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5750 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5751 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5752 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5753 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5754 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5755 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5756 (Qgnutls_bootprop_callbacks_verify): Make static.
5757
e7a6747f
AS
57582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5759
19ed11ba
AS
5760 * callproc.c: Indentation fixup.
5761
e7a6747f 5762 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5763 (wait_for_termination, interruptible_wait_for_termination):
5764 Move after wait_for_termination_1.
e7a6747f 5765
1ef14cb4
LMI
57662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5767
5768 * sysdep.c (interruptible_wait_for_termination): New function
5769 which is like wait_for_termination, but allows keyboard
5770 interruptions.
5771
5772 * callproc.c (Fcall_process): Add (:file "file") as an option for
5773 the STDOUT buffer.
5774 (Fcall_process_region): Ditto.
5775
330d880c
EZ
57762011-04-30 Eli Zaretskii <eliz@gnu.org>
5777
8db90b73
EZ
5778 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5779 rather than `XVECTOR (FOO)->size'.
5780
330d880c
EZ
5781 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5782 inttypes.h, as a gnulib replacement is used if it not available in
5783 system headers.
5784
15cbd324
EZ
57852011-04-21 Eli Zaretskii <eliz@gnu.org>
5786
5787 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5788 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5789 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5790
5791 * coding.c (coding_alloc_by_realloc): Error out if destination
5792 will grow beyond MOST_POSITIVE_FIXNUM.
5793 (decode_coding_emacs_mule): Abort if there isn't enough place in
5794 charbuf for the composition carryover bytes. Reserve an extra
5795 space for up to 2 characters produced in a loop.
5796 (decode_coding_iso_2022): Abort if there isn't enough place in
5797 charbuf for the composition carryover bytes.
5798
57992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5800
ae940cca
EZ
5801 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5802 aborting when %lld or %lll format is passed.
5803 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5804 %llo or %llx format is passed. (Bug#8545)
5805
03ab8921
EZ
5806 * window.c (window_scroll_line_based): Use a marker instead of
5807 simple variables to record original value of point. (Bug#7952)
5808
afda1437
EZ
5809 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5810 produced by %s or %c overflows available buffer space. (Bug#8545)
5811
f76dee0c
PE
58122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5813
5814 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5815 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5816
fdc5744d
JB
58172011-04-28 Juanma Barranquero <lekktu@gmail.com>
5818
5819 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5820
638f053a
JB
58212011-04-28 Juanma Barranquero <lekktu@gmail.com>
5822
5823 * keyboard.c (Qdelayed_warnings_hook): Define.
5824 (command_loop_1): Run `delayed-warnings-hook'
5825 if Vdelayed_warnings_list is non-nil.
5826 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5827 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5828
d178f871
EZ
58292011-04-28 Eli Zaretskii <eliz@gnu.org>
5830
5831 * doprnt.c (doprnt): Don't return value smaller than the buffer
5832 size if the message was truncated. (Bug#8545).
5833
b124fd93
JB
58342011-04-28 Juanma Barranquero <lekktu@gmail.com>
5835
5836 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5837 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5838
e810457d
PE
58392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5842
ea51cceb
JB
58432011-04-27 Juanma Barranquero <lekktu@gmail.com>
5844
5845 * makefile.w32-in: Update dependencies.
5846
94dcfacf
EZ
58472011-04-27 Eli Zaretskii <eliz@gnu.org>
5848
5849 Improve `doprnt' and its usage. (Bug#8545)
5850 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5851 `format_end'. Remove support for %l as a conversion specifier.
5852 Don't use xrealloc. Improve diagnostics when the %l size modifier
5853 is used. Update the commentary.
5854
5855 * eval.c (verror): Simplify calculation of size_t.
5856
5857 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5858 messages.
5859
f61f41d7
PE
58602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5861
5862 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5863 change.
5864
96fb4434
PE
58652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5866
5867 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5868 This makes this file independent of the recent pseudovector change.
5869
671875da 58702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5871
69e9b5a3
PE
5872 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5873
b5f869a7 5874 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5875 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5876 Remove unused local.
c8926152 5877 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5878
841a1577 5879 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5880 GCC 4.6.0 optimizes based on type-based alias analysis.
5881 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5882 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5883 != &v->size, and therefore "v->size = 1; b->size = 2; return
5884 v->size;" must therefore return 1. This assumption is incorrect
5885 for Emacs, since it type-puns struct Lisp_Vector * with many other
5886 types. To fix this problem, this patch adds a new type struct
f904488f 5887 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5888 and pseudovectors, and helps optimizing compilers not get fooled
5889 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5890 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5891 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5892 the size member.
eab3844f
PE
5893 (XSETPVECTYPE): Rewrite in terms of new macro.
5894 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5895 This is a bit clearer, and further avoids the possibility of
5896 undesirable aliasing.
5897 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5898 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5899 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5900 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5901 (ASIZE): Now uses header.size rather than size.
5902 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5903 to avoid the hassle of writing XVECTOR (foo)->header.size.
5904 (struct vectorlike_header): New type.
eab3844f
PE
5905 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5906 object, to help avoid aliasing.
5907 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5908 (SUBRP): Likewise, since Lisp_Subr is a special case.
5909 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5910 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5911 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5912 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5913 changed to be "header.size" and "header.next".
5914 * buffer.h (struct buffer): Likewise.
5915 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5916 * frame.h (struct frame): Likewise.
5917 * process.h (struct Lisp_Process): Likewise.
5918 * termhooks.h (struct terminal): Likewise.
5919 * window.c (struct save_window_data, struct saved_window): Likewise.
5920 * window.h (struct window): Likewise.
5921 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5922 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5923 * buffer.c (init_buffer_once): Likewise.
5924 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5925 special case.
5926 * process.c (Fformat_network_address): Use local var for size,
5927 for brevity.
5928
0df1eac5
PE
5929 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5930
847ab9d1 5931 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5932 * data.c (atof): Remove decl; no longer used or needed.
5933 (digit_to_number): Move to lread.c.
5934 (Fstring_to_number): Use new string_to_number function, to be
5935 consistent with how the Lisp reader treats infinities and NaNs.
5936 Do not assume that floating-point numbers represent EMACS_INT
5937 without losing information; this is not true on most 64-bit hosts.
5938 Avoid double-rounding errors, by insisting on integers when
5939 parsing non-base-10 numbers, as the documentation specifies.
5940 * lisp.h (string_to_number): New decl, replacing ...
5941 (isfloat_string): Remove.
bc0a5c13 5942 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5943 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5944 appears to have been a coding error. Similarly, do not accept
5945 strings like +-1e0 as floating point numbers. Do not report
5946 overflow for integer overflows unless the base is not 10 which
5947 means we have no simple and reliable way to continue.
5948 Break out the floating-point parsing into a new
5949 function string_to_number, so that Fstring_to_number parses
5950 floating point numbers consistently with the Lisp reader.
04f2d78b 5951 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5952 (E_CHAR, EXP_INT): Remove, replacing with ...
5953 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5954 (string_to_number): New function, replacing isfloat_string.
5955 This function checks for valid syntax and produces the resulting
5956 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5957 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5958 so that overflow for non-base-10 numbers is reported only when
5959 there's no portable and simple way to convert to floating point.
452f4150 5960
67769ffc
PE
5961 * textprop.c (set_text_properties_1): Rewrite for clarity,
5962 and to avoid GCC warning about integer overflow.
5963
c20db43f
PE
5964 * intervals.h (struct interval): Use EMACS_INT for members
5965 where EMACS_UINT might cause problems. See
5966 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5967 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5968 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5969 All uses changed.
37aa2f85
PE
5970 (offset_intervals): Tell GCC not to worry about length overflow
5971 when negating a negative length.
c20db43f 5972
2538aa2f
PE
5973 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5974 (overrun_check_free): Likewise.
5975
f2d3008d
PE
5976 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5977 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5978 word size.
5979
ec8df744
PE
5980 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5981 (gnutls_make_error): Rename local to avoid shadowing.
5982 (gnutls_emacs_global_deinit): ifdef out; not used.
5983 (Fgnutls_boot): Use const for pointer to readonly storage.
5984 Comment out unused local. Fix pointer signedness problems.
5985
640ee02d
PE
5986 * lread.c (openp): Don't stuff size_t into an 'int'.
5987 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5988 about possible signed overflow.
5989
6048fb2a
PE
5990 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5991 (GDK_KEY_g): Don't define if already defined.
5992 (xg_prepare_tooltip): Avoid pointer signedness problem.
5993 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5994
fa3c87e1
PE
5995 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5996 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5997
2172544b
PE
5998 * xfns.c (Fx_window_property): Simplify a bit,
5999 to make a bit faster and to avoid GCC 4.6.0 warning.
6000 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6001
9b821a21
PE
6002 * fns.c (internal_equal): Don't assume size_t fits in int.
6003
3c616cfa
PE
6004 * alloc.c (compact_small_strings): Tighten assertion a little.
6005
c2982e87
PE
6006 Replace pEd with more-general pI, and fix some printf arg casts.
6007 * lisp.h (pI): New macro, generalizing old pEd macro to other
6008 conversion specifiers. For example, use "...%"pI"d..." rather
6009 than "...%"pEd"...".
6010 (pEd): Remove. All uses replaced with similar uses of pI.
6011 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6012 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6013 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6014 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6015 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6016 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6017 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6018 64-bit hosts.
6019 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6020 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6021 * print.c (safe_debug_print, print_object): Likewise.
6022 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6023 to int.
6f04d126
PE
6024 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6025 avoiding the 0 flag, which is not portable.
c2982e87
PE
6026 * process.c (Fmake_network_process): Use pI to avoid cast.
6027 * region-cache.c (pp_cache): Likewise.
6028 * xdisp.c (decode_mode_spec): Likewise.
6029 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6030 behavior on 64-bit hosts with printf arg.
6f04d126 6031 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6032 (x_stop_queuing_selection_requests): Likewise.
6033 (x_get_window_property): Don't truncate byte count to an 'int'
6034 when tracing.
0b432f21 6035
5e073ec7
PE
6036 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6037 here, since it parses constructs like leading '-' and spaces,
6038 which are not wanted; and it overflows with large numbers.
6039 Instead, simply match F[0-9]+, which is what is wanted anyway.
6040
36372bf9
PE
6041 * alloc.c: Remove unportable assumptions about struct layout.
6042 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6043 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6044 (allocate_vectorlike, make_pure_vector): Use the new macros,
6045 plus offsetof, to remove unportable assumptions about struct layout.
6046 These assumptions hold on all porting targets that I know of, but
6047 they are not guaranteed, they're easy to remove, and removing them
6048 makes further changes easier.
6049
0b432f21
PE
6050 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6051 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6052 (string_overrun_cookie): Now const. Use initializers that
6053 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6054 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6055 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6056 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6057 multiple of sizeof (EMACS_INT); it need not be, if
6058 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6059 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6060
895009e1
JB
60612011-04-26 Juanma Barranquero <lekktu@gmail.com>
6062
6063 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6064
6a7a1b0b
TZ
60652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6066
6067 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6068 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6069 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6070
841a1577 60712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6072
6073 * lisp.h (Qdebug): List symbol.
895009e1 6074 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6075 * keyboard.c (debug-on-event): New variable.
6076 (handle_user_signal): Break into debugger when debug-on-event
6077 matches the current signal symbol.
6078
f2d3ba6f
DN
60792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6080
6081 * alloc.c (check_sblock, check_string_bytes)
6082 (check_string_free_list): Convert to standard C.
6083
42ce4c63
TZ
60842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6085
6086 * w32.c (emacs_gnutls_push): Fix typo.
6087
825cd63c
EZ
60882011-04-25 Eli Zaretskii <eliz@gnu.org>
6089
fb11d64d
EZ
6090 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6091 "cast to pointer from integer of different size".
6092
825cd63c
EZ
6093 Improve doprnt and its use in verror. (Bug#8545)
6094 * doprnt.c (doprnt): Document the set of format control sequences
6095 supported by the function. Use SAFE_ALLOCA instead of always
6096 using `alloca'.
6097
6098 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6099 is one byte too soon. Don't use xrealloc; instead xfree and
6100 xmalloc anew.
6101
e061a11b
TZ
61022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6103
6104 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6105 callbacks stage.
6106
6107 * gnutls.c: Renamed global_initialized to
6108 gnutls_global_initialized. Added internals for the
6109 :verify-hostname-error, :verify-error, and :verify-flags
6110 parameters of `gnutls-boot' and documented those parameters in the
6111 docstring. Start callback support.
9173deec
JB
6112 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6113 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6114 on error. Return error code.
e061a11b
TZ
6115 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6116 (emacs_gnutls_read): Likewise.
6117 (Fgnutls_boot): Return handshake error code.
6118 (emacs_gnutls_handle_error): New function.
6119 (wsaerror_to_errno): Likewise.
6120
6121 * w32.h (emacs_gnutls_pull): Add prototype.
6122 (emacs_gnutls_push): Likewise.
6123
6124 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6125 (emacs_gnutls_push): Likewise.
6126
61272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6128
6129 * process.c (wait_reading_process_output): Check if GnuTLS
6130 buffered some data internally if no FDs are set for TLS
6131 connections.
6132
6133 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6134 (LIBS): Link to USER_LIBS.
6135 ($(BLD)/gnutls.$(0)): New target.
6136
fa6996bc
EZ
61372011-04-24 Eli Zaretskii <eliz@gnu.org>
6138
eb35682e
EZ
6139 * xdisp.c (handle_single_display_spec): Rename the
6140 display_replaced_before_p argument into display_replaced_p, to
6141 make it consistent with the commentary. Fix typos in the
6142 commentary.
6143
e2ad650c
EZ
6144 * textprop.c (syms_of_textprop): Remove dead code.
6145 (copy_text_properties): Delete obsolete commentary about an
6146 interface that was deleted long ago. Fix typos in the description
6147 of arguments.
6148
1b2de274
EZ
6149 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6150 to changes in oldXMenu/XMenu.h from 2011-04-16.
6151 <menu_help_message, prev_menu_help_message>: Constify.
6152 (IT_menu_make_room): menu->help_text is now `const char **';
6153 adjust.
6154
6155 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6156 to changes in oldXMenu/XMenu.h from 2011-04-16.
6157 (struct XMenu): Declare `help_text' `const char **'.
6158
6159 * xfaces.c <Qunspecified>: Make extern again.
6160
6161 * syntax.c: Include sys/types.h before including regex.h, as
6162 required by Posix.
6163
762b15be
EZ
6164 * doc.c (get_doc_string): Improve the format passed to `error'.
6165
6166 * doprnt.c (doprnt): Improve commentary.
6167
6168 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6169
6170 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6171 them with etags.
6172
f1052e5d
EZ
6173 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6174 changes in globals.h immediately force recompilation.
762b15be
EZ
6175 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6176 $(CURDIR)/s/ms-w32.h.
6177 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6178
fa6996bc
EZ
6179 * character.c (Fchar_direction): Function deleted.
6180 (syms_of_character): Don't defsubr it.
6181 <char-direction-table>: Deleted.
6182
e6c3da20
EZ
61832011-04-23 Eli Zaretskii <eliz@gnu.org>
6184
6185 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6186 * doprnt.c: Include limits.h.
6187 (SIZE_MAX): New macro.
04f2d78b
CB
6188 (doprnt): Return a size_t value. 2nd arg is now size_t.
6189 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6190 Improve overflow protection. Support `l' modifier for integer
6191 conversions. Support %l conversion. Don't assume an EMACS_INT
6192 argument for integer conversions and for %c.
6193
6194 * lisp.h (doprnt): Restore prototype.
6195
6196 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6197 $(SRC)/character.h.
6198
6199 * Makefile.in (base_obj): Add back doprnt.o.
6200
6201 * deps.mk (doprnt.o): Add back prerequisites.
6202 (callint.o): Depend on character.h.
6203
6204 * eval.c (internal_lisp_condition_case): Include the handler
6205 representation in the error message.
6206 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6207 when breaking from the loop.
6208
6209 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6210
6211 * callint.c (Fcall_interactively): When displaying error message
6212 about invalid control letter, pass the character's codepoint, not
6213 a pointer to its multibyte form. Improve display of the character
6214 in octal and display also its hex code.
6215
6216 * character.c (char_string): Use %x to display the (unsigned)
6217 codepoint of an invalid character, to avoid displaying a bogus
6218 negative value.
6219
6220 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6221 `error', not SYMBOL_NAME itself.
6222
6223 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6224 character arguments to `error'.
6225
6226 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6227 to `error' in error message about FINAL_CHAR argument. Make sure
6228 FINAL_CHAR is a character, and use %c when it is passed as
6229 argument to `error'.
6230
4ffd0d6b 62312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6232
6233 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6234
6235 * w32.c: Include <time.h>.
6236 (sys_localtime): New function.
6237
4ffd0d6b 62382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6239
6240 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6241
4ffd0d6b 6242 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6243
4ffd0d6b 62442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6245
4ffd0d6b
GM
6246 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6247 zombies (Bug#8467).
aac0c6e3 6248
04c56954
EZ
62492011-04-19 Eli Zaretskii <eliz@gnu.org>
6250
6251 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6252 gl_state.e_property when gl_state.object is Qt.
6253
6254 * insdel.c (make_gap_larger): Remove limitation of buffer size
6255 to <= INT_MAX.
6256
16a43933
CY
62572011-04-18 Chong Yidong <cyd@stupidchicken.com>
6258
6259 * xdisp.c (lookup_glyphless_char_display)
6260 (produce_glyphless_glyph): Handle cons cell entry in
6261 glyphless-char-display.
6262 (Vglyphless_char_display): Document it.
6263
6264 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6265 glyphless-char-display.
6266
4581706e
CY
62672011-04-17 Chong Yidong <cyd@stupidchicken.com>
6268
6269 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6270
6271 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6272
6273 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6274 definition for no-X builds.
6275
4887c6e2 62762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6277
fd35b6f9
PE
6278 Static checks with GCC 4.6.0 and non-default toolkits.
6279
5c1ccb01
PE
6280 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6281
006c5daa
PE
6282 * process.c (keyboard_bit_set): Define only if SIGIO.
6283 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6284 (send_process): Repair possible setjmp clobbering.
6285
efc736d3
PE
6286 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6287
4e2fe2e6
PE
6288 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6289
f97334a2
PE
6290 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6291
4e75f29d
PE
6292 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6293 Define only if needed.
6294
90efadd1
PE
6295 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6296 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6297 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6298
3c647824
PE
6299 * dispextern.h (struct redisplay_interface): Rename param
6300 to avoid shadowing.
e264f262 6301 * termhooks.h (struct terminal): Likewise.
761383f4 6302 * xterm.c (xembed_send_message): Likewise.
3c647824 6303
b58c5c4a
PE
6304 * insdel.c (make_gap_smaller): Define only if
6305 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6306
cad59032
PE
6307 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6308 it.
6309
c339dc2e
PE
6310 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6311 so that we aren't warned about unused symbols.
6312
91a3e27b
PE
6313 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6314
399c71d3 6315 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6316
8ffc96f5
PE
6317 * xfns.c (x_real_positions): Mark locals as initialized.
6318
eef9bc79
PE
6319 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6320
098db9dd
PE
6321 * xterm.c: Fix problems found by static analysis with other toolkits.
6322 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6323 (x_dispatch_event): Declare static if USE_GTK, and
6324 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6325 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6326 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6327 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6328 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6329
eb18f6cc
PE
6330 * xmenu.c (menu_help_callback): Pointer type fixes.
6331 Use const pointers when pointing at readonly data. Avoid pointer
6332 signedness clashes.
6333 (FALSE): Remove unused macro.
6334 (update_frame_menubar): Remove unused decl.
6335
1fe72bf8
PE
6336 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6337
60d9e1db
PE
6338 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6339 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6340 (single_menu_item): Rename local to avoid shadowing.
6341
39261c26
PE
6342 * keyboard.c (make_lispy_event): Remove unused local var.
6343
018c5e19
PE
6344 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6345 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6346
63d2b86e
PE
6347 * bitmaps: Change bitmaps from unsigned char back to the X11
6348 compatible char. Avoid the old compiler warnings about
6349 out-of-range initializers by using, for example, '\xab' rather
6350 than 0xab.
6351
aefd87e1
PE
6352 * xgselect.c (xgselect_initialize): Check vs interface
6353 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6354
bf501fb9
PE
6355 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6356
e9829fdf
PE
6357 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6358 to read-only memory.
6359
1086c095
PE
6360 * fns.c (vector): Remove; this old hack is no longer needed.
6361
2baccd04 6362 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6363 Remove unused var.
dde42981 6364 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6365
72391843 6366 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6367
436c16df 6368 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6369 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6370 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6371
92bb796d 6372 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6373 (x_term_init): Remove local to avoid shadowing.
92bb796d 6374
764430a3 6375 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6376
6377 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6378 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6379
d1dfb56c
EZ
63802011-04-16 Eli Zaretskii <eliz@gnu.org>
6381
c4354cb4
EZ
6382 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6383
d1dfb56c
EZ
6384 Fix regex.c, syntax.c and friends for buffers > 2GB.
6385 * syntax.h (struct gl_state_s): Declare character position members
6386 EMACS_INT.
6387
6388 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6389
04f2d78b
CB
6390 * textprop.c (verify_interval_modification, interval_of):
6391 Declare arguments EMACS_INT.
d1dfb56c
EZ
6392
6393 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6394 EMACS_INT.
6395
6396 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6397
6398 * indent.c (Fvertical_motion): Local variable it_start is now
6399 EMACS_INT.
6400
6401 * regex.c (re_match, re_match_2, re_match_2_internal)
6402 (bcmp_translate, regcomp, regexec, print_double_string)
6403 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6404 (re_compile_pattern, re_exec): Declare arguments and local
6405 variables `size_t' and `ssize_t' and return values `regoff_t', as
6406 appropriate.
6407 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6408 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6409 <compile_stack_type>: `size' and `avail' are now `size_t'.
6410
6411 * regex.h <regoff_t>: Use ssize_t, not int.
6412 (re_search, re_search_2, re_match, re_match_2): Arguments that
6413 specify buffer/string position and length are now ssize_t and
6414 size_t. Return type is regoff_t.
6415
613052cd
BK
64162011-04-16 Ben Key <bkey76@gmail.com>
6417
6418 * nsfont.m: Fixed bugs in ns_get_family and
6419 ns_descriptor_to_entity that were caused by using free to
6420 deallocate memory blocks that were allocated by xmalloc (via
6421 xstrdup). This caused Emacs to crash when compiled with
6422 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6423 --enable-checking=xmallocoverrun). xfree is now used to
6424 deallocate these memory blocks.
6425
4170f62f 64262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6427
71b41406
PE
6428 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6429
9587a89d
PE
6430 emacs_write: Accept and return EMACS_INT for sizes.
6431 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6432 et seq.
6433 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6434 Accept and return EMACS_INT.
6435 (emacs_gnutls_write): Return the number of bytes written on
6436 partial writes.
6437 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6438 (emacs_read, emacs_write): Remove check for negative size, as the
6439 Emacs source code has been audited now.
9587a89d
PE
6440 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6441 (emacs_read, emacs_write): Use it.
273a5f82
PE
6442 * process.c (send_process): Adjust to the new signatures of
6443 emacs_write and emacs_gnutls_write. Do not attempt to store
6444 a byte offset into an 'int'; it might overflow.
9587a89d 6445 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6446
3e047f51
PE
6447 * sound.c: Don't assume sizes fit in 'int'.
6448 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6449 Return EMACS_INT, not int.
3e047f51 6450 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6451 Accept EMACS_INT, not int.
6452 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6453 record read return values.
6454
cc39a9db
BK
64552011-04-15 Ben Key <bkey76@gmail.com>
6456
c9d0ec6d
JB
6457 * keyboard.c (Qundefined): Don't declare static since it is used
6458 in nsfns.m.
6459 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6460 static since they are used in nsfont.m.
cc39a9db 6461
6c60eb9f
SM
64622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6463
6464 * process.c (Qprocessp): Don't declare static.
6465 * lisp.h (Qprocessp): Declare again.
6466
7990b61a
JB
64672011-04-15 Juanma Barranquero <lekktu@gmail.com>
6468
6469 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6470
5d4cb038
PE
64712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6472
8bd7b830 6473 Improve C-level modularity by making more things 'static'.
cd64ea1d 6474
e3b27b31
PE
6475 Don't publish debugger-only interfaces to other modules.
6476 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6477 (verify_bytepos, count_markers): Move decls to the only modules
6478 that need them.
6479 * region-cache.h (pp_cache): Likewise.
6480 * window.h (check_all_windows): Likewise.
6481 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6482
5d4cb038
PE
6483 * sysdep.c (croak): Now static, if
6484 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6485 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6486
6487 * alloc.c (refill_memory_reserve): Now static if
6488 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6489 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6490
e87b6180
PE
6491 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6492 Define only if USE_LUCID.
6493
ac64929e
PE
6494 * xrdb.c (x_customization_string, x_rm_string): Now static.
6495
6f37259d
PE
6496 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6497 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6498
1683e3ab
PE
6499 * xdisp.c (draw_row_with_mouse_face): Now static.
6500 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6501
de9c2632
PE
6502 * window.h (check_all_windows): Mark externally visible.
6503
2b96acb7
PE
6504 * window.c (window_deletion_count): Now static.
6505
6506 * undo.c: Make symbols static if they're not exported.
6507 (last_undo_buffer, last_boundary_position, pending_boundary):
6508 Now static.
6509
50436f33
PE
6510 * textprop.c (interval_insert_behind_hooks): Now static.
6511 (interval_insert_in_front_hooks): Likewise.
6512
64520e5c
PE
6513 * term.c: Make symbols static if they're not exported.
6514 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6515 (max_frame_lines, tty_set_terminal_modes):
6516 (tty_reset_terminal_modes, tty_turn_off_highlight):
6517 (get_tty_terminal): Now static.
6518 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6519 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6520 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6521 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6522 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6523
1fa53021
PE
6524 * sysdep.c: Make symbols static if they're not exported.
6525 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6526 Now static.
6527 (sigprocmask_set, full_mask): Remove; unused.
6528 (wait_debugging): Mark as visible.
6529 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6530 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6531
d4b43b22
PE
6532 * syntax.c (syntax_temp): Define only if !__GNUC__.
6533
b7c513d0
PE
6534 * sound.c (current_sound_device, current_sound): Now static.
6535
989b29ad
PE
6536 * search.c (searchbufs, searchbuf_head): Now static.
6537
13a55a78
PE
6538 * scroll.c (scroll_cost): Remove; unused.
6539 * dispextern.h (scroll_cost): Remove decl.
6540
de68a1fc
PE
6541 * region-cache.h (pp_cache): Mark as externally visible.
6542
40ccffa6
PE
6543 * process.c: Make symbols static if they're not exported.
6544 (process_tick, update_tick, create_process, chan_process):
6545 (Vprocess_alist, proc_buffered_char, datagram_access):
6546 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6547 (deactivate_process): Mark defn as static, as well as decl.
6548 * lisp.h (create_process): Remove decl.
6549 * process.h (chan_process, Vprocess_alist): Remove decls.
6550
ad64fc97
PE
6551 * print.c: Make symbols static if they're not exported.
6552 (print_depth, new_backquote_output, being_printed, print_buffer):
6553 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6554 (print_interval, print_number_index, initial_stderr_stream):
6555 Now static.
6556 * lisp.h (Fprinc): Remove decl.
6557 (debug_output_compilation_hack): Mark as externally visible.
6558
adddb265
PE
6559 * sysdep.c (croak): Move decl from here to syssignal.h.
6560 * syssignal.h (croak): Put it here, so the API can be checked when
6561 'croak' is called from dissociate_if_controlling_tty.
6562
1717ede2
PE
6563 * minibuf.c: Make symbols static if they're not exported.
6564 (minibuf_save_list, choose_minibuf_frame): Now static.
6565 * lisp.h (choose_minibuf_frame): Remove decl.
6566
fa5fb2bc
PE
6567 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6568
1e3890d1
PE
6569 * lread.c: Make symbols static if they're not exported.
6570 (read_objects, initial_obarray, oblookup_last_bucket_number):
6571 Now static.
6572 (make_symbol): Remove; unused.
6573 * lisp.h (initial_obarray, make_symbol): Remove decls.
6574
8a1414fa
PE
6575 * keyboard.c: Make symbols static if they're not exported.
6576 (single_kboard, recent_keys_index, total_keys, recent_keys):
6577 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6578 (this_single_command_key_start, echoing, last_auto_save):
6579 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6580 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6581 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6582 (Vlispy_mouse_stem, double_click_count):
6583 Now static.
6584 (force_auto_save_soon): Define only if SIGDANGER.
6585 (ignore_mouse_drag_p): Now static if
6586 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6587 (print_help): Remove; unused.
6588 (stop_character, last_timer_event): Mark as externally visible.
6589 * keyboard.h (ignore_mouse_drag_p): Declare only if
6590 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6591 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6592 * lisp.h (echoing): Remove decl.
6593 (force_auto_save_soon): Declare only if SIGDANGER.
6594 * xdisp.c (redisplay_window): Simplify code, to make it more
6595 obvious that ignore_mouse_drag_p is not accessed if !defined
6596 USE_GTK && !defined HAVE_NS.
6597
93ea6e8f
PE
6598 * intervals.c: Make symbols static if they're not exported.
6599 (merge_properties_sticky, merge_interval_right, delete_interval):
6600 Now static.
6601 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6602
77382fcc
PE
6603 * insdel.c: Make symbols static if they're not exported.
6604 However, leave prepare_to_modify_buffer alone. It's never
6605 called from outside this function, but that appears to be a bug.
6606 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6607 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6608 (adjust_after_replace_noundo): Remove; unused.
6609 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6610 (signal_before_change): Remove decls.
77382fcc 6611
9306c32e
PE
6612 * indent.c (val_compute_motion, val_vmotion): Now static.
6613
cd44d2eb
PE
6614 * image.c: Make symbols static if they're not exported.
6615 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6616 if USE_GTK.
6617 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6618 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6619
ad9a7a06
PE
6620 * fringe.c (standard_bitmaps): Now static.
6621 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6622
81626931
PE
6623 * frame.c: Make symbols static if they're not exported.
6624 (x_report_frame_params, make_terminal_frame): Now static.
6625 (get_frame_param): Now static, unless HAVE_NS.
6626 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6627 (x_get_resource_string): Remove; not used.
6628 * frame.h (make_terminal_frame, x_report_frame_params):
6629 (x_get_resource_string); Remove decls.
6630 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6631 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6632
239f9db9
PE
6633 * font.c, fontset.c: Make symbols static if they're not exported.
6634 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6635 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6636 * font.c (font_close_object): Now static.
6637 * font.h (font_close_object): Remove.
6638 * fontset.c (FONTSET_OBJLIST): Remove.
6639 (free_realized_fontset) #if-0 the body, which does nothing.
6640 (face_suitable_for_char_p): #if-0, as it's never called.
6641 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6642 * xfaces.c (face_at_string_position):
6643 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6644 since 0 is always ASCII.
6645
dfcf3579
PE
6646 * fns.c (weak_hash_tables): Now static.
6647
5045092b
PE
6648 * fileio.c: Make symbols static if they're not exported.
6649 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6650 (Vwrite_region_annotation_buffers): Now static.
6651
57a96f5c
PE
6652 * eval.c: Make symbols static if they're not exported.
6653 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6654 * lisp.h (backtrace_list): Remove decl.
6655
35f08c38
PE
6656 * emacs.c: Make symbols static if they're not exported.
6657 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6658 (fatal_error_code, fatal_error_signal_hook, standard_args):
6659 Now static.
6660 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6661 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6662 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6663 * lisp.h (fatal_error_signal_hook): Remove decl.
6664 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6665
f44bd759
PE
6666 * editfns.c: Move a (normally-unused) function to its only use.
6667 * editfns.c, lisp.h (get_operating_system_release): Remove.
6668 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6669 worth the hassle of breaking this out.
6670
b532497d
PE
6671 * xterm.c: Make symbols static if they're not exported.
6672 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6673 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6674 (x_destroy_window, x_delete_display):
6675 Now static.
6676 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6677 (x_mouse_leave): Remove; unused.
6678 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6679 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6680 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6681 Remove decls.
6682 (x_mouse_leave): Declare only if WINDOWSNT.
6683 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6684 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6685 USE_X_TOOLKIT.
6686
1675728f
PE
6687 * ftxfont.c: Make symbols static if they're not exported.
6688 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6689 HAVE_FREETYPE.
6690 * font.h (ftxfont_driver): Likewise.
6691
e4cebfca
PE
6692 * xfns.c: Make symbols static if they're not exported.
6693 (x_last_font_name, x_display_info_for_name):
6694 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6695 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6696 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6697 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6698 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6699 (last_show_tip_args): Now static.
6700 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6701 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6702 (x_screen_planes): Remove; unused.
6703 * dispextern.h (x_screen_planes): Remove decl.
6704
5bf46f05
PE
6705 * dispnew.c: Make symbols static if they're not exported.
6706 * dispextern.h (redraw_garbaged_frames, scrolling):
6707 (increment_row_positions): Remove.
6708 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6709 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6710 Now static.
6711 (redraw_garbaged_frames): Remove; unused.
6712
435f4c28
PE
6713 * xfaces.c: Make symbols static if they're not exported.
6714 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6715 Remove decls.
6716 * xterm.h (defined_color): Remove decls.
6717 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6718 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6719 (menu_face_changed_default, defined_color, free_realized_face):
6720 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6721 (ascii_face_of_lisp_face): Remove; unused.
6722
8524aef3
PE
6723 * xdisp.c: Make symbols static if they're not exported.
6724 * dispextern.h (scratch_glyph_row, window_box_edges):
6725 (glyph_to_pixel_coords, set_cursor_from_row):
6726 (get_next_display_element, set_iterator_to_next):
6727 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6728 (show_mouse_face): Remove decls
6729 * frame.h (message_buf_print): Likewise.
6730 * lisp.h (pop_message, set_message, check_point_in_composition):
6731 Likewise.
6732 * xterm.h (set_vertical_scroll_bar): Likewise.
6733 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6734 (message_buf_print, scratch_glyph_row, displayed_buffer):
6735 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6736 (get_next_display_element, show_mouse_face, window_box_edges):
6737 (frame_to_window_pixel_xy, check_point_in_composition):
6738 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6739 (glyph_to_pixel_coords): Remove; unused.
6740
16390cd2
PE
6741 * dired.c (file_name_completion): Now static.
6742
6743 * dbusbind.c (xd_in_read_queued_messages): Now static.
6744
a25f4dfa
PE
6745 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6746 * data.c (circular_list_error): Remove.
6747
14a9c8df
PE
6748 * commands.h (last_point_position, last_point_position_buffer):
6749 (last_point_position_window): Remove decls.
6750 * keyboard.c: Make these variables static.
6751
04f2d78b
CB
6752 * coding.h (coding, code_convert_region, encode_coding_gap):
6753 Remove decls.
74ab6df5
PE
6754 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6755 (iso_code_class, detect_coding, code_convert_region): Now static.
6756 (encode_coding_gap): Remove; unused.
6757
38dfbee1
PE
6758 * chartab.c (chartab_chars, chartab_bits): Now static.
6759
a2cb4e63
PE
6760 * charset.h (charset_iso_8859_1): Remove decl.
6761 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6762 Now static.
6763
127198fd
PE
6764 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6765 * ccl.c (Vccl_program_table): Now static.
6766 (check_ccl_update): Remove; unused.
6767
d85b608f
PE
6768 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6769 * category.h: ... from here.
6770 * category.c (check_category_table, set_category_set): Now static.
6771
31cd66f3
PE
6772 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6773 * lisp.h: Remove these decls.
6774
c358e587
PE
6775 * buffer.c (buffer_count): Remove unused var.
6776
e78aecca
PE
6777 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6778 so that it's not optimized away.
6779 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6780 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6781 exported only to the debugger.
6782
e192d7d3 6783 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6784 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6785
92470028
PE
6786 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6787 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6788 was inaccessible from Lisp.
6789 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6790 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6791
244ed907
PE
6792 alloc.c: Import and export fewer symbols, and remove unused items.
6793 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6794 is defined.
6795 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6796 it's not optimized away by whole-program optimization.
6797 (message_enable_multibyte, free_misc): Remove.
6798 (catchlist, handlerlist, mark_backtrace):
6799 Declare only if BYTE_MARK_STACK.
6800 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6801 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6802 (message_enable_multibyte): Remove decl.
6803 (free_misc, interval_free_list, float_block, float_block_index):
6804 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6805 (cons_free_list, last_marked_index):
6806 Now static.
6807 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6808 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6809 (mark_backtrace): Define only if BYTE_MARK_STACK.
6810 * xdisp.c (message_enable_multibyte): Now static.
6811
61c2b50e 6812 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6813 This makes it easier for human readers (and static analyzers)
6814 to see whether these variables are used from other modules.
6815 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6816 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6817 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6818 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6819 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6820 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6821 * xmenu.c, xselect.c:
6822 Declare Q* vars static if they are not used in other modules.
6823 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6824 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6825 Remove decls of unexported vars.
6826 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6827
95c82688
PE
6828 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6829
16a97296
PE
6830 Make Emacs functions such as Fatom 'static' by default.
6831 This makes it easier for human readers (and static analyzers)
6832 to see whether these functions can be called from other modules.
6833 DEFUN now defines a static function. To make the function external
6834 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6835 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6836 (Finit_image_library):
16a97296
PE
6837 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6838 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6839 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6840 Remove decls, since these functions are now static.
6841 (Funintern, Fget_internal_run_time): New decls, since these functions
6842 were already external.
95c82688 6843
16a97296
PE
6844 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6845 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6846 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6847 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6848 * keyboard.c, keymap.c, lread.c:
6849 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6850 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6851 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6852 Mark functions with DEFUE instead of DEFUN,
6853 if they are used in other modules.
6854 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6855 decls for now-static functions.
6856 * buffer.h (Fdelete_overlay): Remove decl.
6857 * callproc.c (Fgetenv_internal): Mark as internal.
6858 * composite.c (Fremove_list_of_text_properties): Remove decl.
6859 (Fcomposition_get_gstring): New forward static decl.
6860 * composite.h (Fcomposite_get_gstring): Remove decl.
6861 * dired.c (Ffile_attributes): New forward static decl.
6862 * doc.c (Fdocumntation_property): New forward static decl.
6863 * eval.c (Ffetch_bytecode): New forward static decl.
6864 (Funintern): Remove extern decl; now in .h file where it belongs.
6865 * fileio.c (Fmake_symbolic_link): New forward static decl.
6866 * image.c (Finit_image_library): New forward static decl.
6867 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6868 * intervals.h (Fprevious_property_change):
6869 (Fremove_list_of_text_properties): Remove decls.
6870 * keyboard.c (Fthis_command_keys): Remove decl.
6871 (Fcommand_execute): New forward static decl.
6872 * keymap.c (Flookup_key): New forward static decl.
6873 (Fcopy_keymap): Now static.
6874 * keymap.h (Flookup_key): Remove decl.
6875 * process.c (Fget_process): New forward static decl.
6876 (Fprocess_datagram_address): Mark as internal.
6877 * syntax.c (Fsyntax_table_p): New forward static decl.
6878 (skip_chars): Remove duplicate decl.
6879 * textprop.c (Fprevious_property_change): New forward static decl.
6880 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6881 Now internal.
6882 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6883 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6884
785bbd42
PE
6885 * editfns.c (Fformat): Remove unreachable code.
6886
8b913b57
AS
68872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6888
6889 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6890 change. (Bug#8496)
6891
a6744a35
EZ
68922011-04-13 Eli Zaretskii <eliz@gnu.org>
6893
6894 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6895 when at ZV. (Bug#8487)
6896
e7974947
AS
68972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6898
baad03f0
AS
6899 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6900 (Bug#8437)
6901 * keyboard.c (parse_tool_bar_item): Likewise.
6902 * sound.c (sound_cleanup, alsa_close): Likewise.
6903 * termcap.c (tgetent): Likewise.
6904 * xfns.c (x_default_font_parameter): Likewise.
6905 * xsettings.c (read_and_apply_settings): Likewise.
6906
e7974947
AS
6907 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6908 (overrun_check_free): Protoize.
6909
28272684
PE
69102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6911
6912 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6913 since callers should never pass a negative size.
6914 Change the signature to match that of plain 'read' and 'write'; see
6915 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6916 * lisp.h: Update prototypes of emacs_write and emacs_read.
6917
11997c76
EZ
69182011-04-11 Eli Zaretskii <eliz@gnu.org>
6919
6920 * xdisp.c (redisplay_window): Don't try to determine the character
6921 position of the scroll margin if the window start point w->startp
e896f03c 6922 is outside the buffer's accessible region. (Bug#8468)
11997c76 6923
8a2cbd72
EZ
69242011-04-10 Eli Zaretskii <eliz@gnu.org>
6925
6926 Fix write-region and its subroutines for buffers > 2GB.
6927 * fileio.c (a_write, e_write): Modify declaration of arguments and
6928 local variables to support buffers larger than 2GB.
6929 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6930
6931 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6932 argument, local variables, and return value.
6933
6934 * lisp.h: Update prototypes of emacs_write and emacs_read.
6935
6936 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6937
4073e537 69382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6939
1ebfdcb6
PE
6940 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6941
b2ded58d
PE
6942 Fix more problems found by GCC 4.6.0's static checks.
6943
7d66342c
PE
6944 * xdisp.c (vmessage): Use a better test for character truncation.
6945
bbf47d44
PE
6946 * charset.c (load_charset_map): <, not <=, for optimization,
6947 and to avoid potential problems with integer overflow.
9248994d 6948 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6949 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6950 * editfns.c (Fformat): Likewise.
1e69125e 6951 * syntax.c (skip_chars): Likewise.
3befa583 6952
e3019616
PE
6953 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6954 This also lets GCC 4.6.0 generate slightly better loop code.
6955
becfa255
PE
6956 * callint.c (Fcall_interactively): <, not <=, for optimization.
6957 (Fcall_interactively): Count the number of arguments produced,
6958 not the number of arguments given. This is simpler and lets GCC
6959 4.6.0 generate slightly better code.
6960
dae0cd48
PE
6961 * ftfont.c: Distingish more carefully between FcChar8 and char.
6962 The previous code passed unsigned char * to a functions like
6963 strlen and xstrcasecmp that expect char *, which does not
6964 conform to the C standard.
6965 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6966 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6967 char * when the C standard requires it.
6968
76032d70
PE
6969 * keyboard.c (read_char): Remove unused var.
6970
eb3f1cc8
PE
6971 * eval.c: Port to Windows vsnprintf (Bug#8435).
6972 Include <limits.h>.
6973 (SIZE_MAX): Define if the headers do not.
6974 (verror): Do not give up if vsnprintf returns a negative count.
6975 Instead, grow the buffer. This ports to Windows vsnprintf, which
6976 does not conform to C99. Problem reported by Eli Zaretskii.
6977 Also, simplify the allocation scheme, by avoiding the need for
6978 calling realloc, and removing the ALLOCATED variable.
6979
70476b54
PE
6980 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6981
12020a9e
PE
6982 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6983 But keep the doprint source code for now, as we might revamp it
6984 and use it again (Bug#8435).
ea6c7ae6
PE
6985 * lisp.h (doprnt): Remove.
6986 * Makefile.in (base_obj): Remove doprnt.o.
6987 * deps.mk (doprnt.o): Remove.
6988
5fdb398c
PE
6989 error: Print 32- and 64-bit integers portably (Bug#8435).
6990 Without this change, on typical 64-bit hosts error ("...%d...", N)
6991 was used to print both 32- and 64-bit integers N, which relied on
6992 undefined behavior.
6993 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6994 New macro.
6995 * lisp.h (error, verror): Mark as printf-like functions.
6996 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6997 Report overflow in size calculations when allocating printf buffer.
6998 Do not truncate output string at its first null byte.
6999 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7000 Truncate the output at a character boundary, since vsnprintf does not
7001 do that.
7002 * charset.c (check_iso_charset_parameter): Convert internal
7003 character to string before calling 'error', since %c now has the
7004 printf meaning.
7005 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7006 overflow when computing char to be passed to 'error'. Do not
7007 pass Lisp_Object to 'error'; pass the integer instead.
7008 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7009 formatted with plain %d.
7010
b189fa66
PE
7011 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7012
bff87ef0
PE
7013 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7014
7e2cac20
PE
7015 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7016
ce4d90b5
PE
7017 * xterm.c (x_catch_errors): Remove duplicate declaration.
7018
266c9547
PE
7019 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7020
79c49ad2
PE
7021 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7022
368f4090
JM
70232011-04-10 Jim Meyering <meyering@redhat.com>
7024
7025 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7026 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7027 return ssize_t not "int", and use size_t as the buffer length.
7028 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7029 * gnutls.h: Update declarations.
7030 * process.c (read_process_output): Use ssize_t, to match.
7031 (send_process): Likewise.
7032
a32d4040
CY
70332011-04-09 Chong Yidong <cyd@stupidchicken.com>
7034
7035 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7036
8546720e 70372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7038
04f2d78b
CB
7039 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7040 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7041
8546720e
GM
7042 * xterm.c (handle_one_xevent):
7043 * xmenu.c (create_and_show_popup_menu):
7044 * xselect.c (x_decline_selection_request)
7045 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7046
0a2f5c1a 70472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7048
7049 Fix some uses of `int' instead of EMACS_INT.
7050 * search.c (string_match_1, fast_string_match)
7051 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7052 (scan_buffer, find_next_newline_no_quit)
7053 (find_before_next_newline, search_command, Freplace_match)
7054 (Fmatch_data): Make some `int' variables be EMACS_INT.
7055
7056 * xdisp.c (display_count_lines): 3rd argument and return value now
7057 EMACS_INT. All callers changed.
7058 (pint2hrstr): Last argument is now EMACS_INT.
7059
7060 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7061 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7062 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7063 (decode_coding_utf_16, decode_coding_emacs_mule)
7064 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7065 (decode_coding_ccl, decode_coding_charset)
7066 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7067 (decode_coding_iso_2022, decode_coding_emacs_mule)
7068 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7069 <char_offset, last_offset>: Declare EMACS_INT.
7070 (encode_coding_utf_8, encode_coding_utf_16)
7071 (encode_coding_emacs_mule, encode_invocation_designation)
7072 (encode_designation_at_bol, encode_coding_iso_2022)
7073 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7074 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7075 Declare EMACS_INT.
7076 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7077 (encode_invocation_designation): Last argument P_NCHARS is now
7078 EMACS_INT.
7079 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7080 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7081
7082 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7083 All users changed.
7084
7085 * ccl.c (Fccl_execute_on_string): Declare some variables
7086 EMACS_INT.
7087
8546720e 70882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7089
7090 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7091
4e19a977
CS
70922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7093
7094 * process.c (Fformat_network_address): Doc fix.
7095
87302331
R
70962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7097
7098 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7099
cbb59342
CY
71002011-04-08 Chong Yidong <cyd@stupidchicken.com>
7101
7102 * keyboard.c (read_char): Call Lisp function help-form-show,
7103 instead of using internal_with_output_to_temp_buffer.
7104 (Qhelp_form_show): New var.
e0d38eeb 7105 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7106
7107 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7108
7109 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7110
e67a13ab
CY
71112011-04-06 Chong Yidong <cyd@stupidchicken.com>
7112
04f2d78b
CB
7113 * process.c (Flist_processes): Remove to Lisp.
7114 (list_processes_1): Delete.
e67a13ab 7115
973f782d
EZ
71162011-04-06 Eli Zaretskii <eliz@gnu.org>
7117
7c106b1e
EZ
7118 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7119
973f782d
EZ
7120 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7121
41cf7d1a 71222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7123
ca23cc88
PE
7124 Fix more problems found by GCC 4.6.0's static checks.
7125
f390e2d5
PE
7126 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7127
42eea0d0
PE
7128 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7129
b69769da 7130 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7131
f9541e84
PE
7132 * xdisp.c (vmessage): Mark as a printf-like function.
7133
13841b55
PE
7134 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7135
c136c10f
PE
7136 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7137
5e2d4a30
PE
7138 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7139 printf-like functions.
7140 (tiff_load): Add casts to remove these marks before passing them
7141 to system-supplied API.
7142
583f48b9
PE
7143 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7144
b25d760e
PE
7145 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7146 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7147 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7148 directly, rather than having caller test rule sign. This avoids
7149 some unnecessary tests.
7150 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7151 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7152 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7153
bc7b6697 7154 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7155 (xfont_open): Avoid unnecessary tests.
bc7b6697 7156
27ccc379
PE
7157 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7158
dcd5c89a
PE
7159 * composite.h, composite.c (composition_gstring_put_cache):
7160 Use EMACS_INT, not int, for length.
7161
b13a45c6
PE
7162 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7163 breaking out part of COMPOSITION_DECODE_RULE.
7164 (COMPOSITION_DECODE_RULE): Use it.
7165 * composite.c (get_composition_id): Remove unused local vars,
7166 by using the new macro.
7167
1e792e4d
PE
7168 * textprop.c (set_text_properties_1): Change while to do-while,
7169 since the condition is always true at first.
7170
dc6c6455 7171 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7172 (interval_deletion_adjustment): Return unsigned value.
7173 All uses changed.
dc6c6455 7174
aba7731a
PE
7175 * process.c (list_processes_1, create_pty, read_process_output):
7176 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7177 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7178 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7179 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7180 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7181
fdfc4bf3
PE
7182 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7183
fca8fe46 7184 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7185 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7186
06a0259a 7187 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7188 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7189 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7190
e7b9e80f
PE
7191 * print.c (print_error_message): Avoid int overflow.
7192
56201685
PE
7193 * font.c (font_list_entities): Redo for clarity,
7194 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7195
78834453 7196 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7197 (font_score): Avoid potential overflow in diff calculation.
78834453 7198
0bc0b309 7199 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7200 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7201
e610eaca
PE
7202 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7203
b895abce
PE
7204 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7205 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7206 can always succeed if overflow has undefined behavior.
7207
1f1d9321 7208 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7209 (wordify): Omit three unnecessary tests.
1f1d9321 7210
c59478bc
PE
7211 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7212 All callers changed. This avoids the need for an unused var.
7213
79b73827
PE
7214 * casefiddle.c (casify_region): Remove var that is set but not used.
7215
a4db5dfe
PE
7216 * dired.c (file_name_completion): Remove var that is set but not used.
7217
43aae36e
PE
7218 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7219
2a47c44d 7220 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7221 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7222
a37c69bf
PE
7223 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7224 Check for integer overflow on size calculations.
7225
328ab8e7
PE
7226 * buffer.c (Fprevious_overlay_change): Remove var that is set
7227 but not used.
7228
e5a2a5cb
PE
7229 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7230 Remove vars that are set but not used.
8d84a6eb 7231 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7232 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7233
a60e5f68
PE
7234 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7235
f661cb61 7236 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7237 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7238
f0397f5a
PE
7239 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7240 that are set but not used.
7241
8664db06 7242 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7243 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7244
6abdaa4a
PE
7245 * xselect.c (x_get_local_selection, x_handle_property_notify):
7246 Remove vars that are set but not used.
7247
0ce7538d 7248 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7249 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7250
9ae848fc
PE
7251 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7252 Remove var that is set but not used.
0b918413
PE
7253 (scroll_bar_windows_size): Now size_t, not int.
7254 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7255 Check for overflow.
9ae848fc 7256
a5a62657
PE
7257 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7258 (map_tty_color) [!defined MSDOS]: Likewise.
7259
5c5cdd39
PE
7260 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7261
66ebf983
PE
7262 * coding.c: Remove vars that are set but not used.
7263 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7264 All callers changed.
7265 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7266 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7267 (decode_coding_charset): Remove vars that are set but not used.
7268
1be4d761
PE
7269 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7270 that is set but not used.
7271
47553fa8
PE
7272 * print.c (print_object): Remove var that is set but not used.
7273
1f7196bf 7274 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7275 The gnulib version avoids calling malloc in the usual case,
7276 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7277 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7278 * filelock.c (current_lock_owner): Likewise.
7279 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7280 * sysdep.c: Include allocator.h, careadlinkat.h.
7281 (emacs_no_realloc_allocator): New static constant.
7282 (emacs_readlink): New function.
fdb61804
PE
7283 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7284 ../lib/careadlinkat.h.
d1fdcab7 7285
f84c17c7
SM
72862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7287
7288 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7289 first non-nil return value).
7290
ef3862ad
JD
72912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7292
7293 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7294 if not defined (Bug#8403).
7295
376a7006
JB
72962011-04-02 Juanma Barranquero <lekktu@gmail.com>
7297
7298 * xdisp.c (display_count_lines): Remove parameter `start',
7299 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7300 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7301 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7302 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7303 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7304 and thereabouts. All callers changed.
7305 (get_per_char_metric): Remove parameter `f', unused since
7306 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7307
6ca3801d
JM
73082011-04-02 Jim Meyering <meyering@redhat.com>
7309
7310 do not dereference NULL upon failed strdup
7311 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7312 (ns_get_family): Likewise.
7313
d8e2b5ba
JB
73142011-04-02 Juanma Barranquero <lekktu@gmail.com>
7315
7316 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7317
8c74fcbd
JD
73182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7319
7320 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7321 later (Bug#8403).
7322
7200d79c
SM
73232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7324
03408648 7325 Add lexical binding.
7200d79c 7326
03408648
SM
7327 * window.c (Ftemp_output_buffer_show): New fun.
7328 (Fsave_window_excursion):
7329 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7330
7331 * lread.c (lisp_file_lexically_bound_p): New function.
7332 (Fload): Bind Qlexical_binding.
7333 (readevalloop): Remove `evalfun' arg.
7334 Bind Qinternal_interpreter_environment.
7335 (Feval_buffer): Bind Qlexical_binding.
7336 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7337 Mark as dynamic.
7338 (syms_of_lread): Declare `lexical-binding'.
7339
7340 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7341
7342 * keyboard.c (eval_dyn): New fun.
7343 (menu_item_eval_property): Use it.
ca105506
SM
7344
7345 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7346
03408648
SM
7347 * fns.c (concat, mapcar1): Accept byte-code-functions.
7348
7349 * eval.c (Fsetq): Handle lexical vars.
7350 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7351 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7352 (FletX, Flet): Obey lexical binding.
7353 (Fcommandp): Handle closures.
7354 (Feval): New `lexical' arg.
7355 (eval_sub): New function extracted from Feval. Use it almost
7356 everywhere where Feval was used. Look up vars in lexical env.
7357 Handle closures.
7358 (Ffunctionp): Move from subr.el.
7359 (Ffuncall): Handle closures.
7360 (apply_lambda): Remove `eval_flags'.
7361 (funcall_lambda): Handle closures and new byte-code-functions.
7362 (Fspecial_variable_p): New function.
7363 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7364 but without exporting it to Lisp.
23aba0ea 7365
23aba0ea 7366 * doc.c (Fdocumentation, store_function_docstring):
03408648 7367 * data.c (Finteractive_form): Handle closures.
23aba0ea 7368
03408648
SM
7369 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7370 interactive spec.
ba83908c 7371
04f2d78b
CB
7372 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7373 New byte-codes.
03408648
SM
7374 (exec_byte_code): New function extracted from Fbyte_code to handle new
7375 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7376
03408648 7377 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7378
03408648 7379 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7380
e2abce01
JB
73812011-03-31 Juanma Barranquero <lekktu@gmail.com>
7382
7383 * xdisp.c (redisplay_internal): Fix prototype.
7384
63696a73 73852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7386
63696a73 7387 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7388 (try_scrolling): Use it when setting scroll_limit.
7389 Limit scrolling to 100 screen lines.
63696a73
EZ
7390 (redisplay_window): Even when falling back on "recentering",
7391 position point in the window according to scroll-conservatively,
7392 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7393
7394 (try_scrolling): When point is above the window, allow searching
7395 as far as scroll_max, or one screenful, to compute vertical
7396 distance from PT to the scroll margin position. This prevents
7397 try_scrolling from unnecessarily failing when
7398 scroll-conservatively is set to a value slightly larger than the
7399 window height. Clean up the case of PT below the margin at bottom
7400 of window: scroll_max can no longer be INT_MAX. When aggressive
7401 scrolling is in use, don't let point enter the opposite scroll
7402 margin as result of the scroll.
7403 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7404 threshold of 100 lines for never-recentering scrolling.
7405
e4cc2dfc
JB
74062011-03-31 Juanma Barranquero <lekktu@gmail.com>
7407
7408 * dispextern.h (move_it_by_lines):
7409 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7410 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7411 (message_log_check_duplicate): Remove parameters `prev_bol' and
7412 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7413 (redisplay_internal): Remove parameter `preserve_echo_area',
7414 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7415
7416 * indent.c (Fvertical_motion):
7417 * window.c (window_scroll_pixel_based, Frecenter):
7418 Don't pass `need_y_p' to `move_it_by_lines'.
7419
1c470562
SM
74202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7421
44f230aa
SM
7422 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7423 steal a few bits to be more compact.
7424 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7425 Remove unneeded casts.
7426
1c470562
SM
7427 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7428
888adce9
ZK
74292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7430
7431 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7432 binding" message (bug#7967).
7433
f838ed7b
PE
74342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7435
77861b95
PE
7436 Fix more problems found by GCC 4.6.0's static checks.
7437
de6dbc14
PE
7438 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7439 Remove unused local var.
7440
f838ed7b
PE
7441 * editfns.c (Fmessage_box): Remove unused local var.
7442
792c7b2b
PE
7443 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7444 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7445 Omit unused local vars.
c499e557 7446 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7447 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7448 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7449 Omit unused local var.
7450
ba0165e1
PE
7451 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7452 Don't assume string length fits in int.
32ad8845 7453 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7454 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7455
3c59b4c9
PE
7456 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7457 instead of alloca (Bug#8344).
7458
a3eed478 7459 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7460 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7461
eb4d412d
PE
7462 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7463
1658b401
PE
7464 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7465 concerns.
7466
7467 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7468
7469 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7470
9a2c6e05
PE
7471 * keyboard.c (syms_of_keyboard): Use the same style as later
7472 in this function when indexing through an array. This also
7473 works around GCC bug 48267.
7474
03d0a109
PE
7475 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7476
44f730c8
PE
7477 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7478
fe75f926
PE
7479 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7480 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7481
ffa8c828
PE
7482 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7483 This avoids undefined behavior on integer overflow, and is a bit
7484 more convenient anyway since it is compared to a size_t variable.
7485
c5101a77
PE
7486 Variadic C functions now count arguments with size_t, not int.
7487 This avoids an unnecessary limitation on 64-bit machines, which
7488 caused (substring ...) to crash on large vectors (Bug#8344).
7489 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7490 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7491 All variadic functions and their callers changed accordingly.
c5101a77
PE
7492 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7493 * data.c (arith_driver, float_arith_driver): Likewise.
7494 * editfns.c (general_insert_function): Likewise.
7495 * eval.c (struct backtrace.nargs, interactive_p)
7496 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7497 (funcall_lambda, mark_backtrace): Likewise.
7498 * fns.c (concat): Likewise.
7499 * frame.c (x_set_frame_parameters): Likewise.
7500 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7501 0 if not found, not -1. All callers changed.
7502
dd3f25f7
PE
7503 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7504 (stack_copy_size): Now size_t, not int.
7505 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7506
461c2ab9
JB
75072011-03-28 Juanma Barranquero <lekktu@gmail.com>
7508
7509 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7510 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7511 All callers changed.
7512
7513 * lisp.h (multibyte_char_to_unibyte):
7514 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7515 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7516 * character.h (CHAR_TO_BYTE8):
7517 * cmds.c (internal_self_insert):
7518 * editfns.c (general_insert_function):
7519 * keymap.c (push_key_description):
7520 * search.c (Freplace_match):
7521 * xdisp.c (message_dolog, set_message_1): All callers changed.
7522
f6d62986
SM
75232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7524
7525 * keyboard.c (safe_run_hook_funcall): New function.
7526 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7527 don't set the hook to nil, but remove the offending function instead.
7528 (Qcommand_hook_internal): Remove, unused.
7529 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7530 Vcommand_hook_internal.
7531
7532 * eval.c (enum run_hooks_condition): Remove.
7533 (funcall_nil, funcall_not): New functions.
7534 (run_hook_with_args): Call each function through a `funcall' argument.
7535 Remove `cond' argument, now redundant.
7536 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7537 (Frun_hook_with_args_until_failure): Adjust accordingly.
7538 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7539
1db5b1ad
JB
75402011-03-28 Juanma Barranquero <lekktu@gmail.com>
7541
7542 * dispextern.h (string_buffer_position): Remove declaration.
7543
7544 * print.c (strout): Remove parameter `multibyte', unused since
7545 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7546
7547 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7548 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7549 All callers changed.
7550
7551 * w32.c (_wsa_errlist): Use braces for struct initializers.
7552
7553 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7554 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7555 All callers changed.
7556 (string_buffer_position): Likewise. Also, make static (it's never
7557 used outside xdisp.c).
7558 (cursor_row_p): Remove parameter `w', unused since
7559 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7560 (decode_mode_spec): Remove parameter `precision', introduced during
7561 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7562 All callers changed.
7563
5ffb62aa
JD
75642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7565
7566 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7567
461c2ab9 75682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7569
7570 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7571 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7572 (ns_update_auto_hide_menu_bar): New functions.
7573 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7574 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7575 ns_constrain_all_frames.
7576 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7577 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7578
5c380ffb
JD
75792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7580
7581 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7582
9af30bdf
GM
75832011-03-27 Glenn Morris <rgm@gnu.org>
7584
7585 * syssignal.h: Replace RETSIGTYPE with void.
7586 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7587 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7588 Replace SIGTYPE with void everywhere.
7589 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7590 * s/template.h (SIGTYPE): Remove commented out definition.
7591
e2abce01
JB
75922011-03-26 Eli Zaretskii <eliz@gnu.org>
7593
7594 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7595 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7596
f868cd8a
JB
75972011-03-26 Juanma Barranquero <lekktu@gmail.com>
7598
59eb0929
JB
7599 * w32.c (read_unc_volume): Use parameter `henum', instead of
7600 global variable `wget_enum_handle'.
7601
7602 * keymap.c (describe_vector): Remove parameters `indices' and
7603 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7604 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7605
f868cd8a
JB
7606 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7607
7608 * keyboard.c (timer_check): Remove parameter `do_it_now',
7609 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7610 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7611 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7612
7613 * keyboard.c (read_char):
7614 * w32menu.c (w32_menu_display_help):
7615 * xmenu.c (show_help_event, menu_help_callback):
7616 Adjust calls to `show_help_echo'.
7617
7618 * gtkutil.c (xg_maybe_add_timer):
7619 * keyboard.c (readable_events):
7620 * process.c (wait_reading_process_output):
7621 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7622
7623 * insdel.c (adjust_markers_gap_motion):
7624 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7625 (gap_left, gap_right): Don't call it.
7626
2ecf6fdb
CY
76272011-03-25 Chong Yidong <cyd@stupidchicken.com>
7628
7629 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7630 incurred during fontification.
7631
6b1f9ba4
JB
76322011-03-25 Juanma Barranquero <lekktu@gmail.com>
7633
7634 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7635 (DEFVAR_PER_BUFFER): Don't pass it.
7636
7637 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7638 (scrolling_window): Don't pass it.
7639
0f4a96b5
JB
76402011-03-25 Juanma Barranquero <lekktu@gmail.com>
7641
7642 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7643
7644 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7645 and `suffix'.
7646 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7647 of variables specific to SELinux and computation of `encoded_absname'.
7648
7649 * image.c (XPutPixel): Remove unused variable `height'.
7650
7651 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7652
7653 * unexw32.c (get_section_info): Remove unused variable `section'.
7654
7655 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7656 (system_process_attributes): Remove unused variable `sess'.
7657 (sys_read): Remove unused variable `err'.
7658
7659 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7660 (w32_wnd_proc): Remove unused variable `isdead'.
7661 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7662 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7663 (x_create_tip_frame): Remove unused variable `tem'.
7664
7665 * w32inevt.c (w32_console_read_socket):
7666 Remove unused variable `no_events'.
7667
7668 * w32term.c (x_draw_composite_glyph_string_foreground):
7669 Remove unused variable `width'.
7670
1149507c
JB
76712011-03-24 Juanma Barranquero <lekktu@gmail.com>
7672
7673 * w32term.c (x_set_glyph_string_clipping):
7674 Don't pass uninitialized region to CombineRgn.
7675
9c88f339
JB
76762011-03-23 Juanma Barranquero <lekktu@gmail.com>
7677
7678 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7679 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7680 (Fx_close_connection): Remove unused variable `i'.
7681
7682 * w32font.c (w32font_draw): Return number of glyphs.
7683 (w32font_open_internal): Remove unused variable `i'.
7684 (w32font_driver): Add missing initializer.
7685
7686 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7687 (fill_in_menu): Remove unused variable `items_added'.
7688
7689 * w32term.c (last_mouse_press_frame): Remove static global variable.
7690 (w32_clip_to_row): Remove unused variable `f'.
7691 (x_delete_terminal): Remove unused variable `i'.
7692
7693 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7694 (NOTHING): Remove unused static global variable.
7695 (uniscribe_check_otf): Remove unused variable `table'.
7696 (uniscribe_font_driver): Add missing initializers.
7697
dee091a3
JD
76982011-03-23 Julien Danjou <julien@danjou.info>
7699
7700 * term.c (Fsuspend_tty, Fresume_tty):
7701 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7702 * window.c (temp_output_buffer_show):
7703 * insdel.c (signal_before_change):
7704 * frame.c (Fhandle_switch_frame):
7705 * fileio.c (Fdo_auto_save):
7706 * emacs.c (Fkill_emacs):
7707 * editfns.c (save_excursion_restore):
7708 * cmds.c (internal_self_insert):
7709 * callint.c (Fcall_interactively):
7710 * buffer.c (Fkill_all_local_variables):
7711 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7712 Use Frun_hooks.
0f4a96b5 7713 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7714 unconditionnaly since it does the check itself.
7715
2c520ab5 77162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7717
c9c49752
PE
7718 Fix more problems found by GCC 4.5.2's static checks.
7719
8abc3f12
PE
7720 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7721 the first time through the loop, since we know p0 < p1 then.
7722 This also avoids a gcc -Wstrict-overflow warning.
7723
a2d26660
PE
7724 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7725 leading to a memory leak, possible in functions like
7726 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7727 of objects (Bug#8318).
a2d26660 7728
916c72e9
PE
7729 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7730 that could (at least in theory) be that large.
7731
19ab8a18
PE
7732 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7733 This is less likely to overflow, and avoids undefined behavior if
7734 overflow does occur. All callers changed. Use strtoul to scan
7735 for the unsigned long integer.
b7cbbd6f
PE
7736 (pint2hrstr): Simplify and tune code slightly.
7737 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7738
f0641eff
PE
7739 * scroll.c (do_scrolling): Work around GCC bug 48228.
7740 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7741
7f650bb9
PE
7742 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7743 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7744 (validate_x_resource_name): Simplify count usage.
7745 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7746
37dd57d1
PE
7747 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7748 fail (Bug#8306).
81e56e61 7749
699979fc 7750 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7751
401bf9b4
PE
7752 * process.c (Fmake_network_process): Use socklen_t, not int,
7753 where POSIX says socklen_t is required in portable programs.
7754 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7755 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7756 (Fmake_network_process, server_accept_connection):
7757 (wait_reading_process_output, read_process_output):
7758 Likewise.
7759
b93aacde
PE
7760 * process.c: Rename or move locals to avoid shadowing.
7761 (list_processes_1, Fmake_network_process):
7762 (read_process_output_error_handler, exec_sentinel_error_handler):
7763 Rename or move locals.
4dc343ee 7764 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7765 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7766 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7767 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7768 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7769
af8a867c 7770 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7771 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7772 Include tparam.h instead, since it declares them.
af8a867c
PE
7773 * cm.h (PC): Remove extern decl; tparam.h now does this.
7774 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7775 * terminfo.c: Include tparam.h, to check interfaces.
7776 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7777 (tparam): Adjust signature to match interface in tparam.h;
7778 this removes some undefined behavior. Check that outstring and len
7779 are zero, which they always are with Emacs.
7780 * tparam.h (PC, BC, UP): New extern decls.
7781
0248044d 7782 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7783 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7784
8ff096c1 7785 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7786 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7787 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7788 (ftfont_list): Remove unused local.
49eaafba
PE
7789 (get_adstyle_property, ftfont_pattern_entity):
7790 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7791 Rename locals to avoid shadowing.
8ff096c1 7792
e2be39f6
PE
7793 * xfont.c (xfont_list_family): Mark var as initialized.
7794
c9735e30
PE
7795 * xml.c (make_dom): Now static.
7796
8f5201ae
PE
7797 * composite.c (composition_compute_stop_pos): Rename local to
7798 avoid shadowing.
b246f932
PE
7799 (composition_reseat_it): Remove unused locals.
7800 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7801 (composition_update_it): Mark var as initialized.
11b61122
PE
7802 (find_automatic_composition): Mark vars as initialized,
7803 with a FIXME (Bug#8290).
8f5201ae 7804
760fbc2c
PE
7805 character.h: Rename locals to avoid shadowing.
7806 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7807 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7808 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7809 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7810 to avoid shadowing.
7811
ff08eb85
PE
7812 * textprop.c (property_change_between_p): Remove; unused.
7813
fc7bf025
PE
7814 * intervals.c (interval_start_pos): Now static.
7815
235d7abc
PE
7816 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7817
44f230aa
SM
7818 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7819 Rename locals to avoid shadowing.
3e7d6594 7820
50060332
PE
7821 * sound.c (wav_play, au_play, Fplay_sound_internal):
7822 Fix pointer signedness.
d01f234b 7823 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7824 (wav_play): Initialize a variable to 0, to prevent undefined
7825 behavior (Bug#8278).
50060332 7826
c4fc4e30
PE
7827 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7828
918436ed
PE
7829 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7830
c939f91b
PE
7831 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7832 clobbering (Bug#8298).
b9c7f648
PE
7833 * sysdep.c (sys_subshell): Likewise.
7834 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7835
6bd8c144
PE
7836 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7837 This should get cleaned up, so that child_setup has the
7838 same signature on all platforms.
7839
7710357c 7840 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7841 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7842
c59da222
CY
78432011-03-22 Chong Yidong <cyd@stupidchicken.com>
7844
7845 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7846 not to be necessary, and produces flickering.
7847
66b87493
GM
78482011-03-20 Glenn Morris <rgm@gnu.org>
7849
7850 * config.in: Remove file.
7851
45b6f6d5
JB
78522011-03-20 Juanma Barranquero <lekktu@gmail.com>
7853
7854 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7855 are now in src/globals.h.
7856 (syms_of_minibuf): Remove spurious & from previous change.
7857
3ec03f7e
LL
78582011-03-20 Leo <sdl.web@gmail.com>
7859
7860 * minibuf.c (completing-read-function): New variable.
7861 (completing-read-default): Rename from completing-read.
7862 (completing-read): Call completing-read-function.
7863
b14e3e21
CY
78642011-03-19 Juanma Barranquero <lekktu@gmail.com>
7865
7866 * xfaces.c (Fx_load_color_file):
7867 Read color file from absolute filename (bug#8250).
7868
f2b726e6
JB
78692011-03-19 Juanma Barranquero <lekktu@gmail.com>
7870
7871 * makefile.w32-in: Update dependencies.
7872
09f6ff02
EZ
78732011-03-17 Eli Zaretskii <eliz@gnu.org>
7874
7875 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7876
29a6015a
PE
78772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7878
a3a6c54e
PE
7879 Fix more problems found by GCC 4.5.2's static checks.
7880
b766f867
PE
7881 * process.c (make_serial_process_unwind, send_process_trap):
7882 (sigchld_handler): Now static.
7883
be02381c
PE
7884 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7885 That way, the code declares only the vars that it needs.
7886 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7887 * s/cygwin.h (PTY_ITERATION): Likewise.
7888 * s/darwin.h (PTY_ITERATION): Likewise.
7889 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7890
57048744
PE
7891 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7892 * process.c (allocate_pty): Don't declare stb unless it's needed.
7893
7914961c 7894 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7895 (CONSTANTLIM): Remove; unused.
7896 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7897 Define only if needed.
7914961c 7898
b3967b18
PE
7899 * unexelf.c (unexec): Name an expression,
7900 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7901 Use a different way to cause a compilation error if anyone uses
7902 n rather than nn, a way that does not involve shadowing.
73366a00 7903 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7904
29a6015a
PE
7905 * deps.mk (unexalpha.o): Remove; unused.
7906
43cfc33e 7907 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7908 * unexec.h: New file.
ce701a33
PE
7909 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7910 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7911 Depend on unexec.h.
7912 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7913 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7914 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7915 Change as necessary to match prototype in unexec.h.
ce701a33 7916
01f44d5a
PE
7917 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7918 shadowing.
4f63c6bb 7919 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7920
a6670b0b
PE
7921 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7922 Rename locals to avoid shadowing.
7923
cef2010d 7924 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7925 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7926
d4d7173a
PE
7927 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7928
f08b802a
PE
7929 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7930 warning when compiling print.c.
7931
3ddb0639
PE
7932 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7933 instead of using an uninitialized var.
5ad03b97 7934 (font_sort_entities): Mark var as initialized.
3ddb0639 7935
170a2692
PE
7936 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7937
e663c700
PE
7938 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7939 pointers to constants.
89bc529a 7940 (font_parse_fcname): Remove unused vars.
7b81e2d0 7941 (font_delete_unmatched): Now static.
ea838e10 7942 (font_get_spec): Remove; unused.
13a547c6
PE
7943 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7944 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7945 Rename or move locals to avoid shadowing.
e663c700 7946
2a80c887 7947 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7948 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7949
1384fa33 7950 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7951 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7952
8b2c52e9
PE
7953 * alloc.c (mark_backtrace): Move decl from here ...
7954 * lisp.h: ... to here, so that it can be checked.
7955
475545b5 7956 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7957 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7958 (lisp_indirect_variable): Name an expression,
7959 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7960 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7961
b1349114 7962 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7963 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7964 Use const pointer when appropriate.
b1349114 7965
a2928364
PE
7966 * lisp.h (get_system_name, get_operating_system_release):
7967 Move decls here, to check interfaces.
7968 * process.c (get_operating_system_release): Move decl to lisp.h.
7969 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7970 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7971 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7972 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7973 (Fformat_time_string, Fencode_time, Finsert_char):
7974 (Ftranslate_region_internal, Fformat):
7975 Rename or remove local vars to avoid shadowing.
9710023e 7976 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7977
a415e694
PE
7978 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7979 avoid shadowing.
7980
8ef4622d
PE
7981 * lisp.h (eassert): Check that the argument compiles, even if
7982 ENABLE_CHECKING is not defined.
7983
946f9a5b
PE
7984 * data.c (Findirect_variable): Name an expression, to avoid
7985 gcc -Wbad-function-cast warning.
112396d6 7986 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7987 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7988 (Fmake_variable_buffer_local, Fmake_local_variable):
7989 Mark variables as initialized.
52746918 7990 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7991
e5aab7e7 7992 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7993 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7994 Rename locals to avoid shadowing.
dff45157
PE
7995 (mark_stack): Move local variables into the #ifdef region where
7996 they're used.
7bc26fdb
PE
7997 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7998 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7999 needed otherwise.
8000 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8001 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8002 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8003
e5aab7e7
PE
8004 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8005 avoids undefined behavior in theory.
8006
4da60324
PE
8007 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8008
88043301
PE
8009 Use functions, not macros, for up- and down-casing (Bug#8254).
8010 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8011 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8012 to use the following functions instead of these macros.
8013 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8014 EMACS_INT, since callers assume the returned value fits in int.
8015 (upcase1): Likewise, for UPCASE_TABLE.
8016 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8017 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8018 the race-condition problem in the old DOWNCASE.
88043301 8019
19ed5445
PE
8020 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8021 Rename locals to avoid shadowing.
8022 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8023 (regex_compile, re_search_2, re_match_2_internal):
8024 Remove unused local vars.
952db0d7
PE
8025 (FREE_VAR): Rewrite so as not to use empty "else",
8026 which gcc can warn about.
da053e48 8027 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8028 (RETALLOC_IF): Define only if needed.
8029 (WORDCHAR_P): Likewise. This one is never needed, but is used
8030 only in a comment talking about a compiler bug, so put inside
8031 the #if 0 of that comment.
8032 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8033 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8034 Remove; unused.
19ed5445 8035
1f3561e4 8036 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8037 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8038 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8039
ded6f8f7
PE
8040 * search.c (simple_search): Remove unused var.
8041
dbd37a95
PE
8042 * dired.c (compile_pattern): Move decl from here ...
8043 * lisp.h: ... to here, so that it can be checked.
8044 (struct re_registers): New forward decl.
8045
7e47afad
PE
8046 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8047
85f24f61
PE
8048 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8049 All uses changed.
8050 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8051 Rename locals to avoid shadowing.
5671df8f 8052 (Fvertical_motion): Mark locals as initialized.
85f24f61 8053
181aa2be 8054 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8055 (casify_region): Mark local as initialized.
181aa2be 8056
930d429c
PE
8057 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8058
7082eac6
PE
8059 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8060 New macros, so that the caller can use some names other than
8061 gcpro1, gcpro2, etc.
8062 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8063 of the new macros.
8064 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8065 argument, for consistency with GCPRO2_VAR, etc: it is now the
8066 prefix of the variable, not the variable itself. All uses
8067 changed.
38b2c076
PE
8068 * dired.c (directory_files_internal, file_name_completion):
8069 Rename locals to avoid shadowing.
8070
15206ed9
PE
8071 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8072 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8073 dired.c's scmp function, had undefined behavior.
8074 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8075 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8076 * buffer.h: ... to here, because these macros use current_buffer,
8077 and the new implementation with inline functions needs to have
8078 current_buffer in scope now, rather than later when the macros
8079 are used.
8080 (downcase, upcase1): New static inline functions.
8081 (DOWNCASE, UPCASE1): Reimplement using these functions.
8082 This avoids undefined behavior in expressions like
8083 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8084 from race conditions in accessing the global variables
8085 case_temp1 and case_temp2.
8086 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8087 * lisp.h (case_temp1, case_temp2): Remove their decls.
8088 * character.h (ASCII_CHAR_P): Move from here ...
8089 * lisp.h: ... to here, so that the inline functions mentioned
8090 above can use them.
8091
4a6bea26
PE
8092 * dired.c (directory_files_internal_unwind): Now static.
8093
f14b7e14
PE
8094 * fileio.c (file_name_as_directory, directory_file_name):
8095 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8096 Now static.
2893f146
PE
8097 (file_name_as_directory): Use const pointers when appropriate.
8098 (Fexpand_file_name): Likewise. In particular, newdir might
8099 point at constant storage, so make it a const pointer.
fd4ead52 8100 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8101 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8102 signedness issues.
f839df0c
PE
8103 (Fset_file_times, Finsert_file_contents, auto_save_error):
8104 Rename locals to avoid shadowing.
f14b7e14 8105
5716756e 8106 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8107 (Ftry_completion, Fall_completions): Rename or remove locals
8108 to avoid shadowing.
5716756e 8109
b4c3046a
PE
8110 * marker.c (bytepos_to_charpos): Remove; unused.
8111
b45db522
PE
8112 * lisp.h (verify_bytepos, count_markers): New decls,
8113 so that gcc does not warn that these functions aren't declared.
8114
85876d07
PE
8115 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8116 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8117 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8118 (copy_text): Remove unused local var.
85876d07 8119
03d78a21 8120 * filelock.c (within_one_second): Now static.
b3dd38ab 8121 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8122
5df8f01b
PE
8123 * buffer.c (fix_overlays_before): Mark locals as initialized.
8124 (fix_start_end_in_overlays): Likewise. This function should be
8125 simplified by using pointers-to-pointers, but that's a different
8126 matter.
b1d876f1 8127 (switch_to_buffer_1): Now static.
8f54f30a
PE
8128 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8129 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8130
a70072c9 8131 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8132 Fix pointer signedness issue.
edced198
PE
8133 (sys_subshell): Mark local as volatile if checking for lint,
8134 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8135 (MAXPATHLEN): Define only if needed.
a70072c9 8136
a0977c44
PE
8137 * process.c (serial_open, serial_configure): Move decls from here ...
8138 * systty.h: ... to here, so that they can be checked.
8139
a884fdcc
PE
8140 * fns.c (get_random, seed_random): Move extern decls from here ...
8141 * lisp.h: ... to here, so that they can be checked.
8142
604efe86 8143 * sysdep.c (reset_io): Now static.
b8950c94 8144 (wait_for_termination_signal): Remove; unused.
604efe86 8145
38fc62d9
PE
8146 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8147 (copy_keymap_item, append_key, push_text_char_description):
8148 Now static.
1004a21a 8149 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8150 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8151 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8152 (describe_map_tree):
8153 Rename locals to avoid shadowing.
38fc62d9 8154
2f2650da
PE
8155 * keyboard.c: Declare functions static if they are not used elsewhere.
8156 (echo_char, echo_dash, cmd_error, top_level_2):
8157 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8158 (read_char, kbd_buffer_get_event, make_lispy_position):
8159 (make_lispy_event, make_lispy_movement, apply_modifiers):
8160 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8161 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8162 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8163 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8164 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8165
a053e86c 8166 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8167 (mark_kboards): Move decl here ...
8168 * alloc.c (mark_kboards): ... from here.
a053e86c 8169
4752793e
PE
8170 * lisp.h (force_auto_save_soon): New decl.
8171
74f10ca7 8172 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8173 (DEFINE_DUMMY_FUNCTION): New macro.
8174 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8175 Use it.
c03cd23f
PE
8176 (main): Add casts to avoid warnings
8177 if GCC considers string literals to be constants.
74f10ca7 8178
022e70d4
PE
8179 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8180
59d6fe83
PE
8181 * dbusbind.c: Pointer signedness fixes.
8182 (xd_signature, xd_append_arg, xd_initialize):
8183 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8184 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8185 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8186 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8187
78320123
PE
8188 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8189 if GCC considers string literals to be constants.
49cebcca 8190 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8191
35ac2a97
SM
81922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8193
fb103ca9
SM
8194 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8195 (print_preprocess, print_object): New macro to fix last change.
8196
35ac2a97
SM
8197 * print.c (print_preprocess): Don't forget font objects.
8198
62973b41
JB
81992011-03-16 Juanma Barranquero <lekktu@gmail.com>
8200
8201 * emacs.c (USAGE3): Doc fixes.
8202
0e48bb22
AS
82032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8204
8205 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8206 structure.
8207
7684e57b
JB
82082011-03-14 Juanma Barranquero <lekktu@gmail.com>
8209
8210 * lisp.h (VWindow_system, Qfile_name_history):
8211 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8212 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8213 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8214
8215 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8216 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8217
8218 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8219 * w32console.c (detect_input_pending, read_input_pending)
8220 (encode_terminal_code):
8221 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8222 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8223 (w32_system_caret_y, Qfile_name_history):
8224 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8225 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8226 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8227 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8228 * w32proc.c (Qlocal, report_file_error):
8229 * w32term.c (Vwindow_system, updating_frame):
8230 * w32uniscribe.c (initialized, uniscribe_font_driver):
8231 Remove unneeded extern declarations.
8232
2aa46d6c
CY
82332011-03-14 Chong Yidong <cyd@stupidchicken.com>
8234
c96bbc66 8235 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8236
cffc6f3b
CY
82372011-03-13 Chong Yidong <cyd@stupidchicken.com>
8238
8239 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8240 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8241 These macros can no longer be used for assignment.
8242
44f230aa
SM
8243 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8244 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8245 (record_buffer_markers, fetch_buffer_markers): New functions for
8246 recording and fetching special buffer markers.
8247 (set_buffer_internal_1, set_buffer_temp): Use them.
8248
8249 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8250
8251 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8252
8253 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8254 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8255
8256 * xdisp.c (hscroll_window_tree):
8257 (reconsider_clip_changes): Use PT instead of BUF_PT.
8258
d251f04b
EZ
82592011-03-13 Eli Zaretskii <eliz@gnu.org>
8260
8261 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8262 $(EMACS_ROOT)/lib/intprops.h.
8263
f0c77cd1
PE
82642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8265
3eca4629
PE
8266 Fix more problems found by GCC 4.5.2's static checks.
8267
7c86ee98
PE
8268 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8269 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8270 (xg_free_frame_widgets): Make it clear that a local variable is
8271 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8272 (gdk_window_get_screen): Make it clear that this macro is needed
8273 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8274 (int_gtk_range_get_value): New function, which avoids a diagnostic
8275 from gcc -Wbad-function-cast.
8276 (xg_set_toolkit_scroll_bar_thumb): Use it.
8277 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8278 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8279 (get_utf8_string, xg_get_file_with_chooser):
8280 Rename locals to avoid shadowing.
8281 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8282
41729b81
PE
8283 * xgselect.c (xg_select): Remove unused var.
8284
f0c77cd1
PE
8285 * image.c (four_corners_best): Mark locals as initialized.
8286 (gif_load): Initialize transparent_p to zero (Bug#8238).
8287 Mark another local as initialized.
ec6cf4c6 8288 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8289
ce0ad53d 8290 * image.c (clear_image_cache): Now static.
d5d5a617 8291 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8292 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8293 (x_edge_detection): Remove unnecessary cast that
8294 gcc -Wbad-function-cast diagnoses.
2037898d 8295 (gif_load): Fix pointer signedness.
6ae141d6
PE
8296 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8297 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8298
33383987 82992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8300
d32df629
PE
8301 Improve quality of tests for time stamp overflow.
8302 For example, without this patch (encode-time 0 0 0 1 1
8303 1152921504606846976) returns the obviously-bogus value (-948597
8304 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8305 reports time overflow. See
8306 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8307 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8308 * editfns.c: Include limits.h and intprops.h.
8309 (TIME_T_MIN, TIME_T_MAX): New macros.
8310 (time_overflow): Move earlier, to before first use.
8311 (hi_time, lo_time): New functions, for an accurate test for
8312 out-of-range times.
8313 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8314 (Fget_internal_run_time): Don't assume time_t fits in int.
8315 (make_time): Use list2 instead of Fcons twice.
8316 (Fdecode_time): More accurate test for out-of-range times.
8317 (check_tm_member): New function.
8318 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8319 (lisp_time_argument): Don't rely on undefined left-shift and
8320 right-shift behavior when checking for time stamp overflow.
8be6f318 8321
fe31d94c
PE
8322 * editfns.c (time_overflow): New function, refactoring common code.
8323 (Fformat_time_string, Fdecode_time, Fencode_time):
8324 (Fcurrent_time_string): Use it.
8325
8be6f318
PE
8326 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8327 * dired.c (make_time): Move to ...
8328 * editfns.c (make_time): ... here.
8329 * systime.h: Note the move.
8330
09d9db2c 83312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8332
126bc0dc
YM
8333 * fringe.c (update_window_fringes): Remove unused variables.
8334
c47cbdfd
YM
8335 * unexmacosx.c (copy_data_segment): Also copy __got section.
8336 (Bug#8223)
8337
7ac80be9
EZ
83382011-03-12 Eli Zaretskii <eliz@gnu.org>
8339
c96bbc66 8340 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8341 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8342 Constify `char *' arguments and their references according to
8343 prototypes in tparam.h.
8344
ecb0f94d 8345 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8346
7ac80be9
EZ
8347 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8348 Adapt all references accordingly.
8349
8350 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8351
ef1fd07e
TT
83522011-03-11 Tom Tromey <tromey@redhat.com>
8353
8354 * buffer.c (syms_of_buffer): Remove obsolete comment.
8355
7ef4b50c
EZ
83562011-03-11 Eli Zaretskii <eliz@gnu.org>
8357
8358 * termhooks.h (encode_terminal_code): Declare prototype.
8359
8360 * msdos.c (encode_terminal_code): Don't declare prototype.
8361
8362 * term.c (encode_terminal_code): Now external again, used by
8363 w32console.c and msdos.c.
8364
44f230aa
SM
8365 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8366 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8367
4b1ec863 83682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8369
1714f52b 8370 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8371
4b1ec863
PE
8372 * fringe.c (update_window_fringes): Mark locals as initialized
8373 (Bug#8227).
8374 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8375
524c7aa6
PE
8376 * alloc.c (mark_fringe_data): Move decl from here ...
8377 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8378 to check its interface.
8379 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8380
a5c0af81 8381 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8382 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8383 (fontset_font): Mark local as initialized.
a9a06e0b 8384 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8385
b4716021
PE
8386 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8387
811e9bac 8388 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8389 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8390 (x_own_selection, Fx_disown_selection_internal): Rename locals
8391 to avoid shadowing.
8392 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8393
7e3ab302
PE
8394 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8395 so that the caller can use some name other than gcpro1.
8396 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8397 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8398 (Fx_backspace_delete_keys_p):
8399 Use them to avoid shadowing, and rename vars to avoid shadowing.
8400 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8401 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8402 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8403 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8404 Remove unused locals.
7e3ab302
PE
8405 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8406 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8407 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8408 macros.
f78faa98 8409
e2b13473
PE
8410 * xterm.h (x_mouse_leave): New decl.
8411
77f23912
PE
8412 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8413 Remove unused functions.
cdf4ba58
PE
8414 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8415 (x_calc_absolute_position): Now static.
7411c686 8416 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8417 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8418 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8419 unless they are used.
38d0b34a
PE
8420 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8421 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8422 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8423 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8424 (x_error_catcher, x_connection_closed, x_error_handler):
8425 (x_error_quitter, xembed_send_message, x_iconify_frame):
8426 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8427 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8428 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8429
44f230aa
SM
8430 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8431 Rename or move locals to avoid shadowing.
6b463e58 8432 (tty_defined_color, merge_face_heights): Now static.
5967d051 8433 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8434 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8435 does not deduce is never used uninitialized.
73719eba
PE
8436 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8437 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8438
426994c3 8439 * terminal.c (store_terminal_param): Now static.
5489860b 8440
032f1620 8441 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8442 (set_frame_menubar): Remove unused local.
d4323972 8443 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8444 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8445 since they might point to immutable storage.
281585b0
PE
8446 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8447 since it's unused otherwise.
032f1620 8448
367c19e5 8449 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8450 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8451 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8452 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8453 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8454 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8455 does not deduce are never used uninitialized.
70739cbe 8456
07b48fa9
PE
8457 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8458
8868a238 8459 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8460 * window.c (window_loop, size_window):
8461 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8462
7e5cf297 8463 * window.c (display_buffer): Now static.
d6550a9f
PE
8464 (size_window): Mark variables that gcc -Wuninitialized
8465 does not deduce are never used uninitialized.
a586633d
PE
8466 * window.h (check_all_windows): New decl, to forestall
8467 gcc -Wmissing-prototypes diagnostic.
5b555da1 8468 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8469
f6095868
PE
8470 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8471 shadowing.
8472 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8473 Include <limits.h>.
8474 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8475 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8476 (load_charset_map): Mark variables that gcc -Wuninitialized
8477 does not deduce are never used uninitialized.
53df7c11 8478 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8479
f38b440c
PE
8480 * coding.c (coding_set_source, coding_set_destination):
8481 Use "else { /* comment */ }" rather than "else /* comment */;"
8482 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8483 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8484 a block, when the outer 'i' will do.
8485 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8486 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8487 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8488 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8489 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8490 Rename locals to avoid shadowing.
8491 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8492 * coding.c (emacs_mule_char, encode_invocation_designation):
8493 Now static, since they're not used elsewhere.
413bb2db 8494 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8495 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8496 (decode_coding_emacs_mule): Mark variables that gcc
8497 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8498 (detect_coding_iso_2022): Initialize a local variable that might
8499 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8500 this initialization is needed. (Bug#8211)
5f58e762
PE
8501 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8502 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8503 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8504 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8505 Remove unused macros.
f38b440c 8506
232b38b9 8507 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8508 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8509 * character.c (string_count_byte8): Likewise.
232b38b9 8510
fb90da1b
PE
8511 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8512 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8513
fb93dbc2
PE
8514 * chartab.c (copy_sub_char_table): Now static, since it's not used
8515 elsewhere.
5c156ace
PE
8516 (sub_char_table_ref_and_range, char_table_ref_and_range):
8517 Rename locals to avoid shadowing.
bbcd0949 8518 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8519
7d3b3862 8520 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8521 (BIDI_BOB): Remove unused macro.
7d3b3862 8522
6be7d3da
PE
8523 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8524 deduce are never used uninitialized.
c2ed9c8b 8525 * term.c (encode_terminal_code): Likewise.
6be7d3da 8526
75f8807f 8527 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8528
50938595
PE
8529 * tparam.h: New file.
8530 * term.c, tparam.h: Include it.
8531 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8532 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8533 Move these decls to tparam.h, and make them agree with what
8534 is actually in tparam.c. The previous trick of using incompatible
8535 decls in different modules does not conform to the C standard.
8536 All callers of tparam changed to use tparam's actual API.
8537 * tparam.c (tparam1, tparam, tgoto):
8538 Use const pointers where appropriate.
8539
fbceeba2
PE
8540 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8541 * cm.h (struct cm): Likewise.
8542 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8543 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8544 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8545 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8546 (turn_on_face, init_tty): Likewise.
8547 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8548
7f3f1250
PE
8549 * term.c (term_mouse_position): Rename local to avoid shadowing.
8550
e6ca6543
PE
8551 * alloc.c (mark_ttys): Move decl from here ...
8552 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8553
c40f8d15
AS
85542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8555
8556 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8557
cfe0661d
JB
85582011-03-09 Juanma Barranquero <lekktu@gmail.com>
8559
8560 * search.c (compile_pattern_1): Remove argument regp, unused since
8561 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8562 (compile_pattern): Don't pass it.
8563
0afb4571
J
85642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8565
8566 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8567 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8568 for ! HAVE_GTK3.
8569 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8570
8571 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8572
8573 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8574 gdk_window_get_screen, gdk_window_get_geometry,
8575 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8576 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8577 (xg_get_pixbuf_from_pixmap): New function.
8578 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8579 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8580 Call xg_get_pixbuf_from_pixmap instead of
8581 gdk_pixbuf_get_from_drawable.
8582 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8583 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8584 (xg_check_special_colors): Use GtkStyleContext and its functions
8585 for HAVE_GTK3.
8586 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8587 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8588 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8589 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8590 Call gtk_widget_get_preferred_size.
0afb4571
J
8591 (xg_frame_resized): gdk_window_get_geometry only takes 5
8592 parameters.
44f230aa
SM
8593 (xg_win_to_widget, xg_event_is_for_menubar):
8594 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8595 (xg_set_widget_bg): New function.
8596 (delete_cb): New function.
895009e1 8597 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8598 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8599 (xg_set_background_color): Call xg_set_widget_bg.
8600 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8601 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8602 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8603 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8604 if ! HAVE_GTK3.
8605 (update_frame_tool_bar): Call gtk_widget_hide.
8606 (xg_initialize): Use GDK_KEY_g.
8607
8608 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8609 if ! HAVE_GTK3
8610 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8611
8612 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8613 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8614 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8615
1c2cc4ef
JB
86162011-03-08 Juanma Barranquero <lekktu@gmail.com>
8617
8618 * w32xfns.c (select_palette): Check success of RealizePalette against
8619 GDI_ERROR, not zero.
8620
33383987 8621See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8622
8623;; Local Variables:
8624;; coding: utf-8
aac0c6e3
MR
8625;; End:
8626
33383987 8627 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8628
8629 This file is part of GNU Emacs.
8630
8631 GNU Emacs is free software: you can redistribute it and/or modify
8632 it under the terms of the GNU General Public License as published by
8633 the Free Software Foundation, either version 3 of the License, or
8634 (at your option) any later version.
8635
8636 GNU Emacs is distributed in the hope that it will be useful,
8637 but WITHOUT ANY WARRANTY; without even the implied warranty of
8638 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8639 GNU General Public License for more details.
8640
8641 You should have received a copy of the GNU General Public License
8642 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.