Use pthread_sigmask, not sigprocmask.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
123403e4
PE
12011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2
3 Use pthread_sigmask, not sigprocmask.
4 * callproc.c (Fcall_process):
5 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6 * process.c (create_process):
7 sigprocmask is portable only for single-threaded applications, and
8 Emacs can be multi-threaded when it uses GTK.
9
869795d6
JD
102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11
12 * xsettings.c: Use both GConf and GSettings if both are available.
13 (store_config_changed_event): Add comment.
14 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
15 (store_tool_bar_style_changed): New functions.
16 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
17 (struct xsettings): Move font inside HAVE_XFT.
18 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
19 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
20 Move inside HAVE_XFT.
21 (something_changed_gsettingsCB): Renamed from something_changedCB.
22 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
23 also.
24 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
25 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
26 (something_changed_gconfCB): Renamed from something_changedCB.
27 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
28 (parse_settings): Move check for font inside HAVE_XFT.
29 (read_settings, apply_xft_settings): Add comment.
30 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
31 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
32 call store_font_name_changed.
33 (xft_settings_event): Add comment.
34 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
35 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
36 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
37 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
38 (xsettings_initialize): Call init_gsettings last.
39 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
40 comment.
41
d8ed26bd
PE
422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
43
44 Random fixes. E.g., (random) never returned negative values.
45 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
46 subseconds part to the entropy, as that's a bit more random.
47 Prefer signed to unsigned, since the signedness doesn't matter and
48 in general we prefer signed. When given a limit, use a
49 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
50 latter isn't right if USE_2_TAGS_FOR_INTS.
51 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
52 not 0..VALMASK. Don't discard "excess" bits that random () returns.
53
cabf1cac
SM
542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
55
56 * textprop.c (text_property_stickiness):
57 Obey Vtext_property_default_nonsticky.
58 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
59 * w32fns.c (syms_of_w32fns):
60 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
61
6e9b2be9
PE
622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
63
64 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
65 This is more efficient than Ffile_directory_p and avoids a minor race.
66
90186c68
LMI
672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
68
7c301272
LMI
69 * buffer.c (Foverlay_put): Say what the return value is
70 (bug#7835).
71
c4f2d8d4
LMI
72 * fileio.c (barf_or_query_if_file_exists): Check first if the file
73 is a directory before asking whether to use the file name
74 (bug#7564).
ad637907
LMI
75 (barf_or_query_if_file_exists): Make the "File is a directory"
76 error be more correct.
c4f2d8d4 77
90186c68
LMI
78 * fns.c (Frequire): Remove the mention of the .gz files, since
79 that's installation-specific, but keep the mention of
80 `get-load-suffixes'.
81
da64016e
PE
822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
83
84 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
85 Report string overflow if the output is too long.
86
7d47b580
JB
872011-07-04 Juanma Barranquero <lekktu@gmail.com>
88
a555cb87
JB
89 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
90 (syms_of_gnutls): Remove duplicate DEFSYM for
91 Qgnutls_bootprop_verify_hostname_error, an error for
92 Qgnutls_bootprop_verify_error (which is no longer used).
93
7d47b580
JB
94 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
95 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
96 Also (re)move comments that are misplaced or no longer relevant.
97
1e49bfab
LMI
982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
99
100 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
101
1485f4c0
CY
1022011-07-03 Chong Yidong <cyd@stupidchicken.com>
103
104 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
105 and background color parameters if they have been changed.
106
a9ab721e
LMI
1072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
108
109 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
110
cf7cff57
PE
1112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
112
2e13213d
PE
113 * xsettings.c (SYSTEM_FONT): Define only when used.
114 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
115
cf7cff57
PE
116 * keymap.c (access_keymap_1): Now static.
117
7a8e04f7
CY
1182011-07-02 Chong Yidong <cyd@stupidchicken.com>
119
120 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
121 leave any prefix arg for the up event (Bug#1586).
122
61352f62
LMI
1232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
124
69bb1ef7
LMI
125 * lread.c (syms_of_lread): Mention single symbols defined by
126 `defvar' or `defconst' (bug#7154).
127
61352f62 128 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 129 (Frequire): Mention get-load-suffixes.
61352f62 130
28545e04
MR
1312011-07-02 Martin Rudalics <rudalics@gmx.at>
132
133 * window.h (window): Remove clone_number slot.
134 * window.c (Fwindow_clone_number, Fset_window_clone_number):
135 Remove.
136 (make_parent_window, make_window, saved_window)
137 (Fset_window_configuration, save_window_save): Don't deal with
138 clone numbers.
139 * buffer.c (Qclone_number): Remove declaration.
140 (sort_overlays, overlay_strings): Don't deal with clone numbers.
141
3349e122
SM
1422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
143
144 Add multiple inheritance to keymaps.
145 * keymap.c (Fmake_composed_keymap): New function.
146 (Fset_keymap_parent): Simplify.
147 (fix_submap_inheritance): Remove.
148 (access_keymap_1): New function extracted from access_keymap to handle
149 embedded parents and handle lists of maps.
150 (access_keymap): Use it.
151 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
152 (Fcopy_keymap): Handle embedded parents.
153 (Fcommand_remapping, define_as_prefix): Simplify.
154 (Fkey_binding): Simplify.
155 (syms_of_keymap): Move minibuffer-local-completion-map,
156 minibuffer-local-filename-completion-map,
157 minibuffer-local-must-match-map, and
158 minibuffer-local-filename-must-match-map to Elisp.
159 (syms_of_keymap): Defsubr make-composed-keymap.
160 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
161 (parse_menu_item): Trivial simplification.
162
3279eb87
GM
1632011-07-01 Glenn Morris <rgm@gnu.org>
164
165 * Makefile.in (SETTINGS_LIBS): Fix typo.
166
4550efdf
KI
1672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
168
169 * coding.c (Fencode_coding_string): Record the last coding system
170 used, as the function doc string says (bug#8738).
171
0949d2b6
JD
1722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
173
174 * xsettings.c (store_monospaced_changed): Take new font as arg and
175 check for change against current_mono_font.
176 (EMACS_TYPE_SETTINGS): Remove this and related defines.
177 (emacs_settings_constructor, emacs_settings_get_property)
178 (emacs_settings_set_property, emacs_settings_class_init)
179 (emacs_settings_init, gsettings_obj): Remove.
180 (something_changedCB): New function for HAVE_GSETTINGS.
181 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
182 with value as argument.
183 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
184 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 185 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
186 "changed".
187
188 * xgselect.c: Add defined (HAVE_GSETTINGS).
189 (xgselect_initialize): Ditto.
190
191 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
192 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
193 xg_select.
194
bbc6b304
PE
1952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
196
197 * eval.c (struct backtrace): Simplify and port the data structure.
198 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
199 signed bit field, as this assumption is not portable and it makes
200 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
201 "char debug_on_exit : 1" as this is not portable either; instead,
202 use the portable "unsigned int debug_on_exit : 1". Remove unused
203 member evalargs. Remove obsolete comments about cc bombing out.
204
9851bfc5
JD
2052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
206
51bb811f 207 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
208 Let HAVE_GSETTINGS override HAVE_GCONF.
209 (store_monospaced_changed): New function.
210 (EMACS_SETTINGS): A new type derived from GObject to handle
211 GSettings notifications.
212 (emacs_settings_constructor, emacs_settings_get_property)
213 (emacs_settings_set_property, emacs_settings_class_init):
214 New functions.
215 (gsettings_client, gsettings_obj): New variables.
216 (GSETTINGS_SCHEMA): New define.
217 (something_changedCB): Call store_monospaced_changed.
218 (init_gsettings): New function.
219 (xsettings_initialize): Call init_gsettings.
220 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
221 to NULL.
222
223 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
224 GCONF_CFLAGS/LIBS.
225
5386012d
MR
2262011-06-29 Martin Rudalics <rudalics@gmx.at>
227
228 * window.c (resize_root_window, grow_mini_window)
229 (shrink_mini_window): Rename Qresize_root_window to
230 Qwindow_resize_root_window and Qresize_root_window_vertically to
231 Qwindow_resize_root_window_vertically.
232
f13e0b08
PE
2332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
234
235 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
236
94515237
JB
2372011-06-27 Juanma Barranquero <lekktu@gmail.com>
238
239 * makefile.w32-in: Redesign dependencies so they reflect more
240 clearly which files are directly included by each source file,
241 and not through other includes.
242
e43b6e43
MR
2432011-06-27 Martin Rudalics <rudalics@gmx.at>
244
245 * buffer.c (Qclone_number): Declare static and DEFSYM it.
246 (sort_overlays, overlay_strings): When an overlay's clone number
247 matches the window's clone number process the overlay even if
248 the overlay's window property doesn't match the current window.
249
d68443dc
MR
250 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
251 (Fwindow_hchild): Rename to Fwindow_left_child.
252 (Fwindow_next): Rename to Fwindow_next_sibling.
253 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
254 (resize_window_check): Rename to window_resize_check.
255 (resize_window_apply): Rename to window_resize_apply.
256 (Fresize_window_apply): Rename to Fwindow_resize_apply.
257 (Fdelete_other_windows_internal, resize_frame_windows)
258 (Fsplit_window_internal, Fdelete_window_internal)
259 (grow_mini_window, shrink_mini_window)
260 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 261
c7e73be5
JD
2622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
263
264 * emacsgtkfixed.h: State that this is only used with Gtk+3.
265 (emacs_fixed_set_min_size): Remove.
266 (emacs_fixed_new): Take frame as argument.
267
268 * emacsgtkfixed.c: State that this is only used with Gtk+3.
269 (_EmacsFixedPrivate): Remove minwidth/height.
270 Add struct frame *f.
271 (emacs_fixed_init): Initialize priv->f.
272 (get_parent_class, emacs_fixed_set_min_size): Remove.
273 (emacs_fixed_new): Set priv->f to argument.
274 (emacs_fixed_get_preferred_width)
275 (emacs_fixed_get_preferred_height): Use min_width/height from
276 frames size_hint to set minimum and natural (Bug#8919).
277 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
278 and use min_width/height from frames size_hint to set
279 min_width/height (Bug#8919).
280
281 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
282 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
283 Fix indentation.
c7e73be5 284
cf99dcf8
EZ
2852011-06-26 Eli Zaretskii <eliz@gnu.org>
286
287 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
288 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
289 called at ZV.
290
029529ac
CY
2912011-06-26 Chong Yidong <cyd@stupidchicken.com>
292
293 * process.c (wait_reading_process_output): Bypass select if
294 waiting for a cell while ignoring keyboard input, and input is
295 pending. Suggested by Jan Djärv (Bug#8869).
296
7a7ef429
PE
2972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
298
299 Use gnulib's dup2 module instead of rolling our own.
300 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
301
11fdef7d 3022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
303
304 * dispnew.c (scrolling_window): Before scrolling, turn off a
305 mouse-highlight in the window being scrolled.
306
cd3520a4
JB
3072011-06-24 Juanma Barranquero <lekktu@gmail.com>
308
309 Move DEFSYM to lisp.h and use everywhere.
310
311 * character.h (DEFSYM): Move declaration...
312 * lisp.h (DEFSYM): ...here.
313
314 * gnutls.c:
315 * minibuf.c:
316 * w32menu.c:
317 * w32proc.c:
318 * w32select.c: Don't include character.h.
319
320 * alloc.c (syms_of_alloc):
321 * buffer.c (syms_of_buffer):
322 * bytecode.c (syms_of_bytecode):
323 * callint.c (syms_of_callint):
324 * casefiddle.c (syms_of_casefiddle):
325 * casetab.c (init_casetab_once):
326 * category.c (init_category_once, syms_of_category):
327 * ccl.c (syms_of_ccl):
328 * cmds.c (syms_of_cmds):
329 * composite.c (syms_of_composite):
330 * dbusbind.c (syms_of_dbusbind):
331 * dired.c (syms_of_dired):
332 * dispnew.c (syms_of_display):
333 * doc.c (syms_of_doc):
334 * editfns.c (syms_of_editfns):
335 * emacs.c (syms_of_emacs):
336 * eval.c (syms_of_eval):
337 * fileio.c (syms_of_fileio):
338 * fns.c (syms_of_fns):
339 * frame.c (syms_of_frame):
340 * fringe.c (syms_of_fringe):
341 * insdel.c (syms_of_insdel):
342 * keymap.c (syms_of_keymap):
343 * lread.c (init_obarray, syms_of_lread):
344 * macros.c (syms_of_macros):
345 * msdos.c (syms_of_msdos):
346 * print.c (syms_of_print):
347 * process.c (syms_of_process):
348 * search.c (syms_of_search):
349 * sound.c (syms_of_sound):
350 * syntax.c (init_syntax_once, syms_of_syntax):
351 * terminal.c (syms_of_terminal):
352 * textprop.c (syms_of_textprop):
353 * undo.c (syms_of_undo):
354 * w32.c (globals_of_w32):
355 * window.c (syms_of_window):
356 * xdisp.c (syms_of_xdisp):
357 * xfaces.c (syms_of_xfaces):
358 * xfns.c (syms_of_xfns):
359 * xmenu.c (syms_of_xmenu):
360 * xsettings.c (syms_of_xsettings):
361 * xterm.c (syms_of_xterm): Use DEFSYM.
362
4228cf16
TZ
3632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
364
cd3520a4 365 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 366
7fcccf1e
PE
3672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
368
7efb4e0e
PE
369 Integer and buffer overflow fixes (Bug#8873).
370
ff5844ad
PE
371 * print.c (printchar, strout): Check for string overflow.
372 (PRINTPREPARE, printchar, strout):
373 Don't set size unless allocation succeeds.
374
90532f02
PE
375 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
376 for sizes. Check for string overflow more accurately.
377 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
378
6d84508d
PE
379 * macros.c: Integer and buffer overflow fixes.
380 * keyboard.h (struct keyboard.kbd_macro_bufsize):
381 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
382 Use ptrdiff_t, not int, for sizes.
383 Don't increment bufsize until after realloc succeeds.
384 Check for size-calculation overflow.
385 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
386
437b2cb4
PE
387 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
388
8b9ac8b4
PE
389 * lread.c: Integer overflow fixes.
390 (read_integer): Radix is now EMACS_INT, not int,
391 to improve quality of diagnostics for out-of-range radices.
392 Calculate buffer size correctly for out-of-range radices.
393 (read1): Check for integer overflow in radices, and in
394 read-circle numbers.
82cb60d3
PE
395 (read_escape): Avoid int overflow.
396 (Fload, openp, read_buffer_size, read1)
397 (substitute_object_recurse, read_vector, read_list, map_obarray):
398 Use ptrdiff_t, not int, for sizes.
399 (read1): Use EMACS_INT, not int, for sizes.
20270765 400 Check for size overflow.
8b9ac8b4 401
7fcccf1e
PE
402 * image.c (cache_image): Check for size arithmetic overflow.
403
bfbbd7e7
PE
404 * lread.c: Integer overflow issues.
405 (saved_doc_string_size, saved_doc_string_length)
406 (prev_saved_doc_string_size, prev_saved_doc_string_length):
407 Now ptrdiff_t, not int.
408 (read1): Don't assume doc string length fits in int. Check for
409 out-of-range doc string lengths.
410 (read_list): Don't assume file position fits in int.
39019e54 411 (read_escape): Check for hex character overflow.
bfbbd7e7 412
4e323265
LL
4132011-06-22 Leo Liu <sdl.web@gmail.com>
414
415 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
416 Move to minibuffer.el.
417
85fece3e
PE
4182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
419
20b84ce9 420 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
421 The following patches are for when GLYPH_DEBUG && !XASSERT.
422 * dispextern.h (trace_redisplay_p, dump_glyph_string):
423 * dispnew.c (flush_stdout):
424 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
425 Mark as externally visible.
426 * dispnew.c (check_window_matrix_pointers): Now static.
427 * dispnew.c (window_to_frame_vpos):
428 * xfns.c (unwind_create_frame):
429 * xterm.c (x_check_font): Remove unused local.
430 * scroll.c (CHECK_BOUNDS):
431 * xfaces.c (cache_fache): Rename local to avoid shadowing.
432 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
433 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
434 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
435 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
436 Now static.
437 (debug_method_add): Use va_list and vsprintf rather than relying
438 on undefined behavior with wrong number of arguments.
439 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
440 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
441 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
442 since we're not interested in debugging glyphs with old libraries.
443 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
444 GCC 4.6.0's static checking.
445
0766b489
PE
4462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
447
31fd4b32
PE
448 Integer overflow and signedness fixes (Bug#8873).
449 A few related buffer overrun fixes, too.
450
b79e8648
PE
451 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
452
0766b489
PE
453 * dispextern.h (struct face.stipple):
454 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
455 (x_bitmap_mask, x_allocate_bitmap_record)
456 (x_create_bitmap_from_data, x_create_bitmap_from_file)
457 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
458 (x_create_bitmap_from_xpm_data):
459 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
460 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
461 (.bitmaps_last):
462 * xfaces.c (load_pixmap):
463 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
464 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
465 (.bitmaps_last, struct x_output.icon_bitmap):
466 Use ptrdiff_t, not int, for bitmap indexes.
467 (x_allocate_bitmap_record): Check for size overflow.
468 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
469
b081724f
PE
470 Use ptrdiff_t, not int, for overlay counts.
471 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
472 * editfns.c (overlays_around, get_pos_property):
473 * textprop.c (get_char_property_and_overlay):
474 * xdisp.c (next_overlay_change, note_mouse_highlight):
475 * xfaces.c (face_at_buffer_position):
21514da7
PE
476 * buffer.c (OVERLAY_COUNT_MAX): New macro.
477 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
478 (Fnext_overlay_change, Fprevious_overlay_change)
479 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 480 Use ptrdiff_t, not int, for sizes.
21514da7 481 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 482
3de73e5e
PE
483 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
484
2606c57b
PE
485 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
486 (x_session_initialize): Do not assume string length fits in int.
487
aaafe47a
PE
488 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
489 This is unlikely, but can occur if DPI is outlandish.
490
2674ddc8 491 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
492 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
493
28154962
PE
494 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
495 * xrdb.c (magic_file_p, search_magic_path):
496 Omit last arg SUFFIX; it was always 0. All callers changed.
497 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
498
7de51af5
PE
499 * xfont.c (xfont_match): Avoid need for strlen.
500
25ed6cc3
PE
501 * xfns.c: Don't assume strlen fits in int.
502 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
503
4eab31dd
PE
504 * xdisp.c (message_log_check_duplicate): Return intmax_t,
505 not unsigned long, as we prefer signed integers. All callers changed.
506 Detect integer overflow in repeat count.
507 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 508 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 509
171e2a58
PE
510 * termcap.c: Don't assume sizes fit in int and never overflow.
511 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
512 (gobble_line): Check for size-calculation overflow.
513
ad39faca 514 * minibuf.c (Fread_buffer):
6e5bb2dc 515 * lread.c (intern, intern_c_string):
74ca2eb3
PE
516 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
517 Don't assume string length fits in int.
518
52c61c22 519 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
520 * gtkutil.c (style_changed_cb): Avoid need for strlen.
521
b5b8c9e5
PE
522 * font.c: Don't assume string length fits in int.
523 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
524 Use ptrdiff_t, not int.
ccd6111c
PE
525 (font_intern_prop): Don't assume string length fits in int.
526 Don't assume integer property fits in fixnum.
527 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 528
882f0d81 529 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 530 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
531 Reformulate so as not to need the command string.
532 Invoke gzip -cd rather than gunzip, as it's more portable.
533 (lock_info_type, lock_file_1, lock_file):
534 Don't assume pid_t and time_t fit in unsigned long.
535 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
536 (current_lock_owner): Prefer signed type for sizes.
537 Use memcpy, not strncpy, where memcpy is what is really wanted.
538 Don't assume (via atoi) that time_t and pid_t fit in int.
539 Check for time_t and/or pid_t out of range, e.g., via a network share.
540 Don't alloca where an auto var works fine.
541
93f4cf88
PE
542 * fileio.c: Fix some integer overflow issues.
543 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
544 Don't assume string length fits in int.
545 (directory_file_name): Don't assume string length fits in long.
546 (make_temp_name): Don't assume pid fits in int, or that its print
547 length is less than 20.
548
f3e92b69
PE
549 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
550
1bfdaf10
PE
551 * coding.c (make_subsidiaries): Don't assume string length fits in int.
552
35016e9a
PE
553 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
554
3d1e65a1
PE
555 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
556 We prefer signed integers, even for size calculations.
557
0b963a93
PE
558 * emacs.c: Don't assume string length fits in 'int'.
559 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
560 (main): Don't invoke strlen when not needed.
561
573f4b54
PE
562 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
563 (XD_DEBUG_MESSAGE): Don't waste a byte.
564
989f33ba
PE
565 * callproc.c (getenv_internal_1, getenv_internal)
566 (Fgetenv_internal):
965d34eb
PE
567 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
568
e4d29b33
PE
569 * lread.c (invalid_syntax): Omit length argument.
570 All uses changed. This doesn't fix a bug, but it simplifies the
571 code away from its former Hollerith-constant appearance, and it's
572 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 573 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 574
eb49b136
PE
575 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
576 This didn't break anything, but it didn't help either.
577 It's confusing to put a bogus integer in a place where the actual
578 value does not matter.
9f62aeb1 579 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 580 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 581
15375a22
PE
582 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
583 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
584 implementation.
b61cc01c
PE
585 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
586 We prefer signed types, and the value cannot exceed the EMACS_INT
587 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
588 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
589 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
590 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 591
53b2623d
PE
592 * indent.c (sane_tab_width): New function.
593 (current_column, scan_for_column, Findent_to, position_indentation)
594 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 595 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 596
51cab52b 597 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 598
f2ed8a70
PE
599 * lisp.h (lint_assume): New macro.
600 * composite.c (composition_gstring_put_cache):
601 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
602
abe80cc6
PE
603 * editfns.c, insdel.c:
604 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 605
b02c740e
PE
606 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
607
ebc96716
PE
608 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
609
b4e50fa0 610 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 611 Use much-faster test for byte-length change.
311d5d7c 612 Don't assume string byte-length fits in 'int'.
a4cf38e4 613 Check that character arg fits in 'int'.
85461888 614 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 615
c0c1ee9f
PE
616 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
617
a498d7f4
PE
618 * fns.c (concat): Catch string overflow earlier.
619 Do not rely on integer wraparound.
620
51cab52b
PE
621 * dispextern.h (struct it.overlay_strings_charpos)
622 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
623 * xdisp.c (forward_to_next_line_start)
624 (back_to_previous_visible_line_start)
625 (reseat_at_next_visible_line_start, next_element_from_buffer):
626 Don't arbitrarily truncate the value of 'selective' to int.
627
76031fad
PE
628 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
629
5eb55db9
PE
630 * composite.c: Don't truncate sizes to 'int'.
631 (composition_gstring_p, composition_reseat_it)
632 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
633 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
634 not EMACS_UINT, for indexes.
5eb55db9 635
0703a717
PE
636 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
637
d6202519
PE
638 * buffer.c: Include <verify.h>.
639 (struct sortvec.priority, struct sortstr.priority):
8961a454 640 Now EMACS_INT, not int.
c20998a7 641 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
642 (struct sortstr.size, record_overlay_string)
643 (struct sortstrlist.size, struct sortlist.used):
644 Don't truncate size to int.
645 (record_overlay_string): Check for size-calculation overflow.
d6202519 646 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 647
d5a19415
JM
6482011-06-22 Jim Meyering <meyering@redhat.com>
649
029529ac 650 Don't leak an XBM-image-sized buffer
d5a19415
JM
651 * image.c (xbm_load): Free the image buffer after using it.
652
a9041e6c
PE
6532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
654
655 Port to Sun C.
656 * composite.c (find_automatic_composition): Omit needless 'return 0;'
657 that Sun C diagnosed.
658 * fns.c (secure_hash): Fix pointer signedness issue.
659 * intervals.c (static_offset_intervals): New function.
660 (offset_intervals): Use it.
661
7f3f739f
LL
6622011-06-21 Leo Liu <sdl.web@gmail.com>
663
664 * deps.mk (fns.o):
665 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
666 sha512.h.
667
668 * fns.c (secure_hash): Rename from crypto_hash_function and change
669 the first arg to accept symbols.
5b66d427 670 (Fsecure_hash): New primitive.
7f3f739f
LL
671 (syms_of_fns): New symbols.
672
76147d94
DD
6732011-06-20 Deniz Dogan <deniz@dogan.se>
674
675 * process.c (Fset_process_buffer): Clarify return value in
676 docstring.
677
7d7d0045
CY
6782011-06-18 Chong Yidong <cyd@stupidchicken.com>
679
680 * dispnew.c (add_window_display_history): Use BVAR.
681
682 * xdisp.c (debug_method_add): Use BVAR.
683 (check_window_end, dump_glyph_matrix, dump_glyph)
684 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
685
686 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
687 Likewise.
688
689 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
690 check till after the cache is created in init_frame_faces.
691
ff2bc410
SM
6922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
695
28177add
PE
6962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
697
dd3482fe
PE
698 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
699 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
700 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
701
393d71f3 702 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
703 * fileio.c (Finsert_file_contents):
704 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
705 Remove the old (too-loose) buffer overflow checks.
706 They weren't needed, since make_gap checks for buffer overflow.
707 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
708 The old code merely checked for Emacs fixnum overflow, and relied
709 on undefined (wraparound) behavior. The new code avoids undefined
710 behavior, and also checks for ptrdiff_t and/or size_t overflow.
711
2e6813b0 712 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
713 Tune. Don't use wider integers than needed. Don't use alloca.
714 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 715
599a9e4f
PE
716 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
717
99561444
PE
718 * insdel.c, lisp.h (buffer_overflow): New function.
719 (insert_from_buffer_1, replace_range, replace_range_2):
720 * insdel.c (make_gap_larger):
721 * editfns.c (Finsert_char):
722 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
723
28177add
PE
724 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
725
e69dafad
PE
7262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
727
a7af7fde 728 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 729
b1c46f02
PE
730 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
731 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
732
e69dafad
PE
733 * fileio.c: Don't assume EMACS_INT fits in off_t.
734 (emacs_lseek): New static function.
735 (Finsert_file_contents, Fwrite_region): Use it.
736 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
737
566684ea
PE
738 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
739
e6966cd6
PE
740 * fns.c: Don't overflow int when computing a list length.
741 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
742 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
743 truncation on 64-bit hosts. Check for QUIT every
744 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
745 faster and is responsive enough.
746 (Flength): Report an error instead of overflowing an integer.
747 (Fsafe_length): Return a float if the value is not representable
748 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 749 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 750 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 751
dd0b0efb
PE
752 * alloc.c: Check that resized vectors' lengths fit in fixnums.
753 (header_size, word_size): New constants.
754 (allocate_vectorlike): Don't check size overflow here.
755 (allocate_vector): Check it here instead, since this is the only
756 caller of allocate_vectorlike that could cause overflow.
757 Check that the new vector's length is representable as a fixnum.
758
86fe5cfe
PE
759 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
760 The previous code was bogus. For example, next_almost_prime (32)
761 returned 39, which is undesirable as it is a multiple of 3; and
762 next_almost_prime (24) returned 25, which is a multiple of 5 so
763 why was the code bothering to check for multiples of 7?
764
80e88859
PE
765 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
766
4a2f0ad6
PE
767 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
768
f66c7cf8
PE
769 Variadic C functions now count arguments with ptrdiff_t.
770 This partly undoes my 2011-03-30 change, which replaced int with size_t.
771 Back then I didn't know that the Emacs coding style prefers signed int.
772 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
773 were being counted with int, which may truncate counts on 64-bit
774 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
775 * lisp.h (struct Lisp_Subr.function.aMANY)
776 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
777 Arg counts are now ptrdiff_t, not size_t.
778 All variadic functions and their callers changed accordingly.
779 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
780 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
781 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
782 * callint.c (Fcall_interactively): Check arg count for overflow,
783 to avoid potential buffer overrun. Use signed char, not 'int',
784 for 'varies' array, so that we needn't bother to check its size
785 calculation for overflow.
786 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
787 * eval.c (apply_lambda):
788 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
789 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
790 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
791
a1759b76
PE
792 * callint.c (Fcall_interactively): Don't use index var as event count.
793
d96be9fc
PE
794 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
795 * mem-limits.h (SIZE): Remove; no longer used.
796
a690a978 797 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 798
578c21e6
PE
799 Remove unnecessary casts.
800 * xterm.c (x_term_init):
801 * xfns.c (x_set_border_pixel):
802 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
803 These aren't needed now that we assume ANSI C.
804
96f53c6c
PE
805 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
806 It's more likely to cause problems (due to unsigned overflow)
807 than to cure them.
808
83c77d31
PE
809 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
810
ee2079f1
PE
811 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
812
6da65536
PE
813 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
814
7147c4a4
PE
815 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
816
193e32d9
PE
817 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
818
e5533da6
PE
819 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
820
9910e595
PE
821 GLYPH_CODE_FACE returns EMACS_INT, not int.
822 * dispextern.h (merge_faces):
823 * xfaces.c (merge_faces):
01103c44
PE
824 * xdisp.c (get_next_display_element, next_element_from_display_vector):
825 Don't assume EMACS_INT fits in int.
9910e595 826
2638320e
PE
827 * character.h (CHAR_VALID_P): Remove unused parameter.
828 * fontset.c, lisp.h, xdisp.c: All uses changed.
829
045eb8d9
PE
830 * editfns.c (Ftranslate_region_internal): Omit redundant test.
831
c1f134b5
PE
832 * fns.c (concat): Minor tuning based on overflow analysis.
833 This doesn't fix any bugs. Use int to hold character, instead
834 of constantly refetching from Emacs object. Use XFASTINT, not
835 XINT, for value known to be a character. Don't bother comparing
836 a single byte to 0400, as it's always less.
837
395fcb93 838 * floatfns.c (Fexpt):
327eeec8
PE
839 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
840
abbd3d23
PE
841 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
842 for characters.
843
684a03ef
PE
844 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
845
0fed43f3
PE
846 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
847 Without this fix, on a 64-bit host (aset S 0 4294967386) would
848 incorrectly succeed when S was a string, because 4294967386 was
849 truncated before it was used.
850
8fd02eb7
PE
851 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
852 Otherwise, an out-of-range integer could cause undefined behavior
853 on a 64-bit host.
854
f8c86b69
PE
855 * composite.c: Use int, not EMACS_INT, for characters.
856 (fill_gstring_body, composition_compute_stop_pos): Use int, not
857 EMACS_INT, for values that are known to be in character range.
858 This doesn't fix any bugs but is the usual style inside Emacs and
859 may generate better code on 32-bit machines.
860
34206dd2
PE
861 Make sure a 64-bit char is never passed to ENCODE_CHAR.
862 This is for reasons similar to the recent CHAR_STRING fix.
863 * charset.c (Fencode_char): Check that character arg is actually
864 a character. Pass an int to ENCODE_CHAR.
865 * charset.h (ENCODE_CHAR): Verify that the character argument is no
866 wider than 'int', as a compile-time check to prevent future regressions
867 in this area.
868
c5958d4c 869 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
870
871 Make sure a 64-bit char is never passed to CHAR_STRING.
872 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
873 by silently ignoring the top 32 bits, allowing some values
874 that were far too large to be valid characters.
875 * character.h: Include <verify.h>.
876 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
877 arguments are no wider than unsigned, as a compile-time check
878 to prevent future regressions in this area.
879 * data.c (Faset):
01103c44 880 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
881 (Fsubst_char_in_region):
882 * fns.c (concat):
883 * xdisp.c (decode_mode_spec_coding):
884 Adjust to CHAR_STRING's new requirement.
885 * editfns.c (Finsert_char, Fsubst_char_in_region):
886 * fns.c (concat): Check that character args are actually
887 characters. Without this test, these functions did the wrong
888 thing with wildly out-of-range values on 64-bit hosts.
889
d37ca623
PE
890 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
891 These casts should not be needed on 32-bit hosts, either.
892 * keyboard.c (read_char):
893 * lread.c (Fload): Remove casts to unsigned.
894
ea204efb
PE
895 * lisp.h (UNSIGNED_CMP): New macro.
896 This fixes comparison bugs on 64-bit hosts.
897 (ASCII_CHAR_P): Use it.
898 * casefiddle.c (casify_object):
01103c44 899 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
900 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
901 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
902 * dispextern.h (FACE_FROM_ID):
903 * keyboard.c (read_char): Use UNSIGNED_CMP.
904
41cb286c
PE
905 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
906 not to EMACS_INT, to avoid GCC warning.
907
4a1b9832
PE
908 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
909
55daad71
PE
910 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
911 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
912 isn't needed on 32-bit machines.
8f95c75c 913
01103c44
PE
914 * buffer.c (Fgenerate_new_buffer_name):
915 Use EMACS_INT for count, not int.
0ceccced 916 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
917
918 * data.c (Qcompiled_function): Now static.
919
c6f072e7
PE
920 * window.c (window_body_lines): Now static.
921
20ce5912
PE
922 * image.c (gif_load): Rename local to avoid shadowing.
923
9c4c5f81
PE
924 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
925 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
926 * alloc.c (make_save_value): Integer argument is now of type
927 ptrdiff_t, not int.
928 (mark_object): Use ptrdiff_t, not int.
929 * lisp.h (pD): New macro.
930 * print.c (print_object): Use it.
931
c0c5c8ae
PE
932 * alloc.c: Use EMACS_INT, not int, to count objects.
933 (total_conses, total_markers, total_symbols, total_vector_size)
934 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
935 (total_free_floats, total_floats, total_free_intervals)
936 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
937 Now EMACS_INT, not int. All uses changed.
938 (Fgarbage_collect): Compute overall total using a double, so that
939 integer overflow is less likely to be a problem. Check for overflow
940 when converting back to an integer.
5a25e253
PE
941 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
942 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
943 These were 'int' variables that could overflow on 64-bit hosts;
944 they were never used, so remove them instead of repairing them.
211a0b2a 945 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
946 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
947 Previously, this ceilinged at INT_MAX, but that doesn't work on
948 64-bit machines.
e46bb31a 949 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 950
c78baabf 951 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 952 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
953 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
954 when a (possibly-narrower) signed value would do just as well.
955 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 956
c9d624c6
PE
957 * alloc.c: Catch some string size overflows that we were missing.
958 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
959 for convenience in STRING_BYTES_MAX.
960 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
961 The definition here is exact; the one in lisp.h was approximate.
962 (allocate_string_data): Check for string overflow. This catches
963 some instances we weren't catching before. Also, it catches
964 size_t overflow on (unusual) hosts where SIZE_MAX <= min
965 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
966 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 967
c9d624c6
PE
968 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
969 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
970 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
971
353032ce
PE
972 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
973
2bccce07
PE
974 * alloc.c (Fmake_string): Check for out-of-range init.
975
0ac30604
SM
9762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
977
978 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
979
c195f2de
JD
9802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
981
982 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
983 xg_get_default_scrollbar_width.
984
985 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
986 (int_gtk_range_get_value): Move to the scroll bar part of the file.
987 (style_changed_cb): Call update_theme_scrollbar_width and call
988 x_set_scroll_bar_default_width and xg_frame_set_char_size for
989 all frames (Bug#8505).
990 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
991 Call gtk_window_set_resizable if HAVE_GTK3.
992 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
993 and height if HAVE_GTK3 (Bug#8505).
994 (scroll_bar_width_for_theme): New variable.
995 (update_theme_scrollbar_width): New function.
996 (xg_get_default_scrollbar_width): Move code to
997 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
998 (xg_initialize): Call update_theme_scrollbar_width.
999
1000 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1001
1002 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1003
e10ac9f1
MR
10042011-06-12 Martin Rudalics <rudalics@gmx.at>
1005
1006 * frame.c (make_frame): Call other_buffer_safely instead of
1007 other_buffer.
1008
1009 * window.c (temp_output_buffer_show): Call display_buffer with
1010 second argument Vtemp_buffer_show_specifiers and reset latter
1011 immediately after the call.
1012 (Vtemp_buffer_show_specifiers): New variable.
1013 (auto_window_vscroll_p, next_screen_context_lines)
1014 (Vscroll_preserve_screen_position): Remove leading asterisks from
1015 doc-strings.
1016
2d3c217e 10172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1018
7b7f97e8 1019 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1020 * buffer.c (Qclone_number): Remove for now, as it's unused.
1021 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1022 (record_buffer): Remove unused local.
1023 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1024 (set_frame_buffer_list): Remove; unused.
1025 * frame.h (other_visible_frames): Remove decl.
1026 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1027 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1028 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1029 if HAVE_GPM.
1030 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1031 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1032 Define only if HAVE_GPM.
1033 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1034 (update_hints_inhibit): Remove; never set. All uses removed.
1035 * widgetprv.h (emacsFrameClassRec): Remove decl.
1036 * window.c (delete_deletable_window): Now returns void, since it
1037 wasn't returning anything.
1038 (compare_window_configurations): Remove unused locals.
1039 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1040 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1041 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1042 the same widths as pointers. This follows up on the 2011-05-06 patch.
1043 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1044 * xterm.h: Likewise.
1045 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1046
1384b89e
JB
10472011-06-12 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * makefile.w32-in: Update dependencies.
1050 (LISP_H): Add lib/intprops.h.
1051
1100a63c
CY
10522011-06-11 Chong Yidong <cyd@stupidchicken.com>
1053
1054 * image.c (gif_load): Add animation frame delay to the metadata.
1055 (syms_of_image): Use DEFSYM. New symbol `delay'.
1056
6198ccd0
MR
10572011-06-11 Martin Rudalics <rudalics@gmx.at>
1058
1059 * window.c (delete_deletable_window): Re-add.
1060 (Fset_window_configuration): Rewrite to handle dead buffers and
1061 consequently deletable windows.
1062 (window_tree, Fwindow_tree): Remove. Supply functionality in
1063 window.el.
1064 (compare_window_configurations): Simplify code.
1065
b6e3633c
AS
10662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1067
1ab0dee5
AS
1068 * image.c (imagemagick_load_image): Fix type mismatch.
1069 (Fimagemagick_types): Likewise.
1070
b6e3633c
AS
1071 * window.h (replace_buffer_in_windows): Declare.
1072
9397e56f
MR
10732011-06-11 Martin Rudalics <rudalics@gmx.at>
1074
1075 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1076 Qclone_number. Remove external declaration of Qdelete_window.
1077 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1078 code.
1079 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1080 Qbuffer_list_update_hook if allowed.
1081 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1082 buffer list implementation.
1083 (other_buffer_safely): New function.
1084 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1085 calls to replace_buffer_in_windows and
1086 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1087 if allowed.
1088 (record_buffer): Inhibit quitting and rewrite using quittable
1089 functions. Run Qbuffer_list_update_hook if allowed.
1090 (Frecord_buffer, Funrecord_buffer): New functions.
1091 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1092 switch-to-buffer to window.el.
1093 (bury-buffer): Move to window.el.
1094 (Vbuffer_list_update_hook): New variable.
1095
1096 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1097 section.
1098
1099 * window.h (resize_frame_windows): Move up in code.
1100 (Fwindow_frame): Remove EXFUN.
1101 (replace_buffer_in_all_windows): Remove prototype.
1102 (replace_buffer_in_windows_safely): Add prototype.
1103
1104 * window.c: Declare Qdelete_window static again. Move down
1105 declaration of select_count.
1106 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1107 (Fother_window): Move to window.el.
1108 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1109 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1110 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1111 window.el.
1112 (replace_buffer_in_windows): Implement by calling
1113 Qreplace_buffer_in_windows.
1114 (replace_buffer_in_all_windows): Remove with some functionality
1115 moved into replace_buffer_in_windows_safely.
1116 (replace_buffer_in_windows_safely): New function.
1117 (select_window_norecord, select_frame_norecord): Move in front
1118 of run_window_configuration_change_hook. Remove now obsolete
1119 declarations.
1120 (Fset_window_buffer): Rewrite doc-string. Call
1121 Qrecord_window_buffer.
1122 (keys_of_window): Move binding for other-window to window.el.
1123
b50691aa
CY
11242011-06-11 Chong Yidong <cyd@stupidchicken.com>
1125
1126 * dispextern.h (struct image): Replace data member, whose int_val
1127 and ptr_val fields were not used by anything, with a single
1128 lisp_val object.
1129
1130 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1131 (gif_clear_image, gif_load, imagemagick_load_image)
1132 (gs_clear_image, gs_load): Callers changed.
1133
3f754b86
PE
11342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1135
cca69397
PE
1136 * buffer.h: Include <time.h>, for time_t.
1137 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1138
109e28d0
PE
1139 Fix minor problems found by static checking.
1140
60737f02
PE
1141 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1142
4b66faf3
PE
1143 Make identifiers static if they are not used in other modules.
1144 * data.c (Qcompiled_function, Qframe, Qvector):
1145 * image.c (QimageMagick, Qsvg):
1146 * minibuf.c (Qmetadata):
1147 * window.c (resize_window_check, resize_root_window): Now static.
1148 * window.h (resize_window_check, resize_root_window): Remove decls.
1149
109e28d0
PE
1150 * window.c (window_deletion_count, delete_deletable_window):
1151 Remove; unused.
46a4ce9e
PE
1152 (window_body_lines): Now static.
1153 (Fdelete_other_windows_internal): Mark vars as initialized.
1154 Make sure 'resize_failed' is initialized.
1155 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1156 (resize_window_apply): Remove unused local.
1157 * window.h (delete_deletable_window): Remove decl.
1158
109e28d0 1159 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1160 (imagemagick_load_image): Fix pointer signedness problem by changing
1161 last arg from unsigned char * to char *. All uses changed.
1162 Also, fix a local for similar reasons.
1163 Remove unused locals. Remove locals to avoid shadowing.
1164 (fn_rsvg_handle_free): Remove; unused.
1165 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1166 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1167
3f754b86
PE
1168 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1169
2547adb1
CY
11702011-06-10 Chong Yidong <cyd@stupidchicken.com>
1171
1172 * image.c (gif_load): Fix omitted cast error introduced by
1173 2011-06-06 change.
1174
2c8e37d4
MR
11752011-06-10 Martin Rudalics <rudalics@gmx.at>
1176
1177 * window.h (resize_proportionally, orig_total_lines)
1178 (orig_top_line): Remove from window structure.
1179 (set_window_height, set_window_width, change_window_heights)
1180 (Fdelete_window): Remove prototypes.
1181 (resize_frame_windows): Remove duplicate declaration.
1182
440a42e3
EZ
11832011-06-10 Eli Zaretskii <eliz@gnu.org>
1184
1185 * window.h (resize_frame_windows, resize_window_check)
1186 (delete_deletable_window, resize_root_window)
1187 (resize_frame_windows): Declare prototypes.
1188
1189 * window.c (resize_window_apply): Make definition be "static" to
1190 match the prototype.
1191
562dd5e9
MR
11922011-06-10 Martin Rudalics <rudalics@gmx.at>
1193
1194 * window.c: Remove declarations of Qwindow_size_fixed,
1195 window_min_size_1, window_min_size_2, window_min_size,
1196 size_window, window_fixed_size_p, enlarge_window, delete_window.
1197 Remove static from declaration of Qdelete_window, it's
1198 temporarily needed by Fbury_buffer.
1199 (replace_window): Don't assign orig_top_line and
1200 orig_total_lines.
1201 (Fdelete_window, delete_window): Remove. Window deletion is
1202 handled by window.el.
1203 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1204 Fdelete_window calls with calls to Qdelete_window.
1205 (Fdelete_other_windows): Remove. Deleting other windows is
1206 handled by window.el.
1207 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1208 handled in window.el.
1209 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1210 Window minimum sizes are handled in window.el.
1211 (shrink_windows, size_window, set_window_height)
1212 (set_window_width, change_window_heights, window_height)
1213 (window_width, CURBEG, CURSIZE, enlarge_window)
1214 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1215 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1216 handled in window.el.
1217 (make_dummy_parent): Rename to make_parent_window and give it a
1218 second argument horflag.
1219 (make_window): Don't set resize_proportionally any more.
1220 (Fsplit_window): Remove. Windows are split in window.el.
1221 (save_restore_action, save_restore_orig_size)
1222 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1223 Resize mini windows in window.el.
1224 (grow_mini_window, shrink_mini_window): Implement by calling
1225 Qresize_root_window_vertically, resize_window_check and
1226 resize_window_apply.
1227 (saved_window, Fset_window_configuration, save_window_save): Do
1228 not handle orig_top_line, orig_total_lines, and
1229 resize_proportionally.
1230 (window_min_height, window_min_width): Move to window.el.
1231 (keys_of_window): Move bindings for delete-other-windows,
1232 split-window, delete-window and enlarge-window to window.el.
1233
1234 * buffer.c: Temporarily extern Qdelete_window.
1235 (Fbury_buffer): Temporarily call Qdelete_window instead of
1236 Fdelete_window (Fbury_buffer will move to window.el soon).
1237
1238 * frame.c (set_menu_bar_lines_1): Remove code handling
1239 orig_top_line and orig_total_lines.
1240
1241 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1242 set_window_height but set heights directly.
1243 (change_frame_size_1): Use resize_frame_windows.
1244
1245 * xdisp.c (init_xdisp): Don't use set_window_height but set
1246 heights directly.
1247
1248 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1249 resize_frame_windows instead of change_window_heights and run
1250 run_window_configuration_change_hook.
1251
1252 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1253 instead of change_window_heights and run
1254 run_window_configuration_change_hook.
1255
1a13852e
MR
12562011-06-09 Martin Rudalics <rudalics@gmx.at>
1257
1258 * window.c (replace_window): Rename second argument REPLACEMENT to
1259 NEW. New third argument SETFLAG. Rewrite.
1260 (delete_window, make_dummy_parent): Call replace_window with
1261 third argument 1.
1262 (window_list_1): Move down in code.
1263 (run_window_configuration_change_hook): Move set_buffer part
1264 before select_frame_norecord part in order to unwind correctly.
1265 Rename count1 to count.
1266 (recombine_windows, delete_deletable_window, resize_root_window)
1267 (Fdelete_other_windows_internal)
1268 (Frun_window_configuration_change_hook, make_parent_window)
1269 (resize_window_check, resize_window_apply, Fresize_window_apply)
1270 (resize_frame_windows, Fsplit_window_internal)
1271 (Fdelete_window_internal, Fresize_mini_window_internal): New
1272 functions.
1273 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1274
f3d1777e
MR
12752011-06-08 Martin Rudalics <rudalics@gmx.at>
1276
496e208e
MR
1277 * window.h (window): Add some new members to window structure -
1278 normal_lines, normal_cols, new_total, new_normal, clone_number,
1279 splits, nest, prev_buffers, next_buffers.
1280 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1281 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1282
f3d1777e
MR
1283 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1284 Remove.
496e208e
MR
1285 (make_dummy_parent): Set new members of windows structure.
1286 (make_window): Move down in code. Handle new members of window
1287 structure.
1288 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1289 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1290 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1291 (Fset_window_prev_buffers, Fwindow_next_buffers)
1292 (Fset_window_next_buffers, Fset_window_clone_number): New
1293 functions.
1294 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1295 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1296 Doc-string fixes.
1297 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1298 Argument WINDOW can be now internal window too.
1299 (Fwindow_use_time): Move up in code.
1300 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1301 Rewrite doc-string.
1302 (Fset_window_configuration, saved_window)
1303 (Fcurrent_window_configuration, save_window_save): Handle new
1304 members of window structure.
b9e809c2
MR
1305 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1306 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1307 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1308 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1309 Qget_mru_window, Qresize_root_window,
1310 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1311 Qauto_buffer_name; staticpro them.
f3d1777e 1312
abde8f8c
MR
13132011-06-07 Martin Rudalics <rudalics@gmx.at>
1314
1315 * window.c (Fwindow_total_size, Fwindow_left_column)
1316 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1317 (Fwindow_list_1): New functions.
1318 (window_box_text_cols): Replace with window_body_cols.
1319 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1320 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1321 (delete_window, Fset_window_configuration): Call
1322 delete_all_subwindows with window as argument.
1323 (delete_all_subwindows): Take a window as argument and not a
1324 structure. Rewrite.
190b47e6
MR
1325 (window_loop): Remove handling of GET_LRU_WINDOW and
1326 GET_LARGEST_WINDOW.
1327 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1328
1329 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1330 window_box_text_cols. delete_all_subwindows now takes a
1331 Lisp_Object as argument.
abde8f8c
MR
1332
1333 * indent.c (compute_motion, Fcompute_motion): Use
1334 window_body_cols instead of window_box_text_cols.
1335
fa8a67e6
MR
1336 * frame.c (delete_frame): Call delete_all_subwindows with root
1337 window as argument.
1338
a54e3482
DC
13392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1340
1341 * fns.c (Fputhash): Document return value.
1342
60002bf5
CY
13432011-06-06 Chong Yidong <cyd@stupidchicken.com>
1344
1345 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1346
0c671da6 13472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1348
b862a52a 1349 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1350
be44ca6c
PE
1351 Check for overflow when converting integer to cons and back.
1352 * charset.c (Fdefine_charset_internal, Fdecode_char):
1353 Use cons_to_unsigned to catch overflow.
1354 (Fencode_char): Use INTEGER_TO_CONS.
1355 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1356 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1357 * data.c (long_to_cons, cons_to_long): Remove.
1358 (cons_to_unsigned, cons_to_signed): New functions.
1359 These signal an error for invalid or out-of-range values.
1360 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1361 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1362 * font.c (Ffont_variation_glyphs):
1363 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1364 * lisp.h: Include <intprops.h>.
1365 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1366 (cons_to_signed, cons_to_unsigned): New decls.
1367 (long_to_cons, cons_to_long): Remove decls.
1368 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1369 (Fprimitive_undo): Use CONS_TO_INTEGER.
1370 * xfns.c (Fx_window_property): Likewise.
1371 * xselect.c: Include <limits.h>.
1372 (x_own_selection, selection_data_to_lisp_data):
1373 Use INTEGER_TO_CONS.
1374 (x_handle_selection_request, x_handle_selection_clear)
1375 (x_get_foreign_selection, Fx_disown_selection_internal)
1376 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1377 (lisp_data_to_selection_data): Use cons_to_unsigned.
1378 (x_fill_property_data): Use cons_to_signed.
1379 Report values out of range.
1380
d1f3d2af
PE
1381 Check for buffer and string overflow more precisely.
1382 * buffer.h (BUF_BYTES_MAX): New macro.
1383 * lisp.h (STRING_BYTES_MAX): New macro.
1384 * alloc.c (Fmake_string):
1385 * character.c (string_escape_byte8):
1386 * coding.c (coding_alloc_by_realloc):
1387 * doprnt.c (doprnt):
1388 * editfns.c (Fformat):
1389 * eval.c (verror):
1390 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1391 since they may not be the same number.
1392 * editfns.c (Finsert_char):
1393 * fileio.c (Finsert_file_contents):
1394 Likewise for BUF_BYTES_MAX.
1395
dd52fcea
PE
1396 * image.c: Use ptrdiff_t, not int, for sizes.
1397 (slurp_file): Switch from int to ptrdiff_t.
1398 All uses changed.
1399 (slurp_file): Check that file size fits in both size_t (for
1400 malloc) and ptrdiff_t (for sanity and safety).
1401
7f9bbdbb
PE
1402 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1403 if b->modtime has its maximal value.
1404
dfe18f82
PE
1405 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1406
84acfcf0
PE
1407 Don't assume time_t can fit into int.
1408 * buffer.h (struct buffer.modtime): Now time_t, not int.
1409 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1410 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1411
ccd9a01a
PE
1412 Minor fixes for signed vs unsigned integers.
1413 * character.h (MAYBE_UNIFY_CHAR):
1414 * charset.c (maybe_unify_char):
1415 * keyboard.c (read_char, reorder_modifiers):
1416 XINT -> XFASTINT, since the integer must be nonnegative.
1417 * ftfont.c (ftfont_spec_pattern):
1418 * keymap.c (access_keymap, silly_event_symbol_error):
1419 XUINT -> XFASTINT, since the integer must be nonnegative.
1420 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1421 since it makes no difference and we prefer signed.
1422 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1423 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1424 nonnegative.
1425
d6d100dd
SM
14262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1427
1428 * window.h (Fwindow_frame): Declare.
1429
2b6148e4
PE
14302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1431
1432 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1433 (SPARE_MEMORY): Always define.
1434 (LARGE_REQUEST): Remove.
1435 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1436
f230ecc9
MR
14372011-06-06 Martin Rudalics <rudalics@gmx.at>
1438
727e958e
MR
1439 * lisp.h: Move EXFUNS for Fframe_root_window,
1440 Fframe_first_window and Fset_frame_selected_window to window.h.
1441
1442 * window.h: Move EXFUNS for Fframe_root_window,
1443 Fframe_first_window and Fset_frame_selected_window here from
1444 lisp.h.
1445
1446 * frame.c (Fwindow_frame, Fframe_first_window)
1447 (Fframe_root_window, Fframe_selected_window)
1448 (Fset_frame_selected_window): Move to window.c.
1449 (Factive_minibuffer_window): Move to minibuf.c.
1450 (Fother_visible_frames_p): New function.
1451
1452 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1453
f230ecc9
MR
1454 * window.c (decode_window, decode_any_window): Move up in code.
1455 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1456 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1457 (Fwindow_buffer): Move up and rewrite doc-string.
1458 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1459 (Fwindow_prev): New functions.
727e958e
MR
1460 (Fwindow_frame): Move here from frame.c. Accept any window as
1461 argument.
1462 (Fframe_root_window, Fframe_first_window)
1463 (Fframe_selected_window): Move here from frame.c. Accept frame
1464 or arbitrary window as argument. Update doc-strings.
1465 (Fminibuffer_window): Move up in code.
1466 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1467 (Fset_frame_selected_window): Move here from frame.c.
1468 Marginal rewrite.
727e958e
MR
1469 (Fselected_window, select_window, Fselect_window): Move up in
1470 code. Minor doc-string fixes.
f230ecc9 1471
4d09bcf6
PE
14722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1475 Do not assume that spare memory exists; that assumption is valid
1476 only if SYSTEM_MALLOC.
1477 (LARGE_REQUEST): New macro, so that the issue of large requests
1478 is separated from the issue of spare memory.
1479
810928a2
AS
14802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1481
172418ad
AS
1482 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1483 format. (Bug#8806)
1484
43f862f7
AS
1485 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1486
810928a2
AS
1487 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1488 before statements.
1489
a059fe24
JD
14902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1491
1492 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1493
1494 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1495
1496 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1497 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1498
989bf368
JB
14992011-06-05 Juanma Barranquero <lekktu@gmail.com>
1500
1501 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1502
4b80f674
CY
15032011-06-04 Chong Yidong <cyd@stupidchicken.com>
1504
1505 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1506 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1507 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1508 New error handlers.
4b80f674
CY
1509 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1510 Obey Vx_select_enable_clipboard_manager. Catch errors in
1511 x_clipboard_manager_save (Bug#8779).
1512 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1513 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1514
99a33b77 15152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1516
1517 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1518
99a33b77 15192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1520
1521 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1522 in the current matrix if keep_current_p is non-zero.
1523
8264569d
EZ
15242011-06-04 Eli Zaretskii <eliz@gnu.org>
1525
1526 * bidi.c (bidi_level_of_next_char): Fix last change.
1527
57f97249
EZ
15282011-06-03 Eli Zaretskii <eliz@gnu.org>
1529
fec2107c 1530 Support bidi reordering of text covered by display properties.
57f97249 1531
fec2107c
EZ
1532 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1533 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1534 (bidi_cache_search, bidi_cache_iterator_state)
1535 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1536 (bidi_level_of_next_char, bidi_move_to_visually_next):
1537 Support character positions inside a run of characters covered by a
fec2107c
EZ
1538 display string.
1539 (bidi_paragraph_init, bidi_resolve_explicit_1)
1540 (bidi_level_of_next_char): Call bidi_fetch_char and
1541 bidi_fetch_char_advance instead of FETCH_CHAR and
1542 FETCH_CHAR_ADVANCE.
1543 (bidi_init_it): Initialize new members.
1544 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1545 definitions.
1546 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1547 instead of using explicit *_CHAR codes.
d6d100dd
SM
1548 (bidi_resolve_explicit, bidi_resolve_weak):
1549 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1550 bidirectional text is supported only in multibyte buffers.
1551 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1552 it to initialize the frame_window_p member of struct bidi_it.
1553 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1554 (bidi_resolve_explicit, bidi_resolve_weak)
1555 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1556 bidi_it->nchars is non-positive.
1557 (bidi_level_of_next_char): Don't try to lookup the cache for the
1558 next/previous character if nothing is cached there yet, or if we
1559 were just reseat()'ed to a new position.
c40e2fb2 1560
0e14fe90
EZ
1561 * xdisp.c (set_cursor_from_row): Set start and stop points
1562 according to the row's direction when priming the loop that looks
1563 for the glyph on which to display cursor.
1564 (single_display_spec_intangible_p): Function deleted.
1565 (display_prop_intangible_p): Reimplement to call
1566 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1567 Accept 3 additional arguments needed by handle_display_spec.
1568 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1569 values: lists, `(when COND...)' forms, etc.
1570 (single_display_spec_string_p): Support property values that are
1571 lists with the argument STRING its top-level element.
1572 (display_prop_string_p): Fix the condition for processing a
1573 property that is a list to be consistent with handle_display_spec.
fec2107c 1574 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1575 last portion of handle_display_prop.
1576 (compute_display_string_pos): Accept additional argument
1577 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1578 value of a `display' property is a "replacing spec".
1579 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1580 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1581 the display property, but just return a value indicating whether
1582 the display property will replace the characters it covers.
1583 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1584 frame_window_p members of struct bidi_it.
d6d100dd
SM
1585 (compute_display_string_pos, compute_display_string_end):
1586 New functions.
fec2107c
EZ
1587 (push_it): Accept second argument POSITION, where pop_it should
1588 jump to continue iteration.
1589 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1590
fec2107c
EZ
1591 * keyboard.c (adjust_point_for_property): Adjust the call to
1592 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1593
1594 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1595 (bidi_init_it): Update prototypes.
1596 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1597 (compute_display_string_pos, compute_display_string_end):
1598 Declare prototypes.
fec2107c
EZ
1599 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1600 EMACS_INT.
fc6f18ce 1601
40087514 16022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1603
57f53182
PE
1604 Malloc failure behavior now depends on size of allocation.
1605 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1606 * lisp.h: Change signatures accordingly.
1607 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1608 All callers changed. (Bug#8762)
1609
1610 * gnutls.c: Use Emacs's memory allocators.
1611 Without this change, the gnutls library would invoke malloc etc.
1612 directly, which causes problems on non-SYNC_INPUT hosts, and which
1613 runs afoul of improving memory_full behavior. (Bug#8761)
1614 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1615 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1616 xfree instead of the default malloc, realloc, free.
1617 (Fgnutls_boot): No need to check for memory allocation failure,
1618 since xmalloc does that for us.
1619
ac32cd99 1620 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1621 * category.c (hash_get_category_set):
1622 * ccl.c (ccl_driver):
1623 * charset.c (Fdefine_charset_internal):
1624 * charset.h (struct charset.hash_index):
1625 * composite.c (get_composition_id, gstring_lookup_cache)
1626 (composition_gstring_put_cache):
1627 * composite.h (struct composition.hash_index):
1628 * dispextern.h (struct image.hash):
1629 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1630 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1631 (hashfn_equal, hashfn_user_defined, make_hash_table)
1632 (maybe_resize_hash_table, hash_lookup, hash_put)
1633 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1634 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1635 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1636 * image.c (make_image, search_image_cache, lookup_image)
1637 (xpm_put_color_table_h):
1638 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1639 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1640 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1641 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1642 * alloc.c (allocate_vectorlike):
1643 Check for overflow in vector size calculations.
1644 * ccl.c (ccl_driver):
1645 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1646 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1647 need to be updated by these changes.
40087514
PE
1648 * fns.c (make_hash_table, maybe_resize_hash_table):
1649 Check for integer overflow with large hash tables.
0de4bb68
PE
1650 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1651 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1652 (SXHASH_REDUCE): New macro.
1653 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1654 Use it instead of discarding useful hash info with large hash values.
1655 (sxhash_float): New function.
1656 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1657 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1658 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1659 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1660 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1661 Adjust signatures to match updated version of code.
1662 (consing_since_gc): Now EMACS_INT, since a single hash table can
1663 use more than INT_MAX bytes.
1664
698d32e2
DN
16652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1666
1667 Make it possible to build with GCC-4.6+ -O2 -flto.
1668
1669 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1670
fd6fa53f
SM
16712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1672
1673 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1674 Call minibuffer-inactive-mode.
1675
864db017
JB
16762011-05-31 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1679 Update dependencies.
1680
2ad0baf4
DN
16812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1682
1683 * data.c (init_data): Remove code for UTS, this system is not
1684 supported anymore.
1685
4fcc2638
DN
16862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1687
1688 Don't force ./temacs to start in terminal mode.
1689
1690 * frame.c (make_initial_frame): Initialize faces in all cases, not
1691 only when CANNOT_DUMP is defined.
1692 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1693
c56e0fd5
DN
16942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1695
1696 * dispnew.c (add_window_display_history): Use const for the string
1697 pointer. Remove declaration, not needed.
1698
333d54da 16992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1700
55d4c1b2 1701 Use 'inline', not 'INLINE'.
333d54da 1702 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1703 * alloc.c, fontset.c (INLINE): Remove.
1704 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1705 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1706 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1707 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1708 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1709
738db178
DN
17102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1711
1712 Make it possible to run ./temacs.
1713
1714 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1715 syms_of_callproc does the same thing. Remove test for
1716 "initialized", do it in the caller.
1717 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1718
620c53a6
SM
17192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1720
1721 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1722 (read_minibuf): Use get_minibuffer.
1723 (syms_of_minibuf): Use DEFSYM.
1724 (Qmetadata): New var.
1725 * data.c (Qbuffer): Don't make it static.
1726 (syms_of_data): Use DEFSYM.
1727
e003a292
PE
17282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1729
1730 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1731 (CCL_CODE_MIN): New macro.
1732
ed008a6d
PE
17332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1734
3687c2ef
PE
1735 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1736
ed008a6d
PE
1737 * eval.c (Qdebug): Now static.
1738 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1739 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1740 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1741
d66c4c7c
CY
17422011-05-29 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * image.c: Various fixes to ImageMagick code comments.
1745 (Fimagemagick_types): Doc fix.
1746
5fbc2025
PE
17472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1748
0196f88a
PE
1749 Minor fixes prompted by GCC 4.6.0 warnings.
1750
1751 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1752
5fbc2025
PE
1753 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1754 (x_clipboard_manager_save_all): Move extern decl to ...
1755 * xterm.h: ... here, so that it can be checked for consistency.
1756
1dd3c2d9
CY
17572011-05-29 Chong Yidong <cyd@stupidchicken.com>
1758
1759 * xselect.c (x_clipboard_manager_save_frame)
1760 (x_clipboard_manager_save_all): New functions.
1761 (Fx_clipboard_manager_save): Lisp function deleted.
1762
1763 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1764 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1765
1766 * xterm.h: Update prototype.
1767
5ba6571d
WX
17682011-05-28 William Xu <william.xwl@gmail.com>
1769
1770 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1771 exiting (Bug#8239).
1772
3eaff834
JM
17732011-05-28 Jim Meyering <meyering@redhat.com>
1774
e1900994 1775 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1776 * fns.c (to_uchar): Define.
1777 (crypto_hash_function): Use it to convert some newly-signed
1778 variables to unsigned, to avoid sign-extension bugs. For example,
1779 without this change, (md5 "truc") would evaluate to
1780 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1781 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1782 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1783
0f6990a7
PE
17842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1785
1786 Integer overflow fixes.
c8a9ca5a 1787
08686060
PE
1788 * dbusbind.c: Serial number integer overflow fixes.
1789 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1790 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1791 to hold a serial number that is too large for a fixnum.
1792 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1793 Check for serial numbers out of range. Decode any serial number
59568bf0 1794 that was so large that it became a float. (Bug#8722)
08686060 1795
2d1fc3c7
PE
1796 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1797 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1798 Use XFASTINT rather than XUINT when numbers are nonnegative.
1799 (xd_append_arg, Fdbus_method_return_internal):
1800 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1801 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1802 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1803 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1804 (Bug#8722)
2d1fc3c7 1805
c8a9ca5a
PE
1806 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1807
519e1d69
PE
1808 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1809
30569699
PE
1810 ccl: add integer overflow checks
1811 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1812 (IN_INT_RANGE): New macros.
1813 (ccl_driver): Use them to check for integer overflow when
1814 decoding a CCL program. Many of the new checks are whether XINT (x)
1815 fits in int; it doesn't always, on 64-bit hosts. The new version
1816 doesn't catch all possible integer overflows, but it's an
847044ea 1817 improvement. (Bug#8719)
30569699 1818
c11285dc
PE
1819 * alloc.c (make_event_array): Use XINT, not XUINT.
1820 There's no need for unsigned here.
1821
fdccd48e
PE
1822 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1823 This follows up to the 2011-05-06 change that substituted uintptr_t
1824 for EMACS_INT. This case wasn't caught back then.
1825
37910ab2
PE
1826 Rework Fformat to avoid integer overflow issues.
1827 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1828 now (part of C89). Include <verify.h>.
1829 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1830 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1831 (Fformat): Avoid the prepass trying to compute sizes; it was only
1832 approximate and thus did not catch overflow reliably. Instead, walk
1833 through the format just once, formatting and computing sizes as we go,
1834 checking for integer overflow at every step, and allocating a larger
1835 buffer as needed. Keep track separately whether the format is
1836 multibyte. Keep only the most-recently calculated precision, rather
1837 than them all. Record whether each argument has been converted to
1838 string. Use EMACS_INT, not int, for byte and char and arg counts.
1839 Support field widths and precisions larger than INT_MAX. Avoid
1840 sprintf's undefined behavior with conversion specifications such as %#d
1841 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1842 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1843 formatting out-of-range floating point numbers with int
9173deec 1844 formats. (Bug#8668)
37910ab2 1845
2e6578fb
PE
1846 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1847
0ae6bdee
PE
1848 * data.c: Avoid integer truncation in expressions involving floats.
1849 * data.c: Include <intprops.h>.
1850 (arith_driver): When there's an integer overflow in an expression
1851 involving floating point, convert the integers to floating point
1852 so that the resulting value does not suffer from catastrophic
1853 integer truncation. For example, on a 64-bit host (* 4
1854 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1855 Do not rely on undefined behavior after integer overflow.
1856
de883a70
PE
1857 merge count_size_as_multibyte, parse_str_to_multibyte
1858 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1859 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1860 Check for integer overflow.
1861 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1862 since it's now a duplicate of the other. This is more of
1863 a character than a buffer op, so better that it's in character.c.
1864 * fns.c, print.c: Adjust to above changes.
1865
2ff916cb
PE
18662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1867
1868 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1869
f1b54466
PE
18702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1871
fb1ac845
PE
1872 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1873 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1874 (x_clipboard_manager_save): Now static.
1875 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1876
f1b54466
PE
1877 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1878 (crypto_hash_function): Now static.
1879 Fix pointer signedness problems. Avoid unnecessary initializations.
1880
a9f737ee
CY
18812011-05-27 Chong Yidong <cyd@stupidchicken.com>
1882
1883 * termhooks.h (Vselection_alist): Make it terminal-local.
1884
1885 * terminal.c (create_terminal): Initialize it.
1886
1887 * xselect.c: Support for clipboard managers.
1888 (Vselection_alist): Move to termhooks.h as terminal-local var.
1889 (LOCAL_SELECTION): New macro.
1890 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1891 (symbol_to_x_atom): Remove gratuitous arg.
1892 (x_handle_selection_request, lisp_data_to_selection_data)
1893 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1894 (x_own_selection, x_get_local_selection, x_convert_selection):
1895 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1896 (some_frame_on_display): Delete unused function.
1897 (Fx_own_selection_internal, Fx_get_selection_internal)
1898 (Fx_disown_selection_internal, Fx_selection_owner_p)
1899 (Fx_selection_exists_p): New optional frame arg.
1900 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1901 (x_handle_selection_clear): Don't treat other terminals with the
1902 same keyboard specially. Use the terminal-local Vselection_alist.
1903 (x_clear_frame_selections): Use Frun_hook_with_args.
1904
1905 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1906
1907 * xterm.h: Add support for those atoms.
1908
e067f0c1
CY
19092011-05-26 Chong Yidong <cyd@stupidchicken.com>
1910
1911 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1912 (converted_selections, conversion_fail_tag): New global variables.
1913 (x_selection_request_lisp_error): Free the above.
1914 (x_get_local_selection): Remove unnecessary code.
1915 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1916 of converted selections stored in converted_selections.
1917 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1918 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1919 (x_convert_selection): New function.
1920 (x_handle_selection_event): Simplify.
1921 (x_get_foreign_selection): Don't ignore incoming requests while
1922 waiting for an answer; this will fail when we implement
1923 SAVE_TARGETS, and seems unnecessary anyway.
1924 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1925 (Vx_sent_selection_functions): Doc fix.
1926
0f4aebc0
LL
19272011-05-26 Leo Liu <sdl.web@gmail.com>
1928
1929 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1930
e61124cd
YM
19312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1932
1933 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1934
1935 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1936 for fringe update if it has periodic bitmap.
1937 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1938 and fringe_bitmap_periodic_p.
1939
1940 * fringe.c (get_fringe_bitmap_data): New function.
1941 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1942 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1943 row. Mark glyph row for fringe update if periodicity changed.
1944
1945 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1946 for fringe update unless it has periodic bitmap.
1947
f16d9837
KH
19482011-05-25 Kenichi Handa <handa@m17n.org>
1949
1950 * xdisp.c (get_next_display_element): Set correct it->face_id for
1951 a static composition.
1952
e1b90ef6
LL
19532011-05-24 Leo Liu <sdl.web@gmail.com>
1954
1955 * deps.mk (fns.o):
1956 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1957
1958 * fns.c (crypto_hash_function, Fsha1): New function.
1959 (Fmd5): Use crypto_hash_function.
1960 (syms_of_fns): Add Ssha1.
1961
7400048f
PE
19622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * gnutls.c: Remove unused macros.
1965 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1966 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1967 Remove macros that are defined and never used.
1968 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1969
abb71cf4
CY
19702011-05-22 Chong Yidong <cyd@stupidchicken.com>
1971
1972 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1973 (Fx_get_selection_internal): Minor cleanup.
1974 (Fx_own_selection_internal): Rename arguments for consistency with
1975 select.el.
1976
6307db39
PE
19772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1980
f3d4e0a4
CY
19812011-05-22 Chong Yidong <cyd@stupidchicken.com>
1982
1983 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1984
4d8ade89
YM
19852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1986
1987 * dispnew.c (scrolling_window): Don't exclude the case that the
1988 last enabled row in the desired matrix touches the bottom boundary.
1989
32078c8d
GM
19902011-05-21 Glenn Morris <rgm@gnu.org>
1991
1992 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1993 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1994 and add some more files.
32078c8d 1995
7285dc67
EZ
19962011-05-20 Eli Zaretskii <eliz@gnu.org>
1997
1998 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1999 report_file_error introduced by the change from 2011-05-07.
2000
89d1bd22
PE
20012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * systime.h (Time): Define only if emacs is defined.
2004 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2005 where the include path doesn't have X11/X.h by default. See
2006 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2007
e23640bb 20082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2009
2010 * composite.c (find_automatic_composition): Fix previous change.
2011
b9704ad9
GM
20122011-05-20 Glenn Morris <rgm@gnu.org>
2013
2014 * lisp.mk: New file, split from Makefile.in.
2015 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2016 (shortlisp): Remove.
2017 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2018
4a720484
GM
20192011-05-19 Glenn Morris <rgm@gnu.org>
2020
2021 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2022 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2023 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2024 (lisp): Set the order to that of loadup.el.
2025 (shortlisp): Make it a copy of $lisp.
2026 (SOME_MACHINE_LISP): Remove.
2027 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2028 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2029
a28d4396
KH
20302011-05-18 Kenichi Handa <handa@m17n.org>
2031
2032 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2033 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2034 (find_automatic_composition): Mostly rewrite for efficiency.
2035
a2b1fa8e
JB
20362011-05-18 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * makefile.w32-in: Update dependencies.
2039
8e1f5610
CS
20402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2041
2042 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2043 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2044
7025ee00 20452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2046
cdfa6eab
PE
2047 Fix some integer overflow issues, such as string length overflow.
2048
06d6db33
PE
2049 * insdel.c (count_size_as_multibyte): Check for string overflow.
2050
2b4560a8
PE
2051 * character.c (lisp_string_width): Check for string overflow.
2052 Use EMACS_INT, not int, for string indexes and lengths; in
2053 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2054 the resulting string length overflows an EMACS_INT; instead,
2055 report a string overflow if no precision given. When checking for
2056 precision exhaustion, use a check that cannot possibly have
2057 integer overflow. (Bug#8675)
2058 * character.h (lisp_string_width): Adjust to new signature.
2059
cb93f9be
PE
2060 * alloc.c (string_overflow): New function.
2061 (Fmake_string): Use it. This doesn't change behavior, but saves
2062 a few bytes and will simplify future changes.
2063 * character.c (string_escape_byte8): Likewise.
2064 * lisp.h (string_overflow): New decl.
2065
1a1f3366
PE
2066 Fixups, following up to the user-interface timestamp change.
2067 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2068 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2069 * msdos.c (mouse_get_pos): Likewise.
2070 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2071 * w32gui.h (Time): Define by including "systime.h" rather than by
2072 declaring it ourselves. (Bug#8664)
2073
d4e3e4d3
PE
2074 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2075 * image.c (clear_image_cache): Likewise.
2076
f6a24d19
PE
2077 * term.c (term_mouse_position): Don't assume time_t wraparound.
2078
08dc5ae6
PE
2079 Be more systematic about user-interface timestamps.
2080 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2081 and sometimes 'EMACS_UINT', to represent these timestamps.
2082 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2083 This makes the code easier to follow, and makes it easier to catch
2084 integer overflow bugs such as Bug#8664.
2085 * frame.c (Fmouse_position, Fmouse_pixel_position):
2086 Use Time, not unsigned long, for user-interface timestamps.
2087 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2088 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2089 * keyboard.h (last_event_timestamp): Likewise.
2090 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2091 * menu.h (xmenu_show): Likewise.
2092 * term.c (term_mouse_position): Likewise.
2093 * termhooks.h (struct input_event.timestamp): Likewise.
2094 (struct terminal.mouse_position_hook): Likewise.
2095 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2096 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2097 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2098 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2099 what it was before.
2100 * menu.h, termhooks.h: Include "systime.h", for Time.
2101
8e55734a
PE
2102 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2103 Don't assume that the difference between two unsigned long values
2104 can fit into an integer. At this point, we know button_down_time
2105 <= event->timestamp, so the difference must be nonnegative, so
2106 there's no need to cast the result if double-click-time is
2107 nonnegative, as it should be; check that it's nonnegative, just in
2108 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2109 apart (about 25 days). (Bug#8664)
8e55734a 2110
841f1b75 2111 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2112 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2113
3e26f69c
PE
2114 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2115 that always fit in int. Use a sentinel instead of a counter, to
2116 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2117 * frame.h (struct frame): Use int for menu_bar_items_used
2118 instead of EMACS_INT, since it always fits in int.
3e26f69c 2119
5cc152c0
PE
2120 * menu.c (grow_menu_items): Check for int overflow.
2121
d89eb65e
PE
2122 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2123
5235bd3e
PE
2124 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2125 Before, the code was not consistent. These values cannot exceed
2126 2**31 - 1 so there's no need to make them unsigned.
2127 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2128 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2129 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2130 as modifiers.
2131 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2132
bc827e23
PE
2133 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2134 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2135 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2136 presumably because the widths might not match.
2137
78eb494e
PE
2138 * window.c (size_window): Avoid needless test at loop start.
2139
04f2d78b
CB
21402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2141
2142 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2143
d2fc7e3d 21442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2145
2146 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2147
d2fc7e3d 21482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2149
2150 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2151 `width' to `bar_area_x' and `bar_area_width', respectively.
2152 (x_scroll_run): Take account of fringe background extension.
2153
04f2d78b
CB
2154 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2155 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2156 `bar_area_width', respectively.
2157 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2158 background extension.
2159
79b70037
GM
21602011-05-10 Jim Meyering <meyering@redhat.com>
2161
2162 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2163
2f142cc5
JB
21642011-05-10 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * image.c (Finit_image_library): Return t for built-in image types,
2167 like pbm and xbm. (Bug#8640)
2168
57679c86
AS
21692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2170
2171 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2172
888c9e86
EZ
21732011-05-07 Eli Zaretskii <eliz@gnu.org>
2174
b0512a1d
EZ
2175 * w32console.c (Fset_screen_color): Doc fix.
2176 (Fget_screen_color): New function.
2177 (syms_of_ntterm): Defsubr it.
2178
7285dc67
EZ
2179 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2180 unlink the temporary file if Fcall_process didn't create it in the
2181 first place.
2182 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2183 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2184 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2185 cue to call_process_cleanup not to close that handle.
2186
4d3fcc8e
BK
21872011-05-07 Ben Key <bkey76@gmail.com>
2188
2189 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2190 one of two shell specific rules, either bootstrap-temacs-CMD or
2191 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2192 to the previous implementation of the bootstrap-temacs rule.
2193 The bootstrap-temacs-CMD rule is similar to the previous
2194 implementation of the bootstrap-temacs rule except that it
2195 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2196 variable.
2197
2198 These changes, along with some changes to nt/configure.bat,
2199 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2200 earlier fix to add support for --cflags and --ldflags options
2201 that include quotes so that it works whether make uses cmd or
2202 sh as the shell.
2203
b4289b64
MA
22042011-05-06 Michael Albinus <michael.albinus@gmx.de>
2205
2206 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2207 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2208 is a constant.
2209 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2210 a string. Handle both cases.
2211 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2212 (Fdbus_register_method): Use Qinvalid_function.
2213
af4c0e28
JB
22142011-05-06 Juanma Barranquero <lekktu@gmail.com>
2215
2216 * makefile.w32-in: Update dependencies.
2217 (LISP_H): Add inttypes.h and stdin.h.
2218 (PROCESS_H): Add unistd.h.
2219
c51453d9
EZ
22202011-05-06 Eli Zaretskii <eliz@gnu.org>
2221
2222 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2223 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2224
8ff0ac3c 22252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2226
4c4b566b
PE
2227 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2228
aab2b9b5
PE
2229 * term.c (vfatal): Remove stray call to va_end.
2230 It's not needed and the C Standard doesn't allow it here anyway.
2231
c378da0b
PE
2232 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2233 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2234
288b08c7
PE
2235 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2236 bytes.
2237
e3601888
PE
2238 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2239
db6c0e74
PE
2240 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2241
dd5963ea
PE
2242 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2243
88c9450f
PE
2244 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2245
2f9442b8
PE
2246 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2247
c032b5f8
PE
2248 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2249 * charset.c (Fdefine_charset_internal): Don't initialize
2250 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2251 32-bit int (Bug#8600).
a108c10b
PE
2252
2253 * lread.c (read_integer): Be more consistent with string-to-number.
2254 Use string_to_number to do the actual conversion; this avoids
2255 rounding errors and fixes some other screwups. Without this fix,
2256 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2257 (digit_to_number): Move earlier, for benefit of read_integer.
2258 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2259 not a digit in any supported base. (Bug#8602)
a108c10b 2260
ad5f9eea
PE
2261 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2262
aec1708a
PE
2263 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2264 to match comment at start of function. This also removes a
2265 GCC warning about overflow in a 32+64-bit port.
2266
47be4ab5
PE
2267 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2268
371cac43
PE
2269 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2270 Reported by Stefan Monnier in
2271 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2272 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2273 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2274
d01a7826
PE
2275 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2276 (EMACS_UINTPTR): Likewise, with uintptr_t.
2277
7fd47d5c
PE
2278 * lisp.h: Prefer 64-bit EMACS_INT if available.
2279 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2280 on 32-bit hosts that have 64-bit int, so that they can access
2281 large files.
122b0c86
PE
2282 However, temporarily disable this change unless the temporary
2283 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2284
8727937b
PE
2285 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2286
8ac068ac
PE
2287 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2288 This removes an assumption that EMACS_INT and long are the same
2289 width as pointers. The assumption is true for Emacs porting targets
2290 now, but we want to make other targets possible.
2291 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2292 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2293 In the rest of the code, change types of integers that hold casted
2294 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2295 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2296 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2297 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2298 No need to cast type when ORing.
2299 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2300 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2301 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2302 assume EMACS_INT is the same width as char *.
2303 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2304 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2305 Remove no-longer-needed casts.
2306 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2307 (xg_tool_bar_help_callback, xg_make_tool_item):
2308 Use EMACS_INTPTR to hold an integer
2309 that will be cast to void *; this can avoid a GCC warning
2310 if EMACS_INT is not the same width as void *.
2311 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2312 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2313 (current_message_1, set_message_1):
2314 Use a local to convert to proper width without a cast.
2315 * xmenu.c (dialog_selection_callback): Likewise.
2316
ede49d71
PE
2317 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2318 Also, don't assume VALBITS / RAND_BITS is less than 5,
2319 and don't rely on undefined behavior when shifting a 1 left into
2320 the sign bit.
2321 * lisp.h (get_random): Change signature to match.
2322
2f30ecd0
PE
2323 * lread.c (hash_string): Use size_t, not int, for hash computation.
2324 Normally we prefer signed values; but hashing is special, because
2325 it's better to use unsigned division on hash table sizes so that
2326 the remainder is nonnegative. Also, size_t is the natural width
2327 for hashing into memory. The previous code used 'int', which doesn't
2328 retain enough info to hash well into very large tables.
2329 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2330
2a866e7b
PE
2331 * dbusbind.c: Don't possibly lose pointer info when converting.
2332 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2333 Use XPNTR rather than XHASH, so that the high-order bits of
2334 the pointer aren't lost when converting through void *.
2335
51639eac
PE
2336 * eval.c (Fautoload): Don't double-shift a pointer.
2337
92394119
PE
2338 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2339
dbdb9a7c
JB
23402011-05-06 Juanma Barranquero <lekktu@gmail.com>
2341
2342 * gnutls.c (DEF_GNUTLS_FN):
2343 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2344
db7a0b4f
AS
23452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2346
2347 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2348 marker. (Bug#8610)
2349
f7ff1b0f 23502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2351
2352 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2353 New version that can reserve upto 2GB of heap space.
2354
f7ff1b0f 23552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2356
2357 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2358
639c109b
TZ
23592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2360
2361 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2362 `gnutls_certificate_set_x509_key_file'.
2363
d2127135
JB
23642011-05-05 Juanma Barranquero <lekktu@gmail.com>
2365
2366 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2367 Update dependencies.
2368
e968f4f3
JB
23692011-05-04 Juanma Barranquero <lekktu@gmail.com>
2370
2371 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2372 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2373 Remove unused parameter `fildes'.
2374 * process.c (read_process_output, send_process): Don't pass it.
2375
84d358f0
JB
23762011-05-04 Juanma Barranquero <lekktu@gmail.com>
2377
2378 Fix previous change: the library cache is defined in w32.c.
2379 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2380 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2381
0898ca10
JB
23822011-05-04 Juanma Barranquero <lekktu@gmail.com>
2383
2384 Implement dynamic loading of GnuTLS on Windows.
2385
2386 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2387 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2388 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2389 Declare.
2390
2391 * gnutls.c (Qgnutls_dll): Define.
2392 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2393 (gnutls_*): Declare function pointers.
2394 (init_gnutls_functions): New function to initialize function pointers.
2395 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2396 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2397 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2398 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2399 (emacs_gnutls_write, emacs_gnutls_read)
2400 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2401 (Fgnutls_available_p): New function.
2402 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2403 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2404 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2405
2406 * image.c: Include w32.h.
2407 (Vimage_type_cache): Delete.
2408 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2409 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2410 (w32_delayed_load): Move to w32.c.
2411
2412 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2413
2414 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2415 (w32_delayed_load): Move from image.c. When loading a library, record
2416 its filename in the :loaded-from property of the library id.
2417 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2418 Initialize and staticpro them.
2419 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2420
2421 * process.c: Include lisp.h before w32.h, not after.
2422 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2423 instead of gnutls_record_check_pending.
2424
2425 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2426
ff4de4aa
TZ
24272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2428
2429 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2430 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2431 as passed in.
2432
abe95abb
JD
24332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2434
2435 * xterm.c (x_set_frame_alpha): Do not set property on anything
2436 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2437
e16e55d4
JB
24382011-05-02 Juanma Barranquero <lekktu@gmail.com>
2439
2440 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2441
bafcf6a5
JB
24422011-05-02 Juanma Barranquero <lekktu@gmail.com>
2443
2444 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2445 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2446 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2447 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2448 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2449 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2450 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2451 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2452 (Qgnutls_bootprop_callbacks_verify): Make static.
2453
e7a6747f
AS
24542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2455
19ed11ba
AS
2456 * callproc.c: Indentation fixup.
2457
e7a6747f 2458 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2459 (wait_for_termination, interruptible_wait_for_termination):
2460 Move after wait_for_termination_1.
e7a6747f 2461
1ef14cb4
LMI
24622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2463
2464 * sysdep.c (interruptible_wait_for_termination): New function
2465 which is like wait_for_termination, but allows keyboard
2466 interruptions.
2467
2468 * callproc.c (Fcall_process): Add (:file "file") as an option for
2469 the STDOUT buffer.
2470 (Fcall_process_region): Ditto.
2471
330d880c
EZ
24722011-04-30 Eli Zaretskii <eliz@gnu.org>
2473
8db90b73
EZ
2474 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2475 rather than `XVECTOR (FOO)->size'.
2476
330d880c
EZ
2477 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2478 inttypes.h, as a gnulib replacement is used if it not available in
2479 system headers.
2480
15cbd324
EZ
24812011-04-21 Eli Zaretskii <eliz@gnu.org>
2482
2483 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2484 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2485 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2486
2487 * coding.c (coding_alloc_by_realloc): Error out if destination
2488 will grow beyond MOST_POSITIVE_FIXNUM.
2489 (decode_coding_emacs_mule): Abort if there isn't enough place in
2490 charbuf for the composition carryover bytes. Reserve an extra
2491 space for up to 2 characters produced in a loop.
2492 (decode_coding_iso_2022): Abort if there isn't enough place in
2493 charbuf for the composition carryover bytes.
2494
24952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2496
ae940cca
EZ
2497 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2498 aborting when %lld or %lll format is passed.
2499 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2500 %llo or %llx format is passed. (Bug#8545)
2501
03ab8921
EZ
2502 * window.c (window_scroll_line_based): Use a marker instead of
2503 simple variables to record original value of point. (Bug#7952)
2504
afda1437
EZ
2505 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2506 produced by %s or %c overflows available buffer space. (Bug#8545)
2507
f76dee0c
PE
25082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2509
2510 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2511 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2512
fdc5744d
JB
25132011-04-28 Juanma Barranquero <lekktu@gmail.com>
2514
2515 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2516
638f053a
JB
25172011-04-28 Juanma Barranquero <lekktu@gmail.com>
2518
2519 * keyboard.c (Qdelayed_warnings_hook): Define.
2520 (command_loop_1): Run `delayed-warnings-hook'
2521 if Vdelayed_warnings_list is non-nil.
2522 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2523 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2524
d178f871
EZ
25252011-04-28 Eli Zaretskii <eliz@gnu.org>
2526
2527 * doprnt.c (doprnt): Don't return value smaller than the buffer
2528 size if the message was truncated. (Bug#8545).
2529
b124fd93
JB
25302011-04-28 Juanma Barranquero <lekktu@gmail.com>
2531
2532 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2533 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2534
e810457d
PE
25352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2536
2537 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2538
ea51cceb
JB
25392011-04-27 Juanma Barranquero <lekktu@gmail.com>
2540
2541 * makefile.w32-in: Update dependencies.
2542
94dcfacf
EZ
25432011-04-27 Eli Zaretskii <eliz@gnu.org>
2544
2545 Improve `doprnt' and its usage. (Bug#8545)
2546 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2547 `format_end'. Remove support for %l as a conversion specifier.
2548 Don't use xrealloc. Improve diagnostics when the %l size modifier
2549 is used. Update the commentary.
2550
2551 * eval.c (verror): Simplify calculation of size_t.
2552
2553 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2554 messages.
2555
f61f41d7
PE
25562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2557
2558 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2559 change.
2560
96fb4434
PE
25612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2564 This makes this file independent of the recent pseudovector change.
2565
671875da 25662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2567
69e9b5a3
PE
2568 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2569
b5f869a7 2570 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2571 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2572 Remove unused local.
c8926152 2573 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2574
841a1577 2575 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2576 GCC 4.6.0 optimizes based on type-based alias analysis.
2577 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2578 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2579 != &v->size, and therefore "v->size = 1; b->size = 2; return
2580 v->size;" must therefore return 1. This assumption is incorrect
2581 for Emacs, since it type-puns struct Lisp_Vector * with many other
2582 types. To fix this problem, this patch adds a new type struct
f904488f 2583 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2584 and pseudovectors, and helps optimizing compilers not get fooled
2585 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2586 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2587 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2588 the size member.
eab3844f
PE
2589 (XSETPVECTYPE): Rewrite in terms of new macro.
2590 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2591 This is a bit clearer, and further avoids the possibility of
2592 undesirable aliasing.
2593 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2594 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2595 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2596 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2597 (ASIZE): Now uses header.size rather than size.
2598 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2599 to avoid the hassle of writing XVECTOR (foo)->header.size.
2600 (struct vectorlike_header): New type.
eab3844f
PE
2601 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2602 object, to help avoid aliasing.
2603 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2604 (SUBRP): Likewise, since Lisp_Subr is a special case.
2605 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2606 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2607 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2608 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2609 changed to be "header.size" and "header.next".
2610 * buffer.h (struct buffer): Likewise.
2611 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2612 * frame.h (struct frame): Likewise.
2613 * process.h (struct Lisp_Process): Likewise.
2614 * termhooks.h (struct terminal): Likewise.
2615 * window.c (struct save_window_data, struct saved_window): Likewise.
2616 * window.h (struct window): Likewise.
2617 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2618 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2619 * buffer.c (init_buffer_once): Likewise.
2620 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2621 special case.
2622 * process.c (Fformat_network_address): Use local var for size,
2623 for brevity.
2624
0df1eac5
PE
2625 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2626
847ab9d1 2627 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2628 * data.c (atof): Remove decl; no longer used or needed.
2629 (digit_to_number): Move to lread.c.
2630 (Fstring_to_number): Use new string_to_number function, to be
2631 consistent with how the Lisp reader treats infinities and NaNs.
2632 Do not assume that floating-point numbers represent EMACS_INT
2633 without losing information; this is not true on most 64-bit hosts.
2634 Avoid double-rounding errors, by insisting on integers when
2635 parsing non-base-10 numbers, as the documentation specifies.
2636 * lisp.h (string_to_number): New decl, replacing ...
2637 (isfloat_string): Remove.
bc0a5c13 2638 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2639 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2640 appears to have been a coding error. Similarly, do not accept
2641 strings like +-1e0 as floating point numbers. Do not report
2642 overflow for integer overflows unless the base is not 10 which
2643 means we have no simple and reliable way to continue.
2644 Break out the floating-point parsing into a new
2645 function string_to_number, so that Fstring_to_number parses
2646 floating point numbers consistently with the Lisp reader.
04f2d78b 2647 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2648 (E_CHAR, EXP_INT): Remove, replacing with ...
2649 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2650 (string_to_number): New function, replacing isfloat_string.
2651 This function checks for valid syntax and produces the resulting
2652 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2653 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2654 so that overflow for non-base-10 numbers is reported only when
2655 there's no portable and simple way to convert to floating point.
452f4150 2656
67769ffc
PE
2657 * textprop.c (set_text_properties_1): Rewrite for clarity,
2658 and to avoid GCC warning about integer overflow.
2659
c20db43f
PE
2660 * intervals.h (struct interval): Use EMACS_INT for members
2661 where EMACS_UINT might cause problems. See
2662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2663 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2664 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2665 All uses changed.
37aa2f85
PE
2666 (offset_intervals): Tell GCC not to worry about length overflow
2667 when negating a negative length.
c20db43f 2668
2538aa2f
PE
2669 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2670 (overrun_check_free): Likewise.
2671
f2d3008d
PE
2672 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2673 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2674 word size.
2675
ec8df744
PE
2676 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2677 (gnutls_make_error): Rename local to avoid shadowing.
2678 (gnutls_emacs_global_deinit): ifdef out; not used.
2679 (Fgnutls_boot): Use const for pointer to readonly storage.
2680 Comment out unused local. Fix pointer signedness problems.
2681
640ee02d
PE
2682 * lread.c (openp): Don't stuff size_t into an 'int'.
2683 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2684 about possible signed overflow.
2685
6048fb2a
PE
2686 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2687 (GDK_KEY_g): Don't define if already defined.
2688 (xg_prepare_tooltip): Avoid pointer signedness problem.
2689 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2690
fa3c87e1
PE
2691 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2692 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2693
2172544b
PE
2694 * xfns.c (Fx_window_property): Simplify a bit,
2695 to make a bit faster and to avoid GCC 4.6.0 warning.
2696 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2697
9b821a21
PE
2698 * fns.c (internal_equal): Don't assume size_t fits in int.
2699
3c616cfa
PE
2700 * alloc.c (compact_small_strings): Tighten assertion a little.
2701
c2982e87
PE
2702 Replace pEd with more-general pI, and fix some printf arg casts.
2703 * lisp.h (pI): New macro, generalizing old pEd macro to other
2704 conversion specifiers. For example, use "...%"pI"d..." rather
2705 than "...%"pEd"...".
2706 (pEd): Remove. All uses replaced with similar uses of pI.
2707 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2708 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2709 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2710 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2711 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2712 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2713 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2714 64-bit hosts.
2715 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2716 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2717 * print.c (safe_debug_print, print_object): Likewise.
2718 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2719 to int.
6f04d126
PE
2720 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2721 avoiding the 0 flag, which is not portable.
c2982e87
PE
2722 * process.c (Fmake_network_process): Use pI to avoid cast.
2723 * region-cache.c (pp_cache): Likewise.
2724 * xdisp.c (decode_mode_spec): Likewise.
2725 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2726 behavior on 64-bit hosts with printf arg.
6f04d126 2727 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2728 (x_stop_queuing_selection_requests): Likewise.
2729 (x_get_window_property): Don't truncate byte count to an 'int'
2730 when tracing.
0b432f21 2731
5e073ec7
PE
2732 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2733 here, since it parses constructs like leading '-' and spaces,
2734 which are not wanted; and it overflows with large numbers.
2735 Instead, simply match F[0-9]+, which is what is wanted anyway.
2736
36372bf9
PE
2737 * alloc.c: Remove unportable assumptions about struct layout.
2738 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2739 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2740 (allocate_vectorlike, make_pure_vector): Use the new macros,
2741 plus offsetof, to remove unportable assumptions about struct layout.
2742 These assumptions hold on all porting targets that I know of, but
2743 they are not guaranteed, they're easy to remove, and removing them
2744 makes further changes easier.
2745
0b432f21
PE
2746 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2747 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2748 (string_overrun_cookie): Now const. Use initializers that
2749 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2750 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2751 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2752 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2753 multiple of sizeof (EMACS_INT); it need not be, if
2754 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2755 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2756
895009e1
JB
27572011-04-26 Juanma Barranquero <lekktu@gmail.com>
2758
2759 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2760
6a7a1b0b
TZ
27612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2762
2763 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2764 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2765 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2766
841a1577 27672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2768
2769 * lisp.h (Qdebug): List symbol.
895009e1 2770 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2771 * keyboard.c (debug-on-event): New variable.
2772 (handle_user_signal): Break into debugger when debug-on-event
2773 matches the current signal symbol.
2774
f2d3ba6f
DN
27752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2776
2777 * alloc.c (check_sblock, check_string_bytes)
2778 (check_string_free_list): Convert to standard C.
2779
42ce4c63
TZ
27802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2781
2782 * w32.c (emacs_gnutls_push): Fix typo.
2783
825cd63c
EZ
27842011-04-25 Eli Zaretskii <eliz@gnu.org>
2785
fb11d64d
EZ
2786 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2787 "cast to pointer from integer of different size".
2788
825cd63c
EZ
2789 Improve doprnt and its use in verror. (Bug#8545)
2790 * doprnt.c (doprnt): Document the set of format control sequences
2791 supported by the function. Use SAFE_ALLOCA instead of always
2792 using `alloca'.
2793
2794 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2795 is one byte too soon. Don't use xrealloc; instead xfree and
2796 xmalloc anew.
2797
e061a11b
TZ
27982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2799
2800 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2801 callbacks stage.
2802
2803 * gnutls.c: Renamed global_initialized to
2804 gnutls_global_initialized. Added internals for the
2805 :verify-hostname-error, :verify-error, and :verify-flags
2806 parameters of `gnutls-boot' and documented those parameters in the
2807 docstring. Start callback support.
9173deec
JB
2808 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2809 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2810 on error. Return error code.
e061a11b
TZ
2811 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2812 (emacs_gnutls_read): Likewise.
2813 (Fgnutls_boot): Return handshake error code.
2814 (emacs_gnutls_handle_error): New function.
2815 (wsaerror_to_errno): Likewise.
2816
2817 * w32.h (emacs_gnutls_pull): Add prototype.
2818 (emacs_gnutls_push): Likewise.
2819
2820 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2821 (emacs_gnutls_push): Likewise.
2822
28232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2824
2825 * process.c (wait_reading_process_output): Check if GnuTLS
2826 buffered some data internally if no FDs are set for TLS
2827 connections.
2828
2829 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2830 (LIBS): Link to USER_LIBS.
2831 ($(BLD)/gnutls.$(0)): New target.
2832
fa6996bc
EZ
28332011-04-24 Eli Zaretskii <eliz@gnu.org>
2834
eb35682e
EZ
2835 * xdisp.c (handle_single_display_spec): Rename the
2836 display_replaced_before_p argument into display_replaced_p, to
2837 make it consistent with the commentary. Fix typos in the
2838 commentary.
2839
e2ad650c
EZ
2840 * textprop.c (syms_of_textprop): Remove dead code.
2841 (copy_text_properties): Delete obsolete commentary about an
2842 interface that was deleted long ago. Fix typos in the description
2843 of arguments.
2844
1b2de274
EZ
2845 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2846 to changes in oldXMenu/XMenu.h from 2011-04-16.
2847 <menu_help_message, prev_menu_help_message>: Constify.
2848 (IT_menu_make_room): menu->help_text is now `const char **';
2849 adjust.
2850
2851 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2852 to changes in oldXMenu/XMenu.h from 2011-04-16.
2853 (struct XMenu): Declare `help_text' `const char **'.
2854
2855 * xfaces.c <Qunspecified>: Make extern again.
2856
2857 * syntax.c: Include sys/types.h before including regex.h, as
2858 required by Posix.
2859
762b15be
EZ
2860 * doc.c (get_doc_string): Improve the format passed to `error'.
2861
2862 * doprnt.c (doprnt): Improve commentary.
2863
2864 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2865
2866 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2867 them with etags.
2868
f1052e5d
EZ
2869 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2870 changes in globals.h immediately force recompilation.
762b15be
EZ
2871 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2872 $(CURDIR)/s/ms-w32.h.
2873 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2874
fa6996bc
EZ
2875 * character.c (Fchar_direction): Function deleted.
2876 (syms_of_character): Don't defsubr it.
2877 <char-direction-table>: Deleted.
2878
e6c3da20
EZ
28792011-04-23 Eli Zaretskii <eliz@gnu.org>
2880
2881 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2882 * doprnt.c: Include limits.h.
2883 (SIZE_MAX): New macro.
04f2d78b
CB
2884 (doprnt): Return a size_t value. 2nd arg is now size_t.
2885 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2886 Improve overflow protection. Support `l' modifier for integer
2887 conversions. Support %l conversion. Don't assume an EMACS_INT
2888 argument for integer conversions and for %c.
2889
2890 * lisp.h (doprnt): Restore prototype.
2891
2892 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2893 $(SRC)/character.h.
2894
2895 * Makefile.in (base_obj): Add back doprnt.o.
2896
2897 * deps.mk (doprnt.o): Add back prerequisites.
2898 (callint.o): Depend on character.h.
2899
2900 * eval.c (internal_lisp_condition_case): Include the handler
2901 representation in the error message.
2902 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2903 when breaking from the loop.
2904
2905 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2906
2907 * callint.c (Fcall_interactively): When displaying error message
2908 about invalid control letter, pass the character's codepoint, not
2909 a pointer to its multibyte form. Improve display of the character
2910 in octal and display also its hex code.
2911
2912 * character.c (char_string): Use %x to display the (unsigned)
2913 codepoint of an invalid character, to avoid displaying a bogus
2914 negative value.
2915
2916 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2917 `error', not SYMBOL_NAME itself.
2918
2919 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2920 character arguments to `error'.
2921
2922 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2923 to `error' in error message about FINAL_CHAR argument. Make sure
2924 FINAL_CHAR is a character, and use %c when it is passed as
2925 argument to `error'.
2926
4ffd0d6b 29272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2928
2929 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2930
2931 * w32.c: Include <time.h>.
2932 (sys_localtime): New function.
2933
4ffd0d6b 29342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2935
2936 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2937
4ffd0d6b 2938 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2939
4ffd0d6b 29402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2941
4ffd0d6b
GM
2942 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2943 zombies (Bug#8467).
aac0c6e3 2944
04c56954
EZ
29452011-04-19 Eli Zaretskii <eliz@gnu.org>
2946
2947 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2948 gl_state.e_property when gl_state.object is Qt.
2949
2950 * insdel.c (make_gap_larger): Remove limitation of buffer size
2951 to <= INT_MAX.
2952
16a43933
CY
29532011-04-18 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * xdisp.c (lookup_glyphless_char_display)
2956 (produce_glyphless_glyph): Handle cons cell entry in
2957 glyphless-char-display.
2958 (Vglyphless_char_display): Document it.
2959
2960 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2961 glyphless-char-display.
2962
4581706e
CY
29632011-04-17 Chong Yidong <cyd@stupidchicken.com>
2964
2965 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2966
2967 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2968
2969 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2970 definition for no-X builds.
2971
4887c6e2 29722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2973
fd35b6f9
PE
2974 Static checks with GCC 4.6.0 and non-default toolkits.
2975
5c1ccb01
PE
2976 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2977
006c5daa
PE
2978 * process.c (keyboard_bit_set): Define only if SIGIO.
2979 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2980 (send_process): Repair possible setjmp clobbering.
2981
efc736d3
PE
2982 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2983
4e2fe2e6
PE
2984 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2985
f97334a2
PE
2986 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2987
4e75f29d
PE
2988 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2989 Define only if needed.
2990
90efadd1
PE
2991 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2992 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2993 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2994
3c647824
PE
2995 * dispextern.h (struct redisplay_interface): Rename param
2996 to avoid shadowing.
e264f262 2997 * termhooks.h (struct terminal): Likewise.
761383f4 2998 * xterm.c (xembed_send_message): Likewise.
3c647824 2999
b58c5c4a
PE
3000 * insdel.c (make_gap_smaller): Define only if
3001 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3002
cad59032
PE
3003 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3004 it.
3005
c339dc2e
PE
3006 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3007 so that we aren't warned about unused symbols.
3008
91a3e27b
PE
3009 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3010
399c71d3 3011 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3012
8ffc96f5
PE
3013 * xfns.c (x_real_positions): Mark locals as initialized.
3014
eef9bc79
PE
3015 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3016
098db9dd
PE
3017 * xterm.c: Fix problems found by static analysis with other toolkits.
3018 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3019 (x_dispatch_event): Declare static if USE_GTK, and
3020 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3021 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3022 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3023 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3024 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3025
eb18f6cc
PE
3026 * xmenu.c (menu_help_callback): Pointer type fixes.
3027 Use const pointers when pointing at readonly data. Avoid pointer
3028 signedness clashes.
3029 (FALSE): Remove unused macro.
3030 (update_frame_menubar): Remove unused decl.
3031
1fe72bf8
PE
3032 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3033
60d9e1db
PE
3034 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3035 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3036 (single_menu_item): Rename local to avoid shadowing.
3037
39261c26
PE
3038 * keyboard.c (make_lispy_event): Remove unused local var.
3039
018c5e19
PE
3040 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3041 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3042
63d2b86e
PE
3043 * bitmaps: Change bitmaps from unsigned char back to the X11
3044 compatible char. Avoid the old compiler warnings about
3045 out-of-range initializers by using, for example, '\xab' rather
3046 than 0xab.
3047
aefd87e1
PE
3048 * xgselect.c (xgselect_initialize): Check vs interface
3049 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3050
bf501fb9
PE
3051 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3052
e9829fdf
PE
3053 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3054 to read-only memory.
3055
1086c095
PE
3056 * fns.c (vector): Remove; this old hack is no longer needed.
3057
2baccd04 3058 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3059 Remove unused var.
dde42981 3060 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3061
72391843 3062 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3063
436c16df 3064 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3065 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3066 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3067
92bb796d 3068 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3069 (x_term_init): Remove local to avoid shadowing.
92bb796d 3070
764430a3 3071 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3072
3073 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3074 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3075
d1dfb56c
EZ
30762011-04-16 Eli Zaretskii <eliz@gnu.org>
3077
c4354cb4
EZ
3078 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3079
d1dfb56c
EZ
3080 Fix regex.c, syntax.c and friends for buffers > 2GB.
3081 * syntax.h (struct gl_state_s): Declare character position members
3082 EMACS_INT.
3083
3084 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3085
04f2d78b
CB
3086 * textprop.c (verify_interval_modification, interval_of):
3087 Declare arguments EMACS_INT.
d1dfb56c
EZ
3088
3089 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3090 EMACS_INT.
3091
3092 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3093
3094 * indent.c (Fvertical_motion): Local variable it_start is now
3095 EMACS_INT.
3096
3097 * regex.c (re_match, re_match_2, re_match_2_internal)
3098 (bcmp_translate, regcomp, regexec, print_double_string)
3099 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3100 (re_compile_pattern, re_exec): Declare arguments and local
3101 variables `size_t' and `ssize_t' and return values `regoff_t', as
3102 appropriate.
3103 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3104 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3105 <compile_stack_type>: `size' and `avail' are now `size_t'.
3106
3107 * regex.h <regoff_t>: Use ssize_t, not int.
3108 (re_search, re_search_2, re_match, re_match_2): Arguments that
3109 specify buffer/string position and length are now ssize_t and
3110 size_t. Return type is regoff_t.
3111
613052cd
BK
31122011-04-16 Ben Key <bkey76@gmail.com>
3113
3114 * nsfont.m: Fixed bugs in ns_get_family and
3115 ns_descriptor_to_entity that were caused by using free to
3116 deallocate memory blocks that were allocated by xmalloc (via
3117 xstrdup). This caused Emacs to crash when compiled with
3118 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3119 --enable-checking=xmallocoverrun). xfree is now used to
3120 deallocate these memory blocks.
3121
4170f62f 31222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3123
71b41406
PE
3124 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3125
9587a89d
PE
3126 emacs_write: Accept and return EMACS_INT for sizes.
3127 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3128 et seq.
3129 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3130 Accept and return EMACS_INT.
3131 (emacs_gnutls_write): Return the number of bytes written on
3132 partial writes.
3133 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3134 (emacs_read, emacs_write): Remove check for negative size, as the
3135 Emacs source code has been audited now.
9587a89d
PE
3136 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3137 (emacs_read, emacs_write): Use it.
273a5f82
PE
3138 * process.c (send_process): Adjust to the new signatures of
3139 emacs_write and emacs_gnutls_write. Do not attempt to store
3140 a byte offset into an 'int'; it might overflow.
9587a89d 3141 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3142
3e047f51
PE
3143 * sound.c: Don't assume sizes fit in 'int'.
3144 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3145 Return EMACS_INT, not int.
3e047f51 3146 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3147 Accept EMACS_INT, not int.
3148 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3149 record read return values.
3150
cc39a9db
BK
31512011-04-15 Ben Key <bkey76@gmail.com>
3152
c9d0ec6d
JB
3153 * keyboard.c (Qundefined): Don't declare static since it is used
3154 in nsfns.m.
3155 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3156 static since they are used in nsfont.m.
cc39a9db 3157
6c60eb9f
SM
31582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3159
3160 * process.c (Qprocessp): Don't declare static.
3161 * lisp.h (Qprocessp): Declare again.
3162
7990b61a
JB
31632011-04-15 Juanma Barranquero <lekktu@gmail.com>
3164
3165 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3166
5d4cb038
PE
31672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3168
8bd7b830 3169 Improve C-level modularity by making more things 'static'.
cd64ea1d 3170
e3b27b31
PE
3171 Don't publish debugger-only interfaces to other modules.
3172 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3173 (verify_bytepos, count_markers): Move decls to the only modules
3174 that need them.
3175 * region-cache.h (pp_cache): Likewise.
3176 * window.h (check_all_windows): Likewise.
3177 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3178
5d4cb038
PE
3179 * sysdep.c (croak): Now static, if
3180 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3181 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3182
3183 * alloc.c (refill_memory_reserve): Now static if
3184 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3185 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3186
e87b6180
PE
3187 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3188 Define only if USE_LUCID.
3189
ac64929e
PE
3190 * xrdb.c (x_customization_string, x_rm_string): Now static.
3191
6f37259d
PE
3192 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3193 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3194
1683e3ab
PE
3195 * xdisp.c (draw_row_with_mouse_face): Now static.
3196 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3197
de9c2632
PE
3198 * window.h (check_all_windows): Mark externally visible.
3199
2b96acb7
PE
3200 * window.c (window_deletion_count): Now static.
3201
3202 * undo.c: Make symbols static if they're not exported.
3203 (last_undo_buffer, last_boundary_position, pending_boundary):
3204 Now static.
3205
50436f33
PE
3206 * textprop.c (interval_insert_behind_hooks): Now static.
3207 (interval_insert_in_front_hooks): Likewise.
3208
64520e5c
PE
3209 * term.c: Make symbols static if they're not exported.
3210 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3211 (max_frame_lines, tty_set_terminal_modes):
3212 (tty_reset_terminal_modes, tty_turn_off_highlight):
3213 (get_tty_terminal): Now static.
3214 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3215 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3216 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3217 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3218 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3219
1fa53021
PE
3220 * sysdep.c: Make symbols static if they're not exported.
3221 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3222 Now static.
3223 (sigprocmask_set, full_mask): Remove; unused.
3224 (wait_debugging): Mark as visible.
3225 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3226 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3227
d4b43b22
PE
3228 * syntax.c (syntax_temp): Define only if !__GNUC__.
3229
b7c513d0
PE
3230 * sound.c (current_sound_device, current_sound): Now static.
3231
989b29ad
PE
3232 * search.c (searchbufs, searchbuf_head): Now static.
3233
13a55a78
PE
3234 * scroll.c (scroll_cost): Remove; unused.
3235 * dispextern.h (scroll_cost): Remove decl.
3236
de68a1fc
PE
3237 * region-cache.h (pp_cache): Mark as externally visible.
3238
40ccffa6
PE
3239 * process.c: Make symbols static if they're not exported.
3240 (process_tick, update_tick, create_process, chan_process):
3241 (Vprocess_alist, proc_buffered_char, datagram_access):
3242 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3243 (deactivate_process): Mark defn as static, as well as decl.
3244 * lisp.h (create_process): Remove decl.
3245 * process.h (chan_process, Vprocess_alist): Remove decls.
3246
ad64fc97
PE
3247 * print.c: Make symbols static if they're not exported.
3248 (print_depth, new_backquote_output, being_printed, print_buffer):
3249 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3250 (print_interval, print_number_index, initial_stderr_stream):
3251 Now static.
3252 * lisp.h (Fprinc): Remove decl.
3253 (debug_output_compilation_hack): Mark as externally visible.
3254
adddb265
PE
3255 * sysdep.c (croak): Move decl from here to syssignal.h.
3256 * syssignal.h (croak): Put it here, so the API can be checked when
3257 'croak' is called from dissociate_if_controlling_tty.
3258
1717ede2
PE
3259 * minibuf.c: Make symbols static if they're not exported.
3260 (minibuf_save_list, choose_minibuf_frame): Now static.
3261 * lisp.h (choose_minibuf_frame): Remove decl.
3262
fa5fb2bc
PE
3263 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3264
1e3890d1
PE
3265 * lread.c: Make symbols static if they're not exported.
3266 (read_objects, initial_obarray, oblookup_last_bucket_number):
3267 Now static.
3268 (make_symbol): Remove; unused.
3269 * lisp.h (initial_obarray, make_symbol): Remove decls.
3270
8a1414fa
PE
3271 * keyboard.c: Make symbols static if they're not exported.
3272 (single_kboard, recent_keys_index, total_keys, recent_keys):
3273 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3274 (this_single_command_key_start, echoing, last_auto_save):
3275 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3276 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3277 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3278 (Vlispy_mouse_stem, double_click_count):
3279 Now static.
3280 (force_auto_save_soon): Define only if SIGDANGER.
3281 (ignore_mouse_drag_p): Now static if
3282 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3283 (print_help): Remove; unused.
3284 (stop_character, last_timer_event): Mark as externally visible.
3285 * keyboard.h (ignore_mouse_drag_p): Declare only if
3286 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3287 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3288 * lisp.h (echoing): Remove decl.
3289 (force_auto_save_soon): Declare only if SIGDANGER.
3290 * xdisp.c (redisplay_window): Simplify code, to make it more
3291 obvious that ignore_mouse_drag_p is not accessed if !defined
3292 USE_GTK && !defined HAVE_NS.
3293
93ea6e8f
PE
3294 * intervals.c: Make symbols static if they're not exported.
3295 (merge_properties_sticky, merge_interval_right, delete_interval):
3296 Now static.
3297 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3298
77382fcc
PE
3299 * insdel.c: Make symbols static if they're not exported.
3300 However, leave prepare_to_modify_buffer alone. It's never
3301 called from outside this function, but that appears to be a bug.
3302 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3303 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3304 (adjust_after_replace_noundo): Remove; unused.
3305 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3306 (signal_before_change): Remove decls.
77382fcc 3307
9306c32e
PE
3308 * indent.c (val_compute_motion, val_vmotion): Now static.
3309
cd44d2eb
PE
3310 * image.c: Make symbols static if they're not exported.
3311 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3312 if USE_GTK.
3313 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3314 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3315
ad9a7a06
PE
3316 * fringe.c (standard_bitmaps): Now static.
3317 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3318
81626931
PE
3319 * frame.c: Make symbols static if they're not exported.
3320 (x_report_frame_params, make_terminal_frame): Now static.
3321 (get_frame_param): Now static, unless HAVE_NS.
3322 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3323 (x_get_resource_string): Remove; not used.
3324 * frame.h (make_terminal_frame, x_report_frame_params):
3325 (x_get_resource_string); Remove decls.
3326 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3327 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3328
239f9db9
PE
3329 * font.c, fontset.c: Make symbols static if they're not exported.
3330 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3331 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3332 * font.c (font_close_object): Now static.
3333 * font.h (font_close_object): Remove.
3334 * fontset.c (FONTSET_OBJLIST): Remove.
3335 (free_realized_fontset) #if-0 the body, which does nothing.
3336 (face_suitable_for_char_p): #if-0, as it's never called.
3337 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3338 * xfaces.c (face_at_string_position):
3339 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3340 since 0 is always ASCII.
3341
dfcf3579
PE
3342 * fns.c (weak_hash_tables): Now static.
3343
5045092b
PE
3344 * fileio.c: Make symbols static if they're not exported.
3345 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3346 (Vwrite_region_annotation_buffers): Now static.
3347
57a96f5c
PE
3348 * eval.c: Make symbols static if they're not exported.
3349 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3350 * lisp.h (backtrace_list): Remove decl.
3351
35f08c38
PE
3352 * emacs.c: Make symbols static if they're not exported.
3353 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3354 (fatal_error_code, fatal_error_signal_hook, standard_args):
3355 Now static.
3356 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3357 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3358 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3359 * lisp.h (fatal_error_signal_hook): Remove decl.
3360 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3361
f44bd759
PE
3362 * editfns.c: Move a (normally-unused) function to its only use.
3363 * editfns.c, lisp.h (get_operating_system_release): Remove.
3364 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3365 worth the hassle of breaking this out.
3366
b532497d
PE
3367 * xterm.c: Make symbols static if they're not exported.
3368 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3369 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3370 (x_destroy_window, x_delete_display):
3371 Now static.
3372 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3373 (x_mouse_leave): Remove; unused.
3374 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3375 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3376 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3377 Remove decls.
3378 (x_mouse_leave): Declare only if WINDOWSNT.
3379 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3380 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3381 USE_X_TOOLKIT.
3382
1675728f
PE
3383 * ftxfont.c: Make symbols static if they're not exported.
3384 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3385 HAVE_FREETYPE.
3386 * font.h (ftxfont_driver): Likewise.
3387
e4cebfca
PE
3388 * xfns.c: Make symbols static if they're not exported.
3389 (x_last_font_name, x_display_info_for_name):
3390 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3391 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3392 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3393 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3394 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3395 (last_show_tip_args): Now static.
3396 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3397 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3398 (x_screen_planes): Remove; unused.
3399 * dispextern.h (x_screen_planes): Remove decl.
3400
5bf46f05
PE
3401 * dispnew.c: Make symbols static if they're not exported.
3402 * dispextern.h (redraw_garbaged_frames, scrolling):
3403 (increment_row_positions): Remove.
3404 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3405 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3406 Now static.
3407 (redraw_garbaged_frames): Remove; unused.
3408
435f4c28
PE
3409 * xfaces.c: Make symbols static if they're not exported.
3410 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3411 Remove decls.
3412 * xterm.h (defined_color): Remove decls.
3413 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3414 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3415 (menu_face_changed_default, defined_color, free_realized_face):
3416 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3417 (ascii_face_of_lisp_face): Remove; unused.
3418
8524aef3
PE
3419 * xdisp.c: Make symbols static if they're not exported.
3420 * dispextern.h (scratch_glyph_row, window_box_edges):
3421 (glyph_to_pixel_coords, set_cursor_from_row):
3422 (get_next_display_element, set_iterator_to_next):
3423 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3424 (show_mouse_face): Remove decls
3425 * frame.h (message_buf_print): Likewise.
3426 * lisp.h (pop_message, set_message, check_point_in_composition):
3427 Likewise.
3428 * xterm.h (set_vertical_scroll_bar): Likewise.
3429 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3430 (message_buf_print, scratch_glyph_row, displayed_buffer):
3431 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3432 (get_next_display_element, show_mouse_face, window_box_edges):
3433 (frame_to_window_pixel_xy, check_point_in_composition):
3434 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3435 (glyph_to_pixel_coords): Remove; unused.
3436
16390cd2
PE
3437 * dired.c (file_name_completion): Now static.
3438
3439 * dbusbind.c (xd_in_read_queued_messages): Now static.
3440
a25f4dfa
PE
3441 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3442 * data.c (circular_list_error): Remove.
3443
14a9c8df
PE
3444 * commands.h (last_point_position, last_point_position_buffer):
3445 (last_point_position_window): Remove decls.
3446 * keyboard.c: Make these variables static.
3447
04f2d78b
CB
3448 * coding.h (coding, code_convert_region, encode_coding_gap):
3449 Remove decls.
74ab6df5
PE
3450 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3451 (iso_code_class, detect_coding, code_convert_region): Now static.
3452 (encode_coding_gap): Remove; unused.
3453
38dfbee1
PE
3454 * chartab.c (chartab_chars, chartab_bits): Now static.
3455
a2cb4e63
PE
3456 * charset.h (charset_iso_8859_1): Remove decl.
3457 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3458 Now static.
3459
127198fd
PE
3460 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3461 * ccl.c (Vccl_program_table): Now static.
3462 (check_ccl_update): Remove; unused.
3463
d85b608f
PE
3464 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3465 * category.h: ... from here.
3466 * category.c (check_category_table, set_category_set): Now static.
3467
31cd66f3
PE
3468 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3469 * lisp.h: Remove these decls.
3470
c358e587
PE
3471 * buffer.c (buffer_count): Remove unused var.
3472
e78aecca
PE
3473 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3474 so that it's not optimized away.
3475 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3476 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3477 exported only to the debugger.
3478
e192d7d3 3479 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3480 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3481
92470028
PE
3482 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3483 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3484 was inaccessible from Lisp.
3485 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3486 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3487
244ed907
PE
3488 alloc.c: Import and export fewer symbols, and remove unused items.
3489 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3490 is defined.
3491 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3492 it's not optimized away by whole-program optimization.
3493 (message_enable_multibyte, free_misc): Remove.
3494 (catchlist, handlerlist, mark_backtrace):
3495 Declare only if BYTE_MARK_STACK.
3496 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3497 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3498 (message_enable_multibyte): Remove decl.
3499 (free_misc, interval_free_list, float_block, float_block_index):
3500 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3501 (cons_free_list, last_marked_index):
3502 Now static.
3503 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3504 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3505 (mark_backtrace): Define only if BYTE_MARK_STACK.
3506 * xdisp.c (message_enable_multibyte): Now static.
3507
61c2b50e 3508 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3509 This makes it easier for human readers (and static analyzers)
3510 to see whether these variables are used from other modules.
3511 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3512 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3513 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3514 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3515 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3516 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3517 * xmenu.c, xselect.c:
3518 Declare Q* vars static if they are not used in other modules.
3519 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3520 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3521 Remove decls of unexported vars.
3522 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3523
95c82688
PE
3524 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3525
16a97296
PE
3526 Make Emacs functions such as Fatom 'static' by default.
3527 This makes it easier for human readers (and static analyzers)
3528 to see whether these functions can be called from other modules.
3529 DEFUN now defines a static function. To make the function external
3530 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3531 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3532 (Finit_image_library):
16a97296
PE
3533 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3534 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3535 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3536 Remove decls, since these functions are now static.
3537 (Funintern, Fget_internal_run_time): New decls, since these functions
3538 were already external.
95c82688 3539
16a97296
PE
3540 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3541 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3542 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3543 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3544 * keyboard.c, keymap.c, lread.c:
3545 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3546 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3547 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3548 Mark functions with DEFUE instead of DEFUN,
3549 if they are used in other modules.
3550 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3551 decls for now-static functions.
3552 * buffer.h (Fdelete_overlay): Remove decl.
3553 * callproc.c (Fgetenv_internal): Mark as internal.
3554 * composite.c (Fremove_list_of_text_properties): Remove decl.
3555 (Fcomposition_get_gstring): New forward static decl.
3556 * composite.h (Fcomposite_get_gstring): Remove decl.
3557 * dired.c (Ffile_attributes): New forward static decl.
3558 * doc.c (Fdocumntation_property): New forward static decl.
3559 * eval.c (Ffetch_bytecode): New forward static decl.
3560 (Funintern): Remove extern decl; now in .h file where it belongs.
3561 * fileio.c (Fmake_symbolic_link): New forward static decl.
3562 * image.c (Finit_image_library): New forward static decl.
3563 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3564 * intervals.h (Fprevious_property_change):
3565 (Fremove_list_of_text_properties): Remove decls.
3566 * keyboard.c (Fthis_command_keys): Remove decl.
3567 (Fcommand_execute): New forward static decl.
3568 * keymap.c (Flookup_key): New forward static decl.
3569 (Fcopy_keymap): Now static.
3570 * keymap.h (Flookup_key): Remove decl.
3571 * process.c (Fget_process): New forward static decl.
3572 (Fprocess_datagram_address): Mark as internal.
3573 * syntax.c (Fsyntax_table_p): New forward static decl.
3574 (skip_chars): Remove duplicate decl.
3575 * textprop.c (Fprevious_property_change): New forward static decl.
3576 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3577 Now internal.
3578 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3579 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3580
785bbd42
PE
3581 * editfns.c (Fformat): Remove unreachable code.
3582
8b913b57
AS
35832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3584
3585 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3586 change. (Bug#8496)
3587
a6744a35
EZ
35882011-04-13 Eli Zaretskii <eliz@gnu.org>
3589
3590 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3591 when at ZV. (Bug#8487)
3592
e7974947
AS
35932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3594
baad03f0
AS
3595 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3596 (Bug#8437)
3597 * keyboard.c (parse_tool_bar_item): Likewise.
3598 * sound.c (sound_cleanup, alsa_close): Likewise.
3599 * termcap.c (tgetent): Likewise.
3600 * xfns.c (x_default_font_parameter): Likewise.
3601 * xsettings.c (read_and_apply_settings): Likewise.
3602
e7974947
AS
3603 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3604 (overrun_check_free): Protoize.
3605
28272684
PE
36062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3609 since callers should never pass a negative size.
3610 Change the signature to match that of plain 'read' and 'write'; see
3611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3612 * lisp.h: Update prototypes of emacs_write and emacs_read.
3613
11997c76
EZ
36142011-04-11 Eli Zaretskii <eliz@gnu.org>
3615
3616 * xdisp.c (redisplay_window): Don't try to determine the character
3617 position of the scroll margin if the window start point w->startp
e896f03c 3618 is outside the buffer's accessible region. (Bug#8468)
11997c76 3619
8a2cbd72
EZ
36202011-04-10 Eli Zaretskii <eliz@gnu.org>
3621
3622 Fix write-region and its subroutines for buffers > 2GB.
3623 * fileio.c (a_write, e_write): Modify declaration of arguments and
3624 local variables to support buffers larger than 2GB.
3625 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3626
3627 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3628 argument, local variables, and return value.
3629
3630 * lisp.h: Update prototypes of emacs_write and emacs_read.
3631
3632 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3633
4073e537 36342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3635
1ebfdcb6
PE
3636 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3637
b2ded58d
PE
3638 Fix more problems found by GCC 4.6.0's static checks.
3639
7d66342c
PE
3640 * xdisp.c (vmessage): Use a better test for character truncation.
3641
bbf47d44
PE
3642 * charset.c (load_charset_map): <, not <=, for optimization,
3643 and to avoid potential problems with integer overflow.
9248994d 3644 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3645 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3646 * editfns.c (Fformat): Likewise.
1e69125e 3647 * syntax.c (skip_chars): Likewise.
3befa583 3648
e3019616
PE
3649 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3650 This also lets GCC 4.6.0 generate slightly better loop code.
3651
becfa255
PE
3652 * callint.c (Fcall_interactively): <, not <=, for optimization.
3653 (Fcall_interactively): Count the number of arguments produced,
3654 not the number of arguments given. This is simpler and lets GCC
3655 4.6.0 generate slightly better code.
3656
dae0cd48
PE
3657 * ftfont.c: Distingish more carefully between FcChar8 and char.
3658 The previous code passed unsigned char * to a functions like
3659 strlen and xstrcasecmp that expect char *, which does not
3660 conform to the C standard.
3661 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3662 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3663 char * when the C standard requires it.
3664
76032d70
PE
3665 * keyboard.c (read_char): Remove unused var.
3666
eb3f1cc8
PE
3667 * eval.c: Port to Windows vsnprintf (Bug#8435).
3668 Include <limits.h>.
3669 (SIZE_MAX): Define if the headers do not.
3670 (verror): Do not give up if vsnprintf returns a negative count.
3671 Instead, grow the buffer. This ports to Windows vsnprintf, which
3672 does not conform to C99. Problem reported by Eli Zaretskii.
3673 Also, simplify the allocation scheme, by avoiding the need for
3674 calling realloc, and removing the ALLOCATED variable.
3675
70476b54
PE
3676 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3677
12020a9e
PE
3678 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3679 But keep the doprint source code for now, as we might revamp it
3680 and use it again (Bug#8435).
ea6c7ae6
PE
3681 * lisp.h (doprnt): Remove.
3682 * Makefile.in (base_obj): Remove doprnt.o.
3683 * deps.mk (doprnt.o): Remove.
3684
5fdb398c
PE
3685 error: Print 32- and 64-bit integers portably (Bug#8435).
3686 Without this change, on typical 64-bit hosts error ("...%d...", N)
3687 was used to print both 32- and 64-bit integers N, which relied on
3688 undefined behavior.
3689 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3690 New macro.
3691 * lisp.h (error, verror): Mark as printf-like functions.
3692 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3693 Report overflow in size calculations when allocating printf buffer.
3694 Do not truncate output string at its first null byte.
3695 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3696 Truncate the output at a character boundary, since vsnprintf does not
3697 do that.
3698 * charset.c (check_iso_charset_parameter): Convert internal
3699 character to string before calling 'error', since %c now has the
3700 printf meaning.
3701 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3702 overflow when computing char to be passed to 'error'. Do not
3703 pass Lisp_Object to 'error'; pass the integer instead.
3704 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3705 formatted with plain %d.
3706
b189fa66
PE
3707 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3708
bff87ef0
PE
3709 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3710
7e2cac20
PE
3711 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3712
ce4d90b5
PE
3713 * xterm.c (x_catch_errors): Remove duplicate declaration.
3714
266c9547
PE
3715 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3716
79c49ad2
PE
3717 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3718
368f4090
JM
37192011-04-10 Jim Meyering <meyering@redhat.com>
3720
3721 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3722 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3723 return ssize_t not "int", and use size_t as the buffer length.
3724 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3725 * gnutls.h: Update declarations.
3726 * process.c (read_process_output): Use ssize_t, to match.
3727 (send_process): Likewise.
3728
a32d4040
CY
37292011-04-09 Chong Yidong <cyd@stupidchicken.com>
3730
3731 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3732
8546720e 37332011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3734
04f2d78b
CB
3735 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3736 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3737
8546720e
GM
3738 * xterm.c (handle_one_xevent):
3739 * xmenu.c (create_and_show_popup_menu):
3740 * xselect.c (x_decline_selection_request)
3741 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3742
0a2f5c1a 37432011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3744
3745 Fix some uses of `int' instead of EMACS_INT.
3746 * search.c (string_match_1, fast_string_match)
3747 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3748 (scan_buffer, find_next_newline_no_quit)
3749 (find_before_next_newline, search_command, Freplace_match)
3750 (Fmatch_data): Make some `int' variables be EMACS_INT.
3751
3752 * xdisp.c (display_count_lines): 3rd argument and return value now
3753 EMACS_INT. All callers changed.
3754 (pint2hrstr): Last argument is now EMACS_INT.
3755
3756 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3757 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3758 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3759 (decode_coding_utf_16, decode_coding_emacs_mule)
3760 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3761 (decode_coding_ccl, decode_coding_charset)
3762 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3763 (decode_coding_iso_2022, decode_coding_emacs_mule)
3764 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3765 <char_offset, last_offset>: Declare EMACS_INT.
3766 (encode_coding_utf_8, encode_coding_utf_16)
3767 (encode_coding_emacs_mule, encode_invocation_designation)
3768 (encode_designation_at_bol, encode_coding_iso_2022)
3769 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3770 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3771 Declare EMACS_INT.
3772 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3773 (encode_invocation_designation): Last argument P_NCHARS is now
3774 EMACS_INT.
3775 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3776 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3777
3778 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3779 All users changed.
3780
3781 * ccl.c (Fccl_execute_on_string): Declare some variables
3782 EMACS_INT.
3783
8546720e 37842011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3785
3786 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3787
4e19a977
CS
37882011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3789
3790 * process.c (Fformat_network_address): Doc fix.
3791
87302331
R
37922011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3793
3794 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3795
cbb59342
CY
37962011-04-08 Chong Yidong <cyd@stupidchicken.com>
3797
3798 * keyboard.c (read_char): Call Lisp function help-form-show,
3799 instead of using internal_with_output_to_temp_buffer.
3800 (Qhelp_form_show): New var.
e0d38eeb 3801 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3802
3803 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3804
3805 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3806
e67a13ab
CY
38072011-04-06 Chong Yidong <cyd@stupidchicken.com>
3808
04f2d78b
CB
3809 * process.c (Flist_processes): Remove to Lisp.
3810 (list_processes_1): Delete.
e67a13ab 3811
973f782d
EZ
38122011-04-06 Eli Zaretskii <eliz@gnu.org>
3813
7c106b1e
EZ
3814 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3815
973f782d
EZ
3816 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3817
41cf7d1a 38182011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3819
ca23cc88
PE
3820 Fix more problems found by GCC 4.6.0's static checks.
3821
f390e2d5
PE
3822 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3823
42eea0d0
PE
3824 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3825
b69769da 3826 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3827
f9541e84
PE
3828 * xdisp.c (vmessage): Mark as a printf-like function.
3829
13841b55
PE
3830 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3831
c136c10f
PE
3832 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3833
5e2d4a30
PE
3834 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3835 printf-like functions.
3836 (tiff_load): Add casts to remove these marks before passing them
3837 to system-supplied API.
3838
583f48b9
PE
3839 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3840
b25d760e
PE
3841 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3842 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3843 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3844 directly, rather than having caller test rule sign. This avoids
3845 some unnecessary tests.
3846 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3847 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3848 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3849
bc7b6697 3850 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3851 (xfont_open): Avoid unnecessary tests.
bc7b6697 3852
27ccc379
PE
3853 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3854
dcd5c89a
PE
3855 * composite.h, composite.c (composition_gstring_put_cache):
3856 Use EMACS_INT, not int, for length.
3857
b13a45c6
PE
3858 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3859 breaking out part of COMPOSITION_DECODE_RULE.
3860 (COMPOSITION_DECODE_RULE): Use it.
3861 * composite.c (get_composition_id): Remove unused local vars,
3862 by using the new macro.
3863
1e792e4d
PE
3864 * textprop.c (set_text_properties_1): Change while to do-while,
3865 since the condition is always true at first.
3866
dc6c6455 3867 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3868 (interval_deletion_adjustment): Return unsigned value.
3869 All uses changed.
dc6c6455 3870
aba7731a
PE
3871 * process.c (list_processes_1, create_pty, read_process_output):
3872 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3873 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3874 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3875 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3876 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3877
fdfc4bf3
PE
3878 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3879
fca8fe46 3880 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3881 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3882
06a0259a 3883 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3884 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3885 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3886
e7b9e80f
PE
3887 * print.c (print_error_message): Avoid int overflow.
3888
56201685
PE
3889 * font.c (font_list_entities): Redo for clarity,
3890 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3891
78834453 3892 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3893 (font_score): Avoid potential overflow in diff calculation.
78834453 3894
0bc0b309 3895 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3896 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3897
e610eaca
PE
3898 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3899
b895abce
PE
3900 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3901 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3902 can always succeed if overflow has undefined behavior.
3903
1f1d9321 3904 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3905 (wordify): Omit three unnecessary tests.
1f1d9321 3906
c59478bc
PE
3907 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3908 All callers changed. This avoids the need for an unused var.
3909
79b73827
PE
3910 * casefiddle.c (casify_region): Remove var that is set but not used.
3911
a4db5dfe
PE
3912 * dired.c (file_name_completion): Remove var that is set but not used.
3913
43aae36e
PE
3914 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3915
2a47c44d 3916 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3917 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3918
a37c69bf
PE
3919 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3920 Check for integer overflow on size calculations.
3921
328ab8e7
PE
3922 * buffer.c (Fprevious_overlay_change): Remove var that is set
3923 but not used.
3924
e5a2a5cb
PE
3925 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3926 Remove vars that are set but not used.
8d84a6eb 3927 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3928 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3929
a60e5f68
PE
3930 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3931
f661cb61 3932 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3933 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3934
f0397f5a
PE
3935 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3936 that are set but not used.
3937
8664db06 3938 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3939 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3940
6abdaa4a
PE
3941 * xselect.c (x_get_local_selection, x_handle_property_notify):
3942 Remove vars that are set but not used.
3943
0ce7538d 3944 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3945 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3946
9ae848fc
PE
3947 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3948 Remove var that is set but not used.
0b918413
PE
3949 (scroll_bar_windows_size): Now size_t, not int.
3950 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3951 Check for overflow.
9ae848fc 3952
a5a62657
PE
3953 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3954 (map_tty_color) [!defined MSDOS]: Likewise.
3955
5c5cdd39
PE
3956 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3957
66ebf983
PE
3958 * coding.c: Remove vars that are set but not used.
3959 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3960 All callers changed.
3961 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3962 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3963 (decode_coding_charset): Remove vars that are set but not used.
3964
1be4d761
PE
3965 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3966 that is set but not used.
3967
47553fa8
PE
3968 * print.c (print_object): Remove var that is set but not used.
3969
1f7196bf 3970 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3971 The gnulib version avoids calling malloc in the usual case,
3972 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3973 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3974 * filelock.c (current_lock_owner): Likewise.
3975 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3976 * sysdep.c: Include allocator.h, careadlinkat.h.
3977 (emacs_no_realloc_allocator): New static constant.
3978 (emacs_readlink): New function.
fdb61804
PE
3979 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3980 ../lib/careadlinkat.h.
d1fdcab7 3981
f84c17c7
SM
39822011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3983
3984 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3985 first non-nil return value).
3986
ef3862ad
JD
39872011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3988
3989 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3990 if not defined (Bug#8403).
3991
376a7006
JB
39922011-04-02 Juanma Barranquero <lekktu@gmail.com>
3993
3994 * xdisp.c (display_count_lines): Remove parameter `start',
3995 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3996 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3997 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3998 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3999 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4000 and thereabouts. All callers changed.
4001 (get_per_char_metric): Remove parameter `f', unused since
4002 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4003
6ca3801d
JM
40042011-04-02 Jim Meyering <meyering@redhat.com>
4005
4006 do not dereference NULL upon failed strdup
4007 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4008 (ns_get_family): Likewise.
4009
d8e2b5ba
JB
40102011-04-02 Juanma Barranquero <lekktu@gmail.com>
4011
4012 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4013
8c74fcbd
JD
40142011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4015
4016 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4017 later (Bug#8403).
4018
7200d79c
SM
40192011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4020
03408648 4021 Add lexical binding.
7200d79c 4022
03408648
SM
4023 * window.c (Ftemp_output_buffer_show): New fun.
4024 (Fsave_window_excursion):
4025 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4026
4027 * lread.c (lisp_file_lexically_bound_p): New function.
4028 (Fload): Bind Qlexical_binding.
4029 (readevalloop): Remove `evalfun' arg.
4030 Bind Qinternal_interpreter_environment.
4031 (Feval_buffer): Bind Qlexical_binding.
4032 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4033 Mark as dynamic.
4034 (syms_of_lread): Declare `lexical-binding'.
4035
4036 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4037
4038 * keyboard.c (eval_dyn): New fun.
4039 (menu_item_eval_property): Use it.
ca105506
SM
4040
4041 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4042
03408648
SM
4043 * fns.c (concat, mapcar1): Accept byte-code-functions.
4044
4045 * eval.c (Fsetq): Handle lexical vars.
4046 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4047 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4048 (FletX, Flet): Obey lexical binding.
4049 (Fcommandp): Handle closures.
4050 (Feval): New `lexical' arg.
4051 (eval_sub): New function extracted from Feval. Use it almost
4052 everywhere where Feval was used. Look up vars in lexical env.
4053 Handle closures.
4054 (Ffunctionp): Move from subr.el.
4055 (Ffuncall): Handle closures.
4056 (apply_lambda): Remove `eval_flags'.
4057 (funcall_lambda): Handle closures and new byte-code-functions.
4058 (Fspecial_variable_p): New function.
4059 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4060 but without exporting it to Lisp.
23aba0ea 4061
23aba0ea 4062 * doc.c (Fdocumentation, store_function_docstring):
03408648 4063 * data.c (Finteractive_form): Handle closures.
23aba0ea 4064
03408648
SM
4065 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4066 interactive spec.
ba83908c 4067
04f2d78b
CB
4068 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4069 New byte-codes.
03408648
SM
4070 (exec_byte_code): New function extracted from Fbyte_code to handle new
4071 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4072
03408648 4073 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4074
03408648 4075 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4076
e2abce01
JB
40772011-03-31 Juanma Barranquero <lekktu@gmail.com>
4078
4079 * xdisp.c (redisplay_internal): Fix prototype.
4080
63696a73 40812011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4082
63696a73 4083 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4084 (try_scrolling): Use it when setting scroll_limit.
4085 Limit scrolling to 100 screen lines.
63696a73
EZ
4086 (redisplay_window): Even when falling back on "recentering",
4087 position point in the window according to scroll-conservatively,
4088 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4089
4090 (try_scrolling): When point is above the window, allow searching
4091 as far as scroll_max, or one screenful, to compute vertical
4092 distance from PT to the scroll margin position. This prevents
4093 try_scrolling from unnecessarily failing when
4094 scroll-conservatively is set to a value slightly larger than the
4095 window height. Clean up the case of PT below the margin at bottom
4096 of window: scroll_max can no longer be INT_MAX. When aggressive
4097 scrolling is in use, don't let point enter the opposite scroll
4098 margin as result of the scroll.
4099 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4100 threshold of 100 lines for never-recentering scrolling.
4101
e4cc2dfc
JB
41022011-03-31 Juanma Barranquero <lekktu@gmail.com>
4103
4104 * dispextern.h (move_it_by_lines):
4105 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4106 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4107 (message_log_check_duplicate): Remove parameters `prev_bol' and
4108 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4109 (redisplay_internal): Remove parameter `preserve_echo_area',
4110 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4111
4112 * indent.c (Fvertical_motion):
4113 * window.c (window_scroll_pixel_based, Frecenter):
4114 Don't pass `need_y_p' to `move_it_by_lines'.
4115
1c470562
SM
41162011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4117
44f230aa
SM
4118 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4119 steal a few bits to be more compact.
4120 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4121 Remove unneeded casts.
4122
1c470562
SM
4123 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4124
888adce9
ZK
41252011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4126
4127 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4128 binding" message (bug#7967).
4129
f838ed7b
PE
41302011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4131
77861b95
PE
4132 Fix more problems found by GCC 4.6.0's static checks.
4133
de6dbc14
PE
4134 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4135 Remove unused local var.
4136
f838ed7b
PE
4137 * editfns.c (Fmessage_box): Remove unused local var.
4138
792c7b2b
PE
4139 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4140 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4141 Omit unused local vars.
c499e557 4142 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4143 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4144 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4145 Omit unused local var.
4146
ba0165e1
PE
4147 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4148 Don't assume string length fits in int.
32ad8845 4149 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4150 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4151
3c59b4c9
PE
4152 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4153 instead of alloca (Bug#8344).
4154
a3eed478 4155 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4156 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4157
eb4d412d
PE
4158 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4159
1658b401
PE
4160 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4161 concerns.
4162
4163 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4164
4165 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4166
9a2c6e05
PE
4167 * keyboard.c (syms_of_keyboard): Use the same style as later
4168 in this function when indexing through an array. This also
4169 works around GCC bug 48267.
4170
03d0a109
PE
4171 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4172
44f730c8
PE
4173 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4174
fe75f926
PE
4175 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4176 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4177
ffa8c828
PE
4178 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4179 This avoids undefined behavior on integer overflow, and is a bit
4180 more convenient anyway since it is compared to a size_t variable.
4181
c5101a77
PE
4182 Variadic C functions now count arguments with size_t, not int.
4183 This avoids an unnecessary limitation on 64-bit machines, which
4184 caused (substring ...) to crash on large vectors (Bug#8344).
4185 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4186 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4187 All variadic functions and their callers changed accordingly.
c5101a77
PE
4188 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4189 * data.c (arith_driver, float_arith_driver): Likewise.
4190 * editfns.c (general_insert_function): Likewise.
4191 * eval.c (struct backtrace.nargs, interactive_p)
4192 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4193 (funcall_lambda, mark_backtrace): Likewise.
4194 * fns.c (concat): Likewise.
4195 * frame.c (x_set_frame_parameters): Likewise.
4196 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4197 0 if not found, not -1. All callers changed.
4198
dd3f25f7
PE
4199 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4200 (stack_copy_size): Now size_t, not int.
4201 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4202
461c2ab9
JB
42032011-03-28 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4206 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4207 All callers changed.
4208
4209 * lisp.h (multibyte_char_to_unibyte):
4210 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4211 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4212 * character.h (CHAR_TO_BYTE8):
4213 * cmds.c (internal_self_insert):
4214 * editfns.c (general_insert_function):
4215 * keymap.c (push_key_description):
4216 * search.c (Freplace_match):
4217 * xdisp.c (message_dolog, set_message_1): All callers changed.
4218
f6d62986
SM
42192011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4220
4221 * keyboard.c (safe_run_hook_funcall): New function.
4222 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4223 don't set the hook to nil, but remove the offending function instead.
4224 (Qcommand_hook_internal): Remove, unused.
4225 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4226 Vcommand_hook_internal.
4227
4228 * eval.c (enum run_hooks_condition): Remove.
4229 (funcall_nil, funcall_not): New functions.
4230 (run_hook_with_args): Call each function through a `funcall' argument.
4231 Remove `cond' argument, now redundant.
4232 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4233 (Frun_hook_with_args_until_failure): Adjust accordingly.
4234 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4235
1db5b1ad
JB
42362011-03-28 Juanma Barranquero <lekktu@gmail.com>
4237
4238 * dispextern.h (string_buffer_position): Remove declaration.
4239
4240 * print.c (strout): Remove parameter `multibyte', unused since
4241 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4242
4243 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4244 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4245 All callers changed.
4246
4247 * w32.c (_wsa_errlist): Use braces for struct initializers.
4248
4249 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4250 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4251 All callers changed.
4252 (string_buffer_position): Likewise. Also, make static (it's never
4253 used outside xdisp.c).
4254 (cursor_row_p): Remove parameter `w', unused since
4255 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4256 (decode_mode_spec): Remove parameter `precision', introduced during
4257 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4258 All callers changed.
4259
5ffb62aa
JD
42602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4261
4262 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4263
461c2ab9 42642011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4265
4266 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4267 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4268 (ns_update_auto_hide_menu_bar): New functions.
4269 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4270 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4271 ns_constrain_all_frames.
4272 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4273 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4274
5c380ffb
JD
42752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4276
4277 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4278
9af30bdf
GM
42792011-03-27 Glenn Morris <rgm@gnu.org>
4280
4281 * syssignal.h: Replace RETSIGTYPE with void.
4282 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4283 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4284 Replace SIGTYPE with void everywhere.
4285 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4286 * s/template.h (SIGTYPE): Remove commented out definition.
4287
e2abce01
JB
42882011-03-26 Eli Zaretskii <eliz@gnu.org>
4289
4290 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4291 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4292
f868cd8a
JB
42932011-03-26 Juanma Barranquero <lekktu@gmail.com>
4294
59eb0929
JB
4295 * w32.c (read_unc_volume): Use parameter `henum', instead of
4296 global variable `wget_enum_handle'.
4297
4298 * keymap.c (describe_vector): Remove parameters `indices' and
4299 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4300 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4301
f868cd8a
JB
4302 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4303
4304 * keyboard.c (timer_check): Remove parameter `do_it_now',
4305 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4306 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4307 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4308
4309 * keyboard.c (read_char):
4310 * w32menu.c (w32_menu_display_help):
4311 * xmenu.c (show_help_event, menu_help_callback):
4312 Adjust calls to `show_help_echo'.
4313
4314 * gtkutil.c (xg_maybe_add_timer):
4315 * keyboard.c (readable_events):
4316 * process.c (wait_reading_process_output):
4317 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4318
4319 * insdel.c (adjust_markers_gap_motion):
4320 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4321 (gap_left, gap_right): Don't call it.
4322
2ecf6fdb
CY
43232011-03-25 Chong Yidong <cyd@stupidchicken.com>
4324
4325 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4326 incurred during fontification.
4327
6b1f9ba4
JB
43282011-03-25 Juanma Barranquero <lekktu@gmail.com>
4329
4330 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4331 (DEFVAR_PER_BUFFER): Don't pass it.
4332
4333 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4334 (scrolling_window): Don't pass it.
4335
0f4a96b5
JB
43362011-03-25 Juanma Barranquero <lekktu@gmail.com>
4337
4338 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4339
4340 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4341 and `suffix'.
4342 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4343 of variables specific to SELinux and computation of `encoded_absname'.
4344
4345 * image.c (XPutPixel): Remove unused variable `height'.
4346
4347 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4348
4349 * unexw32.c (get_section_info): Remove unused variable `section'.
4350
4351 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4352 (system_process_attributes): Remove unused variable `sess'.
4353 (sys_read): Remove unused variable `err'.
4354
4355 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4356 (w32_wnd_proc): Remove unused variable `isdead'.
4357 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4358 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4359 (x_create_tip_frame): Remove unused variable `tem'.
4360
4361 * w32inevt.c (w32_console_read_socket):
4362 Remove unused variable `no_events'.
4363
4364 * w32term.c (x_draw_composite_glyph_string_foreground):
4365 Remove unused variable `width'.
4366
1149507c
JB
43672011-03-24 Juanma Barranquero <lekktu@gmail.com>
4368
4369 * w32term.c (x_set_glyph_string_clipping):
4370 Don't pass uninitialized region to CombineRgn.
4371
9c88f339
JB
43722011-03-23 Juanma Barranquero <lekktu@gmail.com>
4373
4374 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4375 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4376 (Fx_close_connection): Remove unused variable `i'.
4377
4378 * w32font.c (w32font_draw): Return number of glyphs.
4379 (w32font_open_internal): Remove unused variable `i'.
4380 (w32font_driver): Add missing initializer.
4381
4382 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4383 (fill_in_menu): Remove unused variable `items_added'.
4384
4385 * w32term.c (last_mouse_press_frame): Remove static global variable.
4386 (w32_clip_to_row): Remove unused variable `f'.
4387 (x_delete_terminal): Remove unused variable `i'.
4388
4389 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4390 (NOTHING): Remove unused static global variable.
4391 (uniscribe_check_otf): Remove unused variable `table'.
4392 (uniscribe_font_driver): Add missing initializers.
4393
dee091a3
JD
43942011-03-23 Julien Danjou <julien@danjou.info>
4395
4396 * term.c (Fsuspend_tty, Fresume_tty):
4397 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4398 * window.c (temp_output_buffer_show):
4399 * insdel.c (signal_before_change):
4400 * frame.c (Fhandle_switch_frame):
4401 * fileio.c (Fdo_auto_save):
4402 * emacs.c (Fkill_emacs):
4403 * editfns.c (save_excursion_restore):
4404 * cmds.c (internal_self_insert):
4405 * callint.c (Fcall_interactively):
4406 * buffer.c (Fkill_all_local_variables):
4407 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4408 Use Frun_hooks.
0f4a96b5 4409 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4410 unconditionnaly since it does the check itself.
4411
2c520ab5 44122011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4413
c9c49752
PE
4414 Fix more problems found by GCC 4.5.2's static checks.
4415
8abc3f12
PE
4416 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4417 the first time through the loop, since we know p0 < p1 then.
4418 This also avoids a gcc -Wstrict-overflow warning.
4419
a2d26660
PE
4420 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4421 leading to a memory leak, possible in functions like
4422 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4423 of objects (Bug#8318).
a2d26660 4424
916c72e9
PE
4425 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4426 that could (at least in theory) be that large.
4427
19ab8a18
PE
4428 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4429 This is less likely to overflow, and avoids undefined behavior if
4430 overflow does occur. All callers changed. Use strtoul to scan
4431 for the unsigned long integer.
b7cbbd6f
PE
4432 (pint2hrstr): Simplify and tune code slightly.
4433 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4434
f0641eff
PE
4435 * scroll.c (do_scrolling): Work around GCC bug 48228.
4436 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4437
7f650bb9
PE
4438 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4439 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4440 (validate_x_resource_name): Simplify count usage.
4441 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4442
37dd57d1
PE
4443 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4444 fail (Bug#8306).
81e56e61 4445
699979fc 4446 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4447
401bf9b4
PE
4448 * process.c (Fmake_network_process): Use socklen_t, not int,
4449 where POSIX says socklen_t is required in portable programs.
4450 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4451 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4452 (Fmake_network_process, server_accept_connection):
4453 (wait_reading_process_output, read_process_output):
4454 Likewise.
4455
b93aacde
PE
4456 * process.c: Rename or move locals to avoid shadowing.
4457 (list_processes_1, Fmake_network_process):
4458 (read_process_output_error_handler, exec_sentinel_error_handler):
4459 Rename or move locals.
4dc343ee 4460 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4461 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4462 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4463 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4464 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4465
af8a867c 4466 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4467 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4468 Include tparam.h instead, since it declares them.
af8a867c
PE
4469 * cm.h (PC): Remove extern decl; tparam.h now does this.
4470 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4471 * terminfo.c: Include tparam.h, to check interfaces.
4472 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4473 (tparam): Adjust signature to match interface in tparam.h;
4474 this removes some undefined behavior. Check that outstring and len
4475 are zero, which they always are with Emacs.
4476 * tparam.h (PC, BC, UP): New extern decls.
4477
0248044d 4478 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4479 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4480
8ff096c1 4481 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4482 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4483 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4484 (ftfont_list): Remove unused local.
49eaafba
PE
4485 (get_adstyle_property, ftfont_pattern_entity):
4486 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4487 Rename locals to avoid shadowing.
8ff096c1 4488
e2be39f6
PE
4489 * xfont.c (xfont_list_family): Mark var as initialized.
4490
c9735e30
PE
4491 * xml.c (make_dom): Now static.
4492
8f5201ae
PE
4493 * composite.c (composition_compute_stop_pos): Rename local to
4494 avoid shadowing.
b246f932
PE
4495 (composition_reseat_it): Remove unused locals.
4496 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4497 (composition_update_it): Mark var as initialized.
11b61122
PE
4498 (find_automatic_composition): Mark vars as initialized,
4499 with a FIXME (Bug#8290).
8f5201ae 4500
760fbc2c
PE
4501 character.h: Rename locals to avoid shadowing.
4502 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4503 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4504 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4505 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4506 to avoid shadowing.
4507
ff08eb85
PE
4508 * textprop.c (property_change_between_p): Remove; unused.
4509
fc7bf025
PE
4510 * intervals.c (interval_start_pos): Now static.
4511
235d7abc
PE
4512 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4513
44f230aa
SM
4514 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4515 Rename locals to avoid shadowing.
3e7d6594 4516
50060332
PE
4517 * sound.c (wav_play, au_play, Fplay_sound_internal):
4518 Fix pointer signedness.
d01f234b 4519 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4520 (wav_play): Initialize a variable to 0, to prevent undefined
4521 behavior (Bug#8278).
50060332 4522
c4fc4e30
PE
4523 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4524
918436ed
PE
4525 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4526
c939f91b
PE
4527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4528 clobbering (Bug#8298).
b9c7f648
PE
4529 * sysdep.c (sys_subshell): Likewise.
4530 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4531
6bd8c144
PE
4532 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4533 This should get cleaned up, so that child_setup has the
4534 same signature on all platforms.
4535
7710357c 4536 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4537 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4538
c59da222
CY
45392011-03-22 Chong Yidong <cyd@stupidchicken.com>
4540
4541 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4542 not to be necessary, and produces flickering.
4543
66b87493
GM
45442011-03-20 Glenn Morris <rgm@gnu.org>
4545
4546 * config.in: Remove file.
4547
45b6f6d5
JB
45482011-03-20 Juanma Barranquero <lekktu@gmail.com>
4549
4550 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4551 are now in src/globals.h.
4552 (syms_of_minibuf): Remove spurious & from previous change.
4553
3ec03f7e
LL
45542011-03-20 Leo <sdl.web@gmail.com>
4555
4556 * minibuf.c (completing-read-function): New variable.
4557 (completing-read-default): Rename from completing-read.
4558 (completing-read): Call completing-read-function.
4559
b14e3e21
CY
45602011-03-19 Juanma Barranquero <lekktu@gmail.com>
4561
4562 * xfaces.c (Fx_load_color_file):
4563 Read color file from absolute filename (bug#8250).
4564
f2b726e6
JB
45652011-03-19 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * makefile.w32-in: Update dependencies.
4568
09f6ff02
EZ
45692011-03-17 Eli Zaretskii <eliz@gnu.org>
4570
4571 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4572
29a6015a
PE
45732011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4574
a3a6c54e
PE
4575 Fix more problems found by GCC 4.5.2's static checks.
4576
b766f867
PE
4577 * process.c (make_serial_process_unwind, send_process_trap):
4578 (sigchld_handler): Now static.
4579
be02381c
PE
4580 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4581 That way, the code declares only the vars that it needs.
4582 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4583 * s/cygwin.h (PTY_ITERATION): Likewise.
4584 * s/darwin.h (PTY_ITERATION): Likewise.
4585 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4586
57048744
PE
4587 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4588 * process.c (allocate_pty): Don't declare stb unless it's needed.
4589
7914961c 4590 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4591 (CONSTANTLIM): Remove; unused.
4592 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4593 Define only if needed.
7914961c 4594
b3967b18
PE
4595 * unexelf.c (unexec): Name an expression,
4596 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4597 Use a different way to cause a compilation error if anyone uses
4598 n rather than nn, a way that does not involve shadowing.
73366a00 4599 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4600
29a6015a
PE
4601 * deps.mk (unexalpha.o): Remove; unused.
4602
43cfc33e 4603 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4604 * unexec.h: New file.
ce701a33
PE
4605 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4606 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4607 Depend on unexec.h.
4608 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4609 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4610 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4611 Change as necessary to match prototype in unexec.h.
ce701a33 4612
01f44d5a
PE
4613 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4614 shadowing.
4f63c6bb 4615 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4616
a6670b0b
PE
4617 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4618 Rename locals to avoid shadowing.
4619
cef2010d 4620 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4621 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4622
d4d7173a
PE
4623 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4624
f08b802a
PE
4625 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4626 warning when compiling print.c.
4627
3ddb0639
PE
4628 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4629 instead of using an uninitialized var.
5ad03b97 4630 (font_sort_entities): Mark var as initialized.
3ddb0639 4631
170a2692
PE
4632 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4633
e663c700
PE
4634 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4635 pointers to constants.
89bc529a 4636 (font_parse_fcname): Remove unused vars.
7b81e2d0 4637 (font_delete_unmatched): Now static.
ea838e10 4638 (font_get_spec): Remove; unused.
13a547c6
PE
4639 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4640 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4641 Rename or move locals to avoid shadowing.
e663c700 4642
2a80c887 4643 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4644 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4645
1384fa33 4646 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4647 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4648
8b2c52e9
PE
4649 * alloc.c (mark_backtrace): Move decl from here ...
4650 * lisp.h: ... to here, so that it can be checked.
4651
475545b5 4652 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4653 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4654 (lisp_indirect_variable): Name an expression,
4655 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4656 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4657
b1349114 4658 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4659 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4660 Use const pointer when appropriate.
b1349114 4661
a2928364
PE
4662 * lisp.h (get_system_name, get_operating_system_release):
4663 Move decls here, to check interfaces.
4664 * process.c (get_operating_system_release): Move decl to lisp.h.
4665 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4666 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4667 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4668 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4669 (Fformat_time_string, Fencode_time, Finsert_char):
4670 (Ftranslate_region_internal, Fformat):
4671 Rename or remove local vars to avoid shadowing.
9710023e 4672 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4673
a415e694
PE
4674 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4675 avoid shadowing.
4676
8ef4622d
PE
4677 * lisp.h (eassert): Check that the argument compiles, even if
4678 ENABLE_CHECKING is not defined.
4679
946f9a5b
PE
4680 * data.c (Findirect_variable): Name an expression, to avoid
4681 gcc -Wbad-function-cast warning.
112396d6 4682 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4683 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4684 (Fmake_variable_buffer_local, Fmake_local_variable):
4685 Mark variables as initialized.
52746918 4686 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4687
e5aab7e7 4688 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4689 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4690 Rename locals to avoid shadowing.
dff45157
PE
4691 (mark_stack): Move local variables into the #ifdef region where
4692 they're used.
7bc26fdb
PE
4693 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4694 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4695 needed otherwise.
4696 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4697 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4698 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4699
e5aab7e7
PE
4700 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4701 avoids undefined behavior in theory.
4702
4da60324
PE
4703 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4704
88043301
PE
4705 Use functions, not macros, for up- and down-casing (Bug#8254).
4706 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4707 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4708 to use the following functions instead of these macros.
4709 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4710 EMACS_INT, since callers assume the returned value fits in int.
4711 (upcase1): Likewise, for UPCASE_TABLE.
4712 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4713 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4714 the race-condition problem in the old DOWNCASE.
88043301 4715
19ed5445
PE
4716 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4717 Rename locals to avoid shadowing.
4718 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4719 (regex_compile, re_search_2, re_match_2_internal):
4720 Remove unused local vars.
952db0d7
PE
4721 (FREE_VAR): Rewrite so as not to use empty "else",
4722 which gcc can warn about.
da053e48 4723 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4724 (RETALLOC_IF): Define only if needed.
4725 (WORDCHAR_P): Likewise. This one is never needed, but is used
4726 only in a comment talking about a compiler bug, so put inside
4727 the #if 0 of that comment.
4728 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4729 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4730 Remove; unused.
19ed5445 4731
1f3561e4 4732 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4733 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4734 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4735
ded6f8f7
PE
4736 * search.c (simple_search): Remove unused var.
4737
dbd37a95
PE
4738 * dired.c (compile_pattern): Move decl from here ...
4739 * lisp.h: ... to here, so that it can be checked.
4740 (struct re_registers): New forward decl.
4741
7e47afad
PE
4742 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4743
85f24f61
PE
4744 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4745 All uses changed.
4746 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4747 Rename locals to avoid shadowing.
5671df8f 4748 (Fvertical_motion): Mark locals as initialized.
85f24f61 4749
181aa2be 4750 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4751 (casify_region): Mark local as initialized.
181aa2be 4752
930d429c
PE
4753 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4754
7082eac6
PE
4755 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4756 New macros, so that the caller can use some names other than
4757 gcpro1, gcpro2, etc.
4758 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4759 of the new macros.
4760 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4761 argument, for consistency with GCPRO2_VAR, etc: it is now the
4762 prefix of the variable, not the variable itself. All uses
4763 changed.
38b2c076
PE
4764 * dired.c (directory_files_internal, file_name_completion):
4765 Rename locals to avoid shadowing.
4766
15206ed9
PE
4767 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4768 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4769 dired.c's scmp function, had undefined behavior.
4770 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4771 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4772 * buffer.h: ... to here, because these macros use current_buffer,
4773 and the new implementation with inline functions needs to have
4774 current_buffer in scope now, rather than later when the macros
4775 are used.
4776 (downcase, upcase1): New static inline functions.
4777 (DOWNCASE, UPCASE1): Reimplement using these functions.
4778 This avoids undefined behavior in expressions like
4779 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4780 from race conditions in accessing the global variables
4781 case_temp1 and case_temp2.
4782 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4783 * lisp.h (case_temp1, case_temp2): Remove their decls.
4784 * character.h (ASCII_CHAR_P): Move from here ...
4785 * lisp.h: ... to here, so that the inline functions mentioned
4786 above can use them.
4787
4a6bea26
PE
4788 * dired.c (directory_files_internal_unwind): Now static.
4789
f14b7e14
PE
4790 * fileio.c (file_name_as_directory, directory_file_name):
4791 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4792 Now static.
2893f146
PE
4793 (file_name_as_directory): Use const pointers when appropriate.
4794 (Fexpand_file_name): Likewise. In particular, newdir might
4795 point at constant storage, so make it a const pointer.
fd4ead52 4796 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4797 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4798 signedness issues.
f839df0c
PE
4799 (Fset_file_times, Finsert_file_contents, auto_save_error):
4800 Rename locals to avoid shadowing.
f14b7e14 4801
5716756e 4802 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4803 (Ftry_completion, Fall_completions): Rename or remove locals
4804 to avoid shadowing.
5716756e 4805
b4c3046a
PE
4806 * marker.c (bytepos_to_charpos): Remove; unused.
4807
b45db522
PE
4808 * lisp.h (verify_bytepos, count_markers): New decls,
4809 so that gcc does not warn that these functions aren't declared.
4810
85876d07
PE
4811 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4812 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4813 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4814 (copy_text): Remove unused local var.
85876d07 4815
03d78a21 4816 * filelock.c (within_one_second): Now static.
b3dd38ab 4817 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4818
5df8f01b
PE
4819 * buffer.c (fix_overlays_before): Mark locals as initialized.
4820 (fix_start_end_in_overlays): Likewise. This function should be
4821 simplified by using pointers-to-pointers, but that's a different
4822 matter.
b1d876f1 4823 (switch_to_buffer_1): Now static.
8f54f30a
PE
4824 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4825 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4826
a70072c9 4827 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4828 Fix pointer signedness issue.
edced198
PE
4829 (sys_subshell): Mark local as volatile if checking for lint,
4830 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4831 (MAXPATHLEN): Define only if needed.
a70072c9 4832
a0977c44
PE
4833 * process.c (serial_open, serial_configure): Move decls from here ...
4834 * systty.h: ... to here, so that they can be checked.
4835
a884fdcc
PE
4836 * fns.c (get_random, seed_random): Move extern decls from here ...
4837 * lisp.h: ... to here, so that they can be checked.
4838
604efe86 4839 * sysdep.c (reset_io): Now static.
b8950c94 4840 (wait_for_termination_signal): Remove; unused.
604efe86 4841
38fc62d9
PE
4842 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4843 (copy_keymap_item, append_key, push_text_char_description):
4844 Now static.
1004a21a 4845 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4846 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4847 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4848 (describe_map_tree):
4849 Rename locals to avoid shadowing.
38fc62d9 4850
2f2650da
PE
4851 * keyboard.c: Declare functions static if they are not used elsewhere.
4852 (echo_char, echo_dash, cmd_error, top_level_2):
4853 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4854 (read_char, kbd_buffer_get_event, make_lispy_position):
4855 (make_lispy_event, make_lispy_movement, apply_modifiers):
4856 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4857 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4858 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4859 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4860 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4861
a053e86c 4862 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4863 (mark_kboards): Move decl here ...
4864 * alloc.c (mark_kboards): ... from here.
a053e86c 4865
4752793e
PE
4866 * lisp.h (force_auto_save_soon): New decl.
4867
74f10ca7 4868 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4869 (DEFINE_DUMMY_FUNCTION): New macro.
4870 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4871 Use it.
c03cd23f
PE
4872 (main): Add casts to avoid warnings
4873 if GCC considers string literals to be constants.
74f10ca7 4874
022e70d4
PE
4875 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4876
59d6fe83
PE
4877 * dbusbind.c: Pointer signedness fixes.
4878 (xd_signature, xd_append_arg, xd_initialize):
4879 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4881 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4882 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4883
78320123
PE
4884 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4885 if GCC considers string literals to be constants.
49cebcca 4886 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4887
35ac2a97
SM
48882011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4889
fb103ca9
SM
4890 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4891 (print_preprocess, print_object): New macro to fix last change.
4892
35ac2a97
SM
4893 * print.c (print_preprocess): Don't forget font objects.
4894
62973b41
JB
48952011-03-16 Juanma Barranquero <lekktu@gmail.com>
4896
4897 * emacs.c (USAGE3): Doc fixes.
4898
0e48bb22
AS
48992011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4900
4901 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4902 structure.
4903
7684e57b
JB
49042011-03-14 Juanma Barranquero <lekktu@gmail.com>
4905
4906 * lisp.h (VWindow_system, Qfile_name_history):
4907 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4908 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4909 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4910
4911 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4912 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4913
4914 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4915 * w32console.c (detect_input_pending, read_input_pending)
4916 (encode_terminal_code):
4917 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4918 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4919 (w32_system_caret_y, Qfile_name_history):
4920 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4921 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4922 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4923 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4924 * w32proc.c (Qlocal, report_file_error):
4925 * w32term.c (Vwindow_system, updating_frame):
4926 * w32uniscribe.c (initialized, uniscribe_font_driver):
4927 Remove unneeded extern declarations.
4928
2aa46d6c
CY
49292011-03-14 Chong Yidong <cyd@stupidchicken.com>
4930
c96bbc66 4931 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4932
cffc6f3b
CY
49332011-03-13 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4936 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4937 These macros can no longer be used for assignment.
4938
44f230aa
SM
4939 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4940 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4941 (record_buffer_markers, fetch_buffer_markers): New functions for
4942 recording and fetching special buffer markers.
4943 (set_buffer_internal_1, set_buffer_temp): Use them.
4944
4945 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4946
4947 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4948
4949 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4950 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4951
4952 * xdisp.c (hscroll_window_tree):
4953 (reconsider_clip_changes): Use PT instead of BUF_PT.
4954
d251f04b
EZ
49552011-03-13 Eli Zaretskii <eliz@gnu.org>
4956
4957 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4958 $(EMACS_ROOT)/lib/intprops.h.
4959
f0c77cd1
PE
49602011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4961
3eca4629
PE
4962 Fix more problems found by GCC 4.5.2's static checks.
4963
7c86ee98
PE
4964 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4965 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4966 (xg_free_frame_widgets): Make it clear that a local variable is
4967 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4968 (gdk_window_get_screen): Make it clear that this macro is needed
4969 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4970 (int_gtk_range_get_value): New function, which avoids a diagnostic
4971 from gcc -Wbad-function-cast.
4972 (xg_set_toolkit_scroll_bar_thumb): Use it.
4973 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4974 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4975 (get_utf8_string, xg_get_file_with_chooser):
4976 Rename locals to avoid shadowing.
4977 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4978
41729b81
PE
4979 * xgselect.c (xg_select): Remove unused var.
4980
f0c77cd1
PE
4981 * image.c (four_corners_best): Mark locals as initialized.
4982 (gif_load): Initialize transparent_p to zero (Bug#8238).
4983 Mark another local as initialized.
ec6cf4c6 4984 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4985
ce0ad53d 4986 * image.c (clear_image_cache): Now static.
d5d5a617 4987 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4988 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4989 (x_edge_detection): Remove unnecessary cast that
4990 gcc -Wbad-function-cast diagnoses.
2037898d 4991 (gif_load): Fix pointer signedness.
6ae141d6
PE
4992 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4993 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4994
33383987 49952011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4996
d32df629
PE
4997 Improve quality of tests for time stamp overflow.
4998 For example, without this patch (encode-time 0 0 0 1 1
4999 1152921504606846976) returns the obviously-bogus value (-948597
5000 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5001 reports time overflow. See
5002 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5003 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5004 * editfns.c: Include limits.h and intprops.h.
5005 (TIME_T_MIN, TIME_T_MAX): New macros.
5006 (time_overflow): Move earlier, to before first use.
5007 (hi_time, lo_time): New functions, for an accurate test for
5008 out-of-range times.
5009 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5010 (Fget_internal_run_time): Don't assume time_t fits in int.
5011 (make_time): Use list2 instead of Fcons twice.
5012 (Fdecode_time): More accurate test for out-of-range times.
5013 (check_tm_member): New function.
5014 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5015 (lisp_time_argument): Don't rely on undefined left-shift and
5016 right-shift behavior when checking for time stamp overflow.
8be6f318 5017
fe31d94c
PE
5018 * editfns.c (time_overflow): New function, refactoring common code.
5019 (Fformat_time_string, Fdecode_time, Fencode_time):
5020 (Fcurrent_time_string): Use it.
5021
8be6f318
PE
5022 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5023 * dired.c (make_time): Move to ...
5024 * editfns.c (make_time): ... here.
5025 * systime.h: Note the move.
5026
09d9db2c 50272011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5028
126bc0dc
YM
5029 * fringe.c (update_window_fringes): Remove unused variables.
5030
c47cbdfd
YM
5031 * unexmacosx.c (copy_data_segment): Also copy __got section.
5032 (Bug#8223)
5033
7ac80be9
EZ
50342011-03-12 Eli Zaretskii <eliz@gnu.org>
5035
c96bbc66 5036 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5037 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5038 Constify `char *' arguments and their references according to
5039 prototypes in tparam.h.
5040
ecb0f94d 5041 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5042
7ac80be9
EZ
5043 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5044 Adapt all references accordingly.
5045
5046 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5047
ef1fd07e
TT
50482011-03-11 Tom Tromey <tromey@redhat.com>
5049
5050 * buffer.c (syms_of_buffer): Remove obsolete comment.
5051
7ef4b50c
EZ
50522011-03-11 Eli Zaretskii <eliz@gnu.org>
5053
5054 * termhooks.h (encode_terminal_code): Declare prototype.
5055
5056 * msdos.c (encode_terminal_code): Don't declare prototype.
5057
5058 * term.c (encode_terminal_code): Now external again, used by
5059 w32console.c and msdos.c.
5060
44f230aa
SM
5061 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5062 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5063
4b1ec863 50642011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5065
1714f52b 5066 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5067
4b1ec863
PE
5068 * fringe.c (update_window_fringes): Mark locals as initialized
5069 (Bug#8227).
5070 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5071
524c7aa6
PE
5072 * alloc.c (mark_fringe_data): Move decl from here ...
5073 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5074 to check its interface.
5075 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5076
a5c0af81 5077 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5078 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5079 (fontset_font): Mark local as initialized.
a9a06e0b 5080 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5081
b4716021
PE
5082 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5083
811e9bac 5084 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5085 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5086 (x_own_selection, Fx_disown_selection_internal): Rename locals
5087 to avoid shadowing.
5088 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5089
7e3ab302
PE
5090 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5091 so that the caller can use some name other than gcpro1.
5092 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5093 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5094 (Fx_backspace_delete_keys_p):
5095 Use them to avoid shadowing, and rename vars to avoid shadowing.
5096 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5097 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5098 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5099 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5100 Remove unused locals.
7e3ab302
PE
5101 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5102 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5103 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5104 macros.
f78faa98 5105
e2b13473
PE
5106 * xterm.h (x_mouse_leave): New decl.
5107
77f23912
PE
5108 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5109 Remove unused functions.
cdf4ba58
PE
5110 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5111 (x_calc_absolute_position): Now static.
7411c686 5112 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5113 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5114 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5115 unless they are used.
38d0b34a
PE
5116 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5117 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5118 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5119 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5120 (x_error_catcher, x_connection_closed, x_error_handler):
5121 (x_error_quitter, xembed_send_message, x_iconify_frame):
5122 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5123 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5124 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5125
44f230aa
SM
5126 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5127 Rename or move locals to avoid shadowing.
6b463e58 5128 (tty_defined_color, merge_face_heights): Now static.
5967d051 5129 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5130 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5131 does not deduce is never used uninitialized.
73719eba
PE
5132 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5133 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5134
426994c3 5135 * terminal.c (store_terminal_param): Now static.
5489860b 5136
032f1620 5137 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5138 (set_frame_menubar): Remove unused local.
d4323972 5139 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5140 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5141 since they might point to immutable storage.
281585b0
PE
5142 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5143 since it's unused otherwise.
032f1620 5144
367c19e5 5145 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5146 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5147 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5148 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5149 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5150 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5151 does not deduce are never used uninitialized.
70739cbe 5152
07b48fa9
PE
5153 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5154
8868a238 5155 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5156 * window.c (window_loop, size_window):
5157 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5158
7e5cf297 5159 * window.c (display_buffer): Now static.
d6550a9f
PE
5160 (size_window): Mark variables that gcc -Wuninitialized
5161 does not deduce are never used uninitialized.
a586633d
PE
5162 * window.h (check_all_windows): New decl, to forestall
5163 gcc -Wmissing-prototypes diagnostic.
5b555da1 5164 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5165
f6095868
PE
5166 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5167 shadowing.
5168 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5169 Include <limits.h>.
5170 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5171 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5172 (load_charset_map): Mark variables that gcc -Wuninitialized
5173 does not deduce are never used uninitialized.
53df7c11 5174 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5175
f38b440c
PE
5176 * coding.c (coding_set_source, coding_set_destination):
5177 Use "else { /* comment */ }" rather than "else /* comment */;"
5178 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5179 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5180 a block, when the outer 'i' will do.
5181 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5182 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5183 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5184 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5185 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5186 Rename locals to avoid shadowing.
5187 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5188 * coding.c (emacs_mule_char, encode_invocation_designation):
5189 Now static, since they're not used elsewhere.
413bb2db 5190 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5191 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5192 (decode_coding_emacs_mule): Mark variables that gcc
5193 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5194 (detect_coding_iso_2022): Initialize a local variable that might
5195 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5196 this initialization is needed. (Bug#8211)
5f58e762
PE
5197 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5198 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5199 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5200 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5201 Remove unused macros.
f38b440c 5202
232b38b9 5203 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5204 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5205 * character.c (string_count_byte8): Likewise.
232b38b9 5206
fb90da1b
PE
5207 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5208 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5209
fb93dbc2
PE
5210 * chartab.c (copy_sub_char_table): Now static, since it's not used
5211 elsewhere.
5c156ace
PE
5212 (sub_char_table_ref_and_range, char_table_ref_and_range):
5213 Rename locals to avoid shadowing.
bbcd0949 5214 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5215
7d3b3862 5216 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5217 (BIDI_BOB): Remove unused macro.
7d3b3862 5218
6be7d3da
PE
5219 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5220 deduce are never used uninitialized.
c2ed9c8b 5221 * term.c (encode_terminal_code): Likewise.
6be7d3da 5222
75f8807f 5223 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5224
50938595
PE
5225 * tparam.h: New file.
5226 * term.c, tparam.h: Include it.
5227 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5228 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5229 Move these decls to tparam.h, and make them agree with what
5230 is actually in tparam.c. The previous trick of using incompatible
5231 decls in different modules does not conform to the C standard.
5232 All callers of tparam changed to use tparam's actual API.
5233 * tparam.c (tparam1, tparam, tgoto):
5234 Use const pointers where appropriate.
5235
fbceeba2
PE
5236 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5237 * cm.h (struct cm): Likewise.
5238 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5239 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5240 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5241 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5242 (turn_on_face, init_tty): Likewise.
5243 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5244
7f3f1250
PE
5245 * term.c (term_mouse_position): Rename local to avoid shadowing.
5246
e6ca6543
PE
5247 * alloc.c (mark_ttys): Move decl from here ...
5248 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5249
c40f8d15
AS
52502011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5251
5252 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5253
cfe0661d
JB
52542011-03-09 Juanma Barranquero <lekktu@gmail.com>
5255
5256 * search.c (compile_pattern_1): Remove argument regp, unused since
5257 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5258 (compile_pattern): Don't pass it.
5259
0afb4571
J
52602011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5261
5262 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5263 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5264 for ! HAVE_GTK3.
5265 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5266
5267 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5268
5269 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5270 gdk_window_get_screen, gdk_window_get_geometry,
5271 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5272 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5273 (xg_get_pixbuf_from_pixmap): New function.
5274 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5275 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5276 Call xg_get_pixbuf_from_pixmap instead of
5277 gdk_pixbuf_get_from_drawable.
5278 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5279 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5280 (xg_check_special_colors): Use GtkStyleContext and its functions
5281 for HAVE_GTK3.
5282 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5283 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5284 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5285 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5286 Call gtk_widget_get_preferred_size.
0afb4571
J
5287 (xg_frame_resized): gdk_window_get_geometry only takes 5
5288 parameters.
44f230aa
SM
5289 (xg_win_to_widget, xg_event_is_for_menubar):
5290 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5291 (xg_set_widget_bg): New function.
5292 (delete_cb): New function.
895009e1 5293 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5294 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5295 (xg_set_background_color): Call xg_set_widget_bg.
5296 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5297 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5298 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5299 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5300 if ! HAVE_GTK3.
5301 (update_frame_tool_bar): Call gtk_widget_hide.
5302 (xg_initialize): Use GDK_KEY_g.
5303
5304 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5305 if ! HAVE_GTK3
5306 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5307
5308 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5309 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5310 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5311
1c2cc4ef
JB
53122011-03-08 Juanma Barranquero <lekktu@gmail.com>
5313
5314 * w32xfns.c (select_palette): Check success of RealizePalette against
5315 GDI_ERROR, not zero.
5316
33383987 5317See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5318
5319;; Local Variables:
5320;; coding: utf-8
aac0c6e3
MR
5321;; End:
5322
33383987 5323 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5324
5325 This file is part of GNU Emacs.
5326
5327 GNU Emacs is free software: you can redistribute it and/or modify
5328 it under the terms of the GNU General Public License as published by
5329 the Free Software Foundation, either version 3 of the License, or
5330 (at your option) any later version.
5331
5332 GNU Emacs is distributed in the hope that it will be useful,
5333 but WITHOUT ANY WARRANTY; without even the implied warranty of
5334 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5335 GNU General Public License for more details.
5336
5337 You should have received a copy of the GNU General Public License
5338 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.