Delete char-direction-table and char-direction.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fa6996bc
EZ
12011-04-24 Eli Zaretskii <eliz@gnu.org>
2
3 * character.c (Fchar_direction): Function deleted.
4 (syms_of_character): Don't defsubr it.
5 <char-direction-table>: Deleted.
6
e6c3da20
EZ
72011-04-23 Eli Zaretskii <eliz@gnu.org>
8
9 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10 * doprnt.c: Include limits.h.
11 (SIZE_MAX): New macro.
12 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
13 local variables are now size_t instead of int or unsigned.
14 Improve overflow protection. Support `l' modifier for integer
15 conversions. Support %l conversion. Don't assume an EMACS_INT
16 argument for integer conversions and for %c.
17
18 * lisp.h (doprnt): Restore prototype.
19
20 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
21 $(SRC)/character.h.
22
23 * Makefile.in (base_obj): Add back doprnt.o.
24
25 * deps.mk (doprnt.o): Add back prerequisites.
26 (callint.o): Depend on character.h.
27
28 * eval.c (internal_lisp_condition_case): Include the handler
29 representation in the error message.
30 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
31 when breaking from the loop.
32
33 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
34
35 * callint.c (Fcall_interactively): When displaying error message
36 about invalid control letter, pass the character's codepoint, not
37 a pointer to its multibyte form. Improve display of the character
38 in octal and display also its hex code.
39
40 * character.c (char_string): Use %x to display the (unsigned)
41 codepoint of an invalid character, to avoid displaying a bogus
42 negative value.
43
44 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
45 `error', not SYMBOL_NAME itself.
46
47 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
48 character arguments to `error'.
49
50 * charset.c (check_iso_charset_parameter): Fix incorrect argument
51 to `error' in error message about FINAL_CHAR argument. Make sure
52 FINAL_CHAR is a character, and use %c when it is passed as
53 argument to `error'.
54
4ffd0d6b 552011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
56
57 * s/ms-w32.h (localtime): Redirect to sys_localtime.
58
59 * w32.c: Include <time.h>.
60 (sys_localtime): New function.
61
4ffd0d6b 622011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
63
64 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
65
4ffd0d6b 66 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 67
4ffd0d6b 682011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 69
4ffd0d6b
GM
70 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
71 zombies (Bug#8467).
aac0c6e3 72
04c56954
EZ
732011-04-19 Eli Zaretskii <eliz@gnu.org>
74
75 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
76 gl_state.e_property when gl_state.object is Qt.
77
78 * insdel.c (make_gap_larger): Remove limitation of buffer size
79 to <= INT_MAX.
80
16a43933
CY
812011-04-18 Chong Yidong <cyd@stupidchicken.com>
82
83 * xdisp.c (lookup_glyphless_char_display)
84 (produce_glyphless_glyph): Handle cons cell entry in
85 glyphless-char-display.
86 (Vglyphless_char_display): Document it.
87
88 * term.c (produce_glyphless_glyph): Handle cons cell entry in
89 glyphless-char-display.
90
4581706e
CY
912011-04-17 Chong Yidong <cyd@stupidchicken.com>
92
93 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
94
95 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
96
97 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
98 definition for no-X builds.
99
4887c6e2 1002011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 101
fd35b6f9
PE
102 Static checks with GCC 4.6.0 and non-default toolkits.
103
5c1ccb01
PE
104 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
105
006c5daa
PE
106 * process.c (keyboard_bit_set): Define only if SIGIO.
107 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
108 (send_process): Repair possible setjmp clobbering.
109
efc736d3
PE
110 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
111
4e2fe2e6
PE
112 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
113
f97334a2
PE
114 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
115
4e75f29d
PE
116 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
117 Define only if needed.
118
90efadd1
PE
119 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
120 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 121 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 122
3c647824
PE
123 * dispextern.h (struct redisplay_interface): Rename param
124 to avoid shadowing.
e264f262 125 * termhooks.h (struct terminal): Likewise.
761383f4 126 * xterm.c (xembed_send_message): Likewise.
3c647824 127
b58c5c4a
PE
128 * insdel.c (make_gap_smaller): Define only if
129 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
130
cad59032
PE
131 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
132 it.
133
c339dc2e
PE
134 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
135 so that we aren't warned about unused symbols.
136
91a3e27b
PE
137 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
138
399c71d3 139 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 140
8ffc96f5
PE
141 * xfns.c (x_real_positions): Mark locals as initialized.
142
eef9bc79
PE
143 * xmenu.c (xmenu_show): Don't use uninitialized vars.
144
098db9dd
PE
145 * xterm.c: Fix problems found by static analysis with other toolkits.
146 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
147 (x_dispatch_event): Declare static if USE_GTK, and
148 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 149 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 150 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
151 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
152 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
153
eb18f6cc
PE
154 * xmenu.c (menu_help_callback): Pointer type fixes.
155 Use const pointers when pointing at readonly data. Avoid pointer
156 signedness clashes.
157 (FALSE): Remove unused macro.
158 (update_frame_menubar): Remove unused decl.
159
1fe72bf8
PE
160 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
161
60d9e1db
PE
162 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
163 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
164 (single_menu_item): Rename local to avoid shadowing.
165
39261c26
PE
166 * keyboard.c (make_lispy_event): Remove unused local var.
167
018c5e19
PE
168 * frame.c, frame.h (x_get_resource_string): Bring this back, but
169 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
170
63d2b86e
PE
171 * bitmaps: Change bitmaps from unsigned char back to the X11
172 compatible char. Avoid the old compiler warnings about
173 out-of-range initializers by using, for example, '\xab' rather
174 than 0xab.
175
aefd87e1
PE
176 * xgselect.c (xgselect_initialize): Check vs interface
177 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
178
bf501fb9
PE
179 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
180
e9829fdf
PE
181 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
182 to read-only memory.
183
1086c095
PE
184 * fns.c (vector): Remove; this old hack is no longer needed.
185
2baccd04 186 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 187 Remove unused var.
dde42981 188 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 189
72391843 190 * xrdb.c (x_load_resources): Omit unused local.
3565b346 191
436c16df 192 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 193 (x_window): Rename locals to avoid shadowing.
dc5ddd85 194 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 195
92bb796d 196 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 197 (x_term_init): Remove local to avoid shadowing.
92bb796d 198
764430a3 199 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
200
201 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
202 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
203
d1dfb56c
EZ
2042011-04-16 Eli Zaretskii <eliz@gnu.org>
205
c4354cb4
EZ
206 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
207
d1dfb56c
EZ
208 Fix regex.c, syntax.c and friends for buffers > 2GB.
209 * syntax.h (struct gl_state_s): Declare character position members
210 EMACS_INT.
211
212 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
213
214 * textprop.c (verify_interval_modification, interval_of): Declare
215 arguments EMACS_INT.
216
217 * intervals.c (adjust_intervals_for_insertion): Declare arguments
218 EMACS_INT.
219
220 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
221
222 * indent.c (Fvertical_motion): Local variable it_start is now
223 EMACS_INT.
224
225 * regex.c (re_match, re_match_2, re_match_2_internal)
226 (bcmp_translate, regcomp, regexec, print_double_string)
227 (group_in_compile_stack, re_search, re_search_2, regex_compile)
228 (re_compile_pattern, re_exec): Declare arguments and local
229 variables `size_t' and `ssize_t' and return values `regoff_t', as
230 appropriate.
231 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
232 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
233 <compile_stack_type>: `size' and `avail' are now `size_t'.
234
235 * regex.h <regoff_t>: Use ssize_t, not int.
236 (re_search, re_search_2, re_match, re_match_2): Arguments that
237 specify buffer/string position and length are now ssize_t and
238 size_t. Return type is regoff_t.
239
613052cd
BK
2402011-04-16 Ben Key <bkey76@gmail.com>
241
242 * nsfont.m: Fixed bugs in ns_get_family and
243 ns_descriptor_to_entity that were caused by using free to
244 deallocate memory blocks that were allocated by xmalloc (via
245 xstrdup). This caused Emacs to crash when compiled with
246 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
247 --enable-checking=xmallocoverrun). xfree is now used to
248 deallocate these memory blocks.
249
4170f62f 2502011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 251
71b41406
PE
252 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
253
9587a89d
PE
254 emacs_write: Accept and return EMACS_INT for sizes.
255 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
256 et seq.
257 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
258 Accept and return EMACS_INT.
259 (emacs_gnutls_write): Return the number of bytes written on
260 partial writes.
261 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
262 (emacs_read, emacs_write): Remove check for negative size, as the
263 Emacs source code has been audited now.
9587a89d
PE
264 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
265 (emacs_read, emacs_write): Use it.
273a5f82
PE
266 * process.c (send_process): Adjust to the new signatures of
267 emacs_write and emacs_gnutls_write. Do not attempt to store
268 a byte offset into an 'int'; it might overflow.
9587a89d 269 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 270
3e047f51
PE
271 * sound.c: Don't assume sizes fit in 'int'.
272 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 273 Return EMACS_INT, not int.
3e047f51 274 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
275 Accept EMACS_INT, not int.
276 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
277 record read return values.
278
cc39a9db
BK
2792011-04-15 Ben Key <bkey76@gmail.com>
280
c9d0ec6d
JB
281 * keyboard.c (Qundefined): Don't declare static since it is used
282 in nsfns.m.
283 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
284 static since they are used in nsfont.m.
cc39a9db 285
6c60eb9f
SM
2862011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * process.c (Qprocessp): Don't declare static.
289 * lisp.h (Qprocessp): Declare again.
290
7990b61a
JB
2912011-04-15 Juanma Barranquero <lekktu@gmail.com>
292
293 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
294
5d4cb038
PE
2952011-04-14 Paul Eggert <eggert@cs.ucla.edu>
296
8bd7b830 297 Improve C-level modularity by making more things 'static'.
cd64ea1d 298
e3b27b31
PE
299 Don't publish debugger-only interfaces to other modules.
300 * lisp.h (safe_debug_print, debug_output_compilation_hack):
301 (verify_bytepos, count_markers): Move decls to the only modules
302 that need them.
303 * region-cache.h (pp_cache): Likewise.
304 * window.h (check_all_windows): Likewise.
305 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
306
5d4cb038
PE
307 * sysdep.c (croak): Now static, if
308 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
309 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
310
311 * alloc.c (refill_memory_reserve): Now static if
312 !defined REL_ALLOC || defined SYSTEM_MALLOC.
313 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 314
e87b6180
PE
315 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
316 Define only if USE_LUCID.
317
ac64929e
PE
318 * xrdb.c (x_customization_string, x_rm_string): Now static.
319
6f37259d
PE
320 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
321 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
322
1683e3ab
PE
323 * xdisp.c (draw_row_with_mouse_face): Now static.
324 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
325
de9c2632
PE
326 * window.h (check_all_windows): Mark externally visible.
327
2b96acb7
PE
328 * window.c (window_deletion_count): Now static.
329
330 * undo.c: Make symbols static if they're not exported.
331 (last_undo_buffer, last_boundary_position, pending_boundary):
332 Now static.
333
50436f33
PE
334 * textprop.c (interval_insert_behind_hooks): Now static.
335 (interval_insert_in_front_hooks): Likewise.
336
64520e5c
PE
337 * term.c: Make symbols static if they're not exported.
338 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
339 (max_frame_lines, tty_set_terminal_modes):
340 (tty_reset_terminal_modes, tty_turn_off_highlight):
341 (get_tty_terminal): Now static.
342 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
343 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 344 HAVE_WINDOW_SYSTEM.
64520e5c
PE
345 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
346 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
347
1fa53021
PE
348 * sysdep.c: Make symbols static if they're not exported.
349 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
350 Now static.
351 (sigprocmask_set, full_mask): Remove; unused.
352 (wait_debugging): Mark as visible.
353 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
354 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
355
d4b43b22
PE
356 * syntax.c (syntax_temp): Define only if !__GNUC__.
357
b7c513d0
PE
358 * sound.c (current_sound_device, current_sound): Now static.
359
989b29ad
PE
360 * search.c (searchbufs, searchbuf_head): Now static.
361
13a55a78
PE
362 * scroll.c (scroll_cost): Remove; unused.
363 * dispextern.h (scroll_cost): Remove decl.
364
de68a1fc
PE
365 * region-cache.h (pp_cache): Mark as externally visible.
366
40ccffa6
PE
367 * process.c: Make symbols static if they're not exported.
368 (process_tick, update_tick, create_process, chan_process):
369 (Vprocess_alist, proc_buffered_char, datagram_access):
370 (fd_callback_data, send_process_frame, process_sent_to): Now static.
371 (deactivate_process): Mark defn as static, as well as decl.
372 * lisp.h (create_process): Remove decl.
373 * process.h (chan_process, Vprocess_alist): Remove decls.
374
ad64fc97
PE
375 * print.c: Make symbols static if they're not exported.
376 (print_depth, new_backquote_output, being_printed, print_buffer):
377 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
378 (print_interval, print_number_index, initial_stderr_stream):
379 Now static.
380 * lisp.h (Fprinc): Remove decl.
381 (debug_output_compilation_hack): Mark as externally visible.
382
adddb265
PE
383 * sysdep.c (croak): Move decl from here to syssignal.h.
384 * syssignal.h (croak): Put it here, so the API can be checked when
385 'croak' is called from dissociate_if_controlling_tty.
386
1717ede2
PE
387 * minibuf.c: Make symbols static if they're not exported.
388 (minibuf_save_list, choose_minibuf_frame): Now static.
389 * lisp.h (choose_minibuf_frame): Remove decl.
390
fa5fb2bc
PE
391 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
392
1e3890d1
PE
393 * lread.c: Make symbols static if they're not exported.
394 (read_objects, initial_obarray, oblookup_last_bucket_number):
395 Now static.
396 (make_symbol): Remove; unused.
397 * lisp.h (initial_obarray, make_symbol): Remove decls.
398
8a1414fa
PE
399 * keyboard.c: Make symbols static if they're not exported.
400 (single_kboard, recent_keys_index, total_keys, recent_keys):
401 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
402 (this_single_command_key_start, echoing, last_auto_save):
403 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
404 (command_loop, echo_now, keyboard_init_hook, help_char_p):
405 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
406 (Vlispy_mouse_stem, double_click_count):
407 Now static.
408 (force_auto_save_soon): Define only if SIGDANGER.
409 (ignore_mouse_drag_p): Now static if
410 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
411 (print_help): Remove; unused.
412 (stop_character, last_timer_event): Mark as externally visible.
413 * keyboard.h (ignore_mouse_drag_p): Declare only if
414 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
415 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
416 * lisp.h (echoing): Remove decl.
417 (force_auto_save_soon): Declare only if SIGDANGER.
418 * xdisp.c (redisplay_window): Simplify code, to make it more
419 obvious that ignore_mouse_drag_p is not accessed if !defined
420 USE_GTK && !defined HAVE_NS.
421
93ea6e8f
PE
422 * intervals.c: Make symbols static if they're not exported.
423 (merge_properties_sticky, merge_interval_right, delete_interval):
424 Now static.
425 * intervals.h (merge_interval_right, delete_interval): Remove decls.
426
77382fcc
PE
427 * insdel.c: Make symbols static if they're not exported.
428 However, leave prepare_to_modify_buffer alone. It's never
429 called from outside this function, but that appears to be a bug.
430 (combine_after_change_list, combine_after_change_buffer):
4889fc82 431 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
432 (adjust_after_replace_noundo): Remove; unused.
433 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 434 (signal_before_change): Remove decls.
77382fcc 435
9306c32e
PE
436 * indent.c (val_compute_motion, val_vmotion): Now static.
437
cd44d2eb
PE
438 * image.c: Make symbols static if they're not exported.
439 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
440 if USE_GTK.
441 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
442 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
443
ad9a7a06
PE
444 * fringe.c (standard_bitmaps): Now static.
445 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
446
81626931
PE
447 * frame.c: Make symbols static if they're not exported.
448 (x_report_frame_params, make_terminal_frame): Now static.
449 (get_frame_param): Now static, unless HAVE_NS.
450 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
451 (x_get_resource_string): Remove; not used.
452 * frame.h (make_terminal_frame, x_report_frame_params):
453 (x_get_resource_string); Remove decls.
454 (x_fullscreen_adjust): Declare only if WINDOWSNT.
455 * lisp.h (get_frame_param): Declare only if HAVE_NS.
456
239f9db9
PE
457 * font.c, fontset.c: Make symbols static if they're not exported.
458 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
459 (FACE_SUITABLE_FOR_CHAR_P): Use it.
460 * font.c (font_close_object): Now static.
461 * font.h (font_close_object): Remove.
462 * fontset.c (FONTSET_OBJLIST): Remove.
463 (free_realized_fontset) #if-0 the body, which does nothing.
464 (face_suitable_for_char_p): #if-0, as it's never called.
465 * fontset.h (face_suitable_for_char_p): Remove decl.
466 * xfaces.c (face_at_string_position): Use
467 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
468 since 0 is always ASCII.
469
dfcf3579
PE
470 * fns.c (weak_hash_tables): Now static.
471
5045092b
PE
472 * fileio.c: Make symbols static if they're not exported.
473 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
474 (Vwrite_region_annotation_buffers): Now static.
475
57a96f5c
PE
476 * eval.c: Make symbols static if they're not exported.
477 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
478 * lisp.h (backtrace_list): Remove decl.
479
35f08c38
PE
480 * emacs.c: Make symbols static if they're not exported.
481 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
482 (fatal_error_code, fatal_error_signal_hook, standard_args):
483 Now static.
484 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
485 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
486 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
487 * lisp.h (fatal_error_signal_hook): Remove decl.
488 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
489
f44bd759
PE
490 * editfns.c: Move a (normally-unused) function to its only use.
491 * editfns.c, lisp.h (get_operating_system_release): Remove.
492 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
493 worth the hassle of breaking this out.
494
b532497d
PE
495 * xterm.c: Make symbols static if they're not exported.
496 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
497 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
498 (x_destroy_window, x_delete_display):
499 Now static.
500 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
501 (x_mouse_leave): Remove; unused.
502 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
503 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
504 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
505 Remove decls.
506 (x_mouse_leave): Declare only if WINDOWSNT.
507 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
508 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
509 USE_X_TOOLKIT.
510
1675728f
PE
511 * ftxfont.c: Make symbols static if they're not exported.
512 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
513 HAVE_FREETYPE.
514 * font.h (ftxfont_driver): Likewise.
515
e4cebfca
PE
516 * xfns.c: Make symbols static if they're not exported.
517 (x_last_font_name, x_display_info_for_name):
518 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
519 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
520 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
521 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
522 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
523 (last_show_tip_args): Now static.
524 (xic_defaut_fontset, xic_create_fontsetname): Define only if
525 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
526 (x_screen_planes): Remove; unused.
527 * dispextern.h (x_screen_planes): Remove decl.
528
5bf46f05
PE
529 * dispnew.c: Make symbols static if they're not exported.
530 * dispextern.h (redraw_garbaged_frames, scrolling):
531 (increment_row_positions): Remove.
532 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
533 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
534 Now static.
535 (redraw_garbaged_frames): Remove; unused.
536
435f4c28
PE
537 * xfaces.c: Make symbols static if they're not exported.
538 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
539 Remove decls.
540 * xterm.h (defined_color): Remove decls.
541 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
542 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
543 (menu_face_changed_default, defined_color, free_realized_face):
544 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
545 (ascii_face_of_lisp_face): Remove; unused.
546
8524aef3
PE
547 * xdisp.c: Make symbols static if they're not exported.
548 * dispextern.h (scratch_glyph_row, window_box_edges):
549 (glyph_to_pixel_coords, set_cursor_from_row):
550 (get_next_display_element, set_iterator_to_next):
551 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
552 (show_mouse_face): Remove decls
553 * frame.h (message_buf_print): Likewise.
554 * lisp.h (pop_message, set_message, check_point_in_composition):
555 Likewise.
556 * xterm.h (set_vertical_scroll_bar): Likewise.
557 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
558 (message_buf_print, scratch_glyph_row, displayed_buffer):
559 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
560 (get_next_display_element, show_mouse_face, window_box_edges):
561 (frame_to_window_pixel_xy, check_point_in_composition):
562 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
563 (glyph_to_pixel_coords): Remove; unused.
564
16390cd2
PE
565 * dired.c (file_name_completion): Now static.
566
567 * dbusbind.c (xd_in_read_queued_messages): Now static.
568
a25f4dfa
PE
569 * lisp.h (circular_list_error, FOREACH): Remove; unused.
570 * data.c (circular_list_error): Remove.
571
14a9c8df
PE
572 * commands.h (last_point_position, last_point_position_buffer):
573 (last_point_position_window): Remove decls.
574 * keyboard.c: Make these variables static.
575
74ab6df5
PE
576 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
577 decls.
578 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
579 (iso_code_class, detect_coding, code_convert_region): Now static.
580 (encode_coding_gap): Remove; unused.
581
38dfbee1
PE
582 * chartab.c (chartab_chars, chartab_bits): Now static.
583
a2cb4e63
PE
584 * charset.h (charset_iso_8859_1): Remove decl.
585 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
586 Now static.
587
127198fd
PE
588 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
589 * ccl.c (Vccl_program_table): Now static.
590 (check_ccl_update): Remove; unused.
591
d85b608f
PE
592 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
593 * category.h: ... from here.
594 * category.c (check_category_table, set_category_set): Now static.
595
31cd66f3
PE
596 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
597 * lisp.h: Remove these decls.
598
c358e587
PE
599 * buffer.c (buffer_count): Remove unused var.
600
e78aecca
PE
601 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
602 so that it's not optimized away.
603 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
604 * dispextern.h (bidi_dump_cached_states): Remove, since it's
605 exported only to the debugger.
606
e192d7d3
PE
607 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
608 * atimer.h (run_all_atimers): Removed; not exported.
609
92470028
PE
610 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
611 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
612 was inaccessible from Lisp.
613 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
614 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
615
244ed907
PE
616 alloc.c: Import and export fewer symbols, and remove unused items.
617 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
618 is defined.
619 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
620 it's not optimized away by whole-program optimization.
621 (message_enable_multibyte, free_misc): Remove.
622 (catchlist, handlerlist, mark_backtrace):
623 Declare only if BYTE_MARK_STACK.
624 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
625 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
626 (message_enable_multibyte): Remove decl.
627 (free_misc, interval_free_list, float_block, float_block_index):
628 (n_float_blocks, float_free_list, cons_block, cons_block_index):
629 (cons_free_list, last_marked_index):
630 Now static.
631 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
632 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
633 (mark_backtrace): Define only if BYTE_MARK_STACK.
634 * xdisp.c (message_enable_multibyte): Now static.
635
61c2b50e 636 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
637 This makes it easier for human readers (and static analyzers)
638 to see whether these variables are used from other modules.
639 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
640 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
641 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
642 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
643 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
644 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
645 * xmenu.c, xselect.c:
646 Declare Q* vars static if they are not used in other modules.
647 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
648 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
649 Remove decls of unexported vars.
650 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
651
95c82688
PE
652 * lisp.h (DEFINE_FUNC): Make sname 'static'.
653
16a97296
PE
654 Make Emacs functions such as Fatom 'static' by default.
655 This makes it easier for human readers (and static analyzers)
656 to see whether these functions can be called from other modules.
657 DEFUN now defines a static function. To make the function external
658 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
659 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
660 (Finit_image_library):
16a97296
PE
661 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
662 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
663 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
664 Remove decls, since these functions are now static.
665 (Funintern, Fget_internal_run_time): New decls, since these functions
666 were already external.
95c82688 667
16a97296
PE
668 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
669 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
670 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
671 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
672 * keyboard.c, keymap.c, lread.c:
673 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
674 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
675 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
676 Mark functions with DEFUE instead of DEFUN,
677 if they are used in other modules.
678 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
679 decls for now-static functions.
680 * buffer.h (Fdelete_overlay): Remove decl.
681 * callproc.c (Fgetenv_internal): Mark as internal.
682 * composite.c (Fremove_list_of_text_properties): Remove decl.
683 (Fcomposition_get_gstring): New forward static decl.
684 * composite.h (Fcomposite_get_gstring): Remove decl.
685 * dired.c (Ffile_attributes): New forward static decl.
686 * doc.c (Fdocumntation_property): New forward static decl.
687 * eval.c (Ffetch_bytecode): New forward static decl.
688 (Funintern): Remove extern decl; now in .h file where it belongs.
689 * fileio.c (Fmake_symbolic_link): New forward static decl.
690 * image.c (Finit_image_library): New forward static decl.
691 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
692 * intervals.h (Fprevious_property_change):
693 (Fremove_list_of_text_properties): Remove decls.
694 * keyboard.c (Fthis_command_keys): Remove decl.
695 (Fcommand_execute): New forward static decl.
696 * keymap.c (Flookup_key): New forward static decl.
697 (Fcopy_keymap): Now static.
698 * keymap.h (Flookup_key): Remove decl.
699 * process.c (Fget_process): New forward static decl.
700 (Fprocess_datagram_address): Mark as internal.
701 * syntax.c (Fsyntax_table_p): New forward static decl.
702 (skip_chars): Remove duplicate decl.
703 * textprop.c (Fprevious_property_change): New forward static decl.
704 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
705 Now internal.
706 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
707 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
708
785bbd42
PE
709 * editfns.c (Fformat): Remove unreachable code.
710
8b913b57
AS
7112011-04-14 Andreas Schwab <schwab@linux-m68k.org>
712
713 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
714 change. (Bug#8496)
715
a6744a35
EZ
7162011-04-13 Eli Zaretskii <eliz@gnu.org>
717
718 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
719 when at ZV. (Bug#8487)
720
e7974947
AS
7212011-04-12 Andreas Schwab <schwab@linux-m68k.org>
722
baad03f0
AS
723 * charset.c (Fclear_charset_maps): Use xfree instead of free.
724 (Bug#8437)
725 * keyboard.c (parse_tool_bar_item): Likewise.
726 * sound.c (sound_cleanup, alsa_close): Likewise.
727 * termcap.c (tgetent): Likewise.
728 * xfns.c (x_default_font_parameter): Likewise.
729 * xsettings.c (read_and_apply_settings): Likewise.
730
e7974947
AS
731 * alloc.c (overrun_check_malloc, overrun_check_realloc)
732 (overrun_check_free): Protoize.
733
28272684
PE
7342011-04-12 Paul Eggert <eggert@cs.ucla.edu>
735
736 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
737 since callers should never pass a negative size.
738 Change the signature to match that of plain 'read' and 'write'; see
739 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
740 * lisp.h: Update prototypes of emacs_write and emacs_read.
741
11997c76
EZ
7422011-04-11 Eli Zaretskii <eliz@gnu.org>
743
744 * xdisp.c (redisplay_window): Don't try to determine the character
745 position of the scroll margin if the window start point w->startp
e896f03c 746 is outside the buffer's accessible region. (Bug#8468)
11997c76 747
8a2cbd72
EZ
7482011-04-10 Eli Zaretskii <eliz@gnu.org>
749
750 Fix write-region and its subroutines for buffers > 2GB.
751 * fileio.c (a_write, e_write): Modify declaration of arguments and
752 local variables to support buffers larger than 2GB.
753 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
754
755 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
756 argument, local variables, and return value.
757
758 * lisp.h: Update prototypes of emacs_write and emacs_read.
759
760 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
761
4073e537 7622011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 763
1ebfdcb6
PE
764 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
765
b2ded58d
PE
766 Fix more problems found by GCC 4.6.0's static checks.
767
7d66342c
PE
768 * xdisp.c (vmessage): Use a better test for character truncation.
769
bbf47d44
PE
770 * charset.c (load_charset_map): <, not <=, for optimization,
771 and to avoid potential problems with integer overflow.
9248994d 772 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 773 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 774 * editfns.c (Fformat): Likewise.
1e69125e 775 * syntax.c (skip_chars): Likewise.
3befa583 776
e3019616
PE
777 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
778 This also lets GCC 4.6.0 generate slightly better loop code.
779
becfa255
PE
780 * callint.c (Fcall_interactively): <, not <=, for optimization.
781 (Fcall_interactively): Count the number of arguments produced,
782 not the number of arguments given. This is simpler and lets GCC
783 4.6.0 generate slightly better code.
784
dae0cd48
PE
785 * ftfont.c: Distingish more carefully between FcChar8 and char.
786 The previous code passed unsigned char * to a functions like
787 strlen and xstrcasecmp that expect char *, which does not
788 conform to the C standard.
789 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
790 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
791 char * when the C standard requires it.
792
76032d70
PE
793 * keyboard.c (read_char): Remove unused var.
794
eb3f1cc8
PE
795 * eval.c: Port to Windows vsnprintf (Bug#8435).
796 Include <limits.h>.
797 (SIZE_MAX): Define if the headers do not.
798 (verror): Do not give up if vsnprintf returns a negative count.
799 Instead, grow the buffer. This ports to Windows vsnprintf, which
800 does not conform to C99. Problem reported by Eli Zaretskii.
801 Also, simplify the allocation scheme, by avoiding the need for
802 calling realloc, and removing the ALLOCATED variable.
803
70476b54
PE
804 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
805
12020a9e
PE
806 Remove invocations of doprnt, as Emacs now uses vsnprintf.
807 But keep the doprint source code for now, as we might revamp it
808 and use it again (Bug#8435).
ea6c7ae6
PE
809 * lisp.h (doprnt): Remove.
810 * Makefile.in (base_obj): Remove doprnt.o.
811 * deps.mk (doprnt.o): Remove.
812
5fdb398c
PE
813 error: Print 32- and 64-bit integers portably (Bug#8435).
814 Without this change, on typical 64-bit hosts error ("...%d...", N)
815 was used to print both 32- and 64-bit integers N, which relied on
816 undefined behavior.
817 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
818 New macro.
819 * lisp.h (error, verror): Mark as printf-like functions.
820 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
821 Report overflow in size calculations when allocating printf buffer.
822 Do not truncate output string at its first null byte.
823 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
824 Truncate the output at a character boundary, since vsnprintf does not
825 do that.
826 * charset.c (check_iso_charset_parameter): Convert internal
827 character to string before calling 'error', since %c now has the
828 printf meaning.
829 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
830 overflow when computing char to be passed to 'error'. Do not
831 pass Lisp_Object to 'error'; pass the integer instead.
832 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
833 formatted with plain %d.
834
b189fa66
PE
835 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
836
bff87ef0
PE
837 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
838
7e2cac20
PE
839 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
840
ce4d90b5
PE
841 * xterm.c (x_catch_errors): Remove duplicate declaration.
842
266c9547
PE
843 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
844
79c49ad2
PE
845 * xdisp.c, lisp.h (message_nolog): Remove; unused.
846
368f4090
JM
8472011-04-10 Jim Meyering <meyering@redhat.com>
848
849 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
850 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
851 return ssize_t not "int", and use size_t as the buffer length.
852 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
853 * gnutls.h: Update declarations.
854 * process.c (read_process_output): Use ssize_t, to match.
855 (send_process): Likewise.
856
a32d4040
CY
8572011-04-09 Chong Yidong <cyd@stupidchicken.com>
858
859 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
860
8546720e 8612011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 862
8546720e
GM
863 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
864 unsigned char, to match FcChar8 type definition.
aac0c6e3 865
8546720e
GM
866 * xterm.c (handle_one_xevent):
867 * xmenu.c (create_and_show_popup_menu):
868 * xselect.c (x_decline_selection_request)
869 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 870
0a2f5c1a 8712011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
872
873 Fix some uses of `int' instead of EMACS_INT.
874 * search.c (string_match_1, fast_string_match)
875 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
876 (scan_buffer, find_next_newline_no_quit)
877 (find_before_next_newline, search_command, Freplace_match)
878 (Fmatch_data): Make some `int' variables be EMACS_INT.
879
880 * xdisp.c (display_count_lines): 3rd argument and return value now
881 EMACS_INT. All callers changed.
882 (pint2hrstr): Last argument is now EMACS_INT.
883
884 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
885 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
886 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
887 (decode_coding_utf_16, decode_coding_emacs_mule)
888 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
889 (decode_coding_ccl, decode_coding_charset)
890 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
891 (decode_coding_iso_2022, decode_coding_emacs_mule)
892 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
893 <char_offset, last_offset>: Declare EMACS_INT.
894 (encode_coding_utf_8, encode_coding_utf_16)
895 (encode_coding_emacs_mule, encode_invocation_designation)
896 (encode_designation_at_bol, encode_coding_iso_2022)
897 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
898 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
899 Declare EMACS_INT.
900 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
901 (encode_invocation_designation): Last argument P_NCHARS is now
902 EMACS_INT.
903 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
904 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
905
906 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
907 All users changed.
908
909 * ccl.c (Fccl_execute_on_string): Declare some variables
910 EMACS_INT.
911
8546720e 9122011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
913
914 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
915
4e19a977
CS
9162011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
917
918 * process.c (Fformat_network_address): Doc fix.
919
87302331
R
9202011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
921
922 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
923
cbb59342
CY
9242011-04-08 Chong Yidong <cyd@stupidchicken.com>
925
926 * keyboard.c (read_char): Call Lisp function help-form-show,
927 instead of using internal_with_output_to_temp_buffer.
928 (Qhelp_form_show): New var.
e0d38eeb 929 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
930
931 * print.c (internal_with_output_to_temp_buffer): Function deleted.
932
933 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
934
e67a13ab
CY
9352011-04-06 Chong Yidong <cyd@stupidchicken.com>
936
937 * process.c (Flist_processes): Removed to Lisp.
938 (list_processes_1): Deleted.
939
973f782d
EZ
9402011-04-06 Eli Zaretskii <eliz@gnu.org>
941
7c106b1e
EZ
942 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
943
973f782d
EZ
944 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
945
41cf7d1a 9462011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 947
ca23cc88
PE
948 Fix more problems found by GCC 4.6.0's static checks.
949
f390e2d5
PE
950 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
951
42eea0d0
PE
952 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
953
b69769da 954 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 955
f9541e84
PE
956 * xdisp.c (vmessage): Mark as a printf-like function.
957
13841b55
PE
958 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
959
c136c10f
PE
960 * sound.c (sound_warning): Don't crash if arg contains a printf format.
961
5e2d4a30
PE
962 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
963 printf-like functions.
964 (tiff_load): Add casts to remove these marks before passing them
965 to system-supplied API.
966
583f48b9
PE
967 * eval.c (Fsignal): Remove excess argument to 'fatal'.
968
b25d760e
PE
969 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
970 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
971 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
972 directly, rather than having caller test rule sign. This avoids
973 some unnecessary tests.
974 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
975 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
976 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 977
bc7b6697 978 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 979 (xfont_open): Avoid unnecessary tests.
bc7b6697 980
27ccc379
PE
981 * composite.c (composition_gstring_put_cache): Use unsigned integer.
982
dcd5c89a
PE
983 * composite.h, composite.c (composition_gstring_put_cache):
984 Use EMACS_INT, not int, for length.
985
b13a45c6
PE
986 * composite.h (COMPOSITION_DECODE_REFS): New macro,
987 breaking out part of COMPOSITION_DECODE_RULE.
988 (COMPOSITION_DECODE_RULE): Use it.
989 * composite.c (get_composition_id): Remove unused local vars,
990 by using the new macro.
991
1e792e4d
PE
992 * textprop.c (set_text_properties_1): Change while to do-while,
993 since the condition is always true at first.
994
dc6c6455 995 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
996 (interval_deletion_adjustment): Return unsigned value.
997 All uses changed.
dc6c6455 998
aba7731a
PE
999 * process.c (list_processes_1, create_pty, read_process_output):
1000 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1001 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1002 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1003 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1004 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1005
fdfc4bf3
PE
1006 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1007
fca8fe46 1008 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1009 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1010
06a0259a 1011 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1012 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1013 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1014
e7b9e80f
PE
1015 * print.c (print_error_message): Avoid int overflow.
1016
56201685
PE
1017 * font.c (font_list_entities): Redo for clarity,
1018 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1019
78834453 1020 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1021 (font_score): Avoid potential overflow in diff calculation.
78834453 1022
0bc0b309 1023 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1024 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1025
e610eaca
PE
1026 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1027
b895abce
PE
1028 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1029 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1030 can always succeed if overflow has undefined behavior.
1031
1f1d9321 1032 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1033 (wordify): Omit three unnecessary tests.
1f1d9321 1034
c59478bc
PE
1035 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1036 All callers changed. This avoids the need for an unused var.
1037
79b73827
PE
1038 * casefiddle.c (casify_region): Remove var that is set but not used.
1039
a4db5dfe
PE
1040 * dired.c (file_name_completion): Remove var that is set but not used.
1041
43aae36e
PE
1042 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1043
2a47c44d 1044 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1045 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1046
a37c69bf
PE
1047 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1048 Check for integer overflow on size calculations.
1049
328ab8e7
PE
1050 * buffer.c (Fprevious_overlay_change): Remove var that is set
1051 but not used.
1052
e5a2a5cb
PE
1053 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1054 Remove vars that are set but not used.
8d84a6eb 1055 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1056 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1057
a60e5f68
PE
1058 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1059
f661cb61 1060 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1061 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1062
f0397f5a
PE
1063 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1064 that are set but not used.
1065
8664db06 1066 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1067 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1068
6abdaa4a
PE
1069 * xselect.c (x_get_local_selection, x_handle_property_notify):
1070 Remove vars that are set but not used.
1071
0ce7538d 1072 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1073 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1074
9ae848fc
PE
1075 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1076 Remove var that is set but not used.
0b918413
PE
1077 (scroll_bar_windows_size): Now size_t, not int.
1078 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1079 Check for overflow.
9ae848fc 1080
a5a62657
PE
1081 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1082 (map_tty_color) [!defined MSDOS]: Likewise.
1083
5c5cdd39
PE
1084 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1085
66ebf983
PE
1086 * coding.c: Remove vars that are set but not used.
1087 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1088 All callers changed.
1089 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1090 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1091 (decode_coding_charset): Remove vars that are set but not used.
1092
1be4d761
PE
1093 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1094 that is set but not used.
1095
47553fa8
PE
1096 * print.c (print_object): Remove var that is set but not used.
1097
1f7196bf 1098 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1099 The gnulib version avoids calling malloc in the usual case,
1100 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1101 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1102 * filelock.c (current_lock_owner): Likewise.
1103 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1104 * sysdep.c: Include allocator.h, careadlinkat.h.
1105 (emacs_no_realloc_allocator): New static constant.
1106 (emacs_readlink): New function.
fdb61804
PE
1107 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1108 ../lib/careadlinkat.h.
d1fdcab7 1109
f84c17c7
SM
11102011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1113 first non-nil return value).
1114
ef3862ad
JD
11152011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1116
1117 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1118 if not defined (Bug#8403).
1119
376a7006
JB
11202011-04-02 Juanma Barranquero <lekktu@gmail.com>
1121
1122 * xdisp.c (display_count_lines): Remove parameter `start',
1123 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1124 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1125 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1126 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1127 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1128 and thereabouts. All callers changed.
1129 (get_per_char_metric): Remove parameter `f', unused since
1130 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1131
6ca3801d
JM
11322011-04-02 Jim Meyering <meyering@redhat.com>
1133
1134 do not dereference NULL upon failed strdup
1135 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1136 (ns_get_family): Likewise.
1137
d8e2b5ba
JB
11382011-04-02 Juanma Barranquero <lekktu@gmail.com>
1139
1140 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1141
8c74fcbd
JD
11422011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1143
1144 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1145 later (Bug#8403).
1146
7200d79c
SM
11472011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1148
03408648 1149 Add lexical binding.
7200d79c 1150
03408648
SM
1151 * window.c (Ftemp_output_buffer_show): New fun.
1152 (Fsave_window_excursion):
1153 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1154
1155 * lread.c (lisp_file_lexically_bound_p): New function.
1156 (Fload): Bind Qlexical_binding.
1157 (readevalloop): Remove `evalfun' arg.
1158 Bind Qinternal_interpreter_environment.
1159 (Feval_buffer): Bind Qlexical_binding.
1160 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1161 Mark as dynamic.
1162 (syms_of_lread): Declare `lexical-binding'.
1163
1164 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1165
1166 * keyboard.c (eval_dyn): New fun.
1167 (menu_item_eval_property): Use it.
ca105506
SM
1168
1169 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1170
03408648
SM
1171 * fns.c (concat, mapcar1): Accept byte-code-functions.
1172
1173 * eval.c (Fsetq): Handle lexical vars.
1174 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1175 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1176 (FletX, Flet): Obey lexical binding.
1177 (Fcommandp): Handle closures.
1178 (Feval): New `lexical' arg.
1179 (eval_sub): New function extracted from Feval. Use it almost
1180 everywhere where Feval was used. Look up vars in lexical env.
1181 Handle closures.
1182 (Ffunctionp): Move from subr.el.
1183 (Ffuncall): Handle closures.
1184 (apply_lambda): Remove `eval_flags'.
1185 (funcall_lambda): Handle closures and new byte-code-functions.
1186 (Fspecial_variable_p): New function.
1187 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1188 but without exporting it to Lisp.
23aba0ea 1189
23aba0ea 1190 * doc.c (Fdocumentation, store_function_docstring):
03408648 1191 * data.c (Finteractive_form): Handle closures.
23aba0ea 1192
03408648
SM
1193 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1194 interactive spec.
ba83908c 1195
03408648
SM
1196 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1197 byte-codes.
1198 (exec_byte_code): New function extracted from Fbyte_code to handle new
1199 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1200
03408648 1201 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1202
03408648 1203 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1204
e2abce01
JB
12052011-03-31 Juanma Barranquero <lekktu@gmail.com>
1206
1207 * xdisp.c (redisplay_internal): Fix prototype.
1208
63696a73 12092011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1210
63696a73
EZ
1211 * xdisp.c (SCROLL_LIMIT): New macro.
1212 (try_scrolling): Use it when setting scroll_limit. Limit
1213 scrolling to 100 screen lines.
1214 (redisplay_window): Even when falling back on "recentering",
1215 position point in the window according to scroll-conservatively,
1216 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1217
1218 (try_scrolling): When point is above the window, allow searching
1219 as far as scroll_max, or one screenful, to compute vertical
1220 distance from PT to the scroll margin position. This prevents
1221 try_scrolling from unnecessarily failing when
1222 scroll-conservatively is set to a value slightly larger than the
1223 window height. Clean up the case of PT below the margin at bottom
1224 of window: scroll_max can no longer be INT_MAX. When aggressive
1225 scrolling is in use, don't let point enter the opposite scroll
1226 margin as result of the scroll.
1227 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1228 threshold of 100 lines for never-recentering scrolling.
1229
e4cc2dfc
JB
12302011-03-31 Juanma Barranquero <lekktu@gmail.com>
1231
1232 * dispextern.h (move_it_by_lines):
1233 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1234 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1235 (message_log_check_duplicate): Remove parameters `prev_bol' and
1236 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1237 (redisplay_internal): Remove parameter `preserve_echo_area',
1238 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1239
1240 * indent.c (Fvertical_motion):
1241 * window.c (window_scroll_pixel_based, Frecenter):
1242 Don't pass `need_y_p' to `move_it_by_lines'.
1243
1c470562
SM
12442011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1245
44f230aa
SM
1246 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1247 steal a few bits to be more compact.
1248 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1249 Remove unneeded casts.
1250
1c470562
SM
1251 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1252
888adce9
ZK
12532011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1254
1255 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1256 binding" message (bug#7967).
1257
f838ed7b
PE
12582011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1259
77861b95
PE
1260 Fix more problems found by GCC 4.6.0's static checks.
1261
de6dbc14
PE
1262 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1263 Remove unused local var.
1264
f838ed7b
PE
1265 * editfns.c (Fmessage_box): Remove unused local var.
1266
792c7b2b
PE
1267 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1268 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1269 Omit unused local vars.
c499e557 1270 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1271 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1272 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1273 Omit unused local var.
1274
ba0165e1
PE
1275 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1276 Don't assume string length fits in int.
32ad8845 1277 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1278 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1279
3c59b4c9
PE
1280 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1281 instead of alloca (Bug#8344).
1282
a3eed478 1283 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1284 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1285
eb4d412d
PE
1286 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1287
1658b401
PE
1288 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1289 concerns.
1290
1291 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1292
1293 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1294
9a2c6e05
PE
1295 * keyboard.c (syms_of_keyboard): Use the same style as later
1296 in this function when indexing through an array. This also
1297 works around GCC bug 48267.
1298
03d0a109
PE
1299 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1300
44f730c8
PE
1301 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1302
fe75f926
PE
1303 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1304 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1305
ffa8c828
PE
1306 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1307 This avoids undefined behavior on integer overflow, and is a bit
1308 more convenient anyway since it is compared to a size_t variable.
1309
c5101a77
PE
1310 Variadic C functions now count arguments with size_t, not int.
1311 This avoids an unnecessary limitation on 64-bit machines, which
1312 caused (substring ...) to crash on large vectors (Bug#8344).
1313 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1314 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1315 All variadic functions and their callers changed accordingly.
c5101a77
PE
1316 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1317 * data.c (arith_driver, float_arith_driver): Likewise.
1318 * editfns.c (general_insert_function): Likewise.
1319 * eval.c (struct backtrace.nargs, interactive_p)
1320 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1321 (funcall_lambda, mark_backtrace): Likewise.
1322 * fns.c (concat): Likewise.
1323 * frame.c (x_set_frame_parameters): Likewise.
1324 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1325 0 if not found, not -1. All callers changed.
1326
dd3f25f7
PE
1327 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1328 (stack_copy_size): Now size_t, not int.
1329 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1330
461c2ab9
JB
13312011-03-28 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1334 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1335 All callers changed.
1336
1337 * lisp.h (multibyte_char_to_unibyte):
1338 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1339 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1340 * character.h (CHAR_TO_BYTE8):
1341 * cmds.c (internal_self_insert):
1342 * editfns.c (general_insert_function):
1343 * keymap.c (push_key_description):
1344 * search.c (Freplace_match):
1345 * xdisp.c (message_dolog, set_message_1): All callers changed.
1346
f6d62986
SM
13472011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1348
1349 * keyboard.c (safe_run_hook_funcall): New function.
1350 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1351 don't set the hook to nil, but remove the offending function instead.
1352 (Qcommand_hook_internal): Remove, unused.
1353 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1354 Vcommand_hook_internal.
1355
1356 * eval.c (enum run_hooks_condition): Remove.
1357 (funcall_nil, funcall_not): New functions.
1358 (run_hook_with_args): Call each function through a `funcall' argument.
1359 Remove `cond' argument, now redundant.
1360 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1361 (Frun_hook_with_args_until_failure): Adjust accordingly.
1362 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1363
1db5b1ad
JB
13642011-03-28 Juanma Barranquero <lekktu@gmail.com>
1365
1366 * dispextern.h (string_buffer_position): Remove declaration.
1367
1368 * print.c (strout): Remove parameter `multibyte', unused since
1369 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1370
1371 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1372 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1373 All callers changed.
1374
1375 * w32.c (_wsa_errlist): Use braces for struct initializers.
1376
1377 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1378 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1379 All callers changed.
1380 (string_buffer_position): Likewise. Also, make static (it's never
1381 used outside xdisp.c).
1382 (cursor_row_p): Remove parameter `w', unused since
1383 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1384 (decode_mode_spec): Remove parameter `precision', introduced during
1385 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1386 All callers changed.
1387
5ffb62aa
JD
13882011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1389
1390 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1391
461c2ab9 13922011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1393
1394 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1395 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1396 (ns_update_auto_hide_menu_bar): New functions.
1397 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1398 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1399 ns_constrain_all_frames.
1400 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1401 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1402
5c380ffb
JD
14032011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1404
1405 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1406
9af30bdf
GM
14072011-03-27 Glenn Morris <rgm@gnu.org>
1408
1409 * syssignal.h: Replace RETSIGTYPE with void.
1410 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1411 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1412 Replace SIGTYPE with void everywhere.
1413 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1414 * s/template.h (SIGTYPE): Remove commented out definition.
1415
e2abce01
JB
14162011-03-26 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1419 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1420
f868cd8a
JB
14212011-03-26 Juanma Barranquero <lekktu@gmail.com>
1422
59eb0929
JB
1423 * w32.c (read_unc_volume): Use parameter `henum', instead of
1424 global variable `wget_enum_handle'.
1425
1426 * keymap.c (describe_vector): Remove parameters `indices' and
1427 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1428 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1429
f868cd8a
JB
1430 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1431
1432 * keyboard.c (timer_check): Remove parameter `do_it_now',
1433 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1434 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1435 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1436
1437 * keyboard.c (read_char):
1438 * w32menu.c (w32_menu_display_help):
1439 * xmenu.c (show_help_event, menu_help_callback):
1440 Adjust calls to `show_help_echo'.
1441
1442 * gtkutil.c (xg_maybe_add_timer):
1443 * keyboard.c (readable_events):
1444 * process.c (wait_reading_process_output):
1445 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1446
1447 * insdel.c (adjust_markers_gap_motion):
1448 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1449 (gap_left, gap_right): Don't call it.
1450
2ecf6fdb
CY
14512011-03-25 Chong Yidong <cyd@stupidchicken.com>
1452
1453 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1454 incurred during fontification.
1455
6b1f9ba4
JB
14562011-03-25 Juanma Barranquero <lekktu@gmail.com>
1457
1458 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1459 (DEFVAR_PER_BUFFER): Don't pass it.
1460
1461 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1462 (scrolling_window): Don't pass it.
1463
0f4a96b5
JB
14642011-03-25 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1467
1468 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1469 and `suffix'.
1470 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1471 of variables specific to SELinux and computation of `encoded_absname'.
1472
1473 * image.c (XPutPixel): Remove unused variable `height'.
1474
1475 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1476
1477 * unexw32.c (get_section_info): Remove unused variable `section'.
1478
1479 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1480 (system_process_attributes): Remove unused variable `sess'.
1481 (sys_read): Remove unused variable `err'.
1482
1483 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1484 (w32_wnd_proc): Remove unused variable `isdead'.
1485 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1486 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1487 (x_create_tip_frame): Remove unused variable `tem'.
1488
1489 * w32inevt.c (w32_console_read_socket):
1490 Remove unused variable `no_events'.
1491
1492 * w32term.c (x_draw_composite_glyph_string_foreground):
1493 Remove unused variable `width'.
1494
1149507c
JB
14952011-03-24 Juanma Barranquero <lekktu@gmail.com>
1496
1497 * w32term.c (x_set_glyph_string_clipping):
1498 Don't pass uninitialized region to CombineRgn.
1499
9c88f339
JB
15002011-03-23 Juanma Barranquero <lekktu@gmail.com>
1501
1502 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1503 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1504 (Fx_close_connection): Remove unused variable `i'.
1505
1506 * w32font.c (w32font_draw): Return number of glyphs.
1507 (w32font_open_internal): Remove unused variable `i'.
1508 (w32font_driver): Add missing initializer.
1509
1510 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1511 (fill_in_menu): Remove unused variable `items_added'.
1512
1513 * w32term.c (last_mouse_press_frame): Remove static global variable.
1514 (w32_clip_to_row): Remove unused variable `f'.
1515 (x_delete_terminal): Remove unused variable `i'.
1516
1517 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1518 (NOTHING): Remove unused static global variable.
1519 (uniscribe_check_otf): Remove unused variable `table'.
1520 (uniscribe_font_driver): Add missing initializers.
1521
dee091a3
JD
15222011-03-23 Julien Danjou <julien@danjou.info>
1523
1524 * term.c (Fsuspend_tty, Fresume_tty):
1525 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1526 * window.c (temp_output_buffer_show):
1527 * insdel.c (signal_before_change):
1528 * frame.c (Fhandle_switch_frame):
1529 * fileio.c (Fdo_auto_save):
1530 * emacs.c (Fkill_emacs):
1531 * editfns.c (save_excursion_restore):
1532 * cmds.c (internal_self_insert):
1533 * callint.c (Fcall_interactively):
1534 * buffer.c (Fkill_all_local_variables):
1535 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1536 Use Frun_hooks.
0f4a96b5 1537 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1538 unconditionnaly since it does the check itself.
1539
2c520ab5 15402011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1541
c9c49752
PE
1542 Fix more problems found by GCC 4.5.2's static checks.
1543
8abc3f12
PE
1544 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1545 the first time through the loop, since we know p0 < p1 then.
1546 This also avoids a gcc -Wstrict-overflow warning.
1547
a2d26660
PE
1548 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1549 leading to a memory leak, possible in functions like
1550 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1551 of objects (Bug#8318).
a2d26660 1552
916c72e9
PE
1553 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1554 that could (at least in theory) be that large.
1555
19ab8a18
PE
1556 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1557 This is less likely to overflow, and avoids undefined behavior if
1558 overflow does occur. All callers changed. Use strtoul to scan
1559 for the unsigned long integer.
b7cbbd6f
PE
1560 (pint2hrstr): Simplify and tune code slightly.
1561 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1562
f0641eff
PE
1563 * scroll.c (do_scrolling): Work around GCC bug 48228.
1564 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1565
7f650bb9
PE
1566 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1567 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1568 (validate_x_resource_name): Simplify count usage.
1569 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1570
37dd57d1
PE
1571 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1572 fail (Bug#8306).
81e56e61 1573
699979fc 1574 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1575
401bf9b4
PE
1576 * process.c (Fmake_network_process): Use socklen_t, not int,
1577 where POSIX says socklen_t is required in portable programs.
1578 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1579 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1580 (Fmake_network_process, server_accept_connection):
1581 (wait_reading_process_output, read_process_output):
1582 Likewise.
1583
b93aacde
PE
1584 * process.c: Rename or move locals to avoid shadowing.
1585 (list_processes_1, Fmake_network_process):
1586 (read_process_output_error_handler, exec_sentinel_error_handler):
1587 Rename or move locals.
4dc343ee 1588 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1589 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1590 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1591 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1592 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1593
af8a867c 1594 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1595 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1596 Include tparam.h instead, since it declares them.
af8a867c
PE
1597 * cm.h (PC): Remove extern decl; tparam.h now does this.
1598 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1599 * terminfo.c: Include tparam.h, to check interfaces.
1600 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1601 (tparam): Adjust signature to match interface in tparam.h;
1602 this removes some undefined behavior. Check that outstring and len
1603 are zero, which they always are with Emacs.
1604 * tparam.h (PC, BC, UP): New extern decls.
1605
0248044d 1606 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1607 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1608
8ff096c1 1609 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1610 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1611 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1612 (ftfont_list): Remove unused local.
49eaafba
PE
1613 (get_adstyle_property, ftfont_pattern_entity):
1614 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1615 Rename locals to avoid shadowing.
8ff096c1 1616
e2be39f6
PE
1617 * xfont.c (xfont_list_family): Mark var as initialized.
1618
c9735e30
PE
1619 * xml.c (make_dom): Now static.
1620
8f5201ae
PE
1621 * composite.c (composition_compute_stop_pos): Rename local to
1622 avoid shadowing.
b246f932
PE
1623 (composition_reseat_it): Remove unused locals.
1624 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1625 (composition_update_it): Mark var as initialized.
11b61122
PE
1626 (find_automatic_composition): Mark vars as initialized,
1627 with a FIXME (Bug#8290).
8f5201ae 1628
760fbc2c
PE
1629 character.h: Rename locals to avoid shadowing.
1630 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1631 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1632 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1633 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1634 to avoid shadowing.
1635
ff08eb85
PE
1636 * textprop.c (property_change_between_p): Remove; unused.
1637
fc7bf025
PE
1638 * intervals.c (interval_start_pos): Now static.
1639
235d7abc
PE
1640 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1641
44f230aa
SM
1642 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1643 Rename locals to avoid shadowing.
3e7d6594 1644
50060332
PE
1645 * sound.c (wav_play, au_play, Fplay_sound_internal):
1646 Fix pointer signedness.
d01f234b 1647 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1648 (wav_play): Initialize a variable to 0, to prevent undefined
1649 behavior (Bug#8278).
50060332 1650
c4fc4e30
PE
1651 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1652
918436ed
PE
1653 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1654
c939f91b
PE
1655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1656 clobbering (Bug#8298).
b9c7f648
PE
1657 * sysdep.c (sys_subshell): Likewise.
1658 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1659
6bd8c144
PE
1660 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1661 This should get cleaned up, so that child_setup has the
1662 same signature on all platforms.
1663
7710357c 1664 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1665 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1666
c59da222
CY
16672011-03-22 Chong Yidong <cyd@stupidchicken.com>
1668
1669 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1670 not to be necessary, and produces flickering.
1671
66b87493
GM
16722011-03-20 Glenn Morris <rgm@gnu.org>
1673
1674 * config.in: Remove file.
1675
45b6f6d5
JB
16762011-03-20 Juanma Barranquero <lekktu@gmail.com>
1677
1678 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1679 are now in src/globals.h.
1680 (syms_of_minibuf): Remove spurious & from previous change.
1681
3ec03f7e
LL
16822011-03-20 Leo <sdl.web@gmail.com>
1683
1684 * minibuf.c (completing-read-function): New variable.
1685 (completing-read-default): Rename from completing-read.
1686 (completing-read): Call completing-read-function.
1687
b14e3e21
CY
16882011-03-19 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * xfaces.c (Fx_load_color_file):
1691 Read color file from absolute filename (bug#8250).
1692
f2b726e6
JB
16932011-03-19 Juanma Barranquero <lekktu@gmail.com>
1694
1695 * makefile.w32-in: Update dependencies.
1696
09f6ff02
EZ
16972011-03-17 Eli Zaretskii <eliz@gnu.org>
1698
1699 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1700
29a6015a
PE
17012011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1702
a3a6c54e
PE
1703 Fix more problems found by GCC 4.5.2's static checks.
1704
b766f867
PE
1705 * process.c (make_serial_process_unwind, send_process_trap):
1706 (sigchld_handler): Now static.
1707
be02381c
PE
1708 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1709 That way, the code declares only the vars that it needs.
1710 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1711 * s/cygwin.h (PTY_ITERATION): Likewise.
1712 * s/darwin.h (PTY_ITERATION): Likewise.
1713 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1714
57048744
PE
1715 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1716 * process.c (allocate_pty): Don't declare stb unless it's needed.
1717
7914961c 1718 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1719 (CONSTANTLIM): Remove; unused.
1720 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1721 Define only if needed.
7914961c 1722
b3967b18
PE
1723 * unexelf.c (unexec): Name an expression,
1724 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1725 Use a different way to cause a compilation error if anyone uses
1726 n rather than nn, a way that does not involve shadowing.
73366a00 1727 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1728
29a6015a
PE
1729 * deps.mk (unexalpha.o): Remove; unused.
1730
43cfc33e 1731 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1732 * unexec.h: New file.
ce701a33
PE
1733 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1734 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1735 Depend on unexec.h.
1736 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1737 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1738 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1739 Change as necessary to match prototype in unexec.h.
ce701a33 1740
01f44d5a
PE
1741 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1742 shadowing.
4f63c6bb 1743 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1744
a6670b0b
PE
1745 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1746 Rename locals to avoid shadowing.
1747
cef2010d 1748 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1749 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1750
d4d7173a
PE
1751 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1752
f08b802a
PE
1753 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1754 warning when compiling print.c.
1755
3ddb0639
PE
1756 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1757 instead of using an uninitialized var.
5ad03b97 1758 (font_sort_entities): Mark var as initialized.
3ddb0639 1759
170a2692
PE
1760 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1761
e663c700
PE
1762 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1763 pointers to constants.
89bc529a 1764 (font_parse_fcname): Remove unused vars.
7b81e2d0 1765 (font_delete_unmatched): Now static.
ea838e10 1766 (font_get_spec): Remove; unused.
13a547c6
PE
1767 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1768 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1769 Rename or move locals to avoid shadowing.
e663c700 1770
2a80c887 1771 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1772 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1773
1384fa33 1774 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1775 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1776
8b2c52e9
PE
1777 * alloc.c (mark_backtrace): Move decl from here ...
1778 * lisp.h: ... to here, so that it can be checked.
1779
475545b5 1780 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1781 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1782 (lisp_indirect_variable): Name an expression,
1783 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1784 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1785
b1349114 1786 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1787 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1788 Use const pointer when appropriate.
b1349114 1789
a2928364
PE
1790 * lisp.h (get_system_name, get_operating_system_release):
1791 Move decls here, to check interfaces.
1792 * process.c (get_operating_system_release): Move decl to lisp.h.
1793 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1794 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1795 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1796 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1797 (Fformat_time_string, Fencode_time, Finsert_char):
1798 (Ftranslate_region_internal, Fformat):
1799 Rename or remove local vars to avoid shadowing.
9710023e 1800 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1801
a415e694
PE
1802 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1803 avoid shadowing.
1804
8ef4622d
PE
1805 * lisp.h (eassert): Check that the argument compiles, even if
1806 ENABLE_CHECKING is not defined.
1807
946f9a5b
PE
1808 * data.c (Findirect_variable): Name an expression, to avoid
1809 gcc -Wbad-function-cast warning.
112396d6 1810 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1811 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1812 (Fmake_variable_buffer_local, Fmake_local_variable):
1813 Mark variables as initialized.
52746918 1814 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1815
e5aab7e7 1816 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1817 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1818 Rename locals to avoid shadowing.
dff45157
PE
1819 (mark_stack): Move local variables into the #ifdef region where
1820 they're used.
7bc26fdb
PE
1821 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1822 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1823 needed otherwise.
1824 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1825 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1826 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1827
e5aab7e7
PE
1828 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1829 avoids undefined behavior in theory.
1830
4da60324
PE
1831 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1832
88043301
PE
1833 Use functions, not macros, for up- and down-casing (Bug#8254).
1834 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1835 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1836 to use the following functions instead of these macros.
1837 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1838 EMACS_INT, since callers assume the returned value fits in int.
1839 (upcase1): Likewise, for UPCASE_TABLE.
1840 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1841 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1842 the race-condition problem in the old DOWNCASE.
88043301 1843
19ed5445
PE
1844 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1845 Rename locals to avoid shadowing.
1846 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1847 (regex_compile, re_search_2, re_match_2_internal):
1848 Remove unused local vars.
952db0d7
PE
1849 (FREE_VAR): Rewrite so as not to use empty "else",
1850 which gcc can warn about.
da053e48 1851 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1852 (RETALLOC_IF): Define only if needed.
1853 (WORDCHAR_P): Likewise. This one is never needed, but is used
1854 only in a comment talking about a compiler bug, so put inside
1855 the #if 0 of that comment.
1856 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1857 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1858 Remove; unused.
19ed5445 1859
1f3561e4 1860 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1861 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1862 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1863
ded6f8f7
PE
1864 * search.c (simple_search): Remove unused var.
1865
dbd37a95
PE
1866 * dired.c (compile_pattern): Move decl from here ...
1867 * lisp.h: ... to here, so that it can be checked.
1868 (struct re_registers): New forward decl.
1869
7e47afad
PE
1870 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1871
85f24f61
PE
1872 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1873 All uses changed.
1874 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1875 Rename locals to avoid shadowing.
5671df8f 1876 (Fvertical_motion): Mark locals as initialized.
85f24f61 1877
181aa2be 1878 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1879 (casify_region): Mark local as initialized.
181aa2be 1880
930d429c
PE
1881 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1882
7082eac6
PE
1883 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1884 New macros, so that the caller can use some names other than
1885 gcpro1, gcpro2, etc.
1886 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1887 of the new macros.
1888 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1889 argument, for consistency with GCPRO2_VAR, etc: it is now the
1890 prefix of the variable, not the variable itself. All uses
1891 changed.
38b2c076
PE
1892 * dired.c (directory_files_internal, file_name_completion):
1893 Rename locals to avoid shadowing.
1894
15206ed9
PE
1895 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1896 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1897 dired.c's scmp function, had undefined behavior.
1898 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1899 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1900 * buffer.h: ... to here, because these macros use current_buffer,
1901 and the new implementation with inline functions needs to have
1902 current_buffer in scope now, rather than later when the macros
1903 are used.
1904 (downcase, upcase1): New static inline functions.
1905 (DOWNCASE, UPCASE1): Reimplement using these functions.
1906 This avoids undefined behavior in expressions like
1907 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1908 from race conditions in accessing the global variables
1909 case_temp1 and case_temp2.
1910 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1911 * lisp.h (case_temp1, case_temp2): Remove their decls.
1912 * character.h (ASCII_CHAR_P): Move from here ...
1913 * lisp.h: ... to here, so that the inline functions mentioned
1914 above can use them.
1915
4a6bea26
PE
1916 * dired.c (directory_files_internal_unwind): Now static.
1917
f14b7e14
PE
1918 * fileio.c (file_name_as_directory, directory_file_name):
1919 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1920 Now static.
2893f146
PE
1921 (file_name_as_directory): Use const pointers when appropriate.
1922 (Fexpand_file_name): Likewise. In particular, newdir might
1923 point at constant storage, so make it a const pointer.
fd4ead52 1924 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1925 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1926 signedness issues.
f839df0c
PE
1927 (Fset_file_times, Finsert_file_contents, auto_save_error):
1928 Rename locals to avoid shadowing.
f14b7e14 1929
5716756e 1930 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1931 (Ftry_completion, Fall_completions): Rename or remove locals
1932 to avoid shadowing.
5716756e 1933
b4c3046a
PE
1934 * marker.c (bytepos_to_charpos): Remove; unused.
1935
b45db522
PE
1936 * lisp.h (verify_bytepos, count_markers): New decls,
1937 so that gcc does not warn that these functions aren't declared.
1938
85876d07
PE
1939 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1940 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1941 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1942 (copy_text): Remove unused local var.
85876d07 1943
03d78a21 1944 * filelock.c (within_one_second): Now static.
b3dd38ab 1945 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1946
5df8f01b
PE
1947 * buffer.c (fix_overlays_before): Mark locals as initialized.
1948 (fix_start_end_in_overlays): Likewise. This function should be
1949 simplified by using pointers-to-pointers, but that's a different
1950 matter.
b1d876f1 1951 (switch_to_buffer_1): Now static.
8f54f30a
PE
1952 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1953 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1954
a70072c9 1955 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1956 Fix pointer signedness issue.
edced198
PE
1957 (sys_subshell): Mark local as volatile if checking for lint,
1958 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1959 (MAXPATHLEN): Define only if needed.
a70072c9 1960
a0977c44
PE
1961 * process.c (serial_open, serial_configure): Move decls from here ...
1962 * systty.h: ... to here, so that they can be checked.
1963
a884fdcc
PE
1964 * fns.c (get_random, seed_random): Move extern decls from here ...
1965 * lisp.h: ... to here, so that they can be checked.
1966
604efe86 1967 * sysdep.c (reset_io): Now static.
b8950c94 1968 (wait_for_termination_signal): Remove; unused.
604efe86 1969
38fc62d9
PE
1970 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1971 (copy_keymap_item, append_key, push_text_char_description):
1972 Now static.
1004a21a 1973 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1974 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1975 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1976 (describe_map_tree):
1977 Rename locals to avoid shadowing.
38fc62d9 1978
2f2650da
PE
1979 * keyboard.c: Declare functions static if they are not used elsewhere.
1980 (echo_char, echo_dash, cmd_error, top_level_2):
1981 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1982 (read_char, kbd_buffer_get_event, make_lispy_position):
1983 (make_lispy_event, make_lispy_movement, apply_modifiers):
1984 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1985 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1986 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1987 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1988 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1989
a053e86c 1990 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1991 (mark_kboards): Move decl here ...
1992 * alloc.c (mark_kboards): ... from here.
a053e86c 1993
4752793e
PE
1994 * lisp.h (force_auto_save_soon): New decl.
1995
74f10ca7 1996 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1997 (DEFINE_DUMMY_FUNCTION): New macro.
1998 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1999 Use it.
c03cd23f
PE
2000 (main): Add casts to avoid warnings
2001 if GCC considers string literals to be constants.
74f10ca7 2002
022e70d4
PE
2003 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2004
59d6fe83
PE
2005 * dbusbind.c: Pointer signedness fixes.
2006 (xd_signature, xd_append_arg, xd_initialize):
2007 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2008 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2009 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2010 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2011
78320123
PE
2012 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2013 if GCC considers string literals to be constants.
49cebcca 2014 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2015
35ac2a97
SM
20162011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2017
fb103ca9
SM
2018 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2019 (print_preprocess, print_object): New macro to fix last change.
2020
35ac2a97
SM
2021 * print.c (print_preprocess): Don't forget font objects.
2022
62973b41
JB
20232011-03-16 Juanma Barranquero <lekktu@gmail.com>
2024
2025 * emacs.c (USAGE3): Doc fixes.
2026
0e48bb22
AS
20272011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2028
2029 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2030 structure.
2031
7684e57b
JB
20322011-03-14 Juanma Barranquero <lekktu@gmail.com>
2033
2034 * lisp.h (VWindow_system, Qfile_name_history):
2035 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2036 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2037 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2038
2039 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2040 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2041
2042 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2043 * w32console.c (detect_input_pending, read_input_pending)
2044 (encode_terminal_code):
2045 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2046 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2047 (w32_system_caret_y, Qfile_name_history):
2048 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2049 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2050 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2051 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2052 * w32proc.c (Qlocal, report_file_error):
2053 * w32term.c (Vwindow_system, updating_frame):
2054 * w32uniscribe.c (initialized, uniscribe_font_driver):
2055 Remove unneeded extern declarations.
2056
2aa46d6c
CY
20572011-03-14 Chong Yidong <cyd@stupidchicken.com>
2058
c96bbc66 2059 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2060
cffc6f3b
CY
20612011-03-13 Chong Yidong <cyd@stupidchicken.com>
2062
2063 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2064 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2065 These macros can no longer be used for assignment.
2066
44f230aa
SM
2067 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2068 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2069 (record_buffer_markers, fetch_buffer_markers): New functions for
2070 recording and fetching special buffer markers.
2071 (set_buffer_internal_1, set_buffer_temp): Use them.
2072
2073 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2074
2075 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2076
2077 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2078 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2079
2080 * xdisp.c (hscroll_window_tree):
2081 (reconsider_clip_changes): Use PT instead of BUF_PT.
2082
d251f04b
EZ
20832011-03-13 Eli Zaretskii <eliz@gnu.org>
2084
2085 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2086 $(EMACS_ROOT)/lib/intprops.h.
2087
f0c77cd1
PE
20882011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2089
3eca4629
PE
2090 Fix more problems found by GCC 4.5.2's static checks.
2091
7c86ee98
PE
2092 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2093 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2094 (xg_free_frame_widgets): Make it clear that a local variable is
2095 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2096 (gdk_window_get_screen): Make it clear that this macro is needed
2097 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2098 (int_gtk_range_get_value): New function, which avoids a diagnostic
2099 from gcc -Wbad-function-cast.
2100 (xg_set_toolkit_scroll_bar_thumb): Use it.
2101 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2102 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2103 (get_utf8_string, xg_get_file_with_chooser):
2104 Rename locals to avoid shadowing.
2105 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2106
41729b81
PE
2107 * xgselect.c (xg_select): Remove unused var.
2108
f0c77cd1
PE
2109 * image.c (four_corners_best): Mark locals as initialized.
2110 (gif_load): Initialize transparent_p to zero (Bug#8238).
2111 Mark another local as initialized.
ec6cf4c6 2112 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2113
ce0ad53d 2114 * image.c (clear_image_cache): Now static.
d5d5a617 2115 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2116 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2117 (x_edge_detection): Remove unnecessary cast that
2118 gcc -Wbad-function-cast diagnoses.
2037898d 2119 (gif_load): Fix pointer signedness.
6ae141d6
PE
2120 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2121 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2122
33383987 21232011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2124
d32df629
PE
2125 Improve quality of tests for time stamp overflow.
2126 For example, without this patch (encode-time 0 0 0 1 1
2127 1152921504606846976) returns the obviously-bogus value (-948597
2128 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2129 reports time overflow. See
2130 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2131 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2132 * editfns.c: Include limits.h and intprops.h.
2133 (TIME_T_MIN, TIME_T_MAX): New macros.
2134 (time_overflow): Move earlier, to before first use.
2135 (hi_time, lo_time): New functions, for an accurate test for
2136 out-of-range times.
2137 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2138 (Fget_internal_run_time): Don't assume time_t fits in int.
2139 (make_time): Use list2 instead of Fcons twice.
2140 (Fdecode_time): More accurate test for out-of-range times.
2141 (check_tm_member): New function.
2142 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2143 (lisp_time_argument): Don't rely on undefined left-shift and
2144 right-shift behavior when checking for time stamp overflow.
8be6f318 2145
fe31d94c
PE
2146 * editfns.c (time_overflow): New function, refactoring common code.
2147 (Fformat_time_string, Fdecode_time, Fencode_time):
2148 (Fcurrent_time_string): Use it.
2149
8be6f318
PE
2150 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2151 * dired.c (make_time): Move to ...
2152 * editfns.c (make_time): ... here.
2153 * systime.h: Note the move.
2154
09d9db2c 21552011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2156
126bc0dc
YM
2157 * fringe.c (update_window_fringes): Remove unused variables.
2158
c47cbdfd
YM
2159 * unexmacosx.c (copy_data_segment): Also copy __got section.
2160 (Bug#8223)
2161
7ac80be9
EZ
21622011-03-12 Eli Zaretskii <eliz@gnu.org>
2163
c96bbc66 2164 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2165 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2166 Constify `char *' arguments and their references according to
2167 prototypes in tparam.h.
2168
ecb0f94d 2169 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2170
7ac80be9
EZ
2171 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2172 Adapt all references accordingly.
2173
2174 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2175
ef1fd07e
TT
21762011-03-11 Tom Tromey <tromey@redhat.com>
2177
2178 * buffer.c (syms_of_buffer): Remove obsolete comment.
2179
7ef4b50c
EZ
21802011-03-11 Eli Zaretskii <eliz@gnu.org>
2181
2182 * termhooks.h (encode_terminal_code): Declare prototype.
2183
2184 * msdos.c (encode_terminal_code): Don't declare prototype.
2185
2186 * term.c (encode_terminal_code): Now external again, used by
2187 w32console.c and msdos.c.
2188
44f230aa
SM
2189 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2190 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2191
4b1ec863 21922011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2193
1714f52b 2194 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2195
4b1ec863
PE
2196 * fringe.c (update_window_fringes): Mark locals as initialized
2197 (Bug#8227).
2198 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2199
524c7aa6
PE
2200 * alloc.c (mark_fringe_data): Move decl from here ...
2201 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2202 to check its interface.
2203 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2204
a5c0af81 2205 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2206 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2207 (fontset_font): Mark local as initialized.
a9a06e0b 2208 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2209
b4716021
PE
2210 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2211
811e9bac 2212 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2213 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2214 (x_own_selection, Fx_disown_selection_internal): Rename locals
2215 to avoid shadowing.
2216 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2217
7e3ab302
PE
2218 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2219 so that the caller can use some name other than gcpro1.
2220 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2221 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2222 (Fx_backspace_delete_keys_p):
2223 Use them to avoid shadowing, and rename vars to avoid shadowing.
2224 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2225 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2226 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2227 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2228 Remove unused locals.
7e3ab302
PE
2229 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2230 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2231 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2232 macros.
f78faa98 2233
e2b13473
PE
2234 * xterm.h (x_mouse_leave): New decl.
2235
77f23912
PE
2236 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2237 Remove unused functions.
cdf4ba58
PE
2238 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2239 (x_calc_absolute_position): Now static.
7411c686 2240 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2241 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2242 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2243 unless they are used.
38d0b34a
PE
2244 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2245 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2246 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2247 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2248 (x_error_catcher, x_connection_closed, x_error_handler):
2249 (x_error_quitter, xembed_send_message, x_iconify_frame):
2250 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2251 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2252 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2253
44f230aa
SM
2254 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2255 Rename or move locals to avoid shadowing.
6b463e58 2256 (tty_defined_color, merge_face_heights): Now static.
5967d051 2257 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2258 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2259 does not deduce is never used uninitialized.
73719eba
PE
2260 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2261 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2262
426994c3 2263 * terminal.c (store_terminal_param): Now static.
5489860b 2264
032f1620 2265 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2266 (set_frame_menubar): Remove unused local.
d4323972 2267 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2268 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2269 since they might point to immutable storage.
281585b0
PE
2270 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2271 since it's unused otherwise.
032f1620 2272
367c19e5 2273 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2274 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2275 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2276 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2277 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2278 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2279 does not deduce are never used uninitialized.
70739cbe 2280
07b48fa9
PE
2281 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2282
8868a238 2283 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2284 * window.c (window_loop, size_window):
2285 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2286
7e5cf297 2287 * window.c (display_buffer): Now static.
d6550a9f
PE
2288 (size_window): Mark variables that gcc -Wuninitialized
2289 does not deduce are never used uninitialized.
a586633d
PE
2290 * window.h (check_all_windows): New decl, to forestall
2291 gcc -Wmissing-prototypes diagnostic.
5b555da1 2292 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2293
f6095868
PE
2294 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2295 shadowing.
2296 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2297 Include <limits.h>.
2298 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2299 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2300 (load_charset_map): Mark variables that gcc -Wuninitialized
2301 does not deduce are never used uninitialized.
53df7c11 2302 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2303
f38b440c
PE
2304 * coding.c (coding_set_source, coding_set_destination):
2305 Use "else { /* comment */ }" rather than "else /* comment */;"
2306 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2307 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2308 a block, when the outer 'i' will do.
2309 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2310 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2311 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2312 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2313 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2314 Rename locals to avoid shadowing.
2315 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2316 * coding.c (emacs_mule_char, encode_invocation_designation):
2317 Now static, since they're not used elsewhere.
413bb2db 2318 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2319 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2320 (decode_coding_emacs_mule): Mark variables that gcc
2321 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2322 (detect_coding_iso_2022): Initialize a local variable that might
2323 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2324 this initialization is needed. (Bug#8211)
5f58e762
PE
2325 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2326 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2327 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2328 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2329 Remove unused macros.
f38b440c 2330
232b38b9 2331 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2332 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2333 * character.c (string_count_byte8): Likewise.
232b38b9 2334
fb90da1b
PE
2335 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2336 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2337
fb93dbc2
PE
2338 * chartab.c (copy_sub_char_table): Now static, since it's not used
2339 elsewhere.
5c156ace
PE
2340 (sub_char_table_ref_and_range, char_table_ref_and_range):
2341 Rename locals to avoid shadowing.
bbcd0949 2342 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2343
7d3b3862 2344 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2345 (BIDI_BOB): Remove unused macro.
7d3b3862 2346
6be7d3da
PE
2347 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2348 deduce are never used uninitialized.
c2ed9c8b 2349 * term.c (encode_terminal_code): Likewise.
6be7d3da 2350
75f8807f 2351 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2352
50938595
PE
2353 * tparam.h: New file.
2354 * term.c, tparam.h: Include it.
2355 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2356 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2357 Move these decls to tparam.h, and make them agree with what
2358 is actually in tparam.c. The previous trick of using incompatible
2359 decls in different modules does not conform to the C standard.
2360 All callers of tparam changed to use tparam's actual API.
2361 * tparam.c (tparam1, tparam, tgoto):
2362 Use const pointers where appropriate.
2363
fbceeba2
PE
2364 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2365 * cm.h (struct cm): Likewise.
2366 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2367 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2368 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2369 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2370 (turn_on_face, init_tty): Likewise.
2371 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2372
7f3f1250
PE
2373 * term.c (term_mouse_position): Rename local to avoid shadowing.
2374
e6ca6543
PE
2375 * alloc.c (mark_ttys): Move decl from here ...
2376 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2377
c40f8d15
AS
23782011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2379
2380 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2381
cfe0661d
JB
23822011-03-09 Juanma Barranquero <lekktu@gmail.com>
2383
2384 * search.c (compile_pattern_1): Remove argument regp, unused since
2385 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2386 (compile_pattern): Don't pass it.
2387
0afb4571
J
23882011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2389
2390 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2391 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2392 for ! HAVE_GTK3.
2393 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2394
2395 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2396
2397 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2398 gdk_window_get_screen, gdk_window_get_geometry,
2399 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2400 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2401 (xg_get_pixbuf_from_pixmap): New function.
2402 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2403 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2404 Call xg_get_pixbuf_from_pixmap instead of
2405 gdk_pixbuf_get_from_drawable.
2406 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2407 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2408 (xg_check_special_colors): Use GtkStyleContext and its functions
2409 for HAVE_GTK3.
2410 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2411 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2412 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2413 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2414 Call gtk_widget_get_preferred_size.
0afb4571
J
2415 (xg_frame_resized): gdk_window_get_geometry only takes 5
2416 parameters.
44f230aa
SM
2417 (xg_win_to_widget, xg_event_is_for_menubar):
2418 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2419 (xg_set_widget_bg): New function.
2420 (delete_cb): New function.
2421 (xg_create_frame_widgets): connect delete-event to delete_cb.
2422 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2423 (xg_set_background_color): Call xg_set_widget_bg.
2424 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2425 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2426 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2427 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2428 if ! HAVE_GTK3.
2429 (update_frame_tool_bar): Call gtk_widget_hide.
2430 (xg_initialize): Use GDK_KEY_g.
2431
2432 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2433 if ! HAVE_GTK3
2434 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2435
2436 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2437 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2438 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2439
1c2cc4ef
JB
24402011-03-08 Juanma Barranquero <lekktu@gmail.com>
2441
2442 * w32xfns.c (select_palette): Check success of RealizePalette against
2443 GDI_ERROR, not zero.
2444
33383987 2445See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2446
2447;; Local Variables:
2448;; coding: utf-8
aac0c6e3
MR
2449;; End:
2450
33383987 2451 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2452
2453 This file is part of GNU Emacs.
2454
2455 GNU Emacs is free software: you can redistribute it and/or modify
2456 it under the terms of the GNU General Public License as published by
2457 the Free Software Foundation, either version 3 of the License, or
2458 (at your option) any later version.
2459
2460 GNU Emacs is distributed in the hope that it will be useful,
2461 but WITHOUT ANY WARRANTY; without even the implied warranty of
2462 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2463 GNU General Public License for more details.
2464
2465 You should have received a copy of the GNU General Public License
2466 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.