More CL cleanups and reduction of use of cl.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
63e47e07
PE
12012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2
3 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4
c43fb4c3
GM
52012-07-11 Glenn Morris <rgm@gnu.org>
6
7 * s/darwin.h, s/gnu-linux.h, s/template.h:
8 Move INTERRUPT_INPUT to configure.
9
e8df9267
DA
102012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
11
12 Minor adjustments to interning code.
13 * lisp.h (intern, intern_c_string): Redefine as static inline
14 wrappers for intern_1 and intern_c_string_1, respectively.
15 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
16 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
17 Vobarray checking.
e8df9267
DA
18 * font.c (font_intern_prop): Likewise. Adjust comment.
19 * w32font.c (intern_font_name): Likewise.
20
34348bd4
AS
212012-07-11 Andreas Schwab <schwab@linux-m68k.org>
22
d96a1e0c
AS
23 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
24
34348bd4
AS
25 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
26 of Fcar/Fcdr if possible.
27 * font.c (check_otf_features): Likewise.
28 * fontset.c (Fnew_fontset): Likewise.
29 * gnutls.c (Fgnutls_boot): Likewise.
30 * minibuf.c (read_minibuf): Likewise.
31 * msdos.c (IT_set_frame_parameters): Likewise.
32 * xmenu.c (Fx_popup_dialog): Likewise.
33 * w32menu.c (Fx_popup_dialog): Likewise.
34
c8add24e
GM
352012-07-11 Glenn Morris <rgm@gnu.org>
36
4b575b3c
GM
37 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
38 since nothing has defined it on these platforms.
39
09f4e3b0
GM
40 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
41 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
42
172bedef
GM
43 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
44 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
45 Move CLASH_DETECTION to configure.
46
249685df
GM
47 * s/gnu.h: Remove file, which is now empty.
48
c8add24e
GM
49 * s/gnu.h, s/gnu-linux.h:
50 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
51
b41253a3
JW
522012-07-11 John Wiegley <johnw@newartisans.com>
53
54 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
55 function attribute, so we only use it if it exists in the
56 compiler.
57
d923b542
DA
582012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
59
60 Avoid call to strlen in fast_c_string_match_ignore_case.
61 * search.c (fast_c_string_match_ignore_case): Change to use
62 length argument. Adjust users accordingly.
63 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
64
5ebbef1d
PE
652012-07-11 Paul Eggert <eggert@cs.ucla.edu>
66
bb352260
PE
67 Assume mkdir, rmdir.
68 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
69 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
70
57054ddd
PE
71 Assume rename.
72 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
73
b747d3f7
PE
74 Assume perror.
75 * s/hpux10-20.h (HAVE_PERROR): Remove.
76 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
77 Remove dummy definition, as this problem was obsolete long ago.
78
5ebbef1d
PE
79 Assume strerror.
80 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
81
984e7f30
DA
822012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
83
84 Avoid calls to strlen in font processing functions.
85 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 86 (font_open_by_name): Change to use length argument. Adjust
984e7f30 87 users accordingly.
d923b542
DA
88 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
89 Adjust prototypes.
90 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
91 Change to return ptrdiff_t.
984e7f30
DA
92 (xfont_list_pattern, xfont_match): Use length returned by
93 xfont_decode_coding_xlfd.
94 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
95
20e94fdd
GM
962012-07-11 Glenn Morris <rgm@gnu.org>
97
9d596af3
GM
98 * s/darwin.h, s/freebsd.h, s/netbsd.h:
99 Move DONT_REOPEN_PTY to configure.
100
20e94fdd
GM
101 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
102 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
103
e99a530f
PE
1042012-07-10 Paul Eggert <eggert@cs.ucla.edu>
105
22ffb973
PE
106 Remove "#define unix" that is no longer needed (Bug#11905).
107 * s/aix4-2.h (unix): Remove; no longer needed.
108
e9a9ae03
PE
109 EMACS_TIME simplification (Bug#11875).
110 This replaces macros (which typically do not work in GDB)
111 with functions, typedefs and enums, making the code easier to debug.
112 The functional style also makes code easier to read and maintain.
113 * systime.h: Include <sys/time.h> on all hosts, not just if
114 WINDOWSNT, since 'struct timeval' is needed in general.
115 (EMACS_TIME): Now a typedef, not a macro.
116 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
117 not macros.
118 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
119 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
120 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
121 (EMACS_TIME_LE): Now functions, not macros.
122 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
123 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
124 which are not functions. All uses rewritten to use:
125 (make_emacs_time): New function.
126 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
127 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
128 not functions. All uses rewritten to use the following, respectively:
129 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
130 (add_emacs_time, sub_emacs_time): New functions.
131 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
132 * fileio.c (Fcopy_file):
133 * xterm.c (XTflash): Get the current time closer to when it's used.
134 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
135
ffacb126
PE
136 * bytecode.c (targets): Suppress -Woverride-init warnings.
137
e99a530f
PE
138 Simplify by avoiding confusing use of strncpy etc.
139 * doc.c (Fsnarf_documentation):
140 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
141 * frame.c (Fmake_terminal_frame):
142 * gtkutil.c (get_utf8_string):
143 * lread.c (openp):
144 * nsmenu.m (ns_update_menubar):
145 * regex.c (regerror):
146 Prefer memcpy to strncpy and strncat when either will do.
147 * fileio.c (Fsubstitute_in_file_name):
148 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
149 (menu_separator_name_p):
150 * nsmenu.m (ns_update_menubar):
151 Prefer memcmp to strncmp when either will do.
152 * nsterm.m: Include <ftoastr.h>.
153 (ns_get_color):
154 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
155 Prefer snprintf to strncpy.
156 * nsterm.m (ns_term_init):
157 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
158 * nsterm.m (ns_term_init):
159 Avoid the need for strncpy, by using build_string or
160 make_unibyte_string directly. Use dtoastr, not snprintf.
161 * process.c (Fmake_network_process): Diagnose service names that
162 are too long, rather than silently truncating them or creating
163 non-null-terminated names.
164 (Fnetwork_interface_info): Likewise, for interface names.
165 * sysdep.c (system_process_attributes) [GNU_LINUX]:
166 Prefer sprintf to strncat.
167 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
168 Prefer vsnprintf to vsprintf + strncpy.
169
c59592b3
GM
1702012-07-10 Glenn Morris <rgm@gnu.org>
171
172 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
173 Clarify fallback case.
174
7d7bbefd
DA
1752012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
176
177 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
178 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
179 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 180 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
181 where argument type is known to be a Lisp_Cons.
182
3a4c8000
TT
1832012-07-10 Tom Tromey <tromey@redhat.com>
184
185 * bytecode.c (BYTE_CODE_THREADED): New macro.
186 (BYTE_CODES): New macro. Replaces all old byte-code defines.
187 (enum byte_code_op): New type.
188 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
189 (exec_byte_code): Use them. Use token threading when applicable.
190
2a0213a6
DA
1912012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
192
193 Optimize pure C strings initialization.
194 * lisp.h (make_pure_string): Fix prototype.
195 (build_pure_c_string): New function, defined as static inline. This
196 provides a better opportunity to optimize away calls to strlen when
197 the function is called with compile-time constant argument.
198 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
199 argument, adjust users accordingly. Use build_pure_c_string where
200 appropriate.
201 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
202 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
203 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
204
cb1caeaf
DA
2052012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
206
207 Avoid calls to strlen in miscellaneous functions.
208 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
209 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
210 * lread.c (openp): Likewise.
211
c293e30c
DA
2122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
213
214 Avoid calls to strlen in path processing functions.
215 * fileio.c (file_name_as_directory): Add comment. Change to add
216 srclen argument and return the length of result. Adjust users
217 accordingly.
218 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 219 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
220 users accordingly.
221 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
222
9e059e3f
GM
2232012-07-10 Glenn Morris <rgm@gnu.org>
224
d02eb359
GM
225 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
226 Move PENDING_OUTPUT_COUNT definition to configure.
227
882cf227
GM
228 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
229 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
230 * s/gnu.h (DATA_START): Move definitions to configure.
231
af6e839f
GM
232 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
233 We include usg5-4-common.h, which defines them both.
234
40289a12
GM
235 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
236 O_RDONLY already includes it).
237
9e059e3f
GM
238 Stop ns builds setting the EMACSLOADPATH environment variable.
239 * nsterm.m (ns_load_path): Rename from ns_init_paths.
240 Now it does not set EMACSLOADPATH, just returns the load-path string.
241 * nsterm.h: Update accordingly.
242 * lread.c [HAVE_NS]: Include nsterm.h.
243 (init_lread) [HAVE_NS]: Use ns_load_path.
244 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
245
7c4e8ec0
GM
2462012-07-09 Glenn Morris <rgm@gnu.org>
247
d4f600ff
GM
248 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
249 since the included bsd-common.h does so.
250
cbb31951
GM
251 Stop ns builds setting the EMACSPATH environment variable.
252 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
253 (ns_init_paths): Do not set EMACSPATH.
254 * nsterm.h (ns_exec_path): Add it.
255 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
256 Use ns_exec_path.
257
7c4e8ec0
GM
258 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
259
26bccfae
PE
2602012-07-09 Paul Eggert <eggert@cs.ucla.edu>
261
a0bee46f
PE
262 * process.c (wait_reading_process_output): 'waitchannels' was unset
263 when read_kbd || !NILP (wait_for_cell); fix this.
264
5994c183
PE
265 Add GCC-style 'const' attribute to functions that can use it.
266 * character.h (char_resolve_modifier_mask):
267 * keyboard.h (make_ctrl_char):
268 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
269 (init_character_once, next_almost_prime, init_fns, init_image)
270 (flush_pending_output, init_sound):
271 * mem-limits.h (start_of_data):
272 * menu.h (finish_menu_items):
273 Add ATTRIBUTE_CONST.
274 * emacs.c (DEFINE_DUMMY_FUNCTION):
275 Declare the dummy function with ATTRIBUTE_CONST.
276 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
277 Add decls with ATTRIBUTE_CONST.
278
26bccfae
PE
279 Minor improvements to make_formatted_string.
280 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
281 where int is good enough, as vsprintf returns an int.
282 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
283
a8290ec3
DA
2842012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
285
286 Use make_formatted_string to avoid double length calculation.
287 * lisp.h (make_formatted_string): New prototype.
288 * alloc.c (make_formatted_string): New function.
289 * buffer.c (Fgenerate_new_buffer_name): Use it.
290 * dbus.c (syms_of_dbusbind): Likewise.
291 * editfns.c (Fcurrent_time_zone): Likewise.
292 * filelock.c (get_boot_time): Likewise.
293 * frame.c (make_terminal_frame, set_term_frame_name)
294 (x_report_frame_params): Likewise.
295 * image.c (gs_load): Likewise.
296 * minibuf.c (get_minibuffer): Likewise.
297 * msdos.c (dos_set_window_size): Likewise.
298 * process.c (make_process): Likewise.
299 * xdisp.c (ensure_echo_area_buffers): Likewise.
300 * xsettings.c (apply_xft_settings): Likewise.
301
d01ba2f1
GM
3022012-07-09 Glenn Morris <rgm@gnu.org>
303
304 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
305 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
306 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
307 * nsterm.h (ns_etc_directory): Add it.
308 * callproc.c [HAVE_NS]: Include nsterm.h.
309 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
310
f1f924b6
DA
3112012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Move marker debugging code under MARKER_DEBUG.
314 * marker.c (MARKER_DEBUG): Move marker debugging code under
315 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
316 for bootstrap with --enable-checking (~3x slowdown reported
317 by Juanma Barranquero <lekktu@gmail.com>).
318 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
319
ab531b66
PE
3202012-07-08 Paul Eggert <eggert@cs.ucla.edu>
321
322 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
323 See <http://bugs.gnu.org/11825#29>.
324
c4b3bc8a
EZ
3252012-07-08 Eli Zaretskii <eliz@gnu.org>
326
327 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
328 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
329 (display_line): Add commentary about displaying truncation glyphs
330 on GUI frames.
331 (produce_special_glyphs): Move here from term.c.
332
333 * term.c (produce_special_glyphs): Move to xdisp.c.
334
335 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
336 section.
c4b3bc8a 337
b676b881
AS
3382012-07-07 Andreas Schwab <schwab@linux-m68k.org>
339
f17c5273
AS
340 * xdisp.c (display_line): Avoid warning about implicit declaration
341 of FRAME_FONT.
342
298819b9
AS
343 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
344
b676b881
AS
345 * lisp.h: Remove empty conditional.
346
6045c4fd
PE
3472012-07-07 Paul Eggert <eggert@cs.ucla.edu>
348
b3350bf9
PE
349 * lread.c (load_path_check): Now static.
350
6045c4fd
PE
351 Fix some minor --with-ns problems found by static checking.
352 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
353 (x_set_font) [!HAVE_X_WINDOWS]:
354 * image.c (xpm_load_image) [HAVE_NS]:
355 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
356 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
357 Remove unused local.
358 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
359 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
360 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
361 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
362 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
363 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
364 Fix pointer signedness problem.
365 * xfaces.c (FRAME_X_FONT_TABLE):
366 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
367
929e7845
GM
3682012-07-07 Glenn Morris <rgm@gnu.org>
369
370 * lread.c (load_path_check): New function, split from init_lread.
371 (init_lread): Reorganize. Motivation:
372 If EMACSLOADPATH is set, check/warn about that rather than the
373 defaults, which we are not going to use. Hence we can remove
374 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
375 Don't warn if site-lisp directories are missing.
376 If not installed, start from a blank load-path, since
377 PATH_LOADSEARCH refers to the eventual installation directories.
378
58dd0aa4
EZ
3792012-07-07 Eli Zaretskii <eliz@gnu.org>
380
381 Support truncation and continuation glyphs on GUI frames, when
382 fringes are disabled. (Bug#11832)
383 * xdisp.c (init_iterator): Get dimensions of truncation and
384 continuation glyphs even if on GUI frames. Adjust
385 it->last_visible_x on GUI frames when the left or right fringes,
386 or both, are absent.
387 (start_display, move_it_in_display_line_to): Handle the case of a
388 GUI frame without a fringe to display continuation or truncation
389 glyphs.
390 (insert_left_trunc_glyphs): Support GUI frames: make sure
391 truncation glyphs overwrite enough glyphs from the current line to
392 have sufficient space in pixels.
393 (display_line): Support truncation and continuation glyphs on GUI
394 frames. If some spare pixels are left on the line after inserting
395 the truncation glyphs, fill that space with a stretch glyph of a
396 suitably computed width.
397
398 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
399 produce_glyphs, to support GUI sessions.
400
31571fd7
PE
4012012-07-07 Paul Eggert <eggert@cs.ucla.edu>
402
5a16b9bc
PE
403 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
404
f3047c75
PE
405 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
406
31571fd7
PE
407 Do not require float-time's arg to fit in time_t (Bug#11825).
408 This works better on hosts where time_t is unsigned, and where
409 float-time is applied to the (negative) difference between two times.
410 * editfns.c (decode_time_components): Last arg is now double *,
411 not int *, and means to store all the result as a double, without
412 worrying about whether the seconds part fits in time_t.
413 All callers changed.
414 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
415 All callers changed.
416 (Ffloat_time): Do not fail merely because the specified time falls
417 outside of time_t range.
418
4516fbef
GM
4192012-07-07 Glenn Morris <rgm@gnu.org>
420
421 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
422 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
423 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
424
07adc2c6
JB
4252012-07-07 Juanma Barranquero <lekktu@gmail.com>
426
427 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
428 Update dependencies.
429
430 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
431
fd573f31
PE
4322012-07-06 Paul Eggert <eggert@cs.ucla.edu>
433
fee5959d
PE
434 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
435 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
436 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
437 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
438 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
439 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
440
fd573f31
PE
441 * xfont.c (compare_font_names): Redo to omit the need for casts.
442
ddadbc0e
AS
4432012-07-06 Andreas Schwab <schwab@linux-m68k.org>
444
fca8d6b6
AS
445 * xfns.c (Fx_change_window_property): Doc fix.
446 * w32fns.c (Fx_change_window_property): Doc fix.
447
ddadbc0e
AS
448 * w32fns.c (Fx_window_property): Accept the same arguments as the
449 X Windows version. Doc fix.
450 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
451
f247498e
JB
4522012-07-06 Juanma Barranquero <lekktu@gmail.com>
453 Eli Zaretskii <eliz@gnu.org>
454
455 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
456 Windows-specific code from nt/config.nt moved here.
457 Obsolete settings removed.
458
216ee680
PE
4592012-07-06 Paul Eggert <eggert@cs.ucla.edu>
460
461 * process.c: Avoid unnecessary calls to gettime.
462 (wait_reading_process_output): Don't get the time of day
463 when gobbling data immediately and not waiting, as there's no need
464 for it in that case. This removes a FIXME.
465
bdd091e4
JD
4662012-07-06 Jan Djärv <jan.h.d@swipnet.se>
467
468 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
469 is defined (Bug#11768).
470
9d44f8ce
DA
4712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
472
473 Fix marker debugging code.
474 * marker.c (byte_char_debug_check): Do not perform the check
475 if buffer is not multibyte.
090bd7cb
JB
476 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
477 Call byte_char_debug_check with correct arguments.
9d44f8ce 478
90fc4786
DA
4792012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
480
481 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
482 * marker.c (byte_char_debug_check, count_markers):
483 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
484 (byte_debug_flag): Remove.
485 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
486 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
487
7b7ae965
DA
4882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
489
4e57b342
DA
490 Avoid code repetition in marker-related functions.
491 * marker.c (attach_marker): New function.
492 (Fset_marker, set_marker_restricted, set_marker_both)
493 (set_marker_restricted_both): Use it.
494 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
495 Consistently rename charno to charpos.
496 (marker_position): Add eassert.
497 (marker_byte_position): Convert to eassert.
498
4992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
500
501 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 502 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 503 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 504
657924ff
DA
5052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
506
507 Introduce fast path for the widely used marker operation.
508 * alloc.c (build_marker): New function.
509 * lisp.h (build_marker): New prototype.
510 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
511 * composite.c (autocmp_chars): Likewise.
512 * editfns.c (buildmark): Remove.
513 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
514 (save_restriction_save): Use build_marker.
515 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
516 * window.c (save_window_save): Likewise.
517
041a49a6
DA
5182012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Do not use Fdelete_overlay in delete_all_overlays
521 to avoid redundant calls to unchain_overlay.
522 * buffer.c (drop_overlay): New function.
523 (delete_all_overlays, Fdelete_overlay): Use it.
524 * minibuf.c (get_minibuffer): Fix comment.
525
7dca65a4
PE
5262012-07-06 Paul Eggert <eggert@cs.ucla.edu>
527
528 Port to OpenBSD 5.1 amd64.
529 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
530 This is needed for OpenBSD, and should be harmless on all BSD systems.
531 Also, include <sys/sysctl.h>, as it should be available on all
532 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
533 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
534 use p_pid member, not kp_proc.pid.
535
8eb876e2
GM
5362012-07-06 Glenn Morris <rgm@gnu.org>
537
538 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
539
38182d90
PE
5402012-07-05 Paul Eggert <eggert@cs.ucla.edu>
541
542 More xmalloc and related cleanup.
543 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
544 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
545 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
546 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
547 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
548 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
549 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
550 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
551 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
552 * xterm.c:
553 Omit needless casts involving void * pointers and allocation.
554 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
555 as the former is more robust if P's type is changed.
556 Prefer xzalloc to xmalloc + memset 0.
557 Simplify malloc-or-realloc to realloc.
558 Don't worry about xmalloc returning a null pointer.
559 Prefer xstrdup to xmalloc + strcpy.
560 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
561 growing it.
562 * keyboard.c (apply_modifiers_uncached): Prefer local array to
563 alloca of a constant.
564
6dd5a677
EZ
5652012-07-05 Eli Zaretskii <eliz@gnu.org>
566
567 * xdisp.c (display_line): Fix horizontal pixel coordinates when
568 hscroll is larger than the line width. Fixes long and futile
569 looping inside extend_face_to_end_of_line (on a TTY) producing
570 glyphs that are not needed and thrown away.
571
6b312f0f
DA
5722012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
573
574 * marker.c (set_marker_restricted_both): Simplify by using
575 clip_to_bounds.
576
f520ef9b
PE
5772012-07-05 Paul Eggert <eggert@cs.ucla.edu>
578
579 * editfns.c (region_limit): Simplify by using clip_to_bounds.
580
383b7c95
JD
5812012-07-05 Jan Djärv <jan.h.d@swipnet.se>
582
583 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
584 not defined (Bug#11768).
585 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
586 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
587 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
588 followed by gtk_box_set_homogeneous (Bug#11768).
589 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
590 (update_theme_scrollbar_width, xg_create_scroll_bar):
591 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
592 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
593 (is_box_type): New function (Bug#11768).
594 (xg_tool_item_stale_p): Call is_box_type.
5293d758 595 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
596 with default display (Bug#11768).
597
d6e7bf45
EZ
5982012-07-05 Eli Zaretskii <eliz@gnu.org>
599
600 * xdisp.c (window_hscroll_limited): New function.
601 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
602 coordinates when window's hscroll is set to insanely large
603 values. (Bug#11857)
604
431391ec
JB
6052012-07-05 Juanma Barranquero <lekktu@gmail.com>
606
607 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
608 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
609
23f86fce
DA
6102012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
611
612 Cleanup xmalloc.
613 * lisp.h (xzalloc): New prototype. Omit needless casts.
614 * alloc.c (xzalloc): New function. Omit needless casts.
615 * charset.c: Omit needless casts. Convert all calls to
616 xmalloc with following memset to xzalloc.
617 * dispnew.c: Likewise.
618 * fringe.c: Likewise.
619 * image.c: Likewise.
620 * sound.c: Likewise.
621 * term.c: Likewise.
622 * w32fns.c: Likewise.
623 * w32font.c: Likewise.
624 * w32term.c: Likewise.
625 * xfaces.c: Likewise.
626 * xfns.c: Likewise.
627 * xterm.c: Likewise.
628 * atimer.c: Omit needless casts.
629 * buffer.c: Likewise.
630 * callproc.c: Likewise.
631 * ccl.c: Likewise.
632 * coding.c: Likewise.
633 * composite.c: Likewise.
634 * doc.c: Likewise.
635 * doprnt.c: Likewise.
636 * editfns.c: Likewise.
637 * emacs.c: Likewise.
638 * eval.c: Likewise.
639 * filelock.c: Likewise.
640 * fns.c: Likewise.
641 * gtkutil.c: Likewise.
642 * keyboard.c: Likewise.
643 * lisp.h: Likewise.
644 * lread.c: Likewise.
645 * minibuf.c: Likewise.
646 * msdos.c: Likewise.
647 * print.c: Likewise.
648 * process.c: Likewise.
649 * region-cache.c: Likewise.
650 * search.c: Likewise.
651 * sysdep.c: Likewise.
652 * termcap.c: Likewise.
653 * terminal.c: Likewise.
654 * tparam.c: Likewise.
655 * w16select.c: Likewise.
656 * w32.c: Likewise.
657 * w32reg.c: Likewise.
658 * w32select.c: Likewise.
659 * w32uniscribe.c: Likewise.
660 * widget.c: Likewise.
661 * xdisp.c: Likewise.
662 * xmenu.c: Likewise.
663 * xrdb.c: Likewise.
664 * xselect.c: Likewise.
665
0497dc44
PE
6662012-07-05 Paul Eggert <eggert@cs.ucla.edu>
667
668 * fileio.c (time_error_value): Check the right error number.
669 Problem reported by Troels Nielsen in
670 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
671
356e7178
PE
6722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
673
4e71fd89
PE
674 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
675 This should be fixed in a better way; see Eli Zaretskii in
676 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
677 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
678
f0941253
PE
679 * fileio.c (time_error_value): Rename from special_mtime.
680 The old name's problems were noted by Eli Zaretskii in
681 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
682
065c9eb4
PE
683 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
684 This variable's comment says Emacs needs at least one GDB-visible
685 symbol of type enum pvec_type, to work around GDB problems.
686 The symbol's value doesn't matter.
687
356e7178
PE
688 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
689 that causes compilation to fail on pre-C99 compilers.
690
95f61aa2
JB
6912012-07-04 Juanma Barranquero <lekktu@gmail.com>
692
693 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
694 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
695
3884d954
DA
6962012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
697
d209e2fb 698 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
699 headers for buffer_defaults and buffer_local_symbols.
700 Reported by Juanma Barranquero <lekktu@gmail.com>.
701
ee28be33
SM
7022012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
703
704 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
705 * lisp.h (enum pvec_type): Use fewer bits.
706 (PSEUDOVECTOR_SIZE_BITS): New constant.
707 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
708 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
709 change in pvec_type.
710 (PSEUDOVECTOR_TYPEP): New macro.
711 (TYPED_PSEUDOVECTORP): Use it.
712 * fns.c (internal_equal): Adapt code to extract pvectype.
713 * emacs.c (gdb_pvec_type): Update type.
714 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
715 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
716 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
717 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
718 (sweep_vectors): Use it. Use local var `total_bytes' instead of
719 abusing vector->header.next.nbytes.
720 (live_vector_p): Use PVEC_TYPE.
721 (mark_object): Adapt code to extract pvectype. Use switch.
722
c7f2cd7f
PE
7232012-07-04 Paul Eggert <eggert@cs.ucla.edu>
724
725 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
726 Tighten new eassert a bit.
727
8ce70ed2
DA
7282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
729
730 Fix compilation with --enable-gcc-warnings and -O1
731 optimization level.
732 * doprnt.c (doprnt): Change type of tem to int, initialize
733 to avoid compiler warning. Add eassert.
734 * search.c (simple_search): Initialize match_byte to avoid
735 compiler warning. Add eassert.
736
dea7f1e5
PE
7372012-07-04 Paul Eggert <eggert@cs.ucla.edu>
738
24a212eb
PE
739 Avoid weird behavior with large horizontal scrolls.
740 Without this change, for example, large hscroll values would
741 mess up Emacs's display on Fedora 15 x86, presumably due to
742 overflows in int calculations in the display code.
743 Also, if buffers had long lines, Emacs would freeze.
744 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
745 (set_window_hscroll): New function, containing the old guts of
746 Fset_window_hscroll. Return the clipped value.
747 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
748 This avoids the need to check against PTRDIFF_MAX.
749
dea7f1e5
PE
750 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
751
76046526
DA
7522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
753
754 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
755
39adff0d
PE
7562012-07-04 Paul Eggert <eggert@cs.ucla.edu>
757
63807d47
PE
758 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
759 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
760 since GCC 4.4.6 issues a bogus warning for them.
761
39adff0d
PE
762 Fix bugs in file timestamp newness comparisons.
763 * fileio.c (Ffile_newer_than_file_p):
764 * lread.c (Fload): Use full timestamp resolution of files,
765 not just the 1-second resolution, so that files that are only
766 slightly newer still count as newer.
767 * fileio.c (Ffile_newer_than_file_p): Don't assume file
768 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
769
dbeed9a6
PE
7702012-07-03 Paul Eggert <eggert@cs.ucla.edu>
771
772 * fileio.c: Improve handling of file time marker. (Bug#11852)
773 (special_mtime): New function.
774 (Finsert_file_contents, Fverify_visited_file_modtime):
775 Use it to set special mtime values consistently.
776
636334d6
AS
7772012-07-03 Andreas Schwab <schwab@linux-m68k.org>
778
779 * fileio.c (Finsert_file_contents): Properly handle st_mtime
780 marker for non-existing file. (Bug#11852)
781
e2017fe2
GM
7822012-07-03 Glenn Morris <rgm@gnu.org>
783
784 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
785 and did not make it into globals.h).
786
404dbd37
TT
7872012-07-03 Tom Tromey <tromey@redhat.com>
788
789 * window.c (Fset_window_margins, Fset_window_fringes)
790 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
791 * textprop.c (Fprevious_property_change): No longer static.
792 * syntax.c (Fsyntax_table_p): No longer static.
793 * process.c (Fget_process, Fprocess_datagram_address): No longer
794 static.
795 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
796 * keyboard.c (Fcommand_execute): No longer static.
797 Remove EXFUN.
798 * insdel.c (Fcombine_after_change_execute): No longer static.
799 * image.c (Finit_image_library): No longer static.
800 * fileio.c (Fmake_symbolic_link): No longer static.
801 * eval.c (Ffetch_bytecode): No longer static.
802 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
803 * doc.c (Fdocumentation_property, Fsnarf_documentation):
804 No longer static.
404dbd37
TT
805 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
806 static.
807 * dired.c (Ffile_attributes): No longer static.
808 * composite.c (Fcomposition_get_gstring): No longer static.
809 * callproc.c (Fgetenv_internal): No longer static.
810
811 * ccl.h: Remove EXFUNs.
812 * buffer.h: Remove EXFUNs.
813 * dispextern.h: Remove EXFUNs.
814 * intervals.h: Remove EXFUNs.
815 * fontset.h: Remove EXFUN.
816 * font.h: Remove EXFUNs.
817 * dosfns.c (system_process_attributes): Remove EXFUN.
818 * keymap.h: Remove EXFUNs.
819 * lisp.h: Remove EXFUNs.
820 * w32term.h: Remove EXFUNs.
821 * window.h: Remove EXFUNs.
822 * xsettings.h: Remove EXFUN.
823 * xterm.h: Remove EXFUN.
824
8e4fd1e1
GM
8252012-07-03 Glenn Morris <rgm@gnu.org>
826
827 * lisp.h (Frandom): Make it visible to C.
828 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
829 buffer for invisible buffers. (Bug#1229)
830
ca95b3eb
DA
8312012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
832
833 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
834 values which aren't power of 2.
835 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
836 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
837 accordingly.
838
7555c33f
SM
8392012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
840
841 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
842
843 * alloc.c (mark_object): Revert part of last patch to use `switch'.
844
d12e8f5a
DA
8452012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
846
847 * alloc.c (allocate_vector_block): Remove redundant
848 calls to mallopt if DOUG_LEA_MALLOC is defined.
849 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
850 avoid calls to mallopt if zero_vector is returned.
851
296094c3
DA
8522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
853
854 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
855 is enabled, avoid dereferencing NULL current_sblock if
856 running undumped.
857
36429c89
DA
8582012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
859
860 Cleanup basic buffer management.
861 * buffer.h (struct buffer): Change layout to use generic vector
862 marking code. Fix some comments. Change type of 'clip_changed'
863 to bitfield. Remove unused #ifndef old.
864 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
865 (GET_OVERLAYS_AT): Fix indentation.
866 (for_each_per_buffer_object_at): New macro.
867 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
868 (Fbuffer_local_variables): Use it.
869 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
870 * alloc.c (allocate_buffer): Adjust to match new layout of
871 struct buffer. Fix comment.
872 (mark_overlay): New function.
873 (mark_buffer): Use it. Use mark_vectorlike to mark normal
874 Lisp area of struct buffer.
875 (mark_object): Use it. Adjust marking of misc objects
876 and related comments.
877
3b3e4cac
PE
8782012-07-02 Paul Eggert <eggert@cs.ucla.edu>
879
880 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
881 wrapper that is not needed because the wrapped code is a no-op (zero
882 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
883 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
884
cf5c0175
DA
8852012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
886
887 * alloc.c (mark_buffer): Simplify. Remove prototype.
888 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 889 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
890 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
891 redundant calls to mark_vectorlike for bool vectors.
892
ca26824c
GM
8932012-06-30 Glenn Morris <rgm@gnu.org>
894
2e4c5312
GM
895 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
896
ca26824c
GM
897 * epaths.in (PATH_SITELOADSEARCH): New.
898 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
899 This is rather than relying on --enable-locallisppath elements
900 having "site-lisp" in their names. (Bug#10208#25, 11658)
901
0d23c240
EZ
9022012-06-30 Eli Zaretskii <eliz@gnu.org>
903
c9240d7a
EZ
904 * w32proc.c (sys_select): Accept and ignore one more argument.
905
906 * w32.c (emacs_gnutls_pull): Call select with one more argument.
907
0d23c240 908 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 909 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
910
911 * sysdep.c: Don't include dos.h and dosfns.h.
912
913 * process.c (sys_select):
914 * msdos.c (sys_select): Accept one more argument and ignore it.
915
916 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
917 adapt data types and code to that.
918
919 * dosfns.c:
920 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
921 which clashes with the gnulib function of the same name.
922
af5a5a98
AS
9232012-06-30 Andreas Schwab <schwab@linux-m68k.org>
924
c5e4379c
AS
925 * font.c (font_style_to_value, font_style_symbolic)
926 (font_prop_validate_style): Add type checks for values in
927 font_style_table.
928
af5a5a98
AS
929 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
930 argument.
931 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
932 uses.
933
8d38f461
EZ
9342012-06-29 Eli Zaretskii <eliz@gnu.org>
935
2e5a6631
EZ
936 * xdisp.c (try_window_id): Undo last change.
937
8d38f461
EZ
938 * w32.c (getwd): Adjust commentary about startup_dir.
939 (init_environment): Always call sys_access, even in non-MSVC
940 builds. Don't chdir to the directory of the Emacs executable.
941 This undoes code from 1997 which was justified by the need to
942 "avoid conflicts when removing and renaming directories". But its
943 downside was that every relative file name was being interpreted
944 relative to the directory of the Emacs executable, which can never
945 be TRT. In particular, it broke sys_access when called with
946 relative file names.
947 (sys_access): Map GetLastError to errno.
948
2af3565e
DA
9492012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * window.h (struct window): Change type of 'fringes_outside_margins'
952 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 953 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
954 Adjust comment.
955 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
956 to ptrdiff_t.
957
c8d3a25c 9582012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 959
c8d3a25c
GM
960 * gnutls.c (emacs_gnutls_handshake):
961 Add QUIT to make the loop interruptible.
57570cd3 962
c8d3a25c 9632012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 964
c8d3a25c
GM
965 * charset.c (init_charset): Make lack of etc/charsets fatal.
966
3e984ee8
DA
9672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
968
969 * editfns.c (region_limit): Fix type mismatch.
970
ef884f23
DA
9712012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
972
973 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
974 undefined. Convert from xassert to eassert.
975 * nsmenu.m: Convert from xassert to eassert.
976 * nsterm.m: Likewise.
977
7d7e0027
SM
9782012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
979
980 * editfns.c (region_limit): Clip to narrowing (bug#11770).
981
aa754e6a
PE
9822012-06-28 Paul Eggert <eggert@cs.ucla.edu>
983
984 Avoid integer overflow on scroll-left and scroll-right.
985 * window.c (HSCROLL_MAX): New macro.
986 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
987 overflow when requested scroll falls outside ptrdiff_t range.
988
80b00b08
DA
9892012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
990
991 * window.h (struct window): Change type of 'hscroll',
992 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
993 'last_modified' and 'last_overlay_modified' to EMACS_INT.
994 Adjust users accordingly.
995 * xdisp.c (try_cursor_movement): Replace type check with eassert.
996 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
997 from EMACS_INT to ptrdiff_t.
998 (make_window): Omit redundant initialization.
999
62b2bcf6
JB
10002012-06-28 Juanma Barranquero <lekktu@gmail.com>
1001
1002 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1003
45942c7d
DA
10042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1005
1006 * window.h (struct window): Change type of 'use_time' and
1007 'sequence_number' from Lisp_Object to int.
1008 * frame.c (make_frame): Adjust users accordingly.
1009 * print.c (print_object): Likewise.
1010 * window.c (select_window, Fwindow_use_time, make_parent_window)
1011 (make_window): Likewise.
1012
e509cfa6
DA
10132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1016 enabled with --enable-checking=[all,glyphs] configure option.
1017 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1018 adjust comments accordingly.
1019 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1020 undefined, adjust comments accordingly.
1021 * image.c: Likewise.
1022 * scroll.c: Likewise.
1023 * w32fns.c: Likewise.
1024 * w32term.c: Likewise.
1025 * xdisp.c: Likewise.
1026 * xfaces.c: Likewise.
1027 * xfns.c: Likewise.
1028 * xterm.c: Likewise.
1029
a54e2c05
DA
10302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 Generalize run-time debugging checks.
1033 * dispextern.h (XASSERTS): Remove.
1034 * fontset.c (xassert): Remove.
1035 Convert from xassert to eassert.
1036 * alloc.c: Convert from xassert to eassert.
1037 * bidi.c: Likewise.
1038 * dispnew.c: Likewise.
1039 * fns.c: Likewise.
1040 * fringe.c: Likewise.
1041 * ftfont.c: Likewise.
1042 * gtkutil.c: Likewise.
1043 * image.c: Likewise.
1044 * keyboard.c: Likewise.
1045 * menu.c: Likewise.
1046 * process.c: Likewise.
1047 * scroll.c: Likewise.
1048 * sound.c: Likewise.
1049 * term.c: Likewise.
1050 * w32console.c: Likewise.
1051 * w32fns.c: Likewise.
1052 * w32term.c: Likewise.
1053 * window.c: Likewise.
1054 * xdisp.c: Likewise.
1055 * xfaces.c: Likewise.
1056 * xfns.c: Likewise.
1057 * xselect.c: Likewise.
1058 * xterm.c: Likewise.
1059
1ec4b7b2
SM
10602012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1061
1062 * fns.c (maybe_resize_hash_table): Output message when growing the
1063 purify-hashtable.
1064
2014308a
DA
10652012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1066
1067 * alloc.c (allocate_string_data): Remove dead code.
1068 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1069 avoid GCC warning about unused macro.
1070
246155eb
DA
10712012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 * alloc.c (allocate_string): Omit intervals initialization.
1074 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1075 as in make_pure_string and make_pure_c_string.
1076
43184b7b
DA
10772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1078
d209e2fb 1079 * alloc.c (allocate_string): Fix last change.
43184b7b 1080
3fe6dd74
DA
10812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1082
d209e2fb 1083 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1084 to memset, add explicit initialization where appropriate.
1085
1ba6038a
GM
10862012-06-27 Glenn Morris <rgm@gnu.org>
1087
1088 * lisp.mk (lisp): Remove paths.elc.
1089
c89926a5
CY
10902012-06-27 Chong Yidong <cyd@gnu.org>
1091
1092 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1093
ed6b3510
JW
10942012-06-26 John Wiegley <johnw@newartisans.com>
1095
1ec4b7b2 1096 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1097 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1098
ed6b3510
JW
1099 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1100 when building with Clang.
1101
8edd4a2b
SM
11022012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1103
1104 * eval.c (Fapply): Allow calling it with a single argument.
1105
f6f62d1b
EZ
11062012-06-26 Eli Zaretskii <eliz@gnu.org>
1107
1108 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1109 _stricmp and _strnicmp.
1110 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1111
62efea5e
DA
11122012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1113
1114 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1115 allocated window.
1116 (allocate_process): Likewise for new process.
8edd4a2b 1117 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1118 (allocate_frame): Likewise.
1119 * frame.c (make_frame): Omit redundant initialization.
1120 * window.c (make_parent_window): Use memset.
1121 (make_window): Omit redundant initialization.
1122 * process.c (make_process): Omit redundant initialization.
1123 * terminal.c (create_terminal): Likewise.
1124
42997f4d
DA
11252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1126
1127 * term.c (delete_tty): Remove redundant call to memset.
1128
1130ecfc
DA
11292012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 * alloc.c: Remove build_string.
1132 * lisp.h: Define build_string as static inline. This provides
1133 a better opportunity to optimize away calls to strlen when the
1134 function is called with compile-time constant argument.
1135 * image.c (imagemagick_error): Convert to build_string.
1136 * w32proc.c (sys_spawnve): Likewise.
1137 * xterm.c (x_term_init): Likewise.
1138
cf38a720
PE
11392012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1140
99027bdd
PE
1141 Use sprintf return value instead of invoking strlen on result.
1142 In the old days this wasn't portable, since some sprintf
1143 implementations returned char *. But they died out years ago and
1144 Emacs already assumes sprintf returns int.
1145 Similarly for float_to_string.
1146 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1147 * ccl.c (ccl_driver):
1148 * character.c (string_escape_byte8):
1149 * data.c (Fnumber_to_string):
1150 * doprnt.c (doprnt):
1151 * print.c (print_object):
1152 * xdisp.c (message_dolog):
1153 * xfns.c (syms_of_xfns):
1154 Use sprintf or float_to_string result to avoid need to call strlen.
1155 * data.c (Fnumber_to_string):
1156 Use make_unibyte_string, since the string must be ASCII.
1157 * lisp.h, print.c (float_to_string): Now returns int length.
1158 * term.c (produce_glyphless_glyph):
1159 Use sprintf result rather than recomputing it.
1160
cf38a720
PE
1161 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1162 * Makefile.in (ALL_CFLAGS):
1163 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1164 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1165
3511c784
DA
11662012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1167
0a08eb21 1168 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1169 strcasecmp if available.
1170 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1171
fb7da12e
AS
11722012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1173
1174 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1175 Avoid comma operator.
1176 * menu.c (push_submenu_start, push_submenu_end)
1177 (push_left_right_boundary, push_menu_pane): Likewise.
1178 * msdos.c (dos_rawgetc): Likewise.
1179
afa2ffd8
DA
11802012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1181
1182 * xfns.c (xic_create_fontsetname): Remove redundant calls
1183 to memset.
1184
b3b4476b
PE
11852012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1186
4495ff38
PE
1187 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1188 sprintf already null-terminates its output.
1189
b3b4476b
PE
1190 * xfns.c (x_window): Remove redundant cast.
1191
b00876c9
DA
11922012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1193
1194 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1195 `const char *' to `char *' to avoid compiler warning.
1196
d188e26b
PE
11972012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1198
885d1d74
PE
1199 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1200 instead of truncating it to 63 (admittedly a generous limit).
1201
d188e26b
PE
1202 * process.c: Fix spelling and caps in comments.
1203
e2f560b1
DN
12042012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1205
e86db54b 1206 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1207 * sysdep.c (setpgrp): Remove definition, not used in this file.
1208
7583a3a1
JB
12092012-06-24 Juanma Barranquero <lekktu@gmail.com>
1210
1211 * makefile.w32-in: Update dependencies.
1212
696056c2
EZ
12132012-06-24 Eli Zaretskii <eliz@gnu.org>
1214
1215 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1216 (SYSTIME_H): Add nt/inc/sys/time.h.
1217
1218 * systime.h [WINDOWSNT]: Include sys/time.h.
1219
1220 * s/ms-w32.h (struct timespec): Definition moved from
1221 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1222
845ca893
PE
12232012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1226 * buffer.h (buffer_slot_type_mismatch):
1227 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1228 * eval.c (unwind_to_catch):
1229 * image.c (my_png_error, my_error_exit):
1230 * keyboard.c (quit_throw_to_read_char, user_error)
1231 (Fexit_recursive_edit, Fabort_recursive_edit):
1232 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1233 (wrong_type_argument, buffer_overflow, __executable_start)
1234 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1235 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1236 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1237 (fatal):
1238 (child_setup) [!DOS_NT]:
1239 * lread.c (end_of_file_error, invalid_syntax):
1240 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1241 * puresize.h (pure_write_error):
1242 * search.c (matcher_overflow):
1243 * sound.c (sound_perror, alsa_sound_perror):
1244 * sysdep.c, syssignal.h (croak):
1245 * term.c (maybe_fatal, vfatal):
1246 * textprop.c (text_read_only):
1247 * undo.c (user_error):
1248 * unexmacosx.c (unexec_error):
1249 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1250 Use _Noreturn rather than NO_RETURN.
1251 No need for separate decl merely because of _Noreturn.
1252 * sound.c (sound_warning, parse_sound):
1253 Remove unnecessary forward decls.
1254
f1dd8073
PE
12552012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1256
1257 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1258 * lisp.h (WAIT_READING_MAX): New macro.
1259 * dispnew.c (Fsleep_for, sit_for):
1260 * keyboard.c (kbd_buffer_get_event):
1261 * process.c (Faccept_process_output):
1262 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1263 This improves on the previous patch, which introduced a bug
1264 when time_t is unsigned and as wide as intmax_t.
1265 See <http://bugs.gnu.org/9000#51>.
1266
b82c1755
EZ
12672012-06-23 Eli Zaretskii <eliz@gnu.org>
1268
1269 * dispnew.c (sit_for, Fsleep_for):
1270 * keyboard.c (kbd_buffer_get_event):
1271 * process.c (Faccept_process_output): Avoid compiler warnings when
1272 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1273
ca300656
JB
12742012-06-23 Juanma Barranquero <lekktu@gmail.com>
1275
049ec95b
JB
1276 * makefile.w32-in: Update dependencies.
1277
ca300656
JB
1278 * w32.c (ltime): Add return type and declare static.
1279 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1280
db7b8d06
PE
12812012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1284 Privately reported by Herbert J. Skuhra.
1285 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1286 All uses changed.
1287 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1288 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1289
0bd8297f
EZ
12902012-06-23 Eli Zaretskii <eliz@gnu.org>
1291
96512555
EZ
1292 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1293 last argument of make_unibyte_string.
1294
0bd8297f
EZ
1295 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1296 language ID in the event parameters.
1297
1298 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1299 event.code, not the obscure "character set ID".
1300
63def6b6
CY
13012012-06-23 Chong Yidong <cyd@gnu.org>
1302
1303 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1304
e8a02204
EZ
13052012-06-23 Eli Zaretskii <eliz@gnu.org>
1306
388cdec0
EZ
1307 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1308 * w32.c (fdutimens): New function.
1309
1310 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1311
1312 * s/ms-w32.h (pselect): Redirect to sys_select.
1313
1314 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1315
e8a02204
EZ
1316 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1317 in the logic of incrementing and decrementing the value of
1318 use_relocatable_buffers.
1319
d054f3fb
PE
13202012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1323 Privately reported by Herbert J. Skuhra.
1324 [__FreeBSD__]: Remove "*/" typo after "#include".
1325 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1326 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1327 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1328 Don't assume EMACS_TIME and struct timeval are the same type.
1329
d35af63c
PE
13302012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 Support higher-resolution time stamps (Bug#9000).
1333 The time stamps are only nanosecond-resolution at the C level,
1334 since that's the best that any real-world system supports now.
1335 But they are picosecond-resolution at the Lisp level, as that's
1336 easy, and leaves room for future OS improvements.
1337
1338 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1339 (LIBES): Use it.
1340
1341 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1342 Don't get current time unless it's needed.
1343
1344 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1345 now provides it if it's absent.
1346 (start_atimer): Port to higher-res time stamps.
1347 Check for time stamp overflow. Don't get current time more
1348 often than is needed.
1349
1350 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1351 Include systime.h, not time.h.
1352 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1353
1354 * dired.c: Include stat-time.h.
1355 (Ffile-attributes): File times now have higher resolution.
1356
1357 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1358 (struct image): Timestamp now has higher resolution.
1359
1360 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1361 has at least microseconds now. All uses removed.
1362 (update_frame, update_single_window, update_window, update_frame_1)
1363 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1364
1365 * editfns.c (time_overflow): Now extern.
1366 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1367 (float-time, Fformat_time_string, Fcurrent_time_string)
1368 (Fcurrent_time_zone): Accept and generate higher-resolution
1369 time stamps.
1370 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1371 (decode_time_components, lisp_seconds_argument): New functions.
1372 (make_time): Now static.
1373 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1374 Report an error if the time is invalid, rather than having the caller
1375 do that.
1376
1377 * fileio.c: Include <stat-time.h>
1378 (Fcopy_file): Copy higher-resolution time stamps.
1379 Prefer to set the time stamp via a file descriptor if that works.
1380 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1381 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1382 (Fvisited_file_modtime, Fset_visited_file_modtime):
1383 Support higher-resolution time stamps.
1384
1385 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1386
1387 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1388
1389 * image.c (prepare_image_for_display, clear_image_cache)
1390 (lookup_image): Port to higer-resolution time stamps.
1391
1392 * keyboard.c (start_polling, bind_polling_period):
1393 Check for time stamp overflow.
1394 (read_char, kbd_buffer_get_event, timer_start_idle)
1395 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1396 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1397 Port to higher-resolution time stamps. Do not assume time_t is signed.
1398 (decode_timer): New function. Timers are now vectors of length 9,
1399 not 8, to accommodate the picosecond component.
1400 (timer_check_2): Use it.
1401
1402 * nsterm.m (select_timeout, timeval_subtract): Remove.
1403 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1404 as they're a bit more accurate and handle overflow better.
1405 (ns_select): Change prototype to be compatible with pselect.
1406 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1407 * nsterm.h (ns_select): Adjust prototype.
1408
1409 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1410 us-resolution time stamps.
1411 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1412
1413 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1414
1415 * lisp.h (time_overflow): New decl.
1416 (wait_reading_process_output): First arg is now intmax_t, not int,
1417 to accommodate larger waits.
1418
1419 * process.h (struct Lisp_Process.read_output_delay):
1420 Now counts nanoseconds, not microseconds.
1421 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1422 EMACS_HAS_USECS.
1423 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1424 (wait_reading_process_output):
1425 Port to ns-resolution time stamps.
1426 (Faccept_process_output, wait_reading_process_output):
1427 Check for time stamp overflow. Do not assume time_t is signed.
1428 (select_wrapper): Remove; we now use pselect.
1429 (Fprocess_attributes): Now generates ns-resolution time stamps.
1430
1431 * sysdep.c: Include utimens.h. Don't include utime.h
1432 or worry about struct utimbuf; gnulib does that for us now.
1433 (gettimeofday): Remove; gnulib provides a substitute.
1434 (make_timeval): New function.
1435 (set_file_times): Now sets ns-resolution time stamps.
1436 New arg FD; all uses changed.
1437 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1438 (system_process_attributes):
1439 Now returns ns-resolution time stamp. All uses changed.
1440 Check for time stamp overflow.
1441
1442 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1443 provides a substitute now.
1444
1445 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1446 since it guarantees struct timespec.
1447 (EMACS_TIME): Now struct timespec, so that we can support
1448 ns-resolution time stamps.
1449 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1450 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1451 (EMACS_USECS): Remove.
1452 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1453 so multiply the arg by 1000 before storing it.
1454 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1455 New macros.
1456 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1457 Port to ns-resolution time stamps.
1458 (EMACS_TIME_NEG_P): Remove; replaced by....
1459 (EMACS_TIME_SIGN): New macro.
1460 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1461 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1462 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1463 (make_timeval, make_lisp_time, decode_time_components): New decls.
1464 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1465 that it mishandled time_t overflow. You can't compare by subtracting!
1466 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1467 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1468
1469 * term.c: Include <sys/time.h>.
1470 (timeval_to_Time): New function, for proper overflow wraparound.
1471 (term_mouse_position, term_mouse_click): Use it.
1472
1473 * undo.c (record_first_change): Support higher-resolution time stamps
1474 in the undo buffer.
1475 (Fprimitive_undo): Use them when restoring time stamps.
1476
1477 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1478 (w32_get_internal_run_time):
1479 Port to higher-resolution Emacs time stamps.
1480 (ltime): Now accepts single 64-bit integer, as that's more convenient
1481 for callers.
1482
1483 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1484
1485 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1486 for compatibility with pselect. Support ns-resolution time stamps.
1487
1488 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1489
1490 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1491 Check for time stamp overflow, and support ns-resolution time stamps.
1492
1493 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1494 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1495 (timeval_subtract): Remove; no longer needed.
1496 (XTflash, XTring_bell, x_wait_for_event):
1497 Port to ns-resolution time stamps. Don't assume time_t is signed.
1498
b6a92dfe
CY
14992012-06-22 Chong Yidong <cyd@gnu.org>
1500
1501 * xdisp.c (x_consider_frame_title): Revert last change.
1502
d251c37c
EZ
15032012-06-22 Eli Zaretskii <eliz@gnu.org>
1504
1505 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1506 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1507 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1508 staticidx goes up to 1597 out of 1600 = 0x640.)
1509
f10deafb
PE
15102012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1513 Otherwise, the umask might be mistakenly 0 while handling input signals.
1514
ec6de1e2
SM
15152012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1516
1517 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1518
28be1ada
DA
15192012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1520
1521 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1522 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1523 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1524 access to `contents' member of Lisp_Vector objects with AREF and ASET
1525 where appropriate.
1526
c6bf3022
CY
15272012-06-19 Chong Yidong <cyd@gnu.org>
1528
1529 * frame.c (delete_frame): When selecting a frame on a different
1530 text terminal, do not alter the terminal's top-frame.
1531
1532 * xdisp.c (format_mode_line_unwind_data): Record the target
1533 frame's selected window and its terminal's top-frame.
1534 (unwind_format_mode_line): Restore them.
1535 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1536 Callers changed.
1537 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1538 since tty frames can be explicitly named.
1539 (prepare_menu_bars): Likewise.
1540
1541 * term.c (Ftty_top_frame): New function.
1542
defd4196
PE
15432012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1544
1545 Port byte-code-meter to modern targets.
1546 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1547 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1548 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1549 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1550 (METER_1, METER_2): Simplify.
1551
1053a871
SM
15522012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1553
1554 * data.c (Fdefalias): Return `symbol' (bug#11686).
1555
b7e8d081
MR
15562012-06-18 Martin Rudalics <rudalics@gmx.at>
1557
1558 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1559 gets killed during executing of this function (Bug#11665).
1560 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1561 (Vkill_buffer_query_functions): In doc-string say that functions
1562 run by this hook should not change the current buffer.
1563
7ea2b339
PE
15642012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 Fix recently-introduced process.c problems found by static checking.
1567 * process.c (write_queue_push, write_queue_pop, send_process):
1568 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1569 (write_queue_pop): Fix pointer signedness problem.
1570 (send_process): Remove unused local.
1571
96a313a1
CY
15722012-06-17 Chong Yidong <cyd@gnu.org>
1573
1574 * xdisp.c (redisplay_internal): No need to redisplay terminal
1575 frames that are not on top.
1576
20ca2e94
TN
15772012-06-17 Troels Nielsen <bn.troels@gmail.com>
1578
1579 * process.c (make_process): Initialize write_queue.
1580 (write_queue_push, write_queue_pop): New functions.
1581 (send_process): Use them to maintain correct ordering of process
1582 writes (Bug#10815).
1583
9a900ca9
PE
15842012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1585
310fbfa8
PE
1586 * lisp.h (eassert): Assume C89 or later.
1587 This removes the need for CHECK.
1588 (CHECK): Remove. Its comments about always evaluating its
1589 argument were confusing, as 'eassert' typically does not evaluate
1590 its argument.
1591
27bb1ca4
PE
1592 * coding.c (produce_chars): Use ptrdiff_t, not int.
1593
9a900ca9
PE
1594 * xterm.c (x_draw_underwave): Check for integer overflow.
1595 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1596
41b7f8bc 15972012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1598
1599 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1600 referenced (Bug#11583).
1601
9b0e3eba
AA
16022012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1603
1604 Implement wave-style variant of underlining.
1605 * dispextern.h (face_underline_type): New enum.
1606 (face): Add field for underline type.
1607 * nsterm.m (ns_draw_underwave): New function.
1608 (ns_draw_text_decoration): Use it.
1609 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1610 New functions.
1611 (x_draw_glyph_string): Use them.
1612 * xfaces.c (Qline, Qwave): New Lisp objects.
1613 (check_lface_attrs, merge_face_ref)
1053a871
SM
1614 (Finternal_set_lisp_face_attribute, realize_x_face):
1615 Handle wave-style underline face attributes.
9b0e3eba
AA
1616 * xterm.c (x_draw_underwave): New function.
1617 (x_draw_glyph_string): Use it.
1618
0fb52f11
JB
16192012-06-16 Juanma Barranquero <lekktu@gmail.com>
1620
1621 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1622 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1623 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1624 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1625 ($(BLD)/w32select.$(O)): Update dependencies.
1626
e5560ff7
AS
16272012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1628
1629 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1630 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1631 * character.c (_fetch_multibyte_char_p): Remove.
1632 * alloc.c: Include "character.h" before "buffer.h".
1633 * bidi.c: Likewise.
1634 * buffer.c: Likewise.
1635 * bytecode.c: Likewise.
1636 * callint.c: Likewise.
1637 * callproc.c: Likewise.
1638 * casefiddle.c: Likewise.
1639 * casetab.c: Likewise.
1640 * category.c: Likewise.
1641 * cmds.c: Likewise.
1642 * coding.c: Likewise.
1643 * composite.c: Likewise.
1644 * dired.c: Likewise.
1645 * dispnew.c: Likewise.
1646 * doc.c: Likewise.
1647 * dosfns.c: Likewise.
1648 * editfns.c: Likewise.
1649 * emacs.c: Likewise.
1650 * fileio.c: Likewise.
1651 * filelock.c: Likewise.
1652 * font.c: Likewise.
1653 * fontset.c: Likewise.
1654 * fringe.c: Likewise.
1655 * indent.c: Likewise.
1656 * insdel.c: Likewise.
1657 * intervals.c: Likewise.
1658 * keyboard.c: Likewise.
1659 * keymap.c: Likewise.
1660 * lread.c: Likewise.
1661 * macros.c: Likewise.
1662 * marker.c: Likewise.
1663 * minibuf.c: Likewise.
1664 * nsfns.m: Likewise.
1665 * nsmenu.m: Likewise.
1666 * print.c: Likewise.
1667 * process.c: Likewise.
1668 * regex.c: Likewise.
1669 * region-cache.c: Likewise.
1670 * search.c: Likewise.
1671 * syntax.c: Likewise.
1672 * term.c: Likewise.
1673 * textprop.c: Likewise.
1674 * undo.c: Likewise.
1675 * unexsol.c: Likewise.
1676 * w16select.c: Likewise.
1677 * w32fns.c: Likewise.
1678 * w32menu.c: Likewise.
1679 * window.c: Likewise.
1680 * xdisp.c: Likewise.
1681 * xfns.c: Likewise.
1682 * xmenu.c: Likewise.
1683 * xml.c: Likewise.
1684 * xselect.c: Likewise.
1685
2f07e6af
EZ
16862012-06-16 Eli Zaretskii <eliz@gnu.org>
1687
1053a871
SM
1688 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1689 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1690 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1691 row.
1692 (handle_face_prop): Use chunk-relative overlay string index when
1693 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1694 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1695 the rightmost. (Bug#11720)
2f07e6af 1696
29b83cec
AS
16972012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1698
1699 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1700 (CATEGORY_MEMBER): Enforce 1/0 value.
1701 * category.c (_temp_category_set): Remove.
1702
4c5501e9
EZ
17032012-06-16 Eli Zaretskii <eliz@gnu.org>
1704
1705 * window.c (Fdelete_other_windows_internal)
1706 (Fdelete_window_internal): Don't access frame's mouse highlight
1707 info of the initial frame. (Bug#11677)
1708
2b570124
PE
17092012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1710
e93864f9
PE
1711 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1712 Assume USE_2_TAGS_FOR_INTS.
1713 (xreload): Adjust $tagmask width to match recent lisp.h change.
1714
2b570124
PE
1715 Simplify lisp.h in minor ways that should not affect code.
1716 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1717 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1718 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1719 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1720 (INTTYPEBITS): New macro, for clarity.
1721 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1722 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1723 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1724 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1725 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1726
81755f69
JB
17272012-06-13 Juanma Barranquero <lekktu@gmail.com>
1728
1729 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1730
16192a57
GM
17312012-06-13 Glenn Morris <rgm@gnu.org>
1732
1733 * s/bsd-common.h (BSD4_3):
1734 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1735
646b5f55
AS
17362012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1737
1738 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1739 instead of union.
1740 (XLI, XIL): Define.
1053a871
SM
1741 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1742 Use them.
1743 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1744 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1745 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1746 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1747 * frame.c (delete_frame): Remove outdated comment.
1748 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1749 USE_LISP_UNION_TYPE.
1750 (Fw32_unregister_hot_key): Likewise.
1751 (Fw32_toggle_lock_key): Likewise.
1752 * w32menu.c (add_menu_item): Likewise.
1753 (w32_menu_display_help): Use XIL instead of checking
1754 USE_LISP_UNION_TYPE.
1755 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1756 (init_heap): Likewise.
1757 * w32term.c (w32_read_socket): Update comment.
1758
1d3823c9
GM
17592012-06-13 Glenn Morris <rgm@gnu.org>
1760
c62ff706
GM
1761 * s/usg5-4-common.h, src/s/unixware.h:
1762 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1763
1d3823c9
GM
1764 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1765
bfe3e0a2
PE
17662012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1769 * alloc.c (make_number) [!defined make_number]:
1770 Remove, as lisp.h always defines this now.
1771 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1772 (roundup_size): Verify that it is a power of 2.
1773 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1774 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1775 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1776 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1777 USE_LSB_TAG now is always defined to be either 0 or 1.
1778 All uses changed.
1779 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1780 code works fine either way, and efficiency is not a concern here,
1781 as the union type is for debugging, not for production.
1782 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1783 Use an inline function on all platforms when using the union type,
1784 since this is simpler and 'static inline' can be used portably
1785 within Emacs now.
1786 (LISP_INITIALLY_ZERO): New macro.
1787 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1788 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1789
45fa9c0f
GM
17902012-06-12 Glenn Morris <rgm@gnu.org>
1791
b4492cba
GM
1792 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1793
1794 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1795
45fa9c0f
GM
1796 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1797 Move BROKEN_SIGIO to configure.
1798
1799 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1800 Move NO_TERMIO to configure.
1801
0e25d334
CY
18022012-06-12 Chong Yidong <cyd@gnu.org>
1803
1804 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1805 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1806 MagickExportImagePixels is undefined.
1807
43682bb6
PE
18082012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 * image.c (imagemagick_load_image): Remove unused label.
1811
a9be7d2b
GM
18122012-06-11 Glenn Morris <rgm@gnu.org>
1813
1814 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1815 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1816 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1817 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1818
3017f87f
SM
18192012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 * alloc.c (make_byte_code): New function.
1822 (Fmake_byte_code): Use it. Don't purify here.
1823 * lread.c (read1): Use it as well to avoid extra allocation.
1824
1b9b4cf4
CY
18252012-06-11 Chong Yidong <cyd@gnu.org>
1826
1827 * image.c (imagemagick_load_image): Implement transparency.
1828
95988fcf
AS
18292012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1830
1831 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1832 account for preceding backslashes. (Bug#11663)
1833
cd4eb164
CY
18342012-06-09 Chong Yidong <cyd@gnu.org>
1835
1836 * term.c: Support italics in capable terminals (Bug#9652).
1837 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1838 (turn_on_face): Output using TS_enter_italic_mode if available.
1839 Don't handle unused blinking and alt-charset cases.
1840 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1841 and tty_alt_charset_p cases.
1842 (tty_capable_p, init_tty): Support italics.
1843
1844 * termchar.h (struct tty_display_info): Add field for italics.
1845 Remove unused blink field.
1846
1847 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1848 Handle slant.
1849
1850 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1851 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1852 tty_alt_charset_p. Add tty_italic_p.
1853
ff88beb8
MA
18542012-06-09 Michael Albinus <michael.albinus@gmx.de>
1855
1856 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1857 dbus_type_is_basic if available.
1858 (xd_extract_signed, xd_extract_unsigned): Rename from
1859 extract_signed and extract_unsigned, respectively. Adapt callers.
1860
44286096
CY
18612012-06-09 Chong Yidong <cyd@gnu.org>
1862
1682701f
CY
1863 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1864
44286096
CY
1865 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1866 case (Bug#9752).
1867
d86feb17
PE
18682012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * xdisp.c (vmessage): Treat frame message as multibyte.
1871 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1872 would generate the diagnostic "Making \302\247 buffer-local while
1873 let-bound!".
1874
d5c20fe8
EZ
18752012-06-08 Eli Zaretskii <eliz@gnu.org>
1876
1877 * dispnew.c (showing_window_margins_p): Undo last change, which
1878 was done due to an inadvertent commit.
1879 (adjust_frame_glyphs_for_frame_redisplay): Do call
1880 showing_window_margins_p.
1881
513749ee
SM
18822012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * eval.c (Fmake_var_non_special): New primitive.
1885 (syms_of_eval): Defsubr it.
1886 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1887
d4a8f5c1
JB
18882012-06-08 Juanma Barranquero <lekktu@gmail.com>
1889
1890 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1891 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1892
8bbbc977
EZ
18932012-06-08 Eli Zaretskii <eliz@gnu.org>
1894
1895 * alloc.c (allocate_vectorlike): Fix last change.
1896
f3372c87
DA
18972012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1898
1899 Block-based vector allocation of small vectors.
1900 * lisp.h (struct vectorlike_header): New field `nbytes',
1901 adjust comment accordingly.
1902 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1903 to denote vector blocks. Adjust users (live_vector_p,
1904 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1905 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1906 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1907 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1908 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1909 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1910 (roundup_size): New constant.
1911 (struct vector_block): New data type.
1912 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1913 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1914 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1915 (sweep_vectors): New functions.
1916 (allocate_vectorlike): Return `zero_vector' as the only vector of
1917 0 items. Allocate new vector from block if vector size is less than
1918 or equal to VBLOCK_BYTES_MAX.
1919 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1920 (init_alloc_once): Add call to init_vectors.
1921
4f18a4ed
SM
19222012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1923
1924 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1925
86f158bc
PE
19262012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * doprnt.c (doprnt): Truncate multibyte char correctly.
1929 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1930 would mishandle a string argument "Xc" if X was a multibyte
1931 character of length 2: it would truncate after X's first byte
1932 rather than including all of X.
1933
c5cfcbe0
CY
19342012-06-06 Chong Yidong <cyd@gnu.org>
1935
1936 * buffer.c (word_wrap): Doc fix.
1937
c05cf390
PE
19382012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1939
1940 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1941
0c3461de
GM
19422012-06-03 Glenn Morris <rgm@gnu.org>
1943
1944 * xdisp.c (tool-bar-style): Doc fix.
1945
c71232db
UM
19462012-06-03 Ulrich Müller <ulm@gentoo.org>
1947
1948 * Makefile.in (PAXCTL): Define.
1949 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1950 binary via PaX flags if the paxctl utility is available.
1951 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1952 Restore PaX flags to their default. (Bug#11398)
1953
383f7350
CY
19542012-06-03 Chong Yidong <cyd@gnu.org>
1955
1956 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1957 buffer (Bug#11226).
1958
5f2c76c6
CY
19592012-06-03 Chong Yidong <cyd@gnu.org>
1960
1961 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1962 (note_mode_line_or_margin_highlight): If there is no help echo,
1963 use mode-line-default-help-echo. Handle the case where the mouse
1964 position is past the end of the mode line string.
1965
1966 * buffer.c (buffer_local_value_1): New function, split from
1967 Fbuffer_local_value; can return Qunbound.
1968 (Fbuffer_local_value): Use it.
1969 (Vmode_line_format): Docstring tweaks.
1970
773d47f6
PE
19712012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * sysdep.c (system_process_attributes): Improve comment.
1974
f2d6a3df
SM
19752012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1976
1977 * keyboard.c: Export real-this-command to Elisp.
1978 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1979 and DEFVAR it. Update all users.
1980
63810350
PE
19812012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1982
7bd5c1f4
PE
1983 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1984
63810350
PE
1985 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1986 Convert pctcpu and pctmem to Lisp float properly.
1987 Let the compiler fold better, as 100.0/0x8000 is exact.
1988
a2821611
AS
19892012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1990
1991 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1992 cons_block.
1993
5fceba1d
PE
19942012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1995
1996 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1997
c98ff5dd
DA
19982012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1999
2000 For a 'struct window', replace some Lisp_Object fields to
2001 bitfields where appropriate, remove unused fields.
2002 * window.h (struct window): Remove unused 'last_mark_x' and
2003 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2004 change it's type from Lisp_Object to bitfield.
2005 Change type of 'force_start', 'optional_new_start',
2006 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2007 fields from Lisp_Object to bitfield. Adjust users accordingly.
2008
ca34e0be
PE
20092012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 Pacify gcc -Wdouble-precision when using Xaw.
2012 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2013 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2014 Use 'float' consistently, rather than 'float' in most places
2015 and 'double' in a couple of places.
2016
efc00ab1 20172012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2018
2019 * xdisp.c (handle_stop): Detect whether we have overlay strings
2020 loaded by testing it->current.overlay_string_index to be
2021 non-negative, instead of checking whether n_overlay_strings is
2022 positive. (Bug#11587)
2023
efc00ab1 20242012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2025
2026 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2027
2028 * doc.c (Fsubstitute_command_keys): Doc fix.
2029
efc00ab1 20302012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2031
2032 * search.c (search_buffer): Remove calls to
2033 r_alloc_inhibit_buffer_relocation, as it is now called by
2034 maybe_unify_char, which was the cause of relocation of buffer text
2035 in bug#11519.
2036
efc00ab1 20372012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2038
2039 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2040 for the duration of call to load_charset, to avoid problems with
2041 callers of maybe_unify_char that access buffer text through C
2042 pointers.
2043
2044 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2045 decrement the inhibition flag, instead of just setting or
2046 resetting it.
2047
ba93a187
PE
20482012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 Remove obsolete '#define static' cruft.
2051 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2052 This #undef was "temporary" in 2000; it is no longer needed
2053 now that '#define static' has gone away.
2054 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2055 (gray_bitmap_bits): Remove; no longer needed.
2056 All uses replaced with definiens.
2057 * xterm.c: Include "bitmaps/gray.xbm".
2058
9e4bf381
PE
20592012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 Clean up __executable_start, monstartup when --enable-profiling.
2062 The following changes affect the code only when profiling.
2063 * dispnew.c (__executable_start): Rename from safe_bcopy.
2064 Define only on platforms that need it.
2065 * emacs.c: Include <sys/gmon.h> when profiling.
2066 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2067 (__executable_start): Remove decl, since lisp.h does it now.
2068 (safe_bcopy): Remove decl; no longer has that name.
2069 (main): Coalesce #if into single bit of code, for simplicity.
2070 Cast pointers to uintptr_t, since standard libraries want integers
2071 and not pointers.
2072 * lisp.h (__executable_start): New decl.
2073
32d72c2f
GM
20742012-05-31 Glenn Morris <rgm@gnu.org>
2075
2076 * image.c (Fimagemagick_types): Doc fix.
2077
baac5bc7
JM
20782012-05-30 Jim Meyering <meyering@redhat.com>
2079
2080 * callproc.c (Fcall_process_region): Include directory component
2081 in mkstemp error message (Bug#11586).
2082
72cb32cf
PE
20832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 * alloc.c, lisp.h (make_pure_vector): Now static.
2086
61b108cc
SM
20872012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2088
2089 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2090 Move to byte-run.el.
2091 (Fautoload): Do the hash-doc more carefully.
2092 * data.c (Fdefalias): Purify definition, except for keymaps.
2093 (Qdefun): Move from eval.c.
2094 * lisp.h (Qdefun): Remove.
2095 * lread.c (read1): Tiny simplification.
2096
471fe23d
TN
20972012-05-29 Troels Nielsen <bn.troels@gmail.com>
2098
934f3f58 2099 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2100 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2101 Bug#9642, but explicitly check that the buffer the overlay would
2102 be moved to is live and rearrange lines to make sure that errors
2103 will not put the overlay in an inconsistent state.
2104 (Fdelete_overlay): Cosmetics.
2105
85d0efd1
EZ
21062012-05-28 Eli Zaretskii <eliz@gnu.org>
2107
2108 * w32term.c (my_bring_window_to_top): New function.
2109 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2110 could be different from the original one.
2111 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2112 (Bug#11513)
2113
2114 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2115 by calling BringWindowToTop.
2116
2117 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2118 (WM_EMACS_END): Increase by one.
2119
da92a98c
PE
21202012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2123 This avoids undefined behavior that might cause the eassert
2124 to not catch an out-of-range value.
2125
74d1f848
JB
21262012-05-28 Juanma Barranquero <lekktu@gmail.com>
2127
2128 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2129 Update dependencies.
2130
9e1a06fc
EZ
21312012-05-27 Eli Zaretskii <eliz@gnu.org>
2132
2133 * bidi.c (bidi_mirror_char): Fix last change.
2134
f3dd7312
AS
21352012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2136
2137 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2138 when referring to sectname field in printf format.
2139
81899c91
PE
21402012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2141
57b81a9f
PE
2142 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2143 Only r_alloc_inhibit_buffer_relocation needed to be added;
2144 the others were already declared.
2145
81899c91
PE
2146 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2147 before checking whether it's out of range. Put the check inside
2148 eassert. See
2149 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2150
33017faf 21512012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2152
2153 * callproc.c (Fcall_process): Restore a line that was accidentally
2154 commented out in the 2011-02-13 change (bug#11547).
2155
33017faf 21562012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2157
2158 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2159 defined on ralloc.c.
2160
2161 * buffer.c [REL_ALLOC]: Remove prototypes of
2162 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2163 they are now on lisp.h.
2164
2165 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2166
2167 * search.c (search_buffer): Use it to inhibit relocation of buffer
2168 text while re_search_2 is doing its job, because re_search_2 is
2169 passed C pointers to buffer text. (Bug#11519)
2170
23415acf
EZ
2171 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2172 Update value to 24.
2173
44e27368
EZ
2174 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2175 state after an additional call to move_it_in_display_line_to, keep
2176 the values of it->max_ascent and it->max_descent found for the
2177 entire line.
2178 (pos_visible_p): Revert the comparison against bottom_y to what it
2179 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2180 (Bug#11464)
2181
c1892f11
PE
21822012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2183
2184 Fix coding-related core dumps with gcc -ftrapv.
2185 The code was computing A - B, where A and B are pointers, and B is
2186 random garbage. This can lead to core dumps on platforms that
2187 have special pointer registers, and it also leads to core dumps on
2188 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2189 A - B only when B is initialized properly.
2190 * coding.c (coding_set_source, coding_set_destination): Return void.
2191 (coding_change_source, coding_change_destinations): New functions,
2192 with the old behaviors of coding_set_source and coding_set_destination.
2193 All callers that need an offset changed to use these new functions.
2194
eb7afdad
GM
21952012-05-26 Glenn Morris <rgm@gnu.org>
2196
2197 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2198
f12fdf02
EZ
21992012-05-26 Eli Zaretskii <eliz@gnu.org>
2200
53a63be6 2201 Extend mouse support on W32 text-mode console.
61b108cc
SM
2202 * xdisp.c (draw_row_with_mouse_face):
2203 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2204
eb3f6f01 2205 * w32console.c: Include window.h.
61b108cc
SM
2206 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2207 New functions.
eb3f6f01
EZ
2208 (initialize_w32_display): Initialize mouse-highlight data.
2209
53a63be6
EZ
2210 * w32inevt.c: Include termchar.h and window.h.
2211 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2212 moves, call note_mouse_highlight. If help_echo changed, call
2213 gen_help_event to produce help-echo message in the echo area.
2214 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2215 highlight info.
2216
4cfd81f6
PE
22172012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2218
2219 * lread.c (read1): Simplify slightly to avoid an overflow warning
2220 with GCC 4.7.0 on x86-64.
2221
4446092a
EZ
22222012-05-26 Eli Zaretskii <eliz@gnu.org>
2223
2224 * bidi.c (bidi_mirror_char): Revert last change: an int is
2225 definitely wide enough here.
2226
42b2a986 22272012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2228
42b2a986 2229 Fix integer width and related bugs (Bug#9874).
eb106a49 2230 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2231 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2232 (string_bytes, check_sblock, allocate_string_data):
2233 (compact_small_strings, Fmake_bool_vector, make_string)
2234 (make_unibyte_string, make_multibyte_string)
2235 (make_string_from_bytes, make_specified_string)
2236 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2237 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2238 (mark_vectorlike):
2239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2240 (allocate_pseudovector):
2241 Use int, not EMACS_INT, where int is wide enough.
2242 (inhibit_garbage_collection, Fgarbage_collect):
2243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2244 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2245 int might not be wide enough.
2246 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2247 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2248 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2249 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2250 (bidi_level_of_next_char, bidi_move_to_visually_next):
2251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2252 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2253 (Fkill_buffer, Fset_buffer_major_mode)
2254 (advance_to_char_boundary, Fbuffer_swap_text)
2255 (Fset_buffer_multibyte, overlays_at, overlays_in)
2256 (overlay_touches_p, struct sortvec, record_overlay_string)
2257 (overlay_strings, recenter_overlay_lists)
2258 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2259 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2260 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2261 (Foverlay_recenter, last_overlay_modification_hooks_used)
2262 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2264 (validate_region): Omit unnecessary test for b <= e,
2265 since that's guaranteed by the previous test.
d311d28c
PE
2266 (adjust_overlays_for_delete): Avoid pos + length overflow.
2267 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2268 (report_overlay_modification):
2269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2270 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2271 Omit pointer cast, which isn't needed anyway, and doesn't work
2272 after the EMACS_INT -> ptrdiff_t change.
02481186 2273 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2274 * buffer.h: Adjust decls to match defn changes elsewhere.
2275 (struct buffer_text, struct buffer):
2276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2277 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2278 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2279 not int, to avoid needless 32-bit limit on 64-bit hosts.
2280 (exec_byte_code): Use tighter memory-full test, one that checks
2281 for alloca overflow. Don't compute the address of the object just
2282 before an array, as that's not portable. Use EMACS_INT, not
2283 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2284 * callint.c (Fcall_interactively):
2285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2286 * callproc.c (call_process_kill, Fcall_process):
2287 Don't assume pid_t fits into an Emacs fixnum.
2288 (call_process_cleanup, Fcall_process, child_setup):
2289 Don't assume pid_t fits into int.
2290 (call_process_cleanup, Fcall_process, delete_temp_file)
2291 (Fcall_process_region):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 (Fcall_process): Simplify handling of volatile integers.
2294 Use int, not EMACS_INT, where int will do.
2295 * casefiddle.c (casify_object, casify_region, operate_on_word)
2296 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2298 (casify_object): Avoid integer overflow when overallocating buffer.
2299 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2300 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2301 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2302 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2303 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2304 integers are now checked earlier. All uses replaced with XINT.
2305 (ccl_driver):
2306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2307 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2308 (ccl_driver, Fregister_code_conversion_map):
2309 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2310 (resolve_symbol_ccl_program): Check that vector header is in range.
2311 Always copy the vector, so that we can check its contents reliably
2312 now rather than having to recheck each instruction as it's being
2313 executed. Check that vector words fit in 'int'.
2314 (ccl_get_compiled_code, Fregister_ccl_program)
2315 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2316 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2317 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2318 contents are in range.
2319 (Fccl_execute_on_string): Check that status is in range.
2320 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2321 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2322 Accept and return EMACS_INT, not int, because callers can pass values
2323 out of 'int' range.
2324 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2325 (multibyte_chars_in_text, parse_str_as_multibyte)
2326 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2327 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2328 (string_escape_byte8, Fget_byte):
2329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2330 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2331 avoid mishandling large integers.
2332 * character.h: Adjust decls to match defn changes elsewhere.
2333 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2334 (Ffind_charset_region):
2335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2336 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2337 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2338 Don't assume fixnum fits in int.
d311d28c
PE
2339 (load_charset_map_from_vector, Fmap_charset_chars):
2340 Remove now-unnecessary CHECK_NATNUMs.
2341 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2342 Don't rely on undefined behavior with signed left shift overflow.
2343 Don't assume unsigned int fits into fixnum, or that fixnum fits
2344 into unsigned int. Don't require max_code to be a valid fixnum;
2345 that's not true for gb10830 4-byte on a 32-bit host. Allow
2346 invalid_code to be a cons, for the same reason. Require code_offset
2347 to be a character. Avoid int overflow if max_char is close
2348 to INT_MAX.
2349 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2350 this is intended anyway and avoids some undefined behavior.
2351 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2352 INDEX_TO_CODE_POINT, as that's what it expects.
2353 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2354 * charset.h (DECODE_CHAR): Return int, not unsigned;
2355 this is what was intended anyway, and it avoids undefined behavior.
2356 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2357 integer-overflow issues.
2358 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2359 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2360 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2361 * chartab.c (Fmake_char_table, Fset_char_table_range)
2362 (uniprop_get_decoder, uniprop_get_encoder):
2363 Don't assume fixnum fits in int.
2364 * cmds.c (move_point): New function, that does the gist of
2365 Fforward_char and Fbackward_char, but does so while checking
2366 for integer overflow more accurately.
c96e5d6a 2367 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2368 (Fforward_line, Fend_of_line, internal_self_insert)
2369 (internal_self_insert):
2370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2371 Fix a FIXME, by checking for integer overflow when calculating
2372 target_clm and actual_clm.
2373 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2374 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2375 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2376 (coding_alloc_by_making_gap, alloc_destination)
2377 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2378 (encode_coding_utf_16, detect_coding_emacs_mule)
2379 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2380 (detect_coding_iso_2022, decode_coding_iso_2022)
2381 (encode_invocation_designation, encode_designation_at_bol)
2382 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2383 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2384 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2385 (encode_coding_ccl, encode_coding_raw_text)
2386 (detect_coding_charset, decode_coding_charset)
2387 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2388 (produce_composition, produce_charset, produce_annotation)
2389 (decode_coding, handle_composition_annotation)
2390 (handle_charset_annotation, consume_chars, decode_coding_gap)
2391 (decode_coding_object, encode_coding_object, detect_coding_system)
2392 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2393 (code_convert_region, code_convert_string)
8f50130c
PE
2394 (Fdefine_coding_system_internal)
2395 (coding_set_source, coding_set_destination):
d311d28c
PE
2396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2397 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2398 (Fdefine_coding_system_internal):
2399 Don't assume fixnums fit in int.
2400 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2401 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2402 (Funencodable_char_position, Fcheck_coding_systems_region)
2403 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2405 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2406 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2407 Don't access memory outside of the args array.
d311d28c 2408 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2409 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2410 result of ENCODE_CHAR.
d311d28c
PE
2411 * coding.h: Adjust decls to match defn changes elsewhere.
2412 (struct coding_system):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2414 * composite.c (get_composition_id, find_composition)
2415 (run_composition_function, update_compositions)
2416 (compose_text, composition_gstring_put_cache)
2417 (composition_gstring_p, composition_gstring_width)
2418 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2419 (composition_compute_stop_pos, composition_reseat_it)
2420 (composition_update_it, struct position_record)
2421 (find_automatic_composition, composition_adjust_point)
2422 (Fcomposition_get_gstring, Ffind_composition_internal):
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 (update_compositions):
2425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2426 * composite.h: Adjust decls to match defn changes elsewhere.
2427 (struct composition):
2428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2429 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2430 Do not attempt to compute the address of the object just before a
2431 buffer; this is not portable.
2432 (Faref, Faset):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 (Faset): Use int, not EMACS_INT, where int is wide enough.
2435 (Fstring_to_number): Don't assume fixnums fit in int.
2436 (Frem): Don't assume arg is nonnegative.
2437 * dbusbind.c (xd_append_arg): Check for integers out of range.
2438 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2439 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2440 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2441 (xd_get_connection_references): Return ptrdiff_t, not int.
2442 All uses changed.
2443 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2444 (xd_read_message_1):
2445 Use int, not unsigned, where the dbus API uses int.
2446 (Fdbus_message_internal): Don't overflow mtype.
2447 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2448 * dired.c (directory_files_internal, file_name_completion, scmp)
2449 (file_name_completion_stat):
2450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2451 (file_name_completion): Don't overflow matchcount.
2452 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2453 * dispextern.h: Adjust decls to match defn changes elsewhere.
2454 (struct text_pos, struct glyph, struct bidi_saved_info)
2455 (struct bidi_string_data, struct bidi_it, struct composition_it)
2456 (struct it):
2457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2458 (struct display_pos, struct composition_it, struct it):
2459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2460 * dispnew.c (increment_matrix_positions)
2461 (increment_row_positions, mode_line_string)
2462 (marginal_area_string):
2463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2464 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2466 (duration_to_sec_usec): New function, to check for overflow better.
2467 (Fsleep_for, sit_for): Use it.
2468 * doc.c (get_doc_string, store_function_docstring):
2469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2470 (get_doc_string, Fsnarf_documentation):
2471 Use int, not EMACS_INT, where int is wide enough.
2472 (get_doc_string):
2473 Use SAFE_ALLOCA, not alloca.
2474 Check for overflow when converting EMACS_INT to off_t.
2475 * doprnt.c (doprnt):
2476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2477 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2478 Don't assume uid_t fits into fixnum.
2479 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2480 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2481 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2482 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2483 (general_insert_function)
2484 (Finsert_char, make_buffer_string, make_buffer_string_both)
2485 (update_buffer_properties, Fbuffer_substring)
2486 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2487 (Fsubst_char_in_region, check_translation)
2488 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2489 (transpose_markers, Ftranspose_regions):
2490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2491 (clip_to_bounds): Move to lisp.h as an inline function).
2492 (Fconstrain_to_field): Don't assume integers are nonnegative.
2493 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2494 (Fsubst_char_in_region, Fsave_restriction):
2495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2496 (Femacs_pid): Don't assume pid_t fits into fixnum.
2497 (lo_time): Use int, not EMACS_INT, when int suffices.
2498 (lisp_time_argument): Check for usec out of range.
2499 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2500 (Fuser_login_name, Fuser_full_name): Signal an error
2501 if a uid argument is out of range, rather than relying on
2502 undefined behavior.
c8d5c857
PE
2503 (Fformat_time_string): Remove now-unnecessary check.
2504 lisp_time_argument checks for out-of-range usec now.
243e0530 2505 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2506 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2507 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2508 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2509 (init_cmdargs, Fdump_emacs):
2510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2511 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2512 the bottom (typically) 32 bits of the fixnum.
2513 * eval.c (specpdl_size, call_debugger):
2514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2515 (when_entered_debugger, Fbacktrace_debug):
2516 Don't assume fixnum can fit in int.
2517 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2518 the object just before a buffer; this is not portable.
2519 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2520 (grow_specpdl, unbind_to):
2521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2522 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2523 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2524 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2525 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2526 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2528 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2529 (a_write, e_write):
2530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2531 (Fcopy_file, non_regular_nbytes, read_non_regular)
2532 (Finsert_file_contents):
2533 Use int, not EMACS_INT, where int is wide enough.
2534 (READ_BUF_SIZE): Verify that it fits in int.
2535 (Finsert_file_contents): Check that counts are in proper range,
2536 rather than assuming fixnums fit into ptrdiff_t etc.
2537 Don't assume fixnums fit into int.
125b3835 2538 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2539 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2540 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2541 (string_char_to_byte, string_byte_to_char)
2542 (string_make_multibyte, string_to_multibyte)
2543 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2544 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2545 (substring_both, Fdelete, internal_equal, Ffillarray)
2546 (Fclear_string, mapcar1)
2547 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2548 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2549 (larger_vector, make_hash_table, maybe_resize_hash_table)
2550 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2551 (Fmaphash, secure_hash):
2552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2553 (concat): Check for string index and length overflow.
2554 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2555 (Frequire):
2556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2557 (larger_vector): New API (vec, incr_min, size_max) replaces old
2558 one (vec, new_size, init). This catches size overflow.
2559 INIT was removed because it was always Qnil.
2560 All callers changed.
2561 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2562 the upper bound on a hash table index size.
2563 (make_hash_table, maybe_resize_hash_table): Use it.
2564 (secure_hash): Computer start_byte and end_byte only after
2565 they're known to be in ptrdiff_t range.
2566 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2567 (Ffont_get_glyphs, Ffont_at):
2568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2569 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2570 (Flist_fonts, Fopen_font):
2571 Don't assume fixnum can fit in int.
2572 (check_gstring): Don't assume index can fit in int.
2573 (font_match_p): Check that fixnum is a character, not a nonnegative
2574 fixnum, since the later code needs to stuff it into an int.
2575 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2576 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2577 conversion overflow issues.
2578 (Fopen_font): Check for integer out of range.
2579 (Ffont_get_glyphs): Don't assume index can fit in int.
2580 * font.h: Adjust decls to match defn changes elsewhere.
2581 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2582 integer overflow.
2583 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2584 printmax_t, where ptrdiff_t is wide enough.
2585 (Finternal_char_font):
2586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2587 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2588 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2589 (Fset_frame_position, x_set_frame_parameters)
2590 (x_set_line_spacing, x_set_border_width)
2591 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2592 Check that fixnums are in proper range for system types.
2593 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2595 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2596 Use SAFE_ALLOCA_LISP, not alloca.
2597 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2598 intptr_t is wide enough.
2599 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2600 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2601 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2602 Check for fixnum out of range.
2603 * ftfont.c (ftfont_list): Don't assume index fits in int.
2604 Check that fixnums are in proper range for system types.
2605 (ftfont_shape_by_flt):
2606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2609 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2610 Check that fixnums are in proper range for system types.
2611 * gnutls.h: Adjust decls to match defn changes elsewhere.
2612 * gtkutil.c (xg_dialog_run):
2613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2614 (update_frame_tool_bar):
2615 Check that fixnums are in proper range for system types.
2616 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2617 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2618 * indent.c (last_known_column, last_known_column_point):
2619 (current_column_bol_cache):
2620 (skip_invisible, current_column, check_display_width):
2621 (check_display_width, scan_for_column, current_column_1)
2622 (Findent_to, Fcurrent_indentation, position_indentation)
2623 (indented_beyond_p, Fmove_to_column, compute_motion):
2624 (Fcompute_motion, Fvertical_motion):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (last_known_column_modified): Use EMACS_INT, not int.
2627 (check_display_width):
2628 (Fcompute_motion):
2629 Check that fixnums and floats are in proper range for system types.
2630 (compute_motion): Don't assume index or fixnum fits in int.
2631 (compute_motion, Fcompute_motion):
2632 Use int, not EMACS_INT, when it is wide enough.
2633 (vmotion): Omit local var start_hpos that is always 0; that way
2634 we don't need to worry about overflow in expressions involving it.
2635 * indent.h: Adjust decls to match defn changes elsewhere.
2636 (struct position):
2637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2638 Use int, not EMACS_INT, where int is wide enough.
2639 Remove unused members ovstring_chars_done and tab_offset;
2640 all uses removed.
2641 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2642 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2643 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2644 (make_gap, copy_text, insert, insert_and_inherit)
2645 (insert_before_markers, insert_before_markers_and_inherit)
2646 (insert_1, count_combining_before, count_combining_after)
2647 (insert_1_both, insert_from_string)
2648 (insert_from_string_before_markers, insert_from_string_1)
2649 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2650 (adjust_after_replace, adjust_after_insert, replace_range)
2651 (replace_range_2, del_range, del_range_1, del_range_byte)
2652 (del_range_both, del_range_2, modify_region)
2653 (prepare_to_modify_buffer, signal_before_change)
2654 (signal_after_change, Fcombine_after_change_execute):
2655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2656 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2657 (balance_an_interval, split_interval_right, split_interval_left)
2658 (find_interval, next_interval, update_interval)
2659 (adjust_intervals_for_insertion, delete_node, delete_interval)
2660 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2661 (static_offset_intervals, offset_intervals)
2662 (merge_interval_right, merge_interval_left, make_new_interval)
2663 (graft_intervals_into_buffer, temp_set_point_both)
2664 (temp_set_point, set_point, adjust_for_invis_intang)
2665 (set_point_both, move_if_not_intangible, get_property_and_range)
2666 (get_local_map, copy_intervals, copy_intervals_to_string)
2667 (compare_string_intervals, set_intervals_multibyte_1):
2668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2669 * intervals.h: Adjust decls to match defn changes elsewhere.
2670 (struct interval):
2671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2672 * keyboard.c (this_command_key_count, this_single_command_key_start)
2673 (before_command_key_count, before_command_echo_length, echo_now)
2674 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2675 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2676 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2677 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2679 (last_non_minibuf_size, last_point_position, echo_truncate)
2680 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2681 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2682 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2683 (stuff_buffered_input):
2684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2685 (last_auto_save, command_loop_1, read_char):
2686 Use EMACS_INT, not int, to avoid integer overflow.
2687 (record_char): Avoid overflow in total_keys computation.
2688 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2689 * keyboard.h: Adjust decls to match defn changes elsewhere.
2690 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2691 (Fkey_description, Fdescribe_vector, Flookup_key):
2692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2693 (click_position): New function, to check that positions are in range.
2694 (Fcurrent_active_maps):
2695 (describe_command):
2696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2697 (Faccessible_keymaps, Fkey_description):
2698 (preferred_sequence_p):
2699 Don't assume fixnum can fit into int.
2700 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2701 Check for integer overflow in size calculations.
2702 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2703 avoid mishandling large integers.
2704 * lisp.h: Adjust decls to match defn changes elsewhere.
2705 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2706 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2707 (struct Lisp_Marker):
2708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2709 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2710 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2711 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2712 All callers changed.
2713 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2714 Assume the arg has valid form, since it always does.
2715 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2716 unsigned integer system type.
2717 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2718 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2720 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2721 (duration_to_sec_usec): New decl.
2722 * lread.c (read_from_string_index, read_from_string_index_byte)
2723 (read_from_string_limit, readchar, unreadchar, openp)
2724 (read_internal_start, read1, oblookup):
2725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2726 (Fload, readevalloop, Feval_buffer, Feval_region):
2727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2728 (openp): Check for out-of-range argument to 'access'.
2729 (read1): Use int, not EMACS_INT, where int is wide enough.
2730 Don't assume fixnum fits into int.
6efdadfd 2731 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2732 (read_filtered_event): Use duration_to_sec_usec
2733 to do proper overflow checking on durations.
d311d28c
PE
2734 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2735 in size calculation.
2736 (Fexecute_kbd_macro):
2737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2738 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2739 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2740 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2741 (set_marker_both, set_marker_restricted_both, marker_position)
2742 (marker_byte_position, Fbuffer_has_markers_at):
2743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2744 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2745 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2746 It now merely ensures that the menu is large enough, without
2747 necessarily growing it, as this avoids some integer overflow issues.
2748 All callers changed.
2749 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2751 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2752 Use SAFE_ALLOCA_LISP, not alloca.
2753 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2754 to EMACS_INT. Check that fixnums are in proper range for system types.
2755 * minibuf.c (minibuf_prompt_width, string_to_object)
2756 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2757 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (get_minibuffer, read_minibuf_unwind):
2760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2761 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2762 this simplifies overflow checking. All callers changed.
2763 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2764 (Ftest_completion):
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2767 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2768 Check that fixnums are in proper range for system types.
2769 (Fx_create_frame, Fx_show_tip):
2770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2771 * nsfont.m (ns_findfonts, nsfont_list_family):
2772 Don't assume fixnum fits in long.
2773 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2776 wide enough.
17fdb222 2777 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2779 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2780 (PRINTDECLARE, PRINTPREPARE):
2781 (strout, print_string):
2782 (print, print_preprocess, print_check_string_charset_prop)
2783 (print_object):
2784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2785 (PRINTDECLARE):
2786 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2788 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2789 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2790 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2791 (print_error_message): Use SAFE_ALLOCA, not alloca.
2792 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2793 (print_depth, new_backquote_output, print_number_index):
2794 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2795 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2796 (Fset_process_window_size, Fformat_network_address)
2797 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2798 (sigchld_handler):
d311d28c 2799 Check that fixnums are in proper range for system types.
d44287d4 2800 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2801 Check for process-ids out of pid_t range rather than relying on
2802 undefined behavior.
e4d81efc 2803 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2804 (Fformat_network_address, read_process_output, send_process)
2805 (Fprocess_send_region, status_notify):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2808 (wait_reading_process_output, read_process_output, exec_sentinel):
2809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2810 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2811 (Faccept_process_output): Use duration_to_sec_usec to do proper
2812 overflow checking on durations.
dde14581
PE
2813 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2814 Don't assume pid_t fits in int.
02481186
PE
2815 * process.h (struct Lisp_Process): Members tick and update_tick
2816 are now of type EMACS_INT, not int.
b62b53e8
PE
2817 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2818 configured --with-wide-int.
d311d28c
PE
2819 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2820 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2821 * search.c (looking_at_1, string_match_1):
2822 (fast_string_match, fast_c_string_match_ignore_case)
2823 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2824 (scan_newline, find_before_next_newline, search_command)
2825 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2826 (set_search_regs, wordify):
2827 (Freplace_match):
2828 (Fmatch_data):
2829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2830 (string_match_1, search_buffer, set_search_regs):
2831 (Fmatch_data):
2832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2833 (wordify): Check for overflow in size calculation.
2834 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2835 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2836 Check that fixnums are in proper range for system types.
2837 * sound.c (struct sound_device)
2838 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2840 (Fplay_sound_internal):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2842 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2843 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2844 (Fparse_partial_sexp):
2845 Don't assume fixnums can fit in int.
2846 (struct lisp_parse_state, find_start_pos, find_start_value)
2847 (find_start_value_byte, find_start_begv)
2848 (update_syntax_table, char_quoted, dec_bytepos)
2849 (find_defun_start, prev_char_comend_first, back_comment):
2850 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2851 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2853 (Finternal_describe_syntax_value): Check that match_lisp is a
2854 character, not an integer, since the code stuffs it into int.
2855 (scan_words, scan_sexps_forward):
2856 Check that fixnums are in proper range for system types.
2857 (Fforward_word):
2858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2859 (scan_sexps_forward):
2860 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2861 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2862 * syntax.h: Adjust decls to match defn changes elsewhere.
2863 (struct gl_state_s):
2864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2865 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2866 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2867 * sysdep.c (wait_for_termination_1, wait_for_termination)
2868 (interruptible_wait_for_termination, mkdir):
2869 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2870 (emacs_read, emacs_write):
2871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2872 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2873 and double all fit in int.
d311d28c
PE
2874 * term.c (set_tty_color_mode):
2875 Check that fixnums are in proper range for system types.
2876 * termhooks.h (struct input_event):
2877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2878 * textprop.c (validate_interval_range, interval_of)
2879 (Fadd_text_properties, set_text_properties_1)
2880 (Fremove_text_properties, Fremove_list_of_text_properties)
2881 (Ftext_property_any, Ftext_property_not_all)
2882 (copy_text_properties, text_property_list, extend_property_ranges)
2883 (verify_interval_modification):
2884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2885 (Fnext_single_char_property_change)
2886 (Fprevious_single_char_property_change):
2887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2888 (copy_text_properties):
2889 Check for integer overflow in index calculation.
d311d28c
PE
2890 * undo.c (last_boundary_position, record_point, record_insert)
2891 (record_delete, record_marker_adjustment, record_change)
2892 (record_property_change):
2893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2894 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2896 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2897 (Fx_hide_tip, Fx_file_dialog):
2898 * w32menu.c (set_frame_menubar):
2899 Use ptrdiff_t, not int, for consistency with rest of code.
2900 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2901 (select_window, Fdelete_other_windows_internal)
2902 (window_scroll_pixel_based, window_scroll_line_based)
2903 (Frecenter, Fset_window_configuration):
2904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2905 (Fset_window_hscroll, run_window_configuration_change_hook)
2906 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2907 (Fscroll_other_window, Frecenter):
d311d28c
PE
2908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2909 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2910 Don't assume fixnum fits in int.
2911 (Fset_window_scroll_bars):
2912 Check that fixnums are in proper range for system types.
2913 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2914 (string_pos, c_string_pos, number_of_chars, init_iterator)
2915 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2916 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2917 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2918 (face_before_or_after_it_pos, handle_invisible_prop)
2919 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2920 (display_prop_intangible_p, string_buffer_position_lim)
2921 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2922 (get_overlay_strings_1, get_overlay_strings)
2923 (iterate_out_of_display_property, forward_to_next_line_start)
2924 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2925 (get_next_display_element, set_iterator_to_next)
2926 (get_visually_first_element, compute_stop_pos_backwards)
2927 (handle_stop_backwards, next_element_from_buffer)
2928 (move_it_in_display_line_to, move_it_in_display_line)
2929 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2930 (add_to_log, message_dolog, message_log_check_duplicate)
2931 (message2, message2_nolog, message3, message3_nolog
2932 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2933 (current_message_1, truncate_echo_area, truncate_message_1)
2934 (set_message, set_message_1, store_mode_line_noprop)
2935 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2936 (text_outside_line_unchanged_p, check_point_in_composition)
2937 (reconsider_clip_changes)
2938 (redisplay_internal, set_cursor_from_row, try_scrolling)
2939 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2940 (redisplay_window, find_last_unchanged_at_beg_row)
2941 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2942 (trailing_whitespace_p, find_row_edges, display_line)
2943 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2944 (display_mode_element, store_mode_line_string)
2945 (pint2str, pint2hrstr, decode_mode_spec)
2946 (display_count_lines, display_string, draw_glyphs)
2947 (x_produce_glyphs, x_insert_glyphs)
2948 (rows_from_pos_range, mouse_face_from_buffer_pos)
2949 (fast_find_string_pos, mouse_face_from_string_pos)
2950 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2952 (safe_call, init_from_display_pos, handle_fontified_prop)
2953 (handle_single_display_spec, load_overlay_strings)
2954 (with_echo_area_buffer, setup_echo_area_for_printing)
2955 (display_echo_area, echo_area_display)
2956 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2957 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2958 (redisplay_window, dump_glyph_row, display_mode_line)
2959 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2960 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2962 (handle_single_display_spec, build_desired_tool_bar_string)
2963 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2964 (get_specified_cursor_type):
2965 Check that fixnums are in proper range for system types.
2966 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2967 (Flookup_image_map):
2968 Don't assume fixnums fit in int.
2969 (compare_overlay_entries):
2970 Avoid mishandling comparisons due to subtraction overflow.
2971 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2972 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2973 (handle_tool_bar_click):
2974 Use int, not unsigned, since we prefer signed and the signedness
2975 doesn't matter here.
2976 (get_next_display_element, next_element_from_display_vector):
2977 Use int, not EMACS_INT, when int is wide enough.
2978 (start_hourglass): Use duration_to_sec_usec to do proper
2979 overflow checking on durations.
2980 * xfaces.c (Fbitmap_spec_p):
2981 Check that fixnums are in proper range for system types.
2982 (compare_fonts_by_sort_order):
2983 Avoid mishandling comparisons due to subtraction overflow.
2984 (Fx_family_fonts, realize_basic_faces):
2985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2986 (Fx_family_fonts):
2987 Don't assume fixnum fits in int.
2988 Use SAFE_ALLOCA_LISP, not alloca.
2989 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2990 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2991 (face_at_buffer_position, face_for_overlay_string)
2992 (face_at_string_position):
2993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2994 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2995 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2996 (Fx_show_tip):
2997 Check that fixnums are in proper range for system types.
2998 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2999 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3001 (Fx_change_window_property): Don't assume fixnums fit in int.
3002 * xfont.c (xfont_chars_supported):
3003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3004 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3005 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3007 * xml.c (parse_region):
3008 * xrdb.c (magic_file_p):
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3011 (x_get_local_selection, x_reply_selection_request)
3012 (x_handle_selection_request, wait_for_property_change):
3013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3014 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3015 short is wide enough.
3016 (x_send_client_event): Don't assume fixnum fits in int.
3017 * xterm.c (x_x_to_emacs_modifiers):
3018 Don't assume EMACS_INT overflows nicely into int.
3019 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3020 may come from Lisp.
3021 (handle_one_xevent): NATNUMP can eval its arg twice.
3022 (x_connection_closed):
3023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3024 * xterm.h: Adjust decls to match defn changes elsewhere.
3025 (struct scroll_bar): Use struct vectorlike_header
3026 rather than rolling our own approximation.
3027 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3028
c6574eb5
GM
30292012-05-25 Glenn Morris <rgm@gnu.org>
3030
3031 * lisp.mk (lisp): Update for more files being compiled now.
3032
e8d32c7e
SM
30332012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3034
48def666
SM
3035 * lread.c: Remove `read_pure' which makes no difference.
3036 (read_pure): Remove var.
3037 (unreadpure): Remove function.
3038 (readevalloop): Don't call read_list with -1 flag.
3039 (read1, read_vector): Don't test read_pure any more.
3040 (read_list): Simplify.
3041
e8d32c7e
SM
3042 * fileio.c, character.h: Minor style tweaks.
3043
4b2addb7
DA
30442012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3045
3046 * window.h (clip_changed): Remove useless declaration.
3047
584461b2
JB
30482012-05-22 Juanma Barranquero <lekktu@gmail.com>
3049
3050 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3051 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3052
34374650
PE
30532012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 Remove src/m/*.
3056 This directory predates autoconf and is no longer needed nowadays.
3057 Move its few remaining bits of functionality to where they're needed.
3058 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3059 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3060 * m/template.h: Remove.
3061 * Makefile.in (M_FILE): Remove. All uses removed.
3062 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3063 * lisp.h (USE_LSB_TAG):
3064 * mem-limits.h (EXCEEDS_LISP_PTR):
3065 Use VAL_MAX, not VALBITS, in #if.
3066 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3067 (EMACS_UINT): Define unconditionally now.
3068 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3069 (BITS_PER_EMACS_INT): New constants, replacing
3070 what used to be in config.h, but not useful in #if.
3071 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3072 define them any more.
3073 (VAL_MAX): New macro.
3074 (VALMASK): Use it.
3075 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3076 BITS_PER_EMACS_INT, in #if.
3077 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3078 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3079 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3080 * s/ms-w32.h (DATA_START):
3081 Move here from removed file m/intel386.h.
3082 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3083 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3084
261cb4bb
PE
30852012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3086
3087 Assume C89 or later.
3088 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3089 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3090 (xrealloc):
3091 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3092 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3093 * textprop.c, tparam.c (NULL): Remove.
3094 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3095 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3096 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3097 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3098 * xterm.c (input_signal_count): Assume volatile works.
3099
ff23cd9f
KB
31002012-05-21 Ken Brown <kbrown@cornell.edu>
3101
3102 * xgselect.c (xg_select): Fix first argument in call to 'select'
3103 (bug#11508).
3104
1b170bc6
KB
31052012-05-20 Ken Brown <kbrown@cornell.edu>
3106
3107 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3108 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3109
b2f4d39f
KB
31102012-05-19 Ken Brown <kbrown@cornell.edu>
3111
3112 * xfns.c (x_in_use): Remove `static' qualifier.
3113 * xterm.h (x_in_use): Declare.
3114 * xgselect.c: Include xterm.h.
3115 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3116 and `display_arg' (bug#9754).
3117
003fdae2
PE
31182012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3119
9232a6d9
PE
3120 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3121
003fdae2
PE
3122 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3123 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3124
784b56e2
EZ
31252012-05-18 Eli Zaretskii <eliz@gnu.org>
3126
3127 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3128
3129 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3130 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3131
3132 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3133 reference to image_cache->refcount.
3134 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3135
a0a79cde
JL
31362012-05-17 Juri Linkov <juri@jurta.org>
3137
3138 * search.c (Fword_search_regexp, Fword_search_backward)
3139 (Fword_search_forward, Fword_search_backward_lax)
3140 (Fword_search_forward_lax): Move functions to isearch.el
3141 (bug#10145, bug#11381).
3142
b0572523
PE
31432012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3144
3145 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3146
9660f5fc
SM
31472012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * lread.c (init_obarray): Declare Qt and Qnil as special.
3150
4374de83
GM
31512012-05-14 Glenn Morris <rgm@gnu.org>
3152
3153 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3154 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3155
dc44c39a
PE
31562012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3157
078c97cb
PE
3158 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3159
dc44c39a
PE
3160 * unexaix.c: Port to more-recent AIX compilers.
3161 (report_error, report_error_1, make_hdr, copy_sym)
3162 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3163 Make arguments const char *, not char *, to avoid violations of C
3164 standard and to fix some AIX warnings reported by Gilles Pion.
3165
e18afed7 31662012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3167
3168 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3169 already have overlays loaded.
3170 (handle_single_display_spec): Before returning without displaying
3171 fringe bitmap, synchronize the bidi iterator with the main display
3172 iterator, by calling iterate_out_of_display_property.
3173 (iterate_out_of_display_property): Detect buffer iteration by
3174 testing that it->string is a Lisp string.
3175 (get_next_display_element): When the current object is exhausted,
3176 and there's something on it->stack, call set_iterator_to_next to
3177 proceed with what's on the stack, instead of returning zero.
3178 (set_iterator_to_next): If called at the end of a Lisp string,
3179 proceed to consider_string_end without incrementing string
3180 position. Don't increment display vector index past the end of
3181 the display vector. (Bug#11417)
c8fb9dc6
EZ
3182 (pos_visible_p): Don't report a position visible when move_it_to
3183 stopped at the last line of window, which happens to be scanned
3184 backwards by the bidi iteration. (Bug#11464)
ac268e67 3185
e18afed7 31862012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3187
3188 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3189 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3190 are on a TTY, and thus unable to display on the fringes.
3191 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3192 so we need to signal to the caller that this is a "replacing"
3193 display spec. This fixes display when the spec is invalid or we
3194 are on a TTY.
3195
e18afed7 31962012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3197
3198 * unexaix.c (make_hdr): Fix typo in prototype.
3199 This bug broke the build on AIX. Problem reported by Gilles Pion.
3200
9d0a235a
MA
32012012-05-14 Michael Albinus <michael.albinus@gmx.de>
3202
3203 * keyboard.c (kbd_buffer_get_event): Read special events also in
3204 batch mode. (Bug#11415)
3205
9e6b06ed
GM
32062012-05-12 Glenn Morris <rgm@gnu.org>
3207
3208 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3209
c1a1d7a3
EZ
32102012-05-12 Eli Zaretskii <eliz@gnu.org>
3211
3212 * lisp.mk (lisp): Add newcomment.elc.
3213
3fe7cdc8
GM
32142012-05-12 Glenn Morris <rgm@gnu.org>
3215
3216 * Makefile.in (MKDIR_P): New, set by configure.
3217 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3218
53f7d2c0
PE
32192012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 Remove unused function hourglass_started.
3222 * dispextern.h (hourglass_started):
3223 * w32fns.c (hourglass_started):
3224 * xdisp.c (hourglass_started): Remove.
3225
75aafb17
JB
32262012-05-10 Juanma Barranquero <lekktu@gmail.com>
3227
3228 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3229 Update dependencies.
3230
12959e8e
PE
32312012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3232
97107e2e
PE
3233 * xgselect.c (xg_select): Put maxfds+1 into a var.
3234 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3235
12959e8e
PE
3236 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3237
836d29b3
DA
32382012-05-10 Dave Abrahams <dave@boostpro.com>
3239
3240 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3241 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3242
5cb67954
MA
32432012-05-09 Michael Albinus <michael.albinus@gmx.de>
3244
3245 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3246 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3247 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3248 Initialize xd_registered_buses.
3249
3478ec45
PE
32502012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3251
b263a6b0
PE
3252 Untag more efficiently if USE_LSB_TAG.
3253 This is based on a proposal by YAMAMOTO Mitsuharu in
3254 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3255 For an admittedly artificial (nth 8000 longlist) benchmark on
3256 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3257 Emacs's overall text size by 1%.
3258 * lisp.h (XUNTAG): New macro.
3259 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3260 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3261 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3262 * eval.c (Fautoload):
3263 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3264 * frame.h (XFRAME): Use XUNTAG.
3265
3478ec45
PE
3266 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3267 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3268 Remove unportable assumptions about print widths of types like
3269 dbus_uint32_t.
3270 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3271 intptr_t when converting between pointer and integer, to avoid GCC
3272 warnings about wrong width.
3273
666b903b 32742012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3275
3276 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3277 stack for each reader_thread, instead of defaulting to 8MB
3278 determined by the linker. This avoids failures in creating
3279 subprocesses on Windows 7, see the discussion in this thread:
3280 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3281
b120cc17
JC
32822012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3283
3284 Fix up display of the *Minibuf-0* buffer in the mini window.
3285 * keyboard.c (read_char): Don't clear the echo area if there's no
3286 message to clear.
3287 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3288 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3289
9a4b36f8
MA
32902012-05-07 Michael Albinus <michael.albinus@gmx.de>
3291
3292 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3293 batch mode.
3294
e5f9458f
CY
32952012-05-06 Chong Yidong <cyd@gnu.org>
3296
3297 * lisp.mk (lisp): Update.
3298
eceeb5fc 32992012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3300
3301 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3302
71873e2b
SM
33032012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3304
3305 * data.c (PUT_ERROR): New macro.
3306 (syms_of_data): Use it. Add new error type `user-error'.
3307 * undo.c (user_error): New function.
3308 (Fprimitive_undo): Use it.
3309 * print.c (print_error_message): Adjust print style for `user-error'.
3310 * keyboard.c (user_error): New function.
3311 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3312
ab0fa4e4
PE
33132012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 Do not limit current-time-string to years 1000..9999.
3316 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3317 (Fcurrent_time_string): Support any year that is supported by the
3318 underlying localtime representation. Don't use asctime, as it
3319 has undefined behavior for years outside the range -999..9999.
3320
7ed806a7
PE
33212012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3322
3323 Fix race conditions involving setenv, gmtime, localtime, asctime.
3324 Without this fix, interrupts could mess up code that uses these
3325 nonreentrant functions, since setting TZ invalidates existing
3326 tm_zone or tzname values, and since most of these functions return
3327 pointers to static storage.
3328 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3329 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3330 Grow the critical sections to include not just invoking
3331 localtime/gmtime, but also accessing these functions' results
3332 including their tm_zone values if any, and any related TZ setting.
3333 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3334 so that the struct tm is saved in the critical section.
3335 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3336 motivated by the fact that memory allocation needs to be outside
3337 the critical section.
3338
0c16dfed
DA
33392012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3340
3341 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3342 with RESET_INTERVAL.
3343
3344 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3345 Remove duplicated buffer name initialization.
3346
3f83ace8
JM
33472012-05-02 Jim Meyering <jim@meyering.net>
3348
3349 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3350
c7b8541e
JM
3351 * xfns.c (x_window): Use xstrdup (Bug#11375).
3352
90207a15 33532012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3354
3355 * xdisp.c (pos_visible_p): If already at a newline from the
3356 display string before the 'while' loop, don't walk back the glyphs
3357 from it3.glyph_row. Solves assertion violation when the display
3358 string begins with a newline (egg.el). (Bug#11367)
3359
b593d6a9
AH
33602012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3361
3362 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3363 Move to simple.el.
3364
4737362e
GM
33652012-05-01 Glenn Morris <rgm@gnu.org>
3366
99cf43f9
GM
3367 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3368 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3369 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3370 All were removed before 23.1.
3371
9311dcff
GM
3372 * dispnew.c: Remove HAVE_LIBNCURSES test;
3373 it is always true on relevant platforms.
3374
4d5c6349
GM
3375 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3376 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3377
4737362e
GM
3378 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3379
74dd3a6b
AS
33802012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3381
3382 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3383 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3384 Remove.
3385
13c379ee
PE
33862012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 Do not avoid creating empty evaporating overlays (Bug#9642).
3389 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3390 That is, do not delete an evaporating overlay if it becomes
3391 empty after its bounds are adjusted to fit within its buffer.
3392 This fix caused other problems, and I'm reverting it until we get
3393 to the bottom of them.
3394
a8e7d6d7 33952012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3396
3397 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3398
a8e7d6d7 33992012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3400
3401 * xdisp.c (pos_visible_p): If the window start position is beyond
3402 ZV, start the display from buffer beginning. Prevents assertion
3403 violation in init_iterator when the minibuffer window is scrolled
3404 via the scroll bar.
3405
3406 * window.c (window_scroll_pixel_based): Likewise.
3407
a8e7d6d7 34082012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3409
3410 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3411
a8e7d6d7 34122012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3413
3414 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3415 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3416
a8e7d6d7 34172012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3418
b593d6a9
AH
3419 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3420 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3421
1c6900d9
EZ
34222012-04-26 Eli Zaretskii <eliz@gnu.org>
3423
4c3fa1d9
EZ
3424 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3425 display element, check also the underlying string or buffer
3426 character. (Bug#11341)
3427
1c6900d9
EZ
3428 * w32menu.c: Include w32heap.h.
3429 (add_menu_item): If the call to AppendMenuW (via
3430 unicode_append_menu) fails, disable Unicode menus only if we are
3431 running on Windows 9X/Me.
3432
42bf8205
AS
34332012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3434
3435 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3436 (xgetint): Add missing shift for LSB tags.
3437
b1bac16e
MR
34382012-04-24 Martin Rudalics <rudalics@gmx.at>
3439
3440 * keyboard.c (read_char): Don't wipe echo area for select window
3441 events: These might get delayed via `mouse-autoselect-window'
3442 (Bug#11304).
3443
d69621cc
JB
34442012-04-24 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3447 manipulation of :loaded-from data.
3448
02fd101b
JB
34492012-04-23 Juanma Barranquero <lekktu@gmail.com>
3450
3451 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3452 now a cons (bug#11311).
3453
888bec30
PE
34542012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3455
89a438bd
PE
3456 Do not create empty overlays with the evaporate property (Bug#9642).
3457 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3458 if it becomes empty after its bounds are adjusted to fit within
3459 its buffer. Without this fix, in a nonempty buffer (let ((o
3460 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3461 yields an empty overlay that has the evaporate property, which is
3462 not supposed to happen.
3463
1068fe4d
PE
3464 Fix minor GTK3 problems found by static checking.
3465 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3466 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3467 (struct _EmacsFixedClass, emacs_fixed_get_type):
3468 Move decls here from emacsgtkfixed.h, since they needn't be public.
3469 (emacs_fixed_get_type): Now static.
3470 (emacs_fixed_class_init): Omit unused local.
3471 (emacs_fixed_child_type): Remove; unused.
3472 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3473 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3474 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3475 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3476 (EMACS_FIXED_GET_CLASS): Remove; unused.
3477 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3478
888bec30
PE
3479 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3480 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3481
de85e130
PE
34822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3483
d0baac98 3484 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3485 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3486 (__malloc_size_t, __malloc_ptrdiff_t):
3487 Remove. All uses removed, replaced by the definiens if needed,
3488 since we can assume C89 or better now.
3489 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3490 (protect_malloc_state, align, get_contiguous_space)
3491 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3492 (malloc_atfork_handler_child, malloc_enable_thread)
3493 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3494 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3495 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3496 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3497 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3498 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3499 Define using prototypes, not old style.
3500 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3501 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3502 (align): Don't assume that signed integer overflow wraps around.
3503 Omit unused local var.
3504 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3505 (_free_internal_nolock, memalign, mallochook, reallochook):
3506 Omit no-longer-needed casts.
3507 (valloc): Use getpagesize, not __getpagesize.
3508 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3509 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3510
de85e130
PE
3511 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3512
dcbf5805
MA
35132012-04-22 Michael Albinus <michael.albinus@gmx.de>
3514
3515 Move functions from C to Lisp. Make non-blocking method calls
3516 the default. Implement further D-Bus standard interfaces.
3517
3518 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3519 (QCdbus_request_name_allow_replacement)
3520 (QCdbus_request_name_replace_existing)
3521 (QCdbus_request_name_do_not_queue)
3522 (QCdbus_request_name_reply_primary_owner)
3523 (QCdbus_request_name_reply_in_queue)
3524 (QCdbus_request_name_reply_exists)
3525 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3526 (QCdbus_registered_serial, QCdbus_registered_method)
3527 (QCdbus_registered_signal): New Lisp objects.
3528 (XD_DEBUG_MESSAGE): Use sizeof.
3529 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3530 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3531 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3532 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3533 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3534 (xd_signature, xd_append_arg): Allow float for integer types.
3535 (xd_get_connection_references): New function.
b593d6a9
AH
3536 (xd_get_connection_address): Rename from xd_initialize.
3537 Return cached address.
dcbf5805
MA
3538 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3539 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3540 level.
3541 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3542 Return number of refcounts.
dcbf5805
MA
3543 (Fdbus_get_unique_name): Make stronger parameter check.
3544 (Fdbus_message_internal): New defun.
3545 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3546 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3547 (Fdbus_send_signal, Fdbus_register_service)
3548 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3549 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3550 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3551 (Vdbus_compiled_version, Vdbus_runtime_version)
3552 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3553 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3554 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3555 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3556 Adapt docstring.
dcbf5805 3557
52828e02
PE
35582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3559
da05bc4c
PE
3560 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3561 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3562 Do not assume ptrdiff_t is the same width as 'int'.
3563
52828e02
PE
3564 * alloc.c: Handle unusual debugging option combinations.
3565 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3566 since the two debugging options are incompatible.
3567 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3568 is defined.
3569 (mem_init, mem_insert, mem_insert_fixup):
3570 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3571 (NEED_MEM_INSERT): Remove; no longer needed.
3572
f01769f9
LL
35732012-04-22 Leo Liu <sdl.web@gmail.com>
3574
3575 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3576
5790543d
PE
35772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 * sysdep.c [__FreeBSD__]: Minor cleanups.
3580 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3581 Use Emacs indenting style more consistently. Avoid some casts.
3582 Use 'double' consistently rather than mixing 'float' and 'double'.
3583
b91b7e4d
EW
35842012-04-21 Eduard Wiebe <usenet@pusto.de>
3585
b593d6a9
AH
3586 * sysdep.c (list_system_processes, system_process_attributes):
3587 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3588
6114eb15
AS
35892012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3590
3591 * lisp.mk (lisp): Update.
3592
2f38dff7
PE
35932012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3596 It is never used otherwise.
3597
4ae29f89
SM
35982012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3599
3600 * print.c (print_preprocess): Only check print_depth if print-circle
3601 is nil.
3602 (print_object): Check for cycles even when print-circle is nil and
3603 print-gensym is t, but only check print_depth if print-circle is nil.
3604
f30d612a
CY
36052012-04-20 Chong Yidong <cyd@gnu.org>
3606
3607 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3608 set the status to "failed" and ensure that sentinel is run.
3609
c07a4c0b 36102012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3611
3612 * process.c (Fset_process_inherit_coding_system_flag)
3613 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3614 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3615
c07a4c0b 36162012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3617
3618 * xdisp.c (string_buffer_position_lim): Limit starting position to
3619 BEGV.
3620 (set_cursor_from_row): If called for a mode-line or header-line
3621 row, return zero immediately.
3622 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3623 farther than the first row after the header line, if any.
3624 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3625 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3626
c07a4c0b 36272012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3628
4ae29f89
SM
3629 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3630 (bug#11238).
ad3a2b41 3631
c07a4c0b 36322012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36332012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3634
3635 configure: new option --enable-gcc-warnings (Bug#11207)
3636 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3637 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3638 (ALL_CFLAGS): Use new macros rather than old.
3639 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3640 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3641 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3642 -Wunused-result, -Wunused-variable. This should go away once
3643 the Emacs and Gnulib regex code is merged.
3644 (xmalloc, xrealloc): Now static.
3645
aba027e8
PE
36462012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * dired.c (Fsystem_groups): Remove unused local.
3649
e5a36063
GM
36502012-04-17 Glenn Morris <rgm@gnu.org>
3651
3652 * dired.c (Fsystem_users): Doc fix.
3653
316411f0
DA
36542012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3655
3656 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3657 (syms_of_dired): Add them.
3658
9426aba4
PE
36592012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3660
b62a57be
PE
3661 Fix minor alloc.c problems found by static checking.
3662 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3663 New extern decls, to avoid calling undeclared functions.
3664 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3665 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3666 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3667 (NEED_MEM_INSERT): New macro.
3668 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3669 Remove one incorrect comment and fix another.
b62a57be 3670
3539f31f
PE
3671 Fix minor ralloc.c problems found by static checking.
3672 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3673 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3674 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3675 (r_alloc_sbrk): Now static.
3676
a041960a
PE
3677 Improve ralloc.c interface checking.
3678 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3679 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3680 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3681 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3682 [REL_ALLOC]: ... to here, to check interface.
3683 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3684 Remove decls. This fixes an "It stinks!".
3685
9426aba4
PE
3686 * alloc.c (which_symbols): Fix alignment issue / type clash.
3687
d55c12ed
AS
36882012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3689
3690 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3691 (struct Lisp_Misc_Any): Likewise.
3692 (struct Lisp_Free): Likewise.
3693 * alloc.c (union aligned_Lisp_Symbol): Define.
3694 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3695 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3696 (union aligned_Lisp_Misc): Define.
3697 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3698 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3699 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3700
b948ce8b
PE
37012012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3702
3703 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3704 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3705 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3706 * s/netbsd.h, s/sol2-6.h:
3707 Remove definition of GC_MARK_STACK, since the default now works.
3708 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3709 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3710 no longer the default.
3711 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3712
35dc09a1 37132012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3714
35dc09a1
GM
3715 * lread.c (lisp_file_lexically_bound_p):
3716 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3717
35dc09a1
GM
37182012-04-14 Eli Zaretskii <eliz@gnu.org>
3719
3720 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3721 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3722
37232012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3724
3725 * nsterm.m (constrainFrameRect): Always constrain when there is only
3726 one screen (Bug#10962).
3727
bcd86815
KB
37282012-04-13 Ken Brown <kbrown@cornell.edu>
3729
3730 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3731
c25df26e
RT
37322012-04-13 Reuben Thomas <rrt@sc3d.org>
3733
3734 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3735
0fc59f1e
DC
37362012-04-11 Daniel Colascione <dancol@dancol.org>
3737
3738 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3739 against is gone. It's better to use vfork now so that when Cygwin
3740 gains a new, working vfork, we use it automatically (bug#10398).
3741
de8c03dc
SM
37422012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3743
3744 * window.c (save_window_save): Obey window-point-insertion-type.
3745
2f097256
GM
37462012-04-11 Glenn Morris <rgm@gnu.org>
3747
3748 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3749
453b951e
SM
37502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3751
3752 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3753
75f1671a 37542012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3755
3756 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3757 (force_quit_count): New var.
3758 (handle_interrupt): Use it.
3759
2a8ce227
JB
37602012-04-10 Juanma Barranquero <lekktu@gmail.com>
3761
3762 * w32.c (w32_delayed_load): Record the full path of the library
3763 being loaded (bug#10424).
3764
935396c0
GM
37652012-04-09 Glenn Morris <rgm@gnu.org>
3766
05920a43
GM
3767 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3768 not just in the obarray, before snarfing them. (Bug#11036)
3769
935396c0
GM
3770 * Makefile.in ($(leimdir)/leim-list.el):
3771 Pass EMACS rather than BUILT_EMACS.
3772
a18ecafa
TZ
37732012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3774
3775 * process.c (make_process):
3776 * process.h: Add integer `gnutls_handshakes_tried' member to
3777 process struct.
3778
6bbef4e5
JC
3779 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3780 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3781
3782 * gnutls.c (gnutls_log_function2i): Convenience log function.
3783 (emacs_gnutls_read): Use new log functions,
3784 `gnutls_handshakes_tried' process member, and
3785 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3786 attempts per process (connection).
3787
b4d3bc10
CY
37882012-04-09 Chong Yidong <cyd@gnu.org>
3789
3790 * eval.c (Fuser_variable_p, user_variable_p_eh)
3791 (lisp_indirect_variable): Functions deleted.
3792 (Fdefvar): Caller changed.
3793
3794 * callint.c (Finteractive, Fcall_interactively):
3795 * minibuf.c (Fread_variable): Callers changed.
3796
70f4d973
EZ
37972012-04-09 Eli Zaretskii <eliz@gnu.org>
3798
3799 * xdisp.c (set_cursor_from_row): If the display string appears in
3800 the buffer at position that is closer to point than the position
3801 after the display string, display the cursor on the first glyph of
3802 the display string. Fixes cursor display when a 'display' text
3803 property immediately follows invisible text. (Bug#11094)
3804
cb3c2e3e
PE
38052012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 composite.c: use 'double' consistently
3808 * composite.c (get_composition_id): Use 'double' consistently
3809 instead of converting 'float' to 'double' and vice versa; this is
3810 easier to understand and avoids a GCC warning.
3811
fd06db5d
GM
38122012-04-09 Glenn Morris <rgm@gnu.org>
3813
50fe702a
GM
3814 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3815 preparation for dumping it with emacs. (Bug#4789)
3816 (leimdir): New variable.
3817 ($(leimdir)/leim-list.el): New rule.
3818 (emacs$(EXEEXT)): Depend on leim-list.el.
3819
fd06db5d
GM
3820 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3821 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3822 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3823
55c131ee
AS
38242012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3825
3826 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3827 proper alignment.
3828
9209588f
JB
38292012-04-07 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3832 Remove unused local variable.
3833
e3fb2efb
PE
38342012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3837 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3838 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3839 objects, as mark_maybe_pointer will catch them otherwise.
3840 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3841 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3842
b5385551
PE
38432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 Fix typo that broke non-Windows builds.
3846 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3847
9078ead6
EZ
38482012-04-07 Eli Zaretskii <eliz@gnu.org>
3849
3850 Support building on MS-Windows with libxml2.
3851
3852 * makefile.w32-in (OBJ2): Add xml.$(O).
3853 (GLOBAL_SOURCES): Add xml.c.
3854 ($(BLD)/xml.$(O)): New dependency list.
3855
3856 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3857 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3858 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3859 [!WINDOWSNT]: New macros.
3860 (init_libxml2_functions, libxml2_loaded_p): New functions.
3861 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3862 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3863 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3864 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3865 linked in).
6bbef4e5
JC
3866 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3867 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3868 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3869
3870 * emacs.c: Don't include libxml/parser.h.
3871 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3872 xmlCleanupParser directly.
3873
3874 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3875
3811fdf3
EZ
38762012-04-07 Eli Zaretskii <eliz@gnu.org>
3877
3878 * indent.c (Fvertical_motion): If there is a display string at
3879 point, use it.vpos to compute how many lines to backtrack after
3880 move_it_to point. (Bug#11133)
3881
2f8e16b2
EZ
38822012-04-06 Eli Zaretskii <eliz@gnu.org>
3883
3884 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3885 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3886 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3887 macros related to unification of CJK characters. For the details,
3888 see the discussion following the message here:
3889 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3890
3d439cd1
CY
38912012-04-04 Chong Yidong <cyd@gnu.org>
3892
3893 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3894
8bc53d00
EZ
38952012-04-01 Eli Zaretskii <eliz@gnu.org>
3896
3897 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3898 instead of alloca. (Bug#11138)
3899
3b0512a3
AS
39002012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3901
3902 * w32menu.c (is_simple_dialog): Properly check lisp types.
3903 (Bug#11141)
3904
8427ddd2
EZ
39052012-03-31 Eli Zaretskii <eliz@gnu.org>
3906
979022ef
EZ
3907 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3908 position we get to after a call to move_it_to fails the
3909 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3910 only if we wind up in a string from display property. (Bug#11063)
3911
a6b1c7cc
EZ
3912 * window.c (Fdelete_other_windows_internal): Invalidate the row
3913 and column information about mouse highlight, so that redisplay
3914 restores it after reallocating the glyph matrices. (Bug#7464)
3915
8427ddd2
EZ
3916 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3917 string comes from a `display' text property, use the buffer
3918 position of that property as if we actually saw that position in
3919 the row's glyphs.
697ba24b
EZ
3920 (move_it_by_lines): Remove the assertion that
3921 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3922 violated when there's a before-string at the beginning of a line.
3923 (Bug#11063)
8427ddd2 3924
65a0a738
EZ
39252012-03-30 Eli Zaretskii <eliz@gnu.org>
3926
3927 * xdisp.c (append_space_for_newline): If the default face was
3928 remapped, use the remapped face for the appended newline.
3929 (extend_face_to_end_of_line): Use the remapped default face for
3930 extending the face to the end of the line.
3931 (display_line): Call extend_face_to_end_of_line when the default
3932 face was remapped. (Bug#11068)
3933
581355cc
EZ
39342012-03-29 Eli Zaretskii <eliz@gnu.org>
3935
3936 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3937
e8fc049f
SM
39382012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3939
3940 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3941
4fb9a543
GM
39422012-03-27 Glenn Morris <rgm@gnu.org>
3943
3944 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3945 Doc fixes.
3946
679910f1
KH
39472012-03-26 Kenichi Handa <handa@m17n.org>
3948
3949 * dispextern.h (struct glyph): Fix previous change. Change the
3950 bit length of glyphless.ch to 25 (Bug#11082).
3951
90d49b7f
CY
39522012-03-26 Chong Yidong <cyd@gnu.org>
3953
3954 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3955 (command_loop_1): Use it; inhibit selection update for
3956 handle-select-window too (Bug#8996).
3957
f514f6f0
FP
39582012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3959
e8fc049f 3960 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3961
bf43fa51
KH
39622012-03-25 Kenichi Handa <handa@m17n.org>
3963
3964 * dispextern.h (struct glyph): Change the bit length of
3965 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3966
8a0c01dd
EZ
39672012-03-24 Eli Zaretskii <eliz@gnu.org>
3968
3969 * s/ms-w32.h (tzname): Include time.h before redirecting to
3970 _tzname. Fixes the MSVC build. (Bug#9960)
3971
7d1c3a76
AS
39722012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3973
8ed79523
AS
3974 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3975 characters.
3976
7d1c3a76
AS
3977 * xterm.c (XTread_socket): Only modify handling_signal if
3978 !SYNC_INPUT. (Bug#11080)
3979
e99a9b8b
EZ
39802012-03-23 Eli Zaretskii <eliz@gnu.org>
3981
3982 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3983 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3984 when fetching a multibyte character consumes more bytes than
3985 CHAR_BYTES returns, due to unification of CJK characters in
3986 string_char. (Bug#11073)
3987
5063c0e1
TN
39882012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3989
3990 * process.c (wait_reading_process_output): Handle pty disconnect
3991 by refraining from sending oneself a SIGCHLD (bug#10933).
3992
9f851fbd
CY
39932012-03-22 Chong Yidong <cyd@gnu.org>
3994
3995 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3996
5063c0e1 3997 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3998 Mark string as coming from a prefix property.
3999 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4000 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4001
fb5b8aca
CY
40022012-03-21 Chong Yidong <cyd@gnu.org>
4003
4004 * xfaces.c (Vface_remapping_alist): Doc fix.
4005
62356a1b
EZ
40062012-03-20 Eli Zaretskii <eliz@gnu.org>
4007
4008 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4009 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4010 Doc fixes.
62356a1b 4011
025de85b
CY
40122012-03-20 Chong Yidong <cyd@gnu.org>
4013
4014 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4015 to reflect default non-nil value of redisplay-dont-pause.
4016
4827f94e
KH
40172012-03-19 Kenichi Handa <handa@m17n.org>
4018
4019 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4020 it fit in a valid range (Bug#11003).
4021
e50a24a2
EZ
40222012-03-18 Eli Zaretskii <eliz@gnu.org>
4023
4024 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4025 that is not from display property, accept the row as a "cursor
4026 row" if one of the string's character has a non-nil `cursor'
4027 property. Fixes cursor positioning when there are newlines in
4028 overlay strings, e.g. in icomplete.el. (Bug#11035)
4029
9af5ed87
PE
40302012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4033
d1f55f16
CY
40342012-03-12 Chong Yidong <cyd@gnu.org>
4035
4036 * eval.c (inhibit_lisp_code): Rename from
4037 inhibit_window_configuration_change_hook; move from window.c.
4038
4039 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4040 * window.c (run_window_configuration_change_hook)
4041 (syms_of_window): Callers changed.
4042
66c5eebd
CY
40432012-03-11 Chong Yidong <cyd@gnu.org>
4044
413df973
CY
4045 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4046
66c5eebd
CY
4047 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4048
1de11f56
CY
40492012-03-10 Chong Yidong <cyd@gnu.org>
4050
4051 * frame.c (other_visible_frames): Don't assume the selected frame
4052 is visible (Bug#10955).
4053
cae07000
SM
40542012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4055
4056 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4057
89c94350
JD
40582012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4059
4060 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4061 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4062 zero (Bug#10954).
4063
999dd333
GM
40642012-03-03 Glenn Morris <rgm@gnu.org>
4065
01a6dcc8 4066 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4067
de0100f2
EZ
40682012-03-02 Eli Zaretskii <eliz@gnu.org>
4069
4070 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4071 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4072 (redisplay_window, next_element_from_string): Fix typos in
4073 comments.
3e441275
EZ
4074 (redisplay_window): Pass to move_it_vertically the margin in
4075 pixels, not in screen lines.
de0100f2 4076
96a72ee9
GM
40772012-03-02 Glenn Morris <rgm@gnu.org>
4078
4079 * buffer.c (buffer-list-update-hook): Doc fix.
4080
312508d7
EZ
40812012-02-29 Eli Zaretskii <eliz@gnu.org>
4082
4083 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4084 push_it before setting up the iterator for the first overlay
4085 string, even if we have an empty string loaded.
4086 (next_overlay_string): If there's an empty string on the iterator
4087 stack, pop the stack. (Bug#10903)
4088
27f3c637
PE
40892012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4090
4091 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4092 Suggested by Stefan Monnier in
4093 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4094 * alloc.c (widen_to_Lisp_Object): New static function.
4095 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4096 and widening them to Lisp_Objects. This would work even if
4097 USE_LSB_TAG is defined and wide integers are used, which might
4098 happen in a future version of Emacs.
4099
3c9dfce6
CY
41002012-02-25 Chong Yidong <cyd@gnu.org>
4101
fa74b241
CY
4102 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4103 Doc fix.
4104
3c9dfce6
CY
4105 * xselect.c (Fx_selection_exists_p): Doc fix.
4106 (x_clipboard_manager_save_all): Print an informative message
4107 before saving to clipboard manager.
4108
9486df08
CY
41092012-02-24 Chong Yidong <cyd@gnu.org>
4110
4111 * keyboard.c (process_special_events): Handle all X selection
4112 requests in kbd_buffer, not just the next one (Bug#8869).
4113
f01d3321
CY
41142012-02-23 Chong Yidong <cyd@gnu.org>
4115
4116 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4117 call when setting menu-bar-lines and tool-bar-lines parameters.
4118 (unwind_create_frame_1): New helper function.
4119
4120 * window.c (inhibit_window_configuration_change_hook): New var.
4121 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4122 (syms_of_window): Initialize it.
f01d3321 4123
86b847b6
CY
41242012-02-22 Chong Yidong <cyd@gnu.org>
4125
4126 * xterm.c (x_draw_image_relief): Add missing type check for
4127 Vtool_bar_button_margin (Bug#10743).
4128
a59225b1
CY
41292012-02-21 Chong Yidong <cyd@gnu.org>
4130
4131 * fileio.c (Vfile_name_handler_alist): Doc fix.
4132
4133 * buffer.c (Fget_file_buffer): Protect against invalid file
4134 handler return value.
4135
310f5bd4
PE
41362012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4137
cb3a28cc
PE
4138 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4139 when computing $valmask.
4140
310f5bd4
PE
4141 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4142 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4143 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4144 It's useless in that case, and it can cause problems on hosts
4145 that allocate halves of EMACS_INT values separately.
4146 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4147 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4148 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4149 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4150 it avoids undefined behavior on hosts where shifting right by more
4151 than the word width has undefined behavior.
4152
2375c96a
CY
41532012-02-19 Chong Yidong <cyd@gnu.org>
4154
4155 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4156 (Funhandled_file_name_directory, Ffile_name_as_directory)
4157 (Fdirectory_file_name, Fexpand_file_name)
4158 (Fsubstitute_in_file_name): Protect against invalid file handler
4159 return values (Bug#10845).
4160
3eb49e71
EZ
41612012-02-18 Eli Zaretskii <eliz@gnu.org>
4162
4163 * .gdbinit (pitx): Fix incorrect references to fields of the
4164 iterator stack.
4165
7b926f3f
CY
41662012-02-17 Chong Yidong <cyd@gnu.org>
4167
4168 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4169
11273115
PE
41702012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4173 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4174
c3a70e2b
CY
41752012-02-15 Chong Yidong <cyd@gnu.org>
4176
4177 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4178 marked as special. Also, starting docstrings with * is obsolete.
4179
0ca43699
AS
41802012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4181
4182 * gnutls.c (emacs_gnutls_write): Fix last change.
4183
2e8f3c56
LI
41842012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4185
4186 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4187 send_process.
4188
af70074f
SM
41892012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4190
4191 * keymap.c (Fsingle_key_description): Handle char ranges.
4192
95986d52
CY
41932012-02-12 Chong Yidong <cyd@gnu.org>
4194
afd83bd1
CY
4195 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4196 as that creates a dangerous corner case.
4197
95986d52
CY
4198 * window.c (Fdelete_window_internal): Invalidate the mouse
4199 highlight (Bug#9904).
4200
bd7da63e
GM
42012012-02-12 Glenn Morris <rgm@gnu.org>
4202
4203 * xselect.c (Fx_own_selection_internal)
4204 (Fx_get_selection_internal, Fx_disown_selection_internal)
4205 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4206 * nsselect.m (Fx_own_selection_internal)
4207 (Fx_disown_selection_internal, Fx_selection_exists_p)
4208 (Fx_selection_owner_p, Fx_get_selection_internal):
4209 Sync docs and argument specs with the xselect.c versions.
4210
77abcbc2
LI
42112012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4212
4213 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4214
90b671e2
EZ
42152012-02-11 Eli Zaretskii <eliz@gnu.org>
4216
1c0ca0b7
EZ
4217 * w32select.c (Fx_selection_exists_p): Sync doc string and
4218 argument list with xselect.c. (Bug#10783)
4219
4220 * w16select.c (Fx_selection_exists_p): Sync doc string and
4221 argument list with xselect.c. (Bug#10783)
90b671e2 4222
49241268
GM
42232012-02-10 Glenn Morris <rgm@gnu.org>
4224
4225 * fns.c (Fsecure_hash): Doc fix.
4226
f998bbe7 42272012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4228
4229 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4230
0992bd9c
CY
42312012-02-07 Chong Yidong <cyd@gnu.org>
4232
4233 * buffer.c (Fbuffer_local_variables)
4234 (buffer_lisp_local_variables): Handle unbound vars correctly;
4235 don't let Qunbound leak into Lisp.
4236
af008560
GM
42372012-02-07 Glenn Morris <rgm@gnu.org>
4238
dd605cc4
GM
4239 * image.c (Fimagemagick_types): Doc fix.
4240
af008560
GM
4241 * image.c (imagemagick-render-type): Change it from a lisp object
4242 to an integer. Move the doc here from the lisp manual.
4243 Treat all values not equal to 0 the same.
4244
1449fa1d
CY
42452012-02-06 Chong Yidong <cyd@gnu.org>
4246
4247 * doc.c (store_function_docstring): Avoid applying docstring of
4248 alias to base function (Bug#2603).
4249
3723ec07
AS
42502012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4251
4252 * .gdbinit (pp1, pv1): Remove redundant defines.
4253 (pr): Use pp.
4254
79c1cc1e
CY
42552012-02-04 Chong Yidong <cyd@gnu.org>
4256
4257 * nsterm.m: Declare a global (Bug#10694).
4258
d7f29f8e
EZ
42592012-02-04 Eli Zaretskii <eliz@gnu.org>
4260
cae07000
SM
4261 * w32.c (get_emacs_configuration_options):
4262 Include --enable-checking, if specified, in the return value.
d7f29f8e 4263
3b95a6f9
MR
42642012-02-04 Martin Rudalics <rudalics@gmx.at>
4265
4266 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4267 after rounding frame sizes. (Bug#9723)
4268
d6fa96a6
EZ
42692012-02-04 Eli Zaretskii <eliz@gnu.org>
4270
4271 * keyboard.c (adjust_point_for_property): Don't position point
4272 before BEGV. (Bug#10696)
4273
df0b2940
PE
42742012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4275
4276 Handle overflow when computing char display width (Bug#9496).
4277 * character.c (char_width): Return EMACS_INT, not int.
4278 (char_width, c_string_width): Check for overflow when
4279 computing the width; this is possible now that individual
4280 characters can have unbounded width. Problem introduced
4281 by merge from Emacs 23 on 2012-01-19.
4282
6bee44d6
MA
42832012-02-02 Michael Albinus <michael.albinus@gmx.de>
4284
4285 * dbusbind.c (Fdbus_register_method): Mention the return value
4286 :ignore in the docstring.
4287
44f92739
GM
42882012-02-02 Glenn Morris <rgm@gnu.org>
4289
1b9f60cc
GM
4290 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4291
44f92739
GM
4292 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4293 Unconditionally set to t. (Bug#10673)
4294 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4295 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4296 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4297
c5d3843c
KH
42982012-02-02 Kenichi Handa <handa@m17n.org>
4299
4300 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4301 0, do not call append_composite_glyph.
4302
159462d4 43032012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4304
4305 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4306 NULL (Bug#6988).
4307 (x_produce_glyphs): If the component of a composition is a null
4308 string, set it->pixel_width to 1 to avoid zero-width glyph.
4309
78cef877
EZ
43102012-02-01 Eli Zaretskii <eliz@gnu.org>
4311
4312 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4313 first 2 arguments are identical. This makes inserting large
4314 output from a subprocess an order of magnitude faster on
4315 MS-Windows, where all sbrk'ed memory is always contiguous.
4316
97897668
GM
43172012-01-31 Glenn Morris <rgm@gnu.org>
4318
4319 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4320 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4321 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4322
31fd3586
GM
43232012-01-29 Glenn Morris <rgm@gnu.org>
4324
4325 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4326
0e24a8b2
CY
43272012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4328
4329 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4330
cc0adcb0
CY
43312012-01-28 Chong Yidong <cyd@gnu.org>
4332
4333 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4334
acc28cb9
CY
43352012-01-26 Chong Yidong <cyd@gnu.org>
4336
9c69cfb7
CY
4337 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4338
acc28cb9
CY
4339 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4340 repeat counts (Bug#10507).
4341
48da7392
GM
43422012-01-26 Glenn Morris <rgm@gnu.org>
4343
4344 * lread.c (syms_of_lread): Doc fix.
4345
14af5f7f
CY
43462012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4347
4348 * coding.c (encode_designation_at_bol): Change return value to
4349 EMACS_INT.
4350
0b21c100
CY
43512012-01-25 Chong Yidong <cyd@gnu.org>
4352
4353 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4354
3c2907f7
CY
43552012-01-21 Chong Yidong <cyd@gnu.org>
4356
4357 * floatfns.c (Fcopysign): Make the second argument non-optional,
4358 since nil is not allowed anyway.
4359
959ad23f
AS
43602012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4361
4362 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4363 (send_process): Likewise.
4364
34a02f46
MR
43652012-01-19 Martin Rudalics <rudalics@gmx.at>
4366
4367 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4368 (Vwindow_persistent_parameters): Do not use Qstate.
4369 Rewrite doc-strings.
34a02f46 4370
1259009a 43712012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4372
4373 * character.c (char_width): New function.
70d4fdf6
GM
4374 (Fchar_width, c_string_width, lisp_string_width):
4375 Use char_width (Bug#9496).
25ed9e61 4376
6a6ee00d
MR
43772012-01-16 Martin Rudalics <rudalics@gmx.at>
4378
4379 * window.c (Vwindow_persistent_parameters): New variable.
4380 (Fset_window_configuration, save_window_save): Handle persistent
4381 window parameters.
4382
c85efaf7
EZ
43832012-01-14 Eli Zaretskii <eliz@gnu.org>
4384
4385 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4386 thrashing the stack of the thread. (Bug#9087)
4387
5944709e
PE
43882012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4389
4390 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4391
e71f5d99
EZ
43922012-01-11 Eli Zaretskii <eliz@gnu.org>
4393
4394 * xdisp.c (rows_from_pos_range): Handle the case where the
4395 highlight ends on a newline. (Bug#10464)
4396 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4397 he end column for display of highlight that ends on a newline
4398 before a R2L line.
4399
ce316182
GM
44002012-01-11 Glenn Morris <rgm@gnu.org>
4401
4402 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4403 from load-path also when installation-directory is nil. (Bug#10208)
4404
5b43da69
GM
44052012-01-10 Glenn Morris <rgm@gnu.org>
4406
74cc8ff9
GM
4407 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4408
7d8d6e4e
GM
4409 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4410 Update template values to be closer to their typical values these days.
5b43da69 4411
a0db8d43
EZ
44122012-01-09 Eli Zaretskii <eliz@gnu.org>
4413
4414 * xdisp.c (rows_from_pos_range): Accept additional argument
4415 DISP_STRING, and accept any glyph in a row whose object is that
4416 string as eligible for mouse highlight. Fixes mouse highlight of
4417 display strings from overlays. (Bug#10464)
4418
9a0115ab 44192012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4420
b9110d6a 4421 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4422 * fileio.c (auto_saving_dir_umask): New static var.
4423 (Fmake_directory_internal): Use it.
4424 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4425 creating the directory. The old code temporarily assigns
4426 too-generous permissions to the directory.
4427 (do_auto_save_eh): Clear it.
b9110d6a 4428 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4429 that the var is always cleared.
4430
6c1bd3f3
EZ
44312012-01-07 Eli Zaretskii <eliz@gnu.org>
4432
4433 * search.c (scan_buffer): Pass character positions to
4434 know_region_cache, not byte positions. (Bug#6540)
4435
069d2b50
L
44362012-01-07 LynX <_LynX@bk.ru> (tiny change)
4437
4438 * w32.c (sys_rename): Report EXDEV when rename of a directory
4439 fails because the target is on another logical disk. (Bug#10284)
4440
75bf0d33
DB
44412012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4442
4443 * xterm.c (x_embed_request_focus): New function.
4444
4445 * xterm.h: Add prototype.
4446
4447 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4448
1c6e5a32
GM
44492012-01-05 Glenn Morris <rgm@gnu.org>
4450
4451 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4452
651e947e
EZ
44532012-01-01 Eli Zaretskii <eliz@gnu.org>
4454
4455 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4456 Load gnutls_transport_set_lowat only if GnuTLS version is below
4457 2.11.1.
4458 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4459 GnuTLS versions below 2.11.1.
4460
3778cdd8
AL
44612011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4462
4463 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4464 to the doc string advising against its use for altering the way
4465 windows are scrolled.
4466
0e5317f7
KH
44672011-12-28 Kenichi Handa <handa@m17n.org>
4468
4469 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4470 coding-system ASCII compatible only when it does not produce BOM
4471 on encoding (Bug#10383).
4472
93d5ca1f
JD
44732011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4474
4475 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4476 can scroll.
4477 (create_and_show_popup_menu): Always use menu_position_func for
4478 Gtk3 (Bug#10361).
4479
ca22b785
AS
44802011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4481
4482 * callint.c (Fcall_interactively): Don't truncate prompt string.
4483
d048e1e6
EZ
44842011-12-23 Eli Zaretskii <eliz@gnu.org>
4485
4486 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4487 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4488 resumed from there (after widening). (Bug#10360)
d048e1e6 4489
5ccaba1f
JD
44902011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4491
4492 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4493
204ee57f
JD
44942011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4495
b81d40f0
JB
4496 * nsterm.m (x_free_frame_resources):
4497 Release f->output_data.ns->miniimage.
204ee57f
JD
4498 (ns_index_color): Fix indentation. Do not retain
4499 color_table->colors[i].
4500
4501 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4502 before returning.
4503
4504 * nsfns.m (x_set_background_color): Assign return value from
4505 ns_index_color to face-background instead of NSColor*.
4506 (ns_implicitly_set_icon_type): Fix indentation.
4507 Change assignment in for loop to comparison.
4508
4509 * emacs.c (ns_pool): New variable.
4510 (main): Assign ns_pool.
4511 (Fkill_emacs): Call ns_release_autorelease_pool.
4512
4513 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4514 autorelease fdesc, release fdAttrs and tdict.
4515 (ns_get_covering_families): Release charset.
4516 (ns_findfonts): Release NSFontDescriptor created with new.
4517 (ns_uni_to_glyphs): Fix indentation.
4518 (setString): Release attrStr before assigning new value.
4519
c803b2b7
JD
45202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4521
678f4426
JD
4522 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4523 and NS_IMPL_COCOA.
4524 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4525 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4526
cd394be1 45272011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4528
5fecd5fc
JD
4529 * nsterm.m (ns_term_init): Subscribe for notifications
4530 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4531 to method trackingNotification in EmacsMenu.
4532
4533 * nsmenu.m (trackingMenu): New variable.
3771cb17 4534 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4535 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4536 from Aquamacs (Bug#7030).
678f4426
JD
4537
45382011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4539
c803b2b7
JD
4540 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4541 (symbol_to_nsstring): Fix indentation.
4542 (ns_symbol_to_pb): New function.
cae07000
SM
4543 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4544 (Fns_rotate_cut_buffers_internal): Remove.
4545 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4546 Fns_store_cut_buffer_internal.
4547 (ns_get_foreign_selection, Fx_own_selection_internal)
4548 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4549 (Fns_get_selection_internal, Fns_store_selection_internal):
4550 Use ns_symbol_to_pb and check if return value is nil.
4551 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4552 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4553 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4554 renamed to Sns_store_selection_internal.
4555 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4556 and remove this function.
4557 (ns_handle_selection_clear): Remove, never used.
4558 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4559 here.
4560
e1b01a3a
KB
45612011-12-17 Ken Brown <kbrown@cornell.edu>
4562
4563 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4564 GID is unknown (Bug#10257).
4565
2adb6e85
PE
45662011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4567
4568 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4569 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4570 which caused a build failure on GNU/Linux IA-64. This problem was
4571 introduced by my 2011-10-07 patch.
4572
d1d7b339
JL
45732011-12-15 Juri Linkov <juri@jurta.org>
4574
4575 * image.c (imagemagick_error): New function. (Bug#10112)
4576 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4577 Use `imagemagick_error' where ImageMagick functions return
4578 `MagickFalse'.
4579 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4580 proper order.
4581
100d5755
KH
45822011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4583
4584 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4585 fill background (Bug#8992).
4586
454592a6
MR
45872011-12-13 Martin Rudalics <rudalics@gmx.at>
4588
4589 * window.c (Vwindow_combination_resize)
4590 (Vwindow_combination_limit): Use t instead of non-nil in
4591 doc-strings.
61d4b438
MR
4592 (Vrecenter_redisplay): Add first sentence of doc-string on
4593 separate line.
53524d93 4594 (Frecenter): Fix doc-string typo.
454592a6 4595
3633e3aa
KH
45962011-12-11 Kenichi Handa <handa@m17n.org>
4597
4598 * coding.c (Funencodable_char_position): Pay attention to the
4599 buffer text relocation (Bug#9389).
4600
7b9d523a 46012011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4602
7b9d523a
JD
4603 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4604 gtk_init (Bug#10100).
4605
b73189c6
EZ
46062011-12-10 Eli Zaretskii <eliz@gnu.org>
4607
4608 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4609 IT->string is nil. (Bug#10263)
4610
f7dfe5d6
JD
46112011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4612
83faebb4
JD
4613 * nsterm.h (x_free_frame_resources): Declare.
4614
f7dfe5d6
JD
4615 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4616 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4617
4618 * nsterm.h (ns_get_defaults_value): Declare.
4619
4620 * nsterm.m (ns_default): Call ns_get_defaults_value.
4621
7cd4e72c
EZ
46222011-12-09 Eli Zaretskii <eliz@gnu.org>
4623
4624 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4625 (Bug#10170)
4626
b34d7317
YM
46272011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4628
4629 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4630 that where the value of an _OBJC_* symbol points to is in the .bss
4631 section (Bug#10240).
4632
76470ad1
KH
46332011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4634
4635 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4636 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4637
745fff94
KH
46382011-12-08 Kenichi Handa <handa@m17n.org>
4639
4640 * ftfont.c (get_adstyle_property): Fix previous change
4641 (Bug#10233).
4642
6e44397c
JB
46432011-12-07 Juanma Barranquero <lekktu@gmail.com>
4644
4645 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4646 dirs from the default value of EMACSLOADPATH (bug#10208).
4647
7efa6272
GM
46482011-12-07 Glenn Morris <rgm@gnu.org>
4649
4650 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4651 installation and source directories as well. (Bug#10208)
4652
f6fc4d87
CY
46532011-12-06 Chong Yidong <cyd@gnu.org>
4654
4655 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4656
2bf26180
GM
46572011-12-06 Glenn Morris <rgm@gnu.org>
4658
4659 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4660 as an error, not just -1. (Bug#10217)
4661
3a6ad4f0
CY
46622011-12-05 Chong Yidong <cyd@gnu.org>
4663
4664 * keyboard.c (process_special_events): New function.
4665 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4666
75a3b399
PE
46672011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4668
4669 * coding.c (encode_designation_at_bol): Don't use uninitialized
4670 local variable (Bug#9318).
4671
c3c9e25e
KH
46722011-12-05 Kenichi Handa <handa@m17n.org>
4673
4674 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4675 return Qnil (Bug#8046, Bug#10193).
4676
5eb05ea3
KH
46772011-12-05 Kenichi Handa <handa@m17n.org>
4678
4679 * coding.c (encode_designation_at_bol): New args charbuf_end and
4680 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4681 (coding_set_source): Return how many bytes coding->source was
4682 relocated.
4683 (coding_set_destination): Return how many bytes
4684 coding->destination was relocated.
4685 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4686 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4687
46882011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4689
4690 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4691 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4692 macro (Bug#9318).
4693
46942011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4695
4696 The following changes are to fix Bug#9318.
4697
a79703f5 4698 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4699 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4700 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4701 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4702
7dbda6df
JB
47032011-12-05 Juanma Barranquero <lekktu@gmail.com>
4704
4705 * lisp.h (process_quit_flag): Fix external declaration.
4706
6d5eb5b0
SM
47072011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4708
4709 Don't macro-inline non-performance-critical code.
4710 * eval.c (process_quit_flag): New function.
4711 * lisp.h (QUIT): Use it.
4712
a0c3fad0
JD
47132011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4714
4715 * nsfns.m (get_geometry_from_preferences): New function.
4716 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4717
6c07aac2
AS
47182011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4719
4720 * emacs.c (Qkill_emacs): Define.
4721 (syms_of_emacs): Initialize it.
4722 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4723 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4724 (quit_throw_to_read_char): Add parameter `from_signal'.
4725 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4726 * lisp.h (QUIT): Call Fkill_emacs if requested.
4727
c052ead4
JD
47282011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4729
4730 * widget.c (update_wm_hints): Return if wmshell is null.
4731 (widget_update_wm_size_hints): New function.
4732
4733 * widget.h (widget_update_wm_size_hints): Declare.
4734
4735 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4736 widget_update_wm_size_hints (Bug#10104).
4737
9e49252b
EZ
47382011-12-03 Eli Zaretskii <eliz@gnu.org>
4739
4740 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4741 before a newline, prepare the bidi iterator for consuming the
4742 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4743 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4744
02b16839
JL
47452011-12-02 Juri Linkov <juri@jurta.org>
4746
4747 * search.c (Fword_search_regexp): New Lisp function created from
4748 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4749 (Fword_search_backward, Fword_search_forward)
4750 (Fword_search_backward_lax, Fword_search_forward_lax):
4751 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4752 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4753
0068070e
SM
47542011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4755
4756 * fileio.c (Finsert_file_contents): Move after-change-function call
4757 to before the "handled:" label, since all "goto handled" appear in
4758 cases where the *-change-functions have already been properly called
4759 (bug#10117).
4760
3360a3fc
AS
47612011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4762
4763 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4764 waiting for input. (Bug#10169)
4765
73d6c093
EZ
47662011-11-30 Eli Zaretskii <eliz@gnu.org>
4767
4768 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4769 verifies glyph row's hash code--we have just reallocated the
4770 glyphs, so their contents can be complete garbage. (Bug#10164)
4771
febe6bea
JB
47722011-11-30 Juanma Barranquero <lekktu@gmail.com>
4773
4774 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4775
801a4313
EZ
47762011-11-30 Eli Zaretskii <eliz@gnu.org>
4777
4778 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4779 attributes are tested _before_ calling verify_row_hash, to protect
4780 against GCC re-ordering of the tests. (Bug#10164)
4781
2b56b87e
JD
47822011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4783
4784 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4785
4786 * xterm.c (handle_one_xevent): Only set async_visible and friends
4787 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4788 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4789 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4790
dbf31225
PE
47912011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4794 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4795 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4796 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4797 All uses changed to use GCPRO1 etc.
4798 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4799 Revert to old implementation (i.e., before 2011-03-11).
4800
1305621b
YM
48012011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4802
4803 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4804 of scroll runs so as to avoid assigning disabled bogus rows and
4805 unnecessary graphics copy operations.
4806
8c9afb46
EZ
48072011-11-27 Eli Zaretskii <eliz@gnu.org>
4808
4809 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4810 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4811 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4812 (malloc, free, realloc, calloc): Redirect to e_* only when
4813 compiling Emacs.
4814
4815 * lisp.h (GCTYPEBITS): Move before first use.
4816 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4817 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4818 this macro definition.
4819
4820 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4821 _MSC_VER.
4822
54e9e3bf
JD
48232011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4824
6d5eb5b0
SM
4825 * gtkutil.c (xg_create_frame_widgets):
4826 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4827 present with Gtk+ 2.0.
4828
83aca1cb
PE
48292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4830
4831 * fileio.c (Finsert_file_contents): Undo previous change; see
4832 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4833
5b76caa4
PE
48342011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 Rename locals to avoid shadowing.
4837 * fileio.c (Finsert_file_contents):
4838 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4839 * process.c (wait_reading_process_output):
4840 Rename inner 'proc' to 'p' to avoid shadowing.
4841 Indent for consistency with usual Emacs style.
4842
8c535114
EZ
48432011-11-25 Eli Zaretskii <eliz@gnu.org>
4844
4845 * xdisp.c (redisplay_window): If cursor row is not fully visible
4846 after recentering, and scroll-conservatively is set to a large
4847 number, scroll window by a few more lines to make the cursor fully
4848 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4849 (start_display): Don't move to the next line if the display should
4850 start at a newline that is part of a display vector or an overlay
4851 string. (Bug#10119)
8c535114 4852
fa4fdb5c
JL
48532011-11-24 Juri Linkov <juri@jurta.org>
4854
4855 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4856 after the `MagickPingImage' call. (Bug#10112)
4857
90ec88df
CY
48582011-11-23 Chong Yidong <cyd@gnu.org>
4859
4860 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4861
56e2e794
MR
48622011-11-23 Martin Rudalics <rudalics@gmx.at>
4863
4864 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4865 making another buffer current. (Bug#10114)
4866
b6e64c41
GM
48672011-11-23 Glenn Morris <rgm@gnu.org>
4868
4869 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4870
6b21de18
CY
48712011-11-23 Chong Yidong <cyd@gnu.org>
4872
4873 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4874 using it (Bug#5984).
4875
b12cd789
EZ
48762011-11-22 Eli Zaretskii <eliz@gnu.org>
4877
4878 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4879 and header-lines, as they don't have one computed for them.
4880 (Bug#10098)
4881
4882 * .gdbinit (prow): Make displayed values more self-explaining.
4883 Add row's hash code.
4884
261b6fd4
LMI
48852011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4886
4887 * process.c (wait_reading_process_output): Fix asynchrounous
4888 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4889 (wait_reading_process_output): Add comment and URL.
261b6fd4 4890
e7cfd277
JD
48912011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4892
4893 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4894
a9b9b7f5
CY
48952011-11-21 Chong Yidong <cyd@gnu.org>
4896
4897 * window.c (Fnext_window, Fprevious_window): Doc fix.
4898
b0d15b4f
SM
48992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4900
4901 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4902
fe7a3057
JB
49032011-11-20 Juanma Barranquero <lekktu@gmail.com>
4904
4905 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4906
d2999b1a
MR
49072011-11-20 Martin Rudalics <rudalics@gmx.at>
4908
4909 * window.c (Fset_window_combination_limit): Rename argument
4910 STATUS to LIMIT.
4911 (Vwindow_combination_limit): Remove "status" from doc-string.
4912
d5ff9cd0
AS
49132011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4914
4915 * m/ibms390.h: Remove.
4916 * m/ibms390x.h: Don't include "ibms390.h".
4917
a5bb9bd3
SM
49182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4919
4920 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4921 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4922
cd1181db
JB
49232011-11-20 Juanma Barranquero <lekktu@gmail.com>
4924
4925 * casetab.c (Fset_case_table):
4926 * charset.c (Fcharset_after): Fix typos.
4927
615a3b8d 49282011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4929
17e845af
PE
4930 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4931 Otherwise, valgrind does not work on some platforms.
4932 Problem reported by Andreas Schwab in
6a0bf43d
PE
4933 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4934 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4935 is set, removing the need for VIRT_ADDRESS_VARIES.
4936 (PURE_P): Use a more-efficient implementation that needs just one
4937 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4938 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4939 to 4 (xorl, subq, cmpq, setbe).
4940 * alloc.c (pure): Always extern now, since that's the
4941 VIRT_ADDR_VARIES behavior.
4942 (PURE_POINTER_P): Use a single comparison, not two, for
4943 consistency with the new puresize.h.
4944 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4945 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4946 Remove VIRT_ADDR_VARIES no longer needed.
4947
f8fe6f96
EZ
49482011-11-19 Eli Zaretskii <eliz@gnu.org>
4949
4950 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4951 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4952 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4953 behave as if the cursor position were at the window margin.
4954
4955 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4956 and the cursor position is out of bounds, behave as if the cursor
4957 position were at the window margin. (Bug#10075)
4958
df05a53c
CY
49592011-11-18 Chong Yidong <cyd@gnu.org>
4960
4961 * window.c (Fwindow_combination_limit): Make first argument
4962 non-optional, since it is meaningless for live windows like the
4963 selected window.
61ccba97 4964
2071918e
DA
49652011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4966
4967 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4968
b50a28de
SM
49692011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4970
4971 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4972 (graft_intervals_into_buffer): Simplify.
4973
015137db
EZ
49742011-11-18 Eli Zaretskii <eliz@gnu.org>
4975
4976 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4977 hash values of the two rows.
4978 (copy_row_except_pointers): Preserve the used[] arrays and the
4979 hash values of the two rows. (Bug#10035)
68c95424 4980 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4981
4982 * xdisp.c (row_hash): New function, body extracted from
4983 compute_line_metrics.
4984 (compute_line_metrics): Call row_hash, instead of computing the
4985 hash code inline.
4986
4987 * dispnew.c (verify_row_hash): Call row_hash for computing the
4988 hash code of a row, instead of duplicating code from xdisp.c.
4989
4990 * dispextern.h (row_hash): Add prototype.
4991
a2addb04
TH
49922011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4993
4994 * frame.c (delete_frame): Don't delete the terminal when the last
4995 X frame is closed if emacs is built with GTK toolkit.
4996
df85d315
JB
49972011-11-17 Juanma Barranquero <lekktu@gmail.com>
4998
4999 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5000
a0c2d0ae
MR
50012011-11-17 Martin Rudalics <rudalics@gmx.at>
5002
5003 * window.c (Vwindow_splits): Rename to
5004 Vwindow_combination_resize. Suggested by Juri Linkov.
5005 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5006 of Vwindow_splits.
5007
58179cce
JB
50082011-11-16 Juanma Barranquero <lekktu@gmail.com>
5009
7877f373
JB
5010 * nsfns.m (Fns_font_name):
5011 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5012
b6f67890
MR
50132011-11-16 Martin Rudalics <rudalics@gmx.at>
5014
5015 * window.h (window): Rename slot "nest" to "combination_limit".
5016 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5017 (Fset_window_nest): Rename to Fset_window_combination_limit.
5018 (Vwindow_nest): Rename to Vwindow_combination_limit.
5019 (recombine_windows, make_parent_window, make_window)
5020 (Fsplit_window_internal, saved_window)
5021 (Fset_window_configuration, save_window_save): Rename all
5022 occurrences of window_nest to window_combination_limit.
5023
c7015153
JB
50242011-11-15 Juanma Barranquero <lekktu@gmail.com>
5025
5026 * image.c (imagemagick_load_image): Fix typo.
5027
322ad6ec
EZ
50282011-11-14 Eli Zaretskii <eliz@gnu.org>
5029
5030 * xdisp.c (display_line): Move the call to
5031 highlight_trailing_whitespace before the call to
5032 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5033 faces of all the glyphs to compute ROW's hash value.
5034 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5035
f067b8ec
JB
50362011-11-14 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5039 just return (bug#10044).
5040
1e5b2111
EZ
50412011-11-12 Eli Zaretskii <eliz@gnu.org>
5042
7ef3cbd5
EZ
5043 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5044 with user-defined heap size. Bump the default size of the temacs
5045 heap to 27MB, to avoid memory warning when running temacs.
5046 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5047
1e5b2111
EZ
5048 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5049 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5050 (verify_row_hash) [XASSERTS]: New function.
5051 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5052 that the hash value of glyph rows is correct.
1e5b2111 5053
89d61221
MR
50542011-11-12 Martin Rudalics <rudalics@gmx.at>
5055
5056 * window.h (window): Remove splits slot.
5057 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5058 (Fdelete_other_windows_internal, make_parent_window)
5059 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5060 (Fset_window_configuration, save_window_save): Don't deal with
5061 split status of windows.
5062 (saved_window): Remove splits slot.
5063 (Vwindow_splits): Rewrite doc-string.
5064
97f18cc8
JD
50652011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5066
5067 * xfns.c (unwind_create_frame):
5068 * nsfns.m (unwind_create_frame):
5069 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5070 Vframe_list (Bug#9999).
5071
22a648b4
DA
50722011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5073
0b381c7e 5074 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5075
659afede
KH
50762011-11-11 Kenichi Handa <handa@m17n.org>
5077
5078 * callproc.c (Fcall_process): Set the member dst_multibyte of
5079 process_coding.
5080
9ac0394b
KH
50812011-11-11 Johan Bockgård <bojohan@gnu.org>
5082
5083 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5084 avoid a crash (bug#9496).
5085
2fbdc249
CY
50862011-11-09 Chong Yidong <cyd@gnu.org>
5087
5088 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5089 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5090
ac6b1f81
PE
50912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5092
5093 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5094
09db192c
PE
50952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 Avoid some portability problems by eschewing 'extern inline' functions.
5098 The trivial performance wins aren't worth the portability hassles; see
5099 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5100 et seq.
5101 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5102 (window_box_width, window_box_left, window_box_left_offset)
5103 (window_box_right, window_box_right_offset): Undo previous change,
5104 by removing the "extern"s.
5105 * intervals.c (adjust_intervals_for_insertion)
5106 (adjust_intervals_for_deletion): Undo previous change,
5107 making these static again.
5108 (offset_intervals, temp_set_point_both, temp_set_point)
5109 (copy_intervals_to_string): No longer inline.
5110 * xdisp.c (window_text_bottom_y, window_box_width)
5111 (window_box_height, window_box_left_offset)
5112 (window_box_right_offset, window_box_left, window_box_right)
5113 (window_box): No longer inline.
5114
105216ed
CY
51152011-11-08 Chong Yidong <cyd@gnu.org>
5116
5117 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5118 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5119 Signal an error if not a live window.
105216ed
CY
5120 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5121 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5122
ae9e237f
JB
51232011-11-07 Juanma Barranquero <lekktu@gmail.com>
5124
5125 * lisp.h (syms_of_abbrev): Remove declaration.
5126 Reported by CHENG Gao <chenggao@royau.me>.
5127
c7aa8333
EZ
51282011-11-07 Eli Zaretskii <eliz@gnu.org>
5129
5130 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5131 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5132 of temacs in GUI mode.
5133
be7f5545
MR
51342011-11-07 Martin Rudalics <rudalics@gmx.at>
5135
5136 * window.h: Declare delete_all_child_windows instead of
5137 delete_all_subwindows.
5138 * window.c (Fwindow_nest, Fset_window_nest)
5139 (Fset_window_new_total, Fset_window_new_normal)
5140 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5141 (delete_all_subwindows): Rename to delete_all_child_windows.
5142 (Fdelete_other_windows_internal, Fset_window_configuration):
5143 Call delete_all_child_windows instead of delete_all_subwindows.
5144 * frame.c (delete_frame): Call delete_all_child_windows instead
5145 of delete_all_subwindows.
5146
ca78dc43
PE
51472011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5148
5149 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5150 This is also needed for porting to any host where GC_MARK_STACK is
5151 not GC_MAKE_GCPROS_NOOPS.
5152 (which_symbols): Use it.
5153
a0241d01
KH
51542011-11-07 Kenichi Handa <handa@m17n.org>
5155
5156 * coding.c (coding_set_destination): Check coding->src_pos only
5157 when coding->src_object is a buffer (bug#9910).
5158
5159 * process.c (send_process): Set the member src_multibyte of coding
5160 to 0 (bug#9911) when sending a unibyte text.
5161
5162 * callproc.c (Fcall_process): Set the member src_multibyte of
5163 process_coding to 0 (bug#9912).
5164
a64bfdfa 51652011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5166
5167 * xmenu.c (cleanup_widget_value_tree): New function.
5168 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5169 calling free_menubar_widget_value_tree directly (Bug#9830).
5170
cb41b32a
PE
51712011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 Fix some portability problems with 'inline'.
5174 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5175 (window_box_width, window_box_left, window_box_left_offset)
5176 (window_box_right, window_box_right_offset): Declare extern.
5177 Otherwise, these inline functions do not conform to C99 and
5178 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5179 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5180 * intervals.c (adjust_intervals_for_insertion)
5181 (adjust_intervals_for_deletion): Now extern, because otherwise the
5182 extern inline functions 'offset_intervals' couldn't refer to it.
5183 (static_offset_intervals): Remove.
5184 (offset_intervals): Rewrite using the old contents of
5185 static_offset_intervals. The old version didn't conform to C99
5186 because an extern inline function contained a reference to an
5187 identifier with static linkage.
5188
b7041366
AS
51892011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5190
5191 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5192 GC.
5193
88a37c4d
EZ
51942011-11-06 Eli Zaretskii <eliz@gnu.org>
5195
5196 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5197 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5198 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5199 return Qleft_to_right.
5200
49745b39
CY
52012011-11-06 Chong Yidong <cyd@gnu.org>
5202
5203 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5204 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5205 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5206 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5207 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5208 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5209 (Fwindow_vscroll): Doc fix.
5210 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5211 argument, since it makes no sense to pass a live window and for
5212 consistency with window-child.
5213
1f05cd82
CS
52142011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5215
5216 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5217 support MSVC.
5218
22610910
JR
52192011-11-05 Jason Rumney <jasonr@gnu.org>
5220
5221 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5222 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5223 fonts (Bug#6029).
5224 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5225 bitwise arithmetic preventing use of unicode-sip and non-truetype
5226 opentype fonts.
5227
a06776b2
EZ
52282011-11-05 Eli Zaretskii <eliz@gnu.org>
5229
3ad924ba
EZ
5230 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5231 "emacs"-only part.
5232
a06776b2
EZ
5233 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5234 initialization code to keep similarity to xfns.c after changes
5235 from 2011-11-05.
5236
c9e7db78
JD
52372011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5238
a97f8f3f
JD
5239 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5240 (unwind_create_frame): New function (Bug#9943).
5241 (Fx_create_frame): Restructure code to be more similar to the one in
5242 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5243 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5244 Move terminal->reference_count++ just before making the frame official
5245 (Bug#9943).
5246
5247 * nsterm.m (x_free_frame_resources): New function.
5248 (x_destroy_window): Move code to x_free_frame_resources.
5249
c9e7db78 5250 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5251 (Fx_create_frame, x_create_tip_frame):
5252 Move terminal->reference_count++ just before making the frame
75f1671a 5253 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5254 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5255
a6fc3b5c
EZ
52562011-11-05 Eli Zaretskii <eliz@gnu.org>
5257
5258 Support MSVC build with newer versions of Visual Studio.
5259 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5260 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5261 nt/gmake.defs.
5262
5263 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5264 which are not supported by MSVC.
5265 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5266 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5267 bitfields.
5268 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5269 types in bitfields.
5270 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5271
5272 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5273
58179cce 52742011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5275
5276 Support MSVC build with newer versions of Visual Studio.
5277 * w32.c: Don't include w32api.h for MSVC.
5278 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5279
5280 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5281 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5282 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5283 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5284 e_* cousins.
5285 (alloca) [_MSC_VER]: Define to _alloca.
5286
5287 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5288
5289 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5290
a58c13ed
EZ
52912011-11-04 Eli Zaretskii <eliz@gnu.org>
5292
5293 * xdisp.c (note_mouse_highlight): If either of
5294 previous/next-single-property-change returns nil, treat that as
5295 the beginning or the end of the buffer. (Bug#9955)
5296
fe0b6370
JD
52972011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5298
a58c13ed 5299 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5300 label is not null (Bug#9951).
5301 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5302 may be NULL.
5303
89bd5ee1
EZ
53042011-11-04 Eli Zaretskii <eliz@gnu.org>
5305
5306 * window.c (Fwindow_body_size): Mention in the doc string that the
5307 return value is in frame's canonical units. (Bug#9949)
5308
84c3edb9
EZ
53092011-11-03 Eli Zaretskii <eliz@gnu.org>
5310
4e2fb5c7
EZ
5311 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5312
84c3edb9 5313 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5314 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5315 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5316
bc17a887
EZ
53172011-11-01 Eli Zaretskii <eliz@gnu.org>
5318
5319 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5320 Don't stop backward scan on the continuation glyph, even though
5321 its CHARPOS is positive.
6d5eb5b0
SM
5322 (mouse_face_from_buffer_pos, note_mouse_highlight):
5323 Rename cover_string to disp_string.
bc17a887 5324
4ee88440
MR
53252011-11-01 Martin Rudalics <rudalics@gmx.at>
5326
5327 * window.c (temp_output_buffer_show): Don't use
5328 Vtemp_buffer_show_specifiers.
5329 (Vtemp_buffer_show_specifiers): Remove unused variable.
5330
c2ff3c02
EZ
53312011-10-30 Eli Zaretskii <eliz@gnu.org>
5332
5333 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5334 past the beginning of the current glyph matrix.
5335
58179cce 53362011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5337
5338 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5339 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5340 HAVE_GTK3 (Bug#9869).
b77a6a7f 5341
3b574623
JD
5342 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5343 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5344
b77a6a7f
JD
5345 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5346
5347 * xterm.c: Declare x_handle_net_wm_state to return int.
5348 (handle_one_xevent): Check if we are iconified but don't have
5349 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5350 (get_current_wm_state): Return non-zero if not hidden,
5351 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5352 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5353 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5354 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5355
196e41e4
PE
53562011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5357
5358 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5359 so that this new function doesn't get optimized away by a
5360 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5361
021f2e1a
AS
53622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5363
5364 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5365
8b058d44
EZ
53662011-10-29 Eli Zaretskii <eliz@gnu.org>
5367
5368 Fix the `xbytecode' command.
5369 * .gdbinit (xprintbytestr): New command.
b50a28de 5370 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5371 (xbytecode): Print the byte-code string as well.
5372
4452fb80
EZ
53732011-10-29 Kim Storm <storm@cua.dk>
5374
8b058d44
EZ
5375 * alloc.c (which_symbols): New function.
5376
21b72067
AS
53772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5378
5379 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5380 line. (Bug#9903)
5381
83ed7b5c
GM
53822011-10-29 Glenn Morris <rgm@gnu.org>
5383
5384 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5385 Not clear what it was for, and it causes various bugs. (Bug#9839)
5386
5a7a728b
EZ
53872011-10-28 Eli Zaretskii <eliz@gnu.org>
5388
5389 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5390 possible random value that matches one of those tested as
5391 condition to clear the mouse face.
5392
d3d0842f
CY
53932011-10-28 Chong Yidong <cyd@gnu.org>
5394
5395 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5396
31b39d13
DN
53972011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5398
5399 * window.c (make_window): Initialize phys_cursor_on_p.
5400
9aba6043
SM
54012011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5402
5403 * lisp.h (struct Lisp_Symbol): Update comments.
5404
c20992f4
JB
54052011-10-28 Juanma Barranquero <lekktu@gmail.com>
5406
5407 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5408
db4f02f2
EZ
54092011-10-28 Eli Zaretskii <eliz@gnu.org>
5410
5411 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5412 <oslsachem@gmail.com> for helping to debug this.
5413
5414 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5415 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5416 (g_b_init_get_glyph_outline_w): New static variables.
5417 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5418 (GetGlyphOutlineW_Proc): New typedefs.
5419 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5420 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5421 New functions.
5422 (w32font_open_internal, compute_metrics):
5423 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5424 instead of calling the "wide" APIs directly.
5425
5426 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5427
5428 * w32.h (syms_of_w32font): Add prototype.
5429
87e68db4
JB
54302011-10-27 Juanma Barranquero <lekktu@gmail.com>
5431
5432 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5433 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5434 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5435 (Fmove_to_window_line): Doc fix.
5436
435c1d67
CY
54372011-10-27 Chong Yidong <cyd@gnu.org>
5438
5439 * process.c (make_process): Set gnutls_state to NULL.
5440
5441 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5442 non-NULL, regardless of GNUTLS_INITSTAGE.
5443 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5444 an error. Set process slots as soon as we allocate them.
5445
5446 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5447
9c6c6f49
CY
54482011-10-27 Chong Yidong <cyd@gnu.org>
5449
9aba6043
SM
5450 * gnutls.c (emacs_gnutls_deinit): New function.
5451 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5452 (Fgnutls_deinit, Fgnutls_boot): Use it.
5453
5454 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5455 (deactivate_process): Call emacs_gnutls_deinit.
5456
657d08d3
JB
54572011-10-27 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * image.c (x_create_x_image_and_pixmap):
5460 * w32.c (sys_rename, w32_delayed_load):
5461 * w32font.c (fill_in_logfont):
5462 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5463
5430d399
JB
54642011-10-26 Juanma Barranquero <lekktu@gmail.com>
5465
5466 * w32fns.c (w32_default_color_map): New function,
5467 extracted from Fw32_default_color_map.
a7ef684b 5468 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5469
fe0055fa
PE
54702011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5473
e6346438
SM
54742011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5475
5476 * keyboard.c (test_undefined): New function (bug#9751).
5477 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5478
e112cc37
ET
54792011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5480
5481 * sysdep.c (init_sys_modes): Fix the check for the controlling
5482 terminal (Bug#6649).
5483
7b5d6677
EZ
54842011-10-20 Eli Zaretskii <eliz@gnu.org>
5485
5486 * dispextern.h (struct bidi_it): New member next_en_type.
5487
5488 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5489 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5490 current character, check also for next_en_type being WEAK_EN.
5491 (bidi_resolve_weak): Don't enter the expensive loop if the current
5492 position is before next_en_pos. Record the bidi type of the first
5493 non-ET, non-BN character we find, in addition to its position.
5494 (bidi_level_of_next_char): Invalidate next_en_type when
5495 next_en_pos is over-stepped.
5496
7da0b018
PE
54972011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5498
5499 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5500 * editfns.c: Rewrite current-time-zone so that it invokes
5501 the equivalent of (format-time-string "%Z") to get the time zone name.
5502 This fixes a bug when the time zone name contains characters that
5503 need converting from the system time locale to Emacs internal format.
5504 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5505 that patch fixed format-time-string to do the conversion, but
5506 I forgot to fix current-time-zone.
5507 (format_time_string): New function, containing most of
5508 what Fformat_time_string used to contain.
5509 (Fformat_time_string): Rewrite in terms of format_time_string.
5510 This doesn't change this function's behavior.
5511 (current-time-zone): Rewrite to use format_time_string.
5512 This fixes the bug reported by Michael Schierl in
5513 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5514 Jason Rumney's 2007-06-07 change worked around this bug, but
5515 didn't fix it.
5516 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5517
8547b010
EZ
55182011-10-19 Eli Zaretskii <eliz@gnu.org>
5519
5520 * xdisp.c (start_display): If the character at POS is displayed
5521 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5522 (try_window_reusing_current_matrix): If a line ends in a display
5523 vector or the next line starts in a display vector, continue
5524 redrawing the window even though the character position of
5525 start_row was reached.
8547b010
EZ
5526 (Bug#9771, part 2)
5527
4e948d15
CY
55282011-10-18 Chong Yidong <cyd@gnu.org>
5529
5530 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5531 with nobreak-char-display too.
5532
4787455f
EZ
55332011-10-18 Eli Zaretskii <eliz@gnu.org>
5534
5535 Fix part 3 of bug#9771.
5536 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5537 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5538 non-neutral characters if the current character is a paragraph
5539 separator (a.k.a. Newline). This avoids running the same
5540 expensive loop twice, once when we consume the preceding newline
5541 and the other time when the line actually needs to be displayed.
5542 Avoid the loop when we see neutrals on the base embedding level
5543 following a character whose directionality is the same as the
5544 paragraph's. This avoids running the expensive loop when a line
5545 ends in a long sequence of neutrals, like control characters.
5546 Add assertion against STRONG_AL type. Slightly rearrange code
5547 that determines the type of a neutral given the first non-neutral
5548 that follows it.
5549 (bidi_level_of_next_char): Set next_en_pos to zero when
5550 invalidating its info.
5551
2c91f553
EZ
55522011-10-17 Eli Zaretskii <eliz@gnu.org>
5553
5554 * xdisp.c (push_display_prop): Determine whether to record string
5555 or buffer position by IT->string, not by IT->method. Allow
5556 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5557 (move_it_vertically_backward): Don't look for character position
5558 immediately after the newline when in a continuation line.
5559 (Bug#9771, part 1)
2c91f553 5560
c7b08b0d
MR
55612011-10-15 Martin Rudalics <rudalics@gmx.at>
5562
5563 * window.c (coordinates_in_window): Rewrite and delabelize
5564 vertical border check. (Bug#5357) (Bug#9618)
5565
6b02f655
SM
55662011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5567
5568 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5569 errors in XSetWindowBorder (bug#9310).
5570
81d40c92
DA
55712011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5572
5573 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5574 avoid crash when xmalloc overrun checking is enabled.
5575
d4172c3b
EZ
55762011-10-13 Eli Zaretskii <eliz@gnu.org>
5577
5578 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5579 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5580 cursor motion with <left> and <right> arrow keys.
5581
5582 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5583 some callers set that themselves.
5584
b00eea75
EZ
55852011-10-12 Eli Zaretskii <eliz@gnu.org>
5586
5587 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5588 display string and the previous row comes from the same string and
5589 is empty. (Bug#9739) (Bug#9738)
5590
8fe012c4
SM
55912011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5592
5593 * doc.c (get_doc_string): Encode file name (bug#9735).
5594
0074aef2
EZ
55952011-10-12 Eli Zaretskii <eliz@gnu.org>
5596
79beb178
EZ
5597 * bidi.c (bidi_level_of_next_char):
5598 * xdisp.c (get_visually_first_element): Remove old incorrect
5599 comments regarding the Unicode Line Separator character.
5600
0074aef2
EZ
5601 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5602
6e4b3fbe
DA
56032011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5604
5605 * alloc.c (Fgc_status): Do not access beyond zombies array
5606 boundary if nzombies > MAX_ZOMBIES.
5607 * alloc.c (dump_zombies): Add missing format specifier.
5608
0324f3af
PE
56092011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5610
b5525cac
PE
5611 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5612 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5613
0324f3af
PE
5614 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5615 Some packages use them to denote characters with modifiers.
5616
e9b5f888
AS
56172011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5618
5619 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5620 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5621 matching a pp-number. Rename parameter var to var1.
5622
127827c0
SM
56232011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5624
5625 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5626
c8fd3bd0
GM
56272011-10-08 Glenn Morris <rgm@gnu.org>
5628
5629 * callint.c (Fcall_interactively): Give a more explicit error for the
5630 'c' case with a non-character input. (Bug#8479)
5631
352ec8ff
EZ
56322011-10-08 Eli Zaretskii <eliz@gnu.org>
5633
03669ccb
EZ
5634 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5635 lines.
7061c986
EZ
5636 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5637 lines that are hscrolled on the left.
03669ccb 5638
352ec8ff
EZ
5639 * dispnew.c (buffer_posn_from_coords): Account for a possible
5640 presence of header-line. (Bug#4426)
5641
a66cfb1c
SM
56422011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5643
6b02f655
SM
5644 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5645 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5646
7c5ee88e
PE
56472011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5648
5649 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5650 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5651 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5652 this makes Emacs dump core during garbage collection on rare
5653 occasions. sizeof is obviously inferior to offsetof here, so
5654 stick with offsetof.
5655 (GC_POINTER_ALIGNMENT): New macro.
5656 (mark_memory): Omit 3rd (offset) arg; caller changed.
5657 Don't assume EMACS_INT alignment is the same as pointer alignment.
5658
df1bbe5b
SM
56592011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5660
5661 * keyboard.c (read_key_sequence_remapped): New var.
5662 (read_key_sequence): Compute remapping in the right buffer.
5663 (command_loop_1): Use read_key_sequence's remapping directly.
5664
51553db6
SM
56652011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5666
32c1fffd
SM
5667 * dired.c (file_name_completion): Don't expand file name.
5668 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5669 before checking file name handler.
5670
51553db6
SM
5671 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5672 they've been requested explicitly (bug#9591).
5673
b6bd1599 56742011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5675
5676 * keymap.c (Fsingle_key_description): Use make_specified_string
5677 instead of build_string to build string from push_key_description.
5678 (Bug#5193)
5679
f701dc2a
PE
56802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5681
4222c55d
PE
5682 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5683 This fixes a Y2038 bug on 64-bit hosts.
5684 * buffer.c (reset_buffer):
5685 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5686 (Fclear_buffer_auto_save_failure):
5687 Use 0, not -1, to represent an unset failure time, since time_t
5688 might not be signed.
5689
f701dc2a
PE
5690 Remove dependency on glibc malloc internals.
5691 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5692 Move back here from lisp.h, but with their new implementations.
5693 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5694 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5695 * charset.c (charset_table_init): New static var.
5696 (syms_of_charset): Use it instead of xmalloc. This removes a
5697 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5698 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5699 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5700 Move back to alloc.c.
5701 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5702 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5703
9ceebf39
JD
57042011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5705
5706 * nsterm.m (windowDidResize): Call x_set_window_size only when
5707 ns_in_resize is true. Otherwise set pixelwidth/height and
5708 call change_frame_size (Bug#9628).
5709
cb993c58
PE
57102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5711
3930c88b
PE
5712 Port --enable-checking=all to Fedora 14 x86-64.
5713 * charset.c (syms_of_charset): Also account for glibc malloc's
5714 internal overhead when calculating the initial malloc maximum.
5715
cb993c58
PE
5716 Port --enable-checking=all to Fedora 14 x86.
5717 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5718 Move to lisp.h.
5719 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5720 (overrun_check_realloc, overrun_check_free):
5721 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5722 That way, xmalloc returns a properly-aligned pointer even if
5723 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5724 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5725 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5726 into account when calculating the initial malloc maximum.
5727 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5728 Move here from alloc.c, so that charset.c can use it too.
5729 Properly align; the old code wasn't right for common 32-bit hosts
5730 when configured with --enable-checking=all.
5731 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5732 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5733
31bed486
EZ
57342011-09-29 Eli Zaretskii <eliz@gnu.org>
5735
04c70788 5736 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5737 use EDOM.
5738
fbcaa2f3
EZ
57392011-09-28 Eli Zaretskii <eliz@gnu.org>
5740
5741 * xdisp.c (compute_display_string_end): If there's no display
5742 string at CHARPOS, return -1.
5743
5744 * bidi.c (bidi_fetch_char): When compute_display_string_end
5745 returns a negative value, treat the character as a normal
5746 character not covered by a display string. (Bug#9624)
5747
a239d4e9
JB
57482011-09-28 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * lread.c (Fread_from_string): Fix typo in docstring.
5751
88652fd5
EZ
57522011-09-27 Eli Zaretskii <eliz@gnu.org>
5753
5754 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5755 newline, reseat the iterator instead of bidi-iterating there one
5756 character at a time. (Bug#9610)
32c1fffd
SM
5757 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5758 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5759
ed497dd4
AS
57602011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5761
5762 * lread.c (readevalloop): Use correct code for NBSP.
5763 (read1): Likewise. (Bug#9608)
5764
b2bf61aa
MA
57652011-09-25 Michael Albinus <michael.albinus@gmx.de>
5766
5767 * dbusbind.c (Fdbus_register_signal): When service is not
5768 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5769
32bbb17c
GM
57702011-09-25 Glenn Morris <rgm@gnu.org>
5771
5772 * buffer.c (truncate-lines): Doc fix.
5773
94e0933e
CY
57742011-09-24 Chong Yidong <cyd@stupidchicken.com>
5775
5776 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5777 (Fset_window_next_buffers): Doc fix.
5778
cddde921
GM
57792011-09-24 Glenn Morris <rgm@gnu.org>
5780
5781 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5782
1260aef1
PE
57832011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5784
25b4bfa0
PE
5785 Fix minor problems found by static checking.
5786 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5787 * indent.c (Fvertical_motion): Fix == vs = typo.
5788
e3cbd34b
EZ
57892011-09-24 Eli Zaretskii <eliz@gnu.org>
5790
a66cfb1c
SM
5791 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5792 Default value is now t. Doc fix.
6bf7006f 5793
e3cbd34b 5794 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5795 logic when moving up, not only when moving down. Fix the
e3cbd34b 5796 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5797 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5798
5799 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5800 CHARPOS is covered by a display string which includes newlines.
5801 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5802 is covered by a display string with embedded newlines.
5803
a3de0cbd
MA
58042011-09-24 Michael Albinus <michael.albinus@gmx.de>
5805
5806 * dbusbind.c (Fdbus_register_signal): Add match rule to
5807 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5808 (Fdbus_register_method, Vdbus_registered_objects_table):
5809 Fix docstring.
a3de0cbd 5810
b260039d
JM
58112011-09-24 Jim Meyering <meyering@redhat.com>
5812
32c1fffd 5813 do not ignore write error for any output size
b260039d
JM
5814 The previous change was incomplete.
5815 While it makes emacs --batch detect the vast majority of stdout
5816 write failures, errors were still ignored whenever the output size is
5817 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5818 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5819 && echo FAIL: ignored write error
5820 FAIL: ignored write error
5821 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5822 && echo FAIL: ignored write error
5823 FAIL: ignored write error
5824 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5825
8eca8a7c
AS
58262011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5827
5828 * emacs.c (Fkill_emacs): In noninteractive mode exit
5829 non-successfully if a write error occurred on stdout. (Bug#9574)
5830
3341db62
EZ
58312011-09-21 Eli Zaretskii <eliz@gnu.org>
5832
5833 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5834 the xassert test.
5835
5836 * dispextern.h (struct it): Update the comment documenting what
5837 can it->OBJECT be.
5838
8c203dbf
EZ
58392011-09-20 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5842 a display string, extend search for cursor position to end of row.
5843 (find_row_edges): If the row ends in a newline from a display
5844 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5845 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5846 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5847 non-empty line. Fixes confusing cursor motion with arrow keys at
5848 the beginning of a line that starts with whitespace.
8c203dbf 5849
a4824228
LMI
58502011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5851
5852 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5853 (bug#9493).
5854
33ed493b
CY
58552011-09-18 Chong Yidong <cyd@stupidchicken.com>
5856
5857 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5858 boolean (Bug#9154).
5859
56cd55c8
EZ
58602011-09-18 Eli Zaretskii <eliz@gnu.org>
5861
5862 * xdisp.c (display_line): Record maximum and minimum buffer
5863 positions even if no glyphs were produced (e.g., by a zero-width
5864 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5865 buffer positions that will be removed from the glyph row because
5866 they don't fit.
c02dcedf
EZ
5867 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5868 column is beyond frame width: don't subtract 1 "pixel" when
5869 computing width of the stretch.
3e62b7e0
EZ
5870 (reseat_at_next_visible_line_start): Undo the change made on
5871 2011-09-17 that saved paragraph information and restored it after
5872 the call to `reseat'. (Bug#9545)
56cd55c8 5873
5ed99d36 58742011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5875
5876 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5877 and turn window cursor on if cleared (Bug#9415).
5878
5ed99d36 58792011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5880
5881 * search.c (boyer_moore): Take unibyte characters from pattern
5882 literally. (Bug#9458)
5883
9bade7b2
EZ
58842011-09-18 Eli Zaretskii <eliz@gnu.org>
5885
5886 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5887
e5e9d610
PE
58882011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5889
87e4427a
PE
5890 Fix minor problem found by static checking.
5891 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5892 initialized, to pacify gcc -Wuninitialized.
5893
e5e9d610
PE
5894 * fileio.c: Report proper errno when syscall falls.
5895 (Finsert_file_contents): Save and restore errno,
5896 so that report_file_error outputs the correct diagnostic.
5897 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5898
a1674f0b
EZ
58992011-09-18 Eli Zaretskii <eliz@gnu.org>
5900
5901 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5902
fbfb6dd4
EZ
59032011-09-17 Eli Zaretskii <eliz@gnu.org>
5904
5905 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5906 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5907
bb187662
EZ
59082011-09-17 Eli Zaretskii <eliz@gnu.org>
5909
1137e8b8 5910 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5911 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5912
5913 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5914 (bidi_find_paragraph_start): Search back for paragraph beginning
5915 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5916 (bidi_move_to_visually_next): Only trigger paragraph-related
5917 computations when the last character is a newline or at EOB, not
5918 just any NEUTRAL_B. (Bug#9470)
5919
bb187662
EZ
5920 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5921 truncated lines if point is covered by a display string. (Bug#9524)
5922
2e621251
PE
59232011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5926 (cons_to_x_long): New function.
5927 (lisp_data_to_selection_data): Use it. Correct the test for
5928 short-versus-long data; it was negated. Break out of vector
5929 loop, for efficiency, when a long datum is discovered.
5930
91a15bc6
SM
59312011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5932
5933 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5934
b41c3a35
EZ
59352011-09-16 Eli Zaretskii <eliz@gnu.org>
5936
5937 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5938 GCC PR/17406) by declaring this function with external scope.
5939
7812ba2d
PE
59402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5941
5942 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5943 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5944
cf7edc2a
AS
59452011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5946
5947 * editfns.c (Fformat): Correctly handle text properties on "%%".
5948
bd01620e
EZ
59492011-09-15 Eli Zaretskii <eliz@gnu.org>
5950
5951 * xterm.c (x_draw_composite_glyph_string_foreground):
5952 * w32term.c (x_draw_composite_glyph_string_foreground):
5953 * term.c (encode_terminal_code):
5954 * composite.c (composition_update_it, get_composition_id):
5955 * xdisp.c (get_next_display_element)
5956 (fill_composite_glyph_string): Add comments about special meaning
5957 of TAB characters in a composition.
5958
a02719a3
PE
59592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5962 This occurs when processing a multibyte format.
5963 Problem reported by Wolfgang Jenker.
a02719a3 5964
72589a3c
JB
59652011-09-15 Johan Bockgård <bojohan@gnu.org>
5966
5967 * xdisp.c (try_cursor_movement): Only check for exact match if
5968 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5969
1c14176c
PE
59702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5971
5972 Remove unused external symbols.
5973 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5974 * xdisp.c (calc_pixel_width_or_height): Now static.
5975 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5976 * indent.c (check_display_width):
5977 * w32term.c: Fix comment to match code.
5978 * xterm.c, xterm.h (x_catching_errors): Remove.
5979
d2eea5b5
PE
59802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 * xselect.c: Use signed conversions more consistently (Bug#9498).
5983 (selection_data_to_lisp_data): Assume incoming selection data are
5984 signed integers, not unsigned. This is to be consistent with
5985 outgoing selection data, which was modified to use signed integers
5986 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5987 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5988 expects long, not unsigned long.
5989
46888499
EZ
59902011-09-14 Eli Zaretskii <eliz@gnu.org>
5991
5992 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5993 computation of loop end. Reported by Johan Bockgård
5994 <bojohan@gnu.org>.
5995
ef8ef9fb
CY
59962011-09-13 Chong Yidong <cyd@stupidchicken.com>
5997
5998 * frame.c (Fother_visible_frames_p): Function deleted.
5999
fa819fed
EZ
60002011-09-12 Eli Zaretskii <eliz@gnu.org>
6001
6002 * indent.c (compute_motion): Process display vector front to back
6003 rather than the other way around. (Bug#2496)
6004
2ba8e008
SM
60052011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6006
6007 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6008
20f53c69
CY
60092011-09-11 Chong Yidong <cyd@stupidchicken.com>
6010
6011 * minibuf.c (Fread_from_minibuffer): Doc fix.
6012
d562d7a4
EZ
60132011-09-11 Eli Zaretskii <eliz@gnu.org>
6014
6015 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6016 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6017
1c4d7f3d
LMI
60182011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6019
6020 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6021 value for non-existent files.
6022
b885bf36
EZ
60232011-09-11 Eli Zaretskii <eliz@gnu.org>
6024
6025 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6026 set its "size" to -1. This will set the modtime_size field of
6027 the corresponding buffer to -1, which is what
6028 verify-visited-file-modtime expects for files that do not exist.
6029 (Bug#9139)
6030
6612f0bf
PE
60312011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6034 here ...
6035 * lisp.h: ... from here. push_key_description is no longer
6036 defined in keyboard.c, so its declaration should not be in
6037 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6038 logically belongs with push_key_description.
6039
dfb3f755
PE
60402011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6041
6042 * buffer.h: Include <sys/types.h> instead of <time.h>.
6043 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6044 Problem reported by Herbert J. Skuhra.
6045
3134906c
LMI
60462011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6047
6048 * xml.c (parse_region): Make the parsing work for
6049 non-comment-starting XML files again (bug#9144).
6050
8d903f4e
AS
60512011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6052
6053 * image.c (gif_load): Fix calculation of bottom and right corner.
6054 (Bug#9468)
6055
80ad64f4
EZ
60562011-09-10 Eli Zaretskii <eliz@gnu.org>
6057
6058 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6059 redisplay in small windows.
6060
208a048d
EZ
60612011-09-09 Eli Zaretskii <eliz@gnu.org>
6062
6063 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6064
9b1c252e
MR
60652011-09-08 Martin Rudalics <rudalics@gmx.at>
6066
6067 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6068 Operate on live windows only.
6069
2949f33b
JB
60702011-09-08 Juanma Barranquero <lekktu@gmail.com>
6071
6072 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6073
e08dcafd
EZ
60742011-09-07 Eli Zaretskii <eliz@gnu.org>
6075
6076 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6077 only under bidi iteration.
6078
115b96bd
JD
60792011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6080
6081 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6082
c8199d0f
PE
60832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6084
6085 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6086 Without this fix, the command to link temacs failed due to an
6087 undefined symbol __builtin_isnan. This is because
6088 /usr/include/iso/math_c99.h #defines isnan(x) to
6089 __builtin_isnan(x), but the bundled gcc, which identifies itself
6090 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6091 a __builtin_isnan.
6092 * floatfns.c (isnan): #undef, and then #define to a clone of
6093 what's in data.c.
6094 (Fisnan): Always define, since it's always available now.
6095 (syms_of_floatfns): Always define isnan at the Lisp level.
6096
e39b275c 60972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6098
6099 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6100
b2db44d9 61012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6102
f4af5137 6103 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6104 The previous code assumed that file offsets (off_t values) fit in
6105 EMACS_INT variables, which is not true on typical 32-bit hosts.
6106 The code messed up by falsely reporting buffer overflow in cases
6107 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6108 when "big" contains more than 2**29 bytes, even though this
6109 inserts just one byte and does not overflow the buffer.
6110 (Finsert_file_contents): Store file offsets as off_t
6111 values, not as EMACS_INT values. Check for overflow when
6112 converting between EMACS_INT and off_t. When checking for
6113 buffer overflow or for overlap, take the offsets into account.
6114 Don't use EMACS_INT for small values where int suffices.
6115 When checking for overlap, fix a typo: ZV was used where
6116 ZV_BYTE was intended.
6117 (Fwrite_region): Don't assume off_t fits into 'long'.
6118 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6119
ecfc0a49
MA
61202011-09-05 Michael Albinus <michael.albinus@gmx.de>
6121
6122 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6123
6511acf2 61242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6125
0999621a 6126 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6127
6128 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6129 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6130 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6131 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6132 (modify_event_symbol): Do not assume that the length of
6133 name_alist_or_stem is safe to alloca and fits in int.
6134 (Fexecute_extended_command): Likewise for function name and binding.
6135 (Frecursion_depth): Wrap around reliably on integer overflow.
6136 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6137 since some callers pass EMACS_INT values.
6138 (Fsingle_key_description): Don't crash if symbol name contains more
6139 than MAX_ALLOCA bytes.
6140 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6141 (get_minibuffer): Arg is now EMACS_INT, not int.
6142 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6143 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6144 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6145
2be7d702
PE
6146 * dbusbind.c (signature_cat): New function.
6147 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6148 Do not overrun buffer; instead, report string overflow.
6149
9d1df220
PE
6150 * dispnew.c (add_window_display_history): Don't overrun buffer.
6151 Truncate instead; this is OK since it's just a log.
6152
33ef5c64
PE
6153 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6154 even if the time zone offset is outlandishly large.
6155 Don't mishandle offset == INT_MIN.
6156
66c6fdd5
PE
6157 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6158 when creating daemon; the previous buffer-overflow check was incorrect.
6159
d749b01b
PE
6160 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6161 which has the guts of the old verror function.
6162
b5cd1905
PE
6163 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6164 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6165
6e1a67fb
PE
6166 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6167 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6168 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6169 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6170 length of string rather than counting it via multiple sprintfs;
6171 that's simpler and more reliable.
c21721cc
PE
6172 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6173 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6174 sprintf, in case result does not fit in int.
6175
c57b67fc
PE
6176 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6177 (fontset_from_font): Print it.
6178
8a401434
PE
6179 * frame.c (tty_frame_count): Now printmax_t, not int.
6180 (make_terminal_frame, set_term_frame_name): Print it.
6181 (x_report_frame_params): In X, window IDs are unsigned long,
6182 not signed long, so print them as unsigned.
6183 (validate_x_resource_name): Check for implausibly long names,
6184 and don't assume name length fits in 'int'.
6185 (x_get_resource_string): Don't blindly alloca invocation name;
6186 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6187 not fit in int.
6188
6e1a67fb
PE
6189 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6190 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6191 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6192
0df02bf3
PE
6193 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6194 Use esprintf, not sprintf, in case result does not fit in int.
6195
48e30793
PE
6196 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6197 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6198 it as a large positive number.
6199 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6200 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6201
a66ff6d8
PE
6202 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6203 in case result does not fit in int.
6204
aca216ff
PE
6205 * print.c (float_to_string): Detect width overflow more reliably.
6206 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6207 buffer overrun. Don't assume list length fits in 'int'. Treat
6208 print length of 0 as 0, not as infinity; to be consistent with other
6209 uses of print length in this function. Don't overflow print length
6210 index. Don't assume hash table size fits in 'long', or that
6211 vectorlike size fits in 'unsigned long'.
6212
31c286f7
PE
6213 * process.c (make_process): Use printmax_t, not int, to format
6214 process-name gensyms.
6215
55e5faa1
PE
6216 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6217
80f2e268
PE
6218 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6219 to avoid potential buffer overrun.
6220
670741ab
PE
6221 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6222 if X resource line is longer than 512 bytes.
6223
b7163a50
PE
6224 * xfns.c (x_window): Make sprintf buffer a bit bigger
6225 to avoid potential buffer overrun.
6226
ae58ff1f
PE
6227 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6228
c43c8a6a
PE
6229 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6230
3f8236f4
PE
62312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6232
53e9fe90 6233 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6234 Without these, Emacs silently mishandles large integers sometimes.
6235 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6236 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6237
6511acf2
PE
6238 * xdisp.c (try_window_id): Check Emacs fixnum range before
6239 converting to 'int'.
806add1d 6240
6511acf2 6241 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6242 Check that an Emacs fixnum is in range before assigning it to 'int'.
6243 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6244 values converted from Emacs fixnums.
6245 (Frecenter): Don't wrap around a line count if it is out of 'int'
6246 range; instead, treat it as an extreme value.
6247 (Fset_window_configuration, compare_window_configurations):
6248 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6249
6511acf2
PE
6250 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6251 that can exceed INT_MAX. Check that EMACS_INT value is in range
6252 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6253 (match_limit): Don't assume that a fixnum can fit in 'int'.
6254
6511acf2 6255 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6256 exceed INT_MAX.
6257
6511acf2 6258 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6259 (Fvertical_motion): Don't wrap around LINES values that don't fit
6260 in 'int'. Instead, treat them as extreme values. This is good
6261 enough for windows, which can't have more than INT_MAX lines anyway.
6262
fcb901a7
LMI
62632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6264
0f2f6b6d
LMI
6265 * Require libxml/parser.h to avoid compilation warning.
6266
fcb901a7
LMI
6267 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6268
6269 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6270 since this reportedly can destroy thread storage.
6271
6e20a0d4
CY
62722011-08-30 Chong Yidong <cyd@stupidchicken.com>
6273
6274 * syntax.c (find_defun_start): Update all cache variables if
6275 exiting early (Bug#9401).
6276
148ae00e
EZ
62772011-08-30 Eli Zaretskii <eliz@gnu.org>
6278
f6cfbd8f
EZ
6279 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6280
148ae00e
EZ
6281 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6282 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6283 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6284
6285 * term.c (tty_append_glyph): New function.
6286 (produce_stretch_glyph): Static function and its prototype deleted.
6287
a66cfb1c
SM
6288 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6289 Add prototypes.
148ae00e 6290
c4a07a4c
PE
62912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6292
6293 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6294 when checking :margin (Bug#9390).
6295 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6296 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6297 so that the name doesn't mislead. All uses changed.
6298
6bc8cd65
JB
62992011-08-28 Johan Bockgård <bojohan@gnu.org>
6300
6301 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6302 set_tty_hooks.
6303
dca4927e
EZ
63042011-08-27 Eli Zaretskii <eliz@gnu.org>
6305
6306 * xdisp.c (move_it_to): Don't bail out early when reaching
6307 position beyond to_charpos, if we are scanning backwards.
6308 (move_it_vertically_backward): When DY == 0, make sure we get to
6309 the first character in the line after the newline.
6310
f2cad773
PE
63112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6312
6313 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6314 (ccl_driver): Do not generate an out-of-range pointer.
6315 (Fccl_execute_on_string): Remove unnecessary check for
6316 integer overflow, noted by Stefan Monnier in
6317 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6318 Remove a FIXME that didn't need fixing.
6319 Simplify the newly-introduced buffer reallocation code.
6320
0cae2cdb
JB
63212011-08-27 Juanma Barranquero <lekktu@gmail.com>
6322
6323 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6324
5fc295a4 63252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6326
70c60eb2 6327 Integer and memory overflow issues (Bug#9196).
726e0ab1 6328
d31850da
PE
6329 * doc.c (get_doc_string): Rework so that
6330 get_doc_string_buffer_size is the actual buffer size, rather than
6331 being 1 less than the actual buffer size; this makes xpalloc more
6332 convenient.
6333
a69fbedb
PE
6334 * image.c (x_allocate_bitmap_record, cache_image):
6335 * xselect.c (Fx_register_dnd_atom):
6336 Simplify previous changes by using xpalloc.
6337
fe5c5d37
PE
6338 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6339 since either will do and ptrdiff_t is convenient with xpalloc.
6340
0065d054
PE
6341 * charset.c (charset_table_size)
6342 (struct charset_sort_data.priority): Now ptrdiff_t.
6343 (charset_compare): Don't overflow if priorities differ greatly.
6344 (Fsort_charsets): Don't assume list length fits in int.
6345 Check for size-calculation overflow when allocating sort data.
6346 (syms_of_charset): Allocate an initial charset table that is
6347 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6348
6349 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6350
6351 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6352 The actual value is always <= INT_MAX, and leaving it unsigned made
6353 overflow checking harder.
6354
6355 * dispextern.h (struct glyph_matrix.rows_allocated)
6356 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6357 with xpalloc. The values are still always <= INT_MAX.
6358
6359 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6360
6361 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6362 (SAFE_NALLOCA): New macro.
6363
6364 * region-cache.c (struct boundary.pos, find_cache_boundary)
6365 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6366 (set_cache_region, invalidate_region_cache)
6367 (revalidate_region_cache, know_region_cache, region_cache_forward)
6368 (region_cache_backward, pp_cache):
6369 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6370 so that ptrdiff_t * can be passed to xpalloc.
6371 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6372 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6373 (pp_cache): Don't assume cache_len fits in int.
6374 * region-cache.h: Adjust extern decls to match.
6375
6376 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6377 EMACS_INT, since either will do, for xpalloc.
6378
6379 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6380 (xnmalloc, xnrealloc, xpalloc): New functions.
6381
726e0ab1
PE
6382 * bidi.c (bidi_shelve_header_size): New constant.
6383 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6384 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6385
51f30bc5 6386 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6387 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6388 (overlay_strings):
6389 Don't update size of array until after memory allocation succeeds,
6390 because xmalloc/xrealloc may not return.
0065d054
PE
6391 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6392 now that we have proper integer overflow checking.
6393 (record_overlay_string, overlay_strings): Catch overflows when
6394 calculating size of overlay_str_buf.
726e0ab1 6395
0065d054
PE
6396 * callproc.c (Fcall_process): Check for size overflow when
6397 calculating size of args2.
6398 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6399 Normally we prefer signed values, but sticking with ptrdiff_t would
6400 require adding more-complicated checks.
726e0ab1
PE
6401
6402 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6403 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6404 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6405 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6406
6407 * character.c (Fstring): Check for size-calculation overflow.
6408
6409 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6410 unnecessary integer overflow. Check for size overflow.
6411 (encode_coding_object): Don't update size until xmalloc succeeds.
6412
6413 * composite.c (get_composition_id): Check for overflow in glyph
6414 length calculations.
6415
6416 Integer and memory overflow fixes for display code.
6417 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6418 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6419 (scrolling_window): Check for overflow in size calculations.
6420 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6421 Don't assume glyph table len fits in int.
6422 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6423 (row_table_size): Now ptrdiff_t, not int.
6424 (scrolling_window): Avoid overflow in size calculations.
6425 Don't update size until allocation succeeds.
6426 * fns.c (concat): Check for overflow in size calculations.
6427 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6428 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6429 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6430
6431 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6432 (get_doc_string): Check for size calculation overflow.
6433 Don't update size until allocation succeeds.
6434 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6435 EMACS_INT, where ptrdiff_t will do.
6436 (Fsubstitute_command_keys): Check for string overflow.
6437
6438 * editfns.c (set_time_zone_rule): Don't assume environment length
6439 fits in int.
6440 (message_length): Now ptrdiff_t, not int.
6441 (Fmessage_box): Don't update size until allocation succeeds.
6442 Don't assume message length fits in int.
6443 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6444
0065d054
PE
6445 * emacs.c (main): Do not reallocate argv, since there is a null at
6446 the end that can be overwritten, and this way there's no need to
6447 worry about size-calculation overflow.
6448 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6449
6450 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6451 alloc succeeds.
6452 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6453
6454 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6455 (x_set_scroll_bar_width, x_figure_window_size):
6456 Check for integer overflow.
6457 (x_set_alpha): Do not assume XINT fits in int.
6458
6459 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6460 This is for the members text_lines, text_cols, total_lines, total_cols,
6461 where the system imposes an 'int' limit.
6462
6463 * fringe.c (Fdefine_fringe_bitmap):
6464 Don't update size until alloc works.
6465
6466 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6467 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6468
6469 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6470 Check for size-calculation overflow.
6471 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6472 do, as we prefer signed integers.
6473 (id_to_widget.max_size, id_to_widget.used)
6474 (xg_store_widget_in_map, xg_remove_widget_from_map)
6475 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6476 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6477 Use and return ptrdiff_t, not int.
6478 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6479 * gtkutil.h: Change prototypes to match the above.
6480
6481 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6482 are duplicate now that they've been promoted to lisp.h.
6483 (x_allocate_bitmap_record, x_alloc_image_color)
6484 (make_image_cache, cache_image, xpm_load):
6485 Don't update size until alloc is done.
6486 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6487 (x_detect_edges):
3256efce 6488 Check for size calculation overflow.
726e0ab1
PE
6489 (ct_colors_allocated_max): New constant.
6490 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6491 overflow.
3256efce 6492
726e0ab1
PE
6493 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6494 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6495 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6496 Use ptrdiff_t, not int, to count maps.
6497 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6498 calculations. Don't update size until allocation succeeds.
6499 Redo calculations to avoid overflow.
726e0ab1
PE
6500 * keyboard.h: Change prototypes to match the above.
6501
6502 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6503 to count maps.
6504 (current_minor_maps): Check for size calculation overflow.
6505 * keymap.h: Change prototypes to match the above.
6506
6507 * lread.c (read1, init_obarray): Don't update size until alloc done.
6508
6509 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6510 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6511
726e0ab1
PE
6512 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6513 Now ptrdiff_t, not int.
6514 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6515 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6516
6517 * process.c (Fnetwork_interface_list): Check for overflow
6518 in size calculation.
6519
6520 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6521
6522 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6523 overflow. Don't bother calling xmalloc when xrealloc will do.
6524
6525 * search.c (Freplace_match): Check for size calculation overflow.
6526 (Fset_match_data): Don't assume list lengths fit in 'int'.
6527
6528 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6529 for command line length. Do not attempt to address one before the
6530 beginning of an array, as that's not portable.
6531
6532 * term.c (max_frame_lines): Remove; unused.
6533 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6534 not int.
6535 (encode_terminal_code, calculate_costs): Check for size
6536 calculation overflow.
6537 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6538 table lengths and related sizes. Don't update size until alloc
6539 done. Redo calculations to avoid overflow.
6540 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6541
6542 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6543 subtracting pointers.
6544 (gobble_line): Check for overflow more carefully. Don't update size
6545 until alloc done.
6546
6547 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6548 Don't update size until alloc done.
6549 Redo size calculations to avoid overflow.
6550 Check for size calculation overflow.
0065d054 6551 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6552
6553 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6554 Use ptrdiff_t, not int, for sizes.
6555 (store_mode_line_noprop_char): Don't update size until alloc done.
6556
0065d054
PE
6557 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6558 Use ptrdiff_t, not int, for sizes.
6559 (Finternal_make_lisp_face, cache_face):
6560 Check for size calculation overflow.
6561 (cache_face): Treat size calculation overflows as if they were
6562 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6563
6564 * xfns.c (x_encode_text, x_set_name_internal)
6565 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6566 sizes, since they can exceed INT_MAX in size. Check for size
6567 calculation overflow.
6568
0065d054
PE
6569 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6570 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6571 Don't update size until alloc done.
6572
0065d054 6573 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6574 as sprintf is limited to int lengths.
1d526e2f 6575
252c5ee1
PE
6576 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6577 (X_LONG_MIN): New macros.
864d7ce7
PE
6578 Use them to make the following changes clearer.
6579 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6580 This change doesn't affect the value now, but it may help remind
6581 future maintainers not to raise the value too much later.
6582 (SELECTION_QUANTUM): Remove, replacing with ...
6583 (selection_quantum): ... new function, which avoids overflow.
6584 All uses changed.
6585 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6586 assumption that selection length fits in 'int'.
6587 (x_reply_selection_request, x_handle_selection_request)
6588 (x_get_window_property, receive_incremental_selection)
6589 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6590 (lisp_data_to_selection_data, clean_local_selection_data):
6591 Use ptrdiff_t, not int, to record length of selection.
6592 (x_reply_selection_request, x_get_window_property)
6593 (receive_incremental_selection, x_property_data_to_lisp):
6594 Redo calculations to avoid overflow.
6595 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6596 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6597 something.
6598 (x_get_window_property, receive_incremental_selection)
6599 (lisp_data_to_selection_data, x_property_data_to_lisp):
6600 Check for size-calculation overflow.
6601 (x_get_window_property, receive_incremental_selection)
6602 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6603 Don't store size until memory allocation succeeds.
6604 (x_get_window_property): Plug memory leak on memory exhaustion.
6605 Don't double-block input; malloc is safe here. Don't assume 2**34
6606 - 4 fits in unsigned long. Add an xassert to check
6607 XGetWindowProperty overflow. Be more careful about overflow
6608 calculations, and distinguish size from memory overflow better.
6609 (receive_incremental_selection): When tracing, don't assume
6610 unsigned int is less than INT_MAX.
6611 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6612 harmful) conversions of unsigned short to int.
6613 (lisp_data_to_selection_data): Don't assume that integers
6614 in the range -65535 through -1 fit in an X unsigned short.
6615 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6616 result parameters unless successful. Rely on cons_to_unsigned
6617 to report problems with elements; the old code wasn't right anyway.
6618 (x_check_property_data): Check for int overflow; we cannot use
6619 a wider type due to X limits.
6620 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6621
726e0ab1 6622 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6623
0065d054
PE
6624 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6625 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6626 (x_color_cells): Don't store size until memory allocation succeeds.
6627 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6628 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6629 (x_term_init): Don't assume length fits in int (sprintf is limited
6630 to int size).
bc18e09d 6631
ebfa62c0
PE
6632 Use ptrdiff_t for composition IDs.
6633 * character.c (lisp_string_width):
6634 * composite.c (composition_table_size, n_compositions)
6635 (get_composition_id, composition_gstring_from_id):
6636 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6637 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6638 * window.c (Frecenter):
6639 Use ptrdiff_t, not int, for composition IDs.
6640 * composite.c (get_composition_id): Check for integer overflow.
6641 * composite.h: Adjust prototypes to match the above changes.
6642
d3411f89
PE
6643 Use ptrdiff_t for hash table indexes.
6644 * category.c (hash_get_category_set):
6645 * ccl.c (ccl_driver):
6646 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6647 * coding.c (coding_system_charset_list, detect_coding_system):
6648 * coding.h (struct coding_system.id):
6649 * composite.c (get_composition_id, gstring_lookup_cache):
6650 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6651 * image.c (xpm_get_color_table_h):
6652 * lisp.h (hash_lookup, hash_put):
6653 * minibuf.c (Ftest_completion):
6654 Use ptrdiff_t for hash table indexes, not int (which is too
6655 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6656 32-bit --with-wide-int hosts).
6657
e097a6fa
PE
6658 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6659 Add a FIXME comment about memory leaks.
6660 (syms_of_charset): Don't assume xmalloc returns.
6661
5637687f
PE
6662 Don't assume that stated character widths fit in int.
6663 * character.c (Fchar_width, c_string_width, lisp_string_width):
6664 * character.h (CHAR_WIDTH):
6665 * indent.c (MULTIBYTE_BYTES_WIDTH):
6666 Use sanitize_char_width to avoid undefined and/or bad behavior
6667 with outlandish widths.
a66cfb1c 6668 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6669 now that we have two such functions. All uses changed.
6670 (sanitize_char_width): New inline function.
6671
a2271ba2
PE
6672 Don't assume that tab-width fits in int.
6673 * character.h (sanitize_width): New inline function.
6674 (SANE_TAB_WIDTH): New macro.
6675 (ASCII_CHAR_WIDTH): Use it.
6676 * indent.c (sane_tab_width): Remove. All uses replaced by
6677 SANE_TAB_WIDTH (current_buffer).
6678 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6679
18c52557
PE
6680 * fileio.c: Integer overflow issues with file modes.
6681 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6682
caeeedc1
PE
6683 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6684 Remove unreachable code.
6685 (read_hex, load_charset_map_from_file): Check for integer overflow.
6686
6df6ae42 6687 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6688 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6689 (x_send_scroll_bar_event): Likewise. Check that the size does not
6690 exceed limits imposed by XClientMessageEvent, as well as the usual
6691 ptrdiff_t and size_t limits.
6692
b13995db
PE
6693 * keyboard.c: Overflow, signedness and related fixes.
6694 (make_lispy_movement): Use same integer type in forward decl
6695 that is used in the definition.
6696 (read_key_sequence, keyremap_step):
6697 Change bufsize argument back to int, undoing my 2011-03-30 change.
6698 We prefer signed types, and int is wide enough here.
6699 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6700 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6701 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6702 length, not size_t. Use ptrdiff_t for index, not int.
6703 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6704 possibility of integer overflow.
6705
13464394
PE
6706 Overflow, signedness and related fixes for images.
6707
6708 * dispextern.h (struct it.stack[0].u.image.image_id)
6709 (struct_it.image_id, struct image.id, struct image_cache.size)
6710 (struct image_cache.used, struct image_cache.ref_count):
6711 * gtkutil.c (update_frame_tool_bar):
6712 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6713 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6714 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6715 * nsmenu.m (update_frame_tool_bar):
6716 * xdisp.c (calc_pixel_width_or_height):
6717 * xfns.c (image_cache_refcount):
6718 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6719 on typical 64-bit hosts.
6720
6721 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6722 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6723 Omit unnecessary casts to int.
6724 (parse_image_spec): Check that integers fall into 'int' range
6725 when the callers expect that.
6726 (image_ascent): Redo ascent calculation to avoid int overflow.
6727 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6728 (lookup_image): Remove unnecessary tests.
6729 (xbm_image_p): Locals are now of int, not EMACS_INT,
6730 since parse_image_check makes sure they fit into int.
6731 (png_load, gif_load, svg_load_image):
6732 Prefer int to unsigned where either will do.
6733 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6734 old tiff_error_handler and tiff_warning_handler.
6735 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6736 stack buffer overflows. It uses only the features of vsnprintf
6737 that are common to both POSIX and native Microsoft.
6738 (tiff_error_handler, tiff_warning_handler): Use it.
6739 (tiff_load, gif_load, imagemagick_load_image):
6740 Don't assume :index value fits in 'int'.
6741 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6742 (imagemagick_load_image): Check that crop parameters fit into
6743 the integer types that MagickCropImage accepts. Don't assume
6744 Vimagemagick_render_type has a nonnegative value. Don't assume
6745 size_t fits in 'long'.
6746 (gs_load): Use printmax_t to print the widest integers possible.
6747 Check for integer overflow when computing image height and width.
6748
c11821d4
EZ
67492011-08-26 Eli Zaretskii <eliz@gnu.org>
6750
6751 * xdisp.c (redisplay_window): Don't force window start if point
6752 will be invisible in the resulting window. (Bug#9324)
6753
0c95fcf7
EZ
67542011-08-25 Eli Zaretskii <eliz@gnu.org>
6755
6756 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6757 the display spec is of the form `(space ...)'.
6758 (handle_display_spec): Return the value returned by
6759 handle_single_display_spec, not just 1 or zero.
6760 (handle_single_display_spec): If the display spec is of the form
6761 `(space ...)', and specifies display in the text area, return 2
6762 rather than 1.
fee65a97 6763 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6764 accurately, and prefer exact match for point under bidi.
6765 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6766
6767 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6768 into disp_prop; all users changed.
6769
6770 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6771 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6772 for the text covered by the display property.
6773
e4ed06f1
CY
67742011-08-25 Chong Yidong <cyd@stupidchicken.com>
6775
6776 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6777 Change return value to nil.
6778 (Frecord_buffer): Delete unused function.
6779
f67cdd7f
EZ
67802011-08-24 Eli Zaretskii <eliz@gnu.org>
6781
5980d4c6
EZ
6782 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6783 buffers, return left-to-right.
8610fe8b
EZ
6784 (set_cursor_from_row): Consider candidate row a win if its glyph
6785 represents a newline and point is on that newline. Fixes cursor
6786 positioning on the newline at EOL of R2L text within L2R
6787 paragraph, and vice versa.
6788 (try_cursor_movement): Check continued rows, in addition to
6789 continuation rows. Fixes unwarranted scroll when point enters a
6790 continued line of R2L text within an L2R paragraph, or vice versa.
6791 (cursor_row_p): Consider the case of point being equal to
6792 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6793 from the end of a short line to the beginning of a continued line
6794 of R2L text within L2R paragraph.
6795 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6796 composed characters.
5980d4c6 6797
f67cdd7f
EZ
6798 * bidi.c (bidi_check_type): Use xassert.
6799 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6800 members.
6801
bca633fb
EZ
68022011-08-23 Eli Zaretskii <eliz@gnu.org>
6803
6804 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6805 a character.
6806
4a5885a7
CY
68072011-08-23 Chong Yidong <cyd@stupidchicken.com>
6808
6809 * nsfont.m (ns_otf_to_script): Fix typo.
6810
0902a04e
KH
68112011-08-22 Kenichi Handa <handa@m17n.org>
6812
6813 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6814 extra slot even if the purpose is char-code-property-table.
6815
1a2e6670
EZ
68162011-08-23 Eli Zaretskii <eliz@gnu.org>
6817
8ddde651
EZ
6818 * xdisp.c (redisplay_window): When computing centering_position,
6819 account for the height of the header line. (Bug#8874)
6820
425cc014
EZ
6821 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6822 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6823 candidate is selected by the mouse, and that candidate has a
6824 composed character under the mouse.
6825
1a2e6670
EZ
6826 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6827 coordinates reported by pos-visible-in-window-p for a composed
6828 character in column zero.
6829
8b76d6f8
SM
68302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6831
6832 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6833
dac347dd
EZ
68342011-08-22 Eli Zaretskii <eliz@gnu.org>
6835
6836 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6837 consider it a hit if to_charpos is anywhere in the range of the
6838 composed buffer positions.
6839
e013fb34
CY
68402011-08-22 Chong Yidong <cyd@stupidchicken.com>
6841
6842 * image.c (gif_load): Don't assume that each subimage has the same
6843 dimensions as the base image. Handle disposal method that is
6844 "undefined" by the gif spec (Bug#9335).
6845
bd1ba3e8
CY
68462011-08-20 Chong Yidong <cyd@stupidchicken.com>
6847
6848 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6849 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6850
54a1215b
EZ
68512011-08-19 Eli Zaretskii <eliz@gnu.org>
6852
823564e5
EZ
6853 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6854 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6855 from an Org mode buffer to a Speedbar frame.
6856
54a1215b
EZ
6857 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6858 a composition, take its buffer position from IT->cmp_it.charpos.
6859 Fixes cursor positioning at the beginning of a line that begins
6860 with a composed character.
6861
9778ebcc
EZ
68622011-08-18 Eli Zaretskii <eliz@gnu.org>
6863
0be6ee06
EZ
6864 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6865 character bidirectional type, use STRONG_L instead. Fixes crashes
6866 in a buffer produced by `describe-categories'.
6867
9778ebcc
EZ
6868 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6869 members before the level stack, so they would be saved and
6870 restored when copying iterator state. Fixes incorrect reordering
6871 around TABs covered by display properties.
6872
156bffbe
AS
68732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6874
6b02f655 6875 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6876
72ad093b
CY
68772011-08-17 Chong Yidong <cyd@stupidchicken.com>
6878
6879 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6880 (internal_condition_case_2, internal_condition_case_n):
6881 Remove unnecessary aborts (Bug#9081).
72ad093b 6882
35774242
EZ
68832011-08-17 Eli Zaretskii <eliz@gnu.org>
6884
6885 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6886 has no `load' handler, try opening the file locally. (Bug#9311)
6887
db76dd85
KB
68882011-08-16 Ken Brown <kbrown@cornell.edu>
6889
6890 * gmalloc.c: Expand comment.
6891
b215eee5
EZ
68922011-08-16 Eli Zaretskii <eliz@gnu.org>
6893
6894 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6895 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6896
a4579d33
KB
68972011-08-16 Ken Brown <kbrown@cornell.edu>
6898
6899 Fix memory allocation problems in Cygwin build (Bug#9273).
6900
6901 * unexcw.c ( __malloc_initialized): Declare external variable.
6902 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6903
8b76d6f8
SM
6904 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6905 New variables.
a4579d33
KB
6906 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6907 dumped emacs.
6908 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6909 in the static heap.
6910 [CYGWIN] (special_realloc): New function.
6911 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6912 requests to realloc storage in the static heap.
6913
3ebec551
PE
69142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6915
6916 * bidi.c (bidi_initialize): Remove unused local.
6917
9fd8be00
EZ
69182011-08-15 Eli Zaretskii <eliz@gnu.org>
6919
6b02f655
SM
6920 * bidimirror.h:
6921 * biditype.h: Remove file.
6922 * makefile.w32-in ($(BLD)/bidi.$(O)):
6923 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6924
6925 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6926
6927 * chartab.c: Improve commentary for the uniprop_table API.
6928
32413314
EZ
6929 * bidi.c (bidi_paragraph_init): Support zero value of
6930 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6931 (bidi_initialize): Use uniprop_table instead of including
6932 biditype.h and bidimirror.h.
32413314 6933
9fd8be00
EZ
6934 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6935 coordinates of the iterator when restoring from ppos_it.
6936 (Bug#9296)
6937
5cf2b69b
KH
69382011-08-14 Kenichi Handa <handa@m17n.org>
6939
6940 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6941 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6942
daf17d00
EZ
69432011-08-14 Eli Zaretskii <eliz@gnu.org>
6944
6945 * xdisp.c (move_it_in_display_line_to): Don't invoke
6946 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6947 ppos_it. Fixes vertical cursor motion when line beginning is
6948 covered by an image. (Bug#9296)
6949
08e3161a
JD
69502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6951
6952 * nsterm.h (ns_run_ascript): Declare.
6953 (NSAPP_DATA2_RUNASSCRIPT): Define.
6954
6955 * nsfns.m (as_script, as_result, as_status): New static variables.
6956 (ns_run_ascript): New function.
5e617bc2 6957 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6958 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6959 the event loop. Get status from as_status (Bug#7276).
6960
6961 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6962 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6963 the event loop (Bug#7276).
6964
a3720aa2
AS
69652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6966
6967 * gnutls.c (QCgnutls_bootprop_priority)
6968 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6969 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6970 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6971 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6972 (QCgnutls_bootprop_verify_hostname_error)
6973 (QCgnutls_bootprop_callbacks_verify): Rename from
6974 Qgnutls_bootprop_..., all uses changed.
6975
6976 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6977 uses changed.
6978
0a0d27fb
PE
69792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6980
19d5c50c
PE
6981 * xfaces.c (Qframe_set_background_mode): Now static.
6982 * dispextern.h (Qframe_set_background_mode): Remove decl.
6983
0a0d27fb
PE
6984 * process.c (Fnetwork_interface_info): Declare local only if needed.
6985
377538cb
JD
69862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6987
6988 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6989 (Fnetwork_interface_list): Allocate in increments of bytes instead
6990 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6991 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6992 sockaddr.
6993 (struct ifflag_def): notrailers is smart on OSX.
6994 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6995 Get hardware address with getifaddrs if available.
6996
08fff70c
EZ
69972011-08-12 Eli Zaretskii <eliz@gnu.org>
6998
6999 * xdisp.c (iterate_out_of_display_property): xassert that
7000 IT->position is set to within IT->object's boundaries. Break from
7001 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7002 when IT->position is set up wrongly due to some bug.
7003 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7004 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7005 entry. Force push_it to save on the stack the current
7006 buffer/string position, to be restored by pop_it. Fix flags in
7007 the iterator structure wrt the object coming from a display
7008 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7009 properties. (Bug#9284)
7010
7be1c708 70112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7012
7be1c708
CY
7013 * fontset.c (fontset_get_font_group): Add proper type checks.
7014 (Bug#9172)
aac0c6e3 7015
7be1c708 70162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7017
7be1c708
CY
7018 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7019 and LC_VERSION_MIN_MACOSX.
7020 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7021 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7022
97bb72a6
EZ
70232011-08-08 Eli Zaretskii <eliz@gnu.org>
7024
7025 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7026 no-display-properties-and-no-overlays under bidi display.
7027 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7028 properties and overlays.
97bb72a6 7029
d5617611
CY
70302011-08-08 Chong Yidong <cyd@stupidchicken.com>
7031
37e11a63
CY
7032 * editfns.c (Fset_time_zone_rule): Document relationship with the
7033 setenv function.
7034
d5617611
CY
7035 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7036 the font entity extracted from the cache (Bug#8109).
7037
58872834
CY
70382011-08-07 Chong Yidong <cyd@stupidchicken.com>
7039
7040 * composite.c (autocmp_chars): Don't reset point. That is done by
7041 restore_point_unwind (Bug#5984).
7042
75bfc667
JL
70432011-08-07 Juri Linkov <juri@jurta.org>
7044
7045 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7046 to show the arg `TIME' instead of `TIMEVAL'.
7047
d1410150
EZ
70482011-08-06 Eli Zaretskii <eliz@gnu.org>
7049
7050 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7051 display property strides EOL and includes a newline, as in
7052 longlines-mode. (Bug#9254)
75b771e4
EZ
7053 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7054 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7055
7056 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7057 is non-zero, even if the data buffer is NULL. Fixes a crash in
7058 vertical-motion with longlines-mode. (Bug#9254)
7059
35928349
EZ
70602011-08-05 Eli Zaretskii <eliz@gnu.org>
7061
ec7cc85b
EZ
7062 * bidi.c <bidi_cache_total_alloc>: Now static.
7063 (bidi_initialize): Initialize bidi_cache_total_alloc.
7064
8b76d6f8 7065 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7066 cache. (Bug#9221)
7067
7068 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7069 amount allocated this far in `bidi_cache_total_alloc'.
7070 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7071 non-zero, only free the data buffer without restoring the cache
7072 contents. All callers changed.
7073
7074 * dispextern.h (bidi_unshelve_cache): Update prototype.
7075
7076 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7077 (move_it_in_display_line, move_it_to)
7078 (move_it_vertically_backward, move_it_by_lines): Replace the call
7079 to xfree to an equivalent call to bidi_unshelve_cache.
7080 (move_it_in_display_line_to): Fix logic of returning
412b6358 7081 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7082
e2e2423b
EZ
70832011-08-05 Eli Zaretskii <eliz@gnu.org>
7084
7085 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7086 came from a string character with a `cursor' property. (Bug#9229)
7087
ae9e757a
JD
70882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7089
7090 * Makefile.in (LIB_PTHREAD): New variable.
7091 (LIBES): Add LIB_PTHREAD (Bug#9216).
7092
7093 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7094 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7095
213bd7f2
AS
70962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7097
6b02f655 7098 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7099
99aaf75f
JD
71002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7101
7102 * xterm.c (x_find_topmost_parent): New function.
7103 (x_set_frame_alpha): Find topmost parent window with
7104 x_find_topmost_parent and set the property there also (bug#9181).
7105 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7106
c74e9d86
PE
71072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7108
7109 * callproc.c (Fcall_process): Avoid vfork clobbering
7110 the local vars buffer, coding_systems, current_dir.
7111
640c8776
SM
71122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7113
7114 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7115
f26d0e4c
PE
71162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7117
8a10d76c
PE
7118 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7119 so that it is not optimized away.
7120
f26d0e4c
PE
7121 * xdisp.c (compute_display_string_pos): Remove unused local.
7122
55439c61
EZ
71232011-08-02 Eli Zaretskii <eliz@gnu.org>
7124
7125 Fix slow cursor motion and scrolling in large buffers with
7126 selective display, like Org Mode buffers. (Bug#9218)
7127
7128 * dispextern.h (struct bidi_it): New member disp_prop_p.
7129
7130 * xdisp.c: Remove one-slot cache of display string positions.
7131 (compute_display_string_pos): Accept an additional argument
5e617bc2 7132 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7133 for a display string or property. If found, set DISP_PROP_P
7134 non-zero.
7135
7136 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7137 DISP_PROP_P, and pass it to compute_display_string_pos.
7138 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7139 non-zero. All callers of bidi_fetch_char changed.
7140
fb33fa43
SM
71412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7142
7143 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7144
b099e063
DM
71452010-12-03 Don March <don@ohspite.net>
7146
7147 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7148 last character M-[char] is translated to ESC [char] (bug#7541).
7149
5cc7f7af
KH
71502011-08-02 Kenichi Handa <handa@m17n.org>
7151
d0fffa3f 7152 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7153
7154 * chartab.c (uniprop_table): Make it non-static.
7155
525d5e6e
EZ
71562011-08-01 Eli Zaretskii <eliz@gnu.org>
7157
7158 * xdisp.c (forward_to_next_line_start): Accept additional argument
7159 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7160 on the newline.
7161 (reseat_at_next_visible_line_start): Use the bidi iterator state
7162 returned by forward_to_next_line_start to restore the state of
7163 it->bidi_it after backing up to previous newline. (Bug#9212)
7164
31011111
AS
71652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7166
7167 * regex.c (re_comp): Protoize.
7168 (re_exec): Fix return type.
7169 (regexec): Fix type of `ret'. (Bug#9203)
7170
476371c4
PE
71712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7172
e5d76069
PE
7173 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7174 This is needed if max-image-size is a floating-point number.
7175
9a79b20c
AS
71762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7177
7178 * print.c (print_object): Print empty symbol as ##.
7179
7180 * lread.c (read1): Read ## as empty symbol.
7181
d8c2fa78
AA
71822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7183
7184 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7185 setting frame foreground color (Bug#9175).
7186 (x_set_background_color): Likewise.
7187
ffe57a7a
AA
7188 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7189 contents (Bug#9176).
7190 (EmacsTooltip -init): Remove bezels and add shadows to
7191 tooltip windows.
7192
bf3492a5
AA
7193 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7194 or scroll bar (Bug#8470).
7195
d55e9c53
AA
7196 * nsfont.m (nsfont_open): Remove assignment to voffset and
7197 unnecessary vars hshink, expand, hd, full_height, min_height.
7198 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7199
7200 * nsterm.h (nsfont_info): Remove voffset field.
7201
d8c2fa78 72022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7203
7204 Implement strike-through and overline on NextStep (Bug#8863).
7205
7206 * nsfont.m (nsfont_open): Use underline position provided by font,
7207 instead of hard-coded value of 2.
7208 (nsfont_draw): Call ns_draw_text_decoration instead.
7209
7210 * nsterm.h: Add declaration for ns_draw_text_decoration.
7211
7212 * nsterm.m (ns_draw_text_decoration): New function for drawing
7213 underline, overline, and strike-through.
7214 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7215 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7216 accommodate underlining, etc.
4843aac3 7217
4cc60b9b
EZ
72182011-07-28 Eli Zaretskii <eliz@gnu.org>
7219
bc7ece87
EZ
7220 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7221 default.
4cc60b9b 7222
476371c4
PE
72232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7224
66606eea
PE
7225 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7226 Without this fix, if a signal arrives just after memory fills up,
7227 'malloc' might be invoked reentrantly.
7228
476371c4
PE
7229 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7230 In other words, assume that every image size is allowed, on non-X
7231 hosts. This assumption is probably wrong, but it lets Emacs compile.
7232
f3fcc40d
AS
72332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7234
7235 * regex.c (re_iswctype): Convert return values to boolean.
7236
350c992f
EZ
72372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7238
7239 * xdisp.c (compute_display_string_pos): Don't use cached display
7240 string position if the buffer had its restriction changed.
7241 (Bug#9184)
7242
5266b4bb
PE
72432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7244
7245 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7246
2573a837 72472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7248
41f55ccd 7249 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7250
39e378da
PE
7251 * bidi.c: Integer size and overflow fixes.
7252 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7253 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7254 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7255 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7256 (bidi_find_other_level_edge):
7257 Use ptrdiff_t instead of EMACS_INT where either will do.
7258 This works better on 32-bit hosts configured --with-wide-int.
7259 (bidi_cache_ensure_space): Check for size-calculation overflow.
7260 Use % rather than repeated addition, for better worst-case speed.
7261 Don't set bidi_cache_size until after xrealloc returns, because it
7262 might not return.
7263 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7264 (bidi_cache_ensure_space): Also check that the bidi cache size
7265 does not exceed that of the largest Lisp string or buffer. See Eli
7266 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7267
5e927815
PE
7268 * alloc.c (__malloc_size_t): Remove.
7269 All uses replaced by size_t. See Andreas Schwab's note
7270 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7271
ca4aa935
PE
7272 * image.c: Improve checking for integer overflow.
7273 (check_image_size): Assume that f is nonnull, since
7274 it is always nonnull in practice. This is one less thing to
7275 worry about when checking for integer overflow later.
7276 (x_check_image_size): New function, which checks for integer
7277 overflow issues inside X.
7278 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7279 This removes the need for a memory_full check.
7280 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7281 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7282 (xbm_read_bitmap_data): Change locals back to 'int', since
7283 their values must fit in 'int'.
7284 (xpm_load_image, png_load, tiff_load):
7285 Invoke x_create_x_image_and_pixmap earlier,
7286 to avoid much needless work if the image is too large.
7287 (tiff_load): Treat overly large images as if
7288 x_create_x_image_and_pixmap failed, not as malloc failures.
7289 (gs_load): Use x_check_image_size.
7290
5f8f9cc2
PE
7291 * gtkutil.c: Omit integer casts.
7292 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7293 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7294
5adf60bc
PE
7295 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7296
c8907a93
PE
7297 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7298 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7299 would wrongly return t on a 64-bit host.
7300
e3c25c68
PE
7301 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7302 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7303 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7304 and therefore cause GCC to emit a bogus diagnostic in some cases.
7305
3f791afe
PE
7306 * image.c: Integer signedness and overflow and related fixes.
7307 This is not an exhaustive set of fixes, but it's time to
7308 record what I've got.
7309 (lookup_pixel_color, check_image_size): Remove redundant decls.
7310 (check_image_size): Don't assume that arbitrary EMACS_INT values
7311 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7312 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7313 (tiff_load, imagemagick_load_image):
7314 Check for overflow in size calculations.
7315 (x_create_x_image_and_pixmap): Remove unnecessary test for
7316 xmalloc returning NULL; that can't happen.
7317 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7318 (xpm_color_bucket): Use better integer hashing function.
7319 (xpm_cache_color): Don't possibly over-allocate memory.
7320 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7321 (gif_memory_source):
7322 Use ptrdiff_t, not int or size_t, to record sizes.
7323 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7324 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7325 either works, as we prefer signed integers.
7326 (tiff_read_from_memory, tiff_write_from_memory):
7327 Return tsize_t, not size_t, since that's what the TIFF API wants.
7328 (tiff_read_from_memory): Don't fail simply because the read would
7329 go past EOF; instead, return a short read.
7330 (tiff_load): Omit no-longer-needed casts.
7331 (Fimagemagick_types): Don't assume size fits into 'int'.
7332
3cc5a532
PE
7333 Improve hashing quality when configured --with-wide-int.
7334 * fns.c (hash_string): New function, taken from sxhash_string.
7335 Do not discard information about ASCII character case; this
7336 discarding is no longer needed.
7337 (sxhash-string): Use it. Change sig to match it. Caller changed.
7338 * lisp.h: Declare it.
7339 * lread.c (hash_string): Remove, since we now use fns.c's version.
7340 The fns.c version returns a wider integer if --with-wide-int is
7341 specified, so this should help the quality of the hashing a bit.
7342
b312a492
PE
7343 * emacs.c: Integer overflow minor fix.
7344 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7345 Define only if GNU_LINUX.
7346 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7347
dfd153ae
PE
7348 * dispnew.c: Integer signedness and overflow fixes.
7349 Remove unnecessary forward decls, that were a maintenance hassle.
7350 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7351 All uses changed.
7352 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7353 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7354 (prepare_desired_row, line_draw_cost):
7355 Use int, not unsigned, where either works.
7356 (save_current_matrix, restore_current_matrix):
7357 Use ptrdiff_t, not size_t, where either works.
7358 (init_display): Check for overflow more accurately, and without
7359 relying on undefined behavior.
7360
a81d11a3
PE
7361 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7362 Remove, replacing with the new symbols in lisp.h. All uses changed.
7363 * fileio.c (make_temp_name):
7364 * filelock.c (lock_file_1, lock_file):
7365 * xdisp.c (message_dolog):
7366 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7367 Use pMd etc. instead.
7368 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7369 replacing the pWIDE etc. symbols removed from editfns.c.
7370
3300e6fd
PE
7371 * keyboard.h (num_input_events): Now uintmax_t.
7372 This is (very slightly) less likely to mess up due to wraparound.
7373 All uses changed.
7374
fd05c7e9
PE
7375 * buffer.c: Integer signedness fixes.
7376 (alloc_buffer_text, enlarge_buffer_text):
7377 Use ptrdiff_t rather than size_t when either will do, as we prefer
7378 signed integers.
7379
903fe15d
PE
7380 * alloc.c: Integer signedness and overflow fixes.
7381 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7382 (__malloc_size_t): Default to size_t, not to int.
7383 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7384 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7385 Prefer ptrdiff_t to size_t when either would do, as we prefer
7386 signed integers.
7387 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7388 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7389 Now const. Initialize with values that are in range even if char
7390 is signed.
7391 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7392 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7393 These functions do the right thing with sizes > 2**32.
7394 (check_depth): Now ptrdiff_t, not int.
7395 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7396 Adjust to new way of storing sizes. Check for size overflow bugs
7397 in rest of code.
7398 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7399 slightly wrong anyway, as it missed one instance of
7400 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7401 (refill_memory_reserve): Omit needless cast to size_t.
7402 (mark_object_loop_halt): Mark as externally visible.
7403
ac82cc6a
PE
7404 * xselect.c: Integer signedness and overflow fixes.
7405 (Fx_register_dnd_atom, x_handle_dnd_message):
7406 Use ptrdiff_t, not size_t, since we prefer signed.
7407 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7408 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7409 x_dnd_atoms_size and x_dnd_atoms_length.
7410
c2d1e36d
PE
7411 * doprnt.c: Prefer signed to unsigned when either works.
7412 * eval.c (verror):
7413 * doprnt.c (doprnt):
7414 * lisp.h (doprnt):
7415 * xdisp.c (vmessage):
7416 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7417 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7418 prefer signed arithmetic to avoid comparison confusion.
7419 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7420 but is a bit tricky.
7421
0e926e56
PE
7422 Assume freestanding C89 headers, string.h, stdlib.h.
7423 * data.c, doprnt.c, floatfns.c, print.c:
7424 Include float.h unconditionally.
7425 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7426 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7427 * regex.c: Likewise for stddef.h, string.h.
7428 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7429 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7430 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7431 (STDC_HEADERS): Remove obsolete defines.
7432 * sysdep.c: Include limits.h unconditionally.
7433
9cfdb3ec
PE
7434 Assume support for memcmp, memcpy, memmove, memset.
7435 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7436 * regex.c (memcmp, memcpy):
7437 Remove; we assume C89 now.
7438
7439 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7440 (__malloc_safe_bcopy): Remove; no longer needed.
7441
cf950e6b 7442 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7443 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7444 well either way, and we prefer signed to unsigned.
7445
dbf38e02
LMI
74462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7447
7448 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7449 closes the connection while we're reading (bug#9182).
7450
d6f0886c 74512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7452
d6f0886c
JD
7453 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7454 are specified (Bug#9168).
24e0f6b1 7455
2eb1f9e6
PE
74562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7457
7458 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7459 Found by GCC static checking and --with-wide-int on a 32-bit host.
7460
22381272 74612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7462
7463 * xdisp.c (compute_display_string_pos): Fix logic of caching
7464 previous display string position. Initialize cached_prev_pos to
7465 -1. Fixes slow-down at the beginning of a buffer.
7466
f25e39b4
EZ
74672011-07-24 Eli Zaretskii <eliz@gnu.org>
7468
7469 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7470 for attrs[LFACE_FONTSET_INDEX].
7471
04c4b52e
PE
74722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 * xml.c (parse_region): Remove unused local
7475 that was recently introduced.
7476
c1734fbd
EZ
74772011-07-23 Eli Zaretskii <eliz@gnu.org>
7478
be18c5a5
EZ
7479 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7480 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7481
c1734fbd
EZ
7482 * xdisp.c (move_it_in_display_line_to): Record the best matching
7483 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7484 exit if none of the characters scanned was an exact match.
7485 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7486 when exact match is impossible due to invisible text, and the
7487 lines are truncated.
7488
a258d627
JD
74892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7490
7491 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7492 for OSX >= 10.7.
7493
b6d5a689
EZ
74942011-07-22 Eli Zaretskii <eliz@gnu.org>
7495
0f74f785
EZ
7496 Fix a significant slow-down of cursor motion with C-n, C-p,
7497 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7498 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7499 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7500 (next_element_from_buffer): Call compute_stop_pos_backwards to
7501 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7502 base_level_stop.
7503 (reseat): Don't look for prev_stop, as that could mean a very long
7504 run.
7505 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7506 <cached_disp_overlay_modiff>: Cache for last found display string
7507 position.
551918c1 7508 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7509 about the same buffer in the same area of character positions, and
7510 the buffer wasn't changed since the time the display string
7511 position was cached.
551918c1 7512
b2d0c91a
EZ
75132011-07-22 Eli Zaretskii <eliz@gnu.org>
7514
7515 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7516 is an integer, which is important for empty lines. (Bug#9149)
7517
043604ee
CY
75182011-07-22 Chong Yidong <cyd@stupidchicken.com>
7519
7520 * frame.c (Fmodify_frame_parameters): In tty case, update the
7521 default face if necessary (Bug#4238).
7522
da4adb04
CY
75232011-07-21 Chong Yidong <cyd@stupidchicken.com>
7524
7525 * editfns.c (Fstring_to_char): No need to explain what a character
7526 is in the docstring (Bug#6576).
7527
9abd0532
LMI
75282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7529
7530 * xml.c (parse_region): Make sure we always return a tree.
7531
36881d16
HK
75322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7533
7534 * xml.c (parse_region): If a document contains only comments,
7535 return that, too.
7536
1e98674d
LMI
75372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7538
7539 * xml.c (make_dom): Return comments, too.
7540
590bd467
PE
75412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7542
7543 Port to OpenBSD.
7544 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7545 and the surrounding thread.
7546 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7547 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7548 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7549 timer goes off.
7550 * s/openbsd.h (BROKEN_SIGIO): Define.
7551 * unexelf.c (unexec) [__OpenBSD__]:
7552 Don't update the .mdebug section of the Alpha COFF symbol table.
7553
f41628b2
LMI
75542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7555
7556 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7557 (bug#8460).
7558
b59b67c5
PE
75592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7560
15e3a074
PE
7561 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7562 This fixes some race conditions on the permissions of any newly
7563 created file.
7564
41bed37d
PE
7565 * alloc.c (valid_pointer_p): Use pipe, not open.
7566 This fixes some permissions issues when debugging.
7567
b59b67c5
PE
7568 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7569 If fchown fails to set both uid and gid, try to set just gid,
7570 as that is sometimes allowed. Adjust the file's mode to eliminate
7571 setuid or setgid bits that are inappropriate if fchown fails.
7572
925a6be7
SM
75732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7574
7575 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7576 to compare Lisp_Objects.
7577 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7578 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7579 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7580
52968808
AS
75812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7582
0a6a104b
AS
7583 * lread.c (read_integer): Unread even EOF character.
7584 (read1): Likewise. Properly record start position of symbol.
7585
52968808
AS
7586 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7587 symbol character follows.
7588
9e381cdd
PE
75892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7590
7591 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7592 This works around a problem with the previous change to Fcopy_file.
7593 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7594 and without this change, GCC might complain about discarding
7595 fchown's return value.
7596
b5641435
JB
75972011-07-16 Juanma Barranquero <lekktu@gmail.com>
7598
7599 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7600
a8031457
PE
76012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7602
7603 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7604
dd889327
LMI
76052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7606
750c33f7
LMI
7607 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7608 it's used from the C level.
7609
dd889327
LMI
7610 * process.c: Use the same condition for POLL_FOR_INPUT in both
7611 keyboard.c and process.c (bug#1858).
7612
87e86684
LM
76132011-07-09 Lawrence Mitchell <wence@gmx.li>
7614
7615 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7616 (Fgnutls_boot): Use it.
7617
64348f40
AS
76182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7619
7620 * doc.c (Fsubstitute_command_keys): Revert last change.
7621
1d698799
LMI
76222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7623
f863868c
LMI
7624 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7625 quotes the next character, and doesn't affect other longer
7626 sequences (bug#8935).
7627
1d698799
LMI
7628 * lread.c (syms_of_lread): Clarify that is isn't only
7629 `eval-buffer' and `eval-defun' that's affected by
7630 `lexical-binding' (bug#8460).
7631
aa4b6df6
EZ
76322011-07-15 Eli Zaretskii <eliz@gnu.org>
7633
7634 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7635 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7636
5d856da6
PE
76372011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7638
ad6042bb
PE
7639 Fix minor problems found by static checking.
7640 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7641 (elsz): Now a signed constant, not a size_t var. We prefer signed
7642 types to unsigned, to avoid integer comparison confusion. Without
7643 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7644 "cannot optimize loop, the loop counter may overflow", a symptom
7645 of the confusion.
f00bbb22 7646 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7647 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7648
6468f31c
LMI
76492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7650
49080b10
LMI
7651 * search.c (Fre_search_backward): Mention `case-fold-search' in
7652 all the re_search_* functions (bug#8138).
7653
6468f31c
LMI
7654 * keyboard.c (Fopen_dribble_file): Document when the file is
7655 closed (bug#8056).
7656
c965adc5
EZ
76572011-07-14 Eli Zaretskii <eliz@gnu.org>
7658
df9733bf
EZ
7659 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7660 bidi_cache_idx.
7661
0bb23927
EZ
7662 Support bidi reordering of display and overlay strings.
7663 * xdisp.c (compute_display_string_pos)
7664 (compute_display_string_end): Accept additional argument STRING.
7665 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7666 (reseat_to_string): Initialize bidi_it->string.s and
7667 bidi_it->string.schars.
7668 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7669 NULL (avoids a crash in bidi_paragraph_init).
7670 Initialize itb.string.lstring.
0bb23927
EZ
7671 (init_iterator): Call bidi_init_it only of a valid
7672 buffer position was specified. Initialize paragraph_embedding to
7673 L2R.
7674 (reseat_to_string): Initialize the bidi iterator.
7675 (display_string): If we need to ignore text properties of
7676 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7677 original value of -1 will not work with bidi.)
7678 (compute_display_string_pos): First arg is now struct
7679 `text_pos *'; all callers changed. Support display properties on
7680 Lisp strings.
7681 (compute_display_string_end): Support display properties on Lisp
7682 strings.
7683 (init_iterator, reseat_1, reseat_to_string): Initialize the
7684 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7685 when iterating on a string not from display properties).
640c8776
SM
7686 (compute_display_string_pos, compute_display_string_end):
7687 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7688 arrow keys.
7689 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7690 base_level_stop; instead, set base_level_stop to BEGV.
7691 Fixes crashes in vertical-motion.
0bb23927
EZ
7692 (next_element_from_buffer): Improve commentary for when
7693 the iterator is before prev_stop.
7694 (init_iterator): Initialize bidi_p from the default value of
7695 bidi-display-reordering, not from buffer-local value. Use the
7696 buffer-local value only if initializing for buffer iteration.
7697 (handle_invisible_prop): Support invisible properties on strings
7698 that are being bidi-reordered.
7699 (set_iterator_to_next): Support bidi reordering of C strings and
7700 Lisp strings.
7701 (next_element_from_string): Support bidi reordering of Lisp
7702 strings.
7703 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7704 (display_string): Support display of R2L glyph rows.
7705 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7706 (init_iterator): Don't initialize it->bidi_p for strings
7707 here.
7708 (reseat_to_string): Initialize it->bidi_p for strings here.
7709 (next_element_from_string, next_element_from_c_string)
7710 (next_element_from_buffer): Add xassert's for correspondence
7711 between IT's object being iterated and it->bidi_it.string
7712 structure.
7713 (face_before_or_after_it_pos): Support bidi iteration.
7714 (next_element_from_c_string): Handle the case of the first string
7715 character that is not the first one in the visual order.
7716 (get_visually_first_element): New function, refactored from common
7717 parts of next_element_from_buffer, next_element_from_string, and
7718 next_element_from_c_string.
7719 (tool_bar_lines_needed, redisplay_tool_bar)
7720 (display_menu_bar): Force left-to-right direction. Add a FIXME
7721 comment for making that be controlled by a user option.
7722 (push_it, pop_it): Save and restore the state of the
7723 bidi iterator. Save and restore the bidi_p flag.
7724 (pop_it): Iterate out of display property for string iteration as
7725 well.
7726 (iterate_out_of_display_property): Support iteration over strings.
7727 (handle_single_display_spec): Set up it->bidi_it for iteration
7728 over a display string, and call bidi_init_it.
7729 (handle_single_display_spec, next_overlay_string)
7730 (get_overlay_strings_1, push_display_prop): Set up the bidi
7731 iterator for displaying display or overlay strings.
7732 (forward_to_next_line_start): Don't use the shortcut if
7733 bidi-iterating.
7734 (back_to_previous_visible_line_start): If handle_display_prop
7735 pushed the iterator stack, restore the internal state of the bidi
7736 iterator by calling bidi_pop_it same number of times.
7737 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7738 and we are bidi-iterating, don't decrement the iterator position;
7739 instead, set the first_elt flag in the bidi iterator, to produce
7740 the same effect.
7741 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7742 (push_display_prop): xassert that we are iterating a buffer.
7743 (push_it, pop_it): Save and restore paragraph_embedding member.
7744 (handle_single_display_spec, next_overlay_string)
7745 (get_overlay_strings_1, reseat_1, reseat_to_string)
7746 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7747 correctly. Don't assume unibyte strings are not bidi-reordered.
7748 (compute_display_string_pos)
7749 (compute_display_string_end): Fix handling the case of C string.
7750 (push_it, pop_it): Save and restore from_disp_prop_p.
7751 (handle_single_display_spec, push_display_prop): Set the
7752 from_disp_prop_p flag.
7753 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7754 (pop_it): Call iterate_out_of_display_property only if we are
7755 popping after iteration over a string that came from a display
7756 property. Fix a typo in popping stretch info. Add an assertion
7757 for verifying that the iterator position is in sync with the bidi
7758 iterator.
7759 (handle_single_display_spec, get_overlay_strings_1)
7760 (push_display_prop): Fix initialization of paragraph direction for
7761 string when that of the parent object is not yet determined.
7762 (reseat_1): Call bidi_init_it to resync the bidi
7763 iterator with IT's position. (Bug#7616)
7764 (find_row_edges): If ROW->start.pos gives position
7765 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7766 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7767 Reset the from_disp_prop_p flag.
7768 (SAVE_IT, RESTORE_IT): New macros.
7769 (pos_visible_p, face_before_or_after_it_pos)
7770 (back_to_previous_visible_line_start)
7771 (move_it_in_display_line_to, move_it_in_display_line)
7772 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7773 (try_scrolling, redisplay_window, display_line): Use them when
7774 saving a temporary copy of the iterator and restoring it back.
7775 (back_to_previous_visible_line_start, reseat_1)
7776 (init_iterator): Empty the bidi cache "stack".
7777 (move_it_in_display_line_to): If iterator ended up at
7778 EOL, but we never saw any buffer positions smaller than
7779 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7780 motion in bidi-reordered lines.
7781 (move_it_in_display_line_to): Record prev_method and prev_pos
7782 immediately before the call to set_iterator_to_next. Fixes cursor
7783 motion in bidi-reordered lines with stretch glyphs and strings
7784 displayed in margins. (Bug#8133) (Bug#8867)
7785 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7786 TO_CHARPOS.
640c8776
SM
7787 (pos_visible_p): Support positions in bidi-reordered lines.
7788 Save and restore bidi cache.
0bb23927
EZ
7789
7790 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7791 (bidi_paragraph_info): Delete unused struct.
7792 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7793 (bidi_cache_start): New variable.
7794 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7795 to zero.
7796 (bidi_cache_fetch_state, bidi_cache_search)
7797 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7798 (bidi_cache_find, bidi_peek_at_next_level)
7799 (bidi_level_of_next_char, bidi_find_other_level_edge)
7800 (bidi_move_to_visually_next): Compare cache index with
7801 bidi_cache_start rather than with zero.
7802 (bidi_fetch_char): Accept new argument STRING; all callers
7803 changed. Support iteration over a string. Support strings with
7804 display properties. Support unibyte strings. Fix the type of
7805 `len' according to what STRING_CHAR_AND_LENGTH expects.
7806 (bidi_paragraph_init, bidi_resolve_explicit_1)
7807 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7808 (bidi_level_of_next_char, bidi_move_to_visually_next):
7809 Support iteration over a string.
0bb23927
EZ
7810 (bidi_set_sor_type, bidi_resolve_explicit_1)
7811 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7812 can now be zero (for strings); special values 0 and -1 were
7813 changed to -1 and -2, respectively.
7814 (bidi_char_at_pos): New function.
7815 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7816 Call it instead of FETCH_MULTIBYTE_CHAR.
7817 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7818 initialized to valid values.
7819 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7820 values.
7821 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7822 the test for valid cached positions. Fix the logic for looking up
7823 the sentinel state in the cache. GCPRO the Lisp string we are
7824 iterating.
7825 (bidi_push_it, bidi_pop_it): New functions.
7826 (bidi_initialize): Initialize the bidi cache start stack pointer.
7827 (bidi_cache_ensure_space): New function, refactored from part of
7828 bidi_cache_iterator_state. Don't assume the required size is just
7829 one BIDI_CACHE_CHUNK away.
7830 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7831 (bidi_count_bytes, bidi_char_at_pos): New functions.
7832 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7833 always valid if bidi_cache_idx is valid.
7834 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7835 is valid if it's going to be used.
7836 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7837 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7838 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7839 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7840 (bidi_find_other_level_edge, bidi_cache_start_stack):
7841 All variables related to cache indices are now EMACS_INT.
c965adc5 7842
0bb23927
EZ
7843 * dispextern.h (struct bidi_string_data): New structure.
7844 (struct bidi_it): New member `string'. Make flag members be 1-bit
7845 fields, and put them last in the struct.
640c8776
SM
7846 (compute_display_string_pos, compute_display_string_end):
7847 Update prototypes.
0bb23927
EZ
7848 (bidi_push_it, bidi_pop_it): Add prototypes.
7849 (struct iterator_stack_entry): New members bidi_p,
7850 paragraph_embedding, and from_disp_prop_p.
7851 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7852 (bidi_shelve_cache, bidi_unshelve_cache):
7853 Declare prototypes.
0bb23927
EZ
7854
7855 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7856 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7857 and vector-like objects.
7858
7859 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7860 cache around display iteration.
7861
7862 * window.c (Fwindow_end, window_scroll_pixel_based)
7863 (displayed_window_lines, Frecenter): Save and restore the bidi
7864 cache around display iteration.
7865
3bbd2265
LMI
78662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7867
7868 * editfns.c (Fdelete_region): Clarify the use of the named
7869 parameters (bug#6788).
7870
adc47434
MR
78712011-07-14 Martin Rudalics <rudalics@gmx.at>
7872
7873 * indent.c (Fvertical_motion): Set and restore w->pointm when
7874 saving and restoring the window's buffer (Bug#9006).
7875
837c31f8
LMI
78762011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7877
7878 * editfns.c (Fstring_to_char): Clarify just what is returned
7879 (bug#6576). Text by Eli Zaretskii.
7880
ac389d0c
JB
78812011-07-13 Juanma Barranquero <lekktu@gmail.com>
7882
7883 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7884
0be0ce47
EZ
78852011-07-13 Eli Zaretskii <eliz@gnu.org>
7886
7887 * buffer.c (mmap_find): Fix a typo.
7888
cd18e7e3
JB
78892011-07-13 Johan Bockgård <bojohan@gnu.org>
7890
7891 Fix execution of x selection hooks.
7892 * xselect.c (Qx_lost_selection_functions)
7893 (Qx_sent_selection_functions): New vars.
7894 (syms_of_xselect): DEFSYM them.
7895 (x_handle_selection_request): Pass Qx_sent_selection_functions
7896 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7897 (x_handle_selection_clear,x_clear_frame_selections):
7898 Pass Qx_lost_selection_functions rather than
7899 Vx_lost_selection_functions to Frun_hook_with_args.
7900
47ea7f44
PE
79012011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7902
ac389d0c 7903 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7904 The old code sometimes used this field without initializing it.
7905
47ea7f44
PE
7906 * alloc.c (gc_sweep): Don't read past end of array.
7907 In theory, the old code could also have corrupted Emacs internals,
7908 though it'd be very unlikely.
7909
bc985c87
AS
79102011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7911
7912 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7913 argument. (Bug#4026)
bc985c87 7914
0cf34688
LMI
79152011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7916
b3dadd76
LMI
7917 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7918 key" (bug#4257).
7919
0cf34688
LMI
7920 * window.c (Fset_window_start): Doc fix (bug#4199).
7921 (Fset_window_hscroll): Ditto.
7922
270768cd
PE
79232011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7924
077e3dda 7925 Fix minor new problems caught by GCC 4.6.1.
270768cd 7926 * term.c (init_tty): Remove unused local.
490011a6 7927 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7928 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7929 not used otherwise.
270768cd 7930
b1f58454
CY
79312011-07-12 Chong Yidong <cyd@stupidchicken.com>
7932
7933 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7934
22b9578d
LMI
79352011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7936
6e70ab07
LMI
7937 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7938 are the mini-buffer and the echo area (bug#3320).
7939
22b9578d
LMI
7940 * term.c (init_tty): Remove support for supdup, c10 and perq
7941 terminals, which are no longer supported (bug#1482).
7942
8974cc9f
JB
79432011-07-10 Johan Bockgård <bojohan@gnu.org>
7944
7945 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7946
a560d974
JD
79472011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7948
7949 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7950 for non-popups (Bug#3642).
7951
1dae0f0a
AS
79522011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7953
268c2c36 7954 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7955 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7956 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7957 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7958 * data.c (fmod): Likewise.
7959 * dispnew.c (swap_glyphs_in_rows): Likewise.
7960 * emacs.c (memory_warning_signal): Likewise.
7961 * floatfns.c (float_error): Likewise.
7962 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7963 (otf_open, font_otf_capability, generate_otf_features)
7964 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7965 Likewise.
7966 * image.c (pbm_read_file): Likewise.
7967 * indent.c (string_display_width): Likewise.
7968 * intervals.c (check_for_interval, search_for_interval)
7969 (inc_interval_count, count_intervals, root_interval)
7970 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7971 * lread.c (defalias): Likewise.
268c2c36 7972 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7973 * regex.c (set_image_of_range_1, set_image_of_range)
7974 (regex_grow_registers): Likewise.
7975 * sysdep.c (strerror): Likewise.
7976 * termcap.c (valid_filename_p, tprint, main): Likewise.
7977 * tparam.c (main): Likewise.
7978 * unexhp9k800.c (run_time_remap, save_data_space)
7979 (update_file_ptrs, read_header, write_header, calculate_checksum)
7980 (copy_file, copy_rest, display_header): Likewise.
7981 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7982 Likewise.
7983 * xdisp.c (check_it): Likewise.
7984 * xfaces.c (register_color, unregister_color, unregister_colors):
7985 Likewise.
7986 * xfns.c (print_fontset_result): Likewise.
7987 * xrdb.c (member, fatal, main): Likewise.
7988
99033785
PE
79892011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7990
7991 Fix minor problems found by static checking (Bug#9031).
7992 * chartab.c (char_table_set_range, map_sub_char_table):
7993 Remove unused locals.
7994 (uniprop_table): Now static.
7995 * composite.c (_work_char): Remove unused static var.
7996
9cb2ac56
JB
79972011-07-09 Juanma Barranquero <lekktu@gmail.com>
7998
7999 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8000
f25661f0
JD
80012011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8002
8003 * gtkutil.c (qttip_cb): Remove code without function.
8004
8278c4fe
EZ
80052011-07-09 Eli Zaretskii <eliz@gnu.org>
8006
8007 * w32.c (pthread_sigmask): New stub.
8008
1692ae2d 80092011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8010
8a6ebd58 8011 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8012 sigprocmask is portable only for single-threaded applications, and
8013 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8014 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8015 (LIBES): Use it.
8016 * callproc.c (Fcall_process):
8017 * process.c (create_process):
8018 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8019 Use pthread_sigmask, not sigprocmask.
123403e4 8020
1b854618
JD
80212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8022
8023 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8024 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8025 wrong (Bug#8591).
8026
3fe4b549
JD
80272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8028
0ce7e563
JD
8029 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8030 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8031 (xg_hide_tooltip): Fix comment.
8032
3fe4b549
JD
8033 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8034 in registerServicesMenuSendTypes.
8035 (validRequestorForSendType): Don't check ns_return_types.
8036
8037 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8038 ns_return_type.
8039
5df75e47
JR
80402011-07-08 Jason Rumney <jasonr@gnu.org>
8041
22610910
JR
8042 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8043 SH_SHOW for hidden windows (Bug#5482).
8044
5df75e47
JR
8045 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8046 frame struct members of non-existent frames (Bug#6284).
8047
699c10bd
JD
80482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8049
4393663b
JD
8050 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8051 variable firstTime not needed on OSX >= 10.6.
8052 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8053 >= 10.5. Use setKnobProportion, setDoubleValue.
8054
8055 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8056 (MAC_OS_X_VERSION_10_5): Define if not defined.
8057 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8058 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8059 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8060
8061 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8062 cString and lossyCString on OSX >= 10.4.
4393663b 8063
58179cce 8064 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8065 sizeToFit on OSX >= 10.2.
8066
8067 * nsimage.m (allocInitFromFile): Don't use deprecated method
8068 bestRepresentationForDevice on OSX >= 10.6.
8069
8070 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8071 to avoid warning.
8072
8073 * emacs.c: Declare unexec_init_emacs_zone.
8074
a63e0781
JD
8075 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8076
699c10bd
JD
8077 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8078
8079 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8080 on svcsMenu (Bug#8842).
8081
8082 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8083 ns_return_types.
8084 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8085
8086 * nsterm.m (QUTF8_STRING): Declare.
8087 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8088 (validRequestorForSendType): Return type is (id).
8089 Change indexOfObjectIdenticalTo to indexOfObject.
8090 Check if we have local selection before returning self (Bug#8842).
8091 (writeSelectionToPasteboard): Put local selection into paste board
8092 if we have a local selection (Bug#8842).
8093 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8094
8095 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8096 (ns_get_local_selection): Declare.
8097
54e10184
LMI
80982011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8099
9888ff71
LMI
8100 * keymap.c (describe_map_tree): Don't insert a double newline at
8101 the end of the buffer (bug#1169) and return whether we inserted
8102 something.
8103
54e10184
LMI
8104 * callint.c (Fcall_interactively): Change "reading args" to
8105 "providing args" to try to clarify what it does (bug#1010).
8106
15fa4783
KH
81072011-07-07 Kenichi Handa <handa@m17n.org>
8108
8109 * composite.c (composition_compute_stop_pos): Ignore a static
8110 composition starting before CHARPOS (Bug#8915).
8111
8112 * xdisp.c (handle_composition_prop): Likewise.
8113
a8815b00
EZ
81142011-07-07 Eli Zaretskii <eliz@gnu.org>
8115
8116 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8117 (Bug#9015)
8118
ef7b981d 81192011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8120
8121 * character.h (unicode_category_t): New enum type.
8122
8123 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8124 (Qchar_code_property_table): New variable.
8125 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8126 (UNIPROP_COMPRESSED_FORM_P): New macros.
8127 (char_table_ascii): Uncompress the compressed values.
8128 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8129 Uncompress the compressed values.
ac389d0c 8130 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8131 (char_table_ref_and_range): Uncompress the compressed values.
8132 (sub_char_table_set): New arg is_uniprop. Callers changed.
8133 Uncompress the compressed values.
8134 (sub_char_table_set_range): Args changed. Callers changed.
8135 (char_table_set_range): Adjuted for the above change.
8136 (map_sub_char_table): Delete args default_val and parent. Add arg
8137 top. Give decoded values to a Lisp function.
640c8776 8138 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8139 values to a Lisp function. Gcpro more variables.
8140 (uniprop_table_uncompress)
8141 (uniprop_decode_value_run_length): New functions.
8142 (uniprop_decoder, uniprop_decoder_count): New variables.
8143 (uniprop_get_decoder, uniprop_encode_value_character)
8144 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8145 New functions.
8146 (uniprop_encoder, uniprop_encoder_count): New variables.
8147 (uniprop_get_encoder, uniprop_table)
8148 (Funicode_property_table_internal, Fget_unicode_property_internal)
8149 (Fput_unicode_property_internal): New functions.
8150 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8151 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8152 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8153 char-code-property-alist.
8154
640c8776 8155 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8156 Vunicode_category_table.
8157
640c8776 8158 * font.c (font_range): Adjust for the change of
c805dec0
KH
8159 Vunicode_category_table.
8160
76b397fb
DN
81612011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8162
8163 * m/iris4d.h: Remove file, move contents ...
8164 * s/irix6-5.h: ... here.
8165
22b4128e
PE
81662011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8167
8168 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8169 * alloc.c (mark_buffer):
8170 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8171 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8172 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8173 This isn't true in general, and it's particularly not true
8174 if Emacs is configured with --with-wide-int.
8175 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8176 New macros, used in the buffer.c change.
8177
869795d6
JD
81782011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8179
8180 * xsettings.c: Use both GConf and GSettings if both are available.
8181 (store_config_changed_event): Add comment.
8182 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8183 (store_tool_bar_style_changed): New functions.
5e617bc2 8184 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8185 (struct xsettings): Move font inside HAVE_XFT.
8186 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8187 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8188 Move inside HAVE_XFT.
640c8776 8189 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8190 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8191 also.
8192 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8193 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8194 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8195 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8196 (parse_settings): Move check for font inside HAVE_XFT.
8197 (read_settings, apply_xft_settings): Add comment.
8198 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8199 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8200 call store_font_name_changed.
8201 (xft_settings_event): Add comment.
8202 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8203 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8204 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8205 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8206 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8207 (xsettings_get_system_font, xsettings_get_system_normal_font):
8208 Add comment.
869795d6 8209
d8ed26bd
PE
82102011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8211
8212 Random fixes. E.g., (random) never returned negative values.
8213 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8214 subseconds part to the entropy, as that's a bit more random.
8215 Prefer signed to unsigned, since the signedness doesn't matter and
8216 in general we prefer signed. When given a limit, use a
8217 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8218 latter isn't right if USE_2_TAGS_FOR_INTS.
8219 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8220 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8221
cabf1cac
SM
82222011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8223
8224 * textprop.c (text_property_stickiness):
8225 Obey Vtext_property_default_nonsticky.
8226 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8227 * w32fns.c (syms_of_w32fns):
8228 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8229
6e9b2be9
PE
82302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8231
8232 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8233 This is more efficient than Ffile_directory_p and avoids a minor race.
8234
90186c68
LMI
82352011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8236
7c301272
LMI
8237 * buffer.c (Foverlay_put): Say what the return value is
8238 (bug#7835).
8239
c4f2d8d4
LMI
8240 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8241 is a directory before asking whether to use the file name
8242 (bug#7564).
ad637907
LMI
8243 (barf_or_query_if_file_exists): Make the "File is a directory"
8244 error be more correct.
c4f2d8d4 8245
90186c68
LMI
8246 * fns.c (Frequire): Remove the mention of the .gz files, since
8247 that's installation-specific, but keep the mention of
8248 `get-load-suffixes'.
8249
da64016e
PE
82502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8251
8252 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8253 Report string overflow if the output is too long.
8254
7d47b580
JB
82552011-07-04 Juanma Barranquero <lekktu@gmail.com>
8256
a555cb87
JB
8257 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8258 (syms_of_gnutls): Remove duplicate DEFSYM for
8259 Qgnutls_bootprop_verify_hostname_error, an error for
8260 Qgnutls_bootprop_verify_error (which is no longer used).
8261
7d47b580
JB
8262 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8263 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8264 Also (re)move comments that are misplaced or no longer relevant.
8265
1e49bfab
LMI
82662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8267
8268 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8269
1485f4c0
CY
82702011-07-03 Chong Yidong <cyd@stupidchicken.com>
8271
8272 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8273 and background color parameters if they have been changed.
8274
a9ab721e
LMI
82752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8276
8277 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8278
cf7cff57
PE
82792011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8280
2e13213d
PE
8281 * xsettings.c (SYSTEM_FONT): Define only when used.
8282 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8283
cf7cff57
PE
8284 * keymap.c (access_keymap_1): Now static.
8285
7a8e04f7
CY
82862011-07-02 Chong Yidong <cyd@stupidchicken.com>
8287
8288 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8289 leave any prefix arg for the up event (Bug#1586).
8290
61352f62
LMI
82912011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8292
69bb1ef7
LMI
8293 * lread.c (syms_of_lread): Mention single symbols defined by
8294 `defvar' or `defconst' (bug#7154).
8295
61352f62 8296 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8297 (Frequire): Mention get-load-suffixes.
61352f62 8298
28545e04
MR
82992011-07-02 Martin Rudalics <rudalics@gmx.at>
8300
8301 * window.h (window): Remove clone_number slot.
8302 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8303 Remove.
8304 (make_parent_window, make_window, saved_window)
8305 (Fset_window_configuration, save_window_save): Don't deal with
8306 clone numbers.
8307 * buffer.c (Qclone_number): Remove declaration.
8308 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8309
3349e122
SM
83102011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8311
8312 Add multiple inheritance to keymaps.
8313 * keymap.c (Fmake_composed_keymap): New function.
8314 (Fset_keymap_parent): Simplify.
8315 (fix_submap_inheritance): Remove.
8316 (access_keymap_1): New function extracted from access_keymap to handle
8317 embedded parents and handle lists of maps.
8318 (access_keymap): Use it.
8319 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8320 (Fcopy_keymap): Handle embedded parents.
8321 (Fcommand_remapping, define_as_prefix): Simplify.
8322 (Fkey_binding): Simplify.
8323 (syms_of_keymap): Move minibuffer-local-completion-map,
8324 minibuffer-local-filename-completion-map,
8325 minibuffer-local-must-match-map, and
8326 minibuffer-local-filename-must-match-map to Elisp.
8327 (syms_of_keymap): Defsubr make-composed-keymap.
8328 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8329 (parse_menu_item): Trivial simplification.
8330
3279eb87
GM
83312011-07-01 Glenn Morris <rgm@gnu.org>
8332
8333 * Makefile.in (SETTINGS_LIBS): Fix typo.
8334
4550efdf
KI
83352011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8336
8337 * coding.c (Fencode_coding_string): Record the last coding system
8338 used, as the function doc string says (bug#8738).
8339
0949d2b6
JD
83402011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8341
8342 * xsettings.c (store_monospaced_changed): Take new font as arg and
8343 check for change against current_mono_font.
8344 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8345 (emacs_settings_constructor, emacs_settings_get_property)
8346 (emacs_settings_set_property, emacs_settings_class_init)
8347 (emacs_settings_init, gsettings_obj): Remove.
8348 (something_changedCB): New function for HAVE_GSETTINGS.
8349 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8350 with value as argument.
8351 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8352 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8353 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8354 "changed".
8355
8356 * xgselect.c: Add defined (HAVE_GSETTINGS).
8357 (xgselect_initialize): Ditto.
8358
8359 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8360 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8361 xg_select.
8362
bbc6b304
PE
83632011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8364
8365 * eval.c (struct backtrace): Simplify and port the data structure.
8366 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8367 signed bit field, as this assumption is not portable and it makes
8368 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8369 "char debug_on_exit : 1" as this is not portable either; instead,
8370 use the portable "unsigned int debug_on_exit : 1". Remove unused
8371 member evalargs. Remove obsolete comments about cc bombing out.
8372
9851bfc5
JD
83732011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8374
51bb811f 8375 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8376 Let HAVE_GSETTINGS override HAVE_GCONF.
8377 (store_monospaced_changed): New function.
8378 (EMACS_SETTINGS): A new type derived from GObject to handle
8379 GSettings notifications.
8380 (emacs_settings_constructor, emacs_settings_get_property)
8381 (emacs_settings_set_property, emacs_settings_class_init):
8382 New functions.
8383 (gsettings_client, gsettings_obj): New variables.
8384 (GSETTINGS_SCHEMA): New define.
8385 (something_changedCB): Call store_monospaced_changed.
8386 (init_gsettings): New function.
8387 (xsettings_initialize): Call init_gsettings.
8388 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8389 to NULL.
8390
640c8776 8391 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8392 GCONF_CFLAGS/LIBS.
8393
5386012d
MR
83942011-06-29 Martin Rudalics <rudalics@gmx.at>
8395
8396 * window.c (resize_root_window, grow_mini_window)
8397 (shrink_mini_window): Rename Qresize_root_window to
8398 Qwindow_resize_root_window and Qresize_root_window_vertically to
8399 Qwindow_resize_root_window_vertically.
8400
f13e0b08
PE
84012011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8402
8403 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8404
94515237
JB
84052011-06-27 Juanma Barranquero <lekktu@gmail.com>
8406
8407 * makefile.w32-in: Redesign dependencies so they reflect more
8408 clearly which files are directly included by each source file,
8409 and not through other includes.
8410
e43b6e43
MR
84112011-06-27 Martin Rudalics <rudalics@gmx.at>
8412
8413 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8414 (sort_overlays, overlay_strings): When an overlay's clone number
8415 matches the window's clone number process the overlay even if
8416 the overlay's window property doesn't match the current window.
8417
d68443dc
MR
8418 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8419 (Fwindow_hchild): Rename to Fwindow_left_child.
8420 (Fwindow_next): Rename to Fwindow_next_sibling.
8421 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8422 (resize_window_check): Rename to window_resize_check.
8423 (resize_window_apply): Rename to window_resize_apply.
8424 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8425 (Fdelete_other_windows_internal, resize_frame_windows)
8426 (Fsplit_window_internal, Fdelete_window_internal)
8427 (grow_mini_window, shrink_mini_window)
8428 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8429
c7e73be5
JD
84302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8431
8432 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8433 (emacs_fixed_set_min_size): Remove.
8434 (emacs_fixed_new): Take frame as argument.
8435
8436 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8437 (_EmacsFixedPrivate): Remove minwidth/height.
8438 Add struct frame *f.
8439 (emacs_fixed_init): Initialize priv->f.
8440 (get_parent_class, emacs_fixed_set_min_size): Remove.
8441 (emacs_fixed_new): Set priv->f to argument.
8442 (emacs_fixed_get_preferred_width)
8443 (emacs_fixed_get_preferred_height): Use min_width/height from
8444 frames size_hint to set minimum and natural (Bug#8919).
8445 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8446 and use min_width/height from frames size_hint to set
8447 min_width/height (Bug#8919).
8448
8449 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8450 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8451 Fix indentation.
c7e73be5 8452
cf99dcf8
EZ
84532011-06-26 Eli Zaretskii <eliz@gnu.org>
8454
8455 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8456 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8457 called at ZV.
8458
029529ac
CY
84592011-06-26 Chong Yidong <cyd@stupidchicken.com>
8460
8461 * process.c (wait_reading_process_output): Bypass select if
8462 waiting for a cell while ignoring keyboard input, and input is
8463 pending. Suggested by Jan Djärv (Bug#8869).
8464
7a7ef429
PE
84652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8466
8467 Use gnulib's dup2 module instead of rolling our own.
8468 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8469
11fdef7d 84702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8471
8472 * dispnew.c (scrolling_window): Before scrolling, turn off a
8473 mouse-highlight in the window being scrolled.
8474
cd3520a4
JB
84752011-06-24 Juanma Barranquero <lekktu@gmail.com>
8476
8477 Move DEFSYM to lisp.h and use everywhere.
8478
8479 * character.h (DEFSYM): Move declaration...
8480 * lisp.h (DEFSYM): ...here.
8481
8482 * gnutls.c:
8483 * minibuf.c:
8484 * w32menu.c:
8485 * w32proc.c:
8486 * w32select.c: Don't include character.h.
8487
8488 * alloc.c (syms_of_alloc):
8489 * buffer.c (syms_of_buffer):
8490 * bytecode.c (syms_of_bytecode):
8491 * callint.c (syms_of_callint):
8492 * casefiddle.c (syms_of_casefiddle):
8493 * casetab.c (init_casetab_once):
8494 * category.c (init_category_once, syms_of_category):
8495 * ccl.c (syms_of_ccl):
8496 * cmds.c (syms_of_cmds):
8497 * composite.c (syms_of_composite):
8498 * dbusbind.c (syms_of_dbusbind):
8499 * dired.c (syms_of_dired):
8500 * dispnew.c (syms_of_display):
8501 * doc.c (syms_of_doc):
8502 * editfns.c (syms_of_editfns):
8503 * emacs.c (syms_of_emacs):
8504 * eval.c (syms_of_eval):
8505 * fileio.c (syms_of_fileio):
8506 * fns.c (syms_of_fns):
8507 * frame.c (syms_of_frame):
8508 * fringe.c (syms_of_fringe):
8509 * insdel.c (syms_of_insdel):
8510 * keymap.c (syms_of_keymap):
8511 * lread.c (init_obarray, syms_of_lread):
8512 * macros.c (syms_of_macros):
8513 * msdos.c (syms_of_msdos):
8514 * print.c (syms_of_print):
8515 * process.c (syms_of_process):
8516 * search.c (syms_of_search):
8517 * sound.c (syms_of_sound):
8518 * syntax.c (init_syntax_once, syms_of_syntax):
8519 * terminal.c (syms_of_terminal):
8520 * textprop.c (syms_of_textprop):
8521 * undo.c (syms_of_undo):
8522 * w32.c (globals_of_w32):
8523 * window.c (syms_of_window):
8524 * xdisp.c (syms_of_xdisp):
8525 * xfaces.c (syms_of_xfaces):
8526 * xfns.c (syms_of_xfns):
8527 * xmenu.c (syms_of_xmenu):
8528 * xsettings.c (syms_of_xsettings):
8529 * xterm.c (syms_of_xterm): Use DEFSYM.
8530
4228cf16
TZ
85312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8532
cd3520a4 8533 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8534
7fcccf1e
PE
85352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8536
7efb4e0e
PE
8537 Integer and buffer overflow fixes (Bug#8873).
8538
ff5844ad
PE
8539 * print.c (printchar, strout): Check for string overflow.
8540 (PRINTPREPARE, printchar, strout):
8541 Don't set size unless allocation succeeds.
8542
90532f02
PE
8543 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8544 for sizes. Check for string overflow more accurately.
8545 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8546
6d84508d
PE
8547 * macros.c: Integer and buffer overflow fixes.
8548 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8549 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8550 Use ptrdiff_t, not int, for sizes.
8551 Don't increment bufsize until after realloc succeeds.
8552 Check for size-calculation overflow.
8553 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8554
437b2cb4
PE
8555 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8556
8b9ac8b4
PE
8557 * lread.c: Integer overflow fixes.
8558 (read_integer): Radix is now EMACS_INT, not int,
8559 to improve quality of diagnostics for out-of-range radices.
8560 Calculate buffer size correctly for out-of-range radices.
8561 (read1): Check for integer overflow in radices, and in
8562 read-circle numbers.
82cb60d3
PE
8563 (read_escape): Avoid int overflow.
8564 (Fload, openp, read_buffer_size, read1)
8565 (substitute_object_recurse, read_vector, read_list, map_obarray):
8566 Use ptrdiff_t, not int, for sizes.
8567 (read1): Use EMACS_INT, not int, for sizes.
20270765 8568 Check for size overflow.
8b9ac8b4 8569
7fcccf1e
PE
8570 * image.c (cache_image): Check for size arithmetic overflow.
8571
bfbbd7e7
PE
8572 * lread.c: Integer overflow issues.
8573 (saved_doc_string_size, saved_doc_string_length)
8574 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8575 Now ptrdiff_t, not int.
8576 (read1): Don't assume doc string length fits in int. Check for
8577 out-of-range doc string lengths.
8578 (read_list): Don't assume file position fits in int.
39019e54 8579 (read_escape): Check for hex character overflow.
bfbbd7e7 8580
4e323265
LL
85812011-06-22 Leo Liu <sdl.web@gmail.com>
8582
8583 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8584 Move to minibuffer.el.
8585
85fece3e
PE
85862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8587
20b84ce9 8588 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8589 The following patches are for when GLYPH_DEBUG && !XASSERT.
8590 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8591 * dispnew.c (flush_stdout):
8592 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8593 Mark as externally visible.
8594 * dispnew.c (check_window_matrix_pointers): Now static.
8595 * dispnew.c (window_to_frame_vpos):
8596 * xfns.c (unwind_create_frame):
8597 * xterm.c (x_check_font): Remove unused local.
8598 * scroll.c (CHECK_BOUNDS):
8599 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8600 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8601 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8602 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8603 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8604 Now static.
8605 (debug_method_add): Use va_list and vsprintf rather than relying
8606 on undefined behavior with wrong number of arguments.
8607 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8608 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8609 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8610 since we're not interested in debugging glyphs with old libraries.
8611 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8612 GCC 4.6.0's static checking.
8613
0766b489
PE
86142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8615
31fd4b32
PE
8616 Integer overflow and signedness fixes (Bug#8873).
8617 A few related buffer overrun fixes, too.
8618
b79e8648
PE
8619 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8620
0766b489
PE
8621 * dispextern.h (struct face.stipple):
8622 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8623 (x_bitmap_mask, x_allocate_bitmap_record)
8624 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8625 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8626 (x_create_bitmap_from_xpm_data):
8627 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8628 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8629 (.bitmaps_last):
8630 * xfaces.c (load_pixmap):
8631 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8632 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8633 (.bitmaps_last, struct x_output.icon_bitmap):
8634 Use ptrdiff_t, not int, for bitmap indexes.
8635 (x_allocate_bitmap_record): Check for size overflow.
8636 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8637
b081724f
PE
8638 Use ptrdiff_t, not int, for overlay counts.
8639 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8640 * editfns.c (overlays_around, get_pos_property):
8641 * textprop.c (get_char_property_and_overlay):
8642 * xdisp.c (next_overlay_change, note_mouse_highlight):
8643 * xfaces.c (face_at_buffer_position):
21514da7
PE
8644 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8645 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8646 (Fnext_overlay_change, Fprevious_overlay_change)
8647 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8648 Use ptrdiff_t, not int, for sizes.
21514da7 8649 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8650
3de73e5e
PE
8651 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8652
2606c57b
PE
8653 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8654 (x_session_initialize): Do not assume string length fits in int.
8655
aaafe47a
PE
8656 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8657 This is unlikely, but can occur if DPI is outlandish.
8658
2674ddc8 8659 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8660 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8661
28154962
PE
8662 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8663 * xrdb.c (magic_file_p, search_magic_path):
8664 Omit last arg SUFFIX; it was always 0. All callers changed.
8665 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8666
7de51af5
PE
8667 * xfont.c (xfont_match): Avoid need for strlen.
8668
25ed6cc3
PE
8669 * xfns.c: Don't assume strlen fits in int.
8670 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8671
4eab31dd
PE
8672 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8673 not unsigned long, as we prefer signed integers. All callers changed.
8674 Detect integer overflow in repeat count.
8675 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8676 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8677
171e2a58
PE
8678 * termcap.c: Don't assume sizes fit in int and never overflow.
8679 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8680 (gobble_line): Check for size-calculation overflow.
8681
ad39faca 8682 * minibuf.c (Fread_buffer):
6e5bb2dc 8683 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8684 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8685 Don't assume string length fits in int.
8686
52c61c22 8687 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8688 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8689
b5b8c9e5
PE
8690 * font.c: Don't assume string length fits in int.
8691 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8692 Use ptrdiff_t, not int.
ccd6111c
PE
8693 (font_intern_prop): Don't assume string length fits in int.
8694 Don't assume integer property fits in fixnum.
8695 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8696
882f0d81 8697 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8698 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8699 Reformulate so as not to need the command string.
8700 Invoke gzip -cd rather than gunzip, as it's more portable.
8701 (lock_info_type, lock_file_1, lock_file):
8702 Don't assume pid_t and time_t fit in unsigned long.
8703 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8704 (current_lock_owner): Prefer signed type for sizes.
8705 Use memcpy, not strncpy, where memcpy is what is really wanted.
8706 Don't assume (via atoi) that time_t and pid_t fit in int.
8707 Check for time_t and/or pid_t out of range, e.g., via a network share.
8708 Don't alloca where an auto var works fine.
8709
93f4cf88
PE
8710 * fileio.c: Fix some integer overflow issues.
8711 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8712 Don't assume string length fits in int.
8713 (directory_file_name): Don't assume string length fits in long.
8714 (make_temp_name): Don't assume pid fits in int, or that its print
8715 length is less than 20.
8716
f3e92b69
PE
8717 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8718
1bfdaf10
PE
8719 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8720
35016e9a
PE
8721 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8722
3d1e65a1
PE
8723 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8724 We prefer signed integers, even for size calculations.
8725
0b963a93
PE
8726 * emacs.c: Don't assume string length fits in 'int'.
8727 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8728 (main): Don't invoke strlen when not needed.
8729
573f4b54
PE
8730 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8731 (XD_DEBUG_MESSAGE): Don't waste a byte.
8732
989f33ba
PE
8733 * callproc.c (getenv_internal_1, getenv_internal)
8734 (Fgetenv_internal):
965d34eb
PE
8735 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8736
e4d29b33
PE
8737 * lread.c (invalid_syntax): Omit length argument.
8738 All uses changed. This doesn't fix a bug, but it simplifies the
8739 code away from its former Hollerith-constant appearance, and it's
8740 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8741 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8742
eb49b136
PE
8743 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8744 This didn't break anything, but it didn't help either.
8745 It's confusing to put a bogus integer in a place where the actual
8746 value does not matter.
9f62aeb1 8747 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8748 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8749
15375a22
PE
8750 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8751 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8752 implementation.
b61cc01c
PE
8753 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8754 We prefer signed types, and the value cannot exceed the EMACS_INT
8755 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8756 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8757 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8758 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8759
53b2623d
PE
8760 * indent.c (sane_tab_width): New function.
8761 (current_column, scan_for_column, Findent_to, position_indentation)
8762 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8763 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8764
51cab52b 8765 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8766
f2ed8a70
PE
8767 * lisp.h (lint_assume): New macro.
8768 * composite.c (composition_gstring_put_cache):
8769 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8770
abe80cc6
PE
8771 * editfns.c, insdel.c:
8772 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8773
b02c740e
PE
8774 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8775
ebc96716
PE
8776 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8777
b4e50fa0 8778 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8779 Use much-faster test for byte-length change.
311d5d7c 8780 Don't assume string byte-length fits in 'int'.
a4cf38e4 8781 Check that character arg fits in 'int'.
85461888 8782 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8783
c0c1ee9f
PE
8784 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8785
a498d7f4
PE
8786 * fns.c (concat): Catch string overflow earlier.
8787 Do not rely on integer wraparound.
8788
51cab52b
PE
8789 * dispextern.h (struct it.overlay_strings_charpos)
8790 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8791 * xdisp.c (forward_to_next_line_start)
8792 (back_to_previous_visible_line_start)
8793 (reseat_at_next_visible_line_start, next_element_from_buffer):
8794 Don't arbitrarily truncate the value of 'selective' to int.
8795
76031fad
PE
8796 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8797
5eb55db9
PE
8798 * composite.c: Don't truncate sizes to 'int'.
8799 (composition_gstring_p, composition_reseat_it)
8800 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8801 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8802 not EMACS_UINT, for indexes.
5eb55db9 8803
0703a717
PE
8804 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8805
d6202519
PE
8806 * buffer.c: Include <verify.h>.
8807 (struct sortvec.priority, struct sortstr.priority):
8961a454 8808 Now EMACS_INT, not int.
c20998a7 8809 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8810 (struct sortstr.size, record_overlay_string)
8811 (struct sortstrlist.size, struct sortlist.used):
8812 Don't truncate size to int.
8813 (record_overlay_string): Check for size-calculation overflow.
d6202519 8814 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8815
d5a19415
JM
88162011-06-22 Jim Meyering <meyering@redhat.com>
8817
029529ac 8818 Don't leak an XBM-image-sized buffer
d5a19415
JM
8819 * image.c (xbm_load): Free the image buffer after using it.
8820
a9041e6c
PE
88212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8822
8823 Port to Sun C.
8824 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8825 that Sun C diagnosed.
8826 * fns.c (secure_hash): Fix pointer signedness issue.
8827 * intervals.c (static_offset_intervals): New function.
8828 (offset_intervals): Use it.
8829
7f3f739f
LL
88302011-06-21 Leo Liu <sdl.web@gmail.com>
8831
8832 * deps.mk (fns.o):
8833 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8834 sha512.h.
8835
8836 * fns.c (secure_hash): Rename from crypto_hash_function and change
8837 the first arg to accept symbols.
5b66d427 8838 (Fsecure_hash): New primitive.
7f3f739f
LL
8839 (syms_of_fns): New symbols.
8840
76147d94
DD
88412011-06-20 Deniz Dogan <deniz@dogan.se>
8842
8843 * process.c (Fset_process_buffer): Clarify return value in
8844 docstring.
8845
7d7d0045
CY
88462011-06-18 Chong Yidong <cyd@stupidchicken.com>
8847
8848 * dispnew.c (add_window_display_history): Use BVAR.
8849
8850 * xdisp.c (debug_method_add): Use BVAR.
8851 (check_window_end, dump_glyph_matrix, dump_glyph)
8852 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8853
8854 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8855 Likewise.
8856
8857 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8858 check till after the cache is created in init_frame_faces.
8859
ff2bc410
SM
88602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8861
8862 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8863
28177add
PE
88642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8865
dd3482fe
PE
8866 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8867 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8868 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8869
393d71f3 8870 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8871 * fileio.c (Finsert_file_contents):
8872 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8873 Remove the old (too-loose) buffer overflow checks.
8874 They weren't needed, since make_gap checks for buffer overflow.
8875 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8876 The old code merely checked for Emacs fixnum overflow, and relied
8877 on undefined (wraparound) behavior. The new code avoids undefined
8878 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8879
2e6813b0 8880 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8881 Tune. Don't use wider integers than needed. Don't use alloca.
8882 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8883
599a9e4f
PE
8884 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8885
99561444
PE
8886 * insdel.c, lisp.h (buffer_overflow): New function.
8887 (insert_from_buffer_1, replace_range, replace_range_2):
8888 * insdel.c (make_gap_larger):
8889 * editfns.c (Finsert_char):
8890 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8891
28177add
PE
8892 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8893
e69dafad
PE
88942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8895
4baa020d 8896 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8897
b1c46f02
PE
8898 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8899 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8900
e69dafad
PE
8901 * fileio.c: Don't assume EMACS_INT fits in off_t.
8902 (emacs_lseek): New static function.
8903 (Finsert_file_contents, Fwrite_region): Use it.
8904 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8905
566684ea
PE
8906 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8907
e6966cd6
PE
8908 * fns.c: Don't overflow int when computing a list length.
8909 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8910 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8911 truncation on 64-bit hosts. Check for QUIT every
8912 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8913 faster and is responsive enough.
8914 (Flength): Report an error instead of overflowing an integer.
8915 (Fsafe_length): Return a float if the value is not representable
8916 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8917 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8918 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8919
dd0b0efb
PE
8920 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8921 (header_size, word_size): New constants.
8922 (allocate_vectorlike): Don't check size overflow here.
8923 (allocate_vector): Check it here instead, since this is the only
8924 caller of allocate_vectorlike that could cause overflow.
8925 Check that the new vector's length is representable as a fixnum.
8926
86fe5cfe
PE
8927 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8928 The previous code was bogus. For example, next_almost_prime (32)
8929 returned 39, which is undesirable as it is a multiple of 3; and
8930 next_almost_prime (24) returned 25, which is a multiple of 5 so
8931 why was the code bothering to check for multiples of 7?
8932
80e88859
PE
8933 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8934
4a2f0ad6
PE
8935 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8936
f66c7cf8
PE
8937 Variadic C functions now count arguments with ptrdiff_t.
8938 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8939 Back then I didn't know that the Emacs coding style prefers signed int.
8940 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8941 were being counted with int, which may truncate counts on 64-bit
8942 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8943 * lisp.h (struct Lisp_Subr.function.aMANY)
8944 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8945 Arg counts are now ptrdiff_t, not size_t.
8946 All variadic functions and their callers changed accordingly.
8947 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8948 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8949 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8950 * callint.c (Fcall_interactively): Check arg count for overflow,
8951 to avoid potential buffer overrun. Use signed char, not 'int',
8952 for 'varies' array, so that we needn't bother to check its size
8953 calculation for overflow.
8954 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8955 * eval.c (apply_lambda):
8956 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8957 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8958 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8959
a1759b76
PE
8960 * callint.c (Fcall_interactively): Don't use index var as event count.
8961
d96be9fc
PE
8962 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8963 * mem-limits.h (SIZE): Remove; no longer used.
8964
a690a978 8965 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8966
578c21e6
PE
8967 Remove unnecessary casts.
8968 * xterm.c (x_term_init):
8969 * xfns.c (x_set_border_pixel):
8970 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8971 These aren't needed now that we assume ANSI C.
8972
96f53c6c
PE
8973 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8974 It's more likely to cause problems (due to unsigned overflow)
8975 than to cure them.
8976
83c77d31
PE
8977 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8978
ee2079f1
PE
8979 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8980
6da65536
PE
8981 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8982
7147c4a4
PE
8983 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8984
193e32d9
PE
8985 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8986
e5533da6
PE
8987 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8988
9910e595
PE
8989 GLYPH_CODE_FACE returns EMACS_INT, not int.
8990 * dispextern.h (merge_faces):
8991 * xfaces.c (merge_faces):
01103c44
PE
8992 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8993 Don't assume EMACS_INT fits in int.
9910e595 8994
2638320e
PE
8995 * character.h (CHAR_VALID_P): Remove unused parameter.
8996 * fontset.c, lisp.h, xdisp.c: All uses changed.
8997
045eb8d9
PE
8998 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8999
c1f134b5
PE
9000 * fns.c (concat): Minor tuning based on overflow analysis.
9001 This doesn't fix any bugs. Use int to hold character, instead
9002 of constantly refetching from Emacs object. Use XFASTINT, not
9003 XINT, for value known to be a character. Don't bother comparing
9004 a single byte to 0400, as it's always less.
9005
395fcb93 9006 * floatfns.c (Fexpt):
327eeec8
PE
9007 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9008
abbd3d23
PE
9009 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9010 for characters.
9011
684a03ef
PE
9012 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9013
0fed43f3
PE
9014 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9015 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9016 incorrectly succeed when S was a string, because 4294967386 was
9017 truncated before it was used.
9018
8fd02eb7
PE
9019 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9020 Otherwise, an out-of-range integer could cause undefined behavior
9021 on a 64-bit host.
9022
f8c86b69
PE
9023 * composite.c: Use int, not EMACS_INT, for characters.
9024 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9025 EMACS_INT, for values that are known to be in character range.
9026 This doesn't fix any bugs but is the usual style inside Emacs and
9027 may generate better code on 32-bit machines.
9028
34206dd2
PE
9029 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9030 This is for reasons similar to the recent CHAR_STRING fix.
9031 * charset.c (Fencode_char): Check that character arg is actually
9032 a character. Pass an int to ENCODE_CHAR.
9033 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9034 wider than 'int', as a compile-time check to prevent future regressions
9035 in this area.
9036
c5958d4c 9037 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9038
9039 Make sure a 64-bit char is never passed to CHAR_STRING.
9040 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9041 by silently ignoring the top 32 bits, allowing some values
9042 that were far too large to be valid characters.
9043 * character.h: Include <verify.h>.
9044 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9045 arguments are no wider than unsigned, as a compile-time check
9046 to prevent future regressions in this area.
9047 * data.c (Faset):
01103c44 9048 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9049 (Fsubst_char_in_region):
9050 * fns.c (concat):
9051 * xdisp.c (decode_mode_spec_coding):
9052 Adjust to CHAR_STRING's new requirement.
9053 * editfns.c (Finsert_char, Fsubst_char_in_region):
9054 * fns.c (concat): Check that character args are actually
9055 characters. Without this test, these functions did the wrong
9056 thing with wildly out-of-range values on 64-bit hosts.
9057
d37ca623
PE
9058 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9059 These casts should not be needed on 32-bit hosts, either.
9060 * keyboard.c (read_char):
9061 * lread.c (Fload): Remove casts to unsigned.
9062
ea204efb
PE
9063 * lisp.h (UNSIGNED_CMP): New macro.
9064 This fixes comparison bugs on 64-bit hosts.
9065 (ASCII_CHAR_P): Use it.
9066 * casefiddle.c (casify_object):
01103c44 9067 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9068 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9069 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9070 * dispextern.h (FACE_FROM_ID):
9071 * keyboard.c (read_char): Use UNSIGNED_CMP.
9072
41cb286c
PE
9073 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9074 not to EMACS_INT, to avoid GCC warning.
9075
4a1b9832
PE
9076 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9077
55daad71
PE
9078 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9079 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9080 isn't needed on 32-bit machines.
8f95c75c 9081
01103c44
PE
9082 * buffer.c (Fgenerate_new_buffer_name):
9083 Use EMACS_INT for count, not int.
0ceccced 9084 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9085
9086 * data.c (Qcompiled_function): Now static.
9087
c6f072e7
PE
9088 * window.c (window_body_lines): Now static.
9089
20ce5912
PE
9090 * image.c (gif_load): Rename local to avoid shadowing.
9091
9c4c5f81
PE
9092 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9093 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9094 * alloc.c (make_save_value): Integer argument is now of type
9095 ptrdiff_t, not int.
9096 (mark_object): Use ptrdiff_t, not int.
9097 * lisp.h (pD): New macro.
9098 * print.c (print_object): Use it.
9099
c0c5c8ae
PE
9100 * alloc.c: Use EMACS_INT, not int, to count objects.
9101 (total_conses, total_markers, total_symbols, total_vector_size)
9102 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9103 (total_free_floats, total_floats, total_free_intervals)
9104 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9105 Now EMACS_INT, not int. All uses changed.
9106 (Fgarbage_collect): Compute overall total using a double, so that
9107 integer overflow is less likely to be a problem. Check for overflow
9108 when converting back to an integer.
5a25e253
PE
9109 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9110 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9111 These were 'int' variables that could overflow on 64-bit hosts;
9112 they were never used, so remove them instead of repairing them.
211a0b2a 9113 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9114 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9115 Previously, this ceilinged at INT_MAX, but that doesn't work on
9116 64-bit machines.
e46bb31a 9117 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9118
c78baabf 9119 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9120 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9121 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9122 when a (possibly-narrower) signed value would do just as well.
9123 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9124
c9d624c6
PE
9125 * alloc.c: Catch some string size overflows that we were missing.
9126 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9127 for convenience in STRING_BYTES_MAX.
9128 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9129 The definition here is exact; the one in lisp.h was approximate.
9130 (allocate_string_data): Check for string overflow. This catches
9131 some instances we weren't catching before. Also, it catches
9132 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9133 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9134 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9135
c9d624c6
PE
9136 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9137 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9138 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9139
353032ce
PE
9140 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9141
2bccce07
PE
9142 * alloc.c (Fmake_string): Check for out-of-range init.
9143
0ac30604
SM
91442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9145
9146 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9147
c195f2de
JD
91482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9149
9150 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9151 xg_get_default_scrollbar_width.
9152
9153 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9154 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9155 (style_changed_cb): Call update_theme_scrollbar_width and call
9156 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9157 all frames (Bug#8505).
9158 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9159 Call gtk_window_set_resizable if HAVE_GTK3.
9160 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9161 and height if HAVE_GTK3 (Bug#8505).
9162 (scroll_bar_width_for_theme): New variable.
9163 (update_theme_scrollbar_width): New function.
9164 (xg_get_default_scrollbar_width): Move code to
9165 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9166 (xg_initialize): Call update_theme_scrollbar_width.
9167
9168 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9169
9170 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9171
e10ac9f1
MR
91722011-06-12 Martin Rudalics <rudalics@gmx.at>
9173
9174 * frame.c (make_frame): Call other_buffer_safely instead of
9175 other_buffer.
9176
9177 * window.c (temp_output_buffer_show): Call display_buffer with
9178 second argument Vtemp_buffer_show_specifiers and reset latter
9179 immediately after the call.
9180 (Vtemp_buffer_show_specifiers): New variable.
9181 (auto_window_vscroll_p, next_screen_context_lines)
9182 (Vscroll_preserve_screen_position): Remove leading asterisks from
9183 doc-strings.
9184
2d3c217e 91852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9186
7b7f97e8 9187 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9188 * buffer.c (Qclone_number): Remove for now, as it's unused.
9189 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9190 (record_buffer): Remove unused local.
9191 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9192 (set_frame_buffer_list): Remove; unused.
9193 * frame.h (other_visible_frames): Remove decl.
9194 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9195 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9196 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9197 if HAVE_GPM.
9198 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9199 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9200 Define only if HAVE_GPM.
9201 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9202 (update_hints_inhibit): Remove; never set. All uses removed.
9203 * widgetprv.h (emacsFrameClassRec): Remove decl.
9204 * window.c (delete_deletable_window): Now returns void, since it
9205 wasn't returning anything.
9206 (compare_window_configurations): Remove unused locals.
9207 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9208 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9209 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9210 the same widths as pointers. This follows up on the 2011-05-06 patch.
9211 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9212 * xterm.h: Likewise.
9213 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9214
1384b89e
JB
92152011-06-12 Juanma Barranquero <lekktu@gmail.com>
9216
9217 * makefile.w32-in: Update dependencies.
9218 (LISP_H): Add lib/intprops.h.
9219
1100a63c
CY
92202011-06-11 Chong Yidong <cyd@stupidchicken.com>
9221
9222 * image.c (gif_load): Add animation frame delay to the metadata.
9223 (syms_of_image): Use DEFSYM. New symbol `delay'.
9224
6198ccd0
MR
92252011-06-11 Martin Rudalics <rudalics@gmx.at>
9226
9227 * window.c (delete_deletable_window): Re-add.
9228 (Fset_window_configuration): Rewrite to handle dead buffers and
9229 consequently deletable windows.
9230 (window_tree, Fwindow_tree): Remove. Supply functionality in
9231 window.el.
9232 (compare_window_configurations): Simplify code.
9233
b6e3633c
AS
92342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9235
1ab0dee5
AS
9236 * image.c (imagemagick_load_image): Fix type mismatch.
9237 (Fimagemagick_types): Likewise.
9238
b6e3633c
AS
9239 * window.h (replace_buffer_in_windows): Declare.
9240
9397e56f
MR
92412011-06-11 Martin Rudalics <rudalics@gmx.at>
9242
9243 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9244 Qclone_number. Remove external declaration of Qdelete_window.
9245 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9246 code.
640c8776
SM
9247 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9248 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9249 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9250 buffer list implementation.
9251 (other_buffer_safely): New function.
9252 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9253 calls to replace_buffer_in_windows and
9254 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9255 if allowed.
9256 (record_buffer): Inhibit quitting and rewrite using quittable
9257 functions. Run Qbuffer_list_update_hook if allowed.
9258 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9259 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9260 Move switch-to-buffer to window.el.
9397e56f
MR
9261 (bury-buffer): Move to window.el.
9262 (Vbuffer_list_update_hook): New variable.
9263
9264 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9265 section.
9266
9267 * window.h (resize_frame_windows): Move up in code.
9268 (Fwindow_frame): Remove EXFUN.
9269 (replace_buffer_in_all_windows): Remove prototype.
9270 (replace_buffer_in_windows_safely): Add prototype.
9271
9272 * window.c: Declare Qdelete_window static again. Move down
9273 declaration of select_count.
9274 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9275 (Fother_window): Move to window.el.
9276 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9277 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9278 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9279 window.el.
9280 (replace_buffer_in_windows): Implement by calling
9281 Qreplace_buffer_in_windows.
9282 (replace_buffer_in_all_windows): Remove with some functionality
9283 moved into replace_buffer_in_windows_safely.
9284 (replace_buffer_in_windows_safely): New function.
9285 (select_window_norecord, select_frame_norecord): Move in front
9286 of run_window_configuration_change_hook. Remove now obsolete
9287 declarations.
640c8776
SM
9288 (Fset_window_buffer): Rewrite doc-string.
9289 Call Qrecord_window_buffer.
9397e56f
MR
9290 (keys_of_window): Move binding for other-window to window.el.
9291
b50691aa
CY
92922011-06-11 Chong Yidong <cyd@stupidchicken.com>
9293
9294 * dispextern.h (struct image): Replace data member, whose int_val
9295 and ptr_val fields were not used by anything, with a single
9296 lisp_val object.
9297
9298 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9299 (gif_clear_image, gif_load, imagemagick_load_image)
9300 (gs_clear_image, gs_load): Callers changed.
9301
3f754b86
PE
93022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9303
cca69397
PE
9304 * buffer.h: Include <time.h>, for time_t.
9305 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9306
109e28d0
PE
9307 Fix minor problems found by static checking.
9308
60737f02
PE
9309 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9310
4b66faf3
PE
9311 Make identifiers static if they are not used in other modules.
9312 * data.c (Qcompiled_function, Qframe, Qvector):
9313 * image.c (QimageMagick, Qsvg):
9314 * minibuf.c (Qmetadata):
9315 * window.c (resize_window_check, resize_root_window): Now static.
9316 * window.h (resize_window_check, resize_root_window): Remove decls.
9317
109e28d0
PE
9318 * window.c (window_deletion_count, delete_deletable_window):
9319 Remove; unused.
46a4ce9e
PE
9320 (window_body_lines): Now static.
9321 (Fdelete_other_windows_internal): Mark vars as initialized.
9322 Make sure 'resize_failed' is initialized.
9323 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9324 (resize_window_apply): Remove unused local.
9325 * window.h (delete_deletable_window): Remove decl.
9326
109e28d0 9327 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9328 (imagemagick_load_image): Fix pointer signedness problem by changing
9329 last arg from unsigned char * to char *. All uses changed.
9330 Also, fix a local for similar reasons.
9331 Remove unused locals. Remove locals to avoid shadowing.
9332 (fn_rsvg_handle_free): Remove; unused.
9333 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9334 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9335
3f754b86
PE
9336 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9337
2547adb1
CY
93382011-06-10 Chong Yidong <cyd@stupidchicken.com>
9339
9340 * image.c (gif_load): Fix omitted cast error introduced by
9341 2011-06-06 change.
9342
2c8e37d4
MR
93432011-06-10 Martin Rudalics <rudalics@gmx.at>
9344
9345 * window.h (resize_proportionally, orig_total_lines)
9346 (orig_top_line): Remove from window structure.
9347 (set_window_height, set_window_width, change_window_heights)
9348 (Fdelete_window): Remove prototypes.
9349 (resize_frame_windows): Remove duplicate declaration.
9350
440a42e3
EZ
93512011-06-10 Eli Zaretskii <eliz@gnu.org>
9352
9353 * window.h (resize_frame_windows, resize_window_check)
9354 (delete_deletable_window, resize_root_window)
9355 (resize_frame_windows): Declare prototypes.
9356
9357 * window.c (resize_window_apply): Make definition be "static" to
9358 match the prototype.
9359
562dd5e9
MR
93602011-06-10 Martin Rudalics <rudalics@gmx.at>
9361
9362 * window.c: Remove declarations of Qwindow_size_fixed,
9363 window_min_size_1, window_min_size_2, window_min_size,
9364 size_window, window_fixed_size_p, enlarge_window, delete_window.
9365 Remove static from declaration of Qdelete_window, it's
9366 temporarily needed by Fbury_buffer.
9367 (replace_window): Don't assign orig_top_line and
9368 orig_total_lines.
9369 (Fdelete_window, delete_window): Remove. Window deletion is
9370 handled by window.el.
640c8776
SM
9371 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9372 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9373 (Fdelete_other_windows): Remove. Deleting other windows is
9374 handled by window.el.
9375 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9376 handled in window.el.
9377 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9378 Window minimum sizes are handled in window.el.
9379 (shrink_windows, size_window, set_window_height)
9380 (set_window_width, change_window_heights, window_height)
9381 (window_width, CURBEG, CURSIZE, enlarge_window)
9382 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9383 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9384 handled in window.el.
9385 (make_dummy_parent): Rename to make_parent_window and give it a
9386 second argument horflag.
9387 (make_window): Don't set resize_proportionally any more.
9388 (Fsplit_window): Remove. Windows are split in window.el.
9389 (save_restore_action, save_restore_orig_size)
9390 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9391 Resize mini windows in window.el.
9392 (grow_mini_window, shrink_mini_window): Implement by calling
9393 Qresize_root_window_vertically, resize_window_check and
9394 resize_window_apply.
640c8776
SM
9395 (saved_window, Fset_window_configuration, save_window_save):
9396 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9397 resize_proportionally.
9398 (window_min_height, window_min_width): Move to window.el.
9399 (keys_of_window): Move bindings for delete-other-windows,
9400 split-window, delete-window and enlarge-window to window.el.
9401
9402 * buffer.c: Temporarily extern Qdelete_window.
9403 (Fbury_buffer): Temporarily call Qdelete_window instead of
9404 Fdelete_window (Fbury_buffer will move to window.el soon).
9405
9406 * frame.c (set_menu_bar_lines_1): Remove code handling
9407 orig_top_line and orig_total_lines.
9408
9409 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9410 set_window_height but set heights directly.
9411 (change_frame_size_1): Use resize_frame_windows.
9412
9413 * xdisp.c (init_xdisp): Don't use set_window_height but set
9414 heights directly.
9415
640c8776
SM
9416 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9417 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9418 run_window_configuration_change_hook.
9419
9420 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9421 instead of change_window_heights and run
9422 run_window_configuration_change_hook.
9423
1a13852e
MR
94242011-06-09 Martin Rudalics <rudalics@gmx.at>
9425
9426 * window.c (replace_window): Rename second argument REPLACEMENT to
9427 NEW. New third argument SETFLAG. Rewrite.
9428 (delete_window, make_dummy_parent): Call replace_window with
9429 third argument 1.
9430 (window_list_1): Move down in code.
9431 (run_window_configuration_change_hook): Move set_buffer part
9432 before select_frame_norecord part in order to unwind correctly.
9433 Rename count1 to count.
9434 (recombine_windows, delete_deletable_window, resize_root_window)
9435 (Fdelete_other_windows_internal)
9436 (Frun_window_configuration_change_hook, make_parent_window)
9437 (resize_window_check, resize_window_apply, Fresize_window_apply)
9438 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9439 (Fdelete_window_internal, Fresize_mini_window_internal):
9440 New functions.
1a13852e
MR
9441 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9442
f3d1777e
MR
94432011-06-08 Martin Rudalics <rudalics@gmx.at>
9444
496e208e
MR
9445 * window.h (window): Add some new members to window structure -
9446 normal_lines, normal_cols, new_total, new_normal, clone_number,
9447 splits, nest, prev_buffers, next_buffers.
9448 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9449 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9450
f3d1777e
MR
9451 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9452 Remove.
496e208e
MR
9453 (make_dummy_parent): Set new members of windows structure.
9454 (make_window): Move down in code. Handle new members of window
9455 structure.
9456 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9457 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9458 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9459 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9460 (Fset_window_next_buffers, Fset_window_clone_number):
9461 New functions.
496e208e
MR
9462 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9463 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9464 Doc-string fixes.
9465 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9466 Argument WINDOW can be now internal window too.
9467 (Fwindow_use_time): Move up in code.
9468 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9469 Rewrite doc-string.
9470 (Fset_window_configuration, saved_window)
9471 (Fcurrent_window_configuration, save_window_save): Handle new
9472 members of window structure.
b9e809c2
MR
9473 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9474 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9475 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9476 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9477 Qget_mru_window, Qresize_root_window,
9478 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9479 Qauto_buffer_name; staticpro them.
f3d1777e 9480
abde8f8c
MR
94812011-06-07 Martin Rudalics <rudalics@gmx.at>
9482
9483 * window.c (Fwindow_total_size, Fwindow_left_column)
9484 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9485 (Fwindow_list_1): New functions.
9486 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9487 (Fwindow_width, Fscroll_left, Fscroll_right):
9488 Use window_body_cols instead of window_box_text_cols.
9489 (delete_window, Fset_window_configuration):
9490 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9491 (delete_all_subwindows): Take a window as argument and not a
9492 structure. Rewrite.
190b47e6
MR
9493 (window_loop): Remove handling of GET_LRU_WINDOW and
9494 GET_LARGEST_WINDOW.
9495 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9496
9497 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9498 window_box_text_cols. delete_all_subwindows now takes a
9499 Lisp_Object as argument.
abde8f8c 9500
640c8776
SM
9501 * indent.c (compute_motion, Fcompute_motion):
9502 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9503
fa8a67e6
MR
9504 * frame.c (delete_frame): Call delete_all_subwindows with root
9505 window as argument.
9506
a54e3482
DC
95072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9508
9509 * fns.c (Fputhash): Document return value.
9510
60002bf5
CY
95112011-06-06 Chong Yidong <cyd@stupidchicken.com>
9512
9513 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9514
0c671da6 95152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9516
b862a52a 9517 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9518
be44ca6c
PE
9519 Check for overflow when converting integer to cons and back.
9520 * charset.c (Fdefine_charset_internal, Fdecode_char):
9521 Use cons_to_unsigned to catch overflow.
9522 (Fencode_char): Use INTEGER_TO_CONS.
9523 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9524 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9525 * data.c (long_to_cons, cons_to_long): Remove.
9526 (cons_to_unsigned, cons_to_signed): New functions.
9527 These signal an error for invalid or out-of-range values.
9528 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9529 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9530 * font.c (Ffont_variation_glyphs):
9531 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9532 * lisp.h: Include <intprops.h>.
9533 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9534 (cons_to_signed, cons_to_unsigned): New decls.
9535 (long_to_cons, cons_to_long): Remove decls.
9536 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9537 (Fprimitive_undo): Use CONS_TO_INTEGER.
9538 * xfns.c (Fx_window_property): Likewise.
9539 * xselect.c: Include <limits.h>.
9540 (x_own_selection, selection_data_to_lisp_data):
9541 Use INTEGER_TO_CONS.
9542 (x_handle_selection_request, x_handle_selection_clear)
9543 (x_get_foreign_selection, Fx_disown_selection_internal)
9544 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9545 (lisp_data_to_selection_data): Use cons_to_unsigned.
9546 (x_fill_property_data): Use cons_to_signed.
9547 Report values out of range.
9548
d1f3d2af
PE
9549 Check for buffer and string overflow more precisely.
9550 * buffer.h (BUF_BYTES_MAX): New macro.
9551 * lisp.h (STRING_BYTES_MAX): New macro.
9552 * alloc.c (Fmake_string):
9553 * character.c (string_escape_byte8):
9554 * coding.c (coding_alloc_by_realloc):
9555 * doprnt.c (doprnt):
9556 * editfns.c (Fformat):
9557 * eval.c (verror):
9558 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9559 since they may not be the same number.
9560 * editfns.c (Finsert_char):
9561 * fileio.c (Finsert_file_contents):
9562 Likewise for BUF_BYTES_MAX.
9563
dd52fcea
PE
9564 * image.c: Use ptrdiff_t, not int, for sizes.
9565 (slurp_file): Switch from int to ptrdiff_t.
9566 All uses changed.
9567 (slurp_file): Check that file size fits in both size_t (for
9568 malloc) and ptrdiff_t (for sanity and safety).
9569
7f9bbdbb
PE
9570 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9571 if b->modtime has its maximal value.
9572
dfe18f82
PE
9573 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9574
84acfcf0
PE
9575 Don't assume time_t can fit into int.
9576 * buffer.h (struct buffer.modtime): Now time_t, not int.
9577 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9578 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9579
ccd9a01a
PE
9580 Minor fixes for signed vs unsigned integers.
9581 * character.h (MAYBE_UNIFY_CHAR):
9582 * charset.c (maybe_unify_char):
9583 * keyboard.c (read_char, reorder_modifiers):
9584 XINT -> XFASTINT, since the integer must be nonnegative.
9585 * ftfont.c (ftfont_spec_pattern):
9586 * keymap.c (access_keymap, silly_event_symbol_error):
9587 XUINT -> XFASTINT, since the integer must be nonnegative.
9588 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9589 since it makes no difference and we prefer signed.
9590 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9591 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9592 nonnegative.
9593
d6d100dd
SM
95942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9595
9596 * window.h (Fwindow_frame): Declare.
9597
2b6148e4
PE
95982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9599
9600 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9601 (SPARE_MEMORY): Always define.
9602 (LARGE_REQUEST): Remove.
9603 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9604
f230ecc9
MR
96052011-06-06 Martin Rudalics <rudalics@gmx.at>
9606
727e958e
MR
9607 * lisp.h: Move EXFUNS for Fframe_root_window,
9608 Fframe_first_window and Fset_frame_selected_window to window.h.
9609
9610 * window.h: Move EXFUNS for Fframe_root_window,
9611 Fframe_first_window and Fset_frame_selected_window here from
9612 lisp.h.
9613
9614 * frame.c (Fwindow_frame, Fframe_first_window)
9615 (Fframe_root_window, Fframe_selected_window)
9616 (Fset_frame_selected_window): Move to window.c.
9617 (Factive_minibuffer_window): Move to minibuf.c.
9618 (Fother_visible_frames_p): New function.
9619
9620 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9621
f230ecc9
MR
9622 * window.c (decode_window, decode_any_window): Move up in code.
9623 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9624 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9625 (Fwindow_buffer): Move up and rewrite doc-string.
9626 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9627 (Fwindow_prev): New functions.
727e958e
MR
9628 (Fwindow_frame): Move here from frame.c. Accept any window as
9629 argument.
9630 (Fframe_root_window, Fframe_first_window)
9631 (Fframe_selected_window): Move here from frame.c. Accept frame
9632 or arbitrary window as argument. Update doc-strings.
9633 (Fminibuffer_window): Move up in code.
9634 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9635 (Fset_frame_selected_window): Move here from frame.c.
9636 Marginal rewrite.
727e958e
MR
9637 (Fselected_window, select_window, Fselect_window): Move up in
9638 code. Minor doc-string fixes.
f230ecc9 9639
4d09bcf6
PE
96402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9641
9642 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9643 Do not assume that spare memory exists; that assumption is valid
9644 only if SYSTEM_MALLOC.
9645 (LARGE_REQUEST): New macro, so that the issue of large requests
9646 is separated from the issue of spare memory.
9647
810928a2
AS
96482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9649
172418ad
AS
9650 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9651 format. (Bug#8806)
9652
43f862f7
AS
9653 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9654
810928a2
AS
9655 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9656 before statements.
9657
a059fe24
JD
96582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9659
9660 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9661
9662 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9663
9664 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9665 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9666
989bf368
JB
96672011-06-05 Juanma Barranquero <lekktu@gmail.com>
9668
9669 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9670
4b80f674
CY
96712011-06-04 Chong Yidong <cyd@stupidchicken.com>
9672
9673 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9674 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9675 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9676 New error handlers.
4b80f674
CY
9677 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9678 Obey Vx_select_enable_clipboard_manager. Catch errors in
9679 x_clipboard_manager_save (Bug#8779).
9680 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9681 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9682
99a33b77 96832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9684
9685 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9686
99a33b77 96872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9688
9689 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9690 in the current matrix if keep_current_p is non-zero.
9691
8264569d
EZ
96922011-06-04 Eli Zaretskii <eliz@gnu.org>
9693
9694 * bidi.c (bidi_level_of_next_char): Fix last change.
9695
57f97249
EZ
96962011-06-03 Eli Zaretskii <eliz@gnu.org>
9697
fec2107c 9698 Support bidi reordering of text covered by display properties.
57f97249 9699
fec2107c
EZ
9700 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9701 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9702 (bidi_cache_search, bidi_cache_iterator_state)
9703 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9704 (bidi_level_of_next_char, bidi_move_to_visually_next):
9705 Support character positions inside a run of characters covered by a
fec2107c
EZ
9706 display string.
9707 (bidi_paragraph_init, bidi_resolve_explicit_1)
9708 (bidi_level_of_next_char): Call bidi_fetch_char and
9709 bidi_fetch_char_advance instead of FETCH_CHAR and
9710 FETCH_CHAR_ADVANCE.
9711 (bidi_init_it): Initialize new members.
9712 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9713 definitions.
9714 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9715 instead of using explicit *_CHAR codes.
d6d100dd
SM
9716 (bidi_resolve_explicit, bidi_resolve_weak):
9717 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9718 bidirectional text is supported only in multibyte buffers.
9719 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9720 it to initialize the frame_window_p member of struct bidi_it.
9721 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9722 (bidi_resolve_explicit, bidi_resolve_weak)
9723 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9724 bidi_it->nchars is non-positive.
9725 (bidi_level_of_next_char): Don't try to lookup the cache for the
9726 next/previous character if nothing is cached there yet, or if we
9727 were just reseat()'ed to a new position.
c40e2fb2 9728
0e14fe90
EZ
9729 * xdisp.c (set_cursor_from_row): Set start and stop points
9730 according to the row's direction when priming the loop that looks
9731 for the glyph on which to display cursor.
9732 (single_display_spec_intangible_p): Function deleted.
9733 (display_prop_intangible_p): Reimplement to call
9734 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9735 Accept 3 additional arguments needed by handle_display_spec.
9736 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9737 values: lists, `(when COND...)' forms, etc.
9738 (single_display_spec_string_p): Support property values that are
9739 lists with the argument STRING its top-level element.
9740 (display_prop_string_p): Fix the condition for processing a
9741 property that is a list to be consistent with handle_display_spec.
fec2107c 9742 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9743 last portion of handle_display_prop.
9744 (compute_display_string_pos): Accept additional argument
9745 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9746 value of a `display' property is a "replacing spec".
9747 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9748 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9749 the display property, but just return a value indicating whether
9750 the display property will replace the characters it covers.
9751 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9752 frame_window_p members of struct bidi_it.
d6d100dd
SM
9753 (compute_display_string_pos, compute_display_string_end):
9754 New functions.
fec2107c
EZ
9755 (push_it): Accept second argument POSITION, where pop_it should
9756 jump to continue iteration.
9757 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9758
fec2107c
EZ
9759 * keyboard.c (adjust_point_for_property): Adjust the call to
9760 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9761
9762 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9763 (bidi_init_it): Update prototypes.
9764 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9765 (compute_display_string_pos, compute_display_string_end):
9766 Declare prototypes.
fec2107c
EZ
9767 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9768 EMACS_INT.
fc6f18ce 9769
40087514 97702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9771
57f53182
PE
9772 Malloc failure behavior now depends on size of allocation.
9773 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9774 * lisp.h: Change signatures accordingly.
9775 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9776 All callers changed. (Bug#8762)
9777
9778 * gnutls.c: Use Emacs's memory allocators.
9779 Without this change, the gnutls library would invoke malloc etc.
9780 directly, which causes problems on non-SYNC_INPUT hosts, and which
9781 runs afoul of improving memory_full behavior. (Bug#8761)
9782 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9783 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9784 xfree instead of the default malloc, realloc, free.
9785 (Fgnutls_boot): No need to check for memory allocation failure,
9786 since xmalloc does that for us.
9787
ac32cd99 9788 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9789 * category.c (hash_get_category_set):
9790 * ccl.c (ccl_driver):
9791 * charset.c (Fdefine_charset_internal):
9792 * charset.h (struct charset.hash_index):
9793 * composite.c (get_composition_id, gstring_lookup_cache)
9794 (composition_gstring_put_cache):
9795 * composite.h (struct composition.hash_index):
9796 * dispextern.h (struct image.hash):
9797 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9798 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9799 (hashfn_equal, hashfn_user_defined, make_hash_table)
9800 (maybe_resize_hash_table, hash_lookup, hash_put)
9801 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9802 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9803 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9804 * image.c (make_image, search_image_cache, lookup_image)
9805 (xpm_put_color_table_h):
9806 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9807 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9808 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9809 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9810 * alloc.c (allocate_vectorlike):
9811 Check for overflow in vector size calculations.
9812 * ccl.c (ccl_driver):
9813 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9814 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9815 need to be updated by these changes.
40087514
PE
9816 * fns.c (make_hash_table, maybe_resize_hash_table):
9817 Check for integer overflow with large hash tables.
0de4bb68
PE
9818 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9819 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9820 (SXHASH_REDUCE): New macro.
9821 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9822 Use it instead of discarding useful hash info with large hash values.
9823 (sxhash_float): New function.
9824 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9825 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9826 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9827 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9828 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9829 Adjust signatures to match updated version of code.
9830 (consing_since_gc): Now EMACS_INT, since a single hash table can
9831 use more than INT_MAX bytes.
9832
698d32e2
DN
98332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9834
9835 Make it possible to build with GCC-4.6+ -O2 -flto.
9836
9837 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9838
fd6fa53f
SM
98392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9840
9841 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9842 Call minibuffer-inactive-mode.
9843
864db017
JB
98442011-05-31 Juanma Barranquero <lekktu@gmail.com>
9845
9846 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9847 Update dependencies.
9848
2ad0baf4
DN
98492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9850
9851 * data.c (init_data): Remove code for UTS, this system is not
9852 supported anymore.
9853
4fcc2638
DN
98542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9855
9856 Don't force ./temacs to start in terminal mode.
9857
9858 * frame.c (make_initial_frame): Initialize faces in all cases, not
9859 only when CANNOT_DUMP is defined.
9860 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9861
c56e0fd5
DN
98622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9863
9864 * dispnew.c (add_window_display_history): Use const for the string
9865 pointer. Remove declaration, not needed.
9866
333d54da 98672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9868
55d4c1b2 9869 Use 'inline', not 'INLINE'.
333d54da 9870 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9871 * alloc.c, fontset.c (INLINE): Remove.
9872 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9873 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9874 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9875 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9876 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9877
738db178
DN
98782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9879
9880 Make it possible to run ./temacs.
9881
9882 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9883 syms_of_callproc does the same thing. Remove test for
9884 "initialized", do it in the caller.
9885 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9886
620c53a6
SM
98872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9888
9889 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9890 (read_minibuf): Use get_minibuffer.
9891 (syms_of_minibuf): Use DEFSYM.
9892 (Qmetadata): New var.
9893 * data.c (Qbuffer): Don't make it static.
9894 (syms_of_data): Use DEFSYM.
9895
e003a292
PE
98962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9897
9898 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9899 (CCL_CODE_MIN): New macro.
9900
ed008a6d
PE
99012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9902
3687c2ef
PE
9903 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9904
ed008a6d
PE
9905 * eval.c (Qdebug): Now static.
9906 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9907 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9908 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9909
d66c4c7c
CY
99102011-05-29 Chong Yidong <cyd@stupidchicken.com>
9911
9912 * image.c: Various fixes to ImageMagick code comments.
9913 (Fimagemagick_types): Doc fix.
9914
5fbc2025
PE
99152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9916
0196f88a
PE
9917 Minor fixes prompted by GCC 4.6.0 warnings.
9918
9919 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9920
5fbc2025
PE
9921 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9922 (x_clipboard_manager_save_all): Move extern decl to ...
9923 * xterm.h: ... here, so that it can be checked for consistency.
9924
1dd3c2d9
CY
99252011-05-29 Chong Yidong <cyd@stupidchicken.com>
9926
9927 * xselect.c (x_clipboard_manager_save_frame)
9928 (x_clipboard_manager_save_all): New functions.
9929 (Fx_clipboard_manager_save): Lisp function deleted.
9930
9931 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9932 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9933
9934 * xterm.h: Update prototype.
9935
5ba6571d
WX
99362011-05-28 William Xu <william.xwl@gmail.com>
9937
9938 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9939 exiting (Bug#8239).
9940
3eaff834
JM
99412011-05-28 Jim Meyering <meyering@redhat.com>
9942
e1900994 9943 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9944 * fns.c (to_uchar): Define.
9945 (crypto_hash_function): Use it to convert some newly-signed
9946 variables to unsigned, to avoid sign-extension bugs. For example,
9947 without this change, (md5 "truc") would evaluate to
9948 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9949 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9950 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9951
0f6990a7
PE
99522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9953
9954 Integer overflow fixes.
c8a9ca5a 9955
08686060
PE
9956 * dbusbind.c: Serial number integer overflow fixes.
9957 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9958 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9959 to hold a serial number that is too large for a fixnum.
9960 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9961 Check for serial numbers out of range. Decode any serial number
59568bf0 9962 that was so large that it became a float. (Bug#8722)
08686060 9963
2d1fc3c7
PE
9964 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9965 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9966 Use XFASTINT rather than XUINT when numbers are nonnegative.
9967 (xd_append_arg, Fdbus_method_return_internal):
9968 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9969 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9970 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9971 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9972 (Bug#8722)
2d1fc3c7 9973
c8a9ca5a
PE
9974 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9975
519e1d69
PE
9976 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9977
6df6ae42 9978 ccl: Add integer overflow checks.
30569699
PE
9979 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9980 (IN_INT_RANGE): New macros.
9981 (ccl_driver): Use them to check for integer overflow when
9982 decoding a CCL program. Many of the new checks are whether XINT (x)
9983 fits in int; it doesn't always, on 64-bit hosts. The new version
9984 doesn't catch all possible integer overflows, but it's an
847044ea 9985 improvement. (Bug#8719)
30569699 9986
c11285dc
PE
9987 * alloc.c (make_event_array): Use XINT, not XUINT.
9988 There's no need for unsigned here.
9989
fdccd48e
PE
9990 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9991 This follows up to the 2011-05-06 change that substituted uintptr_t
9992 for EMACS_INT. This case wasn't caught back then.
9993
37910ab2
PE
9994 Rework Fformat to avoid integer overflow issues.
9995 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9996 now (part of C89). Include <verify.h>.
9997 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9998 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9999 (Fformat): Avoid the prepass trying to compute sizes; it was only
10000 approximate and thus did not catch overflow reliably. Instead, walk
10001 through the format just once, formatting and computing sizes as we go,
10002 checking for integer overflow at every step, and allocating a larger
10003 buffer as needed. Keep track separately whether the format is
10004 multibyte. Keep only the most-recently calculated precision, rather
10005 than them all. Record whether each argument has been converted to
10006 string. Use EMACS_INT, not int, for byte and char and arg counts.
10007 Support field widths and precisions larger than INT_MAX. Avoid
10008 sprintf's undefined behavior with conversion specifications such as %#d
10009 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10010 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10011 formatting out-of-range floating point numbers with int
9173deec 10012 formats. (Bug#8668)
37910ab2 10013
2e6578fb
PE
10014 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10015
0ae6bdee
PE
10016 * data.c: Avoid integer truncation in expressions involving floats.
10017 * data.c: Include <intprops.h>.
10018 (arith_driver): When there's an integer overflow in an expression
10019 involving floating point, convert the integers to floating point
10020 so that the resulting value does not suffer from catastrophic
10021 integer truncation. For example, on a 64-bit host (* 4
10022 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10023 Do not rely on undefined behavior after integer overflow.
10024
de883a70
PE
10025 merge count_size_as_multibyte, parse_str_to_multibyte
10026 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10027 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10028 Check for integer overflow.
10029 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10030 since it's now a duplicate of the other. This is more of
10031 a character than a buffer op, so better that it's in character.c.
10032 * fns.c, print.c: Adjust to above changes.
10033
2ff916cb
PE
100342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10035
10036 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10037
f1b54466
PE
100382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10039
fb1ac845
PE
10040 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10041 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10042 (x_clipboard_manager_save): Now static.
10043 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10044
f1b54466
PE
10045 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10046 (crypto_hash_function): Now static.
10047 Fix pointer signedness problems. Avoid unnecessary initializations.
10048
a9f737ee
CY
100492011-05-27 Chong Yidong <cyd@stupidchicken.com>
10050
10051 * termhooks.h (Vselection_alist): Make it terminal-local.
10052
10053 * terminal.c (create_terminal): Initialize it.
10054
10055 * xselect.c: Support for clipboard managers.
10056 (Vselection_alist): Move to termhooks.h as terminal-local var.
10057 (LOCAL_SELECTION): New macro.
10058 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10059 (symbol_to_x_atom): Remove gratuitous arg.
10060 (x_handle_selection_request, lisp_data_to_selection_data)
10061 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10062 (x_own_selection, x_get_local_selection, x_convert_selection):
10063 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10064 (some_frame_on_display): Delete unused function.
10065 (Fx_own_selection_internal, Fx_get_selection_internal)
10066 (Fx_disown_selection_internal, Fx_selection_owner_p)
10067 (Fx_selection_exists_p): New optional frame arg.
10068 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10069 (x_handle_selection_clear): Don't treat other terminals with the
10070 same keyboard specially. Use the terminal-local Vselection_alist.
10071 (x_clear_frame_selections): Use Frun_hook_with_args.
10072
10073 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10074
10075 * xterm.h: Add support for those atoms.
10076
e067f0c1
CY
100772011-05-26 Chong Yidong <cyd@stupidchicken.com>
10078
10079 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10080 (converted_selections, conversion_fail_tag): New global variables.
10081 (x_selection_request_lisp_error): Free the above.
10082 (x_get_local_selection): Remove unnecessary code.
10083 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10084 of converted selections stored in converted_selections.
10085 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10086 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10087 (x_convert_selection): New function.
10088 (x_handle_selection_event): Simplify.
10089 (x_get_foreign_selection): Don't ignore incoming requests while
10090 waiting for an answer; this will fail when we implement
10091 SAVE_TARGETS, and seems unnecessary anyway.
10092 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10093 (Vx_sent_selection_functions): Doc fix.
10094
0f4aebc0
LL
100952011-05-26 Leo Liu <sdl.web@gmail.com>
10096
10097 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10098
e61124cd
YM
100992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10100
10101 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10102
10103 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10104 for fringe update if it has periodic bitmap.
ac389d0c 10105 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10106 and fringe_bitmap_periodic_p.
10107
10108 * fringe.c (get_fringe_bitmap_data): New function.
10109 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10110 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10111 row. Mark glyph row for fringe update if periodicity changed.
10112
10113 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10114 for fringe update unless it has periodic bitmap.
10115
f16d9837
KH
101162011-05-25 Kenichi Handa <handa@m17n.org>
10117
10118 * xdisp.c (get_next_display_element): Set correct it->face_id for
10119 a static composition.
10120
e1b90ef6
LL
101212011-05-24 Leo Liu <sdl.web@gmail.com>
10122
10123 * deps.mk (fns.o):
10124 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10125
10126 * fns.c (crypto_hash_function, Fsha1): New function.
10127 (Fmd5): Use crypto_hash_function.
10128 (syms_of_fns): Add Ssha1.
10129
7400048f
PE
101302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10131
10132 * gnutls.c: Remove unused macros.
10133 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10134 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10135 Remove macros that are defined and never used.
10136 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10137
abb71cf4
CY
101382011-05-22 Chong Yidong <cyd@stupidchicken.com>
10139
10140 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10141 (Fx_get_selection_internal): Minor cleanup.
10142 (Fx_own_selection_internal): Rename arguments for consistency with
10143 select.el.
10144
6307db39
PE
101452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10146
10147 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10148
f3d4e0a4
CY
101492011-05-22 Chong Yidong <cyd@stupidchicken.com>
10150
10151 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10152
4d8ade89
YM
101532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10154
10155 * dispnew.c (scrolling_window): Don't exclude the case that the
10156 last enabled row in the desired matrix touches the bottom boundary.
10157
32078c8d
GM
101582011-05-21 Glenn Morris <rgm@gnu.org>
10159
10160 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10161 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10162 and add some more files.
32078c8d 10163
7285dc67
EZ
101642011-05-20 Eli Zaretskii <eliz@gnu.org>
10165
10166 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10167 report_file_error introduced by the change from 2011-05-07.
10168
89d1bd22
PE
101692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10170
10171 * systime.h (Time): Define only if emacs is defined.
10172 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10173 where the include path doesn't have X11/X.h by default. See
10174 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10175
cd394be1 101762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10177
10178 * composite.c (find_automatic_composition): Fix previous change.
10179
b9704ad9
GM
101802011-05-20 Glenn Morris <rgm@gnu.org>
10181
10182 * lisp.mk: New file, split from Makefile.in.
10183 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10184 (shortlisp): Remove.
10185 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10186
4a720484
GM
101872011-05-19 Glenn Morris <rgm@gnu.org>
10188
10189 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10190 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10191 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10192 (lisp): Set the order to that of loadup.el.
10193 (shortlisp): Make it a copy of $lisp.
10194 (SOME_MACHINE_LISP): Remove.
10195 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10196 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10197
a28d4396
KH
101982011-05-18 Kenichi Handa <handa@m17n.org>
10199
10200 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10201 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10202 (find_automatic_composition): Mostly rewrite for efficiency.
10203
a2b1fa8e
JB
102042011-05-18 Juanma Barranquero <lekktu@gmail.com>
10205
10206 * makefile.w32-in: Update dependencies.
10207
8e1f5610
CS
102082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10209
10210 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10211 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10212
7025ee00 102132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10214
cdfa6eab
PE
10215 Fix some integer overflow issues, such as string length overflow.
10216
06d6db33
PE
10217 * insdel.c (count_size_as_multibyte): Check for string overflow.
10218
2b4560a8
PE
10219 * character.c (lisp_string_width): Check for string overflow.
10220 Use EMACS_INT, not int, for string indexes and lengths; in
10221 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10222 the resulting string length overflows an EMACS_INT; instead,
10223 report a string overflow if no precision given. When checking for
10224 precision exhaustion, use a check that cannot possibly have
10225 integer overflow. (Bug#8675)
10226 * character.h (lisp_string_width): Adjust to new signature.
10227
cb93f9be
PE
10228 * alloc.c (string_overflow): New function.
10229 (Fmake_string): Use it. This doesn't change behavior, but saves
10230 a few bytes and will simplify future changes.
10231 * character.c (string_escape_byte8): Likewise.
10232 * lisp.h (string_overflow): New decl.
10233
1a1f3366
PE
10234 Fixups, following up to the user-interface timestamp change.
10235 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10236 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10237 * msdos.c (mouse_get_pos): Likewise.
10238 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10239 * w32gui.h (Time): Define by including "systime.h" rather than by
10240 declaring it ourselves. (Bug#8664)
10241
d4e3e4d3
PE
10242 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10243 * image.c (clear_image_cache): Likewise.
10244
f6a24d19
PE
10245 * term.c (term_mouse_position): Don't assume time_t wraparound.
10246
08dc5ae6
PE
10247 Be more systematic about user-interface timestamps.
10248 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10249 and sometimes 'EMACS_UINT', to represent these timestamps.
10250 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10251 This makes the code easier to follow, and makes it easier to catch
10252 integer overflow bugs such as Bug#8664.
10253 * frame.c (Fmouse_position, Fmouse_pixel_position):
10254 Use Time, not unsigned long, for user-interface timestamps.
10255 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10256 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10257 * keyboard.h (last_event_timestamp): Likewise.
10258 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10259 * menu.h (xmenu_show): Likewise.
10260 * term.c (term_mouse_position): Likewise.
10261 * termhooks.h (struct input_event.timestamp): Likewise.
10262 (struct terminal.mouse_position_hook): Likewise.
10263 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10264 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10265 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10266 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10267 what it was before.
10268 * menu.h, termhooks.h: Include "systime.h", for Time.
10269
8e55734a
PE
10270 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10271 Don't assume that the difference between two unsigned long values
10272 can fit into an integer. At this point, we know button_down_time
10273 <= event->timestamp, so the difference must be nonnegative, so
10274 there's no need to cast the result if double-click-time is
10275 nonnegative, as it should be; check that it's nonnegative, just in
10276 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10277 apart (about 25 days). (Bug#8664)
8e55734a 10278
841f1b75 10279 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10280 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10281
3e26f69c
PE
10282 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10283 that always fit in int. Use a sentinel instead of a counter, to
10284 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10285 * frame.h (struct frame): Use int for menu_bar_items_used
10286 instead of EMACS_INT, since it always fits in int.
3e26f69c 10287
5cc152c0
PE
10288 * menu.c (grow_menu_items): Check for int overflow.
10289
d89eb65e
PE
10290 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10291
5235bd3e
PE
10292 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10293 Before, the code was not consistent. These values cannot exceed
10294 2**31 - 1 so there's no need to make them unsigned.
10295 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10296 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10297 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10298 as modifiers.
10299 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10300
bc827e23
PE
10301 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10302 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10303 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10304 presumably because the widths might not match.
10305
78eb494e
PE
10306 * window.c (size_window): Avoid needless test at loop start.
10307
04f2d78b
CB
103082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10309
10310 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10311
d2fc7e3d 103122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10313
10314 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10315
d2fc7e3d 103162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10317
10318 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10319 `width' to `bar_area_x' and `bar_area_width', respectively.
10320 (x_scroll_run): Take account of fringe background extension.
10321
04f2d78b
CB
10322 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10323 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10324 `bar_area_width', respectively.
10325 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10326 background extension.
10327
79b70037
GM
103282011-05-10 Jim Meyering <meyering@redhat.com>
10329
10330 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10331
2f142cc5
JB
103322011-05-10 Juanma Barranquero <lekktu@gmail.com>
10333
10334 * image.c (Finit_image_library): Return t for built-in image types,
10335 like pbm and xbm. (Bug#8640)
10336
57679c86
AS
103372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10338
10339 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10340
888c9e86
EZ
103412011-05-07 Eli Zaretskii <eliz@gnu.org>
10342
b0512a1d
EZ
10343 * w32console.c (Fset_screen_color): Doc fix.
10344 (Fget_screen_color): New function.
10345 (syms_of_ntterm): Defsubr it.
10346
7285dc67
EZ
10347 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10348 unlink the temporary file if Fcall_process didn't create it in the
10349 first place.
10350 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10351 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10352 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10353 cue to call_process_cleanup not to close that handle.
10354
4d3fcc8e
BK
103552011-05-07 Ben Key <bkey76@gmail.com>
10356
10357 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10358 one of two shell specific rules, either bootstrap-temacs-CMD or
10359 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10360 to the previous implementation of the bootstrap-temacs rule.
10361 The bootstrap-temacs-CMD rule is similar to the previous
10362 implementation of the bootstrap-temacs rule except that it
10363 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10364 variable.
10365
10366 These changes, along with some changes to nt/configure.bat,
10367 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10368 earlier fix to add support for --cflags and --ldflags options
10369 that include quotes so that it works whether make uses cmd or
10370 sh as the shell.
10371
b4289b64
MA
103722011-05-06 Michael Albinus <michael.albinus@gmx.de>
10373
10374 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10375 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10376 is a constant.
10377 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10378 a string. Handle both cases.
10379 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10380 (Fdbus_register_method): Use Qinvalid_function.
10381
af4c0e28
JB
103822011-05-06 Juanma Barranquero <lekktu@gmail.com>
10383
10384 * makefile.w32-in: Update dependencies.
10385 (LISP_H): Add inttypes.h and stdin.h.
10386 (PROCESS_H): Add unistd.h.
10387
c51453d9
EZ
103882011-05-06 Eli Zaretskii <eliz@gnu.org>
10389
10390 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10391 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10392
8ff0ac3c 103932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10394
4c4b566b
PE
10395 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10396
aab2b9b5
PE
10397 * term.c (vfatal): Remove stray call to va_end.
10398 It's not needed and the C Standard doesn't allow it here anyway.
10399
c378da0b
PE
10400 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10401 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10402
288b08c7
PE
10403 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10404 bytes.
10405
e3601888
PE
10406 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10407
db6c0e74
PE
10408 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10409
dd5963ea
PE
10410 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10411
88c9450f
PE
10412 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10413
2f9442b8
PE
10414 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10415
c032b5f8
PE
10416 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10417 * charset.c (Fdefine_charset_internal): Don't initialize
10418 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10419 32-bit int (Bug#8600).
a108c10b
PE
10420
10421 * lread.c (read_integer): Be more consistent with string-to-number.
10422 Use string_to_number to do the actual conversion; this avoids
10423 rounding errors and fixes some other screwups. Without this fix,
10424 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10425 (digit_to_number): Move earlier, for benefit of read_integer.
10426 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10427 not a digit in any supported base. (Bug#8602)
a108c10b 10428
ad5f9eea
PE
10429 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10430
aec1708a
PE
10431 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10432 to match comment at start of function. This also removes a
10433 GCC warning about overflow in a 32+64-bit port.
10434
47be4ab5
PE
10435 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10436
371cac43
PE
10437 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10438 Reported by Stefan Monnier in
10439 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10440 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10441 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10442
d01a7826
PE
10443 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10444 (EMACS_UINTPTR): Likewise, with uintptr_t.
10445
7fd47d5c
PE
10446 * lisp.h: Prefer 64-bit EMACS_INT if available.
10447 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10448 on 32-bit hosts that have 64-bit int, so that they can access
10449 large files.
122b0c86
PE
10450 However, temporarily disable this change unless the temporary
10451 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10452
8727937b
PE
10453 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10454
8ac068ac
PE
10455 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10456 This removes an assumption that EMACS_INT and long are the same
10457 width as pointers. The assumption is true for Emacs porting targets
10458 now, but we want to make other targets possible.
10459 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10460 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10461 In the rest of the code, change types of integers that hold casted
10462 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10463 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10464 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10465 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10466 No need to cast type when ORing.
10467 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10468 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10469 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10470 assume EMACS_INT is the same width as char *.
10471 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10472 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10473 Remove no-longer-needed casts.
10474 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10475 (xg_tool_bar_help_callback, xg_make_tool_item):
10476 Use EMACS_INTPTR to hold an integer
10477 that will be cast to void *; this can avoid a GCC warning
10478 if EMACS_INT is not the same width as void *.
10479 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10480 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10481 (current_message_1, set_message_1):
10482 Use a local to convert to proper width without a cast.
10483 * xmenu.c (dialog_selection_callback): Likewise.
10484
ede49d71
PE
10485 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10486 Also, don't assume VALBITS / RAND_BITS is less than 5,
10487 and don't rely on undefined behavior when shifting a 1 left into
10488 the sign bit.
10489 * lisp.h (get_random): Change signature to match.
10490
2f30ecd0
PE
10491 * lread.c (hash_string): Use size_t, not int, for hash computation.
10492 Normally we prefer signed values; but hashing is special, because
10493 it's better to use unsigned division on hash table sizes so that
10494 the remainder is nonnegative. Also, size_t is the natural width
10495 for hashing into memory. The previous code used 'int', which doesn't
10496 retain enough info to hash well into very large tables.
10497 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10498
2a866e7b
PE
10499 * dbusbind.c: Don't possibly lose pointer info when converting.
10500 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10501 Use XPNTR rather than XHASH, so that the high-order bits of
10502 the pointer aren't lost when converting through void *.
10503
51639eac
PE
10504 * eval.c (Fautoload): Don't double-shift a pointer.
10505
92394119
PE
10506 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10507
dbdb9a7c
JB
105082011-05-06 Juanma Barranquero <lekktu@gmail.com>
10509
10510 * gnutls.c (DEF_GNUTLS_FN):
10511 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10512
db7a0b4f
AS
105132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10514
10515 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10516 marker. (Bug#8610)
10517
cd394be1 105182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10519
10520 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10521 New version that can reserve upto 2GB of heap space.
10522
f7ff1b0f 105232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10524
10525 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10526
639c109b
TZ
105272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10528
10529 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10530 `gnutls_certificate_set_x509_key_file'.
10531
d2127135
JB
105322011-05-05 Juanma Barranquero <lekktu@gmail.com>
10533
10534 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10535 Update dependencies.
10536
e968f4f3
JB
105372011-05-04 Juanma Barranquero <lekktu@gmail.com>
10538
10539 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10540 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10541 Remove unused parameter `fildes'.
10542 * process.c (read_process_output, send_process): Don't pass it.
10543
84d358f0
JB
105442011-05-04 Juanma Barranquero <lekktu@gmail.com>
10545
10546 Fix previous change: the library cache is defined in w32.c.
10547 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10548 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10549
0898ca10
JB
105502011-05-04 Juanma Barranquero <lekktu@gmail.com>
10551
10552 Implement dynamic loading of GnuTLS on Windows.
10553
10554 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10555 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10556 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10557 Declare.
10558
10559 * gnutls.c (Qgnutls_dll): Define.
10560 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10561 (gnutls_*): Declare function pointers.
10562 (init_gnutls_functions): New function to initialize function pointers.
10563 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10564 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10565 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10566 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10567 (emacs_gnutls_write, emacs_gnutls_read)
10568 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10569 (Fgnutls_available_p): New function.
10570 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10571 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10572 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10573
10574 * image.c: Include w32.h.
10575 (Vimage_type_cache): Delete.
10576 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10577 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10578 (w32_delayed_load): Move to w32.c.
10579
10580 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10581
10582 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10583 (w32_delayed_load): Move from image.c. When loading a library, record
10584 its filename in the :loaded-from property of the library id.
10585 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10586 Initialize and staticpro them.
10587 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10588
10589 * process.c: Include lisp.h before w32.h, not after.
10590 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10591 instead of gnutls_record_check_pending.
10592
10593 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10594
ff4de4aa
TZ
105952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10596
10597 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10598 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10599 as passed in.
10600
abe95abb
JD
106012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10602
10603 * xterm.c (x_set_frame_alpha): Do not set property on anything
10604 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10605
e16e55d4
JB
106062011-05-02 Juanma Barranquero <lekktu@gmail.com>
10607
10608 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10609
bafcf6a5
JB
106102011-05-02 Juanma Barranquero <lekktu@gmail.com>
10611
10612 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10613 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10614 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10615 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10616 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10617 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10618 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10619 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10620 (Qgnutls_bootprop_callbacks_verify): Make static.
10621
e7a6747f
AS
106222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10623
19ed11ba
AS
10624 * callproc.c: Indentation fixup.
10625
e7a6747f 10626 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10627 (wait_for_termination, interruptible_wait_for_termination):
10628 Move after wait_for_termination_1.
e7a6747f 10629
1ef14cb4
LMI
106302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10631
10632 * sysdep.c (interruptible_wait_for_termination): New function
10633 which is like wait_for_termination, but allows keyboard
10634 interruptions.
10635
10636 * callproc.c (Fcall_process): Add (:file "file") as an option for
10637 the STDOUT buffer.
10638 (Fcall_process_region): Ditto.
10639
330d880c
EZ
106402011-04-30 Eli Zaretskii <eliz@gnu.org>
10641
8db90b73
EZ
10642 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10643 rather than `XVECTOR (FOO)->size'.
10644
330d880c
EZ
10645 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10646 inttypes.h, as a gnulib replacement is used if it not available in
10647 system headers.
10648
15cbd324
EZ
106492011-04-21 Eli Zaretskii <eliz@gnu.org>
10650
10651 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10652 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10653 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10654
10655 * coding.c (coding_alloc_by_realloc): Error out if destination
10656 will grow beyond MOST_POSITIVE_FIXNUM.
10657 (decode_coding_emacs_mule): Abort if there isn't enough place in
10658 charbuf for the composition carryover bytes. Reserve an extra
10659 space for up to 2 characters produced in a loop.
10660 (decode_coding_iso_2022): Abort if there isn't enough place in
10661 charbuf for the composition carryover bytes.
10662
106632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10664
ae940cca
EZ
10665 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10666 aborting when %lld or %lll format is passed.
10667 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10668 %llo or %llx format is passed. (Bug#8545)
10669
03ab8921
EZ
10670 * window.c (window_scroll_line_based): Use a marker instead of
10671 simple variables to record original value of point. (Bug#7952)
10672
afda1437
EZ
10673 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10674 produced by %s or %c overflows available buffer space. (Bug#8545)
10675
f76dee0c
PE
106762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10677
10678 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10679 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10680
fdc5744d
JB
106812011-04-28 Juanma Barranquero <lekktu@gmail.com>
10682
10683 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10684
638f053a
JB
106852011-04-28 Juanma Barranquero <lekktu@gmail.com>
10686
10687 * keyboard.c (Qdelayed_warnings_hook): Define.
10688 (command_loop_1): Run `delayed-warnings-hook'
10689 if Vdelayed_warnings_list is non-nil.
10690 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10691 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10692
d178f871
EZ
106932011-04-28 Eli Zaretskii <eliz@gnu.org>
10694
10695 * doprnt.c (doprnt): Don't return value smaller than the buffer
10696 size if the message was truncated. (Bug#8545).
10697
b124fd93
JB
106982011-04-28 Juanma Barranquero <lekktu@gmail.com>
10699
10700 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10701 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10702
e810457d
PE
107032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10704
10705 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10706
ea51cceb
JB
107072011-04-27 Juanma Barranquero <lekktu@gmail.com>
10708
10709 * makefile.w32-in: Update dependencies.
10710
94dcfacf
EZ
107112011-04-27 Eli Zaretskii <eliz@gnu.org>
10712
10713 Improve `doprnt' and its usage. (Bug#8545)
10714 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10715 `format_end'. Remove support for %l as a conversion specifier.
10716 Don't use xrealloc. Improve diagnostics when the %l size modifier
10717 is used. Update the commentary.
10718
10719 * eval.c (verror): Simplify calculation of size_t.
10720
10721 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10722 messages.
10723
f61f41d7
PE
107242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10725
10726 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10727 change.
10728
96fb4434
PE
107292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10730
10731 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10732 This makes this file independent of the recent pseudovector change.
10733
671875da 107342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10735
69e9b5a3
PE
10736 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10737
b5f869a7 10738 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10739 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10740 Remove unused local.
c8926152 10741 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10742
841a1577 10743 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10744 GCC 4.6.0 optimizes based on type-based alias analysis.
10745 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10746 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10747 != &v->size, and therefore "v->size = 1; b->size = 2; return
10748 v->size;" must therefore return 1. This assumption is incorrect
10749 for Emacs, since it type-puns struct Lisp_Vector * with many other
10750 types. To fix this problem, this patch adds a new type struct
f904488f 10751 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10752 and pseudovectors, and helps optimizing compilers not get fooled
10753 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10754 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10755 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10756 the size member.
eab3844f
PE
10757 (XSETPVECTYPE): Rewrite in terms of new macro.
10758 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10759 This is a bit clearer, and further avoids the possibility of
10760 undesirable aliasing.
10761 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10762 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10763 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10764 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10765 (ASIZE): Now uses header.size rather than size.
10766 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10767 to avoid the hassle of writing XVECTOR (foo)->header.size.
10768 (struct vectorlike_header): New type.
eab3844f
PE
10769 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10770 object, to help avoid aliasing.
10771 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10772 (SUBRP): Likewise, since Lisp_Subr is a special case.
10773 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10774 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10775 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10776 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10777 changed to be "header.size" and "header.next".
10778 * buffer.h (struct buffer): Likewise.
10779 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10780 * frame.h (struct frame): Likewise.
10781 * process.h (struct Lisp_Process): Likewise.
10782 * termhooks.h (struct terminal): Likewise.
10783 * window.c (struct save_window_data, struct saved_window): Likewise.
10784 * window.h (struct window): Likewise.
10785 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10786 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10787 * buffer.c (init_buffer_once): Likewise.
10788 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10789 special case.
10790 * process.c (Fformat_network_address): Use local var for size,
10791 for brevity.
10792
0df1eac5
PE
10793 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10794
847ab9d1 10795 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10796 * data.c (atof): Remove decl; no longer used or needed.
10797 (digit_to_number): Move to lread.c.
10798 (Fstring_to_number): Use new string_to_number function, to be
10799 consistent with how the Lisp reader treats infinities and NaNs.
10800 Do not assume that floating-point numbers represent EMACS_INT
10801 without losing information; this is not true on most 64-bit hosts.
10802 Avoid double-rounding errors, by insisting on integers when
10803 parsing non-base-10 numbers, as the documentation specifies.
10804 * lisp.h (string_to_number): New decl, replacing ...
10805 (isfloat_string): Remove.
bc0a5c13 10806 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10807 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10808 appears to have been a coding error. Similarly, do not accept
10809 strings like +-1e0 as floating point numbers. Do not report
10810 overflow for integer overflows unless the base is not 10 which
10811 means we have no simple and reliable way to continue.
10812 Break out the floating-point parsing into a new
10813 function string_to_number, so that Fstring_to_number parses
10814 floating point numbers consistently with the Lisp reader.
04f2d78b 10815 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10816 (E_CHAR, EXP_INT): Remove, replacing with ...
10817 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10818 (string_to_number): New function, replacing isfloat_string.
10819 This function checks for valid syntax and produces the resulting
10820 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10821 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10822 so that overflow for non-base-10 numbers is reported only when
10823 there's no portable and simple way to convert to floating point.
452f4150 10824
67769ffc
PE
10825 * textprop.c (set_text_properties_1): Rewrite for clarity,
10826 and to avoid GCC warning about integer overflow.
10827
c20db43f
PE
10828 * intervals.h (struct interval): Use EMACS_INT for members
10829 where EMACS_UINT might cause problems. See
10830 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10831 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10832 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10833 All uses changed.
37aa2f85
PE
10834 (offset_intervals): Tell GCC not to worry about length overflow
10835 when negating a negative length.
c20db43f 10836
2538aa2f
PE
10837 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10838 (overrun_check_free): Likewise.
10839
f2d3008d
PE
10840 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10841 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10842 word size.
10843
ec8df744
PE
10844 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10845 (gnutls_make_error): Rename local to avoid shadowing.
10846 (gnutls_emacs_global_deinit): ifdef out; not used.
10847 (Fgnutls_boot): Use const for pointer to readonly storage.
10848 Comment out unused local. Fix pointer signedness problems.
10849
640ee02d
PE
10850 * lread.c (openp): Don't stuff size_t into an 'int'.
10851 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10852 about possible signed overflow.
10853
6048fb2a
PE
10854 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10855 (GDK_KEY_g): Don't define if already defined.
10856 (xg_prepare_tooltip): Avoid pointer signedness problem.
10857 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10858
fa3c87e1
PE
10859 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10860 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10861
2172544b
PE
10862 * xfns.c (Fx_window_property): Simplify a bit,
10863 to make a bit faster and to avoid GCC 4.6.0 warning.
10864 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10865
9b821a21
PE
10866 * fns.c (internal_equal): Don't assume size_t fits in int.
10867
3c616cfa
PE
10868 * alloc.c (compact_small_strings): Tighten assertion a little.
10869
c2982e87
PE
10870 Replace pEd with more-general pI, and fix some printf arg casts.
10871 * lisp.h (pI): New macro, generalizing old pEd macro to other
10872 conversion specifiers. For example, use "...%"pI"d..." rather
10873 than "...%"pEd"...".
10874 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10875 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10876 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10877 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10878 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10879 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10880 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10881 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10882 64-bit hosts.
10883 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10884 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10885 * print.c (safe_debug_print, print_object): Likewise.
10886 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10887 to int.
6f04d126
PE
10888 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10889 avoiding the 0 flag, which is not portable.
c2982e87
PE
10890 * process.c (Fmake_network_process): Use pI to avoid cast.
10891 * region-cache.c (pp_cache): Likewise.
10892 * xdisp.c (decode_mode_spec): Likewise.
10893 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10894 behavior on 64-bit hosts with printf arg.
6f04d126 10895 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10896 (x_stop_queuing_selection_requests): Likewise.
10897 (x_get_window_property): Don't truncate byte count to an 'int'
10898 when tracing.
0b432f21 10899
5e073ec7
PE
10900 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10901 here, since it parses constructs like leading '-' and spaces,
10902 which are not wanted; and it overflows with large numbers.
10903 Instead, simply match F[0-9]+, which is what is wanted anyway.
10904
36372bf9
PE
10905 * alloc.c: Remove unportable assumptions about struct layout.
10906 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10907 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10908 (allocate_vectorlike, make_pure_vector): Use the new macros,
10909 plus offsetof, to remove unportable assumptions about struct layout.
10910 These assumptions hold on all porting targets that I know of, but
10911 they are not guaranteed, they're easy to remove, and removing them
10912 makes further changes easier.
10913
0b432f21
PE
10914 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10915 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10916 (string_overrun_cookie): Now const. Use initializers that
10917 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10918 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10919 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10920 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10921 multiple of sizeof (EMACS_INT); it need not be, if
10922 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10923 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10924
895009e1
JB
109252011-04-26 Juanma Barranquero <lekktu@gmail.com>
10926
10927 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10928
6a7a1b0b
TZ
109292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10930
10931 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10932 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10933 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10934
841a1577 109352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10936
10937 * lisp.h (Qdebug): List symbol.
895009e1 10938 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10939 * keyboard.c (debug-on-event): New variable.
10940 (handle_user_signal): Break into debugger when debug-on-event
10941 matches the current signal symbol.
10942
f2d3ba6f
DN
109432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10944
10945 * alloc.c (check_sblock, check_string_bytes)
10946 (check_string_free_list): Convert to standard C.
10947
42ce4c63
TZ
109482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10949
10950 * w32.c (emacs_gnutls_push): Fix typo.
10951
825cd63c
EZ
109522011-04-25 Eli Zaretskii <eliz@gnu.org>
10953
fb11d64d
EZ
10954 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10955 "cast to pointer from integer of different size".
10956
825cd63c
EZ
10957 Improve doprnt and its use in verror. (Bug#8545)
10958 * doprnt.c (doprnt): Document the set of format control sequences
10959 supported by the function. Use SAFE_ALLOCA instead of always
10960 using `alloca'.
10961
10962 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10963 is one byte too soon. Don't use xrealloc; instead xfree and
10964 xmalloc anew.
10965
e061a11b
TZ
109662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10967
10968 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10969 callbacks stage.
10970
10971 * gnutls.c: Renamed global_initialized to
10972 gnutls_global_initialized. Added internals for the
10973 :verify-hostname-error, :verify-error, and :verify-flags
10974 parameters of `gnutls-boot' and documented those parameters in the
10975 docstring. Start callback support.
9173deec
JB
10976 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10977 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10978 on error. Return error code.
e061a11b
TZ
10979 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10980 (emacs_gnutls_read): Likewise.
10981 (Fgnutls_boot): Return handshake error code.
10982 (emacs_gnutls_handle_error): New function.
10983 (wsaerror_to_errno): Likewise.
10984
10985 * w32.h (emacs_gnutls_pull): Add prototype.
10986 (emacs_gnutls_push): Likewise.
10987
10988 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10989 (emacs_gnutls_push): Likewise.
10990
109912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10992
10993 * process.c (wait_reading_process_output): Check if GnuTLS
10994 buffered some data internally if no FDs are set for TLS
10995 connections.
10996
10997 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10998 (LIBS): Link to USER_LIBS.
10999 ($(BLD)/gnutls.$(0)): New target.
11000
fa6996bc
EZ
110012011-04-24 Eli Zaretskii <eliz@gnu.org>
11002
eb35682e
EZ
11003 * xdisp.c (handle_single_display_spec): Rename the
11004 display_replaced_before_p argument into display_replaced_p, to
11005 make it consistent with the commentary. Fix typos in the
11006 commentary.
11007
e2ad650c
EZ
11008 * textprop.c (syms_of_textprop): Remove dead code.
11009 (copy_text_properties): Delete obsolete commentary about an
11010 interface that was deleted long ago. Fix typos in the description
11011 of arguments.
11012
1b2de274
EZ
11013 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11014 to changes in oldXMenu/XMenu.h from 2011-04-16.
11015 <menu_help_message, prev_menu_help_message>: Constify.
11016 (IT_menu_make_room): menu->help_text is now `const char **';
11017 adjust.
11018
11019 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11020 to changes in oldXMenu/XMenu.h from 2011-04-16.
11021 (struct XMenu): Declare `help_text' `const char **'.
11022
11023 * xfaces.c <Qunspecified>: Make extern again.
11024
11025 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11026 required by POSIX.
1b2de274 11027
762b15be
EZ
11028 * doc.c (get_doc_string): Improve the format passed to `error'.
11029
11030 * doprnt.c (doprnt): Improve commentary.
11031
11032 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11033
11034 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11035 them with etags.
11036
f1052e5d
EZ
11037 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11038 changes in globals.h immediately force recompilation.
762b15be
EZ
11039 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11040 $(CURDIR)/s/ms-w32.h.
11041 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11042
fa6996bc
EZ
11043 * character.c (Fchar_direction): Function deleted.
11044 (syms_of_character): Don't defsubr it.
11045 <char-direction-table>: Deleted.
11046
e6c3da20
EZ
110472011-04-23 Eli Zaretskii <eliz@gnu.org>
11048
11049 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11050 * doprnt.c: Include limits.h.
11051 (SIZE_MAX): New macro.
04f2d78b
CB
11052 (doprnt): Return a size_t value. 2nd arg is now size_t.
11053 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11054 Improve overflow protection. Support `l' modifier for integer
11055 conversions. Support %l conversion. Don't assume an EMACS_INT
11056 argument for integer conversions and for %c.
11057
11058 * lisp.h (doprnt): Restore prototype.
11059
11060 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11061 $(SRC)/character.h.
11062
11063 * Makefile.in (base_obj): Add back doprnt.o.
11064
11065 * deps.mk (doprnt.o): Add back prerequisites.
11066 (callint.o): Depend on character.h.
11067
11068 * eval.c (internal_lisp_condition_case): Include the handler
11069 representation in the error message.
11070 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11071 when breaking from the loop.
11072
11073 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11074
11075 * callint.c (Fcall_interactively): When displaying error message
11076 about invalid control letter, pass the character's codepoint, not
11077 a pointer to its multibyte form. Improve display of the character
11078 in octal and display also its hex code.
11079
11080 * character.c (char_string): Use %x to display the (unsigned)
11081 codepoint of an invalid character, to avoid displaying a bogus
11082 negative value.
11083
11084 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11085 `error', not SYMBOL_NAME itself.
11086
11087 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11088 character arguments to `error'.
11089
11090 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11091 to `error' in error message about FINAL_CHAR argument. Make sure
11092 FINAL_CHAR is a character, and use %c when it is passed as
11093 argument to `error'.
11094
4ffd0d6b 110952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11096
11097 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11098
11099 * w32.c: Include <time.h>.
11100 (sys_localtime): New function.
11101
4ffd0d6b 111022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11103
11104 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11105
4ffd0d6b 11106 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11107
4ffd0d6b 111082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11109
4ffd0d6b
GM
11110 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11111 zombies (Bug#8467).
aac0c6e3 11112
04c56954
EZ
111132011-04-19 Eli Zaretskii <eliz@gnu.org>
11114
11115 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11116 gl_state.e_property when gl_state.object is Qt.
11117
11118 * insdel.c (make_gap_larger): Remove limitation of buffer size
11119 to <= INT_MAX.
11120
16a43933
CY
111212011-04-18 Chong Yidong <cyd@stupidchicken.com>
11122
11123 * xdisp.c (lookup_glyphless_char_display)
11124 (produce_glyphless_glyph): Handle cons cell entry in
11125 glyphless-char-display.
11126 (Vglyphless_char_display): Document it.
11127
11128 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11129 glyphless-char-display.
11130
4581706e
CY
111312011-04-17 Chong Yidong <cyd@stupidchicken.com>
11132
11133 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11134
11135 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11136
11137 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11138 definition for no-X builds.
11139
4887c6e2 111402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11141
fd35b6f9
PE
11142 Static checks with GCC 4.6.0 and non-default toolkits.
11143
5c1ccb01
PE
11144 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11145
006c5daa
PE
11146 * process.c (keyboard_bit_set): Define only if SIGIO.
11147 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11148 (send_process): Repair possible setjmp clobbering.
11149
efc736d3
PE
11150 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11151
4e2fe2e6
PE
11152 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11153
f97334a2
PE
11154 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11155
4e75f29d
PE
11156 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11157 Define only if needed.
11158
90efadd1
PE
11159 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11160 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11161 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11162
3c647824
PE
11163 * dispextern.h (struct redisplay_interface): Rename param
11164 to avoid shadowing.
e264f262 11165 * termhooks.h (struct terminal): Likewise.
761383f4 11166 * xterm.c (xembed_send_message): Likewise.
3c647824 11167
b58c5c4a
PE
11168 * insdel.c (make_gap_smaller): Define only if
11169 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11170
cad59032
PE
11171 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11172 it.
11173
c339dc2e
PE
11174 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11175 so that we aren't warned about unused symbols.
11176
91a3e27b
PE
11177 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11178
399c71d3 11179 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11180
8ffc96f5
PE
11181 * xfns.c (x_real_positions): Mark locals as initialized.
11182
eef9bc79
PE
11183 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11184
098db9dd
PE
11185 * xterm.c: Fix problems found by static analysis with other toolkits.
11186 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11187 (x_dispatch_event): Declare static if USE_GTK, and
11188 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11189 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11190 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11191 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11192 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11193
eb18f6cc
PE
11194 * xmenu.c (menu_help_callback): Pointer type fixes.
11195 Use const pointers when pointing at readonly data. Avoid pointer
11196 signedness clashes.
11197 (FALSE): Remove unused macro.
11198 (update_frame_menubar): Remove unused decl.
11199
1fe72bf8
PE
11200 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11201
60d9e1db
PE
11202 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11203 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11204 (single_menu_item): Rename local to avoid shadowing.
11205
39261c26
PE
11206 * keyboard.c (make_lispy_event): Remove unused local var.
11207
018c5e19
PE
11208 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11209 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11210
63d2b86e
PE
11211 * bitmaps: Change bitmaps from unsigned char back to the X11
11212 compatible char. Avoid the old compiler warnings about
11213 out-of-range initializers by using, for example, '\xab' rather
11214 than 0xab.
11215
aefd87e1
PE
11216 * xgselect.c (xgselect_initialize): Check vs interface
11217 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11218
bf501fb9
PE
11219 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11220
e9829fdf
PE
11221 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11222 to read-only memory.
11223
1086c095
PE
11224 * fns.c (vector): Remove; this old hack is no longer needed.
11225
2baccd04 11226 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11227 Remove unused var.
dde42981 11228 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11229
72391843 11230 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11231
436c16df 11232 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11233 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11234 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11235
92bb796d 11236 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11237 (x_term_init): Remove local to avoid shadowing.
92bb796d 11238
764430a3 11239 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11240
11241 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11242 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11243
d1dfb56c
EZ
112442011-04-16 Eli Zaretskii <eliz@gnu.org>
11245
c4354cb4
EZ
11246 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11247
d1dfb56c
EZ
11248 Fix regex.c, syntax.c and friends for buffers > 2GB.
11249 * syntax.h (struct gl_state_s): Declare character position members
11250 EMACS_INT.
11251
11252 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11253
04f2d78b
CB
11254 * textprop.c (verify_interval_modification, interval_of):
11255 Declare arguments EMACS_INT.
d1dfb56c
EZ
11256
11257 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11258 EMACS_INT.
11259
11260 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11261
11262 * indent.c (Fvertical_motion): Local variable it_start is now
11263 EMACS_INT.
11264
11265 * regex.c (re_match, re_match_2, re_match_2_internal)
11266 (bcmp_translate, regcomp, regexec, print_double_string)
11267 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11268 (re_compile_pattern, re_exec): Declare arguments and local
11269 variables `size_t' and `ssize_t' and return values `regoff_t', as
11270 appropriate.
11271 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11272 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11273 <compile_stack_type>: `size' and `avail' are now `size_t'.
11274
11275 * regex.h <regoff_t>: Use ssize_t, not int.
11276 (re_search, re_search_2, re_match, re_match_2): Arguments that
11277 specify buffer/string position and length are now ssize_t and
11278 size_t. Return type is regoff_t.
11279
613052cd
BK
112802011-04-16 Ben Key <bkey76@gmail.com>
11281
11282 * nsfont.m: Fixed bugs in ns_get_family and
11283 ns_descriptor_to_entity that were caused by using free to
11284 deallocate memory blocks that were allocated by xmalloc (via
11285 xstrdup). This caused Emacs to crash when compiled with
11286 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11287 --enable-checking=xmallocoverrun). xfree is now used to
11288 deallocate these memory blocks.
11289
4170f62f 112902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11291
71b41406
PE
11292 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11293
9587a89d
PE
11294 emacs_write: Accept and return EMACS_INT for sizes.
11295 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11296 et seq.
11297 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11298 Accept and return EMACS_INT.
11299 (emacs_gnutls_write): Return the number of bytes written on
11300 partial writes.
11301 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11302 (emacs_read, emacs_write): Remove check for negative size, as the
11303 Emacs source code has been audited now.
9587a89d
PE
11304 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11305 (emacs_read, emacs_write): Use it.
273a5f82
PE
11306 * process.c (send_process): Adjust to the new signatures of
11307 emacs_write and emacs_gnutls_write. Do not attempt to store
11308 a byte offset into an 'int'; it might overflow.
9587a89d 11309 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11310
3e047f51
PE
11311 * sound.c: Don't assume sizes fit in 'int'.
11312 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11313 Return EMACS_INT, not int.
3e047f51 11314 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11315 Accept EMACS_INT, not int.
11316 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11317 record read return values.
11318
cc39a9db
BK
113192011-04-15 Ben Key <bkey76@gmail.com>
11320
c9d0ec6d
JB
11321 * keyboard.c (Qundefined): Don't declare static since it is used
11322 in nsfns.m.
11323 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11324 static since they are used in nsfont.m.
cc39a9db 11325
6c60eb9f
SM
113262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11327
11328 * process.c (Qprocessp): Don't declare static.
11329 * lisp.h (Qprocessp): Declare again.
11330
7990b61a
JB
113312011-04-15 Juanma Barranquero <lekktu@gmail.com>
11332
11333 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11334
5d4cb038
PE
113352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11336
8bd7b830 11337 Improve C-level modularity by making more things 'static'.
cd64ea1d 11338
e3b27b31
PE
11339 Don't publish debugger-only interfaces to other modules.
11340 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11341 (verify_bytepos, count_markers): Move decls to the only modules
11342 that need them.
11343 * region-cache.h (pp_cache): Likewise.
11344 * window.h (check_all_windows): Likewise.
11345 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11346
5d4cb038
PE
11347 * sysdep.c (croak): Now static, if
11348 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11349 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11350
11351 * alloc.c (refill_memory_reserve): Now static if
11352 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11353 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11354
e87b6180
PE
11355 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11356 Define only if USE_LUCID.
11357
ac64929e
PE
11358 * xrdb.c (x_customization_string, x_rm_string): Now static.
11359
6f37259d
PE
11360 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11361 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11362
1683e3ab
PE
11363 * xdisp.c (draw_row_with_mouse_face): Now static.
11364 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11365
de9c2632
PE
11366 * window.h (check_all_windows): Mark externally visible.
11367
2b96acb7
PE
11368 * window.c (window_deletion_count): Now static.
11369
11370 * undo.c: Make symbols static if they're not exported.
11371 (last_undo_buffer, last_boundary_position, pending_boundary):
11372 Now static.
11373
50436f33
PE
11374 * textprop.c (interval_insert_behind_hooks): Now static.
11375 (interval_insert_in_front_hooks): Likewise.
11376
64520e5c
PE
11377 * term.c: Make symbols static if they're not exported.
11378 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11379 (max_frame_lines, tty_set_terminal_modes):
11380 (tty_reset_terminal_modes, tty_turn_off_highlight):
11381 (get_tty_terminal): Now static.
11382 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11383 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11384 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11385 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11386 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11387
1fa53021
PE
11388 * sysdep.c: Make symbols static if they're not exported.
11389 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11390 Now static.
11391 (sigprocmask_set, full_mask): Remove; unused.
11392 (wait_debugging): Mark as visible.
11393 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11394 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11395
d4b43b22
PE
11396 * syntax.c (syntax_temp): Define only if !__GNUC__.
11397
b7c513d0
PE
11398 * sound.c (current_sound_device, current_sound): Now static.
11399
989b29ad
PE
11400 * search.c (searchbufs, searchbuf_head): Now static.
11401
13a55a78
PE
11402 * scroll.c (scroll_cost): Remove; unused.
11403 * dispextern.h (scroll_cost): Remove decl.
11404
de68a1fc
PE
11405 * region-cache.h (pp_cache): Mark as externally visible.
11406
40ccffa6
PE
11407 * process.c: Make symbols static if they're not exported.
11408 (process_tick, update_tick, create_process, chan_process):
11409 (Vprocess_alist, proc_buffered_char, datagram_access):
11410 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11411 (deactivate_process): Mark defn as static, as well as decl.
11412 * lisp.h (create_process): Remove decl.
11413 * process.h (chan_process, Vprocess_alist): Remove decls.
11414
ad64fc97
PE
11415 * print.c: Make symbols static if they're not exported.
11416 (print_depth, new_backquote_output, being_printed, print_buffer):
11417 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11418 (print_interval, print_number_index, initial_stderr_stream):
11419 Now static.
11420 * lisp.h (Fprinc): Remove decl.
11421 (debug_output_compilation_hack): Mark as externally visible.
11422
adddb265
PE
11423 * sysdep.c (croak): Move decl from here to syssignal.h.
11424 * syssignal.h (croak): Put it here, so the API can be checked when
11425 'croak' is called from dissociate_if_controlling_tty.
11426
1717ede2
PE
11427 * minibuf.c: Make symbols static if they're not exported.
11428 (minibuf_save_list, choose_minibuf_frame): Now static.
11429 * lisp.h (choose_minibuf_frame): Remove decl.
11430
fa5fb2bc
PE
11431 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11432
1e3890d1
PE
11433 * lread.c: Make symbols static if they're not exported.
11434 (read_objects, initial_obarray, oblookup_last_bucket_number):
11435 Now static.
11436 (make_symbol): Remove; unused.
11437 * lisp.h (initial_obarray, make_symbol): Remove decls.
11438
8a1414fa
PE
11439 * keyboard.c: Make symbols static if they're not exported.
11440 (single_kboard, recent_keys_index, total_keys, recent_keys):
11441 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11442 (this_single_command_key_start, echoing, last_auto_save):
11443 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11444 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11445 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11446 (Vlispy_mouse_stem, double_click_count):
11447 Now static.
11448 (force_auto_save_soon): Define only if SIGDANGER.
11449 (ignore_mouse_drag_p): Now static if
11450 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11451 (print_help): Remove; unused.
11452 (stop_character, last_timer_event): Mark as externally visible.
11453 * keyboard.h (ignore_mouse_drag_p): Declare only if
11454 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11455 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11456 * lisp.h (echoing): Remove decl.
11457 (force_auto_save_soon): Declare only if SIGDANGER.
11458 * xdisp.c (redisplay_window): Simplify code, to make it more
11459 obvious that ignore_mouse_drag_p is not accessed if !defined
11460 USE_GTK && !defined HAVE_NS.
11461
93ea6e8f
PE
11462 * intervals.c: Make symbols static if they're not exported.
11463 (merge_properties_sticky, merge_interval_right, delete_interval):
11464 Now static.
11465 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11466
77382fcc
PE
11467 * insdel.c: Make symbols static if they're not exported.
11468 However, leave prepare_to_modify_buffer alone. It's never
11469 called from outside this function, but that appears to be a bug.
11470 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11471 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11472 (adjust_after_replace_noundo): Remove; unused.
11473 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11474 (signal_before_change): Remove decls.
77382fcc 11475
9306c32e
PE
11476 * indent.c (val_compute_motion, val_vmotion): Now static.
11477
cd44d2eb
PE
11478 * image.c: Make symbols static if they're not exported.
11479 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11480 if USE_GTK.
11481 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11482 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11483
ad9a7a06
PE
11484 * fringe.c (standard_bitmaps): Now static.
11485 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11486
81626931
PE
11487 * frame.c: Make symbols static if they're not exported.
11488 (x_report_frame_params, make_terminal_frame): Now static.
11489 (get_frame_param): Now static, unless HAVE_NS.
11490 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11491 (x_get_resource_string): Remove; not used.
11492 * frame.h (make_terminal_frame, x_report_frame_params):
11493 (x_get_resource_string); Remove decls.
11494 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11495 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11496
239f9db9
PE
11497 * font.c, fontset.c: Make symbols static if they're not exported.
11498 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11499 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11500 * font.c (font_close_object): Now static.
11501 * font.h (font_close_object): Remove.
11502 * fontset.c (FONTSET_OBJLIST): Remove.
11503 (free_realized_fontset) #if-0 the body, which does nothing.
11504 (face_suitable_for_char_p): #if-0, as it's never called.
11505 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11506 * xfaces.c (face_at_string_position):
11507 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11508 since 0 is always ASCII.
11509
dfcf3579
PE
11510 * fns.c (weak_hash_tables): Now static.
11511
5045092b
PE
11512 * fileio.c: Make symbols static if they're not exported.
11513 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11514 (Vwrite_region_annotation_buffers): Now static.
11515
57a96f5c
PE
11516 * eval.c: Make symbols static if they're not exported.
11517 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11518 * lisp.h (backtrace_list): Remove decl.
11519
35f08c38
PE
11520 * emacs.c: Make symbols static if they're not exported.
11521 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11522 (fatal_error_code, fatal_error_signal_hook, standard_args):
11523 Now static.
11524 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11525 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11526 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11527 * lisp.h (fatal_error_signal_hook): Remove decl.
11528 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11529
f44bd759
PE
11530 * editfns.c: Move a (normally-unused) function to its only use.
11531 * editfns.c, lisp.h (get_operating_system_release): Remove.
11532 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11533 worth the hassle of breaking this out.
11534
b532497d
PE
11535 * xterm.c: Make symbols static if they're not exported.
11536 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11537 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11538 (x_destroy_window, x_delete_display):
11539 Now static.
11540 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11541 (x_mouse_leave): Remove; unused.
11542 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11543 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11544 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11545 Remove decls.
11546 (x_mouse_leave): Declare only if WINDOWSNT.
11547 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11548 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11549 USE_X_TOOLKIT.
11550
1675728f
PE
11551 * ftxfont.c: Make symbols static if they're not exported.
11552 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11553 HAVE_FREETYPE.
11554 * font.h (ftxfont_driver): Likewise.
11555
e4cebfca
PE
11556 * xfns.c: Make symbols static if they're not exported.
11557 (x_last_font_name, x_display_info_for_name):
11558 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11559 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11560 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11561 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11562 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11563 (last_show_tip_args): Now static.
11564 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11565 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11566 (x_screen_planes): Remove; unused.
11567 * dispextern.h (x_screen_planes): Remove decl.
11568
5bf46f05
PE
11569 * dispnew.c: Make symbols static if they're not exported.
11570 * dispextern.h (redraw_garbaged_frames, scrolling):
11571 (increment_row_positions): Remove.
11572 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11573 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11574 Now static.
11575 (redraw_garbaged_frames): Remove; unused.
11576
435f4c28
PE
11577 * xfaces.c: Make symbols static if they're not exported.
11578 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11579 Remove decls.
11580 * xterm.h (defined_color): Remove decls.
11581 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11582 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11583 (menu_face_changed_default, defined_color, free_realized_face):
11584 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11585 (ascii_face_of_lisp_face): Remove; unused.
11586
8524aef3
PE
11587 * xdisp.c: Make symbols static if they're not exported.
11588 * dispextern.h (scratch_glyph_row, window_box_edges):
11589 (glyph_to_pixel_coords, set_cursor_from_row):
11590 (get_next_display_element, set_iterator_to_next):
11591 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11592 (show_mouse_face): Remove decls
11593 * frame.h (message_buf_print): Likewise.
11594 * lisp.h (pop_message, set_message, check_point_in_composition):
11595 Likewise.
11596 * xterm.h (set_vertical_scroll_bar): Likewise.
11597 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11598 (message_buf_print, scratch_glyph_row, displayed_buffer):
11599 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11600 (get_next_display_element, show_mouse_face, window_box_edges):
11601 (frame_to_window_pixel_xy, check_point_in_composition):
11602 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11603 (glyph_to_pixel_coords): Remove; unused.
11604
16390cd2
PE
11605 * dired.c (file_name_completion): Now static.
11606
11607 * dbusbind.c (xd_in_read_queued_messages): Now static.
11608
a25f4dfa
PE
11609 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11610 * data.c (circular_list_error): Remove.
11611
14a9c8df
PE
11612 * commands.h (last_point_position, last_point_position_buffer):
11613 (last_point_position_window): Remove decls.
11614 * keyboard.c: Make these variables static.
11615
04f2d78b
CB
11616 * coding.h (coding, code_convert_region, encode_coding_gap):
11617 Remove decls.
74ab6df5
PE
11618 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11619 (iso_code_class, detect_coding, code_convert_region): Now static.
11620 (encode_coding_gap): Remove; unused.
11621
38dfbee1
PE
11622 * chartab.c (chartab_chars, chartab_bits): Now static.
11623
a2cb4e63
PE
11624 * charset.h (charset_iso_8859_1): Remove decl.
11625 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11626 Now static.
11627
127198fd
PE
11628 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11629 * ccl.c (Vccl_program_table): Now static.
11630 (check_ccl_update): Remove; unused.
11631
d85b608f
PE
11632 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11633 * category.h: ... from here.
11634 * category.c (check_category_table, set_category_set): Now static.
11635
31cd66f3
PE
11636 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11637 * lisp.h: Remove these decls.
11638
c358e587
PE
11639 * buffer.c (buffer_count): Remove unused var.
11640
e78aecca
PE
11641 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11642 so that it's not optimized away.
11643 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11644 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11645 exported only to the debugger.
11646
e192d7d3 11647 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11648 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11649
92470028
PE
11650 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11651 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11652 was inaccessible from Lisp.
11653 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11654 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11655
244ed907
PE
11656 alloc.c: Import and export fewer symbols, and remove unused items.
11657 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11658 is defined.
11659 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11660 it's not optimized away by whole-program optimization.
11661 (message_enable_multibyte, free_misc): Remove.
11662 (catchlist, handlerlist, mark_backtrace):
11663 Declare only if BYTE_MARK_STACK.
11664 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11665 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11666 (message_enable_multibyte): Remove decl.
11667 (free_misc, interval_free_list, float_block, float_block_index):
11668 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11669 (cons_free_list, last_marked_index):
11670 Now static.
11671 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11672 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11673 (mark_backtrace): Define only if BYTE_MARK_STACK.
11674 * xdisp.c (message_enable_multibyte): Now static.
11675
61c2b50e 11676 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11677 This makes it easier for human readers (and static analyzers)
11678 to see whether these variables are used from other modules.
11679 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11680 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11681 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11682 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11683 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11684 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11685 * xmenu.c, xselect.c:
11686 Declare Q* vars static if they are not used in other modules.
11687 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11688 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11689 Remove decls of unexported vars.
11690 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11691
95c82688
PE
11692 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11693
16a97296
PE
11694 Make Emacs functions such as Fatom 'static' by default.
11695 This makes it easier for human readers (and static analyzers)
11696 to see whether these functions can be called from other modules.
11697 DEFUN now defines a static function. To make the function external
11698 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11699 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11700 (Finit_image_library):
16a97296
PE
11701 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11702 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11703 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11704 Remove decls, since these functions are now static.
11705 (Funintern, Fget_internal_run_time): New decls, since these functions
11706 were already external.
95c82688 11707
16a97296
PE
11708 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11709 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11710 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11711 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11712 * keyboard.c, keymap.c, lread.c:
11713 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11714 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11715 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11716 Mark functions with DEFUE instead of DEFUN,
11717 if they are used in other modules.
11718 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11719 decls for now-static functions.
11720 * buffer.h (Fdelete_overlay): Remove decl.
11721 * callproc.c (Fgetenv_internal): Mark as internal.
11722 * composite.c (Fremove_list_of_text_properties): Remove decl.
11723 (Fcomposition_get_gstring): New forward static decl.
11724 * composite.h (Fcomposite_get_gstring): Remove decl.
11725 * dired.c (Ffile_attributes): New forward static decl.
11726 * doc.c (Fdocumntation_property): New forward static decl.
11727 * eval.c (Ffetch_bytecode): New forward static decl.
11728 (Funintern): Remove extern decl; now in .h file where it belongs.
11729 * fileio.c (Fmake_symbolic_link): New forward static decl.
11730 * image.c (Finit_image_library): New forward static decl.
11731 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11732 * intervals.h (Fprevious_property_change):
11733 (Fremove_list_of_text_properties): Remove decls.
11734 * keyboard.c (Fthis_command_keys): Remove decl.
11735 (Fcommand_execute): New forward static decl.
11736 * keymap.c (Flookup_key): New forward static decl.
11737 (Fcopy_keymap): Now static.
11738 * keymap.h (Flookup_key): Remove decl.
11739 * process.c (Fget_process): New forward static decl.
11740 (Fprocess_datagram_address): Mark as internal.
11741 * syntax.c (Fsyntax_table_p): New forward static decl.
11742 (skip_chars): Remove duplicate decl.
11743 * textprop.c (Fprevious_property_change): New forward static decl.
11744 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11745 Now internal.
11746 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11747 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11748
785bbd42
PE
11749 * editfns.c (Fformat): Remove unreachable code.
11750
8b913b57
AS
117512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11752
11753 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11754 change. (Bug#8496)
11755
a6744a35
EZ
117562011-04-13 Eli Zaretskii <eliz@gnu.org>
11757
11758 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11759 when at ZV. (Bug#8487)
11760
e7974947
AS
117612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11762
baad03f0
AS
11763 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11764 (Bug#8437)
11765 * keyboard.c (parse_tool_bar_item): Likewise.
11766 * sound.c (sound_cleanup, alsa_close): Likewise.
11767 * termcap.c (tgetent): Likewise.
11768 * xfns.c (x_default_font_parameter): Likewise.
11769 * xsettings.c (read_and_apply_settings): Likewise.
11770
e7974947
AS
11771 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11772 (overrun_check_free): Protoize.
11773
28272684
PE
117742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11775
11776 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11777 since callers should never pass a negative size.
11778 Change the signature to match that of plain 'read' and 'write'; see
11779 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11780 * lisp.h: Update prototypes of emacs_write and emacs_read.
11781
11997c76
EZ
117822011-04-11 Eli Zaretskii <eliz@gnu.org>
11783
11784 * xdisp.c (redisplay_window): Don't try to determine the character
11785 position of the scroll margin if the window start point w->startp
e896f03c 11786 is outside the buffer's accessible region. (Bug#8468)
11997c76 11787
8a2cbd72
EZ
117882011-04-10 Eli Zaretskii <eliz@gnu.org>
11789
11790 Fix write-region and its subroutines for buffers > 2GB.
11791 * fileio.c (a_write, e_write): Modify declaration of arguments and
11792 local variables to support buffers larger than 2GB.
11793 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11794
11795 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11796 argument, local variables, and return value.
11797
11798 * lisp.h: Update prototypes of emacs_write and emacs_read.
11799
11800 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11801
4073e537 118022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11803
1ebfdcb6
PE
11804 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11805
b2ded58d
PE
11806 Fix more problems found by GCC 4.6.0's static checks.
11807
7d66342c
PE
11808 * xdisp.c (vmessage): Use a better test for character truncation.
11809
bbf47d44
PE
11810 * charset.c (load_charset_map): <, not <=, for optimization,
11811 and to avoid potential problems with integer overflow.
9248994d 11812 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11813 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11814 * editfns.c (Fformat): Likewise.
1e69125e 11815 * syntax.c (skip_chars): Likewise.
3befa583 11816
e3019616
PE
11817 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11818 This also lets GCC 4.6.0 generate slightly better loop code.
11819
becfa255
PE
11820 * callint.c (Fcall_interactively): <, not <=, for optimization.
11821 (Fcall_interactively): Count the number of arguments produced,
11822 not the number of arguments given. This is simpler and lets GCC
11823 4.6.0 generate slightly better code.
11824
dae0cd48
PE
11825 * ftfont.c: Distingish more carefully between FcChar8 and char.
11826 The previous code passed unsigned char * to a functions like
11827 strlen and xstrcasecmp that expect char *, which does not
11828 conform to the C standard.
11829 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11830 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11831 char * when the C standard requires it.
11832
76032d70
PE
11833 * keyboard.c (read_char): Remove unused var.
11834
eb3f1cc8
PE
11835 * eval.c: Port to Windows vsnprintf (Bug#8435).
11836 Include <limits.h>.
11837 (SIZE_MAX): Define if the headers do not.
11838 (verror): Do not give up if vsnprintf returns a negative count.
11839 Instead, grow the buffer. This ports to Windows vsnprintf, which
11840 does not conform to C99. Problem reported by Eli Zaretskii.
11841 Also, simplify the allocation scheme, by avoiding the need for
11842 calling realloc, and removing the ALLOCATED variable.
11843
70476b54
PE
11844 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11845
12020a9e
PE
11846 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11847 But keep the doprint source code for now, as we might revamp it
11848 and use it again (Bug#8435).
ea6c7ae6
PE
11849 * lisp.h (doprnt): Remove.
11850 * Makefile.in (base_obj): Remove doprnt.o.
11851 * deps.mk (doprnt.o): Remove.
11852
5fdb398c
PE
11853 error: Print 32- and 64-bit integers portably (Bug#8435).
11854 Without this change, on typical 64-bit hosts error ("...%d...", N)
11855 was used to print both 32- and 64-bit integers N, which relied on
11856 undefined behavior.
61bdb816 11857 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11858 * lisp.h (error, verror): Mark as printf-like functions.
11859 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11860 Report overflow in size calculations when allocating printf buffer.
11861 Do not truncate output string at its first null byte.
11862 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11863 Truncate the output at a character boundary, since vsnprintf does not
11864 do that.
11865 * charset.c (check_iso_charset_parameter): Convert internal
11866 character to string before calling 'error', since %c now has the
11867 printf meaning.
11868 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11869 overflow when computing char to be passed to 'error'. Do not
11870 pass Lisp_Object to 'error'; pass the integer instead.
11871 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11872 formatted with plain %d.
11873
b189fa66
PE
11874 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11875
bff87ef0
PE
11876 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11877
7e2cac20
PE
11878 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11879
ce4d90b5
PE
11880 * xterm.c (x_catch_errors): Remove duplicate declaration.
11881
266c9547
PE
11882 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11883
79c49ad2
PE
11884 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11885
368f4090
JM
118862011-04-10 Jim Meyering <meyering@redhat.com>
11887
11888 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11889 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11890 return ssize_t not "int", and use size_t as the buffer length.
11891 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11892 * gnutls.h: Update declarations.
11893 * process.c (read_process_output): Use ssize_t, to match.
11894 (send_process): Likewise.
11895
a32d4040
CY
118962011-04-09 Chong Yidong <cyd@stupidchicken.com>
11897
11898 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11899
8546720e 119002011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11901
04f2d78b
CB
11902 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11903 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11904
8546720e
GM
11905 * xterm.c (handle_one_xevent):
11906 * xmenu.c (create_and_show_popup_menu):
11907 * xselect.c (x_decline_selection_request)
11908 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11909
0a2f5c1a 119102011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11911
11912 Fix some uses of `int' instead of EMACS_INT.
11913 * search.c (string_match_1, fast_string_match)
11914 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11915 (scan_buffer, find_next_newline_no_quit)
11916 (find_before_next_newline, search_command, Freplace_match)
11917 (Fmatch_data): Make some `int' variables be EMACS_INT.
11918
11919 * xdisp.c (display_count_lines): 3rd argument and return value now
11920 EMACS_INT. All callers changed.
11921 (pint2hrstr): Last argument is now EMACS_INT.
11922
11923 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11924 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11925 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11926 (decode_coding_utf_16, decode_coding_emacs_mule)
11927 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11928 (decode_coding_ccl, decode_coding_charset)
11929 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11930 (decode_coding_iso_2022, decode_coding_emacs_mule)
11931 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11932 <char_offset, last_offset>: Declare EMACS_INT.
11933 (encode_coding_utf_8, encode_coding_utf_16)
11934 (encode_coding_emacs_mule, encode_invocation_designation)
11935 (encode_designation_at_bol, encode_coding_iso_2022)
11936 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11937 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11938 Declare EMACS_INT.
11939 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11940 (encode_invocation_designation): Last argument P_NCHARS is now
11941 EMACS_INT.
11942 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11943 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11944
11945 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11946 All users changed.
11947
11948 * ccl.c (Fccl_execute_on_string): Declare some variables
11949 EMACS_INT.
11950
8546720e 119512011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11952
11953 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11954
4e19a977
CS
119552011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11956
11957 * process.c (Fformat_network_address): Doc fix.
11958
87302331
R
119592011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11960
ee7683eb 11961 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11962
cbb59342
CY
119632011-04-08 Chong Yidong <cyd@stupidchicken.com>
11964
11965 * keyboard.c (read_char): Call Lisp function help-form-show,
11966 instead of using internal_with_output_to_temp_buffer.
11967 (Qhelp_form_show): New var.
e0d38eeb 11968 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11969
11970 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11971
11972 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11973
e67a13ab
CY
119742011-04-06 Chong Yidong <cyd@stupidchicken.com>
11975
04f2d78b
CB
11976 * process.c (Flist_processes): Remove to Lisp.
11977 (list_processes_1): Delete.
e67a13ab 11978
973f782d
EZ
119792011-04-06 Eli Zaretskii <eliz@gnu.org>
11980
7c106b1e
EZ
11981 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11982
973f782d
EZ
11983 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11984
41cf7d1a 119852011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11986
ca23cc88
PE
11987 Fix more problems found by GCC 4.6.0's static checks.
11988
f390e2d5
PE
11989 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11990
42eea0d0
PE
11991 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11992
b69769da 11993 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11994
f9541e84
PE
11995 * xdisp.c (vmessage): Mark as a printf-like function.
11996
13841b55
PE
11997 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11998
c136c10f
PE
11999 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12000
5e2d4a30
PE
12001 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12002 printf-like functions.
12003 (tiff_load): Add casts to remove these marks before passing them
12004 to system-supplied API.
12005
583f48b9
PE
12006 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12007
b25d760e
PE
12008 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12009 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12010 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12011 directly, rather than having caller test rule sign. This avoids
12012 some unnecessary tests.
12013 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12014 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12015 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12016
bc7b6697 12017 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12018 (xfont_open): Avoid unnecessary tests.
bc7b6697 12019
27ccc379
PE
12020 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12021
dcd5c89a
PE
12022 * composite.h, composite.c (composition_gstring_put_cache):
12023 Use EMACS_INT, not int, for length.
12024
b13a45c6
PE
12025 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12026 breaking out part of COMPOSITION_DECODE_RULE.
12027 (COMPOSITION_DECODE_RULE): Use it.
12028 * composite.c (get_composition_id): Remove unused local vars,
12029 by using the new macro.
12030
1e792e4d
PE
12031 * textprop.c (set_text_properties_1): Change while to do-while,
12032 since the condition is always true at first.
12033
dc6c6455 12034 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12035 (interval_deletion_adjustment): Return unsigned value.
12036 All uses changed.
dc6c6455 12037
aba7731a
PE
12038 * process.c (list_processes_1, create_pty, read_process_output):
12039 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12040 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12041 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12042 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12043 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12044
fdfc4bf3
PE
12045 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12046
fca8fe46 12047 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12048 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12049
06a0259a 12050 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12051 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12052 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12053
e7b9e80f
PE
12054 * print.c (print_error_message): Avoid int overflow.
12055
56201685
PE
12056 * font.c (font_list_entities): Redo for clarity,
12057 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12058
78834453 12059 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12060 (font_score): Avoid potential overflow in diff calculation.
78834453 12061
0bc0b309 12062 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12063 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12064
e610eaca
PE
12065 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12066
b895abce
PE
12067 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12068 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12069 can always succeed if overflow has undefined behavior.
12070
1f1d9321 12071 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12072 (wordify): Omit three unnecessary tests.
1f1d9321 12073
c59478bc
PE
12074 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12075 All callers changed. This avoids the need for an unused var.
12076
79b73827
PE
12077 * casefiddle.c (casify_region): Remove var that is set but not used.
12078
a4db5dfe
PE
12079 * dired.c (file_name_completion): Remove var that is set but not used.
12080
43aae36e
PE
12081 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12082
2a47c44d 12083 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12084 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12085
a37c69bf
PE
12086 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12087 Check for integer overflow on size calculations.
12088
328ab8e7
PE
12089 * buffer.c (Fprevious_overlay_change): Remove var that is set
12090 but not used.
12091
e5a2a5cb
PE
12092 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12093 Remove vars that are set but not used.
8d84a6eb 12094 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12095 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12096
a60e5f68
PE
12097 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12098
f661cb61 12099 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12100 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12101
f0397f5a
PE
12102 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12103 that are set but not used.
12104
8664db06 12105 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12106 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12107
6abdaa4a
PE
12108 * xselect.c (x_get_local_selection, x_handle_property_notify):
12109 Remove vars that are set but not used.
12110
0ce7538d 12111 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12112 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12113
9ae848fc
PE
12114 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12115 Remove var that is set but not used.
0b918413
PE
12116 (scroll_bar_windows_size): Now size_t, not int.
12117 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12118 Check for overflow.
9ae848fc 12119
a5a62657
PE
12120 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12121 (map_tty_color) [!defined MSDOS]: Likewise.
12122
5c5cdd39
PE
12123 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12124
66ebf983
PE
12125 * coding.c: Remove vars that are set but not used.
12126 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12127 All callers changed.
12128 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12129 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12130 (decode_coding_charset): Remove vars that are set but not used.
12131
1be4d761
PE
12132 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12133 that is set but not used.
12134
47553fa8
PE
12135 * print.c (print_object): Remove var that is set but not used.
12136
1f7196bf 12137 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12138 The gnulib version avoids calling malloc in the usual case,
12139 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12140 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12141 * filelock.c (current_lock_owner): Likewise.
12142 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12143 * sysdep.c: Include allocator.h, careadlinkat.h.
12144 (emacs_no_realloc_allocator): New static constant.
12145 (emacs_readlink): New function.
fdb61804
PE
12146 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12147 ../lib/careadlinkat.h.
d1fdcab7 12148
f84c17c7
SM
121492011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12150
12151 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12152 first non-nil return value).
12153
ef3862ad
JD
121542011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12155
12156 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12157 if not defined (Bug#8403).
12158
376a7006
JB
121592011-04-02 Juanma Barranquero <lekktu@gmail.com>
12160
12161 * xdisp.c (display_count_lines): Remove parameter `start',
12162 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12163 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12164 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12165 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12166 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12167 and thereabouts. All callers changed.
12168 (get_per_char_metric): Remove parameter `f', unused since
12169 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12170
6ca3801d
JM
121712011-04-02 Jim Meyering <meyering@redhat.com>
12172
12173 do not dereference NULL upon failed strdup
12174 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12175 (ns_get_family): Likewise.
12176
d8e2b5ba
JB
121772011-04-02 Juanma Barranquero <lekktu@gmail.com>
12178
12179 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12180
8c74fcbd
JD
121812011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12182
12183 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12184 later (Bug#8403).
12185
7200d79c
SM
121862011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12187
03408648 12188 Add lexical binding.
7200d79c 12189
03408648
SM
12190 * window.c (Ftemp_output_buffer_show): New fun.
12191 (Fsave_window_excursion):
12192 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12193
12194 * lread.c (lisp_file_lexically_bound_p): New function.
12195 (Fload): Bind Qlexical_binding.
12196 (readevalloop): Remove `evalfun' arg.
12197 Bind Qinternal_interpreter_environment.
12198 (Feval_buffer): Bind Qlexical_binding.
12199 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12200 Mark as dynamic.
12201 (syms_of_lread): Declare `lexical-binding'.
12202
12203 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12204
12205 * keyboard.c (eval_dyn): New fun.
12206 (menu_item_eval_property): Use it.
ca105506
SM
12207
12208 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12209
03408648
SM
12210 * fns.c (concat, mapcar1): Accept byte-code-functions.
12211
12212 * eval.c (Fsetq): Handle lexical vars.
12213 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12214 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12215 (FletX, Flet): Obey lexical binding.
12216 (Fcommandp): Handle closures.
12217 (Feval): New `lexical' arg.
12218 (eval_sub): New function extracted from Feval. Use it almost
12219 everywhere where Feval was used. Look up vars in lexical env.
12220 Handle closures.
12221 (Ffunctionp): Move from subr.el.
12222 (Ffuncall): Handle closures.
12223 (apply_lambda): Remove `eval_flags'.
12224 (funcall_lambda): Handle closures and new byte-code-functions.
12225 (Fspecial_variable_p): New function.
12226 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12227 but without exporting it to Lisp.
23aba0ea 12228
23aba0ea 12229 * doc.c (Fdocumentation, store_function_docstring):
03408648 12230 * data.c (Finteractive_form): Handle closures.
23aba0ea 12231
03408648
SM
12232 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12233 interactive spec.
ba83908c 12234
04f2d78b
CB
12235 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12236 New byte-codes.
03408648
SM
12237 (exec_byte_code): New function extracted from Fbyte_code to handle new
12238 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12239
03408648 12240 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12241
03408648 12242 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12243
e2abce01
JB
122442011-03-31 Juanma Barranquero <lekktu@gmail.com>
12245
12246 * xdisp.c (redisplay_internal): Fix prototype.
12247
63696a73 122482011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12249
63696a73 12250 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12251 (try_scrolling): Use it when setting scroll_limit.
12252 Limit scrolling to 100 screen lines.
63696a73
EZ
12253 (redisplay_window): Even when falling back on "recentering",
12254 position point in the window according to scroll-conservatively,
12255 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12256
12257 (try_scrolling): When point is above the window, allow searching
12258 as far as scroll_max, or one screenful, to compute vertical
12259 distance from PT to the scroll margin position. This prevents
12260 try_scrolling from unnecessarily failing when
12261 scroll-conservatively is set to a value slightly larger than the
12262 window height. Clean up the case of PT below the margin at bottom
12263 of window: scroll_max can no longer be INT_MAX. When aggressive
12264 scrolling is in use, don't let point enter the opposite scroll
12265 margin as result of the scroll.
12266 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12267 threshold of 100 lines for never-recentering scrolling.
12268
e4cc2dfc
JB
122692011-03-31 Juanma Barranquero <lekktu@gmail.com>
12270
12271 * dispextern.h (move_it_by_lines):
12272 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12273 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12274 (message_log_check_duplicate): Remove parameters `prev_bol' and
12275 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12276 (redisplay_internal): Remove parameter `preserve_echo_area',
12277 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12278
12279 * indent.c (Fvertical_motion):
12280 * window.c (window_scroll_pixel_based, Frecenter):
12281 Don't pass `need_y_p' to `move_it_by_lines'.
12282
1c470562
SM
122832011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12284
44f230aa
SM
12285 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12286 steal a few bits to be more compact.
12287 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12288 Remove unneeded casts.
12289
1c470562
SM
12290 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12291
888adce9
ZK
122922011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12293
12294 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12295 binding" message (bug#7967).
12296
f838ed7b
PE
122972011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12298
77861b95
PE
12299 Fix more problems found by GCC 4.6.0's static checks.
12300
de6dbc14
PE
12301 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12302 Remove unused local var.
12303
f838ed7b
PE
12304 * editfns.c (Fmessage_box): Remove unused local var.
12305
792c7b2b
PE
12306 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12307 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12308 Omit unused local vars.
c499e557 12309 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12310 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12311 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12312 Omit unused local var.
12313
ba0165e1
PE
12314 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12315 Don't assume string length fits in int.
32ad8845 12316 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12317 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12318
3c59b4c9
PE
12319 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12320 instead of alloca (Bug#8344).
12321
a3eed478 12322 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12323 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12324
eb4d412d
PE
12325 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12326
1658b401
PE
12327 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12328 concerns.
12329
12330 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12331
12332 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12333
9a2c6e05
PE
12334 * keyboard.c (syms_of_keyboard): Use the same style as later
12335 in this function when indexing through an array. This also
12336 works around GCC bug 48267.
12337
03d0a109
PE
12338 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12339
44f730c8
PE
12340 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12341
fe75f926
PE
12342 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12343 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12344
ffa8c828
PE
12345 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12346 This avoids undefined behavior on integer overflow, and is a bit
12347 more convenient anyway since it is compared to a size_t variable.
12348
c5101a77
PE
12349 Variadic C functions now count arguments with size_t, not int.
12350 This avoids an unnecessary limitation on 64-bit machines, which
12351 caused (substring ...) to crash on large vectors (Bug#8344).
12352 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12353 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12354 All variadic functions and their callers changed accordingly.
c5101a77
PE
12355 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12356 * data.c (arith_driver, float_arith_driver): Likewise.
12357 * editfns.c (general_insert_function): Likewise.
12358 * eval.c (struct backtrace.nargs, interactive_p)
12359 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12360 (funcall_lambda, mark_backtrace): Likewise.
12361 * fns.c (concat): Likewise.
12362 * frame.c (x_set_frame_parameters): Likewise.
12363 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12364 0 if not found, not -1. All callers changed.
12365
dd3f25f7
PE
12366 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12367 (stack_copy_size): Now size_t, not int.
12368 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12369
461c2ab9
JB
123702011-03-28 Juanma Barranquero <lekktu@gmail.com>
12371
12372 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12373 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12374 All callers changed.
12375
12376 * lisp.h (multibyte_char_to_unibyte):
12377 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12378 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12379 * character.h (CHAR_TO_BYTE8):
12380 * cmds.c (internal_self_insert):
12381 * editfns.c (general_insert_function):
12382 * keymap.c (push_key_description):
12383 * search.c (Freplace_match):
12384 * xdisp.c (message_dolog, set_message_1): All callers changed.
12385
f6d62986
SM
123862011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12387
12388 * keyboard.c (safe_run_hook_funcall): New function.
12389 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12390 don't set the hook to nil, but remove the offending function instead.
12391 (Qcommand_hook_internal): Remove, unused.
12392 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12393 Vcommand_hook_internal.
12394
12395 * eval.c (enum run_hooks_condition): Remove.
12396 (funcall_nil, funcall_not): New functions.
12397 (run_hook_with_args): Call each function through a `funcall' argument.
12398 Remove `cond' argument, now redundant.
12399 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12400 (Frun_hook_with_args_until_failure): Adjust accordingly.
12401 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12402
1db5b1ad
JB
124032011-03-28 Juanma Barranquero <lekktu@gmail.com>
12404
12405 * dispextern.h (string_buffer_position): Remove declaration.
12406
12407 * print.c (strout): Remove parameter `multibyte', unused since
12408 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12409
12410 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12411 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12412 All callers changed.
12413
12414 * w32.c (_wsa_errlist): Use braces for struct initializers.
12415
12416 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12417 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12418 All callers changed.
12419 (string_buffer_position): Likewise. Also, make static (it's never
12420 used outside xdisp.c).
12421 (cursor_row_p): Remove parameter `w', unused since
12422 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12423 (decode_mode_spec): Remove parameter `precision', introduced during
12424 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12425 All callers changed.
12426
5ffb62aa
JD
124272011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12428
12429 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12430
461c2ab9 124312011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12432
12433 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12434 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12435 (ns_update_auto_hide_menu_bar): New functions.
12436 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12437 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12438 ns_constrain_all_frames.
12439 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12440 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12441
5c380ffb
JD
124422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12443
12444 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12445
9af30bdf
GM
124462011-03-27 Glenn Morris <rgm@gnu.org>
12447
12448 * syssignal.h: Replace RETSIGTYPE with void.
12449 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12450 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12451 Replace SIGTYPE with void everywhere.
12452 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12453 * s/template.h (SIGTYPE): Remove commented out definition.
12454
e2abce01
JB
124552011-03-26 Eli Zaretskii <eliz@gnu.org>
12456
12457 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12458 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12459
f868cd8a
JB
124602011-03-26 Juanma Barranquero <lekktu@gmail.com>
12461
59eb0929
JB
12462 * w32.c (read_unc_volume): Use parameter `henum', instead of
12463 global variable `wget_enum_handle'.
12464
12465 * keymap.c (describe_vector): Remove parameters `indices' and
12466 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12467 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12468
f868cd8a
JB
12469 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12470
12471 * keyboard.c (timer_check): Remove parameter `do_it_now',
12472 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12473 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12474 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12475
12476 * keyboard.c (read_char):
12477 * w32menu.c (w32_menu_display_help):
12478 * xmenu.c (show_help_event, menu_help_callback):
12479 Adjust calls to `show_help_echo'.
12480
12481 * gtkutil.c (xg_maybe_add_timer):
12482 * keyboard.c (readable_events):
12483 * process.c (wait_reading_process_output):
12484 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12485
12486 * insdel.c (adjust_markers_gap_motion):
12487 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12488 (gap_left, gap_right): Don't call it.
12489
2ecf6fdb
CY
124902011-03-25 Chong Yidong <cyd@stupidchicken.com>
12491
12492 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12493 incurred during fontification.
12494
6b1f9ba4
JB
124952011-03-25 Juanma Barranquero <lekktu@gmail.com>
12496
12497 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12498 (DEFVAR_PER_BUFFER): Don't pass it.
12499
12500 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12501 (scrolling_window): Don't pass it.
12502
0f4a96b5
JB
125032011-03-25 Juanma Barranquero <lekktu@gmail.com>
12504
12505 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12506
12507 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12508 and `suffix'.
12509 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12510 of variables specific to SELinux and computation of `encoded_absname'.
12511
12512 * image.c (XPutPixel): Remove unused variable `height'.
12513
12514 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12515
12516 * unexw32.c (get_section_info): Remove unused variable `section'.
12517
12518 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12519 (system_process_attributes): Remove unused variable `sess'.
12520 (sys_read): Remove unused variable `err'.
12521
12522 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12523 (w32_wnd_proc): Remove unused variable `isdead'.
12524 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12525 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12526 (x_create_tip_frame): Remove unused variable `tem'.
12527
12528 * w32inevt.c (w32_console_read_socket):
12529 Remove unused variable `no_events'.
12530
12531 * w32term.c (x_draw_composite_glyph_string_foreground):
12532 Remove unused variable `width'.
12533
1149507c
JB
125342011-03-24 Juanma Barranquero <lekktu@gmail.com>
12535
12536 * w32term.c (x_set_glyph_string_clipping):
12537 Don't pass uninitialized region to CombineRgn.
12538
9c88f339
JB
125392011-03-23 Juanma Barranquero <lekktu@gmail.com>
12540
12541 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12542 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12543 (Fx_close_connection): Remove unused variable `i'.
12544
12545 * w32font.c (w32font_draw): Return number of glyphs.
12546 (w32font_open_internal): Remove unused variable `i'.
12547 (w32font_driver): Add missing initializer.
12548
12549 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12550 (fill_in_menu): Remove unused variable `items_added'.
12551
12552 * w32term.c (last_mouse_press_frame): Remove static global variable.
12553 (w32_clip_to_row): Remove unused variable `f'.
12554 (x_delete_terminal): Remove unused variable `i'.
12555
12556 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12557 (NOTHING): Remove unused static global variable.
12558 (uniscribe_check_otf): Remove unused variable `table'.
12559 (uniscribe_font_driver): Add missing initializers.
12560
dee091a3
JD
125612011-03-23 Julien Danjou <julien@danjou.info>
12562
12563 * term.c (Fsuspend_tty, Fresume_tty):
12564 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12565 * window.c (temp_output_buffer_show):
12566 * insdel.c (signal_before_change):
12567 * frame.c (Fhandle_switch_frame):
12568 * fileio.c (Fdo_auto_save):
12569 * emacs.c (Fkill_emacs):
12570 * editfns.c (save_excursion_restore):
12571 * cmds.c (internal_self_insert):
12572 * callint.c (Fcall_interactively):
12573 * buffer.c (Fkill_all_local_variables):
12574 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12575 Use Frun_hooks.
0f4a96b5 12576 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12577 unconditionally since it does the check itself.
dee091a3 12578
2c520ab5 125792011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12580
c9c49752
PE
12581 Fix more problems found by GCC 4.5.2's static checks.
12582
8abc3f12
PE
12583 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12584 the first time through the loop, since we know p0 < p1 then.
12585 This also avoids a gcc -Wstrict-overflow warning.
12586
a2d26660
PE
12587 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12588 leading to a memory leak, possible in functions like
12589 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12590 of objects (Bug#8318).
a2d26660 12591
916c72e9
PE
12592 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12593 that could (at least in theory) be that large.
12594
19ab8a18
PE
12595 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12596 This is less likely to overflow, and avoids undefined behavior if
12597 overflow does occur. All callers changed. Use strtoul to scan
12598 for the unsigned long integer.
b7cbbd6f
PE
12599 (pint2hrstr): Simplify and tune code slightly.
12600 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12601
f0641eff
PE
12602 * scroll.c (do_scrolling): Work around GCC bug 48228.
12603 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12604
7f650bb9
PE
12605 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12606 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12607 (validate_x_resource_name): Simplify count usage.
12608 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12609
37dd57d1
PE
12610 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12611 fail (Bug#8306).
81e56e61 12612
699979fc 12613 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12614
401bf9b4
PE
12615 * process.c (Fmake_network_process): Use socklen_t, not int,
12616 where POSIX says socklen_t is required in portable programs.
12617 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12618 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12619 (Fmake_network_process, server_accept_connection):
12620 (wait_reading_process_output, read_process_output):
12621 Likewise.
12622
b93aacde
PE
12623 * process.c: Rename or move locals to avoid shadowing.
12624 (list_processes_1, Fmake_network_process):
12625 (read_process_output_error_handler, exec_sentinel_error_handler):
12626 Rename or move locals.
4dc343ee 12627 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12628 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12629 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12630 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12631 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12632
af8a867c 12633 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12634 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12635 Include tparam.h instead, since it declares them.
af8a867c
PE
12636 * cm.h (PC): Remove extern decl; tparam.h now does this.
12637 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12638 * terminfo.c: Include tparam.h, to check interfaces.
12639 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12640 (tparam): Adjust signature to match interface in tparam.h;
12641 this removes some undefined behavior. Check that outstring and len
12642 are zero, which they always are with Emacs.
12643 * tparam.h (PC, BC, UP): New extern decls.
12644
0248044d 12645 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12646 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12647
8ff096c1 12648 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12649 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12650 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12651 (ftfont_list): Remove unused local.
49eaafba
PE
12652 (get_adstyle_property, ftfont_pattern_entity):
12653 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12654 Rename locals to avoid shadowing.
8ff096c1 12655
e2be39f6
PE
12656 * xfont.c (xfont_list_family): Mark var as initialized.
12657
c9735e30
PE
12658 * xml.c (make_dom): Now static.
12659
8f5201ae
PE
12660 * composite.c (composition_compute_stop_pos): Rename local to
12661 avoid shadowing.
b246f932
PE
12662 (composition_reseat_it): Remove unused locals.
12663 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12664 (composition_update_it): Mark var as initialized.
11b61122
PE
12665 (find_automatic_composition): Mark vars as initialized,
12666 with a FIXME (Bug#8290).
8f5201ae 12667
760fbc2c
PE
12668 character.h: Rename locals to avoid shadowing.
12669 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12670 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12671 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12672 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12673 to avoid shadowing.
12674
ff08eb85
PE
12675 * textprop.c (property_change_between_p): Remove; unused.
12676
fc7bf025
PE
12677 * intervals.c (interval_start_pos): Now static.
12678
235d7abc
PE
12679 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12680
44f230aa
SM
12681 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12682 Rename locals to avoid shadowing.
3e7d6594 12683
50060332
PE
12684 * sound.c (wav_play, au_play, Fplay_sound_internal):
12685 Fix pointer signedness.
d01f234b 12686 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12687 (wav_play): Initialize a variable to 0, to prevent undefined
12688 behavior (Bug#8278).
50060332 12689
c4fc4e30
PE
12690 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12691
918436ed
PE
12692 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12693
c939f91b
PE
12694 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12695 clobbering (Bug#8298).
b9c7f648
PE
12696 * sysdep.c (sys_subshell): Likewise.
12697 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12698
6bd8c144
PE
12699 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12700 This should get cleaned up, so that child_setup has the
12701 same signature on all platforms.
12702
7710357c 12703 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12704 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12705
c59da222
CY
127062011-03-22 Chong Yidong <cyd@stupidchicken.com>
12707
12708 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12709 not to be necessary, and produces flickering.
12710
66b87493
GM
127112011-03-20 Glenn Morris <rgm@gnu.org>
12712
12713 * config.in: Remove file.
12714
45b6f6d5
JB
127152011-03-20 Juanma Barranquero <lekktu@gmail.com>
12716
12717 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12718 are now in src/globals.h.
12719 (syms_of_minibuf): Remove spurious & from previous change.
12720
cd394be1 127212011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12722
12723 * minibuf.c (completing-read-function): New variable.
12724 (completing-read-default): Rename from completing-read.
12725 (completing-read): Call completing-read-function.
12726
b14e3e21
CY
127272011-03-19 Juanma Barranquero <lekktu@gmail.com>
12728
12729 * xfaces.c (Fx_load_color_file):
12730 Read color file from absolute filename (bug#8250).
12731
f2b726e6
JB
127322011-03-19 Juanma Barranquero <lekktu@gmail.com>
12733
12734 * makefile.w32-in: Update dependencies.
12735
09f6ff02
EZ
127362011-03-17 Eli Zaretskii <eliz@gnu.org>
12737
12738 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12739
29a6015a
PE
127402011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12741
a3a6c54e
PE
12742 Fix more problems found by GCC 4.5.2's static checks.
12743
b766f867
PE
12744 * process.c (make_serial_process_unwind, send_process_trap):
12745 (sigchld_handler): Now static.
12746
be02381c
PE
12747 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12748 That way, the code declares only the vars that it needs.
12749 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12750 * s/cygwin.h (PTY_ITERATION): Likewise.
12751 * s/darwin.h (PTY_ITERATION): Likewise.
12752 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12753
57048744
PE
12754 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12755 * process.c (allocate_pty): Don't declare stb unless it's needed.
12756
7914961c 12757 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12758 (CONSTANTLIM): Remove; unused.
12759 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12760 Define only if needed.
7914961c 12761
b3967b18
PE
12762 * unexelf.c (unexec): Name an expression,
12763 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12764 Use a different way to cause a compilation error if anyone uses
12765 n rather than nn, a way that does not involve shadowing.
73366a00 12766 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12767
29a6015a
PE
12768 * deps.mk (unexalpha.o): Remove; unused.
12769
43cfc33e 12770 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12771 * unexec.h: New file.
ce701a33
PE
12772 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12773 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12774 Depend on unexec.h.
12775 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12776 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12777 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12778 Change as necessary to match prototype in unexec.h.
ce701a33 12779
01f44d5a
PE
12780 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12781 shadowing.
4f63c6bb 12782 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12783
a6670b0b
PE
12784 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12785 Rename locals to avoid shadowing.
12786
cef2010d 12787 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12788 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12789
d4d7173a
PE
12790 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12791
f08b802a
PE
12792 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12793 warning when compiling print.c.
12794
3ddb0639
PE
12795 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12796 instead of using an uninitialized var.
5ad03b97 12797 (font_sort_entities): Mark var as initialized.
3ddb0639 12798
170a2692
PE
12799 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12800
e663c700
PE
12801 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12802 pointers to constants.
89bc529a 12803 (font_parse_fcname): Remove unused vars.
7b81e2d0 12804 (font_delete_unmatched): Now static.
ea838e10 12805 (font_get_spec): Remove; unused.
13a547c6
PE
12806 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12807 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12808 Rename or move locals to avoid shadowing.
e663c700 12809
2a80c887 12810 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12811 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12812
1384fa33 12813 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12814 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12815
8b2c52e9
PE
12816 * alloc.c (mark_backtrace): Move decl from here ...
12817 * lisp.h: ... to here, so that it can be checked.
12818
475545b5 12819 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12820 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12821 (lisp_indirect_variable): Name an expression,
12822 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12823 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12824
b1349114 12825 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12826 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12827 Use const pointer when appropriate.
b1349114 12828
a2928364
PE
12829 * lisp.h (get_system_name, get_operating_system_release):
12830 Move decls here, to check interfaces.
12831 * process.c (get_operating_system_release): Move decl to lisp.h.
12832 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12833 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12834 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12835 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12836 (Fformat_time_string, Fencode_time, Finsert_char):
12837 (Ftranslate_region_internal, Fformat):
12838 Rename or remove local vars to avoid shadowing.
9710023e 12839 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12840
a415e694
PE
12841 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12842 avoid shadowing.
12843
8ef4622d
PE
12844 * lisp.h (eassert): Check that the argument compiles, even if
12845 ENABLE_CHECKING is not defined.
12846
946f9a5b
PE
12847 * data.c (Findirect_variable): Name an expression, to avoid
12848 gcc -Wbad-function-cast warning.
112396d6 12849 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12850 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12851 (Fmake_variable_buffer_local, Fmake_local_variable):
12852 Mark variables as initialized.
52746918 12853 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12854
e5aab7e7 12855 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12856 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12857 Rename locals to avoid shadowing.
dff45157
PE
12858 (mark_stack): Move local variables into the #ifdef region where
12859 they're used.
7bc26fdb
PE
12860 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12861 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12862 needed otherwise.
12863 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12864 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12865 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12866
e5aab7e7
PE
12867 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12868 avoids undefined behavior in theory.
12869
4da60324
PE
12870 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12871
88043301
PE
12872 Use functions, not macros, for up- and down-casing (Bug#8254).
12873 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12874 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12875 to use the following functions instead of these macros.
12876 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12877 EMACS_INT, since callers assume the returned value fits in int.
12878 (upcase1): Likewise, for UPCASE_TABLE.
12879 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12880 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12881 the race-condition problem in the old DOWNCASE.
88043301 12882
19ed5445
PE
12883 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12884 Rename locals to avoid shadowing.
12885 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12886 (regex_compile, re_search_2, re_match_2_internal):
12887 Remove unused local vars.
952db0d7
PE
12888 (FREE_VAR): Rewrite so as not to use empty "else",
12889 which gcc can warn about.
da053e48 12890 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12891 (RETALLOC_IF): Define only if needed.
12892 (WORDCHAR_P): Likewise. This one is never needed, but is used
12893 only in a comment talking about a compiler bug, so put inside
12894 the #if 0 of that comment.
12895 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12896 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12897 Remove; unused.
19ed5445 12898
1f3561e4 12899 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12900 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12901 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12902
ded6f8f7
PE
12903 * search.c (simple_search): Remove unused var.
12904
dbd37a95
PE
12905 * dired.c (compile_pattern): Move decl from here ...
12906 * lisp.h: ... to here, so that it can be checked.
12907 (struct re_registers): New forward decl.
12908
7e47afad
PE
12909 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12910
85f24f61
PE
12911 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12912 All uses changed.
12913 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12914 Rename locals to avoid shadowing.
5671df8f 12915 (Fvertical_motion): Mark locals as initialized.
85f24f61 12916
181aa2be 12917 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12918 (casify_region): Mark local as initialized.
181aa2be 12919
930d429c
PE
12920 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12921
7082eac6
PE
12922 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12923 New macros, so that the caller can use some names other than
12924 gcpro1, gcpro2, etc.
12925 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12926 of the new macros.
12927 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12928 argument, for consistency with GCPRO2_VAR, etc: it is now the
12929 prefix of the variable, not the variable itself. All uses
12930 changed.
38b2c076
PE
12931 * dired.c (directory_files_internal, file_name_completion):
12932 Rename locals to avoid shadowing.
12933
15206ed9
PE
12934 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12935 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12936 dired.c's scmp function, had undefined behavior.
12937 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12938 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12939 * buffer.h: ... to here, because these macros use current_buffer,
12940 and the new implementation with inline functions needs to have
12941 current_buffer in scope now, rather than later when the macros
12942 are used.
12943 (downcase, upcase1): New static inline functions.
12944 (DOWNCASE, UPCASE1): Reimplement using these functions.
12945 This avoids undefined behavior in expressions like
12946 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12947 from race conditions in accessing the global variables
12948 case_temp1 and case_temp2.
12949 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12950 * lisp.h (case_temp1, case_temp2): Remove their decls.
12951 * character.h (ASCII_CHAR_P): Move from here ...
12952 * lisp.h: ... to here, so that the inline functions mentioned
12953 above can use them.
12954
4a6bea26
PE
12955 * dired.c (directory_files_internal_unwind): Now static.
12956
f14b7e14
PE
12957 * fileio.c (file_name_as_directory, directory_file_name):
12958 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12959 Now static.
2893f146
PE
12960 (file_name_as_directory): Use const pointers when appropriate.
12961 (Fexpand_file_name): Likewise. In particular, newdir might
12962 point at constant storage, so make it a const pointer.
fd4ead52 12963 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12964 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12965 signedness issues.
f839df0c
PE
12966 (Fset_file_times, Finsert_file_contents, auto_save_error):
12967 Rename locals to avoid shadowing.
f14b7e14 12968
5716756e 12969 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12970 (Ftry_completion, Fall_completions): Rename or remove locals
12971 to avoid shadowing.
5716756e 12972
b4c3046a
PE
12973 * marker.c (bytepos_to_charpos): Remove; unused.
12974
b45db522
PE
12975 * lisp.h (verify_bytepos, count_markers): New decls,
12976 so that gcc does not warn that these functions aren't declared.
12977
85876d07
PE
12978 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12979 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12980 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12981 (copy_text): Remove unused local var.
85876d07 12982
03d78a21 12983 * filelock.c (within_one_second): Now static.
b3dd38ab 12984 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12985
5df8f01b
PE
12986 * buffer.c (fix_overlays_before): Mark locals as initialized.
12987 (fix_start_end_in_overlays): Likewise. This function should be
12988 simplified by using pointers-to-pointers, but that's a different
12989 matter.
b1d876f1 12990 (switch_to_buffer_1): Now static.
8f54f30a
PE
12991 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12992 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12993
a70072c9 12994 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12995 Fix pointer signedness issue.
edced198
PE
12996 (sys_subshell): Mark local as volatile if checking for lint,
12997 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12998 (MAXPATHLEN): Define only if needed.
a70072c9 12999
a0977c44
PE
13000 * process.c (serial_open, serial_configure): Move decls from here ...
13001 * systty.h: ... to here, so that they can be checked.
13002
a884fdcc
PE
13003 * fns.c (get_random, seed_random): Move extern decls from here ...
13004 * lisp.h: ... to here, so that they can be checked.
13005
604efe86 13006 * sysdep.c (reset_io): Now static.
b8950c94 13007 (wait_for_termination_signal): Remove; unused.
604efe86 13008
38fc62d9
PE
13009 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13010 (copy_keymap_item, append_key, push_text_char_description):
13011 Now static.
1004a21a 13012 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13013 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13014 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13015 (describe_map_tree):
13016 Rename locals to avoid shadowing.
38fc62d9 13017
2f2650da
PE
13018 * keyboard.c: Declare functions static if they are not used elsewhere.
13019 (echo_char, echo_dash, cmd_error, top_level_2):
13020 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13021 (read_char, kbd_buffer_get_event, make_lispy_position):
13022 (make_lispy_event, make_lispy_movement, apply_modifiers):
13023 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13024 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13025 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13026 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13027 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13028
a053e86c 13029 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13030 (mark_kboards): Move decl here ...
13031 * alloc.c (mark_kboards): ... from here.
a053e86c 13032
4752793e
PE
13033 * lisp.h (force_auto_save_soon): New decl.
13034
74f10ca7 13035 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13036 (DEFINE_DUMMY_FUNCTION): New macro.
13037 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13038 Use it.
c03cd23f
PE
13039 (main): Add casts to avoid warnings
13040 if GCC considers string literals to be constants.
74f10ca7 13041
022e70d4
PE
13042 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13043
59d6fe83
PE
13044 * dbusbind.c: Pointer signedness fixes.
13045 (xd_signature, xd_append_arg, xd_initialize):
13046 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13047 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13048 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13049 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13050
78320123
PE
13051 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13052 if GCC considers string literals to be constants.
49cebcca 13053 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13054
35ac2a97
SM
130552011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13056
fb103ca9
SM
13057 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13058 (print_preprocess, print_object): New macro to fix last change.
13059
35ac2a97
SM
13060 * print.c (print_preprocess): Don't forget font objects.
13061
62973b41
JB
130622011-03-16 Juanma Barranquero <lekktu@gmail.com>
13063
13064 * emacs.c (USAGE3): Doc fixes.
13065
0e48bb22
AS
130662011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13067
13068 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13069 structure.
13070
7684e57b
JB
130712011-03-14 Juanma Barranquero <lekktu@gmail.com>
13072
13073 * lisp.h (VWindow_system, Qfile_name_history):
13074 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13075 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13076 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13077
13078 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13079 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13080
13081 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13082 * w32console.c (detect_input_pending, read_input_pending)
13083 (encode_terminal_code):
13084 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13085 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13086 (w32_system_caret_y, Qfile_name_history):
13087 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13088 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13089 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13090 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13091 * w32proc.c (Qlocal, report_file_error):
13092 * w32term.c (Vwindow_system, updating_frame):
13093 * w32uniscribe.c (initialized, uniscribe_font_driver):
13094 Remove unneeded extern declarations.
13095
2aa46d6c
CY
130962011-03-14 Chong Yidong <cyd@stupidchicken.com>
13097
c96bbc66 13098 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13099
cffc6f3b
CY
131002011-03-13 Chong Yidong <cyd@stupidchicken.com>
13101
13102 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13103 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13104 These macros can no longer be used for assignment.
13105
44f230aa
SM
13106 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13107 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13108 (record_buffer_markers, fetch_buffer_markers): New functions for
13109 recording and fetching special buffer markers.
13110 (set_buffer_internal_1, set_buffer_temp): Use them.
13111
13112 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13113
13114 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13115
13116 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13117 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13118
13119 * xdisp.c (hscroll_window_tree):
13120 (reconsider_clip_changes): Use PT instead of BUF_PT.
13121
d251f04b
EZ
131222011-03-13 Eli Zaretskii <eliz@gnu.org>
13123
13124 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13125 $(EMACS_ROOT)/lib/intprops.h.
13126
f0c77cd1
PE
131272011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13128
3eca4629
PE
13129 Fix more problems found by GCC 4.5.2's static checks.
13130
7c86ee98
PE
13131 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13132 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13133 (xg_free_frame_widgets): Make it clear that a local variable is
13134 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13135 (gdk_window_get_screen): Make it clear that this macro is needed
13136 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13137 (int_gtk_range_get_value): New function, which avoids a diagnostic
13138 from gcc -Wbad-function-cast.
13139 (xg_set_toolkit_scroll_bar_thumb): Use it.
13140 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13141 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13142 (get_utf8_string, xg_get_file_with_chooser):
13143 Rename locals to avoid shadowing.
13144 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13145
41729b81
PE
13146 * xgselect.c (xg_select): Remove unused var.
13147
f0c77cd1
PE
13148 * image.c (four_corners_best): Mark locals as initialized.
13149 (gif_load): Initialize transparent_p to zero (Bug#8238).
13150 Mark another local as initialized.
ec6cf4c6 13151 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13152
ce0ad53d 13153 * image.c (clear_image_cache): Now static.
d5d5a617 13154 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13155 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13156 (x_edge_detection): Remove unnecessary cast that
13157 gcc -Wbad-function-cast diagnoses.
2037898d 13158 (gif_load): Fix pointer signedness.
6ae141d6
PE
13159 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13160 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13161
33383987 131622011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13163
d32df629
PE
13164 Improve quality of tests for time stamp overflow.
13165 For example, without this patch (encode-time 0 0 0 1 1
13166 1152921504606846976) returns the obviously-bogus value (-948597
13167 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13168 reports time overflow. See
13169 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13170 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13171 * editfns.c: Include limits.h and intprops.h.
13172 (TIME_T_MIN, TIME_T_MAX): New macros.
13173 (time_overflow): Move earlier, to before first use.
13174 (hi_time, lo_time): New functions, for an accurate test for
13175 out-of-range times.
13176 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13177 (Fget_internal_run_time): Don't assume time_t fits in int.
13178 (make_time): Use list2 instead of Fcons twice.
13179 (Fdecode_time): More accurate test for out-of-range times.
13180 (check_tm_member): New function.
13181 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13182 (lisp_time_argument): Don't rely on undefined left-shift and
13183 right-shift behavior when checking for time stamp overflow.
8be6f318 13184
fe31d94c
PE
13185 * editfns.c (time_overflow): New function, refactoring common code.
13186 (Fformat_time_string, Fdecode_time, Fencode_time):
13187 (Fcurrent_time_string): Use it.
13188
8be6f318
PE
13189 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13190 * dired.c (make_time): Move to ...
13191 * editfns.c (make_time): ... here.
13192 * systime.h: Note the move.
13193
09d9db2c 131942011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13195
126bc0dc
YM
13196 * fringe.c (update_window_fringes): Remove unused variables.
13197
c47cbdfd
YM
13198 * unexmacosx.c (copy_data_segment): Also copy __got section.
13199 (Bug#8223)
13200
7ac80be9
EZ
132012011-03-12 Eli Zaretskii <eliz@gnu.org>
13202
c96bbc66 13203 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13204 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13205 Constify `char *' arguments and their references according to
13206 prototypes in tparam.h.
13207
ecb0f94d 13208 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13209
7ac80be9
EZ
13210 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13211 Adapt all references accordingly.
13212
13213 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13214
ef1fd07e
TT
132152011-03-11 Tom Tromey <tromey@redhat.com>
13216
13217 * buffer.c (syms_of_buffer): Remove obsolete comment.
13218
7ef4b50c
EZ
132192011-03-11 Eli Zaretskii <eliz@gnu.org>
13220
13221 * termhooks.h (encode_terminal_code): Declare prototype.
13222
13223 * msdos.c (encode_terminal_code): Don't declare prototype.
13224
13225 * term.c (encode_terminal_code): Now external again, used by
13226 w32console.c and msdos.c.
13227
44f230aa
SM
13228 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13229 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13230
4b1ec863 132312011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13232
1714f52b 13233 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13234
4b1ec863
PE
13235 * fringe.c (update_window_fringes): Mark locals as initialized
13236 (Bug#8227).
13237 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13238
524c7aa6
PE
13239 * alloc.c (mark_fringe_data): Move decl from here ...
13240 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13241 to check its interface.
13242 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13243
a5c0af81 13244 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13245 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13246 (fontset_font): Mark local as initialized.
a9a06e0b 13247 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13248
b4716021
PE
13249 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13250
811e9bac 13251 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13252 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13253 (x_own_selection, Fx_disown_selection_internal): Rename locals
13254 to avoid shadowing.
13255 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13256
7e3ab302
PE
13257 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13258 so that the caller can use some name other than gcpro1.
13259 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13260 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13261 (Fx_backspace_delete_keys_p):
13262 Use them to avoid shadowing, and rename vars to avoid shadowing.
13263 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13264 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13265 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13266 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13267 Remove unused locals.
7e3ab302
PE
13268 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13269 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13270 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13271 macros.
f78faa98 13272
e2b13473
PE
13273 * xterm.h (x_mouse_leave): New decl.
13274
77f23912
PE
13275 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13276 Remove unused functions.
cdf4ba58
PE
13277 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13278 (x_calc_absolute_position): Now static.
7411c686 13279 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13280 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13281 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13282 unless they are used.
38d0b34a
PE
13283 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13284 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13285 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13286 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13287 (x_error_catcher, x_connection_closed, x_error_handler):
13288 (x_error_quitter, xembed_send_message, x_iconify_frame):
13289 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13290 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13291 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13292
44f230aa
SM
13293 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13294 Rename or move locals to avoid shadowing.
6b463e58 13295 (tty_defined_color, merge_face_heights): Now static.
5967d051 13296 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13297 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13298 does not deduce is never used uninitialized.
73719eba
PE
13299 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13300 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13301
426994c3 13302 * terminal.c (store_terminal_param): Now static.
5489860b 13303
032f1620 13304 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13305 (set_frame_menubar): Remove unused local.
d4323972 13306 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13307 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13308 since they might point to immutable storage.
281585b0
PE
13309 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13310 since it's unused otherwise.
032f1620 13311
367c19e5 13312 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13313 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13314 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13315 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13316 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13317 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13318 does not deduce are never used uninitialized.
70739cbe 13319
07b48fa9
PE
13320 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13321
8868a238 13322 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13323 * window.c (window_loop, size_window):
13324 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13325
7e5cf297 13326 * window.c (display_buffer): Now static.
d6550a9f
PE
13327 (size_window): Mark variables that gcc -Wuninitialized
13328 does not deduce are never used uninitialized.
a586633d
PE
13329 * window.h (check_all_windows): New decl, to forestall
13330 gcc -Wmissing-prototypes diagnostic.
5b555da1 13331 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13332
f6095868
PE
13333 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13334 shadowing.
13335 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13336 Include <limits.h>.
13337 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13338 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13339 (load_charset_map): Mark variables that gcc -Wuninitialized
13340 does not deduce are never used uninitialized.
53df7c11 13341 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13342
f38b440c
PE
13343 * coding.c (coding_set_source, coding_set_destination):
13344 Use "else { /* comment */ }" rather than "else /* comment */;"
13345 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13346 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13347 a block, when the outer 'i' will do.
13348 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13349 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13350 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13351 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13352 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13353 Rename locals to avoid shadowing.
13354 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13355 * coding.c (emacs_mule_char, encode_invocation_designation):
13356 Now static, since they're not used elsewhere.
413bb2db 13357 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13358 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13359 (decode_coding_emacs_mule): Mark variables that gcc
13360 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13361 (detect_coding_iso_2022): Initialize a local variable that might
13362 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13363 this initialization is needed. (Bug#8211)
5f58e762
PE
13364 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13365 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13366 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13367 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13368 Remove unused macros.
f38b440c 13369
232b38b9 13370 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13371 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13372 * character.c (string_count_byte8): Likewise.
232b38b9 13373
fb90da1b
PE
13374 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13375 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13376
fb93dbc2
PE
13377 * chartab.c (copy_sub_char_table): Now static, since it's not used
13378 elsewhere.
5c156ace
PE
13379 (sub_char_table_ref_and_range, char_table_ref_and_range):
13380 Rename locals to avoid shadowing.
bbcd0949 13381 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13382
7d3b3862 13383 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13384 (BIDI_BOB): Remove unused macro.
7d3b3862 13385
6be7d3da
PE
13386 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13387 deduce are never used uninitialized.
c2ed9c8b 13388 * term.c (encode_terminal_code): Likewise.
6be7d3da 13389
75f8807f 13390 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13391
50938595
PE
13392 * tparam.h: New file.
13393 * term.c, tparam.h: Include it.
13394 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13395 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13396 Move these decls to tparam.h, and make them agree with what
13397 is actually in tparam.c. The previous trick of using incompatible
13398 decls in different modules does not conform to the C standard.
13399 All callers of tparam changed to use tparam's actual API.
13400 * tparam.c (tparam1, tparam, tgoto):
13401 Use const pointers where appropriate.
13402
fbceeba2
PE
13403 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13404 * cm.h (struct cm): Likewise.
13405 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13406 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13407 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13408 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13409 (turn_on_face, init_tty): Likewise.
13410 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13411
7f3f1250
PE
13412 * term.c (term_mouse_position): Rename local to avoid shadowing.
13413
e6ca6543
PE
13414 * alloc.c (mark_ttys): Move decl from here ...
13415 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13416
c40f8d15
AS
134172011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13418
13419 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13420
cfe0661d
JB
134212011-03-09 Juanma Barranquero <lekktu@gmail.com>
13422
13423 * search.c (compile_pattern_1): Remove argument regp, unused since
13424 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13425 (compile_pattern): Don't pass it.
13426
0afb4571
J
134272011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13428
13429 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13430 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13431 for ! HAVE_GTK3.
13432 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13433
13434 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13435
13436 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13437 gdk_window_get_screen, gdk_window_get_geometry,
13438 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13439 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13440 (xg_get_pixbuf_from_pixmap): New function.
13441 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13442 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13443 Call xg_get_pixbuf_from_pixmap instead of
13444 gdk_pixbuf_get_from_drawable.
13445 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13446 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13447 (xg_check_special_colors): Use GtkStyleContext and its functions
13448 for HAVE_GTK3.
13449 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13450 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13451 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13452 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13453 Call gtk_widget_get_preferred_size.
0afb4571
J
13454 (xg_frame_resized): gdk_window_get_geometry only takes 5
13455 parameters.
44f230aa
SM
13456 (xg_win_to_widget, xg_event_is_for_menubar):
13457 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13458 (xg_set_widget_bg): New function.
13459 (delete_cb): New function.
895009e1 13460 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13461 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13462 (xg_set_background_color): Call xg_set_widget_bg.
13463 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13464 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13465 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13466 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13467 if ! HAVE_GTK3.
13468 (update_frame_tool_bar): Call gtk_widget_hide.
13469 (xg_initialize): Use GDK_KEY_g.
13470
13471 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13472 if ! HAVE_GTK3
13473 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13474
13475 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13476 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13477 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13478
1c2cc4ef
JB
134792011-03-08 Juanma Barranquero <lekktu@gmail.com>
13480
13481 * w32xfns.c (select_palette): Check success of RealizePalette against
13482 GDI_ERROR, not zero.
13483
33383987 13484See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13485
13486;; Local Variables:
13487;; coding: utf-8
aac0c6e3
MR
13488;; End:
13489
2f097256 13490 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13491
13492 This file is part of GNU Emacs.
13493
13494 GNU Emacs is free software: you can redistribute it and/or modify
13495 it under the terms of the GNU General Public License as published by
13496 the Free Software Foundation, either version 3 of the License, or
13497 (at your option) any later version.
13498
13499 GNU Emacs is distributed in the hope that it will be useful,
13500 but WITHOUT ANY WARRANTY; without even the implied warranty of
13501 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13502 GNU General Public License for more details.
13503
13504 You should have received a copy of the GNU General Public License
13505 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.