Move test/newsticker-testsuite.el to automated/newsticker-tests.el
[bpt/emacs.git] / src / ChangeLog
CommitLineData
88652fd5
EZ
12011-09-27 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4 newline, reseat the iterator instead of bidi-iterating there one
5 character at a time. (Bug#9610)
6 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7 TO_CHARPOS if the bidi iterator is at base embedding level.
8
ed497dd4
AS
92011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10
11 * lread.c (readevalloop): Use correct code for NBSP.
12 (read1): Likewise. (Bug#9608)
13
b2bf61aa
MA
142011-09-25 Michael Albinus <michael.albinus@gmx.de>
15
16 * dbusbind.c (Fdbus_register_signal): When service is not
17 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
18
32bbb17c
GM
192011-09-25 Glenn Morris <rgm@gnu.org>
20
21 * buffer.c (truncate-lines): Doc fix.
22
94e0933e
CY
232011-09-24 Chong Yidong <cyd@stupidchicken.com>
24
25 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
26 (Fset_window_next_buffers): Doc fix.
27
cddde921
GM
282011-09-24 Glenn Morris <rgm@gnu.org>
29
30 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
31
1260aef1
PE
322011-09-24 Paul Eggert <eggert@cs.ucla.edu>
33
25b4bfa0
PE
34 Fix minor problems found by static checking.
35 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
36 * indent.c (Fvertical_motion): Fix == vs = typo.
37
e3cbd34b
EZ
382011-09-24 Eli Zaretskii <eliz@gnu.org>
39
6bf7006f
EZ
40 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
41 value is now t. Doc fix.
42
e3cbd34b
EZ
43 * indent.c (Fvertical_motion): Compute and apply the overshoot
44 logic when moving up, not only when moving down. Fix the
45 confusing name and values of the it_overshoot_expected variable;
46 logic changes accordingly. (Bug#9254) (Bug#9549)
47
48 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
49 CHARPOS is covered by a display string which includes newlines.
50 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
51 is covered by a display string with embedded newlines.
52
a3de0cbd
MA
532011-09-24 Michael Albinus <michael.albinus@gmx.de>
54
55 * dbusbind.c (Fdbus_register_signal): Add match rule to
56 Vdbus_registered_objects_table. (Bug#9581)
57 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
58 docstring.
59
b260039d
JM
602011-09-24 Jim Meyering <meyering@redhat.com>
61
62 do not ignore write error for any output size
63 The previous change was incomplete.
64 While it makes emacs --batch detect the vast majority of stdout
65 write failures, errors were still ignored whenever the output size is
66 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
67 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
68 && echo FAIL: ignored write error
69 FAIL: ignored write error
70 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
71 && echo FAIL: ignored write error
72 FAIL: ignored write error
73 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
74
8eca8a7c
AS
752011-09-23 Andreas Schwab <schwab@linux-m68k.org>
76
77 * emacs.c (Fkill_emacs): In noninteractive mode exit
78 non-successfully if a write error occurred on stdout. (Bug#9574)
79
3341db62
EZ
802011-09-21 Eli Zaretskii <eliz@gnu.org>
81
82 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
83 the xassert test.
84
85 * dispextern.h (struct it): Update the comment documenting what
86 can it->OBJECT be.
87
8c203dbf
EZ
882011-09-20 Eli Zaretskii <eliz@gnu.org>
89
90 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
91 a display string, extend search for cursor position to end of row.
92 (find_row_edges): If the row ends in a newline from a display
93 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
94 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
95 (Fcurrent_bidi_paragraph_direction): Fix search for previous
96 non-empty line. Fixes confusing cursor motion with arrow keys at
97 the beginning of a line that starts with whitespace.
8c203dbf 98
a4824228
LMI
992011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
100
101 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
102 (bug#9493).
103
33ed493b
CY
1042011-09-18 Chong Yidong <cyd@stupidchicken.com>
105
106 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
107 boolean (Bug#9154).
108
56cd55c8
EZ
1092011-09-18 Eli Zaretskii <eliz@gnu.org>
110
111 * xdisp.c (display_line): Record maximum and minimum buffer
112 positions even if no glyphs were produced (e.g., by a zero-width
113 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
114 buffer positions that will be removed from the glyph row because
115 they don't fit.
c02dcedf
EZ
116 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
117 column is beyond frame width: don't subtract 1 "pixel" when
118 computing width of the stretch.
3e62b7e0
EZ
119 (reseat_at_next_visible_line_start): Undo the change made on
120 2011-09-17 that saved paragraph information and restored it after
121 the call to `reseat'. (Bug#9545)
56cd55c8 122
5ed99d36 1232011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
124
125 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
126 and turn window cursor on if cleared (Bug#9415).
127
5ed99d36 1282011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
129
130 * search.c (boyer_moore): Take unibyte characters from pattern
131 literally. (Bug#9458)
132
9bade7b2
EZ
1332011-09-18 Eli Zaretskii <eliz@gnu.org>
134
135 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
136
e5e9d610
PE
1372011-09-18 Paul Eggert <eggert@cs.ucla.edu>
138
87e4427a
PE
139 Fix minor problem found by static checking.
140 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
141 initialized, to pacify gcc -Wuninitialized.
142
e5e9d610
PE
143 * fileio.c: Report proper errno when syscall falls.
144 (Finsert_file_contents): Save and restore errno,
145 so that report_file_error outputs the correct diagnostic.
146 (Fwrite_region) [CLASH_DETECTION]: Likewise.
147
a1674f0b
EZ
1482011-09-18 Eli Zaretskii <eliz@gnu.org>
149
150 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
151
fbfb6dd4
EZ
1522011-09-17 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
155 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
156
bb187662
EZ
1572011-09-17 Eli Zaretskii <eliz@gnu.org>
158
1137e8b8
EZ
159 * xdisp.c (reseat_at_next_visible_line_start): Keep information
160 about the current paragraph and restore it after the call to
161 reseat.
162
163 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
164 (bidi_find_paragraph_start): Search back for paragraph beginning
165 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
166 (bidi_move_to_visually_next): Only trigger paragraph-related
167 computations when the last character is a newline or at EOB, not
168 just any NEUTRAL_B. (Bug#9470)
169
bb187662
EZ
170 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
171 truncated lines if point is covered by a display string. (Bug#9524)
172
2e621251
PE
1732011-09-16 Paul Eggert <eggert@cs.ucla.edu>
174
175 * xselect.c: Relax test for outgoing X longs (Bug#9498).
176 (cons_to_x_long): New function.
177 (lisp_data_to_selection_data): Use it. Correct the test for
178 short-versus-long data; it was negated. Break out of vector
179 loop, for efficiency, when a long datum is discovered.
180
91a15bc6
SM
1812011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
182
183 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
184
b41c3a35
EZ
1852011-09-16 Eli Zaretskii <eliz@gnu.org>
186
187 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
188 GCC PR/17406) by declaring this function with external scope.
189
7812ba2d
PE
1902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
191
192 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
193 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
194
cf7edc2a
AS
1952011-09-15 Andreas Schwab <schwab@linux-m68k.org>
196
197 * editfns.c (Fformat): Correctly handle text properties on "%%".
198
bd01620e
EZ
1992011-09-15 Eli Zaretskii <eliz@gnu.org>
200
201 * xterm.c (x_draw_composite_glyph_string_foreground):
202 * w32term.c (x_draw_composite_glyph_string_foreground):
203 * term.c (encode_terminal_code):
204 * composite.c (composition_update_it, get_composition_id):
205 * xdisp.c (get_next_display_element)
206 (fill_composite_glyph_string): Add comments about special meaning
207 of TAB characters in a composition.
208
a02719a3
PE
2092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
210
211 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
212 This occurs when processing a multibyte format.
213 Problem reported by Wolfgang Jenker.
a02719a3 214
72589a3c
JB
2152011-09-15 Johan Bockgård <bojohan@gnu.org>
216
217 * xdisp.c (try_cursor_movement): Only check for exact match if
218 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
219
1c14176c
PE
2202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
221
222 Remove unused external symbols.
223 * dispextern.h (calc_pixel_width_or_height): Remove decl.
224 * xdisp.c (calc_pixel_width_or_height): Now static.
225 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
226 * indent.c (check_display_width):
227 * w32term.c: Fix comment to match code.
228 * xterm.c, xterm.h (x_catching_errors): Remove.
229
d2eea5b5
PE
2302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
231
232 * xselect.c: Use signed conversions more consistently (Bug#9498).
233 (selection_data_to_lisp_data): Assume incoming selection data are
234 signed integers, not unsigned. This is to be consistent with
235 outgoing selection data, which was modified to use signed integers
236 in as part of the fix to Bug#9196 in response to Jan D.'s comment
237 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
238 expects long, not unsigned long.
239
46888499
EZ
2402011-09-14 Eli Zaretskii <eliz@gnu.org>
241
242 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
243 computation of loop end. Reported by Johan Bockgård
244 <bojohan@gnu.org>.
245
ef8ef9fb
CY
2462011-09-13 Chong Yidong <cyd@stupidchicken.com>
247
248 * frame.c (Fother_visible_frames_p): Function deleted.
249
fa819fed
EZ
2502011-09-12 Eli Zaretskii <eliz@gnu.org>
251
252 * indent.c (compute_motion): Process display vector front to back
253 rather than the other way around. (Bug#2496)
254
2ba8e008
SM
2552011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
256
257 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
258
20f53c69
CY
2592011-09-11 Chong Yidong <cyd@stupidchicken.com>
260
261 * minibuf.c (Fread_from_minibuffer): Doc fix.
262
d562d7a4
EZ
2632011-09-11 Eli Zaretskii <eliz@gnu.org>
264
265 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
266 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
267
1c4d7f3d
LMI
2682011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
269
270 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
271 value for non-existent files.
272
b885bf36
EZ
2732011-09-11 Eli Zaretskii <eliz@gnu.org>
274
275 * fileio.c (Finsert_file_contents): If the file cannot be opened,
276 set its "size" to -1. This will set the modtime_size field of
277 the corresponding buffer to -1, which is what
278 verify-visited-file-modtime expects for files that do not exist.
279 (Bug#9139)
280
6612f0bf
PE
2812011-09-11 Paul Eggert <eggert@cs.ucla.edu>
282
283 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
284 here ...
285 * lisp.h: ... from here. push_key_description is no longer
286 defined in keyboard.c, so its declaration should not be in
287 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
288 logically belongs with push_key_description.
289
dfb3f755
PE
2902011-09-10 Paul Eggert <eggert@cs.ucla.edu>
291
292 * buffer.h: Include <sys/types.h> instead of <time.h>.
293 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
294 Problem reported by Herbert J. Skuhra.
295
3134906c
LMI
2962011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
297
298 * xml.c (parse_region): Make the parsing work for
299 non-comment-starting XML files again (bug#9144).
300
8d903f4e
AS
3012011-09-10 Andreas Schwab <schwab@linux-m68k.org>
302
303 * image.c (gif_load): Fix calculation of bottom and right corner.
304 (Bug#9468)
305
80ad64f4
EZ
3062011-09-10 Eli Zaretskii <eliz@gnu.org>
307
308 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
309 redisplay in small windows.
310
208a048d
EZ
3112011-09-09 Eli Zaretskii <eliz@gnu.org>
312
313 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
314
9b1c252e
MR
3152011-09-08 Martin Rudalics <rudalics@gmx.at>
316
317 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
318 Operate on live windows only.
319
2949f33b
JB
3202011-09-08 Juanma Barranquero <lekktu@gmail.com>
321
322 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
323
e08dcafd
EZ
3242011-09-07 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
327 only under bidi iteration.
328
115b96bd
JD
3292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
330
331 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
332
c8199d0f
PE
3332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
334
335 isnan: Fix porting problem to Solaris 10 with bundled gcc.
336 Without this fix, the command to link temacs failed due to an
337 undefined symbol __builtin_isnan. This is because
338 /usr/include/iso/math_c99.h #defines isnan(x) to
339 __builtin_isnan(x), but the bundled gcc, which identifies itself
340 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
341 a __builtin_isnan.
342 * floatfns.c (isnan): #undef, and then #define to a clone of
343 what's in data.c.
344 (Fisnan): Always define, since it's always available now.
345 (syms_of_floatfns): Always define isnan at the Lisp level.
346
e39b275c 3472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
348
349 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
350
b2db44d9 3512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 352
f4af5137 353 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
354 The previous code assumed that file offsets (off_t values) fit in
355 EMACS_INT variables, which is not true on typical 32-bit hosts.
356 The code messed up by falsely reporting buffer overflow in cases
357 such as (insert-file-contents "big" nil 1 2) into an empty buffer
358 when "big" contains more than 2**29 bytes, even though this
359 inserts just one byte and does not overflow the buffer.
360 (Finsert_file_contents): Store file offsets as off_t
361 values, not as EMACS_INT values. Check for overflow when
362 converting between EMACS_INT and off_t. When checking for
363 buffer overflow or for overlap, take the offsets into account.
364 Don't use EMACS_INT for small values where int suffices.
365 When checking for overlap, fix a typo: ZV was used where
366 ZV_BYTE was intended.
367 (Fwrite_region): Don't assume off_t fits into 'long'.
368 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
369
ecfc0a49
MA
3702011-09-05 Michael Albinus <michael.albinus@gmx.de>
371
372 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
373
6511acf2 3742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 375
0999621a 376 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
377
378 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 379 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
380 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
381 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
382 (modify_event_symbol): Do not assume that the length of
383 name_alist_or_stem is safe to alloca and fits in int.
384 (Fexecute_extended_command): Likewise for function name and binding.
385 (Frecursion_depth): Wrap around reliably on integer overflow.
386 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
387 since some callers pass EMACS_INT values.
388 (Fsingle_key_description): Don't crash if symbol name contains more
389 than MAX_ALLOCA bytes.
390 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
391 (get_minibuffer): Arg is now EMACS_INT, not int.
392 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 393 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
394 * window.h (command_loop_level, minibuf_level): Reflect API changes.
395
2be7d702
PE
396 * dbusbind.c (signature_cat): New function.
397 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
398 Do not overrun buffer; instead, report string overflow.
399
9d1df220
PE
400 * dispnew.c (add_window_display_history): Don't overrun buffer.
401 Truncate instead; this is OK since it's just a log.
402
33ef5c64
PE
403 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
404 even if the time zone offset is outlandishly large.
405 Don't mishandle offset == INT_MIN.
406
66c6fdd5
PE
407 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
408 when creating daemon; the previous buffer-overflow check was incorrect.
409
d749b01b
PE
410 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
411 which has the guts of the old verror function.
412
b5cd1905
PE
413 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
414 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
415
6e1a67fb
PE
416 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
417 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 418 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 419 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
420 length of string rather than counting it via multiple sprintfs;
421 that's simpler and more reliable.
c21721cc
PE
422 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
423 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
424 sprintf, in case result does not fit in int.
425
c57b67fc
PE
426 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
427 (fontset_from_font): Print it.
428
8a401434
PE
429 * frame.c (tty_frame_count): Now printmax_t, not int.
430 (make_terminal_frame, set_term_frame_name): Print it.
431 (x_report_frame_params): In X, window IDs are unsigned long,
432 not signed long, so print them as unsigned.
433 (validate_x_resource_name): Check for implausibly long names,
434 and don't assume name length fits in 'int'.
435 (x_get_resource_string): Don't blindly alloca invocation name;
436 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
437 not fit in int.
438
6e1a67fb
PE
439 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
440 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
441 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
442
0df02bf3
PE
443 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
444 Use esprintf, not sprintf, in case result does not fit in int.
445
48e30793
PE
446 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
447 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
448 it as a large positive number.
449 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
450 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
451
a66ff6d8
PE
452 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
453 in case result does not fit in int.
454
aca216ff
PE
455 * print.c (float_to_string): Detect width overflow more reliably.
456 (print_object): Make sprintf buffer a bit bigger, to avoid potential
457 buffer overrun. Don't assume list length fits in 'int'. Treat
458 print length of 0 as 0, not as infinity; to be consistent with other
459 uses of print length in this function. Don't overflow print length
460 index. Don't assume hash table size fits in 'long', or that
461 vectorlike size fits in 'unsigned long'.
462
31c286f7
PE
463 * process.c (make_process): Use printmax_t, not int, to format
464 process-name gensyms.
465
55e5faa1
PE
466 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
467
80f2e268
PE
468 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
469 to avoid potential buffer overrun.
470
670741ab
PE
471 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
472 if X resource line is longer than 512 bytes.
473
b7163a50
PE
474 * xfns.c (x_window): Make sprintf buffer a bit bigger
475 to avoid potential buffer overrun.
476
ae58ff1f
PE
477 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
478
c43c8a6a
PE
479 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
480
3f8236f4
PE
4812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
482
53e9fe90 483 Integer overflow fixes for scrolling, etc.
6511acf2
PE
484 Without these, Emacs silently mishandles large integers sometimes.
485 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
486 it were "C-u 1 M-x recenter" on a typical 64-bit host.
487
6511acf2
PE
488 * xdisp.c (try_window_id): Check Emacs fixnum range before
489 converting to 'int'.
806add1d 490
6511acf2 491 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
492 Check that an Emacs fixnum is in range before assigning it to 'int'.
493 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
494 values converted from Emacs fixnums.
495 (Frecenter): Don't wrap around a line count if it is out of 'int'
496 range; instead, treat it as an extreme value.
497 (Fset_window_configuration, compare_window_configurations):
498 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
499
6511acf2
PE
500 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
501 that can exceed INT_MAX. Check that EMACS_INT value is in range
502 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
503 (match_limit): Don't assume that a fixnum can fit in 'int'.
504
6511acf2 505 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
506 exceed INT_MAX.
507
6511acf2 508 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
509 (Fvertical_motion): Don't wrap around LINES values that don't fit
510 in 'int'. Instead, treat them as extreme values. This is good
511 enough for windows, which can't have more than INT_MAX lines anyway.
512
fcb901a7
LMI
5132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
514
0f2f6b6d
LMI
515 * Require libxml/parser.h to avoid compilation warning.
516
fcb901a7
LMI
517 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
518
519 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
520 since this reportedly can destroy thread storage.
521
6e20a0d4
CY
5222011-08-30 Chong Yidong <cyd@stupidchicken.com>
523
524 * syntax.c (find_defun_start): Update all cache variables if
525 exiting early (Bug#9401).
526
148ae00e
EZ
5272011-08-30 Eli Zaretskii <eliz@gnu.org>
528
f6cfbd8f
EZ
529 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
530
148ae00e
EZ
531 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
532 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
533 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
534
535 * term.c (tty_append_glyph): New function.
536 (produce_stretch_glyph): Static function and its prototype deleted.
537
538 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
539 prototypes.
540
c4a07a4c
PE
5412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
542
543 * image.c (parse_image_spec): Check for nonnegative, not for positive,
544 when checking :margin (Bug#9390).
545 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
546 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
547 so that the name doesn't mislead. All uses changed.
548
6bc8cd65
JB
5492011-08-28 Johan Bockgård <bojohan@gnu.org>
550
551 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
552 set_tty_hooks.
553
dca4927e
EZ
5542011-08-27 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (move_it_to): Don't bail out early when reaching
557 position beyond to_charpos, if we are scanning backwards.
558 (move_it_vertically_backward): When DY == 0, make sure we get to
559 the first character in the line after the newline.
560
f2cad773
PE
5612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
562
563 * ccl.c: Improve and simplify overflow checking (Bug#9196).
564 (ccl_driver): Do not generate an out-of-range pointer.
565 (Fccl_execute_on_string): Remove unnecessary check for
566 integer overflow, noted by Stefan Monnier in
567 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
568 Remove a FIXME that didn't need fixing.
569 Simplify the newly-introduced buffer reallocation code.
570
0cae2cdb
JB
5712011-08-27 Juanma Barranquero <lekktu@gmail.com>
572
573 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
574
5fc295a4 5752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 576
70c60eb2 577 Integer and memory overflow issues (Bug#9196).
726e0ab1 578
d31850da
PE
579 * doc.c (get_doc_string): Rework so that
580 get_doc_string_buffer_size is the actual buffer size, rather than
581 being 1 less than the actual buffer size; this makes xpalloc more
582 convenient.
583
a69fbedb
PE
584 * image.c (x_allocate_bitmap_record, cache_image):
585 * xselect.c (Fx_register_dnd_atom):
586 Simplify previous changes by using xpalloc.
587
fe5c5d37
PE
588 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
589 since either will do and ptrdiff_t is convenient with xpalloc.
590
0065d054
PE
591 * charset.c (charset_table_size)
592 (struct charset_sort_data.priority): Now ptrdiff_t.
593 (charset_compare): Don't overflow if priorities differ greatly.
594 (Fsort_charsets): Don't assume list length fits in int.
595 Check for size-calculation overflow when allocating sort data.
596 (syms_of_charset): Allocate an initial charset table that is
597 just under 64 KiB, to avoid problems with glibc malloc and mmap.
598
599 * cmds.c (internal_self_insert): Check for size-calculation overflow.
600
601 * composite.h (struct composition.glyph_len): Now int, not unsigned.
602 The actual value is always <= INT_MAX, and leaving it unsigned made
603 overflow checking harder.
604
605 * dispextern.h (struct glyph_matrix.rows_allocated)
606 (struct face_cache.size): Now ptrdiff_t, for convenience in use
607 with xpalloc. The values are still always <= INT_MAX.
608
609 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
610
611 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
612 (SAFE_NALLOCA): New macro.
613
614 * region-cache.c (struct boundary.pos, find_cache_boundary)
615 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
616 (set_cache_region, invalidate_region_cache)
617 (revalidate_region_cache, know_region_cache, region_cache_forward)
618 (region_cache_backward, pp_cache):
619 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
620 so that ptrdiff_t * can be passed to xpalloc.
621 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
622 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
623 (pp_cache): Don't assume cache_len fits in int.
624 * region-cache.h: Adjust extern decls to match.
625
626 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
627 EMACS_INT, since either will do, for xpalloc.
628
629 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
630 (xnmalloc, xnrealloc, xpalloc): New functions.
631
726e0ab1
PE
632 * bidi.c (bidi_shelve_header_size): New constant.
633 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
634 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
635
51f30bc5 636 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
637 * buffer.c (overlays_at, overlays_in, record_overlay_string)
638 (overlay_strings):
639 Don't update size of array until after memory allocation succeeds,
640 because xmalloc/xrealloc may not return.
0065d054
PE
641 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
642 now that we have proper integer overflow checking.
643 (record_overlay_string, overlay_strings): Catch overflows when
644 calculating size of overlay_str_buf.
726e0ab1 645
0065d054
PE
646 * callproc.c (Fcall_process): Check for size overflow when
647 calculating size of args2.
648 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
649 Normally we prefer signed values, but sticking with ptrdiff_t would
650 require adding more-complicated checks.
726e0ab1
PE
651
652 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
653 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
654 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 655 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
656
657 * character.c (Fstring): Check for size-calculation overflow.
658
659 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
660 unnecessary integer overflow. Check for size overflow.
661 (encode_coding_object): Don't update size until xmalloc succeeds.
662
663 * composite.c (get_composition_id): Check for overflow in glyph
664 length calculations.
665
666 Integer and memory overflow fixes for display code.
667 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
668 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
669 (scrolling_window): Check for overflow in size calculations.
670 (line_draw_cost, realloc_glyph_pool, add_row_entry):
671 Don't assume glyph table len fits in int.
672 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
673 (row_table_size): Now ptrdiff_t, not int.
674 (scrolling_window): Avoid overflow in size calculations.
675 Don't update size until allocation succeeds.
676 * fns.c (concat): Check for overflow in size calculations.
677 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
678 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
679 (NEXT_ALMOST_PRIME_LIMIT): New constant.
680
681 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
682 (get_doc_string): Check for size calculation overflow.
683 Don't update size until allocation succeeds.
684 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
685 EMACS_INT, where ptrdiff_t will do.
686 (Fsubstitute_command_keys): Check for string overflow.
687
688 * editfns.c (set_time_zone_rule): Don't assume environment length
689 fits in int.
690 (message_length): Now ptrdiff_t, not int.
691 (Fmessage_box): Don't update size until allocation succeeds.
692 Don't assume message length fits in int.
693 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
694
0065d054
PE
695 * emacs.c (main): Do not reallocate argv, since there is a null at
696 the end that can be overwritten, and this way there's no need to
697 worry about size-calculation overflow.
698 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
699
700 * eval.c (init_eval_once, grow_specpdl): Don't update size until
701 alloc succeeds.
702 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
703
704 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
705 (x_set_scroll_bar_width, x_figure_window_size):
706 Check for integer overflow.
707 (x_set_alpha): Do not assume XINT fits in int.
708
709 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
710 This is for the members text_lines, text_cols, total_lines, total_cols,
711 where the system imposes an 'int' limit.
712
713 * fringe.c (Fdefine_fringe_bitmap):
714 Don't update size until alloc works.
715
716 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
717 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
718
719 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
720 Check for size-calculation overflow.
721 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
722 do, as we prefer signed integers.
723 (id_to_widget.max_size, id_to_widget.used)
724 (xg_store_widget_in_map, xg_remove_widget_from_map)
725 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
726 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
727 Use and return ptrdiff_t, not int.
728 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
729 * gtkutil.h: Change prototypes to match the above.
730
731 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
732 are duplicate now that they've been promoted to lisp.h.
733 (x_allocate_bitmap_record, x_alloc_image_color)
734 (make_image_cache, cache_image, xpm_load):
735 Don't update size until alloc is done.
736 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
737 (x_detect_edges):
3256efce 738 Check for size calculation overflow.
726e0ab1
PE
739 (ct_colors_allocated_max): New constant.
740 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
741 overflow.
3256efce 742
726e0ab1
PE
743 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
744 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
745 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
746 Use ptrdiff_t, not int, to count maps.
747 (read_char_minibuf_menu_prompt): Check for overflow in size
748 calculations. Don't update size until allocation succeeds. Redo
749 calculations to avoid overflow.
750 * keyboard.h: Change prototypes to match the above.
751
752 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
753 to count maps.
754 (current_minor_maps): Check for size calculation overflow.
755 * keymap.h: Change prototypes to match the above.
756
757 * lread.c (read1, init_obarray): Don't update size until alloc done.
758
759 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
760 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
761
726e0ab1
PE
762 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
763 Now ptrdiff_t, not int.
764 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
765 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
766
767 * process.c (Fnetwork_interface_list): Check for overflow
768 in size calculation.
769
770 * region-cache.c (move_cache_gap): Check for size calculation overflow.
771
772 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
773 overflow. Don't bother calling xmalloc when xrealloc will do.
774
775 * search.c (Freplace_match): Check for size calculation overflow.
776 (Fset_match_data): Don't assume list lengths fit in 'int'.
777
778 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
779 for command line length. Do not attempt to address one before the
780 beginning of an array, as that's not portable.
781
782 * term.c (max_frame_lines): Remove; unused.
783 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
784 not int.
785 (encode_terminal_code, calculate_costs): Check for size
786 calculation overflow.
787 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
788 table lengths and related sizes. Don't update size until alloc
789 done. Redo calculations to avoid overflow.
790 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
791
792 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
793 subtracting pointers.
794 (gobble_line): Check for overflow more carefully. Don't update size
795 until alloc done.
796
797 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
798 Don't update size until alloc done.
799 Redo size calculations to avoid overflow.
800 Check for size calculation overflow.
0065d054 801 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
802
803 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
804 Use ptrdiff_t, not int, for sizes.
805 (store_mode_line_noprop_char): Don't update size until alloc done.
806
0065d054
PE
807 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
808 Use ptrdiff_t, not int, for sizes.
809 (Finternal_make_lisp_face, cache_face):
810 Check for size calculation overflow.
811 (cache_face): Treat size calculation overflows as if they were
812 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
813
814 * xfns.c (x_encode_text, x_set_name_internal)
815 (Fx_change_window_property): Use ptrdiff_t, not int, to count
816 sizes, since they can exceed INT_MAX in size. Check for size
817 calculation overflow.
818
0065d054
PE
819 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
820 (xg_select): Check for size calculation overflow.
726e0ab1
PE
821 Don't update size until alloc done.
822
0065d054 823 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 824 as sprintf is limited to int lengths.
1d526e2f 825
252c5ee1
PE
826 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
827 (X_LONG_MIN): New macros.
864d7ce7
PE
828 Use them to make the following changes clearer.
829 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
830 This change doesn't affect the value now, but it may help remind
831 future maintainers not to raise the value too much later.
832 (SELECTION_QUANTUM): Remove, replacing with ...
833 (selection_quantum): ... new function, which avoids overflow.
834 All uses changed.
835 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
836 assumption that selection length fits in 'int'.
837 (x_reply_selection_request, x_handle_selection_request)
838 (x_get_window_property, receive_incremental_selection)
839 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
840 (lisp_data_to_selection_data, clean_local_selection_data):
841 Use ptrdiff_t, not int, to record length of selection.
842 (x_reply_selection_request, x_get_window_property)
843 (receive_incremental_selection, x_property_data_to_lisp):
844 Redo calculations to avoid overflow.
845 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 846 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
847 something.
848 (x_get_window_property, receive_incremental_selection)
849 (lisp_data_to_selection_data, x_property_data_to_lisp):
850 Check for size-calculation overflow.
851 (x_get_window_property, receive_incremental_selection)
852 (lisp_data_to_selection_data, Fx_register_dnd_atom):
853 Don't store size until memory allocation succeeds.
854 (x_get_window_property): Plug memory leak on memory exhaustion.
855 Don't double-block input; malloc is safe here. Don't assume 2**34
856 - 4 fits in unsigned long. Add an xassert to check
857 XGetWindowProperty overflow. Be more careful about overflow
858 calculations, and distinguish size from memory overflow better.
859 (receive_incremental_selection): When tracing, don't assume
860 unsigned int is less than INT_MAX.
861 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
862 harmful) conversions of unsigned short to int.
863 (lisp_data_to_selection_data): Don't assume that integers
864 in the range -65535 through -1 fit in an X unsigned short.
865 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
866 result parameters unless successful. Rely on cons_to_unsigned
867 to report problems with elements; the old code wasn't right anyway.
868 (x_check_property_data): Check for int overflow; we cannot use
869 a wider type due to X limits.
870 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
871
726e0ab1 872 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 873
0065d054
PE
874 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
875 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
876 (x_color_cells): Don't store size until memory allocation succeeds.
877 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 878 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
879 (x_term_init): Don't assume length fits in int (sprintf is limited
880 to int size).
bc18e09d 881
ebfa62c0
PE
882 Use ptrdiff_t for composition IDs.
883 * character.c (lisp_string_width):
884 * composite.c (composition_table_size, n_compositions)
885 (get_composition_id, composition_gstring_from_id):
886 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
887 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
888 * window.c (Frecenter):
889 Use ptrdiff_t, not int, for composition IDs.
890 * composite.c (get_composition_id): Check for integer overflow.
891 * composite.h: Adjust prototypes to match the above changes.
892
d3411f89
PE
893 Use ptrdiff_t for hash table indexes.
894 * category.c (hash_get_category_set):
895 * ccl.c (ccl_driver):
896 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
897 * coding.c (coding_system_charset_list, detect_coding_system):
898 * coding.h (struct coding_system.id):
899 * composite.c (get_composition_id, gstring_lookup_cache):
900 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
901 * image.c (xpm_get_color_table_h):
902 * lisp.h (hash_lookup, hash_put):
903 * minibuf.c (Ftest_completion):
904 Use ptrdiff_t for hash table indexes, not int (which is too
905 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
906 32-bit --with-wide-int hosts).
907
e097a6fa
PE
908 * charset.c (Fdefine_charset_internal): Check for integer overflow.
909 Add a FIXME comment about memory leaks.
910 (syms_of_charset): Don't assume xmalloc returns.
911
5637687f
PE
912 Don't assume that stated character widths fit in int.
913 * character.c (Fchar_width, c_string_width, lisp_string_width):
914 * character.h (CHAR_WIDTH):
915 * indent.c (MULTIBYTE_BYTES_WIDTH):
916 Use sanitize_char_width to avoid undefined and/or bad behavior
917 with outlandish widths.
918 * character.h (sanitize_tab_width): Renamed from sanitize_width,
919 now that we have two such functions. All uses changed.
920 (sanitize_char_width): New inline function.
921
a2271ba2
PE
922 Don't assume that tab-width fits in int.
923 * character.h (sanitize_width): New inline function.
924 (SANE_TAB_WIDTH): New macro.
925 (ASCII_CHAR_WIDTH): Use it.
926 * indent.c (sane_tab_width): Remove. All uses replaced by
927 SANE_TAB_WIDTH (current_buffer).
928 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
929
18c52557
PE
930 * fileio.c: Integer overflow issues with file modes.
931 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
932
caeeedc1
PE
933 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
934 Remove unreachable code.
935 (read_hex, load_charset_map_from_file): Check for integer overflow.
936
50849c52
PE
937 * xterm.c: don't go over XClientMessageEvent limit
938 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
939 (x_send_scroll_bar_event): Likewise. Check that the size does not
940 exceed limits imposed by XClientMessageEvent, as well as the usual
941 ptrdiff_t and size_t limits.
942
b13995db
PE
943 * keyboard.c: Overflow, signedness and related fixes.
944 (make_lispy_movement): Use same integer type in forward decl
945 that is used in the definition.
946 (read_key_sequence, keyremap_step):
947 Change bufsize argument back to int, undoing my 2011-03-30 change.
948 We prefer signed types, and int is wide enough here.
949 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
950 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
951 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
952 length, not size_t. Use ptrdiff_t for index, not int.
953 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
954 possibility of integer overflow.
955
13464394
PE
956 Overflow, signedness and related fixes for images.
957
958 * dispextern.h (struct it.stack[0].u.image.image_id)
959 (struct_it.image_id, struct image.id, struct image_cache.size)
960 (struct image_cache.used, struct image_cache.ref_count):
961 * gtkutil.c (update_frame_tool_bar):
962 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
963 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
964 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
965 * nsmenu.m (update_frame_tool_bar):
966 * xdisp.c (calc_pixel_width_or_height):
967 * xfns.c (image_cache_refcount):
968 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
969 on typical 64-bit hosts.
970
971 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
972 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
973 Omit unnecessary casts to int.
974 (parse_image_spec): Check that integers fall into 'int' range
975 when the callers expect that.
976 (image_ascent): Redo ascent calculation to avoid int overflow.
977 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
978 (lookup_image): Remove unnecessary tests.
979 (xbm_image_p): Locals are now of int, not EMACS_INT,
980 since parse_image_check makes sure they fit into int.
981 (png_load, gif_load, svg_load_image):
982 Prefer int to unsigned where either will do.
983 (tiff_handler): New function, combining the cores of the
984 old tiff_error_handler and tiff_warning_handler. This
985 function is rewritten to use vsnprintf and thereby avoid
986 stack buffer overflows. It uses only the features of vsnprintf
987 that are common to both POSIX and native Microsoft.
988 (tiff_error_handler, tiff_warning_handler): Use it.
989 (tiff_load, gif_load, imagemagick_load_image):
990 Don't assume :index value fits in 'int'.
991 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
992 (imagemagick_load_image): Check that crop parameters fit into
993 the integer types that MagickCropImage accepts. Don't assume
994 Vimagemagick_render_type has a nonnegative value. Don't assume
995 size_t fits in 'long'.
996 (gs_load): Use printmax_t to print the widest integers possible.
997 Check for integer overflow when computing image height and width.
998
c11821d4
EZ
9992011-08-26 Eli Zaretskii <eliz@gnu.org>
1000
1001 * xdisp.c (redisplay_window): Don't force window start if point
1002 will be invisible in the resulting window. (Bug#9324)
1003
0c95fcf7
EZ
10042011-08-25 Eli Zaretskii <eliz@gnu.org>
1005
1006 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1007 the display spec is of the form `(space ...)'.
1008 (handle_display_spec): Return the value returned by
1009 handle_single_display_spec, not just 1 or zero.
1010 (handle_single_display_spec): If the display spec is of the form
1011 `(space ...)', and specifies display in the text area, return 2
1012 rather than 1.
fee65a97 1013 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1014 accurately, and prefer exact match for point under bidi. Don't
1015 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1016
1017 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1018 into disp_prop; all users changed.
1019
1020 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1021 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1022 for the text covered by the display property.
1023
e4ed06f1
CY
10242011-08-25 Chong Yidong <cyd@stupidchicken.com>
1025
1026 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1027 Change return value to nil.
1028 (Frecord_buffer): Delete unused function.
1029
f67cdd7f
EZ
10302011-08-24 Eli Zaretskii <eliz@gnu.org>
1031
5980d4c6
EZ
1032 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1033 buffers, return left-to-right.
8610fe8b
EZ
1034 (set_cursor_from_row): Consider candidate row a win if its glyph
1035 represents a newline and point is on that newline. Fixes cursor
1036 positioning on the newline at EOL of R2L text within L2R
1037 paragraph, and vice versa.
1038 (try_cursor_movement): Check continued rows, in addition to
1039 continuation rows. Fixes unwarranted scroll when point enters a
1040 continued line of R2L text within an L2R paragraph, or vice versa.
1041 (cursor_row_p): Consider the case of point being equal to
1042 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1043 from the end of a short line to the beginning of a continued line
1044 of R2L text within L2R paragraph.
1045 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1046 composed characters.
5980d4c6 1047
f67cdd7f
EZ
1048 * bidi.c (bidi_check_type): Use xassert.
1049 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1050 members.
1051
bca633fb
EZ
10522011-08-23 Eli Zaretskii <eliz@gnu.org>
1053
1054 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1055 a character.
1056
4a5885a7
CY
10572011-08-23 Chong Yidong <cyd@stupidchicken.com>
1058
1059 * nsfont.m (ns_otf_to_script): Fix typo.
1060
0902a04e
KH
10612011-08-22 Kenichi Handa <handa@m17n.org>
1062
1063 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1064 extra slot even if the purpose is char-code-property-table.
1065
1a2e6670
EZ
10662011-08-23 Eli Zaretskii <eliz@gnu.org>
1067
8ddde651
EZ
1068 * xdisp.c (redisplay_window): When computing centering_position,
1069 account for the height of the header line. (Bug#8874)
1070
425cc014
EZ
1071 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1072 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1073 candidate is selected by the mouse, and that candidate has a
1074 composed character under the mouse.
1075
1a2e6670
EZ
1076 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1077 coordinates reported by pos-visible-in-window-p for a composed
1078 character in column zero.
1079
8b76d6f8
SM
10802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1083
dac347dd
EZ
10842011-08-22 Eli Zaretskii <eliz@gnu.org>
1085
1086 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1087 consider it a hit if to_charpos is anywhere in the range of the
1088 composed buffer positions.
1089
e013fb34
CY
10902011-08-22 Chong Yidong <cyd@stupidchicken.com>
1091
1092 * image.c (gif_load): Don't assume that each subimage has the same
1093 dimensions as the base image. Handle disposal method that is
1094 "undefined" by the gif spec (Bug#9335).
1095
bd1ba3e8
CY
10962011-08-20 Chong Yidong <cyd@stupidchicken.com>
1097
1098 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1099 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1100
54a1215b
EZ
11012011-08-19 Eli Zaretskii <eliz@gnu.org>
1102
823564e5
EZ
1103 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1104 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1105 from an Org mode buffer to a Speedbar frame.
1106
54a1215b
EZ
1107 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1108 a composition, take its buffer position from IT->cmp_it.charpos.
1109 Fixes cursor positioning at the beginning of a line that begins
1110 with a composed character.
1111
9778ebcc
EZ
11122011-08-18 Eli Zaretskii <eliz@gnu.org>
1113
0be6ee06
EZ
1114 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1115 character bidirectional type, use STRONG_L instead. Fixes crashes
1116 in a buffer produced by `describe-categories'.
1117
9778ebcc
EZ
1118 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1119 members before the level stack, so they would be saved and
1120 restored when copying iterator state. Fixes incorrect reordering
1121 around TABs covered by display properties.
1122
156bffbe
AS
11232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1124
1125 * process.c (Fnetwork_interface_list): Correctly determine buffer
1126 size.
1127
72ad093b
CY
11282011-08-17 Chong Yidong <cyd@stupidchicken.com>
1129
1130 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1131 (internal_condition_case_2, internal_condition_case_n):
1132 Remove unnecessary aborts (Bug#9081).
72ad093b 1133
35774242
EZ
11342011-08-17 Eli Zaretskii <eliz@gnu.org>
1135
1136 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1137 has no `load' handler, try opening the file locally. (Bug#9311)
1138
db76dd85
KB
11392011-08-16 Ken Brown <kbrown@cornell.edu>
1140
1141 * gmalloc.c: Expand comment.
1142
b215eee5
EZ
11432011-08-16 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1146 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1147
a4579d33
KB
11482011-08-16 Ken Brown <kbrown@cornell.edu>
1149
1150 Fix memory allocation problems in Cygwin build (Bug#9273).
1151
1152 * unexcw.c ( __malloc_initialized): Declare external variable.
1153 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1154
8b76d6f8
SM
1155 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1156 New variables.
a4579d33
KB
1157 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1158 dumped emacs.
1159 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1160 in the static heap.
1161 [CYGWIN] (special_realloc): New function.
1162 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1163 requests to realloc storage in the static heap.
1164
3ebec551
PE
11652011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 * bidi.c (bidi_initialize): Remove unused local.
1168
9fd8be00
EZ
11692011-08-15 Eli Zaretskii <eliz@gnu.org>
1170
474a8465
EZ
1171 * biditype.h: File removed.
1172
1173 * bidimirror.h: File removed.
1174
1175 * deps.mk (bidi.o): Remove biditype.h and
1176 bidimirror.h.
1177
1178 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1179 bidimirror.h.
1180
1181 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1182
1183 * chartab.c: Improve commentary for the uniprop_table API.
1184
32413314
EZ
1185 * bidi.c (bidi_paragraph_init): Support zero value of
1186 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1187 (bidi_initialize): Use uniprop_table instead of including
1188 biditype.h and bidimirror.h.
32413314 1189
9fd8be00
EZ
1190 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1191 coordinates of the iterator when restoring from ppos_it.
1192 (Bug#9296)
1193
5cf2b69b
KH
11942011-08-14 Kenichi Handa <handa@m17n.org>
1195
1196 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1197 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1198
daf17d00
EZ
11992011-08-14 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (move_it_in_display_line_to): Don't invoke
1202 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1203 ppos_it. Fixes vertical cursor motion when line beginning is
1204 covered by an image. (Bug#9296)
1205
08e3161a
JD
12062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * nsterm.h (ns_run_ascript): Declare.
1209 (NSAPP_DATA2_RUNASSCRIPT): Define.
1210
1211 * nsfns.m (as_script, as_result, as_status): New static variables.
1212 (ns_run_ascript): New function.
5e617bc2 1213 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1214 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1215 the event loop. Get status from as_status (Bug#7276).
1216
1217 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1218 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1219 the event loop (Bug#7276).
1220
a3720aa2
AS
12212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1222
1223 * gnutls.c (QCgnutls_bootprop_priority)
1224 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1225 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1226 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1227 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1228 (QCgnutls_bootprop_verify_hostname_error)
1229 (QCgnutls_bootprop_callbacks_verify): Rename from
1230 Qgnutls_bootprop_..., all uses changed.
1231
1232 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1233 uses changed.
1234
0a0d27fb
PE
12352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1236
19d5c50c
PE
1237 * xfaces.c (Qframe_set_background_mode): Now static.
1238 * dispextern.h (Qframe_set_background_mode): Remove decl.
1239
0a0d27fb
PE
1240 * process.c (Fnetwork_interface_info): Declare local only if needed.
1241
377538cb
JD
12422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1243
1244 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1245 (Fnetwork_interface_list): Allocate in increments of bytes instead
1246 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1247 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1248 sockaddr.
1249 (struct ifflag_def): notrailers is smart on OSX.
1250 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1251 Get hardware address with getifaddrs if available.
1252
08fff70c
EZ
12532011-08-12 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (iterate_out_of_display_property): xassert that
1256 IT->position is set to within IT->object's boundaries. Break from
1257 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1258 when IT->position is set up wrongly due to some bug.
1259 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1260 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1261 entry. Force push_it to save on the stack the current
1262 buffer/string position, to be restored by pop_it. Fix flags in
1263 the iterator structure wrt the object coming from a display
1264 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1265 properties. (Bug#9284)
1266
7be1c708 12672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1268
7be1c708
CY
1269 * fontset.c (fontset_get_font_group): Add proper type checks.
1270 (Bug#9172)
aac0c6e3 1271
7be1c708 12722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1273
7be1c708
CY
1274 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1275 and LC_VERSION_MIN_MACOSX.
1276 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1277 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1278
97bb72a6
EZ
12792011-08-08 Eli Zaretskii <eliz@gnu.org>
1280
1281 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1282 no-display-properties-and-no-overlays under bidi display.
1283 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1284 properties and overlays.
97bb72a6 1285
d5617611
CY
12862011-08-08 Chong Yidong <cyd@stupidchicken.com>
1287
37e11a63
CY
1288 * editfns.c (Fset_time_zone_rule): Document relationship with the
1289 setenv function.
1290
d5617611
CY
1291 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1292 the font entity extracted from the cache (Bug#8109).
1293
58872834
CY
12942011-08-07 Chong Yidong <cyd@stupidchicken.com>
1295
1296 * composite.c (autocmp_chars): Don't reset point. That is done by
1297 restore_point_unwind (Bug#5984).
1298
75bfc667
JL
12992011-08-07 Juri Linkov <juri@jurta.org>
1300
1301 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1302 to show the arg `TIME' instead of `TIMEVAL'.
1303
d1410150
EZ
13042011-08-06 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1307 display property strides EOL and includes a newline, as in
1308 longlines-mode. (Bug#9254)
75b771e4
EZ
1309 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1310 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1311
1312 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1313 is non-zero, even if the data buffer is NULL. Fixes a crash in
1314 vertical-motion with longlines-mode. (Bug#9254)
1315
35928349
EZ
13162011-08-05 Eli Zaretskii <eliz@gnu.org>
1317
ec7cc85b
EZ
1318 * bidi.c <bidi_cache_total_alloc>: Now static.
1319 (bidi_initialize): Initialize bidi_cache_total_alloc.
1320
8b76d6f8 1321 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1322 cache. (Bug#9221)
1323
1324 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1325 amount allocated this far in `bidi_cache_total_alloc'.
1326 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1327 non-zero, only free the data buffer without restoring the cache
1328 contents. All callers changed.
1329
1330 * dispextern.h (bidi_unshelve_cache): Update prototype.
1331
1332 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1333 (move_it_in_display_line, move_it_to)
1334 (move_it_vertically_backward, move_it_by_lines): Replace the call
1335 to xfree to an equivalent call to bidi_unshelve_cache.
1336 (move_it_in_display_line_to): Fix logic of returning
412b6358 1337 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1338
e2e2423b
EZ
13392011-08-05 Eli Zaretskii <eliz@gnu.org>
1340
1341 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1342 came from a string character with a `cursor' property. (Bug#9229)
1343
ae9e757a
JD
13442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * Makefile.in (LIB_PTHREAD): New variable.
1347 (LIBES): Add LIB_PTHREAD (Bug#9216).
1348
1349 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1350 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1351
213bd7f2
AS
13522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1353
1354 * regex.c (re_iswctype): Remove some redundant boolean
1355 conversions.
1356
99aaf75f
JD
13572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1358
1359 * xterm.c (x_find_topmost_parent): New function.
1360 (x_set_frame_alpha): Find topmost parent window with
1361 x_find_topmost_parent and set the property there also (bug#9181).
1362 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1363
c74e9d86
PE
13642011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * callproc.c (Fcall_process): Avoid vfork clobbering
1367 the local vars buffer, coding_systems, current_dir.
1368
640c8776
SM
13692011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1370
1371 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1372
f26d0e4c
PE
13732011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1374
8a10d76c
PE
1375 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1376 so that it is not optimized away.
1377
f26d0e4c
PE
1378 * xdisp.c (compute_display_string_pos): Remove unused local.
1379
55439c61
EZ
13802011-08-02 Eli Zaretskii <eliz@gnu.org>
1381
1382 Fix slow cursor motion and scrolling in large buffers with
1383 selective display, like Org Mode buffers. (Bug#9218)
1384
1385 * dispextern.h (struct bidi_it): New member disp_prop_p.
1386
1387 * xdisp.c: Remove one-slot cache of display string positions.
1388 (compute_display_string_pos): Accept an additional argument
5e617bc2 1389 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1390 for a display string or property. If found, set DISP_PROP_P
1391 non-zero.
1392
1393 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1394 DISP_PROP_P, and pass it to compute_display_string_pos.
1395 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1396 non-zero. All callers of bidi_fetch_char changed.
1397
fb33fa43
SM
13982011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1399
1400 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1401
b099e063
DM
14022010-12-03 Don March <don@ohspite.net>
1403
1404 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1405 last character M-[char] is translated to ESC [char] (bug#7541).
1406
5cc7f7af
KH
14072011-08-02 Kenichi Handa <handa@m17n.org>
1408
d0fffa3f 1409 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1410
1411 * chartab.c (uniprop_table): Make it non-static.
1412
525d5e6e
EZ
14132011-08-01 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (forward_to_next_line_start): Accept additional argument
1416 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1417 on the newline.
1418 (reseat_at_next_visible_line_start): Use the bidi iterator state
1419 returned by forward_to_next_line_start to restore the state of
1420 it->bidi_it after backing up to previous newline. (Bug#9212)
1421
31011111
AS
14222011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1423
1424 * regex.c (re_comp): Protoize.
1425 (re_exec): Fix return type.
1426 (regexec): Fix type of `ret'. (Bug#9203)
1427
476371c4
PE
14282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1429
e5d76069
PE
1430 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1431 This is needed if max-image-size is a floating-point number.
1432
9a79b20c
AS
14332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1434
1435 * print.c (print_object): Print empty symbol as ##.
1436
1437 * lread.c (read1): Read ## as empty symbol.
1438
d8c2fa78
AA
14392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1440
1441 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1442 setting frame foreground color (Bug#9175).
1443 (x_set_background_color): Likewise.
1444
ffe57a7a
AA
1445 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1446 contents (Bug#9176).
1447 (EmacsTooltip -init): Remove bezels and add shadows to
1448 tooltip windows.
1449
bf3492a5
AA
1450 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1451 or scroll bar (Bug#8470).
1452
d55e9c53
AA
1453 * nsfont.m (nsfont_open): Remove assignment to voffset and
1454 unnecessary vars hshink, expand, hd, full_height, min_height.
1455 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1456
1457 * nsterm.h (nsfont_info): Remove voffset field.
1458
d8c2fa78 14592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1460
1461 Implement strike-through and overline on NextStep (Bug#8863).
1462
1463 * nsfont.m (nsfont_open): Use underline position provided by font,
1464 instead of hard-coded value of 2.
1465 (nsfont_draw): Call ns_draw_text_decoration instead.
1466
1467 * nsterm.h: Add declaration for ns_draw_text_decoration.
1468
1469 * nsterm.m (ns_draw_text_decoration): New function for drawing
1470 underline, overline, and strike-through.
1471 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1472 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1473 accommodate underlining, etc.
4843aac3 1474
4cc60b9b
EZ
14752011-07-28 Eli Zaretskii <eliz@gnu.org>
1476
bc7ece87
EZ
1477 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1478 default.
4cc60b9b 1479
476371c4
PE
14802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1481
66606eea
PE
1482 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1483 Without this fix, if a signal arrives just after memory fills up,
1484 'malloc' might be invoked reentrantly.
1485
476371c4
PE
1486 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1487 In other words, assume that every image size is allowed, on non-X
1488 hosts. This assumption is probably wrong, but it lets Emacs compile.
1489
f3fcc40d
AS
14902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1491
1492 * regex.c (re_iswctype): Convert return values to boolean.
1493
350c992f
EZ
14942011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1495
1496 * xdisp.c (compute_display_string_pos): Don't use cached display
1497 string position if the buffer had its restriction changed.
1498 (Bug#9184)
1499
5266b4bb
PE
15002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1503
2573a837 15042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1505
41f55ccd 1506 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1507
39e378da
PE
1508 * bidi.c: Integer size and overflow fixes.
1509 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1510 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1511 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1512 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1513 (bidi_find_other_level_edge):
1514 Use ptrdiff_t instead of EMACS_INT where either will do.
1515 This works better on 32-bit hosts configured --with-wide-int.
1516 (bidi_cache_ensure_space): Check for size-calculation overflow.
1517 Use % rather than repeated addition, for better worst-case speed.
1518 Don't set bidi_cache_size until after xrealloc returns, because it
1519 might not return.
1520 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1521 (bidi_cache_ensure_space): Also check that the bidi cache size
1522 does not exceed that of the largest Lisp string or buffer. See Eli
1523 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1524
5e927815
PE
1525 * alloc.c (__malloc_size_t): Remove.
1526 All uses replaced by size_t. See Andreas Schwab's note
1527 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1528
ca4aa935
PE
1529 * image.c: Improve checking for integer overflow.
1530 (check_image_size): Assume that f is nonnull, since
1531 it is always nonnull in practice. This is one less thing to
1532 worry about when checking for integer overflow later.
1533 (x_check_image_size): New function, which checks for integer
1534 overflow issues inside X.
1535 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1536 This removes the need for a memory_full check.
1537 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1538 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1539 (xbm_read_bitmap_data): Change locals back to 'int', since
1540 their values must fit in 'int'.
1541 (xpm_load_image, png_load, tiff_load):
1542 Invoke x_create_x_image_and_pixmap earlier,
1543 to avoid much needless work if the image is too large.
1544 (tiff_load): Treat overly large images as if
1545 x_create_x_image_and_pixmap failed, not as malloc failures.
1546 (gs_load): Use x_check_image_size.
1547
5f8f9cc2
PE
1548 * gtkutil.c: Omit integer casts.
1549 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1550 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1551
5adf60bc
PE
1552 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1553
c8907a93
PE
1554 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1555 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1556 would wrongly return t on a 64-bit host.
1557
e3c25c68
PE
1558 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1559 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1560 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1561 and therefore cause GCC to emit a bogus diagnostic in some cases.
1562
3f791afe
PE
1563 * image.c: Integer signedness and overflow and related fixes.
1564 This is not an exhaustive set of fixes, but it's time to
1565 record what I've got.
1566 (lookup_pixel_color, check_image_size): Remove redundant decls.
1567 (check_image_size): Don't assume that arbitrary EMACS_INT values
1568 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1569 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1570 (tiff_load, imagemagick_load_image):
1571 Check for overflow in size calculations.
1572 (x_create_x_image_and_pixmap): Remove unnecessary test for
1573 xmalloc returning NULL; that can't happen.
1574 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1575 (xpm_color_bucket): Use better integer hashing function.
1576 (xpm_cache_color): Don't possibly over-allocate memory.
1577 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1578 (gif_memory_source):
1579 Use ptrdiff_t, not int or size_t, to record sizes.
1580 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1581 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1582 either works, as we prefer signed integers.
1583 (tiff_read_from_memory, tiff_write_from_memory):
1584 Return tsize_t, not size_t, since that's what the TIFF API wants.
1585 (tiff_read_from_memory): Don't fail simply because the read would
1586 go past EOF; instead, return a short read.
1587 (tiff_load): Omit no-longer-needed casts.
1588 (Fimagemagick_types): Don't assume size fits into 'int'.
1589
3cc5a532
PE
1590 Improve hashing quality when configured --with-wide-int.
1591 * fns.c (hash_string): New function, taken from sxhash_string.
1592 Do not discard information about ASCII character case; this
1593 discarding is no longer needed.
1594 (sxhash-string): Use it. Change sig to match it. Caller changed.
1595 * lisp.h: Declare it.
1596 * lread.c (hash_string): Remove, since we now use fns.c's version.
1597 The fns.c version returns a wider integer if --with-wide-int is
1598 specified, so this should help the quality of the hashing a bit.
1599
b312a492
PE
1600 * emacs.c: Integer overflow minor fix.
1601 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1602 Define only if GNU_LINUX.
1603 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1604
dfd153ae
PE
1605 * dispnew.c: Integer signedness and overflow fixes.
1606 Remove unnecessary forward decls, that were a maintenance hassle.
1607 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1608 All uses changed.
1609 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1610 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1611 (prepare_desired_row, line_draw_cost):
1612 Use int, not unsigned, where either works.
1613 (save_current_matrix, restore_current_matrix):
1614 Use ptrdiff_t, not size_t, where either works.
1615 (init_display): Check for overflow more accurately, and without
1616 relying on undefined behavior.
1617
a81d11a3
PE
1618 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1619 Remove, replacing with the new symbols in lisp.h. All uses changed.
1620 * fileio.c (make_temp_name):
1621 * filelock.c (lock_file_1, lock_file):
1622 * xdisp.c (message_dolog):
1623 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1624 Use pMd etc. instead.
1625 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1626 replacing the pWIDE etc. symbols removed from editfns.c.
1627
3300e6fd
PE
1628 * keyboard.h (num_input_events): Now uintmax_t.
1629 This is (very slightly) less likely to mess up due to wraparound.
1630 All uses changed.
1631
fd05c7e9
PE
1632 * buffer.c: Integer signedness fixes.
1633 (alloc_buffer_text, enlarge_buffer_text):
1634 Use ptrdiff_t rather than size_t when either will do, as we prefer
1635 signed integers.
1636
903fe15d
PE
1637 * alloc.c: Integer signedness and overflow fixes.
1638 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1639 (__malloc_size_t): Default to size_t, not to int.
1640 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1641 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1642 Prefer ptrdiff_t to size_t when either would do, as we prefer
1643 signed integers.
1644 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1645 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1646 Now const. Initialize with values that are in range even if char
1647 is signed.
1648 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1649 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1650 These functions do the right thing with sizes > 2**32.
1651 (check_depth): Now ptrdiff_t, not int.
1652 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1653 Adjust to new way of storing sizes. Check for size overflow bugs
1654 in rest of code.
1655 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1656 slightly wrong anyway, as it missed one instance of
1657 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1658 (refill_memory_reserve): Omit needless cast to size_t.
1659 (mark_object_loop_halt): Mark as externally visible.
1660
ac82cc6a
PE
1661 * xselect.c: Integer signedness and overflow fixes.
1662 (Fx_register_dnd_atom, x_handle_dnd_message):
1663 Use ptrdiff_t, not size_t, since we prefer signed.
1664 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1665 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1666 x_dnd_atoms_size and x_dnd_atoms_length.
1667
c2d1e36d
PE
1668 * doprnt.c: Prefer signed to unsigned when either works.
1669 * eval.c (verror):
1670 * doprnt.c (doprnt):
1671 * lisp.h (doprnt):
1672 * xdisp.c (vmessage):
1673 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1674 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1675 prefer signed arithmetic to avoid comparison confusion.
1676 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1677 but is a bit tricky.
1678
0e926e56
PE
1679 Assume freestanding C89 headers, string.h, stdlib.h.
1680 * data.c, doprnt.c, floatfns.c, print.c:
1681 Include float.h unconditionally.
1682 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1683 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1684 * regex.c: Likewise for stddef.h, string.h.
1685 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1686 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1687 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1688 (STDC_HEADERS): Remove obsolete defines.
1689 * sysdep.c: Include limits.h unconditionally.
1690
9cfdb3ec
PE
1691 Assume support for memcmp, memcpy, memmove, memset.
1692 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1693 * regex.c (memcmp, memcpy):
1694 Remove; we assume C89 now.
1695
1696 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1697 (__malloc_safe_bcopy): Remove; no longer needed.
1698
cf950e6b 1699 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1700 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1701 well either way, and we prefer signed to unsigned.
1702
dbf38e02
LMI
17032011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1704
1705 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1706 closes the connection while we're reading (bug#9182).
1707
d6f0886c 17082011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1709
d6f0886c
JD
1710 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1711 are specified (Bug#9168).
24e0f6b1 1712
2eb1f9e6
PE
17132011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1714
1715 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1716 Found by GCC static checking and --with-wide-int on a 32-bit host.
1717
22381272 17182011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1719
1720 * xdisp.c (compute_display_string_pos): Fix logic of caching
1721 previous display string position. Initialize cached_prev_pos to
1722 -1. Fixes slow-down at the beginning of a buffer.
1723
f25e39b4
EZ
17242011-07-24 Eli Zaretskii <eliz@gnu.org>
1725
1726 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1727 for attrs[LFACE_FONTSET_INDEX].
1728
04c4b52e
PE
17292011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 * xml.c (parse_region): Remove unused local
1732 that was recently introduced.
1733
c1734fbd
EZ
17342011-07-23 Eli Zaretskii <eliz@gnu.org>
1735
be18c5a5
EZ
1736 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1737 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1738
c1734fbd
EZ
1739 * xdisp.c (move_it_in_display_line_to): Record the best matching
1740 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1741 exit if none of the characters scanned was an exact match.
1742 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1743 when exact match is impossible due to invisible text, and the
1744 lines are truncated.
1745
a258d627
JD
17462011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1747
1748 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1749 for OSX >= 10.7.
1750
b6d5a689
EZ
17512011-07-22 Eli Zaretskii <eliz@gnu.org>
1752
0f74f785
EZ
1753 Fix a significant slow-down of cursor motion with C-n, C-p,
1754 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1755 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1756 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1757 (next_element_from_buffer): Call compute_stop_pos_backwards to
1758 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1759 base_level_stop.
1760 (reseat): Don't look for prev_stop, as that could mean a very long
1761 run.
1762 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1763 <cached_disp_overlay_modiff>: Cache for last found display string
1764 position.
551918c1 1765 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1766 about the same buffer in the same area of character positions, and
1767 the buffer wasn't changed since the time the display string
1768 position was cached.
551918c1 1769
b2d0c91a
EZ
17702011-07-22 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1773 is an integer, which is important for empty lines. (Bug#9149)
1774
043604ee
CY
17752011-07-22 Chong Yidong <cyd@stupidchicken.com>
1776
1777 * frame.c (Fmodify_frame_parameters): In tty case, update the
1778 default face if necessary (Bug#4238).
1779
da4adb04
CY
17802011-07-21 Chong Yidong <cyd@stupidchicken.com>
1781
1782 * editfns.c (Fstring_to_char): No need to explain what a character
1783 is in the docstring (Bug#6576).
1784
9abd0532
LMI
17852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1786
1787 * xml.c (parse_region): Make sure we always return a tree.
1788
36881d16
HK
17892011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1790
1791 * xml.c (parse_region): If a document contains only comments,
1792 return that, too.
1793
1e98674d
LMI
17942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1795
1796 * xml.c (make_dom): Return comments, too.
1797
590bd467
PE
17982011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 Port to OpenBSD.
1801 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1802 and the surrounding thread.
1803 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1804 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1805 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1806 timer goes off.
1807 * s/openbsd.h (BROKEN_SIGIO): Define.
1808 * unexelf.c (unexec) [__OpenBSD__]:
1809 Don't update the .mdebug section of the Alpha COFF symbol table.
1810
f41628b2
LMI
18112011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1812
1813 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1814 (bug#8460).
1815
b59b67c5
PE
18162011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1817
15e3a074
PE
1818 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1819 This fixes some race conditions on the permissions of any newly
1820 created file.
1821
41bed37d
PE
1822 * alloc.c (valid_pointer_p): Use pipe, not open.
1823 This fixes some permissions issues when debugging.
1824
b59b67c5
PE
1825 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1826 If fchown fails to set both uid and gid, try to set just gid,
1827 as that is sometimes allowed. Adjust the file's mode to eliminate
1828 setuid or setgid bits that are inappropriate if fchown fails.
1829
925a6be7
SM
18302011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1831
1832 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1833 to compare Lisp_Objects.
1834 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1835 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1836 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1837
52968808
AS
18382011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1839
0a6a104b
AS
1840 * lread.c (read_integer): Unread even EOF character.
1841 (read1): Likewise. Properly record start position of symbol.
1842
52968808
AS
1843 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1844 symbol character follows.
1845
9e381cdd
PE
18462011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1849 This works around a problem with the previous change to Fcopy_file.
1850 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1851 and without this change, GCC might complain about discarding
1852 fchown's return value.
1853
b5641435
JB
18542011-07-16 Juanma Barranquero <lekktu@gmail.com>
1855
1856 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1857
a8031457
PE
18582011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1861
dd889327
LMI
18622011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1863
750c33f7
LMI
1864 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1865 it's used from the C level.
1866
dd889327
LMI
1867 * process.c: Use the same condition for POLL_FOR_INPUT in both
1868 keyboard.c and process.c (bug#1858).
1869
87e86684
LM
18702011-07-09 Lawrence Mitchell <wence@gmx.li>
1871
1872 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1873 (Fgnutls_boot): Use it.
1874
64348f40
AS
18752011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1876
1877 * doc.c (Fsubstitute_command_keys): Revert last change.
1878
1d698799
LMI
18792011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1880
f863868c
LMI
1881 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1882 quotes the next character, and doesn't affect other longer
1883 sequences (bug#8935).
1884
1d698799
LMI
1885 * lread.c (syms_of_lread): Clarify that is isn't only
1886 `eval-buffer' and `eval-defun' that's affected by
1887 `lexical-binding' (bug#8460).
1888
aa4b6df6
EZ
18892011-07-15 Eli Zaretskii <eliz@gnu.org>
1890
1891 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1892 bidi redisplay when a line includes both an image and is
1893 truncated.
1894
5d856da6
PE
18952011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1896
ad6042bb
PE
1897 Fix minor problems found by static checking.
1898 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1899 (elsz): Now a signed constant, not a size_t var. We prefer signed
1900 types to unsigned, to avoid integer comparison confusion. Without
1901 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1902 "cannot optimize loop, the loop counter may overflow", a symptom
1903 of the confusion.
f00bbb22 1904 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1905 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1906
6468f31c
LMI
19072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1908
49080b10
LMI
1909 * search.c (Fre_search_backward): Mention `case-fold-search' in
1910 all the re_search_* functions (bug#8138).
1911
6468f31c
LMI
1912 * keyboard.c (Fopen_dribble_file): Document when the file is
1913 closed (bug#8056).
1914
c965adc5
EZ
19152011-07-14 Eli Zaretskii <eliz@gnu.org>
1916
df9733bf
EZ
1917 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1918 bidi_cache_idx.
1919
0bb23927
EZ
1920 Support bidi reordering of display and overlay strings.
1921 * xdisp.c (compute_display_string_pos)
1922 (compute_display_string_end): Accept additional argument STRING.
1923 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1924 (reseat_to_string): Initialize bidi_it->string.s and
1925 bidi_it->string.schars.
1926 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1927 NULL (avoids a crash in bidi_paragraph_init).
1928 Initialize itb.string.lstring.
0bb23927
EZ
1929 (init_iterator): Call bidi_init_it only of a valid
1930 buffer position was specified. Initialize paragraph_embedding to
1931 L2R.
1932 (reseat_to_string): Initialize the bidi iterator.
1933 (display_string): If we need to ignore text properties of
1934 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1935 original value of -1 will not work with bidi.)
1936 (compute_display_string_pos): First arg is now struct
1937 `text_pos *'; all callers changed. Support display properties on
1938 Lisp strings.
1939 (compute_display_string_end): Support display properties on Lisp
1940 strings.
1941 (init_iterator, reseat_1, reseat_to_string): Initialize the
1942 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1943 when iterating on a string not from display properties).
640c8776
SM
1944 (compute_display_string_pos, compute_display_string_end):
1945 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1946 arrow keys.
1947 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1948 base_level_stop; instead, set base_level_stop to BEGV.
1949 Fixes crashes in vertical-motion.
0bb23927
EZ
1950 (next_element_from_buffer): Improve commentary for when
1951 the iterator is before prev_stop.
1952 (init_iterator): Initialize bidi_p from the default value of
1953 bidi-display-reordering, not from buffer-local value. Use the
1954 buffer-local value only if initializing for buffer iteration.
1955 (handle_invisible_prop): Support invisible properties on strings
1956 that are being bidi-reordered.
1957 (set_iterator_to_next): Support bidi reordering of C strings and
1958 Lisp strings.
1959 (next_element_from_string): Support bidi reordering of Lisp
1960 strings.
1961 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1962 (display_string): Support display of R2L glyph rows.
1963 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1964 (init_iterator): Don't initialize it->bidi_p for strings
1965 here.
1966 (reseat_to_string): Initialize it->bidi_p for strings here.
1967 (next_element_from_string, next_element_from_c_string)
1968 (next_element_from_buffer): Add xassert's for correspondence
1969 between IT's object being iterated and it->bidi_it.string
1970 structure.
1971 (face_before_or_after_it_pos): Support bidi iteration.
1972 (next_element_from_c_string): Handle the case of the first string
1973 character that is not the first one in the visual order.
1974 (get_visually_first_element): New function, refactored from common
1975 parts of next_element_from_buffer, next_element_from_string, and
1976 next_element_from_c_string.
1977 (tool_bar_lines_needed, redisplay_tool_bar)
1978 (display_menu_bar): Force left-to-right direction. Add a FIXME
1979 comment for making that be controlled by a user option.
1980 (push_it, pop_it): Save and restore the state of the
1981 bidi iterator. Save and restore the bidi_p flag.
1982 (pop_it): Iterate out of display property for string iteration as
1983 well.
1984 (iterate_out_of_display_property): Support iteration over strings.
1985 (handle_single_display_spec): Set up it->bidi_it for iteration
1986 over a display string, and call bidi_init_it.
1987 (handle_single_display_spec, next_overlay_string)
1988 (get_overlay_strings_1, push_display_prop): Set up the bidi
1989 iterator for displaying display or overlay strings.
1990 (forward_to_next_line_start): Don't use the shortcut if
1991 bidi-iterating.
1992 (back_to_previous_visible_line_start): If handle_display_prop
1993 pushed the iterator stack, restore the internal state of the bidi
1994 iterator by calling bidi_pop_it same number of times.
1995 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1996 and we are bidi-iterating, don't decrement the iterator position;
1997 instead, set the first_elt flag in the bidi iterator, to produce
1998 the same effect.
1999 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2000 (push_display_prop): xassert that we are iterating a buffer.
2001 (push_it, pop_it): Save and restore paragraph_embedding member.
2002 (handle_single_display_spec, next_overlay_string)
2003 (get_overlay_strings_1, reseat_1, reseat_to_string)
2004 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2005 correctly. Don't assume unibyte strings are not bidi-reordered.
2006 (compute_display_string_pos)
2007 (compute_display_string_end): Fix handling the case of C string.
2008 (push_it, pop_it): Save and restore from_disp_prop_p.
2009 (handle_single_display_spec, push_display_prop): Set the
2010 from_disp_prop_p flag.
2011 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2012 (pop_it): Call iterate_out_of_display_property only if we are
2013 popping after iteration over a string that came from a display
2014 property. Fix a typo in popping stretch info. Add an assertion
2015 for verifying that the iterator position is in sync with the bidi
2016 iterator.
2017 (handle_single_display_spec, get_overlay_strings_1)
2018 (push_display_prop): Fix initialization of paragraph direction for
2019 string when that of the parent object is not yet determined.
2020 (reseat_1): Call bidi_init_it to resync the bidi
2021 iterator with IT's position. (Bug#7616)
2022 (find_row_edges): If ROW->start.pos gives position
2023 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2024 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2025 Reset the from_disp_prop_p flag.
2026 (SAVE_IT, RESTORE_IT): New macros.
2027 (pos_visible_p, face_before_or_after_it_pos)
2028 (back_to_previous_visible_line_start)
2029 (move_it_in_display_line_to, move_it_in_display_line)
2030 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2031 (try_scrolling, redisplay_window, display_line): Use them when
2032 saving a temporary copy of the iterator and restoring it back.
2033 (back_to_previous_visible_line_start, reseat_1)
2034 (init_iterator): Empty the bidi cache "stack".
2035 (move_it_in_display_line_to): If iterator ended up at
2036 EOL, but we never saw any buffer positions smaller than
2037 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2038 motion in bidi-reordered lines.
2039 (move_it_in_display_line_to): Record prev_method and prev_pos
2040 immediately before the call to set_iterator_to_next. Fixes cursor
2041 motion in bidi-reordered lines with stretch glyphs and strings
2042 displayed in margins. (Bug#8133) (Bug#8867)
2043 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2044 TO_CHARPOS.
640c8776
SM
2045 (pos_visible_p): Support positions in bidi-reordered lines.
2046 Save and restore bidi cache.
0bb23927
EZ
2047
2048 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2049 (bidi_paragraph_info): Delete unused struct.
2050 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2051 (bidi_cache_start): New variable.
2052 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2053 to zero.
2054 (bidi_cache_fetch_state, bidi_cache_search)
2055 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2056 (bidi_cache_find, bidi_peek_at_next_level)
2057 (bidi_level_of_next_char, bidi_find_other_level_edge)
2058 (bidi_move_to_visually_next): Compare cache index with
2059 bidi_cache_start rather than with zero.
2060 (bidi_fetch_char): Accept new argument STRING; all callers
2061 changed. Support iteration over a string. Support strings with
2062 display properties. Support unibyte strings. Fix the type of
2063 `len' according to what STRING_CHAR_AND_LENGTH expects.
2064 (bidi_paragraph_init, bidi_resolve_explicit_1)
2065 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2066 (bidi_level_of_next_char, bidi_move_to_visually_next):
2067 Support iteration over a string.
0bb23927
EZ
2068 (bidi_set_sor_type, bidi_resolve_explicit_1)
2069 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2070 can now be zero (for strings); special values 0 and -1 were
2071 changed to -1 and -2, respectively.
2072 (bidi_char_at_pos): New function.
2073 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2074 Call it instead of FETCH_MULTIBYTE_CHAR.
2075 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2076 initialized to valid values.
2077 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2078 values.
2079 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2080 the test for valid cached positions. Fix the logic for looking up
2081 the sentinel state in the cache. GCPRO the Lisp string we are
2082 iterating.
2083 (bidi_push_it, bidi_pop_it): New functions.
2084 (bidi_initialize): Initialize the bidi cache start stack pointer.
2085 (bidi_cache_ensure_space): New function, refactored from part of
2086 bidi_cache_iterator_state. Don't assume the required size is just
2087 one BIDI_CACHE_CHUNK away.
2088 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2089 (bidi_count_bytes, bidi_char_at_pos): New functions.
2090 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2091 always valid if bidi_cache_idx is valid.
2092 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2093 is valid if it's going to be used.
2094 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2095 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2096 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2097 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2098 (bidi_find_other_level_edge, bidi_cache_start_stack):
2099 All variables related to cache indices are now EMACS_INT.
c965adc5 2100
0bb23927
EZ
2101 * dispextern.h (struct bidi_string_data): New structure.
2102 (struct bidi_it): New member `string'. Make flag members be 1-bit
2103 fields, and put them last in the struct.
640c8776
SM
2104 (compute_display_string_pos, compute_display_string_end):
2105 Update prototypes.
0bb23927
EZ
2106 (bidi_push_it, bidi_pop_it): Add prototypes.
2107 (struct iterator_stack_entry): New members bidi_p,
2108 paragraph_embedding, and from_disp_prop_p.
2109 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2110 (bidi_shelve_cache, bidi_unshelve_cache):
2111 Declare prototypes.
0bb23927
EZ
2112
2113 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2114 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2115 and vector-like objects.
2116
2117 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2118 cache around display iteration.
2119
2120 * window.c (Fwindow_end, window_scroll_pixel_based)
2121 (displayed_window_lines, Frecenter): Save and restore the bidi
2122 cache around display iteration.
2123
3bbd2265
LMI
21242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2125
2126 * editfns.c (Fdelete_region): Clarify the use of the named
2127 parameters (bug#6788).
2128
adc47434
MR
21292011-07-14 Martin Rudalics <rudalics@gmx.at>
2130
2131 * indent.c (Fvertical_motion): Set and restore w->pointm when
2132 saving and restoring the window's buffer (Bug#9006).
2133
837c31f8
LMI
21342011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2135
2136 * editfns.c (Fstring_to_char): Clarify just what is returned
2137 (bug#6576). Text by Eli Zaretskii.
2138
ac389d0c
JB
21392011-07-13 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2142
0be0ce47
EZ
21432011-07-13 Eli Zaretskii <eliz@gnu.org>
2144
2145 * buffer.c (mmap_find): Fix a typo.
2146
cd18e7e3
JB
21472011-07-13 Johan Bockgård <bojohan@gnu.org>
2148
2149 Fix execution of x selection hooks.
2150 * xselect.c (Qx_lost_selection_functions)
2151 (Qx_sent_selection_functions): New vars.
2152 (syms_of_xselect): DEFSYM them.
2153 (x_handle_selection_request): Pass Qx_sent_selection_functions
2154 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2155 (x_handle_selection_clear,x_clear_frame_selections):
2156 Pass Qx_lost_selection_functions rather than
2157 Vx_lost_selection_functions to Frun_hook_with_args.
2158
47ea7f44
PE
21592011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2160
ac389d0c 2161 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2162 The old code sometimes used this field without initializing it.
2163
47ea7f44
PE
2164 * alloc.c (gc_sweep): Don't read past end of array.
2165 In theory, the old code could also have corrupted Emacs internals,
2166 though it'd be very unlikely.
2167
bc985c87
AS
21682011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2169
2170 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2171 argument. (Bug#4026)
bc985c87 2172
0cf34688
LMI
21732011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2174
b3dadd76
LMI
2175 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2176 key" (bug#4257).
2177
0cf34688
LMI
2178 * window.c (Fset_window_start): Doc fix (bug#4199).
2179 (Fset_window_hscroll): Ditto.
2180
270768cd
PE
21812011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2182
077e3dda 2183 Fix minor new problems caught by GCC 4.6.1.
270768cd 2184 * term.c (init_tty): Remove unused local.
490011a6 2185 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2186 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2187 not used otherwise.
270768cd 2188
b1f58454
CY
21892011-07-12 Chong Yidong <cyd@stupidchicken.com>
2190
2191 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2192
22b9578d
LMI
21932011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2194
6e70ab07
LMI
2195 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2196 are the mini-buffer and the echo area (bug#3320).
2197
22b9578d
LMI
2198 * term.c (init_tty): Remove support for supdup, c10 and perq
2199 terminals, which are no longer supported (bug#1482).
2200
8974cc9f
JB
22012011-07-10 Johan Bockgård <bojohan@gnu.org>
2202
2203 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2204
a560d974
JD
22052011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2206
2207 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2208 for non-popups (Bug#3642).
2209
1dae0f0a
AS
22102011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2211
268c2c36 2212 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2213 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2214 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2215 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2216 * data.c (fmod): Likewise.
2217 * dispnew.c (swap_glyphs_in_rows): Likewise.
2218 * emacs.c (memory_warning_signal): Likewise.
2219 * floatfns.c (float_error): Likewise.
2220 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2221 (otf_open, font_otf_capability, generate_otf_features)
2222 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2223 Likewise.
2224 * image.c (pbm_read_file): Likewise.
2225 * indent.c (string_display_width): Likewise.
2226 * intervals.c (check_for_interval, search_for_interval)
2227 (inc_interval_count, count_intervals, root_interval)
2228 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2229 * lread.c (defalias): Likewise.
268c2c36 2230 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2231 * regex.c (set_image_of_range_1, set_image_of_range)
2232 (regex_grow_registers): Likewise.
2233 * sysdep.c (strerror): Likewise.
2234 * termcap.c (valid_filename_p, tprint, main): Likewise.
2235 * tparam.c (main): Likewise.
2236 * unexhp9k800.c (run_time_remap, save_data_space)
2237 (update_file_ptrs, read_header, write_header, calculate_checksum)
2238 (copy_file, copy_rest, display_header): Likewise.
2239 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2240 Likewise.
2241 * xdisp.c (check_it): Likewise.
2242 * xfaces.c (register_color, unregister_color, unregister_colors):
2243 Likewise.
2244 * xfns.c (print_fontset_result): Likewise.
2245 * xrdb.c (member, fatal, main): Likewise.
2246
99033785
PE
22472011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2248
2249 Fix minor problems found by static checking (Bug#9031).
2250 * chartab.c (char_table_set_range, map_sub_char_table):
2251 Remove unused locals.
2252 (uniprop_table): Now static.
2253 * composite.c (_work_char): Remove unused static var.
2254
9cb2ac56
JB
22552011-07-09 Juanma Barranquero <lekktu@gmail.com>
2256
2257 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2258
f25661f0
JD
22592011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2260
2261 * gtkutil.c (qttip_cb): Remove code without function.
2262
8278c4fe
EZ
22632011-07-09 Eli Zaretskii <eliz@gnu.org>
2264
2265 * w32.c (pthread_sigmask): New stub.
2266
1692ae2d 22672011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2268
8a6ebd58 2269 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2270 sigprocmask is portable only for single-threaded applications, and
2271 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2272 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2273 (LIBES): Use it.
2274 * callproc.c (Fcall_process):
2275 * process.c (create_process):
2276 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2277 Use pthread_sigmask, not sigprocmask.
123403e4 2278
1b854618
JD
22792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2280
2281 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2282 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2283 wrong (Bug#8591).
2284
3fe4b549
JD
22852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2286
0ce7e563
JD
2287 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2288 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2289 (xg_hide_tooltip): Fix comment.
2290
3fe4b549
JD
2291 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2292 in registerServicesMenuSendTypes.
2293 (validRequestorForSendType): Don't check ns_return_types.
2294
2295 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2296 ns_return_type.
2297
5df75e47
JR
22982011-07-08 Jason Rumney <jasonr@gnu.org>
2299
2300 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2301 frame struct members of non-existent frames (Bug#6284).
2302
699c10bd
JD
23032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2304
4393663b
JD
2305 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2306 variable firstTime not needed on OSX >= 10.6.
2307 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2308 >= 10.5. Use setKnobProportion, setDoubleValue.
2309
2310 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2311 (MAC_OS_X_VERSION_10_5): Define if not defined.
2312 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2313 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2314 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2315
2316 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2317 cString and lossyCString on OSX >= 10.4
2318
2319 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2320 sizeToFit on OSX >= 10.2.
2321
2322 * nsimage.m (allocInitFromFile): Don't use deprecated method
2323 bestRepresentationForDevice on OSX >= 10.6.
2324
2325 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2326 to avoid warning.
2327
2328 * emacs.c: Declare unexec_init_emacs_zone.
2329
a63e0781
JD
2330 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2331
699c10bd
JD
2332 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2333
2334 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2335 on svcsMenu (Bug#8842).
2336
2337 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2338 ns_return_types.
2339 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2340
2341 * nsterm.m (QUTF8_STRING): Declare.
2342 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2343 (validRequestorForSendType): Return type is (id).
2344 Change indexOfObjectIdenticalTo to indexOfObject.
2345 Check if we have local selection before returning self (Bug#8842).
2346 (writeSelectionToPasteboard): Put local selection into paste board
2347 if we have a local selection (Bug#8842).
2348 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2349
2350 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2351 (ns_get_local_selection): Declare.
2352
54e10184
LMI
23532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2354
9888ff71
LMI
2355 * keymap.c (describe_map_tree): Don't insert a double newline at
2356 the end of the buffer (bug#1169) and return whether we inserted
2357 something.
2358
54e10184
LMI
2359 * callint.c (Fcall_interactively): Change "reading args" to
2360 "providing args" to try to clarify what it does (bug#1010).
2361
15fa4783
KH
23622011-07-07 Kenichi Handa <handa@m17n.org>
2363
2364 * composite.c (composition_compute_stop_pos): Ignore a static
2365 composition starting before CHARPOS (Bug#8915).
2366
2367 * xdisp.c (handle_composition_prop): Likewise.
2368
a8815b00
EZ
23692011-07-07 Eli Zaretskii <eliz@gnu.org>
2370
2371 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2372 (Bug#9015)
2373
ef7b981d 23742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2375
2376 * character.h (unicode_category_t): New enum type.
2377
2378 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2379 (Qchar_code_property_table): New variable.
2380 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2381 (UNIPROP_COMPRESSED_FORM_P): New macros.
2382 (char_table_ascii): Uncompress the compressed values.
2383 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2384 Uncompress the compressed values.
ac389d0c 2385 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2386 (char_table_ref_and_range): Uncompress the compressed values.
2387 (sub_char_table_set): New arg is_uniprop. Callers changed.
2388 Uncompress the compressed values.
2389 (sub_char_table_set_range): Args changed. Callers changed.
2390 (char_table_set_range): Adjuted for the above change.
2391 (map_sub_char_table): Delete args default_val and parent. Add arg
2392 top. Give decoded values to a Lisp function.
640c8776 2393 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2394 values to a Lisp function. Gcpro more variables.
2395 (uniprop_table_uncompress)
2396 (uniprop_decode_value_run_length): New functions.
2397 (uniprop_decoder, uniprop_decoder_count): New variables.
2398 (uniprop_get_decoder, uniprop_encode_value_character)
2399 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2400 New functions.
2401 (uniprop_encoder, uniprop_encoder_count): New variables.
2402 (uniprop_get_encoder, uniprop_table)
2403 (Funicode_property_table_internal, Fget_unicode_property_internal)
2404 (Fput_unicode_property_internal): New functions.
2405 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2406 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2407 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2408 char-code-property-alist.
2409
640c8776 2410 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2411 Vunicode_category_table.
2412
640c8776 2413 * font.c (font_range): Adjust for the change of
c805dec0
KH
2414 Vunicode_category_table.
2415
76b397fb
DN
24162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2417
2418 * m/iris4d.h: Remove file, move contents ...
2419 * s/irix6-5.h: ... here.
2420
22b4128e
PE
24212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2424 * alloc.c (mark_buffer):
2425 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2426 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2427 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2428 This isn't true in general, and it's particularly not true
2429 if Emacs is configured with --with-wide-int.
2430 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2431 New macros, used in the buffer.c change.
2432
869795d6
JD
24332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2434
2435 * xsettings.c: Use both GConf and GSettings if both are available.
2436 (store_config_changed_event): Add comment.
2437 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2438 (store_tool_bar_style_changed): New functions.
5e617bc2 2439 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2440 (struct xsettings): Move font inside HAVE_XFT.
2441 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2442 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2443 Move inside HAVE_XFT.
640c8776 2444 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2445 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2446 also.
2447 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2448 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2449 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2450 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2451 (parse_settings): Move check for font inside HAVE_XFT.
2452 (read_settings, apply_xft_settings): Add comment.
2453 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2454 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2455 call store_font_name_changed.
2456 (xft_settings_event): Add comment.
2457 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2458 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2459 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2460 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2461 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2462 (xsettings_get_system_font, xsettings_get_system_normal_font):
2463 Add comment.
869795d6 2464
d8ed26bd
PE
24652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 Random fixes. E.g., (random) never returned negative values.
2468 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2469 subseconds part to the entropy, as that's a bit more random.
2470 Prefer signed to unsigned, since the signedness doesn't matter and
2471 in general we prefer signed. When given a limit, use a
2472 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2473 latter isn't right if USE_2_TAGS_FOR_INTS.
2474 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2475 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2476
cabf1cac
SM
24772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2478
2479 * textprop.c (text_property_stickiness):
2480 Obey Vtext_property_default_nonsticky.
2481 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2482 * w32fns.c (syms_of_w32fns):
2483 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2484
6e9b2be9
PE
24852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2488 This is more efficient than Ffile_directory_p and avoids a minor race.
2489
90186c68
LMI
24902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2491
7c301272
LMI
2492 * buffer.c (Foverlay_put): Say what the return value is
2493 (bug#7835).
2494
c4f2d8d4
LMI
2495 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2496 is a directory before asking whether to use the file name
2497 (bug#7564).
ad637907
LMI
2498 (barf_or_query_if_file_exists): Make the "File is a directory"
2499 error be more correct.
c4f2d8d4 2500
90186c68
LMI
2501 * fns.c (Frequire): Remove the mention of the .gz files, since
2502 that's installation-specific, but keep the mention of
2503 `get-load-suffixes'.
2504
da64016e
PE
25052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2508 Report string overflow if the output is too long.
2509
7d47b580
JB
25102011-07-04 Juanma Barranquero <lekktu@gmail.com>
2511
a555cb87
JB
2512 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2513 (syms_of_gnutls): Remove duplicate DEFSYM for
2514 Qgnutls_bootprop_verify_hostname_error, an error for
2515 Qgnutls_bootprop_verify_error (which is no longer used).
2516
7d47b580
JB
2517 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2518 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2519 Also (re)move comments that are misplaced or no longer relevant.
2520
1e49bfab
LMI
25212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2522
2523 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2524
1485f4c0
CY
25252011-07-03 Chong Yidong <cyd@stupidchicken.com>
2526
2527 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2528 and background color parameters if they have been changed.
2529
a9ab721e
LMI
25302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2531
2532 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2533
cf7cff57
PE
25342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2535
2e13213d
PE
2536 * xsettings.c (SYSTEM_FONT): Define only when used.
2537 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2538
cf7cff57
PE
2539 * keymap.c (access_keymap_1): Now static.
2540
7a8e04f7
CY
25412011-07-02 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2544 leave any prefix arg for the up event (Bug#1586).
2545
61352f62
LMI
25462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2547
69bb1ef7
LMI
2548 * lread.c (syms_of_lread): Mention single symbols defined by
2549 `defvar' or `defconst' (bug#7154).
2550
61352f62 2551 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2552 (Frequire): Mention get-load-suffixes.
61352f62 2553
28545e04
MR
25542011-07-02 Martin Rudalics <rudalics@gmx.at>
2555
2556 * window.h (window): Remove clone_number slot.
2557 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2558 Remove.
2559 (make_parent_window, make_window, saved_window)
2560 (Fset_window_configuration, save_window_save): Don't deal with
2561 clone numbers.
2562 * buffer.c (Qclone_number): Remove declaration.
2563 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2564
3349e122
SM
25652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2566
2567 Add multiple inheritance to keymaps.
2568 * keymap.c (Fmake_composed_keymap): New function.
2569 (Fset_keymap_parent): Simplify.
2570 (fix_submap_inheritance): Remove.
2571 (access_keymap_1): New function extracted from access_keymap to handle
2572 embedded parents and handle lists of maps.
2573 (access_keymap): Use it.
2574 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2575 (Fcopy_keymap): Handle embedded parents.
2576 (Fcommand_remapping, define_as_prefix): Simplify.
2577 (Fkey_binding): Simplify.
2578 (syms_of_keymap): Move minibuffer-local-completion-map,
2579 minibuffer-local-filename-completion-map,
2580 minibuffer-local-must-match-map, and
2581 minibuffer-local-filename-must-match-map to Elisp.
2582 (syms_of_keymap): Defsubr make-composed-keymap.
2583 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2584 (parse_menu_item): Trivial simplification.
2585
3279eb87
GM
25862011-07-01 Glenn Morris <rgm@gnu.org>
2587
2588 * Makefile.in (SETTINGS_LIBS): Fix typo.
2589
4550efdf
KI
25902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2591
2592 * coding.c (Fencode_coding_string): Record the last coding system
2593 used, as the function doc string says (bug#8738).
2594
0949d2b6
JD
25952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2596
2597 * xsettings.c (store_monospaced_changed): Take new font as arg and
2598 check for change against current_mono_font.
2599 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2600 (emacs_settings_constructor, emacs_settings_get_property)
2601 (emacs_settings_set_property, emacs_settings_class_init)
2602 (emacs_settings_init, gsettings_obj): Remove.
2603 (something_changedCB): New function for HAVE_GSETTINGS.
2604 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2605 with value as argument.
2606 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2607 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2608 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2609 "changed".
2610
2611 * xgselect.c: Add defined (HAVE_GSETTINGS).
2612 (xgselect_initialize): Ditto.
2613
2614 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2615 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2616 xg_select.
2617
bbc6b304
PE
26182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2619
2620 * eval.c (struct backtrace): Simplify and port the data structure.
2621 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2622 signed bit field, as this assumption is not portable and it makes
2623 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2624 "char debug_on_exit : 1" as this is not portable either; instead,
2625 use the portable "unsigned int debug_on_exit : 1". Remove unused
2626 member evalargs. Remove obsolete comments about cc bombing out.
2627
9851bfc5
JD
26282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2629
51bb811f 2630 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2631 Let HAVE_GSETTINGS override HAVE_GCONF.
2632 (store_monospaced_changed): New function.
2633 (EMACS_SETTINGS): A new type derived from GObject to handle
2634 GSettings notifications.
2635 (emacs_settings_constructor, emacs_settings_get_property)
2636 (emacs_settings_set_property, emacs_settings_class_init):
2637 New functions.
2638 (gsettings_client, gsettings_obj): New variables.
2639 (GSETTINGS_SCHEMA): New define.
2640 (something_changedCB): Call store_monospaced_changed.
2641 (init_gsettings): New function.
2642 (xsettings_initialize): Call init_gsettings.
2643 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2644 to NULL.
2645
640c8776 2646 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2647 GCONF_CFLAGS/LIBS.
2648
5386012d
MR
26492011-06-29 Martin Rudalics <rudalics@gmx.at>
2650
2651 * window.c (resize_root_window, grow_mini_window)
2652 (shrink_mini_window): Rename Qresize_root_window to
2653 Qwindow_resize_root_window and Qresize_root_window_vertically to
2654 Qwindow_resize_root_window_vertically.
2655
f13e0b08
PE
26562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2659
94515237
JB
26602011-06-27 Juanma Barranquero <lekktu@gmail.com>
2661
2662 * makefile.w32-in: Redesign dependencies so they reflect more
2663 clearly which files are directly included by each source file,
2664 and not through other includes.
2665
e43b6e43
MR
26662011-06-27 Martin Rudalics <rudalics@gmx.at>
2667
2668 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2669 (sort_overlays, overlay_strings): When an overlay's clone number
2670 matches the window's clone number process the overlay even if
2671 the overlay's window property doesn't match the current window.
2672
d68443dc
MR
2673 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2674 (Fwindow_hchild): Rename to Fwindow_left_child.
2675 (Fwindow_next): Rename to Fwindow_next_sibling.
2676 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2677 (resize_window_check): Rename to window_resize_check.
2678 (resize_window_apply): Rename to window_resize_apply.
2679 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2680 (Fdelete_other_windows_internal, resize_frame_windows)
2681 (Fsplit_window_internal, Fdelete_window_internal)
2682 (grow_mini_window, shrink_mini_window)
2683 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2684
c7e73be5
JD
26852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2686
2687 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2688 (emacs_fixed_set_min_size): Remove.
2689 (emacs_fixed_new): Take frame as argument.
2690
2691 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2692 (_EmacsFixedPrivate): Remove minwidth/height.
2693 Add struct frame *f.
2694 (emacs_fixed_init): Initialize priv->f.
2695 (get_parent_class, emacs_fixed_set_min_size): Remove.
2696 (emacs_fixed_new): Set priv->f to argument.
2697 (emacs_fixed_get_preferred_width)
2698 (emacs_fixed_get_preferred_height): Use min_width/height from
2699 frames size_hint to set minimum and natural (Bug#8919).
2700 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2701 and use min_width/height from frames size_hint to set
2702 min_width/height (Bug#8919).
2703
2704 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2705 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2706 Fix indentation.
c7e73be5 2707
cf99dcf8
EZ
27082011-06-26 Eli Zaretskii <eliz@gnu.org>
2709
2710 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2711 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2712 called at ZV.
2713
029529ac
CY
27142011-06-26 Chong Yidong <cyd@stupidchicken.com>
2715
2716 * process.c (wait_reading_process_output): Bypass select if
2717 waiting for a cell while ignoring keyboard input, and input is
2718 pending. Suggested by Jan Djärv (Bug#8869).
2719
7a7ef429
PE
27202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 Use gnulib's dup2 module instead of rolling our own.
2723 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2724
11fdef7d 27252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2726
2727 * dispnew.c (scrolling_window): Before scrolling, turn off a
2728 mouse-highlight in the window being scrolled.
2729
cd3520a4
JB
27302011-06-24 Juanma Barranquero <lekktu@gmail.com>
2731
2732 Move DEFSYM to lisp.h and use everywhere.
2733
2734 * character.h (DEFSYM): Move declaration...
2735 * lisp.h (DEFSYM): ...here.
2736
2737 * gnutls.c:
2738 * minibuf.c:
2739 * w32menu.c:
2740 * w32proc.c:
2741 * w32select.c: Don't include character.h.
2742
2743 * alloc.c (syms_of_alloc):
2744 * buffer.c (syms_of_buffer):
2745 * bytecode.c (syms_of_bytecode):
2746 * callint.c (syms_of_callint):
2747 * casefiddle.c (syms_of_casefiddle):
2748 * casetab.c (init_casetab_once):
2749 * category.c (init_category_once, syms_of_category):
2750 * ccl.c (syms_of_ccl):
2751 * cmds.c (syms_of_cmds):
2752 * composite.c (syms_of_composite):
2753 * dbusbind.c (syms_of_dbusbind):
2754 * dired.c (syms_of_dired):
2755 * dispnew.c (syms_of_display):
2756 * doc.c (syms_of_doc):
2757 * editfns.c (syms_of_editfns):
2758 * emacs.c (syms_of_emacs):
2759 * eval.c (syms_of_eval):
2760 * fileio.c (syms_of_fileio):
2761 * fns.c (syms_of_fns):
2762 * frame.c (syms_of_frame):
2763 * fringe.c (syms_of_fringe):
2764 * insdel.c (syms_of_insdel):
2765 * keymap.c (syms_of_keymap):
2766 * lread.c (init_obarray, syms_of_lread):
2767 * macros.c (syms_of_macros):
2768 * msdos.c (syms_of_msdos):
2769 * print.c (syms_of_print):
2770 * process.c (syms_of_process):
2771 * search.c (syms_of_search):
2772 * sound.c (syms_of_sound):
2773 * syntax.c (init_syntax_once, syms_of_syntax):
2774 * terminal.c (syms_of_terminal):
2775 * textprop.c (syms_of_textprop):
2776 * undo.c (syms_of_undo):
2777 * w32.c (globals_of_w32):
2778 * window.c (syms_of_window):
2779 * xdisp.c (syms_of_xdisp):
2780 * xfaces.c (syms_of_xfaces):
2781 * xfns.c (syms_of_xfns):
2782 * xmenu.c (syms_of_xmenu):
2783 * xsettings.c (syms_of_xsettings):
2784 * xterm.c (syms_of_xterm): Use DEFSYM.
2785
4228cf16
TZ
27862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2787
cd3520a4 2788 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2789
7fcccf1e
PE
27902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2791
7efb4e0e
PE
2792 Integer and buffer overflow fixes (Bug#8873).
2793
ff5844ad
PE
2794 * print.c (printchar, strout): Check for string overflow.
2795 (PRINTPREPARE, printchar, strout):
2796 Don't set size unless allocation succeeds.
2797
90532f02
PE
2798 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2799 for sizes. Check for string overflow more accurately.
2800 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2801
6d84508d
PE
2802 * macros.c: Integer and buffer overflow fixes.
2803 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2804 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2805 Use ptrdiff_t, not int, for sizes.
2806 Don't increment bufsize until after realloc succeeds.
2807 Check for size-calculation overflow.
2808 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2809
437b2cb4
PE
2810 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2811
8b9ac8b4
PE
2812 * lread.c: Integer overflow fixes.
2813 (read_integer): Radix is now EMACS_INT, not int,
2814 to improve quality of diagnostics for out-of-range radices.
2815 Calculate buffer size correctly for out-of-range radices.
2816 (read1): Check for integer overflow in radices, and in
2817 read-circle numbers.
82cb60d3
PE
2818 (read_escape): Avoid int overflow.
2819 (Fload, openp, read_buffer_size, read1)
2820 (substitute_object_recurse, read_vector, read_list, map_obarray):
2821 Use ptrdiff_t, not int, for sizes.
2822 (read1): Use EMACS_INT, not int, for sizes.
20270765 2823 Check for size overflow.
8b9ac8b4 2824
7fcccf1e
PE
2825 * image.c (cache_image): Check for size arithmetic overflow.
2826
bfbbd7e7
PE
2827 * lread.c: Integer overflow issues.
2828 (saved_doc_string_size, saved_doc_string_length)
2829 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2830 Now ptrdiff_t, not int.
2831 (read1): Don't assume doc string length fits in int. Check for
2832 out-of-range doc string lengths.
2833 (read_list): Don't assume file position fits in int.
39019e54 2834 (read_escape): Check for hex character overflow.
bfbbd7e7 2835
4e323265
LL
28362011-06-22 Leo Liu <sdl.web@gmail.com>
2837
2838 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2839 Move to minibuffer.el.
2840
85fece3e
PE
28412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2842
20b84ce9 2843 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2844 The following patches are for when GLYPH_DEBUG && !XASSERT.
2845 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2846 * dispnew.c (flush_stdout):
2847 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2848 Mark as externally visible.
2849 * dispnew.c (check_window_matrix_pointers): Now static.
2850 * dispnew.c (window_to_frame_vpos):
2851 * xfns.c (unwind_create_frame):
2852 * xterm.c (x_check_font): Remove unused local.
2853 * scroll.c (CHECK_BOUNDS):
2854 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2855 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2856 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2857 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2858 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2859 Now static.
2860 (debug_method_add): Use va_list and vsprintf rather than relying
2861 on undefined behavior with wrong number of arguments.
2862 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2863 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2864 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2865 since we're not interested in debugging glyphs with old libraries.
2866 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2867 GCC 4.6.0's static checking.
2868
0766b489
PE
28692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2870
31fd4b32
PE
2871 Integer overflow and signedness fixes (Bug#8873).
2872 A few related buffer overrun fixes, too.
2873
b79e8648
PE
2874 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2875
0766b489
PE
2876 * dispextern.h (struct face.stipple):
2877 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2878 (x_bitmap_mask, x_allocate_bitmap_record)
2879 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2880 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2881 (x_create_bitmap_from_xpm_data):
2882 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2883 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2884 (.bitmaps_last):
2885 * xfaces.c (load_pixmap):
2886 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2887 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2888 (.bitmaps_last, struct x_output.icon_bitmap):
2889 Use ptrdiff_t, not int, for bitmap indexes.
2890 (x_allocate_bitmap_record): Check for size overflow.
2891 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2892
b081724f
PE
2893 Use ptrdiff_t, not int, for overlay counts.
2894 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2895 * editfns.c (overlays_around, get_pos_property):
2896 * textprop.c (get_char_property_and_overlay):
2897 * xdisp.c (next_overlay_change, note_mouse_highlight):
2898 * xfaces.c (face_at_buffer_position):
21514da7
PE
2899 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2900 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2901 (Fnext_overlay_change, Fprevious_overlay_change)
2902 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2903 Use ptrdiff_t, not int, for sizes.
21514da7 2904 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2905
3de73e5e
PE
2906 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2907
2606c57b
PE
2908 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2909 (x_session_initialize): Do not assume string length fits in int.
2910
aaafe47a
PE
2911 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2912 This is unlikely, but can occur if DPI is outlandish.
2913
2674ddc8 2914 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2915 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2916
28154962
PE
2917 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2918 * xrdb.c (magic_file_p, search_magic_path):
2919 Omit last arg SUFFIX; it was always 0. All callers changed.
2920 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2921
7de51af5
PE
2922 * xfont.c (xfont_match): Avoid need for strlen.
2923
25ed6cc3
PE
2924 * xfns.c: Don't assume strlen fits in int.
2925 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2926
4eab31dd
PE
2927 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2928 not unsigned long, as we prefer signed integers. All callers changed.
2929 Detect integer overflow in repeat count.
2930 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2931 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2932
171e2a58
PE
2933 * termcap.c: Don't assume sizes fit in int and never overflow.
2934 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2935 (gobble_line): Check for size-calculation overflow.
2936
ad39faca 2937 * minibuf.c (Fread_buffer):
6e5bb2dc 2938 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2939 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2940 Don't assume string length fits in int.
2941
52c61c22 2942 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2943 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2944
b5b8c9e5
PE
2945 * font.c: Don't assume string length fits in int.
2946 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2947 Use ptrdiff_t, not int.
ccd6111c
PE
2948 (font_intern_prop): Don't assume string length fits in int.
2949 Don't assume integer property fits in fixnum.
2950 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2951
882f0d81 2952 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2953 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2954 Reformulate so as not to need the command string.
2955 Invoke gzip -cd rather than gunzip, as it's more portable.
2956 (lock_info_type, lock_file_1, lock_file):
2957 Don't assume pid_t and time_t fit in unsigned long.
2958 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2959 (current_lock_owner): Prefer signed type for sizes.
2960 Use memcpy, not strncpy, where memcpy is what is really wanted.
2961 Don't assume (via atoi) that time_t and pid_t fit in int.
2962 Check for time_t and/or pid_t out of range, e.g., via a network share.
2963 Don't alloca where an auto var works fine.
2964
93f4cf88
PE
2965 * fileio.c: Fix some integer overflow issues.
2966 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2967 Don't assume string length fits in int.
2968 (directory_file_name): Don't assume string length fits in long.
2969 (make_temp_name): Don't assume pid fits in int, or that its print
2970 length is less than 20.
2971
f3e92b69
PE
2972 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2973
1bfdaf10
PE
2974 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2975
35016e9a
PE
2976 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2977
3d1e65a1
PE
2978 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2979 We prefer signed integers, even for size calculations.
2980
0b963a93
PE
2981 * emacs.c: Don't assume string length fits in 'int'.
2982 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2983 (main): Don't invoke strlen when not needed.
2984
573f4b54
PE
2985 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2986 (XD_DEBUG_MESSAGE): Don't waste a byte.
2987
989f33ba
PE
2988 * callproc.c (getenv_internal_1, getenv_internal)
2989 (Fgetenv_internal):
965d34eb
PE
2990 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2991
e4d29b33
PE
2992 * lread.c (invalid_syntax): Omit length argument.
2993 All uses changed. This doesn't fix a bug, but it simplifies the
2994 code away from its former Hollerith-constant appearance, and it's
2995 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2996 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2997
eb49b136
PE
2998 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2999 This didn't break anything, but it didn't help either.
3000 It's confusing to put a bogus integer in a place where the actual
3001 value does not matter.
9f62aeb1 3002 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3003 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3004
15375a22
PE
3005 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3006 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3007 implementation.
b61cc01c
PE
3008 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3009 We prefer signed types, and the value cannot exceed the EMACS_INT
3010 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3011 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3012 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3013 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3014
53b2623d
PE
3015 * indent.c (sane_tab_width): New function.
3016 (current_column, scan_for_column, Findent_to, position_indentation)
3017 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3018 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3019
51cab52b 3020 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3021
f2ed8a70
PE
3022 * lisp.h (lint_assume): New macro.
3023 * composite.c (composition_gstring_put_cache):
3024 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3025
abe80cc6
PE
3026 * editfns.c, insdel.c:
3027 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3028
b02c740e
PE
3029 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3030
ebc96716
PE
3031 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3032
b4e50fa0 3033 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3034 Use much-faster test for byte-length change.
311d5d7c 3035 Don't assume string byte-length fits in 'int'.
a4cf38e4 3036 Check that character arg fits in 'int'.
85461888 3037 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3038
c0c1ee9f
PE
3039 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3040
a498d7f4
PE
3041 * fns.c (concat): Catch string overflow earlier.
3042 Do not rely on integer wraparound.
3043
51cab52b
PE
3044 * dispextern.h (struct it.overlay_strings_charpos)
3045 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3046 * xdisp.c (forward_to_next_line_start)
3047 (back_to_previous_visible_line_start)
3048 (reseat_at_next_visible_line_start, next_element_from_buffer):
3049 Don't arbitrarily truncate the value of 'selective' to int.
3050
76031fad
PE
3051 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3052
5eb55db9
PE
3053 * composite.c: Don't truncate sizes to 'int'.
3054 (composition_gstring_p, composition_reseat_it)
3055 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3056 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3057 not EMACS_UINT, for indexes.
5eb55db9 3058
0703a717
PE
3059 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3060
d6202519
PE
3061 * buffer.c: Include <verify.h>.
3062 (struct sortvec.priority, struct sortstr.priority):
8961a454 3063 Now EMACS_INT, not int.
c20998a7 3064 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3065 (struct sortstr.size, record_overlay_string)
3066 (struct sortstrlist.size, struct sortlist.used):
3067 Don't truncate size to int.
3068 (record_overlay_string): Check for size-calculation overflow.
d6202519 3069 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3070
d5a19415
JM
30712011-06-22 Jim Meyering <meyering@redhat.com>
3072
029529ac 3073 Don't leak an XBM-image-sized buffer
d5a19415
JM
3074 * image.c (xbm_load): Free the image buffer after using it.
3075
a9041e6c
PE
30762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 Port to Sun C.
3079 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3080 that Sun C diagnosed.
3081 * fns.c (secure_hash): Fix pointer signedness issue.
3082 * intervals.c (static_offset_intervals): New function.
3083 (offset_intervals): Use it.
3084
7f3f739f
LL
30852011-06-21 Leo Liu <sdl.web@gmail.com>
3086
3087 * deps.mk (fns.o):
3088 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3089 sha512.h.
3090
3091 * fns.c (secure_hash): Rename from crypto_hash_function and change
3092 the first arg to accept symbols.
5b66d427 3093 (Fsecure_hash): New primitive.
7f3f739f
LL
3094 (syms_of_fns): New symbols.
3095
76147d94
DD
30962011-06-20 Deniz Dogan <deniz@dogan.se>
3097
3098 * process.c (Fset_process_buffer): Clarify return value in
3099 docstring.
3100
7d7d0045
CY
31012011-06-18 Chong Yidong <cyd@stupidchicken.com>
3102
3103 * dispnew.c (add_window_display_history): Use BVAR.
3104
3105 * xdisp.c (debug_method_add): Use BVAR.
3106 (check_window_end, dump_glyph_matrix, dump_glyph)
3107 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3108
3109 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3110 Likewise.
3111
3112 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3113 check till after the cache is created in init_frame_faces.
3114
ff2bc410
SM
31152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3116
3117 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3118
28177add
PE
31192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3120
dd3482fe
PE
3121 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3122 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3123 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3124
393d71f3 3125 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3126 * fileio.c (Finsert_file_contents):
3127 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3128 Remove the old (too-loose) buffer overflow checks.
3129 They weren't needed, since make_gap checks for buffer overflow.
3130 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3131 The old code merely checked for Emacs fixnum overflow, and relied
3132 on undefined (wraparound) behavior. The new code avoids undefined
3133 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3134
2e6813b0 3135 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3136 Tune. Don't use wider integers than needed. Don't use alloca.
3137 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3138
599a9e4f
PE
3139 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3140
99561444
PE
3141 * insdel.c, lisp.h (buffer_overflow): New function.
3142 (insert_from_buffer_1, replace_range, replace_range_2):
3143 * insdel.c (make_gap_larger):
3144 * editfns.c (Finsert_char):
3145 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3146
28177add
PE
3147 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3148
e69dafad
PE
31492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3150
a7af7fde 3151 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3152
b1c46f02
PE
3153 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3154 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3155
e69dafad
PE
3156 * fileio.c: Don't assume EMACS_INT fits in off_t.
3157 (emacs_lseek): New static function.
3158 (Finsert_file_contents, Fwrite_region): Use it.
3159 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3160
566684ea
PE
3161 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3162
e6966cd6
PE
3163 * fns.c: Don't overflow int when computing a list length.
3164 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3165 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3166 truncation on 64-bit hosts. Check for QUIT every
3167 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3168 faster and is responsive enough.
3169 (Flength): Report an error instead of overflowing an integer.
3170 (Fsafe_length): Return a float if the value is not representable
3171 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3172 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3173 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3174
dd0b0efb
PE
3175 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3176 (header_size, word_size): New constants.
3177 (allocate_vectorlike): Don't check size overflow here.
3178 (allocate_vector): Check it here instead, since this is the only
3179 caller of allocate_vectorlike that could cause overflow.
3180 Check that the new vector's length is representable as a fixnum.
3181
86fe5cfe
PE
3182 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3183 The previous code was bogus. For example, next_almost_prime (32)
3184 returned 39, which is undesirable as it is a multiple of 3; and
3185 next_almost_prime (24) returned 25, which is a multiple of 5 so
3186 why was the code bothering to check for multiples of 7?
3187
80e88859
PE
3188 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3189
4a2f0ad6
PE
3190 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3191
f66c7cf8
PE
3192 Variadic C functions now count arguments with ptrdiff_t.
3193 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3194 Back then I didn't know that the Emacs coding style prefers signed int.
3195 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3196 were being counted with int, which may truncate counts on 64-bit
3197 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3198 * lisp.h (struct Lisp_Subr.function.aMANY)
3199 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3200 Arg counts are now ptrdiff_t, not size_t.
3201 All variadic functions and their callers changed accordingly.
3202 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3203 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3204 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3205 * callint.c (Fcall_interactively): Check arg count for overflow,
3206 to avoid potential buffer overrun. Use signed char, not 'int',
3207 for 'varies' array, so that we needn't bother to check its size
3208 calculation for overflow.
3209 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3210 * eval.c (apply_lambda):
3211 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3212 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3213 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3214
a1759b76
PE
3215 * callint.c (Fcall_interactively): Don't use index var as event count.
3216
d96be9fc
PE
3217 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3218 * mem-limits.h (SIZE): Remove; no longer used.
3219
a690a978 3220 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3221
578c21e6
PE
3222 Remove unnecessary casts.
3223 * xterm.c (x_term_init):
3224 * xfns.c (x_set_border_pixel):
3225 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3226 These aren't needed now that we assume ANSI C.
3227
96f53c6c
PE
3228 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3229 It's more likely to cause problems (due to unsigned overflow)
3230 than to cure them.
3231
83c77d31
PE
3232 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3233
ee2079f1
PE
3234 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3235
6da65536
PE
3236 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3237
7147c4a4
PE
3238 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3239
193e32d9
PE
3240 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3241
e5533da6
PE
3242 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3243
9910e595
PE
3244 GLYPH_CODE_FACE returns EMACS_INT, not int.
3245 * dispextern.h (merge_faces):
3246 * xfaces.c (merge_faces):
01103c44
PE
3247 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3248 Don't assume EMACS_INT fits in int.
9910e595 3249
2638320e
PE
3250 * character.h (CHAR_VALID_P): Remove unused parameter.
3251 * fontset.c, lisp.h, xdisp.c: All uses changed.
3252
045eb8d9
PE
3253 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3254
c1f134b5
PE
3255 * fns.c (concat): Minor tuning based on overflow analysis.
3256 This doesn't fix any bugs. Use int to hold character, instead
3257 of constantly refetching from Emacs object. Use XFASTINT, not
3258 XINT, for value known to be a character. Don't bother comparing
3259 a single byte to 0400, as it's always less.
3260
395fcb93 3261 * floatfns.c (Fexpt):
327eeec8
PE
3262 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3263
abbd3d23
PE
3264 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3265 for characters.
3266
684a03ef
PE
3267 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3268
0fed43f3
PE
3269 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3270 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3271 incorrectly succeed when S was a string, because 4294967386 was
3272 truncated before it was used.
3273
8fd02eb7
PE
3274 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3275 Otherwise, an out-of-range integer could cause undefined behavior
3276 on a 64-bit host.
3277
f8c86b69
PE
3278 * composite.c: Use int, not EMACS_INT, for characters.
3279 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3280 EMACS_INT, for values that are known to be in character range.
3281 This doesn't fix any bugs but is the usual style inside Emacs and
3282 may generate better code on 32-bit machines.
3283
34206dd2
PE
3284 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3285 This is for reasons similar to the recent CHAR_STRING fix.
3286 * charset.c (Fencode_char): Check that character arg is actually
3287 a character. Pass an int to ENCODE_CHAR.
3288 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3289 wider than 'int', as a compile-time check to prevent future regressions
3290 in this area.
3291
c5958d4c 3292 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3293
3294 Make sure a 64-bit char is never passed to CHAR_STRING.
3295 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3296 by silently ignoring the top 32 bits, allowing some values
3297 that were far too large to be valid characters.
3298 * character.h: Include <verify.h>.
3299 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3300 arguments are no wider than unsigned, as a compile-time check
3301 to prevent future regressions in this area.
3302 * data.c (Faset):
01103c44 3303 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3304 (Fsubst_char_in_region):
3305 * fns.c (concat):
3306 * xdisp.c (decode_mode_spec_coding):
3307 Adjust to CHAR_STRING's new requirement.
3308 * editfns.c (Finsert_char, Fsubst_char_in_region):
3309 * fns.c (concat): Check that character args are actually
3310 characters. Without this test, these functions did the wrong
3311 thing with wildly out-of-range values on 64-bit hosts.
3312
d37ca623
PE
3313 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3314 These casts should not be needed on 32-bit hosts, either.
3315 * keyboard.c (read_char):
3316 * lread.c (Fload): Remove casts to unsigned.
3317
ea204efb
PE
3318 * lisp.h (UNSIGNED_CMP): New macro.
3319 This fixes comparison bugs on 64-bit hosts.
3320 (ASCII_CHAR_P): Use it.
3321 * casefiddle.c (casify_object):
01103c44 3322 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3323 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3324 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3325 * dispextern.h (FACE_FROM_ID):
3326 * keyboard.c (read_char): Use UNSIGNED_CMP.
3327
41cb286c
PE
3328 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3329 not to EMACS_INT, to avoid GCC warning.
3330
4a1b9832
PE
3331 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3332
55daad71
PE
3333 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3334 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3335 isn't needed on 32-bit machines.
8f95c75c 3336
01103c44
PE
3337 * buffer.c (Fgenerate_new_buffer_name):
3338 Use EMACS_INT for count, not int.
0ceccced 3339 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3340
3341 * data.c (Qcompiled_function): Now static.
3342
c6f072e7
PE
3343 * window.c (window_body_lines): Now static.
3344
20ce5912
PE
3345 * image.c (gif_load): Rename local to avoid shadowing.
3346
9c4c5f81
PE
3347 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3348 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3349 * alloc.c (make_save_value): Integer argument is now of type
3350 ptrdiff_t, not int.
3351 (mark_object): Use ptrdiff_t, not int.
3352 * lisp.h (pD): New macro.
3353 * print.c (print_object): Use it.
3354
c0c5c8ae
PE
3355 * alloc.c: Use EMACS_INT, not int, to count objects.
3356 (total_conses, total_markers, total_symbols, total_vector_size)
3357 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3358 (total_free_floats, total_floats, total_free_intervals)
3359 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3360 Now EMACS_INT, not int. All uses changed.
3361 (Fgarbage_collect): Compute overall total using a double, so that
3362 integer overflow is less likely to be a problem. Check for overflow
3363 when converting back to an integer.
5a25e253
PE
3364 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3365 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3366 These were 'int' variables that could overflow on 64-bit hosts;
3367 they were never used, so remove them instead of repairing them.
211a0b2a 3368 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3369 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3370 Previously, this ceilinged at INT_MAX, but that doesn't work on
3371 64-bit machines.
e46bb31a 3372 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3373
c78baabf 3374 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3375 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3376 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3377 when a (possibly-narrower) signed value would do just as well.
3378 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3379
c9d624c6
PE
3380 * alloc.c: Catch some string size overflows that we were missing.
3381 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3382 for convenience in STRING_BYTES_MAX.
3383 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3384 The definition here is exact; the one in lisp.h was approximate.
3385 (allocate_string_data): Check for string overflow. This catches
3386 some instances we weren't catching before. Also, it catches
3387 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3388 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3389 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3390
c9d624c6
PE
3391 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3392 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3393 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3394
353032ce
PE
3395 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3396
2bccce07
PE
3397 * alloc.c (Fmake_string): Check for out-of-range init.
3398
0ac30604
SM
33992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3400
3401 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3402
c195f2de
JD
34032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3404
3405 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3406 xg_get_default_scrollbar_width.
3407
3408 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3409 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3410 (style_changed_cb): Call update_theme_scrollbar_width and call
3411 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3412 all frames (Bug#8505).
3413 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3414 Call gtk_window_set_resizable if HAVE_GTK3.
3415 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3416 and height if HAVE_GTK3 (Bug#8505).
3417 (scroll_bar_width_for_theme): New variable.
3418 (update_theme_scrollbar_width): New function.
3419 (xg_get_default_scrollbar_width): Move code to
3420 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3421 (xg_initialize): Call update_theme_scrollbar_width.
3422
3423 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3424
3425 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3426
e10ac9f1
MR
34272011-06-12 Martin Rudalics <rudalics@gmx.at>
3428
3429 * frame.c (make_frame): Call other_buffer_safely instead of
3430 other_buffer.
3431
3432 * window.c (temp_output_buffer_show): Call display_buffer with
3433 second argument Vtemp_buffer_show_specifiers and reset latter
3434 immediately after the call.
3435 (Vtemp_buffer_show_specifiers): New variable.
3436 (auto_window_vscroll_p, next_screen_context_lines)
3437 (Vscroll_preserve_screen_position): Remove leading asterisks from
3438 doc-strings.
3439
2d3c217e 34402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3441
7b7f97e8 3442 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3443 * buffer.c (Qclone_number): Remove for now, as it's unused.
3444 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3445 (record_buffer): Remove unused local.
3446 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3447 (set_frame_buffer_list): Remove; unused.
3448 * frame.h (other_visible_frames): Remove decl.
3449 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3450 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3451 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3452 if HAVE_GPM.
3453 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3454 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3455 Define only if HAVE_GPM.
3456 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3457 (update_hints_inhibit): Remove; never set. All uses removed.
3458 * widgetprv.h (emacsFrameClassRec): Remove decl.
3459 * window.c (delete_deletable_window): Now returns void, since it
3460 wasn't returning anything.
3461 (compare_window_configurations): Remove unused locals.
3462 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3463 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3464 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3465 the same widths as pointers. This follows up on the 2011-05-06 patch.
3466 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3467 * xterm.h: Likewise.
3468 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3469
1384b89e
JB
34702011-06-12 Juanma Barranquero <lekktu@gmail.com>
3471
3472 * makefile.w32-in: Update dependencies.
3473 (LISP_H): Add lib/intprops.h.
3474
1100a63c
CY
34752011-06-11 Chong Yidong <cyd@stupidchicken.com>
3476
3477 * image.c (gif_load): Add animation frame delay to the metadata.
3478 (syms_of_image): Use DEFSYM. New symbol `delay'.
3479
6198ccd0
MR
34802011-06-11 Martin Rudalics <rudalics@gmx.at>
3481
3482 * window.c (delete_deletable_window): Re-add.
3483 (Fset_window_configuration): Rewrite to handle dead buffers and
3484 consequently deletable windows.
3485 (window_tree, Fwindow_tree): Remove. Supply functionality in
3486 window.el.
3487 (compare_window_configurations): Simplify code.
3488
b6e3633c
AS
34892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3490
1ab0dee5
AS
3491 * image.c (imagemagick_load_image): Fix type mismatch.
3492 (Fimagemagick_types): Likewise.
3493
b6e3633c
AS
3494 * window.h (replace_buffer_in_windows): Declare.
3495
9397e56f
MR
34962011-06-11 Martin Rudalics <rudalics@gmx.at>
3497
3498 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3499 Qclone_number. Remove external declaration of Qdelete_window.
3500 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3501 code.
640c8776
SM
3502 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3503 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3504 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3505 buffer list implementation.
3506 (other_buffer_safely): New function.
3507 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3508 calls to replace_buffer_in_windows and
3509 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3510 if allowed.
3511 (record_buffer): Inhibit quitting and rewrite using quittable
3512 functions. Run Qbuffer_list_update_hook if allowed.
3513 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3514 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3515 Move switch-to-buffer to window.el.
9397e56f
MR
3516 (bury-buffer): Move to window.el.
3517 (Vbuffer_list_update_hook): New variable.
3518
3519 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3520 section.
3521
3522 * window.h (resize_frame_windows): Move up in code.
3523 (Fwindow_frame): Remove EXFUN.
3524 (replace_buffer_in_all_windows): Remove prototype.
3525 (replace_buffer_in_windows_safely): Add prototype.
3526
3527 * window.c: Declare Qdelete_window static again. Move down
3528 declaration of select_count.
3529 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3530 (Fother_window): Move to window.el.
3531 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3532 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3533 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3534 window.el.
3535 (replace_buffer_in_windows): Implement by calling
3536 Qreplace_buffer_in_windows.
3537 (replace_buffer_in_all_windows): Remove with some functionality
3538 moved into replace_buffer_in_windows_safely.
3539 (replace_buffer_in_windows_safely): New function.
3540 (select_window_norecord, select_frame_norecord): Move in front
3541 of run_window_configuration_change_hook. Remove now obsolete
3542 declarations.
640c8776
SM
3543 (Fset_window_buffer): Rewrite doc-string.
3544 Call Qrecord_window_buffer.
9397e56f
MR
3545 (keys_of_window): Move binding for other-window to window.el.
3546
b50691aa
CY
35472011-06-11 Chong Yidong <cyd@stupidchicken.com>
3548
3549 * dispextern.h (struct image): Replace data member, whose int_val
3550 and ptr_val fields were not used by anything, with a single
3551 lisp_val object.
3552
3553 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3554 (gif_clear_image, gif_load, imagemagick_load_image)
3555 (gs_clear_image, gs_load): Callers changed.
3556
3f754b86
PE
35572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3558
cca69397
PE
3559 * buffer.h: Include <time.h>, for time_t.
3560 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3561
109e28d0
PE
3562 Fix minor problems found by static checking.
3563
60737f02
PE
3564 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3565
4b66faf3
PE
3566 Make identifiers static if they are not used in other modules.
3567 * data.c (Qcompiled_function, Qframe, Qvector):
3568 * image.c (QimageMagick, Qsvg):
3569 * minibuf.c (Qmetadata):
3570 * window.c (resize_window_check, resize_root_window): Now static.
3571 * window.h (resize_window_check, resize_root_window): Remove decls.
3572
109e28d0
PE
3573 * window.c (window_deletion_count, delete_deletable_window):
3574 Remove; unused.
46a4ce9e
PE
3575 (window_body_lines): Now static.
3576 (Fdelete_other_windows_internal): Mark vars as initialized.
3577 Make sure 'resize_failed' is initialized.
3578 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3579 (resize_window_apply): Remove unused local.
3580 * window.h (delete_deletable_window): Remove decl.
3581
109e28d0 3582 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3583 (imagemagick_load_image): Fix pointer signedness problem by changing
3584 last arg from unsigned char * to char *. All uses changed.
3585 Also, fix a local for similar reasons.
3586 Remove unused locals. Remove locals to avoid shadowing.
3587 (fn_rsvg_handle_free): Remove; unused.
3588 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3589 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3590
3f754b86
PE
3591 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3592
2547adb1
CY
35932011-06-10 Chong Yidong <cyd@stupidchicken.com>
3594
3595 * image.c (gif_load): Fix omitted cast error introduced by
3596 2011-06-06 change.
3597
2c8e37d4
MR
35982011-06-10 Martin Rudalics <rudalics@gmx.at>
3599
3600 * window.h (resize_proportionally, orig_total_lines)
3601 (orig_top_line): Remove from window structure.
3602 (set_window_height, set_window_width, change_window_heights)
3603 (Fdelete_window): Remove prototypes.
3604 (resize_frame_windows): Remove duplicate declaration.
3605
440a42e3
EZ
36062011-06-10 Eli Zaretskii <eliz@gnu.org>
3607
3608 * window.h (resize_frame_windows, resize_window_check)
3609 (delete_deletable_window, resize_root_window)
3610 (resize_frame_windows): Declare prototypes.
3611
3612 * window.c (resize_window_apply): Make definition be "static" to
3613 match the prototype.
3614
562dd5e9
MR
36152011-06-10 Martin Rudalics <rudalics@gmx.at>
3616
3617 * window.c: Remove declarations of Qwindow_size_fixed,
3618 window_min_size_1, window_min_size_2, window_min_size,
3619 size_window, window_fixed_size_p, enlarge_window, delete_window.
3620 Remove static from declaration of Qdelete_window, it's
3621 temporarily needed by Fbury_buffer.
3622 (replace_window): Don't assign orig_top_line and
3623 orig_total_lines.
3624 (Fdelete_window, delete_window): Remove. Window deletion is
3625 handled by window.el.
640c8776
SM
3626 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3627 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3628 (Fdelete_other_windows): Remove. Deleting other windows is
3629 handled by window.el.
3630 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3631 handled in window.el.
3632 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3633 Window minimum sizes are handled in window.el.
3634 (shrink_windows, size_window, set_window_height)
3635 (set_window_width, change_window_heights, window_height)
3636 (window_width, CURBEG, CURSIZE, enlarge_window)
3637 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3638 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3639 handled in window.el.
3640 (make_dummy_parent): Rename to make_parent_window and give it a
3641 second argument horflag.
3642 (make_window): Don't set resize_proportionally any more.
3643 (Fsplit_window): Remove. Windows are split in window.el.
3644 (save_restore_action, save_restore_orig_size)
3645 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3646 Resize mini windows in window.el.
3647 (grow_mini_window, shrink_mini_window): Implement by calling
3648 Qresize_root_window_vertically, resize_window_check and
3649 resize_window_apply.
640c8776
SM
3650 (saved_window, Fset_window_configuration, save_window_save):
3651 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3652 resize_proportionally.
3653 (window_min_height, window_min_width): Move to window.el.
3654 (keys_of_window): Move bindings for delete-other-windows,
3655 split-window, delete-window and enlarge-window to window.el.
3656
3657 * buffer.c: Temporarily extern Qdelete_window.
3658 (Fbury_buffer): Temporarily call Qdelete_window instead of
3659 Fdelete_window (Fbury_buffer will move to window.el soon).
3660
3661 * frame.c (set_menu_bar_lines_1): Remove code handling
3662 orig_top_line and orig_total_lines.
3663
3664 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3665 set_window_height but set heights directly.
3666 (change_frame_size_1): Use resize_frame_windows.
3667
3668 * xdisp.c (init_xdisp): Don't use set_window_height but set
3669 heights directly.
3670
640c8776
SM
3671 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3672 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3673 run_window_configuration_change_hook.
3674
3675 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3676 instead of change_window_heights and run
3677 run_window_configuration_change_hook.
3678
1a13852e
MR
36792011-06-09 Martin Rudalics <rudalics@gmx.at>
3680
3681 * window.c (replace_window): Rename second argument REPLACEMENT to
3682 NEW. New third argument SETFLAG. Rewrite.
3683 (delete_window, make_dummy_parent): Call replace_window with
3684 third argument 1.
3685 (window_list_1): Move down in code.
3686 (run_window_configuration_change_hook): Move set_buffer part
3687 before select_frame_norecord part in order to unwind correctly.
3688 Rename count1 to count.
3689 (recombine_windows, delete_deletable_window, resize_root_window)
3690 (Fdelete_other_windows_internal)
3691 (Frun_window_configuration_change_hook, make_parent_window)
3692 (resize_window_check, resize_window_apply, Fresize_window_apply)
3693 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3694 (Fdelete_window_internal, Fresize_mini_window_internal):
3695 New functions.
1a13852e
MR
3696 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3697
f3d1777e
MR
36982011-06-08 Martin Rudalics <rudalics@gmx.at>
3699
496e208e
MR
3700 * window.h (window): Add some new members to window structure -
3701 normal_lines, normal_cols, new_total, new_normal, clone_number,
3702 splits, nest, prev_buffers, next_buffers.
3703 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3704 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3705
f3d1777e
MR
3706 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3707 Remove.
496e208e
MR
3708 (make_dummy_parent): Set new members of windows structure.
3709 (make_window): Move down in code. Handle new members of window
3710 structure.
3711 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3712 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3713 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3714 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3715 (Fset_window_next_buffers, Fset_window_clone_number):
3716 New functions.
496e208e
MR
3717 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3718 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3719 Doc-string fixes.
3720 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3721 Argument WINDOW can be now internal window too.
3722 (Fwindow_use_time): Move up in code.
3723 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3724 Rewrite doc-string.
3725 (Fset_window_configuration, saved_window)
3726 (Fcurrent_window_configuration, save_window_save): Handle new
3727 members of window structure.
b9e809c2
MR
3728 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3729 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3730 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3731 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3732 Qget_mru_window, Qresize_root_window,
3733 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3734 Qauto_buffer_name; staticpro them.
f3d1777e 3735
abde8f8c
MR
37362011-06-07 Martin Rudalics <rudalics@gmx.at>
3737
3738 * window.c (Fwindow_total_size, Fwindow_left_column)
3739 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3740 (Fwindow_list_1): New functions.
3741 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3742 (Fwindow_width, Fscroll_left, Fscroll_right):
3743 Use window_body_cols instead of window_box_text_cols.
3744 (delete_window, Fset_window_configuration):
3745 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3746 (delete_all_subwindows): Take a window as argument and not a
3747 structure. Rewrite.
190b47e6
MR
3748 (window_loop): Remove handling of GET_LRU_WINDOW and
3749 GET_LARGEST_WINDOW.
3750 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3751
3752 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3753 window_box_text_cols. delete_all_subwindows now takes a
3754 Lisp_Object as argument.
abde8f8c 3755
640c8776
SM
3756 * indent.c (compute_motion, Fcompute_motion):
3757 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3758
fa8a67e6
MR
3759 * frame.c (delete_frame): Call delete_all_subwindows with root
3760 window as argument.
3761
a54e3482
DC
37622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3763
3764 * fns.c (Fputhash): Document return value.
3765
60002bf5
CY
37662011-06-06 Chong Yidong <cyd@stupidchicken.com>
3767
3768 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3769
0c671da6 37702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3771
b862a52a 3772 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3773
be44ca6c
PE
3774 Check for overflow when converting integer to cons and back.
3775 * charset.c (Fdefine_charset_internal, Fdecode_char):
3776 Use cons_to_unsigned to catch overflow.
3777 (Fencode_char): Use INTEGER_TO_CONS.
3778 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3779 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3780 * data.c (long_to_cons, cons_to_long): Remove.
3781 (cons_to_unsigned, cons_to_signed): New functions.
3782 These signal an error for invalid or out-of-range values.
3783 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3784 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3785 * font.c (Ffont_variation_glyphs):
3786 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3787 * lisp.h: Include <intprops.h>.
3788 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3789 (cons_to_signed, cons_to_unsigned): New decls.
3790 (long_to_cons, cons_to_long): Remove decls.
3791 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3792 (Fprimitive_undo): Use CONS_TO_INTEGER.
3793 * xfns.c (Fx_window_property): Likewise.
3794 * xselect.c: Include <limits.h>.
3795 (x_own_selection, selection_data_to_lisp_data):
3796 Use INTEGER_TO_CONS.
3797 (x_handle_selection_request, x_handle_selection_clear)
3798 (x_get_foreign_selection, Fx_disown_selection_internal)
3799 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3800 (lisp_data_to_selection_data): Use cons_to_unsigned.
3801 (x_fill_property_data): Use cons_to_signed.
3802 Report values out of range.
3803
d1f3d2af
PE
3804 Check for buffer and string overflow more precisely.
3805 * buffer.h (BUF_BYTES_MAX): New macro.
3806 * lisp.h (STRING_BYTES_MAX): New macro.
3807 * alloc.c (Fmake_string):
3808 * character.c (string_escape_byte8):
3809 * coding.c (coding_alloc_by_realloc):
3810 * doprnt.c (doprnt):
3811 * editfns.c (Fformat):
3812 * eval.c (verror):
3813 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3814 since they may not be the same number.
3815 * editfns.c (Finsert_char):
3816 * fileio.c (Finsert_file_contents):
3817 Likewise for BUF_BYTES_MAX.
3818
dd52fcea
PE
3819 * image.c: Use ptrdiff_t, not int, for sizes.
3820 (slurp_file): Switch from int to ptrdiff_t.
3821 All uses changed.
3822 (slurp_file): Check that file size fits in both size_t (for
3823 malloc) and ptrdiff_t (for sanity and safety).
3824
7f9bbdbb
PE
3825 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3826 if b->modtime has its maximal value.
3827
dfe18f82
PE
3828 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3829
84acfcf0
PE
3830 Don't assume time_t can fit into int.
3831 * buffer.h (struct buffer.modtime): Now time_t, not int.
3832 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3833 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3834
ccd9a01a
PE
3835 Minor fixes for signed vs unsigned integers.
3836 * character.h (MAYBE_UNIFY_CHAR):
3837 * charset.c (maybe_unify_char):
3838 * keyboard.c (read_char, reorder_modifiers):
3839 XINT -> XFASTINT, since the integer must be nonnegative.
3840 * ftfont.c (ftfont_spec_pattern):
3841 * keymap.c (access_keymap, silly_event_symbol_error):
3842 XUINT -> XFASTINT, since the integer must be nonnegative.
3843 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3844 since it makes no difference and we prefer signed.
3845 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3846 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3847 nonnegative.
3848
d6d100dd
SM
38492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3850
3851 * window.h (Fwindow_frame): Declare.
3852
2b6148e4
PE
38532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3854
3855 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3856 (SPARE_MEMORY): Always define.
3857 (LARGE_REQUEST): Remove.
3858 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3859
f230ecc9
MR
38602011-06-06 Martin Rudalics <rudalics@gmx.at>
3861
727e958e
MR
3862 * lisp.h: Move EXFUNS for Fframe_root_window,
3863 Fframe_first_window and Fset_frame_selected_window to window.h.
3864
3865 * window.h: Move EXFUNS for Fframe_root_window,
3866 Fframe_first_window and Fset_frame_selected_window here from
3867 lisp.h.
3868
3869 * frame.c (Fwindow_frame, Fframe_first_window)
3870 (Fframe_root_window, Fframe_selected_window)
3871 (Fset_frame_selected_window): Move to window.c.
3872 (Factive_minibuffer_window): Move to minibuf.c.
3873 (Fother_visible_frames_p): New function.
3874
3875 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3876
f230ecc9
MR
3877 * window.c (decode_window, decode_any_window): Move up in code.
3878 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3879 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3880 (Fwindow_buffer): Move up and rewrite doc-string.
3881 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3882 (Fwindow_prev): New functions.
727e958e
MR
3883 (Fwindow_frame): Move here from frame.c. Accept any window as
3884 argument.
3885 (Fframe_root_window, Fframe_first_window)
3886 (Fframe_selected_window): Move here from frame.c. Accept frame
3887 or arbitrary window as argument. Update doc-strings.
3888 (Fminibuffer_window): Move up in code.
3889 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3890 (Fset_frame_selected_window): Move here from frame.c.
3891 Marginal rewrite.
727e958e
MR
3892 (Fselected_window, select_window, Fselect_window): Move up in
3893 code. Minor doc-string fixes.
f230ecc9 3894
4d09bcf6
PE
38952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3898 Do not assume that spare memory exists; that assumption is valid
3899 only if SYSTEM_MALLOC.
3900 (LARGE_REQUEST): New macro, so that the issue of large requests
3901 is separated from the issue of spare memory.
3902
810928a2
AS
39032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3904
172418ad
AS
3905 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3906 format. (Bug#8806)
3907
43f862f7
AS
3908 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3909
810928a2
AS
3910 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3911 before statements.
3912
a059fe24
JD
39132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3914
3915 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3916
3917 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3918
3919 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3920 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3921
989bf368
JB
39222011-06-05 Juanma Barranquero <lekktu@gmail.com>
3923
3924 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3925
4b80f674
CY
39262011-06-04 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3929 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3930 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3931 New error handlers.
4b80f674
CY
3932 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3933 Obey Vx_select_enable_clipboard_manager. Catch errors in
3934 x_clipboard_manager_save (Bug#8779).
3935 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3936 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3937
99a33b77 39382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3939
3940 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3941
99a33b77 39422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3943
3944 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3945 in the current matrix if keep_current_p is non-zero.
3946
8264569d
EZ
39472011-06-04 Eli Zaretskii <eliz@gnu.org>
3948
3949 * bidi.c (bidi_level_of_next_char): Fix last change.
3950
57f97249
EZ
39512011-06-03 Eli Zaretskii <eliz@gnu.org>
3952
fec2107c 3953 Support bidi reordering of text covered by display properties.
57f97249 3954
fec2107c
EZ
3955 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3956 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3957 (bidi_cache_search, bidi_cache_iterator_state)
3958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3959 (bidi_level_of_next_char, bidi_move_to_visually_next):
3960 Support character positions inside a run of characters covered by a
fec2107c
EZ
3961 display string.
3962 (bidi_paragraph_init, bidi_resolve_explicit_1)
3963 (bidi_level_of_next_char): Call bidi_fetch_char and
3964 bidi_fetch_char_advance instead of FETCH_CHAR and
3965 FETCH_CHAR_ADVANCE.
3966 (bidi_init_it): Initialize new members.
3967 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3968 definitions.
3969 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3970 instead of using explicit *_CHAR codes.
d6d100dd
SM
3971 (bidi_resolve_explicit, bidi_resolve_weak):
3972 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3973 bidirectional text is supported only in multibyte buffers.
3974 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3975 it to initialize the frame_window_p member of struct bidi_it.
3976 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3977 (bidi_resolve_explicit, bidi_resolve_weak)
3978 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3979 bidi_it->nchars is non-positive.
3980 (bidi_level_of_next_char): Don't try to lookup the cache for the
3981 next/previous character if nothing is cached there yet, or if we
3982 were just reseat()'ed to a new position.
c40e2fb2 3983
0e14fe90
EZ
3984 * xdisp.c (set_cursor_from_row): Set start and stop points
3985 according to the row's direction when priming the loop that looks
3986 for the glyph on which to display cursor.
3987 (single_display_spec_intangible_p): Function deleted.
3988 (display_prop_intangible_p): Reimplement to call
3989 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3990 Accept 3 additional arguments needed by handle_display_spec.
3991 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3992 values: lists, `(when COND...)' forms, etc.
3993 (single_display_spec_string_p): Support property values that are
3994 lists with the argument STRING its top-level element.
3995 (display_prop_string_p): Fix the condition for processing a
3996 property that is a list to be consistent with handle_display_spec.
fec2107c 3997 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3998 last portion of handle_display_prop.
3999 (compute_display_string_pos): Accept additional argument
4000 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4001 value of a `display' property is a "replacing spec".
4002 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4003 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4004 the display property, but just return a value indicating whether
4005 the display property will replace the characters it covers.
4006 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4007 frame_window_p members of struct bidi_it.
d6d100dd
SM
4008 (compute_display_string_pos, compute_display_string_end):
4009 New functions.
fec2107c
EZ
4010 (push_it): Accept second argument POSITION, where pop_it should
4011 jump to continue iteration.
4012 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4013
fec2107c
EZ
4014 * keyboard.c (adjust_point_for_property): Adjust the call to
4015 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4016
4017 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4018 (bidi_init_it): Update prototypes.
4019 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4020 (compute_display_string_pos, compute_display_string_end):
4021 Declare prototypes.
fec2107c
EZ
4022 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4023 EMACS_INT.
fc6f18ce 4024
40087514 40252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4026
57f53182
PE
4027 Malloc failure behavior now depends on size of allocation.
4028 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4029 * lisp.h: Change signatures accordingly.
4030 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4031 All callers changed. (Bug#8762)
4032
4033 * gnutls.c: Use Emacs's memory allocators.
4034 Without this change, the gnutls library would invoke malloc etc.
4035 directly, which causes problems on non-SYNC_INPUT hosts, and which
4036 runs afoul of improving memory_full behavior. (Bug#8761)
4037 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4038 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4039 xfree instead of the default malloc, realloc, free.
4040 (Fgnutls_boot): No need to check for memory allocation failure,
4041 since xmalloc does that for us.
4042
ac32cd99 4043 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4044 * category.c (hash_get_category_set):
4045 * ccl.c (ccl_driver):
4046 * charset.c (Fdefine_charset_internal):
4047 * charset.h (struct charset.hash_index):
4048 * composite.c (get_composition_id, gstring_lookup_cache)
4049 (composition_gstring_put_cache):
4050 * composite.h (struct composition.hash_index):
4051 * dispextern.h (struct image.hash):
4052 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4053 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4054 (hashfn_equal, hashfn_user_defined, make_hash_table)
4055 (maybe_resize_hash_table, hash_lookup, hash_put)
4056 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4057 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4058 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4059 * image.c (make_image, search_image_cache, lookup_image)
4060 (xpm_put_color_table_h):
4061 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4062 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4063 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4064 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4065 * alloc.c (allocate_vectorlike):
4066 Check for overflow in vector size calculations.
4067 * ccl.c (ccl_driver):
4068 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4069 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4070 need to be updated by these changes.
40087514
PE
4071 * fns.c (make_hash_table, maybe_resize_hash_table):
4072 Check for integer overflow with large hash tables.
0de4bb68
PE
4073 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4074 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4075 (SXHASH_REDUCE): New macro.
4076 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4077 Use it instead of discarding useful hash info with large hash values.
4078 (sxhash_float): New function.
4079 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4080 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4081 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4082 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4083 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4084 Adjust signatures to match updated version of code.
4085 (consing_since_gc): Now EMACS_INT, since a single hash table can
4086 use more than INT_MAX bytes.
4087
698d32e2
DN
40882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4089
4090 Make it possible to build with GCC-4.6+ -O2 -flto.
4091
4092 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4093
fd6fa53f
SM
40942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4095
4096 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4097 Call minibuffer-inactive-mode.
4098
864db017
JB
40992011-05-31 Juanma Barranquero <lekktu@gmail.com>
4100
4101 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4102 Update dependencies.
4103
2ad0baf4
DN
41042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4105
4106 * data.c (init_data): Remove code for UTS, this system is not
4107 supported anymore.
4108
4fcc2638
DN
41092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4110
4111 Don't force ./temacs to start in terminal mode.
4112
4113 * frame.c (make_initial_frame): Initialize faces in all cases, not
4114 only when CANNOT_DUMP is defined.
4115 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4116
c56e0fd5
DN
41172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4118
4119 * dispnew.c (add_window_display_history): Use const for the string
4120 pointer. Remove declaration, not needed.
4121
333d54da 41222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4123
55d4c1b2 4124 Use 'inline', not 'INLINE'.
333d54da 4125 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4126 * alloc.c, fontset.c (INLINE): Remove.
4127 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4128 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4129 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4130 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4131 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4132
738db178
DN
41332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4134
4135 Make it possible to run ./temacs.
4136
4137 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4138 syms_of_callproc does the same thing. Remove test for
4139 "initialized", do it in the caller.
4140 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4141
620c53a6
SM
41422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4143
4144 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4145 (read_minibuf): Use get_minibuffer.
4146 (syms_of_minibuf): Use DEFSYM.
4147 (Qmetadata): New var.
4148 * data.c (Qbuffer): Don't make it static.
4149 (syms_of_data): Use DEFSYM.
4150
e003a292
PE
41512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4152
4153 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4154 (CCL_CODE_MIN): New macro.
4155
ed008a6d
PE
41562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4157
3687c2ef
PE
4158 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4159
ed008a6d
PE
4160 * eval.c (Qdebug): Now static.
4161 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4162 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4163 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4164
d66c4c7c
CY
41652011-05-29 Chong Yidong <cyd@stupidchicken.com>
4166
4167 * image.c: Various fixes to ImageMagick code comments.
4168 (Fimagemagick_types): Doc fix.
4169
5fbc2025
PE
41702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4171
0196f88a
PE
4172 Minor fixes prompted by GCC 4.6.0 warnings.
4173
4174 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4175
5fbc2025
PE
4176 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4177 (x_clipboard_manager_save_all): Move extern decl to ...
4178 * xterm.h: ... here, so that it can be checked for consistency.
4179
1dd3c2d9
CY
41802011-05-29 Chong Yidong <cyd@stupidchicken.com>
4181
4182 * xselect.c (x_clipboard_manager_save_frame)
4183 (x_clipboard_manager_save_all): New functions.
4184 (Fx_clipboard_manager_save): Lisp function deleted.
4185
4186 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4187 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4188
4189 * xterm.h: Update prototype.
4190
5ba6571d
WX
41912011-05-28 William Xu <william.xwl@gmail.com>
4192
4193 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4194 exiting (Bug#8239).
4195
3eaff834
JM
41962011-05-28 Jim Meyering <meyering@redhat.com>
4197
e1900994 4198 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4199 * fns.c (to_uchar): Define.
4200 (crypto_hash_function): Use it to convert some newly-signed
4201 variables to unsigned, to avoid sign-extension bugs. For example,
4202 without this change, (md5 "truc") would evaluate to
4203 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4204 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4205 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4206
0f6990a7
PE
42072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 Integer overflow fixes.
c8a9ca5a 4210
08686060
PE
4211 * dbusbind.c: Serial number integer overflow fixes.
4212 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4213 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4214 to hold a serial number that is too large for a fixnum.
4215 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4216 Check for serial numbers out of range. Decode any serial number
59568bf0 4217 that was so large that it became a float. (Bug#8722)
08686060 4218
2d1fc3c7
PE
4219 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4220 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4221 Use XFASTINT rather than XUINT when numbers are nonnegative.
4222 (xd_append_arg, Fdbus_method_return_internal):
4223 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4224 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4225 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4226 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4227 (Bug#8722)
2d1fc3c7 4228
c8a9ca5a
PE
4229 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4230
519e1d69
PE
4231 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4232
30569699
PE
4233 ccl: add integer overflow checks
4234 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4235 (IN_INT_RANGE): New macros.
4236 (ccl_driver): Use them to check for integer overflow when
4237 decoding a CCL program. Many of the new checks are whether XINT (x)
4238 fits in int; it doesn't always, on 64-bit hosts. The new version
4239 doesn't catch all possible integer overflows, but it's an
847044ea 4240 improvement. (Bug#8719)
30569699 4241
c11285dc
PE
4242 * alloc.c (make_event_array): Use XINT, not XUINT.
4243 There's no need for unsigned here.
4244
fdccd48e
PE
4245 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4246 This follows up to the 2011-05-06 change that substituted uintptr_t
4247 for EMACS_INT. This case wasn't caught back then.
4248
37910ab2
PE
4249 Rework Fformat to avoid integer overflow issues.
4250 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4251 now (part of C89). Include <verify.h>.
4252 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4253 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4254 (Fformat): Avoid the prepass trying to compute sizes; it was only
4255 approximate and thus did not catch overflow reliably. Instead, walk
4256 through the format just once, formatting and computing sizes as we go,
4257 checking for integer overflow at every step, and allocating a larger
4258 buffer as needed. Keep track separately whether the format is
4259 multibyte. Keep only the most-recently calculated precision, rather
4260 than them all. Record whether each argument has been converted to
4261 string. Use EMACS_INT, not int, for byte and char and arg counts.
4262 Support field widths and precisions larger than INT_MAX. Avoid
4263 sprintf's undefined behavior with conversion specifications such as %#d
4264 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4265 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4266 formatting out-of-range floating point numbers with int
9173deec 4267 formats. (Bug#8668)
37910ab2 4268
2e6578fb
PE
4269 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4270
0ae6bdee
PE
4271 * data.c: Avoid integer truncation in expressions involving floats.
4272 * data.c: Include <intprops.h>.
4273 (arith_driver): When there's an integer overflow in an expression
4274 involving floating point, convert the integers to floating point
4275 so that the resulting value does not suffer from catastrophic
4276 integer truncation. For example, on a 64-bit host (* 4
4277 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4278 Do not rely on undefined behavior after integer overflow.
4279
de883a70
PE
4280 merge count_size_as_multibyte, parse_str_to_multibyte
4281 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4282 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4283 Check for integer overflow.
4284 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4285 since it's now a duplicate of the other. This is more of
4286 a character than a buffer op, so better that it's in character.c.
4287 * fns.c, print.c: Adjust to above changes.
4288
2ff916cb
PE
42892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4292
f1b54466
PE
42932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4294
fb1ac845
PE
4295 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4296 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4297 (x_clipboard_manager_save): Now static.
4298 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4299
f1b54466
PE
4300 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4301 (crypto_hash_function): Now static.
4302 Fix pointer signedness problems. Avoid unnecessary initializations.
4303
a9f737ee
CY
43042011-05-27 Chong Yidong <cyd@stupidchicken.com>
4305
4306 * termhooks.h (Vselection_alist): Make it terminal-local.
4307
4308 * terminal.c (create_terminal): Initialize it.
4309
4310 * xselect.c: Support for clipboard managers.
4311 (Vselection_alist): Move to termhooks.h as terminal-local var.
4312 (LOCAL_SELECTION): New macro.
4313 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4314 (symbol_to_x_atom): Remove gratuitous arg.
4315 (x_handle_selection_request, lisp_data_to_selection_data)
4316 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4317 (x_own_selection, x_get_local_selection, x_convert_selection):
4318 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4319 (some_frame_on_display): Delete unused function.
4320 (Fx_own_selection_internal, Fx_get_selection_internal)
4321 (Fx_disown_selection_internal, Fx_selection_owner_p)
4322 (Fx_selection_exists_p): New optional frame arg.
4323 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4324 (x_handle_selection_clear): Don't treat other terminals with the
4325 same keyboard specially. Use the terminal-local Vselection_alist.
4326 (x_clear_frame_selections): Use Frun_hook_with_args.
4327
4328 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4329
4330 * xterm.h: Add support for those atoms.
4331
e067f0c1
CY
43322011-05-26 Chong Yidong <cyd@stupidchicken.com>
4333
4334 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4335 (converted_selections, conversion_fail_tag): New global variables.
4336 (x_selection_request_lisp_error): Free the above.
4337 (x_get_local_selection): Remove unnecessary code.
4338 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4339 of converted selections stored in converted_selections.
4340 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4341 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4342 (x_convert_selection): New function.
4343 (x_handle_selection_event): Simplify.
4344 (x_get_foreign_selection): Don't ignore incoming requests while
4345 waiting for an answer; this will fail when we implement
4346 SAVE_TARGETS, and seems unnecessary anyway.
4347 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4348 (Vx_sent_selection_functions): Doc fix.
4349
0f4aebc0
LL
43502011-05-26 Leo Liu <sdl.web@gmail.com>
4351
4352 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4353
e61124cd
YM
43542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4355
4356 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4357
4358 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4359 for fringe update if it has periodic bitmap.
ac389d0c 4360 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4361 and fringe_bitmap_periodic_p.
4362
4363 * fringe.c (get_fringe_bitmap_data): New function.
4364 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4365 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4366 row. Mark glyph row for fringe update if periodicity changed.
4367
4368 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4369 for fringe update unless it has periodic bitmap.
4370
f16d9837
KH
43712011-05-25 Kenichi Handa <handa@m17n.org>
4372
4373 * xdisp.c (get_next_display_element): Set correct it->face_id for
4374 a static composition.
4375
e1b90ef6
LL
43762011-05-24 Leo Liu <sdl.web@gmail.com>
4377
4378 * deps.mk (fns.o):
4379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4380
4381 * fns.c (crypto_hash_function, Fsha1): New function.
4382 (Fmd5): Use crypto_hash_function.
4383 (syms_of_fns): Add Ssha1.
4384
7400048f
PE
43852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 * gnutls.c: Remove unused macros.
4388 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4389 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4390 Remove macros that are defined and never used.
4391 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4392
abb71cf4
CY
43932011-05-22 Chong Yidong <cyd@stupidchicken.com>
4394
4395 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4396 (Fx_get_selection_internal): Minor cleanup.
4397 (Fx_own_selection_internal): Rename arguments for consistency with
4398 select.el.
4399
6307db39
PE
44002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4401
4402 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4403
f3d4e0a4
CY
44042011-05-22 Chong Yidong <cyd@stupidchicken.com>
4405
4406 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4407
4d8ade89
YM
44082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4409
4410 * dispnew.c (scrolling_window): Don't exclude the case that the
4411 last enabled row in the desired matrix touches the bottom boundary.
4412
32078c8d
GM
44132011-05-21 Glenn Morris <rgm@gnu.org>
4414
4415 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4416 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4417 and add some more files.
32078c8d 4418
7285dc67
EZ
44192011-05-20 Eli Zaretskii <eliz@gnu.org>
4420
4421 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4422 report_file_error introduced by the change from 2011-05-07.
4423
89d1bd22
PE
44242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 * systime.h (Time): Define only if emacs is defined.
4427 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4428 where the include path doesn't have X11/X.h by default. See
4429 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4430
e23640bb 44312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4432
4433 * composite.c (find_automatic_composition): Fix previous change.
4434
b9704ad9
GM
44352011-05-20 Glenn Morris <rgm@gnu.org>
4436
4437 * lisp.mk: New file, split from Makefile.in.
4438 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4439 (shortlisp): Remove.
4440 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4441
4a720484
GM
44422011-05-19 Glenn Morris <rgm@gnu.org>
4443
4444 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4445 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4446 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4447 (lisp): Set the order to that of loadup.el.
4448 (shortlisp): Make it a copy of $lisp.
4449 (SOME_MACHINE_LISP): Remove.
4450 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4451 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4452
a28d4396
KH
44532011-05-18 Kenichi Handa <handa@m17n.org>
4454
4455 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4456 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4457 (find_automatic_composition): Mostly rewrite for efficiency.
4458
a2b1fa8e
JB
44592011-05-18 Juanma Barranquero <lekktu@gmail.com>
4460
4461 * makefile.w32-in: Update dependencies.
4462
8e1f5610
CS
44632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4464
4465 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4466 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4467
7025ee00 44682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4469
cdfa6eab
PE
4470 Fix some integer overflow issues, such as string length overflow.
4471
06d6db33
PE
4472 * insdel.c (count_size_as_multibyte): Check for string overflow.
4473
2b4560a8
PE
4474 * character.c (lisp_string_width): Check for string overflow.
4475 Use EMACS_INT, not int, for string indexes and lengths; in
4476 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4477 the resulting string length overflows an EMACS_INT; instead,
4478 report a string overflow if no precision given. When checking for
4479 precision exhaustion, use a check that cannot possibly have
4480 integer overflow. (Bug#8675)
4481 * character.h (lisp_string_width): Adjust to new signature.
4482
cb93f9be
PE
4483 * alloc.c (string_overflow): New function.
4484 (Fmake_string): Use it. This doesn't change behavior, but saves
4485 a few bytes and will simplify future changes.
4486 * character.c (string_escape_byte8): Likewise.
4487 * lisp.h (string_overflow): New decl.
4488
1a1f3366
PE
4489 Fixups, following up to the user-interface timestamp change.
4490 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4491 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4492 * msdos.c (mouse_get_pos): Likewise.
4493 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4494 * w32gui.h (Time): Define by including "systime.h" rather than by
4495 declaring it ourselves. (Bug#8664)
4496
d4e3e4d3
PE
4497 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4498 * image.c (clear_image_cache): Likewise.
4499
f6a24d19
PE
4500 * term.c (term_mouse_position): Don't assume time_t wraparound.
4501
08dc5ae6
PE
4502 Be more systematic about user-interface timestamps.
4503 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4504 and sometimes 'EMACS_UINT', to represent these timestamps.
4505 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4506 This makes the code easier to follow, and makes it easier to catch
4507 integer overflow bugs such as Bug#8664.
4508 * frame.c (Fmouse_position, Fmouse_pixel_position):
4509 Use Time, not unsigned long, for user-interface timestamps.
4510 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4511 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4512 * keyboard.h (last_event_timestamp): Likewise.
4513 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4514 * menu.h (xmenu_show): Likewise.
4515 * term.c (term_mouse_position): Likewise.
4516 * termhooks.h (struct input_event.timestamp): Likewise.
4517 (struct terminal.mouse_position_hook): Likewise.
4518 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4519 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4520 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4521 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4522 what it was before.
4523 * menu.h, termhooks.h: Include "systime.h", for Time.
4524
8e55734a
PE
4525 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4526 Don't assume that the difference between two unsigned long values
4527 can fit into an integer. At this point, we know button_down_time
4528 <= event->timestamp, so the difference must be nonnegative, so
4529 there's no need to cast the result if double-click-time is
4530 nonnegative, as it should be; check that it's nonnegative, just in
4531 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4532 apart (about 25 days). (Bug#8664)
8e55734a 4533
841f1b75 4534 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4535 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4536
3e26f69c
PE
4537 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4538 that always fit in int. Use a sentinel instead of a counter, to
4539 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4540 * frame.h (struct frame): Use int for menu_bar_items_used
4541 instead of EMACS_INT, since it always fits in int.
3e26f69c 4542
5cc152c0
PE
4543 * menu.c (grow_menu_items): Check for int overflow.
4544
d89eb65e
PE
4545 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4546
5235bd3e
PE
4547 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4548 Before, the code was not consistent. These values cannot exceed
4549 2**31 - 1 so there's no need to make them unsigned.
4550 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4551 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4552 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4553 as modifiers.
4554 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4555
bc827e23
PE
4556 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4557 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4558 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4559 presumably because the widths might not match.
4560
78eb494e
PE
4561 * window.c (size_window): Avoid needless test at loop start.
4562
04f2d78b
CB
45632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4564
4565 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4566
d2fc7e3d 45672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4568
4569 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4570
d2fc7e3d 45712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4572
4573 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4574 `width' to `bar_area_x' and `bar_area_width', respectively.
4575 (x_scroll_run): Take account of fringe background extension.
4576
04f2d78b
CB
4577 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4578 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4579 `bar_area_width', respectively.
4580 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4581 background extension.
4582
79b70037
GM
45832011-05-10 Jim Meyering <meyering@redhat.com>
4584
4585 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4586
2f142cc5
JB
45872011-05-10 Juanma Barranquero <lekktu@gmail.com>
4588
4589 * image.c (Finit_image_library): Return t for built-in image types,
4590 like pbm and xbm. (Bug#8640)
4591
57679c86
AS
45922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4593
4594 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4595
888c9e86
EZ
45962011-05-07 Eli Zaretskii <eliz@gnu.org>
4597
b0512a1d
EZ
4598 * w32console.c (Fset_screen_color): Doc fix.
4599 (Fget_screen_color): New function.
4600 (syms_of_ntterm): Defsubr it.
4601
7285dc67
EZ
4602 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4603 unlink the temporary file if Fcall_process didn't create it in the
4604 first place.
4605 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4606 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4607 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4608 cue to call_process_cleanup not to close that handle.
4609
4d3fcc8e
BK
46102011-05-07 Ben Key <bkey76@gmail.com>
4611
4612 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4613 one of two shell specific rules, either bootstrap-temacs-CMD or
4614 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4615 to the previous implementation of the bootstrap-temacs rule.
4616 The bootstrap-temacs-CMD rule is similar to the previous
4617 implementation of the bootstrap-temacs rule except that it
4618 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4619 variable.
4620
4621 These changes, along with some changes to nt/configure.bat,
4622 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4623 earlier fix to add support for --cflags and --ldflags options
4624 that include quotes so that it works whether make uses cmd or
4625 sh as the shell.
4626
b4289b64
MA
46272011-05-06 Michael Albinus <michael.albinus@gmx.de>
4628
4629 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4630 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4631 is a constant.
4632 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4633 a string. Handle both cases.
4634 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4635 (Fdbus_register_method): Use Qinvalid_function.
4636
af4c0e28
JB
46372011-05-06 Juanma Barranquero <lekktu@gmail.com>
4638
4639 * makefile.w32-in: Update dependencies.
4640 (LISP_H): Add inttypes.h and stdin.h.
4641 (PROCESS_H): Add unistd.h.
4642
c51453d9
EZ
46432011-05-06 Eli Zaretskii <eliz@gnu.org>
4644
4645 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4646 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4647
8ff0ac3c 46482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4649
4c4b566b
PE
4650 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4651
aab2b9b5
PE
4652 * term.c (vfatal): Remove stray call to va_end.
4653 It's not needed and the C Standard doesn't allow it here anyway.
4654
c378da0b
PE
4655 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4656 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4657
288b08c7
PE
4658 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4659 bytes.
4660
e3601888
PE
4661 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4662
db6c0e74
PE
4663 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4664
dd5963ea
PE
4665 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4666
88c9450f
PE
4667 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4668
2f9442b8
PE
4669 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4670
c032b5f8
PE
4671 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4672 * charset.c (Fdefine_charset_internal): Don't initialize
4673 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4674 32-bit int (Bug#8600).
a108c10b
PE
4675
4676 * lread.c (read_integer): Be more consistent with string-to-number.
4677 Use string_to_number to do the actual conversion; this avoids
4678 rounding errors and fixes some other screwups. Without this fix,
4679 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4680 (digit_to_number): Move earlier, for benefit of read_integer.
4681 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4682 not a digit in any supported base. (Bug#8602)
a108c10b 4683
ad5f9eea
PE
4684 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4685
aec1708a
PE
4686 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4687 to match comment at start of function. This also removes a
4688 GCC warning about overflow in a 32+64-bit port.
4689
47be4ab5
PE
4690 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4691
371cac43
PE
4692 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4693 Reported by Stefan Monnier in
4694 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4695 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4696 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4697
d01a7826
PE
4698 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4699 (EMACS_UINTPTR): Likewise, with uintptr_t.
4700
7fd47d5c
PE
4701 * lisp.h: Prefer 64-bit EMACS_INT if available.
4702 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4703 on 32-bit hosts that have 64-bit int, so that they can access
4704 large files.
122b0c86
PE
4705 However, temporarily disable this change unless the temporary
4706 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4707
8727937b
PE
4708 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4709
8ac068ac
PE
4710 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4711 This removes an assumption that EMACS_INT and long are the same
4712 width as pointers. The assumption is true for Emacs porting targets
4713 now, but we want to make other targets possible.
4714 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4715 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4716 In the rest of the code, change types of integers that hold casted
4717 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4718 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4719 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4720 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4721 No need to cast type when ORing.
4722 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4723 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4724 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4725 assume EMACS_INT is the same width as char *.
4726 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4727 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4728 Remove no-longer-needed casts.
4729 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4730 (xg_tool_bar_help_callback, xg_make_tool_item):
4731 Use EMACS_INTPTR to hold an integer
4732 that will be cast to void *; this can avoid a GCC warning
4733 if EMACS_INT is not the same width as void *.
4734 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4735 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4736 (current_message_1, set_message_1):
4737 Use a local to convert to proper width without a cast.
4738 * xmenu.c (dialog_selection_callback): Likewise.
4739
ede49d71
PE
4740 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4741 Also, don't assume VALBITS / RAND_BITS is less than 5,
4742 and don't rely on undefined behavior when shifting a 1 left into
4743 the sign bit.
4744 * lisp.h (get_random): Change signature to match.
4745
2f30ecd0
PE
4746 * lread.c (hash_string): Use size_t, not int, for hash computation.
4747 Normally we prefer signed values; but hashing is special, because
4748 it's better to use unsigned division on hash table sizes so that
4749 the remainder is nonnegative. Also, size_t is the natural width
4750 for hashing into memory. The previous code used 'int', which doesn't
4751 retain enough info to hash well into very large tables.
4752 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4753
2a866e7b
PE
4754 * dbusbind.c: Don't possibly lose pointer info when converting.
4755 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4756 Use XPNTR rather than XHASH, so that the high-order bits of
4757 the pointer aren't lost when converting through void *.
4758
51639eac
PE
4759 * eval.c (Fautoload): Don't double-shift a pointer.
4760
92394119
PE
4761 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4762
dbdb9a7c
JB
47632011-05-06 Juanma Barranquero <lekktu@gmail.com>
4764
4765 * gnutls.c (DEF_GNUTLS_FN):
4766 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4767
db7a0b4f
AS
47682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4769
4770 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4771 marker. (Bug#8610)
4772
f7ff1b0f 47732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4774
4775 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4776 New version that can reserve upto 2GB of heap space.
4777
f7ff1b0f 47782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4779
4780 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4781
639c109b
TZ
47822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4783
4784 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4785 `gnutls_certificate_set_x509_key_file'.
4786
d2127135
JB
47872011-05-05 Juanma Barranquero <lekktu@gmail.com>
4788
4789 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4790 Update dependencies.
4791
e968f4f3
JB
47922011-05-04 Juanma Barranquero <lekktu@gmail.com>
4793
4794 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4795 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4796 Remove unused parameter `fildes'.
4797 * process.c (read_process_output, send_process): Don't pass it.
4798
84d358f0
JB
47992011-05-04 Juanma Barranquero <lekktu@gmail.com>
4800
4801 Fix previous change: the library cache is defined in w32.c.
4802 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4803 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4804
0898ca10
JB
48052011-05-04 Juanma Barranquero <lekktu@gmail.com>
4806
4807 Implement dynamic loading of GnuTLS on Windows.
4808
4809 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4810 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4811 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4812 Declare.
4813
4814 * gnutls.c (Qgnutls_dll): Define.
4815 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4816 (gnutls_*): Declare function pointers.
4817 (init_gnutls_functions): New function to initialize function pointers.
4818 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4819 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4820 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4821 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4822 (emacs_gnutls_write, emacs_gnutls_read)
4823 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4824 (Fgnutls_available_p): New function.
4825 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4826 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4827 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4828
4829 * image.c: Include w32.h.
4830 (Vimage_type_cache): Delete.
4831 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4832 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4833 (w32_delayed_load): Move to w32.c.
4834
4835 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4836
4837 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4838 (w32_delayed_load): Move from image.c. When loading a library, record
4839 its filename in the :loaded-from property of the library id.
4840 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4841 Initialize and staticpro them.
4842 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4843
4844 * process.c: Include lisp.h before w32.h, not after.
4845 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4846 instead of gnutls_record_check_pending.
4847
4848 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4849
ff4de4aa
TZ
48502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4851
4852 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4853 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4854 as passed in.
4855
abe95abb
JD
48562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4857
4858 * xterm.c (x_set_frame_alpha): Do not set property on anything
4859 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4860
e16e55d4
JB
48612011-05-02 Juanma Barranquero <lekktu@gmail.com>
4862
4863 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4864
bafcf6a5
JB
48652011-05-02 Juanma Barranquero <lekktu@gmail.com>
4866
4867 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4868 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4869 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4870 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4871 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4872 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4873 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4874 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4875 (Qgnutls_bootprop_callbacks_verify): Make static.
4876
e7a6747f
AS
48772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4878
19ed11ba
AS
4879 * callproc.c: Indentation fixup.
4880
e7a6747f 4881 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4882 (wait_for_termination, interruptible_wait_for_termination):
4883 Move after wait_for_termination_1.
e7a6747f 4884
1ef14cb4
LMI
48852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4886
4887 * sysdep.c (interruptible_wait_for_termination): New function
4888 which is like wait_for_termination, but allows keyboard
4889 interruptions.
4890
4891 * callproc.c (Fcall_process): Add (:file "file") as an option for
4892 the STDOUT buffer.
4893 (Fcall_process_region): Ditto.
4894
330d880c
EZ
48952011-04-30 Eli Zaretskii <eliz@gnu.org>
4896
8db90b73
EZ
4897 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4898 rather than `XVECTOR (FOO)->size'.
4899
330d880c
EZ
4900 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4901 inttypes.h, as a gnulib replacement is used if it not available in
4902 system headers.
4903
15cbd324
EZ
49042011-04-21 Eli Zaretskii <eliz@gnu.org>
4905
4906 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4907 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4908 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4909
4910 * coding.c (coding_alloc_by_realloc): Error out if destination
4911 will grow beyond MOST_POSITIVE_FIXNUM.
4912 (decode_coding_emacs_mule): Abort if there isn't enough place in
4913 charbuf for the composition carryover bytes. Reserve an extra
4914 space for up to 2 characters produced in a loop.
4915 (decode_coding_iso_2022): Abort if there isn't enough place in
4916 charbuf for the composition carryover bytes.
4917
49182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4919
ae940cca
EZ
4920 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4921 aborting when %lld or %lll format is passed.
4922 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4923 %llo or %llx format is passed. (Bug#8545)
4924
03ab8921
EZ
4925 * window.c (window_scroll_line_based): Use a marker instead of
4926 simple variables to record original value of point. (Bug#7952)
4927
afda1437
EZ
4928 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4929 produced by %s or %c overflows available buffer space. (Bug#8545)
4930
f76dee0c
PE
49312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4934 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4935
fdc5744d
JB
49362011-04-28 Juanma Barranquero <lekktu@gmail.com>
4937
4938 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4939
638f053a
JB
49402011-04-28 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * keyboard.c (Qdelayed_warnings_hook): Define.
4943 (command_loop_1): Run `delayed-warnings-hook'
4944 if Vdelayed_warnings_list is non-nil.
4945 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4946 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4947
d178f871
EZ
49482011-04-28 Eli Zaretskii <eliz@gnu.org>
4949
4950 * doprnt.c (doprnt): Don't return value smaller than the buffer
4951 size if the message was truncated. (Bug#8545).
4952
b124fd93
JB
49532011-04-28 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4956 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4957
e810457d
PE
49582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4959
4960 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4961
ea51cceb
JB
49622011-04-27 Juanma Barranquero <lekktu@gmail.com>
4963
4964 * makefile.w32-in: Update dependencies.
4965
94dcfacf
EZ
49662011-04-27 Eli Zaretskii <eliz@gnu.org>
4967
4968 Improve `doprnt' and its usage. (Bug#8545)
4969 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4970 `format_end'. Remove support for %l as a conversion specifier.
4971 Don't use xrealloc. Improve diagnostics when the %l size modifier
4972 is used. Update the commentary.
4973
4974 * eval.c (verror): Simplify calculation of size_t.
4975
4976 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4977 messages.
4978
f61f41d7
PE
49792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4980
4981 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4982 change.
4983
96fb4434
PE
49842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4985
4986 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4987 This makes this file independent of the recent pseudovector change.
4988
671875da 49892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4990
69e9b5a3
PE
4991 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4992
b5f869a7 4993 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4994 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4995 Remove unused local.
c8926152 4996 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4997
841a1577 4998 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4999 GCC 4.6.0 optimizes based on type-based alias analysis.
5000 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5001 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5002 != &v->size, and therefore "v->size = 1; b->size = 2; return
5003 v->size;" must therefore return 1. This assumption is incorrect
5004 for Emacs, since it type-puns struct Lisp_Vector * with many other
5005 types. To fix this problem, this patch adds a new type struct
f904488f 5006 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5007 and pseudovectors, and helps optimizing compilers not get fooled
5008 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5009 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5010 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5011 the size member.
eab3844f
PE
5012 (XSETPVECTYPE): Rewrite in terms of new macro.
5013 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5014 This is a bit clearer, and further avoids the possibility of
5015 undesirable aliasing.
5016 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5017 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5018 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5019 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5020 (ASIZE): Now uses header.size rather than size.
5021 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5022 to avoid the hassle of writing XVECTOR (foo)->header.size.
5023 (struct vectorlike_header): New type.
eab3844f
PE
5024 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5025 object, to help avoid aliasing.
5026 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5027 (SUBRP): Likewise, since Lisp_Subr is a special case.
5028 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5029 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5030 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5031 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5032 changed to be "header.size" and "header.next".
5033 * buffer.h (struct buffer): Likewise.
5034 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5035 * frame.h (struct frame): Likewise.
5036 * process.h (struct Lisp_Process): Likewise.
5037 * termhooks.h (struct terminal): Likewise.
5038 * window.c (struct save_window_data, struct saved_window): Likewise.
5039 * window.h (struct window): Likewise.
5040 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5041 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5042 * buffer.c (init_buffer_once): Likewise.
5043 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5044 special case.
5045 * process.c (Fformat_network_address): Use local var for size,
5046 for brevity.
5047
0df1eac5
PE
5048 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5049
847ab9d1 5050 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5051 * data.c (atof): Remove decl; no longer used or needed.
5052 (digit_to_number): Move to lread.c.
5053 (Fstring_to_number): Use new string_to_number function, to be
5054 consistent with how the Lisp reader treats infinities and NaNs.
5055 Do not assume that floating-point numbers represent EMACS_INT
5056 without losing information; this is not true on most 64-bit hosts.
5057 Avoid double-rounding errors, by insisting on integers when
5058 parsing non-base-10 numbers, as the documentation specifies.
5059 * lisp.h (string_to_number): New decl, replacing ...
5060 (isfloat_string): Remove.
bc0a5c13 5061 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5062 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5063 appears to have been a coding error. Similarly, do not accept
5064 strings like +-1e0 as floating point numbers. Do not report
5065 overflow for integer overflows unless the base is not 10 which
5066 means we have no simple and reliable way to continue.
5067 Break out the floating-point parsing into a new
5068 function string_to_number, so that Fstring_to_number parses
5069 floating point numbers consistently with the Lisp reader.
04f2d78b 5070 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5071 (E_CHAR, EXP_INT): Remove, replacing with ...
5072 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5073 (string_to_number): New function, replacing isfloat_string.
5074 This function checks for valid syntax and produces the resulting
5075 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5076 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5077 so that overflow for non-base-10 numbers is reported only when
5078 there's no portable and simple way to convert to floating point.
452f4150 5079
67769ffc
PE
5080 * textprop.c (set_text_properties_1): Rewrite for clarity,
5081 and to avoid GCC warning about integer overflow.
5082
c20db43f
PE
5083 * intervals.h (struct interval): Use EMACS_INT for members
5084 where EMACS_UINT might cause problems. See
5085 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5086 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5087 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5088 All uses changed.
37aa2f85
PE
5089 (offset_intervals): Tell GCC not to worry about length overflow
5090 when negating a negative length.
c20db43f 5091
2538aa2f
PE
5092 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5093 (overrun_check_free): Likewise.
5094
f2d3008d
PE
5095 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5096 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5097 word size.
5098
ec8df744
PE
5099 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5100 (gnutls_make_error): Rename local to avoid shadowing.
5101 (gnutls_emacs_global_deinit): ifdef out; not used.
5102 (Fgnutls_boot): Use const for pointer to readonly storage.
5103 Comment out unused local. Fix pointer signedness problems.
5104
640ee02d
PE
5105 * lread.c (openp): Don't stuff size_t into an 'int'.
5106 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5107 about possible signed overflow.
5108
6048fb2a
PE
5109 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5110 (GDK_KEY_g): Don't define if already defined.
5111 (xg_prepare_tooltip): Avoid pointer signedness problem.
5112 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5113
fa3c87e1
PE
5114 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5115 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5116
2172544b
PE
5117 * xfns.c (Fx_window_property): Simplify a bit,
5118 to make a bit faster and to avoid GCC 4.6.0 warning.
5119 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5120
9b821a21
PE
5121 * fns.c (internal_equal): Don't assume size_t fits in int.
5122
3c616cfa
PE
5123 * alloc.c (compact_small_strings): Tighten assertion a little.
5124
c2982e87
PE
5125 Replace pEd with more-general pI, and fix some printf arg casts.
5126 * lisp.h (pI): New macro, generalizing old pEd macro to other
5127 conversion specifiers. For example, use "...%"pI"d..." rather
5128 than "...%"pEd"...".
5129 (pEd): Remove. All uses replaced with similar uses of pI.
5130 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5131 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5132 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5133 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5134 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5135 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5136 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5137 64-bit hosts.
5138 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5139 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5140 * print.c (safe_debug_print, print_object): Likewise.
5141 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5142 to int.
6f04d126
PE
5143 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5144 avoiding the 0 flag, which is not portable.
c2982e87
PE
5145 * process.c (Fmake_network_process): Use pI to avoid cast.
5146 * region-cache.c (pp_cache): Likewise.
5147 * xdisp.c (decode_mode_spec): Likewise.
5148 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5149 behavior on 64-bit hosts with printf arg.
6f04d126 5150 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5151 (x_stop_queuing_selection_requests): Likewise.
5152 (x_get_window_property): Don't truncate byte count to an 'int'
5153 when tracing.
0b432f21 5154
5e073ec7
PE
5155 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5156 here, since it parses constructs like leading '-' and spaces,
5157 which are not wanted; and it overflows with large numbers.
5158 Instead, simply match F[0-9]+, which is what is wanted anyway.
5159
36372bf9
PE
5160 * alloc.c: Remove unportable assumptions about struct layout.
5161 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5162 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5163 (allocate_vectorlike, make_pure_vector): Use the new macros,
5164 plus offsetof, to remove unportable assumptions about struct layout.
5165 These assumptions hold on all porting targets that I know of, but
5166 they are not guaranteed, they're easy to remove, and removing them
5167 makes further changes easier.
5168
0b432f21
PE
5169 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5170 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5171 (string_overrun_cookie): Now const. Use initializers that
5172 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5173 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5174 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5175 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5176 multiple of sizeof (EMACS_INT); it need not be, if
5177 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5178 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5179
895009e1
JB
51802011-04-26 Juanma Barranquero <lekktu@gmail.com>
5181
5182 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5183
6a7a1b0b
TZ
51842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5185
5186 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5187 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5188 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5189
841a1577 51902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5191
5192 * lisp.h (Qdebug): List symbol.
895009e1 5193 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5194 * keyboard.c (debug-on-event): New variable.
5195 (handle_user_signal): Break into debugger when debug-on-event
5196 matches the current signal symbol.
5197
f2d3ba6f
DN
51982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5199
5200 * alloc.c (check_sblock, check_string_bytes)
5201 (check_string_free_list): Convert to standard C.
5202
42ce4c63
TZ
52032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5204
5205 * w32.c (emacs_gnutls_push): Fix typo.
5206
825cd63c
EZ
52072011-04-25 Eli Zaretskii <eliz@gnu.org>
5208
fb11d64d
EZ
5209 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5210 "cast to pointer from integer of different size".
5211
825cd63c
EZ
5212 Improve doprnt and its use in verror. (Bug#8545)
5213 * doprnt.c (doprnt): Document the set of format control sequences
5214 supported by the function. Use SAFE_ALLOCA instead of always
5215 using `alloca'.
5216
5217 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5218 is one byte too soon. Don't use xrealloc; instead xfree and
5219 xmalloc anew.
5220
e061a11b
TZ
52212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5222
5223 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5224 callbacks stage.
5225
5226 * gnutls.c: Renamed global_initialized to
5227 gnutls_global_initialized. Added internals for the
5228 :verify-hostname-error, :verify-error, and :verify-flags
5229 parameters of `gnutls-boot' and documented those parameters in the
5230 docstring. Start callback support.
9173deec
JB
5231 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5232 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5233 on error. Return error code.
e061a11b
TZ
5234 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5235 (emacs_gnutls_read): Likewise.
5236 (Fgnutls_boot): Return handshake error code.
5237 (emacs_gnutls_handle_error): New function.
5238 (wsaerror_to_errno): Likewise.
5239
5240 * w32.h (emacs_gnutls_pull): Add prototype.
5241 (emacs_gnutls_push): Likewise.
5242
5243 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5244 (emacs_gnutls_push): Likewise.
5245
52462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5247
5248 * process.c (wait_reading_process_output): Check if GnuTLS
5249 buffered some data internally if no FDs are set for TLS
5250 connections.
5251
5252 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5253 (LIBS): Link to USER_LIBS.
5254 ($(BLD)/gnutls.$(0)): New target.
5255
fa6996bc
EZ
52562011-04-24 Eli Zaretskii <eliz@gnu.org>
5257
eb35682e
EZ
5258 * xdisp.c (handle_single_display_spec): Rename the
5259 display_replaced_before_p argument into display_replaced_p, to
5260 make it consistent with the commentary. Fix typos in the
5261 commentary.
5262
e2ad650c
EZ
5263 * textprop.c (syms_of_textprop): Remove dead code.
5264 (copy_text_properties): Delete obsolete commentary about an
5265 interface that was deleted long ago. Fix typos in the description
5266 of arguments.
5267
1b2de274
EZ
5268 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5269 to changes in oldXMenu/XMenu.h from 2011-04-16.
5270 <menu_help_message, prev_menu_help_message>: Constify.
5271 (IT_menu_make_room): menu->help_text is now `const char **';
5272 adjust.
5273
5274 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5275 to changes in oldXMenu/XMenu.h from 2011-04-16.
5276 (struct XMenu): Declare `help_text' `const char **'.
5277
5278 * xfaces.c <Qunspecified>: Make extern again.
5279
5280 * syntax.c: Include sys/types.h before including regex.h, as
5281 required by Posix.
5282
762b15be
EZ
5283 * doc.c (get_doc_string): Improve the format passed to `error'.
5284
5285 * doprnt.c (doprnt): Improve commentary.
5286
5287 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5288
5289 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5290 them with etags.
5291
f1052e5d
EZ
5292 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5293 changes in globals.h immediately force recompilation.
762b15be
EZ
5294 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5295 $(CURDIR)/s/ms-w32.h.
5296 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5297
fa6996bc
EZ
5298 * character.c (Fchar_direction): Function deleted.
5299 (syms_of_character): Don't defsubr it.
5300 <char-direction-table>: Deleted.
5301
e6c3da20
EZ
53022011-04-23 Eli Zaretskii <eliz@gnu.org>
5303
5304 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5305 * doprnt.c: Include limits.h.
5306 (SIZE_MAX): New macro.
04f2d78b
CB
5307 (doprnt): Return a size_t value. 2nd arg is now size_t.
5308 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5309 Improve overflow protection. Support `l' modifier for integer
5310 conversions. Support %l conversion. Don't assume an EMACS_INT
5311 argument for integer conversions and for %c.
5312
5313 * lisp.h (doprnt): Restore prototype.
5314
5315 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5316 $(SRC)/character.h.
5317
5318 * Makefile.in (base_obj): Add back doprnt.o.
5319
5320 * deps.mk (doprnt.o): Add back prerequisites.
5321 (callint.o): Depend on character.h.
5322
5323 * eval.c (internal_lisp_condition_case): Include the handler
5324 representation in the error message.
5325 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5326 when breaking from the loop.
5327
5328 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5329
5330 * callint.c (Fcall_interactively): When displaying error message
5331 about invalid control letter, pass the character's codepoint, not
5332 a pointer to its multibyte form. Improve display of the character
5333 in octal and display also its hex code.
5334
5335 * character.c (char_string): Use %x to display the (unsigned)
5336 codepoint of an invalid character, to avoid displaying a bogus
5337 negative value.
5338
5339 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5340 `error', not SYMBOL_NAME itself.
5341
5342 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5343 character arguments to `error'.
5344
5345 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5346 to `error' in error message about FINAL_CHAR argument. Make sure
5347 FINAL_CHAR is a character, and use %c when it is passed as
5348 argument to `error'.
5349
4ffd0d6b 53502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5351
5352 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5353
5354 * w32.c: Include <time.h>.
5355 (sys_localtime): New function.
5356
4ffd0d6b 53572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5358
5359 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5360
4ffd0d6b 5361 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5362
4ffd0d6b 53632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5364
4ffd0d6b
GM
5365 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5366 zombies (Bug#8467).
aac0c6e3 5367
04c56954
EZ
53682011-04-19 Eli Zaretskii <eliz@gnu.org>
5369
5370 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5371 gl_state.e_property when gl_state.object is Qt.
5372
5373 * insdel.c (make_gap_larger): Remove limitation of buffer size
5374 to <= INT_MAX.
5375
16a43933
CY
53762011-04-18 Chong Yidong <cyd@stupidchicken.com>
5377
5378 * xdisp.c (lookup_glyphless_char_display)
5379 (produce_glyphless_glyph): Handle cons cell entry in
5380 glyphless-char-display.
5381 (Vglyphless_char_display): Document it.
5382
5383 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5384 glyphless-char-display.
5385
4581706e
CY
53862011-04-17 Chong Yidong <cyd@stupidchicken.com>
5387
5388 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5389
5390 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5391
5392 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5393 definition for no-X builds.
5394
4887c6e2 53952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5396
fd35b6f9
PE
5397 Static checks with GCC 4.6.0 and non-default toolkits.
5398
5c1ccb01
PE
5399 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5400
006c5daa
PE
5401 * process.c (keyboard_bit_set): Define only if SIGIO.
5402 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5403 (send_process): Repair possible setjmp clobbering.
5404
efc736d3
PE
5405 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5406
4e2fe2e6
PE
5407 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5408
f97334a2
PE
5409 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5410
4e75f29d
PE
5411 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5412 Define only if needed.
5413
90efadd1
PE
5414 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5415 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5416 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5417
3c647824
PE
5418 * dispextern.h (struct redisplay_interface): Rename param
5419 to avoid shadowing.
e264f262 5420 * termhooks.h (struct terminal): Likewise.
761383f4 5421 * xterm.c (xembed_send_message): Likewise.
3c647824 5422
b58c5c4a
PE
5423 * insdel.c (make_gap_smaller): Define only if
5424 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5425
cad59032
PE
5426 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5427 it.
5428
c339dc2e
PE
5429 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5430 so that we aren't warned about unused symbols.
5431
91a3e27b
PE
5432 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5433
399c71d3 5434 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5435
8ffc96f5
PE
5436 * xfns.c (x_real_positions): Mark locals as initialized.
5437
eef9bc79
PE
5438 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5439
098db9dd
PE
5440 * xterm.c: Fix problems found by static analysis with other toolkits.
5441 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5442 (x_dispatch_event): Declare static if USE_GTK, and
5443 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5444 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5445 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5446 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5447 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5448
eb18f6cc
PE
5449 * xmenu.c (menu_help_callback): Pointer type fixes.
5450 Use const pointers when pointing at readonly data. Avoid pointer
5451 signedness clashes.
5452 (FALSE): Remove unused macro.
5453 (update_frame_menubar): Remove unused decl.
5454
1fe72bf8
PE
5455 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5456
60d9e1db
PE
5457 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5458 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5459 (single_menu_item): Rename local to avoid shadowing.
5460
39261c26
PE
5461 * keyboard.c (make_lispy_event): Remove unused local var.
5462
018c5e19
PE
5463 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5464 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5465
63d2b86e
PE
5466 * bitmaps: Change bitmaps from unsigned char back to the X11
5467 compatible char. Avoid the old compiler warnings about
5468 out-of-range initializers by using, for example, '\xab' rather
5469 than 0xab.
5470
aefd87e1
PE
5471 * xgselect.c (xgselect_initialize): Check vs interface
5472 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5473
bf501fb9
PE
5474 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5475
e9829fdf
PE
5476 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5477 to read-only memory.
5478
1086c095
PE
5479 * fns.c (vector): Remove; this old hack is no longer needed.
5480
2baccd04 5481 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5482 Remove unused var.
dde42981 5483 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5484
72391843 5485 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5486
436c16df 5487 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5488 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5489 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5490
92bb796d 5491 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5492 (x_term_init): Remove local to avoid shadowing.
92bb796d 5493
764430a3 5494 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5495
5496 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5497 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5498
d1dfb56c
EZ
54992011-04-16 Eli Zaretskii <eliz@gnu.org>
5500
c4354cb4
EZ
5501 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5502
d1dfb56c
EZ
5503 Fix regex.c, syntax.c and friends for buffers > 2GB.
5504 * syntax.h (struct gl_state_s): Declare character position members
5505 EMACS_INT.
5506
5507 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5508
04f2d78b
CB
5509 * textprop.c (verify_interval_modification, interval_of):
5510 Declare arguments EMACS_INT.
d1dfb56c
EZ
5511
5512 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5513 EMACS_INT.
5514
5515 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5516
5517 * indent.c (Fvertical_motion): Local variable it_start is now
5518 EMACS_INT.
5519
5520 * regex.c (re_match, re_match_2, re_match_2_internal)
5521 (bcmp_translate, regcomp, regexec, print_double_string)
5522 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5523 (re_compile_pattern, re_exec): Declare arguments and local
5524 variables `size_t' and `ssize_t' and return values `regoff_t', as
5525 appropriate.
5526 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5527 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5528 <compile_stack_type>: `size' and `avail' are now `size_t'.
5529
5530 * regex.h <regoff_t>: Use ssize_t, not int.
5531 (re_search, re_search_2, re_match, re_match_2): Arguments that
5532 specify buffer/string position and length are now ssize_t and
5533 size_t. Return type is regoff_t.
5534
613052cd
BK
55352011-04-16 Ben Key <bkey76@gmail.com>
5536
5537 * nsfont.m: Fixed bugs in ns_get_family and
5538 ns_descriptor_to_entity that were caused by using free to
5539 deallocate memory blocks that were allocated by xmalloc (via
5540 xstrdup). This caused Emacs to crash when compiled with
5541 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5542 --enable-checking=xmallocoverrun). xfree is now used to
5543 deallocate these memory blocks.
5544
4170f62f 55452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5546
71b41406
PE
5547 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5548
9587a89d
PE
5549 emacs_write: Accept and return EMACS_INT for sizes.
5550 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5551 et seq.
5552 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5553 Accept and return EMACS_INT.
5554 (emacs_gnutls_write): Return the number of bytes written on
5555 partial writes.
5556 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5557 (emacs_read, emacs_write): Remove check for negative size, as the
5558 Emacs source code has been audited now.
9587a89d
PE
5559 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5560 (emacs_read, emacs_write): Use it.
273a5f82
PE
5561 * process.c (send_process): Adjust to the new signatures of
5562 emacs_write and emacs_gnutls_write. Do not attempt to store
5563 a byte offset into an 'int'; it might overflow.
9587a89d 5564 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5565
3e047f51
PE
5566 * sound.c: Don't assume sizes fit in 'int'.
5567 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5568 Return EMACS_INT, not int.
3e047f51 5569 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5570 Accept EMACS_INT, not int.
5571 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5572 record read return values.
5573
cc39a9db
BK
55742011-04-15 Ben Key <bkey76@gmail.com>
5575
c9d0ec6d
JB
5576 * keyboard.c (Qundefined): Don't declare static since it is used
5577 in nsfns.m.
5578 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5579 static since they are used in nsfont.m.
cc39a9db 5580
6c60eb9f
SM
55812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5582
5583 * process.c (Qprocessp): Don't declare static.
5584 * lisp.h (Qprocessp): Declare again.
5585
7990b61a
JB
55862011-04-15 Juanma Barranquero <lekktu@gmail.com>
5587
5588 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5589
5d4cb038
PE
55902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5591
8bd7b830 5592 Improve C-level modularity by making more things 'static'.
cd64ea1d 5593
e3b27b31
PE
5594 Don't publish debugger-only interfaces to other modules.
5595 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5596 (verify_bytepos, count_markers): Move decls to the only modules
5597 that need them.
5598 * region-cache.h (pp_cache): Likewise.
5599 * window.h (check_all_windows): Likewise.
5600 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5601
5d4cb038
PE
5602 * sysdep.c (croak): Now static, if
5603 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5604 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5605
5606 * alloc.c (refill_memory_reserve): Now static if
5607 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5608 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5609
e87b6180
PE
5610 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5611 Define only if USE_LUCID.
5612
ac64929e
PE
5613 * xrdb.c (x_customization_string, x_rm_string): Now static.
5614
6f37259d
PE
5615 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5616 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5617
1683e3ab
PE
5618 * xdisp.c (draw_row_with_mouse_face): Now static.
5619 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5620
de9c2632
PE
5621 * window.h (check_all_windows): Mark externally visible.
5622
2b96acb7
PE
5623 * window.c (window_deletion_count): Now static.
5624
5625 * undo.c: Make symbols static if they're not exported.
5626 (last_undo_buffer, last_boundary_position, pending_boundary):
5627 Now static.
5628
50436f33
PE
5629 * textprop.c (interval_insert_behind_hooks): Now static.
5630 (interval_insert_in_front_hooks): Likewise.
5631
64520e5c
PE
5632 * term.c: Make symbols static if they're not exported.
5633 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5634 (max_frame_lines, tty_set_terminal_modes):
5635 (tty_reset_terminal_modes, tty_turn_off_highlight):
5636 (get_tty_terminal): Now static.
5637 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5638 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5639 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5640 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5641 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5642
1fa53021
PE
5643 * sysdep.c: Make symbols static if they're not exported.
5644 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5645 Now static.
5646 (sigprocmask_set, full_mask): Remove; unused.
5647 (wait_debugging): Mark as visible.
5648 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5649 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5650
d4b43b22
PE
5651 * syntax.c (syntax_temp): Define only if !__GNUC__.
5652
b7c513d0
PE
5653 * sound.c (current_sound_device, current_sound): Now static.
5654
989b29ad
PE
5655 * search.c (searchbufs, searchbuf_head): Now static.
5656
13a55a78
PE
5657 * scroll.c (scroll_cost): Remove; unused.
5658 * dispextern.h (scroll_cost): Remove decl.
5659
de68a1fc
PE
5660 * region-cache.h (pp_cache): Mark as externally visible.
5661
40ccffa6
PE
5662 * process.c: Make symbols static if they're not exported.
5663 (process_tick, update_tick, create_process, chan_process):
5664 (Vprocess_alist, proc_buffered_char, datagram_access):
5665 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5666 (deactivate_process): Mark defn as static, as well as decl.
5667 * lisp.h (create_process): Remove decl.
5668 * process.h (chan_process, Vprocess_alist): Remove decls.
5669
ad64fc97
PE
5670 * print.c: Make symbols static if they're not exported.
5671 (print_depth, new_backquote_output, being_printed, print_buffer):
5672 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5673 (print_interval, print_number_index, initial_stderr_stream):
5674 Now static.
5675 * lisp.h (Fprinc): Remove decl.
5676 (debug_output_compilation_hack): Mark as externally visible.
5677
adddb265
PE
5678 * sysdep.c (croak): Move decl from here to syssignal.h.
5679 * syssignal.h (croak): Put it here, so the API can be checked when
5680 'croak' is called from dissociate_if_controlling_tty.
5681
1717ede2
PE
5682 * minibuf.c: Make symbols static if they're not exported.
5683 (minibuf_save_list, choose_minibuf_frame): Now static.
5684 * lisp.h (choose_minibuf_frame): Remove decl.
5685
fa5fb2bc
PE
5686 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5687
1e3890d1
PE
5688 * lread.c: Make symbols static if they're not exported.
5689 (read_objects, initial_obarray, oblookup_last_bucket_number):
5690 Now static.
5691 (make_symbol): Remove; unused.
5692 * lisp.h (initial_obarray, make_symbol): Remove decls.
5693
8a1414fa
PE
5694 * keyboard.c: Make symbols static if they're not exported.
5695 (single_kboard, recent_keys_index, total_keys, recent_keys):
5696 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5697 (this_single_command_key_start, echoing, last_auto_save):
5698 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5699 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5700 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5701 (Vlispy_mouse_stem, double_click_count):
5702 Now static.
5703 (force_auto_save_soon): Define only if SIGDANGER.
5704 (ignore_mouse_drag_p): Now static if
5705 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5706 (print_help): Remove; unused.
5707 (stop_character, last_timer_event): Mark as externally visible.
5708 * keyboard.h (ignore_mouse_drag_p): Declare only if
5709 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5710 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5711 * lisp.h (echoing): Remove decl.
5712 (force_auto_save_soon): Declare only if SIGDANGER.
5713 * xdisp.c (redisplay_window): Simplify code, to make it more
5714 obvious that ignore_mouse_drag_p is not accessed if !defined
5715 USE_GTK && !defined HAVE_NS.
5716
93ea6e8f
PE
5717 * intervals.c: Make symbols static if they're not exported.
5718 (merge_properties_sticky, merge_interval_right, delete_interval):
5719 Now static.
5720 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5721
77382fcc
PE
5722 * insdel.c: Make symbols static if they're not exported.
5723 However, leave prepare_to_modify_buffer alone. It's never
5724 called from outside this function, but that appears to be a bug.
5725 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5726 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5727 (adjust_after_replace_noundo): Remove; unused.
5728 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5729 (signal_before_change): Remove decls.
77382fcc 5730
9306c32e
PE
5731 * indent.c (val_compute_motion, val_vmotion): Now static.
5732
cd44d2eb
PE
5733 * image.c: Make symbols static if they're not exported.
5734 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5735 if USE_GTK.
5736 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5737 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5738
ad9a7a06
PE
5739 * fringe.c (standard_bitmaps): Now static.
5740 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5741
81626931
PE
5742 * frame.c: Make symbols static if they're not exported.
5743 (x_report_frame_params, make_terminal_frame): Now static.
5744 (get_frame_param): Now static, unless HAVE_NS.
5745 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5746 (x_get_resource_string): Remove; not used.
5747 * frame.h (make_terminal_frame, x_report_frame_params):
5748 (x_get_resource_string); Remove decls.
5749 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5750 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5751
239f9db9
PE
5752 * font.c, fontset.c: Make symbols static if they're not exported.
5753 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5754 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5755 * font.c (font_close_object): Now static.
5756 * font.h (font_close_object): Remove.
5757 * fontset.c (FONTSET_OBJLIST): Remove.
5758 (free_realized_fontset) #if-0 the body, which does nothing.
5759 (face_suitable_for_char_p): #if-0, as it's never called.
5760 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5761 * xfaces.c (face_at_string_position):
5762 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5763 since 0 is always ASCII.
5764
dfcf3579
PE
5765 * fns.c (weak_hash_tables): Now static.
5766
5045092b
PE
5767 * fileio.c: Make symbols static if they're not exported.
5768 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5769 (Vwrite_region_annotation_buffers): Now static.
5770
57a96f5c
PE
5771 * eval.c: Make symbols static if they're not exported.
5772 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5773 * lisp.h (backtrace_list): Remove decl.
5774
35f08c38
PE
5775 * emacs.c: Make symbols static if they're not exported.
5776 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5777 (fatal_error_code, fatal_error_signal_hook, standard_args):
5778 Now static.
5779 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5780 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5781 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5782 * lisp.h (fatal_error_signal_hook): Remove decl.
5783 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5784
f44bd759
PE
5785 * editfns.c: Move a (normally-unused) function to its only use.
5786 * editfns.c, lisp.h (get_operating_system_release): Remove.
5787 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5788 worth the hassle of breaking this out.
5789
b532497d
PE
5790 * xterm.c: Make symbols static if they're not exported.
5791 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5792 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5793 (x_destroy_window, x_delete_display):
5794 Now static.
5795 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5796 (x_mouse_leave): Remove; unused.
5797 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5798 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5799 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5800 Remove decls.
5801 (x_mouse_leave): Declare only if WINDOWSNT.
5802 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5803 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5804 USE_X_TOOLKIT.
5805
1675728f
PE
5806 * ftxfont.c: Make symbols static if they're not exported.
5807 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5808 HAVE_FREETYPE.
5809 * font.h (ftxfont_driver): Likewise.
5810
e4cebfca
PE
5811 * xfns.c: Make symbols static if they're not exported.
5812 (x_last_font_name, x_display_info_for_name):
5813 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5814 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5815 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5816 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5817 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5818 (last_show_tip_args): Now static.
5819 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5820 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5821 (x_screen_planes): Remove; unused.
5822 * dispextern.h (x_screen_planes): Remove decl.
5823
5bf46f05
PE
5824 * dispnew.c: Make symbols static if they're not exported.
5825 * dispextern.h (redraw_garbaged_frames, scrolling):
5826 (increment_row_positions): Remove.
5827 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5828 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5829 Now static.
5830 (redraw_garbaged_frames): Remove; unused.
5831
435f4c28
PE
5832 * xfaces.c: Make symbols static if they're not exported.
5833 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5834 Remove decls.
5835 * xterm.h (defined_color): Remove decls.
5836 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5837 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5838 (menu_face_changed_default, defined_color, free_realized_face):
5839 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5840 (ascii_face_of_lisp_face): Remove; unused.
5841
8524aef3
PE
5842 * xdisp.c: Make symbols static if they're not exported.
5843 * dispextern.h (scratch_glyph_row, window_box_edges):
5844 (glyph_to_pixel_coords, set_cursor_from_row):
5845 (get_next_display_element, set_iterator_to_next):
5846 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5847 (show_mouse_face): Remove decls
5848 * frame.h (message_buf_print): Likewise.
5849 * lisp.h (pop_message, set_message, check_point_in_composition):
5850 Likewise.
5851 * xterm.h (set_vertical_scroll_bar): Likewise.
5852 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5853 (message_buf_print, scratch_glyph_row, displayed_buffer):
5854 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5855 (get_next_display_element, show_mouse_face, window_box_edges):
5856 (frame_to_window_pixel_xy, check_point_in_composition):
5857 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5858 (glyph_to_pixel_coords): Remove; unused.
5859
16390cd2
PE
5860 * dired.c (file_name_completion): Now static.
5861
5862 * dbusbind.c (xd_in_read_queued_messages): Now static.
5863
a25f4dfa
PE
5864 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5865 * data.c (circular_list_error): Remove.
5866
14a9c8df
PE
5867 * commands.h (last_point_position, last_point_position_buffer):
5868 (last_point_position_window): Remove decls.
5869 * keyboard.c: Make these variables static.
5870
04f2d78b
CB
5871 * coding.h (coding, code_convert_region, encode_coding_gap):
5872 Remove decls.
74ab6df5
PE
5873 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5874 (iso_code_class, detect_coding, code_convert_region): Now static.
5875 (encode_coding_gap): Remove; unused.
5876
38dfbee1
PE
5877 * chartab.c (chartab_chars, chartab_bits): Now static.
5878
a2cb4e63
PE
5879 * charset.h (charset_iso_8859_1): Remove decl.
5880 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5881 Now static.
5882
127198fd
PE
5883 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5884 * ccl.c (Vccl_program_table): Now static.
5885 (check_ccl_update): Remove; unused.
5886
d85b608f
PE
5887 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5888 * category.h: ... from here.
5889 * category.c (check_category_table, set_category_set): Now static.
5890
31cd66f3
PE
5891 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5892 * lisp.h: Remove these decls.
5893
c358e587
PE
5894 * buffer.c (buffer_count): Remove unused var.
5895
e78aecca
PE
5896 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5897 so that it's not optimized away.
5898 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5899 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5900 exported only to the debugger.
5901
e192d7d3 5902 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5903 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5904
92470028
PE
5905 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5906 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5907 was inaccessible from Lisp.
5908 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5909 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5910
244ed907
PE
5911 alloc.c: Import and export fewer symbols, and remove unused items.
5912 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5913 is defined.
5914 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5915 it's not optimized away by whole-program optimization.
5916 (message_enable_multibyte, free_misc): Remove.
5917 (catchlist, handlerlist, mark_backtrace):
5918 Declare only if BYTE_MARK_STACK.
5919 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5920 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5921 (message_enable_multibyte): Remove decl.
5922 (free_misc, interval_free_list, float_block, float_block_index):
5923 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5924 (cons_free_list, last_marked_index):
5925 Now static.
5926 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5927 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5928 (mark_backtrace): Define only if BYTE_MARK_STACK.
5929 * xdisp.c (message_enable_multibyte): Now static.
5930
61c2b50e 5931 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5932 This makes it easier for human readers (and static analyzers)
5933 to see whether these variables are used from other modules.
5934 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5935 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5936 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5937 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5938 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5939 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5940 * xmenu.c, xselect.c:
5941 Declare Q* vars static if they are not used in other modules.
5942 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5943 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5944 Remove decls of unexported vars.
5945 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5946
95c82688
PE
5947 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5948
16a97296
PE
5949 Make Emacs functions such as Fatom 'static' by default.
5950 This makes it easier for human readers (and static analyzers)
5951 to see whether these functions can be called from other modules.
5952 DEFUN now defines a static function. To make the function external
5953 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5954 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5955 (Finit_image_library):
16a97296
PE
5956 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5957 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5958 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5959 Remove decls, since these functions are now static.
5960 (Funintern, Fget_internal_run_time): New decls, since these functions
5961 were already external.
95c82688 5962
16a97296
PE
5963 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5964 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5965 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5966 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5967 * keyboard.c, keymap.c, lread.c:
5968 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5969 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5970 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5971 Mark functions with DEFUE instead of DEFUN,
5972 if they are used in other modules.
5973 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5974 decls for now-static functions.
5975 * buffer.h (Fdelete_overlay): Remove decl.
5976 * callproc.c (Fgetenv_internal): Mark as internal.
5977 * composite.c (Fremove_list_of_text_properties): Remove decl.
5978 (Fcomposition_get_gstring): New forward static decl.
5979 * composite.h (Fcomposite_get_gstring): Remove decl.
5980 * dired.c (Ffile_attributes): New forward static decl.
5981 * doc.c (Fdocumntation_property): New forward static decl.
5982 * eval.c (Ffetch_bytecode): New forward static decl.
5983 (Funintern): Remove extern decl; now in .h file where it belongs.
5984 * fileio.c (Fmake_symbolic_link): New forward static decl.
5985 * image.c (Finit_image_library): New forward static decl.
5986 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5987 * intervals.h (Fprevious_property_change):
5988 (Fremove_list_of_text_properties): Remove decls.
5989 * keyboard.c (Fthis_command_keys): Remove decl.
5990 (Fcommand_execute): New forward static decl.
5991 * keymap.c (Flookup_key): New forward static decl.
5992 (Fcopy_keymap): Now static.
5993 * keymap.h (Flookup_key): Remove decl.
5994 * process.c (Fget_process): New forward static decl.
5995 (Fprocess_datagram_address): Mark as internal.
5996 * syntax.c (Fsyntax_table_p): New forward static decl.
5997 (skip_chars): Remove duplicate decl.
5998 * textprop.c (Fprevious_property_change): New forward static decl.
5999 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6000 Now internal.
6001 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6002 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6003
785bbd42
PE
6004 * editfns.c (Fformat): Remove unreachable code.
6005
8b913b57
AS
60062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6007
6008 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6009 change. (Bug#8496)
6010
a6744a35
EZ
60112011-04-13 Eli Zaretskii <eliz@gnu.org>
6012
6013 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6014 when at ZV. (Bug#8487)
6015
e7974947
AS
60162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6017
baad03f0
AS
6018 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6019 (Bug#8437)
6020 * keyboard.c (parse_tool_bar_item): Likewise.
6021 * sound.c (sound_cleanup, alsa_close): Likewise.
6022 * termcap.c (tgetent): Likewise.
6023 * xfns.c (x_default_font_parameter): Likewise.
6024 * xsettings.c (read_and_apply_settings): Likewise.
6025
e7974947
AS
6026 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6027 (overrun_check_free): Protoize.
6028
28272684
PE
60292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6030
6031 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6032 since callers should never pass a negative size.
6033 Change the signature to match that of plain 'read' and 'write'; see
6034 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6035 * lisp.h: Update prototypes of emacs_write and emacs_read.
6036
11997c76
EZ
60372011-04-11 Eli Zaretskii <eliz@gnu.org>
6038
6039 * xdisp.c (redisplay_window): Don't try to determine the character
6040 position of the scroll margin if the window start point w->startp
e896f03c 6041 is outside the buffer's accessible region. (Bug#8468)
11997c76 6042
8a2cbd72
EZ
60432011-04-10 Eli Zaretskii <eliz@gnu.org>
6044
6045 Fix write-region and its subroutines for buffers > 2GB.
6046 * fileio.c (a_write, e_write): Modify declaration of arguments and
6047 local variables to support buffers larger than 2GB.
6048 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6049
6050 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6051 argument, local variables, and return value.
6052
6053 * lisp.h: Update prototypes of emacs_write and emacs_read.
6054
6055 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6056
4073e537 60572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6058
1ebfdcb6
PE
6059 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6060
b2ded58d
PE
6061 Fix more problems found by GCC 4.6.0's static checks.
6062
7d66342c
PE
6063 * xdisp.c (vmessage): Use a better test for character truncation.
6064
bbf47d44
PE
6065 * charset.c (load_charset_map): <, not <=, for optimization,
6066 and to avoid potential problems with integer overflow.
9248994d 6067 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6068 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6069 * editfns.c (Fformat): Likewise.
1e69125e 6070 * syntax.c (skip_chars): Likewise.
3befa583 6071
e3019616
PE
6072 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6073 This also lets GCC 4.6.0 generate slightly better loop code.
6074
becfa255
PE
6075 * callint.c (Fcall_interactively): <, not <=, for optimization.
6076 (Fcall_interactively): Count the number of arguments produced,
6077 not the number of arguments given. This is simpler and lets GCC
6078 4.6.0 generate slightly better code.
6079
dae0cd48
PE
6080 * ftfont.c: Distingish more carefully between FcChar8 and char.
6081 The previous code passed unsigned char * to a functions like
6082 strlen and xstrcasecmp that expect char *, which does not
6083 conform to the C standard.
6084 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6085 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6086 char * when the C standard requires it.
6087
76032d70
PE
6088 * keyboard.c (read_char): Remove unused var.
6089
eb3f1cc8
PE
6090 * eval.c: Port to Windows vsnprintf (Bug#8435).
6091 Include <limits.h>.
6092 (SIZE_MAX): Define if the headers do not.
6093 (verror): Do not give up if vsnprintf returns a negative count.
6094 Instead, grow the buffer. This ports to Windows vsnprintf, which
6095 does not conform to C99. Problem reported by Eli Zaretskii.
6096 Also, simplify the allocation scheme, by avoiding the need for
6097 calling realloc, and removing the ALLOCATED variable.
6098
70476b54
PE
6099 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6100
12020a9e
PE
6101 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6102 But keep the doprint source code for now, as we might revamp it
6103 and use it again (Bug#8435).
ea6c7ae6
PE
6104 * lisp.h (doprnt): Remove.
6105 * Makefile.in (base_obj): Remove doprnt.o.
6106 * deps.mk (doprnt.o): Remove.
6107
5fdb398c
PE
6108 error: Print 32- and 64-bit integers portably (Bug#8435).
6109 Without this change, on typical 64-bit hosts error ("...%d...", N)
6110 was used to print both 32- and 64-bit integers N, which relied on
6111 undefined behavior.
6112 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6113 New macro.
6114 * lisp.h (error, verror): Mark as printf-like functions.
6115 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6116 Report overflow in size calculations when allocating printf buffer.
6117 Do not truncate output string at its first null byte.
6118 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6119 Truncate the output at a character boundary, since vsnprintf does not
6120 do that.
6121 * charset.c (check_iso_charset_parameter): Convert internal
6122 character to string before calling 'error', since %c now has the
6123 printf meaning.
6124 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6125 overflow when computing char to be passed to 'error'. Do not
6126 pass Lisp_Object to 'error'; pass the integer instead.
6127 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6128 formatted with plain %d.
6129
b189fa66
PE
6130 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6131
bff87ef0
PE
6132 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6133
7e2cac20
PE
6134 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6135
ce4d90b5
PE
6136 * xterm.c (x_catch_errors): Remove duplicate declaration.
6137
266c9547
PE
6138 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6139
79c49ad2
PE
6140 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6141
368f4090
JM
61422011-04-10 Jim Meyering <meyering@redhat.com>
6143
6144 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6145 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6146 return ssize_t not "int", and use size_t as the buffer length.
6147 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6148 * gnutls.h: Update declarations.
6149 * process.c (read_process_output): Use ssize_t, to match.
6150 (send_process): Likewise.
6151
a32d4040
CY
61522011-04-09 Chong Yidong <cyd@stupidchicken.com>
6153
6154 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6155
8546720e 61562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6157
04f2d78b
CB
6158 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6159 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6160
8546720e
GM
6161 * xterm.c (handle_one_xevent):
6162 * xmenu.c (create_and_show_popup_menu):
6163 * xselect.c (x_decline_selection_request)
6164 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6165
0a2f5c1a 61662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6167
6168 Fix some uses of `int' instead of EMACS_INT.
6169 * search.c (string_match_1, fast_string_match)
6170 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6171 (scan_buffer, find_next_newline_no_quit)
6172 (find_before_next_newline, search_command, Freplace_match)
6173 (Fmatch_data): Make some `int' variables be EMACS_INT.
6174
6175 * xdisp.c (display_count_lines): 3rd argument and return value now
6176 EMACS_INT. All callers changed.
6177 (pint2hrstr): Last argument is now EMACS_INT.
6178
6179 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6180 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6181 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6182 (decode_coding_utf_16, decode_coding_emacs_mule)
6183 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6184 (decode_coding_ccl, decode_coding_charset)
6185 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6186 (decode_coding_iso_2022, decode_coding_emacs_mule)
6187 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6188 <char_offset, last_offset>: Declare EMACS_INT.
6189 (encode_coding_utf_8, encode_coding_utf_16)
6190 (encode_coding_emacs_mule, encode_invocation_designation)
6191 (encode_designation_at_bol, encode_coding_iso_2022)
6192 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6193 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6194 Declare EMACS_INT.
6195 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6196 (encode_invocation_designation): Last argument P_NCHARS is now
6197 EMACS_INT.
6198 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6199 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6200
6201 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6202 All users changed.
6203
6204 * ccl.c (Fccl_execute_on_string): Declare some variables
6205 EMACS_INT.
6206
8546720e 62072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6208
6209 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6210
4e19a977
CS
62112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6212
6213 * process.c (Fformat_network_address): Doc fix.
6214
87302331
R
62152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6216
6217 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6218
cbb59342
CY
62192011-04-08 Chong Yidong <cyd@stupidchicken.com>
6220
6221 * keyboard.c (read_char): Call Lisp function help-form-show,
6222 instead of using internal_with_output_to_temp_buffer.
6223 (Qhelp_form_show): New var.
e0d38eeb 6224 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6225
6226 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6227
6228 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6229
e67a13ab
CY
62302011-04-06 Chong Yidong <cyd@stupidchicken.com>
6231
04f2d78b
CB
6232 * process.c (Flist_processes): Remove to Lisp.
6233 (list_processes_1): Delete.
e67a13ab 6234
973f782d
EZ
62352011-04-06 Eli Zaretskii <eliz@gnu.org>
6236
7c106b1e
EZ
6237 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6238
973f782d
EZ
6239 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6240
41cf7d1a 62412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6242
ca23cc88
PE
6243 Fix more problems found by GCC 4.6.0's static checks.
6244
f390e2d5
PE
6245 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6246
42eea0d0
PE
6247 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6248
b69769da 6249 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6250
f9541e84
PE
6251 * xdisp.c (vmessage): Mark as a printf-like function.
6252
13841b55
PE
6253 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6254
c136c10f
PE
6255 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6256
5e2d4a30
PE
6257 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6258 printf-like functions.
6259 (tiff_load): Add casts to remove these marks before passing them
6260 to system-supplied API.
6261
583f48b9
PE
6262 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6263
b25d760e
PE
6264 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6265 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6266 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6267 directly, rather than having caller test rule sign. This avoids
6268 some unnecessary tests.
6269 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6270 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6271 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6272
bc7b6697 6273 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6274 (xfont_open): Avoid unnecessary tests.
bc7b6697 6275
27ccc379
PE
6276 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6277
dcd5c89a
PE
6278 * composite.h, composite.c (composition_gstring_put_cache):
6279 Use EMACS_INT, not int, for length.
6280
b13a45c6
PE
6281 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6282 breaking out part of COMPOSITION_DECODE_RULE.
6283 (COMPOSITION_DECODE_RULE): Use it.
6284 * composite.c (get_composition_id): Remove unused local vars,
6285 by using the new macro.
6286
1e792e4d
PE
6287 * textprop.c (set_text_properties_1): Change while to do-while,
6288 since the condition is always true at first.
6289
dc6c6455 6290 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6291 (interval_deletion_adjustment): Return unsigned value.
6292 All uses changed.
dc6c6455 6293
aba7731a
PE
6294 * process.c (list_processes_1, create_pty, read_process_output):
6295 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6296 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6297 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6298 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6299 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6300
fdfc4bf3
PE
6301 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6302
fca8fe46 6303 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6304 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6305
06a0259a 6306 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6307 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6308 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6309
e7b9e80f
PE
6310 * print.c (print_error_message): Avoid int overflow.
6311
56201685
PE
6312 * font.c (font_list_entities): Redo for clarity,
6313 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6314
78834453 6315 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6316 (font_score): Avoid potential overflow in diff calculation.
78834453 6317
0bc0b309 6318 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6319 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6320
e610eaca
PE
6321 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6322
b895abce
PE
6323 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6324 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6325 can always succeed if overflow has undefined behavior.
6326
1f1d9321 6327 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6328 (wordify): Omit three unnecessary tests.
1f1d9321 6329
c59478bc
PE
6330 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6331 All callers changed. This avoids the need for an unused var.
6332
79b73827
PE
6333 * casefiddle.c (casify_region): Remove var that is set but not used.
6334
a4db5dfe
PE
6335 * dired.c (file_name_completion): Remove var that is set but not used.
6336
43aae36e
PE
6337 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6338
2a47c44d 6339 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6340 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6341
a37c69bf
PE
6342 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6343 Check for integer overflow on size calculations.
6344
328ab8e7
PE
6345 * buffer.c (Fprevious_overlay_change): Remove var that is set
6346 but not used.
6347
e5a2a5cb
PE
6348 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6349 Remove vars that are set but not used.
8d84a6eb 6350 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6351 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6352
a60e5f68
PE
6353 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6354
f661cb61 6355 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6356 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6357
f0397f5a
PE
6358 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6359 that are set but not used.
6360
8664db06 6361 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6362 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6363
6abdaa4a
PE
6364 * xselect.c (x_get_local_selection, x_handle_property_notify):
6365 Remove vars that are set but not used.
6366
0ce7538d 6367 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6368 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6369
9ae848fc
PE
6370 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6371 Remove var that is set but not used.
0b918413
PE
6372 (scroll_bar_windows_size): Now size_t, not int.
6373 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6374 Check for overflow.
9ae848fc 6375
a5a62657
PE
6376 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6377 (map_tty_color) [!defined MSDOS]: Likewise.
6378
5c5cdd39
PE
6379 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6380
66ebf983
PE
6381 * coding.c: Remove vars that are set but not used.
6382 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6383 All callers changed.
6384 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6385 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6386 (decode_coding_charset): Remove vars that are set but not used.
6387
1be4d761
PE
6388 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6389 that is set but not used.
6390
47553fa8
PE
6391 * print.c (print_object): Remove var that is set but not used.
6392
1f7196bf 6393 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6394 The gnulib version avoids calling malloc in the usual case,
6395 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6396 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6397 * filelock.c (current_lock_owner): Likewise.
6398 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6399 * sysdep.c: Include allocator.h, careadlinkat.h.
6400 (emacs_no_realloc_allocator): New static constant.
6401 (emacs_readlink): New function.
fdb61804
PE
6402 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6403 ../lib/careadlinkat.h.
d1fdcab7 6404
f84c17c7
SM
64052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6406
6407 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6408 first non-nil return value).
6409
ef3862ad
JD
64102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6411
6412 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6413 if not defined (Bug#8403).
6414
376a7006
JB
64152011-04-02 Juanma Barranquero <lekktu@gmail.com>
6416
6417 * xdisp.c (display_count_lines): Remove parameter `start',
6418 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6419 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6420 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6421 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6422 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6423 and thereabouts. All callers changed.
6424 (get_per_char_metric): Remove parameter `f', unused since
6425 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6426
6ca3801d
JM
64272011-04-02 Jim Meyering <meyering@redhat.com>
6428
6429 do not dereference NULL upon failed strdup
6430 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6431 (ns_get_family): Likewise.
6432
d8e2b5ba
JB
64332011-04-02 Juanma Barranquero <lekktu@gmail.com>
6434
6435 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6436
8c74fcbd
JD
64372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6438
6439 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6440 later (Bug#8403).
6441
7200d79c
SM
64422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6443
03408648 6444 Add lexical binding.
7200d79c 6445
03408648
SM
6446 * window.c (Ftemp_output_buffer_show): New fun.
6447 (Fsave_window_excursion):
6448 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6449
6450 * lread.c (lisp_file_lexically_bound_p): New function.
6451 (Fload): Bind Qlexical_binding.
6452 (readevalloop): Remove `evalfun' arg.
6453 Bind Qinternal_interpreter_environment.
6454 (Feval_buffer): Bind Qlexical_binding.
6455 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6456 Mark as dynamic.
6457 (syms_of_lread): Declare `lexical-binding'.
6458
6459 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6460
6461 * keyboard.c (eval_dyn): New fun.
6462 (menu_item_eval_property): Use it.
ca105506
SM
6463
6464 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6465
03408648
SM
6466 * fns.c (concat, mapcar1): Accept byte-code-functions.
6467
6468 * eval.c (Fsetq): Handle lexical vars.
6469 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6470 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6471 (FletX, Flet): Obey lexical binding.
6472 (Fcommandp): Handle closures.
6473 (Feval): New `lexical' arg.
6474 (eval_sub): New function extracted from Feval. Use it almost
6475 everywhere where Feval was used. Look up vars in lexical env.
6476 Handle closures.
6477 (Ffunctionp): Move from subr.el.
6478 (Ffuncall): Handle closures.
6479 (apply_lambda): Remove `eval_flags'.
6480 (funcall_lambda): Handle closures and new byte-code-functions.
6481 (Fspecial_variable_p): New function.
6482 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6483 but without exporting it to Lisp.
23aba0ea 6484
23aba0ea 6485 * doc.c (Fdocumentation, store_function_docstring):
03408648 6486 * data.c (Finteractive_form): Handle closures.
23aba0ea 6487
03408648
SM
6488 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6489 interactive spec.
ba83908c 6490
04f2d78b
CB
6491 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6492 New byte-codes.
03408648
SM
6493 (exec_byte_code): New function extracted from Fbyte_code to handle new
6494 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6495
03408648 6496 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6497
03408648 6498 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6499
e2abce01
JB
65002011-03-31 Juanma Barranquero <lekktu@gmail.com>
6501
6502 * xdisp.c (redisplay_internal): Fix prototype.
6503
63696a73 65042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6505
63696a73 6506 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6507 (try_scrolling): Use it when setting scroll_limit.
6508 Limit scrolling to 100 screen lines.
63696a73
EZ
6509 (redisplay_window): Even when falling back on "recentering",
6510 position point in the window according to scroll-conservatively,
6511 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6512
6513 (try_scrolling): When point is above the window, allow searching
6514 as far as scroll_max, or one screenful, to compute vertical
6515 distance from PT to the scroll margin position. This prevents
6516 try_scrolling from unnecessarily failing when
6517 scroll-conservatively is set to a value slightly larger than the
6518 window height. Clean up the case of PT below the margin at bottom
6519 of window: scroll_max can no longer be INT_MAX. When aggressive
6520 scrolling is in use, don't let point enter the opposite scroll
6521 margin as result of the scroll.
6522 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6523 threshold of 100 lines for never-recentering scrolling.
6524
e4cc2dfc
JB
65252011-03-31 Juanma Barranquero <lekktu@gmail.com>
6526
6527 * dispextern.h (move_it_by_lines):
6528 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6529 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6530 (message_log_check_duplicate): Remove parameters `prev_bol' and
6531 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6532 (redisplay_internal): Remove parameter `preserve_echo_area',
6533 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6534
6535 * indent.c (Fvertical_motion):
6536 * window.c (window_scroll_pixel_based, Frecenter):
6537 Don't pass `need_y_p' to `move_it_by_lines'.
6538
1c470562
SM
65392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6540
44f230aa
SM
6541 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6542 steal a few bits to be more compact.
6543 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6544 Remove unneeded casts.
6545
1c470562
SM
6546 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6547
888adce9
ZK
65482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6549
6550 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6551 binding" message (bug#7967).
6552
f838ed7b
PE
65532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6554
77861b95
PE
6555 Fix more problems found by GCC 4.6.0's static checks.
6556
de6dbc14
PE
6557 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6558 Remove unused local var.
6559
f838ed7b
PE
6560 * editfns.c (Fmessage_box): Remove unused local var.
6561
792c7b2b
PE
6562 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6563 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6564 Omit unused local vars.
c499e557 6565 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6566 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6567 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6568 Omit unused local var.
6569
ba0165e1
PE
6570 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6571 Don't assume string length fits in int.
32ad8845 6572 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6573 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6574
3c59b4c9
PE
6575 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6576 instead of alloca (Bug#8344).
6577
a3eed478 6578 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6579 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6580
eb4d412d
PE
6581 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6582
1658b401
PE
6583 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6584 concerns.
6585
6586 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6587
6588 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6589
9a2c6e05
PE
6590 * keyboard.c (syms_of_keyboard): Use the same style as later
6591 in this function when indexing through an array. This also
6592 works around GCC bug 48267.
6593
03d0a109
PE
6594 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6595
44f730c8
PE
6596 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6597
fe75f926
PE
6598 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6599 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6600
ffa8c828
PE
6601 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6602 This avoids undefined behavior on integer overflow, and is a bit
6603 more convenient anyway since it is compared to a size_t variable.
6604
c5101a77
PE
6605 Variadic C functions now count arguments with size_t, not int.
6606 This avoids an unnecessary limitation on 64-bit machines, which
6607 caused (substring ...) to crash on large vectors (Bug#8344).
6608 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6609 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6610 All variadic functions and their callers changed accordingly.
c5101a77
PE
6611 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6612 * data.c (arith_driver, float_arith_driver): Likewise.
6613 * editfns.c (general_insert_function): Likewise.
6614 * eval.c (struct backtrace.nargs, interactive_p)
6615 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6616 (funcall_lambda, mark_backtrace): Likewise.
6617 * fns.c (concat): Likewise.
6618 * frame.c (x_set_frame_parameters): Likewise.
6619 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6620 0 if not found, not -1. All callers changed.
6621
dd3f25f7
PE
6622 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6623 (stack_copy_size): Now size_t, not int.
6624 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6625
461c2ab9
JB
66262011-03-28 Juanma Barranquero <lekktu@gmail.com>
6627
6628 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6629 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6630 All callers changed.
6631
6632 * lisp.h (multibyte_char_to_unibyte):
6633 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6634 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6635 * character.h (CHAR_TO_BYTE8):
6636 * cmds.c (internal_self_insert):
6637 * editfns.c (general_insert_function):
6638 * keymap.c (push_key_description):
6639 * search.c (Freplace_match):
6640 * xdisp.c (message_dolog, set_message_1): All callers changed.
6641
f6d62986
SM
66422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6643
6644 * keyboard.c (safe_run_hook_funcall): New function.
6645 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6646 don't set the hook to nil, but remove the offending function instead.
6647 (Qcommand_hook_internal): Remove, unused.
6648 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6649 Vcommand_hook_internal.
6650
6651 * eval.c (enum run_hooks_condition): Remove.
6652 (funcall_nil, funcall_not): New functions.
6653 (run_hook_with_args): Call each function through a `funcall' argument.
6654 Remove `cond' argument, now redundant.
6655 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6656 (Frun_hook_with_args_until_failure): Adjust accordingly.
6657 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6658
1db5b1ad
JB
66592011-03-28 Juanma Barranquero <lekktu@gmail.com>
6660
6661 * dispextern.h (string_buffer_position): Remove declaration.
6662
6663 * print.c (strout): Remove parameter `multibyte', unused since
6664 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6665
6666 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6667 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6668 All callers changed.
6669
6670 * w32.c (_wsa_errlist): Use braces for struct initializers.
6671
6672 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6673 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6674 All callers changed.
6675 (string_buffer_position): Likewise. Also, make static (it's never
6676 used outside xdisp.c).
6677 (cursor_row_p): Remove parameter `w', unused since
6678 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6679 (decode_mode_spec): Remove parameter `precision', introduced during
6680 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6681 All callers changed.
6682
5ffb62aa
JD
66832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6684
6685 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6686
461c2ab9 66872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6688
6689 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6690 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6691 (ns_update_auto_hide_menu_bar): New functions.
6692 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6693 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6694 ns_constrain_all_frames.
6695 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6696 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6697
5c380ffb
JD
66982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6699
6700 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6701
9af30bdf
GM
67022011-03-27 Glenn Morris <rgm@gnu.org>
6703
6704 * syssignal.h: Replace RETSIGTYPE with void.
6705 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6706 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6707 Replace SIGTYPE with void everywhere.
6708 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6709 * s/template.h (SIGTYPE): Remove commented out definition.
6710
e2abce01
JB
67112011-03-26 Eli Zaretskii <eliz@gnu.org>
6712
6713 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6714 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6715
f868cd8a
JB
67162011-03-26 Juanma Barranquero <lekktu@gmail.com>
6717
59eb0929
JB
6718 * w32.c (read_unc_volume): Use parameter `henum', instead of
6719 global variable `wget_enum_handle'.
6720
6721 * keymap.c (describe_vector): Remove parameters `indices' and
6722 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6723 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6724
f868cd8a
JB
6725 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6726
6727 * keyboard.c (timer_check): Remove parameter `do_it_now',
6728 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6729 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6730 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6731
6732 * keyboard.c (read_char):
6733 * w32menu.c (w32_menu_display_help):
6734 * xmenu.c (show_help_event, menu_help_callback):
6735 Adjust calls to `show_help_echo'.
6736
6737 * gtkutil.c (xg_maybe_add_timer):
6738 * keyboard.c (readable_events):
6739 * process.c (wait_reading_process_output):
6740 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6741
6742 * insdel.c (adjust_markers_gap_motion):
6743 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6744 (gap_left, gap_right): Don't call it.
6745
2ecf6fdb
CY
67462011-03-25 Chong Yidong <cyd@stupidchicken.com>
6747
6748 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6749 incurred during fontification.
6750
6b1f9ba4
JB
67512011-03-25 Juanma Barranquero <lekktu@gmail.com>
6752
6753 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6754 (DEFVAR_PER_BUFFER): Don't pass it.
6755
6756 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6757 (scrolling_window): Don't pass it.
6758
0f4a96b5
JB
67592011-03-25 Juanma Barranquero <lekktu@gmail.com>
6760
6761 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6762
6763 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6764 and `suffix'.
6765 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6766 of variables specific to SELinux and computation of `encoded_absname'.
6767
6768 * image.c (XPutPixel): Remove unused variable `height'.
6769
6770 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6771
6772 * unexw32.c (get_section_info): Remove unused variable `section'.
6773
6774 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6775 (system_process_attributes): Remove unused variable `sess'.
6776 (sys_read): Remove unused variable `err'.
6777
6778 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6779 (w32_wnd_proc): Remove unused variable `isdead'.
6780 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6781 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6782 (x_create_tip_frame): Remove unused variable `tem'.
6783
6784 * w32inevt.c (w32_console_read_socket):
6785 Remove unused variable `no_events'.
6786
6787 * w32term.c (x_draw_composite_glyph_string_foreground):
6788 Remove unused variable `width'.
6789
1149507c
JB
67902011-03-24 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * w32term.c (x_set_glyph_string_clipping):
6793 Don't pass uninitialized region to CombineRgn.
6794
9c88f339
JB
67952011-03-23 Juanma Barranquero <lekktu@gmail.com>
6796
6797 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6798 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6799 (Fx_close_connection): Remove unused variable `i'.
6800
6801 * w32font.c (w32font_draw): Return number of glyphs.
6802 (w32font_open_internal): Remove unused variable `i'.
6803 (w32font_driver): Add missing initializer.
6804
6805 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6806 (fill_in_menu): Remove unused variable `items_added'.
6807
6808 * w32term.c (last_mouse_press_frame): Remove static global variable.
6809 (w32_clip_to_row): Remove unused variable `f'.
6810 (x_delete_terminal): Remove unused variable `i'.
6811
6812 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6813 (NOTHING): Remove unused static global variable.
6814 (uniscribe_check_otf): Remove unused variable `table'.
6815 (uniscribe_font_driver): Add missing initializers.
6816
dee091a3
JD
68172011-03-23 Julien Danjou <julien@danjou.info>
6818
6819 * term.c (Fsuspend_tty, Fresume_tty):
6820 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6821 * window.c (temp_output_buffer_show):
6822 * insdel.c (signal_before_change):
6823 * frame.c (Fhandle_switch_frame):
6824 * fileio.c (Fdo_auto_save):
6825 * emacs.c (Fkill_emacs):
6826 * editfns.c (save_excursion_restore):
6827 * cmds.c (internal_self_insert):
6828 * callint.c (Fcall_interactively):
6829 * buffer.c (Fkill_all_local_variables):
6830 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6831 Use Frun_hooks.
0f4a96b5 6832 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6833 unconditionnaly since it does the check itself.
6834
2c520ab5 68352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6836
c9c49752
PE
6837 Fix more problems found by GCC 4.5.2's static checks.
6838
8abc3f12
PE
6839 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6840 the first time through the loop, since we know p0 < p1 then.
6841 This also avoids a gcc -Wstrict-overflow warning.
6842
a2d26660
PE
6843 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6844 leading to a memory leak, possible in functions like
6845 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6846 of objects (Bug#8318).
a2d26660 6847
916c72e9
PE
6848 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6849 that could (at least in theory) be that large.
6850
19ab8a18
PE
6851 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6852 This is less likely to overflow, and avoids undefined behavior if
6853 overflow does occur. All callers changed. Use strtoul to scan
6854 for the unsigned long integer.
b7cbbd6f
PE
6855 (pint2hrstr): Simplify and tune code slightly.
6856 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6857
f0641eff
PE
6858 * scroll.c (do_scrolling): Work around GCC bug 48228.
6859 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6860
7f650bb9
PE
6861 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6862 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6863 (validate_x_resource_name): Simplify count usage.
6864 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6865
37dd57d1
PE
6866 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6867 fail (Bug#8306).
81e56e61 6868
699979fc 6869 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6870
401bf9b4
PE
6871 * process.c (Fmake_network_process): Use socklen_t, not int,
6872 where POSIX says socklen_t is required in portable programs.
6873 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6874 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6875 (Fmake_network_process, server_accept_connection):
6876 (wait_reading_process_output, read_process_output):
6877 Likewise.
6878
b93aacde
PE
6879 * process.c: Rename or move locals to avoid shadowing.
6880 (list_processes_1, Fmake_network_process):
6881 (read_process_output_error_handler, exec_sentinel_error_handler):
6882 Rename or move locals.
4dc343ee 6883 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6884 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6885 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6886 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6887 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6888
af8a867c 6889 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6890 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6891 Include tparam.h instead, since it declares them.
af8a867c
PE
6892 * cm.h (PC): Remove extern decl; tparam.h now does this.
6893 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6894 * terminfo.c: Include tparam.h, to check interfaces.
6895 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6896 (tparam): Adjust signature to match interface in tparam.h;
6897 this removes some undefined behavior. Check that outstring and len
6898 are zero, which they always are with Emacs.
6899 * tparam.h (PC, BC, UP): New extern decls.
6900
0248044d 6901 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6902 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6903
8ff096c1 6904 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6905 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6906 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6907 (ftfont_list): Remove unused local.
49eaafba
PE
6908 (get_adstyle_property, ftfont_pattern_entity):
6909 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6910 Rename locals to avoid shadowing.
8ff096c1 6911
e2be39f6
PE
6912 * xfont.c (xfont_list_family): Mark var as initialized.
6913
c9735e30
PE
6914 * xml.c (make_dom): Now static.
6915
8f5201ae
PE
6916 * composite.c (composition_compute_stop_pos): Rename local to
6917 avoid shadowing.
b246f932
PE
6918 (composition_reseat_it): Remove unused locals.
6919 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6920 (composition_update_it): Mark var as initialized.
11b61122
PE
6921 (find_automatic_composition): Mark vars as initialized,
6922 with a FIXME (Bug#8290).
8f5201ae 6923
760fbc2c
PE
6924 character.h: Rename locals to avoid shadowing.
6925 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6926 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6927 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6928 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6929 to avoid shadowing.
6930
ff08eb85
PE
6931 * textprop.c (property_change_between_p): Remove; unused.
6932
fc7bf025
PE
6933 * intervals.c (interval_start_pos): Now static.
6934
235d7abc
PE
6935 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6936
44f230aa
SM
6937 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6938 Rename locals to avoid shadowing.
3e7d6594 6939
50060332
PE
6940 * sound.c (wav_play, au_play, Fplay_sound_internal):
6941 Fix pointer signedness.
d01f234b 6942 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6943 (wav_play): Initialize a variable to 0, to prevent undefined
6944 behavior (Bug#8278).
50060332 6945
c4fc4e30
PE
6946 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6947
918436ed
PE
6948 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6949
c939f91b
PE
6950 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6951 clobbering (Bug#8298).
b9c7f648
PE
6952 * sysdep.c (sys_subshell): Likewise.
6953 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6954
6bd8c144
PE
6955 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6956 This should get cleaned up, so that child_setup has the
6957 same signature on all platforms.
6958
7710357c 6959 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6960 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6961
c59da222
CY
69622011-03-22 Chong Yidong <cyd@stupidchicken.com>
6963
6964 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6965 not to be necessary, and produces flickering.
6966
66b87493
GM
69672011-03-20 Glenn Morris <rgm@gnu.org>
6968
6969 * config.in: Remove file.
6970
45b6f6d5
JB
69712011-03-20 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6974 are now in src/globals.h.
6975 (syms_of_minibuf): Remove spurious & from previous change.
6976
3ec03f7e
LL
69772011-03-20 Leo <sdl.web@gmail.com>
6978
6979 * minibuf.c (completing-read-function): New variable.
6980 (completing-read-default): Rename from completing-read.
6981 (completing-read): Call completing-read-function.
6982
b14e3e21
CY
69832011-03-19 Juanma Barranquero <lekktu@gmail.com>
6984
6985 * xfaces.c (Fx_load_color_file):
6986 Read color file from absolute filename (bug#8250).
6987
f2b726e6
JB
69882011-03-19 Juanma Barranquero <lekktu@gmail.com>
6989
6990 * makefile.w32-in: Update dependencies.
6991
09f6ff02
EZ
69922011-03-17 Eli Zaretskii <eliz@gnu.org>
6993
6994 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6995
29a6015a
PE
69962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6997
a3a6c54e
PE
6998 Fix more problems found by GCC 4.5.2's static checks.
6999
b766f867
PE
7000 * process.c (make_serial_process_unwind, send_process_trap):
7001 (sigchld_handler): Now static.
7002
be02381c
PE
7003 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7004 That way, the code declares only the vars that it needs.
7005 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7006 * s/cygwin.h (PTY_ITERATION): Likewise.
7007 * s/darwin.h (PTY_ITERATION): Likewise.
7008 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7009
57048744
PE
7010 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7011 * process.c (allocate_pty): Don't declare stb unless it's needed.
7012
7914961c 7013 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7014 (CONSTANTLIM): Remove; unused.
7015 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7016 Define only if needed.
7914961c 7017
b3967b18
PE
7018 * unexelf.c (unexec): Name an expression,
7019 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7020 Use a different way to cause a compilation error if anyone uses
7021 n rather than nn, a way that does not involve shadowing.
73366a00 7022 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7023
29a6015a
PE
7024 * deps.mk (unexalpha.o): Remove; unused.
7025
43cfc33e 7026 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7027 * unexec.h: New file.
ce701a33
PE
7028 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7029 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7030 Depend on unexec.h.
7031 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7032 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7033 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7034 Change as necessary to match prototype in unexec.h.
ce701a33 7035
01f44d5a
PE
7036 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7037 shadowing.
4f63c6bb 7038 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7039
a6670b0b
PE
7040 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7041 Rename locals to avoid shadowing.
7042
cef2010d 7043 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7044 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7045
d4d7173a
PE
7046 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7047
f08b802a
PE
7048 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7049 warning when compiling print.c.
7050
3ddb0639
PE
7051 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7052 instead of using an uninitialized var.
5ad03b97 7053 (font_sort_entities): Mark var as initialized.
3ddb0639 7054
170a2692
PE
7055 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7056
e663c700
PE
7057 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7058 pointers to constants.
89bc529a 7059 (font_parse_fcname): Remove unused vars.
7b81e2d0 7060 (font_delete_unmatched): Now static.
ea838e10 7061 (font_get_spec): Remove; unused.
13a547c6
PE
7062 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7063 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7064 Rename or move locals to avoid shadowing.
e663c700 7065
2a80c887 7066 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7067 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7068
1384fa33 7069 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7070 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7071
8b2c52e9
PE
7072 * alloc.c (mark_backtrace): Move decl from here ...
7073 * lisp.h: ... to here, so that it can be checked.
7074
475545b5 7075 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7076 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7077 (lisp_indirect_variable): Name an expression,
7078 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7079 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7080
b1349114 7081 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7082 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7083 Use const pointer when appropriate.
b1349114 7084
a2928364
PE
7085 * lisp.h (get_system_name, get_operating_system_release):
7086 Move decls here, to check interfaces.
7087 * process.c (get_operating_system_release): Move decl to lisp.h.
7088 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7089 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7090 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7091 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7092 (Fformat_time_string, Fencode_time, Finsert_char):
7093 (Ftranslate_region_internal, Fformat):
7094 Rename or remove local vars to avoid shadowing.
9710023e 7095 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7096
a415e694
PE
7097 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7098 avoid shadowing.
7099
8ef4622d
PE
7100 * lisp.h (eassert): Check that the argument compiles, even if
7101 ENABLE_CHECKING is not defined.
7102
946f9a5b
PE
7103 * data.c (Findirect_variable): Name an expression, to avoid
7104 gcc -Wbad-function-cast warning.
112396d6 7105 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7106 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7107 (Fmake_variable_buffer_local, Fmake_local_variable):
7108 Mark variables as initialized.
52746918 7109 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7110
e5aab7e7 7111 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7112 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7113 Rename locals to avoid shadowing.
dff45157
PE
7114 (mark_stack): Move local variables into the #ifdef region where
7115 they're used.
7bc26fdb
PE
7116 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7117 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7118 needed otherwise.
7119 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7120 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7121 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7122
e5aab7e7
PE
7123 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7124 avoids undefined behavior in theory.
7125
4da60324
PE
7126 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7127
88043301
PE
7128 Use functions, not macros, for up- and down-casing (Bug#8254).
7129 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7130 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7131 to use the following functions instead of these macros.
7132 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7133 EMACS_INT, since callers assume the returned value fits in int.
7134 (upcase1): Likewise, for UPCASE_TABLE.
7135 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7136 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7137 the race-condition problem in the old DOWNCASE.
88043301 7138
19ed5445
PE
7139 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7140 Rename locals to avoid shadowing.
7141 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7142 (regex_compile, re_search_2, re_match_2_internal):
7143 Remove unused local vars.
952db0d7
PE
7144 (FREE_VAR): Rewrite so as not to use empty "else",
7145 which gcc can warn about.
da053e48 7146 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7147 (RETALLOC_IF): Define only if needed.
7148 (WORDCHAR_P): Likewise. This one is never needed, but is used
7149 only in a comment talking about a compiler bug, so put inside
7150 the #if 0 of that comment.
7151 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7152 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7153 Remove; unused.
19ed5445 7154
1f3561e4 7155 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7156 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7157 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7158
ded6f8f7
PE
7159 * search.c (simple_search): Remove unused var.
7160
dbd37a95
PE
7161 * dired.c (compile_pattern): Move decl from here ...
7162 * lisp.h: ... to here, so that it can be checked.
7163 (struct re_registers): New forward decl.
7164
7e47afad
PE
7165 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7166
85f24f61
PE
7167 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7168 All uses changed.
7169 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7170 Rename locals to avoid shadowing.
5671df8f 7171 (Fvertical_motion): Mark locals as initialized.
85f24f61 7172
181aa2be 7173 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7174 (casify_region): Mark local as initialized.
181aa2be 7175
930d429c
PE
7176 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7177
7082eac6
PE
7178 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7179 New macros, so that the caller can use some names other than
7180 gcpro1, gcpro2, etc.
7181 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7182 of the new macros.
7183 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7184 argument, for consistency with GCPRO2_VAR, etc: it is now the
7185 prefix of the variable, not the variable itself. All uses
7186 changed.
38b2c076
PE
7187 * dired.c (directory_files_internal, file_name_completion):
7188 Rename locals to avoid shadowing.
7189
15206ed9
PE
7190 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7191 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7192 dired.c's scmp function, had undefined behavior.
7193 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7194 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7195 * buffer.h: ... to here, because these macros use current_buffer,
7196 and the new implementation with inline functions needs to have
7197 current_buffer in scope now, rather than later when the macros
7198 are used.
7199 (downcase, upcase1): New static inline functions.
7200 (DOWNCASE, UPCASE1): Reimplement using these functions.
7201 This avoids undefined behavior in expressions like
7202 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7203 from race conditions in accessing the global variables
7204 case_temp1 and case_temp2.
7205 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7206 * lisp.h (case_temp1, case_temp2): Remove their decls.
7207 * character.h (ASCII_CHAR_P): Move from here ...
7208 * lisp.h: ... to here, so that the inline functions mentioned
7209 above can use them.
7210
4a6bea26
PE
7211 * dired.c (directory_files_internal_unwind): Now static.
7212
f14b7e14
PE
7213 * fileio.c (file_name_as_directory, directory_file_name):
7214 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7215 Now static.
2893f146
PE
7216 (file_name_as_directory): Use const pointers when appropriate.
7217 (Fexpand_file_name): Likewise. In particular, newdir might
7218 point at constant storage, so make it a const pointer.
fd4ead52 7219 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7220 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7221 signedness issues.
f839df0c
PE
7222 (Fset_file_times, Finsert_file_contents, auto_save_error):
7223 Rename locals to avoid shadowing.
f14b7e14 7224
5716756e 7225 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7226 (Ftry_completion, Fall_completions): Rename or remove locals
7227 to avoid shadowing.
5716756e 7228
b4c3046a
PE
7229 * marker.c (bytepos_to_charpos): Remove; unused.
7230
b45db522
PE
7231 * lisp.h (verify_bytepos, count_markers): New decls,
7232 so that gcc does not warn that these functions aren't declared.
7233
85876d07
PE
7234 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7235 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7236 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7237 (copy_text): Remove unused local var.
85876d07 7238
03d78a21 7239 * filelock.c (within_one_second): Now static.
b3dd38ab 7240 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7241
5df8f01b
PE
7242 * buffer.c (fix_overlays_before): Mark locals as initialized.
7243 (fix_start_end_in_overlays): Likewise. This function should be
7244 simplified by using pointers-to-pointers, but that's a different
7245 matter.
b1d876f1 7246 (switch_to_buffer_1): Now static.
8f54f30a
PE
7247 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7248 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7249
a70072c9 7250 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7251 Fix pointer signedness issue.
edced198
PE
7252 (sys_subshell): Mark local as volatile if checking for lint,
7253 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7254 (MAXPATHLEN): Define only if needed.
a70072c9 7255
a0977c44
PE
7256 * process.c (serial_open, serial_configure): Move decls from here ...
7257 * systty.h: ... to here, so that they can be checked.
7258
a884fdcc
PE
7259 * fns.c (get_random, seed_random): Move extern decls from here ...
7260 * lisp.h: ... to here, so that they can be checked.
7261
604efe86 7262 * sysdep.c (reset_io): Now static.
b8950c94 7263 (wait_for_termination_signal): Remove; unused.
604efe86 7264
38fc62d9
PE
7265 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7266 (copy_keymap_item, append_key, push_text_char_description):
7267 Now static.
1004a21a 7268 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7269 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7270 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7271 (describe_map_tree):
7272 Rename locals to avoid shadowing.
38fc62d9 7273
2f2650da
PE
7274 * keyboard.c: Declare functions static if they are not used elsewhere.
7275 (echo_char, echo_dash, cmd_error, top_level_2):
7276 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7277 (read_char, kbd_buffer_get_event, make_lispy_position):
7278 (make_lispy_event, make_lispy_movement, apply_modifiers):
7279 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7280 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7281 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7282 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7283 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7284
a053e86c 7285 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7286 (mark_kboards): Move decl here ...
7287 * alloc.c (mark_kboards): ... from here.
a053e86c 7288
4752793e
PE
7289 * lisp.h (force_auto_save_soon): New decl.
7290
74f10ca7 7291 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7292 (DEFINE_DUMMY_FUNCTION): New macro.
7293 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7294 Use it.
c03cd23f
PE
7295 (main): Add casts to avoid warnings
7296 if GCC considers string literals to be constants.
74f10ca7 7297
022e70d4
PE
7298 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7299
59d6fe83
PE
7300 * dbusbind.c: Pointer signedness fixes.
7301 (xd_signature, xd_append_arg, xd_initialize):
7302 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7303 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7304 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7305 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7306
78320123
PE
7307 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7308 if GCC considers string literals to be constants.
49cebcca 7309 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7310
35ac2a97
SM
73112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7312
fb103ca9
SM
7313 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7314 (print_preprocess, print_object): New macro to fix last change.
7315
35ac2a97
SM
7316 * print.c (print_preprocess): Don't forget font objects.
7317
62973b41
JB
73182011-03-16 Juanma Barranquero <lekktu@gmail.com>
7319
7320 * emacs.c (USAGE3): Doc fixes.
7321
0e48bb22
AS
73222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7323
7324 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7325 structure.
7326
7684e57b
JB
73272011-03-14 Juanma Barranquero <lekktu@gmail.com>
7328
7329 * lisp.h (VWindow_system, Qfile_name_history):
7330 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7331 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7332 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7333
7334 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7335 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7336
7337 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7338 * w32console.c (detect_input_pending, read_input_pending)
7339 (encode_terminal_code):
7340 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7341 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7342 (w32_system_caret_y, Qfile_name_history):
7343 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7344 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7345 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7346 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7347 * w32proc.c (Qlocal, report_file_error):
7348 * w32term.c (Vwindow_system, updating_frame):
7349 * w32uniscribe.c (initialized, uniscribe_font_driver):
7350 Remove unneeded extern declarations.
7351
2aa46d6c
CY
73522011-03-14 Chong Yidong <cyd@stupidchicken.com>
7353
c96bbc66 7354 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7355
cffc6f3b
CY
73562011-03-13 Chong Yidong <cyd@stupidchicken.com>
7357
7358 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7359 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7360 These macros can no longer be used for assignment.
7361
44f230aa
SM
7362 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7363 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7364 (record_buffer_markers, fetch_buffer_markers): New functions for
7365 recording and fetching special buffer markers.
7366 (set_buffer_internal_1, set_buffer_temp): Use them.
7367
7368 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7369
7370 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7371
7372 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7373 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7374
7375 * xdisp.c (hscroll_window_tree):
7376 (reconsider_clip_changes): Use PT instead of BUF_PT.
7377
d251f04b
EZ
73782011-03-13 Eli Zaretskii <eliz@gnu.org>
7379
7380 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7381 $(EMACS_ROOT)/lib/intprops.h.
7382
f0c77cd1
PE
73832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7384
3eca4629
PE
7385 Fix more problems found by GCC 4.5.2's static checks.
7386
7c86ee98
PE
7387 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7388 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7389 (xg_free_frame_widgets): Make it clear that a local variable is
7390 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7391 (gdk_window_get_screen): Make it clear that this macro is needed
7392 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7393 (int_gtk_range_get_value): New function, which avoids a diagnostic
7394 from gcc -Wbad-function-cast.
7395 (xg_set_toolkit_scroll_bar_thumb): Use it.
7396 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7397 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7398 (get_utf8_string, xg_get_file_with_chooser):
7399 Rename locals to avoid shadowing.
7400 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7401
41729b81
PE
7402 * xgselect.c (xg_select): Remove unused var.
7403
f0c77cd1
PE
7404 * image.c (four_corners_best): Mark locals as initialized.
7405 (gif_load): Initialize transparent_p to zero (Bug#8238).
7406 Mark another local as initialized.
ec6cf4c6 7407 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7408
ce0ad53d 7409 * image.c (clear_image_cache): Now static.
d5d5a617 7410 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7411 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7412 (x_edge_detection): Remove unnecessary cast that
7413 gcc -Wbad-function-cast diagnoses.
2037898d 7414 (gif_load): Fix pointer signedness.
6ae141d6
PE
7415 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7416 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7417
33383987 74182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7419
d32df629
PE
7420 Improve quality of tests for time stamp overflow.
7421 For example, without this patch (encode-time 0 0 0 1 1
7422 1152921504606846976) returns the obviously-bogus value (-948597
7423 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7424 reports time overflow. See
7425 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7426 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7427 * editfns.c: Include limits.h and intprops.h.
7428 (TIME_T_MIN, TIME_T_MAX): New macros.
7429 (time_overflow): Move earlier, to before first use.
7430 (hi_time, lo_time): New functions, for an accurate test for
7431 out-of-range times.
7432 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7433 (Fget_internal_run_time): Don't assume time_t fits in int.
7434 (make_time): Use list2 instead of Fcons twice.
7435 (Fdecode_time): More accurate test for out-of-range times.
7436 (check_tm_member): New function.
7437 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7438 (lisp_time_argument): Don't rely on undefined left-shift and
7439 right-shift behavior when checking for time stamp overflow.
8be6f318 7440
fe31d94c
PE
7441 * editfns.c (time_overflow): New function, refactoring common code.
7442 (Fformat_time_string, Fdecode_time, Fencode_time):
7443 (Fcurrent_time_string): Use it.
7444
8be6f318
PE
7445 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7446 * dired.c (make_time): Move to ...
7447 * editfns.c (make_time): ... here.
7448 * systime.h: Note the move.
7449
09d9db2c 74502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7451
126bc0dc
YM
7452 * fringe.c (update_window_fringes): Remove unused variables.
7453
c47cbdfd
YM
7454 * unexmacosx.c (copy_data_segment): Also copy __got section.
7455 (Bug#8223)
7456
7ac80be9
EZ
74572011-03-12 Eli Zaretskii <eliz@gnu.org>
7458
c96bbc66 7459 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7460 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7461 Constify `char *' arguments and their references according to
7462 prototypes in tparam.h.
7463
ecb0f94d 7464 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7465
7ac80be9
EZ
7466 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7467 Adapt all references accordingly.
7468
7469 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7470
ef1fd07e
TT
74712011-03-11 Tom Tromey <tromey@redhat.com>
7472
7473 * buffer.c (syms_of_buffer): Remove obsolete comment.
7474
7ef4b50c
EZ
74752011-03-11 Eli Zaretskii <eliz@gnu.org>
7476
7477 * termhooks.h (encode_terminal_code): Declare prototype.
7478
7479 * msdos.c (encode_terminal_code): Don't declare prototype.
7480
7481 * term.c (encode_terminal_code): Now external again, used by
7482 w32console.c and msdos.c.
7483
44f230aa
SM
7484 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7485 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7486
4b1ec863 74872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7488
1714f52b 7489 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7490
4b1ec863
PE
7491 * fringe.c (update_window_fringes): Mark locals as initialized
7492 (Bug#8227).
7493 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7494
524c7aa6
PE
7495 * alloc.c (mark_fringe_data): Move decl from here ...
7496 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7497 to check its interface.
7498 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7499
a5c0af81 7500 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7501 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7502 (fontset_font): Mark local as initialized.
a9a06e0b 7503 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7504
b4716021
PE
7505 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7506
811e9bac 7507 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7508 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7509 (x_own_selection, Fx_disown_selection_internal): Rename locals
7510 to avoid shadowing.
7511 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7512
7e3ab302
PE
7513 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7514 so that the caller can use some name other than gcpro1.
7515 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7516 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7517 (Fx_backspace_delete_keys_p):
7518 Use them to avoid shadowing, and rename vars to avoid shadowing.
7519 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7520 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7521 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7522 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7523 Remove unused locals.
7e3ab302
PE
7524 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7525 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7526 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7527 macros.
f78faa98 7528
e2b13473
PE
7529 * xterm.h (x_mouse_leave): New decl.
7530
77f23912
PE
7531 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7532 Remove unused functions.
cdf4ba58
PE
7533 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7534 (x_calc_absolute_position): Now static.
7411c686 7535 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7536 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7537 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7538 unless they are used.
38d0b34a
PE
7539 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7540 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7541 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7542 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7543 (x_error_catcher, x_connection_closed, x_error_handler):
7544 (x_error_quitter, xembed_send_message, x_iconify_frame):
7545 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7546 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7547 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7548
44f230aa
SM
7549 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7550 Rename or move locals to avoid shadowing.
6b463e58 7551 (tty_defined_color, merge_face_heights): Now static.
5967d051 7552 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7553 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7554 does not deduce is never used uninitialized.
73719eba
PE
7555 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7556 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7557
426994c3 7558 * terminal.c (store_terminal_param): Now static.
5489860b 7559
032f1620 7560 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7561 (set_frame_menubar): Remove unused local.
d4323972 7562 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7563 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7564 since they might point to immutable storage.
281585b0
PE
7565 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7566 since it's unused otherwise.
032f1620 7567
367c19e5 7568 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7569 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7570 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7571 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7572 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7573 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7574 does not deduce are never used uninitialized.
70739cbe 7575
07b48fa9
PE
7576 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7577
8868a238 7578 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7579 * window.c (window_loop, size_window):
7580 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7581
7e5cf297 7582 * window.c (display_buffer): Now static.
d6550a9f
PE
7583 (size_window): Mark variables that gcc -Wuninitialized
7584 does not deduce are never used uninitialized.
a586633d
PE
7585 * window.h (check_all_windows): New decl, to forestall
7586 gcc -Wmissing-prototypes diagnostic.
5b555da1 7587 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7588
f6095868
PE
7589 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7590 shadowing.
7591 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7592 Include <limits.h>.
7593 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7594 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7595 (load_charset_map): Mark variables that gcc -Wuninitialized
7596 does not deduce are never used uninitialized.
53df7c11 7597 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7598
f38b440c
PE
7599 * coding.c (coding_set_source, coding_set_destination):
7600 Use "else { /* comment */ }" rather than "else /* comment */;"
7601 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7602 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7603 a block, when the outer 'i' will do.
7604 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7605 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7606 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7607 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7608 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7609 Rename locals to avoid shadowing.
7610 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7611 * coding.c (emacs_mule_char, encode_invocation_designation):
7612 Now static, since they're not used elsewhere.
413bb2db 7613 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7614 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7615 (decode_coding_emacs_mule): Mark variables that gcc
7616 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7617 (detect_coding_iso_2022): Initialize a local variable that might
7618 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7619 this initialization is needed. (Bug#8211)
5f58e762
PE
7620 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7621 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7622 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7623 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7624 Remove unused macros.
f38b440c 7625
232b38b9 7626 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7627 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7628 * character.c (string_count_byte8): Likewise.
232b38b9 7629
fb90da1b
PE
7630 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7631 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7632
fb93dbc2
PE
7633 * chartab.c (copy_sub_char_table): Now static, since it's not used
7634 elsewhere.
5c156ace
PE
7635 (sub_char_table_ref_and_range, char_table_ref_and_range):
7636 Rename locals to avoid shadowing.
bbcd0949 7637 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7638
7d3b3862 7639 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7640 (BIDI_BOB): Remove unused macro.
7d3b3862 7641
6be7d3da
PE
7642 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7643 deduce are never used uninitialized.
c2ed9c8b 7644 * term.c (encode_terminal_code): Likewise.
6be7d3da 7645
75f8807f 7646 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7647
50938595
PE
7648 * tparam.h: New file.
7649 * term.c, tparam.h: Include it.
7650 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7651 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7652 Move these decls to tparam.h, and make them agree with what
7653 is actually in tparam.c. The previous trick of using incompatible
7654 decls in different modules does not conform to the C standard.
7655 All callers of tparam changed to use tparam's actual API.
7656 * tparam.c (tparam1, tparam, tgoto):
7657 Use const pointers where appropriate.
7658
fbceeba2
PE
7659 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7660 * cm.h (struct cm): Likewise.
7661 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7662 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7663 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7664 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7665 (turn_on_face, init_tty): Likewise.
7666 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7667
7f3f1250
PE
7668 * term.c (term_mouse_position): Rename local to avoid shadowing.
7669
e6ca6543
PE
7670 * alloc.c (mark_ttys): Move decl from here ...
7671 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7672
c40f8d15
AS
76732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7674
7675 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7676
cfe0661d
JB
76772011-03-09 Juanma Barranquero <lekktu@gmail.com>
7678
7679 * search.c (compile_pattern_1): Remove argument regp, unused since
7680 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7681 (compile_pattern): Don't pass it.
7682
0afb4571
J
76832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7684
7685 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7686 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7687 for ! HAVE_GTK3.
7688 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7689
7690 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7691
7692 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7693 gdk_window_get_screen, gdk_window_get_geometry,
7694 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7695 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7696 (xg_get_pixbuf_from_pixmap): New function.
7697 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7698 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7699 Call xg_get_pixbuf_from_pixmap instead of
7700 gdk_pixbuf_get_from_drawable.
7701 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7702 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7703 (xg_check_special_colors): Use GtkStyleContext and its functions
7704 for HAVE_GTK3.
7705 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7706 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7707 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7708 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7709 Call gtk_widget_get_preferred_size.
0afb4571
J
7710 (xg_frame_resized): gdk_window_get_geometry only takes 5
7711 parameters.
44f230aa
SM
7712 (xg_win_to_widget, xg_event_is_for_menubar):
7713 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7714 (xg_set_widget_bg): New function.
7715 (delete_cb): New function.
895009e1 7716 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7717 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7718 (xg_set_background_color): Call xg_set_widget_bg.
7719 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7720 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7721 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7722 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7723 if ! HAVE_GTK3.
7724 (update_frame_tool_bar): Call gtk_widget_hide.
7725 (xg_initialize): Use GDK_KEY_g.
7726
7727 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7728 if ! HAVE_GTK3
7729 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7730
7731 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7732 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7733 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7734
1c2cc4ef
JB
77352011-03-08 Juanma Barranquero <lekktu@gmail.com>
7736
7737 * w32xfns.c (select_palette): Check success of RealizePalette against
7738 GDI_ERROR, not zero.
7739
33383987 7740See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7741
7742;; Local Variables:
7743;; coding: utf-8
aac0c6e3
MR
7744;; End:
7745
33383987 7746 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7747
7748 This file is part of GNU Emacs.
7749
7750 GNU Emacs is free software: you can redistribute it and/or modify
7751 it under the terms of the GNU General Public License as published by
7752 the Free Software Foundation, either version 3 of the License, or
7753 (at your option) any later version.
7754
7755 GNU Emacs is distributed in the hope that it will be useful,
7756 but WITHOUT ANY WARRANTY; without even the implied warranty of
7757 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7758 GNU General Public License for more details.
7759
7760 You should have received a copy of the GNU General Public License
7761 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.